Timeline



Dec 8, 2012:

11:46 PM Changeset in webkit [137057] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/Tools

[CMake] Add CMake style checker
https://bugs.webkit.org/show_bug.cgi?id=104240

Patch by Halton Huo <halton.huo@intel.com> on 2012-12-08
Reviewed by Eric Seidel.

The CMake style checker is followed by existing style checkers like cpp, python.
Unit test is added as well.

  • Scripts/webkitpy/style/checker.py: Use CMakeChecker CMAKE type files(.cmake or CMakeLists.txt)

(FileType):
(CheckerDispatcher._file_type):
(CheckerDispatcher._create_checker):

  • Scripts/webkitpy/style/checkers/cmake.py: Added.

(CMakeChecker):
(CMakeChecker.init):
(CMakeChecker.check):
(CMakeChecker._process_line):
(CMakeChecker._check_trailing_whitespace):
(CMakeChecker._check_no_space_cmds):
(CMakeChecker._check_one_space_cmds):
(CMakeChecker._check_non_lowercase_cmd):
(CMakeChecker._check_indent):

  • Scripts/webkitpy/style/checkers/cmake_unittest.py: Added.

(CMakeCheckerTest):
(CMakeCheckerTest.test_init):
(CMakeCheckerTest.test_init._mock_handle_style_error):
(CMakeCheckerTest.test_check):
(CMakeCheckerTest.test_check._mock_handle_style_error):

9:48 PM Changeset in webkit [137056] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK1] Gardening for WebGL
https://bugs.webkit.org/show_bug.cgi?id=104464

Unreviewed, EFL gardening.

As EFL WK1 does not support WebGL, it should be skipped from layout tests.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-12-08

  • platform/efl-wk1/TestExpectations:
7:02 PM Changeset in webkit [137055] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Build break if SVG is disabled
https://bugs.webkit.org/show_bug.cgi?id=104452

Patch by Rakesh KN <rakeshchaitan@gmail.com> on 2012-12-08
Reviewed by Darin Adler.

Build breaking after r136975 if SVG is disabled.
No new tests required.

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter):
As document is not an argument anymore, removing UNUSED_PARAM against it.

  • rendering/FilterEffectRenderer.h:

Added forward declaration for RenderObject.

6:30 PM Changeset in webkit [137054] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

Compiling WTF outside of WebKit failed on Windows
https://bugs.webkit.org/show_bug.cgi?id=100201

Reviewed by Darin Adler.

Explicitly use the Unicode variants of the Windows API to
allow building the WTF library without the UNICODE define.

  • wtf/win/MainThreadWin.cpp:

(WTF::initializeMainThreadPlatform):

5:54 PM Changeset in webkit [137053] by mkwst@chromium.org
  • 15 edits in trunk

Log to console when script is blocked by sandbox attributes.
https://bugs.webkit.org/show_bug.cgi?id=104365

Reviewed by Ojan Vafai.

Source/WebCore:

Adds a console message to cover script execution blocked within the
context of a sandboxed frame which lacks the 'allow-scripts' permission.

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):

Log a warning when sandboxing flags block script execution.

LayoutTests:

  • fast/frames/sandboxed-iframe-attribute-parsing-expected.txt:
  • fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
  • fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
  • fast/frames/sandboxed-iframe-scripting-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
  • http/tests/security/contentSecurityPolicy/sandbox-invalid-header-expected.txt:
  • http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
  • http/tests/security/sandbox-inherit-to-initial-document-2-expected.txt:
  • media/video-controls-no-scripting-expected.txt:

Rebaselining tests with new expectations.

4:03 PM Changeset in webkit [137052] by tkent@chromium.org
  • 2 edits
    7 adds in trunk/LayoutTests

Add appearance tests for input[type=datetime-local]
https://bugs.webkit.org/show_bug.cgi?id=104439

Reviewed by Kentaro Hara.

  • fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.txt: Added.
  • fast/forms/datetimelocal/datetimelocal-appearance-basic.html: Added.
  • fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.txt: Added.
  • fast/forms/datetimelocal/datetimelocal-appearance-l10n.html: Added.
  • platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png: Added.
  • platform/chromium-mac/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:

Added.
The placeholder strings "yyyy" "mm" "dd" are expected to be
non-localized because they don't support
setLangAttributeAwareFormControlUIEnabled(true).
Note that sub-fields order of filled-outs input and empty inputs
in ar-eg and he-il locales are mismatched. It will be addressed in
webkit.org/b/104438.

  • platform/chromium/TestExpectations:
3:46 PM Changeset in webkit [137051] by commit-queue@webkit.org
  • 90 edits
    38 copies
    20 adds in trunk

Use background color for GraphicsLayers when applicable
https://bugs.webkit.org/show_bug.cgi?id=103786

Source/WebCore:

Updated RenderLayerBacking to call GraphicsLayer::setContentsToBackgroundColor when the following conditions take place:

  1. The layer doesn't paint its own content, other than background/decoration.
  2. There are no borders or other box decorations (border radius, borders, outline, shadow etc.)
  3. The image has only a background color, and no background image.
  4. background-composite is set to source-over, and background-clip is anything apart from text.
  5. The port supports setContentsToBackgroundColor.

This allows any implementation of GraphicsLayer that supports setContentsToBackgroundColor to avoid allocating a backing store
for that layer, but instead draw that solid color directly.
In addition to setting the background color, the layer's contentsRect needs to be adjusted, since the default contents rect of
a layer is not always equivalent to the rect where the background is supposed to be painted, which is derived from the box's
background-clip property.

Patch by No'am Rosenthal <Noam Rosenthal> on 2012-12-08
Reviewed by Simon Fraser.

Tests: compositing/background-color/background-color-alpha.html

compositing/background-color/background-color-change-to-text.html
compositing/background-color/background-color-composite.html
compositing/background-color/background-color-container.html
compositing/background-color/background-color-content-clip.html
compositing/background-color/background-color-padding-change.html
compositing/background-color/background-color-padding-clip.html
compositing/background-color/background-color-simple.html
compositing/background-color/background-color-text-change.html
compositing/background-color/background-color-text-clip.html

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::supportsBackgroundColorContent):

Allows different implementation of GraphicsLayer to identify whether they implement setContentsToBackgroundColor.
Currently only the MAC implementation and TextureMapper falls under that category.

  • rendering/RenderBox.h:

(WebCore::RenderBox::paddingBoxRect):

Added paddingBoxRect to compliment borderBoxRect and contentsBoxRect. paddingBoxRect corresponds to
background-clip: padding.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):

Update the background color if needed, for every configuration change.
This should accomodate the old behavior for full-screen, while enabling background color changes for other layers.

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

Move the contentsRect logic to updateContentsRect.

(WebCore::RenderLayerBacking::updateContentsRect):

Use the background box when directly compositing backgrounds.

(WebCore::RenderLayerBacking::updateBackgroundColor):

Set the background color if applicable, otherwise set to trasnparent and clear.
This was not needed in the past because background colors were only used for the special case of full-screen.

(WebCore::supportsDirectBoxDecorationsComposition):

Helper function to determine whether a particular background can be directly composited. Right now only
background color can be composited, and only if the GraphicsLayer implementation supports background colors.
Also we don't yet support background-clip: text and any background-composite other than source-over.

(WebCore::RenderLayerBacking::paintsBoxDecorations):

Apply the new supportsDirectBoxDecorationsComposition logic.

(WebCore::RenderLayerBacking::contentsBox):

Remove unnecessary local variable.

(WebCore::backgroundRectForBox):
(WebCore::RenderLayerBacking::backgroundBox):

Figure out the correct rect for the GraphicsLayer's contentsRect, based on the renderer's backgroundClip.
The rectangle has to be adjusted based on the composited layer offset, and snapped to an IntRect as
GraphicsLayer::contentsRect expects snapped pixels.

LayoutTests:

Created new tests for composited background colors, update existing tests that are affected by the change,
and created platform-specific overrides for Chromium, since it does not yet support composited background
colors.

Patch by No'am Rosenthal <Noam Rosenthal> on 2012-12-08
Reviewed by Simon Fraser.

  • compositing/background-color/background-color-alpha-expected.html: Added.
  • compositing/background-color/background-color-alpha.html: Added.
  • compositing/background-color/background-color-change-to-text-expected.html: Added.
  • compositing/background-color/background-color-change-to-text.html: Added.
  • compositing/background-color/background-color-composite-expected.html: Added.
  • compositing/background-color/background-color-composite.html: Added.
  • compositing/background-color/background-color-container-expected.html: Added.
  • compositing/background-color/background-color-container.html: Added.
  • compositing/background-color/background-color-content-clip-expected.html: Added.
  • compositing/background-color/background-color-content-clip.html: Added.
  • compositing/background-color/background-color-padding-change-expected.html: Added.
  • compositing/background-color/background-color-padding-change.html: Added.
  • compositing/background-color/background-color-padding-clip-expected.html: Added.
  • compositing/background-color/background-color-padding-clip.html: Added.
  • compositing/background-color/background-color-simple-expected.html: Added.
  • compositing/background-color/background-color-simple.html: Added.
  • compositing/background-color/background-color-text-change-expected.html: Added.
  • compositing/background-color/background-color-text-change.html: Added.
  • compositing/background-color/background-color-text-clip-expected.html: Added.
  • compositing/background-color/background-color-text-clip.html: Added.

Added new tests for the specific functionality added, with the edge cases regarding composited
backgrounds.

  • compositing/backing/no-backing-for-clip-expected.txt:
  • compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • compositing/backing/no-backing-for-perspective-expected.txt:
  • compositing/columns/composited-in-paginated-expected.txt:
  • compositing/geometry/ancestor-overflow-change-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • compositing/geometry/clip-expected.txt:
  • compositing/geometry/composited-in-columns-expected.txt:
  • compositing/geometry/flipped-writing-mode-expected.txt:
  • compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
  • compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
  • compositing/geometry/preserve-3d-switching-expected.txt:
  • compositing/iframes/become-composited-nested-iframes-expected.txt:
  • compositing/iframes/become-overlapped-iframe-expected.txt:
  • compositing/iframes/composited-parent-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • compositing/iframes/connect-compositing-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe2-expected.txt:
  • compositing/iframes/connect-compositing-iframe3-expected.txt:
  • compositing/iframes/enter-compositing-iframe-expected.txt:
  • compositing/iframes/iframe-resize-expected.txt:
  • compositing/iframes/invisible-nested-iframe-hide-expected.txt:
  • compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • compositing/iframes/overlapped-iframe-expected.txt:
  • compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • compositing/iframes/page-cache-layer-tree-expected.txt:
  • compositing/iframes/scrolling-iframe-expected.txt:
  • compositing/layer-creation/animation-overlap-with-children-expected.txt:
  • compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • compositing/layer-creation/overflow-scroll-overlap-expected.txt:
  • compositing/layer-creation/overlap-animation-expected.txt:
  • compositing/layer-creation/overlap-child-layer-expected.txt:
  • compositing/layer-creation/overlap-clipping-expected.txt:
  • compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
  • compositing/layer-creation/overlap-transformed-layer-expected.txt:
  • compositing/layer-creation/overlap-transforms-expected.txt:
  • compositing/layer-creation/scroll-partial-update-expected.txt:
  • compositing/layer-creation/spanOverlapsCanvas-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
  • compositing/layer-creation/translatez-overlap-expected.txt:
  • compositing/overflow-trumps-transform-style-expected.txt:
  • compositing/overflow/clip-descendents-expected.txt:
  • compositing/plugins/no-backing-store-expected.txt:
  • compositing/rtl/rtl-absolute-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-fixed-expected.txt:
  • compositing/rtl/rtl-fixed-overflow-expected.txt:
  • compositing/rtl/rtl-relative-expected.txt:
  • compositing/tiled-layers-hidpi-expected.txt:
  • compositing/visible-rect/2d-transformed-expected.txt:
  • compositing/visible-rect/3d-transform-style-expected.txt:
  • compositing/visible-rect/3d-transformed-expected.txt:
  • compositing/visible-rect/animated-expected.txt:
  • compositing/visible-rect/animated-from-none-expected.txt:
  • compositing/visible-rect/clipped-by-viewport-expected.txt:
  • compositing/visible-rect/clipped-visible-rect-expected.txt:
  • compositing/visible-rect/iframe-and-layers-expected.txt:
  • compositing/visible-rect/nested-transform-expected.txt:
  • compositing/visible-rect/scrolled-expected.txt:
  • css3/filters/filtered-compositing-descendant-expected.txt:

Updated existing tests that now print different layer-tree results.

  • platform/chromium/compositing/backing/no-backing-for-clip-expected.txt: Copied from LayoutTests/compositing/backing/no-backing-for-clip-expected.txt.
  • platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt: Copied from LayoutTests/compositing/backing/no-backing-for-clip-overlap-expected.txt.
  • platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt: Copied from LayoutTests/compositing/backing/no-backing-for-perspective-expected.txt.
  • platform/chromium/compositing/columns/composited-in-paginated-expected.txt: Copied from LayoutTests/compositing/columns/composited-in-paginated-expected.txt.
  • platform/chromium/compositing/geometry/ancestor-overflow-change-expected.txt: Copied from LayoutTests/compositing/geometry/ancestor-overflow-change-expected.txt.
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Copied from LayoutTests/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt.
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Copied from LayoutTests/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt.
  • platform/chromium/compositing/geometry/clip-expected.txt: Copied from LayoutTests/compositing/geometry/clip-expected.txt.
  • platform/chromium/compositing/geometry/composited-in-columns-expected.txt: Copied from LayoutTests/compositing/geometry/composited-in-columns-expected.txt.
  • platform/chromium/compositing/geometry/flipped-writing-mode-expected.txt: Copied from LayoutTests/compositing/geometry/flipped-writing-mode-expected.txt.
  • platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Copied from LayoutTests/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt.
  • platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt.
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-positioned-expected.txt.
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt.
  • platform/chromium/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-transformed-expected.txt.
  • platform/chromium/compositing/geometry/preserve-3d-switching-expected.txt: Copied from LayoutTests/compositing/geometry/preserve-3d-switching-expected.txt.
  • platform/chromium/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Copied from LayoutTests/compositing/iframes/invisible-nested-iframe-hide-expected.txt.
  • platform/chromium/compositing/layer-creation/fixed-position-and-transform-expected.txt: Copied from LayoutTests/compositing/layer-creation/fixed-position-and-transform-expected.txt.
  • platform/chromium/compositing/layer-creation/fixed-position-under-transform-expected.txt: Copied from LayoutTests/compositing/layer-creation/fixed-position-under-transform-expected.txt.
  • platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Copied from LayoutTests/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-animation-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-animation-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-child-layer-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-child-layer-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-clipping-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-clipping-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-transformed-layer-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-transformed-layer-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-transforms-expected.txt.
  • platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt: Copied from LayoutTests/compositing/layer-creation/scroll-partial-update-expected.txt.
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-expected.txt: Copied from LayoutTests/compositing/layer-creation/stacking-context-overlap-expected.txt.
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Copied from LayoutTests/compositing/layer-creation/stacking-context-overlap-nested-expected.txt.
  • platform/chromium/compositing/layer-creation/translatez-overlap-expected.txt: Copied from LayoutTests/compositing/layer-creation/translatez-overlap-expected.txt.
  • platform/chromium/compositing/overflow-trumps-transform-style-expected.txt: Copied from LayoutTests/compositing/overflow-trumps-transform-style-expected.txt.
  • platform/chromium/compositing/rtl/rtl-absolute-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-absolute-expected.txt.
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-absolute-overflow-expected.txt.
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt.
  • platform/chromium/compositing/rtl/rtl-fixed-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-fixed-expected.txt.
  • platform/chromium/compositing/rtl/rtl-fixed-overflow-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-fixed-overflow-expected.txt.
  • platform/chromium/compositing/rtl/rtl-relative-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-relative-expected.txt.
  • platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt: Copied from LayoutTests/css3/filters/filtered-compositing-descendant-expected.txt.

Create chromium-specific results since chromium does not yet support setContentsToBackgroundColor.

3:13 PM Changeset in webkit [137050] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL] Enable WebGL by default.
https://bugs.webkit.org/show_bug.cgi?id=102991.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-08
Reviewed by Kenneth Rohde Christiansen.

Tools:

Enable WebGL by default.

  • Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Update TestExpectations file to enable WebGL tests.

  • platform/efl/TestExpectations:
3:07 PM Changeset in webkit [137049] by zhajiang@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Google results page rendering issue with RTL languages like arabic/hebrew
https://bugs.webkit.org/show_bug.cgi?id=104451

Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.

PR: 206372
On Google results page, we layout the contents at the width of 833.
However, "appbar" and "top_nav" elements which have width 980 cause
overflow during the last layout and make the contents width larger.
The other renderers still stay at the old width unfortunately which
results in blank areas on the left side of the Google results RTL page.
Give it a chance to request another layout if overflow exceeds the
contents size and the page doesn't have virtual viewport, as this
layout will pick up the absolute visible overflow width within
DEFAULT_MAX_LAYOUT_WIDTH and update the other renderers.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::overflowExceedsContentsSize):
(WebKit):

  • Api/WebPage_p.h:

(WebPagePrivate):

1:47 PM Changeset in webkit [137048] by Patrick Gansterer
  • 7 edits in trunk/Source/WebCore

Build fix for WinCE after r137011.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):
(WebCore::GraphicsContext::drawBitmap):

  • platform/graphics/wince/ImageBufferWinCE.cpp:

(WebCore::BufferedImage::draw):
(WebCore::ImageBuffer::draw):

  • platform/graphics/wince/ImageWinCE.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
(WebCore::BitmapImage::draw):

  • platform/graphics/wince/SharedBitmap.cpp:

(WebCore::SharedBitmap::draw):

  • platform/graphics/wince/SharedBitmap.h:
1:19 PM Changeset in webkit [137047] by gavinp@chromium.org
  • 1 edit in trunk/Source/WebCore/loader/LinkLoader.cpp

Unreviewed. Fix build after r137045 for !ENABLE(LINK_PRERENDER) platforms.

A new guard was needed.

I am sorry.

12:34 PM Changeset in webkit [137046] by mifenton@rim.com
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Enforce selection of last work when triggering caret based selection
https://bugs.webkit.org/show_bug.cgi?id=104447

Reviewed by Rob Buis.

PR 249225.

When the selection has reached the end of an input field,
ensure the last word is selected by adjusting the caret.

Reviewed Internally by Gen Mak.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::isCaretAtEndOfText):
(WebKit):

  • WebKitSupport/InputHandler.h:

(InputHandler):

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectObject):

12:03 PM Changeset in webkit [137045] by gavinp@chromium.org
  • 26 edits
    1 copy
    4 adds in trunk/Source

Add status events on <link rel=prerender> elements.
https://bugs.webkit.org/show_bug.cgi?id=96474

Reviewed by Adam Barth.

The new PrerenderStatusEvent is sent to link elements when
prerenders are started by the embedder, and also sent when they
are stopped. Pages using this feature can now serialize launching
prerenders, and track timing performance.

Source/Platform:

  • chromium/public/WebPrerender.h:

(WebKit::WebPrerender::WebPrerender):
(WebKit::WebPrerender::operator=):
(WebPrerender):

Source/WebCore:

Tested in a new WebKitUnitTest for the chromium port.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/EventNames.h:

(WebCore):

  • html/HTMLLinkElement.cpp:

(WebCore):
(WebCore::HTMLLinkElement::didStartLinkPrerender):
(WebCore::HTMLLinkElement::didStopLinkPrerender):
(WebCore::HTMLLinkElement::didSendLoadForLinkPrerender):
(WebCore::HTMLLinkElement::didSendDOMContentLoadedForLinkPrerender):

  • html/HTMLLinkElement.h:

(HTMLLinkElement):

  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::didStartPrerender):
(WebCore):
(WebCore::LinkLoader::didStopPrerender):
(WebCore::LinkLoader::didSendLoadForPrerender):
(WebCore::LinkLoader::didSendDOMContentLoadedForPrerender):
(WebCore::LinkLoader::loadLink):

  • loader/LinkLoader.h:

(LinkLoader):

  • loader/LinkLoaderClient.h:

(LinkLoaderClient):

  • loader/Prerenderer.cpp:

(WebCore::Prerenderer::render):

  • loader/Prerenderer.h:

(WebCore):
(Prerenderer):

  • platform/PrerenderClient.h: Copied from Source/WebCore/loader/LinkLoaderClient.h.

(WebCore):
(PrerenderClient):
(WebCore::PrerenderClient::~PrerenderClient):

  • platform/PrerenderHandle.h:

(WebCore):
(PrerenderHandle):

  • platform/chromium/Prerender.cpp:

(WebCore::Prerender::Prerender):
(WebCore::Prerender::removeClient):
(WebCore):
(WebCore::Prerender::add):
(WebCore::Prerender::cancel):
(WebCore::Prerender::abandon):
(WebCore::Prerender::didStartPrerender):
(WebCore::Prerender::didStopPrerender):
(WebCore::Prerender::didSendLoadForPrerender):
(WebCore::Prerender::didSendDOMContentLoadedForPrerender):

  • platform/chromium/Prerender.h:

(WebKit):
(WebCore):
(Prerender):

  • platform/chromium/PrerenderHandle.cpp:

(WebCore::PrerenderHandle::create):
(WebCore::PrerenderHandle::PrerenderHandle):
(WebCore::PrerenderHandle::~PrerenderHandle):
(WebCore::PrerenderHandle::removeClient):
(WebCore):

  • platform/chromium/support/WebPrerender.cpp:

(WebKit::WebPrerender::toPrerender):
(WebKit):
(WebKit::WebPrerender::assign):
(WebKit::WebPrerender::isNull):
(WebKit::WebPrerender::didStartPrerender):
(WebKit::WebPrerender::didStopPrerender):
(WebKit::WebPrerender::didSendLoadForPrerender):
(WebKit::WebPrerender::didSendDOMContentLoadedForPrerender):

Source/WebKit/chromium:

  • WebKit.gyp:
  • WebKit.gypi:
  • tests/FrameTestHelpers.cpp:

(WebKit::FrameTestHelpers::createWebView):
(FrameTestHelpers):
(WebKit::FrameTestHelpers::createWebViewAndLoad):

  • tests/FrameTestHelpers.h:

(FrameTestHelpers):

  • tests/PrerenderingTest.cpp: Added.
  • tests/data/prerender/multiple_prerenders.html: Added.
  • tests/data/prerender/single_prerender.html: Added.
11:42 AM Changeset in webkit [137044] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore

Reviewed by Martin Robinson.

Update the Chromium/Chrome version we advertise in our User-Agent
string to version 25, to better match our current reality.

  • platform/gtk/UserAgentGtk.cpp:

(WebCore::standardUserAgent):

11:18 AM Changeset in webkit [137043] by kov@webkit.org
  • 1 edit in releases/WebKitGTK/webkit-1.10/Source/WebKit/gtk/webkit/webkitwebsettings.cpp

Update the Chromium version we expose in our User-Agent to match the stable one used when we branched

11:18 AM Changeset in webkit [137042] by kov@webkit.org
  • 3 edits
    3 adds in releases/WebKitGTK/webkit-1.10

Merge 133155 - SVG as an image may recreate the renderer on zoom
https://bugs.webkit.org/show_bug.cgi?id=99508

Reviewed by Abhishek Arya.

Source/WebCore:

The SVGImage code, when SVG is used in <img> tags, caches the renderer
at the start of the painting method and re-uses the pointer at the end
of the method. However, when the page is zoomed the renderer may be
detached mid-method, thus leaving a stray pointer. The fix is to
re-fetch the pointer after the zooms.

Test: svg/as-image/img-zoom-svg-stylesheet.html

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer): Re-fetch the renderer after
the zoom operations.

LayoutTests:

Test and ref-test-result for zooming of SVG content when loaded as-image, and the svg is actually a css file.

  • svg/as-image/img-zoom-svg-stylesheet-expected.html: Added.
  • svg/as-image/img-zoom-svg-stylesheet.html: Added.
  • svg/as-image/resources/svg-stylesheet-for-zoom.svg: Added.
10:27 AM Changeset in webkit [137041] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove about:credits
https://bugs.webkit.org/show_bug.cgi?id=104399

Patch by Chris Hutten-Czapski <chutten@rim.com> on 2012-12-08
Reviewed by Rob Buis.

Just a simple removal.

  • WebKitSupport/AboutData.cpp:
10:10 AM Changeset in webkit [137040] by kov@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

[as_IN] New translation for WebKitGTK+
https://bugs.webkit.org/show_bug.cgi?id=103419

Patch by Nilamdyuti Goswami <nilamdyuti@gmail.com> on 2012-12-08
Rubber-stamped by Gustavo Noronha.

  • as.po: Added.
9:59 AM Changeset in webkit [137039] by commit-queue@webkit.org
  • 90 edits
    58 deletes in trunk

Unreviewed, rolling out r137006.
http://trac.webkit.org/changeset/137006
https://bugs.webkit.org/show_bug.cgi?id=104446

Broke plugin painting on Mac (youtube, etc.) (Requested by
thorton_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-08

Source/WebCore:

  • platform/graphics/GraphicsLayer.h:

(GraphicsLayer):

  • rendering/RenderBox.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):
(WebCore::clipBox):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::updateDrawsContent):
(WebCore::RenderLayerBacking::updateBackgroundColor):
(WebCore::RenderLayerBacking::paintsBoxDecorations):
(WebCore::RenderLayerBacking::contentChanged):
(WebCore::RenderLayerBacking::updateImageContents):
(WebCore::RenderLayerBacking::contentsBox):

  • rendering/RenderLayerBacking.h:

(RenderLayerBacking):

LayoutTests:

  • compositing/background-color/background-color-alpha-expected.html: Removed.
  • compositing/background-color/background-color-alpha.html: Removed.
  • compositing/background-color/background-color-change-to-text-expected.html: Removed.
  • compositing/background-color/background-color-change-to-text.html: Removed.
  • compositing/background-color/background-color-composite-expected.html: Removed.
  • compositing/background-color/background-color-composite.html: Removed.
  • compositing/background-color/background-color-container-expected.html: Removed.
  • compositing/background-color/background-color-container.html: Removed.
  • compositing/background-color/background-color-content-clip-expected.html: Removed.
  • compositing/background-color/background-color-content-clip.html: Removed.
  • compositing/background-color/background-color-padding-change-expected.html: Removed.
  • compositing/background-color/background-color-padding-change.html: Removed.
  • compositing/background-color/background-color-padding-clip-expected.html: Removed.
  • compositing/background-color/background-color-padding-clip.html: Removed.
  • compositing/background-color/background-color-simple-expected.html: Removed.
  • compositing/background-color/background-color-simple.html: Removed.
  • compositing/background-color/background-color-text-change-expected.html: Removed.
  • compositing/background-color/background-color-text-change.html: Removed.
  • compositing/background-color/background-color-text-clip-expected.html: Removed.
  • compositing/background-color/background-color-text-clip.html: Removed.
  • compositing/backing/no-backing-for-clip-expected.txt:
  • compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • compositing/backing/no-backing-for-perspective-expected.txt:
  • compositing/columns/composited-in-paginated-expected.txt:
  • compositing/geometry/ancestor-overflow-change-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • compositing/geometry/clip-expected.txt:
  • compositing/geometry/composited-in-columns-expected.txt:
  • compositing/geometry/flipped-writing-mode-expected.txt:
  • compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
  • compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
  • compositing/geometry/preserve-3d-switching-expected.txt:
  • compositing/iframes/become-composited-nested-iframes-expected.txt:
  • compositing/iframes/become-overlapped-iframe-expected.txt:
  • compositing/iframes/composited-parent-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • compositing/iframes/connect-compositing-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe2-expected.txt:
  • compositing/iframes/connect-compositing-iframe3-expected.txt:
  • compositing/iframes/enter-compositing-iframe-expected.txt:
  • compositing/iframes/iframe-resize-expected.txt:
  • compositing/iframes/invisible-nested-iframe-hide-expected.txt:
  • compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • compositing/iframes/overlapped-iframe-expected.txt:
  • compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • compositing/iframes/page-cache-layer-tree-expected.txt:
  • compositing/iframes/scrolling-iframe-expected.txt:
  • compositing/layer-creation/animation-overlap-with-children-expected.txt:
  • compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • compositing/layer-creation/overflow-scroll-overlap-expected.txt:
  • compositing/layer-creation/overlap-animation-expected.txt:
  • compositing/layer-creation/overlap-child-layer-expected.txt:
  • compositing/layer-creation/overlap-clipping-expected.txt:
  • compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
  • compositing/layer-creation/overlap-transformed-layer-expected.txt:
  • compositing/layer-creation/overlap-transforms-expected.txt:
  • compositing/layer-creation/scroll-partial-update-expected.txt:
  • compositing/layer-creation/spanOverlapsCanvas-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
  • compositing/layer-creation/translatez-overlap-expected.txt:
  • compositing/overflow-trumps-transform-style-expected.txt:
  • compositing/overflow/clip-descendents-expected.txt:
  • compositing/overflow/content-gains-scrollbars-expected.txt:
  • compositing/overflow/overflow-scrollbar-layers-expected.txt:
  • compositing/overflow/resize-painting-expected.txt:
  • compositing/plugins/no-backing-store-expected.txt:
  • compositing/rtl/rtl-absolute-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-fixed-expected.txt:
  • compositing/rtl/rtl-fixed-overflow-expected.txt:
  • compositing/rtl/rtl-relative-expected.txt:
  • compositing/tiled-layers-hidpi-expected.txt:
  • compositing/visible-rect/2d-transformed-expected.txt:
  • compositing/visible-rect/3d-transform-style-expected.txt:
  • compositing/visible-rect/3d-transformed-expected.txt:
  • compositing/visible-rect/animated-expected.txt:
  • compositing/visible-rect/animated-from-none-expected.txt:
  • compositing/visible-rect/clipped-by-viewport-expected.txt:
  • compositing/visible-rect/clipped-visible-rect-expected.txt:
  • compositing/visible-rect/iframe-and-layers-expected.txt:
  • compositing/visible-rect/nested-transform-expected.txt:
  • compositing/visible-rect/scrolled-expected.txt:
  • css3/filters/filtered-compositing-descendant-expected.txt:
  • platform/chromium/compositing/backing/no-backing-for-clip-expected.txt: Removed.
  • platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt: Removed.
  • platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt: Removed.
  • platform/chromium/compositing/columns/composited-in-paginated-expected.txt: Removed.
  • platform/chromium/compositing/geometry/ancestor-overflow-change-expected.txt: Removed.
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Removed.
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Removed.
  • platform/chromium/compositing/geometry/clip-expected.txt: Removed.
  • platform/chromium/compositing/geometry/composited-in-columns-expected.txt: Removed.
  • platform/chromium/compositing/geometry/flipped-writing-mode-expected.txt: Removed.
  • platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Removed.
  • platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Removed.
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Removed.
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Removed.
  • platform/chromium/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Removed.
  • platform/chromium/compositing/geometry/preserve-3d-switching-expected.txt: Removed.
  • platform/chromium/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/fixed-position-and-transform-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/fixed-position-under-transform-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/overlap-animation-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/overlap-child-layer-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/overlap-clipping-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/overlap-transformed-layer-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Removed.
  • platform/chromium/compositing/layer-creation/translatez-overlap-expected.txt: Removed.
  • platform/chromium/compositing/overflow-trumps-transform-style-expected.txt: Removed.
  • platform/chromium/compositing/overflow/content-gains-scrollbars-expected.txt:
  • platform/chromium/compositing/overflow/overflow-scrollbar-layers-expected.txt:
  • platform/chromium/compositing/overflow/resize-painting-expected.txt:
  • platform/chromium/compositing/rtl/rtl-absolute-expected.txt: Removed.
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-expected.txt: Removed.
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Removed.
  • platform/chromium/compositing/rtl/rtl-fixed-expected.txt: Removed.
  • platform/chromium/compositing/rtl/rtl-fixed-overflow-expected.txt: Removed.
  • platform/chromium/compositing/rtl/rtl-relative-expected.txt: Removed.
  • platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
  • platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt:
  • platform/mac/compositing/iframes/resizer-expected.txt:
  • platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
  • platform/mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
9:42 AM Changeset in webkit [137038] by kov@webkit.org
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-1.10

Merge 132856 - feImage should not be allowed to self reference
https://bugs.webkit.org/show_bug.cgi?id=94652

Reviewed by Eric Seidel.

Source/WebCore:

Add cycle detection for SVG filter application, and also fix a problem
with graphics context restore when filters are applied. This also
converts the flags in FilterData to a state tracking system, as the
number of flags was getting messy and only one flag is valid at any given time.

Test: svg/filters/feImage-self-and-other-referencing.html

  • rendering/svg/RenderSVGResourceFilter.cpp: Convert to new FilterData

state management and enable cycle detection.
(WebCore):
(WebCore::RenderSVGResourceFilter::removeClientFromCache): Change isBuilt and markedForRemoval flags to state enums.
(WebCore::RenderSVGResourceFilter::applyResource): Change flags to state enums and detect cycles.
(WebCore::RenderSVGResourceFilter::postApplyResource): Change flags to state and add handling
for the various states.
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged): Change isBuilt flag to state enums.

  • rendering/svg/RenderSVGResourceFilter.h:

(WebCore::FilterData::FilterData):
(FilterData): Convert to a state tracking system.

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced): Add a block around the
SVGRenderingContext so that it applies the filter and reverts the
context before the calling method restores the context.

LayoutTests:

Additional test case for situations when the filter is applied to multiple objects that it also references.

  • svg/filters/feImage-self-and-other-referencing-expected.html: Added.
  • svg/filters/feImage-self-and-other-referencing.html: Added.

Conflicts:

Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp
Source/WebCore/rendering/svg/RenderSVGResourceFilter.h

9:41 AM Changeset in webkit [137037] by kov@webkit.org
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-1.10

Merge 131488 - An feImage that tries to render itself should be stopped
https://bugs.webkit.org/show_bug.cgi?id=94652

Reviewed by Eric Seidel.

Source/WebCore:

An SVG feImage filter element will accept, as the src to render, an
SVG document that makes use of the feImage itself. This causes the
feImage to try to draw itself while already in the process of drawing
itself. Various problems arise from this. The invariant we wish to
maintain is that no element in the src tree of an feImage element
refers to that feImage.

This patch adds a flag to all FilterData objects that tracks whether or
not the filter is currently applying itself, and avoids applying the
filter recursively.

While it may seem better to catch this problem when the src is set, or
when the filter is built, that turns out to be challenging and
inefficient. Say we choose to test when the src atttribute is set. To
do so would require looking through all of the DOM nodes that will be
rendered for the src, finding all resources used, and checking if any
of them make use fo the feImage element that we are setting the source
for. The infrastructure is not in place to do that, and it would
involve walking a potentially very large portion of the DOM in order
to detect a very rare situation. Note that it is not enough just to
walk the DOM directly under the src; we also need to recursively follow any
resource links to see if they use the feImage (e.g. patterns or
masks or use or ...).

If we instead try to use the renderer node to find self referencing,
we need to recursively walk a potentially very large render tree,
tracing all resources in search of the feImage. This would need to be
done every time the filter is built, which is again a significant
overhead for a situation that is very unlikely to occur. And we do not
have methods that make it easy to find feImage filter effect nodes; they are
hidden behind filter resource nodes.

Hence the runtime check to catch the problem. The check must be in
FilterData and RenderSVGResourceFilter code because we must prevent
the destruction of the feImage when we encounter it recursively.

This patch also renames FilterData::builded to FilterData::isBuilt.

Test: svg/filters/feImage-self-referencing.html

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::ApplyingFilterEffectGuard): Guard to ensure that, in the future, we always
clear the isApplying flag even if the postApplyResource method returns early.
(WebCore::RenderSVGResourceFilter::applyResource): Do not apply a resource that is already applying and
rename builded to isBuilt.
(WebCore::RenderSVGResourceFilter::postApplyResource): Mark a resource as applying and clear after
it is done. Abort if a resource is already applying when the method begins. Rename builded to isBuilt.
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged): Rename builded to isBuilt.

  • rendering/svg/RenderSVGResourceFilter.h:

(WebCore::FilterData::FilterData):
(FilterData): Add isApplying and rename builded to isBuilt.

LayoutTests:

Ref-test to verify that an feImage that tries to draw itself will not
crash. This test must be render in order to verify the result. Do not
convert to dumpAstext.

  • svg/filters/feImage-self-referencing-expected.html: Added.
  • svg/filters/feImage-self-referencing.html: Added.

Conflicts:

Source/WebCore/rendering/svg/RenderSVGResourceFilter.cpp

9:30 AM Changeset in webkit [137036] by kov@webkit.org
  • 2 edits in releases/WebKitGTK/webkit-1.10/Source/WebKit2

Merge 137033 - Unreviewed. Make building the WebKit2 GIR file conditional on building the WebKit2 library.

  • GNUmakefile.am:
9:16 AM Changeset in webkit [137035] by commit-queue@webkit.org
  • 10 edits
    2 adds in trunk

[EFL][WK2] Add Remote Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=98705

Patch by Seokju Kwon <Seokju Kwon> on 2012-12-08
Reviewed by Gyuyoung Kim.

.:

Prepare inspectorPageIndex.html for remote web inspector.

  • Source/PlatformEfl.cmake:

Source/WebKit2:

Add Remote Web Inspector to EFL port.
The WebInspectorSever will be started during WebKit context initialization.
The IP address and port number for the server can be set in WEBKIT_INSPECTOR_SERVER.

  • CMakeLists.txt:
  • PlatformEfl.cmake:
  • UIProcess/InspectorServer/WebInspectorServer.h:

(WebInspectorServer):

  • UIProcess/InspectorServer/WebSocketServer.h:

(WebSocketServer):

  • UIProcess/InspectorServer/efl/WebInspectorServerEfl.cpp: Added.

(WebKit):
(WebKit::inspectorResourcePath):
(WebKit::WebInspectorServer::platformResourceForPath):
(WebKit::WebInspectorServer::buildPageList):

  • UIProcess/InspectorServer/soup/WebSocketServerSoup.cpp:

(WebKit::connectionCallback):

  • UIProcess/efl/WebContextEfl.cpp:

(WebKit::initializeInspectorServer):
(WebKit):
(WebKit::WebContext::platformInitializeWebProcess):

  • config.h:
9:13 AM Changeset in webkit [137034] by kov@webkit.org
  • 1 edit
    1 add in trunk/Source/WebKit/gtk/po

Merge Hindi translation of webkit
https://bugs.webkit.org/show_bug.cgi?id=97410

Patch by Rajesh Ranjan <rajeshkajha@yahoo.com> on 2012-12-08
Rubber-stamped by Gustavo Noronha.

  • hi.po: Added.
8:41 AM Changeset in webkit [137033] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Make building the WebKit2 GIR file conditional on building the WebKit2 library.

  • GNUmakefile.am:
8:08 AM Changeset in webkit [137032] by kov@webkit.org
  • 2 edits in trunk/Source/WTF

Unreviewed trivial space fix to silence an automake warning.

  • GNUmakefile.list.am:
8:01 AM Changeset in webkit [137031] by rwlbuis@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove no-op line in WebPage.cpp
https://bugs.webkit.org/show_bug.cgi?id=104385

Reviewed by Antonio Gomes.

Remove self-assignment no-op line. Must have been left when I removed the
mapFromTransformed part.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::touchPointAsMouseEvent):

7:52 AM Changeset in webkit [137030] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
6:41 AM Changeset in webkit [137029] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
5:48 AM Changeset in webkit [137028] by james.wei@intel.com
  • 2 edits in trunk/Source/WebCore

Remove incorrect ASSERT for m_error in CachedResource
https://bugs.webkit.org/show_bug.cgi?id=104333

Reviewed by Nate Chapin.

This assertion was brought in https://bugs.webkit.org/show_bug.cgi?id=100901
When the request is canceled, m_error.isNull() should be true.

run webkit_unit_tests Debug build.

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::stopLoading):

3:05 AM Changeset in webkit [137027] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Qt Linux Minimal build fix after r136975.

  • dom/ElementRareData.h:

(ElementRareData):

2:52 AM Changeset in webkit [137026] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Qt Linux Minimal build fix attempt after r136959.

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::layerTreeDidChange):
(WebCore::InspectorInstrumentation::renderLayerDestroyed):

2:44 AM Changeset in webkit [137025] by xan@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix after r137003. Wrap Microdata only sections with ENABLE(MICRODATA).

  • dom/NodeRareData.h:

(NodeRareData):

2:37 AM Changeset in webkit [137024] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix after r137003. Wrap NodeMutationObserverData with ENABLE(MUTATION_OBSERVERS).

  • dom/NodeRareData.h:

(NodeRareData):

2:22 AM Changeset in webkit [137023] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Remove unused headers
https://bugs.webkit.org/show_bug.cgi?id=104428

Patch by Seokju Kwon <Seokju Kwon> on 2012-12-08
Reviewed by Kentaro Hara.

Header inclusion cleanup.
Remove <WebCore/NotImplement.h>.

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:
  • WebMutableURLRequest.cpp:

Source/WebKit2:

  • Platform/qt/WorkQueueQt.cpp:
  • Platform/win/WorkQueueWin.cpp:
  • Shared/qt/ShareableBitmapQt.cpp:
  • UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
  • UIProcess/win/TextCheckerWin.cpp:
  • UIProcess/win/WebContextMenuProxyWin.cpp:
  • WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:
2:01 AM Changeset in webkit [137022] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for ENABLE(SVG) && !ENABLE(FILTERS) after r136975.

  • rendering/svg/SVGResources.cpp:

(WebCore::SVGResources::buildCachedResources):

1:33 AM WebKitGTK edited by Simon Pena
Updated reference to IRC channel (diff)
1:22 AM Changeset in webkit [137021] by adamk@chromium.org
  • 3 edits
    2 adds in trunk

HTMLTemplateElement.innerHTML should be parsed into the template contents owner document
https://bugs.webkit.org/show_bug.cgi?id=104407

Reviewed by Eric Seidel.

Source/WebCore:

When parsing via innerHTML, ensure that all operations (including the
initial fragment creation) occur in the proper document to avoid,
e.g., images loading while being parsed into the template contents.
This matches the parsing behavior during page load.

Test: fast/dom/HTMLTemplateElement/innerHTML-inert.html

  • editing/markup.cpp:

(WebCore::createFragmentForInnerOuterHTML):

LayoutTests:

  • fast/dom/HTMLTemplateElement/innerHTML-inert-expected.txt: Added.
  • fast/dom/HTMLTemplateElement/innerHTML-inert.html: Added.
12:36 AM Changeset in webkit [137020] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Assertion failed at WebCore::RedirectedXCompositeWindow::context()
https://bugs.webkit.org/show_bug.cgi?id=104349

Patch by ChangSeok Oh <ChangSeok Oh> on 2012-12-08
Reviewed by Martin Robinson.

We should return GLContext if m_needsContext is CreateGLContext. By the way
CreateGLContext is a enum value and its default value is 0. So checking
ASSERT(m_needsContext) causes a crash on debug build.
ASSERT(m_needsContext == CreateGLContext) is better here.

No new tests since we can verify this with already existing AC tests.

  • platform/gtk/RedirectedXCompositeWindow.cpp:

(WebCore::RedirectedXCompositeWindow::context):

Dec 7, 2012:

10:51 PM Changeset in webkit [137019] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Remove unused source file from PlatformEfl.cmake
https://bugs.webkit.org/show_bug.cgi?id=104430

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-12-07
Reviewed by Kentaro Hara.

Shared/API/c/gtk/WKGraphicsContextGtk.cpp is not used for building WebKit2/EFL.

  • PlatformEfl.cmake:
9:39 PM Changeset in webkit [137018] by senorblanco@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-win-xp/fast/text/hyphenate-character-expected.txt: Added.
9:35 PM Changeset in webkit [137017] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Add missing forward declaration for JSC::ArrayAllocationProfile
https://bugs.webkit.org/show_bug.cgi?id=104425

Patch by Jonathan Liu <net147@gmail.com> on 2012-12-07
Reviewed by Kentaro Hara.

The header for the JSC::ArrayConstructor class is missing a forward
declaration for the JSC::ArrayAllocationProfile class which causes
compilation to fail when compiling with MinGW-w64.

  • runtime/ArrayConstructor.h:

(JSC):

9:17 PM Changeset in webkit [137016] by senorblanco@chromium.org
  • 1 edit
    1 move
    3 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-mac-lion/css3/flexbox/repaint-column-reverse-expected.png: Removed.
  • platform/chromium-mac-snowleopard/css3/flexbox/repaint-column-reverse-expected.png: Removed.
  • platform/chromium-win-xp/css3/flexbox/repaint-column-reverse-expected.png: Removed.
  • platform/chromium-win/css3/flexbox/repaint-column-reverse-expected.png: Renamed from LayoutTests/platform/chromium-linux/css3/flexbox/repaint-column-reverse-expected.png.
9:15 PM Changeset in webkit [137015] by senorblanco@chromium.org
  • 1 edit
    4 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-mac/compositing/background-color/background-color-change-to-text-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/background-color/background-color-change-to-text-expected.png: Added.
8:58 PM Changeset in webkit [137014] by senorblanco@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening. Remove some incorrect baselines.

  • platform/chromium-linux/compositing/backface-visibility/backface-visibility-webgl-expected.png: Removed.
  • platform/chromium-mac/compositing/backface-visibility/backface-visibility-webgl-expected.png: Removed.
  • platform/chromium/TestExpectations:
8:24 PM Changeset in webkit [137013] by senorblanco@chromium.org
  • 1 edit
    3 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-mac-lion/css3/flexbox/repaint-column-reverse-expected.png: Added.
  • platform/chromium-mac-snowleopard/css3/flexbox/repaint-column-reverse-expected.png: Added.
  • platform/chromium-mac/css3/flexbox/repaint-column-reverse-expected.png: Added.
8:14 PM Changeset in webkit [137012] by senorblanco@chromium.org
  • 1 edit
    10 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-linux/fast/text/hyphenate-character-expected.png: Added.
  • platform/chromium-linux/fast/text/hyphenate-character-expected.txt: Added.
  • platform/chromium-linux/fast/text/hyphenate-first-word-expected.png: Added.
  • platform/chromium-linux/fast/text/hyphenate-limit-before-after-expected.png: Added.
  • platform/chromium-linux/fast/text/hyphenate-limit-lines-expected.png: Added.
  • platform/chromium-linux/fast/text/hyphenate-locale-expected.png: Added.
  • platform/chromium-linux/fast/text/hyphens-expected.png: Added.
  • platform/chromium-linux/fast/text/international/hindi-whitespace-expected.png: Added.
  • platform/chromium-linux/fast/text/international/hindi-whitespace-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/hyphenate-limit-before-after-expected.png: Added.
8:03 PM Changeset in webkit [137011] by commit-queue@webkit.org
  • 38 edits in trunk/Source

Extend platform layer so it can pass blend modes to the compositing calls
https://bugs.webkit.org/show_bug.cgi?id=104176

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-12-07
Reviewed by Dirk Schulze.

Source/WebCore:

Adding blend mode enumeration to drawImage functions + stored blendmode in graphics context

No new tests, no new functionality.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

  • platform/graphics/BitmapImage.h:
  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::draw):

  • platform/graphics/CrossfadeGeneratedImage.h:

(CrossfadeGeneratedImage):

  • platform/graphics/GeneratedImage.h:

(GeneratedImage):

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::draw):

  • platform/graphics/GeneratorGeneratedImage.h:

(GeneratorGeneratedImage):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage):
(WebCore):
(WebCore::GraphicsContext::drawImageBuffer):
(WebCore::GraphicsContext::setCompositeOperation):

  • platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContextState::GraphicsContextState):
(GraphicsContextState):
(GraphicsContext):

  • platform/graphics/Image.cpp:

(WebCore::Image::draw):
(WebCore::Image::drawTiled):

  • platform/graphics/Image.h:

(Image):

  • platform/graphics/ImageBuffer.h:

(ImageBuffer):

  • platform/graphics/cairo/BitmapImageCairo.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::draw):

  • platform/graphics/cg/PDFDocumentImage.h:

(PDFDocumentImage):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/qt/ImageQt.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/qt/StillImageQt.cpp:

(WebCore::StillImage::draw):

  • platform/graphics/qt/StillImageQt.h:

(StillImage):

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h:

(BitmapImageSingleFrameSkia):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):

  • platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::nativeImageForCurrentFrame):

  • svg/graphics/SVGImage.h:

(SVGImage):

Source/WebKit/chromium:

Adding blend mode enumeration to draw functions

  • tests/DragImageTest.cpp:

(WebCore::TestImage::draw):

  • tests/ImageLayerChromiumTest.cpp:

(WebCore::TestImage::draw):

7:54 PM Changeset in webkit [137010] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Add missing const qualifier to JSC::CodeBlock::getJITType()
https://bugs.webkit.org/show_bug.cgi?id=104424

Patch by Jonathan Liu <net147@gmail.com> on 2012-12-07
Reviewed by Laszlo Gombos.

JSC::CodeBlock::getJITType() has the const qualifier when JIT is
enabled but is missing the const qualifier when JIT is disabled.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::getJITType):

7:14 PM Changeset in webkit [137009] by senorblanco@chromium.org
  • 12 edits
    3 copies
    9 moves
    32 adds
    9 deletes in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-linux/svg/custom/transform-with-shadow-and-gradient-expected.png: Removed.
  • platform/chromium-mac-lion/fast/text/hyphenate-character-expected.png: Added.
  • platform/chromium-mac-lion/fast/text/hyphenate-character-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/hyphenate-first-word-expected.png: Added.
  • platform/chromium-mac-lion/fast/text/hyphenate-first-word-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/hyphenate-limit-before-after-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt.
  • platform/chromium-mac-lion/fast/text/hyphenate-limit-lines-expected.png: Added.
  • platform/chromium-mac-lion/fast/text/hyphenate-limit-lines-expected.txt: Added.
  • platform/chromium-mac-lion/fast/text/hyphenate-locale-expected.png: Added.
  • platform/chromium-mac-lion/fast/text/hyphens-expected.png: Added.
  • platform/chromium-mac-lion/fast/text/hyphens-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-character-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-character-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-first-word-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt:
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-lines-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-lines-expected.txt:
  • platform/chromium-mac-snowleopard/fast/text/hyphenate-locale-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/text/hyphens-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/hyphens-expected.txt: Added.
  • platform/chromium-mac/fast/text/hyphenate-character-expected.png:
  • platform/chromium-mac/fast/text/hyphenate-character-expected.txt: Added.
  • platform/chromium-mac/fast/text/hyphenate-first-word-expected.png: Added.
  • platform/chromium-mac/fast/text/hyphenate-first-word-expected.txt: Added.
  • platform/chromium-mac/fast/text/hyphenate-limit-before-after-expected.png:
  • platform/chromium-mac/fast/text/hyphenate-limit-before-after-expected.txt: Copied from LayoutTests/platform/chromium-mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt.
  • platform/chromium-mac/fast/text/hyphenate-limit-lines-expected.png: Added.
  • platform/chromium-mac/fast/text/hyphenate-limit-lines-expected.txt: Added.
  • platform/chromium-mac/fast/text/hyphenate-locale-expected.png: Added.
  • platform/chromium-mac/fast/text/hyphenate-locale-expected.txt: Renamed from LayoutTests/platform/chromium-mac-snowleopard/fast/text/hyphenate-locale-expected.txt.
  • platform/chromium-mac/fast/text/hyphens-expected.png:
  • platform/chromium-mac/fast/text/hyphens-expected.txt: Added.
  • platform/chromium-mac/svg/custom/transform-with-shadow-and-gradient-expected.png: Removed.
  • platform/chromium-win-xp/fast/text/hyphenate-character-expected.png: Added.
  • platform/chromium-win-xp/fast/text/hyphens-expected.png: Added.
  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.png: Added.
  • platform/chromium-win-xp/fast/text/international/hindi-whitespace-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/text/international/hindi-whitespace-expected.txt.
  • platform/chromium-win/fast/text/hyphenate-character-expected.png: Added.
  • platform/chromium-win/fast/text/hyphenate-character-expected.txt: Added.
  • platform/chromium-win/fast/text/hyphenate-first-word-expected.png: Added.
  • platform/chromium-win/fast/text/hyphenate-limit-before-after-expected.png: Added.
  • platform/chromium-win/fast/text/hyphenate-limit-lines-expected.png: Added.
  • platform/chromium-win/fast/text/hyphenate-locale-expected.png: Added.
  • platform/chromium-win/fast/text/hyphenate-locale-expected.txt: Renamed from LayoutTests/platform/chromium/fast/text/hyphenate-locale-expected.txt.
  • platform/chromium-win/fast/text/hyphens-expected.png: Added.
  • platform/chromium-win/fast/text/international/hindi-whitespace-expected.png:
  • platform/chromium-win/fast/text/international/hindi-whitespace-expected.txt:
  • platform/chromium-win/svg/custom/transform-with-shadow-and-gradient-expected.png: Removed.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/text/hyphenate-character-expected.png: Removed.
  • platform/chromium/fast/text/hyphenate-first-word-expected.png: Removed.
  • platform/chromium/fast/text/hyphenate-limit-before-after-expected.png: Removed.
  • platform/chromium/fast/text/hyphenate-limit-lines-expected.png: Removed.
  • platform/chromium/fast/text/hyphenate-locale-expected.png: Removed.
  • platform/chromium/fast/text/hyphens-expected.png: Removed.
  • platform/chromium/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
  • platform/efl-wk1/fast/text/hyphenate-character-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-character-expected.png.
  • platform/efl-wk1/fast/text/hyphenate-first-word-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-first-word-expected.png.
  • platform/efl-wk1/fast/text/hyphenate-limit-before-after-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-limit-before-after-expected.png.
  • platform/efl-wk1/fast/text/hyphenate-limit-lines-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-limit-lines-expected.png.
  • platform/efl-wk1/fast/text/hyphenate-locale-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-locale-expected.png.
  • platform/efl-wk1/fast/text/hyphenate-locale-expected.txt: Renamed from LayoutTests/platform/efl/fast/text/hyphenate-locale-expected.txt.
  • platform/efl-wk1/fast/text/hyphens-expected.png: Renamed from LayoutTests/platform/efl/fast/text/hyphens-expected.png.
7:00 PM Changeset in webkit [137008] by hclam@chromium.org
  • 12 edits in trunk/Source

[chromium] ImageDecodingStore should cache partially decoded images
https://bugs.webkit.org/show_bug.cgi?id=103796

Reviewed by Stephen White.

Source/WebCore:

Implement caching for incomplete images, meaning the image is partially
decoded. The image is cached together with partially decoded ImageDecoder.
This allows decoding to resume in a later time.

Caching logic for incomplete images is implemented in ImageDecodingStore.

Logic for resuming image decoding is implemented in ImageFrameGenerator.

ImageDecodingStore allows storing incomplete image with the decoder.
The cache entry can be used in a later time to read and write (i.e. resume
decoding.) To avoid the same entry being written and read at the same time,
an incomplete entry can be used by one user only. Concurrent access to
an incomplete entry should never happen and is checked by an assert.
An entry can becomes complete when decoding is finished. In this case
the associated decoder is deleted. Once an entry becomes complete concurrent
read is allowed.

ImageFrameGenerator performs the logic to resume image decoding. It
performs the following operations in sequence:

  • Try to lookup a complete image
  • Try to perform scaling on a complete image
  • Try to lookup an incomplete image and resume decoding & scaling
  • Everything fails, start decoding from scratch

The entire sequence of operations in under a mutex, hence there will be
no more than 1 user of an incomplete cache entry at the same time.

New unit tests in ImageDecodingStoreTest and ImageFrameGeneratorTest.

  • platform/graphics/chromium/ImageDecodingStore.cpp:

(WebCore::ImageDecodingStore::lockCache):
Change of method definition to return an image and ImageDecoder.
(WebCore::ImageDecodingStore::unlockCache):
(WebCore::ImageDecodingStore::insertAndLockCache):
(WebCore::ImageDecodingStore::overwriteAndLockCache):
New method to allow an incomplete cache entry be overwritten.
(WebCore):

  • platform/graphics/chromium/ImageDecodingStore.h:

(ImageDecodingStore):
(WebCore::ImageDecodingStore::CacheEntry::createAndUse):
(WebCore::ImageDecodingStore::CacheEntry::CacheEntry):
(WebCore::ImageDecodingStore::CacheEntry::cachedImage):
(WebCore::ImageDecodingStore::CacheEntry::cachedDecoder):
(WebCore::ImageDecodingStore::CacheEntry::releaseCachedDecoder):
(WebCore::ImageDecodingStore::CacheEntry::overwriteCachedImage):
New method to allow an incomplete image be overwitten.
(CacheEntry):

  • platform/graphics/chromium/ImageFrameGenerator.cpp:

(WebCore::ImageFrameGenerator::ImageFrameGenerator):
(WebCore::ImageFrameGenerator::decodeAndScale):
(WebCore::ImageFrameGenerator::tryToLockCompleteCache):
(WebCore::ImageFrameGenerator::tryToScale):
(WebCore::ImageFrameGenerator::tryToResumeDecodeAndScale):
New method to lookup an incomplete cache entry and resume decoding.
(WebCore):
(WebCore::ImageFrameGenerator::tryToDecodeAndScale):
(WebCore::ImageFrameGenerator::decoder):
New helper method to do decoding for a full sized image.
(WebCore::ImageFrameGenerator::prepareData):
New helper method to prepare data safely.

  • platform/graphics/chromium/ImageFrameGenerator.h:

(ImageFrameGenerator):

  • platform/graphics/chromium/LazyDecodingPixelRef.cpp:

(WebCore::LazyDecodingPixelRef::onLockPixels):

  • platform/graphics/chromium/ScaledImageFragment.h:

(WebCore::ScaledImageFragment::setIsComplete):

Source/WebKit/chromium:

Added unit tests to verify caching behavior for partially decoded images.
New tests added:

  • ImageDecodingStoreTest.insertIncompleteCache

Insert incomplete image with a decoder into cache.

  • ImageDecodingStoreTest.insertCompleteCacheWithDecoder

Insert complete image with a decoder, decoder is deleted.

  • ImageDecodingStoreTest.incompleteCacheBecomesComplete

Progressive downloading of a file. Image becomes complete, decoder deleted.

  • ImageFrameGeneratorTest.cacheMissWithIncompleteDecodeAndScale

Cache lookup failed and start a decoding that decoded an incomplete image.

ImageFrameGeneratorTest.incompleteDecodeBecomesComplete
Image decoded as incomplete, file fully downloaded and cache entry becomes complete.

ImageFrameGeneratorTest.incompleteDecodeAndScaleBecomesComplete
Image decoded and scaled as incomplete, becomes complete after file is fully dowloaded.

ImageFrameGeneratorTest.incompleteDecodeBecomesCompleteMultiThreaded
Transition from incomplete to complete, entire lifecycle happens on 2 threads.

  • tests/DeferredImageDecoderTest.cpp:

(WebCore::DeferredImageDecoderTest::SetUp):

  • tests/ImageDecodingStoreTest.cpp:

(WebCore::ImageDecodingStoreTest::SetUp):
(WebCore::ImageDecodingStoreTest::decoderBeingDestroyed):
(ImageDecodingStoreTest):
(WebCore::ImageDecodingStoreTest::frameBufferRequested):
(WebCore::ImageDecodingStoreTest::frameStatus):
(WebCore::ImageDecodingStoreTest::createIncompleteImage):
(WebCore::ImageDecodingStoreTest::lockCache):
(WebCore::TEST_F):
(WebCore):

  • tests/ImageFrameGeneratorTest.cpp:

(WebCore::ImageFrameGeneratorTest::SetUp):
(WebCore::ImageFrameGeneratorTest::decoderBeingDestroyed):
(ImageFrameGeneratorTest):
(WebCore::MockImageDecoderFactory::create):
(WebCore::TEST_F):
(WebCore):
(WebCore::decodeThreadMain):

  • tests/MockImageDecoder.h:

(WebCore::MockImageDecoder::create):
(MockImageDecoder):
(WebCore::MockImageDecoder::setSize):
(WebCore::MockImageDecoder::frameBufferAtIndex):

6:34 PM Changeset in webkit [137007] by alexis@webkit.org
  • 8 edits in trunk

Enable CSS3 position offset for CSS Masking.
https://bugs.webkit.org/show_bug.cgi?id=104252

Reviewed by Dirk Schulze.

Source/WebCore:

To follow CSS3 background-position, mask-position should also support
the new <position> type (http://dvcs.w3.org/hg/FXTF/raw-file/tip/masking/index.html#mask-property).
Now the code is shared between background and mask I renamed the
functions used to be more generic. Note that the feature flag is not
meant to stay and will be removed in a following commit.

No new tests : I modified LayoutTests/fast/masking/parsing-mask.html to
cover the new feature.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::createPositionListForLayer):

  • css/CSSParser.cpp:

(WebCore::isFillPositionKeyword):
(WebCore::CSSParser::parse4ValuesFillPosition):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::isPotentialPositionValue):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parse2ValuesFillPosition):
(WebCore::CSSParser::parseFillProperty):
(WebCore::CSSParser::parseTransformOriginShorthand):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::parsePerspectiveOrigin):

  • css/CSSParser.h:
  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):

LayoutTests:

Add coverage for the new cases. Both when setting the position with the
longhand or with the shorthand.

  • fast/masking/parsing-mask-expected.txt:
  • fast/masking/parsing-mask.html:
6:29 PM Changeset in webkit [137006] by commit-queue@webkit.org
  • 90 edits
    38 copies
    24 adds in trunk

Use background color for GraphicsLayers when applicable
https://bugs.webkit.org/show_bug.cgi?id=103786

Source/WebCore:

Updated RenderLayerBacking to call GraphicsLayer::setContentsToBackgroundColor when the following conditions take place:

  1. The layer doesn't paint its own content, other than background/decoration.
  2. There are no borders or other box decorations (border radius, borders, outline, shadow etc.)
  3. The image has only a background color, and no background image.
  4. background-composite is set to source-over, and background-clip is anything apart from text.
  5. The port supports setContentsToBackgroundColor.

This allows any implementation of GraphicsLayer that supports setContentsToBackgroundColor to avoid allocating a backing store
for that layer, but instead draw that solid color directly.
In addition to setting the background color, the layer's contentsRect needs to be adjusted, since the default contents rect of
a layer is not always equivalent to the rect where the background is supposed to be painted, which is derived from the box's
background-clip property.

Patch by No'am Rosenthal <Noam Rosenthal> on 2012-12-07
Reviewed by Simon Fraser.

Tests: compositing/background-color/background-color-alpha.html

compositing/background-color/background-color-change-to-text.html
compositing/background-color/background-color-composite.html
compositing/background-color/background-color-container.html
compositing/background-color/background-color-content-clip.html
compositing/background-color/background-color-padding-change.html
compositing/background-color/background-color-padding-clip.html
compositing/background-color/background-color-simple.html
compositing/background-color/background-color-text-change.html
compositing/background-color/background-color-text-clip.html

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::supportsBackgroundColorContent):

Allows different implementation of GraphicsLayer to identify whether they implement setContentsToBackgroundColor.
Currently only the MAC implementation and TextureMapper falls under that category.

  • rendering/RenderBox.h:

(WebCore::RenderBox::paddingBoxRect):

Added paddingBoxRect to compliment borderBoxRect and contentsBoxRect. paddingBoxRect corresponds to
background-clip: padding.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration):

Update the background color if needed, for every configuration change.
This should accomodate the old behavior for full-screen, while enabling background color changes for other layers.

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):

Move the contentsRect logic to updateContentsRect.

(WebCore::RenderLayerBacking::updateContentsRect):

Use the background box when directly compositing backgrounds.

(WebCore::RenderLayerBacking::updateBackgroundColor):

Set the background color if applicable, otherwise set to trasnparent and clear.
This was not needed in the past because background colors were only used for the special case of full-screen.

(WebCore::supportsDirectBoxDecorationsComposition):

Helper function to determine whether a particular background can be directly composited. Right now only
background color can be composited, and only if the GraphicsLayer implementation supports background colors.
Also we don't yet support background-clip: text and any background-composite other than source-over.

(WebCore::RenderLayerBacking::paintsBoxDecorations):

Apply the new supportsDirectBoxDecorationsComposition logic.

(WebCore::RenderLayerBacking::contentsBox):

Remove unnecessary local variable.

(WebCore::backgroundRectForBox):
(WebCore::RenderLayerBacking::backgroundBox):

Figure out the correct rect for the GraphicsLayer's contentsRect, based on the renderer's backgroundClip.
The rectangle has to be adjusted based on the composited layer offset, and snapped to an IntRect as
GraphicsLayer::contentsRect expects snapped pixels.

LayoutTests:

Created new tests for composited background colors, update existing tests that are affected by the change,
and created platform-specific overrides for Chromium, since it does not yet support composited background
colors.

Patch by No'am Rosenthal <Noam Rosenthal> on 2012-12-07
Reviewed by Simon Fraser.

  • compositing/background-color/background-color-alpha-expected.html: Added.
  • compositing/background-color/background-color-alpha.html: Added.
  • compositing/background-color/background-color-change-to-text-expected.html: Added.
  • compositing/background-color/background-color-change-to-text.html: Added.
  • compositing/background-color/background-color-composite-expected.html: Added.
  • compositing/background-color/background-color-composite.html: Added.
  • compositing/background-color/background-color-container-expected.html: Added.
  • compositing/background-color/background-color-container.html: Added.
  • compositing/background-color/background-color-content-clip-expected.html: Added.
  • compositing/background-color/background-color-content-clip.html: Added.
  • compositing/background-color/background-color-padding-change-expected.html: Added.
  • compositing/background-color/background-color-padding-change.html: Added.
  • compositing/background-color/background-color-padding-clip-expected.html: Added.
  • compositing/background-color/background-color-padding-clip.html: Added.
  • compositing/background-color/background-color-simple-expected.html: Added.
  • compositing/background-color/background-color-simple.html: Added.
  • compositing/background-color/background-color-text-change-expected.html: Added.
  • compositing/background-color/background-color-text-change.html: Added.
  • compositing/background-color/background-color-text-clip-expected.html: Added.
  • compositing/background-color/background-color-text-clip.html: Added.

Added new tests for the specific functionality added, with the edge cases regarding composited
backgrounds.

  • compositing/backing/no-backing-for-clip-expected.txt:
  • compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • compositing/backing/no-backing-for-perspective-expected.txt:
  • compositing/columns/composited-in-paginated-expected.txt:
  • compositing/geometry/ancestor-overflow-change-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • compositing/geometry/clip-expected.txt:
  • compositing/geometry/composited-in-columns-expected.txt:
  • compositing/geometry/flipped-writing-mode-expected.txt:
  • compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
  • compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
  • compositing/geometry/preserve-3d-switching-expected.txt:
  • compositing/iframes/become-composited-nested-iframes-expected.txt:
  • compositing/iframes/become-overlapped-iframe-expected.txt:
  • compositing/iframes/composited-parent-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • compositing/iframes/connect-compositing-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe2-expected.txt:
  • compositing/iframes/connect-compositing-iframe3-expected.txt:
  • compositing/iframes/enter-compositing-iframe-expected.txt:
  • compositing/iframes/iframe-resize-expected.txt:
  • compositing/iframes/invisible-nested-iframe-hide-expected.txt:
  • compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • compositing/iframes/overlapped-iframe-expected.txt:
  • compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • compositing/iframes/page-cache-layer-tree-expected.txt:
  • compositing/iframes/scrolling-iframe-expected.txt:
  • compositing/layer-creation/animation-overlap-with-children-expected.txt:
  • compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • compositing/layer-creation/overflow-scroll-overlap-expected.txt:
  • compositing/layer-creation/overlap-animation-expected.txt:
  • compositing/layer-creation/overlap-child-layer-expected.txt:
  • compositing/layer-creation/overlap-clipping-expected.txt:
  • compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
  • compositing/layer-creation/overlap-transformed-layer-expected.txt:
  • compositing/layer-creation/overlap-transforms-expected.txt:
  • compositing/layer-creation/scroll-partial-update-expected.txt:
  • compositing/layer-creation/spanOverlapsCanvas-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
  • compositing/layer-creation/translatez-overlap-expected.txt:
  • compositing/overflow-trumps-transform-style-expected.txt:
  • compositing/overflow/clip-descendents-expected.txt:
  • compositing/plugins/no-backing-store-expected.txt:
  • compositing/rtl/rtl-absolute-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-fixed-expected.txt:
  • compositing/rtl/rtl-fixed-overflow-expected.txt:
  • compositing/rtl/rtl-relative-expected.txt:
  • compositing/tiled-layers-hidpi-expected.txt:
  • compositing/visible-rect/2d-transformed-expected.txt:
  • compositing/visible-rect/3d-transform-style-expected.txt:
  • compositing/visible-rect/3d-transformed-expected.txt:
  • compositing/visible-rect/animated-expected.txt:
  • compositing/visible-rect/animated-from-none-expected.txt:
  • compositing/visible-rect/clipped-by-viewport-expected.txt:
  • compositing/visible-rect/clipped-visible-rect-expected.txt:
  • compositing/visible-rect/iframe-and-layers-expected.txt:
  • compositing/visible-rect/nested-transform-expected.txt:
  • compositing/visible-rect/scrolled-expected.txt:
  • css3/filters/filtered-compositing-descendant-expected.txt:

Updated existing tests that now print different layer-tree results.

  • platform/chromium/compositing/backing/no-backing-for-clip-expected.txt: Copied from LayoutTests/compositing/backing/no-backing-for-clip-expected.txt.
  • platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt: Copied from LayoutTests/compositing/backing/no-backing-for-clip-overlap-expected.txt.
  • platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt: Copied from LayoutTests/compositing/backing/no-backing-for-perspective-expected.txt.
  • platform/chromium/compositing/columns/composited-in-paginated-expected.txt: Copied from LayoutTests/compositing/columns/composited-in-paginated-expected.txt.
  • platform/chromium/compositing/geometry/ancestor-overflow-change-expected.txt: Copied from LayoutTests/compositing/geometry/ancestor-overflow-change-expected.txt.
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Copied from LayoutTests/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt.
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt: Copied from LayoutTests/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt.
  • platform/chromium/compositing/geometry/clip-expected.txt: Copied from LayoutTests/compositing/geometry/clip-expected.txt.
  • platform/chromium/compositing/geometry/composited-in-columns-expected.txt: Copied from LayoutTests/compositing/geometry/composited-in-columns-expected.txt.
  • platform/chromium/compositing/geometry/flipped-writing-mode-expected.txt: Copied from LayoutTests/compositing/geometry/flipped-writing-mode-expected.txt.
  • platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt: Copied from LayoutTests/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt.
  • platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt.
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-positioned-expected.txt.
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt.
  • platform/chromium/compositing/geometry/limit-layer-bounds-transformed-expected.txt: Copied from LayoutTests/compositing/geometry/limit-layer-bounds-transformed-expected.txt.
  • platform/chromium/compositing/geometry/preserve-3d-switching-expected.txt: Copied from LayoutTests/compositing/geometry/preserve-3d-switching-expected.txt.
  • platform/chromium/compositing/iframes/invisible-nested-iframe-hide-expected.txt: Copied from LayoutTests/compositing/iframes/invisible-nested-iframe-hide-expected.txt.
  • platform/chromium/compositing/layer-creation/fixed-position-and-transform-expected.txt: Copied from LayoutTests/compositing/layer-creation/fixed-position-and-transform-expected.txt.
  • platform/chromium/compositing/layer-creation/fixed-position-under-transform-expected.txt: Copied from LayoutTests/compositing/layer-creation/fixed-position-under-transform-expected.txt.
  • platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt: Copied from LayoutTests/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-animation-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-animation-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-child-layer-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-child-layer-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-clipping-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-clipping-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-transformed-layer-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-transformed-layer-expected.txt.
  • platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt: Copied from LayoutTests/compositing/layer-creation/overlap-transforms-expected.txt.
  • platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt: Copied from LayoutTests/compositing/layer-creation/scroll-partial-update-expected.txt.
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-expected.txt: Copied from LayoutTests/compositing/layer-creation/stacking-context-overlap-expected.txt.
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-nested-expected.txt: Copied from LayoutTests/compositing/layer-creation/stacking-context-overlap-nested-expected.txt.
  • platform/chromium/compositing/layer-creation/translatez-overlap-expected.txt: Copied from LayoutTests/compositing/layer-creation/translatez-overlap-expected.txt.
  • platform/chromium/compositing/overflow-trumps-transform-style-expected.txt: Copied from LayoutTests/compositing/overflow-trumps-transform-style-expected.txt.
  • platform/chromium/compositing/rtl/rtl-absolute-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-absolute-expected.txt.
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-absolute-overflow-expected.txt.
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt.
  • platform/chromium/compositing/rtl/rtl-fixed-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-fixed-expected.txt.
  • platform/chromium/compositing/rtl/rtl-fixed-overflow-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-fixed-overflow-expected.txt.
  • platform/chromium/compositing/rtl/rtl-relative-expected.txt: Copied from LayoutTests/compositing/rtl/rtl-relative-expected.txt.
  • platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt: Copied from LayoutTests/css3/filters/filtered-compositing-descendant-expected.txt.

Create chromium-specific results since chromium does not yet support setContentsToBackgroundColor.

5:48 PM Changeset in webkit [137005] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebKit2

Allow the WebProcess access to the CoreMedia preferences file.
https://bugs.webkit.org/show_bug.cgi?id=104320
<rdar://problem/10904519>

Reviewed by Alexey Proskuryakov.

Allow read access to ~/Library/Preferences/com.apple.coremedia.plist and com.apple.avfoundation.plist
by the WebProcess. The QuickTime.plugin uses CoreMedia for playback, so allow PluginProcess
to access those preferences as well.

  • PluginProcess/mac/com.apple.WebKit.PluginProcess.sb.in:
  • WebProcess/com.apple.WebProcess.sb.in:
5:19 PM Changeset in webkit [137004] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

[wk2] WebProcessServiceForWebKitDevelopment should forward stdout and stderr to the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=104418

Reviewed by Simon Fraser.

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::connectToWebProcessServiceForWebKitDevelopment): Send stdout and stderr file descriptors to the WebProcess.

  • WebProcessServiceForWebKitDevelopment/WebProcessServiceForWebKitDevelopmentMain.mm:

(WebProcessServiceForWebKitDevelopmentEventHandler): Replace the WebProcess' stdout and stderr with those from the UIProcess.

5:17 PM Changeset in webkit [137003] by rniwa@webkit.org
  • 9 edits in trunk/Source/WebCore

Shrink the size of NodeRareData by moving pointers into separate objects
https://bugs.webkit.org/show_bug.cgi?id=104312

Reviewed by Andreas Kling.

This patch does three things:

  1. Move ChildNodeList back into NodeListsNodeData.
  2. Move m_mutationObserverRegistry & m_transientMutationObserverRegistry into a separate object owned by NodeRareData.
  3. Move m_itemProp, m_itemRef, m_itemType & into a separate object owned by NodeRareData.

Moving m_childNodeList from NodeRareData to NodeListsNodeData also has a nice side-effect of making ChildNodeList
behave more like other LiveNodeLists.

This patch also fixes Mac build when microdata is enabled.

There should be no user-visible behavior change.

  • dom/ChildNodeList.cpp:

(WebCore::ChildNodeList::~ChildNodeList):

  • dom/Node.cpp:

(WebCore::Node::childNodes): Moved the code to create ChildNodeList into NodeListsNodeData to match other node lists.
(WebCore::Node::invalidateNodeListCachesInAncestors):
(WebCore): Removed removeCachedChildNodeList.

  • dom/Node.h:

(Node):

  • dom/NodeRareData.cpp:

(WebCore): Assert the size of NodeRareData at compilation time.
(WebCore::NodeListsNodeData::reportMemoryUsage):
(WebCore::NodeRareData::reportMemoryUsage):

  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::clearChildNodeListCache): Moved from NodeRareData.
(WebCore::NodeListsNodeData::ensureChildNodeList): Extracted from Node::childNodes.
(WebCore::NodeListsNodeData::removeChildNodeList): Added.
(WebCore::NodeListsNodeData::NodeListsNodeData): Initialize m_childNodeList.
(WebCore::NodeRareData::NodeMutationObserverData): Extracted from NodeRareData.
(WebCore::NodeRareData::NodeMutationObserverData::create):
(WebCore::NodeRareData::NodeMicroDataTokenLists): Ditto.
(WebCore::NodeRareData::NodeMicroDataTokenLists::create):
(WebCore::NodeRareData::NodeRareData):
(WebCore::NodeRareData::ensureNodeLists): Merged setNodeLists since it's not called elsewhere.
(WebCore::NodeRareData::mutationObserverRegistry):
(WebCore::NodeRareData::ensureMutationObserverRegistry): Added.
(WebCore::NodeRareData::transientMutationObserverRegistry):
(WebCore::NodeRareData::ensureTransientMutationObserverRegistry):
(WebCore::NodeRareData::ensureMicroDataTokenLists):
(NodeRareData):
(WebCore::NodeRareData::itemProp):
(WebCore::NodeRareData::setItemProp):
(WebCore::NodeRareData::itemRef):
(WebCore::NodeRareData::setItemRef):
(WebCore::NodeRareData::itemType):
(WebCore::NodeRareData::setItemType):

  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::propertyNodeList): Renamed from namedItem since its return type, PropertyNodeList,
is different from that, Node, of LiveNodeList::namedItem. It was shadowing the function name instead of overriding.

  • html/HTMLPropertiesCollection.h:

(HTMLPropertiesCollection):

  • html/HTMLPropertiesCollection.idl:
5:05 PM Changeset in webkit [137002] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
5:00 PM Changeset in webkit [137001] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Make function code cache proportional to main codeblock cache
https://bugs.webkit.org/show_bug.cgi?id=104420

Reviewed by Geoffrey Garen.

Makes the constants determining the recently used function cache proportional
to the number of root codeblocks in the cache. Also renames the constants to
make them more clear.

  • runtime/CodeCache.h:
4:42 PM Changeset in webkit [137000] by senorblanco@chromium.org
  • 1 edit
    3 moves
    3 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening. New baselines for new tests.

  • platform/chromium-mac/css3/filters/effect-reference-after-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-reference-delete-expected.png: Added.
  • platform/chromium-mac/css3/filters/effect-reference-rename-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-reference-after-expected.png: Renamed from LayoutTests/platform/chromium-linux/css3/filters/effect-reference-after-expected.png.
  • platform/chromium-win/css3/filters/effect-reference-delete-expected.png: Renamed from LayoutTests/platform/chromium-linux/css3/filters/effect-reference-delete-expected.png.
  • platform/chromium-win/css3/filters/effect-reference-rename-expected.png: Renamed from LayoutTests/platform/chromium-linux/css3/filters/effect-reference-rename-expected.png.
4:40 PM Changeset in webkit [136999] by commit-queue@webkit.org
  • 38 edits in trunk/Source

Unreviewed, rolling out r136993.
http://trac.webkit.org/changeset/136993
https://bugs.webkit.org/show_bug.cgi?id=104415

This patch breaks the mac build (Requested by cabanier on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-07

Source/WebCore:

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

  • platform/graphics/BitmapImage.h:
  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::draw):

  • platform/graphics/CrossfadeGeneratedImage.h:

(CrossfadeGeneratedImage):

  • platform/graphics/GeneratedImage.h:

(GeneratedImage):

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::draw):

  • platform/graphics/GeneratorGeneratedImage.h:

(GeneratorGeneratedImage):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawImageBuffer):
(WebCore::GraphicsContext::setCompositeOperation):

  • platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContextState::GraphicsContextState):
(GraphicsContextState):
(GraphicsContext):

  • platform/graphics/Image.cpp:

(WebCore::Image::draw):
(WebCore::Image::drawTiled):

  • platform/graphics/Image.h:

(Image):

  • platform/graphics/ImageBuffer.h:

(ImageBuffer):

  • platform/graphics/cairo/BitmapImageCairo.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::draw):

  • platform/graphics/cg/PDFDocumentImage.h:

(PDFDocumentImage):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/qt/ImageQt.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/qt/StillImageQt.cpp:

(WebCore::StillImage::draw):

  • platform/graphics/qt/StillImageQt.h:

(StillImage):

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h:

(BitmapImageSingleFrameSkia):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):

  • platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::nativeImageForCurrentFrame):

  • svg/graphics/SVGImage.h:

(SVGImage):

Source/WebKit/chromium:

  • tests/DragImageTest.cpp:

(WebCore::TestImage::draw):

  • tests/ImageLayerChromiumTest.cpp:

(WebCore::TestImage::draw):

Source/WebKit2:

  • win/WebKit2.def.in:
4:38 PM Changeset in webkit [136998] by ap@apple.com
  • 9 edits in trunk/Source

There is no need to change cached resource storage policy through ResourceHandleClient
https://bugs.webkit.org/show_bug.cgi?id=104413

Reviewed by Brady Eidson.

This code was only needed to prevent storing responses to disk in private browsing
mode, but we now have a storage session to take care of that in a cleaner and more
reliable way.

4:16 PM Changeset in webkit [136997] by ap@apple.com
  • 14 edits in trunk/Source/WebKit2

Network process should use a correct storage session in private browsing mode
<rdar://problem/12838490>
https://bugs.webkit.org/show_bug.cgi?id=104401

Reviewed by Brady Eidson.

Notify NetworkProcess when it needs to create or destroy a private browsing session,
and add a NetworkResourceLoadParameters member telling if the particular resource
should be requested using it.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp: (WebKit::NetworkConnectionToWebProcess::cookiesForDOM): (WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM): (WebKit::NetworkConnectionToWebProcess::cookiesEnabled): (WebKit::NetworkConnectionToWebProcess::getRawCookies): (WebKit::NetworkConnectionToWebProcess::deleteCookie): (WebKit::NetworkConnectionToWebProcess::getHostnamesWithCookies): (WebKit::NetworkConnectionToWebProcess::deleteCookiesForHostname): (WebKit::NetworkConnectionToWebProcess::deleteAllCookies): Added another dummy argument to dummy networking context.
  • NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::initializeNetworkProcess): Ensure private browsing session if it's needed due to a persistent preference, not an API call at runtime (which is handled below as ensure/destroy).
  • NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::start): Pass private browsing state to RemoteNetworkingContext used for loading. (WebKit::NetworkResourceLoader::willCacheResponse): Added an implemntation that matches WebCore, but may be not needed.
  • NetworkProcess/mac/RemoteNetworkingContext.h: (WebKit::RemoteNetworkingContext::create): Store privateBrowsingEnabled flag.
  • NetworkProcess/mac/RemoteNetworkingContext.mm: (WebKit::RemoteNetworkingContext::storageSession): Return a private session when it's in use.
  • Shared/Network/NetworkProcessCreationParameters.cpp: (WebKit::NetworkProcessCreationParameters::encode): (WebKit::NetworkProcessCreationParameters::decode):
  • Shared/Network/NetworkProcessCreationParameters.h: Pass privateBrowsingEnabled flag to the new process.
  • Shared/Network/NetworkResourceLoadParameters.cpp: (WebKit::NetworkResourceLoadParameters::NetworkResourceLoadParameters): (WebKit::NetworkResourceLoadParameters::encode): (WebKit::NetworkResourceLoadParameters::decode):
  • Shared/Network/NetworkResourceLoadParameters.h: (WebKit::NetworkResourceLoadParameters::inPrivateBrowsingMode): Pass inPrivateBrowsingMode flag for the request.
  • UIProcess/Network/NetworkProcessManager.h: (WebKit::NetworkProcessManager::process): Exposed, so that we can send messages without going through NetworkProcessManager.
  • UIProcess/WebContext.cpp: (WebKit::WebContext::usesNetworkProcess): (WebKit::anyContextUsesNetworkProcess): (WebKit::WebContext::willStartUsingPrivateBrowsing): (WebKit::WebContext::willStopUsingPrivateBrowsing): Notify NetworkProcess when entering or exiting private browsing.
  • UIProcess/WebContext.h: Exposed usesNetworkProcess() for the new static function anyContextUsesNetworkProcess to use.
  • WebProcess/Network/WebResourceLoadScheduler.cpp: (WebKit::WebResourceLoadScheduler::scheduleLoad): Put current private browsing state over in NetworkResourceLoadParameters.
3:43 PM Changeset in webkit [136996] by adamk@chromium.org
  • 7 edits in trunk

MutationRecord addedNodes/removedNodes should never be null
https://bugs.webkit.org/show_bug.cgi?id=98921

Reviewed by Ryosuke Niwa.

Source/WebCore:

Per an update to the DOM4 spec that matches Gecko's behavior,
addedNodes/removedNodes should be empty NodeLists on 'attributes'
and 'characterData' records, rather than null.

This is accomplished with lazy initialization of addedNodes/removedNodes
attributes on 'attributes'/'characterData' records and the
addition of a new StaticNodeList::createEmpty() factory method.

  • dom/MutationRecord.cpp:
  • dom/MutationRecord.h:

(MutationRecord):

  • dom/StaticNodeList.h:

(WebCore::StaticNodeList::adopt):
(StaticNodeList):
(WebCore::StaticNodeList::createEmpty):
(WebCore::StaticNodeList::StaticNodeList):

LayoutTests:

Updated nullity test to check for empty nodelists.

  • fast/mutation/mutation-record-nullity-expected.txt:
  • fast/mutation/mutation-record-nullity.html:
3:42 PM Changeset in webkit [136995] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed build correction after 136959.

The initialization list should follow the same compiler macro
exclusions as the class members.

  • inspector/InstrumentingAgents.h: Add USE(ACCELERATED_COMPOSITING) guards around m_inspectorLayerTreeAgent as this does not exist when the guard is false.
3:34 PM Changeset in webkit [136994] by eae@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

Unreviewed chromium-win rebaselines.

  • platform/chromium-win-xp/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Removed.
  • platform/chromium-win/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
3:33 PM Changeset in webkit [136993] by commit-queue@webkit.org
  • 37 edits in trunk/Source

Extend platform layer so it can pass blend modes to the compositing calls
https://bugs.webkit.org/show_bug.cgi?id=104176

Patch by Rik Cabanier <cabanier@adobe.com> on 2012-12-07
Reviewed by Dirk Schulze.

Source/WebCore:

Adding blend mode enumeration to drawImage functions + stored blendmode in graphics context

No new tests, no new functionality.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

  • platform/graphics/BitmapImage.h:
  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::draw):

  • platform/graphics/CrossfadeGeneratedImage.h:

(CrossfadeGeneratedImage):

  • platform/graphics/GeneratedImage.h:

(GeneratedImage):

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::draw):

  • platform/graphics/GeneratorGeneratedImage.h:

(GeneratorGeneratedImage):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage):
(WebCore):
(WebCore::GraphicsContext::drawImageBuffer):
(WebCore::GraphicsContext::setCompositeOperation):

  • platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContextState::GraphicsContextState):
(GraphicsContextState):
(GraphicsContext):

  • platform/graphics/Image.cpp:

(WebCore::Image::draw):
(WebCore::Image::drawTiled):

  • platform/graphics/Image.h:

(Image):

  • platform/graphics/ImageBuffer.h:

(ImageBuffer):

  • platform/graphics/cairo/BitmapImageCairo.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawNativeImage):
(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::draw):

  • platform/graphics/cg/PDFDocumentImage.h:

(PDFDocumentImage):

  • platform/graphics/qt/GraphicsContextQt.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/qt/ImageQt.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/qt/StillImageQt.cpp:

(WebCore::StillImage::draw):

  • platform/graphics/qt/StillImageQt.h:

(StillImage):

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h:

(BitmapImageSingleFrameSkia):

  • platform/graphics/skia/GraphicsContextSkia.cpp:

(WebCore::GraphicsContext::setPlatformCompositeOperation):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/skia/ImageSkia.cpp:

(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):

  • platform/graphics/win/ImageCGWin.cpp:

(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawSVGToImageBuffer):
(WebCore::SVGImage::draw):
(WebCore::SVGImage::nativeImageForCurrentFrame):

  • svg/graphics/SVGImage.h:

(SVGImage):

Source/WebKit/chromium:

Adding blend mode enumeration to draw functions

  • tests/DragImageTest.cpp:

(WebCore::TestImage::draw):

  • tests/ImageLayerChromiumTest.cpp:

(WebCore::TestImage::draw):

3:20 PM Changeset in webkit [136992] by alecflett@chromium.org
  • 10 edits in trunk/Source

IndexedDB: propagate transaction_ids through open/upgradeneeded
https://bugs.webkit.org/show_bug.cgi?id=103922

Reviewed by Tony Chang.

Source/WebCore:

Make sure front-end is always generating the transaction id,
so that it can be relied upon as an alternative to the
to-be-deprecated IDBTransactionBackendInterface pointer.

No new tests, this is one stage in a larger refactor.

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::create):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::VersionChangeOperation):
(IDBDatabaseBackendImpl::VersionChangeOperation):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::transactionId):
(WebCore::IDBDatabaseBackendImpl::PendingOpenCall::PendingOpenCall):
(IDBDatabaseBackendImpl::PendingOpenCall):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::create):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::transactionId):
(WebCore::IDBDatabaseBackendImpl::PendingOpenWithVersionCall::PendingOpenWithVersionCall):
(IDBDatabaseBackendImpl::PendingOpenWithVersionCall):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
(WebCore::IDBDatabaseBackendImpl::processPendingCalls):
(WebCore::IDBDatabaseBackendImpl::createTransaction):
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendImpl::openConnectionWithVersion):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::openInternal):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::open):

Source/WebKit/chromium:

Update test to account for pre-generated transaction ids.

  • tests/IDBDatabaseBackendTest.cpp:
3:11 PM Changeset in webkit [136991] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk

Implement general ::cue pseudo element for the <video>
https://bugs.webkit.org/show_bug.cgi?id=104043

Patch by Dima Gorbik <dgorbik@apple.com> on 2012-12-07
Reviewed by Eric Carlson.

Source/WebCore:

Implemented the ::cue pseudo element to be able to style all WebVTT cues.
Added the subcontainer with a '::cue' pseudoId in between the TextTrackContainerElement and WebVTT nodes to separate
user agent default styles from user defined styles for the cue elements.

Test: media/track/track-css-all-cues.html

  • css/CSSSelector.cpp: ::cue pseudo selector doesn't have a valid prefix but should be allowed in the user-agent stylesheet.

(WebCore::CSSSelector::parsePseudoType):

  • html/shadow/MediaControlElements.cpp:

(WebCore):
(WebCore::MediaControlTextTrackContainerElement::createSubtrees): create a subcontainer and set its pseudoId to '::cue'.
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): append WebVTT nodes to the newly created subcontainer.

  • html/shadow/MediaControlElements.h:

(MediaControlTextTrackContainerElement):

  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::createTextTrackDisplay): initiate creating subtrees for the MediaControlTextTrackContainerElement.

  • html/shadow/MediaControlsChromium.cpp:

(WebCore::MediaControlsChromium::createTextTrackDisplay):

LayoutTests:

  • media/track/captions-webvtt/styling.vtt: Added.
  • media/track/track-css-all-cues-expected.txt: Added.
  • media/track/track-css-all-cues.html: Added.
3:06 PM Changeset in webkit [136990] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Fix webgl-depth-texture.html to match the test expectation.
https://bugs.webkit.org/show_bug.cgi?id=104259.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-07
Reviewed by Kenneth Russell.

The text expectation of this testcase expects to check for FrameBuffer status and compare the value
using ShouldBe after creating the framebuffer.
Currently, we do it only in case of adding a color buffer. This patch ensures that the Framebuffer
Status check using ShouldBe is done in all cases.

  • fast/canvas/webgl/webgl-depth-texture.html:
2:55 PM Changeset in webkit [136989] by fpizlo@apple.com
  • 5 edits
    3 adds in trunk

Strange results calculating a square root in a loop
https://bugs.webkit.org/show_bug.cgi?id=104247
<rdar://problem/12826880>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Fixed the CFG simplification phase to ignore dead GetLocals in the first of the blocks
under the merge. This fixes the assertion, and is also cleaner: our general rule is
to not "revive" things that we've already proved to be dead.

Also fixed some rotted debug code.

  • dfg/DFGCFGSimplificationPhase.cpp:

(JSC::DFG::CFGSimplificationPhase::fixPossibleGetLocal):

  • dfg/DFGStructureCheckHoistingPhase.cpp:

(JSC::DFG::StructureCheckHoistingPhase::run):

LayoutTests:

  • fast/js/dfg-cfg-simplify-redundant-dead-get-local-expected.txt: Added.
  • fast/js/dfg-cfg-simplify-redundant-dead-get-local.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-cfg-simplify-redundant-dead-get-local.js: Added.

(getDist):
(calcError):

2:47 PM Changeset in webkit [136988] by eae@chromium.org
  • 1 edit
    5 adds
    2 deletes in trunk/LayoutTests

Unreviewed chromium rebaselines.

  • platform/chromium-linux-x86/ietestcenter: Removed.
  • platform/chromium-linux/compositing/backface-visibility: Added.
  • platform/chromium-linux/compositing/backface-visibility/backface-visibility-webgl-expected.png: Added.
  • platform/chromium-mac/compositing/backface-visibility: Added.
  • platform/chromium-mac/compositing/backface-visibility/backface-visibility-webgl-expected.png: Added.
  • platform/chromium-win-xp/http/tests/w3c/webperf/submission/Intel/user-timing: Removed.
  • platform/chromium-win-xp/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_mark-expected.txt: Removed.
  • platform/chromium-win-xp/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
2:40 PM Changeset in webkit [136987] by nghanavatian@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] General code cleanup and improved logging.
https://bugs.webkit.org/show_bug.cgi?id=104389

Reviewed by Rob Buis.

Internally reviewed by Mike Fenton

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::convertStringToWchar):
(BlackBerry::WebKit::InputHandler::requestCheckingOfString):
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):

2:34 PM Changeset in webkit [136986] by ggaren@apple.com
  • 4 edits in trunk/Source

Crash in JSC::Bindings::RootObject::globalObject() sync'ing notes in Evernote
https://bugs.webkit.org/show_bug.cgi?id=104321
<rdar://problem/12770497>

Reviewed by Sam Weinig.

../JavaScriptCore:

Work around a JSValueUnprotect(NULL) in Evernote.

  • API/JSValueRef.cpp:

(evernoteHackNeeded):
(JSValueUnprotect):

../WebCore:

Missed a null check.

  • bindings/objc/WebScriptObject.mm:

(-[WebScriptObject JSObject]): If our root object has been cleared, don't
try to dereference it. This happens in Evernote during tear-down.

This matches the behavior of other methods in the same class.

(_isSafeScript returns false if the root object has been cleared.)

If we believe _isSafeScript is a good idea, it's probably the right test
to use here (as opposed to just null-checking _rootObject) because this API
gives the client unlimited access to the underlying JavaScript object.

2:16 PM Changeset in webkit [136985] by eae@chromium.org
  • 5 edits
    2 adds
    2 deletes in trunk/LayoutTests

Unreviewed chromium rebaselines.

  • platform/chromium-linux-x86/ietestcenter/css3: Removed.
  • platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
  • platform/chromium-mac-lion/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
  • platform/chromium-mac/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
  • platform/efl-wk1/ietestcenter/css3/bordersbackgrounds: Added.
  • platform/efl-wk1/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Removed.
2:13 PM Changeset in webkit [136984] by schenney@chromium.org
  • 5 edits in trunk

XMLSerializer is too aggressive in adding prefixes
https://bugs.webkit.org/show_bug.cgi?id=104387

Reviewed by Ryosuke Niwa.

Source/WebCore:

We have been adding "xlink:" and "xmlns:" and "xml:" prefixes to any
attribute that is in one of those namespaces but which did not already
have the matching prefix. This appears to be in error, at least
compared to other browsers.

The correct behavior appears to be to add the prefix only if there is
no existing prefix. If there is an existing prefix, we now leave it alone.

No new tests. Existing test expanded.

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendAttribute): Only replace the prefix
attribute name prefix if it is empty, and in one of the recognised
namespaces.

LayoutTests:

Add a test case for a prefix that is already set, but to a different name than the default.

  • svg/custom/xlink-prefix-in-attributes.html:
  • svg/custom/xlink-prefix-in-attributes-expected.txt:
2:13 PM Changeset in webkit [136983] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[CoordGfx] Variable name starts with upper case character
https://bugs.webkit.org/show_bug.cgi?id=104327

Patch by Helder Correia <Helder Correia> on 2012-12-07
Reviewed by Noam Rosenthal.

Just fixing a typo.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setMaskLayer):

2:08 PM Changeset in webkit [136982] by jonlee@apple.com
  • 4 edits
    2 deletes in trunk/Source/WebCore

Display the auto-start label image after a delay
https://bugs.webkit.org/show_bug.cgi?id=104173
<rdar://problem/12820071>

Reviewed by Dan Bernstein.

Treat the button now as a label. Once the user has hovered over the plug-in, wait a little while before showing the label.

  • rendering/RenderSnapshottedPlugIn.h:

(RenderSnapshottedPlugIn): Add a one-shot timer, and a variable representing whether the label should
be drawn. Remove the variable that determines whether the label is active.

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): Set the time to a delay of 1 second.
(WebCore::RenderSnapshottedPlugIn::paintReplaced): Paint the label only when we should.
(WebCore::RenderSnapshottedPlugIn::paintLabel): The label should only paint in its hovered state.
(WebCore::startLabelImage): Renamed.
(WebCore::RenderSnapshottedPlugIn::repaintLabel): Renamed.
(WebCore::RenderSnapshottedPlugIn::hoverDelayTimerFired): Now that the timer has fired, we should paint
the label. Repaint.
(WebCore::RenderSnapshottedPlugIn::handleEvent): Update event handling. Click event handler is the
same, except we move the label check inside so that if the click is not the left label we don't
fall through to the other irrevelant if clauses.

For the mouse down handler, make sure to check for the left label. If the hover timer is still running,

stop it, so that we don't draw a label while the user is in the middle of a mouse gesture.

Redo mouse over and out. On mouse over we start the delay timer. On mouse out we stop the delay timer

if it is still running, reset state, and paint the label out.
(WebCore::RenderSnapshottedPlugIn::layout): Refactor.

2:04 PM Changeset in webkit [136981] by nghanavatian@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Strip whitespace from learned text.
https://bugs.webkit.org/show_bug.cgi?id=104391

Reviewed by Rob Buis.

This was removing the first word from the sentence being learned. Using
stripWhiteSpace to remove spaces from the start and end of the text.

Internally reviewed by Mike Fenton.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::learnText):

1:48 PM Changeset in webkit [136980] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/win

Remove WebKit2 related projects from WebKit.sln
https://bugs.webkit.org/show_bug.cgi?id=104395

Reviewed by Tim Horton.

  • WebKit.vcproj/WebKit.sln:
1:34 PM Changeset in webkit [136979] by commit-queue@webkit.org
  • 12 edits
    10 deletes in trunk

[chromium] Remove linux theme related files and switch to default
https://bugs.webkit.org/show_bug.cgi?id=103897

Patch by Scott Violet <sky@chromium.org> on 2012-12-07
Reviewed by Dimitri Glazkov.

Source/Platform:

  • Platform.gypi: Remove WebThemeEngine.h
  • chromium/public/linux/WebThemeEngine.h: Removed.

Source/WebCore:

Linux related theme files are now named Default.

No new tests, code cleanup.

  • WebCore.gyp/WebCore.gyp: Update files
  • WebCore.gypi: Update files
  • platform/chromium/PlatformThemeChromiumLinux.cpp: Removed.
  • platform/chromium/PlatformThemeChromiumLinux.h: Removed.
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: Removed.
  • platform/chromium/ScrollbarThemeChromiumLinux.h: Removed.
  • rendering/RenderThemeChromiumAndroid.cpp:

(WebCore::RenderThemeChromiumAndroid::extraDefaultStyleSheet): Linux->Default

  • rendering/RenderThemeChromiumAndroid.h: Change superclass
  • rendering/RenderThemeChromiumLinux.cpp: Removed.
  • rendering/RenderThemeChromiumLinux.h: Removed.

Source/WebKit/chromium:

Linux theme related files are now named Default.

  • WebKit.gyp:
  • public/linux/WebRenderTheme.h: Removed.
  • public/platform/linux/WebThemeEngine.h: Removed.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setScrollbarColors): Cleanup ifdefs.
(WebKit::WebViewImpl::setSelectionColors): Cleanup ifdefs.

  • src/linux/WebRenderTheme.cpp: Removed.

Tools:

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest): linux->default

1:30 PM Changeset in webkit [136978] by eric.carlson@apple.com
  • 10 edits in trunk

Captions menu doesn't update to track changes
https://bugs.webkit.org/show_bug.cgi?id=104393

Reviewed by Dean Jackson.

Source/WebCore:

Flag the captions menu as needing an update when tracks are added or removed. Don't actually
change the menu until it needs to be displayed.

No new tests, media/video-controls-captions-trackmenu.html was updated to test this.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::addTextTrack): Call closedCaptionTracksChanged().
(WebCore::HTMLMediaElement::didRemoveTrack): Ditto.
(WebCore::HTMLMediaElement::configureTextTracks): Ditto.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlClosedCaptionsTrackListElement::MediaControlClosedCaptionsTrackListElement):

Intialize m_trackListHasChanged.

(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay): Call rebuildTrackListMenu if

the track list has changed.

(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu): Renamed from resetTrackListMenu.

  • html/shadow/MediaControlElements.h:

(WebCore::MediaControlClosedCaptionsTrackListElement::resetTrackListMenu): Just set m_trackListHasChanged.

  • html/shadow/MediaControls.h:

(WebCore::MediaControls::closedCaptionTracksChanged): New, do nothing for base class.

  • html/shadow/MediaControlsApple.cpp:

(WebCore::MediaControlsApple::toggleClosedCaptionTrackList): Update the track list before

showing it.

(WebCore::MediaControlsApple::closedCaptionTracksChanged):

  • html/shadow/MediaControlsApple.h:

LayoutTests:

Test to ensure that the captions menu is updated as tracks added and removed.

  • media/video-controls-captions-trackmenu-expected.txt:
  • media/video-controls-captions-trackmenu.html:
1:29 PM ViewportInteractionTopics edited by kenneth@webkit.org
(diff)
1:27 PM ViewportInteractionTopics edited by kenneth@webkit.org
(diff)
1:26 PM Changeset in webkit [136977] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
1:15 PM Changeset in webkit [136976] by kenneth@webkit.org
  • 20 edits in trunk/Source/WebKit2

[WK2][EFL][Qt] Pixel alignment is wrong in some cases involving a non-integral content scale
https://webkit.org/b/103519

Reviewed by Noam Rosenthal.

This patch removes the blurriness by pixel aligning the layers. It
does not fully remove the shaking, only minimizes it.

  • UIProcess/API/efl/EwkViewImpl.cpp:

(EwkViewImpl::transformFromScene):
(EwkViewImpl::displayTimerFired):

  • UIProcess/API/efl/EwkViewImpl.h:

(EwkViewImpl::pagePosition):

As the pixel alignment of the main layer is moved to the
PageViewportController, rename discretePagePosition to just
pagePosition. It now returns a FloatPoint but the positions
should still be discrete.

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::setVisibleContentsRect):
(WebKit::LayerTreeCoordinatorProxy::didChangeScrollPosition):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::didChangeScrollPosition):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::visibleContentsRect):
(WebKit::LayerTreeCoordinator::setVisibleContentsRect):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.messages.in:
  • WebProcess/WebPage/LayerTreeHost.h:

(WebCore):
(WebKit::LayerTreeHost::setVisibleContentsRect):

Change the internal scroll position/visible contents rect
to be represented as float positions. The rounding to integer
values not happens just before setFixesVisibleContentsRect.
This makes it possible to know our exact positions and
calculate proper scroll deltas.

(WebKit::LayerTreeRenderer::setLayerState):

Group anchor point, position and size together.

  • UIProcess/PageViewportController.h:

(PageViewportController):

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::boundContentsPosition):
(WebKit::PageViewportController::boundContentsPositionAtScale):
(WebKit::PageViewportController::didRenderFrame):
(WebKit::PageViewportController::pageDidRequestScroll):
(WebKit::PageViewportController::didChangeContentsVisibility):
(WebKit::PageViewportController::syncVisibleContents):
(WebKit::PageViewportController::visibleContentsSize):
(WebKit::PageViewportController::applyPositionAfterRenderingContents):

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::focusEditableArea):
(WebKit::PageViewportControllerClientQt::zoomToAreaGestureEnded):
(WebKit::PageViewportControllerClientQt::nearestValidVisibleContentsRect):

Some renaming as what was called viewportPos was actually the
contents position. Rename clampViewportToContents to
boundContentsPosition and remove scale argument which is has
direct access to.

Make the boundContentsPosition allow one extra pixel in each
orientation to allow for pixel alignment of fixed position layers

(WebKit::isIntegral):
(WebKit):
(WebKit::PageViewportController::pixelAlignedFloatPoint):

Introduce way to pixel align the main contents layer. Only in
use for EFL so far.

  • UIProcess/efl/PageClientLegacyImpl.cpp:

(WebKit::PageClientLegacyImpl::updateViewportSize):

  • UIProcess/efl/PageViewportControllerClientEfl.cpp:

(WebKit::PageViewportControllerClientEfl::setViewportPosition):

  • UIProcess/efl/PageViewportControllerClientEfl.h:

(WebKit::PageViewportControllerClientEfl::contentPosition):
(PageViewportControllerClientEfl):

Store the contents position as a FloatPoint.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
(WebCore::CoordinatedGraphicsLayer::setMaskLayer):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::isIntegral):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::computePositionRelativeToBase):
(WebCore::CoordinatedGraphicsLayer::computePixelAlignment):
(WebCore::CoordinatedGraphicsLayer::computeTransformedVisibleRect):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):

Pixel align layers when the effective scale is not an integer
value. This code is based on code from GraphicsLayerCA.

12:56 PM Changeset in webkit [136975] by senorblanco@chromium.org
  • 20 edits
    17 adds in trunk

CSS url() filters with forward references don't work
https://bugs.webkit.org/show_bug.cgi?id=90405

Based on a patch by Keyar Hood.

Reviewed by Dirk Schulze.

Source/WebCore:

In order for CSS to reference SVG filters that will occur later in
the document, or will be added at a future time, we need a way to
notify the target element (the one the filter style is applied to)
when the correct SVG filter is added to the DOM.
There is already code for SVG elements that handles this problem, in
SVGResourcesCache. This patch allows any element to have a reference to
an SVG element in SVGResourceCache.

Tests: css3/filters/effect-reference-after.html

css3/filters/effect-reference-delete-crash.html
css3/filters/effect-reference-delete.html
css3/filters/effect-reference-rename.html
css3/filters/effect-reference-reset-style-delete-crash.html
svg/filters/filter-cycle.html

  • dom/Element.cpp:

(WebCore::Element::hasPendingResources): Added
(WebCore::Element::setHasPendingResources): Added
(WebCore::Element::clearHasPendingResources): Added

  • dom/Element.h:

Accessors for ElementRareData's new bit flag.
(WebCore::Element::buildPendingResource):
Virtual function to override for referenced elements (moved from SVGElement).

  • dom/ElementRareData.h:

(WebCore::ElementRareData::ElementRareData):
Add a new bit flag to indicate whether the element depends on pending resources or not.

  • platform/graphics/texmap/TextureMapperImageBuffer.cpp:

(WebCore::BitmapTextureImageBuffer::applyFilters):
Changed to the new function signature for FilterEffectRenderer::build().

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter):
Changed signature to accept a RenderObject rather than a Document, so we know which node to notify when the SVG filter arrives. If the referenced filter cannot be found, add its id as a pending reference.
(WebCore::FilterEffectRenderer::build):
Changed signature to accept a RenderObject rather than a Document, so we know which node to notify when the SVG filter arrives.

  • rendering/FilterEffectRenderer.h:

Change to signatures of build() and buildReferenceFilter() to pass
a RenderObject instead of a Document.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateOrRemoveFilterEffectRenderer):
Use the new semantics for FilterEffectRenderer::build().

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):
Notify the cache if a RenderObject is destroyed.

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::registerResource):
Call clearHasPendingResourceIfPossible on the SVGDocumentExtensions, not
on the element, since we want to support generic Elements.

  • rendering/svg/SVGResources.cpp:

(WebCore::SVGResources::buildCachedResources):
Add support for building filters on non-SVG elements.

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::SVGResourcesCache::addResourcesFromRenderObject):
Do cycle detection only on SVG elements.
(WebCore::SVGResourcesCache::clientStyleChanged):
For non-SVG elements, set a synthetic style change when parent resources
are invalidated.
(WebCore::SVGResourcesCache::resourceDestroyed):
Add support for non-SVG Elements.

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::addPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::isElementPendingResource):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResourcesForRemoval):
Changed to allow use of Element instead of SVGElement.
(WebCore::SVGDocumentExtensions::clearHasPendingResourcesIfPossible):
Moved from SVGElement, and made to work on any Element. This way,
we avoid adding this function to Element itself.

  • svg/SVGDocumentExtensions.h:

SVGElement -> Element.

  • svg/SVGElement.cpp:
  • svg/SVGElement.h:

All functions moved to Element, except for clearHasPendingResourcesIfPossible() moved to SVGDocumentExtensions.

  • svg/SVGElementRareData.h:

(WebCore::SVGElementRareData::SVGElementRareData):
m_hasPendingResources add accessors moved to ElementRareData.

  • svg/SVGStyledElement.cpp:

(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
SVGElement -> Element, and call SVGDocumentExtensions for
clearHasPendingResourcesIfPossible().

LayoutTests:

  • css3/filters/effect-reference-after-expected.txt: Added.
  • css3/filters/effect-reference-after.html: Added.
  • css3/filters/effect-reference-delete-crash-expected.txt: Added.
  • css3/filters/effect-reference-delete-crash.html: Added.
  • css3/filters/effect-reference-delete-expected.txt: Added.
  • css3/filters/effect-reference-delete.html: Added.
  • css3/filters/effect-reference-rename-expected.txt: Added.
  • css3/filters/effect-reference-rename.html: Added.
  • css3/filters/effect-reference-reset-style-delete-crash-expected.txt: Added.
  • css3/filters/effect-reference-reset-style-delete-crash.html: Added.
  • css3/filters/script-tests/effect-reference-delete-crash.js: Added.
  • css3/filters/script-tests/effect-reference-reset-style-delete-crash.js: Added.
  • svg/filters/filter-cycle.html: Added.
  • svg/filters/filter-cycle-expected.html: Added.
  • platform/chromium-linux/css3/filters/effect-reference-after-expected: Added.
  • platform/chromium-linux/css3/filters/effect-reference-delete-expected.png: Added.
  • platform/chromium-linux/css3/filters/effect-reference-rename-expected.png: Added.
  • platform/chromium/TestExpectations:
12:52 PM Changeset in webkit [136974] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Add shortcut to set visibility:hidden on elements in the ElementsPanel
https://bugs.webkit.org/show_bug.cgi?id=104146

Patch by Eberhard Graether <egraether@google.com> on 2012-12-07
Reviewed by Pavel Feldman.

This change adds the shortcut H to set and unset visibility:hidden on the inline style
of elements in the Elementspanel. This feature makes it easier to look for elements that
cause bad rendering performance, because visibility:hidden does not paint the element,
but preserves the layout.

No new tests.

  • English.lproj/localizedStrings.js:
  • inspector/front-end/CSSStyleModel.js:

(WebInspector.CSSStyleModel.prototype.toggleInlineVisibility):

  • inspector/front-end/ElementsPanelDescriptor.js:

(WebInspector.ElementsPanelDescriptor.prototype.registerShortcuts):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeOutline.prototype.handleShortcut):

  • inspector/front-end/KeyboardShortcut.js:
12:47 PM Changeset in webkit [136973] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r136770): Assertion failure in sendMessage() whenever WebProcess crashes
https://bugs.webkit.org/show_bug.cgi?id=104392

Reviewed by Anders Carlsson.

  • Shared/ChildProcessProxy.cpp: (WebKit::ChildProcessProxy::sendMessage): Changed back to using m_conection where it can be null.
12:41 PM Changeset in webkit [136972] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Improve our decoded data size estimation for style sheets.
<http://webkit.org/b/104388>

Reviewed by Antti Koivisto.

Tweak how we estimate the total decoded size of a given style sheet. (We were guessing at about 30% of actual size.)
This is just used as a hint to the WebCore cache.

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::averageSizeInBytes):

  • css/StyleRule.cpp:

(WebCore::StyleRule::averageSizeInBytes):

12:39 PM Changeset in webkit [136971] by alexis@webkit.org
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening.

css3/calc/background-position-parsing.html is now working as
webkit.org/b/104131 has been fixed. I also rebased
background_position_three_four_values-expected.png which was incorrect and
now with the CSS3 background-position offsets it renders correctly.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
12:34 PM Changeset in webkit [136970] by alexis@webkit.org
  • 4 edits in trunk

[Chromium] Enable CSS3 background-position offset by default.
https://bugs.webkit.org/show_bug.cgi?id=104253

Reviewed by Tony Chang.

Source/WebKit/chromium:

Turn on the feature by default.

  • features.gypi:

LayoutTests:

Enable by default the new CSS3 background position offsets therefore we
can unskip the tests.

  • platform/chromium/TestExpectations:
12:22 PM Changeset in webkit [136969] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] GeolocationClientBB should show file system path in prompts when host is not avaliable
https://bugs.webkit.org/show_bug.cgi?id=103785

PR 247656

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-12-07
Reviewed by Rob Buis.

Adding a special case for origins with protocol "file". We will use the filepath as
an origin when asking for geolocation permission.

If the origin is unique (ie. from a sandboxed iframe), we will fail the location request
right away.

  • WebCoreSupport/GeolocationClientBlackBerry.cpp:

(getOrigin):
(GeolocationClientBlackBerry::requestPermission):
(GeolocationClientBlackBerry::cancelPermissionRequest):

11:34 AM Changeset in webkit [136968] by simonjam@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Enable Intel's Resource Timing tests
https://bugs.webkit.org/show_bug.cgi?id=104330

Reviewed by Tony Gentilcore.

  • platform/chromium/TestExpectations: 2 fail because they rely on iframes.
11:30 AM Changeset in webkit [136967] by robert@webkit.org
  • 3 edits
    4 adds in trunk

REGRESSION(r127163): Content is offset to the right at rea.ru
https://bugs.webkit.org/show_bug.cgi?id=103116

Reviewed by David Hyatt.

Source/WebCore:

The top margin edge of a self-collapsing block that clears a float intrudes up into it by the height of the margin,
so to ensure any child floats of the self-collapsing block only go as far as the top content edge
add the margin back in to the block's current height before placing them.

Tests: fast/block/margin-collapse/self-collapsing-block-with-float-child-collapsed-margins.html

fast/block/margin-collapse/self-collapsing-block-with-float-child.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):

LayoutTests:

  • fast/block/margin-collapse/self-collapsing-block-with-float-child-collapsed-margins-expected.html: Added.
  • fast/block/margin-collapse/self-collapsing-block-with-float-child-collapsed-margins.html: Added.
  • fast/block/margin-collapse/self-collapsing-block-with-float-child-expected.html: Added.
  • fast/block/margin-collapse/self-collapsing-block-with-float-child.html: Added.
11:23 AM Changeset in webkit [136966] by alexis@webkit.org
  • 3 edits in trunk/Source/WebCore

Improve r136754 by hardening checks of expected values for background-position.
https://bugs.webkit.org/show_bug.cgi?id=104380

Reviewed by Antti Koivisto.

r136754 was landed to fix the problem of checking successively two calc
values with validUnit. It was asserting as validUnit expect you to use
the parsed value of the calc after the call. In this case we pre-check the
background-position longhand to count how many values it has to then
call the right parsing functions accordingly. While r136754 is not
wrong it is better to harden isPotentialPositionValue with the real
expected units and keywords. For this matter we can reuse the
ReleaseParsedCalcValueCondition enum which was created with the same
idea as this patch. If you are not interested of the calc parsed
value when calling validUnit() you can now specify it, I believe it is
good to have it explicit to avoid mistake in the future.

No new tests : this is covered by css3/*, fast/backgrounds/*.

  • css/CSSParser.cpp:

(WebCore::CSSParser::validCalculationUnit):
(WebCore::CSSParser::validUnit):
(WebCore::CSSParser::isPotentialPositionValue):

  • css/CSSParser.h:

(WebCore::CSSParser::validUnit):
(CSSParser):

11:16 AM Changeset in webkit [136965] by commit-queue@webkit.org
  • 5 edits in trunk

[BlackBerry] Update BlackBerry Port to use new Graphics::createBuffer BufferType enum values.
https://bugs.webkit.org/show_bug.cgi?id=104121

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-12-07
Reviewed by Rob Buis.

Source/WebKit/blackberry:

Update createBuffer calls to reflect new BufferType enum.
Set buffers opaque if possible to avoid unnecessary blends.
Internal PR 254649
Internal Review: Jakob Petsovits

  • WebKitSupport/BackingStoreTile.cpp:

(BlackBerry::WebKit::TileBuffer::nativeBuffer):

Tools:

Update createBuffer call to reflect new BufferType enum.
Internal PR 254649
Internal Review: Jakob Petsovits

DRT is always backed for maximum compatibility.

  • DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:

(createBitmapContextFromWebView):

11:10 AM Changeset in webkit [136964] by bfulgham@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove unnecessary casts in transformations.
https://bugs.webkit.org/show_bug.cgi?id=104376

Reviewed by Simon Fraser.

Several casts from float-to-double are performed prior to
storing the result in a double type. These casts are unnecessary
overhead and reduce the clarity of the source code.

No new tests. Covered by existing CSS test cases.

  • platform/graphics/transforms/RotateTransformOperation.cpp:
  • platform/graphics/transforms/TransformationMatrix.cpp:
10:49 AM Changeset in webkit [136963] by mkwst@chromium.org
  • 4 edits in trunk/LayoutTests

fast/frames/sandboxed-iframe-scripting.html contains very misleading comments.
https://bugs.webkit.org/show_bug.cgi?id=104363

Reviewed by Darin Adler.

The comments in this test describe a state that is in fact the opposite
of what's being tested. That confused me. This patch corrects the
comments to make it clear that adding a sandbox attribute at runtime has
no effect on the frame; the sandboxing flags are set when the nested
browsing context is _navigated_, not when the attribute changes value.

Spec: http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#attr-iframe-sandbox

  • fast/frames/resources/sandboxed-iframe-script-dynamic.html:
  • fast/frames/sandboxed-iframe-scripting-expected.txt:
  • fast/frames/sandboxed-iframe-scripting.html:
10:26 AM Changeset in webkit [136962] by jochen@chromium.org
  • 2 edits in trunk/Tools

Add 'CHROMIUM_DEVEL_SANDBOX' to the environment variables to copy for layout test drivers
https://bugs.webkit.org/show_bug.cgi?id=104355

Reviewed by Dirk Pranke.

This enables chromium's content_shell driver to run with the full SUID
sandbox.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port.to.setup_environ_for_server):

10:16 AM Changeset in webkit [136961] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Double zoom animation when focusing on input field.
https://bugs.webkit.org/show_bug.cgi?id=104375

Patch by Andrew Lo <anlo@rim.com> on 2012-12-07
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.

UI thread does not need to be notified of a scale change if the WebKit
thread scale has not changed.

This caused issues when two viewport resizes occured one after the other.
Before the scale change due to the first resize could be set in the WK
thread's scale value, it caused WK thread to dispatch a scaleChanged,
overwritting & resetting the new UI thread scale value, resulting in the
double zoom animation.

The larger issue dealing with synchronization between the threads where
scale changes could occur on either thread, however that is beyond the
scope of this change.

Internal PR253122

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::shouldZoomAboutPoint):

10:07 AM Changeset in webkit [136960] by tony@chromium.org
  • 14 edits
    2 copies in branches/chromium/1312

Merge 136878

REGRESSION(r135082): Restore the ability to insert author level style sheets from script
https://bugs.webkit.org/show_bug.cgi?id=104042

Reviewed by Antti Koivisto.

.:

Update exports for Internals.cpp.

  • Source/autotools/symbols.filter:

Source/WebCore:

Add DocumentStyleSheetCollection::addAuthorSheet so embedders can allow scripts
to insert author level styles. Expose the method to window.interals for testing.

Test: userscripts/insert-stylesheets.html

  • WebCore.exp.in: Update exports for Internals.cpp.
  • WebCore.order: Update exports for Internals.cpp.
  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::addAuthorSheet): Add the stylesheet and force a style recalc.
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets): Include author level styles.
(WebCore::DocumentStyleSheetCollection::reportMemoryUsage): Include author styles.

  • dom/DocumentStyleSheetCollection.h:

(WebCore::DocumentStyleSheetCollection::documentAuthorStyleSheets): Accessor.
(DocumentStyleSheetCollection): Keep track of author styles added by script.

  • testing/Internals.cpp:

(WebCore::Internals::insertAuthorCSS): Testing addAuthorSheet.
(WebCore::Internals::insertUserCSS): Testing addUserSheet.

  • testing/Internals.h:
  • testing/Internals.idl: Add addAuthorSheet and addUserSheet.

Source/WebKit/chromium:

  • src/WebDocument.cpp:

(WebKit::WebDocument::insertUserStyleSheet): Use addAuthorSheet if an author level script is requested.

Source/WebKit2:

Update exports for Internals.cpp.

  • win/WebKit2.def.in:

LayoutTests:

Add a test that makes sure that an author level style is set.

  • userscripts/insert-stylesheets-expected.txt: Added.
  • userscripts/insert-stylesheets.html: Added.

TBR=tony@chromium.org
Review URL: https://codereview.chromium.org/11471034

9:54 AM Changeset in webkit [136959] by commit-queue@webkit.org
  • 19 edits
    4 adds in trunk

Provide the backend for exposing the layer tree to the Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=103513

Patch by Antoine Quint <Antoine Quint> on 2012-12-07
Reviewed by Pavel Feldman.

Source/WebCore:

The purpose of this patch is to provide a new agent enabling the Web Inspector to interface
with WebCore to access information about the render layer tree and, more specifically, expose
useful information about layers backed by textures composited on the GPU such as metrics and
backing store. Thus we now provide a LayerTreeAgent which will inform the front-end of
changes to the render layer tree via a new layerTreeDidChange event, providing an object
containing the entire hierarchy of RenderLayers for the inspected document. This hierarchy
can be queried at any time using the .getLayerTree() method on the LayerTreeAgent. Finally,
the LayerTreeAgent also exposes a .nodeIdForLayerId() method allowing to get the id of the
node associated with the RenderLayer with the provided layer id.

In terms of implementation, RenderLayerCompositor has been changed such that in its
updateCompositingLayers() method we call the layerTreeDidChange method on the
InspectorLayerTreeAgent instance via the InspectorInstrumentation.

Test: inspector-protocol/layer-tree.html

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/Inspector.json: Define new types IntRect (x, y, width, height) and Layer, which

holds the information for a RenderLayer (layerId, bounds, isComposited, memory,
compositedBounds) and its children (childLayers). We also define the methods of the
LayerTreeAgent object (enable, disable, getLayerTree, nodeIdForLayerId) and the
layerTreeDidChange event it
fires.

  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::pushNodePathForRenderLayerToFrontend): New method facilitating
pushing the node associated with a given RenderLayer to the front-end.
(WebCore):

  • inspector/InspectorDOMAgent.h:

(InspectorDOMAgent):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::layerTreeDidChangeImpl):
(WebCore::InspectorInstrumentation::renderLayerDestroyedImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::layerTreeDidChange):
(WebCore::InspectorInstrumentation::renderLayerDestroyed):

  • inspector/InspectorLayerTreeAgent.cpp: Added.

(WebCore):
(LayerTreeAgentState):
(WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):
(WebCore::InspectorLayerTreeAgent::~InspectorLayerTreeAgent):
(WebCore::InspectorLayerTreeAgent::setFrontend):
(WebCore::InspectorLayerTreeAgent::clearFrontend):
(WebCore::InspectorLayerTreeAgent::restore):
(WebCore::InspectorLayerTreeAgent::reset):
(WebCore::InspectorLayerTreeAgent::enable):
(WebCore::InspectorLayerTreeAgent::disable):
(WebCore::InspectorLayerTreeAgent::layerTreeDidChange):
(WebCore::InspectorLayerTreeAgent::renderLayerDestroyed):
(WebCore::InspectorLayerTreeAgent::getLayerTree):
(WebCore::InspectorLayerTreeAgent::buildObjectForRootLayer):
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer): Build the entire hierarchy of
RenderLayers from the provided RenderLayer.
(WebCore::InspectorLayerTreeAgent::buildObjectForIntRect):
(WebCore::InspectorLayerTreeAgent::bind):
(WebCore::InspectorLayerTreeAgent::unbind):
(WebCore::InspectorLayerTreeAgent::nodeIdForLayerId):

  • inspector/InspectorLayerTreeAgent.h: Added.

(WebCore):
(InspectorLayerTreeAgent):
(WebCore::InspectorLayerTreeAgent::create):

  • inspector/InstrumentingAgents.h:

(WebCore):
(WebCore::InstrumentingAgents::InstrumentingAgents):
(InstrumentingAgents):
(WebCore::InstrumentingAgents::inspectorLayerTreeAgent):
(WebCore::InstrumentingAgents::setInspectorLayerTreeAgent):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers): Call the layerTreeDidChange method
on the LayerTreeAgent via the InspectorInstrumentation to inform the front-end that the
RenderLayer hierarchy has changed.
(WebCore):
(WebCore::RenderLayerCompositor::layerBecameNonComposited): Call the renderLayerDestroyed
method on the LayerTreeAgent via the InspectorInstrumentation to unbind the layer that is
being destroyed.

  • rendering/RenderLayerCompositor.h:

(RenderLayerCompositor):

LayoutTests:

Adding a LayoutTest that exercises the various APIs and event exposed by the LayerTreeAgent.
This test is skipped on EFL where ACCELERATED_COMPOSITING is not available.

  • inspector-protocol/layer-tree-expected.txt: Added.
  • inspector-protocol/layer-tree.html: Added.
  • platform/efl/TestExpectations:
9:52 AM Changeset in webkit [136958] by jsbell@chromium.org
  • 8 edits in trunk/Source/WebCore

IndexedDB: Check SSV version when opening database
https://bugs.webkit.org/show_bug.cgi?id=102243

Reviewed by Tony Chang.

Ensure that the data format (SerializedScriptValue) isn't "from the future" when opening
a backing store. Treat an unknown version the same as an unknown schema version.

Chromium-side test at https://codereview.chromium.org/11470013/ (same as other schema version tests)

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore):
(WebCore::isSchemaKnown): Check data version as well.
(WebCore::setUpMetadata): Ensure data version is recorded; bump schema version.

  • Modules/indexeddb/IDBLevelDBCoding.cpp: Encoding for "DataVersion" global metadata entry.

(IDBLevelDBCoding):
(WebCore::IDBLevelDBCoding::compare):
(WebCore::IDBLevelDBCoding::DataVersionKey::encode):

  • Modules/indexeddb/IDBLevelDBCoding.h:

(DataVersionKey):
(IDBLevelDBCoding):

  • bindings/js/SerializedScriptValue.cpp:

(SerializedScriptValue::wireFormatVersion): New method (JSC side).

  • bindings/js/SerializedScriptValue.h:
  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::wireFormatVersion): New method (V8 side).
(WebCore):

  • bindings/v8/SerializedScriptValue.h:

(SerializedScriptValue):

8:54 AM Changeset in webkit [136957] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Fix tools for WebKit2-only builds
https://bugs.webkit.org/show_bug.cgi?id=103904

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-12-07
Reviewed by Laszlo Gombos.

The libewebkit2.so should be used for library path for EFL WebKit2.

  • Scripts/webkitdirs.pm:

(builtDylibPathForName):

8:39 AM QtWebKit edited by jocelyn.turcotte@digia.com
Quick cleanup to remove deprecated or misleading information. Those … (diff)
8:32 AM Changeset in webkit [136956] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Throw away StyleResolvers that haven't been used for a long time.
<http://webkit.org/b/104314>

Reviewed by Antti Koivisto.

A lot of memory gets tied up in StyleResolver and the structures and caches that hang from it.
Add a mechanism to throw it away after it's been unused for a while (1 minute.)
This frees up large amounts of memory on inactive pages (background tabs) and static content.

We already have a number of scenarios where the document style is invalidated by throwing away
the StyleResolver so the major code paths are prepared for having a null StyleResolver* on occasion.

~20MB progression on Membuster3.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):

Call document()->didAccessStyleResolver() from the relevant parts of StyleResolver's public API.
This prevents Document from throwing the StyleResolver away for 1 minute after it's used.

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::createStyleResolver):
(WebCore::Document::didAccessStyleResolver):
(WebCore::Document::styleResolverThrowawayTimerFired):

Add a mechanism to call clearStyleResolver() on a refreshing timer.

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

If an attribute change occurs while the document doesn't have a StyleResolver, dirty the element style
since we can't be sure that the attribute change didn't affect any rules.

8:09 AM Changeset in webkit [136955] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding an image mismatch expectation for fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-002.html.

  • platform/gtk/TestExpectations:
7:51 AM Changeset in webkit [136954] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r136947): Made two tests fail on all platforms (Requested by tonikitoo-ll on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=104368

Unreviewed partial rollout.

r136947 was too aggressive in the sense of fixing RenderBox::canBeScrolledAndHasScrollableArea
as part of itself. Revert the related changes in order to fix both
fast/events/autoscroll-should-not-stop-on-keypress.html and
fast/events/autoscroll-in-textfield.html

Patch by Antonio Gomes <a1.gomes@sisa.samsung.com> on 2012-12-07

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::canBeScrolledAndHasScrollableArea):

  • rendering/RenderBox.h:
7:02 AM Changeset in webkit [136953] by allan.jensen@digia.com
  • 5 edits in trunk

[TexMap] Can not do multiple accelerated animations
https://bugs.webkit.org/show_bug.cgi?id=104364

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

By removing all animations with the same name, it is not possible to animate more than one property accelerated.
Instead only remove any animations with both same name and property.

Covered by animations/opacity-transform-animation.html.

  • platform/graphics/GraphicsLayerAnimation.cpp:

(WebCore::GraphicsLayerAnimations::add):
(WebCore::GraphicsLayerAnimations::remove):

  • platform/graphics/GraphicsLayerAnimation.h:

(GraphicsLayerAnimations):

LayoutTests:

Unskip test animating multiple accelerated properties.

  • platform/qt/TestExpectations:
6:52 AM Changeset in webkit [136952] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Fix build warning in StyleResolver.cpp using gcc 4.7.2
https://bugs.webkit.org/show_bug.cgi?id=104262

Patch by Sujin Park <sujjin.park@gmail.com> on 2012-12-07
Reviewed by Alexis Menard.

EFL port treats build warning as compile error and there are
maybe-uninitialized when building with gcc 4.7.2.
This patch adds default case to resolve a build break.

  • css/StyleResolver.cpp:

(WebCore::getFontAndGlyphOrientation):

6:47 AM Changeset in webkit [136951] by pilgrim@chromium.org
  • 3 edits
    1 add in trunk/Source/WebKit/chromium

[Chromium] Move WorkerContextProxy::create out of PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=104151

Reviewed by Kentaro Hara.

Doesn't really solve the layering violation as much as kick it
down the road a bit. Part of a refactoring series; see tracking
bug 82948.

  • WebKit.gyp:
  • src/PlatformSupport.cpp:

(WebCore):

  • src/WorkerContextProxy.cpp: Added.

(WebCore):
(WebCore::WebCore::WorkerContextProxy::create):

6:30 AM Changeset in webkit [136950] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Chromium] Ctrl + ']' "Goto right panel" keyboard shortcut doesn't work
https://bugs.webkit.org/show_bug.cgi?id=104250

Reviewed by Pavel Feldman.

Ignore "keypress" event resulting from a WM_CHAR message emitted by Win7 upon Ctrl + ']' keypress.

  • inspector/front-end/InspectorView.js:

(WebInspector.InspectorView.prototype._keyPress): Ignore all events with charCode < 32.

6:13 AM Changeset in webkit [136949] by pfeldman@chromium.org
  • 18 edits in trunk

Web Inspector: provide a way to reload page with given script preprocessor.
https://bugs.webkit.org/show_bug.cgi?id=80992

Reviewed by Yury Semikhatsky.

Source/WebCore:

This change introduces a way to inject 'preprocessor' script that would process
each JavaScript file before it gets into the VM for compilation. That way inspector
can expose capabilities such as assessing code coverage or tracing all the calls.

Preprocessor script is stored in the page agent where it waits for reload to happen.
Upon reload, ScriptDebugServer is using it to patch the script sources.

Test: inspector/debugger/debugger-script-preprocessor.html

  • bindings/js/ScriptDebugServer.h:

(WebCore::ScriptDebugServer::setScriptPreprocessor):
(ScriptDebugServer):

  • bindings/v8/DebuggerScript.js:
  • bindings/v8/ScriptDebugServer.cpp:

(ScriptDebugServer::ScriptPreprocessor):
(WebCore::ScriptDebugServer::ScriptPreprocessor::ScriptPreprocessor):
(WebCore::ScriptDebugServer::ScriptPreprocessor::preprocessSourceCode):
(WebCore::ScriptDebugServer::ScriptPreprocessor::~ScriptPreprocessor):
(WebCore):
(WebCore::ScriptDebugServer::~ScriptDebugServer):
(WebCore::ScriptDebugServer::setScriptSource):
(WebCore::ScriptDebugServer::setScriptPreprocessor):
(WebCore::ScriptDebugServer::handleV8DebugEvent):

  • bindings/v8/ScriptDebugServer.h:

(ScriptDebugServer):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):

  • inspector/Inspector.json:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorDebuggerAgent.h:

(InspectorDebuggerAgent):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::reload):
(WebCore::InspectorPageAgent::frameNavigated):

  • inspector/InspectorPageAgent.h:

(WebCore::InspectorPageAgent::page):
(WebCore::InspectorPageAgent::scriptPreprocessor):
(InspectorPageAgent):

  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::create):
(WebCore::PageDebuggerAgent::PageDebuggerAgent):
(WebCore::PageDebuggerAgent::startListeningScriptDebugServer):
(WebCore::PageDebuggerAgent::stopListeningScriptDebugServer):
(WebCore::PageDebuggerAgent::injectedScriptForEval):
(WebCore::PageDebuggerAgent::didClearMainFrameWindowObject):
(WebCore):

  • inspector/PageDebuggerAgent.h:

(WebCore):
(PageDebuggerAgent):

LayoutTests:

  • http/tests/inspector/inspector-test.js:

(initialize_InspectorTest.InspectorTest.hardReloadPage):
(initialize_InspectorTest.InspectorTest.reloadPage):
(initialize_InspectorTest.InspectorTest._innerReloadPage):

  • inspector/debugger/debugger-script-preprocessor-expected.txt: Added.
  • inspector/debugger/debugger-script-preprocessor.html: Added.
  • platform/chromium/inspector/debugger/debugger-script-preprocessor-expected.txt: Added.
5:22 AM Changeset in webkit [136948] by apavlov@chromium.org
  • 5 edits
    2 adds in trunk

Web Inspector: the "Sources" column is always empty in CSS selector profiles
https://bugs.webkit.org/show_bug.cgi?id=104225

Reviewed by Pavel Feldman.

Source/WebCore:

r112923 and preceding changesets modified the CSSOM wrapper creation for StyleRules in a way
that would not specify the parent CSSStyleSheet for the CSSStyleRules created. Instead,
styleResolver->ensureFullCSSOMWrapperForInspector(rule) is now used to make sure the CSSStyleRule
has a valid parent CSSStyleSheet.

Test: inspector/profiler/selector-profiler-url.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::applyProperties):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willMatchRuleImpl):
(WebCore::InspectorInstrumentation::willProcessRuleImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore):
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willMatchRule):
(WebCore::InspectorInstrumentation::willProcessRule):

LayoutTests:

  • inspector/profiler/selector-profiler-url-expected.txt: Added.
  • inspector/profiler/selector-profiler-url.html: Added.
5:03 AM Changeset in webkit [136947] by tonikitoo@webkit.org
  • 5 edits in trunk/Source/WebCore

Rework bug 97927 to not depend on RenderLayer::allowsScrolling
https://bugs.webkit.org/show_bug.cgi?id=103999

Reviewed by James Robinson.
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>

Patch makes it possible for methods like
RenderLayer::{updateScrollbarsAfterLayout,updateScrollbarsAfterStyleChange}
to not depend on RenderLayer::allowsScrolling to determine if a layer should
be added or removed from its FrameView's ScrollableArea set.

Following the same logic, the patch also fixes RenderBox::canBeScrolledAndHasScrollableArea
method to take into account the box' scroll allowance in a given direction only
when it overflows. This allows simplifying custom methods like InRegionScrollerPrivate::canScrollRenderBox
(@WebKit/blackberry/Api/InRegionScroller.cpp).

The naming pattern for the newly added methods were chosen to keep the consistency
with the existing ones, in the same class.

No new test: it is already covered by ScrollingCoordinatorChromiumTest.clippedBodyTest.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::canBeScrolledAndHasScrollableArea):

  • rendering/RenderBox.h:

(RenderBox):
(WebCore::RenderBox::hasScrollableOverflowX):
(WebCore::RenderBox::hasScrollableOverflowY):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hasScrollableHorizontalOverflow):
(WebCore):
(WebCore::RenderLayer::hasScrollableVerticalOverflow):
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
(WebCore::RenderLayer::updateScrollbarsAfterStyleChange):

  • rendering/RenderLayer.h:

(RenderLayer):

4:57 AM Changeset in webkit [136946] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] make "isVideo" information available to platform media player
https://bugs.webkit.org/show_bug.cgi?id=104334

Patch by Max Feil <mfeil@rim.com> on 2012-12-07
Reviewed by Rob Buis.

The platform player needs to know whether the element is <video>
or <audio>, so it can make certain decisions before metadata
is ready. This is part of a performance optimization refactor
which does not change functionality so no new tests are required.

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::MediaPlayerPrivate::load):

4:47 AM Changeset in webkit [136945] by loislo@chromium.org
  • 2 edits
    2 moves
    4 deletes in trunk/LayoutTests

Web Inspector: enable inspector tests on chromium-mac.
https://bugs.webkit.org/show_bug.cgi?id=104357

Reviewed by Pavel Feldman.

After chromium r171707 patch we can enable inspector tests on chromium-mac.
Two expectation files were moved from chromium-win to chromium because chromium-mac doesn't inherit expectations from chromium-win.

Expectations in chromium-mac were removed because they were added by mistake.
[ Win Linux ] filter was removed because I need to add Mac but [ Mac Win Linux ] is equivalent to nothing.

  • platform/chromium-mac/inspector/console/command-line-api-getEventListeners-expected.txt: Removed.
  • platform/chromium-mac/inspector/cookie-parser-expected.txt: Removed.
  • platform/chromium-mac/inspector/debugger/debugger-activation-crash2-expected.txt: Removed.
  • platform/chromium-mac/inspector/debugger/event-listener-breakpoints-expected.txt: Removed.
  • platform/chromium/TestExpectations:
  • platform/chromium/inspector/console/command-line-api-getEventListeners-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/console/command-line-api-getEventListeners-expected.txt.
  • platform/chromium/inspector/debugger/debugger-scripts-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/debugger/debugger-scripts-expected.txt.
4:38 AM Changeset in webkit [136944] by sudarsana.nagineni@linux.intel.com
  • 1 edit
    2 adds
    4 deletes in trunk/LayoutTests

Unreviewed EFL gardening.

Remove platform-specific baselines for viewsource-attribute.html
and viewsource-on-image-file.html as the current results matches
base expectations. Also, add missing platform-specific baselines
for fast/text/decorations-with-text-combine.html.

  • platform/efl-wk2/fast/frames/viewsource-attribute-expected.png: Removed.
  • platform/efl-wk2/fast/frames/viewsource-attribute-expected.txt: Removed.
  • platform/efl-wk2/fast/frames/viewsource-on-image-file-expected.png: Removed.
  • platform/efl-wk2/fast/frames/viewsource-on-image-file-expected.txt: Removed.
  • platform/efl/fast/text/decorations-with-text-combine-expected.png: Added.
  • platform/efl/fast/text/decorations-with-text-combine-expected.txt: Added.
4:01 AM Changeset in webkit [136943] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/qt

[Qt][Qnx] Fix QNX build by adding missing include.
https://bugs.webkit.org/show_bug.cgi?id=104359

Patch by Sergio Martins <sergio.martins@kdab.com> on 2012-12-07
Reviewed by Jocelyn Turcotte.

It's where WEBKIT_EXPORTDATA is defined, so include it. Not sure why other
platforms aren't failing.

  • WebCoreSupport/QWebPageAdapter.h:
2:50 AM Changeset in webkit [136942] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] [AC] Implement ImageExtractor::extractImage in GraphicsContext3DEfl.
https://bugs.webkit.org/show_bug.cgi?id=104271.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-07
Reviewed by Kenneth Rohde Christiansen.

This patch implements ImageExtractor::extractImage in GraphicsContext3DEfl.

Covered by existing tests.

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::~ImageExtractor):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

2:47 AM Changeset in webkit [136941] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add ewk_settings APIs for text autosizing
https://bugs.webkit.org/show_bug.cgi?id=103342

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2012-12-07
Reviewed by Kenneth Rohde Christiansen.

Add ewk_settings_text_autosizing_enabled_get / set() functions.
Text autosizing is disabled by default.

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_text_autosizing_enabled_set):
(ewk_settings_text_autosizing_enabled_get):

  • UIProcess/API/efl/ewk_settings.h:
  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

2:22 AM Changeset in webkit [136940] by commit-queue@webkit.org
  • 7 edits in trunk

[BlackBerry] DRT - Update implementation of TestRunner.setCustomPolicyDelegate()
https://bugs.webkit.org/show_bug.cgi?id=104243

RIM PR 259337

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-12-07
Reviewed by Rob Buis.

Source/WebKit/blackberry:

  1. Add DRT callback in dispatchDecidePolicyForResponse.
  2. Pass frame pointer to DRT callback in

dispatchDecidePolicyForNavigationAction, so that it can be used to
calculate originating.

  1. Fix some webkit style errors.

The patch fixed the following tests:

  • http/tests/download
  • fast/forms/mailto/formenctype-attribute-button-html.html
  • fast/forms/mailto/formenctype-attribute-input-html.html
  • fast/encoding/mailto-always-utf-8.html
  • Api/DumpRenderTreeClient.h:
  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForResponse):
(WebCore::FrameLoaderClientBlackBerry::dispatchDecidePolicyForNavigationAction):
(WebCore::FrameLoaderClientBlackBerry::transitionToCommittedForNewPage):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):
(WebCore::FrameLoaderClientBlackBerry::dispatchWillSendRequest):
(WebCore::FrameLoaderClientBlackBerry::decidePolicyForExternalLoad):

Tools:

  1. Implement calculation of navigation originating in

didDecidePolicyForNavigationAction().

  1. Implement policy delegate for resource response.
  2. Enable customPolicyDelegate if waitForPolicyDelegate() is called.
  3. Minor optional updates in dump() and dumpFrameLoadCallbacks().

The patch fixed the following tests:

  • http/tests/download
  • fast/forms/mailto/formenctype-attribute-button-html.html
  • fast/forms/mailto/formenctype-attribute-input-html.html
  • fast/encoding/mailto-always-utf-8.html
  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
(BlackBerry::WebKit::DumpRenderTree::dump):
(BlackBerry::WebKit::DumpRenderTree::didFinishLoadForFrame):
(BlackBerry::WebKit::DumpRenderTree::didDecidePolicyForNavigationAction):
(BlackBerry::WebKit::DumpRenderTree::didDecidePolicyForResponse):
(BlackBerry::WebKit::DumpRenderTree::setCustomPolicyDelegate):

  • DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:

(DumpRenderTree):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:

(TestRunner::setCustomPolicyDelegate):
(TestRunner::waitForPolicyDelegate):
(TestRunner::overridePreference):

1:58 AM Changeset in webkit [136939] by loislo@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed roll crhomium to r171707.

  • DEPS:
1:56 AM Changeset in webkit [136938] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

Use always the order iterator from data member in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=104112

Reviewed by Tony Chang.

Some methods receive it as parameter and others use the data
member.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::computeNextFlexLine):
(WebCore::RenderFlexibleBox::alignFlexLines):
(WebCore::RenderFlexibleBox::alignChildren):
(WebCore::RenderFlexibleBox::flipForRightToLeftColumn):
(WebCore::RenderFlexibleBox::flipForWrapReverse):

  • rendering/RenderFlexibleBox.h:
1:53 AM Changeset in webkit [136937] by tkent@chromium.org
  • 2 edits in trunk/Source/WebCore

Improve confusing code in BaseMultipleFieldsDateAndTimeInputType
https://bugs.webkit.org/show_bug.cgi?id=104353

Reviewed by Kentaro Hara.

This doesn't change any behavior because call sites of
isEditControlOwnerDisabled and isEditControlOwnerReadOnly treat them
similarly.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerDisabled):
Checks element()->disabled, not readOnly.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerReadOnly):
Checks element()->readOnly, not disabled.

1:16 AM Changeset in webkit [136936] by kkristof@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Gardening after r136857, r136893 and 136919.
https://bugs.webkit.org/show_bug.cgi?id=104351

Patch by János Badics <János Badics> on 2012-12-07
Reviewed by Csaba Osztrogonác.

r136857: skipped a newly added failing reftest.
r136893: skipped two newly added xmlhttprequest tests
r136919: skipped a test because layoutTestController.setBackingScaleFactor() is unimplemented

  • platform/qt/TestExpectations:
1:09 AM Changeset in webkit [136935] by tkent@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

REGRESSION(r136631): Fix null pointer dereference in WebPagePopupImpl::paint
https://bugs.webkit.org/show_bug.cgi?id=104350

Reviewed by Hajime Morita.

We changed WebPagePopupImpl so that it deleted m_page in
closePopup. However, paint function is still called.

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::paint): Block by m_closing.

12:49 AM Changeset in webkit [136934] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

[Qt] Adjust library name in layout_tests/port/qt.py after Qt5-r40
https://bugs.webkit.org/show_bug.cgi?id=104348

Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2012-12-07
Reviewed by Csaba Osztrogonác.

After Qt-5.0.0-r40, the library was renamed from QtWebKitWidgets to
Qt5WebKitWidgets. run-webkit-tests were still looking for QtWebKitWidgets

  • Scripts/webkitpy/layout_tests/port/qt.py:

(QtPort._path_to_webcore_library):

12:46 AM Changeset in webkit [136933] by jonlee@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • plugins/PlugInOriginHash.cpp:

(WebCore::PlugInOriginHash::hash):

12:43 AM Changeset in webkit [136932] by jonlee@apple.com
  • 7 edits
    2 adds in trunk/Source/WebCore

Add PlugInOriginHash
https://bugs.webkit.org/show_bug.cgi?id=103655
<rdar://problem/12778949>

Reviewed by Alexey Proskuryakov.

Add the concept of plug-in origin hashes, which are based on a combination of the base domains of the
page's main frame and the plug-in, and the plug-in MIME type.

  • plugins/PlugInOriginHash.cpp: Added.

(WebCore::addCaseFoldedCharacters): Add the case-folded string to the hash.
(WebCore::PlugInOriginHash::hash): The hash is based on the concatenation of the page's host, the plug-in
URL's host, and the MIME type. We use StringHasher to get all 32-bits of the hash, since using StringImpl's hash
masks out 8 of the hash bits to make room for bit flags.

  • plugins/PlugInOriginHash.h: Added.
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
12:25 AM Changeset in webkit [136931] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed fix, unbreak run-launcher after library renaming.

  • Scripts/webkitdirs.pm:

(builtDylibPathForName):

12:25 AM Changeset in webkit [136930] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] new target window would cause the url being loaded twice
https://bugs.webkit.org/show_bug.cgi?id=104086

Reviewed by Yong Li.

When webkit need to open window for a new target like "_blank", it would
load the url subsequently after createWindow. But the chrome browser would
load the url again when it get the OpenWindowEvent from native, which
causes the url being loaded twice. We should make sure that createWindow() be
used to create a new window only, not loading url, so we pass empty url
as parameter.

RIM PR# 257329
Internally reviewed by Charles Wei.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchCreatePage):

12:04 AM Changeset in webkit [136929] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Unreviewed fix after r136896, unbreak --debug-rwt to make bots result verbose again.
https://bugs.webkit.org/show_bug.cgi?id=104296

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(main):

Dec 6, 2012:

11:46 PM Changeset in webkit [136928] by tkent@chromium.org
  • 6 edits in trunk/Source

Refactoring: Clean up placeholder attribute usage
https://bugs.webkit.org/show_bug.cgi?id=104337

Reviewed by Kentaro Hara.

Source/WebCore:

No new tests. This doesn't change any behavior.

  • html/HTMLInputElement.cpp: Remove placeholder and setPlacehodler.
  • html/HTMLInputElement.h: Ditto.
  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::strippedPlaceholder):
We can use fastGetAttribute for placeholder.
(WebCore::HTMLTextFormControlElement::isPlaceholderEmpty):
Ditto.

Source/WebKit/chromium:

  • src/WebInputElement.cpp:

(WebKit::WebInputElement::setPlaceholder):
Use setAttribute.
(WebKit::WebInputElement::placeholder):
Use fastGetAttribute.

11:44 PM Changeset in webkit [136927] by fpizlo@apple.com
  • 9 edits
    3 adds in trunk

Incorrect inequality for checking whether a statement is within bounds of a handler
https://bugs.webkit.org/show_bug.cgi?id=104313
<rdar://problem/12808934>

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

The most relevant change is in handlerForBytecodeOffset(), which fixes the inequality
used for checking whether a handler is pertinent to the current instruction. '<' is
correct, but '<=' isn't, since the 'end' is not inclusive.

Also found, and addressed, a benign goof in how the finally inliner works: sometimes
we will have end > start. This falls out naturally from how the inliner works and how
we pop scopes in the bytecompiler, but it's sufficiently surprising that, to avoid any
future confusion, I added a comment and some code to prune those handlers out. Because
of how the handler resolution works, these handlers would have been skipped anyway.

Also made various fixes to debugging code, which was necessary for tracking this down.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::handlerForBytecodeOffset):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):

  • bytecompiler/Label.h:

(JSC::Label::bind):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::throwException):

  • llint/LLIntExceptions.cpp:

(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::handleHostCall):

LayoutTests:

  • fast/js/jsc-test-list:
  • fast/js/script-tests/try-catch-try-try-catch-try-finally-return-catch-finally.js: Added.

(foo):

  • fast/js/try-catch-try-try-catch-try-finally-return-catch-finally-expected.txt: Added.
  • fast/js/try-catch-try-try-catch-try-finally-return-catch-finally.html: Added.
11:24 PM Changeset in webkit [136926] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[chromium] Introduce setting for low latency rendering
https://bugs.webkit.org/show_bug.cgi?id=104011

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-12-06
Reviewed by James Robinson.

This low latency rendering setting will be used to enable alternate
render signaling and scheduling to reduce latency.

Source/Platform:

  • chromium/public/WebLayerTreeView.h:

(WebKit::WebLayerTreeView::Settings::Settings):
(Settings):

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::WebSettingsImpl):
(WebKit::WebSettingsImpl::setLowLatencyRenderingEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):
(WebKit::WebSettingsImpl::lowLatencyRenderingEnabled):

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

11:21 PM Changeset in webkit [136925] by tkent@chromium.org
  • 12 edits in trunk/Source/WebCore

Refactoring: Rename HTMLFormControlElement::required to isRequired
https://bugs.webkit.org/show_bug.cgi?id=104336

Reviewed by Kentaro Hara.

m_required should be m_isRequired, and required() should be
isRequired. It's safe to rename them because HTML*Element::required IDL
attributes are [Reflected].
http://www.webkit.org/coding/coding-style.html#names-bool

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isRequired):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithControl):

  • dom/CheckedRadioButtons.cpp:

(WebCore::RadioButtonGroup::add):
(WebCore::RadioButtonGroup::requiredAttributeChanged):
(WebCore::RadioButtonGroup::remove):

  • html/CheckboxInputType.cpp:

(WebCore::CheckboxInputType::valueMissing):

  • html/FileInputType.cpp:

(WebCore::FileInputType::valueMissing):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::HTMLFormControlElement):
(WebCore::HTMLFormControlElement::parseAttribute):
(WebCore::HTMLFormControlElement::isRequired):

  • html/HTMLFormControlElement.h:

(HTMLFormControlElement):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::isRequiredFormControl):
(WebCore::HTMLInputElement::setupDateTimeChooserParameters):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::valueMissing):
(WebCore::HTMLSelectElement::isRequiredFormControl):

  • html/HTMLTextAreaElement.h:

(WebCore::HTMLTextAreaElement::isRequiredFormControl):

  • html/TextFieldInputType.cpp:

(WebCore::TextFieldInputType::valueMissing):

11:20 PM Changeset in webkit [136924] by morrita@google.com
  • 21 edits
    2 adds in trunk

[Shadow DOM] Implement Element::shadowRoot with prefix
https://bugs.webkit.org/show_bug.cgi?id=102912

Reviewed by Dimitri Glazkov.

  • Added Element::shadowRoot() which return the youngest author shadow root.
  • Renamed existing Node::shadowRoot() to containingShadowRoot() to avoid name shadowing. The name shadowRoot() is confusing anyway so this is good opportunity to rename it.

Test: fast/dom/shadow/shadow-aware-shadow-root.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkSelector):

  • css/StyleScopeResolver.cpp:

(WebCore::StyleScopeResolver::scopeFor):
(WebCore::StyleScopeResolver::addHostRule):

  • dom/Element.cpp:

(WebCore::Element::shadowRoot):
(WebCore):

  • dom/Element.h:

(Element):

  • dom/Element.idl:
  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::setShouldCollectSelectFeatureSet):

  • dom/Node.cpp:

(WebCore::Node::rendererIsEditable):
(WebCore::Node::shadowHost):
(WebCore::Node::shadowAncestorNode):
(WebCore::Node::containingShadowRoot):

  • dom/Node.h:

(Node):

  • dom/Range.cpp:

(WebCore::Range::shadowRoot):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::insertedInto):
(WebCore::ShadowRoot::removedFrom):

  • dom/ShadowRoot.h:

(WebCore::ShadowRoot::isAccessible):

  • editing/TextIterator.cpp:

(WebCore::TextIterator::handleReplacedElement):

  • editing/htmlediting.cpp:

(WebCore::indexForVisiblePosition):

  • html/HTMLStyleElement.cpp:

(WebCore::HTMLStyleElement::scopedAttributeChanged):
(WebCore::HTMLStyleElement::registerWithScopingNode):
(WebCore::HTMLStyleElement::removedFrom):

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::distribute):

  • html/shadow/HTMLContentElement.cpp:

(WebCore::HTMLContentElement::parseAttribute):
(WebCore::HTMLContentElement::insertedInto):
(WebCore::HTMLContentElement::removedFrom):

  • html/shadow/HTMLShadowElement.cpp:

(WebCore::HTMLShadowElement::insertedInto):
(WebCore::HTMLShadowElement::removedFrom):

  • html/shadow/InsertionPoint.cpp:

(WebCore::InsertionPoint::attach):
(WebCore::InsertionPoint::detach):
(WebCore::InsertionPoint::isActive):
(WebCore::InsertionPoint::childrenChanged):
(WebCore::InsertionPoint::insertedInto):
(WebCore::InsertionPoint::removedFrom):
(WebCore::InsertionPoint::setResetStyleInheritance):

  • page/EventHandler.cpp:

(WebCore::instanceAssociatedWithShadowTreeElement):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::correspondingElement):
(WebCore::collectInstancesForSVGElement):

11:02 PM Changeset in webkit [136923] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Replace int64 with int64_t
https://bugs.webkit.org/show_bug.cgi?id=104338

Patch by Michael Pruett <michael@68k.org> on 2012-12-06
Reviewed by Kentaro Hara.

Cleaning up coding inconsistencies, no change in behavior.

Tests: storage/indexeddb/*

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::openInternal):

10:22 PM Changeset in webkit [136922] by noel.gordon@gmail.com
  • 1 edit
    7 adds in trunk/LayoutTests

Unreviewed Gardening. More http://trac.webkit.org/changeset/136910. Add Chromium Linux results.

  • platform/chromium-linux/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_clearMarks-expected.txt: Added.
  • platform/chromium-linux/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_mark-expected.txt: Added.
9:40 PM Changeset in webkit [136921] by tkent@chromium.org
  • 9 edits in trunk/Source/WebKit/chromium

[Chromium] Rename some init* functions to initialize*
https://bugs.webkit.org/show_bug.cgi?id=104335

Reviewed by Kentaro Hara.

We should use full words.
http://www.webkit.org/coding/coding-style.html#names-full-words

  • src/WebHelperPluginImpl.cpp:

(WebKit::WebHelperPluginImpl::initialize): Renamed from init.
(WebKit::WebHelperPluginImpl::initializePage): Renamed from initPage.

  • src/WebHelperPluginImpl.h:

(WebHelperPluginImpl):

  • src/WebPagePopupImpl.cpp:

(WebKit::WebPagePopupImpl::initialize): Renamed from init.
(WebKit::WebPagePopupImpl::initializePage): Renamed from initPage.

  • src/WebPagePopupImpl.h:

(WebPagePopupImpl):

  • src/WebPopupMenuImpl.cpp:

(WebKit::WebPopupMenuImpl::initialize): Renamed from init.

  • src/WebPopupMenuImpl.h:
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::openPagePopup): Follow the renamings.
(WebKit::WebViewImpl::createHelperPlugin): Ditto.

  • src/ChromeClientImpl.cpp:

(WebKit::ChromeClientImpl::popupOpened): Ditto.

9:08 PM Changeset in webkit [136920] by simonjam@chromium.org
  • 4 edits in trunk

[Resource Timing] Allow detailed timing on same origin sites
https://bugs.webkit.org/show_bug.cgi?id=104328

Reviewed by Tony Gentilcore.

Source/WebCore:

This block was lost when I moved it to PerformanceResourceTiming.cpp.

Test: http/tests/w3c/webperf/submission/resource-timing/html/test_resource_attribute_order.html

  • page/PerformanceResourceTiming.cpp:

(WebCore::passesTimingAllowCheck):

LayoutTests:

  • platform/chromium/TestExpectations: This was mismarked as an iframe failure.
7:07 PM Changeset in webkit [136919] by commit-queue@webkit.org
  • 45 edits
    7 adds in trunk

CSS cursor property should support webkit-image-set
https://bugs.webkit.org/show_bug.cgi?id=99493

Patch by Rick Byers <rbyers@chromium.org> on 2012-12-06
Reviewed by Beth Dakin.

.:

Add ENABLE_MOUSE_CURSOR_SCALE (disabled by default)

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Add ENABLE_MOUSE_CURSOR_SCALE (disabled by default)

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Add support for image scale factors attached to custom mouse cursor images
behind ENABLE(MOUSE_CURSOR_SCALE).

This required refactoring CSSCursorImageValue to derive directly from
CSSValue since it can contain either a CSSImageValue or a CSSImageSetValue.
If it contains an image-set, then we can plumb directly through to the
CSSImageSetValue. If it contains an image, then either we can plumb directly
through to the CSSImageValue, or if the URL represents an SVG cursor we have
to intercept the image loading in order to substitute the actual SVG image URL
and do the appropriate lifetime management.

Tests: fast/css/cursor-parsing-image-set.html

fast/events/mouse-cursor-image-set.html

  • Configurations/FeatureDefines.xcconfig: Add ENABLE_MOUSE_CURSOR_SCALE - disabled
  • GNUmakefile.features.am: ditto
  • css/CSSCursorImageValue.cpp: Refactor to inherit directly from CSSValue and support image sets

(WebCore::CSSCursorImageValue::CSSCursorImageValue):
(WebCore::CSSCursorImageValue::~CSSCursorImageValue):
(WebCore::CSSCursorImageValue::customCssText):
(WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
(WebCore::CSSCursorImageValue::cachedImage):
(WebCore::CSSCursorImageValue::cachedOrPendingImage):
(WebCore::CSSCursorImageValue::isSVGCursor):
(WebCore::CSSCursorImageValue::cachedImageURL):
(WebCore::CSSCursorImageValue::clearCachedImage):
(WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):

  • css/CSSCursorImageValue.h: Remove cursor-specific hacks

(WebCore::CSSCursorImageValue::create):
(CSSCursorImageValue):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::cachedImage):

  • css/CSSImageValue.h:

(CSSImageValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Parse cursor(-webkit-image-set(...)) rules

  • css/CSSValue.h:

(WebCore::CSSValue::isImageValue):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyCursor::applyValue):

  • css/StyleResolver.cpp: Hook up new CSSCursorImageValue support since it can't be handled like other images any more.

(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::StyleResolver::loadPendingImage):

  • css/StyleResolver.h:

(StyleResolver):

  • page/EventHandler.cpp:

(WebCore::EventHandler::selectCursor): Handle StyleCachedImageSet images and plumb scale factor through

  • platform/Cursor.cpp:

(WebCore::Cursor::Cursor): Add imageScaleFactor

  • platform/Cursor.h: Add imageScaleFactor

(Cursor):
(WebCore::Cursor::imageScaleFactor):

  • platform/chromium/CursorChromium.cpp: Add imageScaleFactor

(WebCore::Cursor::Cursor):
(WebCore::Cursor::operator=):

  • rendering/style/CursorData.h: Clarify hotspot units

(CursorData):

  • rendering/style/StyleCachedImage.h:

(StyleCachedImage::cachedImage): Override new virtual.

  • rendering/style/StyleCachedImageSet.h:

(StyleCachedImageSet::cachedImage): Override new virtual.

  • rendering/style/StyleImage.h:

(StyleImage::cachedImage): Add new virtual method to avoid lots of casts and typechecks.

  • rendering/style/StylePendingImage.h: Add CSSCursorImageValue support

(WebCore::StylePendingImage::cssCursorImageValue):

  • testing/Internals.cpp:

(WebCore::Internals::getCurrentCursorInfo): Print non-identity scale factors for testing

Source/WebKit/chromium:

Add ENABLE_MOUSE_CURSOR_SCALE and enable it on the chromium port.
Plumb cursor image scale factor through to chromium API.

  • features.gypi:
  • public/WebCursorInfo.h:
  • src/WebCursorInfo.cpp:

(WebKit::WebCursorInfo::WebCursorInfo):

Source/WebKit/mac:

Add ENABLE_MOUSE_CURSOR_SCALE - disabled by default.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Add ENABLE_MOUSE_CURSOR_SCALE - disabled by default.

  • Configurations/FeatureDefines.xcconfig:

Tools:

Add ENABLE_MOUSE_CURSOR_SCALE - disabled by default

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

Add ENABLE_MOUSE_CURSOR_SCALE - disabled by default

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

Add tests for parser round-tripping of cursor rules with -webkit-image-set,
and also end-to-end mouse cursor tests that validate the cursor details
ultimately used at different device scales.

Tests are disabled on ports other than chromium (require ENABLE(MOUSE_CURSOR_SCALE))

  • fast/css/cursor-parsing-image-set-expected.txt: Added.
  • fast/css/cursor-parsing-image-set.html: Added.
  • fast/events/mouse-cursor-image-set-expected.txt: Added.
  • fast/events/mouse-cursor-image-set.html: Added.
  • fast/events/resources/greenbox200.png: Added.
  • fast/events/resources/greenbox30-hotspot28-3.cur: Added.
  • fast/events/resources/greenbox30.png: Added.
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
7:03 PM Changeset in webkit [136918] by hayato@chromium.org
  • 8 edits
    2 adds in trunk

Event's relatedTarget re-targeting does not occur for manually fired mouse events created by event.initMouseEvent().
https://bugs.webkit.org/show_bug.cgi?id=102681

Reviewed by Dimitri Glazkov.

Source/WebCore:

Make sure that event's relatedTarget re-targeting occurs for mouse
events created by event.initMouseEvent(). Since user-generated
mouse events can have a relatedTarget which is same to the target
node, the algorithm which calculates event's ancestors is also
updated so that ancestors are not shrunk wrongly.

Test: fast/events/dispatch-synthetic-mouseevent.html

fast/dom/shadow/shadow-dom-event-dispatching.html

  • dom/EventDispatcher.cpp:

(WebCore::EventRelatedTargetAdjuster::adjust):

  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::create):
(WebCore::MouseEventDispatchMediator::MouseEventDispatchMediator):
(WebCore::MouseEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.h:

(WebCore::MouseEventDispatchMediator::isSyntheticMouseEvent):
(MouseEventDispatchMediator):

  • dom/Node.cpp:

(WebCore::Node::dispatchEvent):

LayoutTests:

  • fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
  • fast/dom/shadow/shadow-dom-event-dispatching.html:
  • fast/events/dispatch-synthetic-mouseevent-expected.txt: Added.
  • fast/events/dispatch-synthetic-mouseevent.html: Added.
6:57 PM Changeset in webkit [136917] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

[chromium] Rename non-standard discard/ensureFramebufferCHROMIUM extensions so we can use real GL_EXT_discard_framebuffer
https://bugs.webkit.org/show_bug.cgi?id=104316

Patch by James Robinson <jamesr@chromium.org> on 2012-12-06
Reviewed by Kenneth Russell.

GL_EXT_discard_framebuffer is a GL extension that enables optimizations for GPUs that aggressively defer
operations. We've 'borrowed' the extension namespace to enable backbuffer management, but this makes it
impossible to use the actual extension. This adds new entry points for backbuffer management. After callers
(which aren't in the WebKit repo) are updated, we can remove the overlapping entry points.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::discardFramebufferCHROMIUM):
(WebKit::WebGraphicsContext3D::discardBackbufferCHROMIUM):
(WebKit::WebGraphicsContext3D::ensureBackbufferCHROMIUM):

6:30 PM Changeset in webkit [136916] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

Review page is super flakey now
https://bugs.webkit.org/show_bug.cgi?id=104331

Committing without review since this is breaking the code review tool.

remove is only shipping in Chromium. Use jQuery's remove instead.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
6:18 PM Changeset in webkit [136915] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Disabled file input box stops a certain other div from being rendered
https://bugs.webkit.org/show_bug.cgi?id=104226

Patch by Kunihiko Sakamoto <ksakamoto@chromium.org> on 2012-12-06
Reviewed by Dimitri Glazkov.

Source/WebCore:

The bug was caused by setNeedsStyleRecalc() call during style recalculation,
which resulted in inconsistent ChildNeedsStyleRecalc flags in DOM tree.

When reattach of file input happens during style recalculation,
RenderFileUploadControl::updateFromElement() is called from attach().
It may change the disabled state of the upload button in its shadow tree,
but it triggers style recalculation.

This patch solves this issue by setting disabled state of the upload button in
FileInputType::disabledAttributeChanged instead of RenderFileUploadControl.

Test: fast/forms/file/sibling-of-disabled-file-input.html

  • html/FileInputType.cpp:

(WebCore::FileInputType::disabledAttributeChanged): Added.

  • html/FileInputType.h:

(FileInputType): Declare disabledAttributeChanged.

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::updateFromElement): Remove call to button->setDisabled().

LayoutTests:

Add a test to ensure that sibling of disabled file input is correctly rendered.

  • fast/forms/file/sibling-of-disabled-file-input-expected.txt: Added.
  • fast/forms/file/sibling-of-disabled-file-input.html: Added.
6:17 PM Changeset in webkit [136914] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

[CMake] Consolidate list of files to build for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=104287

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-12-06
Reviewed by Gyuyoung Kim.

Add MemoryStatistics.cpp and ExecutableAllocator.cpp to the common
list of files and remove them from the port specific lists.

  • CMakeLists.txt:
  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • PlatformWinCE.cmake:
5:48 PM Changeset in webkit [136913] by dominicc@chromium.org
  • 8 edits in trunk

Element.pseudo property should be prefixed
https://bugs.webkit.org/show_bug.cgi?id=104060

Reviewed by Hajime Morita.

Source/WebCore:

Other Shadow DOM properties are prefixed; pseudo should be too.

Covered by updated tests in fast/dom/shadow.

  • dom/Element.idl:

LayoutTests:

Updated tests.

  • fast/dom/shadow/pseudo-attribute-dynamic.html:
  • fast/dom/shadow/pseudo-attribute-expected.txt:
  • fast/dom/shadow/pseudo-attribute-rendering.html:
  • fast/dom/shadow/pseudo-attribute.html:
  • fast/dom/shadow/shadow-pseudo-id.html:
5:45 PM Changeset in webkit [136912] by commit-queue@webkit.org
  • 18 edits
    2 moves in trunk/Source/WebKit2

Coordinated Graphics: Rename WebLayerTreeInfo to CoordinatedLayerInfo
https://bugs.webkit.org/show_bug.cgi?id=103983

Patch by Jae Hyun Park <jae.park@company100.net> on 2012-12-06
Reviewed by Noam Rosenthal.

This patch refactors WebLayerTreeInfo in 2 areas.

  1. WebLayerTreeInfo is only used by Coordinated Graphics. So, the file

should be located in WebKit2/Shared/CoordinatedGraphics instead of
WebKit2/Shared.

  1. The name of WebLayerTreeInfo is incorrect. Currently,

WebLayerTreeInfo only has WebLayerInfo struct. Also, it is hard to know
what WebLayer is since we don't use that name anymore. More appropriate
name for WebLayerInfo would be CoordinatedLayerInfo.

No new test, because no behavioral change.

  • CMakeLists.txt:
  • Scripts/webkit2/messages.py:

(headers_for_type):

  • Shared/CoordinatedGraphics/CoordinatedLayerInfo.cpp: Renamed from Source/WebKit2/Shared/WebLayerTreeInfo.cpp.

(WebKit):
(WebKit::CoordinatedLayerInfo::encode):
(WebKit::CoordinatedLayerInfo::decode):

  • Shared/CoordinatedGraphics/CoordinatedLayerInfo.h: Renamed from Source/WebKit2/Shared/WebLayerTreeInfo.h.

(WebKit):
(WebKit::CoordinatedLayerInfo::CoordinatedLayerInfo):
(CoordinatedLayerInfo):

  • Shared/LayerTreeContext.h:

(LayerTreeContext):

  • Shared/efl/LayerTreeContextEfl.cpp:

(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
(WebKit::LayerTreeContext::isEmpty):
(WebKit::operator==):

  • Shared/qt/LayerTreeContextQt.cpp:

(WebKit::LayerTreeContext::LayerTreeContext):
(WebKit::LayerTreeContext::encode):
(WebKit::LayerTreeContext::decode):
(WebKit::LayerTreeContext::isEmpty):
(WebKit::operator==):

  • Target.pri:
  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::createTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::removeTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::deleteCompositingLayer):
(WebKit::LayerTreeCoordinatorProxy::setRootCompositingLayer):
(WebKit::LayerTreeCoordinatorProxy::setCompositingLayerState):
(WebKit::LayerTreeCoordinatorProxy::setCompositingLayerChildren):
(WebKit::LayerTreeCoordinatorProxy::setCompositingLayerFilters):
(WebKit::LayerTreeCoordinatorProxy::setLayerAnimations):
(WebKit::LayerTreeCoordinatorProxy::createCanvas):
(WebKit::LayerTreeCoordinatorProxy::syncCanvas):
(WebKit::LayerTreeCoordinatorProxy::destroyCanvas):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:

(WebKit):
(LayerTreeCoordinatorProxy):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::LayerTreeRenderer):
(WebKit::LayerTreeRenderer::createLayer):
(WebKit::LayerTreeRenderer::createCanvas):
(WebKit::LayerTreeRenderer::syncCanvas):
(WebKit::LayerTreeRenderer::destroyCanvas):
(WebKit::LayerTreeRenderer::setLayerChildren):
(WebKit::LayerTreeRenderer::setLayerFilters):
(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::deleteLayer):
(WebKit::LayerTreeRenderer::ensureLayer):
(WebKit::LayerTreeRenderer::setRootLayerID):
(WebKit::LayerTreeRenderer::createTile):
(WebKit::LayerTreeRenderer::removeTile):
(WebKit::LayerTreeRenderer::updateTile):
(WebKit::LayerTreeRenderer::ensureRootLayer):
(WebKit::LayerTreeRenderer::purgeGLResources):
(WebKit::LayerTreeRenderer::setLayerAnimations):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(WebKit):
(LayerTreeRenderer):
(WebKit::LayerTreeRenderer::layerByID):

  • UIProcess/DrawingAreaProxy.h:

(WebKit):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::layerByIDMap):
(WebCore::toCoordinatedLayerID):
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::id):
(WebCore::CoordinatedGraphicsLayer::syncChildren):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.h:
  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::syncLayerState):
(WebKit::LayerTreeCoordinator::syncLayerChildren):
(WebKit::LayerTreeCoordinator::createCanvas):
(WebKit::LayerTreeCoordinator::syncCanvas):
(WebKit::LayerTreeCoordinator::destroyCanvas):
(WebKit::LayerTreeCoordinator::syncLayerFilters):
(WebKit::LayerTreeCoordinator::createTile):
(WebKit::LayerTreeCoordinator::updateTile):
(WebKit::LayerTreeCoordinator::removeTile):
(WebKit::LayerTreeCoordinator::setLayerAnimations):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

5:43 PM Changeset in webkit [136911] by li.yin@intel.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, webaudio/audioparam-connect-audioratesignal.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=87273

Remove audioparam-connect-audioratesignal.html from chromium/TestExpectations,
since it no longer appears on the flakiness dashboard.

  • platform/chromium/TestExpectations:
5:31 PM Changeset in webkit [136910] by eae@chromium.org
  • 1 edit
    13 adds in trunk/LayoutTests

Unreviewed chromium rebaseline for r136909.

  • platform/chromium-win-xp/http/tests/w3c: Added.
  • platform/chromium-win-xp/http/tests/w3c/webperf: Added.
  • platform/chromium-win-xp/http/tests/w3c/webperf/submission: Added.
  • platform/chromium-win-xp/http/tests/w3c/webperf/submission/Intel: Added.
  • platform/chromium-win-xp/http/tests/w3c/webperf/submission/Intel/user-timing: Added.
  • platform/chromium-win-xp/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_mark-expected.txt: Added.
  • platform/chromium-win/http/tests/w3c: Added.
  • platform/chromium-win/http/tests/w3c/webperf: Added.
  • platform/chromium-win/http/tests/w3c/webperf/submission: Added.
  • platform/chromium-win/http/tests/w3c/webperf/submission/Intel: Added.
  • platform/chromium-win/http/tests/w3c/webperf/submission/Intel/user-timing: Added.
  • platform/chromium-win/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_clearMarks-expected.txt: Added.
  • platform/chromium-win/http/tests/w3c/webperf/submission/Intel/user-timing/test_user_timing_mark-expected.txt: Added.
4:52 PM Changeset in webkit [136909] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r136900.
http://trac.webkit.org/changeset/136900
https://bugs.webkit.org/show_bug.cgi?id=104318

Unreviewed build for Windows port. (Requested by rfong on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

  • win/WebKit2.def.in:
4:33 PM Changeset in webkit [136908] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[CSS Regions] Remove the sanitize mechanism from LineFragmentationData
https://bugs.webkit.org/show_bug.cgi?id=104234

Patch by Andrei Bucur <abucur@adobe.com> on 2012-12-06
Reviewed by David Hyatt.

Remove previous work that ensured an invalid region is never returned by the containingRegion getter. After r136793 the blocks always
relayout children if the region chain changes. This means the sanitize() method is only necessary when all the regions are removed.
This case is treated separately in layoutInlineChildren.

Tests: no new functionality, no bug fixed.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutInlineChildren):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::containingRegion):
(WebCore):
(WebCore::RootInlineBox::setContainingRegion):

  • rendering/RootInlineBox.h:

(RootInlineBox):
(WebCore::RootInlineBox::LineFragmentationData::LineFragmentationData):
(LineFragmentationData):

4:26 PM Changeset in webkit [136907] by kbr@google.com
  • 6 edits in trunk/Source

Associate URLs with GraphicsContext3D instances created for WebGL
https://bugs.webkit.org/show_bug.cgi?id=103793

Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/WebGraphicsContext3D.h:

(Attributes):

Add top document's URL to context creation attributes.

Source/WebCore:

Pass down the URL of the topmost frame's document creating the
WebGL context to the platform layer through
GraphicsContext3D::Attributes.

Not feasible to write a layout test for this change; has no
user-visible effect. Tested manually with failure injection in
Chromium port.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::create):

Pass top document's URL in context creation attributes.

  • platform/chromium/support/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3D::create):

Pass URL through WebKit API.

  • platform/graphics/GraphicsContext3D.h:

(Attributes):

Add top document's URL to context creation attributes.

4:21 PM Changeset in webkit [136906] by pdr@google.com
  • 14 edits
    4 adds in trunk

Unify SVG's animation and target tracking systems.
https://bugs.webkit.org/show_bug.cgi?id=102655

Reviewed by Dirk Schulze.

Source/WebCore:

This patch unifies our animation target tracking system and regular target tracking system.
This simplifies the code, fixes a bug, and cleans up a historically security-sensitive area.

Background: When <use>, <mpath>, <animate>, etc. reference another element using
xlink:href="#id", we need to track when #id changes to #otherId, when #id is removed, etc.
This bookkeeping of element -> target is done in SVGDocumentExtensions. Additionally, when
a target changes that causes layout (e.g., rect.x is changed), all dependent elements with
renderers are notified (<animate> has no renderer and will not use this).

Previously, xlink:href changes were lazily resolved when targetElement() was called, target
changes were tracked using the animation tracking framework, and pending targets did not
work (e.g., <animate xlink:href="#p"><!--animate is now pending #p --><rect id="p"/>).

After this patch, we no longer lazily resolve targetElement() but instead change it when
our xlink:href attribute changes. Instead of using the animation tracking framework in
SVGDocumentExtensions, we now use the regular target tracking framework. Lastly, by using
the regular target tracking framework we are able to hook into the pending resource handling
which fixes a bug (see the test).

A test has been added to test that the order of animation elements does not matter. A second
test has been added to show we do not regress a pending-while-pending case.

Tests: svg/animations/svg-animation-order.html

svg/custom/svg-pending-twice.html

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::setTargetElement):

setTargetElement and setAttributeName now work similarly. When the corresponding attribute
changes, we update our internal state (target or attributeName) and save it instead of
looking these values up on each iteration.

(WebCore::SVGAnimateElement::setAttributeName):
(WebCore):
(WebCore::SVGAnimateElement::resetAnimatedPropertyType):

  • svg/SVGAnimateElement.h:

(SVGAnimateElement):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::setAttributeType):
(WebCore::SVGAnimationElement::setTargetElement):
(WebCore::SVGAnimationElement::setAttributeName):

  • svg/SVGAnimationElement.h:

(SVGAnimationElement):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::~SVGDocumentExtensions):
(WebCore):

  • svg/SVGDocumentExtensions.h:

(SVGDocumentExtensions):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::~SVGElement):
(WebCore::SVGElement::removedFrom):
(WebCore::SVGElement::attributeChanged):

  • svg/SVGElementInstance.cpp:

(WebCore::SVGElementInstance::invalidateAllInstancesOfElement):

This can be removed after r131631 landed.

  • svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::buildPendingResource):

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::buildPendingResource):

A bug was discovered in review with our resource tracking in a pending-while-pending
case. SVGMpathElement and SVGTextPathElement have been updated to fix this as well.

  • svg/animation/SVGSMILElement.cpp:

The changes in SVGSMILElement should look very similar to SVGFEImageElement,
SVGMPathElement, etc. The idea is to build pending resources when added or
removed from the document, or when the href attribute changes.

(WebCore::SVGSMILElement::~SVGSMILElement):
(WebCore):
(WebCore::SVGSMILElement::clearResourceReferences):
(WebCore::SVGSMILElement::buildPendingResource):
(WebCore::SVGSMILElement::insertedInto):
(WebCore::SVGSMILElement::removedFrom):
(WebCore::SVGSMILElement::svgAttributeChanged):
(WebCore::SVGSMILElement::setAttributeName):
(WebCore::SVGSMILElement::setTargetElement):

  • svg/animation/SVGSMILElement.h:

(WebCore):
(WebCore::SVGSMILElement::targetElement):
(SVGSMILElement):

LayoutTests:

  • svg/animations/svg-animation-order-expected.html: Added.
  • svg/animations/svg-animation-order.html: Added.
  • svg/custom/svg-pending-twice-expected.html: Added.
  • svg/custom/svg-pending-twice.html: Added.
4:10 PM Changeset in webkit [136905] by jonlee@apple.com
  • 5 edits in trunk/Source

Retry snapshots if they are too empty
https://bugs.webkit.org/show_bug.cgi?id=104174
<rdar://problem/12820146>

Reviewed by Simon Fraser.

Source/WebCore:

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::updateSnapshot): Change the state machine check so that even
when the plug-in is displaying a snapshot, the snapshot can still be updated. This allows for the
retries to be drawn.

Source/WebKit2:

  • WebProcess/Plugins/PluginView.h: Add a new variable that keeps track of the number of times we've

retried to come up with a snapshot.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView): Initialize the count to 0.
(WebKit::isAlmostSolidColor): Figure out if the image is almost a solid color by overlaying
a grid of dots, and calculate the differences among them. If the average color difference is greater than
a threshold, we consider it to have meaningful content. For now we expect a minimum size and a specific
bitmap image format, otherwise we return early.
(WebKit::PluginView::pluginSnapshotTimerFired): If we have a snapshot image to look at, and if it is
evaluated to be too empty, then try again.

3:50 PM Changeset in webkit [136904] by simonjam@chromium.org
  • 4 edits
    1 add
    1 delete in trunk

[Chromium] Enable Resource Timing and User Timing
https://bugs.webkit.org/show_bug.cgi?id=103788

Reviewed by Tony Gentilcore.

Source/WebKit/chromium:

  • features.gypi:

LayoutTests:

  • http/tests/w3c/webperf/submission/resource-timing/html/test_resource_iframe_navigation.html: Removed. Incomplete, shouldn't have been submitted.
  • platform/chromium/TestExpectations: Remove 'Skip' expectations and add expected failures for iframes.
  • platform/chromium/fast/dom/Window/window-properties-performance-expected.txt: Added. Now includes User Timing and Resource Timing properties.
3:47 PM Changeset in webkit [136903] by adamk@chromium.org
  • 17 edits
    1 copy
    2 adds in trunk

[HTMLTemplateElement] make content readonly and cloneNode(deep) clone content
https://bugs.webkit.org/show_bug.cgi?id=104181

Reviewed by Adam Barth.

Source/WebCore:

Note that this patch also adds IDL attributes/custom code to tie the lifetime
of the content DocumentFragment wrapper to the lifetime of the template element wrapper
via a hidden JS property.

Based on a patch by Rafael Weinstein.

Test: fast/dom/HTMLTemplateElement/contentWrappers.html

  • DerivedSources.cpp:
  • Target.pri:
  • UseJSC.cmake:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:
  • bindings/js/JSHTMLTemplateElementCustom.cpp: Copied from Source/WebCore/html/HTMLTemplateElement.idl.

(WebCore):
(WebCore::JSHTMLTemplateElement::content):

  • bindings/scripts/CodeGeneratorV8.pm: Add support for new V8CacheAttributeForGC attribute.
  • dom/Element.h:

(Element): Annotate cloneNode() with OVERRIDE

  • html/HTMLTemplateElement.cpp:

(WebCore::HTMLTemplateElement::cloneNode):

  • html/HTMLTemplateElement.h:

(HTMLTemplateElement): override cloneNode

  • html/HTMLTemplateElement.idl: Make content readonly and add custom attributes.

LayoutTests:

  • fast/dom/HTMLTemplateElement/cloneNode-expected.txt:
  • fast/dom/HTMLTemplateElement/cloneNode.html:
  • fast/dom/HTMLTemplateElement/contentWrappers-expected.txt: Added.
  • fast/dom/HTMLTemplateElement/contentWrappers.html: Added.
  • fast/dom/HTMLTemplateElement/ownerDocument-expected.txt:
  • fast/dom/HTMLTemplateElement/ownerDocument.html:
3:31 PM Changeset in webkit [136902] by eae@chromium.org
  • 4 edits
    4 adds
    1 delete in trunk/LayoutTests

Unreviewed chromium rebaseline for r136885.

  • platform/chromium-mac-lion/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/chromium-mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/efl-wk1/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
  • platform/efl/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Removed.
3:30 PM Changeset in webkit [136901] by vivek.vg@samsung.com
  • 2 edits in trunk/Tools

Unreviewed. Fixing the email order to work correctly with bugzilla.

3:28 PM Changeset in webkit [136900] by tony@chromium.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, Apple Win Debug build fix.

  • win/WebKit2.def.in: Add 2 symbols that are needed by the debug build.
3:20 PM Changeset in webkit [136899] by jochen@chromium.org
  • 7 edits
    2 adds in trunk

[chromium] when forwarding events through the WebPluginContainer, create a UserGestureIndicator if processing a user gesture
https://bugs.webkit.org/show_bug.cgi?id=104306

Reviewed by Dimitri Glazkov.

Source/WebKit/chromium:

In http://trac.webkit.org/changeset/65964 a UserGestureIndicator was
introduced in chromium's WebKit layer intended to fix a problem with
plugins, however, it also affected regular event handling, so I removed
it in http://trac.webkit.org/changeset/128273. Turns out it still is a
problem for plugins. This change adds the UserGestureIndicator back,
however, only for the WebPluginContainer.

  • public/WebInputEvent.h:

(WebInputEvent):
(WebKit::WebInputEvent::isUserGestureEventType):

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::handleEvent):

Tools:

  • DumpRenderTree/chromium/TestWebPlugin.cpp:

(TestWebPlugin::TestWebPlugin):
(TestWebPlugin::handleInputEvent): add support for printing the user gesture status

  • DumpRenderTree/chromium/TestWebPlugin.h:

(TestWebPlugin):

LayoutTests:

  • platform/chromium/plugins/user-gesture-expected.txt: Added.
  • platform/chromium/plugins/user-gesture.html: Added.
3:02 PM Changeset in webkit [136898] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebCore

[Windows, WinCairo] Unreviewed build correction.

Exclude 'DocumentSharedObjectPool.cpp' from build, since it is
built as part of DOMAllInOne.cpp. The build (besides wasting
time) generates a bunch of build warnings for duplicate symbols.

  • WebCore.vcproj/WebCore.vcproj: Mark DocumentSharedObjectPool.cpp

to not build independently of DOMAllInOne.cpp.

2:56 PM Changeset in webkit [136897] by dgrogan@chromium.org
  • 6 edits in trunk/Source

IndexedDB: Abort transactions because of leveldb errors part 4
https://bugs.webkit.org/show_bug.cgi?id=103964

Reviewed by Tony Chang.

Source/WebCore:

deleteDatabase, open, and deleteObjectStore will now fire more aborts
and errors in case of leveldb problems

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::getVarInt): Make return value indicate leveldb error.
(WebCore::getString): ditto.
(WebCore::IDBBackingStore::getIDBDatabaseMetaData):
Change return value to indicate leveldb error.

(WebCore::IDBBackingStore::deleteDatabase):
Already had the desired return value semantics. As a consumer of
getIDBDatabaseMetadata, will return an error (causing an abort) more
often.

(WebCore::IDBBackingStore::deleteObjectStore):
Needed return value change. Will return error to DatabaseBackend to
indicate leveldb problems.

  • Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::openInternal):
Pass leveldb errors up to callers, who already handle internal errors.

(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreOperation::perform):
Abort transaction if there were leveldb problems deleting an object
store.

Source/WebKit/chromium:

  • tests/IDBFakeBackingStore.h: Update one overridden method signature, delete another.
2:45 PM Changeset in webkit [136896] by dpranke@chromium.org
  • 3 edits in trunk/Tools

new-run-webkit-tests --lint-test-files seems to be broken
https://bugs.webkit.org/show_bug.cgi?id=104296

Unreviewed, build fix.

My recent refactoring caused me to not initialize the printer
before calling lint(); this patch restructures the code to make
the lint routine self-contained and do all the work necessary.
This will also make it easier to move this code out into a standalone
file.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(lint):
(main):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(LintTest.test_all_configurations):
(LintTest.test_lint_test_files):
(LintTest.test_lint_test_fileserrors):

2:36 PM Changeset in webkit [136895] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Tell heap that we've released all the compiled code.

Reviewed by Geoff Garen.

When we discard compiled code, inform the heap that we've
released an entire object graph. This informs the heap that
it might want to perform a GC soon.

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::discardAllCode):

2:33 PM Changeset in webkit [136894] by dgrogan@chromium.org
  • 9 edits in trunk

IndexedDB: Add webkitErrorMessage to IDBTransaction
https://bugs.webkit.org/show_bug.cgi?id=104199

Reviewed by Tony Chang.

Source/WebCore:

Don't drop error messages on the floor.

Expose an error message on IDBTransaction to give developers more
information than the opaque error code currently available. This is
exactly what is done in IDBRequest.

Tests - transaction-error.html

  • Modules/indexeddb/IDBDatabaseError.h:

(WebCore::IDBDatabaseError::create):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::dispatchEvent):
(WebCore::IDBRequest::uncaughtExceptionInEventHandler):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::setError):
(WebCore):
(WebCore::IDBTransaction::webkitErrorMessage):
(WebCore::IDBTransaction::onAbort):

  • Modules/indexeddb/IDBTransaction.h:

(IDBTransaction):

  • Modules/indexeddb/IDBTransaction.idl:

LayoutTests:

Test for webkitErrorMessage in the three circumstances that can
generate one:
1) Bubble from operation error
2) Uncaught exception in operation event handler
3) Asynchronous abort from the backend

And fix a FIXME in the test.

  • storage/indexeddb/resources/transaction-error.js:

(testErrorFromRequest.trans.onabort):
(testErrorFromRequest):
(testErrorFromException.trans.onabort):
(testErrorFromException):
(testErrorFromCommit.trans.oncomplete.request.onupgradeneeded.trans.onabort):
(testErrorFromCommit.trans.oncomplete.request.onupgradeneeded):
(testErrorFromCommit.trans.oncomplete):
(testErrorFromCommit):

  • storage/indexeddb/transaction-error-expected.txt:
2:32 PM Changeset in webkit [136893] by commit-queue@webkit.org
  • 4 edits
    5 adds in trunk

XMLHttpRequest Content-Type should be taken from Blob type
https://bugs.webkit.org/show_bug.cgi?id=99983

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-12-06
Reviewed by Alexey Proskuryakov.

Source/WebCore:

Fix XMLHttpRequest::send(Blob*) method, so that the Content-Type is set according to W3C specification.
http://www.w3.org/TR/XMLHttpRequest/#the-send-method

Added test that check if content type is set correctly when blob object is sent.

Test: http/tests/xmlhttprequest/post-blob-content-type.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

Set correct MIME type for Blob objects.

  • WebCore.vcproj/WebCore.vcproj:

Added ParsedContentType to project file.

LayoutTests:

Added tests that check if content type is set correctly when blob object is sent.

  • http/tests/xmlhttprequest/post-blob-content-type-expected.txt: Added.
  • http/tests/xmlhttprequest/post-blob-content-type.html: Added.
2:30 PM Changeset in webkit [136892] by jsbell@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] IndexedDB: storage/indexeddb/resources/cursor-advance.html flaky in content_shell after WK136782
https://bugs.webkit.org/show_bug.cgi?id=104292

Reviewed by Tony Chang.

Test had a read-only transaction depending on the completion of a prior read-write transaction,
which is not guaranteed by the spec. Switch from triggering the second transaction into the
oncomplete of the first.

  • storage/indexeddb/resources/cursor-advance.js:

(populateObjectStore):

2:21 PM Changeset in webkit [136891] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Make LazyDecodingPixelRef inherit from skia::LazyPixelRef so that cc thread can access it
https://bugs.webkit.org/show_bug.cgi?id=103555

Patch by Min Qin <qinmin@chromium.org> on 2012-12-06
Reviewed by Stephen White.

Expose LazyDecodingPixelRef to the cc thread by inheriting from skia::LazyPixelRef.
No test added for now as impl side paiting is still WIP.

  • platform/graphics/chromium/LazyDecodingPixelRef.cpp:

(WebCore::LazyDecodingPixelRef::LazyDecodingPixelRef):
(WebCore::LazyDecodingPixelRef::PrepareToDecode):
(WebCore):
(WebCore::LazyDecodingPixelRef::Decode):

  • platform/graphics/chromium/LazyDecodingPixelRef.h:

(LazyDecodingPixelRef):

2:21 PM Changeset in webkit [136890] by scherkus@chromium.org
  • 7 edits in trunk/LayoutTests

[Chromium] Unreviewed, rebaselining http/tests/media/video-buffered-range-contains-currentTime.html
https://bugs.webkit.org/show_bug.cgi?id=104300

  • platform/chromium-linux/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac-lion/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac-snowleopard/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-mac/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium-win/http/tests/media/video-buffered-range-contains-currentTime-expected.png:
  • platform/chromium/TestExpectations:
2:18 PM Changeset in webkit [136889] by Lucas Forschler
  • 1 copy in tags/Safari-536.28.6

New Tag.

2:14 PM Changeset in webkit [136888] by ap@apple.com
  • 11 edits in trunk/Source/WebKit2

Track private browsing session in network process
https://bugs.webkit.org/show_bug.cgi?id=104281

Reviewed by Jessie Berlin.

Added ensure/destroy messages that match what's done in WebProcess. Also similarly,
ensuring a private session may happen on demand if network process has been restarted
after a crash, or if private browsing is enabled via a persistent preference.

Eventually, we should find a way to share code between WebFrameNetworkingContext
and RemoteNetworkingContext.

  • NetworkProcess/NetworkProcess.cpp: (WebKit::NetworkProcess::initializeNetworkProcess): (WebKit::NetworkProcess::ensurePrivateBrowsingSession): (WebKit::NetworkProcess::destroyPrivateBrowsingSession):
  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/mac/RemoteNetworkingContext.h: (RemoteNetworkingContext):
  • NetworkProcess/mac/RemoteNetworkingContext.mm: (WebKit::privateBrowsingStorageSessionIdentifierBase): (WebKit::RemoteNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase): (WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession): (WebKit::RemoteNetworkingContext::destroyPrivateBrowsingSession):
  • Shared/Network/NetworkProcessCreationParameters.cpp: (WebKit::NetworkProcessCreationParameters::encode): (WebKit::NetworkProcessCreationParameters::decode):
  • Shared/Network/NetworkProcessCreationParameters.h: (NetworkProcessCreationParameters):
  • UIProcess/Network/mac/NetworkProcessProxyMac.mm: (WebKit::NetworkProcessProxy::platformInitializeNetworkProcess):
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm: (WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
  • WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeWebProcess):
2:10 PM Changeset in webkit [136887] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Make an Isolate mandatory in v8UnsignedInteger()
https://bugs.webkit.org/show_bug.cgi?id=104235

Reviewed by Adam Barth.

No tests. No change in behavior.

  • bindings/v8/ArrayValue.cpp:

(WebCore::ArrayValue::get):

  • bindings/v8/V8Binding.h:

(WebCore::v8UnsignedInteger):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

2:08 PM Changeset in webkit [136886] by hyatt@apple.com
  • 5 edits in trunk/Source/WebCore

[New Multicolumn] Add requiresBalancing booleans to track which column sets need to rebalance.
https://bugs.webkit.org/show_bug.cgi?id=104297

Reviewed by Simon Fraser.

Add requiresBalancing booleans to RenderMultiColumnBlock and RenderMultiColumnSet. For now the former is just propagated
to the latter, but eventually RenderMultiColumnSets will have a notion of balancing that has to be independent of the
owning block (e.g., maybe only the last set rebalances, or maybe only a set that contains the content between two forced
breaks wants to rebalance, etc.).

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::RenderMultiColumnBlock):
(WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):
(WebCore::RenderMultiColumnBlock::ensureColumnSets):

  • rendering/RenderMultiColumnBlock.h:

(WebCore::RenderMultiColumnBlock::requiresBalancing):
(RenderMultiColumnBlock):

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::RenderMultiColumnSet):

  • rendering/RenderMultiColumnSet.h:

(WebCore::RenderMultiColumnSet::requiresBalancing):
(WebCore::RenderMultiColumnSet::setRequiresBalancing):
(RenderMultiColumnSet):
(WebCore::toRenderMultiColumnSet):
(WebCore):

2:00 PM Changeset in webkit [136885] by wangxianzhu@chromium.org
  • 9 edits in trunk/LayoutTests

internals.settings.setEnableCompositingForFixedPosition() should be called before onload
https://bugs.webkit.org/show_bug.cgi?id=104277

Fixed some tests that set enableCompositingForFixedPosition in onload handler which may not take effect because it is too late.
Leave the image mismatches to bug 96839.

Reviewed by Simon Fraser.

  • compositing/geometry/fixed-position-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-composited-page-scale-scroll.html:
  • compositing/geometry/fixed-position-composited-page-scale.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-iframe-composited-page-scale.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale-down.html:
  • compositing/geometry/fixed-position-transform-composited-page-scale.html:
  • compositing/layer-creation/fixed-position-out-of-view.html:
  • platform/chromium/TestExpectations: Mark the original flaky image mismatch as constantly failure. Add one image mismatch caused by this change but because of incorrect baseline.
1:58 PM Changeset in webkit [136884] by commit-queue@webkit.org
  • 10 edits in trunk

[EFL] Remove ENABLE_GLIB_SUPPORT CMake variable
https://bugs.webkit.org/show_bug.cgi?id=104278

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-12-06
Reviewed by Brent Fulgham.

.:

The variable is unnecessary as glib is a required dependency
for the EFL port and glib is not used by other ports building
with CMake.

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

The conditional is not required as it is always set for EFL.

  • PlatformEfl.cmake:

Source/WebKit2:

The guards are not required as it is always set for EFL.

  • PlatformEfl.cmake:
  • UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::scanPlugin):

  • WebProcess/efl/WebProcessMainEfl.cpp:

(WebKit::WebProcessMainEfl):

1:41 PM Changeset in webkit [136883] by eae@chromium.org
  • 7 edits in trunk/Source/WebCore

Unreviewed, rolling out r136871.
http://trac.webkit.org/changeset/136871
https://bugs.webkit.org/show_bug.cgi?id=104293

crashes on bots and memory leaks (Requested by esprehn on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

  • dom/Document.h:

(WebCore::Node::treeScope):

  • dom/Element.cpp:

(WebCore::Element::createRareData):

  • dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::ElementRareData):

  • dom/Node.cpp:

(WebCore::Node::setTreeScope):
(WebCore::Node::ensureRareData):
(WebCore::Node::createRareData):
(WebCore::Node::clearRareData):

  • dom/Node.h:

(WebCore::NodeRareDataBase::~NodeRareDataBase):
(WebCore::NodeRareDataBase::NodeRareDataBase):
(NodeRareDataBase):
(WebCore::Node::renderer):
(WebCore::Node::setRenderer):
(Node):
(WebCore::Node::hasRareData):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::NodeRareData):
(NodeRareData):

1:26 PM Changeset in webkit [136882] by adamk@chromium.org
  • 2 edits in trunk/Source/WebCore

Remove non-v8 binding files from WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=104288

Reviewed by Adam Barth.

Since the gyp build is only used by the Chromium project,
there's no need for cpp, gobject, objc, or jsc bindings
in these build files.

  • WebCore.gypi:
1:22 PM Changeset in webkit [136881] by fpizlo@apple.com
  • 2 edits in trunk/Tools

DFG profiler should be helpful about gem installation
https://bugs.webkit.org/show_bug.cgi?id=104217

Reviewed by Oliver Hunt.

'json' and 'highline' are not installed by default on the ruby distributions with
which I am familiar, and the default error messages don't make me happy. This makes
display-profiler-output print a helpful message if those gems are not found.

  • Scripts/display-profiler-output:
1:21 PM Changeset in webkit [136880] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
1:20 PM Changeset in webkit [136879] by fpizlo@apple.com
  • 2 edits in trunk/Tools

Profiler should print a helpful message if you pass the wrong arguments
https://bugs.webkit.org/show_bug.cgi?id=104222

Reviewed by Oliver Hunt.

  • Scripts/display-profiler-output:
1:19 PM Changeset in webkit [136878] by tony@chromium.org
  • 15 edits
    2 adds in trunk

REGRESSION(r135082): Restore the ability to insert author level style sheets from script
https://bugs.webkit.org/show_bug.cgi?id=104042

Reviewed by Antti Koivisto.

.:

Update exports for Internals.cpp.

  • Source/autotools/symbols.filter:

Source/WebCore:

Add DocumentStyleSheetCollection::addAuthorSheet so embedders can allow scripts
to insert author level styles. Expose the method to window.interals for testing.

Test: userscripts/insert-stylesheets.html

  • WebCore.exp.in: Update exports for Internals.cpp.
  • WebCore.order: Update exports for Internals.cpp.
  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::~DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::addAuthorSheet): Add the stylesheet and force a style recalc.
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets): Include author level styles.
(WebCore::DocumentStyleSheetCollection::reportMemoryUsage): Include author styles.

  • dom/DocumentStyleSheetCollection.h:

(WebCore::DocumentStyleSheetCollection::documentAuthorStyleSheets): Accessor.
(DocumentStyleSheetCollection): Keep track of author styles added by script.

  • testing/Internals.cpp:

(WebCore::Internals::insertAuthorCSS): Testing addAuthorSheet.
(WebCore::Internals::insertUserCSS): Testing addUserSheet.

  • testing/Internals.h:
  • testing/Internals.idl: Add addAuthorSheet and addUserSheet.

Source/WebKit/chromium:

  • src/WebDocument.cpp:

(WebKit::WebDocument::insertUserStyleSheet): Use addAuthorSheet if an author level script is requested.

Source/WebKit2:

Update exports for Internals.cpp.

  • win/WebKit2.def.in:

LayoutTests:

Add a test that makes sure that an author level style is set.

  • userscripts/insert-stylesheets-expected.txt: Added.
  • userscripts/insert-stylesheets.html: Added.
1:15 PM Changeset in webkit [136877] by senorblanco@chromium.org
  • 4 edits
    1 delete in trunk/LayoutTests

[Chromium] Unreviewed gardening.

effect-reference-hw.html is failing (lighting has a Y-flip), but people
seem tempted to rebaseline it. Put the software result in its place
for now, and mark it failing, so people aren't tempted to rebaseline it.

  • platform/chromium-linux/css3/filters/effect-reference-hw-expected.png: Removed.
  • platform/chromium-mac/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium/TestExpectations:
1:13 PM Changeset in webkit [136876] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

[chromium] Add some null-checks for the touch-lists in TouchEvent
https://bugs.webkit.org/show_bug.cgi?id=104098

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-12-06
Reviewed by Adam Barth.

It is possible for the touch-lists to be NULL in a TouchEvent. V8TouchEvent checks for NULL
touches(), targetTouches() and changedTouches(). So do the same for WebMouseEventBuilder.

  • src/WebInputEventConversion.cpp:

(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):

  • tests/WebInputEventConversionTest.cpp:
1:09 PM Changeset in webkit [136875] by ojan@chromium.org
  • 5 edits in trunk/Tools

Allow for CCing a secondary email address from watchlists
https://bugs.webkit.org/show_bug.cgi?id=104286

Reviewed by Dirk Pranke.

Change my watchlist CC address so I can filter these separately from
when people explicitly CC me and update the watchlist parser to allow that.

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/watchlist:
  • Scripts/webkitpy/common/watchlist/watchlistparser.py:

(WatchListParser._validate):

  • Scripts/webkitpy/common/watchlist/watchlistparser_unittest.py:

(WatchListParserTest.test_cc_rule_with_invalid_email):
(WatchListParserTest.test_cc_rule_with_secondary_email):

12:40 PM Changeset in webkit [136874] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, skip a new test because of missing test font.

  • platform/qt/TestExpectations:
12:31 PM Changeset in webkit [136873] by senorblanco@chromium.org
  • 11 edits
    1 add
    1 delete in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium-linux/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-linux/fast/css/background-clip-radius-values-expected.png:
  • platform/chromium-mac-lion/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-mac-lion/fast/css/background-clip-radius-values-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-mac/fast/css/background-clip-radius-values-expected.png:
  • platform/chromium-win/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-win/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-win/fast/css/background-clip-radius-values-expected.png: Added.
  • platform/chromium/TestExpectations:
12:24 PM Changeset in webkit [136872] by andersca@apple.com
  • 6 edits in branches/safari-536.28-branch/Source/WebKit2

<rdar://problem/12828185> "Invalid message" crash reporter data should also include last sent sync message

Reviewed by Dan Bernstein.

Add a way to get the last sent sync message and pass it along to the invalid message callback.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::Connection):
(CoreIPC::Connection::sendSyncMessage):

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::lastSentSyncMessageID):
(Connection):

  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit):
(WebKit::WebProcessProxy::didReceiveInvalidMessage):
(WebKit::WebProcessProxy::setInvalidMessageCallback):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

12:16 PM Changeset in webkit [136871] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

Create only NodeRareDataBase when setting TreeScope
https://bugs.webkit.org/show_bug.cgi?id=104202

Patch by Elliott Sprehn <Elliott Sprehn> on 2012-12-06
Reviewed by Dimitri Glazkov.

Move many fields from NodeRareData into NodeRareDataBase and rename it
UncommonNodeData and add a flag to determine if a UncommonNodeData is
actually a full NodeRareData instance. By moving fields up from NodeRareData
we ensure that this new flag in the base class doesn't make NodeRareData
grow in size.

We then make setting the tree scope only allocate the UncommonNodeData
instead of creating the full NodeRareData or ElementRareData. This is
important because when putting nodes into ShadowRoot or any descendant
we must associate the node with a tree scope which adds rare data to the
node making NodeRareData and ElementRareData not very rare.

On 64bit, this reduces the overhead per element from 136 bytes to
32 bytes for a 76% savings, and on other nodes from 64 bytes to 32 bytes
for a 50% savings.

No new tests, no change in behavior.

  • dom/Document.h:

(WebCore::Node::treeScope):

  • dom/Element.cpp:

(WebCore::Element::createRareData):

  • dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::ElementRareData):

  • dom/Node.cpp:

(WebCore::Node::setTreeScope):
(WebCore::Node::ensureRareData):
(WebCore::Node::createRareData):
(WebCore::Node::clearRareData):

  • dom/Node.h:

(WebCore::UncommonNodeData::create):
(UncommonNodeData):
(WebCore::UncommonNodeData::~UncommonNodeData):
(WebCore::UncommonNodeData::isNodeRareData):
(WebCore::UncommonNodeData::UncommonNodeData):
(WebCore::Node::renderer):
(WebCore::Node::setRenderer):
(Node):
(WebCore::Node::hasRareData):
(WebCore::Node::hasUncommonNodeData):

  • dom/NodeRareData.h:

(WebCore::NodeRareData::NodeRareData):
(NodeRareData):

12:13 PM Changeset in webkit [136870] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Add some bug IDs to failing tests, and restore some old expectations.

  • platform/chromium/TestExpectations:
12:11 PM Changeset in webkit [136869] by jsbell@chromium.org
  • 11 edits
    1 delete in trunk/Source/WebCore

IndexedDB: Remove IDBDatabaseException.idl
https://bugs.webkit.org/show_bug.cgi?id=102961

Reviewed by Adam Barth.

Delete the IDL and references to it. No longer needed as a enum member
in the autogenerated ExceptionCodeDescription.h so removed from the ".in"
file; only direct references are retained in the autogenerated cpp file.

Ideally the code generator would handle these new-style DOMExceptions,
but we don't have any other examples yet to know what pattern to follow.

No new tests - just removing dead code.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • DerivedSources.pri:
  • GNUmakefile.list.am:
  • Modules/indexeddb/IDBDatabaseException.idl: Removed.
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMExceptions.in:
  • dom/make_dom_exceptions.pl:

(generateImplementation):

12:02 PM Changeset in webkit [136868] by eae@chromium.org
  • 1 edit
    2 adds
    3 deletes in trunk/LayoutTests

Unreviewed chromium rebaselines.

  • platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.png: Removed.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/masks: Removed.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png: Removed.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/shadows: Removed.
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png: Removed.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/iframes: Added.
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/iframes/composited-iframe-alignment-expected.png: Added.
11:54 AM Changeset in webkit [136867] by junov@google.com
  • 4 edits
    2 adds
    1 delete in trunk/LayoutTests

New pixel baselines for fast/backgrounds/gradient-background-leakage.html
https://bugs.webkit.org/show_bug.cgi?id=103896

Unreviewed

  • platform/chromium-linux/fast/backgrounds/gradient-background-leakage-expected.png:
  • platform/chromium-mac/fast/backgrounds/gradient-background-leakage-expected.png:
  • platform/chromium/TestExpectations:
  • platform/efl-wk1/fast/backgrounds: Added.
  • platform/efl-wk1/fast/backgrounds/gradient-background-leakage-expected.png: Added.
  • platform/efl/fast/backgrounds/gradient-background-leakage-expected.png: Removed.
11:48 AM Changeset in webkit [136866] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

[Mac] Drain the CSSValuePool on memory pressure.
<http://webkit.org/b/104274>

Reviewed by Antti Koivisto.

Add a drain() mechanism to CSSValuePool and call it when we're under memory pressure.

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::drain):

  • css/CSSValuePool.h:
  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::releaseMemory):

11:47 AM Changeset in webkit [136865] by yael@webkit.org
  • 2 edits
    25 adds in trunk/LayoutTests

Unreviewed gardening.

Add expected results for transforms/3d tests that are producing correct resulta.

  • platform/efl/TestExpectations:
  • platform/efl/transforms/3d: Added.
  • platform/efl/transforms/3d/general: Added.
  • platform/efl/transforms/3d/general/perspective-non-layer-expected.png: Added.
  • platform/efl/transforms/3d/general/perspective-non-layer-expected.txt: Added.
  • platform/efl/transforms/3d/general/perspective-units-expected.png: Added.
  • platform/efl/transforms/3d/general/perspective-units-expected.txt: Added.
  • platform/efl/transforms/3d/hit-testing: Added.
  • platform/efl/transforms/3d/hit-testing/backface-hit-test-expected.png: Added.
  • platform/efl/transforms/3d/hit-testing/backface-hit-test-expected.txt: Added.
  • platform/efl/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.png: Added.
  • platform/efl/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt: Added.
  • platform/efl/transforms/3d/point-mapping: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-2-expected.png: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-3-expected.png: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-3-expected.txt: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-expected.txt: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
  • platform/efl/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Added.
11:35 AM Changeset in webkit [136864] by schenney@chromium.org
  • 2 edits
    1 delete in trunk/LayoutTests

Fix a bad rebaseline

Unreviewed expectations fix.

This test is apparently flaky and I put in the wrong flake.

  • platform/chromium-mac-lion/svg/custom/mask-invalidation-expected.png: Removed.
  • platform/chromium-win/svg/custom/mask-invalidation-expected.png:
11:34 AM Changeset in webkit [136863] by oliver@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Build fix, last patch rolled out logic that is now needed on ToT.

11:33 AM Changeset in webkit [136862] by adamk@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove gyp config for incomplete and unused Apple Mac gyp build
https://bugs.webkit.org/show_bug.cgi?id=104068

Reviewed by Adam Barth.

As part of the removal, move some files to the proper sections
of the gypi file.

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
11:27 AM Changeset in webkit [136861] by wangxianzhu@chromium.org
  • 4 edits in trunk/Source/WebKit/chromium

[Chromium] Expose acceleratedCompositingForScrollableFramesEnabled in WebKit API
https://bugs.webkit.org/show_bug.cgi?id=104272

We may need the API to enable compositing scrollable frames in Chromium.

Reviewed by Darin Fisher.

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setAcceleratedCompositingForScrollableFramesEnabled):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

11:26 AM Changeset in webkit [136860] by oliver@apple.com
  • 9 edits in trunk/Source/JavaScriptCore

Remove harmful string->function cache
https://bugs.webkit.org/show_bug.cgi?id=104193

Reviewed by Alexey Proskuryakov.

Remove the string->function code cache that turned out to actually
be quite harmful.

  • runtime/CodeCache.cpp:

(JSC::CodeCache::getFunctionCodeBlock):

  • runtime/CodeCache.h:

(JSC::CodeCache::clear):

11:21 AM Changeset in webkit [136859] by abecsi@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Fix QWebKitTest's notification of device pixel ratio change
https://bugs.webkit.org/show_bug.cgi?id=104269

Unreviewed, trivialy fixing last minute change.

Move signal emission to the correct place.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewFlickablePrivate::onComponentComplete):

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::PageViewportControllerClientQt):

11:06 AM Changeset in webkit [136858] by commit-queue@webkit.org
  • 2 edits in trunk/Source/Platform

[Chromium] Add GL_CHROMIUM_async_pixel_transfers extension support.
https://bugs.webkit.org/show_bug.cgi?id=103995

Patch by David Reveman <reveman@chromium.org> on 2012-12-06
Reviewed by Kenneth Russell.

Add asyncTexImage2DCHROMIUM and asyncTexSubImage2DCHROMIUM to
WebGraphicsContext3D.h.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::asyncTexImage2DCHROMIUM):
(WebKit::WebGraphicsContext3D::asyncTexSubImage2DCHROMIUM):

11:05 AM Changeset in webkit [136857] by commit-queue@webkit.org
  • 11 edits
    4 adds in trunk

[CSS Exclusions] Add support for computing the first included interval position.
https://bugs.webkit.org/show_bug.cgi?id=103327

Source/WebCore:

Patch by Hans Muller <hmuller@adobe.com> on 2012-12-06
Reviewed by Levi Weintraub.

If the first "word" in a line doesn't fit within the shape-inside when lineTop
is the top of the shape's logical bounding box, adjust lineTop downwards to where
the word fits. Currently only rounded rectangle shapes are supported.

Added ExclusionShape::firstIncludedIntervalLogicalTop(). The new virtual method
computes the topmost/leftmost location where a line segment with the specified
minLogicalIntervalSize will fit within the exclusion shape and returns the
corresponding logical Y coordinate. The result is additionally constrained to
be at or below minLogicalIntervalTop. If the segment will not fit anywhere within
the shape, then false is returned.

During layout, minLogicalIntervalTop is the nominal top of the line being laid
out within the exclusion shape.

RenderBlock::layoutRunsAndFloatsInRange() now calls a new ExclusionShapeInsideInfo
method, adjustLogicalLineTop(), which uses firstIncludedIntervalLogicalTop() to
decide if the logical top of the line has to be moved downwards, for the first
word to fit within the exclusion shape.

Tests: fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-001.html

fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-002.html

  • rendering/ExclusionPolygon.cpp:

(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): This is a stub implementation.

  • rendering/ExclusionPolygon.h:
  • rendering/ExclusionRectangle.cpp:

(WebCore::ellipseXIntercept): Added spaces to conform to webkit style and to be consistent with ellipseYIntercept()
(WebCore::ellipseYIntercept): Compute an ellipse's Y intercept for an X coordinate.
(WebCore::ExclusionRectangle::firstIncludedIntervalLogicalTop): See the description above.

  • rendering/ExclusionRectangle.h:
  • rendering/ExclusionShape.h:

(ExclusionShape):
(WebCore::ExclusionShape::logicalTopForMinY): Internal to logical coordinate conversion.

  • rendering/ExclusionShapeInsideInfo.cpp:

(WebCore::ExclusionShapeInsideInfo::adjustLogicalLineTop): A new method that updates m_lineTop with firstIncludedIntervalPosition().

  • rendering/ExclusionShapeInsideInfo.h:

(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::logicalLineTop): This is just a cover for the private m_lineTop field.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Added code that restarts the layout loop if it's necessary to adjust the line's logicalTop.
(WebCore::RenderBlock::restartLayoutRunsAndFloatsInRange): Factored newly common code into this helper function.

LayoutTests:

Test the rounded rectangle support for adjusting the top of a line downwards
when the first word doesn't fit within the shape.

Patch by Hans Muller <hmuller@adobe.com> on 2012-12-06
Reviewed by Levi Weintraub.

  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-001-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-001.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-002-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-fit-002.html: Added.
10:59 AM Changeset in webkit [136856] by mvujovic@adobe.com
  • 2 edits in trunk/Tools

Unreviewed. Add myself to committers.py.

  • Scripts/webkitpy/common/config/committers.py:
10:24 AM Changeset in webkit [136855] by schenney@chromium.org
  • 16 edits
    8 adds
    4 deletes in trunk/LayoutTests

Rebaseline some expectations

Unreviewed expectations update

These test have expectations but apparently just need rebaselines.
Some may still be flakey.

  • platform/chromium-linux/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-linux/svg/css/group-with-shadow-expected.png:
  • platform/chromium-linux/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
  • platform/chromium-mac-lion/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-mac-lion/svg/css/group-with-shadow-expected.png:
  • platform/chromium-mac-lion/svg/custom/mask-invalidation-expected.png: Added.
  • platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
  • platform/chromium-mac-snowleopard/svg/custom/transform-with-shadow-and-gradient-expected.png: Removed.
  • platform/chromium-mac/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-mac/svg/css/group-with-shadow-expected.png:
  • platform/chromium-mac/svg/custom/radialGradient-focal-radius-expected.png: Added.
  • platform/chromium-mac/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
  • platform/chromium-win-xp/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/fast/canvas/canvas-incremental-repaint-expected.png:
  • platform/chromium-win/svg/css/group-with-shadow-expected.png:
  • platform/chromium-win/svg/custom/mask-invalidation-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-container-standalone-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-expected.png:
  • platform/chromium-win/svg/custom/mouse-move-on-svg-root-standalone-expected.png:
  • platform/chromium-win/svg/custom/radialGradient-focal-radius-expected.png: Added.
  • platform/chromium-win/svg/custom/transform-with-shadow-and-gradient-expected.png: Added.
  • platform/chromium/svg/custom/radialGradient-focal-radius-expected.png: Removed.
  • platform/chromium/svg/custom/transform-with-shadow-and-gradient-expected.png: Removed.
  • platform/efl-wk1/svg/custom: Added.
  • platform/efl-wk1/svg/custom/radialGradient-focal-radius-expected.png: Added.
  • platform/efl/svg/custom/radialGradient-focal-radius-expected.png: Removed.
10:18 AM Changeset in webkit [136854] by commit-queue@webkit.org
  • 2 edits in trunk

[EFL] Optimize binary size by removing dead sections on unix/gcc
https://bugs.webkit.org/show_bug.cgi?id=102827

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-12-06
Reviewed by Kenneth Rohde Christiansen.

Turn on -ffunction-sections -fdata-sections --gc-section flags
on unix for the gcc toolchain for release builds to optimize binary
size for the Efl port.

  • Source/cmake/OptionsEfl.cmake:
10:10 AM Changeset in webkit [136853] by schenney@chromium.org
  • 2 edits in trunk/LayoutTests

Test expectations update
https://bugs.webkit.org/show_bug.cgi?id=104007

Unreviewed expectations update.

  • platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png:
10:02 AM Changeset in webkit [136852] by wjmaclean@chromium.org
  • 3 edits
    3 adds in trunk

[chromium] Should apply link highlight to largest enclosing node with a handCursor.
https://bugs.webkit.org/show_bug.cgi?id=104264

Reviewed by Adrienne Walker.

Source/WebKit/chromium:

Link highlights sometimes only apply to part of a link, if we select an enclosed
node (e.g. font changes in link text). The highlight should be applied to the
largest enclosing node that still has handCursor set.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::bestTouchLinkNode):

LayoutTests:

Add layout test to cover new functionality.

  • platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested.html: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested-expected.png: Added.
  • platform/chromium-linux/platform/chromium-linux/compositing/gestures/gesture-tapHighlight-simple-nested-expected.txt: Added.
9:53 AM Changeset in webkit [136851] by abecsi@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Fix QWebKitTest's notification of device pixel ratio change
https://bugs.webkit.org/show_bug.cgi?id=104269

Reviewed by Kenneth Rohde Christiansen.

Since the ViewportInfoItem of MiniBrowser is created before the
WebView finishes construction, thus before the viewport controller
has been instantiated, the shown device pixel ratio was incorrect.
Additionally QWebKitTest's notification signal was also not emitted
when the value changed.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::QQuickWebViewPrivate):

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::PageViewportControllerClientQt):

9:52 AM Changeset in webkit [136850] by rniwa@webkit.org
  • 21 edits in trunk/Source/WebCore

Use ownerNode() instead of base() in HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=104244

Reviewed by Adam Barth.

Use ownerNode() instead of base() in HTMLCollection to match LiveNodeList.
Notice that the definition of base(), which this patch removes, is "return ownerNode()".

  • bindings/js/JSHTMLFormControlsCollectionCustom.cpp:

(WebCore::getNamedItems):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::indexSetter):
(WebCore::JSHTMLOptionsCollection::remove):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateOpaqueRootForGC):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp:

(WebCore::getNamedItems):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::removeCallback):
(WebCore::V8HTMLOptionsCollection::indexedPropertySetter):

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::ownerNode):

  • dom/WebKitNamedFlow.h:

(WebKitNamedFlow):

  • dom/WebKitNamedFlow.idl:
  • html/HTMLAllCollection.idl:
  • html/HTMLCollection.h:

(HTMLCollection):

  • html/HTMLCollection.idl:
  • html/HTMLFormControlsCollection.cpp:

(WebCore::HTMLFormControlsCollection::HTMLFormControlsCollection):
(WebCore::HTMLFormControlsCollection::create):
(WebCore::HTMLFormControlsCollection::formControlElements):
(WebCore::HTMLFormControlsCollection::formImageElements):
(WebCore::HTMLFormControlsCollection::namedItem):
(WebCore::HTMLFormControlsCollection::updateNameCache):

  • html/HTMLFormControlsCollection.idl:
  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::~HTMLNameCollection):
(WebCore::HTMLNameCollection::virtualItemAfter):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):
(WebCore::HTMLOptionsCollection::remove):
(WebCore::HTMLOptionsCollection::selectedIndex):
(WebCore::HTMLOptionsCollection::setSelectedIndex):
(WebCore::HTMLOptionsCollection::setLength):

  • html/HTMLOptionsCollection.idl:
  • html/HTMLPropertiesCollection.cpp:

(WebCore::HTMLPropertiesCollection::updateRefElements):
(WebCore::HTMLPropertiesCollection::namedItem):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::virtualItemAfter):

9:49 AM Changeset in webkit [136849] by zandobersek@gmail.com
  • 10 edits
    1 delete in trunk/LayoutTests

UndoManager layout tests should be removed
https://bugs.webkit.org/show_bug.cgi?id=104246

Reviewed by Adam Barth.

The UndoManager feature support was removed from the source tree
in r133326. The layout tests should be removed as well. As with
the feature implementation, these too can be restored back when needed.

  • editing/undomanager: Removed.
  • editing/undomanager/automatic-transaction-attribute-expected.txt: Removed.
  • editing/undomanager/automatic-transaction-attribute.html: Removed.
  • editing/undomanager/automatic-transaction-data-expected.txt: Removed.
  • editing/undomanager/automatic-transaction-data.html: Removed.
  • editing/undomanager/automatic-transaction-node-expected.txt: Removed.
  • editing/undomanager/automatic-transaction-node.html: Removed.
  • editing/undomanager/document-has-undomanager-expected.txt: Removed.
  • editing/undomanager/document-has-undomanager.html: Removed.
  • editing/undomanager/domtransaction-survives-gc-expected.txt: Removed.
  • editing/undomanager/domtransaction-survives-gc.html: Removed.
  • editing/undomanager/undomanager-isolated-world-expected.txt: Removed.
  • editing/undomanager/undomanager-isolated-world.html: Removed.
  • editing/undomanager/undomanager-item-expected.txt: Removed.
  • editing/undomanager/undomanager-item.html: Removed.
  • editing/undomanager/undomanager-reenter-expected.txt: Removed.
  • editing/undomanager/undomanager-reenter.html: Removed.
  • editing/undomanager/undomanager-transact-expected.txt: Removed.
  • editing/undomanager/undomanager-transact.html: Removed.
  • editing/undomanager/undomanager-undo-redo-expected.txt: Removed.
  • editing/undomanager/undomanager-undo-redo.html: Removed.
  • editing/undomanager/undoscopehost-use-after-free-expected.txt: Removed.
  • editing/undomanager/undoscopehost-use-after-free.html: Removed.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt-4.8/TestExpectations:
  • platform/qt-mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
9:49 AM WebKit Team edited by akling@apple.com
(diff)
9:43 AM Changeset in webkit [136848] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
https://bugs.webkit.org/show_bug.cgi?id=104139

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-12-06
Reviewed by Kenneth Rohde Christiansen.

Resize the window back to 800x600 between tests.
This should be a no-op if the test did not resize the window.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

9:07 AM Changeset in webkit [136847] by alexis@webkit.org
  • 2 edits in trunk/LayoutTests

[Mac] Unreviewed gardening after r136415.

r136415 enables the CSS3 background position offsets therefore this
expected png needs to be updated with the new result (the correct one
actually). It was not failing on the bot as the Apple Mac bot does not
seem to run pixel tests.

  • platform/mac/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
8:59 AM Changeset in webkit [136846] by tommyw@google.com
  • 19 edits in trunk

Speech Recognition API: Change the error code to a string on SpeechRecognitionError
https://bugs.webkit.org/show_bug.cgi?id=104254

Reviewed by Adam Barth.

Source/WebCore:

SpeechRecognitionError::code (numeric value) has been changed to SpeechRecognitionError::error (string)
in the latest specification.

http://dvcs.w3.org/hg/speech-api/raw-file/tip/speechapi.html#speechreco-error

Existing tests modified to cover this patch.

  • Modules/speech/SpeechRecognitionError.cpp:

(WebCore::ErrorCodeToString):
(WebCore):
(WebCore::SpeechRecognitionError::create):
(WebCore::SpeechRecognitionError::SpeechRecognitionError):

  • Modules/speech/SpeechRecognitionError.h:

(SpeechRecognitionErrorInit):
(WebCore::SpeechRecognitionError::error):
(SpeechRecognitionError):

  • Modules/speech/SpeechRecognitionError.idl:

Source/WebKit/chromium:

Minor WebCore type changes.

  • src/AssertMatchingEnums.cpp:
  • src/SpeechRecognitionClientProxy.cpp:

(WebKit::SpeechRecognitionClientProxy::didReceiveError):

Tools:

Changes the mock error function to take a string instead of an int.

  • DumpRenderTree/chromium/DRTTestRunner.cpp:

(DRTTestRunner::setMockSpeechRecognitionError):

  • DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:

(WebTestRunner::ErrorTask::ErrorTask):
(MockWebSpeechRecognizer::setError):

  • DumpRenderTree/chromium/MockWebSpeechRecognizer.h:

(MockWebSpeechRecognizer):

LayoutTests:

Adjusting tests.

  • fast/events/constructors/speech-recognition-error-constructor-expected.txt:
  • fast/events/constructors/speech-recognition-error-constructor.html:
  • fast/speech/scripted/speechrecognition-errors-expected.txt:
  • fast/speech/scripted/speechrecognition-errors.html:
  • fast/speech/scripted/speechrecognitionerror-basics-expected.txt:
  • fast/speech/scripted/speechrecognitionerror-basics.html:
  • platform/chromium/fast/events/constructors/speech-recognition-error-constructor-expected.txt:
8:53 AM Changeset in webkit [136845] by schenney@chromium.org
  • 4 edits
    3 adds in trunk

SVG <use> element inside an svg-as-image fails
https://bugs.webkit.org/show_bug.cgi?id=104007

Reviewed by Eric Seidel.

Upon redraw, SVGImage calls layout on the document it is drawing into
the image if the image, provided it believes the redraw does not need
to be delayed. Unfortunately, when an SVG <use> element is modified
(by animation, say) and regenerates its shadow tree, the destructors
invoke redraw, causing the SVGImage to call layout on something that
is in the process of being deleted. That's bad.

This change causes SVGImage to always delay the redraw. It is the most robust
way to protect against this problem, as there may be any number of
ways to cause this issue (a node being deleted in an svg-as-image
target) and this protects against them all.

The test case crashes in Asan Chromium.

Source/WebCore:

Test: svg/as-image/animated-use-as-image-crash.html

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageContentChanged): Always redraw on the timer.

LayoutTests:

  • platform/chromium-win/svg/custom/use-disappears-after-style-update-expected.png: Changed as a result of this change.
  • svg/as-image/animated-use-as-image-crash-expected.txt: Added.
  • svg/as-image/animated-use-as-image-crash.html: Added.
  • svg/as-image/resources/animated-href-on-use.svg: Added.
8:41 AM Changeset in webkit [136844] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening, update an expected file.

  • platform/qt/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png:
7:23 AM Changeset in webkit [136843] by commit-queue@webkit.org
  • 12 edits
    1 add in trunk

TextTrack's .cues not ordered correctly when two cues have the same .startTime
https://bugs.webkit.org/show_bug.cgi?id=103266

Patch by Antoine Quint <Antoine Quint> on 2012-12-06
Reviewed by Eric Carlson.

Source/WebCore:

Adding a new method TextTrackCueList::updateCueIndex() to update the list of
cues after changing the .startTime or .endTime of a TextTrackCue. I elected to
add a new method to TextTrackCueList rather than calling remove() and then add()
on the list from TextTrack::cueDidChange() so that the nature of the operation
is abstracted and we can easily change the way we keep the cue list sorted at
a later time should we choose to.

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::cueDidChange):

  • html/track/TextTrackCueList.cpp:

(WebCore::TextTrackCueList::updateCueIndex):
(WebCore):

  • html/track/TextTrackCueList.h:

(TextTrackCueList):

LayoutTests:

Unskip an Opera test that we now pass. Note that the original test has two issues that prompted
changes in this patch. The first issue is https://www.w3.org/Bugs/Public/show_bug.cgi?id=20066
and I've elected to comment the sub-test that fails and tracking turning it back on when the test
is corrected with https://bugs.webkit.org/show_bug.cgi?id=104255. The second issue was in the sub-test
that revealed the failure covered by this bug and had an issue acknowledged by the author
(see https://www.w3.org/Bugs/Public/show_bug.cgi?id=20066) so I fixed it in our repository.

  • media/track/opera/interfaces/TextTrack/cues-expected.txt: Added.
  • media/track/opera/interfaces/TextTrack/cues.html:
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
7:01 AM Changeset in webkit [136842] by pierre.rossi@gmail.com
  • 4 edits in trunk/Source/WebKit/qt

[Qt] QWebView uses the mobile style and doesn't follow Qt's style
https://bugs.webkit.org/show_bug.cgi?id=104134

Reviewed by Simon Hausmann.

Another issue introduced by r136235.
Fix the order of initialization of the styleFactory and creation of the
WebCore Page. Since the latter has a RenderTheme member and the creation
of the appropriate RenderTheme type (QStyle-backed) is dependant on having
first initialized the theme factory function, we need to postpone this just
a little bit.

  • WebCoreSupport/QWebPageAdapter.cpp:

(QWebPageAdapter::QWebPageAdapter):
(QWebPageAdapter::initializeWebCorePage): Added.

  • WebCoreSupport/QWebPageAdapter.h:
  • WidgetApi/qwebpage.cpp:

(QWebPagePrivate::QWebPagePrivate): call initializeWebCorePage only after
having initialized WebKitWidgets related logic (QStyle hooks in this case).

6:56 AM Changeset in webkit [136841] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

Unreviewed, rolling out r136788.
http://trac.webkit.org/changeset/136788
https://bugs.webkit.org/show_bug.cgi?id=104260

Asserts on EFL WebKit2 Debug bot (Requested by yael on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::setRootLayerID):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

6:45 AM Changeset in webkit [136840] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r136795.
http://trac.webkit.org/changeset/136795
https://bugs.webkit.org/show_bug.cgi?id=104257

Asserts on EFL WebKit2 Debug bot (Requested by yael on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::setRootLayerID):

6:11 AM Changeset in webkit [136839] by commit-queue@webkit.org
  • 2 edits in trunk

[EFL] Fix destination path in Source/PlatformEfl.cmake
https://bugs.webkit.org/show_bug.cgi?id=104237

Patch by Seokju Kwon <Seokju Kwon> on 2012-12-06
Reviewed by Laszlo Gombos.

Remove InspectorBackendCommands.js when copying it for the consistency in Source/PlatformEfl.cmake.

  • Source/PlatformEfl.cmake:
6:04 AM Changeset in webkit [136838] by zandobersek@gmail.com
  • 1 edit
    4 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Adding missing platform-specific baselines.

  • platform/gtk/fast/text/decorations-with-text-combine-expected.png: Added.
  • platform/gtk/fast/text/decorations-with-text-combine-expected.txt: Added.
  • platform/gtk/fast/text/orientation-sideways-expected.png: Added.
  • platform/gtk/fast/text/orientation-sideways-expected.txt: Added.
6:02 AM Changeset in webkit [136837] by abecsi@webkit.org
  • 5 edits in trunk

[Qt][Mac] Fix libxslt and libxml2 config tests
https://bugs.webkit.org/show_bug.cgi?id=104164

Reviewed by Simon Hausmann.

Source/WebCore:

Since libxml2 is a dependency for libxslt and is not used
standalone the configurations for it should also depend on
whether XSLT is enabled.
Also avoid using pkg-config on Mac, instead use direct
include paths and add needed libraries to the linker.

No new tests needed.

  • WebCore.pri:

Tools:

We should not use pkg-config on Mac instead use direct include
paths and add needed libraries to the linker options to detect
libxslt and libxml2 provided by the system.
Previously we would always fall back to qtxmlpatterns.

  • qmake/config.tests/libxml2/libxml2.pro:
  • qmake/config.tests/libxslt/libxslt.pro:
5:55 AM Changeset in webkit [136836] by Csaba Osztrogonác
  • 4 edits in trunk/Tools

[Qt] Fix the build if the path contains "+" character
https://bugs.webkit.org/show_bug.cgi?id=104120

Reviewed by Tor Arne Vestbø.

The second parameter of qmake's replace() is regular expression, so
we have to escape special characters in paths passed to replace().

  • qmake/mkspecs/features/default_post.prf:
  • qmake/mkspecs/features/default_pre.prf:
  • qmake/mkspecs/features/functions.prf:
5:54 AM Changeset in webkit [136835] by commit-queue@webkit.org
  • 5 edits in trunk/LayoutTests

[EFL][Qt] fast/regions/autowidth-normalflow-maxwidth.html is failing
https://bugs.webkit.org/show_bug.cgi?id=104160

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-12-06
Reviewed by Kenneth Rohde Christiansen.

The test fast/regions/autowidth-normalflow-maxwidth.html is failing for EFL and Qt
because the test expects that the text of the test would fit in 400 pixels,
but both for Qt and for EFL, the text requires more than that.
Changed the test and the expectation ref-test to allow 450 pixels.

  • fast/regions/autowidth-normalflow-maxwidth-expected.html:
  • fast/regions/autowidth-normalflow-maxwidth.html:
  • platform/efl-wk2/TestExpectations:
  • platform/qt-5.0-wk2/TestExpectations:
5:38 AM Changeset in webkit [136834] by shinyak@chromium.org
  • 13 edits in trunk

Internals.getElementByIdInShadowRoot is nonsense now.
https://bugs.webkit.org/show_bug.cgi?id=104241

Reviewed by Kent Tamura.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Since we have ShadowRoot.getElementById() now, we don't need Internals.getElementByIdInShadowRoot, which is
the same functionality of ShadowRoot.getElementById().

Test: fast/dom/shadow/get-element-by-id-in-shadow-root.html

  • WebCore.exp.in:
  • testing/Internals.cpp:
  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit2:

  • win/WebKit2.def.in:

LayoutTests:

  • fast/dom/shadow/get-element-by-id-in-shadow-root-expected.txt:
  • fast/dom/shadow/get-element-by-id-in-shadow-root.html:
  • fast/dom/shadow/resources/shadow-dom.js: Uses ShadowRoot.getElementById() instead.

(getNodeInShadowTreeStack):

5:11 AM Changeset in webkit [136833] by Christophe Dumez
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Context clients should unregister themselves when destroyed
https://bugs.webkit.org/show_bug.cgi?id=104113

Reviewed by Kenneth Rohde Christiansen.

Make sure the context clients (History and Download clients)
unregister themselves when destroyed to make sure their
callback functions are never called after the client objects
have been destroyed (i.e. when the parent Ewk_Context has
been destroyed).

This addresses crashing issues after a Ewk_Context object
gets unref'd and destroyed.

  • UIProcess/efl/ContextHistoryClientEfl.cpp:

(WebKit::ContextHistoryClientEfl::ContextHistoryClientEfl):
(WebKit):
(WebKit::ContextHistoryClientEfl::~ContextHistoryClientEfl):

  • UIProcess/efl/ContextHistoryClientEfl.h:

(ContextHistoryClientEfl):

  • UIProcess/efl/DownloadManagerEfl.cpp:

(WebKit::DownloadManagerEfl::~DownloadManagerEfl):
(WebKit):

  • UIProcess/efl/DownloadManagerEfl.h:

(DownloadManagerEfl):

4:32 AM Changeset in webkit [136832] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[EFL] Active texture state gets corrupted after updating graphics surface contents.
https://bugs.webkit.org/show_bug.cgi?id=104248.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-06
Reviewed by Kenneth Rohde Christiansen.

GraphicsContext3DPrivate::copyToGraphicsSurface() doesn't restore the previously bound texture
after copying texture contents. This corrupts the texture state.

Existing Tests should cover this.

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(GraphicsContext3DPrivate::copyToGraphicsSurface):

  • platform/graphics/opengl/GLPlatformSurface.cpp:

(WebCore::GLPlatformSurface::updateContents):

  • platform/graphics/opengl/GLPlatformSurface.h:

(GLPlatformSurface):

4:29 AM Changeset in webkit [136831] by apavlov@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Goto panel shortcuts and description are reversed
https://bugs.webkit.org/show_bug.cgi?id=103988

Reviewed by Pavel Feldman.

Swap the square brackets in the shortcuts.

  • inspector/front-end/inspector.js:

(WebInspector._registerShortcuts):

4:13 AM Changeset in webkit [136830] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r136825.
http://trac.webkit.org/changeset/136825
https://bugs.webkit.org/show_bug.cgi?id=104251

It made 100+ test fail on Qt-WK2 pixel bot, and 1800+ test
flakey on Qt-WK2 non-pixel bot (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

3:51 AM Changeset in webkit [136829] by commit-queue@webkit.org
  • 8 edits
    2 deletes in trunk

Unreviewed, rolling out r136818.
http://trac.webkit.org/changeset/136818
https://bugs.webkit.org/show_bug.cgi?id=104249

simulatedClick does not work as per #chrmium irc. (Requested
by hayato on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

Source/WebCore:

  • dom/EventDispatcher.cpp:

(WebCore::EventRelatedTargetAdjuster::adjust):

  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::create):
(WebCore::MouseEventDispatchMediator::MouseEventDispatchMediator):
(WebCore::MouseEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.h:

(MouseEventDispatchMediator):

  • dom/Node.cpp:

(WebCore::Node::dispatchEvent):

LayoutTests:

  • fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
  • fast/dom/shadow/shadow-dom-event-dispatching.html:
  • fast/events/dispatch-synthetic-mouseevent-expected.txt: Removed.
  • fast/events/dispatch-synthetic-mouseevent.html: Removed.
3:13 AM Changeset in webkit [136828] by podivilov@chromium.org
  • 2 edits
    3 deletes in trunk/LayoutTests

[chromium] Unreviewed, fix baselines for plugins/npp-set-window-called-during-destruction.html on win7.

  • platform/chromium-linux/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
  • platform/chromium-win-xp/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
  • platform/chromium-win/plugins/npp-set-window-called-during-destruction-expected.txt:
  • platform/win/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
2:48 AM Changeset in webkit [136827] by tkent@chromium.org
  • 54 edits in trunk/LayoutTests

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=104210
https://bugs.webkit.org/show_bug.cgi?id=103869

  • platform/chromium-linux/fast/forms/date/date-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/date/date-appearance-l10n-expected.png:
  • platform/chromium-linux/fast/forms/date/date-appearance-pseudo-elements-expected.png:
  • platform/chromium-linux/fast/forms/datetime/datetime-appearance-l10n-expected.png:
  • platform/chromium-linux/fast/forms/month/month-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/month/month-appearance-l10n-expected.png:
  • platform/chromium-linux/fast/forms/month/month-appearance-pseudo-elements-expected.png:
  • platform/chromium-linux/fast/forms/time/time-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/time/time-appearance-pseudo-elements-expected.png:
  • platform/chromium-linux/fast/forms/week/week-appearance-basic-expected.png:
  • platform/chromium-linux/fast/forms/week/week-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-lion/fast/forms/date/date-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/date/date-appearance-l10n-expected.png:
  • platform/chromium-mac-lion/fast/forms/date/date-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-lion/fast/forms/datetime/datetime-appearance-l10n-expected.png:
  • platform/chromium-mac-lion/fast/forms/month/month-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/month/month-appearance-l10n-expected.png:
  • platform/chromium-mac-lion/fast/forms/month/month-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-lion/fast/forms/time/time-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/time/time-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-lion/fast/forms/week/week-appearance-basic-expected.png:
  • platform/chromium-mac-lion/fast/forms/week/week-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-l10n-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/date/date-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/datetime/datetime-appearance-l10n-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-l10n-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/month/month-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-basic-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/week/week-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/date/date-appearance-l10n-expected.png:
  • platform/chromium-mac/fast/forms/date/date-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/month/month-appearance-l10n-expected.png:
  • platform/chromium-mac/fast/forms/month/month-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/time/time-appearance-pseudo-elements-expected.png:
  • platform/chromium-mac/fast/forms/week/week-appearance-pseudo-elements-expected.png:
  • platform/chromium-win-xp/fast/forms/date/date-appearance-l10n-expected.png:
  • platform/chromium-win-xp/fast/forms/month/month-appearance-l10n-expected.png:
  • platform/chromium-win/fast/forms/date/date-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/date/date-appearance-l10n-expected.png:
  • platform/chromium-win/fast/forms/date/date-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/datetime/datetime-appearance-l10n-expected.png:
  • platform/chromium-win/fast/forms/month/month-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/month/month-appearance-l10n-expected.png:
  • platform/chromium-win/fast/forms/month/month-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/time/time-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/time/time-appearance-pseudo-elements-expected.png:
  • platform/chromium-win/fast/forms/week/week-appearance-basic-expected.png:
  • platform/chromium-win/fast/forms/week/week-appearance-pseudo-elements-expected.png:
  • platform/chromium/TestExpectations:
2:25 AM Changeset in webkit [136826] by tkent@chromium.org
  • 111 edits
    16 adds in trunk/LayoutTests

[Chromium] Update test expectations
https://bugs.webkit.org/show_bug.cgi?id=103853
https://bugs.webkit.org/show_bug.cgi?id=103869

  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-with-scroll-bar-expected.png:
  • platform/chromium/TestExpectations:
2:08 AM Changeset in webkit [136825] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] [WK2] fast/dom/vertical-scrollbar-in-rtl.html makes fast/regions tests flaky
https://bugs.webkit.org/show_bug.cgi?id=104139

Patch by Yael Aharon <yael.aharon@intel.com> on 2012-12-06
Reviewed by Kenneth Rohde Christiansen.

Resize the window back to 800x600 between tests.
This should be a no-op if the test did not resize the window.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

1:49 AM Changeset in webkit [136824] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[v8] Fix hidden property name of V8ArrayBufferView flag.
https://bugs.webkit.org/show_bug.cgi?id=104099

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-12-06
Reviewed by Kentaro Hara.

Fix hidden property name of V8ArrayBufferView hidden copy method.

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

  • bindings/v8/custom/V8ArrayBufferViewCustom.cpp:

(WebCore::getHiddenCopyMethod):
(WebCore::installHiddenCopyMethod):

1:38 AM Changeset in webkit [136823] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fixed a wrong comment landed in r136822.

  • bindings/v8/V8Binding.h:

(WebCore):

1:19 AM Changeset in webkit [136822] by haraken@chromium.org
  • 23 edits in trunk/Source/WebCore

[V8] Implement deprecatedV8String()
https://bugs.webkit.org/show_bug.cgi?id=104230

Reviewed by Adam Barth.

To make an Isolate mandatory in v8String(), we implement
deprecatedV8String() for call sites that don't have
an Isolate. Eventually we want to kill the method though.

No tests. No change in behavior.

  • bindings/scripts/test/V8/V8TestCallback.cpp:

(WebCore::V8TestCallback::callbackWithClass2Param):

  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::getKey):

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::get):
(WebCore::set):

  • bindings/v8/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::evaluate):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::compileAndRunScript):
(WebCore::ScriptController::bindToWindowObject):
(WebCore::ScriptController::disableEval):

  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::setScriptSource):
(WebCore::ScriptDebugServer::ensureDebuggerScriptCompiled):
(WebCore::ScriptDebugServer::compileScript):

  • bindings/v8/ScriptFunctionCall.cpp:

(WebCore::ScriptCallArgumentHandler::appendArgument):
(WebCore::ScriptFunctionCall::call):
(WebCore::ScriptFunctionCall::construct):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):
(WebCore::ScriptProfiler::takeHeapSnapshot):

  • bindings/v8/ScriptSourceCode.cpp:

(WebCore::ScriptSourceCode::compileScript):

  • bindings/v8/V8Binding.h:

(WebCore):
(WebCore::deprecatedV8String):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::initializeIfNeeded):
(WebCore::V8DOMWindowShell::namedItemAdded):
(WebCore::V8DOMWindowShell::namedItemRemoved):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8WindowErrorHandler.cpp:

(WebCore::V8WindowErrorHandler::callListenerFunction):

  • bindings/v8/V8WorkerContextErrorHandler.cpp:

(WebCore::V8WorkerContextErrorHandler::callListenerFunction):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

  • bindings/v8/custom/V8ArrayBufferViewCustom.cpp:

(WebCore::installHiddenCopyMethod):
(WebCore::copyElements):

  • bindings/v8/custom/V8CustomXPathNSResolver.cpp:

(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::getEventListenersCallback):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::InjectedScriptManager::createInjectedScript):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):

1:03 AM Changeset in webkit [136821] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Page popup should align to the right when the anchor element is rtl
https://bugs.webkit.org/show_bug.cgi?id=104219

Reviewed by Kent Tamura.

Page popup should align to the right edge of the anchor element when the anchor element is rtl.

No new tests. Mock page popup can't test popup window position.

  • Resources/pagepopups/pickerCommon.js:

(_adjustWindowRectHorizontally): Align to the right edge when anchor element is rtl. Removed some redundant lines.
(setWindowRect): If the window is hidden we want to move first then resize so the popup doesn't flicker.
(isWindowHidden): Returns true if the window is hidden using hideWindow().

1:01 AM Changeset in webkit [136820] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Make an Isolate mandatory for v8StringOrNull() and v8StringOrUndefined()
https://bugs.webkit.org/show_bug.cgi?id=104213

Reviewed by Adam Barth.

All call sites of v8StringOrNull() and v8StringOrUndefined() have an Isolate.

No tests. No change in behavior.

  • bindings/v8/V8Binding.h:

(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):

12:57 AM Changeset in webkit [136819] by haraken@chromium.org
  • 14 edits in trunk/Source/WebCore

[V8] Implement deprecatedV8Integer(int i)
https://bugs.webkit.org/show_bug.cgi?id=104220

Reviewed by Adam Barth.

To make an Isolate mandatory in v8Integer(), we implement
deprecatedV8Integer(int i) for call sites that don't have
an Isolate. Eventually we want to kill deprecatedV8Integer(int i).

No new tests. No change in behavior.

  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

  • bindings/v8/NPV8Object.cpp:

(_NPN_Enumerate):

  • bindings/v8/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):

  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::compileScript):

  • bindings/v8/ScriptSourceCode.cpp:

(WebCore::ScriptSourceCode::compileScript):

  • bindings/v8/V8Binding.h:

(WebCore):
(WebCore::deprecatedV8Integer):

  • bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::batchConfigureConstants):

  • bindings/v8/V8NPUtils.cpp:

(WebCore::convertNPVariantToV8Object):

  • bindings/v8/V8Utilities.cpp:

(WebCore::createHiddenDependency):
(WebCore::removeHiddenDependency):

  • bindings/v8/V8WindowErrorHandler.cpp:

(WebCore::V8WindowErrorHandler::callListenerFunction):

  • bindings/v8/V8WorkerContextErrorHandler.cpp:

(WebCore::V8WorkerContextErrorHandler::callListenerFunction):

  • bindings/v8/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::addListener):

  • bindings/v8/custom/V8MutationCallbackCustom.cpp:

(WebCore::V8MutationCallback::handleEvent):

12:52 AM Changeset in webkit [136818] by hayato@chromium.org
  • 8 edits
    2 adds in trunk

Event's relatedTarget re-targeting does not occur for manually fired mouse events created by event.initMouseEvent().
https://bugs.webkit.org/show_bug.cgi?id=102681

Reviewed by Dimitri Glazkov.

Source/WebCore:

Make sure that event's relatedTarget re-targeting occurs for mouse
events created by event.initMouseEvent(). Since user-generated
mouse events can have a relatedTarget which is same to the target
node, the algorithm which calculates event's ancestors is also
updated so that ancestors are not shrunk wrongly.

Test: fast/events/dispatch-synthetic-mouseevent.html

fast/dom/shadow/shadow-dom-event-dispatching.html

  • dom/EventDispatcher.cpp:

(WebCore::EventRelatedTargetAdjuster::adjust):

  • dom/MouseEvent.cpp:

(WebCore::MouseEventDispatchMediator::create):
(WebCore::MouseEventDispatchMediator::MouseEventDispatchMediator):
(WebCore::MouseEventDispatchMediator::dispatchEvent):

  • dom/MouseEvent.h:

(WebCore::MouseEventDispatchMediator::isSyntheticMouseEvent):
(MouseEventDispatchMediator):

  • dom/Node.cpp:

(WebCore::Node::dispatchEvent):

LayoutTests:

  • fast/dom/shadow/shadow-dom-event-dispatching-expected.txt:
  • fast/dom/shadow/shadow-dom-event-dispatching.html:
  • fast/events/dispatch-synthetic-mouseevent-expected.txt: Added.
  • fast/events/dispatch-synthetic-mouseevent.html: Added.
12:50 AM Changeset in webkit [136817] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[JSC] Check whether property is an array before attempting conversion to array in JSDictionary
https://bugs.webkit.org/show_bug.cgi?id=96614

Patch by Michael Pruett <michael@68k.org> on 2012-12-06
Reviewed by Kentaro Hara.

JSDictionary should check whether the property being accessed in get()
is an array before attempting to convert the value to an array.

Previously calling get() with a result type of Vector<String> when
the named property could not be converted to an array would generate
an exception.

Tests: storage/indexeddb/*

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSDictionary.h:

(WebCore::JSDictionary::tryGetPropertyAndResult):

12:47 AM Changeset in webkit [136816] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Pass Isolate to toDOMStringList()
https://bugs.webkit.org/show_bug.cgi?id=104224

Reviewed by Adam Barth.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(JSValueToNative):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::overloadedMethod6Callback):
(WebCore::TestObjV8Internal::overloadedMethod7Callback):
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(WebCore::TestObjV8Internal::stringArrayFunctionCallback):

  • bindings/v8/V8Binding.cpp:

(WebCore::toDOMStringList):

  • bindings/v8/V8Binding.h:

(WebCore):

12:43 AM Changeset in webkit [136815] by haraken@chromium.org
  • 7 edits
    2 deletes in trunk/Source/WebCore

Remove JSDependentRetained.h and V8DependentRetained.h
https://bugs.webkit.org/show_bug.cgi?id=104232

Reviewed by Adam Barth.

Although (JS|V8)DependentRetained.h were introduced for MutationObservers,
they are not going to be used (See the discussion in bug 95519).
We can remove them.

No tests. No change in behavior.

  • GNUmakefile.list.am:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDependentRetained.h: Removed.
  • bindings/v8/V8DependentRetained.h: Removed.
  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::V8PerIsolateData):

  • bindings/v8/V8PerIsolateData.h:

(V8PerIsolateData):

12:32 AM Changeset in webkit [136814] by zandobersek@gmail.com
  • 1 edit
    15 adds
    34 deletes in trunk/LayoutTests

Turn pixel tests in dom/xhtml/level3/core into reftests
https://bugs.webkit.org/show_bug.cgi?id=103809

Reviewed by Dirk Pranke.

Turn 15 pixel tests under dom/xhtml/level3/core into reftests.
The reference files are tailored so they present the same output that
the pixel baselines (being removed) do.

  • dom/xhtml/level3/core/canonicalform08-expected.html: Added.
  • dom/xhtml/level3/core/canonicalform09-expected.html: Added.
  • dom/xhtml/level3/core/documentgetinputencoding03-expected.html: Added.
  • dom/xhtml/level3/core/entitygetinputencoding02-expected.html: Added.
  • dom/xhtml/level3/core/entitygetxmlversion02-expected.html: Added.
  • dom/xhtml/level3/core/nodegetbaseuri05-expected.html: Added.
  • dom/xhtml/level3/core/nodegetbaseuri07-expected.html: Added.
  • dom/xhtml/level3/core/nodegetbaseuri09-expected.html: Added.
  • dom/xhtml/level3/core/nodegetbaseuri10-expected.html: Added.
  • dom/xhtml/level3/core/nodegetbaseuri11-expected.html: Added.
  • dom/xhtml/level3/core/nodegetbaseuri15-expected.html: Added.
  • dom/xhtml/level3/core/nodegetbaseuri17-expected.html: Added.
  • dom/xhtml/level3/core/nodegetbaseuri18-expected.html: Added.
  • dom/xhtml/level3/core/nodelookupnamespaceuri01-expected.html: Added.
  • dom/xhtml/level3/core/nodelookupprefix19-expected.html: Added.
  • The now-unnecessary pixel and render tree baselines: Removed.
12:31 AM Changeset in webkit [136813] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Replace v8String("symbol") with v8::String::NewSymbol("symbol")
https://bugs.webkit.org/show_bug.cgi?id=104209

Reviewed by Adam Barth.

V8 can look up symbols faster than strings.

No tests. No change in behavior.

  • bindings/v8/JavaScriptCallFrame.cpp:

(WebCore::JavaScriptCallFrame::caller):
(WebCore::JavaScriptCallFrame::sourceID):
(WebCore::JavaScriptCallFrame::line):
(WebCore::JavaScriptCallFrame::column):
(WebCore::JavaScriptCallFrame::functionName):
(WebCore::JavaScriptCallFrame::scopeChain):
(WebCore::JavaScriptCallFrame::scopeType):
(WebCore::JavaScriptCallFrame::thisObject):
(WebCore::JavaScriptCallFrame::evaluate):
(WebCore::JavaScriptCallFrame::restart):

  • bindings/v8/V8ThrowException.cpp:

(WebCore::domExceptionStackGetter):
(WebCore::domExceptionStackSetter):
(WebCore::V8ThrowException::setDOMException):

  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::V8InspectorFrontendHost::platformCallback):

  • bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:

(WebCore::V8JavaScriptCallFrame::typeAccessorGetter):

12:20 AM Changeset in webkit [136812] by commit-queue@webkit.org
  • 12 edits
    10 adds in trunk

Unreviewed, rolling out r136784 and r136802.
http://trac.webkit.org/changeset/136784
http://trac.webkit.org/changeset/136802
https://bugs.webkit.org/show_bug.cgi?id=104231

breaks chromium canary (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-06

Source/Platform:

  • Platform.gypi:
  • chromium/public/linux/WebThemeEngine.h: Added.

(WebKit):
(WebThemeEngine):
(ScrollbarTrackExtraParams):
(ButtonExtraParams):
(TextFieldExtraParams):
(MenuListExtraParams):
(SliderExtraParams):
(InnerSpinButtonExtraParams):
(ProgressBarExtraParams):
(WebKit::WebThemeEngine::getSize):
(WebKit::WebThemeEngine::paint):

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • platform/chromium/PlatformThemeChromiumLinux.cpp: Added.

(WebCore):
(WebCore::PlatformThemeChromiumLinux::setScrollbarColors):
(WebCore::clamp):
(WebCore::PlatformThemeChromiumLinux::saturateAndBrighten):
(WebCore::PlatformThemeChromiumLinux::outlineColor):
(WebCore::PlatformThemeChromiumLinux::paintArrowButton):

  • platform/chromium/PlatformThemeChromiumLinux.h: Added.

(WebCore):
(PlatformThemeChromiumLinux):
(WebCore::PlatformThemeChromiumLinux::thumbInactiveColor):
(WebCore::PlatformThemeChromiumLinux::thumbActiveColor):
(WebCore::PlatformThemeChromiumLinux::trackColor):
(WebCore::PlatformThemeChromiumLinux::PlatformThemeChromiumLinux):

  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: Added.

(WebCore):
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumLinux::paintButton):
(WebCore::ScrollbarThemeChromiumLinux::paintThumb):
(WebCore::ScrollbarThemeChromiumLinux::shouldCenterOnThumb):
(WebCore::ScrollbarThemeChromiumLinux::buttonSize):
(WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):

  • platform/chromium/ScrollbarThemeChromiumLinux.h: Added.

(ScrollbarThemeChromiumLinux):

  • rendering/RenderThemeChromiumAndroid.cpp:

(WebCore::RenderThemeChromiumAndroid::extraDefaultStyleSheet):

  • rendering/RenderThemeChromiumAndroid.h:
  • rendering/RenderThemeChromiumLinux.cpp: Added.

(WebCore):
(WebCore::getWebThemeState):
(WebCore::RenderThemeChromiumLinux::create):
(WebCore::RenderTheme::themeForPage):
(WebCore::RenderThemeChromiumLinux::RenderThemeChromiumLinux):
(WebCore::RenderThemeChromiumLinux::~RenderThemeChromiumLinux):
(WebCore::RenderThemeChromiumLinux::systemColor):
(WebCore::RenderThemeChromiumLinux::extraDefaultStyleSheet):
(WebCore::RenderThemeChromiumLinux::controlSupportsTints):
(WebCore::RenderThemeChromiumLinux::activeListBoxSelectionBackgroundColor):
(WebCore::RenderThemeChromiumLinux::activeListBoxSelectionForegroundColor):
(WebCore::RenderThemeChromiumLinux::inactiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeChromiumLinux::inactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeChromiumLinux::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumLinux::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeChromiumLinux::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeChromiumLinux::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeChromiumLinux::sliderTickSize):
(WebCore::RenderThemeChromiumLinux::sliderTickOffsetFromTrackCenter):
(WebCore::RenderThemeChromiumLinux::adjustSliderThumbSize):
(WebCore::RenderThemeChromiumLinux::supportsControlTints):
(WebCore::RenderThemeChromiumLinux::setCaretBlinkInterval):
(WebCore::RenderThemeChromiumLinux::caretBlinkIntervalInternal):
(WebCore::RenderThemeChromiumLinux::setSelectionColors):
(WebCore::RenderThemeChromiumLinux::paintCheckbox):
(WebCore::RenderThemeChromiumLinux::setCheckboxSize):
(WebCore::RenderThemeChromiumLinux::paintRadio):
(WebCore::RenderThemeChromiumLinux::setRadioSize):
(WebCore::RenderThemeChromiumLinux::paintButton):
(WebCore::RenderThemeChromiumLinux::paintTextField):
(WebCore::RenderThemeChromiumLinux::paintMenuList):
(WebCore::RenderThemeChromiumLinux::paintSliderTrack):
(WebCore::RenderThemeChromiumLinux::paintSliderThumb):
(WebCore::RenderThemeChromiumLinux::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeChromiumLinux::paintInnerSpinButton):
(WebCore::RenderThemeChromiumLinux::paintProgressBar):
(WebCore::RenderThemeChromiumLinux::shouldOpenPickerWithF4Key):

  • rendering/RenderThemeChromiumLinux.h: Added.

(WebCore):
(RenderThemeChromiumLinux):

Source/WebKit/chromium:

  • WebKit.gyp:
  • public/linux/WebRenderTheme.h: Added.

(WebKit):

  • public/platform/linux/WebThemeEngine.h: Added.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setScrollbarColors):
(WebKit::WebViewImpl::setSelectionColors):

  • src/linux/WebRenderTheme.cpp: Added.

(WebKit):
(WebKit::setCaretBlinkInterval):

Tools:

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest):

Dec 5, 2012:

11:46 PM Changeset in webkit [136811] by tasak@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Add win8/* to Chromium DEPS (r171376)
https://bugs.webkit.org/show_bug.cgi?id=104228

Reviewed by Hajime Morita.

Since updated chromium DEPS to r171376, now printing/printing.gyp
requires win8/* for windows build.

  • DEPS:
11:37 PM Changeset in webkit [136810] by tkent@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Test expectation update
https://bugs.webkit.org/show_bug.cgi?id=103869

  • platform/chromium/TestExpectations:

Fix duplicated entries.

11:28 PM Changeset in webkit [136809] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Title of "Record Timeline" status button on "Timeline
Panel" should reflect the recording state.
https://bugs.webkit.org/show_bug.cgi?id=104108

Patch by Sankeerth V S <sankeerth.vs@samsung.com> on 2012-12-05
Reviewed by Alexander Pavlov.

Title should be toggled between "Record"/"Stop" to reflect current
state of the Status bar button.

No new tests as UI related change.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype.get _toggleTimelineButtonClicked):

11:10 PM Changeset in webkit [136808] by tkent@chromium.org
  • 22 edits in trunk

INPUT_MULTIPLE_FIELDS_UI doesn't show digits well in RTL locales
https://bugs.webkit.org/show_bug.cgi?id=103869

Reviewed by Hajime Morita.

Source/WebCore:

We need to use display:inline elements to wrap sub-fields and static
text in DateTimeEditElement children to apply the Unicode Bidi
Algorithm.

Because we can't use display:inline-block for them, we can't specify
min-width CSS property for them. We stop using customStyleForRenderer of
sub-fields to specify each of their widths, and use
customStyleForRenderer of DateTimeEditElement to specify the total
required width. A sub-field width shrink and grow so that the width fits
to the field value, and a DateTimeEditElement doesn't.

No new tests. Coverred by existing tests, especially
fast/forms/datetime/datetime-appearance-l10n.html shows "23:59"
correctly.

  • css/html.css:

(input::-webkit-datetime-edit-year-field):

  • Make this display:inline to apply the Unicode Bidi Algorithm.
  • Use padding instead of margin because of ease of width computation. Also, the focus apparance gets better by padding.
  • Don't allow to specify font property here because of ease of width computation.
  • Remove text-align:center. It doesn't work for display:inline.

(input::-webkit-datetime-edit-text):

  • Make this display:inline to apply the Unicode Bidi Algorithm.
  • Don't allow to specify font property here because of ease of width computation.
  • html/shadow/DateTimeEditElement.h:

(DateTimeEditElement): Declare customStyleForRenderer.

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::DateTimeEditElement):
Enable customStyleForRenderer.
(WebCore::DateTimeEditElement::customStyleForRenderer):
Compute required width with a font for this element and child maximum
widths, and set it to min-width style.
The resultant width value can be inaccurate if a page author specifies
padding, border, margin, etc. to ::-webkit-datetime-edit-*-field or
::-webkit-datetime-edit-text. In such case, the page author should specify
wider width to <input>.

  • dom/Element.h:

(Element): Add isDateTimeFieldElement to do static_cast<DateTimeFieldElement> safely.

  • dom/Element.cpp:

(WebCore::Element::isDateTimeFieldElement): Added.

  • html/shadow/DateTimeFieldElement.h:

(DateTimeFieldElement): Declare isDateTimeFieldElement and maximumWidth.

  • html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::isDateTimeFieldElement):
Added. Returns true.
(WebCore::DateTimeFieldElement::maximumWidth):
Added. Returns padding width.

  • html/shadow/DateTimeSymbolicFieldElement.h:

(DateTimeSymbolicFieldElement):
Remove customStyleForRenderer, and declare maximumWidth.

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::DateTimeSymbolicFieldElement):
Disable customStyleForRenderer.
(WebCore::DateTimeSymbolicFieldElement::maximumWidth):
Added. Returns the expected maximum width with the specified font.

  • html/shadow/DateTimeNumericFieldElement.h:

(DateTimeNumericFieldElement):
Remove customStyleForRenderer, declare maximumWidth, and make m_placeholder
non-const because it is updated in the constructor.

  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::DateTimeNumericFieldElement):
Disable customStyleForRenderer.
If a numeric value for this field is LTR and the whole direction is RTL,
wrap the placeholder string with left-to-right-mark and
right-to-left-mark so that it is handled as LTR. Without this,
sub-fields order would be changed when the content of a field is changed
from a placeholder to a numeric value.
(WebCore::DateTimeNumericFieldElement::maximumWidth):
Added. Returns the expected maximum width with the specified font.

LayoutTests:

  • Year fields and month fields are shrunk because we stop specifying min-width.
  • Focus rectangle for sub-fields get larger.
  • fast/forms/date-multiple-fields/date-multiple-fields-mouse-events.html:

Need to update mouse click positions because we have some position/width
changes in sub-fields.

  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-mouse-events.html:

Ditto.

  • fast/forms/month-multiple-fields/month-multiple-fields-mouse-events.html:

Ditto.

  • platform/chromium-mac/fast/forms/date/date-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/datetime/datetime-l10n-expected.png:
  • platform/chromium-mac/fast/forms/month/month-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
  • platform/chromium-mac/fast/forms/week/week-appearance-basic-expected.png:
  • platform/chromium/TestExpectations:
10:36 PM Changeset in webkit [136807] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Add myself to watch changes in PerformanceTests/*.

  • Scripts/webkitpy/common/config/watchlist:
10:33 PM Changeset in webkit [136806] by shinyak@chromium.org
  • 3 edits
    2 adds in trunk

[Chromium] DRT on Windows crashes when a testcase has a progress element in indeterminate state
https://bugs.webkit.org/show_bug.cgi?id=102459

Reviewed by Dimitri Glazkov.

Tools:

Since WebThemeControlDRTWin::markState does not consider indeterminate state, DRT caused a crash.

  • DumpRenderTree/chromium/WebThemeControlDRTWin.cpp:

(WebThemeControlDRTWin::markState):

LayoutTests:

  • fast/dom/HTMLProgressElement/progress-element-indeterminate-crash-expected.txt: Added.
  • fast/dom/HTMLProgressElement/progress-element-indeterminate-crash.html: Added.
10:31 PM Changeset in webkit [136805] by shinyak@chromium.org
  • 1 edit
    6 adds in trunk/PerformanceTests

[Shadow] Performance tests for ShadowDOM distribution
https://bugs.webkit.org/show_bug.cgi?id=103617

Reviewed by Dimitri Glazkov.

We would like to measure ShadowDOM distribution performance in various cases.
In this patch, we add performance tests for several distribution patterns.

  • ShadowDOM/ContentReprojection.html: Added.
  • ShadowDOM/DistributionWithMultipleShadowRoots.html: Added.
  • ShadowDOM/LargeDistributionWithLayout.html: Added.
  • ShadowDOM/MultipleInsertionPoints.html: Added.
  • ShadowDOM/ShadowReprojection.html: Added.
  • ShadowDOM/SmallDistributionWithLayout.html: Added.
10:29 PM Changeset in webkit [136804] by fpizlo@apple.com
  • 2 edits in trunk/Tools

DFG profiler should be able to display where a code block was inlined into, and what it inlined
https://bugs.webkit.org/show_bug.cgi?id=104216

Reviewed by Oliver Hunt.

Added an "inlines" command that shows the inline stacks that a code block participated
in. Also cleaned up some of the ways we print compilation units.

  • Scripts/display-profiler-output:
10:16 PM Changeset in webkit [136803] by tkent@chromium.org
  • 8 edits in trunk

Source/WebCore: INPUT_MULTIPLE_FIELDS_UI: The hour, am/pm, millisecond fields should support read-only state correctly
https://bugs.webkit.org/show_bug.cgi?id=104210

Reviewed by Kentaro Hara.

  1. The hour, am/pm, and millisecond fields should have CSS rules for [readonly]. They should be gray when they are read-only.
  2. The am/pm field should reject to set an empty value like other numeric fields do.

Tests: Add test cases to fast/forms/time/time-appearance-basic.html.

  • css/html.css: merge existing readonly rules, and add ampm, hour, and

millisecond pseudo classes.

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::setEmptyValue):
Reject to set empty value if it is read-only.

LayoutTests: INPUT_MULTIPLE_FIELDS_UI: The hour field and the am/pm field should support read-only state correctly
https://bugs.webkit.org/show_bug.cgi?id=104210

Reviewed by Kentaro Hara.

  • fast/forms/time/time-appearance-basic.html:

Add test cases for step=86400 (24 hours)

  • platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
  • platform/chromium/TestExpectations:
10:09 PM Changeset in webkit [136802] by tasak@google.com
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed, WebKit gardening.

  • WebKit.gyp:

Removed public/linux/WebRenderTheme.h. The file was removed.

10:08 PM Changeset in webkit [136801] by shinyak@chromium.org
  • 1 edit
    2 adds in trunk/PerformanceTests

[Shadow] Performance tests of distribution for changing className
https://bugs.webkit.org/show_bug.cgi?id=103612

Reviewed by Dimitri Glazkov.

We would like to measure ShadowDOM performance and compare it to the similar functional HTML without using ShadowDOM.
In this patch, we add a case when classNames of distributed elemeents are changed.

  • ShadowDOM/ChangingClassName.html: Added.
  • ShadowDOM/ChangingClassNameShadowDOM.html: Added.
10:08 PM Changeset in webkit [136800] by commit-queue@webkit.org
  • 4 edits in trunk

HTMLFormElement#requestAutocomplete() should require a user action
https://bugs.webkit.org/show_bug.cgi?id=102320

Patch by Dan Beam <dbeam@chromium.org> on 2012-12-05
Reviewed by Kent Tamura.

This patch dispatches an autocompleteerror when HTMLFormElement::requestAutocomplete() is called while not processing
a user gesture.

Source/WebCore:

  • fast/forms/form-request-autocomplete.html is updated.
  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::requestAutocomplete):

Asynchronously dispatch an autocomplete error when not processing a user action when
HTMLFormElement#requestAutocomplete() is invoked.

LayoutTests:

  • fast/forms/form-request-autocomplete.html:

Added a test to ensure that dispatching a call to HTMLFormElement#requestAutocomplete() in a setTimeout() (which will
never be a user gesture) always fails.

10:02 PM Changeset in webkit [136799] by james.wei@intel.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/committers.py

Add myself into committers.py

10:01 PM Changeset in webkit [136798] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-05

  • DEPS:
9:47 PM Changeset in webkit [136797] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Optimize v8StringOrNull() and v8StringOrUndefined()
https://bugs.webkit.org/show_bug.cgi?id=104206

Reviewed by Adam Barth.

Currently v8StringOrNull() and v8StringOrUndefined() are checking
a null string twice. It is redundant.

[div.localName]
Before this patch: 20.03 ns
After this patch: 19.34 ns

  • bindings/v8/V8Binding.h:

(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):

9:35 PM Changeset in webkit [136796] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Optimize v8String() for uninitialized DOM attributes
https://bugs.webkit.org/show_bug.cgi?id=104205

Reviewed by Adam Barth.

This patch makes uninitialized div.lang, div.title etc 6.3% faster.

[div.lang]
Before this patch: 12.6 ns
After this patch: 11.8 ns

  • bindings/v8/V8Binding.h:

(WebCore::v8String):

9:09 PM Changeset in webkit [136795] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Coordinated Graphics: Reorder messages to LayerTreeCoordinatorProxy
https://bugs.webkit.org/show_bug.cgi?id=103843

Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-05
Reviewed by Noam Rosenthal.

Clarify LayerTreeRenderer::setRootLayerID() can be called only once during its
lifecycle. LayerTreeRenderer, LayerTreeCoordinator and LayerTreeCoordinatorProxy
have the same lifecycle to WebPage and the root layer is reused even if loading
new page, so it is impossible to call LayerTreeRenderer::setRootLayerID() more
than twice.

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::setRootLayerID):

8:54 PM Changeset in webkit [136794] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Remove addImplicitReferencesForNodeWithEventListeners()
https://bugs.webkit.org/show_bug.cgi?id=104203

Reviewed by Adam Barth.

We can use opaqueRootForGC() instead. By this change, we can remove
all AddImplicitReferences() from V8 bindings.

Tests: fast/dom/gc-image-element.html

fast/dom/gc-image-element-2.html
fast/dom/inline-event-attributes-lookup-removed.html

  • bindings/v8/V8GCController.cpp:
7:47 PM Changeset in webkit [136793] by commit-queue@webkit.org
  • 3 edits
    6 adds in trunk

[CSS Regions] Blocks don't relayout children if the width of a region changes
https://bugs.webkit.org/show_bug.cgi?id=103993

Patch by Andrei Bucur <abucur@adobe.com> on 2012-12-05
Reviewed by David Hyatt.

Source/WebCore:

After r135750 lines are no longer invalidating when regions change width. This is happening because the detection for the width change was being done
only at line layout time. This patch moves the line relayout decision to the containing block by setting the relayoutChildren flag if the block
has no region chain attached.

Tests: fast/regions/region-width-change-relayout-1.html

fast/regions/region-width-change-relayout-2.html
fast/regions/region-width-change-relayout-3.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::logicalWidthChangedInRegions):

LayoutTests:

The first test covers the case of reducing the width of a region for a block content node.
The second test covers the case of expanding the width of a region for a block content node.
The third test covers the case of reducing the width of a region for an inline content node.

  • fast/regions/region-width-change-relayout-1-expected.html: Added.
  • fast/regions/region-width-change-relayout-1.html: Added.
  • fast/regions/region-width-change-relayout-2-expected.html: Added.
  • fast/regions/region-width-change-relayout-2.html: Added.
  • fast/regions/region-width-change-relayout-3-expected.html: Added.
  • fast/regions/region-width-change-relayout-3.html: Added.
7:44 PM Changeset in webkit [136792] by bfulgham@webkit.org
  • 5 edits
    1 copy in trunk/Source/WebKit2

[Windows, WinCairo] Regenerate .def files on changes
https://bugs.webkit.org/show_bug.cgi?id=104136

Reviewed by Tim Horton.

The new .def file generator is not regenerating the link
export definitions once it creates the definition file
the first time. You must clean the build directory for
new symbols to be added (or removed).

  • win/WebKit2.vcproj: Change the WebKit2.def file reference to point to the generated version of the file.
  • win/WebKit2ExportGenerator.vcproj: Add WebKit2.def.in as a source file that participates in the build so that Visual Studio knows to build the project when the file changes.
  • win/WebKit2ExportGeneratorBuildCmd.cmd: Added. Refactor build command into its own shell script.
  • win/WebKit2ExportGeneratorPostBuild.cmd: Call new BuildCmd script.
  • win/WebKit2ExportGeneratorPreBuild.cmd: Delete the old generator and definition files to ensure a clean build.
7:37 PM Changeset in webkit [136791] by kihong.kwon@samsung.com
  • 2 edits in trunk/Source/WebCore

Parameter event need to covert to RefPtr in the DeviceController::dispatchDeviceEvent
https://bugs.webkit.org/show_bug.cgi?id=104201

Reviewed by Laszlo Gombos.

Parameter 'event' need to covert to RefPtr in the DeviceController::dispatchDeviceEvent.
This can make crash sometimes.

No new tests. Covered by existing layout tests.

  • page/DeviceController.cpp:

(WebCore::DeviceController::dispatchDeviceEvent):

7:10 PM Changeset in webkit [136790] by commit-queue@webkit.org
  • 85 edits in trunk

[CMake] Unify coding style for CMake files
https://bugs.webkit.org/show_bug.cgi?id=103605

Patch by Halton Huo <halton.huo@intel.com> on 2012-12-05
Reviewed by Laszlo Gombos.

Update cmake files(.cmake, CMakeLists.txt) with following style rules:

  1. Indentation

1.1 Use spaces, not tabs.
1.2 Four spaces as indent.

  1. Spacing

2.1 Place one space between control statements and their parentheses.

For eg, if (), else (), elseif (), endif (), foreach (),
endforeach (), while (), endwhile (), break ().

2.2 Do not place spaces between function and macro statements and

their parentheses. For eg, macro(), endmacro(), function(),
endfunction().

2.3 Do not place spaces between a command or function or macro and its

parentheses, or between a parenthesis and its content. For eg,
message("testing") not message( "testing") or message ("testing" )

2.4 No space at line ending.

  1. Lowercase when call commands macros and functions. For eg, add_executable() not ADD_EXECUTABLE(), set() not SET().

.:

  • CMakeLists.txt:
  • Source/CMakeLists.txt:
  • Source/PlatformEfl.cmake:
  • Source/cmake/EFLHelpers.cmake:
  • Source/cmake/FindATK.cmake:
  • Source/cmake/FindCFLite.cmake:
  • Source/cmake/FindCairo.cmake:
  • Source/cmake/FindDBus.cmake:
  • Source/cmake/FindDirectX.cmake:
  • Source/cmake/FindE_DBus.cmake:
  • Source/cmake/FindEcore.cmake:
  • Source/cmake/FindEdje.cmake:
  • Source/cmake/FindEet.cmake:
  • Source/cmake/FindEeze.cmake:
  • Source/cmake/FindEfreet.cmake:
  • Source/cmake/FindEina.cmake:
  • Source/cmake/FindElementary.cmake:
  • Source/cmake/FindEnchant.cmake:
  • Source/cmake/FindEvas.cmake:
  • Source/cmake/FindFontconfig.cmake:
  • Source/cmake/FindGLIB.cmake:
  • Source/cmake/FindGStreamer.cmake:
  • Source/cmake/FindGperf.cmake:
  • Source/cmake/FindHarfBuzz.cmake:
  • Source/cmake/FindICU.cmake:
  • Source/cmake/FindLibSoup.cmake:
  • Source/cmake/FindQuickTimeSDK.cmake:
  • Source/cmake/FindSqlite.cmake:
  • Source/cmake/OptionsBlackBerry.cmake:
  • Source/cmake/OptionsCommon.cmake:
  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsWinCE.cmake:
  • Source/cmake/OptionsWindows.cmake:
  • Source/cmake/WebKitFS.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmake/WebKitHelpers.cmake:
  • Source/cmake/WebKitMacros.cmake:
  • Source/cmake/WebKitPackaging.cmake:
  • Source/cmake/gtest/CMakeLists.txt:

Source/JavaScriptCore:

  • CMakeLists.txt:
  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • PlatformWinCE.cmake:
  • shell/CMakeLists.txt:
  • shell/PlatformBlackBerry.cmake:
  • shell/PlatformEfl.cmake:
  • shell/PlatformWinCE.cmake:

Source/WebCore:

  • CMakeLists.txt:
  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • PlatformWinCE.cmake:
  • UseJSC.cmake:
  • UseV8.cmake:

Source/WebKit:

  • CMakeLists.txt:
  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • PlatformWinCE.cmake:

Source/WebKit/efl:

  • DefaultTheme/CMakeLists.txt:

Source/WebKit2:

  • CMakeLists.txt:
  • PlatformEfl.cmake:
  • win/WebKit2ExportGenerator.vcproj:
  • win/WebKit2ExportGeneratorCommon.vsprops:

Source/WTF:

  • CMakeLists.txt:
  • wtf/CMakeLists.txt:
  • wtf/PlatformBlackBerry.cmake:
  • wtf/PlatformEfl.cmake:
  • wtf/PlatformWinCE.cmake:

Tools:

  • CMakeLists.txt:
  • DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
  • DumpRenderTree/efl/CMakeLists.txt:
  • EWebLauncher/CMakeLists.txt:
  • EWebLauncher/ControlTheme/CMakeLists.txt:
  • MiniBrowser/efl/CMakeLists.txt:
  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/PlatformEfl.cmake:
  • WebKitTestRunner/CMakeLists.txt:
  • WebKitTestRunner/PlatformEfl.cmake:
  • WinCELauncher/CMakeLists.txt:
  • clang/ReportMemoryUsagePlugin/CMakeLists.txt:
6:58 PM Changeset in webkit [136789] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Remove unused property names from V8HiddenPropertyName
https://bugs.webkit.org/show_bug.cgi?id=104194

Reviewed by Adam Barth.

We can remove unused property names from V8HiddenPropertyName.

No tests. No change in behavior.

  • bindings/v8/V8HiddenPropertyName.h:

(WebCore):

6:50 PM Changeset in webkit [136788] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

Coordinated Graphics: Reorder messages to LayerTreeCoordinatorProxy
https://bugs.webkit.org/show_bug.cgi?id=103843

Patch by Huang Dongsung <luxtella@company100.net> on 2012-12-05
Reviewed by Noam Rosenthal.

Send SetRootCompositingLayer message to the UI process in the
constructor instead of sending it on the first flush.

This is in preparation for refactoring TextureMapper to work in an actor
model (http://webkit.org/b/103854).

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::setRootLayerID):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::initializeRootCompositingLayer):
(WebKit):
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

6:38 PM Changeset in webkit [136787] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Don't use the C API internally in ewk_cookie_manager
https://bugs.webkit.org/show_bug.cgi?id=103243

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-12-05
Reviewed by Gyuyoung Kim.

Used the C++ classes directly instead of the C API wrappers
to avoid a lot of toImpl/toAPI casts.

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::cookieManager):

  • UIProcess/API/efl/ewk_cookie_manager.cpp:

(EwkCookieManager::EwkCookieManager):
(EwkCookieManager::~EwkCookieManager):
(EwkCookieManager::setPersistentStorage):
(EwkCookieManager::setHTTPAcceptPolicy):
(EwkCookieManager::clearHostnameCookies):
(EwkCookieManager::clearAllCookies):
(EwkCookieManager::watchChanges):
(EwkCookieManager::getHostNamesWithCookies):
(EwkCookieManager::getHTTPAcceptPolicy):

  • UIProcess/API/efl/ewk_cookie_manager_private.h:

(EwkCookieManager::create):
(EwkCookieManager):

6:36 PM Changeset in webkit [136786] by commit-queue@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

[WK2][EFL] Gardening. Rebase fast/block/basic/020.html
https://bugs.webkit.org/show_bug.cgi?id=104195

Unreviewed Gardening.

The layer for "visibility:hidden;position:absolute;" object should be in RenderTree when USE(ACCELERATED_COMPOSITING),
because the HiddenLayers are included in zOrderList when CompositingMode is on.

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-12-05

  • platform/efl-wk2/fast/block/basic/020-expected.txt: Added.
  • platform/efl/TestExpectations:
6:06 PM Changeset in webkit [136785] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Add runtime enable for web intents.
https://bugs.webkit.org/show_bug.cgi?id=103669

Patch by Greg Billock <gbillock@google.com> on 2012-12-05
Reviewed by Adam Barth.

Source/WebCore:

Make web intents Javascript API enabled by a runtime setting.

  • Modules/intents/DOMWindowIntents.idl:
  • Modules/intents/NavigatorIntents.idl:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore):

  • bindings/generic/RuntimeEnabledFeatures.h:

(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::webkitStartActivityEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIntentEnabled):
(WebCore::RuntimeEnabledFeatures::webKitIntentEnabled):
(WebCore::RuntimeEnabledFeatures::setWebIntentsEnabled):

Source/WebKit/chromium:

Propagate runtime setting to enable/disable web intents Javascript API.

  • public/WebRuntimeFeatures.h:

(WebRuntimeFeatures):

  • src/WebRuntimeFeatures.cpp:

(WebKit::WebRuntimeFeatures::enableWebIntents):
(WebKit):
(WebKit::WebRuntimeFeatures::isWebIntentsEnabled):

5:38 PM Changeset in webkit [136784] by commit-queue@webkit.org
  • 12 edits
    10 deletes in trunk

[chromium] Remove linux theme related files and switch to default
https://bugs.webkit.org/show_bug.cgi?id=103897

Patch by Scott Violet <sky@chromium.org> on 2012-12-05
Reviewed by Tony Chang.

Source/Platform:

  • Platform.gypi: Remove WebThemeEngine.h
  • chromium/public/linux/WebThemeEngine.h: Removed.

Source/WebCore:

Linux related theme files are now named Default.

No new tests, code cleanup.

  • WebCore.gyp/WebCore.gyp: Update files
  • WebCore.gypi: Update files
  • platform/chromium/PlatformThemeChromiumLinux.cpp: Removed.
  • platform/chromium/PlatformThemeChromiumLinux.h: Removed.
  • platform/chromium/ScrollbarThemeChromiumLinux.cpp: Removed.
  • platform/chromium/ScrollbarThemeChromiumLinux.h: Removed.
  • rendering/RenderThemeChromiumAndroid.cpp:

(WebCore::RenderThemeChromiumAndroid::extraDefaultStyleSheet): Linux->Default

  • rendering/RenderThemeChromiumAndroid.h: Change superclass
  • rendering/RenderThemeChromiumLinux.cpp: Removed.
  • rendering/RenderThemeChromiumLinux.h: Removed.

Source/WebKit/chromium:

Linux theme related files are now named Default.

  • WebKit.gyp:
  • public/linux/WebRenderTheme.h: Removed.
  • public/platform/linux/WebThemeEngine.h: Removed.
  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::setScrollbarColors): Cleanup ifdefs.
(WebKit::WebViewImpl::setSelectionColors): Cleanup ifdefs.

  • src/linux/WebRenderTheme.cpp: Removed.

Tools:

  • Scripts/webkitpy/common/config/build_unittest.py:

(ShouldBuildTest): linux->default

5:35 PM Changeset in webkit [136783] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

Make the strip line numbers link into a checkbox
https://bugs.webkit.org/show_bug.cgi?id=104187

Reviewed by Tony Chang.

The link text was confusing.

  • PrettyPatch/PrettyPatch.rb:
  • code-review.js:
5:30 PM Changeset in webkit [136782] by jsbell@chromium.org
  • 18 edits
    9 adds in trunk

IndexedDB: Allow multiple transactions to interleave request execution
https://bugs.webkit.org/show_bug.cgi?id=97570

Reviewed by Tony Chang.

Source/WebCore:

Implement spec logic for allowing read-only transactions, and read-write transactions
with non-overlapping scopes, to run concurrently. Transactions all still run in the
same thread with tasks triggered via timers, so tasks and the underlying database
operations are interleaved rather than truly parallelized.

Within IDBTransactionCoordinator, rename started->queued, running->started to match
spec terminology and clear up confusion.

Test: storage/indexeddb/transaction-coordination-across-databases.html

storage/indexeddb/transaction-coordination-within-database.html
storage/indexeddb/transaction-readwrite-exclusive.html
storage/indexeddb/transaction-scope-sequencing.html
storage/indexeddb/transaction-starvation.html

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Use IDBTransaction::Mode enum

(WebCore::IDBDatabaseBackendImpl::createTransaction):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h: Ditto.

(IDBDatabaseBackendImpl):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h: Ditto.

(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp: Convert scope as a HashSet for

fast intersecting.
(WebCore::IDBTransactionBackendImpl::create):
(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl):

  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::mode):
(WebCore::IDBTransactionBackendImpl::scope):

  • Modules/indexeddb/IDBTransactionCoordinator.cpp: Spec logic goes here.

(WebCore::IDBTransactionCoordinator::processStartedTransactions): Extend this
method to test all plausibly runnable transactions.
(WebCore):
(WebCore::IDBTransactionCoordinator::canRunTransaction): Test to see if one
particular transaction can be run.
(WebCore::IDBTransactionCoordinator::doScopesOverlap): Do a quick intersection
test between transaction scopes.

  • Modules/indexeddb/IDBTransactionCoordinator.h:

(IDBTransactionCoordinator):

Source/WebKit/chromium:

Map to IDBTransaction::Mode enum as appropriate.

  • src/IDBDatabaseBackendProxy.cpp:

(WebKit::IDBDatabaseBackendProxy::createTransaction):

  • src/IDBDatabaseBackendProxy.h:

(IDBDatabaseBackendProxy):

  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::createTransaction):

  • tests/IDBDatabaseBackendTest.cpp:

LayoutTests:

New tests for parallel transactions, update existing tests that relied on sequential execution.

  • storage/indexeddb/database-close-expected.txt:
  • storage/indexeddb/mozilla/clear-expected.txt:
  • storage/indexeddb/mozilla/resources/clear.js: Split up transaction steps.
  • storage/indexeddb/resources/database-close.js: Don't log on individual transaction completion.
  • storage/indexeddb/resources/transaction-coordination-within-database.js: Added.
  • storage/indexeddb/resources/transaction-scope-sequencing.js: Added.
  • storage/indexeddb/resources/transaction-starvation.js: Added.
  • storage/indexeddb/transaction-coordination-within-database-expected.txt: Added.
  • storage/indexeddb/transaction-coordination-within-database.html: Added.
  • storage/indexeddb/transaction-scope-sequencing-expected.txt: Added.
  • storage/indexeddb/transaction-scope-sequencing.html: Added.
  • storage/indexeddb/transaction-starvation-expected.txt: Added.
  • storage/indexeddb/transaction-starvation.html: Added.
5:23 PM Changeset in webkit [136781] by commit-queue@webkit.org
  • 11 edits in trunk/Source

Coordinated Graphics: Enable support for setContentsToBackgroundColor
https://bugs.webkit.org/show_bug.cgi?id=104128

Patch by No'am Rosenthal <Noam Rosenthal> on 2012-12-05
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Enable background color in GraphicsLayerTextureMapper, and paint it using TextureMapper::drawSolidColor.
Once https://bugs.webkit.org/show_bug.cgi?id=103786 is enabled, this would enable Qt/GTK/EFL to directly
composite colors that only have a background color, without having to create a backing store for them.
This would eliminate the memory usage for those layers, reduce the time needed for them to draw into the
backing store and upload the texture, and in the future allow direct compositing of things other than
background colors.

Compositing tests cover this, but are still skipped for ports using coordinated graphics.
See https://bugs.webkit.org/show_bug.cgi?id=104129.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setContentsToBackgroundColor):
(WebCore::GraphicsLayerTextureMapper::backgroundColor):

Maintain a backgroundColor member variable in GraphicsLayerTextureMapper

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawSolidColor):

TextureMapperGL::drawSolidColor should allow blending when the solid color has alpha.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::flushCompositingStateSelf):

  • platform/graphics/texmap/TextureMapperLayer.h:

(State):

Source/WebKit2:

Enable setContentsToBackgroundColor in CoordinatedGraphicsLayer, and pass it through to the UI process.

  • Shared/WebLayerTreeInfo.h:

(WebLayerInfo):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::setLayerState):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::setContentsToBackgroundColor):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayer):

4:53 PM Changeset in webkit [136780] by dpranke@chromium.org
  • 7 edits in trunk/Tools

nrwt: run_webkit_tests_integrationtest.py depends on being able to share a port w/ between master and worker
https://bugs.webkit.org/show_bug.cgi?id=78168

Reviewed by Ojan Vafai.

This patch adds a single ordered list to ResultSummary that contains
the results of every test run in order of result received, and
modifies the TestResults class to contain the list of references used
for each test as well as the pid of the driver; this allows us to stop
having to override the test drivers to record the tests, and makes the
integration tests that test rdering, retries, restarts, etc. black-box
tests.

  • Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:

(SingleTestRunner._run_rebaseline):
(SingleTestRunner._compare_output):
(SingleTestRunner._run_reftest):
(SingleTestRunner._compare_output_with_reference):

  • Scripts/webkitpy/layout_tests/models/result_summary.py:

(ResultSummary.init):
(ResultSummary.add):

  • Scripts/webkitpy/layout_tests/models/test_results.py:

(TestResult.init):

  • Scripts/webkitpy/layout_tests/port/driver.py:

(DriverOutput.init):
(Driver.run_test):

  • Scripts/webkitpy/layout_tests/port/test.py:

(TestDriver):
(TestDriver.init):
(TestDriver.run_test):
(TestDriver.stop):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(get_tests_run):
(get_test_batches):
(get_test_results):
(MainTest.test_batch_size):
(MainTest.test_dryrun):
(MainTest.test_natural_order):
(MainTest.test_natural_order_test_specified_multiple_times):
(MainTest.test_random_order):
(MainTest.test_random_order_test_specified_multiple_times):
(MainTest.test_no_order):
(MainTest.test_no_order_test_specified_multiple_times):
(MainTest.test_no_order_with_directory_entries_in_natural_order):
(MainTest.test_repeat_each):
(MainTest.test_ignore_flag):
(MainTest.test_skipped_flag):
(MainTest.test_iterations):
(MainTest.test_run_chunk):
(MainTest.test_run_part):
(MainTest.test_run_singly):
(MainTest.test_skip_failing_tests):
(MainTest.test_single_file):
(MainTest.test_single_file_with_prefix):
(MainTest.test_single_skipped_file):
(MainTest.test_test_list):
(MainTest.test_test_list_with_prefix):
(MainTest.test_exit_after_n_failures):
(MainTest.test_exit_after_n_crashes):
(MainTest.test_run_orderinline):
(MainTest.test_reftest_run):
(MainTest.test_reftest_run_reftests_if_pixel_tests_are_disabled):
(MainTest.test_reftest_skip_reftests_if_no_ref_tests):
(MainTest.test_reftest_expected_html_should_be_ignored):
(MainTest.test_reftest_driver_should_run_expected_html):
(MainTest.test_reftest_driver_should_run_expected_mismatch_html):
(MainTest.test_no_http_tests):
(MainTest.test_platform_tests_are_found):

4:40 PM Changeset in webkit [136779] by danakj@chromium.org
  • 7 edits in trunk

[chromium] Make WebCompositorOutputSurface an empty class when USE_CC_OUTPUT_SURFACE is defined.
https://bugs.webkit.org/show_bug.cgi?id=103967

Reviewed by James Robinson.

Source/Platform:

When the USE_CC_OUTPUT_SURFACE flag is set:

  • Make the WebCompositorOutputSurface class empty.
  • Don't define the OutputSurfaceClient.
  • Don't define the SoftwareOutputDevice.

WebCompositorSupport has methods to create a WebCompositorOutputSurface. They
will return NULL until the chromium side lands, and then they will be used
in place of the existing WebViewHost methods.

  • chromium/public/WebCompositorOutputSurface.h:

(WebKit):

  • chromium/public/WebCompositorOutputSurfaceClient.h:

(WebKit):

  • chromium/public/WebCompositorSoftwareOutputDevice.h:

(WebKit):

  • chromium/public/WebCompositorSupport.h:

(WebKit):
(WebCompositorSupport):
(WebKit::WebCompositorSupport::createOutputSurfaceFor3D):
(WebKit::WebCompositorSupport::createOutputSurfaceForSoftware):

Tools:

Use the WebCompositorSupport methods to create an OutputSurface. If they
fail, then fall back to the WebViewHost methods.

Once the chromium side lands, the WebCompositorSupport methods will stop
failing, and will replace the WebViewHost ones.

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createOutputSurface):

4:33 PM Changeset in webkit [136778] by Lucas Forschler
  • 2 edits in tags/Safari-537.20.3/Source/WebKit2

Merged r136776. <rdar://problem/12809890>

4:31 PM Changeset in webkit [136777] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r136481.
http://trac.webkit.org/changeset/136481
https://bugs.webkit.org/show_bug.cgi?id=103868

it might have regressed dom_perf/CloneNodes (See bug 104177)

  • dom/ContainerNodeAlgorithms.h:

(ChildNodeInsertionNotifier):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoDocument):
(WebCore::ChildNodeInsertionNotifier::notifyNodeInsertedIntoTree):
(WebCore::ChildNodeInsertionNotifier::notify):

4:22 PM Changeset in webkit [136776] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/12809890> Should allow sandbox lookup of com.apple.tccd

Reviewed by Beth Dakin and Dan Bernstein.

  • WebProcess/com.apple.WebProcess.sb.in:
4:08 PM Changeset in webkit [136775] by dgrogan@chromium.org
  • 2 edits in trunk/Source/WebCore

IndexedDB: Abort transactions because of leveldb errors part 3
https://bugs.webkit.org/show_bug.cgi?id=103960

Reviewed by Tony Chang.

Transactions are aborted when there are leveldb problems creating
indexes on an object store with existing data or when adding data to an
objectstore that has indexes.

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore):
(WebCore::makeIndexWriters):
(WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreStorageOperation::perform):

4:07 PM Changeset in webkit [136774] by Simon Fraser
  • 6 edits in trunk/Source/WebCore

Fix some repaint/paintCounter confusion, and reset it when getting layers out of the layer pool
https://bugs.webkit.org/show_bug.cgi?id=104180

Reviewed by Tim Horton.

Layers retrieved from the LayerPool by TileCache need to have their
repaint counters reset, otherwise the scroll performance logging gets
confused.

Also, the counter counts paints, not repaints (invalidations), so
rename it accordingly.

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::logExposedUnfilledArea): Whitespace fix.

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/ca/mac/TileCache.mm:

(WebCore::TileCache::blankPixelCountForTiles):
(WebCore::TileCache::createTileLayer):
(WebCore::TileCache::drawRepaintCounter):

  • platform/graphics/ca/mac/WebTileLayer.h:
  • platform/graphics/ca/mac/WebTileLayer.mm:

(-[WebTileLayer resetPaintCount]):
(-[WebTileLayer incrementPaintCount]):
(-[WebTileLayer paintCount]):
(-[WebTileLayer logFilledFreshTile]):

3:43 PM Changeset in webkit [136773] by oliver@apple.com
  • 7 edits in trunk/Source

Empty parse cache when receiving a low memory warning
https://bugs.webkit.org/show_bug.cgi?id=104161

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This adds a function to the globaldata to empty all code related data
structures (code in the heap and the code cache).
It also adds a function to allow the CodeCache to actually be cleared
at all.

  • runtime/CodeCache.h:

(CacheMap):
(JSC::CacheMap::clear):
(JSC::CodeCache::clear):
(CodeCache):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::discardAllCode):
(JSC):

  • runtime/JSGlobalData.h:

(JSGlobalData):

Source/WebCore:

Use new discardAllCode() function on the global data, rather than
directly interacting with the heap.

  • bindings/js/GCController.cpp:

(WebCore::GCController::discardAllCompiledCode):

3:39 PM Changeset in webkit [136772] by ojan@chromium.org
  • 4 edits in trunk/Websites/bugs.webkit.org

Sanitize content on copy in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=104155

Reviewed by Tony Chang.

Always remove expand/header/annotate links. Provide an option
to remove line numbers as well. Store the option in localStorage so
people can always get whichever behavior they want.

A better solution would be to restructure the DOM, but that would require gutting
the whole code review tool and would make it difficult to include line numbers if
you wanted them.

  • PrettyPatch/PrettyPatch.rb:
  • code-review-test.html:
  • code-review.js:
3:28 PM Changeset in webkit [136771] by dpranke@chromium.org
  • 5 edits
    2 adds in trunk/Tools

nrwt: split all of the buildbot-specific output into its own file
https://bugs.webkit.org/show_bug.cgi?id=104165

Reviewed by Ojan Vafai.

Now that we have the RunDetails object we can move all of the
buildbot-specific knowledge out of the core test-running code
and into the outermost run_webkit_tests layer.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(run):
(main):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(passing_run):
(logging_run):
(run_and_capture):
(MainTest.test_all):
(MainTest.test_max_locked_shards):
(MainTest.test_child_processes_2):
(MainTest.test_child_processes_min):
(MainTest.test_full_results_html):
(MainTest.test_hung_thread):
(MainTest.test_keyboard_interrupt):
(MainTest.test_no_tests_found):
(MainTest.test_no_tests_found_2):
(MainTest.test_repeat_each_iterations_num_tests):
(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_test_list):
(MainTest.test_unexpected_failures):
(MainTest.test_missing_and_unexpected_results):
(MainTest.test_pixel_test_directories):
(MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
(MainTest.test_crash_with_stderr):
(MainTest.test_no_image_failure_with_image_diff):
(MainTest.test_crash_log):
(MainTest.test_web_process_crash_log):
(MainTest.test_exit_after_n_failures_upload):
(MainTest.test_results_directory_absolute):
(MainTest.test_results_directory_default):
(MainTest.test_results_directory_relative):
(MainTest.test_retrying_and_flaky_tests):
(MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
(MainTest.test_output_diffs):
(MainTest.test_unsupported_platform):
(MainTest.test_verbose_in_child_processes):
(EndToEndTest.test_end_to_end):
(EndToEndTest.test_reftest_with_two_notrefs):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):

  • Scripts/webkitpy/layout_tests/views/buildbot_results.py: Added.

(BuildBotPrinter):
(BuildBotPrinter.init):
(BuildBotPrinter.print_results):
(BuildBotPrinter._print):
(BuildBotPrinter.print_result_summary):
(BuildBotPrinter._print_result_summary_entry):
(BuildBotPrinter.print_unexpected_results):
(BuildBotPrinter.print_unexpected_results.add_to_dict_of_lists):
(BuildBotPrinter.print_unexpected_results.add_result):

  • Scripts/webkitpy/layout_tests/views/buildbot_results_unittest.py: Added.

(BuildBotPrinterTests):
(BuildBotPrinterTests.assertEmpty):
(BuildBotPrinterTests.assertNotEmpty):
(BuildBotPrinterTests.get_printer):
(BuildBotPrinterTests.get_result):
(BuildBotPrinterTests.get_result_summary):
(BuildBotPrinterTests.test_print_unexpected_results):
(BuildBotPrinterTests.test_print_unexpected_results.get_unexpected_results):

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer):
(Printer.init):
(Printer.print_results):
(Printer._print_statistics_for_test_timings):
(Printer._print_baseline):
(Printer._print_debug):

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(Testprinter.get_printer):
(Testprinter.get_result):
(Testprinter.test_configure_and_cleanup):
(Testprinter.test_print_config):
(Testprinter.test_print_one_line_summary):
(Testprinter.test_test_status_line):
(Testprinter.test_details):

3:28 PM Changeset in webkit [136770] by ap@apple.com
  • 18 edits
    2 adds in trunk/Source/WebKit2

[WK2] Would like to queue messages while NetworkProcess is launching
https://bugs.webkit.org/show_bug.cgi?id=104143

Reviewed by Anders Carlsson.

Factored out process launching and message sending code to a ChildProcessProxy class.
Process closing and crashing code should be moved once we better understand common
requirements for the processes.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebKit2.xcodeproj/project.pbxproj:
  • win/WebKit2.vcproj: Added ChildProcessProxy files.
  • Shared/ChildProcessProxy.cpp: Added. (WebKit::ChildProcessProxy::ChildProcessProxy): (WebKit::ChildProcessProxy::~ChildProcessProxy): (WebKit::ChildProcessProxy::fromConnection): (WebKit::ChildProcessProxy::connect): (WebKit::ChildProcessProxy::terminate): (WebKit::ChildProcessProxy::sendMessage): (WebKit::ChildProcessProxy::isLaunching): (WebKit::ChildProcessProxy::didFinishLaunching): (WebKit::ChildProcessProxy::clearConnection):
  • Shared/ChildProcessProxy.h: Added. (WebKit::ChildProcessProxy::connection): (WebKit::ChildProcessProxy::isValid): (WebKit::ChildProcessProxy::canSendMessage): (WebKit::ChildProcessProxy::processIdentifier): (WebKit::ChildProcessProxy::send): (WebKit::ChildProcessProxy::sendSync): Moved code from WebProcessProxy. Every ChildProcessProxy is a connection client, but every one is a connection queue client, so that latter is passed as an argument.
  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Network/NetworkProcessProxy.cpp: Removed unused syncMessageSendTimedOut(), thank you OVERRIDE.
  • UIProcess/Network/NetworkProcessProxy.cpp: (WebKit::NetworkProcessProxy::NetworkProcessProxy): (WebKit::NetworkProcessProxy::getLaunchOptions): (WebKit::NetworkProcessProxy::~NetworkProcessProxy): (WebKit::NetworkProcessProxy::getNetworkProcessConnection): (WebKit::NetworkProcessProxy::didFinishLaunching):
  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Network/mac/NetworkProcessProxyMac.mm: (WebKit::NetworkProcessProxy::setApplicationIsOccluded):
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::WebProcessProxy): (WebKit::WebProcessProxy::~WebProcessProxy): (WebKit::WebProcessProxy::getLaunchOptions): (WebKit::WebProcessProxy::disconnect): (WebKit::WebProcessProxy::didFinishLaunching): Use shared code.
  • UIProcess/WebProcessProxy.h: (WebKit::WebProcessProxy::fromConnection): NetworkProcess inherits from conneciton client privately, so we need to do most of the work in ClientProcessProxy, and further upcast here.
  • UIProcess/efl/WebProcessProxyEfl.cpp: (WebKit::WebProcessProxy::platformGetLaunchOptions):
  • UIProcess/gtk/WebProcessProxyGtk.cpp: (WebKit::WebProcessProxy::platformGetLaunchOptions):
  • UIProcess/mac/WebProcessProxyMac.mm: (WebKit::WebProcessProxy::platformGetLaunchOptions):
  • UIProcess/qt/WebProcessProxyQt.cpp: (WebKit::WebProcessProxy::platformGetLaunchOptions):
  • UIProcess/win/WebProcessProxyWin.cpp: (WebKit::WebProcessProxy::platformGetLaunchOptions): Updated for renaming, platformConnect -> platformGetLaunchOptions().
3:26 PM Changeset in webkit [136769] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt: collect all of the information about a run into a new RunDetails class
https://bugs.webkit.org/show_bug.cgi?id=104158

Reviewed by Ojan Vafai.

This patch collects the information from both test passes (the
main one and the retries) as well as the summarized results and
the exit code into a RunDetails class, so that the integration
tests can more easily tell what happened.

Also, change the way the --lint-test-files works slightly so that
we don't need to create a printer object (and hence we need to
rework the tests that are testing logging).

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(RunDetails):
(RunDetails.init):
(Manager.run):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(run):
(main):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(passing_run):
(run_and_capture):
(LintTest.test_lint_test_files):
(LintTest.test_lint_test_fileserrors):
(MainTest.test_verbose_in_child_processes):

3:25 PM Changeset in webkit [136768] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt: remove --no-record-results
https://bugs.webkit.org/show_bug.cgi?id=104072

Reviewed by Ojan Vafai.

The command line flag was only being used in the unit tests and
wasn't really needed once we started using a mock filesystem.

Also, reformat a bunch of long lines ...

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run):

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(parse_args):
(passing_run):
(logging_run):
(MainTest.test_repeat_each_iterations_num_tests):
(MainTest.test_test_list):
(MainTest.test_missing_and_unexpected_results):
(MainTest.test_pixel_test_directories):
(MainTest.test_missing_and_unexpected_results_with_custom_exit_code):
(MainTest.test_crash_with_stderr):
(MainTest.test_no_image_failure_with_image_diff):
(MainTest.test_crash_log):
(MainTest.test_web_process_crash_log):
(MainTest.test_exit_after_n_failures_upload):
(MainTest.test_results_directory_absolute):
(MainTest.test_results_directory_relative):
(MainTest.test_reftest_should_not_use_naming_convention_if_not_listed_in_reftestlist):
(MainTest.test_additional_expectations):
(MainTest.test_output_diffs):
(EndToEndTest.test_end_to_end):
(EndToEndTest.test_reftest_with_two_notrefs):
(RebaselineTest.test_reset_results):
(RebaselineTest.test_missing_results):
(RebaselineTest.test_new_baseline):

3:14 PM Changeset in webkit [136767] by dpranke@chromium.org
  • 5 edits in trunk/Tools

nrwt: only summarize the results one way
https://bugs.webkit.org/show_bug.cgi?id=104064

Reviewed by Ojan Vafai.

Change manager.summarize_results so that we always (and only)
include both expected and unexpected results. Previously we
would summarize the results twice, once with expected results
and once without. This made the code much more confusing than
it needed to be.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(summarize_results):
(Manager.run):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ResultSummaryTest.summarized_results):
(ResultSummaryTest.test_no_svn_revision):
(ResultSummaryTest.test_svn_revision):
(ResultSummaryTest.test_summarized_results_wontfix):

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.print_results):
(Printer._print_unexpected_results):
(Printer._print_unexpected_results.add_result):

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(Testprinter.test_print_unexpected_results.get_unexpected_results):
(Testprinter):

3:14 PM Changeset in webkit [136766] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

WebKit2 child processes need to initialize timer coalescing policy on Mac.
https://bugs.webkit.org/show_bug.cgi?id=103613

Patch by Kiran Muppala <cmuppala@apple.com> on 2012-12-05
Reviewed by Mark Rowe.

Set timer coalescing policy of WebKit2 child processes to that of visible applications
until they can manage the policy based on UI process visibility.

  • Shared/mac/ChildProcessMac.mm:

(WebKit::initializeTimerCoalescingPolicy): Set task_latency and task_throughput QOS tiers as appropriate
for visible applications.
(WebKit::ChildProcess::platformInitialize): Add call to initializeTimerCoalescingPolicy.

3:07 PM Changeset in webkit [136765] by mitz@apple.com
  • 4 edits
    3 adds in trunk

Text decorations are rotated when text-combine takes effect
https://bugs.webkit.org/show_bug.cgi?id=104172

Reviewed by Dave Hyatt.

Source/WebCore:

Test: fast/text/decorations-with-text-combine.html

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint): Applied a rotation to the graphics context when painting
the text decorations for combined text.

LayoutTests:

  • fast/text/decorations-with-text-combine.html: Added.
  • platform/chromium/TestExpectations: Added to tests missing platform-specific results.
  • platform/mac/fast/text/decorations-with-text-combine-expected.png: Added.
  • platform/mac/fast/text/decorations-with-text-combine-expected.txt: Added.
2:46 PM Changeset in webkit [136764] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Geolocation prompts won't respond to the correct geolocation object if the user opens two pages and respond in the reversed order
https://bugs.webkit.org/show_bug.cgi?id=104162

PR 257505
Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-12-05
Reviewed by Yong Li.

GeolocationClientBlackBerry will register itself to GeolocationHandler when it has
a pending request. When browser responds with WebPageClientImpl::setAllowGeolocation,
we go through the list and let all the pending GeolocationListeners know that a certain
origin has been aceepted/denied.

  • WebCoreSupport/GeolocationClientBlackBerry.cpp:

(GeolocationClientBlackBerry::geolocationDestroyed):
(GeolocationClientBlackBerry::requestPermission):
(GeolocationClientBlackBerry::cancelPermissionRequest):
(GeolocationClientBlackBerry::onPermission):

2:38 PM Changeset in webkit [136763] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Remove WebLayerTreeView API to set font atlas
https://bugs.webkit.org/show_bug.cgi?id=102960

Patch by Eberhard Graether <egraether@google.com> on 2012-12-05
Reviewed by James Robinson.

Removes old font atlas creation from WebViewImpl.

Source/Platform:

  • chromium/public/WebLayerTreeView.h:

Source/WebKit/chromium:

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setShowFPSCounter):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):

  • src/WebViewImpl.h:
2:16 PM Changeset in webkit [136762] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Connection::waitForMessage shouldn't use the message ID
https://bugs.webkit.org/show_bug.cgi?id=104157

Reviewed by Andreas Kling.

Pass the message receiver name and message name to waitForMessage and use them for lookups instead of
the message ID.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::createSyncMessageEncoder):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::processIncomingMessage):

  • Platform/CoreIPC/Connection.h:

(CoreIPC::Connection::waitForAndDispatchImmediately):

2:12 PM Changeset in webkit [136761] by jpetsovits@rim.com
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Better crash fix for resetting tiles on a backingstore takeover.
https://bugs.webkit.org/show_bug.cgi?id=103969
RIM PR 258415

Reviewed by Adam Treat.

The previous attempt for releasing tile buffers from the
previously active backingstore did not take into account
that resetTiles() would sometimes return early without
having swapped the tiles and thus reclaiming them.

This patch removes the early returns, because it's safe
to swap in an empty geometry at any time and we should
always take the chance when we get it.

Also put the code that calls resetTiles() on an owner
switch right into setCurrentBackingStoreOwner(), so that
it will also release the buffers when the BackingStore
is destroyed (the function is then called with 0).

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::resetTiles):
(WebKit):
(BlackBerry::WebKit::BackingStorePrivate::setCurrentBackingStoreOwner):

  • Api/BackingStore.h: Had to add the friend here to make the moved code work from the static function.
  • Api/BackingStore_p.h:

(BackingStorePrivate):

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):

1:57 PM Changeset in webkit [136760] by commit-queue@webkit.org
  • 3 edits
    4 moves in trunk/Source/WebKit2

Coordinated Graphics: Move AreaAllocator and UpdateAtlas to CoordinatedGraphics
https://bugs.webkit.org/show_bug.cgi?id=103864

Patch by Jae Hyun Park <jae.park@company100.net> on 2012-12-05
Reviewed by Noam Rosenthal.

AreaAllocator and UpdateAtlas are only used for Coordinated Graphics.
So, these should be moved to CoordinatedGraphics to clarify the code.

No new test, because no change of behavior.

  • CMakeLists.txt:
  • Target.pri:
  • WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/AreaAllocator.cpp.

(WebKit):
(WebKit::AreaAllocator::AreaAllocator):
(WebKit::AreaAllocator::~AreaAllocator):
(WebKit::AreaAllocator::expand):
(WebKit::AreaAllocator::expandBy):
(WebKit::AreaAllocator::release):
(WebKit::AreaAllocator::overhead):
(WebKit::AreaAllocator::roundAllocation):
(WebKit::GeneralAreaAllocator::GeneralAreaAllocator):
(WebKit::GeneralAreaAllocator::~GeneralAreaAllocator):
(WebKit::GeneralAreaAllocator::freeNode):
(WebKit::GeneralAreaAllocator::expand):
(WebKit::fitsWithin):
(WebKit::GeneralAreaAllocator::allocate):
(WebKit::GeneralAreaAllocator::allocateFromNode):
(WebKit::GeneralAreaAllocator::splitNode):
(WebKit::GeneralAreaAllocator::updateLargestFree):
(WebKit::GeneralAreaAllocator::release):
(WebKit::GeneralAreaAllocator::overhead):

  • WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.h: Renamed from Source/WebKit2/WebProcess/WebPage/AreaAllocator.h.

(WebCore::nextPowerOfTwo):
(WebCore):
(WebKit):
(AreaAllocator):
(WebKit::AreaAllocator::size):
(WebKit::AreaAllocator::minimumAllocation):
(WebKit::AreaAllocator::setMinimumAllocation):
(WebKit::AreaAllocator::margin):
(WebKit::AreaAllocator::setMargin):
(GeneralAreaAllocator):
(Node):

  • WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/UpdateAtlas.cpp.

(WebKit):
(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit::UpdateAtlas::~UpdateAtlas):
(WebKit::UpdateAtlas::buildLayoutIfNeeded):
(WebKit::UpdateAtlas::didSwapBuffers):
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):

  • WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h: Renamed from Source/WebKit2/WebProcess/WebPage/UpdateAtlas.h.

(WebCore):
(WebKit):
(UpdateAtlasClient):
(UpdateAtlas):
(WebKit::UpdateAtlas::size):
(WebKit::UpdateAtlas::flags):
(WebKit::UpdateAtlas::addTimeInactive):
(WebKit::UpdateAtlas::isInactive):
(WebKit::UpdateAtlas::isInUse):

1:48 PM Changeset in webkit [136759] by Lucas Forschler
  • 2 edits in tags/Safari-537.20.3/Source/WebKit2

Merged r136598. <rdar://problem/12804399>

1:47 PM Changeset in webkit [136758] by tony@chromium.org
  • 8 edits in trunk/LayoutTests

Unreviewed, add Mac baselines after r136409 (mathml sup/sub box changes).

  • platform/mac/TestExpectations:
  • platform/mac/mathml/presentation/roots-expected.txt:
  • platform/mac/mathml/presentation/row-alignment-expected.txt:
  • platform/mac/mathml/presentation/sub-expected.txt:
  • platform/mac/mathml/presentation/subsup-expected.txt:
  • platform/mac/mathml/presentation/sup-expected.txt:
  • platform/mac/mathml/presentation/tables-expected.txt:
1:41 PM Changeset in webkit [136757] by leoyang@rim.com
  • 3 edits in trunk/LayoutTests

Extra space in fast/css/image-resolution/image-resolution.html
https://bugs.webkit.org/show_bug.cgi?id=104130

Reviewed by Emil A Eklund.

String returned by cssText doesn't include an extra tailing space.
This patch is removing an expectation of the extra tailing space in the test.

  • fast/css/image-resolution/image-resolution-expected.txt:
  • fast/css/image-resolution/image-resolution.html:
1:40 PM Changeset in webkit [136756] by fpizlo@apple.com
  • 2 edits in trunk/Tools

DFG profiler should display more information
https://bugs.webkit.org/show_bug.cgi?id=104163

Reviewed by Gavin Barraclough.

Added the following:

  • Distinguish between source counts and bytecode counts.


  • Add a "full" summary view that shows both kinds of counts, plus inline counts.


  • Add a "source" command to see the source.


  • Add a "bytecode" command to see the bytecode and counts.
  • Scripts/display-profiler-output:
1:40 PM Changeset in webkit [136755] by junov@google.com
  • 13 edits in trunk

[skia] Improve performance of GraphicsContext::createCompatibleBuffer by using SkDevice:createCompatibleDevice
https://bugs.webkit.org/show_bug.cgi?id=103896

Reviewed by Stephen White.

Source/WebCore:

Refactored GraphicsContext::createCompatibleBuffer (platform common
code) to use platform-specific implementations provided by ImageBuffer.
There is no change in behavior for non-skia ports. The skia
implementation uses skia'a own createCompatibleDevice implementation,
which offers several performance benefits:

  1. For accelerated contexts, the backing store may be allocated from

the scratch texture pool, which minimizes texture allocation and
deallocation overhead.

  1. The backing store will not be initially cleared if it is known

in advance that fully opaque contents will be drawn into the buffer.

  1. For non-accelerated contexts, if the backing store is flagged as

opaque, faster blitter loop implementations will be used for drawing
the buffer contents into other buffers. (e.g. generated opaque gradient
fills)

No new tests: covered by existing layout tests

  • platform/graphics/Generator.h:

(Generator):
Added hasAlpha method so that it can be used by GeneratorGeneratedImage

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::drawPattern):
Passing m_generator->hasAlpha() to createCompatibleBuffer in order to
take advantage of optimizations that apply to opaque buffers.

  • platform/graphics/Gradient.h:

(Gradient):
Made hasAlpha virtual so that it now overrides Generator::hasAlpha

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::createCompatibleBuffer):
Refactored to use platform-specific implementation

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/ImageBuffer.cpp:

(WebCore::createCompatibleBuffer):
Non-skia implementation. Mimics old
GraphicsContext::createCompatibleBuffer

  • platform/graphics/ImageBuffer.h:

(ImageBuffer):
New skia-specific constructor

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBuffer::createCompatibleBuffer):
(WebCore::ImageBuffer::ImageBuffer):

  • platform/graphics/skia/PlatformContextSkia.cpp:

(WebCore::PlatformContextSkia::createCompatibleDevice):
(WebCore):

  • platform/graphics/skia/PlatformContextSkia.h:

(PlatformContextSkia):

LayoutTests:

Added image failure expectation for test needing new baselines

  • platform/chromium/TestExpectations:
1:38 PM Changeset in webkit [136754] by alexis@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION (r136683): css3/calc/background-position-parsing.html failing on EFL Linux 64-bit Debug WK2
https://bugs.webkit.org/show_bug.cgi?id=104131

Reviewed by Antti Koivisto.

css3/calc/background-position-parsing.html assert in debug because we
call CSSParser::validUnit multiple times in a row. The problem was with
validUnit which check calc() values and save the result inside
m_parsedCalculation for later usage. validUnit expects you to
use m_parsedCalculation therefore calling validUnit again with
m_parsedCalculation being set asserts. As parseFillBackgroundPosition
just want to check wether the current value is maybe valid for
background-position we can just relax the check to allow either the
valid keywords or any other units (we will anyway filter the incorrect
values later in the parsing). The most important check at this point
for the shorthand is the validity of the keyword.

No new tests : the assert was covered by css3/calc/background-position-parsing.html.

  • css/CSSParser.cpp:

(WebCore::CSSParser::isPotentialPositionValue):
(WebCore::CSSParser::parseFillBackgroundPosition):

  • css/CSSParser.h:
1:37 PM Changeset in webkit [136753] by jpetsovits@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Keep screen updates suspended until after a viewport resize.
https://bugs.webkit.org/show_bug.cgi?id=104041

Reviewed by Adam Treat.

Now that screen and backing store updates can be suspended
and resumed separately from each other, prevent blits for
the whole duration of setViewportSize() and always issue
a blit at the end.

Makes WebPage::setViewportSize() more robust in threaded usage,
easier to read/understand, and gets rid of a couple of FIXMEs.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::setViewportSize):

1:30 PM Changeset in webkit [136752] by Lucas Forschler
  • 4 edits in tags/Safari-537.20.3/Source

Versioning.

1:28 PM Changeset in webkit [136751] by Lucas Forschler
  • 1 copy in tags/Safari-537.20.3

New Tag.

1:21 PM Changeset in webkit [136750] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
1:17 PM Changeset in webkit [136749] by senorblanco@chromium.org
  • 6 edits in trunk/Source

Unreviewed, rolling out r136735.
http://trac.webkit.org/changeset/136735
https://bugs.webkit.org/show_bug.cgi?id=102699

Broke Chrome/Win build.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/chromium/ScrollbarThemeChromiumWin.cpp:

(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumWin::paintButton):
(WebCore::ScrollbarThemeChromiumWin::paintThumb):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):
(WebCore::RenderThemeChromiumWin::paintButton):
(WebCore::RenderThemeChromiumWin::paintSliderTrack):
(WebCore::RenderThemeChromiumWin::paintSliderThumb):
(WebCore::RenderThemeChromiumWin::paintMenuList):
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
(WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
(WebCore::RenderThemeChromiumWin::paintProgressBar):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore):
(WebCore::PlatformSupport::paintButton):
(WebCore::PlatformSupport::paintMenuList):
(WebCore::PlatformSupport::paintScrollbarArrow):
(WebCore::PlatformSupport::paintScrollbarThumb):
(WebCore::PlatformSupport::paintScrollbarTrack):
(WebCore::PlatformSupport::paintSpinButton):
(WebCore::PlatformSupport::paintTextField):
(WebCore::PlatformSupport::paintTrackbar):
(WebCore::PlatformSupport::paintProgressBar):

1:16 PM Changeset in webkit [136748] by senorblanco@chromium.org
  • 3 edits
    1 delete in trunk/Source/WebKit/chromium

Unreviewed, rolling out r136741.
http://trac.webkit.org/changeset/136741
https://bugs.webkit.org/show_bug.cgi?id=104151

Broke Chrome/Win build.

  • WebKit.gyp:
  • src/PlatformSupport.cpp:

(WebCore):
(WebCore::WorkerContextProxy::create):

  • src/WorkerContextProxy.cpp: Removed.
1:14 PM Changeset in webkit [136747] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Scroll position shifts while FCC & selection handle are dragged
https://bugs.webkit.org/show_bug.cgi?id=104156

Patch by Andrew Lo <anlo@rim.com> on 2012-12-05
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.

Only ensureFocusTextElementVisible on selectionChanged when
an element is being re-focused.
Internal PR256329

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
(BlackBerry::WebKit::InputHandler::selectionChanged):

  • WebKitSupport/InputHandler.h:

(InputHandler):

1:10 PM Changeset in webkit [136746] by yoli@rim.com
  • 4 edits in trunk

[BlackBerry] Build with libjpegturbo
https://bugs.webkit.org/show_bug.cgi?id=104152

Reviewed by Rob Buis.

.:

RIM PR# 196975.
This change is made by Ming Xie to link with libjpegturbo.

  • Source/cmake/OptionsBlackBerry.cmake:

Tools:

RIM PR# 196975.
Make sure the right include path for libjpeg is included.

  • Scripts/webkitdirs.pm:

(blackberryCMakeArguments):

1:03 PM Changeset in webkit [136745] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

WebGL: use pointer to the source data for Image directly in texImage2D and texSubImage2D to avoid memory copy if no conversion is needed
https://bugs.webkit.org/show_bug.cgi?id=103885

Patch by Jun Jiang <jun.a.jiang@intel.com> on 2012-12-05
Reviewed by Kenneth Russell.

In texImage2D() and texSubImage2D(), there is a redundant memory copy from Image data to the intermediate vector when no conversion is needed. If the Image resource can be locked properly, it is better to use the pointer to the image source directly and hence avoid the memory copy and improve the performance.

Already covered by current tests.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::texImage2DBase):
(WebCore::WebGLRenderingContext::texImage2DImpl):
(WebCore::WebGLRenderingContext::texSubImage2DBase):
(WebCore::WebGLRenderingContext::texSubImage2DImpl):

  • html/canvas/WebGLRenderingContext.h:

(WebGLRenderingContext):

  • platform/graphics/GraphicsContext3D.h:

(ImageExtractor):

1:00 PM Changeset in webkit [136744] by commit-queue@webkit.org
  • 31 edits
    2 adds in trunk/Source/WebCore

Add infrastructure for :before and :after in DOM
https://bugs.webkit.org/show_bug.cgi?id=103705

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-12-05
Reviewed by Eric Seidel.

Add all infrastructure for reimplementing generated content :before and
:after as DOM Elements. Now ElementRareData has two pointers to PseudoElements
for the generated content and Node has methods for traversing the tree
including generated content.

This will allow the generated content to be treated as real nodes instead
of anonymous and take part in the usual recalcStyle and attach flow which
fixes many bugs and vastly simplifies the ifecycle of generated content.

Instead of attempting to land both the infrastructure and enable it at
the same time which has proven problematic due to how drastic this change
is, this patch contains only the support code so a much smaller future
patch can be used to switch it on.

No new behavior, this is just the infrastructure.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/Element.cpp:

(WebCore::Element::~Element):
(WebCore::Element::detach):
(WebCore::Element::updatePseudoElement):
(WebCore::Element::createPseudoElementIfNeeded):
(WebCore::Element::beforePseudoElement):
(WebCore::Element::afterPseudoElement):

  • dom/Element.h:

(Element):

  • dom/ElementRareData.h:

(ElementRareData):
(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::~ElementRareData):
(WebCore::ElementRareData::setPseudoElement):
(WebCore::ElementRareData::pseudoElement):
(WebCore::ElementRareData::releasePseudoElement):

  • dom/Node.cpp:

(WebCore::Node::pseudoAwarePreviousSibling):
(WebCore::Node::pseudoAwareNextSibling):
(WebCore::Node::rendererIsEditable):
(WebCore::checkAcceptChild):

  • dom/Node.h:

(Node):
(WebCore::Node::isPseudoElement):
(WebCore::Node::isBeforePseudoElement):
(WebCore::Node::isAfterPseudoElement):
(WebCore::Node::pseudoId):
(WebCore::Node::customPseudoId):

  • dom/NodeRenderingContext.cpp:

(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):

  • dom/Position.cpp:

(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):

  • dom/PseudoElement.cpp: Added.

(WebCore::pseudoElementTagName):
(WebCore::PseudoElement::PseudoElement):
(WebCore::PseudoElement::customStyleForRenderer):
(WebCore::PseudoElement::attach):
(WebCore::PseudoElement::rendererIsNeeded):
(WebCore::PseudoElement::updateChildStyle):
(WebCore::PseudoElement::didRecalcStyle):

  • dom/PseudoElement.h: Added.

(PseudoElement):
(WebCore::PseudoElement::create):
(WebCore::pseudoElementIsNeeded):

  • editing/visible_units.cpp:

(WebCore::logicallyPreviousBox):
(WebCore::logicallyNextBox):
(WebCore::startPositionForLine):
(WebCore::endPositionForLine):

  • page/animation/AnimationController.cpp:

(WebCore::AnimationController::updateAnimations):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::setInnerNode):
(WebCore::HitTestResult::setInnerNonSharedNode):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::isSelectionRoot):
(WebCore::RenderBlock::renderName):

  • rendering/RenderCounter.cpp:

(WebCore::RenderCounter::originalText):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::renderName):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::renderName):

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::renderName):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::createObject):
(WebCore::RenderObject::setPseudoStyle):
(WebCore::RenderObject::createVisiblePosition):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isPseudoElement):
(RenderObject):
(WebCore::RenderObject::generatingNode):

  • rendering/RenderTableCell.h:

(WebCore::RenderTableCell::renderName):

  • rendering/RenderTableRow.h:

(WebCore::RenderTableRow::renderName):

  • rendering/RenderTableSection.h:

(WebCore::RenderTableSection::renderName):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):

  • rendering/style/ContentData.cpp:

(WebCore::ImageContentData::createRenderer):
(WebCore::TextContentData::createRenderer):
(WebCore::CounterContentData::createRenderer):
(WebCore::QuoteContentData::createRenderer):

12:55 PM Changeset in webkit [136743] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove stale check in check-for-webkit-framework-include-consistency
https://bugs.webkit.org/show_bug.cgi?id=103775

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2012-12-05
Reviewed by David Kilzer.

The underlying issue was fixed in r81173.

  • Scripts/check-for-webkit-framework-include-consistency:
12:53 PM Changeset in webkit [136742] by junov@google.com
  • 2 edits in trunk/Source/WebCore

Use of uninitialized variable in WebCore::RenderBox::paintFillLayers
https://bugs.webkit.org/show_bug.cgi?id=104154

Reviewed by Stephen White.

Method FillLayer::clipOccludesNextLayers performs an internal
initialization when called on the first layer of a list of layers.
Without this initialization, calls to clipOccludesNextLayers on
subsequent layers will use uninitialized data. In some cases, the
call to clipOccludesNextLayers was being short-circuited in
RenderBox::paintFillLayers.
Fix: Predicate was permuted to ensure that clipOccludesNextLayers
is never short-circuited.

Test: fast/backgrounds/size/contain-and-cover-zoomed.html
Running with valgrind reveals the error.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::paintFillLayers):

12:49 PM Changeset in webkit [136741] by pilgrim@chromium.org
  • 3 edits
    1 add in trunk/Source/WebKit/chromium

[Chromium] Move WorkerContextProxy::create out of PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=104151

Reviewed by Adam Barth.

Doesn't really solve the layering violation as much as kick it
down the road a bit. Part of a refactoring series; see tracking
bug 82948.

  • WebKit.gyp:
  • src/PlatformSupport.cpp:

(WebCore):

  • src/WorkerContextProxy.cpp: Added.

(WebCore):
(WebCore::WebCore::WorkerContextProxy::create):

12:47 PM Changeset in webkit [136740] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Chromium] Re-enabling encrypted-media tests now that the issues are fixed.
https://bugs.webkit.org/show_bug.cgi?id=104137

Unreviewed revert of r136312.
The issues were fixed in Chromium r171039 & r171081.

Patch by David Dorwin <ddorwin@chromium.org> on 2012-12-05

  • platform/chromium/TestExpectations:
12:46 PM Changeset in webkit [136739] by inferno@chromium.org
  • 1 edit in branches/chromium/1312/Source/WebKit/chromium/features.gypi

Turn off MATHML for Chromium m24
BUG=164454
Review URL: https://codereview.chromium.org/11437027

12:43 PM Changeset in webkit [136738] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Encapsulate ElementRareData for possible future sharing
https://bugs.webkit.org/show_bug.cgi?id=103948

Patch by Elliott Sprehn <Elliott Sprehn> on 2012-12-05
Reviewed by Eric Seidel.

Encapsulate ElementRareData and make all access go through getters and
setters. This is already true for NodeRareData, but ElementRareData
had many places where people directly access it.

This the first step in possible future sharing of ElementRareData
instances across nodes. All nodes in a shadow tree have rare data to
store the TreeScope, but in most cases all they have is the TreeScope!
Instead of making every node in a shadow subtree have rare data
and use lots of memory we could just share a single instance of rare data
and only allocate a unique one on modification. Encapsulation lets us
assert about mutations on shared instances.

  • dom/Element.cpp:

(WebCore::Element::~Element):
(WebCore::Element::attributes):
(WebCore::Element::shadow):
(WebCore::Element::ensureShadow):
(WebCore::Element::minimumSizeForResizing):
(WebCore::Element::setMinimumSizeForResizing):
(WebCore::Element::computedStyle):
(WebCore::Element::classList):
(WebCore::Element::optionalClassList):
(WebCore::Element::dataset):
(WebCore::Element::hasNamedNodeMap):
(WebCore::Element::savedLayerScrollOffset):
(WebCore::Element::setSavedLayerScrollOffset):

  • dom/ElementRareData.cpp:

(WebCore::ElementRareData::reportMemoryUsage):

  • dom/ElementRareData.h:

(WebCore::ElementRareData::needsFocusAppearanceUpdateSoonAfterAttach):
(WebCore::ElementRareData::setNeedsFocusAppearanceUpdateSoonAfterAttach):
(ElementRareData):
(WebCore::ElementRareData::styleAffectedByEmpty):
(WebCore::ElementRareData::setStyleAffectedByEmpty):
(WebCore::ElementRareData::isInCanvasSubtree):
(WebCore::ElementRareData::setIsInCanvasSubtree):
(WebCore::ElementRareData::containsFullScreenElement):
(WebCore::ElementRareData::setContainsFullScreenElement):
(WebCore::ElementRareData::isInTopLayer):
(WebCore::ElementRareData::setIsInTopLayer):
(WebCore::ElementRareData::childrenAffectedByHover):
(WebCore::ElementRareData::setChildrenAffectedByHover):
(WebCore::ElementRareData::childrenAffectedByActive):
(WebCore::ElementRareData::setChildrenAffectedByActive):
(WebCore::ElementRareData::childrenAffectedByDrag):
(WebCore::ElementRareData::setChildrenAffectedByDrag):
(WebCore::ElementRareData::childrenAffectedByFirstChildRules):
(WebCore::ElementRareData::setChildrenAffectedByFirstChildRules):
(WebCore::ElementRareData::childrenAffectedByLastChildRules):
(WebCore::ElementRareData::setChildrenAffectedByLastChildRules):
(WebCore::ElementRareData::childrenAffectedByDirectAdjacentRules):
(WebCore::ElementRareData::setChildrenAffectedByDirectAdjacentRules):
(WebCore::ElementRareData::childrenAffectedByForwardPositionalRules):
(WebCore::ElementRareData::setChildrenAffectedByForwardPositionalRules):
(WebCore::ElementRareData::childrenAffectedByBackwardPositionalRules):
(WebCore::ElementRareData::setChildrenAffectedByBackwardPositionalRules):
(WebCore::ElementRareData::childIndex):
(WebCore::ElementRareData::setChildIndex):
(WebCore::ElementRareData::shadow):
(WebCore::ElementRareData::setShadow):
(WebCore::ElementRareData::attributeMap):
(WebCore::ElementRareData::setAttributeMap):
(WebCore::ElementRareData::computedStyle):
(WebCore::ElementRareData::setComputedStyle):
(WebCore::ElementRareData::classList):
(WebCore::ElementRareData::setClassList):
(WebCore::ElementRareData::dataset):
(WebCore::ElementRareData::setDataset):
(WebCore::ElementRareData::minimumSizeForResizing):
(WebCore::ElementRareData::setMinimumSizeForResizing):
(WebCore::ElementRareData::savedLayerScrollOffset):
(WebCore::ElementRareData::setSavedLayerScrollOffset):
(WebCore::ElementRareData::resetComputedStyle):

  • dom/NodeRareData.h:

(NodeRareData):

12:39 PM Changeset in webkit [136737] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-2-auth-then-redirect-to-finish.php returns a malformed authentication header
https://bugs.webkit.org/show_bug.cgi?id=104052

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-12-05
Reviewed by Alexey Proskuryakov.

Add an authentication realm to the WWW-Authenticate header of the PHP script. Some networking
libraries do not cope well with WWW-Authenticate headers that do not include realms. Additionally
RFC2617 specifies that this part of the header is not-optional.

This test will be unskipped once the rest of the authentication support is complete in the
libsoup backend and GTK+ DRT/WTR.

  • http/tests/loading/authentication-after-redirect-stores-wrong-credentials/resources/wrong-credential-2-auth-then-redirect-to-finish.php:
12:35 PM Changeset in webkit [136736] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed Windows re-rebaseline.

  • platform/win/fast/text/orientation-sideways-expected.txt:
12:30 PM Changeset in webkit [136735] by pilgrim@chromium.org
  • 6 edits in trunk/Source

[Chromium][Win] Remove theme-related functions from PlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=102699

Reviewed by Adam Barth.

Call theme engine directly instead of going through
PlatformSupport. Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

  • platform/chromium/PlatformSupport.h:

(PlatformSupport):

  • platform/chromium/ScrollbarThemeChromiumWin.cpp:

(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
(WebCore::ScrollbarThemeChromiumWin::paintButton):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):
(WebCore::RenderThemeChromiumWin::paintButton):
(WebCore::RenderThemeChromiumWin::paintSliderTrack):
(WebCore::RenderThemeChromiumWin::paintSliderThumb):
(WebCore::RenderThemeChromiumWin::paintMenuList):
(WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
(WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
(WebCore::RenderThemeChromiumWin::paintProgressBar):

Source/WebKit/chromium:

  • src/PlatformSupport.cpp:

(WebCore::PlatformSupport::pluginScriptableObject):

12:28 PM Changeset in webkit [136734] by senorblanco@chromium.org
  • 9 edits in trunk/Source

Unreviewed, rolling out r136609.
http://trac.webkit.org/changeset/136609
https://bugs.webkit.org/show_bug.cgi?id=103793

Breaking Chrome/Mac Debug builds.

Source/Platform:

  • Platform.gyp/Platform.gyp:
  • chromium/public/WebGraphicsContext3D.h:

(Attributes):

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::create):

  • platform/chromium/support/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3D::create):

  • platform/graphics/GraphicsContext3D.h:

(Attributes):

Source/WebKit/chromium:

  • WebKit.gyp:
12:24 PM Changeset in webkit [136733] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt: simplify the finding of tests to retry
https://bugs.webkit.org/show_bug.cgi?id=104067

Reviewed by Ryosuke Niwa.

I think this makes the code a little clearer; note that
we were no longer using the include_missing flag.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.run):
(Manager._failed_test_names):

12:22 PM Changeset in webkit [136732] by dpranke@chromium.org
  • 3 edits in trunk/Tools

nrwt: remove two unused parameters from a function
https://bugs.webkit.org/show_bug.cgi?id=104059

Reviewed by Ryosuke Niwa.

Also remove an old, stale FIXME.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(interpret_test_failures):
(summarize_results):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ResultSummaryTest.test_interpret_test_failures):

12:19 PM Changeset in webkit [136731] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt: return result_summaries from LayoutTestRunner.run_tests()
https://bugs.webkit.org/show_bug.cgi?id=104051

Reviewed by Ojan Vafai.

This patch completes the refactoring that makes the result summary
an object returned from the layout test runner, rather than having
it passed in and modified. This makes the split of duties between
the manager and runner clearer and makes the data flow more
functionally.

Also clean up some minor lint issues.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner.init):
(LayoutTestRunner.run_tests):
(LayoutTestRunner._mark_interrupted_tests_as_skipped):

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:

(FakePrinter.print_expected):
(LockCheckingRunner.init):
(LayoutTestRunnerTests._runner):
(LayoutTestRunnerTests._run_tests):
(LayoutTestRunnerTests.test_interrupt_if_at_failure_limits):

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.init):
(Manager.run):
(Manager._run_tests):

12:18 PM Changeset in webkit [136730] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt: move creation of the resultsummary objects into Manager._run_tests()
https://bugs.webkit.org/show_bug.cgi?id=104048

Reviewed by Ojan Vafai.

This is a preparatory step to making the resultsummary just get
returned from the layout_test_runner; this does most of manager-side
changes.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._prepare_lists):
(Manager.run):
(Manager._run_tests):

12:17 PM Changeset in webkit [136729] by commit-queue@webkit.org
  • 11 edits
    9 adds in trunk

[CSS Exclusions] Enable shape-inside for multiple-segment polygons
https://bugs.webkit.org/show_bug.cgi?id=91878

Patch by Bear Travis <betravis@adobe.com> on 2012-12-05
Reviewed by David Hyatt.

Source/WebCore:

Patch adding support for multiple-segment polygons for shape-insides from
the CSS Exclusions specification. The layout code has been modified to first
support dividing text into multiple segments per line, and then to lay out
multiple segments per line box.

Tests: fast/exclusions/shape-inside/shape-inside-multiple-segments-001.html

fast/exclusions/shape-inside/shape-inside-multiple-segments-002.html
fast/exclusions/shape-inside/shape-inside-multiple-segments-003.html
fast/exclusions/shape-inside/shape-inside-multiple-segments-004.html

  • platform/text/BidiResolver.h:

(WebCore::BidiCharacterRun::BidiCharacterRun):
(BidiCharacterRun): Added a 'startsSegment' bitfield to track whether a
run begins a new segment. The field is here, rather than in BidiRun, in
order to save space. See Bug 100173.

  • rendering/BidiRun.h:

(WebCore::BidiRun::BidiRun):
(BidiRun): Set the initial value for 'startsSegment'.

  • rendering/ExclusionShapeInsideInfo.cpp:

(WebCore::ExclusionShapeInsideInfo::computeSegmentsForLine): Clear the
segment ranges when computing segments for a new line.

  • rendering/ExclusionShapeInsideInfo.h:

(LineSegmentRange): Added a new type to track segment offsets.
(WebCore::ExclusionShapeInsideInfo::segmentRanges): Added a getter for
the line segment ranges vector.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInInlineDirection): Modified to call
a refactored box placement algorithm that takes a beginning and end position.
(WebCore::InlineFlowBox::placeBoxRangeInInlineDirection): Similar to the
placeBoxes method, but takes an end position that may occur before the end
of the line.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::exclusionShapeInsideInfo): Factored out calls
to ExclusionShapeInsideInfo to the .cpp file, as ExclusionShapeInsideInfo
requires InlineIterator.h, which would create a circular dependency in
ExclusionShapeInsideInfo.h.

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::exclusionShapeInsideInfo): Modified to call
exclusionShapeInsideInfo to be non-inline.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineWidth::LineWidth): LineWidth now uses the number of computed
segmentRanges to determine which LineSegment to use when calculating width.
(WebCore::RenderBlock::createLineBoxes): Now takes a boolean to determine
whether or not it can share the same parentBox as its siblings (segments
must be able to position themselves separately in the RootInlineBox).
(WebCore::RenderBlock::constructLine):
(WebCore::computeExpansionForJustifiedText): Do include runs that start new
segments when calculating justification for the current segment.
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Modified to
use the computeInlineDirectionPositionsForSegment, which can position
multiple segments of text per line.
(WebCore::RenderBlock::computeInlineDirectionPositionsForSegment): Positions
the given segment of text and calculates its layout offsets.
(WebCore::constructBidiRuns): Modified some variables from 'endOfLine' to 'endOfSegment'.
(WebCore::constructBidiRunsForLine): Construct the bidi runs for each segment in
the given line.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Call constructBidiRunsForLine.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Moved the line breaking code
to break segments, with nextLineBreak iterating over segment breaks for the entire line.
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak): Calculates how much text a
segment can hold. This code was originally in nextLineBreak.

LayoutTests:

Adding tests for multiple segment polygons. These tests make sure that text can be
properly broken up into multiple segments per line to fit into a shape-inside.

  • fast/exclusions/shape-inside/shape-inside-multiple-segments-001-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-multiple-segments-001.html: Added.
  • fast/exclusions/shape-inside/shape-inside-multiple-segments-002-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-multiple-segments-002.html: Added.
  • fast/exclusions/shape-inside/shape-inside-multiple-segments-003-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-multiple-segments-003.html: Added.
  • fast/exclusions/shape-inside/shape-inside-multiple-segments-004-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-multiple-segments-004.html: Added.
12:14 PM Changeset in webkit [136728] by senorblanco@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r136630.
http://trac.webkit.org/changeset/136630
https://bugs.webkit.org/show_bug.cgi?id=103555

It's breaking Chrome/Win Debug builds.

  • platform/graphics/chromium/LazyDecodingPixelRef.cpp:

(WebCore::LazyDecodingPixelRef::LazyDecodingPixelRef):

  • platform/graphics/chromium/LazyDecodingPixelRef.h:

(LazyDecodingPixelRef):

12:14 PM DeprecatingFeatures edited by arv@chromium.org
(diff)
12:05 PM Changeset in webkit [136727] by leoyang@rim.com
  • 6 edits in trunk

[BlackBerry] Enable CSS_IMAGE_RESOLUTION
https://bugs.webkit.org/show_bug.cgi?id=104132

Reviewed by Yong Li.

.:

  • Source/cmake/OptionsBlackBerry.cmake:

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
12:04 PM Changeset in webkit [136726] by roger_fong@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed. Re-add Windows specific results removed in r136699 that were actually correct.

  • platform/win/plugins/npp-set-window-called-during-destruction-expected.txt: Added.
11:55 AM Changeset in webkit [136725] by eae@chromium.org
  • 1 edit
    13 adds in trunk/LayoutTests

Unreviewed chromium rebaselines.

  • platform/chromium-linux/css3/filters/effect-reference-hw-expected.png: Added.
  • platform/chromium-linux/plugins/npp-set-window-called-during-destruction-expected.txt: Added.
  • platform/chromium-mac-lion/fast/harness: Added.
  • platform/chromium-mac-lion/fast/harness/perftests: Added.
  • platform/chromium-mac-lion/fast/harness/perftests/runs-per-second-log-expected.png: Added.
  • platform/chromium-mac-lion/fast/harness/perftests/runs-per-second-log-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/harness: Added.
  • platform/chromium-mac-snowleopard/fast/harness/perftests: Added.
  • platform/chromium-mac-snowleopard/fast/harness/perftests/runs-per-second-log-expected.png: Added.
  • platform/chromium-win-xp/plugins/npp-set-window-called-during-destruction-expected.txt: Added.
  • platform/chromium-win/fast/harness/perftests: Added.
  • platform/chromium-win/fast/harness/perftests/runs-per-second-log-expected.png: Added.
  • platform/chromium-win/fast/harness/perftests/runs-per-second-log-expected.txt: Added.
  • platform/chromium/TestExpectations:
11:51 AM Changeset in webkit [136724] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed gardening.

Manage failing fast/media reftests for EFL and Qt.

  • platform/efl-wk2/TestExpectations:
  • platform/qt/TestExpectations:
11:33 AM Changeset in webkit [136723] by zandobersek@gmail.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Adding GTK-specific reference files for two fast/media tests after r136708.
The GTK port isn't yet supporting 3D transforms so these two reference files
should reflect that.

  • platform/gtk/fast/media/mq-transform-02-expected.html: Added.
  • platform/gtk/fast/media/mq-transform-03-expected.html: Added.
11:31 AM Changeset in webkit [136722] by akling@apple.com
  • 8 edits in trunk

REGRESSION(r136615): Incorrect style sharing in view-source documents.
<http://webkit.org/b/104089>

Reviewed by Antti Koivisto.

Source/WebCore:

Make sure we collect feature data about the default view-source style sheet before evaluating
style sharing candidates, otherwise it won't know which class selectors to care about.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::collectFeatures):

LayoutTests:

Unskip: fast/frames/viewsource-attribute.html

fast/frames/viewsource-on-image-file.html

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
11:23 AM Changeset in webkit [136721] by roger_fong@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed rebaseline on Windows after r136640.

  • platform/win/fast/text/orientation-sideways-expected.txt: Added.
11:18 AM Changeset in webkit [136720] by fpizlo@apple.com
  • 10 edits in trunk

JSC profiler should not count executions of op_call_put_result because doing so changes DFG codegen
https://bugs.webkit.org/show_bug.cgi?id=104102

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

This removes op_call_put_result from profiling, since profiling it has an effect on
codegen. This fix enables all of SunSpider, V8, and Kraken to be profiled with the
new profiler.

To make this all fit together, the profiler now also reports in its output the exact
bytecode opcode name for each instruction (in addition to the stringified dump of that
bytecode), so that tools that grok the output can take note of op_call_put_result and
work around the fact that it has no counts.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • profiler/ProfilerBytecode.cpp:

(JSC::Profiler::Bytecode::toJS):

  • profiler/ProfilerBytecode.h:

(JSC::Profiler::Bytecode::Bytecode):
(JSC::Profiler::Bytecode::opcodeID):
(Bytecode):

  • profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::ensureBytecodesFor):

  • runtime/CommonIdentifiers.h:

Tools:

Modify the profiler to not output counts for op_call_put_result, since there
won't be any. Also fix a few weird bugs, like providing better error reporting
when you type something incorrectly and not reporting counts for slow paths
in the old JIT since those counts are actually not what you think they are
(we don't actually count slow path executions separately).

  • Scripts/display-profiler-output:
11:18 AM Changeset in webkit [136719] by mkwst@chromium.org
  • 17 edits in trunk/Source/WebCore

Stop generating call stacks inside ContentSecurityPolicy
https://bugs.webkit.org/show_bug.cgi?id=104126

Reviewed by Yury Semikhatsky.

Now that bug 100650 has made it possible for ConsoleMessage to generate
call stacks, we can remove the stack being generated in
ContentSecurityPolicy::logToConsole. We need the ScriptState*, however,
so this patch makes it possible to pipe it through addConsoleMessage
down into the guts of the inspector.

This patch also removes an unused addConsoleMessage variant from
ScriptExecutionContext, which should have been removed from the patch to
100650 before landing it. My bad.

  • dom/Document.cpp:

(WebCore::Document::addMessage):

  • dom/Document.h:

(Document):

Accept a ScriptState* parameter in Document::addMessage, and pass it
through to Console::addMessage.

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::addConsoleMessage):

  • dom/ScriptExecutionContext.h:

(ScriptExecutionContext):

Accept a ScriptState* parameter in Document::addMessage, and pass it
through to ScriptExecutionContext::addMessage. Also, remove an unused
variant of ScriptExecutionContext::addConsoleMessage that accepted
only a call stack in addition to the basics.

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::ConsoleMessage):

  • inspector/ConsoleMessage.h:

(ConsoleMessage):

Accept a ScriptState* and pass it into autogenerateMetadata for
call stack generational goodness.

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::addMessageToConsole):

Accept a ScriptState* and pass it into addConsoleMessage.

(WebCore::InspectorConsoleAgent::didFinishXHRLoading):
(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):

Add an empty ScriptState parameter to the addConsoleMessage call.

  • inspector/InspectorConsoleAgent.h:

(InspectorConsoleAgent):

  • inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::addMessageToConsole):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

  • page/Console.cpp:

(WebCore::Console::addMessage):

  • page/Console.h:

(Console):

Pipe ScriptState through the intermediate classes.

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::logToConsole):

Drop call stack generation, and pass ScriptState* into addConsoleMessage.

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::addConsoleMessage):
(WebCore::WorkerContext::addMessage):
(WebCore::WorkerContext::addMessageToWorkerConsole):

  • workers/WorkerContext.h:

(WorkerContext):

Accept ScriptState* and pass it into addMessageToConsole.

11:10 AM Changeset in webkit [136718] by zandobersek@gmail.com
  • 1 edit
    557 deletes in trunk/LayoutTests

Unreviewed gardening.

Removing redundant pixel and render tree baselines for fast/media tests.
This is the second and last patch covering non-Chromium ports.

Too many files to list.

11:02 AM Changeset in webkit [136717] by rafaelw@chromium.org
  • 3 edits in trunk/Source/WebCore

DOMImplementation.createDocument should call appendChild rather than parserAppendChild to add docType and documentElement
https://bugs.webkit.org/show_bug.cgi?id=104040

Reviewed by Ojan Vafai.

createDocument now calls appendChild.

No new tests (no observable changes).

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::parserAppendChild):

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createDocument):

11:00 AM Changeset in webkit [136716] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed rebaseline.
https://bugs.webkit.org/show_bug.cgi?id=98209.

  • platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt:
10:59 AM Changeset in webkit [136715] by commit-queue@webkit.org
  • 2 edits in trunk

[CMake] Enable to build WebKit sources without Tools
https://bugs.webkit.org/show_bug.cgi?id=103918

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2012-12-05
Reviewed by Gyuyoung Kim.

Turn on building Tools by default only if ENABLE_TOOLS is not explicitly set
(enabled or disabled) and the Tools directory exists for all CMake based ports.

This change enables the possibility to build WebKit even if the Tools directory
does not exists.

  • CMakeLists.txt:
10:52 AM Changeset in webkit [136714] by alecflett@chromium.org
  • 35 edits in trunk/Source

IndexedDB: Stub out transaction-backend methods
https://bugs.webkit.org/show_bug.cgi?id=103921

Reviewed by Dimitri Glazkov.

Source/WebCore:

In preparation for a refactoring. Legacy methods
will be removed in https://bugs.webkit.org/show_bug.cgi?id=103923.

No new tests, just adding unused methods for refactoring.

  • Modules/indexeddb/IDBCallbacks.h:

(WebCore::IDBCallbacks::onUpgradeNeeded):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::onAbort):
(WebCore):
(WebCore::IDBDatabase::onComplete):

  • Modules/indexeddb/IDBDatabase.h:

(IDBDatabase):

  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::createTransaction):
(WebCore):

  • Modules/indexeddb/IDBDatabaseBackendImpl.h:

(IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::commit):
(WebCore::IDBDatabaseBackendImpl::abort):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h:

(IDBDatabaseBackendInterface):

  • Modules/indexeddb/IDBDatabaseCallbacks.h:

(IDBDatabaseCallbacks):

  • Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp:

(WebCore::IDBDatabaseCallbacksImpl::onAbort):
(WebCore):
(WebCore::IDBDatabaseCallbacksImpl::onComplete):

  • Modules/indexeddb/IDBDatabaseCallbacksImpl.h:

(IDBDatabaseCallbacksImpl):

  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:

(WebCore::IDBFactoryBackendImpl::open):

  • Modules/indexeddb/IDBFactoryBackendImpl.h:

(WebCore::IDBFactoryBackendImpl::open):
(IDBFactoryBackendImpl):

  • Modules/indexeddb/IDBFactoryBackendInterface.h:

(IDBFactoryBackendInterface):

  • Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
(WebCore):

  • Modules/indexeddb/IDBOpenDBRequest.h:

(IDBOpenDBRequest):

  • Modules/indexeddb/IDBTransactionBackendInterface.h:

(WebCore):

  • Modules/indexeddb/IDBTransactionCoordinator.h:

Source/WebKit/chromium:

Add new signatures for refactoring, to allow
transaction_ids to make is through the open/onUpgradeNeeded
loop.

  • public/WebIDBCallbacks.h:

(WebKit::WebIDBCallbacks::onUpgradeNeeded):

  • public/WebIDBDatabase.h:

(WebKit::WebIDBDatabase::createTransaction):
(WebKit::WebIDBDatabase::abort):
(WebKit::WebIDBDatabase::commit):
(WebIDBDatabase):

  • public/WebIDBDatabaseCallbacks.h:

(WebIDBDatabaseCallbacks):
(WebKit::WebIDBDatabaseCallbacks::onAbort):
(WebKit::WebIDBDatabaseCallbacks::onComplete):

  • public/WebIDBFactory.h:

(WebKit::WebIDBFactory::open):

  • src/IDBCallbacksProxy.cpp:

(WebKit::IDBCallbacksProxy::onUpgradeNeeded):
(WebKit):

  • src/IDBCallbacksProxy.h:

(IDBCallbacksProxy):

  • src/IDBDatabaseBackendProxy.cpp:

(WebKit::IDBDatabaseBackendProxy::createTransaction):
(WebKit):
(WebKit::IDBDatabaseBackendProxy::commit):
(WebKit::IDBDatabaseBackendProxy::abort):

  • src/IDBDatabaseBackendProxy.h:

(IDBDatabaseBackendProxy):

  • src/IDBDatabaseCallbacksProxy.cpp:

(WebKit::IDBDatabaseCallbacksProxy::onAbort):
(WebKit):
(WebKit::IDBDatabaseCallbacksProxy::onComplete):

  • src/IDBDatabaseCallbacksProxy.h:

(IDBDatabaseCallbacksProxy):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::open):
(WebKit):

  • src/IDBFactoryBackendProxy.h:

(IDBFactoryBackendProxy):

  • src/WebIDBCallbacksImpl.cpp:

(WebKit::WebIDBCallbacksImpl::onUpgradeNeeded):
(WebKit):

  • src/WebIDBCallbacksImpl.h:

(WebIDBCallbacksImpl):

  • src/WebIDBDatabaseCallbacksImpl.cpp:

(WebKit::WebIDBDatabaseCallbacksImpl::onAbort):
(WebKit):
(WebKit::WebIDBDatabaseCallbacksImpl::onComplete):

  • src/WebIDBDatabaseCallbacksImpl.h:

(WebIDBDatabaseCallbacksImpl):

  • src/WebIDBDatabaseImpl.cpp:

(WebKit::WebIDBDatabaseImpl::createTransaction):
(WebKit):
(WebKit::WebIDBDatabaseImpl::abort):
(WebKit::WebIDBDatabaseImpl::commit):

  • src/WebIDBDatabaseImpl.h:

(WebIDBDatabaseImpl):

  • src/WebIDBFactoryImpl.cpp:

(WebKit::WebIDBFactoryImpl::open):
(WebKit):

  • src/WebIDBFactoryImpl.h:

(WebIDBFactoryImpl):

  • tests/IDBAbortOnCorruptTest.cpp:
  • tests/IDBDatabaseBackendTest.cpp:
10:48 AM Changeset in webkit [136713] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[Qt] REGRESSION: 2 tests started to fail with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=104140

Unreviewed gardening, skip new failing tests to paint the bots green.

  • platform/qt-5.0/TestExpectations:
10:22 AM Changeset in webkit [136712] by robert@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION(r126683): Table cell are getting borders when the style doesn't mention any
https://bugs.webkit.org/show_bug.cgi?id=101677

Reviewed by Julien Chaffraix.

Source/WebCore:

The bordercolor attribute on a cell or row has no effect on FF and Opera, even when the parent
table has a border attribute. IE displays the bordercolor of the cell and row in all cases except when
the parent has no border attribute. WebKit's old behaviour (before r126683) was to display the
bordercolor of the row but not the cells (I don't think this behaviour was particularly deliberate). No
browser displays the bordercolor for a col or tbody element.

Bring WebKit into line with Opera and FF by ignoring the bordercolor attribute on cells, rows, cols, rowgroups, and
colgroups in all cases, regardless of whether the table has a border or not.

Test: fast/table/td-bordercolor-attribute.html

  • html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::isPresentationAttribute):
(WebCore::HTMLTablePartElement::collectStyleForPresentationAttribute):

LayoutTests:

  • fast/table/td-bordercolor-attribute-expected.txt: Added.
  • fast/table/td-bordercolor-attribute.html: Added.
10:07 AM Changeset in webkit [136711] by zandobersek@gmail.com
  • 1 edit
    75 deletes in trunk/LayoutTests

Unreviewed gardening.

Removing redundant pixel and render tree baselines for fast/media tests.
This first patch of a two-part cleanup covers Chromium ports.

Too many files to list.

9:56 AM Changeset in webkit [136710] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL][WK2] Introduce WebKit-EFL to Assistive Technologies
https://bugs.webkit.org/show_bug.cgi?id=104000

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-12-05
Reviewed by Chris Fleizach.

Introduce Webkit-EFL so that Assistive Technologies can distinguish it.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

9:52 AM Changeset in webkit [136709] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove unneeded WTF prefix from WTF types in RenderFlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=104109

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2012-12-05
Reviewed by Eric Seidel.

WTF prefix is not needed because WTF headers have a using
statement at the end of the file.

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::repositionLogicalHeightDependentFlexItems):
(WebCore::RenderFlexibleBox::layoutFlexItems):
(WebCore::RenderFlexibleBox::freezeViolations):
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignFlexLines):
(WebCore::RenderFlexibleBox::alignChildren):
(WebCore::RenderFlexibleBox::flipForWrapReverse):

  • rendering/RenderFlexibleBox.h:
9:51 AM Changeset in webkit [136708] by zandobersek@gmail.com
  • 1 edit
    72 adds
    7 deletes in trunk/LayoutTests

Turn pixel tests in fast/media into reftests
https://bugs.webkit.org/show_bug.cgi?id=103632

Reviewed by Darin Adler.

Turn the pixel tests under fast/media into reftests.
The reference files are tailored so they present the same output
that the pixel baselines. The latter will be removed in two subsequent commits.

  • fast/media/implicit-media-all-expected.html: Added.
  • fast/media/media-descriptor-syntax-01-expected.html: Added.
  • fast/media/media-descriptor-syntax-02-expected.html: Added.
  • fast/media/media-descriptor-syntax-03-expected.html: Added.
  • fast/media/media-descriptor-syntax-04-expected.html: Added.
  • fast/media/media-descriptor-syntax-05-expected.html: Added.
  • fast/media/media-descriptor-syntax-06-expected.html: Added.
  • fast/media/media-query-invalid-value-expected.html: Added.
  • fast/media/media-query-invalid-value-expected.txt: Removed.
  • fast/media/media-type-syntax-01-expected.html: Added.
  • fast/media/media-type-syntax-02-expected.html: Added.
  • fast/media/monochrome-expected.html: Added.
  • fast/media/mq-animation-expected.html: Added.
  • fast/media/mq-aspect-ratio-expected.html: Added.
  • fast/media/mq-compound-query-01-expected.html: Added.
  • fast/media/mq-compound-query-02-expected.html: Added.
  • fast/media/mq-compound-query-03-expected.html: Added.
  • fast/media/mq-compound-query-04-expected.html: Added.
  • fast/media/mq-compound-query-05-expected.html: Added.
  • fast/media/mq-grid-01-expected.html: Added.
  • fast/media/mq-grid-02-expected.html: Added.
  • fast/media/mq-invalid-media-feature-01-expected.html: Added.
  • fast/media/mq-invalid-media-feature-02-expected.html: Added.
  • fast/media/mq-invalid-media-feature-03-expected.html: Added.
  • fast/media/mq-invalid-media-feature-04-expected.html: Added.
  • fast/media/mq-invalid-syntax-01-expected.html: Added.
  • fast/media/mq-invalid-syntax-02-expected.html: Added.
  • fast/media/mq-invalid-syntax-03-expected.html: Added.
  • fast/media/mq-invalid-syntax-04-expected.html: Added.
  • fast/media/mq-invalid-syntax-05-expected.html: Added.
  • fast/media/mq-js-media-except-01-expected.html: Added.
  • fast/media/mq-js-media-except-01-expected.txt: Removed.
  • fast/media/mq-js-media-except-02-expected.html: Added.
  • fast/media/mq-js-media-except-02-expected.txt: Removed.
  • fast/media/mq-js-media-except-03-expected.html: Added.
  • fast/media/mq-js-media-except-03-expected.txt: Removed.
  • fast/media/mq-js-media-forward-syntax-expected.html: Added.
  • fast/media/mq-js-stylesheet-media-01-expected.html: Added.
  • fast/media/mq-js-stylesheet-media-02-expected.html: Added.
  • fast/media/mq-js-stylesheet-media-03-expected.html: Added.
  • fast/media/mq-js-stylesheet-media-04-expected.html: Added.
  • fast/media/mq-max-pixel-ratio-expected.html: Added.
  • fast/media/mq-min-constraint-expected.html: Added.
  • fast/media/mq-min-pixel-ratio-expected.html: Added.
  • fast/media/mq-min-pixel-ratio-expected.txt: Removed.
  • fast/media/mq-orientation-expected.html: Added.
  • fast/media/mq-pixel-ratio-expected.html: Added.
  • fast/media/mq-relative-constraints-02-expected.html: Added.
  • fast/media/mq-relative-constraints-03-expected.html: Added.
  • fast/media/mq-relative-constraints-04-expected.html: Added.
  • fast/media/mq-relative-constraints-05-expected.html: Added.
  • fast/media/mq-relative-constraints-06-expected.html: Added.
  • fast/media/mq-relative-constraints-07-expected.html: Added.
  • fast/media/mq-relative-constraints-08-expected.html: Added.
  • fast/media/mq-relative-constraints-08-expected.txt: Removed.
  • fast/media/mq-relative-constraints-09-expected.html: Added.
  • fast/media/mq-simple-neg-query-01-expected.html: Added.
  • fast/media/mq-simple-neg-query-02-expected.html: Added.
  • fast/media/mq-simple-neg-query-03-expected.html: Added.
  • fast/media/mq-simple-neg-query-04-expected.html: Added.
  • fast/media/mq-simple-neg-query-05-expected.html: Added.
  • fast/media/mq-simple-query-01-expected.html: Added.
  • fast/media/mq-simple-query-02-expected.html: Added.
  • fast/media/mq-simple-query-03-expected.html: Added.
  • fast/media/mq-simple-query-04-expected.html: Added.
  • fast/media/mq-simple-query-05-expected.html: Added.
  • fast/media/mq-transform-01-expected.html: Added.
  • fast/media/mq-transform-02-expected.html: Added.
  • fast/media/mq-transform-03-expected.html: Added.
  • fast/media/mq-transform-04-expected.html: Added.
  • fast/media/mq-transition-expected.html: Added.
  • fast/media/mq-valueless-expected.html: Added.
  • fast/media/mq-width-absolute-01-expected.html: Added.
  • fast/media/mq-width-absolute-02-expected.html: Added.
  • fast/media/mq-width-absolute-03-expected.html: Added.
  • fast/media/mq-width-absolute-04-expected.html: Added.
  • fast/media/view-mode-media-feature-expected.html: Added.
  • fast/media/view-mode-media-feature-expected.txt: Removed.
  • fast/media/viewport-media-query-expected.html: Added.
  • platform/gtk/fast/media/mq-transform-02-expected.html: Added as 3D transforms support

isn't yet enabled on the GTK port.

  • platform/gtk/fast/media/mq-transform-03-expected.html: Ditto.
9:48 AM Changeset in webkit [136707] by Csaba Osztrogonác
  • 7 edits in trunk

Fix compilation for Qt5.0.0 stable branch.
https://bugs.webkit.org/show_bug.cgi?id=103870

Source/WebCore:

Patch by Andras Becsi <andras.becsi@digia.com> on 2012-12-05
Reviewed by Simon Hausmann.

This is a squashed patch consisting of patches by multiple authors.

Fixed use of to-be-removed compatibility functions in QWindow
Patch by Samuel Rødal <samuel.rodal@digia.com>

Build fix. No new tests needed.

  • platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:

(FullScreenVideoWindow::FullScreenVideoWindow):
(PlatformVideoWindow::PlatformVideoWindow):

Source/WebKit2:

Patch by Michael Brüning <michael.bruning@digia.com> on 2012-12-05
Reviewed by Simon Hausmann.

QWindow::pos() and QQuickItem::pos() have been renamed to position().
Patch by Lars Knoll <lars.knoll@digia.com>

  • UIProcess/qt/PageViewportControllerClientQt.cpp:

(WebKit::PageViewportControllerClientQt::setContentRectVisiblePositionAtScale):
(WebKit::PageViewportControllerClientQt::setViewportPosition):

Tools:

Patch by Andras Becsi <andras.becsi@digia.com> on 2012-12-05
Reviewed by Simon Hausmann.

Fix the use of renamed QWindow functions.
Patch by Andras Becsi <andras.becsi@digia.com>

  • MiniBrowser/qt/BrowserWindow.cpp:

(BrowserWindow::BrowserWindow):
(BrowserWindow::onTitleChanged):

  • MiniBrowser/qt/raw/View.cpp:

(View::View):

9:45 AM Changeset in webkit [136706] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: more robust treeoutline.findTreeElement
https://bugs.webkit.org/show_bug.cgi?id=103911

Patch by John J. Barton <johnjbarton@chromium.org> on 2012-12-05
Reviewed by Vsevolod Vlasov.

Non-recursive algorithm to populate the treeoutline given an DOMNode
as representedObject. Walk up the parents from the desired object
until we find one that is currently represented in the treeoutline
cache. Then walk down, putting children in the cache until we get
to the desired object again.
With Pavel Feldeman <pfeldman@chromium.org>

No new tests, refactoring, no new function

  • inspector/front-end/treeoutline.js:

(TreeOutline.prototype.findTreeElement):

9:44 AM Changeset in webkit [136705] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

[EFL][GTK] List value response headers are not handled in RespourceResponse (libsoup specific)
https://bugs.webkit.org/show_bug.cgi?id=95181

Patch by Alexander Shalamov <alexander.shalamov@intel.com> on 2012-12-05
Reviewed by Martin Robinson.

Source/WebCore:

When list-value response headers are received, they are handled as single
value headers. This patch fixes incorrect behavior. New test was added to
verify list-value header handling.

Test: http/tests/xmlhttprequest/xmlhttprequest-test-custom-headers.html

  • platform/network/soup/ResourceResponseSoup.cpp:

(WebCore::ResourceResponse::updateFromSoupMessage):

LayoutTests:

Added test that checks if list-value response headers handled correctly.

  • http/tests/xmlhttprequest/resources/custom-headers.php: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-test-custom-headers-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-test-custom-headers.html: Added.
9:42 AM Changeset in webkit [136704] by commit-queue@webkit.org
  • 2 edits
    3 adds in trunk/LayoutTests

[EFL][WK2] Introduce WebKit-EFL to Assistive Technologies - new baselines
https://bugs.webkit.org/show_bug.cgi?id=104000

Patch by Krzysztof Czech <k.czech@samsung.com> on 2012-12-05
Reviewed by Chris Fleizach.

Added EFL baselines for accessibility/table-cells.html and accessibility/table-cell-spans.html.

  • platform/efl-wk2/TestExpectations:
  • platform/efl-wk2/accessibility/table-cell-spans-expected.txt: Added.
  • platform/efl-wk2/accessibility/table-cells-expected.txt: Added.
9:41 AM Changeset in webkit [136703] by pfeldman@chromium.org
  • 4 edits
    2 adds in trunk

Web Inspector: Don't include error message text in the editor buffer.
https://bugs.webkit.org/show_bug.cgi?id=103932

Reviewed by Alexander Pavlov.

Source/WebCore:

Skip entire decoration content when collecting dirty regions.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._collectLinesFromDOM):

LayoutTests:

  • inspector/editor/editor-test.js:

(initialize_EditorTests.InspectorTest.getLineElement):
(initialize_EditorTests):

  • inspector/editor/text-editor-type-over-decoration-expected.txt: Added.
  • inspector/editor/text-editor-type-over-decoration.html: Added.
9:34 AM Changeset in webkit [136702] by yoli@rim.com
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/watchlist

Unreviewed, adding my new email address to watchlist for blackberry.

  • Scripts/webkitpy/common/config/watchlist:
9:26 AM Changeset in webkit [136701] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Skipping back the Media Stream layout tests, they're not behaving well.
Removing a few failure expectations for tests that are passing.

  • platform/gtk/TestExpectations:
9:25 AM Changeset in webkit [136700] by zhajiang@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] meta viewport pages are rendered at a bad initial scale
https://bugs.webkit.org/show_bug.cgi?id=104122

Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.

PR: 240378
Many websites are rendered at a very bad initial scale because they
both specify meta viewport tag and have large width elements. In such
a case we will think the meta viewport tag is broken if the width of
any element is larger than the calculated layout viewport width.
The fix to this is straightforward that we will zoom the page to fit
the screen to have better user experience instead of respecting the
meta viewport. This can fix the issue on the websites such as
www.travelpod.com, www.forbes.com, interfacelift.com, www.sky.com,
raphaeljs.com and so on.
If non-empty m_userViewportArguments is applied, then we will force to
respect the viewport arguments. In this way we will restrict the fix to
browser only.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::setLoadState):
(BlackBerry::WebKit::WebPagePrivate::respectViewport):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::initialScale):
(BlackBerry::WebKit::WebPagePrivate::maximumScale):
(BlackBerry::WebKit::WebPagePrivate::dispatchViewportPropertiesDidChange):

  • Api/WebPage_p.h:

(BlackBerry::WebKit::WebPagePrivate::isUserScalable):
(WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::minimumScale):

9:22 AM Changeset in webkit [136699] by eae@chromium.org
  • 3 edits
    5 adds
    2 deletes in trunk/LayoutTests

Unreviewed chromium rebaselines.

  • platform/chromium-mac/plugins/npp-set-window-called-during-destruction-expected.txt: Added.
  • platform/chromium-win-xp/css3/flexbox: Added.
  • platform/chromium-win-xp/css3/flexbox/repaint-column-reverse-expected.png: Added.
  • platform/chromium-win/css3/filters/effect-reference-hw-expected.png:
  • platform/chromium-win/plugins/npp-set-window-called-during-destruction-expected.txt:
  • platform/chromium/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
  • platform/win-7sp0/plugins: Added.
  • platform/win-7sp0/plugins/npp-set-window-called-during-destruction-expected.txt: Added.
  • platform/win/plugins/npp-set-window-called-during-destruction-expected.txt: Removed.
9:20 AM Changeset in webkit [136698] by thiago.santos@intel.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed gardening.

  • platform/efl-wk2/TestExpectations:
9:09 AM Changeset in webkit [136697] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

[Gtk] navigator.plugins contains too many plugin entries. First one are garbages
https://bugs.webkit.org/show_bug.cgi?id=102438

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-12-05
Reviewed by Xan Lopez.

Source/WebKit/gtk:

In getPluginInfo, outPlugins is resized to plugins.size and then,
plugins are appended to it. So at the end, outPlugins will be twice
too large, and first half will contain null objects. As outPlugins
size is 0 when calling getPluginInfo, we don't need to resize it.

  • WebCoreSupport/PlatformStrategiesGtk.cpp:

(PlatformStrategiesGtk::getPluginInfo):

LayoutTests:

Add a test to check that navigator.plugins only contain valid plugin
objects.

  • plugins/navigator-plugins-expected.txt: Added.
  • plugins/navigator-plugins.html: Added.
  • plugins/script-tests/navigator-plugins.js: Added.
9:06 AM Changeset in webkit [136696] by jsbell@chromium.org
  • 25 edits in trunk/Source

IndexedDB: Replace use of ScriptExecutionContext::Task (Part 2)
https://bugs.webkit.org/show_bug.cgi?id=103931

Reviewed by Tony Chang.

Source/WebCore:

Actually drop use of ScriptExecutionContext::Task and remove incorrect usage of
ThreadSafeRefCounted<>. Define a new IDBTransactionBackendImpl::Operation base class
for operations; storage of per-operation data becomes explicit.

No new tests - just a refactor.

  • Modules/indexeddb/IDBCallbacks.h: Remove bogus "ThreadSafe"
  • Modules/indexeddb/IDBCursorBackendImpl.cpp:

(WebCore::IDBCursorBackendImpl::CursorIterationOperation::create):
(IDBCursorBackendImpl::CursorIterationOperation):
(WebCore::IDBCursorBackendImpl::CursorIterationOperation::CursorIterationOperation):
(WebCore::IDBCursorBackendImpl::CursorAdvanceOperation::create):
(IDBCursorBackendImpl::CursorAdvanceOperation):
(WebCore::IDBCursorBackendImpl::CursorAdvanceOperation::CursorAdvanceOperation):
(WebCore::IDBCursorBackendImpl::CursorPrefetchIterationOperation::create):
(IDBCursorBackendImpl::CursorPrefetchIterationOperation):
(WebCore::IDBCursorBackendImpl::CursorPrefetchIterationOperation::CursorPrefetchIterationOperation):
(WebCore::IDBCursorBackendImpl::CursorAdvanceOperation::perform):
(WebCore::IDBCursorBackendImpl::CursorIterationOperation::perform):
(WebCore::IDBCursorBackendImpl::CursorPrefetchIterationOperation::perform):

  • Modules/indexeddb/IDBCursorBackendInterface.h: Remove bogus "ThreadSafe"
  • Modules/indexeddb/IDBDatabase.cpp:
  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:

(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreOperation::create):
(IDBDatabaseBackendImpl::CreateObjectStoreOperation):
(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreOperation::CreateObjectStoreOperation):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreOperation::create):
(IDBDatabaseBackendImpl::DeleteObjectStoreOperation):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreOperation::DeleteObjectStoreOperation):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::create):
(IDBDatabaseBackendImpl::VersionChangeOperation):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::VersionChangeOperation):
(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreAbortOperation::create):
(IDBDatabaseBackendImpl::CreateObjectStoreAbortOperation):
(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreAbortOperation::CreateObjectStoreAbortOperation):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreAbortOperation::create):
(IDBDatabaseBackendImpl::DeleteObjectStoreAbortOperation):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreAbortOperation::DeleteObjectStoreAbortOperation):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::create):
(IDBDatabaseBackendImpl::VersionChangeAbortOperation):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::VersionChangeAbortOperation):
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
(WebCore::IDBDatabaseBackendImpl::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackendImpl::CreateObjectStoreAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreAbortOperation::perform):
(WebCore::IDBDatabaseBackendImpl::VersionChangeAbortOperation::perform):

  • Modules/indexeddb/IDBDatabaseBackendInterface.h: Remove bogus "ThreadSafe"
  • Modules/indexeddb/IDBDatabaseCallbacks.h: Remove bogus "ThreadSafe"
  • Modules/indexeddb/IDBFactoryBackendImpl.cpp:
  • Modules/indexeddb/IDBFactoryBackendInterface.h: Remove bogus "ThreadSafe"
  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::OpenIndexCursorOperation::create):
(IDBIndexBackendImpl::OpenIndexCursorOperation):
(WebCore::IDBIndexBackendImpl::OpenIndexCursorOperation::OpenIndexCursorOperation):
(WebCore::IDBIndexBackendImpl::IndexCountOperation::create):
(IDBIndexBackendImpl::IndexCountOperation):
(WebCore::IDBIndexBackendImpl::IndexCountOperation::IndexCountOperation):
(WebCore::IDBIndexBackendImpl::IndexReferencedValueRetrievalOperation::create):
(IDBIndexBackendImpl::IndexReferencedValueRetrievalOperation):
(WebCore::IDBIndexBackendImpl::IndexReferencedValueRetrievalOperation::IndexReferencedValueRetrievalOperation):
(WebCore::IDBIndexBackendImpl::IndexValueRetrievalOperation::create):
(IDBIndexBackendImpl::IndexValueRetrievalOperation):
(WebCore::IDBIndexBackendImpl::IndexValueRetrievalOperation::IndexValueRetrievalOperation):
(WebCore::IDBIndexBackendImpl::OpenIndexCursorOperation::perform):
(WebCore::IDBIndexBackendImpl::openCursor):
(WebCore::IDBIndexBackendImpl::openKeyCursor):
(WebCore::IDBIndexBackendImpl::IndexCountOperation::perform):
(WebCore::IDBIndexBackendImpl::count):
(WebCore::IDBIndexBackendImpl::IndexReferencedValueRetrievalOperation::perform):
(WebCore::IDBIndexBackendImpl::IndexValueRetrievalOperation::perform):
(WebCore::IDBIndexBackendImpl::get):
(WebCore::IDBIndexBackendImpl::getKey):

  • Modules/indexeddb/IDBIndexBackendInterface.h: Remove bogus "ThreadSafe"
  • Modules/indexeddb/IDBKey.h: Remove bogus "ThreadSafe"

(IDBKey):

  • Modules/indexeddb/IDBKeyRange.h: Remove bogus "ThreadSafe"
  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::ObjectStoreRetrievalOperation::create):
(IDBObjectStoreBackendImpl::ObjectStoreRetrievalOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreRetrievalOperation::ObjectStoreRetrievalOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreStorageOperation::create):
(IDBObjectStoreBackendImpl::ObjectStoreStorageOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreStorageOperation::ObjectStoreStorageOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreIndexesReadyOperation::create):
(IDBObjectStoreBackendImpl::ObjectStoreIndexesReadyOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreIndexesReadyOperation::ObjectStoreIndexesReadyOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreDeletionOperation::create):
(IDBObjectStoreBackendImpl::ObjectStoreDeletionOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreDeletionOperation::ObjectStoreDeletionOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreClearOperation::create):
(IDBObjectStoreBackendImpl::ObjectStoreClearOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreClearOperation::ObjectStoreClearOperation):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexOperation::create):
(IDBObjectStoreBackendImpl::CreateIndexOperation):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexOperation::CreateIndexOperation):
(WebCore::IDBObjectStoreBackendImpl::DeleteIndexOperation::create):
(IDBObjectStoreBackendImpl::DeleteIndexOperation):
(WebCore::IDBObjectStoreBackendImpl::DeleteIndexOperation::DeleteIndexOperation):
(WebCore::IDBObjectStoreBackendImpl::OpenObjectStoreCursorOperation::create):
(IDBObjectStoreBackendImpl::OpenObjectStoreCursorOperation):
(WebCore::IDBObjectStoreBackendImpl::OpenObjectStoreCursorOperation::OpenObjectStoreCursorOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreCountOperation::create):
(IDBObjectStoreBackendImpl::ObjectStoreCountOperation):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreCountOperation::ObjectStoreCountOperation):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexAbortOperation::create):
(IDBObjectStoreBackendImpl::CreateIndexAbortOperation):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexAbortOperation::CreateIndexAbortOperation):
(WebCore::IDBObjectStoreBackendImpl::DeleteIndexAbortOperation::create):
(IDBObjectStoreBackendImpl::DeleteIndexAbortOperation):
(WebCore::IDBObjectStoreBackendImpl::DeleteIndexAbortOperation::DeleteIndexAbortOperation):
(WebCore::IDBObjectStoreBackendImpl::get):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreRetrievalOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::put):
(WebCore):
(WebCore::IDBObjectStoreBackendImpl::setIndexesReady):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreIndexesReadyOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreStorageOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::deleteFunction):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreDeletionOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::clear):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreClearOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::createIndex):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::deleteIndex):
(WebCore::IDBObjectStoreBackendImpl::DeleteIndexOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::openCursor):
(WebCore::IDBObjectStoreBackendImpl::OpenObjectStoreCursorOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::count):
(WebCore::IDBObjectStoreBackendImpl::ObjectStoreCountOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::CreateIndexAbortOperation::perform):
(WebCore::IDBObjectStoreBackendImpl::DeleteIndexAbortOperation::perform):

  • Modules/indexeddb/IDBObjectStoreBackendInterface.h: Remove bogus "ThreadSafe"
  • Modules/indexeddb/IDBRequest.h: Remove bogus "ThreadSafe"

(IDBRequest):

  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:

(WebCore::IDBTransactionBackendImpl::IDBTransactionBackendImpl): Appease RefPtr<> adoption strictness.
(WebCore::IDBTransactionBackendImpl::scheduleTask):
(WebCore::IDBTransactionBackendImpl::abort):
(WebCore::IDBTransactionBackendImpl::taskTimerFired):

  • Modules/indexeddb/IDBTransactionBackendImpl.h:

(Operation):
(WebCore::IDBTransactionBackendImpl::Operation::~Operation):
(IDBTransactionBackendImpl):
(WebCore::IDBTransactionBackendImpl::scheduleTask):

  • Modules/indexeddb/IDBTransactionBackendInterface.h: Remove bogus "ThreadSafe"

Source/WebKit/chromium:

Now that IDBCallbacks uses real RefPtr<> a mock class needs to be heap allocated.

  • tests/IDBAbortOnCorruptTest.cpp:

(WebCore::MockIDBCallbacks::create):
(WebCore::MockIDBCallbacks::MockIDBCallbacks):
(MockIDBCallbacks):
(WebCore::TEST):

9:06 AM Changeset in webkit [136695] by jonlee@apple.com
  • 2 edits in trunk/Source/WTF

Extend StringHasher to take a stream of characters
https://bugs.webkit.org/show_bug.cgi?id=104076
<rdar://problem/12811887>

Reviewed by Darin Adler.

We essentially move computeHash() to a member function of StringHasher. This allows clients of the
hasher to append strings to the general hash, without having to first concatenate the strings.

  • wtf/StringHasher.h:

(WTF::StringHasher::addCharacters): Same as computeHash(), except also take into account the possibility
that there is a pending character to hash. If this is the case, we align the word boundary by consuming the
first character in data, adjust the length, move the data pointer forward one, and update the hasher's
pending character state. Also add an early return so that we are guaranteed at least one character in case
we run into this situation.
(WTF::StringHasher::computeHash): Refactor into addCharacters().

8:48 AM Changeset in webkit [136694] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] GeolocationClientBB only holding the latest geolocation permission request
https://bugs.webkit.org/show_bug.cgi?id=104123

PR 256089

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-12-05
Reviewed by Yong Li.

Add a mapping between origin URL and it's geolocation object so we could
respond to the correct geolocation when libwebview responds with onPermission
in GeolocationClient.

Using the mapping, we could also prevent requestGeolocation requests from the same origin
to be sent twice. This prevents pages that hold two iframes to the same resource to request
geolocation permission on the same security origin twice.

Tested this by running a page that includes 2 or more iframes that requests geolocation
permission.

  • WebCoreSupport/GeolocationClientBlackBerry.cpp:

(GeolocationClientBlackBerry::requestPermission):
(GeolocationClientBlackBerry::cancelPermissionRequest):
(GeolocationClientBlackBerry::onPermission):

  • WebCoreSupport/GeolocationClientBlackBerry.h:

(GeolocationClientBlackBerry):

8:36 AM Changeset in webkit [136693] by noel.gordon@gmail.com
  • 3 edits in trunk/Source/WebCore

ENABLE(IMAGE_DECODER_DOWN_SAMPLING): Don't swizzle decode down sampled images
https://bugs.webkit.org/show_bug.cgi?id=103856

Reviewed by Yong Li.

For ports using ENABLE(IMAGE_DECODER_DOWN_SAMPLING), turbo swizzle decodes provide
no speed-up when the decoded image will be down sampled because the data must pass
through the buffer.setRGBA() slow path. That is not the swizzled path. Instead use
JCS_RGB decodes to clarify the output color space handling in outputScanlines().

No new tests. Covered by existing JPEG decoding tests.

  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

(WebCore::JPEGImageReader::decode): libjpeg-turbo swizzle decodes provides no real
speed-up if the image will be down sampled. Revert to using JCS_RGA in this case.
(WebCore::setPixel): Remove the libjpeg-turbo JCS_EXT_BGRA and JCS_EXT_RGBA cases.
(WebCore::JPEGImageDecoder::outputScanlines): ditto.

  • platform/image-decoders/jpeg/JPEGImageDecoder.h:

(WebCore::JPEGImageDecoder::willDownSample): Return true if image down sampling
will be applied to the decoded image (m_scaled). Note: the willDownSample() return
value is valid only after setSize() has been called: add an ASSERT for that.

8:27 AM Changeset in webkit [136692] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Moving some expectations for expected failures under the appropriate section.

Rather than skipping expected failures, they should be run (as long as they
don't time out in great numbers) just to get the extra test coverage (mostly
to confirm they don't crash unexpectably). Most of such expectations are being
unskipped and changed into a proper failure expectation, but more can folllow.

  • platform/gtk/TestExpectations:
8:10 AM Changeset in webkit [136691] by Christophe Dumez
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] EWK2UnitTestBase.ewk_favicon_database_async_icon_get is crashing with new Ewk_Context
https://bugs.webkit.org/show_bug.cgi?id=104110

Reviewed by Laszlo Gombos.

Unregister the WKFaviconDatabase client in EwkFaviconDatabase
destructor to avoid crashing if the callbacks get called
after the EwkFaviconDatabase object has been destroyed (i.e.
the parent EwkContext object was destroyed).

  • UIProcess/API/efl/ewk_favicon_database.cpp:

(EwkFaviconDatabase::~EwkFaviconDatabase):

7:57 AM Changeset in webkit [136690] by senorblanco@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

  • platform/chromium/TestExpectations:
7:52 AM Changeset in webkit [136689] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Avoid showing FCC on empty text field in a different way
https://bugs.webkit.org/show_bug.cgi?id=104019

Patch by Yongxin Dai <yodai@rim.com> on 2012-12-05
Reviewed by Rob Buis.

PR #222796

Add text field empty flag along with the caret change notification so that
FineCursorContnrol is able to avoid showing FCC on empty text filed.
Previous approach, notifying client with empty caret on empty text field,
causes problem. Its code is removed.

Reviewed Internally by Mike Fenton.

  • Api/WebPageClient.h:
  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::caretPositionChanged):

7:51 AM Changeset in webkit [136688] by zandobersek@gmail.com
  • 2 edits
    5 deletes in trunk/LayoutTests

Unreviewed GTK gardening, updating baselines after r136657 and r136672.

  • platform/gtk/http/tests/inspector/console-websocket-error-expected.txt:
  • platform/gtk/http/tests/xmlhttprequest/access-control-preflight-async-header-denied-expected.txt: Removed.
  • platform/gtk/http/tests/xmlhttprequest/access-control-preflight-async-method-denied-expected.txt: Removed.
  • platform/gtk/http/tests/xmlhttprequest/access-control-preflight-async-not-supported-expected.txt: Removed.
  • platform/gtk/http/tests/xmlhttprequest/origin-whitelisting-https-expected.txt: Removed.
  • platform/gtk/http/tests/xmlhttprequest/simple-cross-origin-denied-events-expected.txt: Removed.
7:43 AM Changeset in webkit [136687] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk

Tools: [WK2] InjectedBundle should check Intent url for null
https://bugs.webkit.org/show_bug.cgi?id=104117

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-12-05
Reviewed by Kenneth Rohde Christiansen.

WKIntentServiceInfoCopyHref() can return null, we need to check
for that in InjectedBundlePage::registerIntentServiceForFrame()
to avoid crashing.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::registerIntentServiceForFrame):

LayoutTests: [EFL] InjectedBundle should check Intent url for null
https://bugs.webkit.org/show_bug.cgi?id=104117

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-12-05
Reviewed by Kenneth Rohde Christiansen.

EFL is slightly more verbose than chromium on this one.

  • platform/efl/fast/images/crossfade-client-not-removed-crash-expected.txt: Added.
7:37 AM Changeset in webkit [136686] by commit-queue@webkit.org
  • 11 edits
    1 add
    1 delete in trunk/Source/WebCore

IndexedDB: Implement IndexedDB bindings for JSC
https://bugs.webkit.org/show_bug.cgi?id=103484

Patch by Michael Pruett <michael@68k.org> on 2012-12-05
Reviewed by Kentaro Hara.

IndexedDB is currently implemented only for V8. This change adds
the bindings necessary for IndexedDB to work with JSC. With this
patch, IndexedDB for JSC passes 112 out of the 196 layout tests in
storage/indexeddb. IndexedDB is still not enabled for any JSC port.

Tests: storage/indexeddb/*

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/indexeddb/IDBOpenDBRequest.idl:
  • Modules/indexeddb/IDBVersionChangeRequest.idl:
  • UseJSC.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/DOMRequestState.h: Added to match bindings/v8/DOMRequestState.h.

(WebCore):
(DOMRequestState):
(WebCore::DOMRequestState::DOMRequestState):
(WebCore::DOMRequestState::clear):
(Scope):
(WebCore::DOMRequestState::Scope::Scope):
(WebCore::DOMRequestState::exec):

  • bindings/js/IDBBindingUtilities.cpp: Add utility functions matching those in bindings/v8/IDBBindingUtilities.cpp.

(WebCore::get):
(WebCore):
(WebCore::canSet):
(WebCore::set):
(WebCore::createIDBKeyFromValue):
(WebCore::getNthValueOnKeyPath):
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::ensureNthValueOnKeyPath):
(WebCore::canInjectNthValueOnKeyPath):
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::canInjectIDBKeyIntoScriptValue):
(WebCore::deserializeIDBValue):
(WebCore::idbKeyToScriptValue):

  • bindings/js/IDBBindingUtilities.h: Add utility functions matching those in bindings/v8/IDBBindingUtilities.h.

(WebCore):

  • bindings/js/JSIDBAnyCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSIDBKeyCustom.cpp:

(WebCore::toJS):

  • bindings/js/JSIDBVersionChangeRequestCustom.cpp: Removed.
7:31 AM Changeset in webkit [136685] by zeno.albisser@digia.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt][Mac] QWebView disappears when the system tries to hide the scrollbars.
https://bugs.webkit.org/show_bug.cgi?id=104116

This is a workaround for an issue in Qt that was
caused by Change-Id: I2000fa50d46b153e981ceafc12a53932a196382e
in qtbase.
Since we are drawing the scrollbars by ourselves, there is no
widget available that needs to be hidden by the style.
Therefore we have to disable transient scrollbar
animations on Mac.

Patch by: J-P Nurmi <jpnurmi@digia.com>

Reviewed by Simon Hausmann.

  • WidgetSupport/QStyleFacadeImp.cpp:

(WebKit::QStyleFacadeImp::paintScrollBar):

7:25 AM Changeset in webkit [136684] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

TextTrackCue's .endTime property should fire a TypeError when NaN is assigned
https://bugs.webkit.org/show_bug.cgi?id=103413

Patch by Antoine Quint <Antoine Quint> on 2012-12-05
Reviewed by Eric Carlson.

Source/WebCore:

Check whether the new time passed to setStartTime() and setEndTime() is none of NaN or Infinity,
otherwise throwing a TypeError.

Thanks to this fix, we're no longer skipping media/track/opera/interfaces/TextTrackCue/endTime.html and
media/track/opera/interfaces/TextTrackCue/startTime.html.

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::setStartTime):
(WebCore::TextTrackCue::setEndTime):

  • html/track/TextTrackCue.h:

(TextTrackCue):

  • html/track/TextTrackCue.idl:

LayoutTests:

Stop skipping two tests that now have new passing conditions, only held back from
passing altogether by https://bugs.webkit.org/show_bug.cgi?id=103258.

  • media/track/opera/interfaces/TextTrackCue/endTime-expected.txt: Added.
  • media/track/opera/interfaces/TextTrackCue/startTime-expected.txt: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
7:10 AM Changeset in webkit [136683] by alexis@webkit.org
  • 6 edits in trunk

[CSS3 Backgrounds and Borders] Allow the CSS3 background position offset for background shorthand.
https://bugs.webkit.org/show_bug.cgi?id=104014

Reviewed by Dirk Schulze.

Source/WebCore:

Add the support of the new <position> type if set from within the
background shorthand. The patch just modify the way we count the values
of the current context by checking wether we encounter a comma (it is
then the next background layer), or if we encounter a '/' (which is in the
background shorthand context the background-size) or any value that is
not a valid background-position keyword or length (which means we are
already parsing the next property of the background shorthand).

Tests: LayoutTests/fast/backgrounds/background-position-parsing-2.html
has been modified to cover this use case.

  • css/CSSParser.cpp:

(WebCore::CSSParser::isPositionValue):
(WebCore):
(WebCore::CSSParser::parseFillBackgroundPosition):
(WebCore::CSSParser::parseFillProperty):

  • css/CSSParser.h:

LayoutTests:

Extend the current parsing tests of background-position to cover the
case when it is set part of the background shorthand.

  • fast/backgrounds/background-position-parsing-2-expected.txt:
  • fast/backgrounds/background-position-parsing-2.html:
6:30 AM Changeset in webkit [136682] by keishi@webkit.org
  • 10 edits in trunk/LayoutTests

[Chromium] Rebaseline suggestion picker tests because of CSS change in r136674

Unreviewed.

  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/date-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/month-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/week-suggestion-picker-appearance-rtl-expected.png:
6:22 AM Changeset in webkit [136681] by keishi@webkit.org
  • 2 edits in trunk/LayoutTests

Marking *-suggestion-picker-appearance-locale-hebrew.html tests as Missing

Unreviewed.

  • platform/chromium/TestExpectations:
6:05 AM Changeset in webkit [136680] by kkristof@inf.u-szeged.hu
  • 4 edits
    3 deletes in trunk/LayoutTests

[Qt] Unreviewed gardening.

Revert some update of r136670, and update the generic expecteds.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-12-05

  • fast/media/mq-resolution-dpi-dpcm-warning-expected.txt:
  • fast/media/mq-resolution-expected.txt:
  • fast/media/w3c/test_media_queries-expected.txt:
  • platform/qt/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Removed.
  • platform/qt/fast/media/mq-resolution-expected.txt: Removed.
  • platform/qt/fast/media/w3c/test_media_queries-expected.txt: Removed.
5:55 AM Changeset in webkit [136679] by thiago.santos@intel.com
  • 1 edit
    3 moves
    1 add
    233 deletes in trunk/LayoutTests

[EFL] Unreviewed gardening.

Removed duplicated test expectations.

  • platform/efl-wk1/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Removed.
  • platform/efl-wk1/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Removed.
  • platform/efl-wk1/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Removed.
  • platform/efl-wk1/compositing/repaint/composited-document-element-expected.png: Removed.
  • platform/efl-wk1/dom/xhtml/level3/core/documentnormalizedocument10-expected.txt: Removed.
  • platform/efl-wk1/fast/dom/DOMException/prototype-object-expected.txt: Removed.
  • platform/efl-wk1/fast/dom/DOMException/stack-trace-expected.txt: Removed.
  • platform/efl-wk1/mathml/presentation/roots-expected.txt: Removed.
  • platform/efl-wk1/mathml/presentation/row-alignment-expected.txt: Removed.
  • platform/efl-wk1/mathml/presentation/sub-expected.txt: Removed.
  • platform/efl-wk1/mathml/presentation/subsup-expected.txt: Removed.
  • platform/efl-wk1/media/video-aspect-ratio-expected.png: Removed.
  • platform/efl-wk1/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Removed.
  • platform/efl-wk2/dom/xhtml/level3/core/documentnormalizedocument10-expected.txt: Removed.
  • platform/efl-wk2/fast/dom/DOMException/prototype-object-expected.txt: Removed.
  • platform/efl-wk2/fast/dom/DOMException/stack-trace-expected.txt: Removed.
  • platform/efl-wk2/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Removed.
  • platform/efl-wk2/fast/media/mq-resolution-expected.txt: Removed.
  • platform/efl-wk2/fast/media/w3c/test_media_queries-expected.txt: Removed.
  • platform/efl-wk2/http/tests/loading/text-content-type-with-binary-extension-expected.txt: Removed.
  • platform/efl/fast/canvas/fillText-shadow-expected.txt: Removed.
  • platform/efl/fast/dom/HTMLInputElement/input-slider-update-styled-expected.txt: Removed.
  • platform/efl/fast/forms/005-expected.png: Removed.
  • platform/efl/fast/forms/range/range-thumb-height-percentage-expected.txt: Removed.
  • platform/efl/fast/forms/range/slider-thumb-stylability-expected.txt: Removed.
  • platform/efl/fast/images/exif-orientation-image-document-expected.txt: Removed.
  • platform/efl/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Renamed from LayoutTests/platform/efl-wk1/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt.
  • platform/efl/fast/media/mq-resolution-expected.txt: Renamed from LayoutTests/platform/efl-wk1/fast/media/mq-resolution-expected.txt.
  • platform/efl/fast/media/w3c/test_media_queries-expected.txt: Renamed from LayoutTests/platform/efl-wk1/fast/media/w3c/test_media_queries-expected.txt.
  • platform/efl/fast/multicol/overflow-across-columns-expected.png: Removed.
  • platform/efl/fast/multicol/overflow-across-columns-percent-height-expected.png: Removed.
  • platform/efl/fast/regions/absolute-pos-elem-in-named-flow-expected.txt: Removed.
  • platform/efl/fast/regions/autowidth-attachedinvalidregion-expected.txt: Removed.
  • platform/efl/fast/regions/bottom-overflow-out-of-first-region-expected.png: Removed.
  • platform/efl/fast/regions/content-flowed-into-regions-no-scroll-expected.txt: Removed.
  • platform/efl/fast/regions/content-webkit-from-flow-parsing-expected.txt: Removed.
  • platform/efl/fast/regions/element-region-overset-state-expected.txt: Removed.
  • platform/efl/fast/regions/element-region-overset-state-negative-letter-spacing-expected.txt: Removed.
  • platform/efl/fast/regions/element-region-overset-state-vertical-rl-expected.txt: Removed.
  • platform/efl/fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing-expected.txt: Removed.
  • platform/efl/fast/regions/fixed-pos-elem-in-named-flow-expected.txt: Removed.
  • platform/efl/fast/regions/fixed-pos-elem-in-named-flow2-expected.txt: Removed.
  • platform/efl/fast/regions/flexbox-in-region-crash-expected.txt: Removed.
  • platform/efl/fast/regions/flow-anonymous-children-expected.txt: Removed.
  • platform/efl/fast/regions/flow-region-into-itself-crash-expected.txt: Removed.
  • platform/efl/fast/regions/flowed-content-bounding-client-rect-expected.txt: Removed.
  • platform/efl/fast/regions/flowed-content-bounding-client-rect-horizontal-bt-expected.txt: Removed.
  • platform/efl/fast/regions/flowed-content-bounding-client-rect-vertical-expected.txt: Removed.
  • platform/efl/fast/regions/flowed-content-bounding-client-rect-vertical-rl-expected.txt: Removed.
  • platform/efl/fast/regions/flowed-content-transform-bounding-client-rect-expected.txt: Removed.
  • platform/efl/fast/regions/get-region-flow-ranges-absolute-pos-expected.txt: Removed.
  • platform/efl/fast/regions/get-region-flow-ranges-content-nodes-expected.txt: Removed.
  • platform/efl/fast/regions/get-region-flow-ranges-display-none-expected.txt: Removed.
  • platform/efl/fast/regions/get-region-flow-ranges-empty-regions-expected.txt: Removed.
  • platform/efl/fast/regions/get-region-flow-ranges-expected.txt: Removed.
  • platform/efl/fast/regions/get-region-flow-ranges-fixed-pos-expected.txt: Removed.
  • platform/efl/fast/regions/get-region-flow-ranges-horiz-bt-expected.txt: Removed.
  • platform/efl/fast/regions/get-region-flow-ranges-inline-only-expected.txt: Removed.
  • platform/efl/fast/regions/get-region-flow-ranges-text-expected.txt: Removed.
  • platform/efl/fast/regions/get-region-flow-ranges-text-vert-lr-expected.txt: Removed.
  • platform/efl/fast/regions/get-region-flow-ranges-vert-lr-expected.txt: Removed.
  • platform/efl/fast/regions/get-region-flow-ranges-vert-rl-expected.txt: Removed.
  • platform/efl/fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr-expected.txt: Removed.
  • platform/efl/fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr-expected.txt: Removed.
  • platform/efl/fast/regions/get-regions-by-content-expected.txt: Removed.
  • platform/efl/fast/regions/get-regions-by-content-horiz-bt-expected.txt: Removed.
  • platform/efl/fast/regions/get-regions-by-content-horiz-tb-expected.txt: Removed.
  • platform/efl/fast/regions/get-regions-by-content-vert-lr-expected.txt: Removed.
  • platform/efl/fast/regions/get-regions-by-content-vert-rl-expected.txt: Removed.
  • platform/efl/fast/regions/get-regions-by-content2-expected.txt: Removed.
  • platform/efl/fast/regions/hit-test-float-expected.txt: Removed.
  • platform/efl/fast/regions/hit-test-region-expected.txt: Removed.
  • platform/efl/fast/regions/imbricated-flow-threads-crash-expected.txt: Removed.
  • platform/efl/fast/regions/move-anonymous-block-inside-named-flow-crash-expected.txt: Removed.
  • platform/efl/fast/regions/moved-content-node-crash-expected.txt: Removed.
  • platform/efl/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/no-split-line-box-expected.txt: Removed.
  • platform/efl/fast/regions/overflow-in-uniform-regions-dynamic-expected.png: Removed.
  • platform/efl/fast/regions/overflow-in-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/overflow-rtl-in-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.png: Removed.
  • platform/efl/fast/regions/parse-incomplete-region-rule-expected.txt: Removed.
  • platform/efl/fast/regions/parsing-region-style-rule-expected.txt: Removed.
  • platform/efl/fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.png: Removed.
  • platform/efl/fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.png: Removed.
  • platform/efl/fast/regions/percentage-margins-rtl-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/percentage-margins-variable-width-regions-expected.png: Removed.
  • platform/efl/fast/regions/positioned-vrl-in-named-flow-expected.txt: Removed.
  • platform/efl/fast/regions/positioned-vrl-in-parent-named-flow-expected.txt: Removed.
  • platform/efl/fast/regions/positioned-with-vrl-parent-in-named-flow-expected.txt: Removed.
  • platform/efl/fast/regions/region-attached-wrong-flow-crash-expected.txt: Removed.
  • platform/efl/fast/regions/region-element-display-change-expected.txt: Removed.
  • platform/efl/fast/regions/region-element-display-restriction-expected.txt: Removed.
  • platform/efl/fast/regions/region-element-dynamic-attach-flow-expected.txt: Removed.
  • platform/efl/fast/regions/region-element-dynamic-detach-flow-expected.txt: Removed.
  • platform/efl/fast/regions/region-flow-reattach-crash-expected.txt: Removed.
  • platform/efl/fast/regions/region-range-for-box-crash-expected.txt: Removed.
  • platform/efl/fast/regions/remove-flow-thread-crash-expected.txt: Removed.
  • platform/efl/fast/regions/removed-element-style-in-region-crash-expected.txt: Removed.
  • platform/efl/fast/regions/select-in-region-crash-expected.txt: Removed.
  • platform/efl/fast/regions/set-box-style-in-region-crash-expected.txt: Removed.
  • platform/efl/fast/regions/svg-root-element-collected-expected.txt: Removed.
  • platform/efl/fast/regions/symbol-in-named-flow-crash-expected.txt: Removed.
  • platform/efl/fast/regions/text-region-breaks-expected.txt: Removed.
  • platform/efl/fast/regions/text-region-split-after-resize-expected.txt: Removed.
  • platform/efl/fast/regions/text-region-split-expected.txt: Removed.
  • platform/efl/fast/regions/text-region-split-horizontal-bt-expected.txt: Removed.
  • platform/efl/fast/regions/text-region-split-vertical-expected.txt: Removed.
  • platform/efl/fast/regions/text-region-split-vertical-rl-expected.txt: Removed.
  • platform/efl/fast/regions/top-overflow-out-of-second-region-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.png: Removed.
  • platform/efl/fast/regions/webkit-flow-parsing-expected.txt: Removed.
  • platform/efl/fast/regions/webkit-region-overflow-parsing-expected.txt: Removed.
  • platform/efl/fast/regions/webkit-region-rule-expected.txt: Removed.
  • platform/efl/fast/repaint/background-generated-expected.png: Removed.
  • platform/efl/fast/repaint/line-flow-with-floats-1-expected.png: Removed.
  • platform/efl/fast/repaint/line-flow-with-floats-10-expected.png: Removed.
  • platform/efl/fast/repaint/line-flow-with-floats-2-expected.png: Removed.
  • platform/efl/fast/repaint/line-flow-with-floats-3-expected.png: Removed.
  • platform/efl/fast/repaint/line-flow-with-floats-4-expected.png: Removed.
  • platform/efl/fast/repaint/line-flow-with-floats-5-expected.png: Removed.
  • platform/efl/fast/repaint/line-flow-with-floats-6-expected.png: Removed.
  • platform/efl/fast/repaint/line-flow-with-floats-7-expected.png: Removed.
  • platform/efl/fast/repaint/line-flow-with-floats-8-expected.png: Removed.
  • platform/efl/fast/repaint/line-flow-with-floats-9-expected.png: Removed.
  • platform/efl/fast/repaint/slider-thumb-float-expected.txt: Removed.
  • platform/efl/fast/selectors/unqualified-hover-strict-expected.txt: Removed.
  • platform/efl/fast/table/025-expected.png: Removed.
  • platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt: Removed.
  • platform/efl/fast/text/international/bidi-listbox-expected.txt: Removed.
  • platform/efl/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Removed.
  • platform/efl/fast/text/international/bidi-override-expected.txt: Removed.
  • platform/efl/svg/clip-path/clip-in-mask-objectBoundingBox-expected.png: Removed.
  • platform/efl/svg/clip-path/clip-in-mask-userSpaceOnUse-expected.png: Removed.
  • platform/efl/svg/css/path-gradient-stroke-shadow-expected.txt: Removed.
  • platform/efl/svg/dom/css-transforms-expected.txt: Removed.
  • platform/efl/svg/text/font-size-below-point-five-2-expected.png: Removed.
  • platform/efl/svg/text/scaled-font-expected.png: Removed.
  • platform/efl/svg/text/text-hkern-expected.png: Removed.
  • platform/efl/svg/text/text-vkern-on-horizontal-text-expected.png: Removed.
  • platform/efl/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Removed.
  • platform/efl/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug1055-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug10565-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug10633-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug106816-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug11026-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug113235-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug113235-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug113424-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug120107-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug126742-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug1271-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug12908-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug12908-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug1296-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug13118-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug13169-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug139524-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug1430-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug154780-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug15544-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug159108-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug17130-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug17130-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug17138-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug19061-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug19061-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug196870-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug215629-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug26553-expected.png: Removed.
  • platform/efl/tables/mozilla/bugs/bug26553-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug27038-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug27038-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug2886-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug29314-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug2981-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug3309-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug3309-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug33137-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug4093-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug42187-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug4284-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug46480-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug46480-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug50695-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug5538-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug56563-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug5797-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug625-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug67915-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug69187-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug7112-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug7112-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug8032-1-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug82946-2-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug83786-expected.txt: Removed.
  • platform/efl/tables/mozilla/bugs/bug9024-expected.txt: Removed.
  • platform/efl/tables/mozilla/core/bloomberg-expected.txt: Removed.
  • platform/efl/tables/mozilla/core/col_widths_auto_autoFix-expected.txt: Removed.
  • platform/efl/tables/mozilla/core/misc-expected.txt: Removed.
  • platform/efl/tables/mozilla/core/row_span-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/backgr_index-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/td_valign_baseline-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/td_valign_bottom-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/td_valign_middle-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/td_valign_top-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/th_valign_baseline-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/th_valign_bottom-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/th_valign_middle-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/th_valign_top-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/thead_valign_top-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/tr_valign_baseline-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/tr_valign_bottom-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/tr_valign_middle-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/tr_valign_top-expected.txt: Removed.
  • platform/efl/tables/mozilla/marvin/x_table_align_center-expected.txt: Removed.
  • platform/efl/tables/mozilla/other/cell_widths-expected.txt: Removed.
  • platform/efl/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt: Removed.
5:49 AM Changeset in webkit [136678] by kkristof@inf.u-szeged.hu
  • 2 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening.

Skip a test and update an other one.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-12-05

  • platform/qt/TestExpectations:
  • platform/qt/fast/images/crossfade-client-not-removed-crash-expected.txt: Added.
5:42 AM Changeset in webkit [136677] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
5:27 AM Changeset in webkit [136676] by senorblanco@chromium.org
  • 306 edits
    7 copies
    31 moves
    21 adds
    5 deletes in trunk/LayoutTests

[chromium] New baselines after http://webkit.org/b/103906. Unreviewed.

  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png: Copied from LayoutTests/platform/chromium-linux/compositing/shadows/shadow-drawing-expected.png.
  • platform/chromium-linux/compositing/geometry/clipping-foreground-expected.png:
  • platform/chromium-linux/compositing/iframes/composited-iframe-alignment-expected.png:
  • platform/chromium-linux/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-linux/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-linux/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-linux/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-linux/fast/box-shadow/box-shadow-clipped-slices-expected.png:
  • platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-linux/fast/box-shadow/inset-expected.png:
  • platform/chromium-linux/fast/box-shadow/shadow-tiling-artifact-expected.png:
  • platform/chromium-linux/fast/css/background-clip-radius-values-expected.png:
  • platform/chromium-linux/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-linux/fast/css/color-correction-on-box-shadow-expected.png:
  • platform/chromium-linux/fast/css/color-correction-on-text-shadow-expected.png:
  • platform/chromium-linux/fast/css/shadow-multiple-expected.png:
  • platform/chromium-linux/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-linux/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-linux/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-linux/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-linux/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-linux/fast/text/shadow-translucent-fill-expected.png:
  • platform/chromium-linux/fast/text/stroking-decorations-expected.png:
  • platform/chromium-linux/fast/text/stroking-expected.png:
  • platform/chromium-linux/fast/transforms/shadows-expected.png:
  • platform/chromium-linux/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-linux/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/chromium-linux/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/chromium-linux/fast/writing-mode/english-lr-text-expected.png:
  • platform/chromium-linux/ietestcenter/css3/text/textshadow-001-expected.png:
  • platform/chromium-linux/ietestcenter/css3/text/textshadow-002-expected.png:
  • platform/chromium-linux/ietestcenter/css3/text/textshadow-003-expected.png:
  • platform/chromium-linux/ietestcenter/css3/text/textshadow-004-expected.png:
  • platform/chromium-linux/ietestcenter/css3/text/textshadow-010-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/geometry/clipping-foreground-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/iframes/composited-iframe-alignment-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-linux/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/chromium-linux/svg/css/stars-with-shadow-expected.png:
  • platform/chromium-linux/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-linux/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-linux/transitions/svg-text-shadow-transition-expected.png:
  • platform/chromium-mac-lion/compositing/geometry/clipping-foreground-expected.png:
  • platform/chromium-mac-lion/compositing/iframes/composited-iframe-alignment-expected.png:
  • platform/chromium-mac-lion/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-mac-lion/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-mac-lion/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-mac-lion/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-mac-lion/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac-lion/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/chromium-mac-lion/fast/box-shadow/inset-expected.png:
  • platform/chromium-mac-lion/fast/css/color-correction-on-box-shadow-expected.png:
  • platform/chromium-mac-lion/fast/css/color-correction-on-text-shadow-expected.png:
  • platform/chromium-mac-lion/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac-lion/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-lion/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-mac-lion/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-mac-lion/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-mac-lion/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-mac-lion/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-mac-lion/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac-lion/fast/text/shadow-translucent-fill-expected.png:
  • platform/chromium-mac-lion/fast/text/stroking-decorations-expected.png:
  • platform/chromium-mac-lion/fast/text/stroking-expected.png:
  • platform/chromium-mac-lion/fast/transforms/shadows-expected.png:
  • platform/chromium-mac-lion/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-mac-lion/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/chromium-mac-lion/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/chromium-mac-lion/fast/writing-mode/english-lr-text-expected.png:
  • platform/chromium-mac-lion/ietestcenter/css3/text/textshadow-001-expected.png:
  • platform/chromium-mac-lion/ietestcenter/css3/text/textshadow-002-expected.png:
  • platform/chromium-mac-lion/ietestcenter/css3/text/textshadow-003-expected.png:
  • platform/chromium-mac-lion/ietestcenter/css3/text/textshadow-004-expected.png:
  • platform/chromium-mac-lion/ietestcenter/css3/text/textshadow-010-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/clipping-foreground-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-mac-lion/svg/css/stars-with-shadow-expected.png:
  • platform/chromium-mac-lion/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-mac-lion/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-mac-lion/svg/custom/repaint-shadow-expected.png:
  • platform/chromium-mac-lion/transitions/svg-text-shadow-transition-expected.png:
  • platform/chromium-mac-snowleopard/compositing/geometry/clipping-foreground-expected.png:
  • platform/chromium-mac-snowleopard/compositing/iframes/composited-iframe-alignment-expected.png:
  • platform/chromium-mac-snowleopard/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-mac-snowleopard/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-mac-snowleopard/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-mac-snowleopard/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/color-correction-on-box-shadow-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/color-correction-on-text-shadow-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac-snowleopard/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-mac-snowleopard/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-mac-snowleopard/fast/text/shadow-translucent-fill-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/chromium-mac-snowleopard/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-001-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-002-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-003-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-004-expected.png:
  • platform/chromium-mac-snowleopard/ietestcenter/css3/text/textshadow-010-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/clipping-foreground-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-mac-snowleopard/svg/css/stars-with-shadow-expected.png:
  • platform/chromium-mac-snowleopard/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-mac-snowleopard/transitions/svg-text-shadow-transition-expected.png:
  • platform/chromium-mac/compositing/culling/scrolled-within-boxshadow-expected.png: Added.
  • platform/chromium-mac/compositing/culling/translated-boxshadow-expected.png: Added.
  • platform/chromium-mac/compositing/culling/unscrolled-within-boxshadow-expected.png: Added.
  • platform/chromium-mac/compositing/geometry/clipping-foreground-expected.png:
  • platform/chromium-mac/compositing/geometry/foreground-layer-expected.png:
  • platform/chromium-mac/compositing/iframes/composited-iframe-alignment-expected.png:
  • platform/chromium-mac/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-mac/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-mac/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png:
  • platform/chromium-mac/fast/box-shadow/box-shadow-radius-expected.png:
  • platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/chromium-mac/fast/box-shadow/inset-box-shadow-radius-expected.png:
  • platform/chromium-mac/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-mac/fast/box-shadow/inset-expected.png:
  • platform/chromium-mac/fast/box-shadow/scaled-box-shadow-expected.png:
  • platform/chromium-mac/fast/box-shadow/shadow-buffer-partial-expected.png:
  • platform/chromium-mac/fast/box-shadow/shadow-tiling-artifact-expected.png:
  • platform/chromium-mac/fast/box-shadow/single-pixel-shadow-expected.png:
  • platform/chromium-mac/fast/canvas/fillText-shadow-expected.txt: Removed.
  • platform/chromium-mac/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-mac/fast/css/color-correction-on-box-shadow-expected.png:
  • platform/chromium-mac/fast/css/color-correction-on-text-shadow-expected.png:
  • platform/chromium-mac/fast/css/shadow-multiple-expected.png:
  • platform/chromium-mac/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-mac/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-mac/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-mac/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-mac/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-mac/fast/repaint/transform-replaced-shadows-expected.png:
  • platform/chromium-mac/fast/text/shadow-translucent-fill-expected.png:
  • platform/chromium-mac/fast/text/stroking-decorations-expected.png:
  • platform/chromium-mac/fast/text/stroking-expected.png:
  • platform/chromium-mac/fast/transforms/shadows-expected.png:
  • platform/chromium-mac/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-mac/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/chromium-mac/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/chromium-mac/fast/writing-mode/english-lr-text-expected.png:
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-001-expected.png:
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-002-expected.png:
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-003-expected.png:
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-004-expected.png:
  • platform/chromium-mac/ietestcenter/css3/text/textshadow-010-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/culling/scrolled-within-boxshadow-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/culling/translated-boxshadow-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/culling/unscrolled-within-boxshadow-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/clipping-foreground-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/foreground-layer-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/iframes/composited-iframe-alignment-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-mac/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/chromium-mac/svg/css/path-with-shadow-expected.png:
  • platform/chromium-mac/svg/css/shadow-and-opacity-expected.png:
  • platform/chromium-mac/svg/css/shadow-with-large-radius-expected.png:
  • platform/chromium-mac/svg/css/shadow-with-negative-offset-expected.png:
  • platform/chromium-mac/svg/css/stars-with-shadow-expected.png:
  • platform/chromium-mac/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-mac/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-mac/svg/custom/repaint-shadow-expected.png:
  • platform/chromium-mac/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/chromium-mac/transitions/svg-text-shadow-transition-expected.png:
  • platform/chromium-win-xp/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-win-xp/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-win-xp/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-win-xp/fast/text/stroking-decorations-expected.png:
  • platform/chromium-win-xp/fast/text/stroking-expected.png:
  • platform/chromium-win-xp/fast/writing-mode/english-lr-text-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png: Removed.
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-win/compositing/culling/scrolled-within-boxshadow-expected.png: Copied from LayoutTests/platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png.
  • platform/chromium-win/compositing/culling/translated-boxshadow-expected.png: Copied from LayoutTests/platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png.
  • platform/chromium-win/compositing/culling/unscrolled-within-boxshadow-expected.png: Copied from LayoutTests/platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png.
  • platform/chromium-win/compositing/geometry/clipping-foreground-expected.png:
  • platform/chromium-win/compositing/geometry/foreground-layer-expected.png:
  • platform/chromium-win/compositing/iframes/composited-iframe-alignment-expected.png:
  • platform/chromium-win/compositing/masks/masked-ancestor-expected.png:
  • platform/chromium-win/compositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-win/fast/borders/border-radius-constraints-expected.png:
  • platform/chromium-win/fast/borders/border-radius-split-inline-expected.png:
  • platform/chromium-win/fast/borders/mixed-border-styles-radius-expected.png:
  • platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
  • platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
  • platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
  • platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-box-shadow-radius-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-box-shadows-expected.png:
  • platform/chromium-win/fast/box-shadow/inset-expected.png:
  • platform/chromium-win/fast/box-shadow/scaled-box-shadow-expected.png:
  • platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png:
  • platform/chromium-win/fast/box-shadow/shadow-tiling-artifact-expected.png:
  • platform/chromium-win/fast/box-shadow/single-pixel-shadow-expected.png:
  • platform/chromium-win/fast/css/box-shadow-and-border-radius-expected.png:
  • platform/chromium-win/fast/css/color-correction-on-box-shadow-expected.png:
  • platform/chromium-win/fast/css/color-correction-on-text-shadow-expected.png:
  • platform/chromium-win/fast/css/shadow-multiple-expected.png:
  • platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
  • platform/chromium-win/fast/multicol/shadow-breaking-expected.png:
  • platform/chromium-win/fast/repaint/box-shadow-h-expected.png:
  • platform/chromium-win/fast/repaint/box-shadow-v-expected.png:
  • platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
  • platform/chromium-win/fast/repaint/shadow-multiple-vertical-expected.png:
  • platform/chromium-win/fast/repaint/transform-replaced-shadows-expected.png:
  • platform/chromium-win/fast/text/shadow-translucent-fill-expected.png:
  • platform/chromium-win/fast/text/stroking-decorations-expected.png:
  • platform/chromium-win/fast/text/stroking-expected.png:
  • platform/chromium-win/fast/transforms/shadows-expected.png:
  • platform/chromium-win/fast/writing-mode/box-shadow-horizontal-bt-expected.png:
  • platform/chromium-win/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/chromium-win/fast/writing-mode/box-shadow-vertical-rl-expected.png:
  • platform/chromium-win/fast/writing-mode/english-lr-text-expected.png:
  • platform/chromium-win/ietestcenter/css3/text/textshadow-001-expected.png:
  • platform/chromium-win/ietestcenter/css3/text/textshadow-002-expected.png:
  • platform/chromium-win/ietestcenter/css3/text/textshadow-003-expected.png:
  • platform/chromium-win/ietestcenter/css3/text/textshadow-004-expected.png:
  • platform/chromium-win/ietestcenter/css3/text/textshadow-010-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/month-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/week-picker-appearance-step-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-two-row-appearance-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-with-scrollbar-appearance-expected.png:
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/culling/scrolled-within-boxshadow-expected.png: Copied from LayoutTests/platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/culling/translated-boxshadow-expected.png: Copied from LayoutTests/platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/culling/unscrolled-within-boxshadow-expected.png: Copied from LayoutTests/platform/chromium-win/platform/chromium/fast/forms/color/color-suggestion-picker-one-row-appearance-expected.png.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/clipping-foreground-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/geometry/foreground-layer-expected.png: Added.
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/iframes/composited-iframe-alignment-expected.png:
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/masks/masked-ancestor-expected.png:
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
  • platform/chromium-win/svg/css/circle-in-mask-with-shadow-expected.png:
  • platform/chromium-win/svg/css/path-with-shadow-expected.png:
  • platform/chromium-win/svg/css/shadow-and-opacity-expected.png:
  • platform/chromium-win/svg/css/shadow-with-large-radius-expected.png:
  • platform/chromium-win/svg/css/shadow-with-negative-offset-expected.png:
  • platform/chromium-win/svg/css/stars-with-shadow-expected.png:
  • platform/chromium-win/svg/css/text-gradient-shadow-expected.png:
  • platform/chromium-win/svg/css/text-shadow-multiple-expected.png:
  • platform/chromium-win/svg/custom/repaint-shadow-expected.png:
  • platform/chromium-win/svg/filters/shadow-on-rect-with-filter-expected.png:
  • platform/chromium-win/transitions/svg-text-shadow-transition-expected.png:
  • platform/chromium/TestExpectations:
  • platform/efl-wk1/compositing/geometry/clipping-foreground-expected.png: Renamed from LayoutTests/platform/efl/compositing/geometry/clipping-foreground-expected.png.
  • platform/efl-wk1/compositing/geometry/foreground-layer-expected.png: Renamed from LayoutTests/platform/efl/compositing/geometry/foreground-layer-expected.png.
  • platform/efl-wk1/fast/borders/border-radius-constraints-expected.png: Renamed from LayoutTests/platform/efl/fast/borders/border-radius-constraints-expected.png.
  • platform/efl-wk1/fast/borders/border-radius-split-inline-expected.png: Renamed from LayoutTests/platform/efl/fast/borders/border-radius-split-inline-expected.png.
  • platform/efl-wk1/fast/borders/mixed-border-styles-radius-expected.png: Renamed from LayoutTests/platform/efl/fast/borders/mixed-border-styles-radius-expected.png.
  • platform/efl-wk1/fast/box-shadow/inset-box-shadows-expected.png: Renamed from LayoutTests/platform/efl/fast/box-shadow/inset-box-shadows-expected.png.
  • platform/efl-wk1/fast/box-shadow/inset-expected.png: Renamed from LayoutTests/platform/efl/fast/box-shadow/inset-expected.png.
  • platform/efl-wk1/fast/css/box-shadow-and-border-radius-expected.png: Renamed from LayoutTests/platform/efl/fast/css/box-shadow-and-border-radius-expected.png.
  • platform/efl-wk1/fast/css/shadow-multiple-expected.png: Renamed from LayoutTests/platform/efl/fast/css/shadow-multiple-expected.png.
  • platform/efl-wk1/fast/multicol/shadow-breaking-expected.png: Renamed from LayoutTests/platform/efl/fast/multicol/shadow-breaking-expected.png.
  • platform/efl-wk1/fast/repaint/moving-shadow-on-path-expected.png: Renamed from LayoutTests/platform/efl/fast/repaint/moving-shadow-on-path-expected.png.
  • platform/efl-wk1/fast/text/shadow-translucent-fill-expected.png: Renamed from LayoutTests/platform/efl/fast/text/shadow-translucent-fill-expected.png.
  • platform/efl-wk1/fast/text/stroking-decorations-expected.png: Renamed from LayoutTests/platform/efl/fast/text/stroking-decorations-expected.png.
  • platform/efl-wk1/fast/text/stroking-expected.png: Renamed from LayoutTests/platform/efl/fast/text/stroking-expected.png.
  • platform/efl-wk1/fast/writing-mode/box-shadow-horizontal-bt-expected.png: Renamed from LayoutTests/platform/efl/fast/writing-mode/box-shadow-horizontal-bt-expected.png.
  • platform/efl-wk1/fast/writing-mode/box-shadow-vertical-lr-expected.png: Renamed from LayoutTests/platform/efl/fast/writing-mode/box-shadow-vertical-lr-expected.png.
  • platform/efl-wk1/fast/writing-mode/box-shadow-vertical-rl-expected.png: Renamed from LayoutTests/platform/efl/fast/writing-mode/box-shadow-vertical-rl-expected.png.
  • platform/efl-wk1/fast/writing-mode/english-lr-text-expected.png: Renamed from LayoutTests/platform/efl/fast/writing-mode/english-lr-text-expected.png.
  • platform/efl-wk1/ietestcenter/css3/text/textshadow-001-expected.png: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-001-expected.png.
  • platform/efl-wk1/ietestcenter/css3/text/textshadow-002-expected.png: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-002-expected.png.
  • platform/efl-wk1/ietestcenter/css3/text/textshadow-003-expected.png: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-003-expected.png.
  • platform/efl-wk1/ietestcenter/css3/text/textshadow-004-expected.png: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-004-expected.png.
  • platform/efl-wk1/ietestcenter/css3/text/textshadow-010-expected.png: Renamed from LayoutTests/platform/efl/ietestcenter/css3/text/textshadow-010-expected.png.
  • platform/efl-wk1/svg/css/circle-in-mask-with-shadow-expected.png: Renamed from LayoutTests/platform/efl/svg/css/circle-in-mask-with-shadow-expected.png.
  • platform/efl-wk1/svg/css/path-with-shadow-expected.png: Renamed from LayoutTests/platform/efl/svg/css/path-with-shadow-expected.png.
  • platform/efl-wk1/svg/css/shadow-with-large-radius-expected.png: Renamed from LayoutTests/platform/efl/svg/css/shadow-with-large-radius-expected.png.
  • platform/efl-wk1/svg/css/shadow-with-negative-offset-expected.png: Renamed from LayoutTests/platform/efl/svg/css/shadow-with-negative-offset-expected.png.
  • platform/efl-wk1/svg/css/stars-with-shadow-expected.png: Renamed from LayoutTests/platform/efl/svg/css/stars-with-shadow-expected.png.
  • platform/efl-wk1/svg/css/text-gradient-shadow-expected.png: Renamed from LayoutTests/platform/efl/svg/css/text-gradient-shadow-expected.png.
  • platform/efl-wk1/svg/css/text-shadow-multiple-expected.png: Renamed from LayoutTests/platform/efl/svg/css/text-shadow-multiple-expected.png.
  • platform/efl/fast/canvas/fillText-shadow-expected.txt: Removed.
  • platform/gtk/fast/canvas/fillText-shadow-expected.txt: Removed.
  • platform/gtk/svg/css/shadow-and-opacity-expected.png: Removed.
  • svg/css/shadow-and-opacity-expected.png: Renamed from LayoutTests/platform/efl/svg/css/shadow-and-opacity-expected.png.
5:11 AM Changeset in webkit [136675] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

ShadowRoot should recalcStyle for itself
https://bugs.webkit.org/show_bug.cgi?id=103933

Patch by Elliott Sprehn <Elliott Sprehn> on 2012-12-05
Reviewed by Hajime Morita.

ShadowRoot should support recalcStyle just like Element instead of
having the code inside ElementShadow. This was once the case and
the dead method prototype for recalcShadowTreeStyle is still in
ShadowRoot.h.

No new tests, just refactoring.

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::recalcStyle):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::recalcStyle):

  • dom/ShadowRoot.h:
4:56 AM Changeset in webkit [136674] by keishi@webkit.org
  • 11 edits
    9 adds in trunk

Fix text direction in datalist popup for time controls
https://bugs.webkit.org/show_bug.cgi?id=103853

Reviewed by Kent Tamura.

Source/WebCore:

The datalist entry value should be displayed with the same text direction as the date/time format.

Tests: platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew.html

platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew.html
platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew.html

  • Resources/pagepopups/calendarPicker.js: Renamed isCalendarRTL to isLocaleRTL.

(CalendarPicker.prototype._layout):
(CalendarPicker.prototype.fixWindowSize):
(DaysTable.prototype._handleKey):
(MonthPickerDaysTable.prototype._handleKey):
(WeekPickerDaysTable.prototype._handleKey):

  • Resources/pagepopups/suggestionPicker.css:

(.suggestion-list-entry .title): Title should have the same text direction as the locale.
(.locale-rtl .suggestion-list-entry .title):

  • Resources/pagepopups/suggestionPicker.js:

(SuggestionPicker.prototype._layout): Add locale-rtl class if the isLocaleRTL is true.

Source/WebKit/chromium:

  • src/DateTimeChooserImpl.cpp:

(WebKit::DateTimeChooserImpl::writeDocument): Renamed isCalendarRTL to isLocaleRTL.

LayoutTests:

  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png: Added.
  • platform/chromium-mac/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-rtl-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.txt: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew.html: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.txt: Added.
  • platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew.html: Added.
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.txt: Added.
  • platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew.html: Added.
4:54 AM Changeset in webkit [136673] by mkwst@chromium.org
  • 2 edits
    2 deletes in trunk/LayoutTests

[mac][chromium] Unreviewed gardening.

Rebaselining tests after r136657 to pick up changes to console messages.

  • platform/chromium-linux/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt: Removed.
  • platform/chromium-win/http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt: Removed.
  • platform/mac-wk2/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
4:46 AM Changeset in webkit [136672] by mkwst@chromium.org
  • 3 edits
    1 move
    5 adds
    1 delete in trunk/LayoutTests

[gtk] Unreviewed gardening.

Rebaselining tests after r136657 to pick up changes to console messages.

  • platform/chromium-win/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Removed.
  • platform/chromium/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt: Renamed from LayoutTests/platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt.
  • platform/gtk/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/gtk/http/tests/xmlhttprequest/access-control-preflight-async-header-denied-expected.txt: Added.
  • platform/gtk/http/tests/xmlhttprequest/access-control-preflight-async-not-supported-expected.txt: Added.
  • platform/gtk/svg/custom/polyline-setattribute-points-null-expected.txt:
4:38 AM Changeset in webkit [136671] by keishi@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix flickering when hiding page popup
https://bugs.webkit.org/show_bug.cgi?id=104100

Reviewed by Kent Tamura.

Moving the page popup while hiding was causing flickering in some environments.

No new tests. Can't reproduce in layout test.

  • Resources/pagepopups/pickerCommon.js:

(hideWindow): Don't move and just resize.

4:38 AM Changeset in webkit [136670] by mkwst@chromium.org
  • 2 edits
    4 adds in trunk/LayoutTests

[qt] Unreviewed gardening.

Rebaselining tests after r136657 to pick up changes to console messages.

  • platform/qt/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Added.
  • platform/qt/fast/media/mq-resolution-expected.txt: Added.
  • platform/qt/fast/media/w3c/test_media_queries-expected.txt: Added.
  • platform/qt/svg/custom/polyline-setattribute-points-null-expected.txt:

These shouldn't have had line numbers; they were all pointing to the
end of the style or script block in which the message was generated.

4:37 AM Changeset in webkit [136669] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Don't rely on QMimeDatabase for essential MIME types
https://bugs.webkit.org/show_bug.cgi?id=103865

Based on patch by Pierre Rossi.
Reviewed by Jocelyn Turcotte.

Extend the short static list to also include MIME types essential to WebKit,
and detect these first before checking the system mimedatabase.

  • platform/qt/MIMETypeRegistryQt.cpp:

(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getMIMETypeForPath):

4:32 AM Changeset in webkit [136668] by abecsi@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] REGRESSION(r135399): It made qmltests::DoubleTapToZoom::test_double_zoomInAndBack() API test fail
https://bugs.webkit.org/show_bug.cgi?id=103889

Reviewed by Jocelyn Turcotte.

The client should always be notified in PageViewportController::didChangeViewportAttributes
about the changed attributes not only if the minimum scale changed. This ensures that these
changes are propagated to QWebKitTest and the zoom stack of double-tap-to-zoom is reset correctly.
Also increase precision of scale comparisons since the current value resulted in flakyness in
scale related API tests.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::didChangeViewportAttributes):
(WebKit::PageViewportController::updateMinimumScaleToFit):

4:09 AM Changeset in webkit [136667] by thiago.santos@intel.com
  • 32 edits
    3 copies
    1 add in trunk/LayoutTests

[efl] Unreviewed gardening.

Rebaselining tests after r136657 to pick up changes to console messages.

Patch by Mike West <mkwst@chromium.org> on 2012-12-05

  • platform/efl-wk1/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Added.
  • platform/efl-wk1/fast/media/mq-resolution-expected.txt: Added.
  • platform/efl-wk1/fast/media/w3c/test_media_queries-expected.txt: Added.
  • platform/efl-wk1/inspector/console/console-object-constructor-name-expected.txt: Added.
  • platform/efl-wk2/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Added.
  • platform/efl-wk2/fast/media/mq-resolution-expected.txt: Added.
  • platform/efl-wk2/fast/media/w3c/test_media_queries-expected.txt: Added.

These shouldn't have had line numbers; they were all pointing to the
end of the style or script block in which the message was generated.

  • platform/efl-wk1/http/tests/xmlhttprequest/access-control-preflight-async-method-denied-expected.txt: Added.
  • platform/efl-wk1/http/tests/xmlhttprequest/origin-whitelisting-https-expected.txt: Added.

New stack trace.

3:45 AM Changeset in webkit [136666] by mkwst@chromium.org
  • 1 edit
    16 adds in trunk/LayoutTests

[efl] Unreviewed gardening.

Rebaselining tests after r136657 to pick up changes to console messages.

  • platform/efl-wk1/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Added.
  • platform/efl-wk1/fast/media/mq-resolution-expected.txt: Added.
  • platform/efl-wk1/fast/media/w3c/test_media_queries-expected.txt: Added.
  • platform/efl-wk1/inspector/console/console-object-constructor-name-expected.txt: Added.
  • platform/efl-wk2/fast/media/mq-resolution-dpi-dpcm-warning-expected.txt: Added.
  • platform/efl-wk2/fast/media/mq-resolution-expected.txt: Added.
  • platform/efl-wk2/fast/media/w3c/test_media_queries-expected.txt: Added.

These shouldn't have had line numbers; they were all pointing to the
end of the style or script block in which the message was generated.

  • platform/efl-wk1/http/tests/xmlhttprequest/access-control-preflight-async-method-denied-expected.txt: Added.
  • platform/efl-wk1/http/tests/xmlhttprequest/origin-whitelisting-https-expected.txt: Added.

New stack trace.

3:34 AM Changeset in webkit [136665] by tkent@chromium.org
  • 7 edits
    5 copies
    4 adds in trunk/LayoutTests

Layout Test fast/forms/*-multiple-fields/*-multiple-fields-preserve-value-after-history-back.html are slow
https://bugs.webkit.org/show_bug.cgi?id=104094

Reviewed by Kentaro Hara.

Make them faster by spliting them into the main frame HTML files
and the sub frame HTML files. The sub frame HTML files are loaded
five times in one test, and don't need to load
js-test-pre/post.js. This change makes them about 2x faster on my
local machine.

  • fast/forms/date-multiple-fields/date-multiple-fields-preserve-value-after-history-back.html:
  • fast/forms/date-multiple-fields/resources/preserve-value-after-history-back-frame.html: Copied from LayoutTests/fast/forms/date-multiple-fields/date-multiple-fields-preserve-value-after-history-back.html.
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-preserve-value-after-history-back.html:
  • fast/forms/datetimelocal-multiple-fields/resources/preserve-value-after-history-back-frame.html: Copied from LayoutTests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-preserve-value-after-history-back.html.
  • fast/forms/month-multiple-fields/month-multiple-fields-preserve-value-after-history-back.html:
  • fast/forms/month-multiple-fields/resources/preserve-value-after-history-back-frame.html: Copied from LayoutTests/fast/forms/month-multiple-fields/month-multiple-fields-preserve-value-after-history-back.html.
  • fast/forms/time-multiple-fields/resources/preserve-value-after-history-back-frame.html: Copied from LayoutTests/fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html.
  • fast/forms/time-multiple-fields/time-multiple-fields-preserve-value-after-history-back.html:
  • fast/forms/week-multiple-fields/resources/preserve-value-after-history-back-frame.html: Copied from LayoutTests/fast/forms/week-multiple-fields/week-multiple-fields-preserve-value-after-history-back.html.
  • fast/forms/week-multiple-fields/week-multiple-fields-preserve-value-after-history-back.html:
  • platform/chromium/TestExpectations:
3:32 AM Changeset in webkit [136664] by zandobersek@gmail.com
  • 2 edits
    1 move in trunk/LayoutTests

Unreviewed gardening.

Moving Chromium's baseline for media/track/opera/interfaces/TextTrack/addCue.html
(that contains correct, platform-agnostic results) alongside the test.

  • media/track/opera/interfaces/TextTrack/addCue-expected.txt: Copied from LayoutTests/platform/chromium/media/track/opera/interfaces/TextTrack/addCue-expected.txt.
  • platform/chromium/media/track/opera/interfaces/TextTrack/addCue-expected.txt: Removed.
  • platform/efl/TestExpectations: Removed the missing expectation for this test.
3:12 AM Changeset in webkit [136663] by zandobersek@gmail.com
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a platform-specific baseline for fast/css/image-set-value-not-removed-crash.html.
Adding a failure expectation for svg/custom/use-href-update-crash.html.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/css/image-set-value-not-removed-crash-expected.txt: Added.
2:45 AM Changeset in webkit [136662] by mkwst@chromium.org
  • 5 edits in trunk/LayoutTests

Unreviewed gardening.

fast/frames/viewsource-on-image-file.html and
fast/overflow/scrollbar-click-retains-focus.html are failing on every
port. Skipping.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
2:35 AM Changeset in webkit [136661] by zherczeg@webkit.org
  • 2 edits in trunk/Source/WebCore

Optimize ColorMatrix filter
https://bugs.webkit.org/show_bug.cgi?id=103728

Reviewed by Dirk Schulze.

ColorMatrix filter recalculates several constants for
every pixel. It is enough to do these calculations only
once during the initialization. Style issues also fixed.

Existing tests cover this feature.

  • platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::matrix):
(WebCore::saturateAndHueRotate):
(WebCore::effectType):

2:33 AM WebInspector edited by mousewiki@yahoo.com
(diff)
2:31 AM WebInspector edited by frwindsor@hotmail.com
(diff)
2:30 AM WebInspector edited by mousewiki@yahoo.com
(diff)
2:29 AM WebInspector edited by frwindsor@hotmail.com
(diff)
2:24 AM Changeset in webkit [136660] by Carlos Garcia Campos
  • 3 edits
    2 adds in trunk

Flex item auto margins in the cross direction should safe center
https://bugs.webkit.org/show_bug.cgi?id=103919

Reviewed by Ojan Vafai.

Source/WebCore:

Do not apply auto margins for cross axis if there's no alignment
space available.

Test: css3/flexbox/flex-flow-auto-margins-no-available-space.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::alignChildren): Make sure we pass a
positive value for availableAlignmentSpace to
updateAutoMarginsInCrossAxis().

LayoutTests:

  • css3/flexbox/flex-flow-auto-margins-no-available-space-expected.txt: Added.
  • css3/flexbox/flex-flow-auto-margins-no-available-space.html: Added.
2:22 AM Changeset in webkit [136659] by mkwst@chromium.org
  • 3 edits in trunk/LayoutTests

[mac][gtk] Unreviewed gardening.

fast/overflow/scrollbar-click-retains-focus.html was added in r136646
and fails only on Mac WK1, and GTK. Skipping.

  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
2:11 AM Changeset in webkit [136658] by Christophe Dumez
  • 14 edits in trunk/Source/WebKit2

[CoordinatedGraphics] Use unsigned integers for CoordinatedTile IDs
https://bugs.webkit.org/show_bug.cgi?id=103816

Reviewed by Jocelyn Turcotte.

Use unsigned integer for CoordinatedTile identifier type.
CoordinatedTile was previously using signed integers for
its identifier which is unsafe because the generated ID
will overflow at some point and the C and C++ language
standards say that overflow of a signed value is undefined
behaviour.

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:

(WebKit::CoordinatedBackingStore::createTile):
(WebKit::CoordinatedBackingStore::removeTile):
(WebKit::CoordinatedBackingStore::removeAllTiles):
(WebKit::CoordinatedBackingStore::updateTile):
(WebKit::CoordinatedBackingStore::texture):
(WebKit::CoordinatedBackingStore::paintToTextureMapper):
(WebKit::CoordinatedBackingStore::commitTileOperations):

  • UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h:

(CoordinatedBackingStore):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:

(WebKit::LayerTreeCoordinatorProxy::createTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::removeTileForLayer):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:

(LayerTreeCoordinatorProxy):

  • UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:

(WebKit::LayerTreeRenderer::createTile):
(WebKit::LayerTreeRenderer::removeTile):
(WebKit::LayerTreeRenderer::updateTile):

  • UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:

(LayerTreeRenderer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::createTile):
(WebCore::CoordinatedGraphicsLayer::updateTile):
(WebCore::CoordinatedGraphicsLayer::removeTile):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:

(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp:

(WebKit):
(WebKit::CoordinatedTile::CoordinatedTile):
(WebKit::CoordinatedTile::~CoordinatedTile):
(WebKit::CoordinatedTile::updateBackBuffer):
(WebKit::CoordinatedTile::isReadyToPaint):

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h:

(CoordinatedTile):
(CoordinatedTileClient):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:

(WebKit::LayerTreeCoordinator::createTile):
(WebKit::LayerTreeCoordinator::updateTile):
(WebKit::LayerTreeCoordinator::removeTile):

  • WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:

(LayerTreeCoordinator):

2:02 AM Changeset in webkit [136657] by mkwst@chromium.org
  • 201 edits in trunk

Web Inspector: Autogenerate stack traces and line numbers when possible.
https://bugs.webkit.org/show_bug.cgi?id=100650

Reviewed by Yury Semikhatsky.

Source/WebCore:

Console messages generated in WebCore generally are asked to do a bit of
work in order to provide a developer with a detailed report. We ask the
caller to either generate stack traces, or pass in a url/line number
pair, which can be a bit of work. Predictably, most callers don't pass
in what we'd like to see.

This patch creates a new, simpler console message generation API that we
expect most call sites to use. Source, type, level, and message are
required, and an optional request ID can be passed in. Everything else
will be autogenerated inside ConsoleMessage when appropriate.

In a subsequent patch, we expect to be able to trim down more of the
external call sites (ContentSecurityPolicy springs to mind) in order to
further consolidate the external interface. Simple is good.

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::didFailSocketStream):

Drop the now-redundant URL parameter from various WebSocket errors.

  • css/MediaList.cpp:

(WebCore::addResolutionWarningMessageToConsole):

Switch to Document::addConsoleMessage, which means that we can move
line-number generation out of MediaList.

  • dom/Document.cpp:

(WebCore::Document::logExceptionToConsole):

Use the long-form 'addMessage()' rather than the public interface.

(WebCore::Document::processHttpEquiv):

Drop the URL parameter, as it's now autogenerated.

(WebCore::Document::addConsoleMessage):
(WebCore):

  • dom/Document.h:

(Document):

Override the pure virtual method on ScriptExecutionContext, and pass
the call through to the new Console::addMessage, which accepts a
pointer to the Document in order to do line-number generation.

  • dom/ScriptExecutionContext.h:

(ScriptExecutionContext):

Add a pure virtual variant of addConsoleMessage which accepts only
bare minimum data, and expects autogeneration of the rest.
Additionally, ensure that the other variants always have either a
URL/line number, or a stack trace.

  • dom/ViewportArguments.cpp:

(WebCore::reportViewportWarning):

Drop line numbers and URLs from Viewport warnings. We can generate
these now.

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::validateInteractively):

Drop the URL from form autofocus warnings

  • html/HTMLIFrameElement.cpp:

(WebCore::HTMLIFrameElement::parseAttribute):

Drop the URL and line from sandbox attribute warnings.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::printWarningToConsole):

Drop the URL from WebGL warnings.

  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::ConsoleMessage):

Call 'autogenerateMetadata' to ensure that a stack trace is
generated if one isn't provided. Create a new constructor that
accepts a ScriptState/ScriptArguments pair, and use it for console
API calls.

(WebCore):
(WebCore::ConsoleMessage::autogenerateMetadata):

Generate a stack trace given whatever information we've got.

  • inspector/ConsoleMessage.h:

(ConsoleMessage):

Create a new constructor that accepts a ScriptState/ScriptArguments
pair, and use it for console API calls.

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::enable):

Use the short-form ConsoleMessage constructor.

(WebCore::InspectorConsoleAgent::addMessageToConsole):

Use the stack-only constructor, or the ScriptState
constructor, as appropriate.

(WebCore::InspectorConsoleAgent::count):

We generated a stack, pass it in.

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::isWorkerAgent):

  • inspector/PageConsoleAgent.h:

(WebCore::PageConsoleAgent::isWorkerAgent):

  • inspector/PageConsoleAgent.h:

(WebCore::PageConsoleAgent::isWorkerAgent):

We only want to generate call stacks for non-Workers (because
createScriptCallStack explodes in JSC if we're not on the main
thread). This method will allow us to distinguish between those
messages generated from Workers, and those from Pages.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::didReceiveResponse):

Drop the URL parameter from the console message for X-Frame-Options
parsing errors.

  • page/Console.cpp:

(WebCore::Console::addMessage):

When given a Document*, generate a line number if: 1) the document
is still being parsed, 2) the document is not in document.write(),
3) the parser isn't waiting for script, and 4) the parser isn't
executing script. Many callsites didn't check all of these, which
is why the SVG rebaseline (for example) drops lots and lots of line
numbers which point at a closing '</script>' tag.

(WebCore):

  • page/Console.h:

(WebCore):
(Console):

Update the public API to accept a Document* and little else.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::printErrorMessage):

Don't generate a stack here. We can do it later.

  • svg/SVGDocumentExtensions.cpp:

(WebCore::reportMessage):

Drop the URL and line number. We'll generate them. It'll be sweet.

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::addConsoleMessage):
(WebCore):

  • workers/WorkerContext.h:

(WorkerContext):

Implement the new addConsoleMessage variant.

LayoutTests:

New line numbers! Huzzah! (Also, removing some that shouldn't be there).

  • http/tests/inspector/console-xhr-logging-expected.txt:
  • platform/chromium/http/tests/inspector/console-xhr-logging-expected.txt:

One new stack trace! OMG!

  • fast/frames/sandboxed-iframe-autofocus-denied-expected.txt:
  • fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
  • fast/frames/xss-auditor-handles-file-urls-expected.txt:
  • html5lib/run-test11-expected.txt:
  • http/tests/misc/bubble-drag-events-expected.txt:
  • http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt:
  • http/tests/misc/iframe-invalid-source-crash-expected.txt:
  • http/tests/misc/image-blocked-src-change-expected.txt:
  • http/tests/misc/image-blocked-src-no-change-expected.txt:
  • http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • http/tests/security/frame-loading-via-document-write-expected.txt:
  • http/tests/security/mixedContent/insecure-css-in-iframe-expected.txt:
  • http/tests/security/mixedContent/insecure-css-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/insecure-image-in-main-frame-expected.txt:
  • http/tests/security/xss-DENIED-xml-external-entity-expected.txt:
  • http/tests/security/xssAuditor/base-href-control-char-expected.txt:
  • http/tests/security/xssAuditor/base-href-expected.txt:
  • http/tests/security/xssAuditor/base-href-null-char-expected.txt:
  • http/tests/security/xssAuditor/base-href-scheme-relative-expected.txt:
  • http/tests/security/xssAuditor/cookie-injection-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-code-attribute-2-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-code-attribute-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/embed-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/form-action-expected.txt:
  • http/tests/security/xssAuditor/full-block-base-href-expected.txt:
  • http/tests/security/xssAuditor/full-block-get-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/full-block-iframe-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/full-block-iframe-no-inherit-expected.txt:
  • http/tests/security/xssAuditor/full-block-javascript-link-expected.txt:
  • http/tests/security/xssAuditor/full-block-link-onclick-expected.txt:
  • http/tests/security/xssAuditor/full-block-object-tag-expected.txt:
  • http/tests/security/xssAuditor/full-block-post-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/full-block-script-tag-expected.txt:
  • http/tests/security/xssAuditor/full-block-script-tag-with-source-expected.txt:
  • http/tests/security/xssAuditor/get-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/iframe-injection-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-more-encoding-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode2-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-twice-url-encode3-expected.txt:
  • http/tests/security/xssAuditor/iframe-javascript-url-url-encoded-expected.txt:
  • http/tests/security/xssAuditor/iframe-onload-GBK-char-expected.txt:
  • http/tests/security/xssAuditor/iframe-onload-in-svg-tag-expected.txt:
  • http/tests/security/xssAuditor/iframe-srcdoc-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-GBK-char-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-accented-char-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-non-ASCII-char-default-encoding-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-non-ASCII-char-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-default-encoding-expected.txt:
  • http/tests/security/xssAuditor/img-onerror-non-ASCII-char2-expected.txt:
  • http/tests/security/xssAuditor/inline-event-HTML-entities-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-control-char-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-named-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-HTML-entities-null-char-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-ampersand-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-control-char-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-null-char-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-one-plus-one-expected.txt:
  • http/tests/security/xssAuditor/javascript-link-url-encoded-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-ampersand-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-control-char-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-entities-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-expected.txt:
  • http/tests/security/xssAuditor/link-onclick-null-char-expected.txt:
  • http/tests/security/xssAuditor/link-opens-new-window-expected.txt:
  • http/tests/security/xssAuditor/malformed-HTML-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-1-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-2-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-3-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-4-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-5-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-6-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-7-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-8-expected.txt:
  • http/tests/security/xssAuditor/malformed-xss-protection-header-9-expected.txt:
  • http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-expected.txt:
  • http/tests/security/xssAuditor/object-embed-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/object-tag-expected.txt:
  • http/tests/security/xssAuditor/object-tag-javascript-url-expected.txt:
  • http/tests/security/xssAuditor/open-attribute-body-expected.txt:
  • http/tests/security/xssAuditor/open-event-handler-iframe-expected.txt:
  • http/tests/security/xssAuditor/open-iframe-src-expected.txt:
  • http/tests/security/xssAuditor/open-script-src-expected.txt:
  • http/tests/security/xssAuditor/post-from-iframe-expected.txt:
  • http/tests/security/xssAuditor/property-escape-comment-expected.txt:
  • http/tests/security/xssAuditor/property-escape-entity-expected.txt:
  • http/tests/security/xssAuditor/property-escape-expected.txt:
  • http/tests/security/xssAuditor/property-escape-long-expected.txt:
  • http/tests/security/xssAuditor/property-escape-quote-expected.txt:
  • http/tests/security/xssAuditor/report-script-tag-expected.txt:
  • http/tests/security/xssAuditor/script-tag-Big5-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-16bit-unicode-expected.txt:
  • http/tests/security/xssAuditor/script-tag-Big5-char-twice-url-encode-expected.txt:
  • http/tests/security/xssAuditor/script-tag-Big5-char2-expected.txt:
  • http/tests/security/xssAuditor/script-tag-addslashes-backslash-expected.txt:
  • http/tests/security/xssAuditor/script-tag-addslashes-double-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-addslashes-null-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-addslashes-single-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-control-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-convoluted-expected.txt:
  • http/tests/security/xssAuditor/script-tag-entities-expected.txt:
  • http/tests/security/xssAuditor/script-tag-expected.txt:
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag-expected.txt:
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag2-expected.txt:
  • http/tests/security/xssAuditor/script-tag-inside-svg-tag3-expected.txt:
  • http/tests/security/xssAuditor/script-tag-null-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-open-redirect-expected.txt:
  • http/tests/security/xssAuditor/script-tag-post-control-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-post-expected.txt:
  • http/tests/security/xssAuditor/script-tag-post-null-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-redirect-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode-surrogate-pair-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode2-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode3-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode4-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-16bit-unicode5-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-actual-comma-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-callbacks-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-comma-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-fancy-unicode-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-invalid-closing-tag-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-invalid-url-encoding-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-control-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-data-url-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-data-url2-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-data-url3-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-double-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-entities-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-no-quote-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-null-char-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-relative-scheme-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-same-host-with-query-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-source-unterminated-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-three-times-url-encoded-16bit-unicode-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment2-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment3-expected.txt:
  • http/tests/security/xssAuditor/script-tag-with-trailing-comment4-expected.txt:
  • http/tests/security/xssAuditor/xss-filter-bypass-big5-expected.txt:
  • http/tests/security/xssAuditor/xss-filter-bypass-long-string-expected.txt:
  • http/tests/security/xssAuditor/xss-filter-bypass-sjis-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-01-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-02-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt:
  • http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt:
  • platform/chromium-mac/http/tests/security/cross-origin-xsl-BLOCKED-expected.txt:
  • platform/chromium/http/tests/misc/bubble-drag-events-expected.txt:
  • platform/chromium/http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt:
  • platform/chromium/http/tests/misc/iframe-invalid-source-crash-expected.txt:
  • platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-allowed-expected.txt:
  • platform/chromium/http/tests/security/mixedContent/insecure-image-in-main-frame-blocked-expected.txt:
  • platform/chromium/http/tests/security/xssAuditor/javascript-link-control-char2-expected.txt:
  • platform/chromium/svg/custom/polyline-setattribute-points-null-expected.txt:
  • platform/mac/svg/custom/clip-path-referencing-use2-expected.txt:
  • platform/mac/svg/custom/polyline-setattribute-points-null-expected.txt:
  • svg/custom/invalid-length-units-expected.txt:
  • svg/custom/poly-parsing-error-expected.txt:
  • svg/dom/SVGScriptElement/script-onerror-bubbling-expected.txt:
  • svg/dom/fuzz-path-parser-expected.txt:
  • svg/dom/path-parser-expected.txt:
  • svg/dom/points-parser-expected.txt:
1:54 AM Changeset in webkit [136656] by Carlos Garcia Campos
  • 4 edits
    3 adds in trunk

Reduce the children repaints when moved multiple times during the layout
https://bugs.webkit.org/show_bug.cgi?id=103510

Reviewed by Darin Adler.

Source/WebCore:

Cache the children positions before the layout and move to the
final position after the layout.

Test: css3/flexbox/repaint-column-reverse.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::OrderIterator::OrderIterator): Do not
call first() on the consructor.
(WebCore::RenderFlexibleBox::layoutBlock): Use a Vector with the
children frame rects before the layout and call
repaintChildrenDuringLayoutIfMoved() to repaint the children that
have been moved.
(WebCore::RenderFlexibleBox::appendChildrenFrameRects): Return a
Vector with children frame rects.
(WebCore::RenderFlexibleBox::repaintChildrenDuringLayoutIfMoved):
Call repaintDuringLayoutIfMoved() for every children using the old
frame rects.
(WebCore::RenderFlexibleBox::setFlowAwareLocationForChild): Do not
call repaintDuringLayoutIfMoved().
(WebCore::RenderFlexibleBox::layoutFlexItems): Make sure the
passed iterator points to the first child.

  • rendering/RenderFlexibleBox.h:

LayoutTests:

Add test to check that for flex items moved multiple times during the
layout, only the initial and final positions are repainted.

  • css3/flexbox/repaint-column-reverse-expected.txt: Added.
  • css3/flexbox/repaint-column-reverse.html: Added.
  • platform/chromium-linux/css3/flexbox/repaint-column-reverse-expected.png: Added.
1:42 AM Changeset in webkit [136655] by dominik.rottsches@intel.com
  • 2 edits
    7 adds in trunk/LayoutTests

[EFL] Unreviewed gardening.

Rebaselining viewsource* after r126683.
Adding new baseline for orientation-sideways, new test.
Moving addCue test to TestExpectations until it's fixed in bug 103925.

  • platform/efl-wk2/fast/frames/viewsource-attribute-expected.png: Added.
  • platform/efl-wk2/fast/frames/viewsource-attribute-expected.txt: Added.
  • platform/efl-wk2/fast/frames/viewsource-on-image-file-expected.png: Added.
  • platform/efl-wk2/fast/frames/viewsource-on-image-file-expected.txt: Added.
  • platform/efl/TestExpectations:
  • platform/efl/fast/text/orientation-sideways-expected.png: Added.
  • platform/efl/fast/text/orientation-sideways-expected.txt: Added.
1:38 AM Changeset in webkit [136654] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add APIs to get/set private browsing.
https://bugs.webkit.org/show_bug.cgi?id=102052

Patch by Yuni Jeong <yhnet.jung@samsung.com> on 2012-12-05
Reviewed by Gyuyoung Kim.

Private Browsing allows a user to browse the Internet without saving any information about which sites and pages a user has visited.

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_private_browsing_enabled_set):
(ewk_settings_private_browsing_enabled_get):

  • UIProcess/API/efl/ewk_settings.h:
  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

1:03 AM Changeset in webkit [136653] by mkwst@chromium.org
  • 2 edits in trunk/LayoutTests

[chromium] Unreviewed gardening.

fast/text/hyphenate-character.html, fast/text/hyphenate-first-word.html
fast/text/hyphenate-locale.html, and fast/text/hyphens.html have started
failing on Linux. Widening the skip to cover that platform as well (they
were already skipped for Windows, Mac, and Android.

  • platform/chromium/TestExpectations:
1:03 AM Changeset in webkit [136652] by jochen@chromium.org
  • 31 edits in trunk/Source/WebCore

[V8] toV8Fast for all classes with ScriptWrapper Holder objects
https://bugs.webkit.org/show_bug.cgi?id=102686

Patch by Dan Carney <dcarney@google.com> on 2012-12-05
Reviewed by Adam Barth.

This patch makes most generated bindings use toV8Fast
by adding a fast path to the main world DOMDataStore.
Additionally, toV8Fast is now being called on callbacks
which use v8::Arguments.

No new tests. No change in functionality.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrGetter):
(GenerateFunctionCallString):
(NativeToJSValue):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::mainWorldStore):
(WebCore::DOMDataStore::current):

  • bindings/v8/DOMDataStore.h:
12:45 AM Changeset in webkit [136651] by aandrey@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Canvas] nit: add more typization for js compiler
https://bugs.webkit.org/show_bug.cgi?id=103994

Reviewed by Pavel Feldman.

  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

12:26 AM Changeset in webkit [136650] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

URL schemes registered as local, no access, display isolated and as CORS enabled are not registered again after a web process crash
https://bugs.webkit.org/show_bug.cgi?id=104013

Patch by Joaquim Rocha <jrocha@igalia.com> on 2012-12-05
Reviewed by Darin Adler.

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess): Iterate through the schemes stored in
urlSchemesRegisteredAsLocal, urlSchemesRegisteredAsNoAccess,
urlSchemesRegisteredAsDisplayIsolated and urlSchemesRegisteredAsCORSEnabled and
call the respective (already existing) methods for registering them.

12:26 AM Changeset in webkit [136649] by tasak@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, WebKit gardening.
https://bugs.webkit.org/show_bug.cgi?id=103487

  • platform/chromium/TestExpectations:

fast/forms/placeholder-position.html is flaky on linux.

12:13 AM Changeset in webkit [136648] by tasak@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, WebKit gardening.
https://bugs.webkit.org/show_bug.cgi?id=104092

  • platform/chromium/TestExpectations:

Mark fast/frames/paint-iframe-background.html as flaky.

12:03 AM Changeset in webkit [136647] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CSS Exclusions] ExclusionShape inlines should use isFlippedBlocksWritingMode()
https://bugs.webkit.org/show_bug.cgi?id=103939

Patch by Hans Muller <hmuller@adobe.com> on 2012-12-05
Reviewed by Dirk Schulze.

Just a minor cleanup: the protected ExclusionShape inlines, like minYForLogicalLine(),
now use isFlippedBlocksWritingMode() instead of testing for RightToLeftWritingMode directly.
This changeimproves consistency with the rest of WebKit and will work correctly
if "horizontal-bt" writing-mode support is ever added.

No new tests were added since the existing tests cover these methods.

  • rendering/ExclusionShape.h:

(WebCore::ExclusionShape::minYForLogicalLine):
(WebCore::ExclusionShape::maxYForLogicalLine):
(WebCore::ExclusionShape::internalToLogicalBoundingBox):

12:02 AM Changeset in webkit [136646] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Absolutely positioned non-replaced elements should resolve vertical margins against
their containing block's logical width
https://bugs.webkit.org/show_bug.cgi?id=103576

Patch by Bear Travis <betravis@adobe.com> on 2012-12-05
Reviewed by Emil A Eklund.

Source/WebCore:

According to the CSS box model specification, all percentage margin & padding values,
including top & bottom, should be resolved based on the containing block's width.
http://www.w3.org/TR/CSS2/box.html#margin-properties
The writing modes specification has refined this definition to use the containing
block's logical width to resolve percentage margin & padding values.
http://dev.w3.org/csswg/css3-writing-modes/#dimension-mapping

Previously, positioned elements measured their container in the element's block
direction (containerLogicalHeight) to resolve margin-before/after, and in the inline
direction (containerLogicalWidth) to resolve margin-start/end. This patch measures the
container's logical width in its own inline direction (containerRelativeLogicalWidth)
to resolve all margin percentage values.

Test: fast/writing-mode/percentage-margins-absolute.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidthUsing): Calculate the logical width
of the container, and use it to calculate margins.
(WebCore::RenderBox::computePositionedLogicalHeightUsing): Ditto.

LayoutTests:

Test that different writing mode combinations between a parent and child correctly
compute percentage margins for an absolutely positioned child.

  • fast/writing-mode/percentage-margins-absolute-expected.txt: Added.
  • fast/writing-mode/percentage-margins-absolute.html: Added.
12:01 AM Changeset in webkit [136645] by haraken@chromium.org
  • 9 edits in trunk/Source/WebCore

[V8] Replace String::New("symbol") with String::NewSymbol("symbol") (part 2)
https://bugs.webkit.org/show_bug.cgi?id=104082

Reviewed by Adam Barth.

V8 can look up symbols faster than strings.

No tests. No change in behavior.

  • bindings/v8/custom/V8ArrayBufferViewCustom.cpp:

(WebCore::getHiddenCopyMethod):
(WebCore::installHiddenCopyMethod):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):

  • bindings/v8/custom/V8CustomXPathNSResolver.cpp:

(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::DialogHandler::dialogCreated):
(WebCore::DialogHandler::returnValue):

  • bindings/v8/custom/V8GeolocationCustom.cpp:

(WebCore::createPositionOptions):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::wrapInShadowObject):
(WebCore::V8HTMLDocument::openCallback):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::V8HTMLImageElementConstructor::GetTemplate):

  • bindings/v8/custom/V8SQLTransactionCustom.cpp:

(WebCore::V8SQLTransaction::executeSqlCallback):

Dec 4, 2012:

11:07 PM Changeset in webkit [136644] by tasak@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, WebKit gardening.
https://bugs.webkit.org/show_bug.cgi?id=104090

  • platform/chromium/TestExpectations:

Mark fast/css-grid-layout/grid-columns-rows-get-set-multiple.html and
fast/css-grid-layout/grid-columns-rows-get-set.html as crash on Mac
Debug.

10:30 PM Changeset in webkit [136643] by tasak@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, WebKit gardening.

  • platform/chromium/TestExpectations:

Mark fast/frames/viewsource-attribute.html and
viewsource-on-image-file.html as failure.

10:23 PM Changeset in webkit [136642] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Source/WebCore: Clicking a scrollbar unfocuses the current activeElement
https://bugs.webkit.org/show_bug.cgi?id=96335

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-12-04
Reviewed by Ojan Vafai.

Previously we only tested for clicks inside frame scrollbars before
moving the focus, this patch expands the check to overflow scrollbars.
Now clicking inside a scrollbar only moves the focus when the scrollbar
has an ancestor that is mouse focusable.

This matches Gecko behavior, and was agreed to be the most sensible for now:
http://lists.whatwg.org/htdig.cgi/whatwg-whatwg.org/2012-October/037759.html

Test: fast/overflow/scrollbar-click-retains-focus.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):

Never start selections inside scrollbars because it would cause asserts.
This wasn't a problem before because we always moved the focus when clicking a scrollbar.

(WebCore::EventHandler::dispatchMouseEvent):

Check that the click is not inside a scrollbar before moving the focus.

(WebCore::EventHandler::isInsideScrollbar): Tests if a point is in a scrollbar.
(WebCore):
(WebCore::EventHandler::sendContextMenuEvent):

Never start selections inside scrollbars because it would cause asserts.

  • page/EventHandler.h:

(EventHandler):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTestOverflowControls):

LayoutTests: Clicking a scrollbar unfocuses the current activeElement
https://bugs.webkit.org/show_bug.cgi?id=96335

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-12-04
Reviewed by Ojan Vafai.

Add test that ensures clicking inside a scrollbar doesn't move the
focus unless the scrollbar is inside a mouse focusable element.

  • fast/overflow/scrollbar-click-retains-focus-expected.txt: Added.
  • fast/overflow/scrollbar-click-retains-focus.html: Added.
10:20 PM Changeset in webkit [136641] by haraken@chromium.org
  • 14 edits in trunk/Source/WebCore

[V8] Replace String::New("symbol") with String::NewSymbol("symbol")
https://bugs.webkit.org/show_bug.cgi?id=104084

Reviewed by Adam Barth.

V8 can look up symbols faster than strings. This is a final patch for the replacement.

No tests. No change in behavior.

  • bindings/v8/DateExtension.cpp:

(WebCore::DateExtension::setAllowSleep):
(WebCore::DateExtension::GetNativeFunction):

  • bindings/v8/NPV8Object.cpp:

(WebCore::npIdentifierToV8Identifier):
(_NPN_Invoke):

  • bindings/v8/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::addListener):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::setContextDebugId):

  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::callDebuggerMethod):
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
(WebCore::ScriptDebugServer::setBreakpointsActivated):
(WebCore::ScriptDebugServer::handleV8DebugEvent):
(WebCore::ScriptDebugServer::dispatchDidParseSource):

  • bindings/v8/ScriptObject.cpp:

(WebCore::ScriptGlobalObject::set):
(WebCore::ScriptGlobalObject::get):
(WebCore::ScriptGlobalObject::remove):

  • bindings/v8/V8Binding.h:

(WebCore::toV8Sequence):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::setInjectedScriptContextDebugId):
(WebCore::V8DOMWindowShell::updateDocumentProperty):
(WebCore::V8DOMWindowShell::clearDocumentProperty):

  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectPropertyEnumerator):

  • bindings/v8/V8NodeFilterCondition.cpp:

(WebCore::V8NodeFilterCondition::acceptNode):

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::constructorOfToString):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::initializeContextIfNeeded):

  • bindings/v8/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::addListener):

10:18 PM Changeset in webkit [136640] by mitz@apple.com
  • 21 edits
    1 move
    3 adds in trunk

Support text-orientation: sideways-right (and sideways when it maps to sideways-right)
https://bugs.webkit.org/show_bug.cgi?id=104035

Reviewed by Anders Carlsson.

Test: fast/text/orientation-sideways.html

  • GNUmakefile.list.am: Updated for rename of TextOrientation.h.
  • WebCore.gypi: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Changed to retrieve
text-orientation from RenderStyle rather than from the font description.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): Added sideways and sideways-right as acceptable
text-orientation values.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added mappings for sideways and
sideways-right.
(WebCore::CSSPrimitiveValue::operator TextOrientation): Ditto.

  • css/CSSValueKeywords.in: Added sideways and sideways-right.
  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder): Removed text-orientation property handler, as it is
now handled in CSSStyleResolver.

  • css/StyleResolver.cpp:

(WebCore::getFontAndGlyphOrientation): Added this helper function that determines the font
orientation and non-CJK glyph orientation based on writing-mode and text-orientation.
(WebCore::StyleResolver::styleForDocument): Added code to set the font orientation and
non-CJK glyph orientation in the document style.
(WebCore::checkForOrientationChange): Added. Sets the font orientation and non-CJK glyph
orientation in the child style if the difference between the parent and child styles requires
doing so.
(WebCore::StyleResolver::updateFont): Added call to checkForOrientationChange().
(WebCore::StyleResolver::applyProperty): Changed the writing-mode case to call the new
setWritingMode helper, which dirties the font as needed, rather than changing the font
here. Moved handling of text-orientation here, by calling setTextOrientation, which also
dirties the font as needed.

  • css/StyleResolver.h:

(WebCore::StyleResolver::setWritingMode): Added. Dirties the font if the writing mode changes.
(WebCore::StyleResolver::setTextOrientation): Ditto for text orientation.

  • platform/graphics/FontDescription.h:

(WebCore::FontDescription::FontDescription): Updated initializer for rename.
(WebCore::FontDescription::nonCJKGlyphOrientation): Renamed textOrientation to this.
(WebCore::FontDescription::setNonCJKGlyphOrientation): Renamed setTextOrientation to this.
(FontDescription): Renamed member variable m_textOrientation to m_nonCJKGlyphOrientation.
(WebCore::FontDescription::operator==): Updated for rename.

  • platform/graphics/FontFastPath.cpp:

(WebCore::glyphDataAndPageForNonCJKCharacterWithGlyphOrientation): Renamed
glyphDataAndPageForCharacterWithTextOrientation to this and changed the parameter type from
TextOrientation to NonCJKGlyphOrientation.
(WebCore::Font::glyphDataAndPageForCharacter): Updated for above rename.

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::fontDataForCombiningCharacterSequence): Updated for rename of
FontDescription::textOrientation().

  • platform/text/NonCJKGlyphOrientation.h: Renamed TextOrientation.h to this, and renamed

the enum and its values to better reflect that they describe how glyphs for non-CJK
characters are to be rendered in vertical text.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::requiresIdeographicBaseline): Updated for rename of
FontDescription::textOrientation().

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): Made text-orientation change a layout change.

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::setTextOrientation): Added.

  • rendering/style/RenderStyleConstants.h: Added a new TextOrientation enum here.
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData): Added initialization and copying
of m_textOrientation member variable.
(WebCore::StyleRareInheritedData::operator==): Added comparing of m_textOrientation.

  • rendering/style/StyleRareInheritedData.h:

(StyleRareInheritedData): Added m_textOrientation member variable.

9:51 PM Changeset in webkit [136639] by Jonathan Dong
  • 2 edits in trunk/Tools

Change email address of Jonathan Dong
https://bugs.webkit.org/show_bug.cgi?id=103976

Unreviewed, change my email address from Jonathan Dong
to jonathan.dong.webkit@gmail.com in committers list.

  • Scripts/webkitpy/common/config/committers.py:
9:36 PM Changeset in webkit [136638] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Use ScopedPersistent for IntegerCache::smallIntegers
https://bugs.webkit.org/show_bug.cgi?id=104066

Reviewed by Adam Barth.

We can use ScopedPersistent for IntegerCache::smallIntegers
instead of manual Persistent::New().

I confirmed no performance regression in Bindings/scroll-top.html

No tests. No change in behavior.

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::V8PerIsolateData):

  • bindings/v8/V8ValueCache.cpp:

(WebCore::IntegerCache::IntegerCache):

  • bindings/v8/V8ValueCache.h:

(IntegerCache):
(WebCore::IntegerCache::v8Integer):
(WebCore::IntegerCache::v8UnsignedInteger):

9:20 PM Changeset in webkit [136637] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add APIs to get/set default font size.
https://bugs.webkit.org/show_bug.cgi?id=101921

Patch by Yuni Jeong <yhnet.jung@samsung.com> on 2012-12-04
Reviewed by Gyuyoung Kim.

Add setting APIs for default font size and a unit test.

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_default_font_size_set):
(ewk_settings_default_font_size_get):

  • UIProcess/API/efl/ewk_settings.h:
  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

9:18 PM Changeset in webkit [136636] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Resources: domain cookies are not shown for sub-sub domain pages.
https://bugs.webkit.org/show_bug.cgi?id=104016

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-12-04
Reviewed by Pavel Feldman.

Fixed regexp to allow zero or more subdomain prefix (was zero or one).

  • inspector/front-end/CookieParser.js:

(WebInspector.Cookies.cookieDomainMatchesResourceDomain): Fixed regexp.

9:15 PM Changeset in webkit [136635] by hclam@chromium.org
  • 2 edits in trunk/Source/WebCore

Not reviewed. Build fix.

Fix Chromium Windows build.

  • platform/graphics/chromium/ImageDecodingStore.h:

(CacheEntry):

9:11 PM Changeset in webkit [136634] by haraken@chromium.org
  • 19 edits in trunk/Source

[V8] Remove toV8Object()
https://bugs.webkit.org/show_bug.cgi?id=103987

Reviewed by Adam Barth.

toV8Object() is used only for MessagePort and ArrayBuffer
only by SerializedScriptValue. It is wasteful to generate
toV8Object() for all interfaces.

No tests. No change in behavior.

Source/WebCore:

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):

  • bindings/scripts/test/V8/V8Float64Array.h:

(WebCore):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:
  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
  • bindings/scripts/test/V8/V8TestEventConstructor.h:
  • bindings/scripts/test/V8/V8TestEventTarget.h:
  • bindings/scripts/test/V8/V8TestException.h:
  • bindings/scripts/test/V8/V8TestInterface.h:
  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
  • bindings/scripts/test/V8/V8TestNamedConstructor.h:
  • bindings/scripts/test/V8/V8TestNode.h:
  • bindings/scripts/test/V8/V8TestObj.h:
  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
  • bindings/v8/SerializedScriptValue.cpp:

Source/WebKit/chromium:

  • src/WebArrayBuffer.cpp:

(WebKit::WebArrayBuffer::toV8Value):

  • src/WebBlob.cpp:

(WebKit::WebBlob::toV8Value):

9:11 PM Changeset in webkit [136633] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] VKB flickers in and out when tapping on webview after text selection on URL bar
https://bugs.webkit.org/show_bug.cgi?id=103874
PR245678

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2012-12-04
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.

When the virtual keyboard is hiding, the viewport is changed and the page needs
to relayout.At the same time, the user interface thread is executing compositeLayers
and it will dispatch the updateDelegatedOverlays() to webkit thread which will trigger
the selectionPositionChanged() in webkit thread.

When the selectionPositionChanged() calls frame->selection()->selection().
visibleStart() and frame->selection()->selection().visibleEnd(), it will
trigger page relayout and return the relayouted selection start and end position.
These positions are out of the range which is recorded before its relayout.
As a result it think the selection start and end are all clipped out and it send
out an "empty selection"(not selected) changing event.

When the WebPageClient receives the empty selection changing event, it will consider
the selection process aborted and might cancel selection-related user interaction.
This is not what we intend to happen.

This patch stops the changing handling process and returns when the page needs relayout,
and the selection will be updated again when the page finishs relayout.

  • WebKitSupport/SelectionHandler.cpp:

(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):

9:02 PM Changeset in webkit [136632] by haraken@chromium.org
  • 16 edits in trunk/Source/WebCore

[V8] Replace v8::Null(isolate) with v8Null(isolate)
https://bugs.webkit.org/show_bug.cgi?id=104070

Reviewed by Adam Barth.

v8Null(isolate) is a faster version of v8::Null(isolate).

No tests. No change in behavior.

  • bindings/v8/V8Binding.h:

(WebCore::v8StringOrNull):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::typesAccessorGetter):

  • bindings/v8/custom/V8CoordinatesCustom.cpp:

(WebCore::V8Coordinates::altitudeAccessorGetter):
(WebCore::V8Coordinates::altitudeAccuracyAccessorGetter):
(WebCore::V8Coordinates::headingAccessorGetter):
(WebCore::V8Coordinates::speedAccessorGetter):

  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp:

(WebCore::V8DeviceMotionEvent::accelerationAccessorGetter):
(WebCore::V8DeviceMotionEvent::accelerationIncludingGravityAccessorGetter):
(WebCore::V8DeviceMotionEvent::rotationRateAccessorGetter):
(WebCore::V8DeviceMotionEvent::intervalAccessorGetter):

  • bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:

(WebCore::V8DeviceOrientationEvent::alphaAccessorGetter):
(WebCore::V8DeviceOrientationEvent::betaAccessorGetter):
(WebCore::V8DeviceOrientationEvent::gammaAccessorGetter):
(WebCore::V8DeviceOrientationEvent::absoluteAccessorGetter):

  • bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAccessorGetter):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

  • bindings/v8/custom/V8HistoryCustom.cpp:

(WebCore::V8History::stateAccessorGetter):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):

  • bindings/v8/custom/V8MicroDataItemValueCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):

  • bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore::V8PopStateEvent::stateAccessorGetter):

  • bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:

(WebCore::V8SQLResultSetRowList::itemCallback):

  • bindings/v8/custom/V8TrackEventCustom.cpp:

(WebCore::V8TrackEvent::trackAccessorGetter):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getSupportedExtensionsCallback):

8:55 PM Changeset in webkit [136631] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/chromium

[Chromium] Detach the frame and destroy the page immediately upon request to closeHelperPlugin().
https://bugs.webkit.org/show_bug.cgi?id=103947

Patch by David Dorwin <ddorwin@chromium.org> on 2012-12-04
Reviewed by Kent Tamura.

In the case that the host page is being destroyed, some of the objects
the page depends on, specifically RenderViewImpl, may be destroyed by
the time close() is called asynchronously.
The frameDetached() calling code was originally copied from
WebViewImpl::close(), but WebViewImpl does not have an asynchronous
closing mechanism like the WebWidgets.

This is the fix for http://crbug.com/160650

  • src/WebHelperPluginImpl.cpp:

(WebKit::WebHelperPluginImpl::init):
(WebKit::WebHelperPluginImpl::closeHelperPlugin):
(WebKit::WebHelperPluginImpl::destoryPage):
(WebKit):
(WebKit::WebHelperPluginImpl::close):.
(WebKit::WebHelperPlugin::create):

  • src/WebHelperPluginImpl.h:

(WebHelperPluginImpl):

  • src/WebPagePopupImpl.cpp: Made similar changes since it follows the same model. (I think the way popups are closed has prevented the race condition from occurring for popups.)

(WebKit::WebPagePopupImpl::destoryPage):
(WebKit):
(WebKit::WebPagePopupImpl::close):
(WebKit::WebPagePopupImpl::closePopup):

  • src/WebPagePopupImpl.h:

(WebPagePopupImpl):

8:49 PM Changeset in webkit [136630] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Make LazyDecodingPixelRef inherit from skia::LazyPixelRef so that cc thread can access it
https://bugs.webkit.org/show_bug.cgi?id=103555

Patch by Min Qin <qinmin@chromium.org> on 2012-12-04
Reviewed by Stephen White.

Expose LazyDecodingPixelRef to the cc thread by inheriting from skia::LazyPixelRef.
No test added for now as impl side paiting is still WIP.

  • platform/graphics/chromium/LazyDecodingPixelRef.cpp:

(WebCore::LazyDecodingPixelRef::LazyDecodingPixelRef):
(WebCore::LazyDecodingPixelRef::PrepareToDecode):
(WebCore):
(WebCore::LazyDecodingPixelRef::Decode):

  • platform/graphics/chromium/LazyDecodingPixelRef.h:

(LazyDecodingPixelRef):

8:46 PM Changeset in webkit [136629] by tasak@google.com
  • 2 edits in trunk/Source/WebCore

Fix compile error when SVG is disabled.

Unreviewed gardening.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):

8:40 PM Changeset in webkit [136628] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[BlackBerry] DRT - Tests under "dumpAsText" directory should be dumped as text
https://bugs.webkit.org/show_bug.cgi?id=103986

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-12-04
Reviewed by Rob Buis.

Also move declaration of webSettingTransaction to before any WebSettings
::setXXX() calls so that it works as expected (commit only once in the
function scope).

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(shouldDumpAsText):
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):

8:37 PM Changeset in webkit [136627] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL][WK2] Enable compositing pixel tests that are not fail after EFL WTR snapshot implementation.
https://bugs.webkit.org/show_bug.cgi?id=104075

Unreviewed, EFL gardening.

Patch by Viatcheslav Ostapenko <v.ostapenko@samsung.com> on 2012-12-04

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
8:35 PM Changeset in webkit [136626] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Static code analysis warning fixes
https://bugs.webkit.org/show_bug.cgi?id=103837

Patch by Anthony Scian <ascian@rim.com> on 2012-12-04
Reviewed by Rob Buis.

172,174: disable copy ctor, op= in AutofillBackingStore
504,506: disable copy ctor, op= in CookieManager
1488,1491: disable copy ctor, op= in RSSParserBase
1489,1490: disable copy ctor, op= in RSSItem
514,516: disable copy ctor, op= in CredentialBackingStore
1363: m_state not initialized in ctor

  • platform/blackberry/CookieManager.h:
  • platform/blackberry/PlatformTouchPointBlackBerry.cpp:

(WebCore::PlatformTouchPoint::PlatformTouchPoint):

  • platform/network/blackberry/AutofillBackingStore.h:

(AutofillBackingStore):

  • platform/network/blackberry/CredentialBackingStore.h:

(CredentialBackingStore):

  • platform/network/blackberry/rss/RSSParserBase.h:

(RSSParserBase):

8:33 PM Changeset in webkit [136625] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] Removed obsolete local variable from WebViewImpl.cpp.
https://bugs.webkit.org/show_bug.cgi?id=104050

Patch by David Dorwin <ddorwin@chromium.org> on 2012-12-04
Reviewed by Kent Tamura.

These lines were added with the file in 50739#L761 but the later use
of this variable at L779 has since been removed.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::close):

8:28 PM Changeset in webkit [136624] by noel.gordon@gmail.com
  • 5 edits in trunk

[v8] Improve worker.postMessage() string performance: avoid utf8 conversion
https://bugs.webkit.org/show_bug.cgi?id=102230

Reviewed by Eric Seidel.

Source/WebCore:

Avoid utf8 conversion when serializing strings with SerializedScriptValue. Provide
Ascii and UChar writers for v8 string serialization and provide a UChar reader for
deserialization. Define/use serialization StringUCharTag to indicate UChar strings
in the wire format. Increment the SerializedScriptValue wire format version.

In the wire format, StringUCharTag is followed by the string length in bytes, then
the length/2 UChars of the string.

Note the string length is VarInt encoded. During serialization, compute the number
of bytes used to encode the length and prepend a PaddingTag if needed so the UChar
data appears on an even-byte boundary. This prevents unaligned reads of UChar data
during deserialization (the deserialization buffer is even-byte aligned).

Testing transfers of large strings to and from workers indicates a 10X improvement
in transfer rate for strings, and strings within js objects, with this change. For
example, 500 MByte/s on my test machine (50 MByte/s without this change) for flat,
32 MByte string postMessage() transfers.

Covered by platform/chromium/fast/storage/serialized-script-value.html

  • bindings/v8/SerializedScriptValue.cpp:

LayoutTests:

Update serialized-script-value-expected results for the new SerializedScriptValue
wire format version. Add test cases for UChar string serialization to verify that
the UChar string data appears on an even-byte boundary in the wire format, and to
test reading string data from the previous wire format is backward-compatible.

  • platform/chromium/fast/storage/serialized-script-value-expected.txt:
  • platform/chromium/fast/storage/serialized-script-value.html:
8:25 PM Changeset in webkit [136623] by haraken@chromium.org
  • 7 edits in trunk/Source/WebCore

[V8] V8Binding::v8ExternalString() is redundant
https://bugs.webkit.org/show_bug.cgi?id=103979

Reviewed by Adam Barth.

v8String(), v8StringOrNull() and v8StringOrUndefined() are enough.
We can remove V8Binding::v8ExternalString().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrGetter):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::compileAndRunScript):

  • bindings/v8/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::compileScript):

  • bindings/v8/V8Binding.h:

(WebCore):
(WebCore::v8String):
(WebCore::v8StringOrNull):
(WebCore::v8StringOrUndefined):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

8:22 PM Changeset in webkit [136622] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Remove v8NonStringValueToWebCoreString() and v8NonStringValueToAtomicWebCoreString()
https://bugs.webkit.org/show_bug.cgi?id=103981

Reviewed by Adam Barth.

v8NonStringValueToWebCoreString() and v8NonStringValueToAtomicWebCoreString()
are equivalent to what StringResource does.

No tests. No change in behavior.

  • bindings/v8/V8Binding.cpp:
  • bindings/v8/V8Binding.h:

(WebCore::toWebCoreString):
(WebCore):
(WebCore::toWebCoreStringWithNullCheck):
(WebCore::toWebCoreStringWithUndefinedOrNullCheck):
(WebCore::toWebCoreAtomicString):
(WebCore::toWebCoreAtomicStringWithNullCheck):

  • bindings/v8/V8StringResource.h:

(WebCore::V8StringResource::V8StringResource):
(V8StringResource):

8:21 PM Changeset in webkit [136621] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Scroll adjustments while typing scroll off page, then bounce back.
https://bugs.webkit.org/show_bug.cgi?id=104045

Patch by Andrew Lo <anlo@rim.com> on 2012-12-04
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton & Jakob Petsovits.

Internal PR253845
The main frame's view should only be temporarily set to
not constrain scrolling to the content edge while the
scroll position is set at the end of the scroll animation.

Remove ensureFocusTextElementVisible from setSpannableTextAndRelativeCursor
in InputHandler since FrameSelection::revealSelection
already implements scroll adjustments due to typing.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::zoomBlock):
(BlackBerry::WebKit::WebPagePrivate::resetBlockZoom):

  • Api/WebPage_p.h:

(WebPagePrivate):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
(BlackBerry::WebKit::InputHandler::setSpannableTextAndRelativeCursor):

8:19 PM Changeset in webkit [136620] by andersca@apple.com
  • 35 edits in trunk/Source/WebKit2

Remove #ifs that are always true
https://bugs.webkit.org/show_bug.cgi?id=104080

Reviewed by Andreas Kling.

MAC_OS_X_VERSION_MIN_REQUIRED >= 1070 is always true, so remove all the #ifs.

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::initializeSandbox):
(WebKit::PluginProcess::platformInitialize):

  • Shared/DictionaryPopupInfo.cpp:

(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):

  • Shared/DictionaryPopupInfo.h:
  • Shared/mac/WebEventFactory.mm:

(WebKit::phaseForEvent):
(WebKit::momentumPhaseForEvent):

  • SharedWorkerProcess/mac/SharedWorkerProcessMac.mm:

(WebKit::initializeSandbox):
(WebKit::SharedWorkerProcess::platformInitialize):

  • UIProcess/API/mac/PDFViewController.mm:

(WebKit::PDFViewScrollView_scrollWheel):
(WebKit::PDFViewController::pdfKitBundle):

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::didPerformDictionaryLookup):
(WebKit::PageClientImpl::dismissDictionaryLookupPanel):
(WebKit::PageClientImpl::recordAutocorrectionResponse):
(WebKit::PageClientImpl::recommendedScrollbarStyleDidChange):

  • UIProcess/API/mac/WKView.mm:

(-[WKView displayIfNeeded]):
(-[WKView draggingUpdated:]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _intrinsicDeviceScaleFactor]):
(-[WKView _cacheWindowBottomCornerRect]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
(+[WKView hideWordDefinitionWindow]):

  • UIProcess/Launcher/mac/EnvironmentVariables.cpp:
  • UIProcess/Launcher/mac/EnvironmentVariables.h:

(EnvironmentVariables):

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::addDYLDEnvironmentAdditions):
(WebKit::createWebProcessServiceForWebKitDevelopment):
(WebKit):
(WebKit::tryPreexistingProcess):
(WebKit::createProcess):
(WebKit::ProcessLauncher::launchProcess):

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::shouldUsePlugin):
(WebKit::PluginInfoStore::reactivateInactivePlugin):

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::platformInitializePluginProcess):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::pageDidScroll):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::recordAutocorrectionResponse):
(WebKit::WebPageProxy::handleAlternativeTextUIResult):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/TextCheckerMac.mm:

(WebKit::initializeState):
(WebKit::TextChecker::getGuessesForWord):

  • UIProcess/mac/WKFullScreenWindowController.mm:

(convertRectToScreen):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

  • WebKit2Prefix.h:
  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue):

  • WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:
  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::shouldEraseMarkersAfterChangeSelection):

  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit):

  • WebProcess/WebPage/WebPage.h:

(WebPage):

  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupAtLocation):
(WebKit::WebPage::performDictionaryLookupForSelection):
(WebKit::WebPage::performDictionaryLookupForRange):

  • WebProcess/mac/SecItemShimMethods.mm:
  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::secItemResponse):

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

  • WebProcessService/WebProcessServiceMain.mm:

(main):

  • WebProcessServiceForWebKitDevelopment/WebProcessServiceForWebKitDevelopmentMain.mm:

(WebProcessServiceForWebKitDevelopmentEventHandler):
(main):

8:18 PM Changeset in webkit [136619] by inferno@chromium.org
  • 2 edits in trunk/Source/WebCore

Crash in WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode
https://bugs.webkit.org/show_bug.cgi?id=103515

Reviewed by Ryosuke Niwa.

|current| is weak node pointer that iterates in the hierarchy chain
between |highestAncestor| and |targetNode|. Script executed as part
of iframe onload event can blow away the nodes and we no longer have
|targetNode| in our descendants chain. So, we RefPtr |current| and bail
out when |targetNode| stops being a part of descendant chain.

Test blocked on https://bugs.webkit.org/show_bug.cgi?id=104044.

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):

8:18 PM Changeset in webkit [136618] by tasak@google.com
  • 1 edit
    5 adds in trunk/LayoutTests

Unreviewed, WebKit gardening. A rebaseline.

  • platform/chromium/media/track/opera/interfaces/TextTrack/addCue-expected.txt: Added.
8:16 PM Changeset in webkit [136617] by Bruno de Oliveira Abinader
  • 2 edits in trunk/Source/WebCore

Avoid repeated calls to decorationColor on RenderObject::getTextDecorationColors
https://bugs.webkit.org/show_bug.cgi?id=94131

Reviewed by Brent Fulgham.

Replaces repeated calls to decorationColor by adding a variable that reads the
return value from that function just once on each loop and gets used upon need.

This change won't affect text decoration behavior, so current tests suffice.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::getTextDecorationColors):

8:15 PM Changeset in webkit [136616] by hclam@chromium.org
  • 6 edits
    1 add in trunk/Source

[chromium] Implement cache eviction logic in ImageDecodingStore
https://bugs.webkit.org/show_bug.cgi?id=103480

Reviewed by James Robinson.

Source/WebCore:

This patch implements these features in the new image cache:

  • Least-recently-used eviction logic
  • Setting cache limit (default is 32MB)
  • Remove cache entries when ImageFrameGenerator is removed

New tests in ImageDecodingTestTest. Also covered by platform/chromium/virtual/deferred.

  • platform/graphics/chromium/ImageDecodingStore.cpp:

(WebCore::ImageDecodingStore::ImageDecodingStore):
(WebCore::ImageDecodingStore::~ImageDecodingStore):
Code to assert that everything is cleaned up.
(WebCore::ImageDecodingStore::lockCompleteCache):
(WebCore::ImageDecodingStore::unlockCache):
(WebCore::ImageDecodingStore::insertAndLockCache):
(WebCore::ImageDecodingStore::removeCacheIndexedByGenerator):
New method to remove all cache entries index by ImageFrameGenerator.
(WebCore):
(WebCore::ImageDecodingStore::setCacheLimitInBytes):
(WebCore::ImageDecodingStore::memoryUsageInBytes):
(WebCore::ImageDecodingStore::cacheEntries):
(WebCore::ImageDecodingStore::prune):
New code to implement LRU eviction logic.
(WebCore::ImageDecodingStore::insertCacheInternal):
New method to help new cache insertion. This is separately because it touches 3 containers.
(WebCore::ImageDecodingStore::removeFromCacheInternal):
New method to help remove a cache entry from containers.
(WebCore::ImageDecodingStore::removeFromCacheListInternal):
New helper method to help remove cache entry from doubly linked list.

  • platform/graphics/chromium/ImageDecodingStore.h:

(ImageDecodingStore):
(CacheEntry):
(WebCore::ImageDecodingStore::CacheEntry::createAndUse):
(WebCore::ImageDecodingStore::CacheEntry::CacheEntry):
(WebCore::ImageDecodingStore::CacheEntry::~CacheEntry):
(WebCore::ImageDecodingStore::CacheEntry::cacheKey):
(WebCore::ImageDecodingStore::CacheEntry::cachedImage):
(WebCore::ImageDecodingStore::CacheEntry::useCount):
(WebCore::ImageDecodingStore::CacheEntry::incrementUseCount):
(WebCore::ImageDecodingStore::CacheEntry::decrementUseCount):
(WebCore::ImageDecodingStore::CacheEntry::memoryUsageInBytes):
(WebCore::ImageDecodingStore::incrementMemoryUsage):
(WebCore::ImageDecodingStore::decrementMemoryUsage):
New helper methods.

  • platform/graphics/chromium/ImageFrameGenerator.cpp:

(WebCore::ImageFrameGenerator::~ImageFrameGenerator):

Source/WebKit/chromium:

Added ImageDecodingStoreTest for unit testing new image cache.

New tests:

ImageDecodingStoreTest.evictOneCache

Test eviction of one cache entry by setting a smaller cache limit.

ImageDecodingStoreTest.pruneOrderIsLeastRecentlyUsed

Test eviction order is least recently used.

ImageDecodingStoreTest.pruneCausedByInsertion

Test that eviction is triggered also by cache insertion.

ImageDecodingStoreTest.cacheInUseNotEvicted

Test that cache in use is not evicted.

ImageDecodingStoreTest.destroyImageFrameGenerator

Test that deleting a ImageFrameGenerator causes associated cache
entries to be removed.

  • WebKit.gypi:
  • tests/ImageDecodingStoreTest.cpp: Added.

(WebCore):
(ImageDecodingStoreTest):
(WebCore::ImageDecodingStoreTest::SetUp):
(WebCore::ImageDecodingStoreTest::TearDown):
(WebCore::ImageDecodingStoreTest::createCompleteImage):
(WebCore::ImageDecodingStoreTest::insertCache):
(WebCore::ImageDecodingStoreTest::lockCache):
(WebCore::ImageDecodingStoreTest::unlockCache):
(WebCore::ImageDecodingStoreTest::evictOneCache):
(WebCore::ImageDecodingStoreTest::isCacheAlive):
(WebCore::TEST_F):

8:05 PM Changeset in webkit [136615] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Style sharing: Allow sharing between elements with classes not referenced by any selectors.
<http://webkit.org/b/103925>

Reviewed by Antti Koivisto.

When looking for elements that can share style, instead of blindly rejecting candidates with
a different "class" attribute, check if it's actually referenced by any of the tracked style rules.
It's surprisingly common for web pages to have elements with classes to which no rules apply,
mediawiki content is especially good at this.

~2100 new sharing "hits" on <https://en.wikipedia.org/wiki/Steve_Jobs>.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement):

Don't bail early if the two elements have different return values for hasClass().

(WebCore::StyleResolver::classNamesAffectedByRules):

Helper function that returns whether a SpaceSplitString contains a class name referenced
by any style rules.

(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):

Make this a member function since we need access to m_features.classesInRules.

  • css/StyleResolver.h:

(StyleResolver):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::locateSharedStyle):

Cache whether the element we're resolving style for has a "class" attribute referenced by style rules.

8:01 PM Changeset in webkit [136614] by tasak@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, WebKit gardening.

  • platform/chromium/TestExpectations:

Updated css3/filters/effect-reference-hw.html's expectation.

8:01 PM Changeset in webkit [136613] by commit-queue@webkit.org
  • 20 edits
    1 copy
    3 adds in trunk/Source/WebCore

Refactor Media Control Elements to remove code duplication.
https://bugs.webkit.org/show_bug.cgi?id=101877

Patch by Silvia Pfeiffer <silviapf@chromium.org> on 2012-12-04
Reviewed by Eric Carlson.

Instead of having two different types of inheritance trees for
MediaControlElement and MediaControlInputElement, this
creates a stand-alone virtual class MediaControlElement that
provides the common functions: show(), hide(), isShowing(),
setMediaController(), displayType(), isMediaControlElement(),
shadowPseudoId(), mediaController(), setDisplayType().

The individual elements inherit from MediaControlElement and
either HTMLInputElement or HTMLDivElement. They extend/override
the base functions as appropriate.

As part of this, the RenderXXX classes mixed in between the media
controls in MediaControlElements.cpp are also moved to
rendering/RenderMediaControls.h/cpp to follow common code separation.

No new tests since this is just a refactoring.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:

Build files extended with new files.

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::textTracksIndexNotFound):
Replaced const with function, since it is used in multiple files.

  • html/shadow/MediaControlElementTypes.cpp: new file
  • html/shadow/MediaControlElementTypes.h: new file

Added new MediaControlElement class. Moved MediaControlDivElement and MediaControlInputElement
classes into these files from MediaControlElements.cpp/h. Moved MediaControlElementTypes enum
into these. Moved other media control element classes that are the basis for inheriting media
control elements into these (MediaControlTimeDisplayElement, MediaControlMuteButtonElement,
MediaControlSeekButtonElement, MediaControlVolumeSliderElement).

  • html/shadow/MediaControlElements.cpp:
  • html/shadow/MediaControlElements.h:

Removed common functions between media elements that are now in the common
base class MediaControlElement.
Also moved common base classes to MediaControlElementTypes.h/cpp

  • html/shadow/MediaControls.cpp:
  • html/shadow/MediaControls.h:

Renamed MediaControlVolumeSliderElement to MediaControlPanelVolumeSliderElement
to be consistent in inheritance tree. Updated copyright date.

  • html/shadow/MediaControlsApple.cpp:
  • html/shadow/MediaControlsApple.h:

Renamed MediaControlVolumeSliderElement to MediaControlPanelVolumeSliderElement
to be consistent in inheritance tree. Updated copyright dates.n

  • html/shadow/MediaControlsChromium.cpp:
  • html/shadow/MediaControlsChromium.h:

Renamed MediaControlVolumeSliderElement to MediaControlPanelVolumeSliderElement
to be consistent in inheritance tree.
Moved enclosure element definitions to common MediaControlElements.cpp/h
file through which different media elements are made available to different ports.

  • html/shadow/MediaControlsChromiumAndroid.cpp:
  • html/shadow/MediaControlsChromiumAndroid.h:

Moved enclosure for overlay button to MediaControlElements.cpp/h files
through which different media elements are made available to different ports.

  • rendering/RenderMediaControlElements.cpp: new file
  • rendering/RenderMediaControlElements.h: new file

Moved rendering classes for media control elements into these files from
MediaControlElements.cpp/h.

  • rendering/RenderThemeMac.mm:

Added new RenderMediaControlElements.h file.

  • rendering/RenderingAllInOne.cpp:

Added new RenderMediaControlEleemnt.cpp file.

7:53 PM Changeset in webkit [136612] by andersca@apple.com
  • 11 edits
    6 deletes in trunk/Source/WebKit2

Remove more Snow Leopard only code
https://bugs.webkit.org/show_bug.cgi?id=104079

Reviewed by Andreas Kling.

All of the SecKeychainItem code was Snow Leopard only.

  • Shared/mac/SecKeychainItemRequestData.cpp: Removed.
  • Shared/mac/SecKeychainItemRequestData.h: Removed.
  • Shared/mac/SecKeychainItemResponseData.cpp: Removed.
  • Shared/mac/SecKeychainItemResponseData.h: Removed.
  • UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h:
  • UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.mm:
  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

  • UIProcess/WebProcessProxy.messages.in:
  • UIProcess/mac/WebProcessProxyMac.mm:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
  • WebProcess/mac/KeychainItemShimMethods.h: Removed.
  • WebProcess/mac/KeychainItemShimMethods.mm: Removed.
  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::initializeShim):

  • WebProcess/mac/WebProcessShim.mm:
7:29 PM Changeset in webkit [136611] by andersca@apple.com
  • 15 edits in trunk/Source/WebKit2

Remove PageClient::didChangeScrollbarsForMainFrame
https://bugs.webkit.org/show_bug.cgi?id=104077

Reviewed by Andreas Kling.

The aforementioned function was only used to implement some Snow Leopard specific behavior that we no longer support.

  • UIProcess/API/gtk/PageClientImpl.cpp:
  • UIProcess/API/gtk/PageClientImpl.h:

(PageClientImpl):

  • UIProcess/API/mac/PageClientImpl.h:

(PageClientImpl):

  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/API/mac/WKView.mm:

(-[WKView viewWillMoveToWindow:]):

  • UIProcess/API/mac/WKViewInternal.h:
  • UIProcess/API/qt/raw/qrawwebview_p_p.h:
  • UIProcess/PageClient.h:

(PageClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didChangeScrollbarsForMainFrame):

  • UIProcess/efl/PageClientBase.cpp:

(WebKit):

  • UIProcess/efl/PageClientBase.h:

(PageClientBase):

  • UIProcess/qt/QtPageClient.h:
  • UIProcess/win/WebView.cpp:
  • UIProcess/win/WebView.h:

(WebView):

7:25 PM Changeset in webkit [136610] by fmalita@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening - skip use-href-update-crash.svg on Win.

  • platform/win/TestExpectations:
6:49 PM Changeset in webkit [136609] by kbr@google.com
  • 9 edits in trunk/Source

Associate URLs with GraphicsContext3D instances created for WebGL
https://bugs.webkit.org/show_bug.cgi?id=103793

Reviewed by Adam Barth.

Source/Platform:

  • Platform.gyp/Platform.gyp:

Allow WebURL.h to be included directly or indirectly from Platform.h.

  • chromium/public/WebGraphicsContext3D.h:

(Attributes):

Add top document's URL to context creation attributes.

Source/WebCore:

Pass down the URL of the topmost frame's document creating the
WebGL context to the platform layer through
GraphicsContext3D::Attributes.

Not feasible to write a layout test for this change; has no
user-visible effect. Tested manually with failure injection in
Chromium port.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::create):

Pass top document's URL in context creation attributes.

  • platform/chromium/support/GraphicsContext3DChromium.cpp:

(WebCore::GraphicsContext3D::create):

Pass URL through WebKit API.

  • platform/graphics/GraphicsContext3D.h:

(Attributes):

Add top document's URL to context creation attributes.

Source/WebKit/chromium:

  • WebKit.gyp:

Allow WebURL.h to be included directly or indirectly from Platform.h.

6:40 PM Changeset in webkit [136608] by yurys@chromium.org
  • 15 edits in trunk/Source

Web Inspector: simplify reportMemoryUsage signature
https://bugs.webkit.org/show_bug.cgi?id=104028

Reviewed by Vsevolod Vlasov.

Removed const& modifier from instrumented pointer type. Was const T* const&,
now it is const T*

Source/WebCore:

  • platform/graphics/NativeImagePtr.h:

(WebCore):

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::reportMemoryUsage):

Source/WTF:

  • wtf/MemoryInstrumentation.cpp:

(WTF::MemoryClassInfo::addRawBuffer):

  • wtf/MemoryInstrumentation.h:

(MemoryInstrumentation):
(WTF::MemoryInstrumentation::selectInstrumentationMethod):
(WTF::MemoryInstrumentation::reportObjectMemoryUsage):
(MemoryClassInfo):
(WTF::reportMemoryUsage):
(WTF::MemoryInstrumentation::addObjectImpl):
(WTF):

  • wtf/MemoryInstrumentationArrayBufferView.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationHashCountedSet.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationHashMap.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationHashSet.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationListHashSet.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationParsedURL.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationString.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationVector.h:

(WTF::reportMemoryUsage):

6:35 PM Changeset in webkit [136607] by tasak@google.com
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed, WebKit gardening.

  • platform/chromium-mac-snowleopard/fast/parser/document-write-ignores-later-network-bytes-expected.txt: Removed, rebaseline.
6:24 PM Changeset in webkit [136606] by fpizlo@apple.com
  • 10 edits in trunk

display-profiler-output should be able to show source code
https://bugs.webkit.org/show_bug.cgi?id=104073

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Modify the profiler database to store source code. For functions, we store the
function including the function signature.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::unlinkedCodeBlock):
(CodeBlock):

  • profiler/ProfilerBytecodes.cpp:

(JSC::Profiler::Bytecodes::Bytecodes):
(JSC::Profiler::Bytecodes::toJS):

  • profiler/ProfilerBytecodes.h:

(Bytecodes):
(JSC::Profiler::Bytecodes::sourceCode):

  • profiler/ProfilerDatabase.cpp:

(JSC::Profiler::Database::addBytecodes):
(JSC::Profiler::Database::ensureBytecodesFor):

  • profiler/ProfilerDatabase.h:

(Database):

  • runtime/CommonIdentifiers.h:
  • runtime/Executable.h:

(FunctionExecutable):
(JSC::FunctionExecutable::unlinkedExecutable):

Tools:

Display source code in the summary, using a one-line shortening.

  • Scripts/display-profiler-output:
5:40 PM Changeset in webkit [136605] by abarth@webkit.org
  • 42 edits in trunk/Source/WebCore

[V8] Rename V8DOMWrapper member functions to be more descriptive
https://bugs.webkit.org/show_bug.cgi?id=104069

Reviewed by Eric Seidel.

In addition to the renames, this patch also inline lookupDOMWrapper
into its callers.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateDomainSafeFunctionGetter):
(GenerateDomainSafeFunctionSetter):
(GenerateNormalAttrGetter):
(GenerateSingleConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateToV8Converters):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):

  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

  • bindings/v8/PageScriptDebugServer.cpp:

(WebCore::retrieveFrameWithGlobalObjectCheck):

  • bindings/v8/V8Binding.cpp:

(WebCore::toDOMWindow):
(WebCore::toScriptExecutionContext):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::clearForNavigation):
(WebCore::V8DOMWindowShell::installDOMWindow):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::create):

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):
(WebCore::V8DOMWrapper::setNativeInfo):
(WebCore::V8DOMWrapper::clearNativeInfo):
(WebCore::V8DOMWrapper::associateObjectWithWrapper):

  • bindings/v8/V8Initializer.cpp:

(WebCore::findFrame):

  • bindings/v8/V8NPObject.cpp:

(WebCore::createV8ObjectForNPObject):
(WebCore::forgetV8ObjectForNPObject):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::initializeContextIfNeeded):
(WebCore::WorkerScriptController::controllerForContext):

  • bindings/v8/custom/V8ArrayBufferCustom.cpp:

(WebCore::V8ArrayBuffer::constructorCallbackCustom):

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::wrapArrayBufferView):
(WebCore::constructWebGLArray):

  • bindings/v8/custom/V8AudioContextCustom.cpp:

(WebCore::V8AudioContext::constructorCallbackCustom):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCallbackCustom):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::eventAccessorGetter):
(WebCore::V8DOMWindow::eventAccessorSetter):
(WebCore::V8DOMWindow::toStringCallback):
(WebCore::V8DOMWindow::namedSecurityCheck):
(WebCore::V8DOMWindow::indexedSecurityCheck):
(WebCore::toV8):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallbackCustom):

  • bindings/v8/custom/V8HTMLDocumentCustom.cpp:

(WebCore::V8HTMLDocument::wrapInShadowObject):

  • bindings/v8/custom/V8HTMLImageElementConstructor.cpp:

(WebCore::v8HTMLImageElementConstructorCallback):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::createInjectedScriptHostV8Wrapper):
(WebCore::InjectedScriptManager::canAccessInspectedWindow):

  • bindings/v8/custom/V8IntentCustom.cpp:

(WebCore::V8Intent::constructorCallbackCustom):

  • bindings/v8/custom/V8LocationCustom.cpp:

(WebCore::V8Location::reloadAccessorGetter):
(WebCore::V8Location::replaceAccessorGetter):
(WebCore::V8Location::assignAccessorGetter):

  • bindings/v8/custom/V8MessageChannelCustom.cpp:

(WebCore::V8MessageChannel::constructorCallbackCustom):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::initMessageEventCallback):

  • bindings/v8/custom/V8MutationObserverCustom.cpp:

(WebCore::V8MutationObserver::constructorCallbackCustom):

  • bindings/v8/custom/V8ScriptProfileCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8ScriptProfileNodeCustom.cpp:

(WebCore::toV8):

  • bindings/v8/custom/V8WebKitPointCustom.cpp:

(WebCore::V8WebKitPoint::constructorCallbackCustom):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::constructorCallbackCustom):

5:39 PM Changeset in webkit [136604] by fmalita@chromium.org
  • 3 edits in trunk/LayoutTests

Unreviewed gardening - suppressing failing svg/custom/use-href-update-crash.svg on Mac and
Qt.

  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
5:35 PM Changeset in webkit [136603] by abarth@webkit.org
  • 10 edits in trunk/Source

[V8] Cleanup style in V8DOMWrapper
https://bugs.webkit.org/show_bug.cgi?id=104062

Reviewed by Kentaro Hara.

Source/WebCore:

This patch moves a number of functions from inside the class
declaration to below the class declaration. I've also inlined
domWrapperType into each of its callers and renamed a few functions.
A subsequent patch will improve the names of the remaining functions.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateToV8Converters):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::visitExternalArrays):

  • bindings/v8/V8Collection.h:

(WebCore::getNamedPropertyOfCollection):
(WebCore::getIndexedPropertyOfCollection):

  • bindings/v8/V8DOMWrapper.cpp:

(WebCore::V8DOMWrapper::instantiateDOMWrapper):
(WebCore::V8DOMWrapper::isWrapperOfType):

  • bindings/v8/V8DOMWrapper.h:

(V8DOMWrapper):
(WebCore::V8DOMWrapper::setWrapperClass):
(WebCore::V8DOMWrapper::setDOMWrapper):
(WebCore):
(WebCore::V8DOMWrapper::clearDOMWrapper):
(WebCore::V8DOMWrapper::lookupDOMWrapper):
(WebCore::V8DOMWrapper::createDOMWrapper):

  • bindings/v8/V8GCController.cpp:
  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::V8InspectorFrontendHost::showContextMenuCallback):

Source/WebKit/chromium:

  • src/WebBindings.cpp:

(WebKit::getRangeImpl):

5:32 PM Changeset in webkit [136602] by fpizlo@apple.com
  • 2 edits in trunk/Tools

display-profiler-output should not use reflective infocation to resolve command names

Rubber stamped by Mark Hahnenberg.

Reflection is amazing, but here it was just kind of a bit much.

  • Scripts/display-profiler-output:
5:26 PM Changeset in webkit [136601] by fpizlo@apple.com
  • 44 edits
    18 adds in trunk

JSC should be able to report profiling data associated with the IR dumps and disassembly
https://bugs.webkit.org/show_bug.cgi?id=102999

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Added a new profiler to JSC. It's simply called "Profiler" in anticipation of it
ultimately replacing the previous profiling infrastructure. This profiler counts the
number of times that a bytecode executes in various engines, and will record both the
counts and all disassembly and bytecode dumps, into a database that can be at any
time turned into either a JS object using any global object or global data of your
choice, or can be turned into a JSON string, or saved to a file.

Currently the only use of this is the new '-p <file>' flag to the jsc command-line.

The profiler is always compiled in and normally incurs no execution time cost, but is
only activated when you create a Profiler::Database and install it in
JSGlobalData::m_perBytecodeProfiler. From that point on, all code blocks will be
compiled along with disassembly and bytecode dumps stored into the Profiler::Database,
and all code blocks will have execution counts, which are also stored in the database.
The database will continue to keep information about code blocks alive even after they
are otherwise GC'd.

This currently still has some glitches, like the fact that it only counts executions
in the JITs. Doing execution counting in the LLInt might require a bit of a rethink
about how the counting is expressed - currently it is implicit in bytecode, so there
is no easy way to "turn it on" in the LLInt. Also, right now there is no information
recorded about OSR exits or out-of-line stubs. But, even so, it's quite cool, and
gives you a peek into what JSC is doing that would otherwise not be possible.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::~CodeBlock):

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::baselineVersion):

  • bytecode/CodeOrigin.cpp:

(JSC::InlineCallFrame::baselineCodeBlock):
(JSC):

  • bytecode/CodeOrigin.h:

(InlineCallFrame):

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::execute):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGDisassembler.cpp:

(JSC::DFG::Disassembler::dump):
(DFG):
(JSC::DFG::Disassembler::reportToProfiler):
(JSC::DFG::Disassembler::dumpHeader):
(JSC::DFG::Disassembler::append):
(JSC::DFG::Disassembler::createDumpList):

  • dfg/DFGDisassembler.h:

(Disassembler):
(JSC::DFG::Disassembler::DumpedOp::DumpedOp):
(DumpedOp):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::dumpCodeOrigin):
(JSC::DFG::Graph::dump):

  • dfg/DFGGraph.h:

(Graph):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGNode.h:

(Node):
(JSC::DFG::Node::hasExecutionCounter):
(JSC::DFG::Node::executionCounter):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JIT.cpp:

(JSC::JIT::JIT):
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompile):

  • jit/JIT.h:

(JIT):

  • jit/JITDisassembler.cpp:

(JSC::JITDisassembler::dump):
(JSC::JITDisassembler::reportToProfiler):
(JSC):
(JSC::JITDisassembler::dumpHeader):
(JSC::JITDisassembler::firstSlowLabel):
(JSC::JITDisassembler::dumpVectorForInstructions):
(JSC::JITDisassembler::dumpForInstructions):
(JSC::JITDisassembler::reportInstructions):

  • jit/JITDisassembler.h:

(JITDisassembler):
(DumpedOp):

  • jsc.cpp:

(CommandLine::CommandLine):
(CommandLine):
(printUsageStatement):
(CommandLine::parseArguments):
(jscmain):

  • profiler/ProfilerBytecode.cpp: Added.

(Profiler):
(JSC::Profiler::Bytecode::toJS):

  • profiler/ProfilerBytecode.h: Added.

(Profiler):
(Bytecode):
(JSC::Profiler::Bytecode::Bytecode):
(JSC::Profiler::Bytecode::bytecodeIndex):
(JSC::Profiler::Bytecode::description):
(JSC::Profiler::getBytecodeIndexForBytecode):

  • profiler/ProfilerBytecodes.cpp: Added.

(Profiler):
(JSC::Profiler::Bytecodes::Bytecodes):
(JSC::Profiler::Bytecodes::~Bytecodes):
(JSC::Profiler::Bytecodes::indexForBytecodeIndex):
(JSC::Profiler::Bytecodes::forBytecodeIndex):
(JSC::Profiler::Bytecodes::dump):
(JSC::Profiler::Bytecodes::toJS):

  • profiler/ProfilerBytecodes.h: Added.

(Profiler):
(Bytecodes):
(JSC::Profiler::Bytecodes::append):
(JSC::Profiler::Bytecodes::id):
(JSC::Profiler::Bytecodes::hash):
(JSC::Profiler::Bytecodes::size):
(JSC::Profiler::Bytecodes::at):

  • profiler/ProfilerCompilation.cpp: Added.

(Profiler):
(JSC::Profiler::Compilation::Compilation):
(JSC::Profiler::Compilation::~Compilation):
(JSC::Profiler::Compilation::addDescription):
(JSC::Profiler::Compilation::executionCounterFor):
(JSC::Profiler::Compilation::toJS):

  • profiler/ProfilerCompilation.h: Added.

(Profiler):
(Compilation):
(JSC::Profiler::Compilation::bytecodes):
(JSC::Profiler::Compilation::kind):

  • profiler/ProfilerCompilationKind.cpp: Added.

(WTF):
(WTF::printInternal):

  • profiler/ProfilerCompilationKind.h: Added.

(Profiler):
(WTF):

  • profiler/ProfilerCompiledBytecode.cpp: Added.

(Profiler):
(JSC::Profiler::CompiledBytecode::CompiledBytecode):
(JSC::Profiler::CompiledBytecode::~CompiledBytecode):
(JSC::Profiler::CompiledBytecode::toJS):

  • profiler/ProfilerCompiledBytecode.h: Added.

(Profiler):
(CompiledBytecode):
(JSC::Profiler::CompiledBytecode::originStack):
(JSC::Profiler::CompiledBytecode::description):

  • profiler/ProfilerDatabase.cpp: Added.

(Profiler):
(JSC::Profiler::Database::Database):
(JSC::Profiler::Database::~Database):
(JSC::Profiler::Database::addBytecodes):
(JSC::Profiler::Database::ensureBytecodesFor):
(JSC::Profiler::Database::notifyDestruction):
(JSC::Profiler::Database::newCompilation):
(JSC::Profiler::Database::toJS):
(JSC::Profiler::Database::toJSON):
(JSC::Profiler::Database::save):

  • profiler/ProfilerDatabase.h: Added.

(Profiler):
(Database):

  • profiler/ProfilerExecutionCounter.h: Added.

(Profiler):
(ExecutionCounter):
(JSC::Profiler::ExecutionCounter::ExecutionCounter):
(JSC::Profiler::ExecutionCounter::address):
(JSC::Profiler::ExecutionCounter::count):

  • profiler/ProfilerOrigin.cpp: Added.

(Profiler):
(JSC::Profiler::Origin::Origin):
(JSC::Profiler::Origin::dump):
(JSC::Profiler::Origin::toJS):

  • profiler/ProfilerOrigin.h: Added.

(JSC):
(Profiler):
(Origin):
(JSC::Profiler::Origin::Origin):
(JSC::Profiler::Origin::operator!):
(JSC::Profiler::Origin::bytecodes):
(JSC::Profiler::Origin::bytecodeIndex):
(JSC::Profiler::Origin::operator!=):
(JSC::Profiler::Origin::operator==):
(JSC::Profiler::Origin::hash):
(JSC::Profiler::Origin::isHashTableDeletedValue):
(JSC::Profiler::OriginHash::hash):
(JSC::Profiler::OriginHash::equal):
(OriginHash):
(WTF):

  • profiler/ProfilerOriginStack.cpp: Added.

(Profiler):
(JSC::Profiler::OriginStack::OriginStack):
(JSC::Profiler::OriginStack::~OriginStack):
(JSC::Profiler::OriginStack::append):
(JSC::Profiler::OriginStack::operator==):
(JSC::Profiler::OriginStack::hash):
(JSC::Profiler::OriginStack::dump):
(JSC::Profiler::OriginStack::toJS):

  • profiler/ProfilerOriginStack.h: Added.

(JSC):
(Profiler):
(OriginStack):
(JSC::Profiler::OriginStack::OriginStack):
(JSC::Profiler::OriginStack::operator!):
(JSC::Profiler::OriginStack::size):
(JSC::Profiler::OriginStack::fromBottom):
(JSC::Profiler::OriginStack::fromTop):
(JSC::Profiler::OriginStack::isHashTableDeletedValue):
(JSC::Profiler::OriginStackHash::hash):
(JSC::Profiler::OriginStackHash::equal):
(OriginStackHash):
(WTF):

  • runtime/CommonIdentifiers.h:
  • runtime/ExecutionHarness.h:

(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):

  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::~JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/Options.h:

(JSC):

Source/WTF:

Made some minor changes to support the new profiler. FileOutputStream now has an
open() method, and DataLog uses it. StringPrintStream has a reset() method, which
allows you to reuse the same StringPrintStream for creating multiple strings.
SegmentedVector now has a const operator[]. And, WTFString now can do fromUTF8() on
a CString directly.

  • wtf/DataLog.cpp:

(WTF::initializeLogFileOnce):

  • wtf/FilePrintStream.cpp:

(WTF::FilePrintStream::open):
(WTF):

  • wtf/FilePrintStream.h:
  • wtf/SegmentedVector.h:

(WTF::SegmentedVector::at):
(SegmentedVector):
(WTF::SegmentedVector::operator[]):

  • wtf/StringPrintStream.cpp:

(WTF::StringPrintStream::reset):
(WTF):

  • wtf/StringPrintStream.h:

(StringPrintStream):

  • wtf/text/WTFString.cpp:

(WTF::String::fromUTF8):
(WTF):

  • wtf/text/WTFString.h:

(String):

Tools:

Added a tool that allows you to grok the output from JSC's new profiler. Currently,
this still gets confused a bit about the execution counts of a method running
standalone versus a method running inlined, but other than that, it's pretty cool.
See the attached "sampling profiling session" attached to the bug to see it in
action.

Also had to feed EFL's build system.

  • DumpRenderTree/efl/CMakeLists.txt:
  • Scripts/display-profiler-output: Added.
5:18 PM Changeset in webkit [136600] by senorblanco@chromium.org
  • 4 edits in trunk

[chromium] Turn on the new Skia mask blur algorithm.
https://bugs.webkit.org/show_bug.cgi?id=103906

Reviewed by Adrienne Walker.

Source/WebKit/chromium:

  • skia_webkit.gyp:

LayoutTests:

  • platform/chromium/TestExpectations:
5:11 PM Changeset in webkit [136599] by yurys@chromium.org
  • 14 edits in trunk/Source

Unreviewed, rolling out r136597.
http://trac.webkit.org/changeset/136597
https://bugs.webkit.org/show_bug.cgi?id=104065

broke Windows compilation (Requested by yurys on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-12-04

Source/WebCore:

  • platform/graphics/NativeImagePtr.h:

(WebCore):

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::reportMemoryUsage):

Source/WTF:

  • wtf/MemoryInstrumentation.cpp:

(WTF::MemoryClassInfo::addRawBuffer):

  • wtf/MemoryInstrumentation.h:

(MemoryInstrumentation):
(WTF::MemoryInstrumentation::selectInstrumentationMethod):
(WTF::MemoryInstrumentation::reportObjectMemoryUsage):
(MemoryClassInfo):
(WTF::reportMemoryUsage):
(WTF::MemoryInstrumentation::addObjectImpl):
(WTF):

  • wtf/MemoryInstrumentationArrayBufferView.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationHashCountedSet.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationHashMap.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationHashSet.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationListHashSet.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationParsedURL.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationString.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationVector.h:

(WTF::reportMemoryUsage):

5:05 PM Changeset in webkit [136598] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

[WebKit2] WKWebProcessPlugInBrowserContextControllers should be treated as type WKBrowsingContextControllerType for encoding purposes
https://bugs.webkit.org/show_bug.cgi?id=104063

Reviewed by Sam Weinig.

Objective-C message graphs can include browsing context controller
objects, which are decoded as WKWebProcessPlugInBrowserContextControllers
in the web process plug-in and as WKBrowsingContextControllers in the UI
process. Ensure we correctly encode WKWebProcessPlugInBrowserContextControllers
by treating them as type WKBrowsingContextControllerType.

  • Shared/mac/ObjCObjectGraphCoders.mm:

(WebKit::typeFromObject):

4:56 PM Changeset in webkit [136597] by yurys@chromium.org
  • 14 edits in trunk/Source

Web Inspector: simplify reportMemoryUsage signature
https://bugs.webkit.org/show_bug.cgi?id=104028

Reviewed by Vsevolod Vlasov.

Removed const& modifier from instrumented pointer type. Was const T* const&,
now it is const T*

Source/WebCore:

  • platform/graphics/NativeImagePtr.h:

(WebCore):

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::reportMemoryUsage):

Source/WTF:

  • wtf/MemoryInstrumentation.cpp:

(WTF::MemoryClassInfo::addRawBuffer):

  • wtf/MemoryInstrumentation.h:

(MemoryInstrumentation):
(WTF::MemoryInstrumentation::selectInstrumentationMethod):
(WTF::MemoryInstrumentation::reportObjectMemoryUsage):
(MemoryClassInfo):
(WTF::reportMemoryUsage):
(WTF::MemoryInstrumentation::addObjectImpl):
(WTF):

  • wtf/MemoryInstrumentationArrayBufferView.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationHashCountedSet.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationHashMap.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationHashSet.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationListHashSet.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationParsedURL.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationString.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationVector.h:

(WTF::reportMemoryUsage):

4:53 PM Changeset in webkit [136596] by roger_fong@apple.com
  • 2 edits
    2 adds in trunk/LayoutTests

Unreviewed. Add Windows specific results for some tests following r136558 and r136560.

Tests are indeed passing. The output is just slightly different on Windows.

  • platform/win/TestExpectations:
  • platform/win/fast/css/image-set-value-not-removed-crash-expected.txt: Added.
  • platform/win/fast/images/crossfade-client-not-removed-crash-expected.txt: Added.
4:51 PM Changeset in webkit [136595] by abarth@webkit.org
  • 6 edits in trunk/Source/WebCore

[V8] V8DOMWrapper shouldn't know about NodeFilter
https://bugs.webkit.org/show_bug.cgi?id=104057

Reviewed by Kentaro Hara.

This patch just moves this code into V8Bindings.h, which is where we
have our other type conversion functions. It's too bad that we still
need to special case NodeFilter, but fixing that is going to be a bit
more work.

  • bindings/scripts/CodeGeneratorV8.pm:

(JSValueToNative):

  • bindings/v8/V8Binding.cpp:

(WebCore::toNodeFilter):
(WebCore):

  • bindings/v8/V8Binding.h:

(WebCore):

  • bindings/v8/V8DOMWrapper.cpp:
  • bindings/v8/V8DOMWrapper.h:

(WebCore):
(V8DOMWrapper):

4:51 PM ExportingSymbols edited by wangxianzhu@chromium.org
Update another place about WebKit2.def.in (diff)
4:49 PM Changeset in webkit [136594] by Simon Fraser
  • 18 edits
    1 delete in trunk/Source

Show a mini visualizer for the tile cache tiles
https://bugs.webkit.org/show_bug.cgi?id=104053

Reviewed by Beth Dakin.

Source/WebCore:

Replace the current red/green/yellow scrolling indicator with a
mini map of the tile cache that shows the current tiles, and the
visible rect.

Visibility is controlled via a new preference.

  • WebCore.exp.in: Add Settings::setShowTiledScrollingIndicator(bool),

and remove ScrollingTree::setDebugRootLayer(CALayer*)

  • WebCore.xcodeproj/project.pbxproj: Remove ScrollingTreeMac.mm which

is no longer needed; it just contained debug layer stuff.

  • page/Settings.cpp:

(WebCore::Settings::Settings): Support the new setting.
(WebCore::Settings::setShowTiledScrollingIndicator):

  • page/Settings.h:

(WebCore::Settings::showTiledScrollingIndicator):

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::commitNewTreeState): We no longer update the debug
indicator on tree commit.

  • page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::hasWheelEventHandlers): Needed for the tiled
scrolling indicator.
(ScrollingTree):

  • page/scrolling/mac/ScrollingCoordinatorMac.mm:

(WebCore::ScrollingCoordinatorMac::commitTreeState): Tell the TiledBacking
about the current scrolling mode.

  • page/scrolling/mac/ScrollingTreeMac.mm: Removed.
  • platform/graphics/TiledBacking.h: Add functions to set the indicator scrolling

mode, and to get the tiled scrolling indicator layer. This has to be parented by
the DrawingArea, to ensure that it's in front of all other layers.

  • platform/graphics/ca/mac/TileCache.h:

(WebCore::TileCache::scale): Exposed for the indicator drawing code to use.

  • platform/graphics/ca/mac/TileCache.mm:

(-[WebTileCacheMapLayer init]): The indicator has a sublayer which renders the
visible rect frame, owned by it.
(-[WebTileCacheMapLayer drawInContext:]):
(WebCore::TileCache::TileCache): The indicator mode has to be stored here,
since it can be pushed down before we have an indicator layer.
(WebCore::TileCache::~TileCache): Clear the TileCache on the indicator layer, which
may outlive us.
(WebCore::TileCache::revalidateTiles): Call updateTileCoverageMap().
(WebCore::TileCache::updateTileCoverageMap): Resize the indicator layer to fit
within the window, and update the indicator color.
(WebCore::TileCache::tiledScrollingIndicatorLayer): Create and initialize the layer.
(WebCore::TileCache::setScrollingModeIndication):
(WebCore::TileCache::drawTileMapContents): Draw small white rects for the tiles over
an translucent gray background.

Source/WebKit2:

Plumb through a preference that controls the visibility of a tiled
scrolling indicator, and parent that layer in the TiledCoreAnimationDrawingArea.

  • Shared/WebPreferencesStore.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetTiledScrollingIndicatorVisible):
(WKPreferencesGetTiledScrollingIndicatorVisible):

  • UIProcess/API/C/WKPreferencesPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::mainFrameTiledBacking):
(WebKit::TiledCoreAnimationDrawingArea::updateDebugInfoLayer):

4:43 PM Changeset in webkit [136593] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt: fix total number of tests computed in the result summary
https://bugs.webkit.org/show_bug.cgi?id=104061

Unreviewed, build fix.

One of the recent changes to the resultsummary refactoring caused
us to not include the number of skipped tests in the total number
of tests, throwing off the totals printed in print_one_line_summary().

Unfortunately, given the current state of the code it is difficult
to construct an accurate unit test for this. I have verified the
fix by hand, and will write a test once the remaining refactoring
patches land, at which point it will be trivial to test it.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._prepare_lists):

4:36 PM Changeset in webkit [136592] by dgrogan@chromium.org
  • 7 edits in trunk/Source

Source/WebCore: IndexedDB: Propagate more leveldb errors to IDBIndex and IDBObjectStore
https://bugs.webkit.org/show_bug.cgi?id=103782

Reviewed by Tony Chang.

index.get[Key]() and objectStore.get() will receive more error events.

  • Modules/indexeddb/IDBBackingStore.cpp:

(WebCore::IDBBackingStore::getRecord):
(WebCore::versionExists):
(WebCore::IDBBackingStore::findKeyInIndex):
(WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStore::keyExistsInIndex):

  • Modules/indexeddb/IDBBackingStore.h:

(IDBBackingStore):

  • Modules/indexeddb/IDBIndexBackendImpl.cpp:

(WebCore::IDBIndexBackendImpl::getInternal):
(WebCore::IDBIndexBackendImpl::getKeyInternal):

  • Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:

(WebCore::IDBObjectStoreBackendImpl::getInternal):
(WebCore):

Source/WebKit/chromium: Unreviewed. Rolled DEPS.

Patch by Stephen White <senorblanco@chromium.org> on 2012-12-04

  • DEPS:
4:32 PM Changeset in webkit [136591] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt is not returning the exit status properly
https://bugs.webkit.org/show_bug.cgi?id=103830

Unreviewed, build fix.

The fix in r136474 wasn't quite right either, and would return
the correct exceptional status, but not the correct failing status.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:
4:32 PM Changeset in webkit [136590] by haraken@chromium.org
  • 3 edits in trunk/Source/WebCore

[V8] Remove IntegerCache::m_initialized
https://bugs.webkit.org/show_bug.cgi?id=103978

Reviewed by Adam Barth.

Thanks to r136479, we can now initialize V8 integers in IntegerCache's
constructor. We can remove IntegerCache::m_initialized, which slightly
improves performance.

[Bindings/scroll-top.html in Chromium/Linux]
Before this patch: 285 runs/sec, 281 runs/sec, 281 runs/sec, 280 runs/sec
After this patch : 290 runs/sec, 291 runs/sec, 297 runs/sec, 291 runs/sec

No tests. No change in behavior.

  • bindings/v8/V8ValueCache.cpp:

(WebCore::IntegerCache::IntegerCache):
(WebCore::IntegerCache::~IntegerCache):

  • bindings/v8/V8ValueCache.h:

(IntegerCache):
(WebCore::IntegerCache::v8Integer):
(WebCore::IntegerCache::v8UnsignedInteger):
(WebCore):

4:27 PM Changeset in webkit [136589] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Replace String::New("symbol") with String::NewSymbol("symbol")
https://bugs.webkit.org/show_bug.cgi?id=103989

Reviewed by Adam Barth.

In V8, a symbol lookup is faster than a string lookup. We should use
String::NewSymbol("symbol") for symbols.

No tests. No change in behavior.

  • bindings/v8/custom/V8DeviceMotionEventCustom.cpp:
  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::typeCallback):
(WebCore::V8InjectedScriptHost::functionDetailsCallback):
(WebCore::getJSListenerFunctions):

  • bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:

(WebCore::populateContextMenuItems):

4:25 PM Changeset in webkit [136588] by jchaffraix@webkit.org
  • 15 edits in trunk

[CSS Grid Layout] Implement CSS parsing and handling for <track-minmax>
https://bugs.webkit.org/show_bug.cgi?id=103799

Reviewed by Tony Chang.

Source/WebCore:

This change adds support for:
<track-minmax> => minmax( <track-breadth> , <track-breadth> ) | auto | <track-breadth>
(note that we already supported auto | <track-breadth>).

The change is mostly mechanical, the only newness is that GridTrackSize was updated to
hold 2 Lengths internally and we map the single Length case to 2 by duplicating the value
as this matches the rendering algorithm in the spec.

Tests: fast/css-grid-layout/grid-columns-rows-get-set-multiple.html

fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridTrackBreadth):
Changed the function to do the conversion of one track breadth (one Length).
This was forgotten in the preparatory change in bug 103703.

(WebCore::valueForGridTrackMinMax):
Convert the value back using valueForGridTrackBreadth.

  • css/CSSFunctionValue.cpp:

(WebCore::CSSFunctionValue::CSSFunctionValue):

  • css/CSSFunctionValue.h:

(WebCore::CSSFunctionValue::create):
(CSSFunctionValue):
Added a new constructor. This enables us to return minmax(..., ...) when queried
from JavaScript. I couldn't find a better way to serialize inside CSSComputedStyleDeclaration
so that it properly match the function output.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseGridTrackMinMax):
Added parsing for the new syntax. We convert the 2 values into a Pair if we manage to
parse both values correctly.

  • css/StyleResolver.cpp:

(WebCore::createGridTrackMinMax):
Updated to handle a Pair - for minmax - and set the 2 values on GridTrackSize.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computedUsedBreadthOfGridTracks):
Updated to check the style. For now, we don't handle minmax values.

  • rendering/style/GridTrackSize.h:

(WebCore::GridTrackSize::GridTrackSize):
(WebCore::GridTrackSize::length):
(WebCore::GridTrackSize::setLength):
(WebCore::GridTrackSize::minTrackBreadth):
(WebCore::GridTrackSize::maxTrackBreadth):
(WebCore::GridTrackSize::setMinMax):
(WebCore::GridTrackSize::operator==):
Updated the class to handle minmax values. This means that we now always store
2 values (the <length> case being a subset of minmax, however we kept the distinction
to be able to reconstruct a <length> for getComputedStyle).

LayoutTests:

  • fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple.html:
  • fast/css-grid-layout/grid-columns-rows-get-set.html:
  • fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:
  • fast/css-grid-layout/resources/grid-columns-rows-get-set.js:

Extended the following tests to cover the new grammar.

4:24 PM ExportingSymbols edited by tony@chromium.org
(diff)
4:23 PM ExportingSymbols edited by tony@chromium.org
Fix links to inline annotation source files. (diff)
4:20 PM ExportingSymbols edited by wangxianzhu@chromium.org
Update the content about WebKit2.def.in. (diff)
4:06 PM Changeset in webkit [136587] by ojan@chromium.org
  • 4 edits in trunk/Websites/bugs.webkit.org

Use sticky positioning for the code review toolbar
https://bugs.webkit.org/show_bug.cgi?id=104056

Reviewed by Adam Barth.

This simplifies the code and gives a nicer user-experience.
Also, while here, I fixed up the CSS to not have toolbar items
overlap when you make the window too small.

  • PrettyPatch/PrettyPatch.rb:
  • code-review-test.html:
  • code-review.js:
3:49 PM Changeset in webkit [136586] by fmalita@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening - add missing js-test-pre.js include to avoid use-href-update-crash.svg
failures on platforms that do not define gc().

  • svg/custom/use-href-update-crash.svg:
3:41 PM Changeset in webkit [136585] by dpranke@chromium.org
  • 4 edits in trunk/Tools

nrwt: make paths and test_names passed arguments in Manager._prepare_lists et al
https://bugs.webkit.org/show_bug.cgi?id=104047

Reviewed by Eric Seidel.

The code becomes cleaner if we are just passing values around rather
than hanging them off the manager object, helps move _prepare_lists()
to a pure function, and is needed to eventually make the
result_summary object something returned from runner.run_tests()
(note that two more patches are needed for that to happen).

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager.init):
(Manager._http_tests):
(Manager._prepare_lists):
(Manager.needs_servers):
(Manager._set_up_run):
(Manager.run):
(Manager._run_tests):
(Manager._upload_json_files):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.test_needs_servers.get_manager):
(ManagerTest.test_needs_servers):
(ManagerTest.integration_test_needs_servers.get_manager):
(ManagerTest.integration_test_needs_servers):
(ManagerTest.test_look_for_new_crash_logs.get_manager):
(ManagerTest):
(ManagerTest.test_look_for_new_crash_logs):

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:

(JSONLayoutResultsGenerator.init):
(JSONLayoutResultsGenerator._get_modifier_char):

3:04 PM Changeset in webkit [136584] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebCore

parser* methods in ContainerNode should not support DocumentFragment
https://bugs.webkit.org/show_bug.cgi?id=103965

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-12-04
Reviewed by Darin Adler.

Only parserInsertBefore ever supported DocumentFragment and this feature
is never used. It appears this code ended up in parserInsertBefore when
it was created as a copy of insertBefore that didn't fire events. This
patch removes that code and adds assertions that we never pass
DocumentFragments since doing so would cause a corrupted tree as we never
check checkAcceptChild or do other validation in the parser methods.

No new tests, just refactoring.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::parserInsertBefore):
(WebCore::ContainerNode::parserRemoveChild):
(WebCore::ContainerNode::parserAppendChild):

3:01 PM Changeset in webkit [136583] by abarth@webkit.org
  • 4 edits in trunk/Tools

commit-queue can get stuck with a local commit
https://bugs.webkit.org/show_bug.cgi?id=104032

Reviewed by Dirk Pranke.

Previously the commit-queue would only clean down to HEAD. If the
commit-queue gets interrupted in the middle of a commit (e.g., after
the local commit but before the dcommit), then it can end up with a
patch locally committed. That patch will then prevent the commit-queue
from functioning.

This patch teaches the commit-queue to clean down to the merge base,
which will remove any local commits.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.working_directory_is_clean):
(Git.clean_working_directory):

  • Scripts/webkitpy/tool/commands/roll_unittest.py:
  • Scripts/webkitpy/tool/steps/commit.py:

(Commit._commit_warning):
(Commit.run):

2:55 PM Changeset in webkit [136582] by dpranke@chromium.org
  • 6 edits in trunk/Tools

nrwt: store only the total number of tests in the result summary
https://bugs.webkit.org/show_bug.cgi?id=103963

Reviewed by Ryosuke Niwa.

The result summary only needs the total number of tests that will
be run (including repetitions) in order to provide the correct stats;
it doesn't actually need to know how many unique tests there are, or
or how many repetitions there are.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:

(LayoutTestRunnerTests._result_summary):
(LayoutTestRunnerTests.test_update_summary_with_result):

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._prepare_lists):
(Manager.run):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.test_look_for_new_crash_logs):
(ResultSummaryTest.get_result_summary):

  • Scripts/webkitpy/layout_tests/models/result_summary.py:

(ResultSummary.init):

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(Testprinter.get_result_summary):

2:54 PM Changeset in webkit [136581] by dpranke@chromium.org
  • 2 edits in trunk/Tools

nrwt: do less work when ctrl-c'ed
https://bugs.webkit.org/show_bug.cgi?id=103961

Reviewed by Ryosuke Niwa.

Do less work when we are ctrl-c'ed, because the statistics aren't
that useful anyway. While we're at it, modify summarize_results
to be aware that we don't always retry results (instead of pretending
that the retry produced the same results the initial run did).

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(summarize_results):
(Manager.run):

2:51 PM Changeset in webkit [136580] by dpranke@chromium.org
  • 7 edits in trunk/Tools

nrwt: result summaries should not require a list of tests to skip
https://bugs.webkit.org/show_bug.cgi?id=103951

Reviewed by Ryosuke Niwa.

We shouldn't really be passing a list of tests to skip to the
ResultSummary objects; they should be handled like any other
test result as much as possible.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner_unittest.py:

(LayoutTestRunnerTests._result_summary):
(LayoutTestRunnerTests.test_update_summary_with_result):

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._prepare_lists):
(Manager.run):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ManagerTest.test_look_for_new_crash_logs):
(ResultSummaryTest.get_result_summary):

  • Scripts/webkitpy/layout_tests/models/result_summary.py:

(ResultSummary.init):

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectations):

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(Testprinter.get_result_summary):

2:50 PM Changeset in webkit [136579] by dpranke@chromium.org
  • 8 edits in trunk/Tools

nrwt: derive per-thread, per-worker stats from result summaries
https://bugs.webkit.org/show_bug.cgi?id=103943

Reviewed by Ojan Vafai.

This patch changes the manager and printing code to pull more
information from the ResultSummary object rather than tracking
additional statistics on the side. This allows us to consolidate
a bunch of logic and remove a bunch of free-floating lists and dicts of
of values. We add the shard_name and worker_name to each TestResult,
and then modify print_timing_statistics() and upload_json_files()
to just need the result summaries.

Note that this patch also changes the timing statistics slightly
so that the individual test times are the times to run just the
tests themselves (TestResult.test_run_time) and do not include the
times taken to run the ref tests, compute diffs, etc. The aggregated
per-worker and per-shard statistics still use the total time to
process each test (TestResult.total_run_time).

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner.init):
(LayoutTestRunner.run_tests):
(LayoutTestRunner._handle_finished_test_list):
(LayoutTestRunner._handle_finished_test):
(Worker.handle):
(Worker._run_test):

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(summarize_results):
(Manager.run):
(Manager._upload_json_files):

  • Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:

(ResultSummaryTest.summarized_results):

  • Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:

(JSONLayoutResultsGenerator.init):
(JSONLayoutResultsGenerator._get_test_timing):

  • Scripts/webkitpy/layout_tests/models/test_results.py:

(TestResult.init):

  • Scripts/webkitpy/layout_tests/views/printing.py:

(Printer.print_results):
(Printer._print_timing_statistics):
(Printer):
(Printer._print_worker_statistics):
(Printer._print_aggregate_test_statistics):
(Printer._print_individual_test_times):
(Printer._print_directory_timings):

  • Scripts/webkitpy/layout_tests/views/printing_unittest.py:

(Testprinter.test_print_unexpected_results.get_unexpected_results):
(Testprinter):

2:47 PM Changeset in webkit [136578] by ojan@chromium.org
  • 3 edits in trunk/Websites/bugs.webkit.org

Properly create the header links in the code review tool
https://bugs.webkit.org/show_bug.cgi?id=104037

Reviewed by Adam Barth.

Right now, we just prepend "header" to the two existing links and change
the first link to point to the header. The problem is that jQuery's prepend
method just prepends to each item in the jQuery object instead of adding
the item to the beginning of the list as this code assumed.

  • code-review-test.html:
  • code-review.js:
2:44 PM Changeset in webkit [136577] by dpranke@chromium.org
  • 2 edits in trunk/Source/WebCore

Simplify ShadowRoot::cloneNode(bool,ExceptionCode)
https://bugs.webkit.org/show_bug.cgi?id=103928

Patch by Elliott Sprehn <Elliott Sprehn> on 2012-12-04
Reviewed by Dimitri Glazkov.

ShadowRoot can never be cloned and ShadowRoot::cloneNode(bool) always
returns null so there's no reason to have code in the cloneNode method
for script that acts as if it may not return null.

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::cloneNode):

2:43 PM Changeset in webkit [136576] by eae@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed, mark css3/filters/effect-reference-hw.html as failing rather than crashing.

  • platform/chromium/TestExpectations:
2:43 PM Changeset in webkit [136575] by dpranke@chromium.org
  • 5 edits in trunk/Source/WebCore

setIsInTopLayer is not really a setter
https://bugs.webkit.org/show_bug.cgi?id=103912

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-12-04
Reviewed by Eric Seidel.

Element::setInTopLayer isn't just a setter, it also adds the element
to the top layer vector in the document which changes it's display and
causes a reattach.

To make this more obvious make HTMLDialogElement use the methods on
Document and make those update the state boolean.

There also doesn't seem to be any reason for setInTopLayer
or isInTopLayer to be virtual, it appears it was a typo.

No new tests, just refactoring.

  • dom/Document.cpp:

(WebCore::Document::addToTopLayer):
(WebCore::Document::removeFromTopLayer):

  • dom/Element.cpp:

(WebCore::Element::setIsInTopLayer):

  • dom/Element.h:
  • html/HTMLDialogElement.cpp:

(WebCore::HTMLDialogElement::close):
(WebCore::HTMLDialogElement::showModal):

2:42 PM Changeset in webkit [136574] by dpranke@chromium.org
  • 7 edits in trunk/Source/WebCore

Automatically handle suspend and resume of post attach callbacks
https://bugs.webkit.org/show_bug.cgi?id=103910

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-12-04
Reviewed by Eric Seidel.

Use RAII to handle suspend and resume of post attach callbacks since
they should always be called in pairs.

No new tests, just refactoring.

  • dom/ContainerNode.h:

(PostAttachCallbackDisabler):
(WebCore::PostAttachCallbackDisabler::PostAttachCallbackDisabler):
(WebCore::PostAttachCallbackDisabler::~PostAttachCallbackDisabler):
(ContainerNode):

  • dom/Document.cpp:

(WebCore::Document::recalcStyle):

  • dom/Element.cpp:

(WebCore::Element::attach):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::attach):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::attach):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::attach):
(WebCore):

2:42 PM Changeset in webkit [136573] by dpranke@chromium.org
  • 5 edits in trunk/Source/WebCore

createRareData should return a PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=103851

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-12-04
Reviewed by Eric Seidel.

createRareData should return a PassOwnPtr, not an OwnPtr since it's
transfering ownership.

  • dom/Element.cpp:

(WebCore::Element::createRareData):

  • dom/Element.h:

(Element):

  • dom/Node.cpp:

(WebCore::Node::createRareData):

  • dom/Node.h:
2:30 PM Changeset in webkit [136572] by fpizlo@apple.com
  • 20 edits
    1 move
    2 adds
    2 deletes in trunk/Source

Rename Profiler to LegacyProfiler
https://bugs.webkit.org/show_bug.cgi?id=104031

Rubber stamped by Mark Hahnenberg

Source/JavaScriptCore:

Make room in the namespace for https://bugs.webkit.org/show_bug.cgi?id=102999.

  • API/JSProfilerPrivate.cpp:

(JSStartProfiling):
(JSEndProfiling):

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • interpreter/Interpreter.cpp:

(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):

  • jit/JIT.h:
  • jit/JITCode.h:
  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:

(JSC):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • profiler/LegacyProfiler.cpp: Added.

(JSC):
(JSC::LegacyProfiler::profiler):
(JSC::LegacyProfiler::startProfiling):
(JSC::LegacyProfiler::stopProfiling):
(JSC::dispatchFunctionToProfiles):
(JSC::LegacyProfiler::willExecute):
(JSC::LegacyProfiler::didExecute):
(JSC::LegacyProfiler::exceptionUnwind):
(JSC::LegacyProfiler::createCallIdentifier):
(JSC::createCallIdentifierFromFunctionImp):

  • profiler/LegacyProfiler.h: Added.

(JSC):
(LegacyProfiler):
(JSC::LegacyProfiler::currentProfiles):

  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::addParentForConsoleStart):

  • profiler/ProfileNode.cpp:
  • profiler/Profiler.cpp: Removed.
  • profiler/Profiler.h: Removed.
  • runtime/JSGlobalData.h:

(JSC):
(JSC::JSGlobalData::enabledProfiler):
(JSGlobalData):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::~JSGlobalObject):

Source/WebCore:

Just renaming, no new tests.

  • ForwardingHeaders/profiler/LegacyProfiler.h: Copied from Source/WebCore/ForwardingHeaders/profiler/Profiler.h.
  • ForwardingHeaders/profiler/Profiler.h: Removed.
  • bindings/js/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::start):
(WebCore::ScriptProfiler::stop):

2:29 PM Changeset in webkit [136571] by yurys@chromium.org
  • 6 edits in trunk/LayoutTests

[chromium] Layout test inspector-protocol/debugger-pause-dedicated-worker.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=101229

Reviewed by Vsevolod Vlasov.

Removed unnecessary logging that introduced flakiness to the tests.

  • inspector-protocol/debugger-pause-dedicated-worker-expected.txt:
  • inspector-protocol/debugger-pause-dedicated-worker.html:
  • inspector-protocol/debugger-terminate-dedicated-worker-while-paused-expected.txt:
  • inspector-protocol/debugger-terminate-dedicated-worker-while-paused.html:
  • platform/chromium/TestExpectations:
2:19 PM Changeset in webkit [136570] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1312

Merge 136250
BUG=162620
Review URL: https://codereview.chromium.org/11421227

2:17 PM Changeset in webkit [136569] by eae@chromium.org
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed chromium rebaselines.

  • platform/chromium-mac-snowleopard/fast/parser/document-write-ignores-later-network-bytes-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/parser/document-write-ignores-later-network-bytes-expected.txt: Added.
2:16 PM Changeset in webkit [136568] by andersca@apple.com
  • 12 edits in trunk/Source/WebKit2

Set the visible process name before entering the sandbox
https://bugs.webkit.org/show_bug.cgi?id=104030
<rdar://problem/12800317>

Reviewed by Sam Weinig.

Pass the UI process name along as a process initialization parameter so we can set it
before entering the sandbox. Remove the UI process name from WebProcessCreationParameters.

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters):

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::connectToWebProcessServiceForWebKitDevelopment):
(WebKit::createWebProcessService):
(WebKit::createProcess):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess):

  • WebProcess/mac/WebProcessInitialization.h:

(WebProcessInitializationParameters):

  • WebProcess/mac/WebProcessInitialization.mm:

(WebKit::initializeWebProcess):

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

  • WebProcess/mac/WebProcessMainMac.mm:

(WebKit::WebProcessMain):

  • WebProcess/mac/WebProcessServiceEntryPoints.h:
  • WebProcess/mac/WebProcessServiceEntryPoints.mm:

(WebKit::WebProcessServiceEventHandler):
(initializeWebProcessForWebProcessServiceForWebKitDevelopment):

  • WebProcessServiceForWebKitDevelopment/WebProcessServiceForWebKitDevelopmentMain.mm:

(WebProcessServiceForWebKitDevelopmentEventHandler):

2:11 PM Changeset in webkit [136567] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1312

Merge 136253
BUG=153592
Review URL: https://codereview.chromium.org/11428168

2:05 PM Changeset in webkit [136566] by cevans@google.com
  • 1 edit
    2 copies in branches/chromium/1312

Merge 136074
BUG=153566
Review URL: https://codereview.chromium.org/11280303

2:04 PM Changeset in webkit [136565] by simonjam@chromium.org
  • 3 edits in trunk/Source/WebCore

[User Timing] Fix clang build by removing need for exit time destructor
https://bugs.webkit.org/show_bug.cgi?id=104036

Reviewed by Tony Gentilcore.

Modeled after r99588.

No new tests. No change in functionality.

  • page/PerformanceUserTiming.cpp:

(WebCore::UserTiming::UserTiming):
(WebCore::UserTiming::mark):
(WebCore::UserTiming::findExistingMarkStartTime):

  • page/PerformanceUserTiming.h:

(UserTiming):

2:04 PM Changeset in webkit [136564] by eae@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed chromium expectations update.

  • platform/chromium/TestExpectations:
2:02 PM Changeset in webkit [136563] by yurys@chromium.org
  • 7 edits in trunk

Web Inspector: NMI introduce heap graph recording API
https://bugs.webkit.org/show_bug.cgi?id=103232

Reviewed by Vsevolod Vlasov.

MemoryInstrumentationClient is extended with several methods for reporting
heap graph vertices and edges. Edge source is always idenfied by heap object
address. Target node might be either a destination object address(either real
or adjusted if the edge was retrieved from a pointer to a base class) or a
MemoryObjectInfo in case of internal buffers.

  • wtf/MemoryInstrumentation.cpp:

(WTF::MemoryInstrumentation::reportEdge):
(WTF):
(WTF::MemoryInstrumentation::reportLinkToBuffer): report edge between the object
and a buffer which it owns.
(WTF::MemoryInstrumentation::InstrumentedPointerBase::process):
(WTF::MemoryClassInfo::addRawBuffer):
(WTF::MemoryClassInfo::addPrivateBuffer):

  • wtf/MemoryInstrumentation.h:

(MemoryInstrumentationClient):
(WTF::MemoryInstrumentationClient::reportNode):
(WTF::MemoryInstrumentationClient::reportEdge):
(WTF::MemoryInstrumentationClient::reportLeaf):
(WTF::MemoryInstrumentationClient::reportBaseAddress): if we found an object by a pointer
to base class it may have different value than real object address. Report both real and
adjusted addresses so that they both can be used for identifying corresponding heap graph
node.
(WTF::MemoryInstrumentation::addRootObject):
(MemoryInstrumentation):
(WTF::MemoryInstrumentation::addObject):
(WTF::MemoryInstrumentation::addRawBuffer):
(WTF::MemoryInstrumentation::OwningTraits::addObject):
(WTF::MemoryClassInfo::addMember):
(MemoryClassInfo):
(WTF::MemoryInstrumentation::addObjectImpl):

  • wtf/MemoryObjectInfo.h: added methods for repoting class name and some name string.

(WTF::MemoryObjectInfo::setClassName):
(WTF::MemoryObjectInfo::setName):
(MemoryObjectInfo):

2:01 PM Changeset in webkit [136562] by senorblanco@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled DEPS.

  • DEPS:
2:00 PM Changeset in webkit [136561] by simonjam@chromium.org
  • 3 edits in trunk/Source/WebCore

[User Timing] Fix negative durations
https://bugs.webkit.org/show_bug.cgi?id=104038

Reviewed by Tony Gentilcore.

At some point, we went from passing in a duration to passing in the end time. User Timing
wasn't updated.

Tests: http/tests/w3c/webperf/submission/Intel/user-timing

  • page/PerformanceMark.h:

(WebCore::PerformanceMark::PerformanceMark):

  • page/PerformanceUserTiming.cpp:

(WebCore::UserTiming::measure):

1:50 PM Changeset in webkit [136560] by inferno@chromium.org
  • 4 edits
    2 adds in trunk

Heap-use-after-free in WebCore::StyleCachedImageSet::cssValue
https://bugs.webkit.org/show_bug.cgi?id=100621

Reviewed by Eric Seidel.

Source/WebCore:

r115639 fixed a memory leak caused by reference cycle between StyleCachedImageSet
and its owner CSSImageSetValue. The fix caused StyleCachedImageSet to maintain
a weak pointer to CSSImageSetValue. This patch makes sure that the weak pointer
is cleared when CSSImageSetValue is going away.

Test: fast/css/image-set-value-not-removed-crash.html

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::~CSSImageSetValue):

  • rendering/style/StyleCachedImageSet.h:

(WebCore::StyleCachedImageSet::clearImageSetValue):
(StyleCachedImageSet):

LayoutTests:

  • fast/css/image-set-value-not-removed-crash-expected.txt: Added.
  • fast/css/image-set-value-not-removed-crash.html: Added.
1:46 PM Changeset in webkit [136559] by abarth@webkit.org
  • 5 edits in