Timeline



Jan 1, 2013:

10:53 PM Changeset in webkit [138608] by Christophe Dumez
  • 6 edits in trunk

[WK2] plugins/clicking-missing-plugin-fires-delegate.html is failing
https://bugs.webkit.org/show_bug.cgi?id=105897

Reviewed by Alexey Proskuryakov.

Tools:

Dump in WebKitTestRunner the message that is expected by layout tests
when the missing plugin button is clicked.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::unavailablePluginButtonClicked):
(WTR):

  • WebKitTestRunner/TestController.h:

(TestController):

LayoutTests:

Unskip plugins/clicking-missing-plugin-fires-delegate.html for
WK2 now that WebKitTestRunner is dumping the expected text when
the missing plugin button is clicked.

  • platform/efl-wk2/TestExpectations:
  • platform/mac-wk2/TestExpectations:
8:19 PM Changeset in webkit [138607] by weinig@apple.com
  • 28 edits in trunk/Source/WebKit2

Convert more classes to be WebContextSupplements
https://bugs.webkit.org/show_bug.cgi?id=105890

Reviewed by Dan Bernstein.

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetCookieManager):
(WKContextGetDatabaseManager):
(WKContextGetGeolocationManager):
(WKContextGetKeyValueStorageManager):
(WKContextGetMediaCacheManager):
(WKContextGetNotificationManager):
(WKContextGetResourceCacheManager):

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::cookieManager):
(EwkContext::clearResourceCache):

  • UIProcess/API/efl/ewk_database_manager_private.h:

(EwkDatabaseManager::create):

  • UIProcess/API/efl/ewk_storage_manager_private.h:

(EwkStorageManager::create):

  • UIProcess/API/gtk/WebKitWebContext.cpp:

(createDefaultWebContext):
(webkit_web_context_clear_cache):
(webkit_web_context_get_cookie_manager):

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::supplementName):
(WebKit):
(WebKit::WebNotificationManagerProxy::WebNotificationManagerProxy):
(WebKit::WebNotificationManagerProxy::initializeProvider):
(WebKit::WebNotificationManagerProxy::contextDestroyed):
(WebKit::WebNotificationManagerProxy::processDidClose):
(WebKit::WebNotificationManagerProxy::refWebContextSupplement):
(WebKit::WebNotificationManagerProxy::derefWebContextSupplement):
(WebKit::WebNotificationManagerProxy::didReceiveMessage):
(WebKit::WebNotificationManagerProxy::providerDidShowNotification):
(WebKit::WebNotificationManagerProxy::providerDidClickNotification):
(WebKit::WebNotificationManagerProxy::providerDidCloseNotifications):
(WebKit::WebNotificationManagerProxy::providerDidUpdateNotificationPolicy):
(WebKit::WebNotificationManagerProxy::providerDidRemoveNotificationPolicies):

  • UIProcess/Notifications/WebNotificationManagerProxy.h:

(WebNotificationManagerProxy):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::removeNetworkProcessProxy):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::shouldTerminate):
(WebKit::WebContext::disconnectProcess):

  • UIProcess/WebContext.h:

(WebKit):
(WebContext):
(WebKit::WebContext::iconDatabase):

  • UIProcess/WebContextSupplement.h:

(WebKit):
(WebKit::WebContextSupplement::contextDestroyed):
(WebKit::WebContextSupplement::processDidClose):
(WebContextSupplement):
(WebKit::WebContextSupplement::shouldTerminate):
(WebKit::WebContextSupplement::ref):
(WebKit::WebContextSupplement::deref):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::supplementName):
(WebKit):
(WebKit::WebCookieManagerProxy::WebCookieManagerProxy):
(WebKit::WebCookieManagerProxy::initializeClient):
(WebKit::WebCookieManagerProxy::contextDestroyed):
(WebKit::WebCookieManagerProxy::processDidClose):
(WebKit::WebCookieManagerProxy::shouldTerminate):
(WebKit::WebCookieManagerProxy::refWebContextSupplement):
(WebKit::WebCookieManagerProxy::derefWebContextSupplement):
(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname):
(WebKit::WebCookieManagerProxy::deleteAllCookies):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges):
(WebKit::WebCookieManagerProxy::stopObservingCookieChanges):
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):

  • UIProcess/WebCookieManagerProxy.h:

(WebCookieManagerProxy):

  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::supplementName):
(WebKit):
(WebKit::WebDatabaseManagerProxy::WebDatabaseManagerProxy):
(WebKit::WebDatabaseManagerProxy::initializeClient):
(WebKit::WebDatabaseManagerProxy::contextDestroyed):
(WebKit::WebDatabaseManagerProxy::processDidClose):
(WebKit::WebDatabaseManagerProxy::refWebContextSupplement):
(WebKit::WebDatabaseManagerProxy::derefWebContextSupplement):
(WebKit::WebDatabaseManagerProxy::didReceiveMessage):
(WebKit::WebDatabaseManagerProxy::getDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::getDatabaseOrigins):
(WebKit::WebDatabaseManagerProxy::deleteDatabaseWithNameForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteDatabasesForOrigin):
(WebKit::WebDatabaseManagerProxy::deleteAllDatabases):
(WebKit::WebDatabaseManagerProxy::setQuotaForOrigin):

  • UIProcess/WebDatabaseManagerProxy.h:

(WebDatabaseManagerProxy):

  • UIProcess/WebGeolocationManagerProxy.cpp:

(WebKit::WebGeolocationManagerProxy::supplementName):
(WebKit):
(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):
(WebKit::WebGeolocationManagerProxy::initializeProvider):
(WebKit::WebGeolocationManagerProxy::contextDestroyed):
(WebKit::WebGeolocationManagerProxy::processDidClose):
(WebKit::WebGeolocationManagerProxy::refWebContextSupplement):
(WebKit::WebGeolocationManagerProxy::derefWebContextSupplement):
(WebKit::WebGeolocationManagerProxy::didReceiveMessage):
(WebKit::WebGeolocationManagerProxy::providerDidChangePosition):
(WebKit::WebGeolocationManagerProxy::providerDidFailToDeterminePosition):

  • UIProcess/WebGeolocationManagerProxy.h:

(WebGeolocationManagerProxy):

  • UIProcess/WebKeyValueStorageManagerProxy.cpp:

(WebKit::WebKeyValueStorageManagerProxy::supplementName):
(WebKit):
(WebKit::WebKeyValueStorageManagerProxy::WebKeyValueStorageManagerProxy):
(WebKit::WebKeyValueStorageManagerProxy::contextDestroyed):
(WebKit::WebKeyValueStorageManagerProxy::processDidClose):
(WebKit::WebKeyValueStorageManagerProxy::refWebContextSupplement):
(WebKit::WebKeyValueStorageManagerProxy::derefWebContextSupplement):
(WebKit::WebKeyValueStorageManagerProxy::getKeyValueStorageOrigins):
(WebKit::WebKeyValueStorageManagerProxy::deleteEntriesForOrigin):
(WebKit::WebKeyValueStorageManagerProxy::deleteAllEntries):

  • UIProcess/WebKeyValueStorageManagerProxy.h:

(WebKeyValueStorageManagerProxy):

  • UIProcess/WebMediaCacheManagerProxy.cpp:

(WebKit::WebMediaCacheManagerProxy::supplementName):
(WebKit):
(WebKit::WebMediaCacheManagerProxy::WebMediaCacheManagerProxy):
(WebKit::WebMediaCacheManagerProxy::contextDestroyed):
(WebKit::WebMediaCacheManagerProxy::processDidClose):
(WebKit::WebMediaCacheManagerProxy::refWebContextSupplement):
(WebKit::WebMediaCacheManagerProxy::derefWebContextSupplement):
(WebKit::WebMediaCacheManagerProxy::getHostnamesWithMediaCache):
(WebKit::WebMediaCacheManagerProxy::clearCacheForHostname):
(WebKit::WebMediaCacheManagerProxy::clearCacheForAllHostnames):

  • UIProcess/WebMediaCacheManagerProxy.h:

(WebMediaCacheManagerProxy):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showNotification):

  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::supplementName):
(WebKit):
(WebKit::WebResourceCacheManagerProxy::WebResourceCacheManagerProxy):
(WebKit::WebResourceCacheManagerProxy::contextDestroyed):
(WebKit::WebResourceCacheManagerProxy::processDidClose):
(WebKit::WebResourceCacheManagerProxy::refWebContextSupplement):
(WebKit::WebResourceCacheManagerProxy::derefWebContextSupplement):
(WebKit::WebResourceCacheManagerProxy::didReceiveMessage):
(WebKit::WebResourceCacheManagerProxy::getCacheOrigins):
(WebKit::WebResourceCacheManagerProxy::clearCacheForOrigin):
(WebKit::WebResourceCacheManagerProxy::clearCacheForAllOrigins):

  • UIProcess/WebResourceCacheManagerProxy.h:

(WebResourceCacheManagerProxy):

  • UIProcess/efl/WebContextEfl.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

  • UIProcess/gtk/WebContextGtk.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

  • UIProcess/qt/WebContextQt.cpp:

(WebKit::WebContext::platformInitializeWebProcess):

8:18 PM Changeset in webkit [138606] by mitz@apple.com
  • 16 edits in trunk

<rdar://problem/12942239> Update copyright strings

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • Info.plist:

Source/WebCore:

  • Info.plist:

Source/WebKit/mac:

  • Info.plist:

Source/WebKit2:

  • Info.plist:
  • NetworkProcess/Info.plist:
  • PluginProcess/Info.plist:
  • SharedWorkerProcess/Info.plist:
  • WebProcess/Info.plist:
  • WebProcessService/Info.plist:
  • WebProcessServiceForWebKitDevelopment/Info.plist:

WebKitLibraries:

  • win/tools/scripts/COPYRIGHT-END-YEAR:
8:14 PM Changeset in webkit [138605] by commit-queue@webkit.org
  • 9 edits in trunk

[EFL] Enable MHTML feature
https://bugs.webkit.org/show_bug.cgi?id=105815

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-01-01
Reviewed by Laszlo Gombos.

.:

ENABLE_MHTML is now ON for EFL.

  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

Add application/x-mimearchive type to archive mime types.
Add mht and mhtml to extension map.

No new tests. Existing layout tests pass.

  • loader/archive/ArchiveFactory.cpp:

(WebCore::archiveMIMETypes):

  • platform/efl/MIMETypeRegistryEfl.cpp:

(WebCore):

Source/WebKit2:

Add missing include directory for ENABLE_MHTML.

  • CMakeLists.txt:

Tools:

Enable MHTML feature for EFL port by default.

  • Scripts/webkitperl/FeatureList.pm:
7:51 PM Changeset in webkit [138604] by barraclough@apple.com
  • 13 edits
    18 adds in trunk/Source

Objective-C API for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=105889

Reviewed by Filip Pizlo.

../JavaScriptCore:

For a detailed description of the API implemented here, see:

JSContext.h
APIJSValue.h
JSVirtualMachine.h
JSExport.h

Still to do -

(1) Shoud rename APIJSValue.h -> JSValue.h (but we'll have to rename JSValue.h first).
(2) Numerous FIXMEs, all with separate bugs filed.

  • API/APIJSValue.h: Added.
    • this Objective-C class is used to reference a JavaScript object.
  • API/JSBase.h:
    • added JS_OBJC_API_ENABLED macro to control ObjC API support.
  • API/JSBlockAdaptor.h: Added.
    • this Objective-C class is used in creating a special NSBlock proxying a JavaScript function.
  • API/JSBlockAdaptor.mm: Added.

(BlockArgument):
(BlockArgument::~BlockArgument):
(BlockArgumentBoolean):
(BlockArgumentBoolean::get):
(BlockArgumentNumeric):
(BlockArgumentNumeric::get):
(BlockArgumentId):
(BlockArgumentId::get):
(BlockArgumentStruct):
(BlockArgumentStruct::BlockArgumentStruct):
(BlockArgumentStruct::~BlockArgumentStruct):
(BlockArgumentStruct::get):

  • decoded arguent type information of a JSBlockAdaptor.

(BlockArgumentTypeDelegate):
(BlockArgumentTypeDelegate::typeInteger):
(BlockArgumentTypeDelegate::typeDouble):
(BlockArgumentTypeDelegate::typeBool):
(BlockArgumentTypeDelegate::typeVoid):
(BlockArgumentTypeDelegate::typeId):
(BlockArgumentTypeDelegate::typeOfClass):
(BlockArgumentTypeDelegate::typeBlock):
(BlockArgumentTypeDelegate::typeStruct):

  • delegate for use in conjunction with parseObjCType.

(BlockResult):
(BlockResult::~BlockResult):
(BlockResultVoid):
(BlockResultVoid::set):
(BlockResultInteger):
(BlockResultInteger::set):
(BlockResultDouble):
(BlockResultDouble::set):
(BlockResultBoolean):
(BlockResultBoolean::set):
(BlockResultStruct):
(BlockResultStruct::BlockResultStruct):
(BlockResultStruct::~BlockResultStruct):
(BlockResultStruct::set):

  • decoded result type information of a JSBlockAdaptor.

(buildBlockSignature):

  • partial step in constructing a signature with stack offset information from one without.

(-[JSBlockAdaptor initWithBlockSignatureFromProtocol:]):

  • constructor.

(-[JSBlockAdaptor blockMatchesSignature:]):

  • check whether signature strings match, where only one contains stack frame offsets.

(-[JSBlockAdaptor blockFromValue:inContext:withException:]):

  • use the adaptor to create a special forwarding block.
  • API/JSCallbackObjectFunctions.h:

(JSC::::inherits):

  • add missing braces to multiline for statement.
  • API/JSContext.h: Added.
    • this Objective-C class is used to reference a JavaScript context.
  • API/JSContext.mm: Added.

(-[JSContext init]):

  • constructor.

(-[JSContext initWithVirtualMachine:]):

  • construct in a given VM (JSGlobalData).

(-[JSContext evaluateScript:]):
(-[JSContext globalObject]):

  • evaluate a script, global object accessor.

(+[JSContext currentContext]):
(+[JSContext currentThis]):
(+[JSContext currentArguments]):

  • These methods obtain context, this, arguments from within a callback.

(-[JSContext virtualMachine]):

  • implementation for .virtualMachine property.

(-[JSContext objectForKeyedSubscript:]):
(-[JSContext setObject:forKeyedSubscript:]):

  • support for subscript property access.

(contextInternalContext):

  • internal accessor to m_context.

(-[JSContext dealloc]):

  • desctructor.

(-[JSContext notifyException:]):
(-[JSContext valueFromNotifyException:]):
(-[JSContext boolFromNotifyException:]):

  • internal method to record an exception was thrown.

(-[JSContext beginCallbackWithData:thisValue:argumentCount:arguments:]):
(-[JSContext endCallbackWithData:]):

  • internal methods to push/pop a callback record.

(-[JSContext protect:]):
(-[JSContext unprotect:]):

  • internal methods to add a value to a protect set (used to protect the internal property of JSValue).

(-[JSContext wrapperForObject:]):

  • internal method to create a wrapper object.

(WeakContextRef::WeakContextRef):
(WeakContextRef::~WeakContextRef):
(WeakContextRef::get):
(WeakContextRef::set):

  • Helper class to implement a weak reference to a JSContext.
  • API/JSContextInternal.h: Added.

(CallbackData):
(WeakContextRef):

  • see API/JSContext.mm for description of internal methods.
  • API/JSExport.h: Added.
    • Provides JSExport protocol & JSExportAs macro.
  • API/JSValue.mm: Added.

(+[JSValue valueWithObject:inContext:]):
(+[JSValue valueWithBool:inContext:]):
(+[JSValue valueWithDouble:inContext:]):
(+[JSValue valueWithInt32:inContext:]):
(+[JSValue valueWithUInt32:inContext:]):
(+[JSValue valueWithNewObjectInContext:]):
(+[JSValue valueWithNewArrayInContext:]):
(+[JSValue valueWithNewRegularExpressionFromPattern:flags:inContext:]):
(+[JSValue valueWithNewErrorFromMessage:inContext:]):
(+[JSValue valueWithNullInContext:]):
(+[JSValue valueWithUndefinedInContext:]):

  • Constructors.

(-[JSValue toObject]):
(-[JSValue toObjectOfClass:]):
(-[JSValue toBool]):
(-[JSValue toDouble]):
(-[JSValue toInt32]):
(-[JSValue toUInt32]):
(-[JSValue toNumber]):
(-[JSValue toString]):
(-[JSValue toDate]):
(-[JSValue toArray]):
(-[JSValue toDictionary]):

  • Conversion to Objective-C types.

(-[JSValue valueForProperty:]):
(-[JSValue setValue:forProperty:]):
(-[JSValue deleteProperty:]):
(-[JSValue hasProperty:]):
(-[JSValue defineProperty:descriptor:]):

  • Property access by property name.

(-[JSValue valueAtIndex:]):
(-[JSValue setValue:atIndex:]):

  • Property access by index.

(-[JSValue isUndefined]):
(-[JSValue isNull]):
(-[JSValue isBoolean]):
(-[JSValue isNumber]):
(-[JSValue isString]):
(-[JSValue isObject]):

  • Test JavaScript type.

(-[JSValue isEqualToObject:]):
(-[JSValue isEqualWithTypeCoercionToObject:]):
(-[JSValue isInstanceOf:]):

  • ===, ==, instanceof operators.

(-[JSValue callWithArguments:]):
(-[JSValue constructWithArguments:]):
(-[JSValue invokeMethod:withArguments:]):

  • Call & construct.

(-[JSValue context]):

  • implementation for .context property.

(-[JSValue toPoint]):
(-[JSValue toRange]):
(-[JSValue toRect]):
(-[JSValue toSize]):
(+[JSValue valueWithPoint:inContext:]):
(+[JSValue valueWithRange:inContext:]):
(+[JSValue valueWithRect:inContext:]):
(+[JSValue valueWithSize:inContext:]):

  • Support for NS struct types.

(-[JSValue objectForKeyedSubscript:]):
(-[JSValue objectAtIndexedSubscript:]):
(-[JSValue setObject:forKeyedSubscript:]):
(-[JSValue setObject:atIndexedSubscript:]):

  • support for subscript property access.

(isDate):
(isArray):

  • internal helper functions to check for instances of JS Date, Array types.

(JSContainerConvertor):
(Task):
(JSContainerConvertor::JSContainerConvertor):
(JSContainerConvertor::isWorkListEmpty):
(JSContainerConvertor::convert):
(JSContainerConvertor::add):
(JSContainerConvertor::take):

  • helper class for tracking state while converting to Array/Dictionary objects.

(valueToObjectWithoutCopy):
(containerValueToObject):
(valueToObject):
(valueToNumber):
(valueToString):
(valueToDate):
(valueToArray):
(valueToDictionary):

  • function for converting JavaScript values to Objective-C objects.

(ObjcContainerConvertor):
(ObjcContainerConvertor::ObjcContainerConvertor):
(ObjcContainerConvertor::isWorkListEmpty):
(ObjcContainerConvertor::convert):
(ObjcContainerConvertor::add):
(ObjcContainerConvertor::take):

  • helper class for tracking state while converting to Array/Dictionary values.

(objectToValueWithoutCopy):
(objectToValue):
(valueInternalValue):

  • function for converting Objective-C objects to JavaScript values.

(+[JSValue valueWithValue:inContext:]):
(-[JSValue initWithValue:inContext:]):

  • internal constructors.

(StructTagHandler):
(getStructTagHandler):
(+[JSValue selectorForStructToValue:]):
(+[JSValue selectorForValueToStruct:]):

  • methods to tracking struct types that support conversion to/from JSValue.

(-[JSValue dealloc]):

  • destructor.

(-[JSValue description]):

  • Objective-C to-NSString conversion.

(typeToValueInvocationFor):
(valueToTypeInvocationFor):

  • create invocation objects for conversion to/from JSValue.
  • API/JSValueInternal.h: Added.
    • see API/JSValue.mm for description of internal methods.
  • API/JSVirtualMachine.h: Added.
    • this Objective-C class is used to reference a JavaScript virtual machine (JSGlobalData).
  • API/JSVirtualMachine.mm: Added.

(-[JSVirtualMachine init]):
(-[JSVirtualMachine dealloc]):

  • constructor & destructor.

(getGroupFromVirtualMachine):

  • internal accessor for m_group property.
  • API/JSVirtualMachineInternal.h: Added.
    • see API/JSVirtualMachine.mm for description of internal methods.
  • API/JSWrapperMap.h: Added.
  • API/JSWrapperMap.mm: Added.

(wrapperClass):

  • singleton root for detction (& unwrapping) of wrapper objects.

(selectorToPropertyName):

  • default selector to property name conversion.

(createObjectWithCustomBrand):

  • creates a JSObject with a custom NativeBrand (class name).

(createRenameMap):

  • parse @optional properties of a JSExport protocol.

(putNonEnumerable):

  • property put with enumerable=false.

(copyMethodsToObject):

  • iterate methods in a protocol; add functions to a JSObject.

(parsePropertyAttributes):

  • examine protocol property metadata.

(makeSetterName):

  • "foo" -> "setFoo"

(copyPrototypeProperties):

  • create properties on a Protocol object reflecting the instance methods & properties of a protocol.

(-[JSObjCClassInfo initWithContext:forClass:superClassInfo:]):
(-[JSObjCClassInfo dealloc]):
(-[JSObjCClassInfo wrapperForObject:]):
(-[JSObjCClassInfo constructor]):

  • cache the Protocol/Constructor objects for an Objective-C type.

(-[JSWrapperMap initWithContext:]):
(-[JSWrapperMap dealloc]):

  • constructor & desctructor.

(-[JSWrapperMap classInfoForClass:]):

  • maps Class -> JSObjCClassInfo.

(-[JSWrapperMap wrapperForObject:]):

  • cretae or retrieve a cached wrapper value for an object.

(tryUnwrapObjcObject):

  • check whether a value is a wrapper object; unwrap if so.
  • API/JavaScriptCore.h:
    • Added includes for new API headers.
  • API/ObjCCallbackFunction.h: Added.
    • this class is used to wrap Objective-C instance methods, class methods & blocks as JSFunction objects.
  • API/ObjCCallbackFunction.mm: Added.

(CallbackArgument):
(CallbackArgument::~CallbackArgument):
(CallbackArgumentBoolean):
(CallbackArgumentBoolean::set):
(CallbackArgumentInteger):
(CallbackArgumentInteger::set):
(CallbackArgumentDouble):
(CallbackArgumentDouble::set):
(CallbackArgumentJSValue):
(CallbackArgumentJSValue::set):
(CallbackArgumentId):
(CallbackArgumentId::set):
(CallbackArgumentOfClass):
(CallbackArgumentOfClass::CallbackArgumentOfClass):
(CallbackArgumentOfClass::~CallbackArgumentOfClass):
(CallbackArgumentOfClass::set):
(CallbackArgumentNSNumber):
(CallbackArgumentNSNumber::set):
(CallbackArgumentNSString):
(CallbackArgumentNSString::set):
(CallbackArgumentNSDate):
(CallbackArgumentNSDate::set):
(CallbackArgumentNSArray):
(CallbackArgumentNSArray::set):
(CallbackArgumentNSDictionary):
(CallbackArgumentNSDictionary::set):
(CallbackArgumentStruct):
(CallbackArgumentStruct::CallbackArgumentStruct):
(CallbackArgumentStruct::~CallbackArgumentStruct):
(CallbackArgumentStruct::set):
(CallbackArgumentBlockCallback):
(CallbackArgumentBlockCallback::CallbackArgumentBlockCallback):
(CallbackArgumentBlockCallback::~CallbackArgumentBlockCallback):
(CallbackArgumentBlockCallback::set):

  • decoded arguent type information of a ObjCCallbackFunction.

(ArgumentTypeDelegate):
(ArgumentTypeDelegate::typeInteger):
(ArgumentTypeDelegate::typeDouble):
(ArgumentTypeDelegate::typeBool):
(ArgumentTypeDelegate::typeVoid):
(ArgumentTypeDelegate::typeId):
(ArgumentTypeDelegate::typeOfClass):
(ArgumentTypeDelegate::typeBlock):
(ArgumentTypeDelegate::typeStruct):

  • delegate for use in conjunction with parseObjCType.

(CallbackResult):
(CallbackResult::~CallbackResult):
(CallbackResultVoid):
(CallbackResultVoid::get):
(CallbackResultId):
(CallbackResultId::get):
(CallbackResultNumeric):
(CallbackResultNumeric::get):
(CallbackResultBoolean):
(CallbackResultBoolean::get):
(CallbackResultStruct):
(CallbackResultStruct::CallbackResultStruct):
(CallbackResultStruct::~CallbackResultStruct):
(CallbackResultStruct::get):

  • decoded result type information of a ObjCCallbackFunction.

(ResultTypeDelegate):
(ResultTypeDelegate::typeInteger):
(ResultTypeDelegate::typeDouble):
(ResultTypeDelegate::typeBool):
(ResultTypeDelegate::typeVoid):
(ResultTypeDelegate::typeId):
(ResultTypeDelegate::typeOfClass):
(ResultTypeDelegate::typeBlock):
(ResultTypeDelegate::typeStruct):

  • delegate for use in conjunction with parseObjCType.

(ObjCCallbackFunction):
(ObjCCallbackFunction::ObjCCallbackFunction):
(ObjCCallbackFunction::~ObjCCallbackFunction):

  • constructor & destructor.

(ObjCCallbackFunction::context):

  • accessor.

(ObjCCallbackFunction::wrappedBlock):

  • attemmpt to unwrap a block object.

(objCCallbackFunctionFinalize):
(objCCallbackFunctionCallAsFunction):
(objCCallbackFunctionClass):

  • JSClassRef used to represent ObjCCallbackFunction objects.

(ObjCCallbackFunction::call):
(blockSignatureContainsClass):

  • helper function to determine if we're running on a recent Clang.

(skipNumber):

  • helper used in parsing signature strings.

(objCCallbackFunctionForInvocation):
(objCCallbackFunctionForMethod):
(objCCallbackFunctionForBlock):

  • functions to try to create ObjCCallbackFunction instances for methods/blocks.

(tryUnwrapBlock):

  • attemmpt to unwrap a block object.
  • API/ObjcRuntimeExtras.h: Added.

(protocolImplementsProtocol):
(forEachProtocolImplementingProtocol):
(forEachMethodInClass):
(forEachMethodInProtocol):
(forEachPropertyInProtocol):

  • functions used in reflecting on Objective-C types.

(skipPair):

  • parsing helper used by parseObjCType, scans for matching parentheses.

(StringRange):
(StringRange::StringRange):
(StringRange::~StringRange):
(StringRange::operator const char*):
(StringRange::get):

  • Helper class - create a c string copy of a range of an existing string.

(parseObjCType):

  • function to parse Objective-C type strings, makes callbacks to a deleagte.
  • API/tests/testapi.c:

(main):

  • added call to testObjectiveCAPI (in testapi.m).
  • API/tests/testapi.m: Added.

(+[ParentObject parentTest]):
(+[TestObject testObject]):
(+[TestObject classTest]):
(-[TestObject getString]):
(-[TestObject testArgumentTypesWithInt:double:boolean:string:number:array:dictionary:]):
(-[TestObject callback:]):
(-[TextXYZ test:]):

  • test object, used in various test vases.

(checkResult):

  • helper function.

(blockSignatureContainsClass):

  • helper function to determine if we're running on a recent Clang.

(testObjectiveCAPI):

  • new test cases.
  • JavaScriptCore.xcodeproj/project.pbxproj:
    • added new files.
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • added m_apiData - provide convenient storage for use by the API.
  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::JSGlobalObject):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):

  • added m_apiData - provide convenient storage for use by the API.

../WTF:

  • wtf/WTFThreadData.cpp:

(WTF::WTFThreadData::WTFThreadData):

  • wtf/WTFThreadData.h:

(WTFThreadData):

  • Added m_apiData - provide convenient storage for use by the API.
6:54 PM Changeset in webkit [138603] by commit-queue@webkit.org
  • 4 edits
    6 adds in trunk/Tools

sheriff-bot should know who the gardeners/sheriffs are
https://bugs.webkit.org/show_bug.cgi?id=105698

Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-01
Reviewed by Eric Seidel.

Added a "sheriffs" command to sheriffbot to fetch the current Chromium Webkit sheriffs.

  • Scripts/webkitpy/tool/bot/irc_command.py:

(Current):
(Current._retrieve_webkit_sheriffs):
(Current.execute):

  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:

(IRCCommandTest.test_current):

  • Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_0.js: Added.
  • Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_1.js: Added.
  • Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_2.js: Added.
  • Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_malformed.js: Added.
  • Scripts/webkitpy/tool/bot/testdata/webkit_sheriff_zero.js: Added.
4:23 PM Changeset in webkit [138602] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK1] Skip some webaudio test cases due to lack of implementation
https://bugs.webkit.org/show_bug.cgi?id=105882

Unreviewed, EFL gardening.

Bunch of webaudio test cases need setAudioData implementation and DRT has not it.
So, skips those cases.

Patch by Kangil Han <kangil.han@samsung.com> on 2013-01-01

  • platform/efl-wk1/TestExpectations:
9:20 AM Changeset in webkit [138601] by mkwst@chromium.org
  • 4 edits
    3 adds in trunk

seamless iframes don't inherit styles when srcdoc is used
https://bugs.webkit.org/show_bug.cgi?id=103539

Reviewed by Eric Seidel.

Source/WebCore:

Seamless iframes populated via a 'srcdoc' attribute should always
inherit styles from their parent documents. At the moment, this is
only the case when they contain a stylesheet or some other markup
that forces a style recalculation on the document. Simple 'srcdoc'
attributes (e.g. "srcdoc='<p>This is a comment.</p>'") bail out of
recalculating style early, resulting in unstyled appearance.

This patch instructs WebCore to treat seamless documents as having an
updated StyleResolver regardless of what actions the parser takes,
which in turn ensures that the document's style is recalculated
correctly.

Test: fast/frames/seamless/seamless-srcdoc.html

  • dom/Document.cpp:

(WebCore::Document::finishedParsing):

If it's a seamless document, notify it that its StyleResolver isn't
what it might have expected.

LayoutTests:

  • fast/frames/seamless/resources/span.html: Added.
  • fast/frames/seamless/seamless-contenteditable-not-inherited-expected.txt:

Updating the previously FAILing expectation.

  • fast/frames/seamless/seamless-srcdoc-expected.txt: Added.
  • fast/frames/seamless/seamless-srcdoc.html: Added.

Exciting new test to ensure that this doesn't regress, neither
for totally simple srcdoc attriubtes, nor for slightly more
complex variations.

3:47 AM WebKitGTK/WebKit2Roadmap edited by Carlos Garcia Campos
Added web extensions, and updated target versions (diff)

Dec 31, 2012:

12:37 PM Changeset in webkit [138600] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Fullscreen Media Time Indicators Background Incorrect
https://bugs.webkit.org/show_bug.cgi?id=105888

Patch by Jeff Rogers <jrogers@rim.com> on 2012-12-31
Reviewed by George Staikos.

Internal PR 272699.
Update fullscreen media controls CSS to fix time container background
color. Also fix transparency to be 80% opaque to and the time
remaining text color to match the system player.

No new tests as there is no functionality change.

  • css/mediaControlsBlackBerryFullscreen.css:

(video:-webkit-full-screen::-webkit-media-controls-panel):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-time-display-container):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-timeline-container):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-current-time-display):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-time-remaining-display):
(video:-webkit-full-screen::-webkit-media-controls-fullscreen-button-container, video:-webkit-full-screen::-webkit-media-controls-play-button-container):
(video:-webkit-full-screen::-webkit-media-controls-placeholder):

11:53 AM Changeset in webkit [138599] by weinig@apple.com
  • 7 edits
    1 add in trunk/Source/WebKit2

Add supplementability for WebContext
https://bugs.webkit.org/show_bug.cgi?id=105878

Reviewed by Dan Bernstein.

Add WebContextSupplement and convert WebApplicationCacheManagerProxy to it.

  • UIProcess/API/C/WKContext.cpp:

(WKContextGetApplicationCacheManager):

  • UIProcess/WebApplicationCacheManagerProxy.cpp:

(WebKit::WebApplicationCacheManagerProxy::supplementName):
(WebKit::WebApplicationCacheManagerProxy::WebApplicationCacheManagerProxy):
(WebKit::WebApplicationCacheManagerProxy::contextDestroyed):
(WebKit::WebApplicationCacheManagerProxy::processDidClose):
(WebKit::WebApplicationCacheManagerProxy::refWebContextSupplement):
(WebKit::WebApplicationCacheManagerProxy::derefWebContextSupplement):
(WebKit::WebApplicationCacheManagerProxy::getApplicationCacheOrigins):
(WebKit::WebApplicationCacheManagerProxy::deleteEntriesForOrigin):
(WebKit::WebApplicationCacheManagerProxy::deleteAllEntries):

  • UIProcess/WebApplicationCacheManagerProxy.h:

(WebApplicationCacheManagerProxy):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::WebContext):
(WebKit::WebContext::~WebContext):
(WebKit::WebContext::shouldTerminate):
(WebKit::WebContext::disconnectProcess):

  • UIProcess/WebContext.h:

(WebKit::WebContext::supplement):
(WebKit::WebContext::addSupplement):

  • UIProcess/WebContextSupplement.h: Added.

(WebKit::WebContextSupplement::WebContextSupplement):
(WebKit::WebContextSupplement::~WebContextSupplement):
(WebKit::WebContextSupplement::ref):
(WebKit::WebContextSupplement::deref):
(WebKit::WebContextSupplement::context):
(WebKit::WebContextSupplement::clearContext):

  • WebKit2.xcodeproj/project.pbxproj:
8:56 AM Changeset in webkit [138598] by commit-queue@webkit.org
  • 4 edits in trunk

[EFL][WebGL] Add compile time support for GLES2.
https://bugs.webkit.org/show_bug.cgi?id=105816

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-31
Reviewed by Kenneth Rohde Christiansen.

.:

This patch adds build support for GLES2.
GLES2 support can be enabled during compile time by passing -DENABLE_GLES2=ON as
cmake config parameter. GLES2 options is not enabled by default. This patch doesn't
address all the build issues related to GLES2 but only adds the needed support in
OptionsEfl.cmake.

  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

This patch adds build support for GLES2.
GLES2 support can be enabled during compile time by passing -DENABLE_GLES2=ON as
cmake config parameter. GLES2 options is not enabled by default. This patch doesn't
address all the build issues related to GLES2 but only adds the needed support in
PlatformEfl.cmake.

  • PlatformEfl.cmake:
8:31 AM Changeset in webkit [138597] by Christophe Dumez
  • 2 edits in trunk/Source/WebKit2

[EFL[WK2] Regression(r138574): Should not allocate memory in the fork
https://bugs.webkit.org/show_bug.cgi?id=105868

Reviewed by Kenneth Rohde Christiansen.

Store prefixed executable path in a CString before the fork to
avoid allocating memory in the fork by calling String::utf8().
Allocating memory in the fork may lead to deadlocks due to
FastMalloc and the fork not inheriting the threads.

  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::ProcessLauncher::launchProcess):

8:05 AM Changeset in webkit [138596] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] The HTML5 video fullscreen time indicator on the right cuts clipped when the video is longer than 1 hour
https://bugs.webkit.org/show_bug.cgi?id=105887

Patch by Andy Chen <andchen@rim.com> on 2012-12-31
Reviewed by George Staikos.

The width of the time part was fixed. Remove it.

No new test is required because no functionality change.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):

5:54 AM Changeset in webkit [138595] by commit-queue@webkit.org
  • 4 edits
    1 move
    1 add
    1 delete in trunk

[GTK] Move ImageDiff to the Tools directory root
https://bugs.webkit.org/show_bug.cgi?id=105421

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2012-12-31
Reviewed by Kenneth Rohde Christiansen.

.:

  • GNUmakefile.am: Remove the old ImageDiff makefile include.

Tools:

  • DumpRenderTree/gtk/GNUmakefile.ImageDiff.am: Removed.
  • GNUmakefile.am:
  • ImageDiff/gtk/ImageDiff.cpp: Renamed from Tools/DumpRenderTree/gtk/ImageDiff.cpp.
5:25 AM Changeset in webkit [138594] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] css3/masking/clip-path-circle-relative-overflow.html needs expected results update after 97217
https://bugs.webkit.org/show_bug.cgi?id=105883

Unreviewed, EFL gardening.

Rebaseline css3/masking/clip-path-circle-relative-overflow.html because BUG 97217 has been resolved.

Patch by Kangil Han <kangil.han@samsung.com> on 2012-12-31

  • platform/efl/TestExpectations:
  • platform/efl/css3/masking/clip-path-circle-relative-overflow-expected.png:
4:50 AM Changeset in webkit [138593] by Carlos Garcia Campos
  • 12 edits in trunk/Source/WebKit2

[GTK] Add API to set a WebKitWebView in view source mode to WebKit2
https://bugs.webkit.org/show_bug.cgi?id=99315

Reviewed by Martin Robinson.

Add a generic API to set/get a view mode. For now there are only
two modes, Web and Source, but the API can be extended if we
eventually support other view modes like Printing for example.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewSetProperty): Implement setter for view-mode
property.
(webkitWebViewGetProperty): Implement getter for view-mode
property.
(webkit_web_view_class_init): Add view-source property.
(webkit_web_view_set_view_mode): Public method to set the view
mode.
(webkit_web_view_get_view_mode): Public method to get the view
mode.

  • UIProcess/API/gtk/WebKitWebView.h: Add WebKitViewMode enum.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewMode):
(beforeAll):

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::WebFrameProxy): Initialize
m_inViewSourceMode.
(WebKit::WebFrameProxy::setInViewSourceMode): Set
m_inViewSourceMode if it has changed and call
WebPageProxy::setFrameInViewSourceMode() to notify the WebProcess.

  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::inViewSourceMode): Return whether the
frame is currently in view source mode.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setFrameInViewSourceMode): Send a message
to the WebProcess to set the given frame in view source mode or not.

  • UIProcess/WebPageProxy.h:

(WebPageProxy): Add setFrameInViewSourceMode().

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setFrameInViewSourceMode): Call
setInViewSourceMode for the main frame.

  • WebProcess/WebPage/WebPage.h:

(WebPage): Add setFrameInViewSourceMode().

  • WebProcess/WebPage/WebPage.messages.in: Add new message

SetFrameInViewSourceMode.

12:57 AM Changeset in webkit [138592] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark editing/spelling/spelling-insert-html.html as flaky
since it sometimes hits an assertion in RenderObject
destructor.

  • platform/efl/TestExpectations:

Dec 30, 2012:

11:57 PM Changeset in webkit [138591] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark fast/dom/Range/range-extract-contents.html as flaky
since it sometimes hits an assertion in
WebCore::endOfContinuations().

  • platform/efl/TestExpectations:
11:49 PM Changeset in webkit [138590] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Mark editing/pasteboard/4806874.html as flaky since
it sometimes hits an assertion in RenderObject
destructor.

  • platform/efl/TestExpectations:
11:41 PM Changeset in webkit [138589] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline fast/js/global-constructors.html after
TEMPLATE_ELEMENT was enabled for EFL port in r138586.

  • platform/efl/fast/js/global-constructors-expected.txt:
11:33 PM Changeset in webkit [138588] by commit-queue@webkit.org
  • 5 edits
    2 moves in trunk

[EFL] [WebGL] Rename EGLConfigHelper as EGLConfigSelector.
https://bugs.webkit.org/show_bug.cgi?id=105876

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-30
Reviewed by Kenneth Rohde Christiansen.

This is to sync the naming conventions of our classes in both EGL and GLX implementations.
In our GLX implementation, class responsible for the same functionality is named as GLXConfigSelector.
This patch renames EGLConfigHelper as EGLConfigSelector.

.:

  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

  • PlatformEfl.cmake:
  • platform/graphics/surfaces/egl/EGLConfigSelector.cpp: Renamed from Source/WebCore/platform/graphics/surfaces/egl/EGLConfigHelper.cpp.

(WebCore):
(WebCore::SharedEGLDisplay::deref):
(WebCore::SharedEGLDisplay::sharedEGLDisplay):
(WebCore::SharedEGLDisplay::SharedEGLDisplay):
(WebCore::SharedEGLDisplay::cleanup):
(WebCore::SharedEGLDisplay::~SharedEGLDisplay):
(WebCore::EGLConfigSelector::EGLConfigSelector):
(WebCore::EGLConfigSelector::~EGLConfigSelector):
(WebCore::EGLConfigSelector::display):
(WebCore::EGLConfigSelector::pBufferContextConfig):
(WebCore::EGLConfigSelector::surfaceContextConfig):
(WebCore::EGLConfigSelector::nativeVisualId):
(WebCore::EGLConfigSelector::reset):
(WebCore::EGLConfigSelector::createConfig):

  • platform/graphics/surfaces/egl/EGLConfigSelector.h: Renamed from Source/WebCore/platform/graphics/surfaces/egl/EGLConfigHelper.h.

(WebCore):
(SharedEGLDisplay):
(WebCore::SharedEGLDisplay::create):
(EGLConfigSelector):

  • platform/graphics/surfaces/egl/EGLSurface.cpp:

(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
(WebCore::EGLWindowTransportSurface::configuration):
(WebCore::EGLWindowTransportSurface::destroy):

  • platform/graphics/surfaces/egl/EGLSurface.h:

(EGLWindowTransportSurface):

11:12 PM Changeset in webkit [138587] by mkwst@chromium.org
  • 3 edits in trunk/Tools

Add myself to watchlists for CSP and console logs.
https://bugs.webkit.org/show_bug.cgi?id=105874

Reviewed by Dirk Pranke.

Because I really, really, really need more email.

  • Scripts/webkitpy/common/config/committers.py:

Add mkwst+watchlist@chromium.org as a contributor.

  • Scripts/webkitpy/common/config/watchlist:

Create watchlist categories for 1) the various mechanisms used to
generate console messages, and 2) CSP usage and files.

8:44 PM Changeset in webkit [138586] by gyuyoung.kim@samsung.com
  • 6 edits in trunk

.: [EFL] Enable TEMPLATE_ELEMENT feature
https://bugs.webkit.org/show_bug.cgi?id=105865

Reviewed by Laszlo Gombos.

  • Source/cmake/OptionsEfl.cmake: Add ENABLE_TEMPLATE_ELEMENT macro.

Tools: [EFL] Enable TEMPLATE_ELEMENT feature
https://bugs.webkit.org/show_bug.cgi?id=105865

Reviewed by Laszlo Gombos.

  • Scripts/webkitperl/FeatureList.pm: Enable template element feature for EFL port.

LayoutTests: [EFL] Enable TEMPLATE_ELEMENT feature
https://bugs.webkit.org/show_bug.cgi?id=105865

Reviewed by Laszlo Gombos.

  • platform/efl/TestExpectations: Unskip test cases for template element.
1:22 PM Changeset in webkit [138585] by Martin Robinson
  • 2 edits in trunk/Websites/bugs.webkit.org

PrettyDiff.rb fails to render image diffs with Ruby 1.9.3p194
https://bugs.webkit.org/show_bug.cgi?id=104932

Reviewed by Eric Seidel.

Ruby 1.9 added the concept of string encodings, so the use of `match' with binary data
treats it as UTF-8. Forcing the png_bytes string to have the "binary" encoding avoids
this error.

  • PrettyPatch/PrettyPatch.rb: Use force_encoding.
9:51 AM Changeset in webkit [138584] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Add several webaudio tests to TestExpectations since
they sometimes hit !m_finishedNodes.size() assertion
in AudioContext destructor.

  • platform/efl/TestExpectations:
9:37 AM Changeset in webkit [138583] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip XSS Auditor test case that has been consistently
passing on EFL port for a while.

  • platform/efl/TestExpectations:
9:08 AM Changeset in webkit [138582] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip fast/dom/shadow/host-wrapper-reclaimed.html
since it is passing after r137978.

  • platform/efl/TestExpectations:
9:05 AM Changeset in webkit [138581] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Update expectations for 2 fast/dom test cases so
that they are not reported as unexpected passes.

Those tests are passing because their generated
expectations are wrong.

  • platform/efl/TestExpectations:
8:57 AM Changeset in webkit [138580] by Philippe Normand
  • 4 edits in trunk

[GStreamer] webaudio/decode-audio-data-basic.html fails
https://bugs.webkit.org/show_bug.cgi?id=105298

Reviewed by Martin Robinson.

Source/WebCore:

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::createBus): Return a null pointer if an
error happened while processing a media file.

LayoutTests:

  • platform/efl/TestExpectations: Unflag fixed test.
8:55 AM Changeset in webkit [138579] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip text-decoration-style tests passing after
r126054 and r132076.

  • platform/efl/TestExpectations:
7:55 AM Changeset in webkit [138578] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip cairo-related tests that are now consistently
passing on both WK1 and WK2 EFL.

  • platform/efl/TestExpectations:
7:45 AM Changeset in webkit [138577] by Christophe Dumez
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Unskip several compositing test cases that are passing
consistently on EFL WK2.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
6:57 AM Changeset in webkit [138576] by Christophe Dumez
  • 3 edits in trunk/Source/WebCore

Regression(r138545): Makes WebAudio tests crash
https://bugs.webkit.org/show_bug.cgi?id=105869

Reviewed by Philippe Normand.

Stop using smart pointers and adoptGRef() for the
GstBus object and call gst_object_unref() manually.
This fixes assertions hits when calling adoptGRef()
since the GstBus object has a floating reference.

Alternatively, we could keep using smart pointers
and stop calling adoptGRef() so that
gst_object_ref_sink() is called and the floating
flag is cleared but I think it is clearer to do
it manually here.

No new tests, already covered by existing tests.

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::messageCallback):
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::~AudioDestinationGStreamer):

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::~AudioFileReader):
(WebCore::AudioFileReader::decodeAudioForBusCreation):

6:52 AM Changeset in webkit [138575] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed gardening, unskip a now passing test.

  • platform/qt/TestExpectations:
3:56 AM Changeset in webkit [138574] by Christophe Dumez
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Invalid use of temporary object in ProcessLauncher::launchProcess()
https://bugs.webkit.org/show_bug.cgi?id=105867

Reviewed by Kenneth Rohde Christiansen.

Fix invalid use of temporary object in ProcessLauncher::launchProcess()
for prefixedExecutablePath.

  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::ProcessLauncher::launchProcess):

1:51 AM Changeset in webkit [138573] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

Unreviewed GTK gardening of the unit tests.

Skip the TestInspectorServer unit test that's timing out completely.

  • Scripts/run-gtk-tests:

(TestRunner):

Dec 29, 2012:

5:22 PM Changeset in webkit [138572] by Dimitri Glazkov
  • 3 edits in trunk/Source/WebCore

Rename StyleResolver's member variable that holds SelectorChecker to a proper name.
https://bugs.webkit.org/show_bug.cgi?id=105864

In https://bugs.webkit.org/show_bug.cgi?id=105660#c11, Antti suggested renaming m_checker to
m_selectorChecker. I've forgotten about that, but now I remembered it.

Reviewed by Eric Seidel.

No change in functionality, covered by existing tests.

  • css/StyleResolver.cpp/h: Renamed all instances of m_checker to m_selectorChecker.
4:29 PM Changeset in webkit [138571] by Dimitri Glazkov
  • 8 edits in trunk/Source/WebCore

Move pointer to Document up from SelectorChecker to StyleResolver.
https://bugs.webkit.org/show_bug.cgi?id=105863

Now that SelectorChecker is mostly stateless, it no longer needs to keep a pointer to Document, which
makes all the code in StyleResolver that reaches for it sort of weird.

Reviewed by Eric Seidel.

No change in functionality, covered by existing tests.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::SelectorChecker): Changed to take document as argument (only used to set bit fields).
(WebCore::SelectorChecker::checkOneSelector): Changed to use element document.
(WebCore::SelectorChecker::checkScrollbarPseudoClass): Ditto.

  • css/SelectorChecker.h:

(WebCore): Removed unnecessary Document forward declaration.
(SelectorChecker): Changed constructor declaration, and removed m_document member.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver): Adjusted SelectorChecker initializer accordingly.
(WebCore::StyleResolver::initElement): Changed to use own document accessor.
(WebCore::StyleResolver::initForStyleResolve): Ditto.
(WebCore::StyleResolver::matchUARules): Ditto.
(WebCore::StyleResolver::styleForPage): Ditto.
(WebCore::StyleResolver::applyProperty): Ditto.
(WebCore::StyleResolver::checkForGenericFamilyChange): Ditto.
(WebCore::StyleResolver::initializeFontStyle): Ditto.
(WebCore::StyleResolver::setFontSize): Ditto.

  • css/StyleResolver.h:

(WebCore::StyleResolver::document): Changed to use own member.
(WebCore::StyleResolver::documentSettings): Ditto.
(StyleResolver): Added m_document member.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorQuery::matches): Changed callsite to reflect new constructor signature.
(WebCore::SelectorQuery::queryAll): Ditto.
(WebCore::SelectorQuery::queryFirst): Ditto.

  • html/shadow/ContentSelectorQuery.cpp:

(WebCore::ContentSelectorChecker::ContentSelectorChecker): Ditto.
(WebCore::ContentSelectorQuery::ContentSelectorQuery): Ditto.

  • html/shadow/ContentSelectorQuery.h:

(ContentSelectorChecker): Removed unnecessary argument.

2:17 PM Changeset in webkit [138570] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Windows build fix.

  • win/WebKit2Common.vsprops:
1:58 PM Changeset in webkit [138569] by weinig@apple.com
  • 21 edits
    1 add in trunk/Source/WebKit2

Add supplementability to the NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=105838

Reviewed by Dan Bernstein.

This patch adds a NetworkProcessSupplement, which is almost identical to
WebProcessSupplement, but has a different initialization override. It also
stops WebProcessSupplement from inheriting from MessageReceiver (and makes
everything that is a WebProcessSupplement also a MessageReceiver) as keeping
that would cause classes that need to be both WebProcessSupplements and
NetworkProcessSupplements inherit from MessageReceiver twice.

  • GNUmakefile.list.am:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::downloadsAuthenticationManager):
(WebKit::NetworkProcess::initializeNetworkProcess):

  • NetworkProcess/NetworkProcess.h:

(WebKit):
(NetworkProcess):
(WebKit::NetworkProcess::supplement):
(WebKit::NetworkProcess::addSupplement):

  • Shared/Network/CustomProtocols/CustomProtocolManager.h:

(CustomProtocolManager):

  • Shared/Network/NetworkProcessSupplement.h: Added.

(WebKit):
(NetworkProcessSupplement):
(WebKit::NetworkProcessSupplement::~NetworkProcessSupplement):
(WebKit::NetworkProcessSupplement::initialize):

  • Target.pri:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/ApplicationCache/WebApplicationCacheManager.h:
  • WebProcess/Authentication/AuthenticationManager.h:
  • WebProcess/Cookies/WebCookieManager.h:
  • WebProcess/Geolocation/WebGeolocationManager.h:
  • WebProcess/KeyValueStorage/WebKeyValueStorageManager.h:
  • WebProcess/MediaCache/WebMediaCacheManager.h:
  • WebProcess/Notifications/WebNotificationManager.h:
  • WebProcess/ResourceCache/WebResourceCacheManager.h:
  • WebProcess/WebCoreSupport/WebDatabaseManager.h:
  • WebProcess/WebProcessSupplement.h:
  • win/WebKit2.vcproj:
12:11 PM BuildingGtk edited by Philippe Normand
(diff)
11:10 AM Changeset in webkit [138568] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Cookies with an IP domain are not being loaded properly into memory
https://bugs.webkit.org/show_bug.cgi?id=105859

PR 271597

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-12-29
Reviewed by George Staikos.

The isIP flag isn't persistented in the database. We need to check it
again when we load it into memory.

  • platform/blackberry/CookieManager.cpp:

(WebCore::CookieManager::getBackingStoreCookies):

10:11 AM Changeset in webkit [138567] by commit-queue@webkit.org
  • 7 edits
    1 move in trunk/Source/WebCore

[EFL][WebGL] Refactor GLXImplementation.
https://bugs.webkit.org/show_bug.cgi?id=105825

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-29
Reviewed by Kenneth Rohde Christiansen.

This patch decouples native window management and logic to find surface configuration in GLX implementation.

  • platform/graphics/opengl/GLDefs.h:
  • platform/graphics/surfaces/glx/GLXConfigSelector.h: Renamed from Source/WebCore/platform/graphics/surfaces/glx/GLXWindowResources.h.

(WebCore):
(GLXConfigSelector):
(WebCore::GLXConfigSelector::GLXConfigSelector):
(WebCore::GLXConfigSelector::~GLXConfigSelector):
(WebCore::GLXConfigSelector::visualInfo):
(WebCore::GLXConfigSelector::pBufferContextConfig):
(WebCore::GLXConfigSelector::surfaceContextConfig):
(WebCore::GLXConfigSelector::reset):
(WebCore::GLXConfigSelector::createConfig):

Helper class to find surface configuration.

  • platform/graphics/surfaces/glx/GLXContext.h:

(GLXOffScreenContext):

  • platform/graphics/surfaces/glx/GLXSurface.cpp:

(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurface::configuration):
(WebCore::GLXTransportSurface::setGeometry):
(WebCore::GLXTransportSurface::destroy):
(WebCore::GLXPBuffer::GLXPBuffer):
(WebCore::GLXPBuffer::initialize):
(WebCore::GLXPBuffer::configuration):

  • platform/graphics/surfaces/glx/GLXSurface.h:

(GLXTransportSurface):
(GLXPBuffer):

Inheritance changed from X11OffScreenWindow to GLPlatformSurface.

  • platform/graphics/surfaces/glx/X11WindowResources.cpp:

(WebCore):
(WebCore::X11OffScreenWindow::X11OffScreenWindow):
(WebCore::X11OffScreenWindow::reSizeWindow):
(WebCore::X11OffScreenWindow::createOffscreenWindow):
(WebCore::X11OffScreenWindow::destroyWindow):
(WebCore::X11OffScreenWindow::nativeSharedDisplay):
(WebCore::X11OffScreenWindow::setVisualInfo):
(WebCore::X11OffScreenWindow::isXRenderExtensionSupported):

  • platform/graphics/surfaces/glx/X11WindowResources.h:

(WebCore::SharedX11Resources::create):
(SharedX11Resources):
(X11OffScreenWindow):

Removed code related to surface configiration.

9:02 AM Changeset in webkit [138566] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Change bug for some inspector tests
https://bugs.webkit.org/show_bug.cgi?id=105842

Unreviewed gardening.

Bug 43332 was landed. But these tests still fail on GTK port.
And change bug to track the failures.

Patch by Seokju Kwon <Seokju Kwon> on 2012-12-29

  • platform/gtk/TestExpectations:
8:14 AM Changeset in webkit [138565] by aroben@webkit.org
  • 3 edits in trunk/Source/WebKit/mac

Web Inspector: Mac WK1 Inspector can't save/load timeline data
https://bugs.webkit.org/show_bug.cgi?id=105547

Reviewed by Pavel Feldman.

  • WebCoreSupport/WebInspectorClient.h: Declared new overrides and

member variables necessary for save support.

  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorFrontendClient::save):
(WebInspectorFrontendClient::append):
Implemented these to make saving timeline data work. (It seems to me
the InspectorFrontendClient API could be cleaned up a bit. I had to
look at Chromium source code to determine that I needed to call back
into the InspectorFrontendAPI JS object after saving/appending, and
that I needed to keep a map of passed URLs -> chosen URLs.)

(-[WebInspectorWindowController window:willPositionSheet:usingRect:]):
Tweaked the position of the sheet so that open/save sheets look a
little bette.r

(-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
Implemented to make loading timeline data work.

4:41 AM Changeset in webkit [138564] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Timeline] cpu bar popover shows wrong duration / cpu time.
https://bugs.webkit.org/show_bug.cgi?id=105854

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2012-12-29
Reviewed by Vsevolod Vlasov.

Problem: CPU task indexes are already incremented before written to
data structure.

  • inspector/front-end/TimelinePanel.js:

(WebInspector.TimelinePanel.prototype._refreshMainThreadBars):
Use for loop to get correct indexes.

3:38 AM Changeset in webkit [138563] by loislo@chromium.org
  • 2 edits in trunk/Tools

Web Inspector: Native Memory Instrumentation plugin: do not generate 'not instrumented' warning for instrumented mutable members.
https://bugs.webkit.org/show_bug.cgi?id=105855

Reviewed by Vsevolod Vlasov.

Extract MemberExpr from ImplicitCastExpr. It happens when we instrument a mutable member because
addMember expects const T& and the mutable ref to member implicitly converts into const ref to member.

  • clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:

(ReportMemoryUsageVisitor):
(clang::AddMemberCallVisitor::VisitCallExpr):
(clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
(clang::ReportMemoryUsageVisitor::checkMembersCoverage):

2:53 AM Changeset in webkit [138562] by loislo@chromium.org
  • 2 edits in trunk/Tools

Web Inspector: Native Memory Instrumentation plugin: move function bodies out of class declarations.
https://bugs.webkit.org/show_bug.cgi?id=105852

Reviewed by Alexander Pavlov.

  • clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:

(clang):
(AddMemberCallVisitor):
(ReportMemoryUsageVisitor):
(clang::ReportMemoryUsageAction::ParseArgs):
(clang::AddMemberCallVisitor::VisitCallExpr):
(clang::ReportMemoryUsageVisitor::VisitCXXMethodDecl):
(clang::ReportMemoryUsageVisitor::emitWarning):
(clang::ReportMemoryUsageVisitor::findInstrumentationMethod):
(clang::ReportMemoryUsageVisitor::needsToBeInstrumented):
(clang::ReportMemoryUsageVisitor::CheckMembersCoverage):

1:27 AM Changeset in webkit [138561] by loislo@chromium.org
  • 14 edits in trunk/Source

Web Inspector: Native Memory Instrumentation: instrument not instrumented members.
https://bugs.webkit.org/show_bug.cgi?id=105830

Reviewed by Vsevolod Vlasov.

In some cases we don't want to visit some class members.
As example we decided to skip pointers to interface classes such as GraphicLayerClient.
We could use addWeakPointer for them but it can't be used for nonpointer members.
In the offline discussion we came to a conclusion that we need a new instrumentation
method ignoreMember, which will be used for all the members which we won't like to visit/instrument.

DriveBy: Also I instrumented not yet instrumented members.

Source/WebCore:

  • bindings/v8/DOMWrapperMap.h:

(WebCore::DOMWrapperMap::reportMemoryUsage):

  • bindings/v8/ScriptWrappable.h:

(WebCore::ScriptWrappable::reportMemoryUsage):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::reportMemoryUsage):

  • platform/KURLGoogle.cpp:

(WebCore::KURLGooglePrivate::reportMemoryUsage):

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::reportMemoryUsage):

  • platform/audio/AudioArray.h:

(WebCore::AudioArray::reportMemoryUsage):

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::reportMemoryUsage):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::reportMemoryUsage):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::RowStruct::reportMemoryUsage):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::reportMemoryUsage):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::reportMemoryUsage):

Source/WTF:

  • wtf/MemoryInstrumentation.h:

(MemoryClassInfo):
(WTF::MemoryClassInfo::ignoreMember):

1:19 AM Changeset in webkit [138560] by commit-queue@webkit.org
  • 4 edits in trunk

Source/WebCore: Web Inspector: refactor DefaultTextEditor - annotate handlers and fix getters style
https://bugs.webkit.org/show_bug.cgi?id=105829

Patch by Andrey Lushnikov <lushnikov@chromium.com> on 2012-12-29
Reviewed by Pavel Feldman.

Refactor DefaultTextEditor.js: improve handler method annotations,
remove "get" prefix from method names, get rid of unnecessary
delegation (e.g. see _handleCut).

No new tests: no change in behaviour.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor):
(WebInspector.DefaultTextEditor.prototype._contextMenu):
(WebInspector.DefaultTextEditor.prototype.selection):
(WebInspector.DefaultTextEditor.prototype.lastSelection):
(WebInspector.DefaultTextEditor.prototype.wasShown):
(WebInspector.DefaultTextEditor.prototype.willHide):
(WebInspector.TextEditorChunkedPanel.prototype.createNewChunk):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.wasShown):
(WebInspector.TextEditorMainPanel.prototype.willHide):
(WebInspector.TextEditorMainPanel.prototype.populateContextMenu):
(WebInspector.TextEditorMainPanel.prototype.splitChunkOnALine):
(WebInspector.TextEditorMainPanel.prototype.expandChunks):
(WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
(WebInspector.TextEditorMainPanel.prototype.selection):
(WebInspector.TextEditorMainPanel.prototype.lastSelection):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._handleSelectionChange):
(WebInspector.TextEditorMainPanel.prototype._handleTextInput):
(WebInspector.TextEditorMainPanel.prototype.handleKeyDown):
(WebInspector.TextEditorMainPanel.prototype._handleCut):

LayoutTests: Web Inspector: refactor DefaultTextEditor
https://bugs.webkit.org/show_bug.cgi?id=105829

Patch by Andrey Lushnikov <lushnikov@chromium.com> on 2012-12-29
Reviewed by Pavel Feldman.

Fix test to correlate with refactoring of DefaultTextEditor.

  • inspector/editor/text-editor-selection.html:
12:02 AM Changeset in webkit [138559] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[webkitpy] Omit webkitpy/thirdparty/BeautifulSoup.py from code coverage checking
https://bugs.webkit.org/show_bug.cgi?id=105835

Reviewed by Dirk Pranke.

The BeautifulSoup module is a third-party import and as such we don't have much control
over its testing. Because of that it should be omitted from code coverage checking.

  • Scripts/webkitpy/test/main.py:

(Tester._run_tests):

Dec 28, 2012:

9:42 PM Changeset in webkit [138558] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION: r138555 asserts on Linux EFL/Qt debug builds
https://bugs.webkit.org/show_bug.cgi?id=105848

Unreviewed test fix.

Patch by No'am Rosenthal <Noam Rosenthal> on 2012-12-28

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

Added parameter name to noop shader.

9:30 PM Changeset in webkit [138557] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] MiniBrowser could not be launched on specific machine
https://bugs.webkit.org/show_bug.cgi?id=105844

Reviewed by Gyuyoung Kim.

  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::ProcessLauncher::launchProcess):
Modified to avoid bad use of temporary object.

9:10 PM Changeset in webkit [138556] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[Texmap] Use a transform uniform instead of u_flip/u_textureSize
https://bugs.webkit.org/show_bug.cgi?id=105809

Patch by No'am Rosenthal <Noam Rosenthal> on 2012-12-28
Reviewed by Martin Robinson.

In order to support tiled-patterns, we'd have to apply texture-space transformations in the
vertex shader.
This patch cleans up the current texture-space transformations, and uses
single matrix uniform instead of the current uniforms.

No new tests, refactor only.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore):

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(TextureMapperShaderProgram):

7:05 PM Changeset in webkit [138555] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[Texmap] Edge antialiasing in TextureMapper could be done with less per-pixel calls
https://bugs.webkit.org/show_bug.cgi?id=105377

Patch by No'am Rosenthal <Noam Rosenthal> on 2012-12-28
Reviewed by Kenneth Rohde Christiansen.

Instead of passing 8 quad edge coefficients as uniforms and analyze the distance in the
fragment shader, we render the antialiased quad as 4 edge triangles, which originate in the
center of the quad.

The vertex shader expands the quad based on the screen transform, and applies a value to each vertex to be interpolated by the GPU.

It is very difficult to test performance gain; However, the following is apparent:

  • The matrix multiplications and inversions done before in the quad inflation code were always visible in instruments/valgrind and they are now gone.
  • We now perform a single smoothstep() command per pixel instead of 8 clamp(dot()) commands.
  • It should now be possible to antialias individual edges.

Covered by existing tests.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGLData::getStaticVBO):

Cache the unit-rect and edge-triangle vertex data in a VBO.

(WebCore::TextureMapperGLData::~TextureMapperGLData):

Clear the cached VBOs upon destruction.

(WebCore::TextureMapperGL::drawBorder):
(WebCore::TextureMapperGL::drawTexture):

Removed call to useProgram, since it's already called in drawTexturedQuadWithProgram.

(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):
(WebCore::TextureMapperGL::drawSolidColor):

Use the new signature "draw" instead of "drawQuad".

(WebCore::TextureMapperGL::drawEdgeTriangles):
(WebCore::TextureMapperGL::drawUnitRect):
(WebCore::TextureMapperGL::draw):

Removed DrawQuad, instead draw either a unit rect or edge triangles.

(WebCore::TextureMapperGL::beginClip):

Use the new setMatrix function.

  • platform/graphics/texmap/TextureMapperGL.h:

Added a paint flag for antialiasing.

  • platform/graphics/texmap/TextureMapperShaderManager.cpp:

(WebCore::TextureMapperShaderProgram::setMatrix):

Since we now set the matrix in multiple locations, added a convenience
function for matrix uniform.

(WebCore::getShaderSpec):

Update the vertex and fragment shader to account for the new antialiasing
mechanism.

  • platform/graphics/texmap/TextureMapperShaderManager.h:

(TextureMapperShaderProgram):

6:25 PM Changeset in webkit [138554] by joone.hur@intel.com
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Implement ewk_context_resource_cache_clear
https://bugs.webkit.org/show_bug.cgi?id=104782

The purpose of this API is to clear HTTP caches in local storage and
all resources cached in memory such as images, CSS, JavaScript, XSL,
and fonts.

Reviewed by Kenneth Rohde Christiansen.

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::clearResourceCache): Call WebResourceCacheManager::ClearCacheForAllOrigins.
(ewk_context_resource_cache_clear):

  • UIProcess/API/efl/ewk_context.h: Add ewk_context_resource_cache_clear.
  • UIProcess/API/efl/ewk_context_private.h:

(EwkContext):

6:05 PM Changeset in webkit [138553] by mrowe@apple.com
  • 13 edits
    2 adds in trunk

Move logic for extracting the OS X marketing version in to WebCore
<http://webkit.org/b/105841> / <rdar://problem/10736041>

Reviewed by Dan Bernstein.

Source/WebCore:

The logic for extracting the OS X markerting version is moved in to systemMarketingVersion
from WebKitSystemInterface (post-10.8) and WebKit (pre-10.8).

  • WebCore.exp.in: Export systemMarketingVersion and remove the old WKSI symbol.
  • WebCore.xcodeproj/project.pbxproj: Add the new files.
  • platform/mac/SystemVersionMac.h: Added.
  • platform/mac/SystemVersionMac.mm: Added.

(WebCore::createSystemMarketingVersion): Read the marketing version out of SystemVersion.plist
(WebCore::callGestalt):
(WebCore::createSystemMarketingVersion): Build the marketing version by piecing together the results
of calls to Gestalt.
(WebCore::systemMarketingVersion): Return the cached string.

  • platform/mac/WebCoreSystemInterface.h: Remove the old WKSI symbol.
  • platform/mac/WebCoreSystemInterface.mm: Ditto.

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Remove the code related to the WKSI symbol.

  • WebView/WebView.mm:

(systemMarketingVersionForUserAgentString): Call the WebCore function instead of the WKSI function.
(+[WebView _standardUserAgentWithApplicationName:]): Retain the result now that our helper doesn't
do that for us.

Source/WebKit2:

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::systemMarketingVersionForUserAgentString): Call the WebCore function instead
of the WKSI function.
(WebKit::WebPageProxy::standardUserAgent):

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Remove the code related to the WKSI symbol.

WebKitLibraries:

  • WebKitSystemInterface.h:
4:29 PM Changeset in webkit [138552] by fsamuel@chromium.org
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed rebaseline.

  • platform/chromium-win-xp/inspector/extensions/extensions-resources-expected.txt: Removed.
4:10 PM Changeset in webkit [138551] by fsamuel@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed updated test expectations

  • platform/chromium/TestExpectations:
3:51 PM Changeset in webkit [138550] by fsamuel@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed updated TestExpectations. Mark test as fail on XP only.

  • platform/chromium/TestExpectations:
3:32 PM Changeset in webkit [138549] by fsamuel@chromium.org
  • 2 edits in trunk/LayoutTests

[Templates]: Fix assert in colgroup parse handling
https://bugs.webkit.org/show_bug.cgi?id=105837

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2012-12-28
Reviewed by Eric Seidel.

  • html5lib/resources/template.dat:
2:03 PM Changeset in webkit [138548] by fsamuel@chromium.org
  • 2 edits in trunk/Source/WebKit/chromium

Roll Chromium DEPS to r174739
https://bugs.webkit.org/show_bug.cgi?id=105813

Unreviewed.

  • DEPS:
1:48 PM Changeset in webkit [138547] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix assert seen when adding a custom protocol handler before an initial
web process has been created.

  • UIProcess/WebContext.h:

(WebKit::WebContext::sendToNetworkingProcess):

1:07 PM Changeset in webkit [138546] by rafaelw@chromium.org
  • 4 edits in trunk

[Templates]: Fix assert in colgroup parse handling
https://bugs.webkit.org/show_bug.cgi?id=105837

Reviewed by Eric Seidel.

Source/WebCore:

Tests added to html5lib.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processEndTag):

LayoutTests:

  • html5lib/resources/template.dat:
1:04 PM Changeset in webkit [138545] by Philippe Normand
  • 4 edits in trunk/Source/WebCore

[GStreamer] GstMessage handler in AudioDestination
https://bugs.webkit.org/show_bug.cgi?id=105292

Reviewed by Martin Robinson.

Handle GStreamer warnings and errors coming from the playback
pipeline. For now we only display warnings on the console.

  • platform/audio/gstreamer/AudioDestinationGStreamer.cpp:

(WebCore::messageCallback):
(WebCore):
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
(WebCore::AudioDestinationGStreamer::finishBuildingPipelineAfterWavParserPadReady):
(WebCore::AudioDestinationGStreamer::handleMessage):

  • platform/audio/gstreamer/AudioDestinationGStreamer.h:

(AudioDestinationGStreamer):

12:32 PM Changeset in webkit [138544] by Martin Robinson
  • 32 edits
    1 copy
    1 add in trunk

[GTK][WK2] Add support for IME Composition
https://bugs.webkit.org/show_bug.cgi?id=65093

Reviewed by Carlos Garcia Campos.

Source/WebCore:

No new tests. The GtkInputMethodFilter is covered by unit tests in TestWebKitAPI.
Doing functional tests for this behavior is much more complex.

  • platform/gtk/GtkInputMethodFilter.cpp:

(WebCore::GtkInputMethodFilter::sendCompositionAndPreeditWithFakeKeyEvents): Now
pass along whether or not an event was faked.

  • platform/gtk/GtkInputMethodFilter.h: Ditto.

Source/WebKit/gtk:

Update the method signatures for concrete WebKit1 implementation of
the GtkInputMethodFilter.

  • WebCoreSupport/WebViewInputMethodFilter.cpp:

(WebKit::WebViewInputMethodFilter::sendSimpleKeyEvent):
(WebKit::WebViewInputMethodFilter::sendKeyEventWithCompositionResults):

  • WebCoreSupport/WebViewInputMethodFilter.h:

(WebViewInputMethodFilter):

Source/WebKit2:

Add a WebKit2 implementation of the GtkInputMethodFilter and provide
the necessary plumbing to pass composition information along with
input method events.

  • GNUmakefile.list.am: Add new files to the source list.
  • Shared/EditorState.cpp: The cursorRect is now passed for GTK+ as well as

Qt, so update the encode and decode methods to pass that along.

  • Shared/EditorState.h: Add the cursorRect member for GTK+ as well.
  • Shared/NativeWebKeyboardEvent.h:

(NativeWebKeyboardEvent): Keyboard events should also have knowledge of
the compositionResults and whether or not the event was faked for composition
purposes.

  • Shared/gtk/NativeWebKeyboardEventGtk.cpp: Ditto.
  • Shared/gtk/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebKeyboardEvent): Copy the logic of PlatformKeyEvent,
for properly setting the windows key code and the event text from the composition
results.

  • Shared/gtk/WebEventFactory.h: The createWebKeyboardEvent factory now takes a

CompositionResults argument.

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::doneWithKeyEvent): Don't forward keyboard events that
were faked for composition reasons. These events originated from WebKit and should
never be passed to parent classes.
(WebKit::PageClientImpl::updateTextInputState): Plumb through the updateTextInputState
method to the WebViewBase.

  • UIProcess/API/gtk/PageClientImpl.h:

(PageClientImpl): Add a updateTextInputState method.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(_WebKitWebViewBasePrivate): Instead of having an input method context as a member
keep a WebViewBaseInputMethodFilter.
(webkitWebViewBaseRealize): Set the filter widget when the WebViewBase is realized.
(webkit_web_view_base_init): No longer create a input method context during init.
(webkitWebViewBaseFocusInEvent): Pass along focus in events to the filter.
(webkitWebViewBaseFocusOutEvent): Pass along focus out events to the filter.
(webkitWebViewBaseKeyPressEvent): Instead of passing key presses directly to the WebProcess,
filter them through the input method filter.
(webkitWebViewBaseKeyReleaseEvent): Ditto.
(webkitWebViewBaseButtonPressEvent): Notify the input method filter about button press events.
(webkitWebViewBaseGetIMContext): The input method filter owns the input method now.
(webkitWebViewBaseSetInputMethodState): Add a bit of plumbing for the PageClient.
(webkitWebViewBaseUpdateTextInputState): Ditto.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Add plumbing declarations.
  • UIProcess/API/gtk/WebViewBaseInputMethodFilter.cpp: Added. An implementation of GtkInputMethodFilter for WebKit2.
  • UIProcess/API/gtk/WebViewBaseInputMethodFilter.h: Copied from Source/WebKit/gtk/WebCoreSupport/WebViewInputMethodFilter.h.
  • UIProcess/PageClient.h:

(PageClient): updateInputMethod state is now for both Qt and GTK+.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::editorStateChanged): Pass the editor state for GTK+ as well as Qt.
(WebKit::WebPageProxy::setComposition): Moved this method from WebPageProxyQt as it's used for GTK+ now as well.
(WebKit::WebPageProxy::confirmComposition): Ditto.
(WebKit::WebPageProxy::cancelComposition): Ditto.

  • UIProcess/WebPageProxy.h:

(WebPageProxy): The setInputMethodState message is for GTK+ as well as Qt now.

  • UIProcess/WebPageProxy.messages.in: Ditto.
  • UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::setInputMethodState): Ditto.

  • UIProcess/qt/WebPageProxyQt.cpp: Move some methods to the platform-independent file.
  • WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp: More closely match the WebKit1

logic for dealing with key events so that composition events will be handled properly.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState): Properly pass the cursorRect for GTK+.
(WebKit::targetFrameForEditing): Moved from the Qt file, because its used by GTK+ as well. They
now pass along the updated EditorState as well, just like the Mac versions.
(WebKit::WebPage::confirmComposition): Ditto.
(WebKit::WebPage::setComposition): Ditto.
(WebKit::WebPage::cancelComposition): Ditto.

  • WebProcess/WebPage/WebPage.h: The above messages are now for GTK+ as well as Qt.
  • WebProcess/WebPage/WebPage.messages.in: Ditto.
  • WebProcess/WebPage/qt/WebPageQt.cpp: Moved some methods to the platform-independent file.

Tools:

Update unit tests for GtkInputMethodFilter to note whether or not an event
was a fake event synthesized for composition purposes. This is now used
for WebKit2.

  • TestWebKitAPI/Tests/gtk/InputMethodFilter.cpp:

(TestWebKitAPI::TestInputMethodFilter::sendSimpleKeyEvent):
(TestWebKitAPI::TestInputMethodFilter::sendKeyEventWithCompositionResults):
(TestWebKitAPI::TEST):

  • gtk/generate-gtkdoc:

(get_webkit2_options): Skip new files in the WebKit2 source directory for documentation
generation.

10:32 AM Changeset in webkit [138543] by eae@chromium.org
  • 3 edits
    2 adds in trunk

REGRESSION (r138196): Regions with text-overflow: ellipsis; are being ellipsized unnecessarily
https://bugs.webkit.org/show_bug.cgi?id=105600

Source/WebCore:

Reviewed by Darin Adler.

Pixel-snap lineBoxEdge before comparing with the block edge as
the lineBox edge isn't guaranteed to be snapped to device pixels
on all platforms.

Test: fast/sub-pixel/ellipsis-table.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::checkLinesForTextOverflow):

LayoutTests:

Reviewed by Darin Adler.

Add test for text-overflow: ellipsis inside a table.

  • fast/sub-pixel/ellipsis-table-expected.html: Added.
  • fast/sub-pixel/ellipsis-table.html: Added.
9:45 AM Changeset in webkit [138542] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] DrawingBuffer initialization loop breaks if completely out of memory
https://bugs.webkit.org/show_bug.cgi?id=105732

Patch by Brandon Jones <bajones@chromium.org> on 2012-12-28
Reviewed by Kenneth Russell.

When DrawingBuffer allocation fails because s_currentResourceUsePixels is maxed out
it now forces WebGLRenderingContext creation to fail gracefully.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::create): On Chromium, check for failure to allocate a DrawingBuffer

9:02 AM Changeset in webkit [138541] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Slightly clean up WebCore's Base.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=105808

Reviewed by Sam Weinig.

  • Configurations/Base.xcconfig: Simplify the definition of GCC_GENERATE_DEBUGGING_SYMBOLS,

which is always YES.

8:52 AM Changeset in webkit [138540] by fsamuel@chromium.org
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed rebaseline

  • platform/chromium-win-xp/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-tableValues-prop-expected.png: Added.
8:49 AM Changeset in webkit [138539] by charles.wei@torchmobile.com.cn
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Remove unused BackingStorePrivate::m_defersBlit
https://bugs.webkit.org/show_bug.cgi?id=105811
RIM PR 272067

Reviewed by George Staikos.
Internally Reviewed by Jakob Petsovits.

BackingStorePrivate::m_defersBlit is not used anywhere, it should
be removed to simplify the code and to avoid confusion.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::blitVisibleContents):

  • Api/BackingStore.h:
  • Api/BackingStore_p.h:

(BackingStorePrivate):

8:36 AM Changeset in webkit [138538] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Appease the Windows Gods.

  • WebProcess/Notifications/WebNotificationManager.cpp:
8:30 AM Changeset in webkit [138537] by rafaelw@chromium.org
  • 4 edits in trunk

Heap-use-after-free in WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement
https://bugs.webkit.org/show_bug.cgi?id=105780

Reviewed by Eric Seidel.

Source/WebCore:

This was regression was created by the HTMLTemplateElement implementation. The issue was a missed instance of
"fragment or template contents" case related to the parsing of colgroups.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processEndOfFile):

LayoutTests:

  • html5lib/resources/template.dat:
8:11 AM Changeset in webkit [138536] by vsevik@chromium.org
  • 25 edits in trunk

Web Inspector: Introduce uri as a UISourceCode unique identifier in workspace.
https://bugs.webkit.org/show_bug.cgi?id=105799

Reviewed by Pavel Feldman.

Source/WebCore:

Added uri field to UISourceCode.
Debugger and LiveEdit uiSourceCodes are now created through WorkspaceProviders (not projects yet though)
which are responsible for unique uri generation.
Extracted generic content provider based WorkspaceProvider functionality and url-to-uri conversion logic to ContentProviderWorkspaceProvider class.

  • inspector/front-end/BreakpointManager.js:

(WebInspector.BreakpointManager.sourceFileId):

  • inspector/front-end/CompilerScriptMapping.js:
  • inspector/front-end/DebuggerScriptMapping.js:

(WebInspector.DebuggerScriptMapping):

  • inspector/front-end/DefaultScriptMapping.js:

(WebInspector.DefaultScriptMapping):
(WebInspector.DefaultScriptMapping.prototype.addScript):
(WebInspector.DebuggerWorkspaceProvider):
(WebInspector.DebuggerWorkspaceProvider.prototype.addDebuggerFile):

  • inspector/front-end/LiveEditSupport.js:

(WebInspector.LiveEditSupport):
(WebInspector.LiveEditSupport.prototype.uiSourceCodeForLiveEdit):
(WebInspector.LiveEditWorkspaceProvider):
(WebInspector.LiveEditWorkspaceProvider.prototype.addLiveEditFile):

  • inspector/front-end/NetworkUISourceCodeProvider.js:

(WebInspector.NetworkUISourceCodeProvider.prototype._addFile):

  • inspector/front-end/NetworkWorkspaceProvider.js:

(WebInspector.ContentProviderWorkspaceProvider):
(WebInspector.ContentProviderWorkspaceProvider.uriForURL):
(WebInspector.ContentProviderWorkspaceProvider.prototype.addFile):
(WebInspector.ContentProviderWorkspaceProvider.prototype.uniqueURI):
(WebInspector.NetworkWorkspaceProvider):
(WebInspector.NetworkWorkspaceProvider.prototype.addNetworkFile):

  • inspector/front-end/SASSSourceMapping.js:

(_bindUISourceCode):

  • inspector/front-end/ScriptSnippetModel.js:

(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype._scrollChanged):
(WebInspector.TabbedEditorContainer.prototype._selectionChanged):
(WebInspector.TabbedEditorContainer.prototype._editorClosedByUserAction):
(WebInspector.TabbedEditorContainer.prototype._updateHistory.tabIdToURI):
(WebInspector.TabbedEditorContainer.prototype._updateHistory):
(WebInspector.TabbedEditorContainer.prototype._appendFileTab):
(WebInspector.TabbedEditorContainer.prototype.reset):

  • inspector/front-end/UISourceCode.js:

(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.uri):

  • inspector/front-end/Workspace.js:

(WebInspector.FileDescriptor):
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype.uiSourceCodeForURI):
(WebInspector.Workspace):
(WebInspector.Workspace.prototype.uiSourceCodeForURI):
(WebInspector.Workspace.prototype.addTemporaryUISourceCode):
(WebInspector.Workspace.prototype.removeTemporaryUISourceCode):
(WebInspector.Workspace.prototype.requestFileContent):
(WebInspector.Workspace.prototype.setFileContent):
(WebInspector.Workspace.prototype.searchInFileContent):
(WebInspector.Workspace.prototype.reset):

  • inspector/front-end/inspector.js:

LayoutTests:

  • http/tests/inspector/compiler-script-mapping.html:
  • http/tests/inspector/workspace-test.js:

(initialize_WorkspaceTest.InspectorTest.createWorkspace):
(initialize_WorkspaceTest.InspectorTest.addMockUISourceCodeToWorkspace):

  • inspector/debugger/breakpoint-manager.html:
  • inspector/debugger/resource-script-mapping.html:
  • inspector/debugger/scripts-file-selector.html:
  • inspector/debugger/scripts-panel.html:
  • inspector/debugger/scripts-sorting.html:
  • inspector/debugger/ui-source-code-display-name.html:
  • inspector/debugger/ui-source-code.html:
  • inspector/uisourcecode-revisions.html:
8:09 AM Changeset in webkit [138535] by mkwst@chromium.org
  • 4 edits in trunk/LayoutTests

[Qt,EFL,GTK] Unreviewed gardening.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/qt/TestExpectations:

Skipping http/tests/security/sandboxed-iframe-form-top.html
as it's leaking state (console messages) into the next test.
See wkbug.com/105819 and wkbug.com/85522 for details.

6:42 AM Changeset in webkit [138534] by yurys@chromium.org
  • 12 edits
    2 adds in trunk

Web Inspector: debugger should step into event handler on event dispatch
https://bugs.webkit.org/show_bug.cgi?id=105827

Reviewed by Pavel Feldman.

Source/WebCore:

Added m_pauseInNextEventListener to InspectorDOMDebuggerAgent. The flag is set
to true when "step into" is pressed and reset to false when either JS execution
pauses, the agent gets disabled or JS call stack becomes empty. If the flag is
true and the next JS stetement to be executed belongs to a JS event listener we
will stop in that listener, otherwise we have two options:

1) Control flow directly(without comming through the native bindings) reaches some JS

statement and will pause in the corresponding JS function, in which case the
flag will be reset;

2) JS call stack becomes empty and execution will continue in the native code. We

use didProcessTask to detect such cases and reset the flag to false every time
event queue finishes next task.

Test: inspector/debugger/debugger-step-into-event-listener.html

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::reportMemoryUsage):
(WebCore::InspectorController::didProcessTask):

  • inspector/InspectorController.h:

(WebCore):
(InspectorController):

  • inspector/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
(WebCore::InspectorDOMDebuggerAgent::stepInto):
(WebCore):
(WebCore::InspectorDOMDebuggerAgent::didPause):
(WebCore::InspectorDOMDebuggerAgent::cancelStepIntoEventListener):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorDOMDebuggerAgent::clear):

  • inspector/InspectorDOMDebuggerAgent.h:

(InspectorDOMDebuggerAgent):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::stepInto):
(WebCore::InspectorDebuggerAgent::didPause):

  • inspector/InspectorDebuggerAgent.h:

(Listener):

LayoutTests:

  • inspector/debugger/debugger-step-into-event-listener-expected.txt: Added.
  • inspector/debugger/debugger-step-into-event-listener.html: Added.
6:26 AM Changeset in webkit [138533] by weinig@apple.com
  • 11 edits in trunk/Source/WebKit2

Make CustomProtocolManager a WebProcessSupplement
https://bugs.webkit.org/show_bug.cgi?id=105814

Reviewed by Dan Bernstein.

This converts CustomProtocolManager from a global singleton, to be a
supplement of the WebProcess. Since it also needs to act as a supplement
of the NetworkProcess, it adds an initialization function for the NetworkProcess
as well, while we await the arrival of the forthcoming NetworkProcessSupplement.

In addition, this moves the handling of registering and unregistering schemes
directly to the CustomProtocolManager, instead of requiring an unnecessary trip
in the ChildProcess.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::initializeNetworkProcess):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • Shared/Network/CustomProtocols/CustomProtocolManager.h:

(CustomProtocolManager):

  • Shared/Network/CustomProtocols/CustomProtocolManager.messages.in:
  • Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

(+[WKCustomProtocol canInitWithRequest:]):
(-[WKCustomProtocol initWithRequest:cachedResponse:client:]):
(-[WKCustomProtocol startLoading]):
(-[WKCustomProtocol stopLoading]):
(WebKit::CustomProtocolManager::supplementName):
(WebKit::CustomProtocolManager::CustomProtocolManager):
(WebKit::CustomProtocolManager::initialize):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::registerSchemeForCustomProtocol):
(WebKit::WebContext::unregisterSchemeForCustomProtocol):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
4:51 AM Changeset in webkit [138532] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: enable mutation observer in LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=105826

Patch by Andrey Lushnikov <lushnikov@chromium.com> on 2012-12-28
Reviewed by Pavel Feldman.

Enable mutation observer in LayoutTests.

No new tests: no change in behaviour.

  • inspector/front-end/DOMExtension.js:
2:45 AM Changeset in webkit [138531] by sudarsana.nagineni@linux.intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip http/tests/security/sandboxed-iframe-form-top.html which
started failing after r138525.

  • platform/efl/TestExpectations:
1:49 AM Changeset in webkit [138530] by loislo@chromium.org
  • 2 edits in trunk/Tools

Web Inspector: Native Memory Instrumentation. Update clang plugin according to the current state of memory instrumentation code.
https://bugs.webkit.org/show_bug.cgi?id=105800

Reviewed by Yury Semikhatsky.

  • clang/ReportMemoryUsagePlugin/ReportMemoryUsage.cpp:

(clang::ReportMemoryUsageConsumer::ReportMemoryUsageConsumer):
(clang):

1:43 AM Changeset in webkit [138529] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GTK] Some GStreamer-related files don't need to be in libWebCoreGTK
https://bugs.webkit.org/show_bug.cgi?id=105807

Reviewed by Martin Robinson.

  • GNUmakefile.list.am: Move some modules not using GTK nor Cairo

to libWebCorePlatform.

1:26 AM Changeset in webkit [138528] by yurys@chromium.org
  • 11 edits in trunk

Web Inspector: rename distanceToWindow to distance
https://bugs.webkit.org/show_bug.cgi?id=105823

Reviewed by Pavel Feldman.

PerformanceTests:

Updated heap profiler performance test after renaming distanceToWindow to distance.

  • inspector/heap-snapshot-performance-test.js:

Source/WebCore:

Renamed distanceToWindow to distance. Introduced a method on HeapSnapshot
that allows to check if given node should be displayed to the user as having
distance 1.

  • inspector/front-end/HeapSnapshot.js:

(WebInspector.HeapSnapshotEdge.prototype.serialize):
(WebInspector.HeapSnapshotRetainerEdge.prototype.serialize):
(WebInspector.HeapSnapshotNode.prototype.distance):
(WebInspector.HeapSnapshotNode.prototype.serialize):
(WebInspector.HeapSnapshot.prototype._init):
(WebInspector.HeapSnapshot.prototype.dispose):
(WebInspector.HeapSnapshot.prototype.canHaveDistanceOne):
(WebInspector.HeapSnapshot.prototype._calculateDistances):
(WebInspector.HeapSnapshot.prototype._bfs):
(WebInspector.HeapSnapshot.prototype._buildAggregates):

  • inspector/front-end/HeapSnapshotDataGrids.js:

(WebInspector.HeapSnapshotRetainmentDataGrid):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype._sortFields):
(WebInspector.HeapSnapshotConstructorsDataGrid):
(WebInspector.HeapSnapshotConstructorsDataGrid.prototype._sortFields):

  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
(WebInspector.HeapSnapshotObjectNode):
(WebInspector.HeapSnapshotObjectNode.prototype.comparator):
(WebInspector.HeapSnapshotObjectNode.prototype._enhanceData):
(WebInspector.HeapSnapshotInstanceNode.prototype.comparator):
(WebInspector.HeapSnapshotConstructorNode):
(WebInspector.HeapSnapshotConstructorNode.prototype.comparator):
(WebInspector.HeapSnapshotConstructorNode.prototype.get data):

  • inspector/front-end/JSHeapSnapshot.js:

(WebInspector.JSHeapSnapshot.prototype.canHaveDistanceOne):

LayoutTests:

Updated tests after renaming distanceToWindow to distance.

  • inspector/profiler/heap-snapshot-summary-sorting-fields.html:
  • inspector/profiler/heap-snapshot-summary-sorting-instances.html:
  • inspector/profiler/heap-snapshot-summary-sorting.html:
1:08 AM Changeset in webkit [138527] by commit-queue@webkit.org
  • 4 edits in trunk

Web Inspector: refactor DefaultTextEditor's private methods
https://bugs.webkit.org/show_bug.cgi?id=105797

Patch by Andrey Lushnikov <lushnikov@chromium.com> on 2012-12-28
Reviewed by Pavel Feldman.

Source/WebCore:

  • Refactor private methods to public if they are called from external classes
  • Get rid of external private variable access.

No tests: no change in behaviour.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.DefaultTextEditor.prototype.freeCachedElements):
(WebInspector.DefaultTextEditor.prototype._handleTextInput):
(WebInspector.DefaultTextEditor.prototype._handleKeyDown):
(WebInspector.DefaultTextEditor.prototype._handleCut):
(WebInspector.DefaultTextEditor.prototype._contextMenu):
(WebInspector.DefaultTextEditor.prototype._handleScrollChanged):
(WebInspector.DefaultTextEditor.prototype.selection):
(WebInspector.DefaultTextEditor.prototype.lastSelection):
(WebInspector.DefaultTextEditor.prototype.setSelection):
(WebInspector.DefaultTextEditor.prototype.wasShown):
(WebInspector.DefaultTextEditor.prototype._handleFocused):
(WebInspector.DefaultTextEditor.prototype.willHide):
(WebInspector.DefaultTextEditor.prototype.highlightExpression):
(WebInspector.DefaultTextEditor.prototype.overrideViewportForTest):
(WebInspector.TextEditorChunkedPanel.prototype.buildChunks):
(WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
(WebInspector.TextEditorChunkedPanel.prototype.splitChunkOnALine):
(WebInspector.TextEditorChunkedPanel.prototype.createNewChunk):
(WebInspector.TextEditorChunkedPanel.prototype.scroll):
(WebInspector.TextEditorChunkedPanel.prototype._scheduleRepaintAll):
(WebInspector.TextEditorChunkedPanel.prototype.endUpdates):
(WebInspector.TextEditorChunkedPanel.prototype.chunkForLine):
(WebInspector.TextEditorChunkedPanel.prototype.findVisibleChunks):
(WebInspector.TextEditorChunkedPanel.prototype.repaintAll):
(WebInspector.TextEditorChunkedPanel.prototype.scrollTop):
(WebInspector.TextEditorChunkedPanel.prototype.clientHeight):
(WebInspector.TextEditorChunkedPanel.prototype.expandChunks):
(WebInspector.TextEditorChunkedPanel.prototype.totalHeight):
(WebInspector.TextEditorChunkedPanel.prototype.resize):
(WebInspector.TextEditorGutterPanel):
(WebInspector.TextEditorGutterPanel.prototype.freeCachedElements):
(WebInspector.TextEditorGutterPanel.prototype.createNewChunk):
(WebInspector.TextEditorGutterPanel.prototype.textChanged):
(WebInspector.TextEditorGutterChunk.prototype.get height):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.wasShown):
(WebInspector.TextEditorMainPanel.prototype.willHide):
(WebInspector.TextEditorMainPanel.prototype.highlightLine):
(WebInspector.TextEditorMainPanel.prototype.freeCachedElements):
(WebInspector.TextEditorMainPanel.prototype.handleUndoRedo):
(WebInspector.TextEditorMainPanel.prototype.handleEnterKey):
(WebInspector.TextEditorMainPanel.prototype.splitChunkOnALine):
(WebInspector.TextEditorMainPanel.prototype.buildChunks):
(WebInspector.TextEditorMainPanel.prototype.createNewChunk):
(WebInspector.TextEditorMainPanel.prototype.expandChunks):
(WebInspector.TextEditorMainPanel.prototype._schedulePaintLines):
(WebInspector.TextEditorMainPanel.prototype._paintLines):
(WebInspector.TextEditorMainPanel.prototype._paintLineChunks):
(WebInspector.TextEditorMainPanel.prototype.getSelection):
(WebInspector.TextEditorMainPanel.prototype.getLastSelection):
(WebInspector.TextEditorMainPanel.prototype.setLastSelection):
(WebInspector.TextEditorMainPanel.prototype.restoreSelection):
(WebInspector.TextEditorMainPanel.prototype._selectionToPosition):
(WebInspector.TextEditorMainPanel.prototype.enclosingLineRowOrSelf):
(WebInspector.TextEditorMainPanel.prototype._createLink):
(WebInspector.TextEditorMainPanel.prototype._collectDirtyLines):
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.TextEditorMainPanel.prototype._guessEditRangeBasedOnSelection):
(WebInspector.TextEditorMainPanel.prototype._removeDecorationsInRange):
(WebInspector.TextEditorMainPanel.prototype._updateChunksForRanges):
(WebInspector.TextEditorMainPanel.prototype._updateHighlightsForRange):
(WebInspector.TextEditorMainPanel.prototype.handleSelectionChange):
(WebInspector.TextEditorMainPanel.prototype.handleTextInput):
(WebInspector.TextEditorMainPanel.prototype.handleKeyDown):
(WebInspector.TextEditorMainPanel.prototype.handleCut):
(WebInspector.TextEditorMainPanel.prototype.overrideViewportForTest):
(WebInspector.TextEditorMainChunk.prototype.get height):

LayoutTests:

Fix test to correspond to method renamings of TextEditorMainPanel.

  • inspector/editor/text-editor-selection.html:
1:06 AM Changeset in webkit [138526] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[EFL][WebGL] Add GLES2 support in GraphicsContext3DEfl.
https://bugs.webkit.org/show_bug.cgi?id=105805

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-12-28
Reviewed by Kenneth Rohde Christiansen.

This is in preparation for adding GLES2 support.
This patch adds OPENGL_ES_2 checks in GraphicsContext3DEFl.
With this patch, GraphicsContext3DPrivate uses the FramebufferBlit extension supported by Extensions3D.

  • platform/graphics/GraphicsContext3D.h:

(GraphicsContext3D):

  • platform/graphics/efl/GraphicsContext3DEfl.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

  • platform/graphics/efl/GraphicsContext3DPrivate.cpp:

(GraphicsContext3DPrivate::copyToGraphicsSurface):

  • platform/graphics/opengl/GLDefs.h:
12:11 AM Changeset in webkit [138525] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

Unreviewed holiday gardening, skip new failing tests to paint the bots green.

  • platform/qt/TestExpectations:
12:00 AM Changeset in webkit [138524] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

instance-of-immediates.js : the word "passing" is spelled incorrectly
https://bugs.webkit.org/show_bug.cgi?id=105669

Patch by Stuart Eichert <stuart@fivemicro.com> on 2012-12-27
Reviewed by Julien Chaffraix.

Corrected spelling of the word "passing" in instance-of-immediates.js

  • fast/js/script-tests/instance-of-immediates.js:
Note: See TracTimeline for information about the timeline view.