Timeline



Feb 5, 2013:

11:44 PM Changeset in webkit [141972] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

Add #if USE(V8) to Node::V8CollectableDuringMinorGCFlag
https://bugs.webkit.org/show_bug.cgi?id=109009

Reviewed by Kent Tamura.

Node flags should be saved. V8CollectableDuringMinorGCFlag is used by V8 only.

  • dom/Node.h:

(Node):

11:41 PM Changeset in webkit [141971] by gman@chromium.org
  • 2 edits
    24 adds in trunk/LayoutTests

Adds the WebGL Conformance Tests attrib folder.
https://bugs.webkit.org/show_bug.cgi?id=108901

Reviewed by Kenneth Russell.

  • platform/chromium/TestExpectations:
  • webgl/conformance/attribs/gl-disabled-vertex-attrib-expected.txt: Added.
  • webgl/conformance/attribs/gl-disabled-vertex-attrib.html: Added.
  • webgl/conformance/attribs/gl-enable-vertex-attrib-expected.txt: Added.
  • webgl/conformance/attribs/gl-enable-vertex-attrib.html: Added.
  • webgl/conformance/attribs/gl-vertex-attrib-expected.txt: Added.
  • webgl/conformance/attribs/gl-vertex-attrib-render-expected.txt: Added.
  • webgl/conformance/attribs/gl-vertex-attrib-render.html: Added.
  • webgl/conformance/attribs/gl-vertex-attrib-zero-issues-expected.txt: Added.
  • webgl/conformance/attribs/gl-vertex-attrib-zero-issues.html: Added.
  • webgl/conformance/attribs/gl-vertex-attrib.html: Added.
  • webgl/conformance/attribs/gl-vertexattribpointer-expected.txt: Added.
  • webgl/conformance/attribs/gl-vertexattribpointer-offsets-expected.txt: Added.
  • webgl/conformance/attribs/gl-vertexattribpointer-offsets.html: Added.
  • webgl/conformance/attribs/gl-vertexattribpointer.html: Added.
  • webgl/resources/webgl_test_files/conformance/attribs/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/attribs/gl-disabled-vertex-attrib.html: Added.
  • webgl/resources/webgl_test_files/conformance/attribs/gl-enable-vertex-attrib.html: Added.
  • webgl/resources/webgl_test_files/conformance/attribs/gl-vertex-attrib-render.html: Added.
  • webgl/resources/webgl_test_files/conformance/attribs/gl-vertex-attrib-zero-issues.html: Added.
  • webgl/resources/webgl_test_files/conformance/attribs/gl-vertex-attrib.html: Added.
  • webgl/resources/webgl_test_files/conformance/attribs/gl-vertexattribpointer-offsets.html: Added.
  • webgl/resources/webgl_test_files/conformance/attribs/gl-vertexattribpointer.html: Added.
11:07 PM Changeset in webkit [141970] by falken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Rebaseline navigator-detached-no-crash.html,
whose output is affected by the disabling of web intents in Chromium.

  • platform/chromium/fast/dom/navigator-detached-no-crash-expected.txt:
10:09 PM Changeset in webkit [141969] by falken@chromium.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Chromium disabled web intents.

  • platform/chromium/TestExpectations:
9:49 PM Changeset in webkit [141968] by tkent@chromium.org
  • 2 edits
    3 adds
    1 delete in trunk/LayoutTests

[Chromium] Split calendar-picker-key-operations.html into two
https://bugs.webkit.org/show_bug.cgi?id=109006

Reviewed by Kentaro Hara.

Split calendar-picker-key-operations.html into two parts:

  • OS-independent part (calendar-picker-key-operations.html), and
  • OS-dependent part (calendar-picker-f4-key.html).

We had some troubles when we updated calendar-picker-key-operations.html
because the behavior by F4 key is OS-dependent. We move the test for F4
key to new test.

  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-f4-key-expected.txt:

Added. It is expected that this contains FAIL line because we don't
support the F4 key behavior on OSX.

  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:

Removed. Now the result of calendar-picker-key-operations.html is OS-independent.

  • platform/chromium/fast/forms/calendar-picker/calendar-picker-f4-key-expected.txt: Added.
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-f4-key.html:

Added. Move from calendar-picker-key-operations.html.

  • platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:

Move the F4 key part to calendar-picker-f4-key.html.

9:16 PM Changeset in webkit [141967] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Add ending slashes automatically to file mappings.
https://bugs.webkit.org/show_bug.cgi?id=108936

Reviewed by Pavel Feldman.

  • inspector/front-end/SettingsScreen.js:

(WebInspector.WorkspaceSettingsTab.prototype._addFileMappingClicked):

9:12 PM Changeset in webkit [141966] by eric.carlson@apple.com
  • 10 edits in trunk/Source/WebCore

More updates to Caption user preferences
https://bugs.webkit.org/show_bug.cgi?id=108997

Reviewed by Dean Jackson.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::captionPreferencesChanged): Give the media controls a chance

to update for a preferences change.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateSizes): Add optional "force update"

param to force font size recalc even when the video size hasn't changed.

  • html/shadow/MediaControlElements.h:
  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::textTrackPreferencesChanged): New, force a font size recalc.

  • html/shadow/MediaControls.h:
  • html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties): Don't set width/size of cues

that use default positioning. Use "start" as the default alignment.

  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::captionsWindowCSS): Set padding when the window is visible

so it shows around the cue background.

(WebCore::CaptionUserPreferencesMac::captionsBackgroundCSS): Set padding to 0 when the background

is visible.

(WebCore::CaptionUserPreferencesMac::windowRoundedCornerRadiusCSS): Add "px" to the border radius

so it actually works.

  • rendering/RenderTextTrackCue.cpp:

(WebCore::RenderTextTrackCue::layout): Special case generic cues with default style.
(WebCore::RenderTextTrackCue::repositionGenericCue):

  • rendering/RenderTextTrackCue.h:
8:30 PM Changeset in webkit [141965] by mark.lam@apple.com
  • 2 edits in trunk/Source/WTF

Fix EnumClass so that it can be used with switch statements.
https://bugs.webkit.org/show_bug.cgi?id=109004.

Reviewed by Sam Weinig.

  • wtf/EnumClass.h:

(WTF::EnumClass::operator==):
(WTF::EnumClass::operator!=):
(WTF::EnumClass::operator<):
(WTF::EnumClass::operator<=):
(WTF::EnumClass::operator>):
(WTF::EnumClass::operator>=):
(EnumClass):
(WTF::EnumClass::operator Value):

8:28 PM Changeset in webkit [141964] by hayato@chromium.org
  • 10 edits
    2 adds in trunk/Source/WebCore

Split each RuleSet and feature out from StyleResolver into its own class.
https://bugs.webkit.org/show_bug.cgi?id=107777

Reviewed by Dimitri Glazkov.

Splitting each RuleSet and feature out from StyleResover into its onw class, DocumentRuleSets,
to manage them separately.

This is one of the attempts to try to resolve meta bug (bug 89879)
to lose StyleResolver's weight. We need further action to factor
StyleResolver to separate it into some classes cleanly.
See also https://bugs.webkit.org/show_bug.cgi?id=108890. A following patch will address that.

No tests. No change in behavior.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/DocumentRuleSets.cpp: Added.

(WebCore):
(WebCore::DocumentRuleSets::DocumentRuleSets):
(WebCore::DocumentRuleSets::~DocumentRuleSets):
(WebCore::DocumentRuleSets::initUserStyle): New helper to initialize each RuleSets.
(WebCore::DocumentRuleSets::collectRulesFromUserStyleSheets): Factored out from StyleResolver.
(WebCore::makeRuleSet): Ditto.
(WebCore::DocumentRuleSets::resetAuthorStyle): Ditto.
(WebCore::DocumentRuleSets::appendAuthorStyleSheets): Ditto.
(WebCore::DocumentRuleSets::collectFeatures): Ditto.
(WebCore::DocumentRuleSets::reportMemoryUsage): New methods to report memory usage. Factored out from StyleResolver.

  • css/DocumentRuleSets.h: Added.

(WebCore):
(DocumentRuleSets):
(WebCore::DocumentRuleSets::authorStyle): Moved from StyleResolver.
(WebCore::DocumentRuleSets::userStyle): Ditto.
(WebCore::DocumentRuleSets::features): Ditto.
(WebCore::DocumentRuleSets::sibling): Ditto.
(WebCore::DocumentRuleSets::uncommonAttribute): Ditto.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::appendAuthorStyleSheets): Now calls DocumentRuleSets::appendAuthorStyleSheets.
(WebCore::StyleResolver::matchAuthorRules): Use m_ruleSets.
(WebCore::StyleResolver::matchUserRules): Ditto.
(WebCore::StyleResolver::classNamesAffectedByRules): Ditto.
(WebCore::StyleResolver::locateCousinList): Ditto.
(WebCore::StyleResolver::canShareStyleWithElement): Ditto.
(WebCore::StyleResolver::locateSharedStyle): Ditto.
(WebCore::StyleResolver::styleForPage): Ditto.
(WebCore::StyleResolver::checkRegionStyle): Ditto.
(WebCore::StyleResolver::applyProperty): Ditto.
(WebCore::StyleResolver::reportMemoryUsage): Now calls DocumentRuleSets::reportMemoryUsage.

  • css/StyleResolver.h:

(WebCore::StyleResolver::scopeResolver):
(StyleResolver):
(WebCore::StyleResolver::ruleSets): accessor r to DocumentRuleSets.
(WebCore::StyleResolver::usesSiblingRules): Use m_ruleSets.
(WebCore::StyleResolver::usesFirstLineRules): Ditto.
(WebCore::StyleResolver::usesBeforeAfterRules): Ditto.
(WebCore::StyleResolver::hasSelectorForAttribute): Ditto.
(WebCore::StyleResolver::hasSelectorForClass): Ditto.
(WebCore::StyleResolver::hasSelectorForId): Ditto.

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):

7:01 PM Changeset in webkit [141963] by jchaffraix@webkit.org
  • 5 edits
    2 adds in trunk

[CSS Grid Layout] Grid item's logical height is not properly recomputed after -webkit-grid-column / -webkit-grid-row changes
https://bugs.webkit.org/show_bug.cgi?id=108975

Reviewed by Tony Chang.

Source/WebCore:

Test: fast/css-grid-layout/implicit-position-dynamic-change.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::clearContainingBlockOverrideSize):
(WebCore::RenderBox::clearOverrideContainingBlockContentLogicalHeight):

  • rendering/RenderBox.h:

Added clearOverrideContainingBlockContentLogicalHeight and updated clearContainingBlockOverrideSize
to use it.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::minContentForChild):
(WebCore::RenderGrid::maxContentForChild):
Added missing clearContainingBlockOverrideSize to ensure we don't use a previous layout's override.

LayoutTests:

  • fast/css-grid-layout/implicit-position-dynamic-change-expected.txt: Added.
  • fast/css-grid-layout/implicit-position-dynamic-change.html: Added.
6:53 PM Changeset in webkit [141962] by mhahnenberg@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

put_to_base should emit a Phantom for "value" across the ForceOSRExit
https://bugs.webkit.org/show_bug.cgi?id=108998

Reviewed by Oliver Hunt.

Otherwise, the OSR exit compiler could clobber it, which would lead to badness.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::tallyFrequentExitSites): Build fixes for when DFG debug logging is enabled.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock): Added extra Phantoms for the "value" field where needed.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compile): Ditto.

6:48 PM Changeset in webkit [141961] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Optimize GlyphPage for case where all glyphs are available in the same font.
<http://webkit.org/b/108835>
<rdar://problem/13157042>

Reviewed by Antti Koivisto.

Let GlyphPage begin optimistically assuming that all its glyphs will be represented in
the same SimpleFontData*. In this (very common) case, only keep a single SimpleFontData*.

If glyphs from multiple fonts are mixed in one page, an array of per-glyph SimpleFontData*
is allocated transparently.

4.98 MB progression on Membuster3.

  • platform/graphics/GlyphPageTreeNode.cpp:

(WebCore::GlyphPageTreeNode::initializePage):

  • platform/graphics/GlyphPage.h:

(WebCore::GlyphPage::createUninitialized):
(WebCore::GlyphPage::createZeroedSystemFallbackPage):
(WebCore::GlyphPage::createCopiedSystemFallbackPage):

There are now three ways of constructing a GlyphPage, two of them are only used for
creating system fallback pages.

(WebCore::GlyphPage::setGlyphDataForIndex):

Hold off creating a SimpleFontData* array until we're sure there are two different
SimpleFontData* backing the glyphs in this page.
We don't store font data for glyph #0, instead we let the getters always return null for it.

(WebCore::GlyphPage::~GlyphPage):

Free the SimpleFontData* array if needed.

(WebCore::GlyphPage::glyphDataForCharacter):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::fontDataForCharacter):

The font data for glyph #0 is always a null pointer now.

(WebCore::GlyphPage::clearForFontData):

Updated for new storage format.

6:34 PM Changeset in webkit [141960] by tkent@chromium.org
  • 10 edits in trunk

INPUT_MULTIPLE_FIELDS_UI: Read-only inputs should be focusable
https://bugs.webkit.org/show_bug.cgi?id=108795

Reviewed by Kentaro Hara.

Source/WebCore:

According to the standard [1], readonly form controls should be focusable.

  • Sub-fields should be focusable if they are read-only. We should check isDisabled mainly.
  • All keyboard operations should not be handled if a field is disabled, and focus navigation keyboard operations should be handled even if a field is read-only.

[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#the-readonly-attribute

No new tests. Update
fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html
for the new behavior.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::isKeyboardFocusable):
Make <input> focusable even if it is read-only.

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::isFieldOwnerDisabled):
Separate isFieldOwnerDisabledOrReadOnly into two.
(WebCore::DateTimeEditElement::isFieldOwnerReadOnly): Ditto.
(WebCore::DateTimeEditElement::updateUIState):
We don't need to focus out if this is read-only.

  • html/shadow/DateTimeEditElement.h:

(DateTimeEditElement): Separate isFieldOwnerDisabledOrReadOnly into two.

  • html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::defaultEventHandler):
Skip handleKeyboardEvent if the field is disabled or the owner input is
disabled or read-only. handleKeyboardEvent handles editing key
operations.
(WebCore::DateTimeFieldElement::defaultKeyboardEventHandler):
If this field is disabled or the owner input is disabled, all keyboard
inputs are ignored.
If this field is read-only, we handle only left and right arrows to
change focus, and skip down/up/backspace/del keys.
(WebCore::DateTimeFieldElement::isFieldOwnerDisabled):
A helper function to check disable state of the owner input.
(WebCore::DateTimeFieldElement::isFieldOwnerReadOnly):
A helper function to check read-only state of the owner input.
(WebCore::DateTimeFieldElement::isFocusable):
This field should be focusable if it is read-only and not disabled.

  • html/shadow/DateTimeFieldElement.h:

(FieldOwner): Separate isFieldOwnerDisabledOrReadOnly into two.
(DateTimeFieldElement):
Declare isFieldOwnerDisabled and isFieldOwnerReadOnly.

  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::handleKeyboardEvent):
Remove redundant isDisabled check. It is done in
DateTimeFieldElement::defaultEventHandler.

LayoutTests:

  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events-expected.txt:
  • fast/forms/time-multiple-fields/time-multiple-fields-keyboard-events.html:
6:27 PM Changeset in webkit [141959] by commit-queue@webkit.org
  • 2 edits in trunk/Source/ThirdParty

Building with MinGW compiler dies with gtest errors
https://bugs.webkit.org/show_bug.cgi?id=108470

Patch by Paweł Forysiuk <tuxator@o2.pl> on 2013-02-05
Reviewed by Martin Robinson.

Variable Libraries_libgtest_la_CXXFLAGS blindly assumes that
pthreads will always be enabled. Make using pthreads for gtest
conditional on the build target.

  • gtest/GNUmakefile.am: Set Libraries_libgtest_la_CXXFLAGS accordingly to the build target.
6:21 PM Changeset in webkit [141958] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit/win

Unreviewed build fix.

  • WebKit.vcproj/WebKitExports.def.in:
6:15 PM Changeset in webkit [141957] by eric.carlson@apple.com
  • 11 edits in trunk

[Mac] Complete plumbing so captions menu can indicate track type
https://bugs.webkit.org/show_bug.cgi?id=108994

Reviewed by Dean Jackson.

Source/WebCore:

Plumb "isClosedCaptions" through to the Mac media engine.

Updated media/video-controls-captions-trackmenu-localized.html and results.

  • html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::isClosedCaptions): New, pass the call through to the private track.

  • html/track/InbandTextTrack.h:

(InbandTextTrack):

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Lose the member variable, this won't be accessed often enough

to make it worth caching the value.

  • html/track/TextTrack.h:

(WebCore::TextTrack::isClosedCaptions): Make virtual so derived classes can oveerride.

  • platform/graphics/InbandTextTrackPrivate.h:

(WebCore::InbandTextTrackPrivate::isClosedCaptions): New.

  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:

(WebCore::InbandTextTrackPrivateAVFObjC::isClosedCaptions): New.

LayoutTests:

Update test results now that the Mac media engine identifies CC tracks.

  • media/video-controls-captions-trackmenu-localized.html:
  • platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
6:10 PM Changeset in webkit [141956] by mark.lam@apple.com
  • 9 edits in trunk/Source/WebCore

Change DatabaseTask and DatabaseThread to work with DatabaseBackendAsync
instead of Database.
https://bugs.webkit.org/show_bug.cgi?id=108995.

Reviewed by Sam Weinig.

This change also moves the task inner classes from Database to
DatabaseBackendAsync.

No new tests.

  • Modules/webdatabase/Database.cpp:

(WebCore::Database::from):

  • Modules/webdatabase/Database.h:

(Database):

  • Modules/webdatabase/DatabaseBackend.h:

(DatabaseBackend):

  • Modules/webdatabase/DatabaseBackendAsync.h:

(DatabaseBackendAsync):

  • Modules/webdatabase/DatabaseTask.cpp:

(WebCore::DatabaseTask::DatabaseTask):
(WebCore::DatabaseBackendAsync::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::DatabaseBackendAsync::DatabaseOpenTask::doPerformTask):
(WebCore::DatabaseBackendAsync::DatabaseOpenTask::debugTaskName):
(WebCore::DatabaseBackendAsync::DatabaseCloseTask::DatabaseCloseTask):
(WebCore::DatabaseBackendAsync::DatabaseCloseTask::doPerformTask):
(WebCore::DatabaseBackendAsync::DatabaseCloseTask::debugTaskName):
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::doPerformTask):
(WebCore::DatabaseBackendAsync::DatabaseTransactionTask::debugTaskName):
(WebCore::DatabaseBackendAsync::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::DatabaseBackendAsync::DatabaseTableNamesTask::doPerformTask):
(WebCore::DatabaseBackendAsync::DatabaseTableNamesTask::debugTaskName):

  • Modules/webdatabase/DatabaseTask.h:

(WebCore::DatabaseTask::database):
(DatabaseTask):
(WebCore::DatabaseBackendAsync::DatabaseOpenTask::create):
(DatabaseBackendAsync::DatabaseOpenTask):
(WebCore::DatabaseBackendAsync::DatabaseCloseTask::create):
(DatabaseBackendAsync::DatabaseCloseTask):
(WebCore::DatabaseBackendAsync::DatabaseTableNamesTask::create):
(DatabaseBackendAsync::DatabaseTableNamesTask):

  • Modules/webdatabase/DatabaseThread.cpp:

(WebCore::DatabaseThread::databaseThread):
(WebCore::DatabaseThread::recordDatabaseOpen):
(WebCore::DatabaseThread::recordDatabaseClosed):
(WebCore::SameDatabasePredicate::SameDatabasePredicate):
(SameDatabasePredicate):
(WebCore::DatabaseThread::unscheduleDatabaseTasks):

  • Modules/webdatabase/DatabaseThread.h:

(DatabaseThread):

6:04 PM Changeset in webkit [141955] by oliver@apple.com
  • 2 edits in trunk/Source/WTF

2013-02-05 Oliver Hunt <oliver@apple.com>

Disable TCMalloc hardening as it's breaking leaks.

Reviewed by Gavin Barraclough.

  • wtf/FastMalloc.cpp:
5:42 PM Changeset in webkit [141954] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Explicitly destroy the WebMediaPlayer in WebMediaPlayerClientImpl's destructor
https://bugs.webkit.org/show_bug.cgi?id=108989

Patch by David Dorwin <ddorwin@chromium.org> on 2013-02-05
Reviewed by Kent Tamura.

  • src/WebMediaPlayerClientImpl.cpp:

(WebKit::WebMediaPlayerClientImpl::~WebMediaPlayerClientImpl):

5:36 PM Changeset in webkit [141953] by roger_fong@apple.com
  • 4 edits in trunk/Source/WebKit

Unreviewed. Get rid of redundant exports in export definitions file.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
  • WebKit.vcproj/WebKitExports.def.in:
5:32 PM Changeset in webkit [141952] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

[wk2] TiledCoreAnimationDrawingArea has one more layer in its CAContext when we're in the background
https://bugs.webkit.org/show_bug.cgi?id=108992
<rdar://problem/13087365>

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea): Add storage for m_isInWindow.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updateLayerHostingContext): Only set the root layer on our layer
hosting context if we're in the window when swapping out contexts.
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer): Update m_isInWindow, and set the root layer
of the layer hosting context (or unset it if we're out of the window).

5:06 PM Changeset in webkit [141951] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Crash at JSC::call when loading www.gap.com with JSVALUE32_64 Enabled
https://bugs.webkit.org/show_bug.cgi?id=108991

Reviewed by Oliver Hunt.

Changed the restoration from calleeGPR to nonArgGPR0 because the restoration of the return location
may step on calleeGPR is it happen to be nonArgGPR2.

  • dfg/DFGRepatch.cpp:

(JSC::DFG::dfgLinkClosureCall):

4:58 PM Changeset in webkit [141950] by mark.lam@apple.com
  • 9 edits in trunk/Source

Rename ENUM_CLASS_BEGIN() macro to ENUM_CLASS(), and make DatabaseType a strong enum.
https://bugs.webkit.org/show_bug.cgi?id=108988.

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests.

  • Modules/webdatabase/DatabaseBackend.cpp:

(WebCore::DatabaseBackend::DatabaseBackend):

  • Modules/webdatabase/DatabaseBackend.h:

(DatabaseBackend):

  • Modules/webdatabase/DatabaseBackendAsync.cpp:

(WebCore::DatabaseBackendAsync::DatabaseBackendAsync):

  • Modules/webdatabase/DatabaseBackendSync.cpp:

(WebCore::DatabaseBackendSync::DatabaseBackendSync):

  • Modules/webdatabase/DatabaseBasicTypes.h:

(WebCore::ENUM_CLASS):

  • Modules/webdatabase/DatabaseError.h:

(WebCore::ENUM_CLASS):

Source/WTF:

  • wtf/EnumClass.h:
4:48 PM Changeset in webkit [141949] by bfulgham@webkit.org
  • 2 edits in trunk/Source/WebKit

Unreviewed Visual Studio 2010 build correction.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Link export definitions out of date with ToT. Corrected.

4:28 PM Changeset in webkit [141948] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Remove deprecatedV8String() and deprecatedV8Integer()
https://bugs.webkit.org/show_bug.cgi?id=108919

Reviewed by Adam Barth.

No tests. No change in behavior.

  • bindings/v8/V8Binding.cpp:

(WebCore::toXPathNSResolver):

  • bindings/v8/V8Binding.h:
  • bindings/v8/custom/V8CustomXPathNSResolver.cpp:

(WebCore::V8CustomXPathNSResolver::create):
(WebCore::V8CustomXPathNSResolver::V8CustomXPathNSResolver):
(WebCore::V8CustomXPathNSResolver::lookupNamespaceURI):

  • bindings/v8/custom/V8CustomXPathNSResolver.h:

(V8CustomXPathNSResolver):

4:05 PM Changeset in webkit [141947] by Vineet
  • 5 edits in trunk

formenctype to have empty string as default value.
https://bugs.webkit.org/show_bug.cgi?id=108969

Reviewed by Kent Tamura.

The spec says formEnctype should only have an invalid value default, not a missing value default.
Spec: http://www.w3.org/html/wg/drafts/html/master/forms.html#attr-fs-formenctype

http://www.whatwg.org/specs/web-apps/current-work/#attr-fs-formenctype

Source/WebCore:

No new tests. Covered by existing test case fast/forms/submit-form-attributes.html

  • html/HTMLFormControlElement.cpp: For the missing formEnctype attr return empty string.

(WebCore::HTMLFormControlElement::formEnctype):

LayoutTests:

  • fast/forms/submit-form-attributes-expected.txt:
  • fast/forms/submit-form-attributes.html: Modified test to behave as expected.
4:00 PM Changeset in webkit [141946] by haraken@chromium.org
  • 20 edits in trunk/Source

[V8] Reduce usage of deprecatedString() and deprecatedInteger()
https://bugs.webkit.org/show_bug.cgi?id=108909

Reviewed by Adam Barth.

Source/WebCore:

By passing an Isolate parameter around, we can reduce usage of
deprecated methods.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter):
(GenerateEventListenerCallback):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::addEventListenerCallback):
(WebCore::TestEventTargetV8Internal::removeEventListenerCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::addEventListenerCallback):
(WebCore::TestObjV8Internal::removeEventListenerCallback):

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::get):
(WebCore::set):
(WebCore::getNthValueOnKeyPath):
(WebCore::canInjectNthValueOnKeyPath):
(WebCore::ensureNthValueOnKeyPath):
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::canInjectIDBKeyIntoScriptValue):

  • bindings/v8/NPV8Object.cpp:

(WebCore::createValueListFromVariantArgs):
(_NPN_Invoke):
(_NPN_InvokeDefault):
(_NPN_SetProperty):
(_NPN_Construct):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::compileAndRunScript):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore):
(WebCore::ScriptProfiler::takeHeapSnapshot):

  • bindings/v8/ScriptSourceCode.cpp:

(WebCore::ScriptSourceCode::compileScript):

  • bindings/v8/ScriptSourceCode.h:

(ScriptSourceCode):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):

  • bindings/v8/V8NPUtils.cpp:

(WebCore::convertNPVariantToV8Object):

  • bindings/v8/V8NPUtils.h:

(WebCore):

  • bindings/v8/V8Utilities.cpp:

(WebCore::createHiddenDependency):
(WebCore::removeHiddenDependency):
(WebCore::transferHiddenDependency):

  • bindings/v8/V8Utilities.h:

(WebCore):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::addEventListenerCallback):
(WebCore::V8DOMWindow::removeEventListenerCallback):

Source/WebKit/chromium:

No tests. No change in behavior.

  • src/WebBindings.cpp:

(WebKit::WebBindings::toV8Value):

3:55 PM Changeset in webkit [141945] by haraken@chromium.org
  • 34 edits in trunk/Source

[V8] Make an Isolate parameter mandatory in HasInstance()
https://bugs.webkit.org/show_bug.cgi?id=108917

Reviewed by Adam Barth.

Source/WebCore:

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::HasInstance):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::HasInstance):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::HasInstance):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::HasInstance):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::HasInstance):

  • bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::HasInstance):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::HasInstance):

  • bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::HasInstance):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::HasInstance):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toWebGLUniformLocation):

Source/WebKit/chromium:

Because these methods do not have an Isolate, we have to call
v8::Isolate::GetCurrent().

No tests. No change in behavior.

  • src/WebArrayBuffer.cpp:

(WebKit::WebArrayBuffer::createFromV8Value):

  • src/WebArrayBufferView.cpp:

(WebKit::WebArrayBufferView::createFromV8Value):

  • src/WebBindings.cpp:

(WebKit::getRangeImpl):
(WebKit::getNodeImpl):
(WebKit::getElementImpl):
(WebKit::getArrayBufferImpl):
(WebKit::getArrayBufferViewImpl):
(WebKit::WebBindings::getRange):
(WebKit::WebBindings::getArrayBuffer):
(WebKit::WebBindings::getArrayBufferView):
(WebKit::WebBindings::getNode):
(WebKit::WebBindings::getElement):

3:43 PM Changeset in webkit [141944] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[JSC] Clean up CodeGeneratorJS.pm by introducing HasCustom{Getter,Setter,Method}
https://bugs.webkit.org/show_bug.cgi?id=108898

Reviewed by Sam Weinig.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(HasCustomGetter):
(HasCustomSetter):
(HasCustomMethod):

3:42 PM Changeset in webkit [141943] by danakj@chromium.org
  • 8 edits
    1 delete in trunk/Source

[chromium] Provide compositor offscreen context through the WebLayerTreeViewClient interface
https://bugs.webkit.org/show_bug.cgi?id=107776

Source/Platform:

Make "createGrGLInterface" the preferred virtual method for
WebGraphicsContext3D implementations to override. For now it
just calls the old method in its default implementation.

Reviewed by James Robinson.

  • chromium/public/WebGraphicsContext3D.h:

(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::createGrGLInterface):

Source/WebCore:

Reviewed by James Robinson.

Allow the compositor thread's context to be retrieved on either thread,
so the main thread can create and pass the context to the impl thread
via its own mechanisms.

Move the code to bind the GrGLInterface to a WebGraphicsContext3D into
chromium's GraphicsContext3DPrivate. The chromium-side code will need
to implement this code itself.

  • platform/chromium/support/GraphicsContext3DPrivate.cpp:

(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore):
(WebCore::GraphicsContext3DPrivate::grContext):

  • platform/chromium/support/GraphicsContext3DPrivate.h:
  • platform/graphics/gpu/SharedGraphicsContext3D.cpp:

(WebCore::SharedGraphicsContext3D::getForImplThread):

Source/WebKit/chromium:

Reviewed by James Robinson.

  • WebKit.gyp:
  • src/WebGraphicsContext3D.cpp: Removed.
3:40 PM Changeset in webkit [141942] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Tools

[CMake] Don't warn unused cmake variables which aren't used by cmake ports
https://bugs.webkit.org/show_bug.cgi?id=108761

Reviewed by Laszlo Gombos.

Ignore unused macro variables which aren't used by cmake ports.

  • Scripts/webkitdirs.pm:

(generateBuildSystemFromCMakeProject):

3:37 PM Changeset in webkit [141941] by jparent@chromium.org
  • 3 edits in trunk/Tools

Add cc_unittests to the dashboards
https://bugs.webkit.org/show_bug.cgi?id=108878

Reviewed by Dirk Pranke.

  • TestResultServer/static-dashboards/builders.js:

(loadBuildersList):

  • TestResultServer/static-dashboards/dashboard_base.js:

(currentBuilderGroupCategory):

3:24 PM Changeset in webkit [141940] by roger_fong@apple.com
  • 2 edits in trunk/Source/WTF

Unreviewed build fix.

  • wtf/FastMalloc.cpp:
3:05 PM Changeset in webkit [141939] by roger_fong@apple.com
  • 8 edits
    11 adds in trunk/Source

Add a JavaScriptCore Export Generator project.
https://bugs.webkit.org/show_bug.cgi?id=108971.

Reviewed by Brent Fulgham.

  • JavaScriptCore.vcxproj/JavaScriptCore.sln:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.filters: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.user: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorBuildCmd.cmd: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorCommon.props: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorDebug.props: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPostBuild.cmd: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPreBuild.cmd: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorRelease.props: Added.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in: Added.
  • WebKit.vcxproj/WebKit.sln:
2:39 PM Changeset in webkit [141938] by tonyg@chromium.org
  • 4 edits in trunk/Source/WebCore

Continue making XSSAuditor thread safe: Remove dependency on the parser's tokenizer
https://bugs.webkit.org/show_bug.cgi?id=108666

Reviewed by Adam Barth.

This is the final dependency on the parser, so we remove that as well. Yay!

No new tests because no new functionality.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::pumpTokenizer): Pass m_tokenizer->shouldAllowCDATA()

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::XSSAuditor): Remove isMainThread() check because we have one in init() anyway.
Move m_isEnabled and m_documentURL initialization to init() because we have a Document* there.
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
(WebCore::XSSAuditor::filterStartToken):
(WebCore::XSSAuditor::filterEndToken):
(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::decodedSnippetForJavaScript):

  • html/parser/XSSAuditor.h:

(WebCore::FilterTokenRequest::FilterTokenRequest):
(FilterTokenRequest):
(XSSAuditor):

2:37 PM Changeset in webkit [141937] by enrica@apple.com
  • 4 edits in trunk/Source/WebCore

Make baseWritingDirectionForSelectionStart available to all platforms in the Editor class.
https://bugs.webkit.org/show_bug.cgi?id=108977.

Reviewed by Ryosuke Niwa.

Now that baseWritingDirectionForSelectionStart doesn't use
platform specific type anymore, we can make it available for
all platforms. This way it can be used for iOS as well.

No new tests, no functionality change.

  • editing/Editor.cpp:

(WebCore::Editor::baseWritingDirectionForSelectionStart): Added.

  • editing/Editor.h: Moved from PLATFORM(MAC).
  • editing/mac/EditorMac.mm: baseWritingDirectionForSelectionStart removed.
2:35 PM Changeset in webkit [141936] by Lucas Forschler
  • 4 edits in tags/Safari-537.29.1/Source

Versioning.

2:33 PM Changeset in webkit [141935] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Avoid String->AtomicString conversion in Attr::childrenChanged()
https://bugs.webkit.org/show_bug.cgi?id=108742

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-05
Reviewed by Andreas Kling.

  • dom/Attr.cpp:

(WebCore::Attr::childrenChanged): StringBuilder can output AtomicString directly.

2:32 PM Changeset in webkit [141934] by Lucas Forschler
  • 1 copy in tags/Safari-537.29.1

New Tag.

2:15 PM Changeset in webkit [141933] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Win7 port doesn't run WebGL.

  • platform/win/TestExpectations:
2:14 PM Changeset in webkit [141932] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Tidy up StackBounds
https://bugs.webkit.org/show_bug.cgi?id=108889

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-05
Reviewed by Ryosuke Niwa.

  • wtf/StackBounds.h:

(StackBounds):
(WTF::StackBounds::isSafeToRecurse):
(WTF::StackBounds::size):
Adopt a more conventional style for a multiline branch.

(WTF::StackBounds::StackBounds):
(WTF::StackBounds::current):
(WTF::StackBounds::recursionLimit):
Make those method private.

Making the constructor private ensure initialize() is alwasy called on any StackBounds.

2:14 PM Changeset in webkit [141931] by fpizlo@apple.com
  • 6 edits
    2 adds in trunk/Source/JavaScriptCore

DFG should have a precise view of jump targets
https://bugs.webkit.org/show_bug.cgi?id=108868

Reviewed by Oliver Hunt.

Previously, the DFG relied entirely on the CodeBlock's jump targets list for
determining when to break basic blocks. This worked great, except sometimes it
would be too conservative since the CodeBlock just says where the bytecode
generator inserted labels.

This change keeps the old jump target list in CodeBlock since it is still
valuable to the baseline JIT, but switches the DFG to use its own jump target
calculator. This ought to reduce pressure on the DFG simplifier, which would
previously do a lot of work to try to merge redundantly created basic blocks.
It appears to be a 1% progression on SunSpider.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • bytecode/PreciseJumpTargets.cpp: Added.

(JSC):
(JSC::addSimpleSwitchTargets):
(JSC::computePreciseJumpTargets):

  • bytecode/PreciseJumpTargets.h: Added.

(JSC):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseCodeBlock):

2:08 PM Changeset in webkit [141930] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK][WK2] Unflag tests related to layoutTestController.setCustomPolicyDelegate
https://bugs.webkit.org/show_bug.cgi?id=108976

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-02-05
Reviewed by Martin Robinson.

  • platform/gtk-wk2/TestExpectations: Unflag

fast/loader/policy-delegate-action-hit-test-zoomed.html as it is
already passing (layoutTestController.setCustomPolicyDelegate was
implemented in r128600). Mark some tests related with
layoutTestController.setCustomPolicyDelegate as passing in WK2 but
failing in WK1.

2:04 PM Changeset in webkit [141929] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[chromium] Enable shouldGesturesTriggerActive for Android
https://bugs.webkit.org/show_bug.cgi?id=96948

Patch by Yusuf Ozuysal <yusufo@google.com> on 2013-02-05
Reviewed by James Robinson.

We need this to fix performance issues we are getting because of touchstart
triggering hover/active states.

No new tests. The tests introduced in https://bugs.webkit.org/show_bug.cgi?id=96060
should run with the corrected behavior and would cover this change as well.

  • page/EventHandler.cpp:

(WebCore::shouldGesturesTriggerActive):

2:02 PM Changeset in webkit [141928] by mark.lam@apple.com
  • 31 edits
    8 adds in trunk/Source

Introduced back-end database classes + a few small fixes.
https://bugs.webkit.org/show_bug.cgi?id=108759.

Source/WebCore:

Reviewed by Brady Eidson.

  1. Added DatabaseBackendContext, DatabaseBackendAsync, and DatabaseBackendSync. These are backends for DatabaseContext, Database, and DatabaseSync respectively.
  2. Added DatabaseBase to hold common code between Database and DatabaseSync.
  3. Renamed a few functions.
  4. Cleaned up unneeded code in ~DatabaseSync().
  5. Added some FIXMEs as reminders or places to clean up when we're done refactoring.
  6. Moved the calling of ScriptController::initializeThreading() from the Database constructor to DatabaseManager::openDatabase(). This just moves the call earlier in the same code path. System initialization work (i.e. initializing script threading in this case) should be done by the manager instead of by each Database instance.

No new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/webdatabase/AbstractDatabaseServer.h:

(AbstractDatabaseServer):

  • Modules/webdatabase/Database.cpp:

(WebCore::Database::Database):
(WebCore::Database::backend):

  • Modules/webdatabase/Database.h:

(Database):

  • Modules/webdatabase/DatabaseBackend.cpp:

(WebCore::DatabaseBackend::DatabaseBackend):
(WebCore::DatabaseBackend::~DatabaseBackend):
(WebCore::DatabaseBackend::incrementalVacuumIfNeeded):

  • Modules/webdatabase/DatabaseBackend.h:

(DatabaseBackend):
(WebCore::DatabaseBackend::databaseContext):
(WebCore::DatabaseBackend::setFrontend):

  • Modules/webdatabase/DatabaseBackendAsync.cpp: Added.

(WebCore::DatabaseBackendAsync::DatabaseBackendAsync):

  • Modules/webdatabase/DatabaseBackendAsync.h: Added.

(DatabaseBackendAsync):

  • Modules/webdatabase/DatabaseBackendContext.cpp: Added.

(WebCore::DatabaseBackendContext::securityOrigin):
(WebCore::DatabaseBackendContext::isContextThread):

  • Modules/webdatabase/DatabaseBackendContext.h: Added.

(DatabaseBackendContext):
(WebCore::DatabaseBackendContext::scriptExecutionContext):

  • Modules/webdatabase/DatabaseBackendSync.cpp: Added.

(WebCore::DatabaseBackendSync::DatabaseBackendSync):
(WebCore::DatabaseBackendSync::~DatabaseBackendSync):

  • Modules/webdatabase/DatabaseBackendSync.h: Added.

(DatabaseBackendSync):

  • Modules/webdatabase/DatabaseBase.cpp: Added.

(WebCore::DatabaseBase::DatabaseBase):
(WebCore::DatabaseBase::scriptExecutionContext):
(WebCore::DatabaseBase::logErrorMessage):

  • Modules/webdatabase/DatabaseBase.h: Added.

(DatabaseBase):

  • Modules/webdatabase/DatabaseContext.cpp:

(WebCore::DatabaseContext::DatabaseContext):
(WebCore::DatabaseContext::backend):

  • Modules/webdatabase/DatabaseContext.h:

(DatabaseContext):

  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::openDatabaseSync):
(WebCore::DatabaseManager::hasOpenDatabases):
(WebCore::DatabaseManager::interruptAllDatabasesForContext):
(WebCore::DatabaseManager::getMaxSizeForDatabase):
(WebCore::DatabaseManager::logErrorMessage):

  • Modules/webdatabase/DatabaseManager.h:

(DatabaseManager):

  • Modules/webdatabase/DatabaseServer.cpp:

(WebCore::DatabaseServer::interruptAllDatabasesForContext):
(WebCore::DatabaseServer::canEstablishDatabase):

  • Modules/webdatabase/DatabaseServer.h:
  • Modules/webdatabase/DatabaseSync.cpp:

(WebCore::DatabaseSync::DatabaseSync):
(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::backend):

  • Modules/webdatabase/DatabaseSync.h:

(DatabaseSync):

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::openTrackerDatabase):
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::hasEntryForDatabase):
(WebCore::DatabaseTracker::interruptAllDatabasesForContext):
(WebCore::DatabaseTracker::populateOriginsIfNeeded):
(WebCore::DatabaseTracker::databaseNamesForOriginNoLock):
(WebCore::DatabaseTracker::detailsForNameAndOrigin):
(WebCore::DatabaseTracker::setDatabaseDetails):
(WebCore::DatabaseTracker::usageForOriginNoLock):
(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::addDatabase):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::isDeletingDatabaseOrOriginFor):
(WebCore::DatabaseTracker::canDeleteDatabase):
(WebCore::DatabaseTracker::isDeletingDatabase):
(WebCore::DatabaseTracker::canDeleteOrigin):
(WebCore::DatabaseTracker::isDeletingOrigin):
(WebCore::DatabaseTracker::recordDeletingOrigin):
(WebCore::DatabaseTracker::doneDeletingOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::deleteDatabaseFile):

  • Modules/webdatabase/DatabaseTracker.h:

(DatabaseTracker):

  • Modules/webdatabase/SQLTransaction.cpp:
  • Modules/webdatabase/SQLTransactionClient.cpp:

(WebCore::SQLTransactionClient::didExceedQuota):

  • Modules/webdatabase/SQLTransactionSync.cpp:
  • Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::prepareToOpenDatabase):
(WebCore::DatabaseTracker::failedToOpenDatabase):
(WebCore::DatabaseTracker::interruptAllDatabasesForContext):
(WebCore::DatabaseTracker::closeDatabasesImmediately):

  • Modules/webdatabase/chromium/SQLTransactionClientChromium.cpp:

(WebCore::SQLTransactionClient::didCommitWriteTransaction):
(WebCore::SQLTransactionClient::didExceedQuota):

  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

Reviewed by Brady Eidson.

  • src/DatabaseObserver.cpp:

(WebCore::DatabaseObserver::databaseOpened):
(WebCore::DatabaseObserver::databaseModified):
(WebCore::DatabaseObserver::databaseClosed):

1:58 PM Changeset in webkit [141927] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WTF

[WTFURL] Comparison between signed and unsigned integer expressions in URLUtil.cpp
https://bugs.webkit.org/show_bug.cgi?id=108955

Reviewed by Benjamin Poulain.

  • wtf/url/src/URLUtil.cpp:

(URLUtilities): Make the counter variable a signed integer to get rid of the warning.

1:44 PM Changeset in webkit [141926] by abarth@webkit.org
  • 10 edits in trunk

DumpRenderTree should be able to enable the threaded parser
https://bugs.webkit.org/show_bug.cgi?id=108970

Reviewed by Eric Seidel.

Source/WebKit/chromium:

  • public/WebSettings.h:
  • src/WebSettingsImpl.cpp:

(WebKit::WebSettingsImpl::setThreadedHTMLParser):
(WebKit):

  • src/WebSettingsImpl.h:

(WebSettingsImpl):

Tools:

We can now enable the parser at runtime using --enable-threaded-html-parser.

  • DumpRenderTree/chromium/DumpRenderTree.cpp:

(main):

  • DumpRenderTree/chromium/TestRunner/public/WebPreferences.h:

(WebPreferences):

  • DumpRenderTree/chromium/TestRunner/src/WebPreferences.cpp:

(WebTestRunner::WebPreferences::reset):
(WebTestRunner::WebPreferences::applyTo):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::TestShell):
(TestShell::resetWebSettings):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::setThreadedHTMLParser):
(TestShell):

1:41 PM Changeset in webkit [141925] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit

Unreviewed. Delete some errant preprocessor definitions.

  • WebKit.vcxproj/WebKit/WebKitCommon.props:
1:30 PM Changeset in webkit [141924] by roger_fong@apple.com
  • 3 edits
    3 copies
    41 adds in trunk/Source/WebKit

VS2010 WebKit projects, scripts, and property sheets.
https://bugs.webkit.org/show_bug.cgi?id=106989.

Reviewed by Brent Fulgham.

  • WebKit.vcxproj/Interfaces: Added.
  • WebKit.vcxproj/Interfaces/FixMIDLHeaders.pl: Copied from win/WebKit.vcproj/FixMIDLHeaders.pl.
  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj: Added.
  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters: Added.
  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj.user: Added.
  • WebKit.vcxproj/Interfaces/InterfacesCommon.props: Added.
  • WebKit.vcxproj/Interfaces/InterfacesDebug.props: Added.
  • WebKit.vcxproj/Interfaces/InterfacesPostBuild.cmd: Added.
  • WebKit.vcxproj/Interfaces/InterfacesPreBuild.cmd: Added.
  • WebKit.vcxproj/Interfaces/InterfacesRelease.props: Added.
  • WebKit.vcxproj/WebKit: Added.
  • WebKit.vcxproj/WebKit.sln:
  • WebKit.vcxproj/WebKit/WebKit.vcxproj: Added.
  • WebKit.vcxproj/WebKit/WebKit.vcxproj.filters: Added.
  • WebKit.vcxproj/WebKit/WebKit.vcxproj.user: Added.
  • WebKit.vcxproj/WebKit/WebKitApple.props: Added.
  • WebKit.vcxproj/WebKit/WebKitCFLite.props: Added.
  • WebKit.vcxproj/WebKit/WebKitCommon.props: Added.
  • WebKit.vcxproj/WebKit/WebKitDebug.props: Added.
  • WebKit.vcxproj/WebKit/WebKitDirectX.props: Added.
  • WebKit.vcxproj/WebKit/WebKitPostBuild.cmd: Added.
  • WebKit.vcxproj/WebKit/WebKitPreBuild.cmd: Added.
  • WebKit.vcxproj/WebKit/WebKitPreLink.cmd: Added.
  • WebKit.vcxproj/WebKit/WebKitRelease.props: Added.
  • WebKit.vcxproj/WebKit/resource.h: Copied from win/WebKit.vcproj/resource.h.
  • WebKit.vcxproj/WebKitExportGenerator: Added.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj: Added.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.filters: Added.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.user: Added.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorBuildCmd.cmd: Added.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorCommon.props: Added.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorDebug.props: Added.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPostBuild.cmd: Added.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorPreBuild.cmd: Added.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExportGeneratorRelease.props: Added.
  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Copied from win/WebKit.vcproj/WebKitExports.def.in.
  • WebKit.vcxproj/WebKitGUID: Added.
  • WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj: Added.
  • WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters: Added.
  • WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.user: Added.
  • WebKit.vcxproj/WebKitGUID/WebKitGUIDCommon.props: Added.
  • WebKit.vcxproj/WebKitGUID/WebKitGUIDDebug.props: Added.
  • WebKit.vcxproj/WebKitGUID/WebKitGUIDPostBuild.cmd: Added.
  • WebKit.vcxproj/WebKitGUID/WebKitGUIDPreBuild.cmd: Added.
  • WebKit.vcxproj/WebKitGUID/WebKitGUIDRelease.props: Added.
1:26 PM Changeset in webkit [141923] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

WebKit clients should be able to override loading of blocked plug-ins
https://bugs.webkit.org/show_bug.cgi?id=108968
<rdar://problem/13154516>

Reviewed by Sam Weinig.

Replace the shouldInstantiatePlugin callback with a new pluginLoadPolicy which is called regardless
of whether the plug-in is blocked or not. This lets clients override the plug-in load policy and
force loading of blacklisted plug-ins (and vice versa).

  • UIProcess/API/C/WKPage.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getPluginPath):

  • UIProcess/WebUIClient.cpp:

(WebKit::toWKPluginLoadPolicy):
(WebKit):
(WebKit::toPluginModuleLoadPolicy):
(WebKit::WebUIClient::pluginLoadPolicy):

  • UIProcess/WebUIClient.h:

(WebUIClient):

1:16 PM Changeset in webkit [141922] by nayankk@motorola.com
  • 8 edits in trunk

[WEBGL] Rename WEBKIT_WEBGL_depth_texture to WEBGL_depth_texture.
https://bugs.webkit.org/show_bug.cgi?id=108959

Reviewed by Kenneth Russell.

Source/WebCore:

WEBGL_depth_texture is official now. Hence remove the vendor prefix from
WEBKIT_WEBGL_depth_texture and rename this extension string to WEBGL_depth_texture.
Specification: http://www.khronos.org/registry/webgl/extensions/WEBGL_depth_texture/.

Tests already exists, modified them to test querying of unprefixed extension string.

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLDepthTexture.cpp:

(WebCore::WebGLDepthTexture::getName):

  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::getExtension):

LayoutTests:

  • fast/canvas/webgl/webgl-depth-texture.html:
1:14 PM Changeset in webkit [141921] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Make ConfigurationBuildDir include directories precede WebKitLibraries in JSC.
https://bugs.webkit.org/show_bug.cgi?id=108693.

Rubberstamped by Timothy Horton.

1:04 PM Changeset in webkit [141920] by jamesr@google.com
  • 2 edits in trunk/Source/Platform

[chromium] Remove optionalness of second parameter to WebLayerTreeView::setViewportSize
https://bugs.webkit.org/show_bug.cgi?id=108972

Reviewed by Adam Barth.

This was added to ease the transition of adding this parameter, but it's now always set.

  • chromium/public/WebLayerTreeView.h:

(WebLayerTreeView):

12:58 PM Changeset in webkit [141919] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Rationalize the use of iOS/Mac #defines in Assertions.cpp
https://bugs.webkit.org/show_bug.cgi?id=108870

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-05
Reviewed by David Kilzer.

  • wtf/Assertions.cpp: Instead of using PLATFORM(MAC) and assume it works for iOS and OS X,

use CF as the guard for CFString. Similarily, USE_APPLE_SYSTEM_LOG guards code using ASL.

12:52 PM Changeset in webkit [141918] by roger_fong@apple.com
  • 2 edits in trunk/Source/JavaScriptCore/JavaScriptCore.vcxproj

Unreviewed. VS2010 JavaScriptCore projects touch-ups.

12:49 PM Changeset in webkit [141917] by benjamin@webkit.org
  • 4 edits in trunk

Source/WTF: Make StringBuilder::toAtomicString() consistent with StringBuilder::toString() for strings of length zero
https://bugs.webkit.org/show_bug.cgi?id=108894

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-05
Reviewed by Andreas Kling.

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::toAtomicString): The function was returning the nullAtom for strings of length zero.
This is inconsistent with StringBuilder::toString() which always return an empty string.

This patch unifies the behavior.

Tools: Make StringBuilder::toAtomicString() consistent with StringBuilder::toString() for strings of null length
https://bugs.webkit.org/show_bug.cgi?id=108894

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-05
Reviewed by Andreas Kling.

  • TestWebKitAPI/Tests/WTF/StringBuilder.cpp:

Extend the tests to check toAtomicString() on an empty builder.

12:43 PM Changeset in webkit [141916] by mhahnenberg@apple.com
  • 4 edits in trunk/Source

Structure::m_outOfLineCapacity is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=108206

Reviewed by Darin Adler.

Simplifying the utility functions that we use since we don't need a
bunch of fancy templates for this one specific call site.

Source/JavaScriptCore:

  • runtime/Structure.h:

(JSC::Structure::outOfLineCapacity):

Source/WTF:

  • wtf/MathExtras.h:

(WTF::roundUpToPowerOfTwo):

12:41 PM Changeset in webkit [141915] by roger_fong@apple.com
  • 27 adds in trunk/Source/WebKit/win/WebKit.resources

Unreviewed. Copy some resource files for VS2010 solution.
https://bugs.webkit.org/show_bug.cgi?id=106989.

  • WebKit.resources/WebKit.rc: Added.
  • WebKit.resources/deleteButton.png: Added.
  • WebKit.resources/deleteButtonPressed.png: Added.
  • WebKit.resources/fsVideoAudioVolumeHigh.png: Added.
  • WebKit.resources/fsVideoAudioVolumeLow.png: Added.
  • WebKit.resources/fsVideoExitFullscreen.png: Added.
  • WebKit.resources/fsVideoPause.png: Added.
  • WebKit.resources/fsVideoPlay.png: Added.
  • WebKit.resources/missingImage.png: Added.
  • WebKit.resources/nullplugin.png: Added.
  • WebKit.resources/panEastCursor.png: Added.
  • WebKit.resources/panIcon.png: Added.
  • WebKit.resources/panNorthCursor.png: Added.
  • WebKit.resources/panNorthEastCursor.png: Added.
  • WebKit.resources/panNorthWestCursor.png: Added.
  • WebKit.resources/panSouthCursor.png: Added.
  • WebKit.resources/panSouthEastCursor.png: Added.
  • WebKit.resources/panSouthWestCursor.png: Added.
  • WebKit.resources/panWestCursor.png: Added.
  • WebKit.resources/searchCancel.png: Added.
  • WebKit.resources/searchCancelPressed.png: Added.
  • WebKit.resources/searchMagnifier.png: Added.
  • WebKit.resources/searchMagnifierResults.png: Added.
  • WebKit.resources/textAreaResizeCorner.png: Added.
  • WebKit.resources/verticalTextCursor.png: Added.
  • WebKit.resources/zoomInCursor.png: Added.
  • WebKit.resources/zoomOutCursor.png: Added.
12:38 PM Changeset in webkit [141914] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Objective-C API: testapi.mm should use ARC
https://bugs.webkit.org/show_bug.cgi?id=107838

Reviewed by Oliver Hunt.

In ToT testapi.mm uses the Obj-C garbage collector, which hides a lot of our object lifetime bugs.
We should enable ARC, since that is what most of our clients will be using. We use Xcode project
settings to make sure we don't try to compile ARC on 32-bit.

  • API/tests/testapi.mm:

(+[TestObject testObject]):
(testObjectiveCAPI):

12:34 PM Changeset in webkit [141913] by roger_fong@apple.com
  • 2 edits
    1 add in trunk/WebKitLibraries/win/tools

Unreviewed. VS2010 solution touch-ups.
Make common.props use a platform dependent preprocessor definition (WIN32 or X64).
Add a few base properties.
Create a temporary auto-version script for use by the VS2010 solution. Will be removed later.
https://bugs.webkit.org/show_bug.cgi?id=106949.

  • win/tools/scripts/auto-version2010.sh: Added.
  • win/tools/vsprops/common.props:
12:32 PM Changeset in webkit [141912] by gman@chromium.org
  • 1 edit
    18 adds in trunk/LayoutTests

Adds the WebGL Conformance Tests typedarrays folder.
https://bugs.webkit.org/show_bug.cgi?id=108907

Reviewed by Kenneth Russell.

  • webgl/conformance/typedarrays/array-buffer-crash-expected.txt: Added.
  • webgl/conformance/typedarrays/array-buffer-crash.html: Added.
  • webgl/conformance/typedarrays/array-buffer-view-crash-expected.txt: Added.
  • webgl/conformance/typedarrays/array-buffer-view-crash.html: Added.
  • webgl/conformance/typedarrays/array-unit-tests-expected.txt: Added.
  • webgl/conformance/typedarrays/array-unit-tests.html: Added.
  • webgl/conformance/typedarrays/data-view-crash-expected.txt: Added.
  • webgl/conformance/typedarrays/data-view-crash.html: Added.
  • webgl/conformance/typedarrays/data-view-test-expected.txt: Added.
  • webgl/conformance/typedarrays/data-view-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/typedarrays/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/typedarrays/array-buffer-crash.html: Added.
  • webgl/resources/webgl_test_files/conformance/typedarrays/array-buffer-view-crash.html: Added.
  • webgl/resources/webgl_test_files/conformance/typedarrays/array-unit-tests.html: Added.
  • webgl/resources/webgl_test_files/conformance/typedarrays/data-view-crash.html: Added.
  • webgl/resources/webgl_test_files/conformance/typedarrays/data-view-test.html: Added.
12:20 PM Changeset in webkit [141911] by gman@chromium.org
  • 1 edit
    45 adds in trunk/LayoutTests

Adds the WebGL Conformance Tests misc folder.
https://bugs.webkit.org/show_bug.cgi?id=108905

Reviewed by Kenneth Russell.

  • webgl/conformance/misc/bad-arguments-test-expected.txt: Added.
  • webgl/conformance/misc/bad-arguments-test.html: Added.
  • webgl/conformance/misc/boolean-argument-conversion-expected.txt: Added.
  • webgl/conformance/misc/boolean-argument-conversion.html: Added.
  • webgl/conformance/misc/delayed-drawing-expected.txt: Added.
  • webgl/conformance/misc/delayed-drawing.html: Added.
  • webgl/conformance/misc/error-reporting-expected.txt: Added.
  • webgl/conformance/misc/error-reporting.html: Added.
  • webgl/conformance/misc/functions-returning-strings-expected.txt: Added.
  • webgl/conformance/misc/functions-returning-strings.html: Added.
  • webgl/conformance/misc/instanceof-test-expected.txt: Added.
  • webgl/conformance/misc/instanceof-test.html: Added.
  • webgl/conformance/misc/invalid-passed-params-expected.txt: Added.
  • webgl/conformance/misc/invalid-passed-params.html: Added.
  • webgl/conformance/misc/is-object-expected.txt: Added.
  • webgl/conformance/misc/is-object.html: Added.
  • webgl/conformance/misc/null-object-behaviour-expected.txt: Added.
  • webgl/conformance/misc/null-object-behaviour.html: Added.
  • webgl/conformance/misc/object-deletion-behaviour-expected.txt: Added.
  • webgl/conformance/misc/object-deletion-behaviour.html: Added.
  • webgl/conformance/misc/shader-precision-format-expected.txt: Added.
  • webgl/conformance/misc/shader-precision-format.html: Added.
  • webgl/conformance/misc/type-conversion-test-expected.txt: Added.
  • webgl/conformance/misc/type-conversion-test.html: Added.
  • webgl/conformance/misc/uninitialized-test-expected.txt: Added.
  • webgl/conformance/misc/uninitialized-test.html: Added.
  • webgl/conformance/misc/webgl-specific-expected.txt: Added.
  • webgl/conformance/misc/webgl-specific.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/misc/bad-arguments-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/boolean-argument-conversion.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/delayed-drawing.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/error-reporting.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/functions-returning-strings.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/instanceof-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/invalid-passed-params.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/is-object.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/null-object-behaviour.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/object-deletion-behaviour.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/shader-precision-format.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/type-conversion-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/uninitialized-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/misc/webgl-specific.html: Added.
12:09 PM Changeset in webkit [141910] by gman@chromium.org
  • 1 edit
    31 adds in trunk/LayoutTests

Adds the WebGL Conformance Tests buffers folder
https://bugs.webkit.org/show_bug.cgi?id=108902

Reviewed by Kenneth Russell.

  • webgl/conformance/buffers/buffer-bind-test-expected.txt: Added.
  • webgl/conformance/buffers/buffer-bind-test.html: Added.
  • webgl/conformance/buffers/buffer-data-array-buffer-expected.txt: Added.
  • webgl/conformance/buffers/buffer-data-array-buffer.html: Added.
  • webgl/conformance/buffers/element-array-buffer-delete-recreate-expected.txt: Added.
  • webgl/conformance/buffers/element-array-buffer-delete-recreate.html: Added.
  • webgl/conformance/buffers/index-validation-copies-indices-expected.txt: Added.
  • webgl/conformance/buffers/index-validation-copies-indices.html: Added.
  • webgl/conformance/buffers/index-validation-crash-with-buffer-sub-data-expected.txt: Added.
  • webgl/conformance/buffers/index-validation-crash-with-buffer-sub-data.html: Added.
  • webgl/conformance/buffers/index-validation-expected.txt: Added.
  • webgl/conformance/buffers/index-validation-large-buffer-expected.txt: Added.
  • webgl/conformance/buffers/index-validation-large-buffer.html: Added.
  • webgl/conformance/buffers/index-validation-verifies-too-many-indices-expected.txt: Added.
  • webgl/conformance/buffers/index-validation-verifies-too-many-indices.html: Added.
  • webgl/conformance/buffers/index-validation-with-resized-buffer-expected.txt: Added.
  • webgl/conformance/buffers/index-validation-with-resized-buffer.html: Added.
  • webgl/conformance/buffers/index-validation.html: Added.
  • webgl/resources/webgl_test_files/conformance/buffers/00_test_list.txt: Added.
  • webgl/resources/webgl_test_files/conformance/buffers/buffer-bind-test.html: Added.
  • webgl/resources/webgl_test_files/conformance/buffers/buffer-data-array-buffer.html: Added.
  • webgl/resources/webgl_test_files/conformance/buffers/element-array-buffer-delete-recreate.html: Added.
  • webgl/resources/webgl_test_files/conformance/buffers/index-validation-copies-indices.html: Added.
  • webgl/resources/webgl_test_files/conformance/buffers/index-validation-crash-with-buffer-sub-data.html: Added.
  • webgl/resources/webgl_test_files/conformance/buffers/index-validation-large-buffer.html: Added.
  • webgl/resources/webgl_test_files/conformance/buffers/index-validation-verifies-too-many-indices.html: Added.
  • webgl/resources/webgl_test_files/conformance/buffers/index-validation-with-resized-buffer.html: Added.
  • webgl/resources/webgl_test_files/conformance/buffers/index-validation.html: Added.
11:47 AM Changeset in webkit [141909] by commit-queue@webkit.org
  • 21 edits in trunk/Source

Unreviewed, rolling out r141905.
http://trac.webkit.org/changeset/141905
https://bugs.webkit.org/show_bug.cgi?id=108963

"Broke mac build" (Requested by tonyg-cr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-05

Source/WebCore:

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::pumpTokenizer):

  • html/parser/CompactHTMLToken.cpp:

(SameSizeAsCompactHTMLToken):
(WebCore::isStringSafeToSendToAnotherThread):
(WebCore::CompactHTMLToken::isSafeToSendToAnotherThread):

  • html/parser/CompactHTMLToken.h:

(WebCore):
(CompactHTMLToken):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterToken):

  • html/parser/XSSAuditor.h:

(WebCore):
(XSSAuditor):

  • html/parser/XSSAuditorDelegate.cpp:

(WebCore::XSSAuditorDelegate::didBlockScript):

  • html/parser/XSSAuditorDelegate.h:

(WebCore::DidBlockScriptRequest::create):
(WebCore::DidBlockScriptRequest::DidBlockScriptRequest):
(XSSAuditorDelegate):

  • platform/KURL.cpp:
  • platform/KURL.h:

(KURL):

  • platform/KURLGoogle.cpp:

(WebCore::KURLGooglePrivate::reportMemoryUsage):

  • platform/KURLGooglePrivate.h:

(KURLGooglePrivate):

  • platform/KURLWTFURLImpl.h:

(WebCore::KURLWTFURLImpl::reportMemoryUsage):

Source/WTF:

  • wtf/text/CString.cpp:
  • wtf/text/CString.h:
  • wtf/text/WTFString.cpp:
  • wtf/text/WTFString.h:

(String):

  • wtf/url/api/ParsedURL.h:

(ParsedURL):

  • wtf/url/api/URLString.h:
11:38 AM Changeset in webkit [141908] by dominik.rottsches@intel.com
  • 2 edits in trunk/Source/WebCore

[HarfBuzz][Cairo] harfBuzzGetGlyph is slow and hot
https://bugs.webkit.org/show_bug.cgi?id=108941

Reviewed by Kenneth Rohde Christiansen.

The text to glyph conversion using Cairo is slow
due to expensive text codec conversion to UTF-8.
Additionally, the glyph lookup itself is expensive.

Inspired by the approach taken in HarfBuzzFaceSkia.cpp
I suggest to implement a similar caching mechanism to
accelerate this conversion.

Arabic line breaking test, under review in
bug 108948 shows about 58% improvement on my system
with this patch.

  • platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:

(WebCore::HarfBuzzFontData::HarfBuzzFontData):

New container structure that keeps pointers
to the cairo scaled font as well as the glyph cache.

(HarfBuzzFontData):
(WebCore):
(WebCore::harfBuzzGetGlyph): Using the new container structure for accessing the cache.
(WebCore::harfBuzzGetGlyphHorizontalAdvance): Using the new container structure for accessing the scaled font.
(WebCore::harfBuzzGetGlyphExtents): Ditto.
(WebCore::destroyHarfBuzzFontData): Destroying the container that held the pointers.
(WebCore::HarfBuzzFace::createFont):

Initializing the container structure with the pointers
to the cache that is held in HarfBuzzFace and the cairo scaled font.

11:26 AM Changeset in webkit [141907] by mrobinson@webkit.org
  • 1 copy in releases/WebKitGTK/webkit-1.11.5

Tag the WebKitGTK+ 1.11.5 release

11:15 AM Changeset in webkit [141906] by dominik.rottsches@intel.com
  • 2 edits
    1 add in trunk/PerformanceTests

Add a performance test for arabic line breaking
https://bugs.webkit.org/show_bug.cgi?id=108948

Reviewed by Eric Seidel.

Adding a perfomance test based to exercise the complex
font path used in rendering arabic script.

  • Layout/ArabicLineLayout.html: Added.
  • Skipped: New test skipped by default as per Ryosuke's request.
11:06 AM Changeset in webkit [141905] by tonyg@chromium.org
  • 21 edits in trunk/Source

Call XSSAuditor's didBlockScript() for the threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=108726

Reviewed by Adam Barth.

Source/WebCore:

This patch causes us to call didBlockScript() on the main thread if the CompactHTML token has XSSInfo.
To do so, we:

  1. Rename DidBlockScriptRequest to XSSInfo.
  2. Add an OwnPtr<XSSInfo> field to CompactHTMLToken.
  3. Add an isSafeToSendToAnotherThread() method to String and KURL.

We don't yet populate didBlockScriptRequest on the background thread, but this should just work once we do.

No new tests because no new functionality.

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore::BackgroundHTMLParser::pumpTokenizer): Update comment for rename.

  • html/parser/CompactHTMLToken.cpp:

(SameSizeAsCompactHTMLToken):
(WebCore::CompactHTMLToken::CompactHTMLToken): Add a copy constructor used by Vector.
(WebCore::CompactHTMLToken::isSafeToSendToAnotherThread): Include new m_xssInfo field in safety check.
(WebCore):
(WebCore::CompactHTMLToken::xssInfo): Added.
(WebCore::CompactHTMLToken::setXSSInfo): Added.

  • html/parser/CompactHTMLToken.h: Add an OwnPtr<XSSInfo> field to CompactHTMLToken.

(WebCore):
(CompactHTMLToken):
(WTF): Add VectorTraits necessary for copying Vector fields objects that contain an OwnPtr.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser): Add new didBlockScript() call.
(WebCore::HTMLDocumentParser::pumpTokenizer):

  • html/parser/XSSAuditor.cpp: Renaming.

(WebCore::XSSAuditor::filterToken):

  • html/parser/XSSAuditor.h: Renaming.

(WebCore):
(XSSAuditor):

  • html/parser/XSSAuditorDelegate.cpp:

(WebCore::XSSInfo::isSafeToSendToAnotherThread):
(WebCore):
(WebCore::XSSAuditorDelegate::didBlockScript):

  • html/parser/XSSAuditorDelegate.h:

(WebCore::XSSInfo::create):
(XSSInfo):
(WebCore::XSSInfo::XSSInfo):
(XSSAuditorDelegate):

  • platform/KURL.cpp:

(WebCore::KURL::isSafeToSendToAnotherThread): Added.
(WebCore):

  • platform/KURL.h:

(KURL):

  • platform/KURLGoogle.cpp:

(WebCore):
(WebCore::KURLGooglePrivate::isSafeToSendToAnotherThread): Added.

  • platform/KURLGooglePrivate.h:

(KURLGooglePrivate):

  • platform/KURLWTFURLImpl.h:

(WebCore::KURLWTFURLImpl::isSafeToSendToAnotherThread): Added.

Source/WTF:

This patch adds isSafeToSendToAnotherThread() methods to CString, String, ParsedURL and URLString.
These methods check to ensure there are 0 or 1 references.

  • wtf/text/CString.cpp:

(WTF::CString::isSafeToSendToAnotherThread): Added.
(WTF):

  • wtf/text/CString.h:

(CString):

  • wtf/text/WTFString.cpp:

(WTF::String::isSafeToSendToAnotherThread): Added.
(WTF):

  • wtf/text/WTFString.h:

(String):

  • wtf/url/api/ParsedURL.h:

(WTF::ParsedURL::isSafeToSendToAnotherThread): Added.

  • wtf/url/api/URLString.h:

(WTF::URLString::isSafeToSendToAnotherThread): Added.

10:55 AM Changeset in webkit [141904] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Make overlay layers slow-scrolling
https://bugs.webkit.org/show_bug.cgi?id=108957

Patch by Sami Kyostila <skyostil@chromium.org> on 2013-02-05
Reviewed by James Robinson.

Since overlay layers get inserted on top of everything else, we must
mark them slow-scrolling to prevent all scroll input events to the rest
of the page from getting blocked. This is also more correct because
generally the overlay contents need to be repainted whenever the scroll
offset changes, and with this patch the painting happens in sync with
page scrolling.

10:44 AM Changeset in webkit [141903] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Scrolling performance drops doing page load
https://bugs.webkit.org/show_bug.cgi?id=108949

Patch by Andrew Lo <anlo@rim.com> on 2013-02-05
Reviewed by Yong Li.
Internally reviewed by Jakob Petsovits.

Internal PR 291390.
The intention of this code was to not update non-visible tiles during page load.

Before this patch, the code would update tiles that have already been rendered
during page load.

  • Api/BackingStore.cpp:

(BlackBerry::WebKit::BackingStorePrivate::updateTilesForScrollOrNotRenderedRegion):

10:43 AM Changeset in webkit [141902] by bfulgham@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[Windows] Unreviewed VS2010 Build Correction after r141651

StructureRareData.h and StructureRareData.cpp files.

10:36 AM Changeset in webkit [141901] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

TextAutosizing: adjust the maximum difference between cluster text width and its descendant
width.
https://bugs.webkit.org/show_bug.cgi?id=108411

Source/WebCore:

Currently, if a render object is more than 200 CSS units shorter than its parent cluster, it
becomes a separate autosizing cluster (see https://bugs.webkit.org/show_bug.cgi?id=105188).
This doesn't work well for layouts when narrow nodes are related, like nested comments:
deeper comments are all shorter than the parent cluster and become autosized differently. To
avoid that the difference that makes a shorter descendant a new autosizing cluster is
adjusted each time the width difference is not greater than 50 CSS units from the previous
one. This allows nested comments, for example, to remain a part of the parent cluster and be
autosized with the same multiplier.

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-05
Reviewed by Kenneth Rohde Christiansen.

Tests:

fast/text-autosizing/nested-child.html

  • rendering/TextAutosizer.cpp:

(WebCore::TextAutosizingClusterInfo::TextAutosizingClusterInfo):

Added a new field to store the current maximum width difference for the cluster.

(WebCore::TextAutosizer::isAutosizingCluster):

Uses the new field to determine if the current node is a separate cluster,
updates the maximum allowed width difference between the cluster and its descendant.

(WebCore::TextAutosizer::processContainer):
(WebCore::TextAutosizer::clusterShouldBeAutosized):
(WebCore::TextAutosizer::measureDescendantTextWidth):

Non-const reference passed to the methods above.

  • rendering/TextAutosizer.h: updated method parameters.

LayoutTests:

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-05
Reviewed by Kenneth Rohde Christiansen.

Tests that certain width difference doesn't make descendants separate clusters.

  • fast/text-autosizing/nested-child-expected.html: Added.
  • fast/text-autosizing/nested-child.html: Added.
10:30 AM Changeset in webkit [141900] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/chromium

Unreviewed, rolling out r141896.
http://trac.webkit.org/changeset/141896
https://bugs.webkit.org/show_bug.cgi?id=108956

crashes indexdb security tests (Requested by gavinp on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-05

  • public/platform/WebKitPlatformSupport.h:

(WebKit):
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::idbFactory):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

10:26 AM WebKit Team edited by Christophe Dumez
Update my affiliation. (diff)
10:07 AM Changeset in webkit [141899] by jochen@chromium.org
  • 3 edits in trunk/Tools

[chromium] remove methods from the WebTestRunner interface that are only used by WebTestProxyBase
https://bugs.webkit.org/show_bug.cgi?id=108926

Reviewed by Adam Barth.

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebKit):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

9:59 AM Changeset in webkit [141898] by jknotten@chromium.org
  • 2 edits in branches/chromium/1364

Disable Fullscreen API on Android.

Disable the fullscreen API, as it is not working correctly on Android.

BUG=173664
Review URL: https://codereview.chromium.org/12208016

9:55 AM Changeset in webkit [141897] by tonyg@chromium.org
  • 5 edits in trunk/Source/WebCore

Continue making XSSAuditor thread safe: Remove dependency on parser's sourceForToken and TextResourceDecoder
https://bugs.webkit.org/show_bug.cgi?id=108698

Reviewed by Adam Barth.

We'd like to be able to call filterToken() from the BackgroundHTMLParser where there is no HTMLDocumentParser. So we are removing the dependencies of
filterToken() on the HTMLDocumentParser. This patch brings us one step closer to removing the m_parser member from XSSAuditor by passing in the
TextResourceDecoder and HTMLSourceTracker to filterToken. To keep the number of parameters from blowing up, this introduces a FilterTokenRequest struct
to hold its arguments. We expect to add one more member to this struct.

No new tests because no new functionality.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::pumpTokenizer):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterToken):
(WebCore::XSSAuditor::filterStartToken):
(WebCore::XSSAuditor::filterCharacterToken):
(WebCore::XSSAuditor::filterScriptToken):
(WebCore::XSSAuditor::filterObjectToken):
(WebCore::XSSAuditor::filterParamToken):
(WebCore::XSSAuditor::filterEmbedToken):
(WebCore::XSSAuditor::filterAppletToken):
(WebCore::XSSAuditor::filterIframeToken):
(WebCore::XSSAuditor::filterMetaToken):
(WebCore::XSSAuditor::filterBaseToken):
(WebCore::XSSAuditor::filterFormToken):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
(WebCore::XSSAuditor::eraseAttributeIfInjected):
(WebCore::XSSAuditor::decodedSnippetForName):
(WebCore::XSSAuditor::decodedSnippetForAttribute):
(WebCore::XSSAuditor::decodedSnippetForJavaScript):

  • html/parser/XSSAuditor.h:

(WebCore):
(WebCore::FilterTokenRequest::FilterTokenRequest):
(FilterTokenRequest):
(XSSAuditor):

9:42 AM Changeset in webkit [141896] by pilgrim@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Remove idbFactory from WebKitPlatformSupport
https://bugs.webkit.org/show_bug.cgi?id=106457

Reviewed by Adam Barth.

Now that https://codereview.chromium.org/12181010/ has landed, the
idbFactory method is no longer needed. (Embedders must now call
the new setIDBFactory method upon initialization.) Part of a
larger refactoring series; see tracking bug 82948.

  • public/platform/WebKitPlatformSupport.h:

(WebKit):

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::IDBFactoryBackendProxy):

9:21 AM Changeset in webkit [141895] by kerz@chromium.org
  • 5 edits
    4 copies in branches/chromium/1364

Merge 141093

REGRESSION: ChildrenAffectedBy flags lost between siblings which have child elements sharing style
https://bugs.webkit.org/show_bug.cgi?id=105672

Reviewed by Andreas Kling.

Source/WebCore:

Change in how childrenAffectedBy bits were stored made it easier to trigger an issue where childrenAffectedBy bits
were not set due to sharing of styles between cousin elements.

This patch fixes the issue by not sharing styles from children with parents who prevent sharing.

Tests: fast/selectors/cousin-stylesharing-adjacent-selector.html

fast/selectors/cousin-stylesharing-last-child-selector.html

  • css/StyleResolver.cpp:

(WebCore::parentElementPreventsSharing):
(WebCore::StyleResolver::locateCousinList):

  • dom/Element.cpp:

(WebCore::Element::hasFlagsSetDuringStylingOfChildren):

  • dom/Element.h:

(Element):

LayoutTests:

Two test cases by Philippe Wittenbergh that triggers the issue.

  • fast/selectors/cousin-stylesharing-adjacent-selector-expected.html: Added.
  • fast/selectors/cousin-stylesharing-adjacent-selector.html: Added.
  • fast/selectors/cousin-stylesharing-last-child-selector-expected.html: Added.
  • fast/selectors/cousin-stylesharing-last-child-selector.html: Added.

TBR=allan.jensen@digia.com
Review URL: https://codereview.chromium.org/12209019

7:52 AM Changeset in webkit [141894] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

r141788 won't build due to not having all changes needed by Node* change
https://bugs.webkit.org/show_bug.cgi?id=108944

Reviewed by David Kilzer.

Fixed three instances of integerResult(..., m_compileIndex) to be integerResult(..., node).

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForARMv7s):

7:48 AM Changeset in webkit [141893] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip failing test.
https://bugs.webkit.org/show_bug.cgi?id=108942.

  • platform/qt/TestExpectations:
7:34 AM Changeset in webkit [141892] by jocelyn.turcotte@digia.com
  • 4 edits in trunk

[Qt] REGRESSION(r137436): It made all inspector tests timeout on developer builds
https://bugs.webkit.org/show_bug.cgi?id=106554

Reviewed by Simon Hausmann.

.:

Explicitely link WebCore resources in the final DLL only on Windows to
support force_static_libs_as_shared on other platforms.

WebKit1 applications don't get the QtWebKit dynamic library loaded
since libQtWebKitWidgets doesn't depend on libQtWebKit if WebCore and
WebKit1 are dynamic libraries of their own.

  • Source/api.pri:

Source/WebCore:

  • Target.pri:
7:05 AM Changeset in webkit [141891] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: prevent crash, add required error string value
https://bugs.webkit.org/show_bug.cgi?id=108776

Patch by Peter Rybin <prybin@chromium.org> on 2013-02-05
Reviewed by Pavel Feldman.

Error string is assigned where missing, assert is added where empty string is
possible.

  • inspector/InjectedScriptBase.cpp:

(WebCore::InjectedScriptBase::makeEvalCall):

  • inspector/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::injectedScriptForEval):

6:18 AM Changeset in webkit [141890] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Clicking a profile's title in the console loads about:blank.
https://bugs.webkit.org/show_bug.cgi?id=107949

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-02-05
Reviewed by Vsevolod Vlasov.

Quick fix for regression.

  • inspector/front-end/inspector.js:

Avoid "exit route" when URL is a profile URL.

5:54 AM Changeset in webkit [141889] by tkent@chromium.org
  • 4 edits
    2 adds in trunk

INPUT_MULTIPLE_FIELDS_UI: element.focus() should not focus on disabled sub-fields.
https://bugs.webkit.org/show_bug.cgi?id=108924

Reviewed by Kentaro Hara.

Source/WebCore:

The first field may be non-focusable. We should search sub-fields for
focusable one.

Test: fast/forms/date-multiple-fields/date-multiple-fields-focus.html

  • html/shadow/DateTimeEditElement.cpp:

(WebCore::DateTimeEditElement::focusOnNextFocusableField):
Added. A private helper function.
(WebCore::DateTimeEditElement::focusIfNoFocus): Use focusOnNextFocusableField.
(WebCore::DateTimeEditElement::focusByOwner): Ditto.
(WebCore::DateTimeEditElement::focusOnNextField): Ditto.

  • html/shadow/DateTimeEditElement.h:

(DateTimeEditElement): Declare focusOnNextFocusableField.

LayoutTests:

  • fast/forms/date-multiple-fields/date-multiple-fields-focus-expected.txt: Added.
  • fast/forms/date-multiple-fields/date-multiple-fields-focus.html: Added.
5:52 AM Changeset in webkit [141888] by vsevik@chromium.org
  • 8 edits
    2 adds in trunk

Web Inspector: Create separate project for each file system added to inspector.
https://bugs.webkit.org/show_bug.cgi?id=108652

Reviewed by Pavel Feldman.

Source/WebCore:

Every file system added to web inspector is now represented by its own project in workspace.
FileSystemMapping changed accrodingly.

Test: inspector/file-system-mapping.html

  • inspector/front-end/FileMapping.js:

(WebInspector.FileMapping.prototype._entryURIPrefix):

  • inspector/front-end/FileSystemMapping.js:

(WebInspector.FileSystemMapping.prototype.fileForURI):
(WebInspector.FileSystemMapping.prototype.uriForFile):
(WebInspector.FileSystemMapping.prototype.uriPrefixForPathPrefix):
(WebInspector.FileSystemMappingImpl):
(WebInspector.FileSystemMappingImpl.prototype._loadFromSettings.get this):
(WebInspector.FileSystemMappingImpl.prototype._loadFromSettings):
(WebInspector.FileSystemMappingImpl.prototype._saveToSettings):
(WebInspector.FileSystemMappingImpl.prototype.set _fileSystemName):
(WebInspector.FileSystemMappingImpl.prototype.fileSystemId):
(WebInspector.FileSystemMappingImpl.prototype.addFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.removeFileSystemMapping):
(WebInspector.FileSystemMappingImpl.prototype.fileSystemPaths):
(WebInspector.FileSystemMappingImpl.prototype.fileForURI):
(WebInspector.FileSystemMappingImpl.prototype.uriForFile):
(WebInspector.FileSystemMappingImpl.prototype.uriPrefixForPathPrefix):

  • inspector/front-end/FileSystemWorkspaceProvider.js:

(WebInspector.FileSystemWorkspaceProvider):
(WebInspector.FileSystemWorkspaceProvider.prototype.innerCallback):
(WebInspector.FileSystemWorkspaceProvider.prototype.requestFileContent):
(WebInspector.FileSystemWorkspaceProvider.prototype.setFileContent):
(WebInspector.FileSystemWorkspaceProvider.prototype._populate.filesLoaded):
(WebInspector.FileSystemWorkspaceProvider.prototype._populate):
(WebInspector.FileSystemWorkspaceProvider.prototype._addFile):
(WebInspector.FileSystemWorkspaceProvider.prototype._removeFile):
(WebInspector.FileSystemWorkspaceProvider.prototype.reset):

  • inspector/front-end/IsolatedFileSystemModel.js:

(WebInspector.IsolatedFileSystemModel):
(WebInspector.IsolatedFileSystemModel.prototype._innerAddFileSystem):
(WebInspector.IsolatedFileSystemModel.prototype._fileSystemRemoved):

  • inspector/front-end/Workspace.js:

(WebInspector.Project.prototype.searchInFileContent):
(WebInspector.Project.prototype.dispose):
(WebInspector.Workspace.prototype.removeProject):

LayoutTests:

  • inspector/file-mapping.html:
  • inspector/file-system-mapping-expected.txt: Added.
  • inspector/file-system-mapping.html: Added.
5:28 AM WebKit Team edited by mario@webkit.org
(diff)
5:03 AM Changeset in webkit [141887] by tkent@chromium.org
  • 8 edits
    2 adds in trunk

INPUT_MULTIPLE_FIELDS_UI: Should not move focus if the element already has focus
https://bugs.webkit.org/show_bug.cgi?id=108914

Reviewed by Kentaro Hara.

Source/WebCore:

If timeInput.focus() is called when a sub-field of the time input
already has focus, we should not focus on the first sub-field of the
time input.

Test: fast/forms/time-multiple-fields/time-multiple-fields-focus.html

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::willCancelFocus): If
the input elment already has focused sub-field, we don't need to proceed
focus handling. FocusDirection check is required because we don't need
to do this in cases of sequential focus navigation.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType): Override InputType::willCancelFocus.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::focus):
Cancel focus if InputType::willCancelFocus returns true.

  • html/HTMLInputElement.h:

(HTMLInputElement): Override focus.

  • html/InputType.cpp:

(WebCore::InputType::willCancelFocus):
Add a default implementation. It returns false.

  • html/InputType.h:

(InputType): Declare willCancelFocus.

LayoutTests:

  • fast/forms/time-multiple-fields/time-multiple-fields-focus-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-focus.html: Added.
4:57 AM Changeset in webkit [141886] by allan.jensen@digia.com
  • 4 edits in trunk/Source/WebCore

[Qt] RGB -> BGR is wrong on big endian
https://bugs.webkit.org/show_bug.cgi?id=107560

Reviewed by Jocelyn Turcotte.

Replace the conversion to methods that make it clearer what is going on.
The routines are also optimized compared to the existing by avoiding going
over slow Color constructor.

Tested by existing tests in canvas and fast/canvas.

  • platform/graphics/Color.cpp:

(WebCore::colorFromPremultipliedARGB):

Cleanup.

(WebCore::premultipliedARGBFromColor):

Cleanup and correct for alpha = 0.

  • platform/graphics/Color.h:

(WebCore):

  • platform/graphics/qt/ImageBufferQt.cpp:

(WebCore::copyColorToRGBA):
(WebCore::copyRGBAToColor):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):

4:41 AM Changeset in webkit [141885] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[TexMap] Use visible as initial value of backface-visibility-property.
https://bugs.webkit.org/show_bug.cgi?id=108875

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2013-02-05
Reviewed by Noam Rosenthal.

According to W3C spec, the initial value of backface-visibility-visibility is visible.
However TextureMapperLayer's initial value is false which means hidden.
So this patch is for changing the value to visible(true).

Covered by existing tests.

  • platform/graphics/texmap/TextureMapperLayer.h:

(WebCore::TextureMapperLayer::State::State): Change the initial value false to true
to use backface-visibility.

4:34 AM Changeset in webkit [141884] by aandrey@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: [Canvas] do not store a dropped trace log in backend
https://bugs.webkit.org/show_bug.cgi?id=108600

Reviewed by Pavel Feldman.

Clear memory immediately on dropping current trace log instead of waiting for the next capture command.

  • inspector/InjectedScriptCanvasModuleSource.js:

(.):

4:04 AM Changeset in webkit [141883] by aandrey@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Canvas] UI is not restored properly when deleting a live recording profile
https://bugs.webkit.org/show_bug.cgi?id=108602

Reviewed by Pavel Feldman.

Cancel recording profile of canvas-type when deleting an alive trace log.
Drive-by: rename ProfileHeader.reset to ProfileHeader.dispose since it's called on header's destruction.

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileHeader.prototype.dispose):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileHeader.prototype.dispose):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):

2:58 AM Changeset in webkit [141882] by Simon Hausmann
  • 3 edits in trunk/Source/WebKit2

[Qt][WK2] Replace more uses of WebPageProxy with WKPage in QQuickWebView
https://bugs.webkit.org/show_bug.cgi?id=108826

Reviewed by Kenneth Rohde Christiansen and signed off for WK2 by
Benjamin Poulain.

This patch converts a few more usages of WebPageProxy to functions in
the WKPage API.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):
(QQuickWebViewLegacyPrivate::zoomFactor):
(QQuickWebViewLegacyPrivate::setZoomFactor):
(QQuickWebViewExperimental::postMessage):
(QQuickWebViewExperimental::userAgent):
(QQuickWebViewExperimental::setUserAgent):
(QQuickWebViewExperimental::evaluateJavaScript):
(QQuickWebViewExperimental::findText):
(QQuickWebView::goBack):
(QQuickWebView::goForward):
(QQuickWebView::stop):
(QQuickWebView::reload):
(QQuickWebView::setUrl):
(QQuickWebView::canGoBack):
(QQuickWebView::canGoForward):
(QQuickWebView::loading):
(QQuickWebView::title):
(QQuickWebView::pageRef):
(QQuickWebView::loadHtml):
(QQuickWebView::runJavaScriptInMainFrame):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

2:33 AM QtWebKitGardening edited by Csaba Osztrogonác
(diff)
2:32 AM Changeset in webkit [141881] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

Adding a flaky crash expectation for a couple of tests.
Reclassifying the expectation for http/tests/media/video-play-stall.html as a flaky timeouting test.

  • platform/gtk/TestExpectations:
2:27 AM Changeset in webkit [141880] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Build is broken since r141543 for platforms without OpenGL
https://bugs.webkit.org/show_bug.cgi?id=108862

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-02-05
Reviewed by Simon Hausmann.

  • Target.pri:
2:26 AM Changeset in webkit [141879] by haraken@chromium.org
  • 20 edits in trunk/Source

Unreviewed, rolling out r141865.
http://trac.webkit.org/changeset/141865
https://bugs.webkit.org/show_bug.cgi?id=108909

webkit unit tests are broken

Source/WebCore:

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter):
(GenerateEventListenerCallback):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::addEventListenerCallback):
(WebCore::TestEventTargetV8Internal::removeEventListenerCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::addEventListenerCallback):
(WebCore::TestObjV8Internal::removeEventListenerCallback):

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::get):
(WebCore::set):
(WebCore::getNthValueOnKeyPath):
(WebCore::canInjectNthValueOnKeyPath):
(WebCore::ensureNthValueOnKeyPath):
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::canInjectIDBKeyIntoScriptValue):

  • bindings/v8/NPV8Object.cpp:

(WebCore::createValueListFromVariantArgs):
(_NPN_Invoke):
(_NPN_InvokeDefault):
(_NPN_SetProperty):
(_NPN_Construct):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::compileAndRunScript):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::takeHeapSnapshot):

  • bindings/v8/ScriptSourceCode.cpp:

(WebCore::ScriptSourceCode::compileScript):

  • bindings/v8/ScriptSourceCode.h:

(ScriptSourceCode):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):

  • bindings/v8/V8NPUtils.cpp:

(WebCore::convertNPVariantToV8Object):

  • bindings/v8/V8NPUtils.h:

(WebCore):

  • bindings/v8/V8Utilities.cpp:

(WebCore::createHiddenDependency):
(WebCore::removeHiddenDependency):
(WebCore::transferHiddenDependency):

  • bindings/v8/V8Utilities.h:

(WebCore):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::addEventListenerCallback):
(WebCore::V8DOMWindow::removeEventListenerCallback):

Source/WebKit/chromium:

  • src/WebBindings.cpp:

(WebKit::WebBindings::toV8Value):

2:20 AM Changeset in webkit [141878] by jochen@chromium.org
  • 2 edits in trunk/Tools

[chromium] remove unneccessary 0 checks for testRunner now that the TestRunner library owns it
https://bugs.webkit.org/show_bug.cgi?id=108923

Reviewed by Kentaro Hara.

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner):
(WebTestRunner::WebTestProxyBase::shouldBeginEditing):
(WebTestRunner::WebTestProxyBase::shouldEndEditing):
(WebTestRunner::WebTestProxyBase::shouldInsertNode):
(WebTestRunner::WebTestProxyBase::shouldInsertText):
(WebTestRunner::WebTestProxyBase::shouldChangeSelectedRange):
(WebTestRunner::WebTestProxyBase::shouldDeleteRange):
(WebTestRunner::WebTestProxyBase::shouldApplyStyle):
(WebTestRunner::WebTestProxyBase::didBeginEditing):
(WebTestRunner::WebTestProxyBase::didChangeSelection):
(WebTestRunner::WebTestProxyBase::didChangeContents):
(WebTestRunner::WebTestProxyBase::didEndEditing):
(WebTestRunner::WebTestProxyBase::createView):
(WebTestRunner::WebTestProxyBase::setStatusText):
(WebTestRunner::WebTestProxyBase::didStopLoading):
(WebTestRunner::WebTestProxyBase::isSmartInsertDeleteEnabled):
(WebTestRunner::WebTestProxyBase::isSelectTrailingWhitespaceEnabled):
(WebTestRunner::WebTestProxyBase::willPerformClientRedirect):
(WebTestRunner::WebTestProxyBase::didCancelClientRedirect):
(WebTestRunner::WebTestProxyBase::didStartProvisionalLoad):
(WebTestRunner::WebTestProxyBase::didReceiveServerRedirectForProvisionalLoad):
(WebTestRunner::WebTestProxyBase::didFailProvisionalLoad):
(WebTestRunner::WebTestProxyBase::didCommitProvisionalLoad):
(WebTestRunner::WebTestProxyBase::didReceiveTitle):
(WebTestRunner::WebTestProxyBase::didFinishDocumentLoad):
(WebTestRunner::WebTestProxyBase::didHandleOnloadEvents):
(WebTestRunner::WebTestProxyBase::didFailLoad):
(WebTestRunner::WebTestProxyBase::didFinishLoad):
(WebTestRunner::WebTestProxyBase::didChangeLocationWithinPage):
(WebTestRunner::WebTestProxyBase::didDisplayInsecureContent):
(WebTestRunner::WebTestProxyBase::didRunInsecureContent):
(WebTestRunner::WebTestProxyBase::didDetectXSS):
(WebTestRunner::WebTestProxyBase::assignIdentifierToRequest):
(WebTestRunner::WebTestProxyBase::willRequestResource):
(WebTestRunner::WebTestProxyBase::didCreateDataSource):
(WebTestRunner::WebTestProxyBase::willSendRequest):
(WebTestRunner::WebTestProxyBase::didReceiveResponse):
(WebTestRunner::WebTestProxyBase::didFinishResourceLoad):
(WebTestRunner::WebTestProxyBase::didFailResourceLoad):
(WebTestRunner::WebTestProxyBase::runModalBeforeUnloadDialog):
(WebTestRunner::WebTestProxyBase::locationChangeDone):
(WebTestRunner::WebTestProxyBase::decidePolicyForNavigation):
(WebTestRunner::WebTestProxyBase::willCheckAndDispatchMessageEvent):

2:13 AM Changeset in webkit [141877] by mkwst@chromium.org
  • 15 edits in trunk/Source/WebCore

Cleanup: Use exceptionless Range::* methods rather than ignoring exceptions.
https://bugs.webkit.org/show_bug.cgi?id=108773

Reviewed by Darin Adler.

We often call Range::{start,end}{Container,Offset} with an ExceptionCode
that's completely ignored. In these cases, we should simply use the
exceptionless version of the method instead.

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::addMarker):

Here, I also moved parameters onto one line to make the
stylebot happy.

(WebCore::DocumentMarkerController::addTextMatchMarker):
(WebCore::DocumentMarkerController::setMarkersActive):

Dropped ignored ExceptionCode variable entirely.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::visiblePositionForIndex):

Can't drop the variable because of the selectNodeContents call.

  • editing/Editor.cpp:

(WebCore::Editor::canDeleteRange):

Dropped ignored ExceptionCode variable entirely.

(WebCore::Editor::advanceToNextMisspelling):

Can't drop the variable because of setStart/setEnd.

  • editing/EditorCommand.cpp:

(WebCore::unionDOMRanges):

Can't drop the variable because of compareBoundaryPoints.

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::appendNodeValue):

Dropped ignored ExceptionCode variable entirely.

  • editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingParagraph::offsetAsRange):
(WebCore::TextCheckingHelper::findFirstMisspelling):
(WebCore::TextCheckingHelper::findFirstGrammarDetail):
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::renderedText):
(WebCore::StyledMarkupAccumulator::stringValueForRange):

Dropped ignored ExceptionCode variable entirely.

  • editing/visible_units.cpp:

(WebCore::previousBoundary):

Can't drop the variable due to many other calls.

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::deleteFromDocument):
(WebCore::DOMSelection::containsNode):

For both these cases, the 'ASSERT(!ec)' after the statement I've
edited only checked the last occurance of the exception: that is,
if 'startXxx(ec)' threw an exception, it would be overwritten by
the 'setBaseAndExtend()' or 'compareBoundaryPoints()' exception.
Removing the exception parameters from the parameters' calls
shouldn't effect behavior.

  • platform/chromium/PasteboardChromium.cpp:

(WebCore::Pasteboard::writeSelection):

  • platform/mac/HTMLConverter.mm:

(+[WebHTMLConverter editingAttributedStringFromRange:]):

  • platform/win/ClipboardWin.cpp:

(WebCore::ClipboardWin::writeRange):

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::writeSelection):

  • platform/wince/PasteboardWinCE.cpp:

(WebCore::Pasteboard::writeSelection):

Dropped ignored ExceptionCode variable entirely.

2:10 AM Changeset in webkit [141876] by yurys@chromium.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: introduce Memory.getDOMCounters
https://bugs.webkit.org/show_bug.cgi?id=108822

Reviewed by Pavel Feldman.

Introduced Memory.getDOMCounters command that returns number of Documents, Nodes
and JS event listeners in the inspected process.

  • inspector/Inspector.json:
  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::getDOMCounters):
(WebCore):

  • inspector/InspectorMemoryAgent.h:

(InspectorMemoryAgent):

1:57 AM Changeset in webkit [141875] by kadam@inf.u-szeged.hu
  • 2 edits
    2 adds in trunk/LayoutTests

[Qt][Wk2] Unreviewed gardening. Added platform specific expected.

  • platform/qt-5.0-wk2/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Update after r141459.
  • platform/qt-5.0-wk2/http/tests/cache/cancel-multiple-post-xhrs-expected.txt: Added update after r140174.
1:37 AM Changeset in webkit [141874] by loislo@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: rename Image m_data member to m_encodedImageData for the consistency
https://bugs.webkit.org/show_bug.cgi?id=108913

Reviewed by Yury Semikhatsky.

No new tests because no API changes.

  • platform/graphics/Image.cpp:

(WebCore::Image::setData):
(WebCore::Image::reportMemoryUsage):

  • platform/graphics/Image.h:

(WebCore::Image::data):
(Image):

1:19 AM Changeset in webkit [141873] by morrita@google.com
  • 3 edits in trunk/Source/WebCore

Unreviewed Linux ASAN build fix for r141783.

  • platform/RefCountedSupplement.h:

(Wrapper):

  • platform/Supplementable.h:

(Supplement):

1:13 AM Changeset in webkit [141872] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebCore

[chromium] Unreviewed: Fix broken SVG-disabled build.
https://bugs.webkit.org/show_bug.cgi?id=108916

The new enum value CSSPropertyWebkitGridAutoFlow was introduced in
r141787, and accidentally left out of CSSParser::parseValue's big
switch. This causes problems in non-SVG builds.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

1:10 AM Changeset in webkit [141871] by tommyw@google.com
  • 13 edits
    3 deletes in trunk

MediaStream API: Update RTCPeerConnections stream accessors to match the latest specification
https://bugs.webkit.org/show_bug.cgi?id=108179

Reviewed by Adam Barth.

Source/WebCore:

http://dev.w3.org/2011/webrtc/editor/webrtc.html#interface-definition
The attributes localStreams and remoteStreams have been changes to the methods
getLocalStreams() and getRemoteStreams() which return a native array instead.

Existing tests updated to cover patch.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/MediaStream.h:

(WebCore):

  • Modules/mediastream/MediaStreamList.cpp: Removed.
  • Modules/mediastream/MediaStreamList.h: Removed.
  • Modules/mediastream/MediaStreamList.idl: Removed.
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::addStream):
(WebCore::RTCPeerConnection::removeStream):
(WebCore::RTCPeerConnection::getLocalStreams):
(WebCore::RTCPeerConnection::getRemoteStreams):
(WebCore::RTCPeerConnection::didAddRemoteStream):
(WebCore::RTCPeerConnection::didRemoveRemoteStream):

  • Modules/mediastream/RTCPeerConnection.h:

(RTCPeerConnection):

  • Modules/mediastream/RTCPeerConnection.idl:
  • WebCore.gypi:

LayoutTests:

Updating tests for RTCPeerConnections new stream accessors.

  • fast/mediastream/RTCPeerConnection-AddRemoveStream-expected.txt:
  • fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
  • fast/mediastream/RTCPeerConnection-statsSelector-expected.txt:
  • fast/mediastream/RTCPeerConnection-statsSelector.html:
1:07 AM Changeset in webkit [141870] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Qt][EFL][WebGL] Webgl doesn't work on nvidia cards
https://bugs.webkit.org/show_bug.cgi?id=108059

Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2013-02-05
Reviewed by Kenneth Rohde Christiansen.

Commit r138327 fixed repainting issues on mesa3d GL library by re-binding
texture to the window after every glXSwapBuffer. Unfortunatelly re-bind
breaks rendering on NVidia cards with NVidia propiertary drivers.
This change limits texture re-binding only for mesa3d GL library.

No new tests. HW specific fix.

  • platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:

(WebCore::OffScreenRootWindow::isMesaGLX):
(OffScreenRootWindow):
(WebCore::GraphicsSurface::platformSwapBuffers):

1:05 AM Changeset in webkit [141869] by shinyak@chromium.org
  • 3 edits in trunk/LayoutTests

touch-event.html should check touchstartFiredInShadowDOM is true.
https://bugs.webkit.org/show_bug.cgi?id=108910

Reviewed by Hajime Morita.

We have to check touchstartFiredInShadowDOM is true so that we can assure touch event is in ShadowDOM.
This is a follow-up patch for http://trac.webkit.org/changeset/141054

  • fast/dom/shadow/touch-event-expected.txt:
  • fast/dom/shadow/touch-event.html:
12:55 AM Changeset in webkit [141868] by mrobinson@webkit.org
  • 4 edits in trunk

Update the NEWS and configuration in preparation for 1.11.5.

Reviewed by Philippe Normand.

.:

  • configure.ac:

Source/WebKit/gtk:

  • NEWS:
12:39 AM Changeset in webkit [141867] by commit-queue@webkit.org
  • 6 edits in trunk

Floating point precision error in AudioPannerNode.
https://bugs.webkit.org/show_bug.cgi?id=106001

Patch by Praveen Jadhav <praveen.j@samsung.com> on 2013-02-05
Reviewed by Kentaro Hara.

Specifications Update:
https://dvcs.w3.org/hg/audio/rev/69a39a516e45

Source/WebCore:

Conversion from double to float and back to double
results in precision error. Avoiding these conversions
will make sure that proper values are retained in the
parameters.

  • Modules/webaudio/PannerNode.h:

(WebCore::PannerNode::refDistance):
(WebCore::PannerNode::setRefDistance):
(WebCore::PannerNode::maxDistance):
(WebCore::PannerNode::setMaxDistance):
(WebCore::PannerNode::rolloffFactor):
(WebCore::PannerNode::setRolloffFactor):
(WebCore::PannerNode::coneInnerAngle):
(WebCore::PannerNode::setConeInnerAngle):
(WebCore::PannerNode::coneOuterAngle):
(WebCore::PannerNode::setConeOuterAngle):
(WebCore::PannerNode::coneOuterGain):
(WebCore::PannerNode::setConeOuterGain):

  • Modules/webaudio/PannerNode.idl:

LayoutTests:

New test scenarios are added to verify precision
error issues in PannerNode.

  • webaudio/pannernode-basic-expected.txt:
  • webaudio/pannernode-basic.html:
12:31 AM Changeset in webkit [141866] by tkent@chromium.org
  • 13 edits in trunk

INPUT_MULTIPLE_FIELDS_UI: Use disabled attribute internally instead of readonly attribute
https://bugs.webkit.org/show_bug.cgi?id=108911

Reviewed by Kentaro Hara.

Source/WebCore:

Use 'disabled' attribute for shadow elements for <input> with
multiple-fields UI instead of 'readonly' attribute because 'readonly'
attribute represents focusable-but-non-editable state in HTML though
we'd like to represent non-focusable-and-non-editable state.

The summary of changes:

  • Use 'disabled' attribute instead of 'readonly' attribute for DateTimeFieldElement,
  • Rename C++ functions for it,
  • Call isFocusable instead of isReadOnly to check focusable state.

No new tests. This doesn't make user-visible behavior changes.

  • css/html.css:

Replace [readonly] with [disabled] for sub-fields.

  • html/shadow/DateTimeEditElement.cpp:

(DateTimeEditBuilder):
(WebCore::DateTimeEditBuilder::visitField):
(WebCore::DateTimeEditBuilder::shouldDayOfMonthFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldHourFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldMillisecondFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldMinuteFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldSecondFieldDisabled):
(WebCore::DateTimeEditBuilder::shouldYearFieldDisabled):
(WebCore::DateTimeEditElement::anyEditableFieldsHaveValues):
(WebCore::DateTimeEditElement::focusOnNextField): Use isFocusable.
(WebCore::DateTimeEditElement::focusOnPreviousField): Use isFocusable.

  • html/shadow/DateTimeFieldElement.cpp:

(WebCore::DateTimeFieldElement::isFocusable):
(WebCore::DateTimeFieldElement::isDisabled):
(WebCore::DateTimeFieldElement::setDisabled):

  • html/shadow/DateTimeFieldElement.h:

(DateTimeFieldElement): Make isFocusable public in order that
DateTimeEditElement can call it.

  • html/shadow/DateTimeNumericFieldElement.cpp:

(WebCore::DateTimeNumericFieldElement::handleKeyboardEvent):
(WebCore::DateTimeNumericFieldElement::setEmptyValue):

  • html/shadow/DateTimeSymbolicFieldElement.cpp:

(WebCore::DateTimeSymbolicFieldElement::setEmptyValue):

LayoutTests:

  • fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html:
  • fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html:
  • fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield.html:
  • fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html:
  • fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield.html:
12:20 AM Changeset in webkit [141865] by haraken@chromium.org
  • 20 edits in trunk/Source

[V8] Reduce usage of deprecatedString() and deprecatedInteger()
https://bugs.webkit.org/show_bug.cgi?id=108909

Reviewed by Adam Barth.

Source/WebCore:

By passing an Isolate parameter around, we can reduce usage of
deprecated methods.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateNormalAttrSetter):
(GenerateEventListenerCallback):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::addEventListenerCallback):
(WebCore::TestEventTargetV8Internal::removeEventListenerCallback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::addEventListenerCallback):
(WebCore::TestObjV8Internal::removeEventListenerCallback):

  • bindings/v8/IDBBindingUtilities.cpp:

(WebCore::get):
(WebCore::set):
(WebCore::getNthValueOnKeyPath):
(WebCore::canInjectNthValueOnKeyPath):
(WebCore::ensureNthValueOnKeyPath):
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::canInjectIDBKeyIntoScriptValue):

  • bindings/v8/NPV8Object.cpp:

(WebCore::createValueListFromVariantArgs):
(_NPN_Invoke):
(_NPN_InvokeDefault):
(_NPN_SetProperty):
(_NPN_Construct):

  • bindings/v8/ScriptController.cpp:

(WebCore::ScriptController::compileAndRunScript):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore):
(WebCore::ScriptProfiler::takeHeapSnapshot):

  • bindings/v8/ScriptSourceCode.cpp:

(WebCore::ScriptSourceCode::compileScript):

  • bindings/v8/ScriptSourceCode.h:

(ScriptSourceCode):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::prepareListenerObject):

  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):
(WebCore::npObjectGetProperty):

  • bindings/v8/V8NPUtils.cpp:

(WebCore::convertNPVariantToV8Object):

  • bindings/v8/V8NPUtils.h:

(WebCore):

  • bindings/v8/V8Utilities.cpp:

(WebCore::createHiddenDependency):
(WebCore::removeHiddenDependency):
(WebCore::transferHiddenDependency):

  • bindings/v8/V8Utilities.h:

(WebCore):

  • bindings/v8/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::addEventListenerCallback):
(WebCore::V8DOMWindow::removeEventListenerCallback):

Source/WebKit/chromium:

No tests. No change in behavior.

  • src/WebBindings.cpp:

(WebKit::WebBindings::toV8Value):

12:03 AM Changeset in webkit [141864] by dino@apple.com
  • 14 edits
    2 moves
    1 add
    1 delete in trunk

[Mac] Captions menu should indicate language and type of track
https://bugs.webkit.org/show_bug.cgi?id=108882

Reviewed by Eric Carlson.

Source/WebCore:

On Mac, we want a specific format for menu items in a caption list. Since
other ports might want different formats, move the generation of the label
into CaptionsUserPreferences where it can be overridden.

This required CaptionsUserPreferences to become public on the PageGroup, so
it could be used when creating the menu. Also, since CaptionsUserPreferences
was hidden on Mountain Lion and below, be a little more specific about
which pieces can be seen on which builds.

Covered by existing media/video-controls-captions-trackmenu tests.

  • English.lproj/Localizable.strings: Remove textTrackClosedCaptionsText.
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu): Build only

one section and get the track's display name from the user preferences.

  • page/CaptionUserPreferences.h:

(WebCore::CaptionUserPreferences::displayNameForTrack): Default implementation of

virtual function that provides a label for a captions menu item.

  • page/CaptionUserPreferencesMac.h: Add the new virtual function, and expose just

a bit of this class outside 10.9 builds.

  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::CaptionUserPreferencesMac): Guard features for system version.
(WebCore::CaptionUserPreferencesMac::~CaptionUserPreferencesMac): Ditto.
(WebCore::CaptionUserPreferencesMac::displayNameForTrack): New OS X-specific method that

returns a string for the menu label.

  • page/PageGroup.cpp:

(WebCore::PageGroup::captionPreferences): Unguard for system version.

  • page/PageGroup.h: Make captionPreferences public.
  • platform/LocalizedStrings.cpp: Remove textTrackClosedCaptionsText - not needed any more.
  • platform/LocalizedStrings.h: Remove textTrackClosedCaptionsText.

LayoutTests:

Now that the captions menu can be labelled in a platform-specific way, move
the results into the platform directory. At the moment, they are skipped
everywhere but Mac. Also update the tests to the new menu structure, which
only has a single list of entries.

  • media/video-controls-captions-trackmenu-localized.html: Updated for new menu structure.
  • media/video-controls-captions-trackmenu-expected.txt: Removed.
  • media/video-controls-captions-trackmenu-localized-expected.txt: Removed.
  • media/video-controls-captions-trackmenu-sorted-expected.txt: Removed.
  • media/video-controls-captions-trackmenu-sorted.html: Updated for new menu structure.
  • media/video-controls-captions-trackmenu.html: Updated for new menu structure.
  • platform/mac/media/video-controls-captions-trackmenu-expected.txt: New platform specific results.
  • platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt: Ditto.
  • platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt: Ditto.
12:00 AM Changeset in webkit [141863] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

EWS bots don't remove untracked files after processing a patch
https://bugs.webkit.org/show_bug.cgi?id=108891

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-04
Reviewed by Adam Barth.

Added option to remove untracked files in the bot's repo.

  • EWSTools/start-queue.sh:

Feb 4, 2013:

11:39 PM Changeset in webkit [141862] by haraken@chromium.org
  • 31 edits in trunk/Source/WebCore

[V8] Pass an Isolate to V8DOMConfiguration
https://bugs.webkit.org/show_bug.cgi?id=108900

Reviewed by Adam Barth.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateToV8Converters):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::ConfigureV8Float64ArrayTemplate):
(WebCore::V8Float64Array::createWrapper):

  • bindings/scripts/test/V8/V8Float64Array.h:

(WebCore::V8Float64Array::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::ConfigureV8TestActiveDOMObjectTemplate):
(WebCore::V8TestActiveDOMObject::createWrapper):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(WebCore::V8TestActiveDOMObject::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::ConfigureV8TestCustomNamedGetterTemplate):
(WebCore::V8TestCustomNamedGetter::createWrapper):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(WebCore::V8TestCustomNamedGetter::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::ConfigureV8TestEventConstructorTemplate):
(WebCore::V8TestEventConstructor::createWrapper):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(WebCore::V8TestEventConstructor::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::ConfigureV8TestEventTargetTemplate):
(WebCore::V8TestEventTarget::createWrapper):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(WebCore::V8TestEventTarget::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::createWrapper):

  • bindings/scripts/test/V8/V8TestException.h:

(WebCore::V8TestException::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::ConfigureV8TestInterfaceTemplate):
(WebCore::V8TestInterface::createWrapper):

  • bindings/scripts/test/V8/V8TestInterface.h:

(WebCore::V8TestInterface::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::ConfigureV8TestMediaQueryListListenerTemplate):
(WebCore::V8TestMediaQueryListListener::createWrapper):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(WebCore::V8TestMediaQueryListListener::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::ConfigureV8TestNamedConstructorTemplate):
(WebCore::V8TestNamedConstructor::createWrapper):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(WebCore::V8TestNamedConstructor::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::ConfigureV8TestNodeTemplate):
(WebCore::V8TestNode::createWrapper):

  • bindings/scripts/test/V8/V8TestNode.h:

(WebCore::V8TestNode::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::ConfigureV8TestObjTemplate):
(WebCore::V8TestObj::installPerContextProperties):
(WebCore::V8TestObj::createWrapper):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::ConfigureV8TestOverloadedConstructorsTemplate):
(WebCore::V8TestOverloadedConstructors::createWrapper):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(WebCore::V8TestOverloadedConstructors::installPerContextProperties):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
(WebCore::V8TestSerializedScriptValueInterface::createWrapper):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(WebCore::V8TestSerializedScriptValueInterface::installPerContextProperties):

  • bindings/v8/V8DOMConfiguration.cpp:

(WebCore::V8DOMConfiguration::batchConfigureAttributes):
(WebCore::V8DOMConfiguration::batchConfigureConstants):
(WebCore::V8DOMConfiguration::batchConfigureCallbacks):
(WebCore::V8DOMConfiguration::configureTemplate):

  • bindings/v8/V8DOMConfiguration.h:

(V8DOMConfiguration):
(WebCore::V8DOMConfiguration::configureAttribute):

  • bindings/v8/V8DOMWindowShell.cpp:

(WebCore::V8DOMWindowShell::installDOMWindow):

11:28 PM Changeset in webkit [141861] by morrita@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, skipping heap-snapshot-with-detached-dom-tree.html

  • platform/chromium/TestExpectations:
10:53 PM Changeset in webkit [141860] by haraken@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Clean up CodeGeneratorV8.pm by introducing HasCustom{Getter,Setter,Method}
https://bugs.webkit.org/show_bug.cgi?id=108896

Reviewed by Adam Barth.

No tests. No change in generated code.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(HasCustomGetter):
(HasCustomSetter):
(HasCustomMethod):
(GetFunctionTemplateCallbackName):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(RequiresCustomSignature):

10:35 PM Changeset in webkit [141859] by morrita@google.com
  • 1 edit
    6 adds in trunk/LayoutTests

[Chromium] Unreviewed rebaselining.

  • platform/chromium-linux/compositing/overflow/scrolling-without-painting-expected.txt: Added.
  • platform/chromium-linux/compositing/overflow/updating-scrolling-content-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/scrolling-without-painting-expected.txt: Added.
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/overflow/updating-scrolling-content-expected.txt: Added.
10:20 PM Changeset in webkit [141858] by tkent@chromium.org
  • 3 edits
    2 adds in trunk

Fix crash by <select> type change on focus
https://bugs.webkit.org/show_bug.cgi?id=108830

Reviewed by Abhishek Arya.

Source/WebCore:

Test: fast/forms/select/select-change-type-on-focus.html

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::menuListDefaultEventHandler):
focus() calls may change the renderer type.

LayoutTests:

  • fast/forms/select/select-change-type-on-focus-expected.txt: Added.
  • fast/forms/select/select-change-type-on-focus.html: Added.
10:08 PM Changeset in webkit [141857] by haraken@chromium.org
  • 6 edits in trunk/Source/WebCore

[V8] Pass an Isolate to opaqueRootForGC()
https://bugs.webkit.org/show_bug.cgi?id=108886

Reviewed by Adam Barth.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateOpaqueRootForGC):
(GenerateHeader):

  • bindings/v8/V8GCController.cpp:

(WebCore::V8GCController::opaqueRootForGC):

  • bindings/v8/WrapperTypeInfo.h:

(WebCore):
(WebCore::WrapperTypeInfo::opaqueRootForGC):

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::opaqueRootForGC):

9:56 PM Changeset in webkit [141856] by haraken@chromium.org
  • 7 edits in trunk/LayoutTests

Add missing tests for default values of event constructors
https://bugs.webkit.org/show_bug.cgi?id=108885

Reviewed by Adam Barth.

Spec: https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-keyboardevent

  • fast/events/constructors/keyboard-event-constructor-expected.txt:
  • fast/events/constructors/keyboard-event-constructor.html:
  • fast/events/constructors/mouse-event-constructor-expected.txt:
  • fast/events/constructors/mouse-event-constructor.html:
  • fast/events/constructors/wheel-event-constructor-expected.txt:
  • fast/events/constructors/wheel-event-constructor.html:
9:22 PM Changeset in webkit [141855] by gman@chromium.org
  • 1 edit
    65 adds in trunk/LayoutTests

Add Support Files for WebGL Conformance Tests
https://bugs.webkit.org/show_bug.cgi?id=108731

Reviewed by Kenneth Russell.

These are the 'resource' files for the WebGL
Conformance Tests. Other CLs will add the
actual tests.

  • webgl/resources/webgl_test_files/conformance/resources/3x3.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/blue-1x1.jpg: Added.
  • webgl/resources/webgl_test_files/conformance/resources/boolUniformShader.vert: Added.
  • webgl/resources/webgl_test_files/conformance/resources/bug-32888-texture.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/floatUniformShader.vert: Added.
  • webgl/resources/webgl_test_files/conformance/resources/fragmentShader.frag: Added.
  • webgl/resources/webgl_test_files/conformance/resources/glsl-conformance-test.js: Added.

(GLSLConformanceTester):

  • webgl/resources/webgl_test_files/conformance/resources/glsl-feature-tests.css: Added.

(canvas):
(.shader-source):
(.shader-source li:nth-child(odd)):
(.shader-source li:nth-child(even)):
(.testimages):
(.testimages br):
(.testimages > div):
(IMG):

  • webgl/resources/webgl_test_files/conformance/resources/glsl-generator.js: Added.

(GLSLGenerator.):
(GLSLGenerator):

  • webgl/resources/webgl_test_files/conformance/resources/gray-ramp-256-with-128-alpha.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/gray-ramp-256.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/gray-ramp-default-gamma.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/gray-ramp-gamma0.1.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/gray-ramp-gamma1.0.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/gray-ramp-gamma2.0.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/gray-ramp-gamma4.0.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/gray-ramp-gamma9.0.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/gray-ramp.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/green-2x2-16bit.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/intArrayUniformShader.vert: Added.
  • webgl/resources/webgl_test_files/conformance/resources/intUniformShader.vert: Added.
  • webgl/resources/webgl_test_files/conformance/resources/matUniformShader.vert: Added.
  • webgl/resources/webgl_test_files/conformance/resources/noopUniformShader.frag: Added.
  • webgl/resources/webgl_test_files/conformance/resources/noopUniformShader.vert: Added.
  • webgl/resources/webgl_test_files/conformance/resources/npot-video.mp4: Added.
  • webgl/resources/webgl_test_files/conformance/resources/npot-video.theora.ogv: Added.
  • webgl/resources/webgl_test_files/conformance/resources/npot-video.webmvp8.webm: Added.
  • webgl/resources/webgl_test_files/conformance/resources/ogles-tests.css: Added.

(canvas):
(.shader-source):
(.shader-source li:nth-child(odd)):
(.shader-source li:nth-child(even)):
(.testimages):
(.testimages br):
(.testimages > div):
(IMG):

  • webgl/resources/webgl_test_files/conformance/resources/pnglib.js: Added.

(.):

  • webgl/resources/webgl_test_files/conformance/resources/red-green.mp4: Added.
  • webgl/resources/webgl_test_files/conformance/resources/red-green.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/red-green.theora.ogv: Added.
  • webgl/resources/webgl_test_files/conformance/resources/red-green.webmvp8.webm: Added.
  • webgl/resources/webgl_test_files/conformance/resources/red-indexed.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/samplerUniformShader.frag: Added.
  • webgl/resources/webgl_test_files/conformance/resources/small-square-with-cie-rgb-profile.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/small-square-with-colormatch-profile.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/small-square-with-colorspin-profile.jpg: Added.
  • webgl/resources/webgl_test_files/conformance/resources/small-square-with-colorspin-profile.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/small-square-with-e-srgb-profile.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/small-square-with-smpte-c-profile.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/small-square-with-srgb-iec61966-2.1-profile.png: Added.
  • webgl/resources/webgl_test_files/conformance/resources/structUniformShader.vert: Added.
  • webgl/resources/webgl_test_files/conformance/resources/tex-image-and-sub-image-2d-with-canvas.js: Added.

(.init):
(.setCanvasToRedGreen):
(.drawTextInCanvas):
(.setCanvasTo257x257):
(.setCanvasTo1x2):
(.else):
(.runOneIteration):
(.runTest.runNextTest):
(.runTest):
(generateTest):

  • webgl/resources/webgl_test_files/conformance/resources/tex-image-and-sub-image-2d-with-image-data.js: Added.

(.init):
(.runOneIteration):
(.runTest):
(generateTest):

  • webgl/resources/webgl_test_files/conformance/resources/tex-image-and-sub-image-2d-with-image.js: Added.

(.init):
(.runOneIteration):
(.runTestOnImage):
(.runTest.newImage.onload):
(.runTest):
(.runTest2.newImage.onload):
(.runTest2):
(.runTest3):
(generateTest):

  • webgl/resources/webgl_test_files/conformance/resources/tex-image-and-sub-image-2d-with-video.js: Added.

(debug):
(.init):
(.runOneIteration):
(.runTest):

  • webgl/resources/webgl_test_files/conformance/resources/vertexShader.vert: Added.
  • webgl/resources/webgl_test_files/conformance/resources/webgl-test-utils.js: Added.

(WebGLTestUtils):
(WebGLTestUtils.):

  • webgl/resources/webgl_test_files/conformance/resources/webgl-test.js: Added.

(webglTestLog):
(getGLErrorAsString):
(shouldGenerateGLError):
(glErrorShouldBe):

  • webgl/resources/webgl_test_files/conformance/resources/zero-alpha.png: Added.
  • webgl/resources/webgl_test_files/resources/desktop-gl-constants.js: Added.
  • webgl/resources/webgl_test_files/resources/js-test-post.js: Added.
  • webgl/resources/webgl_test_files/resources/js-test-pre.js: Added.

(.):
(reportTestResultsToHarness):
(notifyFinishedToHarness):
(description):
(debug):
(escapeHTML):
(testPassed):
(testFailed):
(areArraysEqual):
(isMinusZero):
(isResultCorrect):
(stringify):
(evalAndLog):
(shouldBe):
(shouldNotBe):
(shouldBeTrue):
(shouldBeFalse):
(shouldBeNaN):
(shouldBeNull):
(shouldBeEqualToString):
(shouldEvaluateTo):
(shouldBeNonZero):
(shouldBeNonNull):
(shouldBeUndefined):
(shouldBeDefined):
(shouldBeGreaterThanOrEqual):
(expectTrue):
(shouldThrow):
(assertMsg):
(gc.gcRec):
(gc):
(finishTest.epilogue.onload):
(finishTest):

  • webgl/resources/webgl_test_files/resources/js-test-style.css: Added.

(.pass):
(.fail):
(#console):

  • webgl/resources/webgl_test_files/resources/test-eval.js: Added.

(TestEval):

  • webgl/resources/webgl_test_files/resources/webgl-logo.png: Added.
  • webgl/resources/webgl_test_files/resources/webgl-test-harness.js: Added.

(WebGLTestHarnessModule.log):
(WebGLTestHarnessModule.try.request.onreadystatechange):
(WebGLTestHarnessModule.loadTextFileAsynchronous):
(WebGLTestHarnessModule.greaterThanOrEqualToVersion):
(WebGLTestHarnessModule.copyObject):
(WebGLTestHarnessModule.toCamelCase):
(WebGLTestHarnessModule.):
(WebGLTestHarnessModule.getFileListImpl):
(WebGLTestHarnessModule.var):
(WebGLTestHarnessModule.getFileList):
(WebGLTestHarnessModule.FilterURL):
(WebGLTestHarnessModule.TestFile):
(WebGLTestHarnessModule.Test):
(WebGLTestHarnessModule.TestHarness):
(WebGLTestHarnessModule.TestHarness.prototype.addFiles_):
(WebGLTestHarnessModule.TestHarness.prototype.runTests):
(WebGLTestHarnessModule.TestHarness.prototype.setTimeout):
(WebGLTestHarnessModule.TestHarness.prototype.clearTimeout):
(WebGLTestHarnessModule.TestHarness.prototype.startNextTest):
(WebGLTestHarnessModule.TestHarness.prototype.startTest):
(WebGLTestHarnessModule.TestHarness.prototype.getTest):
(WebGLTestHarnessModule.TestHarness.prototype.reportResults):
(WebGLTestHarnessModule.TestHarness.prototype.dequeTest):
(WebGLTestHarnessModule.TestHarness.prototype.notifyFinished):
(WebGLTestHarnessModule.TestHarness.prototype.timeout):
(WebGLTestHarnessModule.TestHarness.prototype.setTimeoutDelay):
(WebGLTestHarnessModule):

  • webgl/resources/webkit-webgl-test-harness.js: Added.

(.):

9:11 PM Changeset in webkit [141854] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r180583. Requested by
"Mark Pilgrim" <pilgrim@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-04

  • DEPS:
8:45 PM Changeset in webkit [141853] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Coordinated Graphics : disconnectCustomFilterProgram does not do anything.
https://bugs.webkit.org/show_bug.cgi?id=108807

Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2013-02-04
Reviewed by Anders Carlsson.

We need to add newly created WebCustomFilterProgramProxy to a hashset to
disconnect when CoordinatedLayerTreeHost gets destructed.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::checkCustomFilterProgramProxies):

8:40 PM Changeset in webkit [141852] by morrita@google.com
  • 4 edits
    4 copies
    2 moves
    5 adds in trunk/LayoutTests

[Chromium] Unreviewed rebaselining for r141769.

  • platform/chromium-mac-lion/compositing/overflow/nested-scrolling-expected.png:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/overflow/nested-scrolling-expected.png: Added.
  • platform/chromium-mac-snowleopard/compositing/overflow/nested-scrolling-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/overflow/nested-scrolling-expected.png: Added.
  • platform/chromium-mac/compositing/overflow/nested-scrolling-expected.png:
  • platform/chromium-mac/compositing/overflow/textarea-scroll-touch-expected.txt: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/nested-scrolling-expected.png: Added.
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/overflow/textarea-scroll-touch-expected.txt: Added.
  • platform/chromium/compositing/overflow/scrolling-without-painting-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt.
  • platform/chromium/compositing/overflow/updating-scrolling-content-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt.
  • platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt.
  • platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt.
  • platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/scrolling-without-painting-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt.
  • platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/updating-scrolling-content-expected.txt: Renamed from LayoutTests/platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt.
8:30 PM Changeset in webkit [141851] by james.wei@intel.com
  • 2 edits in trunk/Source/WebCore

Heap-buffer-overflow in WebCore::AudioBufferSourceNode::process
https://bugs.webkit.org/show_bug.cgi?id=108515

After calling setBuffer() with a buffer having a different number of
channels, there can in rare cases be a slight delay before the output
bus is updated to the new number of channels because of use of
tryLocks() in the context's updating system.
In this case, if the the buffer has just been changed and we're
not quite ready yet then just output silence.

Reviewed by Chris Rogers.

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::renderFromBuffer):

8:23 PM Changeset in webkit [141850] by simonjam@chromium.org
  • 8 edits in trunk/Source

[Chromium] Add a signal for when the body is inserted in the document
https://bugs.webkit.org/show_bug.cgi?id=108725

Reviewed by Adam Barth.

Source/WebCore:

This is an important signal for resource scheduling. We know we have enough to paint something,
so we can start kicking off image preloads.

Test: Chromium webkit_unit_tests

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::insertHTMLBodyElement):

  • loader/FrameLoaderClient.h:

(FrameLoaderClient):
(WebCore::FrameLoaderClient::dispatchWillInsertBody):

Source/WebKit/chromium:

  • public/WebFrameClient.h:

(WebFrameClient):
(WebKit::WebFrameClient::willInsertBody):

  • src/FrameLoaderClientImpl.cpp:

(WebKit::FrameLoaderClientImpl::dispatchWillInsertBody):
(WebKit):

  • src/FrameLoaderClientImpl.h:

(FrameLoaderClientImpl):

  • tests/WebFrameTest.cpp:
8:21 PM Changeset in webkit [141849] by benjamin@webkit.org
  • 47 edits in trunk

Kill suspendAnimation(), resumeAnimation() and numberOfActiveAnimations() from DRT/WTR; use Internals
https://bugs.webkit.org/show_bug.cgi?id=108741

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-04
Reviewed by Tony Chang.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

Move suspendAnimations and resumeAnimations to group all the animation related
code together.

Add support for numberOfActiveAnimations, similarily to the feature previously defined
in TestRunner.

  • testing/Internals.cpp:

(WebCore::Internals::numberOfActiveAnimations):
(WebCore):
(WebCore::Internals::suspendAnimations):
(WebCore::Internals::resumeAnimations):

  • testing/Internals.h:

(Internals):

  • testing/Internals.idl:

Source/WebKit/efl:

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
  • WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
  • WebCoreSupport/DumpRenderTreeSupportGtk.h:

(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

  • WebView/WebFrame.mm:
  • WebView/WebFramePrivate.h:

Source/WebKit/qt:

  • WebCoreSupport/DumpRenderTreeSupportQt.cpp:
  • WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

  • WebKit.vcproj/WebKitExports.def.in:

Source/WebKit2:

Suspending and resuming application has been useless for a one. Someone just
"forgot" WebKit2.

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
  • WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h:
  • WebProcess/WebPage/WebFrame.cpp:
  • WebProcess/WebPage/WebFrame.h:

(WebFrame):

Tools:

Remove all support for suspendAnimation(), resumeAnimation() and numberOfActiveAnimations().

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):

  • DumpRenderTree/TestRunner.h:

(TestRunner):

  • DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/efl/TestRunnerEfl.cpp:
  • DumpRenderTree/gtk/TestRunnerGtk.cpp:
  • DumpRenderTree/mac/TestRunnerMac.mm:
  • DumpRenderTree/qt/TestRunnerQt.cpp:
  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunner):

  • DumpRenderTree/win/TestRunnerWin.cpp:
  • DumpRenderTree/wx/TestRunnerWx.cpp:
  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:
  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Update the tests to use WebCore Internals instead of the TestRunner.

  • animations/animation-controller-drt-api.html:
  • transitions/hang-with-bad-transition-list.html:
  • transitions/remove-transition-style.html:
  • transitions/repeated-firing-background-color.html:
  • transitions/zero-duration-with-non-zero-delay-end.html:
8:02 PM Changeset in webkit [141848] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Implement runBeforeUnloadConfirmPanel on EFL
https://bugs.webkit.org/show_bug.cgi?id=106979

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-02-04
Reviewed by Benjamin Poulain.

Implement runBeforeUnloadConfirmPanel() to support window.onbeforeunload.
We can show confirmation window when beforeunload event is fired.

  • UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::PageUIClientEfl):
(WebKit::PageUIClientEfl::runBeforeUnloadConfirmPanel):
(WebKit):

  • UIProcess/efl/PageUIClientEfl.h:

(PageUIClientEfl):

7:42 PM Changeset in webkit [141847] by thakis@chromium.org
  • 3 edits in trunk/Tools

[chromium] Try to get WebKit building with enable_web_intents set to 0 on Windows too.
https://bugs.webkit.org/show_bug.cgi?id=108887

Reviewed by Kentaro Hara.

This is a follow-up to http://trac.webkit.org/changeset/141614. The
Mac and Linux linkers didn't complain about the reference to
WebIntent in that function for some reason (probably because it's
a dead function that's stripped).

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

7:30 PM Changeset in webkit [141846] by nayankk@motorola.com
  • 6 edits in trunk/Source/WebCore

[WEBGL] Rename WEBKIT_WEBGL_compressed_texture_s3tc to WEBGL_compressed_texture_s3tc
https://bugs.webkit.org/show_bug.cgi?id=108866

Reviewed by Kenneth Russell.

WEBGL_compressed_texture_s3tc is one of the community approved WebGL extension.
Hence remove the vendor prefix from WEBKIT_WEBGL_compressed_texture_s3tc.
Specification: http://www.khronos.org/registry/webgl/extensions/WEBGL_compressed_texture_s3tc/

No tests currently present to test WEBKIT_WEBGL_compressed_texture_s3tc.

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLCompressedTextureS3TC.cpp:

(WebCore::WebGLCompressedTextureS3TC::getName):

  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::getExtension):

7:28 PM Changeset in webkit [141845] by nayankk@motorola.com
  • 18 edits in trunk

[WEBGL] Rename WEBKIT_WEBGL_lose_context to WEBGL_lose_context.
https://bugs.webkit.org/show_bug.cgi?id=108694

Reviewed by Kenneth Russell.

WEBGL_lose_context is one of the community approved WebGL extension.
Hence remove the vendor prefix from WEBKIT_WEBGL_lose_context extension.
Spefication: http://www.khronos.org/registry/webgl/extensions/WEBGL_lose_context/

Source/WebCore:

Tests already exists, modified them to verify the change in extension name.

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toV8Object):

  • html/canvas/WebGLExtension.h:
  • html/canvas/WebGLLoseContext.cpp:

(WebCore::WebGLLoseContext::getName):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):
(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

LayoutTests:

  • fast/canvas/webgl/WebGLContextEvent.html:
  • fast/canvas/webgl/context-destroyed-crash.html:
  • fast/canvas/webgl/context-lost-expected.txt:
  • fast/canvas/webgl/context-lost-restored.html:
  • fast/canvas/webgl/context-lost.html:
  • platform/chromium-linux-x86/fast/canvas/webgl/context-lost-expected.txt:
  • platform/chromium-linux/fast/canvas/webgl/context-lost-expected.txt:
  • platform/chromium-mac/fast/canvas/webgl/context-lost-expected.txt:
  • platform/chromium-win-xp/fast/canvas/webgl/context-lost-expected.txt:
  • platform/chromium-win/fast/canvas/webgl/context-lost-expected.txt:
  • platform/chromium/platform/chromium/virtual/gpu/fast/canvas/webgl/context-lost-expected.txt:
6:57 PM Changeset in webkit [141844] by dino@apple.com
  • 4 edits in trunk/Source/WebCore

Default element styles are not always collected for sharing detection
https://bugs.webkit.org/show_bug.cgi?id=108404

Reviewed by Antti Koivisto.

The method ensureDefaultStyleSheetsForElement is run as we add elements
to the document. This may update the defaultStyle of the document, but
does not recollect any changes into the StyleResolver. This means that
style sharing might be overly ambitious, thinking it can share a style
for an element which was matched in the new rules. This showed up most
often in the Shadow Root for media elements, which would add a set of
style rules, but the shadow children would sometimes share styles even
when they shouldn't.

The fix is to detect if we need to collect after adding a
style for an element. This might cause a little more work, but
in my testing it doesn't happen very often.

Unfortunately it is hard to get a reproducible test for this.

  • css/CSSDefaultStyleSheets.cpp:

(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement): As we load in

styles, keep track of whether or not we change the default style.

  • css/CSSDefaultStyleSheets.h:

(CSSDefaultStyleSheets): New boolean parameter indicating if the style has changed.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForElement): Collect features if the element

caused the default style to update.

(WebCore::StyleResolver::collectFeatures): Protect for null in updates.

6:25 PM Changeset in webkit [141843] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the issue that some possible source formats are ignored for float textures in texture packing for CG port
https://bugs.webkit.org/show_bug.cgi?id=108812

Patch by Jun Jiang <jun.a.jiang@intel.com> on 2013-02-04
Reviewed by Kenneth Russell.

Already covered by latest WebGL conformance test.

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore):

6:12 PM Changeset in webkit [141842] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

[EFL] Remove needless local variables in LocalizedStringsEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=108869

Reviewed by Kentaro Hara.

fromUTF8() returns static String. So, we don't need to use needless local variables.

  • platform/efl/LocalizedStringsEfl.cpp:

(WebCore::contextMenuItemTagCopy):
(WebCore::contextMenuItemTagDelete):
(WebCore::contextMenuItemTagSelectAll):
(WebCore::contextMenuItemTagGoBack):
(WebCore::contextMenuItemTagGoForward):
(WebCore::contextMenuItemTagStop):
(WebCore::contextMenuItemTagCut):
(WebCore::contextMenuItemTagPaste):
(WebCore::contextMenuItemTagBold):
(WebCore::contextMenuItemTagItalic):
(WebCore::contextMenuItemTagUnderline):

6:11 PM Changeset in webkit [141841] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

WebGL: Move the format conversion for 16-bit per channel formats into Core Graphics port only
https://bugs.webkit.org/show_bug.cgi?id=108304

Patch by Jun Jiang <jun.a.jiang@intel.com> on 2013-02-04
Reviewed by Kenneth Russell.

Since the 16-bit per channel formats are only used for Core Graphics port in WebGL and not a standard to represent any file format that is widely used
for each platform, it is better to limit and hide this kinds of information and processing in CG specific code only.
It can make the code more clear and reduce the binary size for both CG port and non-CG port.

Already covered by current tests.

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore):

  • platform/graphics/GraphicsContext3D.h:

(GraphicsContext3D):
(WebCore::GraphicsContext3D::srcFormatComeFromDOMElementOrImageData):
(ImageExtractor):

  • platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore):
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

6:01 PM Changeset in webkit [141840] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

Allow TextTracks to be marked as closed captions
https://bugs.webkit.org/show_bug.cgi?id=108856

Reviewed by Darin Adler.

While this isn't exposed directly in markup, some platform media frameworks can
provide indication that a caption track is a closed caption. Expose such a flag
on TextTrack and platforms can show a different UI if they want to.

No tests - this isn't used elsewhere yet, nor exposed to the DOM.

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack): Initialise new member.

  • html/track/TextTrack.h:

(WebCore::TextTrack::isClosedCaptions): New member variable.
(WebCore::TextTrack::setIsClosedCaptions):

5:46 PM Changeset in webkit [141839] by jparent@chromium.org
  • 6 edits in trunk/Tools

Dashboard cleanup: Make builder a real dashboardSpecificParameter.
https://bugs.webkit.org/show_bug.cgi?id=108706

Reviewed by Dirk Pranke.

Add builder to g_defaultDashboardSpecificParameter maps for the
dashboards where it is used (flakiness, timeline, treemap).
Default it to null, and then update reads of it to check the
builder group's default if one is not set, rather than trying to
set and track this everywhere.
This allows us to remove tons of special-casing of builder parsing,
including where we used to add it to the query string even when the
user did not specify it.

  • TestResultServer/static-dashboards/dashboard_base.js:

(parseParameters):

  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(generatePage):
(handleQueryParameterChange):

  • TestResultServer/static-dashboards/loader.js:

(.):

  • TestResultServer/static-dashboards/timeline_explorer.html:
  • TestResultServer/static-dashboards/treemap.html:
5:30 PM Changeset in webkit [141838] by jparent@chromium.org
  • 2 edits in trunk/Tools

Setting tests on flakiness dashboard should invalidate builder.
https://bugs.webkit.org/show_bug.cgi?id=108521

Reviewed by Dirk Pranke.

When you move into a cross builder view, builder should not still be
set. Currently, it is deleted from the internal state, but still shows
up in the url, causing the current state and the hash to not match.

To see this in action, load the flakiness dashboard, select a builder,
and then click on an individual test, to get into individual test view.
The url will still have the builder you selected listed, even though it
is cleared in the UI.

The fix is to consider 'tests' to be a parameter that invalidates builder.

  • TestResultServer/static-dashboards/flakiness_dashboard.js:
5:27 PM Changeset in webkit [141837] by commit-queue@webkit.org
  • 34 edits
    1 add in trunk

Make moveCaretTowardsWindowPoint not snap to the beginning/end when moved above/below editable
https://bugs.webkit.org/show_bug.cgi?id=107850

Patch by Chris Hopman <cjhopman@chromium.org> on 2013-02-04
Reviewed by Ojan Vafai.

Source/WebCore:

On Android, EditingBehavior::shouldMoveCaret[...] controls the
behavior of insertion handles. This change adds a new Android specific
editing behavior type.

The new EditingBehavior is the same as EditingUnixBehavior except for
EditingBehavior::shouldMoveCaret[...]. This new behavior fixes
WebFrame::moveCaretTowardsWindowPoint to not span to the
beginning/end.

  • editing/EditingBehavior.h:

(WebCore::EditingBehavior::shouldMoveCaretToHorizontalBoundaryWhenPastTopOrBottom):
(WebCore::EditingBehavior::shouldAllowSpellingSuggestionsWithoutSelection):
(WebCore::EditingBehavior::shouldNavigateBackOnBackspace):

  • editing/EditingBehaviorTypes.h:
  • page/Settings.cpp:

(WebCore):
(WebCore::editingBehaviorTypeForPlatform):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setEditingBehavior):

Source/WebKit/chromium:

On Android, EditingBehavior::shouldMoveCaret[...] controls the
behavior of insertion handles. This change adds a new Android specific
editing behavior type so that we can change these settings independent
of behavior for other platforms.

  • public/WebSettings.h:
  • src/AssertMatchingEnums.cpp:

Just add the corresponding assertion for the new editing behavior.

  • public/WebSettings.h:
  • src/AssertMatchingEnums.cpp:
  • tests/WebFrameTest.cpp:
  • tests/data/move_caret.html: Added.

Add a test that moveCaretTowardsWindowPoint works as expected on
Android.

LayoutTests:

Test the new "android" editing behavior in the following tests:

  • editing/deleting/delete-ligature-003-expected.txt:
  • editing/deleting/delete-ligature-003.html:
  • editing/deleting/paragraph-in-preserveNewline-expected.txt:
  • editing/deleting/paragraph-in-preserveNewline.html:
  • editing/deleting/whitespace-pre-1-expected.txt:
  • editing/deleting/whitespace-pre-1.html:
  • editing/execCommand/script-tests/toggle-compound-styles.js:
  • editing/execCommand/toggle-compound-styles-expected.txt:
  • editing/selection/5354455-1-expected.txt:
  • editing/selection/5354455-1.html:
  • editing/selection/click-in-margins-inside-editable-div-expected.txt:
  • editing/selection/click-in-padding-with-multiple-line-boxes-expected.txt:
  • editing/selection/context-menu-text-selection-expected.txt:
  • editing/selection/context-menu-text-selection.html:
  • editing/selection/extend-after-mouse-selection-expected.txt:
  • editing/selection/extend-after-mouse-selection.html:
  • editing/selection/programmatic-selection-on-mac-is-directionless-expected.txt:
  • editing/selection/programmatic-selection-on-mac-is-directionless.html:
  • editing/selection/rtl-move-selection-right-left-expected.txt:
  • editing/selection/rtl-move-selection-right-left.html:
  • editing/selection/script-tests/click-in-margins-inside-editable-div.js:
  • editing/selection/script-tests/click-in-padding-with-multiple-line-boxes.js:
  • editing/selection/selection-extend-should-not-move-across-caret-on-mac-expected.txt:
  • editing/selection/selection-extend-should-not-move-across-caret-on-mac.html:
5:20 PM Changeset in webkit [141836] by kenneth@webkit.org
  • 16 edits
    2 adds in trunk

[EFL][WK2] Introduce a WebView class as counterpart for WKViewRef
https://bugs.webkit.org/show_bug.cgi?id=107931

Reviewed by Anders Carlsson.

Source/WebKit2:

This is just one step of the new plan for the EFL API.

The plan is to move the public EFL-like API on top of the shared
WK2 C API, plus a few EFL extensions (WKView class mostly).

The EFL-like API can be seen as a convenience API which ties
well into EFL and which makes it easy to add web experiences
to existing and new EFL applications. It provides a smart object
like API and a Evas_Object based view.

For more advanced use cases, such as browser and runtime, it is
possible to use the WK* C API, which is gives more flexibility
while being more low level.

The idea is that the WKView class will not depend on Evas_Object
and X11 (future plan) unlike the current EFL-like API. This should
make it possible to use it for cases where none of these are
available.

This patch introduces the WebView class which serves as our
counterpart for the WKView class, and adds a few needed methods.

The EwkView owns the WebView class (and will be constructing it
in the near future when the EwkView class has been changed to
handle all smart object related code)

The clean up of the smart object related code as the proper
construction of EwkView and WebView will be done in follow-up
patches.

  • UIProcess/API/C/efl/WKAPICastEfl.h:

(WebKit):

The WKView API is not based on WebView and not Evas_Object*

  • UIProcess/API/C/efl/WKView.cpp:

(WKViewCreate):
(WKViewCreateWithFixedLayout):
(WKViewInitialize):
(WKViewGetPage):
(WKViewSetThemePath):
(WKViewSuspendActiveDOMObjectsAndAnimations):
(WKViewResumeActiveDOMObjectsAndAnimations):
(WKViewGetEvasObject):
(WKViewCreateSnapshot):

Add a few new WKView EFL C methods, and update existing
methods to reflect that the WKViewRef is now a WebView*

The construction methods will be rewritten when the smart
object construction has been solved.

  • UIProcess/API/C/efl/WKView.h:
  • UIProcess/efl/WebView.cpp: Added.

(WebKit):
(WebKit::WebView::WebView):
(WebKit::WebView::~WebView):
(WebKit::WebView::initialize):
(WebKit::WebView::setThemePath):
(WebKit::WebView::suspendActiveDOMObjectsAndAnimations):
(WebKit::WebView::resumeActiveDOMObjectsAndAnimations):

  • UIProcess/efl/WebView.h: Added.

(WebKit):
(WebView):
(WebKit::WebView::pageRef):
(WebKit::WebView::evasObject):
(WebKit::WebView::page):
(WebKit::WebView::type):

Add a new WebKit::WebView class for EFL.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::~EwkView):
(EwkView::wkPage):
(EwkView::setThemePath):
(EwkView::createGLSurface):

Base methods on C API instead of internal API as much
as currently possible.

  • UIProcess/API/efl/EwkView.h:

(WebKit):
(WebView):
(EwkView):
(EwkView::wkView):
(EwkView::page):

  • UIProcess/API/efl/ewk_view.cpp:

(createEwkView):
(ewk_view_base_add):
(ewk_view_smart_add):

Modify to return the EwkView class for now.

  • UIProcess/API/efl/ewk_view_private.h:
  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

Updated due to changed API.

Tools:

Change platformView to be a WKView and use WKViewGetEvasObject
for the places where an Evas_Object is needed.

Instead of extracting the Ecore_Evas* from the m_view we use
the m_window instead, which actually holds the it.

  • TestWebKitAPI/PlatformWebView.h:
  • TestWebKitAPI/efl/PlatformWebView.cpp:

(TestWebKitAPI::PlatformWebView::PlatformWebView):
(TestWebKitAPI::PlatformWebView::~PlatformWebView):
(TestWebKitAPI::PlatformWebView::resizeTo):
(TestWebKitAPI::PlatformWebView::page):
(TestWebKitAPI::PlatformWebView::simulateSpacebarKeyPress):
(TestWebKitAPI::PlatformWebView::simulateMouseMove):
(TestWebKitAPI::PlatformWebView::simulateRightClick):

  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/efl/EventSenderProxyEfl.cpp:

(WTR::EventSenderProxy::sendTouchEvent):
(WTR::EventSenderProxy::setTouchModifier):

  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::~PlatformWebView):
(WTR::PlatformWebView::resizeTo):
(WTR::PlatformWebView::page):
(WTR::PlatformWebView::focus):
(WTR::PlatformWebView::windowFrame):
(WTR::PlatformWebView::setWindowFrame):
(WTR::PlatformWebView::windowSnapshotImage):

5:17 PM Changeset in webkit [141835] by tkent@chromium.org
  • 13 edits
    2 adds in trunk

INPUT_MULTIPLE_FIELDS_UI: Focus order is not controllable by tabIndex attribute on <input>
https://bugs.webkit.org/show_bug.cgi?id=108447

Reviewed by Hajime Morita.

Source/WebCore:

We make <input> elements with the multiple-fields UI focusable.

  • However, we don't want to change the existing focus behavior for multiple-fields <input>. We'd like to focus on the last sub-field of an<input> with Shift + TAB focus navigation, and focus on the first sub-field of the <input> otherwise. So, we move focus immediately after the <input> gets focus.
  • We don't need the isFocusableByClickOnLabel hack any more. <input> elements with the multiple-fields UI are mouse-focusable.

Test: fast/forms/time-multiple-fields/time-multiple-fields-tabindex.html

  • html/InputType.h:

(InputType): Add FocusDirection argument to handleFocusEvent, and remove
unnecessary isFocusableByClickOnLabel and focus.

  • html/InputType.cpp:

(WebCore::InputType::handleFocusEvent): Ditto.

  • html/PasswordInputType.cpp:

(WebCore::PasswordInputType::handleFocusEvent): Follow the argument change.

  • html/PasswordInputType.h:

(PasswordInputType): Ditto.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::handleFocusEvent):
If this element gets focus by FocusDirectionBackward (it means the focus
is moved from the first sub-field of the element,) move the focus
backward once more. Otherwise, we focus on the first sub-filed of the
element.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isKeyboardFocusable):
Make this keyboard-focusable. We have a wrong test to ensure read-only
input does NOT get focus. We'll address it later.
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isMouseFocusable):
Make this mouse-focusable.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType):

  • html/HTMLInputElement.h:

(HTMLInputElement): Remove defaultFocus, focus, and isFocusableByClickOnLabel.
Add missing OVERRIDE to handleFocusEvent.

  • html/HTMLInputElement.cpp: Remove unnecessary functions.

(WebCore::HTMLInputElement::handleFocusEvent):
Pass FocusDirection value to InputTYpe::handleFocusEvent.

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::defaultEventHandler):
Use isMouseFocusable().

  • html/HTMLElement.cpp: Remove unnecessary isFocusableByClickOnLabel.
  • html/HTMLElement.h: Ditto.

LayoutTests:

  • fast/forms/time-multiple-fields/time-multiple-fields-tabindex-expected.txt: Added.
  • fast/forms/time-multiple-fields/time-multiple-fields-tabindex.html: Added.
5:13 PM Changeset in webkit [141834] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Set up the storage manager as a connection queue
https://bugs.webkit.org/show_bug.cgi?id=108879

Reviewed by Sam Weinig.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::processWillOpenConnection):
Add the storage manager as a connection queue client.

(WebKit::StorageManager::processWillCloseConnection):
Remove the storage manager.

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::processWillOpenConnection):
Call the storage manager.

(WebKit::WebContext::processWillCloseConnection):
Call the storage manager.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::connectionWillOpen):
Call the context.

(WebKit::WebProcessProxy::connectionWillClose):
Call the context.

(WebKit::WebProcessProxy::didFinishLaunching):
Remove a comment.

4:54 PM Changeset in webkit [141833] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Coordinated Graphics: crash in TiledBackingStore::adjustForContentsRect
https://bugs.webkit.org/show_bug.cgi?id=107639

Patch by Seulgi Kim <seulgikim@company100.net> on 2013-02-04
Reviewed by Kenneth Rohde Christiansen.

In TiledBackingStore::adjustForContentsRect method, inflating is not
needed when there is no intersections between the cover/keep rect and
the content rect.

No new tests, no change in functionality.

  • platform/graphics/TiledBackingStore.cpp:

(WebCore::TiledBackingStore::adjustForContentsRect):

4:46 PM Changeset in webkit [141832] by senorblanco@chromium.org
  • 3 edits in trunk/Source/WebCore

[skia] Remove use of SkSingleInputImageFilter.
https://bugs.webkit.org/show_bug.cgi?id=108867

Reviewed by James Robinson.

This class is but a hollow shell of its former self, and has
been removed in Skia.

Covered by existing tests in css3/filters.

  • platform/graphics/filters/skia/DropShadowImageFilter.cpp:

(WebCore::DropShadowImageFilter::DropShadowImageFilter):
(WebCore::DropShadowImageFilter::onFilterImage):

  • platform/graphics/filters/skia/DropShadowImageFilter.h:
4:39 PM Changeset in webkit [141831] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION (r129478-r129480): http/tests/loading/text-content-type-with-binary-extension.html failing on Apple MountainLion Debug WK2 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=98527

The bug was fixed but the test was never removed from the Mac WK2 TestExpectations file.
Remove it now.

  • platform/mac-wk2/TestExpectations:
4:34 PM Changeset in webkit [141830] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Send message when creating and destroying StorageAreaProxy objects
https://bugs.webkit.org/show_bug.cgi?id=108874

Reviewed by Sam Weinig.

  • Shared/SecurityOriginData.cpp:

(WebKit::SecurityOriginData::fromSecurityOrigin):

  • Shared/SecurityOriginData.h:

(SecurityOriginData):
Add helper function for creating a SecurityOriginData object given a WebCore::SecurityOrigin object.

  • WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::generateStorageAreaID):
New function to create a unique storage area ID.

(WebKit::StorageAreaProxy::StorageAreaProxy):
Send a CreateStorageArea message.

(WebKit::StorageAreaProxy::~StorageAreaProxy):
Send a DestroyStorageArea message.

(WebKit::StorageAreaProxy::contains):
Remove this assertion for now, it fires too often.

  • WebProcess/Storage/StorageNamespaceProxy.h:

(WebKit::StorageNamespaceProxy::storageNamespaceID):
Add getter.

4:30 PM Changeset in webkit [141829] by commit-queue@webkit.org
  • 7 edits in trunk/Tools

Don't update author info in PrepareChangeLog and allow users to skip the PrepareChangeLog step entirely.
https://bugs.webkit.org/show_bug.cgi?id=108788

Patch by Timothy Loh <timloh@chromium.com> on 2013-02-04
Reviewed by Ryosuke Niwa.

As per discussion in Bug 74358, it's probably preferable to remove the
behaviour of updating the author details in a ChangeLog entry. We also
want to be able to skip preparing change logs (e.g. rebaselining many
tests), so a --no-prepare-changelogs option is added to webkit-patch.

  • Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLogEntry._parse_entry):
(ChangeLogEntry.date): Added

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:

(test_parse_log_entries_from_changelog):

  • Scripts/webkitpy/tool/commands/commandtest.py:

(CommandsTest.assert_execute_outputs):

  • Scripts/webkitpy/tool/steps/options.py:

(Options): Added --no-prepare-changelogs

  • Scripts/webkitpy/tool/steps/preparechangelog.py:

(PrepareChangeLog.options):
(PrepareChangeLog._merge_entries): date_line() gets the entire line, including
the author's name and email, but we only want to replace the date.
(PrepareChangeLog.run):

  • Scripts/webkitpy/tool/steps/preparechangelog_unittest.py:

(PrepareChangeLogTest.test_resolve_existing_entry): Added tests for changed
authors. Removed unneeded variable.

4:28 PM Changeset in webkit [141828] by dpranke@chromium.org
  • 2 edits in trunk/LayoutTests

[ Linux ] Mark media/track/track-cues-cuechange.html and media/track/track-cues-enter-exit.html as slow
https://bugs.webkit.org/show_bug.cgi?id=108876

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-04
Reviewed by Dirk Pranke.

Tests take ~5.4 seconds to run locally.
Timing out on the EWS bots but passing on the Webkit buildbots.
Marked tests as slow in TestExpectations.

  • platform/chromium/TestExpectations:
3:57 PM Changeset in webkit [141827] by kenneth@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][WK2] Use C API inside EwkView
https://bugs.webkit.org/show_bug.cgi?id=108825

Reviewed by Anders Carlsson.

A straight-forward port towards the C API.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView): Use C API for common default preferences.
(EwkView::wkPage): Make it const and remove useless comment.
(EwkView::deviceScaleFactor):
(EwkView::title):
(EwkView::customTextEncodingName):
(EwkView::setCustomTextEncodingName):
(EwkView::informURLChange):

  • UIProcess/API/efl/EwkView.h:

(EwkView):

3:55 PM Changeset in webkit [141826] by haraken@chromium.org
  • 10 edits in trunk

Implement WheelEvent::deltaMode
https://bugs.webkit.org/show_bug.cgi?id=108455

Reviewed by Adam Barth.

Source/WebCore:

Per the spec, WheelEvent::deltaMode should return
DOM_DELTA_PIXEL or DOM_DELTA_LINE or DOM_DELTA_PAGE.

Spec: http://www.w3.org/TR/DOM-Level-3-Events/#events-wheelevents
https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-wheelevent

Test: fast/event/wheel-event-constructor.html

  • dom/WheelEvent.cpp:

(WebCore::WheelEventInit::WheelEventInit):
(WebCore::WheelEvent::WheelEvent):
(WebCore::WheelEvent::initWheelEvent):
(WebCore::deltaMode):

  • dom/WheelEvent.h:

(WheelEventInit):
(WebCore::WheelEvent::create):
(WebCore::WheelEvent::deltaMode):
(WheelEvent):

  • dom/WheelEvent.idl:
  • page/EventHandler.cpp:

(WebCore::wheelGranularityToScrollGranularity):

Source/WebKit/chromium:

  • src/WebInputEventConversion.cpp:

(WebKit::WebMouseWheelEventBuilder::WebMouseWheelEventBuilder):

LayoutTests:

Per the spec, WheelEvent::deltaMode should return
DOM_DELTA_PIXEL or DOM_DELTA_LINE or DOM_DELTA_PAGE.

Spec: http://www.w3.org/TR/DOM-Level-3-Events/#events-wheelevents
https://dvcs.w3.org/hg/d4e/raw-file/tip/source_respec.htm#constructor-wheelevent

  • fast/events/constructors/wheel-event-constructor-expected.txt:
  • fast/events/constructors/wheel-event-constructor.html:
3:54 PM Changeset in webkit [141825] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove an unnecessary sandbox rule.

Reviewed by Sam Weinig.

  • WebProcess/com.apple.WebProcess.sb.in: We already have a file-read rule for /Library/Managed Preferences, no need for another rule for something inside it.
3:24 PM Changeset in webkit [141824] by beidson@apple.com
  • 5 edits in trunk/Source/WebKit2

WebProcess crashes handling repeated NetworkProcess crashes.
<rdar://problem/13049867> and https://bugs.webkit.org/show_bug.cgi?id=108861

Reviewed by Alexey Proskuryakov.

  • Rename the concept of "unschedulable loader" to "internally failed loader"
  • When the NetworkProcess crashes, add all outstanding ResourceLoaders into the unschedulable pile.
  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::WebResourceLoadScheduler):
(WebKit::WebResourceLoadScheduler::scheduleLoad):
(WebKit::WebResourceLoadScheduler::scheduleInternallyFailedLoad):
(WebKit::WebResourceLoadScheduler::internallyFailedLoadTimerFired):
(WebKit::WebResourceLoadScheduler::remove): Also remove a non-helpful, out of date comment.
(WebKit::WebResourceLoadScheduler::networkProcessCrashed):

  • WebProcess/Network/WebResourceLoadScheduler.h:

WebResourceLoader no longer responds to crashes directly, but now exposes its WebCore ResourceLoader:

  • WebProcess/Network/WebResourceLoader.cpp:
  • WebProcess/Network/WebResourceLoader.h:

(WebKit::WebResourceLoader::resourceLoader):

3:23 PM Changeset in webkit [141823] by jochen@chromium.org
  • 14 edits
    5 deletes in trunk/Tools

[chromium] Remove WebEventSender and WebAccessibilityController from public TestRunner API
https://bugs.webkit.org/show_bug.cgi?id=108467

Reviewed by Adam Barth.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebAccessibilityController.h: Removed.
  • DumpRenderTree/chromium/TestRunner/public/WebEventSender.h: Removed.
  • DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebTestRunner):
(WebTestInterfaces):

  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebTestRunner):
(WebTestProxyBase):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):
(WebTestRunner::TestInterfaces::setWebView):
(WebTestRunner::TestInterfaces::webView):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebAccessibilityController.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/WebEventSender.cpp: Removed.
  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::~WebTestInterfaces):
(WebTestRunner::WebTestInterfaces::setWebView):
(WebTestRunner::WebTestInterfaces::setDelegate):
(WebTestRunner::WebTestInterfaces::bindTo):
(WebTestRunner::WebTestInterfaces::resetAll):
(WebTestRunner::WebTestInterfaces::setTestIsRunning):
(WebTestRunner::WebTestInterfaces::webView):
(WebTestRunner::WebTestInterfaces::testRunner):
(WebTestRunner::WebTestInterfaces::testInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::setInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp: Removed.
  • DumpRenderTree/chromium/TestShell.h:
  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:
3:19 PM Changeset in webkit [141822] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore

[Soup] Remove duplicate setting of first party for cookies
https://bugs.webkit.org/show_bug.cgi?id=108814

Reviewed by Martin Robinson.

Covered by existing tests.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::createSoupMessageForHandleAndRequest): there is no need to set
the first party for cookies here, since that is already done in
ResourceRequest::updateSoupMessage, which is called a few lines before.

3:18 PM Changeset in webkit [141821] by kov@webkit.org
  • 7 edits in trunk/Source/WebCore

[GStreamer][Soup] Let GStreamer provide the buffer data is downloaded to, to avoid copying
https://bugs.webkit.org/show_bug.cgi?id=105552

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-02-04
Reviewed by Philippe Normand.

Makes it possible for the GStreamer media backend to provide the buffer to which
the Soup networking backend will use to download data to. This makes copying
memory unnecessary when ResourceHandle hands data over to the media player's
StreamingClient. Thanks to Dan Winship for help designing the interface.

No behaviour change, covered by existing tests.

  • platform/graphics/gstreamer/GStreamerVersioning.cpp:

(createGstBufferForData): New helper to create a GstBuffer when
we have a data pointer and a length.
(getGstBufferSize): Abstract obtaining the size of the buffer, so the code
is cleaner while still working for both GST 0.10 and 1.0.
(setGstBufferSize): Ditto, but for setting the size.
(getGstBufferDataPointer): Ditto, but for grabbing the data pointer.
(mapGstBuffer): Convenience method to take care of mapping the buffer so that
we can provide the data pointer to ResourceHandle.
(unmapGstBuffer): Convenience method which takes care of unmapping the buffer
and properly freeing the GstMapInfo.

  • platform/graphics/gstreamer/GStreamerVersioning.h:
  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient): New methods.
(_WebKitWebSrcPrivate): We now store the GstBuffer we provided the data pointer from
so we can later unmap it and push it to the pipeline.
(webKitWebSrcDispose): Deal with the GstBuffer in case it exists when the source is
destroyed.
(webKitWebSrcStop): Also clear the GstBuffer in this case.
(StreamingClient::didReceiveData): Handle the hand-over of the buffer.
(StreamingClient::getBuffer): Provide ResourceHandle with a new GstBuffer's data pointer.

  • platform/network/ResourceHandleClient.h:

(ResourceHandleClient):
(WebCore::ResourceHandleClient::ResourceHandleClient): Constructor to initialize the buffer
member variable to 0.
(WebCore::ResourceHandleClient::~ResourceHandleClient): Destructor to free the buffer if it
has been allocated.
(WebCore::ResourceHandleClient::getBuffer): Default implementation which returns a
newly allocated char pointer.

  • platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(ResourceHandleInternal): Store actual buffer size, which is no longer a constant.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::cleanupSoupRequestOperation): Clear the buffer pointer, the life-cycle of the
buffer is handled by the ResourceHandleClient.
(WebCore::nextMultipartResponsePartCallback): Get a new buffer from the client before reading.
(WebCore::sendRequestCallback): Ditto.
(WebCore::readCallback): Ditto.

3:07 PM Changeset in webkit [141820] by andersca@apple.com
  • 15 edits in trunk/Source/WebKit2

Update message generation to use the new queue client semantics
https://bugs.webkit.org/show_bug.cgi?id=108865

Reviewed by Andreas Kling.

  • Scripts/webkit2/messages.py:

(connection_work_queue_message_statement):
(async_message_statement):
(generate_message_handler):

  • Scripts/webkit2/messages_unittest.py:
  • Shared/mac/SecItemShim.cpp:

(WebKit::SecItemShim::didReceiveMessageOnConnectionWorkQueue):

  • Shared/mac/SecItemShim.h:

(SecItemShim):

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::didReceiveMessageOnConnectionWorkQueue):

  • UIProcess/Storage/StorageManager.h:

(StorageManager):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessageOnConnectionWorkQueue):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

  • UIProcess/mac/SecItemShimProxy.cpp:

(WebKit::SecItemShimProxy::didReceiveMessageOnConnectionWorkQueue):

  • UIProcess/mac/SecItemShimProxy.h:

(SecItemShimProxy):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::didReceiveMessageOnConnectionWorkQueue):

  • WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessageOnConnectionWorkQueue):

  • WebProcess/WebProcess.h:

(WebProcess):

3:01 PM Changeset in webkit [141819] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Build fix for AtomicString on iOS

Unreviewed. The commit r141812 rely on isUIThread(), there is no such things
in the tree right now. Use pthread_main_np() until more thread handling is upstreamed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-04

  • wtf/text/AtomicString.cpp:

(WTF::AtomicStringTable::create):

2:49 PM Changeset in webkit [141818] by pilgrim@chromium.org
  • 6 edits
    1 move
    2 adds in trunk/Source

[Chromium] Move WorkerContextProxy to WebCore
https://bugs.webkit.org/show_bug.cgi?id=108847

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 106829.

Source/WebCore:

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:
  • workers/chromium: Added.
  • workers/chromium/WorkerContextProxyChromium.cpp: Added.

(WebCore):
(WebCore::setWorkerContextProxyCreateFunction):
(WebCore::WorkerContextProxy::create):

  • workers/chromium/WorkerContextProxyChromium.h: Added.

(WebCore):

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/WebKit.cpp:

(WebKit::initializeWithoutV8):

  • src/WorkerContextProxy.cpp: Removed.
2:39 PM Changeset in webkit [141817] by commit-queue@webkit.org
  • 3 edits
    3 adds in trunk

WebVTT <i>, <b> and <u> elements should have default styles
https://bugs.webkit.org/show_bug.cgi?id=107214

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-04
Reviewed by Darin Adler.

Source/WebCore:

Added default styles for basic webvtt object types.

Test: media/track/track-css-matching-default.html

  • css/mediaControls.css:

(video::-webkit-media-text-track-container b):
(video::-webkit-media-text-track-container u):
(video::-webkit-media-text-track-container i):

LayoutTests:

  • media/track/captions-webvtt/styling-default.vtt: Added.
  • media/track/track-css-matching-default-expected.txt: Added.
  • media/track/track-css-matching-default.html: Added.
2:36 PM Changeset in webkit [141816] by inferno@chromium.org
  • 47 edits in trunk/Source

Add ASSERT_WITH_SECURITY_IMPLICATION to detect out of bounds access
https://bugs.webkit.org/show_bug.cgi?id=108668

Reviewed by Eric Seidel.

Source/WebCore:

  • bindings/v8/SerializedScriptValue.cpp:
  • css/CSSCalculationValue.cpp:

(WebCore::CSSCalcExpressionNodeParser::parseCalc):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::fillImageSet):
(WebCore::CSSImageSetValue::customCssText):

  • css/CSSParserValues.h:

(WebCore::CSSParserString::operator[]):

  • css/CSSValueList.h:

(WebCore::CSSValueListInspector::item):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::ruleAt):
(WebCore::StyleSheetContents::wrapperInsertRule):
(WebCore::StyleSheetContents::wrapperDeleteRule):

  • dom/Document.cpp:

(WebCore::Document::processArguments):

  • dom/Element.cpp:

(WebCore::Element::removeAttributeInternal):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::removeAttribute):

  • dom/ElementAttributeData.h:

(WebCore::ElementAttributeData::attributeItem):

  • dom/SpaceSplitString.h:

(WebCore::SpaceSplitStringData::operator[]):
(WebCore::SpaceSplitString::operator[]):

  • editing/TextIterator.cpp:

(WebCore::TextIterator::characterAt):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::removeFormElement):

  • html/HTMLSelectElementWin.cpp:

(WebCore::HTMLSelectElement::platformHandleKeydownEvent):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore):

  • html/parser/HTMLFormattingElementList.cpp:

(WebCore::HTMLFormattingElementList::swapTo):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::styleSheetTextWithChangedStyle):

  • inspector/InspectorStyleTextEditor.cpp:

(WebCore::InspectorStyleTextEditor::replaceProperty):

  • inspector/InspectorValues.cpp:

(WebCore::InspectorArrayBase::get):

  • page/WindowFeatures.cpp:

(WebCore::WindowFeatures::WindowFeatures):

  • platform/audio/AudioArray.h:

(WebCore::AudioArray::at):

  • platform/audio/AudioFIFO.cpp:

(WebCore::AudioFIFO::findWrapLengths):

  • platform/graphics/GlyphPage.h:

(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::glyphAt):
(WebCore::GlyphPage::setGlyphDataForIndex):

  • platform/graphics/TextRun.h:

(WebCore::TextRun::operator[]):
(WebCore::TextRun::data8):
(WebCore::TextRun::data16):

  • platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::setDrawRange):

  • platform/graphics/openvg/TiledImageOpenVG.cpp:

(WebCore::TiledImageOpenVG::setTile):
(WebCore::TiledImageOpenVG::tile):

  • platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::decodeAtIndex):
(WebCore::ICOImageDecoder::imageTypeAtIndex):

  • platform/text/QuotedPrintable.cpp:

(WebCore::lengthOfLineEndingAtIndex):

  • platform/text/SegmentedString.cpp:

(WebCore::SegmentedString::advance):

  • platform/win/WebCoreTextRenderer.cpp:

(WebCore::doDrawTextAtPoint):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):

Source/WebKit/chromium:

  • src/ContextFeaturesClientImpl.cpp:

(WebKit::ContextFeaturesCache::entryFor):

  • src/WebFrameImpl.cpp:

(WebKit::WebFrameImpl::selectFindMatch):

Source/WebKit2:

  • Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::HandleArray::operator[]):

Source/WTF:

  • wtf/AVLTree.h:

(WTF::AVLTreeDefaultBSet::operator[]):

  • wtf/BitArray.h:

(WTF::BitArray::set):
(WTF::BitArray::get):

  • wtf/FastBitVector.h:

(WTF::FastBitVector::set):
(WTF::FastBitVector::clear):
(WTF::FastBitVector::get):

  • wtf/FixedArray.h:

(WTF::FixedArray::operator[]):

  • wtf/RefCountedArray.h:

(WTF::RefCountedArray::at):

  • wtf/TypedArrayBase.h:

(WTF::TypedArrayBase::item):

  • wtf/text/StringBuffer.h:

(WTF::StringBuffer::operator[]):

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::operator[]):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::operator[]):

2:35 PM Changeset in webkit [141815] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r141809.
http://trac.webkit.org/changeset/141809
https://bugs.webkit.org/show_bug.cgi?id=108860

ARC isn't supported on 32-bit. (Requested by mhahnenberg on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-04

  • API/tests/testapi.mm:

(+[TestObject testObject]):
(testObjectiveCAPI):

2:33 PM Changeset in webkit [141814] by andersca@apple.com
  • 15 edits in trunk/Source/WebKit2

Change didReceiveMessageOnConnectionWorkQueue semantics
https://bugs.webkit.org/show_bug.cgi?id=108859

Reviewed by Sam Weinig.

Change didReceiveMessageOnConnectionWorkQueue to take a reference to an
OwnPtr<MessageDecoder>. This lets queue clients handle a message later, on a different
work queue for example. Also, get rid of the didHandleMessage boolean, since taking ownership
of the decoder implicitly means that the message was handled.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::processIncomingMessage):

  • Platform/CoreIPC/Connection.h:

(QueueClient):

  • Shared/mac/SecItemShim.cpp:

(WebKit::SecItemShim::didReceiveMessageOnConnectionWorkQueue):

  • Shared/mac/SecItemShim.h:

(SecItemShim):

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::StorageManager):
(WebKit::StorageManager::didReceiveMessageOnConnectionWorkQueue):

  • UIProcess/Storage/StorageManager.h:

(WebKit):
(StorageManager):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didReceiveMessageOnConnectionWorkQueue):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

  • UIProcess/mac/SecItemShimProxy.cpp:

(WebKit::SecItemShimProxy::didReceiveMessageOnConnectionWorkQueue):

  • UIProcess/mac/SecItemShimProxy.h:

(SecItemShimProxy):

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::didReceiveMessageOnConnectionWorkQueue):

  • WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didReceiveMessageOnConnectionWorkQueue):

  • WebProcess/WebProcess.h:

(WebProcess):

2:28 PM Changeset in webkit [141813] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/12884778> Sandbox violation due to MediaAccessibility code trying to access ~/Library/Preferences/com.apple.mediaaccessibility.plist

Reviewed by Sam Weinig.

  • WebProcess/com.apple.WebProcess.sb.in:
2:20 PM Changeset in webkit [141812] by benjamin@webkit.org
  • 3 edits in trunk/Source/WTF

Upstream iOS's AtomicString
https://bugs.webkit.org/show_bug.cgi?id=108139

Reviewed by David Kilzer.

On iOS, WebCore can be executed from two different threads. To maintain consistency,
a few changes had been made:
-The main UI thread and the WebThread share the same AtomicStringTable.
-A spin lock is needed before any access to prevent any concurrent modification of the string table.

The spin lock also prevent race on the static initialization of the shared table.

  • wtf/Platform.h:

Introduce a new USE(WEB_THREAD) to scope changes related to iOS Web Thread.

  • wtf/text/AtomicString.cpp:

(AtomicStringTableLocker):
(WTF::AtomicStringTableLocker::AtomicStringTableLocker):
(WTF::AtomicStringTableLocker::~AtomicStringTableLocker):
(WTF::AtomicStringTable::create):
wtfThreadData() is not necessarily inlined on ARM. When it is not inlined, the old code
causes two call to the function. Instead, we can keep the value in register and pass it
to AtomicStringTable::create().
(WTF::stringTable):
(WTF::addToStringTable):
(WTF::AtomicString::addSlowCase):
(WTF::AtomicString::find):
(WTF::AtomicString::remove):

2:19 PM Changeset in webkit [141811] by Nate Chapin
  • 2 edits in trunk/Source/WebCore

REGRESSION (r137607): Loading of archives as substitute data is broken
https://bugs.webkit.org/show_bug.cgi?id=108589

Reviewed by Alexey Proskuryakov.

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::resourceData): Return the content from

SubstituteData as mainResourceData if present.

2:18 PM Changeset in webkit [141810] by jchaffraix@webkit.org
  • 3 edits
    2 adds in trunk

[CSS Grid Layout] Heap-buffer-overflow in std::sort
https://bugs.webkit.org/show_bug.cgi?id=108834

Reviewed by Abhishek Arya.

Source/WebCore:

Test: fast/css-grid-layout/grid-strict-ordering-crash.html

  • rendering/RenderGrid.cpp:

(WebCore::sortByGridTrackGrowthPotential):
The std::sort documentation says that this function should define a *strict* weak ordering. Fixed the strict
part of the ordering. Also moved the function definition next to where it is needed and made the GridTrack
argument const (as it shouldn't modify them or std::sort will misbehave).

  • rendering/RenderGrid.cpp:

(WebCore::sortByGridTrackGrowthPotential):
(WebCore):

LayoutTests:

  • fast/css-grid-layout/grid-strict-ordering-crash-expected.txt: Added.
  • fast/css-grid-layout/grid-strict-ordering-crash.html: Added.

The test requires a column / row index above the Vector inline capacity to work (which is currently 16).
The values are much higher in case we decide to bump the inline capacity.

2:13 PM Changeset in webkit [141809] by mhahnenberg@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Objective-C API: testapi.mm should use ARC
https://bugs.webkit.org/show_bug.cgi?id=107838

Reviewed by Oliver Hunt.

In ToT testapi.mm uses the Obj-C garbage collector, which hides a lot of our object lifetime bugs.
We should enable ARC, since that is what most of our clients will be using.

  • API/tests/testapi.mm:

(-[TestObject init]):
(-[TestObject dealloc]):
(+[TestObject testObject]):
(testObjectiveCAPI):

2:02 PM Changeset in webkit [141808] by Bruno de Oliveira Abinader
  • 2 edits in trunk/Tools

[EFL] Add "full screen" parameter to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=108850

Reviewed by Antonio Gomes.

Implements the {-F,--full-screen}={true,false} parameter to WebKit EFL's
MiniBrowser.

  • MiniBrowser/efl/main.c:

(window_create):
(elm_main):
Added '-F/--full-screen' parameter functionality.

1:49 PM Changeset in webkit [141807] by igor.o@sisa.samsung.com
  • 2 edits in trunk/Source/WebCore

[Texmap] Implement BGRA swizzling detection
https://bugs.webkit.org/show_bug.cgi?id=81103

For OpenGLES if the extension EXT_texture_format_BGRA8888 is supported
the internal and external formats need to be BGRA.

Reviewed by Noam Rosenthal.

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore):
(WebCore::driverSupportsExternalTextureBGRA):
(WebCore::driverSupportsSubImage):
(WebCore::BitmapTextureGL::didReset):

1:45 PM Changeset in webkit [141806] by commit-queue@webkit.org
  • 5 edits in trunk

class="cue" is getting some default style
https://bugs.webkit.org/show_bug.cgi?id=108752

Source/WebCore:

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-04
Reviewed by Dean Jackson.

The value variable inside the selector is used to store different information depending on the
type of the selector so we have to check explicitly that the selector we apply filtering to
matches a pseudo element.

Existing tests modified to cover this case.

  • css/RuleSet.cpp:

(WebCore::determinePropertyWhitelistType):

LayoutTests:

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-04
Reviewed by Dean Jackson.

  • media/track/track-css-property-whitelist-expected.txt:
  • media/track/track-css-property-whitelist.html:
1:37 PM Changeset in webkit [141805] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Objective-C API: ObjCCallbackFunction should retain the target of its NSInvocation
https://bugs.webkit.org/show_bug.cgi?id=108843

Reviewed by Darin Adler.

Currently, ObjCCallbackFunction doesn't retain the target of its NSInvocation. It needs to do
this to prevent crashes when trying to invoke a callback later on.

  • API/ObjCCallbackFunction.mm:

(ObjCCallbackFunction::ObjCCallbackFunction):
(ObjCCallbackFunction::~ObjCCallbackFunction):

1:34 PM Changeset in webkit [141804] by andersca@apple.com
  • 15 edits in trunk/Source/WebKit2

Add didCloseOnConnectionWorkQueue to Connection::QueueClient
https://bugs.webkit.org/show_bug.cgi?id=108853

Reviewed by Andreas Kling.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::connectionDidClose):

  • Platform/CoreIPC/Connection.h:

(QueueClient):

  • Shared/mac/SecItemShim.cpp:

(WebKit::SecItemShim::didCloseOnConnectionWorkQueue):

  • Shared/mac/SecItemShim.h:

(SecItemShim):

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::didCloseOnConnectionWorkQueue):
(WebKit):

  • UIProcess/Storage/StorageManager.h:

(StorageManager):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::didCloseOnConnectionWorkQueue):
(WebKit):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

  • UIProcess/mac/SecItemShimProxy.cpp:

(WebKit::SecItemShimProxy::didCloseOnConnectionWorkQueue):

  • UIProcess/mac/SecItemShimProxy.h:

(SecItemShimProxy):

  • WebProcess/WebPage/EventDispatcher.cpp:

(WebKit::EventDispatcher::didCloseOnConnectionWorkQueue):
(WebKit):

  • WebProcess/WebPage/EventDispatcher.h:

(EventDispatcher):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::didCloseOnConnectionWorkQueue):
(WebKit):

  • WebProcess/WebProcess.h:

(WebProcess):

1:31 PM Changeset in webkit [141803] by tsepez@chromium.org
  • 2 edits in trunk/Source/WebCore

[V8] Binding Integrity crash in V8HTMLEmbedElement::createWrapper
https://bugs.webkit.org/show_bug.cgi?id=108841

Reviewed by Adam Barth.

  • html/HTMLEmbedElement.idl:

Quick change to IDL to disable binding check for now.

1:29 PM Changeset in webkit [141802] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

[WK2] [Mac] Support drag in mouse events for WebKit2 EventSender
https://bugs.webkit.org/show_bug.cgi?id=68552

Skip another test that depends on setting eventSender.dragMode.

  • platform/wk2/TestExpectations:
1:29 PM Changeset in webkit [141801] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

Out-of-view check of fixed position element in frame might still be incorrect on Mac when
page is scaled
https://bugs.webkit.org/show_bug.cgi?id=105049

These tests have started passing all the time on all the Lion and Mountain Lion Debug and
Release WK1 and WK2 testers. Remove the failing expectation.

  • platform/mac/TestExpectations:
1:28 PM Changeset in webkit [141800] by mrobinson@webkit.org
  • 9 edits in trunk/Source

Fix GTK+ 'make dist' in preparation for the 1.11.5 release.

Source/JavaScriptCore:

  • GNUmakefile.list.am: Update the source lists.

Source/WebCore:

  • GNUmakefile.list.am:

Source/WebKit2:

  • GNUmakefile.am:
  • GNUmakefile.list.am:

Source/WTF:

  • GNUmakefile.list.am:
1:22 PM Changeset in webkit [141799] by enrica@apple.com
  • 11 edits in trunk/Source

Add specific EditActions for Bold and Italic commands.
https://bugs.webkit.org/show_bug.cgi?id=108842.
<rdar://problem/13098252>

Source/WebCore:

This change is required on iOS where we need to
identify the command in order to display the correct
message in the undo popup. It is also in line with
what we do for underline, which already has its own
separate EditAction.

Reviewed by Ryosuke Niwa.

No new tests. No behavior change.

  • editing/EditAction.h:
  • editing/EditorCommand.cpp:

(WebCore::executeToggleBold):
(WebCore::executeToggleItalic):

Source/WebKit/mac:

Reviewed by Ryosuke Niwa.

  • WebCoreSupport/WebEditorClient.mm:

(undoNameForEditAction):

Source/WebKit/qt:

Reviewed by Ryosuke Niwa.

  • WebCoreSupport/UndoStepQt.cpp:

(undoNameForEditAction):

Source/WebKit/win:

Reviewed by Ryosuke Niwa.

  • WebCoreSupport/WebEditorClient.cpp:

(undoNameForEditAction):

Source/WebKit2:

Reviewed by Ryosuke Niwa.

  • UIProcess/WebEditCommandProxy.cpp:

(WebKit::WebEditCommandProxy::nameForEditAction):

1:15 PM Changeset in webkit [141798] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1364

Merge 141127
BUG=172814
Review URL: https://codereview.chromium.org/12183027

1:12 PM Changeset in webkit [141797] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry]Adjust fatfinger detection rect size
https://bugs.webkit.org/show_bug.cgi?id=108678

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-02-04
Reviewed by Antonio Gomes.
RIM Bug 246976

We still need to clip the fatfinger detection rect to the viewport to
avoid wrong hitTest result.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::mouseEvent):

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::getNodesFromRect):

1:11 PM Changeset in webkit [141796] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Use a separate queue for the connection watchdog callback in the web process
https://bugs.webkit.org/show_bug.cgi?id=108844

Reviewed by Andreas Kling.

Don't pass the connection work queue to the didCloseOnConnectionWorkQueue callback.
Instead, create a new, temporary work queue where the exit call will be dispatched to.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::connectionDidClose):

  • Platform/CoreIPC/Connection.h:

(Connection):

  • Shared/ChildProcess.cpp:

(WebKit::didCloseOnConnectionWorkQueue):

1:00 PM Changeset in webkit [141795] by commit-queue@webkit.org
  • 6 edits in trunk

Implemet :lang() pseudo class support for the WebVTT ::cue pseudo element
https://bugs.webkit.org/show_bug.cgi?id=105478

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-02-04
Reviewed by Antti Koivisto.

Source/WebCore:

In WebVTT lang is preprocessed and stored in the lang attribute of the element,
so we access it instead of walking up the tree the way it is done in HTML.

Existing tests were modified to cover this case.

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

LayoutTests:

  • media/track/captions-webvtt/styling-lang.vtt:
  • media/track/track-css-matching-lang-expected.txt:
  • media/track/track-css-matching-lang.html:
12:40 PM Changeset in webkit [141794] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1364

Merge 140975
BUG=167728
Review URL: https://codereview.chromium.org/12194024

12:37 PM Changeset in webkit [141793] by cevans@google.com
  • 2 edits
    2 copies in branches/chromium/1364

Merge 141198
BUG=171830
Review URL: https://codereview.chromium.org/12178024

12:30 PM Changeset in webkit [141792] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Disable autoscrolling the main frame if main frame scrolling is disabled
https://bugs.webkit.org/show_bug.cgi?id=108848
<rdar://problem/13004059>

Reviewed by Simon Fraser.

Ensure that the main frame can scroll at all before allowing an autoscroll.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::canAutoscroll):

11:48 AM Changeset in webkit [141791] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

XSS Auditor bypass via svg tags and xlink:href
https://bugs.webkit.org/show_bug.cgi?id=84158

Source/WebCore:

This patch adds a test for the xlink:href attribute inside of
script tokens. The test is complicated by the namespacing; the
xlink hrefAttr qualified name does not contain a literal "xlink"
prefix but only the URI of the namespace.

Patch by Tom Sepez <tsepez@chromiium.org> on 2013-02-04
Reviewed by Adam Barth.

Test: http/tests/security/xssAuditor/svg-script-tag.html

  • html/parser/XSSAuditor.cpp:

(WebCore::findAttributeWithName):
(WebCore::XSSAuditor::filterScriptToken):

LayoutTests:

Patch by Tom Sepez <tsepez@chromiium.org> on 2013-02-04
Reviewed by Adam Barth.

  • http/tests/security/xssAuditor/svg-script-tag-expected.txt: Added.
  • http/tests/security/xssAuditor/svg-script-tag.html: Added.
11:39 AM Changeset in webkit [141790] by eric.carlson@apple.com
  • 10 edits in trunk/Source/WebCore

Update CaptionUserPreferences
https://bugs.webkit.org/show_bug.cgi?id=108783

Reviewed by Dean Jackson.

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateSizes): Mark font size as important

when necessary.

  • page/CaptionUserPreferences.h:

(WebCore::CaptionUserPreferences::setUserPrefersCaptions): New, allow a port to remember that

the user has chosen to see captions.

(WebCore::CaptionUserPreferences::setPreferredLanguage): New, allow a port to remember the

user's preferred caption language.

(WebCore::CaptionUserPreferences::preferredLanguages): New, return a Vector of the user's

preferred caption languages.

  • page/CaptionUserPreferencesMac.h:
  • page/CaptionUserPreferencesMac.mm:
  • page/PageGroup.cpp:

(WebCore::PageGroup::captionPreferences):
(WebCore::PageGroup::captionFontSizeScale):

  • page/PageGroup.h:
  • platform/Language.cpp:

(WebCore::userPreferredLanguagesOverride): New, return the user preferred languages override

used during testing.

  • platform/Language.h:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:

(WebCore::InbandTextTrackPrivateAVFObjC::kind):

11:26 AM Changeset in webkit [141789] by timothy_horton@apple.com
  • 6 edits in trunk/Source

Allow TiledCoreAnimationDrawingArea overlay layers to become tiled
https://bugs.webkit.org/show_bug.cgi?id=108729
<rdar://problem/13047546>

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:

(TiledCoreAnimationDrawingArea): Add didCommitChangesForLayer and storage for the
current PlatformLayer corresponding to m_pageOverlayLayer.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::flushLayers): Update the TileCache's visible rect.
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect): Forward exposed rect changes to the page overlay layer, if it's tiled.
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged): Forward scrollability changes to the page overlay layer, if it's tiled.
(WebKit::TiledCoreAnimationDrawingArea::createPageOverlayLayer): Allow the page overlay layer to become tiled. Update its exposed rect and whether or not it respects the exposed rect if it's tiled upon creation.
(WebKit::TiledCoreAnimationDrawingArea::didCommitChangesForLayer): If a GraphicsLayer's platform layer changes (because it switched to or from a tiled layer), reparent it. If it's switching to a tiled layer, update the exposed rect and whether or not it should respect the exposed rect.

  • WebCore.exp.in:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::flushCompositingStateForThisLayerOnly): The "for this layer only" variant
of flushCompositingState wasn't informing its client that it committed changes for the layer.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): We now explicitly want to be able to have a
GraphicsLayerCA switch into or out of tiling while being unparented (we'll get a client callback and
swap out its parent ourselves).

11:18 AM Changeset in webkit [141788] by msaboff@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

For ARMv7s use integer divide instruction for divide and modulo when possible
https://bugs.webkit.org/show_bug.cgi?id=108840

Reviewed in person by Filip Pizlo.

Added ARMv7s integer divide path for ArithDiv and ArithMod where operands and results are integer.
This is patterned after the similar code for X86. Also added modulo power of 2 optimization
that uses logical and. Added sdiv and udiv to the ARMv7 disassembler. Put all the changes
behind #if CPU(APPLE_ARMV7S).

  • assembler/ARMv7Assembler.h:

(ARMv7Assembler):
(JSC::ARMv7Assembler::sdiv):
(JSC::ARMv7Assembler::udiv):

  • dfg/DFGCommon.h:

(JSC::DFG::isARMv7s):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForARMv7s):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

11:14 AM Changeset in webkit [141787] by jchaffraix@webkit.org
  • 13 edits
    2 adds in trunk

[CSS Grid Layout] Add parsing for grid-auto-flow
https://bugs.webkit.org/show_bug.cgi?id=108397

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-auto-flow-get-set.html

This change adds the parsing, application and conversion back through getComputedStyle
for the new property -webkit-grid-auto-flow, which accpets the following:

-webkit-grid-auto-flow: none | rows | columns

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Added code to convert the RenderStyle information back into a CSS value.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
Implemented parsing for -webkit-grid-auto-flow.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator GridAutoFlow):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
Added the conversion operators, used for parsing and getComputedStyle.

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::isInheritedProperty):
Added -webkit-grid-auto-flow to the list of the not inherited properties.

  • css/CSSPropertyNames.in:

Added the new value and keywords.

  • css/StyleBuilder.cpp:

(WebCore::StyleBuilder::StyleBuilder):
Added a handler for the new CSS property.

  • rendering/style/RenderStyle.h:

Added the usual getter / setter / initial function.

  • rendering/style/RenderStyleConstants.h:

Added a new enum GridAutoFlow to hold the parsed value.

  • rendering/style/StyleGridData.cpp:

(WebCore::StyleGridData::StyleGridData):

  • rendering/style/StyleGridData.h:

(WebCore::StyleGridData::operator==):
Updated after adding a new field for the GridAutoFlow value.

LayoutTests:

  • fast/css-grid-layout/grid-auto-flow-get-set-expected.txt: Added.
  • fast/css-grid-layout/grid-auto-flow-get-set.html: Added.
  • fast/css-grid-layout/resources/grid.css:

(.gridAutoFlowNone):
(.gridAutoFlowColumn):
(.gridAutoFlowRow):
Added these new classes to our common style.

11:01 AM Changeset in webkit [141786] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Check PrivateHeaders/JSBasePrivate.h for inappropriate macros
<http://webkit.org/b/108749>

Reviewed by Joseph Pecoraro.

PrivateHeaders/JSBasePrivate.h to list of headers to check in
"Check for Inappropriate Macros in External Headers" build phase
script.

10:59 AM Changeset in webkit [141785] by jochen@chromium.org
  • 5 edits
    1 move
    1 add
    1 delete in trunk/Tools

[chromium] remove WebTestPlugin from the public TestRunner API
https://bugs.webkit.org/show_bug.cgi?id=108467

Reviewed by Adam Barth.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebTestPlugin.h: Removed.
  • DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:

(WebKit):
(WebTestProxyBase):
(WebTestRunner::WebTestProxy::createPlugin):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.cpp: Renamed from Tools/DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp.

(WebTestRunner::TestPlugin::TestPlugin):
(WebTestRunner):
(WebTestRunner::TestPlugin::~TestPlugin):
(WebTestRunner::TestPlugin::initialize):
(WebTestRunner::TestPlugin::destroy):
(WebTestRunner::TestPlugin::updateGeometry):
(WebTestRunner::TestPlugin::parsePrimitive):
(WebTestRunner::TestPlugin::parseColor):
(WebTestRunner::TestPlugin::parseOpacity):
(WebTestRunner::TestPlugin::parseBoolean):
(WebTestRunner::TestPlugin::initScene):
(WebTestRunner::TestPlugin::drawScene):
(WebTestRunner::TestPlugin::destroyScene):
(WebTestRunner::TestPlugin::initProgram):
(WebTestRunner::TestPlugin::initPrimitive):
(WebTestRunner::TestPlugin::drawPrimitive):
(WebTestRunner::TestPlugin::loadShader):
(WebTestRunner::TestPlugin::loadProgram):
(WebTestRunner::TestPlugin::handleInputEvent):
(WebTestRunner::TestPlugin::handleDragStatusUpdate):
(WebTestRunner::TestPlugin::create):
(WebTestRunner::TestPlugin::mimeType):

  • DumpRenderTree/chromium/TestRunner/src/TestPlugin.h: Added.

(WebTestRunner):
(TestPlugin):
(WebTestRunner::TestPlugin::scriptableObject):
(WebTestRunner::TestPlugin::canProcessDrag):
(WebTestRunner::TestPlugin::paint):
(WebTestRunner::TestPlugin::updateFocus):
(WebTestRunner::TestPlugin::updateVisibility):
(WebTestRunner::TestPlugin::acceptsInputEvents):
(WebTestRunner::TestPlugin::didReceiveResponse):
(WebTestRunner::TestPlugin::didReceiveData):
(WebTestRunner::TestPlugin::didFinishLoading):
(WebTestRunner::TestPlugin::didFailLoading):
(WebTestRunner::TestPlugin::didFinishLoadingFrameRequest):
(WebTestRunner::TestPlugin::didFailLoadingFrameRequest):
(WebTestRunner::TestPlugin::isPlaceholder):
(WebTestRunner::TestPlugin::prepareTexture):
(WebTestRunner::TestPlugin::context):
(Scene):
(WebTestRunner::TestPlugin::Scene::Scene):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::createPlugin):
(WebTestRunner):

  • DumpRenderTree/chromium/WebViewHost.cpp:

(WebViewHost::createPlugin):

10:52 AM Changeset in webkit [141784] by pilgrim@chromium.org
  • 8 edits
    1 copy
    1 move
    1 add in trunk/Source

[Chromium] Move IDBFactoryBackendInterface to WebCore
https://bugs.webkit.org/show_bug.cgi?id=108638

Reviewed by Adam Barth.

Part of a larger refactoring series; see tracking bug 106829.

Source/WebCore:

  • Modules/indexeddb/chromium: Added.
  • Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.cpp: Added.

(WebCore):
(WebCore::setIDBFactoryBackendInterfaceCreateFunction):
(WebCore::IDBFactoryBackendInterface::create):

  • Modules/indexeddb/chromium/IDBFactoryBackendInterfaceChromium.h: Added.

(WebCore):

  • WebCore.gyp/WebCore.gyp:
  • WebCore.gypi:

Source/WebKit/chromium:

  • WebKit.gyp:
  • src/AssertMatchingEnums.cpp:
  • src/IDBFactoryBackendInterface.cpp: Removed.
  • src/IDBFactoryBackendProxy.h:
  • src/WebKit.cpp:

(WebKit::initializeWithoutV8):

10:43 AM Changeset in webkit [141783] by inferno@chromium.org
  • 45 edits in trunk/Source

Add ASSERT_WITH_SECURITY_IMPLICATION to detect bad cast in DOM, CSS, etc.
https://bugs.webkit.org/show_bug.cgi?id=108688

Reviewed by Eric Seidel.

Source/WebCore:

  • Modules/notifications/Notification.cpp:

(WebCore::Notification::Notification):
(WebCore::Notification::permission):
(WebCore::Notification::requestPermission):

  • Modules/speech/SpeechGrammar.cpp:

(WebCore::SpeechGrammar::setSrc):

  • Modules/speech/SpeechGrammarList.cpp:

(WebCore::SpeechGrammarList::addFromUri):

  • Modules/websockets/ThreadableWebSocketChannel.cpp:

(WebCore::ThreadableWebSocketChannel::create):

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::cellForColumnAndRow):

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::reattach):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::fillImageSet):

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::reattach):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::reattach):

  • css/StyleBuilder.cpp:

(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):

  • css/StyleResolver.cpp:

(WebCore::createGridPosition):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):

  • css/WebKitCSSFilterRule.cpp:

(WebCore::WebKitCSSFilterRule::reattach):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::reattach):

  • css/WebKitCSSViewportRule.cpp:

(WebCore::WebKitCSSViewportRule::reattach):

  • editing/EditCommand.h:

(WebCore::toSimpleEditCommand):

  • editing/visible_units.cpp:

(WebCore::startOfParagraph):
(WebCore::endOfParagraph):

  • html/HTMLCollection.cpp:

(WebCore::LiveNodeListBase::setItemCache):

  • loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoader::create):
(WebCore::ThreadableLoader::loadResourceSynchronously):

  • loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):

  • page/Frame.cpp:

(WebCore::Frame::frameForWidget):

  • platform/RefCountedSupplement.h:

(WebCore::RefCountedSupplement::from):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::splitBlocks):
(WebCore::RenderBlock::firstLineBlock):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::createLineBoxes):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeReplacedLogicalHeightUsing):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::positionForPoint):

  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::layoutChildBoxes):

  • testing/js/WebCoreTestSupport.cpp:

(WebCoreTestSupport::resetInternalsObject):

  • testing/v8/WebCoreTestSupport.cpp:

(WebCoreTestSupport::resetInternalsObject):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerProxy::addToWorkerDocuments):
(WebCore::SharedWorkerConnectTask::performTask):

  • workers/SharedWorker.cpp:

(WebCore::SharedWorker::create):

  • workers/WorkerContext.cpp:

(WebCore::CloseWorkerContextTask::performTask):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::MessageWorkerContextTask::performTask):
(WebCore::connectToWorkerContextInspectorTask):
(WebCore::disconnectFromWorkerContextInspectorTask):
(WebCore::dispatchOnInspectorBackendTask):

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::loadSynchronously):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadShutdownFinishTask::performTask):
(WebCore::WorkerThreadShutdownStartTask::performTask):

Source/WebKit/blackberry:

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):

  • WebKitSupport/FatFingers.cpp:

(BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):

Source/WebKit/chromium:

  • src/IDBFactoryBackendProxy.cpp:

(WebKit::IDBFactoryBackendProxy::allowIndexedDB):
(WebKit::getWebFrame):

  • src/LocalFileSystemChromium.cpp:

(WebCore::LocalFileSystem::deleteFileSystem):

  • src/WebSharedWorkerImpl.cpp:

(WebKit::WebSharedWorkerImpl::connectTask):
(WebKit::resumeWorkerContextTask):
(WebKit::connectToWorkerContextInspectorTask):
(WebKit::reconnectToWorkerContextInspectorTask):
(WebKit::disconnectFromWorkerContextInspectorTask):
(WebKit::dispatchOnInspectorBackendTask):

Source/WebKit/qt:

  • WebCoreSupport/FrameLoaderClientQt.cpp:
10:35 AM Changeset in webkit [141782] by kov@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

Made the documentation on the confirmed argument for the
WebView::script-confirm signal clearer about its type.

Reviewed by Martin Robinson.

  • webkit/webkitwebview.cpp:

(webkit_web_view_class_init):

10:34 AM Changeset in webkit [141781] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Use UNUSED_PARAM instead of C style comments.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::createStorageArea):

10:32 AM Changeset in webkit [141780] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Stop using libsoup in ewk_url_scheme_request
https://bugs.webkit.org/show_bug.cgi?id=108816

Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-04
Reviewed by Anders Carlsson.

As we are trying to minimize use of external dependencies in our WK2 EFL
API implementation, we should stop using libsoup in
ewk_url_scheme_request and use the WK2 C API instead.

  • UIProcess/API/efl/ewk_url_scheme_request.cpp:

(EwkUrlSchemeRequest::EwkUrlSchemeRequest):

10:29 AM Changeset in webkit [141779] by kov@webkit.org
  • 3 edits in trunk/Tools

Add a new method for obtaining a build-type-dependent path,
instead of modifying all call sites to pass it in.

Reviewed by Martin Robinson.

  • Scripts/run-gtk-tests:

(TestRunner.init): use the new method, which takes a tuple.
(TestRunner._setup_testing_environment): ditto.

  • gtk/common.py:

(get_build_path): accept a tuple that may include Release and
Debug as build types, for searching.
(build_path_for_build_types): new method that finds the path when
it is dependent on the build type.
(build_path): restore its original behaviour.

10:22 AM WebKitGTK/1.10.x edited by jdiggs@igalia.com
Add a new proposed item for 1.10.3 (diff)
10:21 AM Changeset in webkit [141778] by dominik.rottsches@intel.com
  • 2 edits in trunk/Source/WebCore

[Skia] Argument to HarfBuzzShaper::offsetForPosition unnecessarily truncated
https://bugs.webkit.org/show_bug.cgi?id=108479

Reviewed by Emil A Eklund.

Remove a FIXME that intended to solve the value truncation.
Should positively affect SVG text positioning.

No new tests, partially covered by manual test
ManualTests/harfbuzz-mouse-selection-crash.html.

  • platform/graphics/harfbuzz/FontHarfBuzz.cpp:

(WebCore::Font::offsetForPositionForComplexText):

10:19 AM Changeset in webkit [141777] by commit-queue@webkit.org
  • 26 edits in trunk

Web Inspector: Create a container class for SidebarPane instances
https://bugs.webkit.org/show_bug.cgi?id=108183

Source/WebCore:

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

SidebarPaneStack is responsible for pane title bar and expand/collapse behavior (previously handled by SidebarPane).
SidebarPanes are inserted into DOM lazily and can belong to more than one container.
SidebarPane is ready to be displayed in other types of containers (such as tabbed pane as requested in https://bugs.webkit.org/show_bug.cgi?id=107552).
There should be no visible changes except for one: DOM breakpoint pane expand/collapse state is no longer
shared between Elements and Sources sidebars.

  • inspector/front-end/AuditResultView.js:

(WebInspector.AuditResultView):

  • inspector/front-end/BreakpointsSidebarPane.js:

(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._addBreakpoint):
(WebInspector.XHRBreakpointsSidebarPane.prototype.highlightBreakpoint):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype.highlightBreakpoint):

  • inspector/front-end/DOMBreakpointsSidebarPane.js:

(WebInspector.DOMBreakpointsSidebarPane.prototype.highlightBreakpoint):

  • inspector/front-end/ElementsPanel.js:

(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype.wasShown):
(WebInspector.ElementsPanel.prototype.updateStyles):
(WebInspector.ElementsPanel.prototype.updateMetrics):
(WebInspector.ElementsPanel.prototype.updateProperties):
(WebInspector.ElementsPanel.prototype.updateEventListeners):

  • inspector/front-end/ExtensionPanel.js:

(WebInspector.ExtensionSidebarPane):

  • inspector/front-end/ExtensionServer.js:

(WebInspector.ExtensionServer.prototype._onCreateSidebarPane):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype.wasShown):

  • inspector/front-end/SidebarPane.js:

(WebInspector.SidebarPane):
(WebInspector.SidebarPane.prototype.title):
(WebInspector.SidebarPane.prototype.prepareContent):
(WebInspector.SidebarPane.prototype.expand):
(WebInspector.SidebarPane.prototype.onContentReady):
(WebInspector.SidebarPane.prototype.setExpandCallback):
(WebInspector.SidebarPane.prototype.setShowCallback):
(WebInspector.SidebarPane.prototype.wasShown):
(WebInspector.SidebarPaneStack):
(WebInspector.SidebarPaneStack.prototype.wasShown):
(WebInspector.SidebarPaneStack.prototype.addPane):
(WebInspector.SidebarPaneStack.prototype._addTitle):
(WebInspector.SidebarPaneStack.prototype._attachToPane):
(WebInspector.SidebarPaneStack.prototype._isExpanded):
(WebInspector.SidebarPaneStack.prototype._setExpanded):
(WebInspector.SidebarPaneStack.prototype._onPaneExpanded):
(WebInspector.SidebarPaneStack.prototype._collapsePane):
(WebInspector.SidebarPaneStack.prototype._togglePane):
(WebInspector.SidebarPaneStack.prototype._onTitleKeyDown):

  • inspector/front-end/StylesSidebarPane.js:

(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype.set _createNewRule):
(WebInspector.ComputedStyleSidebarPane.prototype.prepareContent):

  • inspector/front-end/WatchExpressionsSidebarPane.js:

(WebInspector.WatchExpressionsSidebarPane):
(WebInspector.WatchExpressionsSidebarPane.prototype.wasShown):
(WebInspector.WatchExpressionsSidebarPane.prototype.addExpression):
(WebInspector.WatchExpressionsSidebarPane.prototype._addButtonClicked):

  • inspector/front-end/inspector.css:

(.pane-title + .pane-title, .pane:not(.visible) + .pane-title, .pane-title:first-of-type):
(.pane-title):
(.pane-title:active):
(.pane-title::before):
(.pane-title.expanded::before):
(.pane-title > select):
(.pane-title > select:hover):
(.pane-title > select:active):
(.pane-title > select.select-settings):
(.pane-title > select.select-filter):
(.pane-title > select > option, .pane-title > select > hr):
(.pane-title > .pane-title-button):
(.pane-title > .pane-title-button:hover):
(.pane-title > .pane-title-button:active, .pane-title > .pane-title-button.toggled):
(.pane-title > .pane-title-button.add):
(.pane-title > .pane-title-button.element-state):
(.pane-title > .pane-title-button.refresh):
(.pane.visible > .body):
(.pane.visible:nth-last-of-type(1)):
(.panel-enabler-view button:not(.status-bar-item), .pane-title-button, button.show-all-nodes):
(.panel-enabler-view button:active:not(.status-bar-item), .pane-title-button:active, button.show-all-nodes:active):
(body.inactive .panel-enabler-view button:not(.status-bar-item), .panel-enabler-view button:disabled:not(.status-bar-item), body.inactive .pane-title-button, .pane-title-button:disabled, body.inactive button.show-all-nodes):

LayoutTests:

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

  • http/tests/inspector/elements-test.js:

(initialize_ElementTest.stylesCallback):
(initialize_ElementTest.InspectorTest.selectNodeAndWaitForStylesWithComputed):

  • inspector/audits/audits-panel-functional-expected.txt:
  • inspector/audits/audits-panel-noimages-functional-expected.txt:
  • inspector/debugger/error-in-watch-expressions.html:
  • inspector/debugger/properties-special.html:
  • inspector/debugger/watch-expressions-panel-switch.html:
  • inspector/debugger/watch-expressions-preserve-expansion.html:
  • inspector/extensions/extensions-audits-api-expected.txt:
  • inspector/extensions/extensions-audits-content-script-expected.txt:
  • inspector/extensions/extensions-audits-expected.txt:
  • inspector/extensions/extensions-events.html:
  • inspector/extensions/extensions-sidebar.html:
  • inspector/styles/lazy-computed-style.html:
10:14 AM Changeset in webkit [141776] by kadam@inf.u-szeged.hu
  • 4 edits in trunk/LayoutTests

[Qt][Wk2] Unreviewed gardnening. Skip failing tests.

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0-wk2/fast/multicol/shrink-to-column-height-for-pagination-expected.png: Update after r141459.
  • platform/qt-5.0-wk2/fast/multicol/shrink-to-column-height-for-pagination-expected.txt: Update after r141459.
9:45 AM Changeset in webkit [141775] by eae@chromium.org
  • 5 edits in trunk/Source/WebCore

Remove duplicate code in RenderBoxModelObject::computedCSSPadding*
https://bugs.webkit.org/show_bug.cgi?id=108707

Reviewed by Eric Seidel.

The computedCSSPaddingTop/Bottom/... methods in
RenderBoxModelObject all do pretty much exactly the same thing
yet share no code.

Break out shared code into computedCSSPadding method and have
the top/bottom/left/right/... ones call it with the appropriate
length value.

No new tests, no change in functionality.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::computedCSSPadding):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
(RenderBoxModelObject):

9:42 AM Changeset in webkit [141774] by commit-queue@webkit.org
  • 8 edits in trunk

Web Inspector: add round braces to javascript tokenizer
https://bugs.webkit.org/show_bug.cgi?id=108692

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

Source/WebCore:

Change SourceJavascriptTokenizer.re2js file to produce "brace-start"
and "brace-end" tokens for round braces.
Regenerate SourceJavascriptTokenizer.js according to new re2js file.

No new tests: no change in behaviour.

  • inspector/front-end/SourceJavaScriptTokenizer.js:

(WebInspector.SourceJavaScriptTokenizer.prototype.nextToken):

  • inspector/front-end/SourceJavaScriptTokenizer.re2js:

LayoutTests:

Updated test expectations to correspond to new tokens "brace-start"
and "brace-end" in javascript tokenizer.

  • inspector/editor/highlighter-basics-expected.txt:
  • inspector/editor/text-editor-long-line-expected.txt:
  • inspector/syntax-highlight-html-expected.txt:
  • inspector/syntax-highlight-javascript-expected.txt:
9:38 AM Changeset in webkit [141773] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Needs one-shot drawing synchronization flag should be set before rendering when resuming the backing store
https://bugs.webkit.org/show_bug.cgi?id=108760

Patch by Andrew Lo <anlo@rim.com> on 2013-02-04
Reviewed by Yong Li.
Internally reviewed by Arvid Nilsson.

Internal PR 286218.
When acquiring the backing store ownership in WebPagePrivate::resumeBackingStore
we need to set the needs one-shot drawing synchronization flag
before rendering, so that when the render is completed we
commit the root layer.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):

8:42 AM Changeset in webkit [141772] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: take page scale factor into account when updating overlay.
https://bugs.webkit.org/show_bug.cgi?id=108831

Reviewed by Vsevolod Vlasov.

Otherwise, the ports that use page scale factor have broken overlay.

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::update):

7:56 AM Changeset in webkit [141771] by commit-queue@webkit.org
  • 17 edits in trunk/Source/WebCore

[v8] explicit isolate parameter for MakeWeak calls
https://bugs.webkit.org/show_bug.cgi?id=108818

Patch by Dan Carney <dcarney@google.com> on 2013-02-04
Reviewed by Kentaro Hara.

No new tests. No change in functionality.

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::DOMDataStore):
(WebCore::DOMDataStore::weakCallback):

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::setWrapper):
(WebCore::DOMDataStore::set):
(WebCore::DOMDataStore::setWrapperInObject):
(DOMDataStore):

  • bindings/v8/DOMWrapperMap.h:

(WebCore::DOMWrapperMap::DOMWrapperMap):
(WebCore::DOMWrapperMap::set):
(WebCore::DOMWrapperMap::defaultWeakCallback):
(DOMWrapperMap):

  • bindings/v8/DOMWrapperWorld.cpp:

(WebCore::isolatedWorldWeakCallback):
(WebCore::DOMWrapperWorld::makeContextWeak):

  • bindings/v8/ScriptState.cpp:

(WebCore::ScriptState::ScriptState):
(WebCore::ScriptState::weakReferenceCallback):

  • bindings/v8/ScriptState.h:

(ScriptState):

  • bindings/v8/V8AbstractEventListener.cpp:

(WebCore::V8AbstractEventListener::weakEventListenerCallback):
(WebCore::V8AbstractEventListener::V8AbstractEventListener):
(WebCore::V8AbstractEventListener::setListenerObject):

  • bindings/v8/V8AbstractEventListener.h:

(V8AbstractEventListener):

  • bindings/v8/V8EventListener.cpp:

(WebCore::V8EventListener::V8EventListener):

  • bindings/v8/V8LazyEventListener.cpp:

(WebCore::V8LazyEventListener::V8LazyEventListener):

  • bindings/v8/V8MutationCallback.cpp:

(WebCore::V8MutationCallback::V8MutationCallback):

  • bindings/v8/V8MutationCallback.h:

(WebCore::V8MutationCallback::create):
(WebCore::V8MutationCallback::weakCallback):

  • bindings/v8/V8NPObject.cpp:

(WebCore::V8NPTemplateMap::set):
(WebCore::V8NPTemplateMap::sharedInstance):
(WebCore::V8NPTemplateMap::V8NPTemplateMap):
(V8NPTemplateMap):
(WebCore::V8NPTemplateMap::weakCallback):
(WebCore::npObjectGetProperty):
(WebCore):
(WebCore::staticNPObjectMap):
(WebCore::weakNPObjectCallback):

  • bindings/v8/V8ValueCache.cpp:

(WebCore::cachedStringCallback):
(WebCore::StringCache::v8ExternalStringSlow):

  • bindings/v8/custom/V8InjectedScriptManager.cpp:

(WebCore::WeakReferenceCallback):
(WebCore::createInjectedScriptHostV8Wrapper):

  • bindings/v8/custom/V8MutationObserverCustom.cpp:

(WebCore::V8MutationObserver::constructorCallbackCustom):

7:00 AM Changeset in webkit [141770] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Source/WebKit2

[WK2][EFL] Weird stripe at the end of the page
https://bugs.webkit.org/show_bug.cgi?id=108820

Reviewed by Noam Rosenthal.

The page scroll bound was artificially enlarged by one causing the artifact appearance.

  • UIProcess/PageViewportController.cpp:

(WebKit::PageViewportController::boundContentsPositionAtScale):

6:45 AM Changeset in webkit [141769] by commit-queue@webkit.org
  • 15 edits
    1 move
    7 deletes in trunk

Disable -webkit-overflow-scrolling CSS attribute on Chromium
https://bugs.webkit.org/show_bug.cgi?id=108020

Patch by Sami Kyostila <skyostil@chromium.org> on 2013-02-04
Reviewed by James Robinson.

Now that we can automatically promote overflow elements to accelerated
scrolling layers there is no use for the -webkit-overflow-scrolling CSS
attribute any longer on Chromium.

Source/WebKit/chromium:

This patch enables composited overflow scrolling in
ScrollingCoordinatorChromiumTest. Because this also causes the overflow div
in non-fast-scrollable.html to become composited, we also need to modify that
test to opt it out of composited scrolling.

  • features.gypi:
  • tests/ScrollingCoordinatorChromiumTest.cpp:

(WebKit::ScrollingCoordinatorChromiumTest::ScrollingCoordinatorChromiumTest):
(WebKit::TEST_F):

  • tests/data/non-fast-scrollable.html:
  • tests/data/overflow-scrolling.html: Renamed from Source/WebKit/chromium/tests/data/touch-overflow-scrolling.html.

LayoutTests:

The following tests using -webkit-overflow-scroll are modified to also call
setAcceleratedCompositingForOverflowScrollEnabled(). This makes them test
meaningful things on also on platforms that do not support that CSS attribute.

  • compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor.html:
  • compositing/overflow/iframe-inside-overflow-clipping.html:
  • compositing/overflow/nested-scrolling.html:
  • compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor.html:
  • compositing/overflow/scrolling-content-clip-to-viewport.html:
  • compositing/overflow/scrolling-without-painting.html:
  • compositing/overflow/textarea-scroll-touch.html:
  • compositing/overflow/updating-scrolling-content.html:
  • platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt: Removed.
  • platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch.html: Removed.
  • platform/chromium-linux/compositing/overflow/nested-scrolling-expected.png:
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/overflow/overflow-auto-with-touch-toggle-expected.txt: Removed.
  • platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.png: Removed.
  • platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context-expected.txt: Removed.
  • platform/chromium/compositing/overflow/overflow-scrolling-touch-stacking-context.html: Removed.
  • platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt: Removed.
6:43 AM Changeset in webkit [141768] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Allow user to change dock side by dragging toolbar
https://bugs.webkit.org/show_bug.cgi?id=108073

Dragging toolbar to the right/bottom will change the dock side accordingly
instead of changing the inspector window height (if dock to right is available).

Patch by Dmitry Gozman <dgozman@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

No new tests, because of pure inspector UI change.

  • inspector/front-end/DockController.js:

(WebInspector.DockController.prototype.dockSide):

  • inspector/front-end/Toolbar.js:

(WebInspector.Toolbar):
(WebInspector.Toolbar.prototype._isDockedToBottom):
(WebInspector.Toolbar.prototype._isUndocked):
(WebInspector.Toolbar.prototype._toolbarDragStart):
(WebInspector.Toolbar.prototype._toolbarDragEnd):
(WebInspector.Toolbar.prototype._toolbarDrag):
(WebInspector.Toolbar.prototype._toolbarDragMoveWindow):
(WebInspector.Toolbar.prototype._toolbarDragChangeDocking):
(WebInspector.Toolbar.prototype._toolbarDragChangeHeight):

  • inspector/front-end/UIUtils.js:

(WebInspector._elementDragStart):
(WebInspector._elementDragMove):
(WebInspector._cancelDragEvents):
(WebInspector._elementDragEnd):

6:35 AM Changeset in webkit [141767] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipping failing tests.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2013-02-04

  • platform/qt/TestExpectations:
6:23 AM Changeset in webkit [141766] by caseq@chromium.org
  • 4 edits in trunk

Web Inspector: sync list of console API methods to that used by auto-complete
https://bugs.webkit.org/show_bug.cgi?id=108804

Reviewed by Pavel Feldman.

  • push new method names from InjectedScriptSource to RuntimeModel;
  • add a comment to InjectedScriptSource noting the necessity of keeping lists in sync.
  • inspector/InjectedScriptSource.js:
  • inspector/front-end/RuntimeModel.js:

(WebInspector.RuntimeModel.prototype.receivedPropertyNames):
(WebInspector.RuntimeModel.prototype._completionsForExpression):

6:08 AM Changeset in webkit [141765] by caseq@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Network] Minor refactorings.
https://bugs.webkit.org/show_bug.cgi?id=108162

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-02-04
Reviewed by Vsevolod Vlasov.

Apply minor refactorings to NetworkPanel.js
Add hint to statusbar selector buttons.

  • English.lproj/localizedStrings.js: Added hint string.
  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._createStatusBarItems): Ditto.
(WebInspector.NetworkLogView.prototype._makeHeaderFragment):
Applied minor refactoring.
(WebInspector.NetworkLogView.prototype._createStatusBarItems.createFilterElement):
Ditto.
(WebInspector.NetworkLogView.prototype._updateOffscreenRows): Ditto.
(WebInspector.NetworkPanel.prototype._onRowSizeChanged): Ditto.

5:55 AM Changeset in webkit [141764] by caseq@chromium.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: [CPU Profile] Apply minor refactorings and add JSDocs.
https://bugs.webkit.org/show_bug.cgi?id=108437

Patch by Eugene Klyuchnikov <eustas@chromium.org> on 2013-02-04
Reviewed by Pavel Feldman.

CPU Profile code has obsolete inline-comments to clarify types.
Currently we use JSDocs to specify types.

Also applied some minor refactorings.

  • inspector/front-end/BottomUpProfileDataGridTree.js:

(WebInspector.BottomUpProfileDataGridNode):
Added JSDocs. Removed profileView parameter.
(WebInspector.BottomUpProfileDataGridNode.prototype._takePropertiesFromProfileDataGridNode):
Added JSDocs.
(WebInspector.BottomUpProfileDataGridNode.prototype._keepOnlyChild):
Ditto.
(WebInspector.BottomUpProfileDataGridNode.prototype._merge):
Ditto.
(WebInspector.BottomUpProfileDataGridNode.prototype._sharedPopulate):
Do not pass profileView to constructor.
(WebInspector.BottomUpProfileDataGridTree):
Added JSDocs. Renamed parameters.
(WebInspector.BottomUpProfileDataGridTree.prototype.focus):
Added JSDocs.
(WebInspector.BottomUpProfileDataGridTree.prototype.exclude):
Ditto.

  • inspector/front-end/CPUProfileView.js: Removed unused getter/setter.

(WebInspector.CPUProfileView.prototype._getCPUProfileCallback):
Un-nested. Added JSDocs.
(WebInspector.CPUProfileView.prototype._getBottomUpProfileDataGridTree):
Added JSDocs. Turned to method from getter. Simplified.
(WebInspector.CPUProfileView.prototype._getTopDownProfileDataGridTree):
Added JSDocs. Turned to method from getter.
(WebInspector.CPUProfileView.prototype._assignParentsInProfile):
Optimized.

  • inspector/front-end/DataGrid.js: Added JSDocs.
  • inspector/front-end/ProfileDataGridTree.js:

(WebInspector.ProfileDataGridNode):
Added JSDocs. Removed profileView parameter.
(WebInspector.ProfileDataGridNode.prototype.createCell): Added JSDocs.
(WebInspector.ProfileDataGridNode.prototype.sort): Ditto.
(WebInspector.ProfileDataGridNode.prototype.insertChild): Ditto.
(WebInspector.ProfileDataGridNode.prototype.removeChild): Ditto.
(WebInspector.ProfileDataGridNode.prototype.removeChildren):
Added JSDocs. Removed parameter.
(WebInspector.ProfileDataGridNode.prototype.findChild): Added JSDocs.
(WebInspector.ProfileDataGridTree): Added JSDocs. Renamed parameter.

  • inspector/front-end/TopDownProfileDataGridTree.js:

(WebInspector.TopDownProfileDataGridNode):
Added JSDocs. Removed profileView parameter.
(WebInspector.TopDownProfileDataGridNode.prototype._sharedPopulate):
Do not pass profileView to constructor.
(WebInspector.TopDownProfileDataGridTree):
Added JSDocs. Renamed parameter.
(WebInspector.TopDownProfileDataGridTree.prototype.focus):
Added JSDocs.
(WebInspector.TopDownProfileDataGridTree.prototype.exclude):
Ditto.

5:48 AM Changeset in webkit [141763] by commit-queue@webkit.org
  • 24 edits in trunk/Source/WebCore

[v8] use toV8Fast in hand coded callbacks
https://bugs.webkit.org/show_bug.cgi?id=108817

Patch by Dan Carney <dcarney@google.com> on 2013-02-04
Reviewed by Kentaro Hara.

No new tests. No change in functionality.

  • bindings/v8/custom/V8DOMWindowCustom.cpp:

(WebCore::V8DOMWindow::openCallback):
(WebCore::V8DOMWindow::indexedPropertyGetter):
(WebCore::V8DOMWindow::namedPropertyGetter):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):

  • bindings/v8/custom/V8DocumentLocationCustom.cpp:

(WebCore::V8Document::locationAccessorGetter):

  • bindings/v8/custom/V8EventCustom.cpp:

(WebCore::V8Event::dataTransferAccessorGetter):
(WebCore::V8Event::clipboardDataAccessorGetter):

  • bindings/v8/custom/V8FileReaderCustom.cpp:

(WebCore::V8FileReader::resultAccessorGetter):

  • bindings/v8/custom/V8HTMLAllCollectionCustom.cpp:

(WebCore):
(WebCore::getNamedItems):
(WebCore::getItem):
(WebCore::V8HTMLAllCollection::namedPropertyGetter):
(WebCore::V8HTMLAllCollection::itemCallback):
(WebCore::V8HTMLAllCollection::namedItemCallback):
(WebCore::V8HTMLAllCollection::callAsFunctionCallback):

  • bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:

(WebCore::V8HTMLCanvasElement::getContextCallback):

  • bindings/v8/custom/V8HTMLCollectionCustom.cpp:

(WebCore::V8HTMLCollection::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLElementCustom.cpp:

(WebCore::V8HTMLElement::itemValueAccessorGetter):

  • bindings/v8/custom/V8HTMLFormControlsCollectionCustom.cpp:

(WebCore):
(WebCore::getNamedItems):
(WebCore::V8HTMLFormControlsCollection::namedPropertyGetter):
(WebCore::V8HTMLFormControlsCollection::namedItemCallback):

  • bindings/v8/custom/V8HTMLFormElementCustom.cpp:

(WebCore::V8HTMLFormElement::indexedPropertyGetter):
(WebCore::V8HTMLFormElement::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:

(WebCore::V8HTMLFrameSetElement::namedPropertyGetter):

  • bindings/v8/custom/V8HTMLLinkElementCustom.cpp:

(WebCore::V8HTMLLinkElement::sizesAccessorGetter):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore):
(WebCore::getNamedItems):
(WebCore::V8HTMLOptionsCollection::namedPropertyGetter):
(WebCore::V8HTMLOptionsCollection::namedItemCallback):
(WebCore::V8HTMLOptionsCollection::indexedPropertyGetter):

  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::V8HTMLSelectElement::indexedPropertyGetter):

  • bindings/v8/custom/V8MessageEventCustom.cpp:

(WebCore::V8MessageEvent::dataAccessorGetter):
(WebCore::V8MessageEvent::portsAccessorGetter):

  • bindings/v8/custom/V8NamedNodeMapCustom.cpp:

(WebCore::V8NamedNodeMap::indexedPropertyGetter):
(WebCore::V8NamedNodeMap::namedPropertyGetter):

  • bindings/v8/custom/V8NodeListCustom.cpp:

(WebCore::V8NodeList::namedPropertyGetter):

  • bindings/v8/custom/V8PopStateEventCustom.cpp:

(WebCore::V8PopStateEvent::stateAccessorGetter):

  • bindings/v8/custom/V8SQLTransactionSyncCustom.cpp:

(WebCore::V8SQLTransactionSync::executeSqlCallback):

  • bindings/v8/custom/V8StyleSheetListCustom.cpp:

(WebCore::V8StyleSheetList::namedPropertyGetter):

  • bindings/v8/custom/V8TrackEventCustom.cpp:

(WebCore::V8TrackEvent::trackAccessorGetter):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::V8XMLHttpRequest::responseAccessorGetter):

4:44 AM Changeset in webkit [141762] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

Remove duplicate entry from DumpRenderTree Xcode project

$ uniq Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj | diff -u - Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj | patch -p0 -R
patching file Tools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Remove duplicate.

4:41 AM Changeset in webkit [141761] by ddkilzer@apple.com
  • 2 edits in trunk/Tools

Sort TestWebKitAPI Xcode project file

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
4:36 AM Changeset in webkit [141760] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit2

Sort WebKit2 Xcode project file

  • WebKit2.xcodeproj/project.pbxproj:
4:32 AM Changeset in webkit [141759] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Remove duplicate entry from WebCore Xcode project

$ uniq Source/WebCore/WebCore.xcodeproj/project.pbxproj | diff -u - Source/WebCore/WebCore.xcodeproj/project.pbxproj | patch -p0 -R
patching file Source/WebCore/WebCore.xcodeproj/project.pbxproj

  • WebCore.xcodeproj/project.pbxproj: Remove duplicate.
4:30 AM Changeset in webkit [141758] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

Sort WebCore Xcode project file

  • WebCore.xcodeproj/project.pbxproj:
4:26 AM Changeset in webkit [141757] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove duplicate entries from JavaScriptCore Xcode project

$ uniq Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj | diff -u - Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj | patch -p0 -R
patching file Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj

4:21 AM Changeset in webkit [141756] by Simon Hausmann
  • 3 edits in trunk/Source/WebKit2

[WK2][Qt] Replace WebPageGroup usage for user scripts with WKPageGroupRef
https://bugs.webkit.org/show_bug.cgi?id=108651

Reviewed by Sam Weinig.

It's straight-forward port towards the C API.

  • UIProcess/API/qt/qquickwebview.cpp:

(QQuickWebViewPrivate::initialize):
(readUserScript):
(QQuickWebViewPrivate::updateUserScripts):

  • UIProcess/API/qt/qquickwebview_p_p.h:

(QQuickWebViewPrivate):

4:21 AM Changeset in webkit [141755] by ddkilzer@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Sort JavaScriptCore Xcode project file

4:14 AM Changeset in webkit [141754] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WTF

Sort WTF Xcode project file

  • WTF.xcodeproj/project.pbxproj:
4:13 AM Changeset in webkit [141753] by ddkilzer@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

Sort ANGLE Xcode project file.

  • ANGLE.xcodeproj/project.pbxproj:
3:34 AM Changeset in webkit [141752] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[v8] disable ascii check once latin-1 is enabled in v8
https://bugs.webkit.org/show_bug.cgi?id=108805

Patch by Dan Carney <dcarney@google.com> on 2013-02-04
Reviewed by Kentaro Hara.

No new tests. No change in functionality.

  • bindings/v8/V8ValueCache.cpp:

(WebCore::makeExternalString):

2:46 AM Changeset in webkit [141751] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: make tabbed pane header a relayout boundary.
https://bugs.webkit.org/show_bug.cgi?id=108650

Reviewed by Alexander Pavlov.

Otherwise, its measure width routine causes total reflow.

  • inspector/front-end/tabbedPane.css:

(.tabbed-pane-header):

2:27 AM Changeset in webkit [141750] by hayato@chromium.org
  • 9 edits
    2 adds in trunk/Source/WebCore

Split InspectorCSSOMWrappers out from StyleResolver.h into its own file.
https://bugs.webkit.org/show_bug.cgi?id=108797

Reviewed by Hajime Morita.

This is a following patch after r141373. Now we can have
InspectorCSSOMWrappers in its own file since CSSDefaultStyleSheets
was factored out from StyleResolver.cpp in r141733.

WebCore/inspector/ directory is used for basic inspector
functionalities. Therefore, I've put
InspectorCSSOMWrappers.{h,cpp} in WebCore/css/ rather than
WebCore/inspector/.

No new tests, refactoring only.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/InspectorCSSOMWrappers.cpp: Added.

(WebCore):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetIfNeeded):
(WebCore::InspectorCSSOMWrappers::collect):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetContents):
(WebCore::InspectorCSSOMWrappers::collectFromStyleSheets):
(WebCore::InspectorCSSOMWrappers::collectFromDocumentStyleSheetCollection):
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
(WebCore::InspectorCSSOMWrappers::reportMemoryUsage):

  • css/InspectorCSSOMWrappers.h: Added.

(WebCore):
(InspectorCSSOMWrappers):

  • css/StyleResolver.cpp:
  • css/StyleResolver.h:
1:33 AM Changeset in webkit [141749] by kbalazs@webkit.org
  • 21 edits
    1 add in trunk/Source

[Soup] Wrap SoupSession by NetworkStorageSession
https://bugs.webkit.org/show_bug.cgi?id=108615

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Implement NetworkStorageSession for ports using soup. It has been
separated from NetworkingContext, so now we have a default storage
session, which is the same as before but now wrapped with NetworkStorageSession,
and it can be overridden by the networking context.

No change in behavior so no new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • loader/CookieJar.cpp:

(WebCore):
Now we also get the storage session from the networking context
and not the other way.

  • platform/network/NetworkStorageSession.h:

(NetworkStorageSession):
(WebCore::NetworkStorageSession::setSoupSession):
(WebCore::NetworkStorageSession::soupSession):
Hold a SoupSession pointer for ports using soup. Added a setter because it is
necessary for API's that allow it to be specified per page, like EFL WK1.

  • platform/network/NetworkingContext.h:

(NetworkingContext):

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::cookieJarForSession):

  • platform/network/soup/NetworkStorageSessionSoup.cpp: Copied from Source/WebKit2/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp.

(WebCore::NetworkStorageSession::NetworkStorageSession):
(WebCore::NetworkStorageSession::defaultStorageSession):
(WebCore::NetworkStorageSession::createDefaultSession):
(WebCore::NetworkStorageSession::createPrivateBrowsingSession):
(WebCore::NetworkStorageSession::switchToNewTestingSession):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sessionFromContext):

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • loader/CookieJar.cpp:

(WebCore):

  • platform/network/NetworkStorageSession.h:

(NetworkStorageSession):
(WebCore::NetworkStorageSession::setSoupSession):
(WebCore::NetworkStorageSession::soupSession):

  • platform/network/NetworkingContext.h:

(NetworkingContext):

  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::cookieJarForSession):

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sessionFromContext):

Source/WebKit/efl:

Changed to hold the SoupSession pointer in a NetworkStorageSession
so we can pass it to WebCore. _Ewk_View_Private_Data has to be
changed for that reason.

  • WebCoreSupport/FrameNetworkingContextEfl.cpp:

(WebCore::FrameNetworkingContextEfl::storageSession):

  • WebCoreSupport/FrameNetworkingContextEfl.h:

(FrameNetworkingContextEfl):

  • ewk/ewk_view.cpp:

(_Ewk_View_Private_Data):
(_ewk_view_priv_new):
(ewk_view_soup_session_get):
(ewk_view_soup_session_set):
(EWKPrivate::storageSession):
(EWKPrivate):

  • ewk/ewk_view_private.h:

(EWKPrivate):

Source/WebKit/gtk:

  • WebCoreSupport/FrameNetworkingContextGtk.cpp:

(WebKit::FrameNetworkingContextGtk::storageSession):

  • WebCoreSupport/FrameNetworkingContextGtk.h:

(FrameNetworkingContextGtk):

Source/WebKit2:

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::WebFrameNetworkingContext::storageSession):

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:

(WebFrameNetworkingContext):

1:08 AM Changeset in webkit [141748] by tkent@chromium.org
  • 16 edits
    3 deletes in trunk/LayoutTests

[Chromium] Rebaseline for r141741
https://bugs.webkit.org/show_bug.cgi?id=108791

  • platform/chromium-linux-x86/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-linux/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-lion/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac-snowleopard/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-mac/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win-xp/fast/forms/date-multiple-fields/date-multiple-fields-keyboard-events-expected.txt: Removed.
  • platform/chromium-win-xp/fast/forms/date/date-appearance-l10n-expected.png:
  • platform/chromium-win-xp/fast/forms/datetime/datetime-appearance-l10n-expected.png:
  • platform/chromium-win-xp/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-keyboard-events-expected.txt: Removed.
  • platform/chromium-win-xp/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png:
  • platform/chromium-win-xp/fast/forms/month/month-appearance-l10n-expected.png:
  • platform/chromium-win-xp/fast/forms/time-multiple-fields/time-multiple-fields-localization-expected.txt: Removed.
  • platform/chromium-win-xp/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetime-suggestion-picker-appearance-locale-hebrew-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/datetimelocal-suggestion-picker-appearance-locale-hebrew-expected.png:
  • platform/chromium-win-xp/platform/chromium/fast/forms/suggestion-picker/time-suggestion-picker-appearance-locale-hebrew-expected.png:
  • platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-appearance-ru-expected.png:
  • platform/chromium/TestExpectations:
1:01 AM Changeset in webkit [141747] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: source location in statusbar has few bugs in it
https://bugs.webkit.org/show_bug.cgi?id=108748

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-04
Reviewed by Vsevolod Vlasov.

Call super method statusBarItems in SnippetJavaScriptSourceFrame class
and merge its results. Fix css styles for source location in statusbar
and rename its css class into a less confusing name.

No new test: no change in behaviour.

  • inspector/front-end/SnippetJavaScriptSourceFrame.js:

(WebInspector.SnippetJavaScriptSourceFrame.prototype.statusBarItems):

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame):

  • inspector/front-end/inspector.css:

(.source-frame-cursor-position):

12:26 AM Changeset in webkit [141746] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebCore

Cleanup: Normalize usage of ExceptionCode in ContainerNode::checkXxxChild()
https://bugs.webkit.org/show_bug.cgi?id=108766

Reviewed by Kentaro Hara.

This patch refactors checkAddChild and checkReplaceChild to remove the
creation of an extra ExceptionCode that's not necessary for the
desired behavior, and to bring the ExceptionCode usage into line with
the rest of WebKit (this was the only case where ExceptionCode was
assigned inside an 'if' statement's condition).

After this patch, 'ec' will always be assigned a value, even if the
result of 'checkAcceptChild' is 0. This would only change behavior if
'ec' was non-zero coming into the function, and 'checkAcceptChild'
returned 0. Since every callsite is either directly after an explicit
zeroing of 'ec', or after an 'if (ec)' clause, that case should never
appear. This patch, therefore, shouldn't visibly change WebKit's
behavior.

  • dom/ContainerNode.cpp:

(WebCore::checkAddChild):
(WebCore::checkReplaceChild):

Feb 3, 2013:

11:44 PM Changeset in webkit [141745] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL][WK2] Mark fast/dom/DOMImplementation/createDocument-with-used-doctype.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=108793

Unreviewed EFL gardening.

Mark fast/dom/DOMImplementation/createDocument-with-used-doctype.html as
flaky due to Bug 108058. It sometimes crashes on the bots.

Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-03

  • platform/efl-wk2/TestExpectations:
11:16 PM Changeset in webkit [141744] by ddkilzer@apple.com
  • 8 edits in trunk/Source

Upstream ENABLE_PDFKIT_PLUGIN settting
<http://webkit.org/b/108792>

Reviewed by Tim Horton.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN

on iOS since PDFKit is a Mac-only framework.

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN

on iOS since PDFKit is a Mac-only framework.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN

on iOS since PDFKit is a Mac-only framework.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig: Disable PDFKIT_PLUGIN

on iOS since PDFKit is a Mac-only framework.

11:14 PM Changeset in webkit [141743] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Silently block one more directory needed for NSApplication initialization.

Reviewed by Sam Weinig.

  • WebProcess/com.apple.WebProcess.sb.in:
11:02 PM Changeset in webkit [141742] by tasak@google.com
  • 4 edits in trunk/Source/WebCore

Split per-resolve logic out from StyleResolver.
https://bugs.webkit.org/show_bug.cgi?id=96421

Reviewed by Eric Seidel.

Implemented class StyleResolver::State and added m_state to
StyleResolver. All member variables used for per-resolve logic are
moved into the state class.

No new tests, because just refactoring.

  • css/SVGCSSStyleSelector.cpp:

(WebCore::StyleResolver::applySVGProperty):

  • css/StyleResolver.cpp:

(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::sortMatchedRules):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::initElement):
(WebCore::StyleResolver::initForStyleResolve):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::updateFont):
(WebCore::StyleResolver::cacheBorderAndBackground):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::isLeftPage):
(WebCore::StyleResolver::applyPropertyToStyle):
(WebCore::StyleResolver::useSVGZoomRules):
(WebCore::createGridTrackBreadth):
(WebCore::createGridTrackMinMax):
(WebCore::createGridTrackGroup):
(WebCore::createGridTrackList):
(WebCore::StyleResolver::resolveVariables):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::StyleResolver::checkForTextSizeAdjust):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::setFontSize):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::cachedOrPendingStyleShaderFromValue):
(WebCore::StyleResolver::loadPendingShaders):
(WebCore::StyleResolver::parseCustomFilterTransformParameter):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingImages):
(WebCore::StyleResolver::reportMemoryUsage):

  • css/StyleResolver.h:

(WebCore::StyleResolver::style):
(WebCore::StyleResolver::parentStyle):
(WebCore::StyleResolver::rootElementStyle):
(WebCore::StyleResolver::element):
(WebCore::StyleResolver::setFontDescription):
(WebCore::StyleResolver::setZoom):
(WebCore::StyleResolver::setEffectiveZoom):
(WebCore::StyleResolver::setTextSizeAdjust):
(WebCore::StyleResolver::setWritingMode):
(WebCore::StyleResolver::setTextOrientation):
(WebCore::StyleResolver::hasParentNode):
(WebCore::StyleResolver::addMatchedRule):
(StyleResolver):
(State):
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::applyPropertyToRegularStyle):
(WebCore::StyleResolver::applyPropertyToVisitedLinkStyle):
Added "m_state." to access member variables used for per-resolve logic.

10:58 PM Changeset in webkit [141741] by tkent@chromium.org
  • 4 edits in trunk

Support setLangAttributeAwareFormControlUIEnabled on Chromium Windows XP
https://bugs.webkit.org/show_bug.cgi?id=108791

Reviewed by Kentaro Hara.

Source/WebCore:

We didn't support setLangAttributeAwareFormControlUIEnabled(true) on
Chromium Windows XP because of lack of LocaleNameToLCID API. This change
add manual mapping from locale names to LCIDs for Windows XP.

No new tests. This doesn't make any behavior changes in products, and
this improves some test results.

  • platform/text/win/LocaleWin.cpp:

(WebCore): Define NameToLCIDMap.
(WebCore::removeLastComponent):
Remove the last component separated with '-'.
(WebCore::ensureNameToLCIDMap):
Add locale names used in layout tests.
(WebCore::convertLocaleNameToLCID):
Find an appropriate LCID longest matching with the specified locale name.
(WebCore::LCIDFromLocale):
Use convertLocaleNameToLCID if LocaleNameToLCID is not available.

LayoutTests:

  • platform/chromium/TestExpectations:

Mark affected tests failure.
Actually we should be able to remove XP-specific test results for
them. We just mark them in this patch just in case, and do rebaseline
later.

10:17 PM Changeset in webkit [141740] by morrita@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, marking some as timing out.

  • platform/chromium/TestExpectations:
10:16 PM Changeset in webkit [141739] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

PatchLogs are not getting created on QueueStatusServer
https://bugs.webkit.org/show_bug.cgi?id=108593

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-03
Reviewed by Eric Seidel.

Added missing "added" patch event to submit-to-ews handler.

  • QueueStatusServer/app.yaml:
  • QueueStatusServer/handlers/submittoews.py:

(SubmitToEWS._add_attachment_to_ews_queues):

10:11 PM Changeset in webkit [141738] by tkent@chromium.org
  • 24 edits in trunk/Source/WebCore

Add FocusDirection argument to HTMLTextFormControlElement::handleFocusEvent
https://bugs.webkit.org/show_bug.cgi?id=108775

Reviewed by Hajime Morita.

We'd like to add a FocusDirection argument to
HTMLTextFormControlElement::handleFocusEvent in order to fix Bug

  1. This is a preparation for it.

We need to add FocusDirection arguments to some focus-related functions
to pass it correctly when TAB or Shift+TAB is pressed.

No new tests. This doesn't make any behavior changes.

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::dispatchFocusEvent):
To pass the FocusDirection argument to handleFocusEvent, we need to add
it to dispatchFocusEvent too.

  • html/HTMLTextFormControlElement.h:

(HTMLTextFormControlElement):
Add FocusDirection arugment to dispatchFocusEvent.
(WebCore::HTMLTextFormControlElement::handleFocusEvent):
Add FocusDirection argument.

  • dom/Node.cpp:

(WebCore::Node::dispatchFocusEvent): Add FocusDirection argument.

  • dom/Node.h:

(Node): Ditto.

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode): Add FocusDirection argument in
order to pass it to Node::dispatchFocusEvent.

  • dom/Document.h:

(Document): Ditto.

  • page/FocusController.cpp:

(WebCore::dispatchEventsOnWindowAndFocusedNode):
Adjust Node::dispatchFocusEvent argument.
(WebCore::FocusController::advanceFocusInDocumentOrder):
Pass FocusDirectio to Element::focus.
(WebCore::FocusController::setFocusedNode):
Add FocusDirection argument in order to pass it to Document::setFocusedNode.
(WebCore::FocusController::advanceFocusDirectionallyInContainer):
Pass FocusDirectio to Element::focus.

  • page/FocusController.h:

(FocusController): Add FocusDirection argument to setFocusedNode.

  • dom/Element.cpp:

(WebCore::Element::focus):
Add FocusDirection argument to pass it to FocusController::setFocusedNode.

  • dom/Element.h:

(Element): Ditto.

  • WebCore.exp.in:

Update FocusController::setFocusedNode and Document::setFocusedNode.

  • html/HTMLLabelElement.cpp:

(WebCore::HTMLLabelElement::focus): Adjust FocusDirection argument.

  • html/HTMLLabelElement.h:

(HTMLLabelElement): Ditto.

  • html/HTMLLegendElement.cpp:

(WebCore::HTMLLegendElement::focus): Ditto.

  • html/HTMLLegendElement.h:

(HTMLLegendElement): Ditto.

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::dispatchFocusEvent): Ditto.

  • html/HTMLSelectElement.h:

(HTMLSelectElement): Ditto.

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::defaultFocus):
Add FocusDirection argument in order to pass it from
HTMLInputElement::focus() to HTMLTextFormControlElement::focus().
(WebCore::HTMLInputElement::focus):
Pass the FocusDirection argument to InputType::focus. See above.
(WebCore::HTMLInputElement::handleFocusEvent):
Adjust FocusDirection argument.

  • html/HTMLInputElement.h:

(HTMLInputElement):

  • html/InputType.cpp:

(WebCore::InputType::focus): Add FocusDirection argument.

  • html/InputType.h:

(InputType): Ditto.

  • html/BaseMultipleFieldsDateAndTimeInputType.cpp:

(WebCore::BaseMultipleFieldsDateAndTimeInputType::focus):
Add FocusDirection argument to follow InputType.

  • html/BaseMultipleFieldsDateAndTimeInputType.h:

(BaseMultipleFieldsDateAndTimeInputType): Ditto.

10:02 PM Changeset in webkit [141737] by morrita@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, marking terminate-during-sync-operation.html as timing out.

  • platform/chromium/TestExpectations:
9:59 PM Changeset in webkit [141736] by commit-queue@webkit.org
  • 16 edits in trunk/Source/WebKit

Fix build warning after r141473
https://bugs.webkit.org/show_bug.cgi?id=108782

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-03
Reviewed by Kentaro Hara.

Fix -Wunused-parameter build warning.

Source/WebKit/blackberry:

  • WebCoreSupport/EditorClientBlackBerry.cpp:

(WebCore::EditorClientBlackBerry::getClientPasteboardDataForRange):

Source/WebKit/chromium:

  • src/EditorClientImpl.cpp:

(WebKit::EditorClientImpl::getClientPasteboardDataForRange):

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.cpp:

(WebCore::EditorClientEfl::getClientPasteboardDataForRange):

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.cpp:

(WebKit::EditorClient::getClientPasteboardDataForRange):

Source/WebKit/qt:

  • WebCoreSupport/EditorClientQt.cpp:

(WebCore::EditorClientQt::getClientPasteboardDataForRange):

Source/WebKit/win:

  • WebCoreSupport/WebEditorClient.cpp:

(WebEditorClient::getClientPasteboardDataForRange):

Source/WebKit/wince:

  • WebCoreSupport/EditorClientWinCE.cpp:

(WebKit::EditorClientWinCE::getClientPasteboardDataForRange):

Source/WebKit/wx:

  • WebKitSupport/EditorClientWx.cpp:

(WebCore::EditorClientWx::getClientPasteboardDataForRange):

9:11 PM Changeset in webkit [141735] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk/Source/WebCore

Adds usage instrumentation for indexedDB
Includes new header file in project files

https://bugs.webkit.org/show_bug.cgi?id=107772

Patch by Kassy Coan <kassycoan@chromium.org> on 2013-02-03
Reviewed by Tony Chang.

Currently untestable. Has zero effect apart from histogramming.

  • GNUmakefile.list.am:
  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
(WebCore::IDBDatabase::transaction):

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):

  • Modules/indexeddb/IDBHistograms.h: Added.

(WebCore):

  • Target.pri:
  • WebCore.gypi:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.xcodeproj/project.pbxproj:
8:54 PM Changeset in webkit [141734] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Unreviewed. Add dstockwell as a contributor in comitters.py and to the watchlist for animation
https://bugs.webkit.org/show_bug.cgi?id=108777

Patch by Douglas Stockwell <dstockwell@chromium.org> on 2013-02-03

  • Scripts/webkitpy/common/config/committers.py:
  • Scripts/webkitpy/common/config/watchlist:
8:53 PM Changeset in webkit [141733] by hayato@chromium.org
  • 8 edits
    2 adds in trunk/Source/WebCore

Split default style-sheet statics out from StyleResolver into its own class
https://bugs.webkit.org/show_bug.cgi?id=107780

Reviewed by Dimitri Glazkov.

Factored static variables and logic about default style sheets out from StyleResolver into its own class
CSSDefaultStyleSheets. This is a following patch after r141373.

No new tests, refactoring only.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.gypi:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSAllInOne.cpp:
  • css/CSSDefaultStyleSheets.cpp: Added.

(WebCore):
(WebCore::elementCanUseSimpleDefaultStyle):
(WebCore::screenEval):
(WebCore::printEval):
(WebCore::parseUASheet):
(WebCore::CSSDefaultStyleSheets::initDefaultStyle):
(WebCore::CSSDefaultStyleSheets::loadFullDefaultStyle):
(WebCore::CSSDefaultStyleSheets::loadSimpleDefaultStyle):
(WebCore::CSSDefaultStyleSheets::viewSourceStyle):
(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

  • css/CSSDefaultStyleSheets.h: Added.

(WebCore):
(CSSDefaultStyleSheets):

  • css/StyleResolver.cpp:

(WebCore):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
(WebCore::StyleResolver::collectFeatures):
(WebCore::StyleResolver::reportMemoryUsage):

8:27 PM FeatureFlags edited by tkent@chromium.org
Rename CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED to … (diff)
8:25 PM Changeset in webkit [141732] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix build warning after r141648
https://bugs.webkit.org/show_bug.cgi?id=108784

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-03
Reviewed by Kentaro Hara.

Fix -Wunused-parameter build warning.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::createStorageArea):
(WebKit::StorageManager::destroyStorageArea):

8:04 PM Changeset in webkit [141731] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] Do not call m_widgetClient->show() for WebHelperPlugin.
https://bugs.webkit.org/show_bug.cgi?id=108740

Patch by David Dorwin <ddorwin@chromium.org> on 2013-02-03
Reviewed by Kent Tamura.

The calls to m_widgetClient->show() and setFocus() do not appear to be
necessary, and the former causes problems on at least on platform.

  • src/WebHelperPluginImpl.cpp:

(WebKit::WebHelperPluginImpl::initialize): Removed calls to m_widgetClient->show() and setFocus().
(WebKit::WebHelperPluginImpl::setFocus): Should never be called.

7:22 PM Changeset in webkit [141730] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Simplify CodeGeneratorV8.pm by using InheritsExtendedAttribute("EventTarget")
https://bugs.webkit.org/show_bug.cgi?id=108441

Reviewed by Adam Barth.

A complicated condition in GetInternalFields() can be simplified
by using InheritsExtendedAttribute("EventTarget").

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GetInternalFields):

  • dom/EventTarget.idl: Added [EventTarget] which should have been added.
  • svg/SVGElementInstance.idl: Ditto.
7:09 PM Changeset in webkit [141729] by weinig@apple.com
  • 2 edits in trunk/Tools

Fix failing test.

  • TestWebKitAPI/Tests/WebKit2/ShouldGoToBackForwardListItem.cpp:

(TestWebKitAPI::didFinishLoadForFrame):

6:55 PM Changeset in webkit [141728] by morrita@google.com
  • 1 edit
    1 add in trunk/LayoutTests

[Chromium] Unreviewed rebaselining.

  • platform/chromium-mac-lion/fast/css/resize-corner-tracking-transformed-iframe-expected.png: Added.
6:16 PM Changeset in webkit [141727] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore

[Soup] Do not use local variables for the client
https://bugs.webkit.org/show_bug.cgi?id=108714

Reviewed by Martin Robinson.

Covered by existing tests, refactoring code only.

We have had problems in the past with the client being destroyed or
changed inside a method or function, and we ended up with a stale
pointer, leading to crashes. This refactoring is an effort to minimize
the possibility of hitting that same issue in the future.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::redirectSkipCallback): no longer use a local variable to hold
the client.
(WebCore::wroteBodyDataCallback): ditto.
(WebCore::nextMultipartResponsePartCallback): ditto.
(WebCore::sendRequestCallback): ditto.
(WebCore::closeCallback): ditto.
(WebCore::readCallback): ditto.

6:15 PM Changeset in webkit [141726] by morrita@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, marking grid-preferred-logical-widths.html as a fail.

  • platform/chromium/TestExpectations:
5:54 PM Changeset in webkit [141725] by morrita@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, marking block-test.html as a fail.

  • platform/chromium/TestExpectations:
5:37 PM Changeset in webkit [141724] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[chromium] Skip editing/inserting/smart-link-when-caret-is-moved-before-URL.html
https://bugs.webkit.org/show_bug.cgi?id=85463

Test added in http://trac.webkit.org/changeset/141618 - requires that DRT or WKTR
implement setAutomaticLinkDetectionEnabled().

Unreviewed gardening.

  • platform/chromium/TestExpectations:
5:03 PM Changeset in webkit [141723] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Make ChangeLogEntry detect annotations by prepare-ChangeLog (Added/Removed/Copied from/Renamed from) as clean.
https://bugs.webkit.org/show_bug.cgi?id=108433

Patch by Timothy Loh <timloh@chromium.com> on 2013-02-03
Reviewed by Eric Seidel.

PrepareChangeLog is supposed to update the file/function list if we
haven't touched it, but the existing regex doesn't handle the
annotations prepare-ChangeLog adds (e.g. "Added.")

  • Scripts/webkitpy/common/checkout/changelog.py:

(ChangeLogEntry.is_touched_files_text_clean):

  • Scripts/webkitpy/common/checkout/changelog_unittest.py:

(test_is_touched_files_text_clean):

4:47 PM Changeset in webkit [141722] by tkent@chromium.org
  • 3 edits in trunk/LayoutTests

calendar-picker-key-operations.html is failing
https://bugs.webkit.org/show_bug.cgi?id=108566

Reviewed by Kentaro Hara.

  • platform/chromium/TestExpectations:
  • platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:

Month.createFromDate supports only UTC Date. Use the Month constructor
with local year and local month.

4:43 PM Changeset in webkit [141721] by haraken@chromium.org
  • 18 edits in trunk/Source/WebCore

[V8] Pass an Isolate to HasInstance() (part 1)
https://bugs.webkit.org/show_bug.cgi?id=108617

Reviewed by Adam Barth.

This is one of efforts to pass an Isolate to GetTemplate().

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(JSValueToNative):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::Float64ArrayV8Internal::fooCallback):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::TestActiveDOMObjectV8Internal::excitingFunctionCallback):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::TestEventTargetV8Internal::dispatchEventCallback):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
(WebCore::TestInterfaceV8Internal::supplementalMethod2Callback):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::voidMethodWithArgsCallback):
(WebCore::TestObjV8Internal::longMethodWithArgsCallback):
(WebCore::TestObjV8Internal::objMethodWithArgsCallback):
(WebCore::TestObjV8Internal::methodThatRequiresAllArgsAndThrowsCallback):
(WebCore::TestObjV8Internal::overloadedMethod1Callback):
(WebCore::TestObjV8Internal::overloadedMethod2Callback):
(WebCore::TestObjV8Internal::overloadedMethod8Callback):
(WebCore::TestObjV8Internal::convert1Callback):
(WebCore::TestObjV8Internal::convert2Callback):
(WebCore::TestObjV8Internal::convert4Callback):
(WebCore::TestObjV8Internal::convert5Callback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::constructor1Callback):
(WebCore::V8TestOverloadedConstructors::constructor2Callback):
(WebCore::V8TestOverloadedConstructors::constructor3Callback):

  • bindings/v8/Dictionary.cpp:

(WebCore::Dictionary::get):

  • bindings/v8/ScriptProfiler.cpp:

(WebCore::ScriptProfiler::visitNodeWrappers):

  • bindings/v8/SerializedScriptValue.cpp:

(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::deserialize):

  • bindings/v8/V8Binding.cpp:

(WebCore::toDOMStringList):
(WebCore::toXPathNSResolver):

  • bindings/v8/V8Binding.h:

(WebCore):

  • bindings/v8/V8Collection.cpp:

(WebCore::toOptionsCollectionSetter):

  • bindings/v8/V8GCController.cpp:

(WebCore::WrapperVisitor::WrapperVisitor):
(WrapperVisitor):
(WebCore::V8GCController::majorGCPrologue):

  • bindings/v8/V8NPObject.cpp:

(WebCore::npObjectInvokeImpl):

  • bindings/v8/V8Utilities.cpp:

(WebCore::extractTransferables):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):

4:01 PM Changeset in webkit [141720] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[GTK] Make distcheck fails
https://bugs.webkit.org/show_bug.cgi?id=108756

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2013-02-03
Reviewed by Kentaro Hara.

Source/WebCore:

  • GNUmakefile.list.am: Remove header files which no longer exist;

correct one which got added incorrectly.

Source/WebKit2:

  • GNUmakefile.list.am: Remove header files which no longer exist
3:53 PM Changeset in webkit [141719] by haraken@chromium.org
  • 5 edits in trunk/Source/WebCore

[V8] Pass an Isolate to HasInstance() (part 3)
https://bugs.webkit.org/show_bug.cgi?id=108622

Reviewed by Adam Barth.

This is one of efforts to pass an Isolate to GetTemplate().

No tests. No change in behavior.

  • bindings/v8/custom/V8InjectedScriptHostCustom.cpp:

(WebCore::V8InjectedScriptHost::isHTMLAllCollectionCallback):
(WebCore::V8InjectedScriptHost::typeCallback):
(WebCore::V8InjectedScriptHost::getEventListenersCallback):

  • bindings/v8/custom/V8NodeCustom.cpp:

(WebCore::V8Node::insertBeforeCallback):
(WebCore::V8Node::replaceChildCallback):
(WebCore::V8Node::removeChildCallback):
(WebCore::V8Node::appendChildCallback):

  • bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:

(WebCore::toWebGLUniformLocation):
(WebCore::V8WebGLRenderingContext::getAttachedShadersCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::V8WebGLRenderingContext::getUniformCallback):
(WebCore::vertexAttribAndUniformHelperf):
(WebCore::uniformHelperi):
(WebCore::uniformMatrixHelper):

  • bindings/v8/custom/V8XMLHttpRequestCustom.cpp:

(WebCore::isDocumentType):
(WebCore::V8XMLHttpRequest::sendCallback):

3:26 PM Changeset in webkit [141718] by haraken@chromium.org
  • 13 edits in trunk/Source/WebCore

[V8] Pass an Isolate to HasInstance() (part 2)
https://bugs.webkit.org/show_bug.cgi?id=108620

Reviewed by Adam Barth.

This is one of efforts to pass an Isolate to GetTemplate().

No tests. No change in behavior.

  • bindings/v8/custom/V8ArrayBufferViewCustom.h:

(WebCore::constructWebGLArray):
(WebCore::setWebGLArrayHelper):

  • bindings/v8/custom/V8AudioBufferSourceNodeCustom.cpp:

(WebCore::V8AudioBufferSourceNode::bufferAccessorSetter):

  • bindings/v8/custom/V8BlobCustom.cpp:

(WebCore::V8Blob::constructorCallbackCustom):

  • bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:

(WebCore::toCanvasStyle):
(WebCore::V8CanvasRenderingContext2D::strokeStyleAccessorSetter):

  • bindings/v8/custom/V8ClipboardCustom.cpp:

(WebCore::V8Clipboard::setDragImageCallback):

  • bindings/v8/custom/V8CryptoCustom.cpp:

(WebCore::V8Crypto::getRandomValuesCallback):

  • bindings/v8/custom/V8DOMFormDataCustom.cpp:

(WebCore::V8DOMFormData::constructorCallbackCustom):
(WebCore::V8DOMFormData::appendCallback):

  • bindings/v8/custom/V8DataViewCustom.cpp:

(WebCore::V8DataView::constructorCallbackCustom):

  • bindings/v8/custom/V8DocumentCustom.cpp:

(WebCore::V8Document::evaluateCallback):

  • bindings/v8/custom/V8HTMLMediaElementCustom.cpp:

(WebCore::V8HTMLMediaElement::controllerAccessorSetter):

  • bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:

(WebCore::V8HTMLOptionsCollection::addCallback):

  • bindings/v8/custom/V8HTMLSelectElementCustom.cpp:

(WebCore::removeElement):

10:35 AM Changeset in webkit [141717] by mkwst@chromium.org
  • 2 edits in trunk/Source/WebCore

Cleanup: 'ExceptionCode& ec', not 'ExceptionCode &ec'.
https://bugs.webkit.org/show_bug.cgi?id=108769

Reviewed by Eric Seidel.

Does what it says on the tin: reference parameters should read
'type& name', and this patch fixes the two occurances of 'type &name'
that cropped up for ExceptionCode.

Pure style change; no effect on behavior.

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):

5:37 AM Changeset in webkit [141716] by akling@apple.com
  • 8 edits in trunk/Source

Vector should consult allocator about ideal size when choosing capacity.
<http://webkit.org/b/108410>
<rdar://problem/13124002>

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

Remove assertion about Vector capacity that won't hold anymore since capacity()
may not be what you passed to reserveCapacity().
Also export WTF::fastMallocGoodSize() for Windows builds.

  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

Source/WTF:

Added WTF::fastMallocGoodSize(), a workalike/wrapper for OS X's malloc_good_size().
It returns the actual size of the block that will get allocated for a given byte size.

Vector's internal buffer now checks with the allocator if the resulting allocation
could actually house more objects and updates its capacity to make use of the space.

  • wtf/Deque.h:

(WTF::::expandCapacity):

  • wtf/FastMalloc.cpp:

(WTF::fastMallocGoodSize):

  • wtf/FastMalloc.h:
  • wtf/Vector.h:

(WTF::VectorBufferBase::allocateBuffer):
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::VectorBufferBase::reallocateBuffer):

4:17 AM Changeset in webkit [141715] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Mark inspector/debugger/source-frame-count.html as flaky
https://bugs.webkit.org/show_bug.cgi?id=108768

Unreviewed EFL gardening.

Mark inspector/debugger/source-frame-count.html as flaky as it sometimes
crashes due to Bug 81574.

Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-03

  • platform/efl-wk2/TestExpectations:
2:48 AM Changeset in webkit [141714] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Mark a few more media tests as flaky due to gstreamer 1.0
https://bugs.webkit.org/show_bug.cgi?id=108765

Unreviewed EFL gardening.

Mark 2 more media tests as flaky since the update to gstreamer 1.0.
They sometimes crash in MediaPlayerPrivateGStreamer dtor.

Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-03

  • platform/efl/TestExpectations:
2:42 AM Changeset in webkit [141713] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

[EFL] svg/custom/text-ctm.svg needs a baseline
https://bugs.webkit.org/show_bug.cgi?id=108764

Unreviewed EFL gardening.

Add baseline for svg/custom/text-ctm.svg that was added in r17879.

Patch by Christophe Dumez <dchris@gmail.com> on 2013-02-03

  • platform/efl/svg/custom/text-ctm-expected.png: Added.
  • platform/efl/svg/custom/text-ctm-expected.txt: Added.

Feb 2, 2013:

10:12 PM Changeset in webkit [141712] by Michael Nordman
  • 4 edits in trunk/Source

[chromium] FileSystem mods: Changes to snapshot file creation to reduce dependencies on blobs.
This patch just alters the WebKitAPI in advance of coding to the new API in chromium and webkit
sources, defining two new virtual methods (unimplemented and uncalled). The existing API remains
in place and in use.
https://bugs.webkit.org/show_bug.cgi?id=108736

Reviewed by Darin Fisher.

Source/Platform:

  • chromium/public/WebFileSystem.h:

(WebFileSystem):
(WebKit::WebFileSystem::createSnapshotFileAndReadMetadata):

Source/WebKit/chromium:

  • public/WebFileSystemCallbacks.h:

(WebFileSystemCallbacks):
(WebKit::WebFileSystemCallbacks::didCreateSnapshotFile):

5:14 PM Changeset in webkit [141711] by weinig@apple.com
  • 24 edits in trunk/Source/WebKit2

Remove more LegacyReceivers
https://bugs.webkit.org/show_bug.cgi?id=108758

Reviewed by Anders Carlsson.

  • UIProcess/Downloads/DownloadProxy.cpp:
  • UIProcess/Downloads/DownloadProxy.messages.in:
  • UIProcess/WebApplicationCacheManagerProxy.cpp:
  • UIProcess/WebApplicationCacheManagerProxy.h:

(WebApplicationCacheManagerProxy):

  • UIProcess/WebApplicationCacheManagerProxy.messages.in:
  • UIProcess/WebCookieManagerProxy.cpp:
  • UIProcess/WebCookieManagerProxy.h:

(WebCookieManagerProxy):

  • UIProcess/WebCookieManagerProxy.messages.in:
  • UIProcess/WebDatabaseManagerProxy.cpp:
  • UIProcess/WebDatabaseManagerProxy.h:

(WebDatabaseManagerProxy):

  • UIProcess/WebDatabaseManagerProxy.messages.in:
  • UIProcess/mac/RemoteLayerTreeHost.h:

(RemoteLayerTreeHost):

  • UIProcess/mac/RemoteLayerTreeHost.messages.in:
  • UIProcess/mac/RemoteLayerTreeHost.mm:
  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
  • WebProcess/ApplicationCache/WebApplicationCacheManager.h:

(WebApplicationCacheManager):

  • WebProcess/ApplicationCache/WebApplicationCacheManager.messages.in:
  • WebProcess/Cookies/WebCookieManager.cpp:
  • WebProcess/Cookies/WebCookieManager.h:

(WebCookieManager):

  • WebProcess/Cookies/WebCookieManager.messages.in:
  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
  • WebProcess/WebCoreSupport/WebDatabaseManager.h:

(WebDatabaseManager):

  • WebProcess/WebCoreSupport/WebDatabaseManager.messages.in:
5:11 PM Changeset in webkit [141710] by weinig@apple.com
  • 10 edits in trunk/Source/WebKit2

Convert CustomProtocolManagerProxy, CustomProtocolManager and AuthenticationManager to be non-LegacyReceivers
https://bugs.webkit.org/show_bug.cgi?id=108757

Reviewed by Anders Carlsson.

  • Shared/Authentication/AuthenticationManager.cpp:
  • Shared/Authentication/AuthenticationManager.h:

(AuthenticationManager):

  • Shared/Authentication/AuthenticationManager.messages.in:
  • Shared/Network/CustomProtocols/CustomProtocolManager.h:

(CustomProtocolManager):

  • Shared/Network/CustomProtocols/CustomProtocolManager.messages.in:
  • Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
  • UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:

(CustomProtocolManagerProxy):

  • UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.messages.in:
  • UIProcess/Network/CustomProtocols/mac/CustomProtocolManagerProxyMac.mm:
4:14 PM Changeset in webkit [141709] by Christophe Dumez
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Use C API inside ewk_file_chooser_request
https://bugs.webkit.org/show_bug.cgi?id=107811

Reviewed by Sam Weinig.

Use C API inside ewk_file_chooser_request instead of
accessing the internal C++ classes directly, to
avoid violating API layering.

  • UIProcess/API/efl/ewk_file_chooser_request.cpp:

(EwkFileChooserRequest::EwkFileChooserRequest):
(EwkFileChooserRequest::~EwkFileChooserRequest):
(EwkFileChooserRequest::allowMultipleFiles):
(EwkFileChooserRequest::acceptedMIMETypes):
(EwkFileChooserRequest::cancel):
(EwkFileChooserRequest::chooseFiles):
(ewk_file_chooser_request_accepted_mimetypes_get):
(ewk_file_chooser_request_files_choose):
(ewk_file_chooser_request_file_choose):

  • UIProcess/API/efl/ewk_file_chooser_request_private.h:

(EwkFileChooserRequest::create):
(EwkFileChooserRequest):

  • UIProcess/efl/PageUIClientEfl.cpp:

(WebKit::PageUIClientEfl::runOpenPanel):

3:50 PM Changeset in webkit [141708] by weinig@apple.com
  • 10 edits in trunk/Source/WebKit2

Stop keeping a frame tree in the UIProcess
https://bugs.webkit.org/show_bug.cgi?id=81728

Reviewed by Oliver Hunt.

This patch removes the parent/child relationships of WebFrameProxys
in the UIProcess

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameCopyChildFrames):
(WKFrameGetParentFrame):

  • UIProcess/API/C/WKFrame.h:

Null out the implementations of WKFrameCopyChildFrames and WKFrameGetParentFrame,
but keep them around as their symbols are still needed for nightlies.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::WebFrameProxy):
(WebKit::WebFrameProxy::disconnect):

  • UIProcess/WebFrameProxy.h:

Remove parent/child connections.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCreateSubframe):
(WebKit::WebPageProxy::didRemoveFrameFromHierarchy):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::didSaveToPageCache):
(WebKit::WebFrameLoaderClient::didRestoreFromPageCache):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createSubframe):
Remove/Update messages that only served to update the parent/child connection.

3:01 PM Changeset in webkit [141707] by dino@apple.com
  • 2 edits in trunk/Tools

Add Antoine Quint to the list of committers
https://bugs.webkit.org/show_bug.cgi?id=108750

No review necessary.

  • Scripts/webkitpy/common/config/committers.py:
2:32 PM Changeset in webkit [141706] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Optimize some operations for float type in texture format conversions of WebGL
https://bugs.webkit.org/show_bug.cgi?id=107526

Patch by Jun Jiang <jun.a.jiang@intel.com> on 2013-02-02
Reviewed by Darin Adler.

Some small changes are made to optimize the operations for float type in the texture format conversion of WebGL to improve performance.

Already covered by current tests.

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore):

2:26 PM Changeset in webkit [141705] by weinig@apple.com
  • 5 edits in trunk/Source/WebKit2

Make it possible to modify the connection from ChildProcessProxy subclasses.

Reviewed by Anders Carlsson.

  • Shared/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::ChildProcessProxy):
(WebKit::ChildProcessProxy::didFinishLaunching):
(WebKit::ChildProcessProxy::clearConnection):
(WebKit::ChildProcessProxy::connectionWillOpen):
(WebKit::ChildProcessProxy::connectionWillClose):

  • Shared/ChildProcessProxy.h:

(ChildProcessProxy):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::connectionWillOpen):
(WebKit::WebProcessProxy::connectionWillClose):

  • UIProcess/WebProcessProxy.h:

(WebProcessProxy):

1:04 PM Changeset in webkit [141704] by Simon Fraser
  • 16 edits in trunk/Source/WebCore

Clean up the storage of dirty bits on nodes in the scrolling state tree
https://bugs.webkit.org/show_bug.cgi?id=108744

Reviewed by Sam Weinig.

ScrollingStateNode and its subclasses used different techniques for
tracking which properties changed. ScrollingStateNode tracked its layers
via a bool member and some layer-specific methods, but also had virtual
methods to allow subclasses to track properties via a bit mask.

Clean this up by having the base class store the bit mask, and use
enums to specify bits for the various properties. All properties are thus
tracked in the same way. Bits are read and written through non-virtual member
functions on ScrollingStateNode. All bit checking is done via hasChangedProperty().

  • page/scrolling/ScrollingStateFixedNode.cpp:

(WebCore::ScrollingStateFixedNode::ScrollingStateFixedNode): m_changedProperties is now on the base class.
(WebCore::ScrollingStateFixedNode::updateConstraints): Use setPropertyChanged()

  • page/scrolling/ScrollingStateFixedNode.h: Remove overrides that are no longer needed.
  • page/scrolling/ScrollingStateNode.cpp:

(WebCore::ScrollingStateNode::ScrollingStateNode): Initialize m_changedProperties,
m_scrollLayerDidChange no longer tracked separately.
(WebCore::ScrollingStateNode::cloneAndReset):

  • page/scrolling/ScrollingStateNode.h:

(WebCore::ScrollingStateNode::hasChangedProperties):
(WebCore::ScrollingStateNode::hasChangedProperty): Tests the bit.
(WebCore::ScrollingStateNode::resetChangedProperties): Set all bits to 0.
(WebCore::ScrollingStateNode::setPropertyChanged): Set the bit.
(WebCore::ScrollingStateNode::changedProperties): Private to discourage incorrect usage
(changeProperties() & foo).

  • page/scrolling/ScrollingStateScrollingNode.cpp:

(WebCore::ScrollingStateScrollingNode::ScrollingStateScrollingNode): Base class does the copying now.
(WebCore::ScrollingStateScrollingNode::setViewportRect): Use setPropertyChanged().
(WebCore::ScrollingStateScrollingNode::setContentsSize): Ditto.
(WebCore::ScrollingStateScrollingNode::setFrameScaleFactor): Etc.
(WebCore::ScrollingStateScrollingNode::setNonFastScrollableRegion):
(WebCore::ScrollingStateScrollingNode::setWheelEventHandlerCount):
(WebCore::ScrollingStateScrollingNode::setShouldUpdateScrollLayerPositionOnMainThread):
(WebCore::ScrollingStateScrollingNode::setHorizontalScrollElasticity):
(WebCore::ScrollingStateScrollingNode::setVerticalScrollElasticity):
(WebCore::ScrollingStateScrollingNode::setHasEnabledHorizontalScrollbar):
(WebCore::ScrollingStateScrollingNode::setHasEnabledVerticalScrollbar):
(WebCore::ScrollingStateScrollingNode::setHorizontalScrollbarMode):
(WebCore::ScrollingStateScrollingNode::setVerticalScrollbarMode):
(WebCore::ScrollingStateScrollingNode::setRequestedScrollPosition):
(WebCore::ScrollingStateScrollingNode::setScrollOrigin):

  • page/scrolling/ScrollingStateScrollingNode.h:

(ScrollingStateScrollingNode):

  • page/scrolling/ScrollingStateStickyNode.cpp:

(WebCore::ScrollingStateStickyNode::ScrollingStateStickyNode):
(WebCore::ScrollingStateStickyNode::updateConstraints):

  • page/scrolling/ScrollingStateStickyNode.h:
  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::commitNewTreeState):

  • page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::update):

  • page/scrolling/mac/ScrollingStateNodeMac.mm:

(WebCore::ScrollingStateNode::setScrollLayer):

  • page/scrolling/mac/ScrollingStateScrollingNodeMac.mm:

(WebCore::ScrollingStateScrollingNode::setCounterScrollingLayer):

  • page/scrolling/mac/ScrollingTreeFixedNode.mm:

(WebCore::ScrollingTreeFixedNode::update):

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNodeMac::update):

  • page/scrolling/mac/ScrollingTreeStickyNode.mm:

(WebCore::ScrollingTreeStickyNode::update):

1:03 PM Changeset in webkit [141703] by Simon Fraser
  • 12 edits in trunk/Source/WebCore

Fixed and sticky nodes have no nodeID set
https://bugs.webkit.org/show_bug.cgi?id=108734

Reviewed by Sam Weinig.

Push ScrollingNodeIDs onto scrolling nodes at construction time, and thereafter
treat them as readonly. Previously, only the root scrolling node would have a node ID.

Node IDs aren't actually used by the scrolling tree yet, but are useful for debugging.

Not testable since we only dump the scrolling state tree, not the scrolling
node tree in tests.

  • page/scrolling/ScrollingTree.cpp:

(WebCore::ScrollingTree::ScrollingTree): No longer create the root node here;
we can only create it when we know what its ID will be.
(WebCore::ScrollingTree::updateTreeFromStateNode): Create the root node if
necessary. Pass node IDs into create methods.

  • page/scrolling/ScrollingTreeNode.cpp:

(WebCore::ScrollingTreeNode::ScrollingTreeNode):

  • page/scrolling/ScrollingTreeNode.h:
  • page/scrolling/ScrollingTreeScrollingNode.cpp:

(WebCore::ScrollingTreeScrollingNode::ScrollingTreeScrollingNode):

  • page/scrolling/ScrollingTreeScrollingNode.h:
  • page/scrolling/mac/ScrollingTreeFixedNode.h:
  • page/scrolling/mac/ScrollingTreeFixedNode.mm:

(WebCore::ScrollingTreeFixedNode::create):
(WebCore::ScrollingTreeFixedNode::ScrollingTreeFixedNode):

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:

(WebCore::ScrollingTreeScrollingNode::create):
(WebCore::ScrollingTreeScrollingNodeMac::ScrollingTreeScrollingNodeMac):

  • page/scrolling/mac/ScrollingTreeStickyNode.h:
  • page/scrolling/mac/ScrollingTreeStickyNode.mm:

(WebCore::ScrollingTreeStickyNode::create):
(WebCore::ScrollingTreeStickyNode::ScrollingTreeStickyNode):

12:59 PM Changeset in webkit [141702] by Patrick Gansterer
  • 5 edits
    2 deletes in trunk

[CMake] Adopt the WinCE port to new CMake
https://bugs.webkit.org/show_bug.cgi?id=108754

Reviewed by Laszlo Gombos.

.:

Remove the entry point hack which isn't required in the new
CMake version with offical WindowsCE support.

  • Source/cmake/OptionsWindows.cmake:

Source/JavaScriptCore:

  • os-win32/WinMain.cpp: Removed.
  • shell/PlatformWinCE.cmake: Removed.

Tools:

  • WinCELauncher/CMakeLists.txt: Mark WinCELauncher

as WIN32 target to use the correct entry point.

12:55 PM Changeset in webkit [141701] by tasak@google.com
  • 3 edits
    2 adds in trunk

Making -webkit-image-set() the first value of background property causes crash.
https://bugs.webkit.org/show_bug.cgi?id=108409

Reviewed by Beth Dakin.

Source/WebCore:

CSSParser::addFillValue should use lval->isBaseValueList() instead
of lval->isValueList(). If lval is -webkit-image-set, rval is appended
to -webkit-image-set.

Test: fast/css/image-set-value-crash-in-fillImageSet.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::addFillValue):
If lval is not a value list, lval is initialized by using
CSSValueList::createCommaSeparated(). So we have to check whether
lval is created by CSSValueList::createCommaSeparated() or not.

LayoutTests:

  • fast/css/image-set-value-crash-in-fillImageSet-expected.txt: Added.
  • fast/css/image-set-value-crash-in-fillImageSet.html: Added.
12:25 PM Changeset in webkit [141700] by mrowe@apple.com
  • 5 edits in trunk/Source

<http://webkit.org/b/108745> WTF shouldn't use a script build phase to detect the presence of headers when the compiler can do it for us

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • DerivedSources.make: Remove an obsolete Makefile rule. This should have been removed when the use

of the generated file moved to WTF.

Source/WTF:

  • WTF.xcodeproj/project.pbxproj: Remove the script phase that used to generate a header file

containing information about whether certain header files exist on the system.

  • wtf/FastMalloc.cpp: Use Clang's has_include to detect whether the header exists before including it.
11:02 AM Changeset in webkit [141699] by ddkilzer@apple.com
  • 8 edits in trunk/Source

Upstream iOS FeatureDefines
<http://webkit.org/b/108753>

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:
  • ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
  • ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
  • FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO. Add PLATFORM_NAME variant to reduce future merge conflicts.

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
  • ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
  • FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO. Add PLATFORM_NAME variant to reduce future merge conflicts.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:
  • ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
  • ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
  • FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO. Add PLATFORM_NAME variant to reduce future merge conflicts.

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
  • ENABLE_DEVICE_ORIENTATION: Add iOS configurations.
  • ENABLE_PLUGIN_PROXY_FOR_VIDEO: Ditto.
  • FEATURE_DEFINES: Add ENABLE_PLUGIN_PROXY_FOR_VIDEO. Add PLATFORM_NAME variant to reduce future merge conflicts.
9:31 AM Changeset in webkit [141698] by ap@apple.com
  • 2 edits in trunk/Tools

One is not allowed to use commit-queue to make oneself a committer.

  • Scripts/webkitpy/common/config/committers.py: Rolled out r141693. Also, changed e-mail order for Yongjun Zhang, so that Bugzilla autocomplete works.
8:41 AM Changeset in webkit [141697] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer] Media tests fix after r141695.

Rubber-stamped by Martin Robinson.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::setPlaybinURL): Remove
both fragment and query string for file:// uris before loading.

8:12 AM Changeset in webkit [141696] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Build fix for WinCE after r141637.

  • platform/graphics/wince/ImageBufferWinCE.cpp:
8:00 AM Changeset in webkit [141695] by Philippe Normand
  • 4 edits in trunk/Source/WebCore

[GStreamer] webkitwebsrc is exposed to application-side
https://bugs.webkit.org/show_bug.cgi?id=108088

Reviewed by Martin Robinson.

Switch the webkitwebsrc to handle webkit+http(s) uris so it is now
explicit that this element is meant to be used preferrably inside
WebKit. This change is internal to the player.

No new tests, covered by existing http/tests/media tests.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::setPlaybinURL):
(WebCore):
(WebCore::MediaPlayerPrivateGStreamer::load):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

(MediaPlayerPrivateGStreamer):

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcGetProtocols):
(webKitWebSrcSetUri):

7:27 AM Changeset in webkit [141694] by Simon Hausmann
  • 2 edits in trunk/Source/WebCore

Unreviewed trivial prospective build fix for A17n disabled
configurations.

The dummy computed object attriute cache control functions need to be defined
as being member functions of AXObjectCache, because that's where they are
declared.

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::startCachingComputedObjectAttributesUntilTreeMutates):
(WebCore::AXObjectCache::stopCachingComputedObjectAttributes):

6:09 AM Changeset in webkit [141693] by Antoine Quint
  • 2 edits in trunk/Tools

Add Antoine Quint to the list of committers
https://bugs.webkit.org/show_bug.cgi?id=108750

Reviewed by Dean Jackson.

  • Scripts/webkitpy/common/config/committers.py:
5:55 AM Changeset in webkit [141692] by Antoine Quint
  • 3 edits in trunk/Source/WebCore

Creating a WebInspector.ContextMenu without an event crashes WebCore when calling .show()
https://bugs.webkit.org/show_bug.cgi?id=108636

Reviewed by Pavel Feldman.

Return early if InspectorFrontendHost::showContextMenu() is called without an event and
assert in ContextMenuController::createContextMenu() in case no event was provided.

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::showContextMenu):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::createContextMenu):

5:05 AM Changeset in webkit [141691] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Improper initialization of ANGLEResources
https://bugs.webkit.org/show_bug.cgi?id=101489

Patch by Jonathan Feldstein <jfeldstein@rim.com> on 2013-02-02
Reviewed by Antonio Gomes.

MaxDrawBuffers, OES_standard_derivatives, OES_EGL_image_external and ARB_texture_rectangle have already been initialized through ShBuiltInResources function and these fields do not need to be set again in GraphicsContext3dBlackBerry.cpp. In addition, the extension flags cannot be set to true without getExtension having been called (Khronos WebGL specs, section 5.14.14.). Thus these lines need to be removed.

  • platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:

(WebCore::GraphicsContext3D::GraphicsContext3D):

4:54 AM Changeset in webkit [141690] by vivek.vg@samsung.com
  • 2 edits in trunk/Source/WebCore

Web Inspector: Refactor InspectorDOMStorageAgent::getDOMStorageEntries to report the error messages
https://bugs.webkit.org/show_bug.cgi?id=108611

Reviewed by Pavel Feldman.

Added reporting of various error messages. Moved the modification of output
parameter at a later stage when there are no errors reported.

No new tests as code refactoring.

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::hadException):
(WebCore):
(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):

3:58 AM Changeset in webkit [141689] by commit-queue@webkit.org
  • 5 edits in trunk

Web Inspector: fix bug in highlighting single chars via highlightRange API of DTE
https://bugs.webkit.org/show_bug.cgi?id=108685

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-02
Reviewed by Pavel Feldman.

Source/WebCore:

Use Math.min instead of Math.max in rangesForLine method.

Updated test: text-editor-highlight-api.html

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.RangeHighlightDescriptor.prototype.rangesForLine):

LayoutTests:

Updated layout test to cover specific bug case.

  • inspector/editor/text-editor-highlight-api-expected.txt:
  • inspector/editor/text-editor-highlight-api.html:
1:43 AM Changeset in webkit [141688] by zandobersek@gmail.com
  • 3 edits
    1 add in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/TestExpectations:
  • platform/gtk/svg/custom/text-ctm-expected.txt:
  • platform/gtk/svg/repaint/svgsvgelement-repaint-children-expected.txt: Added.
1:01 AM Changeset in webkit [141687] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

[Qt][WK2] Unreviewed buildfix after r141648.

  • DerivedSources.pri:
12:25 AM Changeset in webkit [141686] by tonyg@chromium.org
  • 5 edits in trunk/Source/WebCore

Continue making XSSAuditor thread safe: Remove unsafe AtomicString compares
https://bugs.webkit.org/show_bug.cgi?id=108557

Reviewed by Adam Barth.

Unfortunately HTMLNames comparisons will always be false on a non-main thread
with our current design, so we have to use some "threadSafeMatch" helpers written
for the HTMLBackgroundParser.

Also factor out threadSafeMatch() methods to HTMLParserIdioms.

No new tests because no new functionality.

  • html/parser/BackgroundHTMLParser.cpp:

(WebCore):

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::threadSafeEqual):
(WebCore):
(WebCore::threadSafeMatch):

  • html/parser/HTMLParserIdioms.h:

(WebCore):

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::eraseAttributeIfInjected):

12:04 AM Changeset in webkit [141685] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Follow-up to r141682. Adding build targets for the files that should be generated from the new message.in file.

Unreviewed.

  • GNUmakefile.list.am:

Feb 1, 2013:

11:40 PM Changeset in webkit [141684] by simonjam@chromium.org
  • 10 edits in trunk/Source

Add didChangePriority() to ResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=107995

Reviewed by Darin Fisher.

Source/Platform:

  • chromium/public/WebURLLoader.h:

(WebKit):
(WebURLLoader):
(WebKit::WebURLLoader::didChangePriority): Added.

Source/WebCore:

For PLT, it's important that preloads remain a lower priority than parser requested resources.
This can lead to a 5% improvement.

The plan is to use this plumbing to expose the desired behavior. This patch simply allows a
resource's priority to change and have it propagate to the network layer. An upcoming patch will
lower the priority of preloads and then increase the priority when the parser officially requests
it.

No new tests. No visible change, because priority doesn't change yet.

  • loader/cache/CachedResource.cpp:

(WebCore):
(WebCore::CachedResource::setLoadPriority):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource): Allow loads to modify priority.

  • loader/cache/CachedResourceRequest.h:

(WebCore::CachedResourceRequest::setPriority): Notify when priority changes.

  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::didChangePriority): Added.
(WebCore):

  • platform/network/ResourceHandle.h:

(ResourceHandle):

  • platform/network/chromium/ResourceHandle.cpp:

(WebCore::ResourceHandleInternal::didChangePriority):
(WebCore):
(WebCore::ResourceHandle::didChangePriority):

  • platform/network/chromium/ResourceHandleInternal.h:

(ResourceHandleInternal):

10:26 PM Changeset in webkit [141683] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Building fails in an armv5tel board
https://bugs.webkit.org/show_bug.cgi?id=108083

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2013-02-01
Reviewed by Martin Robinson.

In some systems in which $architecture is filled-in from "uname -m"
the value may not start with "arm-", but with "armvN", where "N" is
an architecture version number. The regexp in isARM() is modified
so it covers these kind of cases.

  • Scripts/webkitdirs.pm:

(isARM):

10:18 PM Changeset in webkit [141682] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r141648.

  • GNUmakefile.am: Add UIProcess/Storage to the list of paths that

should be searched for *.messages.in files.

7:57 PM Changeset in webkit [141681] by mhahnenberg@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Structure::m_enumerationCache should be moved to StructureRareData
https://bugs.webkit.org/show_bug.cgi?id=108723

Reviewed by Oliver Hunt.

m_enumerationCache is only used by objects whose properties are iterated over, so not every Structure needs this
field and it can therefore be moved safely to StructureRareData to help with memory savings.

  • runtime/JSPropertyNameIterator.h:

(JSPropertyNameIterator):
(JSC::Register::propertyNameIterator):
(JSC::StructureRareData::enumerationCache): Add to JSPropertyNameIterator.h so that it can see the correct type.
(JSC::StructureRareData::setEnumerationCache): Ditto.

  • runtime/Structure.cpp:

(JSC::Structure::addPropertyWithoutTransition): Use the enumerationCache() getter rather than accessing the field.
(JSC::Structure::removePropertyWithoutTransition): Ditto.
(JSC::Structure::visitChildren): We no longer have to worry about marking the m_enumerationCache field.

  • runtime/Structure.h:

(JSC::Structure::setEnumerationCache): Move the old accessors back since we don't have to have any knowledge of
the JSPropertyNameIterator type.
(JSC::Structure::enumerationCache): Ditto.

  • runtime/StructureRareData.cpp:

(JSC::StructureRareData::visitChildren): Mark the new m_enumerationCache field.

  • runtime/StructureRareData.h: Add new functions/fields.

(StructureRareData):

7:40 PM Changeset in webkit [141680] by commit-queue@webkit.org
  • 6 edits
    1 move
    5 adds
    1 delete in trunk/LayoutTests

Rebaseline tests after bug 9221
https://bugs.webkit.org/show_bug.cgi?id=108712

Unreviewed rebaseline of test expectations.

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-01

  • fast/css/resize-corner-tracking-expected.txt: Renamed from LayoutTests/platform/mac/fast/css/resize-corner-tracking-expected.txt.
  • platform/chromium-mac-lion/fast/css/resize-corner-tracking-expected.png:
  • platform/chromium-mac-lion/fast/css/resize-corner-tracking-transformed-iframe-expected.txt: Added.
  • platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-expected.png:
  • platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-iframe-expected.png: Added.
  • platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-iframe-expected.txt: Added.
  • platform/chromium-mac/fast/css/resize-corner-tracking-expected.png:
  • platform/chromium-mac/fast/css/resize-corner-tracking-transformed-iframe-expected.png:
  • platform/chromium-mac/fast/css/resize-corner-tracking-transformed-iframe-expected.txt: Added.
  • platform/chromium-win/fast/css/resize-corner-tracking-transformed-iframe-expected.png: Added.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/css/resize-corner-tracking-expected.txt: Removed.
6:54 PM Changeset in webkit [141679] by roger_fong@apple.com
  • 6 edits
    1 delete in trunk/Source/WebCore

Unreviewed. Clean up WebCore VS2010 project.

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.vcxproj/WebCoreCommon.props:
  • WebCore.vcxproj/WebCoreGenerated.make:
  • WebCore.vcxproj/WebCorePreLink.cmd: Removed.
  • WebCore.vcxproj/build-generated-files.sh:
6:53 PM Changeset in webkit [141678] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Don't use deprecated method -[NSImage dissolveToPoint:fraction:]
<rdar://problem/11723792>
https://bugs.webkit.org/show_bug.cgi?id=108739

Reviewed by Anders Carlsson.

  • platform/mac/DragImageMac.mm:

(WebCore::dissolveDragImageToFraction):
Remove use of deprecated NSImage methods and simplify a bit.

6:51 PM Changeset in webkit [141677] by roger_fong@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Unreviewed. JavaScriptCore VS2010 project cleanup.

6:48 PM Changeset in webkit [141676] by roger_fong@apple.com
  • 3 edits
    1 delete in trunk/Source/WTF

Unreviewed. WTF VS2010 project cleanup.

  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
  • WTF.vcxproj/WTFPreLink.cmd: Removed.
6:36 PM Changeset in webkit [141675] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r180221. Requested by
"Nico Weber" <thakis@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01

  • DEPS:
6:35 PM Changeset in webkit [141674] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r141662.
http://trac.webkit.org/changeset/141662
https://bugs.webkit.org/show_bug.cgi?id=108738

it's an incorrect change since processPhiStack will
dereference dangling BasicBlock pointers (Requested by pizlo
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parse):

6:17 PM Changeset in webkit [141673] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: fix "DOM Exception 8" when deleting lines containing decoration in DTE.
https://bugs.webkit.org/show_bug.cgi?id=108689

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-01
Reviewed by Alexander Pavlov.

Add a check that decoration element is still added to the line before trying to delete it. This
won't be true if the whole line is deleted in contentEditable,
and this is the reason for the exception to be thrown.

No new tests.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainChunk.prototype.removeAllDecorations):

6:16 PM Changeset in webkit [141672] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Update LayoutTests scripts to skip webgl folder on ports
https://bugs.webkit.org/show_bug.cgi?id=108705

Patch by Gregg Tavares <gman@google.com> on 2013-02-01
Reviewed by Dirk Pranke.

I'm working on checking in the WebGL Conformance Tests
as layout tests into LayoutTests/webgl. For ports
that do not have WebGL enabled this changes will
skip tests in the "webgl" folder.

  • Scripts/webkitpy/layout_tests/port/base.py:

(Port._missing_symbol_to_skipped_tests):

  • Scripts/webkitpy/layout_tests/port/port_testcase.py:

(PortTestCase.test_skipped_directories_for_symbols):

5:35 PM Changeset in webkit [141671] by roger_fong@apple.com
  • 3 edits in trunk/Tools

Unreviewed. Fix for webkitpy tests.

  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

  • Scripts/webkitpy/tool/steps/runtests_unittest.py:
5:27 PM Changeset in webkit [141670] by leviw@chromium.org
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r141669.
http://trac.webkit.org/changeset/141669
https://bugs.webkit.org/show_bug.cgi?id=108728

Broke the windows build. (Requested by leviw on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):

  • rendering/RenderBoxModelObject.h:

(RenderBoxModelObject):

5:10 PM Changeset in webkit [141669] by eae@chromium.org
  • 3 edits in trunk/Source/WebCore

Remove duplicate code in RenderBoxModelObject::computedCSSPadding*
https://bugs.webkit.org/show_bug.cgi?id=108707

Reviewed by Levi Weintraub.

The computedCSSPaddingTop/Bottom/... methods in
RenderBoxModelObject all do pretty much exactly the same thing
yet share no code.

Break out shared code into computedCSSPadding method and have
the top/bottom/left/right/... ones call it with the appropriate
length value.

No new tests, no change in functionality.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::computedCSSPadding):

  • rendering/RenderBoxModelObject.h:

(WebCore::RenderBoxModelObject::computedCSSPaddingTop):
(WebCore::RenderBoxModelObject::computedCSSPaddingBottom):
(WebCore::RenderBoxModelObject::computedCSSPaddingLeft):
(WebCore::RenderBoxModelObject::computedCSSPaddingRight):
(WebCore::RenderBoxModelObject::computedCSSPaddingBefore):
(WebCore::RenderBoxModelObject::computedCSSPaddingAfter):
(WebCore::RenderBoxModelObject::computedCSSPaddingStart):
(WebCore::RenderBoxModelObject::computedCSSPaddingEnd):
(RenderBoxModelObject):

5:05 PM Changeset in webkit [141668] by mark.lam@apple.com
  • 14 edits in trunk/Source/WebCore

Replace ExceptionCode with DatabaseError in the openDatabase() code path.
https://bugs.webkit.org/show_bug.cgi?id=108724.

Reviewed by Alexey Proskuryakov.

Also made DatabaseBackend::performOpenAndVerify() a little more
straightforward and less repetitive.

No new tests.

  • Modules/webdatabase/DOMWindowWebDatabase.cpp:

(WebCore::DOMWindowWebDatabase::openDatabase):

  • Modules/webdatabase/Database.cpp:

(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::performOpenAndVerify):

  • Modules/webdatabase/Database.h:

(Database):

  • Modules/webdatabase/DatabaseBackend.cpp:

(WebCore::DoneCreatingDatabaseOnExitCaller::DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
(DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::openSucceeded):
(WebCore::DatabaseBackend::performOpenAndVerify):

  • Modules/webdatabase/DatabaseBackend.h:
  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::openDatabaseSync):

  • Modules/webdatabase/DatabaseManager.h:

(DatabaseManager):

  • Modules/webdatabase/DatabaseSync.cpp:

(WebCore::DatabaseSync::openAndVerifyVersion):

  • Modules/webdatabase/DatabaseSync.h:

(DatabaseSync):

  • Modules/webdatabase/DatabaseTask.cpp:

(WebCore::Database::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::Database::DatabaseOpenTask::doPerformTask):

  • Modules/webdatabase/DatabaseTask.h:

(WebCore::Database::DatabaseOpenTask::create):
(Database::DatabaseOpenTask):

  • Modules/webdatabase/WorkerContextWebDatabase.cpp:

(WebCore::WorkerContextWebDatabase::openDatabase):
(WebCore::WorkerContextWebDatabase::openDatabaseSync):

  • WebCore.gypi:
4:58 PM Changeset in webkit [141667] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Document is never released if an image's src attribute is changed to a url blocked by content-security-policy.
https://bugs.webkit.org/show_bug.cgi?id=108545

Source/WebCore:

If we just scheduled an error event due to an null newImage, we should not cancel it when newImage and oldImage
is not the same. Otherwise we will ref the sourceElement in updateHasPendingEvent (m_hasPendingErrorEvent is true)
but never deref it since we already cancelled the error event.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-02-01
Reviewed by Alexey Proskuryakov.

Test: fast/images/image-error-event-not-firing.html

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement): don't cancel error event if newImage is null, we want the

error event to fire.

LayoutTests:

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-02-01
Reviewed by Alexey Proskuryakov.

Add a test to verify the error event is fired when image's src attribute is changed to a url
but the url blocked by content-security-policy.

  • fast/images/image-error-event-not-firing-expected.txt: Added.
  • fast/images/image-error-event-not-firing.html: Added.
4:51 PM Changeset in webkit [141666] by jer.noble@apple.com
  • 2 edits in trunk/Tools

LLDB: add synthetic provider for WTF::HashTable
https://bugs.webkit.org/show_bug.cgi?id=108718

Reviewed by Darin Adler.

Add a synthetic provider which will emit the contents of a given
WTF::HashTable. This allows clients using Xcode/lldb to enumerate
the hash contents.

  • lldb/lldb_webkit.py:

(lldb_init_module):
(
lldb_init_module.lldb_webkit):
(WTFHashTable_SummaryProvider):
(WTFVectorProvider.has_children):
(WTFHashTableProvider):
(WTFHashTableProvider.init):
(WTFHashTableProvider.num_children):
(WTFHashTableProvider.get_child_index):
(WTFHashTableProvider.get_child_at_index):
(WTFHashTableProvider.tableSize):
(WTFHashTableProvider.keyCount):
(WTFHashTableProvider.update):
(WTFHashTableProvider.has_children):

4:51 PM Changeset in webkit [141665] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r141648

Needs to add StorageManager.messages.in to CMakeLists.txt.

  • CMakeLists.txt:
4:50 PM Changeset in webkit [141664] by fmalita@chromium.org
  • 2 edits
    3 copies
    3 adds in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Rebaseline after http://trac.webkit.org/changeset/141634

  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-dynamic-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt.
  • platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • platform/chromium-win/platform/chromium/virtual/softwarecompositing/visibility/visibility-image-layers-dynamic-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt.
  • platform/chromium-win/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Copied from LayoutTests/platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt.
4:33 PM Changeset in webkit [141663] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Build fix for CustomProtocolManagerMac after r141658.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-01

  • Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

(WebKit::CustomProtocolManager::supplementName): I accidentally typed "const" twice twice.

4:26 PM Changeset in webkit [141662] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Eliminate dead blocks sooner in the DFG::ByteCodeParser to make clear that you don't need to hold onto them during Phi construction
https://bugs.webkit.org/show_bug.cgi?id=108717

Reviewed by Mark Hahnenberg.

I think this makes the code clearer. It doesn't change behavior.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parse):

4:25 PM Changeset in webkit [141661] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

The assertions in updateLayerPositionsAfterScroll were commented out in r141278, so stop
expecting http/tests/inspector/resource-har-pages.html to assert in debug builds.
(see https://bugs.webkit.org/show_bug.cgi?id=103432).

  • platform/mac/TestExpectations:
4:19 PM Changeset in webkit [141660] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r180186. Requested by
"Nico Weber" <thakis@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01

  • DEPS:
4:14 PM Changeset in webkit [141659] by ojan@chromium.org
  • 5 edits
    3 deletes in trunk/LayoutTests

Make svg-fonts-in-text-controls.html have the same results across platforms
https://bugs.webkit.org/show_bug.cgi?id=108676

Reviewed by Dirk Pranke.

Mac uses a different default font-size for form controls and Windows
uses different padding for textareas/inputs. Override these so
this test doesn't need platform specific expectations.

  • platform/chromium/TestExpectations:
  • platform/gtk/svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
  • platform/qt/svg/custom/svg-fonts-in-text-controls-expected.png: Removed.
  • platform/qt/svg/custom/svg-fonts-in-text-controls-expected.txt: Removed.
  • svg/custom/script-tests/svg-fonts-in-text-controls.js:
  • svg/custom/svg-fonts-in-text-controls-expected.txt:
  • svg/custom/svg-fonts-in-text-controls.html:

These dummy elements aren't needed anymore. js-test-pre.js inserts them.

4:10 PM Changeset in webkit [141658] by benjamin@webkit.org
  • 42 edits in trunk/Source/WebKit2

[WK2] Use light supplement names instead of static AtomicStrings
https://bugs.webkit.org/show_bug.cgi?id=108570

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-01
Reviewed by Anders Carlsson.

Since all the supplement names are just string literals and are all different,
we can just use their pointer as the key in the supplement hashmaps.

This is lighter and faster than using AtomicString. WebCore already moved to this
in Supplementable.

  • NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::addSupplement):
(NetworkProcess):

  • Shared/Authentication/AuthenticationManager.cpp:

(WebKit::AuthenticationManager::supplementName):

  • Shared/Authentication/AuthenticationManager.h:

(AuthenticationManager):

  • Shared/Network/CustomProtocols/CustomProtocolManager.h:

(CustomProtocolManager):

  • Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

(WebKit::CustomProtocolManager::supplementName):

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::supplementName):

  • UIProcess/Notifications/WebNotificationManagerProxy.h:

(WebNotificationManagerProxy):

  • UIProcess/WebApplicationCacheManagerProxy.cpp:

(WebKit::WebApplicationCacheManagerProxy::supplementName):

  • UIProcess/WebApplicationCacheManagerProxy.h:

(WebApplicationCacheManagerProxy):

  • UIProcess/WebContext.h:

(WebContext):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::supplementName):

  • UIProcess/WebCookieManagerProxy.h:

(WebCookieManagerProxy):

  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::supplementName):

  • UIProcess/WebDatabaseManagerProxy.h:

(WebDatabaseManagerProxy):

  • UIProcess/WebGeolocationManagerProxy.cpp:

(WebKit::WebGeolocationManagerProxy::supplementName):

  • UIProcess/WebGeolocationManagerProxy.h:

(WebGeolocationManagerProxy):

  • UIProcess/WebKeyValueStorageManagerProxy.cpp:

(WebKit::WebKeyValueStorageManagerProxy::supplementName):

  • UIProcess/WebKeyValueStorageManagerProxy.h:

(WebKeyValueStorageManagerProxy):

  • UIProcess/WebMediaCacheManagerProxy.cpp:

(WebKit::WebMediaCacheManagerProxy::supplementName):

  • UIProcess/WebMediaCacheManagerProxy.h:

(WebMediaCacheManagerProxy):

  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::supplementName):

  • UIProcess/WebResourceCacheManagerProxy.h:

(WebResourceCacheManagerProxy):

  • UIProcess/soup/WebSoupRequestManagerProxy.cpp:

(WebKit::WebSoupRequestManagerProxy::supplementName):

  • UIProcess/soup/WebSoupRequestManagerProxy.h:

(WebSoupRequestManagerProxy):

  • WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:

(WebKit::WebApplicationCacheManager::supplementName):

  • WebProcess/ApplicationCache/WebApplicationCacheManager.h:

(WebApplicationCacheManager):

  • WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::supplementName):

  • WebProcess/Cookies/WebCookieManager.h:

(WebCookieManager):

  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::supplementName):

  • WebProcess/Geolocation/WebGeolocationManager.h:

(WebGeolocationManager):

  • WebProcess/MediaCache/WebMediaCacheManager.cpp:

(WebKit::WebMediaCacheManager::supplementName):

  • WebProcess/MediaCache/WebMediaCacheManager.h:

(WebMediaCacheManager):

  • WebProcess/Notifications/WebNotificationManager.cpp:

(WebKit::WebNotificationManager::supplementName):

  • WebProcess/Notifications/WebNotificationManager.h:

(WebNotificationManager):

  • WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::supplementName):

  • WebProcess/ResourceCache/WebResourceCacheManager.h:

(WebResourceCacheManager):

  • WebProcess/Storage/WebKeyValueStorageManager.cpp:

(WebKit::WebKeyValueStorageManager::supplementName):

  • WebProcess/Storage/WebKeyValueStorageManager.h:

(WebKeyValueStorageManager):

  • WebProcess/WebCoreSupport/WebDatabaseManager.cpp:

(WebKit::WebDatabaseManager::supplementName):

  • WebProcess/WebCoreSupport/WebDatabaseManager.h:

(WebDatabaseManager):

  • WebProcess/WebProcess.h:

(WebKit::WebProcess::addSupplement):
(WebProcess):

3:59 PM Changeset in webkit [141657] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[Chromium] WebWidget::selectionBounds should return the bounds in document space
https://bugs.webkit.org/show_bug.cgi?id=108386

Patch by Chris Hopman <cjhopman@chromium.org> on 2013-02-01
Reviewed by James Robinson.

When in applyPageScaleFactorInCompositor mode, selectionBounds needs
to scale the anchor/focus window points by the pageScaleFactor.

  • src/WebViewImpl.cpp:

(WebKit::WebViewImpl::selectionBounds):
(WebKit::WebViewImpl::computeScaleAndScrollForFocusedNode):

3:55 PM Changeset in webkit [141656] by benjamin@webkit.org
  • 14 edits in trunk

Clean the String->AtomicString conversion for AnimationController::pauseAnimationAtTime
https://bugs.webkit.org/show_bug.cgi?id=108558

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-01
Reviewed by Dean Jackson.

.:

  • Source/autotools/symbols.filter:

Source/WebCore:

This is a step torward killing the implicit conversion from String to AtomicString.

The animation name are AtomicString. The API is changed all the way to the callers
to take an AtomicString. When needed, we use explicit conversion.

  • WebCore.exp.in:
  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::pauseAnimationAtTime):
(WebCore::AnimationController::pauseAnimationAtTime):

  • page/animation/AnimationController.h:

(AnimationController):

  • page/animation/AnimationControllerPrivate.h:

(AnimationControllerPrivate):

  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::pauseAnimationAtTime):
We should not null check the name. Getting a null name from the HashMap would be
an error from the tests, and the HashMap would never return a value anyway.

  • testing/Internals.cpp:

(WebCore::Internals::pauseAnimationAtTimeOnPseudoElement):

Source/WebKit2:

  • WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:

(WKBundleFramePauseAnimationOnElementWithId):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::pauseAnimationOnElementWithId):

  • WebProcess/WebPage/WebFrame.h:

(WebFrame):

3:50 PM Changeset in webkit [141655] by dmazzoni@google.com
  • 9 edits in trunk/Source

AX: memoize expensive computation during blocks where tree doesn't change
https://bugs.webkit.org/show_bug.cgi?id=106497

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add a cache for computed attributes of AXObjects.
The cache can be enabled at the start of a batch of
read-only operations on the accessibility tree, and
it's cleared automatically when the tree mutates.
Currently accessibilityIsIgnored is cached, since it's
frequently called and relatively expensive to compute.

No new tests.

  • accessibility/AXObjectCache.cpp:

(WebCore):
(WebCore::AXComputedObjectAttributeCache::getIgnored):
(WebCore::AXComputedObjectAttributeCache::setIgnored):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::nodeTextChangeNotification):
(WebCore::AXObjectCache::handleScrollbarUpdate):
(WebCore::AXObjectCache::startCachingComputedObjectAttributesUntilTreeMutates):
(WebCore::AXObjectCache::stopCachingComputedObjectAttributes):

  • accessibility/AXObjectCache.h:

(AXComputedObjectAttributeCache):
(WebCore::AXComputedObjectAttributeCache::create):
(WebCore::AXComputedObjectAttributeCache::AXComputedObjectAttributeCache):
(WebCore::AXComputedObjectAttributeCache::CachedAXObjectAttributes::CachedAXObjectAttributes):
(CachedAXObjectAttributes):
(WebCore):
(WebCore::AXObjectCache::computedObjectAttributeCache):
(AXObjectCache):
(WebCore::AXComputedObjectAttributeCache::getIgnored):
(WebCore::AXComputedObjectAttributeCache::setIgnored):
(WebCore::startCachingComputedObjectAttributesUntilTreeMutates):
(WebCore::stopCachingComputedObjectAttributes):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::findMatchingObjects):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore):
(WebCore::AccessibilityRenderObject::accessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

Source/WebKit/chromium:

Expose two methods to enable and disable caching of
computed WebAccessibilityObject attributes, to speed up
batch read-only operations.

  • public/WebAccessibilityObject.h:

(WebAccessibilityObject):

  • src/WebAccessibilityObject.cpp:

(WebKit::WebAccessibilityObject::startCachingComputedObjectAttributesUntilTreeMutates):
(WebKit):
(WebKit::WebAccessibilityObject::stopCachingComputedObjectAttributes):

3:46 PM Changeset in webkit [141654] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • Modules/webdatabase/DatabaseBackend.cpp: (DoneCreatingDatabaseOnExitCaller): Don't fail because of an unused member variable in cross-plaform code path.
3:30 PM Changeset in webkit [141653] by fsamuel@chromium.org
  • 3 edits in trunk/Source/WebKit/chromium

[Chromium] Expose WebNode::shadowHost()
https://bugs.webkit.org/show_bug.cgi?id=108681

Reviewed by Dimitri Glazkov.

BrowserPlugin needs to be able to check the event listeners attached to
<webview> and so we expose shadowHost to permit it to poke at the webview
node.

  • public/WebNode.h:
  • src/WebNode.cpp:

(WebKit::WebNode::shadowHost):
(WebKit):

3:23 PM Changeset in webkit [141652] by commit-queue@webkit.org
  • 5 edits in trunk/Source

[chromium] Fat scrollbars on Windows in high-DPI mode.
https://bugs.webkit.org/show_bug.cgi?id=108637

Updates mechanism for retrieving scrollbar metrics on the
Windows port of Chromium. Previously, GetSystemMetrics calls
were used, which fetches prescaled sizes in pixel rather than
logical units, resulting in a double scaling when a device
scale factor is set. With the patch, the size is retrieved
from the theme engine in DIP.

Patch by Kevin Ellis <kevers@chromium.org> on 2013-02-01
Reviewed by Adam Barth.

Source/Platform:

  • chromium/public/win/WebThemeEngine.h:

(WebThemeEngine):

Source/WebCore:

No new tests.

  • platform/chromium/ScrollbarThemeChromiumWin.cpp:

(WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
(WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):

  • rendering/RenderThemeChromiumWin.cpp:

(WebCore):
(WebCore::menuListButtonWidth):

3:10 PM Changeset in webkit [141651] by mhahnenberg@apple.com
  • 18 edits
    3 adds in trunk/Source/JavaScriptCore

Structure should have a StructureRareData field to save space
https://bugs.webkit.org/show_bug.cgi?id=108659

Reviewed by Oliver Hunt.

Many of the fields in Structure are used in a subset of all total Structures; however, all Structures must
pay the memory cost of those fields, regardless of whether they use them or not. Since we can have potentially
many Structures on a single page (e.g. bing.com creates ~1500 Structures), it would be profitable to
refactor Structure so that not every Structure has to pay the memory costs for these infrequently used fields.

To accomplish this, we can create a new StructureRareData class to house these seldom used fields which we
can allocate on demand whenever a Structure requires it. This StructureRareData can itself be a JSCell, and
can do all the marking of the fields for the Structure. The StructureRareData field will be part of a union
with m_previous to minimize overhead. We'll add a new field to JSTypeInfo to indicate that the Structure has
a StructureRareData field. During transitions, a Structure will clone its previous Structure's StructureRareData
if it has one. There could be some potential for optimizing this process, but the initial implementation will
be dumb since we'd be paying these overhead costs for each Structure anyways.

Initially we'll only put two fields in the StructureRareData to avoid a memory regression. Over time we'll
continue to move fields from Structure to StructureRareData. Optimistically, this could potentially reduce our
Structure memory footprint by up to around 75%. It could also clear the way for removing destructors from
Structures (and into StructureRareData).

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGRepatch.cpp: Includes for linking purposes.
  • jit/JITStubs.cpp:
  • jsc.cpp:
  • llint/LLIntSlowPaths.cpp:
  • runtime/JSCellInlines.h: Added ifdef guards.
  • runtime/JSGlobalData.cpp: New Structure for StructureRareData class.

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/JSGlobalObject.h:
  • runtime/JSTypeInfo.h: New flag to indicate whether or not a Structure has a StructureRareData field.

(JSC::TypeInfo::flags):
(JSC::TypeInfo::structureHasRareData):

  • runtime/ObjectPrototype.cpp:
  • runtime/Structure.cpp: We use a combined WriteBarrier<JSCell> field m_previousOrRareData to avoid compiler issues.

(JSC::Structure::dumpStatistics):
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::pin):
(JSC::Structure::allocateRareData): Handles allocating a brand new StructureRareData field.
(JSC::Structure::cloneRareDataFrom): Handles cloning a StructureRareData field from another. Used during Structure
transitions.
(JSC::Structure::visitChildren): We no longer have to worry about marking m_objectToStringValue.

  • runtime/Structure.h:

(JSC::Structure::previousID): Checks the structureHasRareData flag to see where it should get the previous Structure.
(JSC::Structure::objectToStringValue): Reads the value from the StructureRareData. If it doesn't exist, returns 0.
(JSC::Structure::setObjectToStringValue): Ensures that we have a StructureRareData field, then forwards the function
call to it.
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::setPreviousID): Checks for StructureRareData and forwards if necessary.
(Structure):
(JSC::Structure::clearPreviousID): Ditto.
(JSC::Structure::create):

  • runtime/StructureRareData.cpp: Added. All of the basic functionality of a JSCell with the fields that we've moved

from Structure and the functions required to access/modify those fields as Structure would have done.
(JSC):
(JSC::StructureRareData::createStructure):
(JSC::StructureRareData::create):
(JSC::StructureRareData::clone):
(JSC::StructureRareData::StructureRareData):
(JSC::StructureRareData::visitChildren):

  • runtime/StructureRareData.h: Added.

(JSC):
(StructureRareData):

  • runtime/StructureRareDataInlines.h: Added.

(JSC):
(JSC::StructureRareData::previousID):
(JSC::StructureRareData::setPreviousID):
(JSC::StructureRareData::clearPreviousID):
(JSC::Structure::previous): Handles the ugly casting to get the value of the right type of m_previousOrRareData.
(JSC::Structure::rareData): Ditto.
(JSC::StructureRareData::objectToStringValue):
(JSC::StructureRareData::setObjectToStringValue):

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Target.pri:
  • dfg/DFGRepatch.cpp:
  • jit/JITStubs.cpp:
  • jsc.cpp:
  • llint/LLIntSlowPaths.cpp:
  • runtime/JSCellInlines.h:
  • runtime/JSGlobalData.cpp:

(JSC::JSGlobalData::JSGlobalData):

  • runtime/JSGlobalData.h:

(JSGlobalData):

  • runtime/JSGlobalObject.h:
  • runtime/JSTypeInfo.h:

(JSC):
(JSC::TypeInfo::flags):
(JSC::TypeInfo::structureHasRareData):

  • runtime/ObjectPrototype.cpp:
  • runtime/Structure.cpp:

(JSC::Structure::dumpStatistics):
(JSC::Structure::Structure):
(JSC::Structure::materializePropertyMap):
(JSC::Structure::addPropertyTransition):
(JSC::Structure::nonPropertyTransition):
(JSC::Structure::pin):
(JSC::Structure::allocateRareData):
(JSC):
(JSC::Structure::cloneRareDataFrom):
(JSC::Structure::visitChildren):

  • runtime/Structure.h:

(JSC::Structure::previousID):
(JSC::Structure::objectToStringValue):
(JSC::Structure::setObjectToStringValue):
(JSC::Structure::materializePropertyMapIfNecessary):
(JSC::Structure::setPreviousID):
(Structure):
(JSC::Structure::clearPreviousID):
(JSC::Structure::previous):
(JSC::Structure::rareData):
(JSC::Structure::create):

  • runtime/StructureRareData.cpp: Added.

(JSC):
(JSC::StructureRareData::createStructure):
(JSC::StructureRareData::create):
(JSC::StructureRareData::clone):
(JSC::StructureRareData::StructureRareData):
(JSC::StructureRareData::visitChildren):

  • runtime/StructureRareData.h: Added.

(JSC):
(StructureRareData):

  • runtime/StructureRareDataInlines.h: Added.

(JSC):
(JSC::StructureRareData::previousID):
(JSC::StructureRareData::setPreviousID):
(JSC::StructureRareData::clearPreviousID):
(JSC::StructureRareData::objectToStringValue):
(JSC::StructureRareData::setObjectToStringValue):

3:03 PM Changeset in webkit [141650] by commit-queue@webkit.org
  • 4 edits in trunk

Source/WebKit/chromium: [Chromium] Ignore punctuation in spellcheck
https://bugs.webkit.org/show_bug.cgi?id=108511

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-01
Reviewed by Tony Chang.

  • src/ContextMenuClientImpl.cpp:

(WebKit::IsWhiteSpaceOrPunctuation): Added utility function to detect whitespace or punctuation.
(WebKit::selectMisspellingAsync): Ignore punctuation when selecting the misspelling.

LayoutTests: [Chromium] Expect spellcheck to ignore punctuation
https://bugs.webkit.org/show_bug.cgi?id=108511

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-01
Reviewed by Tony Chang.

  • platform/chromium/TestExpectations: Expect spellcheck to ignore punctuation.
3:03 PM Changeset in webkit [141649] by mark.lam@apple.com
  • 13 edits in trunk/Source/WebCore

Clean up calls to DatabaseTracker::add/removeOpenDatabase().
https://bugs.webkit.org/show_bug.cgi?id=108431

Reviewed by Geoffrey Garen.

Also adapted the chromium port to work with this new code.
Chromium parts reviewed by Michael Nordman and David Levin.

This is part of the webdatabase refactoring effort.

No new tests.

  • Modules/webdatabase/AbstractDatabaseServer.h:

(AbstractDatabaseServer):

  • Modules/webdatabase/Database.cpp:

(WebCore::Database::openAndVerifyVersion):
(WebCore::Database::close):

  • Modules/webdatabase/DatabaseBackend.cpp:

(WebCore::DatabaseBackend::DatabaseBackend):
(WebCore::DatabaseBackend::closeDatabase):
(DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::DoneCreatingDatabaseOnExitCaller):
(WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
(WebCore::DatabaseBackend::performOpenAndVerify):

  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::openDatabase):
(WebCore::DatabaseManager::openDatabaseSync):

  • Modules/webdatabase/DatabaseManager.h:

(DatabaseManager):

  • Modules/webdatabase/DatabaseServer.cpp:
  • Modules/webdatabase/DatabaseServer.h:
  • Modules/webdatabase/DatabaseSync.cpp:

(WebCore::DatabaseSync::~DatabaseSync):
(WebCore::DatabaseSync::openAndVerifyVersion):
(WebCore::DatabaseSync::closeImmediately):

  • Modules/webdatabase/DatabaseSync.h:

(DatabaseSync):

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::addOpenDatabase):

  • Modules/webdatabase/DatabaseTracker.h:

(DatabaseTracker):

  • Modules/webdatabase/chromium/DatabaseTrackerChromium.cpp:

(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::prepareToOpenDatabase):
(WebCore::DatabaseTracker::failedToOpenDatabase):

2:56 PM Changeset in webkit [141648] by andersca@apple.com
  • 7 edits
    1 add in trunk/Source/WebKit2

More work on UI side storage
https://bugs.webkit.org/show_bug.cgi?id=108700

Reviewed by Sam Weinig.

  • DerivedSources.make:

Add StorageManager.messages.in.

  • Platform/CoreIPC/HandleMessage.h:

(CoreIPC::callMemberFunction):
Add new overload.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::didReceiveMessageOnConnectionWorkQueue):
Call the right function.

(WebKit::StorageManager::createStorageArea):
(WebKit::StorageManager::destroyStorageArea):
Add stubs.

  • UIProcess/Storage/StorageManager.messages.in: Added.

Add new messages files.

  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/Storage/StorageAreaProxy.cpp:

(WebKit::StorageAreaProxy::~StorageAreaProxy):
Add another FIXME.

(WebKit::StorageAreaProxy::canAccessStorage):
(WebKit::StorageAreaProxy::incrementAccessCount):
(WebKit::StorageAreaProxy::decrementAccessCount):
Implement these.

2:55 PM Changeset in webkit [141647] by commit-queue@webkit.org
  • 5 edits in trunk

Web Inspector: remove extra padding around overlay highlight.
https://bugs.webkit.org/show_bug.cgi?id=108679

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-01
Reviewed by Alexander Pavlov.

Source/WebCore:

No new tests: no change in behaviour.

Remove extraWidth from overlay highlight spans.

  • inspector/front-end/DefaultTextEditor.js:

(WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):

LayoutTests:

Update layout test expectations to correspond to updated overlay highlight style.

  • inspector/editor/text-editor-highlight-api-expected.txt:
  • inspector/editor/text-editor-highlight-token-expected.txt:
2:46 PM Changeset in webkit [141646] by commit-queue@webkit.org
  • 2 edits in trunk/Websites/bugs.webkit.org

Allow prettify.rb to be run from any directory, and don't hard-code the system ruby path
https://bugs.webkit.org/show_bug.cgi?id=108569

Patch by Nathan de Vries <ndevries@apple.com> on 2013-02-01
Reviewed by Joseph Pecoraro.

  • PrettyPatch/prettify.rb:
2:38 PM Changeset in webkit [141645] by pdr@google.com
  • 8 edits
    3 adds in trunk

Prevent skipped repaints for children of inner SVG elements
https://bugs.webkit.org/show_bug.cgi?id=108429

Reviewed by Eric Seidel.

Source/WebCore:

This patch fixes a bug caused by r108699 and r133786 where we would not repaint children
of inner SVG elements because "m_didTransformToRootUpdate" was never reset on viewport
containers. The stale m_didTransformToRootUpdate variable caused us to skip child repaints.

I verified that the Robohornet SVG benchmark performance gains in r133786 are not regressed
with this patch.

Test: svg/repaint/svgsvgelement-repaint-children.html

  • rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::calcViewport):

This can be removed because setNeedsTransformUpdate() will set m_needsTransformUpdate.

(WebCore::RenderSVGViewportContainer::calculateLocalTransform):

This change is straightforward and is similar to the equivalent assignment in
RenderSVGTransformableContainer::calculateLocalTransform().

LayoutTests:

Need to update expectations for a single file (just a 1px difference).

  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • svg/repaint/svgsvgelement-repaint-children-expected.png: Added.
  • svg/repaint/svgsvgelement-repaint-children-expected.txt: Added.
  • svg/repaint/svgsvgelement-repaint-children.html: Added.
2:24 PM Changeset in webkit [141644] by pdr@google.com
  • 4 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening of two svg/zoom/page tests.

This change rebaselines two tests for WK108108.

Unreviewed update of test expectations.

  • platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
  • platform/chromium-mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
  • platform/chromium/TestExpectations:
2:10 PM Changeset in webkit [141643] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Fix webkitpy tests since a build_style is not specified in some cases.

  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

2:00 PM Changeset in webkit [141642] by fmalita@chromium.org
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed gardening.

Skip a test added in r14618 that uses setAutomaticLinkDetectionEnabled.

  • platform/chromium/TestExpectations:
2:00 PM Changeset in webkit [141641] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

offlineasm BaseIndex handling is broken on ARM due to MIPS changes
https://bugs.webkit.org/show_bug.cgi?id=108261

Patch by Balazs Kilvady <kilvadyb@homejinni.com> on 2013-02-01
Reviewed by Filip Pizlo.

offlineasm BaseIndex handling fix on MIPS.

  • offlineasm/mips.rb:
  • offlineasm/risc.rb:
1:56 PM Changeset in webkit [141640] by caio.oliveira@openbossa.org
  • 5 edits in trunk/Source/WebKit2

[Gtk] [WK2] Fix build after r141619
https://bugs.webkit.org/show_bug.cgi?id=108687

Reviewed by Benjamin Poulain.

Take a reference instead of a pointer for decoding functions.

  • Platform/gtk/SharedMemoryGtk.cpp:

(WebKit::SharedMemory::Handle::decode):

  • Shared/gtk/ArgumentCodersGtk.cpp:

(CoreIPC::decodeImage):
(CoreIPC::decodeDataObject):
(CoreIPC::::decode):
(CoreIPC::decodeGKeyFile):
(CoreIPC::decode):

  • Shared/gtk/ArgumentCodersGtk.h:
  • Shared/gtk/LayerTreeContextGtk.cpp:

(WebKit::LayerTreeContext::decode):

1:40 PM Changeset in webkit [141639] by caio.oliveira@openbossa.org
  • 10 edits in trunk/Source/WebKit2

[EFL] [WK2] Fix build after r141619
https://bugs.webkit.org/show_bug.cgi?id=108683

Reviewed by Benjamin Poulain.

Take a reference instead of a pointer for decoding functions.

  • Shared/WebBatteryStatus.cpp:

(WebKit::WebBatteryStatus::Data::decode):

  • Shared/WebBatteryStatus.h:

(Data):

  • Shared/WebNetworkInfo.cpp:

(WebKit::WebNetworkInfo::Data::decode):

  • Shared/WebNetworkInfo.h:

(Data):

  • Shared/cairo/LayerTreeContextCairo.cpp:

(WebKit::LayerTreeContext::decode):

  • Shared/efl/LayerTreeContextEfl.cpp:

(WebKit::LayerTreeContext::decode):

  • Shared/soup/PlatformCertificateInfo.cpp:

(WebKit::PlatformCertificateInfo::decode):

  • Shared/soup/PlatformCertificateInfo.h:

(PlatformCertificateInfo):

  • Shared/soup/WebCoreArgumentCodersSoup.cpp:

(CoreIPC::::decodePlatformData):

1:34 PM Changeset in webkit [141638] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Mac] Layout test fast/parser/parser-yield-timing.html is flaky on debug bots
https://bugs.webkit.org/show_bug.cgi?id=108677

Patch by David Farler <dfarler@apple.com> on 2013-02-01
Reviewed by Tim Horton.

  • platform/mac/TestExpectations:

Mark fast/parser/parser-yield-timing.html as [ Pass Failure ]

1:31 PM Changeset in webkit [141637] by pdr@google.com
  • 45 edits
    1 add in trunk

Change hasAlpha to isKnownToBeOpaque and correct the return value for SVG images.
https://bugs.webkit.org/show_bug.cgi?id=106966

Reviewed by Stephen White.

Source/WebCore:

Previously, Image::currentFrameHasAlpha's default implementation returned false so SVG
images always returned false for currentFrameHasAlpha. Additionally, currentFrameHasAlpha
was treated as returning whether the frame had alpha when it would actually conservatively
return true.

This patch renames hasAlpha and currentFrameHasAlpha to isKnownToBeOpaque and
currentFrameIsKnownToBeOpaque, respectively. This rename better describes the actual
functionality. This patch also makes Image::isKnownToBeOpaque a pure virtual function and
correctly implements it for SVG images.

All users of isKnownToBeOpaque access SVG images using CachedImage::imageForRenderer which
currently returns a cached bitmap image. Therefore, this patch will not affect existing
functionality. A regression test has been added that will catch if this changes in the
future (e.g., WK106159 which proposes not returning cached bitmaps). The now unnecessary
isBitmapImage() calls have been removed in this patch.

image-box-shadow.html has been modified to test SVG images.

  • css/CSSCrossfadeValue.cpp:

(WebCore::subimageKnownToBeOpaque):
(WebCore::CSSCrossfadeValue::knownToBeOpaque):

Mostly straightforward rename but note the logic has been slightly altered: AND -> OR.

  • css/CSSCrossfadeValue.h:

(CSSCrossfadeValue):

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::knownToBeOpaque):

  • css/CSSGradientValue.h:

(CSSGradientValue):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::knownToBeOpaque):

  • css/CSSImageGeneratorValue.h:

(CSSImageGeneratorValue):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::knownToBeOpaque):

  • css/CSSImageValue.h:

(CSSImageValue):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::currentFrameKnownToBeOpaque):

  • loader/cache/CachedImage.h:

(CachedImage):

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::currentFrameKnownToBeOpaque):

  • platform/graphics/BitmapImage.h:

(BitmapImage):

  • platform/graphics/GeneratedImage.h:

(GeneratedImage):

  • platform/graphics/Image.h:

Note: now a pure virtual function!

(Image):

  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::updateTextureContentsIfNeeded):

Removed unnecessary isBitmapImage() checks.

  • platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

Removed unnecessary isBitmapImage() checks.

  • platform/graphics/cg/PDFDocumentImage.h:

(PDFDocumentImage):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

Removed unnecessary isBitmapImage() checks.

(WebCore::GraphicsLayerChromium::setContentsToImage):

  • platform/graphics/qt/StillImageQt.cpp:

(WebCore::StillImage::currentFrameKnownToBeOpaque):

  • platform/graphics/qt/StillImageQt.h:

(StillImage):

  • platform/graphics/skia/BitmapImageSingleFrameSkia.cpp:

(WebCore::BitmapImageSingleFrameSkia::currentFrameKnownToBeOpaque):

  • platform/graphics/skia/BitmapImageSingleFrameSkia.h:

(BitmapImageSingleFrameSkia):

  • platform/graphics/texmap/TextureMapperBackingStore.cpp:

(WebCore::TextureMapperTile::updateContents):
(WebCore::TextureMapperTiledBackingStore::updateContents):

  • platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:

(WebCore::CoordinatedImageBacking::update):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::backgroundIsObscured):

Removed unnecessary isBitmapImage() checks and slightly reworked the logic.

  • rendering/style/FillLayer.cpp:

(WebCore::FillLayer::hasOpaqueImage):

  • rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::knownToBeOpaque):

  • rendering/style/StyleCachedImage.h:

(StyleCachedImage):

  • rendering/style/StyleCachedImageSet.cpp:

(WebCore::StyleCachedImageSet::knownToBeOpaque):

  • rendering/style/StyleCachedImageSet.h:

(StyleCachedImageSet):

  • rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::knownToBeOpaque):

  • rendering/style/StyleGeneratedImage.h:

(StyleGeneratedImage):

  • rendering/style/StyleImage.h:

(StyleImage):

  • rendering/style/StylePendingImage.h:

(WebCore::StylePendingImage::knownToBeOpaque):

  • svg/graphics/SVGImage.h:

(SVGImage):

Source/WebKit/chromium:

  • tests/DragImageTest.cpp:

(WebCore::TestImage::currentFrameKnownToBeOpaque):
(TestImage):

  • tests/ImageLayerChromiumTest.cpp:

(WebCore::TestImage::currentFrameKnownToBeOpaque):

  • tests/PlatformContextSkiaTest.cpp:

(WebCore::TEST):

Source/WebKit/win:

  • WebKit.vcproj/WebKitExports.def.in:

LayoutTests:

An SVG image has been added to this test to check for regressions.

  • fast/box-shadow/image-box-shadow-expected.html:
  • fast/box-shadow/image-box-shadow.html:

Add an SVG image and correct a small mistake in the test that used values of 256
instead of 255.

  • fast/box-shadow/resources/green.svg: Added.
1:26 PM Changeset in webkit [141636] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, GTK TestExpectations update.

  • platform/gtk/TestExpectations: Flag some new media tests

crashing until a fix is figured out.

1:18 PM Changeset in webkit [141635] by beidson@apple.com
  • 8 edits in trunk/Source

Clean up WebArchive loading with the NetworkProcess
<rdar://problem/12695840> and https://bugs.webkit.org/show_bug.cgi?id=108673

Reviewed by Alexey Proskuryakov.

Source/WebCore:

No new tests (No change in WebCore behavior).

Remove a now unneeded function and add a needed export.

  • WebCore.exp.in:
  • loader/ResourceLoadScheduler.cpp:
  • loader/ResourceLoadScheduler.h:

Source/WebKit2:

  • NetworkProcess/HostRecord.cpp:

(WebKit::HostRecord::servePendingRequestsForQueue): Add new logging.
(WebKit::HostRecord::servePendingRequests): Tweak existing logging.

  • NetworkProcess/NetworkResourceLoadScheduler.cpp:

(WebKit::NetworkResourceLoadScheduler::servePendingRequests): Tweak existing logging.

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::scheduleLoad): Handle archive resource scheduling better,

and add new logging to better explore archive loading behavior in the future.

1:16 PM Changeset in webkit [141634] by alokp@chromium.org
  • 405 edits in trunk

Print GraphicsLayer::m_contentsOpaque if non-default (true)
https://bugs.webkit.org/show_bug.cgi?id=108354

Reviewed by Simon Fraser.

Source/WebCore:

No new tests. This change facilitates testing of GraphicsLayer opaqueness.

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::dumpProperties):

LayoutTests:

  • compositing/absolute-inside-out-of-view-fixed-expected.txt:
  • compositing/backing/no-backing-for-clip-expected.txt:
  • compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • compositing/backing/no-backing-for-perspective-expected.txt:
  • compositing/bounds-in-flipped-writing-mode-expected.txt:
  • compositing/clip-child-by-non-stacking-ancestor-expected.txt:
  • compositing/columns/composited-in-paginated-expected.txt:
  • compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
  • compositing/filters/sw-nested-shadow-overlaps-hw-nested-shadow-expected.txt:
  • compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
  • compositing/filters/sw-shadow-overlaps-hw-shadow-expected.txt:
  • compositing/geometry/ancestor-overflow-change-expected.txt:
  • compositing/geometry/bounds-clipped-composited-child-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-dynamic-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • compositing/geometry/bounds-ignores-hidden-expected.txt:
  • compositing/geometry/clip-expected.txt:
  • compositing/geometry/clip-inside-expected.txt:
  • compositing/geometry/composited-in-columns-expected.txt:
  • compositing/geometry/fixed-position-composited-switch-expected.txt:
  • compositing/geometry/flipped-writing-mode-expected.txt:
  • compositing/geometry/foreground-layer-expected.txt:
  • compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
  • compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
  • compositing/geometry/limit-layer-bounds-clipping-ancestor-expected.txt:
  • compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-opacity-transition-expected.txt:
  • compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-expected.txt:
  • compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
  • compositing/geometry/preserve-3d-switching-expected.txt:
  • compositing/iframes/become-composited-nested-iframes-expected.txt:
  • compositing/iframes/become-overlapped-iframe-expected.txt:
  • compositing/iframes/composited-parent-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • compositing/iframes/connect-compositing-iframe-expected.txt:
  • compositing/iframes/connect-compositing-iframe2-expected.txt:
  • compositing/iframes/connect-compositing-iframe3-expected.txt:
  • compositing/iframes/enter-compositing-iframe-expected.txt:
  • compositing/iframes/iframe-resize-expected.txt:
  • compositing/iframes/iframe-size-from-zero-expected.txt:
  • compositing/iframes/invisible-nested-iframe-hide-expected.txt:
  • compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • compositing/iframes/overlapped-iframe-expected.txt:
  • compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • compositing/iframes/overlapped-nested-iframes-expected.txt:
  • compositing/iframes/page-cache-layer-tree-expected.txt:
  • compositing/iframes/scrolling-iframe-expected.txt:
  • compositing/images/clip-on-directly-composited-image-expected.txt:
  • compositing/layer-creation/animation-overlap-with-children-expected.txt:
  • compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
  • compositing/layer-creation/fixed-position-out-of-view-expected.txt:
  • compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
  • compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
  • compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • compositing/layer-creation/no-compositing-for-fixed-position-under-transform-expected.txt:
  • compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • compositing/layer-creation/overflow-scroll-overlap-expected.txt:
  • compositing/layer-creation/overlap-animation-clipping-expected.txt:
  • compositing/layer-creation/overlap-animation-container-expected.txt:
  • compositing/layer-creation/overlap-animation-expected.txt:
  • compositing/layer-creation/overlap-child-layer-expected.txt:
  • compositing/layer-creation/overlap-clipping-expected.txt:
  • compositing/layer-creation/overlap-transformed-3d-expected.txt:
  • compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
  • compositing/layer-creation/overlap-transformed-layer-expected.txt:
  • compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
  • compositing/layer-creation/overlap-transforms-expected.txt:
  • compositing/layer-creation/rotate3d-overlap-expected.txt:
  • compositing/layer-creation/scroll-partial-update-expected.txt:
  • compositing/layer-creation/spanOverlapsCanvas-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-expected.txt:
  • compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
  • compositing/layer-creation/translatez-overlap-expected.txt:
  • compositing/masks/mask-layer-size-expected.txt:
  • compositing/overflow-trumps-transform-style-expected.txt:
  • compositing/overflow/clip-descendents-expected.txt:
  • compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
  • compositing/overflow/content-gains-scrollbars-expected.txt:
  • compositing/overflow/content-loses-scrollbars-expected.txt:
  • compositing/overflow/overflow-auto-with-touch-expected.txt:
  • compositing/overflow/overflow-auto-with-touch-toggle-expected.txt:
  • compositing/overflow/overflow-overlay-with-touch-expected.txt:
  • compositing/overflow/overflow-scrollbar-layers-expected.txt:
  • compositing/overflow/resize-painting-expected.txt:
  • compositing/overflow/scrolling-content-clip-to-viewport-expected.txt:
  • compositing/overflow/scrolling-without-painting-expected.txt:
  • compositing/overflow/textarea-scroll-touch-expected.txt:
  • compositing/overflow/updating-scrolling-content-expected.txt:
  • compositing/plugins/no-backing-store-expected.txt:
  • compositing/plugins/small-to-large-composited-plugin-expected.txt:
  • compositing/repaint/invalidations-on-composited-layers-expected.txt:
  • compositing/repaint/resize-repaint-expected.txt:
  • compositing/rtl/rtl-absolute-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-expected.txt:
  • compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-fixed-expected.txt:
  • compositing/rtl/rtl-fixed-overflow-expected.txt:
  • compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-iframe-absolute-expected.txt:
  • compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
  • compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
  • compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
  • compositing/rtl/rtl-iframe-relative-expected.txt:
  • compositing/rtl/rtl-relative-expected.txt:
  • compositing/tiled-layers-hidpi-expected.txt:
  • compositing/tiling/backface-preserve-3d-tiled-expected.txt:
  • compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • compositing/tiling/huge-layer-expected.txt:
  • compositing/tiling/huge-layer-img-expected.txt:
  • compositing/tiling/huge-layer-resize-expected.txt:
  • compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • compositing/tiling/rotated-tiled-clamped-expected.txt:
  • compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
  • compositing/tiling/tile-cache-zoomed-expected.txt:
  • compositing/tiling/tiled-layer-resize-expected.txt:
  • compositing/visibility/layer-visible-content-expected.txt:
  • compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • compositing/visible-rect/2d-transformed-expected.txt:
  • compositing/visible-rect/3d-transform-style-expected.txt:
  • compositing/visible-rect/3d-transformed-expected.txt:
  • compositing/visible-rect/animated-expected.txt:
  • compositing/visible-rect/animated-from-none-expected.txt:
  • compositing/visible-rect/clipped-by-viewport-expected.txt:
  • compositing/visible-rect/clipped-visible-rect-expected.txt:
  • compositing/visible-rect/iframe-and-layers-expected.txt:
  • compositing/visible-rect/iframe-no-layers-expected.txt:
  • compositing/visible-rect/nested-transform-expected.txt:
  • compositing/visible-rect/scrolled-expected.txt:
  • css3/compositing/should-have-compositing-layer-expected.txt:
  • css3/filters/filtered-compositing-descendant-expected.txt:
  • platform/chromium-android/compositing/layer-creation/overflow-scrolling-touch-expected.txt:
  • platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/chromium-linux-x86/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-linux-x86/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/chromium-linux/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-linux/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-mac/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
  • platform/chromium-mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/chromium-mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/chromium-mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/chromium-mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • platform/chromium-mac/css3/filters/composited-during-animation-layertree-expected.txt:
  • platform/chromium-mac/css3/filters/composited-during-transition-layertree-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/scrolling-without-painting-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/textarea-scroll-touch-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/gpu/compositedscrolling/overflow/updating-scrolling-content-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/invalidations-on-composited-layers-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/softwarecompositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/chromium-mac/platform/chromium/virtual/threaded/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/chromium-win-xp/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium-win/compositing/backing/no-backing-for-clip-expected.txt:
  • platform/chromium-win/compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • platform/chromium-win/compositing/backing/no-backing-for-perspective-expected.txt:
  • platform/chromium-win/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/chromium-win/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • platform/chromium-win/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
  • platform/chromium-win/compositing/geometry/layer-due-to-layer-children-switch-expected.txt:
  • platform/chromium-win/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • platform/chromium-win/compositing/geometry/preserve-3d-switching-expected.txt:
  • platform/chromium-win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/chromium-win/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • platform/chromium-win/compositing/layer-creation/scroll-partial-update-expected.txt:
  • platform/chromium-win/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/chromium-win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/chromium-win/compositing/tiling/huge-layer-expected.txt:
  • platform/chromium-win/compositing/tiling/huge-layer-resize-expected.txt:
  • platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/chromium-win/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/chromium-win/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • platform/chromium-win/css3/filters/composited-during-animation-layertree-expected.txt:
  • platform/chromium-win/css3/filters/composited-during-transition-layertree-expected.txt:
  • platform/chromium/TestExpectations:
  • platform/chromium/compositing/backing/no-backing-for-clip-expected.txt:
  • platform/chromium/compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • platform/chromium/compositing/backing/no-backing-for-perspective-expected.txt:
  • platform/chromium/compositing/canvas/accelerated-canvas-compositing-expected.txt:
  • platform/chromium/compositing/columns/composited-in-paginated-expected.txt:
  • platform/chromium/compositing/filters/sw-layer-overlaps-hw-shadow-expected.txt:
  • platform/chromium/compositing/filters/sw-shadow-overlaps-hw-layer-expected.txt:
  • platform/chromium/compositing/force-compositing-mode/force-composite-empty-expected.txt:
  • platform/chromium/compositing/force-compositing-mode/no-overflow-iframe-layer-expected.txt:
  • platform/chromium/compositing/force-compositing-mode/overflow-hidden-iframe-layer-expected.txt:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-enter-compositing-expected.txt:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-layer-expected.txt:
  • platform/chromium/compositing/force-compositing-mode/overflow-iframe-leave-compositing-expected.txt:
  • platform/chromium/compositing/geometry/ancestor-overflow-change-expected.txt:
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/chromium/compositing/geometry/bounds-ignores-hidden-dynamic-negzindex-expected.txt:
  • platform/chromium/compositing/geometry/clip-expected.txt:
  • platform/chromium/compositing/geometry/clip-inside-expected.txt:
  • platform/chromium/compositing/geometry/composited-in-columns-expected.txt:
  • platform/chromium/compositing/geometry/fixed-position-composited-switch-expected.txt:
  • platform/chromium/compositing/geometry/flipped-writing-mode-expected.txt:
  • platform/chromium/compositing/geometry/foreground-layer-expected.txt:
  • platform/chromium/compositing/geometry/layer-due-to-layer-children-deep-switch-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-fixed-positioned-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-overflow-root-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-positioned-transition-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-transformed-expected.txt:
  • platform/chromium/compositing/geometry/limit-layer-bounds-transformed-overflow-expected.txt:
  • platform/chromium/compositing/geometry/preserve-3d-switching-expected.txt:
  • platform/chromium/compositing/iframes/become-composited-nested-iframes-expected.txt:
  • platform/chromium/compositing/iframes/become-overlapped-iframe-expected.txt:
  • platform/chromium/compositing/iframes/composited-parent-iframe-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe2-expected.txt:
  • platform/chromium/compositing/iframes/connect-compositing-iframe3-expected.txt:
  • platform/chromium/compositing/iframes/enter-compositing-iframe-expected.txt:
  • platform/chromium/compositing/iframes/iframe-resize-expected.txt:
  • platform/chromium/compositing/iframes/iframe-size-from-zero-expected.txt:
  • platform/chromium/compositing/iframes/invisible-nested-iframe-hide-expected.txt:
  • platform/chromium/compositing/iframes/overlapped-iframe-expected.txt:
  • platform/chromium/compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • platform/chromium/compositing/iframes/overlapped-nested-iframes-expected.txt:
  • platform/chromium/compositing/iframes/resizer-expected.txt:
  • platform/chromium/compositing/iframes/scrolling-iframe-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-out-of-view-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
  • platform/chromium/compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • platform/chromium/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • platform/chromium/compositing/layer-creation/overflow-scroll-overlap-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-animation-clipping-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-animation-container-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-animation-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-child-layer-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-clipping-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-transformed-3d-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-transformed-and-clipped-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-transformed-layer-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
  • platform/chromium/compositing/layer-creation/overlap-transforms-expected.txt:
  • platform/chromium/compositing/layer-creation/scroll-partial-update-expected.txt:
  • platform/chromium/compositing/layer-creation/spanOverlapsCanvas-expected.txt:
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-expected.txt:
  • platform/chromium/compositing/layer-creation/stacking-context-overlap-nested-expected.txt:
  • platform/chromium/compositing/layer-creation/translatez-overlap-expected.txt:
  • platform/chromium/compositing/overflow-trumps-transform-style-expected.txt:
  • platform/chromium/compositing/overflow/clip-descendents-expected.txt:
  • platform/chromium/compositing/overflow/content-gains-scrollbars-expected.txt:
  • platform/chromium/compositing/overflow/content-loses-scrollbars-expected.txt:
  • platform/chromium/compositing/overflow/overflow-scrollbar-layers-expected.txt:
  • platform/chromium/compositing/overflow/resize-painting-expected.txt:
  • platform/chromium/compositing/rtl/rtl-absolute-expected.txt:
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-expected.txt:
  • platform/chromium/compositing/rtl/rtl-absolute-overflow-scrolled-expected.txt:
  • platform/chromium/compositing/rtl/rtl-fixed-expected.txt:
  • platform/chromium/compositing/rtl/rtl-fixed-overflow-expected.txt:
  • platform/chromium/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/chromium/compositing/rtl/rtl-iframe-absolute-expected.txt:
  • platform/chromium/compositing/rtl/rtl-iframe-fixed-expected.txt:
  • platform/chromium/compositing/rtl/rtl-iframe-relative-expected.txt:
  • platform/chromium/compositing/rtl/rtl-relative-expected.txt:
  • platform/chromium/compositing/tiling/huge-layer-img-expected.txt:
  • platform/chromium/css3/filters/filtered-compositing-descendant-expected.txt:
  • platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/content-gains-scrollbars-expected.txt:
  • platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-auto-with-touch-toggle-expected.txt:
  • platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/overflow-scrollbar-layers-expected.txt:
  • platform/chromium/platform/chromium/virtual/gpu/compositedscrolling/overflow/resize-painting-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/layer-creation/fixed-position-out-of-view-scaled-scroll-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/content-gains-scrollbars-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/overflow-scrollbar-layers-expected.txt:
  • platform/chromium/platform/chromium/virtual/softwarecompositing/overflow/resize-painting-expected.txt:
  • platform/efl/compositing/geometry/foreground-layer-expected.txt:
  • platform/efl/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
  • platform/efl/compositing/repaint/invalidations-on-composited-layers-expected.txt:
  • platform/mac-wk2/compositing/rtl/rtl-fixed-expected.txt:
  • platform/mac-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
  • platform/mac-wk2/compositing/visible-rect/iframe-no-layers-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-no-image-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-body-layer-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-opacity-html-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-positioned-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-transformed-html-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-html-background-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed-background/fixed-non-propagated-body-background-expected.txt:
  • platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed-expected.txt:
  • platform/mac-wk2/tiled-drawing/tile-coverage-after-scroll-expected.txt:
  • platform/mac-wk2/tiled-drawing/tile-coverage-scroll-to-bottom-expected.txt:
  • platform/mac-wk2/tiled-drawing/tile-coverage-slow-scrolling-expected.txt:
  • platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
  • platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
  • platform/mac-wk2/tiled-drawing/use-tiled-drawing-expected.txt:
  • platform/mac/TestExpectations:
  • platform/mac/compositing/canvas/accelerated-canvas-compositing-expected.txt:
  • platform/mac/compositing/geometry/fixed-position-composited-switch-expected.txt:
  • platform/mac/compositing/iframes/resizer-expected.txt:
  • platform/mac/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
  • platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt:
  • platform/mac/compositing/tiling/backface-preserve-3d-tiled-expected.txt:
  • platform/mac/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-img-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-resize-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/mac/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/mac/compositing/tiling/rotated-tiled-clamped-expected.txt:
  • platform/mac/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
  • platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
  • platform/mac/compositing/tiling/tiled-layer-resize-expected.txt:
  • platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • platform/mac/css3/filters/composited-during-animation-layertree-expected.txt:
  • platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt:
  • platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/become-composited-nested-iframes-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/become-overlapped-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/composited-parent-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-delayed-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe2-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/connect-compositing-iframe3-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/enter-compositing-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/iframe-resize-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/leave-compositing-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/overlapped-nested-iframes-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/page-cache-layer-tree-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/resizer-expected.txt:
  • platform/qt-5.0-wk2/compositing/iframes/scrolling-iframe-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-and-transform-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-change-out-of-view-in-view-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/fixed-position-under-transform-expected.txt:
  • platform/qt-5.0-wk2/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • platform/qt-5.0-wk2/compositing/overflow/content-gains-scrollbars-expected.txt:
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scrollbar-layers-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-absolute-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-expected.txt:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-iframe-fixed-overflow-scrolled-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiled-layers-hidpi-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/crash-reparent-tiled-layer-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-expected.txt:
  • platform/qt-5.0-wk2/compositing/tiling/huge-layer-with-layer-children-resize-expected.txt:
  • platform/qt-5.0-wk2/css3/filters/composited-during-animation-layertree-expected.txt:
  • platform/qt/compositing/backing/no-backing-for-clip-expected.txt:
  • platform/qt/compositing/backing/no-backing-for-clip-overlap-expected.txt:
  • platform/qt/compositing/backing/no-backing-for-perspective-expected.txt:
  • platform/qt/compositing/geometry/preserve-3d-switching-expected.txt:
  • platform/qt/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/qt/compositing/layer-creation/no-compositing-for-preserve-3d-expected.txt:
  • platform/qt/compositing/layer-creation/overlap-animation-container-expected.txt:
  • platform/qt/compositing/overflow/clip-descendents-expected.txt:
  • platform/qt/compositing/overflow/composited-scrolling-creates-a-stacking-container-expected.txt:
  • platform/qt/css3/compositing/should-have-compositing-layer-expected.txt:
  • platform/qt/css3/filters/composited-during-transition-layertree-expected.txt:
  • platform/win/compositing/iframes/composited-iframe-expected.txt:
  • platform/win/compositing/iframes/invisible-nested-iframe-show-expected.txt:
  • platform/win/compositing/iframes/overlapped-iframe-iframe-expected.txt:
  • platform/win/compositing/tiling/huge-layer-add-remove-child-expected.txt:
  • platform/win/compositing/tiling/rotated-tiled-clamped-expected.txt:
  • platform/win/compositing/tiling/rotated-tiled-preserve3d-clamped-expected.txt:
1:13 PM Changeset in webkit [141633] by tonyg@chromium.org
  • 3 edits in trunk/Source/WebCore

Continue making XSSAuditor thread safe: Remove dependency on parser's Document URL
https://bugs.webkit.org/show_bug.cgi?id=108655

Reviewed by Adam Barth.

No new tests because no new functionality.

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::isLikelySafeResource):

  • html/parser/XSSAuditor.h:
1:08 PM Changeset in webkit [141632] by caio.oliveira@openbossa.org
  • 15 edits in trunk/Source/WebKit2

[Qt] [WK2] Fix build after r141619
https://bugs.webkit.org/show_bug.cgi?id=108680

Reviewed by Benjamin Poulain.

Take a reference instead of a pointer for decoding functions.

  • Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::Handle::decode):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:

(CoreIPC::::decode):
(CoreIPC::decodeTimingFunction):

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
  • Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:

(WebKit::WebCoordinatedSurface::Handle::decode):

  • Shared/CoordinatedGraphics/WebCoordinatedSurface.h:

(Handle):

  • Shared/qt/ArgumentCodersQt.cpp:

(CoreIPC::::decode):

  • Shared/qt/ArgumentCodersQt.h:

(CoreIPC):

  • Shared/qt/LayerTreeContextQt.cpp:

(WebKit::LayerTreeContext::decode):

  • Shared/qt/PlatformCertificateInfo.h:

(WebKit::PlatformCertificateInfo::decode):

  • Shared/qt/QtNetworkReplyData.cpp:

(WebKit::QtNetworkReplyData::decode):

  • Shared/qt/QtNetworkReplyData.h:

(QtNetworkReplyData):

  • Shared/qt/QtNetworkRequestData.cpp:

(WebKit::QtNetworkRequestData::decode):

  • Shared/qt/QtNetworkRequestData.h:

(QtNetworkRequestData):

  • Shared/qt/WebCoreArgumentCodersQt.cpp:

(CoreIPC::::decodePlatformData):

12:46 PM Changeset in webkit [141631] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Re-try enabling Win-EWS tests for the third time.
https://bugs.webkit.org/show_bug.cgi?id=107968

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(WinEWS):

12:44 PM Changeset in webkit [141630] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r141281): Navigating to this HTTP Live Streaming (application/vnd.apple.mpegurl) URL downloads a file instead of playing it in the browser
https://bugs.webkit.org/show_bug.cgi?id=108674
<rdar://problem/13133595>

Reviewed by Eric Carlson.

When passed a HashSet of available MIME types to fill out, QTKit was overwriting the contents, which were
AVFoundation's supported types. Instead, it should be appending to the list of supported types.

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::concatenateHashSets): Added static utility function.
(WebCore::MediaPlayerPrivateQTKit::getSupportedTypes): Concatenate instead of overwriting the passed in MIME types.

12:43 PM Changeset in webkit [141629] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip more test in preparation for Win EWS bots (round 2).
https://bugs.webkit.org/show_bug.cgi?id=108249

  • platform/win/TestExpectations:
12:36 PM Changeset in webkit [141628] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Fix test scripts for EWS bots to get them running once and for all.
https://bugs.webkit.org/show_bug.cgi?id=108422

Reviewed by Timothy Horton.

Disabling --quiet option on Windows for now because that fails when we try to use /dev/null.
runtests.py was not passing in a configuration to run-webkit-tests which causes DRT to build in release by default.
However, we build in Debug only on the EWS Windows bots, which caused the build to fail.

  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.options):
(RunTests.run):

12:27 PM Changeset in webkit [141627] by jberlin@webkit.org
  • 2 edits in trunk/LayoutTests

WTR needs an implementation of setAutomaticLinkDetectionEnabled
https://bugs.webkit.org/show_bug.cgi?id=87162

Skip a test on wk2 added in r14618 that uses setAutomaticLinkDetectionEnabled.

  • platform/wk2/TestExpectations:
12:21 PM Changeset in webkit [141626] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Zooming in during page load of non-scalable webpage results in fixed magnification
https://bugs.webkit.org/show_bug.cgi?id=108252

Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Yong Li.
Internally reviewed by Konrad Piascik.

PR: 284828
We got float layoutSize(342.284122, 521.448467) and
m_maximumScale(2.243750) after computing viewport meta based on the
device pixel ratio and laid out the contents at IntSize(342, 521).
Therefore, zoomToFitScale(2.245681) would be a bit larger than
m_maximumScale based on that contents size and resulted in
maximumScale()!=minimumScale(), which made the non-scalable page
scalable.
Return zoomToFitScale for maximumScale() in such kind of case.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::maximumScale):

12:13 PM Changeset in webkit [141625] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Another speculative windows build fix.

  • platform/ScrollAnimator.h:
12:11 PM Changeset in webkit [141624] by krit@webkit.org
  • 9 edits
    3 adds in trunk

[canvas] Add more constructors to Path
https://bugs.webkit.org/show_bug.cgi?id=108587

Patch by Dirk Schulze <krit@webkit.org> on 2013-01-31
Reviewed by Dean Jackson.

Source/WebCore:

Add more constructors to Path object to make it possible
to copy Path objects and parse SVG strings into a Path
object that can be used on the canvas context afterwards.

Test: fast/canvas/canvas-path-constructors.html

  • html/canvas/DOMPath.h: New constructors for Path.

(WebCore::DOMPath::create):
(WebCore::DOMPath::DOMPath):

  • html/canvas/DOMPath.idl: Ditto.

LayoutTests:

Add tests for new constructors of Path objects.
Since the feature is behind a flag, the test is skipped on
all platforms for now.

  • fast/canvas/canvas-path-constructors-expected.txt: Added.
  • fast/canvas/canvas-path-constructors.html: Added.
  • fast/canvas/script-tests/canvas-path-constructors.js: Added.
  • platform/chromium/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
12:11 PM Changeset in webkit [141623] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/blackberry

[BlackBerry] InputHandler status is not restored when page history goes back
https://bugs.webkit.org/show_bug.cgi?id=108448

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2013-02-01
Reviewed by Yong Li.

PR288406 Internally reviewed by Mike Fenton

When webpage goes back, it restores the old frame's selection and focused node,
but we don't save the InputHandler's status, it becomes non-input mode when page
goes back. When it restores the focus, since the new focus node is same as the old
document focused node, webcore will not notify client to update the input handler.

This patch updates the input handler's status by notifying it focus node changed.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::restoreViewState):

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::restoreViewState):
(WebKit):

  • WebKitSupport/InputHandler.h:

(InputHandler):

12:06 PM Changeset in webkit [141622] by zandobersek@gmail.com
  • 9 edits in trunk

[GTK] Add WTFURL source files to the build
https://bugs.webkit.org/show_bug.cgi?id=108215

Reviewed by Benjamin Poulain.

.:

  • Source/autotools/symbols.filter: Force the export of the KURL::string() symbol.

This is required when using the WTFURL backend but otherwise doesn't affect the build.

Source/WebCore:

  • platform/KURLWTFURL.cpp:

(WebCore): Only use the stub implementation of the fileSystemPath method for the
Apple ports, other ports should for now still rely on their platform-specific implementations.

Source/WTF:

The WTFURL implementation sources are all still guarded by the USE(WTFURL) guard,
meaning that the GTK port still uses the default KURL backend. To use the WTFURL
backend instead, one would have to define WTF_USE_WTFURL in Platform.h.

  • GNUmakefile.am: List the directories from which source headers will be included.

Plenty of WTFURL code currently just includes the required header by name rather
than specifying the header path as relative to Source/WTF. In the future all the inclusions
should probaby be changed to include the header through the path relative to Source/WTF.

  • GNUmakefile.list.am: Add build targets for the WTFURL source files.
  • wtf/url/api/ParsedURL.cpp: Specify the complete path to the required headers and

reorder the inclusions.

  • wtf/url/src/URLCanon.h: Ditto.
11:58 AM Changeset in webkit [141621] by mkwst@chromium.org
  • 13 edits in trunk

Remove call to SecurityOrigin::canAccessDatabase from IDB constructor.
https://bugs.webkit.org/show_bug.cgi?id=108477

Reviewed by Adam Barth.

Source/WebCore:

This change removes the 'SecurityOrigin::canAccessDatabase' check from
the constructor for the 'indexedDB' property on both DOMWindow and
WorkerContext. After the patch for http://wkbug.com/94171 this check
is redundant, as all the entry points to IDB are now gated on access
being granted.

As a side-effect, dropping the check in WorkerContextIndexedDatabase
allows us to stop holding a pointer to the ScriptExecutionContext we're
extending, which can only be a good thing.

The tests in storage/indexeddb should continue to pass.

  • Modules/indexeddb/DOMWindowIndexedDatabase.cpp:

(WebCore::DOMWindowIndexedDatabase::indexedDB):

Drop the SecurityOrigin::canAccessDatabase check.

  • Modules/indexeddb/WorkerContextIndexedDatabase.cpp:

(WebCore::WorkerContextIndexedDatabase::WorkerContextIndexedDatabase):
(WebCore::WorkerContextIndexedDatabase::from):

Drop the ScriptExecutionContext parameter from the class's
constructor and callsites.

(WebCore::WorkerContextIndexedDatabase::indexedDB):

Drop the SecurityOrigin::canAccessDatabase check.

  • Modules/indexeddb/WorkerContextIndexedDatabase.h:

(WorkerContextIndexedDatabase):

Drop the stored pointer to ScriptExecutionContext, as we no longer
need it in ::indexedDB.

LayoutTests:

  • http/tests/security/no-indexeddb-from-sandbox-expected.txt:
  • http/tests/security/no-indexeddb-from-sandbox.html:

This test expected the 'webkitIndexedDB' property to be missing
entirely inside a sandbox. The expectation has been updated to
expect 'webkitIndexedDB.open()' to throw a SECURITY_ERR.

  • platform/efl/TestExpectations:
  • platform/mac-snowleopard/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/qt/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:

This test was accidentally passing on a variety of platforms that
don't yet implement IndexedDB. Now that failure is distinguishable
we should skip it on a variety of platforms.

11:54 AM Changeset in webkit [141620] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Speculative Windows build fix.

  • platform/ScrollAnimator.h:

(WebCore):

11:53 AM Changeset in webkit [141619] by andersca@apple.com
  • 109 edits in trunk/Source/WebKit2

Message decoding functions should take a MessageDecoder reference
https://bugs.webkit.org/show_bug.cgi?id=108669

Reviewed by Andreas Kling.

Message encoding functions already take a reference instead of a pointer, so
make the decoding functions take a reference as well.

  • Platform/CoreIPC/ArgumentCoder.h:

(CoreIPC::ArgumentCoder::decode):

  • Platform/CoreIPC/ArgumentCoders.cpp:

(CoreIPC::::decode):
(CoreIPC::decodeStringText):

  • Platform/CoreIPC/ArgumentCoders.h:

(CoreIPC::SimpleArgumentCoder::decode):

  • Platform/CoreIPC/ArgumentDecoder.h:

(CoreIPC::ArgumentDecoder::decode):

  • Platform/CoreIPC/Arguments.h:

(CoreIPC::Arguments0::decode):
(CoreIPC::Arguments1::decode):
(CoreIPC::Arguments2::decode):
(CoreIPC::Arguments3::decode):
(CoreIPC::Arguments4::decode):
(CoreIPC::Arguments5::decode):
(CoreIPC::Arguments6::decode):
(CoreIPC::Arguments7::decode):
(CoreIPC::Arguments8::decode):
(CoreIPC::Arguments10::decode):

  • Platform/CoreIPC/Attachment.cpp:

(CoreIPC::Attachment::decode):

  • Platform/CoreIPC/Attachment.h:

(Attachment):

  • Platform/CoreIPC/DataReference.cpp:

(CoreIPC::DataReference::decode):

  • Platform/CoreIPC/DataReference.h:

(DataReference):

  • Platform/CoreIPC/StringReference.cpp:

(CoreIPC::StringReference::decode):

  • Platform/CoreIPC/StringReference.h:

(StringReference):

  • Platform/CoreIPC/mac/MachPort.h:

(CoreIPC::MachPort::decode):

  • Platform/SharedMemory.h:

(Handle):

  • Platform/mac/SharedMemoryMac.cpp:

(WebKit::SharedMemory::Handle::decode):

  • PluginProcess/PluginCreationParameters.cpp:

(WebKit::PluginCreationParameters::decode):

  • PluginProcess/PluginCreationParameters.h:

(PluginCreationParameters):

  • Shared/DictionaryPopupInfo.cpp:

(WebKit::DictionaryPopupInfo::decode):

  • Shared/DictionaryPopupInfo.h:

(DictionaryPopupInfo):

  • Shared/EditorState.cpp:

(WebKit::EditorState::decode):

  • Shared/EditorState.h:

(EditorState):

  • Shared/FontInfo.cpp:

(WebKit::FontInfo::decode):

  • Shared/FontInfo.h:

(FontInfo):

  • Shared/LayerTreeContext.h:

(LayerTreeContext):

  • Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::decode):

  • Shared/Network/NetworkProcessCreationParameters.h:

(NetworkProcessCreationParameters):

  • Shared/Network/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::decode):

  • Shared/Network/NetworkResourceLoadParameters.h:

(NetworkResourceLoadParameters):

  • Shared/OriginAndDatabases.cpp:

(WebKit::OriginAndDatabases::decode):

  • Shared/OriginAndDatabases.h:

(OriginAndDatabases):

  • Shared/PlatformPopupMenuData.cpp:

(WebKit::PlatformPopupMenuData::decode):

  • Shared/PlatformPopupMenuData.h:

(PlatformPopupMenuData):

  • Shared/Plugins/NPIdentifierData.cpp:

(WebKit::NPIdentifierData::decode):

  • Shared/Plugins/NPIdentifierData.h:

(NPIdentifierData):

  • Shared/Plugins/NPVariantData.cpp:

(WebKit::NPVariantData::decode):

  • Shared/Plugins/NPVariantData.h:

(NPVariantData):

  • Shared/Plugins/PluginProcessCreationParameters.cpp:

(WebKit::PluginProcessCreationParameters::decode):

  • Shared/Plugins/PluginProcessCreationParameters.h:

(PluginProcessCreationParameters):

  • Shared/PrintInfo.cpp:

(WebKit::PrintInfo::decode):

  • Shared/PrintInfo.h:

(PrintInfo):

  • Shared/SandboxExtension.h:

(Handle):
(HandleArray):
(WebKit::SandboxExtension::Handle::decode):
(WebKit::SandboxExtension::HandleArray::decode):

  • Shared/SecurityOriginData.cpp:

(WebKit::SecurityOriginData::decode):

  • Shared/SecurityOriginData.h:

(SecurityOriginData):

  • Shared/SessionState.cpp:

(WebKit::SessionState::decode):

  • Shared/SessionState.h:

(SessionState):

  • Shared/ShareableBitmap.cpp:

(WebKit::ShareableBitmap::Handle::decode):

  • Shared/ShareableBitmap.h:

(Handle):

  • Shared/ShareableResource.cpp:

(WebKit::ShareableResource::Handle::decode):

  • Shared/ShareableResource.h:

(Handle):

  • Shared/SharedWorkerProcessCreationParameters.cpp:

(WebKit::SharedWorkerProcessCreationParameters::decode):

  • Shared/SharedWorkerProcessCreationParameters.h:

(SharedWorkerProcessCreationParameters):

  • Shared/StatisticsData.cpp:

(WebKit::StatisticsData::decode):

  • Shared/StatisticsData.h:

(StatisticsData):

  • Shared/StringPairVector.h:

(WebKit::StringPairVector::decode):

  • Shared/UpdateInfo.cpp:

(WebKit::UpdateInfo::decode):

  • Shared/UpdateInfo.h:

(UpdateInfo):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageDecoder::baseDecode):

  • Shared/WebContextMenuItemData.cpp:

(WebKit::WebContextMenuItemData::decode):

  • Shared/WebContextMenuItemData.h:

(WebContextMenuItemData):

  • Shared/WebCoreArgumentCoders.cpp:

(CoreIPC::::decode):
(CoreIPC::decodeImage):

  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebEvent.cpp:

(WebKit::WebEvent::decode):

  • Shared/WebEvent.h:

(WebEvent):
(WebMouseEvent):
(WebWheelEvent):
(WebKeyboardEvent):
(WebGestureEvent):
(WebPlatformTouchPoint):
(WebTouchEvent):

  • Shared/WebGeolocationPosition.cpp:

(WebKit::WebGeolocationPosition::Data::decode):

  • Shared/WebGeolocationPosition.h:

(Data):

  • Shared/WebGestureEvent.cpp:

(WebKit::WebGestureEvent::decode):

  • Shared/WebHitTestResult.cpp:

(WebKit::WebHitTestResult::Data::decode):

  • Shared/WebHitTestResult.h:

(Data):

  • Shared/WebKeyboardEvent.cpp:

(WebKit::WebKeyboardEvent::decode):

  • Shared/WebMouseEvent.cpp:

(WebKit::WebMouseEvent::decode):

  • Shared/WebNavigationDataStore.h:

(WebKit::WebNavigationDataStore::decode):

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:

(WebPageCreationParameters):

  • Shared/WebPageGroupData.cpp:

(WebKit::WebPageGroupData::decode):

  • Shared/WebPageGroupData.h:

(WebPageGroupData):

  • Shared/WebPlatformTouchPoint.cpp:

(WebKit::WebPlatformTouchPoint::decode):

  • Shared/WebPopupItem.cpp:

(WebKit::WebPopupItem::decode):

  • Shared/WebPopupItem.h:
  • Shared/WebPreferencesStore.cpp:

(WebKit::WebPreferencesStore::decode):

  • Shared/WebPreferencesStore.h:

(WebPreferencesStore):

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:

(WebProcessCreationParameters):

  • Shared/WebTouchEvent.cpp:

(WebKit::WebTouchEvent::decode):

  • Shared/WebWheelEvent.cpp:

(WebKit::WebWheelEvent::decode):

  • Shared/cf/ArgumentCodersCF.cpp:

(CoreIPC::decode):

  • Shared/cf/ArgumentCodersCF.h:

(CoreIPC):

  • Shared/mac/ArgumentCodersMac.h:

(CoreIPC):

  • Shared/mac/ArgumentCodersMac.mm:

(CoreIPC::decode):

  • Shared/mac/AttributedString.h:

(AttributedString):

  • Shared/mac/AttributedString.mm:

(WebKit::AttributedString::decode):

  • Shared/mac/ColorSpaceData.h:

(ColorSpaceData):

  • Shared/mac/ColorSpaceData.mm:

(WebKit::ColorSpaceData::decode):

  • Shared/mac/LayerTreeContextMac.mm:

(WebKit::LayerTreeContext::decode):

  • Shared/mac/ObjCObjectGraphCoders.h:

(WebContextObjCObjectGraphDecoder):
(InjectedBundleObjCObjectGraphDecoder):

  • Shared/mac/ObjCObjectGraphCoders.mm:

(WebKit::ObjCObjectGraphDecoder::baseDecode):
(WebKit::WebContextObjCObjectGraphDecoderImpl::decode):
(WebKit::InjectedBundleObjCObjectGraphDecoderImpl::decode):
(WebKit::WebContextObjCObjectGraphDecoder::decode):
(WebKit::InjectedBundleObjCObjectGraphDecoder::decode):

  • Shared/mac/PlatformCertificateInfo.h:

(PlatformCertificateInfo):

  • Shared/mac/PlatformCertificateInfo.mm:

(WebKit::PlatformCertificateInfo::decode):

  • Shared/mac/RemoteLayerTreeTransaction.h:

(LayerProperties):
(RemoteLayerTreeTransaction):

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::RemoteLayerTreeTransaction::decode):

  • Shared/mac/SandboxExtensionMac.mm:

(WebKit::SandboxExtension::Handle::decode):
(WebKit::SandboxExtension::HandleArray::decode):

  • Shared/mac/SecItemRequestData.cpp:

(WebKit::SecItemRequestData::decode):

  • Shared/mac/SecItemRequestData.h:
  • Shared/mac/SecItemResponseData.cpp:

(WebKit::SecItemResponseData::decode):

  • Shared/mac/SecItemResponseData.h:

(SecItemResponseData):

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::decodePlatformData):
(CoreIPC::::decode):

  • UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageDecoder::decode):

  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:

(WebKit::InjectedBundleUserMessageDecoder::decode):

  • WebProcess/Plugins/Plugin.cpp:

(WebKit::Plugin::Parameters::decode):

  • WebProcess/Plugins/Plugin.h:

(Parameters):

11:44 AM Changeset in webkit [141618] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Smart link can erroneously move caret after an URL when typing immediately before it
https://bugs.webkit.org/show_bug.cgi?id=92812

Reviewed by Enrica Casucci.

Source/WebCore:

The bug was caused by smart link being triggered even when a user finished typing a word
immediately before an URL. We already had a logic to avoid smart-linking an URL when the caret
was after the URL but we were missing a check for when the caret is before the URL.

Fixed the bug by adding this check.

Test: editing/inserting/smart-link-when-caret-is-moved-before-URL.html

  • editing/Editor.cpp:

(WebCore::Editor::markAndReplaceFor):

LayoutTests:

Add a regression for typing immediately before an URL while smart link is enabled.
WebKit should not be moving the caret erroneously.

  • editing/inserting/smart-link-when-caret-is-moved-before-URL-expected.txt: Added.
  • editing/inserting/smart-link-when-caret-is-moved-before-URL.html: Added.
11:40 AM Changeset in webkit [141617] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Windows build fix. FloatSize.cpp was not included in the project.

  • WebCore.vcproj/WebCore.vcproj:
11:29 AM Changeset in webkit [141616] by jchaffraix@webkit.org
  • 4 edits
    2 adds in trunk

[CSS Grid Layout] computePreferredLogicalWidths doesn't handle minmax tracks
https://bugs.webkit.org/show_bug.cgi?id=108403

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-preferred-logical-widths.html

The code before this change was only handling minmax() with 2 fixed widths.
The new code was updated to remove this artificial limitation and we now
support all combination of minmax().

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::computePreferredLogicalWidths):
Updated to use computePreferredTrackWidth..

(WebCore::RenderGrid::computePreferredTrackWidth):
Added this helper function that implements the core of the preferred width
computation.

  • rendering/RenderGrid.h: Added computePreferredTrackWidth.

LayoutTests:

  • fast/css-grid-layout/grid-preferred-logical-widths-expected.txt: Added.
  • fast/css-grid-layout/grid-preferred-logical-widths.html: Added.
11:25 AM Changeset in webkit [141615] by Nate Chapin
  • 5 edits
    3 adds in trunk

Cached main resources report a zero identifer on 304s
https://bugs.webkit.org/show_bug.cgi?id=108402

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/cache/iframe-304-crash.html

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::responseReceived): Throughout, check m_identifierForLoadWithoutResourceLoader

instead of !loader() to determine whether MainResourceLoader needs to synthesize resource load callbacks.

(WebCore::MainResourceLoader::dataReceived):
(WebCore::MainResourceLoader::didFinishLoading):

LayoutTests:

  • http/tests/cache/iframe-304-crash-expected.txt: Added.
  • http/tests/cache/iframe-304-crash.html: Added.
  • http/tests/cache/resources/iframe304.php: Added.
  • platform/chromium/TestExpectations: New test requires main resource caching, which isn't supported on chromium at the moment.
  • platform/mac/TestExpectations: New test requires main resource caching, which isn't supported on mac at the moment.
11:14 AM Changeset in webkit [141614] by thakis@chromium.org
  • 11 edits in trunk

[chromium] Build webkit with enable_web_intents set to 0.
https://bugs.webkit.org/show_bug.cgi?id=108408

Reviewed by Tony Chang.

I'll then make chromium build fine with that, then switch
enable_web_intents to 0, roll that into webkit, and then
actually remove the code hidden behind this flag.

Source/WebCore:

  • bindings/v8/custom/V8IntentCustom.cpp:

Source/WebKit/chromium:

The features.gypi bit depends on https://codereview.chromium.org/12143002/
and will disable web intents support on android. Since common.gypi
sets enable_web_intents to 0 explicitly, it seems this is currently on
by accident anyway.

While it looks like this CL just removes ENABLE_WEB_INTENTS=1 from
features.gypi completely, it's still set further down the file if
enable_web_intents is on.

  • WebKit.gyp:
  • features.gypi:
  • src/WebFrameImpl.cpp:

Tools:

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:

(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):

  • DumpRenderTree/chromium/WebViewHost.cpp:
  • DumpRenderTree/chromium/WebViewHost.h:

(WebViewHost):

11:07 AM Changeset in webkit [141613] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: make console object state hint non-active
https://bugs.webkit.org/show_bug.cgi?id=108642

Reviewed by Vsevolod Vlasov.

Otherwise it seems like an active element user could click.

  • inspector/front-end/inspector.css:

(.object-info-state-note):

11:04 AM Changeset in webkit [141612] by commit-queue@webkit.org
  • 3 edits
    18 adds in trunk

Zero size gradient should paint nothing on canvas
https://bugs.webkit.org/show_bug.cgi?id=102654

Patch by Rashmi Shyamasundar <rashmi.s2@samsung.com> on 2013-02-01
Reviewed by Dirk Schulze.

Source/WebCore:

The functions fill(), fillText(), stroke(), strokeRect() and strokeText()
should paint nothing on canvas when the canvas fillStyle/strokeStyle
is set to a zero size gradient.

Tests: fast/canvas/canvas-fill-zeroSizeGradient.html

fast/canvas/canvas-fillRect-zeroSizeGradient.html
fast/canvas/canvas-fillText-zeroSizeGradient.html
fast/canvas/canvas-stroke-zeroSizeGradient.html
fast/canvas/canvas-strokeRect-zeroSizeGradient.html
fast/canvas/canvas-strokeText-zeroSizeGradient.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::stroke):
(WebCore::CanvasRenderingContext2D::strokeRect):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

LayoutTests:

The functions fill(), fillText(), stroke(), strokeRect() and strokeText()
should paint nothing on canvas when the canvas fillStyle/strokeStyle
is set to a zero size gradient.

  • fast/canvas/canvas-fill-zeroSizeGradient-expected.txt: Added.
  • fast/canvas/canvas-fill-zeroSizeGradient.html: Added.
  • fast/canvas/canvas-fillRect-zeroSizeGradient-expected.txt: Added.
  • fast/canvas/canvas-fillRect-zeroSizeGradient.html: Added.
  • fast/canvas/canvas-fillText-zeroSizeGradient-expected.txt: Added.
  • fast/canvas/canvas-fillText-zeroSizeGradient.html: Added.
  • fast/canvas/canvas-stroke-zeroSizeGradient-expected.txt: Added.
  • fast/canvas/canvas-stroke-zeroSizeGradient.html: Added.
  • fast/canvas/canvas-strokeRect-zeroSizeGradient-expected.txt: Added.
  • fast/canvas/canvas-strokeRect-zeroSizeGradient.html: Added.
  • fast/canvas/canvas-strokeText-zeroSizeGradient-expected.txt: Added.
  • fast/canvas/canvas-strokeText-zeroSizeGradient.html: Added.
  • fast/canvas/script-tests/canvas-fill-zeroSizeGradient.js: Added.
  • fast/canvas/script-tests/canvas-fillRect-zeroSizeGradient.js: Added.
  • fast/canvas/script-tests/canvas-fillText-zeroSizeGradient.js: Added.
  • fast/canvas/script-tests/canvas-stroke-zeroSizeGradient.js: Added.
  • fast/canvas/script-tests/canvas-strokeRect-zeroSizeGradient.js: Added.
  • fast/canvas/script-tests/canvas-strokeText-zeroSizeGradient.js: Added.
11:00 AM Changeset in webkit [141611] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

HRTFElevation segfault if a null AudioBus is returned by loadPlatformResource
https://bugs.webkit.org/show_bug.cgi?id=108504

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2013-02-01
Reviewed by Kenneth Russell.

Fixed a segfault by checking if the returned AudioBus is null or not.
If it is, we should early return in the same way it was being done already
in HRTFElevation::calculateKernelsForAzimuthElevation();

No new tests, covered by existing tests.

  • platform/audio/HRTFElevation.cpp:

(WebCore::getConcatenatedImpulseResponsesForSubject):

10:59 AM Changeset in webkit [141610] by Beth Dakin
  • 8 edits in trunk/Source/WebCore

ScrollAnimatorMac should adopt contentAreaScrolledInDirection
https://bugs.webkit.org/show_bug.cgi?id=108647
-and corresponding-
<rdar://problem/12434779>

Reviewed by Anders Carlsson.

This patch makes notifyContentAreaScrolled() and notifyPositionChanged() take a
FloatSize parameter that represents the scroll delta so that it can be passed
along to contentAreaScrolledInDirection:.

Pass along the scroll delta.

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):

The delta is not needed in this base-class implementation. It will only be needed
in the ScrollAnimatorMac override.
(WebCore::ScrollAnimator::notifyPositionChanged):

  • platform/ScrollAnimator.h:

(WebCore::ScrollAnimator::notifyContentAreaScrolled):

Pass along the delta.

  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorNone::animationTimerFired):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::scrollPositionChanged):

Add contentAreaScrolledInDirection: to the NSScrollerImpDetails.

  • platform/mac/NSScrollerImpDetails.h:

New member variable m_contentAreaScrolledTimerScrollDelta stores the current
scroll delta while we are waiting for m_sendContentAreaScrolledTimer to fire.

  • platform/mac/ScrollAnimatorMac.h:

We need this so that we can call just contentAreaScrolled if
contentAreaScrolledInDirection: is not available.

  • platform/mac/ScrollAnimatorMac.mm:

(supportsContentAreaScrolledInDirection):

Pass along the delta.
(WebCore::ScrollAnimatorMac::immediateScrollTo):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::mayBeginScrollGesture):
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore::ScrollAnimatorMac::immediateScrollBy):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledSoon):

If contentAreaScrolledInDirection: is available, call it with the delta, and then
reset our delta. Otherwise, still call contentAreaScrolled.
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):

10:56 AM Changeset in webkit [141609] by leviw@chromium.org
  • 2 edits
    2 copies in branches/chromium/1364

Merge 141357

[Chromium] WebPluginContainerImpl adding imbalanced touch handler refs
https://bugs.webkit.org/show_bug.cgi?id=108381

Reviewed by James Robinson.

Source/WebKit/chromium:

WebPluginContainerImpl would call Document::didAddTouchEventHandler every time the plugin requested
touch events. Some plugins make this request more than once, leading to an imbalance in Document's
touch event handler map, and a stale node pointer when the plugin is destroyed. This change
has WebPluginContainerImpl only add one ref for the plugin at a time.

  • src/WebPluginContainerImpl.cpp:

(WebKit::WebPluginContainerImpl::requestTouchEventType):

Tools:

  • DumpRenderTree/chromium/TestRunner/src/WebTestPlugin.cpp: Adding an attribute that

tickles the case in WebPluginContainerImpl that imbalanced touch handler refs in Document.

LayoutTests:

  • platform/chromium/plugins/re-request-touch-events-crash-expected.txt: Added.
  • platform/chromium/plugins/re-request-touch-events-crash.html: Added.

TBR=leviw@chromium.org
Review URL: https://codereview.chromium.org/12088115

10:55 AM Changeset in webkit [141608] by commit-queue@webkit.org
  • 4 edits in trunk

Source/WebKit/chromium: [Chromium] Ignore whitespace in spellcheck
https://bugs.webkit.org/show_bug.cgi?id=108510

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-01
Reviewed by Ryosuke Niwa.

  • src/ContextMenuClientImpl.cpp:

(WebKit::selectMisspellingAsync): Ignore whitespace when selecting the misspelling.

LayoutTests: [Chromium] Expect spellcheck to ignore whitespace
https://bugs.webkit.org/show_bug.cgi?id=108510

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-01
Reviewed by Ryosuke Niwa.

  • platform/chromium/TestExpectations: Expect spellcheck to ignore whitespace.
10:49 AM Changeset in webkit [141607] by pfeldman@chromium.org
  • 4 edits in trunk

Web Inspector: [file selector dialog] for mixed case queries, score uppercase letters only when assessing camelcase.
https://bugs.webkit.org/show_bug.cgi?id=108639

Reviewed by Vsevolod Vlasov.

Source/WebCore:

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.FilteredItemSelectionDialog.prototype._createScoringRegex):

LayoutTests:

  • inspector/filtered-item-selection-dialog-filtering-expected.txt:
10:45 AM Changeset in webkit [141606] by robert@webkit.org
  • 3 edits
    4 adds in trunk

Padding in a parent inline preceding an empty inline child should be counted towards width
https://bugs.webkit.org/show_bug.cgi?id=108226

Reviewed by Levi Weintraub.

Source/WebCore:

Add the border/padding/margin from an empty inline's parent inline if it is the first or last
child of the inline.

Tests: fast/inline/parent-inline-element-padding-contributes-width.html

fast/inline/positioned-element-padding-contributes-width.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

  • fast/inline/parent-inline-element-padding-contributes-width-expected.txt: Added.
  • fast/inline/parent-inline-element-padding-contributes-width.html: Added.
  • fast/inline/positioned-element-padding-contributes-width-expected.txt: Added.
  • fast/inline/positioned-element-padding-contributes-width.html: Added.
10:40 AM Changeset in webkit [141605] by tonyg@chromium.org
  • 4 edits in trunk/Source/WebCore

Continue making XSSAuditor thread safe: Remove dependencies on m_parser from init()
https://bugs.webkit.org/show_bug.cgi?id=108531

Reviewed by Adam Barth.

The threaded HTML parser will create and init() the XSSAuditor on the main thread, but filterToken() will be called on the background.

No new tests because no change in functionality.

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::pumpTokenizer):

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):

  • html/parser/XSSAuditor.h:

(WebCore):
(XSSAuditor):

10:32 AM Changeset in webkit [141604] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Removed an unused function: JSGlobalObject::createFunctionExecutableFromGlobalCode
https://bugs.webkit.org/show_bug.cgi?id=108657

Reviewed by Anders Carlsson.

  • runtime/JSGlobalObject.cpp:

(JSC):

  • runtime/JSGlobalObject.h:

(JSGlobalObject):

10:31 AM Changeset in webkit [141603] by beidson@apple.com
  • 4 edits in trunk/Source/WebCore

Remove unnecessary parameter from DocumentLoader::scheduleArchiveLoad
https://bugs.webkit.org/show_bug.cgi?id=108654

Reviewed by Alexey Proskuryakov.

No new tests (No behavior change.)

Remove the KURL parameter parameter from this method which, in practice,
is always the same as the url of the ResourceRequest parameter.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::scheduleArchiveLoad):

  • loader/DocumentLoader.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::start):

10:18 AM Changeset in webkit [141602] by zandobersek@gmail.com
  • 3 edits in trunk/Tools

Set the GTK 64-bit Debug builder to build and test only WebKit1
https://bugs.webkit.org/show_bug.cgi?id=108648

Reviewed by Philippe Normand.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Change the builder name, type and

build directory to note that the builder builds and tests only the WebKit1 port on the GTK platform.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(CompileWebKit1Only): Add the new build class that builds only the WebKit1 port of the builder's platform.
(BuildAndTestWebKit1OnlyFactory): Add the new factory that uses the CompileWebKit1Only build class
for building and testing only WebKit1 on the builder's platform.

9:49 AM Changeset in webkit [141601] by Lucas Forschler
  • 2 edits in tags/Safari-537.26.5/Source/WebKit2

Merged r141180. <rdar://problem/13047398>

9:46 AM Changeset in webkit [141600] by Lucas Forschler
  • 29 edits in tags/Safari-537.26.5/Source/WebKit2

Merged r141167. <rdar://problem/13047398>

9:18 AM Changeset in webkit [141599] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Adapt WorkQueueGtk to the latest changes in WebKit2 after r141497
https://bugs.webkit.org/show_bug.cgi?id=108607

Reviewed by Anders Carlsson.

  • Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::EventSource::executeEventSource): Remove the is valid
work queue check.
(WorkQueue::EventSource): WorkQueue is now refcounted, so keep a
reference when a new job is scheduled and unref it when it
finishes.

8:34 AM Changeset in webkit [141598] by Simon Hausmann
  • 3 edits in trunk/Source/WebKit/qt

[Qt] Make QWebHistory unit tests more robust

Reviewed by Jocelyn Turcotten.

The tests were using a QEventLoop::exec() call to verify the emission
of the loadFinished() signal after calling for example back() or forward().
However sometimes the call to back() may emit the signal immediately and
sometimes async, causing instabilities in test runs. The call to exec()
also means that if there was a bug then the rest would hang forever because
exec() has no timeout.

This patch introduces a simple SignalBarrier class that solves both issues:

(1) ensureSignalEmitted() supports the immediate signal emission case as well
as the async one.

(2) Through the use of QSignalSpy's wait() there's an actual timeout.

  • tests/qwebhistory/tst_qwebhistory.cpp:

(tst_QWebHistory::init):
(tst_QWebHistory::cleanup):
(tst_QWebHistory::back):
(tst_QWebHistory::forward):
(tst_QWebHistory::goToItem):
(tst_QWebHistory::serialize_2):

  • tests/util.h:

(waitForSignal):
(SignalBarrier):
(SignalBarrier::SignalBarrier):
(SignalBarrier::ensureSignalEmitted):

8:14 AM Changeset in webkit [141597] by Philippe Normand
  • 2 edits in trunk/Source/WebKit/gtk/po

Unreviewed, GTK build fix after r141566.

  • POTFILES.in: The FullscreenVideoController moved to WebCore.
8:02 AM Changeset in webkit [141596] by jochen@chromium.org
  • 18 edits
    1 add
    1 delete in trunk/Tools

[chromium] move ownership of TestRunner object to TestInterfaces
https://bugs.webkit.org/show_bug.cgi?id=108464

Reviewed by Adam Barth.

Before, TestShell owned the class. This also removes the last include
from DumpRenderTree to TestRunner/src.

This also deletes TestDelegate and uses WebTestDelegate everywhere
instead.

  • DumpRenderTree/DumpRenderTree.gypi:
  • DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:

(WebTestInterfaces):

  • DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:

(WebKit):
(WebTestRunner):

  • DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
  • DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:

(WebTestRunner):
(WebTestRunner::AccessibilityController::setDelegate):
(AccessibilityController):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:

(WebTestRunner):
(WebTestRunner::makeMenuItemStringsFor):

  • DumpRenderTree/chromium/TestRunner/src/EventSender.h:

(WebTestRunner):
(WebTestRunner::EventSender::setDelegate):
(EventSender):

  • DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp:

(WebTestRunner::GamepadController::setDelegate):

  • DumpRenderTree/chromium/TestRunner/src/GamepadController.h:

(WebTestRunner):
(GamepadController):

  • DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: Removed.
  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:

(WebTestRunner::TestInterfaces::TestInterfaces):
(WebTestRunner::TestInterfaces::~TestInterfaces):
(WebTestRunner::TestInterfaces::setWebView):
(WebTestRunner::TestInterfaces::setDelegate):
(WebTestRunner::TestInterfaces::bindTo):
(WebTestRunner::TestInterfaces::resetAll):
(WebTestRunner):
(WebTestRunner::TestInterfaces::setTestIsRunning):
(WebTestRunner::TestInterfaces::testRunner):

  • DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:

(WebTestRunner):
(TestInterfaces):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:

(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):

  • DumpRenderTree/chromium/TestRunner/src/TestRunner.h:

(WebKit):
(TestRunner):

  • DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:

(WebTestRunner::WebTestInterfaces::Internal::testRunner):
(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::Internal):
(WebTestRunner::WebTestInterfaces::Internal::setDelegate):
(WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):

  • DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp: Added.

(WebTestRunner):
(WebTestRunner::WebTestRunner::WebTestRunner):
(WebTestRunner::WebTestRunner::shouldDumpEditingCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpAsText):
(WebTestRunner::WebTestRunner::setShouldDumpAsText):
(WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
(WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
(WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
(WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
(WebTestRunner::WebTestRunner::shouldDumpAsAudio):
(WebTestRunner::WebTestRunner::audioData):
(WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
(WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
(WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
(WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
(WebTestRunner::WebTestRunner::shouldDumpCreateView):
(WebTestRunner::WebTestRunner::canOpenWindows):
(WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
(WebTestRunner::WebTestRunner::webPermissions):
(WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
(WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
(WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
(WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
(WebTestRunner::WebTestRunner::testRepaint):
(WebTestRunner::WebTestRunner::sweepHorizontally):
(WebTestRunner::WebTestRunner::isPrinting):
(WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
(WebTestRunner::WebTestRunner::setTitleTextDirection):
(WebTestRunner::WebTestRunner::httpHeadersToClear):
(WebTestRunner::WebTestRunner::shouldBlockRedirects):
(WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
(WebTestRunner::WebTestRunner::setTopLoadingFrame):
(WebTestRunner::WebTestRunner::topLoadingFrame):
(WebTestRunner::WebTestRunner::policyDelegateDone):
(WebTestRunner::WebTestRunner::policyDelegateEnabled):
(WebTestRunner::WebTestRunner::policyDelegateIsPermissive):
(WebTestRunner::WebTestRunner::policyDelegateShouldNotifyDone):
(WebTestRunner::WebTestRunner::shouldInterceptPostMessage):
(WebTestRunner::WebTestRunner::isSmartInsertDeleteEnabled):
(WebTestRunner::WebTestRunner::isSelectTrailingWhitespaceEnabled):

  • DumpRenderTree/chromium/TestShell.cpp:

(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::runFileTest):
(TestShell::resetTestController):
(TestShell::dump):
(TestShell::bindJSObjectsToWindow):

  • DumpRenderTree/chromium/TestShell.h:

(TestShell::testRunner):
(TestShell):

7:58 AM Changeset in webkit [141595] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

Unreviewed. Rolled Chromium DEPS to r180131. Requested by
"Florin Malita" <fmalita@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01

  • DEPS:
7:46 AM Changeset in webkit [141594] by pfeldman@chromium.org
  • 6 edits in trunk

Web Inspector: relax goto file matching again.
https://bugs.webkit.org/show_bug.cgi?id=108346

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This change brings back behavior introduced in r116244.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._createSearchRegex):
(WebInspector.FilteredItemSelectionDialog.prototype._createScoringRegex):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems.compareFunction):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
(WebInspector.FilteredItemSelectionDialog.prototype._onMouseMove):
(WebInspector.FilteredItemSelectionDialog.prototype.itemElement):
(WebInspector.OpenResourceDialog):

  • inspector/front-end/utilities.js:

(String.regexSpecialCharacters):
(String.prototype.escapeForRegExp):

LayoutTests:

  • inspector/filtered-item-selection-dialog-filtering-expected.txt:
  • inspector/filtered-item-selection-dialog-filtering.html:
7:43 AM Changeset in webkit [141593] by vsevik@chromium.org
  • 8 edits in trunk

Web Inspector: Navigator should not create tree elements for uiSourceCodes unless neededm should populate folders on expand only.
https://bugs.webkit.org/show_bug.cgi?id=108601

Reviewed by Pavel Feldman.

Source/WebCore:

Tree elememnts for uiSourceCodes are not created until really needed anymore.
They are now created when parent folder tree elememnts are expanded or when uiSourceCode is revealed in navigator.

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorView):
(WebInspector.NavigatorView.prototype.addUISourceCode):
(WebInspector.NavigatorView.prototype._getOrCreateScriptTreeElement):
(WebInspector.NavigatorView.prototype._getScriptTreeElement):
(WebInspector.NavigatorView.prototype._createScriptTreeElement):
(WebInspector.NavigatorView.prototype._removeScriptTreeElement):
(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype.isScriptSourceAdded):
(WebInspector.NavigatorView.prototype.revealUISourceCode):
(WebInspector.NavigatorView.prototype.removeUISourceCode):
(WebInspector.NavigatorView.prototype.reset):
(WebInspector.NavigatorView.prototype.createFolderTreeElement):
(WebInspector.NavigatorView.prototype._populateFolderTreeElement):
(WebInspector.NavigatorView.prototype._addScriptTreeElement):
(WebInspector.NavigatorView.prototype._adoptUISourceCode):
(WebInspector.NavigatorFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement.prototype.onpopulate):

LayoutTests:

  • http/tests/inspector/debugger-test.js:

(initialize_DebuggerTest.):
(initialize_DebuggerTest):

  • inspector/debugger/scripts-file-selector-expected.txt:
  • inspector/debugger/scripts-file-selector.html:
  • inspector/debugger/scripts-sorting-expected.txt:
  • inspector/debugger/scripts-sorting.html:
7:40 AM Changeset in webkit [141592] by Philippe Normand
  • 2 edits in trunk/LayoutTests

Unreviewed, flagging more fullscreen tests in GTK due to bug 108363.

  • platform/gtk/TestExpectations:
7:32 AM Changeset in webkit [141591] by loislo@chromium.org
  • 9 edits in trunk/Source/WTF

Web Inspector: Native Memory Instrumentation: provide edge names and class names for WTF containers and strings
https://bugs.webkit.org/show_bug.cgi?id=107303

Reviewed by Yury Semikhatsky.

I'd like to use ValueType[] as className for the container data members
because class names of template parameters already present in the container class names.

  • wtf/MemoryInstrumentationArrayBufferView.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationHashCountedSet.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationHashMap.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationHashSet.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationListHashSet.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationSequence.h:
  • wtf/MemoryInstrumentationString.h:

(WTF::reportMemoryUsage):

  • wtf/MemoryInstrumentationVector.h:

(WTF::reportMemoryUsage):

7:27 AM Changeset in webkit [141590] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

PatchLog process durations are increasing linearly with time (faulty data logging)
https://bugs.webkit.org/show_bug.cgi?id=108621

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-01
Reviewed by Eric Seidel.

Added a check to prevent a stop event from happening to the same patch multiple times.

  • QueueStatusServer/loggers/recordpatchevent.py:

(RecordPatchEvent.stopped):

7:27 AM Changeset in webkit [141589] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: TabbedEditorContainer.History performance optimization.
https://bugs.webkit.org/show_bug.cgi?id=108581

Introduced history items indexing by url.

Reviewed by Pavel Feldman.

Covered by existing test.

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.History):
(WebInspector.TabbedEditorContainer.History.prototype.index):
(WebInspector.TabbedEditorContainer.History.prototype._rebuildItemIndex):
(WebInspector.TabbedEditorContainer.History.prototype.update):
(WebInspector.TabbedEditorContainer.History.prototype.remove):

7:01 AM Changeset in webkit [141588] by ggaren@apple.com
  • 6 edits
    1 add in trunk/Source

Added TriState to WTF and started using it in one place
https://bugs.webkit.org/show_bug.cgi?id=108628

Reviewed by Beth Dakin.

../JavaScriptCore:

  • runtime/PrototypeMap.h:

(JSC::PrototypeMap::isPrototype): Use TriState instead of boolean. In
response to review feedback, this is an attempt to clarify that our
'true' condition is actually just a 'maybe'.

  • runtime/PrototypeMap.h:

(PrototypeMap):
(JSC::PrototypeMap::isPrototype):

../WebCore:

  • editing/EditingStyle.h:

(WebCore): Moved TriState to WTF so it can be used in more places.

../WTF:

Useful for expressing "maybe" conditions in a boolean context.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/TriState.h: Added.

(WTF):

6:17 AM Changeset in webkit [141587] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r141319.
http://trac.webkit.org/changeset/141319
https://bugs.webkit.org/show_bug.cgi?id=108629

This patch is causing the UIProcess to hang on GTK port when
loading plugins (Requested by chris-qBT_laptop on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01

  • UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:

(WebKit::PluginProcessProxy::scanPlugin):

6:12 AM Changeset in webkit [141586] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

Build fix for WinCE after r137709
https://bugs.webkit.org/show_bug.cgi?id=105767

Do not pass functions as const references to
templated arguments to make the compiler happy.

  • wtf/StdLibExtras.h:

(WTF::binarySearch):
(WTF::tryBinarySearch):
(WTF::approximateBinarySearch):

6:11 AM Changeset in webkit [141585] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK][WK2] MiniBrowser fullscreen signals support
https://bugs.webkit.org/show_bug.cgi?id=108005

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-02-01
Reviewed by Carlos Garcia Campos.

Shows a label for 2 seconds using overlay (if GTK >= 3.2.0) and hides
the toolbar when entering fullscreen. When leaving fullscreen the
label is hidden (if it's not hidden yet) and the toolbar is shown again.

  • MiniBrowser/gtk/BrowserWindow.c:

(_BrowserWindow):
(fullScreenMessageTimeoutCallback):
(webViewEnterFullScreen):
(webViewLeaveFullScreen):
(browserWindowFinalize):
(browserWindowConstructed):

5:42 AM Changeset in webkit [141584] by sudarsana.nagineni@linux.intel.com
  • 4 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip some failing tests on EFL bots after r141459 and r141310.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/fast/js/global-constructors-expected.txt: Revert change from r141573.
5:08 AM Changeset in webkit [141583] by mikhail.pozdnyakov@intel.com
  • 6 edits in trunk/Source/WebKit2

[EFL][WK2] EwkContext should be based on C WK2 API
https://bugs.webkit.org/show_bug.cgi?id=107666

Reviewed by Andreas Kling.

EwkContext should be based on C WK2 API so that API layering is not violated.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):

  • UIProcess/API/efl/ewk_context.cpp:

(EwkContext::EwkContext):
(EwkContext::create):
(EwkContext::cookieManager):
(EwkContext::ensureFaviconDatabase):
(EwkContext::setFaviconDatabaseDirectoryPath):
(EwkContext::addVisitedLink):
(EwkContext::setCacheModel):
(EwkContext::cacheModel):
(EwkContext::setAdditionalPluginPath):
(EwkContext::clearResourceCache):

  • UIProcess/API/efl/ewk_context_private.h:

(EwkContext):

  • UIProcess/API/efl/ewk_view.cpp:

(ewk_view_base_add):

5:00 AM Changeset in webkit [141582] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Fix hanging deleteQWebViewTwice test

Reviewed by Allan Sandfeld Jensen.

Don't use QCoreApplication::instance()->exec(), because in case of a bug
that never finishes. Instead use waitForSignal() which has the concept of
a timeout.

  • tests/qwebpage/tst_qwebpage.cpp:

(tst_QWebPage::deleteQWebViewTwice):

4:56 AM Changeset in webkit [141581] by Christophe Dumez
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Use C API inside ewk_auth_request
https://bugs.webkit.org/show_bug.cgi?id=107806

Reviewed by Andreas Kling.

Use C API inside ewk_auth_request instead of accessing C++ internal
classes directly, to avoid violating layering.

  • UIProcess/API/efl/ewk_auth_request.cpp:

(EwkAuthRequest::EwkAuthRequest):
(EwkAuthRequest::suggestedUsername):
(EwkAuthRequest::realm):
(EwkAuthRequest::host):
(EwkAuthRequest::continueWithoutCredential):
(EwkAuthRequest::authenticate):
(EwkAuthRequest::isRetrying):
(ewk_auth_request_authenticate):

  • UIProcess/API/efl/ewk_auth_request_private.h:

(EwkAuthRequest::create):
(EwkAuthRequest):

  • UIProcess/efl/PageLoadClientEfl.cpp:

(WebKit::PageLoadClientEfl::didReceiveAuthenticationChallengeInFrame):

4:54 AM Changeset in webkit [141580] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

[Gtk][WK2] Fix build after recent WebKit2 changes
https://bugs.webkit.org/show_bug.cgi?id=108588

Patch by Seulgi Kim <seulgikim@company100.net> on 2013-02-01
Reviewed by Andreas Kling.

Don't remove WorkQueue during execution.
Following the logic on https://bugs.webkit.org/show_bug.cgi?id=108544

  • Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::EventSource::~EventSource):
(WorkQueue::EventSource::executeEventSource):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
(WorkQueue::dispatchOnTermination):

4:23 AM Changeset in webkit [141579] by pfeldman@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Follow up to r141260: fixing renamed style.
Not reviewed.

  • inspector/front-end/FilteredItemSelectionDialog.js:

(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._onClick):
(WebInspector.FilteredItemSelectionDialog.prototype._onMouseMove):

4:16 AM Changeset in webkit [141578] by alexis@webkit.org
  • 32 edits in trunk

Enable unprefixed CSS transitions by default.
https://bugs.webkit.org/show_bug.cgi?id=108216

Reviewed by Dean Jackson.

.:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations. Remove the
various #ifdefs and conditional generations.

  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.cpp:
  • GNUmakefile.features.am.in:
  • css/CSSPropertyNames.in:
  • dom/EventNames.in:
  • dom/TransitionEvent.cpp:
  • dom/TransitionEvent.h:
  • dom/TransitionEvent.idl:
  • page/DOMWindow.idl:
  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle):

Source/WebKit/chromium:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

  • features.gypi:

Source/WebKit/mac:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

  • Configurations/FeatureDefines.xcconfig:

Tools:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

  • Scripts/webkitperl/FeatureList.pm:
  • qmake/mkspecs/features/features.pri:

WebKitLibraries:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

  • win/tools/vsprops/FeatureDefines.vsprops:
  • win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

Unskip the tests by default as now unprefixed CSS Transitions are
enabled by default.

  • fast/events/event-creation-expected.txt:
  • fast/events/event-creation.html: Add the test that was commented out

before.

  • platform/chromium/TestExpectations:
3:49 AM Changeset in webkit [141577] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

Unreviewed, rolling out r141548.
http://trac.webkit.org/changeset/141548
https://bugs.webkit.org/show_bug.cgi?id=108579

userscript-plugin-document.html is flaky

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::setWrapperInObject):

  • bindings/v8/V8GCController.cpp:

(WebCore):
(WebCore::gcTree):
(WebCore::V8GCController::didCreateWrapperForNode):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):

  • bindings/v8/V8GCController.h:

(V8GCController):

3:39 AM Changeset in webkit [141576] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skipped some failing tests.

  • platform/qt/TestExpectations:
3:27 AM Changeset in webkit [141575] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit/qt

[Qt] Skip hanging WebGL software fallback tests

Reviewed by Allan Sandfeld Jensen.

See also https://bugs.webkit.org/show_bug.cgi?id=105820.

  • tests/qgraphicswebview/tst_qgraphicswebview.cpp:

(tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation):
(tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation):

3:26 AM Changeset in webkit [141574] by aandrey@chromium.org
  • 8 edits in trunk/Source/WebCore

Web Inspector: fix jscompiler warnings
https://bugs.webkit.org/show_bug.cgi?id=108604

Reviewed by Pavel Feldman.

  • inspector/front-end/ConsoleView.js:

(WebInspector.ConsoleGroup.prototype.addMessage):

  • inspector/front-end/ContextMenu.js:

(WebInspector.ContextSubMenuItem):

  • inspector/front-end/ImageView.js:

(WebInspector.ImageView.prototype._copyImageURL):
(WebInspector.ImageView.prototype._openInNewTab):

  • inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView.prototype._clearBrowserCache):
(WebInspector.NetworkLogView.prototype._clearBrowserCookies):

  • inspector/front-end/ResourcesPanel.js:

(WebInspector.IDBDatabaseTreeElement.prototype._refreshIndexedDB):

  • inspector/front-end/ScriptsNavigator.js:

(WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRenameSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleCreateSnippet):

  • inspector/front-end/Toolbar.js:

(WebInspector.Toolbar.prototype._isDockedToBottom):

3:22 AM Changeset in webkit [141573] by sudarsana.nagineni@linux.intel.com
  • 2 edits
    1 delete in trunk/LayoutTests

Unreviewed EFL gardening.

Update platform expectations for failing tests after the
WEB_INTENTS flag turned off for EFL port in r141439

  • platform/efl/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
  • platform/efl/fast/js/global-constructors-expected.txt:
3:00 AM Changeset in webkit [141572] by sudarsana.nagineni@linux.intel.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Renamed inspector/editor/text-editor-ctrl-movements.html to
inspector/editor/text-editor-word-jumps.html after r141399.

  • platform/efl/TestExpectations:
2:51 AM Changeset in webkit [141571] by commit-queue@webkit.org
  • 4 edits in trunk/Source

Coordinated Graphics : Sort Target.pri and class declarations in alphabetical order.
https://bugs.webkit.org/show_bug.cgi?id=108590

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-02-01
Reviewed by Noam Rosenthal.

Source/WebCore:

Sort CoordinatedGraphics files in Target.pri in alphabetical order.

No new tests. No change in behavior.

  • Target.pri:

Source/WebKit2:

Sort class declarations in alphabetical order.

  • Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:

(WebCore):

2:42 AM Changeset in webkit [141570] by loislo@chromium.org
  • 173 edits in trunk/Source/WebCore

Web Inspector: Native Memory Instrumentation: provide edge names to class members in all WebCore instrumented classes.
https://bugs.webkit.org/show_bug.cgi?id=107369

Reviewed by Yury Semikhatsky.

It is almost mechanical change generated by a script.
Late I'll implement name to edge name consistency check in clang plugin.

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::reportMemoryUsage):

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::reportMemoryUsage):

  • bindings/js/ScriptWrappable.h:

(WebCore::ScriptWrappable::reportMemoryUsage):

  • bindings/v8/DOMDataStore.cpp:

(WebCore::DOMDataStore::reportMemoryUsage):

  • bindings/v8/DOMWrapperMap.h:

(WebCore::DOMWrapperMap::reportMemoryUsage):

  • bindings/v8/V8PerIsolateData.cpp:

(WebCore::V8PerIsolateData::reportMemoryUsage):

  • bindings/v8/V8ValueCache.cpp:

(WebCore::StringCache::reportMemoryUsage):

  • css/CSSBorderImageSliceValue.cpp:

(WebCore::CSSBorderImageSliceValue::reportDescendantMemoryUsage):

  • css/CSSCalculationValue.cpp:
  • css/CSSCanvasValue.cpp:

(WebCore::CSSCanvasValue::reportDescendantMemoryUsage):

  • css/CSSCharsetRule.cpp:

(WebCore::CSSCharsetRule::reportMemoryUsage):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::reportMemoryUsage):

  • css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::reportDescendantMemoryUsage):

  • css/CSSCursorImageValue.cpp:

(WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::reportMemoryUsage):

  • css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::reportDescendantMemoryUsage):

  • css/CSSFunctionValue.cpp:

(WebCore::CSSFunctionValue::reportDescendantMemoryUsage):

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientColorStop::reportMemoryUsage):
(WebCore::CSSGradientValue::reportBaseClassMemoryUsage):
(WebCore::CSSLinearGradientValue::reportDescendantMemoryUsage):
(WebCore::CSSRadialGradientValue::reportDescendantMemoryUsage):

  • css/CSSGroupingRule.cpp:

(WebCore::CSSGroupingRule::reportMemoryUsage):

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::reportDescendantMemoryUsage):
(WebCore::CSSImageSetValue::ImageWithScale::reportMemoryUsage):

  • css/CSSImageValue.cpp:

(WebCore::CSSImageValue::reportDescendantMemoryUsage):

  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::reportMemoryUsage):

  • css/CSSMediaRule.cpp:

(WebCore::CSSMediaRule::reportMemoryUsage):

  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::reportMemoryUsage):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):

  • css/CSSProperty.cpp:

(WebCore::CSSProperty::reportMemoryUsage):

  • css/CSSReflectValue.cpp:

(WebCore::CSSReflectValue::reportDescendantMemoryUsage):

  • css/CSSRule.cpp:

(WebCore::CSSRule::reportMemoryUsage):

  • css/CSSRuleList.cpp:

(WebCore::StaticCSSRuleList::reportMemoryUsage):

  • css/CSSRuleList.h:
  • css/CSSSelectorList.cpp:

(WebCore::CSSSelectorList::reportMemoryUsage):

  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::reportMemoryUsage):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::reportMemoryUsage):

  • css/CSSValue.cpp:

(WebCore::TextCloneCSSValue::reportDescendantMemoryUsage):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::reportDescendantMemoryUsage):

  • css/CSSVariableValue.h:

(WebCore::CSSVariableValue::reportDescendantMemoryUsage):

  • css/FontFeatureValue.cpp:

(WebCore::FontFeatureValue::reportDescendantMemoryUsage):

  • css/FontValue.cpp:

(WebCore::FontValue::reportDescendantMemoryUsage):

  • css/MediaList.cpp:

(WebCore::MediaQuerySet::reportMemoryUsage):
(WebCore::MediaList::reportMemoryUsage):

  • css/MediaQuery.cpp:

(WebCore::MediaQuery::reportMemoryUsage):

  • css/MediaQueryExp.cpp:

(WebCore::MediaQueryExp::reportMemoryUsage):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::reportMemoryUsage):
(WebCore::StyleRuleCSSStyleDeclaration::reportMemoryUsage):
(WebCore::InlineCSSStyleDeclaration::reportMemoryUsage):

  • css/RuleFeature.cpp:

(WebCore::RuleFeatureSet::reportMemoryUsage):

  • css/RuleSet.cpp:

(WebCore::RuleData::reportMemoryUsage):
(WebCore::RuleSet::reportMemoryUsage):
(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):

  • css/ShadowValue.cpp:

(WebCore::ShadowValue::reportDescendantMemoryUsage):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::reportMemoryUsage):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::MatchedProperties::reportMemoryUsage):
(WebCore::StyleResolver::MatchedPropertiesCacheItem::reportMemoryUsage):
(WebCore::MediaQueryResult::reportMemoryUsage):
(WebCore::StyleResolver::reportMemoryUsage):

  • css/StyleRule.cpp:

(WebCore::StyleRule::reportDescendantMemoryUsage):
(WebCore::StyleRulePage::reportDescendantMemoryUsage):
(WebCore::StyleRuleFontFace::reportDescendantMemoryUsage):
(WebCore::StyleRuleGroup::reportDescendantMemoryUsage):
(WebCore::StyleRuleMedia::reportDescendantMemoryUsage):
(WebCore::StyleRuleRegion::reportDescendantMemoryUsage):
(WebCore::StyleRuleViewport::reportDescendantMemoryUsage):

  • css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::reportDescendantMemoryUsage):

  • css/StyleScopeResolver.cpp:

(WebCore::StyleScopeResolver::reportMemoryUsage):

  • css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::reportMemoryUsage):

  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::StyleKeyframe::reportMemoryUsage):
(WebCore::WebKitCSSKeyframeRule::reportMemoryUsage):

  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):
(WebCore::WebKitCSSKeyframesRule::reportMemoryUsage):

  • css/WebKitCSSSVGDocumentValue.cpp:

(WebCore::WebKitCSSSVGDocumentValue::reportDescendantMemoryUsage):

  • css/WebKitCSSShaderValue.cpp:

(WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):

  • css/WebKitCSSViewportRule.cpp:

(WebCore::WebKitCSSViewportRule::reportMemoryUsage):

  • dom/Attribute.h:

(WebCore::Attribute::reportMemoryUsage):

  • dom/CharacterData.cpp:

(WebCore::CharacterData::reportMemoryUsage):

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::reportMemoryUsage):

  • dom/ContainerNode.h:

(ContainerNode):

  • dom/Document.cpp:

(WebCore::Document::reportMemoryUsage):

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::reportMemoryUsage):

  • dom/DocumentOrderedMap.cpp:

(WebCore::DocumentOrderedMap::reportMemoryUsage):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):

  • dom/Element.cpp:

(WebCore::Element::reportMemoryUsage):

  • dom/ElementAttributeData.cpp:

(WebCore::ElementAttributeData::reportMemoryUsage):

  • dom/ElementRareData.cpp:

(WebCore::ElementRareData::reportMemoryUsage):

  • dom/ElementShadow.cpp:

(WebCore::ElementShadow::reportMemoryUsage):

  • dom/Event.cpp:

(WebCore::Event::reportMemoryUsage):

  • dom/LiveNodeList.cpp:

(WebCore::LiveNodeListBase::reportMemoryUsage):

  • dom/Node.cpp:

(WebCore::Node::reportMemoryUsage):

  • dom/NodeRareData.cpp:

(WebCore::NodeListsNodeData::reportMemoryUsage):
(WebCore::NodeRareData::reportMemoryUsage):

  • dom/QualifiedName.cpp:

(WebCore::QualifiedName::reportMemoryUsage):
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::reportMemoryUsage):

  • dom/SecurityContext.cpp:

(WebCore::SecurityContext::reportMemoryUsage):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::reportMemoryUsage):

  • dom/TreeScope.cpp:

(WebCore::TreeScope::reportMemoryUsage):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::reportMemoryUsage):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::reportMemoryUsage):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::reportMemoryUsage):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::reportMemoryUsage):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::reportMemoryUsage):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::reportMemoryUsage):

  • inspector/HeapGraphSerializer.cpp:

(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::reportMemoryUsage):

  • inspector/HeapGraphSerializer.h:

(HeapGraphSerializer):

  • inspector/InspectorBaseAgent.cpp:

(WebCore::InspectorBaseAgentInterface::reportMemoryUsage):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::reportMemoryUsage):

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::reportMemoryUsage):

  • inspector/InspectorDOMStorageResource.cpp:

(WebCore::InspectorDOMStorageResource::reportMemoryUsage):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::reportMemoryUsage):
(WebCore::ScriptDebugListener::Script::reportMemoryUsage):

  • inspector/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::reportMemoryUsage):

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::reportMemoryUsage):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::reportMemoryUsage):

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::reportMemoryUsage):

  • inspector/MemoryInstrumentationImpl.cpp:

(WebCore::MemoryInstrumentationClientImpl::reportMemoryUsage):
(WebCore::MemoryInstrumentationImpl::reportMemoryUsage):

  • inspector/NetworkResourcesData.cpp:

(WebCore::XHRReplayData::reportMemoryUsage):
(WebCore::NetworkResourcesData::ResourceData::reportMemoryUsage):
(WebCore::NetworkResourcesData::reportMemoryUsage):

  • loader/CachedMetadata.cpp:

(WebCore::CachedMetadata::reportMemoryUsage):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::reportMemoryUsage):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::reportMemoryUsage):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::reportMemoryUsage):

  • loader/Prerenderer.cpp:

(WebCore::Prerenderer::reportMemoryUsage):

  • loader/ResourceBuffer.cpp:

(WebCore::ResourceBuffer::reportMemoryUsage):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::reportMemoryUsage):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::reportMemoryUsage):

  • loader/SubstituteData.cpp:

(WebCore::SubstituteData::reportMemoryUsage):

  • loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::reportMemoryUsage):

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::reportMemoryUsage):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::reportMemoryUsage):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::reportMemoryUsage):

  • loader/cache/CachedResourceHandle.cpp:

(WebCore::CachedResourceHandleBase::reportMemoryUsage):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::reportMemoryUsage):

  • loader/cache/CachedSVGDocument.cpp:

(WebCore::CachedSVGDocument::reportMemoryUsage):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::reportMemoryUsage):

  • loader/cache/CachedShader.cpp:

(WebCore::CachedShader::reportMemoryUsage):

  • loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::reportMemoryUsage):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::reportMemoryUsage):

  • page/DOMTimer.cpp:

(WebCore::DOMTimer::reportMemoryUsage):

  • page/Frame.cpp:

(WebCore::Frame::reportMemoryUsage):

  • page/Page.cpp:

(WebCore::Page::reportMemoryUsage):

  • platform/KURL.cpp:

(WebCore::KURL::reportMemoryUsage):

  • platform/KURLGoogle.cpp:

(WebCore::KURLGooglePrivate::reportMemoryUsage):

  • platform/KURLWTFURLImpl.h:

(WebCore::KURLWTFURLImpl::reportMemoryUsage):

  • platform/ScrollableArea.cpp:

(WebCore::ScrollableArea::reportMemoryUsage):

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::reportMemoryUsage):

  • platform/audio/AudioArray.h:

(WebCore::AudioArray::reportMemoryUsage):

  • platform/audio/FFTFrame.cpp:

(WebCore::FFTFrame::reportMemoryUsage):

  • platform/audio/HRTFDatabase.cpp:

(WebCore::HRTFDatabase::reportMemoryUsage):

  • platform/audio/HRTFDatabaseLoader.cpp:

(WebCore::HRTFDatabaseLoader::reportMemoryUsage):

  • platform/audio/HRTFElevation.cpp:

(WebCore::HRTFElevation::reportMemoryUsage):

  • platform/audio/HRTFKernel.cpp:

(WebCore::HRTFKernel::reportMemoryUsage):

  • platform/audio/ffmpeg/FFTFrameFFMPEG.cpp:

(reportMemoryUsage):

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::reportMemoryUsage):
(WebCore::FrameData::reportMemoryUsage):

  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::reportMemoryUsage):

  • platform/graphics/GeneratorGeneratedImage.cpp:

(WebCore::GeneratorGeneratedImage::reportMemoryUsage):

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::reportMemoryUsage):

  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::reportMemoryUsage):

  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::reportMemoryUsage):

  • platform/graphics/chromium/GraphicsLayerChromium.cpp:

(WebCore::GraphicsLayerChromium::reportMemoryUsage):

  • platform/graphics/skia/ImageBufferSkia.cpp:

(WebCore::ImageBufferData::reportMemoryUsage):

  • platform/graphics/skia/MemoryInstrumentationSkia.cpp:

(reportMemoryUsage):

  • platform/graphics/skia/NativeImageSkia.cpp:

(WebCore::NativeImageSkia::reportMemoryUsage):

  • platform/image-decoders/ImageDecoder.cpp:

(WebCore::ImageFrame::reportMemoryUsage):
(WebCore):
(WebCore::ImageDecoder::reportMemoryUsage):

  • platform/image-decoders/skia/ImageDecoderSkia.cpp:

(WebCore::ImageFrame::reportMemoryUsage):

  • platform/network/FormData.cpp:

(WebCore::FormData::reportMemoryUsage):
(WebCore::FormDataElement::reportMemoryUsage):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::reportMemoryUsageBase):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::reportMemoryUsage):

  • platform/network/chromium/ResourceRequest.cpp:

(WebCore::ResourceRequest::reportMemoryUsage):

  • rendering/InlineBox.cpp:

(WebCore::InlineBox::reportMemoryUsage):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::reportMemoryUsage):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::reportMemoryUsage):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::reportMemoryUsage):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::reportMemoryUsage):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::reportMemoryUsage):
(WebCore::RenderFrameSet::GridAxis::reportMemoryUsage):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::reportMemoryUsage):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::reportMemoryUsage):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::reportMemoryUsage):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::reportMemoryUsage):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::reportMemoryUsage):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::reportMemoryUsage):

  • rendering/RenderTableCol.cpp:

(WebCore::RenderTableCol::reportMemoryUsage):

  • rendering/RenderTableRow.cpp:

(WebCore::RenderTableRow::reportMemoryUsage):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::reportMemoryUsage):
(WebCore::RenderTableSection::RowStruct::reportMemoryUsage):
(WebCore::RenderTableSection::CellStruct::reportMemoryUsage):

  • rendering/RenderText.cpp:

(WebCore::RenderText::reportMemoryUsage):

  • rendering/RenderView.cpp:

(WebCore::RenderView::reportMemoryUsage):

  • rendering/style/DataRef.h:

(WebCore::DataRef::reportMemoryUsage):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::reportMemoryUsage):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::reportMemoryUsage):

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::reportMemoryUsage):

  • svg/SVGPaint.cpp:

(WebCore::SVGPaint::reportDescendantMemoryUsage):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::reportMemoryUsage):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::reportMemoryUsage):

2:40 AM Changeset in webkit [141569] by pierre.rossi@gmail.com
  • 1 edit in trunk/Source/WebKit/qt/ChangeLog

[Qt] visibility of embedded widget
https://bugs.webkit.org/show_bug.cgi?id=108327

Rubber-stamped by Simon Hausmann.

In overriding Widget::hide in QtPluginWidget, we forgot to call the
parent implementation, which as it turns, out does sensible stuff.

  • WebCoreSupport/FrameLoaderClientQt.cpp:
2:37 AM Changeset in webkit [141568] by mihnea@adobe.com
  • 4 edits
    2 adds
    32 deletes in trunk/LayoutTests

[CSS Regions] Convert fast/regions/region-overflow-auto-overflow* to reftests
https://bugs.webkit.org/show_bug.cgi?id=108333

Reviewed by Tony Chang.

Add reftests, cleanup existing tests.

  • fast/regions/region-overflow-auto-overflow-hidden-expected.html: Added.
  • fast/regions/region-overflow-auto-overflow-hidden.html:
  • fast/regions/region-overflow-auto-overflow-visible-expected.html: Added.
  • fast/regions/region-overflow-auto-overflow-visible.html:
  • platform/chromium-linux-x86/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/chromium-linux-x86/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/chromium-linux/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
  • platform/chromium-linux/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/chromium-linux/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
  • platform/chromium-linux/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
  • platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/chromium-mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/chromium-mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/chromium/TestExpectations:
  • platform/chromium/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/chromium/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
  • platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
  • platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
  • platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
  • platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
  • platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
  • platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
  • platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
  • platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
  • platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
  • platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
2:35 AM Changeset in webkit [141567] by pierre.rossi@gmail.com
  • 2 edits in trunk/Source/WebKit/qt

[Qt] visibility of embedded widget
https://bugs.webkit.org/show_bug.cgi?id=108327

Rubber-stamped by Simon Hausmann.

In overriding Widget::show in QtPluginWidget, we forgot to call the
parent implementation, which as it turns, out does sensible stuff.

  • WebCoreSupport/FrameLoaderClientQt.cpp:
2:25 AM Changeset in webkit [141566] by Philippe Normand
  • 12 edits
    2 moves in trunk/Source

[GTK][GStreamer] FullscreenVideoControllerGtk implementation
https://bugs.webkit.org/show_bug.cgi?id=107398

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

NATIVE_FULLSCREEN_VIDEO support for the GTK port. The previous
FullscreenVideoController implementation was refactored as a
sub-class of FullscreenVideoControllerGStreamer and hooked in the
MediaPlayerPrivateGStreamer backend.

  • GNUmakefile.list.am:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
  • platform/graphics/gtk/FullscreenVideoControllerGtk.cpp: Renamed from Source/WebKit/gtk/WebCoreSupport/FullscreenVideoController.cpp.
  • platform/graphics/gtk/FullscreenVideoControllerGtk.h: Renamed from Source/WebKit/gtk/WebCoreSupport/FullscreenVideoController.h.

Source/WebKit/gtk:

Remove the FullscreenVideoController as it moved to
FullscreenVideoControllerGStreamer and its Gtk subclass in
WebCore. Hook in NATIVE_FULLSCREEN_VIDEO in the ChromeClient in
the two possible scenarios, wether FULLSCREEN_API is enabled or not.

  • GNUmakefile.am: Remove FullscreenVideoController.
  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit):
(WebKit::ChromeClient::enterFullscreenForNode): Hook
NATIVE_FULLSCREEN_VIDEO support.
(WebKit::ChromeClient::exitFullscreenForNode): Ditto
(WebKit::ChromeClient::enterFullScreenForElement): Ditto
(WebKit::ChromeClient::exitFullScreenForElement): Ditto

  • WebCoreSupport/ChromeClientGtk.h:

(ChromeClient):

  • WebCoreSupport/FullscreenVideoController.cpp: Removed.
  • WebCoreSupport/FullscreenVideoController.h: Removed.
  • webkit/webkitwebview.cpp: Remove FullscreenVideoController support.
  • webkit/webkitwebviewprivate.h: Ditto
2:11 AM Changeset in webkit [141565] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: fix cursor location in Source Frame
https://bugs.webkit.org/show_bug.cgi?id=108592

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-01
Reviewed by Pavel Feldman.

Normalize range before computing amount of lines in
_updateSourcePosition.

No new tests.

  • inspector/front-end/SourceFrame.js:

(WebInspector.SourceFrame.prototype._updateSourcePosition): Normalize text range.

  • inspector/front-end/inspector.css: Slightly bigger left padding for the text.

(.source-frame-position):

2:09 AM Changeset in webkit [141564] by haraken@chromium.org
  • 15 edits in trunk/Source/WebCore

Unreviewed build fix after r141553.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateImplementation):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::HasInstance):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::HasInstance):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::HasInstance):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::HasInstance):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::HasInstance):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::HasInstance):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::HasInstance):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::V8TestObj::HasInstance):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::HasInstance):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

2:07 AM Changeset in webkit [141563] by vsevik@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: Sources panel navigator reveal and expand fixes.
https://bugs.webkit.org/show_bug.cgi?id=108584

Reviewed by Pavel Feldman.

Navigator folders are not expanded by default anymore.
Made domain folder expanded for inspected page main frame domain.
UISourceCodes are now added to navigator before editor container
so that they could be revealed if editor container decides to show them.

  • inspector/front-end/NavigatorView.js:

(WebInspector.BaseNavigatorTreeElement.prototype.onattach):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):

  • inspector/front-end/ScriptsPanel.js:

(WebInspector.ScriptsPanel.prototype._addUISourceCode):

2:06 AM Changeset in webkit [141562] by Simon Hausmann
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] MiniBrowser segfaults on loading google.com
https://bugs.webkit.org/show_bug.cgi?id=108597

Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2013-02-01
Reviewed by Andreas Kling.

  • Platform/CoreIPC/unix/ConnectionUnix.cpp:

(CoreIPC::Connection::processMessage):
oolMessageBody should be properly initialized before it is used.

This patch also adds omitted break statement.

1:52 AM Changeset in webkit [141561] by aandrey@chromium.org
  • 3 edits in trunk/Source/WebCore

Web Inspector: [Canvas] drop trace log in the backend when deleting profile in frontend
https://bugs.webkit.org/show_bug.cgi?id=108591

Reviewed by Pavel Feldman.

Send a dropTraceLog command to the backend when deleting a profile header from the sidebar.
Before we were sending the command only upon deleting an existing view of a profile, so we would not
sent the command if the view was not created or if a profile header was removed via context menu (the ondelete() method).
Drive-by: fixed an odd formatting of property functions.

  • inspector/front-end/CanvasProfileView.js:

(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileHeader.prototype.reset):

  • inspector/front-end/ProfilesPanel.js:

(WebInspector.ProfileHeader.prototype.reset):
(WebInspector.ProfileHeader.prototype.load):
(WebInspector.ProfileHeader.prototype.canSaveToFile):
(WebInspector.ProfileHeader.prototype.saveToFile):
(WebInspector.ProfileHeader.prototype.loadFromFile):
(WebInspector.ProfileHeader.prototype.fromFile):
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):

1:32 AM Changeset in webkit [141560] by Chris Fleizach
  • 5 edits
    2 adds in trunk

AX: when aria-activedescendant is used with a ComboBox role, focus should not be changed
https://bugs.webkit.org/show_bug.cgi?id=108596

Reviewed by Ryosuke Niwa.

Source/WebCore:

Normally, an aria-activedescendant change causes a focus change to be triggered.
However, when used in conjunction with a combo box, this causes problems for screen readers.
Namely, the user expects focus to remain in the text field so that the user can keep typing.
If focus moves to an item in the combobox list, it is not possible to keep typing.

The solution is to not trigger a focus change in this case and instead use a selected children change notification.

Test: platform/mac/accessibility/combobox-activedescendant-notifications.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::shouldNotifyActiveDescendant):
(WebCore::AccessibilityRenderObject::shouldFocusActiveDescendant):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

LayoutTests:

  • platform/mac/accessibility/combobox-activedescendant-notifications-expected.txt: Added.
  • platform/mac/accessibility/combobox-activedescendant-notifications.html: Added.
1:17 AM Changeset in webkit [141559] by Chris Fleizach
  • 4 edits in trunk

Source/WebCore: [Mac] REGRESSION(r140974): accessibility/lists.html fails on Lion=
https://bugs.webkit.org/show_bug.cgi?id=108291

Reviewed by Ryosuke Niwa.

This accounts for differences in what AppKit gives for accessibility role descriptions between platforms
when the subrole is not recognized, and standardizes it for WebKit.

Unskip a failing Lion test

  • accessibility/mac/WebAccessibilityObjectWrapper.mm:

(-[WebAccessibilityObjectWrapper roleDescription]):

LayoutTests: [Mac] REGRESSION(r140974): accessibility/lists.html fails on Lion
https://bugs.webkit.org/show_bug.cgi?id=108291

Reviewed by Ryosuke Niwa.

  • platform/mac/TestExpectations:
1:06 AM Changeset in webkit [141558] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Replace localeCompare in NavigatorView with compareTo.
https://bugs.webkit.org/show_bug.cgi?id=108585

Reviewed by Pavel Feldman.

Replaced String.prototype.localeCompare with String.prototype.compareTo
in NavigatorView to improve performance.

  • inspector/front-end/NavigatorView.js:

(WebInspector.NavigatorTreeOutline._treeElementsCompare):

12:57 AM Changeset in webkit [141557] by vsevik@chromium.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: File system pending requests list is not cleared after processing.
https://bugs.webkit.org/show_bug.cgi?id=108573

Reviewed by Pavel Feldman.

  • inspector/front-end/IsolatedFileSystemModel.js:

(WebInspector.IsolatedFileSystemModel.prototype._processPendingFileSystemRequests):

12:52 AM Changeset in webkit [141556] by tsepez@chromium.org
  • 5 edits in trunk/Source/WebCore

Dubious cast from HTMLCollection to HTMLAllCollection
https://bugs.webkit.org/show_bug.cgi?id=108538

Reviewed by Adam Barth.

Patch is tested by enabling V8 binding integrity on HTMLAllCollection and
running the existing tests without introducing new crashes.

  • dom/Document.cpp:

(WebCore::Document::all):
Pass correct type to template.

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::create):
(WebCore::HTMLAllCollection::HTMLAllCollection):

  • html/HTMLAllCollection.h:

(HTMLAllCollection):
Make create() method arguments compatible with template above.

  • html/HTMLAllCollection.idl:

Enable binding integrity.

12:50 AM Changeset in webkit [141555] by commit-queue@webkit.org
  • 16 edits
    2 adds in trunk

Web Inspector: Add support for handling modal dialogs
https://bugs.webkit.org/show_bug.cgi?id=107883

Patch by Ken Kania <kkania@chromium.org> on 2013-02-01
Reviewed by Pavel Feldman.

Introduce support for being notified when a JavaScript modal dialog
is opening and closing, as well as a new command for accepting or
dismissing the dialog.

Source/WebCore:

Test: inspector-protocol/page/willRunJavaScriptDialog.html

  • inspector/Inspector.json:
  • inspector/InspectorClient.h:

(WebCore::InspectorClient::handleJavaScriptDialog):
(InspectorClient):

  • inspector/InspectorInstrumentation.cpp:

(WebCore):
(WebCore::InspectorInstrumentation::willRunJavaScriptDialogImpl):
(WebCore::InspectorInstrumentation::didRunJavaScriptDialogImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willRunJavaScriptDialog):
(WebCore):
(WebCore::InspectorInstrumentation::didRunJavaScriptDialog):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::willRunJavaScriptDialog):
(WebCore):
(WebCore::InspectorPageAgent::didRunJavaScriptDialog):
(WebCore::InspectorPageAgent::handleJavaScriptDialog):

  • inspector/InspectorPageAgent.h:
  • inspector/front-end/ResourceTreeModel.js:

(WebInspector.PageDispatcher.prototype.frameStartedLoading):
(WebInspector.PageDispatcher.prototype.frameStoppedLoading):
(WebInspector.PageDispatcher.prototype.frameScheduledNavigation):
(WebInspector.PageDispatcher.prototype.frameClearedScheduledNavigation):
(WebInspector.PageDispatcher.prototype.javascriptDialogOpening):
(WebInspector.PageDispatcher.prototype.javascriptDialogClosed):

  • page/Chrome.cpp:

(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):

Source/WebKit/chromium:

  • public/WebDevToolsAgent.h:
  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::handleJavaScriptDialog):
(WebKit):

  • src/InspectorClientImpl.h:

(InspectorClientImpl):

  • src/WebDevToolsAgentImpl.cpp:

(BrowserDataHintStringValues):
(WebKit::WebDevToolsAgentImpl::captureScreenshot):
(WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
(WebKit):
(WebKit::browserHintToString):
(WebKit::browserHintFromString):
(WebKit::WebDevToolsAgent::patchWithBrowserData):

  • src/WebDevToolsAgentImpl.h:

(WebDevToolsAgentImpl):

LayoutTests:

  • inspector-protocol/page/javascriptDialogEvents-expected.txt: Added.
  • inspector-protocol/page/javascriptDialogEvents.html: Added.
12:48 AM Changeset in webkit [141554] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source

Touch disambiguation blacklist is not being queried properly
https://bugs.webkit.org/show_bug.cgi?id=108222

Patch by Dan Alcantara <dfalcantara@chromium.org> on 2013-02-01
Reviewed by Adam Barth.

TEST=WebFrameTest::DisambiguationPopupBlacklist

Source/WebCore:

Fix the blacklist so that we check it for the right nodes.
Add a chromium test to check that the blacklist is being built and used
correctly. Also update the other DisambiguationPopup tests to
use the new page scale method.

  • page/TouchDisambiguation.cpp:

(WebCore::findGoodTouchTargets):

Source/WebKit/chromium:

Fix the blacklist so that we check it for the right nodes.
Add a test to check that the blacklist is being built and used
correctly. Also update the other DisambiguationPopup tests to
use the new page scale method.

  • tests/WebFrameTest.cpp:
  • tests/data/disambiguation_popup_blacklist.html: Added.
12:45 AM Changeset in webkit [141553] by haraken@chromium.org
  • 28 edits in trunk/Source/WebCore

[V8] Add a temporary optional Isolate parameter to HasInstance()
https://bugs.webkit.org/show_bug.cgi?id=108567

Reviewed by Adam Barth.

The optional Isolate parameter will be removed once all call sites have an Isolate.
It will require several patches.

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm:

(GenerateHeader):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
(GenerateImplementation):

  • bindings/scripts/test/V8/V8Float64Array.cpp:

(WebCore::V8Float64Array::HasInstance):

  • bindings/scripts/test/V8/V8Float64Array.h:

(V8Float64Array):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:

(WebCore::V8TestActiveDOMObject::HasInstance):

  • bindings/scripts/test/V8/V8TestActiveDOMObject.h:

(V8TestActiveDOMObject):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:

(WebCore::V8TestCustomNamedGetter::HasInstance):

  • bindings/scripts/test/V8/V8TestCustomNamedGetter.h:

(V8TestCustomNamedGetter):

  • bindings/scripts/test/V8/V8TestEventConstructor.cpp:

(WebCore::V8TestEventConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestEventConstructor.h:

(V8TestEventConstructor):

  • bindings/scripts/test/V8/V8TestEventTarget.cpp:

(WebCore::V8TestEventTarget::HasInstance):

  • bindings/scripts/test/V8/V8TestEventTarget.h:

(V8TestEventTarget):

  • bindings/scripts/test/V8/V8TestException.cpp:

(WebCore::V8TestException::HasInstance):

  • bindings/scripts/test/V8/V8TestException.h:

(V8TestException):

  • bindings/scripts/test/V8/V8TestInterface.cpp:

(WebCore::V8TestInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestInterface.h:

(V8TestInterface):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:

(WebCore::V8TestMediaQueryListListener::HasInstance):

  • bindings/scripts/test/V8/V8TestMediaQueryListListener.h:

(V8TestMediaQueryListListener):

  • bindings/scripts/test/V8/V8TestNamedConstructor.cpp:

(WebCore::V8TestNamedConstructor::HasInstance):

  • bindings/scripts/test/V8/V8TestNamedConstructor.h:

(V8TestNamedConstructor):

  • bindings/scripts/test/V8/V8TestNode.cpp:

(WebCore::V8TestNode::HasInstance):

  • bindings/scripts/test/V8/V8TestNode.h:

(V8TestNode):

  • bindings/scripts/test/V8/V8TestObj.cpp:

(WebCore::TestObjV8Internal::overloadedMethodCallback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):
(WebCore::V8TestObj::HasInstance):

  • bindings/scripts/test/V8/V8TestObj.h:

(V8TestObj):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:

(WebCore::V8TestOverloadedConstructors::constructorCallback):
(WebCore::V8TestOverloadedConstructors::HasInstance):

  • bindings/scripts/test/V8/V8TestOverloadedConstructors.h:

(V8TestOverloadedConstructors):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:

(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

  • bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

(V8TestSerializedScriptValueInterface):

12:44 AM Changeset in webkit [141552] by morrita@google.com
  • 2 edits in trunk/LayoutTests

[Chromium] Unreviewed, marking table-section-overflow-clip-crash.html failed.

  • platform/chromium/TestExpectations:
12:44 AM Changeset in webkit [141551] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

[CPP,GObject,ObjC] Add 'static' skip to CodeGenerator{CPP,GObject,ObjC}.pm
https://bugs.webkit.org/show_bug.cgi?id=108578

Patch by Nils Barth <nbarth@google.com> on 2013-02-01
Reviewed by Kentaro Hara.

Since CPP/GObject/ObjC code generators (CodeGenerator{CPP,GObject,ObjC}.pm)
do not support static attributes, add test to skip these.
This lets us remove #if macro from static in test files and not need
these in future.

Test: bindings/scripts/test/TestObj.idl (run-bindings-test)
Test: bindings/scripts/test/TestSupplemental.idl (run-bindings-test)

  • bindings/scripts/CodeGeneratorCPP.pm:

(SkipAttribute):

  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipAttribute):

  • bindings/scripts/CodeGeneratorObjC.pm:

(SkipAttribute):

  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestSupplemental.idl:
12:37 AM Changeset in webkit [141550] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/chromium

[chromium] only show checkboxes for FPS meter and continuous painting when compositing mode is forced
https://bugs.webkit.org/show_bug.cgi?id=108236

Patch by Eberhard Graether <egraether@google.com> on 2013-02-01
Reviewed by Pavel Feldman.

This change hides the checkboxes for FPS meter and continuous painting if compositing mode is not forced.
This way the checkboxes only show up for users that can make use of these features.

  • src/InspectorClientImpl.cpp:

(WebKit::InspectorClientImpl::canShowFPSCounter):
(WebKit::InspectorClientImpl::canContinuouslyPaint):

12:30 AM Changeset in webkit [141549] by morrita@google.com
  • 2 edits in trunk/LayoutTests

Unreviewed, rebaselining a result.

  • platform/chromium/fast/js/kde/inbuilt_function_tostring-expected.txt:
12:27 AM Changeset in webkit [141548] by haraken@chromium.org
  • 4 edits in trunk/Source/WebCore

[V8] Remove V8GCController::m_edenNodes
https://bugs.webkit.org/show_bug.cgi?id=108579

Reviewed by Adam Barth.

Currently V8GCController::m_edenNodes stores a list of nodes whose
wrappers have been created since the latest GC. The reason why we
needed m_edenNodes is that there was no way to know a list of wrappers
in the new space of V8. By using m_edenNodes, we had been approximating
'wrappers in the new space' by 'wrappers that have been created since
the latest GC'.

Now V8 provides VisitHandlesForPartialDependence(), with which WebKit
can know a list of wrappers in the new space. By using the API, we can
remove V8GCController::m_edenNodes. The benefit is that (1) we no longer
need to keep m_edenNodes and that (2) it enables more precise minor
DOM GC (Remember that m_edenNodes was just an approximation).

Performance benchmark: https://bugs.webkit.org/attachment.cgi?id=185940
The benchmark runs 300 iterations, each of which creates 100000 elements.
The benchmark measures average, min, median, max and stdev of execution times
of the 300 iterations. This will tell us the worst-case overhead of this change.

Before:

mean=59.91ms, min=39ms, median=42ms, max=258ms, stdev=47.48ms

After:

mean=58.75ms, min=35ms, median=41ms, max=250ms, stdev=47.32ms

As shown above, I couldn't observe any performance regression.

No tests. No change in behavior.

  • bindings/v8/DOMDataStore.h:

(WebCore::DOMDataStore::setWrapperInObject):

  • bindings/v8/V8GCController.cpp:

(WebCore::gcTree):
(WebCore):
(MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::notifyFinished):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):

  • bindings/v8/V8GCController.h:

(V8GCController):

12:19 AM Changeset in webkit [141547] by vsevik@chromium.org
  • 8 edits in trunk

Web Inspector: Use String.prototype.startsWith instead of String.prototype.indexOf when possible
https://bugs.webkit.org/show_bug.cgi?id=108575

Reviewed by Yury Semikhatsky.

Source/WebCore:

  • inspector/front-end/FileMapping.js:

(WebInspector.FileMapping.prototype._entryMatchesURL):
(WebInspector.FileMapping.prototype.urlForURI):

  • inspector/front-end/FileSystemMapping.js:

(get WebInspector.FileSystemMappingImpl.prototype.fileForURI):
(get WebInspector.FileSystemMappingImpl.prototype.uriForPath):

LayoutTests:

  • http/tests/inspector/console-cd-completions.html:
  • http/tests/inspector/console-cd.html:
  • http/tests/inspector/indexeddb/indexeddb-test.js:

(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer.consoleMessageOverride):
(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer):

  • inspector/network-status-non-http.html:
12:02 AM Changeset in webkit [141546] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Qt] Add MessageFlags.h in Target.pri
https://bugs.webkit.org/show_bug.cgi?id=108583

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-01-31
Reviewed by Kentaro Hara.

Since MessageDecoder and MessageEncoder include MessageFlags.h, it
should be included in Target.pri.

  • Target.pri:
Note: See TracTimeline for information about the timeline view.