Timeline



Apr 28, 2013:

11:51 PM Changeset in webkit [149270] by zandobersek@gmail.com
  • 3 edits
    1 delete in trunk/Tools

Remove Chromium code from Tools/BuildSlaveSupport
https://bugs.webkit.org/show_bug.cgi?id=115325

Reviewed by Benjamin Poulain.

Remove the two Chromium-specific scripts and the Chromium-specific parts from the code
covering archiving test results and built products.

  • BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):
(extractBuiltProduct):

  • BuildSlaveSupport/chromium/output-android-device-status: Removed.
  • BuildSlaveSupport/chromium/remove-crash-logs: Removed.
  • BuildSlaveSupport/test-result-archive:

(archiveTestResults):

11:43 PM Changeset in webkit [149269] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove support for Chromium from webkitdirs.pm
https://bugs.webkit.org/show_bug.cgi?id=115338

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-28
Reviewed by Darin Adler.

  • Scripts/webkitdirs.pm:

(determineBaseProductDir):
(argumentsForConfiguration):
(builtDylibPathForName):
(determineIsQt):
(isAppleWebKit):

11:17 PM Changeset in webkit [149268] by zandobersek@gmail.com
  • 11 edits in trunk

Rename TestRunner's setAudioData to setAudioResult
https://bugs.webkit.org/show_bug.cgi?id=115326

Reviewed by Darin Adler.

Tools:

Rename the TestRunner's setAudioData method to setAudioResult. The new name better conveys the method's purpose
than the previous one. The change is a simple rename, there's no change in the method's functionality. The
affected tests are adjusted accordingly.

  • DumpRenderTree/qt/TestRunnerQt.cpp:

(TestRunnerQt::setAudioResult):

  • DumpRenderTree/qt/TestRunnerQt.h:

(TestRunnerQt):

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setAudioResult):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner):

LayoutTests:

Adjust the testRunner.setAudioData references/callsites, the method is now named setAudioResult.

  • platform/efl-wk1/TestExpectations:
  • webaudio/resources/audio-codec-test.js:

(finishedLoading):

  • webaudio/resources/audio-testing.js:

(finishAudioTest):

  • webaudio/test-basic.html:
10:04 PM Changeset in webkit [149267] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed fix build break on EFL port since r149259.

In EFL port, there is a non-compatible code when compiling based on C++11. This is a trivial build fix.

I got a confirm from Sam about landing a trivial build fix patch without sign-off from
WK2 owner.

  • UIProcess/API/efl/EwkViewCallbacks.h:
9:13 PM Changeset in webkit [149266] by ryuan.choi@samsung.com
  • 2 edits in trunk

[EFL][CMAKE] Build break after r149259
https://bugs.webkit.org/show_bug.cgi?id=115339

Reviewed by Gyuyoung Kim.

r149259 used c++11 features(Right angle bracket, Range-based for-loop).
This patch enforces c++0x when cmake based ports build WebKit2 using gcc.

  • Source/cmake/WebKitHelpers.cmake:
5:57 PM Changeset in webkit [149265] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Get rid of a duplicate file from LayoutTests/TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=115337

Unreviewed gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-28

  • TestExpectations: Remove one of two svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm.
5:40 PM Changeset in webkit [149264] by fpizlo@apple.com
  • 8 edits in branches/dfgFourthTier/Source/JavaScriptCore

FTL should support double variables
https://bugs.webkit.org/show_bug.cgi?id=113624

Reviewed by Geoffrey Garen.

Made all of the operations that the FTL already supports, also support doubles.
OSR exit already basically had everything it needed, so no changes there. This
mostly just glues together bits of DFG IR to LLVM IR, in a straight-forward way.

  • ftl/FTLAbbreviations.h:

(FTL):
(JSC::FTL::doubleType):
(JSC::FTL::constReal):
(JSC::FTL::buildPhi):
(JSC::FTL::addIncoming):
(JSC::FTL::buildFAdd):
(JSC::FTL::buildFSub):
(JSC::FTL::buildFMul):
(JSC::FTL::buildFNeg):
(JSC::FTL::buildSIToFP):
(JSC::FTL::buildUIToFP):
(JSC::FTL::buildBitCast):
(JSC::FTL::buildFCmp):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLCommonValues.cpp:

(JSC::FTL::CommonValues::CommonValues):

  • ftl/FTLCommonValues.h:

(CommonValues):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileGetLocal):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::compileAdd):
(JSC::FTL::LowerDFGToLLVM::compileArithSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::LowerDFGToLLVM::compileUInt32ToNumber):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareLess):
(JSC::FTL::LowerDFGToLLVM::lowDouble):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
(JSC::FTL::LowerDFGToLLVM::isCellOrMisc):
(JSC::FTL::LowerDFGToLLVM::unboxDouble):
(JSC::FTL::LowerDFGToLLVM::boxDouble):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::speculateNumber):
(JSC::FTL::LowerDFGToLLVM::speculateRealNumber):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::constDouble):
(Output):
(JSC::FTL::Output::phi):
(JSC::FTL::Output::doubleAdd):
(JSC::FTL::Output::doubleSub):
(JSC::FTL::Output::doubleMul):
(JSC::FTL::Output::doubleNeg):
(JSC::FTL::Output::intToFP):
(JSC::FTL::Output::intToDouble):
(JSC::FTL::Output::unsignedToFP):
(JSC::FTL::Output::unsignedToDouble):
(JSC::FTL::Output::bitCast):
(JSC::FTL::Output::loadDouble):
(JSC::FTL::Output::storeDouble):
(JSC::FTL::Output::doubleEqual):
(JSC::FTL::Output::doubleNotEqualOrUnordered):
(JSC::FTL::Output::doubleLessThan):
(JSC::FTL::Output::doubleLessThanOrEqual):
(JSC::FTL::Output::doubleGreaterThan):
(JSC::FTL::Output::doubleGreaterThanOrEqual):
(JSC::FTL::Output::doubleEqualOrUnordered):
(JSC::FTL::Output::doubleNotEqual):
(JSC::FTL::Output::doubleLessThanOrUnordered):
(JSC::FTL::Output::doubleLessThanOrEqualOrUnordered):
(JSC::FTL::Output::doubleGreaterThanOrUnordered):
(JSC::FTL::Output::doubleGreaterThanOrEqualOrUnordered):
(JSC::FTL::Output::testIsZero64):

3:45 PM Changeset in webkit [149263] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebKit

Windows build fix.

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

  • WebKit.vcproj/WebKitExports.def.in:
3:21 PM Changeset in webkit [149262] by rniwa@webkit.org
  • 18 edits
    2 deletes in trunk/Source

StaticHashSetNodeList is unnecessary
https://bugs.webkit.org/show_bug.cgi?id=115219

Reviewed by Antonio Gomes.

Source/WebCore:

Moved Document::nodesFromRect into Internals::nodesFromRect per
https://chromium.googlesource.com/chromium/blink/+/78207c5c34383fbb807bb9347deb67168f09bb04.

Also made TouchAdjustment functions use HashListSet directly instead of wrapping it inside
a StaticHashSetNodeList since there was no need to use the latter.

With these two changes, I deleted StaticHashSetNodeList.

  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore):

  • dom/Document.h:

(Document):

  • dom/StaticHashSetNodeList.cpp: Removed.
  • dom/StaticHashSetNodeList.h: Removed.
  • page/EventHandler.cpp:

(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):

  • page/TouchAdjustment.cpp:

(WebCore::TouchAdjustment::compileSubtargetList):
(WebCore::TouchAdjustment::compileZoomableSubtargets):
(WebCore::findBestClickableCandidate):
(WebCore::findBestContextMenuCandidate):
(WebCore::findBestZoomableArea):

  • page/TouchAdjustment.h:

(WebCore):

  • testing/Internals.cpp:

(WebCore::Internals::nodesFromRect):

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/win:

  • WebKit.vcproj/WebKitExports.def.in:
2:52 PM Changeset in webkit [149261] by dino@apple.com
  • 12 edits
    2 deletes in trunk

[Mac] Disable canvas backing store scaling (HIGH_DPI_CANVAS)
https://bugs.webkit.org/show_bug.cgi?id=115310

Reviewed by Simon Fraser.

Source/JavaScriptCore:

Remove ENABLE_HIGH_DPI_CANVAS_macosx.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Disable the automatic pixel doubling in canvas backing stores on high
dpi devices. This will potentially make canvases look worse of high dpi
displays, but only if they were ignoring devicePixelRatio. Since the
majority of high dpi displays *do not* auto-double (including mobile
devices and other desktop browsers), this provides consistency and less
chance of unnecessary memory use.

  • Configurations/FeatureDefines.xcconfig: Remove ENABLE_HIGH_DPI_CANVAS_macosx.

Source/WebKit/mac:

Remove ENABLE_HIGH_DPI_CANVAS_macosx.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Remove ENABLE_HIGH_DPI_CANVAS_macosx.

  • Configurations/FeatureDefines.xcconfig:

LayoutTests:

No need for platform-specific results any more.

  • fast/canvas/2d.backingStorePixelRatio-expected.txt:
  • fast/canvas/2d.imageDataHD-expected.txt:
  • fast/canvas/canvas-resize-reset-pixelRatio-expected.txt:
  • platform/win/fast/canvas/2d.backingStorePixelRatio-expected.txt: Removed.
  • platform/win/fast/canvas/canvas-resize-reset-pixelRatio-expected.txt: Removed.
1:31 PM Changeset in webkit [149260] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

[WebKit2] Adopt new API for detecting window occlusion
https://bugs.webkit.org/show_bug.cgi?id=115334

Reviewed by Simon Fraser.

Switch off of WKSI for window occlusion and use the new NSWindowDidChangeOcclusionState notification
instead.

  • UIProcess/API/mac/WKView.mm:

(-[WKView dealloc]):
(-[WKView addWindowObserversForWindow:]):
(-[WKView removeWindowObservers]):
(-[WKView viewWillMoveToWindow:]):
(-[WKView viewDidMoveToWindow]):
(-[WKView _windowDidOrderOnScreen:]):
(-[WKView _windowDidChangeOcclusionState:]):
(-[WKView _setIsWindowOccluded:]):
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]):
(-[WKView windowOcclusionDetectionEnabled]):
(-[WKView setWindowOcclusionDetectionEnabled:]):
Only compile occlusion detection code where supported and remove calls to register/deregister
for detection callbacks, now that NSWindow will handle that for us. We also no longer need to
track all the WKViews, as that was only required to lookup the view that matched the window number
returned from the occlusion callback.

11:17 AM Changeset in webkit [149259] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Use OwnPtr<PluginControllerProxy> for storing plug-in controllers in WebProcessConnection
https://bugs.webkit.org/show_bug.cgi?id=115259

Reviewed by Andreas Kling.

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::addPluginControllerProxy):
(WebKit::WebProcessConnection::removePluginControllerProxy):
(WebKit::WebProcessConnection::didClose):

  • PluginProcess/WebProcessConnection.h:

(WebProcessConnection):

5:39 AM Changeset in webkit [149258] by zandobersek@gmail.com
  • 3 edits
    17 deletes in trunk

[WKTR] Tests dumping audio data shouldn't dump pixels
https://bugs.webkit.org/show_bug.cgi?id=115270

Reviewed by Benjamin Poulain.

Tools:

Prevent dumping the pixel output when Web Audio tests are dumping output data
as the testing output. Pixel output in these tests has no real meaning and is
as such unnecessary.

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setAudioData):

LayoutTests:

Remove the now-unnecessary pixel baselines for audio tests that were used on the EFL WK2 platform.

  • platform/efl-wk2/webaudio/audiobuffersource-expected.png: Removed.
  • platform/efl-wk2/webaudio/audiobuffersource-loop-points-expected.png: Removed.
  • platform/efl-wk2/webaudio/audiobuffersource-multi-channels-expected.png: Removed.
  • platform/efl-wk2/webaudio/audiobuffersource-playbackrate-expected.png: Removed.
  • platform/efl-wk2/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.png: Removed.
  • platform/efl-wk2/webaudio/codec-tests/wav/24bit-22khz-resample-expected.png: Removed.
  • platform/efl-wk2/webaudio/codec-tests/wav/24bit-44khz-expected.png: Removed.
  • platform/efl-wk2/webaudio/gain-expected.png: Removed.
  • platform/efl-wk2/webaudio/mixing-expected.png: Removed.
  • platform/efl-wk2/webaudio/oscillator-custom-expected.png: Removed.
  • platform/efl-wk2/webaudio/oscillator-sawtooth-expected.png: Removed.
  • platform/efl-wk2/webaudio/oscillator-sine-expected.png: Removed.
  • platform/efl-wk2/webaudio/oscillator-square-expected.png: Removed.
  • platform/efl-wk2/webaudio/oscillator-triangle-expected.png: Removed.
  • platform/efl-wk2/webaudio/up-mixing-mono-51-expected.png: Removed.
  • platform/efl-wk2/webaudio/up-mixing-mono-stereo-expected.png: Removed.
  • platform/efl-wk2/webaudio/up-mixing-stereo-51-expected.png: Removed.
2:38 AM Changeset in webkit [149257] by Christophe Dumez
  • 61 edits in trunk/Source/WebCore

Get rid of [Callback] IDL extended attribute for parameters
https://bugs.webkit.org/show_bug.cgi?id=115250

Reviewed by Kentaro Hara.

Remove the WebKit-specific [Callback] extended attribute and make the bindings
generator smart enough to know when a parameter is of callback type on its
own.

No new tests, no behavior change.

  • DerivedSources.make: Use WebCore/Modules as IDL include path instead of using

subdirs. The generator will search recursively anyway and the list of subdirs was
incomplete.

  • Modules/filesystem/DOMWindowFileSystem.idl:
  • Modules/filesystem/DirectoryEntry.idl:
  • Modules/filesystem/DirectoryReader.idl:
  • Modules/filesystem/Entry.idl:
  • Modules/filesystem/FileEntry.idl:
  • Modules/filesystem/WorkerContextFileSystem.idl:
  • Modules/mediastream/NavigatorMediaStream.idl:
  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/notifications/Notification.idl:
  • Modules/notifications/NotificationCenter.idl:
  • Modules/quota/StorageInfo.idl:
  • Modules/quota/StorageQuota.idl:
  • Modules/webaudio/AudioContext.idl:
  • Modules/webdatabase/DOMWindowWebDatabase.idl:
  • Modules/webdatabase/Database.idl:
  • Modules/webdatabase/DatabaseSync.idl:
  • Modules/webdatabase/SQLTransaction.idl:
  • Modules/webdatabase/WorkerContextWebDatabase.idl:
  • bindings/gobject/GNUmakefile.am: Add missing IDL include dirs.
  • bindings/scripts/CodeGenerator.pm:

(IsWrapperType):
(IsCallbackInterface):

  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateParametersCheckExpression):
(GenerateParametersCheck):

  • bindings/scripts/IDLAttributes.txt: Remove "Callback" extended attribute.
  • bindings/scripts/test/CPP/WebDOMTestCallback.cpp:

(WebDOMTestCallback::callbackWithArrayParam):
(WebDOMTestCallback::callbackWithSerializedScriptValueParam):
(WebDOMTestCallback::callbackWithNonBoolReturnType):
(WebDOMTestCallback::callbackRequiresThisToPass):

  • bindings/scripts/test/CPP/WebDOMTestCallback.h:

(WebDOMTestCallback):

  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:

(WebDOMTestObj::convert1):
(WebDOMTestObj::convert2):
(WebDOMTestObj::convert4):
(WebDOMTestObj::convert5):

  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:

(WebDOMTestSerializedScriptValueInterface::acceptTransferList):
(WebDOMTestSerializedScriptValueInterface::multiTransferList):

  • bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:

(WebDOMTestSerializedScriptValueInterface):

  • bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp:

(WebDOMTestTypedefs::multiTransferList):

  • bindings/scripts/test/CPP/WebDOMTestTypedefs.h:

(WebDOMTestTypedefs):

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:

(webkit_dom_test_callback_callback_with_array_param):
(webkit_dom_test_callback_callback_with_serialized_script_value_param):
(webkit_dom_test_callback_callback_with_non_bool_return_type):
(webkit_dom_test_callback_callback_requires_this_to_pass):

  • bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:

(webkit_dom_test_obj_convert1):
(webkit_dom_test_obj_convert2):
(webkit_dom_test_obj_convert4):
(webkit_dom_test_obj_convert5):

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:

(webkit_dom_test_serialized_script_value_interface_accept_transfer_list):
(webkit_dom_test_serialized_script_value_interface_multi_transfer_list):

  • bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:

(webkit_dom_test_typedefs_multi_transfer_list):

  • bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
  • bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallback::callbackWithArrayParam):
(WebCore::JSTestCallback::callbackWithSerializedScriptValueParam):
(WebCore::JSTestCallback::callbackRequiresThisToPass):

  • bindings/scripts/test/JS/JSTestCallback.h:

(JSTestCallback):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionAcceptTransferList):
(WebCore::jsTestSerializedScriptValueInterfacePrototypeFunctionMultiTransferList):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::jsTestTypedefsPrototypeFunctionMultiTransferList):

  • bindings/scripts/test/ObjC/DOMTestCallback.h:
  • bindings/scripts/test/ObjC/DOMTestCallback.mm:

(-[DOMTestCallback callbackWithArrayParam:]):
(-[DOMTestCallback callbackWithSerializedScriptValueParam:strArg:]):
(-[DOMTestCallback callbackWithNonBoolReturnType:]):
(-[DOMTestCallback callbackRequiresThisToPass:testNodeParam:]):

  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj convert1:]):
(-[DOMTestObj convert2:]):
(-[DOMTestObj convert4:]):
(-[DOMTestObj convert5:]):

  • bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:

(-[DOMTestSerializedScriptValueInterface acceptTransferList:transferList:]):
(-[DOMTestSerializedScriptValueInterface multiTransferList:tx:second:txx:]):

  • bindings/scripts/test/ObjC/DOMTestTypedefs.h:
  • bindings/scripts/test/ObjC/DOMTestTypedefs.mm:

(-[DOMTestTypedefs multiTransferList:tx:second:txx:]):

  • bindings/scripts/test/TestCallback.idl: Use valid types instead of Class1, Class2, ...

so that the bindings generator does not complain about not being able to resolve
them.

  • bindings/scripts/test/TestObj.idl: Use valid parameter types instead of 'a', 'b', 'd', 'e'

so that the bindings generator does not complain about them.

  • bindings/scripts/test/TestSerializedScriptValueInterface.idl:
  • bindings/scripts/test/TestTypedefs.idl:
  • css/FontLoader.idl:
  • dom/DataTransferItem.idl:
  • page/DOMWindow.idl:

Apr 27, 2013:

9:53 PM Changeset in webkit [149256] by jberlin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Build fix.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveBuffer):
Do not declare another variable with the same name.

8:51 PM Changeset in webkit [149255] by Darin Adler
  • 171 edits in trunk/Source

Move from constructor and member function adoptCF/NS to free function adoptCF/NS.
https://bugs.webkit.org/show_bug.cgi?id=115307

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • heap/HeapTimer.cpp:

(JSC::HeapTimer::HeapTimer):

  • runtime/VM.cpp:

(JSC::enableAssembler):
Use adoptCF free function.

Source/WebCore:

This change was done by a global replace followed by compiling and inspecting for
cases that needed to be tweaked by hand.

  • accessibility/ios/AXObjectCacheIOS.mm:

(WebCore::AXObjectCache::attachWrapper):

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::attachWrapper):

  • bridge/objc/objc_class.mm:

(JSC::Bindings::ObjcClass::methodNamed):
(JSC::Bindings::ObjcClass::fieldNamed):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcField::ObjcField):

  • editing/mac/EditorMac.mm:

(WebCore::Editor::fontAttributesForSelectionStart):

  • history/cf/HistoryPropertyList.cpp:

(WebCore::HistoryPropertyListWriter::releaseData):

  • html/HTMLMediaElement.cpp:

(WebCore::createFileURLForApplicationCacheResource):

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::createPropertyListRepresentation):
(WebCore::LegacyWebArchive::create):
(WebCore::LegacyWebArchive::rawDataRepresentation):

  • loader/archive/cf/LegacyWebArchiveMac.mm:

(WebCore::LegacyWebArchive::createPropertyListRepresentation):

  • loader/mac/ResourceLoaderMac.mm:

(WebCore::ResourceLoader::willCacheResponse):

  • page/CaptionUserPreferencesMac.mm:

(WebCore::CaptionUserPreferencesMac::userPrefersCaptions):
(WebCore::CaptionUserPreferencesMac::userPrefersSubtitles):
(WebCore::CaptionUserPreferencesMac::captionsWindowCSS):
(WebCore::CaptionUserPreferencesMac::captionsBackgroundCSS):
(WebCore::CaptionUserPreferencesMac::captionsTextColor):
(WebCore::CaptionUserPreferencesMac::captionsDefaultFontCSS):
(WebCore::CaptionUserPreferencesMac::preferredLanguages):
(WebCore::trackDisplayName):

  • platform/Language.cpp:

(WebCore::displayNameForLanguageLocale):

  • platform/LocalizedStrings.cpp:

(WebCore::contextMenuItemTagSearchWeb):
(WebCore::imageTitle):

  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):

  • platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::AudioFileReader):

  • platform/cf/KURLCFNet.cpp:

(WebCore::KURL::fileSystemPath):

  • platform/cf/SharedBufferCF.cpp:

(WebCore::SharedBuffer::maybeTransferPlatformData):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setContentsToImage):

  • platform/graphics/ca/mac/LayerFlushSchedulerMac.cpp:

(WebCore::LayerFlushScheduler::schedule):

  • platform/graphics/ca/mac/PlatformCAAnimationMac.mm:

(PlatformCAAnimation::PlatformCAAnimation):

  • platform/graphics/ca/mac/PlatformCAFiltersMac.mm:

(PlatformCAFilters::filterValueForOperation):

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::PlatformCALayer):
(PlatformCALayer::addAnimationForKey):
(PlatformCALayer::setBackgroundColor):
(PlatformCALayer::setBorderColor):

  • platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::BitmapImage::checkForSolidColor):
(WebCore::BitmapImage::getCGImageArray):

  • platform/graphics/cg/ColorCG.cpp:

(WebCore::cachedCGColor):

  • platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore::GraphicsContext3D::ImageExtractor::extractImage):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::applyStrokePattern):
(WebCore::GraphicsContext::applyFillPattern):
(WebCore::GraphicsContext::setURLForRect):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::createIOSurface):
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::putByteArray):
(WebCore::CGImageEncodeToData):
(WebCore::CGImageToDataURL):
(WebCore::ImageBuffer::toDataURL):
(WebCore::ImageDataToDataURL):

  • platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::getData):
(WebCore::ImageBufferData::putData):

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::Image::imageWithColorSpace):
(WebCore::Image::drawPattern):

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::ImageSource::setData):
(WebCore::ImageSource::isSizeAvailable):
(WebCore::ImageSource::frameSizeAtIndex):
(WebCore::ImageSource::orientationAtIndex):
(WebCore::ImageSource::getHotSpot):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::dataChanged):

  • platform/graphics/cg/PathCG.cpp:

(WebCore::createScratchContext):
(WebCore::Path::contains):

  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::setFont):
(WebCore::createFeatureSettingDictionary):
(WebCore::cascadeToLastResortFontDescriptor):
(WebCore::cascadeToLastResortAndDisableSwashesFontDescriptor):
(WebCore::FontPlatformData::ctFont):
(WebCore::FontPlatformData::description):

  • platform/graphics/gpu/mac/DrawingBufferMac.mm:

(WebCore::DrawingBuffer::DrawingBuffer):

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(-[WebCascadeList objectAtIndex:]):
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

  • platform/graphics/mac/FontCustomPlatformData.cpp:

(WebCore::createFontCustomPlatformData):

  • platform/graphics/mac/GlyphPageTreeNodeMac.cpp:

(WebCore::GlyphPage::fill):

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::GraphicsContext3D):

  • platform/graphics/mac/GraphicsContextMac.mm:

(WebCore::GraphicsContext::drawFocusRing):
(WebCore::linearRGBColorSpaceRef):

  • platform/graphics/mac/ImageMac.mm:

(WebCore::BitmapImage::getTIFFRepresentation):
(WebCore::BitmapImage::getNSImage):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieView):
(WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::setPreservesPitch):
(WebCore::addFileTypesToCache):

  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::SimpleFontData::getCFStringAttributes):

  • platform/graphics/mac/SimpleFontDataMac.mm:

(WebCore::fontHasVerticalGlyphs):
(WebCore::SimpleFontData::getCompositeFontReferenceFontData):
(WebCore::SimpleFontData::platformCharWidthInit):
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence):

  • platform/graphics/mac/WebGLLayer.mm:

(-[WebGLLayer copyImageSnapshotWithColorSpace:]):

  • platform/mac/ContentFilterMac.mm:

(WebCore::ContentFilter::ContentFilter):

  • platform/mac/ContextMenuItemMac.mm:

(WebCore::ContextMenuItem::ContextMenuItem):

  • platform/mac/CursorMac.mm:

(WebCore::createCustomCursor):
(WebCore::createNamedCursor):

  • platform/mac/DisplaySleepDisabler.cpp:

(WebCore::DisplaySleepDisabler::DisplaySleepDisabler):

  • platform/mac/DragImageMac.mm:

(WebCore::dissolveDragImageToFraction):
(WebCore::createDragImageFromImage):

  • platform/mac/HTMLConverter.mm:

(+[WebHTMLConverter editingAttributedStringFromRange:]):

  • platform/mac/Language.mm:

(WebCore::httpStyleLanguageCode):
(WebCore::platformUserPreferredLanguages):

  • platform/mac/LocalizedStringsMac.cpp:

(WebCore::localizedString):

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::getDataSelection):
(WebCore::Pasteboard::writeSelectionForTypes):
(WebCore::fragmentFromWebArchive):

  • platform/mac/PlatformClockCM.mm:

(PlatformClockCM::PlatformClockCM):
(PlatformClockCM::initializeWithTimingSource):

  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::PlatformPasteboard::addTypes):
(WebCore::PlatformPasteboard::setTypes):
(WebCore::PlatformPasteboard::setPathnamesForType):

  • platform/mac/PlatformSpeechSynthesizerMac.mm:

(WebCore::PlatformSpeechSynthesizer::speak):

  • platform/mac/PopupMenuMac.mm:

(WebCore::PopupMenuMac::populate):
(WebCore::PopupMenuMac::show):

  • platform/mac/ScrollAnimatorMac.mm:

(-[WebScrollbarPainterDelegate setUpAlphaAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateUIStateTransitionWithDuration:]):
(-[WebScrollbarPainterDelegate scrollerImp:animateExpansionTransitionWithDuration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):

  • platform/mac/SharedBufferMac.mm:

(WebCore::SharedBuffer::createCFData):

  • platform/mac/WebCoreNSStringExtras.mm:

(stringEncodingForResource):

  • platform/network/ProtectionSpace.cpp:

(WebCore::ProtectionSpace::receivesCredentialSecurely):

  • platform/network/SynchronousLoaderClient.cpp:

(WebCore::SynchronousLoaderClient::platformBadResponseError):

  • platform/network/cf/CredentialStorageCFNet.cpp:

(WebCore::CredentialStorage::getFromPersistentStorage):

  • platform/network/cf/DNSCFNet.cpp:

(WebCore::DNSResolveQueue::platformProxyIsEnabledInSystemPreferences):

  • platform/network/cf/FormDataStreamCFNet.cpp:

(WebCore::advanceCurrentStream):

  • platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::overrideCookieStorage):

  • platform/network/cf/ProxyServerCFNet.cpp:

(WebCore::proxyAutoConfigurationResultCallback):
(WebCore::processProxyServers):
(WebCore::addProxyServersForURL):

  • platform/network/cf/ResourceErrorCF.cpp:

(WebCore::ResourceError::platformLazyInit):
(WebCore::ResourceError::cfError):

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::willSendRequest):
(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
(WebCore::ResourceHandle::handleDataArray):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::setHeaderFields):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::setStorageSession):

  • platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::ResourceResponse::cfURLResponse):
(WebCore::ResourceResponse::platformLazyInit):

  • platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::executePACFileURL):
(WebCore::SocketStreamHandle::chooseProxy):
(WebCore::SocketStreamHandle::createStreams):
(WebCore::SocketStreamHandle::addCONNECTCredentials):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
(WebCore::SocketStreamHandle::reportErrorToClient):

  • platform/network/mac/AuthenticationMac.mm:

(WebCore::mac):
(WebCore::AuthenticationChallenge::setAuthenticationClient):

  • platform/network/mac/CookieJarMac.mm:

(WebCore::filterCookies):

  • platform/network/mac/NetworkStateNotifierMac.cpp:

(WebCore::NetworkStateNotifier::updateState):
(WebCore::NetworkStateNotifier::NetworkStateNotifier):

  • platform/network/mac/ResourceErrorMac.mm:

(WebCore::createNSErrorFromResourceErrorBase):
(WebCore::ResourceError::nsError):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::updateNSURLRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdatePlatformHTTPBody):
(WebCore::ResourceRequest::setStorageSession):

  • platform/network/mac/ResourceResponseMac.mm:

(WebCore::ResourceResponse::initNSURLResponse):
(WebCore::ResourceResponse::nsURLResponse):
(WebCore::ResourceResponse::platformLazyInit):

  • platform/network/mac/UTIUtilities.mm:

(WebCore::mimeTypeFromUTITree):

  • platform/network/mac/WebCoreURLResponse.mm:

(WebCore::adjustMIMETypeIfNecessary):

  • platform/text/cf/HyphenationCF.cpp:

(WebCore::::createValueForNullKey):
(WebCore::lastHyphenLocation):

  • platform/text/mac/HyphenationMac.mm:

(WebCore::::createValueForKey):
(WebCore::lastHyphenLocation):

  • platform/text/mac/LocaleMac.mm:

(WebCore::determineLocale):
(WebCore::LocaleMac::LocaleMac):
(WebCore::LocaleMac::initializeLocaleData):

  • platform/text/mac/TextBreakIteratorInternalICUMac.mm:

(WebCore::textBreakLocalePreference):
(WebCore::canonicalLanguageIdentifier):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::RenderThemeMac):
(WebCore::RenderThemeMac::levelIndicatorFor):
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintSliderTrack):
(WebCore::RenderThemeMac::popupButton):
(WebCore::RenderThemeMac::search):
(WebCore::RenderThemeMac::searchMenuTemplate):
(WebCore::RenderThemeMac::sliderThumbHorizontal):
(WebCore::RenderThemeMac::sliderThumbVertical):
(WebCore::RenderThemeMac::textField):
Use adoptNS and adoptCF free functions.

Source/WebKit/cf:

  • WebCoreSupport/WebInspectorClientCF.cpp:

(populateSetting): Use adoptCF.

Source/WebKit/mac:

This change was done by a global replace followed by compiling and inspecting for
cases that needed to be tweaked by hand.

  • DefaultDelegates/WebDefaultContextMenuDelegate.mm:

(-[WebDefaultUIDelegate menuItemWithTag:target:representedObject:]):

  • Misc/WebNSFileManagerExtras.mm:

(-[NSFileManager _webkit_startupVolumeName]):

  • Plugins/Hosted/HostedNetscapePluginStream.mm:

(WebKit::HostedNetscapePluginStream::HostedNetscapePluginStream):

  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::spawnPluginHost):
(WebKit::NetscapePluginHostManager::instantiatePlugin):

  • Plugins/Hosted/NetscapePluginHostProxy.mm:

(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
(WebKit::NetscapePluginHostProxy::beginModal):
(WKPCBooleanAndDataReply):

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::print):
(WebKit::NetscapePluginInstanceProxy::snapshot):
(WebKit::NetscapePluginInstanceProxy::status):
(WebKit::NetscapePluginInstanceProxy::loadURL):
(WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
(WebKit::NetscapePluginInstanceProxy::enumerate):
(WebKit::NetscapePluginInstanceProxy::marshalValue):
(WebKit::NetscapePluginInstanceProxy::marshalValues):
(WebKit::NetscapePluginInstanceProxy::demarshalValue):
(WebKit::NetscapePluginInstanceProxy::demarshalValues):

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(-[WebHostedNetscapePluginView setAttributeKeys:andValues:]):
(-[WebHostedNetscapePluginView createPlugin]):

  • Plugins/WebBaseNetscapePluginView.mm:

(-[WebBaseNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
(-[WebBaseNetscapePluginView cacheSnapshot]):
(WebKit::getAuthenticationInfo):

  • Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage initWithPath:]):

  • Plugins/WebNetscapePluginEventHandlerCarbon.mm:

(WebNetscapePluginEventHandlerCarbon::startTimers):

  • Plugins/WebNetscapePluginEventHandlerCocoa.mm:

(WebNetscapePluginEventHandlerCocoa::syntheticKeyDownWithCommandModifier):
(WebNetscapePluginEventHandlerCocoa::handleTSMEvent):

  • Plugins/WebNetscapePluginPackage.mm:

(-[WebNetscapePluginPackage _initWithPath:]):

  • Plugins/WebNetscapePluginStream.mm:

(WebNetscapePluginStream::WebNetscapePluginStream):
(WebNetscapePluginStream::deliverData):
(WebNetscapePluginStream::deliverDataToFile):
(WebNetscapePluginStream::didReceiveData):

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView createPlugin]):
(-[WebNetscapePluginView initWithFrame:pluginPackage:URL:baseURL:MIMEType:attributeKeys:attributeValues:loadManually:element:WebCore::]):
(-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):

  • Storage/WebDatabaseManagerClient.mm:

(WebDatabaseManagerClient::dispatchDidModifyOrigin):
(WebDatabaseManagerClient::dispatchDidModifyDatabase):

  • Storage/WebStorageTrackerClient.mm:

(WebStorageTrackerClient::dispatchDidModifyOrigin):

  • WebCoreSupport/CorrectionPanel.mm:

(CorrectionPanel::handleAcceptedReplacement):

  • WebCoreSupport/WebApplicationCache.mm:

(+[WebApplicationCache originsWithCache]):

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::didRunInsecureContent):

  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::openInspectorFrontend):

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController enterFullScreen:]):

  • WebView/WebPDFDocumentExtras.mm:

(allScriptsInPDFDocument):

  • WebView/WebPreferences.mm:

(-[WebPreferences initWithIdentifier:]):
(-[WebPreferences initWithCoder:]):

  • WebView/WebScriptDebugger.mm:

(WebScriptDebugger::initGlobalCallFrame):
(WebScriptDebugger::callEvent):

  • WebView/WebView.mm:

(-[WebView previousValidKeyView]):
Use adoptNS and adoptCF free functions.

Source/WebKit2:

This change was done by a global replace followed by compiling and inspecting for
cases that needed to be tweaked by hand.

  • Platform/cg/CGUtilities.cpp:

(WebKit::paintBitmapContext):

  • Platform/mac/ModuleMac.mm:

(WebKit::Module::load):
(WebKit::Module::platformFunctionPointer):

  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::initializeSandbox):

  • Shared/API/c/mac/WKURLRequestNS.mm:

(WKURLRequestCreateWithNSURLRequest):

  • Shared/API/c/mac/WKURLResponseNS.mm:

(WKURLResponseCreateWithNSURLResponse):

  • Shared/Downloads/mac/DownloadMac.mm:

(WebKit::Download::start):
(WebKit::Download::startWithHandle):

  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h:

(WebKit::ChildProcessMain):

  • Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:

(WebKit::getPluginArchitecture):
(WebKit::contentsOfPropertyListAtURL):
(WebKit::getMIMETypesFromPluginBundle):
(WebKit::getStringListResource):
(WebKit::NetscapePluginModule::getPluginInfo):

  • Shared/ShareableResource.cpp:

(WebKit::ShareableResource::Handle::tryWrapInSharedBuffer):

  • Shared/cf/ArgumentCodersCF.cpp:

(CoreIPC::decode):
(CoreIPC::encode):

  • Shared/cg/ShareableBitmapCG.cpp:

(WebKit::ShareableBitmap::createGraphicsContext):
(WebKit::ShareableBitmap::makeCGImageCopy):
(WebKit::ShareableBitmap::makeCGImage):
(WebKit::ShareableBitmap::createCGImage):

  • Shared/mac/ArgumentCodersMac.mm:

(CoreIPC::decode):

  • Shared/mac/PlatformCertificateInfo.mm:

(WebKit::PlatformCertificateInfo::dump):

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

  • UIProcess/API/mac/FindIndicatorWindow.mm:

(WebKit::FindIndicatorWindow::setFindIndicator):
(WebKit::FindIndicatorWindow::startFadeOutTimerFired):

  • UIProcess/API/mac/PDFViewController.mm:

(-[WKPDFView initWithFrame:PDFViewController:]):
(WebKit::PDFViewController::PDFViewController):
(WebKit::convertPostScriptDataSourceToPDF):
(WebKit::PDFViewController::setPDFDocumentData):

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::PageClientImpl):
(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::setDragImage):

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(didFailProvisionalLoadWithErrorForFrame):
(didFailLoadWithErrorForFrame):

  • UIProcess/API/mac/WKConnection.mm:

(didReceiveMessage):

  • UIProcess/API/mac/WKPrintingView.mm:

(-[WKPrintingView drawRect:]):

  • UIProcess/API/mac/WKView.mm:

(-[WKView browsingContextController]):
(-[WKView _setAcceleratedCompositingModeRootLayer:]):
(-[WKView _setPromisedData:WebCore::withFileName:withExtension:withTitle:withURL:withVisibleURL:withArchive:WebCore::forPasteboard:]):
(-[WKView namesOfPromisedFilesDroppedAtDestination:]):
(-[WKView fullScreenWindowController]):
(-[WKView _executeSavedCommandBySelector:]):
(-[WKView printOperationWithPrintInfo:forFrame:]):

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::createProcess):

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::pluginPathsInDirectory):
(WebKit::PluginInfoStore::getMIMETypeForExtension):

  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:

(WebKit::PluginProcessProxy::beginModal):

  • UIProcess/cf/WebBackForwardListCF.cpp:

(WebKit::WebBackForwardList::createCFDictionaryRepresentation):

  • UIProcess/cf/WebPageProxyCF.cpp:

(WebKit::WebPageProxy::sessionStateData):
(WebKit::WebPageProxy::restoreFromSessionStateData):
(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):

  • UIProcess/cf/WebPreferencesCF.cpp:

(WebKit::cfStringFromWebCoreString):
(WebKit::setStringValueIfInUserDefaults):
(WebKit::setBoolValueIfInUserDefaults):
(WebKit::setUInt32ValueIfInUserDefaults):
(WebKit::setDoubleValueIfInUserDefaults):
(WebKit::WebPreferences::platformUpdateUInt32ValueForKey):
(WebKit::WebPreferences::platformUpdateDoubleValueForKey):
(WebKit::WebPreferences::platformUpdateFloatValueForKey):

  • UIProcess/mac/BackingStoreMac.mm:

(WebKit::BackingStore::resetScrolledRect):
(WebKit::BackingStore::backingStoreContext):

  • UIProcess/mac/CorrectionPanel.mm:

(WebKit::CorrectionPanel::handleAcceptedReplacement):

  • UIProcess/mac/TextCheckerMac.mm:

(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::updateSpellingUIWithGrammarString):

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController _startEnterFullScreenAnimationWithDuration:]):
(-[WKFullScreenWindowController _startExitFullScreenAnimationWithDuration:]):

  • UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformDefaultDiskCacheDirectory):

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::nsMenuItemVector):
(WebKit::WebContextMenuProxyMac::populate):

  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::populate):
(WebKit::WebPopupMenuProxyMac::showPopupMenu):

  • WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::load):

  • WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:

(WebKit::NetscapePlugin::updatePluginLayer):

  • WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:

(WebKit::PluginProxy::pluginLayer):

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::PDFPlugin):
(WebKit::PDFPlugin::createScrollbar):
(WebKit::PDFPlugin::pdfDocumentDidLoad):
(WebKit::PDFPlugin::writeItemsToPasteboard):

  • WebProcess/Plugins/PDF/SimplePDFPlugin.mm:

(getAllScriptsInPDFDocument):
(WebKit::SimplePDFPlugin::pdfDocumentDidLoad):
(WebKit::SimplePDFPlugin::streamDidReceiveData):
(WebKit::SimplePDFPlugin::manualStreamDidReceiveData):

  • WebProcess/ResourceCache/WebResourceCacheManager.cpp:

(WebKit::WebResourceCacheManager::clearCacheForOrigin):

  • WebProcess/ResourceCache/cf/WebResourceCacheManagerCFNet.cpp:

(WebKit::WebResourceCacheManager::cfURLCacheHostNames):
(WebKit::WebResourceCacheManager::clearCFURLCacheForHostNames):

  • WebProcess/WebCoreSupport/mac/WebErrorsMac.mm:

(WebKit::createNSError):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::drawPagesToPDF):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::performDictionaryLookupForRange):
(WebKit::cachedResponseForURL):
(WebKit::WebPage::drawPagesToPDFFromPDFDocument):

  • WebProcess/mac/WebProcessMac.mm:

(WebKit::WebProcess::platformSetCacheModel):
Use adoptCF and adoptNS free functions.

Source/WTF:

  • wtf/RunLoopTimerCF.cpp:

(WTF::RunLoopTimerBase::start):

  • wtf/SchedulePair.h:

(WTF::SchedulePair::SchedulePair):

  • wtf/SchedulePairMac.mm:

(WTF::SchedulePair::SchedulePair):

  • wtf/unicode/icu/CollatorICU.cpp:

(WTF::Collator::userDefault):
Use adoptCF free function.

8:43 PM Changeset in webkit [149254] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Pressing mouse button inside a dragstart event causes a crash
https://bugs.webkit.org/show_bug.cgi?id=115296

Reviewed by Darin Adler.

Source/WebCore:

Add a missing null pointer check. We should better encapsulate the states in DragState in the long term
but this is good enough for now.

Test: fast/events/mousedown-inside-dragstart-should-not-cause-crash.html

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleDrag):

LayoutTests:

Added a regression test. While the bug report involves opening inspector and setting a breakpoint,
a simpler reduction that uses eventSender significantly reduces the complexity.

  • fast/events/mousedown-inside-dragstart-should-not-cause-crash-expected.txt: Added.
  • fast/events/mousedown-inside-dragstart-should-not-cause-crash.html: Added.
8:38 PM Changeset in webkit [149253] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/13757007> Crashes in NetworkResourceLoader::didReceiveResponseAsync
https://bugs.webkit.org/show_bug.cgi?id=115318

Reviewed by Darin Adler.

sendAbortingOnFailure may actually fail, and abort the request, making m_handle null.

  • NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::didReceiveResponseAsync): Null check m_handle after sending a message, because the request will cancelled when connection is invalid. (WebKit::NetworkResourceLoader::didReceiveBuffer): Assert that m_handle matches the handle that we are called with. (WebKit::NetworkResourceLoader::didFinishLoading): Ditto. (WebKit::NetworkResourceLoader::didFail): Ditto. (WebKit::NetworkResourceLoader::willSendRequestAsync): Ditto. (WebKit::NetworkResourceLoader::didSendData): Ditto. (WebKit::NetworkResourceLoader::shouldUseCredentialStorage): Ditto. (WebKit::NetworkResourceLoader::shouldUseCredentialStorageAsync): Ditto. (WebKit::NetworkResourceLoader::didReceiveAuthenticationChallenge): Ditto. (WebKit::NetworkResourceLoader::didCancelAuthenticationChallenge): Ditto. (WebKit::NetworkResourceLoader::canAuthenticateAgainstProtectionSpaceAsync): Ditto.
8:37 PM Changeset in webkit [149252] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Try to fix the Windows build.

8:22 PM Changeset in webkit [149251] by ap@apple.com
  • 5 edits in trunk/Source/WebKit2

<rdar://problem/13757687> Threads get stuck in NetworkProcess when canceling loads
https://bugs.webkit.org/show_bug.cgi?id=115319

Reviewed by Darin Adler.

WebResourceLoader was second-guessing NetworkProcess as to whether it needs a response
to DidReceiveResponseWithCertificateInfo, and it was guessing wrong if the load was
alrady canceled on WebProcess side.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponseAsync):

  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::didReceiveResponseWithCertificateInfo):

  • WebProcess/Network/WebResourceLoader.h:
  • WebProcess/Network/WebResourceLoader.messages.in:
6:17 PM Changeset in webkit [149250] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix when disabling video and video-track.

  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
5:09 PM Changeset in webkit [149249] by ggaren@apple.com
  • 3 edits in trunk/Source/WebCore

WebGL shouldn't allocate a "length" Identifier just to move some numbers around
https://bugs.webkit.org/show_bug.cgi?id=115317

Reviewed by Dean Jackson.

Saw this while debugging an ammo.js bug.

  • bindings/js/JSArrayBufferViewHelper.h:

(WebCore::setWebGLArrayWithTypedArrayArgument):
(WebCore::setWebGLArrayHelper):
(WebCore::constructArrayBufferViewWithTypedArrayArgument):
(WebCore::constructArrayBufferView):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toVector): Use the pre-computed "length" identifier instead of
allocating a new one for each vector operation. There are lots more
optimizations we could do here. This is a start.

4:14 PM Changeset in webkit [149248] by fpizlo@apple.com
  • 9 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: SymbolTable should be thread-safe
https://bugs.webkit.org/show_bug.cgi?id=115301

Reviewed by Geoffrey Garen.

Makes SymbolTable thread-safe. Relies on SymbolTableEntry already being immutable,
other than the WatchpointSet; but the WatchpointSet already has a righteous
concurrency protocol. So, this patch just protects the SymbolTable's HashMap.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::nameForRegister):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::addVar):

  • runtime/Executable.cpp:

(JSC::ProgramExecutable::addGlobalVar):

  • runtime/JSActivation.cpp:

(JSC::JSActivation::getOwnNonIndexPropertyNames):
(JSC::JSActivation::symbolTablePutWithAttributes):

  • runtime/JSSymbolTableObject.cpp:

(JSC::JSSymbolTableObject::getOwnNonIndexPropertyNames):

  • runtime/JSSymbolTableObject.h:

(JSC::symbolTableGet):
(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):

  • runtime/SymbolTable.cpp:

(JSC::SymbolTable::SymbolTable):
(JSC::SymbolTable::~SymbolTable):

  • runtime/SymbolTable.h:

(JSC::SymbolTable::find):
(JSC::SymbolTable::get):
(JSC::SymbolTable::inlineGet):
(JSC::SymbolTable::begin):
(JSC::SymbolTable::end):
(JSC::SymbolTable::size):
(JSC::SymbolTable::add):
(JSC::SymbolTable::set):
(JSC::SymbolTable::contains):

4:14 PM Changeset in webkit [149247] by ggaren@apple.com
  • 26 edits in trunk

Cleaned up pre/post inc/dec in bytecode
https://bugs.webkit.org/show_bug.cgi?id=115222

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

A few related changes here:

(*) Removed post_inc and post_dec. The two-result form was awkward to
reason about. Being explicit about the intermediate mov and to_number
reduces DFG overhead, removes some fragile ASSERTs from the DFG, and
fixes a const bug. Plus, we get to blow away 262 lines of code.

(*) Renamed pre_inc and pre_dec to inc and dec, since there's only one
version now.

(*) Renamed to_jsnumber to to_number, to match the ECMA name.

(*) Tightened up the codegen and runtime support for to_number.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

  • bytecode/Opcode.h:

(JSC::padOpcodeName):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitInc):
(JSC::BytecodeGenerator::emitDec):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::emitToNumber):
(BytecodeGenerator): Removed post_inc and post_dec.

  • bytecompiler/NodesCodegen.cpp:

(JSC::emitPreIncOrDec): Updated for rename.

(JSC::emitPostIncOrDec): Issue an explicit mov and to_number when needed.
These are rare, and they boil away in the DFG.

(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve): For const, use an explicit mov instead
of any special forms. This fixes a bug where we would do string
add/subtract instead of number.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:
  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_inc):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emit_op_dec):
(JSC::JIT::emitSlow_op_dec):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_inc):
(JSC::JIT::emitSlow_op_inc):
(JSC::JIT::emit_op_dec):
(JSC::JIT::emitSlow_op_dec): Removed post_inc/dec, and updated for renames.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_to_number):
(JSC::JIT::emitSlow_op_to_number): Removed a test for number cells. There's
no such thing!

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_to_number): Use LowestTag to avoid making assumptions
about the lowest valued tag.

(JSC::JIT::emitSlow_op_to_number): Updated for renames.

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • jit/JITStubs.h:
  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LLIntSlowPaths.h:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • parser/NodeConstructors.h:

(JSC::UnaryPlusNode::UnaryPlusNode): Removed post_inc/dec, and updated for renames.

  • runtime/Operations.cpp:

(JSC::jsIsObjectType): Removed a test for number cells. There's
no such thing!

LayoutTests:

  • fast/js/const-expected.txt:
  • fast/js/resources/const.js: Added tests for some const cases we used

to get wrong.

4:02 PM Changeset in webkit [149246] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Regression tests that reference a non-local resource crash with NetworkProcess enabled
https://bugs.webkit.org/show_bug.cgi?id=115290

Reviewed by Sam Weinig.

Covered by fast/dom/icon-url-change.html and many other existing tests.

  • WebProcess/Network/WebResourceLoadScheduler.cpp:

(WebKit::WebResourceLoadScheduler::remove): Handle this case. Architecturally, it
would be better if SubresourceLoad::create just created an object an didn't do
further checks before returning a pointer, but changing that is beyond the scope
of the fix.

1:55 PM Changeset in webkit [149245] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Remove two more StorageTask types
https://bugs.webkit.org/show_bug.cgi?id=115312

Reviewed by Dean Jackson.

  • storage/StorageTask.cpp:

(WebCore::StorageTask::performTask):

  • storage/StorageTask.h:
  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::setOriginDetails):
(WebCore::StorageTracker::deleteOrigin):

  • storage/StorageTracker.h:
1:44 PM Changeset in webkit [149244] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Get rid of more uses of StorageTask
https://bugs.webkit.org/show_bug.cgi?id=115311

Reviewed by Dean Jackson.

Make StorageAreaSync derive from ThreadSafeRefCounted as well, since it's passed between threads.

  • storage/StorageAreaSync.h:
  • storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::scheduleImport):
(WebCore::StorageSyncManager::scheduleSync):
(WebCore::StorageSyncManager::scheduleDeleteEmptyDatabase):

  • storage/StorageTask.cpp:

(WebCore::StorageTask::StorageTask):
(WebCore::StorageTask::performTask):

  • storage/StorageTask.h:

(StorageTask):

1:32 PM Changeset in webkit [149243] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Indent StorageAreaSync to match the style guidelines.

Rubber-stamped by Andreas Kling.

  • storage/StorageAreaSync.h:
1:28 PM Changeset in webkit [149242] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

Replace uses of StorageTask with StorageThread::dispatch and WTF::bind
https://bugs.webkit.org/show_bug.cgi?id=115309

Reviewed by Andreas Kling.

  • storage/StorageTask.cpp:

(WebCore::StorageTask::StorageTask):
(WebCore::StorageTask::performTask):

  • storage/StorageTask.h:
  • storage/StorageThread.cpp:

(WebCore::StorageThread::terminate):
(WebCore::StorageThread::releaseFastMallocFreeMemoryInAllThreads):

  • storage/StorageThread.h:
  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::importOriginIdentifiers):
(WebCore::StorageTracker::deleteAllOrigins):

12:59 PM Changeset in webkit [149241] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Add StorageThread::dispatch
https://bugs.webkit.org/show_bug.cgi?id=115308

Reviewed by Andreas Kling.

StorageThread::dispatch takes a Function<void ()> and runs it on the storage thread. This will be used to eventually get rid of StorageTask.

  • storage/StorageTask.cpp:

(WebCore::StorageTask::StorageTask):
(WebCore::StorageTask::performTask):

  • storage/StorageTask.h:

(WebCore::StorageTask::createDispatch):

  • storage/StorageThread.cpp:

(WebCore::StorageThread::dispatch):

  • storage/StorageThread.h:

(StorageThread):

11:25 AM Changeset in webkit [149240] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r149114): cache flush for SH4 arch may flush an extra page.
https://bugs.webkit.org/show_bug.cgi?id=115305

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-04-27
Reviewed by Andreas Kling.

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::cacheFlush):

11:23 AM Changeset in webkit [149239] by fpizlo@apple.com
  • 5 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: WatchpointSet should make racy uses easier to reason about
https://bugs.webkit.org/show_bug.cgi?id=115299

Reviewed by Anders Carlsson.

The compiler often does things like:

1c) Observe something that would imply that a WatchpointSet ought to be invalid

2c) Check that it is invalid

The main thread often does things like:

1m) Fire the watchpoint set

2m) Do some other thing that would cause the compiler to assume that the WatchpointSet
ought to be invalid

An example is structure transitions, where (1c) is the compiler noticing that a
put_by_id inline cache is in a transition state, with the source structure being S;
(2c) is the compiler asserting that S's watchpoint set is invalid; (1m) is the main
thread firing S's watchpoint set before it does the first transition away from S; and
(2m) is the main thread caching the put_by_id transition away from S.

This is totally fine, except that (1c) and (2c), and (1m) and (2m) could be reordered.
Probably, in most cases, this ought to do enough things that the main thread probably
already has some fencing. But the compiler thread definitely doesn't have fencing. In
any case, we should play it safe and just have additional fencing in all of the
relevant places.

We already have some idioms to put load-load and store-store fences in the right
places. But this change just makes WatchpointSet take care of this for us, thus
reducing the chances of us getting this wrong.

  • bytecode/Watchpoint.cpp:

(JSC::WatchpointSet::notifyWriteSlow):

  • bytecode/Watchpoint.h:

(WatchpointSet):
(JSC::WatchpointSet::isStillValid):
(JSC::WatchpointSet::hasBeenInvalidated):
(JSC::InlineWatchpointSet::hasBeenInvalidated):
(JSC::InlineWatchpointSet::notifyWrite):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGDesiredWatchpoints.h:

(JSC::DFG::GenericDesiredWatchpoints::shouldAssumeMixedState):

11:18 AM Changeset in webkit [149238] by rakuco@webkit.org
  • 2 edits in trunk/Tools

[EFL] Unreviewed Intel bots fix after r149231.

  • efl/jhbuild.modules: Disable the libxml Python bindings since the

bots don't have Python's development files installed. libxml should
detect this kind of thing better.

10:08 AM Changeset in webkit [149237] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r147261): Audio controls background not displayed after loading audio file
https://bugs.webkit.org/show_bug.cgi?id=115221

Reviewed by Darin Adler.

As in r147261, set a flex-shrink: 0 to avoid shrinking the media controls panel
below the specified height.

No new tests; fixes the media/media-document-audio-repaint.html test.

  • css/mediaControlsQuickTime.css:

(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):

9:51 AM WebKitGTK/2.0.x edited by zandobersek@gmail.com
Adding a merge proposal for 2.0.2. (diff)

Apr 26, 2013:

11:43 PM Changeset in webkit [149236] by ggaren@apple.com
  • 16 edits
    2 adds in trunk

Source/JavaScriptCore: Re-landing <http://trac.webkit.org/changeset/148999>

Filled out more cases of branch folding in bytecode when emitting
expressions into a branching context
https://bugs.webkit.org/show_bug.cgi?id=115057

Reviewed by Phil Pizlo.

We can't fold the number == 1 case to boolean because all non-zero numbers
down-cast to true, but only 1 is == to true.

Source/WTF: Filled out more cases of branch folding in bytecode when emitting expressions into a branching context
https://bugs.webkit.org/show_bug.cgi?id=115057

Reviewed by Filip Pizlo.

Added a helper constructor for TriState so clients can make one without
branching or making assumptions about the integer values of TriStates.

  • wtf/TriState.h:

(WTF::triState):
(WTF):

LayoutTests: Re-landing <http://trac.webkit.org/changeset/148999>

Filled out more cases of branch folding in bytecode when emitting
expressions into a branching context
https://bugs.webkit.org/show_bug.cgi?id=115057

Reviewed by Phil Pizlo.

Added a more exhaustive correctness test.

  • fast/js/branch-fold-correctness-expected.txt: Added.
  • fast/js/branch-fold-correctness.html: Added.
11:33 PM Changeset in webkit [149235] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

Fix indentation of SymbolTable.h

Rubber stamped by Mark Hahnenberg.

  • runtime/SymbolTable.h:
11:28 PM Changeset in webkit [149234] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Correct indentation of SymbolTable.h

Rubber stamped by Mark Hahnenberg.

  • runtime/SymbolTable.h:
10:44 PM Changeset in webkit [149233] by fpizlo@apple.com
  • 16 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: CFA should defend against results seeming inconsistent due to a watchpoint firing during compilation
https://bugs.webkit.org/show_bug.cgi?id=115083

Reviewed by Geoffrey Garen.

This ruggedizes our racyness with respect to watchpoints. We want to be able to assert,
in some places, that a watchpoint-based optimization has only occurred if the
watchpoint set was still valid. But currently we *can* soundly do watchpoint-based
optimizations even for invalid watchpoints, so long as we recorded in the IR that we
had done so; this will then lead to the code being insta-jettisoned after compilation
completes. Obviously, we don't want this to happen often - but we do want to allow it
precisely in the case of watchpoint races.

This adds the ability to assert that we hadn't over-watchpointed ourselves, with and
exemption for races.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

  • dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::setFuturePossibleStructure):
(JSC::DFG::AbstractValue::filterFuturePossibleStructure):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::addStructureTransitionCheck):
(JSC::DFG::ByteCodeParser::parseResolveOperations):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):

  • dfg/DFGDesiredWatchpoints.h:

(GenericDesiredWatchpoints):
(JSC::DFG::GenericDesiredWatchpoints::isStillValid):
(JSC::DFG::GenericDesiredWatchpoints::shouldAssumeMixedState):
(JSC::DFG::GenericDesiredWatchpoints::isValidOrMixed):
(JSC::DFG::DesiredWatchpoints::isStillValid):
(JSC::DFG::DesiredWatchpoints::shouldAssumeMixedState):
(JSC::DFG::DesiredWatchpoints::isValidOrMixed):
(DesiredWatchpoints):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::canOptimizeStringObjectAccess):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::masqueradesAsUndefinedWatchpointIsStillValid):
(Graph):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • dfg/DFGJITCompiler.h:

(JSC::DFG::JITCompiler::addLazily):
(JITCompiler):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::masqueradesAsUndefinedWatchpointIsStillValid):
(JSC::DFG::SpeculativeJIT::speculationWatchpointForMasqueradesAsUndefined):
(JSC::DFG::SpeculativeJIT::speculateStringObjectForStructure):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::compileObjectEquality):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

  • ftl/FTLState.h:

(State):

10:30 PM Changeset in webkit [149232] by jer.noble@apple.com
  • 5 edits
    3 adds in trunk

Video playback has corruption on the edges of the video
https://bugs.webkit.org/show_bug.cgi?id=115216

Reviewed by Simon Fraser.

Source/WebCore:

Test: media/video-poster-background.html

RenderImage correctly answers foregroundIsKnownToBeOpaqueInRect() method
when a poster image is displayed, but once the video begins playing and
the poster image is no longer displayed, RenderImage will continue to
answer 'true' even when the video does not occupy the entire render box.
Override foregroundIsKnownToBeOpaqueInRect() in order to more correctly
answer the question for the video layer.

  • rendering/RenderImage.h: Make foregroundIsKnownToBeOpaqueInRect() protected

(vs. private).

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::foregroundIsKnownToBeOpaqueInRect): Added. Return

true if the rect parameter is entirely contained by the video box.

  • rendering/RenderVideo.h:

LayoutTests:

  • media/content/test.jpg: Added.
  • media/video-poster-background-expected.html: Added.
  • media/video-poster-background.html: Added.
9:41 PM Changeset in webkit [149231] by ryuan.choi@samsung.com
  • 2 edits in trunk/Tools

[EFL] Build break using jhbuild on ubuntu 13.04
https://bugs.webkit.org/show_bug.cgi?id=115225

Reviewed by Gyuyoung Kim.

libxslt in Ubuntu 13.04 requires libxml 2.9.0 or higher and
libxml 2.9.0 has a bug to make regression which r138422 mentioned.
So this patch bumped libxml version to 2.9.1.

  • efl/jhbuild.modules:
6:31 PM Changeset in webkit [149230] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WK2][EFL] Build break after r149212
https://bugs.webkit.org/show_bug.cgi?id=115294

Patch by Yael Aharon <yael.aharon@intel.com> on 2013-04-26
Reviewed by Simon Fraser.
r144672 bumped up the revision of WKContextClient API, and introduced a version array
APIClientTraits<WKContextClient>::interfaceSizesByVersion .
In r149212, the version was bumped back down and the version array was emptied but not removed.
This causes a warning "array subscript is below array bounds", and in EFL the warning is
treated as error.

  • Shared/APIClientTraits.cpp:

(WebKit):

  • Shared/APIClientTraits.h:
5:51 PM Changeset in webkit [149229] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skipping some more tests that still need rebaselining after disabling subpixel layout on mac.
http://bugs.webkit.org/show_bug.cgi?id=115292

5:51 PM Changeset in webkit [149228] by jpfau@apple.com
  • 2 edits in trunk/Tools

delete-stale-build-files does not clear .d files
http://bugs.webkit.org/show_bug.cgi?id=115293

Reviewed by Ryosuke Niwa.

  • BuildSlaveSupport/delete-stale-build-files:

(main): Add .d to the file type list

5:38 PM Changeset in webkit [149227] by roger_fong@apple.com
  • 2 edits in trunk/WebKitLibraries

Disable sub-pixel-layout on Apple Windows port, VS2005 edition.

  • win/tools/vsprops/FeatureDefines.vsprops:
5:35 PM Changeset in webkit [149226] by hmuller@adobe.com
  • 12 edits in trunk/Source/WebCore

[CSS Exclusions] ExclusionShape bounding box methods should return LayoutRects
https://bugs.webkit.org/show_bug.cgi?id=115117

Reviewed by Dirk Schulze.

Redefined the ExclusionShape API in terms of LayoutUnits, instead of floats: all of the
ExclusionShape methods now have LayoutUnit parameters and return LayoutUnit values.
This is more natural, since the callers work exclusively in LayoutUnits.

This is strictly a refactoring, no new tests were needed.

  • rendering/ExclusionPolygon.cpp:

(WebCore::ExclusionPolygon::getExcludedIntervals):
(WebCore::ExclusionPolygon::getIncludedIntervals):
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop):

  • rendering/ExclusionPolygon.h:
  • rendering/ExclusionRectangle.cpp:

(WebCore::ExclusionRectangle::getExcludedIntervals):
(WebCore::ExclusionRectangle::getIncludedIntervals):
(WebCore::ExclusionRectangle::firstIncludedIntervalLogicalTop):

  • rendering/ExclusionRectangle.h:
  • rendering/ExclusionShape.cpp:

(WebCore::ExclusionShape::createExclusionShape):

  • rendering/ExclusionShape.h:

(LineSegment):
(ExclusionShape):

  • rendering/ExclusionShapeInfo.cpp:

(WebCore):
(WebCore::::computedShape):

  • rendering/ExclusionShapeInfo.h:

(WebCore):
(WebCore::ExclusionShapeInfo::shapeLogicalTop):
(WebCore::ExclusionShapeInfo::shapeLogicalBottom):
(ExclusionShapeInfo):

  • rendering/ExclusionShapeInsideInfo.cpp:

(WebCore::ExclusionShapeInsideInfo::adjustLogicalLineTop):

  • rendering/ExclusionShapeInsideInfo.h:
  • rendering/ExclusionShapeOutsideInfo.h:
5:17 PM Changeset in webkit [149225] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Nil-check the results of -[AVPlayerItemVideoOutput copyPixelBufferForItemTime:itemTimeForDisplay:].
https://bugs.webkit.org/show_bug.cgi?id=115265

Reviewed by Eric Carlson.

copyPixelBufferForItemTime:itemTimeForDisplay: can return nil, even
when hasNewPixelBufferForItemTime: returns YES. Check the results
before passing the buffer on to VTPixelTransferSessionTransferImage()
which does not NULL-check its parameters.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createPixelBuffer):

5:09 PM Changeset in webkit [149224] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skipping some tests that still need rebaselining after disabling subpixel layout on mac.
http://bugs.webkit.org/show_bug.cgi?id=115292

4:45 PM Changeset in webkit [149223] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Uninflate caret rect.
http://bugs.webkit.org/show_bug.cgi?id=114997.
<rdar://problem/12629007>.

Reviewed by Timothy Horton.

Inflation was causing painting errors with focus rings.
It is no longer needed after disabling subpixel layout.

  • editing/FrameSelection.cpp:

(WebCore::repaintCaretForLocalRect):

4:40 PM Changeset in webkit [149222] by roger_fong@apple.com
  • 3 edits
    66 adds in trunk/LayoutTests

Unreviewed. More rebaselines for mac after disabling sub-pixel layout.

4:40 PM Changeset in webkit [149221] by roger_fong@apple.com
  • 2 edits in trunk/WebKitLibraries

Disable sub-pixel-layout on Apple Windows port.

  • win/tools/vsprops/FeatureDefines.props:
4:17 PM Changeset in webkit [149220] by roger_fong@apple.com
  • 216 edits
    1 delete in trunk

Make Apple Windows VS2010 build results into and get dependencies from 32 suffixed folders.
Make the DebugSuffix configuration use _debug dependencies.

4:06 PM Changeset in webkit [149219] by Martin Robinson
  • 5 edits in trunk/Source/WebKit2

[GTK] Add methods to add a user style sheet to the WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=99081

Reviewed by Carlos Garcia Campos, Gustavo Noronha Silva, and Benjamin Poulain.

Add methods to WebKitWebViewGroup to add and remove user style sheets.
This allows clients to inject style sheets into pages with a set of
rules for when those style sheets apply.

  • UIProcess/API/gtk/WebKitWebViewGroup.cpp:

(toImmutableArray): Added this helper which converts the GList* parameters into
ImmutableArrays for use with the WebKit2 internal API.
(webkit_web_view_group_add_user_style_sheet): Added new API for adding a style sheet.
(webkit_web_view_group_remove_all_user_style_sheets): Add new API for clearing out all style sheets.

  • UIProcess/API/gtk/WebKitWebViewGroup.h: Added new method declarations.
  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Added new API to the documentation.
  • UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp: Added a test for the new API.

(isStyleSheetInjectedForURLAtPath): Function to check whether the style sheet has been injected for a given URL.
(fillURLListFromPaths): Helper which converts paths passed via varargs into a whitelist or blacklist.
(removeOldInjectedStyleSheetsAndResetLists): Function to start afresh.
(testWebViewGroupInjectedStyleSheet): The actual test.
(serverCallback): Server callback for use with the test. We cannot use loadHTML or
loadAlternateHTML, because that checks the whitelist and blacklist against about:blank.
(beforeAll): Initialize the server and new test.
(afterAll): Clean up the server.

3:29 PM Changeset in webkit [149218] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix.

  • platform/LayoutUnit.h:

(WebCore::LayoutUnit::LayoutUnit):

3:22 PM Changeset in webkit [149217] by ap@apple.com
  • 8 edits in trunk/Source/WebKit2

2013-04-26 Simon Cooper <scooper@apple.com>

Permit ~/Library or ~/Library/Preferences to be symlinks
https://bugs.webkit.org/show_bug.cgi?id=115142
<rdar://problem/12953603>

Reviewed by Alexey Proskuryakov.

Pass in two new parameters which are the resolved paths to ~/Library
and ~/Library/Preferences. Added new expansion functions and
substituted the new functions for home-regex, home-subpath and
home-literal for places referencing resources in "~/Library" or
"~/Library/Preferences".

  • Resources/PlugInSandboxProfiles/com.apple.QuickTime Plugin.plugin.sb:
  • Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
  • Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb:
  • Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:
  • Resources/PlugInSandboxProfiles/com.microsoft.SilverlightPlugin.sb:
  • Resources/PlugInSandboxProfiles/com.oracle.java.JavaAppletPlugin.sb:
  • Shared/mac/ChildProcessMac.mm: (WebKit::ChildProcess::initializeSandbox):
3:20 PM Changeset in webkit [149216] by msaboff@apple.com
  • 4 edits in trunk/Source/WebCore

WebCore ObjC bridge is missing support for bool type
https://bugs.webkit.org/show_bug.cgi?id=115276

Reviewed by Geoffrey Garen.

Added code to handle conversion between ObjC and JS booleans.

  • bridge/objc/objc_instance.mm:

(ObjcInstance::invokeObjcMethod):

  • bridge/objc/objc_utility.h:
  • bridge/objc/objc_utility.mm:

(JSC::Bindings::convertValueToObjcValue):
(JSC::Bindings::convertObjcValueToValue):
(JSC::Bindings::objcValueTypeForType):

3:15 PM Changeset in webkit [149215] by mrowe@apple.com
  • 1 edit in tags/Safari-537.39.1/Source/WebKit/mac/WebCoreSupport/WebEditorClient.mm

Build fix.

3:15 PM Changeset in webkit [149214] by mrowe@apple.com
  • 4 edits in tags/Safari-537.39.1/Source

Versioning.

3:09 PM Changeset in webkit [149213] by mrowe@apple.com
  • 1 copy in tags/Safari-537.39.1

New tag.

2:54 PM Changeset in webkit [149212] by ap@apple.com
  • 4 edits in trunk/Source/WebKit2

[WK2] WKContextClient doesn't need to be versioned yet
https://bugs.webkit.org/show_bug.cgi?id=115279

Reviewed by Anders Carlsson.

  • Shared/APIClientTraits.cpp:
  • Shared/APIClientTraits.h:
  • UIProcess/API/C/WKContext.h:
2:39 PM Changeset in webkit [149211] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

Downloads need to be converted from the NSURLConnection, not canceled and restarted, when using the NetworkProcess
https://bugs.webkit.org/show_bug.cgi?id=115277
<rdar://problem/12890184>

Reviewed by Sam Weinig.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):
Ask the download manager to convert the main resource load to a download.

  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:

Add new message.

  • NetworkProcess/NetworkResourceLoader.h:

(WebKit::NetworkResourceLoader::handle):
Add getter.

  • Shared/Downloads/mac/DownloadMac.mm:

(dispatchOnMainThread):
Helper function that ensures that a given block is called on the main thread.

(-[WKDownloadAsDelegate downloadDidBegin:]):
(-[WKDownloadAsDelegate download:didReceiveAuthenticationChallenge:]):
(-[WKDownloadAsDelegate download:didReceiveResponse:]):
(-[WKDownloadAsDelegate download:didReceiveDataOfLength:]):
(-[WKDownloadAsDelegate download:shouldDecodeSourceDataOfMIMEType:]):
(-[WKDownloadAsDelegate download:decideDestinationWithSuggestedFilename:]):
(-[WKDownloadAsDelegate download:didCreateDestination:]):
(-[WKDownloadAsDelegate downloadDidFinish:]):
(-[WKDownloadAsDelegate download:didFailWithError:]):
Use dispatchOnMainThread.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):
Remove code that cancels the current load and starts a new download.

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::convertMainResourceLoadToDownload):
Send the ConvertMainResourceLoadToDownload message to the network process.

2:25 PM Changeset in webkit [149210] by roger_fong@apple.com
  • 865 edits
    359 adds
    262 deletes in trunk/LayoutTests

Unreviewed. Rebaseline a bunch of tests and run optimize-baselines after disabling sub-pixel layout on mac.
https://bugs.webkit.org/show_bug.cgi?id=114999.

2:19 PM Changeset in webkit [149209] by roger_fong@apple.com
  • 9 edits in trunk/Source

Disable sub-pixel layout on mac.
https://bugs.webkit.org/show_bug.cgi?id=114999.

Reviewed by Simon Fraser.

  • Configurations/FeatureDefines.xcconfig:
  • WebCore.exp.in:

Export symbol needed to be added for IntRect(const LayoutRect&) constructor,
which is now being used in pixelSnappedIntRect(const LayoutRect&) in LayoutRect.h after disabling sub-pixel layout.

2:13 PM Changeset in webkit [149208] by Simon Fraser
  • 2 edits in trunk/Source/WebKit2

Inspector window is often blank when opened
https://bugs.webkit.org/show_bug.cgi?id=115220
<rdar://problem/13735496>

Reviewed by Tim Horton.

After disabling tiled scrolling and accelerated drawing in r149006, the
Inspector window was often missing its content after opening. This only
happened when the user has a preference on disk to use accelerated drawing
in the Inspector.

The missing content was caused by a failure to connect the correct contextID
for remote layer hosting. On window creation, we hook up a context using
WindowServer layer hosting (the default), but then switch back to app-hosted
layers for the Inspector window. This switching happens in didUpdateBackingStoreState(),
but that can be re-entered via its call to sendUpdateBackingStoreState(). In
that cause, on unwinding the stack it would call enterAcceleratedCompositingMode()
with a stale layerTreeContext.

Fix by moving the code that exits/enters accelerated compositing mode to before
the call to sendUpdateBackingStoreState() that can cause re-entrancy. That avoids
use of a possibly stale layerTreeContext.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::didUpdateBackingStoreState):

2:13 PM Changeset in webkit [149207] by Simon Fraser
  • 4 edits in trunk/Source

Layer-backed WebViews don't repaint content outside the visible area
https://bugs.webkit.org/show_bug.cgi?id=115275

Reviewed by Beth Dakin.

Source/WebCore:

Export ScrollView::setPaintsEntireContents(bool).

  • WebCore.exp.in:

Source/WebKit/mac:

When a client of WebView makes the WebView be layer-backed, then
AppKit propagaes the layer-backing down to the WebHTMLView (but
no further).

In this situation, we had a bug where content that was not
in the visible content rect would not get repainted, because
WebCore clips repaints to the visible rect.

Fix by calling ScrollView::setPaintsEntireContents(bool) from
-[WebHTMLView setLayer:], saying that we need
to paint the entire contents if we have a layer.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView setLayer:]):

1:34 PM Changeset in webkit [149206] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Check for valid element in elementTouched
https://bugs.webkit.org/show_bug.cgi?id=115205

Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-04-26
Reviewed by Rob Buis.

Internally reviewed by Genevieve Mak.

PR 331546
We might receive a null ptr from nodeAsElementIfApplicable which
is passed in here. Check to make sure it's valid before using.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::elementTouched):

1:12 PM Changeset in webkit [149205] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Make stack tracing more robust
https://bugs.webkit.org/show_bug.cgi?id=115272

Reviewed by Geoffrey Garen.

CallFrame already handles stack walking confusion robustly,
so we should make sure that the actual walk handles that as well.

  • interpreter/Interpreter.cpp:

(JSC::getCallerInfo):

12:42 PM Changeset in webkit [149204] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Crashes under ResourceHandle::continueDidReceiveResponse when loading blobs
https://bugs.webkit.org/show_bug.cgi?id=115273

Reviewed by Anders Carlsson.

Covered by multiple existing tests (when using NetworkProcess), including:

  • http/tests/fileapi/blob-url-in-subframe.html
  • http/tests/fileapi/create-blob-url-from-data-url.html
  • NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::continueDidReceiveResponse): Work around BlobResourceHandle badness.
12:09 PM Changeset in webkit [149203] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Change RenderMeter::valueRatio() visibility to public
https://bugs.webkit.org/show_bug.cgi?id=115266

This function is currently unused.
However, it is necessary to implement a RenderTheme capable of rendering Meter elements.

Patch by Daker Fernandes Pinheiro <daker.pinheiro@openbossa.org> on 2013-04-26
Reviewed by Alexis Menard.

No new tests, because no behaviour is changed.

  • rendering/RenderMeter.h:

(RenderMeter):

12:08 PM Changeset in webkit [149202] by timothy@apple.com
  • 6 edits
    1 add in trunk/Source

Add Runtime.parse to the Inspector protocol.

This will be used to parse console expressions for errors
before evaluating them fully.

https://webkit.org/b/115242

Reviewed by Oliver Hunt.

  • ForwardingHeaders/parser/ParserError.h: Added.
  • inspector/Inspector.json:
  • inspector/InspectorRuntimeAgent.cpp:

(WebCore::InspectorRuntimeAgent::parse):

  • inspector/InspectorRuntimeAgent.h:

(InspectorRuntimeAgent):

12:04 PM Changeset in webkit [149201] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the copyright years after r149057

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-26

  • page/DiagnosticLoggingKeys.cpp: I accidentally removed a year from

the copyright in r149057.

11:57 AM Changeset in webkit [149200] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Web Inspector: Crash due to null items from getDOMStorageItems
https://bugs.webkit.org/show_bug.cgi?id=115176

Patch by Konrad Piascik <kpiascik@blackberry.com> on 2013-04-26
Reviewed by Joseph Pecoraro.

Source/WebCore:

findStorageArea was returning a null storageArea causing the items
input paramater to not be set. This was happening without any error
being set at all. Set an error to prevent a crash when we try to
convert the result to a JSON string.

Added tests to check if session and local storage are empty that
they are still functional.

  • inspector/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):

LayoutTests:

Tests to check that if local and session storage are empty
that they still work corerctly.

  • inspector/storage-panel-dom-storage-empty-expected.txt: Added.
  • inspector/storage-panel-dom-storage-empty.html: Added.
11:40 AM Changeset in webkit [149199] by ap@apple.com
  • 3 edits in trunk/Source/WebKit2

[WK2] Remove NetworkResourceLoader::cleanupOnMainThread
https://bugs.webkit.org/show_bug.cgi?id=115268

Reviewed by Brady Eidson.

All cleanup() callers are now on main thread, and this indirection only complicates debugging.

  • NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::connectionToWebProcessDidClose): (WebKit::NetworkResourceLoader::abortInProgressLoad): (WebKit::NetworkResourceLoader::didFinishLoading): (WebKit::NetworkResourceLoader::didFail):
  • NetworkProcess/NetworkResourceLoader.h:
11:24 AM Changeset in webkit [149198] by aestes@apple.com
  • 3 edits in trunk/Source/WebKit2

[WebKit2] CustomProtocolManager's m_registeredSchemes HashSet can be accessed by multiple threads
https://bugs.webkit.org/show_bug.cgi?id=115267

Reviewed by Alexey Proskuryakov.

  • Shared/Network/CustomProtocols/CustomProtocolManager.h: Added a Mutex to protect m_registeredSchemes.
  • Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

(WebKit::CustomProtocolManager::registerScheme): Acquired the mutex before accessing m_registeredSchemes.
(WebKit::CustomProtocolManager::unregisterScheme): Ditto.
(WebKit::CustomProtocolManager::supportsScheme): Ditto.

11:10 AM Changeset in webkit [149197] by eric.carlson@apple.com
  • 2 edits in trunk/LayoutTests

[Mac] media/track/track-mode.html sometimes trigger InvalidStateError
https://bugs.webkit.org/show_bug.cgi?id=115045

Reviewed by Alexey Proskuryakov.

  • media/track/track-mode.html: Don't assume that the video element is ready for seeking

after a 100ms timeout.

10:51 AM Changeset in webkit [149196] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

Blobs are not associated with connection when there are no sandbox extensions
https://bugs.webkit.org/show_bug.cgi?id=115264

Reviewed by Brady Eidson.

Covered by multiple fast/files tests when using NetworkProcess.

  • NetworkProcess/FileAPI/NetworkBlobRegistry.cpp: (WebKit::NetworkBlobRegistry::registerBlobURL): Fixed a logic error.
10:41 AM Changeset in webkit [149195] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[GTK] Clean up the TestWebKitAPI GNUmakefile.am
https://bugs.webkit.org/show_bug.cgi?id=115233

Reviewed by Martin Robinson.

Specify unconditional, non-installable program targets in one declaration. Only conditionally specify
WebKit2-specific targets, not the complete target setups (i.e. targets' sources, cppflags listings etc.).
Add missing unit test source files to the TestWTF program, namely HashSet.cpp and MetaAllocator.cpp.
Specify the TestWTF program's CXXFLAGS to be the same as the global cxxflags as the source files need to
be compiled with the -fno-rtti flag that's present in the global_cxxflags variable.

  • TestWebKitAPI/GNUmakefile.am:
9:55 AM Changeset in webkit [149194] by aestes@apple.com
  • 11 edits
    3 copies
    2 adds in trunk

[WebKit2] Loading a resource from a custom protocol in a synchronous XHR times out
https://bugs.webkit.org/show_bug.cgi?id=115223

Reviewed by Darin Adler.

Source/WebKit2:

When WebKit performs a synchronous load on the Mac, it spins a nested
run loop in a mode that only accepts input from the NSURLConnection
performing the load. When the load is for a custom protocol in WebKit2,
we proxy it to the UI process via CoreIPC messages, but the response
messages from the UI process are never processed as long as the run
loop is in a non-common mode (and we wouldn't want to process messages
that could re-enter WebCore in the middle of loading, anyway). Since
these messages never make it back to the NSURLConnection handling the
request, the connection eventually times out.

Fix this by using a work queue to handle custom protocol messages in
the networking process. The work queue can process incoming custom
protocol messages while the main thread is blocked.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeConnection): Called
initializeConnection() on all the NetworkProcess's supplements.

  • Shared/ChildProcessSupplement.h: Added a base class for

NetworkProcessSupplement and WebProcessSupplement which defines
initializeConnection and provides an empty default implementation.
(WebKit::ChildProcessSupplement::~ChildProcessSupplement):
(WebKit::ChildProcessSupplement::initializeConnection):

  • Shared/Network/CustomProtocols/CustomProtocolManager.h:
  • Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

(WebKit::CustomProtocolManager::CustomProtocolManager): Instantiated a
work queue for message processing.
(WebKit::CustomProtocolManager::initializeConnection): Added the work
queue as a message receiver on the CoreIPC connection.
(WebKit::CustomProtocolManager::initialize): If we're in the web
process and the network process is being used, unregister and destroy
the work queue we previously created. It'd be better to not create it
in the first place, but we have to register our work queue with the
CoreIPC connection before it is established, which is before the UI
process has told us whether the network process is in use.

  • Shared/Network/NetworkProcessSupplement.h: Inherited from

ChildProcessSupplement.

  • WebKit2.xcodeproj/project.pbxproj: Added ChildProcessSupplement.h.
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeConnection): Called
initializeConnection() on all the WebProcess's supplements.

  • WebProcess/WebProcessSupplement.h: Inherited from

ChildProcessSupplement.

Tools:

Added an API test.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added new files.
  • TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm: Added.

(TestWebKitAPI::TEST): Tested that a synchronous XHR does not time out
when it loads a request with a custom protocol.

  • TestWebKitAPI/Tests/WebKit2/custom-protocol-sync-xhr.html: Added.
  • TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm: Moved the

NSURLProtocol subclass to TestProtocol.{h, mm} and did some
miscellaneous cleanup.

  • TestWebKitAPI/mac/TestProtocol.h: Copied from Source/WebKit2/WebProcess/WebProcessSupplement.h.
  • TestWebKitAPI/mac/TestProtocol.mm: Copied from Tools/TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsTest.mm.

(+[TestProtocol canInitWithRequest:]):
(+[TestProtocol canonicalRequestForRequest:]):
(+[TestProtocol requestIsCacheEquivalent:toRequest:]):
(+[TestProtocol scheme]):
(-[TestProtocol startLoading]):
(-[TestProtocol stopLoading]):

9:24 AM Changeset in webkit [149193] by Martin Robinson
  • 49 edits in trunk

Remove the remaining Skia #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=114886

Reviewed by Benjamin Poulain.

Source/WebCore:

  • html/HTMLCanvasElement.cpp: Remove Skia #ifdef references.
  • platform/graphics/BitmapImage.cpp: Ditto.
  • platform/graphics/FloatPoint.h: Ditto.
  • platform/graphics/FloatRect.h: Ditto.
  • platform/graphics/FontCache.h: Ditto.
  • platform/graphics/Gradient.cpp: Ditto.
  • platform/graphics/Gradient.h: Ditto.
  • platform/graphics/GraphicsContext.cpp: Ditto.
  • platform/graphics/GraphicsContext.h: Ditto.
  • platform/graphics/GraphicsContext3D.h: Ditto.
  • platform/graphics/ImageBuffer.cpp: Ditto.
  • platform/graphics/ImageBuffer.h: Ditto.
  • platform/graphics/ImageBufferData.h: Ditto.
  • platform/graphics/IntPoint.h: Ditto.
  • platform/graphics/IntRect.h: Ditto.
  • platform/graphics/NativeImagePtr.h: Ditto.
  • platform/graphics/Path.h: Ditto.
  • platform/graphics/Pattern.cpp: Ditto.
  • platform/graphics/Pattern.h: Ditto.
  • platform/graphics/filters/FEBlend.h: Ditto.
  • platform/graphics/filters/FEColorMatrix.h: Ditto.
  • platform/graphics/filters/FEComponentTransfer.h: Ditto.
  • platform/graphics/filters/FEComposite.h: Ditto.
  • platform/graphics/filters/FEConvolveMatrix.h: Ditto.
  • platform/graphics/filters/FEDisplacementMap.h: Ditto.
  • platform/graphics/filters/FEGaussianBlur.h: Ditto.
  • platform/graphics/filters/FELighting.h: Ditto.
  • platform/graphics/filters/FEMorphology.h: Ditto.
  • platform/graphics/filters/FEOffset.h: Ditto.
  • platform/graphics/filters/FilterEffect.cpp: Ditto.
  • platform/graphics/filters/FilterEffect.h: Ditto.
  • platform/graphics/transforms/AffineTransform.h: Ditto.
  • platform/graphics/transforms/TransformationMatrix.h: Ditto.
  • platform/image-decoders/ImageDecoder.cpp: Ditto.
  • platform/image-decoders/ImageDecoder.h: Ditto.
  • platform/image-decoders/jpeg/JPEGImageDecoder.cpp: Ditto.
  • platform/image-decoders/webp/WEBPImageDecoder.cpp: Ditto.
  • platform/mac/LocalCurrentGraphicsContext.h: Ditto.
  • platform/mac/LocalCurrentGraphicsContext.mm: Ditto.
  • rendering/svg/RenderSVGResourceSolidColor.cpp: Ditto.
  • svg/graphics/SVGImage.cpp: Ditto.
  • svg/graphics/SVGImage.h: Ditto.

Source/WebKit/blackberry:

  • Api/WebPage.cpp: Remove Skia #ifdef references.
  • WebCoreSupport/AboutDataUseFeatures.in: Ditto.

Source/WTF:

  • wtf/Platform.h:

Tools:

  • DumpRenderTree/blackberry/PixelDumpSupportBlackBerry.cpp:

(createBitmapContextFromWebView): Remove Skia #ifdef references.

9:16 AM Changeset in webkit [149192] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Compilation of ProcessLauncherGtk.cpp fails due to unresolved symbols
https://bugs.webkit.org/show_bug.cgi?id=115240

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2013-04-26
Reviewed by Martin Robinson.

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp: Includes sys/socket.h if OS is Linux
9:15 AM Changeset in webkit [149191] by ddkilzer@apple.com
  • 2 edits in trunk/LayoutTests

Sort jsc-test-list

$ sort -f -o LayoutTests/fast/js/jsc-test-list LayoutTests/fast/js/jsc-test-list

  • fast/js/jsc-test-list: Sort case-insensitively.
9:15 AM Changeset in webkit [149190] by ddkilzer@apple.com
  • 2 edits in trunk/LayoutTests

Upstream iOS changes to jsc-test-list

Reviewed by Michael Saboff.

  • fast/js/jsc-test-list: Add tests.
9:12 AM Changeset in webkit [149189] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip two failing tests.

  • platform/qt/TestExpectations:
9:08 AM Changeset in webkit [149188] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

Assert in JSC::Heap::unprotect when closing facebook.com web site
https://bugs.webkit.org/show_bug.cgi?id=115058

Reviewed by Darin Adler.

Grab a JSLock before calling RootObject::invalidate().

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::~ScriptController):

8:17 AM Changeset in webkit [149187] by eric.carlson@apple.com
  • 6 edits in trunk/Source/WebCore

[Mac] in-band cues sometimes have incorrect duration
https://bugs.webkit.org/show_bug.cgi?id=115200

Reviewed by Jer Noble.

No new tests, this is not possible to test in DRT.

  • html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::addGenericCue): Don't add completed cues to the map.
(WebCore::InbandTextTrack::removeGenericCue): Log when a cue is removed from the track.

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::InbandTextTrackPrivateAVF): Initialize m_pendingCueStatus.
(WebCore::InbandTextTrackPrivateAVF::processCue): Never call update() on a cue that is delivered

while seeking.

(WebCore::InbandTextTrackPrivateAVF::beginSeeking): Flush all incomplete cues, remember that

we are seeking.

(WebCore::InbandTextTrackPrivateAVF::resetCueValues):

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::seek): Call track->beginSeeking() instead of resetCueValues().
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Call track->endSeeking().

  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:

(WebCore::InbandTextTrackPrivateAVFObjC::kind): Include class name in Kind enum values to

avoid compile error.

8:14 AM Changeset in webkit [149186] by akling@apple.com
  • 21 edits in trunk/Source/WebCore

Remove wxWebKit from WebCore.
<http://webkit.org/b/115255>

Reviewed by Anders Carlsson.

  • DerivedSources.make:
  • WebCorePrefix.h:
  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::port):

  • config.h:
  • html/HTMLFormElement.cpp:
  • platform/ContextMenu.h:

(ContextMenu):

  • platform/ContextMenuItem.h:
  • platform/Cursor.h:
  • platform/DragData.h:
  • platform/DragImage.h:
  • platform/FileSystem.h:
  • platform/PlatformExportMacros.h:
  • platform/PlatformKeyboardEvent.h:

(PlatformKeyboardEvent):

  • platform/PlatformMenuDescription.h:
  • platform/PlatformMouseEvent.h:

(PlatformMouseEvent):

  • platform/PlatformWheelEvent.h:

(PlatformWheelEvent):

  • platform/ScrollView.cpp:
  • platform/ScrollView.h:

(ScrollView):

  • platform/Widget.h:
  • platform/win/SharedTimerWin.cpp:
8:13 AM Changeset in webkit [149185] by commit-queue@webkit.org
  • 6 edits
    3 adds in trunk

use-after-free removing a frame from its parent in a beforeload event of an OBJECT element
https://bugs.webkit.org/show_bug.cgi?id=113964

Source/WebCore:

Object elements have the tendecny to modify or even fully remove
the containing Document inside beforeload callback. While Document is removed,
RenderArena gets destroyed. Retained RenderWidgets fails to function with NULL arena.

Protect RendereArena from getting wiped out, when Document is removed
during FrameView::updateWidget().

Patch by Zalan Bujtas <Alan Bujtas> on 2013-04-26
Reviewed by Antti Koivisto.

Test: fast/frames/crash-remove-iframe-during-object-beforeload.html

  • dom/Document.cpp:

(WebCore::Document::attach):

  • dom/Document.h:

(Document):

  • page/FrameView.cpp:

(WebCore::FrameView::updateWidgets):

  • rendering/RenderArena.h:

(RenderArena):
(WebCore::RenderArena::create):

LayoutTests:

Patch by Zalan Bujtas <Alan Bujtas> on 2013-04-26
Reviewed by Antti Koivisto.

  • fast/frames/crash-remove-iframe-during-object-beforeload-expected.txt: Added.
  • fast/frames/crash-remove-iframe-during-object-beforeload.html: Added.
  • fast/frames/resources/remove-this-during-object-beforeload.html: Added.
7:56 AM Changeset in webkit [149184] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Source/WTF

Add move semantics to RefPtr
https://bugs.webkit.org/show_bug.cgi?id=115033

Reviewed by Anders Carlsson.

Add move constructors and move assignment operators to RefPtr when
COMPILER_SUPPORTS(CXX_RVALUE_REFERENCES).
This obviates unnecessary reffing/ureffing when RefPtr is created
or assigned from rvalue references.

  • wtf/RefPtr.h:

(RefPtr):
(WTF::RefPtr::RefPtr):
(WTF::RefPtr::operator=):

7:32 AM Changeset in webkit [149183] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r149165): It made many tests crash on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=115227

Reviewed by Csaba Osztrogonác.

m_reservation is uninitialized when ENABLE(SUPER_REGION) is false.

  • heap/SuperRegion.cpp:

(JSC::SuperRegion::~SuperRegion):

6:59 AM Changeset in webkit [149182] by mary.wu@torchmobile.com.cn
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Should check if it's cached resource before download
https://bugs.webkit.org/show_bug.cgi?id=115101

Reviewed by Rob Buis.

Since main resource maybe cached, if user want to save the resource, we first check
if it's cached. If yes, don't need to initiate a fresh load again, but get the
cached resource data out to save.

RIM bug# 324003, internally reviewed by Charles Wei.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::convertMainResourceLoadToDownload):

6:20 AM Changeset in webkit [149181] by zandobersek@gmail.com
  • 3 edits
    20 adds in trunk/LayoutTests

[GTK] Enable Web Audio layout tests on WK2, provide platform-specific expected output
https://bugs.webkit.org/show_bug.cgi?id=114513

Reviewed by Philippe Normand.

Unskip the Web Audio layout tests for GTK WK2 and generate platform-specific baselines for the tests.
The audio baselines are not audibly different from the generic baselines, but it can be expected that
different backends won't produce the same binary output.

The remaining failures are marked as such in the TestExpectations, each failure having the appropriate
bug handle covering the issue. The tests are still skipped for GTK WK1 as DumpRenderTree is still missing
infrastructure support for running these tests.

  • platform/gtk-wk1/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/gtk/webaudio/audiobuffersource-loop-points-expected.wav: Added.
  • platform/gtk/webaudio/audiobuffersource-playbackrate-expected.wav: Added.
  • platform/gtk/webaudio/codec-tests/aac/vbr-128kbps-44khz-expected.wav: Added.
  • platform/gtk/webaudio/codec-tests/mp3/128kbps-44khz-expected.wav: Added.
  • platform/gtk/webaudio/codec-tests/vorbis/vbr-128kbps-44khz-expected.wav: Added.
  • platform/gtk/webaudio/codec-tests/vorbis/vbr-70kbps-44khz-expected.wav: Added.
  • platform/gtk/webaudio/codec-tests/vorbis/vbr-96kbps-44khz-expected.wav: Added.
  • platform/gtk/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav: Added.
  • platform/gtk/webaudio/codec-tests/wav/24bit-44khz-expected.wav: Added.
  • platform/gtk/webaudio/oscillator-custom-expected.wav: Added.
  • platform/gtk/webaudio/oscillator-sawtooth-expected.wav: Added.
  • platform/gtk/webaudio/oscillator-sine-expected.wav: Added.
  • platform/gtk/webaudio/oscillator-square-expected.wav: Added.
  • platform/gtk/webaudio/oscillator-triangle-expected.wav: Added.
6:16 AM Changeset in webkit [149180] by mary.wu@torchmobile.com.cn
  • 5 edits in trunk

[BlackBerry] Clean up load interface in WebPage
https://bugs.webkit.org/show_bug.cgi?id=113267

Reviewed by Rob Buis.

Source/WebKit/blackberry:

Remove unused loadExtended(), combine load() and download() api in WebPage.
RIM Bug# 315535, internally reviewed by Joe Mason.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::load):

  • Api/WebPage.h:

Tools:

Update DumpRenderTree with change of load() interface in WebPage.
RIM Bug# 315535, internally reviewed by Joe Mason.

  • DumpRenderTree/blackberry/DumpRenderTree.cpp:

(BlackBerry::WebKit::DumpRenderTree::runTest):

6:09 AM Changeset in webkit [149179] by Claudio Saavedra
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed gardnering. Unskip passing test.

  • platform/gtk/TestExpectations: Unskip http/tests/inspector/compiler-source-mapping-debug.html
6:07 AM Changeset in webkit [149178] by akling@apple.com
  • 8 edits
    3 deletes in trunk/Source/WTF

Remove wxWebKit from WTF.
<http://webkit.org/b/115249>

Reviewed by Antti Koivisto.

  • wscript: Removed.
  • wtf/ArrayBufferView.h:

(ArrayBufferView):

  • wtf/CurrentTime.cpp:
  • wtf/DisallowCType.h:
  • wtf/ExportMacros.h:
  • wtf/FeatureDefines.h:
  • wtf/Platform.h:
  • wtf/text/WTFString.h:

(String):

  • wtf/wx/MainThreadWx.cpp: Removed.
  • wtf/wx/StringWx.cpp: Removed.
6:03 AM Changeset in webkit [149177] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

Optimize function and interface object length computation in bindings generator
https://bugs.webkit.org/show_bug.cgi?id=115247

Reviewed by Kentaro Hara.

Introduce new GetFunctionLength() function that efficiently compute the length
of a function (i.e. its number of mandatory parameters).

We now call GetFunctionLength() instead of GenerateFunctionParametersCheck()
whenever we care only interested in the function length and not the actual
expression for checking the parameters. This is much more efficient as
GenerateFunctionParametersCheck() does a lot more processing than we need in
this case.

No new tests, no behavior change.

  • bindings/scripts/CodeGeneratorJS.pm:

(GetFunctionLength):
(GenerateImplementation):
(GenerateConstructorHelperMethods):

6:02 AM Changeset in webkit [149176] by zandobersek@gmail.com
  • 1 edit
    1 delete in trunk/Tools

Remove the HeapGraphSerializer unit test
https://bugs.webkit.org/show_bug.cgi?id=115231

Reviewed by Andreas Kling.

Remove the HeapGraphSerializer unit test. The code it was testing was removed in r148921,
specifically the Source/WebCore/inspector/HeapGraphSerializer.(cpp|h) files.

  • TestWebKitAPI/Tests/WebCore/HeapGraphSerializerTest.cpp: Removed.
5:09 AM FeatureFlags edited by akling@apple.com
(diff)
4:48 AM Changeset in webkit [149175] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Web Audio: Remove reduplicative addInput() in AnalyserNode.
<http://webkit.org/b/115244>

From Blink r149155 by <james.wei@intel.com>:

The parent class BasicInspectorNode already called addInput() and addOutput().
So it is reduplicative to call them in AnalyserNode.

  • Modules/webaudio/AnalyserNode.cpp:

(WebCore::AnalyserNode::AnalyserNode):

  • Modules/webaudio/AudioBasicInspectorNode.cpp:

(WebCore::AudioBasicInspectorNode::AudioBasicInspectorNode):

  • Modules/webaudio/AudioBasicInspectorNode.h:

(AudioBasicInspectorNode):

  • Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):

3:30 AM Changeset in webkit [149174] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Add unit test cases for ewk_settings APIs
https://bugs.webkit.org/show_bug.cgi?id=114897

Patch by Jose Lejin PJ <jose.lejin@gmail.com> on 2013-04-26
Reviewed by Gyuyoung Kim.

Added unit tests for ewk_settings APIs.

  • tests/test_ewk_setting.cpp:

(TEST_F):

2:42 AM Changeset in webkit [149173] by allan.jensen@digia.com
  • 20 edits
    4 adds in trunk

Mouseenter and mouseleave events not supported
https://bugs.webkit.org/show_bug.cgi?id=18930

Reviewed by David Hyatt.

Source/WebCore:

Implements mouseenter and mouseleave events from W3C DOM Level 3 Events.
These event are already supported by all other major browsers.

To avoid performance regressions the new events are only dispatched when
there are event listeners for them.

Tests: fast/events/mouseenter-mouseleave-capture.html

fast/events/mouseenter-mouseleave.html

  • bindings/scripts/CodeGenerator.pm:
  • dom/Document.cpp:

(WebCore::Document::prepareMouseEvent):
(WebCore::Document::updateHoverActiveState):

  • dom/Document.h:

(Document):

  • dom/Document.idl:
  • dom/Element.h:

(Element):

  • dom/Element.idl:
  • dom/EventListenerMap.cpp:

(WebCore::EventListenerMap::containsCapturing):

  • dom/EventListenerMap.h:

(EventListenerMap):

  • dom/EventNames.h:
  • dom/EventTarget.h:

(EventTarget):
(WebCore::EventTarget::hasCapturingEventListeners):

  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::create):
(WebCore::MouseEvent::toElement):
(WebCore::MouseEvent::fromElement):

  • html/HTMLAttributeNames.in:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::eventNameForAttributeName):

  • page/DOMWindow.h:

(DOMWindow):

  • page/DOMWindow.idl:
  • svg/SVGElement.cpp:

(WebCore::SVGElement::parseAttribute):

  • svg/SVGElementInstance.h:

(SVGElementInstance):

  • svg/SVGElementInstance.idl:

LayoutTests:

To new tests that mouseenter and mouseleave works in both bubbling and capture phase.

  • fast/events/mouseenter-mouseleave-capture-expected.txt: Added.
  • fast/events/mouseenter-mouseleave-capture.html: Added.
  • fast/events/mouseenter-mouseleave-expected.txt: Added.
  • fast/events/mouseenter-mouseleave.html: Added.
2:36 AM Changeset in webkit [149172] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix SH4 build broken since r149159.
https://bugs.webkit.org/show_bug.cgi?id=115229

Add BranchTruncateType enum in SH4 port and handle it in branchTruncateDoubleToInt32.

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-04-26
Reviewed by Allan Sandfeld Jensen.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branchTruncateDoubleToInt32):

2:16 AM Changeset in webkit [149171] by Christophe Dumez
  • 5 edits in trunk/LayoutTests

[Qt] REGRESSION(r149001): It made two fast/dom/DeviceMotion tests fail.
https://bugs.webkit.org/show_bug.cgi?id=115235

Reviewed by Kentaro Hara.

Update window-property.html test cases for DeviceMotion and DeviceOrientation.
The global constructors are no longer enumerable after r149001.

  • fast/dom/DeviceMotion/script-tests/window-property.js:
  • fast/dom/DeviceMotion/window-property-expected.txt:
  • fast/dom/DeviceOrientation/script-tests/window-property.js:
  • fast/dom/DeviceOrientation/window-property-expected.txt:
12:38 AM WebKitIDL edited by Christophe Dumez
Drop Supplemental in favor of partial interfaces due to r149170 (diff)
12:35 AM WebKitIDL edited by Christophe Dumez
[Callback] only applies to parameters, not interfaces (diff)
12:29 AM Changeset in webkit [149170] by Christophe Dumez
  • 33 edits in trunk/Source/WebCore

Add support for Web IDL partial interfaces to the bindings generator
https://bugs.webkit.org/show_bug.cgi?id=115228

Reviewed by Kentaro Hara.

Add support for Web IDL partial interfaces to the bindings generator:
http://dev.w3.org/2006/webapi/WebIDL/#dfn-partial-interface

Also drop support for the the WebKit-specific [Supplemental] extended
attribute and use partial interfaces instead in existing IDL files.

No new tests, no behavior change.

  • Modules/battery/NavigatorBattery.idl:
  • Modules/filesystem/DOMWindowFileSystem.idl:
  • Modules/filesystem/DataTransferItemFileSystem.idl:
  • Modules/filesystem/HTMLInputElementFileSystem.idl:
  • Modules/filesystem/WorkerContextFileSystem.idl:
  • Modules/gamepad/NavigatorGamepad.idl:
  • Modules/geolocation/NavigatorGeolocation.idl:
  • Modules/indexeddb/DOMWindowIndexedDatabase.idl:
  • Modules/indexeddb/WorkerContextIndexedDatabase.idl:
  • Modules/mediastream/DOMWindowMediaStream.idl:
  • Modules/mediastream/NavigatorMediaStream.idl:
  • Modules/navigatorcontentutils/NavigatorContentUtils.idl:
  • Modules/networkinfo/NavigatorNetworkInfoConnection.idl:
  • Modules/notifications/DOMWindowNotifications.idl:
  • Modules/notifications/WorkerContextNotifications.idl:
  • Modules/quota/DOMWindowQuota.idl:
  • Modules/quota/NavigatorStorageQuota.idl:
  • Modules/quota/WorkerNavigatorStorageQuota.idl:
  • Modules/speech/DOMWindowSpeech.idl:
  • Modules/speech/DOMWindowSpeechSynthesis.idl:
  • Modules/vibration/NavigatorVibration.idl:
  • Modules/webaudio/DOMWindowWebAudio.idl:
  • Modules/webdatabase/DOMWindowWebDatabase.idl:
  • Modules/webdatabase/WorkerContextWebDatabase.idl:
  • Modules/websockets/DOMWindowWebSocket.idl:
  • Modules/websockets/WorkerContextWebSocket.idl:
  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/IDLParser.pm:

(parsePartialDefinition):

  • bindings/scripts/generate-bindings.pl:
  • bindings/scripts/preprocess-idls.pl:

(getPartialInterfaceNameFromIDLFile):

  • bindings/scripts/test/TestSupplemental.idl:
  • page/DOMWindowPagePopup.idl:

Apr 25, 2013:

11:50 PM Changeset in webkit [149169] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebKit2

[GTK] Plugin process broken due to a missing symbol
https://bugs.webkit.org/show_bug.cgi?id=114901

Reviewed by Gustavo Noronha Silva.

Work around the missing symbols in the WebKitPluginProcess by specifying the required libraries
multiple times in the program's LDADD list. Libtool fights fiercely to avoid duplicate static library
references among the linker arguments (even if using the --preserve-dup-deps flag) so the required libraries
are specified in various ways.

The unresolved symbols in object files are no longer ignored as this can lead to further trouble (for instance
this patch also adds a few missing source files to the list of WebKitPluginProcess sources). The Freetype and
gamepad dependencies' libraries are also added to the binary's LDADD list.

  • GNUmakefile.am:
  • GNUmakefile.list.am: Add a few missing files to the build.
11:23 PM Changeset in webkit [149168] by mihnea@adobe.com
  • 4 edits
    2 adds in trunk

[CSS Regions] Hit testing is broken for absolutely positioned regions that have overflow: hidden
https://bugs.webkit.org/show_bug.cgi?id=113874

Reviewed by David Hyatt.

Source/WebCore:

Test: fast/regions/hit-test-abspos-overflow-region.html

When a region is an out-of-flow positioned object with an overflow clip, we need
to make sure that hit testing works also for cases other than foreground (content)
hit testing. This patch moves the previous hit testing code, that delegated foreground
hit testing to the region's flow thread hit testing, into the hitTestContent method,
now that RenderRegion is RenderBlock based.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::hitTestContents):

  • rendering/RenderRegion.h:

(RenderRegion):

LayoutTests:

Add test for hit-testing of border of an out-of-flow region with overflow: hidden.

  • fast/regions/hit-test-abspos-overflow-region-expected.txt: Added.
  • fast/regions/hit-test-abspos-overflow-region.html: Added.
9:51 PM Changeset in webkit [149167] by rniwa@webkit.org
  • 4 edits
    2 adds in trunk

Copy and paste can strip !important CSS rules due to a bug in mergeStyleFromRules
https://bugs.webkit.org/show_bug.cgi?id=115217

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by mergeStyleFromRules overriding "important" style rules with "unimportant" inline styles.
Fixed the bug by using addParsedProperty, which respects !important, in MutableStylePropertySet's
mergeAndOverrideOnConflict, which was only used in editing code. Now that we've fixed this function, we can use
it in ViewportStyleResolver::addViewportRule as well.

Test: editing/pasteboard/copy-paste-with-important-rules.html

  • css/StylePropertySet.cpp:

(WebCore::MutableStylePropertySet::mergeAndOverrideOnConflict): Fixed to respect !important.

  • css/ViewportStyleResolver.cpp:

(WebCore::ViewportStyleResolver::addViewportRule): Use mergeAndOverrideOnConflict now that the code is identical.

LayoutTests:

Added a regression test.

  • editing/pasteboard/copy-paste-with-important-rules-expected.txt: Added.
  • editing/pasteboard/copy-paste-with-important-rules.html: Added.
9:50 PM Changeset in webkit [149166] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Remove support for Chromium from build/update scripts
https://bugs.webkit.org/show_bug.cgi?id=115218

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-25
Reviewed by Darin Adler.

  • Scripts/build-webkit:

(writeCongrats):

  • Scripts/update-webkit:
7:47 PM Changeset in webkit [149165] by mhahnenberg@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

SuperRegion doesn't call deallocate() on its PageReservation
https://bugs.webkit.org/show_bug.cgi?id=115208

Reviewed by Geoffrey Garen.

It should. This doesn't cause us to leak physical memory, but it does cause us to leak virtual
address space (and probably mach ports), which is also bad :-( FixedVMPoolExecutableAllocator
also has this bug, but it doesn't matter much because there's only one instance of that class
throughout the entire lifetime of the process, whereas each VM has its own SuperRegion.

  • heap/SuperRegion.cpp:

(JSC::SuperRegion::~SuperRegion):

  • heap/SuperRegion.h:

(SuperRegion):

  • jit/ExecutableAllocatorFixedVMPool.cpp:

(FixedVMPoolExecutableAllocator):
(JSC::FixedVMPoolExecutableAllocator::~FixedVMPoolExecutableAllocator):

7:30 PM Changeset in webkit [149164] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Remove support for Chromium from api-test
https://bugs.webkit.org/show_bug.cgi?id=115211

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-25
Reviewed by Dirk Pranke.

  • Scripts/build-api-tests:
  • Scripts/run-api-tests:

(isSupportedPlatform):

6:38 PM Changeset in webkit [149163] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Get rid of Chromium in build-dumprendertree
https://bugs.webkit.org/show_bug.cgi?id=115212

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-25
Reviewed by Dirk Pranke.

  • Scripts/build-dumprendertree:
6:18 PM Changeset in webkit [149162] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

DFG doesn't support to_jsnumber
https://bugs.webkit.org/show_bug.cgi?id=115129

Reviewed by Geoffrey Garen.

Based on Oliver's patch. Implements to_jsnumber as Identity(Number:@thingy), and then does
an optimization in Fixup to turn Identity(Number:) into Identity(Int32:) if the predictions
tell us to. Identity is later turned into Phantom.

Also fixed BackPropMask, which appeared to have NodeDoesNotExit included in it. That's
wrong; NodeDoesNotExit is not a backward propagation property.

Also fixed Identity to be marked as CanExit (i.e. not NodeDoesNotExit).

This more than doubles the FPS on ammo.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.h:

(JSC::DFG::canCompileOpcode):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(FixupPhase):
(JSC::DFG::FixupPhase::observeUseKindOnNode):
(JSC::DFG::FixupPhase::observeUseKindOnEdge):

  • dfg/DFGNodeFlags.h:

(DFG):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

5:50 PM Changeset in webkit [149161] by mrowe@apple.com
  • 4 edits in trunk/Source

Versioning.

5:49 PM Changeset in webkit [149160] by mrowe@apple.com
  • 1 copy in tags/Safari-537.39

New tag.

5:41 PM Changeset in webkit [149159] by oliver@apple.com
  • 21 edits
    12 adds in trunk

Add support for Math.imul
https://bugs.webkit.org/show_bug.cgi?id=115143

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Add support for Math.imul, a thunk generator for Math.imul,
and an intrinsic.

Fairly self explanatory set of changes, DFG intrinsics simply
leverages the existing ValueToInt32 nodes.

  • create_hash_table:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

  • dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::propagate):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsic):

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNodeType.h:

(DFG):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithIMul):

  • dfg/DFGSpeculativeJIT.h:

(SpeculativeJIT):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/ThunkGenerators.cpp:

(JSC::imulThunkGenerator):
(JSC):

  • jit/ThunkGenerators.h:

(JSC):

  • runtime/Intrinsic.h:
  • runtime/MathObject.cpp:

(JSC):
(JSC::mathProtoFuncIMul):

  • runtime/VM.cpp:

(JSC::thunkGeneratorForIntrinsic):

LayoutTests:

Add a bunch of tests for Math.imul

  • fast/js/Object-getOwnPropertyNames-expected.txt:
  • fast/js/imul-expected.txt: Added.
  • fast/js/imul.html: Added.
  • fast/js/regress/imul-double-only-expected.txt: Added.
  • fast/js/regress/imul-double-only.html: Added.
  • fast/js/regress/imul-int-only-expected.txt: Added.
  • fast/js/regress/imul-int-only.html: Added.
  • fast/js/regress/imul-mixed-expected.txt: Added.
  • fast/js/regress/imul-mixed.html: Added.
  • fast/js/regress/script-tests/imul-double-only.js: Added.

(f):

  • fast/js/regress/script-tests/imul-int-only.js: Added.

(f):

  • fast/js/regress/script-tests/imul-mixed.js: Added.

(f):

  • fast/js/script-tests/Object-getOwnPropertyNames.js:
  • fast/js/script-tests/imul.js: Added.

(testIMul):

5:40 PM Changeset in webkit [149158] by fpizlo@apple.com
  • 15 edits in trunk/Source

Unreviewed, roll out http://trac.webkit.org/changeset/148999
It broke http://kripken.github.io/ammo.js/examples/new/ammo.html

Source/JavaScriptCore:

(JSC::BytecodeGenerator::emitNewArray):
(JSC::BytecodeGenerator::emitThrowReferenceError):
(JSC::BytecodeGenerator::emitReadOnlyExceptionIfNeeded):

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::shouldEmitProfileHooks):
(BytecodeGenerator):

  • bytecompiler/NodesCodegen.cpp:

(JSC):
(JSC::NullNode::emitBytecode):
(JSC::BooleanNode::emitBytecode):
(JSC::NumberNode::emitBytecode):
(JSC::StringNode::emitBytecode):
(JSC::IfNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createIfStatement):
(ASTBuilder):

  • parser/NodeConstructors.h:

(JSC):
(JSC::NullNode::NullNode):
(JSC::BooleanNode::BooleanNode):
(JSC::NumberNode::NumberNode):
(JSC::StringNode::StringNode):
(JSC::IfNode::IfNode):
(JSC::IfElseNode::IfElseNode):

  • parser/Nodes.h:

(JSC::ExpressionNode::isPure):
(JSC::ExpressionNode::isSubtract):
(StatementNode):
(NullNode):
(JSC::NullNode::isNull):
(BooleanNode):
(JSC::BooleanNode::isPure):
(NumberNode):
(JSC::NumberNode::value):
(JSC::NumberNode::isPure):
(StringNode):
(JSC::StringNode::isPure):
(JSC::StringNode::isString):
(BinaryOpNode):
(IfNode):
(JSC):
(IfElseNode):
(ContinueNode):
(BreakNode):

  • parser/Parser.cpp:

(JSC::::parseIfStatement):

  • parser/ResultType.h:

(ResultType):

  • runtime/JSCJSValueInlines.h:

(JSC::JSValue::pureToBoolean):

  • runtime/JSCell.h:

(JSCell):

  • runtime/JSCellInlines.h:

(JSC):

Source/WTF:

  • wtf/TriState.h:
5:33 PM Changeset in webkit [149157] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

StylePropertySet::getPropertyShorthand() should return a String.
<http://webkit.org/b/115213>

Reviewed by Anders Carlsson.

Return a String directly from getPropertyShorthand() instead of forcing clients
to call getPropertyNameString().

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::getPropertyShorthand):

  • css/StylePropertySet.cpp:

(WebCore::StylePropertySet::getPropertyShorthand):

  • css/StylePropertySet.h:

(StylePropertySet):

5:27 PM Changeset in webkit [149156] by Chris Fleizach
  • 13 edits in trunk

WEB SPEECH: language support does not work as expected
https://bugs.webkit.org/show_bug.cgi?id=115119

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Make the Mac platform synthesizer have access to all the voices installed on the system.

  • WebCore.exp.in:
  • platform/mac/PlatformSpeechSynthesizerMac.mm:

(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

WebKitLibraries:

  • WebKitSystemInterface.h:
4:33 PM Changeset in webkit [149155] by Chris Fleizach
  • 11 edits
    2 adds in trunk

Source/WebCore: <meter> element not exposed to accessibility
https://bugs.webkit.org/show_bug.cgi?id=109023
rdar://problem/13658964

Reviewed by Tim Horton.

Makes the <meter> element appear in the AX tree by reusing the
AccessibilityProgressIndicator element to handle either progress or meter
elements.

Test: accessibility/meter-element.html

  • accessibility/AXObjectCache.cpp:

(WebCore::createFromRenderer):
(WebCore::AXObjectCache::getOrCreate):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::canHaveChildren):
(WebCore::AccessibilityNodeObject::visibleText):

  • accessibility/AccessibilityProgressIndicator.cpp:

(WebCore::AccessibilityProgressIndicator::AccessibilityProgressIndicator):
(WebCore::AccessibilityProgressIndicator::create):
(WebCore::AccessibilityProgressIndicator::valueForRange):
(WebCore::AccessibilityProgressIndicator::maxValueForRange):
(WebCore::AccessibilityProgressIndicator::minValueForRange):
(WebCore::AccessibilityProgressIndicator::progressElement):
(WebCore::AccessibilityProgressIndicator::meterElement):

  • accessibility/AccessibilityProgressIndicator.h:

(AccessibilityProgressIndicator):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::firstChild):
(WebCore::AccessibilityRenderObject::lastChild):

These methods are modified to handle when there is no rendered children, but there are Node
children. The node children are desired when calculating text within a node, for example.

LayoutTests: <meter> element not exposed to accessibility
https://bugs.webkit.org/show_bug.cgi?id=109023

Reviewed by Tim Horton.

  • accessibility/meter-element-expected.txt: Added.
  • accessibility/meter-element.html: Added.
  • platform/mac/accessibility/role-subrole-roledescription-expected.txt:
  • platform/mac/accessibility/role-subrole-roledescription.html:
4:10 PM Changeset in webkit [149154] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

PreciseJumpTargets should treat loop_hint as a jump target
https://bugs.webkit.org/show_bug.cgi?id=115209

Reviewed by Mark Hahnenberg.

I didn't add a test but I turned this into a release assertion. Running Octane is enough
to trigger it.

  • bytecode/PreciseJumpTargets.cpp:

(JSC::computePreciseJumpTargets):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

4:06 PM Changeset in webkit [149153] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[CSS Shaders] Remove the meshType from the CustomFilterOperation
https://bugs.webkit.org/show_bug.cgi?id=102529

Patch by Qiankun Miao <qiankun.miao@intel.com> on 2013-04-25
Reviewed by Dean Jackson.

No new tests, no new functionality.

MeshType can be accessed from program, so remove the m_meshType
related code in CustomFilterOperation.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):

  • platform/graphics/filters/CustomFilterOperation.cpp:

(WebCore::CustomFilterOperation::CustomFilterOperation):
(WebCore::CustomFilterOperation::blend):

  • platform/graphics/filters/CustomFilterOperation.h:

(WebCore::CustomFilterOperation::create):
(WebCore::CustomFilterOperation::meshType):
(CustomFilterOperation):
(WebCore::CustomFilterOperation::operator==):

  • platform/graphics/texmap/coordinated/CoordinatedCustomFilterOperation.h:

(WebCore::CoordinatedCustomFilterOperation::CoordinatedCustomFilterOperation):

3:52 PM Changeset in webkit [149152] by commit-queue@webkit.org
  • 10 edits
    9 adds in trunk

Source/JavaScriptCore: Fix problems with processing negative zero on DFG.
https://bugs.webkit.org/show_bug.cgi?id=113862

Patch by Roman Zhuykov <zhroma@ispras.ru> on 2013-04-25
Reviewed by Filip Pizlo.

Fix NodeNeedsNegZero flag propagation in BackwardPropagationPhase.
Function arithNodeFlags should not mask NodeNeedsNegZero flag for ArithNegate and DoubleAsInt32
nodes and this flag should be always used to decide where we need to generate nezative-zero checks.
Remove unnecessary negative-zero checks from integer ArithDiv on ARM.
Also remove such checks from integer ArithMod on ARM and X86, and make them always to
check not only "modulo_result == 0" but also "dividend < 0".
Generate faster code for case when ArithMod operation divisor is constant power of 2 on ARMv7
in the same way as on ARMv7s, and add negative-zero checks into this code when needed.
Change speculationCheck ExitKind from Overflow to NegativeZero where applicable.

This shows 30% speedup of math-spectral-norm, and 5% speedup
on SunSpider overall on ARMv7 Linux.

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::branchConvertDoubleToInt32):

  • assembler/MacroAssemblerMIPS.h:

(JSC::MacroAssemblerMIPS::branchConvertDoubleToInt32):

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branchConvertDoubleToInt32):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::branchConvertDoubleToInt32):

  • dfg/DFGBackwardsPropagationPhase.cpp:

(JSC::DFG::BackwardsPropagationPhase::isNotNegZero):
(JSC::DFG::BackwardsPropagationPhase::isNotPosZero):
(JSC::DFG::BackwardsPropagationPhase::propagate):

  • dfg/DFGNode.h:

(JSC::DFG::Node::arithNodeFlags):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileDoubleAsInt32):
(JSC::DFG::SpeculativeJIT::compileSoftModulo):
(JSC::DFG::SpeculativeJIT::compileArithNegate):

LayoutTests: Arithmetic operations with negative zero should be optimized correclty.
https://bugs.webkit.org/show_bug.cgi?id=113862

Patch by Roman Zhuykov <zhroma@ispras.ru> on 2013-04-25
Reviewed by Filip Pizlo.

  • fast/js/regress/negative-zero-divide-expected.txt: Added.
  • fast/js/regress/negative-zero-divide.html: Added.
  • fast/js/regress/negative-zero-modulo-expected.txt: Added.
  • fast/js/regress/negative-zero-modulo.html: Added.
  • fast/js/regress/negative-zero-negate-expected.txt: Added.
  • fast/js/regress/negative-zero-negate.html: Added.
  • fast/js/regress/script-tests/negative-zero-divide.js: Added.

(foo):

  • fast/js/regress/script-tests/negative-zero-modulo.js: Added.

(foo):

  • fast/js/regress/script-tests/negative-zero-negate.js: Added.

(foo):

3:51 PM Changeset in webkit [149151] by tkent@chromium.org
  • 7 edits in trunk

Ignore invalid regular expressions for input[pattern].
https://bugs.webkit.org/show_bug.cgi?id=115204

Reviewed by Darin Adler.

Source/WebCore:

According to the specification, we should not proceed regular expression
matching if a pattern attribute value is an invalid regular
expression. We had a bug that invalid expressions such as
pattern=")foo(" made RegularExpression objects successfully.

http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#the-pattern-attribute

If an input element has a pattern attribute specified, and the
attribute's value, when compiled as a JavaScript regular expression with
the global, ignoreCase, and multiline flags disabled (see ECMA262
Edition 5, sections 15.10.7.2 through 15.10.7.4), compiles successfully,
then the resulting regular expression is the element's compiled pattern
regular expression. If the element has no such attribute, or if the
value doesn't compile successfully, then the element has no compiled
pattern regular expression.

This imports a part of Blink r148951.

Tests: Update fast/forms/ValidityState-patternMismatch.html

  • html/BaseTextInputType.cpp:

(WebCore::BaseTextInputType::patternMismatch):
Check correctness of pattern attribute value before wrapping with parentheses.

  • platform/text/RegularExpression.cpp:

(WebCore::RegularExpression::isValid): Added.

  • platform/text/RegularExpression.h:

(RegularExpression): Declare isValid.

LayoutTests:

  • fast/forms/ValidityState-patternMismatch-expected.txt:
  • fast/forms/ValidityState-patternMismatch.html:
3:50 PM Changeset in webkit [149150] by oliver@apple.com
  • 2 edits in trunk/Source/WTF

Fix 32bit build

3:37 PM Changeset in webkit [149149] by Simon Fraser
  • 2 edits in trunk/Source/WebKit/mac

Build fix for smart compliers.

Reviewed by Tim Horton.

[NSDictionary dictionaryWithObjectsAndKeys:] returns an NSDictionary,
not a NSMutableDictionary.

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::updateSpellingUIWithGrammarString):

3:25 PM Changeset in webkit [149148] by ap@apple.com
  • 8 edits in trunk/Tools

Pass relatedPage when creating a page in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=115206

Reviewed by Geoffrey Garen.

To make sure that window.open() opens in the same process even when using multiple processes.

  • WebKitTestRunner/PlatformWebView.h:
  • WebKitTestRunner/TestController.cpp: (WTR::TestController::createOtherPage): (WTR::TestController::createWebViewWithOptions):
  • WebKitTestRunner/efl/PlatformWebViewEfl.cpp: (WTR::PlatformWebView::PlatformWebView):
  • WebKitTestRunner/gtk/PlatformWebViewGtk.cpp: (WTR::PlatformWebView::PlatformWebView):
  • WebKitTestRunner/mac/PlatformWebViewMac.mm: (-[TestRunnerWKView initWithFrame:contextRef:pageGroupRef:relatedToPage:useTiledDrawing:]): (WTR::PlatformWebView::PlatformWebView):
  • WebKitTestRunner/qt/PlatformWebViewQt.cpp: (WTR::PlatformWebView::PlatformWebView):
  • WebKitTestRunner/win/PlatformWebViewWin.cpp: (WTR::PlatformWebView::PlatformWebView):
3:23 PM Changeset in webkit [149147] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Rename DecidePolicyForResponse message to DecidePolicyForResponseSync
https://bugs.webkit.org/show_bug.cgi?id=115207

Reviewed by Beth Dakin.

In preparation for adding a new async DecidePolicyForResponse message,
rename the current one to DecidePolicyForResponseSync. Also split out the async part
into a separate WebPageProxy::decidePolicyForResponse member function.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForResponse):
(WebKit::WebPageProxy::decidePolicyForResponseSync):

  • UIProcess/WebPageProxy.h:

(WebPageProxy):

  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):

3:17 PM Changeset in webkit [149146] by oliver@apple.com
  • 4 edits in trunk/Source

Stack guards are too conservative
https://bugs.webkit.org/show_bug.cgi?id=115147

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

Increase stack guard to closer to old size.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::StackPolicy::StackPolicy):

Source/WTF:

Use getrlimit on darwin to get the stack size for the main thread.

  • wtf/StackBounds.cpp:

(WTF::StackBounds::initialize):

2:39 PM Changeset in webkit [149145] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Selection overlay on non-composited iframes are incorrectly positioned.
https://bugs.webkit.org/show_bug.cgi?id=115197

Patch by Andrew Lo <anlo@rim.com> on 2013-04-25
Reviewed by Rob Buis.

When drawing the selection overlay, the rects to
paint when selecting text on non-composited sub-frames
need to be adjusted by the frame position.

  • WebKitSupport/SelectionOverlay.cpp:

(BlackBerry::WebKit::SelectionOverlay::paintContents):

2:29 PM Changeset in webkit [149144] by Antoine Quint
  • 2 edits in trunk/Source/WebCore

Glyphs may fail to render when using SVG font
https://bugs.webkit.org/show_bug.cgi?id=115193

Reviewed by Simon Fraser.

Calling SimpleFontData::applyTransforms() when the font used is
an SVG font makes little sense since Core Text doesn’t know or
understand SVG fonts and would be passed some other, unrelated
platform font.

  • platform/graphics/SimpleFontData.h:

(WebCore::SimpleFontData::applyTransforms):

2:21 PM Changeset in webkit [149143] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Fix autocompletion for Benjamin. The Bugzilla email address must come first.

  • Scripts/webkitpy/common/config/contributors.json:
2:02 PM Changeset in webkit [149142] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

Media elements shouldn't resume playback when a page is restored from the back/forward cache if the WKView isn't in a window
https://bugs.webkit.org/show_bug.cgi?id=115191

Reviewed by Eric Carlson.

If a page is suspended, then resumed when its WebView or WKView has been removed from a window,
the page's media elements will unpause. Check whether media is allowed to start during resume()
via Page::canMediaStart() and if not, register for mediaCanStart notifications. Then, in
mediaCanStart() if the media is force-paused, unpause it.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::suspend):
(WebCore::HTMLMediaElement::resume):
(WebCore::HTMLMediaElement::mediaCanStart):

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::pageConsentRequiredForResume):

2:01 PM Changeset in webkit [149141] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Update a comment, mentioning a newly filed bug.

  • platform/wk2/TestExpectations:
1:37 PM Changeset in webkit [149140] by akling@apple.com
  • 7 edits in trunk/Source

Remove ENABLE(PARSED_STYLE_SHEET_CACHING) and make it always-on.

Rubber-stamped by Anders Koivisto.

Source/WebCore:

  • PlatformWinCE.cmake:
  • accessibility/AccessibilityObject.h:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::setCSSStyleSheet):

Source/WebKit:

  • PlatformWinCE.cmake:

Source/WebKit/blackberry:

  • WebCoreSupport/AboutDataEnableFeatures.in:

Source/WTF:

  • wtf/FeatureDefines.h:
1:26 PM Changeset in webkit [149139] by Patrick Gansterer
  • 5 edits in trunk/Source

Remove OS(WINCE) from AccessibilityObject.h
https://bugs.webkit.org/show_bug.cgi?id=115192

Reviewed by Andreas Kling.

Use the same files like the the other PLATFORM(WIN) ports use.

Source/WebCore:

  • PlatformWinCE.cmake:
  • accessibility/AccessibilityObject.h:

(AccessibilityObject):

Source/WebKit:

  • PlatformWinCE.cmake:
1:11 PM Changeset in webkit [149138] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Add definition of GlyphBufferGlyph for BlackBerry
https://bugs.webkit.org/show_bug.cgi?id=115183

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-25
Reviewed by Xan Lopez.

BlackBerry uses an unsigned int.

  • platform/graphics/GlyphBuffer.h:

(WebCore):

1:02 PM Changeset in webkit [149137] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Make scroll position adjustment work with pages with fixed position elements.
https://bugs.webkit.org/show_bug.cgi?id=115178

Patch by Iris Wu <shuwu@blackberry.com> on 2013-04-25
Reviewed by Rob Buis.

PR 308796

Currently the position WebPage::adjustDocumentScrollPosition adjusts is the top
left point of the viewport.
On the page with fixed position elements, we want it to adjust the position beneath
the fixed elements so it can be always visible.

The basic idea is:

  1. Detect if there are fixed position elements before going through ProximityDetector.
  2. If the fixed element exists, calculate its the size and the actual visible position

beneath it.

  1. Pass the position to ProximityDetector. Then according to the new position we get,

calculate the top left position of the viewport (final scroll position).

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::fixedElementSizeDelta):
(WebKit):

  • Api/WebPage.h:
  • Api/WebPageCompositor.cpp:

(BlackBerry::WebKit::WebPageCompositorPrivate::findFixedElementRect):
(WebKit):

  • Api/WebPageCompositor_p.h:

(WebPageCompositorPrivate):

1:00 PM Changeset in webkit [149136] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Stack guards are too conservative
https://bugs.webkit.org/show_bug.cgi?id=115147

Reviewed by Geoffrey Garen.

Reduce the limits and simplify the decision making.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::StackPolicy::StackPolicy):

12:56 PM Changeset in webkit [149135] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Enable balanced page group load deferrer behaviour.
https://bugs.webkit.org/show_bug.cgi?id=115189

Patch by Mike Lattanzio <mlattanzio@blackberry.com> on 2013-04-25
Reviewed by Rob Buis.

Prevent a possible deadlock by enabling balanced deferrers.
Internally reviewed by: Joe Mason
PR 329986

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init):

12:54 PM Changeset in webkit [149134] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

JSC: Fix interpreter misbehavior in builds with JIT disabled
https://bugs.webkit.org/show_bug.cgi?id=115190

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-04-25
Reviewed by Oliver Hunt.

Commit http://trac.webkit.org/changeset/147858 modified
some details on how JS stack traces are built. The method
"getLineNumberForCallFrame", renamed in that changeset to
"getBytecodeOffsetForCallFrame" is always returning `0' when
JIT is disabled

How to reproduce:

  • Build webkit with JIT disabled
  • Open MiniBrowser, for example, with http://google.com
  • In a debug build, WebProcess will hit the following ASSERT: Source/JavaScriptCore/bytecode/UnlinkedCodeBlock.cpp:279 ASSERT(low);
  • interpreter/Interpreter.cpp:

(JSC::getBytecodeOffsetForCallFrame):

12:50 PM Changeset in webkit [149133] by rniwa@webkit.org
  • 2 edits in trunk/Tools

Build fix. Forgot to merge args.

  • Scripts/webkitpy/tool/bot/irc_command.py:

(Hi.execute):

12:44 PM Changeset in webkit [149132] by rniwa@webkit.org
  • 2 edits in trunk/Tools

webkitbot should recognize its own nickname in greetings.
https://bugs.webkit.org/show_bug.cgi?id=115196

Reviewed by Andreas Kling.

Make webkitbot recognize other forms of its nick. Also be tolerant of spaces between the nick and !.

  • Scripts/webkitpy/tool/bot/irc_command.py:

(Hi.execute):

12:31 PM Changeset in webkit [149131] by Joseph Pecoraro
  • 21 edits
    2 adds
    2 deletes in trunk

ScriptExecutionContext log exception should include a column number
https://bugs.webkit.org/show_bug.cgi?id=114315

Reviewed by Oliver Hunt.

Source/WebCore:

Test: inspector/console/console-exception-stack-traces.html

  • bindings/js/ScriptCallStackFactory.h:
  • bindings/js/ScriptCallStackFactory.cpp:

(WebCore::createScriptCallStackFromException):
Generate a ScriptCallStack from an exception. Use the vm.exceptionStack
if available, and fallback to the exception object where needed.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::reportException):
Always include a non-empty call stack with exceptions.
Where not provided, fallback to the exception object.

  • dom/Document.h:
  • dom/Document.cpp:

(WebCore::Document::logExceptionToConsole):

  • dom/ScriptExecutionContext.h:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::PendingException::PendingException):
(ScriptExecutionContext::PendingException):
(WebCore::ScriptExecutionContext::reportException):

  • workers/DefaultSharedWorkerRepository.cpp:
  • workers/SharedWorkerContext.cpp:

(WebCore::SharedWorkerContext::logExceptionToConsole):

  • workers/SharedWorkerContext.h:
  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::logExceptionToConsole):

  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerExceptionTask::performTask):
Plumb columnNumber through as needed.

LayoutTests:

  • inspector/console/console-exception-stack-traces-expected.txt: Added.
  • inspector/console/console-exception-stack-traces.html: Added.

Verifies that exceptions have stack traces and match a console.trace stack.

  • http/tests/inspector-enabled/console-exception-while-no-inspector-expected.txt: Removed.
  • http/tests/inspector-enabled/console-exception-while-no-inspector.html: Removed.

We now save exception backtraces even if the inspector is not open.

  • fast/dom/javascript-url-exception-isolation-expected.txt
  • fast/events/remove-target-with-shadow-in-drag-expected.txt
  • fast/events/set-attribute-listener-window-onerror-crash-expected.txt
  • inspector-protocol/media-query-listener-exception-expected.txt:
  • inspector/console/console-uncaught-exception-expected.txt:
  • inspector/console/console-uncaught-exception-in-eval-expected.txt:

Update results that now include backtraces or different data. Most better, some worse.

12:02 PM WebKitIDL edited by Christophe Dumez
[Callback] only applies to parameters, not interfaces (diff)
11:59 AM Changeset in webkit [149130] by oliver@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Make checkSyntax take a VM instead of an ExecState

RS=Tim

11:57 AM WebKitIDL edited by Christophe Dumez
Update [Callback] extended attribute doc due to r149113 (diff)
11:50 AM Changeset in webkit [149129] by gman@chromium.org
  • 5 edits in trunk/Source/WebCore

Fix build files so WebGLDebugXXX extensions can be used if enabled.
https://bugs.webkit.org/show_bug.cgi?id=113976

Reviewed by Dean Jackson.

No new tests as no new functionality.

  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSWebGLRenderingContextCustom.cpp:
11:35 AM Changeset in webkit [149128] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

32 Bit: Crash due to RegExpTest nodes not setting result type to Boolean
https://bugs.webkit.org/show_bug.cgi?id=115188

Reviewed by Geoffrey Garen.

Changed the RegExpTest node to set the AbstractValue to boolean, since that
what it is.

  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

11:33 AM Changeset in webkit [149127] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

cloneChildNodes looks for deleteButtonController in each level of recursion
https://bugs.webkit.org/show_bug.cgi?id=115146

Reviewed by Andreas Kling.

Obtain the delete button controller upfront, and shallow copy descendents of each child
so that we don't look for the delete button controller inside cloneNode called on each child.

Performance Tests: DOM/CloneNodes.html

  • dom/ContainerNode.cpp:

(WebCore::cloneChildNodesAvoidingDeleteButon): Extracted.
(WebCore::ContainerNode::cloneChildNodes):

11:32 AM Changeset in webkit [149126] by rniwa@webkit.org
  • 8 edits in trunk

HTMLOptionsCollection's namedItem and name getter should return the first item
https://bugs.webkit.org/show_bug.cgi?id=115150

Reviewed by Andreas Kling.

Source/WebCore:

Following the resolution in http://lists.whatwg.org/pipermail/whatwg-whatwg.org/2012-December/038355.html,
the spefication has been updated to only return the first item when there are multiple items of the same name
in HTMLOptionsCollection; this new behavior matches that of Firefox and Opera (Presto).

Implement this new behavior to remove the custom binding code and use the fast path in namedItem and name
getter of HTMLOptionsCollection. (Obtaining all items for a given name is expensive!).

Tests: fast/dom/HTMLSelectElement/named-options.html

fast/dom/html-collections-named-getter.html

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore): Removed the custom bindings for name getter and namedItem.

  • html/HTMLOptionsCollection.idl:

LayoutTests:

Changed the expectations of the tests.

  • fast/dom/HTMLSelectElement/named-options-expected.txt:
  • fast/dom/HTMLSelectElement/script-tests/named-options.js:
  • fast/dom/html-collections-named-getter-expected.txt:
  • fast/dom/html-collections-named-getter.html:
11:31 AM Changeset in webkit [149125] by Joseph Pecoraro
  • 59 edits
    1 move
    3 adds
    1 delete in trunk

Web Inspector: ConsoleMessage should include line and column number where possible
https://bugs.webkit.org/show_bug.cgi?id=114929

Source/WebCore:

  • adds "m_column" to WebCore::ConsoleMessage
  • adds "column" to Console.ConsoleMessage in the inspector protocol
  • set the column number for console.* functions (Console.cpp)
  • set the column number for XSLT errors (XSLTProcessor)
  • plumb columnNumber everywhere else it is needed, set it to 0 and file bugs for all cases missing columnNumber that could provide it.

Reviewed by Timothy Hatcher.

Test: inspector/console/console-url-line-column.html

inspector/console/console-messages-stack-traces.html

  • inspector/ConsoleMessage.h:
  • inspector/ConsoleMessage.cpp:

(WebCore::ConsoleMessage::ConsoleMessage):
(WebCore::ConsoleMessage::autogenerateMetadata):
(WebCore::ConsoleMessage::addToFrontend):
(WebCore::ConsoleMessage::isEqual):
Add m_column and set it where appropriate.

  • inspector/Inspector.json:

Add column property to Console.ConsoleMessage.

  • page/Console.cpp:

(WebCore::internalAddMessage):
(WebCore::Console::profile):
Set columnNumber like lineNumber from the last stack frame.
(WebCore::Console::groupEnd):
Line and column are unused in this message type, set both to 0.

  • xml/XSLTProcessorLibxslt.cpp:

(WebCore::XSLTProcessor::parseErrorFunc):

  • xml/XSLTProcessorQt.cpp:

(WebCore::XSLTMessageHandler::handleMessage):
Add real column numbers, the XSLT handlers already had it available.

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • css/CSSParser.cpp:

(WebCore::CSSParser::logError):

  • dom/ScriptExecutionContext.h:
  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::addConsoleMessage):

  • dom/Document.cpp:

(WebCore::Document::logExceptionToConsole):
(WebCore::Document::addMessage):

  • dom/Document.h:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::addMessageToConsole):
(WebCore::InspectorConsoleAgent::stopTiming):
(WebCore::InspectorConsoleAgent::didFinishXHRLoading):
(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::addMessageToConsole):
(WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
(WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
(WebCore::InspectorInstrumentation::addProfileImpl):

  • inspector/InspectorInstrumentation.h:

(InspectorInstrumentation):

  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::addProfile):
(WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
(WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
(WebCore::InspectorProfilerAgent::start):
(WebCore::InspectorProfilerAgent::stop):

  • inspector/InspectorProfilerAgent.h:

(InspectorProfilerAgent):

  • loader/EmptyClients.h:

(WebCore::EmptyChromeClient::addMessageToConsole):

  • page/ChromeClient.h:

(WebCore::ChromeClient::addMessageToConsole):

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::logToConsole):

  • page/PageConsole.cpp:

(WebCore::PageConsole::addMessage):

  • page/PageConsole.h:
  • workers/DefaultSharedWorkerRepository.cpp:

(SharedWorkerProxy):
(WebCore::postExceptionTask):
(WebCore::SharedWorkerProxy::postExceptionToWorkerObject):
(WebCore::postConsoleMessageTask):
(WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):

  • workers/SharedWorkerContext.cpp:

(WebCore::SharedWorkerContext::logExceptionToConsole):

  • workers/WorkerContext.cpp:

(WebCore::WorkerContext::logExceptionToConsole):
(WebCore::WorkerContext::addConsoleMessage):
(WebCore::WorkerContext::addMessage):
(WebCore::WorkerContext::addMessageToWorkerConsole):

  • workers/WorkerContext.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerExceptionTask::create):
(WebCore::WorkerExceptionTask::WorkerExceptionTask):
(WebCore::WorkerExceptionTask::performTask):
(WorkerExceptionTask):
(WebCore::WorkerMessagingProxy::postExceptionToWorkerObject):
(WebCore::postConsoleMessageTask):
(WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):

  • workers/WorkerMessagingProxy.h:

(WorkerMessagingProxy):

  • workers/WorkerReportingProxy.h:

(WorkerReportingProxy):
Plumb columnNumber through where appropriate. File bugs where missing.

Source/WebKit/blackberry:

Reviewed by Timothy Hatcher.

  • Api/DumpRenderTreeClient.h:
  • Api/WebPageClient.h:
  • WebCoreSupport/ChromeClientBlackBerry.cpp:

(WebCore::ChromeClientBlackBerry::addMessageToConsole):

  • WebCoreSupport/ChromeClientBlackBerry.h:

(ChromeClientBlackBerry):

Source/WebKit/efl:

Reviewed by Timothy Hatcher.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::addMessageToConsole):

  • WebCoreSupport/ChromeClientEfl.h:

(ChromeClientEfl):

Source/WebKit/gtk:

Reviewed by Timothy Hatcher.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::addMessageToConsole):

  • WebCoreSupport/ChromeClientGtk.h:

(ChromeClient):

Source/WebKit/mac:

Reviewed by Timothy Hatcher.

  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::addMessageToConsole):

Source/WebKit/qt:

Reviewed by Timothy Hatcher.

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::addMessageToConsole):

  • WebCoreSupport/ChromeClientQt.h:

Source/WebKit/win:

Reviewed by Timothy Hatcher.

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::addMessageToConsole):

  • WebCoreSupport/WebChromeClient.h:

Source/WebKit/wince:

Reviewed by Timothy Hatcher.

  • WebCoreSupport/ChromeClientWinCE.cpp:

(WebKit::ChromeClientWinCE::addMessageToConsole):

  • WebCoreSupport/ChromeClientWinCE.h:

Source/WebKit2:

Reviewed by Timothy Hatcher.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::addMessageToConsole):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

LayoutTests:

Update a test that was outputting the url and line number of console
method calls, to output the column number as well. Added a test that
verifies that console API messages have stack traces if appropriate.

Reviewed by Timothy Hatcher.

  • inspector/console/console-url-and-line-expected.txt: Removed.
  • inspector/console/console-url-line-column-expected.txt: Added.
  • inspector/console/console-url-line-column.html: Renamed from LayoutTests/inspector/console/console-url-and-line.html.
  • inspector/console/console-messages-stack-traces-expected.txt: Added.
  • inspector/console/console-messages-stack-traces.html: Added.
11:29 AM Changeset in webkit [149124] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Get rid of return in void method
https://bugs.webkit.org/show_bug.cgi?id=115186

Patch by Konrad Piascik <kpiascik@blackberry.com> on 2013-04-25
Reviewed by Rob Buis.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::setForcedTextEncoding):

11:19 AM Changeset in webkit [149123] by allan.jensen@digia.com
  • 5 edits in trunk/Source

[Qt] Animated opacity does not trigger accelerated compositing
https://bugs.webkit.org/show_bug.cgi?id=115107

Reviewed by Simon Fraser.

Source/WebCore:

Add extra option to also trigger compositing on animated opacity.

  • page/ChromeClient.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForAnimation):

Source/WebKit/qt:

We should trigger compositing on animated opacity as it is always faster on Qt.

  • WebCoreSupport/ChromeClientQt.cpp:

VideoTrigger removed because we have already disabled AC for video in qwebsettings.

11:09 AM Changeset in webkit [149122] by Alexandru Chiculita
  • 1 edit in trunk/Tools/Scripts/webkitpy/common/config/contributors.json

Unreviewed. Adding myself to the reviwers list.

10:59 AM Changeset in webkit [149121] by beidson@apple.com
  • 3 edits in trunk/Source/WebKit2

Thread safety issues in WKCustomProtocol.
<rdar://problem/13247304> and https://bugs.webkit.org/show_bug.cgi?id=115185

Reviewed by Alexey Proskuryakov.

  • Shared/Network/CustomProtocols/CustomProtocolManager.h:
  • Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:

(WebKit::CustomProtocolManager::addCustomProtocol): Protect m_customProtocolMap with its mutex.
(WebKit::CustomProtocolManager::removeCustomProtocol): Ditto.
(WebKit::CustomProtocolManager::didFailWithError):
(WebKit::CustomProtocolManager::didLoadData):
(WebKit::CustomProtocolManager::didReceiveResponse):
(WebKit::CustomProtocolManager::didFinishLoading):
(WebKit::CustomProtocolManager::protocolForID): Protect m_customProtocolMap with its mutex, and return

a RetainPtr instead of a raw pointer.

10:48 AM Changeset in webkit [149120] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

Sec-WebSocket-Extensions header field must not appear more than once in an HTTP response.
https://bugs.webkit.org/show_bug.cgi?id=115128

Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-04-25
Reviewed by Alexey Proskuryakov.

Source/WebCore:

According to WebSocket specification Sec-WebSocket-Extensions header field
must not appear more than once in an HTTP response. It is ok if it appears
more than once in client request. Also add a check for invalid UTF-8
characters when parsing Sec-WebSocket-Extensions quoted string.

Test: http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header.html

  • Modules/websockets/WebSocketExtensionParser.cpp:

(WebCore::WebSocketExtensionParser::consumeQuotedString): Return false if there is
invalid character in the quoted string being parsed.

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::readHTTPHeaders): Check if Sec-WebSocket-Extensions
appears more than once in header response. Abort handshake if it does.

LayoutTests:

  • http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header-expected.txt: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header.html: Added.
  • http/tests/websocket/tests/hybi/handshake-fail-by-more-extensions-header_wsh.py: Added.
10:31 AM Changeset in webkit [149119] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebKit2

Further build fixes: correct two more misnames of WebProcessShim.dyld.

  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:

(WebKit::WebContentProcessMainDelegate::doPreInitializationWork):

  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
10:12 AM Changeset in webkit [149118] by Martin Robinson
  • 2 edits in trunk/Source/WebKit2

Make gobject-introspection warnings non-fatal
https://bugs.webkit.org/show_bug.cgi?id=115184

Reviewed by Carlos Garcia Campos.

  • GNUmakefile.am: Make it so that gobject-introspection errors do not fail the buld

until we get to a point where gobject-introspection gives consistent warnings.

9:46 AM Changeset in webkit [149117] by Carlos Garcia Campos
  • 14 edits
    4 adds in trunk/Source/WebKit2

[GTK] Add WebKitWebViewGroup to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=111265

Reviewed by Anders Carlsson.

In the current API the settings are always shared by all web
views, because they are always created on the default page
group. This makes impossible to have different settings on
different web views. Expose the page group in the API,
so that users can create web views on a group different than the
default one to have their own settings.

  • GNUmakefile.list.am: Add new files to compilation.
  • UIProcess/API/gtk/WebKitSettings.cpp:

(webkitSettingsGetPreferences): Helper private method to get the
WebPreferences wrapped by a WebKitSettings object.

  • UIProcess/API/gtk/WebKitSettingsPrivate.h:
  • UIProcess/API/gtk/WebKitWebContext.cpp:

(_WebKitWebContextPrivate): Add a default WebKitWebViewGroup.
(webkitWebContextCreatePageForWebView): Create the WebPageProxy
with the WebPageGroup of the given WebKitWebViewGroup.
(webkitWebContextGetDefaultWebViewGroup): Helper private method to
get the default WebKitWebViewGroup.

  • UIProcess/API/gtk/WebKitWebContextPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(_WebKitWebViewPrivate): Add a WebKitWebViewGroup in case the view
is created with a group.
(webkitWebViewUpdateSettings): Keep a reference of the group
settings to be able to disconnect the signals when the settings
object is replaced in the view group and connect to the signals
for the custom settings.
(webkitWebViewSettingsChanged): Disconnect the signals for the
previous settings and set the new settings.
(webkitWebViewDisconnectSettingsChangedSignalHandler): Disconnect
notify::settings signal of WebKitWebViewGroup.
(webkitWebViewConstructed): Pass the current WebKitWebViewGroup to
webkitWebContextCreatePageForWebView().
(webkitWebViewSetProperty): Add setter for group property.
(webkitWebViewGetProperty): Add getter for group property.
(webkitWebViewDispose): Call
webkitWebViewDisconnectSettingsChangedSignalHandler().
(webkit_web_view_class_init): Add WebKitWebView:group property.
(webkitWebViewHandleAuthenticationChallenge): Use
webkit_web_view_get_settings().
(webkit_web_view_new_with_group): Create a new web view with the
given WebKitWebViewGroup.
(webkit_web_view_get_group): Return the current WebKitWebViewGroup
or the default one if the view was not created with
webkit_web_view_new_with_group().
(webkit_web_view_set_settings): Set the settings of the current
WebKitWebViewGroup.
(webkit_web_view_get_settings): Get the settings of the current
WebKitWebViewGroup.
(webkit_web_view_set_zoom_level): Use
webkit_web_view_get_settings().
(webkit_web_view_get_zoom_level): Ditto.

  • UIProcess/API/gtk/WebKitWebView.h:
  • UIProcess/API/gtk/WebKitWebViewGroup.cpp: Added.

(_WebKitWebViewGroupPrivate):
(webkitWebViewGroupSetProperty):
(webkitWebViewGroupGetProperty):
(webkitWebViewGroupConstructed):
(webkit_web_view_group_class_init):
(webkitWebViewGroupAttachSettingsToPageGroup): Set the
WebPreferences of the current WebKitSettings to the WebPageGroup.
(webkitWebViewGroupCreate): Create a new WebKitWebViewGroup for
the given WebPageGroup.
(webkitWebViewGroupGetPageGroup): Helper private method to get the
WebPageGroup wrapped by the WebKitWebViewGroup.
(webkit_web_view_group_new): Create a new WebKitWebViewGroup.
(webkit_web_view_group_get_name): Return the name of a
WebKitWebViewGroup.
(webkit_web_view_group_get_settings): Get the settings of a
WebKitWebViewGroup.
(webkit_web_view_group_set_settings): Set new settings of a
WebKitWebViewGroup.

  • UIProcess/API/gtk/WebKitWebViewGroup.h: Added.

(_WebKitWebViewGroup):
(_WebKitWebViewGroupClass):

  • UIProcess/API/gtk/WebKitWebViewGroupPrivate.h: Added.
  • UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add

WebKitWebViewGroup section.

  • UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
  • UIProcess/API/gtk/docs/webkit2gtk.types: Add

webkit_web_view_group_get_type.

  • UIProcess/API/gtk/tests/GNUmakefile.am: Add new files to

compilation.

  • UIProcess/API/gtk/tests/TestWebKitWebView.cpp:

(testWebViewSettings): We can't watch settings in the default view
group anymore, because they are not released with the web view but
with the web context that is freed after the Test destructor.

  • UIProcess/API/gtk/tests/TestWebKitWebViewGroup.cpp: Added.

(testWebViewGroupDefault):
(testWebViewGroupNewGroup):
(testWebViewNewWithGroup):
(testWebViewGroupSettings):
(beforeAll):
(afterAll):

  • UIProcess/API/gtk/webkit2.h: Include WebKitWebViewGroup.h.
9:39 AM Changeset in webkit [149116] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[Windows] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=115170

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-04-25
Reviewed by Filip Pizlo.

Forward declare function, instead of including intrin.h.

  • wtf/Atomics.h:
9:32 AM Changeset in webkit [149115] by rakuco@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r148758): Remove WTFLogAlways call from IconLoader.
https://bugs.webkit.org/show_bug.cgi?id=115182

Reviewed by Dan Bernstein.

The call added in r148758 was apparently a leftover from some debugging
session, and it makes the Interactive/window-resize.html performance
test randomly fail on Qt and EFL due to WTFLogAlways writing to stderr.

  • loader/icon/IconLoader.cpp:

(WebCore::IconLoader::notifyFinished):

9:18 AM Changeset in webkit [149114] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r137994): Random crashes occur with SH4 JSC.
https://bugs.webkit.org/show_bug.cgi?id=115167.

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-04-25
Reviewed by Oliver Hunt.

Since r137994, uncommited pages could be inside the area of memory in
parameter of the cacheFlush function. That's why we have to flush each
page separately to avoid a fail of the whole flush, if an uncommited page
is in the area.

This patch is very similar to changeset 145194 made for ARMv7 architecture,
see https://bugs.webkit.org/show_bug.cgi?id=111441 for further information.

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::cacheFlush):

8:55 AM Changeset in webkit [149113] by Christophe Dumez
  • 32 edits in trunk/Source/WebCore

Add support for Web IDL callback interfaces to the bindings generator
https://bugs.webkit.org/show_bug.cgi?id=115179

Reviewed by Kentaro Hara.

Add support in the bindings generator for Web IDL callback interfaces:
http://dev.w3.org/2006/webapi/WebIDL/#dfn-callback-interface

Drop support for the WebKit-specific [Callback] extended attributes
on Web IDL interfaces and update existing IDL files to use proper
callback interfaces instead.

No new tests, no behavior change.

  • Modules/filesystem/EntriesCallback.idl:
  • Modules/filesystem/EntryCallback.idl:
  • Modules/filesystem/ErrorCallback.idl:
  • Modules/filesystem/FileCallback.idl:
  • Modules/filesystem/FileSystemCallback.idl:
  • Modules/filesystem/FileWriterCallback.idl:
  • Modules/filesystem/MetadataCallback.idl:
  • Modules/geolocation/PositionCallback.idl:
  • Modules/geolocation/PositionErrorCallback.idl:
  • Modules/mediastream/NavigatorUserMediaErrorCallback.idl:
  • Modules/mediastream/NavigatorUserMediaSuccessCallback.idl:
  • Modules/mediastream/RTCErrorCallback.idl:
  • Modules/mediastream/RTCSessionDescriptionCallback.idl:
  • Modules/mediastream/RTCStatsCallback.idl:
  • Modules/notifications/NotificationPermissionCallback.idl:
  • Modules/quota/StorageErrorCallback.idl:
  • Modules/quota/StorageQuotaCallback.idl:
  • Modules/quota/StorageUsageCallback.idl:
  • Modules/webaudio/AudioBufferCallback.idl:
  • Modules/webdatabase/DatabaseCallback.idl:
  • Modules/webdatabase/SQLStatementCallback.idl:
  • Modules/webdatabase/SQLStatementErrorCallback.idl:
  • Modules/webdatabase/SQLTransactionCallback.idl:
  • Modules/webdatabase/SQLTransactionErrorCallback.idl:
  • Modules/webdatabase/SQLTransactionSyncCallback.idl:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateInterface):

  • bindings/scripts/IDLParser.pm:

(parseCallbackRestOrInterface):

  • bindings/scripts/test/TestCallback.idl:
  • dom/RequestAnimationFrameCallback.idl:
  • dom/StringCallback.idl:
  • html/VoidCallback.idl:
8:17 AM Changeset in webkit [149112] by mikhail.pozdnyakov@intel.com
  • 2 edits in trunk/Source/WTF

Use std::move in AtomicString
https://bugs.webkit.org/show_bug.cgi?id=115102

Reviewed by Anders Carlsson.

Use std::move in AtomicString instead of direct casting to rvalue references.

  • wtf/text/AtomicString.h:

(AtomicString):
(WTF::AtomicString::AtomicString):
(WTF::AtomicString::operator=):

7:52 AM Changeset in webkit [149111] by commit-queue@webkit.org
  • 8 edits
    1 copy in trunk

[GStreamer] Add audio/speex MIME type as supported
https://bugs.webkit.org/show_bug.cgi?id=115032

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2013-04-25
Reviewed by Philippe Normand.

Source/WebCore:

GStreamer has support for the Speex codec (http://www.speex.org).
Speex streams may be embedded in a Ogg container, or standalone.
The case of the Ogg container is already covered by the "*/ogg"
MIME types declared as supported by the GStreamer media playing
code, but for standalone streams to work, "audio/speex" has to
be added.

With this, and the needed GStreamer plugin installed, the GTK+
launcher is able to correctly play Speex streams served with
"Content-type: audio/speex".

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

LayoutTests:

Speex (http://www.speex.org) streams can be embedded into Ogg
Ogg containers, so add a check for it in the test case.

  • media/media-can-play-ogg-expected.txt:
  • media/media-can-play-ogg.html:
  • platform/blackberry/media/media-can-play-ogg-expected.txt:
  • platform/mac/media/media-can-play-ogg-expected.txt:
  • platform/qt-linux/media/media-can-play-ogg-expected.txt:
  • platform/win/media/media-can-play-ogg-expected.txt:
7:33 AM Changeset in webkit [149110] by akling@apple.com
  • 9 edits in trunk/Source/WebCore

Add FINAL decorators to the InlineBox class hierarchy.
<http://webkit.org/b/115177>

Reviewed by Antti Koivisto.

From Blink r148628 by <cevans@chromium.org>:

FINAL is a macro in wtf/Compiler.h that does the correct thing if the compiler does not support "final")
The approach used is as simple as possible whilst being thorough.
So, leaf classes have FINAL applied to the whole class whereas intermediary classes have FINAL applied to relevant methods.

FINAL allows a compiler to devirtualize call sites and turn them into direct calls. As you might expect, this is perf positive:
(clang on Linux):

  • line_layout.html goes from 120 runs/s -> 123 runs/2, +2.5%
  • html5-full-render.html goes from 3176ms -> 3162ms, +0.4%

I have confidence that the former result is statistically significant (as the numbers are very very stable) but not the latter.

  • rendering/EllipsisBox.h:
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.h:
  • rendering/RootInlineBox.h:
  • rendering/TrailingFloatsRootInlineBox.h:
  • rendering/svg/SVGInlineFlowBox.h:
  • rendering/svg/SVGInlineTextBox.h:
  • rendering/svg/SVGRootInlineBox.h:
7:19 AM Changeset in webkit [149109] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Tools/gtk/install-dependencies added ragel dependency
https://bugs.webkit.org/show_bug.cgi?id=115163

Patch by Xavier Castano <xcastanho@igalia.com> on 2013-04-25
Reviewed by Xan Lopez.

The install-dependencies script was missing a dependency on ragel
which is expected when building HarfBuzz.

  • gtk/install-dependencies: Added a dependency on ragel for both

apt and yum.

7:05 AM Changeset in webkit [149108] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Remove pango from optional jhbuild dependencies
https://bugs.webkit.org/show_bug.cgi?id=115162

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2013-04-25
Reviewed by Martin Robinson.

Pango is not needed since revision r148293 that lowers the pango
dependency to 1.30, which is available in most distributions.

  • gtk/jhbuild-optional.modules: Removes description of pango module.
6:46 AM Changeset in webkit [149107] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebKit2

Unreviewed build fix: Fix the name of DyldInterpose.h in
SecItemShimLibrary.mm, fix the name of WebProcessShim.dyld in
WebContentServiceEntryPoint.mm, and stop linking against libWTF.a
directly (which means removing ASSERTs from
CookieStorageShimLibrary.cpp).

  • Shared/mac/CookieStorageShimLibrary.cpp:

(WebKit::shimCFHTTPCookieStorageCopyRequestHeaderFieldsForURL):
(WebKit::WebKitCookieStorageShimInitialize):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:

(WebContentServiceInitializer):

  • WebProcess/mac/SecItemShimLibrary.mm:
6:43 AM Changeset in webkit [149106] by akling@apple.com
  • 4 edits
    4 adds in trunk

CSS parser: Add error recovery while parsing @-webkit-keyframes key values.
<http://webkit.org/b/115175>

Source/WebCore:

From Blink r148714 by <apavlov@chromium.org>:

If not a percentage, "from", or "to" value is used in a key list, the rule is erroneous,
and due to the absense of recovery, the parser skips the following, valid CSS rule.

On a related note, keyframes, whose selectors contain invalid keys, should be discarded
altogether, according to <http://www.w3.org/TR/css3-animations/#keyframes>

Tests: animations/keyframes-invalid-keys.html

fast/css/webkit-keyframes-errors.html

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::rewriteSpecifiers):

LayoutTests:

From Blink r148714 by <apavlov@chromium.org>.

  • animations/keyframes-invalid-keys-expected.txt: Added.
  • animations/keyframes-invalid-keys.html: Added.
  • fast/css/webkit-keyframes-errors-expected.html: Added.
  • fast/css/webkit-keyframes-errors.html: Added.
6:23 AM Changeset in webkit [149105] by Antti Koivisto
  • 7 edits in trunk/Source/WebCore

REGRESSION (r147797): Animations slideshows of images on www.thesuperficial.com are slow
https://bugs.webkit.org/show_bug.cgi?id=115172

Reviewed by Andreas Kling.

On this page ads dynamically loaded to subframes on slideshow navigation switch us to state where we throttle layer flushes.

Fix by ignoring any subframe-originated loads when determining throttling.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadProgressingStatusChanged):

  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::isMainLoadProgressing):

Rename, ignore subframe originated loads. Subframe loads that are initiated during the main load still count.

  • loader/ProgressTracker.h:

(ProgressTracker):

  • page/FrameView.cpp:

(WebCore::FrameView::updateLayerFlushThrottlingInAllFrames):

  • page/FrameView.h:

(FrameView):

  • rendering/RenderLayerBacking.cpp:

(WebCore::computeTileCoverage):

6:10 AM Changeset in webkit [149104] by kadam@inf.u-szeged.hu
  • 2 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Skip some failing tests after r148996.

  • platform/qt/TestExpectations:
6:04 AM Changeset in webkit [149103] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove Chromium-specific cases from FeatureList.pm
https://bugs.webkit.org/show_bug.cgi?id=115169

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-25
Reviewed by Andreas Kling.

  • Scripts/webkitperl/FeatureList.pm:
5:56 AM Changeset in webkit [149102] by akling@apple.com
  • 4 edits
    2 adds in trunk

SVG: Fix viewBox animations on shapes with non-scaling-stroke.
<http://webkit.org/b/115173>

Source/WebCore:

From Blink r149058 by <pdr@chromium.org>:

Previously hasAttribute() to determine if a viewBox was set in the transform
code for non-scaling-strokes. hasAttribute() should not be used in this case,
as it will return false if the attribute is not set but the value is animating.

This patch switches to checking if the viewBox is empty instead of checking for
the presence of the attribute.

Test: svg/stroke/animated-non-scaling-stroke.html

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::localCoordinateSpaceTransform):

  • svg/SVGSVGElement.h:

(WebCore::SVGSVGElement::hasEmptyViewBox):

LayoutTests:

From Blink r149058 by <pdr@chromium.org>.

  • svg/stroke/animated-non-scaling-stroke-expected.html: Added.
  • svg/stroke/animated-non-scaling-stroke.html: Added.
5:32 AM Changeset in webkit [149101] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Remove isPluginElement hack in Document::setFocusedNode()
<http://webkit.org/b/115171>

From Blink r148800 by <tkent@chromium.org>:

This hack is no longer necessary because r147591 made isFocusable for plugin
elements work correctly.

  • dom/Document.cpp:

(WebCore::Document::setFocusedNode):

5:13 AM Changeset in webkit [149100] by kadam@inf.u-szeged.hu
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskip now passing tests.

  • platform/qt-5.0-wk1/TestExpectations:
  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations:
3:49 AM Changeset in webkit [149099] by kadam@inf.u-szeged.hu
  • 23 edits
    22 copies
    8 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Organize expected files after r149095.

  • platform/qt-5.0-wk1/editing/deleting/delete-by-word-002-expected.txt: Copied from LayoutTests/platform/qt/editing/deleting/delete-by-word-002-expected.txt.
  • platform/qt-5.0-wk1/editing/deleting/delete-cell-contents-expected.txt: Copied from LayoutTests/platform/qt/editing/deleting/delete-cell-contents-expected.txt.
  • platform/qt-5.0-wk1/editing/execCommand/button-expected.txt: Copied from LayoutTests/platform/qt/editing/execCommand/button-expected.txt.
  • platform/qt-5.0-wk1/editing/execCommand/createLink-expected.txt: Copied from LayoutTests/platform/qt/editing/execCommand/createLink-expected.txt.
  • platform/qt-5.0-wk1/editing/execCommand/indent-pre-expected.txt: Copied from LayoutTests/platform/qt/editing/execCommand/indent-pre-expected.txt.
  • platform/qt-5.0-wk1/editing/execCommand/unlink-expected.txt: Copied from LayoutTests/platform/qt/editing/execCommand/unlink-expected.txt.
  • platform/qt-5.0-wk1/editing/input/emacs-ctrl-o-expected.txt: Copied from LayoutTests/platform/qt/editing/input/emacs-ctrl-o-expected.txt.
  • platform/qt-5.0-wk1/editing/inserting/insert-before-link-1-expected.txt: Copied from LayoutTests/platform/qt/editing/inserting/insert-before-link-1-expected.txt.
  • platform/qt-5.0-wk1/editing/pasteboard/display-block-on-spans-expected.txt: Copied from LayoutTests/platform/qt/editing/pasteboard/display-block-on-spans-expected.txt.
  • platform/qt-5.0-wk1/editing/pasteboard/emacs-cntl-y-001-expected.txt: Copied from LayoutTests/platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.txt.
  • platform/qt-5.0-wk1/editing/pasteboard/merge-end-list-2-expected.txt: Copied from LayoutTests/platform/qt/editing/pasteboard/merge-end-list-2-expected.txt.
  • platform/qt-5.0-wk1/editing/pasteboard/merge-end-table-2-expected.txt: Copied from LayoutTests/platform/qt/editing/pasteboard/merge-end-table-2-expected.txt.
  • platform/qt-5.0-wk1/editing/pasteboard/page-zoom-expected.txt: Copied from LayoutTests/platform/qt/editing/pasteboard/page-zoom-expected.txt.
  • platform/qt-5.0-wk1/editing/selection/extend-selection-word-expected.txt: Copied from LayoutTests/platform/qt/editing/selection/extend-selection-word-expected.txt.
  • platform/qt-5.0-wk1/editing/style/apply-through-end-of-document-expected.txt: Copied from LayoutTests/platform/qt/editing/style/apply-through-end-of-document-expected.txt.
  • platform/qt-5.0-wk1/editing/style/remove-underline-across-paragraph-expected.txt: Copied from LayoutTests/platform/qt/editing/style/remove-underline-across-paragraph-expected.txt.
  • platform/qt-5.0-wk1/editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Copied from LayoutTests/platform/qt/editing/style/remove-underline-across-paragraph-in-bold-expected.txt.
  • platform/qt-5.0-wk1/editing/style/remove-underline-expected.txt: Copied from LayoutTests/platform/qt/editing/style/remove-underline-expected.txt.
  • platform/qt-5.0-wk1/editing/style/remove-underline-from-stylesheet-expected.txt: Copied from LayoutTests/platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt.
  • platform/qt-5.0-wk1/editing/style/remove-underline-in-bold-expected.txt: Copied from LayoutTests/platform/qt/editing/style/remove-underline-in-bold-expected.txt.
  • platform/qt-5.0-wk1/editing/style/unbold-in-bold-expected.txt: Copied from LayoutTests/platform/qt/editing/style/unbold-in-bold-expected.txt.
  • platform/qt-5.0-wk1/editing/undo/replace-text-in-node-preserving-markers-crash-expected.txt: Copied from LayoutTests/platform/qt/editing/undo/replace-text-in-node-preserving-markers-crash-expected.txt.
  • platform/qt/editing/deleting/delete-by-word-002-expected.txt:
  • platform/qt/editing/deleting/delete-cell-contents-expected.txt:
  • platform/qt/editing/execCommand/button-expected.txt:
  • platform/qt/editing/execCommand/createLink-expected.txt:
  • platform/qt/editing/execCommand/indent-pre-expected.txt:
  • platform/qt/editing/execCommand/unlink-expected.txt:
  • platform/qt/editing/input/emacs-ctrl-o-expected.txt:
  • platform/qt/editing/inserting/insert-before-link-1-expected.txt:
  • platform/qt/editing/pasteboard/display-block-on-spans-expected.txt:
  • platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-list-2-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-table-2-expected.txt:
  • platform/qt/editing/pasteboard/page-zoom-expected.txt:
  • platform/qt/editing/selection/extend-selection-word-expected.txt:
  • platform/qt/editing/style/apply-through-end-of-document-expected.txt:
  • platform/qt/editing/style/remove-underline-across-paragraph-expected.txt:
  • platform/qt/editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
  • platform/qt/editing/style/remove-underline-expected.txt:
  • platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt:
  • platform/qt/editing/style/remove-underline-in-bold-expected.txt:
  • platform/qt/editing/style/unbold-in-bold-expected.txt:
  • platform/qt/editing/undo/replace-text-in-node-preserving-markers-crash-expected.txt:
2:51 AM Changeset in webkit [149098] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

EventSource: Synchronous loader callback not handled properly
https://bugs.webkit.org/show_bug.cgi?id=115104

Source/WebCore:

When attempting a cross-origin request towards a non-HTTP URL, an early verification
of the protocol scheme will cause didFailAccessControlCheck to be called synchronously
before the loader has even finished being created. This special case was not handled
properly, since we tried to cancel a non-existing loader, which resulted in a crash.
In addition to checking whether a request is in flight before trying to cancel it,
this change also schedules the initial creation of the loader to happen asynchronously
when an EventSource is constructed, so that a script can register for the error event
before it is dispatched (as a result of passing a non-HTTP URL to the constructor).

Patch by Per-Erik Brodin <per-erik.brodin@ericsson.com> on 2013-04-25
Reviewed by Alexey Proskuryakov.

Test: http/tests/eventsource/eventsource-cors-non-http.html

  • page/EventSource.cpp:

(WebCore::EventSource::EventSource):
(WebCore::EventSource::create):
(WebCore::EventSource::scheduleInitialConnect):
(WebCore):
(WebCore::EventSource::scheduleReconnect):
(WebCore::EventSource::connectTimerFired):
(WebCore::EventSource::close):
(WebCore::EventSource::abortConnectionAttempt):

  • page/EventSource.h:

(EventSource):

LayoutTests:

Patch by Per-Erik Brodin <per-erik.brodin@ericsson.com> on 2013-04-25
Reviewed by Alexey Proskuryakov.

  • http/tests/eventsource/eventsource-cors-non-http-expected.txt: Added.
  • http/tests/eventsource/eventsource-cors-non-http.html: Added.
2:43 AM Changeset in webkit [149097] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

Unreviewed WinCE build fix after r148888.

  • wtf/Atomics.h: WinCE version of intrin.h is called cmnintrin.h.
2:42 AM Changeset in webkit [149096] by Patrick Gansterer
  • 2 edits in trunk/Source/WebCore

Unreviewed WinCE build fix after r148545.

  • page/wince/FrameWinCE.cpp:
1:01 AM Changeset in webkit [149095] by kadam@inf.u-szeged.hu
  • 7 edits
    21 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Added platform specific expected files after r148987.

  • platform/qt/editing/deleting/delete-by-word-002-expected.txt: Added.
  • platform/qt/editing/deleting/delete-cell-contents-expected.txt: Added.
  • platform/qt/editing/execCommand/button-expected.txt: Added.
  • platform/qt/editing/execCommand/createLink-expected.txt: Added.
  • platform/qt/editing/execCommand/indent-pre-expected.txt: Added.
  • platform/qt/editing/execCommand/unlink-expected.txt: Added.
  • platform/qt/editing/input/emacs-ctrl-o-expected.png:
  • platform/qt/editing/input/emacs-ctrl-o-expected.txt:
  • platform/qt/editing/inserting/insert-before-link-1-expected.txt: Added.
  • platform/qt/editing/pasteboard/display-block-on-spans-expected.txt: Added.
  • platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.png:
  • platform/qt/editing/pasteboard/emacs-cntl-y-001-expected.txt:
  • platform/qt/editing/pasteboard/merge-end-list-2-expected.txt: Added.
  • platform/qt/editing/pasteboard/merge-end-table-2-expected.txt: Added.
  • platform/qt/editing/pasteboard/page-zoom-expected.txt: Added.
  • platform/qt/editing/selection/extend-selection-word-expected.txt: Added.
  • platform/qt/editing/selection/selection-extend-should-not-move-across-caret-on-mac-expected.txt: Added.
  • platform/qt/editing/style/apply-through-end-of-document-expected.txt: Added.
  • platform/qt/editing/style/make-text-writing-direction-inline-win-expected.txt: Added.
  • platform/qt/editing/style/remove-underline-across-paragraph-expected.txt: Added.
  • platform/qt/editing/style/remove-underline-across-paragraph-in-bold-expected.txt: Added.
  • platform/qt/editing/style/remove-underline-expected.txt: Added.
  • platform/qt/editing/style/remove-underline-from-stylesheet-expected.txt: Added.
  • platform/qt/editing/style/remove-underline-in-bold-expected.txt: Added.
  • platform/qt/editing/style/unbold-in-bold-expected.png:
  • platform/qt/editing/style/unbold-in-bold-expected.txt:
  • platform/qt/editing/undo/replace-text-in-node-preserving-markers-crash-expected.txt: Added.
12:50 AM Changeset in webkit [149094] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

Unreviewed, rolling out r149032.
http://trac.webkit.org/changeset/149032
https://bugs.webkit.org/show_bug.cgi?id=115151

EFL WK1 API test has been broken after r149032 (Requested by
gyuyoung on #webkit).

  • tests/test_ewk_setting.cpp:

(TEST_F):

Apr 24, 2013:

11:42 PM Changeset in webkit [149093] by tkent@chromium.org
  • 5 edits in trunk

Back references don't work in pattern attribute
https://bugs.webkit.org/show_bug.cgi?id=105875

Reviewed by Geoffrey Garen.

Source/WebCore:

This imports a part of Blink r148951.

Tests: Update fast/forms/ValidityState-patternMismatch.html

  • html/BaseTextInputType.cpp:

(WebCore::BaseTextInputType::patternMismatch):
Don't use capturing parentheses. They affected back references in
pattern attribute values.

LayoutTests:

  • fast/forms/ValidityState-patternMismatch-expected.txt:
  • fast/forms/ValidityState-patternMismatch.html:
10:41 PM Changeset in webkit [149092] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove checking chromium from run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=115139

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-24
Reviewed by Benjamin Poulain.

  • Scripts/run-webkit-tests:

(useNewRunWebKitTests):

10:30 PM Changeset in webkit [149091] by timothy_horton@apple.com
  • 5 edits in trunk/Source

PDFPlugin: Cursor should become an i-beam when over selectable text
https://bugs.webkit.org/show_bug.cgi?id=115018
<rdar://problem/12645012>

Reviewed by Alexey Proskuryakov.

  • WebProcess/Plugins/PDF/PDFPlugin.h:

Add updateCursor(), the UpdateCursorMode and HitTestResult enums, and
storage for the last PDF hit test result.

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::updateCursor):
Hit test the PDF. If there is a word under the cursor, use the I-beam cursor,
otherwise, use the default pointer cursor. This approximates PDFKit's behavior,
though does not match it precisely in the case of annotations.
Only send the cursor update to the UIProcess if it is a change, or if
we're explicitly asked to update.
(WebKit::PDFPlugin::handleMouseEvent):
If we're processing a mouse moved event, update the cursor if needed.
(WebKit::PDFPlugin::handleMouseEnterEvent):
If the cursor just moved over the PDFPlugin, force-update the cursor,
even if it matches the previously-set cursor (because something else
likely updated the cursor while it was not over the PDFPlugin).

  • WebCore.exp.in: Export the I-beam and arrow cursors.
9:56 PM Changeset in webkit [149090] by roger_fong@apple.com
  • 1 edit
    559 adds
    297 deletes in trunk/LayoutTests

Roll out AppleWin re-baselines from r149088.

7:59 PM Changeset in webkit [149089] by mark.lam@apple.com
  • 11 edits in trunk/Source/JavaScriptCore

Add watchdog timer polling for the DFG.
https://bugs.webkit.org/show_bug.cgi?id=115134.

Reviewed by Geoffrey Garen.

The strategy is to add a speculation check to the DFG generated code to
test if the watchdog timer has fired or not. If the watchdog timer has
fired, the generated code will do an OSR exit to the baseline JIT, and
let it handle servicing the watchdog timer.

If the watchdog is not enabled, this speculation check will not be
emitted.

  • API/tests/testapi.c:

(currentCPUTime_callAsFunction):
(extendTerminateCallback):
(main):

  • removed try/catch statements so that we can test the watchdog on the DFG.
  • added JS bindings to a native currentCPUTime() function so that the timeout tests can be more accurate.
  • also shortened the time values so that the tests can complete sooner.
  • bytecode/ExitKind.h:
  • dfg/DFGAbstractState.cpp:

(JSC::DFG::AbstractState::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNodeType.h:
  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • runtime/Watchdog.cpp:

(JSC::Watchdog::setTimeLimit):

7:44 PM Changeset in webkit [149088] by roger_fong@apple.com
  • 103 edits
    2046 adds
    1760 deletes in trunk/LayoutTests

Unreviewed optimize-baselines for mac and win.

7:09 PM Changeset in webkit [149087] by Simon Fraser
  • 17 edits in trunk/Tools

Pixel tests in SVG are all broken in WK2
https://bugs.webkit.org/show_bug.cgi?id=114218

Reviewed by Darin Adler.

Window snapshots in WebKitTestRunner on Mac are window-sized
(800x600), which is wrong for the W3C SVG tests that require a
480x360 snapshot.

Fix by resizing the window, as well as the web view in
PlatformWebView::resizeTo() so that window snapshots are correctly
sized.

Also do some drive-by cleanup of the window size constants in both
DRT and WTR to remove magic numbers, and make the code more similar.

  • DumpRenderTree/TestRunner.cpp:

(TestRunner::setShouldPaintBrokenImage):

  • DumpRenderTree/TestRunner.h:
  • DumpRenderTree/efl/DumpRenderTree.cpp:
  • DumpRenderTree/gtk/DumpRenderTree.cpp:

(webInspectorShowWindow):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):
(sizeWebViewForCurrentTest):

  • DumpRenderTree/mac/DumpRenderTreeMac.h:
  • DumpRenderTree/mac/PixelDumpSupportMac.mm:

(createPagedBitmapContext):

  • DumpRenderTree/qt/DumpRenderTreeQt.cpp:

(DumpRenderTree::DumpRenderTree):
(DumpRenderTree::open):

  • DumpRenderTree/qt/TestRunnerQt.cpp:
  • DumpRenderTree/qt/TestRunnerQt.h:
  • DumpRenderTree/win/DumpRenderTree.cpp:

(sizeWebViewForCurrentTest):

  • DumpRenderTree/wx/DumpRenderTreeWx.cpp:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetStateToConsistentValues):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::sizeWebViewForCurrentTest):

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::resizeTo):

6:32 PM Changeset in webkit [149086] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Page Overlays shouldn't waste time flushing layers if we're not going to use it
https://bugs.webkit.org/show_bug.cgi?id=115145

Reviewed by Simon Fraser.

Don't flush the page overlay layer when it's installed - it starts out
with paintContents=false, so we don't really need a CALayer yet. We'll
flush later if need be.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::didInstallPageOverlay):

6:32 PM Changeset in webkit [149085] by fpizlo@apple.com
  • 5 edits
    1 add in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: AbstractValue methods that deal with watchpoints should have access to Graph, so that in debug mode, Graph can track the history of watchpoint states and detect races
https://bugs.webkit.org/show_bug.cgi?id=115084

Reviewed by Geoffrey Garen.

The idea is that as part of https://bugs.webkit.org/show_bug.cgi?id=115083, I'll have
Graph record the initial state of a watchpoint at the time that we decide to take
advantage of it; then I will use this to disable any watchpoint-related assertions
in debug mode. Note that this "watchpoint cache" will only be maintained in debug
mode, so there will be no release performance implications. But to do this, I need to
ensure that all of the places that reason about watchpoints have access to Graph.
For example, I'll want AbstractValue::setFuturePossibleStructure to record the state
of the watchpoint in Graph so that subsequent assertions can check if the watchpoint's
state had changed since that decision was made.

(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::executeEffects):
(JSC::DFG::AbstractState::mergeStateAtTail):

  • dfg/DFGAbstractState.h:

(JSC::DFG::AbstractState::trySetConstant):

  • dfg/DFGAbstractValue.cpp: Added.

(DFG):
(JSC::DFG::AbstractValue::setMostSpecific):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::setFuturePossibleStructure):
(JSC::DFG::AbstractValue::filterFuturePossibleStructure):
(JSC::DFG::AbstractValue::dump):

  • dfg/DFGAbstractValue.h:

(DFG):
(AbstractValue):
(JSC::DFG::AbstractValue::setType):
(JSC::DFG::AbstractValue::filterByValue):

6:27 PM Changeset in webkit [149084] by Simon Fraser
  • 3 edits
    2 adds in trunk

Garbage at the top of http://www.technologyreview.com after scrolling
https://bugs.webkit.org/show_bug.cgi?id=114825

Source/WebCore:

Reviewed by Tim Horton.

Garbage pixels are caused by GraphicsLayerCA setting a layer to be opaque,
but then not painting anything into it. On this page, the element is
toggled to be visibility:hidden on scrolling, but RenderLayer::backgroundIsKnownToBeOpaqueInRect()
failed to consider that as something that can cause backgrounds not to be opaque.

For the bug to happen, some subtle interactions with r142012 come into play
for the layer to remain visible, hence the slightly complex testcase.

Test: compositing/contents-opaque/visibility-hidden.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

Reviewed by Tim Horton.

Test that sets visibility:hidden on an element with some complex
configuration of layer children, and dumps the layer tree to check
that the contents are not marked as opaque.

  • compositing/contents-opaque/visibility-hidden-expected.txt: Added.
  • compositing/contents-opaque/visibility-hidden.html: Added.
6:27 PM Changeset in webkit [149083] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Dump layer opaqueness in the Compositing log output
https://bugs.webkit.org/show_bug.cgi?id=115132

Reviewed by Tim Horton.

It's useful to see whether we consider layers to be opaque in the Compositing
log channel output, so dump it.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::logLayerInfo):

6:26 PM Changeset in webkit [149082] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Special thunks for math functions should work on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=115144

Reviewed by Gavin Barraclough and Oliver Hunt.

The only hard bit here was ensuring that we implemented the very special
"cheap C call" convention on ARMv7.

  • assembler/AbstractMacroAssembler.h:

(JSC::isARMv7s):
(JSC):
(JSC::isX86):

  • dfg/DFGCommon.h:
  • jit/SpecializedThunkJIT.h:

(SpecializedThunkJIT):
(JSC::SpecializedThunkJIT::callDoubleToDoublePreservingReturn):

  • jit/ThunkGenerators.cpp:

(JSC::floorThunkGenerator):
(JSC::ceilThunkGenerator):
(JSC::roundThunkGenerator):
(JSC::expThunkGenerator):
(JSC::logThunkGenerator):

5:51 PM Changeset in webkit [149081] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Add efl to JSInspectorFrontendHost::port()
https://bugs.webkit.org/show_bug.cgi?id=115137

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-24
Reviewed by Timothy Hatcher.

No new tests, because there is no change in behavior.

  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::port):

5:44 PM Changeset in webkit [149080] by kangil.han@samsung.com
  • 3 edits in trunk/Source/WebCore

Function parameter quotePair can be passed by reference
https://bugs.webkit.org/show_bug.cgi?id=115089

Reviewed by Alexey Proskuryakov.

Minor performance patch.

  • rendering/style/QuotesData.cpp:

(WebCore::QuotesData::addPair):

  • rendering/style/QuotesData.h:

(QuotesData):

5:17 PM Changeset in webkit [149079] by beidson@apple.com
  • 10 edits in trunk/Source/WebCore

Implementors of CachedResource subclasses should be forced to decide if encoded data can be replaced.
https://bugs.webkit.org/show_bug.cgi?id=115140

Reviewed by Beth Dakin.

No new tests (No behavior change).

This makes mayTryReplaceEncodedData() return false in CachedResource, but overrides to true
in all CachedResource subclasses besides CachedFont (which already has an implementation).

  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedImage.h:
  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.h:
  • loader/cache/CachedSVGDocument.h:
  • loader/cache/CachedScript.h:
  • loader/cache/CachedShader.h:
  • loader/cache/CachedTextTrack.h:
  • loader/cache/CachedXSLStyleSheet.h:
5:10 PM Changeset in webkit [149078] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Misc bugfix and cleaning in sh4 base JIT.
https://bugs.webkit.org/show_bug.cgi?id=115022.

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-04-24
Reviewed by Oliver Hunt.

Remove unused add32() and sub32() with scratchreg parameter to avoid
confusion as this function prototype means another behaviour.
Remove unused "void push(Address)" function which seems quite buggy.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::and32): Cosmetic change.
(JSC::MacroAssemblerSH4::lshift32): Cosmetic change.
(JSC::MacroAssemblerSH4::or32): Cosmetic change.
(JSC::MacroAssemblerSH4::xor32): Cosmetic change.
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::load32): Cosmetic change.
(JSC::MacroAssemblerSH4::load8Signed): Fix invalid offset upper limit
when using r0 register and cosmetic changes.
(JSC::MacroAssemblerSH4::load8): Reuse load8Signed to avoid duplication.
(JSC::MacroAssemblerSH4::load16): Fix invalid offset upper limit when
using r0 register, fix missing offset shift and cosmetic changes.
(JSC::MacroAssemblerSH4::store32): Cosmetic change.
(JSC::MacroAssemblerSH4::branchAdd32): Store result value before branch.

4:46 PM Changeset in webkit [149077] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

Further unreviewed build fix; CFNetwork.framework is the one which Lion
refuses to link against.

  • WebKit2.xcodeproj/project.pbxproj:
4:32 PM Changeset in webkit [149076] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix; link against CoreServices.framework instead of against
CoreFoundation.framework directly, to make the linker happy on Lion.

  • WebKit2.xcodeproj/project.pbxproj:
4:31 PM Changeset in webkit [149075] by ddkilzer@apple.com
  • 2 edits in trunk/LayoutTests

Fix invalid test names in jsc-test-list
<http://webkit.org/b/115136>

Reviewed by Geoffrey Garen.

This shell script finds all the invalid tests listed in
LayoutTests/fast/js/jsc-test-list:

$ for F in cat LayoutTests/fast/js/jsc-test-list; do if [ ! -f LayoutTests/$F.html ]; then echo $F; fi; done
fast/js/dfg-double-addition-simplify-to-int.html
fast/js/dfg-mul-big-integers-with-small-integer-and-bitor
fast/js/dfg-mul-big-integers-with-small-integer-and-detect-overflow
fast/js/dfg-mul-big-integers-with-small-integer
fast/js/dfg-value-to-int32-with-side-effects

  • fast/js/jsc-test-list: Fix invalid test names by removing

*.html suffix or stray "s" characters.

4:20 PM Changeset in webkit [149074] by jer.noble@apple.com
  • 9 edits
    3 copies
    2 adds in trunk/Source/WebKit2

WWDC session videos don’t play at developer.apple.com
https://bugs.webkit.org/show_bug.cgi?id=114858

Reviewed by Eric Carlson. Rubber stamped by Brady Eidson.

AVFoundation uses CFNetwork to store and retrieve cookies from the global store.
However, in the case where network access happens in the NetworkProcess, session
cookies are stored in-memory, and are not accessable in the WebProcess. Until such
a time as AVFoundation can provide an API which would allow us to provide cookies
for a specific request, we will interpose the CFNetwork method which they use to
retrieve the cookie string from the cookie store for their pending request.

Duplicate the previous SecItemShim target to a new, WebProcessShim target. This
target includes the SecItemShim functionality, but will add a new shim for cookie
retrieval:

  • Shared/mac/CookieStorageShimLibrary.h: Added

(CookieStorageShimCallbacks):

  • Shared/mac/CookieStorageShimLibrary.cpp: Added.

(WebKit::ShimProtector::ShimProtector): A simple stack-based counter class.
(WebKit::ShimProtector::~ShimProtector):
(WebKit::ShimProtector::count):
(WebKit::shimCFHTTPCookieStorageCopyRequestHeaderFieldsForURL): Interpose

the CFNetwork call, and pass to the registered callback.

(WebKit::WebKitCookieStorageShimInitialize): Register the callbacks.

Add a helper singleton class which will talk to the shim through the
registered callbacks:

  • Shared/mac/CookieStorageShim.h: Added

(WebKit::CookieStorageShim::CookieStorageShim):

  • Shared/mac/CookieStorageShim.cpp: Added.

(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL): Pass the request

over to the NetworkProcess.

(WebKit::CookieStorageShim::shared): Simple singleton.
(WebKit::CookieStorageShim::initialize): Call the library initializer.

Initialize the shim only when the WebProcess is delegating network loading
to the NetworkProcess:

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

Rename the WebProcess's shim from SecItemShim -> WebProcessShim:

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::addDYLDEnvironmentAdditions):

  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:

(WebKit::WebContentProcessMainDelegate::doPreInitializationWork):

  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:

(WebContentServiceInitializer):

As the DYLD_INTERPOSE macro is used in multiple files now, put it in its
own header:

  • Shared/mac/DyldInterpose.h: Added.
  • PluginProcess/mac/PluginProcessShim.mm:
  • WebProcess/mac/SecItemShimLibrary.mm:

Add new files to the project:

  • WebKit2.xcodeproj/project.pbxproj:
3:50 PM Changeset in webkit [149073] by bw80.lee@samsung.com
  • 4 edits in trunk

[EFL] Fix build error after r148963.
https://bugs.webkit.org/show_bug.cgi?id=115126

Reviewed by Laszlo Gombos.

Generate forwarding headers for 'CoordinatedGraphics' to generate WKView.h

Source/WebKit2:

  • PlatformEfl.cmake:

Tools:

  • TestWebKitAPI/PlatformEfl.cmake:
3:42 PM Changeset in webkit [149072] by Patrick Gansterer
  • 13 edits in trunk/Source/JavaScriptCore

[WIN] Remove pthread from Visual Studio files in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=114864

Reviewed by Brent Fulgham.

3:39 PM Changeset in webkit [149071] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

DFG should keep the operand to create_this alive if it's emitting code for create_this
https://bugs.webkit.org/show_bug.cgi?id=115133

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

The DFG must model bytecode liveness, or else OSR exit is going to have a really bad time.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

LayoutTests:

Reviewed by Mark Hahnenberg.

This test crashes prior to my change.

  • fast/js/dfg-allocation-profile-watch-point-exit-expected.txt: Added.
  • fast/js/dfg-allocation-profile-watch-point-exit.html: Added.
  • fast/js/jsc-test-list:
  • fast/js/script-tests/dfg-allocation-profile-watch-point-exit.js: Added.

(Foo):
(foo):

3:35 PM Changeset in webkit [149070] by beidson@apple.com
  • 5 edits in trunk/Source/WebCore

Once a custom font is cached to disk, it starts failing to render until the page is refreshed.
<rdar://problem/13622998> and https://bugs.webkit.org/show_bug.cgi?id=115131

Reviewed by Alexey Proskuryakov.

No new tests (Not a tested config, nor are disk cache issues currently testable).

  • loader/cache/CachedResource.h:

(WebCore::CachedResource:: mayTryReplaceEncodedData): Allow subclasses to refuse encoded data replacement.

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::tryReplaceEncodedData): Only try if shouldTryReplaceEncodedData() is true.

  • loader/cache/CachedFont.cpp:

(WebCore::CachedFont::CachedFont):
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::mayTryReplaceEncodedData): Return false if the custom font data has ever been created.

  • loader/cache/CachedFont.h:
3:22 PM Changeset in webkit [149069] by jpfau@apple.com
  • 2 edits in branches/safari-536.30-branch/LayoutTests

<rdar://problem/12952167> 11G56: “AVF Info: …” logged to stdout

  • platform/mac-lion/Skipped: Skipped all tests that were failing due to AVF info being printed.
3:05 PM Changeset in webkit [149068] by ap@apple.com
  • 5 edits in trunk/LayoutTests

fast/js/global-constructors.html was deleted in r149001, removing it from
TextExpectations too.

  • platform/mac/TestExpectations:
  • platform/qt-arm/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:
2:43 PM Changeset in webkit [149067] by roger_fong@apple.com
  • 13 edits in trunk

Have VS2010 WebKit solution look in WebKit_Libraries/lib32 for dependencies.

2:37 PM Changeset in webkit [149066] by Beth Dakin
  • 12 edits in trunk/Source/WebCore

Vertical overlay scrollbar in iframes fades in and out rapidly when you scroll in
a circle
https://bugs.webkit.org/show_bug.cgi?id=115124
-and corresponding-
<rdar://problem/13168957>

Reviewed by Anders Carlsson.

With http://trac.webkit.org/changeset/119834 we started calling
ScrollbarPainterController's contentAreaScrolled/contentAreaScrolledInDirection
API on a zero-delay timer instead of calling it right away. This prevented some
crashes that we saw whenever this was called during a layout. However, that delay,
combined with the particulars of contentAreaScrolledInDirection cause this bug
where sometimes the scrollbars in an iframe will fade out very noticeably when
scrolling in a circle.

This change makes it so we will only use the zero-delay timer if the
ScrollableArea is not currently handling a wheel event. If it IS handling a wheel
event, then we will send the notifications to AppKit right away. I confirmed that
this change did not reintroduce the old crashes.

Keep track of whether we are currently handling a wheel event with the new member
variable m_isHandlingWheelEvent.

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::handleWheelEvent):

  • page/EventHandler.h:

(WebCore::EventHandler::isHandlingWheelEvent):
(EventHandler):

To prevent layering violations, the ScrollableArea sub-classes will have to access
this information from the EventHandler.

  • page/FrameView.cpp:

(WebCore::FrameView::isHandlingWheelEvent):

  • page/FrameView.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::isHandlingWheelEvent):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::isHandlingWheelEvent):

  • rendering/RenderLayer.h:

(RenderLayer):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::isHandlingWheelEvent):

  • rendering/RenderListBox.h:

sendContentAreaScrolledSoon() can be private. Also add new function
sendContentAreaScrolled().

  • platform/mac/ScrollAnimatorMac.h:

(ScrollAnimatorMac):

If the ScrollableArea is handling a wheel event, call
sendContentAreaScrolled(), otherwise call sendContentAreaScrolledSoon()

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolled):

Re-factored to use sendContentAreaScrolled()
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):

2:35 PM Changeset in webkit [149065] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix a merge error in r149007 (was missing a null check added in r148777).

  • rendering/LogicalSelectionOffsetCaches.h:

(WebCore::containingBlockForAbsolutePosition):

2:33 PM Changeset in webkit [149064] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash when trying to determine the length of an invalid message
https://bugs.webkit.org/show_bug.cgi?id=115127
<rdar://problem/13700736>

Reviewed by Beth Dakin.

Use message instead of incomingMessage since incomingMessage will always be null.

  • Platform/CoreIPC/Connection.cpp:

(CoreIPC::Connection::processIncomingMessage):

1:38 PM Changeset in webkit [149063] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Battery API won't return updated battery status until client calls didChangeBatteryStatus
https://bugs.webkit.org/show_bug.cgi?id=114891

Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-04-24
Reviewed by Rob Buis.

The BatteryStatus object in BatteryManager won't get updated until BatteryClient calls
didChangeBatteryStatus in BatteryController. Any attempts to call webkitBattery.charged()
or other get functions will always return the default values until the next battery status
change object gets passed to the controller.

We need to update the manager when we attach it to the controller, and update all
existing managers when the controller receives it's first battery status object.

  • Modules/battery/BatteryController.cpp:

(WebCore::BatteryController::addListener):
(WebCore::BatteryController::updateBatteryStatus):

  • Modules/battery/BatteryManager.cpp:

(WebCore::BatteryManager::didChangeBatteryStatus):
(WebCore::BatteryManager::updateBatteryStatus):
(WebCore):

  • Modules/battery/BatteryManager.h:

(BatteryManager):

1:11 PM Changeset in webkit [149062] by zhajiang@rim.com
  • 2 edits in trunk/Source/WebCore

Clean up unused code in ViewportArguments.h
https://bugs.webkit.org/show_bug.cgi?id=115121

Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-04-24.
Reviewed by Benjamin Poulain.

The target-densityDPI emulation implementation has been removed by
r147893, so clean up the remaining code as well.

  • dom/ViewportArguments.h:
1:03 PM Changeset in webkit [149061] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

ElementData should use 'unsigned' attribute indices.
<http://webkit.org/b/115103>

Reviewed by Antti Koivisto.

Switch to using 'unsigned' for attribute indices. This gives consistent behavior
on 32/64-bit, and the underlying storage is already limited by Vector's 32-bit capacity.

Added an ElementData::attributeNotFound constant (-1) since we can't use WTF::notFound.

  • dom/Element.cpp:

(WebCore::Element::detachAttribute):
(WebCore::Element::removeAttribute):
(WebCore::Element::setAttribute):
(WebCore::Element::setSynchronizedLazyAttribute):
(WebCore::Element::setAttributeInternal):
(WebCore::Element::setAttributeNode):
(WebCore::Element::removeAttributeNode):
(WebCore::Element::removeAttributeInternal):
(WebCore::UniqueElementData::removeAttribute):
(WebCore::ElementData::getAttributeItemIndexSlowCase):

  • dom/Element.h:

(ElementData):
(UniqueElementData):
(Element):
(WebCore::Element::getAttributeItemIndex):
(WebCore::Element::attributeCount):
(WebCore::ElementData::length):
(WebCore::ElementData::getAttributeItem):
(WebCore::ElementData::getAttributeItemIndex):

  • dom/NamedNodeMap.cpp:

(WebCore::NamedNodeMap::removeNamedItem):
(WebCore::NamedNodeMap::removeNamedItemNS):
(WebCore::NamedNodeMap::length):

  • dom/NamedNodeMap.h:

(NamedNodeMap):

1:00 PM Changeset in webkit [149060] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

ElementData::attributeItem() should bounds-check the index.
<http://webkit.org/b/115076>

Reviewed by Antti Koivisto.

Switch the ASSERT_WITH_SECURITY_IMPLICATION to a RELEASE_ASSERT.

  • dom/Element.h:

(WebCore::ElementData::attributeItem):

12:59 PM Changeset in webkit [149059] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Setting an inline style property to "" shouldn't cause style recalc unless the property was present.
<http://webkit.org/b/115122>

Reviewed by Antti Koivisto.

StylePropertySet::setProperty() handles empty strings by removing the property entirely.
If there was no property to remove, it shouldn't claim that it changed something, as that
will cause the CSSOM wrapper to mark the element for style recalc.

A common idiom that triggers this is excessive use of { element.style.display = ; }

  • css/StylePropertySet.cpp:

(WebCore::MutableStylePropertySet::setProperty):

12:50 PM Changeset in webkit [149058] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Moving word boundaries backwards fails when there is a text node starting with an apostrophe
https://bugs.webkit.org/show_bug.cgi?id=115070

Reviewed by Alexey Proskuryakov.

Source/WebCore:

The bug was caused by previousBoundary erroneously assuming that we don't need any more context if a word
boundary is found at the beginning of a string. For example, when "I'll" is split into two text nodes,
"I" and "'ll", there is a word boundary between "'" and "ll" in "'ll" so we need to examine the whole "I'll".

Fixed the bug by obtaining more context when the character starts exactly at offset 1 in a text node to
work around this bug. In the long term, we probably need to provide Foundation of the entire context since in
languages like Hebrew and some of European languages, there could be many accents and combining characters
between split into multiple text nodes as one variant is seen in the newly added test case.

Test: editing/selection/previous-word-boundary-across-text-nodes.html

  • editing/VisibleUnits.cpp:

(WebCore::previousBoundary):

LayoutTests:

Added a test case for moving bacwkards with a word granurality across multiple text nodes.
Some test cases still fail since this patch only implements a work around.

  • editing/selection/previous-word-boundary-across-text-nodes-expected.txt: Added.
  • editing/selection/previous-word-boundary-across-text-nodes.html: Added.
12:46 PM Changeset in webkit [149057] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Do not use static string in DiagnosticLoggingKeys
https://bugs.webkit.org/show_bug.cgi?id=115093

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-24
Reviewed by Andreas Kling.

The code is not hot enough to justify keeping the memory around.
This removes 3kb from the binary on x86_64.

  • page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::mediaLoadedKey):
(WebCore::DiagnosticLoggingKeys::mediaLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadedKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::pageContainsPluginKey):
(WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey):
(WebCore::DiagnosticLoggingKeys::pageContainsMediaEngineKey):
(WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOneMediaEngineKey):
(WebCore::DiagnosticLoggingKeys::passKey):
(WebCore::DiagnosticLoggingKeys::failKey):
(WebCore::DiagnosticLoggingKeys::noopKey):

  • page/DiagnosticLoggingKeys.h:

(DiagnosticLoggingKeys):

12:38 PM Changeset in webkit [149056] by benjamin@webkit.org
  • 22 edits in trunk/Source/WebCore

Remove wxWebKit #ifdefs from WebCore/platform/graphics
https://bugs.webkit.org/show_bug.cgi?id=115081

Reviewed by Geoffrey Garen.

  • platform/graphics/BitmapImage.h:

(BitmapImage):

  • platform/graphics/Color.h:

(Color):

  • platform/graphics/FloatRect.h:

(FloatRect):

  • platform/graphics/FloatSize.h:

(FloatSize):

  • platform/graphics/FontPlatformData.h:
  • platform/graphics/GlyphBuffer.h:

(WebCore):
(WebCore::GlyphBuffer::glyphAt):
(WebCore::GlyphBuffer::add):

  • platform/graphics/Gradient.h:
  • platform/graphics/GraphicsContext.h:

(GraphicsContext):

  • platform/graphics/Image.cpp:

(WebCore::Image::drawTiled):

  • platform/graphics/ImageBufferData.h:
  • platform/graphics/IntPoint.h:

(IntPoint):

  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.h:

(IntSize):

  • platform/graphics/NativeImagePtr.h:

(WebCore):

  • platform/graphics/Path.h:
  • platform/graphics/Pattern.h:
  • platform/graphics/SimpleFontData.h:

(SimpleFontData):
(WebCore::SimpleFontData::widthForGlyph):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::collectComplexTextRuns):

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

  • platform/graphics/transforms/AffineTransform.h:

(AffineTransform):

  • platform/graphics/transforms/TransformationMatrix.h:

(TransformationMatrix):

12:36 PM Changeset in webkit [149055] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove wxWebKit #ifdefs from WebCore/plugins
https://bugs.webkit.org/show_bug.cgi?id=115080

Reviewed by Geoffrey Garen.

  • plugins/PluginView.h:

(PluginView):

  • plugins/mac/PluginViewMac.mm:

(WebCore::nativeWindowFor):
(WebCore::cgHandleFor):
(WebCore::topLevelOffsetFor):
(WebCore::PluginView::platformStart):

  • plugins/win/PluginViewWin.cpp:

(windowHandleForPageClient):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::snapshot):

12:35 PM Changeset in webkit [149054] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebCore

Remove wxWebKit #ifdefs from WebCore/page
https://bugs.webkit.org/show_bug.cgi?id=115079

Reviewed by Geoffrey Garen.

  • page/FrameView.cpp:

(WebCore::FrameView::wheelEvent):

  • page/Settings.cpp:

(WebCore):

  • page/Settings.h:

(Settings):

12:34 PM Changeset in webkit [149053] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Use post-branch store for RefCountedBase::derefBase
https://bugs.webkit.org/show_bug.cgi?id=115078

Reviewed by Andreas Kling.

  • wtf/RefCounted.h:

(WTF::RefCountedBase::derefBase): This makes the assembly easier to follow.

11:34 AM Changeset in webkit [149052] by Carlos Garcia Campos
  • 5 edits in trunk

[GTK] Use stamp files for generate-forwarding-headers makefile rules
https://bugs.webkit.org/show_bug.cgi?id=115118

Reviewed by Martin Robinson.

Source/WebKit2:

Use a stamp file for the WebKit2 forwarding generator rule. Also
fix the rule dependencies that pointed to a non existent variable.

  • GNUmakefile.am:

Tools:

Use a stamp file for the TestWebKitAPI and WebKitTestRunner
forwarding generator rules and don't call it for soup since there
aren't soup directories in TestWebKitAPI and WebKitTestRunner.

  • TestWebKitAPI/GNUmakefile.am:
  • WebKitTestRunner/GNUmakefile.am:
11:33 AM Changeset in webkit [149051] by Chris Fleizach
  • 12 edits
    2 adds in trunk

AX: WAI-ARIA landmarks no longer speak type of landmark on iOS
https://bugs.webkit.org/show_bug.cgi?id=114547

Reviewed by David Kilzer.

Source/WebCore:

We want iOS to speak the landmark type.
I've moved the landmark role description to the base Mac class and exposed
these localized strings to iOS (the ones used to return landmark descriptions).

I've also updated the accessibilityLabel to account for landmark type, but also
handle multiple label sources more gracefully by appending commas, which changed a few
tests in minor ways.

Test: platform/iphone-simulator/accessibility/landmark-type.html

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityLabel]):

  • accessibility/mac/WebAccessibilityObjectWrapperBase.h:
  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(-[WebAccessibilityObjectWrapperBase ariaLandmarkRoleDescription]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper roleDescription]):

  • platform/LocalizedStrings.cpp:

(WebCore):
(WebCore::AXButtonActionVerb):
(WebCore::AXRadioButtonActionVerb):
(WebCore::AXTextFieldActionVerb):
(WebCore::AXCheckedCheckBoxActionVerb):
(WebCore::AXUncheckedCheckBoxActionVerb):
(WebCore::AXLinkActionVerb):
(WebCore::AXMenuListPopupActionVerb):
(WebCore::AXMenuListActionVerb):

  • platform/LocalizedStrings.h:

(WebCore):

LayoutTests:

  • platform/iphone-simulator/accessibility/landmark-type-expected.txt: Added.
  • platform/iphone-simulator/accessibility/landmark-type.html: Added.
  • platform/iphone-simulator/accessibility/link-with-images-text-expected.txt:
  • platform/iphone-simulator/accessibility/link-with-images-text.html:

Minor change to accomodate trimming of white space.

  • platform/iphone-simulator/accessibility/math-expected.txt:
  • platform/iphone-simulator/accessibility/math.html:

Math objects now include "math" as the landmark type.

11:16 AM Changeset in webkit [149050] by ggaren@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

32-bit build fix.

Unreviewed.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleBooleanBranch): Explicitly
truncate to 32-bit to avoid compiler warnings. It's safe to truncate
because the payload of a boolean is the low bits on both 64-bit and 32-bit.

11:06 AM Changeset in webkit [149049] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

[GTK][WK2] Implement LayerTreeHostGtk::pageBackgroundTransparencyChanged
https://bugs.webkit.org/show_bug.cgi?id=115094

Reviewed by Tim Horton.

The method was introduced in r149004 (and a stub implementation for the GTK port added in r149017).
Implement the method for the GTK port in the same manner it is implemented under the Mac port,
calling setContentsOpaque on the non-composited content layer.

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::pageBackgroundTransparencyChanged):

10:50 AM Changeset in webkit [149048] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Update build dependencies
https://bugs.webkit.org/show_bug.cgi?id=115111

Patch by Simon Pena <simon.pena@samsung.com> on 2013-04-24
Reviewed by Martin Robinson.

The install-dependencies script was missing a dependency on EGL,
which is expected when building Cairo.

  • gtk/install-dependencies: Added a dependency on libegl1-mesa

for both apt and yum.

10:43 AM Changeset in webkit [149047] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

CSS attribute selectors cause unnecessary style recalc when setting attribute to same value.
<http://webkit.org/b/115116>
<rdar://problem/13727709>

Reviewed by Simon Fraser.

The logic that dirties the style if there's a relevant attribute selector in the document
shouldn't run if the attribute is being overwritten with an identical value.
Move this into willModifyAttribute() instead, since we need access to both the old and the new value.

This reduces unnecessary style recalculation in Mac App Store content.

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):
(WebCore::Element::willModifyAttribute):

10:07 AM Changeset in webkit [149046] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove the Chromium-specific helper from run_webkit_tests.py
https://bugs.webkit.org/show_bug.cgi?id=114996

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-24
Reviewed by Dirk Pranke.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(parse_args):

9:12 AM Changeset in webkit [149045] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Tools

[EFL][WK2]: Fix WKViewClientWebProcessCallbacks WK2 API test
https://bugs.webkit.org/show_bug.cgi?id=114850

Patch by Sergio Correia <Sergio Correia> on 2013-04-24
Reviewed by Andreas Kling.

Revision r148312 fixed WebPageProxy cleanup and also changed the process
termination semantics when requested by the user so that a client is not
notified of a crash anymore, since there was no crash anyway.

That change broke WKViewClientWebProcessCallbacks WK2 API test, since it
relied on being notified of a crash after calling WKPageTerminate(). As
a result of not being notified of such non-existent crash, the test would
timeout right after making the terminate call.

This patch adds an InjectedBundle to be used for simulating a crash, by
calling abort() upon receiving a "Crash" message, and thus we are able to
keep testing the crash callback.

This patch also re-enables the WKViewClientWebProcessCallbacks test, which
had been disabled in revisions r148858 and r148855, since it was failing.

  • TestWebKitAPI/PlatformEfl.cmake:
  • TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/efl/WKViewClientWebProcessCallbacks_Bundle.cpp: Added.

(TestWebKitAPI):
(WKViewClientWebProcessCallbacksTest):
(TestWebKitAPI::WKViewClientWebProcessCallbacksTest::WKViewClientWebProcessCallbacksTest):
(TestWebKitAPI::WKViewClientWebProcessCallbacksTest::didReceiveMessage):

9:08 AM Changeset in webkit [149044] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

2013-04-24 Simon Cooper <scooper@apple.com>

<rdar://problem/13614117> Refine the Flash Player profile
https://bugs.webkit.org/show_bug.cgi?id=115016

Reviewed by Alexey Proskuryakov.

Add some refinements to the Flash Player profile. Make a non-/ home
directory work. Fixes that allow file uploading via user selected files.

  • Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb:
8:59 AM Changeset in webkit [149043] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Do not clear focus on a node when tapping on form controls
https://bugs.webkit.org/show_bug.cgi?id=115055

Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-04-24
Reviewed by Rob Buis.

Internally reviewed by Genevieve Mak.

PR316069
To allow for rich text editors to apply styles on an input field
or highlighted text, we must maintain focus on the current element
when tapping on form elements. Moving the code that clears this
context to trigger off TouchHold instead of TouchPress.

  • WebKitSupport/TouchEventHandler.cpp:

(BlackBerry::WebKit::TouchEventHandler::doFatFingers):

8:49 AM Changeset in webkit [149042] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Fixes the San Angeles demo on khronos.org
https://bugs.webkit.org/show_bug.cgi?id=115106

Patch by Jonathan Feldstein <jfeldstein@blackberry.com> on 2013-04-24
Reviewed by Rob Buis
Internally Reviewed by Jeremy Nicholl and Arvid Nilsson

Fixes a bug in which the currently bound vertex array object's vertex array
state was being modified as opposed to the default vertex array state.

  • platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:

(EGLImageLayerWebKitThread::blitToFrontBuffer):

8:48 AM Changeset in webkit [149041] by ggaren@apple.com
  • 8 edits in trunk

Filled out more cases of branch folding in the DFG
https://bugs.webkit.org/show_bug.cgi?id=115088

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

No change on the benchmarks we track, but a 3X speedup on a
microbenchmark that uses these techniques.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock): (!/=)= and (!/=)== can constant
fold all types, not just numbers, because true constants have no
side effects when type-converted at runtime.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateBoolean): Added support for fixing up
boolean uses, like we do for other types like number.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleBooleanBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::compileBooleanCompare): Peephole fuse
boolean compare and/or compare-branch, now that we have the types for
them.

  • dfg/DFGSpeculativeJIT.h: Updated declarations.

LayoutTests:

  • fast/js/regress/script-tests/branch-fold.js:

(g): Added some boolean and constant-folded cases.

8:44 AM Changeset in webkit [149040] by thakis@chromium.org
  • 4 edits
    2 deletes in trunk/Source/WebCore

Fold RenderThemeMacShared into RenderThemeMac
https://bugs.webkit.org/show_bug.cgi?id=115086

Reviewed by Anders Carlsson.

No intended functionality change.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderThemeMac.h:

(RenderThemeMac):
(WebCore::RenderThemeMac::supportsControlTints):
(WebCore::RenderThemeMac::scrollbarControlSizeForPart):
(WebCore::RenderThemeMac::supportsSelectionForegroundColors):
(WebCore::RenderThemeMac::supportsClosedCaptioning):
(WebCore::RenderThemeMac::updateActiveState):

  • rendering/RenderThemeMac.mm:

(-[WebCoreRenderThemeNotificationObserver initWithTheme:WebCore::]):
(-[WebCoreRenderThemeNotificationObserver systemColorsDidChange:]):
(-[WebCoreTextFieldCell _coreUIDrawOptionsWithFrame:inView:includeFocus:]):
(WebCore::RenderThemeMac::RenderThemeMac):
(WebCore::RenderThemeMac::~RenderThemeMac):
(WebCore::RenderThemeMac::platformActiveSelectionBackgroundColor):
(WebCore):
(WebCore::RenderThemeMac::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeMac::platformActiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeMac::platformActiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeMac::platformFocusRingColor):
(WebCore::RenderThemeMac::platformInactiveListBoxSelectionBackgroundColor):
(WebCore::toFontWeight):
(WebCore::RenderThemeMac::systemFont):
(WebCore::convertNSColorToColor):
(WebCore::menuBackgroundColor):
(WebCore::RenderThemeMac::platformColorsDidChange):
(WebCore::RenderThemeMac::systemColor):
(WebCore::RenderThemeMac::usesTestModeFocusRingColor):
(WebCore::RenderThemeMac::isControlStyled):
(WebCore::RenderThemeMac::adjustRepaintRect):
(WebCore::RenderThemeMac::inflateRect):
(WebCore::RenderThemeMac::convertToPaintingRect):
(WebCore::RenderThemeMac::updateCheckedState):
(WebCore::RenderThemeMac::updateEnabledState):
(WebCore::RenderThemeMac::updateFocusedState):
(WebCore::RenderThemeMac::updatePressedState):
(WebCore::RenderThemeMac::controlSupportsTints):
(WebCore::RenderThemeMac::controlSizeForFont):
(WebCore::RenderThemeMac::setControlSize):
(WebCore::RenderThemeMac::sizeForFont):
(WebCore::RenderThemeMac::sizeForSystemFont):
(WebCore::RenderThemeMac::setSizeFromFont):
(WebCore::RenderThemeMac::setFontFromControlSize):
(WebCore::RenderThemeMac::controlSizeForSystemFont):
(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::adjustTextFieldStyle):
(WebCore::RenderThemeMac::paintCapsLockIndicator):
(WebCore::RenderThemeMac::paintTextArea):
(WebCore::RenderThemeMac::adjustTextAreaStyle):
(WebCore::RenderThemeMac::popupButtonMargins):
(WebCore::RenderThemeMac::popupButtonSizes):
(WebCore::RenderThemeMac::popupButtonPadding):
(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::meterSizeForBounds):
(WebCore::RenderThemeMac::paintMeter):
(WebCore::RenderThemeMac::supportsMeter):
(WebCore::RenderThemeMac::levelIndicatorStyleFor):
(WebCore::RenderThemeMac::levelIndicatorFor):
(WebCore::RenderThemeMac::progressBarSizes):
(WebCore::RenderThemeMac::progressBarMargins):
(WebCore::RenderThemeMac::minimumProgressBarHeight):
(WebCore::RenderThemeMac::animationRepeatIntervalForProgressBar):
(WebCore::RenderThemeMac::animationDurationForProgressBar):
(WebCore::RenderThemeMac::adjustProgressBarStyle):
(WebCore::RenderThemeMac::paintProgressBar):
(WebCore::TopGradientInterpolate):
(WebCore::BottomGradientInterpolate):
(WebCore::MainGradientInterpolate):
(WebCore::TrackGradientInterpolate):
(WebCore::RenderThemeMac::paintMenuListButtonGradients):
(WebCore::RenderThemeMac::paintMenuListButton):
(WebCore::menuListButtonSizes):
(WebCore::RenderThemeMac::adjustMenuListStyle):
(WebCore::RenderThemeMac::popupInternalPaddingLeft):
(WebCore::RenderThemeMac::popupInternalPaddingRight):
(WebCore::RenderThemeMac::popupInternalPaddingTop):
(WebCore::RenderThemeMac::popupInternalPaddingBottom):
(WebCore::RenderThemeMac::adjustMenuListButtonStyle):
(WebCore::RenderThemeMac::setPopupButtonCellState):
(WebCore::RenderThemeMac::menuListSizes):
(WebCore::RenderThemeMac::minimumMenuListSize):
(WebCore::RenderThemeMac::adjustSliderTrackStyle):
(WebCore::RenderThemeMac::paintSliderTrack):
(WebCore::RenderThemeMac::adjustSliderThumbStyle):
(WebCore::RenderThemeMac::paintSliderThumb):
(WebCore::RenderThemeMac::paintSearchField):
(WebCore::RenderThemeMac::setSearchCellState):
(WebCore::RenderThemeMac::searchFieldSizes):
(WebCore::RenderThemeMac::setSearchFieldSize):
(WebCore::RenderThemeMac::adjustSearchFieldStyle):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::cancelButtonSizes):
(WebCore::RenderThemeMac::adjustSearchFieldCancelButtonStyle):
(WebCore::RenderThemeMac::resultsButtonSizes):
(WebCore::RenderThemeMac::adjustSearchFieldDecorationStyle):
(WebCore::RenderThemeMac::paintSearchFieldDecoration):
(WebCore::RenderThemeMac::adjustSearchFieldResultsDecorationStyle):
(WebCore::RenderThemeMac::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeMac::adjustSearchFieldResultsButtonStyle):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):
(WebCore::RenderThemeMac::sliderTickSize):
(WebCore::RenderThemeMac::sliderTickOffsetFromTrackCenter):
(WebCore::RenderThemeMac::adjustSliderThumbSize):
(WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused):
(WebCore::RenderThemeMac::popupButton):
(WebCore::RenderThemeMac::search):
(WebCore::RenderThemeMac::searchMenuTemplate):
(WebCore::RenderThemeMac::sliderThumbHorizontal):
(WebCore::RenderThemeMac::sliderThumbVertical):
(WebCore::RenderThemeMac::textField):
(WebCore::RenderThemeMac::fileListNameForWidth):

  • rendering/RenderThemeMacShared.h: Removed.
  • rendering/RenderThemeMacShared.mm: Removed.
8:38 AM CoordinatedGraphicsSystem edited by allan.jensen@digia.com
(diff)
8:36 AM Changeset in webkit [149039] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK][AC] Visible rect doesn't update after resizing a window.
https://bugs.webkit.org/show_bug.cgi?id=115096

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-24
Reviewed by Gustavo Noronha Silva.

Once we set actor's a clip rect, we should update the rect when resizing the actor.

No new tests since no new functionality.

  • platform/graphics/clutter/GraphicsLayerClutter.cpp:

(WebCore::GraphicsLayerClutter::setSize):

8:34 AM Changeset in webkit [149038] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK][AC] Fix unexpected clear of ClutterContent.
https://bugs.webkit.org/show_bug.cgi?id=115099

Patch by ChangSeok Oh <ChangSeok Oh> on 2013-04-24
Reviewed by Gustavo Noronha Silva.

adoptGRef doesn't increase a reference count. So if a actor has a valid ClutterContent,
it would be cleared unexpectedly by smart pointer when escaping a function.

No new tests, no functionality changed.

  • platform/graphics/clutter/GraphicsLayerActor.cpp:

(graphicsLayerActorUpdateTexture):

8:30 AM Changeset in webkit [149037] by akling@apple.com
  • 2 edits in trunk/Source/WebKit/win

Wild build fix attempt.

  • WebCoreSupport/WebChromeClient.h:

(WebChromeClient):

8:26 AM Changeset in webkit [149036] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WebKit2] Add CoordinatedGraphics to the list of platforms in generate-forwarding-headers.pl
https://bugs.webkit.org/show_bug.cgi?id=115098

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-24
Reviewed by Martin Robinson.

r148963 introduced a new WKView.h header in a directory not listed
as a platform prefix in generate-forwarding-headers.pl.

  • Scripts/generate-forwarding-headers.pl: Replace unused chromium

plaform prefix with CoordinatedGraphics that is used now.

8:15 AM Changeset in webkit [149035] by jberlin@webkit.org
  • 7 edits
    1 delete in trunk/Source/WebKit

Assertion failure (crash in release) attempting to delete database storage in WK1 without
creating a WebView first
https://bugs.webkit.org/show_bug.cgi?id=115065

Reviewed by Brady Eidson.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Remove WebDatabaseManagerInternal.h.

Source/WebKit/mac:

Make sure the WebPlatformStrategies is initialized before using the WebDatabaseManager.

  • Storage/WebDatabaseManager.mm:

(-[WebDatabaseManager init]):
Move the logic from WebKitInitializeDatabasesIfNecessary here, and add a call to
WebPlatformStrategies::initializeIfNecessary.

  • Storage/WebDatabaseManagerInternal.h: Removed.
  • WebCoreSupport/WebPlatformStrategies.h:

(WebPlatformStrategies):
Change "initialize" to "initalizeIfNecessary".

  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::initializeIfNecessary):
Only call setPlatformStrategies once.

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
Updated for the name change from initialize to initializeIfNecessary.
Instead of calling WebKitInitializeDatabasesIfNecessary, call [WebDatabaseManager
sharedWebDatabaseManager].
(+[WebView _setLoadResourcesSerially:]):
Updated for the name change from initialize to initializeIfNecessary.

7:27 AM Changeset in webkit [149034] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

DOMFileSystemBase: fix multiple definitions in the BlackBerry port
https://bugs.webkit.org/show_bug.cgi?id=114950

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-04-24
Reviewed by Xan Lopez.

The following methods are already defined in DOMFileSystemBlackBerry.cpp:

crackFileSystemURL()
createFileSystemURL()
isValidType()
supportsToURL()

  • Modules/filesystem/DOMFileSystemBase.cpp:

(WebCore):

7:10 AM Changeset in webkit [149033] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[BlackBerry] Add support for JPEG image quality during encoding.
https://bugs.webkit.org/show_bug.cgi?id=105773

Patch by George Staikos <gstaikos@rim.com> on 2013-04-24
Reviewed by Xan Lopez.

PR 271611
Internally reviewed by Liam Quinn.

Pass the quality flag into the encoder, with a default of 65

Covered by existing tests.

  • platform/image-encoders/JPEGImageEncoder.cpp:

(WebCore::compressRGBABigEndianToJPEG):

  • platform/image-encoders/JPEGImageEncoder.h:

(WebCore):

6:54 AM Changeset in webkit [149032] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Add unit test cases for ewk_settings APIs
https://bugs.webkit.org/show_bug.cgi?id=114897

Patch by Jose Lejin PJ <jose.lejin@gmail.com> on 2013-04-24
Reviewed by Gyuyoung Kim.

Added unit tests for ewk_settings APIs.

  • tests/test_ewk_setting.cpp:

(TEST_F):

6:11 AM Changeset in webkit [149031] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Fix cast-align WebCore/platform/graphics/GraphicsContext3D.cpp on ARM
https://bugs.webkit.org/show_bug.cgi?id=115036

Reviewed by Benjamin Poulain.

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore):

6:03 AM Changeset in webkit [149030] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline fast/js/constructor-length.html for EFL port after
r148997.

  • platform/efl/fast/js/constructor-length-expected.txt:
5:33 AM Changeset in webkit [149029] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Remove unnecessary MutableStylePropertySet casts.
<http://webkit.org/b/115075>

Reviewed by Geoffrey Garen.

Get rid of some now-unneeded static_casts that were left from the StylePropertySet
refactoring last weekend.

  • css/StylePropertySet.cpp:

(WebCore::MutableStylePropertySet::setProperty):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::triStateOfStyle):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):

5:17 AM Changeset in webkit [149028] by kangil.han@samsung.com
  • 2 edits in trunk/Source/WebCore

[Minor code cleanup] Remove duplicated condition check
https://bugs.webkit.org/show_bug.cgi?id=115082

Reviewed by Andreas Kling.

areRectsPartiallyAligned() has duplicated condition check, so remove it.

  • page/SpatialNavigation.cpp:

(WebCore::areRectsPartiallyAligned):

5:01 AM Changeset in webkit [149027] by Christophe Dumez
  • 2 edits in trunk/Tools

[EFL][WK2] WebKitTestRunner failures due to IconDatabase assertions
https://bugs.webkit.org/show_bug.cgi?id=115095

Reviewed by Antonio Gomes.

Use different subfolders under DumpRenderTree Temp folder for every
functionality (icon database, cache, localstorage, ...). This makes
sure there is no conflict between the functionalities.

In EFL's case, libsoup cache was causing problems for the icon
database if sharing the same folder.

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::initialize):

4:21 AM Changeset in webkit [149026] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

[EFL] Fix build warnings caused by missing images attributes for default buttons
https://bugs.webkit.org/show_bug.cgi?id=114955

Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-04-24
Reviewed by Gyuyoung Kim.

Added default image for each button from mediacontrol catalog.

No new tests, because there is no change in behavior.

  • platform/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc:
  • platform/efl/DefaultTheme/widget/mediacontrol/mutebutton/mute_button.edc:
  • platform/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playpause_button.edc:
  • platform/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackward_button.edc:
  • platform/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforward_button.edc:
  • platform/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/toggle_captions_button.edc:
3:54 AM WebKitGTK/2.0.x edited by Manuel Rego Casasnovas
(diff)
3:53 AM WebKitGTK/2.0.x edited by Manuel Rego Casasnovas
(diff)
3:50 AM Changeset in webkit [149025] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Web Inspector: Add number to list from remote web inspector.
https://bugs.webkit.org/show_bug.cgi?id=115014

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-24
Reviewed by Benjamin Poulain.

  • UIProcess/InspectorServer/front-end/inspectorPageIndex.html:
3:48 AM Changeset in webkit [149024] by commit-queue@webkit.org
  • 23 edits in trunk/LayoutTests

[EFL] Rebaselining after r148944
https://bugs.webkit.org/show_bug.cgi?id=115085

Unreviewed gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-04-24

  • platform/efl/TestExpectations:
  • platform/efl/fast/table/giantRowspan-expected.txt:
  • platform/efl/fast/table/giantRowspan2-expected.png:
  • platform/efl/fast/table/giantRowspan2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug133756-1-expected.png:
  • platform/efl/tables/mozilla/bugs/bug133756-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug133756-2-expected.png:
  • platform/efl/tables/mozilla/bugs/bug133756-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug220536-expected.png:
  • platform/efl/tables/mozilla/bugs/bug220536-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug8858-expected.png:
  • platform/efl/tables/mozilla/bugs/bug8858-expected.txt:
  • platform/efl/tables/mozilla/core/bloomberg-expected.png:
  • platform/efl/tables/mozilla/core/bloomberg-expected.txt:
  • platform/efl/tables/mozilla/core/row_span-expected.png:
  • platform/efl/tables/mozilla/core/row_span-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
2:01 AM Changeset in webkit [149023] by abucur@adobe.com
  • 3 edits in trunk/LayoutTests

Fix test style issues following the commit of
https://bugs.webkit.org/show_bug.cgi?id=114412

Unreviewed gardening.

  • css3/compositing/effect-background-blend-mode-color.html:
  • css3/compositing/effect-background-blend-mode-color2.html:
1:44 AM Changeset in webkit [149022] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

--minimal build fails with error: Source/WebKit2/Platform/CoreIPC/ArgumentCoder.h:44:36: error: decode is not a member of WebCore::TextCheckingResult
https://bugs.webkit.org/show_bug.cgi?id=114367

Patch by Vlad Vasilyeu <vasvlad@gmail.com> on 2013-04-24
Reviewed by Benjamin Poulain.

Include WebCoreArgumentCoders.h to WebEditorClientEfl.cpp from
WebKit2/Shared/ for successfully building with option --minimal

  • WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp:
1:23 AM Changeset in webkit [149021] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix with gstreamer 0.10.x after r147555.

  • platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:

(webKitWebAudioSrcLoop):

1:11 AM Changeset in webkit [149020] by mrowe@apple.com
  • 6 edits
    6 copies in trunk

Roll depsHHHHChangeLogs.

1:09 AM Changeset in webkit [149019] by anilsson@rim.com
  • 5 edits in trunk/Source/WebCore

[BlackBerry] Remove the setContentsToColor flavor of LayerTiler::TextureJob
https://bugs.webkit.org/show_bug.cgi?id=115092

Reviewed by Carlos Garcia Campos.

With the Skia backend, we had an optimization to detect solid color
layers. The Skia code has been purged, but these bits remained. With
BlackBerry::Platform::Graphics::PlatformGraphicsContext, only the solid
color will be drawn anyway, so we don't need to detect such layers at
the WebCore level. Fixed by removing the setContentsToColor flavor of
LayerTiler::TextureJob.

BlackBerry::WebKit::WebOverlay still uses
TextureCacheCompositingThread::textureForColor() so that one can stay
for now.

This was dead code so no new tests.

  • platform/graphics/blackberry/LayerTile.cpp:
  • platform/graphics/blackberry/LayerTile.h:

(LayerTile):

  • platform/graphics/blackberry/LayerTiler.cpp:

(WebCore::LayerTiler::processTextureJob):
(WebCore::LayerTiler::performTileJob):

  • platform/graphics/blackberry/LayerTiler.h:

(WebCore::LayerTiler::TextureJob::setContents):
(TextureJob):

12:43 AM Changeset in webkit [149018] by zandobersek@gmail.com
  • 4 edits in trunk/Source

[GTK] Move image decoders, some other GStreamer, Cairo and Soup sources to libPlatform
https://bugs.webkit.org/show_bug.cgi?id=115050

Reviewed by Martin Robinson.

Source/Platform:

  • GNUmakefile.am: Add the image-decoders directory and its subdirectories to the list of header inclusion directories.

List the Cairo, GStreamer and Libsoup cppflags under the cppflags libPlatform uses for compiling its sources.

Source/WebCore:

No new tests - no new functionality.

  • GNUmakefile.list.am: Move the image decoders source files and a couple of GStreamer, Cairo and Libsoup source

files under the libPlatform's list of files to build. All of these are already free of platform layer violations.

12:25 AM Changeset in webkit [149017] by Claudio Saavedra
  • 3 edits in trunk/Source/WebKit2

Build break after r149004
https://bugs.webkit.org/show_bug.cgi?id=115091

Reviewed by Csaba Osztrogonác.

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::pageBackgroundTransparencyChanged):
(WebKit): Add dummy method for new virtual method.

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.h:

(LayerTreeHostGtk): Ditto.

Note: See TracTimeline for information about the timeline view.