Timeline
May 11, 2013:
- 11:15 PM Changeset in webkit [149951] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Unreviewed build fix after r149932
Patch by Brent Fulgham <Brent Fulgham> on 2013-05-11
- make-export-file-generator: Don't attempt to import
(or use) non-existent cxxabi functions on Windows.
- 10:39 PM Changeset in webkit [149950] by
-
- 2 edits in trunk/Source/WebCore
Add more info to compositing log channel output
https://bugs.webkit.org/show_bug.cgi?id=115978
Reviewed by Dean Jackson.
Add to compositing log channel output whether a layer paints
into its compositing ancestor.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::logLayerInfo):
- 9:54 PM Changeset in webkit [149949] by
-
- 4 edits4 adds in trunk
REGRESSION: Fixed background on ColterReed.com scrolls
https://bugs.webkit.org/show_bug.cgi?id=115951
Source/WebCore:
Reviewed by Beth Dakin.
The logic for painting the fixed root background into its own layer was
broken when the document element's layer was composited. This could be caused
by a negative z-index child of the body, or by an explicit compositing-causing
style on the <html>.
There were two issues. First, when painting the layer for the fixed root
background, we would simply short-circuit the fixed background paint in
RenderLayer::paintLayer(), when checking for a composited layer. We have
to continue to paint through the composited <html> layer to get the root
background in this case.
Secondly, RenderLayerBacking::paintIntoLayer() would only set the PaintLayerPaintingSkipRootBackground
flag if this RenderLayerBacking had a m_backgroundLayer. However, when the <html> is
composited, we need to skip painting the root layer for both the RenderView's backing,
and for the <html>'s backing. Checking whether there is *any* layer that paints
the fixed root background (i.e. checking compositor()->fixedRootBackgroundLayer())
is a simple way to fix this test.
Tests: platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-composited-html.html
platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-negative-z-index-fixed.html
- rendering/RenderLayer.cpp:
(WebCore::paintForFixedRootBackground):
(WebCore::RenderLayer::paintLayer):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintIntoLayer):
LayoutTests:
Reviewed by Beth Dakin.
Tests with a fixed background and two different ways of making the <html> composited.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-composited-html-expected.html: Added.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-composited-html.html: Added.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-negative-z-index-fixed-expected.html: Added.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-background-negative-z-index-fixed.html: Added.
- 9:28 PM Changeset in webkit [149948] by
-
- 2 edits in trunk/Source/WebCore
Possible crash when going Back while loading PDF
https://bugs.webkit.org/show_bug.cgi?id=115972
Reviewed by Dan Bernstein.
It's possible for m_frame to be null when Document::findUnsafeParentScrollPropagationBoundary()
is called, so null-check currentFrame.
- dom/Document.cpp:
(WebCore::Document::findUnsafeParentScrollPropagationBoundary):
- 5:53 PM Changeset in webkit [149947] by
-
- 3 edits in trunk/Source/WebCore
<rdar://problem/13823864> TextCodecICU complains about ambiguous codec names with current ICU release
https://bugs.webkit.org/show_bug.cgi?id=115953
Reviewed by Darin Adler.
Store and use canonical converter name to create converters.
As a side effect, we now actually reuse cached converters - previously we would compare
a standard encoding name to internal canonical one, which rarely match.
- platform/text/TextCodecICU.h:
- platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::create): Pass canonical ICU converter name to constructor.
(WebCore::TextCodecICU::registerEncodingNames):
- Updated terminology.
- Added a comment that special cases should be kept in sync between registerEncodingNames and registerCodecs.
- Moved maccyrillic alias to a correct section. It's not present in ICU even today.
- Changed a few aliases to actually map to standard name, not to an overridden one (this doesn't change behavior since addToTextEncodingNameMap looks up canonical name, but is clearer).
(WebCore::TextCodecICU::registerCodecs): Store a converter name to use with each
canonical encoding name.
(WebCore::TextCodecICU::TextCodecICU): Ditto.
(WebCore::TextCodecICU::releaseICUConverter): Reset the converter to remove any
leftover data.
(WebCore::TextCodecICU::createICUConverter):
- Compare converter name to converter name, not to another alias name.
- Use proper string comparison instead of pointer comparison.
- When creating a converter, assert that the name is not ambigous - canonical converter names should never be, otherwise there would be no way to create the converter without ambiguity.
- 5:26 PM Changeset in webkit [149946] by
-
- 6 edits2 adds2 deletes in branches/dfgFourthTier/Source/JavaScriptCore
Rename StructureCheckHoistingPhase to TypeCheckHoistingPhase
https://bugs.webkit.org/show_bug.cgi?id=115938
We're going to add some more types of check hoisting soon, so let's have
the right name here.
Rubber stamped by Filip Pizlo.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGStructureCheckHoistingPhase.cpp: Removed.
- dfg/DFGStructureCheckHoistingPhase.h: Removed.
- dfg/DFGTypeCheckHoistingPhase.cpp: Added.
(DFG):
(TypeCheckHoistingPhase):
(JSC::DFG::TypeCheckHoistingPhase::TypeCheckHoistingPhase):
(JSC::DFG::TypeCheckHoistingPhase::run):
(JSC::DFG::TypeCheckHoistingPhase::shouldConsiderForHoisting):
(JSC::DFG::TypeCheckHoistingPhase::noticeStructureCheck):
(CheckData):
(JSC::DFG::TypeCheckHoistingPhase::CheckData::CheckData):
(JSC::DFG::performTypeCheckHoisting):
- dfg/DFGTypeCheckHoistingPhase.h: Added.
- 4:42 PM Changeset in webkit [149945] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix after r149944.
- Platform/CoreIPC/ArgumentEncoder.cpp: Include <sys/mman.h> for mmap(2).
- 4:28 PM Changeset in webkit [149944] by
-
- 3 edits in trunk/Source/WebKit2
Don't pass malloced pointers as out-of-line data when sending Mach messages
https://bugs.webkit.org/show_bug.cgi?id=115970
<rdar://problem/13144680>
Reviewed by Sam Weinig.
Give ArgumentEncoder an inline buffer of 512 bytes. If we need more than that, use mmap to allocate data
since that gives us fresh zero-filled memory that we can safely share.
- Platform/CoreIPC/ArgumentEncoder.cpp:
(CoreIPC::ArgumentEncoder::ArgumentEncoder):
Set up the buffer pointers to point to the inline buffer.
(CoreIPC::ArgumentEncoder::~ArgumentEncoder):
Unmap the buffer if necessary.
(CoreIPC::ArgumentEncoder::grow):
Grow the allocation exponentially, rounded up to the nearest page. This is a simplification from the
current strategy, but most messages are either tiny in which case they will fit inside the inline buffer,
or big in which case we'll end up doing less allocations + memory copying.
- Platform/CoreIPC/ArgumentEncoder.h:
(ArgumentEncoder):
- 4:26 PM Changeset in webkit [149943] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
SpeculativeJIT::checkArray should use the correct ExitKind
https://bugs.webkit.org/show_bug.cgi?id=115943
Currently it uses Uncountable, which gives us no information if we end up exiting due to a
mismatched ClassInfo pointer. It should instead use BadType and should pass the correct
JSValueSource and Node instead of passing empty values.
Reviewed by Filip Pizlo.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::checkArray):
- 2:42 PM Changeset in webkit [149942] by
-
- 3 edits in trunk/Source/WebCore
[Mac] The captions menu should not use a canned max-width and max-height
https://bugs.webkit.org/show_bug.cgi?id=115968
Reviewed by Eric Carlson.
Use more real estate to display the captions menu should the caption names
be long.
- css/mediaControlsQuickTime.css:
(video::-webkit-media-controls-closed-captions-container):
(video::-webkit-media-controls-closed-captions-track-list):
Make the captions menu scale to a max-width and max-height to allow 4px
above and below the menu, except on the right where it always aligns with
the captions icon in the media controller.
- html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::createControls):
Move the captions menu element to be a child of the controls instead of
the panel such that it may scale relative to the controls when using %
CSS values.
- 2:07 PM Changeset in webkit [149941] by
-
- 5 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support Jump and ForceOSRExit
https://bugs.webkit.org/show_bug.cgi?id=115942
Reviewed by Oliver Hunt.
Added two obvious nodes: Jump and ForceOSRExit. We already had everything we needed
to support them.
Adding these increases our coverage a fair bit, and revealed a bug: LLVM's full
instruction selector currently appears to mishandle doubles in constant pools (or
just constant pools in general) with the small code model in the MCJIT. But switching
to FastISel "fixes" it. That's what this patch does, for now. This will probably
actually be permanent; the FastISel does pretty much everything we would ever want,
at least in the foreseeable future.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
(FTL):
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileJSConstant):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileJump):
(JSC::FTL::LowerDFGToLLVM::compileReturn):
(JSC::FTL::LowerDFGToLLVM::compileForceOSRExit):
- runtime/Options.h:
(JSC):
- 1:57 PM Changeset in webkit [149940] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed GTK build fix after r149904.
- GNUmakefile.list.am: Adding missing build targets.
- 1:08 PM Changeset in webkit [149939] by
-
- 2 edits in trunk/LayoutTests
Bogus -webkit-columns value in fast/text/international/spaces-combined-in-vertical-text.html
https://bugs.webkit.org/show_bug.cgi?id=115164
Patch by Xan Lopez <xlopez@igalia.com> on 2013-05-11
Reviewed by Rob Buis.
Remove bogus -webkit-columns property.
- fast/text/international/spaces-combined-in-vertical-text.html:
- 1:07 PM Changeset in webkit [149938] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, Fix WK2 EFL build after r149904.
Add new PluginInformation.cpp file to CMake.
- CMakeLists.txt:
- 12:47 PM Changeset in webkit [149937] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, fix WK2 EFL build after r149904.
Add new WKPluginInformation.cpp file to CMake.
- CMakeLists.txt:
- 12:09 PM Changeset in webkit [149936] by
-
- 5 edits2 adds in trunk
Disallow a window to focus itself via javascript URLs or using target _self
https://bugs.webkit.org/show_bug.cgi?id=115906
Reviewed by Geoffrey Garen.
Source/WebCore:
Test: fast/dom/Window/window-focus-self.html
- loader/FrameLoader.cpp:
(WebCore::createWindow):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::focus):
LayoutTests:
- fast/dom/Window/window-focus-self-expected.txt: Added.
- fast/dom/Window/window-focus-self.html: Added.
- platform/wk2/TestExpectations: test uses unimplemented setWindowIsKey.
- 12:07 PM Changeset in webkit [149935] by
-
- 58 edits in trunk/Source/WebCore
Fix several style warnings in generated bindings
https://bugs.webkit.org/show_bug.cgi?id=115961
Reviewed by Kentaro Hara.
Fix several style errors in the bindings generated under
Source/WebCore/bindings/scripts/test/
No new tests, no behavior change.
- bindings/scripts/CodeGeneratorCPP.pm:
(GenerateImplementation):
(WriteData):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
(WriteData):
- bindings/scripts/CodeGeneratorObjC.pm:
(GenerateHeader):
- bindings/scripts/test/CPP/WebDOMFloat64Array.cpp:
- bindings/scripts/test/CPP/WebDOMTestActiveDOMObject.cpp:
- bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
- bindings/scripts/test/CPP/WebDOMTestCustomNamedGetter.cpp:
- bindings/scripts/test/CPP/WebDOMTestEventConstructor.cpp:
- bindings/scripts/test/CPP/WebDOMTestEventTarget.cpp:
- bindings/scripts/test/CPP/WebDOMTestException.cpp:
- bindings/scripts/test/CPP/WebDOMTestInterface.cpp:
- bindings/scripts/test/CPP/WebDOMTestMediaQueryListListener.cpp:
- bindings/scripts/test/CPP/WebDOMTestNamedConstructor.cpp:
- bindings/scripts/test/CPP/WebDOMTestNode.cpp:
- bindings/scripts/test/CPP/WebDOMTestObj.cpp:
- bindings/scripts/test/CPP/WebDOMTestOverloadedConstructors.cpp:
- bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp:
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestActiveDOMObject.h:
(WebCore::JSTestActiveDOMObject::releaseImplIfNotNull):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
(WebCore::JSTestCustomNamedGetter::releaseImplIfNotNull):
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestEventConstructor.h:
(WebCore::JSTestEventConstructor::releaseImplIfNotNull):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestEventTarget.h:
(WebCore::JSTestEventTarget::releaseImplIfNotNull):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestException.h:
(WebCore::JSTestException::releaseImplIfNotNull):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestInterface.h:
(WebCore::JSTestInterface::releaseImplIfNotNull):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
(WebCore::JSTestMediaQueryListListener::releaseImplIfNotNull):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestNamedConstructor.h:
(WebCore::JSTestNamedConstructor::releaseImplIfNotNull):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestObj.h:
(WebCore::JSTestObj::releaseImplIfNotNull):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
(WebCore::JSTestOverloadedConstructors::releaseImplIfNotNull):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(WebCore::JSTestSerializedScriptValueInterface::releaseImplIfNotNull):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::toJS):
- bindings/scripts/test/JS/JSTestTypedefs.h:
(WebCore::JSTestTypedefs::releaseImplIfNotNull):
- bindings/scripts/test/ObjC/DOMFloat64ArrayInternal.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestActiveDOMObjectInternal.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestCallbackInternal.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestCustomNamedGetterInternal.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestEventConstructorInternal.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestEventTargetInternal.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestExceptionInternal.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestInterfaceInternal.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestMediaQueryListListenerInternal.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestNamedConstructorInternal.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestNodeInternal.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestObjInternal.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestOverloadedConstructorsInternal.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterfaceInternal.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestTypedefsInternal.h:
(WebCore):
- 11:53 AM Changeset in webkit [149934] by
-
- 3 edits in trunk/Source/WebKit2
When possible, terminate web processes immediately when closing their last page.
<http://webkit.org/b/115964>
<rdar://problem/13869266>
Reviewed by Geoffrey Garen.
When we're using a network process, there's no need for the UI process to wait for web processes
to clear resource caches and terminate nicely.
We can just kill them off right away in WebProcessProxy::removeWebPage() when the last page is closed.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::removeWebPage):
Terminate the child process immediately if possible.
- UIProcess/WebProcessProxy.h:
(WebKit::WebProcessProxy::canTerminateChildProcess):
(WebKit::WebProcessProxy::shouldTerminate):
Broke out the logic from the shouldTerminate() IPC message handler into a separate function
so we can call it from removeWebPage().
- 11:00 AM Changeset in webkit [149933] by
-
- 8 edits1 add in trunk
Crash when terminating a process that has not been fully launched
https://bugs.webkit.org/show_bug.cgi?id=115962
<rdar://problem/13660916>
Reviewed by Andreas Kling.
Source/WebKit2:
Handle terminating a process that has not been fully launched.
- UIProcess/Launcher/ProcessLauncher.cpp:
(WebKit::ProcessLauncher::didFinishLaunchingProcess):
If we have been invalidated, dispose the connection identifier.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::terminateProcess):
If we're still launching the process, invalidate so the client won't get an unexpected
didFinishLaunching callback.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::requestTermination):
Check if webConnection() is null before calling it. (It will be null if the process isn't fully launched).
Tools:
Add TerminateTwice, a test that terminates a page, then reloads it and terminates it again
before the process has had a chance to be fully launched.
- TestWebKitAPI/GNUmakefile.am:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/TerminateTwice.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/WebKit2.pro:
- 9:09 AM Changeset in webkit [149932] by
-
- 2 edits in trunk/Source/WebCore
Make it a build error to put invalid C++ symbol names in WebCore.exp.in
https://bugs.webkit.org/show_bug.cgi?id=115958
Reviewed by Andreas Kling.
While invalid C++ symbols will eventually show up as a link error since the symbol won't be found,
this makes it easier to catch invalid symbols inside of #ifdefs.
- make-export-file-generator:
Try to demangle C++ symbols before printing them.
- 7:09 AM Changeset in webkit [149931] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX (r149718): Move exported symbol into ENABLE(FULLSCREEN_API) section
Fixes the following build failure when ENABLE(FULLSCREEN_API) is
off:
Undefined symbols for architecture i386:
"ZNK7WebCore7Element25containsFullScreenElementEv", referenced from:
-exported_symbol[s_list] command line option
- WebCore.exp.in: Move the symbol.
- 5:14 AM Changeset in webkit [149930] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, remove some lint accidentally left in r149929.
- rendering/InlineFlowBox.cpp:
(WebCore::verticalAlignApplies):
- 5:08 AM Changeset in webkit [149929] by
-
- 5 edits2 adds in trunk
Text flow broken in elements with vertical align top/bottom and inline elements taller than line-height
https://bugs.webkit.org/show_bug.cgi?id=111974
Source/WebCore:
Reviewed by Ryosuke Niwa.
Per http://www.w3.org/TR/CSS2/visudet.html#propdef-vertical-align 'vertical-align' only applies to inline and table-cell
elements.
Test: fast/css/vertical-align-block-elements.html
- rendering/InlineFlowBox.cpp:
(WebCore::isTextInBlockElement):
(WebCore):
(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
LayoutTests:
Reviewed by Ryosuke Niwa.
- editing/execCommand/query-command-state-expected.txt:
- editing/execCommand/script-tests/query-command-state.js: Remove invalid tests, vertical-align does not apply to div elements.
(runTests):
- fast/css/vertical-align-block-elements-expected.html: Added.
- fast/css/vertical-align-block-elements.html: Added.
- 1:36 AM Changeset in webkit [149928] by
-
- 7 edits in trunk/Source/WebCore
Make CanvasStyle a plain object instead of an RefCounted object
https://bugs.webkit.org/show_bug.cgi?id=115775
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-11
Reviewed by Andreas Kling.
CanvasStyle is just 2 words wide. We do not gain anything from allocating
it on the heap. Change the object to be just a type and some data.
- bindings/js/JSCanvasRenderingContext2DCustom.cpp:
(WebCore::toJS):
(WebCore::toHTMLCanvasStyle):
- html/HTMLCanvasElement.cpp:
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::setStrokeStyle):
(WebCore::CanvasRenderingContext2D::setFillStyle):
(WebCore::CanvasRenderingContext2D::setStrokeColor):
(WebCore::CanvasRenderingContext2D::setFillColor):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
- html/canvas/CanvasRenderingContext2D.h:
(WebCore::CanvasRenderingContext2D::strokeStyle):
(CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::fillStyle):
(State):
- html/canvas/CanvasStyle.cpp:
(WebCore::CanvasStyle::CanvasStyle):
(WebCore::CanvasStyle::createFromString):
(WebCore::CanvasStyle::createFromStringWithOverrideAlpha):
(WebCore::CanvasStyle::isEquivalentColor):
(WebCore):
(WebCore::CanvasStyle::operator=):
(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):
- html/canvas/CanvasStyle.h:
(CanvasStyle):
(WebCore::CanvasStyle::isValid):
(WebCore::CanvasStyle::CanvasStyle):
(WebCore):
(WebCore::CanvasStyle::operator=):
- 12:56 AM Changeset in webkit [149927] by
-
- 2 edits in trunk/Source/WebCore
Gradient::platformGradient: Vector reserveCapacity -> reserveInitialCapacity
https://bugs.webkit.org/show_bug.cgi?id=115779
Reviewed by Andreas Kling.
- platform/graphics/cg/GradientCG.cpp:
(WebCore::Gradient::platformGradient): Clang is surprisingly smart at removing
all the branches of this function. Remove two more with reserveInitialCapacity.
- 12:47 AM Changeset in webkit [149926] by
-
- 2 edits in trunk/Websites/planet.webkit.org
Remove irrelevant blogs from Planet WebKit
https://bugs.webkit.org/show_bug.cgi?id=115620
Reviewed by Ryosuke Niwa.
- config.ini:
May 10, 2013:
- 10:51 PM Changeset in webkit [149925] by
-
- 8 edits2 adds3 deletes in trunk
<rdar://problem/13666412> Clean up some edge cases of URL parsing.
https://bugs.webkit.org/show_bug.cgi?id=104919
Reviewed by Darin Adler.
WebCore:
- page/SecurityOrigin.cpp: (WebCore::schemeRequiresHost): (WebCore::shouldTreatAsUniqueOrigin): Updated function name and comments (host is not the same as authority). We still need this check - KURL can still produce http URLs with an empty host (even as this patch reduces the number of such cases). So can Gecko and current draft of URL Standard. It would be good to have a guarantee that such useless URLs can not come out of URL parser, as relying on downstream code re-parsing the URL correctly would be fragile.
- platform/KURL.cpp: (WebCore::hostPortIsEmptyButCredentialsArePresent): Updated an argument name for correctness. (WebCore::KURL::parse):
- Reverted behavior changes from <http://trac.webkit.org/changeset/82181> - I could find no reason to allow "@" in hostnames, and having a URL like this re-parsed by a different parser would likely produce different results. It's better to just treat these edge case URLs as invalid.
- When hostname component is a lone colon, preserve it in parsed URL string, as otherwise path would get pushed in its place when re-parsing.
- When authority component is a lone colon, don't forget to "" after scheme, too.
- Added some assertions about contents of authority component, to catch potential mis-parsing earlier.
LayoutTests:
- fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-pathname.js:
- fast/dom/HTMLAnchorElement/set-href-attribute-pathname-expected.txt: Updated expectations of one sub-test. We previously tried to keep the test passing as is (see bug 57291), but I couldn't find any reason to prefer the old behavior.
- fast/url/host-expected.txt:
- fast/url/host.html: Updated one subtest to new results, which match at least Gecko (original of the test actually claims that all browsers including Safari already do what we'll do now).
- fast/url/segments-userinfo-vs-host-expected.txt: Added.
- fast/url/segments-userinfo-vs-host.html: Added. Added a number of tests, with detailed explanations of the differences with Firefox, and with rationales.
- http/tests/uri/username-with-no-hostname-expected.txt: Removed.
- http/tests/uri/username-with-no-hostname.html-disabled: Removed.
- platform/win/http/tests/uri/username-with-no-hostname-expected.txt: Removed. This test has been disabled for a long time, and being an end-to-end test for invalid URL handling, it would be difficult to make work again. We have multiple parsing tests for URLs like this.
- 10:45 PM Changeset in webkit [149924] by
-
- 3 edits in trunk/Source/WebCore
Make TextCodecICU not depend on TextEncoding
https://bugs.webkit.org/show_bug.cgi?id=115848
Reviewed by Darin Adler.
- platform/text/TextCodecICU.cpp: (WebCore::TextCodecICU::create): (WebCore::TextCodecICU::TextCodecICU): (WebCore::TextCodecICU::createICUConverter): (WebCore::TextCodecICU::decode): (WebCore::TextCodecICU::encode):
- platform/text/TextCodecICU.h: Use a plain encoding string in platform encoder wrapper, not a higher level concept.
- 10:03 PM Changeset in webkit [149923] by
-
- 20 edits in trunk/Source
Web Inspector: Implement WK2 version of WebInspectorFrontendClient::save
https://bugs.webkit.org/show_bug.cgi?id=115564
Patch by Brian J. Burg <Brian Burg> on 2013-05-10
Reviewed by Benjamin Poulain.
Source/WebKit/mac:
Clean up save() and append() implementations.
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorFrontendClient::save):
(WebInspectorFrontendClient::append):
Source/WebKit2:
Implement InspectorFrontendHost's save() and append() methods for
Mac WebKit2. Add canSave() for all ports.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::save):
(WebKit):
(WebKit::WebInspectorProxy::append):
- UIProcess/WebInspectorProxy.h:
(WebInspectorProxy):
- UIProcess/WebInspectorProxy.messages.in:
- UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformSave):
(WebKit):
(WebKit::WebInspectorProxy::platformAppend):
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformSave):
(WebKit):
(WebKit::WebInspectorProxy::platformAppend):
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformSave):
(WebKit):
(WebKit::WebInspectorProxy::platformAppend):
- UIProcess/qt/WebInspectorProxyQt.cpp:
(WebKit::WebInspectorProxy::platformSave):
(WebKit):
(WebKit::WebInspectorProxy::platformAppend):
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::canSave):
(WebKit):
(WebKit::WebInspectorFrontendClient::save):
(WebKit::WebInspectorFrontendClient::append):
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
(WebInspectorFrontendClient):
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::save):
(WebKit):
(WebKit::WebInspector::append):
(WebKit::WebInspector::didSave):
(WebKit::WebInspector::didAppend):
- WebProcess/WebPage/WebInspector.h:
(WebInspector):
- WebProcess/WebPage/WebInspector.messages.in:
- WebProcess/WebPage/efl/WebInspectorEfl.cpp:
(WebKit::WebInspector::canSave):
(WebKit):
- WebProcess/WebPage/gtk/WebInspectorGtk.cpp:
(WebKit::WebInspector::canSave):
(WebKit):
- WebProcess/WebPage/mac/WebInspectorMac.mm:
(WebKit::WebInspector::canSave):
(WebKit):
- WebProcess/WebPage/qt/WebInspectorQt.cpp:
(WebKit::WebInspector::canSave):
(WebKit):
- 6:59 PM Changeset in webkit [149922] by
-
- 18 edits in trunk
Remove Mac OS X Leopard (10.5) support
https://bugs.webkit.org/show_bug.cgi?id=107964
Reviewed by Ryosuke Niwa.
Removed the code for 10.5 and removed if-def for 10.6.
Source/WebCore:
No new tests, covered by existing tests.
- platform/LocalizedStrings.cpp:
(WebCore::contextMenuItemTagLookUpInDictionary):
- platform/graphics/cg/GraphicsContextCG.cpp:
- platform/mac/EmptyProtocolDefinitions.h:
- platform/mac/NSScrollerImpDetails.h:
- platform/mac/WebCoreSystemInterface.h:
- platform/text/mac/HyphenationMac.mm:
Source/WebKit/mac:
- DefaultDelegates/WebDefaultContextMenuDelegate.mm:
- Misc/WebKitErrors.m:
(-[NSError _initWithPluginErrorCode:contentURL:pluginPageURL:pluginName:MIMEType:]):
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- WebView/WebClipView.mm:
(-[WebClipView _immediateScrollToPoint:]):
- WebView/WebFrameView.mm:
(-[WebFrameView initWithFrame:]):
- WebView/WebView.mm:
Tools:
- DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
(convertMIMEType):
(createXMLStringFromWebArchiveData):
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::authenticateSession):
(TestRunner::setTextDirection):
- WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
(convertMIMEType):
(createXMLStringFromWebArchiveData):
- 6:27 PM Changeset in webkit [149921] by
-
- 16 edits in trunk/Source
Remove USE(OS_RANDOMNESS)
https://bugs.webkit.org/show_bug.cgi?id=108095
Reviewed by Darin Adler.
Remove the USE(OS_RANDOMNESS) guard as it is turned on for all
ports.
Source/JavaScriptCore:
- jit/JIT.cpp:
(JSC::JIT::JIT):
Source/WebCore:
No new tests as this is covered by existing tests.
- page/Crypto.cpp:
(WebCore::Crypto::getRandomValues):
- platform/UUID.cpp:
(WebCore::createCanonicalUUIDString):
Source/WebKit/blackberry:
- WebCoreSupport/AboutDataUseFeatures.in:
Source/WTF:
- wtf/CryptographicallyRandomNumber.cpp:
(WTF::cryptographicallyRandomValues):
- wtf/CryptographicallyRandomNumber.h:
- wtf/OSRandomSource.cpp:
(WTF::cryptographicallyRandomValuesFromOS):
- wtf/OSRandomSource.h:
- wtf/Platform.h:
- wtf/RandomNumber.cpp:
(WTF::randomNumber):
- wtf/RandomNumber.h:
- wtf/RandomNumberSeed.h:
(WTF::initializeRandomNumberGenerator):
- 6:24 PM Changeset in webkit [149920] by
-
- 25 edits in trunk
Remove [NoInterfaceObject] from several WebAudio IDL interfaces
https://bugs.webkit.org/show_bug.cgi?id=115894
Reviewed by Darin Adler.
Source/WebCore:
Several WebAudio IDL interfaces had [NoInterfaceObject] extended attribute set,
meaning that there was no corresponding attribute on the global window object.
This behavior is not according to the specification:
https://dvcs.w3.org/hg/audio/raw-file/tip/webaudio/specification.html
This patch removes the [NoInterfaceObject] extended attribute where needed to
match the specification.
No new tests, already covered by existing tests.
- Modules/webaudio/AnalyserNode.idl:
- Modules/webaudio/AudioBuffer.idl:
- Modules/webaudio/AudioBufferSourceNode.idl:
- Modules/webaudio/AudioDestinationNode.idl:
- Modules/webaudio/AudioListener.idl:
- Modules/webaudio/AudioNode.idl:
- Modules/webaudio/AudioParam.idl:
- Modules/webaudio/BiquadFilterNode.idl:
- Modules/webaudio/ChannelMergerNode.idl:
- Modules/webaudio/ChannelSplitterNode.idl:
- Modules/webaudio/ConvolverNode.idl:
- Modules/webaudio/DelayNode.idl:
- Modules/webaudio/DynamicsCompressorNode.idl:
- Modules/webaudio/GainNode.idl:
- Modules/webaudio/MediaElementAudioSourceNode.idl:
- Modules/webaudio/MediaStreamAudioDestinationNode.idl:
- Modules/webaudio/MediaStreamAudioSourceNode.idl:
- Modules/webaudio/OscillatorNode.idl:
- Modules/webaudio/ScriptProcessorNode.idl:
- Modules/webaudio/WaveShaperNode.idl:
- Modules/webaudio/WaveTable.idl:
LayoutTests:
Rebaseline fast/js/global-constructors-attributes.html now that more
global constructors are exposed.
- fast/js/global-constructors-attributes-expected.txt:
- platform/efl/fast/js/global-constructors-attributes-expected.txt:
- 6:23 PM Changeset in webkit [149919] by
-
- 2 edits in trunk/Source/WebKit2
Copy WKPluginInformation.h header to the WebKit2 Framework private headers.
https://bugs.webkit.org/show_bug.cgi?id=115940
Patch by Remy Demarest <rdemarest@apple.com> on 2013-05-10
Reviewed by Darin Adler.
- WebKit2.xcodeproj/project.pbxproj:
Move WKPluginInformation.h file from the framework's Project Headers to
Private Headers.
- 5:59 PM Changeset in webkit [149918] by
-
- 3 edits2 adds in trunk
REGRESSION (r145680): No box shadow rendered on element with positioned child that obscures it
https://bugs.webkit.org/show_bug.cgi?id=115840
Source/WebCore:
Reviewed by Antti Koivisto.
In r107836, we moved some box-shadow painting into the paintFillLayer code for performance.
However, in r145680 we started to skip background painting when we know the background is
obscured. This broke shadow painting in some cases.
Fix by always painting the background fill layers if we know that they will also
paint the shadow.
Test: fast/box-shadow/box-shadow-obscured-backgrounds.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBackground):
LayoutTests:
Reviewed by Antti Koivisto.
- fast/box-shadow/box-shadow-obscured-backgrounds-expected.html: Added.
- fast/box-shadow/box-shadow-obscured-backgrounds.html: Added.
- 5:52 PM Changeset in webkit [149917] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][Mac] Unreviewed. Roll out the fix attempt in r149912.
- Target.pri:
- 5:46 PM Changeset in webkit [149916] by
-
- 3 edits1 add in trunk/Tools
[Windows] Allow VS2010 Build to use VS2005 Support Libraries
https://bugs.webkit.org/show_bug.cgi?id=115935
Reviewed by Jer Noble.
- WinLauncher/WinLauncher.vcxproj/WinLauncher.exe.manifest: Added.
- WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj: Add reference
to the new manifest file.
- WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.filters: Ditto.
- 5:32 PM Changeset in webkit [149915] by
-
- 3 edits4 adds in trunk
REGRESSION (r143626): Element shows as garbage in image gallery
https://bugs.webkit.org/show_bug.cgi?id=115946
Source/WebCore:
Reviewed by Antti Koivisto.
RenderLayer::backgroundIsKnownToBeOpaqueInRect() used hasVisibleContent()
to check whether the layer's content was hidden via the visibility property.
However, this assumed that a passing hasVisibleContent() check meant that the
entire area was covered by the renderers and layers checked layer.
This is not always true. It's possible to have a visibility:hidden layer
with a non-covering visbility:visible child, or even a single RenderText
child that happens to have visibility:visible style. In these situations,
hasVisibleContent() returns true but the entire area is not painted.
So we have to fall back to on a more conservative check using the
visibility style, which will give is a reliable answer for the current layer.
Tests: compositing/contents-opaque/hidden-with-visible-child.html
compositing/contents-opaque/hidden-with-visible-text.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):
LayoutTests:
Reviewed by Antti Koivisto.
Test that dumps layers for a visibility:hidden element with a child text node,
and with a visibility:visible child. The resulting compositing layer should
not be marked as opaque.
- compositing/contents-opaque/hidden-with-visible-child-expected.txt: Added.
- compositing/contents-opaque/hidden-with-visible-child.html: Added.
- compositing/contents-opaque/hidden-with-visible-text-expected.txt: Added.
- compositing/contents-opaque/hidden-with-visible-text.html: Added.
- 5:31 PM Changeset in webkit [149914] by
-
- 3 edits2 adds in trunk
Garbage down left side of nytimes.com page (if subscriber)
https://bugs.webkit.org/show_bug.cgi?id=115839
Source/WebCore:
Reviewed by Antti Koivisto.
RenderLayer::backgroundIsKnownToBeOpaqueInRect() would incorrectly return true
for layers where the given rect wasn't contained in the background rect, but
where some child layer obscured the rect, even though clipping hid part
of that child layer.
So bail from RenderLayer::backgroundIsKnownToBeOpaqueInRect() if we have
any overflow clipping. This could be enhanced in future to test whether child
layers obscure the clipping rect, but that would be more expensive.
Test: compositing/contents-opaque/overflow-hidden-child-layers.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):
LayoutTests:
Reviewed by Antti Koivisto.
- compositing/contents-opaque/overflow-hidden-child-layers-expected.txt: Added.
- compositing/contents-opaque/overflow-hidden-child-layers.html: Added.
- 4:42 PM Changeset in webkit [149913] by
-
- 2 edits in trunk/Source/WebKit2
Fix AppleConnect issues for WiFi interfaces
<rdar://problem/13776227&13776240&13776281>
https://bugs.webkit.org/show_bug.cgi?id=115932
Patch by Simon Cooper <scooper@apple.com> on 2013-05-10
Reviewed by Alexey Proskuryakov.
Add support for WiFi interfaces for the AppleConnect plugin.
Remove the FIXME.
- Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb:
- 4:36 PM Changeset in webkit [149912] by
-
- 2 edits in trunk/Source/WebKit2
[Qt][Mac] Unreviewed speculative build fix after r149904.
- Target.pri:
- 4:15 PM Changeset in webkit [149911] by
-
- 8 edits2 adds in trunk/Source/JavaScriptCore
Rename StructureCheckHoistingPhase to TypeCheckHoistingPhase
https://bugs.webkit.org/show_bug.cgi?id=115938
We're going to add some more types of check hoisting soon, so let's have the right name here.
Rubber stamped by Filip Pizlo.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- dfg/DFGDriver.cpp:
(JSC::DFG::compile):
- dfg/DFGStructureCheckHoistingPhase.cpp: Removed.
- dfg/DFGStructureCheckHoistingPhase.h: Removed.
- dfg/DFGTypeCheckHoistingPhase.cpp: Copied from Source/JavaScriptCore/dfg/DFGStructureCheckHoistingPhase.cpp.
(JSC::DFG::TypeCheckHoistingPhase::TypeCheckHoistingPhase):
(JSC::DFG::performTypeCheckHoisting):
- dfg/DFGTypeCheckHoistingPhase.h: Copied from Source/JavaScriptCore/dfg/DFGStructureCheckHoistingPhase.h.
- 3:56 PM Changeset in webkit [149910] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support CompareStrictEqConstant
https://bugs.webkit.org/show_bug.cgi?id=115941
Reviewed by Mark Hahnenberg.
Pretty simple, but factors out the craziness of comparing against null or undefined
in a way that is reusable for both == and ===.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCompareEqConstant):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEqConstant):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::equalNullOrUndefined):
- 3:50 PM Changeset in webkit [149909] by
-
- 2 edits in trunk/Source/WebKit2
[Qt] Unreviewed buildfix after r149904.
- Target.pri:
- 3:22 PM Changeset in webkit [149908] by
-
- 7 edits2 adds in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support CompareEqConstant
https://bugs.webkit.org/show_bug.cgi?id=115939
Reviewed by Oliver Hunt and Mark Hahnenberg.
The most interesting part of this patch is the way I make it easier to deal with
the inputs to Phi functions. This adds the notion of ValueFromBlock, which you
can get by doing m_out.anchor(value). You can build up a vector of these, and then
pass them to m_out.phi(type, vector) in one go.
- JavaScriptCore.xcodeproj/project.pbxproj:
- ftl/FTLAbbreviatedTypes.h: Added.
(FTL):
- ftl/FTLAbbreviations.h:
(FTL):
(JSC::FTL::addIncoming):
(JSC::FTL::buildPhi):
- ftl/FTLAbstractHeapRepository.h:
(FTL):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCompareEqConstant):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lowDouble):
(JSC::FTL::LowerDFGToLLVM::masqueradesAsUndefinedWatchpointIfIsStillValid):
- ftl/FTLOutput.h:
(JSC::FTL::Output::phi):
(Output):
(JSC::FTL::Output::anchor):
- ftl/FTLValueFromBlock.h: Added.
(FTL):
(ValueFromBlock):
(JSC::FTL::ValueFromBlock::ValueFromBlock):
(JSC::FTL::ValueFromBlock::value):
(JSC::FTL::ValueFromBlock::block):
- 2:28 PM Changeset in webkit [149907] by
-
- 5 edits in trunk
Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790
Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-05-10.
Reviewed by Rob Buis.
Source/WebKit/blackberry:
Fix the following warnings for BlackBerry:
BackingStore.cpp:852:60: warning: suggest parentheses around '&&' within
' ' [-Wparentheses]. WebPage.cpp:2858:40: warning: suggest parentheses around assignment used
as truth value [-Wparentheses].
WebPage.cpp:2880:42: warning: suggest parentheses around assignment used
as truth value [-Wparentheses]
- Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::updateTilesAfterBackingStoreRectChange):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::adjustRectOffsetForFrameOffset):
(BlackBerry::WebKit::WebPagePrivate::blockZoomRectForNode):
Tools:
Fix the following warnings for BlackBerry:
DumpRenderTree.cpp:357:42: warning: suggest parentheses around assignment
used as truth value [-Wparentheses].
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
- 2:11 PM Changeset in webkit [149906] by
-
- 8 edits2 adds in trunk
In-band captions not visible immediately after track mode change
https://bugs.webkit.org/show_bug.cgi?id=115922
Reviewed by Dean Jackson.
Source/WebCore:
Test: media/track/track-in-band-mode.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTrackModeChanged): Add cues for all loaded tracks, regardless
of track type.
LayoutTests:
- media/track/track-in-band-mode-expected.txt: Added.
- media/track/track-in-band-mode.html: Added.
- platform/efl/TestExpectations: Skip new test.
- platform/gtk/TestExpectations: Ditto.
- platform/mac/TestExpectations: Ditto.
- platform/qt/TestExpectations: Ditto.
- platform/win/TestExpectations: Ditto.
- 1:54 PM Changeset in webkit [149905] by
-
- 3 edits in trunk/Source/WebCore
Web Inspector: determine the resource type in InspectorResourceAgent::willSendRequest.
This allows the Network timeline and Resources sidebar to filter Resources earlier,
before the server sends a response. Useful for long polling (comet) XHRs.
https://webkit.org/b/74935
rdar://problem/13726105
Reviewed by Joseph Pecoraro.
- inspector/Inspector.json:
(Network.requestWillBeSent): Added.
- inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::willSendRequest): Send the type if it isn't Other along in requestWillBeSent.
(WebCore::InspectorResourceAgent::didReceiveResponse): Don't determine the type here anymore. Clear the CachedResource
if isNotModified like the old code path did by not setting cachedResource if !isNotModified.
- 1:46 PM Changeset in webkit [149904] by
-
- 12 edits5 adds in trunk/Source/WebKit2
Unify plug-in information dictionaries
<rdar://problem/13852080>
https://bugs.webkit.org/show_bug.cgi?id=115891
Reviewed by Anders Carlsson.
This unifies the plug-in information dictionaries vended by WKContextCopyPlugInInfoForBundleIdentifier
and WKContextGetInfoForInstalledPlugIns with those from the WKPageLoaderClient and WKPageUIClient.
All the old keys will continue to work, but have been deprecated in favor of new keys defined in
WKPluginInformation.h
- Shared/API/c/WKPluginInformation.cpp: Added.
- Shared/API/c/WKPluginInformation.h: Added.
Export new keys as SPI.
- Shared/Plugins/Netscape/PluginInformation.h: Added.
- Shared/Plugins/Netscape/PluginInformation.cpp: Added.
(WebKit::pluginInformationBundleIdentifierKey):
(WebKit::pluginInformationBundleVersionKey):
(WebKit::pluginInformationPathKey):
(WebKit::pluginInformationDisplayNameKey):
(WebKit::pluginInformationDefaultLoadPolicyKey):
(WebKit::pluginInformationUpdatePastLastBlockedVersionIsKnownAvailableKey):
(WebKit::pluginInformationHasSandboxProfileKey):
(WebKit::pluginInformationFrameURLKey):
(WebKit::pluginInformationMIMETypeKey):
(WebKit::pluginInformationPageURLKey):
(WebKit::pluginInformationPluginspageAttributeURLKey):
(WebKit::pluginInformationPluginURLKey):
Add new keys.
(WebKit::pluginModuleInformation):
(WebKit::createPluginInformationDictionary):
Add creation functions to simplify multiple sites.
- Shared/Plugins/Netscape/mac/PluginInformationMac.mm: Added.
(WebKit::platformPluginModuleInformation):
Add platform specific data to the dictionary.
- UIProcess/API/C/WKPage.cpp:
(WKPageGetPluginInformationBundleIdentifierKey):
(WKPageGetPluginInformationBundleVersionKey):
(WKPageGetPluginInformationDisplayNameKey):
(WKPageGetPluginInformationFrameURLKey):
(WKPageGetPluginInformationMIMETypeKey):
(WKPageGetPluginInformationPageURLKey):
(WKPageGetPluginInformationPluginspageAttributeURLKey):
(WKPageGetPluginInformationPluginURLKey):
- UIProcess/API/C/WKPage.h:
Deprecate the old keys.
- UIProcess/API/C/mac/WKContextPrivateMac.h:
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKContextCopyPlugInInfoForBundleIdentifier):
(WKContextGetInfoForInstalledPlugIns):
Simplify by using the new createPluginInformationDictionary functions.
(WKPlugInInfoPathKey):
(WKPlugInInfoBundleIdentifierKey):
(WKPlugInInfoVersionKey):
(WKPlugInInfoLoadPolicyKey):
(WKPlugInInfoUpdatePastLastBlockedVersionIsKnownAvailableKey):
(WKPlugInInfoIsSandboxedKey):
Deprecate the old keys.
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didFailToInitializePlugin):
(WebKit::WebLoaderClient::didBlockInsecurePluginVersion):
(WebKit::WebLoaderClient::pluginLoadPolicy):
- UIProcess/WebLoaderClient.h:
- UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::unavailablePluginButtonClicked):
- UIProcess/WebUIClient.h:
Optimize for the most recent callback type which takes a dictionary,
and pull out the necessary bits from it for deprecated callbacks as necessary.
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin):
(WebKit::WebPageProxy::unavailablePluginButtonClicked):
(WebKit::WebPageProxy::didFailToInitializePlugin):
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
Use createPluginInformationDictionary() consistently, to get consistent results for callbacks.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- 1:35 PM Changeset in webkit [149903] by
-
- 3 edits in trunk/Source/WebKit2
Web Inspector: implement runOpenPanel callback for WebKit2 inspector
https://bugs.webkit.org/show_bug.cgi?id=115865
Patch by Brian J. Burg <Brian Burg> on 2013-05-10
Reviewed by Sam Weinig.
- UIProcess/WebInspectorProxy.h:
(WebKit::WebInspectorProxy::inspectorWindow):
Add an accessor for m_inspectorWindow.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::runOpenPanel):
Show the open panel dialog when requested.
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Register the callback when the inspector page is created.
- 1:34 PM Changeset in webkit [149902] by
-
- 13 edits in trunk
[WK2][CoordinatedGraphics] WKViewSetThemePath is EFL specific
https://bugs.webkit.org/show_bug.cgi?id=115928
Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2013-05-10
Reviewed by Kenneth Rohde Christiansen.
Source/WebKit2:
WKViewSetThemePath was moved to WKViewEfl.h since it is EFL specific.
- UIProcess/API/C/CoordinatedGraphics/WKView.cpp:
- UIProcess/API/C/CoordinatedGraphics/WKView.h:
- UIProcess/API/C/efl/WKViewEfl.cpp:
(WKViewSetThemePath):
- UIProcess/API/C/efl/WKViewEfl.h:
- UIProcess/CoordinatedGraphics/WebView.cpp:
- UIProcess/CoordinatedGraphics/WebView.h:
(WebView):
- UIProcess/efl/ViewClientEfl.cpp:
- UIProcess/efl/WebInspectorProxyEfl.cpp:
- UIProcess/efl/WebViewEfl.cpp:
(WebKit::WebViewEfl::setThemePath):
- UIProcess/efl/WebViewEfl.h:
(WebViewEfl):
Tools:
WKViewSetThemePath was moved to WKViewEfl.h.
- TestWebKitAPI/efl/PlatformWebView.cpp:
- 12:24 PM Changeset in webkit [149901] by
-
- 2 edits in trunk/LayoutTests
Unreviewed mac-lion rebaselines.
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
- 12:12 PM Changeset in webkit [149900] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support CompareStrictEq
https://bugs.webkit.org/show_bug.cgi?id=115927
Reviewed by Mark Hahnenberg.
Do the sensible thing, and make it so that for common cases, CompareEq is
implemented in terms of CompareStrictEq in the FTL backend. All of the cases
we currently support can be done this way.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):
- 12:10 PM Changeset in webkit [149899] by
-
- 5 edits in trunk/Source/WebCore
[CMake] Consolidate list of files to build for WebCore plugin support
https://bugs.webkit.org/show_bug.cgi?id=104429
Reviewed by Rob Buis.
Move the common files to support plugins and the logic for disabling
plugins) to CMakeLists.txt from PlatformXXX.cmake.
No new tests as there is no new functionality.
- CMakeLists.txt:
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
- PlatformWinCE.cmake:
- 12:04 PM Changeset in webkit [149898] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support Int32ToDouble
https://bugs.webkit.org/show_bug.cgi?id=115926
Reviewed by Mark Hahnenberg.
This node exists mainly to help the DFG see that a node may have both an int
and a double representation. But in the FTL, nodes already have multiple
representations. So this is just a no-op for the FTL.
I considered making it so that the node isn't even inserted if we're doing
FTL compilation, but that would have required a bunch of conditionalizing in
the DFG's optimization phases, which sort of expect this node to be present
and necessary.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileInt32ToDouble):
(LowerDFGToLLVM):
- 12:02 PM Changeset in webkit [149897] by
-
- 3 edits2 adds in trunk
REGRESSION(r148121): Empty Span does not get a linebox when it's in an anonymous block
https://bugs.webkit.org/show_bug.cgi?id=115818
Reviewed by David Hyatt.
Source/WebCore:
r148121 only worried about split inlines inside anonymous blocks - it ought to have
catered for empty inlines, with no continuations, inside a single solitary anonymous block too.
Test: fast/inline/anonymous-block-with-empty-inline.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::hasInlineDirectionBordersPaddingOrMargin):
LayoutTests:
- fast/inline/anonymous-block-with-empty-inline-expected.txt: Added.
- fast/inline/anonymous-block-with-empty-inline.html: Added.
- 11:47 AM Changeset in webkit [149896] by
-
- 5 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support LogicalNot
https://bugs.webkit.org/show_bug.cgi?id=115924
Reviewed by Mark Hahnenberg.
- ftl/FTLAbbreviations.h:
(JSC::FTL::buildNot):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileLogicalNot):
(LowerDFGToLLVM):
- ftl/FTLOutput.h:
(JSC::FTL::Output::bitNot):
- 11:39 AM Changeset in webkit [149895] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Remove unnecessary includes in WidgetGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=115912
Reviewed by Andreas Kling.
No new tests - no new functionality.
- platform/gtk/WidgetGtk.cpp: Remove the unnecessary includes of the Chrome.h, Frame.h, FrameView.h,
Page.h and RenderObject.h headers as the included declarations are not used anywhere. ScrollView.h is
included instead as it is required and was previously included by one of the removed header inclusions.
- 11:38 AM Changeset in webkit [149894] by
-
- 2 edits in trunk/Source/WebCore
[Cairo] Remove the unnecessary ImageData.h include in ImageBufferCairo.cpp
https://bugs.webkit.org/show_bug.cgi?id=115911
Reviewed by Carlos Garcia Campos.
No new tests - no new functionality.
- platform/graphics/cairo/ImageBufferCairo.cpp: Remove the ImageData.h include
as the included declarations are not used anywhere.
- 11:37 AM Changeset in webkit [149893] by
-
- 2 edits in trunk/Source/WebCore
[Cairo] Remove the unnecessary CSSParser.h include in GradientCairo.cpp
https://bugs.webkit.org/show_bug.cgi?id=115910
Reviewed by Laszlo Gombos.
No new tests - no new functionality.
- platform/graphics/cairo/GradientCairo.cpp: Remove the CSSParser.h include
as the included declarations are not used anywhere.
- 11:31 AM Changeset in webkit [149892] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should support CompareGreater, CompareLessEq, and CompareGreaterEq
https://bugs.webkit.org/show_bug.cgi?id=115923
Reviewed by Mark Hahnenberg.
Also fixed a bug where double CompareLess would assert.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCompareLess):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileCompareLessEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreater):
(JSC::FTL::LowerDFGToLLVM::compileCompareGreaterEq):
- 11:20 AM Changeset in webkit [149891] by
-
- 3 edits2 adds in trunk
Include tab character as a word end for kerning
https://bugs.webkit.org/show_bug.cgi?id=115915
<rdar://problem/13861491>
Reviewed by Enrica Casucci.
This is a follow-up to https://bugs.webkit.org/show_bug.cgi?id=112507
which only looked for a space character as a word end. It should
look for tab characters too.
Source/WebCore:
Test: fast/text/word-space-with-kerning-4.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::setLogicalWidthForTextRun): Look for '\t'.
LayoutTests:
- fast/text/word-space-with-kerning-4-expected.html: Added.
- fast/text/word-space-with-kerning-4.html: Added.
- 11:12 AM Changeset in webkit [149890] by
-
- 7 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL CompareEq ObjectUse should handle masquerading
https://bugs.webkit.org/show_bug.cgi?id=115920
Reviewed by Mark Hahnenberg.
We don't yet support watchpoints, but this does all the wiring right up to the
part where we would have emitted watchpoints. I've also written this in a way that
makes it easy to use the case where you would have anyway speculated non-masquerading
even if the watchpoint was invalidated.
This is inherently racy, of course: but the only race here is that you might first
set the watchpoint, and then the watchpoint is invalidated, and then you compile rest
of the code in a way that doesn't need the watchpoint. That's fine, since the FTL
will remember that it had set the watchpoint and then cancel the compilation.
- ftl/FTLAbbreviations.h:
(JSC::FTL::int8Type):
- ftl/FTLAbstractHeapRepository.h:
(FTL):
- ftl/FTLCommonValues.cpp:
(JSC::FTL::CommonValues::CommonValues):
- ftl/FTLCommonValues.h:
(CommonValues):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::lowNonNullObject):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::speculateNonNullObject):
(JSC::FTL::LowerDFGToLLVM::masqueradesAsUndefinedWatchpointIsStillValid):
(JSC::FTL::LowerDFGToLLVM::masqueradesAsUndefinedWatchpointIfIsStillValid):
- ftl/FTLOutput.h:
(JSC::FTL::Output::constInt8):
(JSC::FTL::Output::load8):
(JSC::FTL::Output::isZero8):
(JSC::FTL::Output::notZero8):
(JSC::FTL::Output::testIsZero8):
(JSC::FTL::Output::testNonZero8):
- 10:48 AM Changeset in webkit [149889] by
-
- 2 edits in trunk/Tools
I accidentally the Java testing.
- Scripts/webkitpy/port/mac.py:
- 10:39 AM Changeset in webkit [149888] by
-
- 8 edits2 deletes in trunk/Source/WebCore
Remove EventTracer
https://bugs.webkit.org/show_bug.cgi?id=115916
Reviewed by Sam Weinig.
EventTracer is dead code, remove it.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- platform/EventTracer.cpp: Removed.
- platform/EventTracer.h: Removed.
- 10:36 AM Changeset in webkit [149887] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Generated files are regenerated always
https://bugs.webkit.org/show_bug.cgi?id=115908
Reviewed by Carlos Garcia Campos.
No new tests - no change in functionality.
- GNUmakefile.am: Don't treat the window constructors IDL file as a dependency of the JavaScriptCore bindings.
The file is generated during the IDL preprocessing, and the JSC bindings already depend on that step through
the idl_supplemental_dependencies file. Because of that the window constructors IDL file has a phony target
which seems to confuse the bindings generation rule into thinking that a complete regeration of the bindings is required.
- 10:34 AM Changeset in webkit [149886] by
-
- 10 edits in trunk
Caching of generated images in CSS should be smarter.
<http://webkit.org/b/115902>
<rdar://problem/13542727>
Reviewed by Antti Koivisto.
Add an IntSize => GeneratorGeneratedImage cache at the CSSImageGeneratorValue level.
CSSGradientValue is currently the only CSSImageGeneratorValue subclass that makes use of the cache.
Generated images are kept for 3 seconds after last use.
The main problem with the previous approach was that background renderers (e.g <body>, <tr>, etc)
would be passed to multiple CSSImageGeneratorValue::getImage() calls with different sizes requested
for each of the descendent renderers that inherit their background from the same parent.
The cache wasn't smart enough for this, it just thought the background renderer was changing size
a lot, and would regenerate the image over and over.
We already had caching of intermediate image buffers for GeneratorGeneratedImage::drawPattern().
This removes the eviction timer from that cache so that the intermediate images can live a bit longer.
(WebCore::CSSImageGeneratorValue::cachedImageForSize):
(WebCore::CSSImageGeneratorValue::saveCachedImageForSize):
Renamed from getImage() and putImage().
(WebCore::CSSImageGeneratorValue::evictCachedGeneratedImage):
(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::CachedGeneratedImage):
(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::evictionTimerFired):
Let the CachedGeneratedImage throw itself out from cache when the timer fires.
- css/CSSImageGeneratorValue.h:
(CachedGeneratedImage):
Exactly what it sounds like. These go into CSSImageGeneratorValue::m_images with the size
as the hash key.
- platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::drawPattern):
- platform/graphics/GeneratorGeneratedImage.h:
(WebCore::GeneratorGeneratedImage::~GeneratorGeneratedImage):
(WebCore::GeneratorGeneratedImage::GeneratorGeneratedImage):
Keep the intermediate image for drawPattern() until destruction instead of dropping it on
a timer. These objects are now evicted by the CSSImageGeneratorValue's image cache
after 3 seconds of disuse rather than kept for the lifetime of the renderer.
- css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::canvasChanged):
(WebCore::CSSCanvasValue::canvasResized):
- css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::crossfadeChanged):
- rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::addClient):
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::addClient):
(WebCore::CSSImageGeneratorValue::removeClient):
CSSImageGeneratorValue::m_clients is now a HashCountedSet<RenderObject*>, tweak accordingly.
- 10:20 AM Changeset in webkit [149885] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r149439): Video turns blank upon entering full screen for the first time
https://bugs.webkit.org/show_bug.cgi?id=115617
Reviewed by Eric Carlson.
Partially revert the change introduced in r149439 for OS X 10.8 and previous. On these
platforms, create a window with a NSZeroSize initial frame, which fixes the "blank"
first-full screen behavior.
- UIProcess/API/mac/WKView.mm:
(-[WKView createFullScreenWindow]):
- 10:16 AM Changeset in webkit [149884] by
-
- 7 edits in trunk/Source/WebKit2
[WK2] Make the WebSoupRequestManager a supplement to the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=115717
Reviewed by Andreas Kling.
WebSoupRequestManager should inherit from WebProcessSupplement and should be used as such
by the WebProcess. This removes the need for the m_soupRequestManager member variable in
the WebProcess class and brings the WebSoupRequestManager in line with other manager classes
of which instances are controlled by the WebProcess class.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess): Add the WebSoupRequestManager as a supplement.
- WebProcess/WebProcess.h:
(WebProcess): Remove the m_soupRequestManager member variable and its getter method.
- WebProcess/soup/WebKitSoupRequestGeneric.cpp:
(webkitSoupRequestGenericSendAsync): Access the WebSoupRequestManager as a supplement.
(webkitSoupRequestGenericSendFinish): Ditto.
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformInitializeWebProcess): Access the WebSoupRequestManager as a supplement.
- WebProcess/soup/WebSoupRequestManager.cpp:
(WebKit::WebSoupRequestManager::supplementName): Specify the supplement's name.
- WebProcess/soup/WebSoupRequestManager.h:
(WebSoupRequestManager): Inherit from the WebProcessSupplement interface.
- 10:04 AM Changeset in webkit [149883] by
-
- 2 edits in trunk/Tools
[GTK] Module Cairo fails to build under jhbuild
https://bugs.webkit.org/show_bug.cgi?id=115854
Patch by Brian Holt <brian.holt@samsung.com> on 2013-05-10
Reviewed by Martin Robinson.
Make cairo depend on glib in jhbuild.modules.
- gtk/jhbuild.modules:
- 10:03 AM Changeset in webkit [149882] by
-
- 10 edits3 deletes in trunk/Source/WebCore
Remove MemoryUsageSupport class
https://bugs.webkit.org/show_bug.cgi?id=115913
Reviewed by Andreas Kling.
MemoryUsageSupport was just used by a single call site in InspectorTimelineAgent,
and the function called always returns zero on all platforms! Remove it.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- inspector/InspectorMemoryAgent.cpp:
- inspector/InspectorTimelineAgent.cpp:
(WebCore):
(WebCore::InspectorTimelineAgent::setNativeHeapStatistics):
- platform/MemoryUsageSupport.cpp: Removed.
- platform/MemoryUsageSupport.h: Removed.
- platform/qt/MemoryUsageSupportQt.cpp: Removed.
- 9:38 AM Changeset in webkit [149881] by
-
- 7 edits2 adds in trunk
REGRESSION (r149652): Videos do not play on cnn.com, just black box
https://bugs.webkit.org/show_bug.cgi?id=115887
Reviewed by Antti Koivisto.
Source/WebCore:
The bug was caused by window and document named item maps counting the same element twice
when it has the same id and name attribute values. Fixed the bug by avoiding to add or remove
an element per id and name attribute updates when it had already been added or removed by
name and id attribute updates respectively.
We do this by checking whether the other attribute affects the element's precense in window
and document named item maps and avoiding to add or remove the attribute when they do and
the other attribute is present in updateId and updateName.
Consider a scenario when an object element has id "foo", and name attribute is about to be also
set to "foo". If the id attribute doesn't affect element's presense in window or document
named item maps, we're done. If it does, then the maps already have this element so we don't
want to add it again. Conversely, if the element already has id and name attributes set to
"foo", and we're moving the id attribute, then we want to remove the element from the maps only
if the id doesn't affect the presence of the element in the maps.
Unfortuntely, this logic doesn't work when we're inserting or removing an element on its entirely
because updateId and updateName are called when both id and name attributes are present so skip
this step (AlwaysUpdateHTMLDocumentNamedItemMaps) for the id attribute to break the symmetry.
Test: fast/dom/HTMLDocument/image-with-same-id-and-name.html
fast/dom/HTMLDocument/object-with-same-id-and-name.html
- dom/Element.cpp:
(WebCore::Element::insertedInto): Call updateId and updateName with
AlwaysUpdateHTMLDocumentNamedItemMaps.
(WebCore::Element::removedFrom): Ditto.
(WebCore::Element::updateName): Don't add or remove this element if the id attribute has already
done so except when we're inserting, removing, or cloning an element.
(WebCore::Element::updateId): Ditto for the name attribute.
(WebCore::Element::cloneAttributesFromElement): Added a comment and assert that we never call this
function when this element is in the document. We can't update window and documemt named item
maps here because image element's id attribute value, for example, is present in the document's
named item map if it has a name attribute. Since this function calls updateId and updateName
before updating attributes, this check is going to fail in DocumentNameCollection's
nodeMatchesIfIdAttributeMatch and bad things will happen.
- dom/Element.h:
- editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren): Clone children and attributes before
inserting the swapped span to avoid hitting the assertion in cloneAttributesFromElement we added.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute):
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::updateDocNamedItem):
LayoutTests:
Add regression tests.
- fast/dom/HTMLDocument/image-with-same-id-and-name-expected.txt: Added.
- fast/dom/HTMLDocument/image-with-same-id-and-name.html: Added.
- fast/dom/HTMLDocument/object-with-same-id-and-name-expected.txt: Added.
- fast/dom/HTMLDocument/object-with-same-id-and-name.html: Added.
- 9:18 AM Changeset in webkit [149880] by
-
- 2 edits in trunk/Source/WebCore
Don't trust character widths for internal OS X fonts in form controls
https://bugs.webkit.org/show_bug.cgi?id=115883
<rdar://problem/13817757>
Reviewed by Darin Adler.
We ignore the character width for a bunch of fonts when predicting
the width of a form control. Some of the internal fonts in OS X are
not in the ignored list. Rather than add them, simply test for
fonts whose family begins with a period character ".".
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::hasValidAvgCharWidth): Return false for
any family that starts with "."
- 9:11 AM Changeset in webkit [149879] by
-
- 11 edits in trunk
[GTK] Remove unnecessary GLIB_CHECK_VERSION #ifdefs
https://bugs.webkit.org/show_bug.cgi?id=115904
Reviewed by Martin Robinson.
Source/WebCore:
- bindings/gobject/WebKitDOMEventTarget.cpp:
- platform/gtk/GtkVersioning.c:
- platform/gtk/GtkVersioning.h:
Source/WebKit2:
- UIProcess/API/gtk/tests/TestInspectorServer.cpp:
(startTestServerMonitor):
- UIProcess/API/gtk/tests/TestWebKitAccessibility.cpp:
(startTestServerMonitor):
Source/WTF:
- wtf/gobject/GRefPtr.cpp:
Tools:
- ImageDiff/gtk/ImageDiff.cpp:
(main):
- 9:01 AM Changeset in webkit [149878] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix the ENABLE(SHARED_WORKERS) build after r149864.
- workers/SharedWorkerThread.cpp: include "SecurityOrigin.h"
- 8:27 AM Changeset in webkit [149877] by
-
- 2 edits in trunk/Tools
Add my new address to contributors.json. (Unreviewed)
- Scripts/webkitpy/common/config/contributors.json:
- 7:05 AM Changeset in webkit [149876] by
-
- 2 edits in trunk/Source/WebCore
Fix build after r149864.
Unreviewed build fix.
- loader/ThreadableLoader.h: include <wtf/text/AtomicString.h>
when building with RESOURCE_TIMING enabled.
- 6:26 AM WebKit Team edited by
- Move myself to the Reviewers list (diff)
- 6:19 AM Changeset in webkit [149875] by
-
- 2 edits in trunk/Tools
Unreviewed. Move myself to the reviewers list.
- Scripts/webkitpy/common/config/contributors.json:
- 6:16 AM Changeset in webkit [149874] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Rebaseline fast/dom/Range/getClientRects.html for EFL port.
Skip accessibility/poorly-formed-aria-table.html introduced in
r149858 but failing on EFL port.
- platform/efl/TestExpectations:
- platform/efl/fast/dom/Range/getClientRects-expected.txt:
- 6:00 AM Changeset in webkit [149873] by
-
- 2 edits in trunk/Source/WebCore
Fix build.
- bindings/js/ScriptController.cpp:
- 5:53 AM Changeset in webkit [149872] by
-
- 2 edits2 adds in trunk/LayoutTests
[Qt] Unreviewed gardening.
- 5:51 AM Changeset in webkit [149871] by
-
- 13 edits1 delete in trunk/Source/WebCore
Remove ScriptInstance.h
https://bugs.webkit.org/show_bug.cgi?id=115900
Reviewed by Andreas Kling.
Remove yet another abstraction now that we don't support V8.
- GNUmakefile.list.am:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptController.h:
(Bindings):
(ScriptController):
- bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::createScriptInstanceForWidget):
- bindings/js/ScriptInstance.h: Removed.
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::getInstance):
- html/HTMLPlugInElement.h:
(Bindings):
(HTMLPlugInElement):
- platform/graphics/wince/MediaPlayerProxy.h:
(WebMediaPlayerProxy):
- rendering/RenderEmbeddedObject.cpp:
- rendering/RenderSnapshottedPlugIn.cpp:
- 5:49 AM Changeset in webkit [149870] by
-
- 3 edits3 adds in trunk/LayoutTests
Unreviewed EFL gardening.
Skip several remaining shadow dom tests and rebaseline a few others.
- platform/efl/TestExpectations:
- platform/efl/fast/images/crossfade-client-not-removed-crash-expected.txt: Added.
- platform/efl/fast/js/dom-static-property-for-in-iteration-expected.txt:
- platform/efl/inspector/console/command-line-api-expected.txt: Added.
- 5:22 AM Changeset in webkit [149869] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed, rolling out r149866.
http://trac.webkit.org/changeset/149866
https://bugs.webkit.org/show_bug.cgi?id=115898
Broke tests
- dom/Document.cpp:
(WebCore::Document::setDomain):
(WebCore::Document::initSecurityContext):
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::isolatedCopy):
(WebCore::SecurityOrigin::setDomainFromDOM):
(WebCore::SecurityOrigin::grantUniversalAccess):
- page/SecurityOrigin.h:
(SecurityOrigin):
- 5:21 AM Changeset in webkit [149868] by
-
- 2 edits in trunk/Tools
Unreviewed. Add my email to a few watchlists.
- Scripts/webkitpy/common/config/watchlist:
- 5:17 AM Changeset in webkit [149867] by
-
- 3 edits in trunk/Source/WebCore
Remove overflow dead code
https://bugs.webkit.org/show_bug.cgi?id=115893
Reviewed by Antti Koivisto.
The patch removes unused public overflow accesor functions from RenderOverflow and InlineFlowBox.
Tests: no tests, code cleanup.
- rendering/InlineFlowBox.h: Removed logicalLeftLayoutOverflow and logicalRightLayoutOverflow.
- rendering/RenderOverflow.h: Removed setMinYLayoutOverflow, setMaxYLayoutOverflow,
setMinXLayoutOverflow, setMaxXLayoutOverflow, setMinYVisualOverflow, setMaxYVisualOverflow,
setMinXVisualOverflow and setMaxXVisualOverflow.
- 4:59 AM Changeset in webkit [149866] by
-
- 4 edits in trunk/Source/WebCore
Begin making SecurityOrigin immutable
https://bugs.webkit.org/show_bug.cgi?id=115898
Reviewed by Andreas Kling.
Replace SecurityOrigin::setDomainFromDOM and SecurityOrigin::grantUniversalAccess with
member functions that return new SecurityOrigin objects.
- dom/Document.cpp:
(WebCore::Document::setDomain):
Update the security origin to one returned by copyWithDomainSetFromDOM.
(WebCore::Document::initSecurityContext):
Set the security origin to one returned by copyWithUniversalAccessGranted().
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::SecurityOrigin):
Add a new constructor that takes all the member variables as parameters. This is a little unwieldy at the moment,
but all the boolean parameters could be replaced by a bitmask of flags.
(WebCore::SecurityOrigin::isolatedCopy):
Call the new constructor.
(WebCore::SecurityOrigin::copyWithDomainSetFromDOM):
Return a new security origin with m_domainWasSetInDOM set to true and the domain updated.
(WebCore::SecurityOrigin::copyWithUniversalAccessGranted):
Return a new security origin with m_universalAccess set to true.
- 4:18 AM Changeset in webkit [149865] by
-
- 7 edits in trunk/Source/WebCore
Remove ScriptController::updateSecurityOrigin
https://bugs.webkit.org/show_bug.cgi?id=115895
Reviewed by Antti Koivisto.
ScriptController::updateSecurityOrigin is just dead code now that the V8 bindings are gone.
- bindings/js/ScriptController.cpp:
- bindings/js/ScriptController.h:
- dom/Document.cpp:
(WebCore::Document::setIsViewSource):
(WebCore::Document::setDomain):
- dom/Document.h:
(Document):
- dom/SecurityContext.cpp:
(WebCore::SecurityContext::enforceSandboxFlags):
- dom/SecurityContext.h:
(SecurityContext):
- 4:12 AM Changeset in webkit [149864] by
-
- 15 edits in trunk/Source/WebCore
Stop including SecurityOrigin.h where unnecessary
https://bugs.webkit.org/show_bug.cgi?id=115897
Reviewed by Antti Koivisto.
Move rarely called functions out of line so headers don't have to include SecurityOrigin.h
- Modules/indexeddb/IDBFactoryBackendImpl.h:
- Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::DatabaseBackendBase::databaseDebugName):
- Modules/webdatabase/DatabaseBackendBase.h:
(DatabaseBackendBase):
- Modules/webdatabase/DatabaseSync.h:
- bindings/js/JSDOMWindowCustom.h:
- html/parser/XSSAuditor.cpp:
- loader/ThreadableLoader.cpp:
(WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):
(WebCore::ThreadableLoaderOptions::~ThreadableLoaderOptions):
(WebCore::ThreadableLoader::create):
- loader/ThreadableLoader.h:
(ThreadableLoaderOptions):
- loader/WorkerThreadableLoader.cpp:
- workers/DedicatedWorkerContext.cpp:
- workers/DedicatedWorkerThread.cpp:
- workers/SharedWorkerContext.cpp:
- workers/WorkerThread.cpp:
- workers/WorkerThread.h:
- 2:37 AM WK2-EFLTextCheckerApiTutorial edited by
- (diff)
- 2:32 AM WK2-EFLTextCheckerApiTutorial edited by
- (diff)
- 2:29 AM WK2-EFLTextCheckerApiTutorial edited by
- (diff)
- 1:45 AM Changeset in webkit [149863] by
-
- 3 edits in trunk/Tools
Unicode support missing from string representation of Contributors in committers.py
https://bugs.webkit.org/show_bug.cgi?id=115859
Patch by Simon Pena <simon.pena@samsung.com> on 2013-05-10
Reviewed by Darin Adler.
Contributors, in committers.py, provided a string representation in str which
didn't support unicode characters, so printing a contributor would fail in that case.
This patch implements unicode and makes str use it to represent a contributor.
The unit tests are updated accordingly, so they ensure that a unicode name can be shown.
- Scripts/webkitpy/common/config/committers.py: Move the existing string representation
to the newly implemented method unicode, and make str display its utf-8 encoded
representation.
(Contributor.str):
(Contributor):
(Contributor.unicode):
- Scripts/webkitpy/common/config/committers_unittest.py: Add a new test that checks that
a contributor with unicode characters can be represented as a string.
(CommittersTest):
(CommittersTest.test_contributor_encoding):
- 12:41 AM Changeset in webkit [149862] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix GTK+ build after r149839.
- platform/gtk/RenderThemeGtk3.cpp:
(WebCore::gtkStyleChangedCallback):
May 9, 2013:
- 8:29 PM Changeset in webkit [149861] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG shouldn't allocate in the GC heap
https://bugs.webkit.org/show_bug.cgi?id=115598
Reviewed by Geoffrey Garen.
I believe that we've now fixed this, and this patch just adds the relevant assertion.
- runtime/JSCellInlines.h:
(JSC::JSCell::JSCell):
- 7:45 PM Changeset in webkit [149860] by
-
- 12 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: CodeBlock should be RefCounted
https://bugs.webkit.org/show_bug.cgi?id=115594
Reviewed by Geoffrey Garen.
This makes it possible to have the currently-being-compiled CodeBlock not be
installed in Executable, while also allowing it to point to its intended
alternative(). So long as we were using ownership and not reference counting, it
would have been difficult to have both CodeBlock::m_alternative and
Executable::m_codeBlockForBlah point to the previous CodeBlock.
I also took the opportunity to clean up a bunch of code that appears to have
rotted.
- assembler/MacroAssemblerCodeRef.h:
(MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::operator==):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::releaseAlternative):
(JSC::CodeBlock::setAlternative):
(CodeBlock):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
- heap/DFGCodeBlocks.cpp:
(JSC::DFGCodeBlocks::~DFGCodeBlocks):
(JSC::DFGCodeBlocks::jettison):
(JSC::DFGCodeBlocks::deleteUnmarkedJettisonedCodeBlocks):
- heap/DFGCodeBlocks.h:
(DFGCodeBlocks):
- heap/Heap.cpp:
(JSC::Heap::jettisonDFGCodeBlock):
- heap/Heap.h:
- jit/JITDriver.h:
(JSC::jitCompileIfAppropriate):
(JSC::jitCompileFunctionIfAppropriate):
- runtime/Executable.cpp:
(JSC::jettisonCodeBlock):
(JSC::EvalExecutable::jitCompile):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::jitCompile):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::jitCompileForCall):
(JSC::FunctionExecutable::jitCompileForConstruct):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
- runtime/Executable.h:
(EvalExecutable):
(FunctionExecutable):
(JSC::FunctionExecutable::codeBlockFor):
- runtime/ExecutionHarness.h:
(JSC::prepareForExecution):
(JSC::prepareFunctionForExecution):
- 6:46 PM Changeset in webkit [149859] by
-
- 6 edits in trunk/LayoutTests
Unskipped the webarchive tests for Mac that are not skipped for a reason other than
dumpDOMAsWebArchive not being implemented, which was fixed in r149692.
https://bugs.webkit.org/show_bug.cgi?id=115819
Patch by Alex Christensen <achristensen@apple.com> on 2013-05-09
Reviewed by Benjamin Poulain.
- platform/efl-wk2/TestExpectations:
Skip webarchive tests.
- platform/gtk-wk2/TestExpectations:
Skip webarchive tests.
- platform/qt-5.0-mac-wk2/TestExpectations:
Skip webarchive tests.
- platform/qt-5.0-wk2/TestExpectations:
Skip webarchive tests.
- platform/wk2/TestExpectations:
Removed universal skipping of webarchive tests, noted which tests are still skipped with bug numbers.
- 5:57 PM Changeset in webkit [149858] by
-
- 10 edits2 adds in trunk
AX: VoiceOver is no longer seeing items in poorly formed tables
https://bugs.webkit.org/show_bug.cgi?id=115837
Reviewed by Darin Adler.
Source/WebCore:
In case the author didn't include the rows of a table as the
direct children, a table needs to dive down its descendant chain
until the rows are found.
I also took the opportunity to clean up a bit around what the different
meanings of table are in the accessibility classes.
Test: accessibility/poorly-formed-aria-table.html
- accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::addRowDescendant):
(WebCore::AccessibilityARIAGrid::addChildren):
- accessibility/AccessibilityARIAGrid.h:
(AccessibilityARIAGrid):
- accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::parentTable):
(WebCore):
- accessibility/AccessibilityARIAGridRow.h:
(AccessibilityARIAGridRow):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isTable):
- accessibility/AccessibilityTable.h:
(AccessibilityTable):
(WebCore::AccessibilityTable::isTable):
(WebCore::toAccessibilityTable):
- accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::parentTable):
LayoutTests:
- accessibility/poorly-formed-aria-table-expected.txt: Added.
- accessibility/poorly-formed-aria-table.html: Added.
- 5:12 PM Changeset in webkit [149857] by
-
- 6 edits in trunk/LayoutTests
[Qt] REGRESSION (r148975) shape-inside-percentage.html and shape-inside-overflow-fixed-dimensions.html are failing after r148975
https://bugs.webkit.org/show_bug.cgi?id=115053
Reviewed by Alexandru Chiculita.
I changed the tests to use Ahem font (overflow will be the same on every port) and modify the markup in order to be the similar
for the two tests. The change fixes both tests and make them passing on Qt as well. I removed the tests from the TestExpectations.
- fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions-expected.html:
- fast/exclusions/shape-inside/shape-inside-overflow-fixed-dimensions.html:
- fast/exclusions/shape-inside/shape-inside-percentage-expected.html:
- fast/exclusions/shape-inside/shape-inside-percentage.html:
- platform/qt/TestExpectations:
- 4:55 PM Changeset in webkit [149856] by
-
- 3 edits4 adds in trunk
REGRESSION: Disabled multiline select element now responds to (certain) clicks
https://bugs.webkit.org/show_bug.cgi?id=115710
Patch by Yael Aharon <yael.aharon@intel.com> on 2013-05-09
Reviewed by Kent Tamura.
Source/WebCore:
After http://trac.webkit.org/changeset/140286, select elements can scroll whether they
are disabled or not. While they scroll, they also change the selected item.
This patch allows the select element to scroll, but does not change the selection
if the select element is disabled.
Test: fast/forms/select/listbox-disabled-scroll-no-onchange.html
Test: fast/forms/select/listbox-disabled-no-autoscroll.html
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::autoscroll):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::stopAutoscroll):
LayoutTests:
Test that a disabled element does not change selection while scrolling.
- fast/forms/select/listbox-disabled-scroll-no-onchange-expected.txt: Added.
- fast/forms/select/listbox-disabled-scroll-no-onchange.html: Added.
- fast/forms/select/listbox-disabled-no-autoscroll.html: Added.
- fast/forms/select/listbox-disabled-no-autoscroll-expected.html: Added.
- 4:47 PM Changeset in webkit [149855] by
-
- 4 edits in trunk/Tools
[WIN][DRT] Remove duplicated (start|stop)JavaScriptThreads()
https://bugs.webkit.org/show_bug.cgi?id=92371
Reviewed by Brent Fulgham.
Use JavaScriptThreading.cpp where the same functionality is
implemented too. This reduces the dependency on the pthread
library. Also replace assert() with WebKit ASSERT().
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj:
- DumpRenderTree/win/DumpRenderTree.cpp:
(dumpHistoryItem):
(dumpBackForwardList):
- DumpRenderTree/win/DumpRenderTree.vcproj:
- 4:41 PM Changeset in webkit [149854] by
-
- 3 edits in trunk/Source/WebCore
Clean up SecurityOrigin::databaseIdentifier
https://bugs.webkit.org/show_bug.cgi?id=115882
Reviewed by Beth Dakin.
Remove m_encodedHost and just call encodeHost from databaseIdentifier().
Also, use a StringBuilder when constructing the database identifier to avoid allocating
temporary String objects over and over.
- page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore):
(WebCore::SecurityOrigin::createFromDatabaseIdentifier):
(WebCore::SecurityOrigin::databaseIdentifier):
- page/SecurityOrigin.h:
(SecurityOrigin):
- 4:21 PM Changeset in webkit [149853] by
-
- 3 edits in trunk/Source/WebCore
Remove m_securityOrigin from XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=115881
Reviewed by Alexey Proskuryakov.
The security origin passed to XMLHttpRequest::create was always null, so just get rid of the member variable completely.
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::create):
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::securityOrigin):
- xml/XMLHttpRequest.h:
(XMLHttpRequest):
- 4:03 PM Changeset in webkit [149852] by
-
- 2 edits in trunk/Source/WebKit2
Fix build.
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
- 3:50 PM Changeset in webkit [149851] by
-
- 16 edits4 adds in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG should have its own notion of StructureChain, and it should be possible to validate it after compilation finishes
https://bugs.webkit.org/show_bug.cgi?id=115841
Reviewed by Oliver Hunt.
This adds IntendedStructureChain, which is like StructureChain, except that it holds a bit
more information and can be validated independantly of its owning Structure and lexical
GlobalObject, since it remembers both of those things. It's also malloc'd and RefCounted
rather than GC'd, so it can be allocated in a concurrent compilation thread.
Gave this class a bunch of methods to allow the following idiom:
- Snapshot a structure chain concurrently. This structure chain may end up being wrong in case of races, but in that case we will find out when we try to validate it.
- Perform validation on the structure chain itself, without recomputing the chain. Previously, many chain validation methods (prototypeChainMayInterceptStoreTo() for example) recomputed the chain, and hence, were inherently racy: you could build one chain and then validate against a different chain, and hence not realize that the chain you did build was actually broken for your purposes, because the chain you checked was a different one.
- Validate that the chain is still the right one at any time, allowing the cancellation of compilation if there was a race.
Also added DFG::DesiredStructureChains, which tracks those intended structure chains that
the compiler had already chosen to use. If any of those are invalid at link time, throw
out the compilation.
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeForChain):
(JSC::GetByIdStatus::computeFor):
- bytecode/GetByIdStatus.h:
(JSC::GetByIdStatus::GetByIdStatus):
(JSC::GetByIdStatus::chain):
(GetByIdStatus):
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
- bytecode/PutByIdStatus.h:
(JSC::PutByIdStatus::PutByIdStatus):
(JSC::PutByIdStatus::structureChain):
(PutByIdStatus):
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGDesiredStructureChains.cpp: Added.
(DFG):
(JSC::DFG::DesiredStructureChains::DesiredStructureChains):
(JSC::DFG::DesiredStructureChains::~DesiredStructureChains):
(JSC::DFG::DesiredStructureChains::areStillValid):
- dfg/DFGDesiredStructureChains.h: Added.
(DFG):
(DesiredStructureChains):
(JSC::DFG::DesiredStructureChains::addLazily):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::isStillValid):
(DFG):
- dfg/DFGGraph.h:
(Graph):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::linkFunction):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- runtime/IntendedStructureChain.cpp: Added.
(JSC):
(JSC::IntendedStructureChain::IntendedStructureChain):
(JSC::IntendedStructureChain::~IntendedStructureChain):
(JSC::IntendedStructureChain::isStillValid):
(JSC::IntendedStructureChain::matches):
(JSC::IntendedStructureChain::chain):
(JSC::IntendedStructureChain::mayInterceptStoreTo):
(JSC::IntendedStructureChain::isNormalized):
(JSC::IntendedStructureChain::terminalPrototype):
- runtime/IntendedStructureChain.h: Added.
(JSC):
(IntendedStructureChain):
(JSC::IntendedStructureChain::head):
(JSC::IntendedStructureChain::size):
(JSC::IntendedStructureChain::at):
(JSC::IntendedStructureChain::operator[]):
(JSC::IntendedStructureChain::last):
- runtime/Structure.cpp:
(JSC::Structure::prototypeChainMayInterceptStoreTo):
- runtime/Structure.h:
(Structure):
- runtime/StructureInlines.h:
(JSC::Structure::storedPrototypeObject):
(JSC):
(JSC::Structure::storedPrototypeStructure):
- 3:40 PM Changeset in webkit [149850] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed build fix after r149836.
It broke at least EFL and GTK builds. Move new static members initialization
outside the class. Those need to have a definition outside the class because
their address is used (e.g. CodeCacheMap::nonGlobalWorkingSetMaxEntries).
- runtime/CodeCache.cpp:
(JSC):
- runtime/CodeCache.h:
(CodeCacheMap):
- 3:39 PM Changeset in webkit [149849] by
-
- 2 edits in trunk/Source/WebKit2
Enable UI process storage
https://bugs.webkit.org/show_bug.cgi?id=115879
<rdar://problem/12239765>
Reviewed by Beth Dakin.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
Flip the switch.
- 3:37 PM Changeset in webkit [149848] by
-
- 121 edits in trunk/Source/WebKit2
Remove extra spaces between right angle brackets in template declarations
https://bugs.webkit.org/show_bug.cgi?id=115877
Reviewed by Beth Dakin.
C++11 doesn't require spaces between right angle brackets so remove all of them.
- NetworkProcess/FileAPI/NetworkBlobRegistry.cpp:
(WebKit::NetworkBlobRegistry::registerBlobURL):
(WebKit::NetworkBlobRegistry::sandboxExtensions):
- NetworkProcess/FileAPI/NetworkBlobRegistry.h:
(NetworkBlobRegistry):
- NetworkProcess/HostRecord.h:
(HostRecord):
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::NetworkConnectionToWebProcess::didClose):
(WebKit::NetworkConnectionToWebProcess::registerBlobURL):
- NetworkProcess/NetworkConnectionToWebProcess.h:
(NetworkConnectionToWebProcess):
- NetworkProcess/NetworkProcess.h:
(NetworkProcess):
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::servePendingRequests):
(WebKit::NetworkResourceLoadScheduler::removeScheduledLoaders):
- NetworkProcess/NetworkResourceLoadScheduler.h:
- NetworkProcess/SchedulableLoader.cpp:
(WebKit::SchedulableLoader::SchedulableLoader):
- NetworkProcess/SchedulableLoader.h:
(SchedulableLoader):
- Platform/CoreIPC/ArgumentCoders.h:
- Platform/CoreIPC/Connection.cpp:
(Connection::SyncMessageState):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::processIncomingMessage):
- Platform/CoreIPC/Connection.h:
(Connection):
- Platform/WorkQueue.h:
(WorkQueue):
- PluginProcess/PluginProcess.h:
(PluginProcess):
- Scripts/webkit2/messages_unittest.py:
(CoreIPC):
- Shared/BlockingResponseMap.h:
(BlockingResponseMap):
- Shared/ChildProcessProxy.h:
(ChildProcessProxy):
- Shared/ImmutableArray.cpp:
(WebKit::ImmutableArray::ImmutableArray):
- Shared/ImmutableArray.h:
(WebKit::ImmutableArray::adopt):
(ImmutableArray):
- Shared/ImmutableDictionary.cpp:
(WebKit::ImmutableDictionary::keys):
- Shared/ImmutableDictionary.h:
(ImmutableDictionary):
- Shared/Network/CustomProtocols/CustomProtocolManager.h:
(CustomProtocolManager):
- Shared/SecurityOriginData.cpp:
(WebKit::performAPICallbackWithSecurityOriginDataVector):
- Shared/SessionState.cpp:
- Shared/StatisticsData.h:
(StatisticsData):
- Shared/UserMessageCoders.h:
(WebKit::UserMessageDecoder::baseDecode):
- Shared/WebArchive.cpp:
(WebKit::WebArchive::WebArchive):
(WebKit::WebArchive::subresources):
(WebKit::WebArchive::subframeArchives):
- Shared/WebContextMenuItem.cpp:
(WebKit::WebContextMenuItem::submenuItemsAsImmutableArray):
- Shared/WebOpenPanelParameters.cpp:
(WebKit::WebOpenPanelParameters::acceptMIMETypes):
(WebKit::WebOpenPanelParameters::selectedFileNames):
- Shared/mac/ArgumentCodersMac.mm:
(CoreIPC::encode):
- SharedWorkerProcess/SharedWorkerProcess.h:
(SharedWorkerProcess):
- UIProcess/API/mac/WKPrintingView.h:
(WebFrameProxy):
- UIProcess/API/mac/WKPrintingView.mm:
(-[WKPrintingView _drawPreview:]):
- UIProcess/API/mac/WKView.mm:
(WebKit):
- UIProcess/Downloads/DownloadProxyMap.cpp:
(WebKit::DownloadProxyMap::processDidClose):
- UIProcess/Downloads/DownloadProxyMap.h:
(DownloadProxyMap):
- UIProcess/GeolocationPermissionRequestManagerProxy.h:
(GeolocationPermissionRequestManagerProxy):
- UIProcess/Launcher/mac/DynamicLinkerEnvironmentExtractor.h:
(DynamicLinkerEnvironmentExtractor):
- UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
(CustomProtocolManagerProxy):
- UIProcess/Network/NetworkProcessProxy.h:
(NetworkProcessProxy):
- UIProcess/Notifications/NotificationPermissionRequestManagerProxy.h:
(NotificationPermissionRequestManagerProxy):
- UIProcess/Notifications/WebNotificationManagerProxy.h:
(WebNotificationManagerProxy):
- UIProcess/Plugins/PluginProcessManager.h:
(PluginProcessManager):
- UIProcess/Plugins/PluginProcessProxy.h:
(PluginProcessProxy):
- UIProcess/Plugins/WebPluginSiteDataManager.cpp:
(WebKit::WebPluginSiteDataManager::didGetSitesWithData):
- UIProcess/Plugins/WebPluginSiteDataManager.h:
(WebPluginSiteDataManager):
- UIProcess/SharedWorkers/SharedWorkerProcessManager.h:
(SharedWorkerProcessManager):
- UIProcess/SharedWorkers/SharedWorkerProcessProxy.h:
(SharedWorkerProcessProxy):
- UIProcess/StatisticsRequest.cpp:
(WebKit::StatisticsRequest::completedRequest):
- UIProcess/Storage/StorageManager.cpp:
(StorageManager::StorageArea):
(WebKit::StorageManager::StorageArea::dispatchEvents):
(StorageManager::SessionStorageNamespace):
(WebKit::StorageManager::SessionStorageNamespace::getOrCreateStorageArea):
(WebKit::StorageManager::SessionStorageNamespace::cloneTo):
(WebKit::StorageManager::createLocalStorageMap):
(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::destroyStorageMap):
(WebKit::StorageManager::invalidateConnectionInternal):
(WebKit::StorageManager::findStorageArea):
(WebKit::StorageManager::getOrCreateLocalStorageNamespace):
- UIProcess/Storage/StorageManager.h:
(StorageManager):
- UIProcess/WebApplicationCacheManagerProxy.h:
(WebApplicationCacheManagerProxy):
- UIProcess/WebBackForwardList.cpp:
(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::clear):
- UIProcess/WebBackForwardList.h:
(WebKit):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::enableProcessTermination):
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):
- UIProcess/WebContext.h:
(WebContext):
- UIProcess/WebCookieManagerProxy.cpp:
(WebKit::WebCookieManagerProxy::didGetHostnamesWithCookies):
- UIProcess/WebCookieManagerProxy.h:
(WebCookieManagerProxy):
- UIProcess/WebDatabaseManagerProxy.cpp:
(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):
- UIProcess/WebDatabaseManagerProxy.h:
(WebDatabaseManagerProxy):
- UIProcess/WebFormClient.cpp:
(WebKit::WebFormClient::willSubmitForm):
- UIProcess/WebFormClient.h:
(WebFormClient):
- UIProcess/WebKeyValueStorageManagerProxy.h:
(WebKeyValueStorageManagerProxy):
- UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didChangeBackForwardList):
- UIProcess/WebLoaderClient.h:
(WebLoaderClient):
- UIProcess/WebMediaCacheManagerProxy.cpp:
(WebKit::WebMediaCacheManagerProxy::didGetHostnamesWithMediaCache):
- UIProcess/WebMediaCacheManagerProxy.h:
(WebMediaCacheManagerProxy):
- UIProcess/WebPageContextMenuClient.cpp:
(WebKit::WebPageContextMenuClient::showContextMenu):
- UIProcess/WebPageProxy.cpp:
(ExceededDatabaseQuotaRecords):
(WebKit::WebPageProxy::relatedPages):
(WebKit::WebPageProxy::didChangeBackForwardList):
(WebKit::WebPageProxy::handleWheelEvent):
(WebKit::WebPageProxy::processNextQueuedWheelEvent):
(WebKit::WebPageProxy::findStringMatches):
(WebKit::WebPageProxy::willSubmitForm):
(WebKit::WebPageProxy::pluginInformationDictionary):
(WebKit::WebPageProxy::didFindStringMatches):
(WebKit::WebPageProxy::didReceiveEvent):
- UIProcess/WebPageProxy.h:
(WebPageProxy):
- UIProcess/WebPageProxy.messages.in:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::didClose):
(WebKit::WebProcessProxy::didBecomeUnresponsive):
(WebKit::WebProcessProxy::interactionOccurredWhileUnresponsive):
(WebKit::WebProcessProxy::didBecomeResponsive):
(WebKit::WebProcessProxy::disconnectFramesFromPage):
(WebKit::WebProcessProxy::frameCountInPage):
- UIProcess/WebProcessProxy.h:
(WebProcessProxy):
- UIProcess/WebResourceCacheManagerProxy.h:
(WebResourceCacheManagerProxy):
- UIProcess/mac/WebContextMenuProxyMac.mm:
(WebKit::populateNSMenu):
(WebKit::nsMenuItemVector):
- WebProcess/ApplicationCache/WebApplicationCacheManager.cpp:
(WebKit::WebApplicationCacheManager::getApplicationCacheOrigins):
- WebProcess/Geolocation/WebGeolocationManager.cpp:
(WebKit::WebGeolocationManager::didChangePosition):
(WebKit::WebGeolocationManager::didFailToDeterminePosition):
- WebProcess/IconDatabase/WebIconDatabaseProxy.h:
(WebIconDatabaseProxy):
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::originsWithApplicationCache):
- WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp:
(WebKit::InjectedBundleBackForwardListItem::children):
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange):
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
(InjectedBundlePageEditorClient):
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
(WebKit::InjectedBundlePageFormClient::willSendSubmitEvent):
(WebKit::InjectedBundlePageFormClient::willSubmitForm):
- WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
(InjectedBundlePageFormClient):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::featuresUsedInPage):
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::internallyFailedLoadTimerFired):
(WebKit::WebResourceLoadScheduler::networkProcessCrashed):
- WebProcess/Network/WebResourceLoadScheduler.h:
(WebResourceLoadScheduler):
- WebProcess/Notifications/NotificationPermissionRequestManager.h:
(NotificationPermissionRequestManager):
- WebProcess/Notifications/WebNotificationManager.h:
(WebNotificationManager):
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::invalidate):
- WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
(NPRuntimeObjectMap):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::stopAllStreams):
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
(NetscapePlugin):
- WebProcess/Plugins/Netscape/NetscapePluginStream.h:
(NetscapePluginStream):
- WebProcess/Plugins/PDF/SimplePDFPlugin.mm:
(getAllScriptsInPDFDocument):
(WebKit::SimplePDFPlugin::runScriptsInPDFDocument):
- WebProcess/Plugins/PluginProcessConnectionManager.h:
(PluginProcessConnectionManager):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::cancelAllStreams):
- WebProcess/Plugins/PluginView.h:
(PluginView):
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::dispatchSessionStorageEvent):
(WebKit::StorageAreaMap::dispatchLocalStorageEvent):
- WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::storageArea):
- WebProcess/Storage/StorageNamespaceImpl.h:
(StorageNamespaceImpl):
- WebProcess/Storage/WebKeyValueStorageManager.cpp:
(WebKit::keyValueStorageOriginIdentifiers):
- WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit::WebDatabaseManager::getDatabasesByOrigin):
(WebKit::WebDatabaseManager::getDatabaseOrigins):
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::getClientPasteboardDataForRange):
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
- WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
(WebKit::WebEditorClient::documentFragmentFromAttributedString):
- WebProcess/WebPage/EventDispatcher.h:
(EventDispatcher):
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findStringMatches):
- WebProcess/WebPage/FindController.h:
(FindController):
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::childFrames):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::trackedRepaintRects):
- WebProcess/WebPage/WebPage.h:
(WebKit):
(WebPage):
- WebProcess/WebPage/mac/LayerTreeHostMac.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::visitedLinkStateChanged):
(WebKit::WebProcess::allVisitedLinkStateChanged):
(WebKit::WebProcess::focusedWebPage):
(WebKit::WebProcess::createWebPage):
(WebKit::WebProcess::didClose):
(WebKit::WebProcess::webPageGroup):
(WebKit::addCaseFoldedCharacters):
(WebKit::getWebCoreMemoryCacheStatistics):
(WebKit::WebProcess::setTextCheckerState):
- WebProcess/WebProcess.h:
(WebProcess):
- 3:26 PM Changeset in webkit [149847] by
-
- 3 edits in trunk/Source/WebKit2
Implement WebPlatformStrategies::transientLocalStorageNamespace
https://bugs.webkit.org/show_bug.cgi?id=115876
<rdar://problem/13852871>
Reviewed by Beth Dakin.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::transientLocalStorageNamespace):
Return a session storage namespace for a random page when UI process storage is enabled,
otherwise call the base class implementation.
- 3:09 PM Changeset in webkit [149846] by
-
- 1 edit2 adds1 delete in trunk/LayoutTests
Unreviewed mac gardening.
- platform/mac/inspector/command-line-api-expected.txt: Removed.
- platform/mac/inspector/console: Added.
- platform/mac/inspector/console/command-line-api-expected.txt: Added.
- 2:47 PM Changeset in webkit [149845] by
-
- 17 edits in trunk
[NoInterfaceObject] extended attribute should be removed for several interfaces
https://bugs.webkit.org/show_bug.cgi?id=115852
Reviewed by Benjamin Poulain.
Source/WebCore:
Remove [NoInterfaceObject] extended attribute from the following Web IDL
interfaces: SecurityPolicy, History, Location, Navigator, Performance,
PerformanceEntry, PerformanceMark, PerformanceMeasure, PerformanceNavigation,
PerformanceResourceTiming, PerformanceTiming and Screen.
These interfaces should not have the [NoInterfaceObject] extended attribute
according to their respective specifications:
- http://www.w3.org/html/wg/drafts/html/master/browsers.html#the-history-interface
- http://www.w3.org/html/wg/drafts/html/master/browsers.html#the-location-interface
- https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#securitypolicy
- http://www.w3.org/html/wg/drafts/html/master/webappapis.html#the-navigator-object
- http://www.w3.org/TR/navigation-timing/#performance
- https://dvcs.w3.org/hg/webperf/raw-file/tip/specs/PerformanceTimeline/Overview.html#sec-PerformanceEntry-interface
- http://www.w3.org/TR/navigation-timing/#performancenavigation
- http://www.w3.org/TR/navigation-timing/#performancetiming
- http://www.w3.org/TR/user-timing/#performancemark
- http://www.w3.org/TR/user-timing/#performancemeasure
- http://www.w3c-test.org/webperf/specs/ResourceTiming/#performanceresourcetiming
- http://dev.w3.org/csswg/cssom-view/#the-screen-interface
The new behavior is consistent with the specifications, Firefox and soon Blink.
No new tests, already covered by existing tests.
- page/DOMSecurityPolicy.idl:
- page/History.idl:
- page/Location.idl:
- page/Navigator.idl:
- page/Performance.idl:
- page/PerformanceEntry.idl:
- page/PerformanceMark.idl:
- page/PerformanceMeasure.idl:
- page/PerformanceNavigation.idl:
- page/PerformanceResourceTiming.idl:
- page/PerformanceTiming.idl:
- page/Screen.idl:
LayoutTests:
Rebaseline several layout tests whose output has changed now that a few more
global constructors are exposed.
- fast/dom/dom-constructors-expected.txt:
- fast/js/global-constructors-attributes-expected.txt:
- platform/efl/fast/js/global-constructors-attributes-expected.txt:
- 2:45 PM Changeset in webkit [149844] by
-
- 4 edits1 move3 deletes in trunk
REGRESSION (Safari 3-Safari 4): Replaced element with percent height in table has incorrect height
https://bugs.webkit.org/show_bug.cgi?id=26394
Reviewed by David Hyatt.
Source/WebCore:
Text controls or any object that has scrollable content should not flex inside a table cell.
This makes our behaviour the same as IE, FF and Opera (Presto).
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
LayoutTests:
- fast/replaced/table-percent-height-text-controls-expected.txt: Renamed from LayoutTests/platform/mac/fast/replaced/table-percent-height-text-controls-expected.txt.
- fast/replaced/table-percent-height-text-controls.html:
- platform/gtk/fast/replaced/table-percent-height-text-controls-expected.txt: Removed.
- platform/qt/fast/replaced/table-percent-height-text-controls-expected.txt: Removed.
- platform/win/fast/replaced/table-percent-height-text-controls-expected.txt: Removed.
- 2:35 PM Changeset in webkit [149843] by
-
- 2 edits1 move in trunk/Tools
[DRT] Replace JavaScriptThreadingPthreads.cpp with JavaScriptThreading.cpp
https://bugs.webkit.org/show_bug.cgi?id=92505
Reviewed by Brent Fulgham.
- DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
- DumpRenderTree/JavaScriptThreading.cpp: Copied from DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp.
(javaScriptThreadsMutex):
(javaScriptThreads):
(runJavaScriptThread):
(startJavaScriptThreads):
(stopJavaScriptThreads):
- DumpRenderTree/pthreads: Removed.
- DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp: Removed.
- 2:34 PM Changeset in webkit [149842] by
-
- 2 edits in trunk/Source/WebCore
Build fix.
- WebCore.exp.in:
- 2:18 PM Changeset in webkit [149841] by
-
- 2 edits in trunk/LayoutTests
Update srcipt paths in editing/shadow/rightclick-on-meter-in-shadow-crash.html
https://bugs.webkit.org/show_bug.cgi?id=96223
Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2013-05-09
Reviewed by Rob Buis.
The original paths don't exist at all.
- editing/shadow/rightclick-on-meter-in-shadow-crash.html:
- 2:03 PM Changeset in webkit [149840] by
-
- 14 edits in trunk/Source/WebCore
Add a StorageStrategy hook for creating transient local storage namespaces
https://bugs.webkit.org/show_bug.cgi?id=115870
Reviewed by Geoffrey Garen.
- WebCore.exp.in:
Export symbol needed by WebKit2.
- dom/Document.cpp:
(WebCore::Document::topOrigin):
- dom/Document.h:
- dom/ScriptExecutionContext.h:
- workers/WorkerContext.h:
Remove const qualifier from topOrigin() to avoid ugly const_casts when assigning into a RefPtr<SecurityOrigin> variable.
- page/PageGroup.cpp:
(WebCore::PageGroup::transientLocalStorage):
Do a single hash lookup instead of three and use the SecurityOrigin itself as the hash key instead of a string representation of it.
- page/PageGroup.h:
Update HashMap declaration.
- storage/StorageNamespace.cpp:
(WebCore::StorageNamespace::transientLocalStorageNamespace):
Add new implementation that will optionally call out to the storage strategy.
- storage/StorageNamespaceImpl.cpp:
(WebCore::StorageNamespaceImpl::transientLocalStorageNamespace):
Move the default implementation here from PageGroup.
- storage/StorageStrategy.cpp:
(WebCore::StorageStrategy::transientLocalStorageNamespace):
Call the default implementation.
- 1:54 PM Changeset in webkit [149839] by
-
- 4 edits in trunk/Source/WebCore
A change in system environment should force all CSS properties to be recomputed.
https://bugs.webkit.org/show_bug.cgi?id=115872
<rdar://problem/13781171>
Reviewed by Antti Koivisto.
When a change in the global environment occurs, for example system colors,
we need to make sure all the CSS properties are recomputed and not fetched
from the cache. For this reason we invalidate the properties cache.
I've also renamed the function to give it a more meaningful name.
- page/Page.cpp:
(WebCore::Page::updateStyleForAllPagesAfterGlobalChangeInEnvironment):
- page/Page.h:
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::platformColorsDidChange):
- 1:35 PM Changeset in webkit [149838] by
-
- 2 edits in trunk/Source/WebCore
Reoptimize free-standing :focus/link/visited/-webkit-any-link selectors.
<http://webkit.org/b/115590>
Reviewed by Darin Adler.
Common pseudo selectors should go into their respective rule buckets instead of ending up in the universal one.
- css/RuleSet.cpp:
(WebCore::RuleSet::findBestRuleSetAndAdd):
Check tag selectors with * local name (usually created for namespace) for a suitable narrower bucket too.
- 1:31 PM Changeset in webkit [149837] by
-
- 1 edit3 adds in trunk/LayoutTests
Unreviewed mac port gardening.
- platform/mac-lion/fast/js: Added.
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt: Added.
- platform/mac/inspector/command-line-api-expected.txt: Added.
- 1:03 PM Changeset in webkit [149836] by
-
- 17 edits3 adds in trunk
Code cache stores bogus var references for functions in eval code
https://bugs.webkit.org/show_bug.cgi?id=115747
Reviewed by Mark Hahnenberg.
Source/JavaScriptCore:
Non-global eval now uses a per-CodeBlock cache, and only use it
when we're at the top of a function's scope. This means that we
will no longer cache the parsing of a single string across
multiple functions, and we won't cache when we're nested inside
constructs like |with| and |catch| where previously we would, which
is good because caching in those cases is unsound.
- bytecode/EvalCodeCache.h:
(JSC):
(JSC::EvalCodeCache::getSlow):
(JSC::EvalCodeCache::get):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::codeCacheForEval):
(UnlinkedCodeBlock):
(RareData):
- debugger/Debugger.cpp:
(JSC::evaluateInGlobalCallFrame):
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::evaluate):
- interpreter/Interpreter.cpp:
(JSC::eval):
- runtime/CodeCache.cpp:
(JSC::CodeCache::CodeCache):
(JSC::CodeCache::generateBytecode):
(JSC):
(JSC::CodeCache::getCodeBlock):
- runtime/CodeCache.h:
(JSC::CodeCacheMap::CodeCacheMap):
(CodeCacheMap):
(JSC::CodeCacheMap::canPruneQuickly):
(JSC::CodeCacheMap::prune):
(JSC::CodeCache::create):
(CodeCache):
- runtime/Executable.cpp:
(JSC::EvalExecutable::EvalExecutable):
(JSC::EvalExecutable::compileInternal):
- runtime/Executable.h:
(JSC::EvalExecutable::create):
(EvalExecutable):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::createEvalCodeBlock):
- runtime/JSGlobalObject.h:
(JSGlobalObject):
- runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncEval):
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
(VM):
LayoutTests:
Many tests
- fast/js/eval-cache-scoped-lookup-expected.txt: Added.
- fast/js/eval-cache-scoped-lookup.html: Added.
- fast/js/script-tests/eval-cache-scoped-lookup.js: Added.
(first):
(a.string_appeared_here.second):
(third):
(fifth):
(sixth):
(seventh):
(eighth):
(nineth):
(tenth):
(eleventh):
- 12:41 PM Changeset in webkit [149835] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Fixing botched rebase of ChangeLog
- 12:38 PM Changeset in webkit [149834] by
-
- 4 edits3 adds in trunk
DFGArrayMode::fromObserved is too liberal when it sees different Array and NonArray shapes
https://bugs.webkit.org/show_bug.cgi?id=115805
Source/JavaScriptCore:
Reviewed by Geoffrey Garen.
It checks the observed ArrayModes to see if we have seen any ArrayWith* first. If so, it assumes it's
an Array::Array, even if we've also observed any NonArrayWith* in the ArrayProfile. This leads to the
code generated by jumpSlowForUnwantedArrayMode to check the indexing type against (shape | IsArray)
instead of just shape, which can cause us to exit a lot in the case that we saw a NonArray.
To fix this we need to add a case that checks for both ArrayWith* and NonArrayWith* cases first, which
should then use Array::PossiblyArray, then do the checks we were already doing.
- bytecode/ArrayProfile.h:
(JSC::hasSeenArray):
(JSC::hasSeenNonArray):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::fromObserved):
LayoutTests:
Added regression test for array access over polymorphic array vs. non-array indexing types.
With the fix, we get 3.666x faster on this microbenchmark.
Reviewed by Geoffrey Garen.
- fast/js/regress/array-nonarray-polymorphic-access-expected.txt: Added.
- fast/js/regress/array-nonarray-polymorphic-access.html: Added.
- fast/js/regress/script-tests/array-nonarray-polymorphic-access.js: Added.
(f):
(run):
- 12:24 PM Changeset in webkit [149833] by
-
- 7 edits in trunk/Source
RenderQuote has giant function for language to quotes map
https://bugs.webkit.org/show_bug.cgi?id=115807
Reviewed by Anders Carlsson.
Source/WebCore:
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::RenderQuote): Updated for m_isAttached name change.
(WebCore::RenderQuote::~RenderQuote): Updated for name change, and also split
assertion with && in it into two separate assertions.
(WebCore::checkNumberOfDistinctQuoteCharacters): Added. Helper function that is used
to check that the number of distinct quote characters is small enough to fit into
our fixed size array below.
(WebCore::quotesForLanguage): Replaces the old quotesDataLanguageMap function.
Returns a pointer to a struct that contains the four quote characters. This new
function doesn't have the massive amount of code that the old one did. We use the
standard library bsearch function to do a binary search.
(WebCore::stringForQuoteCharacter): Added. This returns a string for a given quote
character; one string for any given character.
(WebCore::quotationMarkString): Added. Returns the string for the quotation mark.
(WebCore::apostropheStringImpl): Added. Returns the string for the apostrophe.
(WebCore::RenderQuote::originalText): Rewrote this to include all the logic that
used to be in the quotesData function.
(WebCore::RenderQuote::attachQuote): Tweak assertions as above. Removed unneeded
special case for the first quote in a RenderView; sharing the code is better and
there is no significant performance difference. Also use m_isAttached directly
when looking at predecessores so there is no need for an isAttached function.
(WebCore::RenderQuote::detachQuote): Updated assertions and for name change.
(WebCore::RenderQuote::updateDepth): Ditto.
- rendering/RenderQuote.h: Removed unneeded includes. Marked the class FINAL since
we call the originalText function in the class and we don't want to do a virtual
function dispatch for that. Removed uneeded const from an argument. Removed a
stray semicolon. Removed the quotesData and isAttached functions, since they are no
longer needed. Renamed m_attached to m_isAttached.
- rendering/style/QuotesData.cpp: Removed the overload of QuotesData::create that
takes four quote strings. This was only used to build up the quotes table.
- rendering/style/QuotesData.h: Ditto.
Source/WTF:
- wtf/unicode/CharacterNames.h: Added a couple of character names.
- 12:03 PM Changeset in webkit [149832] by
-
- 15 edits in trunk/Source/WebKit2
Use explicit qualifiers for names in the std:: namespace
https://bugs.webkit.org/show_bug.cgi?id=115868
Reviewed by Andreas Kling.
- Shared/mac/ArgumentCodersMac.mm:
(CoreIPC::encode):
- UIProcess/API/C/WKPluginSiteDataManager.cpp:
(WKPluginSiteDataManagerClearAllSiteData):
- UIProcess/Plugins/PluginInfoStore.cpp:
(WebKit::PluginInfoStore::findPluginForExtension):
- UIProcess/WebFrameProxy.cpp:
- UIProcess/WebProcessProxy.cpp:
- WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::parsePostBuffer):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::loadURL):
- WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
(WebKit::NetscapePluginStream::deliverDataToPlugin):
- WebProcess/Plugins/PDF/SimplePDFPlugin.mm:
- WebProcess/WebPage/DrawingAreaImpl.cpp:
- WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::countStringMatches):
(WebKit::FindController::updateFindUIAfterPageScroll):
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::drawPDFPage):
- WebProcess/mac/WebProcessMac.mm:
- 12:00 PM Changeset in webkit [149831] by
-
- 8 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Update iInRegionScroller, WebKitTextCodec and WebPageCompositor
to match check-webkit-style updates.
- Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::setScrollPositionCompositingThread):
- Api/InRegionScroller_p.h:
- Api/WebKitTextCodec.cpp:
(BlackBerry::WebKit::transcode):
- Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositor::render):
- Api/WebPageCompositor.h:
- Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):
- Api/WebSettings_p.h:
- 11:49 AM Changeset in webkit [149830] by
-
- 14 edits3 adds in trunk
shouldUsePluginDocument() needs to be respected when a document is created
https://bugs.webkit.org/show_bug.cgi?id=110308
Patch by Max Feil <mfeil@rim.com> on 2013-05-09
Reviewed by Rob Buis.
Source/WebCore:
In DOMImplementation::createDocument() we should create
a PluginDocument for mime types that return "true" for
shouldAlwaysUsePluginDocument(), even if there is no pluginData
for them. This lets a client choose plugins for which the "missing
plugin" text or icon should appear more consistently. Otherwise
plugins referenced by iFrames will be treated as an HTMLDocument,
possibly resulting in binary files rendered as gibberish text.
Layout test platform/blackberry/plugins/swf-as-src-of-iframe.html
- dom/DOMImplementation.cpp:
(WebCore::DOMImplementation::createDocument):
Source/WebKit/blackberry:
This patch implements shouldAlwaysUsePluginDocument() in the
BlackBerry frame loader client. It is called in several places
within WebCore to determine whether a PluginDocument should
be created.
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::shouldAlwaysUsePluginDocument):
(WebCore):
(WebCore::FrameLoaderClientBlackBerry::createPlugin):
- WebCoreSupport/FrameLoaderClientBlackBerry.h:
(FrameLoaderClientBlackBerry):
Source/WebKit/win:
Renaming shouldUsePluginDocument() to shouldAlwaysUsePluginDocument()
for clarity.
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::shouldAlwaysUsePluginDocument):
- WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient):
Source/WebKit2:
Renaming shouldUsePluginDocument() to shouldAlwaysUsePluginDocument()
for clarity.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::shouldAlwaysUsePluginDocument):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
(WebFrameLoaderClient):
- 11:47 AM Changeset in webkit [149829] by
-
- 2 edits in trunk/Source/WebCore
Fix an exception when hovering native functions while paused in the debugger.
https://webkit.org/b/115866
rdar://problem/13681982
Reviewed by Darin Adler and Joseph Pecoraro.
- inspector/InjectedScriptSource.js:
(InjectedScript.prototype.getFunctionDetails): Return an error if the details
is null or undefined.
- 11:42 AM Changeset in webkit [149828] by
-
- 2 edits in trunk/Source/WebCore
[Mac] CFError leak under Objective-C garbage collection
https://bugs.webkit.org/show_bug.cgi?id=115862
Reviewed by Benjamin Poulain.
- platform/network/mac/ResourceErrorMac.mm:
(WebCore::ResourceError::nsError): Use adoptCF instead of adoptNS since
the CFError needs a CFRelease, not an -[NSObject release].
- 11:38 AM Changeset in webkit [149827] by
-
- 2 edits in trunk/Source/WebCore
BlackBerry: fix call to PluginLayerWebKitThread::setHolePunchRect()
https://bugs.webkit.org/show_bug.cgi?id=114953
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-09
Reviewed by Rob Buis.
data->layer needs a cast in order to call setHolePunchRect().
- plugins/blackberry/NPCallbacksBlackBerry.cpp:
(WebCore::npSetHolePunchHandler):
- 11:32 AM Changeset in webkit [149826] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Update SelectionHandler to match check-webkit-style updates.
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::shouldExtendSelectionInDirection):
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
(BlackBerry::WebKit::SelectionHandler::updateOrHandleInputSelection):
(BlackBerry::WebKit::adjustCaretRects):
(BlackBerry::WebKit::SelectionHandler::clipPointToVisibleContainer):
(BlackBerry::WebKit::regionRectListContainsPoint):
- WebKitSupport/SelectionHandler.h:
(SelectionHandler):
- 11:24 AM Changeset in webkit [149825] by
-
- 2 edits in trunk/Source/JavaScriptCore
[BlackBerry] Set up logging buffer on start of jsc executable
https://bugs.webkit.org/show_bug.cgi?id=114688
Patch by Joe Mason <jmason@blackberry.com> on 2013-05-09
Reviewed by Rob Buis.
Internal PR: 322715
Internally Reviewed By: Jeff Rogers
- jsc.cpp:
(main): call BB::Platform::setupApplicationLogging
- 11:13 AM Changeset in webkit [149824] by
-
- 11 edits in trunk/Source/WebCore
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Update WebCore/platform/graphics BlackBerry sources
to match check-webkit-style updates.
Internally reviewed by Jakob Petsovits.
- platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
- platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::readPixelsIMG):
(WebCore::GraphicsContext3D::paintToCanvas):
- platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore::GraphicsLayerBlackBerry::updateLayerPosition):
- platform/graphics/blackberry/IntRectBlackBerry.cpp:
(WebCore::IntRect::IntRect):
- platform/graphics/blackberry/LayerCompositingThread.h:
(WTF::::deref):
- platform/graphics/blackberry/LayerFilterRenderer.cpp:
(WebCore::LayerFilterRenderer::initializeSharedGLObjects):
(WebCore::LayerFilterRenderer::actionsForOperations):
(WebCore::LayerFilterRenderer::applyActions):
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::setViewport):
(WebCore::LayerRenderer::compositeBuffer):
(WebCore::LayerRenderer::drawColor):
(WebCore::LayerRenderer::compositeLayersRecursive):
- platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::setFrame):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):
- platform/image-decoders/blackberry/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::JPEGImageDecoder):
- 11:02 AM Changeset in webkit [149823] by
-
- 5 edits in trunk/Source/WebCore
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Update WebCore/platform/network/blackberry
to match check-webkit-style updates.
- platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::initialize):
(WebCore::NetworkJob::handleSetCookieHeader):
(WebCore::NetworkJob::sendResponseIfNeeded):
(WebCore::NetworkJob::shouldSendClientData):
- platform/network/blackberry/NetworkJob.h:
(NetworkJob):
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
- platform/network/blackberry/rss/RSSFilterStream.cpp:
(WebCore::isRSSContent):
(WebCore::transcode):
- 10:59 AM Changeset in webkit [149822] by
-
- 11 edits in trunk/Source/WebCore
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Update WebCore/platform/blackberry to match check-webkit-style updates.
No functional changes.
- platform/blackberry/CookieDatabaseBackingStore/CookieDatabaseBackingStore.h:
- platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::getRawCookies):
- platform/blackberry/CookieMap.h:
(WebCore::CookieMap::count):
- platform/blackberry/CookieParser.cpp:
(WebCore::CookieParser::parseOneCookie):
- platform/blackberry/LoggingBlackBerry.cpp:
- platform/blackberry/PageClientBlackBerry.h:
(Platform):
(Graphics):
(WebCore):
- platform/blackberry/ParsedCookie.cpp:
(WebCore::ParsedCookie::appendWebCoreCookie):
- platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore::RenderThemeBlackBerry::paintSearchFieldCancelButton):
(WebCore::RenderThemeBlackBerry::paintButton):
(WebCore::RenderThemeBlackBerry::paintSliderThumb):
- platform/blackberry/SSLKeyGeneratorBlackBerry.cpp:
(WebCore::signedPublicKeyAndChallengeString):
- platform/blackberry/ScrollAnimatorBlackBerry.h:
- 10:40 AM Changeset in webkit [149821] by
-
- 4 edits4 adds in trunk/Source
JSC: There should be a disassembler for ARM Thumb 2
https://bugs.webkit.org/show_bug.cgi?id=115827
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Added a new disassembler for ARMv7 Thumb2 instructions for use by the JSC debugging
and profiling code. The opcode coverage is currently not complete. It covers all
of the integer instructions JSC currently emits, but only a limited number of
floating point opcodes. Currently that is just the 64 bit vmov and vmsr instructions.
The disassembler is structured as a base opcode class ARMv7DOpcode with sub-classes
for each instruction group. There is a public format method that does the bulk of
the disassembly work. There are two broad sub-classes, ARMv7D16BitOpcode and
ARMv7D32BitOpcode, for the 16 bit and 32 bit opcodes. There are sub-classes under
those two classes for individual and related groups of opcodes. Instructions are
"dispatched" to the right subclass via two arrays of linked lists in the inner classes
OpcodeGroup. There is one such inner class for each ARMv7D16BitOpcode and ARMv7D32BitOpcode.
Each OpcodeGroup has a mask and a pattern that it applies to the instruction to determine
that it matches a particular group. OpcodeGroup uses a static method to reinterpret_cast
the Opcode object to the right base class for the instruction group for formatting.
The cast eliminates the need of allocating an object for each decoded instruction.
Unknown instructions are formatted as ".word 1234" or ".long 12345678" depending whether
the instruction is 16 or 32 bit.
- JavaScriptCore.xcodeproj/project.pbxproj:
- disassembler/ARMv7: Added.
- disassembler/ARMv7/ARMv7DOpcode.cpp: Added.
(ARMv7Disassembler):
(OpcodeGroupInitializer):
(JSC::ARMv7Disassembler::ARMv7DOpcode::init):
(JSC::ARMv7Disassembler::ARMv7DOpcode::startITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::saveITConditionAt):
(JSC::ARMv7Disassembler::ARMv7DOpcode::fetchOpcode):
(JSC::ARMv7Disassembler::ARMv7DOpcode::disassemble):
(JSC::ARMv7Disassembler::ARMv7DOpcode::bufferPrintf):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendInstructionName):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendRegisterName):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendRegisterList):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendFPRegisterName):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::init):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::doDisassemble):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::defaultFormat):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddRegisterT2::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSPPlusImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchConditionalT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchExchangeT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchT2::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareImmediateT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT2::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeGeneratePCRelativeAddress::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadFromLiteralPool::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLogicalImmediateT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscAddSubSP::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscBreakpointT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscByteHalfwordOps::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscHint16::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscIfThenT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscPushPop::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveImmediateT1::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveRegisterT1::format):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::init):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::doDisassemble):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::defaultFormat):
(JSC::ARMv7Disassembler::ARMv7DOpcodeConditionalBranchT3::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchOrBranchLink::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::appendModifiedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::appendImmShift):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::appendFPRegister):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegShift::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegExtend::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegParallel::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegMisc::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadRegister::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadUnsignedImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataPushPopSingle::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate12::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleRegister::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::format):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMSR::format):
- disassembler/ARMv7/ARMv7DOpcode.h: Added.
(ARMv7Disassembler):
(ARMv7DOpcode):
(JSC::ARMv7Disassembler::ARMv7DOpcode::ARMv7DOpcode):
(JSC::ARMv7Disassembler::ARMv7DOpcode::is32BitInstruction):
(JSC::ARMv7Disassembler::ARMv7DOpcode::isFPInstruction):
(JSC::ARMv7Disassembler::ARMv7DOpcode::conditionName):
(JSC::ARMv7Disassembler::ARMv7DOpcode::shiftName):
(JSC::ARMv7Disassembler::ARMv7DOpcode::inITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::startingITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::endITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendInstructionNameNoITBlock):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendSeparator):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendCharacter):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendString):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendShiftType):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendSignedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendUnsignedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendPCRelativeOffset):
(JSC::ARMv7Disassembler::ARMv7DOpcode::appendShiftAmount):
(ARMv7D16BitOpcode):
(OpcodeGroup):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::OpcodeGroup):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::setNext):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::next):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::matches):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::OpcodeGroup::format):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::rm):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::rd):
(JSC::ARMv7Disassembler::ARMv7D16BitOpcode::opcodeGroupNumber):
(ARMv7DOpcodeAddRegisterT2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddRegisterT2::rdn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddRegisterT2::rm):
(ARMv7DOpcodeAddSPPlusImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSPPlusImmediate::rd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSPPlusImmediate::immediate8):
(ARMv7DOpcodeAddSubtract):
(ARMv7DOpcodeAddSubtractT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::rm):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractT1::rn):
(ARMv7DOpcodeAddSubtractImmediate3):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::immediate3):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate3::rn):
(ARMv7DOpcodeAddSubtractImmediate8):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::rdn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeAddSubtractImmediate8::immediate8):
(ARMv7DOpcodeBranchConditionalT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchConditionalT1::condition):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchConditionalT1::offset):
(ARMv7DOpcodeBranchExchangeT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchExchangeT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchExchangeT1::rm):
(ARMv7DOpcodeBranchT2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchT2::immediate11):
(ARMv7DOpcodeCompareImmediateT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareImmediateT1::rn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareImmediateT1::immediate8):
(ARMv7DOpcodeCompareRegisterT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT1::rn):
(ARMv7DOpcodeCompareRegisterT2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT2::rn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeCompareRegisterT2::rm):
(ARMv7DOpcodeDataProcessingRegisterT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::rm):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegisterT1::rdn):
(ARMv7DOpcodeGeneratePCRelativeAddress):
(JSC::ARMv7Disassembler::ARMv7DOpcodeGeneratePCRelativeAddress::rd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeGeneratePCRelativeAddress::immediate8):
(ARMv7DOpcodeLoadFromLiteralPool):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadFromLiteralPool::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadFromLiteralPool::immediate8):
(ARMv7DOpcodeLoadStoreRegisterImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::immediate5):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::rn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterImmediate::scale):
(ARMv7DOpcodeLoadStoreRegisterImmediateWordAndByte):
(ARMv7DOpcodeLoadStoreRegisterImmediateHalfWord):
(ARMv7DOpcodeLoadStoreRegisterOffsetT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::opB):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::rm):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::rn):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterOffsetT1::rt):
(ARMv7DOpcodeLoadStoreRegisterSPRelative):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadStoreRegisterSPRelative::immediate8):
(ARMv7DOpcodeLogicalImmediateT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLogicalImmediateT1::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLogicalImmediateT1::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLogicalImmediateT1::immediate5):
(ARMv7DOpcodeMiscAddSubSP):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscAddSubSP::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscAddSubSP::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscAddSubSP::immediate7):
(ARMv7DOpcodeMiscByteHalfwordOps):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscByteHalfwordOps::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscByteHalfwordOps::op):
(ARMv7DOpcodeMiscBreakpointT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscBreakpointT1::immediate8):
(ARMv7DOpcodeMiscCompareAndBranch):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::immediate6):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscCompareAndBranch::rn):
(ARMv7DOpcodeMiscHint16):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscHint16::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscHint16::opA):
(ARMv7DOpcodeMiscIfThenT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscIfThenT1::firstCondition):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscIfThenT1::mask):
(ARMv7DOpcodeMiscPushPop):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscPushPop::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscPushPop::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMiscPushPop::registerMask):
(ARMv7DOpcodeMoveImmediateT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveImmediateT1::rd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveImmediateT1::immediate8):
(ARMv7DOpcodeMoveRegisterT1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveRegisterT1::rd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeMoveRegisterT1::rm):
(ARMv7D32BitOpcode):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::OpcodeGroup):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::setNext):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::next):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::matches):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::OpcodeGroup::format):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::rd):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::rm):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::rn):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::rt):
(JSC::ARMv7Disassembler::ARMv7D32BitOpcode::opcodeGroupNumber):
(ARMv7DOpcodeBranchRelative):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchRelative::sBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchRelative::j1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchRelative::j2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchRelative::immediate11):
(ARMv7DOpcodeConditionalBranchT3):
(JSC::ARMv7Disassembler::ARMv7DOpcodeConditionalBranchT3::offset):
(JSC::ARMv7Disassembler::ARMv7DOpcodeConditionalBranchT3::condition):
(JSC::ARMv7Disassembler::ARMv7DOpcodeConditionalBranchT3::immediate6):
(ARMv7DOpcodeBranchOrBranchLink):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchOrBranchLink::offset):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchOrBranchLink::immediate10):
(JSC::ARMv7Disassembler::ARMv7DOpcodeBranchOrBranchLink::isBL):
(ARMv7DOpcodeDataProcessingLogicalAndRithmetic):
(ARMv7DOpcodeDataProcessingModifiedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::sBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingModifiedImmediate::immediate12):
(ARMv7DOpcodeDataProcessingShiftedReg):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::sBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::immediate5):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::type):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::tbBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingShiftedReg::tBit):
(ARMv7DOpcodeDataProcessingReg):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingReg::op1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingReg::op2):
(ARMv7DOpcodeDataProcessingRegShift):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegShift::opName):
(ARMv7DOpcodeDataProcessingRegExtend):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegExtend::opExtendName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegExtend::opExtendAndAddName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegExtend::rotate):
(ARMv7DOpcodeDataProcessingRegParallel):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegParallel::opName):
(ARMv7DOpcodeDataProcessingRegMisc):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataProcessingRegMisc::opName):
(ARMv7DOpcodeHint32):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::isDebugHint):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::debugOption):
(JSC::ARMv7Disassembler::ARMv7DOpcodeHint32::op):
(ARMv7DOpcodeFPTransfer):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::opH):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::opL):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::opC):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::opB):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::vd):
(JSC::ARMv7Disassembler::ARMv7DOpcodeFPTransfer::vn):
(ARMv7DOpcodeDataLoad):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataLoad::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataLoad::op):
(ARMv7DOpcodeLoadRegister):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadRegister::immediate2):
(ARMv7DOpcodeLoadSignedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::pBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::uBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::wBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadSignedImmediate::immediate8):
(ARMv7DOpcodeLoadUnsignedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLoadUnsignedImmediate::immediate12):
(ARMv7DOpcodeLongMultipleDivide):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::smlalOpName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::smlaldOpName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::smlsldOpName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::rdLo):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::rdHi):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::op1):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::op2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::nBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeLongMultipleDivide::mBit):
(ARMv7DOpcodeDataPushPopSingle):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataPushPopSingle::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataPushPopSingle::op):
(ARMv7DOpcodeDataStoreSingle):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataStoreSingle::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeDataStoreSingle::op):
(ARMv7DOpcodeStoreSingleImmediate12):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate12::immediate12):
(ARMv7DOpcodeStoreSingleImmediate8):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::pBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::uBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::wBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleImmediate8::immediate8):
(ARMv7DOpcodeStoreSingleRegister):
(JSC::ARMv7Disassembler::ARMv7DOpcodeStoreSingleRegister::immediate2):
(ARMv7DOpcodeUnmodifiedImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::opName):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::shBit):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::bitNumOrSatImmediate):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::immediate5):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::immediate12):
(JSC::ARMv7Disassembler::ARMv7DOpcodeUnmodifiedImmediate::immediate16):
(ARMv7DOpcodeVMOVDoublePrecision):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::rt2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVDoublePrecision::vm):
(ARMv7DOpcodeVMOVSinglePrecision):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::op):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::rt2):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::rt):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMOVSinglePrecision::vm):
(ARMv7DOpcodeVMSR):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMSR::opL):
(JSC::ARMv7Disassembler::ARMv7DOpcodeVMSR::rt):
- disassembler/ARMv7Disassembler.cpp: Added.
(JSC::tryToDisassemble):
Source/WTF:
Added a new disassembler for ARMv7 Thumb2 instructions for use by the JSC debugging
and profiling code. Enabled the disassembler for IOS bulds.
- wtf/Platform.h:
- 9:54 AM Changeset in webkit [149820] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Update WebPage and WebPageClient to match check-webkit-style updates.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPage::executeJavaScriptInIsolatedWorld):
(BlackBerry::WebKit::WebPagePrivate::zoomAboutPoint):
(BlackBerry::WebKit::WebPagePrivate::calculateReflowedScrollPosition):
(BlackBerry::WebKit::WebPagePrivate::centerOfVisibleContentsRect):
(BlackBerry::WebKit::WebPage::assignFocus):
(BlackBerry::WebKit::WebPagePrivate::resumeBackingStore):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
(BlackBerry::WebKit::WebPage::deleteTextRelativeToCursor):
(BlackBerry::WebKit::WebPage::addVisitedLink):
(BlackBerry::WebKit::WebPagePrivate::findPatternStringForUrl):
(BlackBerry::WebKit::WebPage::notifySwipeEvent):
(BlackBerry::WebKit::WebPage::notifyScreenPowerStateChanged):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::setRootLayerWebKitThread):
(BlackBerry::WebKit::WebPagePrivate::releaseLayerResourcesCompositingThread):
- Api/WebPageClient.h:
- Api/WebPage_p.h:
- 9:51 AM Changeset in webkit [149819] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Update BackingStore to match check-webkit-style updates.
Internally reviewed by Jakob Petsovits.
- Api/BackingStore.cpp:
(BlackBerry::WebKit::bestDivisor):
(BlackBerry::WebKit::BackingStorePrivate::repaint):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveLeft):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveRight):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveUp):
(BlackBerry::WebKit::BackingStorePrivate::shouldMoveDown):
(BlackBerry::WebKit::BackingStorePrivate::canMoveLeft):
(BlackBerry::WebKit::BackingStorePrivate::canMoveRight):
(BlackBerry::WebKit::BackingStorePrivate::canMoveUp):
(BlackBerry::WebKit::BackingStorePrivate::canMoveDown):
(BlackBerry::WebKit::BackingStorePrivate::indexOfTile):
(BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
(BlackBerry::WebKit::BackingStorePrivate::scrollBackingStore):
(BlackBerry::WebKit::BackingStoreGeometry::originOfTile):
(BlackBerry::WebKit::BackingStore::repaint):
- Api/BackingStore_p.h:
(BackingStoreGeometry):
- 9:36 AM WebKit Team edited by
- Adding myself (diff)
- 9:16 AM Changeset in webkit [149818] by
-
- 8 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Update ChromeClientBlackBerry, CredentialManager, FrameLoaderClientBlackBerry,
GeolocationClientBlackBerry and IconDatabaseClientBlackberry to
match check-webkit-style updates.
- WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):
- WebCoreSupport/CredentialManager.h:
(CredentialManager):
- WebCoreSupport/CredentialTransformData.cpp:
- WebCoreSupport/FrameLoaderClientBlackBerry.h:
(WebCore::FrameLoaderClientBlackBerry::assignIdentifierToInitialRequest):
(FrameLoaderClientBlackBerry):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveAuthenticationChallenge):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidCancelAuthenticationChallenge):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveContentLength):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoading):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailLoading):
- WebCoreSupport/GeolocationClientBlackBerry.cpp:
(GeolocationClientBlackBerry::onLocationUpdate):
- WebCoreSupport/GeolocationClientBlackBerry.h:
(GeolocationClientBlackBerry):
- WebCoreSupport/IconDatabaseClientBlackBerry.cpp:
(WebCore::IconDatabaseClientBlackBerry::initIconDatabase):
- 9:13 AM Changeset in webkit [149817] by
-
- 29 edits in trunk/Source/WebCore
Require use of AudioBus::create() to avoid ref-counting issues
https://bugs.webkit.org/show_bug.cgi?id=115836
Reviewed by Andreas Kling.
There were a couple of places still embedding raw AudioBus objects as
member variables or local variables causing ref-counting problems
now that AudioBus is ref-counted. Make AudioBus constructor private
to enforce use of AudioBus::create().
Adapted from Blink patch:
https://chromiumcodereview.appspot.com/14628008/
- Modules/webaudio/AudioDestinationNode.h:
(WebCore::AudioDestinationNode::LocalAudioInputProvider::LocalAudioInputProvider):
(WebCore::AudioDestinationNode::LocalAudioInputProvider::set):
(WebCore::AudioDestinationNode::LocalAudioInputProvider::provideInput):
(LocalAudioInputProvider):
- Modules/webaudio/AudioNodeInput.cpp:
(WebCore::AudioNodeInput::AudioNodeInput):
(WebCore::AudioNodeInput::updateInternalBus):
- Modules/webaudio/AudioNodeOutput.cpp:
(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::updateInternalBus):
- Modules/webaudio/AudioParam.cpp:
(WebCore::AudioParam::calculateFinalValues):
- Modules/webaudio/ConvolverNode.cpp:
(WebCore::ConvolverNode::setBuffer):
- Modules/webaudio/MediaStreamAudioDestinationNode.cpp:
(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):
(WebCore::MediaStreamAudioDestinationNode::process):
- Modules/webaudio/MediaStreamAudioDestinationNode.h:
- Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
- Modules/webaudio/ScriptProcessorNode.cpp:
(WebCore::ScriptProcessorNode::ScriptProcessorNode):
(WebCore::ScriptProcessorNode::process):
- Modules/webaudio/ScriptProcessorNode.h:
(ScriptProcessorNode):
- platform/audio/AudioBus.cpp:
(WebCore::AudioBus::create):
(WebCore):
(WebCore::AudioBus::AudioBus):
(WebCore::AudioBus::createBufferFromRange):
(WebCore::AudioBus::createBySampleRateConverting):
(WebCore::AudioBus::createByMixingToMono):
- platform/audio/AudioBus.h:
(AudioBus):
- platform/audio/AudioFIFO.cpp:
(WebCore::AudioFIFO::AudioFIFO):
(WebCore::AudioFIFO::consume):
(WebCore::AudioFIFO::push):
- platform/audio/AudioFIFO.h:
(AudioFIFO):
- platform/audio/AudioPullFIFO.cpp:
(WebCore::AudioPullFIFO::AudioPullFIFO):
(WebCore::AudioPullFIFO::fillBuffer):
- platform/audio/AudioPullFIFO.h:
(AudioPullFIFO):
- platform/audio/AudioResampler.cpp:
(WebCore::AudioResampler::AudioResampler):
(WebCore::AudioResampler::configureChannels):
- platform/audio/MultiChannelResampler.cpp:
- platform/audio/Reverb.cpp:
(WebCore::Reverb::initialize):
- platform/audio/SincResampler.cpp:
(WebCore::SincResampler::consumeSource):
(WebCore):
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
(WebCore::AudioDestinationGStreamer::AudioDestinationGStreamer):
- platform/audio/gstreamer/AudioDestinationGStreamer.h:
(AudioDestinationGStreamer):
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::AudioFileReader::createBus):
- platform/audio/ios/AudioDestinationIOS.cpp:
(WebCore::AudioDestinationIOS::AudioDestinationIOS):
(WebCore::AudioDestinationIOS::render):
- platform/audio/ios/AudioDestinationIOS.h:
(AudioDestinationIOS):
- platform/audio/mac/AudioDestinationMac.cpp:
(WebCore::AudioDestinationMac::AudioDestinationMac):
(WebCore::AudioDestinationMac::render):
- platform/audio/mac/AudioDestinationMac.h:
(AudioDestinationMac):
- platform/audio/mac/AudioFileReaderMac.cpp:
(WebCore::AudioFileReader::createBus):
- 9:09 AM Changeset in webkit [149816] by
-
- 5 edits in trunk/Source/WebKit/blackberry
Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790
Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-05-09.
Reviewed by Rob Buis.
Fix the following warnings for BlackBerry:
InRegionScroller.cpp:286:39: warning: suggest parentheses around
assignment used as truth value [-Wparentheses].
InRegionScroller.cpp:349:39: warning: suggest parentheses around
assignment used as truth value [-Wparentheses].
InRegionScroller.cpp:456:82: warning: suggest parentheses around '&&'
within ' ' [-Wparentheses]. InRegionScrollableArea.cpp:134:16: warning: suggest explicit braces to
avoid ambiguous 'else' [-Wparentheses].
SelectionHandler.cpp:390:109: warning: suggest parentheses around '&&'
within ' ' [-Wparentheses]. SelectionOverlay.cpp:56:47: warning: comparison between signed and
unsigned integer expressions [-Wsign-compare].
- Api/InRegionScroller.cpp:
(BlackBerry::WebKit::InRegionScrollerPrivate::calculateInRegionScrollableAreasForPoint):
(BlackBerry::WebKit::InRegionScrollerPrivate::firstScrollableInRegionForNode):
(BlackBerry::WebKit::InRegionScrollerPrivate::canScrollRenderBox):
- WebKitSupport/InRegionScrollableArea.cpp:
(BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::extendSelectionToFieldBoundary):
- WebKitSupport/SelectionOverlay.cpp:
(BlackBerry::WebKit::SelectionOverlay::draw):
- 9:02 AM Changeset in webkit [149815] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Update ColorPickerClient and PagePopupBlackBerry
to match check-webkit-style updates.
- WebCoreSupport/ColorPickerClient.cpp:
(WebCore::ColorPickerClient::generateHTML):
- WebCoreSupport/PagePopupBlackBerry.cpp:
(WebCore::setValueAndClosePopupCallback):
(WebCore::PagePopupBlackBerry::installDOMFunction):
- 8:51 AM Changeset in webkit [149814] by
-
- 9 edits4 adds in trunk/Source
[BlackBerry] Upstream the input popups
https://bugs.webkit.org/show_bug.cgi?id=114608
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-09
Reviewed by Rob Buis.
This patch contains contributions from many members of the
BlackBerry WebKit team, including:
Chris Hutten-Czapski
David Hoon
Jessica Cao
Rob Buis
Tiancheng Jiang
Source/WebCore:
- Resources/blackberry/colorControlBlackBerry.css: Added.
(.color-picker-popup-area):
(.color-picker-content):
(.color-picker-block):
(#color-picker-swatch-block):
(.color-picker-switcher):
(.color-picker-check-mark):
(.color-picker-option):
(.color-picker-button):
(.color-picker-highlight):
(input):
(.color-picker-sharp):
(.color-picker-off):
(.color-picker-inactive-font):
(.color-picker-row):
(.color-picker-hex-style):
(.color-picker-input):
(.color-picker-well):
(.color-picker-input .color-picker-well):
(.color-picker-slider):
(.color-picker-slider-output):
(.color-picker-range):
(.color-picker-range::-webkit-slider-thumb):
(.color-picker-range::-webkit-slider-thumb:active):
(.red-ranger-bg):
(.green-ranger-bg):
(.blue-ranger-bg):
(@media only screen and (height: 768px)):
(@media only screen and (height: 720px)):
- Resources/blackberry/colorControlBlackBerry.js: Added.
(.):
- Resources/blackberry/popupControlBlackBerry.css:
(body):
(.popup-area):
(.popup-header):
(.popup-content):
(.popup-buttons):
(.popup-button):
(@media only screen and (width: 720px) and (height: 720px)):
- Resources/blackberry/selectControlBlackBerry.css:
(.popup-content):
(@media (min-height: 918px)):
(.option):
(@media only screen and (width: 720px) and (height: 720px)):
(.contents):
(.option:active):
(.selected):
(.selected .contents::after):
(.text):
(.disabled):
(.optgroup):
(.optgroup-option):
- Resources/blackberry/selectControlBlackBerry.js:
(.):
- Resources/blackberry/timeControlBlackBerry.css: Added.
(#popup-content-time):
(.column):
(.column:not(:last-child)):
(.cell):
(.yearmonthdate .cell div:last-child):
(.row-highlight-container):
(.row-highlight-filler):
(.row-highlight):
(.tall-bit):
(@media only screen and (width: 720px) and (height: 720px)):
- Resources/blackberry/timeControlBlackBerry.js: Added.
(.):
Source/WebKit/blackberry:
- WebCoreSupport/ColorPickerClient.cpp:
(WebCore):
(WebCore::ColorPickerClient::generateHTML):
- WebCoreSupport/DatePickerClient.cpp:
(WebCore):
(WebCore::DatePickerClient::generateHTML):
(WebCore::DatePickerClient::generateDateLabels):
- WebCoreSupport/DatePickerClient.h:
(DatePickerClient):
- WebCoreSupport/SelectPopupClient.cpp:
(WebCore):
(WebCore::SelectPopupClient::generateHTML):
- 8:46 AM Changeset in webkit [149813] by
-
- 16 edits in trunk/Source/WebCore
[BlackBerry] texmap code generates warnings
https://bugs.webkit.org/show_bug.cgi?id=115815
Patch by Rob Buis <rbuis@rim.com> on 2013-05-09
Reviewed by Benjamin Poulain.
Add USE(TEXTURE_MAPPER) guards since Source/WebCore/CMakeLists.txt includes
these files unconditionally.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
- platform/graphics/texmap/TextureMapper.h:
- platform/graphics/texmap/TextureMapperBackingStore.cpp:
- platform/graphics/texmap/TextureMapperBackingStore.h:
- platform/graphics/texmap/TextureMapperFPSCounter.cpp:
- platform/graphics/texmap/TextureMapperFPSCounter.h:
- platform/graphics/texmap/TextureMapperGL.cpp:
- platform/graphics/texmap/TextureMapperGL.h:
- platform/graphics/texmap/TextureMapperLayer.cpp:
- platform/graphics/texmap/TextureMapperLayer.h:
- platform/graphics/texmap/TextureMapperTile.cpp:
- platform/graphics/texmap/TextureMapperTile.h:
- platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:
- platform/graphics/texmap/TextureMapperTiledBackingStore.h:
- 8:44 AM Changeset in webkit [149812] by
-
- 2 edits in trunk/Source/WebCore
PluginDatabase: add plugin directory for the BlackBerry port.
https://bugs.webkit.org/show_bug.cgi?id=114943
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-09
Reviewed by Rob Buis.
XP_UNIX is defined for the BlackBerry port, but we don't want to
share the same code here.
- plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::defaultPluginDirectories):
(WebCore::PluginDatabase::isPreferredPluginDirectory):
- 8:43 AM Changeset in webkit [149811] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Update DOMSupport to match check-webkit-style updates.
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isTextInputElement):
(BlackBerry::WebKit::DOMSupport::isPasswordElement):
(BlackBerry::WebKit::DOMSupport::convertPointToFrame):
- 8:42 AM Changeset in webkit [149810] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BLACKBERRY]fix regression in Webpage
and FrameLoaderClientBlackberry
https://bugs.webkit.org/show_bug.cgi?id=115843
Patch by Xuefei Ren <xren@blackberry.com> on 2013-05-09
Reviewed by Rob Buis.
Internally reviewed by Mary Wu.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::loadFile):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::startDownload):
- 8:35 AM Changeset in webkit [149809] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Update FatFingers to match check-webkit-style updates.
- WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::checkFingerIntersection):
(BlackBerry::WebKit::FatFingers::checkForClickableElement):
- WebKitSupport/FatFingers.h:
(FatFingersResult):
- 8:26 AM Changeset in webkit [149808] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Update InRegionScrollableArea, TileIndexHash
and TouchEventHandler to match check-webkit-style updates.
- WebKitSupport/InRegionScrollableArea.cpp:
- WebKitSupport/TileIndexHash.h:
- WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
- 8:16 AM Changeset in webkit [149807] by
-
- 8 edits2 deletes in trunk/Source/WebCore
Web Inspector: Remove Memory Distribution and Memory Snapshots Panels
https://bugs.webkit.org/show_bug.cgi?id=115850
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-09
Reviewed by Andreas Kling.
Removed the Memory Instrumentation Code after r148921.
No new tests, no behavior change.
- inspector/compile-front-end.py:
- inspector/front-end/NativeMemorySnapshotView.js: Removed.
- inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
- inspector/front-end/Settings.js:
(WebInspector.Settings):
(WebInspector.ExperimentsSettings):
- inspector/front-end/SettingsScreen.js:
- inspector/front-end/WebKit.qrc:
- inspector/front-end/inspector.css:
- inspector/front-end/inspector.js:
(WebInspector._panelDescriptors):
- inspector/front-end/nativeMemoryProfiler.css: Removed.
- 8:11 AM Changeset in webkit [149806] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Style updates required based on new check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=115857
Reviewed by Rob Buis.
Styles fixes required for InputHandler based on updated
check-webkit-style.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
(BlackBerry::WebKit::InputHandler::ensureFocusPluginElementVisible):
(BlackBerry::WebKit::InputHandler::setPopupListIndexes):
(BlackBerry::WebKit::InputHandler::firstSpanInString):
(BlackBerry::WebKit::InputHandler::setTextAttributes):
- WebKitSupport/InputHandler.h:
- 7:26 AM Changeset in webkit [149805] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed GTK build fix after r149796.
- GNUmakefile.am: Add a phony target for the window constructors file and include it among
the dependencies for the non-generated code.
- 7:03 AM Changeset in webkit [149804] by
-
- 2 edits in trunk/Source/WebKit2
Make dragging off a tab in Safari with a docked Inspector reattach the Inspector.
https://webkit.org/b/115832
rdar://problem/13605661
Reviewed by Benjamin Poulain.
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformBringToFront):
If the Web Inspector is no longer in the same window as the inspected view,
then we need to reopen the Inspector to get it attached to the right window.
- 6:50 AM Changeset in webkit [149803] by
-
- 5 edits in trunk/LayoutTests
[CSSRegions] Change fast/regions/webkit-flow-inlines-inside-regions-bounds[-vertical] tests to make them platform independent
https://bugs.webkit.org/show_bug.cgi?id=115851
Patch by Radu Stavila <stavila@adobe.com> on 2013-05-09
Reviewed by Antti Koivisto.
Modified tests to make them platform independent by using Ahem and no font smoothing.
- fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.html:
- fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.html:
- fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html:
- fast/regions/webkit-flow-inlines-inside-regions-bounds.html:
- 6:48 AM Changeset in webkit [149802] by
-
- 10 edits in trunk/LayoutTests
[Qt][EFL][GTK] Failing CSS region tests
https://bugs.webkit.org/show_bug.cgi?id=115785
Patch by Radu Stavila <stavila@adobe.com> on 2013-05-09
Reviewed by Antti Koivisto.
Updated tests to overcome platform differences
Unskip fixed CSS regions tests
- fast/regions/webkit-flow-double-pagination-float-push-expected.html:
- fast/regions/webkit-flow-double-pagination-float-push.html:
- fast/regions/webkit-flow-float-pushed-to-last-region-expected.html:
- fast/regions/webkit-flow-float-pushed-to-last-region.html:
- fast/regions/webkit-flow-float-unable-to-push-expected.html:
- fast/regions/webkit-flow-float-unable-to-push.html:
- fast/regions/webkit-flow-floats-inside-regions-bounds-expected.html:
- fast/regions/webkit-flow-floats-inside-regions-bounds.html:
- platform/qt/TestExpectations:
- 6:12 AM Changeset in webkit [149801] by
-
- 9 edits10 copies36 adds in trunk/LayoutTests
[Qt] Unreviewed gardeing. Updating some png expected results.
- platform/qt-5.0-wk2/compositing/checkerboard-expected.png: Added.
- platform/qt-5.0-wk2/css3/unicode-bidi-isolate-basic-expected.png: Added.
- platform/qt-5.0-wk2/editing/deleting/delete-image-001-expected.png: Added.
- platform/qt-5.0-wk2/editing/inserting/typing-around-image-001-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/caret-rtl-2-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/caret-rtl-2-left-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/caret-rtl-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/extend-by-character-002-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/extend-selection-bidi-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/unrendered-001-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png: Added.
- platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png: Added.
- platform/qt-5.0-wk2/fast/borders/rtl-border-04-expecrted.png: Added.
- platform/qt-5.0-wk2/fast/borders/rtl-border-05-expected.png: Added.
- platform/qt-5.0-wk2/fast/box-shadow/shadow-repaint-expected.txt: Added.
- platform/qt-5.0-wk2/fast/dom/34176-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label06-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label07-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.png:
- platform/qt-5.0-wk2/fast/forms/listbox-bidi-align-expected.png: Added.
- platform/qt-5.0-wk2/fast/forms/search-rtl-expected.png: Added.
- platform/qt-5.0-wk2/fast/frames/transparent-scrollbar-expected.png: Added.
- platform/qt-5.0-wk2/fast/inline/inline-box-background-expected.png: Added.
- platform/qt-5.0-wk2/fast/inline/inline-box-background-long-image-expected.png: Added.
- platform/qt-5.0-wk2/fast/inline/inline-box-background-repeat-x-expected.png: Added.
- platform/qt-5.0-wk2/fast/inline/inline-box-background-repeat-y-expected.png: Added.
- platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png:
- platform/qt-5.0-wk2/fast/repaint/absolute-position-moved-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
- platform/qt-5.0-wk2/fast/repaint/add-table-overpaint-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
- platform/qt-5.0-wk2/fast/repaint/backgroundSizeRepaint-expected.png:
- platform/qt-5.0-wk2/fast/repaint/change-transform-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/inline-outline-repaint-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png:
- platform/qt-5.0-wk2/fast/repaint/overflow-into-content-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png.
- platform/qt-5.0-wk2/fast/repaint/stacked-diacritics-expected.png: Added.
- platform/qt-5.0-wk2/fast/repaint/table-cell-overflow-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
- platform/qt-5.0-wk2/fast/repaint/table-overflow-hidden-in-overflow-hidden-scrolled-expected.png:
- platform/qt-5.0-wk2/fast/repaint/table-row-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png.
- platform/qt-5.0-wk2/fast/repaint/transform-rotate-and-remove-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
- platform/qt-5.0-wk2/fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Added.
- platform/qt-5.0-wk2/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png: Added.
- platform/qt-5.0-wk2/svg/custom/repaint-on-image-bounds-change-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png.
- platform/qt-5.0-wk2/svg/custom/use-disappears-after-style-update-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png.
- platform/qt-5.0-wk2/svg/dom/rect-modify-rx-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/overflow-hide-expected.png.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGCircleElement-svgdom-requiredFeatures-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGClipPathElement-transform-influences-hitTesting-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-dom-y2-attr-expected.png:
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/dynamic-updates/SVGRectElement-svgdom-x-prop-expected.png: Added.
- platform/qt-5.0-wk2/svg/repaint/svgsvgelement-repaint-children-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
- platform/qt-5.0-wk2/svg/text/tspan-dynamic-positioning-expected.png: Added.
- 6:11 AM Changeset in webkit [149800] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt][WK1]REGRESSION(r149532) tst_qwebelement and tst_qwebframe API tests crash.
<http://webkit.org/b/115855>
Fix obvious off-by-one mistake.
- Api/qwebelement.cpp:
(QWebElement::styleProperty):
- 3:05 AM WebKitIDL edited by
- Add documentation for [NoInterfaceObject] introduced in r149796 (diff)
- 2:40 AM WebKitIDL edited by
- Move extended attribute to their correct place (diff)
- 2:18 AM Changeset in webkit [149799] by
-
- 1 edit1 add in trunk/LayoutTests
[Qt] Unreviewed gardening. Added platform specific expected file after r149758.
- platform/qt/fast/js/global-constructors-attributes-expected.txt: Added after r149758.
- 2:07 AM Changeset in webkit [149798] by
-
- 2 edits in trunk/Tools
Unreviewed. Update Simon Pena email on his behalf.
- Scripts/webkitpy/common/config/contributors.json:
- 1:14 AM Changeset in webkit [149797] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for Qt minimal build.
r149796 broke builds that have WEB_SOCKETS flag disabled.
- page/DOMWindow.idl:
- 12:38 AM Changeset in webkit [149796] by
-
- 215 edits4 deletes in trunk
Add support for [NoInterfaceObject] Web IDL extended attribute
https://bugs.webkit.org/show_bug.cgi?id=115714
Reviewed by Kentaro Hara.
.:
Update GENERATE_BINDINGS macro to take an additional _window_constructors_file
optional argument.
- Source/cmake/WebKitMacros.cmake:
Source/WebCore:
*Constructor attributes on the global DOMWindow object are now automatically
generated for each non-callback interface that is not declared with the
[NoInterfaceObject] extended attribute. It is thus no longer needed for
developers to manually add *Constructor attributes for their new interfaces
unless they wish to register an "extra" constructor for their interface.
This patch does not modify at all the behavior on JS side. To achieve this,
[NoInterfaceObject] extended attribute is added to interfaces that should
not have it according to specification (e.g. History, Location, ...).
This can be improved later as the behavior should not change with this
patch.
No new tests, no behavior change.
- CMakeLists.txt:
- DerivedSources.make:
- DerivedSources.pri:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Modules/battery/BatteryManager.idl:
- Modules/encryptedmedia/MediaKeyMessageEvent.idl:
- Modules/encryptedmedia/MediaKeyNeededEvent.idl:
- Modules/encryptedmedia/MediaKeySession.idl:
- Modules/encryptedmedia/MediaKeys.idl:
- Modules/filesystem/DOMFileSystem.idl:
- Modules/filesystem/DOMFileSystemSync.idl:
- Modules/filesystem/DirectoryEntry.idl:
- Modules/filesystem/DirectoryEntrySync.idl:
- Modules/filesystem/DirectoryReader.idl:
- Modules/filesystem/DirectoryReaderSync.idl:
- Modules/filesystem/Entry.idl:
- Modules/filesystem/EntryArray.idl:
- Modules/filesystem/EntryArraySync.idl:
- Modules/filesystem/EntrySync.idl:
- Modules/filesystem/FileEntry.idl:
- Modules/filesystem/FileEntrySync.idl:
- Modules/filesystem/FileWriter.idl:
- Modules/filesystem/FileWriterSync.idl:
- Modules/filesystem/Metadata.idl:
- Modules/gamepad/Gamepad.idl:
- Modules/gamepad/GamepadList.idl:
- Modules/geolocation/Coordinates.idl:
- Modules/geolocation/Geolocation.idl:
- Modules/geolocation/Geoposition.idl:
- Modules/geolocation/PositionError.idl:
- Modules/indexeddb/DOMWindowIndexedDatabase.idl:
- Modules/indexeddb/IDBAny.idl:
- Modules/mediasource/MediaSource.idl:
- Modules/mediasource/SourceBuffer.idl:
- Modules/mediasource/SourceBufferList.idl:
- Modules/mediastream/DOMWindowMediaStream.idl: Removed.
- Modules/mediastream/MediaStream.idl:
- Modules/mediastream/MediaStreamTrack.idl:
- Modules/mediastream/MediaStreamTrackEvent.idl:
- Modules/mediastream/NavigatorUserMediaError.idl:
- Modules/mediastream/RTCDTMFSender.idl:
- Modules/mediastream/RTCDTMFToneChangeEvent.idl:
- Modules/mediastream/RTCDataChannel.idl:
- Modules/mediastream/RTCDataChannelEvent.idl:
- Modules/mediastream/RTCIceCandidateEvent.idl:
- Modules/mediastream/RTCPeerConnection.idl:
- Modules/mediastream/RTCStatsReport.idl:
- Modules/mediastream/RTCStatsResponse.idl:
- Modules/networkinfo/NetworkInfoConnection.idl:
- Modules/notifications/DOMWindowNotifications.idl:
- Modules/notifications/NotificationCenter.idl:
- Modules/quota/StorageInfo.idl:
- Modules/quota/StorageQuota.idl:
- Modules/speech/DOMWindowSpeech.idl: Removed.
- Modules/speech/DOMWindowSpeechSynthesis.idl:
- Modules/speech/SpeechGrammar.idl:
- Modules/speech/SpeechGrammarList.idl:
- Modules/speech/SpeechRecognition.idl:
- Modules/speech/SpeechRecognitionAlternative.idl:
- Modules/speech/SpeechRecognitionError.idl:
- Modules/speech/SpeechRecognitionEvent.idl:
- Modules/speech/SpeechRecognitionResult.idl:
- Modules/speech/SpeechRecognitionResultList.idl:
- Modules/speech/SpeechSynthesis.idl:
- Modules/speech/SpeechSynthesisVoice.idl:
- Modules/webaudio/AnalyserNode.idl:
- Modules/webaudio/AudioBuffer.idl:
- Modules/webaudio/AudioBufferSourceNode.idl:
- Modules/webaudio/AudioContext.idl:
- Modules/webaudio/AudioDestinationNode.idl:
- Modules/webaudio/AudioListener.idl:
- Modules/webaudio/AudioNode.idl:
- Modules/webaudio/AudioParam.idl:
- Modules/webaudio/AudioSourceNode.idl:
- Modules/webaudio/BiquadFilterNode.idl:
- Modules/webaudio/ChannelMergerNode.idl:
- Modules/webaudio/ChannelSplitterNode.idl:
- Modules/webaudio/ConvolverNode.idl:
- Modules/webaudio/DOMWindowWebAudio.idl: Removed.
- Modules/webaudio/DelayNode.idl:
- Modules/webaudio/DynamicsCompressorNode.idl:
- Modules/webaudio/GainNode.idl:
- Modules/webaudio/MediaElementAudioSourceNode.idl:
- Modules/webaudio/MediaStreamAudioDestinationNode.idl:
- Modules/webaudio/MediaStreamAudioSourceNode.idl:
- Modules/webaudio/OfflineAudioContext.idl:
- Modules/webaudio/OscillatorNode.idl:
- Modules/webaudio/PannerNode.idl:
- Modules/webaudio/ScriptProcessorNode.idl:
- Modules/webaudio/WaveShaperNode.idl:
- Modules/webaudio/WaveTable.idl:
- Modules/webdatabase/DOMWindowWebDatabase.idl:
- Modules/webdatabase/Database.idl:
- Modules/webdatabase/DatabaseSync.idl:
- Modules/webdatabase/SQLError.idl:
- Modules/webdatabase/SQLResultSet.idl:
- Modules/webdatabase/SQLResultSetRowList.idl:
- Modules/webdatabase/SQLTransaction.idl:
- Modules/webdatabase/SQLTransactionSync.idl:
- Modules/websockets/DOMWindowWebSocket.idl: Removed.
- Modules/websockets/WebSocket.idl:
- PlatformBlackBerry.cmake:
- UseJSC.cmake:
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/IDLParser.pm:
(parseTypedef):
- bindings/scripts/preprocess-idls.pl:
(GenerateConstructorAttribute):
(getFileContents):
(getPartialInterfaceNameFromIDL):
(isCallbackInterfaceFromIDL):
(trim):
(getInterfaceExtendedAttributesFromIDL):
- css/CSSFontFaceLoadEvent.idl:
- css/CSSFontFaceRule.idl:
- css/CSSSupportsRule.idl:
- css/CSSUnknownRule.idl:
- css/DOMWindowCSS.idl:
- css/FontLoader.idl:
- css/MediaQueryList.idl:
- css/MediaQueryListListener.idl:
- css/StyleMedia.idl:
- dom/CustomElementConstructor.idl:
- dom/DOMError.idl:
- dom/DOMNamedFlowCollection.idl:
- dom/DataTransferItem.idl:
- dom/DataTransferItemList.idl:
- dom/EventListener.idl:
- dom/EventTarget.idl:
- dom/NodeIterator.idl:
- dom/ShadowRoot.idl:
- dom/TreeWalker.idl:
- dom/WebKitNamedFlow.idl:
- fileapi/FileException.idl:
- fileapi/FileReaderSync.idl:
- html/HTMLAudioElement.idl:
- html/HTMLDetailsElement.idl:
- html/HTMLOptionElement.idl:
- html/MediaError.idl:
- html/MediaKeyError.idl:
- html/MicroDataItemValue.idl:
- html/RadioNodeList.idl:
- html/ValidityState.idl:
- html/canvas/CanvasRenderingContext.idl:
- html/canvas/DOMPath.idl:
- html/canvas/EXTDrawBuffers.idl:
- html/canvas/EXTTextureFilterAnisotropic.idl:
- html/canvas/OESElementIndexUint.idl:
- html/canvas/OESStandardDerivatives.idl:
- html/canvas/OESTextureFloat.idl:
- html/canvas/OESTextureHalfFloat.idl:
- html/canvas/OESVertexArrayObject.idl:
- html/canvas/WebGLCompressedTextureATC.idl:
- html/canvas/WebGLCompressedTexturePVRTC.idl:
- html/canvas/WebGLCompressedTextureS3TC.idl:
- html/canvas/WebGLContextAttributes.idl:
- html/canvas/WebGLDebugRendererInfo.idl:
- html/canvas/WebGLDebugShaders.idl:
- html/canvas/WebGLDepthTexture.idl:
- html/canvas/WebGLLoseContext.idl:
- html/canvas/WebGLVertexArrayObjectOES.idl:
- html/track/AudioTrack.idl:
- html/track/AudioTrackList.idl:
- html/track/TextTrackRegionList.idl:
- html/track/VideoTrack.idl:
- html/track/VideoTrackList.idl:
- inspector/InjectedScriptHost.idl:
- inspector/InspectorFrontendHost.idl:
- inspector/JavaScriptCallFrame.idl:
- inspector/ScriptProfile.idl:
- inspector/ScriptProfileNode.idl:
- loader/appcache/DOMApplicationCache.idl:
- page/AbstractView.idl:
- page/BarInfo.idl:
- page/Console.idl:
- page/Crypto.idl:
- page/DOMSecurityPolicy.idl:
- page/DOMWindow.idl:
- page/History.idl:
- page/Location.idl:
- page/MemoryInfo.idl:
- page/Navigator.idl:
- page/PagePopupController.idl:
- page/Performance.idl:
- page/PerformanceEntry.idl:
- page/PerformanceEntryList.idl:
- page/PerformanceMark.idl:
- page/PerformanceMeasure.idl:
- page/PerformanceNavigation.idl:
- page/PerformanceResourceTiming.idl:
- page/PerformanceTiming.idl:
- page/Screen.idl:
- page/SpeechInputResult.idl:
- page/SpeechInputResultList.idl:
- page/WorkerNavigator.idl:
- page/make_settings.pl:
(generateInternalSettingsIdlFile):
- svg/ElementTimeControl.idl:
- svg/SVGAnimationElement.idl:
- svg/SVGExternalResourcesRequired.idl:
- svg/SVGFilterPrimitiveStandardAttributes.idl:
- svg/SVGFitToViewBox.idl:
- svg/SVGLangSpace.idl:
- svg/SVGLocatable.idl:
- svg/SVGStyledElement.idl:
- svg/SVGTests.idl:
- svg/SVGTransformable.idl:
- svg/SVGURIReference.idl:
- testing/InternalSettings.idl:
- testing/Internals.idl:
- testing/MallocStatistics.idl:
- testing/TypeConversions.idl:
- workers/AbstractWorker.idl:
- workers/DedicatedWorkerContext.idl:
- workers/SharedWorker.idl:
- workers/SharedWorkerContext.idl:
- workers/WorkerContext.idl:
- workers/WorkerLocation.idl:
- xml/XPathExpression.idl:
- xml/XPathNSResolver.idl:
Tools:
Update BindingsTests.generate_supplemental_dependency() to pass an
additional windowConstructorsFile argument to preprocess-idls.pl.
- Scripts/webkitpy/bindings/main.py:
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.main):
- 12:05 AM Changeset in webkit [149795] by
-
- 5 edits in trunk
[GTK][AC] Buildfix after r149694
https://bugs.webkit.org/show_bug.cgi?id=115797
Patch by ChangSeok Oh <ChangSeok Oh> on 2013-05-09
Reviewed by Gustavo Noronha Silva.
Source/WebCore:
Some interfaces, such as a return value and parameters of functions are changed.
No new tests since no functionality changed.
- platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::animationHasStepsTimingFunction):
(WebCore::GraphicsLayerClutter::timingFunctionForAnimationValue):
(WebCore::GraphicsLayerClutter::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerClutter::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerClutter::createTransformAnimationsFromKeyframes):
(WebCore::GraphicsLayerClutter::setAnimationEndpoints):
(WebCore::GraphicsLayerClutter::setAnimationKeyframes):
- platform/graphics/clutter/GraphicsLayerClutter.h:
(GraphicsLayerClutter):
Tools:
Add CLUTTER_LIBS for linking TestWebCore.
- TestWebKitAPI/GNUmakefile.am:
May 8, 2013:
- 11:39 PM Changeset in webkit [149794] by
-
- 2 edits in trunk/Source/WebCore
Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790
Patch by Rob Buis <rbuis@rim.com> on 2013-05-08
Reviewed by Brent Fulgham.
Get rid of the following warning for BlackBerry:
NavigatorContentUtils.cpp:60:78: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
by not compiling any of the code to add protocols to the protocol whitelist.
- Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::initProtocolHandlerWhitelist):
- 11:38 PM Changeset in webkit [149793] by
-
- 2 edits in trunk/Source/WebCore
[Windows] The function seekFile() is not implemented.
https://bugs.webkit.org/show_bug.cgi?id=115246
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-05-08
Reviewed by Brent Fulgham.
Implemented seekFile() function for Windows.
- platform/win/FileSystemWin.cpp:
(WebCore::seekFile):
- 11:31 PM Changeset in webkit [149792] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: Fix a typo in Settings.js
https://bugs.webkit.org/show_bug.cgi?id=115849
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-08
Reviewed by Joseph Pecoraro.
No new tests, no behavior change.
- inspector/front-end/Settings.js:
(WebInspector.Settings):
- 10:26 PM Changeset in webkit [149791] by
-
- 3 edits in trunk/Source/WebCore
SecurityOrigin doesn’t need to forward declare or include Document
https://bugs.webkit.org/show_bug.cgi?id=115847
Reviewed by Alexey Proskuryakov.
Merge https://chromium.googlesource.com/chromium/blink/+/fc7a88caa9c41f3471d8994a530643e5225f82fc.
Removed unused Document forward declaration+include from SecurityOrigin.
- page/SecurityOrigin.cpp:
- page/SecurityOrigin.h:
- 9:58 PM EFLWebKit edited by
- Update dependency pkgs (diff)
- 9:50 PM Changeset in webkit [149790] by
-
- 2 edits in trunk/Tools
[EFL] Remove unnecessary pkgs in EFL jhbuild
https://bugs.webkit.org/show_bug.cgi?id=114908
Reviewed by Laszlo Gombos.
p11-kit, libgpg-error and libgcrypt don't influence on layout test. So, we don't need to
handle them using jhbuild. We can reduce build time when using --update-efl.
- efl/jhbuild.modules:
- 8:52 PM Changeset in webkit [149789] by
-
- 2 edits in trunk/Source/WebCore
BUILD FIX: Don't use adoptCF() with NSDictionary * object
Fixes the following build failure:
In file included from Source/WebCore/platform/network/mac/ResourceErrorMac.mm:27:
In file included from Source/WebCore/platform/network/cf/ResourceError.h:31:
/usr/local/include/wtf/RetainPtr.h:81:13: error: static_assert failed "Don't use adoptCF with Objective-C pointer types, use adoptNS."
static_assert(!std::is_convertible<T, id>::value, "Don't use adoptCF with Objective-C pointer types, use adoptNS.");
/usr/local/include/wtf/RetainPtr.h:274:16: note: in instantiation of member function 'WTF::RetainPtr<NSDictionary *>::RetainPtr' requested here
return RetainPtr<T>(AdoptCF, o);
Source/WebCore/platform/network/mac/ResourceErrorMac.mm:214:44: note: in instantiation of function template specialization 'WTF::adoptCF<NSDictionary *>' requested here
RetainPtr<NSDictionary> userInfo = adoptCF((NSDictionary *) CFErrorCopyUserInfo(error));
1 error generated.
- platform/network/mac/ResourceErrorMac.mm:
(WebCore::ResourceError::nsError): Switch from adoptCF() to
adoptNS(). This is in USE(CFNETWORK) code, so it's not
exercised on the Mac.
- 8:12 PM Changeset in webkit [149788] by
-
- 4 edits in trunk/Source
Versioning.
- 8:00 PM Changeset in webkit [149787] by
-
- 1 copy in tags/Safari-537.41
New Tag.
- 7:12 PM Changeset in webkit [149786] by
-
- 2 edits in trunk/Tools
[EFL] Disable SHADOW DOM feature in FeatureList.pm
https://bugs.webkit.org/show_bug.cgi?id=115834
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-08
Reviewed by Gyuyoung Kim.
- Scripts/webkitperl/FeatureList.pm:
- 6:11 PM Changeset in webkit [149785] by
-
- 3 edits in trunk/Source/WebCore
Remove Editor::setSelectionOffsets
https://bugs.webkit.org/show_bug.cgi?id=115831
Reviewed by Andreas Kling.
Removed the function added in r120985 for Chromium Android port.
- editing/Editor.cpp:
- editing/Editor.h:
- 6:02 PM Changeset in webkit [149784] by
-
- 2 edits in trunk/Source/WebKit2
Fix a typo in a comment.
Rubber-stamped by Darin Adler.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeConnection):
- 5:49 PM Changeset in webkit [149783] by
-
- 2 edits in trunk/Source/WebKit2
Remove bogus StorageAreaMap assertions
https://bugs.webkit.org/show_bug.cgi?id=115838
Reviewed by Sam Weinig.
It is possible for didGetValues, and didClear to be called even if m_hasPendingClear is false so remove the assertions.
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::didGetValues):
(WebKit::StorageAreaMap::didClear):
- 5:24 PM Changeset in webkit [149782] by
-
- 2 edits in trunk/LayoutTests
[EFL] Get rid of duplicate entry line in TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=115828
Unreviewed gardening.
Patch by Seokju Kwon <Seokju Kwon> on 2013-05-08
- platform/efl/TestExpectations:
- 5:20 PM Changeset in webkit [149781] by
-
- 2 edits in trunk/Source/WebKit2
Handle incoming clear operations
https://bugs.webkit.org/show_bug.cgi?id=115829
Reviewed by Sam Weinig.
Handle clear by building up a new storage map with our pending changes.
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::applyChange):
- 4:51 PM Changeset in webkit [149780] by
-
- 2 edits in trunk/Source/WebCore
Potential use-after-free of Frame
https://bugs.webkit.org/show_bug.cgi?id=115774
Reviewed by Simon Fraser.
Merge https://chromium.googlesource.com/chromium/blink/+/c5b4a6db82e8280c7fc55ee3dc3a84c6b026e66e.
- page/Frame.cpp:
(WebCore::Frame::setPrinting):
(WebCore::Frame::setPageAndTextZoomFactors):
(WebCore::Frame::deviceOrPageScaleFactorChanged):
- 4:43 PM Changeset in webkit [149779] by
-
- 5 edits in trunk/Source/WebCore
Unreviewed build fix, AppleWin port.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::seek):
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted):
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification):
(WebCore):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(MediaPlayerPrivateAVFoundation):
- 4:38 PM Changeset in webkit [149778] by
-
- 24 edits in trunk/Source/WebCore
Heap-use-after-free in WebCore::AudioNodeOutput::pull
https://bugs.webkit.org/show_bug.cgi?id=111362
Reviewed by Chris Rogers.
- Modules/webaudio/AudioBuffer.cpp:
(WebCore::AudioBuffer::createFromAudioFileData):
- Modules/webaudio/AudioNodeInput.cpp:
(WebCore::AudioNodeInput::AudioNodeInput):
(WebCore::AudioNodeInput::updateInternalBus):
- Modules/webaudio/AudioNodeInput.h:
(AudioNodeInput):
- Modules/webaudio/AudioNodeOutput.cpp:
(WebCore::AudioNodeOutput::AudioNodeOutput):
(WebCore::AudioNodeOutput::updateInternalBus):
(WebCore::AudioNodeOutput::pull):
(WebCore::AudioNodeOutput::bus):
- Modules/webaudio/AudioNodeOutput.h:
(AudioNodeOutput):
- Modules/webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
- Modules/webaudio/OfflineAudioDestinationNode.h:
(OfflineAudioDestinationNode):
- platform/audio/AudioBus.cpp:
(WebCore::AudioBus::createBufferFromRange):
(WebCore::AudioBus::createBySampleRateConverting):
(WebCore::AudioBus::createByMixingToMono):
- platform/audio/AudioBus.h:
(AudioBus):
- platform/audio/AudioFileReader.h:
(WebCore):
- platform/audio/AudioResampler.cpp:
(WebCore::AudioResampler::AudioResampler):
(WebCore::AudioResampler::configureChannels):
- platform/audio/AudioResampler.h:
(AudioResampler):
- platform/audio/HRTFElevation.cpp:
(WebCore::getConcatenatedImpulseResponsesForSubject):
(WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):
- platform/audio/MultiChannelResampler.cpp:
- platform/audio/Reverb.cpp:
(WebCore::Reverb::initialize):
- platform/audio/Reverb.h:
(Reverb):
- platform/audio/efl/AudioBusEfl.cpp:
(WebCore::AudioBus::loadPlatformResource):
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(AudioFileReader):
(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):
- platform/audio/gtk/AudioBusGtk.cpp:
(WebCore::AudioBus::loadPlatformResource):
- platform/audio/mac/AudioBusMac.mm:
(WebCore::AudioBus::loadPlatformResource):
- platform/audio/mac/AudioFileReaderMac.cpp:
(WebCore::AudioFileReader::createBus):
(WebCore::createBusFromAudioFile):
(WebCore::createBusFromInMemoryAudioFile):
- platform/audio/mac/AudioFileReaderMac.h:
(AudioFileReader):
- platform/audio/qt/AudioBusQt.cpp:
(WebCore::AudioBus::loadPlatformResource):
- 4:31 PM Changeset in webkit [149777] by
-
- 6 edits in trunk/Source/WebKit2
Don't apply changes while we're clearing the database
https://bugs.webkit.org/show_bug.cgi?id=115826
Reviewed by Darin Adler.
- UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::openDatabase):
Only call didOpenDatabaseWithOrigin if we actually did open the database.
(WebKit::LocalStorageDatabase::updateDatabaseWithChangedItems):
Create the database if needed.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::getValues):
Send back a DidGetValues message.
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::StorageAreaMap):
Initialize m_hasPendingClear.
(WebKit::StorageAreaMap::clear):
Set m_hasPendingClear to true.
(WebKit::StorageAreaMap::resetValues):
Set m_hasPendingClear back to false.
(WebKit::StorageAreaMap::loadValuesIfNeeded):
Set m_hasPendingClear to true so we'll ignore any changes that are already part of the returned items.
(WebKit::StorageAreaMap::didGetValues):
Set m_hasPendingClear back to false.
(WebKit::StorageAreaMap::didClear):
Set m_hasPendingClear back to false.
(WebKit::StorageAreaMap::applyChange):
Don't apply the change if m_hasPendingClear is true.
- WebProcess/Storage/StorageAreaMap.messages.in:
Add DidGetValues message.
- 4:15 PM Changeset in webkit [149776] by
-
- 2 edits in trunk/Tools
Add Scheduler for Mac MtnLion 32bit Release builder.
Unreviewed.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 4:08 PM Changeset in webkit [149775] by
-
- 2 edits in trunk/Tools
Update JSCIdentifier pretty printer in Tools/gdb/webkit.py
https://bugs.webkit.org/show_bug.cgi?id=115808
Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-05-08
Reviewed by Darin Adler.
The pretty printer for the JSCIdentifier in Tools/gdb/webkit.py
was left outdated after r127191, when the m_string member was changed
from UString to String. This patch calls the right pretty printer for it.
- gdb/webkit.py:
(JSCIdentifierPrinter.to_string): Use WTFPrettyPrinter instead of
WTFImplPrettyPrinter.
- 3:41 PM Changeset in webkit [149774] by
-
- 5 edits2 adds in trunk
[WebKit2] REGRESSION (Custom Protocols): Reproducible crash when navigating to URL with an invalid scheme
https://bugs.webkit.org/show_bug.cgi?id=115790
Reviewed by Alexey Proskuryakov.
Source/WebKit2:
NSMutableSet does not support adding or removing nil objects, and
WTF::HashSet does not support adding, removing, or checking for null
WTF::Strings.
For the NSMutableSet case, make sure that we don't try to add or remove
nil NSStrings.
For the WTF::HashSet case, NSURL will return a nil NSString if we ask
it for its scheme when it is invalid, which we will convert to a null
WTF::String. Don't try to check if our HashSet of registered schemes
contains a null String.
- Shared/Network/CustomProtocols/mac/CustomProtocolManagerMac.mm:
(WebKit::CustomProtocolManager::registerScheme): Assert that the scheme
isn't null. We reject null schemes at the WKBrowsingContextController level.
(WebKit::CustomProtocolManager::unregisterScheme): Ditto.
(WebKit::CustomProtocolManager::supportsScheme): If scheme is null, return false.
- UIProcess/API/mac/WKBrowsingContextController.mm:
(+[WKBrowsingContextController registerSchemeForCustomProtocol:]): Do not register a nil scheme.
(+[WKBrowsingContextController unregisterSchemeForCustomProtocol:]): Ditto.
Tools:
Added two API tests:
1) Verify that +[WKBrowsingContextController (un)registerSchemeForCustomProtocol:] can be called with a nil NSString without crashing.
2) Verify that +[WKCustomProtocol canInitWithRequest:] does not crash when passed an NSURLRequest with an invalid scheme.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme.mm: Added.
(TestWebKitAPI):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp: Added.
(TestWebKitAPI):
(TestWebKitAPI::decidePolicyForNavigationAction):
(CustomProtocolInvalidSchemeTest):
(TestWebKitAPI::CustomProtocolInvalidSchemeTest::CustomProtocolInvalidSchemeTest):
- 3:40 PM Changeset in webkit [149773] by
-
- 2 edits in trunk/Tools
Teach buildbot how to compile 32-bit on Mac.
Reviewed by Ryosuke Niwa.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit.start):
(ExtractTestResultsAndLeaks):
- 3:34 PM Changeset in webkit [149772] by
-
- 3 edits in trunk/Source/WebKit2
Apply remote changes to storage maps locally
https://bugs.webkit.org/show_bug.cgi?id=115825
Reviewed by Beth Dakin.
- WebProcess/Storage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::resetValues):
Clear the pending values map.
(WebKit::StorageAreaMap::didSetItem):
If we failed to set the item, forget everything we know about this storage map.
Otherwise, remove the pending item.
(WebKit::StorageAreaMap::didRemoveItem):
Remove the pending item.
(WebKit::StorageAreaMap::shouldApplyChangeForKey):
Helper function that returns whether a change for a given key should be applied.
(WebKit::StorageAreaMap::applyChange):
Apply the change. Currently only adds and removes are handled.
(WebKit::StorageAreaMap::dispatchStorageEvent):
Apply the change locally as well if needed.
- WebProcess/Storage/StorageAreaMap.h:
- 3:26 PM Changeset in webkit [149771] by
-
- 2 edits1 copy in trunk/WebKitLibraries
Update WebKitLibraries/win to handle different architectures properly.
- win/lib32: Copied from win/lib.
- win/tools/WinTools.make:
- 3:08 PM Changeset in webkit [149770] by
-
- 2 edits in trunk/Source/WTF
Simplify RetainPtrObjectHashTraits
https://bugs.webkit.org/show_bug.cgi?id=115822
Reviewed by Benjamin Poulain.
RetainPtrObjectHashTraits is inherited from SimpleClassHashTraits
instead of GenericHashTraits re-using more shared functionality.
- wtf/RetainPtr.h:
(WTF::RetainPtrObjectHashTraits::emptyValue):
- 3:05 PM Changeset in webkit [149769] by
-
- 26 edits in trunk
[BlackBerry] Fix usage of BlackBerry::Platform::String
https://bugs.webkit.org/show_bug.cgi?id=115781
Patch by Eli Fidler <efidler@blackberry.com> on 2013-05-08
Reviewed by Rob Buis.
BlackBerry PRs 304193 and 327181
Internally Reviewed by Mike Lattanzio, Arvid Nilsson, Joe Mason, Jeff Rogers, and George Staikos
We currently have a problem where we're passing UTF-8 encoded data into
the char* constructors of BlackBerry::Platform::String. This means the string
thinks its data is not UTF-8.
Source/WebCore:
- platform/blackberry/ClipboardBlackBerry.cpp:
(WebCore::ClipboardBlackBerry::setData):
(WebCore::ClipboardBlackBerry::writeURL):
(WebCore::ClipboardBlackBerry::writePlainText):
- platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::getRawCookies):
(WebCore::CookieManager::getBackingStoreCookies):
- platform/blackberry/CookieParser.cpp:
(WebCore::CookieParser::CookieParser):
(WebCore::CookieParser::parseOneCookie):
- platform/blackberry/CursorBlackBerry.cpp:
(WebCore::Cursor::Cursor):
- platform/blackberry/PlatformBlob.cpp:
(WebCore::PlatformBlob::nextDataItem):
- platform/blackberry/WorkerAsyncFileSystemBlackBerry.cpp:
(WebCore::WorkerAsyncFileSystemBlackBerry::openFileSystemOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::deleteFileSystemOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::moveOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::copyOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::removeRecursivelyOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::readMetadataOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createFileOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createDirectoryOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::fileExistsOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::directoryExistsOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::readDirectoryOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createWriterOnMainThread):
(WebCore::WorkerAsyncFileSystemBlackBerry::createSnapshotFileAndReadMetadataOnMainThread):
- platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::Image::loadPlatformResource):
- platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):
(WebCore::toWebMediaStreamSource):
(WebCore::toWebMediaStreamDescriptor):
- platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob):
- platform/network/blackberry/SocketStreamHandleBlackBerry.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
- platform/network/blackberry/rss/RSSFilterStream.cpp:
(WebCore::RSSFilterStream::notifyStatusReceived):
(WebCore::RSSFilterStream::notifyHeadersReceived):
(WebCore::RSSFilterStream::convertContentToHtml):
(WebCore::RSSFilterStream::charset):
(WebCore::RSSFilterStream::removeHeader):
(WebCore::RSSFilterStream::updateHeader):
(WebCore::RSSFilterStream::updateRSSHeaders):
- platform/network/blackberry/rss/RSSFilterStream.h:
- platform/text/blackberry/StringBlackBerry.cpp:
(WTF::String::operator BlackBerry::Platform::String):
Source/WebKit/blackberry:
- Api/JavaScriptVariant.cpp:
(BlackBerry::WebKit::JSValueRefToBlackBerryJavaScriptVariant):
- Api/WebKitTextCodec.cpp:
(BlackBerry::WebKit::base64Encode):
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::loadFile):
(BlackBerry::WebKit::WebPage::textEncoding):
(BlackBerry::WebKit::WebPage::textHasAttribute):
(BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):
- Api/WebPage.h:
- Api/WebSettings.cpp:
(BlackBerry::WebKit::WebSettings::standardSettings):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::dispatchDidFinishLoad):
(WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
- WebKitSupport/DefaultTapHighlight.cpp:
(WebKit):
(BlackBerry::WebKit::DefaultTapHighlight::draw):
(BlackBerry::WebKit::DefaultTapHighlight::hide):
Tools:
- DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::resetToConsistentStateBeforeTesting):
(BlackBerry::WebKit::dumpHistoryItem):
- DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
(TestRunner::setUserStyleSheetLocation):
- DumpRenderTree/blackberry/WorkQueueItemBlackBerry.cpp:
(LoadHTMLStringItem::invoke):
- 3:02 PM Changeset in webkit [149768] by
-
- 6 edits in trunk/Source
Assert at compile time that we don't pass Objective-C object pointers to adoptCF
https://bugs.webkit.org/show_bug.cgi?id=115823
Reviewed by Geoffrey Garen.
Source/WebCore:
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::TileController):
Use adoptNS for CALayer.
Source/WebKit2:
Fix adoptNS/adoptCF mismatches. For the adopt(leakRef()) case we'd ideally want a static_pointer_cast overload for RetainPtr,
but this will do for now.
- Shared/mac/ArgumentCodersMac.mm:
(CoreIPC::decode):
Source/WTF:
static_assert in adoptCF that the object passed in is not an Objective-C object.
- wtf/RetainPtr.h:
- 2:56 PM Changeset in webkit [149767] by
-
- 2 edits in trunk/Tools
Tools: add new BlackBerry include dirs.
https://bugs.webkit.org/show_bug.cgi?id=115514
Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-08
Reviewed by Rob Buis.
iType include dirs are missing, and HarfBuzz needs to be fixed.
- Scripts/webkitdirs.pm:
(blackberryCMakeArguments):
- 1:53 PM Changeset in webkit [149766] by
-
- 4 edits2 adds in trunk
TextTrackCue should support empty content
https://bugs.webkit.org/show_bug.cgi?id=115821
Reviewed by Jer Noble.
Source/WebCore:
Test: media/track/track-cue-empty-text-crash.html
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::updateDisplay): Don't bother trying to render
cues with no content.
- html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::getCueAsHTML): Return early if there isn't a node tree.
(WebCore::TextTrackCue::createCueRenderingTree): Ditto.
(WebCore::TextTrackCue::determineTextDirection): Ditto.
(WebCore::TextTrackCue::updateDisplayTree): Return early if there isn't a cue rendering tree.
LayoutTests:
- media/track/track-cue-empty-text-crash-expected.txt: Added.
- media/track/track-cue-empty-text-crash.html: Added.
- 1:48 PM Changeset in webkit [149765] by
-
- 5 edits2 adds in trunk/Source/WebKit2
Add SPI to determine if a plugin is sandboxed
https://bugs.webkit.org/show_bug.cgi?id=115810
Reviewed by Anders Carlsson.
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::initializeSandbox):
- Shared/Plugins/mac/PluginSandboxProfile.h: Added.
- Shared/Plugins/mac/PluginSandboxProfile.mm: Added.
(WebKit::pluginSandboxProfileDefaultDirectory):
(WebKit::pluginSandboxProfileDirectories):
(WebKit::pluginSandboxProfileName):
(WebKit::pluginSandboxCommonProfile):
(WebKit::pluginSandboxProfileForDirectory):
(WebKit::pluginSandboxProfile):
(WebKit::pluginHasSandboxProfileForDirectory):
(WebKit::pluginHasSandboxProfile):
Move sandbox code to its own file and refactor to use cocoa. Also adds pluginHasSandboxProfile function
which uses the newly refactored code.
- UIProcess/API/C/mac/WKContextPrivateMac.h:
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
(WKPlugInInfoIsSandboxedKey):
(createInfoDictionary):
Add WKPlugInInfoIsSandboxedKey.
- WebKit2.xcodeproj/project.pbxproj:
Add new files.
- 1:45 PM Changeset in webkit [149764] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed AppleWin build fix.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
(MediaPlayerPrivateAVFoundationCF):
(WebCore::MediaPlayerPrivateAVFoundationCF::currentTrack):
- 1:33 PM Changeset in webkit [149763] by
-
- 2 edits in trunk/Source/WebKit/blackberry
Fix some compiler warnings (miscellaneous)
https://bugs.webkit.org/show_bug.cgi?id=80790
Patch by Rob Buis <rbuis@rim.com> on 2013-05-08
Reviewed by Philip Rogers.
Get rid of the following warning for BlackBerry:
BackingStoreClient.cpp:54:21: warning: unused parameter 'parentFrame' [-Wunused-parameter]
by using ASSERT_UNUSED instead of ASSERT.
- WebKitSupport/BackingStoreClient.cpp:
(BlackBerry::WebKit::BackingStoreClient::create):
- 1:06 PM Changeset in webkit [149762] by
-
- 2 edits in trunk/Source/WebKit2
Safari unexpectedly quits with invalid message from the web process with message ID 0x323002f (WebPageProxy.DecidePolicyForNavigationAction)
https://bugs.webkit.org/show_bug.cgi?id=115814
<rdar://problem/12331258>
Reviewed by Andreas Kling.
To ensure that any asynchronous messages are delivered to the UI process before
synchronous messages (except when doing so would lead to a deadlock), Call
setOnlySendMessagesAsDispatchWhenWaitingForSyncReplyWhenProcessingSuchAMessage on the UI process connections.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeConnection):
- 1:02 PM Changeset in webkit [149761] by
-
- 4 edits in trunk/Source/WebKit2
Coalesce WKView visibleRect changes
https://bugs.webkit.org/show_bug.cgi?id=115792
<rdar://problem/13776842>
Reviewed by Simon Fraser.
The system can call renewGState much more often than we actually want
to update the WebProcess' notion of the exposed rect. Most importantly,
within an autolayout pass it is called many times, and often sees
[WKView visibleRect] be an intermediate value which will never be
flushed to the screen. We only care about the final value, so we should
wait until AppKit has finished - with a zero-delay timer - to inform the
WebProcess of exposed rect changes.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
Add exposedRectChangedTimer.
(WebKit::WebPageProxy::close):
Cancel exposedRectChangedTimer when tearing down the WebPageProxy.
- UIProcess/WebPageProxy.h:
(WebPageProxy):
Add exposedRectChangedTimerFired, the timer itself, and two rects:
the most recent exposed rect from the WKView, and the last one we actually
sent across to the WebProcess.
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::viewExposedRectChanged):
Instead of immediately sending exposed rect changes to the WebProcess,
start a zero-delay timer to do so.
(WebKit::WebPageProxy::exposedRectChangedTimerFired):
Once the zero-delay timer fires, send the new exposed rect to the WebProcess.
- 12:47 PM Changeset in webkit [149760] by
-
- 2 edits in trunk/Source/WTF
Remove RetainPtr::adoptNS and RetainPtr::adoptCF
https://bugs.webkit.org/show_bug.cgi?id=115817
Reviewed by Jessie Berlin.
These functions are now unused so remove them. The preferred way to create a RetainPtr with an
adopted reference is to use the adoptNS/adoptCF free functions.
Rewrite the move assignment operators to just call CFRelease explicitly.
- wtf/RetainPtr.h:
- 12:39 PM Changeset in webkit [149759] by
-
- 12 edits in trunk
[GTK] Plumb the Automake build system for the Battery Status API feature
https://bugs.webkit.org/show_bug.cgi?id=115718
Reviewed by Martin Robinson.
.:
- Source/autotools/FindDependencies.m4: Check for the upower-glib dependency if the feature is enabled.
- Source/autotools/PrintBuildConfiguration.m4: Print out the feature status.
- Source/autotools/ReadCommandLineArguments.m4: Check for the --enable-battery-status option. The deafult,
when the option is not given, is to disable the feature.
- Source/autotools/SetupWebKitFeatures.m4: Treat the ENABLE_BATTERY_STATUS define as configurable.
- Source/autotools/symbols.filter: Export a couple of symbols that are used in the WebCore internals library.
Source/WebCore:
No new tests - no new functionality. The feature is not enabled yet, though all the relevant tests
pass when it is.
- GNUmakefile.am: Add the Modules/battery directory to the list of search paths for header inclusions.
Include the same directory under the IDL_PATH variable so the IDL files it contains are processed.
List these IDL files using a wildcard under the EXTRA_DIST list.
- GNUmakefile.list.am: Add the build targets for the module source files, IDLs and resulting JS bindings.
- bindings/gobject/GNUmakefile.am: Add the build targets for the GObject DOM bindings.
Tools:
- Scripts/webkitdirs.pm:
(buildAutotoolsProject): List battery-status as a configurable feature, meaning its value will be adjusted
through the --(enable|disable)-battery-status flag passed to configure.
- 12:28 PM Changeset in webkit [149758] by
-
- 3 edits2 adds in trunk/LayoutTests
Add layout test that lists all global constructors
https://bugs.webkit.org/show_bug.cgi?id=115724
Reviewed by Ryosuke Niwa.
Update fast/js/global-constructors-attributes.html so that it lists all
global constructors instead of just a few.
- fast/js/global-constructors-attributes-expected.txt:
- fast/js/script-tests/global-constructors-attributes.js:
(classNameForObject):
(constructorPropertiesOnWindow):
- platform/efl/fast/js/global-constructors-attributes-expected.txt: Added.
- platform/gtk/fast/js/global-constructors-attributes-expected.txt: Added.
- 12:26 PM Changeset in webkit [149757] by
-
- 2 edits in trunk/Tools
new-run-webkit-websocketserver doesn't work after Chromium removal
https://bugs.webkit.org/show_bug.cgi?id=115816
Reviewed by Joseph Pecoraro.
Fix the bug by instantiating the correct port object.
- Scripts/new-run-webkit-websocketserver:
(main):
- 12:19 PM Changeset in webkit [149756] by
-
- 3 edits in trunk/LayoutTests
Unreviewed gardening, mac port.
These tests should use testRunner, not layoutTestController.
- fast/js/parse-error-external-script-in-eval.html:
- fast/js/parse-error-external-script-in-new-Function.html:
- 12:11 PM Changeset in webkit [149755] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed. AppleWin VS2010 build fix.
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- 11:54 AM Changeset in webkit [149754] by
-
- 4 edits in trunk
REGRESSION(r149700): fast/css-generated-content/close-quote-negative-depth.html
https://bugs.webkit.org/show_bug.cgi?id=115776
Reviewed by Anders Carlsson.
Source/WebCore:
I changed depth to more closely match what is in the CSS3 specification.
There may be a more optimal way to make it work, but this seems the most straightforward.
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::RenderQuote): Initialize m_depth to -1 because that depth
is consistent with the empty string that is the initial value of the text. The
real depth will be calculated when the node is attached.
(WebCore::RenderQuote::originalText): Removed the "depth - 1" logic that
used to be done for close quotes. Instead, the updateDepth function now correctly
subtracts one for the close quote itself, not just afterward. Also added an early
exit when the depth is negative; these changes together fix the bug.
(WebCore::RenderQuote::attachQuote): Added a call to updateDepth even for the render
quote head, we now need that to set the depth either to 0 or to -1.
(WebCore::RenderQuote::detachQuote): Removed code to set m_depth to 0; if we are not
resetting the text then m_depth should be left matching the text, otherwise updateDepth
might not do its job correctly if the quote is later re-attached. What matters is that
m_depth and the text are in sync.
(WebCore::RenderQuote::updateDepth): Changed updating logic in two ways. First,
compute the depth in a local variable rather than computing it in a data member
after first saving off the old value of the data member. That's clearer style.
Second, add the code to change negative depths to zero when propagating to the
next quote in the chain, which matches how the standard is written, and decrement
the depth of the close quote itself, not the quote after the close quote.
LayoutTests:
- TestExpectations: Expect success again on this test.
- 11:52 AM Changeset in webkit [149753] by
-
- 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/config.json
Unreviewed. Fix duplicate builddir.
- 11:46 AM Changeset in webkit [149752] by
-
- 2 edits in trunk/Tools
Configure buildbot for 32bit builder.
https://bugs.webkit.org/show_bug.cgi?id=115769
Reviewed by Ryosuke Niwa.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 11:19 AM Changeset in webkit [149751] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/13776220> 13A451: PluginProcess(2225) deny file-read-data ~/Library/InputManagers
<rdar://problem/13642510> PluginProcess logs sandbox violations initializing TextServices
Reviewed by Anders Carlsson.
- Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb: Allow more TextServices and NSInputManager directories.
- 10:35 AM Changeset in webkit [149750] by
-
- 2 edits in trunk/Tools
Unreviewed. Add my apple.com e-mail address to contributors.
- 10:16 AM Changeset in webkit [149749] by
-
- 3 edits2 adds in trunk
Prevent crash when track is deleted during video element deletion.
https://bugs.webkit.org/show_bug.cgi?id=106183
Reviewed by Dean Jackson.
Source/WebCore:
Test: media/track/track-remove-crash.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::removedFrom): Set m_inActiveDocument to false so we
do not process text track cues or dispatch related events.
LayoutTests:
- media/track/track-remove-crash-expected.txt: Added.
- media/track/track-remove-crash.html: Added.
- 10:03 AM Changeset in webkit [149748] by
-
- 1 edit1 delete in trunk/Source/WebKit2
Remove BinarySemaphoreWin.cpp.
Rubber-stamped by Beth Dakin.
BinarySemaphoreWin has been moved to WTF, but the original was never removed.
- Platform/CoreIPC/win/BinarySemaphoreWin.cpp: Removed.
- 9:54 AM Changeset in webkit [149747] by
-
- 1 edit1 delete in trunk/Source/WTF
Remove ThreadingNone.cpp
Rubber-stamped by Beth Dakin.
ThreadingNone.cpp is empty and not used anywhere.
- wtf/ThreadingNone.cpp: Removed.
- 9:52 AM Changeset in webkit [149746] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove chromium test results added in r149743
- platform/chromium/fast/js/parse-error-external-script-in-eval-expected.txt: Removed.
- platform/chromium/fast/js/parse-error-external-script-in-new-Function-expected.txt: Removed.
- 9:46 AM Changeset in webkit [149745] by
-
- 2 edits in trunk/Tools
BUILD FIX (r149579): Use Vector::appendVector() instead of Vector::append()
- DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(concatenateAttributeAndValue): Switch to appendVector().
- 9:41 AM Changeset in webkit [149744] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Unreviewed buildfix after r149741.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible):
- 9:33 AM Changeset in webkit [149743] by
-
- 1 edit11 adds in trunk/LayoutTests
Add layout tests for test cases in Bug 5206
<http://webkit.org/b/5206>
Reviewed by Eric Seidel.
These issues were likely fixed in r89257 for Bug 62613.
- fast/js/parse-error-external-script-in-eval-expected.txt: Added.
- fast/js/parse-error-external-script-in-eval.html: Added.
- fast/js/parse-error-external-script-in-new-Function-expected.txt: Added.
Note that the line number in this result is relative to the line
number of the second argument to the new Function() method.
- fast/js/parse-error-external-script-in-new-Function.html: Added.
- fast/js/resources/parse-error-external-script-in-eval.js: Added.
- fast/js/resources/parse-error-external-script-in-new-Function.js: Added.
- platform/chromium/fast/js/parse-error-external-script-in-eval-expected.txt: Added.
- platform/chromium/fast/js/parse-error-external-script-in-new-Function-expected.txt: Added.
- 9:17 AM Changeset in webkit [149742] by
-
- 2 edits in trunk/Source/WTF
Remove HashMap::deleteAllKeys
https://bugs.webkit.org/show_bug.cgi?id=115806
Reviewed by Brent Fulgham.
This function was not used anywhere so let's get rid of it.
- wtf/HashMap.h:
- 9:06 AM Changeset in webkit [149741] by
-
- 17 edits in trunk
[Mac] Inband text tracks are not in track menu on Lion
https://bugs.webkit.org/show_bug.cgi?id=115740
Reviewed by Dean Jackson.
Source/WebCore:
No new tests, covered by existing tests.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Remove m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::setClosedCaptionsVisible): Set m_closedCaptionsVisible
to false immediately, it will be reset to the appropriate value if necessary.
(WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible): Remove m_legacyWebKitClosedCaptionsVisible.
(WebCore::HTMLMediaElement::webkitClosedCaptionsVisible): Remove m_legacyWebKitClosedCaptionsVisible.
- html/HTMLMediaElement.h:
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp: Remove
HAVE(AVFOUNDATION_TEXT_TRACK_SUPPORT) requirement. AVFOUNDATION_TEXT_TRACK_SUPPORT ->
AVFOUNDATION_MEDIA_SELECTION_GROUP
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h: Ditto.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::seek): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Ditto.
(WebCore::MediaPlayerPrivateAVFoundation::trackModeChanged): Ditto.
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Ditto.
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.h: Ditto.
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::kind): Don't look at media characteristics,
a legacy CC track is always Captions.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::isClosedCaptions): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::containsOnlyForcedSubtitles): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::isMainProgramContent): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::isEasyToRead): Ditto.
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::label): Use different AVFoundation API on 10.7.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC): AVFOUNDATION_TEXT_TRACK_SUPPORT ->
AVFOUNDATION_MEDIA_SELECTION_GROUP.
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible): Do nothing. AVFOUNDATION_TEXT_TRACK_SUPPORT ->
AVFOUNDATION_MEDIA_SELECTION_GROUP.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Support legacy CC tracks
only on 10.8. AVFOUNDATION_TEXT_TRACK_SUPPORT -> AVFOUNDATION_MEDIA_SELECTION_GROUP
(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setCurrentTrack): Ditto.
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): AVFOUNDATION_TEXT_TRACK_SUPPORT ->
AVFOUNDATION_MEDIA_SELECTION_GROUP
Source/WTF:
- wtf/Platform.h: AVFOUNDATION_TEXT_TRACK_SUPPORT -> AVFOUNDATION_MEDIA_SELECTION_GROUP
LayoutTests:
- platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt:
- 8:19 AM Changeset in webkit [149740] by
-
- 3 edits2 adds in trunk
Allow blank spaces before colon (:) on CSS variable definition
https://bugs.webkit.org/show_bug.cgi?id=115802
Reviewed by Darin Adler.
Source/WebCore:
Test: css3/css-variable-definition.html
Modified the grammar to allow blank spaces before the colon on CSS
variable definitions.
- css/CSSGrammar.y.in:
LayoutTests:
New test to check that spaces are allowed before the color on CSS
variable definitions.
- css3/css-variable-definition-expected.html: Added.
- css3/css-variable-definition.html: Added.
- 8:08 AM Changeset in webkit [149739] by
-
- 2 edits in trunk/Source/WTF
HashTraits<RefPtr<P> >::peek should consider empty value
https://bugs.webkit.org/show_bug.cgi?id=115799
Reviewed by Darin Adler.
HashTraits<RefPtr<P> >::peek() should consider passing of empty value which is
raw pointer equal to '0', and return it right away instead of converting it to RefPtr
and invoking get().
- wtf/HashTraits.h:
- 8:07 AM Changeset in webkit [149738] by
-
- 2 edits in trunk/Source/WTF
Avoid unnecessary arguments copying inside GenericHashTraits methods
https://bugs.webkit.org/show_bug.cgi?id=115733
Reviewed by Darin Adler.
Before the change both WTF::GenericHashTraits::passOut and WTF::GenericHashTraits::passOut
used to return the given argument always by value and that caused implicit extra
copying of the argument. It was OK as long as argument type T was POD, as compiler
could optimize it, but in case T was a class having non-trivial copy constructor the
extra copying of the argument could not have been obviated.
The proposed solution is to provide overloaded functions that accept non-temporary
values and return them by reference thus avoiding extra copying.
The proposed solution made an impact on the size of libjavascriptcore_efl.so (EFL
release build): the size decreased from 6554992 bytes to 6554560 bytes.
- wtf/HashTraits.h:
(WTF::GenericHashTraits::passOut):
(WTF::GenericHashTraits::peek):
- 7:36 AM Changeset in webkit [149737] by
-
- 1 edit16 adds in trunk/LayoutTests
[Qt] Unreviewed gardening after r149292.
https://bugs.webkit.org/show_bug.cgi?id=115372
- platform/qt-5.0-wk2/fast/css-grid-layout/grid-element-change-columns-repaint-expected.txt: Added.
- platform/qt-5.0-wk2/fast/css-grid-layout/grid-element-change-rows-repaint-expected.txt: Added.
- platform/qt-5.0-wk2/fast/css-grid-layout/grid-item-change-column-repaint-expected.txt: Added.
- platform/qt-5.0-wk2/fast/css-grid-layout/grid-item-change-row-repaint-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/layer-full-repaint-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/overflow-flipped-writing-mode-table-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/reflection-table-layout-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/selection-gap-absolute-child-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/selection-gap-fixed-child-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/selection-gap-flipped-absolute-child-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/selection-gap-flipped-fixed-child-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/selection-gap-transformed-absolute-child-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/selection-gap-transformed-fixed-child-expected.txt: Added.
- platform/qt-5.0-wk2/fast/repaint/transform-table-layout-expected.txt: Added.
- platform/qt-5.0-wk2/svg/repaint/repaint-webkit-svg-shadow-container-expected.txt: Added.
- 7:28 AM WebKitGTK/2.0.x edited by
- Adding a couple reasonably simple GStreamer backend fixes (diff)
- 6:44 AM Changeset in webkit [149736] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed EFL gardening
https://bugs.webkit.org/show_bug.cgi?id=115791
Unreviewed EFL gardening
Skip fast/regions/ test cases which are failing after r149668.
Patch by Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> on 2013-05-08
- platform/efl/TestExpectations:
- 6:41 AM Changeset in webkit [149735] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Does memory buffering even with preload set to none
https://bugs.webkit.org/show_bug.cgi?id=115754
Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-05-08
Reviewed by Philippe Normand.
Covered by existing tests.
Revision 148840 fixed on-disk buffering being done when preload is set to none,
but memory buffering is still being done. That is because setting the state to
paused causes GStreamer to start loading the media, to gather information. Only
doing that when committing the load avoids that while maintaining the tested
behaviour unchanged.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::load): move setting pause state to commitLoad.
(WebCore::MediaPlayerPrivateGStreamer::commitLoad): see above.
- 6:07 AM Changeset in webkit [149734] by
-
- 2 edits in trunk/Source/WebCore
SVGStyledElement::getPresentationAttribute() does not need to be virtual.
From Blink r149888 by <cevans@chromium.org>
<http://src.chromium.org/viewvc/blink?view=revision&revision=149888>
- svg/SVGStyledElement.h:
- 6:00 AM Changeset in webkit [149733] by
-
- 2 edits in trunk/Source/WebCore
Crash when loading link to audio file
https://bugs.webkit.org/show_bug.cgi?id=115794
Reviewed by Jocelyn Turcotte.
Do not access a null pointer frame.
- loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
- 5:56 AM Changeset in webkit [149732] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipping some failing fast/region tests.
https://bugs.webkit.org/show_bug.cgi?id=115785
- platform/qt/TestExpectations:
- 5:20 AM Changeset in webkit [149731] by
-
- 2 edits in trunk/Tools
[Qt][WTR] Fix the build on Mac after r149692
Unreviewed build fix.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
- 4:54 AM Changeset in webkit [149730] by
-
- 3 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Unskip two spelling tests as they started passing after r149366.
- platform/efl-wk2/TestExpectations:
Unskip spelling-exactly-selected-word.html and
spelling-with-punctuation-selection.html
- platform/efl/TestExpectations:
Remove spelling tests from efl/TestExpectations as the failing tests
are already skipped for both efl-wk1 and global wk2.
- 3:59 AM Changeset in webkit [149729] by
-
- 20 edits in trunk/Source/WebCore
Remove unused [TransferList] extended attribute
https://bugs.webkit.org/show_bug.cgi?id=115788
Reviewed by Kentaro Hara.
Remove [TransferList] extended attribute and corresponding tests as it has no
effect on the generated JSC bindings.
No new tests, no behavior change.
- bindings/scripts/IDLAttributes.txt:
- bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/CPP/WebDOMTestSerializedScriptValueInterface.h:
(WebDOMTestSerializedScriptValueInterface):
- bindings/scripts/test/CPP/WebDOMTestTypedefs.cpp:
- bindings/scripts/test/CPP/WebDOMTestTypedefs.h:
(WebDOMTestTypedefs):
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.cpp:
- bindings/scripts/test/GObject/WebKitDOMTestTypedefs.h:
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
(JSTestSerializedScriptValueInterfacePrototype):
(JSTestSerializedScriptValueInterfaceConstructor):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore):
- bindings/scripts/test/JS/JSTestTypedefs.h:
(WebCore):
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.h:
- bindings/scripts/test/ObjC/DOMTestSerializedScriptValueInterface.mm:
- bindings/scripts/test/ObjC/DOMTestTypedefs.h:
- bindings/scripts/test/ObjC/DOMTestTypedefs.mm:
- bindings/scripts/test/TestSerializedScriptValueInterface.idl:
- bindings/scripts/test/TestTypedefs.idl:
- 3:38 AM Changeset in webkit [149728] by
-
- 3 edits in trunk/Tools
Unreviewed. Added Anton Obzhirov to the list of contributors and myself
to the watchlist for Accessibility.
- Scripts/webkitpy/common/config/contributors.json: Added Anton Obzhirov.
- Scripts/webkitpy/common/config/watchlist: Added myself.
- 3:37 AM WebKitIDL edited by
- Remove [TransferList] (diff)
- 3:16 AM Changeset in webkit [149727] by
-
- 2 edits in trunk/LayoutTests
Unreviewed EFL gardening.
Skip remaining Shadow DOM tests on the EFL port.
- platform/efl/TestExpectations:
- 2:50 AM Changeset in webkit [149726] by
-
- 2 edits in trunk/Tools
[Qt] Build fails with clang
https://bugs.webkit.org/show_bug.cgi?id=115741
Reviewed by Benjamin Poulain.
Since r149112 std::move is used in AtomicString for compilers that
support rvalue references and this requires a standard library
implementing c++11 move semantics.
We only explicitely require c++11 for WebKit2, but since clang supports
rvalue references the build of subtargets using AtomicString fails because
of missing std::move.
It is safe to add CONFIG += c++11 for the whole project when using clang
since we explicitely disable c++11 for ANGLE that had probems with libc++.
- qmake/mkspecs/features/unix/default_pre.prf:
- 2:41 AM Changeset in webkit [149725] by
-
- 3 edits in trunk/Tools
Fix one more place that needed to use adoptCF/NS
https://bugs.webkit.org/show_bug.cgi?id=115778
Reviewed by Benjamin Poulain.
Not sure why I missed this code last time, but found a bit more code that needs
to switch to the newer style adoptCF/NS.
- WebKitTestRunner/cf/WebArchiveDumpSupport.cpp:
(convertWebResourceDataToString): Use adoptCF.
(convertWebResourceResponseToDictionary): Ditto.
(createXMLStringFromWebArchiveData): Ditto.
- WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm:
(createCFURLResponseFromResponseData): Use adoptNS and adoptCF.
- 2:23 AM Changeset in webkit [149724] by
-
- 2 edits in trunk/LayoutTests
Unreviewed GTK gardening.
- platform/gtk/TestExpectations: Adding failure expectations for CSS Regions tests
that regressed when converted into reftests in r149668.
- 1:55 AM Changeset in webkit [149723] by
-
- 7 edits in trunk
Make optional arguments in CanvasRenderingContext2D match the spec.
https://bugs.webkit.org/show_bug.cgi?id=115723
Patch by Dongseong Hwang <dongseong.hwang@intel.com> on 2013-05-08
Reviewed by Dean Jackson.
Source/WebCore:
WebKit r98985 set many arguments optional although the canvas spec[1] does not
indicate. So this patch corrects CanvasRenderingContext2D.idl to match the spec.
[1] http://www.w3.org/html/wg/drafts/2dcontext/html5_canvas/
Covered by existing tests:
canvas/philip/tests/2d.missingargs.html
fast/canvas/canvas-overloads-strokeRect.html
inspector/profiler/canvas2d/canvas2d-profiler-capturing-basics.html
- html/canvas/CanvasRenderingContext2D.idl:
LayoutTests:
When tests use <canvas> API with not enough arguments, TypeError
exception is fired now. So three tests are changed to match the canvas
spec.
- fast/canvas/canvas-overloads-strokeRect-expected.txt:
- fast/canvas/script-tests/canvas-overloads-strokeRect.js:
- platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:
- 1:54 AM WebKitIDL edited by
- Rename JSCustomIsReachable to CustomIsReachable and … (diff)
- 1:50 AM WebKitIDL edited by
- Remove JSCustomHeader (diff)
- 1:48 AM WebKitIDL edited by
- Remove remaining mentions of V8 (diff)
- 1:45 AM WebKitIDL edited by
- Remove V8DoNotCheckSignature (diff)
- 1:45 AM WebKitIDL edited by
- Remove V8CustomIsReachable (diff)
- 1:43 AM WebKitIDL edited by
- Remove [URL] (diff)
- 1:42 AM WebKitIDL edited by
- Remove V8GenerateIsReachable and JSGenerateIsReachable (diff)
- 1:40 AM WebKitIDL edited by
- Remove V8DependentLifeTime (diff)
- 1:39 AM WebKitIDL edited by
- Remove V8CustomIndexedGetter (diff)
- 1:38 AM WebKitIDL edited by
- Remove dead section from TOC (diff)
- 1:36 AM WebKitIDL edited by
- Remove V8EnabledAtRuntime, V8EnabledPerContext from TOC (diff)
- 1:35 AM WebKitIDL edited by
- Remove V8Unforgeable and V8OnProto (diff)
- 1:33 AM WebKitIDL edited by
- Remove V8ReadOnly (diff)
- 1:29 AM WebKitIDL edited by
- Remove mentions of JSCustom and V8Custom (diff)
- 1:28 AM Changeset in webkit [149722] by
-
- 2 edits in trunk/Tools
Unreviewed, rolling out r149271.
http://trac.webkit.org/changeset/149271
https://bugs.webkit.org/show_bug.cgi?id=115780
The mangled symbols are now enforced through LDFLAGS
(Requested by zdobersek on #webkit).
Patch by Commit Queue <commit-queue@webkit.org> on 2013-05-08
- BuildSlaveSupport/gtk/daemontools-buildbot.conf:
- 1:19 AM WebKitIDL edited by
- Rename V8SkipVTableValidation to SkipVTableValidation (diff)
- 1:16 AM WebKitIDL edited by
- Remove mentions of toV8() (diff)
- 1:14 AM Changeset in webkit [149721] by
-
- 2 edits in trunk/Tools
[Flakiness Dashboard] Remove the Chromium fallback platforms listing from the legend popup
https://bugs.webkit.org/show_bug.cgi?id=115636
Reviewed by Ryosuke Niwa.
- TestResultServer/static-dashboards/flakiness_dashboard.js:
(showLegend): Remove the listing of the Chromium fallback platforms from the legend popup. The code iterated
through the platforms in the g_fallbacksMap dictionary to construct this part of the legend, but the dictionary,
while Chromium-specific, can't be removed just yet as there's more code that uses it.
- 1:14 AM WebKitIDL edited by
- Use more monospace (diff)
- 1:06 AM Changeset in webkit [149720] by
-
- 6 edits in trunk/Source/WebKit2
[WK2] Make the WebNetworkInfoManager a supplement to the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=115716
Reviewed by Andreas Kling.
WebNetworkInfoManager should inherit from WebProcessSupplement and should be used
as such by the WebProcess. This removes the need for the m_networkInfoManager member
variable in the WebProcess class and brings the WebNetworkInfoManager in line with
other manager classes of which instances are controlled by the WebProcess class.
- WebProcess/NetworkInfo/WebNetworkInfoManager.cpp:
(WebKit::WebNetworkInfoManager::supplementName): Specify the supplement's name.
(WebKit):
- WebProcess/NetworkInfo/WebNetworkInfoManager.h:
(WebKit): Alphabetically reorder the two forwarding declarations.
(WebNetworkInfoManager): Inherit from the WebProcessSupplement interface.
- WebProcess/WebCoreSupport/WebNetworkInfoClient.cpp:
(WebKit::WebNetworkInfoClient::bandwidth): Access the WebNetworkInfoManager as a supplement.
(WebKit::WebNetworkInfoClient::metered): Ditto.
(WebKit::WebNetworkInfoClient::startUpdating): Ditto.
(WebKit::WebNetworkInfoClient::stopUpdating): Ditto.
(WebKit::WebNetworkInfoClient::networkInfoControllerDestroyed): Ditto.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess): Add the WebNetworkInfoManager instance as a supplement.
- WebProcess/WebProcess.h:
(WebProcess): Remove the m_networkInfoManager member variable and its getter method.
- 1:02 AM Changeset in webkit [149719] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Correct documentation for ewk_settings APIs
https://bugs.webkit.org/show_bug.cgi?id=115507
Patch by Jose Lejin PJ <jose.lejin@gmail.com> on 2013-05-08
Reviewed by Gyuyoung Kim.
Corrected documentation for ewk_settings APIs.
- ewk/ewk_settings.h:
- 1:01 AM WebKitIDL edited by
- Use more monospace (diff)
- 12:58 AM Changeset in webkit [149718] by
-
- 3 edits in trunk/Source/WebCore
Remove unused method and de-virtualize others in Element.h
https://bugs.webkit.org/show_bug.cgi?id=115770
Reviewed by Andreas Kling.
Merge https://chromium.googlesource.com/chromium/blink/+/c2c2ff9cb69f46f5cc9d289b2bfbdb8ab5bd3e49
The de-virtualization possibilities were noted whilst "FINALizing" the Node
hierarchy. If a method is successfully marked FINAL but then fails when marked
OVERRIDE as well, the method by definition does not need to be virtual.
- WebCore.exp.in:
- dom/Element.h:
(WebCore::Element::hasAuthorShadowRoot):
- 12:52 AM WebKitIDL edited by
- Use more monospace (diff)
- 12:51 AM Changeset in webkit [149717] by
-
- 6 edits in trunk/Source/WebKit2
[WK2] Make the WebBatteryManager a supplement to the WebProcess
https://bugs.webkit.org/show_bug.cgi?id=115715
Reviewed by Andreas Kling.
WebBatteryManager should inherit from WebProcessSupplement and should be used as such
by the WebProcess. This removes the need for the m_batteryManager member variable in
the WebProcess class and brings the WebBatteryManager in line with other manager classes
of which instances are controlled by the WebProcess class.
- WebProcess/Battery/WebBatteryManager.cpp:
(WebKit::WebBatteryManager::supplementName): Specify the supplement's name.
(WebKit):
- WebProcess/Battery/WebBatteryManager.h:
(WebBatteryManager): Inherit from the WebProcessSupplement interface.
- WebProcess/WebCoreSupport/WebBatteryClient.cpp:
(WebKit::WebBatteryClient::startUpdating): Access the WebBatteryManager as a supplement.
(WebKit::WebBatteryClient::stopUpdating): Ditto.
(WebKit::WebBatteryClient::batteryControllerDestroyed): Ditto.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess): Add the WebBatteryManager instance as a supplement.
- WebProcess/WebProcess.h:
(WebProcess): Remove the m_batteryManager member variable and its getter method.
- 12:44 AM WebKitIDL edited by
- Use more monospace (diff)
- 12:40 AM Changeset in webkit [149716] by
-
- 94 edits in trunk
Source/WebCore: Use adoptCF and adoptNS in more places
https://bugs.webkit.org/show_bug.cgi?id=115657
Reviewed by Sam Weinig.
This is similar to my last set of changes, but covers code that I missed with
global replace using the Safari Xcode workspace.
- platform/cf/win/CertificateCFWin.cpp:
(WebCore::copyCertificateToData):
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::platformBufferedTimeRanges):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMinTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeLoaded):
(WebCore::MediaPlayerPrivateAVFoundationCF::totalBytes):
(WebCore::mimeTypeCache):
(WebCore::MediaPlayerPrivateAVFoundationCF::tracksChanged):
(WebCore::MediaPlayerPrivateAVFoundationCF::sizeChanged):
(WebCore::AVFWrapper::createAssetForURL):
(WebCore::AVFWrapper::createPlayer):
(WebCore::AVFWrapper::createPlayerItem):
(WebCore::AVFWrapper::setAsset):
(WebCore::AVFWrapper::platformLayer):
(WebCore::AVFWrapper::createAVCFVideoLayer):
(WebCore::AVFWrapper::createImageGenerator):
- platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
(WebCore::InbandTextTrackPrivateLegacyAVFObjC::language):
- platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
(toCACFTimingFunction):
(PlatformCAAnimation::PlatformCAAnimation):
(PlatformCAAnimation::setFromValue):
(PlatformCAAnimation::setToValue):
(PlatformCAAnimation::setValues):
(PlatformCAAnimation::setKeyTimes):
(PlatformCAAnimation::setTimingFunctions):
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayer::PlatformCALayer):
(PlatformCALayer::setBackgroundColor):
(PlatformCALayer::setBorderColor):
- platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::PlatformCALayerWinInternal):
(PlatformCALayerWinInternal::addTile):
- platform/graphics/ca/win/WKCACFViewLayerTreeHost.cpp:
(WebCore::WKCACFViewLayerTreeHost::WKCACFViewLayerTreeHost):
- platform/graphics/gstreamer/PlatformVideoWindowMac.mm:
(PlatformVideoWindow::PlatformVideoWindow):
- platform/graphics/win/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::fontPlatformData):
- platform/graphics/win/FontPlatformDataCGWin.cpp:
(WebCore::getPostScriptName):
(WebCore::FontPlatformData::platformDataInit):
- platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::drawWindowsBitmap):
- platform/graphics/win/ImageCGWin.cpp:
(WebCore::BitmapImage::create):
- platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
(WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer):
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::rfc2616DateStringFromTime):
(WebCore::QTCFDictionaryCreateWithDataCallback):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage):
- platform/graphics/win/WKCAImageQueue.cpp:
(WebCore::WKCAImageQueue::WKCAImageQueue):
- platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::qcmsOutputDeviceProfile):
- platform/network/cf/AuthenticationCF.cpp:
(WebCore::core):
- platform/network/cf/CookieJarCFNet.cpp:
(WebCore::cookieDomain):
(WebCore::cookieName):
(WebCore::cookiePath):
(WebCore::cookieValue):
(WebCore::filterCookies):
(WebCore::setCookiesFromDOM):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostname):
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::certificatePath):
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::urlFromPath):
(WebCore::getURL):
- platform/win/LocalizedStringsWin.cpp:
(WebCore::createWebKitBundle):
(WebCore::localizedString):
- platform/win/SearchPopupMenuWin.cpp:
(WebCore::SearchPopupMenuWin::saveRecentSearches):
(WebCore::SearchPopupMenuWin::loadRecentSearches):
- plugins/mac/PluginPackageMac.cpp:
(WebCore::stringListFromResourceId):
(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):
- plugins/mac/PluginViewMac.mm:
(WebCore::PluginView::platformStart):
- rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::platformFocusRingColor):
(WebCore::RenderThemeSafari::paintMenuListButtonGradients):
(WebCore::RenderThemeSafari::paintSliderTrack):
Use adoptCF and adoptNS throughout.
Source/WebKit/win: Use adoptCF and adoptNS in more places
https://bugs.webkit.org/show_bug.cgi?id=115657
Reviewed by Sam Weinig.
This is similar to my last set of changes, but covers code that I missed with
global replace using the Safari Xcode workspace.
- CFDictionaryPropertyBag.cpp:
(CFDictionaryPropertyBag::Write):
- WebCache.cpp:
(WebCache::statistics):
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidFailToStartPlugin):
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::openInspectorFrontend):
(WebInspectorFrontendClient::localizedStringsURL):
- WebDatabaseManager.cpp:
(WebDatabaseManager::dispatchDidModifyDatabase):
- WebDownloadCFNet.cpp:
(WebDownload::init):
(WebDownload::initWithRequest):
(WebDownload::initToResumeWithBundle):
(WebDownload::cancelForResume):
(WebDownload::useCredential):
(WebDownload::didReceiveAuthenticationChallenge):
- WebError.cpp:
(WebError::sslPeerCertificate):
- WebHistory.cpp:
(createUserInfoFromArray):
(createUserInfoFromHistoryItem):
(WebHistory::WebHistory):
(WebHistory::loadFromURL):
(WebHistory::loadHistoryGutsFromURL):
(WebHistory::saveToURL):
(WebHistory::saveHistoryGuts):
(WebHistory::removeAllItems):
(WebHistory::removeItem):
(WebHistory::addItem):
(WebHistory::itemForURL):
(WebHistory::addItemToDateCaches):
(getDayBoundaries):
- WebIconDatabase.cpp:
(postDidAddIconNotification):
- WebLocalizableStrings.cpp:
(cfBundleForStringsBundle):
- WebMutableURLRequest.cpp:
(WebMutableURLRequest::mutableCopy):
- WebPreferences.cpp:
(cfNumber):
(WebPreferences::initializeDefaultSettings):
(WebPreferences::valueForKey):
(WebPreferences::setStringValue):
(WebPreferences::load):
(WebPreferences::migrateWebKitPreferencesToCFPreferences):
(WebPreferences::setPreferenceForTest):
- WebView.cpp:
(WebView::setCacheModel):
(WebView::notifyPreferencesChanged):
Use adoptCF and adoptNS.
Source/WebKit2: Use adoptCF and adoptNS in more places
https://bugs.webkit.org/show_bug.cgi?id=115657
Reviewed by Sam Weinig.
- Shared/Downloads/cfnet/DownloadCFNet.cpp:
(WebKit::Download::useCredential):
(WebKit::Download::start):
(WebKit::Download::startWithHandle):
(WebKit::Download::cancel):
(WebKit::Download::didDecideDestination):
Use adoptCF and adoptNS.
Tools: Use adoptCF and adoptNS in more places, test code and code not compiled on Mac
https://bugs.webkit.org/show_bug.cgi?id=115657
Reviewed by Sam Weinig.
This is similar to my last set of changes, but covers code that I missed with
global replace using the Safari Xcode workspace.
- DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
(convertWebResourceDataToString):
(convertWebResourceResponseToDictionary):
(createXMLStringFromWebArchiveData):
- DumpRenderTree/cg/ImageDiffCG.cpp:
(createImageFromStdin):
(createDifferenceImage):
(main):
- DumpRenderTree/cg/PixelDumpSupportCG.cpp:
(printPNG):
(dumpBitmap):
- DumpRenderTree/cg/PixelDumpSupportCG.h:
(BitmapContext::BitmapContext):
- DumpRenderTree/mac/MockWebNotificationProvider.mm:
(-[MockWebNotificationProvider init]):
- DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createBitmapContext):
- DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::addDisallowedURL):
(TestRunner::applicationCacheDiskUsageForOrigin):
(TestRunner::localStorageDiskUsageForOrigin):
(TestRunner::clearApplicationCacheForOrigin):
(TestRunner::deleteLocalStorageForOrigin):
(TestRunner::copyDecodedHostName):
(TestRunner::copyEncodedHostName):
(TestRunner::queueLoad):
(TestRunner::setDomainRelaxationForbiddenForURLScheme):
(TestRunner::setMockGeolocationPositionUnavailableError):
(TestRunner::setUserStyleSheetLocation):
(TestRunner::setValueForUser):
(TestRunner::overridePreference):
(TestRunner::setPersistentUserStyleSheetLocation):
(TestRunner::execCommand):
(TestRunner::findString):
(TestRunner::isCommandEnabled):
(TestRunner::addOriginAccessWhitelistEntry):
(TestRunner::removeOriginAccessWhitelistEntry):
(TestRunner::addUserScript):
(TestRunner::addUserStyleSheet):
(TestRunner::evaluateInWebInspector):
(TestRunner::evaluateScriptInIsolatedWorld):
(TestRunner::apiTestNewWindowDataLoadBaseURL):
(-[SynchronousLoader connection:didReceiveAuthenticationChallenge:]):
(TestRunner::authenticateSession):
(TestRunner::grantWebNotificationPermission):
(TestRunner::denyWebNotificationPermission):
- DumpRenderTree/mac/WebArchiveDumpSupportMac.mm:
(createCFURLResponseFromResponseData):
- DumpRenderTree/mac/WorkQueueItemMac.mm:
(LoadItem::invoke):
(LoadHTMLStringItem::invoke):
(ScriptItem::invoke):
- DumpRenderTree/win/DumpRenderTree.cpp:
(substringFromIndex):
(urlSuitableForTestResult):
(lastPathComponent):
(sharedCFURLCache):
- DumpRenderTree/win/ImageDiffCairo.cpp:
(createImageFromStdin):
(main):
- DumpRenderTree/win/PixelDumpSupportWin.cpp:
(createBitmapContextFromWebView):
- DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::setUserStyleSheetLocation):
(TestRunner::setPersistentUserStyleSheetLocation):
- TestWebKitAPI/Tests/CustomProtocolsSyncXHRTest.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/TestWebKitAPI/mac/InstanceMethodSwizzler.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/cf/RetainPtrHashing.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/FindMatches.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/WebArchive.cpp:
(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
- TestWebKitAPI/Tests/WebKit2/mac/GetBackingScaleFactor.mm:
(TestWebKitAPI::createWindow):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WebKit2/win/DoNotCopyANullCFURLResponse.cpp:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/AcceptsFirstMouse.mm:
(TestWebKitAPI::AcceptsFirstMouse::runTest):
- TestWebKitAPI/Tests/mac/AttributedString.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/BackForwardList.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/CancelLoadFromResourceLoadDelegate.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/ContextMenuCanCopyURL.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/DOMHTMLTableCellCellAbove.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/DOMRangeOfString.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/DeviceScaleFactorInDashboardRegions.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/DeviceScaleFactorOnBack.mm:
(TestWebKitAPI::DeviceScaleFactorOnBack::createWindow):
- TestWebKitAPI/Tests/mac/DynamicDeviceScaleFactor.mm:
(TestWebKitAPI::DynamicDeviceScaleFactor::createWindow):
- TestWebKitAPI/Tests/mac/HTMLCollectionNamedItem.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/HTMLFormCollectionNamedItem.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/InspectorBar.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/MemoryCacheDisableWithinResourceLoadDelegate.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/MemoryCachePruneWithinResourceLoadDelegate.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
(TestWebKitAPI::PageVisibilityStateWithWindowChanges::runTest):
- TestWebKitAPI/Tests/mac/RenderedImageFromDOMRange.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/SetDocumentURI.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/SimplifyMarkup.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/WillSendSubmitEvent.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/mac/WindowlessWebViewWithMedia.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::MIMETypeForWKURLResponse):
- TestWebKitAPI/mac/WebKitAgnosticTest.mm:
(TestWebKitAPI::WebKitAgnosticTest::runWebKit1Test):
(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
- WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
(WTR::testPathFromURL):
- WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
- WebKitTestRunner/cg/TestInvocationCG.cpp:
(WTR::createCGContextFromImage):
(WTR::dumpBitmap):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseScrollBy):
- WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::windowSnapshotImage):
- WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::initializeTestPluginDirectory):
Use adoptCF and adoptNS.
- 12:36 AM WebKitIDL edited by
- Start using monospace for IDL extended attributes (diff)
- 12:24 AM WebKitIDL edited by
- Remove deprecated "in" keyword from IDL examples (diff)
- 12:05 AM Changeset in webkit [149715] by
-
- 2 edits in trunk/LayoutTests
Add an image only failure expectation to fast/css-generated-content/close-quote-negative-depth.html per
bug 115776 after r149700. r149707 tried to fix its regression but this test is still failing.
- 12:04 AM WebKitIDL edited by
- Update documentation for optional and [Default] (diff)
- 12:03 AM Changeset in webkit [149714] by
-
- 2 edits in trunk
[Automake] Pass --no-demangle to the linker by default to get the mangled symbols
https://bugs.webkit.org/show_bug.cgi?id=115732
Reviewed by Gustavo Noronha Silva.
- GNUmakefile.am: Pass the --no-demangle option to the linker by default. This is done by appending
the flag to the LDFLAGS variable. While the AM_LDFLAGS variable would be more appropriate, it's not
at all used when linking installable libraries like libwebkitgtk and libwebkit2gtk, so the LDFLAGS
variable is used instead.
- 12:00 AM Changeset in webkit [149713] by
-
- 2 edits in trunk/Source/WebKit/mac
<rdar://problem/13633007> WebKit and others fail to build headers due to build root dependency
Reviewed by Sam Weinig.
- Configurations/WebKit.xcconfig: Look for WebCore's headers within the SDK if we're building against one.
May 7, 2013:
- 11:24 PM Changeset in webkit [149712] by
-
- 2 edits in trunk/Source/WebKit/efl
[EFL] Remove the ewk_settings_shadow_dom_enable_set/get APIs from unit test
https://bugs.webkit.org/show_bug.cgi?id=115771
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-05-07
Reviewed by Gyuyoung Kim.
Unit test is failing since r149702. Remove the test case related to shadow dom.
- tests/test_ewk_setting.cpp:
- 10:08 PM Changeset in webkit [149711] by
-
- 5 edits in trunk/Source/WebKit/blackberry
Clean up load interface in WebPage
https://bugs.webkit.org/show_bug.cgi?id=115622
Patch by Xuefei Ren <xren@blackberry.com> on 2013-05-07
Reviewed by Rob Buis.
Internal PR:315535
Internal reviewed by Mary Wu
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::load):
(BlackBerry::WebKit::WebPage::loadFile):
(BlackBerry::WebKit::WebPage::load):
- Api/WebPage.h:
- Api/WebPage_p.h:
(WebPagePrivate):
- WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::startDownload):
- 8:18 PM Changeset in webkit [149710] by
-
- 3 edits in trunk/Source/WebCore
Make CanvasStyle's CMYKAValues allocated on the heap and move the pointer in the union.
https://bugs.webkit.org/show_bug.cgi?id=115764
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-07
Reviewed by Andreas Kling.
CMYKA input is uncommon enough that we should not pay the price for
every CanvasStyle.
Make those values heap allocated and put the pointer in the union. Since
the RGBA32 values are needed for CMYKA, a RGBA32 value is added to the structure.
- html/canvas/CanvasStyle.cpp:
(WebCore::CanvasStyle::CanvasStyle):
(WebCore::CanvasStyle::~CanvasStyle):
(WebCore::CanvasStyle::isEquivalentColor):
(WebCore::CanvasStyle::isEquivalentCMYKA):
(WebCore::CanvasStyle::applyStrokeColor):
(WebCore::CanvasStyle::applyFillColor):
- html/canvas/CanvasStyle.h:
(CanvasStyle):
(CMYKAValues):
(WebCore::CanvasStyle::CMYKAValues::CMYKAValues):
(WebCore::CanvasStyle::color):
(WebCore):
- 7:41 PM Changeset in webkit [149709] by
-
- 3 edits in trunk/Source/WebCore
Use OwnPtr instead of deleteAllValues for requests in PluginView
https://bugs.webkit.org/show_bug.cgi?id=115731
Reviewed by Sam Weinig.
- plugins/PluginView.cpp:
(WebCore::PluginView::~PluginView): Removed the call to deleteAllValues.
(WebCore::PluginView::requestTimerFired): Use release to remove an OwnPtr
from m_requests rather than an explicit delete. Also use !isEmpty instead
of size > 0.
(WebCore::PluginView::scheduleRequest): Changed argument type to PassOwnPtr.
(WebCore::PluginView::load): Use adoptPtr to call scheduleRequest.
- plugins/PluginView.h: Changed argument type of scheduleRequest to
PassOwnPtr, and m_requests to a Vector<OwnPtr>.
- 7:03 PM Changeset in webkit [149708] by
-
- 18 edits2 deletes in trunk/Source
Remove SelectRuleFeatureSet
https://bugs.webkit.org/show_bug.cgi?id=115757
Reviewed by Benjamin Poulain.
This is dead code.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.exp.in:
- WebCore.vcproj/WebCore.vcproj:
- WebCore.xcodeproj/project.pbxproj:
- dom/Element.cpp:
(WebCore::Element::attributeChanged):
(WebCore):
(WebCore::Element::didAffectSelector):
- dom/Element.h:
(Element):
- dom/ElementShadow.h:
(WebCore::ElementShadow::invalidateDistribution):
- html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::ContentDistributor):
(WebCore):
- html/shadow/ContentDistributor.h:
(ContentDistributor):
- html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::insertedInto):
(WebCore::InsertionPoint::removedFrom):
- html/shadow/InsertionPoint.h:
(InsertionPoint):
- html/shadow/SelectRuleFeatureSet.cpp: Removed.
- html/shadow/SelectRuleFeatureSet.h: Removed.
- testing/Internals.cpp:
(WebCore):
- testing/Internals.idl:
- 6:47 PM Changeset in webkit [149707] by
-
- 3 edits in trunk/Source/WebCore
Store the quotes in the same allocation as the QuotesData object
https://bugs.webkit.org/show_bug.cgi?id=115768
Reviewed by Andreas Kling.
Since the QuotesData object is immutable we don't need a Vector to store the quote pairs,
they can just be stored after the class data.
- rendering/style/QuotesData.cpp:
(WebCore::sizeForQuotesDataWithQuoteCount):
Helper function for computing the allocation size.
(WebCore::QuotesData::create):
Use fastMalloc + placement new.
(WebCore::QuotesData::QuotesData):
Use placement new to allocate the quote pairs.
(WebCore::QuotesData::~QuotesData):
Destroy the quote pairs.
(WebCore::QuotesData::openQuote):
Stop using Vector.
(WebCore::QuotesData::closeQuote):
Ditto.
(WebCore::operator==):
Ditto.
- rendering/style/QuotesData.h:
- 6:42 PM Changeset in webkit [149706] by
-
- 2 edits in trunk/Source/WebCore
We should not ref() the RefPtr twice in CanvasStyle
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-07
Reviewed by Darin Adler.
- html/canvas/CanvasStyle.cpp:
(WebCore::CanvasStyle::CanvasStyle):
We leak the ref of PassRefPtr, we should not ref() it a second time.
- 6:41 PM Changeset in webkit [149705] by
-
- 14 edits in trunk/Source/WebCore
Devirtualize Document class type checking
https://bugs.webkit.org/show_bug.cgi?id=115755
Reviewed by Benjamin Poulain.
Merge https://chromium.googlesource.com/chromium/blink/+/dae5adc768d5ce6bff301df6515745da8ea24950
Document has a bunch of virtual bool is*Document() methods on it, but it also has
two bools for XHTML and HTML documents which is silly. We can merge them all
together into an enum of values and devirtualize the type checking methods.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::createElement):
- dom/Document.h:
(WebCore::Document::create):
(WebCore::Document::createXHTML):
(WebCore::Document::isHTMLDocument):
(WebCore::Document::isXHTMLDocument):
(WebCore::Document::isImageDocument):
(WebCore::Document::isSVGDocument):
(WebCore::Document::isPluginDocument):
(WebCore::Document::isMediaDocument):
(WebCore::Document):
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::HTMLDocument):
- html/HTMLDocument.h:
(WebCore::HTMLDocument):
- html/ImageDocument.cpp:
(WebCore::ImageDocument::ImageDocument):
- html/ImageDocument.h:
(WebCore::ImageDocument):
- html/MediaDocument.cpp:
(WebCore::MediaDocument::MediaDocument):
- html/MediaDocument.h:
(WebCore::MediaDocument):
- html/PluginDocument.cpp:
(WebCore::PluginDocument::PluginDocument):
- html/PluginDocument.h:
(WebCore::PluginDocument):
- loader/PlaceholderDocument.h:
(WebCore::PlaceholderDocument::PlaceholderDocument):
- svg/SVGDocument.cpp:
(WebCore::SVGDocument::SVGDocument):
- svg/SVGDocument.h:
(WebCore::SVGDocument):
- 6:35 PM Changeset in webkit [149704] by
-
- 2 edits in trunk/Tools
Fix a memory leak introduced in r149692
https://bugs.webkit.org/show_bug.cgi?id=115766
Patch by Alex Christensen <achristensen@apple.com> on 2013-05-07
Reviewed by Mark Rowe.
In r149692, the fix for <http://webkit.org/b/42324>, a call to WKBundleFrameCopyWebArchive was added without any
matching call to WKRelease. An earlier attempted fix in r149697 introduced a RetainPtr but failed to adopt the object.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
Fix the memory leak by switching to WKRetainPtr and adopting the returned object.
- 6:26 PM Changeset in webkit [149703] by
-
- 2 edits in trunk/Tools
[Win] Fix storage leak in Windows DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=115651
Reviewed by Sam Weinig.
- DumpRenderTree/win/DumpRenderTree.cpp:
(lastPathComponent): Added a missing call to adoptCF.
- 6:13 PM Changeset in webkit [149702] by
-
- 3 edits in trunk
[CMAKE] Remove SHADOW_DOM from cmakeconfig.h.cmake
https://bugs.webkit.org/show_bug.cgi?id=115712
Reviewed by Andreas Kling.
Nobody uses SHADOW_DOM in cmake.
- Source/cmake/WebKitFeatures.cmake:
- Source/cmakeconfig.h.cmake:
- 5:11 PM Changeset in webkit [149701] by
-
- 3 edits in trunk/Source/WebKit2
Add SPI to get an array of all the installed plug-ins
https://bugs.webkit.org/show_bug.cgi?id=115688
Reviewed by Anders Carlsson.
- UIProcess/API/C/mac/WKContextPrivateMac.h:
- UIProcess/API/C/mac/WKContextPrivateMac.mm:
(createInfoDictionary):
Extract creation of info dictionary into helper.
(WKContextCopyPlugInInfoForBundleIdentifier):
Modified to use the new helper.
(WKContextGetInfoForInstalledPlugIns):
Added.
- 4:07 PM Changeset in webkit [149700] by
-
- 7 edits in trunk/Source/WebCore
Begin unraveling the mess that is QuotesData
https://bugs.webkit.org/show_bug.cgi?id=115765
Reviewed by Andreas Kling.
Change QuotesData to be an immutable object and fix other things that are broken.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
QuotesData::addPair is gone. Instead, create the Vector up front and pass it to QuotesData.
- rendering/RenderQuote.cpp:
(WebCore::RenderQuote::originalText):
Update for renames.
- rendering/style/QuotesData.cpp:
(WebCore::QuotesData::create):
Remove the create overload that wasn't used. Add a new create overload that takes a Vector.
(WebCore::QuotesData::openQuote):
Rename this from getOpenQuote and clean it up.
(WebCore::QuotesData::closeQuote):
Rename this from getCloseQuote and clean it up.
(WebCore::operator==):
Replace the equals member function with a proper equality operator.
- rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
Stop calling QuotesData::equals. Use the same idiom as used for other properties.
(WebCore::RenderStyle::setQuotes):
- rendering/style/StyleRareInheritedData.cpp:
Use operator==.
(WebCore::quotesDataEquivalent):
Add helper function.
(WebCore::StyleRareInheritedData::operator==):
Call quotesDataEquivalent.
- 3:54 PM Changeset in webkit [149699] by
-
- 3 edits1 add1 delete in trunk/LayoutTests
[CSS Exclusions] shape-inside, shape-padding, polygon test failing when subpixel layout is disabled
https://bugs.webkit.org/show_bug.cgi?id=115649
Reviewed by Dirk Schulze.
Another correction of a padded shape test that failed when subpixel layout was disabled.
This test puts a cross pattern made of five Ahem characters on three lines, within a padded
diamond polygon. The left edges of each line depend on the intersection of the padded polygon's
edges with the top of each line, which makes predicting the exact values unreliable. So we
just verify that the left edges of each line are within a pixel of the ideal value. This
change is very similar to the one made for bug 115490.
- fast/exclusions/shape-inside/shape-inside-polygon-padding-002-expected.html: Removed.
- fast/exclusions/shape-inside/shape-inside-polygon-padding-002-expected.txt: Added.
- fast/exclusions/shape-inside/shape-inside-polygon-padding-002.html:
- platform/mac/TestExpectations:
- 3:41 PM Changeset in webkit [149698] by
-
- 3 edits3 adds in trunk
Support -webkit-system-font on OS X.
https://bugs.webkit.org/show_bug.cgi?id=115758
<rdar://problem/13433854>
- 3:26 PM Changeset in webkit [149697] by
-
- 2 edits in trunk/Tools
fixed a memory leak introduced by bug 42324 by using a RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=115760
Patch by Alex Christensen <achristensen@apple.com> on 2013-05-07
Reviewed by Tim Horton.
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
fixed memory leak, added UNUSED_PARAM macros
- 3:14 PM Changeset in webkit [149696] by
-
- 3 edits in trunk/Source/WebCore
Move CanvasGradient and CanvasPattern in the union of CanvasStyle
https://bugs.webkit.org/show_bug.cgi?id=115759
Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-07
Reviewed by Andreas Kling.
The Gradient and Pattern are exclusive with the other values, but they
were left out of the union because they are ref-counted.
This patch moves them in the union, and simply does the ref-counting manually.
- html/canvas/CanvasStyle.cpp:
(WebCore::CanvasStyle::CanvasStyle):
(WebCore::CanvasStyle::~CanvasStyle):
- html/canvas/CanvasStyle.h:
(CanvasStyle):
(WebCore::CanvasStyle::canvasGradient):
(WebCore::CanvasStyle::canvasPattern):
- 3:06 PM Changeset in webkit [149695] by
-
- 3 edits in trunk/Source/WebCore
Remove custom allocator support from PODArena
https://bugs.webkit.org/show_bug.cgi?id=115762
Reviewed by Andreas Kling.
Nobody uses PODArena with a custom allocator, so just get rid of it and always use fastMalloc/fastFree.
- platform/PODArena.h:
(WebCore::PODArena::PODArena):
(WebCore::PODArena::allocateBase):
(WebCore::PODArena::Chunk::Chunk):
(WebCore::PODArena::Chunk::~Chunk):
(Chunk):
- platform/PODFreeListArena.h:
(WebCore::PODFreeListArena::allocate):
(WebCore::PODFreeListArena::FreeListChunk::FreeListChunk):
- 3:04 PM Changeset in webkit [149694] by
-
- 12 edits in trunk/Source
Clean up KeyframeValueList and related classes
https://bugs.webkit.org/show_bug.cgi?id=115738
Reviewed by Simon Fraser.
Source/WebCore:
Add static create() functions to the AnimationValue subclasses, and change a bunch of parameters
and return values that can never be null from pointer types to reference types to better indicate this.
- platform/graphics/GraphicsLayer.cpp:
(WebCore::filterOperationsAt):
(WebCore::GraphicsLayer::validateFilterOperations):
(WebCore::operationsAt):
(WebCore::GraphicsLayer::validateTransformOperations):
- platform/graphics/GraphicsLayer.h:
(AnimationValue):
(WebCore::AnimationValue::AnimationValue):
(WebCore::FloatAnimationValue::create):
(FloatAnimationValue):
(WebCore::FloatAnimationValue::FloatAnimationValue):
(WebCore::TransformAnimationValue::create):
(TransformAnimationValue):
(WebCore::TransformAnimationValue::value):
(WebCore::TransformAnimationValue::TransformAnimationValue):
(WebCore::FilterAnimationValue::create):
(WebCore::FilterAnimationValue::value):
(WebCore::FilterAnimationValue::FilterAnimationValue):
(FilterAnimationValue):
(WebCore::KeyframeValueList::~KeyframeValueList):
(KeyframeValueList):
(WebCore::KeyframeValueList::at):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::animationHasStepsTimingFunction):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::createFilterAnimationsFromKeyframes):
(WebCore::GraphicsLayerCA::timingFunctionForAnimationValue):
(WebCore::GraphicsLayerCA::setAnimationEndpoints):
(WebCore::GraphicsLayerCA::setAnimationKeyframes):
(WebCore::GraphicsLayerCA::setTransformAnimationEndpoints):
(WebCore::GraphicsLayerCA::setTransformAnimationKeyframes):
(WebCore::GraphicsLayerCA::setFilterAnimationEndpoints):
(WebCore::GraphicsLayerCA::setFilterAnimationKeyframes):
- platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::startAnimation):
(WebCore::RenderLayerBacking::startTransition):
Source/WebKit2:
Update for WebCore changes.
- Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::decode):
- 2:52 PM Changeset in webkit [149693] by
-
- 7 edits in trunk/Source
Add and remove databases and origins from the database tracker
https://bugs.webkit.org/show_bug.cgi?id=115752
Reviewed by Andreas Kling.
Source/WebCore:
Add symbols needed by WebKit2.
- WebCore.exp.in:
Source/WebKit2:
- UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::LocalStorageDatabase):
Rename m_databaseFilename to m_databasePath.
(WebKit::LocalStorageDatabase::tryToOpenDatabase):
Rename m_databaseFilename to m_databasePath.
- UIProcess/Storage/LocalStorageDatabase.h:
Rename m_databaseFilename to m_databasePath.
- UIProcess/Storage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::databasePath):
Rename databaseFilename to databasePath.
(WebKit::LocalStorageDatabaseTracker::didOpenDatabaseWithOrigin):
Call addDatabaseWithOriginIdentifier.
(WebKit::LocalStorageDatabaseTracker::deleteEmptyDatabaseWithOrigin):
Call removeDatabaseWithOriginIdentifier.
(WebKit::LocalStorageDatabaseTracker::trackerDatabasePath):
Call databasePath instead of databaseFile.
(WebKit::LocalStorageDatabaseTracker::openTrackerDatabase):
Bail if the database is already open.
(WebKit::LocalStorageDatabaseTracker::updateTrackerDatabaseFromLocalStorageDatabaseFiles):
Call addDatabaseWithOriginIdentifier if this is an origin we don't know about.
(WebKit::LocalStorageDatabaseTracker::addDatabaseWithOriginIdentifier):
Add the database to the Origins table.
(WebKit::LocalStorageDatabaseTracker::removeDatabaseWithOriginIdentifier):
remove the database from the Origins table and delete it.
(WebKit::LocalStorageDatabaseTracker::pathForDatabaseWithOriginIdentifier):
Helper function that looks up a database path given its identifier.
- UIProcess/Storage/LocalStorageDatabaseTracker.h:
Rename databaseFile to databasePath.
- 2:26 PM Changeset in webkit [149692] by
-
- 6 edits4 adds in trunk/Tools
WebKitTestRunner needs testRunner.dumpDOMAsWebArchive
https://bugs.webkit.org/show_bug.cgi?id=42324
<rdar://problem/8193633>
Patch by Alex Christensen <achristensen@apple.com> on 2013-05-07
Reviewed by Tim Horton.
- Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
Added dumpDOMAsWebArchive JavaScript function to be called by test cases.
- Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::dumpDOMAsWebArchive):
Added dumpDOMAsWebArchive code that is called when dumping.
(WTR::InjectedBundlePage::dump):
Made DOMAsWebArchive case when dumping call dumpDOMAsWebArchive.
- Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
(InjectedBundlePage):
Added dumpDOMAsWebArchive declaration.
- Tools/WebKitTestRunner/InjectedBundle/TestRunner.h:
(WTR::TestRunner::dumpDOMAsWebArchive):
Added dumpDOMAsWebArchive JS callback function that sets m_whatToDump to DOMAsWebArchive.
- Tools/WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
Added WebArchiveDumpSupport.cpp, WebArchiveDumpSupport.h, WebArchiveDumpSupportMac.mm to project.
- Tools/WebKitTestRunner/cf: Added.
- Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.cpp: Added.
Copied from Tools/DumpRenderTree/cf for createXMLStringFromWebArchiveData and other functions it uses.
(convertMIMEType):
(convertWebResourceDataToString):
(normalizeHTTPResponseHeaderFields):
(normalizeWebResourceURL):
(convertWebResourceResponseToDictionary):
(compareResourceURLs):
(createXMLStringFromWebArchiveData):
- Tools/WebKitTestRunner/cf/WebArchiveDumpSupport.h: Added.
Copied from Tools/DumpRenderTree/cf for used symbol declarations.
- Tools/WebKitTestRunner/mac/WebArchiveDumpSupportMac.mm: Added.
Copied from Tools/DumpRenderTree/mac for used functions.
(createCFURLResponseFromResponseData):
(supportedNonImageMIMETypes):
- 2:12 PM Changeset in webkit [149691] by
-
- 3 edits in trunk/Source/WebCore
Still possible to fire paint-related LayoutMilestones before CA has committed the
changes
https://bugs.webkit.org/show_bug.cgi?id=115753
-and corresponding-
<rdar://problem/13822315>
Reviewed by Simon Fraser.
To ensure we wait for the CA commit, we should wait until the end of the runloop
with a zero-delay timer.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::paintRelatedMilestonesTimerFired):
(WebCore):
- rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):
- 2:09 PM Changeset in webkit [149690] by
-
- 2 edits in trunk/Source/WebCore
Bug 115694 - Fix bad cast to RenderHTMLCanvas
https://bugs.webkit.org/show_bug.cgi?id=115694
Reviewed by Ryosuke Niwa.
Don't cast to RenderHTML until we check what kind of object it is.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
- 1:30 PM Changeset in webkit [149689] by
-
- 2 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Increase the padding size for caret based scrolling.
https://bugs.webkit.org/show_bug.cgi?id=115749
Reviewed by Rob Buis.
PR 322670.
Increasing the padding size for scrolling in order to optimize the
number of scrolls required during typing.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
- 1:07 PM Performance Tests edited by
- (diff)
- 12:42 PM Changeset in webkit [149688] by
-
- 7 edits in trunk/Source
The storage database tracker should know when databases come and go
https://bugs.webkit.org/show_bug.cgi?id=115748
Reviewed by Andreas Kling.
Source/WebCore:
Export symbol needed by WebKit2.
- WebCore.exp.in:
Source/WebKit2:
- UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::openDatabase):
If we've opened the database successfully, call LocalStorageDatabaseTracker::didOpenDatabaseWithOrigin.
(WebKit::LocalStorageDatabase::tryToOpenDatabase):
Remove a FIXME; we run all storage related things on the same thread.
(WebKit::LocalStorageDatabase::close):
Close the database. If it's empty, call LocalStorageDatabaseTracker::deleteEmptyDatabaseWithOrigin.
(WebKit::LocalStorageDatabase::databaseIsEmpty):
Helper function for determining whether a database is empty.
- UIProcess/Storage/LocalStorageDatabase.h:
- UIProcess/Storage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::databaseFilename):
Add ".localstorage" to the filename.
(WebKit::LocalStorageDatabaseTracker::didOpenDatabaseWithOrigin):
(WebKit::LocalStorageDatabaseTracker::deleteEmptyDatabaseWithOrigin):
Add empty stubs.
- 12:11 PM Changeset in webkit [149687] by
-
- 3 edits in trunk/Source/WebKit2
Add JoinExistingSession to the Networking XPC.
<rdar://problem/12902288> and https://bugs.webkit.org/show_bug.cgi?id=114991
Reviewed by Sam Weinig.
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService.Development/Info.plist:
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info.plist:
- 12:08 PM Changeset in webkit [149686] by
-
- 2 edits in trunk/Tools
Updated style of WebArchiveDumpSupport before putting it into WebKitTestRunner.
https://bugs.webkit.org/show_bug.cgi?id=115745
Patch by Alex Christensen <achristensen@apple.com> on 2013-05-07
Reviewed by Tim Horton.
- DumpRenderTree/cf/WebArchiveDumpSupport.cpp:
(compareResourceURLs):
Updated style.
- 11:52 AM Changeset in webkit [149685] by
-
- 5 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Maintain touch event state throughout processing
https://bugs.webkit.org/show_bug.cgi?id=115663
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-05-07
Reviewed by Rob Buis.
Internally reviewed by Otto Cheung and Genevieve Mak.
PR 297691
By maintaining our touch event state, we can get a better idea
of what triggered an update to selection and respond appropriately.
On touch press we set userTouchTriggered to give the UI thread
some context.
- Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::setExtraPluginDirectory):
- Api/WebPage_p.h:
(WebPagePrivate):
- WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectionPositionChanged):
- 11:42 AM Changeset in webkit [149684] by
-
- 3 edits in trunk/Source/WebCore
Use OwnPtr instead of deleteAllValues in SVGResourcesCache
https://bugs.webkit.org/show_bug.cgi?id=115729
Reviewed by Benjamin Poulain.
- rendering/svg/SVGResourcesCache.cpp:
(WebCore::SVGResourcesCache::~SVGResourcesCache): Removed call to deleteAllValues.
(WebCore::SVGResourcesCache::addResourcesFromRenderObject): Use adoptPtr and release
to create new SVGResources object.
(WebCore::SVGResourcesCache::removeResourcesFromRenderObject): Use take to remove
the SVGResources from the map rather than a get combined with delete/take.
(WebCore::SVGResourcesCache::cachedResourcesForRenderObject): Removed unneeded
call to contains, since get already returns 0 if there is no item in the map.
(WebCore::SVGResourcesCache::resourceDestroyed): Use typedef for the map type so
we don't have to repeat the type.
- rendering/svg/SVGResourcesCache.h: Added typedef CacheMap, and changed value
type to OwnPtr.
- 11:30 AM Changeset in webkit [149683] by
-
- 4 edits in trunk/Source
REGRESSION(r149647): Assertion failure in LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal
https://bugs.webkit.org/show_bug.cgi?id=115711
Reviewed by Andreas Kling.
Source/WebCore:
Export SQLiteDatabase::close.
- WebCore.exp.in:
Source/WebKit2:
Handle setting the local storage directory more than once.
- UIProcess/Storage/LocalStorageDatabaseTracker.cpp:
(WebKit::LocalStorageDatabaseTracker::setLocalStorageDirectoryInternal):
Close the database (if necessary) and clear the origins map before importing the origin identifiers.
- 11:12 AM Changeset in webkit [149682] by
-
- 4 edits in trunk/Source/WebKit2
Re-establish autostart timeout extension on user interaction
https://bugs.webkit.org/show_bug.cgi?id=113232
Change WebProcess::pluginDidReceiveUserInteraction to use a tuple of
(pluginOrigin, pageOrigin, mimeType) arguments like the other similar
WebProcess methods and gather these arguments from the PlugInView's
plug-in element.
Reviewed by Dean Jackson.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginDidReceiveUserInteraction):
Cast the m_pluginElement to a HTMLPlugInImageElement so we can obtain the
tuple of (pluginOrigin, pageOrigin, mimeType) to pass to pluginDidReceiveUserInteraction().
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::plugInDidReceiveUserInteraction):
- WebProcess/WebProcess.h:
(WebProcess):
Update method signature to a tuple of (pluginOrigin, pageOrigin, mimeType)
and obtain the plug-in origin hash from that.
- 10:58 AM Changeset in webkit [149681] by
-
- 26 edits1 delete in trunk/LayoutTests
Combine html and js parts fast/url script-tests
https://bugs.webkit.org/show_bug.cgi?id=115739
Rubber-stamped by Brady Eidson.
- fast/url/anchor.html:
- fast/url/file-http-base.html:
- fast/url/file.html:
- fast/url/host-lowercase-per-scheme.html:
- fast/url/host.html:
- fast/url/idna2003.html:
- fast/url/idna2008.html:
- fast/url/invalid-urls-utf8.html:
- fast/url/ipv4.html:
- fast/url/ipv6.html:
- fast/url/mailto.html:
- fast/url/path-url.html:
- fast/url/path.html:
- fast/url/port.html:
- fast/url/query.html:
- fast/url/relative-unix.html:
- fast/url/relative-win.html:
- fast/url/relative.html:
- fast/url/safari-extension.html:
- fast/url/scheme.html:
- fast/url/script-tests: Removed.
- fast/url/script-tests/TEMPLATE.html: Removed.
- fast/url/script-tests/anchor.js: Removed.
- fast/url/script-tests/file-http-base.js: Removed.
- fast/url/script-tests/file.js: Removed.
- fast/url/script-tests/host.js: Removed.
- fast/url/script-tests/idna2003.js: Removed.
- fast/url/script-tests/idna2008.js: Removed.
- fast/url/script-tests/ipv4.js: Removed.
- fast/url/script-tests/ipv6.js: Removed.
- fast/url/script-tests/mailto.js: Removed.
- fast/url/script-tests/path-url.js: Removed.
- fast/url/script-tests/path.js: Removed.
- fast/url/script-tests/port.js: Removed.
- fast/url/script-tests/query.js: Removed.
- fast/url/script-tests/relative-unix.js: Removed.
- fast/url/script-tests/relative-win.js: Removed.
- fast/url/script-tests/relative.js: Removed.
- fast/url/script-tests/scheme.js: Removed.
- fast/url/script-tests/segments-from-data-url.js: Removed.
- fast/url/script-tests/segments.js: Removed.
- fast/url/script-tests/standard-url.js: Removed.
- fast/url/script-tests/trivial-segments.js: Removed.
- fast/url/script-tests/trivial.js: Removed.
- fast/url/segments-from-data-url.html:
- fast/url/segments.html:
- fast/url/standard-url.html:
- fast/url/trivial-segments.html:
- fast/url/trivial.html:
- 10:45 AM Changeset in webkit [149680] by
-
- 3 edits in trunk/Source/WebKit2
Each local storage database should know its origin
https://bugs.webkit.org/show_bug.cgi?id=115737
Reviewed by Andreas Kling.
Store the security origin in a member variable. It'll be used to communicate database state changes to the tracker.
- UIProcess/Storage/LocalStorageDatabase.cpp:
(WebKit::LocalStorageDatabase::create):
(WebKit::LocalStorageDatabase::LocalStorageDatabase):
- UIProcess/Storage/LocalStorageDatabase.h:
(LocalStorageDatabase):
- 10:42 AM Changeset in webkit [149679] by
-
- 8 edits in trunk
Add an 'isReadOnly' member to IDL parse tree structure
https://bugs.webkit.org/show_bug.cgi?id=115704
Reviewed by Kentaro Hara.
Source/WebCore:
Add an 'isReadOnly' member to IDL parse tree structure by merging
https://chromium.googlesource.com/chromium/blink/+/d6add80ecd08bcd88a6ae0e1698d929830b3bd8b
and update Objective-C, C++, and GObject binding generators to use isReadOnly.
- bindings/scripts/CodeGeneratorCPP.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/CodeGeneratorGObject.pm:
(GetWriteableProperties):
(GenerateProperty):
(GenerateFunctions):
- bindings/scripts/CodeGeneratorJS.pm:
(IsReadonly):
- bindings/scripts/CodeGeneratorObjC.pm:
(GenerateHeader):
(GenerateImplementation):
- bindings/scripts/IDLParser.pm:
(parseAttributeRest):
(parseExceptionField):
(parseAttributeRestOld):
Tools:
Use newly added isReadOnly attribute.
- WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
(_generateHeaderFile):
(_generateImplementationFile):
(_staticValuesGetterImplementation):
- 10:10 AM Changeset in webkit [149678] by
-
- 3 edits in trunk/Source/WebKit2
Remove some unnecessary soft linking in NetworkProcess. (Take 2)
<rdar://problem/13821779> and https://bugs.webkit.org/show_bug.cgi?id=115683
Reviewed by Dean Jackson and owned by Andreas Kling.
As a followup to r149651, include the private headers conditionally.
Also, fix a bug introduced with r149651 (bool vs CFBooleanRef).
- NetworkProcess/mac/DiskCacheMonitor.mm:
- NetworkProcess/mac/NetworkResourceLoaderMac.mm:
(WebKit::NetworkResourceLoader::tryGetShareableHandleFromSharedBuffer):
- 9:54 AM Changeset in webkit [149677] by
-
- 3 edits in trunk/Source/WebCore
Use OwnPtr instead of deleteAllValues in SMILTimeContainer
https://bugs.webkit.org/show_bug.cgi?id=115730
Reviewed by Geoffrey Garen.
- svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::~SMILTimeContainer): Removed call to deleteAllValues.
(WebCore::SMILTimeContainer::schedule): Use add instead of get/set to put a new
AnimationsVector into the map as needed.
(WebCore::SMILTimeContainer::setElapsed): Added get since values are OwnPtr now.
(WebCore::SMILTimeContainer::updateAnimations): Ditto.
- svg/animation/SMILTimeContainer.h: Changed value type of GroupedAnimationsMap
to OwnPtr instead of raw pointer.
- 9:53 AM Changeset in webkit [149676] by
-
- 3 edits in trunk/Source/JavaScriptCore
Take advantage of pre-decrement and post-increment opcodes for sh4 base JIT.
https://bugs.webkit.org/show_bug.cgi?id=115722
Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-07
Reviewed by Oliver Hunt.
- assembler/MacroAssemblerSH4.h:
(JSC::MacroAssemblerSH4::load8PostInc):
(MacroAssemblerSH4):
(JSC::MacroAssemblerSH4::load16Unaligned):
(JSC::MacroAssemblerSH4::load16PostInc):
(JSC::MacroAssemblerSH4::storeDouble):
(JSC::MacroAssemblerSH4::load32WithUnalignedHalfWords):
- assembler/SH4Assembler.h:
(JSC::SH4Assembler::movwMemRegIn):
(SH4Assembler):
(JSC::SH4Assembler::movbMemRegIn):
(JSC::SH4Assembler::printInstr):
- 9:24 AM Changeset in webkit [149675] by
-
- 4 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Read-only fields should not get keyboard focus
https://bugs.webkit.org/show_bug.cgi?id=115725
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-05-07
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
PR332887
Prevent keyboard focus and FCC from displaying when the user taps on a
read-only field. Further, ensure form controls skip over these fields
with the next/previous buttons.
- WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::elementIsReadOnly):
(DOMSupport):
- WebKitSupport/DOMSupport.h:
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::focusedNodeChanged):
(BlackBerry::WebKit::InputHandler::setInputModeEnabled):
(BlackBerry::WebKit::InputHandler::notifyClientOfKeyboardVisibilityChange):
(BlackBerry::WebKit::InputHandler::isActiveTextEdit):
(WebKit):
- WebKitSupport/InputHandler.h:
- 9:18 AM Changeset in webkit [149674] by
-
- 3 edits in trunk/Source/WebKit/blackberry
[BlackBerry] Expand spellcheck logging
https://bugs.webkit.org/show_bug.cgi?id=115482
Patch by Nima Ghanavatian <nghanavatian@blackberry.com> on 2013-05-07
Reviewed by Rob Buis.
Internally reviewed by Mike Fenton.
Fix some build errors when SpellingLog was turned on and expand on the debug
statements to be more verbose. Set up timers and print the duration of each
iteration as we traverse the text to create a range to send out for checking.
- WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::setElementFocused):
(WebKit):
(BlackBerry::WebKit::InputHandler::spellCheckTextBlock):
- WebKitSupport/SpellingHandler.cpp:
(BlackBerry::WebKit::SpellingHandler::spellCheckTextBlock):
(BlackBerry::WebKit::SpellingHandler::parseBlockForSpellChecking):
- 9:01 AM Changeset in webkit [149673] by
-
- 30 edits1 delete in trunk
Remove AlwaysInline.h from WTF
https://bugs.webkit.org/show_bug.cgi?id=115727
Reviewed by Brent Fulgham.
The macro that used to be in AlwaysInline.h is now in Compiler.h so there's no reason
to keep AlwaysInline.h around anymore.
Source/JavaScriptCore:
- jit/JSInterfaceJIT.h:
- parser/Lexer.h:
- runtime/JSCJSValue.h:
- runtime/SymbolTable.h:
Source/WebCore:
- WebCore.vcproj/WebCore.vcproj:
- bindings/js/JSDOMWindowCustom.h:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
- platform/graphics/filters/FEConvolveMatrix.h:
- rendering/InlineIterator.h:
- rendering/InlineTextBox.cpp:
- rendering/RenderBlockLineLayout.cpp:
- rendering/RenderText.cpp:
Source/WTF:
- WTF.vcproj/WTF.vcproj:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/AlwaysInline.h: Removed.
- wtf/BloomFilter.h:
- wtf/FastMalloc.cpp:
- wtf/PassRefPtr.h:
- wtf/dtoa.cpp:
- wtf/gobject/GRefPtr.h:
Tools:
- DumpRenderTree/qt/DumpRenderTreeMain.cpp:
- WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
- 8:53 AM Changeset in webkit [149672] by
-
- 2 edits in trunk/Source/WebCore
[Curl] POST requests sometimes fail.
https://bugs.webkit.org/show_bug.cgi?id=111844
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-05-07
Reviewed by Brent Fulgham.
Curl adds the header 'Expect: 100-Continue' when sending a POST request.
When we receive the header 'HTTP/1.1 100 Continue', we should not call
ResourceHandleClient::didReceiveResponse(), as this will cancel the request,
because the MIME type is empty in this case, causing the POST request to fail.
This header is only sent as an info header, or provisional response.
In addition, this patch changes the classification of http code 304 (Not modified).
It is not reported as a redirect anymore, but as a response
(ResourceHandleClient::didReceiveResponse() is called.
- platform/network/curl/ResourceHandleManager.cpp:
(WebCore::isHttpInfo): Added helper method to determine if http code is http info.
(WebCore::isHttpRedirect): Added helper method to determine if http code is http redirect.
(WebCore::headerCallback): Just return when receiving the header'HTTP/1.1 100 Continue'.
- 8:33 AM Changeset in webkit [149671] by
-
- 3 edits in trunk/Source/WebKit/qt
Crash when calling QWebFrame::evaluateJavaScript
https://bugs.webkit.org/show_bug.cgi?id=113434
Reviewed by Simon Hausmann.
Ensure we hold the JSLock when converting JSValue to JSValueRef.
- Api/qwebelement.cpp:
(setupScriptContext):
(QWebElement::evaluateJavaScript):
- WebCoreSupport/QWebFrameAdapter.cpp:
(QWebFrameAdapter::evaluateJavaScript):
- 8:13 AM Changeset in webkit [149670] by
-
- 6 edits in trunk/Source/WebKit2
[EFL][WK2] Add ewk APIs for setting and getting user agent
https://bugs.webkit.org/show_bug.cgi?id=114429
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-05-07
Reviewed by Andreas Kling.
Provide ewk_view_user_agent_get/set APIs which wraps WK APIs.
- UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::setUserAgent):
- UIProcess/API/efl/EwkView.h:
(EwkView::userAgent):
(EwkView):
- UIProcess/API/efl/ewk_view.cpp:
(ewk_view_user_agent_get):
(ewk_view_user_agent_set):
- UIProcess/API/efl/ewk_view.h:
- UIProcess/API/efl/tests/test_ewk2_view.cpp:
(TEST_F):
- 8:07 AM Changeset in webkit [149669] by
-
- 2 edits in trunk/Source/WebCore
[X11][BlackBerry] Check if MOZ_X11 is defined instead of XP_UNIX npruntime_internal.h
https://bugs.webkit.org/show_bug.cgi?id=113687
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-05-07
Reviewed by Anders Carlsson.
It's assumed that all UNIX platforms use X11 for plugins, which is
not the case of BlackBerry.
- bridge/npruntime_internal.h: Use MOZ_X11 instead of XP_UNIX.
- 7:41 AM Changeset in webkit [149668] by
-
- 3 edits4 adds32 deletes in trunk/LayoutTests
[CSS Regions] Convert remaining fast/regions/webkit-flow* pixel tests to reftests
https://bugs.webkit.org/show_bug.cgi?id=115422
Patch by Radu Stavila <stavila@adobe.com> on 2013-05-07
Reviewed by Andreas Kling.
Converted following tests from pixel tests to ref tests:
- webkit-flow-double-pagination-float-push
- webkit-flow-float-pushed-to-last-region
- webkit-flow-float-unable-to-push
- webkit-flow-floats-inside-regions-bounds
- fast/regions/webkit-flow-double-pagination-float-push-expected.html: Added.
- fast/regions/webkit-flow-float-pushed-to-last-region-expected.html: Added.
- fast/regions/webkit-flow-float-pushed-to-last-region.html:
- fast/regions/webkit-flow-float-unable-to-push-expected.html: Added.
- fast/regions/webkit-flow-float-unable-to-push.html:
- fast/regions/webkit-flow-floats-inside-regions-bounds-expected.html: Added.
- platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
- platform/efl/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
- platform/efl/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
- platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
- platform/gtk/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
- platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
- platform/gtk/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
- platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
- platform/gtk/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
- platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
- platform/gtk/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
- platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
- platform/mac/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
- platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
- platform/mac/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
- platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
- platform/mac/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
- platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
- platform/mac/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
- platform/qt/fast/regions/webkit-flow-double-pagination-float-push-expected.png: Removed.
- platform/qt/fast/regions/webkit-flow-double-pagination-float-push-expected.txt: Removed.
- platform/qt/fast/regions/webkit-flow-float-pushed-to-last-region-expected.png: Removed.
- platform/qt/fast/regions/webkit-flow-float-pushed-to-last-region-expected.txt: Removed.
- platform/qt/fast/regions/webkit-flow-float-unable-to-push-expected.png: Removed.
- platform/qt/fast/regions/webkit-flow-float-unable-to-push-expected.txt: Removed.
- platform/qt/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.png: Removed.
- platform/qt/fast/regions/webkit-flow-floats-inside-regions-bounds-expected.txt: Removed.
- 4:01 AM Changeset in webkit [149667] by
-
- 2 edits in trunk/Tools
[Qt][WTR] QQuickWindowPrivate::setRenderWithoutShowing has been removed from Qt 5
https://bugs.webkit.org/show_bug.cgi?id=114808
Reviewed by Jocelyn Turcotte.
QQuickWindow::grabWindow() has been implemented for isVisible=false for Qt 5.1.
(https://codereview.qt-project.org/#change,54234)
- WebKitTestRunner/qt/PlatformWebViewQt.cpp:
(WTR::WrapperWindow::handleStatusChanged):
- 12:42 AM Changeset in webkit [149666] by
-
- 3 edits in trunk/Source/WebKit/gtk
[GTK] Initialize WebKitWebPlugin path to prevent double-free
https://bugs.webkit.org/show_bug.cgi?id=115624
Patch by Tomas Popela <tpopela@redhat.com> on 2013-05-07
Reviewed by Carlos Garcia Campos.
Use GOwnPtr for WebKitWebPlugin path to prevent double-free
situations. Also use GOwnPtr for GError in webkit_web_plugin_get_path.
- webkit/webkitwebplugin.cpp:
(webkit_web_plugin_finalize):
(webkit_web_plugin_get_path):
- webkit/webkitwebpluginprivate.h:
- 12:23 AM Changeset in webkit [149665] by
-
- 41 edits in trunk/Source
HashTraits<RefPtr<P> >::PeekType should be raw pointer for better performance
https://bugs.webkit.org/show_bug.cgi?id=115646
Reviewed by Darin Adler.
Source/JavaScriptCore:
- bytecompiler/StaticPropertyAnalyzer.h:
(JSC::StaticPropertyAnalyzer::putById):
Updated accordingly to new HashMap<.., RefPtr>::get() semantics.
Source/WebCore:
No new tests, no new functionality.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::get):
(WebCore::AXObjectCache::remove):
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::objectFromAXID):
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::getImage):
- css/InspectorCSSOMWrappers.cpp:
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingSVGDocuments):
- html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::rootEditableElementForSelectionOnMouseDown):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::elementForAlias):
- html/shadow/ContentDistributor.cpp:
(WebCore::ContentDistributor::findInsertionPointFor):
- loader/appcache/ApplicationCache.cpp:
(WebCore::ApplicationCache::resourceForURL):
- loader/archive/ArchiveResourceCollection.cpp:
(WebCore::ArchiveResourceCollection::archiveResourceForURL):
- page/PageGroup.cpp:
(WebCore::PageGroup::transientLocalStorage):
- page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):
(WebCore::CompositeAnimation::pauseTransitionAtTime):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateMaskLayer):
- platform/network/BlobRegistryImpl.cpp:
(WebCore::BlobRegistryImpl::getBlobDataFromURL):
- plugins/PluginDatabase.cpp:
(WebCore::PluginDatabase::pluginForMIMEType):
(WebCore::PluginDatabase::MIMETypeForExtension):
- rendering/RenderCounter.cpp:
(WebCore::makeCounterNode):
(showCounterRendererTree):
- svg/graphics/filters/SVGFilterBuilder.cpp:
(WebCore::SVGFilterBuilder::getEffectById):
Updated accordingly to new HashMap<.., RefPtr>::get() semantics.
Source/WebKit/mac:
- Plugins/Hosted/NetscapePluginHostProxy.mm:
(WebKit::NetscapePluginHostProxy::pluginInstance):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::cancelStreamLoad):
Updated accordingly to new HashMap<.., RefPtr>::get() semantics.
Source/WebKit2:
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):
- NetworkProcess/NetworkResourceLoadScheduler.cpp:
(WebKit::NetworkResourceLoadScheduler::hostForURL):
- Shared/ImmutableDictionary.h:
(WebKit::ImmutableDictionary::get):
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::createSessionStorageMap):
(WebKit::StorageManager::cloneSessionStorageNamespaceInternal):
(WebKit::StorageManager::findStorageArea):
- UIProcess/WebContext.h:
(WebKit::WebContext::supplement):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::webBackForwardItem):
(WebKit::WebProcessProxy::webFrame):
- UIProcess/efl/DownloadManagerEfl.cpp:
(WebKit::DownloadManagerEfl::ewkDownloadJob):
- WebProcess/Network/WebResourceLoadScheduler.h:
(WebKit::WebResourceLoadScheduler::webResourceLoaderForIdentifier):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::streamFromID):
- WebProcess/Plugins/PluginProcessConnectionManager.cpp:
(WebKit::PluginProcessConnectionManager::pluginProcessCrashed):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::cancelStreamLoad):
- WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::wheelEvent):
- WebProcess/WebPage/WebBackForwardListProxy.cpp:
(WebKit::WebBackForwardListProxy::itemForID):
(WebKit::WebBackForwardListProxy::itemAtIndex):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::webUndoStep):
(WebKit::WebPage::didFinishCheckingText):
(WebKit::WebPage::didCancelCheckingText):
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::webPage):
(WebKit::WebProcess::webPageGroup):
Updated accordingly to new HashMap<.., RefPtr>::get() semantics.
Source/WTF:
HashTraits<RefPtr<P> >::PeekType should be raw pointer so that we
can obviate multiple RefPtr copying when invoking HashMap<.., RefPtr>::get()
method.
- wtf/HashTraits.h:
