Timeline



Jun 3, 2013:

11:27 PM Changeset in webkit [151157] by mark.lam@apple.com
  • 3 edits in branches/dfgFourthTier

Merged from http://svn.webkit.org/repository/webkit/trunk

------------------------------------------------------------------------
r148820 | mark.lam@apple.com | 2013-04-21 02:04:09 -0700 (Sun, 21 Apr 2013) | 11 lines
Refactor identical inline functions in JSVALUE64 and JSVALUE32_64 sections
out into the common section.

https://bugs.webkit.org/show_bug.cgi?id=114910.
------------------------------------------------------------------------

11:03 PM Changeset in webkit [151156] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Unable to play videos in Safari using QuickTime plug-in until I've played those videos in Chrome first
https://bugs.webkit.org/show_bug.cgi?id=117174
<rdar://problem/13711687>

Patch by Simon Cooper <scooper@apple.com> on 2013-06-03
Reviewed by Alexey Proskuryakov.

Pull in fixes that allow https connections within the plugin
environment.

  • Resources/PlugInSandboxProfiles/com.apple.WebKit.plugin-common.sb:
10:37 PM Changeset in webkit [151155] by mark.lam@apple.com
  • 53 edits
    4 copies
    1 delete in branches/dfgFourthTier

Source/JavaScriptCore: Merged from http://svn.webkit.org/repository/webkit/trunk

------------------------------------------------------------------------
r148639 | mark.lam@apple.com | 2013-04-17 15:37:45 -0700 (Wed, 17 Apr 2013) | 127 lines
Add LLINT and baseline JIT support for timing out scripts.

https://bugs.webkit.org/show_bug.cgi?id=114577.
------------------------------------------------------------------------
r148641 | mark.lam@apple.com | 2013-04-17 15:57:33 -0700 (Wed, 17 Apr 2013) | 10 lines
Fix broken build. Replaced a static const with a #define.

https://bugs.webkit.org/show_bug.cgi?id=114577.
------------------------------------------------------------------------
r148655 | mark.lam@apple.com | 2013-04-17 20:17:44 -0700 (Wed, 17 Apr 2013) | 10 lines
Avoid using a branch range that is too far for some CPU architectures.

https://bugs.webkit.org/show_bug.cgi?id=114782.
------------------------------------------------------------------------
r148709 | mark.lam@apple.com | 2013-04-18 15:45:25 -0700 (Thu, 18 Apr 2013) | 11 lines
Interpreter entry points should throw the TerminatedExecutionException from the caller frame.

https://bugs.webkit.org/show_bug.cgi?id=114816.
------------------------------------------------------------------------
r148893 | mark.lam@apple.com | 2013-04-22 10:37:29 -0700 (Mon, 22 Apr 2013) | 30 lines
Change baseline JIT watchdog timer check to use the proper fast slow path
infrastructure.

https://bugs.webkit.org/show_bug.cgi?id=114963.
------------------------------------------------------------------------
r148899 | mark.lam@apple.com | 2013-04-22 11:40:58 -0700 (Mon, 22 Apr 2013) | 20 lines
Fix broken 32-bit build to green the bots.

https://bugs.webkit.org/show_bug.cgi?id=114968.
------------------------------------------------------------------------
r148942 | mark.lam@apple.com | 2013-04-22 21:47:08 -0700 (Mon, 22 Apr 2013) | 11 lines
Fix a typo in MacroAssemblerARMv7.h.

https://bugs.webkit.org/show_bug.cgi?id=115011.
------------------------------------------------------------------------
r148989 | mark.lam@apple.com | 2013-04-23 13:54:34 -0700 (Tue, 23 Apr 2013) | 21 lines
Simplify the baseline JIT loop hint call site.

https://bugs.webkit.org/show_bug.cgi?id=115052.
------------------------------------------------------------------------
r149089 | mark.lam@apple.com | 2013-04-24 19:59:51 -0700 (Wed, 24 Apr 2013) | 40 lines
Add watchdog timer polling for the DFG.

https://bugs.webkit.org/show_bug.cgi?id=115134.
------------------------------------------------------------------------
r149420 | mark.lam@apple.com | 2013-04-30 19:38:19 -0700 (Tue, 30 Apr 2013) | 17 lines
JSContextGroupSetExecutionTimeLimit() should not pass a callback to the
VM watchdog if its client did not pass one in.

https://bugs.webkit.org/show_bug.cgi?id=115461.
------------------------------------------------------------------------
r150449 | mark.lam@apple.com | 2013-05-21 09:44:01 -0700 (Tue, 21 May 2013) | 8 lines
Added missing assert condition for PositiveOrZero in ARM branch32().

https://bugs.webkit.org/show_bug.cgi?id=116538.
------------------------------------------------------------------------

Source/WebCore: Merged from http://svn.webkit.org/repository/webkit/trunk

------------------------------------------------------------------------
r148639 | mark.lam@apple.com | 2013-04-17 15:37:45 -0700 (Wed, 17 Apr 2013) | 127 lines
Add LLINT and baseline JIT support for timing out scripts.

https://bugs.webkit.org/show_bug.cgi?id=114577.
------------------------------------------------------------------------

Source/WTF: Merged from http://svn.webkit.org/repository/webkit/trunk

------------------------------------------------------------------------
r148639 | mark.lam@apple.com | 2013-04-17 15:37:45 -0700 (Wed, 17 Apr 2013) | 127 lines
Added currentCPUTime() and currentCPUTimeMS().

https://bugs.webkit.org/show_bug.cgi?id=114577.
------------------------------------------------------------------------

10:09 PM Changeset in webkit [151154] by kangil.han@samsung.com
  • 2 edits in trunk/Source/WebCore

Remove unused arithmetic operation in RenderListItem
https://bugs.webkit.org/show_bug.cgi?id=117175

Reviewed by Brent Fulgham.

Variable 'markerLogicalLeft' is reassigned a value before the old one has been used.

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::positionListMarker):

10:01 PM Changeset in webkit [151153] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

validate-committer-lists script is now outdated and does not work
https://bugs.webkit.org/show_bug.cgi?id=115860

Patch by Simon Pena <simon.pena@samsung.com> on 2013-06-03
Reviewed by Brent Fulgham.

The script validate-committer-lists was outdated, still using the deprecated log
system and having the old addresses for the mailing lists, as well as still referring
to committers.py, after this was renamed to contributors.json. This patch fixes that
so it can be used again.

  • Scripts/validate-committer-lists: Replace calls to log and error with the

new logging mechanism, fix the URLs for the mailing lists, and fix the mentions
to committers.py, which should be contributors.json.
(CommitterListFromMailingList):
(CommitterListFromMailingList.check_for_emails_missing_from_list):
(CommitterListFromGit._fetch_authors_and_last_commit_time_from_git_log):
(CommitterListFromGit._fill_in_emails_for_old_logins):
(CommitterListFromGit.print_committers_missing_from_committer_list):

9:51 PM Changeset in webkit [151152] by dpranke@chromium.org
  • 1 edit
    1 add in trunk/Tools

add a script to dump the tests run most recently by a given worker
https://bugs.webkit.org/show_bug.cgi?id=116571

Reviewed by Brent Fulgham.

The tests_run*.txt results files in layout-test-results/ were removed
in r137356, in favor of collecting more data about how the tests were
run and compressing it and storing it in stats.json. However, it was
nice to just be able to look at a flat text file.

This script will extract the tests run by a given worker from a
given stats.json file, and should help to address that.

  • Scripts/dump-webkit-tests-run: Added.

(main):
(convert_trie_to_flat_paths):

9:02 PM Changeset in webkit [151151] by Brent Fulgham
  • 10 edits in trunk/Tools

[Windows] NRWT is not putting crash logs in proper place
https://bugs.webkit.org/show_bug.cgi?id=117098

Reviewed by Ryosuke Niwa.

Provide windows-specific overloads for various Port features needed to create and capture
crash logs. This change makes it possible to view crash logs (when created) as part of the
summary report at the end of the NRWT run.

  • Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs.find_newest_log): Add support for win32 crash logs
(CrashLogs._find_newest_log_win): Added

  • Scripts/webkitpy/common/system/crashlogs_unittest.py:

(make_mock_crash_report_win): Added
(CrashLogsTest.test_find_log_win): Added.

  • Scripts/webkitpy/common/system/executive.py:

(Executive.running_pids): Add support for Cygwin win32 crash logs

  • Scripts/webkitpy/common/system/executive_mock.py:

(MockExecutive.init):

  • Scripts/webkitpy/common/system/filesystem_unittest.py:

(RealFileSystemTest.test_read_and_write_file): Add tests for
malformed ascii/utf8 handling (i.e., Windows log files)

  • Scripts/webkitpy/port/base.py:

(Port.find_system_pid): Added

  • Scripts/webkitpy/port/server_process.py:

(ServerProcess._start): Gather windows PIDs to match up with Cygwin PIDs

  • Scripts/webkitpy/port/win.py:

(WinPort.setup_crash_log_saving): Don't open windows shell (which might get stuck waiting
for user to hit enter.
(WinPort._get_crash_log): Added
(WinPort.look_for_new_crash_logs): Added
(WinPort.find_system_pid): Added

  • Scripts/webkitpy/port/win_unittest.py:

(WinPortTest.test_get_crash_log): Added test

9:00 PM Changeset in webkit [151150] by mark.lam@apple.com
  • 44 edits
    2 deletes in branches/dfgFourthTier

Merged from http://svn.webkit.org/repository/webkit/trunk

------------------------------------------------------------------------
r148119 | ggaren@apple.com | 2013-04-10 11:51:47 -0700 (Wed, 10 Apr 2013) | 106 lines
Removed bitrotted TimeoutChecker code

Source/JavaScriptCore:
https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------

Source/WebCore:
https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------

Source/WebKit/blackberry:
https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------

Source/WebKit/mac:
https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------

Source/WebKit/qt:
https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------

Source/WebKit2:
https://bugs.webkit.org/show_bug.cgi?id=114336
------------------------------------------------------------------------

8:20 PM Changeset in webkit [151149] by commit-queue@webkit.org
  • 6 edits
    1 add in trunk/Source/JavaScriptCore

[EFL] Implement GCActivityCallback
https://bugs.webkit.org/show_bug.cgi?id=95923

Patch by Hojong Han <hojong.han@samsung.com> on 2013-06-03
Reviewed by Geoffrey Garen.

Implements the activity triggered garbage collector.
Additional GCs can be triggered by platfrom timer.
It has sort of compaction effect not to make JSC heap grow fast
so that memory usage becomes lower than usual.

  • PlatformEfl.cmake: Added.
  • heap/HeapTimer.cpp:

(JSC):
(JSC::HeapTimer::HeapTimer):
(JSC::HeapTimer::~HeapTimer):
(JSC::HeapTimer::add):
(JSC::HeapTimer::stop):
(JSC::HeapTimer::timerEvent):

  • heap/HeapTimer.h:

(HeapTimer):

  • jsc.cpp:

(main):

  • runtime/GCActivityCallback.cpp:

(JSC):
(JSC::DefaultGCActivityCallback::DefaultGCActivityCallback):
(JSC::DefaultGCActivityCallback::scheduleTimer):
(JSC::DefaultGCActivityCallback::cancelTimer):
(JSC::DefaultGCActivityCallback::didAllocate):

  • runtime/GCActivityCallback.h:

(GCActivityCallback):
(JSC::GCActivityCallback::GCActivityCallback):
(DefaultGCActivityCallback):

7:57 PM Changeset in webkit [151148] by mark.lam@apple.com
  • 20 edits in branches/dfgFourthTier

Merged from http://svn.webkit.org/repository/webkit/trunk


r147858 | oliver@apple.com | 2013-04-06 15:47:56 -0700 (Sat, 06 Apr 2013) | 62 lines
Unify the many and varied stack trace mechanisms, and make the result sane.

Source/JavaScriptCore:

https://bugs.webkit.org/show_bug.cgi?id=114072


Source/WebCore:

https://bugs.webkit.org/show_bug.cgi?id=114072


Tools:

https://bugs.webkit.org/show_bug.cgi?id=114072


6:44 PM Changeset in webkit [151147] by roger_fong@apple.com
  • 6 edits
    2 moves in trunk

Unreviewed. Some AppleWin VS2010 house cleaning.

  • WebKit.vcxproj/Interfaces/InterfacesPreBuild.cmd:
  • WebKit.vcxproj/WebKit/WebKitPreBuild.cmd:
  • win/tools32/scripts/auto-version.sh: Replaced with win/tools32/scripts/auto-version2010.sh.
  • win/tools32/scripts/auto-version2010.sh: Removed.
  • win/tools32/scripts/feature-defines.sh: Replaced with win/tools32/scripts/feature-defines2010.sh.
  • win/tools32/scripts/feature-defines2010.sh: Removed.
  • WebCore.vcxproj/build-generated-files.sh:
6:16 PM Changeset in webkit [151146] by roger_fong@apple.com
  • 9 edits
    1 add in trunk

clearLayoutOverflow should never be called before calling layer()->updateScrollInfoAfterLayout().
https://bugs.webkit.org/show_bug.cgi?id=116689.

Reviewed by Ojan Vafai.

Make sure that clearLayoutOverflow only gets called after layer()->updateScrollInfoAfterLayout().
Also move clearLayoutOverflow to RenderBlock so we can keep all the delayed scroll update logic together.

Test: fast/flexbox/clear-overflow-before-scroll-update.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::layout): Remove call to clearLayoutOverflow.
(WebCore::RenderBlock::finishDelayUpdateScrollInfo): Add call to clearLayoutOverflow.
(WebCore::RenderBlock::updateScrollInfoAfterLayout): Ditto.

  • rendering/RenderBlock.h:

(RenderBlock):

  • rendering/RenderBox.cpp:
  • rendering/RenderBox.h:

(WebCore::RenderBox::layoutOverflowRect): Remove from layoutOverflowRect.
(RenderBox):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutBlock): This should call updateScrollInfoAfterLayout() intead of directly calling layer()->updateScrollInfoAfterLayout().

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock): Ditto.

6:09 PM Changeset in webkit [151145] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] Add ATK version 2.8.0 to efl jhbuild moduleset
https://bugs.webkit.org/show_bug.cgi?id=116726

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2013-06-03
Reviewed by Gyuyoung Kim.

.:

Bump required version of ATK to 2.8.0 in EFL CMake's build.

  • Source/cmake/FindATK.cmake: Adds macro to check required version
  • Source/cmake/OptionsEfl.cmake: Specifies required version of ATK to be 2.8.0

Tools:

Current version of ATK in efl-ews environment is 2.4.0 and is taken from
the platform (it is not listed in jhbuild moduleset). That version is
old-ish and contain deprecated symbols and missing API, that are blocking
patches in other ports (gtk). This patch adds ATK version 2.8.0 to efl
moduleset, which is the same version the gtk port uses.

See bug https://bugs.webkit.org/show_bug.cgi?id=115647 for more details on
why this is needed.

  • efl/jhbuild.modules: Adds ATK module as dependency
5:11 PM Changeset in webkit [151144] by fpizlo@apple.com
  • 6 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: all cached put_by_id transitions, even ones that weren't inlined by the DFG, should be propagated by the GC
https://bugs.webkit.org/show_bug.cgi?id=117170

Reviewed by Mark Hahnenberg.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitAggregate):
(JSC::CodeBlock::propagateTransitions):
(JSC):
(JSC::CodeBlock::determineLiveness):
(JSC::CodeBlock::visitWeakReferences):
(JSC::CodeBlock::finalizeUnconditionally):

  • bytecode/CodeBlock.h:

(CodeBlock):

  • bytecode/PolymorphicPutByIdList.h:

(JSC):
(PutByIdAccess):
(PolymorphicPutByIdList):

  • bytecode/StructureStubInfo.h:

(StructureStubInfo):

  • jit/JITCode.h:

(JSC::JITCode::couldBeInterpreted):
(JITCode):

4:42 PM Changeset in webkit [151143] by mark.lam@apple.com
  • 15 edits in branches/dfgFourthTier

Source/JavaScriptCore: Merged from http://svn.webkit.org/repository/webkit/trunk


r146505 | mark.lam@apple.com | 2013-03-21 13:06:26 -0700 (Thu, 21 Mar 2013) | 21 lines
Fix lexer charPosition computation when "rewind"ing the lexer.

https://bugs.webkit.org/show_bug.cgi?id=112952.


r146552 | mark.lam@apple.com | 2013-03-21 18:56:17 -0700 (Thu, 21 Mar 2013) | 50 lines
Fix O(n2) op_debug bytecode charPosition to column computation.

https://bugs.webkit.org/show_bug.cgi?id=112957.


Source/WTF: Merged from http://svn.webkit.org/repository/webkit/trunk


r146552 | mark.lam@apple.com | 2013-03-21 18:56:17 -0700 (Thu, 21 Mar 2013) | 50 lines
Introducing String::findNextLineStart().

https://bugs.webkit.org/show_bug.cgi?id=112957.


3:52 PM Changeset in webkit [151142] by Lucas Forschler
  • 2 edits in tags/Safari-537.43.57/Source/WebKit2

Merged r151035. <rdar://problem/14050413>

3:47 PM Changeset in webkit [151141] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[harfbuzz] WebKit fails to build with MinGW compiler because of invalid cast in HarfBuzzShaper.cpp
https://bugs.webkit.org/show_bug.cgi?id=108373

Patch by Paweł Forysiuk <tuxator@o2.pl> on 2013-06-03
Reviewed by Darin Adler.

Fix building on platforms where UChar is defined as wchar_t.

  • platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):

3:45 PM Changeset in webkit [151140] by rniwa@webkit.org
  • 33 edits
    2 adds in trunk

REGRESSION: Undoing autocorrection doesn't prevent a future autocorrection
https://bugs.webkit.org/show_bug.cgi?id=117165

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by SpellingCorrectionCommand returning true in callsAppliedEditingInDoApply, which prevented
the command from being registered to the undo manager. This behavior was introduced in r148306 because TypingCommand
registeres itself to the undo manager in appliedEditing.

Fixed the bug by reverting both r122176 and r148306 and implementing a better fix for the bug 90487.
Instead of using InsertTextCommand, simply don't specify ReplaceSelectionCommand::PreventNesting so that the command
doesn't try to break out of a blockquote.

Also fix a bug in ReplaceSelectionCommand::completeHTMLReplacement uncovered by this change. We were only merging
text nodes at the beginning of the replaced content but not at the end. Call mergeTextNodesAroundPosition for the
second time to fix whitespace at the end of the replaced content.

Test: platform/mac/editing/spelling/autocorrection-respets-undo.html

  • editing/CompositeEditCommand.cpp: Explictily check isTypingCommand now that callsAppliedEditingInDoApply has been

removed from SpellingCorrectionCommand and TypingCommand and SpellingCorrectionCommand were only classes that
returned true in callsAppliedEditingInDoApply. See r148306 that introduced this function.
(WebCore::CompositeEditCommand::apply):

  • editing/CompositeEditCommand.h: Removed callsAppliedEditingInDoApply.
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::completeHTMLReplacement):

  • editing/SpellingCorrectionCommand.cpp: Removed callsAppliedEditingInDoApply, which was the culprit of this bug,

so that CompositeEditCommand::apply correctly registers this command with the undo manager.
(WebCore::SpellingCorrectionCommand::doApply): Use ReplaceSelectionCommand instead of TypingCommand as noted above.

  • editing/SpellingCorrectionCommand.h:
  • editing/TypingCommand.cpp: Deleted callsAppliedEditingInDoApply.
  • editing/TypingCommand.h:

LayoutTests:

Add a regression test and rebaseline other tests as ReplaceSelectionCommand now merges text nodes at
the end of replaced text.

  • editing/deleting/merge-paragraph-from-address-expected.txt:
  • editing/deleting/merge-paragraph-from-h6-expected.txt:
  • editing/deleting/merge-paragraph-from-listing-expected.txt:
  • editing/deleting/paste-with-transparent-background-color-expected.txt:
  • editing/inserting/insert-3907422-fix-expected.txt:
  • editing/pasteboard/copy-image-with-alt-text-expected.txt:
  • editing/pasteboard/merge-end-4-expected.txt:
  • editing/pasteboard/nested-blocks-with-text-area-expected.txt:
  • editing/pasteboard/nested-blocks-with-text-field-expected.txt:
  • editing/pasteboard/paste-text-001-expected.txt:
  • editing/pasteboard/paste-unrendered-select-expected.txt:
  • editing/pasteboard/smart-paste-003-trailing-whitespace-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-001-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-019-expected.txt:
  • platform/mac/editing/deleting/delete-block-merge-contents-020-expected.txt:
  • platform/mac/editing/pasteboard/4944770-2-expected.txt:
  • platform/mac/editing/pasteboard/8145-2-expected.txt:
  • platform/mac/editing/pasteboard/paste-line-endings-006-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-008-expected.txt:
  • platform/mac/editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
  • platform/mac/editing/pasteboard/paste-xml-expected.txt:
  • platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt:
  • platform/mac/editing/spelling/autocorrection-blockquote-crash.html: Added more asssertions to ensure that

the autocorrected text is in the blockquote. r122176 modified the test description saying that this test
already checks this condition but it never did so explicitly; it assumed that the autocorrected text was
inside a blockquote as long as it started at a certain offset in the text node.

  • platform/mac/editing/spelling/autocorrection-respets-undo-expected.txt: Added.
  • platform/mac/editing/spelling/autocorrection-respets-undo.html: Added.
  • platform/mac/editing/spelling/autocorrection-with-multi-line-text-expected.txt:
3:32 PM Changeset in webkit [151139] by Lucas Forschler
  • 4 edits in tags/Safari-537.43.57/Source

Versioning.

3:29 PM Changeset in webkit [151138] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Reduce indentation in Widget::paint in WidgetMac.mm
https://bugs.webkit.org/show_bug.cgi?id=117171

Reviewed by Darin Adler.

Use an early return for the common case to reduce indentation in the complex case.

  • platform/mac/WidgetMac.mm:

(WebCore::Widget::paint):

3:29 PM Changeset in webkit [151137] by Lucas Forschler
  • 1 copy in tags/Safari-537.43.57

New Tag.

3:28 PM Changeset in webkit [151136] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. AppleWin VS2010 build fix.

  • WebCore.vcxproj/migrate-scripts.sh:
3:25 PM Changeset in webkit [151135] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[GTK] Respect PKG_CONFIG env variable when generating gtk-doc
https://bugs.webkit.org/show_bug.cgi?id=117168

Patch by Erik van Pienbroek <epienbro@fedoraproject.org> on 2013-06-03
Reviewed by Martin Robinson.

The tool generate-gtkdoc internally calls pkg-config.
When cross-compiling it shouldn't use pkg-config, but
it should use the pkg-config which was detected by
the ./configure script (for example this can be
i686-w64-mingw32-pkg-config when cross-compiling)

  • GNUmakefile.am:
  • gtk/gtkdoc.py:

(PkgConfigGTKDoc.init):

3:23 PM Changeset in webkit [151134] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] Unreviewed build fix.

  • TestWebKitAPI/win/main.cpp: Embed proper manifest information to

allow VS2010 builds to use VS2005 runtime libraries as needed.

3:13 PM Changeset in webkit [151133] by roger_fong@apple.com
  • 7 edits
    98 deletes in trunk

Nuke VS2005 files from the tree.
<rdar://problem/14042021>.

Rubberstamped by Brent Fulgham.

3:06 PM Changeset in webkit [151132] by marcelo.lira@openbossa.org
  • 3 edits in trunk/Source/WebKit2

[WK2] REGRESSION(r150798): scrolling coordinator is not being enabled when WebPage is set to use fixed layout
https://bugs.webkit.org/show_bug.cgi?id=117163

Reviewed by Darin Adler.

Moved call to WebPage::settings()->setScrollingCoordinatorEnabled()
from CoordinatedLayerTreeHost constructor to WebPage::setUseFixedLayout().
The scrolling coordinator must be enabled or disabled following the
WebPage's use of fixed layout.

  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::CoordinatedLayerTreeHost):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setUseFixedLayout):

2:51 PM Changeset in webkit [151131] by Chris Fleizach
  • 7 edits in trunk

AX: WebKit should join substrings on single space when concatenating the accessible name of an element
https://bugs.webkit.org/show_bug.cgi?id=117100

Reviewed by Darin Adler.

Source/WebCore:

When concatenating text from underneath an element append spaces between objects and trim whitespace.

Modified existing tests reflect the new behavior.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::textUnderElement):

LayoutTests:

  • accessibility/text-role-with-aria-hidden-inside-expected.txt:
  • accessibility/text-role-with-aria-hidden-inside.html:
  • platform/mac/accessibility/internal-link-anchors2-expected.txt:
  • platform/mac/accessibility/table-with-aria-role-expected.txt:
2:49 PM Changeset in webkit [151130] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/LayoutTests

Unreviewed, unbreak all of the tests.

Printing "Some tests failed" is great for the silentTestPass mode, but breaks all previous
expected-to-fail tests. Changed it so we only print this helpful message if we're in
silentTestPass mode.

  • fast/js/resources/js-test-pre.js:

(isSuccessfullyParsed):

2:47 PM Changeset in webkit [151129] by anlo@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Expose show debug borders setting through BlackBerry::WebKit::WebPage
https://bugs.webkit.org/show_bug.cgi?id=117167

Reviewed by Rob Buis.
Internally reviewed by Arvid Nilsson.

Add WebKit::WebPage API for setting whether to show accelerated compositing
debug borders.

  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPage::setShowDebugBorders):
(WebKit):

  • Api/WebPage.h:
2:41 PM Changeset in webkit [151128] by mark.lam@apple.com
  • 5 edits in branches/dfgFourthTier

Merged from http://svn.webkit.org/repository/webkit/trunk


r147798 | fpizlo@apple.com | 2013-04-05 14:34:15 -0700 (Fri, 05 Apr 2013) | 14 lines
If CallFrame::trueCallFrame() knows that it's about to read garbage instead of a valid
CodeOrigin/InlineCallFrame, then it should give up and return 0 and all callers should
be robust against this

https://bugs.webkit.org/show_bug.cgi?id=114062


2:23 PM Changeset in webkit [151127] by mark.lam@apple.com
  • 5 edits
    3 copies in branches/dfgFourthTier

Source/JavaScriptCore: Merged from http://svn.webkit.org/repository/webkit/trunk


r147670 | oliver@apple.com | 2013-04-04 14:25:26 -0700 (Thu, 04 Apr 2013) | 42 lines
Exception stack unwinding doesn't handle inline callframes correctly
https://bugs.webkit.org/show_bug.cgi?id=113952


r147690 | Christophe Dumez | 2013-04-04 17:44:28 -0700 (Thu, 04 Apr 2013) | 7 lines
Unreviewed EFL build fix.
We had undefined reference to `JSC::CodeOrigin::maximumBytecodeIndex'.


LayoutTests: Merged from http://svn.webkit.org/repository/webkit/trunk


r147670 | oliver@apple.com | 2013-04-04 14:25:26 -0700 (Thu, 04 Apr 2013) | 42 lines
Exception stack unwinding doesn't handle inline callframes correctly
https://bugs.webkit.org/show_bug.cgi?id=113952


2:03 PM Changeset in webkit [151126] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

Remove XMLMIMETypeRegExp
https://bugs.webkit.org/show_bug.cgi?id=116861

Reviewed by Alexey Proskuryakov.

Remove the XMLMIMETypeRegExp class. It contained a regular expression that was used
for checking for valid XML MIME types in DOMImplementation::isXMLMIMEType. The thread-global
instance was stored in ThreadGlobalData.

The class is removed, with DOMImplementation::isXMLMIMEType now testing that the given MIME type
is of proper form and contains only valid characters.

No new tests - no change in functionality.

  • dom/DOMImplementation.cpp:

(WebCore::isValidXMLMIMETypeChar): A helper method that returns true only for characters that
are acceptable in a valid XML MIME type (apart from the forward slash).
(WebCore::DOMImplementation::isXMLMIMEType): Instead of using a regular expression, determine
whether the given string is a valid non-standard XML mime type by checking for the '+xml' ending,
proper forward slash position, and that no invalid characters are used in the string.

  • dom/DOMImplementation.h:
  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData): The OwnPtr<XMLMIMETypeRegExp> member variable is being removed.
(WebCore::ThreadGlobalData::destroy): Ditto.

  • platform/ThreadGlobalData.h:

(WebCore): No need for the XMLMIMETypeRegExp forward declaration.
(ThreadGlobalData): Remove the OwnPtr<XMLMIMETypeRegExp> member variable.

1:52 PM Changeset in webkit [151125] by commit-queue@webkit.org
  • 7 edits in trunk

[GTK] Use drawErrorUnderline() instead of Pango API for highlighting misspelled words
https://bugs.webkit.org/show_bug.cgi?id=115406

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2013-06-03
Reviewed by Martin Robinson.

Source/WebCore:

Replace pango API for drawing underline error on misspelled words, in favor of
drawErrorUnderline() method, removing the platform #ifdef check. As this was the
only usage of Pango in GraphicsContextCairo, it no longer includes pango.h.

  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawLineForDocumentMarker): Removes
pango_cairo_show_error_underline() in favor of drawErrorUnderline().

  • platform/graphics/cairo/DrawErrorUnderline.h:

(drawErrorUnderline): Fills the cairo path at the end of the drawing.

LayoutTests:

Update PNG expectations for some spell checking tests to pass pixel hash comparison.
The images are not visually modified.

  • platform/gtk/editing/spelling/inline-spelling-markers-hidpi-expected.png: Rebaseline

image to pass pixel hash

  • platform/gtk/editing/spelling/inline_spelling_markers-expected.png: Rebasline

image to pass pixel hash

  • platform/gtk/editing/spelling/spelling-expected.png: Rebasline

image to pass pixel hash

12:41 PM Changeset in webkit [151124] by Chris Fleizach
  • 8 edits in trunk/Tools

AX: MathML multiscripts not exposed in Accessibility
https://bugs.webkit.org/show_bug.cgi?id=115069

Reviewed by Tim Horton.

Add methods to help output components of math multiscripts for accessibility.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(mathPostscriptsDescriptionCallback):
(mathPrescriptsDescriptionCallback):
(AccessibilityUIElement::getJSClass):

  • DumpRenderTree/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(convertMathMultiscriptPairsToString):
(AccessibilityUIElement::mathPostscriptsDescription):
(AccessibilityUIElement::mathPrescriptsDescription):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::mathPostscriptsDescription):
(WTR::AccessibilityUIElement::mathPrescriptsDescription):

  • WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:

(AccessibilityUIElement):

  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::_convertMathMultiscriptPairsToString):
(WTR::AccessibilityUIElement::mathPostscriptsDescription):
(WTR::AccessibilityUIElement::mathPrescriptsDescription):

12:35 PM Changeset in webkit [151123] by Chris Fleizach
  • 10 edits
    2 adds in trunk

AX: MathML multiscripts not exposed in Accessibility
https://bugs.webkit.org/show_bug.cgi?id=115069

Reviewed by Tim Horton.

Source/WebCore:

Math multiscript tags allow for an arbitrary number of prescripts and postscripts
around a base object.

This MathML tag currently is not supported in the render tree, but that doesn't need to
stop it from being exposed through accessibility, as a base object with an array of postscripts
and an array of prescripts.

Test: platform/mac/accessibility/mathml-multiscript.html

  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isMathMultiscript):
(AccessibilityObject):
(WebCore::AccessibilityObject::mathPrescripts):
(WebCore::AccessibilityObject::mathPostscripts):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isMathMultiscript):
(WebCore::AccessibilityRenderObject::isIgnoredElementWithinMathTree):
(WebCore::AccessibilityRenderObject::mathBaseObject):
(WebCore::AccessibilityRenderObject::mathPrescripts):
(WebCore::AccessibilityRenderObject::mathPostscripts):

  • accessibility/AccessibilityRenderObject.h:

(AccessibilityRenderObject):

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityPlatformMathSubscriptKey]):
(-[WebAccessibilityObjectWrapper accessibilityPlatformMathSuperscriptKey]):
(-[WebAccessibilityObjectWrapper accessibilityMathPostscripts]):
(-[WebAccessibilityObjectWrapper accessibilityMathPrescripts]):
(-[WebAccessibilityObjectWrapper accessibilityMathOverObject]):
(-[WebAccessibilityObjectWrapper accessibilityMathType]):

  • accessibility/mac/WebAccessibilityObjectWrapperBase.h:
  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(convertMathPairsToNSArray):
(-[WebAccessibilityObjectWrapperBase accessibilityPlatformMathSubscriptKey]):
(-[WebAccessibilityObjectWrapperBase accessibilityPlatformMathSuperscriptKey]):
(-[WebAccessibilityObjectWrapperBase accessibilityMathPostscriptPairs]):
(-[WebAccessibilityObjectWrapperBase accessibilityMathPrescriptPairs]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityPlatformMathSubscriptKey]):
(-[WebAccessibilityObjectWrapper accessibilityPlatformMathSuperscriptKey]):

  • mathml/mathtags.in:

LayoutTests:

  • platform/mac/accessibility/mathml-multiscript-expected.txt: Added.
  • platform/mac/accessibility/mathml-multiscript.html: Added.
12:19 PM Changeset in webkit [151122] by zandobersek@gmail.com
  • 5 edits
    2 adds in trunk/LayoutTests

[Layout Tests] Update testharness scripts, add WebIDLParser.js and idlharness.js
https://bugs.webkit.org/show_bug.cgi?id=116983

Reviewed by Sam Weinig.

Update the testharness scripts that are used by the W3C tests that are located under LayoutTests/http/tests/w3c. Also add the
WebIDLParser.js and idlharness.js scripts that will be used by tests imported in the future. The files are being updated or impoted
off the 06cab30bcee2 changeset in the http://w3c-test.org/resources repository.

No test is affected by this update, though some tests will require rebaselining due to the baselines containing stack traces of which
line numbers will change due to the updated scripts.

  • http/tests/w3c/README: List the currently-imported directories, noting from where they originate, at which changeset were

they imported and what files can or should be modified. Also note what script should be used to import/update the files, if available.

  • http/tests/w3c/resources/WebIDLParser.js: Added. Will be used by future tests imported from the W3C test suites.
  • http/tests/w3c/resources/idlharness.js: Ditto.
  • http/tests/w3c/resources/testharness.css: Updated.
  • http/tests/w3c/resources/testharness.js: Updated.
  • http/tests/w3c/resources/testharnessreport.js: Updated. Removed the default completion callback and readded

the completion callback that was in use until now.

11:33 AM Changeset in webkit [151121] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][WK1][CSS Regions] New test fast/regions/hover-on-child-parent-different-regions.html fails
https://bugs.webkit.org/show_bug.cgi?id=117035

Forced relayout to ensure the hover event has propagated before checking the results.

Patch by Radu Stavila <stavila@adobe.com> on 2013-06-03
Reviewed by Alexandru Chiculita.

  • fast/regions/hover-on-child-parent-different-regions.html:
11:31 AM Changeset in webkit [151120] by andersca@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Add radar number to ChangeLog.

11:30 AM Changeset in webkit [151119] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Send mouse events to the banner for as long as the mouse button is down
https://bugs.webkit.org/show_bug.cgi?id=117161

Reviewed by Beth Dakin.

Keep track of whether the mouse was pressed in a banner and keep sending mouse events to it,
even if they are outside the banner's bounds for as long as the mouse is down.

  • WebProcess/WebPage/PageBanner.h:
  • WebProcess/WebPage/mac/PageBannerMac.mm:

(WebKit::PageBanner::PageBanner):
(WebKit::PageBanner::mouseEvent):

10:57 AM Changeset in webkit [151118] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Selection handles are not cleared when displaying error pages.
https://bugs.webkit.org/show_bug.cgi?id=117158

Reviewed by Carlos Garcia Campos.

PR 342159.

Add explicit cancel of selection state when loading an error page
as it is not always cleared.

Internally Reviewed by Nima Ghanavatian.

  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:

(WebCore::FrameLoaderClientBlackBerry::dispatchDidFailProvisionalLoad):

10:31 AM Changeset in webkit [151117] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: node->parentNode(), Heap-use-after-free in WebCore::RenderBox::exclusionShapeOutsideInfo
https://bugs.webkit.org/show_bug.cgi?id=117155

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-03
Reviewed by David Hyatt.

Source/WebCore:

Ported from a Blink patch by kenrb@chromium.org:

Clear floats on RenderBlocks that haven't had layout

WebKit revision 150084 creates a condition where a RenderBlock
can have a populated floating object list even when it has not
previously had layout. Since clearing of floats is optimized
to not search through parts of the tree that have not had layout,
references to floating objects were not being cleared in some cases.

This patch causes markAllDescendantsWithFloatsForLayout() to proceed
in the above case, in order to clear floats for a RenderBlock that has
not had layout.

Test: fast/block/float/float-list-changed-before-layout-crash.html

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):

LayoutTests:

Test for crash. Note that this will only crash when run under a memory
checking tool like ASAN.

  • fast/block/float/float-list-changed-before-layout-crash-expected.txt: Added.
  • fast/block/float/float-list-changed-before-layout-crash.html: Added.
10:21 AM Changeset in webkit [151116] by commit-queue@webkit.org
  • 4 edits
    6 adds in trunk

[CSS Shapes] inset-rectangle support for shape-outside
https://bugs.webkit.org/show_bug.cgi?id=116641

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-03
Reviewed by Alexandru Chiculita.

Source/WebCore:

Implement support for using inset-rectangles in a shape-outside.

Tests: fast/exclusions/shape-outside-floats/shape-outside-floats-simple-inset-rectangle.html

fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-inset-rectangle.html

  • rendering/ExclusionShape.cpp:

(WebCore::ExclusionShape::createExclusionShape): An inset-rectangle is

simply a rectangle with the dimensions calculated differently. So
just use ExclusionRectangle after converting the dimensions.

  • rendering/ExclusionShapeOutsideInfo.cpp:

(WebCore::ExclusionShapeOutsideInfo::isEnabledFor): Enable inset

rectangles for shape-outside.

LayoutTests:

Add tests for inset-rectangles.

  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-expected.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-inset-rectangle.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-percentage-expected.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-inset-rectangle-percentage.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-inset-rectangle-expected.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-simple-rounded-inset-rectangle.html: Added.
10:17 AM Changeset in webkit [151115] by mifenton@rim.com
  • 2 edits in trunk/Source/WebKit/blackberry

[BlackBerry] ROI details are not always cleared when using back navigation.
https://bugs.webkit.org/show_bug.cgi?id=117159

Reviewed by Carlos Garcia Campos.

PR 328557.

Secondary change to ensure when restoreViewState is triggered
ROI is reset.

Internally Reviewed by Nima Ghanavatian.

  • WebKitSupport/InputHandler.cpp:

(BlackBerry::WebKit::InputHandler::restoreViewState):

8:45 AM Changeset in webkit [151114] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Slider UX updates.
https://bugs.webkit.org/show_bug.cgi?id=117148

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-06-03
Reviewed by Rob Buis.

BlackBerry PR 342328
Internally Reviewed by Jeff Rogers.

Change image and reduce handle size when it is disabled.

  • platform/blackberry/RenderThemeBlackBerry.cpp:

(WebCore::RenderThemeBlackBerry::paintSliderTrack):
(WebCore::RenderThemeBlackBerry::paintSliderThumb):

7:45 AM Changeset in webkit [151113] by zarvai@inf.u-szeged.hu
  • 2 edits
    17 adds in trunk/LayoutTests

[Qt] [WK2] Unreviewed gardening. Unskipping passing tests and generate new test expectations where needed.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-03

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0-wk2/compositing/geometry/video-opacity-overlay-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/geometry/video-opacity-overlay-expected.txt: Added.
  • platform/qt-5.0-wk2/editing/spelling/grammar-markers-expected.png: Added.
  • platform/qt-5.0-wk2/editing/spelling/grammar-markers-expected.txt: Added.
  • platform/qt-5.0-wk2/editing/spelling/grammar-markers-hidpi-expected.png: Added.
  • platform/qt-5.0-wk2/editing/spelling/grammar-markers-hidpi-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
  • platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-rt-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
  • platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-text1-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
  • platform/qt-5.0-wk2/fast/ruby/rubyDOM-insert-text3-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
  • platform/qt-5.0-wk2/fast/ruby/rubyDOM-remove-rt1-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/ruby/rubyDOM-remove-text1-expected.png: Added.
  • platform/qt-5.0-wk2/fast/ruby/rubyDOM-remove-text1-expected.txt: Added.
7:26 AM Changeset in webkit [151112] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] accessibility/placeholder.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112031

Unreviewed EFL gardening.

accessibility/placeholder.html passes after r151103.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-06-03

  • platform/efl-wk2/TestExpectations:
6:58 AM Changeset in webkit [151111] by commit-queue@webkit.org
  • 11 edits in trunk

Unreviewed, rolling out r151109.
http://trac.webkit.org/changeset/151109
https://bugs.webkit.org/show_bug.cgi?id=117145

"Plugins in WK2 aren't implemented yet." (Requested by
jturcotte on #webkit).

Source/WebCore:

  • platform/FileSystem.h:
  • platform/qt/FileSystemQt.cpp:

(WebCore::unloadModule):

  • plugins/mac/PluginPackageMac.cpp:

(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):

  • plugins/mac/PluginViewMac.mm:

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::windowResizerRect):

Tools:

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • qmake/mkspecs/features/features.prf:
  • qmake/mkspecs/features/unix/default_pre.prf:
6:37 AM Changeset in webkit [151110] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

REGRESSION (r143070): Overflow:scroll content does not get clipped properly when the parent box has CSS3 filter on.
https://bugs.webkit.org/show_bug.cgi?id=116859

Patch by Zalan Bujtas <Alan Bujtas> on 2013-06-03
Reviewed by Simon Fraser.

Apply proper clipping for overflow:scroll, when parent dictates
full repaint to ensure correct CSS3 filter effect.

When a particular layer has 'pixel moving' CSS3 filter(drop shadow, blur), it sets clipToDirtyRect
to false to force no clipping on itself and on the child layers too.
No clipping makes overflow:scroll behave like overflow:display, because
overflow::scroll gets clipped at RenderLayer level (as opposed to overflow::hidden).
This patch makes sure that both full repaint and clipping are ensured.

Source/WebCore:

Tests: css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on-parent.html

css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):

LayoutTests:

  • css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on-expected.html: Added.
  • css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on-parent-expected.html: Added.
  • css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on-parent.html: Added.
  • css3/filters/clipping-overflow-scroll-with-pixel-moving-effect-on.html: Added.
6:13 AM Changeset in webkit [151109] by jocelyn.turcotte@digia.com
  • 11 edits in trunk

[Qt] Re-enable plugins on Mac.
https://bugs.webkit.org/show_bug.cgi?id=116622

Reviewed by Tor Arne Vestbø.

Source/WebCore:

  • platform/FileSystem.h:
  • platform/qt/FileSystemQt.cpp:

(WebCore::unloadModule):

  • Q_WS_* aren't defined since Qt5, use Q_OS_MACX instead.
  • plugins/mac/PluginPackageMac.cpp:

(WebCore::PluginPackage::fetchInfo):
(WebCore::PluginPackage::load):

  • createCFString now does the adoption itself.
  • plugins/mac/PluginViewMac.mm:
    • Add missing include.

Source/WebKit/qt:

  • WebCoreSupport/ChromeClientQt.cpp:

(WebCore::ChromeClientQt::windowResizerRect):

  • Add missing parenthese.

Tools:

Plugins on Mac were only enabled if !embedded but the later was set if
QPA is enabled, which is the default since Qt 5.0.

Remove references to 'embedded' and fix various build issues,
PluginViewMac.mm and PluginPackageMac.cpp haven't been compiled since a few
months.

  • DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
  • qmake/mkspecs/features/features.prf:
  • qmake/mkspecs/features/unix/default_pre.prf:
6:12 AM Changeset in webkit [151108] by kangil.han@samsung.com
  • 2 edits in trunk/LayoutTests

[EFL] Remove obsolete test case from TestExpectations

Unreviewed EFL gardening.

xmlviewer/extensions-api.html case has been removed since r151080.

  • platform/efl/TestExpectations:
6:12 AM Changeset in webkit [151107] by jocelyn.turcotte@digia.com
  • 4 edits in trunk/Source/WebCore

[Qt][Mac] Allow drawing plugins with QWindow by always using an intermediate bitmap.
https://bugs.webkit.org/show_bug.cgi?id=116620

Reviewed by Tor Arne Vestbø.

The isolation of QWidget along with QPA in Qt5 is abstracting away the native CGContext
of a QWidget and we would need to create a non-public API to be able to achieve it.
Instead of adding complexity to this rarely touched code, always draw into an
intermediate bitmap that we then paint into our QPainter afterward.

  • Use CGBitmapContextCreate to allocate a buffer directly instead of creating a QPixmap and extract an CGContextRef out of it.
  • Get rid of the "if (platformPluginWidget())" code path since we don't paint directly into the QWidget's backing store anymore.
  • Always use m_contextRef to draw the plugin instead of alternating between direct and indirect drawing.
  • plugins/PluginView.cpp:

(WebCore::PluginView::PluginView):

  • plugins/PluginView.h:
  • plugins/mac/PluginViewMac.mm:

(WebCore::createBitmapContext):
(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformDestroy):
(WebCore::PluginView::setFocus):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::invalidateRect):

6:12 AM Changeset in webkit [151106] by jocelyn.turcotte@digia.com
  • 4 edits in trunk/Source/WebCore

[Qt][Mac] Remove Carbon and QuickDraw support for plugins.
https://bugs.webkit.org/show_bug.cgi?id=116619

Reviewed by Tor Arne Vestbø.

They are only enabled for 32bit builds of QtWebKit and are rarely tested.
Other browsers support them through a 32bit host process.
PluginViewMac.mm is only used by Qt since the Wx port was removed.

  • Only support the Cocoa event model
  • Only support the CoreGraphics drawing model
  • Remove all NP_NO_CARBON and NP_NO_QUICKDRAW blocks in PluginViewMac.mm
  • plugins/PluginView.cpp:

(WebCore::PluginView::setValue):
(WebCore::PluginView::PluginView):

  • plugins/PluginView.h:
  • plugins/mac/PluginViewMac.mm:

(WebCore::PluginView::platformStart):
(WebCore::PluginView::platformDestroy):
(WebCore::PluginView::platformGetValueStatic):
(WebCore::PluginView::setFocus):
(WebCore::PluginView::setNPWindowIfNeeded):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleWheelEvent):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::handleKeyboardEvent):

6:07 AM Changeset in webkit [151105] by zarvai@inf.u-szeged.hu
  • 4 edits in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk1/TestExpectations: Unskip after r151104.
  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations: Skip crashing test.
5:52 AM Changeset in webkit [151104] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt][WK1][CSS Regions] New test fast/regions/hover-on-child-parent-different-regions.html fails
https://bugs.webkit.org/show_bug.cgi?id=117035

Used waitUntilDone() to ensure correct results.

Patch by Radu Stavila <stavila@adobe.com> on 2013-06-03
Reviewed by Antti Koivisto.

  • fast/regions/hover-on-child-parent-different-regions-expected.txt:
  • fast/regions/hover-on-child-parent-different-regions.html:
5:40 AM Changeset in webkit [151103] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK][WK2] accessibility/placeholder.html is failing
https://bugs.webkit.org/show_bug.cgi?id=106344

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-06-03
Reviewed by Gyuyoung Kim.

Tools:

Adds support for retrieving attribute value.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::coreAttributeToAtkAttribute):
(WTR::AccessibilityUIElement::stringAttributeValue):

LayoutTests:

Unskipping failing test. It's been fixed.

  • platform/gtk-wk2/TestExpectations:
5:38 AM Changeset in webkit [151102] by Patrick Gansterer
  • 2 edits in trunk/Source/WTF

Unreviewed WinCE build fix after r150833.

  • wtf/DateMath.cpp:

(WTF::calculateDSTOffset):

4:47 AM Changeset in webkit [151101] by commit-queue@webkit.org
  • 4 edits in trunk

'onended' event is not received in AudioBufferSourceNode and OscillatorNode.
https://bugs.webkit.org/show_bug.cgi?id=117132.

Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-06-03
Reviewed by Christophe Dumez.

Source/WebCore:

The listener argument is a PassRefPtr which becomes NULL after the call to
setAttributeEventListener() in setOnended(). This causes the m_hasEndedListener
boolean to be incorrectly initialized. This patch reverses the two statements so
that the m_hasEndedListener is updated before the call to setAttributeEventListener().

No new tests, already covered by existing tests.

  • Modules/webaudio/AudioScheduledSourceNode.cpp:

(WebCore::AudioScheduledSourceNode::setOnended):

LayoutTests:

Unskip webaudio test cases that were failing due to the 'onended' event not being fired.

  • platform/efl/TestExpectations:
3:30 AM Changeset in webkit [151100] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL]<select> element's text is clipped when a height is specified along with CSS line-height.
https://bugs.webkit.org/show_bug.cgi?id=114862

Patch by Rashmi Kulakarni <rashmi.vijay@samsung.com> on 2013-06-03
Reviewed by Gyuyoung Kim.

Source/WebCore:

Fix <select> element getting clipped when element height becomes less than the line-height.
Set minimum height for <select> element.

No new tests, no behavior change.

  • platform/efl/RenderThemeEfl.cpp:

(WebCore::RenderThemeEfl::adjustMenuListButtonStyle):

LayoutTests:

Rebaselined the test case fast/forms/001.html.

  • platform/efl/fast/forms/001-expected.png:
  • platform/efl/fast/forms/001-expected.txt:
1:58 AM Changeset in webkit [151099] by charles.wei@torchmobile.com.cn
  • 5 edits
    4 adds in trunk

Source/WebCore: Webkit crashes while loading content from Application Cache.
https://bugs.webkit.org/show_bug.cgi?id=116814

Reviewed by Darin Adler.

With the refacor for 112722, which removes MainResourceLoader and moves the functionality to DocumentLoader,
the processing of appcache for main resource error (because of network error) was moved DocumentLoader::
mainReceivedError(), which was trigged by ResourceHandle::didFail->SubResourceLoader::didFail, which already
in a Finishing state after notifying the DocumentLoader of the load failure.

Before patch for 112722, the appcache for main resource error was in MainResourceLoader::didFail(),
which will start processing the potential fallback before notifying DocumentLoader and moving the the state
of the resource loader to finishing state.

So we should move maybeLoadFallbackForMainError out of DocumentLoader::mainReceivedError, and move it to
ApplicationCacheHost::maybeLoadFallbackForError, if the resource that has error is the main resource.

Test: http/tests/appcache/main-resource-fallback-for-network-error-crash.html

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::mainReceivedError):

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::maybeLoadFallbackForError):

  • loader/appcache/ApplicationCacheHost.h:

LayoutTests: Webkit crashes while loading content from Application Cache.
https://bugs.webkit.org/show_bug.cgi?id=116814

Reviewed by Darin Adler.

  • http/tests/appcache/main-resource-fallback-for-network-error-crash-expected.txt: Added.
  • http/tests/appcache/main-resource-fallback-for-network-error-crash.html: Added.
  • http/tests/appcache/resources/main-resource-fallback-for-network-error-crash.manifest: Added.
  • http/tests/appcache/resources/success-and-notify-done.html: Added.
1:34 AM Changeset in webkit [151098] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Process launcher uses system() for wrapping the WebProcess when using WEB_PROCESS_CMD_PREFIX
https://bugs.webkit.org/show_bug.cgi?id=105156

Patch by Sergio Correia <Sergio Correia> on 2013-06-03
Reviewed by Christophe Dumez.

When using WEB_PROCESS_CMD_PREFIX - which allows us for instance to analyze
WebProcess under tools like valgrind or gdb -, the ProcessLauncher would
spawn the new process using system(), which would, among other things, keep
an extra UIProcess waiting and executing the shell.

This patch handles the normal case and the case where we have something to
prefix WebProcess (i.e., by using WEB_PROCESS_CMD_PREFIX in a debug build)
the same way, through a call to execvp().

To achieve this a function was introduced to create an array with the given
arguments to the full command to be executed, to be used by execvp(). We use
a Vector<OwnArrayPtr<char>>, so that we can take advantage of the destructor
of OwnArrayPtr to handle the memory deallocation when it goes out of scope.

  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::createArgsArray): This function creates the array to be used by
execvp(), out of the Strings given as arguments.
(WebKit::ProcessLauncher::launchProcess): Rework the logic to accomodate
both the cases with and without WEB_PROCESS_CMD_PREFIX. The execl() call
was replaced with an execvp() call, since now we should deal with having
a variable number of arguments (WEB_PROCESS_CMD_PREFIX) as well.

1:02 AM Changeset in webkit [151097] by Christophe Dumez
  • 5 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline 2 printing test cases on EFL port.

  • platform/efl/printing/compositing-layer-printing-expected.png:
  • platform/efl/printing/compositing-layer-printing-expected.txt:
  • platform/efl/printing/page-rule-in-media-query-expected.png:
  • platform/efl/printing/page-rule-in-media-query-expected.txt:
12:48 AM Changeset in webkit [151096] by Christophe Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Skip 2 webaudio tests that are failing due to the onended event not getting
fired.

  • platform/efl/TestExpectations:
12:44 AM Changeset in webkit [151095] by Christophe Dumez
  • 11 edits
    2 adds in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline several test cases on EFL.

  • platform/efl-wk2/compositing/overflow/content-gains-scrollbars-expected.txt: Added.
  • platform/efl-wk2/compositing/overflow/content-loses-scrollbars-expected.txt: Added.
  • platform/efl-wk2/fast/dynamic/002-expected.txt:
  • platform/efl/fast/block/float/float-not-removed-from-next-sibling2-expected.png:
  • platform/efl/fast/block/float/float-not-removed-from-next-sibling2-expected.txt:
  • platform/efl/fast/dynamic/002-expected.png:
  • platform/efl/fast/table/007-expected.png:
  • platform/efl/fast/table/007-expected.txt:
  • platform/efl/fast/table/colspanMinWidth-expected.png:
  • platform/efl/fast/table/colspanMinWidth-expected.txt:
  • platform/efl/fast/table/spanOverlapRepaint-expected.png:
  • platform/efl/fast/table/spanOverlapRepaint-expected.txt:
12:14 AM Changeset in webkit [151094] by Christophe Dumez
  • 37 edits in trunk/LayoutTests

Unreviewed EFL gardening.

Rebaseline several mozilla tables layout tests for EFL port.

  • platform/efl/tables/mozilla/bugs/bug13169-expected.png:
  • platform/efl/tables/mozilla/bugs/bug13169-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug133756-1-expected.png:
  • platform/efl/tables/mozilla/bugs/bug133756-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug133756-2-expected.png:
  • platform/efl/tables/mozilla/bugs/bug133756-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug17138-expected.png:
  • platform/efl/tables/mozilla/bugs/bug17138-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug17548-expected.png:
  • platform/efl/tables/mozilla/bugs/bug17548-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug220536-expected.png:
  • platform/efl/tables/mozilla/bugs/bug220536-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug6304-expected.png:
  • platform/efl/tables/mozilla/bugs/bug6304-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug73321-expected.png:
  • platform/efl/tables/mozilla/bugs/bug73321-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug7714-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug8858-expected.png:
  • platform/efl/tables/mozilla/bugs/bug8858-expected.txt:
  • platform/efl/tables/mozilla/core/bloomberg-expected.png:
  • platform/efl/tables/mozilla/core/bloomberg-expected.txt:
  • platform/efl/tables/mozilla/core/cell_heights-expected.png:
  • platform/efl/tables/mozilla/core/cell_heights-expected.txt:
  • platform/efl/tables/mozilla/other/test6-expected.png:
  • platform/efl/tables/mozilla/other/test6-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1010-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.png:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug6933-expected.txt:
12:09 AM Changeset in webkit [151093] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WTF

[WTF] Add OwnArrayPtr vectortraits template
https://bugs.webkit.org/show_bug.cgi?id=117131

Reviewed by Darin Adler.

To support Vector<OwnArrayPtr<P>>, which will be used by EFL port.

  • wtf/VectorTraits.h:

Jun 2, 2013:

10:32 PM Changeset in webkit [151092] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed EFL Gardening.

  • platform/efl-wk2/TestExpectations: Unskipping some of webgl passing tests.
9:53 PM Changeset in webkit [151091] by commit-queue@webkit.org
  • 11 edits
    2 deletes in trunk/Source

[Qt] Move Qt port off legacy clipboard
https://bugs.webkit.org/show_bug.cgi?id=116416

Patch by Arunprasad Rajkumar <arurajku@cisco.com> on 2013-06-02
Reviewed by Darin Adler.

Source/WebCore:

No change in behavior, no new tests added.

  • Target.pri: Removed ClipboardQt.h and EditorQt.cpp from compilation.
  • dom/Clipboard.h:
  • editing/qt/EditorQt.cpp: Removed.
  • page/qt/EventHandlerQt.cpp: Use Clipboard::createForDragAndDrop().

(WebCore::EventHandler::createDraggingClipboard):

  • platform/Pasteboard.h:

(WebCore::Pasteboard::clipboardData): Expose writable QMimeData* to outside, so that it is accessible
from DragClientQt.cpp and WebDragClientQt.cpp.
(WebCore::Pasteboard::invalidateWritableData):
(WebCore::Pasteboard::isForDragAndDrop):
(WebCore::Pasteboard::isForCopyAndPaste):

  • platform/qt/ClipboardQt.cpp:

(WebCore::Clipboard::createDragImage):
(WebCore::Clipboard::declareAndWriteDragImage):

  • platform/qt/ClipboardQt.h: Removed.
  • platform/qt/PasteboardQt.cpp: Moved required methods from ClipboardQt.cpp.

(WebCore::isTextMimeType):
(WebCore::isHtmlMimeType):
(WebCore::Pasteboard::create):
(WebCore::Pasteboard::createForCopyAndPaste):
(WebCore::Pasteboard::createPrivate):
(WebCore::Pasteboard::createForDragAndDrop):
(WebCore::Pasteboard::Pasteboard):
(WebCore::Pasteboard::~Pasteboard):
(WebCore::Pasteboard::generalPasteboard):
(WebCore::Pasteboard::isSelectionMode):
(WebCore::Pasteboard::setSelectionMode):
(WebCore::Pasteboard::readData):
(WebCore::Pasteboard::hasData):
(WebCore::Pasteboard::clear):
(WebCore::Pasteboard::readString):
(WebCore::Pasteboard::writeString):
(WebCore::Pasteboard::types):
(WebCore::Pasteboard::readFilenames):
(WebCore::Pasteboard::setDragImage):
(WebCore::Pasteboard::writePasteboard):

Source/WebKit/qt:

  • WebCoreSupport/DragClientQt.cpp:

(WebCore::DragClientQt::startDrag):

Source/WebKit2:

  • WebProcess/WebCoreSupport/qt/WebDragClientQt.cpp:

(WebKit::WebDragClient::startDrag):

9:14 PM Changeset in webkit [151090] by Lucas Forschler
  • 4 edits in branches/safari-537.43-branch/Source

Versioning.

9:13 PM Changeset in webkit [151089] by Lucas Forschler
  • 1 copy in tags/Safari-537.43.7

New Tag.

6:43 PM Changeset in webkit [151088] by beidson@apple.com
  • 3 edits
    3 adds in trunk

Going "back" to a cached page from a page with a main resource error breaks scrolling, amongst other issues.
<rdar://problem/13751844> and https://bugs.webkit.org/show_bug.cgi?id=117112

Reviewed by Alexey Proskuryakov.

Source/WebCore:

If a main resource load ends in error, the Document's parser is never cleared out.

If you then return to a CachedPage, we run the Document->clearParser() step for the
old page and that incorrectly dispatches didFinishLoad for the previous page load
in the middle of the load for the cached page.

The parser should never be needed after a load completes (even if it fails) and
holding on to the parser after the page load failed but before a new navigation is
actually using unnecessary resources.

So we should just clear the parser right when the main resource fails.

Test: http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::stopLoading): After canceling the main resource load, also clear the parser.

LayoutTests:

  • http/tests/loading/resources/resource-that-goes-back-while-still-loading.php: Added.
  • http/tests/loading/unfinished-load-back-to-cached-page-callbacks-expected.txt: Added.
  • http/tests/loading/unfinished-load-back-to-cached-page-callbacks.html: Added.
4:34 PM Changeset in webkit [151087] by sfalken@apple.com
  • 1 edit in branches/safari-537.43-branch/Source/WebCore/ChangeLog

Fix typo in ChangeLog

4:33 PM Changeset in webkit [151086] by sfalken@apple.com
  • 6 edits in branches/safari-537.43-branch/Source/WebCore

Rollout r151084

2:32 PM Changeset in webkit [151085] by weinig@apple.com
  • 6 edits in branches/safari-537.43-branch/Source/WebCore

Merged r151076. <rdar://problem/14042030>

1:37 PM Changeset in webkit [151084] by ap@apple.com
  • 1 edit
    1 delete in trunk/LayoutTests

The empty directory did not get deleted by commit queue, deleting manually.

  • xmlviewer: Removed.
  • xmlviewer/resources: Removed.
12:08 PM Changeset in webkit [151083] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[CMake] Unreviewed buildfix after r148896 and r150940.

  • CMakeLists.txt:
10:29 AM Changeset in webkit [151082] by fpizlo@apple.com
  • 6 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: Get rid of StructureStubInfo::bytecodeIndex
https://bugs.webkit.org/show_bug.cgi?id=117127

Reviewed by Mark Hahnenberg.

StructureStubInfo already has a CodeOrigin field, which also has a bytecodeIndex.
It makes sense to just always use the CodeOrigin.

  • bytecode/StructureStubInfo.h:

(StructureStubInfo):
(JSC::getStructureStubInfoBytecodeIndex):

  • jit/JIT.cpp:

(JSC::PropertyStubCompilationInfo::copyToStubInfo):

  • jit/JIT.h:

(JSC::JIT::compileGetByIdProto):
(JSC::JIT::compileGetByIdSelfList):
(JSC::JIT::compileGetByIdProtoList):
(JSC::JIT::compileGetByIdChainList):
(JSC::JIT::compileGetByIdChain):
(JSC::JIT::compilePutByIdTransition):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::privateCompilePutByIdTransition):

1:33 AM Changeset in webkit [151081] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2][CoordinatedGraphics]: Use a properly initialized WebPage when creating a PageClient
https://bugs.webkit.org/show_bug.cgi?id=117116

Patch by Sergio Correia <Sergio Correia> on 2013-06-02
Reviewed by Tim Horton.

Valgrind reported a "conditional jump or move depends on uninitialised value"
at WebPageProxy constructor, when checking the m_isVisible variable inside
the ENABLE(PAGE_VISIBILITY_API) guard.

The issue was tracked down to the WebView constructor, which was creating a
WebKit::PageClient* making use of `this' before having initialized all of its
attributes.

The solution was to move the initialization of the `page' member to inside the
constructor itself - out of the initialization list -, where we can guarantee
all the relevant stuff has already been properly initialized.

Here's the relevant valgrind trace for reference:

Conditional jump or move depends on uninitialised value(s)

at 0x65A35A4: WebKit::WebPageProxy::WebPageProxy(WebKit::PageClient*,

WTF::PassRefPtr<WebKit::WebProcessProxy>,
WebKit::WebPageGroup*, unsigned long) (WebPageProxy.cpp:322)

by 0x65A2BA2: WebKit::WebPageProxy::create(WebKit::PageClient*,

WTF::PassRefPtr<WebKit::WebProcessProxy>,
WebKit::WebPageGroup*, unsigned long) (WebPageProxy.cpp:233)

by 0x65E94BB: WebKit::WebProcessProxy::createWebPage(WebKit::PageClient*,

WebKit::WebContext*, WebKit::WebPageGroup*)
(WebProcessProxy.cpp:172)

by 0x6570957: WebKit::WebContext::createWebPage(WebKit::PageClient*,

WebKit::WebPageGroup*, WebKit::WebPageProxy*)
(WebContext.cpp:735)

by 0x67673E3: WebKit::WebView::WebView(WebKit::WebContext*,

WebKit::WebPageGroup*) (WebView.cpp:52)

by 0x6775F18: WebKit::WebViewEfl::WebViewEfl(WebKit::WebContext*,

WebKit::WebPageGroup*) (WebViewEfl.cpp:54)

by 0x6775EB4: WebKit::WebView::create(WebKit::WebContext*,

WebKit::WebPageGroup*) (WebViewEfl.cpp:49)

by 0x673E13D: WKViewCreate (WKView.cpp:33)
by 0x6763ECE: EWKViewCreate (ewk_view.cpp:92)

  • UIProcess/CoordinatedGraphics/WebView.cpp:

(WebKit::WebView::WebView):

1:14 AM Changeset in webkit [151080] by ap@apple.com
  • 4 edits
    2 adds
    3 deletes in trunk

Unstyled XML viewer crashes when XML contains an element with id="tree"
https://bugs.webkit.org/show_bug.cgi?id=117117
<rdar://problem/13727267>

Reviewed by Darin Adler.

Source/WebCore:

Test: http/tests/xmlviewer/dumpAsText/existing-tree-element-crash.xml

  • xml/XMLViewer.css: Removed the rule to hide source document, as we no longer

keep it in the tree.

  • xml/XMLViewer.js:

(prepareWebKitXMLViewer): Make sourceXML a detached tree, as otherwise it can
have ID conflicts with elements we add.
(sourceXMLLoaded): Removed some commented out code. Removed code that was checking
whether an extension took over XML display, as it makes no sense to duplicate this
functionality in an extension.

LayoutTests:

  • http/tests/xmlviewer/dumpAsText/existing-tree-element-crash-expected.txt: Added.
  • http/tests/xmlviewer/dumpAsText/existing-tree-element-crash.xml: Added.
  • xmlviewer: Removed.
  • xmlviewer/extensions-api-expected.txt: Removed.
  • xmlviewer/extensions-api.html: Removed.
  • xmlviewer/resources: Removed.
  • xmlviewer/resources/sample.xml: Removed.

The "API" no longer exists.

Jun 1, 2013:

9:42 PM Changeset in webkit [151079] by Chris Fleizach
  • 3 edits
    2 adds in trunk

WebKit ignores aria-hidden when traversing nodes for name calculation
https://bugs.webkit.org/show_bug.cgi?id=117101

Reviewed by Tim Horton.

Source/WebCore:

When calculating the inner text, aria-hidden should be considered.

Test: accessibility/text-role-with-aria-hidden-inside.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::shouldUseAccessiblityObjectInnerText):

LayoutTests:

  • accessibility/text-role-with-aria-hidden-inside-expected.txt: Added.
  • accessibility/text-role-with-aria-hidden-inside.html: Added.
4:41 PM Changeset in webkit [151078] by jberlin@webkit.org
  • 8 edits in branches/safari-537.43-branch/Source/WebKit2

Merge r151054.

4:31 PM Changeset in webkit [151077] by jberlin@webkit.org
  • 17 edits in branches/safari-537.43-branch/Source/WebKit2

Merge r151043.

4:26 PM Changeset in webkit [151076] by Darin Adler
  • 6 edits in trunk/Source/WebCore

window.speechSynthesis needs to be cheap
https://bugs.webkit.org/show_bug.cgi?id=117111
rdar://problem/14042030

Reviewed by Dean Jackson.

Add the traditional laziness to all of the speech synthesis code, wherever
it was omitted.

  • Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::create): Tweaked style (took out unneeded parentheses).
(WebCore::SpeechSynthesis::SpeechSynthesis): Don't create m_platformSpeechSynthesizer.
(WebCore::SpeechSynthesis::setPlatformSynthesizer): Clear state when changing the
platform speech synthesizer. Since this code is only used to set up a mock in the
test runner, the fact that it was wrong before was harmless, but still not good.
(WebCore::SpeechSynthesis::getVoices): Create the platform speech synthesizer here
so we can get the voice list from it.
(WebCore::SpeechSynthesis::startSpeakingImmediately): Create the platform speech
synthesizer here.
(WebCore::SpeechSynthesis::cancel): Check the platform speech synthesizer for
null and do nothing if it's not present.
(WebCore::SpeechSynthesis::pause): Ditto.
(WebCore::SpeechSynthesis::resume): Ditto.

  • platform/PlatformSpeechSynthesizer.cpp:

(WebCore::PlatformSpeechSynthesizer::create): Don't call initializeVoiceList just
to create a synthesizer.
(WebCore::PlatformSpeechSynthesizer::voiceList): Do call initializeVoiceList once
when asked for a voice list.

  • platform/PlatformSpeechSynthesizer.h: The voiceList function is no longer inlined.

The unused setVoiceList function has been removed. The initializeVoiceList is now
private rather than protected. Added a new m_voiceListIsInitialized boolean.

  • platform/mac/PlatformSpeechSynthesizerMac.mm:

(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer): Initialize
m_voiceListIsInitialized to false.

  • platform/mock/PlatformSpeechSynthesizerMock.cpp:

(WebCore::PlatformSpeechSynthesizerMock::create): Don't call initializeVoiceList just
to create a synthesizer.
(WebCore::PlatformSpeechSynthesizerMock::~PlatformSpeechSynthesizerMock):
Removed unneeded call to m_speakingFinishedTimer.stop() since timers automatically
stop when you destroy them.
(WebCore::PlatformSpeechSynthesizerMock::initializeVoiceList): Removed unneeded
call to m_voiceList.clear(), since the caller only calls this once when the
voice list is already clear.

4:09 PM Changeset in webkit [151075] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Add a preferred email address and "expertise" for me.

  • Scripts/webkitpy/common/config/contributors.json:
4:09 PM Changeset in webkit [151074] by jberlin@webkit.org
  • 2 edits in branches/safari-537.43-branch/Tools

Merge r150636.

3:24 PM Changeset in webkit [151073] by fpizlo@apple.com
  • 11 edits in branches/dfgFourthTier/Source/JavaScriptCore

Fix some minor issues in the DFG's profiling of heap accesses
https://bugs.webkit.org/show_bug.cgi?id=113010

Reviewed by Goeffrey Garen.

Carefully merge r146669 from trunk. This required some fiddling since it
wasn't a clean apply.

Original changelog:

1) If a CodeBlock gets jettisoned by GC, we should count the exit sites.


2) If a CodeBlock clears a structure stub during GC, it should record this, and
the DFG should prefer to not inline that access (i.e. treat it as if it had an
exit site).


3) If a PutById was seen by the baseline JIT, and the JIT attempted to cache it,
but it chose not to, then assume that it will take slow path.


4) If we frequently exited because of a structure check on a weak constant,
don't try to inline that access in the future.


5) Treat all exits that were counted as being frequent.


81% speed-up on Octane/gbemu. Small speed-ups elsewhere, and no regressions.


  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeUnconditionally):
(JSC):
(JSC::CodeBlock::resetStubDuringGCInternal):
(JSC::CodeBlock::reoptimize):
(JSC::CodeBlock::jettison):
(JSC::ProgramCodeBlock::jettisonImpl):
(JSC::EvalCodeBlock::jettisonImpl):
(JSC::FunctionCodeBlock::jettisonImpl):
(JSC::CodeBlock::tallyFrequentExitSites):

  • bytecode/CodeBlock.h:

(CodeBlock):
(JSC::CodeBlock::tallyFrequentExitSites):
(ProgramCodeBlock):
(EvalCodeBlock):
(FunctionCodeBlock):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFor):

  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFor):

  • bytecode/StructureStubInfo.h:

(JSC::StructureStubInfo::StructureStubInfo):
(StructureStubInfo):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGOSRExitBase.cpp:

(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSiteSlow):

  • dfg/DFGOSRExitBase.h:

(JSC::DFG::OSRExitBase::considerAddingAsFrequentExitSite):
(OSRExitBase):

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

  • runtime/Options.h:

(JSC):

11:02 AM Changeset in webkit [151072] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Fix typo in r151071.

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

3:20 AM Changeset in webkit [151071] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Move Node::hasName() to Element.
<http://webkit.org/b/117107>

Reviewed by Antti Koivisto.

A Node can't have attributes, and thus can't have a name.
Use a bit on ElementData instead of (half) a Node flag to track whether we have a name.

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):
(WebCore::ElementData::ElementData):

  • dom/Element.h:

(WebCore::ElementData::hasName):
(WebCore::Element::hasName):

  • dom/Node.h:

(WebCore::Node::isEditingText):

2:48 AM Changeset in webkit [151070] by akling@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Remove unnused WebDOMNodeOperationsInternal category.
<http://webkit.org/b/117105>

Reviewed by Ryosuke Niwa.

_subresourceURLs had no clients.

  • DOM/WebDOMOperations.mm:
2:39 AM Changeset in webkit [151069] by akling@apple.com
  • 8 edits in trunk/Source

Move Node::hasID() and hasClass() to Element.
<http://webkit.org/b/117104>

Reviewed by Ryosuke Niwa.

Source/WebCore:

A Node can't have attributes, and thus can't have an ID or a class.
Move these to Element instead, and fix up a few call sites that called through on a Node*.

  • dom/Element.h:
  • dom/LiveNodeList.cpp:

(WebCore::LiveNodeList::namedItem):

  • dom/Node.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::name):

  • rendering/RenderTreeAsText.cpp:

(WebCore::RenderTreeAsText::writeRenderObject):
(WebCore::writeRenderRegionList):

Source/WebKit/mac:

  • WebView/WebRenderLayer.mm:

(+[WebRenderLayer nameForLayer:]):

May 31, 2013:

11:00 PM Changeset in webkit [151068] by gyuyoung.kim@samsung.com
  • 4 edits in trunk/LayoutTests

Unreviewed, EFL gardening. Remove passed accessibility test from EFL WK1.

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
10:41 PM Changeset in webkit [151067] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk/Source

[Curl] Unable to download files.
https://bugs.webkit.org/show_bug.cgi?id=116150

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-05-31
Reviewed by Brent Fulgham.

Implemented basic download functionality for Curl.

Source/WebCore:

  • WebCore.vcproj/WebCore.vcproj: Added file.
  • WebCore.vcxproj/WebCore.vcxproj: Added file.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Added file.
  • platform/network/curl/CurlDownload.h: Added.
  • platform/network/curl/CurlDownload.cpp: Added.

Source/WebKit/win:

  • WebDownload.h:
  • WebDownloadCurl.cpp:

(WebDownload::init):
(WebDownload::start):
(WebDownload::cancel):
(WebDownload::deletesFileUponFailure):
(WebDownload::setDeletesFileUponFailure):
(WebDownload::setDestination):
(WebDownload::useCredential):
(WebDownload::didReceiveResponse):
(WebDownload::didReceiveDataOfLength):
(WebDownload::didFinish):
(WebDownload::didFail):

9:21 PM Changeset in webkit [151066] by roger_fong@apple.com
  • 3 edits in trunk/Tools

Unreviewed. Make windows test bots search in the correct directory for build output.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(RunWebKitTests.start):

  • Scripts/webkitdirs.pm:

(determineConfigurationProductDir):

8:54 PM Changeset in webkit [151065] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Windows build fix...

  • BuildSlaveSupport/built-product-archive:

(createZip):

8:34 PM Changeset in webkit [151064] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Windows build fix. One more time!

  • BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):
(extractBuiltProduct):

8:04 PM Changeset in webkit [151063] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Windows build fix.

  • Scripts/build-webkit:
7:59 PM Changeset in webkit [151062] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] Add a null checking condition to in hide() of EwkContextMenu
https://bugs.webkit.org/show_bug.cgi?id=117014

Reviewed by Christophe Dumez.

m_viewImpl is able to be null. So, we need to protect this function against such case.

  • UIProcess/API/efl/ewk_context_menu.cpp:

(EwkContextMenu::hide):
(ewk_context_menu_hide):

  • UIProcess/API/efl/ewk_context_menu_private.h:

(EwkContextMenu):

6:43 PM Changeset in webkit [151061] by Lucas Forschler
  • 4 edits in branches/safari-537.43-branch/Source

Versioning.

6:39 PM Changeset in webkit [151060] by oliver@apple.com
  • 4 edits in trunk/Source/WebKit2

Fix bug in active page tracking that lead to plugins hanging during destruction
https://bugs.webkit.org/show_bug.cgi?id=117099

Reviewed by Anders Carlsson.

NPRuntimeObjectMap no longer keeps its own reference to the
throttler, and no longer reports activity during destruction.

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::NPRuntimeObjectMap):
(WebKit::NPRuntimeObjectMap::evaluate):

  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::PluginView):

6:07 PM Changeset in webkit [151059] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Windows build fix.

  • Scripts/build-webkit:
5:45 PM Changeset in webkit [151058] by Lucas Forschler
  • 1 copy in tags/Safari-537.43.6

New Tag.

5:18 PM EfficientStrings edited by rafael.lobo@openbossa.org
This is a summary of what was discussed on "[webkit-dev] When should I … (diff)
5:01 PM Changeset in webkit [151057] by timothy_horton@apple.com
  • 6 edits in trunk/Source/WebKit2

[wk2] All intrinsic content size changes should go through the 0-delay timer
https://bugs.webkit.org/show_bug.cgi?id=117058
<rdar://problem/13935042>

Reviewed by Anders Carlsson.

In r146913, I added a 0-delay timer so that we'd coalesce intrinsic
content size changes. However, didUpdateGeometry was still immediately
invalidating the intrinsic content size without coalescing.

Move that update to the WebProcess to share the timer.

  • UIProcess/DrawingAreaProxy.h:

(WebKit::DrawingAreaProxy::didUpdateGeometry):

  • UIProcess/DrawingAreaProxy.messages.in:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::didUpdateGeometry):
Remove the newIntrinsicContentSize argument, and don't invalidate intrinsic
content size inside didUpdateGeometry.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updateGeometry):
Start the intrinsic content size update timer when we finish updateGeometry.

4:47 PM Changeset in webkit [151056] by roger_fong@apple.com
  • 2 edits
    2 deletes in trunk/Tools

Make build-webkit output VCExpress 2010 build logs properly.
https://bugs.webkit.org/show_bug.cgi?id=117096

Reviewed by Brent Fulgham.

Make it so that output from VCExpress is always printed to console.
Get build log results from AssembleBuildLogs project output.
We don't need those old VCExpress scripts anymore either.

  • Scripts/build-webkit:
  • Scripts/print-msvc-project-dependencies: Removed.
  • Scripts/print-vse-failure-logs: Removed.
4:40 PM Changeset in webkit [151055] by ap@apple.com
  • 5 edits
    1 add in trunk/Source/WebKit2

Sandbox violations when trying to access fonts in non-standard locations
https://bugs.webkit.org/show_bug.cgi?id=117097
<rdar://problem/9264746>

Reviewed by Anders Carlsson.

The issue was that lack of a main xib was resulting in font machinery being
initialized too early, before we entered sandbox.

  • Resources/WebContentProcess.xib: Added.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/EntryPoint/mac/LegacyProcess/Info.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService.Development/Info.plist:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist:
4:32 PM Changeset in webkit [151054] by jberlin@webkit.org
  • 8 edits in trunk/Source/WebKit2

Need the ability to get the information for a plug-in with a particular process id that may
be running on a page
https://bugs.webkit.org/show_bug.cgi?id=117090

Rubber-stamped by Anders Carlsson.

Follow-up to r151043 incorprating some feedback I got from Darin after I had already
committed the patch.

  • UIProcess/API/C/mac/WKPagePrivateMac.cpp:

(callGetPlugInInformationBlockAndDispose):
Renamed to be less wordy.
(WKPageGetPlugInInformation):
Ditto.

  • UIProcess/API/C/mac/WKPagePrivateMac.h:

Ditto.

  • UIProcess/Plugins/PluginProcessManager.h:
  • UIProcess/Plugins/mac/PluginProcessManagerMac.mm:

(WebKit::PluginProcessManager::findPlugInProcessByID):
Renamed to not use "Cocoa method style" in non-Cocoa functions.
(WebKit::PluginProcessManager::findPlugInProcessByToken):
Ditto.

  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::getPlugInInformation):
Reduce ref count churn and fix a variable name.
Updated for the change to findPlugInProcessByID.
(WebKit::WebPageProxy::containsPlugInCallback):
Updated for the change to findPlugInProcessByToken.

  • WebProcess/Plugins/PDF/SimplePDFPlugin.h:

Move the override of a virtual function to the private section.

4:32 PM Changeset in webkit [151053] by fpizlo@apple.com
  • 14 edits in branches/dfgFourthTier/LayoutTests

fourthTier: convert more fast/js/dfg-* tests to wait for the concurrent JIT

Rubber stamped by Mark Hahnenberg.

  • fast/js/dfg-arguments-alias-one-block-overwrite-expected.txt:
  • fast/js/dfg-arguments-out-of-bounds-expected.txt:
  • fast/js/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int-expected.txt:
  • fast/js/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers-expected.txt:
  • fast/js/dfg-array-length-dead-expected.txt:
  • fast/js/dfg-array-pop-side-effects-expected.txt:
  • fast/js/resources/js-test-pre.js:

(testFailed):
(dfgIncrement):
(isSuccessfullyParsed):

  • fast/js/script-tests/dfg-arguments-alias-one-block-overwrite.js:
  • fast/js/script-tests/dfg-arguments-out-of-bounds.js:
  • fast/js/script-tests/dfg-arith-add-overflow-check-elimination-predicted-but-not-proven-int.js:
  • fast/js/script-tests/dfg-arith-add-overflow-check-elimination-tower-of-large-numbers.js:
  • fast/js/script-tests/dfg-array-length-dead.js:
  • fast/js/script-tests/dfg-array-pop-side-effects.js:
4:13 PM Changeset in webkit [151052] by fpizlo@apple.com
  • 1 edit in branches/dfgFourthTier/Source/JavaScriptCore/ChangeLog

Fix ChangeLog. That revision was no longer a work in progress.

3:49 PM Changeset in webkit [151051] by Lucas Forschler
  • 9 edits in branches/safari-537.43-branch/Source

Merged r151040. <rdar://problem/14027095>

3:47 PM Changeset in webkit [151050] by Lucas Forschler
  • 9 edits in branches/safari-537.43-branch/Source

Rollout of r151048.

3:32 PM Changeset in webkit [151049] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

<rdar://problem/14036464> Sandbox violation when using Web SpeechSynthesis

Reviewed by Anders Carlsson

  • WebProcess/com.apple.WebProcess.sb.in: Allow com.apple.speech.synthesis.console.
3:23 PM Changeset in webkit [151048] by Lucas Forschler
  • 9 edits in branches/safari-537.43-branch/Source

Merged r51945. <rdar://problem/14027095>

3:14 PM Changeset in webkit [151047] by Brent Fulgham
  • 3 edits in trunk/Tools

[Windows] Use WinLauncher to display LayoutTest results
https://bugs.webkit.org/show_bug.cgi?id=117085

Reviewed by Oliver Hunt.

  • Scripts/webkitdirs.pm:

(runSafari): Use WinLauncher to display content

  • WinLauncher/WinLauncher.cpp:

(dllLauncherEntryPoint): Check for URL argument.

3:13 PM Changeset in webkit [151046] by Lucas Forschler
  • 2 edits in branches/safari-537.43-branch/Source/WebCore

Merged r151042. <rdar://problem/13812355>

3:08 PM Changeset in webkit [151045] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Incorrect assertion in DFG::Graph::uncheckedActivationRegisterFor()
<rdar://problem/13989324>

Rubber stamped by Mark Hahnenberg.

This has a bogus assertion that checks that the passed CodeOrigin doesn't have
an inline call frame. This was well intentioned in the sense that it is true
that inlined call frames wouldn't have an activation register. But that doesn't
mean that people won't ask. Removing the assertion fixes a debug-only crash and
has no impact on production code. This change adds a comment to that effect.

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::uncheckedActivationRegisterFor):

3:01 PM Changeset in webkit [151044] by roger_fong@apple.com
  • 4 edits in trunk

Unreviewed. Modify AssembleBuildLogs project to WebKit solution in preparation for moving buildbots to VCExpress 2010.
Add it to the WebKit solution as well.

  • win/AssembleBuildLogs/AssembleLogs.cmd:
2:59 PM Changeset in webkit [151043] by jberlin@webkit.org
  • 17 edits in trunk/Source/WebKit2

Need the ability to get the information for a plug-in with a particular process id that may
be running on a page
https://bugs.webkit.org/show_bug.cgi?id=117090

Reviewed by Anders Carlsson.

  • UIProcess/API/C/mac/WKPagePrivateMac.cpp:

(callGetInformationForPlugInWithProcessIDBlockAndDispose):
Get the block from the context, invoke it with the result, and dispose of it.
(WKPageGetInformationForPlugInWithProcessID):
Ask the WebPageProxy and provide it with a dictionary callback that uses the
above function to invoke the passed in block.

  • UIProcess/API/C/mac/WKPagePrivateMac.h:

Add WKPageGetInformationForPlugInWithProcessID and a typedef for the callback block.

  • UIProcess/Plugins/PluginProcessManager.h:

Add ways to get the PluginProcessProxy associated with a process id or process token.

  • UIProcess/Plugins/mac/PluginProcessManagerMac.mm:

(WebKit::PluginProcessManager::plugInProcessWithProcessID):
Return the first PluginProcessProxy with the passed in process ID.
(WebKit::PluginProcessManager::plugInProcessWithToken):
Return the first PluginProcessProxy with the passed in process token.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::close):
Invalidate any outstanding requests for plug-in information.

  • UIProcess/WebPageProxy.h:

Keep track of the callbacks for the requests for plug-in information.

  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::getInformationForPlugInWithProcessID):
If there are no known plug-ins with the provided process ID, invoke the callback with a null
dictionary of plug-in information.
Otherwise, keep track of the callback and send a message to the web process asking for the
information.
(WebKit::WebPageProxy::containsPlugInCallback):
If the page did not contain the plug-in, invoke the callback with a null dictionary of
plug-in information.
Invoke the callback with a dictionary containing the PlugInModuleInfo.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

Return 0 for the plugInProcessToken.

  • WebProcess/Plugins/PDF/SimplePDFPlugin.h:

Ditto.

  • WebProcess/Plugins/Plugin.h:

Add a pure virtual method for plugInProcessToken so it can be accessed from from the Plugin
on the PluginView.

  • WebProcess/Plugins/PluginProxy.h:

Return the actual plug-in process token.

  • WebProcess/Plugins/PluginView.h:

(WebKit::PluginView::plugIn):
Make it possible to get at the plug-in process token through the Plugin.

  • WebProcess/WebPage/WebPageMac.mm:

(WebKit::WebPage::containsPluginViewsWithPluginProcessToken):
If there is an instance of the plug-in with that token, send a confirmation to the ui
process.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
2:55 PM Changeset in webkit [151042] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Take the normal NSView code path when drawing into an inclusive layer
https://bugs.webkit.org/show_bug.cgi?id=117094
<rdar://problem/13812355>

Reviewed by Sam Weinig.

For now, take the normal code path when drawing into an inclusive layer.

  • platform/mac/WidgetMac.mm:

(WebCore::Widget::paint):

2:48 PM Changeset in webkit [151041] by fpizlo@apple.com
  • 4 edits in branches/dfgFourthTier/Source/JavaScriptCore

Remove CodeOrigin::valueProfileOffset since it was only needed for op_call_put_result.

Rubber stamped by Mark Hahnenberg.

  • bytecode/CodeOrigin.h:

(CodeOrigin):
(JSC::CodeOrigin::CodeOrigin):
(JSC::CodeOrigin::isSet):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::currentCodeOrigin):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::valueProfileFor):

2:44 PM Changeset in webkit [151040] by slewis@apple.com
  • 9 edits in trunk/Source

Source/WebCore: Update low memory handler to use new memory pressure notifications on new OS versions.
<rdar://problem/14027095>

Reviewed by Mark Rowe.

No change in functionality.

  • WebCore.exp.in:
  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::install): Call new API

  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac: Update low memory handler to use new memory pressure notifications on new OS versions.
<rdar://problem/14027095>

Reviewed by Mark Rowe.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

Source/WebKit2: Update low memory handler to use new memory pressure notifications on new OS versions.
<rdar://problem/14027095>

Reviewed by Mark Rowe.

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

2:40 PM Changeset in webkit [151039] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/JavaScriptCore

Remove finalDestinationOrIgnored since it isn't called anymore.

Rubber stamped by Mark Hahnenberg.

  • bytecompiler/BytecodeGenerator.h:

(BytecodeGenerator):

2:37 PM Changeset in webkit [151038] by fpizlo@apple.com
  • 20 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: get rid of op_call_put_result
https://bugs.webkit.org/show_bug.cgi?id=117047

Reviewed by Gavin Barraclough.

Work in progress. This still makes like 20 tests crash.

op_call_put_result is an oddball. Its semantics are that it takes the return
value of a call instruction, which is set aside in regT0/regT1, and places them
into some stack slot. This is weird since there is an implicit contract with the
preceding bytecode instruction, and it's even weirder since it means that it
doesn't make sense to jump to it; for example OSR exit from the preceding call
instruction must make sure to jump over the op_call_put_result.

So this patch gets rid of op_call_put_result:

  • In bytecode, all calls return a value and we always allocate a temporary for that value even if it isn't used.


  • The LLInt does the return value saving as part of dispatchAfterCall().


  • The JIT and DFG do the return value saving as part of normal code generation. The DFG already did the right thing.


  • DFG->JIT OSR exit in the case of inlining will make the return PC's point at the CallLinkInfo::callReturnLocation, rather than the machine PC associated with the op_call_put_result instruction.


  • Tons of code gets removed. The DFG had to track whether or not a call had a return value in a bunch of places. It had to track the fact that we would exit to after the op_call_put_result. It was a mess. That mess is now gone.
  • bytecode/CallLinkStatus.cpp:

(JSC::CallLinkStatus::computeFromLLInt):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::printCallOp):
(JSC::CodeBlock::dumpArrayProfiling):
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:
  • bytecode/Opcode.h:

(JSC):
(JSC::padOpcodeName):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitConstruct):

  • bytecompiler/NodesCodegen.cpp:

(JSC::NewExprNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::FunctionCallDotNode::emitBytecode):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::ByteCodeParser):
(ByteCodeParser):
(JSC::DFG::ByteCodeParser::currentCodeOrigin):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::getPredictionWithoutOSRExit):
(JSC::DFG::ByteCodeParser::getPrediction):
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::reifyInlinedCallFrames):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:

(JIT):

  • jit/JITCall.cpp:

(JSC::JIT::emitPutCallResult):
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::emit_op_call):
(JSC):
(JSC::JIT::emit_op_call_eval):
(JSC::JIT::emit_op_call_varargs):
(JSC::JIT::emit_op_construct):
(JSC::JIT::emitSlow_op_call):
(JSC::JIT::emitSlow_op_call_eval):
(JSC::JIT::emitSlow_op_call_varargs):
(JSC::JIT::emitSlow_op_construct):

  • jit/JITCall32_64.cpp:

(JSC::JIT::emitPutCallResult):
(JSC::JIT::compileLoadVarargs):
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):

  • jit/JITOpcodes.cpp:

(JSC):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::genericCall):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
1:44 PM Changeset in webkit [151037] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Update Button UX.
https://bugs.webkit.org/show_bug.cgi?id=116992

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-05-31
Reviewed by Rob Buis.

BlackBerry PR 342298.
Internally Review by Jeff Rogers.

  • css/themeBlackBerry.css:
1:27 PM Changeset in webkit [151036] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

DerivedSources.make: any rules that use $(FEATURE_DEFINES) should be rebuilt when FeatureDefines.xcconfig changes
<http://webkit.org/b/117081>

Reviewed by Mark Rowe.

  • DerivedSources.make: Add $(PLATFORM_FEATURE_DEFINES)

dependency for all rules that use $(FEATURE_DEFINES) to generate
files.
(PLATFORM_FEATURE_DEFINES): Set this variable to
Configurations/FeatureDefines.xcconfig if not already set on
Mac OS X.

1:16 PM Changeset in webkit [151035] by ap@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r141445): MPEG-4 videos do not play on certain hardware configurations
https://bugs.webkit.org/show_bug.cgi?id=117089
<rdar://problem/13839717>

Reviewed by Mark Rowe.

  • Configurations/WebContentProcess.xcconfig: Statically link to a framework that uses an XPC service to work around a libxpc limitation on Lion.
12:08 PM Changeset in webkit [151034] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Text Field UX updates.
https://bugs.webkit.org/show_bug.cgi?id=116996

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-05-31
Reviewed by Rob Buis.

BlackBerry PR 342333.
Internally Reviewed by Jeff Rogers.

Update disabled text field font color.

  • css/themeBlackBerry.css:
11:22 AM Changeset in webkit [151033] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[sh4] Fix Overflow case of branchMul32 in baseline JIT.
https://bugs.webkit.org/show_bug.cgi?id=117057

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-31
Reviewed by Oliver Hunt.

Current implementation of Overflow case in branchMul32 performs an
unsigned multiplication whereas a signed multiplication is expected.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branchMul32):

11:22 AM Changeset in webkit [151032] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[sh4] Fix floating point comparisons in baseline JIT.
https://bugs.webkit.org/show_bug.cgi?id=117066.

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-31
Reviewed by Oliver Hunt.

Current implementation of branchDouble function in baseline JIT is wrong
for some conditions and overkill for others. For instance:

  • With DoubleGreaterThanOrEqual condition, branch will be taken if either operand is NaN with current implementation whereras it should not.
  • With DoubleNotEqualOrUnordered condition, performed NaN checks are useless (because comparison result is false if either operand is NaN).
  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branchDouble):

11:21 AM Changeset in webkit [151031] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[sh4] Fix double floating point transfer in baseline JIT.
https://bugs.webkit.org/show_bug.cgi?id=117054

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-31
Reviewed by Oliver Hunt.

In current implementation, dmovRegReg function transfers only one single
FPRegister as PR=1 and SZ=0 in floating point status/control register.
Double transfers must be performed with two fmov.s opcodes.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::moveDouble):
(JSC::MacroAssemblerSH4::addDouble): Handle (op2==dest) case properly.
(JSC::MacroAssemblerSH4::sqrtDouble):

  • assembler/SH4Assembler.h:

(JSC::SH4Assembler::fmovsRegReg):

11:19 AM Changeset in webkit [151030] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[sh4] Handle branchType properly in branchTruncateDoubleToInt32.
https://bugs.webkit.org/show_bug.cgi?id=117062

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-31
Reviewed by Oliver Hunt.

Current implementation of branchTruncateDoubleToInt32 is incorrect
when branchType == BranchIfTruncateSuccessful in sh4 baseline JIT.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::branchTruncateDoubleToInt32):

10:45 AM Changeset in webkit [151029] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Update CheckedInt.h to latest version from Mozilla
https://bugs.webkit.org/show_bug.cgi?id=117009

Reviewed by Darin Adler.

Mozilla have updated their version of CheckedInt and suggested
we sync. Here are the improvements:

  • CheckedInt now consistently rejects unsupported types. Before, you

could sometimes construct a CheckedInt from an unsupported type (like,
float) or multiply a CheckedInt by a float, and have it not caught! See
https://bugzilla.mozilla.org/show_bug.cgi?id=869194

  • Fixed a possibility of undefined behavior in unary operator-. See bug

https://bugzilla.mozilla.org/show_bug.cgi?id=849666

  • CheckedInt now supports the "long long" and "unsigned long long"

types. We don't like "long long" (and neither does the Google C++ style
guide!) but we had to do that because libogg exposes typedefs to those
types. See Bug https://bugzilla.mozilla.org/show_bug.cgi?id=869685

  • CheckedInt also now supports "signed char" in addition to "char" ---

they are not the same type! See Bug https://bugzilla.mozilla.org/show_bug.cgi?id=847521

  • Fixed and simplified usage of CheckedInt outside of Mozilla. You'll

like this one! See Bug https://bugzilla.mozilla.org/show_bug.cgi?id=849667

  • html/canvas/CheckedInt.h: Updated.
10:29 AM Changeset in webkit [151028] by Lucas Forschler
  • 2 edits in branches/safari-537.43-branch/Source/WebKit2

Merged r151026. <rdar://problem/14030364>

10:27 AM Changeset in webkit [151027] by Lucas Forschler
  • 2 edits in branches/safari-537.43-branch/Source/WebCore

Merged r150836. <rdar://problem/13925131>

10:04 AM Changeset in webkit [151026] by dino@apple.com
  • 2 edits in trunk/Source/WebKit2

Don't create an accelerated compositing layer unless we have to for snapshotting plug-ins
https://bugs.webkit.org/show_bug.cgi?id=117076
<rdar://problem/14030364>

Reviewed by Beth Dakin and Anders Carlsson.

If a plug-in can support software snapshotting, then don't create an
accelerated compositing layer for it while in snapshot mode. This is a
better user experience -- otherwise the page/plug-in looks like it broke.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::isAcceleratedCompositingEnabled): If we are in snapshotting mode
and we are a Flash plugin (the only one that supports software snapshots at the moment)
then do not create an accelerated compositing layer.

10:02 AM Changeset in webkit [151025] by Brent Fulgham
  • 2 edits in trunk/Source/JavaScriptCore

[Windows] Unreviewed build fix for VS2005 builders.

missing export for WTF::SHA1::computeHexDigest

9:57 AM Changeset in webkit [151024] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r151022.
http://trac.webkit.org/changeset/151022
https://bugs.webkit.org/show_bug.cgi?id=117084

Also breaks build by introducing duplicate symbols (Requested
by bfulgham on #webkit).

  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops:
9:54 AM WebKitGTK/2.0.x edited by kalevlember@gmail.com
Link to changesets instead of bugzilla, for two issues where fixes … (diff)
9:45 AM Changeset in webkit [151023] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] Unreviewed build fix to NRWT

  • Scripts/webkitpy/port/win.py:

(WinPort.create_debugger_command_file): Use proper argument for _filesystem.write_text_file.

9:31 AM Changeset in webkit [151022] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] Unreviewed build fix after r151012

  • TestWebKitAPI/Configurations/TestWebKitAPICommon.vsprops: Add dependency on

WTF library to support SHA tests

9:17 AM Changeset in webkit [151021] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Make sure gstreamer source element is thread-safe
https://bugs.webkit.org/show_bug.cgi?id=115352

Patch by Andre Moreira Magalhaes <Andre Moreira Magalhaes> on 2013-05-31
Reviewed by Philippe Normand.

GStreamer source element may be created by any gstreamer element on any thread by calling
gst_element_make_from_uri with the URIs handled by the source element.
This patch makes sure the gstreamer source element is thread-safe to avoid issues with it
being created outside the main thread.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(_WebKitWebSrcPrivate):
(webkit_web_src_init):
(webKitWebSrcFinalize):
(webKitWebSrcSetProperty):
(webKitWebSrcGetProperty):
(webKitWebSrcStop):
(webKitWebSrcStart):
(webKitWebSrcChangeState):
(webKitWebSrcQueryWithParent):
(webKitWebSrcGetUri):
(webKitWebSrcSetUri):
(webKitWebSrcNeedDataMainCb):
(webKitWebSrcEnoughDataMainCb):
(webKitWebSrcSeekMainCb):
(webKitWebSrcSeekDataCb):
(webKitWebSrcSetMediaPlayer):
(StreamingClient::StreamingClient):
(StreamingClient::~StreamingClient):
(StreamingClient::didReceiveResponse):
(StreamingClient::didReceiveData):
(StreamingClient::didFinishLoading):
(StreamingClient::wasBlocked):
(StreamingClient::cannotShowURL):

9:16 AM Changeset in webkit [151020] by rafael.lobo@openbossa.org
  • 2 edits in trunk/Source/WTF

Fix double hash lookup in PageMapMemoryUsageRecorder::visit
https://bugs.webkit.org/show_bug.cgi?id=117071

Reviewed by Andreas Kling.

  • wtf/FastMalloc.cpp:

(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

9:14 AM Changeset in webkit [151019] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] Unreviewed build fix after r151012

  • TestWebKitAPI/Tests/WTF/MD5.cpp: Include <wtf/StringExtras.h> to provide

snprintf definition for Windows.

9:01 AM Changeset in webkit [151018] by Brent Fulgham
  • 2 edits in trunk/Source/WTF

[Windows] Speculative build fix for pre-VS2010 compilers

  • wtf/Platform.h: Only treat WTF as DLL for VS2010 builds
8:53 AM Changeset in webkit [151017] by jer.noble@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Update test-expectations after r151000.

  • fast/js/date-DST-time-cusps-expected.txt:
8:52 AM Changeset in webkit [151016] by sergio@webkit.org
  • 2 edits in trunk/Source/WebCore

Build fix when CSSParser debugging is enabled
https://bugs.webkit.org/show_bug.cgi?id=117075

Reviewed by Andreas Kling.

Build fails when enabling parser debugging by setting YYDEBUG to
1 because of a missing include.

  • css/CSSGrammar.y.includes:
8:21 AM Changeset in webkit [151015] by eustas@chromium.org
  • 2 edits in trunk/LayoutTests

[Qt][WK2] Newly added editing/selection/caret-after-keypress.html crashing
https://bugs.webkit.org/show_bug.cgi?id=117070

Unreviewed test expectations update.

WebKitTestRunner needs a more-complete implementation of eventSender.
Until then caret-after-keypress test is disabled

See https://bugs.webkit.org/show_bug.cgi?id=42194

  • platform/qt-5.0-wk2/TestExpectations:
6:29 AM Changeset in webkit [151014] by zarvai@inf.u-szeged.hu
  • 3 edits
    1 add in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk1/TestExpectations: Skip flaky test.
  • platform/qt-5.0-wk2/TestExpectations: Skip crashing test.
  • platform/qt/fast/js/date-DST-time-cusps-expected.txt: Rebaselining after r151000.
3:25 AM Changeset in webkit [151013] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Soup] [Gstreamer] ASSERT in StreamingClient::getOrCreateReadBuffer
https://bugs.webkit.org/show_bug.cgi?id=116686

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-31
Reviewed by Carlos Garcia Campos.

We were using g_input_stream_read_async() to handle redirections
because of Gnome bug #691489.

This produces an unexpected read attempt which triggers an assert
in StreamingClient::getOrCreateReadBuffer().

Now that the Gnome bug is fixed we can replace read_async() with
skip_async().

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::ResourceHandle::ensureReadBuffer):
(WebCore::redirectSkipCallback):
(WebCore::sendRequestCallback):

3:06 AM Changeset in webkit [151012] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

Move MD5, SHA1 unit tests from WTF to TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=116445

Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-05-31
Reviewed by Benjamin Poulain.

Source/WTF:

Remove the MD5 and SHA1 test cases from the WTF code. The same cases are now built and run under TestWebKitAPI.

  • wtf/MD5.cpp:

(WTF::MD5::MD5):

  • wtf/SHA1.cpp:

(WTF::SHA1::SHA1):

Tools:

Add the MD5 and SHA1 unit tests that were previously located inside WTF.

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/GNUmakefile.am:
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/MD5.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::expectMD5):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/SHA1.cpp: Added.

(TestWebKitAPI):
(TestWebKitAPI::expectSHA1):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/WTF.pro:
  • TestWebKitAPI/win/TestWebKitAPI.vcproj:
1:58 AM Changeset in webkit [151011] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Update EFL TextExpectation for WebAudio cases.
https://bugs.webkit.org/show_bug.cgi?id=117061.

Unreviewed EFL Gardening.

WebAudio test cases delaynode-max-nondefault-delay.html, delaynode-scheduling.html
and javascriptaudionode.html pass with latest updates in efl port. Updating
TestExpectation accordingly.

Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-05-31

  • platform/efl/TestExpectations:
12:15 AM Changeset in webkit [151010] by noel.gordon@gmail.com
  • 2 edits in trunk/LayoutTests

[Mac] Should pass http/tests/images/png-partial-load-no-alpha.html
https://bugs.webkit.org/show_bug.cgi?id=97170

Unreviewed test expectations update.

  • platform/mac/TestExpectations: Passing after r150340: remove the

Mac-specfic [ImageOnlyFailure] for this test.

May 30, 2013:

10:14 PM Changeset in webkit [151009] by eustas@chromium.org
  • 4 edits
    2 adds in trunk

selectionStart/selectionEnd return "obsolete" values when requested during "input" event
https://bugs.webkit.org/show_bug.cgi?id=110742

Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch defers firing "webkitEditableContentChanged" until new
selection is applied to control. This makes selection during "input"
more consistent and reliable.

Background: "input" event is fired by "webkitEditableContentChanged"
dispatcher. But "input" is scoped event, so under some conditions its
dispatching may be deferred. When "input" dispatching is deferred,
dispatcher observes updated selectionStart and selectionEnd.
Otherwise values repersent state before applying editing command.

So, to make selectionStart/End to be more predictable and useful, we
need either always dispatch "input" before selection is updated, or
always dispatch "input" after selection is updated.

As it was mentioned, dispatching could be deferred by scoping. So
dispatching before updating selection couldn't be guaranteed.
Moreover, it will be hard to calculate updated selection in user
code. On the other side - old selection could be easily tracked.

So, it looks logically that we should guarantee dispatching "input"
after updating selection. There are no execution paths in
"webkitEditableContentChanged" dispatched that depends on current
selection. So it is safe to fire this event after selection is updated.

Test: editing/selection/caret-after-keypress.html

  • editing/Editor.cpp:

Dispatch "input" event after new selection in applied.

LayoutTests:

Test that cursor is up-to-date during "input" event.

  • editing/selection/caret-after-keypress-expected.txt: Added.
  • editing/selection/caret-after-keypress.html: Added.
  • platform/mac-wk2/TestExpectations: Exclude new test.
9:53 PM Changeset in webkit [151008] by Lucas Forschler
  • 4 edits in branches/safari-537.43-branch/Source

Versioning.

9:51 PM Changeset in webkit [151007] by Lucas Forschler
  • 1 copy in tags/Safari-537.43.5

New Tag.

9:32 PM Changeset in webkit [151006] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/LayoutTests

Unreviewed, EFL gardening.

Some of tests in printing are passing on EFL WK2. But, they are still failing on EFL WK1.

  • platform/efl/TestExpectations:
8:59 PM Changeset in webkit [151005] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] Unreviewed build correction.

  • Scripts/webkitpy/port/win.py:

(WinPort.create_debugger_command_file): The directory needs to be
a string, not a temporary directory object.

8:31 PM Changeset in webkit [151004] by Brent Fulgham
  • 2 edits in trunk/Tools

[Windows] NRWT doesn't save crash logs on Apple's Windows port.
https://bugs.webkit.org/show_bug.cgi?id=76935

Reviewed by Ryosuke Niwa.

Extend the WinPort class with commands to set and clean up various registry
values needed to invoke the correct debugger to get crash files.

  • Scripts/webkitpy/port/win.py:

(WinPort): Added global caches for registry keys and settings
(WinPort._ntsd_location): Added
(WinPort.create_debugger_command_file): Added
(WinPort.read_registry_string): Added
(WinPort.write_registry_string): Added
(WinPort.setup_crash_log_saving): Added
(WinPort.restore_crash_log_saving): Added
(WinPort.setup_test_run): Added overload to add registry settings.
(WinPort.clean_up_test_run): Added overload to clean up registry settings.

7:32 PM Changeset in webkit [151003] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

WebKit's Enter Full Screen for <video> elements isn't working
https://bugs.webkit.org/show_bug.cgi?id=117001

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-05-30
Reviewed by Jer Noble.

Fix workflow to allow a video to enter into full screen
mode from a kWKContextMenuItemTagEnterVideoFullscreen
context menu item by denoting the enterFullscreenForVideo
call as a user gesture, so Document::requestFullScreenForElement
will execute correctly.

No new tests. Covered by media/context-menu-actions.html,
which is disabled due to bug #116651.

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::enterFullscreenForVideo):

7:30 PM Changeset in webkit [151002] by Lucas Forschler
  • 24 edits
    2 deletes in branches/safari-537.43-branch/Source

Rollout of r150981. <rdar://problem/13785764>

7:05 PM Changeset in webkit [151001] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

It's easy to hit ASSERT_NOT_REACHED in WKDOMNodeClass
https://bugs.webkit.org/show_bug.cgi?id=117051

Reviewed by Anders Carlsson.

Re-add the ASSERT_NOT_REACHED, and return [WKDOMNode class] in the case
where we don't have a specific subclass.

  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:

(WebKit::WKDOMNodeClass):

6:52 PM Changeset in webkit [151000] by barraclough@apple.com
  • 3 edits in trunk/LayoutTests

fast/js/date-DST-time-cusps.html fails after http://trac.webkit.org/changeset/150833
https://bugs.webkit.org/show_bug.cgi?id=116895
<rdar://problem/4777813> Safari incorrectly handles times that shouldn't exist
https://bugs.webkit.org/show_bug.cgi?id=11157

Reviewed by Alexey Proskuryakov.

Accidental progression, updating results to expect success.

  • TestExpectations:
    • Remove expectations of failure.
  • fast/js/script-tests/date-DST-time-cusps.js:
    • Prefer the latter option for non-existent time (due to clock rolling forward).
6:52 PM Changeset in webkit [150999] by roger_fong@apple.com
  • 2 edits in trunk/Source/WTF

Another unreviewed speculative build fix for Mac.

  • wtf/text/WTFString.h:

(WTF::String::fromUTF8WithLatin1Fallback):

6:46 PM Changeset in webkit [150998] by dfarler@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix jscore-test when not using --sdk option with jsDriver.pl
https://bugs.webkit.org/show_bug.cgi?id=116339

Reviewed by Joe Pecoraro.

  • tests/mozilla/jsDriver.pl:

(execute_tests):
With each test, the shell_command needs to be started from scratch.

This fix will clear the shell_command and start over as before with
the opt_arch option when not using --sdk with jsDriver.pl.

6:09 PM WebKitEFLLayoutTest edited by gyuyoung.kim@samsung.com
(diff)
6:07 PM Changeset in webkit [150997] by roger_fong@apple.com
  • 3 edits in trunk/Source/WTF

Unreviewed build fix for Mac.

  • wtf/OSAllocator.h:
  • wtf/text/WTFString.h:

(WTF::String::fromUTF8):

5:53 PM Changeset in webkit [150996] by rafael.lobo@openbossa.org
  • 2 edits in trunk/Source/WebCore

Fix double hash lookup in RenderTableSection::paintObject loop
https://bugs.webkit.org/show_bug.cgi?id=117055

Reviewed by Antonio Gomes.

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::paintObject):

5:38 PM Changeset in webkit [150995] by roger_fong@apple.com
  • 35 edits
    1 delete in trunk

Get rid of JavaScript exports file on AppleWin port.
https://bugs.webkit.org/show_bug.cgi?id=117050.

Reviewed by Darin Adler.

This requires turning WTF into a shared library and adding the WTF_EXPORT_PRIVATE to some methods where it was missed.
Start linking in WTF.lib now that it's a shared library.
Also, delete the JavaScriptCoreExportGenerator folder and remove dependencies.

  • JavaScriptCore.vcxproj/JavaScriptCore.submit.sln:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.filters: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorBuildCmd.cmd: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorCommon.props: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorDebug.props: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPostBuild.cmd: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorPreBuild.cmd: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorProduction.props: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGeneratorRelease.props: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in: Removed.
  • JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/make-export-file-generator: Removed.
  • JavaScriptCore.vcxproj/jsc/jscCommon.props:
  • JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj:
  • JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj.filters:
  • JavaScriptCore.vcxproj/testRegExp/testRegExpCommon.props:
  • JavaScriptCore.vcxproj/testapi/testapiCommon.props:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTFCommon.props:
  • wtf/DateMath.h:
  • wtf/ExportMacros.h:
  • wtf/FilePrintStream.h:
  • wtf/OSAllocator.h:
  • wtf/PageAllocationAligned.h:
  • wtf/Platform.h:
  • wtf/PrintStream.h:
  • wtf/StackBounds.h:
  • wtf/StringPrintStream.h:
  • wtf/ThreadSpecific.h:
  • wtf/WTFThreadData.h:
  • wtf/dtoa/cached-powers.h:
  • wtf/dtoa/double-conversion.h:
  • wtf/text/WTFString.h:
  • wtf/unicode/Collator.h:
  • wtf/unicode/UTF8.h:
  • WebKit.vcxproj/WebKit.sln:
  • WebKit.vcxproj/WebKit/WebKitCommon.props:
  • DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props:
  • DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props:
  • TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPICommon.props:
5:16 PM Changeset in webkit [150994] by dfarler@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add --sdk option to jsDriver.pl to run with iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=116339

Reviewed by David Kilzer.

  • tests/mozilla/jsDriver.pl:

(execute_tests):
Prefix shell command with the path to the "sim" tool.
(parse_args):
Add -d / --sdk option.
(usage):
Help message for -d / --sdk option.

4:29 PM Changeset in webkit [150993] by fpizlo@apple.com
  • 11 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: LLInt shouldn't store an offset call PC during op_call-like calls
https://bugs.webkit.org/show_bug.cgi?id=117048

Reviewed by Mark Hahnenberg.

This just makes everything consistent in the LLInt: anytime any op calls out,
it stores its PC and never the next op's PC.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::linkIncomingCall):
(JSC::CodeBlock::bytecodeOffset):

  • bytecode/CodeBlock.h:
  • bytecode/Opcode.h:

(JSC::padOpcodeName):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitCallVarargs):

  • llint/LLIntExceptions.cpp:

(JSC::LLInt::interpreterThrowInCaller):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter.cpp:

(JSC::CLoop::execute):

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
4:21 PM Changeset in webkit [150992] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[sh4] Optimize NaN checks in LLINT for floating point comparisons.
https://bugs.webkit.org/show_bug.cgi?id=117049

Patch by Julien Brianceau <jbrianceau@nds.com> on 2013-05-30
Reviewed by Oliver Hunt.

Use the fcmp/eq opcode in sh4 LLINT to test if a double is NaN.
This is more efficient, doesn't require two tmp registers and requires
less code than current implementation (which converts double to float,
then checks 'E = Emax + 1' and 'f != 0').

  • offlineasm/sh4.rb:
4:15 PM WebKitGTK/2.0.x edited by kov@webkit.org
as translation update (diff)
4:15 PM Changeset in webkit [150991] by rafael.lobo@openbossa.org
  • 2 edits in trunk/Source/WebCore

Fix double hash lookup in WebSocket::connect loop
https://bugs.webkit.org/show_bug.cgi?id=117052

Reviewed by Anders Carlsson.

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):

3:58 PM Changeset in webkit [150990] by oliver@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

JSCallbackObject does not correctly initialise the PropertySlot for getOwnPropertyDescriptor
https://bugs.webkit.org/show_bug.cgi?id=117053

Reviewed by Mark Hahnenberg.

Set appropriate thisValue on the PropertySlot

  • API/JSCallbackObjectFunctions.h:

(JSC::::getOwnPropertyDescriptor):

  • API/tests/testapi.mm:
3:55 PM Changeset in webkit [150989] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove ASSERT_NOT_REACHED from WKDOMNodeClass
https://bugs.webkit.org/show_bug.cgi?id=117051

Reviewed by Anders Carlsson.

It's easy to fail this assertion in seemingly-legitimate cases.

  • WebProcess/InjectedBundle/API/mac/WKDOMInternals.mm:

(WebKit::WKDOMNodeClass):

3:47 PM Changeset in webkit [150988] by kov@webkit.org
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[GTK] Updated as-IN translations
https://bugs.webkit.org/show_bug.cgi?id=116953

Patch by Nilamdyuti Goswami <ngoswami@redhat.com> on 2013-05-30
Reviewed by Gustavo Noronha Silva (kov).

  • as.po: Updated.
2:31 PM Changeset in webkit [150987] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

fast/dom/location-new-window-no-crash.html times out flakily on mac-wk2
https://bugs.webkit.org/show_bug.cgi?id=117037

Reviewed by Alexey Proskuryakov.

Close the window on a zero-delay timer, working around a bug where WKTR
will hang if a window is closed while a load is in progress.

Doesn't affect the test in an important way.

  • fast/dom/script-tests/location-new-window-no-crash.js:
2:18 PM Changeset in webkit [150986] by Lucas Forschler
  • 5 edits in branches/safari-537.43-branch/Source/WebCore

Merged r150977. <rdar://problem/13916291>

2:15 PM Changeset in webkit [150985] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Remove some 16bits conversion.
https://bugs.webkit.org/show_bug.cgi?id=116935

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-05-30
Reviewed by Darin Adler.

Merge chromium ce35a544d09e6cb907457535340eb0e9984e57b8.
https://chromium.googlesource.com/chromium/blink/+/ce35a544d09e6cb907457535340eb0e9984e57b8

  • html/parser/InputStreamPreprocessor.h:
  • platform/FileSystem.cpp:

(WebCore::encodeForFileName):

2:11 PM Changeset in webkit [150984] by Lucas Forschler
  • 4 edits in branches/safari-537.43-branch/Source

Rollout of r150819. <rdar://problem/14025590>

2:08 PM Changeset in webkit [150983] by Lucas Forschler
  • 12 edits in branches/safari-537.43-branch/Source

Merged r150950. <rdar://problem/13992853>

2:03 PM Changeset in webkit [150982] by Lucas Forschler
  • 6 edits in branches/safari-537.43-branch/Source

Merged r150948. <rdar://problem/13886753>

2:00 PM Changeset in webkit [150981] by Lucas Forschler
  • 24 edits
    2 copies in branches/safari-537.43-branch/Source

Merged r150935. <rdar://problem/13785764>

1:55 PM Changeset in webkit [150980] by Lucas Forschler
  • 3 edits in branches/safari-537.43-branch/Source/JavaScriptCore

Merged r150831. <rdar://problem/14004998>

1:53 PM Changeset in webkit [150979] by Lucas Forschler
  • 2 edits in branches/safari-537.43-branch/Source/WebKit2

Merged r150925. <rdar://problem/13976781>

1:51 PM Changeset in webkit [150978] by Lucas Forschler
  • 2 edits in branches/safari-537.43-branch/Source/WebKit2

Merged r150648. <rdar://problem/13976781>

1:50 PM Changeset in webkit [150977] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

REGRESSION (r119759): Adobe Flash Player "smaller" installer relies on the incorrect firing of a load event and needs an app-specific hack for compatibility
https://bugs.webkit.org/show_bug.cgi?id=117042
<rdar://problem/13916291>

Reviewed by Mark Rowe.

Ignore HTTP errors for scripts requested from within the installer. Instead of just checking for the
Adobe Flash installer, we use the "com.solidstatenetworks.awkhost" bundle identifier to determine
whether to apply the workaround. This could in theory fix other installers that use the same mechanism.

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::shouldIgnoreHTTPStatusCodeErrors):

  • loader/cache/CachedScript.h:
  • platform/RuntimeApplicationChecks.cpp:

(WebCore::applicationIsSolidStateNetworksDownloader):

  • platform/RuntimeApplicationChecks.h:
1:39 PM Changeset in webkit [150976] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit/gtk

[GTK] Fix pass_by_value coverity warning in ChromeClientGtk
https://bugs.webkit.org/show_bug.cgi?id=117021

Patch by Enrique Ocana Gonzalez <eocanha@igalia.com> on 2013-05-30
Reviewed by Anders Carlsson.

Pass dirtyRegion parameter in paintWebView() by reference to avoid object copying.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::paintWebView):

12:21 PM Changeset in webkit [150975] by Lucas Forschler
  • 4 edits in branches/safari-537.43-branch/Source

Versioning.

12:18 PM Changeset in webkit [150974] by Lucas Forschler
  • 1 copy in tags/Safari-537.43.4

New Tag.

11:34 AM Changeset in webkit [150973] by zandobersek@gmail.com
  • 14 edits
    12 adds in trunk/LayoutTests

Update XMLHttpRequest timeout tests to a newer version from W3C
https://bugs.webkit.org/show_bug.cgi?id=117023

Reviewed by Alexey Proskuryakov.

The XMLHttpRequest Timeout tests have gone through a bit of restructuring and should
be updated. This is being primarily done because of the intention of updating the
testharness scripts which would break these tests if they were left not updated.

These tests were updated from the W3C web-platform-tests GitHub repository.
https://github.com/w3c/web-platform-tests

  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-aborted.js: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-abortedonmain.js: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overrides-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overrides.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overrides.js: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overridesexpires.js: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-runner.js:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-simple.js: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconmain.js: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-synconworker.js: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-twice.js: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-aborted.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overrides-expected.txt: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overrides.html: Added.
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overridesexpires.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-simple.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-synconworker.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-twice.html:
  • http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout.js:

(RequestTracker.prototype.startXHR):
(AbortedRequest.prototype.startXHR.handleEvent):
(runTestRequests):

11:20 AM Changeset in webkit [150972] by sergio@webkit.org
  • 6 edits in trunk

Allow no space between "background-position:" dimensions
https://bugs.webkit.org/show_bug.cgi?id=116870

Reviewed by Darin Adler.

From Blink r149314 by <ericwilligers@chromium.org>

Source/WebCore:

Specs allow no spaces between the dimensions of a
"background-position:" like "1px+1px", we should support
that.

Whitespaces are no longer early consumed, dramatically dropping
the shift/reduce conflicts to half. The productions unary_term,
calc_func_term, calc_func_expr and calc_func_paren_expr no longer
consume whitespaces.

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::realLex):

LayoutTests:

  • fast/backgrounds/background-position-parsing-2-expected.txt:
  • fast/backgrounds/background-position-parsing-2.html:
11:19 AM Changeset in webkit [150971] by jer.noble@apple.com
  • 14 edits
    2 copies in trunk/Source/WebCore

HTMLMediaElement will not unthrottle page when playback stops for nreasons other than user-initiated pause.
https://bugs.webkit.org/show_bug.cgi?id=117016

Reviewed by Oliver Hunt.

Add a new class PageActivityAssertionToken to allow HTMLMediaElement to decouple
knowledge of and control over the lifetime of PageThrottler. The new class will
have weak references to and from the PageThrottler so that holders of the token
will not need to care if the Page or PageThrottler has been destroyed.

HTMLMediaElement will create one of these PageActivityAssertionTokens when playback
begins and destroy it when playback stops for any reason, or when the element is
destroyed.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::pauseInternal):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::updatePlayState):

  • html/HTMLMediaElement.h:
  • page/Page.cpp:

(WebCore::createActivityToken): Added simple factory method.

  • page/Page.h:
  • page/PageActivityAssertionToken.cpp:

(WebCore::PageActivityAssertionToken::PageActivityAssertionToken): Call addActivityToken();
(WebCore::PageActivityAssertionToken::~PageActivityAssertionToken): Call removeActivityToken();
(WebCore::PageActivityAssertionToken::invalidate): Clear m_throttler.

  • page/PageActivityAssertionToken.h:
  • page/PageThrottler.cpp:

(WebCore::PageThrottler::~PageThrottler): Invalidate all outstanding tokens.
(WebCore::PageThrottler::addActivityToken): Bump the activity count.
(WebCore::PageThrottler::removeActivityToken): Lower the activity count.

  • page/PageThrottler.h:

Add the new files to the various build systems:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
10:52 AM Changeset in webkit [150970] by jpfau@apple.com
  • 12 edits in trunk

[Mac] Enable cache partitioning and the public suffix list on 10.8
<rdar://problem/13679019>

Rubber-stamped by David Kilzer.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

WebKitLibraries:

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMountainLion.a:
10:09 AM Changeset in webkit [150969] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Fix double hash lookup in DocumentEventQueue::cancelEvent().
<http://webkit.org/b/117031>

Reviewed by Anders Carlsson.

  • dom/DocumentEventQueue.cpp:

(WebCore::DocumentEventQueue::cancelEvent):

10:06 AM Changeset in webkit [150968] by akling@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix double hash lookup in WebPage::determinePrimarySnapshottedPlugIn() loop.
<http://webkit.org/b/117032>

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::determinePrimarySnapshottedPlugIn):

10:05 AM Changeset in webkit [150967] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Fix double hash lookup in DocumentLoader::removeSubresourceLoader().
<http://webkit.org/b/117030>

Reviewed by Anders Carlsson.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::removeSubresourceLoader):

10:03 AM Changeset in webkit [150966] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Fix double hash lookup in RenderView::repaintSelection() loop.
<http://webkit.org/b/117029>

Reviewed by Anders Carlsson.

  • rendering/RenderView.cpp:

(WebCore::RenderView::repaintSelection):

9:44 AM Changeset in webkit [150965] by zarvai@inf.u-szeged.hu
  • 4 edits
    5 adds in trunk/LayoutTests

[Qt] Unreviewed gardening.

  • platform/qt-5.0-wk1/TestExpectations: Skip new failures after r150868.
  • platform/qt-5.0-wk2/TestExpectations: re-skip still failing tests after r150892.
  • platform/qt-5.0-wk2/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.png: Rebaselining after r150798.
  • platform/qt-5.0-wk2/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Added.
  • platform/qt-5.0-wk2/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.png: Added.
  • platform/qt-5.0-wk2/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt: Added.
  • platform/qt/TestExpectations: Skip new failre after r150853.
8:12 AM Changeset in webkit [150964] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

CURL: Incorrect stripping of query from file URL
https://bugs.webkit.org/show_bug.cgi?id=104307

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-05-30
Reviewed by Darin Adler.

Clear the query part of the file URL if there is any.

  • platform/network/curl/ResourceHandleManager.cpp:

(WebCore::ResourceHandleManager::initializeHandle):

7:55 AM Changeset in webkit [150963] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] Needs to check for harfbuzz-icu
https://bugs.webkit.org/show_bug.cgi?id=116978

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-05-30
Reviewed by Xan Lopez.

HarfBuzz 0.9.18 splits harbuzz-icu into a separate library so we
also need to check for it in order to get the necessary flags for
the compiler and the linker.

We keep this conditional for now since we still want to support
earlier versions of HarfBuzz.

  • Source/autotools/FindDependencies.m4:
7:26 AM Changeset in webkit [150962] by Antti Koivisto
  • 10 edits
    2 adds in trunk/Source/WebCore

Separate generic font family settings to a class
https://bugs.webkit.org/show_bug.cgi?id=117027

Reviewed by Andreas Kling.

The new class is under platform/ and can be accessed by the font code directly without platform violations.

  • WebCore.xcodeproj/project.pbxproj:
  • page/Settings.cpp:

(WebCore::invalidateAfterGenericFamilyChange):
(WebCore::Settings::Settings):
(WebCore::Settings::~Settings):
(WebCore::Settings::create):
(WebCore::Settings::standardFontFamily):
(WebCore::Settings::setStandardFontFamily):
(WebCore::Settings::fixedFontFamily):
(WebCore::Settings::setFixedFontFamily):
(WebCore::Settings::serifFontFamily):
(WebCore::Settings::setSerifFontFamily):
(WebCore::Settings::sansSerifFontFamily):
(WebCore::Settings::setSansSerifFontFamily):
(WebCore::Settings::cursiveFontFamily):
(WebCore::Settings::setCursiveFontFamily):
(WebCore::Settings::fantasyFontFamily):
(WebCore::Settings::setFantasyFontFamily):
(WebCore::Settings::pictographFontFamily):
(WebCore::Settings::setPictographFontFamily):

  • page/Settings.h:
  • platform/graphics/FontGenericFamilies.cpp: Added.

(WebCore::setGenericFontFamilyForScript):
(WebCore::genericFontFamilyForScript):
(WebCore::FontGenericFamilies::FontGenericFamilies):
(WebCore::FontGenericFamilies::standardFontFamily):
(WebCore::FontGenericFamilies::fixedFontFamily):
(WebCore::FontGenericFamilies::serifFontFamily):
(WebCore::FontGenericFamilies::sansSerifFontFamily):
(WebCore::FontGenericFamilies::cursiveFontFamily):
(WebCore::FontGenericFamilies::fantasyFontFamily):
(WebCore::FontGenericFamilies::pictographFontFamily):
(WebCore::FontGenericFamilies::setStandardFontFamily):
(WebCore::FontGenericFamilies::setFixedFontFamily):
(WebCore::FontGenericFamilies::setSerifFontFamily):
(WebCore::FontGenericFamilies::setSansSerifFontFamily):
(WebCore::FontGenericFamilies::setCursiveFontFamily):
(WebCore::FontGenericFamilies::setFantasyFontFamily):
(WebCore::FontGenericFamilies::setPictographFontFamily):

  • platform/graphics/FontGenericFamilies.h: Added.

(WebCore::UScriptCodeHashTraits::emptyValue):
(WebCore::UScriptCodeHashTraits::constructDeletedValue):
(WebCore::UScriptCodeHashTraits::isDeletedValue):
(WebCore::FontGenericFamilies::create):

7:15 AM Changeset in webkit [150961] by zarvai@inf.u-szeged.hu
  • 91 edits
    43 copies
    483 adds in trunk/LayoutTests

[Qt][WK2] Unreviewed expected pixel result rebaselining after r150798.

  • platform/qt-5.0-wk2/compositing/checkerboard-expected.png:
  • platform/qt-5.0-wk2/compositing/culling/filter-occlusion-blur-large-expected.png:
  • platform/qt-5.0-wk2/compositing/direct-image-compositing-expected.png:
  • platform/qt-5.0-wk2/compositing/geometry/video-fixed-scrolling-expected.png:
  • platform/qt-5.0-wk2/compositing/masks/masked-ancestor-expected.png:
  • platform/qt-5.0-wk2/compositing/masks/multiple-masks-expected.png:
  • platform/qt-5.0-wk2/compositing/masks/simple-composited-mask-expected.png:
  • platform/qt-5.0-wk2/compositing/overflow/nested-scrolling-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/overflow/overflow-scroll-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/patterns/direct-pattern-compositing-contain-no-repeat-expected.png: Added.
  • platform/qt-5.0-wk2/compositing/repaint/newly-composited-on-scroll-expected.png:
  • platform/qt-5.0-wk2/compositing/repaint/page-scale-repaint-expected.png:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-absolute-overflow-expected.png:
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
  • platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.png:
  • platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png:
  • platform/qt-5.0-wk2/css1/basic/containment-expected.png: Added.
  • platform/qt-5.0-wk2/css1/basic/id_as_selector-expected.png: Added.
  • platform/qt-5.0-wk2/css1/basic/inheritance-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border_bottom-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border_bottom_width-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border_left-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border_left_width-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border_right_inline-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border_right_width-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border_style-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border_top-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border_top_width-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/border_width-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/clear-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/clear_float-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/float_elements_in_series-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/float_margin-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/float_on_text_elements-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/height-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/margin-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/margin_bottom-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/margin_inline-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/margin_left-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/margin_right-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/margin_top-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/padding-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/padding_bottom-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/padding_inline-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/padding_left-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/padding_right-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/padding_top-expected.png: Added.
  • platform/qt-5.0-wk2/css1/box_properties/width-expected.png: Added.
  • platform/qt-5.0-wk2/css1/cascade/cascade_order-expected.png: Added.
  • platform/qt-5.0-wk2/css1/classification/display-expected.png: Added.
  • platform/qt-5.0-wk2/css1/classification/list_style_type-expected.png: Added.
  • platform/qt-5.0-wk2/css1/classification/white_space-expected.png: Added.
  • platform/qt-5.0-wk2/css1/color_and_background/background-expected.png: Added.
  • platform/qt-5.0-wk2/css1/color_and_background/background_attachment-expected.png: Added.
  • platform/qt-5.0-wk2/css1/color_and_background/background_position-expected.png: Added.
  • platform/qt-5.0-wk2/css1/color_and_background/background_repeat-expected.png: Added.
  • platform/qt-5.0-wk2/css1/conformance/forward_compatible_parsing-expected.png: Added.
  • platform/qt-5.0-wk2/css1/font_properties/font-expected.png: Added.
  • platform/qt-5.0-wk2/css1/font_properties/font_family-expected.png: Added.
  • platform/qt-5.0-wk2/css1/font_properties/font_size-expected.png: Added.
  • platform/qt-5.0-wk2/css1/font_properties/font_weight-expected.png: Added.
  • platform/qt-5.0-wk2/css1/formatting_model/floating_elements-expected.png: Added.
  • platform/qt-5.0-wk2/css1/formatting_model/height_of_lines-expected.png: Added.
  • platform/qt-5.0-wk2/css1/formatting_model/horizontal_formatting-expected.png: Added.
  • platform/qt-5.0-wk2/css1/formatting_model/inline_elements-expected.png: Added.
  • platform/qt-5.0-wk2/css1/formatting_model/replaced_elements-expected.png: Added.
  • platform/qt-5.0-wk2/css1/formatting_model/vertical_formatting-expected.png: Added.
  • platform/qt-5.0-wk2/css1/pseudo/anchor-expected.png: Added.
  • platform/qt-5.0-wk2/css1/pseudo/firstletter-expected.png: Added.
  • platform/qt-5.0-wk2/css1/pseudo/firstline-expected.png: Added.
  • platform/qt-5.0-wk2/css1/pseudo/multiple_pseudo_elements-expected.png: Added.
  • platform/qt-5.0-wk2/css1/text_properties/letter_spacing-expected.png: Added.
  • platform/qt-5.0-wk2/css1/text_properties/line_height-expected.png: Added.
  • platform/qt-5.0-wk2/css1/text_properties/text_decoration-expected.png: Added.
  • platform/qt-5.0-wk2/css1/text_properties/text_indent-expected.png: Added.
  • platform/qt-5.0-wk2/css1/text_properties/text_transform-expected.png: Added.
  • platform/qt-5.0-wk2/css1/text_properties/vertical_align-expected.png: Added.
  • platform/qt-5.0-wk2/css1/text_properties/word_spacing-expected.png: Added.
  • platform/qt-5.0-wk2/css1/units/color_units-expected.png: Added.
  • platform/qt-5.0-wk2/css1/units/length_units-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/abspos-containing-block-initial-007-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/layout-state-only-positioned-expected.png.
  • platform/qt-5.0-wk2/css2.1/20110323/abspos-non-replaced-width-margin-000-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/abspos-replaced-width-margin-000-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/block-non-replaced-height-002-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/block-non-replaced-height-004-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/block-non-replaced-height-008-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/block-non-replaced-height-010-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/block-non-replaced-height-012-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/block-non-replaced-height-014-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/block-non-replaced-height-016-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t0803-c5502-mrgn-r-02-c-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t0803-c5505-mrgn-02-c-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t080301-c411-vt-mrgn-00-b-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t1002-c5523-width-02-b-g-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t1202-counters-08-b-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t1508-c527-font-07-b-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/delete-after-span-ws-001-expected.png:
  • platform/qt-5.0-wk2/editing/deleting/delete-after-span-ws-002-expected.png:
  • platform/qt-5.0-wk2/editing/deleting/delete-after-span-ws-003-expected.png:
  • platform/qt-5.0-wk2/editing/deleting/delete-line-end-ws-001-expected.png: Added.
  • platform/qt-5.0-wk2/editing/deleting/delete-line-end-ws-002-expected.png: Added.
  • platform/qt-5.0-wk2/editing/inserting/insert-div-023-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/extend-by-character-004-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/focus_editable_html-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/move-by-character-004-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/select-all-001-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/select-all-002-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/select-all-003-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/select-all-004-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png.
  • platform/qt-5.0-wk2/editing/selection/unrendered-001-expected.png:
  • platform/qt-5.0-wk2/editing/selection/unrendered-002-expected.png:
  • platform/qt-5.0-wk2/editing/selection/unrendered-003-expected.png:
  • platform/qt-5.0-wk2/editing/selection/unrendered-004-expected.png:
  • platform/qt-5.0-wk2/editing/selection/unrendered-005-expected.png:
  • platform/qt-5.0-wk2/fast/backgrounds/background-inherit-color-bug-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/background-leakage-transforms-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Added.
  • platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize15-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/basic/016-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/basic/fieldset-stretch-to-legend-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/basic/truncation-rtl-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/float/008-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/layout-state-only-positioned-expected.png.
  • platform/qt-5.0-wk2/fast/block/float/013-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/float/019-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.png.
  • platform/qt-5.0-wk2/fast/block/float/021-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/float/025-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/float/027-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/float/032-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/float/033-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
  • platform/qt-5.0-wk2/fast/block/float/035-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/repaint/newly-composited-on-scroll-expected.png.
  • platform/qt-5.0-wk2/fast/block/float/avoidance-percent-width-strict-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/float/br-with-clear-2-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png.
  • platform/qt-5.0-wk2/fast/block/float/centered-float-avoidance-complexity-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/float/float-avoidance-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/float/nested-clearance-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
  • platform/qt-5.0-wk2/fast/block/float/relative-painted-twice-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/rtl/rtl-fixed-overflow-expected.png.
  • platform/qt-5.0-wk2/fast/block/float/shrink-to-avoid-float-complexity-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/lineboxcontain/parsing-invalid-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/margin-collapse/103-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/margin-collapse/104-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/margin-collapse/empty-clear-blocks-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/047-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/051-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/055-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/auto/007-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/auto/vertical-lr/005-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/auto/vertical-rl/005-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/fixed-positioning-scrollbar-bug-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/negative-rel-position-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png.
  • platform/qt-5.0-wk2/fast/block/positioning/relative-overflow-block-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/relative-overflow-replaced-expected.png: Added.
  • platform/qt-5.0-wk2/fast/block/positioning/relative-overflow-replaced-float-expected.png: Added.
  • platform/qt-5.0-wk2/fast/body-propagation/overflow/001-expected.png: Added.
  • platform/qt-5.0-wk2/fast/body-propagation/overflow/001-xhtml-expected.png: Added.
  • platform/qt-5.0-wk2/fast/body-propagation/overflow/005-declarative-expected.png: Added.
  • platform/qt-5.0-wk2/fast/body-propagation/overflow/005-expected.png: Added.
  • platform/qt-5.0-wk2/fast/body-propagation/overflow/005-xhtml-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-image-massive-scale-expected.png:
  • platform/qt-5.0-wk2/fast/borders/border-image-rotate-transform-expected.png:
  • platform/qt-5.0-wk2/fast/borders/border-image-scale-transform-expected.png:
  • platform/qt-5.0-wk2/fast/borders/border-image-scaled-expected.png:
  • platform/qt-5.0-wk2/fast/borders/inline-mask-overlay-image-expected.png:
  • platform/qt-5.0-wk2/fast/borders/rtl-border-01-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/rtl-border-02-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/rtl-border-03-expected.png: Added.
  • platform/qt-5.0-wk2/fast/box-shadow/basic-shadows-expected.png: Added.
  • platform/qt-5.0-wk2/fast/box-sizing/box-sizing-expected.png: Added.
  • platform/qt-5.0-wk2/fast/canvas/canvas-bg-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
  • platform/qt-5.0-wk2/fast/canvas/canvas-text-alignment-expected.png: Added.
  • platform/qt-5.0-wk2/fast/canvas/image-object-in-canvas-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css-generated-content/014-expected.png:
  • platform/qt-5.0-wk2/fast/css-generated-content/table-parts-before-and-after-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/005-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  • platform/qt-5.0-wk2/fast/css/border-height-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/clip-text-in-scaled-div-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/color-correction-backgrounds-and-text-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/empty-pseudo-class-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/first-child-pseudo-class-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/first-of-type-pseudo-class-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/font_property_normal-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/hsl-color-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/last-child-pseudo-class-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/last-of-type-pseudo-class-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/line-height-overflow-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/nested-floating-relative-position-percentages-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/only-child-pseudo-class-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/only-of-type-pseudo-class-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/relative-positioned-block-with-inline-ancestor-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/shadow-multiple-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/text-overflow-ellipsis-text-align-justify-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/text-overflow-ellipsis-text-align-left-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/text-overflow-ellipsis-text-align-right-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png: Added.
  • platform/qt-5.0-wk2/fast/dom/clone-node-dynamic-style-expected.png: Added.
  • platform/qt-5.0-wk2/fast/dynamic/008-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/custom/text-xy-updates-SVGList-expected.png.
  • platform/qt-5.0-wk2/fast/dynamic/anchor-lock-expected.png: Added.
  • platform/qt-5.0-wk2/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Added.
  • platform/qt-5.0-wk2/fast/encoding/utf-16-big-endian-expected.png: Added.
  • platform/qt-5.0-wk2/fast/encoding/utf-16-little-endian-expected.png: Added.
  • platform/qt-5.0-wk2/fast/events/pointer-events-2-expected.png:
  • platform/qt-5.0-wk2/fast/events/resize-events-expected.png: Added.
  • platform/qt-5.0-wk2/fast/flexbox/016-expected.png: Added.
  • platform/qt-5.0-wk2/fast/flexbox/flex-hang-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
  • platform/qt-5.0-wk2/fast/forms/basic-textareas-quirks-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/button-default-title-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/button-table-styles-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/disabled-select-change-index-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/fieldset-align-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/file/file-input-direction-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/form-hides-table-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/input-appearance-selection-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/input-placeholder-paint-order-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
  • platform/qt-5.0-wk2/fast/frames/flattening/frameset-flattening-advanced-expected.png: Added.
  • platform/qt-5.0-wk2/fast/frames/flattening/frameset-flattening-grid-expected.png: Added.
  • platform/qt-5.0-wk2/fast/frames/flattening/frameset-flattening-simple-expected.png:
  • platform/qt-5.0-wk2/fast/frames/flattening/frameset-flattening-subframe-resize-expected.png: Added.
  • platform/qt-5.0-wk2/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.png: Added.
  • platform/qt-5.0-wk2/fast/frames/flattening/iframe-flattening-out-of-view-expected.png: Added.
  • platform/qt-5.0-wk2/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.png: Added.
  • platform/qt-5.0-wk2/fast/frames/iframe-scrolling-attribute-expected.png: Added.
  • platform/qt-5.0-wk2/fast/frames/transparent-scrollbar-expected.png:
  • platform/qt-5.0-wk2/fast/gradients/background-clipped-expected.png:
  • platform/qt-5.0-wk2/fast/gradients/css3-color-stop-units-expected.png:
  • platform/qt-5.0-wk2/fast/html/details-position-expected.png: Added.
  • platform/qt-5.0-wk2/fast/html/details-writing-mode-expected.png: Added.
  • platform/qt-5.0-wk2/fast/images/gif-large-checkerboard-expected.png: Added.
  • platform/qt-5.0-wk2/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
  • platform/qt-5.0-wk2/fast/inline/inline-borders-with-bidi-override-expected.png: Added.
  • platform/qt-5.0-wk2/fast/inline/inline-continuation-borders-expected.png: Added.
  • platform/qt-5.0-wk2/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.png: Added.
  • platform/qt-5.0-wk2/fast/inline/long-wrapped-line-expected.png: Added.
  • platform/qt-5.0-wk2/fast/layers/layer-content-visibility-change-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
  • platform/qt-5.0-wk2/fast/layers/scroll-rect-to-visible-expected.png:
  • platform/qt-5.0-wk2/fast/line-grid/line-grid-inside-columns-expected.png: Added.
  • platform/qt-5.0-wk2/fast/lists/001-expected.png: Added.
  • platform/qt-5.0-wk2/fast/lists/001-vertical-expected.png: Added.
  • platform/qt-5.0-wk2/fast/lists/008-expected.png: Added.
  • platform/qt-5.0-wk2/fast/lists/008-vertical-expected.png: Added.
  • platform/qt-5.0-wk2/fast/lists/li-br-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
  • platform/qt-5.0-wk2/fast/lists/ol-start-parsing-expected.png: Added.
  • platform/qt-5.0-wk2/fast/lists/olstart-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/block-axis-horizontal-tb-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/client-rects-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/column-break-with-balancing-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/column-rules-stacking-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/columns-shorthand-parsing-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/float-multicol-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/float-paginate-complex-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/float-paginate-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/layers-in-multicol-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/layers-split-across-columns-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/paginate-block-replaced-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/pagination-h-horizontal-bt-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
  • platform/qt-5.0-wk2/fast/multicol/pagination-h-horizontal-tb-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png.
  • platform/qt-5.0-wk2/fast/multicol/pagination-h-vertical-lr-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
  • platform/qt-5.0-wk2/fast/multicol/pagination-h-vertical-rl-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
  • platform/qt-5.0-wk2/fast/multicol/pagination-v-horizontal-bt-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
  • platform/qt-5.0-wk2/fast/multicol/pagination-v-horizontal-tb-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png.
  • platform/qt-5.0-wk2/fast/multicol/pagination-v-vertical-lr-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/qt-5.0-wk2/fast/multicol/pagination-v-vertical-rl-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/repaint/newly-composited-on-scroll-expected.png.
  • platform/qt-5.0-wk2/fast/multicol/positioned-with-constrained-height-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/progression-reverse-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/span/anonymous-style-inheritance-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/span/span-as-immediate-child-generated-content-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/span/span-as-immediate-child-property-removal-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/span/span-as-immediate-columns-child-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/span/span-as-nested-columns-child-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/span/span-margin-collapsing-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/table-vertical-align-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-lr/column-break-with-balancing-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-lr/float-paginate-complex-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-lr/float-paginate-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-lr/nested-columns-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-lr/unsplittable-inline-block-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-rl/column-break-with-balancing-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-rl/float-paginate-complex-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-rl/float-paginate-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-rl/nested-columns-expected.png: Added.
  • platform/qt-5.0-wk2/fast/multicol/vertical-rl/unsplittable-inline-block-expected.png: Added.
  • platform/qt-5.0-wk2/fast/overflow/006-expected.png: Added.
  • platform/qt-5.0-wk2/fast/overflow/overflow-auto-table-expected.png: Added.
  • platform/qt-5.0-wk2/fast/overflow/overflow-stacking-expected.png: Added.
  • platform/qt-5.0-wk2/fast/overflow/paged-x-on-root-expected.png: Added.
  • platform/qt-5.0-wk2/fast/overflow/paged-y-on-root-expected.png: Added.
  • platform/qt-5.0-wk2/fast/overflow/position-fixed-transform-clipping-expected.png:
  • platform/qt-5.0-wk2/fast/reflections/reflection-direction-expected.png: Added.
  • platform/qt-5.0-wk2/fast/regions/region-style-image-background-color-expected.png:
  • platform/qt-5.0-wk2/fast/regions/region-style-inline-background-color-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
  • platform/qt-5.0-wk2/fast/repaint/dynamic-table-vertical-alignment-change-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/fixed-position-transparency-with-overflow-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/float-new-in-block-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
  • platform/qt-5.0-wk2/fast/repaint/layout-state-only-positioned-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/overflow-scroll-body-appear-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-reflection-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-fixed-layer-with-transformed-parent-layer-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/scroll-relative-table-inside-table-cell-expected.png:
  • platform/qt-5.0-wk2/fast/repaint/transform-absolute-in-positioned-container-expected.png:
  • platform/qt-5.0-wk2/fast/replaced/005-expected.png: Added.
  • platform/qt-5.0-wk2/fast/replaced/width100percent-image-expected.png:
  • platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png:
  • platform/qt-5.0-wk2/fast/selectors/166-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/023-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/027-vertical-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/034-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/038-vertical-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/040-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/040-vertical-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/border-collapsing/002-vertical-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/border-collapsing/004-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/border-collapsing/004-vertical-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/empty-cells-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/frame-and-rules-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/height-percent-test-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
  • platform/qt-5.0-wk2/fast/table/height-percent-test-vertical-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
  • platform/qt-5.0-wk2/fast/table/overflowHidden-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/prepend-in-anonymous-table-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/table-display-types-vertical-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/wide-colspan-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/layout-state-only-positioned-expected.png.
  • platform/qt-5.0-wk2/fast/table/wide-column-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
  • platform/qt-5.0-wk2/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/hyphenate-limit-lines-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/large-text-composed-char-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/softHyphen-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/text-letter-spacing-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/wbr-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/word-break-expected.png: Added.
  • platform/qt-5.0-wk2/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Added.
  • platform/qt-5.0-wk2/fast/transforms/rotated-transform-affects-scrolling-2-expected.png: Added.
  • platform/qt-5.0-wk2/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png: Added.
  • platform/qt-5.0-wk2/fast/writing-mode/box-shadow-vertical-lr-expected.png:
  • platform/qt-5.0-wk2/fast/writing-mode/box-shadow-vertical-rl-expected.png: Added.
  • platform/qt-5.0-wk2/fast/writing-mode/fieldsets-expected.png: Added.
  • platform/qt-5.0-wk2/fonts/cursive-expected.png: Added.
  • platform/qt-5.0-wk2/fonts/default-expected.png: Added.
  • platform/qt-5.0-wk2/fonts/fantasy-expected.png: Added.
  • platform/qt-5.0-wk2/fonts/monospace-expected.png: Added.
  • platform/qt-5.0-wk2/fonts/sans-serif-expected.png: Added.
  • platform/qt-5.0-wk2/fonts/serif-expected.png: Added.
  • platform/qt-5.0-wk2/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
  • platform/qt-5.0-wk2/ietestcenter/css3/bordersbackgrounds/background-size-aspect-ratio-expected.png: Added.
  • platform/qt-5.0-wk2/ietestcenter/css3/bordersbackgrounds/background_position_three_four_values-expected.png: Added.
  • platform/qt-5.0-wk2/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
  • platform/qt-5.0-wk2/printing/return-from-printing-mode-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png:
  • platform/qt-5.0-wk2/svg/as-image/image-preserveAspectRatio-all-expected.png: Added.
  • platform/qt-5.0-wk2/svg/as-image/image-respects-pageScaleFactor-expected.png:
  • platform/qt-5.0-wk2/svg/custom/altglyph-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/external-paintserver-reference-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png.
  • platform/qt-5.0-wk2/svg/custom/js-late-pattern-creation-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/junk-data-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/linking-base-external-reference-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/repaint/scroll-in-fixed-layer-expected.png.
  • platform/qt-5.0-wk2/svg/custom/missing-xlink-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/object-sizing-no-width-height-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/path-bad-data-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/pattern-scaling-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
  • platform/qt-5.0-wk2/svg/custom/text-xy-updates-SVGList-expected.png:
  • platform/qt-5.0-wk2/svg/custom/use-font-face-crash-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-appendItem-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-initialize-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-insertItemBefore-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-removeItem-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-replaceItem-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/SVGStringList-basics-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dom/css-transforms-expected.png: Added.
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-in-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-in2-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-dom-mode-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-in-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-in2-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEBlendElement-svgdom-mode-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-type-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-values-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFEComponentTransferElement-svgdom-type-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLineElement-svgdom-requiredFeatures-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGPatternElement-svgdom-patternTransform-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-dom-lengthAdjust-attr-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGTextElement-svgdom-lengthAdjust-prop-expected.png:
  • platform/qt-5.0-wk2/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png:
  • platform/qt-5.0-wk2/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feImage-multiple-targets-id-change-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png.
  • platform/qt-5.0-wk2/svg/hixie/error/012-expected.png: Added.
  • platform/qt-5.0-wk2/svg/in-html/circle-expected.png: Added.
  • platform/qt-5.0-wk2/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/qt-5.0-wk2/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/qt-5.0-wk2/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/qt-5.0-wk2/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/qt-5.0-wk2/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-defaults-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/compositing/scaling/tiled-layer-recursion-expected.png.
  • platform/qt-5.0-wk2/svg/repaint/image-with-clip-path-expected.png:
  • platform/qt-5.0-wk2/svg/text/kerning-expected.png: Added.
  • platform/qt-5.0-wk2/svg/text/multichar-glyph-expected.png: Added.
  • platform/qt-5.0-wk2/svg/wicd/rightsizing-grid-expected.png: Added.
  • platform/qt-5.0-wk2/svg/wicd/test-rightsizing-b-expected.png:
  • platform/qt-5.0-wk2/svg/wicd/test-scalable-background-image1-expected.png: Added.
  • platform/qt-5.0-wk2/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
  • platform/qt-5.0-wk2/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
  • platform/qt-5.0-wk2/svg/zoom/page/zoom-mask-with-percentages-expected.png:
  • platform/qt-5.0-wk2/svg/zoom/page/zoom-svg-float-border-padding-expected.png:
  • platform/qt-5.0-wk2/svg/zoom/text/zoom-svg-float-border-padding-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug101674-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug10269-2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug10296-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug1055-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug113235-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug113235-3-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug11944-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug120364-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug12384-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug1302-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug131020-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug131020_iframe-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug137388-2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug16252-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug194024-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug22019-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug23151-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug2479-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug2479-3-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug2479-4-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug27038-2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug29314-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug2947-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug32205-2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug38916-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug3977-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug43039-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug43854-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug44505-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug46480-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug46480-2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug50695-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug56405-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug5797-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug5835-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug625-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug650-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug67915-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug7112-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug7112-2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug73321-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug92143-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug96343-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/collapsing_borders/bug41262-3-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/core/bloomberg-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla/core/captions-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/core/cell_heights-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/core/col_span-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/core/col_widths_auto_fix-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/core/col_widths_fix_fixPer-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/core/nested1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/core/one_row-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/core/row_span-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_index-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_position-table-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_simple-table-cell-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_simple-table-column-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_simple-table-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_simple-table-row-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_table_bgcolor_name-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_td_bgcolor_name-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_td_height-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_td_nowrap-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_th_bgcolor_name-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_th_height-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_th_nowrap-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/other/cell_widths-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/other/nestedTables-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/other/test3-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/other/test6-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/other/wa_table_thtd_rowspan-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/other/wa_table_tr_align-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug10140-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug101759-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug10216-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug1055-2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug106966-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug19526-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug220653-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug22122-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug67915-2-expected.png: Copied from LayoutTests/platform/qt-5.0-wk2/fast/scrolling/scrollbar-tickmarks-styled-expected.png.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug7243-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug80762-2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug89315-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/bugs/bug91057-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/backgrounds-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/captions1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/captions2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/captions3-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/col_span2-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/columns-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/conflicts-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/core/standards1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/other/empty_cells-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla_expected_failures/other/test4-expected.png: Added.
  • platform/qt-5.0-wk2/transforms/2d/transform-fixed-container-expected.png:
5:53 AM Changeset in webkit [150960] by akling@apple.com
  • 11 edits in trunk/Source/WebCore

Avoid using CSSOM style declarations in HTML editing.
<http://webkit.org/b/117019>

Reviewed by Antti Koivisto.

Convert the editing code to use ComputedStyleExtractor instead of instantiating CSSOM wrappers.

  • css/CSSComputedStyleDeclaration.h:
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::getFontSizeCSSValuePreferringKeyword):
(WebCore::ComputedStyleExtractor::useFixedFontDefaultSize):
(WebCore::ComputedStyleExtractor::propertyMatches):
(WebCore::ComputedStyleExtractor::copyProperties):
(WebCore::ComputedStyleExtractor::copyPropertiesInSet):

Moved here from CSSComputedStyleDeclaration. These methods are used by HTML editing.

(WebCore::CSSComputedStyleDeclaration::copyProperties):

Reimplemented to call ComputedStyleExtractor.

  • css/CSSStyleDeclaration.h:
  • css/PropertySetCSSStyleDeclaration.h:
  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::copyProperties):

Removed CSSStyleDeclaration::cssPropertyMatches(), the remaining code lives in
ComputedStyleExtractor::propertyMatches() and is only used by HTML editing.

  • css/StylePropertySet.h:
  • css/StylePropertySet.cpp:

(WebCore::MutableStylePropertySet::removeEquivalentProperties):

Added an overload that takes a ComputedStyleExtractor.
This code should move into EditingStyle.cpp, material for a follow-up patch.

  • editing/ApplyStyleCommand.cpp:

(WebCore::toIdentifier):

Add a file-local helper for yanking the identifier value (if any) out of a CSSPrimitiveValue.

(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock):
(WebCore::highestEmbeddingAncestor):

  • editing/EditingStyle.h:
  • editing/EditingStyle.cpp:

(WebCore::editingStyleFromComputedStyle):
(WebCore::extractPropertyValue):
(WebCore::identifierForStyleProperty):
(WebCore::textColorFromStyle):
(WebCore::backgroundColorFromStyle):
(WebCore::EditingStyle::init):
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::EditingStyle::triStateOfStyle):
(WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
(WebCore::StyleChange::StyleChange):
(WebCore::fontWeightIsBold):
(WebCore::extractPropertiesNotIn):
(WebCore::getPropertiesNotIn):

Use ComputedStyleExtractor instead of CSSComputedStyleDeclaration in all of this code.
Templatized a bunch of the code so we don't have to repeat ourselves for both StylePropertySet
and ComputedStyleExtractor inputs.

5:41 AM Changeset in webkit [150959] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove "hidden"=true from Inspector.json
https://bugs.webkit.org/show_bug.cgi?id=114116

Patch by Roland Takacs <rtakacs@inf.u-szeged.hu> on 2013-05-30
Reviewed by Timothy Hatcher.

Remove "hidden"=true because it's a Chromium concept.
Patch created by Timothy Hatcher.

  • inspector/Inspector.json:
5:28 AM Changeset in webkit [150958] by kalyan.kondapally@intel.com
  • 9 edits in trunk/Source/WebCore

[EFL][EGL] Implement TransportSurface client.
https://bugs.webkit.org/show_bug.cgi?id=114122

Reviewed by Kenneth Rohde Christiansen.

Covered by existing WebGL tests.

This patch implements the client support for Transport
Surface with EGL backend using GLES2.

  • platform/graphics/surfaces/efl/GLTransportSurface.cpp:

(WebCore::GLTransportSurfaceClient::createTransportSurfaceClient):
(WebCore::GLTransportSurfaceClient::GLTransportSurfaceClient):

  • platform/graphics/surfaces/efl/GLTransportSurface.h:

(GLTransportSurfaceClient):

  • platform/graphics/surfaces/efl/GraphicsSurfaceCommon.cpp:

(WebCore::GraphicsSurfacePrivate::initializeClient):

  • platform/graphics/surfaces/egl/EGLConfigSelector.cpp:

(WebCore):
(WebCore::EGLConfigSelector::surfaceClientConfig):
(WebCore::EGLConfigSelector::findMatchingConfigWithVisualId):

  • platform/graphics/surfaces/egl/EGLConfigSelector.h:

(WebCore):
(EGLConfigSelector):

Support for retrieving valid EGLConfig on client side.

  • platform/graphics/surfaces/egl/EGLHelper.cpp:

(WebCore):
(WebCore::resolveDisplay):
(WebCore::EGLHelper::resolveEGLBindings):
(WebCore::EGLHelper::createEGLImage):
(WebCore::EGLHelper::destroyEGLImage):
(WebCore::EGLHelper::imageTargetTexture2DOES):

  • platform/graphics/surfaces/egl/EGLHelper.h:

Helper functions to create and destroy EGLImage.

  • platform/graphics/surfaces/egl/EGLXSurface.cpp:

(WebCore::EGLXTransportSurfaceClient::EGLXTransportSurfaceClient):
(WebCore):
(WebCore::EGLXTransportSurfaceClient::~EGLXTransportSurfaceClient):
(WebCore::EGLXTransportSurfaceClient::destroy):
(WebCore::EGLXTransportSurfaceClient::prepareTexture):
(WebCore::EGLTextureFromPixmap::EGLTextureFromPixmap):
(WebCore::EGLTextureFromPixmap::~EGLTextureFromPixmap):
(WebCore::EGLTextureFromPixmap::destroy):
(WebCore::EGLTextureFromPixmap::isValid):
(WebCore::EGLTextureFromPixmap::bindTexImage):
(WebCore::EGLTextureFromPixmap::reBindTexImage):

  • platform/graphics/surfaces/egl/EGLXSurface.h:

(EGLXTransportSurfaceClient):

TransportSurfaceClient implementation.

(WebCore):

  • platform/graphics/surfaces/glx/GLXSurface.cpp:

(WebCore::GLXTransportSurfaceClient::GLXTransportSurfaceClient):

  • platform/graphics/surfaces/glx/GLXSurface.h:

(GLXTransportSurfaceClient):

  • platform/graphics/surfaces/glx/X11Helper.cpp:

(WebCore::X11Helper::createOffScreenWindow):
(WebCore):
(WebCore::X11Helper::createPixmap):

  • platform/graphics/surfaces/glx/X11Helper.h:

(X11Helper):

5:08 AM Changeset in webkit [150957] by mkwst@chromium.org
  • 22 edits in trunk/Source/WebCore

Rename 'KURL::elidedString' and inspector's 'String.prototype.trimMiddle' for clarity.
https://bugs.webkit.org/show_bug.cgi?id=111700

Reviewed by Darin Adler.

Darin suggested that 'KURL::elidedString' is inaccurately named[1], this
patch is an attempt to do better. It additionally brings the Inspector's
'String.prototype.trimMiddle' method into line, as the two methods do
more or less the same thing.

After a bit of discussion with Maciej and Daniel Bates on IRC, I've
settled on 'KURL::stringCenterEllipsizedToLength(unsigned)' and
'String.prototype.centerEllipsizedToLength(number)' respectively.

No new tests are added, as this patch shouldn't have any visible effect
on the web. It's strictly an internal refactoring.

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):
(WebCore::WebSocket::send):

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::send):
(WebCore::WebSocketChannel::fail):

  • bindings/ScriptControllerBase.cpp:

(WebCore::ScriptController::canExecuteScripts):

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::executeScript):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::canPlayType):
(WebCore::HTMLMediaElement::isSafeToLoadURL):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
(WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
(WebCore::createWindow):

  • loader/MainResourceLoader.cpp:

(WebCore::MainResourceLoader::willSendRequest):
(WebCore::MainResourceLoader::responseReceived):

  • loader/MixedContentChecker.cpp:

(WebCore::MixedContentChecker::logWarning):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didReceiveResponse):
(WebCore::ApplicationCacheGroup::didFail):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::loadResource):
(WebCore::CachedResourceLoader::printAccessDeniedMessage):

  • page/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
(WebCore::CSPDirectiveList::allowScriptNonce):
(WebCore::CSPDirectiveList::allowPluginType):

  • platform/KURL.cpp:

(WebCore::KURL::stringCenterEllipsizedToLength):

  • platform/KURL.h:

Rename 'KURL::elidedString' to 'KURL::stringCenterEllipsizedToLength',
and adjust callsites accordingly.

  • inspector/front-end/CallStackSidebarPane.js:

(WebInspector.CallStackSidebarPane.Placard.prototype._update):

  • inspector/front-end/ElementsTreeOutline.js:

(WebInspector.ElementsTreeElement.prototype._buildAttributeDOM):

  • inspector/front-end/HeapSnapshotGridNodes.js:

(WebInspector.HeapSnapshotGenericObjectNode.prototype.shortenWindowURL):

  • inspector/front-end/Linkifier.js:

(WebInspector.Linkifier.DefaultFormatter.prototype.formatLiveAnchor):

  • inspector/front-end/ResourceUtils.js:

(WebInspector.linkifyURLAsNode):

  • inspector/front-end/TabbedEditorContainer.js:

(WebInspector.TabbedEditorContainer.prototype._titleForFile):

  • inspector/front-end/utilities.js:

Rename 'String.prototype.trimMiddle' to 'String.prototype.centerEllipsizedToLength'
and adjust callsites accordingly.

3:44 AM Changeset in webkit [150956] by Antti Koivisto
  • 15 edits
    2 moves in trunk/Source/WebCore

Rename FontFallbackList.cpp/h to FontGlyphs.cpp/h
https://bugs.webkit.org/show_bug.cgi?id=117022

Reviewed by Andreas Kling.

Rename to match the class name.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Target.pri:
  • WebCore.vcproj/WebCore.vcproj:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/Font.h:
  • platform/graphics/FontCache.cpp:
  • platform/graphics/FontFallbackList.cpp: Removed.
  • platform/graphics/FontFallbackList.h: Removed.
  • platform/graphics/FontFastPath.cpp:
  • platform/graphics/FontGlyphs.cpp: Copied from Source/WebCore/platform/graphics/FontFallbackList.cpp.
  • platform/graphics/FontGlyphs.h: Copied from Source/WebCore/platform/graphics/FontFallbackList.h.
  • platform/graphics/mac/FontComplexTextMac.cpp:
3:43 AM Changeset in webkit [150955] by rniwa@webkit.org
  • 6 edits
    11 deletes in trunk

Web Inspector: tests in PerformanceTests/inspector/ are timing out
https://bugs.webkit.org/show_bug.cgi?id=77024

Reviewed by Andreas Kling.

PerformanceTests:

These tests have been disabled for ages and don't conform to the standard format.

  • Skipped:
  • inspector: Removed.
  • inspector/console-300-lines.html: Removed.
  • inspector/first-open-elements.html: Removed.
  • inspector/first-open-resources.html: Removed.
  • inspector/first-open-scripts.html.broken: Removed.
  • inspector/heap-snapshot-advanced.html: Removed.
  • inspector/heap-snapshot-performance-test.js: Removed.
  • inspector/heap-snapshot.html: Removed.
  • inspector/inspector-startup-time.html: Removed.
  • inspector/network-append-30-requests.html.broken: Removed.
  • inspector/performance-test.js: Removed.
  • inspector/show-panel.html.broken: Removed.

Tools:

Remove inspector performance tests since they have been disabled for ages,
and they don't use the standard parser-style performance output.

It's adding a lot of code complexity to our infrastructure.

  • Scripts/webkitpy/performance_tests/perftest.py:

(SingleProcessPerfTest.init):
(PerfTestFactory):

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPerfTestFactory.test_regular_test):

  • Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:

(TestDriver.run_test):
(MainTest.run_test):
(MainTest._tests_for_runner):
(MainTest.test_run_test_set_kills_drt_per_run):
(MainTest._test_run_with_json_output):
(MainTest):
(MainTest.test_run_with_upload_json_should_generate_perf_webkit_json):

3:42 AM Changeset in webkit [150954] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

Get rid of Position::computedStyle
https://bugs.webkit.org/show_bug.cgi?id=117024

Reviewed by Andreas Kling.

Removed the function.

  • dom/Position.cpp:
  • dom/Position.h:
  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::positionToComputeInlineStyleChange): We need a position
inside the dummy element since we'll get the containing element's style instead
if we had the position before the dummy element.

  • editing/EditingStyle.cpp:

(WebCore::StyleChange::StyleChange):

1:14 AM Changeset in webkit [150953] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove obsolete forward declaration from InspectorFrontendHost.h
https://bugs.webkit.org/show_bug.cgi?id=117017

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-30
Reviewed by Joseph Pecoraro.

Remove obsolete forward declaration and fix style issue as well.

No change in behavior, no new tests.

  • inspector/InspectorFrontendHost.h:

(WebCore):
(InspectorFrontendHost):

12:34 AM Changeset in webkit [150952] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] Cleanup TestExpectations
https://bugs.webkit.org/show_bug.cgi?id=117005

Unreviewed GTK gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-05-30

  • platform/gtk/TestExpectations: Get rid of duplicate entry line.
12:32 AM Changeset in webkit [150951] by rniwa@webkit.org
  • 6 edits in trunk/Tools

Remove requires_http_server as Chromium Android was the only port that needed this
https://bugs.webkit.org/show_bug.cgi?id=117018

Reviewed by Benjamin Poulain.

Removed the unused code that existed for Chromium Android port.

  • Scripts/webkitpy/layout_tests/controllers/layout_test_runner.py:

(LayoutTestRunner.run_tests):
(LayoutTestRunner._handle_finished_test_list):

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._run_tests):

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._collect_tests):
(PerfTestsRunner.run):

  • Scripts/webkitpy/port/base.py:

(Port.to.start_helper):

  • Scripts/webkitpy/port/base_unittest.py:

(PortTest.test_build_path):

Note: See TracTimeline for information about the timeline view.