Jun 16, 2013:

11:53 PM Changeset in webkit [151630] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/LayoutTests

[CSS Blending] Update the background-blend-mode-image-color-dynamic test to use the repaint test logic

Updating testcase verifying if background blend modes are updated dynamically from script. This now
properly uses the repaint test mechanism. Also, the background image resource is addded.


Patch by Mihai Tica <mitica@adobe.com> on 2013-06-16
Reviewed by Dean Jackson.

  • fast/repaint/background-blend-mode-image-color-dynamic-expected.html:
  • fast/repaint/background-blend-mode-image-color-dynamic.html:
  • fast/repaint/resources/ducky.png: Added.
11:28 PM WebKitIDL edited by Christophe Dumez
Fix several index links (diff)
9:23 PM Changeset in webkit [151629] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix test assertion after r151624

An assertion was hit in RenderObject::willBeDestroyed()
for fast/css/getComputedStyle/getComputedStyle-background-shorthand.html
because the code asserted that the RenderObject had been removed from
the FrameView's slowRepaintObject set before remove() was called,
so move the assertion to after that call.

  • rendering/RenderObject.cpp:


8:56 PM Changeset in webkit [151628] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

Remove a redundant virtual call to hostWindow() in FrameView::invalidateRect()

Reviewed by Andreas Kling.

From Blink r152490 by <vivek.vg@samsung.com>

  • page/FrameView.cpp:

(WebCore::FrameView::invalidateRect): Avoid hostWindow() twice call.

7:25 PM Changeset in webkit [151627] by tkent@chromium.org
  • 5 edits
    2 adds in trunk

Fix two assertion failures in Range::insertNode

Reviewed by Ryosuke Niwa.


ASSERTION FAILED: childBefore == (offset ? container->childNode(offset - 1) : 0)
third_party/WebKit/Source/WebCore/dom/RangeBoundaryPoint.h(115) : void WebCore::RangeBoundaryPoint::set(PassRefPtr<WebCore::Node>, int, WebCore::Node *)

ASSERTION FAILED: child->parentNode()
../../third_party/WebKit/Source/core/dom/RangeBoundaryPoint.h(133) : void WebCore::RangeBoundaryPoint::setToBeforeChild(WebCore::Node *)

1 0x87594b2 WebCore::RangeBoundaryPoint::setToBeforeChild(WebCore::Node*)
2 0x87534a9 WebCore::Range::insertNode(WTF::PassRefPtr<WebCore::Node>, int&)

Range::insertNode calls Node::insertBefore, in which an event handler
can update the DOM structure so that RangeBoundaryPoint don't like. We
postpone event dispatching by EventQueueScope.

Also, remove old comments about Acid3. The behavior is standardized.
(Step 9 of http://dom.spec.whatwg.org/#dom-range-insertnode)

This patch imports http://src.chromium.org/viewvc/blink?view=revision&revision=150470 .

Test: fast/dom/Range/range-insertNode-assertion.html

  • dom/Range.cpp:


  • Add EventQueueScope
  • Remove obsolete comments


We need to update fast/dom/insertBefore-refChild-crash.html because the
test caused recursive calls to the event handler. container.innerHTML=
did nothing before this CL. Now container has the newChild because
DOMNodeRemoved event dispatching is delayed until Range::insertNode

We need to update fast/text/split-text-crash.xhtml so that it doesn't
stop when the event handler is called twice. I'm not sure why the test
worked before this CL.

  • fast/dom/Range/range-insertNode-assertion-expected.txt: Added.
  • fast/dom/Range/range-insertNode-assertion.html: Added.
  • fast/dom/insertBefore-refChild-crash.html:
  • fast/text/split-text-crash.xhtml:
6:58 PM Changeset in webkit [151626] by gyuyoung.kim@samsung.com
  • 2 edits
    10 adds in trunk/LayoutTests

Unreviewed. Added new baselines for some of editing/style tests, which works on EFL port.

  • platform/efl/TestExpectations:
  • platform/efl/editing/style/5017613-1-expected.png: Added.
  • platform/efl/editing/style/5017613-1-expected.txt: Added.
  • platform/efl/editing/style/5046875-1-expected.png: Added.
  • platform/efl/editing/style/5046875-1-expected.txt: Added.
  • platform/efl/editing/style/5065910-expected.png: Added.
  • platform/efl/editing/style/5065910-expected.txt: Added.
  • platform/efl/editing/style/5228141-expected.png: Added.
  • platform/efl/editing/style/5228141-expected.txt: Added.
  • platform/efl/editing/style/5279521-expected.png: Added.
  • platform/efl/editing/style/5279521-expected.txt: Added.
6:13 PM Changeset in webkit [151625] by gyuyoung.kim@samsung.com
  • 2 edits
    18 adds in trunk/LayoutTests

Unreviewed. Added new baselines for some of editing/selection tests as r151533 on EFL port.

  • platform/efl/TestExpectations:
4:32 PM Changeset in webkit [151624] by Simon Fraser
  • 5 edits
    2 adds in trunk

Fixed backgrounds in composited layers not repainted on scrolling


Reviewed by Tim Horton.

FrameView is aware that "slow-repaint objects" (i.e. renderers with
background-attachment:fixed) require a slow-scrolling path. However,
it was ignorant of the fact that such objects could be painting into
compositing layers; it simply dirtied the main tiles, and nothing else.

Fix by having FrameView track the slow-repaints objects explicitly, as we
do for position:fixed, and repaint each of them on scrolling.

Test: compositing/repaint/fixed-background-scroll.html

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView): No need to initialize m_slowRepaintObjectCount,
which is now an OwnPtr<RenderObjectSet>.
(WebCore::FrameView::useSlowRepaints): Use hasSlowRepaintObjects() now.
(WebCore::FrameView::addSlowRepaintObject): Now adds the object to a set,
allocating the set if necessary.
(WebCore::FrameView::removeSlowRepaintObject): Remove the object from the set,
and deallocate the set if empty.
(WebCore::FrameView::scrollContentsSlowPath): Call repaintSlowRepaintObjects();
this is the change that fixes the bug for always-composited implementations (e.g.
tile cache). This is a conservative change; we still invalidate the tile cache
as well. This could be optimized later.
(WebCore::FrameView::repaintSlowRepaintObjects): Repaint each object in the set.
Their appropriate compositing ancestor will be repainted.
(WebCore::FrameView::scrollPositionChangedViaPlatformWidget): Call
repaintSlowRepaintObjects() so that fixed backgrounds in composited layers are
correctly repainted; this fixes the bug for WebKit1.

  • page/FrameView.h: Replace m_slowRepaintObjectCount with a HashSet of

(WebCore::FrameView::hasSlowRepaintObject): Takes a RenderObject* now.
(WebCore::FrameView::hasSlowRepaintObjects): Ditto.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::styleWillChange): Pass the RenderObject.
(WebCore::RenderObject::willBeDestroyed): Assert that this RenderObject
has been removed from FrameView's set of slow-repaint objects already, if
the document is not being destroyed.
(WebCore::RenderObject::willBeRemovedFromTree): Pass the RenderObject.


Reviewed by Tim Horton.

Test that verifies that a composited layer with a fixed background is repainted
on scrolling.

  • compositing/repaint/fixed-background-scroll-expected.txt: Added.
  • compositing/repaint/fixed-background-scroll.html: Added.
10:24 AM Changeset in webkit [151623] by Simon Fraser
  • 8 edits
    5 adds in trunk

Source/WebCore: Painting of fixed background images is wrong in composited layers

Reviewed by Sam Weinig.

The code that computed background image geometry for background-attachment:fixed
images was unaware of compositing, so often painting the image at the wrong location.

Fix by having RenderBoxModelObject::calculateBackgroundImageGeometry() do the correct
math for fixed backgrounds in composited layer by offsetting the viewport rect by
the paint container's absolute position.

Tests: compositing/backgrounds/fixed-background-on-descendant.html


  • rendering/RenderBox.cpp:

(WebCore::RenderBox::getBackgroundPaintedExtent): Now returns a bool indicating
whether it is returning a reliable extent rect. It can return false in the case where
a background is fixed, since computing the correct extent would require finding
the appropriate composited ancestor to pass to calculateBackgroundImageGeometry().
This is OK since this function is used for "background opaque" optimizations.
(WebCore::RenderBox::computeBackgroundIsKnownToBeObscured): If getBackgroundPaintedExtent()
returns false, return false.
(WebCore::RenderBox::maskClipRect): We removed mask-attachment, so we never need to
compute the composited ancestor here and can pass null.
(WebCore::RenderBox::repaintLayerRectsForImage): Unwrap a comment.
If the changed image is related to a fixed background, geometry.hasNonLocalGeometry()
will be true. In that cause, just repaint the entire renderer rather than groveling
around for a composited ancestor.

  • rendering/RenderBox.h: Changed name and signature of backgroundPaintedExtent.
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended): calculateBackgroundImageGeometry()
now needs to know the painting container.
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Now takes a painting
container, that is required to correctly compute the viewport-relative offset for fixed
backgrounds. geometry.setHasNonLocalGeometry() is set for fixed backgrounds to indicate
to callers that, if they didn't pass a paint container, the destRect is not accurate.
The main bug fix is also here: we move the viewportRect by the absolute location of
paint container, which is equivalent to the composited layer offset.
(WebCore::RenderBoxModelObject::getGeometryForBackgroundImage): calculateBackgroundImageGeometry()
takes a paint container.

  • rendering/RenderBoxModelObject.h:


  • rendering/RenderImage.cpp:

(WebCore::RenderImage::computeBackgroundIsKnownToBeObscured): If getBackgroundPaintedExtent()
can't cheaply give an accurate answer, return false.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage): Pass the paint container,
which is our own renderer.

LayoutTests: Fixed background images behave strangely with webkit transitions

Reviewed by Sam Weinig.

Ref tests that compare fixed background rendering after a scroll, with and
without compositing, with a couple of layer configurations.

  • compositing/backgrounds/fixed-background-on-descendant-expected.html: Added.
  • compositing/backgrounds/fixed-background-on-descendant.html: Added.
  • compositing/backgrounds/fixed-backgrounds-expected.html: Added.
  • compositing/backgrounds/fixed-backgrounds.html: Added.
9:57 AM Changeset in webkit [151622] by Simon Fraser
  • 7 edits
    2 adds in trunk

webkit-backface-visibility on a parent element stops background-position from updating


Reviewed by Darin Adler.

The optimization added in r102952 was incorrect in the case where a style change
resulted in a positioned-movement-only layout but also required a repaint; it assumed
that a composited layer did not need to be repainted for a a positioned-movement-only layout.

Fix by making RenderObject::setNeedsLayoutForPositionedMovement() check whether the
style change requires a repaint, and calling setLayerNeedsFullRepaint() in that situation.

Test: compositing/repaint/positioned-movement.html

  • rendering/RenderLayer.h: RepaintStatus values do not need to be bit flags.
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::setStyle): Pass the old style to setNeedsPositionedMovementLayout().
(WebCore::RenderObject::styleDidChange): Ditto.

  • rendering/RenderObject.h:

(WebCore::RenderObject::setNeedsPositionedMovementLayout): Now takes a const RenderStyle*.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::diff): Remove a comment now that this bug is fixed.
(WebCore::RenderStyle::diffRequiresRepaint): Public wrapper for changeRequiresRepaint().
That function never uses contextSensitiveProperties so we can safely ignore them.

  • rendering/style/RenderStyle.h: Expose a way to call changeRequiresRepaint().


Reviewed by Darin Adler.

Test that does a positioned-movement-only layout and dumps a layer tree with
repaint rects.

  • compositing/repaint/positioned-movement-expected.txt: Added.
  • compositing/repaint/positioned-movement.html: Added.
8:06 AM Changeset in webkit [151621] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Try to fix iOS after last Pasteboard change.

  • platform/ios/PasteboardIOS.mm: (WebCore::Pasteboard::writeSelection): Put the new code inline here because the stringSelectionForPasteboard function is currently Mac-only.

Jun 15, 2013:

7:21 PM Changeset in webkit [151620] by Darin Adler
  • 6 edits in trunk/Source/WebCore

Move Pasteboard::getStringSelection to Editor, fixing a layering violation

Reviewed by Ryosuke Niwa.

  • editing/Editor.h: Added stringSelectionForPasteboardWithImageAltText.
  • editing/mac/EditorMac.mm:

(WebCore::Editor::stringSelectionForPasteboard): Moved code here from the Pasteboard
class, since all the Pasteboard class did really was turn around and call back here.
(WebCore::Editor::stringSelectionForPasteboardWithImageAltText): Added. Variant of
the function above that includes image alt text. Separate named functions are often
the best pattern for something like this unless there are many different combinations.

  • platform/Pasteboard.h: Remove the Mac-only Pasteboard::getStringSelectioon.
  • platform/ios/PasteboardIOS.mm:


  • platform/mac/PasteboardMac.mm:

Call the two new functions instead of the old Pasteboard::getStringSelection.

7:15 PM Changeset in webkit [151619] by Darin Adler
  • 3 edits in trunk/Source/WebCore

Support using clang instead of gcc for bindings preprocessing

Reviewed by Sam Weinig.

I couldn't build on my computer because I don't have gcc installed.
This is my cut at fixing it.

  • bindings/scripts/CodeGeneratorObjC.pm:

(ReadPublicInterfaces): Use clang if present.

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor): Ditto.

6:49 PM Changeset in webkit [151618] by fpizlo@apple.com
  • 8 edits in branches/dfgFourthTier/Source

Concurrent JIT shouldn't try to recompute the CodeBlockHash as part of debug dumps, since doing so may fail if dealing with a CachedScript that doesn't have its script string handy

Reviewed by Sam Weinig.


CodeBlock now caches m_hash, and the DFG Driver will force its computation if we're doing debug dumps of any kind.

Also made sure that CodeBlock::CodeBlock initializes all of its fields; it was previously missing the
initialization of m_capabilityLevelState.

  • bytecode/CodeBlock.cpp:


  • bytecode/CodeBlock.h:


  • bytecode/CodeBlockHash.cpp:


  • bytecode/CodeBlockHash.h:


  • dfg/DFGDriver.cpp:



Remove the broken hack for the concurrent JIT, since now the concurrent JIT won't use this code anymore.

No new tests because no new behavior.

  • loader/cache/CachedScript.cpp:


3:56 PM Changeset in webkit [151617] by dino@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash in supportsSnapshotting

Reviewed by Darin Adler.

Speculative fix for deferencing a null RefPtr in supportsSnapshotting.
It seems like it was possible to get in a state where the plugin machinery
would fire up and attempt to get a screenshot before there was an active
connection to the plugin process (usually under periods of high load, such
as opening a lot of tabs at once). In this case we're now returning false
from supportsSnapshotting, which will trigger the plugin to restart, but
that's better than requesting a snapshot on something that doesn't yet exist.

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::supportsSnapshotting): Guard for an empty connection object.

3:37 PM Changeset in webkit [151616] by fpizlo@apple.com
  • 26 edits in branches/dfgFourthTier/Source/JavaScriptCore

fourthTier: DFG should support op_switch_imm

Reviewed by Oliver Hunt.

Implement integer (i.e. immediate) switches in the DFG. Reduce the minimum
threshold for using op_switch.

Also get rid of edge code support, since we haven't used it in the year since
I introduced it. It was supposed to allow us to break critical edges late in
the backend, thus enabling global register allocation from an SSA-form graph.
But we aren't doing that so I figure we should just kill the code for now. It
would have made implementing switch harder.

  • assembler/AbstractMacroAssembler.h:


  • assembler/MacroAssemblerCodeRef.h:


  • bytecode/CodeBlock.cpp:


  • bytecode/JumpTable.h:


  • dfg/DFGAbstractState.cpp:


  • dfg/DFGBackwardsPropagationPhase.cpp:


  • dfg/DFGByteCodeParser.cpp:


  • dfg/DFGCapabilities.cpp:


  • dfg/DFGCommon.h:
  • dfg/DFGFixupPhase.cpp:


  • dfg/DFGGraph.cpp:


  • dfg/DFGGraph.h:


  • dfg/DFGJITCompiler.cpp:


  • dfg/DFGJITCompiler.h:


  • dfg/DFGNode.h:


  • dfg/DFGNodeType.h:


  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:


  • dfg/DFGSpeculativeJIT.cpp:


  • dfg/DFGSpeculativeJIT.h:


  • dfg/DFGSpeculativeJIT32_64.cpp:


  • dfg/DFGSpeculativeJIT64.cpp:


  • jit/JITStubs.cpp:


  • parser/Nodes.h:


3:29 PM Changeset in webkit [151615] by fpizlo@apple.com
  • 2 edits in branches/dfgFourthTier/Source/WTF

Printing a StringImpl* should really guard against NULL

Reviewed by Mark Hahnenberg.

  • wtf/PrintStream.cpp:


8:44 AM Changeset in webkit [151614] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed. Reorder my email addresses.

Patch by Bruno de Oliveira Abinader <Bruno de Oliveira Abinader> on 2013-06-15

  • Scripts/webkitpy/common/config/contributors.json:

Jun 14, 2013:

11:59 PM Changeset in webkit [151613] by robert@webkit.org
  • 3 edits
    2 adds in trunk

REGRESSION (r148367): Facebook and Twitter icons at macworld.com are stacked vertically, obscuring Twitter one

Reviewed by David Hyatt.


Test: fast/text/whitespace/inline-whitespace-wrapping-7.html

We were looking for line breaks in trailing collapsed whitespace even when inside a nowrap inline.
It's wrong to do this as we don't know yet if we will want or need to break - that decision has to
be deferred until we enter a part of the line that is autowrap.

  • rendering/RenderBlockLineLayout.cpp:



  • fast/text/whitespace/inline-whitespace-wrapping-7-expected.html: Added.
  • fast/text/whitespace/inline-whitespace-wrapping-7.html: Added.
9:42 PM Changeset in webkit [151612] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

background-color is not preserved when inserting a new paragraph

Patch by Lukasz Gajowy <l.gajowy@samsung.com> on 2013-06-14
Reviewed by Ryosuke Niwa.


The style isn't copied because background-color isn't defined as inheritable property.

Test: editing/inserting/insert-paragraph-not-preserving-background-color.html

  • editing/InsertParagraphSeparatorCommand.cpp:

Passing EditingPropertiesInEffect instead of implicit parameter OnlyEditingInheritableProperties.


Adding layout test and expected result to reproduce the issue.

  • editing/inserting/insert-paragraph-with-font-and-background-color-expected.txt: Added.
  • editing/inserting/insert-paragraph-with-font-and-background-color.html: Added.
4:05 PM Changeset in webkit [151611] by abarth@webkit.org
  • 3 edits
    3 adds in trunk

Threaded HTML parser can ASSERT in some situations

Reviewed by Ryosuke Niwa.


This patch merges https://chromium.googlesource.com/chromium/blink/+/3c0a112b42d72c7623f78463166dd7f04d680b4c

The parser is supposed to stop processing data when there's a pending
location change, but before this CL we would actually process the first
token from every chunk when there was a pending location change.

If the first token in a chunk was a "script" start tag, that would put
the tree builder into TextMode, which can only process character
tokens. If the next chunk starts with another start tag token, the tree
builder would be sad and hit an ASSERT.

This CL reorders a couple lines in HTMLDocumentParser so that we check
for pending location changes before processing any tokens. This change
stops us from processing the first token from each chunk while there is
a pending location change.

This issue can reproduce on any platform, but it reproduced often on
Android because mobile markup often elides spaces between consecutive
script tags. If there are space characters between the script tags,
then those space characters will be the first ones processes in the
chunk, which doesn't trigger the ASSERT.

Since we landed this patch in Blink, we've been able to reproduce this
issue on desktops as well. I spoke with rniwa in #webkit and he said
that WebKit doesn't have any current plans to enable the threaded
parser but that it was probably worth merging this patch anyway.

Test: http/tests/navigation/pending-location-change-assert.html

  • html/parser/HTMLDocumentParser.cpp:



  • http/tests/navigation/pending-location-change-assert-expected.txt: Added.
  • http/tests/navigation/pending-location-change-assert.html: Added.
  • http/tests/resources/slow-notify-done.php: Added.
3:49 PM Changeset in webkit [151610] by Patrick Gansterer
  • 17 edits in trunk

Introduce USE(WINGDI) for the Windows port

Reviewed by Ryosuke Niwa.

Using USE(WINGDI) instead of OS(WINCE) will allow us to
compile the GDI based Windows port on WinNT too.


  • Source/cmake/OptionsWinCE.cmake:


  • config.h:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/FontPlatformData.h:
  • platform/graphics/GlyphBuffer.h:


  • platform/graphics/Gradient.h:


  • platform/graphics/GraphicsContext.cpp:


  • platform/graphics/GraphicsContext.h:


  • platform/graphics/ImageBufferData.h:
  • platform/graphics/NativeImagePtr.h:


  • platform/graphics/Path.h:
  • platform/graphics/Pattern.h:
  • plugins/win/PluginViewWin.cpp:



  • wtf/Platform.h:
3:40 PM Changeset in webkit [151609] by jer.noble@apple.com
  • 10 edits in trunk/Source/WebCore

Report the memory cost of HTMLMediaElements to GC.

Reviewed by Darin Adler.

Report the extra memory cost of a HTMLMediaElement to the VM, in order to
encourage GC to occur after a media element is removed from the DOM.

Because we cannot know for sure the memory cost of our underlying media
framework objects, use the worst case scenario for the media memory cost:
the buffered percentage of movie * the total data length of the movie.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_reportedExtraMemoryCost.
(WebCore::HTMLMediaElement::removedFrom): Report the extra memory cost.

  • html/HTMLMediaElement.h:
  • html/TimeRanges.cpp:

(TimeRanges::totalDuration): Added convenience function.

  • html/TimeRanges.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::extraMemoryCost): Pass to MediaPlayerPrivate.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::extraMemoryCost): Default to 0.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::extraMemoryCost): Return the percentage

loaded * total data length.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
3:27 PM Changeset in webkit [151608] by jer.noble@apple.com
  • 5 edits in trunk/Source

Add support for AVFoundation-backed HTMLMediaElements in the WebVideoFullScreenController.

Reviewed by Eric Carlson.


Check for media elements with AVFoundation media types and create a AVPlayerLayer
rather than a QTMovieLayer.

  • platform/mac/WebVideoFullscreenController.h:
  • platform/mac/WebVideoFullscreenController.mm:

(-[WebVideoFullscreenController setupVideoOverlay:]): Take a CALayer rather than a

QTMovieLayer. Move the code which connects the layer with it's media source into

(-[WebVideoFullscreenController windowDidLoad]): Give the window's contentView a generic

CALayer instaead of a QTMovieLayer.

(-[WebVideoFullscreenController setMediaElement:]): Test whether the incoming media

element is backed by a QTMovie or an AVPlayer, and create the appropriate layer.

(-[WebVideoFullscreenController windowDidExitFullscreen]): Remove the observer of

AVPlayer's rate property.

(-[WebVideoFullscreenController observeValueForKeyPath:ofObject:change:context:]):

If the keyPath is "rate", call rateChanged.


Allow AVFoundation to be enabled even when the FullScreen API is disabled.

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

3:21 PM Changeset in webkit [151607] by enrica@apple.com
  • 8 edits
    1 add in trunk

WKPageFindStringMatches ignores the kWKFindOptionsBackwards option.


Reviewed by Darin Adler.

The API returns the matched ranges in the DOM order regardless of the
find direction, but the index of the first match after the user selection
should take the find direction into account.

Extended existing test in TestWebKitAPI.

  • page/Page.cpp:

(WebCore::Page::findStringMatchingRanges): Added handling of the Backwards case.

  • page/Page.h: Fixed incorrect name of the enum.


Reviewed by Darin Adler.

The API returns the matched ranges in the DOM order regardless of the
find direction, but the index of the first match after the user selection
should take the find direction into account.

Extended existing test in TestWebKitAPI.

  • Shared/API/c/WKFindOptions.h: Added enum for the case where there are

no matches after the user selection in the direction of the find.


Reviewed by Darin Adler.

The test now uses content with a selection and tests both
forwards and backward find as well as the case of a find
that has no matches after the user selection.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/FindMatches.mm:


  • TestWebKitAPI/Tests/WebKit2/findRanges.html: Added.
2:55 PM Changeset in webkit [151606] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r150651): Web Audio doesn't work at all (silence or squawks) on Mountain Lion

Reviewed by Eric Carlson.

r150651 disabled setting the buffer size to a large value, but in so doing, also
disabled setting the buffer size to a small value for Web Audio. Narrow the Mountain
Lion protection to just the <video> element case.

  • platform/audio/mac/AudioSessionManagerMac.cpp:


1:36 PM Changeset in webkit [151605] by rniwa@webkit.org
  • 9 edits in trunk/Source

Function names on Object.prototype should be common identifiers

Reviewed by Darin Adler.


Patch written by Sam Weinig. Make Object's prototype function names common identififers since they're used frequently.

  • runtime/CommonIdentifiers.h:
  • runtime/FunctionConstructor.cpp:


  • runtime/JSGlobalObject.cpp:


  • runtime/JSObject.h:
  • runtime/ObjectPrototype.cpp:


  • runtime/StringPrototype.cpp:



Use the added common identifiers.

  • bindings/js/JSDOMWindowBase.cpp:


1:13 PM Changeset in webkit [151604] by a.bah@samsung.com
  • 3 edits
    2 adds in trunk

Editing: wrong text position when you click enter on the text behind the image

Reviewed by Ryosuke Niwa.


When trying to break a line after an image followed by some text, contrary
to the expected behavior the text doesn't move to a new line, instead, the
caret position just shifts to the end of line.

As per the existing implementation for inserting a paragraph separator,
the insertion position obtained corresponds to the point after the image
Since the insertion position doesn't resolve to being offset in the
following text node (0 offset), no splitting of text occurs and the block
to be inserted is placed after the containing (start) block (thereby
causing the caret position to shift).

If the computed insertionPosition points to an element that shall be
ignored for editing purposes (i.e. cannot have a VisiblePosition inside
it), and the position lies either at the start or at the end of such
an element, we should move our Position either upstream or
downstream (respectively) so as to obtain a valid position which can
be used further for splitting of the text.

Test: editing/inserting/insert-paragraph-after-non-editable-node-before-text.html

  • editing/InsertParagraphSeparatorCommand.cpp:

Moving the insertionPosition either upstream or downstream, if the point
lies either at the start or at the end of the anchor node.
The ensuing position, if a text node, can then be used for splitting of
the text correctly.


  • editing/inserting/insert-paragraph-after-non-editable-node-before-text-expected.txt: Added.
  • editing/inserting/insert-paragraph-after-non-ediatble-node-before-text.html: Added.

Layout test added for verifying the insert paragraph behavior between an inline node
which is ignored for editing purposes and some text.

1:02 PM Changeset in webkit [151603] by commit-queue@webkit.org
  • 7 edits
    4 deletes in trunk/Source

[BlackBerry] Remove implementation of ContextMenu classes

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-06-14
Reviewed by Rob Buis.

This code is not being used so we can safely remove it.


  • PlatformBlackBerry.cmake:
  • platform/blackberry/ContextMenuBlackBerry.cpp: Removed.
  • platform/blackberry/ContextMenuItemBlackBerry.cpp: Removed.
  • platform/blackberry/LocalizedStringsBlackBerry.cpp:


  • PlatformBlackBerry.cmake:


  • Api/WebPage.cpp:


  • WebCoreSupport/ContextMenuClientBlackBerry.cpp: Removed.
  • WebCoreSupport/ContextMenuClientBlackBerry.h: Removed.
12:37 PM Changeset in webkit [151602] by timothy@apple.com
  • 3 edits in trunk/Websites/webkit.org

Shrink larger images to fit the width of the blog.

  • blog-files/new-inspector/hero-labeled.png:
  • blog-files/new-inspector/hero.png:
12:34 PM Changeset in webkit [151601] by Brent Fulgham
  • 5 edits in trunk/Source/WebCore

[Windows] Provide simple <meter> drawing logic for testing.

Reviewed by Anders Carlsson.


  • rendering/RenderThemeSafari.cpp: Simple test implementation

(WebCore::RenderThemeSafari::adjustMeterStyle): Added.
(WebCore::RenderThemeSafari::supportsMeter): Added.
(WebCore::RenderThemeSafari::meterSizeForBounds): Added.
(WebCore::RenderThemeSafari::paintMeter): Added.

  • rendering/RenderThemeSafari.h:
  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::progressBarTheme): Added.
(WebCore::RenderThemeWin::getClassicThemeData): Support meters.
(WebCore::RenderThemeWin::getThemeData): Support meter theme.
(WebCore::RenderThemeWin::adjustMeterStyle): Added.
(WebCore::RenderThemeWin::supportsMeter): Added.
(WebCore::RenderThemeWin::meterSizeForBounds): Added.
(WebCore::RenderThemeWin::paintMeter): Added.

  • rendering/RenderThemeWin.h:
10:18 AM Changeset in webkit [151600] by eric.carlson@apple.com
  • 4 edits
    2 adds in trunk

Potential use-after-free with an event fired at a HTMLMediaElement which is currently being deleted

Reviewed by Oliver Hunt.

Merge https://chromium.googlesource.com/chromium/blink/+/f4200a0093b3d9376f703961615359ec7fb712b4

If an event is created using as target an HTMLMediaElement which is
currently being deleted it becomes a heap-use-after free situation.

The GenericEventQueue instance is already owned by the HTMLMediaElement,
and there already is an underlying mechanism to set the target of the
event to NULL, if their target is owner of the queue.

In order to avoid creating this reference in the first place, we enqueue
the event with a NULL target to defer the refcount increment until the
timer for dispatching the event happens (which won't happen at all if
garbage collection is already destroying the objects).


Test: media/track/media-element-enqueue-event-crash.html

  • dom/GenericEventQueue.cpp:

(WebCore::GenericEventQueue::enqueueEvent): Don't ASSERT if the event has no target.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement): Close the event queue so it won't try to

dispatch any pending events.

(WebCore::HTMLMediaElement::scheduleEvent): Don't set the event target, it will happen just

prior to event dispatch.

(WebCore::HTMLMediaElement::stop): Close the event queue.


  • media/track/media-element-enqueue-event-crash-expected.txt: Added.
  • media/track/media-element-enqueue-event-crash.html: Added.
10:09 AM Changeset in webkit [151599] by dino@apple.com
  • 4 edits in trunk/Source/WebCore

Clicking on snapshotting plug-ins does not restart them

Follow-up review comments from Darin Adler, with some
discussion on IRC.

Sprinkle OVERRIDE on virtual functions where needed. Also
make sure that the Event is a MouseEvent before casting to it.

  • html/HTMLPlugInElement.h: Move defaultEventHandler back to protected and add OVERRIDE.
  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::defaultEventHandler): Check for MouseEvent and
use toMouseEvent().

  • html/HTMLPlugInImageElement.h: Sprinkle some OVERRIDEs, and move defaultEventHandler

to private.

9:52 AM Changeset in webkit [151598] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Remove front-end from the WebCore Xcode project.

Reviewed by Darin Adler.

  • WebCore.xcodeproj/project.pbxproj:
9:36 AM Changeset in webkit [151597] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

CSSParser::parseImageSet() doesn't need a parameter.

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-06-14
Reviewed by Darin Adler.

parseImageSet() can get m_valueList directly.
And minor fixes.

No new tests, no behavior change.

  • css/CSSParser.cpp:


  • css/CSSParser.h:
9:25 AM Changeset in webkit [151596] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[BlackBerry] Dropdown button UX updates.

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-06-14
Reviewed by Rob Buis.

JIRA 388652
Internally Reviewed by Jeff Rogers.

Change arrow assert.

  • platform/blackberry/RenderThemeBlackBerry.cpp:


8:00 AM Changeset in webkit [151595] by anilsson@rim.com
  • 16 edits in trunk/Source

[BlackBerry] LayerTiler fails to tile really big layers

Reviewed by Carlos Garcia Campos.

PR 273550


The cause for this bug was that LayerTiler computed which tiles are
visible by exhaustively mapping every tile to normalized device
coordinates and checking if it intersected the viewport. If there was a
lot of tiles, it would get stuck in this loop, iterating over all
tiles, for a very long time. Also, the visibility information was
transferred to the WebKit thread using mutexes, which added unnecessary
mutex contention to the mix.

Fixed by doing the reverse calculation, unprojecting the visible part
of the layer to layer coordinate space to find which tiles are visible.
Instead of doing a traditional unprojection of point to line and see
where the line intersects the layer, this patch uses the w-coordinates
of triangle vertices to perform "perspective correct texturing" of the
intersection points in device space, which is equivalent to
unprojection since perspective correct texturing computes a 2D
coordinate in (normalized) layer coordinate space which is easily
scaled up to the layer bounds and get the visible region expressed in
layer coordinate space.

The visible area is approximated by a rectangle, and a set of tiles
needing render are added to the mix, and we have a swappable data
structure so visbility can be transferred to WebKit thread without
mutexes, but instead using atomic swap.

No new tests, covered by existing tests.

  • platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:


  • platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:


  • platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.h:


  • platform/graphics/blackberry/LayerCompositingThread.cpp:


  • platform/graphics/blackberry/LayerCompositingThread.h:


  • platform/graphics/blackberry/LayerCompositingThreadClient.h:


  • platform/graphics/blackberry/LayerRenderer.cpp:


  • platform/graphics/blackberry/LayerTile.cpp:


  • platform/graphics/blackberry/LayerTile.h:


  • platform/graphics/blackberry/LayerTiler.cpp:


  • platform/graphics/blackberry/LayerTiler.h:


  • platform/graphics/blackberry/LayerUtilities.h:



Adapt to changes in LayerCompositingThreadClient interface.

  • Api/WebOverlay.cpp:


  • Api/WebOverlay_p.h:


7:53 AM Changeset in webkit [151594] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Compilation problems - hb.h not found

Unreviewed GTK+ build fix.

Patch by Andres Gomez <Andres Gomez> on 2013-06-14

  • GNUmakefile.am: Added freetype cflags for WebKit2 GTK+ Platform


7:50 AM Changeset in webkit [151593] by zarvai@inf.u-szeged.hu
  • 3 edits
    26 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Generate new baseline to some tests and bot greening.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-14

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt-5.0-wk2/animations/3d/change-transform-in-end-event-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-left-right-same-bottom-different-color-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-radius-percent-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-radius-wide-border-05-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-radius-with-box-shadow-01-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/border-radius-with-box-shadow-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css-generated-content/details-summary-before-after-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css-generated-content/details-summary-before-after-expected.txt: Added.
  • platform/qt-5.0-wk2/fast/forms/zoomed-controls-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-color-stop-units-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-generated-gradients-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-linear-angle-gradients-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-linear-right-angle-gradients-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-list-item-gradient-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-radial-gradients-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-radial-gradients3-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-repeating-end-fill-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-repeating-linear-gradient-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-repeating-radial-gradients-expected.png: Added.
  • platform/qt-5.0-wk2/fast/gradients/unprefixed-zero-range-repeating-gradient-hang-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/marker-orient-auto-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/marker-orient-auto-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/filters/feDropShadow-zero-deviation-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feDropShadow-zero-deviation-expected.txt: Added.
  • platform/qt-5.0-wk2/svg/filters/feGaussianBlur-zero-deviation-expected.png: Added.
  • platform/qt-5.0-wk2/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Added.
  • platform/qt/TestExpectations:
7:43 AM Changeset in webkit [151592] by Antoine Quint
  • 3 edits in trunk/Source/WebCore

[Mac] clicking caption track glyph should dismiss menu

We now correctly capture all click events while the captions track menu
is showing, and ensure that no other control in the media player can be
activated as the track list gets dismissed by clicking anywhere but on

Reviewed by Eric Carlson.

  • html/shadow/MediaControlsApple.cpp:

Make the controls panel non-interactive and track click events in the
capture phase also on the controls container itself such that we can
identify correctly whether a click in the <video> shadow tree is on
the track list or another element (the target could only be resolved
to a shadow tree node if the event is handled within the shadow tree).

Make the controls panel interactive again and remove the new click
event handler on the controls container.

Capture any click event that targets a node anywhere outside of the track
list container and its subtree and hide the track list in this condition.

Call handleClickEvent() on the media controls when a click event is handled.

  • html/shadow/MediaControlsApple.h:

New public handleClickEvent() API such that it can be called from

7:04 AM Changeset in webkit [151591] by anilsson@rim.com
  • 9 edits
    1 add in trunk/Source/WebCore

[BlackBerry] Accelerated compositing layers that intersect the image plane are incorrectly transformed

Reviewed by Carlos Garcia Campos.

PR 273550

The BlackBerry port used to mathematically project each corner of each
layer bounds rectangle, which gives the wrong results when the layer
intersects the image plane.

For display lists, we still got the correct appearance of the layer
contents, since the display list results in geometry that's transformed
in the vertex shader, on the GPU.

However, the transformed bounds are used for drawing the debug border,
performing visibility calculations on the CPU and drawing of WebGL,
masks/reflections and filters. Using the mathematical projection of
points that lie behind the image plane gives the wrong results.

The most important consequence of this bug was that the wrong area of
the layer would be considered visible, so a tiled layer would not
populate the right tiles (or any tiles at all).

Fixed by implementing something along the lines of the recipe in
section 6.2 of http://www.w3.org/TR/css3-transforms.

No new tests, manually testable by enabling debug border on

  • platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:


  • platform/graphics/blackberry/LayerCompositingThread.cpp:


  • platform/graphics/blackberry/LayerCompositingThread.h:


  • platform/graphics/blackberry/LayerFilterRenderer.cpp:


  • platform/graphics/blackberry/LayerRenderer.cpp:


  • platform/graphics/blackberry/LayerRenderer.h:


  • platform/graphics/blackberry/LayerRendererSurface.cpp:


  • platform/graphics/blackberry/LayerRendererSurface.h:


  • platform/graphics/blackberry/LayerUtilities.h: Added.


5:53 AM Changeset in webkit [151590] by zarvai@inf.u-szeged.hu
  • 28 edits
    48 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Some more rebaselining after r151205 and r150798.

  • platform/qt-5.0-wk2/css2.1/20110323/absolute-replaced-height-004-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/20110323/absolute-replaced-height-022-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Added.
  • platform/qt-5.0-wk2/css2.1/t170602-bdr-conflct-w-09-d-expected.png: Added.
  • platform/qt-5.0-wk2/css3/selectors3/html/css3-modsel-70-expected.png: Added.
  • platform/qt-5.0-wk2/css3/selectors3/xhtml/css3-modsel-131b-expected.png: Added.
  • platform/qt-5.0-wk2/css3/unicode-bidi-isolate-basic-expected.png:
  • platform/qt-5.0-wk2/editing/deleting/delete-image-002-expected.png:
  • platform/qt-5.0-wk2/editing/deleting/smart-delete-004-expected.png:
  • platform/qt-5.0-wk2/editing/selection/caret-rtl-2-expected.png:
  • platform/qt-5.0-wk2/editing/selection/caret-rtl-2-left-expected.png:
  • platform/qt-5.0-wk2/editing/selection/caret-rtl-expected.png:
  • platform/qt-5.0-wk2/editing/selection/caret-rtl-right-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/extend-selection-bidi-expected.png:
  • platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.png:
  • platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.png:
  • platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
  • platform/qt-5.0-wk2/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
  • platform/qt-5.0-wk2/fast/block/positioning/auto/vertical-rl/001-expected.png: Added.
  • platform/qt-5.0-wk2/fast/borders/rtl-border-05-expected.png:
  • platform/qt-5.0-wk2/fast/box-shadow/box-shadow-transformed-expected.png:
  • platform/qt-5.0-wk2/fast/css/error-in-last-decl-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/font-size-negative-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/namespaces/004-expected.png: Added.
  • platform/qt-5.0-wk2/fast/css/table-text-align-strict-expected.png: Added.
  • platform/qt-5.0-wk2/fast/dom/34176-expected.png:
  • platform/qt-5.0-wk2/fast/dom/inner-text-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label06-expected.png:
  • platform/qt-5.0-wk2/fast/forms/HTMLOptionElement_label07-expected.png:
  • platform/qt-5.0-wk2/fast/forms/button-cannot-be-nested-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/form-element-geometry-expected.png:
  • platform/qt-5.0-wk2/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
  • platform/qt-5.0-wk2/fast/forms/listbox-bidi-align-expected.png:
  • platform/qt-5.0-wk2/fast/forms/search-rtl-expected.png:
  • platform/qt-5.0-wk2/fast/forms/select-baseline-expected.png:
  • platform/qt-5.0-wk2/fast/inline/inline-box-background-expected.png:
  • platform/qt-5.0-wk2/fast/inline/inline-box-background-long-image-expected.png:
  • platform/qt-5.0-wk2/fast/inline/inline-box-background-repeat-x-expected.png:
  • platform/qt-5.0-wk2/fast/inline/inline-box-background-repeat-y-expected.png:
  • platform/qt-5.0-wk2/fast/invalid/014-expected.png: Added.
  • platform/qt-5.0-wk2/fast/overflow/childFocusRingClip-expected.png: Added.
  • platform/qt-5.0-wk2/fast/overflow/hit-test-overflow-controls-expected.png: Added.
  • platform/qt-5.0-wk2/fast/repaint/float-in-new-block-with-layout-delta-expected.png: Added.
  • platform/qt-5.0-wk2/fast/replaced/width-and-height-of-positioned-replaced-elements-expected.png: Added.
  • platform/qt-5.0-wk2/fast/runin/generated-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/multiple-captions-display-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/remove-td-display-none-expected.png: Added.
  • platform/qt-5.0-wk2/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
  • platform/qt-5.0-wk2/fast/text/international/unicode-bidi-plaintext-in-textarea-expected.png:
  • platform/qt-5.0-wk2/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-017-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-16-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-23-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-31-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-85-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/coords-trans-04-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/coords-units-02-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-marker-01-f-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/paths-data-01-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/script-handle-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-cond-03-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-defs-01-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-align-02-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-align-08-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-text-03-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/text-ctm-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/use-instanceRoot-event-listeners-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug81934-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/tables_bgcolor_red-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/tfoot_align_left-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_td_align_right-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/x_th_class-expected.png: Added.
4:43 AM Changeset in webkit [151589] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed TestExpectation cleanup

Unreviewed gardening.

Patch by Seokju Kwon <Seokju Kwon> on 2013-06-14

  • platform/qt-5.0-wk1/TestExpectations:
  • platform/qt/TestExpectations:
4:34 AM Changeset in webkit [151588] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Map rewind and fast forward keys to match GoogleTV

Reviewed by Jocelyn Turcotte.

Set the same keycode for media keys rewind and fast-forward as
GoogleTV does.

  • platform/qt/PlatformKeyboardEventQt.cpp:


4:26 AM Changeset in webkit [151587] by zandobersek@gmail.com
  • 2 edits in trunk/Source/Platform

Unreviewed GTK build fix.

  • GNUmakefile.am: Add the Freetype CFLAGS to the list of libPlatformGtk's CPPFLAGS. These are required as there are

specific build targets that end up including the HarfBuzz headers which are included in the Freetype CFLAGS variable.

3:59 AM Changeset in webkit [151586] by Carlos Garcia Campos
  • 24 edits in trunk/Source/WebCore

Avoid unnecessary data copies when loading subresources with DoNotBufferData option

Reviewed by Darin Adler.

When DoNotBufferData option is used to load a resource its data
is always copied before sending it to the CachedResource. Most
of the cached resources ignore the incremental data and wait
until all data has been received to save the ResourceBuffer,
that will be NULL anyway when DoNotBufferData is used.
CachedRawResource notifies its clients about the incremental
data, but it doesn't save the data when DoNotBufferData option
is present. In those cases we are unnecessary copying the data.

CachedResource::data has been split into
CachedResource::addDataBuffer() used for incremental data chunks
when buffering data, CachedResource::addData() used for
incremental data chunks when not buffering and
CachedResource::finishLoading() used to finish the loading. This
way we get rid of the allDataReceived boolean parameter and cached
resources not interested in incremenetal data chunks only have to
implement finishLoading() without having to check if all data have
been received or not.

SubresourceLoader::sendDataToResource was always called after
checking if loading multipart content, and then it was checked
again to decided whether to copy the data or not. It has been
removed in favor of calling directly the resource methods,
finishLoading for multipart content, addDataBuffer for data chunks
when buffering and addData for data chunks when not buffering.

No new functionality, covered by existing tests.

  • html/ImageDocument.cpp:

(WebCore::ImageDocumentParser::appendBytes): Update to API changes.
(WebCore::ImageDocumentParser::finish): Ditto.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didReceiveResponse): Call
finishLoading() for multipart content.
(WebCore::SubresourceLoader::didReceiveDataOrBuffer): Add data to
the resource using addDataBuffer or addData depending on whether
we are buffering or not.
(WebCore::SubresourceLoader::didFinishLoading): Call
finishLoading() for the cached resource instead of data.

  • loader/SubresourceLoader.h:
  • loader/cache/CachedCSSStyleSheet.cpp:


  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedFont.cpp:


  • loader/cache/CachedFont.h:
  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::isValidDecodedImageSize): Helper function
to check if the image size is valid.
(WebCore::CachedImage::addIncrementalDataBuffer): Helper function
to add incremental data buffer.
(WebCore::CachedImage::addDataBuffer): Call
(WebCore::CachedImage::addData): Create a ResourceBuffer and call

  • loader/cache/CachedImage.h:
  • loader/cache/CachedRawResource.cpp:

Returns a pointer to the data corresponding to the current chunk
and its length.
(WebCore::CachedRawResource::addDataBuffer): Assert to make sure
this is only called when BufferData option is present. Use
(WebCore::CachedRawResource::addData): Assert to make sure this is
only called when DoNotBufferData option is present.
(WebCore::CachedRawResource::notifyClientsDataWasReceived): Helper
private function to notify the clients about data received.

  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedResource.cpp:


  • loader/cache/CachedResource.h:
  • loader/cache/CachedSVGDocument.cpp:


  • loader/cache/CachedSVGDocument.h:
  • loader/cache/CachedScript.cpp:


  • loader/cache/CachedScript.h:
  • loader/cache/CachedShader.cpp:


  • loader/cache/CachedShader.h:
  • loader/cache/CachedTextTrack.cpp:


  • loader/cache/CachedTextTrack.h:
  • loader/cache/CachedXSLStyleSheet.cpp:


  • loader/cache/CachedXSLStyleSheet.h:
3:03 AM Changeset in webkit [151585] by vestbo@webkit.org
  • 2 edits in trunk/Tools

Remove myself from Qt build system watchlist

1:26 AM Changeset in webkit [151584] by zarvai@inf.u-szeged.hu
  • 2 edits
    73 adds in trunk/LayoutTests

[Qt] Unreviewed gardening. Rebaselining after r151205.

  • platform/qt-5.0-wk2/css2.1/t0805-c5519-ibrdr-r-00-a-expected.png: Added.
  • platform/qt-5.0-wk2/css3/selectors3/html/css3-modsel-39-expected.png: Added.
  • platform/qt-5.0-wk2/editing/execCommand/create-list-with-hr-expected.png: Added.
  • platform/qt-5.0-wk2/editing/inserting/4960120-2-expected.png: Added.
  • platform/qt-5.0-wk2/editing/selection/5057506-expected.png: Added.
  • platform/qt-5.0-wk2/fast/invalid/003-expected.png: Added.
  • platform/qt-5.0-wk2/fast/selectors/061-expected.png: Added.
  • platform/qt-5.0-wk2/fast/table/table-display-types-strict-expected.png: Added.
  • platform/qt-5.0-wk2/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.png: Added.
  • platform/qt-5.0-wk2/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-002-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-02-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-05-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-12-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-13-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-14-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-26-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-29-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-62-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/animate-elem-84-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/coords-trans-02-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/coords-units-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/filters-felem-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/filters-tile-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/interact-order-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/linking-a-03-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/linking-uri-02-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/linking-uri-03-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/masking-path-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/masking-path-03-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-fill-03-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-fill-05-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-marker-02-f-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/paths-data-06-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/paths-data-12-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/script-handle-02-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/script-handle-04-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-cond-01-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-dom-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-dom-03-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-frag-05-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/struct-group-03-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/styling-css-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/styling-pres-01-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-align-04-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-align-05-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-deco-01-b-expected.png: Added.
  • platform/qt-5.0-wk2/svg/W3C-SVG-1.1/text-fonts-02-t-expected.png: Added.
  • platform/qt-5.0-wk2/svg/custom/use-font-face-crash-expected.png:
  • platform/qt-5.0-wk2/tables/mozilla/bugs/bug727-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/tables_border_1-expected.png: Added.
  • platform/qt-5.0-wk2/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.png: Added.
1:20 AM Changeset in webkit [151583] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK][WK1] Missing symbols

Unreviewed GTK+ build fix.

Patch by Manuel Rego Casasnovas <Manuel Rego Casasnovas> on 2013-06-14

  • Source/autotools/symbols.filter: Added missing symbols needed when

compiling WK1.

12:55 AM Changeset in webkit [151582] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL] Fix build when DRAG_SUPPORT is set OFF

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-06-14
Reviewed by Gyuyoung Kim.

Add guard around Clipboard::declareAndWriteDragImage.

  • platform/efl/ClipboardEfl.cpp:

Jun 13, 2013:

9:58 PM Changeset in webkit [151581] by Simon Fraser
  • 6 edits in trunk/Source/WebCore

Sometimes we stick in slow scrolling mode even after leaving a page

Reviewed by Sam Weinig.

ScrollingCoordinator, and thus the scrolling state tree, is owned by Page,
and so persists when navigating between cached pages. We do give the ScrollingStateTree
a new ScrollingStateScrollingNode on navigation, however the ScrollingStateScrollingNode
would not have dirty flags set for, say, WheelEventHandlerCount if the document had
no wheel handlers. And because that dirty flag wasn't set, ScrollingTree::commitNewTreeState()
would fail to update m_hasWheelEventHandlers, so we'd remain in slow scrolling.

Fix by having ScrollingStateTree remember if it's been given a new root ScrollingStateScrollingNode,
and making ScrollingTree::commitNewTreeState() to the right thing in that case.

Also fix a couple of issues with the tiled scrolling indicator. First, on cached page
navigation, the indicator color would show the state for the old page, because
ScrollingCoordinatorMac::commitTreeState() checked scrollingTree()->hasWheelEventHandlers()
before the scrolling thread has committed the new scrolling tree.

Second, the color change would animate, so stop that.

Not testable, since tests can only dump the scrolling state tree.

  • page/scrolling/ScrollingStateTree.cpp:


  • page/scrolling/ScrollingStateTree.h:


  • page/scrolling/ScrollingTree.cpp:


  • page/scrolling/mac/ScrollingCoordinatorMac.mm:


  • platform/graphics/ca/mac/TileController.mm:

(-[WebTiledScrollingIndicatorLayer init]): Turn off borderColor implicit animations.

9:47 PM Changeset in webkit [151580] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[curl] Merge http response header values

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2013-06-13
Reviewed by Brent Fulgham.

According to the HTTP RFC some HTTP header values should be
merged if multiple entries for the same header exists.

  • platform/network/curl/ResourceHandleManager.cpp:


9:32 PM Changeset in webkit [151579] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Should not call firePaintRelatedMilestones() for "update control tints" paint pass

Reviewed by Sam Weinig.

When window activation changes, we do a fake paint pass that is just used to
invalidate controls that change their appearance in background windows. This fake
paint should not be recorded in the inspector, and it should not cause paint-related
milestones to fire.

  • page/FrameView.cpp:


8:43 PM Changeset in webkit [151578] by rniwa@webkit.org
  • 4 edits in trunk/Source

Remove LiteralIdentifierTable

Reviewed by Geoffrey Garen.

Removed LiteralIdentifierTable since it doesn't seem to have any perf. impact now.


  • runtime/Identifier.cpp:



  • wtf/WTFThreadData.h:
7:55 PM Changeset in webkit [151577] by gyuyoung.kim@samsung.com
  • 3 edits
    30 adds in trunk/LayoutTests

Unreviewed. Added new baselines for some tests as r151533 on EFL port.

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/editing/selection/select-across-readonly-input-1-expected.png: Added.
  • platform/efl/editing/selection/select-across-readonly-input-1-expected.txt: Added.
  • platform/efl/editing/selection/select-across-readonly-input-2-expected.png: Added.
  • platform/efl/editing/selection/select-across-readonly-input-2-expected.txt: Added.
  • platform/efl/editing/selection/select-across-readonly-input-3-expected.png: Added.
  • platform/efl/editing/selection/select-across-readonly-input-3-expected.txt: Added.
  • platform/efl/editing/selection/select-across-readonly-input-4-expected.png: Added.
  • platform/efl/editing/selection/select-across-readonly-input-4-expected.txt: Added.
  • platform/efl/editing/selection/select-across-readonly-input-5-expected.png: Added.
  • platform/efl/editing/selection/select-across-readonly-input-5-expected.txt: Added.
  • platform/efl/editing/selection/select-all-002-expected.png: Added.
  • platform/efl/editing/selection/select-all-002-expected.txt: Added.
  • platform/efl/editing/selection/select-all-003-expected.png: Added.
  • platform/efl/editing/selection/select-all-003-expected.txt: Added.
  • platform/efl/editing/selection/select-all-004-expected.png: Added.
  • platform/efl/editing/selection/select-all-004-expected.txt: Added.
  • platform/efl/editing/selection/select-all-005-expected.png: Added.
  • platform/efl/editing/selection/select-all-005-expected.txt: Added.
  • platform/efl/editing/selection/select-all-006-expected.png: Added.
  • platform/efl/editing/selection/select-all-006-expected.txt: Added.
  • platform/efl/editing/selection/select-box-expected.png: Added.
  • platform/efl/editing/selection/select-box-expected.txt: Added.
  • platform/efl/editing/selection/select-element-paragraph-boundary-expected.png: Added.
  • platform/efl/editing/selection/select-element-paragraph-boundary-expected.txt: Added.
  • platform/efl/editing/selection/select-from-textfield-outwards-expected.png: Added.
  • platform/efl/editing/selection/select-from-textfield-outwards-expected.txt: Added.
  • platform/efl/editing/selection/selection-actions-expected.png: Added.
  • platform/efl/editing/selection/selection-actions-expected.txt: Added.
  • platform/efl/editing/selection/selection-button-text-expected.png: Added.
  • platform/efl/editing/selection/selection-button-text-expected.txt: Added.
6:20 PM Changeset in webkit [151576] by dino@apple.com
  • 4 edits in trunk/Source/WebCore

Clicking on snapshotting plug-ins does not restart them

Reviewed by Simon Fraser.

HTMLPlugInElement has an event handler which would return
immediately if the element was not snapshotted, restarting
or playing. There is a case it missed, which was snapshotting
(WaitingForSnapshot to be precise). If we get a click in this
state then it should immediately restart.

  • html/HTMLPlugInElement.h: Move defaultEventHandler to public (we call it from the child class).
  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::defaultEventHandler): If there is a click on a snapshotting
plug-in, then call restart.

  • html/HTMLPlugInImageElement.h: Virtual defaultEventHandler declaration.
5:39 PM Changeset in webkit [151575] by zoltan@webkit.org
  • 10 edits in trunk/Source/WebCore

Use borderAndPadding[Before,After]() instead of border[Before,After]() + padding[Before,After]()

Reviewed by Dirk Schulze.

I added a new function called borderAndPaddingAfter(), since we already had borderAndPaddingBefore(). I changed
every separate additions to the old/new function. This change makes the code shorter and more straightforward.

Behavior hasn't changed, no new tests were needed.

  • rendering/InlineFlowBox.cpp:


  • rendering/RenderBlock.cpp:


  • rendering/RenderBlockLineLayout.cpp:


  • rendering/RenderBoxModelObject.h:


  • rendering/RenderMultiColumnBlock.cpp:


  • rendering/RenderMultiColumnSet.cpp:


  • rendering/RenderTableCell.cpp:


  • rendering/RenderTableSection.cpp:


  • rendering/RootInlineBox.cpp:


4:54 PM Changeset in webkit [151574] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

<http://webkit.org/b/117615> Web Inspector: JS PrettyPrinting Should have space between "do" and "{"

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-06-13
Reviewed by Timothy Hatcher.

  • UserInterface/CodeMirrorFormatters.js:
4:33 PM Changeset in webkit [151573] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

<http://webkit.org/b/117612> Web Inspector: "Search Resource Content" should cancel when I remove all text search text

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-06-13
Reviewed by Timothy Hatcher.

  • UserInterface/ResourceSidebarPanel.js:


3:47 PM Changeset in webkit [151572] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

Move Node::shouldUseInputMethod() to Element.

Reviewed by Antti Koivisto.

This method is only ever called on Elements, so move it off of Node.

  • dom/Element.cpp:


  • dom/Element.h:
  • dom/Node.cpp:
  • dom/Node.h:
  • html/HTMLInputElement.h:
  • html/HTMLTextAreaElement.h:
3:32 PM Changeset in webkit [151571] by mvujovic@adobe.com
  • 3 edits
    2 adds in trunk

[CSS Regions] Selection dragged from a region paints its background

Reviewed by Alexandru Chiculita.


Add a manual test for the painting of a dragged selection from a region. We don't have an
automated way to test this yet. This test is similar to the other manual selection dragging
tests (e.g. ManualTests/drag-image.html).

  • ManualTests/regions/drag-selection-painting.html: Added.


When a RenderFlowThread is in the selection paint phase, tell its layer to paint with the
selection only behavior. This way, only foregrounds and not backgrounds will be painted in
the dragged selection.

Manual test: ManualTests/regions/drag-selection-painting.html

  • rendering/RenderFlowThread.cpp:


2:09 PM Changeset in webkit [151570] by zoltan@webkit.org
  • 4 edits
    8 adds in trunk

[CSS Shapes][CSS Regions] Respect bottom positioned shapes and content adjustment inside shapes

Reviewed by David Hyatt.

In r150478 I added support for multiple positioned shape-insides on regions, this patch covers the cases when a shape
is positioned to the bottom of the region or the region contains a shape which forces the content to be adjusted inside
the shape (e.g. we have a triangle shape and the first line needs to be started at the first position where it fits).
I introduced a new helper function to update the current shape and the current line segments in the flow thread cases. With
this new helper function all the logic which calculates the segments for shape-inside on regions is located in one function.


Tests: fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes.html


  • rendering/RenderBlock.h: Add new helper's declaration
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::LineLayoutState::LineLayoutState): Add a member to carry adjustment for flow thread cases.
(WebCore::LineLayoutState::adjustedLogicalLineTop): Add new member.
(WebCore::LineLayoutState::setAdjustedLogicalLineTop): Add new setter for the new member.
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLine): Move flow thread case to its helper function.
(WebCore::RenderBlock::updateShapeAndSegmentsForCurrentLineInFlowThread): Added new helper for flow thread cases.
(WebCore::RenderBlock::adjustLogicalLineTopAndLogicalHeightIfNeeded): Save adjustment for flow thread cases.


  • fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes-expected.html: Added.
  • fast/regions/shape-inside/shape-inside-on-regions-block-content-overflow-bottom-positioned-multiple-shapes.html: Added.
  • fast/regions/shape-inside/shape-inside-on-regions-block-content-polygon-with-adjustment-expected.html: Added.
  • fast/regions/shape-inside/shape-inside-on-regions-block-content-polygon-with-adjustment.html: Added.
  • fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes-expected.html: Added.
  • fast/regions/shape-inside/shape-inside-on-regions-inline-content-overflow-bottom-positioned-multiple-shapes.html: Added.
  • fast/regions/shape-inside/shape-inside-on-regions-inline-content-polygon-with-adjustment-expected.html: Added.
  • fast/regions/shape-inside/shape-inside-on-regions-inline-content-polygon-with-adjustment.html: Added.
1:51 PM Changeset in webkit [151569] by fpizlo@apple.com
  • 30 edits
    12 adds in branches/dfgFourthTier

fourthTier: DFG should support op_in and it should use patching to make it fast


Reviewed by Geoffrey Garen.

Implement op_in in the DFG and give it patching. The code we generate is just
a jump on the hot path, and the slow paths generate stubs and link the jump to
them. I didn't want to bother with patching structures and load offsets and
the like, although I probably could have.

This is a ginormous speed-up on microbenchmarks for "in", obviously.

  • bytecode/CodeBlock.cpp:


  • bytecode/CodeBlock.h:


  • bytecode/StructureStubInfo.cpp:


  • bytecode/StructureStubInfo.h:


  • dfg/DFGAbstractState.cpp:


  • dfg/DFGByteCodeParser.cpp:


  • dfg/DFGCCallHelpers.h:


  • dfg/DFGCapabilities.cpp:


  • dfg/DFGFixupPhase.cpp:


  • dfg/DFGGPRInfo.h:


  • dfg/DFGJITCompiler.cpp:


  • dfg/DFGJITCompiler.h:


  • dfg/DFGNodeType.h:


  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:


  • dfg/DFGRepatch.cpp:


  • dfg/DFGRepatch.h:


  • dfg/DFGSlowPathGenerator.h:


  • dfg/DFGSpeculativeJIT.cpp:


  • dfg/DFGSpeculativeJIT.h:


  • dfg/DFGSpeculativeJIT32_64.cpp:


  • dfg/DFGSpeculativeJIT64.cpp:


  • runtime/JSCJSValue.cpp:


  • runtime/JSString.h:


  • runtime/Operations.h:



Reviewed by Geoffrey Garen.

Now if you pass a null StringImpl* then something will still get printed instead
of crashing. I figure that this is broadly useful for debug code, and I make use
of it in the JSC portion of this patch.

  • wtf/PrintStream.cpp:



Reviewed by Geoffrey Garen.

Test coverage for op_in performance.

  • fast/js/regress/in-four-cases-expected.txt: Added.
  • fast/js/regress/in-four-cases.html: Added.
  • fast/js/regress/in-one-case-false-expected.txt: Added.
  • fast/js/regress/in-one-case-false.html: Added.
  • fast/js/regress/in-one-case-true-expected.txt: Added.
  • fast/js/regress/in-one-case-true.html: Added.
  • fast/js/regress/in-two-cases-expected.txt: Added.
  • fast/js/regress/in-two-cases.html: Added.
  • fast/js/regress/script-tests/in-four-cases.js: Added.


  • fast/js/regress/script-tests/in-one-case-false.js: Added.


  • fast/js/regress/script-tests/in-one-case-true.js: Added.


  • fast/js/regress/script-tests/in-two-cases.js: Added.


12:03 PM Changeset in webkit [151568] by Christophe Dumez
  • 2 edits in trunk/Source/WebKit

Unreviewed build fix after rr151563.

Export needed symbols for Windows.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
11:34 AM Changeset in webkit [151567] by commit-queue@webkit.org
  • 1 edit
    16 adds in trunk/LayoutTests

Add tests to validate CSS Background Blending

This patch set removes the test case of adding bg blend mode through script, as it
is now part of bug#117223


Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.

  • css3/compositing/background-blend-mode-default-value.html: Added.
  • css3/compositing/background-blend-mode-different-image-formats.html: Added.
  • css3/compositing/background-blend-mode-image-color.html: Added.
  • css3/compositing/background-blend-mode-image-image.html: Added.
  • css3/compositing/background-blend-mode-single-layer-no-blending.html: Added.
  • css3/compositing/resources/ducky.jpg: Added.
  • platform/mac/css3/compositing/background-blend-mode-default-value-expected.png: Added.
  • platform/mac/css3/compositing/background-blend-mode-default-value-expected.txt: Added.
  • platform/mac/css3/compositing/background-blend-mode-different-image-formats-expected.png: Added.
  • platform/mac/css3/compositing/background-blend-mode-different-image-formats-expected.txt: Added.
  • platform/mac/css3/compositing/background-blend-mode-image-color-expected.png: Added.
  • platform/mac/css3/compositing/background-blend-mode-image-color-expected.txt: Added.
  • platform/mac/css3/compositing/background-blend-mode-image-image-expected.png: Added.
  • platform/mac/css3/compositing/background-blend-mode-image-image-expected.txt: Added.
  • platform/mac/css3/compositing/background-blend-mode-single-layer-no-blending-expected.png: Added.
  • platform/mac/css3/compositing/background-blend-mode-single-layer-no-blending-expected.txt: Added.
11:25 AM Changeset in webkit [151566] by commit-queue@webkit.org
  • 3 edits
    7 adds in trunk

[CSS Background Blending] Enable CSS Background blending for layers with SVGs.


The change implies adding the blending parameter for SVGImage

Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.

Tests: css3/compositing/background-blend-mode-image-svg.html


  • svg/graphics/SVGImage.cpp:



Adding tests for SVGs over simple background colors and images blending with SVGs.

Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.

  • css3/compositing/background-blend-mode-image-svg-expected.txt: Added.
  • css3/compositing/background-blend-mode-image-svg.html: Added.
  • css3/compositing/background-blend-mode-svg-color-expected.txt: Added.
  • css3/compositing/background-blend-mode-svg-color.html: Added.
  • css3/compositing/resources/red-circle.svg: Added.
  • platform/mac/css3/compositing/background-blend-mode-image-svg-expected.png: Added.
  • platform/mac/css3/compositing/background-blend-mode-svg-color-expected.png: Added.
11:24 AM Changeset in webkit [151565] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Updating the -webkit-background-blend-mode property dynamically does not trigger a redraw of the element.


Adding krit's fix: actual blending values should be compared, not the sets.

Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.

Test: css3/compositing/background-blend-mode-image-color-dynamic.html

  • rendering/style/FillLayer.cpp:



Adding test that sets background blend modes from script, after the page is loaded.

Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.

  • fast/repaint/background-blend-mode-image-color-dynamic-expected.html: Added.
  • fast/repaint/background-blend-mode-image-color-dynamic.html: Added.
11:22 AM Changeset in webkit [151564] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Headers and footers should be pinned to the left edge of the window when scrolling
horizontally, even when zoomed
-and corresponding-

Reviewed by Sam Weinig.

We really want to use the width value from scrollOffsetForFixedPosition() for the
banner with a scaled factor of 1. So if there is a different scale factor, re-
compute this value specifically for the banners.

  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:


11:13 AM Changeset in webkit [151563] by Christophe Dumez
  • 24 edits in trunk

Support byte and octet types in bindings generators

Reviewed by Kentaro Hara.


Add support for byte and octet IDL types to the bindings

No new tests, covered by existing layout tests and by new
bindings tests.

No new tests, covered by bindings tests and:

  • WebCore.exp.in: Export new symbols for mac port.
  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h: Add toInt8() / toUInt8()

methods to convert from JSValue to int8_t / uint8_t as
specified by Web IDL.

  • bindings/js/JSDataViewCustom.cpp: Remove custom code for

getInt8, getUInt8, setInt8, setUInt8 now that byte and octet
types are supported by the bindings generator.

  • bindings/scripts/CodeGeneratorCPP.pm:
  • bindings/scripts/CodeGeneratorGObject.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/test/CPP/WebDOMTestObj.cpp:
  • bindings/scripts/test/CPP/WebDOMTestObj.h:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestObj.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:
  • bindings/scripts/test/TestObj.idl: Add tests for byte and octet types.
  • html/canvas/DataView.idl: Remove [Custom] extended attribute for

getInt8, getUInt8, setInt8, setUInt8 and use newly supported byte / octet


Update fast/js/webidl-type-mapping.html to cover byte and octet
Web IDL types with and without [EnforceRange].

  • fast/js/webidl-type-mapping-expected.txt:
  • fast/js/webidl-type-mapping.html:
11:06 AM Changeset in webkit [151562] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Revert r150339 since it causes a hang while paused in the Web Inspector in other apps.


Reviewed by Joseph Pecoraro.

  • platform/mac/EventLoopMac.mm:


10:48 AM Changeset in webkit [151561] by Brent Fulgham
  • 2 edits in trunk/Source/WTF

[WinCairo] Correct FeatureDefines.h Default for ENABLE_VIEW_MODE_CSS_MEDIA

Reviewed by Dean Jackson.

  • wtf/FeatureDefines.h: The WinCairo port does not (currently) support Media elements,

so make sure we do not enable this feature by default for that port.

10:44 AM Changeset in webkit [151560] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Windows] Unreviewed gardening. Remove dangling 'strings' folder from solution.

  • WebCore.vcxproj/WebCore.vcxproj.filters: Get rid of 'strings' that was orphaned by

recent file reorganization.

10:33 AM Changeset in webkit [151559] by Brent Fulgham
  • 3 edits in trunk/Source/WTF

[Windows] Unreviewed gardening.

  • WTF.vcxproj/WTF.vcxproj: Add FeatureDefines.h to visible files.
  • WTF.vcxproj/WTF.vcxproj.filters: Ditto.
10:03 AM Changeset in webkit [151558] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Avoid unwanted thread hops in ScriptProcessorNode when 'onaudioprocess' listener is not set.

Patch by Praveen R Jadhav <praveen.j@samsung.com> on 2013-06-13
Reviewed by Darin Adler.

ScriptProcessorNode process operation continues to dispatch AudioProcessingEvent
even though 'onaudioprocess' listener is not set. This results in unwanted thread hops.
Code is optimized to dispatch AudioProcessingEvent only if the listener is set.

No new tests, already covered by existing tests.

  • Modules/webaudio/ScriptProcessorNode.cpp:


  • Modules/webaudio/ScriptProcessorNode.h:


10:02 AM Changeset in webkit [151557] by Brent Fulgham
  • 3 edits in trunk/Source/WebKit

[Windows] Revise WebKit project to show generated export definition file.

Reviewed by Mark Rowe.

  • WebKit.vcxproj/WebKit/WebKit.vcxproj: Add generated file.
  • WebKit.vcxproj/WebKit/WebKit.vcxproj.filters: Ditto
9:56 AM Changeset in webkit [151556] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WTF

Optimize String::fromUTF8 for ASCII

Reviewed by Brent Fulgham.

From Blink r152243 by <abarth@chromium.org>

Current String::fromUTF8() implementation converts 8 bit ASCII character into 16 bit.
Instead of always trying to convert into a 16 bit buffer, we can add a call to charactersAreAllASCII.
In the common case when characters are ASCII, we directly copy it into an 8 bit string buffer.

  • wtf/text/WTFString.cpp:


9:50 AM Changeset in webkit [151555] by mvujovic@adobe.com
  • 4 edits
    2 adds in trunk

[CSS Regions] -webkit-background-clip: text; does not clip the background in regions

Reviewed by Alexandru Chiculita.


This patch enables -webkit-background-clip: text; on regions.

Test: fast/regions/webkit-background-clip-text.html

  • rendering/RenderFlowThread.cpp:


Force black text if we're in the text clip paint phase. This makes sure the text's alpha
channel does not affect the final opacity of the background clipping result. Rather,
the text's alpha channel affects the amount of blending between the text color
and the background.

  • rendering/RenderRegion.cpp:


Factor out a function to check if we should paint the region contents in a particular
phase. Add "PaintPhaseTextClip" so that we draw the contents in the text clipping phase.


Call shouldPaintRegionContentsInPhase instead of doing the phase checks directly in this
function. Move, update, and clarify the surrounding comments.


  • fast/regions/webkit-background-clip-text-expected.html: Added.
  • fast/regions/webkit-background-clip-text.html: Added.
9:49 AM Changeset in webkit [151554] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk

[CSS Regions] Regions auto-height and absolute positioning bug

Patch by Anton Obzhirov <Anton Obzhirov> on 2013-06-13
Reviewed by David Hyatt.

During last layout that should update the auto-height regions new auto-height region height
is calculated correctly based on the text content, but it requires extra step
to reposition the render block after new logical height is set (correct logical height becomes
available only during last layout).

Tests: fast/regions/autoheight-abspos-bottom-align.html

  • rendering/RenderRegion.cpp:


9:47 AM Changeset in webkit [151553] by commit-queue@webkit.org
  • 2 edits in trunk

[GTK] [WK2] Found missing symbol when running some tests

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-06-13
Reviewed by Martin Robinson.

  • Source/autotools/symbols.filter: Added missing


9:20 AM Changeset in webkit [151552] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[WinCairo] Unreviewed build correction.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add

missing symbols needed by TestWebKitAPI on WinCairo build.

9:18 AM Changeset in webkit [151551] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[WinCairo] Unreviewed build correction.

  • WebCore.vcxproj/WebCoreCairo.props: Use proper WebKit_Libraries

environment variable, rather than older WebKitLibraries.

9:12 AM Changeset in webkit [151550] by Christophe Dumez
  • 2 edits in trunk/Source/WebCore

Avoid duplicate isInt32() / isUInt32() checks in JSDOMBindings

Reviewed by Geoffrey Garen.

Avoid duplicate isInt32() / isUInt32() checks in JSDOMBindings by
calling asInt32() / asUInt32() instead of toInt32() / toUInt32()
when we already know the value is a int32 / uint32.

No new tests, no behavior change.

  • bindings/js/JSDOMBinding.cpp:
9:01 AM EFLWebKit edited by bfulgham@webkit.org
9:00 AM SettingUpDevelopmentEnvironmentForN9 edited by bfulgham@webkit.org
8:59 AM TinOS edited by bfulgham@webkit.org
8:59 AM BuildingQtOnOSX edited by bfulgham@webkit.org
8:58 AM BuildingQtOnLinux edited by bfulgham@webkit.org
8:57 AM BuildingCairoOnWindows edited by bfulgham@webkit.org
8:37 AM Changeset in webkit [151549] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Setting overflow:hidden on position:absolute does not repaint hidden content

Patch by Yuki Sekiguchi <yuki.sekiguchi@access-company.com> on 2013-06-13
Reviewed by Simon Fraser.


Since a container which has overflow clip of RenderBox which has self painting layer doesn't have a rect of the RenderBox as visual overflow,
the container should not clip request repainting rect of the RenderBox.

Test: fast/repaint/change-overflow-and-display-of-relative.html

  • rendering/RenderBox.cpp:


  • rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::shouldUseClipForRepaint): If this has self painting layer, we should not clip for repaint.

  • rendering/RenderLayerModelObject.h:


  • fast/repaint/change-overflow-and-display-of-relative-expected.txt: Added.
  • fast/repaint/change-overflow-and-display-of-relative.html: Added.
8:29 AM Changeset in webkit [151548] by ggaren@apple.com
  • 11 edits in branches/dfgFourthTier/Source/JavaScriptCore

The Math object should not be polymorphic

Reviewed by Oliver Hunt.

Fill in the Math object eagerly, to avoid its structure changing during
execution. There are lots of ways to skin this cat; this one seemed
easiest, and justified given the relative hotness of math operations.

20% speedup on DSP-filtrr tests, small speedups on a few Kraken tests.

  • DerivedSources.make:
  • JavaScriptCore.order:
  • create_hash_table:
  • interpreter/CallFrame.h:

(JSC::ExecState::jsonTable): Removed the Math object's static table.

  • runtime/JSObject.cpp:


  • runtime/JSObject.h:
  • runtime/MathObject.cpp:


  • runtime/MathObject.h:

(JSC::MathObject::create): Set up the Math object at construction time.

  • runtime/VM.cpp:


  • runtime/VM.h: Removed the Math object's static table.
8:05 AM Changeset in webkit [151547] by commit-queue@webkit.org
  • 4 edits
    12 adds in trunk

[CSS Background Blending] Gradients don't blend with any of the layers behind.
First, allow the layers behind opaque gradients to be drawn, then add the blending filters
when working with gradients.



Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.

Tests: css3/compositing/background-blend-mode-gradient-color.html


  • platform/graphics/GeneratorGeneratedImage.cpp:


  • rendering/RenderBox.cpp:



Patch by Mihai Tica <mitica@adobe.com> on 2013-06-13
Reviewed by Dirk Schulze.

  • css3/compositing/background-blend-mode-gradient-color-expected.txt: Added.
  • css3/compositing/background-blend-mode-gradient-color.html: Added.
  • css3/compositing/background-blend-mode-gradient-gradient-expected.txt: Added.
  • css3/compositing/background-blend-mode-gradient-gradient.html: Added.
  • css3/compositing/background-blend-mode-gradient-image-expected.txt: Added.
  • css3/compositing/background-blend-mode-gradient-image.html: Added.
  • css3/compositing/background-blend-mode-multiple-background-layers-expected.txt: Added.
  • css3/compositing/background-blend-mode-multiple-background-layers.html: Added.
  • platform/mac/css3/compositing/background-blend-mode-gradient-color-expected.png: Added.
  • platform/mac/css3/compositing/background-blend-mode-gradient-gradient-expected.png: Added.
  • platform/mac/css3/compositing/background-blend-mode-gradient-image-expected.png: Added.
  • platform/mac/css3/compositing/background-blend-mode-multiple-background-layers-expected.png: Added.
7:42 AM Changeset in webkit [151546] by michael.bruning@digia.com
  • 4 edits in trunk

[Qt][Mac] Disable QTKit video on OS X.

Reviewed by Tor Arne Vestbø.


Deployment of the same Qt binaries to different
Mac OS X version makes it impossible to link against
the correct WebKitSystemInterface version at build time.

No new tests, no behavioural change.

  • WebCore.pri:


Deployment of Qt binaries to different Mac OS X
platform version makes it impossible to link against
the correct version of the WebKitSystemInterface library,
so we need to disable QTKit for media elements.

  • qmake/mkspecs/features/features.prf:
7:11 AM Changeset in webkit [151545] by commit-queue@webkit.org
  • 11 edits
    32 adds in trunk

Column balancing support in the region based multicol implementation


Start by setting the column height to the flow thread's height divided
by the number of columns. Then stretch the column height until
contents fits without creating overflowing columns, or until the
maximum allowed column height is reached, whichever comes first. This
may require several layout iterations (but normally only a
couple). For each time we stretch, stretch by the least amount
required to make a difference to which box goes where.

Also make sure that the columns get tall enough to honor orphans
and widows settings.

This change takes some tiny steps in preparing for multiple column
set support. There is also some minor cleanup and bugfixing; see
details below.

Patch by Morten Stenshorne <mstensho@opera.com> on 2013-06-13
Reviewed by David Hyatt.

Tests: fast/multicol/newmulticol/balance-images.html


  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::adjustBlockChildForPagination): If no lines
cross the boundaries, we need to report where blocks cross
instead, so that the column balancer knows how much to stretch
columns if necessary.

  • rendering/RenderBlock.h:
  • rendering/RenderFlowThread.h:
  • rendering/RenderMultiColumnBlock.cpp:


  • rendering/RenderMultiColumnBlock.h:


  • rendering/RenderMultiColumnFlowThread.cpp:


  • rendering/RenderMultiColumnFlowThread.h:


  • rendering/RenderMultiColumnSet.cpp: Get rid of

RenderMultiColumnSet::updateLogicalHeight() override. Make
RenderMultiColumnSet behave more like normal blocks, by having
computeLogicalHeight() calculate logical top in addition to
height, just like any other block.
(WebCore::RenderMultiColumnSet::heightAdjustedForSetOffset): This
method will become more meaningful once we add support for
multiple column sets.
repaintFlowThreadContent() could end up in an infinite loop
because columnIndexAtOffset() could return UINT_MAX
(subtracting 1 from unsigned 0, which columnCount() could return),
which an unsigned integer obviously can never become larger
than. Also always call columnIndexAtOffset() if we want to get the
column index for some offset, rather than doing it on our own
sometimes. To make this work also during layout, we cannot just
return the last column created so far if we're past it, since
adding new columns is exactly what we want to do at this point.

  • rendering/RenderMultiColumnSet.h:



Patch by Morten Stenshorne <mstensho@opera.com> on 2013-06-13
Reviewed by David Hyatt.

  • fast/multicol/newmulticol/balance-images-expected.txt: Added.
  • fast/multicol/newmulticol/balance-images.html: Added.
  • fast/multicol/newmulticol/balance-maxheight1-expected.txt: Added.
  • fast/multicol/newmulticol/balance-maxheight1.html: Added.
  • fast/multicol/newmulticol/balance-maxheight2-expected.txt: Added.
  • fast/multicol/newmulticol/balance-maxheight2.html: Added.
  • fast/multicol/newmulticol/balance1-expected.txt: Added.
  • fast/multicol/newmulticol/balance1.html: Added.
  • fast/multicol/newmulticol/balance2-expected.txt: Added.
  • fast/multicol/newmulticol/balance2.html: Added.
  • fast/multicol/newmulticol/balance3-expected.txt: Added.
  • fast/multicol/newmulticol/balance3.html: Added.
  • fast/multicol/newmulticol/balance4-expected.txt: Added.
  • fast/multicol/newmulticol/balance4.html: Added.
  • fast/multicol/newmulticol/balance5-expected.txt: Added.
  • fast/multicol/newmulticol/balance5.html: Added.
  • fast/multicol/newmulticol/balance6-expected.txt: Added.
  • fast/multicol/newmulticol/balance6.html: Added.
  • fast/multicol/newmulticol/balance7-expected.txt: Added.
  • fast/multicol/newmulticol/balance7.html: Added.
  • fast/multicol/newmulticol/balance8-expected.txt: Added.
  • fast/multicol/newmulticol/balance8.html: Added.
  • fast/multicol/newmulticol/balance9-expected.txt: Added.
  • fast/multicol/newmulticol/balance9.html: Added.
  • fast/multicol/newmulticol/cell-shrinkback-expected.html: Added.
  • fast/multicol/newmulticol/cell-shrinkback.html: Added.
  • fast/multicol/newmulticol/columns-shorthand-parsing-expected.html: Added.
  • fast/multicol/newmulticol/columns-shorthand-parsing.html: Added.
  • fast/multicol/newmulticol/orphans-and-widows-balance-expected.txt: Added.
  • fast/multicol/newmulticol/orphans-and-widows-balance.html: Added.
  • fast/multicol/newmulticol/single-line-expected.html: Added.
  • fast/multicol/newmulticol/single-line.html: Added.
5:53 AM Changeset in webkit [151544] by zarvai@inf.u-szeged.hu
  • 3 edits in trunk/LayoutTests

[Qt] Unreviewed gardening. Unskipping passing test and move to the right place.

Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-06-13

  • platform/qt-5.0-wk2/TestExpectations:
  • platform/qt/TestExpectations:
2:45 AM Changeset in webkit [151543] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[ARM] Unreviewed gardening, skip one more test to paint the bot green.

  • platform/qt-arm/TestExpectations:
2:17 AM Changeset in webkit [151542] by zandobersek@gmail.com
  • 3 edits in trunk/LayoutTests

Unreviewed GTK gardening.
Adding failure expectations for most of the current failures.

  • platform/gtk-wk1/TestExpectations:
  • platform/gtk/TestExpectations:
1:23 AM Changeset in webkit [151541] by commit-queue@webkit.org
  • 8 edits in trunk

[EFL][WK2] Wrong context menu and popup menu positions when scroll is applied

Patch by Michał Pakuła vel Rutka <Michał Pakuła vel Rutka> on 2013-06-13
Reviewed by Noam Rosenthal.


WebKit2 EFL uses fixed layout - because of this ScrollView::contentsToWindow, does
not take scroll into account, as it is meant to be handled by UI application.
When popup and context menu are created, after calling contentsToWindow their position
are not adjusted to page scroll.
Added two functions to EwkView and WKView, converting contents position to user viewport
coordinates, to adjust popup and context menu positions.

  • UIProcess/API/C/CoordinatedGraphics/WKView.cpp:


  • UIProcess/API/C/CoordinatedGraphics/WKView.h:
  • UIProcess/API/efl/EwkView.cpp:


  • UIProcess/CoordinatedGraphics/WebView.cpp:


  • UIProcess/CoordinatedGraphics/WebView.h:


Remove unnecessary code adjusting context menu position to webview position.
Now position is calculcated in EwkView.

  • MiniBrowser/efl/main.c:


12:52 AM Changeset in webkit [151540] by ryuan.choi@samsung.com
  • 7 edits in trunk/Source/WebKit/efl

[EFL] Refactor ewk_view_scroll to remove internal structure.

Reviewed by Gyuyoung Kim.

After removed c-ism from WebKit/Efl, There is no reason to keep internal
structures like Ewk_Scroll_Request.
This patch refactored ewk_view_scroll to use WTF instead of Ewk_Scroll_Request
and scrolls of SmartData.

  • WebCoreSupport/ChromeClientEfl.cpp:


  • ewk/ewk_view.cpp: Removed functions to manage Ewk_Scroll_Request.


  • ewk/ewk_view.h: Removed Ewk_Scroll_Request which is private structure.
  • ewk/ewk_view_private.h:


  • ewk/ewk_view_single.cpp:


  • ewk/ewk_view_tiled.cpp:


12:15 AM Changeset in webkit [151539] by Lucas Forschler
  • 5 edits in trunk/Source


12:04 AM Changeset in webkit [151538] by Lucas Forschler
  • 1 copy in tags/Safari-537.45

New Tag.

Jun 12, 2013:

11:10 PM Changeset in webkit [151537] by Csaba Osztrogonác
  • 2 edits in trunk/LayoutTests

[ARM] Unreviewed gardening, skip one more test to paint the bot green.

  • platform/qt-arm/TestExpectations:
10:58 PM Changeset in webkit [151536] by Brent Fulgham
  • 3 edits in trunk/WebKitLibraries

[WinCairo] Unreviewed build correction.

  • win/tools32/vsprops/WinCairo.props: Switch from using the $WebKitLibraries environment variable to the newer $WebKit_Libraries.
  • win/tools32/vsprops/debug_wincairo.props: Ditto.
6:48 PM Changeset in webkit [151535] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Turn on WinEWS test now that AppleWin port uses new-run-webkit-tests.

  • Scripts/webkitpy/common/config/ews.json:
6:15 PM Changeset in webkit [151534] by roger_fong@apple.com
  • 4 edits
    3 moves in trunk/Websites/webkit.org

Update webkit.org build instructions for Apple Windows port.

Reviewed by Brent Fulgham.

  • building/build.html:
  • building/debug.html:
  • building/launch-debugger-vs2005.png: Removed.
  • building/launch-debugger-vs2010.png: Copied from webkit.org/building/launch-debugger-vs2005.png.
  • building/set-as-startup-project-vs2005.png: Removed.
  • building/set-as-startup-project-vs2010.png: Copied from webkit.org/building/set-as-startup-project-vs2005.png.
  • building/set-debugging-properties-vs2005.png: Removed.
  • building/set-debugging-properties-vs2010.png: Copied from webkit.org/building/set-debugging-properties-vs2005.png.
  • building/tools.html:
6:13 PM Changeset in webkit [151533] by gyuyoung.kim@samsung.com
  • 3 edits
    29 adds in trunk/LayoutTests

Unreviewed. EFL Gardening. Needs to add new baseline for some tests, which are passing on EFL bots.

  • platform/efl-wk1/TestExpectations:
  • platform/efl/TestExpectations:
  • platform/efl/editing/selection/3690703-2-expected.png: Added.
  • platform/efl/editing/selection/3690703-2-expected.txt: Added.
  • platform/efl/editing/selection/3690703-expected.png: Added.
  • platform/efl/editing/selection/3690703-expected.txt: Added.
  • platform/efl/editing/selection/3690719-expected.png: Added.
  • platform/efl/editing/selection/3690719-expected.txt: Added.
  • platform/efl/editing/selection/4397952-expected.png: Added.
  • platform/efl/editing/selection/4397952-expected.txt: Added.
  • platform/efl/editing/selection/4895428-3-expected.png: Added.
  • platform/efl/editing/selection/4895428-3-expected.txt: Added.
  • platform/efl/editing/selection/4975120-expected.png: Added.
  • platform/efl/editing/selection/4975120-expected.txt: Added.
  • platform/efl/editing/selection/5007143-2-expected.png: Added.
  • platform/efl/editing/selection/5007143-2-expected.txt: Added.
  • platform/efl/editing/selection/5007143-expected.png: Added.
  • platform/efl/editing/selection/5007143-expected.txt: Added.
  • platform/efl/editing/selection/5057506-expected.png: Added.
  • platform/efl/editing/selection/5057506-expected.txt: Added.
  • platform/efl/editing/selection/5195166-1-expected.txt: Added.
  • platform/efl/editing/selection/7152-2-expected.png: Added.
  • platform/efl/editing/selection/7152-2-expected.txt: Added.
  • platform/efl/editing/selection/caret-before-select-expected.png: Added.
  • platform/efl/editing/selection/caret-before-select-expected.txt: Added.
  • platform/efl/editing/selection/caret-ltr-right-expected.png: Added.
  • platform/efl/editing/selection/caret-ltr-right-expected.txt: Added.
  • platform/efl/editing/selection/caret-rtl-2-left-expected.png: Added.
  • platform/efl/editing/selection/caret-rtl-2-left-expected.txt: Added.
  • platform/efl/editing/selection/caret-rtl-right-expected.png: Added.
  • platform/efl/editing/selection/caret-rtl-right-expected.txt: Added.
6:00 PM Changeset in webkit [151532] by Brent Fulgham
  • 2 edits in trunk/Websites/planet.webkit.org

Remove irrelevant blog from Planet WebKit.

Reviewed by Mark Rowe.

  • config.ini: Remove Chromium blog from planet.webkit.org
5:59 PM Changeset in webkit [151531] by Brent Fulgham
  • 2 edits in trunk/Source/WTF

[Windows] Activate supported C++11 Features for VS2010

Reviewed by Anders Carlsson.

  • wtf/Compiler.h: Turn on rvalue references and static_assert

when compiling with VS2010 (or newer)

5:34 PM Changeset in webkit [151530] by andersca@apple.com
  • 18 edits in trunk/Source

Remove the notion of inactive plug-ins

Reviewed by Tim Horton.


Remove RenderEmbeddedObject::PluginInactive and the replacement text.

  • English.lproj/Localizable.strings:
  • platform/LocalizedStrings.cpp:
  • platform/LocalizedStrings.h:
  • rendering/RenderEmbeddedObject.cpp:


  • rendering/RenderEmbeddedObject.h:


Remove code that deals with inactive plug-ins.

  • WebCoreSupport/WebChromeClient.mm:


  • WebCoreSupport/WebFrameLoaderClient.mm:



Remove code that deals with inactive plug-ins. We still keep around the kWKPluginLoadPolicyInactive API enum for now.

  • Shared/Plugins/PluginModuleInfo.h:
  • UIProcess/API/C/WKAPICast.h:


  • UIProcess/Plugins/PluginInfoStore.cpp:
  • UIProcess/Plugins/PluginInfoStore.h:
  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:


  • UIProcess/WebPageProxy.cpp:


  • WebProcess/WebCoreSupport/WebChromeClient.cpp:


  • WebProcess/WebPage/WebPage.cpp:


5:10 PM BuildingOnWindows edited by roger_fong@apple.com
5:05 PM Changeset in webkit [151529] by Brent Fulgham
  • 18 edits
    7 adds in trunk

[Windows] Implement Accessibility2 APIs in Windows.

Reviewed by Anders Carlsson.


  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj: Add new IAccessible2 IDL files.
  • WebKit.vcxproj/Interfaces/Interfaces.vcxproj.filters: Ditto.
  • WebKit.vcxproj/Interfaces/InterfacesCommon.props: Reference new Accessible2 folder.
  • WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj: Build IAccessible2 symbols.
  • WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.filters: Ditto.


  • AccessibleBase.cpp: Add stubs for IAccessible2 interface, replace attributeValue

method with get_attribute from IAccessible2 API.

  • AccessibleBase.h: Ditto.
  • AccessibleDocument.cpp: Revise signatures for IAccessible2.
  • AccessibleDocument.h: Ditto.
  • AccessibleImage.cpp: Revise signatures for IAccessible2.
  • AccessibleImage.h: Ditto.
  • Interfaces/Accessible2: Added.
  • Interfaces/Accessible2/Accessible2.idl: Added.
  • Interfaces/Accessible2/Accessible2_2.idl: Added.
  • Interfaces/Accessible2/AccessibleApplication.idl: Added.
  • Interfaces/Accessible2/AccessibleRelation.idl: Added.
  • Interfaces/Accessible2/AccessibleStates.idl: Added.
  • Interfaces/Accessible2/IA2CommonTypes.idl: Added.
  • Interfaces/AccessibleComparable.idl:
  • Interfaces/WebKit.idl: Reference IAccessible2 types.
  • WebFrame.cpp:

(WebFrame::accessible): Pass window handle to IAccessible types.

4:55 PM Changeset in webkit [151528] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Change default Traditional Chinese serif font on 10.9

Reviewed by Alexey Proskuryakov.

Change default font on newer versions of OS X.

  • page/mac/SettingsMac.mm:

(WebCore::Settings::initializeDefaultFontFamilies): Use 'Songti TC'
on 10.9 and above.

4:53 PM Changeset in webkit [151527] by Hugo Parente Lima
  • 2 edits in trunk/Source/WebKit2

[GTK] Explicit include glib.h to avoid compilation errors if libsoup isn't used.

Reviewed by Martin Robinson.

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
4:48 PM Changeset in webkit [151526] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Change default Simplified Chinese serif font on 10.9

Reviewed by Alexey Proskuryakov.

Change default font on newer versions of OS X.

  • page/mac/SettingsMac.mm:

(WebCore::Settings::initializeDefaultFontFamilies): Use 'Songti SC'
instead of 'STSong' on newer systems.

4:30 PM Changeset in webkit [151525] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

Fix crashes due to failed ImageBuffer allocation

Reviewed by Andreas Kling.

From Blink r152268 by <pdr@chromium.org>

A crash can happen due to a failed ImageBuffer allocation in
SVGImage::drawPatternForContainer(). Added a check for that failed allocation.

  • svg/graphics/SVGImage.cpp:


4:28 PM BuildingOnWindows edited by bfulgham@webkit.org
4:20 PM BuildingOnWindows edited by bfulgham@webkit.org
4:19 PM BuildingOnWindows edited by bfulgham@webkit.org
4:13 PM BuildingOnWindows edited by bfulgham@webkit.org
4:08 PM BuildingOnWindows edited by bfulgham@webkit.org
3:56 PM BuildingOnWindows edited by roger_fong@apple.com
3:48 PM BuildingOnWindows edited by roger_fong@apple.com
3:46 PM BuildingOnWindows edited by roger_fong@apple.com
3:44 PM BuildingOnWindows edited by roger_fong@apple.com
3:29 PM BuildingOnWindows edited by roger_fong@apple.com
2:39 PM Changeset in webkit [151524] by commit-queue@webkit.org
  • 6 edits in trunk

[atk] Replace deprecated call to atk_document_get_locale() in DumpRenderTree

Patch by Eduardo Lima Mitev <elima@igalia.com> on 2013-06-12
Reviewed by Martin Robinson.


Override the get_object_locale() method of WebkitAccessibleWrapperAtk's internal
AtkObject, to include custom implementations for AtkDocument and AtkText objects,
taking the logic as-is from AtkDocument::get_document_locale() and DumpRenderTree's
AccessibilityUIElementAtk::language(), respectively.

Apart from improving encapsulation, this avoids calling deprecated get_document_locale()

No new functionality, no new tests.

  • accessibility/atk/WebKitAccessibleInterfaceDocument.cpp:

(webkitAccessibleDocumentInterfaceInit): Chains implementation of
AtkDocument::get_document_locale() to AtkObject::get_object_locale().

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetObjectLocale): Add implementation of locale resolution for
objects of type AtkDocument and AtkText.
(webkitAccessibleClassInit): Override AtkObject::get_object_locale() method.


Locale resolution is moved to WebKitAccessibleWrapperAtk using
AtkObject::get_object_locale() API. Now, implementation of
AccessibilityUIElement::language() in both DumpRenderTree and WebKitTestRunner can
be leveraged to get_object_locale() of AtkObject.

Apart from improving encapsulation, this avoids calling deprecated get_document_locale()

No new functionality, no new tests.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::language): Leverage locale resolution to

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::language): Leverage locale resolution to

1:46 PM Changeset in webkit [151523] by Hugo Parente Lima
  • 3 edits in trunk/Tools

Remove last bits of GYP from build-webkit and update-webkit scripts

Reviewed by Ryosuke Niwa.

  • Scripts/build-webkit:
  • Scripts/update-webkit:
1:18 PM Changeset in webkit [151522] by zandobersek@gmail.com
  • 6 edits in trunk/Source

[GTK] Move more build targets for source code that's free of layer violations into libPlatform

Reviewed by Martin Robinson.


  • GNUmakefile.am: Add additional Source/WebCore/platform subdirectories to the list of the directories

that are specific to the platform layer but still located in WebCore. Add Enchant and Freetype dependencies'
CFLAGS to the list of libPlatform CPPFLAGS. Add GStreamer dependency's CFLAGS to the list of libPlatformGtk


No new tests - no new functionality.

  • GNUmakefile.list.am: Move more build targets under the platform_sources and platformgtk_sources listing.

These build targets represent source files that are already free of platform layer violations and are as such
ready to be pushed down from the WebCore layer into the Platform layer.


  • GNUmakefile.am: Add GStreamer dependency's CFLAGS to the list of libPlatformGtk2 CPPFLAGS.
1:07 PM Changeset in webkit [151521] by Hugo Parente Lima
  • 1 edit
    1 delete in trunk/Tools

Remove forgotten unused Tools/Script/make-gypi script

Reviewed by Ryosuke Niwa.

This script isn't used since the GYP removal from WebKit.

  • Scripts/make-gypi: Removed.
12:58 PM Changeset in webkit [151520] by commit-queue@webkit.org
  • 7 edits in trunk/Source

"Open Video in New Window" doesn't make sense in fullscreen

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-12
Reviewed by Beth Dakin.


No new tests needed.

  • WebCore.exp.in: Added WebKit2 hook for mediaIsInFullscreen() method.


Adds method mediaIsInFullscreen() that checks if a media element is in
fullscreen mode, which is needed to decide when to display the
"Open Video in New Window" context menu item.

  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.cpp:

(WKBundleHitTestResultMediaIsInFullscreen): Added.
Hooks into new InjectedBundleHitTestResult::mediaIsInFullscreen() method.

  • WebProcess/InjectedBundle/API/c/WKBundleHitTestResult.h:
  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.cpp:

(WebKit::InjectedBundleHitTestResult::mediaIsInFullscreen): Added.
Checks if media element is in fullscreen.

  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
12:52 PM Changeset in webkit [151519] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Accessibility code assumes an area element's parent is a map element

Reviewed by Chris Fleizach.


We can't make such an assumption. Scripts can insert any element between area and map elements.

Merge https://chromium.googlesource.com/chromium/blink/+/b6f486284f08c52904701c93e1ec0b7d6e76af9f.

Test: accessibility/image-map-with-indirect-area-crash.html

  • accessibility/AccessibilityRenderObject.cpp:



Add a regression test from https://chromium.googlesource.com/chromium/blink/+/b6f486284f08c52904701c93e1ec0b7d6e76af9f.

  • accessibility/image-map-with-indirect-area-crash-expected.txt: Added.
  • accessibility/image-map-with-indirect-area-crash.html: Added.
12:20 PM Changeset in webkit [151518] by robert@webkit.org
  • 3 edits
    2 adds in trunk

Source/WebCore: Whitespace between inlines with nowrap and a shrink-to-fit parent gets a line-break when it shouldn't

Reviewed by David Hyatt.

Test: fast/text/whitespace/inline-whitespace-wrapping-8.html

A no-wrap inline shouldn't include trailing space when deciding whether it fits on a line.
Likewise when we finish iterating through the objects on a line we should clear our linebreak
if the only thing that prevents us fitting on the line is our collapsed trailing whitespace.

Removing the trailing space from this measurement means we need to watch out for potential
breaks between no-wrap inlines, in particular if we leave a no-wrap inline ignoring spaces
and enter an autowrap inline then we need to mark the beginning of the autowrap inline
as a potential linebreak. The test fast/text/whitespace/inline-whitespace-wrapping-5.html
is an example of such a case.

  • rendering/RenderBlockLineLayout.cpp:


LayoutTests: Whitespace between inlines with nowrap and a shrink-to-fit parent line-break incorrectly

Reviewed by David Hyatt.

  • fast/text/whitespace/inline-whitespace-wrapping-8-expected.html: Added.
  • fast/text/whitespace/inline-whitespace-wrapping-8.html: Added.
11:59 AM Changeset in webkit [151517] by commit-queue@webkit.org
  • 16 edits
    4 adds in trunk

[CSS Shapes] rectangle and inset-rectangle do not properly handle rx and ry

Patch by Bem Jones-Bey <Bem Jones-Bey> on 2013-06-12
Reviewed by Dirk Schulze.


If ry is not supplied, it now defaults to the rx value. Also, if rx
and ry are not supplied, they default to 0px. This also has the effect
that the computed style for any rectangle or inset-rectangle now
contains all six parameters.

If rx > width/2 then it is clamped to width/2, and if ry > height/2,
then it is clamped to height/2. This happens at layout time because
given mixed units and relative units, that is the only time this
determination can be made.

Tests: fast/exclusions/shape-inside/shape-inside-rounded-rectangle-large-radius.html


  • css/BasicShapeFunctions.cpp:

(WebCore::valueForBasicShape): Remove checks for undefined, since rx

and ry cannot be undefined in BasicShapes anymore.

(WebCore::basicShapeForValue): If radii are undefined in CSS, set

default values in the BasicShape, per the spec.

  • rendering/ExclusionShape.cpp:

(WebCore::ensureRadiiDoNotOverlap): Utility method to ensure radii

don't overlap.

(WebCore::ExclusionShape::createExclusionShape): Remove defaulting to

zero, clamp radii per the spec.

  • rendering/style/BasicShapes.cpp:

(WebCore::BasicShapeRectangle::path): Remove defaulting.
(WebCore::BasicShapeRectangle::blend): Ditto.
(WebCore::BasicShapeInsetRectangle::path): Ditto.
(WebCore::BasicShapeInsetRectangle::blend): Ditto.

  • rendering/style/BasicShapes.h:

(WebCore::BasicShapeRectangle::BasicShapeRectangle): Remove defaulting

to undefined for radii.

(WebCore::BasicShapeRectangle::setCornerRadiusX): Add assert to

prevent undefined.

(WebCore::BasicShapeRectangle::setCornerRadiusY): Add assert to

prevent undefined.

(WebCore::BasicShapeInsetRectangle::BasicShapeInsetRectangle): Ditto.
(WebCore::BasicShapeInsetRectangle::setCornerRadiusX): Add assert to

prevent undefined.

(WebCore::BasicShapeInsetRectangle::setCornerRadiusY): Add assert to

prevent undefined.


Update tests to check for the rx and ry conditions.

  • fast/exclusions/parsing/parsing-shape-inside-expected.txt: New results.
  • fast/exclusions/parsing/parsing-shape-outside-expected.txt: New results.
  • fast/exclusions/parsing/script-tests/parsing-shape-inside.js: Update

to reflect that the computed value now always has rx and ry.

  • fast/exclusions/parsing/script-tests/parsing-shape-outside.js: Ditto.
  • fast/exclusions/parsing/script-tests/parsing-test-utils.js: Ditto.
  • fast/exclusions/resources/rounded-rectangle.js:

(genLeftRightRoundedRectFloatShapeOutsideRefTest): Factor out left and

right into separate methods so that they can be used in tests that
only have left floats or only right floats.

(genLeftRoundedRectFloatShapeOutsideRefTest): Ditto.
(genRightRoundedRectFloatShapeOutsideRefTest): Ditto.

  • fast/exclusions/shape-inside/shape-inside-animation-expected.txt: New results.
  • fast/exclusions/shape-inside/shape-inside-animation.html: Change to

reflect new computed style value.

  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-large-radius-expected.html: Added.
  • fast/exclusions/shape-inside/shape-inside-rounded-rectangle-large-radius.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius-expected.html: Added.
  • fast/exclusions/shape-outside-floats/shape-outside-floats-rounded-rectangle-large-radius.html: Added.

Note that the expected test here uses shape-inside, because we
really are just testing that the behavior is the same as a
shape-inside with rx and ry set to 50%, and it turned out to be
very hard to construct an expected result that didn't use
shape-inside and wasn't off by a pixel.

  • css3/masking/clip-path-animation.html: Update expected value.
  • css3/masking/clip-path-animation-expected.txt: New results.
11:57 AM Changeset in webkit [151516] by Brent Fulgham
  • 9 edits in trunk

[Windows] Support Title UI Element Accessibility Attribute

Reviewed by Anders Carlsson.


Fixes: accessibility/list-item-role.html


  • accessibility/win/AccessibilityObjectWrapperWin.cpp:

(WebCore::AccessibilityObjectWrapper::accessibilityAttributeValue): Extend to support access
for the Title UI Element object.

  • accessibility/win/AccessibilityObjectWrapperWin.h: Revise interface to use Variant output,

which is more in keeping with the Mac's 'id' method signature.


  • AccessibleBase.cpp:

(AccessibleBase::attributeValue): Extend to handle Title UI Element.

  • AccessibleBase.h: Revise signature to use a variant argument.
  • Interfaces/AccessibleComparable.idl: Revise interface to use variant
11:53 AM Changeset in webkit [151515] by timothy@apple.com
  • 1 edit
    17 adds in trunk/Websites/webkit.org

Add new Web Inspector images for a blog post.

  • blog-files/new-inspector/activity-viewer.png: Added.
  • blog-files/new-inspector/codemirror.png: Added.
  • blog-files/new-inspector/console.png: Added.
  • blog-files/new-inspector/hero-labeled.png: Added.
  • blog-files/new-inspector/hero.png: Added.
  • blog-files/new-inspector/layer-borders.png: Added.
  • blog-files/new-inspector/layers.png: Added.
  • blog-files/new-inspector/navigation-bar.png: Added.
  • blog-files/new-inspector/open-sign.png: Added.
  • blog-files/new-inspector/reasons.png: Added.
  • blog-files/new-inspector/save.png: Added.
  • blog-files/new-inspector/source-map.png: Added.
  • blog-files/new-inspector/styles.png: Added.
  • blog-files/new-inspector/toolbar-context-menu.png: Added.
  • blog-files/new-inspector/toolbar-docked.png: Added.
  • blog-files/new-inspector/toolbar.png: Added.
11:41 AM Changeset in webkit [151514] by leoyang@rim.com
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Use RefPtr for HTMLInputElement inside CredentialTransformData

Reviewed by Carlos Garcia Campos.

In CredentialTransformData we should use RefPtr for
m_userNameElement, m_passwordElement and m_oldPasswordElement
because otherwise the elements could go away when the form
elements get destroyed.

Also add *const* for the parameter of CredentialTransformData::findPasswordFormFields().

No functionalities changed no new tests.

  • WebCoreSupport/CredentialTransformData.cpp:


  • WebCoreSupport/CredentialTransformData.h:
11:28 AM Changeset in webkit [151513] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CSS Shaders] Animations and transitions should use validated custom programs

Run filters used for animations and transitions through RenderLayer::computeFilterOperations
in order to validate custom filter operations.

Patch by Ralph Thomas <ralpht@gmail.com> on 2013-06-12
Reviewed by Alexandru Chiculita.

No new tests as no platform can run custom filters with accelerated animations yet.

  • rendering/RenderLayerBacking.cpp:


10:33 AM Changeset in webkit [151512] by commit-queue@webkit.org
  • 13 edits in trunk/Source

Allow for toggling fullscreen on <video> elements

Patch by Ruth Fong <ruth_fong@apple.com> on 2013-06-12
Reviewed by Dean Jackson.


This patch adds the ability for fullscreen
context menu item on <video> elements to switch between "Enter Fullscreen"
and "Exit Fullscreen" and behave appropriately.

No new tests. media/context-menu-action.html,
which has been disabled by bug 116651, is used to test context menus.

  • English.lproj/Localizable.strings: Add "Exit Fullscreen" string.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::toggleFullscreenState): Added to appropriately enter/exit fullscreen.

  • html/HTMLMediaElement.h:
  • page/ContextMenuController.cpp:
  • platform/ContextMenuItem.h:
  • platform/LocalizedStrings.cpp:
  • platform/LocalizedStrings.h:

Updated to rename variables more appropriately to reflect the toggle-ability of video fullscreen.

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::mediaIsInFullscreen): Added to check if an element
was a media element in fullscreen.
(WebCore::HitTestResult::toggleMediaFullscreenState): Added to hook into

  • rendering/HitTestResult.h:


  • Shared/API/c/WKContextMenuItemTypes.h:
  • Shared/API/c/WKSharedAPICast.h:

Added variables to support the toggle-ability of the fullscreen
video context menu item.

10:32 AM Changeset in webkit [151511] by Csaba Osztrogonác
  • 2 edits
    3 deletes in trunk/LayoutTests

[ARM] Unreviewed gardening, unskip now passing tests and try to paint the bot green.

  • platform/qt-arm/TestExpectations:
  • platform/qt-arm/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Removed.
  • platform/qt-arm/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Removed.
  • platform/qt-arm/svg/batik/text/textOnPath3-expected.txt: Removed.
10:23 AM Changeset in webkit [151510] by sergio@webkit.org
  • 3 edits
    2 adds in trunk

Skipping {}, () and [] blocks while error recovering in CSS

Reviewed by Darin Adler.

From Blink r150201 and r150755 by <serya@chromium.org>


Test: fast/css/parsing-expr-error-recovery.html

The CSS parser should properly recover from invalid {}, () and []
blocks skipping them instead of discarding the whole declaration
as invalid. This merge is actually made of two different changes
from Blink, the original one that fixes the bug and another one
which refactors a bit the code making it more legible.

  • css/CSSGrammar.y.in:


  • fast/css/parsing-expr-error-recovery-expected.txt: Added.
  • fast/css/parsing-expr-error-recovery.html: Added.
10:22 AM Changeset in webkit [151509] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

JSExport header documentation substitutes "semicolon" for "colon"

Patch by Conrad Shultz <Conrad Shultz> on 2013-06-12
Reviewed by Mark Hahnenberg.

  • API/JSExport.h:

Fix a couple typos.

10:17 AM Changeset in webkit [151508] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Invalidate the ProcessLauncher when the process is terminated before it has finished launching

Reviewed by Anders Carlsson.

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:

(WebKit::ProcessLauncher::terminateProcess): If process is still
launching just invalidate the launcher. Reset the process
identifier after killing the process.

10:11 AM Changeset in webkit [151507] by commit-queue@webkit.org
  • 9 edits in trunk

[BlackBerry] Remove dead WebDOM code

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-06-12
Reviewed by Anders Carlsson.

BlackBerry PR 347565
Internally reviewed by Charles Wei.


  • Source/cmake/OptionsBlackBerry.cmake:


  • PlatformBlackBerry.cmake:


  • Api/WebPage.cpp:
  • Api/WebPage.h:
  • WebCoreSupport/AboutDataEnableFeatures.in:
  • WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
10:01 AM Changeset in webkit [151506] by sergio@webkit.org
  • 5 edits in trunk/LayoutTests

[css exclusions] fast/css/variables/var-inside-shape.html is failing

Reviewed by Alexandru Chiculita.

Some shapes were incorrectly defined, there was a "rectange"
instead of a "rectangle" and also the number of parameters and
their types was wrong. Apart from that, both the CSS exclusions
and CSS variables settings were not enabled at runtime.

Some extra text was also added to the divs in order to verify that
the CSS exclusions are working properly.

  • fast/css/variables/var-inside-shape-expected.html:
  • fast/css/variables/var-inside-shape.html:
  • platform/efl/TestExpectations: Removed var-inside-shape.html.
  • platform/gtk/TestExpectations: Ditto.
9:46 AM Changeset in webkit [151505] by dbates@webkit.org
  • 10 edits
    1 copy
    3 adds in trunk

window.find() case-insensitive search doesn't match diacritical marks

Patch by Daniel Bates <dabates@apple.com> on 2013-06-12
Reviewed by Darin Adler.


Currently, a case-insensitive window.find() search will return true for a word w
(e.g. café) with diacritical characters when w appears on the page without
diacritical marks (e.g. cafe). This leads to bad results, especially when
searching for a non-English word (e.g. qué) where the presence of an accented
character(s) may change the meaning of the word. Instead window.find() should
return false when case-insensitively matching a word with diacritical marks to
the same word without diacritical marks.

Test: fast/text/find-diacritical-mark.html

  • editing/TextIterator.cpp:



Added test to use window.find() to find a search string in text, where either
the search string or text (or both) contain diacritical characters.

Additionally, updated tests LayoutTests/fast/text/find-soft-hyphen.html
and LayoutTests/editing/execCommand/findString-diacriticals.html based on the
new behavior of window.find(). Moved function testFind() from LayoutTests/fast/text/script-tests/find-backwards.js
to its own file, LayoutTests/fast/text/resources/test-find.js, so that this function can
be used by both tests LayoutTests/fast/text/find-{backwards, diacritical-mark}.html.

  • LayoutTests/editing/execCommand/findString-diacriticals.html: Update test based on the new

behavior of window.find().

  • fast/text/find-backwards.html: Include external JavaScript file test-find.js.
  • fast/text/find-case-folding-expected.txt: Rebase result; expected failure.
  • fast/text/find-case-folding.html: Add comment to see bug #117548 with regards to expected failure.
  • fast/text/find-diacritical-mark-expected.txt: Added.
  • fast/text/find-diacritical-mark.html: Copied from LayoutTests/fast/text/find-backwards.html.
  • fast/text/find-soft-hyphen-expected.txt: Rebase result.
  • fast/text/resources/test-find.js: Added.


  • fast/text/script-tests/find-backwards.js: Moved function testFind() from here to

file fast/text/resources/test-find.js and modified it to take an additional argument to
toggle search case sensitivity.

  • fast/text/script-tests/find-diacritical-mark.js: Added.
  • fast/text/script-tests/find-soft-hyphen.js: Update test based on the new behavior of window.find().
9:30 AM Changeset in webkit [151504] by msaboff@apple.com
  • 29 edits in branches/dfgFourthTier/Source/JavaScriptCore

Unreviewed, rolled back in http://trac.webkit.org/changeset/151362.

I fixed that the llint exception process was happening in common slow paths
even when call via the baseline JIT. Also moved emitSlow_* methods to
be right after the corresponding emit_* method.

2013-06-07 Michael Saboff <msaboff@apple.com>

fourthTier: The baseline jit and LLint should use common slow paths

9:06 AM Changeset in webkit [151503] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/blackberry

[BlackBerry] Smarter algorithm to determine the backingstore rect


Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-06-12
Reviewed by Rob Buis.

So far, the backingstore tile geometry allocation was
pretty straightforward: We would start off from the
current viewport and append all available tiles into
the current scrolling direction from there.

This will usually work well enough, but has the downside
of discarding all the tiles in the opposite direction.
Also, tiles very close to the viewport will often get
discarded even if the user only scrolls very slowly.

This patch completely revamps the algorithm for
determining where the backingstore should be positioned.

The general idea is that we construct a "desired rect"
based on the viewport and inflate it into all four
directions according to the current scroll momentum.
This rectangle will be similarly large as a backingstore
tile geometry rectangle might be, by using the
approximate number of pixels that are available in the
given number of tiles.

The proportions for extending the rectangle from the
viewport are influenced by different factors, including
scroll momentum, viewport ratio, available space in the
overall contents rectangle, and natural bias for the
"down" direction.

In practice, this results in a backingstore that is
roughly evenly distributed around the viewport when no
movement is happening, and will gradually narrow down
and extend into the scroll direction at a higher momentum.

The final tile geometry is constructed by trying fit
the tiles into the desired rect in a way that maximizes
the area of its intersection. There are a few parameters
that can be tweaked, the ones in this patch seem to
handle most cases well enough to minimize checkerboarding.

As an additional bonus, a rectangle-based tiling strategy
can more easily be adopted for accelerated compositing,
which currently operates on a simpler algorithm that also
inflates the viewport but does not take scrolling into

  • Api/BackingStore.cpp:


  • Api/BackingStore_p.h:


8:48 AM Changeset in webkit [151502] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[Qt][CSS Regions] fast/regions/overflow-size-change-with-stacking-context.html fails

Unreviewed, Qt Gardening.

Unskip test that is now passing on the bots.

Patch by Javier Fernandez <jfernandez@igalia.com> on 2013-06-12

  • platform/qt/TestExpectations:
8:37 AM Changeset in webkit [151501] by mark.lam@apple.com
  • 3 edits in branches/dfgFourthTier

Merged from http://svn.webkit.org/repository/webkit/trunk:

r148746 | jberlin@webkit.org | 2013-04-19 08:21:49 -0700 (Fri, 19 Apr 2013) | 3 lines

Fix expectations added in r148720.

8:03 AM Changeset in webkit [151500] by mark.lam@apple.com
  • 23 edits
    4 deletes in branches/dfgFourthTier/Source

Unreviewed, rolled out r151456, r151420:



It causes layout test failures.


It causes layout test failures.

7:49 AM WebKitIDL edited by Christophe Dumez
Remove [IndexedGetter] and [NumericIndexedGetter] after r151499 (diff)
7:41 AM Changeset in webkit [151499] by Christophe Dumez
  • 58 edits in trunk/Source/WebCore

Support latest Web IDL indexed property getters

Reviewed by Kentaro Hara.

Support latest Web IDL indexed property getters:

Drop support for outdated [IndexedGetter] and [NumericIndexedGetter]
IDL extended attributes. Since the new getter format specifies the
return type, the bindings generator is now smart enough to know if
the indexed getter is numeric or not on its own.

Based on Blink r149564 by <kojih@chromium.org>.

No new tests, no behavior change.

  • Modules/filesystem/EntryArray.idl:
  • Modules/filesystem/EntryArraySync.idl:
  • Modules/gamepad/GamepadList.idl:
  • Modules/mediasource/SourceBufferList.idl:
  • Modules/speech/SpeechGrammarList.idl:
  • Modules/speech/SpeechRecognitionResult.idl:
  • Modules/speech/SpeechRecognitionResultList.idl:
  • bindings/scripts/CodeGenerator.pm:


  • bindings/scripts/CodeGeneratorJS.pm:


  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/TestEventTarget.idl:
  • bindings/scripts/test/TestTypedArray.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSValueList.idl:
  • css/MediaList.idl:
  • css/StyleSheetList.idl:
  • css/WebKitCSSFilterValue.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • css/WebKitCSSTransformValue.idl:
  • dom/ClientRectList.idl:
  • dom/DOMNamedFlowCollection.idl:
  • dom/DOMStringList.idl:
  • dom/DataTransferItemList.idl:
  • dom/NamedNodeMap.idl:
  • dom/NodeList.idl:
  • dom/PropertyNodeList.idl:
  • dom/TouchList.idl:
  • fileapi/FileList.idl:
  • html/DOMSettableTokenList.idl:
  • html/DOMTokenList.idl:
  • html/HTMLAllCollection.idl:
  • html/HTMLCollection.idl:
  • html/HTMLFormControlsCollection.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLPropertiesCollection.idl:
  • html/HTMLSelectElement.idl:
  • html/RadioNodeList.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/canvas/Uint8ClampedArray.idl:
  • html/track/AudioTrackList.idl:
  • html/track/TextTrackCueList.idl:
  • html/track/TextTrackList.idl:
  • html/track/TextTrackRegionList.idl:
  • html/track/VideoTrackList.idl:
  • page/PerformanceEntryList.idl:
  • page/SpeechInputResultList.idl:
  • plugins/DOMMimeTypeArray.idl:
  • plugins/DOMPlugin.idl:
  • plugins/DOMPluginArray.idl:
7:37 AM Changeset in webkit [151498] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Coordinated Graphics] Remove unused headers in CoordinatedLayerTreeHostProxy

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-06-12
Reviewed by Noam Rosenthal.

  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
6:50 AM Changeset in webkit [151497] by kseo@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Unskipping passing tests.

  • platform/gtk-wk2/TestExpectations:
6:39 AM Changeset in webkit [151496] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] MiniBrowser to automatically download "non-showable" documents when left click in link

Patch by Andres Gomez <Andres Gomez> on 2013-06-12
Reviewed by Carlos Garcia Campos.

MiniBrowser now starts automatically the download of the documents
that cannot be shown just by WebKit itself on link left clicking.

  • MiniBrowser/gtk/BrowserWindow.c:

(webViewDecidePolicy): handled the

5:49 AM WebKitIDL edited by Christophe Dumez
Rename [CallWith] to [ConstructorCallWith] for interfaces (diff)
5:25 AM Changeset in webkit [151495] by Christophe Dumez
  • 22 edits in trunk/Source/WebCore

Rename [CallWith] to [ConstructorCallWith] for IDL interfaces

Reviewed by Kentaro Hara.

Rename [CallWith] to [ConstructorCallWith] for IDL interfaces as the
meaning is slightly different when [CallWith] is used for IDL operations
or attributes. This improves IDL readability a bit and makes it more
directly understandable.

Also removed [ConstructorCallWith] statements from interfaces with custom
constructors or no constructor, as this does not have any effect.

No new tests, no behavior change.

  • Modules/filesystem/FileWriter.idl:
  • Modules/mediasource/MediaSource.idl:
  • Modules/mediasource/SourceBufferList.idl:
  • Modules/mediastream/MediaStream.idl:
  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/notifications/Notification.idl:
  • Modules/speech/SpeechRecognition.idl:
  • Modules/speech/SpeechSynthesisUtterance.idl:
  • Modules/webaudio/OfflineAudioContext.idl:
  • Modules/websockets/WebSocket.idl:
  • bindings/scripts/CodeGeneratorJS.pm:


  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/TestInterface.idl:
  • dom/MessageChannel.idl:
  • fileapi/FileReader.idl:
  • html/MediaController.idl:
  • html/track/TextTrackCue.idl:
  • page/EventSource.idl:
  • workers/SharedWorker.idl:
  • workers/Worker.idl:
  • xml/XMLHttpRequest.idl:
4:44 AM Changeset in webkit [151494] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

[Qt] Set windows key-code for multimedia keys

Reviewed by Jocelyn Turcotte.

Map Qt Key-events to their defined windows keycode values.

  • platform/qt/PlatformKeyboardEventQt.cpp:


4:34 AM Changeset in webkit [151493] by sergio@webkit.org
  • 3 edits in trunk/Source/WebCore

[Soup] Use ResourceLoadPriority

Reviewed by Carlos Garcia Campos.

Use the ResourceLoadPriority from the ResourceRequest to set the
correnpondent priority to each SoupMessage.

No new tests required as there is no change in functionality,
we're just enabling a new feature in the underlying network stack.

  • platform/network/soup/ResourceHandleSoup.cpp:


  • platform/network/soup/ResourceRequest.h:

(WebCore::toSoupMessagePriority): Translates ResourceLoadPriority
to SoupMessagePriority.

1:51 AM Changeset in webkit [151492] by zandobersek@gmail.com
  • 4 edits in trunk

[GTK] Remove the WebCoreLayer(Gtk2).a archives before regenerating them

Reviewed by Carlos Garcia Campos.


  • GNUmakefile.am: When generating the WebCoreLayerGtk2.a archive from all the dependency archives, remove the

current archive (if any). Updating an existent archive in an incremental build is not bulletproof and can lead
to corrupt archives and subsequent build failures. On the other hand, the archive generation is not expensive
and produces a working archive without problems even on incremental builds.


  • TestWebKitAPI/GNUmakefile.am: When generating the WebCoreLayer.a archive from all the dependency archives,

remove the current archive (if any). Updating an existent archive in an incremental build is not bulletproof
and can lead to corrupt archives and subsequent build failures. On the other hand, the archive generation is
not expensive and produces a working archive without problems even on incremental builds.

1:45 AM Changeset in webkit [151491] by zandobersek@gmail.com
  • 16 edits in trunk/Source

Remove memoryInfoEnabled, quantizedMemoryInfoEnabled settings

Reviewed by Darin Adler.


  • page/Settings.in: Remove the memoryInfoEnabled and the quantizedMemoryInfoEnabled settings. These are not used

anywhere anymore after r151199 which simplified and moved the MemoryInfo interface under window.internals.


  • Api/WebPage.cpp:

(BlackBerry::WebKit::WebPagePrivate::init): Remove the call to Settings::setMemoryInfoEnabled, the setting is being removed.


  • WebKit.order: Remove the memoryInfoEnabled entry.
  • WebView/WebPreferenceKeysPrivate.h: Remove WebKitMemoryInfoEnabledPreferenceKey.
  • WebView/WebPreferences.mm: Remove memoryInfoEnabled, setMemoryInfoEnabled methods.

(+[WebPreferences initialize]): Don't set the default value for the WebKitMemoryInfoEnabledPreferenceKey, the preference is being removed.

  • WebView/WebPreferencesPrivate.h: Remove memoryInfoEnabled, setMemoryInfoEnabled method declarations.
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]): Remove the call to Settings::setMemoryInfoEnabled, the setting is being removed.


  • Interfaces/IWebPreferencesPrivate.idl: Remove memoryInfoEnabled, setMemoryInfoEnabled entries.
  • WebPreferenceKeysPrivate.h: Remove the WebKitMemoryInfoEnabledPreferenceKey definition.
  • WebPreferences.cpp: Remove the memoryInfo, setMemoryInfoEnabled methods.

(WebPreferences::initializeDefaultSettings): Remove the WebKitMemoryInfoEnabledPreferenceKey entry initialization.

  • WebPreferences.h: Remove the memoryInfo, setMemoryInfoEnabled method declarations.
  • WebView.cpp:

(WebView::notifyPreferencesChanged): Remove the Settings::setMemoryInfoEnabled call, the method is being removed.

1:36 AM Changeset in webkit [151490] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed GTK build fix.

  • GNUmakefile.list.am: Adding missing build targets to the plugin process after r151480.
1:09 AM Changeset in webkit [151489] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[GTK] Parameter 'pseudoElement' from function 'webkit_dom_dom_window_get_computed_style' should be allowed to be NULL

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2013-06-12
Reviewed by Xan Lopez.


Add parameter 'pseudoElement' to the list of parameters that are allowed to
be NULL.

  • bindings/scripts/CodeGeneratorGObject.pm:



Add test for function 'webkit_dom_dom_window_get_computed_style'.

  • tests/testdomdomwindow.c:

(dom_dom_window_fixture_setup): Test setup for function
(dom_dom_window_fixture_teardown): Test teardown for function
(test_dom_dom_window_get_computed_style): Checks function

12:20 AM Changeset in webkit [151488] by sergio@webkit.org
  • 4 edits in trunk

Add CSS parsing recovery to functions

Reviewed by Andreas Kling.

From Blink r150205 by <serya@chromium.org>


Add parsing recovery capabilities to functions. Errors were
correctly detected without this change but then the whole
declaration was invalidated. By using expr_recovery to handle them
we can recover from those errors and go on with the parsing.

  • css/CSSGrammar.y.in:


  • fast/css/parsing-error-recovery.html: added some test cases for

parsing recovery inside functions.

Note: See TracTimeline for information about the timeline view.