Timeline
Jul 6, 2013:
- 11:46 PM Changeset in webkit [152438] by
-
- 2 edits in trunk/Source/WTF
Fix the performance regressions introduced by r152418
https://bugs.webkit.org/show_bug.cgi?id=118438
Reviewed by Sam Weinig.
- wtf/text/StringImpl.h:
(WTF::equal):
Looping between two arbitrary pointers prevents important loop
optimizations.
- 1:08 PM Changeset in webkit [152437] by
-
- 10 edits in trunk
createElement("image") creates an HTMLImageElement, although this hack should exist in parser only
https://bugs.webkit.org/show_bug.cgi?id=88360
Reviewed by Sam Weinig.
Source/WebCore:
Create a HTMLElement when using createElement('image'), but keep the HTML5 parser constructing HTMLImageelement for it.
- html/HTMLTagNames.in:
LayoutTests:
Update tests to reflect new behavior. This matches FireFox and Opera 12.
- fast/canvas/webgl/context-lost.html:
- fast/dom/prefixed-image-tag-expected.txt:
- fast/dom/prefixed-image-tag.xhtml:
- fast/dom/wrapper-classes-expected.txt:
- fast/dom/wrapper-classes.html:
- platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
- platform/mac/fast/dom/wrapper-classes-objc.html:
- 10:12 AM Changeset in webkit [152436] by
-
- 3 edits in trunk/Tools
Update list of EFL WK2 API tests
https://bugs.webkit.org/show_bug.cgi?id=118443
Patch by Sergio Correia <Sergio Correia> on 2013-07-06
Reviewed by Christophe Dumez.
The following tests were included:
Passing:
- CloseThenTerminate
- DidAssociateFormControls
- PageVisibilityState
- ResponsivenessTimerDoesntFireEarly
- TerminateTwice
- WillLoad
Failing:
- ResizeReversePaginatedWebView
- ScrollPinningBehaviors
This patch also modified
test_webkit2_api_BINARIES list so that it is in
alphabetical order.
- TestWebKitAPI/CMakeLists.txt: Added Bundles for included tests.
- TestWebKitAPI/PlatformEfl.cmake: Added a few tests.
- 12:24 AM Changeset in webkit [152435] by
-
- 2 edits in trunk/Source/WebCore
Stop hardcoding interfaces that have indexed getters returning strings
https://bugs.webkit.org/show_bug.cgi?id=118414
Reviewed by Kentaro Hara.
Stop hardcoding the names of interfaces that have indexed getters returning
strings in the bindings generator. Now that we use the latest Web IDL indexed
getter, more information is provided in the IDL files and the generator is
able to figure out if the indexed getter is returning a DOMString on its own.
No new tests, no behavior change.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateImplementation):
Jul 5, 2013:
- 10:01 PM Changeset in webkit [152434] by
-
- 2 edits in trunk/Source/WebCore
Tons of crashes on bots after r152425
https://bugs.webkit.org/show_bug.cgi?id=118440
<rdar://problem/14366772>
Reviewed by Sam Weinig.
Null-check the frame's page and early return. It's OK to do this
because it only happens when we're being torn down.
- page/FrameView.cpp:
(WebCore::FrameView::minimumScrollPosition):
(WebCore::FrameView::maximumScrollPosition):
- 7:19 PM Changeset in webkit [152433] by
-
- 4 edits in trunk
Fix r152265: FrameView's pagination mode is only one of two, and the logic was totally wrong
https://bugs.webkit.org/show_bug.cgi?id=118439
<rdar://problem/14366120>
Reviewed by Anders Carlsson.
- page/FrameView.cpp:
(WebCore::FrameView::maximumScrollPosition):
- Test both Page and FrameView's pagination modes.
- *Don't* clamp negatives to zero if we are paginated with scroll offset set,
like the original changelog claimed, but the code did the opposite.
- Don't clamp in *all* pagination modes; with 'direction: RTL' it's still possible
to have a negative maximum position in LTR/TB pagination modes.
- TestWebKitAPI/Tests/WebKit2/ResizeReversePaginatedWebView.cpp:
(TestWebKitAPI::didLayout):
(TestWebKitAPI::TEST):
- Make use of EXPECT_JS_EQ instead of manually doing JavaScript stuff.
- Assert that we got the right number of pages for sanity.
- Reduce the page gap size so that DrawingAreaImpl doesn't try to allocate
so much memory that SharedMemory asserts and makes the test time out.
- Use didFirstLayoutAfterSuppressedIncrementalRendering instead of Paint
because paint doesn't fire if the window is offscreen.
- 6:08 PM Changeset in webkit [152432] by
-
- 7 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: FTL should better report its compile-times and it should be able to run in a mode where it doesn't spend time generating OSR exits
https://bugs.webkit.org/show_bug.cgi?id=118401
Reviewed by Sam Weinig.
Add two new OSR exit modes, which are useful only for playing with compile times:
- All OSR exits are llvm.trap().
- OSR exits don't take arguments and have no exit value marshaling.
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGPlan.h:
(Plan):
- ftl/FTLIntrinsicRepository.h:
(FTL):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::emitOSRExitCall):
- ftl/FTLOutput.h:
(JSC::FTL::Output::trap):
- runtime/Options.h:
(JSC):
- 6:01 PM Changeset in webkit [152431] by
-
- 38 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG should refer to BasicBlocks by BasicBlock* and not BlockIndex
https://bugs.webkit.org/show_bug.cgi?id=118339
Reviewed by Michael Saboff.
This accomplishes two goals:
1) Simplifies a bunch of code. You can now much more directly get to a successor
or predecessor, since you just get the pointer directly. The backend(s) always
hold onto a pointer to the block they're on, so you don't have to do work to
get the block from the index.
2) It allows for the possibility of inserting blocks into the program.
Previously, if you did that, you'd have to edit all references to blocks since
those references would have outdated indexing after an insertion. Now, if you
change the indexing, you just have to invalidate some analyses and make sure
that you change each block's BasicBlock::index accordingly.
- dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::initialize):
(JSC::DFG::AbstractState::endBasicBlock):
(JSC::DFG::AbstractState::mergeToSuccessors):
- dfg/DFGAbstractState.h:
(AbstractState):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGBackwardsPropagationPhase.cpp:
(JSC::DFG::BackwardsPropagationPhase::run):
- dfg/DFGBasicBlock.h:
(DFG):
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::size):
(JSC::DFG::BasicBlock::isEmpty):
(JSC::DFG::BasicBlock::at):
(JSC::DFG::BasicBlock::operator[]):
(JSC::DFG::BasicBlock::last):
(JSC::DFG::BasicBlock::resize):
(JSC::DFG::BasicBlock::grow):
(BasicBlock):
(JSC::DFG::BasicBlock::append):
(JSC::DFG::BasicBlock::numSuccessors):
(JSC::DFG::BasicBlock::successor):
(JSC::DFG::BasicBlock::successorForCondition):
(JSC::DFG::BasicBlock::dump):
(UnlinkedBlock):
(JSC::DFG::UnlinkedBlock::UnlinkedBlock):
(JSC::DFG::getBytecodeBeginForBlock):
(JSC::DFG::blockForBytecodeOffset):
- dfg/DFGByteCodeParser.cpp:
(ByteCodeParser):
(InlineStackEntry):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::linkBlocks):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
(JSC::DFG::CFAPhase::performForwardCFA):
- dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::convertToJump):
- dfg/DFGCPSRethreadingPhase.cpp:
(JSC::DFG::CPSRethreadingPhase::freeUnnecessaryNodes):
(JSC::DFG::CPSRethreadingPhase::canonicalizeLocalsInBlocks):
(JSC::DFG::CPSRethreadingPhase::propagatePhis):
(CPSRethreadingPhase):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::run):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::run):
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGDCEPhase.cpp:
(JSC::DFG::DCEPhase::run):
- dfg/DFGDisassembler.cpp:
(JSC::DFG::Disassembler::Disassembler):
(JSC::DFG::Disassembler::createDumpList):
- dfg/DFGDisassembler.h:
(JSC::DFG::Disassembler::setForBlockIndex):
- dfg/DFGDominators.cpp:
(JSC::DFG::Dominators::compute):
(JSC::DFG::Dominators::iterateForBlock):
- dfg/DFGDominators.h:
(JSC::DFG::Dominators::dominates):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::run):
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dumpBlockHeader):
(JSC::DFG::Graph::handleSuccessor):
(JSC::DFG::Graph::determineReachability):
(JSC::DFG::Graph::resetReachability):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::numBlocks):
(JSC::DFG::Graph::block):
(JSC::DFG::Graph::lastBlock):
(Graph):
(JSC::DFG::Graph::appendBlock):
(JSC::DFG::Graph::killBlock):
(DFG):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::link):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::setForBlockIndex):
- dfg/DFGNaturalLoops.cpp:
(JSC::DFG::NaturalLoop::dump):
(JSC::DFG::NaturalLoops::compute):
(JSC::DFG::NaturalLoops::loopsOf):
- dfg/DFGNaturalLoops.h:
(JSC::DFG::NaturalLoop::NaturalLoop):
(JSC::DFG::NaturalLoop::addBlock):
(JSC::DFG::NaturalLoop::header):
(JSC::DFG::NaturalLoop::at):
(JSC::DFG::NaturalLoop::operator[]):
(JSC::DFG::NaturalLoop::contains):
(NaturalLoop):
(JSC::DFG::NaturalLoops::headerOf):
(NaturalLoops):
- dfg/DFGNode.h:
(DFG):
(JSC::DFG::SwitchCase::SwitchCase):
(JSC::DFG::SwitchCase::withBytecodeIndex):
(SwitchCase):
(JSC::DFG::SwitchCase::targetBytecodeIndex):
(JSC::DFG::SwitchData::SwitchData):
(JSC::DFG::SwitchData::setFallThroughBytecodeIndex):
(JSC::DFG::SwitchData::fallThroughBytecodeIndex):
(SwitchData):
(JSC::DFG::Node::setTakenBlock):
(JSC::DFG::Node::setNotTakenBlock):
(JSC::DFG::Node::takenBlock):
(JSC::DFG::Node::notTakenBlock):
(JSC::DFG::Node::successor):
(JSC::DFG::Node::successorForCondition):
- dfg/DFGPredictionInjectionPhase.cpp:
(JSC::DFG::PredictionInjectionPhase::run):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagateForward):
(JSC::DFG::PredictionPropagationPhase::propagateBackward):
(JSC::DFG::PredictionPropagationPhase::doRoundOfDoubleVoting):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::convertLastOSRExitToForward):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
(JSC::DFG::SpeculativeJIT::nonSpeculativeStrictEq):
(JSC::DFG::SpeculativeJIT::compilePeepHoleDoubleBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleIntegerBranch):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::createOSREntries):
(JSC::DFG::SpeculativeJIT::linkOSREntries):
(JSC::DFG::SpeculativeJIT::compileStrictEqForConstant):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::compileRegExpExec):
(JSC::DFG::SpeculativeJIT::addBranch):
(JSC::DFG::SpeculativeJIT::linkBranches):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::nextBlock):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):
(JSC::DFG::SpeculativeJIT::branchDouble):
(JSC::DFG::SpeculativeJIT::branchDoubleNonZero):
(JSC::DFG::SpeculativeJIT::branch32):
(JSC::DFG::SpeculativeJIT::branchTest32):
(JSC::DFG::SpeculativeJIT::branch64):
(JSC::DFG::SpeculativeJIT::branch8):
(JSC::DFG::SpeculativeJIT::branchPtr):
(JSC::DFG::SpeculativeJIT::branchTestPtr):
(JSC::DFG::SpeculativeJIT::branchTest8):
(JSC::DFG::SpeculativeJIT::jump):
(JSC::DFG::SpeculativeJIT::addBranch):
(JSC::DFG::SpeculativeJIT::StringSwitchCase::StringSwitchCase):
(StringSwitchCase):
(JSC::DFG::SpeculativeJIT::BranchRecord::BranchRecord):
(BranchRecord):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranchNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompareNull):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeStrictEq):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::run):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantStructureChecks):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks):
(JSC::DFG::TypeCheckHoistingPhase::disableHoistingAcrossOSREntries):
- dfg/DFGUnificationPhase.cpp:
(JSC::DFG::UnificationPhase::run):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::checkOperand):
(JSC::DFG::Validate::reportValidationContext):
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileJump):
(JSC::FTL::LowerDFGToLLVM::compileBranch):
(JSC::FTL::LowerDFGToLLVM::lowBlock):
- 4:21 PM Changeset in webkit [152430] by
-
- 2 edits in trunk/Source/WebCore
WKPageFindStringMatches with kWKFindOptionsBackwards still doesn't work
<rdar://problem/13881024>
https://bugs.webkit.org/show_bug.cgi?id=118436
Reviewed by Tim Horton.
- page/Page.cpp:
(WebCore::Page::findStringMatchingRanges):
- When searching backwards, use END_TO_START rather than START_TO_END.
- If there is no selection and we are searching backwards, we now select the last item, not the first.
- 4:12 PM Changeset in webkit [152429] by
-
- 2 edits in trunk/Source/WTF
[Windows] Unreviewed build correction.
- WTF.vcxproj/WTFGenerated.make: Avoid syntax error in generated
file in cases where Legible Output support is not present.
- 4:06 PM Changeset in webkit [152428] by
-
- 1 edit5 adds in trunk/Source/WebCore
Nix upstreaming - Adding Nix render theme files
https://bugs.webkit.org/show_bug.cgi?id=118368
Patch by Tullio Lucena <tullio.lucena@openbossa.org> on 2013-07-05
Reviewed by Benjamin Poulain.
All files related to render theme stuff.
No new tests. They will be uploaded on another patch during the upstreaming process.
- platform/nix/RenderThemeNix.cpp: Added.
- platform/nix/RenderThemeNix.h: Added.
- platform/nix/ScrollbarThemeNix.cpp: Added.
- platform/nix/ScrollbarThemeNix.h: Added.
- 3:57 PM Changeset in webkit [152427] by
-
- 2 edits in trunk/Source/WTF
[Windows] Unreviewed build correction.
- WTF.vcxproj/WTFGenerated.make: Use space (rather than double
quotes) when handling the no-Legible-Output case.
- 3:17 PM Changeset in webkit [152426] by
-
- 7 edits in trunk/Source
[Windows] Identify OS-level at build-time.
https://bugs.webkit.org/show_bug.cgi?id=118428
Reviewed by Anders Carlsson.
../WebCore:
- DerivedSources.make: Activate legible output features if present.
- WebCorePrefix.h: Activate MSVC 2010 workarounds for CGFloat if
building with VS2010.
- config.h: Activate legible output features if present.
../WTF:
- WTF.vcxproj/WTFGenerated.make: Check for Legible Output featurs
and set build environment as appropriate.
- wtf/Platform.h: Activate Legible Output features if present.
- 2:33 PM Changeset in webkit [152425] by
-
- 24 edits1 add in trunk
[wk2] Add API to lock the scroll position at the top or bottom of the page
https://bugs.webkit.org/show_bug.cgi?id=118429
<rdar://problem/14120323>
Reviewed by Anders Carlsson.
Test (API): WebKit2.ScrollPinningBehaviors
- WebCore.exp.in:
Expose FrameView::setScrollPinningBehavior.
- page/FrameView.cpp:
(WebCore::FrameView::FrameView):
Our pinning behavior should be DoNotPin by default.
- page/FrameView.cpp:
(WebCore::FrameView::minimumScrollPosition):
(WebCore::FrameView::maximumScrollPosition):
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::minimumScrollPosition):
(WebCore::ScrollingTreeScrollingNodeMac::maximumScrollPosition):
Fix the minimum scroll position's vertical location to the maximum if
we're pinned to the bottom, and vice-versa if we're pinned to the top.
(WebCore::FrameView::setScrollPinningBehavior): Added.
If scroll pinning behavior has changed, inform ScrollingCoordinator
and update scrollbars (which will also re-pin the scroll position).
- page/FrameView.h:
Override minimumScrollPosition, add setScrollPinningBehavior,
and storage for m_scrollPinningBehavior.
- page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::setScrollPinningBehavior): Added.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::ScrollingTree):
Our pinning behavior should be DoNotPin by default.
(WebCore::ScrollingTree::setScrollPinningBehavior):
(WebCore::ScrollingTree::scrollPinningBehavior):
Getter/setter for m_scrollPinningBehavior, scrolling-thread-safe.
- page/scrolling/ScrollingTree.h:
- page/scrolling/mac/ScrollingCoordinatorMac.h:
- page/scrolling/mac/ScrollingCoordinatorMac.mm:
(WebCore::ScrollingCoordinatorMac::setScrollPinningBehavior):
Inform ScrollingTree of the scroll pinning behavior change.
- platform/ScrollTypes.h:
Add ScrollPinningBehavior enum.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2/ScrollPinningBehaviors.cpp: Added.
(TestWebKitAPI::didFinishDocumentLoadForFrame):
(TestWebKitAPI::TEST):
Add a test that ensures that the three pinning modes (DoNotPin, PinToTop, PinToBottom)
all work correctly in the face of resizing the view and scrolling from JS.
- Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):
- Shared/WebPageCreationParameters.h:
Pass the current ScrollPinningBehavior across to the WebPage upon creation.
- UIProcess/API/C/WKPage.cpp:
(WKPageGetScrollPinningBehavior):
(WKPageSetScrollPinningBehavior):
- UIProcess/API/C/WKPagePrivate.h:
SPI to get/set the WebPageProxy's current ScrollPinningBehavior.
Convert between WK API type and WebCore enum.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::creationParameters):
Send ScrollPinningBehavior when creating a WebPage.
(WebKit::WebPageProxy::setScrollPinningBehavior):
Pass ScrollPinningBehavior changes across to the WebProcess (and save it
in WebPageProxy so it can be sent back across if the WebProcess crashes).
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::scrollPinningBehavior):
Getter/setter and storage for m_scrollPinningBehavior.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Inform new FrameViews of the current ScrollPinningBehavior.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Set our ScrollPinningBehavior based on our creation parameters.
(WebKit::WebPage::setScrollPinningBehavior):
Inform the FrameView of ScrollPinningBehavior changes.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::scrollPinningBehavior): Added.
(WebKit::WebPage::setScrollPinningBehavior): Added.
Add storage for m_scrollPinningBehavior.
- WebProcess/WebPage/WebPage.messages.in:
Add SetScrollPinningBehavior message.
- 2:28 PM Changeset in webkit [152424] by
-
- 3 edits2 adds in trunk
iframe constrained by max-width in full screen
https://bugs.webkit.org/show_bug.cgi?id=118250
Patch by Zalan Bujtas <Alan Bujtas> on 2013-07-05
Reviewed by Antti Koivisto.
Ensure that contents inside iframe can go full screen properly.
Set max-width and max-height values to the default 'none', so that iframes are not
constrained when entering full screen.
Source/WebCore:
Test: fullscreen/full-screen-iframe-with-max-width-height.html
- css/fullscreen.css:
(iframe:-webkit-full-screen):
LayoutTests:
- fullscreen/full-screen-iframe-with-max-width-height-expected.txt: Added.
- fullscreen/full-screen-iframe-with-max-width-height.html: Added.
- 2:03 PM Changeset in webkit [152423] by
-
- 2 edits in trunk/Tools
Unreviewed. Add myself as a committer.
- Scripts/webkitpy/common/config/contributors.json:
- 1:35 PM Changeset in webkit [152422] by
-
- 5 edits2 adds in trunk
[Mac] .webkitClosedCaptionsVisible doesn't work with "Automatic" caption mode
https://bugs.webkit.org/show_bug.cgi?id=118319
Reviewed by Jer Noble.
Source/WebCore:
Track when captions are enabled with the old 'webkitClosedCaptionsVisible' attribute and
consider that when determining which track should be enabled.
Test: media/track/track-legacyapi-with-automatic-mode.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_webkitLegacyClosedCaptionOverride.
(WebCore::HTMLMediaElement::setWebkitClosedCaptionsVisible): Set m_webkitLegacyClosedCaptionOverride.
(WebCore::HTMLMediaElement::webkitClosedCaptionsVisible): Return m_webkitLegacyClosedCaptionOverride.
- html/HTMLMediaElement.h:
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::textTrackSelectionScore): Don't apply "automatic"
logic when captions were enabled with .webkitClosedCaptionsVisible.
LayoutTests:
- media/track/track-legacyapi-with-automatic-mode-expected.txt: Added.
- media/track/track-legacyapi-with-automatic-mode.html: Added.
- 10:46 AM Changeset in webkit [152421] by
-
- 5 edits in tags/Safari-537.48.3/Source
Versioning.
- 10:44 AM Changeset in webkit [152420] by
-
- 1 copy in tags/Safari-537.48.3
New tag.
- 10:35 AM Changeset in webkit [152419] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Updated TestExpectations file.
Added accessibility/listitem-list.html to the list of expected
failures, which will get fixed once bug 105214 is fixed.
- platform/gtk/TestExpectations: Added new test.
- 10:25 AM Changeset in webkit [152418] by
-
- 3 edits in trunk/Source/WTF
A lot of code duplication within StringImpl 'equal' functions
https://bugs.webkit.org/show_bug.cgi?id=118415
Reviewed by Anders Carlsson.
There has been a lot of code duplication within StringImpl 'equal' functions:
the whole logic was copied to every overloaded 'equal' function.
Fixed now using templates and std::equal.
- wtf/text/StringImpl.cpp:
(WTF::equalInternal):
(WTF::equal):
- wtf/text/StringImpl.h:
(WTF::arraysEqual):
(WTF::equal):
- 9:35 AM Changeset in webkit [152417] by
-
- 2 edits in trunk/LayoutTests
[GTK] Update TestExpectations with crashing and failing tests
https://bugs.webkit.org/show_bug.cgi?id=118424
Unreviewed GTK gardening.
Updated TestExpectations with tests crashing and failing.
Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-05
- platform/gtk/TestExpectations:
- 8:02 AM Changeset in webkit [152416] by
-
- 2 edits in trunk/Source/WebCore
Segmentation fault occurred when ICU data library doesn't embed the expected encoding.
https://bugs.webkit.org/show_bug.cgi?id=118410
Patch by Benjamin Dupont <bdupont@nds.com> on 2013-07-05
Reviewed by Allan Sandfeld Jensen.
- platform/text/TextEncodingRegistry.cpp:
(WebCore::newTextCodec):
- 4:23 AM Changeset in webkit [152415] by
-
- 3 edits in trunk/Source/WTF
Remove code duplication from StringImpl create()/reallocate() methods
https://bugs.webkit.org/show_bug.cgi?id=118355
Reviewed by Andreas Kling.
StringImpl create()/reallocate() methods accepting LChar and UChar used to have
duplicated code. The code duplication is removed now via used templates.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::constructInternal):
(WTF::LChar):
(WTF::StringImpl::createUninitializedInternal):
(WTF::StringImpl::createUninitialized):
(WTF::StringImpl::reallocateInternal):
(WTF::StringImpl::reallocate):
(WTF::StringImpl::createInternal):
(WTF::StringImpl::create):
- wtf/text/StringImpl.h:
- 3:29 AM WikiStart edited by
- I'm developing a Mac app embedding a WebView and another developer … (diff)
- 3:29 AM Changeset in webkit [152414] by
-
- 4 edits in trunk/Source/WebKit2
[EFL][WK2] Implement unit test callbacks: onWordLearn and onWordIgnore.
https://bugs.webkit.org/show_bug.cgi?id=118392
Patch by Krzysztof Wolanski <k.wolanski@samsung.com> on 2013-07-05
Reviewed by Christophe Dumez.
Simulate behavior of Learn and Ignore Word in the text field.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.cpp:
(EWK2UnitTest::EWK2UnitTestBase::mouseDoubleClick):
Select the entire word in the text field.
- UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestBase.h:
- UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:
(onSpellingForKnownWord):
(onWordLearn):
(onWordIgnore):
(selectLearnSpelling):
(selectIgnoreSpelling):
- 3:26 AM Changeset in webkit [152413] by
-
- 2 edits1 add1 delete in trunk/LayoutTests
[New multicol] Change test to follow the pattern of the other tests
https://bugs.webkit.org/show_bug.cgi?id=117698
Patch by Mihai Maerean <Mihai Maerean> on 2013-07-05
Reviewed by Andreas Kling.
Test is a ref test against the old multicol code, like all the other tests in LayoutTests/fast/multicol/newmulticol/
This is a follow up of bug 116614, testing that flow threads don't end up being cloned in region based multi
columns with columns:1 where the only child has column-span:all.
- fast/multicol/newmulticol/direct-child-column-span-all-expected.html: Added.
- fast/multicol/newmulticol/direct-child-column-span-all-expected.txt: Removed.
- fast/multicol/newmulticol/direct-child-column-span-all.html:
- 3:13 AM Changeset in webkit [152412] by
-
- 4 edits in trunk
[GTK] WebKit2 test TestWebKitFaviconDatabase times out with recent glib
https://bugs.webkit.org/show_bug.cgi?id=111434
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-07-05
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
- UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:
(testNotInitialized):
(testSetDirectory):
(testClearDatabase):
(testGetFavicon):
(testGetFaviconURI): Removed gconstpointer parameter.
(testWebViewFavicon): Fixed to make it work together with the
other tests and removed gconstpointer parameter.
(testFaviconDatabase): Created to call all tests in the proper
order.
(beforeAll): Changed to call only testFaviconDatabase instead of
the separate tests.
Tools:
- Scripts/run-gtk-tests:
(TestRunner): Unskipped TestWebKitFaviconDatabase tests.
- 1:52 AM Changeset in webkit [152411] by
-
- 6 edits in trunk
[GTK] fast/text/font-kerning.html fails
https://bugs.webkit.org/show_bug.cgi?id=76048
Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-07-05
Reviewed by Martin Robinson.
Added kerning to the list of features for hb_shade() according to FontDescription::kerning().
Removed font-kerning.html from gtk/TestExpectations, which was failing before this fix.
Source/WebCore:
- platform/graphics/harfbuzz/HarfBuzzFace.cpp:
(WebCore):
- platform/graphics/harfbuzz/HarfBuzzFace.h:
(HarfBuzzFace):
- platform/graphics/harfbuzz/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::setFontFeatures):
LayoutTests:
- platform/gtk/TestExpectations:
- 1:41 AM Changeset in webkit [152410] by
-
- 2 edits in trunk/Source/WebKit2
TestWebKitFaviconDatabase/clear-database is not testing things properly
https://bugs.webkit.org/show_bug.cgi?id=118404
Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-07-05
Reviewed by Carlos Garcia Campos.
- UIProcess/API/gtk/tests/TestWebKitFaviconDatabase.cpp:
(testClearDatabase): Check for an existing icon that can make the
test fail if clear database is not working.
- 12:36 AM Changeset in webkit [152409] by
-
- 2 edits in trunk/Source/WebCore
Build fix GTK after r152404.
https://bugs.webkit.org/show_bug.cgi?id=118407
Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2013-07-05
Reviewed by Christophe Dumez.
- GNUmakefile.list.am:
Jul 4, 2013:
- 11:53 PM Changeset in webkit [152408] by
-
- 2 edits in trunk/Tools
[EFL] DumpRenderTree doesn't run if "opengl_x11" engine is not available
https://bugs.webkit.org/show_bug.cgi?id=118370
Patch by Viatcheslav Ostapenko <sl.ostapenko@samsung.com> on 2013-07-04
Reviewed by Christophe Dumez.
Add fallback to software X11 engine if opengl_x11 engine creation fails.
- DumpRenderTree/efl/DumpRenderTree.cpp:
(initEcoreEvas):
- 2:17 PM Changeset in webkit [152407] by
-
- 3 edits in trunk/Source/WebKit2
Paint the page background if we haven't received our first update
https://bugs.webkit.org/show_bug.cgi?id=118402
<rdar://problem/13893308>
Reviewed by Simon Fraser.
Make sure that we always paint something when we haven't received our first update from the web process.
- UIProcess/API/mac/WKView.mm:
(-[WKView drawRect:]):
- UIProcess/DrawingAreaProxyImpl.h:
(WebKit::DrawingAreaProxyImpl::hasReceivedFirstUpdate):
- 1:28 PM Changeset in webkit [152406] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
Unreviewed, add a helpful comment for why DCE is needed in the FTL.
I believe I've now twice down the experiment of disabling DCE in the FTL,
only to realize that this can't work, and that DCE is needed. I'd kind of
like to not make that mistake again.
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- 12:53 PM Changeset in webkit [152405] by
-
- 3 edits in trunk/Source/WebKit/mac
Add a method to get unreachable URL from WebFrame.
https://bugs.webkit.org/show_bug.cgi?id=118399
Normally we could use [[WebFrame dataSource] unreachableURL] to get the failed URL. However, if the frame has not
loaded (FrameLoader::frameHasLoaded() is false), we will get a nil dataSource and we won't be able to get unreachableURL.
We can add a method to always return the unreachableURL regardless if the frame has loaded or not.
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2013-07-04
Reviewed by Dan Bernstein.
- WebView/WebFrame.mm:
(-[WebFrame _unreachableURL]):
- WebView/WebFramePrivate.h:
- 11:48 AM Changeset in webkit [152404] by
-
- 16 edits2 deletes in trunk
Have SVGTextContentElement inherit SVGGraphicsElement
https://bugs.webkit.org/show_bug.cgi?id=118351
Reviewed by Dirk Schulze.
Source/WebCore:
Have SVGTextContentElement inherit SVGGraphicsElement instead of
SVGStyledElement in order to match the latest SVG2 specification:
https://svgwg.org/svg2-draft/text.html#InterfaceSVGTextContentElement
This patch also removes the SVGTransformable and SVGLocatable IDL
interfaces as they are no longer needed (were merged into
SVGGraphicsElement in the latest specification).
This is one step towards getting rid of multiple inheritance in
SVG, and complying with the latest SVG2 specification.
No new tests, covered by existing tests.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGeneratorJS.pm:
(GetGnuVTableOffsetForType):
- bindings/scripts/CodeGeneratorObjC.pm:
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::hasValidAttributeType):
- svg/SVGElement.cpp:
(WebCore::SVGElement::getBoundingBox):
- svg/SVGLocatable.idl: Removed.
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::SVGTextContentElement):
(WebCore::SVGTextContentElement::isSupportedAttribute):
(WebCore::SVGTextContentElement::isPresentationAttribute):
(WebCore::SVGTextContentElement::collectStyleForPresentationAttribute):
(WebCore::SVGTextContentElement::parseAttribute):
(WebCore::SVGTextContentElement::svgAttributeChanged):
- svg/SVGTextContentElement.h:
- svg/SVGTextContentElement.idl:
- svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::SVGTextElement):
(WebCore::SVGTextElement::animatedLocalTransform):
- svg/SVGTextElement.h:
- svg/SVGTextElement.idl:
- svg/SVGTransformable.idl: Removed.
LayoutTests:
Fix conversion to absolute (user agent) coordinates in the svg/text
tests to use SVGGraphicsElement::getScreenCTM() instead of
SVGGraphicsElement::getTransformToElement(). The previous code was
working until now due to a bug in getTransformToElement(), which
was not taking into consideration the CTM of the SVGTextElement (as
it was not recognized as a "locatable" element). Now that
SVGTextElement inherits from SVGGraphicsElement, it is properly
recognized as a "locatable" element by getTransformToElement().
- svg/text/resources/SelectionTestCase.js:
(toAbsoluteCoordinates):
- svg/text/selection-doubleclick.svg:
- 11:42 AM Changeset in webkit [152403] by
-
- 2 edits in trunk/Source/WebKit2
Crash when createPluginInternal ends up destroying the plug-in
https://bugs.webkit.org/show_bug.cgi?id=118397
<rdar://problem/14155051>
Reviewed by Simon Fraser.
Keep the WebProcessConnection object alive while calling createPluginInternal and handle
the IPC connection going away.
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::createPluginAsynchronously):
- 11:33 AM WebKitGTK/StartHacking edited by
- (diff)
- 11:00 AM Changeset in webkit [152402] by
-
- 3 edits in trunk/Source/WebCore
Remove PageThrottler::m_activeThrottleBlockers
https://bugs.webkit.org/show_bug.cgi?id=118375
Reviewed by Mark Rowe.
This is simply m_activityTokens.size().
Also, fold preventThrottling into addActivityToken & allowThrottling into removeActivityToken
(these should no longer be called directly, and should not be public).
- page/PageThrottler.cpp:
(WebCore::PageThrottler::PageThrottler):
- removed m_activeThrottleBlockers
(WebCore::PageThrottler::startThrottleHysteresisTimer):
- m_activeThrottleBlockers -> m_activityTokens.size()
(WebCore::PageThrottler::throttleHysteresisTimerFired):
- m_activeThrottleBlockers -> m_activityTokens.size()
(WebCore::PageThrottler::addActivityToken):
- added functionality from preventThrottling
(WebCore::PageThrottler::removeActivityToken):
- added functionality from allowThrottling
- page/PageThrottler.h:
- removed preventThrottling, allowThrottling, and m_activeThrottleBlockers.
- 8:52 AM WebKitGTK/StartHacking edited by
- Minor correction in documentation section (diff)
- 8:51 AM Changeset in webkit [152401] by
-
- 5 edits in trunk/Source/WebCore
Take document height into account when determining when it is considered visually non-empy
https://bugs.webkit.org/show_bug.cgi?id=118272
Reviewed by Darin Adler.
The current visually non-empy mechanism takes into account only the amount of contents in renderers.
Add a simple layout dependency so that we don't consider page non-empty until the document height
exceed a (low) height threshold (or the load completes).
- page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
Don't send layout callbacks until we have actually some content.
(WebCore::FrameView::qualifiesAsVisuallyNonEmpty):
(WebCore::FrameView::updateIsVisuallyNonEmpty):
Factor into functions.
- page/FrameView.h:
(WebCore::FrameView::incrementVisuallyNonEmptyCharacterCount):
(WebCore::FrameView::incrementVisuallyNonEmptyPixelCount):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::RenderEmbeddedObject):
- rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
The size is not known but the estimate provided here is always bigger than the threshold so
the functionality is unchanged.
- 8:50 AM WebKitGTK/StartHacking edited by
- Added documentation section. (diff)
- 8:33 AM Changeset in webkit [152400] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r152399.
Add missing header include for SVGNames.h.
- svg/SVGImageElement.h:
- 7:09 AM WebKitGTK/SpeedUpBuild edited by
- Minor typo fix in gold section (diff)
- 7:07 AM WebKitGTK/SpeedUpBuild edited by
- Minor fix in gold (diff)
- 7:06 AM WebKitGTK/SpeedUpBuild edited by
- Adding gold section (diff)
- 7:00 AM WebKitGTK/StartHacking edited by
- Recommending to use the gold linker (diff)
- 6:58 AM Changeset in webkit [152399] by
-
- 4 edits in trunk/Source/WebCore
Change static_cast<SVGImageElement*> with toSVGImageElement
https://bugs.webkit.org/show_bug.cgi?id=118387
Reviewed by Andreas Kling.
As a step to change static_cast with toXXX, static_cast<SVGImageElement*> can
be changed with toSVGImageElement().
Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=153557
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::updateImageViewport):
(WebCore::RenderSVGImage::layout):
(WebCore::RenderSVGImage::paintForeground):
- svg/SVGImageElement.h:
(WebCore::toSVGImageElement):
- svg/SVGImageLoader.cpp:
(WebCore::SVGImageLoader::dispatchLoadEvent):
- 6:18 AM Changeset in webkit [152398] by
-
- 2 edits in trunk/Source/WebCore
[GTK] Leak: Free PangoFontDescription* in RenderThemeGtk3
https://bugs.webkit.org/show_bug.cgi?id=118386
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-04
Reviewed by Carlos Garcia Campos.
Free PangoFontDescription* allocated by gtk_style_context_get (transfer full).
- platform/gtk/RenderThemeGtk3.cpp:
(WebCore::spinButtonArrowSize):
- 5:10 AM Changeset in webkit [152397] by
-
- 7 edits in trunk
[ATK] Leak: AtkAttributeSet* should be freed
https://bugs.webkit.org/show_bug.cgi?id=118307
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-04
Reviewed by Christophe Dumez.
Source/WebCore:
Use AtkAttributeSet* instead of GSList*.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetObjectLocale):
Tools:
Fixed memory leaks for AtkAttributeSet by calling
atk_attribute_set_free().
- DumpRenderTree/atk/AccessibilityControllerAtk.cpp:
(AccessibilityController::childElementById):
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(getAtkAttributeSetAsString):
(AccessibilityUIElement::allAttributes):
(AccessibilityUIElement::stringAttributeValue):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
(WTR::childElementById):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::getAtkAttributeSetAsString):
(WTR::AccessibilityUIElement::allAttributes):
(WTR::AccessibilityUIElement::stringAttributeValue):
- 3:03 AM Changeset in webkit [152396] by
-
- 4 edits in trunk/Source
[ATK] Do not expose '\n' for wrapped lines with ATK_TEXT_BOUNDARY_CHAR
https://bugs.webkit.org/show_bug.cgi?id=118359
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Do not expose a '\n' character for every visual line break.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextGetChar): Removed wrong code.
Source/WebKit/gtk:
Added new unit test to make sure we exposed line breaks properly.
- tests/testatk.c:
(testWebkitAtkGetTextAtOffsetWithWrappedLines): New unit test.
(main): Added new test to the test suite.
- 2:12 AM Changeset in webkit [152395] by
-
- 2 edits1 delete in trunk/Source/JavaScriptCore
[CMake] Add generation of JITStubs for x86_64 MSVC
https://bugs.webkit.org/show_bug.cgi?id=116666
Reviewed by Laszlo Gombos.
Also move the generation for ARM CPU into the CMakeLists.txt,
since it's compiler specific and not dedicated to Windows CE.
- CMakeLists.txt:
- PlatformWinCE.cmake: Removed.
- 2:05 AM Changeset in webkit [152394] by
-
- 2 edits2 deletes in trunk/LayoutTests
[EFL] Gardening. Unskip tests related with editing
https://bugs.webkit.org/show_bug.cgi?id=118379
Unreviewed gardening.
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2013-07-04
- platform/efl-wk2/TestExpectations: Unskip editing/selection/doubleclick-beside-cr-span.html and editing/selection/doubleclick-whitespace.html, which are passed after r150289
- platform/efl/editing/style/5065910-expected.txt: Removed (wrong expected result).
- platform/efl/editing/style/5065910-expected.png: Removed (wrong expected result).
- 1:52 AM Changeset in webkit [152393] by
-
- 2 edits in trunk/Source/JavaScriptCore
[CMake] Add STATICALLY_LINKED_WITH_WTF to JavaScriptCore project
https://bugs.webkit.org/show_bug.cgi?id=118120
Reviewed by Gyuyoung Kim.
Since WTF is a static library linked to JavaScriptCore on all CMake ports
we need to define STATICALLY_LINKED_WITH_WTF for all of them.
This makes only a difference for Windows, since WTF_EXPORT and WTF_IMPORT
are the same on all other platforms.
- CMakeLists.txt:
- 1:08 AM Changeset in webkit [152392] by
-
- 3 edits1 delete in trunk/Source/WebCore
Port FileSystemWin.cpp to WinCE
https://bugs.webkit.org/show_bug.cgi?id=117935
Reviewed by Brent Fulgham.
Add #if !OS(WINCE) around a few lines of the code, so it can be used by the WinCE port too.
- PlatformWinCE.cmake:
- platform/win/FileSystemWin.cpp:
(WebCore::storageDirectory):
- platform/wince/FileSystemWinCE.cpp: Removed.
- 12:44 AM Changeset in webkit [152391] by
-
- 3 edits2 adds in trunk
[GStreamer] support preload="metadata"
https://bugs.webkit.org/show_bug.cgi?id=116817
Reviewed by Eric Carlson.
Source/WebCore:
Add appropriate behavior for preload="metadata". Delay enabling download buffering
until playback is started in this case. This behavior fits with the standard quite
well and this is the most exact match we can get (at least without adding too much
extra complexity). What matters mostly is that we can avoid loading the media
before playback but we have the first frame and the metadata.
Test: media/video-load-preload-metadata.html
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::prepareToPlay): Set |m_preload| to |Auto|
so we will start download buffering if we did not start it yet.
(WebCore::MediaPlayerPrivateGStreamer::play): Ditto.
(MediaPlayerPrivateGStreamer::setDownloadBuffering): Only start download
buffering if |m_preload == Auto|. Also make sure we don't clear the download
flag once we started downloading because it would result in not well defined
behavior and it does not really makes sense.
(MediaPlayerPrivateGStreamer::setPreload): Set download buffering accordingly.
LayoutTests:
- media/video-load-preload-metadata.html: Added.
Jul 3, 2013:
- 11:48 PM WebKitGTK/2.0.x edited by
- (diff)
- 11:44 PM Changeset in webkit [152390] by
-
- 3 edits in trunk/Source/WebCore
[Coordinated Graphics] Don't use && operator in ASSERT
https://bugs.webkit.org/show_bug.cgi?id=118377
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-07-03
Reviewed by Noam Rosenthal.
We don't use && opeartor in ASSERT because it's impossible to know which
condition caused the assertion.
- platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp:
(WebCore::CoordinatedBackingStoreTile::swapBuffers):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::~CoordinatedGraphicsLayer):
- 11:20 PM Changeset in webkit [152389] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Support some more editing keyboard events
https://bugs.webkit.org/show_bug.cgi?id=118346
Patch by KyungTae Kim <ktf.kim@samsung.com> on 2013-07-03
Reviewed by Gyuyoung Kim.
For editable contents, support the shortcuts for copy, page, cut, select all, undo and redo.
- platform/efl/EflKeyboardUtilities.cpp:
- 10:28 PM Changeset in webkit [152388] by
-
- 5 edits2 adds in trunk
AX: Items the img aria role aren't inserting an object replacement character
https://bugs.webkit.org/show_bug.cgi?id=118259
Source/WebCore:
Reviewed by Tim Horton.
VoiceOver relies on object replacement characters being emitted when asking for selected text.
This has worked if a real <img> is used, but if role="img" is used on a <div>, for example,
no emission is performed, which leads to missed elements in text.
Test: platform/mac/accessibility/aria-image-emits-object-replacement.html
- editing/TextIterator.cpp:
(WebCore::isRendererReplacedElement):
(WebCore::TextIterator::advance):
LayoutTests:
Reviewed by Reviewed by Tim Horton.
- accessibility/non-native-image-crash-expected.txt:
- platform/mac/accessibility/aria-image-emits-object-replacement-expected.txt: Added.
- platform/mac/accessibility/aria-image-emits-object-replacement.html: Added.
- platform/mac/accessibility/img-fallsback-to-title-expected.txt:
Update expected tests where role="img" now emits replacement character.
- 9:31 PM Changeset in webkit [152387] by
-
- 6 edits in trunk/Source/WebCore
Adopt is/toHTMLMapElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118235
Reviewed by Andreas Kling.
To enhance readability, this patch adopts is/toHTMLMapElement.
This also helps out to reduce duplicated use of static_cast.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getDocumentLinks):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
- dom/DocumentOrderedMap.cpp:
(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):
- dom/TreeScope.cpp:
(WebCore::TreeScope::getImageMap):
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::imageElement):
- html/HTMLMapElement.h:
(WebCore::isHTMLMapElement):
(WebCore::toHTMLMapElement):
- 5:47 PM Changeset in webkit [152386] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Unreviewed build correction after r15283.
- WebCorePrefix.h: Remove include directive for CGFloat.h, as it
is not present in all Windows build environments.
- 5:39 PM Changeset in webkit [152385] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Exclude unsupported QuartzCore Features.
https://bugs.webkit.org/show_bug.cgi?id=118374
Reviewed by Anders Carlsson.
- WebCore.vcxproj/WebCoreCG.props: Exclude a few non-Windows
concepts from the QuartzCore headers.
- 5:03 PM Changeset in webkit [152384] by
-
- 5 edits in trunk/Source/WebCore
Simplify PageThrottler ownership.
https://bugs.webkit.org/show_bug.cgi?id=118372
Reviewed by Sam Weinig.
- page/Page.cpp:
(WebCore::Page::~Page):
- 'clearPage' method removed - just clear the own pointer.
- page/Page.h:
- make m_pageThrottler an OwnPtr.
- page/PageThrottler.cpp:
(WebCore::PageThrottler::~PageThrottler):
- moved 'setThrottled(false)' from 'clearPage' (removed).
(WebCore::PageThrottler::throttlePage):
(WebCore::PageThrottler::unthrottlePage):
- no need to check 'm_page'
- page/PageThrottler.h:
(WebCore::PageThrottler::create):
- create a PassOwnPtr, not PassRefPtr.
- 5:01 PM Changeset in webkit [152383] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Updates to support changes in CoreGraphics libraries.
https://bugs.webkit.org/show_bug.cgi?id=118373
Reviewed by Anders Carlsson.
- WebCorePrefix.h: Include definitions for isnan/round/roundf for versions of
Visual Studio that do not provide them natively.
- 4:56 PM Changeset in webkit [152382] by
-
- 13 edits in trunk/Source
Implement mechanism to detect (partially) hidden blocked plugins.
https://bugs.webkit.org/show_bug.cgi?id=117998
Patch by Gordon Sheridan <gordon_sheridan@apple.com> on 2013-07-03
Reviewed by Dean Jackson.
Source/WebCore:
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::replacementTextRect):
Added private method for calculating the size of the replacement text for blocked plugins.
(WebCore::RenderEmbeddedObject::isReplacementObscured):
Added public method to determine if the EMBED element used for a blocked plugin is inaccessible to the user.
- rendering/RenderEmbeddedObject.h:
Declare the two new methods mentioned above.
- WebCore.exp.in:
Export RenderEmbeddedObject::isReplacementObscured().
Source/WebKit2:
- Shared/Plugins/Netscape/PluginInformation.h:
- Shared/Plugins/Netscape/PluginInformation.cpp:
(WebKit::plugInInformationReplacementObscuredKey):
Add key for plugInInformation dictionaries.
(WebKit::createPluginInformationDictionary):
Add boolean parameter identifying whether the replacement for a blocked plugin is obscured, and add it to the dictionary.
- Shared/API/c/WKPluginInformation.h:
- Shared/API/c/WKPluginInformation.cpp:
(WKPluginInformationReplacementObscuredKey):
Provide the C API for the plugInInformationReplacementObscuredKey().
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didBlockInsecurePluginVersion):
Add bool replacementObscured parameter to pass on argument to createPluginInformationDictionary().
- UIProcess/WebPageProxy.messages.in:
Add bool replacementObscured parameter to DidBlockInsecurePluginVersion() message.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Invoke isReplacementObscured() method for blocked plugins.
- 4:38 PM Changeset in webkit [152381] by
-
- 2 edits in trunk/Source/WTF
[Windows] Unreviewed build correction.
- WTF.vcxproj/copy-files.cmd: Limit path (for this file) to DOS-only to avoid
the Cygwin variant of rmdir from being used.
- 4:13 PM Changeset in webkit [152380] by
-
- 3 edits in trunk/Source/WebInspectorUI
Guard remaining calls to decodeURIComponent with a try/catch.
https://bugs.webkit.org/show_bug.cgi?id=118371
Reviewed by Joseph Pecoraro.
- UserInterface/Main.js:
(WebInspector.displayNameForURL):
(WebInspector.updateWindowTitle):
- UserInterface/Utilities.js:
(arrayResult):
(queryString):
- 3:33 PM Changeset in webkit [152379] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152375. <rdar://problem/14349560>
- 3:31 PM Changeset in webkit [152378] by
-
- 2 edits in tags/Safari-537.48.2/Source/WebKit2
Merged r152375. <rdar://problem/14349560>
- 3:30 PM Changeset in webkit [152377] by
-
- 5 edits in tags/Safari-537.48.2/Source
Versioning.
- 3:28 PM Changeset in webkit [152376] by
-
- 1 copy in tags/Safari-537.48.2
New Tag.
- 3:28 PM Changeset in webkit [152375] by
-
- 2 edits in trunk/Source/WebKit2
<rdar://problem/14271105> Flash Player: deny ipc-posix-sem 59918130
<rdar://problem/14349560> Flash Player: deny ipc-posix-sem MacromediaSemaphoreDig on many sites
Reviewed by Sam Weinig.
- Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb: semaphore-owner doesn't appear to work the way we need it to, removing it (at least for now).
- 1:19 PM Changeset in webkit [152374] by
-
- 2 edits in trunk/Source/WebInspectorUI
Ran update-webkit-localizable-strings.
Rubber-stamped by Joseph Pecoraro.
- Localizations/en.lproj/localizedStrings.js:
- 1:16 PM Changeset in webkit [152373] by
-
- 1 edit1 add in trunk/Tools
Add Makefile to WebKitLauncher
https://bugs.webkit.org/show_bug.cgi?id=118365
Reviewed by Mark Rowe.
- WebKitLauncher/Makefile: Added.
- 12:45 PM Changeset in webkit [152372] by
-
- 2 edits in branches/safari-537-branch/LayoutTests
Skipping inspector tests that had other expectations, because specific rules override
general rules, and we need to skip all inspector tests.
<rdar://problem/12318375>
- platform/mac/TestExpectations:
- 11:50 AM Changeset in webkit [152371] by
-
- 3 edits in trunk/Tools
[ATK] Leak: more leaks in AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=118362
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-03
Reviewed by Christophe Dumez.
Free the memory created by g_strdup_printf.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::language):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::language):
- 11:40 AM Changeset in webkit [152370] by
-
- 2 edits in branches/safari-537-branch/Tools
Merged r152195.
- 11:06 AM Changeset in webkit [152369] by
-
- 4 edits in trunk
WebTextCheckerClient doesn't initialize output arguments.
https://bugs.webkit.org/show_bug.cgi?id=83683
Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-03
Reviewed by Martin Robinson.
Source/WebKit2:
Callers of checkSpellingOfString and checkGrammarOfString expect
certain default values when no misspelled (or bad grammar) string
is found. They try to do that by initialising the reply arguments
that go into the IPC calls, but these values are ultimately ignored (see
HandleMessage.h, where the replyArguments are declared).
In the past, this seems to have led to various issues, (see
TextCheckingHelper::findFirstMisspelling in TextCheckingHelper.cpp),
where these return values are asserted and checked to be in the right range.
This patch initialises the values, so even if no available client
implements the methods (or if the implementation forgets to do it) the callers
will have their expected output.
However, and for a general case, we probably need a way to tell the caller
that any existing value in the output arguments will be ignored.
- UIProcess/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::checkSpellingOfString):
(WebKit::WebTextCheckerClient::checkGrammarOfString):
LayoutTests:
Unskip editing/pasteboard/pasting-empty-html-falls-back-to-text.html, which no longer
crashes after the fix.
- platform/gtk-wk2/TestExpectations:
- 10:45 AM Changeset in webkit [152368] by
-
- 2 edits in branches/safari-537-branch/Source/WebKit2
Merged r152317. <rdar://problem/14309423>
- 10:35 AM Changeset in webkit [152367] by
-
- 2 edits in trunk/Source/WebKit2
[GTK][WK2] SIGSEV in WebKit::WebPageContextMenuClient::customContextMenuItemSelected
https://bugs.webkit.org/show_bug.cgi?id=116867
Reviewed by Anders Carlsson.
We did not reset the clients on WebPageProxy::close(), so right
clicking on a link after starting the navigation to some other
page was causing crashes because code was trying to access an
already freed m_contextMenuClient.
There were some other clients that could potentially trigger the
same issues. Reset them all to null to prevent this situation.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close):
- 10:28 AM Changeset in webkit [152366] by
-
- 2 edits in trunk/Tools
Xcode often gets in a state where the debugger is completely unresponsive
https://bugs.webkit.org/show_bug.cgi?id=118157
The GetPointeeData() operations we use to retrieve strings is extremely expensive.
Rather than pull the character data out of the debugger one byte at a time
through the GetPointeeData() API, retrieve the memory contents of the string through
the ReadMemory() API, and convert the retrieved memory into a python string.
Reviewed by Anders Carlsson.
- lldb/lldb_webkit.py:
(lldb_init_module.lldb_webkit):
(guess_string_length):
(ustring_to_string):
(lstring_to_string):
- 10:28 AM Changeset in webkit [152365] by
-
- 2 edits in branches/safari-537-branch/LayoutTests
Skip inspector tests, because they are failing with production builds.
<rdar://problem/12318375>
- platform/mac/TestExpectations:
- 10:10 AM Changeset in webkit [152364] by
-
- 5 edits in tags/Safari-537.48.1/Source
Versioning.
- 10:07 AM Changeset in webkit [152363] by
-
- 1 copy in tags/Safari-537.48.1
New Tag.
- 10:05 AM Changeset in webkit [152362] by
-
- 3 edits in trunk/Source/WTF
Unreviewed, rolling out r152356.
http://trac.webkit.org/changeset/152356
https://bugs.webkit.org/show_bug.cgi?id=118361
Broke JSCore tests (Requested by andersca on #webkit).
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::createUninitialized):
(WTF::StringImpl::reallocate):
(WTF::StringImpl::create):
- wtf/text/StringImpl.h:
- 10:03 AM Changeset in webkit [152361] by
-
- 1 delete in tags/Safari-537.48.1
Remove Tag.
- 9:48 AM Changeset in webkit [152360] by
-
- 5 edits in branches/safari-537-branch/Source
Versioning.
- 9:46 AM Changeset in webkit [152359] by
-
- 5 edits in tags/Safari-537.48.1/Source
Versioning.
- 9:43 AM Changeset in webkit [152358] by
-
- 1 copy in tags/Safari-537.48.1
New Tag.
- 9:12 AM Changeset in webkit [152357] by
-
- 2 edits in trunk/Source/WebKit2
Output arguments used in IPC calls should be returned initialised
https://bugs.webkit.org/show_bug.cgi?id=118354
Patch by Simon Pena <simon.pena@samsung.com> on 2013-07-03
Reviewed by Anders Carlsson.
When Download::shouldDecodeSourceDataOfMIMEType and Download::retrieveDestinationWithSuggestedFilename
call DownloadProxy::shouldDecodeSourceDataOfMIMEType and DownloadProxy::decideDestinationWithSuggestedFilename
through IPC, they assume the output arguments result and allowOverwrite have
been initialised.
This patch initialises these arguments also in the unlikely event that a
m_webContext is not available.
- UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::shouldDecodeSourceDataOfMIMEType):
(WebKit::DownloadProxy::decideDestinationWithSuggestedFilename):
- 9:03 AM EFLWebKit edited by
- Added a short paragraph linking to the instructions on how to work … (diff)
- 8:49 AM PythonGuidelines edited by
- Added section on how to work with distros that come with Python 3 as … (diff)
- 8:38 AM Changeset in webkit [152356] by
-
- 3 edits in trunk/Source/WTF
Remove code duplication from StringImpl create()/reallocate() methods
https://bugs.webkit.org/show_bug.cgi?id=118355
Reviewed by Anders Carlsson.
StringImpl create()/reallocate() methods accepting LChar and UChar used to have
duplicated code. The code duplication is removed now via used templates.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::constructInternal):
(WTF::LChar):
(WTF::StringImpl::createUninitializedInternal):
(WTF::StringImpl::createUninitialized):
(WTF::StringImpl::reallocateInternal):
(WTF::StringImpl::reallocate):
(WTF::StringImpl::createInternal):
(WTF::StringImpl::create):
- wtf/text/StringImpl.h:
- 8:28 AM Changeset in webkit [152355] by
-
- 2 edits in trunk/Source/WebCore
Speculative build fix after r152340.
- WebCore.exp.in:
- 7:52 AM Changeset in webkit [152354] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][GTK] Invalid ASSERTs in WebResources loading code
https://bugs.webkit.org/show_bug.cgi?id=118352
Reviewed by Carlos Garcia Campos.
The WebKitWebView keeps track of the resources being loaded in a
map. A couple of ASSERTs verify that every loaded resource is
stored in that map.
The map that is cleared each time a new load starts so there is a
small chance that we get notifications for resources that
correspond to previous page loads
(and thus are not stored in the map). We should remove the ASSERT
which is not valid anymore.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewGetLoadingWebResource):
- 7:18 AM Changeset in webkit [152353] by
-
- 15 edits in trunk/Source/WebCore
Append overloading function for isFooElement
https://bugs.webkit.org/show_bug.cgi?id=118334
Reviewed by Antti Koivisto.
Node::hasTagName needs additional isElementNode() check when it is triggered.
So conversion from Element* to Node* in isFooElement should be avoided.
Therefore, to support both Node* and Element* as an argument of isFooElement,
this patch appends overloading inline function.
- css/CSSStyleSheet.cpp:
(WebCore::isAcceptableCSSStyleSheetParent):
- css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::scopeFor):
- dom/Node.cpp:
(WebCore::Node::numberOfScopedHTMLStyleChildren):
- html/HTMLAnchorElement.h:
(WebCore::isHTMLAnchorElement):
- html/HTMLAreaElement.h:
(WebCore::isHTMLAreaElement):
- html/HTMLAudioElement.h:
(WebCore::isHTMLAudioElement):
- html/HTMLFormElement.h:
(WebCore::isHTMLFormElement):
- html/HTMLImageElement.h:
(WebCore::isHTMLImageElement):
- html/HTMLInputElement.h:
(WebCore::isHTMLInputElement):
- html/HTMLLabelElement.h:
(WebCore::isHTMLLabelElement):
- html/HTMLOptGroupElement.h:
(WebCore::isHTMLOptGroupElement):
- html/HTMLOptionElement.h:
(WebCore::isHTMLOptionElement):
- html/HTMLStyleElement.h:
(WebCore::isHTMLStyleElement):
(WebCore::toHTMLStyleElement):
- html/HTMLTextAreaElement.h:
(WebCore::isHTMLTextAreaElement):
- 6:54 AM Changeset in webkit [152352] by
-
- 4 edits2 adds in trunk
Gif: zero filling should use memset instead of setRGBA for every pixel
https://bugs.webkit.org/show_bug.cgi?id=118350
Patch by Balazs Kelemen <b.kelemen@samsung.com> on 2013-07-03
Reviewed by Allan Sandfeld Jensen.
No new tests. Actually it is not covered by existing tests. Surprisingly we haven't got pixel
tests for animated images. Given that this patch is pretty trivial I don't think it's worth the
cost to start introducing such tests.
I added a manual test: animated-gif-dispose-background.html.
GIFImageDecoder::initializeFrameBuffer use a loop to fill a subrect with tranparent pixels.
This is extremely ineffecient. The use case for this code path is not frequent on the web
but it's still better to fix it.
- platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageFrame::zeroFillFrameRect):
- platform/image-decoders/ImageDecoder.h:
- platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::initFrameBuffer):
Fixed indentation in addition.
- 5:59 AM Changeset in webkit [152351] by
-
- 3 edits in trunk/Source/WebCore
TextureUnit code optimization
https://bugs.webkit.org/show_bug.cgi?id=117868
Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2013-07-03
Reviewed by Noam Rosenthal.
According to OpenGL ES 2.0 specification it is not possible to use both
texture2D and textureCubeMap in one texture unit.
This patch reduces amount of code, slightly increases rendering performance
and makes WebKit more consistent with OpenGL.
No new tests. Covered by existing tests:
LayoutTests/webgl/conformance/textures/tex-image-webgl.html
LayoutTests/webgl/conformance/textures/texture-complete.html
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::~WebGLRenderingContext):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::bindTexture):
(WebCore::WebGLRenderingContext::deleteTexture):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::handleNPOTTextures):
(WebCore::WebGLRenderingContext::validateTextureBinding):
(WebCore::WebGLRenderingContext::restoreCurrentTexture2D):
- html/canvas/WebGLRenderingContext.h:
- 3:50 AM Changeset in webkit [152350] by
-
- 21 edits in trunk/Source/WebCore
Stop inheriting SVGFilterPrimitiveStandardAttributes in SVG
https://bugs.webkit.org/show_bug.cgi?id=118305
Reviewed by Kentaro Hara.
Stop inheriting SVGFilterPrimitiveStandardAttributes in SVG and use
Web IDL implements instead to get rid of multiple inheritance and
follow the latest specification:
No new tests, no behavior change.
- CMakeLists.txt:
- DerivedSources.pri:
- GNUmakefile.list.am:
- svg/SVGFEBlendElement.idl:
- svg/SVGFEColorMatrixElement.idl:
- svg/SVGFEComponentTransferElement.idl:
- svg/SVGFECompositeElement.idl:
- svg/SVGFEConvolveMatrixElement.idl:
- svg/SVGFEDiffuseLightingElement.idl:
- svg/SVGFEDisplacementMapElement.idl:
- svg/SVGFEDropShadowElement.idl:
- svg/SVGFEFloodElement.idl:
- svg/SVGFEGaussianBlurElement.idl:
- svg/SVGFEImageElement.idl:
- svg/SVGFEMergeElement.idl:
- svg/SVGFEMorphologyElement.idl:
- svg/SVGFEOffsetElement.idl:
- svg/SVGFESpecularLightingElement.idl:
- svg/SVGFETileElement.idl:
- svg/SVGFETurbulenceElement.idl:
- 3:19 AM Changeset in webkit [152349] by
-
- 2 edits in trunk/Source/WTF
Fix cast-align warnings in FastMalloc.cpp
https://bugs.webkit.org/show_bug.cgi?id=117991
Reviewed by Mark Hahnenberg.
- wtf/FastMalloc.cpp:
- 3:13 AM Changeset in webkit [152348] by
-
- 6 edits in trunk/Source
H&R Block 2010 Help window can not be reopened.
https://bugs.webkit.org/show_bug.cgi?id=118342
Patch by Zalan Bujtas <Alan Bujtas> on 2013-07-03
Reviewed by Antti Koivisto.
http://trac.webkit.org/changeset/118916 changed the window.focus() behaviour so that
only the opener can (re)focus() a particular window.
H&R Block app relies on the relaxed window.focus() rules.
Source/WebCore:
- WebCore.exp.in:
- platform/RuntimeApplicationChecks.cpp:
(WebCore::applicationIsHRBlock):
- platform/RuntimeApplicationChecks.h:
Source/WebKit/mac:
- WebView/WebView.mm:
(shouldRestrictWindowFocus):
(-[WebView _preferencesChanged:]):
- 3:06 AM Changeset in webkit [152347] by
-
- 2 edits in trunk/Source/WebCore
Further build fixing for build configurations that disable CSS regions support.
- dom/PseudoElement.h: Wrap shouldMoveToFlowThread override into the ENABLE(CSS_REGIONS) build guard.
- 3:00 AM Changeset in webkit [152346] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix after r152320 and r152345 for build configurations that enable
SVG support but disable CSS regions support.
- svg/SVGElement.cpp: Wrap shouldMoveToFlowThread override into the ENABLE(CSS_REGIONS) build guard.
- svg/SVGElement.h: Ditto.
- 2:35 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:33 AM WebKitGTK/2.0.x edited by
- (diff)
- 2:02 AM Changeset in webkit [152345] by
-
- 3 edits in trunk/Source/WebCore
[CSS Regions] Improve implementation of elements in region being flowed to another flow thread
https://bugs.webkit.org/show_bug.cgi?id=118300
Based on patch by Zoltán Árvai <zarvai@inf.u-szeged.hu>
Patch by Radu Stavila <stavila@adobe.com> on 2013-07-03
Reviewed by Csaba Osztrogonác.
Fixed CSS_REGIONS guard.
- dom/Element.h:
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::elementInsideRegionNeedsRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
- 1:43 AM Changeset in webkit [152344] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Migrate WebKitWebContext to GTask
https://bugs.webkit.org/show_bug.cgi?id=117153
Reviewed by Gustavo Noronha Silva.
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextGetPluginThread):
(webkit_web_context_get_plugins):
(webkit_web_context_get_plugins_finish):
- 1:03 AM Changeset in webkit [152343] by
-
- 15 edits in trunk/Source/WebCore
Move SVGTests attributes parsing to SVGGraphicsElement
https://bugs.webkit.org/show_bug.cgi?id=118292
Reviewed by Darin Adler.
Move SVGTests attributes parsing to SVGGraphicsElement instead of doing
this in each of its subclasses. SVGGraphicsElement is now the one
subclassing SVGTests after r152167.
No new tests, no behavior change.
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::isSupportedAttribute):
(WebCore::SVGAElement::parseAttribute):
- svg/SVGCircleElement.cpp:
(WebCore::SVGCircleElement::isSupportedAttribute):
(WebCore::SVGCircleElement::parseAttribute):
(WebCore::SVGCircleElement::svgAttributeChanged):
- svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::isSupportedAttribute):
(WebCore::SVGClipPathElement::parseAttribute):
- svg/SVGEllipseElement.cpp:
(WebCore::SVGEllipseElement::isSupportedAttribute):
(WebCore::SVGEllipseElement::parseAttribute):
(WebCore::SVGEllipseElement::svgAttributeChanged):
- svg/SVGForeignObjectElement.cpp:
(WebCore::SVGForeignObjectElement::isSupportedAttribute):
(WebCore::SVGForeignObjectElement::parseAttribute):
(WebCore::SVGForeignObjectElement::svgAttributeChanged):
- svg/SVGGElement.cpp:
(WebCore::SVGGElement::isSupportedAttribute):
(WebCore::SVGGElement::parseAttribute):
(WebCore::SVGGElement::svgAttributeChanged):
- svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::isSupportedAttribute):
(WebCore::SVGGraphicsElement::parseAttribute):
(WebCore::SVGGraphicsElement::svgAttributeChanged):
- svg/SVGImageElement.cpp:
(WebCore::SVGImageElement::isSupportedAttribute):
(WebCore::SVGImageElement::parseAttribute):
(WebCore::SVGImageElement::svgAttributeChanged):
- svg/SVGLineElement.cpp:
(WebCore::SVGLineElement::isSupportedAttribute):
(WebCore::SVGLineElement::parseAttribute):
(WebCore::SVGLineElement::svgAttributeChanged):
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::isSupportedAttribute):
(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::svgAttributeChanged):
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::isSupportedAttribute):
(WebCore::SVGPolyElement::parseAttribute):
(WebCore::SVGPolyElement::svgAttributeChanged):
- svg/SVGRectElement.cpp:
(WebCore::SVGRectElement::isSupportedAttribute):
(WebCore::SVGRectElement::parseAttribute):
(WebCore::SVGRectElement::svgAttributeChanged):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::parseAttribute):
(WebCore::SVGSVGElement::svgAttributeChanged): Fall back to calling
SVGGraphicsElement::svgAttributeChanged() instead of
SVGStyledElement::svgAttributeChanged() as SVGGraphicsElement is the
parent class and it takes care of parsing SVGTests attributes now.
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::isSupportedAttribute):
(WebCore::SVGUseElement::parseAttribute):
(WebCore::SVGUseElement::svgAttributeChanged):
- 12:44 AM Changeset in webkit [152342] by
-
- 2 edits in trunk/LayoutTests
[Qt] Unreviewed gardening. Skipping test to paint the debug bot green.
Patch by Gabor Abraham <abrhm@inf.u-szeged.hu> on 2013-07-03
- platform/qt/TestExpectations:
- 12:30 AM Changeset in webkit [152341] by
-
- 2 edits in trunk/Tools
[GTK] Let F5 refresh the page in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=117638
Patch by Morten Stenshorne <mstensho@opera.com> on 2013-07-03
Reviewed by Carlos Garcia Campos.
Also use the correct icon for the refresh button that was already there.
- MiniBrowser/gtk/BrowserWindow.c:
(browser_window_init):
Jul 2, 2013:
- 10:54 PM Changeset in webkit [152340] by
-
- 2 edits in trunk/Source/WebKit2
[WK2] Invalidate FontCache before purging MemoryCache upon WebProcess termination/closure
https://bugs.webkit.org/show_bug.cgi?id=118280
Reviewed by Darin Adler.
Invalidate the FontCache before disabling and purging the MemoryCache in WebProcess::didClose
and WebProcess::terminate. This frees up additional references to objects that were held
by the FontCache, reducing the amount of 'LEAK: *' output when exiting MiniBrowser or
WebKitTestRunner in debug builds.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::terminate):
(WebKit::WebProcess::didClose):
- 10:30 PM Changeset in webkit [152339] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: DFG::Node::m_opInfo2 should also be a uintptr_t
https://bugs.webkit.org/show_bug.cgi?id=118340
Reviewed by Sam Weinig.
- dfg/DFGNode.h:
(JSC::DFG::Node::Node):
- 10:21 PM Changeset in webkit [152338] by
-
- 6 edits in branches/dfgFourthTier/Source
Unreviewed, fix 32-bit build.
Source/JavaScriptCore:
- assembler/MacroAssembler.h:
(JSC::MacroAssembler::comparePtr):
(MacroAssembler):
- dfg/DFGBinarySwitch.cpp:
(JSC::DFG::BinarySwitch::advance):
- dfg/DFGBinarySwitch.h:
(JSC::DFG::BinarySwitch::caseValue):
Source/WTF:
- wtf/Platform.h:
- 10:07 PM Changeset in webkit [152337] by
-
- 2 edits in trunk/Source/WebCore
Modernize QualifiedName by wrapping gNameCache in a function and using more early exits
https://bugs.webkit.org/show_bug.cgi?id=118299
Reviewed by Andreas Kling.
Did cleanups.
- dom/QualifiedName.cpp:
(WebCore::qualifiedNameCache): Added to wrap gNameCache.
(WebCore::QualifiedName::QualifiedName):
(WebCore::QualifiedName::QualifiedNameImpl::~QualifiedNameImpl):
(WebCore::QualifiedName::toString): Use early exit and StringBuilder.
(WebCore::QualifiedName::init): Use early exit.
- 8:45 PM Changeset in webkit [152336] by
-
- 3 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: Have fewer Arrayify's
https://bugs.webkit.org/show_bug.cgi?id=118335
Reviewed by Mark Hahnenberg.
A lot of Arrayify's arise because some program saw Int32 arrays early on in
execution, but then they all got converted to Double arrays and the program
will never see Int32 arrays ever again. Prior to this change you would always
have an Arrayify in this case. But with this change, the first time that an
ArrayProfile is about to go polymorphic in computeUpdatedPrediction(), it
instead forcibly monomorphises itself to the latest-seen structure.
Thereafter it will never again perform this monomorphisation. This is
controlled by ArrayProfile::m_didPerformFirstRunPruning. This is a 5%
speed-up on Kraken/imaging-gaussian-blur with the FTL enabled, and it
unblocks a bunch of stuff we want to do in the future because it makes a
bunch of loops effect-free.
We will still want to implement Arrayify hoisting in the future, but this is
great anyway because it's better to not have Arrayifications than it is to
have hoisted Arrayifications.
- bytecode/ArrayProfile.cpp:
(JSC::ArrayProfile::computeUpdatedPrediction):
(JSC::ArrayProfile::briefDescription):
(JSC):
(JSC::ArrayProfile::briefDescriptionWithoutUpdating):
- bytecode/ArrayProfile.h:
(JSC::ArrayProfile::ArrayProfile):
(ArrayProfile):
- 8:19 PM Changeset in webkit [152335] by
-
- 2 edits in trunk/Source/WebCore
Don't set z-index: 0 on lots of elements with -webkit-overflow-scrolling: touch
https://bugs.webkit.org/show_bug.cgi?id=118337
Reviewed by Benjamin Poulain.
-webkit-overflow-scrolling: touch is an inherited property that, on iOS, controls
the behavior of overflow scrolling content, and causes overflow scrolling elements
to become CSS stacking contexts.
However, the code was too aggressive in setting style->setZIndex(0), doing so
for any element with overflow != hidden. Since the default for overflow is visible,
that meant almost every element.
Previously, this didn't really matter. However, since r125693, any renderer with non-auto
z-index gets a RenderLayer, and that RenderLayer will become a stacking context. The result
was too many RenderLayers and incorrect stacking context behavior.
Fix by ensuring that -webkit-overflow-scrolling: touch only affects elements which
are actually scrollable.
Also move the code that does this to below the code that adjust overflow style
for different elements.
- css/StyleResolver.cpp:
(WebCore::isScrollableOverflow):
(WebCore::StyleResolver::adjustRenderStyle):
- 7:45 PM Changeset in webkit [152334] by
-
- 2 edits in trunk/Tools
- 5:48 PM Changeset in webkit [152333] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r152318.
http://trac.webkit.org/changeset/152318
https://bugs.webkit.org/show_bug.cgi?id=118333
This patch broke media/track/track-automatic-subtitles.html on
Mac (Requested by dfarler on #webkit).
Source/WebCore:
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::textTrackSelectionScore):
LayoutTests:
- media/track/track-legacyapi-with-automatic-mode-expected.txt: Removed.
- media/track/track-legacyapi-with-automatic-mode.html: Removed.
- 5:39 PM Changeset in webkit [152332] by
-
- 11 edits in branches/safari-537-branch/Source
Merged r152328. <rdar://problem/14320278>
- 5:32 PM Changeset in webkit [152331] by
-
- 2 edits in trunk/Tools
Unreviewed. Adding myself to contributors.json.
- Scripts/webkitpy/common/config/contributors.json:
- 5:20 PM Changeset in webkit [152330] by
-
- 3 edits2 adds in trunk
Change event should not be dispatched by clicking a scrollbar of select listbox
https://bugs.webkit.org/show_bug.cgi?id=118019
<rdar://problem/14297760>
Patch by Ruth Fong <ruth_fong@apple.com> on 2013-07-02
Reviewed by Dean Jackson.
Source/WebCore:
Test: fast/forms/select/listbox-click-on-scrollbar.html
Merge the following:
http://src.chromium.org/viewvc/blink?view=revision&revision=151689
https://chromium.googlesource.com/chromium/blink/+/492549b0fcaa58a85aa0797446b62985a263704f
Previously, a select element with the multiple attribute would dispatch
an onChanged event when the scrollbar is clicked. This patch corrects this
issue by only calling listBoxOnChange(), which fires the onChanged event,
when an actual option is clicked.
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::childrenChanged): Updated to clear the list
of selected items when when an <option> element is added to/deleted from its <select> element.
(Without this addition, if a option was selected, and then JavaScript was used to modify
the <select> element, and then the scrollbar was clicked, an onChanged event would fire
because it remembers the previously selected option.)
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Updated to
only call listBoxOnChange() if at least one option is selected.
LayoutTests:
Merge the following:
http://src.chromium.org/viewvc/blink?view=revision&revision=151689
https://chromium.googlesource.com/chromium/blink/+/492549b0fcaa58a85aa0797446b62985a263704f
- fast/forms/select/listbox-click-on-scrollbar-expected.txt: Added.
- fast/forms/select/listbox-click-on-scrollbar.html: Added.
Tests that an onChange() event is not fired when the scrollbar of a
<select multiple> element is clicked.
- 5:18 PM Changeset in webkit [152329] by
-
- 3 edits in trunk/Source/WebCore
Preparing Windows WebGL build system.
https://bugs.webkit.org/show_bug.cgi?id=118325
Reviewed by Brent Fulgham.
- WebCore.vcxproj/WebCore.vcxproj: Added EGL files, removed unused GraphicsContext3DOpenGL.cpp.
- WebCore.vcxproj/WebCore.vcxproj.filters: Added EGL filter and files, removed unused GraphicsContext3DOpenGL.cpp.
- 5:06 PM Changeset in webkit [152328] by
-
- 11 edits in trunk/Source
The callback for WKPageGetPlugInInformation needs info about whether or not there are any
non-playing instances of the plug-in on the page
https://bugs.webkit.org/show_bug.cgi?id=118330
Reviewed by Anders Carlsson.
Source/WebCore:
- WebCore.exp.in:
Expose a symbol so it can be used in WebKit2.
Source/WebKit2:
Add another key value pair to the dictionary passed to the callback.
- Shared/API/c/WKPluginInformation.cpp:
(WKPlugInInformationPageContainsNonPlayingInstanceOfPlugInKey):
- Shared/API/c/WKPluginInformation.h:
- Shared/Plugins/Netscape/PluginInformation.cpp:
(WebKit::plugInInformationPageContainsNonPlayingInstanceOfPlugInKey):
(WebKit::createPlugInInformationDictionary):
Add the information about whether or not the page contains a non-playing instance of that
plug-in to the plug-in information dictionary.
- Shared/Plugins/Netscape/PluginInformation.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::containsPlugInCallback):
Check if any of the MIME types of the plug-in instances that are present on the page but are
not playing match the instance of plug-in being searched for.
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::addPlugInMimeTypesFromNodeListForNonPlayingPlugIns):
Based roughly off of addPlugInsFromNodeListMatchingPlugInOrigin in
HTMLPlugInImageElement.cpp.
(WebKit::WebPage::containsPluginViewsWithPluginProcessToken):
Based roughly off of HTMLPlugInImageElement::restartSimilarPlugIns.
- 4:04 PM Changeset in webkit [152327] by
-
- 2 edits in branches/safari-537-branch/LayoutTests
Merged r152288. <rdar://problem/14338353>
- 3:54 PM Changeset in webkit [152326] by
-
- 5 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: add option to disable OSR entry in loops
https://bugs.webkit.org/show_bug.cgi?id=118329
Reviewed by Mark Hahnenberg.
This adds that option, and also makes the OSR exit reoptimization trigger rely less on
OSR entry failing. Now even if we never attempt OSR entry but our execution counter gets
high after a small number of OSR exits, we will recompile.
- dfg/DFGOSRExitCompilerCommon.cpp:
(JSC::DFG::handleExitCounts):
- dfg/DFGOperations.cpp:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_loop_hint):
(JSC::JIT::emitSlow_op_loop_hint):
- runtime/Options.h:
(JSC):
- 3:18 PM Changeset in webkit [152325] by
-
- 2 edits in trunk/Source/WebCore
Added getProcAddress implementation for Windows in OpenGLShims.
https://bugs.webkit.org/show_bug.cgi?id=118312
Reviewed by Brent Fulgham.
- platform/graphics/OpenGLShims.cpp:
(WebCore::getProcAddress): Added for Windows.
- 3:12 PM Changeset in webkit [152324] by
-
- 2 edits in trunk/Source/WebCore
media/unsupported-rtsp.html is failing
https://bugs.webkit.org/show_bug.cgi?id=118327
Reviewed by Eric Carlson.
Fixes the media/unsupported-rtsp.html test.
Set the contentType field of contentInformationRequest in order to trigger AVFoundation to
notice that loading failed and generate an error.
- platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::notifyFinished):
- 2:58 PM Changeset in webkit [152323] by
-
- 2 edits in trunk/Source/WebCore
Fixed compile error in non-X11 platforms using EGL.
https://bugs.webkit.org/show_bug.cgi?id=118323
Reviewed by Brent Fulgham.
- platform/graphics/egl/GLContextEGL.cpp:
(WebCore::GLContextEGL::createPixmapContext): Put all X11-specific code into #if PLATFORM(X11).
- 2:45 PM Changeset in webkit [152322] by
-
- 1 edit1 delete in trunk/LayoutTests
Unreviewed rebaseline of media/video-controls-captions-trackmenu-localized after r151697.
- platform/mac-lion/media/video-controls-captions-trackmenu-localized-expected.txt: Removed.
"Unknown SDH" -> "Unknown".
- 2:24 PM Changeset in webkit [152321] by
-
- 2 edits in trunk/LayoutTests
Unreviewed rebaseline of Mac Lion fast/js/global-constructors-attributes after r151914.
- platform/mac-lion/fast/js/global-constructors-attributes-expected.txt:
WaveTable -> PeriodicWave
- 1:43 PM Changeset in webkit [152320] by
-
- 22 edits in trunk
[CSS Regions] Improve implementation of elements in region being flowed to another flow thread
https://bugs.webkit.org/show_bug.cgi?id=118300
Patch by Radu Stavila <stavila@adobe.com> on 2013-07-02
Reviewed by David Hyatt.
Source/WebCore:
Methods that must be const have been turned back into const. Code has been better organized.
Performance is better. Tests have been added to.
- dom/Element.cpp:
(WebCore::Element::detach):
(WebCore::Element::setIsInsideRegion):
(WebCore::Element::isInsideRegion):
(WebCore::Element::shouldMoveToFlowThread):
- dom/Element.h:
- dom/ElementRareData.h:
(WebCore::ElementRareData::isInsideRegion):
(WebCore::ElementRareData::setIsInsideRegion):
(WebCore::ElementRareData::ElementRareData):
- dom/Node.cpp:
(WebCore::Node::isRegisteredWithNamedFlow):
- dom/Node.h:
- dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):
(WebCore::NodeRenderingContext::elementInsideRegionNeedsRenderer):
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRenderingContext::createRendererForElementIfNeeded):
- dom/NodeRenderingContext.h:
- dom/PseudoElement.h:
- dom/Text.cpp:
(WebCore::Text::textRendererIsNeeded):
- dom/Text.h:
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::unregisterNamedFlowContentNode):
(WebCore::FlowThreadController::isContentNodeRegisteredWithAnyNamedFlow):
- rendering/FlowThreadController.h:
- rendering/RenderObject.h:
- rendering/RenderRegion.h:
- svg/SVGElement.cpp:
(WebCore::SVGElement::shouldMoveToFlowThread):
- svg/SVGElement.h:
LayoutTests:
- fast/regions/flow-body-in-html.html:
- fast/regions/region-content-flown-into-region-expected.html:
- fast/regions/region-content-flown-into-region.html:
- fast/regions/universal-selector-children-to-the-same-region.html:
- 1:30 PM Changeset in webkit [152319] by
-
- 2 edits in trunk/LayoutTests
Skip cache partitioning tests on Lion.
Rubber stamped by Jeffrey Pfau.
- platform/mac-lion/TestExpectations:
http/tests/cache/partitioned-cache.html
http/tests/cache/partitioned-cache-iframe.html
- 1:28 PM Changeset in webkit [152318] by
-
- 3 edits2 adds in trunk
[Mac] .webkitClosedCaptionsVisible doesn't work with "Automatic" caption mode
https://bugs.webkit.org/show_bug.cgi?id=118319
Reviewed by Darin Adler.
Source/WebCore:
Test: media/track/track-legacyapi-with-automatic-mode.html
- page/CaptionUserPreferencesMediaAF.cpp:
(WebCore::CaptionUserPreferencesMediaAF::textTrackSelectionScore): Don't apply "automatic"
logic when captions were enabled with .webkitClosedCaptionsVisible.
LayoutTests:
- media/track/track-legacyapi-with-automatic-mode-expected.txt: Added.
- media/track/track-legacyapi-with-automatic-mode.html: Added.
- 1:07 PM Changeset in webkit [152317] by
-
- 2 edits in trunk/Source/WebKit2
security/block-test.html fails when NetworkProcess is enabled
https://bugs.webkit.org/show_bug.cgi?id=118320
<rdar://problem/14309423>
Reviewed by Geoff Garen.
- NetworkProcess/NetworkResourceLoader.cpp: (WebKit::NetworkResourceLoader::wasBlocked): (WebKit::NetworkResourceLoader::cannotShowURL): Implemented missing ResourceHandleClient functions.
- 12:51 PM Changeset in webkit [152316] by
-
- 2 edits in trunk/Source/WebKit2
Fix crash when PageBanner::detachFromPage() is called from WebPage::~WebPage().
https://bugs.webkit.org/show_bug.cgi?id=118268
Reviewed by Beth Dakin.
- WebProcess/WebPage/mac/PageBannerMac.mm:
(WebKit::PageBanner::detachFromPage): Add some null checks. m_webPage->corePage()
can be null if this method is called after the web page is closed.
- 12:50 PM Changeset in webkit [152315] by
-
- 2 edits in trunk/Source/WebCore
Always flip the coordinate system before drawing NSViews from Widget::paint
https://bugs.webkit.org/show_bug.cgi?id=118318
<rdar://problem/13895483>
Reviewed by Beth Dakin.
Undo the change that would not flip on 10.9; turns out the bug was in AppKit. Also remove the
_hasCanDrawSubviewsIntoLayerOrAncestor workaround since drawing works correctly now.
Also, pass flipped:NO when creating the NSGraphicsContext to indicate that the graphics context
is unflipped as far as AppKit knows (since we flipped it earlier).
- platform/mac/WidgetMac.mm:
(WebCore::Widget::paint):
- 12:47 PM Changeset in webkit [152314] by
-
- 2 edits in trunk/Source/JavaScriptCore
Replace RELEASE_ASSERT with ASSERT in CodeBlock:: bytecodeOffsetForCallAtIndex
https://bugs.webkit.org/show_bug.cgi?id=118316
Reviewed by Geoffrey Garen.
This is causing some crashiness in release builds. We should replace it with an ASSERT
until we track down all the places that need fixing in bug 118315.
- bytecode/CodeBlock.h:
(JSC::CodeBlock::bytecodeOffsetForCallAtIndex):
- 12:30 PM Changeset in webkit [152313] by
-
- 3 edits2 adds in trunk
empty inlines should not affect line-wrapping
https://bugs.webkit.org/show_bug.cgi?id=25638
Reviewed by David Hyatt.
Source/WebCore:
Don't break on empty inlines if we're in the middle of a word. I took this opportunity to
refactor the series of checks we perform to establish if we can break at the current position.
Test: fast/text/whitespace/inline-whitespace-wrapping-11.html
- rendering/RenderBlockLineLayout.cpp:
(WebCore::textBeginsWithBreakablePosition):
(WebCore::canBreakAtThisPosition):
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):
LayoutTests:
- fast/text/whitespace/inline-whitespace-wrapping-11-expected.html: Added.
- fast/text/whitespace/inline-whitespace-wrapping-11.html: Added.
- 12:30 PM Changeset in webkit [152312] by
-
- 1 copy in tags/Safari-537.48
New Tag.
- 12:29 PM Changeset in webkit [152311] by
-
- 1 delete in tags/Safari-537.48
Remove Tag.
- 12:27 PM Changeset in webkit [152310] by
-
- 6 edits in branches/safari-537-branch/Source/WebInspectorUI
Merged r152199. <rdar://problem/14287209>
- 12:24 PM Changeset in webkit [152309] by
-
- 13 edits in branches/safari-537-branch/Source/WebInspectorUI
Merged r152141. <rdar://problem/14283900>
- 12:21 PM Changeset in webkit [152308] by
-
- 6 edits in branches/safari-537-branch/Source/WebInspectorUI
Merged r152136. <rdar://problem/13899156>
- 12:17 PM Changeset in webkit [152307] by
-
- 6 edits2 copies in trunk/Source
Implement CoordinatedSurface for Threaded Coordinated Graphics
https://bugs.webkit.org/show_bug.cgi?id=109661
Patch by Jae Hyun Park <jae.park@company100.net> on 2013-07-02
Reviewed by Noam Rosenthal.
This is a preparation patch for Threaded Coordianted Graphics.
This patch implements ThreadSafeCoordinatedSurface using ImageBuffer as a
backend. Also, this patch moves common implementation to CoordinatedSurface to
prevent duplication of code.
Source/WebCore:
- platform/graphics/texmap/coordinated/CoordinatedSurface.cpp:
(WebCore::CoordinatedSurface::CoordinatedSurface):
- platform/graphics/texmap/coordinated/CoordinatedSurface.h:
(WebCore::CoordinatedSurface::size):
(WebCore::CoordinatedSurface::flags):
- platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.cpp: Added.
(WebCore::ThreadSafeCoordinatedSurface::create):
(WebCore::ThreadSafeCoordinatedSurface::ThreadSafeCoordinatedSurface):
(WebCore::ThreadSafeCoordinatedSurface::~ThreadSafeCoordinatedSurface):
(WebCore::ThreadSafeCoordinatedSurface::paintToSurface):
(WebCore::ThreadSafeCoordinatedSurface::copyToTexture):
- platform/graphics/texmap/coordinated/ThreadSafeCoordinatedSurface.h: Added.
Source/WebKit2:
- Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
(WebKit::WebCoordinatedSurface::WebCoordinatedSurface):
- Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
- 12:09 PM Changeset in webkit [152306] by
-
- 4 edits in trunk/Source
plainText() is O(N2)
https://bugs.webkit.org/show_bug.cgi?id=118282
<rdar://problem/14284360>
Reviewed by Alexey Proskuryakov.
Source/WebCore:
- editing/TextIterator.cpp:
(WebCore::plainText): Linear growth for a vector data type is O(N2).
Don't do that. Luckily, StringBuilder does the right thing automatically,
so we can just delete code.
Source/WTF:
- wtf/text/StringBuilder.cpp:
(WTF::expandCapacity): Factored out this helper function to simplify
some code that was duplicated in four places.
(WTF::StringBuilder::appendUninitializedSlow):
(WTF::StringBuilder::append): Use expandCapacity(). One of the cases
was not doing anything special, and so was O(N2).
Also, always call expandCapacity() it in a standard way, calling
capacity() first, so it's easy to tell at a glance that you got it right.
- 12:00 PM Changeset in webkit [152305] by
-
- 2 edits in branches/dfgFourthTier/Source/JavaScriptCore
fourthTier: since the FTL disassembly hacks cannot distinguish between code and data, the LLVM disassembler symbol table callback should be able to deal gracefully with arbitrary garbage
https://bugs.webkit.org/show_bug.cgi?id=118313
Reviewed by Mark Hahnenberg.
Give it a mode where we can still crash on unrecognized reference types, so that we might
implement them in the future, but by default just print some stuff and keep going.
- disassembler/LLVMDisassembler.cpp:
(JSC):
(JSC::symbolLookupCallback):
- 11:15 AM Changeset in webkit [152304] by
-
- 1 copy in tags/Safari-537.48
New Tag.
- 11:14 AM Changeset in webkit [152303] by
-
- 6 edits3 adds in trunk
constrainScrollPositionForOverhang needs to handle scrollOrigin correctly
https://bugs.webkit.org/show_bug.cgi?id=118176
<rdar://problem/14301271>
Reviewed by Anders Carlsson.
Test: compositing/geometry/fixed-position-flipped-writing-mode.html
WebCore makes use of constrainScrollPositionForOverhang not only for
constraining fixed- and sticky-positioned elements to the viewport, but
also for clamping the tile cache's visible rect.
Therefore, constrainScrollPositionForOverhang needs to correctly take
the scrollOrigin into account. The easiest way I saw to do this was to
reimplement the function in terms of a pair of rect intersections
between a virtual scrollable "viewport" and the document (with a bit
of complication from headers and footers).
The first intersection is performed, then if the viewport doesn't fit,
it is pushed down and to the right, from the origin. Next, we intersect
again, this time pushing the rect up by the amount it overflowed the document
rect from the bottom right. This performs effectively the same constraint
as previously, but handles the scrollOrigin correctly and is also somewhat
easier to read and understand (with pictures).
- page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:
(WebCore::ScrollingTreeScrollingNodeMac::setScrollLayerPosition):
Subtract the scrollOrigin out of the offset passed to scrollOffsetForFixedPosition,
it's expecting an offset without the origin included.
- platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::constrainScrollPositionForOverhang):
Reimplement the function as described above.
Add a test that ensures that fixed position works with a scrollable document
and direction: rtl, which is one case where scrollOrigin is set.
Disable the test on Mac WebKit1 because of https://bugs.webkit.org/show_bug.cgi?id=118269.
- compositing/geometry/fixed-position-flipped-writing-mode-expected.txt: Added.
- compositing/geometry/fixed-position-flipped-writing-mode.html: Added.
- platform/mac/compositing/geometry/fixed-position-flipped-writing-mode-expected.png: Added.
- platform/mac/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 11:00 AM Changeset in webkit [152302] by
-
- 3 edits in branches/safari-537-branch/LayoutTests
Merged r152184. <rdar://problem/14304814>
- 10:54 AM Changeset in webkit [152301] by
-
- 5 edits in branches/dfgFourthTier/Source
fourthTier: FTL should use the equivalent of llvm opt -O2 by default
https://bugs.webkit.org/show_bug.cgi?id=118311
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
Use a PassManagerBuilder instead of rolling our own.
This boosts our speed-up by another 5% or so.
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- runtime/Options.h:
(JSC):
Source/WTF:
Reviewed by Mark Hahnenberg.
- wtf/LLVMHeaders.h:
- 10:53 AM Changeset in webkit [152300] by
-
- 2 edits in trunk/Source/JavaScriptCore
[Windows] Unreviewed build correction for 'DebugSuffix' target.
- JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj: Must pass the
DEBUGSUFFIX definition to the nmake instance to be available during script processing.
- 10:37 AM Changeset in webkit [152299] by
-
- 16 edits2 deletes in trunk/Source/WebCore
Remove SVGStyledLocatableElement class
https://bugs.webkit.org/show_bug.cgi?id=118283
Reviewed by Dirk Schulze.
Remove SVGStyledLocatableElement class and have SVGGraphicsElement
inherit SVGStyledElement directly instead. SVGStyledLocatableElement
is no longer needed and according to the specification, SVGGraphicsElement
should inherit SVGStyledElement (actually SVGElement once we merge
SVGStyledElement into SVGElement).
No new tests, no behavior change.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.order:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- bindings/scripts/CodeGeneratorJS.pm:
(GetGnuVTableOffsetForType):
- svg/SVGAllInOne.cpp:
- svg/SVGElement.cpp:
(WebCore::SVGElement::getBoundingBox):
- svg/SVGElement.h:
- svg/SVGGraphicsElement.cpp:
(WebCore::SVGGraphicsElement::SVGGraphicsElement):
(WebCore::SVGGraphicsElement::parseAttribute):
(WebCore::SVGGraphicsElement::svgAttributeChanged):
- svg/SVGGraphicsElement.h:
- svg/SVGLocatable.cpp:
(WebCore::SVGLocatable::getTransformToElement):
- svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::localCoordinateSpaceTransform):
- svg/SVGStyledLocatableElement.cpp: Removed.
- svg/SVGStyledLocatableElement.h: Removed.
- 9:50 AM Changeset in webkit [152298] by
-
- 2 edits in trunk/Tools
[ATK] Leak: leaks in AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=118297
Fixed memory leak.
Patch by Brian Holt <brian.holt@samsung.com> on 2013-07-02
Reviewed by Christophe Dumez.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::stringValue):
- 9:26 AM Changeset in webkit [152297] by
-
- 3 edits in trunk/Source/WebCore
[Curl] Crash after download.
https://bugs.webkit.org/show_bug.cgi?id=118303
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-07-02
Reviewed by Brent Fulgham.
We need to make sure that the Curl easy handle is removed from the Curl multi handle before it's freed.
- platform/network/curl/CurlDownload.cpp:
(CurlDownloadManager::updateHandleList): Use addToCurl() and removeFromCurl() methods.
(CurlDownloadManager::addToCurl): Add method to add easy handle to multi handle.
(CurlDownloadManager::removeFromCurl): Add method to remove easy handle from multi handle, and then delete the handle.
(CurlDownloadManager::downloadThread): Use removeFromCurl() method.
(CurlDownload::~CurlDownload):
- platform/network/curl/CurlDownload.h: Avoid deleting Curl easy handle in destructor.
- 9:21 AM Changeset in webkit [152296] by
-
- 3 edits1 add in trunk/LayoutTests
Unreviewed gardening. Added new common expectations for test after r151665.
- accessibility/box-styled-lists-expected.txt: Added shared expectation.
- platform/efl/TestExpectations: Removed failure expectation.
- platform/gtk/TestExpectations: Ditto.
- 9:19 AM Changeset in webkit [152295] by
-
- 4 edits in trunk/Tools
Fix WebKitTestRunner crashes.
https://bugs.webkit.org/show_bug.cgi?id=117630
Reviewed by Darin Adler.
Create static function to dump for WebProcess unresponsiveness status,
and use it before calling TestController::runTest().
Accessing TestController::m_currentInvocation before calling
TestController::runTest() can make crash because the invocation
instance will be assigned at the function.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::run):
- WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::dumpWebProcessUnresponsiveness):
- WebKitTestRunner/TestInvocation.h:
- 9:13 AM Changeset in webkit [152294] by
-
- 1 edit1 move1 add in trunk/LayoutTests
Unreviewed gardening. Added new baselines for GTK after revision r151841 and r151868.
- accessibility/listitem-title-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/listitem-title-expected.txt.
- platform/gtk/accessibility/aria-tab-role-on-buttons-expected.txt: Added.
- 8:00 AM Changeset in webkit [152293] by
-
- 4 edits in trunk/Source/WebCore
[CSSRegions] No other SVG elements except the SVGRoot must have RegionInfo objects attached
https://bugs.webkit.org/show_bug.cgi?id=118295
Patch by Radu Stavila <stavila@adobe.com> on 2013-07-02
Reviewed by Antti Koivisto.
Only the SVGRoot element can be collected in a named flow. As such, no SVG element below the root should
be attached to a RenderBoxRegionInfo object.
A larger patch's test (https://bugs.webkit.org/show_bug.cgi?id=118300) is failing because of this.
This change will be covered by that test.
- rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::canHaveBoxInfoInRegion):
- rendering/RenderObject.h:
(WebCore::RenderObject::isRenderSVGBlock):
- rendering/svg/RenderSVGBlock.h:
- 7:32 AM Changeset in webkit [152292] by
-
- 2 edits in trunk/WebKitLibraries
Unreviewed, rolling out r152233.
http://trac.webkit.org/changeset/152233
https://bugs.webkit.org/show_bug.cgi?id=118304
hopeful attempt to restore windows buildage (Requested by
kling on #webkit).
- win/tools/vsprops/debugsuffix.props:
- 7:04 AM Changeset in webkit [152291] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening. Rebaseline background blend mode default test result.
- platform/mac/css3/compositing/background-blend-mode-default-value-expected.png:
- 6:48 AM Changeset in webkit [152290] by
-
- 6 edits in trunk/Source/WebCore
is/toHTMLStyleElement should use Element* for its argument
https://bugs.webkit.org/show_bug.cgi?id=118286
Reviewed by Andreas Kling.
To reduce unnecessary call of isElementNode(), this patch replaces argument
of is/toHTMLStyleElement from Node* to Element*. Plus, use Element::hasTagName
in collectActiveStyleSheets function for minor code refactoring since
its cost is cheaper than Node::hasTagName.
- css/CSSStyleSheet.cpp:
(WebCore::isAcceptableCSSStyleSheetParent):
- css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::scopeFor):
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
- dom/Node.cpp:
(WebCore::Node::numberOfScopedHTMLStyleChildren):
- html/HTMLStyleElement.h:
(WebCore::isHTMLStyleElement):
(WebCore::toHTMLStyleElement):
- 6:36 AM Changeset in webkit [152289] by
-
- 3 edits in trunk/Source/WTF
Avoid code duplication inside String::append()
https://bugs.webkit.org/show_bug.cgi?id=118290
Reviewed by Anders Carlsson.
The implementation of 'append(UChar)' had been repeated inside 'append(LChar)',
this duplication is obviated now.
- wtf/text/WTFString.cpp:
(WTF::String::appendInternal):
(WTF::String::append):
- wtf/text/WTFString.h:
- 6:31 AM Changeset in webkit [152288] by
-
- 2 edits in trunk/LayoutTests
Skip fast/dom/timer-throttling-hidden-page.html after r152202.
<http://webkit.org/b/118301>
- 5:53 AM Changeset in webkit [152287] by
-
- 2 edits in trunk/LayoutTests
Skip 3 MathML tests that are failing after r152235.
<http://webkit.org/b/118298>
- 5:20 AM Changeset in webkit [152286] by
-
- 3 edits in trunk/Source/WebCore
Unexpose EditingPropertiesToInclude in EditingStyle.h after r151772
https://bugs.webkit.org/show_bug.cgi?id=118271
Reviewed by Andreas Kling.
Don't expose EditingPropertiesToInclude in EditingStyle.h and do other cleanups as described below.
No new tests since there should be no behavioral change.
- editing/EditingStyle.cpp:
(WebCore::copyEditingProperties): Use newly defined numAllEditingProperties and numInheritableEditingProperties
instead of a magic number of 2.
(WebCore::copyPropertiesFromComputedStyle): Renamed from editingStyleFromComputedStyle. It now takes ComputedStyleExtractor and
PropertiesToInclude instead of Node* and EditingPropertiesToInclude and handles AllProperties. Also added a helper that takes Node*.
(WebCore::EditingStyle::init): Calls copyPropertiesFromComputedStyle. Unfortunately, we need to special-case EditingPropertiesInEffect
and not set background-color and text-decoration. This is required probably due to a bug elsewhere.
(WebCore::EditingStyle::removeStyleAddedByNode):
(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::extractEditingProperties): Renamed from EditingStyle::removeAllButEditingProperties; takes PropertiesToInclude instead of
EditingPropertiesToInclude since the only caller of this function, EditingStyle::mergeInlineAndImplicitStyleOfElement, was converting
the type.
(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
- editing/EditingStyle.h:
- 4:56 AM Changeset in webkit [152285] by
-
- 7 edits in trunk/Source/WebCore
Introduce toSVGInlineTextBox
https://bugs.webkit.org/show_bug.cgi?id=118289
Reviewed by Andreas Kling.
As a step to change static_cast with toXXX, static_cast<SVGInlineTextBox*> can
be changed with toSVGInlineTextBox().
Blink merge from https://src.chromium.org/viewvc/blink?view=rev&revision=153345
- rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::positionForPoint):
- rendering/svg/SVGInlineFlowBox.cpp:
(WebCore::SVGInlineFlowBox::paintSelectionBackground):
(WebCore::SVGInlineFlowBox::paint):
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):
- rendering/svg/SVGInlineTextBox.h:
(WebCore::toSVGInlineTextBox):
- rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGInlineTextBoxes):
- rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::paint):
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::layoutChildBoxes):
(WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):
- rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::collectTextBoxesInFlowBox):
- 4:50 AM Changeset in webkit [152284] by
-
- 2 edits in trunk/Source/WebCore
Simplify SVGTextContentElement::elementFromRenderer()
https://bugs.webkit.org/show_bug.cgi?id=118284
Reviewed by Andreas Kling.
Simplify SVGTextContentElement::elementFromRenderer() by leveraging
SVGElement::isTextContent() methods instead of explicitly checking
for tag names.
No new tests, no behavior change.
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::elementFromRenderer):
- 4:19 AM Changeset in webkit [152283] by
-
- 2 edits in trunk/Source/WebCore
Fix cast-align warnings in WebCore/platform/graphics/texmap/TextureMapperGL.cpp
https://bugs.webkit.org/show_bug.cgi?id=118249
Reviewed by Allan Sandfeld Jensen.
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
- 4:04 AM Changeset in webkit [152282] by
-
- 6 edits in trunk
[Qt][WK1] Support WebGL with EGL on Linux
https://bugs.webkit.org/show_bug.cgi?id=118251
Reviewed by Kenneth Rohde Christiansen.
Source/WebCore:
Let GraphicsContext3D work without a GraphicsSurface.
- Target.pri:
- platform/graphics/OpenGLShims.cpp:
(WebCore::getProcAddress):
- platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::paintToTextureMapper):
Tools:
- qmake/mkspecs/features/features.prf:
- 12:43 AM Changeset in webkit [152281] by
-
- 7 edits2 adds in trunk
[CSS-Regions] OverrideLogicalHeight used by both regions and flexbox
https://bugs.webkit.org/show_bug.cgi?id=118057
Patch by Catalin Badea <badea@adobe.com> on 2013-07-02
Reviewed by David Hyatt.
Source/WebCore:
Remove the use of overrideLogicalContentHeight() from regions and
use a local variable instead. The change was needed to avoid
overlapping with flexbox containers.
Test: fast/regions/autoheight-flexbox.html
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::applyBreakAfterContent):
(WebCore::RenderFlowThread::initializeRegionsComputedAutoHeight):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):
- rendering/RenderFlowThread.h:
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::pageLogicalHeight):
(WebCore::RenderRegion::logicalHeightOfAllFlowThreadContent):
(WebCore::RenderRegion::updateRegionHasAutoLogicalHeightFlag):
(WebCore::RenderRegion::layoutBlock):
(WebCore::RenderRegion::updateLogicalHeight):
- rendering/RenderRegion.h:
(WebCore::RenderRegion::computedAutoHeight):
(WebCore::RenderRegion::setComputedAutoHeight):
(WebCore::RenderRegion::clearComputedAutoHeight):
(WebCore::RenderRegion::hasComputedAutoHeight):
- rendering/RenderView.cpp:
LayoutTests:
Add test for auto-height regions and flexbox containers.
- fast/regions/autoheight-flexbox-expected.html: Added.
- fast/regions/autoheight-flexbox.html: Added.
