Timeline
Sep 25, 2013:
- 11:33 PM Changeset in webkit [156449] by
-
- 2 edits in trunk/Source/WebKit2
8 bytes memory leaks in WebProcessMainQt.cpp when proxy is initialized
https://bugs.webkit.org/show_bug.cgi?id=118515
Patch by Minju Kim <pmuarteo@gmail.com> on 2013-09-25
Reviewed by Christophe Dumez.
- WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::initializeProxy): Handled EnvHttpProxyFactory by using OwnPtr
to avoid memory leak when it isn't handled by NetworkProxyFactory
- 9:50 PM Changeset in webkit [156448] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, blind attempt at a build fix.
- inspector/InspectorIndexedDBAgent.cpp: Don’t include the keyPathFromIDBKeyPath method for PLATFORM(MAC) as it is unused.
- 9:15 PM Changeset in webkit [156447] by
-
- 11 edits in trunk/Source
Enable the IndexedDB build on Mac, but leave the feature non-functional
https://bugs.webkit.org/show_bug.cgi?id=121918
Reviewed by Alexey Proskuryakov.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
(WebCore::IDBFactory::create): If the IDBFactoryBackend is null (which it is for on-levelDB platforms),
don't create an IDBFactory. This hides the feature from javascript even though upport code is in the build.
- inspector/InspectorIndexedDBAgent.cpp: Empty out DatabaseLoader::execute on Mac until the inspector build gurus can figure out a 32bit-vs-64bit issue that there is no obvious solution for.
- WebCore.xcodeproj/project.pbxproj: Remove the Modules/indexedDB/leveldb directory now that Mac has no further use for it.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 8:54 PM Changeset in webkit [156446] by
-
- 4 edits in trunk/Source/WebCore
Unreviewed build fix for EFL port.
IDBCursorBackendImpl and IDBDatabaseBackendImpl are renamed after r156406.
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h:
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp:
(WebCore::IDBTransactionBackendLevelDB::create):
(WebCore::IDBTransactionBackendLevelDB::IDBTransactionBackendLevelDB):
(WebCore::IDBTransactionBackendLevelDB::registerOpenCursor):
(WebCore::IDBTransactionBackendLevelDB::unregisterOpenCursor):
(WebCore::IDBTransactionBackendLevelDB::closeOpenCursors):
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h:
(WebCore::IDBTransactionBackendLevelDB::database):
- 8:51 PM Changeset in webkit [156445] by
-
- 3 edits in trunk/LayoutTests
fast/css/font-face-data-uri.html is failing
https://bugs.webkit.org/show_bug.cgi?id=82744
Reviewed by Darin Adler.
This test used to wait for one font to load, but not for another, which made no sense.
- fast/css/font-face-data-uri.html: Wait for both fonts. Increased the number of tries,
it's not that long. Use an async test idiom that doesn't conflict with js-test-post.js.
- fast/css/font-face-data-uri-expected.txt: Updated the results for proper async
test usage.
- 7:30 PM Changeset in webkit [156444] by
-
- 5 edits in trunk/Source/WebCore
Do not reenter Document from its destructor
https://bugs.webkit.org/show_bug.cgi?id=121933
Reviewed by Darin Adler.
Following r156422, there are cases where we would reenter Document
during its destruction.
The flow was the following:
-Document's destructor is executed.
-DocumentStyleSheetCollection being part of Document, its destructor
is executed.
-DocumentStyleSheetCollection's destructor detach the owner node of all
its stylesheets avoid keeping stale references to a dead Document.
-CSSStyleSheet::clearOwnerNode() would fetch the dying document
and invoke Document::styleResolverChanged().
This would not fail because the document is detached and Document::styleResolverChanged()
would fail early. This is complicated and error prone so this patch attempt to clear
the process a bit.
With the patch, Document detach all the stylesheets early in the destruction.
Clearing the stylesheet is also changed to avoid re-entering the document.
- css/CSSStyleSheet.h:
- dom/Document.cpp:
(WebCore::Document::~Document):
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::detachFromDocument):
- dom/DocumentStyleSheetCollection.h:
- 7:03 PM Changeset in webkit [156443] by
-
- 3 edits in trunk/Source/WTF
Fix compilation with new MSVC compiler for Windows CE
https://bugs.webkit.org/show_bug.cgi?id=121914
Reviewed by Darin Adler.
Remove code to support older Windows CE versions, since those old
versions do not support C+11, which is required in the meantime.
- wtf/Atomics.h:
- wtf/Platform.h:
- 7:01 PM Changeset in webkit [156442] by
-
- 2 edits in trunk/Source/WebCore
htmlediting.cpp: unnecessary local variable cleanup
https://bugs.webkit.org/show_bug.cgi?id=121903
Patch by Santosh Mahto <santosh.ma@samsung.com> on 2013-09-25
Reviewed by Darin Adler.
Code cleanup.
- editing/htmlediting.cpp:
(WebCore::lowestEditableAncestor):
- 6:49 PM Changeset in webkit [156441] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed Build fix.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 6:05 PM Changeset in webkit [156440] by
-
- 5 edits1 add in trunk/Tools
Removed check for Apple Application Support directory in WinCairo port.
https://bugs.webkit.org/show_bug.cgi?id=121869
Patch by Alex Christensen <achristensen@webkit.org> on 2013-09-25
Reviewed by Brent Fulgham.
- DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj:
- DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj:
- WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj:
Use DLLLauncherWinCairo.props for WinCairo ports.
- win/DLLLauncher/DLLLauncherMain.cpp:
(wWinMain):
Don't call modifyPath to check for AAS in the WinCairo port.
- win/DLLLauncher/DLLLauncherWinCairo.props: Added to define WIN_CAIRO.
- 6:03 PM Changeset in webkit [156439] by
-
- 10 edits in trunk/Source
Unreviewed, rolling out r156432.
http://trac.webkit.org/changeset/156432
https://bugs.webkit.org/show_bug.cgi?id=121932
some integer conversion things that need brady to fix
(Requested by thorton on #webkit).
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- Modules/indexeddb/IDBFactory.h:
(WebCore::IDBFactory::create):
- WebCore.xcodeproj/project.pbxproj:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 5:53 PM Changeset in webkit [156438] by
-
- 4 edits in trunk/Source
Move KeyValuePairTraits inside HashMap
https://bugs.webkit.org/show_bug.cgi?id=121931
Reviewed by Sam Weinig.
Source/JavaScriptCore:
- tools/ProfileTreeNode.h:
Source/WTF:
Also rename the ValueType typedef to KeyValuePairType since it's always a key value pair.
- wtf/HashMap.h:
(WTF::HashMap::KeyValuePairTraits::isEmptyValue):
(WTF::HashMap::find):
(WTF::HashMap::contains):
- 5:48 PM Changeset in webkit [156437] by
-
- 7 edits in trunk
Enabled AssembleBuildLogs on WinCairo port.
https://bugs.webkit.org/show_bug.cgi?id=121923
Patch by Alex Christensen <achristensen@webkit.org> on 2013-09-25
Reviewed by Brent Fulgham.
Source/WebKit:
- WebKit.vcxproj/WebKit.sln:
Build AssembleBuildLogs in WinCairo port.
Tools:
- win/AssembleBuildLogs/AssembleBuildLogs.vcxproj:
Fixed reference to README, added WinCairo configurations.
- win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters:
Fixed reference to README.
- win/AssembleBuildLogs/AssembleLogs.cmd:
Added ANGLE projects, skipped QTMovieWin for WinCairo, use PlatformArchitecture for Win64.
- win/AssembleBuildLogs/README: Fixed spelling.
- 5:41 PM Changeset in webkit [156436] by
-
- 2 edits in trunk/Source/WebCore
Win64 compile fix after r155226.
https://bugs.webkit.org/show_bug.cgi?id=120969
Reviewed by Brent Fulgham.
- WebCore.vcxproj/WebCore.vcxproj:
Disable building StructuredExceptionHandlerSuppressor.cpp and makesafeseh.asm on Win64.
- 4:51 PM Changeset in webkit [156435] by
-
- 4 edits in trunk/Source/WebCore
Flaky Test: platform/mac/fonts/han-disunification.html
https://bugs.webkit.org/show_bug.cgi?id=114207
Reviewed by Anders Carlsson.
This test was affected by preceding tests changing font settings.
Save original font if it's changed, and restore it in Backup::restoreTo().
- WebCore.exp.in:
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setStandardFontFamily):
(WebCore::InternalSettings::setSerifFontFamily):
(WebCore::InternalSettings::setSansSerifFontFamily):
(WebCore::InternalSettings::setFixedFontFamily):
(WebCore::InternalSettings::setCursiveFontFamily):
(WebCore::InternalSettings::setFantasyFontFamily):
(WebCore::InternalSettings::setPictographFontFamily):
- testing/InternalSettings.h:
- 4:26 PM Changeset in webkit [156434] by
-
- 2 edits in trunk/Source/WTF
Un-indent HashMap.h.
Rubber-stamped by Andreas Kling.
- wtf/HashMap.h:
- 4:24 PM Changeset in webkit [156433] by
-
- 2 edits in trunk/Source/WebKit/win
[Windows] Attempting to scroll from a non-scrollable layer results the main document getting scrolled.
https://bugs.webkit.org/show_bug.cgi?id=121889.
<rdar://problem/15072441>
- WebView.cpp:
(WebView::gesture):
Call scrollByRecursively on the current RenderLayer's enclosingScrollableLayer to make sure that the method
doesn't bail early and end up just scrolling the main document instead of the next scrollable layer in the RenderLayer tree.
- 4:21 PM Changeset in webkit [156432] by
-
- 10 edits in trunk/Source
Enable the IndexedDB build on Mac, but leave the feature non-functional
https://bugs.webkit.org/show_bug.cgi?id=121918
Reviewed by Alexey Proskuryakov.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig: Enable the feature.
- Modules/indexeddb/IDBFactory.h:
(WebCore::IDBFactory::create): If the IDBFactoryBackend is null (which it is for on-levelDB platforms),
don't create an IDBFactory. This hides the feature from javascript even though upport code is in the build.
- WebCore.xcodeproj/project.pbxproj: Remove the Modules/indexedDB/leveldb directory now that Mac has no further use for it.
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 4:18 PM Changeset in webkit [156431] by
-
- 3 edits in trunk/LayoutTests
Flaky Test: fast/history/history-subframe-with-name.html
https://bugs.webkit.org/show_bug.cgi?id=51039
Reviewed by Brady Eidson.
- fast/history/history-subframe-with-name.html: In state 3, there was a race between
history.forward() and navigating to a new URL. Not sure how this resulted in an
extra load, but let's get rid of that. Also, extended failure logging.
- fast/history/resources/history-subframe-with-name-2.html: No longer do the
navigation unconditionally. We need it in state 1, but not in state 3.
- 4:18 PM Changeset in webkit [156430] by
-
- 3 edits in trunk/Source/WebKit/win
[WIN] Replace CF time functions with Windows API functions in WebHistory
https://bugs.webkit.org/show_bug.cgi?id=121599
Reviewed by Brent Fulgham.
This reduces the dependencies on the CoreFoundation library.
- WebHistory.cpp:
(addDayToSystemTime):
(getDayBoundaries):
(beginningOfDay):
(dateKey):
(WebHistory::orderedLastVisitedDays):
- WebHistory.h:
- 3:54 PM Changeset in webkit [156429] by
-
- 2 edits in trunk/Source/WTF
Un-indent HashTraits.h.
Rubber-stamped by Andreas Kling.
- wtf/HashTraits.h:
- 3:51 PM Changeset in webkit [156428] by
-
- 1 edit in trunk/Source/WebCore/bindings/generic/RuntimeEnabledFeatures.cpp
Fix the build.
- 3:42 PM Changeset in webkit [156427] by
-
- 2 edits in trunk/Source/WebCore
Make EventTarget::hasEventListeners() a const method.
This class needs a lot of love in the const correctness department
but for now let's limit ourselves to fixing the IndexedDB build.
- dom/EventTarget.h:
(WebCore::EventTarget::hasEventListeners):
- 3:35 PM Changeset in webkit [156426] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Disable more CSS_SHAPES tests on AppleWin port.
- platform/win/TestExpectations:
- 3:18 PM Changeset in webkit [156425] by
-
- 3 edits99 adds in trunk/PerformanceTests
DoYouEvenBench: Add a test case for FlightJS
https://bugs.webkit.org/show_bug.cgi?id=121926
Reviewed by Antti Koivisto.
Add a FlightJS test case.
- DoYouEvenBench/benchmark.html:
- DoYouEvenBench/benchmark.js:
- DoYouEvenBench/flightjs-example-app: Added.
- DoYouEvenBench/flightjs-example-app/LICENSE.md: Added.
- DoYouEvenBench/flightjs-example-app/README.md: Added.
- DoYouEvenBench/flightjs-example-app/app: Added.
- DoYouEvenBench/flightjs-example-app/app/boot: Added.
- DoYouEvenBench/flightjs-example-app/app/boot/page.js: Added.
- DoYouEvenBench/flightjs-example-app/app/component_data: Added.
- DoYouEvenBench/flightjs-example-app/app/component_data/compose_box.js: Added.
- DoYouEvenBench/flightjs-example-app/app/component_data/mail_items.js: Added.
- DoYouEvenBench/flightjs-example-app/app/component_data/move_to.js: Added.
- DoYouEvenBench/flightjs-example-app/app/component_ui: Added.
- DoYouEvenBench/flightjs-example-app/app/component_ui/compose_box.js: Added.
- DoYouEvenBench/flightjs-example-app/app/component_ui/folders.js: Added.
- DoYouEvenBench/flightjs-example-app/app/component_ui/mail_controls.js: Added.
- DoYouEvenBench/flightjs-example-app/app/component_ui/mail_items.js: Added.
- DoYouEvenBench/flightjs-example-app/app/component_ui/move_to_selector.js: Added.
- DoYouEvenBench/flightjs-example-app/app/component_ui/with_select.js: Added.
- DoYouEvenBench/flightjs-example-app/app/css: Added.
- DoYouEvenBench/flightjs-example-app/app/css/custom.css: Added.
- DoYouEvenBench/flightjs-example-app/app/data.js: Added.
- DoYouEvenBench/flightjs-example-app/app/templates.js: Added.
- DoYouEvenBench/flightjs-example-app/components: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/css: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap-responsive.css: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap-responsive.min.css: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap.css: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap.min.css: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/img: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/img/glyphicons-halflings-white.png: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/img/glyphicons-halflings.png: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/js: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/js/bootstrap.js: Added.
- DoYouEvenBench/flightjs-example-app/components/bootstrap/js/bootstrap.min.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/.gitignore: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/CHANGES: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/CONTRIBUTORS.md: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/LICENSE: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/README.md: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/component.json: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-sham.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-sham.min.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-shim.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-shim.min.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/package.json: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers/h-kill.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers/h-matchers.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers/h.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/index.html: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine-html.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine.css: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine_favicon.png: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/json2.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-array.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-date.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-function.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-object.js: Added.
- DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-string.js: Added.
- DoYouEvenBench/flightjs-example-app/components/flight: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/.travis.yml: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/lib: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/lib/advice.js: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/lib/component.js: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/lib/compose.js: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/lib/index.js: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/lib/logger.js: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/lib/registry.js: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/lib/utils.js: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/tools: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/tools/debug: Added.
- DoYouEvenBench/flightjs-example-app/components/flight/tools/debug/debug.js: Added.
- DoYouEvenBench/flightjs-example-app/components/jasmine-flight: Added.
- DoYouEvenBench/flightjs-example-app/components/jasmine-flight/LICENSE.md: Added.
- DoYouEvenBench/flightjs-example-app/components/jasmine-flight/README.md: Added.
- DoYouEvenBench/flightjs-example-app/components/jasmine-flight/bower.json: Added.
- DoYouEvenBench/flightjs-example-app/components/jasmine-flight/lib: Added.
- DoYouEvenBench/flightjs-example-app/components/jasmine-flight/lib/jasmine-flight.js: Added.
- DoYouEvenBench/flightjs-example-app/components/jasmine-jquery: Added.
- DoYouEvenBench/flightjs-example-app/components/jasmine-jquery/lib: Added.
- DoYouEvenBench/flightjs-example-app/components/jasmine-jquery/lib/jasmine-jquery.js: Added.
- DoYouEvenBench/flightjs-example-app/components/jquery: Added.
- DoYouEvenBench/flightjs-example-app/components/jquery/component.json: Added.
- DoYouEvenBench/flightjs-example-app/components/jquery/composer.json: Added.
- DoYouEvenBench/flightjs-example-app/components/jquery/jquery.js: Added.
- DoYouEvenBench/flightjs-example-app/components/jquery/jquery.min.js: Added.
- DoYouEvenBench/flightjs-example-app/components/mustache: Added.
- DoYouEvenBench/flightjs-example-app/components/mustache/mustache.js: Added.
- DoYouEvenBench/flightjs-example-app/components/requirejs: Added.
- DoYouEvenBench/flightjs-example-app/components/requirejs/require.js: Added.
- DoYouEvenBench/flightjs-example-app/index.html: Added.
- DoYouEvenBench/flightjs-example-app/karma.conf.js: Added.
- DoYouEvenBench/flightjs-example-app/package.json: Added.
- DoYouEvenBench/flightjs-example-app/requireMain.js: Added.
- 3:18 PM Changeset in webkit [156424] by
-
- 47 edits in trunk/Source
../WebCore: [Windows] Refactor RuntimeEnabledFeatures as a Singleton
https://bugs.webkit.org/show_bug.cgi?id=121883
Windows is experiencing crashes when client programs (such as
DumpRenderTree) attemp to change settings on the RuntimeEnabledFeatures
object. The inlined static accessor methods are not accessing
memory safely (when compiled by Visual Studio) resulting in
crashes.
Reviewed by Jer Noble.
- WebCore.exp.in: Remove static accessors for RuntimeEnabledFeatures.
- bindings/generic/RuntimeEnabledFeatures.cpp: Switch methods to
conform to a singleton pattern.
(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::sharedRuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::fileSystemEnabled):
(WebCore::RuntimeEnabledFeatures::javaScriptI18NAPIEnabled):
(WebCore::RuntimeEnabledFeatures::audioEnabled):
(WebCore::RuntimeEnabledFeatures::htmlMediaElementEnabled):
(WebCore::RuntimeEnabledFeatures::htmlAudioElementEnabled):
(WebCore::RuntimeEnabledFeatures::htmlVideoElementEnabled):
(WebCore::RuntimeEnabledFeatures::htmlSourceElementEnabled):
(WebCore::RuntimeEnabledFeatures::mediaControllerEnabled):
(WebCore::RuntimeEnabledFeatures::mediaErrorEnabled):
(WebCore::RuntimeEnabledFeatures::timeRangesEnabled):
(WebCore::RuntimeEnabledFeatures::sharedWorkerEnabled):
(WebCore::RuntimeEnabledFeatures::webSocketEnabled):
(WebCore::RuntimeEnabledFeatures::openDatabaseEnabled):
(WebCore::RuntimeEnabledFeatures::openDatabaseSyncEnabled):
- bindings/generic/RuntimeEnabledFeatures.h: Ditto.
(WebCore::RuntimeEnabledFeatures::setLocalStorageEnabled):
(WebCore::RuntimeEnabledFeatures::localStorageEnabled):
(WebCore::RuntimeEnabledFeatures::setSessionStorageEnabled):
(WebCore::RuntimeEnabledFeatures::sessionStorageEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitNotificationsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitNotificationsEnabled):
(WebCore::RuntimeEnabledFeatures::setApplicationCacheEnabled):
(WebCore::RuntimeEnabledFeatures::applicationCacheEnabled):
(WebCore::RuntimeEnabledFeatures::setDataTransferItemsEnabled):
(WebCore::RuntimeEnabledFeatures::dataTransferItemsEnabled):
(WebCore::RuntimeEnabledFeatures::setGeolocationEnabled):
(WebCore::RuntimeEnabledFeatures::geolocationEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitIndexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIndexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::indexedDBEnabled):
(WebCore::RuntimeEnabledFeatures::setCanvasPathEnabled):
(WebCore::RuntimeEnabledFeatures::canvasPathEnabled):
(WebCore::RuntimeEnabledFeatures::setCSSExclusionsEnabled):
(WebCore::RuntimeEnabledFeatures::cssExclusionsEnabled):
(WebCore::RuntimeEnabledFeatures::setCSSShapesEnabled):
(WebCore::RuntimeEnabledFeatures::cssShapesEnabled):
(WebCore::RuntimeEnabledFeatures::setCSSRegionsEnabled):
(WebCore::RuntimeEnabledFeatures::cssRegionsEnabled):
(WebCore::RuntimeEnabledFeatures::setCSSCompositingEnabled):
(WebCore::RuntimeEnabledFeatures::cssCompositingEnabled):
(WebCore::RuntimeEnabledFeatures::setFontLoadEventsEnabled):
(WebCore::RuntimeEnabledFeatures::fontLoadEventsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullScreenAPIEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitFullScreenAPIEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRequestFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitIsFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullScreenKeyboardInputAllowedEnabled):
(WebCore::RuntimeEnabledFeatures::webkitCurrentFullScreenElementEnabled):
(WebCore::RuntimeEnabledFeatures::webkitCancelFullScreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenEnabledEnabled):
(WebCore::RuntimeEnabledFeatures::webkitFullscreenElementEnabled):
(WebCore::RuntimeEnabledFeatures::webkitExitFullscreenEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRequestFullscreenEnabled):
(WebCore::RuntimeEnabledFeatures::touchEnabled):
(WebCore::RuntimeEnabledFeatures::setTouchEnabled):
(WebCore::RuntimeEnabledFeatures::setDeviceMotionEnabled):
(WebCore::RuntimeEnabledFeatures::deviceMotionEnabled):
(WebCore::RuntimeEnabledFeatures::deviceMotionEventEnabled):
(WebCore::RuntimeEnabledFeatures::ondevicemotionEnabled):
(WebCore::RuntimeEnabledFeatures::setDeviceOrientationEnabled):
(WebCore::RuntimeEnabledFeatures::deviceOrientationEnabled):
(WebCore::RuntimeEnabledFeatures::deviceOrientationEventEnabled):
(WebCore::RuntimeEnabledFeatures::ondeviceorientationEnabled):
(WebCore::RuntimeEnabledFeatures::setSpeechInputEnabled):
(WebCore::RuntimeEnabledFeatures::speechInputEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGrammarEnabled):
(WebCore::RuntimeEnabledFeatures::setScriptedSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::scriptedSpeechEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionErrorEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechRecognitionEventEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarEnabled):
(WebCore::RuntimeEnabledFeatures::webkitSpeechGrammarListEnabled):
(WebCore::RuntimeEnabledFeatures::setFileSystemEnabled):
(WebCore::RuntimeEnabledFeatures::setJavaScriptI18NAPIEnabled):
(WebCore::RuntimeEnabledFeatures::mediaStreamEnabled):
(WebCore::RuntimeEnabledFeatures::setMediaStreamEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGetUserMediaEnabled):
(WebCore::RuntimeEnabledFeatures::webkitMediaStreamEnabled):
(WebCore::RuntimeEnabledFeatures::peerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::setPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::webkitRTCPeerConnectionEnabled):
(WebCore::RuntimeEnabledFeatures::setLegacyCSSVendorPrefixesEnabled):
(WebCore::RuntimeEnabledFeatures::legacyCSSVendorPrefixesEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitGetGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::webkitGetGamepadsEnabled):
(WebCore::RuntimeEnabledFeatures::quotaEnabled):
(WebCore::RuntimeEnabledFeatures::setQuotaEnabled):
(WebCore::RuntimeEnabledFeatures::mediaSourceEnabled):
(WebCore::RuntimeEnabledFeatures::setMediaSourceEnabled):
(WebCore::RuntimeEnabledFeatures::encryptedMediaEnabled):
(WebCore::RuntimeEnabledFeatures::setEncryptedMediaEnabled):
(WebCore::RuntimeEnabledFeatures::webkitVideoTrackEnabled):
(WebCore::RuntimeEnabledFeatures::setWebkitVideoTrackEnabled):
(WebCore::RuntimeEnabledFeatures::shadowDOMEnabled):
(WebCore::RuntimeEnabledFeatures::setShadowDOMEnabled):
(WebCore::RuntimeEnabledFeatures::authorShadowDOMForAnyElementEnabled):
(WebCore::RuntimeEnabledFeatures::setAuthorShadowDOMForAnyElementEnabled):
(WebCore::RuntimeEnabledFeatures::customDOMElementsEnabled):
(WebCore::RuntimeEnabledFeatures::setCustomDOMElements):
(WebCore::RuntimeEnabledFeatures::styleScopedEnabled):
(WebCore::RuntimeEnabledFeatures::setStyleScopedEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeDateEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeDateEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeDateTimeEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeDateTimeEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeDateTimeLocalEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeDateTimeLocalEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeMonthEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeMonthEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeTimeEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeTimeEnabled):
(WebCore::RuntimeEnabledFeatures::inputTypeWeekEnabled):
(WebCore::RuntimeEnabledFeatures::setInputTypeWeekEnabled):
(WebCore::RuntimeEnabledFeatures::experimentalContentSecurityPolicyFeaturesEnabled):
(WebCore::RuntimeEnabledFeatures::setExperimentalContentSecurityPolicyFeaturesEnabled):
(WebCore::RuntimeEnabledFeatures::seamlessIFramesEnabled):
(WebCore::RuntimeEnabledFeatures::setSeamlessIFramesEnabled):
(WebCore::RuntimeEnabledFeatures::langAttributeAwareFormControlUIEnabled):
(WebCore::RuntimeEnabledFeatures::setLangAttributeAwareFormControlUIEnabled):
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::getCSSPropertyNamePrefix): Use singleton accessors.
(WebCore::cssPropertyIDForJSCSSPropertyName): Ditto.
- bindings/scripts/CodeGeneratorJS.pm:
(GetRuntimeEnableFunctionName): Generate singleton version of
accessors.
- css/CSSFontFace.cpp:
(WebCore::CSSFontFace::fontLoaded): Use singleton accessors.
(WebCore::CSSFontFace::getFontData): Ditto.
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule): Ditto.
- css/CSSParser.cpp:
(WebCore::isSimpleLengthPropertyID): Ditto.
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::rewriteSpecifiers):
- css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::fontLoaded): Ditto.
- css/StyleResolver.h:
(WebCore::StyleResolver::ensureScopeResolver): Ditto.
- dom/Document.cpp:
(WebCore::Document::cssRegionsEnabled): Ditto.
(WebCore::Document::cssCompositingEnabled):
(WebCore::Document::shouldDisplaySeamlesslyWithParent):
(WebCore::Document::getCachedLocale):
- dom/Element.cpp:
(WebCore::Element::createShadowRoot): Ditto.
- dom/Position.cpp:
(WebCore::Position::Position): Ditto.
(WebCore::Position::findParent):
- dom/TreeScope.cpp:
(WebCore::TreeScope::getSelection): Ditto.
- dom/make_names.pl:
(printConstructorInterior): Generate singleton version of accessors.
(printWrapperFunctions): Ditto.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isSpeechEnabled): Use singleton accessors.
(WebCore::HTMLInputElement::setupDateTimeChooserParameters): Ditto.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::finishParsingChildren): Ditto.
(WebCore::HTMLMediaElement::scheduleDelayedAction):
(WebCore::HTMLMediaElement::loadTimerFired):
(WebCore::HTMLMediaElement::prepareForLoad):
(WebCore::HTMLMediaElement::loadInternal):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::mediaPlayerDidAddAudioTrack):
(WebCore::HTMLMediaElement::mediaPlayerDidAddTextTrack):
(WebCore::HTMLMediaElement::mediaPlayerDidAddVideoTrack):
(WebCore::HTMLMediaElement::addAudioTrack):
(WebCore::HTMLMediaElement::addTextTrack):
(WebCore::HTMLMediaElement::addVideoTrack):
(WebCore::HTMLMediaElement::removeAudioTrack):
(WebCore::HTMLMediaElement::removeTextTrack):
(WebCore::HTMLMediaElement::removeVideoTrack):
(WebCore::HTMLMediaElement::audioTracks):
(WebCore::HTMLMediaElement::textTracks):
(WebCore::HTMLMediaElement::videoTracks):
(WebCore::HTMLMediaElement::didAddTextTrack):
(WebCore::HTMLMediaElement::didRemoveTextTrack):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::userCancelledLoad):
(WebCore::HTMLMediaElement::hasClosedCaptions):
(WebCore::HTMLMediaElement::setClosedCaptionsVisible):
(WebCore::HTMLMediaElement::configureTextTrackDisplay):
- html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::parseAttribute): Ditto.
(WebCore::HTMLStyleElement::scopedAttributeChanged):
(WebCore::HTMLStyleElement::unregisterWithScopingNode):
(WebCore::HTMLStyleElement::scoped):
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::parseAttribute): Ditto.
(WebCore::HTMLTrackElement::scheduleLoad):
(WebCore::HTMLTrackElement::canLoadUrl):
- html/InputType.cpp:
(WebCore::createInputTypeFactoryMap): Ditto.
- page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::experimentalFeaturesEnabled): Ditto.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::addEventListener): Ditto.
- page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks): Ditto.
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup): Ditto.
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setShadowDOMEnabled):
(WebCore::InternalSettings::setAuthorShadowDOMForAnyElementEnabled):
(WebCore::InternalSettings::setStyleScopedEnabled):
(WebCore::InternalSettings::setCSSExclusionsEnabled):
(WebCore::InternalSettings::setCSSShapesEnabled):
(WebCore::InternalSettings::setLangAttributeAwareFormControlUIEnabled):
../WebKit: [Windows] Refactor RuntimeEnabledFeatures as a Singleton
https://bugs.webkit.org/show_bug.cgi?id=121883
Reviewed by Jer Noble.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Expose singleton accessor for DLL clients.
../WebKit/blackberry: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.
Reviewed by Jer Noble.
- WebKitSupport/DumpRenderTreeSupport.cpp:
(DumpRenderTreeSupport::setStyleScopedEnabled): use
singleton accessor.
../WebKit/efl: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.
Reviewed by Jer Noble.
- WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setCSSRegionsEnabled): Use singleton.
(DumpRenderTreeSupportEfl::setSeamlessIFramesEnabled): Ditto.
- ewk/ewk_settings.cpp:
(ewk_settings_shadow_dom_enable_get): Ditto.
(ewk_settings_shadow_dom_enable_set):
- ewk/ewk_view.cpp:
(_ewk_view_priv_new): Ditto.
../WebKit/gtk: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.
Reviewed by Jer Noble.
- WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setCSSRegionsEnabled): Use singleton.
(DumpRenderTreeSupportGtk::setExperimentalContentSecurityPolicyFeaturesEnabled):
(DumpRenderTreeSupportGtk::setSeamlessIFramesEnabled):
(DumpRenderTreeSupportGtk::setShadowDOMEnabled):
(DumpRenderTreeSupportGtk::setStyleScopedEnabled):
- webkit/webkitwebview.cpp:
(webkit_web_view_update_settings): Ditto.
../WebKit/mac: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.
Reviewed by Jer Noble.
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Use singleton accessor.
(-[WebView _setDashboardBehavior:to:]): Ditto.
../WebKit/qt: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.
Reviewed by Jer Noble.
- Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply): Use singleton accessor.
- WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::setSeamlessIFramesEnabled): Ditto.
../WebKit/win: [Windows] Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883
Reviewed by Jer Noble.
- WebView.cpp:
(WebView::notifyPreferencesChanged): Use singleton accessor
../WebKit2: Refactor RuntimeEnabledFeatures as a Singleton.
https://bugs.webkit.org/show_bug.cgi?id=121883.
Reviewed by Jer Noble.
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner): Use
Singleton accessor.
(WebKit::InjectedBundle::setShadowDOMEnabled):
(WebKit::InjectedBundle::setCSSRegionsEnabled):
(WebKit::InjectedBundle::setCSSCompositingEnabled):
(WebKit::InjectedBundle::setSeamlessIFramesEnabled):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Ditto.
- WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformInitializeWebProcess): Ditto.
- 3:08 PM Changeset in webkit [156423] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for IDBDatabase.
Turns out there was a much cleaner way to express this.
- 2:13 PM Changeset in webkit [156422] by
-
- 34 edits in trunk/Source/WebCore
Tie the life of DocumentStyleSheetCollection and Document together
https://bugs.webkit.org/show_bug.cgi?id=121892
Reviewed by Andreas Kling.
DocumentStyleSheetCollection had an odd destruction pattern for no apparent reason.
The two objects strictly depend on eachother, this patch make that explicit by making
DocumentStyleSheetCollection a plain object in Document's memory space.
- css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::didMutateRules):
- css/DocumentRuleSets.cpp:
(WebCore::DocumentRuleSets::initUserStyle):
- css/DocumentRuleSets.h:
- css/InspectorCSSOMWrappers.cpp:
(WebCore::InspectorCSSOMWrappers::collectFromDocumentStyleSheetCollection):
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
- css/InspectorCSSOMWrappers.h:
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::matchRecursively):
(WebCore::SelectorChecker::checkOne):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::StyleResolver):
- css/StyleSheetList.cpp:
(WebCore::StyleSheetList::styleSheets):
(WebCore::StyleSheetList::detachFromDocument):
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::setCompatibilityMode):
(WebCore::Document::recalcStyle):
(WebCore::Document::createStyleResolver):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::preferredStylesheetSet):
(WebCore::Document::selectedStylesheetSet):
(WebCore::Document::setSelectedStylesheetSet):
(WebCore::Document::scheduleOptimizedStyleSheetUpdate):
(WebCore::Document::styleResolverChanged):
(WebCore::Document::haveStylesheetsLoaded):
- dom/Document.h:
(WebCore::Document::styleSheetCollection):
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::DocumentStyleSheetCollection):
(WebCore::DocumentStyleSheetCollection::combineCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::resetCSSFeatureFlags):
(WebCore::DocumentStyleSheetCollection::pageUserSheet):
(WebCore::DocumentStyleSheetCollection::clearPageUserSheet):
(WebCore::DocumentStyleSheetCollection::updatePageUserSheet):
(WebCore::DocumentStyleSheetCollection::updateInjectedStyleSheetCache):
(WebCore::DocumentStyleSheetCollection::invalidateInjectedStyleSheetCache):
(WebCore::DocumentStyleSheetCollection::addAuthorSheet):
(WebCore::DocumentStyleSheetCollection::addUserSheet):
(WebCore::DocumentStyleSheetCollection::removePendingSheet):
(WebCore::DocumentStyleSheetCollection::addStyleSheetCandidateNode):
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
(WebCore::DocumentStyleSheetCollection::analyzeStyleSheetChange):
(WebCore::collectActiveCSSStyleSheetsFromSeamlessParents):
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets):
- dom/DocumentStyleSheetCollection.h:
- dom/Element.cpp:
(WebCore::Element::createPseudoElementIfNeeded):
- dom/InlineStyleSheetOwner.cpp:
(WebCore::InlineStyleSheetOwner::insertedIntoDocument):
(WebCore::InlineStyleSheetOwner::removedFromDocument):
(WebCore::InlineStyleSheetOwner::clearDocumentData):
(WebCore::InlineStyleSheetOwner::createSheet):
(WebCore::InlineStyleSheetOwner::sheetLoaded):
(WebCore::InlineStyleSheetOwner::startLoadingDynamicSheet):
- dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::~ProcessingInstruction):
(WebCore::ProcessingInstruction::checkStyleSheet):
(WebCore::ProcessingInstruction::sheetLoaded):
(WebCore::ProcessingInstruction::insertedInto):
(WebCore::ProcessingInstruction::removedFrom):
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::~HTMLLinkElement):
(WebCore::HTMLLinkElement::insertedInto):
(WebCore::HTMLLinkElement::removedFrom):
(WebCore::HTMLLinkElement::addPendingSheet):
(WebCore::HTMLLinkElement::removePendingSheet):
- html/HTMLQuoteElement.cpp:
(WebCore::HTMLQuoteElement::insertedInto):
- html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::HTMLViewSourceDocument):
- inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::willMatchRule):
- inspector/InspectorCSSAgent.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willMatchRuleImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willMatchRule):
- mathml/MathMLMathElement.cpp:
(WebCore::MathMLMathElement::insertedInto):
- page/Page.cpp:
(WebCore::Page::userStyleSheetLocationChanged):
- page/PageGroup.cpp:
(WebCore::PageGroup::invalidateInjectedStyleSheetCacheInAllFrames):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::lineHeight):
(WebCore::RenderBlock::updateFirstLetter):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
(WebCore::RenderInline::lineHeight):
- rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::lineHeight):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::uncachedFirstLineStyle):
(WebCore::RenderObject::cachedFirstLineStyle):
- rendering/RenderObject.h:
(WebCore::RenderObject::firstLineStyle):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::verticalPositionForBox):
- style/StyleResolveTree.cpp:
(WebCore::Style::resolveLocal):
- testing/Internals.cpp:
(WebCore::Internals::insertAuthorCSS):
(WebCore::Internals::insertUserCSS):
- 1:58 PM Changeset in webkit [156421] by
-
- 8 edits in trunk/Source
FeatureDefine.xcconfig cleanup (They should all be identical).
https://bugs.webkit.org/show_bug.cgi?id=121921
Reviewed by Mark Rowe.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit2:
- Configurations/FeatureDefines.xcconfig:
- 1:57 PM Changeset in webkit [156420] by
-
- 7 edits in trunk/Source/WebKit2
Use tuples for encoding IPC messages
https://bugs.webkit.org/show_bug.cgi?id=121924
Reviewed by Andreas Kling.
Yet another step towards getting rid of the Arguments hierarchy.
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::handleMessage):
(CoreIPC::handleMessageVariadic):
(CoreIPC::handleMessageDelayed):
- Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::send):
- Scripts/webkit2/messages.py:
(arguments_type_old):
(arguments_type):
(reply_type):
(decode_type):
(delayed_reply_type):
(message_to_struct_declaration):
- Scripts/webkit2/messages_unittest.py:
(LoadURL):
(std):
(TouchEvent):
(DidReceivePolicyDecision):
(Close):
(PreferencesDidChange):
(SendDoubleAndFloat):
(SendInts):
(CreatePlugin):
(RunJavaScriptAlert):
(GetPlugins):
(GetPluginProcessConnection):
(TestMultipleAttributes):
(TestParameterAttributes):
(TemplateTest):
(DidCreateWebProcessConnection):
(InterpretKeyEvent):
(DeprecatedOperation):
(ExperimentalOperation):
- Shared/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::send):
- 1:01 PM Changeset in webkit [156419] by
-
- 45 edits in trunk/Source/WebCore
JS wrappers should have strongly typed impl() functions.
<https://webkit.org/b/121919>
Reviewed by Geoffrey Garen.
Generate strongly typed JSFoo::impl() functions for all wrappers,
not just those marked with JSGenerateToNativeObject.
Removed 8.8 million static_casts that are no longer needed.
- 12:22 PM Changeset in webkit [156418] by
-
- 3 edits in trunk/Tools
[WIN] Fix MSVC C4146 compiler warning
https://bugs.webkit.org/show_bug.cgi?id=121838
Reviewed by Brent Fulgham.
Fix some variables from unsinged to int to fix the compiler warning
"unary minus operator applied to unsigned type, result still unsigned".
- DumpRenderTree/WorkQueueItem.h:
(BackItem::BackItem):
(ForwardItem::ForwardItem):
- DumpRenderTree/win/DumpRenderTree.cpp:
(createWebViewAndOffscreenWindow):
- 12:13 PM Changeset in webkit [156417] by
-
- 2 edits in trunk/Tools
[GTK] Switch the 64-bit Release builder to testing layout tests under WK2
https://bugs.webkit.org/show_bug.cgi?id=121256
Reviewed by Martin Robinson.
Switch the GTK 64-bit Release builder to testing the layout tests under WebKit2.
The GTK 64-bit Release WK2 testing builder is switched to now run layout tests under WebKit1.
- BuildSlaveSupport/build.webkit.org-config/config.json:
- 12:04 PM Changeset in webkit [156416] by
-
- 5 edits in trunk/Source
https://bugs.webkit.org/show_bug.cgi?id=121885.
<rdar://problem/15072332>.
Reviewed by Brent Fulgham.
No new functionality added.
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollByRecursively):
- rendering/RenderLayer.h:
- WebView.cpp:
(WebView::gestureNotify):
(WebView::gesture):
- 12:02 PM Changeset in webkit [156415] by
-
- 4 edits in trunk/LayoutTests
Unreviewed GTK gardening. Moving WK1-specific failure expectations into the WK1-specific TestExpectations.
Also adding expectations for the currently failing tests on WK2.
- platform/gtk-wk1/TestExpectations:
- platform/gtk-wk2/TestExpectations:
- platform/gtk/TestExpectations:
- 11:56 AM Changeset in webkit [156414] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed build fix: Add new syntax of function declaration to
Windows export definition file.
- 11:52 AM Changeset in webkit [156413] by
-
- 69 edits in trunk/Source/WebCore
Reduce repetitive EventTarget subclassing.
<https://webkit.org/b/121915>
Reviewed by Antti Koivisto.
Add a EventTargetWithInlineData helper class to EventTarget.h.
It's a simple subclass with an EventTargetData member and FINAL
eventTargetData()/ensureEventTargetData() overrides.
Turns out that this fits almost every use case except Node and
SVGElementInstance.
Inlined most of the FINAL EventTarget overrides since they will
be called on tight pointers by generated bindings code and this
removes the need for virtual dispatch.
Spammed OVERRIDE FINAL as appropriate, we can't make the whole
classes FINAL until bug 121747 is fixed, so added FIXMEs.
- 11:51 AM Changeset in webkit [156412] by
-
- 1 edit42 adds12 deletes in trunk/LayoutTests
Unreviewed GTK gardening. Moving around and updating the GTK baselines that are
either specific to WK1 or WK2 or can be shared by both.
- platform/gtk-wk1/http: Added.
- platform/gtk-wk1/http/tests: Added.
- platform/gtk-wk1/http/tests/cache: Added.
- platform/gtk-wk1/http/tests/cache/cancel-multiple-post-xhrs-expected.txt: Added.
- platform/gtk-wk1/http/tests/security: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-only-expected.txt: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt: Added.
- platform/gtk-wk1/http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt: Added.
- platform/gtk-wk2/http: Added.
- platform/gtk-wk2/http/tests: Added.
- platform/gtk-wk2/http/tests/loading: Added.
- platform/gtk-wk2/http/tests/loading/basic-auth-resend-wrong-credentials-expected.txt: Added.
- platform/gtk-wk2/http/tests/loading/basic-credentials-sent-automatically-expected.txt: Added.
- platform/gtk-wk2/http/tests/misc: Added.
- platform/gtk-wk2/http/tests/misc/401-alternative-content-expected.txt: Added.
- platform/gtk-wk2/http/tests/misc/authentication-redirect-1: Added.
- platform/gtk-wk2/http/tests/misc/authentication-redirect-1/authentication-sent-to-redirect-cross-origin-expected.txt: Added.
- platform/gtk-wk2/http/tests/misc/authentication-redirect-2: Added.
- platform/gtk-wk2/http/tests/misc/authentication-redirect-2/authentication-sent-to-redirect-same-origin-expected.txt: Added.
- platform/gtk-wk2/http/tests/misc/authentication-redirect-4: Added.
- platform/gtk-wk2/http/tests/misc/authentication-redirect-4/authentication-sent-to-redirect-same-origin-url-expected.txt: Added.
- platform/gtk-wk2/http/tests/security: Added.
- platform/gtk-wk2/http/tests/security/401-logout: Added.
- platform/gtk-wk2/http/tests/security/401-logout/401-logout-expected.txt: Added.
- platform/gtk-wk2/http/tests/xmlhttprequest: Added.
- platform/gtk-wk2/http/tests/xmlhttprequest/failed-auth-expected.txt: Added.
- platform/gtk-wk2/http/tests/xmlhttprequest/remember-bad-password-expected.txt: Added.
- platform/gtk-wk2/js: Added.
- platform/gtk-wk2/js/dom: Added.
- platform/gtk-wk2/js/dom/constructor-length-expected.txt: Added.
- platform/gtk-wk2/js/dom/global-constructors-attributes-expected.txt: Added.
- platform/gtk/http/tests/cache: Removed.
- platform/gtk/http/tests/cache/cancel-multiple-post-xhrs-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-and-enforce-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-data-uri-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-file-uri-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-uri-cross-origin-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-blocked-uri-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-only-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-only-from-header-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-inline-javascript-expected.txt: Removed.
- platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-javascript-expected.txt: Removed.
- platform/gtk/userscripts: Added.
- platform/gtk/userscripts/script-run-at-end-expected.txt: Added.
- 11:43 AM Changeset in webkit [156411] by
-
- 2 edits in trunk/Source/WebKit
[Windows] Unreviewed build fix after r156408.
- 11:29 AM Changeset in webkit [156410] by
-
- 2 edits in trunk/LayoutTests
loader/go-back-to-different-window-size.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=96642
- platform/mac/TestExpectations: Marking it as flaky on Mac. I think that it's
a general issue with the tools that window resizing doesn't work well.
- 11:21 AM Changeset in webkit [156409] by
-
- 6 edits in trunk
AX: WebKit doesn't map aria-sort=other on OS X
https://bugs.webkit.org/show_bug.cgi?id=118511
Patch by Sam White <Samuel White> on 2013-09-25
Reviewed by Chris Fleizach.
Source/WebCore:
No new tests, updated existing aria-sort test to validate addition of "other"
sort order per http://www.w3.org/TR/wai-aria/complete#aria-sort.
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::sortDirection):
- accessibility/AccessibilityObject.h:
LayoutTests:
Updated test to check "other" aria-sort order. Also added additional checks to
determine which elements expose aria-sort so our "none" case is more clear.
- accessibility/aria-sort-expected.txt:
- accessibility/aria-sort.html:
- 11:09 AM Changeset in webkit [156408] by
-
- 65 edits in trunk/Source/WebCore
CTTE: More Document references please
https://bugs.webkit.org/show_bug.cgi?id=121893
Reviewed by Anders Carlsson.
- Thread even more Document&s around. *
- 11:07 AM Changeset in webkit [156407] by
-
- 2 edits in trunk/Source/WebCore
HasMemoryCostMemberFunction should work for final classes
https://bugs.webkit.org/show_bug.cgi?id=121747
Reviewed by Sam Weinig.
Use decltype to check for the memoryCost() member function. This doesn't check that the return type is size_t, but
the build will fail anyway if that's the case (or if the return type is not convertible to size_t).
- bindings/js/JSDOMBinding.h:
- 11:02 AM Changeset in webkit [156406] by
-
- 11 edits13 moves1 delete in trunk/Source/WebCore
More refactoring to make the LevelDB dependencies of IDB more obvious.
https://bugs.webkit.org/show_bug.cgi?id=121880
Reviewed by Alexey Proskuryakov.
This patch does three things:
1 - Moves some files to the indexeddb/leveldb subdirectory, renaming them in the process.
2 - Renames some classes.
3 - Adds "USE(LEVELDB)" guards in addition to the ENABLE(INDEXED_DATABASE) guard for those files.
Project file updates:
- GNUmakefile.am:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.xcodeproj/project.pbxproj:
- WebCore.vcxproj/WebCore.vcxproj:
File renames, class renames, and USE(LEVELDB) guards:
- Modules/indexeddb/IDBBackingStore.cpp: Removed.
- Modules/indexeddb/IDBFactoryBackendInterface.cpp:
(WebCore::IDBFactoryBackendInterface::create): Add a null return if USE(LEVELDB) is disabled as a stop gap measure until
there is a non-LevelDB impl.
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBBackingStore.h.
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.cpp.
- Modules/indexeddb/leveldb/IDBCursorBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.h.
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.cpp.
- Modules/indexeddb/leveldb/IDBDatabaseBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBDatabaseBackendImpl.h.
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBFactoryBackendImpl.cpp.
- Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBFactoryBackendImpl.h.
- Modules/indexeddb/leveldb/IDBLevelDBCoding.cpp:
- Modules/indexeddb/leveldb/IDBLevelDBCoding.h:
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp.
- Modules/indexeddb/leveldb/IDBObjectStoreBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.h.
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp.
- Modules/indexeddb/leveldb/IDBTransactionBackendLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.h.
- Modules/indexeddb/leveldb/IDBTransactionCoordinatorLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionCoordinator.cpp.
- Modules/indexeddb/leveldb/IDBTransactionCoordinatorLevelDB.h: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionCoordinator.h.
- 11:00 AM Changeset in webkit [156405] by
-
- 3 edits in trunk/Tools
Add style checker for CMake lists
https://bugs.webkit.org/show_bug.cgi?id=121764
Reviewed by Ryosuke Niwa.
Add an additional check to make sure that list of files are sorted.
Exclude lists of include directories for now, since the order
can be importent for compilation of some files.
- Scripts/webkitpy/style/checkers/cmake.py:
(CMakeChecker.check):
(CMakeChecker._check_indent):
(CMakeChecker):
(CMakeChecker._check_list_order):
(CMakeChecker._list_item_path):
- Scripts/webkitpy/style/checkers/cmake_unittest.py:
(CMakeCheckerTest.test_check):
- 10:45 AM Changeset in webkit [156404] by
-
- 4 edits2 adds in trunk
REGRESSION (r156355) Links / interactive elements inside nested tables are unclickable
https://bugs.webkit.org/show_bug.cgi?id=121904
Reviewed by Andreas Kling.
Source/WebCore:
Test: fast/table/hittest-self-painting.html
Original reduction by Philippe Wittenbergh.
- rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange):
Tighten a bit.
(WebCore::RenderTableRow::nodeAtPoint):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::nodeAtPoint):
These flipped accidentally in r156355.
LayoutTests:
- fast/table/hittest-self-painting-expected.txt: Added.
- fast/table/hittest-self-painting.html: Added.
- 10:40 AM Changeset in webkit [156403] by
-
- 5 edits in trunk/Tools
CMakeChecker takes unusually long time to run
https://bugs.webkit.org/show_bug.cgi?id=105662
Reviewed by Ryosuke Niwa.
Move the caching mechanism for regular expression of the C++ checker into
a common file and use it for the CMake and ChangeLog checkers too.
- Scripts/webkitpy/style/checkers/changelog.py:
(ChangeLogChecker.check_entry):
- Scripts/webkitpy/style/checkers/cmake.py:
(CMakeChecker._process_line):
(CMakeChecker._check_no_space_cmds):
(CMakeChecker._check_one_space_cmds):
(CMakeChecker._check_non_lowercase_cmd):
- Scripts/webkitpy/style/checkers/common.py:
(match):
(search):
(searchIgnorecase):
(sub):
(subn):
- Scripts/webkitpy/style/checkers/cpp.py:
- 9:33 AM Changeset in webkit [156402] by
-
- 2 edits in trunk/Source/JavaScriptCore
Build fix for WinCE after r155098.
Windows CE does not support getenv().
- jsc.cpp:
(main):
- 9:32 AM Changeset in webkit [156401] by
-
- 2 edits in trunk/Source/WTF
Fix template deduction for CollatorDefault
- wtf/unicode/CollatorDefault.cpp:
(WTF::Collator::userDefault): Use nullptr instead of 0.
- 9:08 AM Changeset in webkit [156400] by
-
- 2 edits in trunk/Source/WebCore
Fix warning in makeprop.pl
https://bugs.webkit.org/show_bug.cgi?id=121900
Reviewed by Ryosuke Niwa.
%nameIsInherited and %nameToId were incorrectly initialized using
references instead of lists.
Anyway there's no need to initialize those variables explicitly,
they're already empty by default.
- css/makeprop.pl:
- 9:02 AM Changeset in webkit [156399] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r156393): Build with !ENABLE(SVG_FONTS) broken
Unreviewed build-fix.
Protect SVG font code with #ifdef ENABLE(SVG_FONTS).
- platform/graphics/WidthIterator.cpp:
(WebCore::applyFontTransforms):
- 8:41 AM Changeset in webkit [156398] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r156272.
http://trac.webkit.org/changeset/156272
https://bugs.webkit.org/show_bug.cgi?id=121909
Has no real effect (Requested by carewolf on #webkit).
- platform/graphics/qt/TileQt.cpp:
(WebCore::TileQt::updateBackBuffer):
- 8:40 AM Changeset in webkit [156397] by
-
- 16 edits in trunk/Source/WebCore
Move wheel event dispatch from Node to Element.
<https://webkit.org/b/121908>
Reviewed by Anders Carlsson.
Wheel events are only ever dispatched on Elements, so move the logic out of Node.
Had to make RenderBox::scroll() and friends return a stopElement instead of a
stopNode (out argument) to make this work, though it was only ever returning
Elements there anyway.
- 8:06 AM Changeset in webkit [156396] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed gardening. Unskip passing fast/text/font-kerning.html
https://bugs.webkit.org/show_bug.cgi?id=121907
Unreviewed EFL gardening. Passes after r152411.
Patch by Sanghyup Lee <sh53.lee@samsung.com> on 2013-09-25
- platform/efl/TestExpectations:
- 7:57 AM Changeset in webkit [156395] by
-
- 13 edits in trunk
[Qt] Fix build with Qt 5.2 QtPosition module
https://bugs.webkit.org/show_bug.cgi?id=121089
Reviewed by Simon Hausmann.
.:
QtLocation -> QtPositioning
- Source/sync.profile:
Source/WebKit:
QtLocation -> QtPositioning
- WebKit1.pri:
Source/WebKit/qt:
QtLocation -> QtPositioning
- WebCoreSupport/GeolocationClientQt.cpp:
Source/WebKit2:
QtLocation -> QtPositioning
- Target.pri:
- UIProcess/qt/WebGeolocationProviderQt.cpp:
- WebKit2.pri:
Tools:
QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
that might depend on them.
- qmake/mkspecs/features/default_pre.prf:
- qmake/mkspecs/features/features.prf:
- 7:50 AM Changeset in webkit [156394] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Fix build with !ENABLE(BLOB) after r156330
Unreviewed build-fix.
- platform/network/qt/ResourceRequestQt.cpp:
(WebCore::ResourceRequest::toNetworkRequest):
- 7:19 AM Changeset in webkit [156393] by
-
- 13 edits3 adds in trunk
Support kerning with SVG web fonts
https://bugs.webkit.org/show_bug.cgi?id=117540
Source/WebCore:
Reviewed by Stephen Chenney.
Adds the glue to WidthIterator to take advantage of kerning in SVG web fonts.
To supply SVG font kerning with its required text input, the signature of
applyFontTransforms has been extended.
Since SVG font kerning was extremely slow, it has been sped up by replacing
the iteration over all possible kerning definitions with a hash-map based
lookup of the leading symbol to be kerned. The new algorithm provides a
roughly 100x speed-up in SVG font kerning.
Test: fast/text/svg-font-face-with-kerning.html
- platform/graphics/TextRun.h:
(WebCore::TextRun::string):
- platform/graphics/WidthIterator.cpp:
(WebCore::applyFontTransforms):
(WebCore::WidthIterator::advanceInternal):
- rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::applySVGKerning):
- rendering/svg/SVGTextRunRenderingContext.h:
- svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::invalidateGlyphCache):
(WebCore::SVGFontElement::ensureGlyphCache):
(WebCore::SVGKerningMap::clear):
(WebCore::SVGKerningMap::insert):
(WebCore::stringMatchesUnicodeRange):
(WebCore::stringMatchesGlyphName):
(WebCore::stringMatchesUnicodeName):
(WebCore::matches):
(WebCore::kerningForPairOfStringsAndGlyphs):
(WebCore::SVGFontElement::horizontalKerningForPairOfStringsAndGlyphs):
(WebCore::SVGFontElement::verticalKerningForPairOfStringsAndGlyphs):
- svg/SVGFontElement.h:
(WebCore::SVGKerning::SVGKerning):
(WebCore::SVGKerningMap::isEmpty):
- svg/SVGHKernElement.cpp:
(WebCore::SVGHKernElement::buildHorizontalKerningPair):
- svg/SVGHKernElement.h:
- svg/SVGVKernElement.cpp:
(WebCore::SVGVKernElement::buildVerticalKerningPair):
- svg/SVGVKernElement.h:
LayoutTests:
Added test of SVG web font kerning.
Reviewed by Stephen Chenney.
- fast/text/svg-font-face-with-kerning-expected.png: Added.
- fast/text/svg-font-face-with-kerning-expected.txt: Added.
- fast/text/svg-font-face-with-kerning.html: Added.
- 7:16 AM Changeset in webkit [156392] by
-
- 2 edits in trunk/LayoutTests
[GTK] Update test expectations. Mark fast/images/exif-orientation.html as failing.
https://bugs.webkit.org/show_bug.cgi?id=121906
Unreviewed GTK gardening.
Patch by Anton Obzhirov <Anton Obzhirov> on 2013-09-25
- platform/gtk/TestExpectations: Mark fast/images/exif-orientation.html as failing,
as reported in webkit.org/b/121905.
- 6:53 AM Changeset in webkit [156391] by
-
- 10 edits9 adds in trunk
<https://webkit.org/b/120476> [CSS Masking] Implement luminance masking
Source/WebCore:
Added implementation for luminance masking. A luminance mask is applied by transforming its RGB values into
an alpha value, using luminance-to-alpha coefficients. Because this conversion is already implemented in
the ImageBuffer class, we used it in our implementation.
Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-25
Reviewed by Dirk Schulze.
Tests: css3/masking/mask-luminance-gradient.html
css3/masking/mask-luminance-png.html
css3/masking/mask-luminance-svg.html
- platform/graphics/BitmapImage.cpp: Add a drawPattern method, in which an ImageBuffer is created and converted from alpha to luminance, if there is a luminance mask.
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::drawPattern):
- platform/graphics/BitmapImage.h:
- platform/graphics/GeneratorGeneratedImage.cpp: Convert the ImageBuffer to luminance, if necessary.
(WebCore::GeneratorGeneratedImage::drawPattern):
- platform/graphics/GraphicsContext.cpp: Add methods which set and check if a luminance mask is drawn.
(WebCore::GraphicsContext::setDrawLuminanceMask):
(WebCore::GraphicsContext::drawLuminanceMask):
- platform/graphics/GraphicsContext.h: Add property to ContextState for luminance drawing.
(WebCore::GraphicsContextState::GraphicsContextState):
- rendering/RenderBoxModelObject.cpp: Set the luminance property of the mask, if the layer has a mask source type of luminance.
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
- svg/graphics/SVGImage.cpp: Convert the ImageBuffer to luminance, if necessary.
(WebCore::SVGImage::drawPatternForContainer):
- svg/graphics/SVGImageForContainer.cpp: Pass the luminance property to the SVG image.
(WebCore::SVGImageForContainer::drawPattern):
LayoutTests:
Added tests to verify the implementation of luminance masking.
Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-25
Reviewed by Dirk Schulze.
- css3/masking/mask-luminance-gradient-expected.html: Added.
- css3/masking/mask-luminance-gradient.html: Added.
- css3/masking/mask-luminance-png.html: Added.
- css3/masking/mask-luminance-svg-expected.html: Added.
- css3/masking/mask-luminance-svg.html: Added.
- css3/masking/resources/circle-alpha.svg: Added.
- css3/masking/resources/circle2.svg: Added.
- css3/masking/resources/dice.png: Added.
- platform/mac/css3/masking/mask-luminance-png-expected.txt: Added.
- 6:02 AM Changeset in webkit [156390] by
-
- 10 edits2 deletes in trunk/Source/WebCore
Remove EventPathWalker.
<https://webkit.org/b/121890>
Reviewed by Antti Koivisto.
Purge some more leftover Shadow DOM code.
- dom/EventPathWalker.cpp:
- dom/EventPathWalker.h:
Removed.
- dom/EventRetargeter.cpp:
(WebCore::nodeOrHostIfPseudoElement):
(WebCore::EventRetargeter::calculateEventPath):
(WebCore::EventRetargeter::buildRelatedNodeMap):
If starting at a pseudo element, e.g for events originating from
a transition on :before/:after, retarget to the pseudo element's
host as appropriate. This was the only real "feature" we were
using in EventPathWalker.
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDraggedEvent):
(WebCore::EventHandler::updateDragAndDrop):
(WebCore::EventHandler::updateMouseEventTargetNode):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::handleTouchEvent):
Replace use of EventPathWalker with parentOrShadowHostElement()
parent chain climbing.
- 5:50 AM Changeset in webkit [156389] by
-
- 3 edits in trunk/LayoutTests
[EFL] Updated accessibility expectations after r154781 and r155599
https://bugs.webkit.org/show_bug.cgi?id=121901
Unreviewed EFL gardening.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-25
- platform/efl/accessibility/menu-list-sends-change-notification-expected.txt:
- platform/efl/accessibility/notification-listeners-expected.txt:
- 5:33 AM Changeset in webkit [156388] by
-
- 3 edits in trunk/Tools
[ATK] Fix style issues in AccessibilityUIElementAtk
https://bugs.webkit.org/show_bug.cgi?id=121898
Reviewed by Chris Fleizach.
Avoid the '.f' suffix for float literals and use G_VALUE_INIT
instead of { 0, { { 0 } } } to initialize a GValue.
- DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:
(AccessibilityUIElement::clickPointX): Remove suffix.
(AccessibilityUIElement::clickPointY): Ditto.
(AccessibilityUIElement::intValue): Use G_VALUE_INIT and remove suffix.
(AccessibilityUIElement::minValue): Ditto.
(AccessibilityUIElement::maxValue): Ditto.
(AccessibilityUIElement::numberAttributeValue): Remove suffix.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::numberAttributeValue): Remove suffix.
(WTR::AccessibilityUIElement::x): Ditto.
(WTR::AccessibilityUIElement::y): Ditto.
(WTR::AccessibilityUIElement::width): Ditto.
(WTR::AccessibilityUIElement::height): Ditto.
(WTR::AccessibilityUIElement::clickPointX): Ditto.
(WTR::AccessibilityUIElement::clickPointY): Ditto.
(WTR::AccessibilityUIElement::intValue): Ditto.
(WTR::AccessibilityUIElement::minValue): Ditto.
(WTR::AccessibilityUIElement::maxValue): Ditto.
- 5:21 AM Changeset in webkit [156387] by
-
- 4 edits2 adds in trunk
:read-write pseudo-class should not be applied on <input type="text" disabled>
https://bugs.webkit.org/show_bug.cgi?id=118236
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-25
Reviewed by Darin Adler.
Source/WebCore:
The :read-write pseudo-class must match any element falling into one
of the following categories i.e
input elements to which the readonly attribute applies, and that are mutable
(i.e. that do not have the readonly attribute specified and that are not disabled)
textarea elements that do not have a readonly attribute, and that are not disabled
elements that are editing hosts or editable and are neither input elements nor
textarea elements.
Test: fast/css/readwrite-pseudoclass-input.html
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::matchesReadWritePseudoClass):
- html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::matchesReadWritePseudoClass):
Checking for both readonly and disabled attribute on input ane textarea element.
LayoutTests:
- fast/css/readwrite-pseudoclass-input-expected.txt: Added.
- fast/css/readwrite-pseudoclass-input.html: Added.
Added test case to verify that :read-write pseudo-class properties are
are not applied to disabled input and textarea elements.
- 4:02 AM Changeset in webkit [156386] by
-
- 9 edits in trunk
[EFL] accessibility/loading-iframe-sends-notification.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112003
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-25
Reviewed by Mario Sanchez Prada.
Source/WebCore:
Enabled AXLayoutComplete on EFL platform.
- dom/Document.cpp:
(WebCore::Document::implicitClose):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
Tools:
Enabled addNotificationListener and removeNotificationListener for EFL port.
- WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
(WTR::AccessibilityController::removeNotificationListener):
LayoutTests:
- platform/efl-wk1/TestExpectations: Removed loading-iframe-sends-notification.html.
- platform/efl-wk2/TestExpectations: Removed loading-iframe-sends-notification.html.
Sep 24, 2013:
- 10:38 PM Changeset in webkit [156385] by
-
- 2 edits in trunk/Source/WebKit2
Remove erroneous reference to libWTF.a in the WebKit2 Xcode project file.
Rubber-stamped by Alexey Proskuryakov.
- WebKit2.xcodeproj/project.pbxproj:
- 10:37 PM Changeset in webkit [156384] by
-
- 2 edits in trunk/Source/WebKit2
Remove the Windows-specific rules from WebKit2's DerivedSources.make, Windows is not supported anymore
https://bugs.webkit.org/show_bug.cgi?id=121895
Reviewed by Alexey Proskuryakov.
- DerivedSources.make:
Remove Windows-specific rules, and, now that only the Mac is using this file, remove the
Mac checks.
- 10:22 PM Changeset in webkit [156383] by
-
- 11 edits in trunk/Source/WebCore
Unreviewed, rolling out r156379.
http://trac.webkit.org/changeset/156379
https://bugs.webkit.org/show_bug.cgi?id=121894
Caused many assertion failures (Requested by ap on #webkit).
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):
- css/TransformFunctions.cpp:
(WebCore::transformsForValue):
- css/WebKitCSSArrayFunctionValue.h:
- css/WebKitCSSFilterValue.h:
- css/WebKitCSSMatFunctionValue.h:
- css/WebKitCSSMixFunctionValue.h:
- css/WebKitCSSSVGDocumentValue.h:
- css/WebKitCSSShaderValue.h:
(WebCore::toWebKitCSSShaderValue):
- css/WebKitCSSTransformValue.h:
- 8:34 PM Changeset in webkit [156382] by
-
- 3 edits2 adds in trunk
Crash in Document::setFocusedElement
https://bugs.webkit.org/show_bug.cgi?id=121888
Reviewed by Andreas Kling.
Source/WebCore:
Merge https://chromium.googlesource.com/chromium/blink/+/4a594a3de7d9761462b55fb27a6850d767419af2
The crash was caused by attempting to call Chrome:focusedNodeChanged() after m_page had already
been cleared. This could happen when blur's event handler removes the iframe from which
the focus had been moved. Fixed the bug by adding a null pointer check.
Test: fast/events/blur-remove-parent-crash.html
- dom/Document.cpp:
(WebCore::Document::setFocusedElement):
LayoutTests:
- fast/events/blur-remove-parent-crash-expected.txt: Added.
- fast/events/blur-remove-parent-crash.html: Added.
- 8:09 PM Changeset in webkit [156381] by
-
- 19 edits3 deletes in trunk/Source/WebCore
Remove HTMLContentElement
https://bugs.webkit.org/show_bug.cgi?id=121891
Reviewed by Andreas Kling.
Remove an unsused Shadow DOM type.
- DerivedSources.make:
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLDetailsElement.cpp:
- html/HTMLSummaryElement.cpp:
- html/HTMLTagNames.in:
- html/shadow/ContentDistributor.cpp:
- html/shadow/HTMLContentElement.cpp: Removed.
- html/shadow/HTMLContentElement.h: Removed.
- html/shadow/HTMLContentElement.idl: Removed.
- html/shadow/InsertionPoint.h:
(WebCore::InsertionPoint::matchTypeFor):
- testing/Internals.cpp:
- testing/Internals.h:
- testing/Internals.idl:
- 6:18 PM Changeset in webkit [156380] by
-
- 2 edits in trunk/Source/WebCore
Remove a contradiction from SelectorChecker
https://bugs.webkit.org/show_bug.cgi?id=121881
Reviewed by Andreas Kling.
The matching code for PseudoHover and PseudoActive is done on the current
selector pseudo type. The current selector match type must be CSSSelector::PseudoClass
in order to reach this code. Consequently, selector->m_match == CSSSelector::Tag can
never be true.
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- 6:17 PM Changeset in webkit [156379] by
-
- 11 edits in trunk/Source/WebCore
Add toWebKitCSS*Value functions to cast from CSSValue
https://bugs.webkit.org/show_bug.cgi?id=121776
Reviewed by Darin Adler.
CSS_VALUE_TYPE_CASTS can't cover WebKitCSS*Value classes. So, this patch adds toWebKitCSS*Value manually.
No new tests, no behavior change.
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):
- css/TransformFunctions.cpp:
(WebCore::transformsForValue):
- css/WebKitCSSArrayFunctionValue.h:
(WebCore::toWebKitCSSArrayFunctionValue):
- css/WebKitCSSFilterValue.h:
(WebCore::toWebKitCSSFilterValue):
- css/WebKitCSSMatFunctionValue.h:
(WebCore::toWebKitCSSMatFunctionValue):
- css/WebKitCSSMixFunctionValue.h:
(WebCore::toWebKitCSSMixFunctionValue):
- css/WebKitCSSSVGDocumentValue.h:
(WebCore::toWebKitCSSSVGDocumentValue):
- css/WebKitCSSShaderValue.h:
(WebCore::toWebKitCSSShaderValue):
- css/WebKitCSSTransformValue.h:
(WebCore::toWebKitCSSTransformValue):
- 6:03 PM Changeset in webkit [156378] by
-
- 4 edits in trunk/Source/WebKit2
Only allow rvalues to be passed as synchronous message replies
https://bugs.webkit.org/show_bug.cgi?id=121870
Reviewed by Andreas Kling.
This lets us get rid of a nasty const cast and is more logical.
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::sendSync):
- Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::send):
(CoreIPC::MessageSender::sendSync):
- Shared/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::sendSync):
- 6:01 PM Changeset in webkit [156377] by
-
- 12 edits in trunk/Source/WebCore
Clean up some uses of first/lastChildSlow
https://bugs.webkit.org/show_bug.cgi?id=121882
Reviewed by Andreas Kling.
Tighten typing and use first/lastChild instead.
- dom/Position.cpp:
(WebCore::Position::hasRenderedNonAnonymousDescendantsWithHeight):
(WebCore::Position::isCandidate):
(WebCore::Position::getInlineBoxAndOffset):
- dom/Position.h:
- dom/PositionIterator.cpp:
(WebCore::PositionIterator::isCandidate):
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
- rendering/RenderBlock.cpp:
(WebCore::canMergeAnonymousBlock):
(WebCore::canMergeContiguousAnonymousBlocks):
(WebCore::RenderBlock::firstLineBlock):
(WebCore::RenderBlock::updateFirstLetter):
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
(WebCore::RenderRegion::computeChildrenStyleInRegion):
- rendering/RenderRegion.h:
- rendering/RenderRuby.cpp:
(WebCore::rubyBeforeBlock):
(WebCore::rubyAfterBlock):
(WebCore::lastRubyRun):
- rendering/RenderTreeAsText.cpp:
(WebCore::write):
(WebCore::writeCounterValuesFromChildren):
- rendering/svg/RenderSVGText.cpp:
(WebCore::findPreviousAndNextAttributes):
- style/StyleResolveTree.cpp:
(WebCore::Style::textRendererIsNeeded):
- 5:37 PM Changeset in webkit [156376] by
-
- 13 edits6 adds in trunk
op_get_callee shouldn't use value profiling
https://bugs.webkit.org/show_bug.cgi?id=121821
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Currently it's one of the two opcodes that uses m_singletonValue, which is unnecessary.
Our current plan is to remove m_singletonValue so that GenGC can have a simpler story
for handling CodeBlocks/FunctionExecutables during nursery collections.
Instead of using a ValueProfile op_get_callee now has a simple inline cache of the most
recent JSFunction that we saw.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::finalizeUnconditionally):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCreateThis):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- jit/JIT.cpp:
(JSC::JIT::privateCompileSlowCases):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_get_callee):
(JSC::JIT::emitSlow_op_get_callee):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_get_callee):
(JSC::JIT::emitSlow_op_get_callee):
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/CommonSlowPaths.h:
LayoutTests:
Added two tests to make sure we didn't regress the performance of op_get_callee.
- js/regress/get_callee_monomorphic-expected.txt: Added.
- js/regress/get_callee_monomorphic.html: Added.
- js/regress/get_callee_polymorphic-expected.txt: Added.
- js/regress/get_callee_polymorphic.html: Added.
- js/regress/script-tests/get_callee_monomorphic.js: Added.
- js/regress/script-tests/get_callee_polymorphic.js: Added.
- 5:14 PM Changeset in webkit [156375] by
-
- 5 edits in trunk
initial commit
- 4:52 PM Changeset in webkit [156374] by
-
- 25 edits in trunk/Source
Change JSC debug hooks to pass a CallFrame* instead of a DebuggerCallFrame.
https://bugs.webkit.org/show_bug.cgi?id=121867.
Reviewed by Geoffrey Garen.
Source/JavaScriptCore:
- Removed the need for passing the line and column info to the debug hook callbacks. We now get the line and column info from the CallFrame.
- Simplify BytecodeGenerator::emitDebugHook() to only take 1 line number argument. The caller can determine whether to pass in the first or last line number of the block of source code as appropriate. Note: we still need to pass in the line and column info to emitDebugHook() because it uses this info to emit expression info which is later used by the StackVisitor to determine the line and column info for its "pc".
- Pass the exceptionValue explicitly to the exception() debug hook callback. It should not be embedded in the CallFrame / DebuggerCallFrame.
- Change the op_debug opcode size to 2 (from 5) since we've removing 3 arg values. Update the LLINT and JIT code to handle this.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
- bytecode/Opcode.h:
(JSC::padOpcodeName):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
- bytecompiler/BytecodeGenerator.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::ConstStatementNode::emitBytecode):
(JSC::EmptyStatementNode::emitBytecode):
(JSC::DebuggerStatementNode::emitBytecode):
(JSC::ExprStatementNode::emitBytecode):
(JSC::VarStatementNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::SwitchNode::emitBytecode):
(JSC::LabelNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):
(JSC::TryNode::emitBytecode):
(JSC::ProgramNode::emitBytecode):
(JSC::EvalNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):
- debugger/Debugger.h:
- debugger/DebuggerCallFrame.cpp:
(JSC::LineAndColumnFunctor::operator()):
(JSC::LineAndColumnFunctor::line):
(JSC::LineAndColumnFunctor::column):
(JSC::DebuggerCallFrame::DebuggerCallFrame):
(JSC::DebuggerCallFrame::clear):
- debugger/DebuggerCallFrame.h:
(JSC::DebuggerCallFrame::line):
(JSC::DebuggerCallFrame::column):
- interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
(JSC::UnwindFunctor::UnwindFunctor):
(JSC::UnwindFunctor::operator()):
(JSC::Interpreter::unwind):
(JSC::Interpreter::debug):
- interpreter/Interpreter.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_debug):
- jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_debug):
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- llint/LowLevelInterpreter.asm:
Source/WebCore:
No new tests.
- bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::createCallFrame):
(WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
(WebCore::ScriptDebugServer::callEvent):
(WebCore::ScriptDebugServer::atStatement):
(WebCore::ScriptDebugServer::returnEvent):
(WebCore::ScriptDebugServer::exception):
(WebCore::ScriptDebugServer::willExecuteProgram):
(WebCore::ScriptDebugServer::didExecuteProgram):
(WebCore::ScriptDebugServer::didReachBreakpoint):
- bindings/js/ScriptDebugServer.h:
- bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::willExecuteProgram):
- bindings/js/WorkerScriptDebugServer.h:
Source/WebKit/mac:
- WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFrame _initWithGlobalObject:debuggerCallFrame:exceptionValue:JSC::]):
(-[WebScriptCallFrame exception]):
- WebView/WebScriptDebugger.h:
- WebView/WebScriptDebugger.mm:
(WebScriptDebugger::exception):
- 4:47 PM Changeset in webkit [156373] by
-
- 3 edits in trunk/LayoutTests
webgl/conformance/extensions/oes-element-index-uint.html failing after r156351 or 156352
https://bugs.webkit.org/show_bug.cgi?id=121863
<rdar://problem/15069481>
Reviewed by Beth Dakin.
This test was not querying the vertex attribute locations
before binding data to them. When we enabled symbol mangling
we started seeing attributes appear in a different order
than the order defined in the shader source. Update this test
to ask getAttribLocation first.
Note that there are two important issues.
Firstly, this is updating our local copy of the Khronos test.
I've opened pull request #377 to get it addressed in the source.
https://github.com/KhronosGroup/WebGL/pull/377
Secondly, this indicates that we might have a lot of problems
with existing content that does not expect the order of
attributes to change.
- webgl/resources/webgl_test_files/conformance/extensions/oes-element-index-uint.html:
- TestExpectations: Unskip test.
- 4:39 PM Changeset in webkit [156372] by
-
- 9 edits in trunk/Source/WebCore
Move keyboard event dispatch from Node to Element.
<https://webkit.org/b/121873>
Reviewed by Antti Koivisto.
We only dispatch keyboard events on Elements so that logic shouldn't be in Node.
- dom/Document.cpp:
(WebCore::eventTargetElementForDocument):
Reworked to return Element instead of Node.
- dom/Document.h:
- dom/Element.h:
- dom/Element.cpp:
(WebCore::Element::dispatchKeyEvent):
Moved from Node to Element.
- editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::insertDictatedText):
- page/EventHandler.cpp:
(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::handleTextInputEvent):
Adjusted for above changes.
- 4:27 PM Changeset in webkit [156371] by
-
- 7 edits6 adds in trunk
Crashing under JSC::DFG::SpeculativeJIT::spill visiting citicards.com
https://bugs.webkit.org/show_bug.cgi?id=121844
Source/JavaScriptCore:
Reviewed by Mark Hahnenberg.
Fix some int52 bugs that caused this.
- bytecode/ValueRecovery.h:
(JSC::ValueRecovery::dumpInContext): There's no such thing as int53.
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::spill): Actually spill int52's, instead of hitting an assert and crashing.
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateInt32Internal): Use the right format (from before when we clobber it).
Tools:
Reviewed by Mark Hahnenberg.
- Scripts/run-javascriptcore-tests: Be more clear about what test suite failed.
LayoutTests:
Reviewed by Mark Hahnenberg.
- js/dfg-int52-spill-expected.txt: Added.
- js/dfg-int52-spill-trickier-expected.txt: Added.
- js/dfg-int52-spill-trickier.html: Added.
- js/dfg-int52-spill.html: Added.
- js/script-tests/dfg-int52-spill-trickier.js: Added.
(foo):
- js/script-tests/dfg-int52-spill.js: Added.
(foo):
- 4:18 PM Changeset in webkit [156370] by
-
- 2 edits in trunk/LayoutTests
Flaky Test: compositing/reflections/load-video-in-reflection.html
https://bugs.webkit.org/show_bug.cgi?id=117427
- platform/mac/TestExpectations: Marking the test accordingly.
- 4:00 PM Changeset in webkit [156369] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed buildfix.
- UIProcess/WebNetworkInfoManagerProxy.h:
- 3:57 PM Changeset in webkit [156368] by
-
- 2 edits in trunk/Source/WebKit2
Fix Mac build now.
- UIProcess/WebContext.messages.in:
- 3:45 PM Changeset in webkit [156367] by
-
- 2 edits in trunk/LayoutTests
SVG Animations are flaky
https://bugs.webkit.org/show_bug.cgi?id=107018
- platform/mac-wk2/TestExpectations: Marked some frequently failing tests
- 3:40 PM Changeset in webkit [156366] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed buildfix after r156350.
- UIProcess/WebContext.messages.in:
- 3:35 PM Changeset in webkit [156365] by
-
- 2 edits in trunk/Tools
[Mac][WK2] Multiple font tests fail is there is a global setting for font antialiasing threshold
https://bugs.webkit.org/show_bug.cgi?id=121854
Reviewed by Anders Carlsson.
- WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize): Post a notification to update cached
settings in underlying frameworks.
- 3:24 PM Changeset in webkit [156364] by
-
- 5 edits2 adds in trunk
[CSS Shapes] Modify updateSegmentsForShapes function to use logical coordinates
https://bugs.webkit.org/show_bug.cgi?id=121864
Reviewed by David Hyatt.
When I landed updateSegmentsForShapes in r156022, I didn't use logical coordinates. This change modifies the
code to use coordinates for positioning the float and the content around the float in a shape-inside. Now I
added only one writing mode tests, but I will add more later in bug #121866.
Source/WebCore:
Test: fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content.html
- rendering/FloatingObjects.h:
(WebCore::FloatingObject::logicalHeight):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeLogicalLocationForFloat):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::updateSegmentsForShapes):
LayoutTests:
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content-expected.html: Added.
- fast/shapes/shape-inside/shape-inside-left-float-in-upper-left-triangle-vertical-lr-inline-content.html: Added.
- 3:18 PM Changeset in webkit [156363] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed buildfix after r156354 and r156360.
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::processMessage):
(CoreIPC::Connection::sendOutgoingMessage):
- 3:09 PM Changeset in webkit [156362] by
-
- 3 edits in trunk/LayoutTests
Flaky Test: fast/history/history-subframe-with-name.html
https://bugs.webkit.org/show_bug.cgi?id=51039
Reviewed by Anders Carlsson.
Speculative fix, I could not reproduce locally.
- fast/history/resources/history-subframe-with-name-container.html: Added a check
that onunload trick worked.
- fast/history/resources/history-subframe-with-name-2.html: Starting the navigation
used to race with loading another iframe in the parent. Wait until the parent loads.
- 2:51 PM Changeset in webkit [156361] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed buildfix after r156349.
- Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::processMessage):
- 2:46 PM Changeset in webkit [156360] by
-
- 5 edits in trunk/Source/WebKit2
Use std::unique_ptr for decoders as well
https://bugs.webkit.org/show_bug.cgi?id=121868
Reviewed by Andreas Kling.
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::SyncMessageState::processIncomingMessage):
(CoreIPC::Connection::SyncMessageState::dispatchMessages):
(CoreIPC::Connection::waitForMessage):
(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::sendSyncMessageFromSecondaryThread):
(CoreIPC::Connection::waitForSyncReply):
(CoreIPC::Connection::processIncomingSyncReply):
(CoreIPC::Connection::processIncomingMessage):
(CoreIPC::Connection::enqueueIncomingMessage):
(CoreIPC::Connection::dispatchMessage):
(CoreIPC::Connection::dispatchOneMessage):
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::sendSync):
(CoreIPC::Connection::waitForAndDispatchImmediately):
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::createMessageDecoder):
(CoreIPC::Connection::receiveSourceEventHandler):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postSynchronousMessage):
- 2:25 PM Changeset in webkit [156359] by
-
- 2 edits in trunk/Source/WebCore
Remove IDBTransactionCallbacks.h from the .xcodeproj, as it's gone from the repository.
Rubberstamped by Anders Carlsson and Alexey Proskuryakov.
- WebCore.xcodeproj/project.pbxproj:
- 2:23 PM Changeset in webkit [156358] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Using Breakpoint Actions Breaks iOS inspection
https://bugs.webkit.org/show_bug.cgi?id=121862
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-24
Reviewed by Timothy Hatcher.
Only use DebuggerAgent.BreakpointActionType if it is available.
Otherwise leave options undefined for breakpoints since the backend
does not support it.
- UserInterface/DebuggerManager.js:
(WebInspector.DebuggerManager.prototype._setBreakpoint):
- 2:19 PM Changeset in webkit [156357] by
-
- 1 edit3 adds in trunk/Source/WebInspectorUI
Web Inspector: Include iOS 7 Inspector.json Version
https://bugs.webkit.org/show_bug.cgi?id=121852
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-24
Reviewed by Timothy Hatcher.
- UserInterface/Legacy/7.0/InspectorBackendCommands.js: Added.
- Versions/Inspector-iOS-7.0.json: Added.
- 1:50 PM Changeset in webkit [156356] by
-
- 2 edits in trunk/LayoutTests
webgl/conformance/extensions/oes-element-index-uint.html failing after r156351 or 156352
https://bugs.webkit.org/show_bug.cgi?id=121863
<rdar://problem/15069481>
Temporarily skipped while investigating.
- 1:47 PM Changeset in webkit [156355] by
-
- 9 edits in trunk/Source/WebCore
Tighten table rendering code
https://bugs.webkit.org/show_bug.cgi?id=121860
Reviewed by Andreas Kling.
Hide firstChild/lastChild/nextSibling/previousSibling in table renderers,
expose correctly typed firstRow/nextCell etc instead.
- 1:41 PM Changeset in webkit [156354] by
-
- 48 edits in trunk/Source/WebKit2
Move MessageEncoder and ArgumentEncoder to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=121861
Reviewed by Andreas Kling.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didReceiveSyncMessage):
- NetworkProcess/NetworkConnectionToWebProcess.h:
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didReceiveSyncMessage):
- NetworkProcess/NetworkProcess.h:
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchWorkQueueMessageReceiverMessage):
(CoreIPC::Connection::createSyncMessageEncoder):
(CoreIPC::Connection::sendMessage):
(CoreIPC::Connection::sendSyncReply):
(CoreIPC::Connection::sendSyncMessage):
(CoreIPC::Connection::sendSyncMessageFromSecondaryThread):
(CoreIPC::Connection::sendOutgoingMessages):
(CoreIPC::Connection::dispatchSyncMessage):
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::send):
(CoreIPC::Connection::sendSync):
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::handleMessageDelayed):
- Platform/CoreIPC/MessageReceiver.h:
(CoreIPC::MessageReceiver::didReceiveSyncMessage):
- Platform/CoreIPC/MessageReceiverMap.cpp:
(CoreIPC::MessageReceiverMap::dispatchSyncMessage):
- Platform/CoreIPC/MessageReceiverMap.h:
- Platform/CoreIPC/MessageSender.cpp:
(CoreIPC::MessageSender::sendMessage):
- Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::send):
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::open):
(CoreIPC::Connection::sendOutgoingMessage):
- PluginProcess/PluginControllerProxy.h:
- PluginProcess/WebProcessConnection.cpp:
(WebKit::WebProcessConnection::didReceiveSyncMessage):
- PluginProcess/WebProcessConnection.h:
- Scripts/webkit2/messages.py:
(message_to_struct_declaration):
(generate_message_handler):
- Scripts/webkit2/messages_unittest.py:
- Shared/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::sendMessage):
(WebKit::ChildProcessProxy::dispatchSyncMessage):
(WebKit::ChildProcessProxy::didFinishLaunching):
- Shared/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::send):
- Shared/Plugins/NPObjectMessageReceiver.h:
- Shared/Plugins/NPRemoteObjectMap.cpp:
(WebKit::NPRemoteObjectMap::didReceiveSyncMessage):
- Shared/Plugins/NPRemoteObjectMap.h:
- Shared/WebConnection.cpp:
(WebKit::WebConnection::postMessage):
- UIProcess/Downloads/DownloadProxy.h:
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didReceiveSyncMessage):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/Storage/StorageManager.h:
- UIProcess/WebContext.cpp:
(WebKit::WebContext::dispatchSyncMessage):
(WebKit::WebContext::didReceiveSyncMessage):
- UIProcess/WebContext.h:
- UIProcess/WebFullScreenManagerProxy.h:
- UIProcess/WebIconDatabase.h:
- UIProcess/WebInspectorProxy.h:
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveSyncMessage):
- UIProcess/WebProcessProxy.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::postSynchronousMessage):
- WebProcess/Network/NetworkProcessConnection.cpp:
(WebKit::NetworkProcessConnection::didReceiveSyncMessage):
- WebProcess/Network/NetworkProcessConnection.h:
- WebProcess/Plugins/PluginProcessConnection.cpp:
(WebKit::PluginProcessConnection::didReceiveSyncMessage):
- WebProcess/Plugins/PluginProcessConnection.h:
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveSyncMessage):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didReceiveSyncMessage):
- WebProcess/WebProcess.h:
- 12:59 PM Changeset in webkit [156353] by
-
- 17 edits in trunk/Source
Remove encoder create functions
https://bugs.webkit.org/show_bug.cgi?id=121853
Reviewed by Sam Weinig.
Source/WebKit2:
- Platform/CoreIPC/ArgumentEncoder.cpp:
- Platform/CoreIPC/ArgumentEncoder.h:
- Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchWorkQueueMessageReceiverMessage):
(CoreIPC::Connection::createSyncMessageEncoder):
(CoreIPC::Connection::dispatchSyncMessage):
- Platform/CoreIPC/Connection.h:
(CoreIPC::Connection::send):
- Platform/CoreIPC/MessageEncoder.cpp:
(CoreIPC::MessageEncoder::setIsSyncMessage):
- Platform/CoreIPC/MessageEncoder.h:
- Platform/CoreIPC/MessageSender.h:
(CoreIPC::MessageSender::send):
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::open):
- Shared/ChildProcessProxy.h:
(WebKit::ChildProcessProxy::send):
- Shared/WebConnection.cpp:
(WebKit::WebConnection::postMessage):
- UIProcess/WebContext.cpp:
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::postMessageToInjectedBundle):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postMessage):
- WebProcess/WebPage/EncoderAdapter.cpp:
(WebKit::EncoderAdapter::EncoderAdapter):
(WebKit::EncoderAdapter::dataReference):
(WebKit::EncoderAdapter::encodeBytes):
(WebKit::EncoderAdapter::encodeBool):
(WebKit::EncoderAdapter::encodeUInt16):
(WebKit::EncoderAdapter::encodeUInt32):
(WebKit::EncoderAdapter::encodeUInt64):
(WebKit::EncoderAdapter::encodeInt32):
(WebKit::EncoderAdapter::encodeInt64):
(WebKit::EncoderAdapter::encodeFloat):
(WebKit::EncoderAdapter::encodeDouble):
(WebKit::EncoderAdapter::encodeString):
- WebProcess/WebPage/EncoderAdapter.h:
Source/WTF:
Add a variadic version of createOwned.
- wtf/OwnPtr.h:
(WTF::createOwned):
- 12:43 PM Changeset in webkit [156352] by
-
- 3 edits in trunk/Source/WebCore
Implement symbol name hashing for WebGL shaders
https://bugs.webkit.org/show_bug.cgi?id=121849
Reviewed by Anders Carlsson.
Turn on ANGLE's symbol name mapping for shader programs.
This avoids compilation failures (or worse, crashers)
on some hardware that doesn't like it when shaders redefine
symbols like "sin", even though that is valid.
The way ANGLE exposes this is via setting a pointer
to a char* -> uint64_t hash function. Since we only have
a 32-bit hash in WebKit, I combine the 32-bit value with
a counter value that exists over the lifetime of a GC3D context.
Before calling ANGLE, I point the global hash map to the local
hash map, and then clean up after we're done. This introduces
a memory hit, in that the symbol table will build up until
the context is released.
Covered by Khronos WebGL tests, including
conformance/glsl/misc/shader-with-non-reserved-words.html
- platform/graphics/GraphicsContext3D.h: Define a ShaderNameHash type,
and add an OwnPtr to one as a member variable.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::nameHashForShader): Global function used for ANGLE hashing.
(WebCore::GraphicsContext3D::compileShader): Set up the ANGLE properties,
point to the local hash map, and call compile/translate.
- 12:43 PM Changeset in webkit [156351] by
-
- 4 edits2 adds in trunk
Use mapped name in attribute location binding
https://bugs.webkit.org/show_bug.cgi?id=121847
<rdar://problem/15067526>
Reviewed by Eric Carlson.
Source/WebCore:
The shader that we send down to OpenGL to compile
may have been translated by ANGLE, so we keep a
table around that maps input symbols to output symbols.
We used the table when binding to and looking up
uniforms, and when looking up attributes, but not
when actually binding to attribute locations.
Test: fast/canvas/webgl/gl-bind-attrib-mapped-names.html
- platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::getSymbolInfo): Add logging of symbol mapping.
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::bindAttribLocation): Used the mapped name.
(WebCore::GraphicsContext3D::getAttribLocation): Remove comment since
we do the lookup everywhere.
(WebCore::GraphicsContext3D::getUniformLocation): Ditto.
LayoutTests:
New test that has an attribute name long enough
to trigger symbol mapping in all cases.
- fast/canvas/webgl/gl-bind-attrib-mapped-names-expected.txt: Added.
- fast/canvas/webgl/gl-bind-attrib-mapped-names.html: Added.
- 12:35 PM Changeset in webkit [156350] by
-
- 20 edits1 add in trunk/Source
Upstream changes to Pasteboard implementation for iOS.
https://bugs.webkit.org/show_bug.cgi?id=121818
Reviewed by Darin Adler.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- editing/Editor.cpp:
(WebCore::Editor::cut):
(WebCore::Editor::copyImage):
- editing/ios/EditorIOS.mm:
(WebCore::attributedStringForRange):
(WebCore::dataInRTFDFormat):
(WebCore::dataInRTFFormat):
(WebCore::Editor::stringSelectionForPasteboardWithImageAltText):
(WebCore::Editor::selectionInWebArchiveFormat):
(WebCore::Editor::writeSelectionToPasteboard):
(WebCore::getImage):
(WebCore::Editor::writeImageToPasteboard):
- platform/Pasteboard.h:
- platform/PasteboardStrategy.h:
- platform/PlatformPasteboard.h:
- platform/ios/PasteboardIOS.mm:
- platform/ios/PlatformPasteboardIOS.mm: Added.
(WebCore::PlatformPasteboard::PlatformPasteboard):
(WebCore::PlatformPasteboard::getTypes):
(WebCore::PlatformPasteboard::bufferForType):
(WebCore::PlatformPasteboard::getPathnamesForType):
(WebCore::PlatformPasteboard::stringForType):
(WebCore::PlatformPasteboard::color):
(WebCore::PlatformPasteboard::url):
(WebCore::PlatformPasteboard::copy):
(WebCore::PlatformPasteboard::addTypes):
(WebCore::PlatformPasteboard::setTypes):
(WebCore::PlatformPasteboard::setBufferForType):
(WebCore::PlatformPasteboard::setPathnamesForType):
(WebCore::PlatformPasteboard::setStringForType):
(WebCore::PlatformPasteboard::changeCount):
(WebCore::PlatformPasteboard::uniqueName):
(WebCore::PlatformPasteboard::write):
Source/WebKit/mac:
- WebCoreSupport/WebPlatformStrategies.h:
- WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::writeToPasteboard):
Source/WebKit2:
- Scripts/webkit2/messages.py:
(struct_or_class):
(headers_for_type):
- Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::encodeSharedBuffer):
(CoreIPC::decodeSharedBuffer):
(CoreIPC::::encode):
(CoreIPC::::decode):
- Shared/WebCoreArgumentCoders.h:
- UIProcess/WebContext.h:
- UIProcess/WebContext.messages.in:
- UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::writeWebContentToPasteboard):
(WebKit::WebContext::writeImageToPasteboard):
(WebKit::WebContext::writeStringToPasteboard):
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::writeToPasteboard):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 12:23 PM Changeset in webkit [156349] by
-
- 9 edits in trunk/Source/WebKit2
Remove create functions from MessageDecoder and ArgumentDecoder
https://bugs.webkit.org/show_bug.cgi?id=121850
Reviewed by Antti Koivisto.
- Platform/CoreIPC/ArgumentDecoder.cpp:
(CoreIPC::ArgumentDecoder::ArgumentDecoder):
- Platform/CoreIPC/ArgumentDecoder.h:
- Platform/CoreIPC/MessageDecoder.cpp:
(CoreIPC::MessageDecoder::MessageDecoder):
- Platform/CoreIPC/MessageDecoder.h:
- Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::createMessageDecoder):
- WebProcess/WebPage/DecoderAdapter.cpp:
(WebKit::DecoderAdapter::DecoderAdapter):
(WebKit::DecoderAdapter::decodeBytes):
(WebKit::DecoderAdapter::decodeBool):
(WebKit::DecoderAdapter::decodeUInt16):
(WebKit::DecoderAdapter::decodeUInt32):
(WebKit::DecoderAdapter::decodeUInt64):
(WebKit::DecoderAdapter::decodeInt32):
(WebKit::DecoderAdapter::decodeInt64):
(WebKit::DecoderAdapter::decodeFloat):
(WebKit::DecoderAdapter::decodeDouble):
(WebKit::DecoderAdapter::decodeString):
- WebProcess/WebPage/DecoderAdapter.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::postInjectedBundleMessage):
- 12:18 PM Changeset in webkit [156348] by
-
- 20 edits in trunk
<rdar://problem/14971518> WebKit should build against the Xcode default toolchain when targeting OS X 10.8
Reviewed by Dan Bernstein.
Source/JavaScriptCore:
- Configurations/Base.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/Base.xcconfig:
Source/WebCore:
- Configurations/Base.xcconfig:
Source/WebInspectorUI:
- Configurations/Base.xcconfig:
Source/WebKit/mac:
- Configurations/Base.xcconfig:
Source/WebKit2:
- Configurations/Base.xcconfig:
Source/WTF:
- Configurations/Base.xcconfig:
Tools:
- DumpRenderTree/mac/Configurations/Base.xcconfig:
- MiniBrowser/Configurations/Base.xcconfig:
- TestWebKitAPI/Configurations/Base.xcconfig:
- WebKitLauncher/Configurations/Base.xcconfig:
- WebKitTestRunner/Configurations/Base.xcconfig:
- 12:14 PM Changeset in webkit [156347] by
-
- 10 edits in trunk/Source/WebCore
[iOS] Upstream -webkit-touch-callout
https://bugs.webkit.org/show_bug.cgi?id=121507
Reviewed by Antti Koivisto.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPropertyNames.in: Added -webkit-touch-callout.
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::willRespondToMouseClickEvents): Added.
- html/HTMLImageElement.h:
- rendering/style/RenderStyle.h:
- rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
- rendering/style/StyleRareInheritedData.h:
- 12:02 PM Changeset in webkit [156346] by
-
- 8 edits5 adds in trunk
Properly handle bottom margin on float with shape-outside
https://bugs.webkit.org/show_bug.cgi?id=121808
Reviewed by David Hyatt.
Source/WebCore:
When a float has a shape-outside, inline content must conform to the
shape, not to the margin box. Thus, if a float with shape-outside has
a bottom margin and the shape does not intrude into that margin, then
the inline content should ignore the margin. Before this patch, inline
content would drop below the margin box instead of obeying the shape.
Note that content that should clear the float still clears the margin
box, not the shape's contour.
Tests: csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002.html
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003.html
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-004.html
- rendering/LineWidth.cpp:
(WebCore::LineWidth::fitBelowFloats): Compute the logical bottom based
on the shape.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nextFloatLogicalBottomBelow): Add option to
compute the logical bottom based on the shape instead of on the margin
box.
- rendering/RenderBlock.h:
LayoutTests:
Import new tests for floats wish shape-outside and bottom margins.
- csswg/contributors/adobe/submitted/shapes/shape-outside/resources/w3c-import.log:
- csswg/contributors/adobe/submitted/shapes/shape-outside/resources/rounded-rectangle.js: Remove whitespace at ends of lines.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003-expected.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003.html: Added.
- csswg/contributors/adobe/submitted/shapes/shape-outside/w3c-import.log:
- 11:58 AM Changeset in webkit [156345] by
-
- 9 edits in trunk/Source
[GTK] Fix compilation problems when setting ENABLE_DRAG_SUPPORT = FALSE
https://bugs.webkit.org/show_bug.cgi?id=121782
Patch by Lorenzo Tilve <ltilve@igalia.com> on 2013-09-24
Reviewed by Martin Robinson.
Disabled drag functions.
Source/WebCore:
- page/gtk/EventHandlerGtk.cpp:
- platform/gtk/PasteboardGtk.cpp:
Source/WebKit/gtk:
- WebCoreSupport/DragClientGtk.cpp:
- WebCoreSupport/DragClientGtk.h:
Source/WebKit2:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkit_web_view_base_class_init):
- WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:
- 11:42 AM Changeset in webkit [156344] by
-
- 2 edits in trunk/Source/WebKit/win
[Windows] Unreviewed crash fix after r156321.
Fix a few mistakes in the use of Vectors and counting that introduced test crashes.
- WebHistory.cpp:
(WebHistory::removeAllItems): Loop termination tried to test an unsigned for negative size.
(WebHistory::removeItemFromDateCaches): Vector was being created with empty entries.
(WebHistory::addItemToDateCaches): Ditto.
- 11:38 AM Changeset in webkit [156343] by
-
- 2 edits in branches/safari-537.60-branch/Source/WebCore
Merged r156315. <rdar://problem/15063134>
- 11:20 AM Changeset in webkit [156342] by
-
- 1 edit in branches/safari-537.60-branch/Source/WebCore/rendering/RenderLayer.cpp
build fix.
- 11:16 AM Changeset in webkit [156341] by
-
- 3 edits in trunk/Source/WebKit2
Begin adopting std::tuple for IPC decoding
https://bugs.webkit.org/show_bug.cgi?id=121848
Reviewed by Sam Weinig.
This is the first step towards getting rid of the horrible Arguments class hierarchy.
- Platform/CoreIPC/Arguments.h:
(CoreIPC::TupleCoder::encode):
(CoreIPC::TupleCoder::decode):
- Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
(CoreIPC::handleMessage):
(CoreIPC::handleMessageVariadic):
(CoreIPC::handleMessageDelayed):
- 11:11 AM Changeset in webkit [156340] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Breakpoint Actions input should disable spellchecking
https://bugs.webkit.org/show_bug.cgi?id=121846
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-09-24
Reviewed by Timothy Hatcher.
- UserInterface/BreakpointActionView.js:
- 10:57 AM Changeset in webkit [156339] by
-
- 15 edits in trunk/Source/WebCore
AX: Replace AXObjectCache postNotification method boolean arguments with enum values.
https://bugs.webkit.org/show_bug.cgi?id=121504
Patch by Samuel White <Samuel White> on 2013-09-24
Reviewed by Chris Fleizach.
No new tests, no functional changes. Changed argument type from bool
to enum per "Names" rule #10 in the WebKit coding style guidelines.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::textChanged):
(WebCore::AXObjectCache::postNotification):
(WebCore::AXObjectCache::checkedStateChanged):
(WebCore::AXObjectCache::selectedChildrenChanged):
(WebCore::AXObjectCache::handleAttributeChanged):
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::postNotification):
- accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::didUpdateActiveOption):
- accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::childrenChanged):
(WebCore::AccessibilityNodeObject::changeValueByStep):
(WebCore::AccessibilityNodeObject::changeValueByPercent):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::handleAriaExpandedChanged):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
(WebCore::AccessibilityRenderObject::textChanged):
- dom/Document.cpp:
(WebCore::Document::implicitClose):
- editing/Editor.cpp:
(WebCore::Editor::respondToChangedContents):
(WebCore::Editor::markAndReplaceFor):
- editing/mac/FrameSelectionMac.mm:
(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::setInnerTextValue):
- html/InputType.cpp:
(WebCore::InputType::applyStep):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::handleKeydownEvent):
- page/FocusController.cpp:
(WebCore::FocusController::setInitialFocus):
- page/FrameView.cpp:
(WebCore::FrameView::layout):
- 10:51 AM Changeset in webkit [156338] by
-
- 8 edits in trunk/Source/WebCore
Make hoverAncestor() a RenderElement concept.
<https://webkit.org/b/121845>
Reviewed by Antti Koivisto.
The hover ancestor renderer is always a RenderElement, we only ever
ask RenderElements for their hover ancestors.
Updated Document::updateHoverActiveState() to take advantage of the
tighter typing, removing a few isElementNode() checks.
- 10:12 AM Changeset in webkit [156337] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Initialize settings mediaPlayback{AllowsInline, RequiresUserGesture} and
shouldRespectImageOrientation as appropriate
https://bugs.webkit.org/show_bug.cgi?id=121792
Reviewed by Darin Adler.
On iOS we explicitly want to disable mediaPlaybackAllowsInline, and enable
mediaPlaybackRequiresUserGesture and shouldRespectImageOrientation by default.
This differs from other platforms. We need to extract the initialization logic
for these settings into constants whose definition is conditioned on the platform.
- page/Settings.cpp:
- page/Settings.in:
- 9:45 AM Changeset in webkit [156336] by
-
- 2 edits in trunk/Source/WebCore
[WinCairo] Compile error.
https://bugs.webkit.org/show_bug.cgi?id=121839
Patch by peavo@outlook.com <peavo@outlook.com> on 2013-09-24
Reviewed by Brent Fulgham.
- platform/graphics/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate): Added missing guard.
- 9:22 AM Changeset in webkit [156335] by
-
- 2 edits in branches/safari-537.60-branch/Source/WebCore
Merge patch for <rdar://problem/15056974>. Build fix after r156221.
- 9:20 AM Changeset in webkit [156334] by
-
- 4 edits in trunk/Source/WebCore
Cache continuation() in a local to avoid repeat hash lookups.
<https://webkit.org/b/121840>
Reviewed by Geoffrey Garen.
RenderBoxModelObject::continuation() does a hash lookup every time.
Cache the result in a local instead of calling it repeatedly.
- rendering/RenderBlock.h:
(WebCore::RenderBlock::isAnonymousBlockContinuation):
Reorder to check bitfield before hash map.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateDragState):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::clippedOverflowRectForRepaint):
(WebCore::RenderInline::updateDragState):
(WebCore::RenderInline::addFocusRingRects):
Cache continuation() in locals where it's used more than once.
- 7:25 AM Changeset in webkit [156333] by
-
- 2 edits in trunk/Source/WebKit2
[EFL] Build failed at ProcessLauncherEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=121826
Reviewed by Gyuyoung Kim.
Fixed a build failure with adding socket.h.
- UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
- 7:24 AM Changeset in webkit [156332] by
-
- 5 edits in trunk
[ATK] Missing WTR AccessibilityController::addNotificationListener implementation
https://bugs.webkit.org/show_bug.cgi?id=121674
Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-09-24
Reviewed by Mario Sanchez Prada.
Tools:
Implemented the global notification listener for
AccessibilityController. The signal is generated by
AXObjectCache::postPlatformNotification() and received by
axObjectEventListener(). axObjectEventListener will then invoke
JSObjectCallAsFunction() with the respective callback function.
There is no additional test for this patch since its implementation will
be tested by an accessibility layout test that is currently failing
(accessibility/loading-iframe-sends-notification.html).
- WebKitTestRunner/InjectedBundle/AccessibilityController.cpp: Removed
stub implementations of addNotificationListener and
removeNotificationListener for the GTK port.
- WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
(WTR::AccessibilityController::addNotificationListener): Creates the
notification handler and sets the notification function callback.
(WTR::AccessibilityController::removeNotificationListener): Removes the
global handler.
LayoutTests:
Updated the expectation of loading-iframe-sends-notification.html test,
which was failing before this fix.
- platform/gtk-wk2/TestExpectations: Removed
loading-iframe-sends-notification.html because it now passes with this
fix.
- 7:18 AM Changeset in webkit [156331] by
-
- 4 edits in trunk
[GTK] fast/images/exif-orientation-composited.html is failing
https://bugs.webkit.org/show_bug.cgi?id=119731
Patch by Anton Obzhirov <Anton Obzhirov> on 2013-09-24
Reviewed by Carlos Garcia Campos.
Tools:
Add handling respect image orientation property in DRT.
- DumpRenderTree/gtk/TestRunnerGtk.cpp:
(TestRunner::overridePreference):
LayoutTests:
Unskip fast/images/exif-orientation-composited.html for GTK WK1 and WK2.
- platform/gtk/TestExpectations:
- 7:16 AM Changeset in webkit [156330] by
-
- 6 edits in trunk
[Qt] Crash when trying to download blob url
https://bugs.webkit.org/show_bug.cgi?id=121681
Reviewed by Simon Hausmann.
Source/WebCore:
Resolve any blob URLs before creating a QUrl.
- platform/network/qt/ResourceRequestQt.cpp:
(WebCore::appendBlobResolved):
(WebCore::resolveBlobUrl):
(WebCore::ResourceRequest::toNetworkRequest):
Source/WebKit/qt:
Do not crash if a download was triggered on a resource WebCore handles internally.
- WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::convertMainResourceLoadToDownload):
LayoutTests:
Unskip two tests that downloads blob URLs. Note the two tests do not use the download attribute feature.
- platform/qt/TestExpectations:
- 7:10 AM Changeset in webkit [156329] by
-
- 2 edits in trunk/Source/WebKit/qt
[Qt] RepaintRequested signal sometimes not emitted
https://bugs.webkit.org/show_bug.cgi?id=121790
Reviewed by Simon Hausmann.
We should also emit repaintRequested after calling PageClient::update().
- WidgetSupport/PageClientQt.cpp:
(WebCore::PageClientQWidget::repaintViewport):
(WebCore::PageClientQGraphicsWidget::repaintViewport):
- 6:14 AM Changeset in webkit [156328] by
-
- 4 edits in trunk
[GTK] Enable the Wayland target if GTK+ dependency is found
https://bugs.webkit.org/show_bug.cgi?id=121704
Reviewed by Gustavo Noronha Silva.
The Wayland target should be enabled by default if the GTK+ dependency is of version 3.9.14 or later.
- Source/autotools/FindDependencies.m4: If the Wayland target was not strictly disabled, the GTK+ dependency
is tested if it can provide the Wayland GDK backend, and that the version of that backend matches the version
of the master GTK+ dependency for which we already tested. If found, the target is enabled, otherwise we either
warn or error out, depending on whether the build target was set to auto or completely disabled through configuration.
- Source/autotools/ReadCommandLineArguments.m4: Switch the default Wayland target status to 'auto', meaning
it will be disabled if the GTK+ dependency is not found.
- Source/autotools/Versions.m4: Require GTK+ 3.9.14 for the Wayland target only.
- 6:09 AM Changeset in webkit [156327] by
-
- 2 edits in trunk/Source/WebKit/gtk
[GTK] Fix accelerated compositing disabling under Wayland displays
https://bugs.webkit.org/show_bug.cgi?id=121788
Reviewed by Gustavo Noronha Silva.
- webkit/webkitwebview.cpp:
(updateAcceleratedCompositingSetting): Fix a ridiculous early return in the case of disabling the accelerated
compositing setting. There's no need to re-disable the setting if it was already disabled, but it should
definitely be disabled if the setting was previously enabled.
- 6:08 AM Changeset in webkit [156326] by
-
- 2 edits in trunk/Tools
[GTK] Bump the GTK+ dependency in the Wayland-specific Jhbuild moduleset
https://bugs.webkit.org/show_bug.cgi?id=121787
Reviewed by Gustavo Noronha Silva.
- gtk/jhbuild-wayland.modules: Bump the GTK+ dependency that's intended for use when building
with the Wayland target enabled to version 3.10.0.
- 5:22 AM Changeset in webkit [156325] by
-
- 7 edits in trunk/Source/WebCore
Move more style change code from RenderObject to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121822
Reviewed by Darin Adler.
- rendering/RenderElement.cpp:
(WebCore::RenderElement::~RenderElement):
RenderTexts are no longer registered as image clients. They don't need be unregistered either.
(WebCore::RenderElement::adjustStyleDifference):
(WebCore::RenderElement::hasImmediateNonWhitespaceTextChild):
(WebCore::RenderElement::shouldRepaintForStyleDifference):
(WebCore::RenderElement::updateFillImages):
(WebCore::RenderElement::updateImage):
(WebCore::RenderElement::updateShapeImage):
(WebCore::RenderElement::setStyle):
Move from RenderObject and remove the text specific bits.
- rendering/RenderElement.h:
- rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):
(WebCore::RenderObject::arenaDelete):
- rendering/RenderObject.h:
Remove styleWill/DidChange which move to subclasses.
- rendering/RenderText.cpp:
(WebCore::RenderText::setStyle):
Add simple text specific setStyle.
- rendering/RenderText.h:
- 3:41 AM WebKitGTK/2.2.x edited by
- Strike out a merged proposal. (diff)
- 3:36 AM Changeset in webkit [156324] by
-
- 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit/gtk
Merge r156261 - Unreviewed, GTK build fix when building with GTK+ 2.0.
Patch provided by Dominique Leuenberger <dimstar@opensuse.org>.
- WebCoreSupport/AcceleratedCompositingContextGL.cpp: Include GtkVersioning.h to set up
the mock GDK_IS_X11_DISPLAY macro if it's not provided by the GTK+ headers.
- 3:25 AM Changeset in webkit [156323] by
-
- 1 edit in releases/WebKitGTK/webkit-2.2/Source/autotools/Versions.m4
Bump the GTK+ Wayland dependency to 3.10.0 for the forthcoming 2.2 release.
- 12:47 AM Changeset in webkit [156322] by
-
- 15 edits in trunk
[CSS Background] repeat: round should round the number of tiles to the nearest natural number
https://bugs.webkit.org/show_bug.cgi?id=120668
Source/WebCore:
Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-24
Reviewed by Darin Adler.
Tests already available in css3/masking and css3/background
- rendering/RenderBoxModelObject.cpp: Rounded the number of tiles to the nearest natural number.
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
LayoutTests:
Changed the sizes of the images/masks in the tests to be compliant with the new behaviour.
Patch by Andrei Parvu <parvu@adobe.com> on 2013-09-24
Reviewed by Darin Adler.
- css3/background/background-repeat-round-auto1-expected.html:
- css3/background/background-repeat-round-auto2-expected.html:
- css3/background/background-repeat-round-border-expected.html:
- css3/background/background-repeat-round-content-expected.html:
- css3/background/background-repeat-round-padding-expected.html:
- css3/background/background-repeat-round-padding.html:
- css3/masking/mask-repeat-round-auto1-expected.html:
- css3/masking/mask-repeat-round-auto2-expected.html:
- css3/masking/mask-repeat-round-border-expected.html:
- css3/masking/mask-repeat-round-content-expected.html:
- css3/masking/mask-repeat-round-padding-expected.html:
- css3/masking/mask-repeat-round-padding.html:
- 12:33 AM Changeset in webkit [156321] by
-
- 3 edits in trunk/Source/WebKit/win
Make WebHistory more type safe
https://bugs.webkit.org/show_bug.cgi?id=121801
Reviewed by Brent Fulgham.
Use a WTF::Vector instead of a CFMutableArray to avoid
casting from void* all the time when accessing the entries.
This reduces the dependencies on CoreFoundation too.
- WebHistory.cpp:
(getDayBoundaries):
(beginningOfDay):
(dateKey):
(WebHistory::orderedItemsLastVisitedOnDay):
(WebHistory::removeItemFromDateCaches):
(WebHistory::addItemToDateCaches):
- WebHistory.h:
- 12:30 AM Changeset in webkit [156320] by
-
- 4 edits1 delete in trunk/Source/WebCore
Remove ScrollView::platformInit() and ScrollView::platformDestroy()
https://bugs.webkit.org/show_bug.cgi?id=121824
Reviewed by Darin Adler.
ScrollView::platformInit() and ScrollView::platformDestroy() are just
empty functions for all ports after removed WX port at r149186.
- PlatformEfl.cmake: Removed ScrollViewEfl.cpp from source list.
- platform/ScrollView.cpp: Removed platformInit and PlatformDestroy.
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::~ScrollView):
- platform/ScrollView.h: Ditto.
- platform/efl/ScrollViewEfl.cpp: Removed.
Sep 23, 2013:
- 10:53 PM Changeset in webkit [156319] by
-
- 8 edits in trunk/Source/WebCore
Use unique_ptr instead of deleteAllValues in FloatingObject code
https://bugs.webkit.org/show_bug.cgi?id=121823
Reviewed by Sam Weinig.
- rendering/FloatingObjects.cpp:
(WebCore::FloatingObject::create): Return a unique_ptr instead of PassOwnPtr.
Use auto and a word for the local variable instead of an abbreviation. Also
changed to take a reference instead of a pointer.
(WebCore::FloatingObject::copyToNewContainer): Ditto.
(WebCore::FloatingObject::unsafeClone): Ditto.
(WebCore::FloatingObjects::~FloatingObjects): Removed call to deleteAllValues.
(WebCore::FloatingObjects::clearLineBoxTreePointers): Use auto to make this
read clearly.
(WebCore::FloatingObjects::clear): Removed call to deleteAllValues.
(WebCore::FloatingObjects::moveAllToFloatInfoMap): Use std::move to move values
out of the set, into the map. Removed code to clear the set, since it was a
trick to prevent the values from being deleted when they were not moved.
(WebCore::FloatingObjects::add): Changed to take a unique_ptr and to move the
pointer into the set instead of using leakPtr.
(WebCore::FloatingObjects::remove): Rearranged code so that the remove is at
the end of the function rather than the beginning. Also had to use a hash
translator and a find/remove combo since we don't have hash translator version
of the remove function.
(WebCore::FloatingObjects::computePlacedFloatsTree): Updated for changes to
the types.
(WebCore::FloatingObjects::placedFloatsTree): Moved this function here instead
of having it in the header, since it's only used within the file.
- rendering/FloatingObjects.h: Changed functions to take references instead
of pointers and return unique_ptr instead of PassOwnPtr. Also made
constructors public so we can use them with make_unique. Changed types to
use unique_ptr instead of raw pointers, and made the FloatingObjectHashTranslator
work for both RenderBox& and FloatingObject&.
- rendering/LineWidth.cpp:
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):
Updated for changes to types.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
(WebCore::RenderBlock::moveAllChildrenIncludingFloatsTo):
(WebCore::RenderBlock::addOverflowFromFloats):
(WebCore::RenderBlock::repaintOverhangingFloats):
(WebCore::RenderBlock::paintFloats):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObject):
(WebCore::RenderBlock::removeFloatingObjectsBelow):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::nextFloatLogicalBottomBelow):
(WebCore::RenderBlock::lowestFloatLogicalBottom):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::hasOverhangingFloat):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::containsFloat):
(WebCore::RenderBlock::markSiblingsWithFloatsForLayout):
(WebCore::RenderBlock::updateLocalFloatingObjectsForPaintingContainer):
(WebCore::RenderBlock::hitTestFloats):
(WebCore::RenderBlock::adjustForBorderFit):
Updated for changes to types.
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::clearFloats): Updated to use take instead of
a combination of remove and delete.
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloats):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
(WebCore::RenderBlock::positionNewFloatOnLine):
Updated for changes to types.
- 9:00 PM Changeset in webkit [156318] by
-
- 7 edits10 adds in trunk
CSS Unit vh, vw, vmin and vmax in box-shadow are not applied.
https://bugs.webkit.org/show_bug.cgi?id=121422
Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-23
Reviewed by Darin Adler.
Source/WebCore:
Box-shadow properties were not applied incase its values
were given in vh, vw, vmax, vmin unit.
Tests: fast/css/box-shadow-negative-viewportlength.html
fast/css/box-shadow-viewport-height.html
fast/css/box-shadow-viewport-vmax.html
fast/css/box-shadow-viewport-vmin.html
fast/css/box-shadow-viewport-width.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseShadow):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::MatchedProperties::~MatchedProperties):
(WebCore::StyleResolver::viewportPercentageHeight):
(WebCore::StyleResolver::viewportPercentageWidth):
(WebCore::StyleResolver::viewportPercentageMax):
(WebCore::StyleResolver::viewportPercentageMin):
- css/StyleResolver.h:
Parsing and calculating the shadow values which has been specified
in viewport units.The vh/vw units are calcultated as percent of
viewport height and viewport width respectively. 1vmax: 1vw or 1vh,
whatever is largest.1vmin: 1vw or 1vh, whatever is smallest.
LayoutTests:
- fast/css/box-shadow-negative-viewportlength-expected-mismatch.html: Added.
- fast/css/box-shadow-negative-viewportlength.html: Added.
- fast/css/box-shadow-viewport-height-expected-mismatch.html: Added.
- fast/css/box-shadow-viewport-height.html: Added.
- fast/css/box-shadow-viewport-vmax-expected-mismatch.html: Added.
- fast/css/box-shadow-viewport-vmax.html: Added.
- fast/css/box-shadow-viewport-vmin-expected-mismatch.html: Added.
- fast/css/box-shadow-viewport-vmin.html: Added.
- fast/css/box-shadow-viewport-width-expected-mismatch.html: Added.
- fast/css/box-shadow-viewport-width.html: Added.
Added new tests for verifying that box-shadow properties are
applied when its values are viewport units.
- fast/css/shadow-viewport-units-expected.txt:
- fast/css/shadow-viewport-units.html:
Rebaselining existing tests as per the new behavior. Support for shadow
properties with viewport units is added so modified the test case.
- 7:48 PM Changeset in webkit [156317] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix for CMake ports with INDEXED_DATABASE after r156296
- CMakeLists.txt: Removed IDBBackingStore.cpp from source list.
- 7:09 PM Changeset in webkit [156316] by
-
- 7 edits in trunk/Source
Remove WTF_USE_SCROLLBAR_PAINTER #define
https://bugs.webkit.org/show_bug.cgi?id=121819
Reviewed by Sam Weinig.
Source/WebCore:
Remove unnecessary if checks and dead code.
- platform/mac/NSScrollerImpDetails.h:
- platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::mouseEnteredScrollbar):
(WebCore::ScrollAnimatorMac::mouseExitedScrollbar):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):
(WebCore::ScrollAnimatorMac::mayBeginScrollGesture):
(WebCore::ScrollAnimatorMac::finishCurrentScrollAnimations):
(WebCore::ScrollAnimatorMac::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveVerticalScrollbar):
(WebCore::ScrollAnimatorMac::didAddHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::willRemoveHorizontalScrollbar):
(WebCore::ScrollAnimatorMac::shouldScrollbarParticipateInHitTesting):
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore::ScrollAnimatorMac::cancelAnimations):
(WebCore::ScrollAnimatorMac::setIsActive):
(WebCore::ScrollAnimatorMac::updateScrollerStyle):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):
- platform/mac/ScrollViewMac.mm:
(WebCore::toNSScrollerKnobStyle):
(WebCore::ScrollView::platformSetScrollbarOverlayStyle):
- platform/mac/ScrollbarThemeMac.mm:
(WebCore::updateArrowPlacement):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::ScrollbarThemeMac):
(WebCore::ScrollbarThemeMac::scrollbarThickness):
(WebCore::ScrollbarThemeMac::usesOverlayScrollbarsChanged):
(WebCore::ScrollbarThemeMac::hasThumb):
(WebCore::ScrollbarThemeMac::minimumThumbLength):
(WebCore::ScrollbarThemeMac::updateEnabledState):
(WebCore::ScrollbarThemeMac::paint):
Source/WTF:
All our supported systems use the scrollbar painter now, so get rid of the #ifdef.
- wtf/Platform.h:
- 6:56 PM Changeset in webkit [156315] by
-
- 2 edits in trunk/Source/WebCore
[Windows] Moving back in history from a page with <video>, then moving forward causes crash.
https://bugs.webkit.org/show_bug.cgi?id=120475
Reviewed by Anders Carlsson.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::AVFWrapper::AVFWrapper): Add assertion that creation is on main thread.
(WebCore::AVFWrapper::~AVFWrapper): Add assertion that destruction is on main thread.
(WebCore::destroyAVFWrapper): Helper function to dispatch on main queue.
(WebCore::AVFWrapper::disconnectAndDeleteAVFWrapper): Spawn AVFoundationCF destruction to
main queue.
- 6:44 PM Changeset in webkit [156314] by
-
- 3 edits in trunk/Source/WebCore
RenderTextControlSingleLine::updateFromElement() override not needed.
<https://webkit.org/b/121815>
Reviewed by Anders Carlsson.
- rendering/RenderTextControlSingleLine.cpp:
- rendering/RenderTextControlSingleLine.h:
- 5:57 PM Changeset in webkit [156313] by
-
- 8 edits in trunk/Source/WebCore
Introduce CSS_VALUE_TYPE_CASTS macro in order to cast CSSValue type
https://bugs.webkit.org/show_bug.cgi?id=121462
Reviewed by Darin Adler.
As r155429 introduced ELEMENT_TYPE_CASTS, CSS_VALUE_TYPE_CASTS can be used
by css value type casting as well. This type cast macros will help to detect
bad-cast bugs as well as improve a code readibility.
This patch adds the following methods,
- CSSFooValue* toCSSFooValue(CSSValue*)
- const CSSFooValue* toCSSFooValue(const CSSValue*)
This patch support CSSImageSetValue and CSSReflectValue first. Other CSS*Values
will use this macro step by step.
Besides this patch will remove unnecessary local variables.
No new tests, no behavior change.
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::cachedImage):
(WebCore::CSSCursorImageValue::cachedOrPendingImage):
- css/CSSImageSetValue.h:
- css/CSSReflectValue.h:
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
- css/StyleResolver.cpp:
(WebCore::hasVariableReference):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
- rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::cssImageSetValue):
- 5:55 PM Changeset in webkit [156312] by
-
- 10 edits in trunk/Source/WebCore
Move style change analysis code to RenderElement
https://bugs.webkit.org/show_bug.cgi?id=121812
Reviewed by Andreas Kling.
Text renderers don't need this. There is no text renderer specific invalidation and text
style never changes independent from the containing RenderElement.
- 5:51 PM Changeset in webkit [156311] by
-
- 6 edits in trunk/Source
Unreviewed, rolling out r156307.
http://trac.webkit.org/changeset/156307
https://bugs.webkit.org/show_bug.cgi?id=121817
Broke the build, and crashes the compiler (Requested by ap on
#webkit).
Source/WebCore:
- css/MediaQuery.cpp:
(WebCore::expressionCompare):
(WebCore::MediaQuery::MediaQuery):
- dom/MutationObserver.cpp:
(WebCore::MutationObserver::ObserverLessThan::operator()):
(WebCore::MutationObserver::deliverAllMutations):
- page/CaptionUserPreferences.cpp:
(WebCore::textTrackCompare):
(WebCore::CaptionUserPreferences::sortedTrackListForMenu):
Source/WTF:
- wtf/ListDump.h:
(WTF::lessThan):
(WTF::sortedListDump):
- 5:34 PM Changeset in webkit [156310] by
-
- 8 edits in trunk/Source/WebCore
Move rendererForRootBackground() to RenderElement.
<http://webkit.org/b/121813>
Reviewed by Antti Koivisto.
Move this to RenderElement (and make it return one, too) since the
document element renderer will always be a RenderElement.
- 5:14 PM Changeset in webkit [156309] by
-
- 7 edits1 add in trunk/Source/WebCore
Make the Mac build work with IndexedDB enabled.
https://bugs.webkit.org/show_bug.cgi?id=121814
Reviewed by Alexey Proskuryakov.
This patch makes the Mac build work if one were to enable the IndexedDB feature flag.
This patch does not actually enable the flag for everyone.
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/IDBBackingStore.cpp: Added.
(WebCore::IDBBackingStore::open):
(WebCore::IDBBackingStore::openInMemory):
(WebCore::IDBBackingStore::getObjectStores):
(WebCore::IDBBackingStore::Cursor::advance):
(WebCore::IDBBackingStore::Cursor::continueFunction):
(WebCore::IDBBackingStore::Transaction::Transaction):
(WebCore::IDBBackingStore::Transaction::begin):
(WebCore::IDBBackingStore::Transaction::commit):
(WebCore::IDBBackingStore::Transaction::rollback):
- Modules/indexeddb/IDBBackingStore.h:
(WebCore::LevelDBFactory::~LevelDBFactory):
(WebCore::IDBBackingStore::Transaction::reset):
(WebCore::IDBBackingStore::Transaction::levelDBTransactionFrom):
- Modules/indexeddb/IDBKeyPath.cpp:
(WebCore::IDBIsValidKeyPath):
- bindings/js/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromValue):
- bindings/js/JSIDBAnyCustom.cpp:
(WebCore::toJS):
- 4:55 PM Changeset in webkit [156308] by
-
- 10 edits in trunk/Source/WebCore
CTTE: RenderObject::container() should return a RenderElement*.
<https://webkit.org/b/121811>
Reviewed by Antti Koivisto.
The containing renderer is always a RenderElement.
- 4:53 PM Changeset in webkit [156307] by
-
- 6 edits in trunk/Source
Test the waters and begin using lambdas
https://bugs.webkit.org/show_bug.cgi?id=121809
Reviewed by Andreas Kling.
Source/WebCore:
Use lambdas instead of static functions and function objects.
- css/MediaQuery.cpp:
(WebCore::MediaQuery::MediaQuery):
- dom/MutationObserver.cpp:
(WebCore::MutationObserver::deliverAllMutations):
- page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::sortedTrackListForMenu):
Source/WTF:
- wtf/ListDump.h:
(WTF::sortedListDump):
Use std::less instead of a custom lessThan function.
- 4:26 PM Changeset in webkit [156306] by
-
- 2 edits in trunk/Source/WebCore
[WIN] Add implementation for WebCore::readFromFile()
https://bugs.webkit.org/show_bug.cgi?id=119210
Reviewed by Brent Fulgham.
- platform/win/FileSystemWin.cpp:
(WebCore::readFromFile):
- 3:41 PM Changeset in webkit [156305] by
-
- 2 edits in trunk/Source/WTF
ListHashSet::removeLast should only remove one element.
- wtf/ListHashSet.h:
(WTF::ListHashSet::removeLast):
- 3:39 PM Changeset in webkit [156304] by
-
- 5 edits in trunk/Source/WTF
Add hash traits for std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=121807
Reviewed by Antti Koivisto.
Also, convert the thread map over to using std::unique_ptr instead of OwnPtr.
- wtf/HashMap.h:
Remove unnecessary typedefs and add missing calls to std::forward.
- wtf/HashTraits.h:
Add hash trait for std::unique_ptr.
- wtf/RefPtrHashMap.h:
Use std::add_lvalue_reference.
- wtf/ThreadingPthreads.cpp:
(WTF::establishIdentifierForPthreadHandle):
Change ThreadMap to be a hash map from ThreadIdentifier to std::unique_ptr<PthreadState>.
- 3:35 PM Changeset in webkit [156303] by
-
- 5 edits in trunk/Source
[WIN] Implement WebMutableURLRequest::setHTTPBody()
https://bugs.webkit.org/show_bug.cgi?id=91920
Reviewed by Brent Fulgham.
Source/WebCore:
Add a method to FormData for growing the internal buffer with a given size.
- platform/network/FormData.cpp:
(WebCore::FormData::appendData):
(WebCore::FormData::expandDataStore):
- platform/network/FormData.h:
Source/WebKit/win:
- WebMutableURLRequest.cpp:
(WebMutableURLRequest::setHTTPBody):
(WebMutableURLRequest::setHTTPBodyStream):
- 3:25 PM Changeset in webkit [156302] by
-
- 20 edits in trunk
use NOMINMAX instead of #define min min
https://bugs.webkit.org/show_bug.cgi?id=73563
Reviewed by Brent Fulgham.
Use NOMINMAX instead of #define min/max as a cleaner
way of ensuring that Windows system header files don't
define min/max as macro in the first place.
Source/JavaScriptCore:
- config.h:
Source/WebCore:
- WebCorePrefix.h:
- config.h:
Source/WebKit/win:
- WebKitPrefix.h:
Source/WebKit2:
- config.h:
Source/WTF:
- config.h:
Tools:
- DumpRenderTree/DumpRenderTreePrefix.h:
- DumpRenderTree/cg/ImageDiffCG.cpp:
- DumpRenderTree/config.h:
- DumpRenderTree/win/ImageDiffCairo.cpp:
- WebKitTestRunner/WebKitTestRunnerPrefix.h:
- WebKitTestRunner/config.h:
WebKitLibraries:
- win/tools/vsprops/common.props:
- 3:16 PM Changeset in webkit [156301] by
-
- 8 edits in trunk
REGRESSION (r155998): when zooming in, tiles are too small
https://bugs.webkit.org/show_bug.cgi?id=121765
Source/WebCore:
Reviewed by Dean Jackson.
In r155998 I made GraphicsLayerCA take root-relative transforms
into account when computing contentsScale, and landed a bunch of
new results which should actually have told me that I broke page
scaling.
We don't want to take page scale into account when computing contentsScale,
because we already do so, so ignore the transform on the layer that
applies page scale (the only transform it should ever has is the page scale).
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateRootRelativeScale):
LayoutTests:
Reviewed by Dean Jackson.
Fix results of tests that showed that we had incorrect tiling
behavior on zooming.
- platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed-expected.txt:
- platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt:
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
- platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled-expected.txt:
- platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt:
- 3:09 PM Changeset in webkit [156300] by
-
- 28 edits2 adds in trunk/Source/JavaScriptCore
Never use ReturnPC for exception handling and quit using exception check indices as a lame replica of the CodeOrigin index
https://bugs.webkit.org/show_bug.cgi?id=121734
Reviewed by Mark Hahnenberg.
Exception handling can deduce where the exception was thrown from by looking at the
code origin that was stored into the call frame header. There is no need to pass any
additional meta-data into the exception throwing logic. But the DFG was still doing it
anyway.
This removes all of the logic to pass extra meta-data into lookupExceptionHandler()
and friends. It simplifies a lot of code.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shrinkToFit):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::codeOrigins):
(JSC::CodeBlock::hasCodeOrigins):
(JSC::CodeBlock::canGetCodeOrigin):
(JSC::CodeBlock::codeOrigin):
- bytecode/CodeOrigin.h:
(JSC::InlineCallFrame::InlineCallFrame):
- bytecode/InlineCallFrameSet.cpp: Added.
(JSC::InlineCallFrameSet::InlineCallFrameSet):
(JSC::InlineCallFrameSet::~InlineCallFrameSet):
(JSC::InlineCallFrameSet::add):
(JSC::InlineCallFrameSet::shrinkToFit):
- bytecode/InlineCallFrameSet.h: Added.
(JSC::InlineCallFrameSet::isEmpty):
(JSC::InlineCallFrameSet::size):
(JSC::InlineCallFrameSet::at):
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGCommonData.cpp:
(JSC::DFG::CommonData::addCodeOrigin):
(JSC::DFG::CommonData::shrinkToFit):
- dfg/DFGCommonData.h:
- dfg/DFGDesiredWriteBarriers.cpp:
(JSC::DFG::DesiredWriteBarrier::DesiredWriteBarrier):
(JSC::DFG::DesiredWriteBarrier::trigger):
- dfg/DFGDesiredWriteBarriers.h:
(JSC::DFG::DesiredWriteBarriers::add):
(JSC::DFG::initializeLazyWriteBarrierForInlineCallFrameExecutable):
(JSC::DFG::initializeLazyWriteBarrierForInlineCallFrameCallee):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
- dfg/DFGGraph.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::compileExceptionHandlers):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compileFunction):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::emitStoreCodeOrigin):
(JSC::DFG::JITCompiler::exceptionCheck):
(JSC::DFG::JITCompiler::fastExceptionCheck):
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGRepatch.cpp:
(JSC::DFG::tryBuildGetByIDList):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheck):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):
(JSC::DFG::SpeculativeJIT::appendCall):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::emitCall):
- dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::callPreflight):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::emitExceptionCheck):
- 3:07 PM Changeset in webkit [156299] by
-
- 5 edits in trunk/Tools
Delete TestWebKitAPI domain or some keys before running TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=121715 & <rdar://problem/14269434>
Patch by Benjamin Poulain <benjamin@webkit.org> on 2013-09-23
Reviewed by Alexey Proskuryakov.
Previously, initalizing a WebPreference would change the cache model
to WebCacheModelDocumentBrowser. That behavior was due to a stale
preference file on disk.
This patch fixes the tests by resetting the default, and using the proper
default values after initializing WebPreference.
- TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
(TestWebKitAPI::TEST): Use the proper initial value, unrelated
to the previous runs.
- TestWebKitAPI/Tests/mac/SetAndUpdateCacheModel.mm:
(TestWebKitAPI::TEST): This test needs b/f cache to be enabled, so change
cache model to the one required.
- TestWebKitAPI/ios/mainIOS.mm:
(main): Reset the preferences before testing.
- TestWebKitAPI/mac/mainMac.mm:
(main): Ditto.
- 2:53 PM Changeset in webkit [156298] by
-
- 6 edits1 delete in trunk/Source/WTF
Remove PassTraits.h
https://bugs.webkit.org/show_bug.cgi?id=121805
Reviewed by Andreas Kling.
We no longer need PassTraits.h, get rid of it.
- GNUmakefile.list.am:
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/PassTraits.h: Removed.
- 2:50 PM Changeset in webkit [156297] by
-
- 3 edits3 adds in trunk
iframe and scrollbar with "overflow:auto" should support autoscroll with mousedrag
https://bugs.webkit.org/show_bug.cgi?id=40981
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com> on 2013-09-23
Reviewed by Darin Adler.
Source/WebCore:
RenderBox::calculateAutoscrollDirection does not properly translate
inner frames' coordinates in order to determine its auto-scrollability.
By coincidence, if the inner frame box it placed near to page's 0, 0 position
(upper left corner), it might work.
Patch fixes it by changing ::calculateAutoscrollDirection algorithm to operate
with window coordinates, taking inner frames offset and scroll position into account.
The behavior of auto-scrollable non-frame overflow boxes, including divs, still works
as it is used to.
Test: fast/events/drag-and-drop-autoscroll-inner-frame.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::calculateAutoscrollDirection):
LayoutTests:
Test ensures that dragging an element close to the boundary of
scrollable Frames, scroll its content in that direction.
- fast/events/drag-and-drop-autoscroll-inner-frame-expected.txt: Added.
- fast/events/drag-and-drop-autoscroll-inner-frame.html: Added.
- 2:45 PM Changeset in webkit [156296] by
-
- 4 edits3 moves1 add in trunk/Source/WebCore
Move LevelDB specific IDB files into their own subdirectory.
https://bugs.webkit.org/show_bug.cgi?id=121804
Rubberstamped by Alexey Proskuryakov.
- CMakeLists.txt:
- GNUmakefile.list.am:
- WebCore.xcodeproj/project.pbxproj:
- Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBBackingStore.cpp.
(WebCore::recordInternalError):
(WebCore::putBool):
(WebCore::getInt):
(WebCore::putInt):
(WebCore::getVarInt):
(WebCore::putVarInt):
(WebCore::getString):
(WebCore::putString):
(WebCore::putIDBKeyPath):
(WebCore::compareKeys):
(WebCore::compareIndexKeys):
(WebCore::Comparator::compare):
(WebCore::Comparator::name):
(WebCore::isSchemaKnown):
(WebCore::setUpMetadata):
(WebCore::getMaxObjectStoreId):
(WebCore::DefaultLevelDBFactory::openLevelDB):
(WebCore::DefaultLevelDBFactory::destroyLevelDB):
(WebCore::IDBBackingStore::IDBBackingStore):
(WebCore::IDBBackingStore::~IDBBackingStore):
(WebCore::IDBBackingStore::open):
(WebCore::IDBBackingStore::openInMemory):
(WebCore::IDBBackingStore::create):
(WebCore::IDBBackingStore::getDatabaseNames):
(WebCore::IDBBackingStore::getIDBDatabaseMetaData):
(WebCore::getNewDatabaseId):
(WebCore::IDBBackingStore::createIDBDatabaseMetaData):
(WebCore::IDBBackingStore::updateIDBDatabaseIntVersion):
(WebCore::IDBBackingStore::updateIDBDatabaseMetaData):
(WebCore::deleteRange):
(WebCore::IDBBackingStore::deleteDatabase):
(WebCore::checkObjectStoreAndMetaDataType):
(WebCore::IDBBackingStore::getObjectStores):
(WebCore::setMaxObjectStoreId):
(WebCore::IDBBackingStore::createObjectStore):
(WebCore::IDBBackingStore::deleteObjectStore):
(WebCore::IDBBackingStore::getRecord):
(WebCore::getNewVersionNumber):
(WebCore::IDBBackingStore::putRecord):
(WebCore::IDBBackingStore::clearObjectStore):
(WebCore::IDBBackingStore::deleteRecord):
(WebCore::IDBBackingStore::getKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::maybeUpdateKeyGeneratorCurrentNumber):
(WebCore::IDBBackingStore::keyExistsInObjectStore):
(WebCore::checkIndexAndMetaDataKey):
(WebCore::IDBBackingStore::getIndexes):
(WebCore::setMaxIndexId):
(WebCore::IDBBackingStore::createIndex):
(WebCore::IDBBackingStore::deleteIndex):
(WebCore::IDBBackingStore::putIndexDataForRecord):
(WebCore::findGreatestKeyLessThanOrEqual):
(WebCore::versionExists):
(WebCore::IDBBackingStore::findKeyInIndex):
(WebCore::IDBBackingStore::getPrimaryKeyViaIndex):
(WebCore::IDBBackingStore::keyExistsInIndex):
(WebCore::IDBBackingStore::Cursor::Cursor):
(WebCore::IDBBackingStore::Cursor::firstSeek):
(WebCore::IDBBackingStore::Cursor::advance):
(WebCore::IDBBackingStore::Cursor::continueFunction):
(WebCore::IDBBackingStore::Cursor::haveEnteredRange):
(WebCore::IDBBackingStore::Cursor::isPastBounds):
(WebCore::ObjectStoreKeyCursorImpl::create):
(WebCore::ObjectStoreKeyCursorImpl::clone):
(WebCore::ObjectStoreKeyCursorImpl::value):
(WebCore::ObjectStoreKeyCursorImpl::encodeKey):
(WebCore::ObjectStoreKeyCursorImpl::ObjectStoreKeyCursorImpl):
(WebCore::ObjectStoreKeyCursorImpl::loadCurrentRow):
(WebCore::ObjectStoreCursorImpl::create):
(WebCore::ObjectStoreCursorImpl::clone):
(WebCore::ObjectStoreCursorImpl::value):
(WebCore::ObjectStoreCursorImpl::encodeKey):
(WebCore::ObjectStoreCursorImpl::ObjectStoreCursorImpl):
(WebCore::ObjectStoreCursorImpl::loadCurrentRow):
(WebCore::IndexKeyCursorImpl::create):
(WebCore::IndexKeyCursorImpl::clone):
(WebCore::IndexKeyCursorImpl::value):
(WebCore::IndexKeyCursorImpl::primaryKey):
(WebCore::IndexKeyCursorImpl::recordIdentifier):
(WebCore::IndexKeyCursorImpl::encodeKey):
(WebCore::IndexKeyCursorImpl::IndexKeyCursorImpl):
(WebCore::IndexKeyCursorImpl::loadCurrentRow):
(WebCore::IndexCursorImpl::create):
(WebCore::IndexCursorImpl::clone):
(WebCore::IndexCursorImpl::value):
(WebCore::IndexCursorImpl::primaryKey):
(WebCore::IndexCursorImpl::recordIdentifier):
(WebCore::IndexCursorImpl::encodeKey):
(WebCore::IndexCursorImpl::IndexCursorImpl):
(WebCore::IndexCursorImpl::loadCurrentRow):
(WebCore::objectStoreCursorOptions):
(WebCore::indexCursorOptions):
(WebCore::IDBBackingStore::openObjectStoreCursor):
(WebCore::IDBBackingStore::openObjectStoreKeyCursor):
(WebCore::IDBBackingStore::openIndexKeyCursor):
(WebCore::IDBBackingStore::openIndexCursor):
(WebCore::IDBBackingStore::Transaction::Transaction):
(WebCore::IDBBackingStore::Transaction::begin):
(WebCore::IDBBackingStore::Transaction::commit):
(WebCore::IDBBackingStore::Transaction::rollback):
- Modules/indexeddb/leveldb/IDBLevelDBCoding.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.cpp.
(WebCore::IDBLevelDBCoding::encodeByte):
(WebCore::IDBLevelDBCoding::decodeByte):
(WebCore::IDBLevelDBCoding::maxIDBKey):
(WebCore::IDBLevelDBCoding::minIDBKey):
(WebCore::IDBLevelDBCoding::encodeBool):
(WebCore::IDBLevelDBCoding::decodeBool):
(WebCore::IDBLevelDBCoding::encodeInt):
(WebCore::IDBLevelDBCoding::decodeInt):
(WebCore::IDBLevelDBCoding::compareInts):
(WebCore::IDBLevelDBCoding::encodeVarInt):
(WebCore::IDBLevelDBCoding::decodeVarInt):
(WebCore::IDBLevelDBCoding::encodeString):
(WebCore::IDBLevelDBCoding::decodeString):
(WebCore::IDBLevelDBCoding::encodeStringWithLength):
(WebCore::IDBLevelDBCoding::decodeStringWithLength):
(WebCore::IDBLevelDBCoding::compareEncodedStringsWithLength):
(WebCore::IDBLevelDBCoding::encodeDouble):
(WebCore::IDBLevelDBCoding::decodeDouble):
(WebCore::IDBLevelDBCoding::encodeIDBKey):
(WebCore::IDBLevelDBCoding::decodeIDBKey):
(WebCore::IDBLevelDBCoding::extractEncodedIDBKey):
(WebCore::IDBLevelDBCoding::keyTypeByteToKeyType):
(WebCore::IDBLevelDBCoding::compareEncodedIDBKeys):
(WebCore::IDBLevelDBCoding::encodeIDBKeyPath):
(WebCore::IDBLevelDBCoding::decodeIDBKeyPath):
(WebCore::IDBLevelDBCoding::compare):
(WebCore::IDBLevelDBCoding::KeyPrefix::KeyPrefix):
(WebCore::IDBLevelDBCoding::KeyPrefix::createWithSpecialIndex):
(WebCore::IDBLevelDBCoding::KeyPrefix::isValidDatabaseId):
(WebCore::IDBLevelDBCoding::KeyPrefix::isValidObjectStoreId):
(WebCore::IDBLevelDBCoding::KeyPrefix::isValidIndexId):
(WebCore::IDBLevelDBCoding::KeyPrefix::decode):
(WebCore::IDBLevelDBCoding::KeyPrefix::encodeEmpty):
(WebCore::IDBLevelDBCoding::KeyPrefix::encode):
(WebCore::IDBLevelDBCoding::KeyPrefix::encodeInternal):
(WebCore::IDBLevelDBCoding::KeyPrefix::compare):
(WebCore::IDBLevelDBCoding::KeyPrefix::type):
(WebCore::IDBLevelDBCoding::SchemaVersionKey::encode):
(WebCore::IDBLevelDBCoding::MaxDatabaseIdKey::encode):
(WebCore::IDBLevelDBCoding::DataVersionKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::DatabaseFreeListKey):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::decode):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::encodeMaxKey):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::databaseId):
(WebCore::IDBLevelDBCoding::DatabaseFreeListKey::compare):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::decode):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encode):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encodeMinKeyForOrigin):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::encodeStopKeyForOrigin):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::compare):
(WebCore::IDBLevelDBCoding::DatabaseMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::ObjectStoreMetaDataKey):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encodeMaxKey):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::objectStoreId):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::metaDataType):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::compare):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::IndexMetaDataKey):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::decode):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::encode):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::encodeMaxKey):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::compare):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::indexId):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::ObjectStoreFreeListKey):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::encodeMaxKey):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::objectStoreId):
(WebCore::IDBLevelDBCoding::ObjectStoreFreeListKey::compare):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::IndexFreeListKey):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::decode):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::encode):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::encodeMaxKey):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::compare):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::objectStoreId):
(WebCore::IDBLevelDBCoding::IndexFreeListKey::indexId):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::compare):
(WebCore::IDBLevelDBCoding::IndexNamesKey::IndexNamesKey):
(WebCore::IDBLevelDBCoding::IndexNamesKey::decode):
(WebCore::IDBLevelDBCoding::IndexNamesKey::encode):
(WebCore::IDBLevelDBCoding::IndexNamesKey::compare):
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::decode):
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::encode):
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::compare):
(WebCore::IDBLevelDBCoding::ObjectStoreDataKey::userKey):
(WebCore::IDBLevelDBCoding::ExistsEntryKey::decode):
(WebCore::IDBLevelDBCoding::ExistsEntryKey::encode):
(WebCore::IDBLevelDBCoding::ExistsEntryKey::compare):
(WebCore::IDBLevelDBCoding::ExistsEntryKey::userKey):
(WebCore::IDBLevelDBCoding::IndexDataKey::IndexDataKey):
(WebCore::IDBLevelDBCoding::IndexDataKey::decode):
(WebCore::IDBLevelDBCoding::IndexDataKey::encode):
(WebCore::IDBLevelDBCoding::IndexDataKey::encodeMinKey):
(WebCore::IDBLevelDBCoding::IndexDataKey::encodeMaxKey):
(WebCore::IDBLevelDBCoding::IndexDataKey::compare):
(WebCore::IDBLevelDBCoding::IndexDataKey::databaseId):
(WebCore::IDBLevelDBCoding::IndexDataKey::objectStoreId):
(WebCore::IDBLevelDBCoding::IndexDataKey::indexId):
(WebCore::IDBLevelDBCoding::IndexDataKey::userKey):
(WebCore::IDBLevelDBCoding::IndexDataKey::primaryKey):
- Modules/indexeddb/leveldb/IDBLevelDBCoding.h: Renamed from Source/WebCore/Modules/indexeddb/IDBLevelDBCoding.h.
(WebCore::IDBLevelDBCoding::encodeIntSafely):
(WebCore::IDBLevelDBCoding::KeyPrefix::validIds):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::origin):
(WebCore::IDBLevelDBCoding::DatabaseNameKey::databaseName):
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::metaDataType):
(WebCore::IDBLevelDBCoding::ObjectStoreNamesKey::objectStoreName):
(WebCore::IDBLevelDBCoding::IndexNamesKey::indexName):
- 2:39 PM Changeset in webkit [156295] by
-
- 3 edits in trunk/Source/WebCore
Try to fix GTK build.
Not reviewed.
- accessibility/atk/AccessibilityObjectAtk.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(textForRenderer):
- 2:39 PM Changeset in webkit [156294] by
-
- 4 edits in trunk
ListHashSet should work with move-only types
https://bugs.webkit.org/show_bug.cgi?id=121802
Reviewed by Andreas Kling.
Source/WTF:
Add rvalue reference overloads and calls to std::forward and std::move where appropriate.
- wtf/ListHashSet.h:
(WTF::::removeFirst):
Implement this in terms of takeFirst.
(WTF::::takeFirst):
Look up the iterator before we move out the value so we won't break the hash invariant.
(WTF::::removeLast):
Implement this in terms of takeLast.
(WTF::::takeLast):
Look up the iterator before we move out the value so we won't break the hash invariant.
Tools:
- TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
(TestWebKitAPI::TEST):
Add a test for move-only types.
- 2:20 PM Changeset in webkit [156293] by
-
- 4 edits in trunk/LayoutTests
video-object-fit tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=121803
Rubber-stamped by Simon Fraser.
Removing an ad hoc 1.5 second timeout that these tests had. Loading video can take
longer.
- compositing/video/video-object-fit.html:
- media/video-object-fit-change.html:
- media/video-object-fit.html:
- 1:45 PM Changeset in webkit [156292] by
-
- 8 edits in trunk
Web Inspector: [CSS Regions] Display CSS Regions flow name in the inspector overlay
https://bugs.webkit.org/show_bug.cgi?id=121794
Reviewed by Joseph Pecoraro.
Source/WebCore:
No new tests, the previous test for CSS Regions highlighting covers the flow name.
This patch adds the "Flow" property in the inspector overlay. The region
chain is already displayed with numbers, so it makes sense to have the flow
name around when a CSS region is highlighted.
I've consolidated the flow information into "elementInfo.flowInfo".
Flow info has two properties: "name" and "regions".
- inspector/InspectorOverlay.cpp:
(WebCore::buildObjectForCSSRegionsHighlight):
(WebCore::InspectorOverlay::buildObjectForHighlightedNode):
- inspector/InspectorOverlayPage.css:
(.css-property): Added the CSS property font color that the Inspector uses.
- inspector/InspectorOverlayPage.html: Added a new element to be used to display the flow-from property.
- inspector/InspectorOverlayPage.js:
(_drawElementTitle):
(drawNodeHighlight):
LayoutTests:
Updated the expected results after moving the regions to the elementInfo.flowInfo property.
Also, the test is now logging the name of the flow container in the output.
- http/tests/inspector/elements-test.js:
- inspector/elements/highlight-node-regions-expected.txt:
- 1:43 PM Changeset in webkit [156291] by
-
- 10 edits in trunk/Source/WebCore
Rapidly loading pages can result in !needsLayout() assertions in FrameView::paintContents() and RenderView::paint()
https://bugs.webkit.org/show_bug.cgi?id=121725
<rdar://problem/13982161> ASSERT(!needsLayout()) in WebCore::RenderView::paint (121196)
Reviewed by Dean Jackson.
Layout has to be up-to-date before we paint, and when composited we rely on a
CFRunLoopObserver owned by LayerFlushScheduler to enforce this. The contract is
that changes to GraphicsLayers accumulate in those layers, and are all pushed to
CALayers only inside of flushCompositingState(). CALayers must not be touched
directly outside of flushCompositingState(), since this may trigger a CA commit
and resultant painting without us having updated layout.
In addition, we rely on the CA commits only happening after our runloop observer
has fired in order for LayerFlushScheduler's suspend/resume to work (these are used
for freezing the layer tree during page transitions).
However, TileController was violating this contract. It called revalidateTiles()
at random times, and on a timer. This would result in CA commits happening when
layer flushing was suspended at the LayerFlushScheduler level, and thus before
we'd had a chance to do layout.
Fix by only ever revalidatingTiles inside of flushCompositingState(). Calls
that used to result in revalidateTiles() at other times now just set a bit
on GraphicsLayerCA to indicate that revalidation is required, and this triggers
a later flush like any other GraphicsLayerCA change.
There is one exception to the revalidate-inside-flush rule: when purging
files for background tabs on a timer, we are only dealing with an unparented
layer tree, so CALayer manipulation is safe at any time.
Very timing dependent, so hard to test.
- platform/graphics/TiledBacking.h: Expose revalidateTiles()
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp: Remove
platformCALayerDidCreateTiles() override.
- platform/graphics/ca/GraphicsLayerCA.h: Keep track of m_isCommittingChanges
so we can assert. Add TilingAreaChanged flag.
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::GraphicsLayerCA):
(WebCore::GraphicsLayerCA::recursiveCommitChanges): noteSublayersChanged() is
used inside of a commit in some cases to trigger a parent layer to update
children after the children have been processed. To avoid trying to pointlessly
schedule the flusher inside a flush, and for strong assertions, use a new flag
that indicates that flushing is not required in this situation.
Set the m_isCommittingChanges flag around committing state.
(WebCore::GraphicsLayerCA::platformCALayerSetNeedsToRevalidateTiles): We used
to use platformCALayerDidCreateTiles() to ensure that we would flush after adding
new tiles to avoid garbage flashes. Now that we only ever create tiles inside
a flush, this is no longer necessary.
The new platformCALayerSetNeedsToRevalidateTiles() function just sets the
TilingAreaChanged flag and triggers a flush.
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): After updating
visible rect, we look for the TilingAreaChanged flag to tell us whether to
revalidate TiledBacking tiles.
(WebCore::GraphicsLayerCA::ensureStructuralLayer): Use DontScheduleFlush when
telling a parent layer that it needs to reconsider sublayers.
(WebCore::GraphicsLayerCA::updateTiles): The caller of revalidateTiles().
(WebCore::GraphicsLayerCA::updateContentsRects): DontScheduleFlush again.
(WebCore::GraphicsLayerCA::noteSublayersChanged): Pass scheduleFlush along.
(WebCore::GraphicsLayerCA::noteLayerPropertyChanged): Handle scheduleFlush.
- platform/graphics/ca/PlatformCALayerClient.h:
(WebCore::PlatformCALayerClient::platformCALayerSetNeedsToRevalidateTiles): Added
so that TileController can call back out to GraphicsLayerCA.
(WebCore::PlatformCALayerClient::isCommittingChanges):
- platform/graphics/ca/mac/TileController.h: Need to keep track of secondary
coverage rects in m_secondaryTileCoverageRects.
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::tileCacheLayerBoundsChanged): Just trigger a tile revalidate,
which will happen later in this same commit.
(WebCore::TileController::setScale): This is called inside the commit. Does an extra
revalidate, which is needed to prune tiles. This could be optimized in future.
(WebCore::TileController::setVisibleRect): Assert that we're inside a commit,
and trigger a revalidate.
(WebCore::TileController::setExposedRect): Trigger a revalidate.
(WebCore::TileController::setClipsToExposedRect): Ditto.
(WebCore::TileController::prepopulateRect): Save the rect and trigger a revalidate.
(WebCore::TileController::setIsInWindow): If we're in the window, trigger a revalidate
otherwise schedule the timer.
(WebCore::TileController::revalidateTiles): Wrapper for the real revalidateTiles().
(WebCore::TileController::tileRevalidationTimerFired): If we're in the window,
schedule a revalidate. Otherwise our layer tree is disconnected, and it's OK to call revalidateTiles().
(WebCore::TileController::setNeedsRevalidateTiles): Call through the client to GraphicsLayerCA
which will schedule a layer tree flush.
(WebCore::TileController::revalidateTiles):
(WebCore::TileController::ensureTilesForRect): Move code from prepopulateRect
into here; ensureTilesForRect() for each secondary rect, then clear the rects.
No need to call platformCALayerDidCreateTiles() at the end.
- platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp: Remove
platformCALayerDidCreateTiles() override.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::scheduleLayerFlush): This should only be
called when we're not inside a flush, otherwise it will fail to schedule
another one.
- 1:38 PM Changeset in webkit [156290] by
-
- 2 edits in trunk/Tools
Added --64-bit option for Windows build.
https://bugs.webkit.org/show_bug.cgi?id=121799
Reviewed by Brent Fulgham.
- Scripts/webkitdirs.pm:
(determinePassedConfiguration): Add "|x64" for 64-bit configuration.
(isWin64): Added.
(determineIsWin64): Added.
- 1:24 PM Changeset in webkit [156289] by
-
- 21 edits in trunk/Source/WebCore
CTTE: htmlediting.h Element creation function should take a Document&
https://bugs.webkit.org/show_bug.cgi?id=121800
Reviewed by Antti Koivisto.
Thread the Document&!
- 1:23 PM Changeset in webkit [156288] by
-
- 5 edits in trunk/Source
[BlackBerry] Poor rendering opening a Google map short link
https://bugs.webkit.org/show_bug.cgi?id=121687
Source/WebCore:
Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-09-23.
Reviewed by Yong Li.
Internally reviewed by Liam Quinn and Joe Mason.
Fix a regression. It turns out that LayerCompositingThread already has
an API named isVisible() which by default returns false. So rename the
one in the LayerData to isLayerVisible().
- platform/graphics/blackberry/LayerData.h:
(WebCore::LayerData::isLayerVisible):
- platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::compositeLayersRecursive):
Source/WebKit/blackberry:
Patch by Jacky Jiang <zhajiang@blackberry.com> on 2013-09-23.
Reviewed by Yong Li.
Internally reviewed by Arvid Nilsson.
Clean up m_isAcceleratedCompositingActive as it has been deprecated.
- Api/WebPage_p.h:
- 1:09 PM Changeset in webkit [156287] by
-
- 2 edits in trunk/Source/WebKit2
[GTK][WK2] A plugin dirtyRect within iframe remains after moving to a different page.
https://bugs.webkit.org/show_bug.cgi?id=121600
Reviewed by Gustavo Noronha Silva.
Nowhere to destroy NetscapePlugin::m_platformPluginWidget even after destroying
an instance of NetscapePlugin. So the created GtkWidget remains visible.
- WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformDestroy):
- 12:46 PM Changeset in webkit [156286] by
-
- 3 edits in trunk/Source/JavaScriptCore
CodeLoad performance regression
Reviewed by Filip Pizlo.
Temporarily remove the ExpressionInfo compression until we can
work out how to make it not clobber performance.
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset):
(JSC::UnlinkedCodeBlock::addExpressionInfo):
- bytecode/UnlinkedCodeBlock.h:
- 12:32 PM Changeset in webkit [156285] by
-
- 38 edits in trunk/Source
Rename RenderObject::first/lastChild to RenderObject::first/lastChildSlow
https://bugs.webkit.org/show_bug.cgi?id=121784
Reviewed by Andreas Kling.
This will make it obvious in code where typing should be tightened.
Handled some simple cases by tightening the code instead of renaming.
- 12:27 PM Changeset in webkit [156284] by
-
- 5 edits in trunk/Source/WebInspectorUI
Hook up the initiator info and show it in the Resource details sidebar.
https://bugs.webkit.org/show_bug.cgi?id=121741
Reviewed by Joseph Pecoraro.
- UserInterface/FrameResourceManager.js:
(WebInspector.FrameResourceManager.prototype.resourceRequestWillBeSent):
(WebInspector.FrameResourceManager.prototype.resourceRequestWasServedFromMemoryCache):
(WebInspector.FrameResourceManager.prototype._addNewResourceToFrame):
(WebInspector.FrameResourceManager.prototype._initiatorSourceCodeLocationFromPayload):
- UserInterface/NetworkObserver.js:
(WebInspector.NetworkObserver.prototype.requestWillBeSent):
(WebInspector.NetworkObserver.prototype.requestServedFromMemoryCache):
- UserInterface/Resource.js:
(WebInspector.Resource):
(WebInspector.Resource.prototype.get initiatorSourceCodeLocation):
- UserInterface/ResourceDetailsSidebarPanel.js:
(WebInspector.ResourceDetailsSidebarPanel):
(WebInspector.ResourceDetailsSidebarPanel.prototype._refreshURL):
- 12:27 PM Changeset in webkit [156283] by
-
- 2 edits in trunk/Source/WTF
Clean up ListHashSet
https://bugs.webkit.org/show_bug.cgi?id=121797
Reviewed by Antti Koivisto.
- wtf/ListHashSet.h:
- 12:02 PM Changeset in webkit [156282] by
-
- 5 edits2 adds in trunk
[Texmap] Reloading a webgl page doesn't work
https://bugs.webkit.org/show_bug.cgi?id=120593
Reviewed by Noam Rosenthal.
Source/WebCore:
Let GraphicsLayerTextureMapper know it needs to detach the platform layer when a GraphicsContext3D is destroyed.
Test: fast/canvas/webgl/webgl-reload-crash.html
- platform/graphics/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
- platform/graphics/texmap/TextureMapperPlatformLayer.h:
LayoutTests:
Add a new test case to check if a crash occurs while reloading a page which contains webgl.
- fast/canvas/webgl/webgl-reload-crash-expected.txt: Added.
- fast/canvas/webgl/webgl-reload-crash.html: Added.
- 11:21 AM Changeset in webkit [156281] by
-
- 4 edits in trunk
ListHashSet should use std::reverse_iterator for reverse iterators
https://bugs.webkit.org/show_bug.cgi?id=121795
Reviewed by Antti Koivisto.
Source/WTF:
Get rid of the custom reverse iterators and just use std::reverse_iterator instead.
- wtf/ListHashSet.h:
Tools:
Add test for reverse iterators.
- TestWebKitAPI/Tests/WTF/ListHashSet.cpp:
(TestWebKitAPI::TEST):
- 10:54 AM Changeset in webkit [156280] by
-
- 2 edits in trunk/LayoutTests
Audio object garbage collection is incorrect (media/audio-garbage-collect.html test is flaky)
https://bugs.webkit.org/show_bug.cgi?id=72698
Skipping the test. It frequently times out, and when it doesn't, that's only
because if fails to detect incorrect behavior.
- 10:50 AM Changeset in webkit [156279] by
-
- 3 edits in trunk/Source/WebKit2
Add back the SharedWorkerStrategy to prevent crashing.
- WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit::WebPlatformStrategies::createSharedWorkerStrategy):
(WebKit::WebPlatformStrategies::isAvailable):
- WebProcess/WebCoreSupport/WebPlatformStrategies.h:
- 10:43 AM Changeset in webkit [156278] by
-
- 40 edits2 deletes in trunk/Source/WebCore
Remove RenderObjectChildList
https://bugs.webkit.org/show_bug.cgi?id=121771
Reviewed by Darin Adler.
Most RenderElement subclasses have m_children member (>90% of instances on typical page). It is not worth optimising
for memory for the few cases that don't (RenderImage, RenderLineBreak mostly) in expense of performance.
This patch moves child handling to RenderElement. This gets rid of virtual children() calls and simplifies the code.
- 10:39 AM Changeset in webkit [156277] by
-
- 15 edits11 deletes in trunk/Source/WebKit2
SharedWorkerProcess code is dead
https://bugs.webkit.org/show_bug.cgi?id=121563
Reviewed by Alexey Proskuryakov.
Remove SharedWorkerProcess code.
- 10:33 AM Changeset in webkit [156276] by
-
- 2 edits in trunk/Source/WTF
De-indent ListHashSet in preparation of more changes.
Rubber-stamped by Sam Weinig.
- wtf/ListHashSet.h:
- 10:15 AM Changeset in webkit [156275] by
-
- 2 edits in branches/safari-537.60-branch/Source/WebCore
Merged r156223. <rdar://problem/15048898>
- 9:32 AM Changeset in webkit [156274] by
-
- 2 edits in trunk/Source/WebCore
Document::destroyRenderTree() shouldn't do anything but.
<https://webkit.org/b/121786>
Reviewed by Anders Carlsson.
Move everything in destroyRenderTree() that doesn't actually destroy
render trees to prepareForDestruction() instead.
Destroying the render tree is now a reparable operation.
- 8:47 AM Changeset in webkit [156273] by
-
- 6 edits in trunk
[EFL] accessibility/aria-invalid is failing
https://bugs.webkit.org/show_bug.cgi?id=111986
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-23
Reviewed by Mario Sanchez Prada.
Tools:
Adds possibility to retrieve JS context.
This is part of the implementation of AccessibilityUIElement::addNotificationListener
from 119883 and 120421.
- DumpRenderTree/atk/AccessibilityCallbacksAtk.cpp:
(axObjectEventListener):
(addAccessibilityNotificationHandler):
(removeAccessibilityNotificationHandler):
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
(WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
(WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
LayoutTests:
Test passes on both efk-wk2 and efl-wk1, because of the patches from bugs: 119883 and 120421.
- platform/efl-wk1/TestExpectations: Removed accessibility/aria-invalid.html
- platform/efl-wk2/TestExpectations: Removed accessibility/aria-invalid.html
- 8:40 AM Changeset in webkit [156272] by
-
- 2 edits in trunk/Source/WebCore
[Qt] Tiled backing-store causes wrong translation
https://bugs.webkit.org/show_bug.cgi?id=121789
Reviewed by Noam Rosenthal.
Move the translation inside save/restore of the GraphicsContext.
- platform/graphics/qt/TileQt.cpp:
(WebCore::TileQt::updateBackBuffer):
- 8:09 AM Changeset in webkit [156271] by
-
- 8 edits1 add in trunk
[Autotools] Rework the build target selection
https://bugs.webkit.org/show_bug.cgi?id=121703
Reviewed by Gustavo Noronha Silva.
Replace the --with-target configuration flag with target-specific --enable-*-target flags:
- --enable-x11-target
- --enable-wayland-target
- --enable-win32-target
- --enable-quartz-target
- --enable-directfb-target
By default, the X11 target is enabled. This default is preserved only if no --enable-*-target flag
is passed on the command line. When that occurs, the newly-constructed list of build targets is
used to determine what build targets should actually be built. So for instance, executing just
./configurewould only enable the X11 target as that's the default, and executing
./configure --enable-wayland-targetwould only enable the Wayland target, as the defaults are
completely ignored.
- Source/autotools/CheckSystemAndBasicDependencies.m4: Abort if grep was not found, just in case.
- Source/autotools/CustomMacros.m4: The new file that contains helpful custom macros.
- Source/autotools/FindDependencies.m4: Use the appropriate 'enable_*_target' references instead of 'with_*target'.
- Source/autotools/PrintBuildConfiguration.m4: Use the new AM_APPEND_TO_DESCRIPTION macro to construct a pretty-looking
description string of what targets will be built.
- Source/autotools/ReadCommandLineArguments.m4: Replace the --with-target configuration flag and the related
hacks with the set of --enable-*-target flags. The new AM_DETERMINE_BUILD_TARGET_STATUS macro is used to determine
whether to enable specific build targets, based indirectly on the passed-in --enable-*-target flags.
- Source/autotools/SetupAutoconfHeader.m4: Use the appropriate 'enable_*_target' references instead of 'with_*target'.
- Source/autotools/SetupAutomake.m4: Use the appropriate 'enable_*_target' references instead of 'with_*target'.
- configure.ac: Include the new CustomMacros.m4 file.
- 6:04 AM Changeset in webkit [156270] by
-
- 4 edits in trunk/Source/WebCore
Unify code paths leading to render tree teardown.
<https://webkit.org/b/121785>
Reviewed by Antti Koivisto.
Make Document::prepareForDestruction() fit all the call sites that were
doing destroyRenderTree() + disconnectFromFrame().
- disconnectDescendantFrames() is already a no-op if there are no frames.
- willDetachDocumentFromFrame() will only run if there is a frame.
This is another step towards making tree rebuild possible.
Removed some age-old FIXMEs about why we aren't calling willRemove(),
a long-gone function.
- 5:23 AM WebKitGTK/2.0.x edited by
- (diff)
- 5:03 AM Changeset in webkit [156269] by
-
- 2 edits in trunk
[GTK] Bump version
Reviewed by Carlos Garcia Campos.
- Source/autotools/Versions.m4: Bump to 2.3.0
- 4:04 AM QtWebKitBuildBots edited by
- Updating EWS info to Qt 5.1.1 (diff)
- 2:51 AM Changeset in webkit [156268] by
-
- 2 edits in trunk/LayoutTests
[EFL] accessibility/selection-states.html is failing
https://bugs.webkit.org/show_bug.cgi?id=112007
Unreviewed EFL gardening. Passes after r156149.
Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-09-23
- platform/efl-wk2/TestExpectations:
- 1:26 AM Changeset in webkit [156267] by
-
- 7 edits in trunk/Source/WebCore
Cleanup CMake files in WebCore
https://bugs.webkit.org/show_bug.cgi?id=119262
Reviewed by Gyuyoung Kim.
Sort files and unify style.
- CMakeLists.txt:
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- PlatformWin.cmake:
- PlatformWinCE.cmake:
- 1:09 AM Changeset in webkit [156266] by
-
- 4 edits in trunk/Source/WebKit
Cleanup CMake files in WebKit
https://bugs.webkit.org/show_bug.cgi?id=121763
Reviewed by Gyuyoung Kim.
Sort files and unify style.
- PlatformBlackBerry.cmake:
- PlatformEfl.cmake:
- PlatformWinCE.cmake:
- 1:07 AM Changeset in webkit [156265] by
-
- 4 edits in trunk/Source/WebKit2
Cleanup CMake files in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=121767
Reviewed by Gyuyoung Kim.
Sort files and unify style.
- CMakeLists.txt:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- 1:03 AM Changeset in webkit [156264] by
-
- 4 edits in trunk/Source/WTF
Cleanup CMake files in WTF
https://bugs.webkit.org/show_bug.cgi?id=121761
Reviewed by Gyuyoung Kim.
Sort files and unify the style.
- wtf/CMakeLists.txt:
- wtf/PlatformEfl.cmake:
- wtf/PlatformGTK.cmake:
- 1:02 AM Changeset in webkit [156263] by
-
- 5 edits in trunk/Source/JavaScriptCore
Cleanup CMake files in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=121762
Reviewed by Gyuyoung Kim.
Sort files and unify style.
- CMakeLists.txt:
- shell/CMakeLists.txt:
- shell/PlatformBlackBerry.cmake:
- shell/PlatformEfl.cmake:
Sep 22, 2013:
- 11:41 PM WebKitGTK/2.2.x edited by
- (diff)
- 11:35 PM Changeset in webkit [156262] by
-
- 40 edits1 copy1 add in trunk/Source/WebCore
Unreviewed, rolling out r156254.
http://trac.webkit.org/changeset/156254
https://bugs.webkit.org/show_bug.cgi?id=121779
Caused assertions in fast/regions tests (Requested by ap on
#webkit).
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.xcodeproj/project.pbxproj:
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::willBeDestroyed):
(WebCore::RenderBlock::addChildToAnonymousColumnBlocks):
(WebCore::RenderBlock::splitBlocks):
(WebCore::RenderBlock::splitFlow):
(WebCore::RenderBlock::makeChildrenAnonymousColumnBlocks):
(WebCore::RenderBlock::makeChildrenNonInline):
(WebCore::RenderBlock::removeLeftoverAnonymousBlock):
(WebCore::RenderBlock::collapseAnonymousBoxChild):
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::updateFirstLetterStyle):
- rendering/RenderBlock.h:
(WebCore::RenderBlock::firstChild):
(WebCore::RenderBlock::lastChild):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::splitAnonymousBoxesAroundChild):
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::moveChildTo):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::RenderElement):
(WebCore::RenderElement::addChild):
(WebCore::RenderElement::removeChild):
- rendering/RenderElement.h:
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::layout):
- rendering/RenderEmbeddedObject.h:
- rendering/RenderFrameSet.h:
- rendering/RenderInline.cpp:
(WebCore::RenderInline::willBeDestroyed):
(WebCore::RenderInline::splitInlines):
(WebCore::RenderInline::splitFlow):
(WebCore::RenderInline::childBecameNonInline):
- rendering/RenderInline.h:
(WebCore::RenderInline::firstChild):
(WebCore::RenderInline::lastChild):
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::willBeDestroyed):
- rendering/RenderLineBreak.h:
- rendering/RenderListMarker.h:
- rendering/RenderMedia.cpp:
(WebCore::RenderMedia::layout):
- rendering/RenderMedia.h:
(WebCore::RenderMedia::firstChild):
(WebCore::RenderMedia::lastChild):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::handleDynamicFloatPositionChange):
(WebCore::RenderObject::willBeDestroyed):
(WebCore::RenderObject::removeFromRenderFlowThreadRecursive):
- rendering/RenderObject.h:
(WebCore::RenderObject::firstChild):
(WebCore::RenderObject::lastChild):
(WebCore::RenderObject::children):
(WebCore::RenderObject::canHaveChildren):
- rendering/RenderObjectChildList.cpp: Added.
(WebCore::RenderObjectChildList::destroyLeftoverChildren):
(WebCore::RenderObjectChildList::removeChildNode):
(WebCore::RenderObjectChildList::insertChildNode):
- rendering/RenderObjectChildList.h: Copied from Source/WebCore/rendering/RenderMedia.h.
(WebCore::RenderObjectChildList::RenderObjectChildList):
(WebCore::RenderObjectChildList::firstChild):
(WebCore::RenderObjectChildList::lastChild):
(WebCore::RenderObjectChildList::setFirstChild):
(WebCore::RenderObjectChildList::setLastChild):
(WebCore::RenderObjectChildList::appendChildNode):
- rendering/RenderReplaced.h:
(WebCore::RenderReplaced::canHaveChildren):
- rendering/RenderReplica.h:
- rendering/RenderRubyBase.cpp:
(WebCore::RenderRubyBase::moveInlineChildren):
(WebCore::RenderRubyBase::moveBlockChildren):
- rendering/RenderTableCol.h:
- rendering/RenderTableRow.h:
- rendering/RenderTableSection.h:
- rendering/RenderText.h:
- rendering/RenderingAllInOne.cpp:
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::updateFromElement):
- rendering/svg/RenderSVGContainer.h:
(WebCore::RenderSVGContainer::firstChild):
(WebCore::RenderSVGContainer::lastChild):
- rendering/svg/RenderSVGGradientStop.h:
- rendering/svg/RenderSVGImage.h:
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::willBeDestroyed):
- rendering/svg/RenderSVGRoot.h:
- rendering/svg/RenderSVGShape.h:
- 11:34 PM Changeset in webkit [156261] by
-
- 2 edits in trunk/Source/WebKit/gtk
Unreviewed, GTK build fix when building with GTK+ 2.0.
Patch provided by Dominique Leuenberger <dimstar@opensuse.org>.
- WebCoreSupport/AcceleratedCompositingContextGL.cpp: Include GtkVersioning.h to set up
the mock GDK_IS_X11_DISPLAY macro if it's not provided by the GTK+ headers.
- 11:33 PM Changeset in webkit [156260] by
-
- 45 edits in trunk/Source/WebCore
Unreviewed, rolling out r156253.
http://trac.webkit.org/changeset/156253
https://bugs.webkit.org/show_bug.cgi?id=121778
Caused >20 tests to crash with assertion failures (Requested
by ap on #webkit).
- css/CSSAspectRatioValue.h:
- css/CSSBorderImageSliceValue.h:
- css/CSSCalculationValue.cpp:
(WebCore::CSSCalcExpressionNodeParser::parseValue):
- css/CSSCalculationValue.h:
- css/CSSCrossfadeValue.cpp:
(WebCore::subimageKnownToBeOpaque):
- css/CSSCrossfadeValue.h:
(WebCore::toCSSCrossfadeValue):
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::~CSSCursorImageValue):
(WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
(WebCore::CSSCursorImageValue::cachedImage):
(WebCore::CSSCursorImageValue::cachedOrPendingImage):
(WebCore::CSSCursorImageValue::isSVGCursor):
- css/CSSCursorImageValue.h:
- css/CSSFilterImageValue.h:
(WebCore::toCSSFilterImageValue):
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
- css/CSSGradientValue.h:
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):
(WebCore::CSSImageGeneratorValue::subimageIsPending):
(WebCore::CSSImageGeneratorValue::cachedImageForCSSValue):
- css/CSSImageGeneratorValue.h:
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::fillImageSet):
- css/CSSImageSetValue.h:
- css/CSSImageValue.h:
- css/CSSInheritedValue.h:
- css/CSSInitialValue.h:
- css/CSSLineBoxContainValue.h:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::parseRadialGradient):
- css/CSSPrimitiveValue.h:
- css/CSSReflectValue.h:
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillAttachment):
(WebCore::CSSToStyleMap::mapFillClip):
(WebCore::CSSToStyleMap::mapFillComposite):
(WebCore::CSSToStyleMap::mapFillBlendMode):
(WebCore::CSSToStyleMap::mapFillOrigin):
(WebCore::CSSToStyleMap::mapFillRepeatX):
(WebCore::CSSToStyleMap::mapFillRepeatY):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapFillMaskSourceType):
(WebCore::CSSToStyleMap::mapAnimationDelay):
(WebCore::CSSToStyleMap::mapAnimationDirection):
(WebCore::CSSToStyleMap::mapAnimationDuration):
(WebCore::CSSToStyleMap::mapAnimationFillMode):
(WebCore::CSSToStyleMap::mapAnimationIterationCount):
(WebCore::CSSToStyleMap::mapAnimationName):
(WebCore::CSSToStyleMap::mapAnimationPlayState):
(WebCore::CSSToStyleMap::mapAnimationProperty):
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
(WebCore::CSSToStyleMap::mapNinePieceImageSlice):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
(WebCore::CSSToStyleMap::mapNinePieceImageRepeat):
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isCSSLineBoxContainValue):
(WebCore::CSSValue::isCalculationValue):
- css/CSSValueList.h:
- css/CSSVariableValue.h:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyMarqueeIncrement::applyValue):
(WebCore::ApplyPropertyMarqueeRepetition::applyValue):
(WebCore::ApplyPropertyMarqueeSpeed::applyValue):
(WebCore::ApplyPropertyTextUnderlinePosition::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
- css/FontFeatureValue.h:
- css/FontValue.h:
- css/MediaList.cpp:
(WebCore::reportMediaQueryWarningIfNeeded):
- css/MediaQueryEvaluator.cpp:
(WebCore::compareAspectRatioValue):
(WebCore::numberValue):
(WebCore::orientationMediaFeatureEval):
(WebCore::evalResolution):
(WebCore::device_pixel_ratioMediaFeatureEval):
(WebCore::resolutionMediaFeatureEval):
(WebCore::computeLength):
(WebCore::view_modeMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/ShadowValue.h:
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getLayeredShorthandValue):
- css/StyleResolver.cpp:
(WebCore::createGridTrackSize):
(WebCore::createGridTrackList):
(WebCore::createGridPosition):
(WebCore::hasVariableReference):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::styleShader):
(WebCore::StyleResolver::parseCustomFilterArrayParameter):
(WebCore::StyleResolver::parseCustomFilterColorParameter):
(WebCore::StyleResolver::parseCustomFilterNumberParameter):
(WebCore::StyleResolver::parseCustomFilterParameter):
(WebCore::StyleResolver::parseCustomFilterParameterList):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):
- css/TransformFunctions.cpp:
(WebCore::transformsForValue):
- css/ViewportStyleResolver.cpp:
(WebCore::ViewportStyleResolver::getViewportArgumentValue):
- css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::computedFontSize):
- editing/EditingStyle.cpp:
(WebCore::identifierForStyleProperty):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(WebCore::cssValueToRGBA):
(WebCore::EditingStyle::extractFontSizeDelta):
(WebCore::EditingStyle::textDirection):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::EditingStyle::legacyFontSize):
(WebCore::EditingStyle::textDirectionForSelection):
(WebCore::StyleChange::extractTextStyles):
(WebCore::fontWeightIsBold):
(WebCore::isTransparentColorValue):
- editing/markup.cpp:
(WebCore::propertyMissingOrEqualToNone):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::retrieveResourcesForProperties):
- rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::data):
(WebCore::StylePendingImage::cssImageValue):
(WebCore::StylePendingImage::cssImageGeneratorValue):
(WebCore::StylePendingImage::cssCursorImageValue):
(WebCore::StylePendingImage::cssImageSetValue):
- 11:31 PM Changeset in webkit [156259] by
-
- 3 edits2 deletes in trunk
Unreviewed, rolling out r156257.
http://trac.webkit.org/changeset/156257
https://bugs.webkit.org/show_bug.cgi?id=121777
The test from this patch fails (Requested by ap on #webkit).
Source/WebCore:
- rendering/RenderBox.cpp:
(WebCore::RenderBox::calculateAutoscrollDirection):
LayoutTests:
- fast/events/drag-and-drop-autoscroll-inner-frame-expected.txt: Removed.
- fast/events/drag-and-drop-autoscroll-inner-frame.html: Removed.
- 9:32 PM Changeset in webkit [156258] by
-
- 10 edits in trunk/LayoutTests
Unreviewed EFL gardening. Rebaselining after r156040.
- platform/efl/fast/forms/HTMLOptionElement_label06-expected.txt:
- platform/efl/fast/forms/HTMLOptionElement_label07-expected.txt:
- platform/efl/fast/forms/form-element-geometry-expected.txt:
- platform/efl/fast/forms/menulist-separator-painting-expected.txt:
- platform/efl/fast/forms/select-baseline-expected.txt:
- platform/efl/fast/forms/select-empty-option-height-expected.txt:
- platform/efl/fast/forms/selectlist-minsize-expected.txt:
- platform/efl/fast/html/keygen-expected.txt:
- platform/efl/fast/replaced/three-selects-break-expected.txt:
- 9:03 PM Changeset in webkit [156257] by
-
- 3 edits2 adds in trunk
iframe and scrollbar with "overflow:auto" should support autoscroll with mousedrag
https://bugs.webkit.org/show_bug.cgi?id=40981
Reviewed by Darin Adler.
Patch by Antonio Gomes <a1.gomes@sisa.samsung.com>
Source/WebCore:
RenderBox::calculateAutoscrollDirection does not properly translate
inner frames' coordinates in order to determine its auto-scrollability.
By coincidence, if the inner frame box it placed near to page's 0, 0 position
(upper left corner), it might work.
Patch fixes it by changing ::calculateAutoscrollDirection algorithm to operate
with window coordinates, taking inner frames offset and scroll position into account.
The behavior of auto-scrollable non-frame overflow boxes, including divs, still works
as it is used to.
Test: fast/events/drag-and-drop-autoscroll-inner-frame.html
- rendering/RenderBox.cpp:
(WebCore::RenderBox::calculateAutoscrollDirection):
LayoutTests:
Test ensures that dragging an element close to the boundary of
scrollable Frames, scroll its content in that direction.
- fast/events/drag-and-drop-autoscroll-inner-frame-expected.txt: Added.
- fast/events/drag-and-drop-autoscroll-inner-frame.html: Added.
- 8:40 PM Changeset in webkit [156256] by
-
- 40 edits in trunk/Source
CTTE: Use references more in ContainerNode, ContainerNodeAlgorithms and related classes
https://bugs.webkit.org/show_bug.cgi?id=121772
Reviewed by Andreas Kling.
../WebCore:
Use references for never null Nodes in ContainerNode and related classes.
../WebKit/qt:
- Api/qwebelement.cpp:
(QWebElementCollection::append):
Update to work with the new StaticNodeList adopt function.
- 7:59 PM Changeset in webkit [156255] by
-
- 5 edits in trunk/Source/WebCore
Fix functions calling to RenderObject superclass to call RenderElement instead
https://bugs.webkit.org/show_bug.cgi?id=121773
Reviewed by Andreas Kling.
The class hierarchy has a new class. Superclass calls should be pointed there instead to
avoid future bugs.
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::setSelectionState):
- rendering/RenderLayerModelObject.cpp:
(WebCore::RenderLayerModelObject::styleWillChange):
(WebCore::RenderLayerModelObject::styleDidChange):
- rendering/svg/RenderSVGGradientStop.cpp:
(WebCore::RenderSVGGradientStop::styleDidChange):
- rendering/svg/RenderSVGModelObject.cpp:
(WebCore::RenderSVGModelObject::styleWillChange):
(WebCore::RenderSVGModelObject::styleDidChange):
- 7:35 PM Changeset in webkit [156254] by
-
- 40 edits2 deletes in trunk/Source/WebCore
Remove RenderObjectChildList
https://bugs.webkit.org/show_bug.cgi?id=121771
Reviewed by Darin Adler.
Most RenderElement subclasses have m_children member (>90% of instances on typical page). It is not worth optimising
for memory for the few cases that don't (RenderImage, RenderLineBreak mostly) in expense of performance.
This patch moves child handling to RenderElement. This gets rid of virtual children() calls and simplifies the code.
- 6:20 PM Changeset in webkit [156253] by
-
- 45 edits in trunk/Source/WebCore
Introduce CSS_VALUE_TYPE_CASTS macro in order to cast CSSValue type
https://bugs.webkit.org/show_bug.cgi?id=121462
Reviewed by Andreas Kling.
As r155429 introduced ELEMENT_TYPE_CASTS, CSS_VALUE_TYPE_CASTS can be used
by css value type casting as well. This type cast macros will help to detect
bad-cast bugs as well as improve a code readibility.
This patch adds the following methods,
- CSSFooValue* toCSSFooValue(CSSValue*)
- const CSSFooValue* toCSSFooValue(const CSSValue*)
To be consistent with other is*Value() naming style, isCSSLineBoxContainValue() and isCalculationValue()
are changed with isLineBoxContainValue() and isCalcValue().
FontValue, FontFeatureValue, ShadowValue have a manual type case function because of different
class naming style. So, toFontValue(), toFontFeatureValue() and toShadowValue() are added manually.
This patch removes unnecessary local variables.
No new tests, no behavior change.
- css/CSSAspectRatioValue.h:
- css/CSSBorderImageSliceValue.h:
- css/CSSCalculationValue.cpp:
(WebCore::CSSCalcExpressionNodeParser::parseValue):
- css/CSSCalculationValue.h:
- css/CSSCrossfadeValue.cpp:
(WebCore::subimageKnownToBeOpaque):
- css/CSSCrossfadeValue.h:
- css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::~CSSCursorImageValue):
(WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):
(WebCore::CSSCursorImageValue::cachedImage):
(WebCore::CSSCursorImageValue::cachedOrPendingImage):
(WebCore::CSSCursorImageValue::isSVGCursor):
- css/CSSCursorImageValue.h:
- css/CSSFilterImageValue.h:
- css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
- css/CSSGradientValue.h:
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::image):
(WebCore::CSSImageGeneratorValue::fixedSize):
(WebCore::CSSImageGeneratorValue::loadSubimages):
(WebCore::CSSImageGeneratorValue::subimageIsPending):
(WebCore::CSSImageGeneratorValue::cachedImageForCSSValue):
- css/CSSImageGeneratorValue.h:
- css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::fillImageSet):
- css/CSSImageSetValue.h:
- css/CSSImageValue.h:
- css/CSSInheritedValue.h:
- css/CSSInitialValue.h:
- css/CSSLineBoxContainValue.h:
- css/CSSParser.cpp:
(WebCore::CSSParser::parseColor):
(WebCore::CSSParser::addProperty):
(WebCore::CSSParser::parse3ValuesFillPosition):
(WebCore::CSSParser::parseFillPosition):
(WebCore::CSSParser::parseFillRepeat):
(WebCore::CSSParser::parseDeprecatedRadialGradient):
(WebCore::CSSParser::parseRadialGradient):
- css/CSSPrimitiveValue.h:
- css/CSSReflectValue.h:
- css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillAttachment):
(WebCore::CSSToStyleMap::mapFillClip):
(WebCore::CSSToStyleMap::mapFillComposite):
(WebCore::CSSToStyleMap::mapFillBlendMode):
(WebCore::CSSToStyleMap::mapFillOrigin):
(WebCore::CSSToStyleMap::mapFillRepeatX):
(WebCore::CSSToStyleMap::mapFillRepeatY):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapFillMaskSourceType):
(WebCore::CSSToStyleMap::mapAnimationDelay):
(WebCore::CSSToStyleMap::mapAnimationDirection):
(WebCore::CSSToStyleMap::mapAnimationDuration):
(WebCore::CSSToStyleMap::mapAnimationFillMode):
(WebCore::CSSToStyleMap::mapAnimationIterationCount):
(WebCore::CSSToStyleMap::mapAnimationName):
(WebCore::CSSToStyleMap::mapAnimationPlayState):
(WebCore::CSSToStyleMap::mapAnimationProperty):
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
(WebCore::CSSToStyleMap::mapNinePieceImageSlice):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
(WebCore::CSSToStyleMap::mapNinePieceImageRepeat):
- css/CSSValue.cpp:
(WebCore::CSSValue::destroy):
- css/CSSValue.h:
(WebCore::CSSValue::isLineBoxContainValue):
(WebCore::CSSValue::isCalcValue):
- css/CSSValueList.h:
- css/CSSVariableValue.h:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontFamily::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyMarqueeIncrement::applyValue):
(WebCore::ApplyPropertyMarqueeRepetition::applyValue):
(WebCore::ApplyPropertyMarqueeSpeed::applyValue):
(WebCore::ApplyPropertyTextUnderlinePosition::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
(WebCore::ApplyPropertyTextIndent::applyValue):
- css/FontFeatureValue.h:
(WebCore::toFontFeatureValue):
- css/FontValue.h:
(WebCore::toFontValue):
- css/MediaList.cpp:
(WebCore::reportMediaQueryWarningIfNeeded):
- css/MediaQueryEvaluator.cpp:
(WebCore::compareAspectRatioValue):
(WebCore::numberValue):
(WebCore::orientationMediaFeatureEval):
(WebCore::evalResolution):
(WebCore::device_pixel_ratioMediaFeatureEval):
(WebCore::resolutionMediaFeatureEval):
(WebCore::computeLength):
(WebCore::view_modeMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):
- css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
- css/ShadowValue.h:
(WebCore::toShadowValue):
- css/StylePropertySet.cpp:
(WebCore::StylePropertySet::getLayeredShorthandValue):
- css/StyleResolver.cpp:
(WebCore::createGridTrackSize):
(WebCore::createGridTrackList):
(WebCore::createGridPosition):
(WebCore::hasVariableReference):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::styleShader):
(WebCore::StyleResolver::parseCustomFilterArrayParameter):
(WebCore::StyleResolver::parseCustomFilterColorParameter):
(WebCore::StyleResolver::parseCustomFilterNumberParameter):
(WebCore::StyleResolver::parseCustomFilterParameter):
(WebCore::StyleResolver::parseCustomFilterParameterList):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createFilterOperations):
- css/TransformFunctions.cpp:
(WebCore::transformsForValue):
- css/ViewportStyleResolver.cpp:
(WebCore::ViewportStyleResolver::getViewportArgumentValue):
- css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):
- css/WebKitCSSShaderValue.h:
(WebCore::toWebKitCSSShaderValue):
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::computedFontSize):
- editing/EditingStyle.cpp:
(WebCore::identifierForStyleProperty):
(WebCore::HTMLElementEquivalent::valueIsPresentInStyle):
(WebCore::cssValueToRGBA):
(WebCore::EditingStyle::extractFontSizeDelta):
(WebCore::EditingStyle::textDirection):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::EditingStyle::legacyFontSize):
(WebCore::EditingStyle::textDirectionForSelection):
(WebCore::StyleChange::extractTextStyles):
(WebCore::fontWeightIsBold):
(WebCore::isTransparentColorValue):
- editing/markup.cpp:
(WebCore::propertyMissingOrEqualToNone):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::retrieveResourcesForProperties):
- rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::data):
(WebCore::StylePendingImage::cssImageValue):
(WebCore::StylePendingImage::cssImageGeneratorValue):
(WebCore::StylePendingImage::cssCursorImageValue):
(WebCore::StylePendingImage::cssImageSetValue):
- 4:19 PM Changeset in webkit [156252] by
-
- 4 edits2 adds in trunk
Hiding a focused element should unfocus it and fire a blur event
https://bugs.webkit.org/show_bug.cgi?id=29241
Patch by Arunprasad Rajkumar <ararunprasad@gmail.com> on 2013-09-22
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/dom/HTMLDocument/active-element-gets-unfocusable.html
We check whether the current focus element is really focusable after
the style recalculation and layout change. If it is not focusable then schedule a
timer to reset it asynchronously.
- dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::recalcStyle): Check isFocusable() on the focus element after
style recalculation.
(WebCore::Document::updateLayout): Check isFocusable() on the focus element after
layout.
(WebCore::Document::resetHiddenFocusElementSoon):
(WebCore::Document::resetHiddenFocusElementTimer):
- dom/Document.h:
LayoutTests:
- fast/dom/HTMLDocument/active-element-gets-unfocusable-expected.txt: Added.
- fast/dom/HTMLDocument/active-element-gets-unfocusable.html: Added.
LayoutTest reused from https://chromium.googlesource.com/chromium/blink/+/c58f636fd18fc27944c42e27d6a92a36867c57e1
with little modification.
- 3:11 PM Changeset in webkit [156251] by
-
- 15 edits in trunk/Source/WebCore
CTTE: StaticNodeLists often contain only Elements, we shouldn't store them as Vector<RefPtr<Node>> in those cases
https://bugs.webkit.org/show_bug.cgi?id=121769
Reviewed by Andreas Kling.
Introduces StaticElementList and uses it.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
- bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::getNamedItems):
- bindings/js/JSHTMLCollectionCustom.cpp:
- bindings/js/JSHTMLFormControlsCollectionCustom.cpp:
(WebCore::getNamedItems):
- bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::nameGetter):
- dom/SelectorQuery.cpp:
(WebCore::AllElementExtractorSelectorQueryTrait::appendOutputForElement):
(WebCore::SelectorDataList::queryAll):
- dom/StaticNodeList.cpp:
(WebCore::StaticElementList::length):
(WebCore::StaticElementList::item):
(WebCore::StaticElementList::namedItem):
- dom/StaticNodeList.h:
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::getRegionsByContent):
(WebCore::WebKitNamedFlow::getRegions):
(WebCore::WebKitNamedFlow::getContent):
(WebCore::WebKitNamedFlow::dispatchRegionLayoutUpdateEvent):
(WebCore::WebKitNamedFlow::dispatchRegionOversetChangeEvent):
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::namedItems):
- html/HTMLCollection.h:
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::getNamedElements):
- html/HTMLFormElement.h:
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::collectIntersectionOrEnclosureList):
- 2:23 PM Changeset in webkit [156250] by
-
- 12 edits in trunk/Source/WebCore
CTTE: RenderNamedFlowThread and FlowThreadController should operate on Elements, not Nodes
https://bugs.webkit.org/show_bug.cgi?id=121768
Reviewed by Andreas Kling.
- dom/Element.cpp:
(WebCore::Element::unregisterNamedFlowContentElement):
(WebCore::Element::shouldMoveToFlowThread):
(WebCore::Element::clearStyleDerivedDataBeforeDetachingRenderer):
- dom/Element.h:
Update to new names and to pass this as a reference to the FlowThreadController.
- dom/Node.cpp:
- dom/Node.h:
Move isRegisteredWithNamedFlow() to Element.
- dom/WebKitNamedFlow.cpp:
(WebCore::WebKitNamedFlow::getRegionsByContent):
(WebCore::WebKitNamedFlow::getRegions):
(WebCore::WebKitNamedFlow::getContent):
Update for contentNodes() -> contentElements() name change. Modernize the code a bit
as well.
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::registerNamedFlowContentElement):
(WebCore::FlowThreadController::unregisterNamedFlowContentElement):
(WebCore::FlowThreadController::isContentElementRegisteredWithAnyNamedFlow):
- rendering/FlowThreadController.h:
Change the Node* -> RenderNamedFlowThread* map to a Element* -> RenderNamedFlowThread*. Update
functions taking Node*s to take Element&s.
- rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::~RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::clearContentElements):
(WebCore::RenderNamedFlowThread::registerNamedFlowContentElement):
(WebCore::RenderNamedFlowThread::unregisterNamedFlowContentElement):
(WebCore::RenderNamedFlowThread::hasContentElement):
(WebCore::isContainedInElements):
(WebCore::nextNodeInsideContentElement):
(WebCore::RenderNamedFlowThread::getRanges):
- rendering/RenderNamedFlowThread.h:
Change the NamedFlowContent set to store Elements rather than Nodes. Like with FlowThreadController,
update registration functions to take Element&s instead of Node*s, removing asserts.
- rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setRegionObjectsRegionStyle):
Update for new names.
- style/StyleResolveTree.cpp:
(WebCore::Style::moveToFlowThreadIfNeeded):
Pass the Element and RenderNamedFlowThread as references.
- 2:23 PM Changeset in webkit [156249] by
-
- 2 edits in trunk/Source/WebKit/win
Try to fix the windows build (take 2).
- DOMEventsClasses.cpp:
(DOMEvent::createInstance):
- 2:17 PM Changeset in webkit [156248] by
-
- 2 edits in trunk/Source/WebKit/win
Try to fix the windows build.
- DOMEventsClasses.cpp:
(DOMEvent::createInstance):
- 10:03 AM Changeset in webkit [156247] by
-
- 5 edits in trunk/Source/JavaScriptCore
Get rid of CodeBlock::RareData::callReturnIndexVector and most of the evil that it introduced
https://bugs.webkit.org/show_bug.cgi?id=121766
Reviewed by Andreas Kling.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shrinkToFit):
- bytecode/CodeBlock.h:
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileExceptionHandlers):
(JSC::DFG::JITCompiler::link):
- jit/JIT.cpp:
(JSC::JIT::privateCompile):
- 5:49 AM Changeset in webkit [156246] by
-
- 6 edits in trunk/Source
Give purity hints to compiler to avoid penalizing repeated calls to some functions.
<https://webkit.org/b/121744>
Reviewed by Darin Adler.
Source/WebCore:
Mark the following functions pure:
- gcController()
- cssValuePool()
- threadGlobalData()
I had this idea when I saw Darin's patch to cache cssValuePool() in a local.
We know that this function will always return the same value, so we should just
share this knowledge with the compiler and let it do the cleverness instead.
Source/WTF:
Added a PURE_FUNCTION macro. This is supported on GCC and Clang for now.
Marking a function pure means that the compiler's CSE pass is free to coalesce
multiple calls to this function because it has no globally observable side
effects beyond the first call.
- 12:34 AM Changeset in webkit [156245] by
-
- 7 edits in trunk/Source/WebKit/mac
Remove unused code in WebKit/mac's WebScriptDebugDelegate.
https://bugs.webkit.org/show_bug.cgi?id=121706.
Reviewed by Timothy Hatcher.
WebScriptDebugDelegate's didEnterCallFrame, willExecuteStatement,
and willLeaveCallFrame are not in use. Removed them and all methods
and fields used for supporting them.
- WebView/WebDelegateImplementationCaching.h:
- WebView/WebScriptDebugDelegate.h:
- WebView/WebScriptDebugDelegate.mm:
(-[WebScriptCallFramePrivate dealloc]):
(-[WebScriptCallFrame _initWithGlobalObject:debuggerCallFrame:]):
- WebView/WebScriptDebugger.h:
(WebScriptDebugger::globalObject):
(WebScriptDebugger::callEvent):
(WebScriptDebugger::atStatement):
(WebScriptDebugger::returnEvent):
(WebScriptDebugger::willExecuteProgram):
(WebScriptDebugger::didExecuteProgram):
(WebScriptDebugger::didReachBreakpoint):
- WebView/WebScriptDebugger.mm:
(WebScriptDebugger::WebScriptDebugger):
(WebScriptDebugger::exception):
- WebView/WebView.mm:
(-[WebView _cacheScriptDebugDelegateImplementations]):
- 12:15 AM Changeset in webkit [156244] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Fix accessibility-node-memory-management.html to use normal style for
GC-related tests, making it more robust
https://bugs.webkit.org/show_bug.cgi?id=121760
Rubber-stamped by Alexey Proskuryakov.
Change was accidentally landed in previous commit, this is the change log
that goes with it.
- accessibility/accessibility-node-memory-management.html:
Use jsTestIsAsync and setTimeout to do the garbage collection without the
rest of the script state on the stack. Also removed a lot of unneeded
"window." since the test works fine without them and tweaked comments.
- 12:11 AM Changeset in webkit [156243] by
-
- 3 edits in trunk
Fix too-strict type error exceptions introduced in WebGL bindings
https://bugs.webkit.org/show_bug.cgi?id=121759
Reviewed by Alexey Proskuryakov.
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::JSWebGLRenderingContext::getAttachedShaders): Allow undefined
or null without throwing type error.
(WebCore::JSWebGLRenderingContext::getProgramParameter): Ditto.
(WebCore::JSWebGLRenderingContext::getUniform): Ditto.
(WebCore::dataFunctionf): Ditto.
(WebCore::dataFunctioni): Ditto.
(WebCore::dataFunctionMatrix): Ditto.
Sep 21, 2013:
- 10:00 PM Changeset in webkit [156242] by
-
- 15 edits in trunk/Source/JavaScriptCore
Interpreter::unwind() has no need for the bytecodeOffset
https://bugs.webkit.org/show_bug.cgi?id=121755
Reviewed by Oliver Hunt.
It was only using the bytecodeOffset for some debugger stuff, but the debugger could
just get the bytecodeOffset the same way the rest of the machinery does: by using the
CallFrame's location.
It turns out that a lot of really ugly code was in place just to supply this
bytecodeOffset. This patch kills most of that code, and allows us to kill even more
code in a future patch - though most likely that killage will involve further
refactorings as well, see https://bugs.webkit.org/show_bug.cgi?id=121734.
- dfg/DFGOperations.cpp:
- interpreter/CallFrame.cpp:
(JSC::CallFrame::bytecodeOffset):
(JSC::CallFrame::codeOrigin):
- interpreter/CallFrame.h:
- interpreter/Interpreter.cpp:
(JSC::Interpreter::unwind):
- interpreter/Interpreter.h:
- jit/JITExceptions.cpp:
(JSC::genericUnwind):
- jit/JITExceptions.h:
- jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
(JSC::cti_vm_handle_exception):
- llint/LLIntExceptions.cpp:
(JSC::LLInt::doThrow):
(JSC::LLInt::returnToThrow):
(JSC::LLInt::callToThrow):
- llint/LLIntExceptions.h:
- llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/CommonSlowPathsExceptions.cpp:
(JSC::CommonSlowPaths::interpreterThrowInCaller):
- runtime/CommonSlowPathsExceptions.h:
- 9:15 PM Changeset in webkit [156241] by
-
- 202 edits in trunk/Source/WebCore
Event and EventTarget interfaces don't need to be store as AtomicStrings
https://bugs.webkit.org/show_bug.cgi?id=121751
Reviewed by Andreas Kling.
Convert the Event and EventTarget interface identifiers from AtomicStrings to enums. They
are not extensible and not exposed as Strings anywhere.
- Files elided *
- 9:02 PM Changeset in webkit [156240] by
-
- 46 edits in trunk/Source
Add ExecState::uncheckedArgument and use where possible to shrink a bit
https://bugs.webkit.org/show_bug.cgi?id=121750
Reviewed by Andreas Kling.
Source/JavaScriptCore:
- interpreter/CallFrame.h:
(JSC::ExecState::uncheckedArgument): Added. Like argument, but with an
assertion rather than a runtime check.
- API/APICallbackFunction.h:
(JSC::APICallbackFunction::call): Use uncheckedArgument because we are
already in a loop over arguments, so don't need a range check.
- API/JSCallbackConstructor.cpp:
(JSC::constructJSCallback): Ditto.
- API/JSCallbackObjectFunctions.h:
(JSC::JSCallbackObject::construct): Ditto.
(JSC::JSCallbackObject::call): Ditto.
- jsc.cpp:
(functionPrint): Ditto.
(functionRun): Ditto.
(functionSetSamplingFlags): Ditto.
(functionClearSamplingFlags): Ditto.
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncConcat): Ditto.
(JSC::arrayProtoFuncPush): Use uncheckedArgument because there is already
code that explicitly checks argumentCount.
(JSC::arrayProtoFuncSplice): Ditto.
(JSC::arrayProtoFuncUnShift): Ditto.
(JSC::arrayProtoFuncReduce): Ditto.
(JSC::arrayProtoFuncReduceRight): Ditto.
(JSC::arrayProtoFuncLastIndexOf): Ditto.
- runtime/DatePrototype.cpp:
(JSC::fillStructuresUsingTimeArgs): Ditto.
(JSC::fillStructuresUsingDateArgs): Ditto.
- runtime/JSArrayBufferConstructor.cpp:
(JSC::constructArrayBuffer): Ditto.
- runtime/JSArrayBufferPrototype.cpp:
(JSC::arrayBufferProtoFuncSlice): Ditto.
- runtime/JSBoundFunction.cpp:
(JSC::boundFunctionCall): Ditto.
(JSC::boundFunctionConstruct): Ditto.
- runtime/JSDataViewPrototype.cpp:
(JSC::getData): Ditto.
(JSC::setData): Ditto.
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::constructGenericTypedArrayView): Ditto.
- runtime/JSGenericTypedArrayViewPrototypeInlines.h:
(JSC::genericTypedArrayViewProtoFuncSet): Ditto.
(JSC::genericTypedArrayViewProtoFuncSubarray): Ditto.
- runtime/JSONObject.cpp:
(JSC::JSONProtoFuncParse): Ditto.
(JSC::JSONProtoFuncStringify): Ditto.
- runtime/JSPromiseConstructor.cpp:
(JSC::constructPromise): Ditto.
(JSC::JSPromiseConstructorFuncFulfill): Ditto.
(JSC::JSPromiseConstructorFuncResolve): Ditto.
(JSC::JSPromiseConstructorFuncReject): Ditto.
- runtime/MathObject.cpp:
(JSC::mathProtoFuncMax): Ditto.
(JSC::mathProtoFuncMin): Ditto.
- runtime/NameConstructor.cpp:
(JSC::constructPrivateName): Removed unneeded check of argumentCout
that simply repeats what argument already does.
- runtime/NativeErrorConstructor.cpp:
(JSC::Interpreter::constructWithNativeErrorConstructor): Ditto.
(JSC::Interpreter::callNativeErrorConstructor): Ditto.
- runtime/NumberConstructor.cpp:
(JSC::constructWithNumberConstructor): Use uncheckedArgument since
there is already code that explicitly checks argument count.
(JSC::callNumberConstructor): Ditto.
- runtime/ObjectConstructor.cpp:
(JSC::objectConstructorCreate): Small refactoring to not call argument(0)
three times.
- runtime/SetConstructor.cpp:
(JSC::constructSet): Use uncheckedArgument since we are already in a loop
over arguments.
- runtime/StringConstructor.cpp:
(JSC::stringFromCharCodeSlowCase): In a loop.
(JSC::stringFromCharCode): Already checked count.
(JSC::constructWithStringConstructor): Ditto.
(JSC::callStringConstructor): Ditto.
- runtime/StringPrototype.cpp:
(JSC::stringProtoFuncConcat): Already checked count.
- runtime/TestRunnerUtils.cpp:
(JSC::numberOfDFGCompiles): Ditto.
(JSC::setNeverInline): Ditto.
Source/WebCore:
- bindings/js/JSHTMLCanvasElementCustom.cpp:
(WebCore::JSHTMLCanvasElement::probablySupportsContext): Already checked count.
(WebCore::JSHTMLCanvasElement::toDataURL): Ditto.
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::documentWrite): In a loop.
- bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::inspectedObject): Already checked count.
(WebCore::JSInjectedScriptHost::internalConstructorName): Ditto.
(WebCore::JSInjectedScriptHost::isHTMLAllCollection): Ditto.
(WebCore::JSInjectedScriptHost::type): Ditto.
(WebCore::JSInjectedScriptHost::functionDetails): Ditto.
(WebCore::JSInjectedScriptHost::getEventListeners): Ditto.
(WebCore::JSInjectedScriptHost::inspect): Ditto.
(WebCore::JSInjectedScriptHost::databaseId): Ditto.
(WebCore::JSInjectedScriptHost::storageId): Ditto.
- bindings/js/JSSQLTransactionSyncCustom.cpp:
(WebCore::JSSQLTransactionSync::executeSql): Ditto.
- bindings/js/JSSVGLengthCustom.cpp:
(WebCore::JSSVGLength::convertToSpecifiedUnits): Ditto.
- bindings/js/JSSharedWorkerCustom.cpp:
(WebCore::JSSharedWorkerConstructor::constructJSSharedWorker): Ditto.
- bindings/js/JSWebGLRenderingContextCustom.cpp:
(WebCore::getObjectParameter): Already checked count.
(WebCore::JSWebGLRenderingContext::getAttachedShaders): Removed tortured code
to triply do the checking that the toWebGLProgram function already does, including
spurious exception checking in code that can't create an exception. Also count is
already checked.
(WebCore::JSWebGLRenderingContext::getExtension): More of the same.
(WebCore::JSWebGLRenderingContext::getFramebufferAttachmentParameter): Ditto.
(WebCore::JSWebGLRenderingContext::getParameter): Ditto.
(WebCore::JSWebGLRenderingContext::getProgramParameter): Ditto.
(WebCore::JSWebGLRenderingContext::getShaderParameter): Ditto.
(WebCore::JSWebGLRenderingContext::getUniform): Ditto.
(WebCore::dataFunctionf): Ditto.
(WebCore::dataFunctioni): Ditto.
(WebCore::dataFunctionMatrix): Ditto.
- bindings/js/JSWorkerGlobalScopeCustom.cpp:
(WebCore::JSWorkerGlobalScope::importScripts): In a loop.
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::open): Already checked. Also removed some unneeded
argument count checks.
(WebCore::JSXMLHttpRequest::send): Removed unneeded special case for 0 argument
count that does the same thing as the undefined case, since asking for an
argument past the count yields undefined.
- bindings/js/JSXSLTProcessorCustom.cpp:
(WebCore::JSXSLTProcessor::setParameter): Already checked.
(WebCore::JSXSLTProcessor::getParameter): Already checked.
(WebCore::JSXSLTProcessor::removeParameter): Already checked.
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::ScheduledAction): In a loop.
- bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptArguments): Ditto.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck): Removed some excess argumentCount checks.
Used uncheckedArgument in a few places. More needs to be done, especially for
overloaded functions.
- bridge/c/c_instance.cpp:
(JSC::Bindings::CInstance::invokeMethod): In a loop.
(JSC::Bindings::CInstance::invokeDefaultMethod): Ditto.
- bridge/objc/objc_instance.mm:
(ObjcInstance::invokeObjcMethod): Ditto.
(ObjcInstance::invokeDefaultMethod): Ditto.
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
Updated.
Source/WebKit2:
- WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::callMethod): In a loop.
(WebKit::JSNPObject::callObject): Ditto.
(WebKit::JSNPObject::callConstructor): Ditto.
- 8:48 PM Changeset in webkit [156239] by
-
- 3 edits in trunk/Source/JavaScriptCore
Remove the notion that a CallFrame can have a pointer to an InlineCallFrame, since that doesn't happen anymore
https://bugs.webkit.org/show_bug.cgi?id=121753
Reviewed by Darin Adler.
- interpreter/CallFrame.cpp:
(JSC::CallFrame::bytecodeOffsetFromCodeOriginIndex):
- interpreter/CallFrame.h:
- interpreter/Register.h:
- 5:31 PM Changeset in webkit [156238] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, fix the revert.
- dfg/DFGRepatch.cpp:
- 5:24 PM Changeset in webkit [156237] by
-
- 29 edits4 adds7 deletes in trunk/Source/JavaScriptCore
Unreviewed, revert http://trac.webkit.org/changeset/156235. It won't work on Windows.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CallLinkInfo.cpp:
(JSC::CallLinkInfo::unlink):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetStubInternal):
- bytecode/StructureStubInfo.h:
- dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
(JSC::DFG::CallArrayAllocatorSlowPathGenerator::CallArrayAllocatorSlowPathGenerator):
(JSC::DFG::CallArrayAllocatorWithVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableSizeSlowPathGenerator):
- dfg/DFGJITCompiler.h:
- dfg/DFGOSRExitCompiler.h:
- dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
- dfg/DFGOperations.h:
(JSC::DFG::operationNewTypedArrayWithSizeForType):
(JSC::DFG::operationNewTypedArrayWithOneArgumentForType):
- dfg/DFGRegisterSet.h: Added.
(JSC::DFG::RegisterSet::RegisterSet):
(JSC::DFG::RegisterSet::asPOD):
(JSC::DFG::RegisterSet::copyInfo):
(JSC::DFG::RegisterSet::set):
(JSC::DFG::RegisterSet::setGPRByIndex):
(JSC::DFG::RegisterSet::clear):
(JSC::DFG::RegisterSet::get):
(JSC::DFG::RegisterSet::getGPRByIndex):
(JSC::DFG::RegisterSet::getFreeGPR):
(JSC::DFG::RegisterSet::setFPRByIndex):
(JSC::DFG::RegisterSet::getFPRByIndex):
(JSC::DFG::RegisterSet::setByIndex):
(JSC::DFG::RegisterSet::getByIndex):
(JSC::DFG::RegisterSet::numberOfSetGPRs):
(JSC::DFG::RegisterSet::numberOfSetFPRs):
(JSC::DFG::RegisterSet::numberOfSetRegisters):
(JSC::DFG::RegisterSet::setBit):
(JSC::DFG::RegisterSet::clearBit):
(JSC::DFG::RegisterSet::getBit):
- dfg/DFGRepatch.cpp: Added.
(JSC::DFG::repatchCall):
(JSC::DFG::repatchByIdSelfAccess):
(JSC::DFG::addStructureTransitionCheck):
(JSC::DFG::replaceWithJump):
(JSC::DFG::emitRestoreScratch):
(JSC::DFG::linkRestoreScratch):
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryCacheGetByID):
(JSC::DFG::repatchGetByID):
(JSC::DFG::getPolymorphicStructureList):
(JSC::DFG::patchJumpToGetByIdStub):
(JSC::DFG::tryBuildGetByIDList):
(JSC::DFG::buildGetByIDList):
(JSC::DFG::appropriateGenericPutByIdFunction):
(JSC::DFG::appropriateListBuildingPutByIdFunction):
(JSC::DFG::emitPutReplaceStub):
(JSC::DFG::emitPutTransitionStub):
(JSC::DFG::tryCachePutByID):
(JSC::DFG::repatchPutByID):
(JSC::DFG::tryBuildPutByIdList):
(JSC::DFG::buildPutByIdList):
(JSC::DFG::tryRepatchIn):
(JSC::DFG::repatchIn):
(JSC::DFG::linkSlowFor):
(JSC::DFG::linkFor):
(JSC::DFG::linkClosureCall):
(JSC::DFG::resetGetByID):
(JSC::DFG::resetPutByID):
(JSC::DFG::resetIn):
- dfg/DFGRepatch.h: Added.
(JSC::DFG::resetGetByID):
(JSC::DFG::resetPutByID):
(JSC::DFG::resetIn):
- dfg/DFGScratchRegisterAllocator.h: Added.
(JSC::DFG::ScratchRegisterAllocator::ScratchRegisterAllocator):
(JSC::DFG::ScratchRegisterAllocator::lock):
(JSC::DFG::ScratchRegisterAllocator::allocateScratch):
(JSC::DFG::ScratchRegisterAllocator::allocateScratchGPR):
(JSC::DFG::ScratchRegisterAllocator::allocateScratchFPR):
(JSC::DFG::ScratchRegisterAllocator::didReuseRegisters):
(JSC::DFG::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::DFG::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
(JSC::DFG::ScratchRegisterAllocator::desiredScratchBufferSize):
(JSC::DFG::ScratchRegisterAllocator::preserveUsedRegistersToScratchBuffer):
(JSC::DFG::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBuffer):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::writeBarrier):
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGThunks.cpp:
(JSC::DFG::emitPointerValidation):
(JSC::DFG::throwExceptionFromCallSlowPathGenerator):
(JSC::DFG::slowPathFor):
(JSC::DFG::linkForThunkGenerator):
(JSC::DFG::linkCallThunkGenerator):
(JSC::DFG::linkConstructThunkGenerator):
(JSC::DFG::linkClosureCallThunkGenerator):
(JSC::DFG::virtualForThunkGenerator):
(JSC::DFG::virtualCallThunkGenerator):
(JSC::DFG::virtualConstructThunkGenerator):
- dfg/DFGThunks.h:
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
- ftl/FTLOSRExitCompiler.h:
- jit/AssemblyHelpers.h:
- jit/JIT.cpp:
(JSC::JIT::linkFor):
(JSC::JIT::linkSlowCall):
- jit/JITCall.cpp:
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):
- jit/JITOperationWrappers.h: Removed.
- jit/JITOperations.cpp: Removed.
- jit/JITOperations.h: Removed.
- jit/RegisterSet.h: Removed.
- jit/Repatch.cpp: Removed.
- jit/Repatch.h: Removed.
- jit/ScratchRegisterAllocator.h: Removed.
- jit/ThunkGenerators.cpp:
(JSC::generateSlowCaseFor):
(JSC::linkForGenerator):
(JSC::linkCallGenerator):
(JSC::linkConstructGenerator):
(JSC::linkClosureCallGenerator):
(JSC::virtualForGenerator):
(JSC::virtualCallGenerator):
(JSC::virtualConstructGenerator):
- jit/ThunkGenerators.h:
- 5:11 PM Changeset in webkit [156236] by
-
- 2 edits in trunk/Source/WebCore
Fix Obj-C bindings test expectations.
Unreviewed.
Bindings tests failed with r156232, from https://bugs.webkit.org/show_bug.cgi?id=121745.
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj reflectedStringAttr]): Update test expectations.
- 4:10 PM Changeset in webkit [156235] by
-
- 29 edits7 adds4 deletes in trunk/Source/JavaScriptCore
Move DFG inline caching logic into jit/
https://bugs.webkit.org/show_bug.cgi?id=121749
Rubber stamped by Sam Weinig.
We want to get rid of the baseline JIT's inline caching machinery and have it use the
DFG's instead. But before we do that we need to move the DFG's inline caching machine
out from behind its ENABLE(DFG_JIT) guards and make it available to the whole system.
This patch does that:
- dfg/DFGRepatch becomes jit/Repatch.
- The thunks used by the DFG IC go into jit/ThunkGenerators, instead of dfg/DFGThunks.
- The operations used by the DFG IC go into jit/JITOperations, instead of dfg/DFGOperations.
- The old JIT's thunk generators for calls are renamed to reduce confusion. Previously it was easy to know which generators belong to which JIT because the old JIT used JSC::virtualCallBlah and the DFG used JSC::DFG::virtualCallBlah, but that's not the case anymore. Note that the old JIT's thunk generators will die in a future patch.
No functional changes beyond those moves.
- CMakeLists.txt:
- GNUmakefile.list.am:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Target.pri:
- bytecode/CallLinkInfo.cpp:
(JSC::CallLinkInfo::unlink):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::resetStubInternal):
- bytecode/StructureStubInfo.h:
- dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
(JSC::DFG::CallArrayAllocatorSlowPathGenerator::CallArrayAllocatorSlowPathGenerator):
(JSC::DFG::CallArrayAllocatorWithVariableSizeSlowPathGenerator::CallArrayAllocatorWithVariableSizeSlowPathGenerator):
- dfg/DFGJITCompiler.h:
- dfg/DFGOSRExitCompiler.h:
- dfg/DFGOperations.cpp:
(JSC::DFG::operationPutByValInternal):
- dfg/DFGOperations.h:
(JSC::DFG::operationNewTypedArrayWithSizeForType):
(JSC::DFG::operationNewTypedArrayWithOneArgumentForType):
- dfg/DFGRegisterSet.h: Removed.
- dfg/DFGRepatch.cpp: Removed.
- dfg/DFGRepatch.h: Removed.
- dfg/DFGScratchRegisterAllocator.h: Removed.
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::nonSpeculativeCompare):
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::cachedPutById):
(JSC::DFG::SpeculativeJIT::nonSpeculativePeepholeBranch):
(JSC::DFG::CompareAndBoxBooleanSlowPathGenerator::CompareAndBoxBooleanSlowPathGenerator):
(JSC::DFG::SpeculativeJIT::nonSpeculativeNonPeepholeCompare):
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGThunks.cpp:
- dfg/DFGThunks.h:
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::writeBarrier):
- jit/JIT.cpp:
(JSC::JIT::linkFor):
(JSC::JIT::linkSlowCall):
- jit/JITCall.cpp:
(JSC::JIT::compileCallEval):
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileCallEvalSlowCase):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::privateCompileClosureCall):
- jit/JITOperationWrappers.h: Added.
- jit/JITOperations.cpp: Added.
- jit/JITOperations.h: Added.
- jit/RegisterSet.h: Added.
(JSC::RegisterSet::RegisterSet):
(JSC::RegisterSet::asPOD):
(JSC::RegisterSet::copyInfo):
(JSC::RegisterSet::set):
(JSC::RegisterSet::setGPRByIndex):
(JSC::RegisterSet::clear):
(JSC::RegisterSet::get):
(JSC::RegisterSet::getGPRByIndex):
(JSC::RegisterSet::getFreeGPR):
(JSC::RegisterSet::setFPRByIndex):
(JSC::RegisterSet::getFPRByIndex):
(JSC::RegisterSet::setByIndex):
(JSC::RegisterSet::getByIndex):
(JSC::RegisterSet::numberOfSetGPRs):
(JSC::RegisterSet::numberOfSetFPRs):
(JSC::RegisterSet::numberOfSetRegisters):
(JSC::RegisterSet::setBit):
(JSC::RegisterSet::clearBit):
(JSC::RegisterSet::getBit):
- jit/Repatch.cpp: Added.
(JSC::repatchCall):
(JSC::repatchByIdSelfAccess):
(JSC::addStructureTransitionCheck):
(JSC::replaceWithJump):
(JSC::emitRestoreScratch):
(JSC::linkRestoreScratch):
(JSC::generateProtoChainAccessStub):
(JSC::tryCacheGetByID):
(JSC::repatchGetByID):
(JSC::getPolymorphicStructureList):
(JSC::patchJumpToGetByIdStub):
(JSC::tryBuildGetByIDList):
(JSC::buildGetByIDList):
(JSC::appropriateGenericPutByIdFunction):
(JSC::appropriateListBuildingPutByIdFunction):
(JSC::emitPutReplaceStub):
(JSC::emitPutTransitionStub):
(JSC::tryCachePutByID):
(JSC::repatchPutByID):
(JSC::tryBuildPutByIdList):
(JSC::buildPutByIdList):
(JSC::tryRepatchIn):
(JSC::repatchIn):
(JSC::linkSlowFor):
(JSC::linkFor):
(JSC::linkClosureCall):
(JSC::resetGetByID):
(JSC::resetPutByID):
(JSC::resetIn):
- jit/Repatch.h: Added.
(JSC::resetGetByID):
(JSC::resetPutByID):
(JSC::resetIn):
- jit/ScratchRegisterAllocator.h: Added.
(JSC::ScratchRegisterAllocator::ScratchRegisterAllocator):
(JSC::ScratchRegisterAllocator::lock):
(JSC::ScratchRegisterAllocator::allocateScratch):
(JSC::ScratchRegisterAllocator::allocateScratchGPR):
(JSC::ScratchRegisterAllocator::allocateScratchFPR):
(JSC::ScratchRegisterAllocator::didReuseRegisters):
(JSC::ScratchRegisterAllocator::preserveReusedRegistersByPushing):
(JSC::ScratchRegisterAllocator::restoreReusedRegistersByPopping):
(JSC::ScratchRegisterAllocator::desiredScratchBufferSize):
(JSC::ScratchRegisterAllocator::preserveUsedRegistersToScratchBuffer):
(JSC::ScratchRegisterAllocator::restoreUsedRegistersFromScratchBuffer):
- jit/ThunkGenerators.cpp:
(JSC::oldStyleGenerateSlowCaseFor):
(JSC::oldStyleLinkForGenerator):
(JSC::oldStyleLinkCallGenerator):
(JSC::oldStyleLinkConstructGenerator):
(JSC::oldStyleLinkClosureCallGenerator):
(JSC::oldStyleVirtualForGenerator):
(JSC::oldStyleVirtualCallGenerator):
(JSC::oldStyleVirtualConstructGenerator):
(JSC::emitPointerValidation):
(JSC::throwExceptionFromCallSlowPathGenerator):
(JSC::slowPathFor):
(JSC::linkForThunkGenerator):
(JSC::linkCallThunkGenerator):
(JSC::linkConstructThunkGenerator):
(JSC::linkClosureCallThunkGenerator):
(JSC::virtualForThunkGenerator):
(JSC::virtualCallThunkGenerator):
(JSC::virtualConstructThunkGenerator):
- jit/ThunkGenerators.h:
- 1:02 PM Changeset in webkit [156234] by
-
- 5 edits in trunk/Source/WebCore
Node: FINAL-ize EventTarget overrides.
<https://webkit.org/b/121748>
Reviewed by Darin Adler.
Mark the following Node functions FINAL:
- scriptExecutionContext()
- eventTargetData()
- ensureEventTargetData()
This devirtualizes a myriad of generated calls in the JSC bindings.
- 12:05 PM Changeset in webkit [156233] by
-
- 3 edits in trunk/Source/JavaScriptCore
Fix the non-DFG build.
- interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
- interpreter/StackVisitor.cpp:
(JSC::StackVisitor::Frame::r):
- 11:46 AM Changeset in webkit [156232] by
-
- 2 edits in trunk/Source/WebCore
Don't bloat Obj-C bindings with inlined attribute retrieval.
<https://webkit.org/b/121745>
Reviewed by Anders Carlsson.
Hack bindings generator to always use getAttribute() for Objective-C.
Reduces WebCore binary size by 25120 bytes.
- 11:25 AM Changeset in webkit [156231] by
-
- 38 edits2 deletes in trunk/Source/WebCore
Shink attribute event listener code
https://bugs.webkit.org/show_bug.cgi?id=121735
Reviewed by Antti Koivisto.
- GNUmakefile.list.am: Eliminate ScriptEventListener source files.
- Target.pri: Ditto.
- UseJSC.cmake: Ditto.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- bindings/js/JSBindingsAllInOne.cpp: Ditto.
- bindings/js/JSDOMGlobalObject.h: Removed unneeded forward declarations
of JSEventListener and JSLazyEventListener.
- bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::JSLazyEventListener): Changed type to
ContainerNode because the node pointer is only ever used for elements
and documents.
(WebCore::eventParameterName): Moved this function here from
ScriptEventListener.cpp, but also rewrote to use NeverDestroyed.
(WebCore::JSLazyEventListener::createForNode): Moved this function
here from ScriptEventListener.cpp, cleaned up a bit.
(WebCore::JSLazyEventListener::createForDOMWindow): Ditto.
- bindings/js/JSLazyEventListener.h: Replaced the old create function
with two new create functions we can use directly. Also used some
OVERRIDE, some FINAL, and a bit of WTF_DELETED_FUNCTION so we don't
accidentally call create and create a non-lazy listener.
- bindings/js/ScriptEventListener.cpp: Removed.
- bindings/js/ScriptEventListener.h: Removed.
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::setAttributeEventListener): Added.
Calls JSLazyEventListener::createForNode and then calls the other
overload of setAttributeEventListener, to obviate having more code
at the call site.
- dom/ContainerNode.h: Added overload of setAttributeEventListener
for convenient use in Document and Element implementations.
- dom/Document.cpp:
(WebCore::Document::prepareForDestruction): Use m_domWindow instead
of the domWindow() function.
(WebCore::Document::removeAllEventListeners): Ditto.
(WebCore::Document::errorEventTarget): Ditto.
(WebCore::Document::takeDOMWindowFrom): Ditto.
(WebCore::Document::setWindowAttributeEventListener): Ditto. Also
added an overload that calls JSLazyEventListener::createForDOMWindow.
(WebCore::Document::getWindowAttributeEventListener): Use m_domWindow.
(WebCore::Document::dispatchWindowEvent): Ditto.
(WebCore::Document::dispatchWindowLoadEvent): Ditto.
(WebCore::Document::enqueueWindowEvent): Ditto.
(WebCore::Document::enqueuePopstateEvent): Ditto.
- dom/Document.h: Added overload of setWindowAttributeEventListener.
- html/HTMLBodyElement.cpp: Removed unnneded include.
(WebCore::HTMLBodyElement::parseAttribute): Removed all the calls to
createAttributeEventListener, and use the setAttributeEventListener
overloads instead.
- html/HTMLButtonElement.cpp: Ditto.
- html/HTMLElement.cpp:
(WebCore::HTMLElement::parseAttribute): Ditto.
- html/HTMLFormControlElement.cpp: Ditto.
- html/HTMLFormElement.cpp: Ditto.
- html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseAttribute): Ditto.
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::parseAttribute): Ditto.
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseAttribute): Ditto.
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::parseAttribute): Ditto.
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::parseAttribute): Ditto.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute): Ditto.
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseAttribute): Ditto.
- html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::parseAttribute): Ditto.
- html/HTMLSelectElement.cpp: Ditto.
- html/HTMLStyleElement.cpp: Ditto.
- html/HTMLTextFormControlElement.cpp: Ditto.
- html/HTMLTrackElement.cpp: Ditto.
- html/track/LoadableTextTrack.cpp: Ditto.
- svg/SVGElement.cpp:
(WebCore::SVGElement::parseAttribute): Ditto.
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::parseAttribute): Ditto.
- svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::parseAttribute): Ditto.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForEventListener):
Moved the code here to dig inside a JSEventListener for things like
the source location. This used to be spread across multiple function
calls in ScriptEventListener.h, which were doing and redoing the same
things, so better to just get it all at once.
- html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::init): Fixed "minium" typo.
- 10:47 AM Changeset in webkit [156230] by
-
- 3 edits in trunk/Source/WebCore
Don't store the "processing-instruction" string for PI tokens in the XPath parser
https://bugs.webkit.org/show_bug.cgi?id=121746
Reviewed by Antti Koivisto.
For PI tokens, the string is always going to be "processing-instruction", and it's never used so we don't need to save it.
- xml/XPathGrammar.y:
- xml/XPathParser.cpp:
(Parser::nextTokenInternal):
(Parser::lex):
- 10:40 AM Changeset in webkit [156229] by
-
- 8 edits3 adds in trunk
Get rid of IsInlinedCodeTag and its associated methods since it's unused
https://bugs.webkit.org/show_bug.cgi?id=121737
Source/JavaScriptCore:
Reviewed by Sam Weinig.
This was meant to be easy, but I kept wondering if it was safe to remove the
inline call frame check in Arguments::tearOff(). The check was clearly dead
since the bit wasn't being set anywhere.
It turns out that the unwindCallFrame() function was relying on tearOff()
doing the right thing for inlined code, but it wasn't even passing it an
inline call frame. I fixed this by having unwindCallFrame() inlining check,
while also making sure that the code uses the right operand index for the
arguments register.
- interpreter/CallFrame.h:
- interpreter/CallFrameInlines.h:
- interpreter/Interpreter.cpp:
(JSC::unwindCallFrame):
- interpreter/StackVisitor.cpp:
(JSC::StackVisitor::Frame::r):
- interpreter/StackVisitor.h:
- runtime/Arguments.cpp:
(JSC::Arguments::tearOff):
LayoutTests:
Reviewed by Sam Weinig.
- js/dfg-inline-arguments-capture-throw-exception-expected.txt: Added.
- js/dfg-inline-arguments-capture-throw-exception.html: Added.
- js/script-tests/dfg-inline-arguments-capture-throw-exception.js: Added.
(foo):
(bar):
(makeF):
(recurse):
- 6:45 AM Changeset in webkit [156228] by
-
- 2 edits in trunk/Source/WebCore
Handle windows lineendings in makeprop.pl after r155511
https://bugs.webkit.org/show_bug.cgi?id=121740
Reviewed by Ryosuke Niwa.
Check for an optinal \r at the end of a line in regular expressions
to make it work again on native windows machines which use CRLF.
- css/makeprop.pl:
- 6:05 AM Changeset in webkit [156227] by
-
- 3 edits in trunk/Source/WebCore
Re-inline some hot ElementData functions.
<https://webkit.org/b/121743>
Reviewed by Antti Koivisto.
Make the following functions inline again:
- deref()
- addAttribute()
- removeAttribute()
- attributeAt()
They were out-of-lined in r154249 and perf.webkit.org reports a 1.4%
regression on the html5 spec for that revision. This'll hopefully steer
the graph back in the right direction.
- 3:52 AM Changeset in webkit [156226] by
-
- 13 edits2 moves in trunk/Source/WebCore
GeneratorGeneratedImage should be called GradientImage
https://bugs.webkit.org/show_bug.cgi?id=121085
Reviewed by Simon Fraser.
No new tests, just a refactor.
r150053 removed the concept of a Generator, making GeneratorGeneratedImage
take a Gradient. This leaves GeneratorGeneratedImage's name not making a
whole lot of sense, so let's rename it to GradientImage.
- CMakeLists.txt:
- GNUmakefile.list.am:
- Target.pri:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image):
- platform/graphics/BitmapImage.h:
- platform/graphics/GradientImage.cpp: Renamed from Source/WebCore/platform/graphics/GeneratorGeneratedImage.cpp.
(WebCore::GradientImage::draw):
(WebCore::GradientImage::drawPattern):
- platform/graphics/GradientImage.h: Renamed from Source/WebCore/platform/graphics/GeneratorGeneratedImage.h.
- platform/graphics/Image.h:
- platform/graphics/ImageBuffer.h:
Rename.
- css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::cachedImageForSize):
(WebCore::CSSImageGeneratorValue::saveCachedImageForSize):
(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::CachedGeneratedImage):
- css/CSSImageGeneratorValue.h:
(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::image):
Drive-by, the CSSImageGeneratorValue generated image cache should be
in terms of GeneratedImage, not a random subclass, regardless
of the fact that it's only used for GradientImage as of yet.
- 1:03 AM Changeset in webkit [156225] by
-
- 2 edits in trunk/Source/WebCore
Shrink valueForBasicShape by removing repeated calls to cssValuePool()
https://bugs.webkit.org/show_bug.cgi?id=121736
Reviewed by Sam Weinig.
- css/BasicShapeFunctions.cpp:
(WebCore::valueForBasicShape): Put the pool into a local variable and use that.
