Timeline



Nov 9, 2013:

11:28 PM Changeset in webkit [159018] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

CSSValuePool::createFontFamilyValue() should return PassRef.
<https://webkit.org/b/124114>

Unlike createFontFaceValue(), createFontFamilyValue() can never
fail to return an object and thus should return PassRef.

Reviewed by Anders Carlsson.

11:26 PM Changeset in webkit [159017] by akling@apple.com
  • 371 edits in trunk

RenderIFrame should display its name correctly in DRT output.
<https://webkit.org/b/124117>

Source/WebCore:

Nuke an age-old FIXME about making RenderIFrame show its true name
in DRT output. No more "RenderPartObject {IFRAME}"!

Reviewed by Anders Carlsson.

LayoutTests:

Rebaseline results now that RenderIFrame correctly dumps its name
as "RenderIFrame".

Reviewed by Anders Carlsson.

  • compositing/iframes/composited-iframe-scroll-expected.txt:
  • compositing/iframes/iframe-content-flipping-expected.txt:
  • compositing/iframes/nested-iframe-scrolling-expected.txt:
  • fast/css/replaced-element-implicit-size-expected.txt:
  • fast/css/resize-corner-tracking-expected.txt:
  • fast/dom/attr_dead_doc-expected.txt:
  • fast/frames/content-opacity-1-expected.txt:
  • fast/frames/content-opacity-2-expected.txt:
  • fast/frames/iframe-scaling-with-scroll-expected.txt:
  • fast/frames/iframe-text-contents-expected.txt:
  • fast/frames/paint-iframe-background-expected.txt:
  • fast/repaint/4774354-expected.txt:
  • fast/repaint/iframe-scroll-repaint-expected.txt:
  • fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
  • fast/replaced/percent-height-in-anonymous-block-expected.txt:
  • http/tests/misc/acid3-expected.txt:
  • media/media-document-audio-repaint-expected.txt:
  • platform/efl/compositing/iframes/composited-iframe-alignment-expected.txt:
  • platform/efl/compositing/iframes/iframe-copy-on-scroll-expected.txt:
  • platform/efl/compositing/iframes/iframe-in-composited-layer-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-004-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-005-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-007-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-011-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-012-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-014-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-018-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-019-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-021-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-025-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-026-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-028-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-032-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-033-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-035-expected.txt:
  • platform/efl/css2.1/20110323/block-replaced-height-004-expected.txt:
  • platform/efl/css2.1/20110323/block-replaced-height-005-expected.txt:
  • platform/efl/css2.1/20110323/block-replaced-height-007-expected.txt:
  • platform/efl/css2.1/20110323/float-replaced-height-004-expected.txt:
  • platform/efl/css2.1/20110323/float-replaced-height-005-expected.txt:
  • platform/efl/css2.1/20110323/float-replaced-height-007-expected.txt:
  • platform/efl/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
  • platform/efl/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
  • platform/efl/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
  • platform/efl/css2.1/20110323/inline-replaced-height-004-expected.txt:
  • platform/efl/css2.1/20110323/inline-replaced-height-005-expected.txt:
  • platform/efl/css2.1/20110323/inline-replaced-height-007-expected.txt:
  • platform/efl/editing/pasteboard/4631972-expected.txt:
  • platform/efl/editing/selection/4776665-expected.txt:
  • platform/efl/editing/selection/4960137-expected.txt:
  • platform/efl/editing/selection/4975120-expected.txt:
  • platform/efl/editing/selection/drag-in-iframe-expected.txt:
  • platform/efl/editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • platform/efl/editing/selection/iframe-expected.txt:
  • platform/efl/editing/selection/select-all-iframe-expected.txt:
  • platform/efl/fast/block/basic/013-expected.txt:
  • platform/efl/fast/block/positioning/window-height-change-expected.txt:
  • platform/efl/fast/css/line-height-overflow-expected.txt:
  • platform/efl/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt:
  • platform/efl/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
  • platform/efl/fast/flexbox/016-expected.txt:
  • platform/efl/fast/forms/basic-textareas-expected.txt:
  • platform/efl/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/efl/fast/forms/targeted-frame-submission-expected.txt:
  • platform/efl/fast/frames/001-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-nested-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-simple-expected.txt:
  • platform/efl/fast/frames/frameElement-iframe-expected.txt:
  • platform/efl/fast/frames/iframe-option-crash-expected.txt:
  • platform/efl/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/efl/fast/frames/iframe-with-frameborder-expected.txt:
  • platform/efl/fast/frames/onlyCommentInIFrame-expected.txt:
  • platform/efl/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/efl/fast/frames/viewsource-attribute-expected.txt:
  • platform/efl/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/efl/fast/images/favicon-as-image-expected.txt:
  • platform/efl/fast/overflow/scrollRevealButton-expected.txt:
  • platform/efl/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/efl/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
  • platform/efl/fast/replaced/007-expected.txt:
  • platform/efl/fast/replaced/border-radius-clip-expected.txt:
  • platform/efl/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
  • platform/efl/fast/replaced/replaced-breaking-expected.txt:
  • platform/efl/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
  • platform/efl/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt:
  • platform/efl/fast/table/quote-text-around-iframe-expected.txt:
  • platform/efl/fast/text/selection-hard-linebreak-expected.txt:
  • platform/efl/http/tests/loading/simple-subframe-expected.txt:
  • platform/efl/http/tests/local/file-url-sent-as-referer-expected.txt:
  • platform/efl/http/tests/misc/acid3-expected.txt:
  • platform/efl/http/tests/misc/favicon-as-image-expected.txt:
  • platform/efl/http/tests/misc/frame-access-during-load-expected.txt:
  • platform/efl/http/tests/misc/iframe404-expected.txt:
  • platform/efl/http/tests/misc/location-replace-crossdomain-expected.txt:
  • platform/efl/http/tests/multipart/invalid-image-data-standalone-expected.txt:
  • platform/efl/media/media-document-audio-repaint-expected.txt:
  • platform/efl/svg/hixie/rendering-model/003-expected.txt:
  • platform/efl/svg/in-html/by-reference-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug38916-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt:
  • platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-004-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-005-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-007-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-011-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-012-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-014-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-018-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-019-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-021-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-025-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-026-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-028-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-032-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-033-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-035-expected.txt:
  • platform/gtk/css2.1/20110323/block-replaced-height-004-expected.txt:
  • platform/gtk/css2.1/20110323/block-replaced-height-005-expected.txt:
  • platform/gtk/css2.1/20110323/block-replaced-height-007-expected.txt:
  • platform/gtk/css2.1/20110323/float-replaced-height-004-expected.txt:
  • platform/gtk/css2.1/20110323/float-replaced-height-005-expected.txt:
  • platform/gtk/css2.1/20110323/float-replaced-height-007-expected.txt:
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
  • platform/gtk/css2.1/20110323/inline-replaced-height-004-expected.txt:
  • platform/gtk/css2.1/20110323/inline-replaced-height-005-expected.txt:
  • platform/gtk/css2.1/20110323/inline-replaced-height-007-expected.txt:
  • platform/gtk/editing/execCommand/find-after-replace-expected.txt:
  • platform/gtk/editing/execCommand/paste-1-expected.txt:
  • platform/gtk/editing/pasteboard/4631972-expected.txt:
  • platform/gtk/editing/pasteboard/copy-standalone-image-expected.txt:
  • platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
  • platform/gtk/editing/pasteboard/paste-2-expected.txt:
  • platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/gtk/editing/selection/4776665-expected.txt:
  • platform/gtk/editing/selection/4960137-expected.txt:
  • platform/gtk/editing/selection/4975120-expected.txt:
  • platform/gtk/editing/selection/drag-in-iframe-expected.txt:
  • platform/gtk/editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • platform/gtk/editing/selection/iframe-expected.txt:
  • platform/gtk/editing/selection/select-all-iframe-expected.txt:
  • platform/gtk/fast/block/basic/013-expected.txt:
  • platform/gtk/fast/block/positioning/window-height-change-expected.txt:
  • platform/gtk/fast/css/line-height-overflow-expected.txt:
  • platform/gtk/fast/css/resize-corner-tracking-expected.txt:
  • platform/gtk/fast/css/resize-corner-tracking-transformed-iframe-expected.txt:
  • platform/gtk/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt:
  • platform/gtk/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
  • platform/gtk/fast/flexbox/016-expected.txt:
  • platform/gtk/fast/forms/basic-textareas-expected.txt:
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/gtk/fast/forms/targeted-frame-submission-expected.txt:
  • platform/gtk/fast/frames/001-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-simple-expected.txt:
  • platform/gtk/fast/frames/frameElement-iframe-expected.txt:
  • platform/gtk/fast/frames/iframe-option-crash-expected.txt:
  • platform/gtk/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/gtk/fast/frames/iframe-with-frameborder-expected.txt:
  • platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt:
  • platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/frames/viewsource-attribute-expected.txt:
  • platform/gtk/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/gtk/fast/images/favicon-as-image-expected.txt:
  • platform/gtk/fast/overflow/scrollRevealButton-expected.txt:
  • platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/gtk/fast/repaint/iframe-scroll-repaint-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/gtk/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
  • platform/gtk/fast/replaced/007-expected.txt:
  • platform/gtk/fast/replaced/border-radius-clip-expected.txt:
  • platform/gtk/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-expected.txt:
  • platform/gtk/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
  • platform/gtk/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt:
  • platform/gtk/fast/table/quote-text-around-iframe-expected.txt:
  • platform/gtk/fast/text/selection-hard-linebreak-expected.txt:
  • platform/gtk/http/tests/loading/simple-subframe-expected.txt:
  • platform/gtk/http/tests/local/file-url-sent-as-referer-expected.txt:
  • platform/gtk/http/tests/misc/favicon-as-image-expected.txt:
  • platform/gtk/http/tests/misc/frame-access-during-load-expected.txt:
  • platform/gtk/http/tests/misc/iframe404-expected.txt:
  • platform/gtk/http/tests/misc/location-replace-crossdomain-expected.txt:
  • platform/gtk/http/tests/multipart/invalid-image-data-standalone-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
  • platform/gtk/plugins/iframe-plugin-bgcolor-expected.txt:
  • platform/gtk/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
  • platform/gtk/svg/custom/embedding-external-svgs-expected.txt:
  • platform/gtk/svg/hixie/rendering-model/003-expected.txt:
  • platform/gtk/svg/in-html/by-reference-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug38916-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/iphone-simulator/text-autosizing/contenteditable-expected.txt:
  • platform/mac-mountainlion/editing/selection/4975120-expected.txt:
  • platform/mac-mountainlion/fast/forms/basic-textareas-expected.txt:
  • platform/mac-mountainlion/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac-mountainlion/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac-wk2/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/mac/compositing/iframes/composited-iframe-alignment-expected.txt:
  • platform/mac/compositing/iframes/iframe-copy-on-scroll-expected.txt:
  • platform/mac/compositing/iframes/iframe-in-composited-layer-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-004-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-005-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-007-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-011-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-012-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-014-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-018-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-019-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-021-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-025-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-026-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-028-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-032-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-033-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-035-expected.txt:
  • platform/mac/css2.1/20110323/block-replaced-height-004-expected.txt:
  • platform/mac/css2.1/20110323/block-replaced-height-005-expected.txt:
  • platform/mac/css2.1/20110323/block-replaced-height-007-expected.txt:
  • platform/mac/css2.1/20110323/float-replaced-height-004-expected.txt:
  • platform/mac/css2.1/20110323/float-replaced-height-005-expected.txt:
  • platform/mac/css2.1/20110323/float-replaced-height-007-expected.txt:
  • platform/mac/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
  • platform/mac/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
  • platform/mac/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
  • platform/mac/css2.1/20110323/inline-replaced-height-004-expected.txt:
  • platform/mac/css2.1/20110323/inline-replaced-height-005-expected.txt:
  • platform/mac/css2.1/20110323/inline-replaced-height-007-expected.txt:
  • platform/mac/editing/execCommand/find-after-replace-expected.txt:
  • platform/mac/editing/execCommand/paste-1-expected.txt:
  • platform/mac/editing/pasteboard/4631972-expected.txt:
  • platform/mac/editing/pasteboard/copy-standalone-image-expected.txt:
  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
  • platform/mac/editing/pasteboard/paste-2-expected.txt:
  • platform/mac/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/mac/editing/selection/4776665-expected.txt:
  • platform/mac/editing/selection/4960137-expected.txt:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/drag-in-iframe-expected.txt:
  • platform/mac/editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • platform/mac/editing/selection/iframe-expected.txt:
  • platform/mac/editing/selection/select-all-iframe-expected.txt:
  • platform/mac/fast/block/basic/013-expected.txt:
  • platform/mac/fast/block/positioning/window-height-change-expected.txt:
  • platform/mac/fast/css/line-height-overflow-expected.txt:
  • platform/mac/fast/css/resize-corner-tracking-transformed-iframe-expected.txt:
  • platform/mac/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt:
  • platform/mac/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
  • platform/mac/fast/flexbox/016-expected.txt:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/targeted-frame-submission-expected.txt:
  • platform/mac/fast/frames/001-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-nested-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt:
  • platform/mac/fast/frames/frameElement-iframe-expected.txt:
  • platform/mac/fast/frames/iframe-option-crash-expected.txt:
  • platform/mac/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/mac/fast/frames/iframe-with-frameborder-expected.txt:
  • platform/mac/fast/frames/onlyCommentInIFrame-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/frames/viewsource-attribute-expected.txt:
  • platform/mac/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/mac/fast/images/favicon-as-image-expected.txt:
  • platform/mac/fast/overflow/scrollRevealButton-expected.txt:
  • platform/mac/fast/repaint/4774354-expected.txt:
  • platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
  • platform/mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
  • platform/mac/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
  • platform/mac/fast/replaced/007-expected.txt:
  • platform/mac/fast/replaced/border-radius-clip-expected.txt:
  • platform/mac/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
  • platform/mac/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt:
  • platform/mac/fast/table/quote-text-around-iframe-expected.txt:
  • platform/mac/fast/text/selection-hard-linebreak-expected.txt:
  • platform/mac/http/tests/loading/simple-subframe-expected.txt:
  • platform/mac/http/tests/local/file-url-sent-as-referer-expected.txt:
  • platform/mac/http/tests/misc/acid3-expected.txt:
  • platform/mac/http/tests/misc/favicon-as-image-expected.txt:
  • platform/mac/http/tests/misc/frame-access-during-load-expected.txt:
  • platform/mac/http/tests/misc/iframe404-expected.txt:
  • platform/mac/http/tests/misc/location-replace-crossdomain-expected.txt:
  • platform/mac/http/tests/multipart/invalid-image-data-standalone-expected.txt:
  • platform/mac/plugins/update-widget-from-style-recalc-expected.txt:
  • platform/mac/plugins/update-widget-from-style-recalc.html:
  • platform/mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt:
  • platform/mac/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt:
  • platform/mac/svg/custom/embedding-external-svgs-expected.txt:
  • platform/mac/svg/hixie/rendering-model/003-expected.txt:
  • platform/mac/svg/in-html/by-reference-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug38916-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
  • platform/win-xp/media/media-document-audio-repaint-expected.txt:
  • platform/win/http/tests/misc/acid3-expected.txt:
  • plugins/iframe-plugin-bgcolor-expected.txt:
  • printing/iframe-print-expected.txt:
  • scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt:
  • scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt:
  • svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
  • tables/mozilla/bugs/bug137388-1-expected.txt:
  • tables/mozilla/bugs/bug137388-2-expected.txt:
  • tables/mozilla/bugs/bug137388-3-expected.txt:
  • tables/mozilla/bugs/bug50695-2-expected.txt:
10:49 PM Changeset in webkit [159016] by mitz@apple.com
  • 6 edits
    2 adds in trunk/Source/WebKit2

Use createCFURLFromBuffer when converting a String to a CFURL
https://bugs.webkit.org/show_bug.cgi?id=124113

Reviewed by Anders Carlsson.

  • Shared/API/c/cf/WKURLCF.mm:

(WKURLCopyCFURL): Replaced some code with a call to createCFURLFromBuffer(), which does the
same thing.

  • Shared/Cocoa/WKNSURLExtras.h: Added.
  • Shared/Cocoa/WKNSURLExtras.mm: Added.

(+[NSURL _web_URLWithWTFString:relativeToURL:]): Added. Returns nil for the null String,
otherwise returns the result of createCFURLFromBuffer().

  • UIProcess/API/Cocoa/WKBackForwardListItem.mm:

(-[WKBackForwardListItem URL]): Changed to use +_web_URLWithWTFString:relativeToURL:.
(-[WKBackForwardListItem originalURL]): Ditto.

  • UIProcess/API/Cocoa/WKNavigationData.mm:

(-[WKNavigationData destinationURL]): Ditto.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController unreachableURL]): Ditto.

  • WebKit2.xcodeproj/project.pbxproj: Added references to new files.
10:45 PM Changeset in webkit [159015] by akling@apple.com
  • 3 edits
    2 copies
    9 moves
    1 add
    13 deletes in trunk/LayoutTests

Optimize baselines: svg/W3C-SVG-1.1-SE

Unreviewed; run "webkit-patch optimize-baselines svg/W3C-SVG-1.1-SE"

  • platform/efl/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
  • platform/win-future/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt.
  • platform/win-future/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt.
  • svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt.
  • svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.
  • svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt.
  • svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
10:42 PM Changeset in webkit [159014] by akling@apple.com
  • 1 edit
    9 moves
    9 deletes in trunk/LayoutTests

Optimize baselines: svg/carto.net

Unreviewed; run "webkit-patch optimize-baselines svg/carto.net"

  • platform/gtk/svg/carto.net/button-expected.txt: Removed.
  • platform/gtk/svg/carto.net/colourpicker-expected.txt: Removed.
  • platform/gtk/svg/carto.net/combobox-expected.txt: Removed.
  • platform/gtk/svg/carto.net/scrollbar-expected.txt: Removed.
  • platform/gtk/svg/carto.net/selectionlist-expected.txt: Removed.
  • platform/gtk/svg/carto.net/slider-expected.txt: Removed.
  • platform/gtk/svg/carto.net/tabgroup-expected.txt: Removed.
  • platform/gtk/svg/carto.net/textbox-expected.txt: Removed.
  • platform/gtk/svg/carto.net/window-expected.txt: Removed.
  • svg/carto.net/button-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/button-expected.txt.
  • svg/carto.net/colourpicker-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/colourpicker-expected.txt.
  • svg/carto.net/combobox-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/combobox-expected.txt.
  • svg/carto.net/scrollbar-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/scrollbar-expected.txt.
  • svg/carto.net/selectionlist-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/selectionlist-expected.txt.
  • svg/carto.net/slider-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/slider-expected.txt.
  • svg/carto.net/tabgroup-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/tabgroup-expected.txt.
  • svg/carto.net/textbox-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/textbox-expected.txt.
  • svg/carto.net/window-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/window-expected.txt.
10:39 PM Changeset in webkit [159013] by akling@apple.com
  • 1 edit
    10 moves
    10 deletes in trunk/LayoutTests

Optimize baselines: svg/css

Unreviewed; run "webkit-patch optimize-baselines svg/css"

  • platform/gtk/svg/css/circle-in-mask-with-shadow-expected.png: Removed.
  • platform/gtk/svg/css/clippath-with-shadow-expected.png: Removed.
  • platform/gtk/svg/css/group-with-shadow-expected.txt: Removed.
  • platform/gtk/svg/css/path-with-shadow-expected.png: Removed.
  • platform/gtk/svg/css/shadow-with-large-radius-expected.png: Removed.
  • platform/gtk/svg/css/shadow-with-negative-offset-expected.png: Removed.
  • platform/gtk/svg/css/stars-with-shadow-expected.txt: Removed.
  • platform/gtk/svg/css/text-gradient-shadow-expected.txt: Removed.
  • platform/mac/svg/css/composite-shadow-example-expected.txt: Removed.
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
  • svg/css/circle-in-mask-with-shadow-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/circle-in-mask-with-shadow-expected.png.
  • svg/css/clippath-with-shadow-expected.png: Renamed from LayoutTests/platform/efl/svg/css/clippath-with-shadow-expected.png.
  • svg/css/composite-shadow-example-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/composite-shadow-example-expected.txt.
  • svg/css/composite-shadow-with-opacity-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/composite-shadow-with-opacity-expected.txt.
  • svg/css/group-with-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/group-with-shadow-expected.txt.
  • svg/css/path-with-shadow-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/path-with-shadow-expected.png.
  • svg/css/shadow-with-large-radius-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/shadow-with-large-radius-expected.png.
  • svg/css/shadow-with-negative-offset-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/shadow-with-negative-offset-expected.png.
  • svg/css/stars-with-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/stars-with-shadow-expected.txt.
  • svg/css/text-gradient-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/text-gradient-shadow-expected.txt.
10:37 PM Changeset in webkit [159012] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

SVGTextMetricsBuilder::walkTree() should take a RenderElement.
<https://webkit.org/b/124105>

Make walkTree() take a RenderElement so we can use the non-virtual
firstChild() internally. All call sites had pointers to compatible
objects already.

Reviewed by Anders Carlsson.

9:48 PM Changeset in webkit [159011] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

RenderMathMLFenced should pass around operators in tighter types.
<https://webkit.org/b/124115>

Store operator renderers in RenderMathMLOperator pointers instead
of passing them around as RenderObject.

Reviewed by Martin Robinson.

9:47 PM Changeset in webkit [159010] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

Use RENDER_OBJECT_TYPE_CASTS for more types.
<https://webkit.org/b/124112>

Generate toRenderFoo() type casting helpers for these classes:

  • RenderCombineText
  • RenderDetailsMarker
  • RenderListMarker
  • RenderVideo
  • RenderView

Reviewed by Anders Carlsson.

9:08 PM Changeset in webkit [159009] by akling@apple.com
  • 13 edits in trunk/Source/WebCore

Move MathML type checking virtuals to RenderObject.
<https://webkit.org/b/124111>

Previously, checking the type of a MathML renderer would require
that you first check if it's a RenderMathMLBlock, and then casting
to that type to access the check you really wanted.

This change moves all the isRenderMathMLFoo() virtual functions
to RenderObject. I also made sure all the overloads were private
and marked them OVERRIDE/FINAL as appropriate.

Finally I replaced all the hand-written casting functions with
autogenerated ones using RENDER_OBJECT_TYPE_CASTS.

Reviewed by Anders Carlsson.

8:20 PM Changeset in webkit [159008] by oliver@apple.com
  • 12 edits
    3 moves
    6 adds in trunk

Add Map Iterators
https://bugs.webkit.org/show_bug.cgi?id=124109

Reviewed by Andreas Kling.

Source/JavaScriptCore:

Added new Map iterator implementation. This is a mostly boilerplate patch
however there's a a little bit of additional logic added to the MapData iterator
to deal with the possibility of map mutation between creation of the iterator
and use of it. We'll be able to improve the performance of this substantially
by using intrinsics, however I'm pondering coming up with a better way to define
these thunks without requiring so much duplicated logic.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/CommonIdentifiers.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/JSMapIterator.cpp: Added.

(JSC::JSMapIterator::finishCreation):
(JSC::JSMapIterator::visitChildren):
(JSC::JSMapIterator::createPair):

  • runtime/JSMapIterator.h: Added.

(JSC::JSMapIterator::createStructure):
(JSC::JSMapIterator::create):
(JSC::JSMapIterator::next):
(JSC::JSMapIterator::JSMapIterator):

  • runtime/MapData.h:

(JSC::MapData::const_iterator::ensureSlot):

  • runtime/MapIteratorConstructor.cpp: Added.

(JSC::MapIteratorConstructor::finishCreation):

  • runtime/MapIteratorConstructor.h: Added.

(JSC::MapIteratorConstructor::create):
(JSC::MapIteratorConstructor::createStructure):
(JSC::MapIteratorConstructor::MapIteratorConstructor):

  • runtime/MapIteratorPrototype.cpp: Added.

(JSC::MapIteratorPrototype::finishCreation):
(JSC::MapIteratorPrototypeFuncIterator):
(JSC::MapIteratorPrototypeFuncNext):

  • runtime/MapIteratorPrototype.h: Added.

(JSC::MapIteratorPrototype::create):
(JSC::MapIteratorPrototype::createStructure):
(JSC::MapIteratorPrototype::MapIteratorPrototype):

  • runtime/MapPrototype.cpp:

(JSC::MapPrototype::finishCreation):
(JSC::mapProtoFuncValues):
(JSC::mapProtoFuncEntries):
(JSC::mapProtoFuncKeys):

LayoutTests:

Moved map tests to a more sensible location, and added new iteration tests.

  • js/basic-map-expected.txt: Renamed from LayoutTests/js/dom/basic-map-expected.txt.
  • js/basic-map.html: Renamed from LayoutTests/js/dom/basic-map.html.
  • js/script-tests/basic-map.js: Renamed from LayoutTests/js/dom/script-tests/basic-map.js.

(set shouldBe):
(set var):

7:39 PM Changeset in webkit [159007] by Martin Robinson
  • 7 edits in trunk

[MathML] Poor spacing around delimiters in MathML Torture Test 14
https://bugs.webkit.org/show_bug.cgi?id=122837

Reviewed by Brent Fulgham.

Instead of stretching the vertical bar with the stretchable version, just repeat
the normal vertical bar. This follows what Gecko does when rendering tall vertical
bars and also works around an issue with STIX fonts leading to poor spacing in
formulas.

Source/WebCore:

  • rendering/mathml/RenderMathMLOperator.cpp: Stretch the vertical bar with the

normal variant.

LayoutTests:

  • platform/gtk/mathml/presentation/mo-stretch-expected.png: Update to reflect new results.
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt: Ditto.
  • platform/mac/mathml/presentation/mo-stretch-expected.png: Ditto.
  • platform/mac/mathml/presentation/mo-stretch-expected.txt: Ditto.
7:36 PM Changeset in webkit [159006] by akling@apple.com
  • 2 edits
    1 copy
    20 moves
    1 add
    22 deletes in trunk/LayoutTests

Optimize baselines: svg/clip-path

Unreviewed; run "webkit-patch optimize-baselines svg/clip-path"

  • platform/efl/svg/clip-path/clip-path-pixelation-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-in-clip-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-clipped-no-content-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-pixelation-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-recursive-call-by-child-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-recursive-call-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-text-and-shape-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-text-and-stroke-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-text-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child2-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child3-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child4-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child5-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-container-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-different-unittypes-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-different-unittypes2-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-invisibile-child-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-text-clipped-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clipper-placement-issue-expected.png: Removed.
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Removed.
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Removed.
  • platform/win-future/svg/clip-path/clip-path-pixelation-expected.txt: Copied from LayoutTests/svg/clip-path/clip-path-pixelation-expected.txt.
  • svg/clip-path/clip-in-clip-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-in-clip-expected.png.
  • svg/clip-path/clip-path-clipped-no-content-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.png.
  • svg/clip-path/clip-path-pixelation-expected.txt:
  • svg/clip-path/clip-path-recursive-call-by-child-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-recursive-call-by-child-expected.png.
  • svg/clip-path/clip-path-recursive-call-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-recursive-call-expected.png.
  • svg/clip-path/clip-path-text-and-shape-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-text-and-shape-expected.txt.
  • svg/clip-path/clip-path-text-and-stroke-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-text-and-stroke-expected.txt.
  • svg/clip-path/clip-path-text-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-text-expected.txt.
  • svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-tspan-and-stroke-expected.txt.
  • svg/clip-path/clip-path-use-as-child2-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child2-expected.png.
  • svg/clip-path/clip-path-use-as-child3-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child3-expected.png.
  • svg/clip-path/clip-path-use-as-child4-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child4-expected.png.
  • svg/clip-path/clip-path-use-as-child5-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child5-expected.png.
  • svg/clip-path/clip-path-with-container-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-container-expected.png.
  • svg/clip-path/clip-path-with-different-unittypes-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.png.
  • svg/clip-path/clip-path-with-different-unittypes2-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.png.
  • svg/clip-path/clip-path-with-invisibile-child-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.png.
  • svg/clip-path/clip-path-with-text-clipped-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-text-clipped-expected.txt.
  • svg/clip-path/clipper-placement-issue-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clipper-placement-issue-expected.png.
  • svg/clip-path/deep-nested-clip-in-mask-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.txt.
  • svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt.
7:32 PM Changeset in webkit [159005] by akling@apple.com
  • 2 edits
    5 copies
    48 moves
    2 adds
    57 deletes in trunk/LayoutTests

Optimize baselines: svg/hixie

Unreviewed; run "webkit-patch optimize-baselines svg/hixie"

  • platform/efl/svg/hixie/perf/007-expected.txt: Removed.
  • platform/gtk/svg/hixie/dynamic/002-expected.png: Removed.
  • platform/gtk/svg/hixie/dynamic/003-expected.png: Removed.
  • platform/gtk/svg/hixie/dynamic/004-expected.png: Removed.
  • platform/gtk/svg/hixie/dynamic/005-expected.png: Removed.
  • platform/gtk/svg/hixie/dynamic/006-expected.png: Removed.
  • platform/gtk/svg/hixie/error/001-expected.png: Removed.
  • platform/gtk/svg/hixie/error/002-expected.png: Removed.
  • platform/gtk/svg/hixie/error/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/003-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/006-expected.png: Removed.
  • platform/gtk/svg/hixie/error/007-expected.png: Removed.
  • platform/gtk/svg/hixie/error/008-expected.png: Removed.
  • platform/gtk/svg/hixie/error/009-expected.png: Removed.
  • platform/gtk/svg/hixie/error/010-expected.png: Removed.
  • platform/gtk/svg/hixie/error/010-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/011-expected.png: Removed.
  • platform/gtk/svg/hixie/error/011-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/014-expected.png: Removed.
  • platform/gtk/svg/hixie/error/014-test-expected.png: Removed.
  • platform/gtk/svg/hixie/error/015-expected.png: Removed.
  • platform/gtk/svg/hixie/error/016-expected.png: Removed.
  • platform/gtk/svg/hixie/error/017-expected.txt: Removed.
  • platform/gtk/svg/hixie/intrinsic/001-expected.png: Removed.
  • platform/gtk/svg/hixie/intrinsic/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/intrinsic/002-expected.png: Removed.
  • platform/gtk/svg/hixie/intrinsic/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/links/002-expected.png: Removed.
  • platform/gtk/svg/hixie/links/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/mixed/007-expected.png: Removed.
  • platform/gtk/svg/hixie/painting/001-expected.png: Removed.
  • platform/gtk/svg/hixie/perf/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/003-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/004-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/005-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/006-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/007-expected.txt: Removed.
  • platform/gtk/svg/hixie/processing-model/003-expected.png: Removed.
  • platform/gtk/svg/hixie/processing-model/004-expected.png: Removed.
  • platform/gtk/svg/hixie/processing-model/005-expected.png: Removed.
  • platform/gtk/svg/hixie/rendering-model/003a-expected.png: Removed.
  • platform/gtk/svg/hixie/shapes/path/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/text/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/text/003a-expected.txt: Removed.
  • platform/gtk/svg/hixie/text/003b-expected.txt: Removed.
  • platform/gtk/svg/hixie/use/001-expected.png: Removed.
  • platform/gtk/svg/hixie/use/002-expected.png: Removed.
  • platform/gtk/svg/hixie/use/002-test-expected.png: Removed.
  • platform/gtk/svg/hixie/viewbox/001-expected.png: Removed.
  • platform/gtk/svg/hixie/viewbox/004-expected.png: Removed.
  • platform/gtk/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Removed.
  • platform/mac/svg/hixie/cascade/002-expected.txt: Removed.
  • platform/mac/svg/hixie/perf/004-expected.txt: Removed.
  • platform/mac/svg/hixie/perf/005-expected.txt: Removed.
  • platform/mac/svg/hixie/perf/006-expected.txt: Removed.
  • platform/win-future/svg/hixie/perf/007-expected.txt: Copied from LayoutTests/svg/hixie/perf/007-expected.txt.
  • svg/hixie/cascade/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/cascade/002-expected.txt.
  • svg/hixie/dynamic/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/002-expected.png.
  • svg/hixie/dynamic/003-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/003-expected.png.
  • svg/hixie/dynamic/004-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/004-expected.png.
  • svg/hixie/dynamic/005-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/005-expected.png.
  • svg/hixie/dynamic/006-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/006-expected.png.
  • svg/hixie/error/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/001-expected.png.
  • svg/hixie/error/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/002-expected.png.
  • svg/hixie/error/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/002-expected.txt.
  • svg/hixie/error/003-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/003-expected.txt.
  • svg/hixie/error/006-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/006-expected.png.
  • svg/hixie/error/007-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/007-expected.png.
  • svg/hixie/error/008-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/008-expected.png.
  • svg/hixie/error/009-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/009-expected.png.
  • svg/hixie/error/010-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/010-expected.png.
  • svg/hixie/error/010-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/010-expected.txt.
  • svg/hixie/error/011-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/011-expected.png.
  • svg/hixie/error/011-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/011-expected.txt.
  • svg/hixie/error/014-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/014-expected.png.
  • svg/hixie/error/014-test-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/014-test-expected.png.
  • svg/hixie/error/015-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/015-expected.png.
  • svg/hixie/error/016-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/016-expected.png.
  • svg/hixie/error/017-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/017-expected.txt.
  • svg/hixie/intrinsic/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/001-expected.png.
  • svg/hixie/intrinsic/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/001-expected.txt.
  • svg/hixie/intrinsic/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/002-expected.png.
  • svg/hixie/intrinsic/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/002-expected.txt.
  • svg/hixie/links/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/links/002-expected.png.
  • svg/hixie/links/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/links/002-expected.txt.
  • svg/hixie/mixed/007-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/mixed/007-expected.png.
  • svg/hixie/painting/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/painting/001-expected.png.
  • svg/hixie/perf/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/001-expected.txt.
  • svg/hixie/perf/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/002-expected.txt.
  • svg/hixie/perf/003-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/003-expected.txt.
  • svg/hixie/perf/004-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/004-expected.txt.
  • svg/hixie/perf/005-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/005-expected.txt.
  • svg/hixie/perf/006-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/006-expected.txt.
  • svg/hixie/perf/007-expected.txt:
  • svg/hixie/processing-model/003-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/processing-model/003-expected.png.
  • svg/hixie/processing-model/004-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/processing-model/004-expected.png.
  • svg/hixie/processing-model/005-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/processing-model/005-expected.png.
  • svg/hixie/rendering-model/003a-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/rendering-model/003a-expected.png.
  • svg/hixie/shapes/path/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/shapes/path/001-expected.txt.
  • svg/hixie/text/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/text/002-expected.txt.
  • svg/hixie/text/003a-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/text/003a-expected.txt.
  • svg/hixie/text/003b-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/text/003b-expected.txt.
  • svg/hixie/use/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/use/001-expected.png.
  • svg/hixie/use/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/use/002-expected.png.
  • svg/hixie/use/002-test-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/use/002-test-expected.png.
  • svg/hixie/viewbox/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/001-expected.png.
  • svg/hixie/viewbox/004-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/004-expected.png.
  • svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt.
  • svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt.
5:27 PM Changeset in webkit [159004] by andersca@apple.com
  • 7 edits in trunk/Source

Encode form data using the KeyedEncoder
https://bugs.webkit.org/show_bug.cgi?id=124107

Reviewed by Sam Weinig.

Source/WebCore:

  • platform/KeyedCoding.h:

(WebCore::KeyedEncoder::encodeEnum):

  • platform/network/FormData.cpp:

(WebCore::encodeElement):
(WebCore::FormData::encode):

  • platform/network/FormData.h:

Source/WebKit2:

  • Shared/cf/KeyedEncoder.cpp:

(WebKit::KeyedEncoder::encodeBool):
(WebKit::KeyedEncoder::encodeDouble):

  • Shared/cf/KeyedEncoder.h:
3:26 PM Changeset in webkit [159003] by andersca@apple.com
  • 1 edit
    1 delete in trunk/Source/WebKit2

Remove an unused file.

Rubber-stamped by Andreas Kling.

  • WebProcess/WebPage/gtk/ChunkedUpdateDrawingAreaGtk.cpp: Removed.
1:41 PM Changeset in webkit [159002] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Modernize CanvasObserverProxy
https://bugs.webkit.org/show_bug.cgi?id=124106

Reviewed by Anders Carlsson.

  • css/CSSCanvasValue.h:
12:59 PM Changeset in webkit [159001] by Patrick Gansterer
  • 101 edits
    7 moves
    1 add in trunk/Source

Move RunLoop from WebCore to WTF
https://bugs.webkit.org/show_bug.cgi?id=116606

Reviewed by Anders Carlsson.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • PlatformWin.cmake:
  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

Source/WebKit/mac:

  • Carbon/CarbonWindowAdapter.mm:

(+[CarbonWindowAdapter initialize]):

  • History/WebBackForwardList.mm:

(+[WebBackForwardList initialize]):

  • History/WebHistoryItem.mm:

(+[WebHistoryItem initialize]):

  • Misc/WebCache.mm:

(+[WebCache initialize]):

  • Misc/WebElementDictionary.mm:

(+[WebElementDictionary initialize]):

  • Misc/WebIconDatabase.mm:

(+[WebIconDatabase initialize]):

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(+[WebHostedNetscapePluginView initialize]):

  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebBasePluginPackage.mm:
  • Plugins/WebNetscapePluginView.mm:

(+[WebNetscapePluginView initialize]):

  • WebCoreSupport/WebEditorClient.mm:

(+[WebUndoStep initialize]):

  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebArchive.mm:

(+[WebArchivePrivate initialize]):

  • WebView/WebDataSource.mm:

(+[WebDataSource initialize]):

  • WebView/WebHTMLView.mm:

(+[WebHTMLViewPrivate initialize]):
(+[WebHTMLView initialize]):

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

  • WebView/WebResource.mm:

(+[WebResourcePrivate initialize]):

  • WebView/WebTextIterator.mm:

(+[WebTextIteratorPrivate initialize]):

  • WebView/WebView.mm:

(+[WebView initialize]):

  • WebView/WebViewData.mm:

(+[WebViewPrivate initialize]):

Source/WebKit2:

  • DatabaseProcess/DatabaseProcess.cpp:
  • DatabaseProcess/DatabaseToWebProcessConnection.cpp:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:
  • NetworkProcess/NetworkProcess.cpp:
  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/mac/DiskCacheMonitor.h:
  • NetworkProcess/unix/NetworkProcessMainUnix.cpp:
  • Platform/CoreIPC/Connection.cpp:
  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/mac/ConnectionMac.cpp:
  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
  • PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:
  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginProcess.cpp:
  • PluginProcess/PluginProcess.h:
  • PluginProcess/WebProcessConnection.cpp:
  • PluginProcess/unix/PluginProcessMainUnix.cpp:
  • Shared/ChildProcess.cpp:
  • Shared/ChildProcess.h:
  • Shared/ChildProcessProxy.cpp:
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h:
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.mm:
  • Shared/Plugins/NPObjectProxy.cpp:
  • Shared/WebKit2Initialize.cpp:

(WebKit::InitializeWebKit2):

  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
  • UIProcess/API/mac/FindIndicatorWindow.h:
  • UIProcess/API/mac/WKPrintingView.mm:
  • UIProcess/API/mac/WKView.mm:
  • UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:
  • UIProcess/Network/NetworkProcessProxy.cpp:
  • UIProcess/Plugins/PluginProcessProxy.cpp:
  • UIProcess/ResponsivenessTimer.cpp:
  • UIProcess/ResponsivenessTimer.h:
  • UIProcess/VisitedLinkProvider.h:
  • UIProcess/WebContext.cpp:
  • UIProcess/WebProcessProxy.cpp:
  • WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
  • WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
  • WebProcess/Network/WebResourceLoadScheduler.h:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
  • WebProcess/Plugins/PluginView.h:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/EventDispatcher.cpp:
  • WebProcess/WebPage/PageOverlay.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.cpp:
  • WebProcess/efl/WebProcessMainEfl.cpp:
  • WebProcess/gtk/WebProcessMainGtk.cpp:

Source/WTF:

With this change RunLoop can be used in JavaScriptCore too.

  • GNUmakefile.list.am:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/PlatformBlackBerry.cmake:
  • wtf/PlatformEfl.cmake:
  • wtf/PlatformGTK.cmake:
  • wtf/PlatformWin.cmake:
  • wtf/RunLoop.cpp: Renamed from Source/WebCore/platform/RunLoop.cpp.

(WTF::RunLoop::Holder::Holder):
(WTF::RunLoop::Holder::runLoop):
(WTF::RunLoop::initializeMainRunLoop):
(WTF::RunLoop::current):
(WTF::RunLoop::main):
(WTF::RunLoop::isMain):
(WTF::RunLoop::performWork):
(WTF::RunLoop::dispatch):

  • wtf/RunLoop.h: Renamed from Source/WebCore/platform/RunLoop.h.

(WTF::RunLoop::TimerBase::startRepeating):
(WTF::RunLoop::TimerBase::startOneShot):
(WTF::RunLoop::TimerBase::isRepeating):
(WTF::RunLoop::Timer::Timer):
(WTF::RunLoop::Timer::fired):

  • wtf/blackberry/RunLoopBlackBerry.cpp: Renamed from Source/WebCore/platform/blackberry/RunLoopBlackBerry.cpp.

(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::wakeUp):

  • wtf/cf/RunLoopCF.cpp: Renamed from Source/WebCore/platform/cf/RunLoopCF.cpp.

(WTF::RunLoop::performWork):
(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::runForDuration):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::run):
(WTF::RunLoop::stop):
(WTF::RunLoop::TimerBase::timerFired):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

  • wtf/efl/RunLoopEfl.cpp: Renamed from Source/WebCore/platform/efl/RunLoopEfl.cpp.

(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::run):
(WTF::RunLoop::stop):
(WTF::RunLoop::wakeUpEvent):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::timerFired):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

  • wtf/gtk/RunLoopGtk.cpp: Renamed from Source/WebCore/platform/gtk/RunLoopGtk.cpp.

(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::run):
(WTF::RunLoop::innermostLoop):
(WTF::RunLoop::pushNestedMainLoop):
(WTF::RunLoop::popNestedMainLoop):
(WTF::RunLoop::stop):
(WTF::RunLoop::queueWork):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::clearTimerSource):
(WTF::RunLoop::TimerBase::timerFiredCallback):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

  • wtf/win/RunLoopWin.cpp: Renamed from Source/WebCore/platform/win/RunLoopWin.cpp.

(WTF::RunLoop::RunLoopWndProc):
(WTF::RunLoop::wndProc):
(WTF::RunLoop::run):
(WTF::RunLoop::stop):
(WTF::RunLoop::registerRunLoopMessageWindowClass):
(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::TimerBase::timerFired):
(WTF::generateTimerID):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

8:11 AM Changeset in webkit [159000] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Tighten typing in SVGResourcesCycleSolver a bit.
<https://webkit.org/b/124104>

Make the SVGResourcesCycleSolver constructor take a RenderElement&
and a SVGResources&.

While I was in the neighborhood, also converted one loop to use a
renderer iterator instead of walking siblings manually.

Finally used "auto" to clean up some overly wordy loops.

Reviewed by Anders Carlsson.

3:32 AM Changeset in webkit [158999] by akling@apple.com
  • 18 edits in trunk/Source/WebCore

Beat SVGRenderSupport with the RenderElement stick.
<https://webkit.org/b/124102>

Tighten up all the SVGRenderSupport helper functions by making them
take const RenderElements references instead of raw RenderObject
pointers as much as possible.

This tunes up a bunch of branchy style() calls.

The patch looks big but it's mostly mechanical. I just changed the
signatures and then worked backwards until everything built again.

Reviewed by Antti Koivisto.

3:17 AM Changeset in webkit [158998] by akling@apple.com
  • 10 edits in trunk/Source/WebCore

SVGTextLayoutAttributes always has a RenderSVGInlineText.
<https://webkit.org/b/124101>

No SVGTextLayoutAttributes object is without a RenderSVGInlineText
"context" so make context() return a reference.

Reviewed by Antti Koivisto.

3:16 AM Changeset in webkit [158997] by akling@apple.com
  • 13 edits
    2 deletes in trunk/Source/WebCore

Move BindingSecurity stuff under JSDOMBinding umbrella.
<https://webkit.org/b/124099>

We are hitting shouldAllowAccessToDOMWindow() pretty hard on the
demo here: <http://www.jasondavies.com/maps/rotate/>

Putting it together with the rest of the JSDOMBinding code takes
CPU time spent in there from 8.7% to 6.5%. The abstraction was
only used to support alternate JS engines in the past.

Reviewed by Antti Koivisto.

3:14 AM Changeset in webkit [158996] by Antti Koivisto
  • 2 edits in trunk/PerformanceTests

Add subtest for word-break:break-all to Layout/line-layout-simple.html
https://bugs.webkit.org/show_bug.cgi?id=124103

Reviewed by Andreas Kling.

  • Layout/line-layout-simple.html:

Combination "white-space:pre-wrap; word-break:break-all" is common for pure text.

Nov 8, 2013:

11:57 PM Changeset in webkit [158995] by zandobersek@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed GTK build fix.

  • GNUmakefile.list.am: Remove redundant build targets.
10:55 PM Changeset in webkit [158994] by fpizlo@apple.com
  • 4 edits
    2 deletes in trunk/Source/JavaScriptCore

Remove dead FTL C ABI support
https://bugs.webkit.org/show_bug.cgi?id=124100

Reviewed by Jer Noble.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • ftl/FTLCArgumentGetter.cpp: Removed.
  • ftl/FTLCArgumentGetter.h: Removed.
  • ftl/FTLOSRExitCompiler.cpp:
  • jit/FPRInfo.h:
10:53 PM Changeset in webkit [158993] by fpizlo@apple.com
  • 3 edits in trunk/WebKitLibraries

Update binary drops to a version that includes new stackmap fixes and exposes the new calling conventions.

  • LLVMIncludesMountainLion.tar.bz2:
  • LLVMLibrariesMountainLion.tar.bz2:
10:27 PM Changeset in webkit [158992] by beidson@apple.com
  • 39 edits
    2 moves
    1 delete in trunk/Source

Merge IDBDatabaseBackendInterface and IDBDatabaseBackendImpl
https://bugs.webkit.org/show_bug.cgi?id=124088

Source/WebCore:

Reviewed by Tim Horton.

Source/WebKit2:

Reviewed by Tim Horton.

This abstraction is no longer meaningful in its current form in WebCore.
The current groundwork for the WK2 DatabaseProcess relied on this abstraction,
but that will be reworked in a future patch.

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBDatabaseBackend.h:
  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::maybeCreateTransactionBackend):
(WebKit::WebIDBFactoryBackend::createCursorBackend):

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
  • WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp:

(WebKit::WebProcessIDBDatabaseBackend::put):
(WebKit::WebProcessIDBDatabaseBackend::openCursor):

  • WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:
10:00 PM Changeset in webkit [158991] by commit-queue@webkit.org
  • 12 edits in trunk/LayoutTests

Updating LayoutTests that depend on RTCPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=124097

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-08
Reviewed by Eric Carlson.

Needed to do not throw unwanted exception

  • fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
  • fast/mediastream/RTCPeerConnection-createAnswer.html:
  • fast/mediastream/RTCPeerConnection-createOffer.html:
  • fast/mediastream/RTCPeerConnection-datachannel.html:
  • fast/mediastream/RTCPeerConnection-dtmf.html:
  • fast/mediastream/RTCPeerConnection-events.html:
  • fast/mediastream/RTCPeerConnection-ice.html:
  • fast/mediastream/RTCPeerConnection-localDescription.html:
  • fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
  • fast/mediastream/RTCPeerConnection-remoteDescription.html:
  • fast/mediastream/RTCPeerConnection-state.html:
8:40 PM Changeset in webkit [158990] by ljaehun.lim@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r158984.

No needs to include "KeyedEncoder.h".
WebKit/Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp:31:26: fatal error: KeyedEncoder.h: No such file or directory

  • WebProcess/WebPage/WebBackForwardListProxy.cpp: Removed #include line.
8:24 PM Changeset in webkit [158989] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

FTL should support Phantom(FinalObject:)
https://bugs.webkit.org/show_bug.cgi?id=124092

Reviewed by Oliver Hunt.

  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::isType):
(JSC::FTL::LowerDFGToLLVM::isNotType):
(JSC::FTL::LowerDFGToLLVM::speculateFinalObject):

8:20 PM Changeset in webkit [158988] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Get rid of the FTL tail call APIs since they are unused
https://bugs.webkit.org/show_bug.cgi?id=124093

Reviewed by Oliver Hunt.

  • ftl/FTLAbbreviations.h:

(JSC::FTL::buildCall):

  • ftl/FTLOutput.h:
8:17 PM Changeset in webkit [158987] by commit-queue@webkit.org
  • 25 edits in trunk/LayoutTests

Improving readability of LayoutTests in fast/mediastream
https://bugs.webkit.org/show_bug.cgi?id=124095

Adding some indentation

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-08
Reviewed by Eric Carlson.

  • fast/mediastream/MediaStream-add-remove-tracks.html:
  • fast/mediastream/MediaStream-onended.html:
  • fast/mediastream/MediaStreamConstructor.html:
  • fast/mediastream/RTCIceCandidate.html:
  • fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
  • fast/mediastream/RTCPeerConnection-createAnswer.html:
  • fast/mediastream/RTCPeerConnection-createOffer.html:
  • fast/mediastream/RTCPeerConnection-datachannel.html:
  • fast/mediastream/RTCPeerConnection-dtmf.html:
  • fast/mediastream/RTCPeerConnection-events.html:
  • fast/mediastream/RTCPeerConnection-ice.html:
  • fast/mediastream/RTCPeerConnection-localDescription.html:
  • fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
  • fast/mediastream/RTCPeerConnection-remoteDescription.html:
  • fast/mediastream/RTCPeerConnection-state.html:
  • fast/mediastream/RTCPeerConnection-stats.html:
  • fast/mediastream/RTCPeerConnection-statsSelector.html:
  • fast/mediastream/RTCPeerConnection.html:
  • fast/mediastream/RTCSessionDescription.html:
  • fast/mediastream/argument-types.html:
  • fast/mediastream/constructors.html:
  • fast/mediastream/enabled.html:
  • fast/mediastream/getusermedia.html:
  • fast/mediastream/no-interface-object.html:
7:40 PM Changeset in webkit [158986] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Reindent JSDOMBinding.h (finally.)

Rubber-stamped by Sam Weinig.

7:24 PM Changeset in webkit [158985] by weinig@apple.com
  • 64 edits in trunk/Source/WebCore

Change collectStyleForPresentationAttribute and related functions to take a MutableStylePropertySet by reference
https://bugs.webkit.org/show_bug.cgi?id=124096

Reviewed by Andreas Kling.

Pass MutableStylePropertySet by reference. It is never null.

5:51 PM Changeset in webkit [158984] by andersca@apple.com
  • 7 edits in trunk/Source

Implement encoding of arrays of objects
https://bugs.webkit.org/show_bug.cgi?id=124091

Reviewed by Beth Dakin.

Source/WebCore:

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTreeNode):
Encode the rest of the members.

  • platform/KeyedCoding.h:

(WebCore::KeyedEncoder::encodeObjects):
Call beginArray, then beginArrayElement/endArrayElement for every element and lastly endArray.

Source/WebKit2:

Add a new array stack and push and pop from it accordingly.

  • Shared/cf/KeyedEncoder.cpp:

(WebKit::KeyedEncoder::~KeyedEncoder):
(WebKit::KeyedEncoder::encodeBytes):
(WebKit::KeyedEncoder::encodeUInt32):
(WebKit::KeyedEncoder::encodeInt32):
(WebKit::KeyedEncoder::encodeInt64):
(WebKit::KeyedEncoder::encodeFloat):
(WebKit::KeyedEncoder::beginArray):
(WebKit::KeyedEncoder::beginArrayElement):
(WebKit::KeyedEncoder::endArrayElement):
(WebKit::KeyedEncoder::endArray):

  • Shared/cf/KeyedEncoder.h:
5:44 PM Changeset in webkit [158983] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

FTL should support AllocatePropertyStorage
https://bugs.webkit.org/show_bug.cgi?id=124086

Reviewed by Oliver Hunt.

Also rationalized some offsets in the DFG.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileAllocatePropertyStorage):

5:43 PM Changeset in webkit [158982] by timothy_horton@apple.com
  • 13 edits in trunk/Source

Remote Layer Tree: RemoteLayerBackingStore partial repaint is broken for the tile cache
https://bugs.webkit.org/show_bug.cgi?id=123944

Reviewed by Simon Fraser.

Ensure that the tile cache retrieves repaint rects from the tile layer,
not from the tiled backing layer.

Rework RemoteLayerBackingStore painting to fix some rounding issues
that would cause pixel cracks upon repaint, and to speed it up a bit.

  • Shared/mac/RemoteLayerBackingStore.h:

Redefine RepaintRectList because we can't include WebLayer.h here yet.
Remove createBackingStore, which was never implemented.
Remove mapToContentCoordinates, because we don't need it on Mac.

(WebKit::RemoteLayerBackingStore::paintingRects): Added.

  • Shared/mac/RemoteLayerBackingStore.mm:

(RemoteLayerBackingStore::setNeedsDisplay):
(RemoteLayerBackingStore::display):
Stop using mapToContentCoordinates.

(RemoteLayerBackingStore::drawInContext):
Use clipping instead of painting the image multiple times.
Never repaint more than the dirty region's bounds.
Don't waste time with all of the drawNativeImage code, just use CG.
Unindent the switch's cases.
Store the rects we're painting so that enumerateRectsBeingDrawn can get them.
Pixel-snap the rects we're painting.
Clip the context before going to paint.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::enumerateRectsBeingDrawn):

  • WebProcess/WebPage/mac/PlatformCALayerRemote.h:

Retrieve the rects currently being painted from our backing store, and
transform them (mostly) according to the CTM, to match the transformation
that will have occurred underneath wkCALayerEnumerateRectsBeingDrawnWithBlock.

  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayerMac::enumerateRectsBeingDrawn):
Allow the PlatformCALayer to decide how to enumerate rects to paint.

  • WebCore.exp.in:
  • platform/graphics/mac/WebLayer.h:

Add RepaintRectList, remove some unnecessary WebCore::s.

  • platform/graphics/mac/WebLayer.mm:

(WebCore::collectRectsToPaint):
Factor collectRectsToPaint out; it just grabs the rects from
the layer and makes the decision whether to repaint the bounds
of the dirty region or just the subregions.

Move calls to collectRectsToPaint() to callers of drawLayerContents(),
so that TileController can collect rects from the appropriate source
(the Tile layer) and other layers just continue grabbing them from
their relevant layers.

Make sure that the list that comes from collectRectsToPaint() always
has at least one rect in it (appending the clip bounds if we don't
want to repaint subregions) so we can simplify logic in drawLayerContents.

(WebCore::drawLayerContents):
Remove code to support CompositingCoordinatesBottomUp, as it's only
used on Windows, so this Mac-specific code doesn't need to support it.

Simplify logic given that dirtyRects will always be non-empty.

(-[WebLayer drawInContext:]):
(-[WebSimpleLayer setNeedsDisplayInRect:]):

  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::platformCALayerPaintContents):
Adopt collectRectsToPaint.

5:29 PM Changeset in webkit [158981] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Get rid of the bizarre Darwin/x86-only MacroAssembler::shouldBlindForSpecificArch(uintptr_t) overload
https://bugs.webkit.org/show_bug.cgi?id=124087

Reviewed by Michael Saboff.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::shouldBlindPointerForSpecificArch):
(JSC::MacroAssembler::shouldBlind):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::shouldBlindForSpecificArch):

5:16 PM Changeset in webkit [158980] by andersca@apple.com
  • 7 edits in trunk/Source

Implement more KeyedEncoder functionality
https://bugs.webkit.org/show_bug.cgi?id=124089

Reviewed by Beth Dakin.

Source/WebCore:

  • bindings/js/SerializedScriptValue.h:
  • history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTreeNode):

  • platform/KeyedCoding.h:

(WebCore::KeyedEncoder::encodeConditionalObject):

Source/WebKit2:

  • Shared/cf/KeyedEncoder.cpp:

(WebKit::KeyedEncoder::encodeBytes):
(WebKit::KeyedEncoder::encodeInt32):
(WebKit::KeyedEncoder::encodeFloat):

  • Shared/cf/KeyedEncoder.h:
5:13 PM Changeset in webkit [158979] by eric.carlson@apple.com
  • 3 edits
    2 adds in trunk

getCueAsHTML() on an empty cue should return a document fragment
https://bugs.webkit.org/show_bug.cgi?id=124084

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-cue-empty-cue-text.html

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::createDocumentFragmentFromCueText): Don't return early when the

passed an empty string.

LayoutTests:

  • media/track/track-cue-empty-cue-text-expected.txt: Added.
  • media/track/track-cue-empty-cue-text.html: Added.
4:51 PM Changeset in webkit [158978] by andersca@apple.com
  • 7 edits in trunk/Source

KeyedEncoder should be able to encoder objects
https://bugs.webkit.org/show_bug.cgi?id=124085

Reviewed by Sam Weinig.

Source/WebCore:

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTree):
Encode the root object.

(WebCore::HistoryItem::encodeBackForwardTreeNode):
Encode the target.

  • history/HistoryItem.h:

Add new members.

  • platform/KeyedCoding.h:

(WebCore::KeyedEncoder::encodeObject):
Call beginObject, call the functor and then call endObject().

Source/WebKit2:

Add a dictionary stack to KeyedEncoder that's pushed and popped by
beginObject/endObject.

  • Shared/cf/KeyedEncoder.cpp:

(WebKit::KeyedEncoder::KeyedEncoder):
(WebKit::KeyedEncoder::~KeyedEncoder):
(WebKit::KeyedEncoder::encodeUInt32):
(WebKit::KeyedEncoder::encodeString):
(WebKit::KeyedEncoder::beginObject):
(WebKit::KeyedEncoder::endObject):

  • Shared/cf/KeyedEncoder.h:
4:42 PM Changeset in webkit [158977] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

FTL should support NewArrayBuffer
https://bugs.webkit.org/show_bug.cgi?id=124067

Reviewed by Michael Saboff.

This expanded coverage and revealed some bugs.

This revealed a bug in FTL::OSRExitCompiler where it was assuming that it could save
the framePointer in regT3 even though DFG::reifyInlinedCallFrames() would clobber it.
It turns out that this can be fixed by just completely restoring the stack prior to
doing reifyInlineCallFrames().

I used this as an opportunity to simplify NewArray. That revealed a bug; whenever we say
lowJSValue() in there we need to use ManualOperandSpeculation since we're using it to
rebox values even when we also have to do some speculations. The speculations are done
at the top of compileNewArray().

This also revealed a bug in StringCharAt() for the OOB case.

  • ftl/FTLAbstractHeapRepository.h:

(JSC::FTL::AbstractHeapRepository::forIndexingType):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNewArray):
(JSC::FTL::LowerDFGToLLVM::compileNewArrayBuffer):
(JSC::FTL::LowerDFGToLLVM::compileStringCharAt):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

4:39 PM Changeset in webkit [158976] by Alexandru Chiculita
  • 4 edits
    2 adds in trunk

Web Inspector: It should be possible to debug the Inspector code
https://bugs.webkit.org/show_bug.cgi?id=124065

Reviewed by Timothy Hatcher.

Source/WebKit2:

When the script is paused, the debugger will pause all the pages in the same PageGroup.
All the Inspector windows were created in the same PageGroup, so pausing one debugger
would stop the other too.

Added WebInspectorPageGroups to manage the PageGroups created for the Inspectors.
The WebInspectors will now use the inspection "level" to figure out which PageGroup to use.
The inspector that debugs the main page will use "WebInspectorPageGroupLevel1",
the second inspector (that debugs the first inspector) will use "WebInspectorPageGroupLevel2" ...

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorPageGroups::shared):
(WebKit::WebInspectorPageGroups::inspectorLevel):
(WebKit::WebInspectorPageGroups::isInspectorPageGroup):
(WebKit::WebInspectorPageGroups::inspectorPageGroupLevel):
(WebKit::WebInspectorPageGroups::inspectorPageGroupForLevel):
(WebKit::WebInspectorPageGroups::createInspectorPageGroup):
(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::inspectorPageGroup):
(WebKit::WebInspectorProxy::isInspectorPage):
(WebKit::WebInspectorProxy::canAttach):

  • UIProcess/WebInspectorProxy.h:

LayoutTests:

Added test to check that a second inspector window can be used to debug the first one.

  • inspector-protocol/debugger/nested-inspectors-expected.txt: Added.
  • inspector-protocol/debugger/nested-inspectors.html: Added.
4:39 PM Changeset in webkit [158975] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

It should be easy to disable blinding on a per-architecture basis
https://bugs.webkit.org/show_bug.cgi?id=124083

Reviewed by Michael Saboff.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::haveScratchRegisterForBlinding):
(JSC::AbstractMacroAssembler::scratchRegisterForBlinding):
(JSC::AbstractMacroAssembler::canBlind):
(JSC::AbstractMacroAssembler::shouldBlindForSpecificArch):

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::shouldBlind):
(JSC::MacroAssembler::store32):
(JSC::MacroAssembler::branch32):
(JSC::MacroAssembler::branchAdd32):
(JSC::MacroAssembler::branchMul32):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::canBlind):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::haveScratchRegisterForBlinding):

4:32 PM Changeset in webkit [158974] by matthew_hanson@apple.com
  • 5 edits in branches/safari-537.73-branch/Source

Versioning.

4:29 PM Changeset in webkit [158973] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-537.73.5

New Tag.

4:27 PM Changeset in webkit [158972] by weinig@apple.com
  • 5 edits in trunk/Source/WebCore

Teach CanvasObserver about references
https://bugs.webkit.org/show_bug.cgi?id=124082

Reviewed by Anders Carlsson.

  • css/CSSCanvasValue.cpp:
  • css/CSSCanvasValue.h:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLCanvasElement.h:
4:25 PM Changeset in webkit [158971] by andersca@apple.com
  • 8 edits
    3 moves
    2 deletes in trunk/Source

Begin stubbing out a KeyedEncoder class in WebCore
https://bugs.webkit.org/show_bug.cgi?id=124079

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.exp.in:

Add symbol needed by WebCore.

  • WebCore.xcodeproj/project.pbxproj:

Add new header file.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTree):

  • history/HistoryItem.h:

Add an encodeBackForwardTree overload that takes a KeyedEncoder object. Encode the version.

  • platform/KeyedCoding.h:

Add a KeyedEncoder class that just has a single encodeUInt32 member function for now.

Source/WebKit2:

  • Shared/KeyedEncoder.h: Removed.
  • Shared/cf/KeyedCodingValueCF.cpp: Removed.
  • Shared/cf/KeyedEncoder.cpp: Added.

Remove old keyed encoders.

(WebKit::createDictionary):
Helper function to create a mutable dictionary.
(WebKit::KeyedEncoder::KeyedEncoder):
Create the root dictionary.

(WebKit::KeyedEncoder::encodeUInt32):
Create a CFNumberRef and add it to the dictionary.

  • Shared/cf/KeyedEncoder.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::updateBackForwardItem):
Create a KeyedEncoder and encode the history tree.

4:18 PM Changeset in webkit [158970] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/JavaScriptCore

Rollout r158882. <rdar://problem/15426318>

4:09 PM Changeset in webkit [158969] by beidson@apple.com
  • 20 edits
    1 move
    1 add
    2 deletes in trunk/Source

Merge IDBTransactionBackendInterface and IDBTransactionBackendImpl
https://bugs.webkit.org/show_bug.cgi?id=124077

Reviewed by Alexey Proskuryakov.

Source/WebCore:

The abstraction is no longer needed.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:
  • Modules/indexeddb/IDBTransactionBackendInterface.h: Removed.
  • Modules/indexeddb/IDBTransactionBackend.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp.
  • Modules/indexeddb/IDBTransactionBackend.h: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.h.
  • Modules/indexeddb/IDBBackingStoreInterface.h:
  • Modules/indexeddb/IDBCursorBackend.cpp:
  • Modules/indexeddb/IDBCursorBackend.h:
  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
  • Modules/indexeddb/IDBDatabaseBackendImpl.h:
  • Modules/indexeddb/IDBFactoryBackendInterface.h:
  • Modules/indexeddb/IDBTransactionBackendOperations.h:
  • Modules/indexeddb/IDBTransactionCoordinator.cpp:
  • Modules/indexeddb/IDBTransactionCoordinator.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:

Source/WebKit2:

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
3:53 PM Changeset in webkit [158968] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

REGRESSION (r155660): Some Etherpad pages not scrollable with overlay scrollbars
https://bugs.webkit.org/show_bug.cgi?id=124075

Reviewed by Beth Dakin.

In r155660 I removed some scrollbar-related layouts when scrollbars
are in overlay mode.

However, ScrollView::updateScrollbars() has a case where we still need
to do multiple pases, related to its "Never ever try to both gain/lose a
scrollbar in the same pass" comment. When we avoid making a new scrollbar
because the other was removed, we need to do another pass to bring the
correct scrollbar back.

Can't test overlay scrollbars in tests.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

3:46 PM Changeset in webkit [158967] by hmuller@adobe.com
  • 4 edits
    4 adds in trunk

[CSS Shapes] Image valued shape-outside that extends vertically into the margin-box is top-clipped
https://bugs.webkit.org/show_bug.cgi?id=123769

Reviewed by Dirk Schulze.

Source/WebCore:

Remove the assumption that Y coordinates are >= 0 from the RasterShapeIntervals class
and correct its computeShapeMarginIntervals() method. The computeShapeMarginIntervals()
method now generates intervals with Y coordinates that begin at the image shape's
bounds.y - shape-margin, which may be less than 0.

The RasterShapeIntervals::intervalsAt() method now offsets its Y coordinate parameter
by the shape-margin. A non-const overload of the method was added to centralize all
access to m_intervalLists.

Test: fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-004.html

fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-005.html

  • rendering/shapes/RasterShape.cpp:

(WebCore::MarginIntervalGenerator::intervalAt): Don't clip X coordinates to 0 since they can extend into the margin-box.
(WebCore::RasterShapeIntervals::appendInterval): Use the non-const intervalsAt() method.
(WebCore::RasterShapeIntervals::uniteMarginInterval): Ditto.
(WebCore::RasterShapeIntervals::computeShapeMarginIntervals): See above.

  • rendering/shapes/RasterShape.h:

(WebCore::RasterShapeIntervals::RasterShapeIntervals): Added a field for the margin.
(WebCore::RasterShapeIntervals::intervalsAt): Offset y coordinates by the margin; added a non-const overload.

LayoutTests:

Verify that lines overlap a shape-outside that extends into the top of the margin-box
do wrap around the top of the shape as well its side and bottom.

  • fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-004-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-004.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-005-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-005.html: Added.
3:46 PM Changeset in webkit [158966] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: remove -webkit-min and -webkit-max from CSS completions
https://bugs.webkit.org/show_bug.cgi?id=124072

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-08
Reviewed by Timothy Hatcher.

-webkit-min and -webkit-max are not implemented in WebCore, despite mentions of it.

  • UserInterface/CSSKeywordCompletions.js:
3:45 PM Changeset in webkit [158965] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Ended event should work also when playback rate is negative
https://bugs.webkit.org/show_bug.cgi?id=123879

Patch by Piotr Grad <p.grad@samsung.com> on 2013-11-08
Reviewed by Eric Carlson.

Source/WebCore:

According to W3C specification playback is ended also when playback rate is
negative and position is the earliest possible position.

Test: media/video-ended-event-negative-playback.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):

LayoutTests:

Tests if ended event is triggered for audio/video elements after
changing playback rate to negative.

  • media/video-ended-event-negative-playback-expected.txt: Added.
  • media/video-ended-event-negative-playback.html: Added.
3:36 PM Changeset in webkit [158964] by commit-queue@webkit.org
  • 25 edits
    1 add in trunk

Checking for TypeError in RTCPeerConnection object creation
https://bugs.webkit.org/show_bug.cgi?id=124049

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-08
Reviewed by Eric Carlson.

Source/WebCore:

If invalid parameters are passed on RTCPeerConnection creation we must throw a TypeError exception.
According to the spec it requires a Dictionary argument, the RTCConfiguration, which is mandatory.

Please notice that this patch does not make every tests run as expected,
RTCPeerConnectionHandlerMock needs to be update to deal with contraints.

Existing tests were updated.

  • GNUmakefile.list.am:
  • Modules/mediastream/RTCPeerConnection.idl:
  • UseJSC.cmake:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSRTCPeerConnectionCustom.cpp: Added.

(WebCore::JSRTCPeerConnectionConstructor::constructJSRTCPeerConnection):

LayoutTests:

Please notice that this patch does not make every tests run as expected,
RTCPeerConnectionHandlerMock needs to be update to deal with contraints.

  • fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
  • fast/mediastream/RTCPeerConnection-createAnswer.html:
  • fast/mediastream/RTCPeerConnection-createOffer.html:
  • fast/mediastream/RTCPeerConnection-datachannel.html:
  • fast/mediastream/RTCPeerConnection-dtmf.html:
  • fast/mediastream/RTCPeerConnection-events.html:
  • fast/mediastream/RTCPeerConnection-expected.txt:
  • fast/mediastream/RTCPeerConnection-ice-expected.txt:
  • fast/mediastream/RTCPeerConnection-ice.html:
  • fast/mediastream/RTCPeerConnection-localDescription.html:
  • fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
  • fast/mediastream/RTCPeerConnection-remoteDescription.html:
  • fast/mediastream/RTCPeerConnection-stats-expected.txt:
  • fast/mediastream/RTCPeerConnection-stats.html:
  • fast/mediastream/RTCPeerConnection-statsSelector-expected.txt:
  • fast/mediastream/RTCPeerConnection-statsSelector.html:
  • fast/mediastream/RTCPeerConnection.html:
3:24 PM Changeset in webkit [158963] by Bem Jones-Bey
  • 4 edits in trunk/Source/WebCore

Use references instead of pointers to RenderBlockFlow in FloatingObjects and ComputeFloatOffsetAdapter
https://bugs.webkit.org/show_bug.cgi?id=124074

Reviewed by Sam Weinig.

Just a straightforward conversion from const pointers to const references.

Also, remove unneeded argument from FloatingObjects constructor.

No new tests, no behavior change.

  • rendering/FloatingObjects.cpp:

(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelow):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelowForBlock):
(WebCore::FloatingObjects::FloatingObjects):
(WebCore::FloatingObjects::clearLineBoxTreePointers):
(WebCore::FloatingObjects::computePlacedFloatsTree):
(WebCore::shapeInfoForFloat):
(WebCore::::updateOffsetIfNeeded):
(WebCore::::collectIfNeeded):
(WebCore::::heightRemaining):

  • rendering/FloatingObjects.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::createFloatingObjects):

3:23 PM Changeset in webkit [158962] by weinig@apple.com
  • 6 edits in trunk/Source/WebCore

Teach SubframeLoader a bit about references
https://bugs.webkit.org/show_bug.cgi?id=124076

Reviewed by Anders Carlsson.

  • html/HTMLAppletElement.cpp:
  • html/HTMLFrameElementBase.cpp:
  • html/HTMLMediaElement.cpp:
  • loader/SubframeLoader.cpp:
  • loader/SubframeLoader.h:
3:16 PM Changeset in webkit [158961] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Blind Windows build-fix attempt after r158959

  • WebCore.vcxproj/WebCore.vcxproj:
3:10 PM Changeset in webkit [158960] by matthew_hanson@apple.com
  • 5 edits in branches/safari-537.73-branch/Source/WebKit2

Merge r158101.

2:48 PM Changeset in webkit [158959] by beidson@apple.com
  • 22 edits
    2 moves
    1 delete in trunk/Source

Merge IDBCursorBackendInterface and IDBCursorBackendImpl
https://bugs.webkit.org/show_bug.cgi?id=124068

Reviewed by Anders Carlsson.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:
  • Modules/indexeddb/IDBCursorBackendInterface.h: Removed.
  • Modules/indexeddb/IDBCursorBackend.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.cpp.
  • Modules/indexeddb/IDBCursorBackend.h: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.h.
  • Modules/indexeddb/IDBCallbacks.h:
  • Modules/indexeddb/IDBCursor.cpp:
  • Modules/indexeddb/IDBCursor.h:
  • Modules/indexeddb/IDBCursorWithValue.cpp:
  • Modules/indexeddb/IDBCursorWithValue.h:
  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
  • Modules/indexeddb/IDBFactoryBackendInterface.h:
  • Modules/indexeddb/IDBRequest.cpp:
  • Modules/indexeddb/IDBRequest.h:
  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:
  • Modules/indexeddb/IDBTransactionBackendImpl.h:
  • Modules/indexeddb/IDBTransactionBackendInterface.h:
  • Modules/indexeddb/IDBTransactionBackendOperations.cpp:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:

Source/WebKit2:

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::createCursorBackend):

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
2:42 PM Changeset in webkit [158958] by weinig@apple.com
  • 5 edits in trunk/Source/WebCore

Modernize FrameLoader a bit
https://bugs.webkit.org/show_bug.cgi?id=124073

Reviewed by Anders Carlsson.

  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:

Use std::unique_ptrs rather than OwnPtrs.

  • loader/MixedContentChecker.cpp:
  • loader/MixedContentChecker.h:

Switch to hold a Frame& rather than Frame*.

2:11 PM Changeset in webkit [158957] by oliver@apple.com
  • 1 edit
    4 deletes in trunk/Source/JavaScriptCore

Remove more accidentally added files.

2:09 PM Changeset in webkit [158956] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

Remove code guarded with ENABLE(STREAM)
https://bugs.webkit.org/show_bug.cgi?id=123667

Reviewed by Anders Carlsson.

Remove ENABLE(STREAM)-guarded code. This was added in the effort to provide Stream API support, but
no port enables the feature and the work on this feature has wound down after the Chromium port forked,
leaving this code unmaintained.

  • fileapi/FileReaderLoader.cpp:
  • fileapi/FileReaderLoader.h:
2:04 PM Changeset in webkit [158955] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Remove a workaround for a bug in malloc on Symbian
https://bugs.webkit.org/show_bug.cgi?id=124069

Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::~ArgumentDecoder):
(CoreIPC::ArgumentDecoder::initialize):

  • Platform/CoreIPC/ArgumentDecoder.h:
2:01 PM Changeset in webkit [158954] by Bem Jones-Bey
  • 6 edits in trunk/Source/WebCore

RenderBlockFlow::nextFloatLogicalBottomBelow should not use ShapeOutsideFloatOffsetMode
https://bugs.webkit.org/show_bug.cgi?id=123931

Reviewed by Sam Weinig.

Rewrite nextFloatLogicalBottomBelow to use the placed floats tree for
the search and to not need ShapeOutsideFloatOffsetMode anymore. This
moves almost all of the logic into FloatingObjects, making a small
reduction in the amount that RenderBlockFlow needs to know about the
implementation of FloatingObjects.

In addition, change ComputeFloatOffsetAdapter to take in LayoutUnits
and roundToInt itself so that all of it's callers can be simplified.

No new tests, no new behavior.

  • rendering/FloatingObjects.cpp:

(WebCore::rangesIntersect):
(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter):
(WebCore::FindNextFloatLogicalBottomAdapter::FindNextFloatLogicalBottomAdapter):
(WebCore::FindNextFloatLogicalBottomAdapter::lowValue):
(WebCore::FindNextFloatLogicalBottomAdapter::highValue):
(WebCore::FindNextFloatLogicalBottomAdapter::nextLogicalBottom):
(WebCore::FindNextFloatLogicalBottomAdapter::nextShapeLogicalBottom):
(WebCore::FindNextFloatLogicalBottomAdapter::collectIfNeeded):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelow):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelowForBlock):
(WebCore::FloatingObjects::logicalLeftOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset):

  • rendering/FloatingObjects.h:
  • rendering/LineWidth.cpp:

(WebCore::LineWidth::fitBelowFloats):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelow):
(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelowForBlock):
(WebCore::RenderBlockFlow::getClearDelta):

  • rendering/RenderBlockFlow.h:
2:01 PM Changeset in webkit [158953] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI

Merged r157459. <rdar://problem/15411420>

1:55 PM Changeset in webkit [158952] by Lucas Forschler
  • 15 edits in branches/safari-537.73-branch/Source/WebKit2

Merged r157137. <rdar://problem/15411426>

1:50 PM Changeset in webkit [158951] by matthew_hanson@apple.com
  • 3 edits in tags/Safari-538.5/Source/WebCore

Merge r158923.

1:42 PM Changeset in webkit [158950] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r152867. <rdar://problem/15411424>

1:35 PM Changeset in webkit [158949] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

More build fixes.

  • UIProcess/API/mac/WKBrowsingContextController.mm:
  • UIProcess/API/mac/WKConnection.mm:

(didReceiveMessage):

1:22 PM Changeset in webkit [158948] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

More build fixes.

  • UIProcess/API/mac/WKConnection.h:
  • UIProcess/API/mac/WKConnection.mm:

(didReceiveMessage):

1:19 PM Changeset in webkit [158947] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the 32-bit build.

  • Shared/API/Cocoa/WKBrowsingContextHandleInternal.h:
1:17 PM Changeset in webkit [158946] by matthew_hanson@apple.com
  • 2 edits in trunk/Tools

Added myself as a contributor.

1:07 PM Changeset in webkit [158945] by ap@apple.com
  • 2 edits
    5 moves in trunk/Source/WebCore

https://bugs.webkit.org/show_bug.cgi?id=124064
Some WebCrypto files are not in correct directories

Rubber-stamped by Anders Carlsson.

  • WebCore.xcodeproj/project.pbxproj:
  • crypto/CryptoAlgorithmAesCbcParams.h: Removed.
  • crypto/CryptoAlgorithmAesKeyGenParams.h: Removed.
  • crypto/CryptoKeyAES.cpp: Removed.
  • crypto/CryptoKeyAES.h: Removed.
  • crypto/CryptoKeyMac.cpp: Removed.
  • crypto/keys/CryptoKeyAES.cpp: Copied from Source/WebCore/crypto/CryptoKeyAES.cpp.
  • crypto/keys/CryptoKeyAES.h: Copied from Source/WebCore/crypto/CryptoKeyAES.h.
  • crypto/mac/CryptoKeyMac.cpp: Copied from Source/WebCore/crypto/CryptoKeyMac.cpp.
  • crypto/parameters/CryptoAlgorithmAesCbcParams.h: Copied from Source/WebCore/crypto/CryptoAlgorithmAesCbcParams.h.
  • crypto/parameters/CryptoAlgorithmAesKeyGenParams.h: Copied from Source/WebCore/crypto/CryptoAlgorithmAesKeyGenParams.h.
1:05 PM Changeset in webkit [158944] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Replace alignof with alignof.

Rubber-stamped by Beth Dakin.

  • Platform/CoreIPC/ArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::decodeStringText):

  • Platform/CoreIPC/ArgumentCoders.h:

(CoreIPC::SimpleArgumentCoder::encode):
(CoreIPC::SimpleArgumentCoder::decode):

  • Platform/CoreIPC/ArgumentDecoder.h:

(CoreIPC::ArgumentDecoder::bufferIsLargeEnoughToContain):

  • WebProcess/WebPage/DecoderAdapter.cpp:

(WebKit::DecoderAdapter::decodeString):

  • WebProcess/WebPage/EncoderAdapter.cpp:

(WebKit::EncoderAdapter::encodeString):

1:01 PM Changeset in webkit [158943] by ap@apple.com
  • 10 edits
    14 adds
    1 delete in trunk

Implement JWK key import for HMAC and AES-CBC
https://bugs.webkit.org/show_bug.cgi?id=124059

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: crypto/subtle/aes-cbc-import-jwk.html

crypto/subtle/hmac-import-jwk.html
crypto/subtle/import-jwk.html

WebCrypto supports multiple key formats - raw, pkcs8, spki, jwk. The design is that
we'll transform these into parsed KeyData subclasses before passing to algorithms.

CryptoKeySerialization is a base class for handling all these formats.

  • WebCore.xcodeproj/project.pbxproj: Added new files. Removed CryptoKeyFormat.h.


  • bindings/js/JSCryptoKeySerializationJWK.h: Added.
  • bindings/js/JSCryptoKeySerializationJWK.cpp: Added.

(WebCore::getStringFromJSON): A helper. Note that we can rely on the object being
a nice freshly parsed JSON, no getters or anything.
(WebCore::getBooleanFromJSON): Ditto.
(WebCore::JSCryptoKeySerializationJWK::JSCryptoKeySerializationJWK):
(WebCore::JSCryptoKeySerializationJWK::~JSCryptoKeySerializationJWK):
(WebCore::createHMACParameters): A simple helper.
(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm): WebCrypto API is weird,
you can have algorithm parameters both inside a JWK key and passed as importKey()
arguments. They need to agree, whatever that means for specific serialization's
algorithm options (not all necessarily have a 1-1 matching to WebCrypto).
(WebCore::JSCryptoKeySerializationJWK::reconcileUsages): Take an intersection of usages.
(WebCore::JSCryptoKeySerializationJWK::reconcileExtractable): Only extractable if
both JWK and the caller agree.
(WebCore::JSCryptoKeySerializationJWK::keySizeIsValid): Verify validity of JWK key.
(WebCore::JSCryptoKeySerializationJWK::keyData): Return an appropriate KeyData
subclass.

  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::ENUM_CLASS): Moved CryptoKeyFormat here.
(WebCore::cryptoKeyFormatFromJSValue): Added a human readable string to an exception.
(WebCore::JSSubtleCrypto::importKey): Support multiple key formats, not just raw.

  • crypto/CryptoAlgorithm.cpp: (WebCore::CryptoAlgorithm::importKey):
  • crypto/CryptoAlgorithm.h:

Updated signature for importKey to one that makes more sense. Decoding formats all
the way from a binary blob is not something that CryptoAlgorithm subclasses should
do, we now pass a KeyData subclass instead.
Removed exportKey/wrapKey/unwrapKey altogether, because I don't yet know what the
signatures will be.

  • crypto/CryptoKeyData.h: Added.

(WebCore::CryptoKeyData::ENUM_CLASS):
(WebCore::CryptoKeyData::CryptoKeyData):
(WebCore::CryptoKeyData::~CryptoKeyData):
(WebCore::CryptoKeyData::format):
A base class for passing key material to algorithms. Currently, only one type is
supported, that being OctetSequence for secret keys. Keys for RSA and EC are more
complicated, and secret/public ones are different too.

  • crypto/CryptoKeyFormat.h: Removed. There are too many key format classes

confusingly floating around, and this was only needed in one file for parsing.

  • crypto/CryptoKeySerialization.h: Added.

Base class for handling raw/pkcs8/spki/jwk keys.

  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::importKey):

  • crypto/algorithms/CryptoAlgorithmAES_CBC.h:

Updated to use CryptoKeyData.

  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::importKey):

  • crypto/algorithms/CryptoAlgorithmHMAC.h:

Updated to use CryptoKeyData.

  • crypto/keys/CryptoKeyDataOctetSequence.cpp: Added.

(WebCore::CryptoKeyDataOctetSequence::CryptoKeyDataOctetSequence):
(WebCore::CryptoKeyDataOctetSequence::~CryptoKeyDataOctetSequence):

  • crypto/keys/CryptoKeyDataOctetSequence.h: Added.

(WebCore::asCryptoKeyDataOctetSequence):

  • crypto/keys/CryptoKeySerializationRaw.cpp: Added.

(WebCore::CryptoKeySerializationRaw::CryptoKeySerializationRaw):
(WebCore::CryptoKeySerializationRaw::~CryptoKeySerializationRaw):
(WebCore::CryptoKeySerializationRaw::reconcileAlgorithm):
(WebCore::CryptoKeySerializationRaw::reconcileUsages):
(WebCore::CryptoKeySerializationRaw::reconcileExtractable):
(WebCore::CryptoKeySerializationRaw::keyData):

  • crypto/keys/CryptoKeySerializationRaw.h: Added.

Much code to pass around a Vector<char>.

LayoutTests:

  • crypto/subtle/aes-cbc-import-jwk-expected.txt: Added.
  • crypto/subtle/aes-cbc-import-jwk.html: Added.
  • crypto/subtle/hmac-import-jwk-expected.txt: Added.
  • crypto/subtle/hmac-import-jwk.html: Added.
  • crypto/subtle/import-jwk-expected.txt: Added.
  • crypto/subtle/import-jwk.html: Added.
12:42 PM Changeset in webkit [158942] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add a way to get a WKWebProcessPlugInBrowserContextController from a handle
https://bugs.webkit.org/show_bug.cgi?id=124063

Reviewed by Beth Dakin.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(+[WKWebProcessPlugInBrowserContextController lookUpBrowsingContextFromHandle:]):

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:
12:41 PM Changeset in webkit [158941] by oliver@apple.com
  • 1 edit
    2 deletes in trunk/Source/JavaScriptCore

Remove accidentally added files.

12:27 PM Changeset in webkit [158940] by oliver@apple.com
  • 2 edits
    6 adds in trunk/Source/JavaScriptCore

Fix minor (unobservable) bug in ArrayIterator::next()
https://bugs.webkit.org/show_bug.cgi?id=124061

Reviewed by Beth Dakin.

I noticed this while reading the array iterator code. Due to how
ArrayIterator::next() and our enumeration behaviour is implemented
this is not actually a code path that can be hit. But in order to
future proof this it should be correct.

  • runtime/JSArrayIterator.cpp:

(JSC::arrayIteratorNext):

12:22 PM Changeset in webkit [158939] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

More work on WKBrowsingContextHandle
https://bugs.webkit.org/show_bug.cgi?id=124060

Reviewed by Beth Dakin.

Implement -hash and -isEqual: and add -[WKWebProcessPlugInBrowserContextController handle].

  • Shared/API/Cocoa/WKBrowsingContextHandle.mm:

(-[WKBrowsingContextHandle hash]):
(-[WKBrowsingContextHandle isEqual:]):

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(decodeInvocation):

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController mainFrameDocument]):
(-[WKWebProcessPlugInBrowserContextController selectedRange]):
(-[WKWebProcessPlugInBrowserContextController handle]):

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerInternal.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:
12:06 PM Changeset in webkit [158938] by matthew_hanson@apple.com
  • 2 edits in tags/Safari-538.5/Tools

Unreviewed. Added myself as a committer.

12:03 PM Changeset in webkit [158937] by mark.lam@apple.com
  • 24 edits
    4 adds in trunk/Source

Move breakpoint (and exception break) functionality into JSC::Debugger.
https://bugs.webkit.org/show_bug.cgi?id=121796.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • In ScriptDebugServer and JSC::Debugger, SourceID and BreakpointID are now numeric tokens.
  • JSC::Debugger now tracks user defined breakpoints in a JSC::Breakpoint record. Previously, this info is tracked in the ScriptBreakpoint record in ScriptDebugServer. The only element of ScriptBreakpoint that is not being tracked by JSC::Breakpoint is the ScriptBreakpointAction.

The ScriptBreakpointAction is still tracked by the ScriptDebugServer

in a list keyed on the corresponding BreakpointID.

The ScriptBreakpoint record is now only used as a means of passing

breakpoint paramaters to the ScriptDebugServer.

  • ScriptDebugServer now no longer accesses the JSC::CallFrame* directly. It always goes through the DebuggerCallFrame.

(JSC::Breakpoint::Breakpoint):

  • Breakpoint class to track info for each breakpoint in JSC::Debugger.
  • debugger/Debugger.cpp:

(JSC::DebuggerCallFrameScope::DebuggerCallFrameScope):
(JSC::DebuggerCallFrameScope::~DebuggerCallFrameScope):
(JSC::Debugger::Debugger):
(JSC::Debugger::detach):
(JSC::Debugger::updateNeedForOpDebugCallbacks):
(JSC::Debugger::setBreakpoint):
(JSC::Debugger::removeBreakpoint):
(JSC::Debugger::hasBreakpoint):
(JSC::Debugger::clearBreakpoints):
(JSC::Debugger::setBreakpointsActivated):
(JSC::Debugger::setPauseOnExceptionsState):
(JSC::Debugger::setPauseOnNextStatement):
(JSC::Debugger::breakProgram):
(JSC::Debugger::continueProgram):
(JSC::Debugger::stepIntoStatement):
(JSC::Debugger::stepOverStatement):
(JSC::Debugger::stepOutOfFunction):
(JSC::Debugger::updateCallFrame):
(JSC::Debugger::updateCallFrameAndPauseIfNeeded):
(JSC::Debugger::pauseIfNeeded):
(JSC::Debugger::exception):
(JSC::Debugger::atStatement):
(JSC::Debugger::callEvent):
(JSC::Debugger::returnEvent):
(JSC::Debugger::willExecuteProgram):
(JSC::Debugger::didExecuteProgram):
(JSC::Debugger::didReachBreakpoint):
(JSC::Debugger::currentDebuggerCallFrame):

  • debugger/Debugger.h:
  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::sourceID):
(JSC::DebuggerCallFrame::sourceIDForCallFrame):

  • debugger/DebuggerCallFrame.h:
  • debugger/DebuggerPrimitives.h: Added.
  • define SourceID, noSourceID, BreakpointID, and noBreakpointID.

Source/WebCore:

No new tests.

  • In ScriptDebugServer and JSC::Debugger, SourceID and BreakpointID are now numeric tokens.
  • JSC::Debugger now tracks user defined breakpoints in a JSC::Breakpoint record. Previously, this info is tracked in the ScriptBreakpoint record in ScriptDebugServer. The only element of ScriptBreakpoint that is not being tracked by JSC::Breakpoint is the ScriptBreakpointAction.

The ScriptBreakpointAction is still tracked by the ScriptDebugServer

in a list keyed on the corresponding BreakpointID.

The ScriptBreakpoint record is now only used as a means of passing

breakpoint paramaters to the ScriptDebugServer.

  • ScriptDebugServer now no longer accesses the JSC::CallFrame* directly. It always goes through the DebuggerCallFrame.
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/BreakpointID.h: Added.
  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
(WebCore::ScriptDebugServer::dispatchDidPause):
(WebCore::ScriptDebugServer::dispatchDidContinue):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::notifyDoneProcessingDebuggerEvents):
(WebCore::ScriptDebugServer::needPauseHandling):
(WebCore::ScriptDebugServer::handleBreakpointHit):
(WebCore::ScriptDebugServer::handleExceptionInBreakpointCondition):
(WebCore::ScriptDebugServer::handlePause):

  • bindings/js/ScriptDebugServer.h:
  • bindings/js/SourceID.h: Added.
  • bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):

  • bindings/js/WorkerScriptDebugServer.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::parseLocation):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::clear):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/ScriptDebugListener.h:

Source/WebKit/mac:

  • WebView/WebScriptDebugger.h:
  • WebView/WebScriptDebugger.mm:

(WebScriptDebugger::WebScriptDebugger):
(WebScriptDebugger::handlePause):

11:49 AM Changeset in webkit [158936] by andersca@apple.com
  • 5 edits
    3 copies in trunk/Source/WebKit2

Add A WKBrowsingContextHandle class
https://bugs.webkit.org/show_bug.cgi?id=124058

Reviewed by Sam Weinig.

The WKBrowsingContextHandle class represents a browsing context and can be sent across process boundaries.

  • Shared/API/Cocoa/WKBrowsingContextHandle.h: Added.
  • Shared/API/Cocoa/WKBrowsingContextHandle.mm: Added.

(-[WKBrowsingContextHandle _initWithPageID:]):
(-[WKBrowsingContextHandle encodeWithCoder:]):
(-[WKBrowsingContextHandle initWithCoder:]):
(+[WKBrowsingContextHandle supportsSecureCoding]):

  • Shared/API/Cocoa/WKBrowsingContextHandleInternal.h: Added.
  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController handle]):

  • UIProcess/API/mac/WKBrowsingContextControllerInternal.h:
  • UIProcess/API/mac/WKBrowsingContextControllerPrivate.h:

(NS_ENUM):

  • WebKit2.xcodeproj/project.pbxproj:
11:45 AM Changeset in webkit [158935] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

InspectorConsoleAgent::didFinishXHRLoading ConsoleMessage should include a column number
https://bugs.webkit.org/show_bug.cgi?id=114316

Patch by László Langó <lango@inf.u-szeged.hu> on 2013-11-08
Reviewed by Timothy Hatcher.

InspectorConsoleAgent::didFinishXHRLoading creates a ConsoleMessage with a line number,
but it should also include a column number. It looks like ultimately the line number comes from
JSXMLHttpRequest::send, it should also be possible to get the column number at the time.
The column number would be needed by the Web Inspector to jump to the proper place in source code
to show where the XHR originated from.

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::SendFunctor::SendFunctor):
(WebCore::SendFunctor::column):
(WebCore::SendFunctor::operator()):
(WebCore::JSXMLHttpRequest::send):

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::didFinishXHRLoading):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didFinishXHRLoadingImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didFinishXHRLoading):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::setLastSendLineAndColumnNumber):
(WebCore::XMLHttpRequest::didFinishLoading):

  • xml/XMLHttpRequest.h:
11:38 AM Changeset in webkit [158934] by Simon Fraser
  • 3 edits
    4 adds in trunk

Left sidebar on cubic-bezier.com flickers
https://bugs.webkit.org/show_bug.cgi?id=123128

Source/WebCore:

Reviewed by Dean Jackson.

The logic that determined whether position:fixed elements outside the viewport
should be composited was incorrect if the fixed element also had a transform.

layer.calculateLayerBounds() only takes into account painted transforms (since they
affect layer bounds). So we need to compute the bounds relative to the layer
itself, then use localToContainerQuad() to map them to document coordinates,
but only to the RenderView so that we don't hit the page scale transform.

Tests: compositing/layer-creation/fixed-position-transformed-into-view.html

compositing/layer-creation/fixed-position-transformed-outside-view.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

LayoutTests:

Reviewed by Dean Jackson.

Tests with transformed, fixed elements which dump the layer tree to see
which layers get composited.

  • compositing/layer-creation/fixed-position-transformed-into-view-expected.txt: Added.
  • compositing/layer-creation/fixed-position-transformed-into-view.html: Added.
  • compositing/layer-creation/fixed-position-transformed-outside-view-expected.txt: Added.
  • compositing/layer-creation/fixed-position-transformed-outside-view.html: Added.
11:37 AM Changeset in webkit [158933] by ap@apple.com
  • 2 edits in trunk/Source/WTF

Make base64url decoding actually work
https://bugs.webkit.org/show_bug.cgi?id=124050

Reviewed by Sam Weinig.

  • wtf/text/Base64.cpp: (WTF::base64DecodeInternal): Don't hardcode knowledge about

alphabet, put it into the map.

11:28 AM Changeset in webkit [158932] by oliver@apple.com
  • 2 edits in trunk/LayoutTests

Fix layout test that was actually testing incorrect behaviour.

11:27 AM Changeset in webkit [158931] by Martin Robinson
  • 9 edits in trunk

[MathML] Center of stretched curly bracket not always vertically centered
https://bugs.webkit.org/show_bug.cgi?id=123715

Reviewed by Brent Fulgham.

Source/WebCore:

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::fillWithExtensionGlyph): Update an assertion and
handle the case where two glyph pieces abut.
(WebCore::RenderMathMLOperator::paint): Do not offset the center glyph by y().

LayoutTests:

because MathML is changing rapidly, but we need it to test these changes.

  • mathml/presentation/mo-stretch.html: Update to show stretching characteristics

of all stretchable glyphs.

  • platform/gtk/mathml/presentation/mo-stretch-expected.png:
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt:
11:10 AM Changeset in webkit [158930] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add WKRemoteObjectRegistry to WKConnection
https://bugs.webkit.org/show_bug.cgi?id=124054

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKConnection.h:
  • UIProcess/API/mac/WKConnection.mm:

(-[WKConnection delegate]):
(-[WKConnection setDelegate:]):
(-[WKConnection remoteObjectRegistry]):
(didReceiveMessage):

10:47 AM Changeset in webkit [158929] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Map.forEach crashes on deleted values
https://bugs.webkit.org/show_bug.cgi?id=124017

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

MapData iterator did not consider the case of the first entries
being holes. To fix this I've refactored iteration so that we
can perform an initialisation increment on construction, whle
retaining the useful assertion in MapData::const_iterator::operator++

  • runtime/MapData.h:

(JSC::MapData::const_iterator::operator++):
(JSC::MapData::const_iterator::internalIncrement):
(JSC::MapData::const_iterator::const_iterator):

LayoutTests:

Test case

  • js/map-iterate-first-entry-is-a-hole-expected.txt: Added.
  • js/map-iterate-first-entry-is-a-hole.html: Added.
  • js/script-tests/map-iterate-first-entry-is-a-hole.js: Added.

(set map0):

10:30 AM Changeset in webkit [158928] by jer.noble@apple.com
  • 7 edits
    2 adds in trunk

[MSE] Bring SourceBuffer.append up to the most recent spec.
https://bugs.webkit.org/show_bug.cgi?id=123377

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-append-failed.html

Bring the MediaSource append() implementation up to the current spec.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::appendBufferInternal):
(WebCore::SourceBuffer::appendBufferTimerFired):

  • platform/graphics/SourceBufferPrivate.h:
  • platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockSourceBufferPrivate::append):
(WebCore::MockSourceBufferPrivate::evictCodedFrames):
(WebCore::MockSourceBufferPrivate::isFull):

  • platform/mock/mediasource/MockSourceBufferPrivate.h:

LayoutTests:

  • media/media-source/media-source-append-failed-expected.txt: Added.
  • media/media-source/media-source-append-failed.html: Added.
  • media/media-source/mock-media-source.js:
10:28 AM Changeset in webkit [158927] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Encode and decode NSURLRequests using NSCoder
https://bugs.webkit.org/show_bug.cgi?id=124051

Reviewed by Sam Weinig.

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::archiveAndEncodeObject):
(CoreIPC::decodeAndUnarchiveObject):
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

10:25 AM Changeset in webkit [158926] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

REGRESSION(r158883): Fix crashes for ARM architecture.
https://bugs.webkit.org/show_bug.cgi?id=124038

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Michael Saboff.

  • jit/GPRInfo.h: Remove r11 from the temporary register set, use a free register for

nonPreservedNonReturnGPR and remove obsolete declaration of bucketCounterRegister.
(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):

  • jit/JITOperations.cpp: Frame pointer register is r11 for ARM_TRADITIONAL and

r7 for ARM_THUMB2 instead of r5 since r158883.

10:24 AM Changeset in webkit [158925] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

REGRESSION(r158883): Fix crashes for MIPS architecture.
https://bugs.webkit.org/show_bug.cgi?id=124044

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Michael Saboff.

  • jit/JITOperations.cpp: Frame pointer register is fp instead of s0 since r158883 for MIPS.
  • jit/ThunkGenerators.cpp: Save and restore the new frame pointer register.

(JSC::returnFromJavaScript):
(JSC::callToJavaScript):

10:03 AM Changeset in webkit [158924] by Chris Fleizach
  • 3 edits in branches/safari-537.73-branch/LayoutTests

Fix up failing layout tests that in branch due to recent accessibility patches.

Unreviewed.

  • media/track/track-in-band-mode-expected.txt:
  • platform/mac/accessibility/listitem-title-expected.txt:
9:55 AM Changeset in webkit [158923] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

[Mac] Crash at com.apple.WebCore: WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange + 26
https://bugs.webkit.org/show_bug.cgi?id=124031

Reviewed by Eric Carlson.

WTF::bind() causes errors when given a bare id pointer as a parameter,
when that parameter is casted to a specific NS type pointer (in this
case, a NSArray*) in order to pass it as a parameter to the bound
function.

Instead of passing around bare id pointers, wrap them in RetainPtr<>
objects before passing them to WTF::bind().

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::loadedTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):

9:31 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
9:12 AM Changeset in webkit [158922] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Win] JavaScript crash in getHostCallReturnValue.
https://bugs.webkit.org/show_bug.cgi?id=124040

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-08
Reviewed by Geoffrey Garen.

  • jit/JITOperations.cpp: Update MSVC assembler code in getHostCallReturnValue according to gcc x86 version.
7:27 AM Changeset in webkit [158921] by Michał Pakuła vel Rutka
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Add test expectations for failing tests.

  • platform/efl/TestExpectations:
6:57 AM Changeset in webkit [158920] by Antti Koivisto
  • 1 edit
    1 add in trunk/PerformanceTests

Add line layout performance test that exercises more cases
https://bugs.webkit.org/show_bug.cgi?id=124041

Reviewed by Anders Carlsson.

The existing line-layout.html covers the most basic left-aligned case only.
Add a test with more coverage for things that are mostly not yet supported by the simple
line layout path:

  • centered text
  • right aligned text
  • justified text
  • pre
  • white-space:pre-wrap
  • text with simple inlines
  • text with br
  • Layout/line-layout-simple.html: Added.
6:42 AM Changeset in webkit [158919] by commit-queue@webkit.org
  • 6 edits
    5 copies
    3 adds
    5 deletes in trunk/LayoutTests

[GTK] Add new GTK-specific layout test results for vertical text
https://bugs.webkit.org/show_bug.cgi?id=124000

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-11-08
Reviewed by Mario Sanchez Prada.

Rebaselined some expected results for tests that use vertical text.
These tests are now working fine after the fix from Bug 50619.
They have specific results for WebKit2 GTK+ because WebKit1 has a
permanent area in the bottom for the horizontal scroll bar.
This area reduces the layout area in WebKit1 and consequently the
results differ from WebKit2.

  • fast/repaint/japanese-rl-selection-clear-expected.txt:
  • fast/repaint/japanese-rl-selection-repaint-expected.txt:
  • fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • fast/text/international/vertical-text-glyph-test-expected.txt:
  • fast/text/justify-ideograph-vertical-expected.txt:
  • platform/efl/fast/repaint/japanese-rl-selection-clear-expected.txt: Removed.
  • platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.txt: Removed.
  • platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Removed.
  • platform/efl/fast/text/international/vertical-text-glyph-test-expected.txt: Removed.
  • platform/efl/fast/text/justify-ideograph-vertical-expected.txt: Removed.
  • platform/gtk-wk2/fast/repaint/japanese-rl-selection-clear-expected.txt: Copied from LayoutTests/fast/repaint/japanese-rl-selection-clear-expected.txt.
  • platform/gtk-wk2/fast/repaint/japanese-rl-selection-repaint-expected.txt: Copied from LayoutTests/fast/repaint/japanese-rl-selection-repaint-expected.txt.
  • platform/gtk-wk2/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Copied from LayoutTests/fast/repaint/repaint-across-writing-mode-boundary-expected.txt.
  • platform/gtk-wk2/fast/text/international/vertical-text-glyph-test-expected.txt: Copied from LayoutTests/fast/text/international/vertical-text-glyph-test-expected.txt.
  • platform/gtk-wk2/fast/text/justify-ideograph-vertical-expected.txt: Copied from LayoutTests/fast/text/justify-ideograph-vertical-expected.txt.
4:53 AM Changeset in webkit [158918] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Templated LChar/UChar paths for simple line layout
https://bugs.webkit.org/show_bug.cgi?id=124035

Reviewed by Andreas Kling.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForText):
(WebCore::SimpleLineLayout::canUseFor):

Use a templated function to check for illegal characters.

(WebCore::SimpleLineLayout::skipWhitespaces):

Make a template function.

(WebCore::SimpleLineLayout::textWidth):

Make a template function plus some argument changes.

(WebCore::SimpleLineLayout::createTextRuns):

Template function for creating runs while operating with either LChars or UChar.
Also simplified line breaking and text width measuring logic.

(WebCore::SimpleLineLayout::create):

Pick the template.

  • rendering/break_lines.cpp:
  • rendering/break_lines.h:


Move the implementation to the header (except for the table) so we can use the template
versions directly.

(WebCore::isBreakableSpace):
(WebCore::shouldBreakAfter):
(WebCore::needsLineBreakIterator):
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):

4:16 AM Changeset in webkit [158917] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] accessibility/aria-link-supports-press.html
https://bugs.webkit.org/show_bug.cgi?id=111987

Unreviewed EFL gardening, passes after r158913.

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-08

  • platform/efl-wk1/TestExpectations: test is no longer failing.
  • platform/efl-wk2/TestExpectations: test is no longer failing.
3:26 AM Changeset in webkit [158916] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

[mips] Fix typo (introduced in r158751).
https://bugs.webkit.org/show_bug.cgi?id=124033.

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Csaba Osztrogonác.

  • jit/ThunkGenerators.cpp:

(JSC::callToJavaScript):

3:22 AM Changeset in webkit [158915] by Csaba Osztrogonác
  • 4 edits in trunk/Source/JavaScriptCore

[arm] Use specific PatchableJump implementation for CPU(ARM_TRADITIONAL).
https://bugs.webkit.org/show_bug.cgi?id=123891

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-08
Reviewed by Michael Saboff.

Although patchableBranch32 is implemented in MacroAssemblerARM.h, the used implementation
is the generic one in MacroAssembler.h. This patch fixes it and also implements the
patchableJump() function for CPU(ARM_TRADITIONAL). These specific implementations are
needed for this architecture backend to ensure that these jumps can be relinked.

  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::patchableJump):

  • jit/GPRInfo.h: Remove static_cast that are generating warnings in debug builds.

(JSC::GPRInfo::toIndex):
(JSC::GPRInfo::debugName):

2:55 AM Changeset in webkit [158914] by mario@webkit.org
  • 9 edits in trunk

AX: [ATK] <span> elements exposed through ATK when not needed
https://bugs.webkit.org/show_bug.cgi?id=123885

Reviewed by Chris Fleizach.

Source/WebCore:

As per SVN r158195, the way it's decided whether <span> elements
should be ignored or not has slightly changed, causing that the
GTK/EFL ports expose them in cases that they should be ignored,
such as for text elements that neither are focusable (e.g. by
explicitly setting tabindex) nor have a meaningful accessible name
suggesting they should be exposed.

As a result, the flattening that ATK based ports normally do for
this kind of elements (by folding them into their parents) do not
work correctly anymore, making two tests to fail:

platform/gtk/accessibility/spans-paragraphs-and-divs.html
platform/gtk/accessibility/spans.html

This patch encapsulates the part of the logic that affects this in
the computeAccessibilityIsIgnored() method, placing it in a
new method of AccessibilityObject that we can call from ATK's
accessibilityPlatformIncludesObject() to ensure we hide those
<span> elements when they don't fulfill those requirements.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::hasAttributesRequiredForInclusion):
New virtual method encapsulating part of the logic from the function
that computes whether accessibility should be ignored or not.

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::hasAttributesRequiredForInclusion):
Override of the new method adding additional checks, as extracted from
the original bits in computeAccessibilityIsIgnored().

  • accessibility/AccessibilityNodeObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
Use the newly added function where we had the original code before.

  • accessibility/atk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Make sure <span> elements are ignored if they are not focusable
and they don't have a meaningful accessible name.

LayoutTests:

Removed failure expectations for tests now passing.

  • platform/gtk/TestExpectations: Removed expectations.
2:24 AM Changeset in webkit [158913] by commit-queue@webkit.org
  • 5 edits in trunk

[GTK] accessibility/aria-link-supports-press.html is failing
https://bugs.webkit.org/show_bug.cgi?id=98355

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-08
Reviewed by Mario Sanchez Prada.

Tools:

Checking "jump" action for link elements. Action "jump" occurs when a link
element is pressed/clicked.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::isPressActionSupported):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::isPressActionSupported):

LayoutTests:

Removed failure expectation.

  • platform/gtk/TestExpectations: test is no longer failing.
1:43 AM Changeset in webkit [158912] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[JHBUILD] Jhbuild Makefile build bug workaround
https://bugs.webkit.org/show_bug.cgi?id=123971

Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2013-11-08
Reviewed by Ryosuke Niwa.

After Jhbuild repository is cloned (for instance when you use
Tools/Scripts/update-webkitefl-libs) it is built from sources.
If you have GREP_OPTIONS grep env variable set (for instance
GREP_OPTIONS=-n) then it is jhbuild build error. Makefile.plain
uses shell grep. For specific GREP_OPTIONS grep output will be
different than expected one by Jhbuild and there is an error
with Jhbuild build. Jhbuild will not be built and then WebKit
source also will not be built. This patch is a workaround to this
issue. It disables GREP_OPTIONS for Jhbuild build time.

  • jhbuild/jhbuild-wrapper:

(install_jhbuild):

1:06 AM Changeset in webkit [158911] by akling@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Add back expectation for test that went missing in r158813.

  • svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
12:16 AM Changeset in webkit [158910] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

[GTK] Add missing symbols to WebKitDOMEventTarget.symbols
https://bugs.webkit.org/show_bug.cgi?id=123990

Reviewed by Philippe Normand.

Add webkit_dom_event_target_add_event_listener_with_closure and
webkit_dom_event_target_remove_event_listener_with_closure to the
symbols files.

  • bindings/gobject/WebKitDOMEventTarget.symbols:
  • bindings/gobject/webkitdom.symbols:
12:14 AM Changeset in webkit [158909] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Ignore deprecated macros when generating gtk-doc
https://bugs.webkit.org/show_bug.cgi?id=123988

Reviewed by Philippe Normand.

  • gtk/generate-gtkdoc:

(get_common_options): Ignore also WEBKIT_DEPRECATED and
WEBKIT_DEPRECATED_FOR decorators.

12:12 AM Changeset in webkit [158908] by Carlos Garcia Campos
  • 3 edits in trunk/Tools

[GTK] Pass the library namespace to gtkdoc-mkdb
https://bugs.webkit.org/show_bug.cgi?id=123900

Reviewed by Martin Robinson.

This fixes the generation of the index of symbols in the API
documentation.

  • gtk/generate-gtkdoc:

(get_webkit2_options): Define namespace as WebKit.
(get_webkit1_options): Ditto.
(get_webkitdom_options): Define namespace as WebKitDOM.

  • gtk/gtkdoc.py:

(GTKDoc.init): Add namespace option.
(GTKDoc._run_gtkdoc_mkdb): Pass namespace to mkdb if present.

12:09 AM Changeset in webkit [158907] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebCore

[GTK] Use deprecation guards around deprecated API in GObject DOM bindings
https://bugs.webkit.org/show_bug.cgi?id=123899

Reviewed by Martin Robinson.

Do not include deprecated API when compiling with
WEBKIT_DISABLE_DEPRECATED option.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction):

  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:

Nov 7, 2013:

10:08 PM Changeset in webkit [158906] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Enhance SQL journal_mode setting code to be less likely to log an error.
<rdar://problem/15418577> and https://bugs.webkit.org/show_bug.cgi?id=124018

Reviewed by Anders Carlsson.

Even though the docs says SQLITE_ROW will always be returned, apparently SQLITE_OK is sometimes returned.
Change the code to handle that.

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::open): Save the statement result value, and accept SQLITE_OK as a non-error condition.

9:52 PM Changeset in webkit [158905] by gyuyoung.kim@samsung.com
  • 33 edits
    1 copy
    7 adds
    4 deletes in trunk/LayoutTests

[EFL] Layout tests with vertical texts need to be rebaselined
https://bugs.webkit.org/show_bug.cgi?id=123985

Unreviewed, EFL port needs to do rebaseline since r158848.

  • platform/efl-wk1/fast/text/international/text-combine-image-test-expected.txt: Removed.
  • platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
  • platform/efl-wk2/fast/text/international/text-combine-image-test-expected.txt: Removed.
  • platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.
  • platform/efl/TestExpectations:
  • platform/efl/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
  • platform/efl/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
  • platform/efl/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
  • platform/efl/fast/block/lineboxcontain/block-with-ideographs-expected.txt:
  • platform/efl/fast/dynamic/text-combine-expected.txt:
  • platform/efl/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
  • platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
  • platform/efl/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
  • platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • platform/efl/fast/ruby/base-shorter-than-text-expected.txt:
  • platform/efl/fast/text/decorations-with-text-combine-expected.txt:
  • platform/efl/fast/text/emphasis-combined-text-expected.txt:
  • platform/efl/fast/text/emphasis-vertical-expected.txt:
  • platform/efl/fast/text/international/text-combine-image-test-expected.txt: Added.
  • platform/efl/fast/text/international/text-spliced-font-expected.txt:
  • platform/efl/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
  • platform/efl/fast/text/justify-ideograph-vertical-expected.txt: Added.
  • platform/efl/fast/text/orientation-sideways-expected.txt:
  • platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
  • platform/efl/fast/writing-mode/border-vertical-lr-expected.txt:
  • platform/efl/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
  • platform/efl/fast/writing-mode/broken-ideographic-font-expected.txt:
  • platform/efl/fast/writing-mode/fallback-orientation-expected.txt:
  • platform/efl/fast/writing-mode/japanese-lr-selection-expected.txt:
  • platform/efl/fast/writing-mode/japanese-lr-text-expected.txt:
  • platform/efl/fast/writing-mode/japanese-rl-selection-expected.txt:
  • platform/efl/fast/writing-mode/japanese-rl-text-expected.txt:
  • platform/efl/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt:
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
  • platform/efl/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
  • platform/efl/fast/writing-mode/text-orientation-basic-expected.txt:
  • platform/efl/fast/writing-mode/vertical-align-table-baseline-expected.txt:
  • platform/efl/fast/writing-mode/vertical-baseline-alignment-expected.txt:
  • platform/efl/fast/writing-mode/vertical-font-fallback-expected.txt:
9:40 PM Changeset in webkit [158904] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Update an out-dated ASSERT in IconDatabase code.
<rdar://problem/15171118> and https://bugs.webkit.org/show_bug.cgi?id=124030.

Reviewed by Andreas Kling.

With the asynchronous interfaces that have been added and the support for WK2 that has been added,
this ASSERT can incorrectly fire if an icon is asked for before database cleanup is allowed.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::synchronousIconForPageURL): Update an invalid ASSERT.

9:24 PM Changeset in webkit [158903] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

RenderSVGResource helpers should take RenderStyle by const reference.
<https://webkit.org/b/124029>

Take const RenderStyle& instead of RenderStyle* in a few more places
so we can get rid of some ampersands and assertions.

Reviewed by Anders Carlsson.

9:21 PM Changeset in webkit [158902] by gyuyoung.kim@samsung.com
  • 11 edits in trunk/Source/WebCore

[AX] Generate toAccessibilityTableRow|Column|Cell to detect bad type casts
https://bugs.webkit.org/show_bug.cgi?id=123984

Reviewed by Mario Sanchez Prada.

As a step to let static_cast<> use TYPE_CASTS_BASE, AccessibilityTableRow|Column|Cell use
ACCESSIBILITY_OBJECT_TYPE_CASTS which can support more helper functions rather than manual
static_cast<>. This change will help to detect bad type casts further.

No new tests, no behavior changes.

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addTableCellChild):
(WebCore::AccessibilityARIAGrid::addChildren):

  • accessibility/AccessibilityARIAGridCell.cpp:

(WebCore::AccessibilityARIAGridCell::rowIndexRange):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::rowHeaders):
(WebCore::AccessibilityTable::columnHeaders):
(WebCore::AccessibilityTable::cellForColumnAndRow):

  • accessibility/AccessibilityTableCell.h:
  • accessibility/AccessibilityTableColumn.h:
  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::headerObject):

  • accessibility/AccessibilityTableRow.h:
  • accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(cellAtIndex):
(webkitAccessibleTableGetColumnHeader):
(webkitAccessibleTableGetRowHeader):

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper tableCellParent]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

8:05 PM Changeset in webkit [158901] by mark.lam@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

Get rid of the regT* definitions in JSInterfaceJIT.h.
https://bugs.webkit.org/show_bug.cgi?id=123806.

Reviewed by Geoffrey Garen.

JSInterfaceJIT now inherits from GPRInfo and FPRInfo, and relies on them
to provide all the register definitions.

  • jit/GPRInfo.h:

(JSC::GPRInfo::toArgumentRegister):

  • jit/JIT.cpp:

(JSC::JIT::emitEnterOptimizationCheck):
(JSC::JIT::privateCompile):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_compareAndJumpSlow):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_compareAndJumpSlow):

  • jit/JITCall.cpp:

(JSC::JIT::compileLoadVarargs):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileLoadVarargs):

  • jit/JITInlines.h:

(JSC::JIT::appendCallWithExceptionCheckSetJSValueResult):
(JSC::JIT::appendCallWithExceptionCheckSetJSValueResultWithProfile):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_end):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):
(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emitSlow_op_get_argument_by_val):
(JSC::JIT::emitSlow_op_loop_hint):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall):
(JSC::JIT::emit_op_end):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emitSlow_op_jfalse):
(JSC::JIT::emitSlow_op_jtrue):
(JSC::JIT::emitSlow_op_eq):
(JSC::JIT::emitSlow_op_neq):
(JSC::JIT::emit_op_throw):
(JSC::JIT::emit_op_get_pnames):
(JSC::JIT::emit_op_switch_imm):
(JSC::JIT::emit_op_switch_char):
(JSC::JIT::emit_op_switch_string):
(JSC::JIT::emit_op_create_activation):
(JSC::JIT::emit_op_create_arguments):
(JSC::JIT::emitSlow_op_get_argument_by_val):

  • jit/JSInterfaceJIT.h:

(JSC::JSInterfaceJIT::JSInterfaceJIT):

  • jit/SlowPathCall.h:

(JSC::JITSlowPathCall::call):

  • jit/ThunkGenerators.cpp:
7:55 PM Changeset in webkit [158900] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r154375): Image is oriented incorrectly
https://bugs.webkit.org/show_bug.cgi?id=123831

Reviewed by Antonio Gomes.

r154375 made that shouldRespectImageOrientation() isn't used by drawImage().
It causes an image isn't oriented correctly. This patch sets shouldRespectImageOrientation()
value by default.

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):

7:54 PM Changeset in webkit [158899] by gyuyoung.kim@samsung.com
  • 1 edit
    22 deletes in trunk/LayoutTests

Unreviewed, rolling out r158846.
http://trac.webkit.org/changeset/158846

r158846 was duplicating gardening against r158837.

  • platform/efl/fullscreen/video-controls-override-expected.txt: Removed.
  • platform/efl/http/tests/media/video-cookie-expected.txt: Removed.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_2-expected.txt: Removed.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Removed.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Removed.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Removed.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_3-expected.txt: Removed.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_4-expected.txt: Removed.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Removed.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Removed.
  • platform/efl/media/context-menu-actions-expected.txt: Removed.
  • platform/efl/media/media-can-play-flac-audio-expected.txt: Removed.
  • platform/efl/media/media-can-play-webm-expected.txt: Removed.
  • platform/efl/media/media-volume-slider-rendered-below-expected.txt: Removed.
  • platform/efl/media/media-volume-slider-rendered-normal-expected.txt: Removed.
  • platform/efl/media/track/audio/audio-track-mkv-vorbis-addtrack-expected.txt: Removed.
  • platform/efl/media/track/audio/audio-track-mkv-vorbis-enabled-expected.txt: Removed.
  • platform/efl/media/track/track-cue-mutable-text-expected.txt: Removed.
  • platform/efl/media/track/track-cue-rendering-mode-changed-expected.txt: Removed.
  • platform/efl/media/track/track-language-preference-expected.txt: Removed.
  • platform/efl/media/track/video/video-track-mkv-theora-addtrack-expected.txt: Removed.
  • platform/efl/media/track/video/video-track-mkv-theora-selected-expected.txt: Removed.
  • platform/efl/media/video-controls-fullscreen-volume-expected.txt: Removed.
  • platform/efl/media/video-controls-toggling-expected.txt: Removed.
7:50 PM Changeset in webkit [158898] by hmuller@adobe.com
  • 3 edits
    2 adds in trunk

[CSS Shapes] Image shape-outside with vertical gaps is handled incorrectly
https://bugs.webkit.org/show_bug.cgi?id=123934

Reviewed by Andreas Kling.

Source/WebCore:

RasterShapeIntervals::getExcludedIntervals() was returning an empty
list when the line overlapped any vertical gap in the image. This short-circuit
had been mistakenly copied from getIncludedIntervals(), where it makes sense.

Test: fast/shapes/shape-outside-floats/shape-outside-floats-image-vgap.html

  • rendering/shapes/RasterShape.cpp:

(WebCore::RasterShapeIntervals::getExcludedIntervals):

LayoutTests:

  • fast/shapes/shape-outside-floats/shape-outside-floats-image-vgap-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-image-vgap.html: Added.
7:07 PM Changeset in webkit [158897] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Make contents layer borders more visible
https://bugs.webkit.org/show_bug.cgi?id=124025

Reviewed by Tim Horton.

Layer borders for contents layers are impossible to see when the
contentsLayer has the same bounds as its parent; make the contents
layer border 4px thick to make it more visible.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setupContentsLayer):

6:57 PM Changeset in webkit [158896] by akling@apple.com
  • 1 edit
    31 moves
    1 add
    36 deletes in trunk/LayoutTests

Optimize baselines: svg/filters

Unreviewed; run "webkit-patch optimize-baselines svg/filters"

  • platform/gtk/svg/filters/animate-fill-expected.png: Removed.
  • platform/gtk/svg/filters/feColorMatrix-default-type-expected.png: Removed.
  • platform/gtk/svg/filters/feColorMatrix-offset-expected.png: Removed.
  • platform/gtk/svg/filters/feColorMatrix-values-expected.png: Removed.
  • platform/gtk/svg/filters/feComposite-expected.txt: Removed.
  • platform/gtk/svg/filters/feDisplacementMap-expected.txt: Removed.
  • platform/gtk/svg/filters/feDropShadow-subregion-expected.png: Removed.
  • platform/gtk/svg/filters/feDropShadow-zero-deviation-expected.png: Removed.
  • platform/gtk/svg/filters/feDropShadow-zero-deviation-expected.txt: Removed.
  • platform/gtk/svg/filters/feGaussianBlur-subregion-expected.png: Removed.
  • platform/gtk/svg/filters/feGaussianBlur-zero-deviation-expected.png: Removed.
  • platform/gtk/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Removed.
  • platform/gtk/svg/filters/feImage-change-target-id-expected.png: Removed.
  • platform/gtk/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt: Removed.
  • platform/gtk/svg/filters/feImage-remove-target-expected.png: Removed.
  • platform/gtk/svg/filters/feLighting-crash-expected.png: Removed.
  • platform/gtk/svg/filters/feMerge-wrong-input-expected.png: Removed.
  • platform/gtk/svg/filters/filter-empty-g-expected.png: Removed.
  • platform/gtk/svg/filters/filter-hidden-content-expected.txt: Removed.
  • platform/gtk/svg/filters/filter-on-filter-for-text-expected.png: Removed.
  • platform/gtk/svg/filters/filter-on-filter-for-text-expected.txt: Removed.
  • platform/gtk/svg/filters/filter-on-tspan-expected.txt: Removed.
  • platform/gtk/svg/filters/filter-refresh-expected.png: Removed.
  • platform/gtk/svg/filters/filter-rounding-issues-expected.png: Removed.
  • platform/gtk/svg/filters/filter-width-update-expected.txt: Removed.
  • platform/gtk/svg/filters/filterRes-expected.txt: Removed.
  • platform/gtk/svg/filters/filterRes2-expected.png: Removed.
  • platform/gtk/svg/filters/filteredImage-expected.png: Removed.
  • platform/gtk/svg/filters/sourceAlpha-expected.png: Removed.
  • platform/gtk/svg/filters/sourceAlpha-expected.txt: Removed.
  • platform/mac/svg/filters/feDisplacementMap-expected.txt: Removed.
  • platform/mac/svg/filters/feDropShadow-zero-deviation-expected.txt: Removed.
  • platform/mac/svg/filters/feGaussianBlur-zero-deviation-expected.txt: Removed.
  • platform/mac/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt: Removed.
  • platform/mac/svg/filters/filter-hidden-content-expected.txt: Removed.
  • platform/mac/svg/filters/filterRes-expected.txt: Removed.
  • platform/win-future/svg/filters/feImage-reference-svg-primitive-expected.png: Renamed from LayoutTests/svg/filters/feImage-reference-svg-primitive-expected.png.
  • svg/filters/animate-fill-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/animate-fill-expected.png.
  • svg/filters/feColorMatrix-default-type-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feColorMatrix-default-type-expected.png.
  • svg/filters/feColorMatrix-offset-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feColorMatrix-offset-expected.png.
  • svg/filters/feColorMatrix-values-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feColorMatrix-values-expected.png.
  • svg/filters/feComposite-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feComposite-expected.txt.
  • svg/filters/feDisplacementMap-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feDisplacementMap-expected.txt.
  • svg/filters/feDropShadow-subregion-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feDropShadow-subregion-expected.png.
  • svg/filters/feDropShadow-zero-deviation-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feDropShadow-zero-deviation-expected.png.
  • svg/filters/feDropShadow-zero-deviation-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feDropShadow-zero-deviation-expected.txt.
  • svg/filters/feGaussianBlur-subregion-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feGaussianBlur-subregion-expected.png.
  • svg/filters/feGaussianBlur-zero-deviation-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feGaussianBlur-zero-deviation-expected.png.
  • svg/filters/feGaussianBlur-zero-deviation-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feGaussianBlur-zero-deviation-expected.txt.
  • svg/filters/feImage-change-target-id-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feImage-change-target-id-expected.png.
  • svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.txt.
  • svg/filters/feImage-remove-target-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feImage-remove-target-expected.png.
  • svg/filters/feLighting-crash-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feLighting-crash-expected.png.
  • svg/filters/feMerge-wrong-input-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/feMerge-wrong-input-expected.png.
  • svg/filters/filter-empty-g-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filter-empty-g-expected.png.
  • svg/filters/filter-hidden-content-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filter-hidden-content-expected.txt.
  • svg/filters/filter-on-filter-for-text-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filter-on-filter-for-text-expected.png.
  • svg/filters/filter-on-filter-for-text-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filter-on-filter-for-text-expected.txt.
  • svg/filters/filter-on-tspan-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filter-on-tspan-expected.txt.
  • svg/filters/filter-refresh-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filter-refresh-expected.png.
  • svg/filters/filter-rounding-issues-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filter-rounding-issues-expected.png.
  • svg/filters/filter-width-update-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filter-width-update-expected.txt.
  • svg/filters/filterRes-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/filterRes-expected.txt.
  • svg/filters/filterRes2-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filterRes2-expected.png.
  • svg/filters/filteredImage-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/filteredImage-expected.png.
  • svg/filters/sourceAlpha-expected.png: Renamed from LayoutTests/platform/efl/svg/filters/sourceAlpha-expected.png.
  • svg/filters/sourceAlpha-expected.txt: Renamed from LayoutTests/platform/efl/svg/filters/sourceAlpha-expected.txt.
6:47 PM Changeset in webkit [158895] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Encode and decode NSURLResponse objects using NSCoder
https://bugs.webkit.org/show_bug.cgi?id=124028

Reviewed by Andreas Kling.

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

6:43 PM Changeset in webkit [158894] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

InlineFlowBox always has a RenderBoxModelObject, take advantage.
<https://webkit.org/b/124024>

Since InlineFlowBox already has the branch-less renderer() returning
a RenderBoxModelObject&, avoid using InlineBox::boxModelObject()
wherever we have a tightly-typed box. One branch disappears from
every call site.

Deleted boxModelObject() on InlineFlowBox to prevent new code from
calling the less efficient function.

Reviewed by Anders Carlsson.

6:41 PM Changeset in webkit [158893] by akling@apple.com
  • 12 edits in trunk/Source/WebCore

CTTE: Scrolling tree nodes should always have a ScrollingTree&.
<https://webkit.org/b/124022>

Let ScrollingTreeNode and subclasses store the backpointer to the
tree as a ScrollingTree& reference.

Reviewed by Anders Carlsson.

6:22 PM Changeset in webkit [158892] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Move m_destinationID to MessageDecoder
https://bugs.webkit.org/show_bug.cgi?id=124026

Reviewed by Andreas Kling.

  • Platform/CoreIPC/ArgumentDecoder.h:
  • Platform/CoreIPC/MessageDecoder.h:

(CoreIPC::MessageDecoder::destinationID):

5:55 PM Changeset in webkit [158891] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

FTL should support NewArray
https://bugs.webkit.org/show_bug.cgi?id=124010

Reviewed by Oliver Hunt.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNewObject):
(JSC::FTL::LowerDFGToLLVM::compileNewArray):
(JSC::FTL::LowerDFGToLLVM::allocateCell):
(JSC::FTL::LowerDFGToLLVM::allocateObject):
(JSC::FTL::LowerDFGToLLVM::allocateBasicStorageAndGetEnd):
(JSC::FTL::LowerDFGToLLVM::ArrayValues::ArrayValues):
(JSC::FTL::LowerDFGToLLVM::allocateJSArray):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::loadDouble):
(JSC::FTL::Output::storeDouble):

5:54 PM Changeset in webkit [158890] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Get rid of the out-of-line memory attachment type
https://bugs.webkit.org/show_bug.cgi?id=124023

Reviewed by Andreas Kling.

We're only using out-of-line memory for when the message body is too big, so
isolate that code in Connection and get rid of the out of line attachment type.

  • Platform/CoreIPC/Attachment.cpp:

(CoreIPC::Attachment::Attachment):

  • Platform/CoreIPC/Attachment.h:

(CoreIPC::Attachment::port):
(CoreIPC::Attachment::disposition):

  • Platform/CoreIPC/mac/ConnectionMac.cpp:

(CoreIPC::Connection::sendOutgoingMessage):
(CoreIPC::createMessageDecoder):

5:42 PM Changeset in webkit [158889] by Simon Fraser
  • 5 edits in trunk/Source

Lots of layers get solid color but transparent contents layers now
https://bugs.webkit.org/show_bug.cgi?id=123537

Source/WebCore:

Reviewed by Tim Horton.

We call rendererBackgroundColor() to determine the layer's background color,
but on most elements this returns the transparent color (a valid color).
This caused us to allocate a contentsLayer, and use the transparent color as its
backgroundColor, which was wasteful.

Fix by only making a background-color layer if the color is not transparent (zero alpha).

Also avoid making a new contents layer on every color change, and make sure that
we don't do implicit animations for backgroundColor, and some other properties
that were omitted by mistake.

Layer tree dumps don't dump content layers, so no way to test easily.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setContentsToSolidColor):

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(nullActionsDictionary):

Source/WebKit2:

Reviewed by Tim Horton.

Add some properties to the list of things not to implicitly animate.

  • Shared/mac/RemoteLayerTreePropertyApplier.mm:

(WebKit::RemoteLayerTreePropertyApplier::disableActionsForLayer):

5:29 PM Changeset in webkit [158888] by Lucas Forschler
  • 2 edits in tags/Safari-538.5/Source/WebCore

Merge r158869 for <rdar://problem/15406440>.

5:12 PM Changeset in webkit [158887] by roger_fong@apple.com
  • 3 edits in branches/safari-537.60-branch/Source/WebKit

Unreviewed. Windows WebKit makefile fixes.

No need to copy over WebKit.resources.

  • WebKit.vcxproj/WebKit.make:
  • WebKit.vcxproj/WebKit/WebKitPostBuild.cmd:
5:12 PM Changeset in webkit [158886] by Chris Fleizach
  • 6 edits in branches/safari-537.73-branch/LayoutTests

Fix up failing layout tests that referenced wrong paths (due to ToT changes).

Unreviewed.

  • accessibility/negative-tabindex-does-not-expose-label.html:
  • media/track/track-cue-rendering-mode-changed-expected.txt:
  • platform/mac/accessibility/native-list-item-should-not-expose-label.html:
  • platform/mac/accessibility/object-replacement-with-no-rendered-children-at-node-start.html:
  • platform/mac/accessibility/object-replacement-with-rendered-children-at-node-start.html:
5:07 PM Changeset in webkit [158885] by roger_fong@apple.com
  • 3 edits in trunk/Source/WebKit

Unreviewed. Windows WebKit makefile fixes.

No need to copy over WebKit.resources.

  • WebKit.vcxproj/WebKit.make:
  • WebKit.vcxproj/WebKit/WebKitPostBuild.cmd:
3:46 PM Changeset in webkit [158884] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebKit

Remove a PLATFORM(IOS) from WebKit Private Header
https://bugs.webkit.org/show_bug.cgi?id=124014

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-07
Reviewed by Timothy Hatcher.

Source/WebKit/ios:

  • WebKit.iOS.exp:

Source/WebKit/mac:

Make the previously iOS only WebInspectorDidStartSearchingForNode
and WebInspectorDidStopSearchingForNode notifications non iOS specific.

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::didSetSearchingForNode):

  • WebInspector/WebInspector.h:
  • WebInspector/WebInspector.mm:
  • WebKit.exp:
3:45 PM Changeset in webkit [158883] by msaboff@apple.com
  • 14 edits in trunk/Source/JavaScriptCore

Change CallFrameRegister to architected frame pointer register
https://bugs.webkit.org/show_bug.cgi?id=123956

Reviewed by Geoffrey Garen.

Changed X86 and ARM variants as well as MIPS to use their respective architected
frame pointer registers. The freed up callFrameRegisteris are made available to
the DFG register allocator. Modified the FTL OSR exit compiler to use a temporary
register as a stand in for the destination callFrameRegister since the FTL frame
pointer register is needed to extract values from the FTL stack.

Reviewed by Geoffrey Garen.

  • assembler/ARMAssembler.h:
  • assembler/ARMv7Assembler.h:
  • assembler/MacroAssemblerMIPS.h:
  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::addressFor):

  • jit/GPRInfo.h:

(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):

  • jit/JITOperations.cpp:
  • jit/JSInterfaceJIT.h:
  • jit/ThunkGenerators.cpp:

(JSC::callToJavaScript):

  • offlineasm/arm.rb:
  • offlineasm/arm64.rb:
  • offlineasm/mips.rb:
  • offlineasm/x86.rb:
3:40 PM Changeset in webkit [158882] by roger_fong@apple.com
  • 2 edits in branches/safari-537.60-branch/Source/JavaScriptCore

Rollout part of r146669 which caused a performance regression.
<rdar://problem/15265457>.

Rubberstamped by Filip Pizlo.

  • jit/JITStubs.cpp:

(JSC::DEFINE_STUB_FUNCTION):

3:34 PM Changeset in webkit [158881] by Alexandru Chiculita
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: CSS Regions: Use a Map object to store the ContentFlows
https://bugs.webkit.org/show_bug.cgi?id=124015

Reviewed by Joseph Pecoraro.

Changed the Object hashmap to a Map based hashmap when storing the flows in DOMTreeManager.

  • UserInterface/DOMTreeManager.js:

(WebInspector.DOMTreeManager):
(WebInspector.DOMTreeManager.prototype.getNamedFlowCollection):
(WebInspector.DOMTreeManager.prototype.namedFlowRemoved):
(WebInspector.DOMTreeManager.prototype._sendNamedFlowUpdateEvents):

3:31 PM Changeset in webkit [158880] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove more dead code
https://bugs.webkit.org/show_bug.cgi?id=124016

Reviewed by Beth Dakin.

We're always layer backed now so we never scroll using the PageClient.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::canScrollView):
(WebKit::PageClientImpl::scrollView):

3:26 PM Changeset in webkit [158879] by timothy@apple.com
  • 4 edits in trunk/Source/WebInspectorUI

Fix up some sidebar switching details to make selections persist better.

Translate represented objects between sidebars so the same item can be reselected
as you switch between frames and main reources. Also fix some null checks that are
needed on selectedSidebarPanel.

https://bugs.webkit.org/show_bug.cgi?id=124001

Reviewed by Joseph Pecoraro.

  • UserInterface/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype.treeElementForRepresentedObject): Added. Translate a Frame
representedObject into a main resource representedObject.

  • UserInterface/Main.js:

(WebInspector._revealAndSelectRepresentedObjectInNavigationSidebar): Null check selectedSidebarPanel.
(WebInspector._updateNavigationSidebarForCurrentContentView): Fix a logic error to match other code.
allowedNavigationSidebarPanels.length needs to have a length before using contains.
(WebInspector._contentBrowserCurrentContentViewDidChange): Null check selectedSidebarPanel.

  • UserInterface/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype.treeElementForRepresentedObject): Translate a main resource
representedObject into a Frame representedObject.

3:25 PM Changeset in webkit [158878] by Chris Fleizach
  • 23 edits in branches/safari-537.73-branch/LayoutTests

AX: Audio and Video attachments are not output to VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=123479

Unreviewed.

A number of the rebaselines from the original merge must have failed to apply.
This rebaselines those tests that are failing with the new expected results.

  • fullscreen/full-screen-crash-offsetLeft-expected.txt:
  • fullscreen/full-screen-no-style-sharing-expected.txt:
  • fullscreen/full-screen-stacking-context-expected.txt:
  • fullscreen/video-controls-drag-expected.txt:
  • fullscreen/video-controls-override-expected.txt:
  • fullscreen/video-controls-timeline-expected.txt:
  • fullscreen/video-cursor-auto-hide-expected.txt:
  • fullscreen/video-specified-size-expected.txt:
  • media/media-initialTime-expected.txt:
  • media/media-startTime-expected.txt:
  • media/media-volume-slider-rendered-below-expected.txt:
  • media/media-volume-slider-rendered-normal-expected.txt:
  • media/track/track-cue-mutable-text-expected.txt:
  • media/video-controls-captions-trackmenu-includes-enabled-track-expected.txt:
  • media/video-controls-fullscreen-volume-expected.txt:
  • media/video-controls-toggling-expected.txt:
  • media/video-controls-visible-exiting-fullscreen-expected.txt:
  • platform/mac/accessibility/media-element-expected.txt:
  • platform/mac/media/video-controls-captions-trackmenu-expected.txt:
  • platform/mac/media/video-controls-captions-trackmenu-hide-on-click-expected.txt:
  • platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:
  • platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt:
3:16 PM Changeset in webkit [158877] by rniwa@webkit.org
  • 6 edits in trunk

DOMTokenList::add can add duplicated values if arguments had duplicated values
https://bugs.webkit.org/show_bug.cgi?id=123962

Reviewed by Benjamin Poulain.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/bd3822ad4ae3fc5d8f89f433a7bf04f697334305

In case we do element.classList.add('a', 'a') we need to ensure that we do not add the same token twice.
See http://dom.spec.whatwg.org/#dom-domtokenlist-add

  • html/DOMTokenList.cpp:

(WebCore::DOMTokenList::add): Make sure filtered tokens are unique among themselves.

LayoutTests:

  • fast/dom/HTMLElement/class-list-expected.txt:
  • fast/dom/HTMLElement/class-list-quirks-expected.txt:
  • fast/dom/HTMLElement/script-tests/class-list.js:
3:01 PM Changeset in webkit [158876] by Chris Fleizach
  • 2 edits in trunk/Tools

Modify email order list for James Craig so his primary email is first.

  • Scripts/webkitpy/common/config/contributors.json:
2:19 PM Changeset in webkit [158875] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Reproducible crash when using Map (affects Web Inspector)
https://bugs.webkit.org/show_bug.cgi?id=123940

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Trivial fix. Once again we get bitten by attempting to be clever when
growing while adding entries to indexing maps.

Now we simply do a find(), and then add() _after_ we've ensured there is
sufficient space in the MapData list.

  • runtime/MapData.cpp:

(JSC::MapData::add):

LayoutTests:

Add testcases

  • js/map-grow-with-holes-expected.txt: Added.
  • js/map-grow-with-holes.html: Added.
  • js/script-tests/map-grow-with-holes.js: Added.

(get map):

2:08 PM Changeset in webkit [158874] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

Remove npr.org specific hack in HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=123859

Reviewed by Jer Noble.

Remove the site specific hack added in r57820, it is no longer necessary.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Remove m_dispatchingCanPlayEvent.
(HTMLMediaElement::play): Don't special case npr.org.

  • html/HTMLMediaElement.h:
1:56 PM Changeset in webkit [158873] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Attempt to fix the 32-bit build. Virtual thunks seem to have different
symbol names between 32- and 64-bit.

  • WebCore.exp.in:
1:54 PM Changeset in webkit [158872] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Don't repaint the view when the web process crashes
https://bugs.webkit.org/show_bug.cgi?id=124013

Reviewed by Dan Bernstein.

It's up to each individual port to decide whether the view should be repainted when the web process crashes.

  • UIProcess/API/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::setViewNeedsDisplay):
(WebKit::PageClientImpl::displayView):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetStateAfterProcessExited):

1:51 PM Changeset in webkit [158871] by Michał Pakuła vel Rutka
  • 2 edits
    1 move
    1 add
    1 delete in trunk/LayoutTests

Unreviewed EFL gardening

Remove failure test expectations from passing tests.

  • platform/efl-wk2/fast/repaint/caret-with-transformation-expected.png: Removed.
  • platform/efl/TestExpectations:
  • platform/efl/fast/repaint/caret-with-transformation-expected.png: Added.
  • platform/efl/fast/repaint/caret-with-transformation-expected.txt: Renamed from LayoutTests/platform/efl-wk2/fast/repaint/caret-with-transformation-expected.txt.
1:47 PM Changeset in webkit [158870] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Crash in HTMLMediaElement::contextDestroyed
https://bugs.webkit.org/show_bug.cgi?id=123963

Reviewed by Eric Carlson.

Merge https://chromium.googlesource.com/chromium/blink/+/177999cdb34b707465670f0feff723922939f278

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::~HTMLMediaElement):

1:43 PM Changeset in webkit [158869] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[Mac] Crash at com.apple.WebCore: -[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:] + 2084
https://bugs.webkit.org/show_bug.cgi?id=124012

Reviewed by Eric Carlson.

The value of the 'duration' key is a NSConcreteValue wrapping a CMTime, not a NSNumber.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):

1:39 PM Changeset in webkit [158868] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Crash when submitting form in a document with null encoding
https://bugs.webkit.org/show_bug.cgi?id=123975

Reviewed by Alexey Proskuryakov.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/bba01a7fff09e3053ada96ababac2a6e4261fe5f

The CString object which is passed to normalizeLineEndingsToCRLF() can be
a null string. It is created in FormDataList::appendString(), and it
produces a null CString if FormDataList::m_encoding is a null encoding.

Test: fast/forms/form-submit-in-image-document.html

  • platform/text/LineEnding.cpp:

(internalNormalizeLineEndingsToCRLF):

LayoutTests:

  • fast/forms/form-submit-in-image-document-expected.txt: Added.
  • fast/forms/form-submit-in-image-document.html: Added.
1:37 PM Changeset in webkit [158867] by andersca@apple.com
  • 8 edits in trunk/Source/WebCore

Use std::function for all policy continuation functions
https://bugs.webkit.org/show_bug.cgi?id=124011

Reviewed by Sam Weinig.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::responseReceived):

  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::loadPostRequest):

  • loader/PolicyCallback.cpp:

(WebCore::PolicyCallback::clear):
(WebCore::PolicyCallback::set):
(WebCore::PolicyCallback::call):
(WebCore::PolicyCallback::clearRequest):
(WebCore::PolicyCallback::cancel):

  • loader/PolicyCallback.h:
  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy):
(WebCore::PolicyChecker::checkNewWindowPolicy):
(WebCore::PolicyChecker::checkContentPolicy):

  • loader/PolicyChecker.h:
1:30 PM Changeset in webkit [158866] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Gtk] Disable LTO when building cairo
https://bugs.webkit.org/show_bug.cgi?id=123954

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-07
Reviewed by Martin Robinson.

Cairo always uses LTO, when it detects compiler support.
LTO is buggy in many/all versions of GCC and shouldn't be enabled by
default. This patch disables LTO when building cairo library.

With gcc 4.7.3, for example, the build fails with the following message:
'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'

  • gtk/jhbuild.modules:
12:49 PM Changeset in webkit [158865] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Use SQLite journal mode WAL (WriteAheadLogging)
https://bugs.webkit.org/show_bug.cgi?id=124009

Reviewed by Anders Carlsson.

WriteAheadLogging journalling is better than the traditional rollback model.

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::open): Use a PRAGMA to set journal_mode to WAL.

12:26 PM Changeset in webkit [158864] by commit-queue@webkit.org
  • 19 edits in trunk/LayoutTests

[GStreamer] Fix in-band track tests after r158743
https://bugs.webkit.org/show_bug.cgi?id=124007

Add a new line to a bunch of tests to match changes made in r158743.

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-07
Reviewed by Eric Carlson.

  • media/track/audio/audio-track-mkv-vorbis-language-expected.txt:
  • media/track/in-band/track-in-band-kate-ogg-addtrack-expected.txt:
  • media/track/in-band/track-in-band-kate-ogg-cues-added-once-expected.txt:
  • media/track/in-band/track-in-band-kate-ogg-kind-expected.txt:
  • media/track/in-band/track-in-band-kate-ogg-language-expected.txt:
  • media/track/in-band/track-in-band-kate-ogg-mode-expected.txt:
  • media/track/in-band/track-in-band-kate-ogg-style-expected.txt:
  • media/track/in-band/track-in-band-kate-ogg-track-order-expected.txt:
  • media/track/in-band/track-in-band-mkv-chapters-expected.txt:
  • media/track/in-band/track-in-band-srt-mkv-addtrack-expected.txt:
  • media/track/in-band/track-in-band-srt-mkv-cues-added-once-expected.txt:
  • media/track/in-band/track-in-band-srt-mkv-kind-expected.txt:
  • media/track/in-band/track-in-band-srt-mkv-language-expected.txt:
  • media/track/in-band/track-in-band-srt-mkv-mode-expected.txt:
  • media/track/in-band/track-in-band-srt-mkv-style-expected.txt:
  • media/track/in-band/track-in-band-srt-mkv-track-order-expected.txt:
  • media/track/video/video-track-mkv-theora-language-expected.txt:
  • media/track/video/video-track-mkv-theora-selected-expected.txt:
12:19 PM Changeset in webkit [158863] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Report error on unknown template class usage.
https://bugs.webkit.org/show_bug.cgi?id=123096

Patch by Tamas Gergely <gertom@inf.u-szeged.hu> on 2013-11-07
Reviewed by Darin Adler.

Report error when template class is not found in the dictionary.

  • Scripts/webkit2/messages.py:

(class_template_headers):
(class_template_headers.template):

12:17 PM Changeset in webkit [158862] by mark.lam@apple.com
  • 19 edits in trunk/Source

Cosmetic: rename xxxId to xxxID for ScriptId, SourceId, and BreakpointId.
https://bugs.webkit.org/show_bug.cgi?id=123945.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::sourceID):
(JSC::DebuggerCallFrame::sourceIDForCallFrame):

  • debugger/DebuggerCallFrame.h:

Source/WebCore:

No new tests.

  • bindings/js/JSInjectedScriptHostCustom.cpp:

(WebCore::JSInjectedScriptHost::functionDetails):

  • bindings/js/JavaScriptCallFrame.h:

(WebCore::JavaScriptCallFrame::sourceID):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
(WebCore::ScriptDebugServer::updateCallFrame):
(WebCore::ScriptDebugServer::pauseIfNeeded):

  • bindings/js/ScriptDebugServer.h:
  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::addMessageToConsole):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorConsoleInstrumentation.h:

(WebCore::InspectorInstrumentation::addMessageToConsole):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForEventListener):

  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::parseLocation):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::removeBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::setScriptSource):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::compileScript):
(WebCore::InspectorDebuggerAgent::runScript):
(WebCore::InspectorDebuggerAgent::didParseSource):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::clear):
(WebCore::InspectorDebuggerAgent::reset):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):

  • inspector/InspectorInstrumentation.h:
  • inspector/ScriptDebugListener.h:

Source/WebKit/mac:

  • WebView/WebScriptDebugger.mm:

(WebScriptDebugger::exception):

12:11 PM Changeset in webkit [158861] by commit-queue@webkit.org
  • 2 edits
    3 adds in trunk

Avoid invalid cairo matrix when drawing surfaces too small
https://bugs.webkit.org/show_bug.cgi?id=123810

Drawing surfaces too small makes inverse matrix with values too big,
when this happen, cairo context is not valid anymore and it stops to draw anything.

Patch by Cidorvan Leite <cidorvan.leite@openbossa.org> on 2013-11-07
Reviewed by Martin Robinson.

Test: fast/canvas/drawImage-with-small-values.html

  • platform/graphics/cairo/PlatformContextCairo.cpp:

(WebCore::PlatformContextCairo::drawSurfaceToContext):

11:45 AM Changeset in webkit [158860] by Antti Koivisto
  • 9 edits
    2 adds in trunk

Simple line layout crashes with SVG fonts
https://bugs.webkit.org/show_bug.cgi?id=124002

Source/WebCore:

Reviewed by Simon Fraser.

Don't use simple line layout for flows using SVG fonts. They crash if kerning is enabled.

Test: fast/text/svg-font-simple-line-crash.html

  • platform/graphics/Font.h:

(WebCore::Font::isSVGFont):

Add isSVGFont() so callers don't need to go via primaryFont().

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::constructTextRun):

  • rendering/RenderBlock.cpp:

(WebCore::constructTextRunInternal):

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):

Disallow SVG fonts.

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::constructTextRun):

  • rendering/svg/SVGTextMetrics.cpp:

(WebCore::SVGTextMetrics::constructTextRun):
(WebCore::SVGTextMetrics::SVGTextMetrics):

  • rendering/svg/SVGTextRunRenderingContext.h:


Get rid of the abstract textRunNeedsRenderingContext in favor of just testing isSVGFont().

LayoutTests:

Reviewed by Simon Fraser.

  • fast/text/svg-font-simple-line-crash-expected.txt: Added.
  • fast/text/svg-font-simple-line-crash.html: Added.
11:34 AM Changeset in webkit [158859] by Simon Fraser
  • 12 edits in trunk/Source/WebCore

Allow customization of the contentsScale of TileController tiles
https://bugs.webkit.org/show_bug.cgi?id=124004

Reviewed by Tim Horton.

On some platorms, zooming out on pages with TiledBacking compositing
layers can cause very high memory use, because the TiledBacking retains
the original page scale while the zoom is in flight, but can be asked
to cover a large area.

Make it possible to reduce memory use in this case by allowing RenderLayerCompositor
to provide an additional scale factor for newly created tiles. Platforms can
then customize this to create low-res tiles when necessary.

  • WebCore.exp.in:
  • platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::contentsScaleMultiplierForNewTiles):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::platformCALayerContentsScaleMultiplierForNewTiles):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/PlatformCALayerClient.h:

(WebCore::PlatformCALayerClient::platformCALayerContentsScaleMultiplierForNewTiles):

  • platform/graphics/ca/mac/TileController.h:
  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::TileController):
(WebCore::TileController::setScale):
(WebCore::TileController::createTileLayer):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::contentsScaleMultiplierForNewTiles):

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::contentsScaleMultiplierForNewTiles):

  • rendering/RenderLayerCompositor.h:
11:33 AM Changeset in webkit [158858] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

returnFromJavaScript() for ARM_THUMB2 uses push()s which should be pop()s
https://bugs.webkit.org/show_bug.cgi?id=124006

Rubber stamped by Mark Hahnenberg.

Changed the push() calls to pop().

  • jit/ThunkGenerators.cpp:

(JSC::returnFromJavaScript):

11:23 AM Changeset in webkit [158857] by msaboff@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove unneeded moving of ESP to ECX in callToJavaScript for COMPILER(MSVC)
https://bugs.webkit.org/show_bug.cgi?id=123998

Reviewed by Mark Lam.

Dead code removal. Passing esp as the first "C" argument to a JavaScript
function is no longer needed.

  • jit/ThunkGenerators.cpp:

(JSC::callToJavaScript):

11:04 AM Changeset in webkit [158856] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Win build fix after r158855; wrap shapeInfoForFloat() in an ENABLE(CSS_SHAPES) guard.

  • rendering/FloatingObjects.cpp:
10:11 AM Changeset in webkit [158855] by Bem Jones-Bey
  • 6 edits in trunk/Source/WebCore

Refactor logical left/right offset for line methods
https://bugs.webkit.org/show_bug.cgi?id=123898

Reviewed by David Hyatt.

Simplify the logical left/right offset for line methods and their
implementation, including the ComputeFloatOffsetAdapter. This also
reduces the number of line offset methods in RenderBlock.

No new tests, no behavior change.

  • rendering/FloatingObjects.cpp:

(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter):
(WebCore::ComputeFloatOffsetAdapter::offset): Add a method to return

the offset instead of using a confusing out parameter.

(WebCore::::shapeOffset): Method to return the offset modified by the

shape delta. Moving the computation to this method allowed for
simplification of the users of ComputeFloatOffsetAdapter.

(WebCore::FloatingObjects::logicalLeftOffsetForPositioningFloat): Added this

method so that ShapeOutsideFloatOffsetMode isn't needed. Returns the
offset based on the float margin box.

(WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat): Ditto.
(WebCore::FloatingObjects::logicalLeftOffset): This now only returns

the offset based on the shape's contour.

(WebCore::FloatingObjects::logicalRightOffset): Ditto.
(WebCore::::heightRemaining): Rename to properly follow the getter

naming convention.

  • rendering/FloatingObjects.h:
  • rendering/RenderBlock.h:

(WebCore::RenderBlock::logicalRightOffsetForLine): Update to remove

use of ShapeOutsideFloatOffsetMode and heightRemaining.

(WebCore::RenderBlock::logicalLeftOffsetForLine): Ditto.
(WebCore::RenderBlock::logicalRightFloatOffsetForLine): Ditto.
(WebCore::RenderBlock::logicalLeftFloatOffsetForLine): Ditto.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::logicalLeftOffsetForPositioningFloat):

Positioning a float is the only case where the float margin box
should be used, and also the only case where heightRemaining is
needed. This handles that case.

(WebCore::RenderBlockFlow::logicalRightOffsetForPositioningFloat):

Ditto.

(WebCore::RenderBlockFlow::computeLogicalLocationForFloat): Update to

use logical(Left|Right)OffsetForPositioningFloatOnLine.

(WebCore::RenderBlockFlow::logicalLeftFloatOffsetForLine): Update to

remove use for ShapeOutsideFloatOffsetMode and heightRemaining.

(WebCore::RenderBlockFlow::logicalRightFloatOffsetForLine): Ditto.

  • rendering/RenderBlockFlow.h:
10:05 AM Changeset in webkit [158854] by Alexandru Chiculita
  • 6 edits
    2 adds in trunk

Web Inspector: CSS Regions: Removing a content node of a ContentFlow from the DOM will send a 0 nodeId
https://bugs.webkit.org/show_bug.cgi?id=123577

Source/WebCore:

Reviewed by Timothy Hatcher.

Test: inspector-protocol/model/content-flow-content-removal.html

Do not send unregister events for the content nodes of a flow when the element is not part of the DOM
anymore. We already send an unbind event, so the inspector is already notified that the node was removed.

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::didUnregisterNamedFlowContentElement):

Source/WebInspectorUI:

Reviewed by Timothy Hatcher.

Fixed the content node removal from the content flow.

  • UserInterface/ContentFlowTreeContentView.js:
  • UserInterface/DOMTreeManager.js:

(WebInspector.DOMTreeManager):
(WebInspector.DOMTreeManager.prototype._createContentFlowFromPayload): Registered all the content nodes
in the _contentNodesToFlowsMap.
(WebInspector.DOMTreeManager.prototype._unbind): Added call to _removeContentNodeFromFlowIfNeeded.
(WebInspector.DOMTreeManager.prototype._removeContentNodeFromFlowIfNeeded): Called from _unbind to check
and remove a node from it's parent content flow if needed.
(WebInspector.DOMTreeManager.prototype.unregisteredNamedFlowContentElement):

LayoutTests:

Reviewed by Timothy Hatcher.

Added test to check that the notification that an element was removed from the ContentFlow is handled
correctly in the WebInspector even if the element is not part of the DOM anymore.

  • inspector-protocol/model/content-flow-content-removal-expected.txt: Added.
  • inspector-protocol/model/content-flow-content-removal.html: Added.
9:58 AM Changeset in webkit [158853] by jer.noble@apple.com
  • 13 edits
    27 adds in trunk

[MSE] Add mock MediaSource classes for testing.
https://bugs.webkit.org/show_bug.cgi?id=123322

Reviewed by Eric Carlson.

Source/WebCore:

Tests: media/media-source/media-source-addsourcebuffer.html

media/media-source/media-source-append-buffer.html
media/media-source/media-source-canplaythrough.html
media/media-source/media-source-closed.html
media/media-source/media-source-play.html
media/media-source/media-source-track-enabled.html
media/media-source/media-source-tracks.html

Add mock implementation of platform MediaSource classes, allowing ports to test the
MediaSource API without having a platform implementation.

The MockMediaSource will support a byteformat defined in MockBox.h: a simple box-style media
format with an initialization segment containing a number of tracks, followed by a list of
samples.

Add a means to insert a new media engine factory at runtime, so the internals object can add
a MockMediaSourceMediaPlayer:

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayerFactorySupport::callRegisterMediaEngine):

  • platform/graphics/MediaPlayer.h:
  • testing/Internals.cpp:

(WebCore::Internals::initializeMockMediaSource):

  • testing/Internals.h:
  • testing/Internals.idl:

For non-media-source supporting media engines, fail immediately when asked to load a media
source, so that the MockMediaSourceMediaPlayer will be instantiated as a fall-back:

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::load):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::supportsType):

  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::load):
(WebCore::MediaPlayerPrivateQTKit::supportsType):

Add new files to the project:

  • WebCore.xcodeproj/project.pbxproj:
  • Source/WebCore/WebCore.exp.in:

Update the MediaSource implementation:

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::monitorSourceBuffers): Add a link to the spec.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::buffered): Ditto.
(WebCore::SourceBuffer::setTimestampOffset): Ditto.
(WebCore::SourceBuffer::validateInitializationSegment): Ditto.
(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment): Ditto. Also,

bring the implementation up to date with part of the spec.

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): Remove "Predicate" from

SampleIsRandomAccessPredicate.

Add utility classes to parse and represent the bytestream supported by the MockMediaSource:

  • platform/mock/mediasource/MockBox.cpp: Added.

(WebCore::MockBox::MockBox):
(WebCore::MockBox::peekType):
(WebCore::MockBox::peekLength):
(WebCore::MockTrackBox::MockTrackBox):
(WebCore::MockTrackBox::type):
(WebCore::MockInitializationBox::MockInitializationBox):
(WebCore::MockInitializationBox::type):
(WebCore::MockSampleBox::MockSampleBox):
(WebCore::MockSampleBox::type):

  • platform/mock/mediasource/MockBox.h: Added.

(WebCore::MockBox::length):
(WebCore::MockBox::type):
(WebCore::MockTrackBox::trackID):
(WebCore::MockTrackBox::codec):
(WebCore::MockTrackBox::kind):
(WebCore::MockInitializationBox::duration):
(WebCore::MockInitializationBox::tracks):
(WebCore::MockSampleBox::presentationTimestamp):
(WebCore::MockSampleBox::decodeTimestamp):
(WebCore::MockSampleBox::duration):
(WebCore::MockSampleBox::trackID):
(WebCore::MockSampleBox::flags):
(WebCore::MockSampleBox::isSync):

Add a MediaPlayerPrivate implementation which uses MockMediaSource:

  • platform/mock/mediasource/MockMediaPlayerMediaSource.cpp: Added.

(WebCore::MockMediaPlayerMediaSource::registerMediaEngine):
(WebCore::MockMediaPlayerMediaSource::create):
(WebCore::mimeTypeCache):
(WebCore::MockMediaPlayerMediaSource::getSupportedTypes):
(WebCore::MockMediaPlayerMediaSource::supportsType):
(WebCore::MockMediaPlayerMediaSource::MockMediaPlayerMediaSource):
(WebCore::MockMediaPlayerMediaSource::~MockMediaPlayerMediaSource):
(WebCore::MockMediaPlayerMediaSource::load):
(WebCore::MockMediaPlayerMediaSource::cancelLoad):
(WebCore::MockMediaPlayerMediaSource::play):
(WebCore::MockMediaPlayerMediaSource::pause):
(WebCore::MockMediaPlayerMediaSource::naturalSize):
(WebCore::MockMediaPlayerMediaSource::hasVideo):
(WebCore::MockMediaPlayerMediaSource::hasAudio):
(WebCore::MockMediaPlayerMediaSource::setVisible):
(WebCore::MockMediaPlayerMediaSource::seeking):
(WebCore::MockMediaPlayerMediaSource::paused):
(WebCore::MockMediaPlayerMediaSource::networkState):
(WebCore::MockMediaPlayerMediaSource::readyState):
(WebCore::MockMediaPlayerMediaSource::buffered):
(WebCore::MockMediaPlayerMediaSource::didLoadingProgress):
(WebCore::MockMediaPlayerMediaSource::setSize):
(WebCore::MockMediaPlayerMediaSource::paint):
(WebCore::MockMediaPlayerMediaSource::currentTimeDouble):
(WebCore::MockMediaPlayerMediaSource::durationDouble):
(WebCore::MockMediaPlayerMediaSource::seekDouble):
(WebCore::MockMediaPlayerMediaSource::advanceCurrentTime):
(WebCore::MockMediaPlayerMediaSource::updateDuration):
(WebCore::MockMediaPlayerMediaSource::setReadyState):

  • platform/mock/mediasource/MockMediaPlayerMediaSource.h: Added.

Add a mock implementation of MediaSourcePrivate, which uses MockSourceBuffer:

  • platform/mock/mediasource/MockMediaSourcePrivate.cpp: Added.

(WebCore::MockMediaSourcePrivate::create):
(WebCore::MockMediaSourcePrivate::MockMediaSourcePrivate):
(WebCore::MockMediaSourcePrivate::~MockMediaSourcePrivate):
(WebCore::MockMediaSourcePrivate::addSourceBuffer):
(WebCore::MockMediaSourcePrivate::removeSourceBuffer):
(WebCore::MockMediaSourcePrivate::duration):
(WebCore::MockMediaSourcePrivate::setDuration):
(WebCore::MockMediaSourcePrivate::markEndOfStream):
(WebCore::MockMediaSourcePrivate::unmarkEndOfStream):
(WebCore::MockMediaSourcePrivate::readyState):
(WebCore::MockMediaSourcePrivate::setReadyState):
(WebCore::MockMediaSourcePrivate::sourceBufferPrivateDidChangeActiveState):
(WebCore::MockSourceBufferPrivateHasAudio):
(WebCore::MockMediaSourcePrivate::hasAudio):
(WebCore::MockSourceBufferPrivateHasVideo):
(WebCore::MockMediaSourcePrivate::hasVideo):

  • platform/mock/mediasource/MockMediaSourcePrivate.h: Added.

(WebCore::MockMediaSourcePrivate::activeSourceBuffers):
(WebCore::MockMediaSourcePrivate::player):

Add a mock implementation of SourceBufferPrivate, which uses MockBoxes to parse the
bytestream provided by SourceBuffer:

  • platform/mock/mediasource/MockSourceBufferPrivate.cpp: Added.

(WebCore::MockMediaSample::create):
(WebCore::MockMediaSample::~MockMediaSample):
(WebCore::MockMediaSample::MockMediaSample):
(WebCore::MockMediaSample::platformSample):
(WebCore::MockMediaDescription::create):
(WebCore::MockMediaDescription::~MockMediaDescription):
(WebCore::MockMediaDescription::MockMediaDescription):
(WebCore::MockSourceBufferPrivate::create):
(WebCore::MockSourceBufferPrivate::MockSourceBufferPrivate):
(WebCore::MockSourceBufferPrivate::~MockSourceBufferPrivate):
(WebCore::MockSourceBufferPrivate::setClient):
(WebCore::MockSourceBufferPrivate::append):
(WebCore::MockSourceBufferPrivate::didReceiveInitializationSegment):
(WebCore::MockSourceBufferPrivate::didReceiveSample):
(WebCore::MockSourceBufferPrivate::abort):
(WebCore::MockSourceBufferPrivate::removedFromMediaSource):
(WebCore::MockSourceBufferPrivate::readyState):
(WebCore::MockSourceBufferPrivate::setReadyState):
(WebCore::MockSourceBufferPrivate::hasVideo):
(WebCore::MockSourceBufferPrivate::hasAudio):

  • platform/mock/mediasource/MockSourceBufferPrivate.h: Added.

Create mock implementations of AudioTrackPrivate, VideoTrackPrivate, and TextTrackPrivate
which wrap the MockTrackBox class:

  • platform/mock/mediasource/MockTracks.cpp: Added.
  • platform/mock/mediasource/MockTracks.h: Added.

(WebCore::MockAudioTrackPrivate::create):
(WebCore::MockAudioTrackPrivate::~MockAudioTrackPrivate):
(WebCore::MockAudioTrackPrivate::id):
(WebCore::MockAudioTrackPrivate::MockAudioTrackPrivate):
(WebCore::MockTextTrackPrivate::create):
(WebCore::MockTextTrackPrivate::~MockTextTrackPrivate):
(WebCore::MockTextTrackPrivate::id):
(WebCore::MockTextTrackPrivate::MockTextTrackPrivate):
(WebCore::MockVideoTrackPrivate::create):
(WebCore::MockVideoTrackPrivate::~MockVideoTrackPrivate):
(WebCore::MockVideoTrackPrivate::id):
(WebCore::MockVideoTrackPrivate::MockVideoTrackPrivate):

LayoutTests:

  • media/media-source/media-source-addsourcebuffer-expected.txt: Added.
  • media/media-source/media-source-addsourcebuffer.html: Added.
  • media/media-source/media-source-append-buffer-expected.txt: Added.
  • media/media-source/media-source-append-buffer.html: Added.
  • media/media-source/media-source-canplaythrough-expected.txt: Added.
  • media/media-source/media-source-canplaythrough.html: Added.
  • media/media-source/media-source-closed-expected.txt: Added.
  • media/media-source/media-source-closed.html: Added.
  • media/media-source/media-source-play-expected.txt: Added.
  • media/media-source/media-source-play.html: Added.
  • media/media-source/mock-media-source.js: Added.
  • media/video-test.js:
9:56 AM Changeset in webkit [158852] by Samuel White
  • 4 edits
    2 adds in trunk

AX: DRT AccessibilityUIElement::isFocused methods should be finished.
https://bugs.webkit.org/show_bug.cgi?id=123774

Reviewed by Chris Fleizach.

Tools:

Implemented AccessibilityUIElement::isFocused methods and removed FIXMEs.

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::isFocused):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::isFocused):

LayoutTests:

Added Mac platform test so we can validate our AccessibilityUIElement convenience method expectations.

  • platform/mac/accessibility/test-convenience-methods-expected.txt: Added.
  • platform/mac/accessibility/test-convenience-methods.html: Added.
9:17 AM Changeset in webkit [158851] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Removed retrieveQMakespecVar function
https://bugs.webkit.org/show_bug.cgi?id=123996

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-07
Reviewed by Csaba Osztrogonác.

  • Scripts/webkitdirs.pm:
9:11 AM Changeset in webkit [158850] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Removed QMake related filters
https://bugs.webkit.org/show_bug.cgi?id=123992

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-07
Reviewed by Csaba Osztrogonác.

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaseline.test_rebaseline):
(TestRebaselineExpectations.test_rebaseline_expectations):

9:08 AM WebInspectorCodingStyleGuide edited by Alexandru Chiculita
(diff)
8:21 AM Changeset in webkit [158849] by commit-queue@webkit.org
  • 34 edits
    2 moves in trunk/Source

Changing MediaStreamDescriptor to MediaStreamPrivate
https://bugs.webkit.org/show_bug.cgi?id=123935

Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-07
Reviewed by Eric Carlson.

Source/WebCore:

No new tests needed.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::create):
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::~MediaStream):
(WebCore::MediaStream::ended):
(WebCore::MediaStream::setEnded):
(WebCore::MediaStream::addTrack):
(WebCore::MediaStream::removeTrack):
(WebCore::MediaStream::removeRemoteSource):

  • Modules/mediastream/MediaStream.h:
  • Modules/mediastream/MediaStreamRegistry.cpp:

(WebCore::MediaStreamRegistry::registerURL):
(WebCore::MediaStreamRegistry::unregisterURL):
(WebCore::MediaStreamRegistry::lookupMediaStreamPrivate):

  • Modules/mediastream/MediaStreamRegistry.h:
  • Modules/mediastream/MediaStreamTrack.cpp:
  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::addStream):
(WebCore::RTCPeerConnection::removeStream):
(WebCore::RTCPeerConnection::didAddRemoteStream):
(WebCore::RTCPeerConnection::didRemoveRemoteStream):

  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::didCreateStream):
(WebCore::UserMediaRequest::callSuccessHandler):

  • Modules/mediastream/UserMediaRequest.h:
  • Modules/webaudio/MediaStreamAudioDestinationNode.cpp:

(WebCore::MediaStreamAudioDestinationNode::MediaStreamAudioDestinationNode):

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.cpp:

(HTMLMediaElement::loadResource):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

(WebCore::toWebMediaStreamPrivate):
(WebCore::MediaPlayerPrivate::lookupMediaStream):

  • platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
  • platform/mediastream/MediaStreamCenter.cpp:
  • platform/mediastream/MediaStreamCreationClient.h:
  • platform/mediastream/MediaStreamPrivate.cpp: Renamed from Source/WebCore/platform/mediastream/MediaStreamDescriptor.cpp.

(WebCore::MediaStreamPrivate::create):
(WebCore::MediaStreamPrivate::addSource):
(WebCore::MediaStreamPrivate::removeSource):
(WebCore::MediaStreamPrivate::addRemoteSource):
(WebCore::MediaStreamPrivate::removeRemoteSource):
(WebCore::MediaStreamPrivate::addRemoteTrack):
(WebCore::MediaStreamPrivate::removeRemoteTrack):
(WebCore::MediaStreamPrivate::MediaStreamPrivate):
(WebCore::MediaStreamPrivate::setEnded):
(WebCore::MediaStreamPrivate::addTrack):
(WebCore::MediaStreamPrivate::removeTrack):

  • platform/mediastream/MediaStreamPrivate.h: Renamed from Source/WebCore/platform/mediastream/MediaStreamDescriptor.h.

(WebCore::MediaStreamPrivateClient::~MediaStreamPrivateClient):
(WebCore::MediaStreamPrivate::~MediaStreamPrivate):
(WebCore::MediaStreamPrivate::client):
(WebCore::MediaStreamPrivate::setClient):
(WebCore::MediaStreamPrivate::id):
(WebCore::MediaStreamPrivate::numberOfAudioSources):
(WebCore::MediaStreamPrivate::audioSources):
(WebCore::MediaStreamPrivate::numberOfVideoSources):
(WebCore::MediaStreamPrivate::videoSources):
(WebCore::MediaStreamPrivate::numberOfAudioTracks):
(WebCore::MediaStreamPrivate::audioTracks):
(WebCore::MediaStreamPrivate::numberOfVideoTracks):
(WebCore::MediaStreamPrivate::videoTracks):
(WebCore::MediaStreamPrivate::ended):

  • platform/mediastream/MediaStreamSource.cpp:
  • platform/mediastream/MediaStreamSource.h:
  • platform/mediastream/RTCPeerConnectionHandler.h:
  • platform/mediastream/RTCPeerConnectionHandlerClient.h:
  • platform/mediastream/blackberry/MediaStreamCenterBlackBerry.cpp:
  • platform/mediastream/blackberry/MediaStreamCenterBlackBerry.h:
  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
  • platform/mediastream/mac/MediaStreamCenterMac.cpp:

(WebCore::MediaStreamCenterMac::createMediaStream):

  • platform/mock/MockMediaStreamCenter.cpp:

(WebCore::MockMediaStreamCenter::createMediaStream):

  • platform/mock/RTCPeerConnectionHandlerMock.cpp:

(WebCore::RTCPeerConnectionHandlerMock::addStream):
(WebCore::RTCPeerConnectionHandlerMock::removeStream):

  • platform/mock/RTCPeerConnectionHandlerMock.h:

Source/WebKit/blackberry:

  • WebCoreSupport/UserMediaClientImpl.cpp:

(WebCore::toMediaStreamPrivate):
(WebCore::WebUserMediaRequestClientImpl::requestSucceeded):

7:18 AM Changeset in webkit [158848] by mario@webkit.org
  • 92 edits in trunk

[GTK] Glyphs in vertical text tests are rotated 90 degrees clockwise
https://bugs.webkit.org/show_bug.cgi?id=50619

Patch by Denis Nomiyama <d.nomiyama@samsung.com> on 2013-11-07
Reviewed by Martin Robinson.

Source/WebCore:

Implemented the OPENTYPE_VERTICAL feature for the GTK+ port. It resolves
the 90 degrees rotation problem of CJK characters when displaying
vertical text.

New tests are not required as the existing tests for vertical text will
work properly now.

  • GNUmakefile.list.am: Added OpenTypeVerticalData.cpp and

OpenTypeVerticalData.h to platformgtk_sources.

  • PlatformEfl.cmake: Added OpenTypeVerticalData.cpp.
  • PlatformGTK.cmake: Added OpenTypeVerticalData.cpp.
  • platform/graphics/FontCache.cpp: Originally the HashMap for

OpenTypeVerticalData was designed with FontFileKey as integer in the
Chromium port, which was an unique number provided by Skia. Since other
ports use FontFileKey as string, new generic hash functions had to be
implemented instead of using the specific ones for integers.
(WebCore::FontVerticalDataCacheKeyHash::hash): New hash function for
HashMap of OpenTypeVerticalData.
(WebCore::FontVerticalDataCacheKeyHash::equal): New function for
comparing hash indexes in the HashMap of OpenTypeVerticalData.
(WebCore::FontVerticalDataCacheKeyTraits::emptyValue): New function for
giving an empty FontFileKey.
(WebCore::FontVerticalDataCacheKeyTraits::constructDeletedValue): New
function to create a FontFileKey for deleted values.
(WebCore::FontVerticalDataCacheKeyTraits::isDeletedValue): New function
to check if a HashMap entry is available.

  • platform/graphics/freetype/FontCustomPlatformDataFreeType.cpp:

(WebCore::FontCustomPlatformData::fontPlatformData): Added font
orientation as a parameter to the FontPlatformData constructor.

  • platform/graphics/freetype/FontPlatformData.h: Added m_orientation to

store the font orientation and m_horizontalOrientationMatrix to store
the Cairo matrix for horizontal orientation, which can be restored in
setOrientation().
(WebCore::FontPlatformData::FontPlatformData): Added font orientation as
a parameter.
(WebCore::FontPlatformData::orientation): Implemented this function
based on m_orientation.

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp: Added new

helper function rotateCairoMatrixForVerticalOrientation() to rotate the
Cairo matrix in case of vertical orientation.
(WebCore::FontPlatformData::FontPlatformData): Initialized
m_orientation.
(WebCore::FontPlatformData::operator=): Added m_orientation and
m_horizontalOrientationMatrix to the assignment operator.
(WebCore::FontPlatformData::operator==): Added m_orientation to the
equal operator.
(WebCore::FontPlatformData::initializeWithFontFace): Rotated and
translated fonts if orientation is vertical. Also stored the horizontal
Cairo matrix.
(WebCore::FontPlatformData::verticalData): Returned the vertical data
from the font cache.
(WebCore::FontPlatformData::openTypeTable): Loaded the font table into
a shared buffer.
(WebCore::FontPlatformData::setOrientation): Replaced the scaled font
data by rotating fonts according to the new orientation.

  • platform/graphics/freetype/SimpleFontDataFreeType.cpp:

(WebCore::SimpleFontData::platformInit): Set the glyph's height and
width according to the font orientation. It also sets EM.
(WebCore::SimpleFontData::platformCreateScaledFontData): Added
orientation to the FontPlatformData constructor.
(WebCore::SimpleFontData::platformWidthForGlyph): Returned the glyph's
width according the orientation.

  • platform/graphics/harfbuzz/HarfBuzzFaceCairo.cpp:

(WebCore::CairoGetGlyphWidthAndExtents): Obtained the character advance
and extents according to the font orientation.

Source/Platform:

Added WebCore/platform/graphics/opentype to the include path.

  • GNUmakefile.am:

Source/WTF:

Enabled OPENTYPE_VERTICAL by default on GTK+ and EFL ports, which are
currently using Freetype.

  • wtf/Platform.h:

Source/WebKit:

Added WebCore/platform/graphics/opentype to the include path.

  • PlatformEfl.cmake:

Source/WebKit2:

Added WebCore/platform/graphics/opentype to the include path.

  • PlatformEfl.cmake:
  • PlatformGTK.cmake:

LayoutTests:

Updated existing test results that uses vertical texts.

  • platform/gtk-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
  • platform/gtk-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Updated.
  • platform/gtk/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.png: Updated.
  • platform/gtk/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt: Updated.
  • platform/gtk/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.png: Updated.
  • platform/gtk/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.png: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.png: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.png: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.png: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.png: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.png: Updated.
  • platform/gtk/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt: Updated.
  • platform/gtk/fast/block/lineboxcontain/block-with-ideographs-expected.png: Updated.
  • platform/gtk/fast/block/lineboxcontain/block-with-ideographs-expected.txt: Updated.
  • platform/gtk/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png: Updated.
  • platform/gtk/fast/dynamic/text-combine-expected.png: Updated.
  • platform/gtk/fast/dynamic/text-combine-expected.txt: Updated.
  • platform/gtk/fast/html/details-writing-mode-expected.png: Updated.
  • platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.png: Updated.
  • platform/gtk/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.png: Updated.
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-expected.txt: Added.
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Updated.
  • platform/gtk/fast/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Updated.
  • platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Updated.
  • platform/gtk/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Updated.
  • platform/gtk/fast/ruby/base-shorter-than-text-expected.png: Updated.
  • platform/gtk/fast/ruby/base-shorter-than-text-expected.txt: Updated.
  • platform/gtk/fast/text/decorations-with-text-combine-expected.png: Updated.
  • platform/gtk/fast/text/decorations-with-text-combine-expected.txt: Updated.
  • platform/gtk/fast/text/emphasis-combined-text-expected.png: Updated.
  • platform/gtk/fast/text/emphasis-combined-text-expected.txt: Updated.
  • platform/gtk/fast/text/emphasis-vertical-expected.png: Updated.
  • platform/gtk/fast/text/emphasis-vertical-expected.txt: Updated.
  • platform/gtk/fast/text/international/text-combine-image-test-expected.png: Updated.
  • platform/gtk/fast/text/international/text-combine-image-test-expected.txt: Updated.
  • platform/gtk/fast/text/international/text-spliced-font-expected.png: Updated.
  • platform/gtk/fast/text/international/text-spliced-font-expected.txt: Updated.
  • platform/gtk/fast/text/international/vertical-text-glyph-test-expected.png: Updated.
  • platform/gtk/fast/text/international/vertical-text-glyph-test-expected.txt: Added.
  • platform/gtk/fast/text/justify-ideograph-vertical-expected.png: Updated.
  • platform/gtk/fast/text/justify-ideograph-vertical-expected.txt: Added.
  • platform/gtk/fast/text/orientation-sideways-expected.png: Updated.
  • platform/gtk/fast/text/orientation-sideways-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Updated.
  • platform/gtk/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/border-vertical-lr-expected.png: Updated.
  • platform/gtk/fast/writing-mode/border-vertical-lr-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/broken-ideograph-small-caps-expected.png: Updated.
  • platform/gtk/fast/writing-mode/broken-ideograph-small-caps-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/broken-ideographic-font-expected.png: Updated.
  • platform/gtk/fast/writing-mode/broken-ideographic-font-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/fallback-orientation-expected.png: Updated.
  • platform/gtk/fast/writing-mode/fallback-orientation-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/japanese-lr-selection-expected.png: Updated.
  • platform/gtk/fast/writing-mode/japanese-lr-selection-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/japanese-lr-text-expected.png: Updated.
  • platform/gtk/fast/writing-mode/japanese-lr-text-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/japanese-rl-selection-expected.png: Updated.
  • platform/gtk/fast/writing-mode/japanese-rl-selection-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/japanese-rl-text-expected.png: Updated.
  • platform/gtk/fast/writing-mode/japanese-rl-text-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/japanese-rl-text-with-broken-font-expected.png: Updated.
  • platform/gtk/fast/writing-mode/japanese-rl-text-with-broken-font-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/japanese-ruby-vertical-lr-expected.png: Updated.
  • platform/gtk/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/japanese-ruby-vertical-rl-expected.png: Updated.
  • platform/gtk/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/text-orientation-basic-expected.png: Updated.
  • platform/gtk/fast/writing-mode/text-orientation-basic-expected.txt:
  • platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.png: Updated.
  • platform/gtk/fast/writing-mode/vertical-align-table-baseline-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/vertical-baseline-alignment-expected.png: Updated.
  • platform/gtk/fast/writing-mode/vertical-baseline-alignment-expected.txt: Updated.
  • platform/gtk/fast/writing-mode/vertical-font-fallback-expected.png: Updated.
  • platform/gtk/fast/writing-mode/vertical-font-fallback-expected.txt: Updated.
5:43 AM Changeset in webkit [158847] by mario@webkit.org
  • 1 edit
    2 moves
    1 delete in trunk/LayoutTests

Unreviewed GTK gardening. Expectations are finally the same for
WK1 and WK2 so, besides needing a rebaseline, we now can share them.

  • platform/gtk-wk1/accessibility/table-attributes-expected.txt: Removed.
  • platform/gtk-wk1/accessibility/table-sections-expected.txt: Removed.
  • platform/gtk/accessibility/table-attributes-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/accessibility/table-attributes-expected.txt.
  • platform/gtk/accessibility/table-sections-expected.txt: Renamed from LayoutTests/platform/gtk-wk2/accessibility/table-sections-expected.txt.
4:51 AM Changeset in webkit [158846] by gyuyoung.kim@samsung.com
  • 1 edit
    26 adds in trunk/LayoutTests

Unreviewed, Add new baselines to EFL port since r158743 as well as do rebaseline.
Because r158743 didn't update EFL port.

  • platform/efl/fullscreen/video-controls-override-expected.txt: Added.
  • platform/efl/http/tests/media/video-cookie-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_2-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_3-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_4-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Added.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Added.
  • platform/efl/media/context-menu-actions-expected.txt: Added.
  • platform/efl/media/media-can-play-flac-audio-expected.txt: Added.
  • platform/efl/media/media-can-play-webm-expected.txt: Added.
  • platform/efl/media/media-volume-slider-rendered-below-expected.txt: Added.
  • platform/efl/media/media-volume-slider-rendered-normal-expected.txt: Added.
  • platform/efl/media/track/audio/audio-track-mkv-vorbis-addtrack-expected.txt: Added.
  • platform/efl/media/track/audio/audio-track-mkv-vorbis-enabled-expected.txt: Added.
  • platform/efl/media/track/track-cue-mutable-text-expected.txt: Added.
  • platform/efl/media/track/track-cue-rendering-mode-changed-expected.txt: Added.
  • platform/efl/media/track/track-language-preference-expected.txt: Added.
  • platform/efl/media/track/video/video-track-mkv-theora-addtrack-expected.txt: Added.
  • platform/efl/media/track/video/video-track-mkv-theora-selected-expected.txt: Added.
  • platform/efl/media/video-controls-fullscreen-volume-expected.txt: Added.
  • platform/efl/media/video-controls-toggling-expected.txt: Added.
4:46 AM Changeset in webkit [158845] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Efl] Disable LTO when building cairo
https://bugs.webkit.org/show_bug.cgi?id=123947

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-07
Reviewed by Gyuyoung Kim.

Cairo always uses LTO, when it detects compiler support.
LTO is buggy in many/all versions of GCC and shouldn't be enabled by
default. This patch disables LTO when building cairo library.

With gcc 4.7.3, for example, the build fails with the following message:
'lto1: fatal error: LTO_tags out of range: Range is 0 to 361, value is 15872'

  • efl/jhbuild.modules:
4:29 AM Changeset in webkit [158844] by gyuyoung.kim@samsung.com
  • 7 edits in trunk/Source

[AX] Use toAccessibilityRenderObject() instead of using static_cast<>
https://bugs.webkit.org/show_bug.cgi?id=123986

Reviewed by Mario Sanchez Prada.

Though there is toAccessibilityRenderObject(), static_cast<> are being used by many places.
To use toAccessibilityRenderObject() is more helpful to find bad type cast.

No new tests, no behavior changes.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::notificationPostTimerFired):

  • accessibility/AccessibilityImageMapLink.cpp:

(WebCore::AccessibilityImageMapLink::imageMapLinkRenderer):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):

  • accessibility/ios/AccessibilityObjectIOS.mm:

(WebCore::AccessibilityObject::accessibilityPasswordFieldLength):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(AXAttributeStringSetElement):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

4:10 AM Changeset in webkit [158843] by gyuyoung.kim@samsung.com
  • 6 edits in trunk/Source/WebCore

[AX] Use toAccessibilityTable() instead of using manual static_cast<>
https://bugs.webkit.org/show_bug.cgi?id=123982

Reviewed by Mario Sanchez Prada.

Though there is toAccessibilityTable(), static_cast<> are being used by many places.
We need to use toAccessibilityTable().

No new tests, no behavior changes.

  • accessibility/AccessibilityARIAGridRow.cpp:

(WebCore::AccessibilityARIAGridRow::disclosedRows):
(WebCore::AccessibilityARIAGridRow::disclosedByRow):

  • accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore::AccessibilityTableHeaderContainer::addChildren):

  • accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(cell):
(cellAtIndex):
(webkitAccessibleTableGetIndexAt):
(webkitAccessibleTableGetNColumns):
(webkitAccessibleTableGetNRows):
(webkitAccessibleTableGetColumnHeader):
(webkitAccessibleTableGetRowHeader):

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper tableParent]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):

4:04 AM Changeset in webkit [158842] by akling@apple.com
  • 14 edits in trunk/Source/WebCore

Use tighter InlineBox subtypes in some places.
<https://webkit.org/b/123980>

RenderLineBreak and RenderBox line box wrappers are always going to
be InlineElementBox, so codify this with tighter types. Also made
the various positionLine() functions take tighter reference types.

All the casting to renderer-appropriate box types happens inside of
RenderBlockFlow::computeBlockDirectionPositionsForLine() and
propagates from there.

Reviewed by Antti Koivisto.

3:12 AM Changeset in webkit [158841] by mario@webkit.org
  • 10 edits
    4 adds in trunk

AX: [ATK] Video and audio elements are not properly exposed
https://bugs.webkit.org/show_bug.cgi?id=123894

Reviewed by Chris Fleizach.

Source/WebCore:

Expose <audio> and <video> elements with ATK_ROLE_EMBEDDED, so we
can identify them properly from ATK/AT-SPI based ATs.

Tests: platform/gtk/accessibility/media-controls-panel-title.html

platform/efl/accessibility/media-emits-object-replacement.html
platform/gtk/accessibility/media-emits-object-replacement.html

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(atkRole): Add the new mapping.

Tools:

Update DRT and WKTR to handle the ATK_ROLE_EMBEDDED role.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp: Updated.
  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp: Updated.

LayoutTests:

Updated tests and expectations according to the new behavior.

Updated failing test to reflect the new reality.

  • platform/gtk/accessibility/media-element-expected.txt: Updated.

Extended GTK specific test by adding an <audio> element besides
the <video> one and printing all the information about those
related to their media nature.

  • platform/gtk/accessibility/media-controls-panel-title.html: Extended.
  • platform/gtk/accessibility/media-controls-panel-title-expected.txt: Updated.

Added new tests for GTK and EFL to check that the replaced
character is being properly emitter for both <video> and <audio>
elements. Inspired in the ones in platform/mac, we use a different
approach here to print the test since we don't have the
textMarkerRangeForElement functionality in our DRT/WKTR, and
because we expect embedded objects to show up in the results in a
GTK/EFL specific way (using the "<obj>" string).

  • platform/efl/accessibility/media-emits-object-replacement-expected.txt: Added.
  • platform/efl/accessibility/media-emits-object-replacement.html: Added.
  • platform/gtk/accessibility/media-emits-object-replacement-expected.txt: Added.
  • platform/gtk/accessibility/media-emits-object-replacement.html: Added.

Removed tests with failure expectations that are now passing.

  • platform/gtk/TestExpectations: Removed passing tests.
3:04 AM Changeset in webkit [158840] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix crash in BitmapImage::destroyDecodedData()
https://bugs.webkit.org/show_bug.cgi?id=116494

Patch by Laszlo Vidacs <lac@inf.u-szeged.hu> on 2013-11-07
Reviewed by Csaba Osztrogonác.

Merge from https://chromium.googlesource.com/chromium/blink/+/6b6887bf53068f8537908e501fdc7317ad2c6d86

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::destroyDecodedData):

2:53 AM Changeset in webkit [158839] by svillar@igalia.com
  • 6 edits in trunk

[CSS Grid Layout] CSSParser should reject <track-list> without a <track-size>
https://bugs.webkit.org/show_bug.cgi?id=118025

Reviewed by Andreas Kling.

Source/WebCore:

From Blink r152914 by <jchaffraix@chromium.org>

Make sure that we parse at least 1 <track-size> inside each
<track-list>. The old parser code allowed track-lists exclusively
made of <track-name>. The way it was implemented eases the future
addition of parsing for the repeat() function.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseGridTrackList):

  • css/StyleResolver.cpp:

(WebCore::createGridTrackList): ASSERT if we don't find any
<track-size> now that we detect their absence in the parser.

LayoutTests:

Added a new test that verifies that <track-list> exclusively made
of <track-name> are not supported.

  • fast/css-grid-layout/named-grid-line-get-set-expected.txt:
  • fast/css-grid-layout/named-grid-line-get-set.html:
2:45 AM Changeset in webkit [158838] by svillar@igalia.com
  • 13 edits in trunk

[CSS Grid Layout] Fix handling of 'inherit' and 'initial' for grid lines
https://bugs.webkit.org/show_bug.cgi?id=115401

Reviewed by Andreas Kling.

Source/WebCore:

From Blink r150585 by <jchaffraix@chromium.org>

Added support for 'inherit' and 'initial' special values to
grid-auto-{columns|rows} and grid-definition-{columns|rows}.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty): Resolve 'initial' and 'inherit'.

  • rendering/style/RenderStyle.h: Added initialNamedGrid{Column|Row}Lines().
  • rendering/style/StyleGridData.cpp:

(WebCore::StyleGridData::StyleGridData): Initialize m_namedGrid{Column|Row}Lines.

LayoutTests:

Added 'inherit' and 'initial' testing support to existing tests.

  • fast/css-grid-layout/grid-auto-columns-rows-get-set-expected.txt:
  • fast/css-grid-layout/grid-auto-columns-rows-get-set.html:
  • fast/css-grid-layout/grid-auto-flow-get-set-expected.txt:
  • fast/css-grid-layout/grid-auto-flow-get-set.html:
  • fast/css-grid-layout/grid-columns-rows-get-set-expected.txt:
  • fast/css-grid-layout/grid-columns-rows-get-set-multiple-expected.txt:
  • fast/css-grid-layout/resources/grid-columns-rows-get-set-multiple.js:

(testInherit): New helper function.
(testInitial): Ditto.

  • fast/css-grid-layout/resources/grid-columns-rows-get-set.js:

(testInherit): New helper function.
(testInitial): Ditto.

2:36 AM Changeset in webkit [158837] by Michał Pakuła vel Rutka
  • 30 edits in trunk/LayoutTests

Unreviewed gardening

Adjust test expectations after r158743.

  • fullscreen/video-controls-override-expected.txt:
  • http/tests/media/video-cookie-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_codecs_order_2-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_3-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_4-expected.txt:
  • media/context-menu-actions-expected.txt:
  • media/media-can-play-flac-audio-expected.txt:
  • media/media-volume-slider-rendered-below-expected.txt:
  • media/media-volume-slider-rendered-normal-expected.txt:
  • media/track/audio/audio-track-mkv-vorbis-addtrack-expected.txt:
  • media/track/audio/audio-track-mkv-vorbis-enabled-expected.txt:
  • media/track/track-cue-mutable-text-expected.txt:
  • media/track/track-cue-rendering-mode-changed-expected.txt:
  • media/track/track-language-preference-expected.txt:
  • media/track/video/video-track-mkv-theora-addtrack-expected.txt:
  • media/video-controls-fullscreen-volume-expected.txt:
  • media/video-controls-toggling-expected.txt:
  • media/video-controls-visible-exiting-fullscreen-expected.txt:
  • media/video-seek-past-end-paused-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt:
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt:
  • platform/efl/media/media-can-play-webm-expected.txt:
2:27 AM Changeset in webkit [158836] by akling@apple.com
  • 1 edit
    35 moves
    35 deletes in trunk/LayoutTests

Optimize baselines: svg/batik

Unreviewed; run "webkit-patch optimize-baselines svg/batik"

  • platform/gtk/svg/batik/filters/feTile-expected.txt: Removed.
  • platform/gtk/svg/batik/filters/filterRegions-expected.txt: Removed.
  • platform/gtk/svg/batik/masking/maskRegions-expected.txt: Removed.
  • platform/gtk/svg/batik/paints/gradientLimit-expected.txt: Removed.
  • platform/gtk/svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Removed.
  • platform/gtk/svg/batik/paints/patternRegionA-expected.txt: Removed.
  • platform/gtk/svg/batik/paints/patternRegions-expected.txt: Removed.
  • platform/gtk/svg/batik/paints/patternRegions-positioned-objects-expected.txt: Removed.
  • platform/gtk/svg/batik/text/longTextOnPath-expected.txt: Removed.
  • platform/gtk/svg/batik/text/smallFonts-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textAnchor-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textAnchor2-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textAnchor3-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textDecoration-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textDecoration2-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textEffect-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textEffect2-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textEffect3-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textFeatures-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textLayout-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textLayout2-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textLength-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textOnPath-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textOnPath2-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textOnPath3-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textOnPathSpaces-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textPCDATA-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textPosition-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textProperties-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textProperties2-expected.txt: Removed.
  • platform/gtk/svg/batik/text/textStyles-expected.txt: Removed.
  • platform/gtk/svg/batik/text/verticalText-expected.txt: Removed.
  • platform/gtk/svg/batik/text/verticalTextOnPath-expected.txt: Removed.
  • platform/gtk/svg/batik/text/xmlSpace-expected.txt: Removed.
  • svg/batik/filters/feTile-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/filters/feTile-expected.txt.
  • svg/batik/filters/filterRegions-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/filters/filterRegions-expected.txt.
  • svg/batik/masking/maskRegions-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/masking/maskRegions-expected.txt.
  • svg/batik/paints/gradientLimit-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/paints/gradientLimit-expected.txt.
  • svg/batik/paints/patternPreserveAspectRatioA-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/paints/patternPreserveAspectRatioA-expected.txt.
  • svg/batik/paints/patternRegionA-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/paints/patternRegionA-expected.txt.
  • svg/batik/paints/patternRegions-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/paints/patternRegions-expected.txt.
  • svg/batik/paints/patternRegions-positioned-objects-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/paints/patternRegions-positioned-objects-expected.txt.
  • svg/batik/text/longTextOnPath-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/longTextOnPath-expected.txt.
  • svg/batik/text/smallFonts-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/smallFonts-expected.txt.
  • svg/batik/text/textAnchor-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textAnchor-expected.txt.
  • svg/batik/text/textAnchor2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textAnchor2-expected.txt.
  • svg/batik/text/textAnchor3-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textAnchor3-expected.txt.
  • svg/batik/text/textDecoration-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textDecoration-expected.txt.
  • svg/batik/text/textDecoration2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textDecoration2-expected.txt.
  • svg/batik/text/textEffect-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textEffect-expected.txt.
  • svg/batik/text/textEffect2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textEffect2-expected.txt.
  • svg/batik/text/textEffect3-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textEffect3-expected.txt.
  • svg/batik/text/textFeatures-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textFeatures-expected.txt.
  • svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textGlyphOrientationHorizontal-expected.txt.
  • svg/batik/text/textLayout-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textLayout-expected.txt.
  • svg/batik/text/textLayout2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textLayout2-expected.txt.
  • svg/batik/text/textLength-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textLength-expected.txt.
  • svg/batik/text/textOnPath-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textOnPath-expected.txt.
  • svg/batik/text/textOnPath2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textOnPath2-expected.txt.
  • svg/batik/text/textOnPath3-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textOnPath3-expected.txt.
  • svg/batik/text/textOnPathSpaces-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textOnPathSpaces-expected.txt.
  • svg/batik/text/textPCDATA-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textPCDATA-expected.txt.
  • svg/batik/text/textPosition-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textPosition-expected.txt.
  • svg/batik/text/textProperties-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textProperties-expected.txt.
  • svg/batik/text/textProperties2-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textProperties2-expected.txt.
  • svg/batik/text/textStyles-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/textStyles-expected.txt.
  • svg/batik/text/verticalText-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/verticalText-expected.txt.
  • svg/batik/text/verticalTextOnPath-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/verticalTextOnPath-expected.txt.
  • svg/batik/text/xmlSpace-expected.txt: Renamed from LayoutTests/platform/efl/svg/batik/text/xmlSpace-expected.txt.
2:18 AM Changeset in webkit [158835] by akling@apple.com
  • 7 edits
    6 copies
    10 moves
    1 add
    22 deletes in trunk/LayoutTests

Optimize baselines: svg/as-background-image

Unreviewed; run "webkit-patch optimize-baselines svg/as-background-image"

  • platform/efl/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
  • platform/efl/svg/as-background-image/svg-as-background-2-expected.txt: Removed.
  • platform/efl/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
  • platform/efl/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
  • platform/efl/svg/as-background-image/svg-as-background-5-expected.txt: Removed.
  • platform/efl/svg/as-background-image/svg-as-background-6-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/animated-svg-as-background-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-1-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-2-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-3-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-4-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-5-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-6-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-expected.png: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-with-viewBox-expected.png: Removed.
  • platform/gtk/svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-as-tiled-background-expected.png: Removed.
  • platform/gtk/svg/as-background-image/svg-as-tiled-background-expected.txt: Removed.
  • platform/gtk/svg/as-background-image/svg-width-100p-as-background-expected.png: Removed.
  • platform/gtk/svg/as-background-image/svg-width-100p-as-background-expected.txt: Removed.
  • platform/win-future/svg/as-background-image/svg-as-background-1-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-1-expected.txt.
  • platform/win-future/svg/as-background-image/svg-as-background-2-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-2-expected.txt.
  • platform/win-future/svg/as-background-image/svg-as-background-3-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-3-expected.txt.
  • platform/win-future/svg/as-background-image/svg-as-background-4-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-4-expected.txt.
  • platform/win-future/svg/as-background-image/svg-as-background-5-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-5-expected.txt.
  • platform/win-future/svg/as-background-image/svg-as-background-6-expected.txt: Copied from LayoutTests/svg/as-background-image/svg-as-background-6-expected.txt.
  • svg/as-background-image/animated-svg-as-background-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/animated-svg-as-background-expected.txt.
  • svg/as-background-image/svg-as-background-1-expected.txt:
  • svg/as-background-image/svg-as-background-2-expected.txt:
  • svg/as-background-image/svg-as-background-3-expected.txt:
  • svg/as-background-image/svg-as-background-4-expected.txt:
  • svg/as-background-image/svg-as-background-5-expected.txt:
  • svg/as-background-image/svg-as-background-6-expected.txt:
  • svg/as-background-image/svg-as-background-expected.png: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-expected.png.
  • svg/as-background-image/svg-as-background-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-expected.txt.
  • svg/as-background-image/svg-as-background-with-relative-size-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-with-relative-size-expected.txt.
  • svg/as-background-image/svg-as-background-with-viewBox-expected.png: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-with-viewBox-expected.png.
  • svg/as-background-image/svg-as-background-with-viewBox-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-background-with-viewBox-expected.txt.
  • svg/as-background-image/svg-as-tiled-background-expected.png: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-tiled-background-expected.png.
  • svg/as-background-image/svg-as-tiled-background-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-as-tiled-background-expected.txt.
  • svg/as-background-image/svg-width-100p-as-background-expected.png: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-width-100p-as-background-expected.png.
  • svg/as-background-image/svg-width-100p-as-background-expected.txt: Renamed from LayoutTests/platform/efl/svg/as-background-image/svg-width-100p-as-background-expected.txt.
2:12 AM Changeset in webkit [158834] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Clean up BidiRun a little bit.
<https://webkit.org/b/123964>

Make BidiRun's member variables private and add accessors for them.
In doing so, codify the following:

  • BidiRun always has a corresponding RenderObject.
  • The inline box is never cleared after being set.

Reviewed by Antti Koivisto.

2:11 AM Changeset in webkit [158833] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

More CSSPrimitiveValue constructors should return PassRef.
<https://webkit.org/b/123953>

Make some more CSSPrimitiveValue constructor helpers (that are
known to never return null) return PassRef instead of PassRefPtr.

Reviewed by Antti Koivisto.

2:08 AM Changeset in webkit [158832] by akling@apple.com
  • 17 edits in trunk/Source/WebCore

Generate type casting helpers for line boxes and use them.
<https://webkit.org/b/123976>

Semi-automatically generate the full set of toFooInlineBox()
helpers with macros instead of having them (partially) hand-coded.
Replaced static_casts with the new helpers across the codebase.

Also made the isFooInlineBox() overrides private since they should
never be called when the type is already known.

Reviewed by Antti Koivisto.

2:04 AM Changeset in webkit [158831] by Chris Fleizach
  • 425 edits
    4 adds in branches/safari-537.73-branch

Merge r158743

Source/WebCore:

2013-11-06 Chris Fleizach <Chris Fleizach>


AX: Audio and Video attachments are not output to VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=123479

Reviewed by Mario Sanchez Prada.

Video and audio elements don't appear as distinct objects in the AX hierarchy,
nor are they treated as replaceable objects when emitting the text. We should
treat these characters like attachments, for one. On the Mac platform, we should
also identify them with special subroles.

Tests: platform/mac/accessibility/media-emits-object-replacement.html

platform/mac/accessibility/media-role-descriptions.html


  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isGenericFocusableElement):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):

  • editing/TextIterator.cpp:

(WebCore::isRendererReplacedElement):

LayoutTests:

2013-11-06 Chris Fleizach <Chris Fleizach>

AX: Audio and Video attachments are not output to VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=123479

Reviewed by Mario Sanchez Prada.

Making media elements int replaced elements has the unfortunate side-effect
of causing a new line to be inserted into any test using a <video> or <audio> tag.

  • compositing/video/video-poster-expected.txt:
  • compositing/video/video-reflection-expected.txt:
  • compositing/visibility/visibility-simple-video-layer-expected.txt:
  • fast/css/first-letter-block-form-controls-crash-expected.txt:
  • fast/css/relative-position-replaced-in-table-display-crash-expected.txt:
  • fast/forms/access-key-for-all-elements-expected.txt:
  • fast/forms/form-associated-element-crash3-expected.txt:
  • fast/multicol/renderer-positioned-assert-crash-expected.txt:
  • fast/regions/full-screen-video-from-region-expected.txt:
  • fast/runin/nonblock-runin-expected.txt:
  • fast/spatial-navigation/snav-media-elements-expected.txt:
  • fullscreen/full-screen-crash-offsetLeft-expected.txt:
  • fullscreen/full-screen-no-style-sharing-expected.txt:
  • fullscreen/full-screen-stacking-context-expected.txt:
  • fullscreen/video-controls-drag-expected.txt:
  • fullscreen/video-controls-timeline-expected.txt:
  • fullscreen/video-cursor-auto-hide-expected.txt:
  • fullscreen/video-specified-size-expected.txt:
  • http/tests/appcache/video-expected.txt:
  • http/tests/media/pdf-served-as-pdf-expected.txt:
  • http/tests/media/reload-after-dialog-expected.txt:
  • http/tests/media/text-served-as-text-expected.txt:
  • http/tests/media/video-accept-encoding-expected.txt:
  • http/tests/media/video-buffered-range-contains-currentTime-expected.txt:
  • http/tests/media/video-cross-site-expected.txt:
  • http/tests/media/video-error-abort-expected.txt:
  • http/tests/media/video-load-suspend-expected.txt:
  • http/tests/media/video-play-progress-expected.txt:
  • http/tests/media/video-play-stall-before-meta-data-expected.txt:
  • http/tests/media/video-preload-expected.txt:
  • http/tests/media/video-redirect-expected.txt:
  • http/tests/media/video-referer-expected.txt:
  • http/tests/media/video-served-as-text-expected.txt:
  • http/tests/media/video-throttled-load-metadata-expected.txt:
  • http/tests/misc/empty-urls-expected.txt:
  • http/tests/security/contentSecurityPolicy/media-src-allowed-expected.txt:
  • http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
  • http/tests/security/local-video-poster-from-remote-expected.txt:
  • http/tests/security/local-video-source-from-remote-expected.txt:
  • http/tests/security/local-video-src-from-remote-expected.txt:
  • http/tests/security/text-track-crossorigin-expected.txt:
  • media/W3C/audio/events/event_canplay-expected.txt:
  • media/W3C/audio/events/event_canplay_manual-expected.txt:
  • media/W3C/audio/events/event_canplaythrough-expected.txt:
  • media/W3C/audio/events/event_canplaythrough_manual-expected.txt:
  • media/W3C/audio/events/event_loadeddata-expected.txt:
  • media/W3C/audio/events/event_loadeddata_manual-expected.txt:
  • media/W3C/audio/events/event_loadedmetadata-expected.txt:
  • media/W3C/audio/events/event_loadedmetadata_manual-expected.txt:
  • media/W3C/audio/events/event_loadstart-expected.txt:
  • media/W3C/audio/events/event_loadstart_manual-expected.txt:
  • media/W3C/audio/events/event_order_canplay_canplaythrough-expected.txt:
  • media/W3C/audio/events/event_order_canplay_playing-expected.txt:
  • media/W3C/audio/events/event_order_loadedmetadata_loadeddata-expected.txt:
  • media/W3C/audio/events/event_order_loadstart_progress-expected.txt:
  • media/W3C/audio/events/event_pause_manual-expected.txt:
  • media/W3C/audio/events/event_play-expected.txt:
  • media/W3C/audio/events/event_play_manual-expected.txt:
  • media/W3C/audio/events/event_playing-expected.txt:
  • media/W3C/audio/events/event_playing_manual-expected.txt:
  • media/W3C/audio/events/event_progress-expected.txt:
  • media/W3C/audio/events/event_progress_manual-expected.txt:
  • media/W3C/audio/events/event_timeupdate-expected.txt:
  • media/W3C/audio/events/event_timeupdate_manual-expected.txt:
  • media/W3C/audio/networkState/networkState_during_loadstart-expected.txt:
  • media/W3C/audio/paused/paused_false_during_play-expected.txt:
  • media/W3C/audio/paused/paused_true_during_pause-expected.txt:
  • media/W3C/audio/readyState/readyState_during_canplay-expected.txt:
  • media/W3C/audio/readyState/readyState_during_canplaythrough-expected.txt:
  • media/W3C/audio/readyState/readyState_during_loadeddata-expected.txt:
  • media/W3C/audio/readyState/readyState_during_loadedmetadata-expected.txt:
  • media/W3C/audio/readyState/readyState_during_playing-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_1-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_2-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_3-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_bogus_type-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_method_exists-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt:
  • media/W3C/video/currentSrc/currentSrc_empty_if_no_src-expected.txt:
  • media/W3C/video/currentSrc/currentSrc_property_exists-expected.txt:
  • media/W3C/video/error/error_null-expected.txt:
  • media/W3C/video/error/error_onerror_called_on_bogus_source-expected.txt:
  • media/W3C/video/error/error_property_exists-expected.txt:
  • media/W3C/video/events/event_canplay-expected.txt:
  • media/W3C/video/events/event_canplay_manual-expected.txt:
  • media/W3C/video/events/event_canplaythrough-expected.txt:
  • media/W3C/video/events/event_canplaythrough_manual-expected.txt:
  • media/W3C/video/events/event_loadeddata-expected.txt:
  • media/W3C/video/events/event_loadeddata_manual-expected.txt:
  • media/W3C/video/events/event_loadedmetadata-expected.txt:
  • media/W3C/video/events/event_loadedmetadata_manual-expected.txt:
  • media/W3C/video/events/event_loadstart-expected.txt:
  • media/W3C/video/events/event_loadstart_manual-expected.txt:
  • media/W3C/video/events/event_order_canplay_canplaythrough-expected.txt:
  • media/W3C/video/events/event_order_canplay_playing-expected.txt:
  • media/W3C/video/events/event_order_loadedmetadata_loadeddata-expected.txt:
  • media/W3C/video/events/event_order_loadstart_progress-expected.txt:
  • media/W3C/video/events/event_pause_manual-expected.txt:
  • media/W3C/video/events/event_play-expected.txt:
  • media/W3C/video/events/event_play_manual-expected.txt:
  • media/W3C/video/events/event_playing-expected.txt:
  • media/W3C/video/events/event_playing_manual-expected.txt:
  • media/W3C/video/events/event_progress-expected.txt:
  • media/W3C/video/events/event_progress_manual-expected.txt:
  • media/W3C/video/events/event_timeupdate-expected.txt:
  • media/W3C/video/events/event_timeupdate_manual-expected.txt:
  • media/W3C/video/networkState/networkState_during_loadstart-expected.txt:
  • media/W3C/video/networkState/networkState_during_progress-expected.txt:
  • media/W3C/video/networkState/networkState_initial-expected.txt:
  • media/W3C/video/networkState/networkState_property_exists-expected.txt:
  • media/W3C/video/paused/paused_false_during_play-expected.txt:
  • media/W3C/video/paused/paused_true_during_pause-expected.txt:
  • media/W3C/video/preload/preload_property_exists-expected.txt:
  • media/W3C/video/preload/preload_reflects_auto_value-expected.txt:
  • media/W3C/video/preload/preload_reflects_bogus_value-expected.txt:
  • media/W3C/video/preload/preload_reflects_empty-expected.txt:
  • media/W3C/video/preload/preload_reflects_metadata-expected.txt:
  • media/W3C/video/preload/preload_reflects_no_value-expected.txt:
  • media/W3C/video/preload/preload_reflects_none-expected.txt:
  • media/W3C/video/preload/preload_reflects_none_autoplay-expected.txt:
  • media/W3C/video/readyState/readyState_during_canplay-expected.txt:
  • media/W3C/video/readyState/readyState_during_canplaythrough-expected.txt:
  • media/W3C/video/readyState/readyState_during_loadeddata-expected.txt:
  • media/W3C/video/readyState/readyState_during_loadedmetadata-expected.txt:
  • media/W3C/video/readyState/readyState_during_playing-expected.txt:
  • media/W3C/video/readyState/readyState_initial-expected.txt:
  • media/W3C/video/readyState/readyState_property_exists-expected.txt:
  • media/W3C/video/src/src_reflects_attribute_not_source_elements-expected.txt:
  • media/W3C/video/src/src_reflects_no_value-expected.txt:
  • media/W3C/video/src/src_removal_does_not_trigger_loadstart-expected.txt:
  • media/audio-mpeg-supported-expected.txt:
  • media/audio-mpeg4-supported-expected.txt:
  • media/audio-only-video-intrinsic-size-expected.txt:
  • media/auto-play-in-sandbox-with-allow-scripts-expected.txt:
  • media/before-load-member-access-expected.txt:
  • media/broken-video-expected.txt:
  • media/constructors-expected.txt:
  • media/controls-css-overload-expected.txt:
  • media/controls-drag-timebar-expected.txt:
  • media/controls-layout-direction-expected.txt:
  • media/controls-right-click-on-timebar-expected.txt:
  • media/csp-blocks-video-expected.txt:
  • media/event-attributes-expected.txt:
  • media/media-blocked-by-beforeload-expected.txt:
  • media/media-blocked-by-willsendrequest-expected.txt:
  • media/media-can-play-mpeg-audio-expected.txt:
  • media/media-can-play-mpeg4-video-expected.txt:
  • media/media-can-play-octet-stream-expected.txt:
  • media/media-can-play-type-expected.txt:
  • media/media-can-play-wav-audio-expected.txt:
  • media/media-captions-expected.txt:
  • media/media-captions-no-controls-expected.txt:
  • media/media-controller-expected.txt:
  • media/media-controller-playback-expected.txt:
  • media/media-controller-playbackrate-expected.txt:
  • media/media-controller-time-clamp-expected.txt:
  • media/media-controller-time-constant-expected.txt:
  • media/media-controller-time-expected.txt:
  • media/media-controller-timeupdate-expected.txt:
  • media/media-controller-unpause-expected.txt:
  • media/media-controls-invalid-url-expected.txt:
  • media/media-ended-expected.txt:
  • media/media-extension-with-fragment-expected.txt:
  • media/media-fragments/TC0001-expected.txt:
  • media/media-fragments/TC0002-expected.txt:
  • media/media-fragments/TC0003-expected.txt:
  • media/media-fragments/TC0004-expected.txt:
  • media/media-fragments/TC0005-expected.txt:
  • media/media-fragments/TC0006-expected.txt:
  • media/media-fragments/TC0009-expected.txt:
  • media/media-fragments/TC0011-expected.txt:
  • media/media-fragments/TC0012-expected.txt:
  • media/media-fragments/TC0014-expected.txt:
  • media/media-fragments/TC0015-expected.txt:
  • media/media-fragments/TC0017-expected.txt:
  • media/media-fragments/TC0024-expected.txt:
  • media/media-fragments/TC0027-expected.txt:
  • media/media-fragments/TC0028-expected.txt:
  • media/media-fragments/TC0029-expected.txt:
  • media/media-fragments/TC0030-expected.txt:
  • media/media-fragments/TC0031-expected.txt:
  • media/media-fragments/TC0032-expected.txt:
  • media/media-fragments/TC0033-expected.txt:
  • media/media-fragments/TC0034-expected.txt:
  • media/media-fragments/TC0035-expected.txt:
  • media/media-fragments/TC0036-expected.txt:
  • media/media-fragments/TC0037-expected.txt:
  • media/media-fragments/TC0038-expected.txt:
  • media/media-fragments/TC0039-expected.txt:
  • media/media-fragments/TC0044-expected.txt:
  • media/media-fragments/TC0051-expected.txt:
  • media/media-fragments/TC0052-expected.txt:
  • media/media-fragments/TC0053-expected.txt:
  • media/media-fragments/TC0054-expected.txt:
  • media/media-fragments/TC0055-expected.txt:
  • media/media-fragments/TC0058-expected.txt:
  • media/media-fragments/TC0059-expected.txt:
  • media/media-fragments/TC0061-expected.txt:
  • media/media-fragments/TC0062-expected.txt:
  • media/media-fragments/TC0063-expected.txt:
  • media/media-fragments/TC0064-expected.txt:
  • media/media-fragments/TC0065-expected.txt:
  • media/media-fragments/TC0066-expected.txt:
  • media/media-fragments/TC0067-expected.txt:
  • media/media-fragments/TC0068-expected.txt:
  • media/media-fragments/TC0069-expected.txt:
  • media/media-fragments/TC0070-expected.txt:
  • media/media-fragments/TC0071-expected.txt:
  • media/media-fragments/TC0072-expected.txt:
  • media/media-fragments/TC0073-expected.txt:
  • media/media-fragments/TC0074-expected.txt:
  • media/media-fragments/TC0075-expected.txt:
  • media/media-fragments/TC0076-expected.txt:
  • media/media-fragments/TC0077-expected.txt:
  • media/media-fragments/TC0078-expected.txt:
  • media/media-fragments/TC0079-expected.txt:
  • media/media-fragments/TC0080-expected.txt:
  • media/media-fragments/TC0081-expected.txt:
  • media/media-fragments/TC0082-expected.txt:
  • media/media-fragments/TC0083-expected.txt:
  • media/media-fragments/TC0084-expected.txt:
  • media/media-fragments/TC0085-expected.txt:
  • media/media-fragments/TC0086-expected.txt:
  • media/media-fragments/TC0087-expected.txt:
  • media/media-fragments/TC0088-expected.txt:
  • media/media-fragments/TC0089-expected.txt:
  • media/media-fragments/TC0090-expected.txt:
  • media/media-fragments/TC0091-expected.txt:
  • media/media-fragments/TC0092-expected.txt:
  • media/media-fragments/TC0093-expected.txt:
  • media/media-fragments/TC0094-expected.txt:
  • media/media-fullscreen-inline-expected.txt:
  • media/media-preload-no-delay-loadevent-expected.txt:
  • media/no-autoplay-with-user-gesture-requirement-expected.txt:
  • media/nodesFromRect-shadowContent-expected.txt:
  • media/restore-from-page-cache-expected.txt:
  • media/sources-fallback-codecs-expected.txt:
  • media/track/add-and-remove-track-expected.txt:
  • media/track/audio-track-expected.txt:
  • media/track/opera/interfaces/TextTrack/addCue-expected.txt:
  • media/track/opera/interfaces/TextTrack/removeCue-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/align-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/endTime-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/id-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/pauseOnExit-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/startTime-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/track-expected.txt:
  • media/track/opera/interfaces/TextTrackCueList/getCueById-expected.txt:
  • media/track/opera/interfaces/TextTrackCueList/length-expected.txt:
  • media/track/text-track-cue-is-reachable-expected.txt:
  • media/track/text-track-is-reachable-expected.txt:
  • media/track/track-active-cues-expected.txt:
  • media/track/track-add-remove-cue-expected.txt:
  • media/track/track-add-track-expected.txt:
  • media/track/track-addtrack-kind-expected.txt:
  • media/track/track-automatic-subtitles-expected.txt:
  • media/track/track-css-all-cues-expected.txt:
  • media/track/track-css-cue-lifetime-expected.txt:
  • media/track/track-css-matching-default-expected.txt:
  • media/track/track-css-matching-expected.txt:
  • media/track/track-css-matching-lang-expected.txt:
  • media/track/track-css-matching-timestamps-expected.txt:
  • media/track/track-css-property-whitelist-expected.txt:
  • media/track/track-css-user-override-expected.txt:
  • media/track/track-cue-container-rendering-position-expected.txt:
  • media/track/track-cue-empty-text-crash-expected.txt:
  • media/track/track-cue-inline-assertion-crash-expected.txt:
  • media/track/track-cue-mutable-expected.txt:
  • media/track/track-cue-mutable-fragment-expected.txt:
  • media/track/track-cue-negative-timestamp-expected.txt:
  • media/track/track-cue-nothing-to-render-expected.txt:
  • media/track/track-cue-overlap-snap-to-lines-not-set-expected.txt:
  • media/track/track-cue-rendering-empty-cue-crash-expected.txt:
  • media/track/track-cue-rendering-expected.txt:
  • media/track/track-cue-rendering-on-resize-expected.txt:
  • media/track/track-cue-rendering-rtl-expected.txt:
  • media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt:
  • media/track/track-cue-rendering-tree-is-removed-properly-expected.txt:
  • media/track/track-cue-rendering-with-padding-expected.txt:
  • media/track/track-cues-cuechange-expected.txt:
  • media/track/track-cues-enter-exit-expected.txt:
  • media/track/track-cues-missed-expected.txt:
  • media/track/track-cues-pause-on-exit-expected.txt:
  • media/track/track-cues-seeking-expected.txt:
  • media/track/track-cues-sorted-before-dispatch-expected.txt:
  • media/track/track-default-attribute-expected.txt:
  • media/track/track-disabled-addcue-expected.txt:
  • media/track/track-disabled-expected.txt:
  • media/track/track-element-load-event-expected.txt:
  • media/track/track-in-band-cues-added-once-expected.txt:
  • media/track/track-in-band-duplicate-tracks-when-source-changes-expected.txt:
  • media/track/track-in-band-expected.txt:
  • media/track/track-in-band-legacy-api-expected.txt:
  • media/track/track-in-band-style-expected.txt:
  • media/track/track-kind-expected.txt:
  • media/track/track-large-timestamp-expected.txt:
  • media/track/track-legacyapi-with-automatic-mode-expected.txt:
  • media/track/track-load-from-element-readyState-expected.txt:
  • media/track/track-load-from-src-readyState-expected.txt:
  • media/track/track-long-captions-file-expected.txt:
  • media/track/track-mode-disabled-crash-expected.txt:
  • media/track/track-mode-expected.txt:
  • media/track/track-mode-not-changed-by-new-track-expected.txt:
  • media/track/track-mode-triggers-loading-expected.txt:
  • media/track/track-remove-active-cue-crash-expected.txt:
  • media/track/track-remove-by-setting-innerHTML-expected.txt:
  • media/track/track-remove-quickly-expected.txt:
  • media/track/track-text-track-cue-list-expected.txt:
  • media/track/track-texttracks-expected.txt:
  • media/track/track-webvtt-tc000-empty-expected.txt:
  • media/track/track-webvtt-tc001-utf8-expected.txt:
  • media/track/track-webvtt-tc002-bom-expected.txt:
  • media/track/track-webvtt-tc003-newlines-expected.txt:
  • media/track/track-webvtt-tc004-magic-header-expected.txt:
  • media/track/track-webvtt-tc005-header-comment-expected.txt:
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt:
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt:
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt:
  • media/track/track-webvtt-tc009-timings-hour-expected.txt:
  • media/track/track-webvtt-tc010-no-timings-expected.txt:
  • media/track/track-webvtt-tc011-blank-lines-expected.txt:
  • media/track/track-webvtt-tc013-settings-expected.txt:
  • media/track/track-webvtt-tc014-alignment-expected.txt:
  • media/track/track-webvtt-tc015-positioning-expected.txt:
  • media/track/track-webvtt-tc016-align-positioning-expected.txt:
  • media/track/track-webvtt-tc017-line-position-expected.txt:
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt:
  • media/track/track-webvtt-tc019-cue-size-expected.txt:
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt:
  • media/track/track-webvtt-tc021-valign-expected.txt:
  • media/track/track-webvtt-tc022-entities-expected.txt:
  • media/track/track-webvtt-tc023-markup-expected.txt:
  • media/track/track-webvtt-tc024-timestamp-expected.txt:
  • media/track/track-webvtt-tc025-class-markup-expected.txt:
  • media/track/track-webvtt-tc026-voice-expected.txt:
  • media/track/track-webvtt-tc027-empty-cue-expected.txt:
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt:
  • media/track/track-word-breaking-expected.txt:
  • media/track/tracklist-is-reachable-expected.txt:
  • media/track/video-track-expected.txt:
  • media/unsupported-rtsp-expected.txt:
  • media/unsupported-tracks-expected.txt:
  • media/video-append-source-expected.txt:
  • media/video-autoplay-expected.txt:
  • media/video-beforeload-remove-source-expected.txt:
  • media/video-buffered-expected.txt:
  • media/video-canvas-drawing-expected.txt:
  • media/video-canvas-drawing-output-expected.txt:
  • media/video-controls-captions-trackmenu-hide-on-click-outside-expected.txt:
  • media/video-controls-captions-trackmenu-includes-enabled-track-expected.txt:
  • media/video-controls-expected.txt:
  • media/video-controls-transformed-expected.txt:
  • media/video-controls-with-mutation-event-handler-expected.txt:
  • media/video-controls-zoomed-expected.txt:
  • media/video-currentTime-delay-expected.txt:
  • media/video-currentTime-expected.txt:
  • media/video-currentTime-set-expected.txt:
  • media/video-currentTime-set2-expected.txt:
  • media/video-delay-load-event-expected.txt:
  • media/video-display-aspect-ratio-expected.txt:
  • media/video-dom-autoplay-expected.txt:
  • media/video-dom-preload-expected.txt:
  • media/video-dom-src-expected.txt:
  • media/video-duration-known-after-eos-expected.txt:
  • media/video-error-does-not-exist-expected.txt:
  • media/video-load-networkState-expected.txt:
  • media/video-load-preload-metadata-expected.txt:
  • media/video-load-preload-none-expected.txt:
  • media/video-load-readyState-expected.txt:
  • media/video-load-require-user-gesture-expected.txt:
  • media/video-loop-expected.txt:
  • media/video-mouse-focus-expected.txt:
  • media/video-muted-expected.txt:
  • media/video-no-autoplay-expected.txt:
  • media/video-pause-empty-events-expected.txt:
  • media/video-pause-immediately-expected.txt:
  • media/video-play-empty-events-expected.txt:
  • media/video-play-pause-events-expected.txt:
  • media/video-play-pause-exception-expected.txt:
  • media/video-play-require-user-gesture-expected.txt:
  • media/video-playbackrate-expected.txt:
  • media/video-played-collapse-expected.txt:
  • media/video-played-ranges-1-expected.txt:
  • media/video-played-reset-expected.txt:
  • media/video-plays-past-end-of-test-expected.txt:
  • media/video-poster-blocked-by-willsendrequest-expected.txt:
  • media/video-poster-delayed-expected.txt:
  • media/video-poster-expected.txt:
  • media/video-poster-scale-expected.txt:
  • media/video-preload-expected.txt:
  • media/video-replaces-poster-expected.txt:
  • media/video-reverse-play-duration-expected.txt:
  • media/video-seek-after-end-expected.txt:
  • media/video-seek-by-small-increment-expected.txt:
  • media/video-seek-multiple-expected.txt:
  • media/video-seek-no-src-exception-expected.txt:
  • media/video-seek-past-end-playing-expected.txt:
  • media/video-seekable-expected.txt:
  • media/video-seeking-expected.txt:
  • media/video-set-rate-from-pause-expected.txt:
  • media/video-single-valid-source-expected.txt:
  • media/video-size-expected.txt:
  • media/video-source-error-expected.txt:
  • media/video-source-error-no-candidate-expected.txt:
  • media/video-source-expected.txt:
  • media/video-source-inserted-expected.txt:
  • media/video-source-load-expected.txt:
  • media/video-source-none-supported-expected.txt:
  • media/video-source-type-expected.txt:
  • media/video-src-blob-expected.txt:
  • media/video-src-change-expected.txt:
  • media/video-src-empty-expected.txt:
  • media/video-src-expected.txt:
  • media/video-src-invalid-poster-expected.txt:
  • media/video-src-invalid-remove-expected.txt:
  • media/video-src-none-expected.txt:
  • media/video-src-plus-source-expected.txt:
  • media/video-src-remove-expected.txt:
  • media/video-src-set-expected.txt:
  • media/video-src-source-expected.txt:
  • media/video-timeupdate-during-playback-expected.txt:
  • media/video-timeupdate-reverse-play-expected.txt:
  • media/video-volume-expected.txt:
  • media/video-width-height-expected.txt:
  • platform/mac/accessibility/media-element-expected.txt:
  • platform/mac/accessibility/media-emits-object-replacement-expected.txt: Added.
  • platform/mac/accessibility/media-emits-object-replacement.html: Added.
  • platform/mac/accessibility/media-role-descriptions-expected.txt: Added.
  • platform/mac/accessibility/media-role-descriptions.html: Added.
  • platform/mac/compositing/video/video-object-fit-expected.txt:
  • platform/mac/fullscreen/video-controls-override-expected.txt:
  • platform/mac/media/media-can-play-wav-audio-expected.txt:
  • platform/mac/media/media-can-play-webm-expected.txt:
  • platform/mac/media/video-seek-past-end-paused-expected.txt:
2:02 AM Changeset in webkit [158830] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix build for architectures with 4 argument registers (broken since r158820).
https://bugs.webkit.org/show_bug.cgi?id=123969

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-07
Reviewed by Andreas Kling.

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArguments):

1:32 AM Changeset in webkit [158829] by rniwa@webkit.org
  • 4 edits in trunk/Source/WebCore

Simplify Attr by removing m_specified member variable and setter
https://bugs.webkit.org/show_bug.cgi?id=123965

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/597f44ec928e08820574728889adabc6d8ecd746

m_specified is always true in WebKit so simply return true in Attr::specified().

  • dom/Attr.cpp:

(WebCore::Attr::Attr):

  • dom/Attr.h:
  • dom/Document.cpp:

(WebCore::Document::adoptNode):

1:21 AM Changeset in webkit [158828] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Change git_commit_from_svn_revision() to work in a pure git checkout
https://bugs.webkit.org/show_bug.cgi?id=111668

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2013-11-07
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/common/checkout/scm/git.py:

(Git.git_commit_from_svn_revision):

12:05 AM Changeset in webkit [158827] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[Gtk] Remove old takeFocus() method from PageClientImpl and mark methods as OVERRIDE
https://bugs.webkit.org/show_bug.cgi?id=123919

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-07
Reviewed by Carlos Garcia Campos.

  • UIProcess/API/gtk/PageClientImpl.cpp: Remove takeFocus().
  • UIProcess/API/gtk/PageClientImpl.h: Remove takeFocus() and mark methods as OVERRIDE.

Nov 6, 2013:

10:41 PM Changeset in webkit [158826] by Lucas Forschler
  • 5 edits in trunk/Source

Versioning.

10:39 PM Changeset in webkit [158825] by Lucas Forschler
  • 1 copy in tags/Safari-538.5

New Tag.

10:01 PM Changeset in webkit [158824] by Lucas Forschler
  • 5 edits in branches/safari-537.73-branch/Source

Versioning.

9:59 PM Changeset in webkit [158823] by Lucas Forschler
  • 1 copy in tags/Safari-537.73.4

New Tag.

9:38 PM Changeset in webkit [158822] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

FTL should support CheckFunction
https://bugs.webkit.org/show_bug.cgi?id=123862

Reviewed by Sam Weinig.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCheckFunction):

9:26 PM Changeset in webkit [158821] by jer.noble@apple.com
  • 35 edits
    8 copies in trunk/Source/WebCore

[MSE] Add MediaSource extensions to AudioTrack, VideoTrack, and TextTrack.
https://bugs.webkit.org/show_bug.cgi?id=123374

Reviewed by Eric Carlson.

No tests added; tests will be added when Mock implementations are added in a future patch.

Add new partial interfaces for added methods on AudioTrack, TextTrack, and VideoTrack:

  • Modules/mediasource/AudioTrackMediaSource.idl: Add read-only sourceBuffer attribute.
  • Modules/mediasource/TextTrackMediaSource.idl: Ditto.
  • Modules/mediasource/VideoTrackMediaSource.idl: Ditto.
  • Modules/mediasource/AudioTrackMediaSource.h:

(WebCore::AudioTrackMediaSource::sourceBuffer): Added static wrapper around non-static sourceBuffer().

  • Modules/mediasource/TextTrackMediaSource.h:

(WebCore::TextTrackMediaSource::sourceBuffer): Ditto.

  • Modules/mediasource/VideoTrackMediaSource.h:

(WebCore::VideoTrackMediaSource::sourceBuffer): Ditto.

Add support for writable kind & language attributes through a custom setter:

  • bindings/js/JSAudioTrackCustom.cpp:

(WebCore::JSAudioTrack::setKind):
(WebCore::JSAudioTrack::setLanguage):

  • bindings/js/JSTextTrackCustom.cpp:

(WebCore::JSTextTrack::setKind):
(WebCore::JSTextTrack::setLanguage):

  • bindings/js/JSVideoTrackCustom.cpp:

(WebCore::JSVideoTrack::setKind):
(WebCore::JSVideoTrack::setLanguage):

  • html/track/AudioTrack.idl:
  • html/track/TextTrack.idl:
  • html/track/VideoTrack.idl:

Add setter methods to the implementation classes:

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::TextTrack):
(WebCore::TextTrack::setKind):
(WebCore::TextTrack::setLanguage):

  • html/track/TextTrack.h:
  • html/track/TrackBase.cpp:

(WebCore::TrackBase::TrackBase):
(WebCore::TrackBase::setKind):
(WebCore::TrackBase::setKindInternal):

  • html/track/TrackBase.h:

(WebCore::TrackBase::setLanguage):
(WebCore::TrackBase::sourceBuffer):
(WebCore::TrackBase::setSourceBuffer):

  • html/track/VideoTrack.cpp:

(WebCore::VideoTrack::VideoTrack):
(WebCore::VideoTrack::setKind):
(WebCore::VideoTrack::setLanguage):

  • html/track/VideoTrack.h:

Implement the unimplemented portions of MediaSource and SourceBuffer:

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::removeSourceBuffer):

  • Modules/mediasource/MediaSourceBase.cpp:

(WebCore::MediaSourceBase::MediaSourceBase):
(WebCore::MediaSourceBase::setPrivateAndOpen):
(WebCore::MediaSourceBase::setReadyState):
(WebCore::MediaSourceBase::attachToElement):

  • Modules/mediasource/MediaSourceBase.h:

(WebCore::MediaSourceBase::mediaElement):

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::videoTracks):
(WebCore::SourceBuffer::audioTracks):
(WebCore::SourceBuffer::textTracks):
(WebCore::SourceBuffer::sourceBufferPrivateDidAddAudioTrack):
(WebCore::SourceBuffer::sourceBufferPrivateDidAddVideoTrack):
(WebCore::SourceBuffer::sourceBufferPrivateDidAddTextTrack):
(WebCore::SourceBuffer::sourceBufferPrivateDidChangeActiveState):

  • Modules/mediasource/SourceBuffer.h:
  • Modules/mediasource/SourceBuffer.idl:

Add new files to the project:

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:

And a smorgasbord of other utility changes:

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadResource): Pass this when attaching.
(WebCore::HTMLMediaElement::mediaPlayerDidAddTextTrack): Ditto.

  • html/HTMLMediaSource.h:
  • html/track/TextTrackList.cpp:

(TextTrackList::item): Make const.

  • html/track/TextTrackList.h:

(WebCore::TextTrackList::lastItem): Added.

  • platform/graphics/InbandTextTrackPrivate.h:

(WebCore::InbandTextTrackPrivate::create): Added.
(WebCore::MockSourceBufferPrivate::trackDidChangeEnabled):

9:05 PM Changeset in webkit [158820] by fpizlo@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

IC code should handle the call frame register not being the callFrameRegister
https://bugs.webkit.org/show_bug.cgi?id=123865

Reviewed by Geoffrey Garen.

For now, in the FTL, the call frame may be something other than our frame pointer,
since it's an argument passed in according to whatever convention LLVM picks.

This is temporary in two ways - pretty soon the callFrameRegister will be the actual
frame pointer and not some other register, and LLVM will not pass the frame pointer
as an argument to IC's.

  • bytecode/StructureStubInfo.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::cachedGetById):
(JSC::DFG::SpeculativeJIT::cachedPutById):

  • ftl/FTLCompile.cpp:

(JSC::FTL::fixFunctionBasedOnStackMaps):

  • ftl/FTLInlineCacheSize.cpp:

(JSC::FTL::sizeOfGetById):
(JSC::FTL::sizeOfPutById):

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArguments):

  • jit/JITInlineCacheGenerator.cpp:

(JSC::JITByIdGenerator::JITByIdGenerator):
(JSC::JITPutByIdGenerator::JITPutByIdGenerator):

  • jit/JITInlineCacheGenerator.h:

(JSC::JITGetByIdGenerator::JITGetByIdGenerator):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):

  • jit/Repatch.cpp:

(JSC::tryBuildGetByIDList):
(JSC::emitPutTransitionStub):

8:43 PM Changeset in webkit [158819] by mitz@apple.com
  • 2 edits
    1 move in trunk/Source/WebKit2

Moved UIProcess/Cocoa to UIProcess/API/Cocoa.

Rubber-stamped by Anders Carlsson.

  • UIProcess/API/Cocoa: Copied from Source/WebKit2/UIProcess/Cocoa.
  • UIProcess/Cocoa: Removed.
  • UIProcess/Cocoa/WKBackForwardList.h: Removed.
  • UIProcess/Cocoa/WKBackForwardList.mm: Removed.
  • UIProcess/Cocoa/WKBackForwardListInternal.h: Removed.
  • UIProcess/Cocoa/WKBackForwardListItem.h: Removed.
  • UIProcess/Cocoa/WKBackForwardListItem.mm: Removed.
  • UIProcess/Cocoa/WKBackForwardListItemInternal.h: Removed.
  • UIProcess/Cocoa/WKBrowsingContextHistoryDelegate.h: Removed.
  • UIProcess/Cocoa/WKNavigationData.h: Removed.
  • UIProcess/Cocoa/WKNavigationData.mm: Removed.
  • UIProcess/Cocoa/WKNavigationDataInternal.h: Removed.
  • WebKit2.xcodeproj/project.pbxproj:
8:22 PM Changeset in webkit [158818] by akling@apple.com
  • 6 edits
    5 copies
    253 moves
    1 add
    263 deletes in trunk/LayoutTests

Optimize baselines: svg/W3C-SVG-1.1

Unreviewed; run "webkit-patch optimize-baselines svg/W3C-SVG-1.1"

  • platform/efl/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/color-prof-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/interact-events-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/interact-order-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-10-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-13-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-14-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/paths-data-15-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/render-elems-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/render-elems-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/render-elems-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-group-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-group-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-04-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-05-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-06-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-08-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-09-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-image-10-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-align-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-align-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-align-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-align-04-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-align-05-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-align-06-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-text-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-text-07-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-text-08-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-tref-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-ws-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/text-ws-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: Removed.
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Removed.
  • platform/win-future/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt.
  • platform/win-future/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt.
  • platform/win-future/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt.
  • platform/win-future/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt.
  • platform/win-future/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt.
  • platform/win-future/svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt: Renamed from LayoutTests/svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt.
  • svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt.
  • svg/W3C-SVG-1.1/color-prof-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/color-prof-01-f-expected.txt.
  • svg/W3C-SVG-1.1/color-prop-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt.
  • svg/W3C-SVG-1.1/color-prop-02-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt.
  • svg/W3C-SVG-1.1/color-prop-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt.
  • svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt.
  • svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt.
  • svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt.
  • svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt.
  • svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt.
  • svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt.
  • svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt.
  • svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt.
  • svg/W3C-SVG-1.1/coords-units-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt.
  • svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt.
  • svg/W3C-SVG-1.1/coords-units-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt.
  • svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt.
  • svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt.
  • svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt.
  • svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt.
  • svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt.
  • svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt.
  • svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt.
  • svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt.
  • svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt.
  • svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt.
  • svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt.
  • svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt.
  • svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt.
  • svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt.
  • svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt.
  • svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt.
  • svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt.
  • svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt.
  • svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt.
  • svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt.
  • svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt.
  • svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt.
  • svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt.
  • svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt.
  • svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt.
  • svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt.
  • svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt.
  • svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt.
  • svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt.
  • svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt.
  • svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt.
  • svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-glyph-04-t-expected.txt.
  • svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt.
  • svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt.
  • svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt.
  • svg/W3C-SVG-1.1/interact-events-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/interact-events-01-b-expected.txt.
  • svg/W3C-SVG-1.1/interact-order-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt.
  • svg/W3C-SVG-1.1/interact-order-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt.
  • svg/W3C-SVG-1.1/interact-order-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/interact-order-03-b-expected.txt.
  • svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt.
  • svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt.
  • svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt.
  • svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt.
  • svg/W3C-SVG-1.1/linking-a-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt.
  • svg/W3C-SVG-1.1/linking-a-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt.
  • svg/W3C-SVG-1.1/linking-a-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt.
  • svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt.
  • svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt.
  • svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt.
  • svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt.
  • svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt.
  • svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt.
  • svg/W3C-SVG-1.1/masking-path-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt.
  • svg/W3C-SVG-1.1/masking-path-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt.
  • svg/W3C-SVG-1.1/masking-path-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt.
  • svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt.
  • svg/W3C-SVG-1.1/masking-path-05-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt.
  • svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt.
  • svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt.
  • svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt.
  • svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt.
  • svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt.
  • svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt.
  • svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt.
  • svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt.
  • svg/W3C-SVG-1.1/painting-render-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt.
  • svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt.
  • svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt.
  • svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt.
  • svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt.
  • svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-10-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-10-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-13-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-13-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-14-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-14-t-expected.txt.
  • svg/W3C-SVG-1.1/paths-data-15-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/paths-data-15-t-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt.
  • svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt.
  • svg/W3C-SVG-1.1/render-elems-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-elems-01-t-expected.txt.
  • svg/W3C-SVG-1.1/render-elems-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-elems-02-t-expected.txt.
  • svg/W3C-SVG-1.1/render-elems-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-elems-03-t-expected.txt.
  • svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt.
  • svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt.
  • svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt.
  • svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt.
  • svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt.
  • svg/W3C-SVG-1.1/script-handle-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt.
  • svg/W3C-SVG-1.1/script-handle-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt.
  • svg/W3C-SVG-1.1/script-handle-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt.
  • svg/W3C-SVG-1.1/script-handle-04-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt.
  • svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt.
  • svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt.
  • svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt.
  • svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt.
  • svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt.
  • svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt.
  • svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt.
  • svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt.
  • svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt.
  • svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
  • svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-group-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-group-01-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-group-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-group-02-b-expected.txt.
  • svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-image-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-01-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-image-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt.
  • svg/W3C-SVG-1.1/struct-image-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-03-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-image-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-04-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-image-05-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-05-b-expected.txt.
  • svg/W3C-SVG-1.1/struct-image-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-06-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-image-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-image-08-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-08-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-image-09-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-09-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-image-10-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-image-10-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt.
  • svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt.
  • svg/W3C-SVG-1.1/struct-use-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt.
  • svg/W3C-SVG-1.1/styling-css-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt.
  • svg/W3C-SVG-1.1/styling-css-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt.
  • svg/W3C-SVG-1.1/styling-css-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt.
  • svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt.
  • svg/W3C-SVG-1.1/styling-css-05-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt.
  • svg/W3C-SVG-1.1/styling-css-06-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt.
  • svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt.
  • svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt.
  • svg/W3C-SVG-1.1/text-align-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-align-01-b-expected.txt.
  • svg/W3C-SVG-1.1/text-align-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-align-02-b-expected.txt.
  • svg/W3C-SVG-1.1/text-align-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-align-03-b-expected.txt.
  • svg/W3C-SVG-1.1/text-align-04-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-align-04-b-expected.txt.
  • svg/W3C-SVG-1.1/text-align-05-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-align-05-b-expected.txt.
  • svg/W3C-SVG-1.1/text-align-06-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-align-06-b-expected.txt.
  • svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-align-08-b-expected.txt.
  • svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt.
  • svg/W3C-SVG-1.1/text-deco-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt.
  • svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt.
  • svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt.
  • svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt.
  • svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt.
  • svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt.
  • svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt.
  • svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt.
  • svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt.
  • svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-path-01-b-expected.txt.
  • svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt.
  • svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-text-01-b-expected.txt.
  • svg/W3C-SVG-1.1/text-text-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-text-03-b-expected.txt.
  • svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-text-04-t-expected.txt.
  • svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-text-05-t-expected.txt.
  • svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-text-06-t-expected.txt.
  • svg/W3C-SVG-1.1/text-text-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-text-07-t-expected.txt.
  • svg/W3C-SVG-1.1/text-text-08-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-text-08-b-expected.txt.
  • svg/W3C-SVG-1.1/text-tref-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-tref-01-b-expected.txt.
  • svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt.
  • svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt.
  • svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt.
  • svg/W3C-SVG-1.1/text-ws-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-ws-01-t-expected.txt.
  • svg/W3C-SVG-1.1/text-ws-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/text-ws-02-t-expected.txt.
  • svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt.
7:53 PM Changeset in webkit [158817] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Gtk][EFL] Fix build after r158759
https://bugs.webkit.org/show_bug.cgi?id=123910

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-06
Reviewed by Gyuyoung Kim.

  • UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.cpp:

(WebKit::CoordinatedDrawingAreaProxy::incorporateUpdate): Remove call to flashBackingStoreUpdates().

7:49 PM Changeset in webkit [158816] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Properly null check positionToReveal in ResourceSidebarPanel.prototype.showSourceCode.

https://bugs.webkit.org/show_bug.cgi?id=123921

Reviewed by Joseph Pecoraro.

  • UserInterface/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype.showSourceCode):

7:49 PM Changeset in webkit [158815] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Applied background color is not retained after typing a characters
https://bugs.webkit.org/show_bug.cgi?id=117337

Patch by Vani Hegde <vani.hegde@samsung.com> on 2013-11-06
Reviewed by Ryosuke Niwa.

Source/WebCore:

While deleting a selection, only the inheritable style properties
applied on the selection were saved.
Since background color is considered as noninheritable style property,
on deleting the selection, background color set on it was being lost.
Hence on typing in new text, it would not have the applied
background color set.
Fixed by saving editing preoperties that are already in effect
on a selection before deleting it.

Test: editing/style/background-color-retained.html

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::saveTypingStyleState):
Modified as to save EditingPropertiesInEffect on a selection before
deleting it.

LayoutTests:

  • editing/style/background-color-retained-expected.txt: Added.
  • editing/style/background-color-retained.html: Added.

Test to make sure that background color applied on a
selection is retained after deleting the selection.

7:49 PM Changeset in webkit [158814] by rniwa@webkit.org
  • 5 edits
    1 add in trunk/Websites/test-results

New flakiness dashboard should generate JSON in the background process
https://bugs.webkit.org/show_bug.cgi?id=123797

Reviewed by Alexey Proskuryakov.

  • config.json: Add defaultBuildWaitInterval used by process-builds.php.
  • init-database.sql: Add is_process column to builds table so that we can track of "unprocessed" builds.
  • public/admin/process-builds.php: Added.

(process_latest_five_builds): Update flakiness states and generate JSONs for the latest five builds.
We go backwards in the time so that we don't end up infinite looping over a single build that fails.
(main): Call processed_builds with an exponential back off.

  • public/api/report.php:

(store_results): No need to return build or builder ids.
(main): Don't update flakiness states or generate JSONs.

  • public/include/test-results.php:

(add_build): Take the slave name; it doesn't make any sense to create a build without it and later
updating it in store_test_results.
(store_test_results): Once new test results are added, explicitly mark this build as unprocessed.

7:39 PM Changeset in webkit [158813] by akling@apple.com
  • 1 edit
    40 moves
    42 deletes in trunk/LayoutTests

Optimize baselines: svg/W3C-I18N

Unreviewed; run "webkit-patch optimize-baselines svg/W3C-I18N"

  • platform/efl/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Removed.
  • platform/gtk/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed.
  • svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt.
  • svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt.
  • svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt.
  • svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt.
  • svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt.
  • svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt.
  • svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt.
  • svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt.
  • svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt.
  • svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt.
  • svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt.
  • svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt.
  • svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt.
  • svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt.
  • svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt.
  • svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt.
  • svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt.
  • svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt.
  • svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt.
  • svg/W3C-I18N/text-anchor-no-markup-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-anchor-no-markup-expected.txt.
  • svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt.
  • svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt.
  • svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt.
  • svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt.
  • svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt.
  • svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt.
  • svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt.
  • svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt.
  • svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt.
  • svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt.
  • svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt.
  • svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt.
  • svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt.
  • svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt.
  • svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt.
  • svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt.
  • svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt.
  • svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt.
  • svg/W3C-I18N/tspan-direction-ltr-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-direction-ltr-expected.txt.
  • svg/W3C-I18N/tspan-direction-rtl-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-I18N/tspan-direction-rtl-expected.txt.
7:32 PM Changeset in webkit [158812] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

InlineBox: Make paint() and nodeAtPoint() pure virtuals.
<https://webkit.org/b/123937>

...and move the current implementations to InlineElementBox.
All subclasses were already overriding these functions so the move
is completely natural.

Reviewed by Anders Carlsson.

7:30 PM Changeset in webkit [158811] by akling@apple.com
  • 8 edits in trunk/Source/WebCore

Nothing should return std::unique_ptr<InlineBox>.
<https://webkit.org/b/123936>

Made RenderBox, RenderLineBreak and RenderListMarker return tightly
typed InlineElementBoxes instead.

Reviewed by Anders Carlsson.

7:26 PM Changeset in webkit [158810] by akling@apple.com
  • 4 edits
    3 copies
    24 moves
    2 adds
    28 deletes in trunk/LayoutTests

Optimize baselines: accessibility

Unreviewed; run "webkit-patch optimize-baselines accessibility"

  • accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt.
  • accessibility/aria-combobox-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-combobox-expected.txt.
  • accessibility/aria-fallback-roles-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-fallback-roles-expected.txt.
  • accessibility/aria-labelledby-overrides-aria-label-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-labelledby-overrides-aria-label-expected.txt.
  • accessibility/aria-menubar-menuitems-expected.txt:
  • accessibility/aria-option-role-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-option-role-expected.txt.
  • accessibility/aria-roles-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-roles-expected.txt.
  • accessibility/aria-tab-role-on-buttons-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-tab-role-on-buttons-expected.txt.
  • accessibility/aria-tables-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-tables-expected.txt.
  • accessibility/aria-toggle-button-with-title-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/aria-toggle-button-with-title-expected.txt.
  • accessibility/canvas-description-and-role-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/canvas-description-and-role-expected.txt.
  • accessibility/canvas-fallback-content-expected.txt:
  • accessibility/deleting-iframe-destroys-axcache-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/deleting-iframe-destroys-axcache-expected.txt.
  • accessibility/div-within-anchors-causes-crash-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/div-within-anchors-causes-crash-expected.txt.
  • accessibility/file-upload-button-stringvalue-expected.txt: Renamed from LayoutTests/platform/efl-wk1/accessibility/file-upload-button-stringvalue-expected.txt.
  • accessibility/img-alt-tag-only-whitespace-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/img-alt-tag-only-whitespace-expected.txt.
  • accessibility/notification-listeners-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/notification-listeners-expected.txt.
  • accessibility/paragraph-with-linebreaks-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/paragraph-with-linebreaks-expected.txt.
  • accessibility/svg-image-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/svg-image-expected.txt.
  • accessibility/svg-remote-element-expected.txt:
  • platform/efl-wk1/accessibility/table-attributes-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/table-attributes-expected.txt.
  • platform/efl-wk1/accessibility/table-detection-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/table-detection-expected.txt.
  • platform/efl-wk1/accessibility/table-one-cell-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/table-one-cell-expected.txt.
  • platform/efl-wk1/accessibility/table-sections-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/table-sections-expected.txt.
  • platform/efl-wk1/accessibility/table-with-rules-expected.txt: Renamed from LayoutTests/platform/efl/accessibility/table-with-rules-expected.txt.
  • platform/efl/accessibility/aria-menubar-menuitems-expected.txt: Removed.
  • platform/efl/accessibility/canvas-fallback-content-expected.txt: Removed.
  • platform/efl/accessibility/svg-remote-element-expected.txt: Removed.
  • platform/gtk-wk1/accessibility/table-attributes-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-attributes-expected.txt.
  • platform/gtk-wk1/accessibility/table-sections-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/table-sections-expected.txt.
  • platform/gtk/accessibility/adjacent-continuations-cause-assertion-failure-expected.txt: Removed.
  • platform/gtk/accessibility/aria-combobox-expected.txt: Removed.
  • platform/gtk/accessibility/aria-fallback-roles-expected.txt: Removed.
  • platform/gtk/accessibility/aria-labelledby-overrides-aria-label-expected.txt: Removed.
  • platform/gtk/accessibility/aria-menubar-menuitems-expected.txt: Removed.
  • platform/gtk/accessibility/aria-option-role-expected.txt: Removed.
  • platform/gtk/accessibility/aria-roles-expected.txt: Removed.
  • platform/gtk/accessibility/aria-tab-role-on-buttons-expected.txt: Removed.
  • platform/gtk/accessibility/aria-tables-expected.txt: Removed.
  • platform/gtk/accessibility/aria-toggle-button-with-title-expected.txt: Removed.
  • platform/gtk/accessibility/canvas-description-and-role-expected.txt: Removed.
  • platform/gtk/accessibility/canvas-fallback-content-expected.txt: Removed.
  • platform/gtk/accessibility/deleting-iframe-destroys-axcache-expected.txt: Removed.
  • platform/gtk/accessibility/div-within-anchors-causes-crash-expected.txt: Removed.
  • platform/gtk/accessibility/file-upload-button-stringvalue-expected.txt: Removed.
  • platform/gtk/accessibility/img-alt-tag-only-whitespace-expected.txt: Removed.
  • platform/gtk/accessibility/notification-listeners-expected.txt: Removed.
  • platform/gtk/accessibility/paragraph-with-linebreaks-expected.txt: Removed.
  • platform/gtk/accessibility/svg-image-expected.txt: Removed.
  • platform/gtk/accessibility/svg-remote-element-expected.txt: Removed.
  • platform/mac/accessibility/aria-fallback-roles-expected.txt: Removed.
  • platform/mac/accessibility/aria-menubar-menuitems-expected.txt: Copied from LayoutTests/accessibility/aria-menubar-menuitems-expected.txt.
  • platform/mac/accessibility/aria-roles-expected.txt: Removed.
  • platform/mac/accessibility/aria-tables-expected.txt: Removed.
  • platform/mac/accessibility/canvas-fallback-content-expected.txt: Copied from LayoutTests/accessibility/canvas-fallback-content-expected.txt.
  • platform/mac/accessibility/img-alt-tag-only-whitespace-expected.txt: Removed.
  • platform/mac/accessibility/svg-image-expected.txt: Removed.
  • platform/win-future/accessibility/svg-remote-element-expected.txt: Copied from LayoutTests/accessibility/svg-remote-element-expected.txt.
6:47 PM Changeset in webkit [158809] by akling@apple.com
  • 6 edits
    6 copies
    7 moves
    11 adds
    18 deletes in trunk/LayoutTests

Optimize baselines: media

Unreviewed; run "webkit-patch optimize-baselines media"

  • media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt:
  • media/media-can-play-webm-expected.txt: Renamed from LayoutTests/platform/efl/media/media-can-play-webm-expected.txt.
  • media/video-controls-visible-audio-only-expected.txt: Renamed from LayoutTests/platform/efl/media/video-controls-visible-audio-only-expected.txt.
  • platform/efl-wk2/media/video-layer-crash-expected.png: Renamed from LayoutTests/platform/efl/media/video-layer-crash-expected.png.
  • platform/efl-wk2/media/video-transformed-expected.png: Renamed from LayoutTests/platform/efl/media/video-transformed-expected.png.
  • platform/efl-wk2/media/video-zoom-expected.png: Renamed from LayoutTests/platform/efl/media/video-zoom-expected.png.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Removed.
  • platform/efl/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Removed.
  • platform/gtk/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Removed.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Removed.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Removed.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Removed.
  • platform/gtk/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Removed.
  • platform/gtk/media/media-can-play-webm-expected.txt: Removed.
  • platform/gtk/media/video-controls-visible-audio-only-expected.txt: Removed.
  • platform/mac/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Copied from LayoutTests/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt.
  • platform/mac/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Copied from LayoutTests/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt.
  • platform/mac/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Copied from LayoutTests/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt.
  • platform/mac/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Copied from LayoutTests/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt.
  • platform/mac/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Copied from LayoutTests/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt.
  • platform/mac/media/video-controls-visible-audio-only-expected.txt: Removed.
  • platform/win-7sp0/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Renamed from LayoutTests/platform/efl/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt.
  • platform/win-7sp0/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Renamed from LayoutTests/platform/efl/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt.
  • platform/win-7sp0/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Renamed from LayoutTests/platform/efl/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt.
  • platform/win/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Removed.
  • platform/win/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Removed.
  • platform/win/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Removed.
  • platform/win/media/media-can-play-ogg-expected.txt: Removed.
  • platform/win/media/video-colorspace-yuv420-expected.txt: Removed.
  • platform/win/media/video-colorspace-yuv422-expected.txt: Removed.
  • platform/win/media/video-size-intrinsic-scale-expected.txt: Removed.
6:02 PM Changeset in webkit [158808] by timothy_horton@apple.com
  • 4 edits in trunk/Source/WebKit2

Remote Layer Tree: RemoteLayerTreeDrawingArea doesn't make layers for fixedpos elements
https://bugs.webkit.org/show_bug.cgi?id=123943

Reviewed by Simon Fraser.

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::updatePreferences):
Make fixed position elements create compositing layers and stacking contexts
in the RemoteLayerTreeDrawingArea just like they do in TiledCoreAnimationDrawingArea.

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::updatePreferences):
Fix the comment, since we have long since achieved this goal.

5:41 PM Changeset in webkit [158807] by dino@apple.com
  • 2 edits in trunk/Source/ThirdParty/ANGLE

kTraceBufferLen is unused in default builds
https://bugs.webkit.org/show_bug.cgi?id=123941
<rdar://problem/15409804>

Reviewed by Tim Horton.

kTraceBufferLen is not used in debug.cpp if TRACE_ENABLED is
not defined. This causes a warning in newer builds of clang.
For now, skip warnings on unused variables until we
update from ANGLE.

  • src/compiler/debug.cpp: Add unused-variable ignore pragma.
5:20 PM Changeset in webkit [158806] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Implement enough functionality so that NSURLRequest objects can be decoded
https://bugs.webkit.org/show_bug.cgi?id=123942

Reviewed by Andreas Kling.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(-[WKRemoteObjectEncoder requiresSecureCoding]):
Add new method. Return YES.

(-[WKRemoteObjectDecoder decodeValueOfObjCType:at:]):
Add new method. This currently only handles 'i', but we'll add more variants as needed.

(-[WKRemoteObjectDecoder decodeBoolForKey:]):
Get a WebBoolean from the dictionary and return its value.

5:12 PM Changeset in webkit [158805] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Encoded object stream should be sequential
https://bugs.webkit.org/show_bug.cgi?id=123939

Reviewed by Andreas Kling.

Reserve space in the object stream for objects that are to be encoded, otherwise
the object stream will not be sequential.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeToObjectStream):

  • Shared/ImmutableArray.h:

(WebKit::ImmutableArray::entries):

4:48 PM Changeset in webkit [158804] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Allow property list classes to exist in containers
https://bugs.webkit.org/show_bug.cgi?id=123938

Reviewed by Andreas Kling.

  • Shared/API/Cocoa/WKRemoteObjectInterface.mm:

(isContainerClass):
Return whether a given class is a container class.

(propertyListClasses):
Return the set of property list classes.

(allowedArgumentClassesForMethod):
Allow all property list classes for container type arguments.

4:39 PM Changeset in webkit [158803] by dbates@webkit.org
  • 20 edits
    5 adds in trunk

[iOS] Upstream Letterpress effect
https://bugs.webkit.org/show_bug.cgi?id=123932

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Add feature define ENABLE_LETTERPRESS disabled by default. We only enable
letterpress on iOS.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Test: platform/iphone-simulator/iphone/getComputedStyle-text-decoration-letterpress.html

  • Configurations/FeatureDefines.xcconfig: Add feature define ENABLE_LETTERPRESS disabled

by default. We only enable letterpress on iOS.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::renderTextDecorationFlagsToCSSValue): Add support for CSS value -webkit-letterpress.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseTextDecoration): Ditto.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator TextDecoration): Ditto.

  • css/CSSValueKeywords.in: Added CSS value -webkit-letterpress.
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/mac/FontMac.mm:

(WebCore::fillVectorWithHorizontalGlyphPositions): Added.
(WebCore::shouldUseLetterpressEffect): Added.
(WebCore::showLetterpressedGlyphsWithAdvances): Added.
(WebCore::showGlyphsWithAdvances): Modified to call showLetterpressedGlyphsWithAdvances()
to show a letterpressed glyph. I also included additional iOS-specific changes.
(WebCore::Font::drawGlyphs):

  • rendering/TextPaintStyle.cpp:

(WebCore::TextPaintStyle::TextPaintStyle):
(WebCore::computeTextPaintStyle): Modified to compute letterpress effect style.
(WebCore::updateGraphicsContext): Modified to apply/unapply letterpress effect drawing mode.

  • rendering/TextPaintStyle.h:
  • rendering/style/RenderStyleConstants.h:

Source/WebKit/mac:

Add feature define ENABLE_LETTERPRESS disabled by default. We only enable
letterpress on iOS.

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Add feature define ENABLE_LETTERPRESS disabled by default. We only enable
letterpress on iOS.

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

Add feature define ENABLE_LETTERPRESS disabled by default. We only enable
letterpress on iOS.

  • wtf/FeatureDefines.h:

LayoutTests:

  • platform/iphone-simulator/iphone/getComputedStyle-text-decoration-letterpress-expected.txt: Added.
  • platform/iphone-simulator/iphone/getComputedStyle-text-decoration-letterpress.html: Added.
  • platform/iphone-simulator/iphone/resources/getComputedStyle-text-decoration-letterpress.js: Added.
4:20 PM Changeset in webkit [158802] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Crash in SliderThumbElement::dragFrom
https://bugs.webkit.org/show_bug.cgi?id=123873

Reviewed by Sam Weinig.

Moved Ref.

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderThumbElement::dragFrom):

4:04 PM Changeset in webkit [158801] by eric.carlson@apple.com
  • 5 edits
    1 add in trunk/LayoutTests

LayoutTests/media/track/track-forced-subtitles-in-band.html always times out
https://bugs.webkit.org/show_bug.cgi?id=123412

Reviewed by Jer Noble.

  • media/content/CC+Subtitles.mov: Added.
  • media/track/track-forced-subtitles-in-band.html: Fail loudly if the caption track menu is

not found by the helper function. Wait for both 'seeked' and 'cuechange' events before
checking activeCues.

  • media/trackmenu-test.js:

(getTrackListElement): Correct the caption menu pseudo-id.
(trackMenuList): Complain when the track menu is not found.

  • platform/mac/TestExpectations: Remove track-forced-subtitles-in-band.html.
4:00 PM Changeset in webkit [158800] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Cleanup FontMac.mm
https://bugs.webkit.org/show_bug.cgi?id=123928

Reviewed by Andy Estes.

  • platform/graphics/mac/FontMac.mm:

(WebCore::showGlyphsWithAdvances): Inline the value of variable isVertical as we
reference it exactly once and its value is sufficiently clear.
(WebCore::Font::drawGlyphs): Remove default case in switch block so that the compiler
checks that all cases are covered. Move definition of platformData to the top of the
function and use it whenever we want to access the platform font data

3:53 PM Changeset in webkit [158799] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Fixed multiple API test failures after r158764.

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(setUpPagePolicyClient): If the delegate isn’t set or doesn’t respond to a selector, respond
with WKFramePolicyListenerUse().

3:08 PM Changeset in webkit [158798] by Brent Fulgham
  • 5 edits in trunk/Source/WebCore

[WebGL] We should not allow generateMipMap on compressed textures
https://bugs.webkit.org/show_bug.cgi?id=123915
<rdar://problem/15201274>

Reviewed by Dean Jackson.

Found by existing conformance/extensions/webgl-compressed-texture-s3tc.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::compressedTexImage2D): Set compressed flag.
(WebCore::WebGLRenderingContext::compressedTexSubImage2D): Ditto.
(WebCore::WebGLRenderingContext::generateMipmap): For Apple builds, check state
of compressed flag and generate appropriate WebGL error if necessary.

  • html/canvas/WebGLTexture.cpp:

(WebCore::WebGLTexture::WebGLTexture): Set compressed flag to false by default
(WebCore::WebGLTexture::isCompressed): Added
(WebCore::WebGLTexture::setCompressed): Added

  • html/canvas/WebGLTexture.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::generateMipmap): Switch implementation to use proper
glGenerateMipmaps, rather than the glGenerateMipmapsEXT method.

3:04 PM Changeset in webkit [158797] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Move allowed classes handling to decodeObject
https://bugs.webkit.org/show_bug.cgi?id=123930

Reviewed by Andreas Kling.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(decodeObjectFromObjectStream):
Pass allowed classes through to decodeObject.

(decodeObject):
Update to take an NSSet of allowed classes. If the set is nil, use the current set.

(-[WKRemoteObjectDecoder decodeObjectOfClasses:forKey:]):
Pass classes to decodeObject.

2:44 PM Changeset in webkit [158796] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Web Inspector: Changes to CodeGeneratorInspectorStrings.py should rebuild inspector generated files
https://bugs.webkit.org/show_bug.cgi?id=123925

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-06
Reviewed by Timothy Hatcher.

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.am:
2:40 PM Changeset in webkit [158795] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI

Merged rr157966. <rdar://problem/15406689>

2:37 PM Changeset in webkit [158794] by Lucas Forschler
  • 3 edits in branches/safari-537.73-branch/Source/WebInspectorUI

Merged r156675. <rdar://problem/15406691>

2:37 PM Changeset in webkit [158793] by oliver@apple.com
  • 14 edits
    9 adds in trunk

Support iteration of the Arguments object
https://bugs.webkit.org/show_bug.cgi?id=123835

Reviewed by Mark Lam.

Source/JavaScriptCore:

Add an ArgumentsIterator object, and associated classes so that we can support
iteration of the arguments object.

This is a largely mechanical patch. The only gnarliness is in the
logic to avoid reifying the Arguments object in for(... of arguments)
scenarios.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitEnumeration):

  • runtime/Arguments.cpp:

(JSC::Arguments::getOwnPropertySlot):
(JSC::argumentsFuncIterator):

  • runtime/Arguments.h:
  • runtime/ArgumentsIteratorConstructor.cpp: Added.

(JSC::ArgumentsIteratorConstructor::finishCreation):

  • runtime/ArgumentsIteratorConstructor.h: Added.

(JSC::ArgumentsIteratorConstructor::create):
(JSC::ArgumentsIteratorConstructor::createStructure):
(JSC::ArgumentsIteratorConstructor::ArgumentsIteratorConstructor):

  • runtime/ArgumentsIteratorPrototype.cpp: Added.

(JSC::ArgumentsIteratorPrototype::finishCreation):
(JSC::argumentsIteratorPrototypeFuncIterator):
(JSC::argumentsIteratorPrototypeFuncNext):

  • runtime/ArgumentsIteratorPrototype.h: Added.

(JSC::ArgumentsIteratorPrototype::create):
(JSC::ArgumentsIteratorPrototype::createStructure):
(JSC::ArgumentsIteratorPrototype::ArgumentsIteratorPrototype):

  • runtime/CommonIdentifiers.h:
  • runtime/JSArgumentsIterator.cpp: Added.

(JSC::JSArgumentsIterator::finishCreation):

  • runtime/JSArgumentsIterator.h: Added.

(JSC::JSArgumentsIterator::createStructure):
(JSC::JSArgumentsIterator::create):
(JSC::JSArgumentsIterator::next):
(JSC::JSArgumentsIterator::JSArgumentsIterator):

  • runtime/JSArrayIterator.cpp:

(JSC::createIteratorResult):

  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:

LayoutTests:

Add test cases

  • js/arguments-iterator-expected.txt: Added.
  • js/arguments-iterator.html: Added.
  • js/script-tests/arguments-iterator.js: Added.

(shouldThrow.test):
(testAlias):
(testStrict):
(testReifiedArguments):
(testOverwrittenArguments):
(testNullArguments):
(testNonArrayLikeArguments):

2:37 PM Changeset in webkit [158792] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix EFL build after r158753
https://bugs.webkit.org/show_bug.cgi?id=123923

r158753 renamed WKNavigationData.h as WKNavigationDataRef.h, so
update it in UIProcess/API/efl/ewk_navigation_data_private.h.

Patch by Sergio Correia <Sergio Correia> on 2013-11-06
Reviewed by Csaba Osztrogonác.

  • UIProcess/API/efl/ewk_navigation_data_private.h:
2:31 PM Changeset in webkit [158791] by Lucas Forschler
  • 4 edits in branches/safari-537.73-branch/Source/WebInspectorUI

Merged r154550. <rdar://problem/15406685>

2:29 PM Changeset in webkit [158790] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Fix the display of query parameters when the value is missing.

https://bugs.webkit.org/show_bug.cgi?id=123920

Reviewed by Joseph Pecoraro.

  • UserInterface/ResourceDetailsSidebarPanel.js:

(WebInspector.ResourceDetailsSidebarPanel.prototype._createNameValueDataGrid):

2:27 PM Changeset in webkit [158789] by Lucas Forschler
  • 1 edit in branches/safari-537.73-branch/Source/WebInspectorUI/UserInterface/External/CodeMirror/codemirror.js

Merge patch for <rdar://problem/15406685>.

2:08 PM Changeset in webkit [158788] by Alexandru Chiculita
  • 8 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: CSS Regions: When a flow is clicked the content of flow needs to be displayed
https://bugs.webkit.org/show_bug.cgi?id=122927

Reviewed by Joseph Pecoraro.

ContentFlowTreeContentView is now used to display the content nodes of a ContentFlow. It is
very similar to the DOMTreeContentView class, but can handle multiple root nodes.

  • UserInterface/ContentFlowTreeContentView.js: Added.

(WebInspector.ContentFlowTreeContentView):
(WebInspector.ContentFlowTreeContentView.prototype.get selectionPathComponents):
(WebInspector.ContentFlowTreeContentView.prototype.updateLayout):
(WebInspector.ContentFlowTreeContentView.prototype.shown):
(WebInspector.ContentFlowTreeContentView.prototype.hidden):
(WebInspector.ContentFlowTreeContentView.prototype.closed):
(WebInspector.ContentFlowTreeContentView.prototype._selectedNodeDidChange):
(WebInspector.ContentFlowTreeContentView.prototype._pathComponentSelected):
(WebInspector.ContentFlowTreeContentView.prototype._createContentNodeTree):
(WebInspector.ContentFlowTreeContentView.prototype._createContentTrees):
(WebInspector.ContentFlowTreeContentView.prototype._contentNodeWasAdded):
(WebInspector.ContentFlowTreeContentView.prototype._contentNodeWasRemoved):

  • UserInterface/ContentView.js:

(WebInspector.ContentView):
(WebInspector.ContentView.isViewable):

  • UserInterface/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype.ondeselect): We need to remove the selected "dom node"
so that the element is not going to stay selected after the we move to a different DOM tree.

  • UserInterface/DOMTreeOutline.js:

(WebInspector.DOMTreeOutline.prototype.selectDOMNode):

  • UserInterface/Main.html:
  • UserInterface/Main.js:

(WebInspector.sidebarPanelForRepresentedObject):

  • UserInterface/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):

2:04 PM Changeset in webkit [158787] by Lucas Forschler
  • 17 edits
    4 copies in branches/safari-537.73-branch

Merged r158617. <rdar://problem/15391030>

1:57 PM Changeset in webkit [158786] by oliver@apple.com
  • 2 edits in trunk/LayoutTests

Fix test case

1:54 PM Changeset in webkit [158785] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Remove the flaky test expectation after r158720 now that the test is not flaky.

  • platform/mac/TestExpectations:
1:52 PM Changeset in webkit [158784] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Implement more decoding methods
https://bugs.webkit.org/show_bug.cgi?id=123922

Reviewed by Dan Bernstein.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(-[WKRemoteObjectDecoder decodeObjectForKey:]):
Call decodeObjectOfClasses:forKey: passing nil as the classes set.

(-[WKRemoteObjectDecoder decodeInt64ForKey:]):
Try to get a WebUInt64 and return its value.

(-[WKRemoteObjectDecoder decodeDoubleForKey:]):
Try to get a WebDouble and return its value.

(-[WKRemoteObjectDecoder decodeBytesForKey:returnedLength:]):
Move this method next to the other decoding methods.

(-[WKRemoteObjectDecoder requiresSecureCoding]):
Ditto.

1:39 PM Changeset in webkit [158783] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Disable "unused local typedefs" warning for GCC 4.7
https://bugs.webkit.org/show_bug.cgi?id=123913

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-06
Reviewed by Martin Robinson.

That warning was actually introduced in gcc 4.7.0.
See: http://gcc.gnu.org/gcc-4.7/changes.html

  • wtf/Compiler.h:
1:31 PM Changeset in webkit [158782] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit2

[Gtk][EFL] Fix build after r158759
https://bugs.webkit.org/show_bug.cgi?id=123910

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-06
Reviewed by Gustavo Noronha Silva.

  • UIProcess/API/gtk/PageClientImpl.cpp: Remove flashBackingStoreUpdates().
  • UIProcess/API/gtk/PageClientImpl.h: Same.
  • UIProcess/CoordinatedGraphics/WebView.cpp: Same.
  • UIProcess/CoordinatedGraphics/WebView.h: Same.
  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::incorporateUpdate): Don't call flashBackingStoreUpdates().

1:21 PM Changeset in webkit [158781] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed Mac build fix; include ResourceResponse.

  • Shared/WebNavigationDataStore.h:
1:17 PM Changeset in webkit [158780] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Decode invocation arguments
https://bugs.webkit.org/show_bug.cgi?id=123917

Reviewed by Sam Weinig.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(-[WKRemoteObjectDecoder initWithInterface:rootObjectDictionary:WebKit::]):
Initialize the object stream.

(decodeObjectFromObjectStream):
Check that we're not reading past the end of the stream, then decode the object.

(decodeInvocationArguments):
Decode arguments from the object stream.

(decodeInvocation):
Call decodeInvocationArguments and set up the selector argument.

  • Shared/ImmutableArray.h:

(WebKit::ImmutableArray::at):
(WebKit::ImmutableArray::size):
(WebKit::ImmutableArray::entries):
Constify.

12:56 PM Changeset in webkit [158779] by mitz@apple.com
  • 6 edits in trunk/Source/WebKit2

[Cocoa] Add -[WKNavigationData response]
https://bugs.webkit.org/show_bug.cgi?id=123918

Reviewed by Sam Weinig.

  • Shared/WebNavigationDataStore.h: Added a ResourceResponse data member.

(WebKit::WebNavigationDataStore::encode): Encode the response.
(WebKit::WebNavigationDataStore::decode): Decode the response.

  • UIProcess/Cocoa/WKNavigationData.h: Declared new property.
  • UIProcess/Cocoa/WKNavigationData.mm:

(-[WKNavigationData response]): Added.

  • UIProcess/WebNavigationData.h:

(WebKit::WebNavigationData::response): Added.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::updateGlobalHistory): Set the response in the data store.

12:49 PM Changeset in webkit [158778] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r158629. <rdar://problem/15391028>

12:49 PM Changeset in webkit [158777] by Bem Jones-Bey
  • 4 edits in trunk/Source/WebCore

Rename region line offset methods
https://bugs.webkit.org/show_bug.cgi?id=123897

Reviewed by Sam Weinig.

Because of the large number of overloads on the line offset methods,
it is very hard to read code using them, which also makes it harder to
move them out of RenderBlock. This patch renames the methods that take
a region as an argument to make it clearer when looking at the code
how the differ from the ones that don't.

No new tests, no behavior change.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::availableLogicalWidthForLineInRegion):
(WebCore::RenderBlock::logicalRightOffsetForLineInRegion):
(WebCore::RenderBlock::logicalLeftOffsetForLineInRegion):
(WebCore::RenderBlock::startOffsetForLineInRegion):
(WebCore::RenderBlock::endOffsetForLineInRegion):
(WebCore::RenderBlock::availableLogicalWidthForLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):

12:49 PM Changeset in webkit [158776] by weinig@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix the 32-bit build.

  • UIProcess/API/mac/WKBrowsingContextController.h:
  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController dealloc]):
(-[WKBrowsingContextController _initWithPageRef:]):

12:48 PM Changeset in webkit [158775] by mitz@apple.com
  • 5 edits in trunk/Source/WebKit2

[Cocoa] Add -[WKBrowsingContextController unreachableURL]
https://bugs.webkit.org/show_bug.cgi?id=123909

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKBrowsingContextController.h: Declared unreachableURL property.
  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController unreachableURL]): Added.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::unreachableURL): Added.

  • UIProcess/WebPageProxy.h:
12:38 PM Changeset in webkit [158774] by Antti Koivisto
  • 8 edits in trunk/Source/WebCore

HTMLCollection should use CollectionIndexCache
https://bugs.webkit.org/show_bug.cgi?id=123906

Reviewed by Ryosuke Niwa.

More code sharing.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):

  • dom/ChildNodeList.h:
  • dom/CollectionIndexCache.h:

(WebCore::::nodeBeforeCached):
(WebCore::::nodeAfterCached):
(WebCore::::nodeAt):

Add a mechanism for disabling use of backward traversal.

  • dom/LiveNodeList.h:

(WebCore::LiveNodeList::collectionCanTraverseBackward):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::isMatchingElement):
(WebCore::HTMLCollection::iterateForPreviousElement):
(WebCore::firstMatchingElement):
(WebCore::nextMatchingElement):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::nameShouldBeVisibleInDocumentAll):
(WebCore::firstMatchingChildElement):
(WebCore::nextMatchingSiblingElement):
(WebCore::HTMLCollection::firstElement):
(WebCore::HTMLCollection::traverseForward):
(WebCore::HTMLCollection::collectionFirst):
(WebCore::HTMLCollection::collectionLast):
(WebCore::HTMLCollection::collectionTraverseForward):
(WebCore::HTMLCollection::collectionTraverseBackward):
(WebCore::HTMLCollection::invalidateCache):
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):

  • html/HTMLCollection.h:

(WebCore::HTMLCollection::collectionCanTraverseBackward):

Disable use of backward traversal for collections that use custom traversal.

12:32 PM Changeset in webkit [158773] by fpizlo@apple.com
  • 4 edits
    3 adds in trunk

DFG CheckArray(NonArray) should prove that the child isn't an array
https://bugs.webkit.org/show_bug.cgi?id=123911
<rdar://problem/15202803>

Reviewed by Mark Hahnenberg.

Source/JavaScriptCore:

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::jumpSlowForUnwantedArrayMode):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::isArrayType):

LayoutTests:

  • js/dfg-check-array-non-array-expected.txt: Added.
  • js/dfg-check-array-non-array.html: Added.
  • js/script-tests/dfg-check-array-non-array.js: Added.

(foo):
(bar):
(baz):

12:31 PM Changeset in webkit [158772] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Encode parameters as objects
https://bugs.webkit.org/show_bug.cgi?id=123912

Reviewed by Beth Dakin.

We want to ensure that the objects have the right types when decoded, so just encode them as objects.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeInvocation):
(-[WKRemoteObjectEncoder encodeValueOfObjCType:at:]):

12:27 PM Changeset in webkit [158771] by Lucas Forschler
  • 6 edits in branches/safari-537.73-branch/Source/WebKit2

Merged r154763. <rdar://problem/15401612>

12:23 PM Changeset in webkit [158770] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/LayoutTests

Merged r158766. <rdar://problem/15390971>

12:22 PM Changeset in webkit [158769] by Lucas Forschler
  • 5 edits in branches/safari-537.73-branch/Source/WebCore

Merged r155997. <rdar://problem/15390971>

12:20 PM Changeset in webkit [158768] by Lucas Forschler
  • 3 edits in branches/safari-537.73-branch/WebKitLibraries

Merged r155996. <rdar://problem/15390971>

12:16 PM Changeset in webkit [158767] by jer.noble@apple.com
  • 2 edits in trunk/Tools

Unreviewed webkitpy unit test fix; update baselines after r158765

  • Scripts/webkitpy/port/win_unittest.py:

(WinPortTest.test_baseline_search_path):

12:10 PM Changeset in webkit [158766] by Lucas Forschler
  • 2 edits in branches/safari-537.60-branch/LayoutTests

Merged r154392. <rdar://problem/15390971>

11:53 AM Changeset in webkit [158765] by jer.noble@apple.com
  • 2 edits in trunk/Tools

[Win] run-webkit-tests on the win platform should fall back to mac-mountainlion, not mac-lion.
https://bugs.webkit.org/show_bug.cgi?id=123905

Reviewed by Brent Fulgham.

Now that the mac-lion results have been removed, the win port should fall back to
the mac-mountainlion results.

  • Scripts/webkitpy/port/win.py:

(WinPort.default_baseline_search_path):

11:42 AM Changeset in webkit [158764] by weinig@apple.com
  • 5 edits
    1 add in trunk/Source/WebKit2

Add WKBrowsingContextPolicyDelegate
https://bugs.webkit.org/show_bug.cgi?id=123904

Reviewed by Anders Carlsson.

  • UIProcess/API/mac/WKBrowsingContextController.h:
  • UIProcess/API/mac/WKBrowsingContextController.mm:

Implement a WKPagePolicyClient in terms of the new WKBrowsingContextPolicyDelegate protocol.

  • UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h:

Added.

  • UIProcess/API/mac/WebKit2.h:

Add new #include of WKBrowsingContextPolicyDelegate.h

  • WebKit2.xcodeproj/project.pbxproj:

Add new file.

11:23 AM Changeset in webkit [158763] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

WKRemoteObjectInterface should keep track of allowed decodable classes
https://bugs.webkit.org/show_bug.cgi?id=123903

Reviewed by Sam Weinig.

  • Shared/API/Cocoa/WKRemoteObjectInterface.mm:

(allowedArgumentClassesForMethod):
Helper function that returns a vector of sets of allowed classes for each method argument.

(initializeAllowedArgumentClasses):
Iterate over the methods in the protocol, get the extended method type encoding and create an
NSMethodSignature from it. Finally, pass the signature to allowedArgumentClassesForMethod.

(initializeAllowedArgumentClasses):
Call the other initializeAllowedArgumentClasses twice, once for required methods,
and once for optional methods.

(-[WKRemoteObjectInterface initWithProtocol:identifier:]):
Call initializeAllowedArgumentClasses.

(-[WKRemoteObjectInterface _allowedArgumentClassesForSelector:]):
Add new getter.

  • Shared/API/Cocoa/WKRemoteObjectInterfaceInternal.h:
11:21 AM Changeset in webkit [158762] by mhahnenberg@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

JSExport doesn't support constructors
https://bugs.webkit.org/show_bug.cgi?id=123380

Reviewed by Geoffrey Garen.

Needed another linked-on-or-after check for when we're deciding whether
we should copy over init family methods.

Factored out the link time checks into a separate function so that they can be cached.

Factored out the check for init-family method selectors into helper function and changed it to
match the description in the clang docs, namely that there can be underscores at the beginning
and the first letter after 'init' part of the selector (if there is one) must be a capital letter.

Updated tests to make sure we don't treat "initialize" as an init-family method and that we do
treat "_init" as an init-family method.

  • API/JSWrapperMap.h:
  • API/JSWrapperMap.mm:

(isInitFamilyMethod):
(shouldSkipMethodWithName):
(copyMethodsToObject):
(allocateConstructorForCustomClass):
(supportsInitMethodConstructors):

  • API/tests/testapi.mm:

(-[ClassA initialize]):
(-[ClassD initialize]):

11:01 AM Changeset in webkit [158761] by andersca@apple.com
  • 2 edits in trunk/Tools

Fix a Mountain Lion test failure.

NSURLRequest doesn't conform to NSSecureCoding on Mountain Lion, so don't try to test encoding it.

  • TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:

(TestWebKitAPI::TEST):

10:54 AM WebInspector edited by timothy@apple.com
(diff)
10:53 AM Changeset in webkit [158760] by commit-queue@webkit.org
  • 17 edits
    2 adds in trunk

Add "id" attribute to TextTrack
https://bugs.webkit.org/show_bug.cgi?id=123825

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-06
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/track-id.html

  • html/HTMLMediaElement.cpp:

(HTMLMediaElement::addTextTrack): Add emptyString() for track id.

  • html/track/AudioTrack.cpp:

(WebCore::AudioTrack::AudioTrack): Pass trackPrivate->id() to TrackBase.
(WebCore::AudioTrack::idChanged): Added, set id.

  • html/track/AudioTrack.h: Move m_id to TrackBase.
  • html/track/InbandTextTrack.cpp:

(WebCore::InbandTextTrack::InbandTextTrack): Pass trackPrivate->id() to TrackBase.
(WebCore::InbandTextTrack::idChanged): Added, set id.

  • html/track/InbandTextTrack.h: Add idChanged().
  • html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::LoadableTextTrack): Add emptyString() for track id.
(WebCore::LoadableTextTrack::id): Override to return the track element's id.

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::captionMenuOffItem): Add empty string for track id.
(WebCore::TextTrack::captionMenuAutomaticItem): Add empty string for track id.
(WebCore::TextTrack::TextTrack): Pass id to TrackBase.

  • html/track/TextTrack.h:

(WebCore::TextTrack::create): Add id parameter.

  • html/track/TextTrack.idl: Add id attribute.
  • html/track/TrackBase.cpp:

(WebCore::TrackBase::TrackBase): Add m_id.

  • html/track/TrackBase.h: Add id attribute / m_id.
  • html/track/VideoTrack.cpp:

(WebCore::VideoTrack::VideoTrack): Pass trackPrivate->id() to TrackBase.
(WebCore::VideoTrack::idChanged): Added, set id.

  • html/track/VideoTrack.h: Move m_id to TrackBase.
  • platform/graphics/TrackPrivateBase.h: Add idChanged() callback.

LayoutTests:

  • media/track/track-id-expected.txt: Added.
  • media/track/track-id.html: Added.
10:51 AM Changeset in webkit [158759] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

Remove dead code
https://bugs.webkit.org/show_bug.cgi?id=123902

Reviewed by Tim Horton.

Remove the PageClient::containingWindowGraphicsContext() as well as the
WKPageSetDebugPaintFlags and WKPageGetDebugPaintFlags API functions.

  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.mm:
  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::searchTheWeb):

10:18 AM Changeset in webkit [158758] by Antti Koivisto
  • 10 edits in trunk/Source/WebCore

Move array position caching out from HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=123895

Reviewed by Darin Adler.

This caching complicates the logic but is used by a single subclass
(HTMLFormControlsCollection) only. The subclass can do the caching itself.

  • html/HTMLAllCollection.cpp:

(WebCore::HTMLAllCollection::HTMLAllCollection):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::create):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::elementBeforeOrAfterCachedElement):
(WebCore::HTMLCollection::firstElement):

Renamed from traverseFirstElement.

(WebCore::HTMLCollection::traverseForwardToOffset):
(WebCore::HTMLCollection::invalidateCache):

Make cache invalidation virtual so we can clear HTMLTableRowsCollection index cache.

(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNameCache):

Use traverseForwardToOffset instead traverseNextElement. This allows removal of traverseNextElement.

  • html/HTMLCollection.h:

(WebCore::HTMLCollection::usesCustomForwardOnlyTraversal):

Renamed the enum and the accessor to be more informative.

(WebCore::HTMLCollection::setCachedElement):
(WebCore::HTMLCollection::customElementAfter):

Renamed from virtualItemAfter.

  • html/HTMLFormControlsCollection.cpp:

(WebCore::HTMLFormControlsCollection::HTMLFormControlsCollection):
(WebCore::findFormAssociatedElement):
(WebCore::HTMLFormControlsCollection::customElementAfter):

Move the array position caching logic here.

(WebCore::HTMLFormControlsCollection::invalidateCache):

  • html/HTMLFormControlsCollection.h:
  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::HTMLNameCollection):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::HTMLOptionsCollection):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::HTMLTableRowsCollection):
(WebCore::HTMLTableRowsCollection::customElementAfter):

  • html/HTMLTableRowsCollection.h:
10:17 AM Changeset in webkit [158757] by Michał Pakuła vel Rutka
  • 6 edits in trunk

[ATK] accessibility/title-ui-element-correctness.html fails
https://bugs.webkit.org/show_bug.cgi?id=99825

Reviewed by Mario Sanchez Prada.

Source/WebCore:

When calling setAtkRelationSetFromCoreObject a new ATK_LABELLED_BY_RELATION
is added, adding proper label element as a relation. When the document structure
has been changed and a different label should be linked as a relation, current ATK
implementation adds it as a next target on relation's target list, while
WTR/DumpRenderTree implementation takes only first one into account.
This patch adds a new function removing current relations before adding new ones.

Covered by existing tests.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(removeAtkRelationFromRelationSetByType):
(setAtkRelationSetFromCoreObject):

LayoutTests:

Remove failure test expectation for the test fixed by this patch.

  • platform/efl-wk1/TestExpectations:
  • platform/efl-wk2/TestExpectations:
  • platform/gtk/TestExpectations:
10:12 AM Changeset in webkit [158756] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Promoted WKBrowsingContextHistoryDelegate.h to private.

Rubber-stamped by Sam Weinig.

  • WebKit2.xcodeproj/project.pbxproj:
10:00 AM WebInspectorCodingStyleGuide edited by Joseph Pecoraro
(diff)
9:57 AM WebInspectorCodingStyleGuide edited by Alexandru Chiculita
(diff)
9:56 AM WebInspectorCodingStyleGuide created by Alexandru Chiculita
9:43 AM Changeset in webkit [158755] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Media elements wrongly exposed after r158743.

  • platform/gtk/TestExpectations: Added failure expectations.
9:39 AM Changeset in webkit [158754] by commit-queue@webkit.org
  • 4 edits
    8 adds in trunk/LayoutTests

[ATK] Providing new table related accessibility expectations after r158742
https://bugs.webkit.org/show_bug.cgi?id=123893

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-06
Reviewed by Chris Fleizach.

New baselines after added missing implementation in r158742.

  • platform/efl-wk1/TestExpectations: Tests are no longer failing.
  • platform/efl-wk2/TestExpectations: Tests are no longer failing.
  • platform/efl-wk2/accessibility/table-attributes-expected.txt: Added.
  • platform/efl-wk2/accessibility/table-sections-expected.txt: Added.
  • platform/efl/accessibility/table-attributes-expected.txt: Added.
  • platform/efl/accessibility/table-sections-expected.txt: Added.
  • platform/gtk-wk2/accessibility/table-attributes-expected.txt: Added.
  • platform/gtk-wk2/accessibility/table-sections-expected.txt: Added.
  • platform/gtk/TestExpectations: Tests are no longer failing.
  • platform/gtk/accessibility/table-attributes-expected.txt: Added.
  • platform/gtk/accessibility/table-sections-expected.txt: Added.
9:36 AM Changeset in webkit [158753] by mitz@apple.com
  • 10 edits
    2 moves
    4 adds in trunk/Source/WebKit2

[Cocoa] History delegate
https://bugs.webkit.org/show_bug.cgi?id=123837

Reviewed by Sam Weinig.

  • Shared/Cocoa/APIObject.mm:

(WebKit::APIObject::newObject): Allocate a WKNavigationData if the object is a
WebNavigationData.

  • Shared/Cocoa/WKNSString.h:

(WebKit::wrapper): Added. Returns a WebString’s wrapper as an NSString.

  • Shared/Cocoa/WKNSURL.h:

(WebKit::wrapper): Added. Returns a WebURL’s wrapper as an NSURL.

  • UIProcess/API/C/WKNavigationData.cpp: Renamed.
  • UIProcess/API/C/WKNavigationData.h: Renamed.
  • UIProcess/API/C/WKNavigationDataRef.cpp: Copied from Source/WebKit2/UIProcess/API/C/WKNavigationData.cpp.
  • UIProcess/API/C/WKNavigationDataRef.h: Copied from Source/WebKit2/UIProcess/API/C/WKNavigationData.h.
  • UIProcess/API/mac/WKBrowsingContextController.h: Declared historyDelegate property.
  • UIProcess/API/mac/WKProcessGroup.mm:

(didNavigateWithNavigationData): Added history client callback that calls the browsing
context’s history delegate.
(didPerformClientRedirect): Ditto.
(didPerformServerRedirect): Ditto.
(didUpdateHistoryTitle): Ditto.
(setUpHistoryClient): Added.
(-[WKProcessGroup initWithInjectedBundleURL:]): Added call to setUpHistoryClient.
(-[WKProcessGroup dealloc]): Clear the history client.

  • UIProcess/Cocoa/WKBrowsingContextHistoryDelegate.h: Added.
  • UIProcess/Cocoa/WKNavigationData.h: Added.
  • UIProcess/Cocoa/WKNavigationData.mm: Added.

(-[WKNavigationData dealloc]): Calls the WebNavigationData destructor.
(-[WKNavigationData title]): Added.
(-[WKNavigationData originalRequest]): Added.
(-[WKNavigationData destinationURL]): Added.
(-[WKNavigationData _apiObject]): Returns the wrapped WebNavigationData.

  • UIProcess/Cocoa/WKNavigationDataInternal.h: Added.

(WebKit::wrapper): Added. Returns a WebNavigationData’s wrapper as a WKNavigationData.

  • WebKit2.xcodeproj/project.pbxproj: Updated for renames and additions.
9:31 AM WebKitGTK/2.2.x edited by zandobersek@gmail.com
Add two proposed merges for the next 2.2 release. (diff)
9:31 AM Changeset in webkit [158752] by jer.noble@apple.com
  • 3 edits in trunk/LayoutTests

Unreviewed gardening; Fix expected results for video-seek-with-negative-playback.html,
and modify the test to conform to media test style.

  • media/video-seek-with-negative-playback-expected.txt:
  • media/video-seek-with-negative-playback.html:
9:29 AM Changeset in webkit [158751] by msaboff@apple.com
  • 18 edits
    3 deletes in trunk/Source/JavaScriptCore

Change ctiTrampoline into a thunk
https://bugs.webkit.org/show_bug.cgi?id=123844

Reviewed by Filip Pizlo.

Converted ctiTrampoline and ctiOpThrowNotCaught into thunks named callToJavaScript
and returnFromJavaScript. Cleaned up and in some cases removed JITStubsXXX.h files
after removing ctiTrampoline and ctiOpThrowNotCaught. Added callJavaScriptJITFunction
to VM that is a function pointer to the callToJavaScript thunk.

  • GNUmakefile.list.am:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

  • jit/JITCode.cpp:

(JSC::JITCode::execute):

  • jit/JITExceptions.cpp:

(JSC::genericUnwind):

  • jit/JITStubs.cpp:
  • jit/JITStubs.h:
  • jit/JITStubsARM.h:
  • jit/JITStubsARM64.h: Removed.
  • jit/JITStubsARMv7.h:
  • jit/JITStubsMIPS.h: Removed.
  • jit/JITStubsMSVC64.asm:
  • jit/JITStubsSH4.h: Removed.
  • jit/JITStubsX86.h:
  • jit/JITStubsX86_64.h:
  • jit/JSInterfaceJIT.h:
  • jit/ThunkGenerators.cpp:

(JSC::returnFromJavaScript):
(JSC::callToJavaScript):

  • jit/ThunkGenerators.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
8:48 AM Changeset in webkit [158750] by dbates@webkit.org
  • 7 edits in trunk/Source

Add ENABLE(TEXT_SELECTION)
https://bugs.webkit.org/show_bug.cgi?id=123827

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add compile-time guard, ENABLE(TEXT_SELECTION), to enable or
disable selection painting in WebCore (enabled by default).

On iOS we disable WebCore selection painting and have UIKit
paint the selection.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintSelection): Only paint selection when
TEXT_SELECTION is enabled.

  • rendering/LogicalSelectionOffsetCaches.h:

(WebCore::LogicalSelectionOffsetCaches::LogicalSelectionOffsetCaches):
For now, add a ENABLE(TEXT_SELECTION)-guard around an assertion. Added
a FIXME comment to investigate the callers and either move the assertion
to the appropriate callers or structure the code such that we can remove
the assertion.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintSelection): Only paint selection when
TEXT_SELECTION is enabled.

  • rendering/TextPaintStyle.cpp:

(WebCore::computeTextSelectionPaintStyle): Only compute the selection
paint style when TEXT_SELECTION is enabled. Otherwise, return a paint
style identical to the text paint style. Also, substitute nullptr for 0.

Source/WTF:

Enable selection painting by default on all ports except iOS.

  • wtf/FeatureDefines.h:
8:45 AM Changeset in webkit [158749] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unrevewied Windows build fix after r158736; add InlineElementBox.cpp to the RenderingAllInOne.cpp file.

  • rendering/RenderingAllInOne.cpp:
8:38 AM Changeset in webkit [158748] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

FTL should support StringCharCodeAt
https://bugs.webkit.org/show_bug.cgi?id=123854

Reviewed by Sam Weinig.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileStringCharCodeAt):

8:36 AM Changeset in webkit [158747] by svillar@igalia.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix, style() return type is now a reference.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::resolveGridPositionFromStyle):

8:26 AM Changeset in webkit [158746] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed 32-bit Mac build fix; use an explicit FloatSize -> IntSize conversion function.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged):

8:15 AM Changeset in webkit [158745] by jer.noble@apple.com
  • 6 edits in trunk/Source/WebCore

Playing many sounds with HTML5 Audio makes WebKit unresponsive
https://bugs.webkit.org/show_bug.cgi?id=116145

Reviewed by Eric Carlson.

Cache as much information as possible from AVPlayerItem to eliminate unneccesary
calls into AVFoundation.

Add WillChange/DidChange functions to handle the results of KVO notifications
from AVPlayerItem and AVPlayer:

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformPlay):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformPause):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateRate):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatusDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackLikelyToKeepUpWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackLikelyToKeepUpDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackBufferEmptyWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackBufferEmptyDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackBufferFullWillChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playbackBufferFullDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::loadedTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasEnabledAudioDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::presentationSizeDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::durationDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::rateDidChange):
(WebCore::itemKVOProperties):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):

Instruct the HTMLMediaElement to cache the currentTime value for 5 seconds:

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

(WebCore::MediaPlayerPrivateAVFoundationObjC::maximumDurationToCacheMediaTime):

Add and initialize member variables to hold these cached values:

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cancelLoad):

Add a new Notification type which can take (and call) a Function object:

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(WebCore::MediaPlayerPrivateAVFoundation::Notification::Notification):
(WebCore::MediaPlayerPrivateAVFoundation::Notification::function):

Implement queries in terms of the cached values of AVPlayerItem and AVPlayer
properties:

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
(WebCore::MediaPlayerPrivateAVFoundationObjC::playerItemStatus):
(WebCore::MediaPlayerPrivateAVFoundationObjC::rate):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformBufferedTimeRanges):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMinTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMaxTimeSeekable):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMaxTimeLoaded):
(WebCore::MediaPlayerPrivateAVFoundationObjC::totalBytes):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateAudioTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::updateVideoTracks):
(WebCore::MediaPlayerPrivateAVFoundationObjC::sizeChanged):
(WebCore::MediaPlayerPrivateAVFoundationObjC::processLegacyClosedCaptionsTracks):

Invalidate the cached currentTime before calling scheduleTimeUpdate so that the
correct movieTime is saved in m_clockTimeAtLastUpdateEvent:

  • html/HTMLMediaElement.cpp:

(HTMLMediaElement::setReadyState):

7:54 AM Changeset in webkit [158744] by svillar@igalia.com
  • 18 edits
    4 adds in trunk

[CSS Grid Layout] Add support for named grid areas
https://bugs.webkit.org/show_bug.cgi?id=120045

Reviewed by Andreas Kling.

From Blink r155555, r155850 and r155889 by <jchaffraix@chromium.org>

Source/WebCore:

Added support for named grid areas. Basically a named grid area is
now a valid grid position. The shorthand parsing of grid-area was
split from the grid-{row|column} as the rules for expanding are
slightly different.

Unknown grid area names are treated as 'auto' as per the
specification. This means that for those cases we need to trigger
the auto-placement algorithm.

Tests: fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html

fast/css-grid-layout/grid-item-named-grid-area-resolution.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::valueForGridPosition):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseGridPosition):
(WebCore::gridMissingGridPositionValue):
(WebCore::CSSParser::parseGridItemPositionShorthand):
(WebCore::CSSParser::parseGridAreaShorthand):
(WebCore::CSSParser::parseSingleGridAreaLonghand):

  • css/CSSParser.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::adjustGridItemPosition):
(WebCore::createGridPosition):

  • css/StyleResolver.h:
  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::resolveGridPositionFromStyle):

  • rendering/style/GridPosition.h:

(WebCore::GridPosition::isNamedGridArea):
(WebCore::GridPosition::setNamedGridArea):
(WebCore::GridPosition::namedGridLine):

LayoutTests:

Added a couple of new tests to check that both known and unknown
named grid areas are properly handled.

Also extended some of the existing tests to use named grid areas
as any other possible grid position.

  • fast/css-grid-layout/grid-item-area-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-area-get-set.html:
  • fast/css-grid-layout/grid-item-bad-named-area-auto-placement-expected.txt: Added.
  • fast/css-grid-layout/grid-item-bad-named-area-auto-placement.html: Added.
  • fast/css-grid-layout/grid-item-column-row-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-column-row-get-set.html:
  • fast/css-grid-layout/grid-item-end-after-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-end-after-get-set.html:
  • fast/css-grid-layout/grid-item-named-grid-area-resolution-expected.txt: Added.
  • fast/css-grid-layout/grid-item-named-grid-area-resolution.html: Added.
  • fast/css-grid-layout/grid-item-start-before-get-set-expected.txt:
  • fast/css-grid-layout/grid-item-start-before-get-set.html:
  • fast/css-grid-layout/resources/grid-item-column-row-parsing-utils.js:
6:15 AM Changeset in webkit [158743] by Chris Fleizach
  • 442 edits
    4 adds in trunk

AX: Audio and Video attachments are not output to VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=123479

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Video and audio elements don't appear as distinct objects in the AX hierarchy,
nor are they treated as replaceable objects when emitting the text. We should
treat these characters like attachments, for one. On the Mac platform, we should
also identify them with special subroles.

Tests: platform/mac/accessibility/media-emits-object-replacement.html

platform/mac/accessibility/media-role-descriptions.html

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isGenericFocusableElement):

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
(-[WebAccessibilityObjectWrapper roleDescription]):

  • editing/TextIterator.cpp:

(WebCore::isRendererReplacedElement):

LayoutTests:

Making media elements int replaced elements has the unfortunate side-effect
of causing a new line to be inserted into any test using a <video> or <audio> tag.

  • compositing/video/video-poster-expected.txt:
  • compositing/video/video-reflection-expected.txt:
  • compositing/visibility/visibility-simple-video-layer-expected.txt:
  • fast/css/first-letter-block-form-controls-crash-expected.txt:
  • fast/css/relative-position-replaced-in-table-display-crash-expected.txt:
  • fast/forms/access-key-for-all-elements-expected.txt:
  • fast/forms/form-associated-element-crash3-expected.txt:
  • fast/multicol/renderer-positioned-assert-crash-expected.txt:
  • fast/regions/full-screen-video-from-region-expected.txt:
  • fast/runin/nonblock-runin-expected.txt:
  • fast/spatial-navigation/snav-media-elements-expected.txt:
  • fullscreen/full-screen-crash-offsetLeft-expected.txt:
  • fullscreen/full-screen-no-style-sharing-expected.txt:
  • fullscreen/full-screen-stacking-context-expected.txt:
  • fullscreen/video-controls-drag-expected.txt:
  • fullscreen/video-controls-timeline-expected.txt:
  • fullscreen/video-cursor-auto-hide-expected.txt:
  • fullscreen/video-specified-size-expected.txt:
  • http/tests/appcache/video-expected.txt:
  • http/tests/media/pdf-served-as-pdf-expected.txt:
  • http/tests/media/reload-after-dialog-expected.txt:
  • http/tests/media/text-served-as-text-expected.txt:
  • http/tests/media/video-accept-encoding-expected.txt:
  • http/tests/media/video-buffered-range-contains-currentTime-expected.txt:
  • http/tests/media/video-cross-site-expected.txt:
  • http/tests/media/video-error-abort-expected.txt:
  • http/tests/media/video-load-suspend-expected.txt:
  • http/tests/media/video-play-progress-expected.txt:
  • http/tests/media/video-play-stall-before-meta-data-expected.txt:
  • http/tests/media/video-preload-expected.txt:
  • http/tests/media/video-redirect-expected.txt:
  • http/tests/media/video-referer-expected.txt:
  • http/tests/media/video-served-as-text-expected.txt:
  • http/tests/media/video-throttled-load-metadata-expected.txt:
  • http/tests/misc/empty-urls-expected.txt:
  • http/tests/security/contentSecurityPolicy/media-src-allowed-expected.txt:
  • http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
  • http/tests/security/local-video-poster-from-remote-expected.txt:
  • http/tests/security/local-video-source-from-remote-expected.txt:
  • http/tests/security/local-video-src-from-remote-expected.txt:
  • http/tests/security/text-track-crossorigin-expected.txt:
  • media/W3C/audio/events/event_canplay-expected.txt:
  • media/W3C/audio/events/event_canplay_manual-expected.txt:
  • media/W3C/audio/events/event_canplaythrough-expected.txt:
  • media/W3C/audio/events/event_canplaythrough_manual-expected.txt:
  • media/W3C/audio/events/event_loadeddata-expected.txt:
  • media/W3C/audio/events/event_loadeddata_manual-expected.txt:
  • media/W3C/audio/events/event_loadedmetadata-expected.txt:
  • media/W3C/audio/events/event_loadedmetadata_manual-expected.txt:
  • media/W3C/audio/events/event_loadstart-expected.txt:
  • media/W3C/audio/events/event_loadstart_manual-expected.txt:
  • media/W3C/audio/events/event_order_canplay_canplaythrough-expected.txt:
  • media/W3C/audio/events/event_order_canplay_playing-expected.txt:
  • media/W3C/audio/events/event_order_loadedmetadata_loadeddata-expected.txt:
  • media/W3C/audio/events/event_order_loadstart_progress-expected.txt:
  • media/W3C/audio/events/event_pause_manual-expected.txt:
  • media/W3C/audio/events/event_play-expected.txt:
  • media/W3C/audio/events/event_play_manual-expected.txt:
  • media/W3C/audio/events/event_playing-expected.txt:
  • media/W3C/audio/events/event_playing_manual-expected.txt:
  • media/W3C/audio/events/event_progress-expected.txt:
  • media/W3C/audio/events/event_progress_manual-expected.txt:
  • media/W3C/audio/events/event_timeupdate-expected.txt:
  • media/W3C/audio/events/event_timeupdate_manual-expected.txt:
  • media/W3C/audio/networkState/networkState_during_loadstart-expected.txt:
  • media/W3C/audio/paused/paused_false_during_play-expected.txt:
  • media/W3C/audio/paused/paused_true_during_pause-expected.txt:
  • media/W3C/audio/readyState/readyState_during_canplay-expected.txt:
  • media/W3C/audio/readyState/readyState_during_canplaythrough-expected.txt:
  • media/W3C/audio/readyState/readyState_during_loadeddata-expected.txt:
  • media/W3C/audio/readyState/readyState_during_loadedmetadata-expected.txt:
  • media/W3C/audio/readyState/readyState_during_playing-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_1-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_2-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_application_octet_stream_with_codecs_3-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_bogus_type-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_codecs_order_1-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_method_exists-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_1-expected.txt:
  • media/W3C/video/canPlayType/canPlayType_two_implies_one_2-expected.txt:
  • media/W3C/video/currentSrc/currentSrc_empty_if_no_src-expected.txt:
  • media/W3C/video/currentSrc/currentSrc_property_exists-expected.txt:
  • media/W3C/video/error/error_null-expected.txt:
  • media/W3C/video/error/error_onerror_called_on_bogus_source-expected.txt:
  • media/W3C/video/error/error_property_exists-expected.txt:
  • media/W3C/video/events/event_canplay-expected.txt:
  • media/W3C/video/events/event_canplay_manual-expected.txt:
  • media/W3C/video/events/event_canplaythrough-expected.txt:
  • media/W3C/video/events/event_canplaythrough_manual-expected.txt:
  • media/W3C/video/events/event_loadeddata-expected.txt:
  • media/W3C/video/events/event_loadeddata_manual-expected.txt:
  • media/W3C/video/events/event_loadedmetadata-expected.txt:
  • media/W3C/video/events/event_loadedmetadata_manual-expected.txt:
  • media/W3C/video/events/event_loadstart-expected.txt:
  • media/W3C/video/events/event_loadstart_manual-expected.txt:
  • media/W3C/video/events/event_order_canplay_canplaythrough-expected.txt:
  • media/W3C/video/events/event_order_canplay_playing-expected.txt:
  • media/W3C/video/events/event_order_loadedmetadata_loadeddata-expected.txt:
  • media/W3C/video/events/event_order_loadstart_progress-expected.txt:
  • media/W3C/video/events/event_pause_manual-expected.txt:
  • media/W3C/video/events/event_play-expected.txt:
  • media/W3C/video/events/event_play_manual-expected.txt:
  • media/W3C/video/events/event_playing-expected.txt:
  • media/W3C/video/events/event_playing_manual-expected.txt:
  • media/W3C/video/events/event_progress-expected.txt:
  • media/W3C/video/events/event_progress_manual-expected.txt:
  • media/W3C/video/events/event_timeupdate-expected.txt:
  • media/W3C/video/events/event_timeupdate_manual-expected.txt:
  • media/W3C/video/networkState/networkState_during_loadstart-expected.txt:
  • media/W3C/video/networkState/networkState_during_progress-expected.txt:
  • media/W3C/video/networkState/networkState_initial-expected.txt:
  • media/W3C/video/networkState/networkState_property_exists-expected.txt:
  • media/W3C/video/paused/paused_false_during_play-expected.txt:
  • media/W3C/video/paused/paused_true_during_pause-expected.txt:
  • media/W3C/video/preload/preload_property_exists-expected.txt:
  • media/W3C/video/preload/preload_reflects_auto_value-expected.txt:
  • media/W3C/video/preload/preload_reflects_bogus_value-expected.txt:
  • media/W3C/video/preload/preload_reflects_empty-expected.txt:
  • media/W3C/video/preload/preload_reflects_metadata-expected.txt:
  • media/W3C/video/preload/preload_reflects_no_value-expected.txt:
  • media/W3C/video/preload/preload_reflects_none-expected.txt:
  • media/W3C/video/preload/preload_reflects_none_autoplay-expected.txt:
  • media/W3C/video/readyState/readyState_during_canplay-expected.txt:
  • media/W3C/video/readyState/readyState_during_canplaythrough-expected.txt:
  • media/W3C/video/readyState/readyState_during_loadeddata-expected.txt:
  • media/W3C/video/readyState/readyState_during_loadedmetadata-expected.txt:
  • media/W3C/video/readyState/readyState_during_playing-expected.txt:
  • media/W3C/video/readyState/readyState_initial-expected.txt:
  • media/W3C/video/readyState/readyState_property_exists-expected.txt:
  • media/W3C/video/src/src_reflects_attribute_not_source_elements-expected.txt:
  • media/W3C/video/src/src_reflects_no_value-expected.txt:
  • media/W3C/video/src/src_removal_does_not_trigger_loadstart-expected.txt:
  • media/audio-mpeg-supported-expected.txt:
  • media/audio-mpeg4-supported-expected.txt:
  • media/audio-only-video-intrinsic-size-expected.txt:
  • media/auto-play-in-sandbox-with-allow-scripts-expected.txt:
  • media/before-load-member-access-expected.txt:
  • media/broken-video-expected.txt:
  • media/constructors-expected.txt:
  • media/controls-css-overload-expected.txt:
  • media/controls-drag-timebar-expected.txt:
  • media/controls-layout-direction-expected.txt:
  • media/controls-right-click-on-timebar-expected.txt:
  • media/csp-blocks-video-expected.txt:
  • media/event-attributes-expected.txt:
  • media/media-blocked-by-beforeload-expected.txt:
  • media/media-blocked-by-willsendrequest-expected.txt:
  • media/media-can-play-mpeg-audio-expected.txt:
  • media/media-can-play-mpeg4-video-expected.txt:
  • media/media-can-play-octet-stream-expected.txt:
  • media/media-can-play-type-expected.txt:
  • media/media-can-play-wav-audio-expected.txt:
  • media/media-captions-expected.txt:
  • media/media-captions-no-controls-expected.txt:
  • media/media-controller-expected.txt:
  • media/media-controller-playback-expected.txt:
  • media/media-controller-playbackrate-expected.txt:
  • media/media-controller-time-clamp-expected.txt:
  • media/media-controller-time-constant-expected.txt:
  • media/media-controller-time-expected.txt:
  • media/media-controller-timeupdate-expected.txt:
  • media/media-controller-unpause-expected.txt:
  • media/media-controls-invalid-url-expected.txt:
  • media/media-ended-expected.txt:
  • media/media-extension-with-fragment-expected.txt:
  • media/media-fragments/TC0001-expected.txt:
  • media/media-fragments/TC0002-expected.txt:
  • media/media-fragments/TC0003-expected.txt:
  • media/media-fragments/TC0004-expected.txt:
  • media/media-fragments/TC0005-expected.txt:
  • media/media-fragments/TC0006-expected.txt:
  • media/media-fragments/TC0009-expected.txt:
  • media/media-fragments/TC0011-expected.txt:
  • media/media-fragments/TC0012-expected.txt:
  • media/media-fragments/TC0014-expected.txt:
  • media/media-fragments/TC0015-expected.txt:
  • media/media-fragments/TC0017-expected.txt:
  • media/media-fragments/TC0024-expected.txt:
  • media/media-fragments/TC0027-expected.txt:
  • media/media-fragments/TC0028-expected.txt:
  • media/media-fragments/TC0029-expected.txt:
  • media/media-fragments/TC0030-expected.txt:
  • media/media-fragments/TC0031-expected.txt:
  • media/media-fragments/TC0032-expected.txt:
  • media/media-fragments/TC0033-expected.txt:
  • media/media-fragments/TC0034-expected.txt:
  • media/media-fragments/TC0035-expected.txt:
  • media/media-fragments/TC0036-expected.txt:
  • media/media-fragments/TC0037-expected.txt:
  • media/media-fragments/TC0038-expected.txt:
  • media/media-fragments/TC0039-expected.txt:
  • media/media-fragments/TC0044-expected.txt:
  • media/media-fragments/TC0051-expected.txt:
  • media/media-fragments/TC0052-expected.txt:
  • media/media-fragments/TC0053-expected.txt:
  • media/media-fragments/TC0054-expected.txt:
  • media/media-fragments/TC0055-expected.txt:
  • media/media-fragments/TC0058-expected.txt:
  • media/media-fragments/TC0059-expected.txt:
  • media/media-fragments/TC0061-expected.txt:
  • media/media-fragments/TC0062-expected.txt:
  • media/media-fragments/TC0063-expected.txt:
  • media/media-fragments/TC0064-expected.txt:
  • media/media-fragments/TC0065-expected.txt:
  • media/media-fragments/TC0066-expected.txt:
  • media/media-fragments/TC0067-expected.txt:
  • media/media-fragments/TC0068-expected.txt:
  • media/media-fragments/TC0069-expected.txt:
  • media/media-fragments/TC0070-expected.txt:
  • media/media-fragments/TC0071-expected.txt:
  • media/media-fragments/TC0072-expected.txt:
  • media/media-fragments/TC0073-expected.txt:
  • media/media-fragments/TC0074-expected.txt:
  • media/media-fragments/TC0075-expected.txt:
  • media/media-fragments/TC0076-expected.txt:
  • media/media-fragments/TC0077-expected.txt:
  • media/media-fragments/TC0078-expected.txt:
  • media/media-fragments/TC0079-expected.txt:
  • media/media-fragments/TC0080-expected.txt:
  • media/media-fragments/TC0081-expected.txt:
  • media/media-fragments/TC0082-expected.txt:
  • media/media-fragments/TC0083-expected.txt:
  • media/media-fragments/TC0084-expected.txt:
  • media/media-fragments/TC0085-expected.txt:
  • media/media-fragments/TC0086-expected.txt:
  • media/media-fragments/TC0087-expected.txt:
  • media/media-fragments/TC0088-expected.txt:
  • media/media-fragments/TC0089-expected.txt:
  • media/media-fragments/TC0090-expected.txt:
  • media/media-fragments/TC0091-expected.txt:
  • media/media-fragments/TC0092-expected.txt:
  • media/media-fragments/TC0093-expected.txt:
  • media/media-fragments/TC0094-expected.txt:
  • media/media-fullscreen-inline-expected.txt:
  • media/media-preload-no-delay-loadevent-expected.txt:
  • media/no-autoplay-with-user-gesture-requirement-expected.txt:
  • media/nodesFromRect-shadowContent-expected.txt:
  • media/restore-from-page-cache-expected.txt:
  • media/sources-fallback-codecs-expected.txt:
  • media/track/add-and-remove-track-expected.txt:
  • media/track/audio-track-expected.txt:
  • media/track/opera/interfaces/TextTrack/addCue-expected.txt:
  • media/track/opera/interfaces/TextTrack/removeCue-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/align-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/endTime-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/id-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/pauseOnExit-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/startTime-expected.txt:
  • media/track/opera/interfaces/TextTrackCue/track-expected.txt:
  • media/track/opera/interfaces/TextTrackCueList/getCueById-expected.txt:
  • media/track/opera/interfaces/TextTrackCueList/length-expected.txt:
  • media/track/text-track-cue-is-reachable-expected.txt:
  • media/track/text-track-is-reachable-expected.txt:
  • media/track/track-active-cues-expected.txt:
  • media/track/track-add-remove-cue-expected.txt:
  • media/track/track-add-track-expected.txt:
  • media/track/track-addtrack-kind-expected.txt:
  • media/track/track-automatic-subtitles-expected.txt:
  • media/track/track-css-all-cues-expected.txt:
  • media/track/track-css-cue-lifetime-expected.txt:
  • media/track/track-css-matching-default-expected.txt:
  • media/track/track-css-matching-expected.txt:
  • media/track/track-css-matching-lang-expected.txt:
  • media/track/track-css-matching-timestamps-expected.txt:
  • media/track/track-css-property-whitelist-expected.txt:
  • media/track/track-css-user-override-expected.txt:
  • media/track/track-cue-container-rendering-position-expected.txt:
  • media/track/track-cue-empty-text-crash-expected.txt:
  • media/track/track-cue-inline-assertion-crash-expected.txt:
  • media/track/track-cue-mutable-expected.txt:
  • media/track/track-cue-mutable-fragment-expected.txt:
  • media/track/track-cue-negative-timestamp-expected.txt:
  • media/track/track-cue-nothing-to-render-expected.txt:
  • media/track/track-cue-overlap-snap-to-lines-not-set-expected.txt:
  • media/track/track-cue-rendering-empty-cue-crash-expected.txt:
  • media/track/track-cue-rendering-expected.txt:
  • media/track/track-cue-rendering-on-resize-expected.txt:
  • media/track/track-cue-rendering-rtl-expected.txt:
  • media/track/track-cue-rendering-snap-to-lines-not-set-expected.txt:
  • media/track/track-cue-rendering-tree-is-removed-properly-expected.txt:
  • media/track/track-cue-rendering-with-padding-expected.txt:
  • media/track/track-cues-cuechange-expected.txt:
  • media/track/track-cues-enter-exit-expected.txt:
  • media/track/track-cues-missed-expected.txt:
  • media/track/track-cues-pause-on-exit-expected.txt:
  • media/track/track-cues-seeking-expected.txt:
  • media/track/track-cues-sorted-before-dispatch-expected.txt:
  • media/track/track-default-attribute-expected.txt:
  • media/track/track-disabled-addcue-expected.txt:
  • media/track/track-disabled-expected.txt:
  • media/track/track-element-load-event-expected.txt:
  • media/track/track-in-band-cues-added-once-expected.txt:
  • media/track/track-in-band-duplicate-tracks-when-source-changes-expected.txt:
  • media/track/track-in-band-expected.txt:
  • media/track/track-in-band-legacy-api-expected.txt:
  • media/track/track-in-band-style-expected.txt:
  • media/track/track-kind-expected.txt:
  • media/track/track-large-timestamp-expected.txt:
  • media/track/track-legacyapi-with-automatic-mode-expected.txt:
  • media/track/track-load-from-element-readyState-expected.txt:
  • media/track/track-load-from-src-readyState-expected.txt:
  • media/track/track-long-captions-file-expected.txt:
  • media/track/track-mode-disabled-crash-expected.txt:
  • media/track/track-mode-expected.txt:
  • media/track/track-mode-not-changed-by-new-track-expected.txt:
  • media/track/track-mode-triggers-loading-expected.txt:
  • media/track/track-remove-active-cue-crash-expected.txt:
  • media/track/track-remove-by-setting-innerHTML-expected.txt:
  • media/track/track-remove-quickly-expected.txt:
  • media/track/track-text-track-cue-list-expected.txt:
  • media/track/track-texttracks-expected.txt:
  • media/track/track-webvtt-tc000-empty-expected.txt:
  • media/track/track-webvtt-tc001-utf8-expected.txt:
  • media/track/track-webvtt-tc002-bom-expected.txt:
  • media/track/track-webvtt-tc003-newlines-expected.txt:
  • media/track/track-webvtt-tc004-magic-header-expected.txt:
  • media/track/track-webvtt-tc005-header-comment-expected.txt:
  • media/track/track-webvtt-tc006-cue-identifiers-expected.txt:
  • media/track/track-webvtt-tc007-cue-no-id-expected.txt:
  • media/track/track-webvtt-tc008-timings-no-hours-expected.txt:
  • media/track/track-webvtt-tc009-timings-hour-expected.txt:
  • media/track/track-webvtt-tc010-no-timings-expected.txt:
  • media/track/track-webvtt-tc011-blank-lines-expected.txt:
  • media/track/track-webvtt-tc013-settings-expected.txt:
  • media/track/track-webvtt-tc014-alignment-expected.txt:
  • media/track/track-webvtt-tc015-positioning-expected.txt:
  • media/track/track-webvtt-tc016-align-positioning-expected.txt:
  • media/track/track-webvtt-tc017-line-position-expected.txt:
  • media/track/track-webvtt-tc018-align-text-line-position-expected.txt:
  • media/track/track-webvtt-tc019-cue-size-expected.txt:
  • media/track/track-webvtt-tc020-cue-size-align-expected.txt:
  • media/track/track-webvtt-tc021-valign-expected.txt:
  • media/track/track-webvtt-tc022-entities-expected.txt:
  • media/track/track-webvtt-tc023-markup-expected.txt:
  • media/track/track-webvtt-tc024-timestamp-expected.txt:
  • media/track/track-webvtt-tc025-class-markup-expected.txt:
  • media/track/track-webvtt-tc026-voice-expected.txt:
  • media/track/track-webvtt-tc027-empty-cue-expected.txt:
  • media/track/track-webvtt-tc028-unsupported-markup-expected.txt:
  • media/track/track-word-breaking-expected.txt:
  • media/track/tracklist-is-reachable-expected.txt:
  • media/track/video-track-expected.txt:
  • media/unsupported-rtsp-expected.txt:
  • media/unsupported-tracks-expected.txt:
  • media/video-append-source-expected.txt:
  • media/video-autoplay-expected.txt:
  • media/video-beforeload-remove-source-expected.txt:
  • media/video-buffered-expected.txt:
  • media/video-canvas-drawing-expected.txt:
  • media/video-canvas-drawing-output-expected.txt:
  • media/video-controls-captions-trackmenu-hide-on-click-outside-expected.txt:
  • media/video-controls-captions-trackmenu-includes-enabled-track-expected.txt:
  • media/video-controls-expected.txt:
  • media/video-controls-transformed-expected.txt:
  • media/video-controls-with-mutation-event-handler-expected.txt:
  • media/video-controls-zoomed-expected.txt:
  • media/video-currentTime-delay-expected.txt:
  • media/video-currentTime-expected.txt:
  • media/video-currentTime-set-expected.txt:
  • media/video-currentTime-set2-expected.txt:
  • media/video-delay-load-event-expected.txt:
  • media/video-display-aspect-ratio-expected.txt:
  • media/video-dom-autoplay-expected.txt:
  • media/video-dom-preload-expected.txt:
  • media/video-dom-src-expected.txt:
  • media/video-duration-known-after-eos-expected.txt:
  • media/video-error-does-not-exist-expected.txt:
  • media/video-load-networkState-expected.txt:
  • media/video-load-preload-metadata-expected.txt:
  • media/video-load-preload-none-expected.txt:
  • media/video-load-readyState-expected.txt:
  • media/video-load-require-user-gesture-expected.txt:
  • media/video-loop-expected.txt:
  • media/video-mouse-focus-expected.txt:
  • media/video-muted-expected.txt:
  • media/video-no-autoplay-expected.txt:
  • media/video-pause-empty-events-expected.txt:
  • media/video-pause-immediately-expected.txt:
  • media/video-play-empty-events-expected.txt:
  • media/video-play-pause-events-expected.txt:
  • media/video-play-pause-exception-expected.txt:
  • media/video-play-require-user-gesture-expected.txt:
  • media/video-playbackrate-expected.txt:
  • media/video-played-collapse-expected.txt:
  • media/video-played-ranges-1-expected.txt:
  • media/video-played-reset-expected.txt:
  • media/video-plays-past-end-of-test-expected.txt:
  • media/video-poster-blocked-by-willsendrequest-expected.txt:
  • media/video-poster-delayed-expected.txt:
  • media/video-poster-expected.txt:
  • media/video-poster-scale-expected.txt:
  • media/video-preload-expected.txt:
  • media/video-replaces-poster-expected.txt:
  • media/video-reverse-play-duration-expected.txt:
  • media/video-seek-after-end-expected.txt:
  • media/video-seek-by-small-increment-expected.txt:
  • media/video-seek-multiple-expected.txt:
  • media/video-seek-no-src-exception-expected.txt:
  • media/video-seek-past-end-playing-expected.txt:
  • media/video-seekable-expected.txt:
  • media/video-seeking-expected.txt:
  • media/video-set-rate-from-pause-expected.txt:
  • media/video-single-valid-source-expected.txt:
  • media/video-size-expected.txt:
  • media/video-source-error-expected.txt:
  • media/video-source-error-no-candidate-expected.txt:
  • media/video-source-expected.txt:
  • media/video-source-inserted-expected.txt:
  • media/video-source-load-expected.txt:
  • media/video-source-none-supported-expected.txt:
  • media/video-source-type-expected.txt:
  • media/video-src-blob-expected.txt:
  • media/video-src-change-expected.txt:
  • media/video-src-empty-expected.txt:
  • media/video-src-expected.txt:
  • media/video-src-invalid-poster-expected.txt:
  • media/video-src-invalid-remove-expected.txt:
  • media/video-src-none-expected.txt:
  • media/video-src-plus-source-expected.txt:
  • media/video-src-remove-expected.txt:
  • media/video-src-set-expected.txt:
  • media/video-src-source-expected.txt:
  • media/video-timeupdate-during-playback-expected.txt:
  • media/video-timeupdate-reverse-play-expected.txt:
  • media/video-volume-expected.txt:
  • media/video-width-height-expected.txt:
  • platform/mac/accessibility/media-element-expected.txt:
  • platform/mac/accessibility/media-emits-object-replacement-expected.txt: Added.
  • platform/mac/accessibility/media-emits-object-replacement.html: Added.
  • platform/mac/accessibility/media-role-descriptions-expected.txt: Added.
  • platform/mac/accessibility/media-role-descriptions.html: Added.
  • platform/mac/compositing/video/video-object-fit-expected.txt:
  • platform/mac/fullscreen/video-controls-override-expected.txt:
  • platform/mac/media/media-can-play-wav-audio-expected.txt:
  • platform/mac/media/media-can-play-webm-expected.txt:
  • platform/mac/media/video-seek-past-end-paused-expected.txt:
5:55 AM WebKitGtkLayoutTests edited by Andres Gomez
(diff)
5:55 AM Changeset in webkit [158742] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[ATK] Implement tables-related attributesOf*() functions for AccessibilityUIElement
https://bugs.webkit.org/show_bug.cgi?id=118969

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-06
Reviewed by Mario Sanchez Prada.

Added missing implementation of attributesOfColumnHeaders, attributesOfRowHeaders, attributesOfVisibleCells.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::attributesOfChildren):
(AccessibilityUIElement::attributesOfColumnHeaders):
(AccessibilityUIElement::attributesOfRowHeaders):
(AccessibilityUIElement::attributesOfVisibleCells):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::attributesOfChildren):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):

5:54 AM WebKitGtkLayoutTests edited by Andres Gomez
(diff)
5:52 AM WebKitGtkLayoutTests edited by Andres Gomez
(diff)
3:31 AM Changeset in webkit [158741] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[ATK] accessibility/tabindex-elements-are-accessible.html is failing
https://bugs.webkit.org/show_bug.cgi?id=123884

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-06
Reviewed by Mario Sanchez Prada.

Added new accessibility expectation file. ATK represents paragraph's role as a ATK_ROLE_PARAGRAPH.

  • platform/efl/TestExpectations: Test is no longer failing.
  • platform/efl/accessibility/tabindex-elements-are-accessible-expected.txt: Added.
  • platform/gtk/accessibility/tabindex-elements-are-accessible-expected.txt: Added.
3:17 AM Changeset in webkit [158740] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Tests failing after r158195

  • platform/gtk/TestExpectations: Added failure expectations.
3:11 AM Changeset in webkit [158739] by rniwa@webkit.org
  • 3 edits
    6 adds in trunk

Notify nodes removal to Range/Selection after dispatching blur and mutation event
https://bugs.webkit.org/show_bug.cgi?id=123880

Reviewed by Andreas Kling.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/b60576a0560d14f8757e58d55d37b7cefa48a6ac

In willRemoveChildren in ContainerNode.cpp, call Document::nodeChildrenWillBeRemoved after instead of
before dispatching mutation events because we need to update ranges created by those mutation event
listeners. willRemoveChild was fixed in r115686.

Tests: editing/selection/selection-change-in-blur-event-by-remove-children.html

editing/selection/selection-change-in-mutation-event-by-remove-children.html
fast/dom/Range/range-created-during-remove-children.html

  • dom/ContainerNode.cpp:

(WebCore::willRemoveChildren):

LayoutTests:

  • editing/selection/selection-change-in-blur-event-by-remove-children-expected.txt: Added.
  • editing/selection/selection-change-in-blur-event-by-remove-children.html: Added.
  • editing/selection/selection-change-in-mutation-event-by-remove-children-expected.txt: Added.
  • editing/selection/selection-change-in-mutation-event-by-remove-children.html: Added.
  • fast/dom/Range/range-created-during-remove-children-expected.txt: Added.
  • fast/dom/Range/range-created-during-remove-children.html: Added.
2:55 AM Changeset in webkit [158738] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Fix out-of-date offset in selection range code in range.surroundContents
https://bugs.webkit.org/show_bug.cgi?id=123871

Source/WebCore:

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/c89b413ff0fc4aafa0c71d180b0b1e131bb37707

The code in Range::insertNode assumeed that the start offset of the selection range within its container
doesn't change across a call to insertBefore on the container but this is wrong. This patch recomputes
the start offset when it is used after the insertBefore call.

Test: editing/selection/range-surroundContents-with-preceding-node.html

  • dom/Range.cpp:

(WebCore::Range::insertNode):

LayoutTests:

Reviewed by Andreas Kling.

  • editing/selection/range-surroundContents-with-preceding-node-expected.txt: Added.
  • editing/selection/range-surroundContents-with-preceding-node.html: Added.
2:33 AM Changeset in webkit [158737] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] accessibility/svg-group-element-with-title.html is failing
https://bugs.webkit.org/show_bug.cgi?id=114251

Unreviewed GTK gardening.

Removed failure expectation as the test is passing since r158664.

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-11-06

  • platform/gtk/TestExpectations: The test is no longer failing.
2:26 AM Changeset in webkit [158736] by akling@apple.com
  • 13 edits
    2 adds in trunk/Source/WebCore

Add InlineElementBox and stop instantiating InlineBox directly.
<https://webkit.org/b/123882>

Make the InlineBox constructors protected and add a new class
called InlineElementBox on top. This is somewhat analogous to the
split between RenderText and RenderElement, and allows us to make
renderer() return a far tighter RenderBoxModelObject& instead
of a RenderObject&.

Moved over attachLine(), deleteLine() and extractLine() to start
things off. More things will follow.

Reviewed by Antti Koivisto.

2:21 AM Changeset in webkit [158735] by commit-queue@webkit.org
  • 2 edits in trunk

[EFL] Change required version of ATK to 2.10.0
https://bugs.webkit.org/show_bug.cgi?id=123883

Patch by Krzysztof Czech <k.czech@samsung.com> on 2013-11-06
Reviewed by Mario Sanchez Prada.

Changing a required version of ATK to 2.10.0

  • Source/cmake/OptionsEfl.cmake:
1:32 AM Changeset in webkit [158734] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Source/WebCore: Seek for video doesn't work when playback rate is negative
https://bugs.webkit.org/show_bug.cgi?id=123791

In MediaPlayerPrivateGStreamer::seek negative playback rate was not taken to account.

Patch by Piotr Grad <p.grad@samsung.com> on 2013-11-06
Reviewed by Philippe Normand.

Test: media/video-seek-with-negative-playback.html

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::seek):

LayoutTests: Test for seek not working properly with negative playback rate.
https://bugs.webkit.org/show_bug.cgi?id=123791

Seek method should work properly with negative playback rate.

Patch by Piotr Grad <p.grad@samsung.com> on 2013-11-06
Reviewed by Philippe Normand.

  • media/video-seek-with-negative-playback.html: Added.
  • media/video-seek-with-negative-playback-expected.txt: Added.
12:19 AM Changeset in webkit [158733] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Reinstate an annoying assertion that I accidentally commented out.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::synchronousIconForPageURL):

12:14 AM Changeset in webkit [158732] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[GStreamer] Override label() and language() in Audio and VideoTrackPrivateGStreamer
https://bugs.webkit.org/show_bug.cgi?id=123836

The tests are currently flakey because we only get the label and language if we get
tags after the track client is set.

Patch by Brendan Long <b.long@cablelabs.com> on 2013-11-06
Reviewed by Philippe Normand.

No new tests because the tests already exist (this fixes flakeyness).

  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h: Override label() and language() to use m_label and m_language.
  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h: Same.
  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h: Make m_label and m_language protected so they can be used in the functions above.
12:13 AM Changeset in webkit [158731] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add a test for queries whose leftmost selector matches the root node
https://bugs.webkit.org/show_bug.cgi?id=123877

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/22981c70bf93e8a07ee7b4d68a4522aee21b26ce
so that we won't introduce the regression they had.

  • fast/selectors/querySelector-leftmost-selector-matches-rootNode-expected.txt: Added.
  • fast/selectors/querySelector-leftmost-selector-matches-rootNode.html: Added.
12:09 AM Changeset in webkit [158730] by akling@apple.com
  • 7 edits in trunk/Source/WebCore

RenderBlockFlow should only expose its line boxes as RootInlineBox.
<https://webkit.org/b/123878>

The line boxes attached directly to a RenderBlockFlow are always
RootInlineBox objects, so call sites should always use the tightly
typed firstRootBox() and lastRootBox().

This allows the compiler to devirtualize calls to member functions
of RootInlineBox that are marked FINAL.

Reviewed by Antti Koivisto.

12:05 AM Changeset in webkit [158729] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Assertion failure end < m_runCount in WebCore::BidiRunList<WebCore::BidiRun>::reverseRuns
https://bugs.webkit.org/show_bug.cgi?id=123863

Reviewed by Andreas Kling.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/cbaa92c763a37d89eeabd01658e522219299290c

Test: fast/text/bidi-reverse-runs-crash.html

  • platform/text/BidiResolver.h:

(WebCore::BidiResolver<Iterator, Run>::createBidiRunsForLine): Don't reverse the runs if there's
nothing to be reversed.

LayoutTests:

  • fast/text/bidi-reverse-runs-crash-expected.txt: Added.
  • fast/text/bidi-reverse-runs-crash.html: Added.
12:02 AM Changeset in webkit [158728] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Address the review comment after r158724.

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent):

Nov 5, 2013:

11:31 PM Changeset in webkit [158727] by Alan Bujtas
  • 3 edits
    1 add in trunk

Widget's position change should not initiate layout, only when its size changes.
https://bugs.webkit.org/show_bug.cgi?id=123860

Reviewed by Andreas Kling.

RenderWidgets initiate unnecessary layouts while scrolling when they are embedded to
overflow:scroll containers. Scroll position change doesn't dirty the render tree
so it should not trigger layout either.

.:

  • ManualTests/layouts-on-renderwidgets-while-scrolling.html: Added.

Source/WebCore:

Manual test added. Unfortunately we can't test against the number of layouts yet.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidgetGeometry):
(WebCore::RenderWidget::updateWidgetGeometry):
(WebCore::RenderWidget::updateWidgetPosition):

11:30 PM Changeset in webkit [158726] by rniwa@webkit.org
  • 3 edits
    8 adds in trunk/LayoutTests

Add more tests for formaction, formenctype, formmethod, formnovalidate, and formtarget attributes
https://bugs.webkit.org/show_bug.cgi?id=123876

Reviewed by Andreas Kling.

Merge tests from https://chromium.googlesource.com/chromium/blink/+/5f4ccd416fec39a6878af66e87bda191cc59ea7e
so that we won't introduce regressions they had.

  • fast/forms/formaction-attribute-expected.txt:
  • fast/forms/formaction-attribute.html:
  • fast/forms/formmethod-attribute-input-2-expected.txt: Added.
  • fast/forms/formmethod-attribute-input-2.html: Added.
  • fast/forms/formtarget-attribute-input-2-expected.txt: Added.
  • fast/forms/formtarget-attribute-input-2.html: Added.
  • fast/forms/interactive-validation-formnovalidate-2-expected.txt: Added.
  • fast/forms/interactive-validation-formnovalidate-2.html: Added.
  • fast/forms/mailto/formenctype-attribute-input-2-expected.txt: Added.
  • fast/forms/mailto/formenctype-attribute-input-2.html: Added.
11:20 PM Changeset in webkit [158725] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Mac Mavericks rebaseline after r158714.

  • platform/mac/fast/forms/textAreaLineHeight-expected.txt:
11:11 PM Changeset in webkit [158724] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

Use-after-free in SliderThumbElement::dragFrom
https://bugs.webkit.org/show_bug.cgi?id=123873

Reviewed by Andreas Kling.

Source/WebCore:

Ref the SliderThumbElement since it could go away inside dragFrom.

Test: fast/forms/range/range-type-change-onchange-2.html

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::handleMouseDownEvent):

LayoutTests:

Merge https://chromium.googlesource.com/chromium/blink/+/04a23bfca2d04101a1828d36ff36c29f3a24f34b

  • fast/forms/range/range-type-change-onchange-2-expected.txt: Added.
  • fast/forms/range/range-type-change-onchange-2.html: Added.
10:14 PM Changeset in webkit [158723] by rniwa@webkit.org
  • 3 edits in trunk/Source/WebCore

Change the order of conditions to avoid computing rendererIsEditable()
https://bugs.webkit.org/show_bug.cgi?id=123868

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/c89b413ff0fc4aafa0c71d180b0b1e131bb37707

When we need both Node::renderer() and Node::rendererIsEditable() conditions to be true to perform
some operation, it is more effective to check for renderer() first, so that if this condition fails
we can avoid unnecessary computation of rendererIsEditable().

  • dom/Position.cpp:

(WebCore::nextRenderedEditable):
(WebCore::previousRenderedEditable):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseReleaseEvent):

10:02 PM Changeset in webkit [158722] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

simpleUserAgentStyleSheet doesn't have focus ring on anchor element
https://bugs.webkit.org/show_bug.cgi?id=123867

Reviewed by Andreas Kling.

Merge https://chromium.googlesource.com/chromium/blink/+/08ecc23c4d80be9969918c4baf0ac83dc6cb6cbd

  • css/CSSDefaultStyleSheets.cpp:
10:00 PM Changeset in webkit [158721] by rniwa@webkit.org
  • 3 edits
    2 adds in trunk

valueForBorderRadiusShorthand returns wrong values in some case
https://bugs.webkit.org/show_bug.cgi?id=123866

Reviewed by Andreas Kling.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/0933728126f2db06ab8e945efc98bffa2d42af1c

Because valueForBorderRadiusShorthand misses the followings:

  • showHorizontalBottomRight depends on showHorizontalBottomLeft.
  • showHorizontalTopRight depends on showHorizontalBottomRight (including showHorizontalBottomLeft).

See also http://dev.w3.org/csswg/css-backgrounds/#the-border-radius

Test: fast/css/getComputedStyle/getComputedStyle-borderRadius-2.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::getBorderRadiusShorthandValue):

LayoutTests:

  • fast/css/getComputedStyle/getComputedStyle-borderRadius-2-expected.txt: Added.
  • fast/css/getComputedStyle/getComputedStyle-borderRadius-2.html: Added.
9:50 PM Changeset in webkit [158720] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Flaky Test: transitions/cancel-transition.html
https://bugs.webkit.org/show_bug.cgi?id=114193

Reviewed by Simon Fraser.

Merge https://chromium.googlesource.com/chromium/blink/+/983dbbff6c46b6365540bf1451f25b31d72ce893

  • transitions/cancel-transition.html:
9:21 PM Changeset in webkit [158719] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

Protect DOM nodes in IndentOutdentCommand::tryIndentingAsListItem()
https://bugs.webkit.org/show_bug.cgi?id=123861

Reviewed by Benjamin Poulain.

Merge https://chromium.googlesource.com/chromium/blink/+/297442eb539a2b764fdad323de79099a70179186 partially.

  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::tryIndentingAsListItem): Make selectedListItem, previousList, and nextList
RefPtr since they're are used after calling insertNodeBefore.

8:47 PM Changeset in webkit [158718] by akling@apple.com
  • 22 edits in trunk/Source/WebCore

Apply more unique_ptr to line box management.
<https://webkit.org/b/123857>

Make all of the functions that return newly-created line boxes
return them packed up in std::unique_ptrs.

There is one exception in RenderBlockLineLayout where the function
createInlineBoxForRenderer() is inconsistent about the ownership of
the returned object. This will be addressed by a subsequent patch.

We now "release" the line boxes into their various home structures,
so the pointer smartness doesn't go end-to-end just yet.

Reviewed by Anders Carlsson.

8:40 PM Changeset in webkit [158717] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

FTL should support NewObject
https://bugs.webkit.org/show_bug.cgi?id=123849

Reviewed by Oliver Hunt.

  • ftl/FTLAbstractHeapRepository.cpp:

(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):

  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNewObject):
(JSC::FTL::LowerDFGToLLVM::allocate):

8:38 PM Changeset in webkit [158716] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

FTL should support StringCharAt
https://bugs.webkit.org/show_bug.cgi?id=123855

Reviewed by Oliver Hunt.

This is just like GetByVal for String, so we reuse that code.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compileStringCharAt):

7:59 PM Changeset in webkit [158715] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebKit/win

Windows build fix attempt after r158704.

  • FullscreenVideoController.cpp:
7:55 PM Changeset in webkit [158714] by rniwa@webkit.org
  • 5 edits
    2 adds in trunk

getComputedStyle(x).lineHeight is affected by zooming
https://bugs.webkit.org/show_bug.cgi?id=123847

Reviewed by Benjamin Poulain.

Source/WebCore:

Merge https://chromium.googlesource.com/chromium/blink/+/7957097afbab2899ababd0d9c8acbf6e3eddb870

Test: fast/css/line-height-zoom-get-computed-style.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::lineHeightFromStyle): Don't round line-height values.

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyLineHeight::applyValue): Use the computed value instead of the used value.

LayoutTests:

Cleaned up the test.

  • fast/css/line-height-zoom-get-computed-style-expected.txt: Added.
  • fast/css/line-height-zoom-get-computed-style.html: Added.
  • platform/mac-mountainlion/fast/forms/textAreaLineHeight-expected.txt: Rebaselined.
7:50 PM Changeset in webkit [158713] by commit-queue@webkit.org
  • 10 edits in trunk

AX: media controls accessibility needs more work
https://bugs.webkit.org/show_bug.cgi?id=123749

Patch by James Craig <jcraig@apple.com> on 2013-11-05
Reviewed by Jer Noble.

Updated some of the control labels/roles to improve accessibility.

  • Volume slider is now keyboard/screenreader accessible.
  • muteButton was a checkbox toggling checked state, now a button that toggles label "mute/unmute"
  • fullscreenButton was a checkbox toggling checked state, now a button that toggles label "display/exit full screen"
  • captionButton was a checkbox, now a popup button that launches the newly accessible menu.

Subtitles menu is now keyboard/screenreader accessible (uses roaming tabindex).
Render dump expectations changed because volume slider is now hidden via...
...opacity/size (to make accessible without hover) instead of display:none.

Updated existing test coverage.

Source/WebCore:

  • Modules/mediacontrols/mediaControlsApple.css:

(audio::-webkit-media-controls-panel .volume-box):
(audio::-webkit-media-controls-panel .volume-box:active):
(audio::-webkit-media-controls-toggle-closed-captions-button):
(audio::-webkit-media-controls-closed-captions-container .list):
(audio::-webkit-media-controls-closed-captions-container li:focus):

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.createControls):
(Controller.prototype.handleFullscreenChange):
(Controller.prototype.handleMuteButtonClicked):
(Controller.prototype.handleMinButtonClicked):
(Controller.prototype.handleMaxButtonClicked):
(Controller.prototype.handleVolumeSliderChange):
(Controller.prototype.buildCaptionMenu):
(Controller.prototype.focusSiblingCaptionItem):
(Controller.prototype.handleCaptionItemKeyUp):

LayoutTests:

  • platform/mac/accessibility/media-element-expected.txt:
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-strict-expected.txt:
  • platform/mac/media/controls-styling-strict-expected.txt:
  • platform/mac/media/controls-without-preload-expected.txt:
7:36 PM Changeset in webkit [158712] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Move some plugin-specific code from RenderWidget to RenderEmbeddedObject.
<https://webkit.org/b/123845>

All RenderWidgets representing plugins will be RenderEmbeddedObjects.
Move some of the plugin-specific logic to RenderEmbeddedObject since it
doesn't make sense for all RenderWidgets (frames, embedded documents)
to care about this.

Reviewed by Anders Carlsson.

6:48 PM Changeset in webkit [158711] by rniwa@webkit.org
  • 3 edits in trunk/LayoutTests

Add a test to obtain offsetWidth of expanded table cell
https://bugs.webkit.org/show_bug.cgi?id=123843

Reviewed by Tim Horton.

Merge the test fix in https://chromium.googlesource.com/chromium/blink/+/b249d552497c0939d8277360b99dd3c56b0c9659.

  • fast/table/table-cell-offset-width-expected.txt:
  • fast/table/table-cell-offset-width.html:
6:40 PM Changeset in webkit [158710] by rniwa@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add a test to obtain offsetWidth of expanded table cell
https://bugs.webkit.org/show_bug.cgi?id=123843

Reviewed by Tim Horton.

Merge the test from https://chromium.googlesource.com/chromium/blink/+/58a5fac292a5b3f79b00cdc71074fbf8be2ebc2b
so that we'll never introduce the regression they had.

  • fast/table/table-cell-offset-width-expected.txt: Added.
  • fast/table/table-cell-offset-width.html: Added.
6:39 PM Changeset in webkit [158709] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the 32-bit build.

  • WebCore.exp.in:
6:15 PM Changeset in webkit [158708] by Alexandru Chiculita
  • 4 edits
    7 adds in trunk

Web Inspector: Moving an element while in the DOMNodeRemoved handler will hide it in the inspector
https://bugs.webkit.org/show_bug.cgi?id=123516

Reviewed by Timothy Hatcher.

Source/WebCore:

InspectorInstrumentation::willRemoveDOMNode was actually calling both willRemoveDOMNodeImpl and
didRemoveDOMNodeImpl, making the DOMAgent unbind the element even if it was still part of the DOM.

Because of that the DOMAgent was sending two events:

  1. When the element was about to be removed, just before JS "DOMNodeRemoved" was triggered.
  2. When the element was actually removed.

Note that inspector's event #2 will not know about the node, as it just removed it from the
internal hashmap, so it will just use a nodeID == 0 for it.

This patch adds a separate call to InspectorInstrumentation::didRemoveDOMNode, just before the
element is about to be removed. The InspectorInstrumentation::willRemoveDOMNode call is now only used
by the DOMDebugger to trigger the DOM breakpoints in the Web Inspector. That feature is not exposed
in the new Inspector UI, but can be used/tested using the protocol directly.

Tests: inspector-protocol/dom-debugger/node-removed.html

inspector-protocol/dom/dom-remove-events.html
inspector-protocol/dom/remove-multiple-nodes.html

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeBetween):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willRemoveDOMNode):
(WebCore::InspectorInstrumentation::didRemoveDOMNode):

LayoutTests:

Added tests to check that the DOM.childNodeRemoved inspector-protocol message is dispatched
correctly when DOM nodes are moved while inside the "DOMNodeRemoved" event handler.

  • inspector-protocol/dom-debugger/node-removed-expected.txt: Added.
  • inspector-protocol/dom-debugger/node-removed.html: Added. Checking that the DOMDebugger agent

is still sending the node-removed events.

  • inspector-protocol/dom/dom-remove-events-expected.txt: Added.
  • inspector-protocol/dom/dom-remove-events.html: Added. Test with a single DOM remove event.
  • inspector-protocol/dom/remove-multiple-nodes-expected.txt: Added.
  • inspector-protocol/dom/remove-multiple-nodes.html: Added. Test case when multiple children

are removed at once with parentNode.textContent = "String".

6:09 PM Changeset in webkit [158707] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove old unused code for hypothetical LLVM intrinsics
https://bugs.webkit.org/show_bug.cgi?id=123824

Reviewed by Oliver Hunt.

  • ftl/FTLIntrinsicRepository.h:
6:07 PM Changeset in webkit [158706] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

FTL should support String character access operations
https://bugs.webkit.org/show_bug.cgi?id=123783

Reviewed by Oliver Hunt.

Implements:

  • string.length


  • string[index]
  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetIndexedPropertyStorage):
(JSC::FTL::LowerDFGToLLVM::compileGetArrayLength):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):

6:03 PM Changeset in webkit [158705] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix on CMake based ports with GLES.

  • CMakeLists.txt:

Added OPENGLES2_LIBRARIES and OPENGLES2_INCLUDE_DIR into the includes and
libraries list.

5:44 PM Changeset in webkit [158704] by timothy_horton@apple.com
  • 9 edits in trunk/Source/WebCore

platformCALayerDeviceScaleFactor should be const
https://bugs.webkit.org/show_bug.cgi?id=123842

Reviewed by Simon Fraser.

  • WebCore.exp.in:
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::LayerClient::platformCALayerDeviceScaleFactor):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::platformCALayerDeviceScaleFactor):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/PlatformCALayerClient.h:
  • platform/graphics/ca/mac/TileController.h:
  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::platformCALayerDeviceScaleFactor):

  • platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

(WebCore::MediaPlayerPrivateQuickTimeVisualContext::LayerClient::platformCALayerDeviceScaleFactor):
Constify PlatformCALayerClient::platformCALayerDeviceScaleFactor.

5:39 PM Changeset in webkit [158703] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

text-decoration-skip: ink isn't tested with underlines that don't intersect the underlined text
https://bugs.webkit.org/show_bug.cgi?id=123839

Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-11-05
Reviewed by Simon Fraser.

text-decoration-skip: ink uses a mask to determine where the underline can be drawn. Right now,
there is not a test that makes sure that the mask always gets applied to the location
where the underline will get drawn.

  • fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-non-intersecting-underline-expected.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-skip/text-decoration-skip-non-intersecting-underline.html: Added.
5:26 PM Changeset in webkit [158702] by barraclough@apple.com
  • 3 edits in trunk/Source/WebCore

Subresource loads should not prevent page throttling
https://bugs.webkit.org/show_bug.cgi?id=123757

Reviewed by Alexey Proskuryakov.

The page-is-loading test for inhibiting process supression is currently
too conservative, preventing supression of pages with infinitely loading
resources (commonly XHRs). Instead, just rely on the FrameLoader being
active (with hysteresis).

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::init):
(WebCore::SubresourceLoader::checkForHTTPStatusCodeError):
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::willCancel):

  • loader/SubresourceLoader.h:
    • remove m_activityAssertion from SubresourceLoader.
5:13 PM Changeset in webkit [158701] by timothy_horton@apple.com
  • 5 edits
    4 adds in trunk

[mac] PDFDocumentImage is too big if PDF has a crop box smaller than the media box
https://bugs.webkit.org/show_bug.cgi?id=123840
<rdar://problem/15308765>

Reviewed by Alexey Proskuryakov.

Test: fast/images/pdf-as-image-crop-box.html

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::size):
Use the crop box when determining the size of the image.

(WebCore::PDFDocumentImage::computeBoundsForCurrentPage):

  • platform/graphics/cg/PDFDocumentImage.h:
  • platform/graphics/mac/PDFDocumentImageMac.mm:

(WebCore::PDFDocumentImage::computeBoundsForCurrentPage):
Get rid of m_mediaBox, since we don't need it anymore.

(WebCore::PDFDocumentImage::drawPDFPage):
PDFKit does the translation by the crop box origin for us;
if we do it additionally, we'll be painting the wrong part of the image.
So, don't do the translation here.

  • fast/images/pdf-as-image-crop-box-expected.html: Added.
  • fast/images/pdf-as-image-crop-box.html: Added.
  • fast/images/resources/green-1x1.pdf: Added.
  • fast/images/resources/red-green-2x2-cropped-to-1x1.pdf: Added.

Add a test that ensures that PDFDocumentImage respects the PDF's crop box.
red-green-2x2-cropped-to-1x1 has a 2"x2" red square with a 1"x1" green
square centered in it, a media box of 2"x2", and a crop box of 1"x1"
offset by 0.5", 0.5". green-1x1 has a 1"x1" green square. The two images
should render the same if the crop box is being respected correctly.

4:58 PM Changeset in webkit [158700] by andersca@apple.com
  • 5 edits
    1 copy in trunk/Source/WebKit2

Begin work on decoding invocations
https://bugs.webkit.org/show_bug.cgi?id=123838

Reviewed by Dan Bernstein.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeInvocation):
Declare the type string and selector keys as constants.

(encodeObject):
Make sure to encode the class name for NSInvocations as well.

(decodeInvocation):
Figure out the local and remove method signatures and make sure that they are equal.

  • Shared/API/Cocoa/WKRemoteObjectInterface.mm:

(methodArgumentTypeEncodingForSelector):
Helper function that returns the type encoding for a given selector.

(-[WKRemoteObjectInterface _methodSignatureForSelector:]):
Helper function that returns a method signature for the method with the name referred to by selector.

  • Shared/API/Cocoa/WKRemoteObjectInterfaceInternal.h: Added.

Add internal header.

  • Shared/API/Cocoa/WKRemoteObjectRegistry.mm:

(-[WKRemoteObjectRegistry _invokeMessageWithInterfaceIdentifier:encodedInvocation:]):
Pass the right object to the WKRemoteObjectDecoder initializer and decode the invocation.

  • WebKit2.xcodeproj/project.pbxproj:

Add internal header.

3:58 PM Changeset in webkit [158699] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

WKRemoteObjectDecoder should know which interface it's decoding for
https://bugs.webkit.org/show_bug.cgi?id=123833

Reviewed by Andreas Kling.

Move the interface identifier out into the root object body dictionary and make
the encoded invocation a sibling of it. That way we can look up the interface before
creating the decoder.

Also, manage exported objects and interfaces in a separate hash map.

  • Shared/API/Cocoa/WKRemoteObjectCoder.h:
  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(-[WKRemoteObjectDecoder initWithInterface:rootObjectDictionary:WebKit::]):
(decodeInvocation):
(decodeObject):

  • Shared/API/Cocoa/WKRemoteObjectRegistry.mm:

(-[WKRemoteObjectRegistry registerExportedObject:interface:]):
(-[WKRemoteObjectRegistry unregisterExportedObject:interface:]):
(-[WKRemoteObjectRegistry _sendInvocation:interface:]):
(-[WKRemoteObjectRegistry _handleMessageWithName:body:]):
(-[WKRemoteObjectRegistry _invokeMessageWithInterfaceIdentifier:encodedInvocation:]):

3:45 PM Changeset in webkit [158698] by Antti Koivisto
  • 8 edits
    1 add in trunk/Source/WebCore

Factor index cache for NodeLists and HTMLCollections to a class
https://bugs.webkit.org/show_bug.cgi?id=123823

Reviewed by Ryosuke Niwa.

Implement index cache class that can used by NodeLists and HTMLCollections that currently
each have implementations of their own.

This patch also implements ChildNodeList and LiveNodeList using CollectionIndexCache.
HTMLCollection is will be transitioned later.

  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ChildNodeList.cpp:

(WebCore::ChildNodeList::ChildNodeList):
(WebCore::ChildNodeList::length):
(WebCore::ChildNodeList::item):

The client calls to cache to for indexed and size access.

(WebCore::ChildNodeList::collectionFirst):
(WebCore::ChildNodeList::collectionLast):
(WebCore::ChildNodeList::collectionTraverseForward):
(WebCore::ChildNodeList::collectionTraverseBackward):

Cache calls back to these as needed to do the actual traversal.

(WebCore::ChildNodeList::invalidateCache):

  • dom/ChildNodeList.h:
  • dom/CollectionIndexCache.h: Added.


Templated cache class itself.

(WebCore::::CollectionIndexCache):
(WebCore::::nodeCount):
(WebCore::::nodeBeforeCached):
(WebCore::::nodeAfterCached):
(WebCore::::nodeAt):
(WebCore::::invalidate):

  • dom/LiveNodeList.cpp:

(WebCore::firstMatchingElement):
(WebCore::nextMatchingElement):
(WebCore::traverseMatchingElementsForward):
(WebCore::LiveNodeList::collectionFirst):
(WebCore::LiveNodeList::collectionLast):
(WebCore::LiveNodeList::collectionTraverseForward):
(WebCore::LiveNodeList::collectionTraverseBackward):
(WebCore::LiveNodeList::length):
(WebCore::LiveNodeList::item):
(WebCore::LiveNodeList::invalidateCache):

  • dom/LiveNodeList.h:

(WebCore::LiveNodeList::LiveNodeList):

3:14 PM Changeset in webkit [158697] by enrica@apple.com
  • 6 edits in trunk

Full width semicolon is wrong in vertical text.
https://bugs.webkit.org/show_bug.cgi?id=123814
<rdar://problem/15312541>

Reviewed by Benjamin Poulain.

Source/WebCore:

The full width semicolon should always be upright.
Adding it to the list of characters that should
ignore rotation.

  • platform/graphics/FontGlyphs.cpp:

(WebCore::shouldIgnoreRotation):

LayoutTests:

Extended the existing test to include the full width
semicolon.

  • platform/mac/fast/text/vertical-no-sideways.html:
  • platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt:
  • platform/mac-mountainlion/platform/mac/fast/text/vertical-no-sideways-expected.txt
3:00 PM Changeset in webkit [158696] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Add support for decoding NSStrings
https://bugs.webkit.org/show_bug.cgi?id=123829

Reviewed by Andreas Kling.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeObject):
(-[WKRemoteObjectDecoder allowsKeyedCoding]):
Always return YES.

(-[WKRemoteObjectDecoder containsValueForKey:]):
Look up the key in the current dictionary.

(-[WKRemoteObjectDecoder decodeBytesForKey:returnedLength:]):
Try to get the WebData object and return its data + size.

(-[WKRemoteObjectDecoder requiresSecureCoding]):
Return YES.

(checkIfClassIsAllowed):
Check if the class or any of its superclasses are are allowed.

(validateClass):
Call checkIfClassIsAllowed and validate that the class conforms to NSSecureCoding.

(decodeObject):
Get the class name, verify that the class exists and is allowed.
Allocate and initialize an object using initWithCoder:.

(-[WKRemoteObjectDecoder decodeObjectOfClasses:forKey:]):
Set the allowed classes, look up the object in _currentDictionary and call decodeObject.

(-[WKRemoteObjectDecoder allowedClasses]):
Return _allowedClasses.

  • Shared/API/Cocoa/WKRemoteObjectRegistry.mm:

(-[WKRemoteObjectRegistry _sendInvocation:interface:]):
Declare interfaceIdentifier as a constant.

(-[WKRemoteObjectRegistry _invokeMessageWithBody:]):
Decode the interface identifier.

  • Shared/ImmutableDictionary.h:

(WebKit::ImmutableDictionary::get):
(WebKit::ImmutableDictionary::size):
(WebKit::ImmutableDictionary::map):
Make member functions const.

2:51 PM Changeset in webkit [158695] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ObjCCallbackFunctionImpl's NSInvocation shouldn't retain its target or arguments
https://bugs.webkit.org/show_bug.cgi?id=123822

Reviewed by Geoffrey Garen.

Using -retainArguments on ObjCCallbackFunctionImpl's NSInvocation leads to memory leaks.
We should handle retaining/releasing the target ourselves, and we should never retain the arguments.

  • API/ObjCCallbackFunction.mm:

(JSC::ObjCCallbackFunctionImpl::~ObjCCallbackFunctionImpl):
(JSC::ObjCCallbackFunctionImpl::name):
(objCCallbackFunctionForInvocation):
(objCCallbackFunctionForMethod):
(objCCallbackFunctionForBlock):

2:44 PM Changeset in webkit [158694] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix Mountain Lion Debug bot after r158689

Unreviewed.

It looks like WebGeolocationManagerProxy::stopUpdating() and WebGeolocationManagerProxy::processDidClose()
are racing in some cases, causing the assertion to fail.

That case is handled properly in the last if() branch of WebGeolocationManagerProxy::removeRequester().
This patch remove the overzealous assertion.

  • UIProcess/WebGeolocationManagerProxy.cpp:

(WebKit::WebGeolocationManagerProxy::removeRequester):

2:38 PM Changeset in webkit [158693] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Remove unused RenderWidget::notifyWidget().

Rubber-stamped by Anders Carlsson.

2:30 PM Changeset in webkit [158692] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix build for architectures with 4 argument registers (broken since r158681).
https://bugs.webkit.org/show_bug.cgi?id=123826

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-05
Reviewed by Michael Saboff.

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState):
(JSC::CCallHelpers::setupArguments):

2:04 PM Changeset in webkit [158691] by timothy_horton@apple.com
  • 5 edits
    2 adds in trunk/Source/WebKit2

Remote Layer Tree: Apply layer changes to LayerTypeCustom layers to the custom layer in the Web process, not to the CALayerHost
https://bugs.webkit.org/show_bug.cgi?id=123818

Reviewed by Anders Carlsson.

Changes to the properties of a PlatformCALayer of type LayerTypeCustom are intended
to affect the custom CALayer; however, we were bundling them up with the transaction
and applying them to the CALayerHost, leading to important properties being lost.

Instead, apply them to the Web-process-side CALayer when building the transaction.

  • Shared/mac/RemoteLayerTreePropertyApplier.h: Added.
  • Shared/mac/RemoteLayerTreePropertyApplier.mm: Added.

(WebKit::cgColorFromColor):
(WebKit::toCAFilterType):
(WebKit::RemoteLayerTreePropertyApplier::applyPropertiesToLayer):
(WebKit::RemoteLayerTreePropertyApplier::disableActionsForLayer):
Move code to apply LayerProperties to a CALayer from RemoteLayerTreeHost.
Move code to disable actions on a CALayer from RemoteLayerTreeHost.

  • UIProcess/mac/RemoteLayerTreeHost.mm:

(WebKit::RemoteLayerTreeHost::commit):
(WebKit::RemoteLayerTreeHost::createLayer):
Use RemoteLayerTreePropertyApplier.
Hand it a map of LayerID->CALayer so that it can look up related layers
for children and mask layers.

  • WebKit2.xcodeproj/project.pbxproj:

Add RemoteLayerTreePropertyApplier.{h,mm}

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::recursiveBuildTransaction):
Upon commit, apply changes to LayerTypeCustom layers to the platform layer.
Setting children or maskLayer won't work, since we don't know about other raw CALayers.
This is OK, since nothing uses those properties on custom layers.

  • WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.cpp:

(PlatformCALayerRemoteCustom::PlatformCALayerRemoteCustom):
Disable actions on the root custom layer.

1:21 PM Changeset in webkit [158690] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Begin work on a WKRemoteObjectDecoder object
https://bugs.webkit.org/show_bug.cgi?id=123819

Reviewed by Dan Bernstein.

  • Shared/API/Cocoa/WKRemoteObjectCoder.h:
  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(-[WKRemoteObjectDecoder initWithRootObjectDictionary:]):
Add designated initializer.

  • Shared/API/Cocoa/WKRemoteObjectRegistry.mm:

(-[WKRemoteObjectRegistry _handleMessageWithName:body:]):
If the message has the expected name and body type, pass it along to -_invokeMessageWithBody:.

(-[WKRemoteObjectRegistry _invokeMessageWithBody:]):
Create a decoder.

1:17 PM Changeset in webkit [158689] by benjamin@webkit.org
  • 18 edits
    5 adds in trunk

[WK2] Add a WebKit2 API for Geolocation's highAccuracy
https://bugs.webkit.org/show_bug.cgi?id=123786

Reviewed by Darin Adler.

Source/WebKit2:

This adds support for highAccuracy Geolocation with WebKit2.

The key is to track which page/requester need what kind of geolocation
in order to change between high and low accuracy as pages run and disappear.

WebGeolocationManager and WebGeolocationManagerProxy have very similar roles
but for different sources:
-WebGeolocationManager tracks which live page require high accuracy geolocation.

When the state changes, it forward the information to the UIProcess.

-WebGeolocationManagerProxy tracks which WebContent processes needs high accuracy.

  • Shared/APIClientTraits.cpp:
  • Shared/APIClientTraits.h:
  • UIProcess/API/C/WKGeolocationManager.h:
  • UIProcess/WebGeolocationManagerProxy.cpp:

(WebKit::WebGeolocationManagerProxy::startUpdating):
(WebKit::WebGeolocationManagerProxy::removeRequester):
(WebKit::WebGeolocationManagerProxy::setEnableHighAccuracy):

  • UIProcess/WebGeolocationManagerProxy.h:

(WebKit::WebGeolocationManagerProxy::isUpdating):
(WebKit::WebGeolocationManagerProxy::isHighAccuracyEnabled):

  • UIProcess/WebGeolocationManagerProxy.messages.in:
  • UIProcess/WebGeolocationProvider.cpp:

(WebKit::WebGeolocationProvider::setEnableHighAccuracy):

  • UIProcess/WebGeolocationProvider.h:
  • WebProcess/Geolocation/WebGeolocationManager.cpp:

(WebKit::WebGeolocationManager::registerWebPage):
(WebKit::WebGeolocationManager::unregisterWebPage):
(WebKit::WebGeolocationManager::setEnableHighAccuracyForPage):

  • WebProcess/Geolocation/WebGeolocationManager.h:

(WebKit::WebGeolocationManager::isUpdating):
(WebKit::WebGeolocationManager::isHighAccuracyEnabled):

  • WebProcess/WebCoreSupport/WebGeolocationClient.cpp:

(WebKit::WebGeolocationClient::setEnableHighAccuracy):

Tools:

Add basic testing for the Geolocation API (start, stop and change accuracy).

  • TestWebKitAPI/GNUmakefile.am:
  • TestWebKitAPI/PlatformEfl.cmake:
  • TestWebKitAPI/PlatformGTK.cmake:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/Geolocation.cpp: Added.

(TestWebKitAPI::operator<<):
(TestWebKitAPI::GeolocationStateTracker::~GeolocationStateTracker):
(TestWebKitAPI::GeolocationStateTracker::eventsChanged):
(TestWebKitAPI::GeolocationStateTracker::startUpdatingCallback):
(TestWebKitAPI::GeolocationStateTracker::stopUpdatingCallback):
(TestWebKitAPI::GeolocationStateTracker::setEnableHighAccuracyCallback):
(TestWebKitAPI::decidePolicyForGeolocationPermissionRequestCallBack):
(TestWebKitAPI::setupGeolocationProvider):
(TestWebKitAPI::setupView):
(TestWebKitAPI::GeolocationBasicStateTracker::GeolocationBasicStateTracker):
(TestWebKitAPI::GeolocationBasicStateTracker::eventsChanged):
(TestWebKitAPI::GeolocationBasicWithHighAccuracyStateTracker::GeolocationBasicWithHighAccuracyStateTracker):
(TestWebKitAPI::GeolocationBasicWithHighAccuracyStateTracker::eventsChanged):
(TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::GeolocationTransitionToHighAccuracyStateTracker):
(TestWebKitAPI::GeolocationTransitionToHighAccuracyStateTracker::eventsChanged):
(TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::GeolocationTransitionToLowAccuracyStateTracker):
(TestWebKitAPI::GeolocationTransitionToLowAccuracyStateTracker::eventsChanged):
(TestWebKitAPI::didFinishLoadForFrame):

  • TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPosition.html: Added.
  • TestWebKitAPI/Tests/WebKit2/geolocationGetCurrentPositionWithHighAccuracy.html: Added.
  • TestWebKitAPI/Tests/WebKit2/geolocationWatchPosition.html: Added.
  • TestWebKitAPI/Tests/WebKit2/geolocationWatchPositionWithHighAccuracy.html: Added.
  • WebKitTestRunner/GeolocationProviderMock.cpp:

(WTR::GeolocationProviderMock::GeolocationProviderMock):

1:16 PM Changeset in webkit [158688] by commit-queue@webkit.org
  • 10 edits in trunk

Unreviewed, rolling out r158678.
http://trac.webkit.org/changeset/158678
https://bugs.webkit.org/show_bug.cgi?id=123820

Causes a new debug assertion failure on the Mavericks test
system. (Requested by bfulgham on #webkit).

Source/WebCore:

  • rendering/mathml/RenderMathMLOperator.cpp:

LayoutTests:

  • TestExpectations:
  • mathml/presentation/mo-stretch.html:
  • platform/gtk/TestExpectations:
  • platform/gtk/mathml/presentation/mo-stretch-expected.png:
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/mo-stretch-expected.png:
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
1:04 PM Changeset in webkit [158687] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fix register allocation inside control flow in GetByVal String
https://bugs.webkit.org/show_bug.cgi?id=123816

Reviewed by Geoffrey Garen.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnString):

1:03 PM Changeset in webkit [158686] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove FTL::LowerDFGToLLVM::compileJSConstant()
https://bugs.webkit.org/show_bug.cgi?id=123817

Reviewed by Geoffrey Garen.

  • ftl/FTLLowerDFGToLLVM.cpp:
12:56 PM Changeset in webkit [158685] by andersca@apple.com
  • 6 edits in trunk

Implement more NSCoder methods
https://bugs.webkit.org/show_bug.cgi?id=123815

Reviewed by Dan Bernstein.

Source/WebKit2:

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeObject):
Assert that object is not nil.

(createEncodedObject):
Handle nil objects.

(-[WKRemoteObjectEncoder encodeValueOfObjCType:at:]):
Call the right object stream encoding function based on the object type.

(-[WKRemoteObjectEncoder encodeBool:forKey:]):
(-[WKRemoteObjectEncoder encodeInt64:forKey:]):
(-[WKRemoteObjectEncoder encodeDouble:forKey:]):
Create APIObjects and add them to the current dictionary.

Tools:

Add a method that takes an NSArray, an NSDictionary and an NSURLRequest.

  • TestWebKitAPI/Tests/WebKit2ObjC/WKRemoteObjectRegistry.mm:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Bundle.mm:

(-[BundleObject testMethodWithArray:dictionary:request:]):

  • TestWebKitAPI/Tests/mac/WKRemoteObjectRegistry_Shared.h:
11:34 AM Changeset in webkit [158684] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Encode the class name
https://bugs.webkit.org/show_bug.cgi?id=123813

Reviewed by Dan Bernstein.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeObject):
Get the Class using -[NSObject classForCoder] and encode its name in the object dictionary.

11:24 AM Changeset in webkit [158683] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Clean up the WKRemoteObjectEncoder code
https://bugs.webkit.org/show_bug.cgi?id=123811

Reviewed by Dan Bernstein.

Add a new object stream array to be used for the non-keyed encoding values
and free functions for encoding values to the object stream. Simplify object encoding
by moving the dictionary creation out into a separate function and ditching the block based methods.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(ensureObjectStream):
Add helper function to create an object stream.

(encodeToObjectStream):
Add overloads for encoding values into the object streams.

(encodeInvocation):
Add helper function for encoding an NSInvocation.

(encodeObject):
Call encodeInvocation if needed, otherwise just use encodeWithCoder:.

(createEncodedObject):
Helper function that sets up a dictionary, encodes the object into the dictionary and then returns the dictionary.

(-[WKRemoteObjectEncoder encodeObject:forKey:]):
Call createEncodedObject.

11:16 AM Changeset in webkit [158682] by reni@webkit.org
  • 4 edits
    2 adds in trunk

ASSERTION FAILED: isHTMLTitleElement(m_titleElement.get()) in WebCore::Document::setTitle
https://bugs.webkit.org/show_bug.cgi?id=122092

Reviewed by Darin Adler.

Source/WebCore:

Remove a bogus assert in Document::setTitle().
m_titleElement can be either of HTMLTitleElement or SVGTitleElement. The assertion was wrong.

Backported from Blink:
https://src.chromium.org/viewvc/blink?revision=158620&view=revision

Test: svg/custom/title-assertion.html

  • dom/Document.cpp:

(WebCore::Document::setTitle):

  • svg/SVGTitleElement.cpp:

(WebCore::SVGTitleElement::insertedInto):

LayoutTests:

  • svg/custom/title-assertion-expected.txt: Added.
  • svg/custom/title-assertion.html: Added.
10:56 AM Changeset in webkit [158681] by fpizlo@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

FTL should support PutById
https://bugs.webkit.org/show_bug.cgi?id=123784

Reviewed by Geoffrey Garen.

  • ftl/FTLAbbreviations.h:

(JSC::FTL::buildCall):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLCompile.cpp:

(JSC::FTL::generateICFastPath):
(JSC::FTL::fixFunctionBasedOnStackMaps):

  • ftl/FTLInlineCacheDescriptor.h:

(JSC::FTL::InlineCacheDescriptor::InlineCacheDescriptor):
(JSC::FTL::GetByIdDescriptor::GetByIdDescriptor):
(JSC::FTL::PutByIdDescriptor::PutByIdDescriptor):
(JSC::FTL::PutByIdDescriptor::ecmaMode):
(JSC::FTL::PutByIdDescriptor::putKind):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compilePutById):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::call):

  • ftl/FTLSlowPathCall.cpp:

(JSC::FTL::callOperation):

  • ftl/FTLSlowPathCall.h:
  • ftl/FTLState.h:
  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArguments):

  • runtime/Executable.h:

(JSC::ScriptExecutable::ecmaMode):

10:53 AM Changeset in webkit [158680] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

GetById->GetByOffset and PutById->PutByOffset folding should mark haveStructures since it may result in structure transition watchpoints
https://bugs.webkit.org/show_bug.cgi?id=123788

Reviewed by Geoffrey Garen.

haveStructures is true if there are any currentlyKnownStructures that have
interesting values, since that's the only time when clobbering needs to do things.
It's a really important compile-time optimization. But that also means that anytime
we might cause currentlyKnownStructures to get set - like when we might insert some
structure transition watchpoints - we need to set haveStructures. We were forgetting
to do that for GetById->GetByOffset and PutById->PutByOffset because, I guess, we
forgot that those might insert structure transition watchpoints.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

10:50 AM Changeset in webkit [158679] by fpizlo@apple.com
  • 3 edits in trunk/Tools

Update ReducedFTL
https://bugs.webkit.org/show_bug.cgi?id=123805

Reviewed by Sam Weinig.

  • Make ReducedFTL build with debug info.


  • Give ReducedFTL a --loop mode that runs everything in a loop. Great for finding memory leaks and attaching a profiler.


  • Reorder the passes so that they match the FTL.


  • Make it possible to change the backend opt level and enable the fast isel.
  • ReducedFTL/ReducedFTL.c:

(usage):
(roundUpSize):
(mmAllocateCodeSection):
(main):

  • ReducedFTL/build.sh:
10:06 AM Changeset in webkit [158678] by Martin Robinson
  • 10 edits in trunk

[MathML] Poor spacing around delimiters in MathML Torture Test 14
https://bugs.webkit.org/show_bug.cgi?id=122837

Reviewed by Brent Fulgham.

Instead of stretching the vertical bar with the stretchable version, just repeat
the normal vertical bar. This follows what Gecko does when rendering tall vertical
bars and also works around an issue with STIX fonts leading to poor spacing in
formulas.

Source/WebCore:

  • rendering/mathml/RenderMathMLOperator.cpp: Stretch the vertical bar with the

normal variant.

LayoutTests:

  • mathml/presentation/mo-stretch.html: Reworked this test to show

stretching of all stretchable characters, which reveals a bug with
the double vertical bar (covered by http://wkbug.com/123543).

  • platform/gtk/TestExpectations:
  • platform/gtk/mathml/presentation/mo-stretch-expected.png:
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/mathml/presentation/mo-stretch-expected.png:
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
10:05 AM Changeset in webkit [158677] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[mips] Make regTx registers match between JSInterfaceJIT and GPRInfo.
https://bugs.webkit.org/show_bug.cgi?id=123807

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-05
Reviewed by Mark Lam.

  • jit/GPRInfo.h:

(JSC::GPRInfo::toIndex):

  • jit/JSInterfaceJIT.h:
10:02 AM Changeset in webkit [158676] by dbates@webkit.org
  • 3 edits
    3 adds in trunk

XSSAuditor should catch reflected srcdoc properties even without a <frame> tag injection

From Blink r160615 by <tsepez@chromium.org>
https://src.chromium.org/viewvc/blink?view=rev&revision=160615

Source/WebCore:

Test: http/tests/security/xssAuditor/iframe-srcdoc-property-blocked.html

  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::filterIframeToken):

LayoutTests:

  • http/tests/security/xssAuditor/iframe-srcdoc-property-blocked-expected.txt: Added.
  • http/tests/security/xssAuditor/iframe-srcdoc-property-blocked.html: Added.
  • http/tests/security/xssAuditor/resources/echo-frame-src.pl: Added.
8:23 AM Changeset in webkit [158675] by Michał Pakuła vel Rutka
  • 2 edits
    6 adds in trunk/LayoutTests

Unreviewed EFL gardening

Add baselines for tests marked as missing.

  • platform/efl-wk1/TestExpectations:
  • platform/efl/css3/masking/mask-luminance-png-expected.txt: Added.
  • platform/efl/fast/css/color-correction-untagged-images-expected.png: Added.
  • platform/efl/fast/css/color-correction-untagged-images-expected.txt: Added.
  • platform/efl/fast/regions/iframe-html-collected-expected.txt: Added.
  • platform/efl/fast/repaint/hover-pseudo-borders-expected.png: Added.
  • platform/efl/fast/repaint/hover-pseudo-borders-expected.txt: Added.
8:16 AM Changeset in webkit [158674] by Chris Fleizach
  • 8 edits in trunk/Tools

AX: switch DRT AX methods to use nullptr
https://bugs.webkit.org/show_bug.cgi?id=123773

Reviewed by Andreas Kling.

Switch AX related code in DRT and WKTR to use nullptr.

  • DumpRenderTree/AccessibilityUIElement.cpp:

(AccessibilityUIElement::startTextMarker):
(AccessibilityUIElement::endTextMarker):

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(findAccessibleObjectById):
(AccessibilityController::accessibleElementById):

  • DumpRenderTree/mac/AccessibilityUIElementMac.mm:

(AccessibilityUIElement::getChildAtIndex):
(AccessibilityUIElement::linkedUIElementAtIndex):
(AccessibilityUIElement::ariaOwnsElementAtIndex):
(AccessibilityUIElement::ariaFlowToElementAtIndex):
(AccessibilityUIElement::disclosedRowAtIndex):
(AccessibilityUIElement::selectedChildAtIndex):
(AccessibilityUIElement::selectedRowAtIndex):
(AccessibilityUIElement::rowAtIndex):
(AccessibilityUIElement::titleUIElement):
(AccessibilityUIElement::parentElement):
(AccessibilityUIElement::disclosedByRow):
(AccessibilityUIElement::stringAttributeValue):
(AccessibilityUIElement::uiElementAttributeValue):
(AccessibilityUIElement::role):
(AccessibilityUIElement::subrole):
(AccessibilityUIElement::roleDescription):
(AccessibilityUIElement::title):
(AccessibilityUIElement::description):
(AccessibilityUIElement::orientation):
(AccessibilityUIElement::stringValue):
(AccessibilityUIElement::language):
(AccessibilityUIElement::helpText):
(AccessibilityUIElement::valueDescription):
(AccessibilityUIElement::speak):
(AccessibilityUIElement::classList):
(AccessibilityUIElement::ariaDropEffects):
(AccessibilityUIElement::rangeForLine):
(AccessibilityUIElement::rangeForPosition):
(AccessibilityUIElement::boundsForRange):
(AccessibilityUIElement::stringForRange):
(AccessibilityUIElement::attributedStringForRange):
(AccessibilityUIElement::uiElementForSearchPredicate):
(AccessibilityUIElement::attributesOfColumnHeaders):
(AccessibilityUIElement::attributesOfRowHeaders):
(AccessibilityUIElement::attributesOfColumns):
(AccessibilityUIElement::attributesOfRows):
(AccessibilityUIElement::attributesOfVisibleCells):
(AccessibilityUIElement::attributesOfHeader):
(AccessibilityUIElement::rowIndexRange):
(AccessibilityUIElement::columnIndexRange):
(AccessibilityUIElement::cellForColumnAndRow):
(AccessibilityUIElement::horizontalScrollbar):
(AccessibilityUIElement::verticalScrollbar):
(AccessibilityUIElement::pathDescription):
(AccessibilityUIElement::selectedTextRange):
(AccessibilityUIElement::url):
(AccessibilityUIElement::textMarkerRangeForElement):
(AccessibilityUIElement::textMarkerForIndex):
(AccessibilityUIElement::previousTextMarker):
(AccessibilityUIElement::nextTextMarker):
(AccessibilityUIElement::stringForTextMarkerRange):
(AccessibilityUIElement::textMarkerRangeForMarkers):
(AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(AccessibilityUIElement::endTextMarkerForBounds):
(AccessibilityUIElement::startTextMarkerForBounds):
(AccessibilityUIElement::textMarkerForPoint):
(AccessibilityUIElement::accessibilityElementForTextMarker):
(AccessibilityUIElement::startTextMarker):
(AccessibilityUIElement::endTextMarker):
(AccessibilityUIElement::supportedActions):
(AccessibilityUIElement::mathPostscriptsDescription):
(AccessibilityUIElement::mathPrescriptsDescription):

  • WebKitTestRunner/InjectedBundle/AccessibilityController.cpp:

(WTR::AccessibilityController::accessibleElementById):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::startTextMarker):
(WTR::AccessibilityUIElement::endTextMarker):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:

(WTR::findAccessibleObjectById):
(WTR::AccessibilityController::accessibleElementById):

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityUIElementMac.mm:

(WTR::AccessibilityUIElement::childAtIndex):
(WTR::AccessibilityUIElement::linkedUIElementAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToElementAtIndex):
(WTR::AccessibilityUIElement::disclosedRowAtIndex):
(WTR::AccessibilityUIElement::rowAtIndex):
(WTR::AccessibilityUIElement::selectedChildAtIndex):
(WTR::AccessibilityUIElement::selectedRowAtIndex):
(WTR::AccessibilityUIElement::titleUIElement):
(WTR::AccessibilityUIElement::parentElement):
(WTR::AccessibilityUIElement::disclosedByRow):
(WTR::AccessibilityUIElement::stringAttributeValue):
(WTR::AccessibilityUIElement::uiElementAttributeValue):
(WTR::AccessibilityUIElement::role):
(WTR::AccessibilityUIElement::subrole):
(WTR::AccessibilityUIElement::roleDescription):
(WTR::AccessibilityUIElement::title):
(WTR::AccessibilityUIElement::description):
(WTR::AccessibilityUIElement::orientation):
(WTR::AccessibilityUIElement::stringValue):
(WTR::AccessibilityUIElement::language):
(WTR::AccessibilityUIElement::helpText):
(WTR::AccessibilityUIElement::valueDescription):
(WTR::AccessibilityUIElement::classList):
(WTR::AccessibilityUIElement::speak):
(WTR::AccessibilityUIElement::ariaDropEffects):
(WTR::AccessibilityUIElement::rangeForLine):
(WTR::AccessibilityUIElement::rangeForPosition):
(WTR::AccessibilityUIElement::boundsForRange):
(WTR::AccessibilityUIElement::stringForRange):
(WTR::AccessibilityUIElement::attributedStringForRange):
(WTR::AccessibilityUIElement::uiElementForSearchPredicate):
(WTR::AccessibilityUIElement::attributesOfColumnHeaders):
(WTR::AccessibilityUIElement::attributesOfRowHeaders):
(WTR::AccessibilityUIElement::attributesOfColumns):
(WTR::AccessibilityUIElement::attributesOfRows):
(WTR::AccessibilityUIElement::attributesOfVisibleCells):
(WTR::AccessibilityUIElement::attributesOfHeader):
(WTR::AccessibilityUIElement::rowIndexRange):
(WTR::AccessibilityUIElement::columnIndexRange):
(WTR::AccessibilityUIElement::cellForColumnAndRow):
(WTR::AccessibilityUIElement::horizontalScrollbar):
(WTR::AccessibilityUIElement::verticalScrollbar):
(WTR::AccessibilityUIElement::selectedTextRange):
(WTR::AccessibilityUIElement::url):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):
(WTR::AccessibilityUIElement::previousTextMarker):
(WTR::AccessibilityUIElement::nextTextMarker):
(WTR::AccessibilityUIElement::stringForTextMarkerRange):
(WTR::AccessibilityUIElement::textMarkerRangeForMarkers):
(WTR::AccessibilityUIElement::startTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForTextMarkerRange):
(WTR::AccessibilityUIElement::endTextMarkerForBounds):
(WTR::AccessibilityUIElement::startTextMarkerForBounds):
(WTR::AccessibilityUIElement::textMarkerForPoint):
(WTR::AccessibilityUIElement::accessibilityElementForTextMarker):
(WTR::AccessibilityUIElement::textMarkerForIndex):
(WTR::AccessibilityUIElement::startTextMarker):
(WTR::AccessibilityUIElement::endTextMarker):
(WTR::AccessibilityUIElement::mathPostscriptsDescription):
(WTR::AccessibilityUIElement::mathPrescriptsDescription):
(WTR::AccessibilityUIElement::pathDescription):
(WTR::AccessibilityUIElement::supportedActions):

8:06 AM Changeset in webkit [158673] by commit-queue@webkit.org
  • 1 edit
    1 delete in trunk/Source/WebCore

Delete maketokenizer.
https://bugs.webkit.org/show_bug.cgi?id=115155

Patch by Éva Balázsfalvi <balazsfalvi.eva@stud.u-szeged.hu> on 2013-11-05
Reviewed by Zoltan Herczeg.

This script was used to generate the old flex based CSS tokenizer. It
was replaced by a custom tokenizer in r106217 but the script wasn't
removed. Since there is no mention of it in the original bug nor any
reference to maketokenizer in our build files, it's probably an
oversight.

Merge from blink:
https://chromium.googlesource.com/chromium/blink/+/2a1c8aaf867f707ccdcd8893446e907e2aa2e1c2

  • css/maketokenizer: Removed.
7:34 AM Changeset in webkit [158672] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r158315): Fix register mixup in JIT::compileOpCall.
https://bugs.webkit.org/show_bug.cgi?id=123799

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-05
Reviewed by Mark Lam.

Changeset r158315 is crashing architectures where JSInterfaceJIT::regT3 is
different from GPRInfo::regT3. This is the case for MIPS architecture.

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileOpCall):

7:33 AM Changeset in webkit [158671] by commit-queue@webkit.org
  • 2 edits in trunk

Remove leftover Qt related things from WebKitMacros.cmake
https://bugs.webkit.org/show_bug.cgi?id=123798

Patch by Éva Balázsfalvi <balazsfalvi.eva@stud.u-szeged.hu> on 2013-11-05
Reviewed by Anders Carlsson.

  • Source/cmake/WebKitMacros.cmake:
7:32 AM Changeset in webkit [158670] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

[mips] Fix build for MIPS platforms.
https://bugs.webkit.org/show_bug.cgi?id=123796

Patch by Julien Brianceau <jbriance@cisco.com> on 2013-11-05
Reviewed by Michael Saboff.

  • assembler/LinkBuffer.cpp:

(JSC::LinkBuffer::linkCode): Add specific MIPS call to relocateJumps.

  • assembler/MIPSAssembler.h: Remove executableCopy (because of r157690) and set relocateJumps function public.

(JSC::MIPSAssembler::firstRegister):
(JSC::MIPSAssembler::lastRegister):
(JSC::MIPSAssembler::firstFPRegister):
(JSC::MIPSAssembler::lastFPRegister):
(JSC::MIPSAssembler::buffer): Needed since r157690.

  • assembler/MacroAssemblerMIPS.h: Add framePointerRegister.

(JSC::MacroAssemblerMIPS::revertJumpReplacementToPatchableBranchPtrWithPatch): Remove unused parameter warning.

7:31 AM Changeset in webkit [158669] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove leftover Qt related things from the flakiness_dashboard
https://bugs.webkit.org/show_bug.cgi?id=123800

Patch by László Langó <laszlo.lango@frontendart.com> on 2013-11-05
Reviewed by Anders Carlsson.

  • TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:

(test):

7:30 AM Changeset in webkit [158668] by mihnea@adobe.com
  • 1 edit
    140 moves
    1 add in trunk/LayoutTests

[CSS Regions] Move cssom related tests into fast/regions/cssom
https://bugs.webkit.org/show_bug.cgi?id=123705

Reviewed by Sam Weinig.

Move tests related to http://dev.w3.org/csswg/css-regions/#cssom_view_and_css_regions into their own folder and adjust paths for resources used in tests.
They test the same functionality: CSSRegions and CSSOM-view.

  • fast/regions/cssom/element-region-overset-state-expected.txt: Renamed from LayoutTests/fast/regions/element-region-overset-state-expected.txt.
  • fast/regions/cssom/element-region-overset-state-negative-letter-spacing-expected.txt: Renamed from LayoutTests/fast/regions/element-region-overset-state-negative-letter-spacing-expected.txt.
  • fast/regions/cssom/element-region-overset-state-negative-letter-spacing.html: Renamed from LayoutTests/fast/regions/element-region-overset-state-negative-letter-spacing.html.
  • fast/regions/cssom/element-region-overset-state-vertical-rl-expected.txt: Renamed from LayoutTests/fast/regions/element-region-overset-state-vertical-rl-expected.txt.
  • fast/regions/cssom/element-region-overset-state-vertical-rl-negative-letter-spacing-expected.txt: Renamed from LayoutTests/fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing-expected.txt.
  • fast/regions/cssom/element-region-overset-state-vertical-rl-negative-letter-spacing.html: Renamed from LayoutTests/fast/regions/element-region-overset-state-vertical-rl-negative-letter-spacing.html.
  • fast/regions/cssom/element-region-overset-state-vertical-rl.html: Renamed from LayoutTests/fast/regions/element-region-overset-state-vertical-rl.html.
  • fast/regions/cssom/element-region-overset-state.html: Renamed from LayoutTests/fast/regions/element-region-overset-state.html.
  • fast/regions/cssom/flowed-content-bounding-client-rect-expected.txt: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect-expected.txt.
  • fast/regions/cssom/flowed-content-bounding-client-rect-horizontal-bt-expected.txt: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect-horizontal-bt-expected.txt.
  • fast/regions/cssom/flowed-content-bounding-client-rect-horizontal-bt.html: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect-horizontal-bt.html.
  • fast/regions/cssom/flowed-content-bounding-client-rect-vertical-expected.txt: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect-vertical-expected.txt.
  • fast/regions/cssom/flowed-content-bounding-client-rect-vertical-rl-expected.txt: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect-vertical-rl-expected.txt.
  • fast/regions/cssom/flowed-content-bounding-client-rect-vertical-rl.html: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect-vertical-rl.html.
  • fast/regions/cssom/flowed-content-bounding-client-rect-vertical.html: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect-vertical.html.
  • fast/regions/cssom/flowed-content-bounding-client-rect.html: Renamed from LayoutTests/fast/regions/flowed-content-bounding-client-rect.html.
  • fast/regions/cssom/flowed-content-transform-bounding-client-rect-expected.txt: Renamed from LayoutTests/fast/regions/flowed-content-transform-bounding-client-rect-expected.txt.
  • fast/regions/cssom/flowed-content-transform-bounding-client-rect.html: Renamed from LayoutTests/fast/regions/flowed-content-transform-bounding-client-rect.html.
  • fast/regions/cssom/flowed-inline-content-bounding-client-rect-expected.txt: Renamed from LayoutTests/fast/regions/flowed-inline-content-bounding-client-rect-expected.txt.
  • fast/regions/cssom/flowed-inline-content-bounding-client-rect.html: Renamed from LayoutTests/fast/regions/flowed-inline-content-bounding-client-rect.html.
  • fast/regions/cssom/get-region-flow-ranges-absolute-pos-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-absolute-pos-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-absolute-pos.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-absolute-pos.html.
  • fast/regions/cssom/get-region-flow-ranges-content-nodes-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-content-nodes-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-content-nodes.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-content-nodes.html.
  • fast/regions/cssom/get-region-flow-ranges-display-none-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-display-none-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-display-none.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-display-none.html.
  • fast/regions/cssom/get-region-flow-ranges-empty-regions-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-empty-regions-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-empty-regions.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-empty-regions.html.
  • fast/regions/cssom/get-region-flow-ranges-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-fixed-pos-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-fixed-pos-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-fixed-pos.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-fixed-pos.html.
  • fast/regions/cssom/get-region-flow-ranges-horiz-bt-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-horiz-bt-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-horiz-bt.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-horiz-bt.html.
  • fast/regions/cssom/get-region-flow-ranges-inline-only-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-inline-only-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-inline-only.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-inline-only.html.
  • fast/regions/cssom/get-region-flow-ranges-inline-svg-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-inline-svg-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-inline-svg.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-inline-svg.html.
  • fast/regions/cssom/get-region-flow-ranges-text-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-text-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-text-vert-lr-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-text-vert-lr-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-text-vert-lr.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-text-vert-lr.html.
  • fast/regions/cssom/get-region-flow-ranges-text.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-text.html.
  • fast/regions/cssom/get-region-flow-ranges-vert-lr-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-vert-lr-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-vert-lr.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-vert-lr.html.
  • fast/regions/cssom/get-region-flow-ranges-vert-rl-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-vert-rl-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-vert-rl.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-vert-rl.html.
  • fast/regions/cssom/get-region-flow-ranges-writing-modes-rl-rb-lr-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-writing-modes-rl-rb-lr.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-writing-modes-rl-rb-lr.html.
  • fast/regions/cssom/get-region-flow-ranges-writing-modes-tb-rl-lr-expected.txt: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr-expected.txt.
  • fast/regions/cssom/get-region-flow-ranges-writing-modes-tb-rl-lr.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges-writing-modes-tb-rl-lr.html.
  • fast/regions/cssom/get-region-flow-ranges.html: Renamed from LayoutTests/fast/regions/get-region-flow-ranges.html.
  • fast/regions/cssom/get-regions-by-content-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-expected.txt.
  • fast/regions/cssom/get-regions-by-content-horiz-bt-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-horiz-bt-expected.txt.
  • fast/regions/cssom/get-regions-by-content-horiz-bt.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-horiz-bt.html.
  • fast/regions/cssom/get-regions-by-content-horiz-tb-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-horiz-tb-expected.txt.
  • fast/regions/cssom/get-regions-by-content-horiz-tb.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-horiz-tb.html.
  • fast/regions/cssom/get-regions-by-content-pseudo-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-pseudo-expected.txt.
  • fast/regions/cssom/get-regions-by-content-pseudo.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-pseudo.html.
  • fast/regions/cssom/get-regions-by-content-vert-lr-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-vert-lr-expected.txt.
  • fast/regions/cssom/get-regions-by-content-vert-lr.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-vert-lr.html.
  • fast/regions/cssom/get-regions-by-content-vert-rl-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content-vert-rl-expected.txt.
  • fast/regions/cssom/get-regions-by-content-vert-rl.html: Renamed from LayoutTests/fast/regions/get-regions-by-content-vert-rl.html.
  • fast/regions/cssom/get-regions-by-content.html: Renamed from LayoutTests/fast/regions/get-regions-by-content.html.
  • fast/regions/cssom/get-regions-by-content2-expected.txt: Renamed from LayoutTests/fast/regions/get-regions-by-content2-expected.txt.
  • fast/regions/cssom/get-regions-by-content2.html: Renamed from LayoutTests/fast/regions/get-regions-by-content2.html.
  • fast/regions/cssom/offsetLeft-offsetTop-in-multiple-regions-expected.txt: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-multiple-regions-expected.txt.
  • fast/regions/cssom/offsetLeft-offsetTop-in-multiple-regions.html: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-multiple-regions.html.
  • fast/regions/cssom/offsetLeft-offsetTop-in-region-absolute-sticky-fixed-expected.txt: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-region-absolute-sticky-fixed-expected.txt.
  • fast/regions/cssom/offsetLeft-offsetTop-in-region-absolute-sticky-fixed.html: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-region-absolute-sticky-fixed.html.
  • fast/regions/cssom/offsetLeft-offsetTop-in-region-float-expected.txt: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-region-float-expected.txt.
  • fast/regions/cssom/offsetLeft-offsetTop-in-region-float-vert-rl-expected.txt: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-region-float-vert-rl-expected.txt.
  • fast/regions/cssom/offsetLeft-offsetTop-in-region-float-vert-rl.html: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-region-float-vert-rl.html.
  • fast/regions/cssom/offsetLeft-offsetTop-in-region-float.html: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-in-region-float.html.
  • fast/regions/cssom/offsetLeft-offsetTop-inlines-region-in-element-expected.txt: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-inlines-region-in-element-expected.txt.
  • fast/regions/cssom/offsetLeft-offsetTop-inlines-region-in-element.html: Renamed from LayoutTests/fast/regions/offsetLeft-offsetTop-inlines-region-in-element.html.
  • fast/regions/cssom/offsetParent-body-in-flow-thread-expected.txt: Renamed from LayoutTests/fast/regions/offsetParent-body-in-flow-thread-expected.txt.
  • fast/regions/cssom/offsetParent-body-in-flow-thread.html: Renamed from LayoutTests/fast/regions/offsetParent-body-in-flow-thread.html.
  • fast/regions/cssom/offsetParent-in-flow-thread-expected.txt: Renamed from LayoutTests/fast/regions/offsetParent-in-flow-thread-expected.txt.
  • fast/regions/cssom/offsetParent-in-flow-thread.html: Renamed from LayoutTests/fast/regions/offsetParent-in-flow-thread.html.
  • fast/regions/cssom/overset-break-expected.txt: Renamed from LayoutTests/fast/regions/overset-break-expected.txt.
  • fast/regions/cssom/overset-break-nested-expected.txt: Renamed from LayoutTests/fast/regions/overset-break-nested-expected.txt.
  • fast/regions/cssom/overset-break-nested.html: Renamed from LayoutTests/fast/regions/overset-break-nested.html.
  • fast/regions/cssom/overset-break-with-sibling-expected.txt: Renamed from LayoutTests/fast/regions/overset-break-with-sibling-expected.txt.
  • fast/regions/cssom/overset-break-with-sibling.html: Renamed from LayoutTests/fast/regions/overset-break-with-sibling.html.
  • fast/regions/cssom/overset-break.html: Renamed from LayoutTests/fast/regions/overset-break.html.
  • fast/regions/cssom/region-range-for-box-crash-expected.txt: Renamed from LayoutTests/fast/regions/region-range-for-box-crash-expected.txt.
  • fast/regions/cssom/region-range-for-box-crash.html: Renamed from LayoutTests/fast/regions/region-range-for-box-crash.html.
  • fast/regions/cssom/webkit-named-flow-collection-crash-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-crash-expected.txt.
  • fast/regions/cssom/webkit-named-flow-collection-crash.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-crash.html.
  • fast/regions/cssom/webkit-named-flow-collection-empty-getters-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-empty-getters-expected.txt.
  • fast/regions/cssom/webkit-named-flow-collection-empty-getters.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-empty-getters.html.
  • fast/regions/cssom/webkit-named-flow-collection-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection-expected.txt.
  • fast/regions/cssom/webkit-named-flow-collection.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-collection.html.
  • fast/regions/cssom/webkit-named-flow-event-add-to-flow-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-add-to-flow-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-add-to-flow.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-add-to-flow.html.
  • fast/regions/cssom/webkit-named-flow-event-auto-height-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-auto-height-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-auto-height.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-auto-height.html.
  • fast/regions/cssom/webkit-named-flow-event-crash-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-crash-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-crash.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-crash.html.
  • fast/regions/cssom/webkit-named-flow-event-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-no-regions-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-no-regions-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-no-regions.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-no-regions.html.
  • fast/regions/cssom/webkit-named-flow-event-region-in-flexbox-no-overset-change-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-region-in-flexbox-no-overset-change.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-no-overset-change.html.
  • fast/regions/cssom/webkit-named-flow-event-region-in-flexbox-overset-change-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-region-in-flexbox-overset-change.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-region-in-flexbox-overset-change.html.
  • fast/regions/cssom/webkit-named-flow-event-remove-from-dom-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-remove-from-dom-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-remove-from-dom.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-remove-from-dom.html.
  • fast/regions/cssom/webkit-named-flow-event-remove-from-flow-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-remove-from-flow-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-remove-from-flow.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-remove-from-flow.html.
  • fast/regions/cssom/webkit-named-flow-event-target-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-target-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-target.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-target.html.
  • fast/regions/cssom/webkit-named-flow-event-to-null-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-to-null-expected.txt.
  • fast/regions/cssom/webkit-named-flow-event-to-null.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event-to-null.html.
  • fast/regions/cssom/webkit-named-flow-event.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-event.html.
  • fast/regions/cssom/webkit-named-flow-existing-flow-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-existing-flow-expected.txt.
  • fast/regions/cssom/webkit-named-flow-existing-flow.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-existing-flow.html.
  • fast/regions/cssom/webkit-named-flow-first-empty-region-index-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-first-empty-region-index-expected.txt.
  • fast/regions/cssom/webkit-named-flow-first-empty-region-index.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-first-empty-region-index.html.
  • fast/regions/cssom/webkit-named-flow-flow-added-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-flow-added-expected.txt.
  • fast/regions/cssom/webkit-named-flow-flow-added.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-flow-added.html.
  • fast/regions/cssom/webkit-named-flow-get-content-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-get-content-expected.txt.
  • fast/regions/cssom/webkit-named-flow-get-content.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-get-content.html.
  • fast/regions/cssom/webkit-named-flow-get-regions-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-get-regions-expected.txt.
  • fast/regions/cssom/webkit-named-flow-get-regions-pseudo-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-get-regions-pseudo-expected.txt.
  • fast/regions/cssom/webkit-named-flow-get-regions-pseudo.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-get-regions-pseudo.html.
  • fast/regions/cssom/webkit-named-flow-get-regions.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-get-regions.html.
  • fast/regions/cssom/webkit-named-flow-invalid-name-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-invalid-name-expected.txt.
  • fast/regions/cssom/webkit-named-flow-invalid-name.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-invalid-name.html.
  • fast/regions/cssom/webkit-named-flow-modified-flow-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-modified-flow-expected.txt.
  • fast/regions/cssom/webkit-named-flow-modified-flow.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-modified-flow.html.
  • fast/regions/cssom/webkit-named-flow-name-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-name-expected.txt.
  • fast/regions/cssom/webkit-named-flow-name.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-name.html.
  • fast/regions/cssom/webkit-named-flow-non-existing-flow-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-non-existing-flow-expected.txt.
  • fast/regions/cssom/webkit-named-flow-non-existing-flow.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-non-existing-flow.html.
  • fast/regions/cssom/webkit-named-flow-overset-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-overset-expected.txt.
  • fast/regions/cssom/webkit-named-flow-overset.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-overset.html.
  • fast/regions/cssom/webkit-named-flow-removed-flow-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-removed-flow-expected.txt.
  • fast/regions/cssom/webkit-named-flow-removed-flow.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-removed-flow.html.
  • fast/regions/cssom/webkit-named-flow-same-object-expected.txt: Renamed from LayoutTests/fast/regions/webkit-named-flow-same-object-expected.txt.
  • fast/regions/cssom/webkit-named-flow-same-object.html: Renamed from LayoutTests/fast/regions/webkit-named-flow-same-object.html.
7:25 AM Changeset in webkit [158667] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Unbreaking GCC builds.

  • html/HTMLCollection.cpp:

(WebCore::isMatchingElement): This inline function is not a template anymore.

6:50 AM Changeset in webkit [158666] by mario@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening. Two tests pass after r158575 and r15856.

  • platform/gtk/TestExpectations: Removed passing tests.
6:35 AM Changeset in webkit [158665] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Make it compile.

  • dom/LiveNodeList.h:

(WebCore::LiveNodeList::LiveNodeList):
(WebCore::LiveNodeList::~LiveNodeList):

  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::adoptDocument):

  • html/HTMLCollection.cpp:

(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::~HTMLCollection):

5:40 AM Changeset in webkit [158664] by commit-queue@webkit.org
  • 5 edits in trunk

[EFL] accessibility/svg-group-element-with-title.html is failing
https://bugs.webkit.org/show_bug.cgi?id=114151

Patch by Robert Plociennik <r.plociennik@samsung.com> on 2013-11-05
Reviewed by Mario Sanchez Prada.

Tools:

atk_component_ref_accessible_at_point(), utilized in
AccessibilityUIElement::elementAtPoint(), is expected to 'get a reference to the
accessible child, if one exists, at the coordinate point specified' and not
explicitly return self in case of lack of child elements. This contradicts with
expected behavior of elementAtPoint(). Therefore, elementAtPoint() is
changed to return self regardless of coordinates specified, provided no child
element could be retrieved, effectively mimicing the behaviour of equivalent
Mac implementation in accessibilityHitTest().

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::elementAtPoint): Fixed.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::elementAtPoint): Fixed.

LayoutTests:

Removed failure expectation.

  • platform/efl/TestExpectations: The test is no longer failing.
5:20 AM Changeset in webkit [158663] by Antti Koivisto
  • 25 edits in trunk/Source/WebCore

HTMLCollection should not be NodeList
https://bugs.webkit.org/show_bug.cgi?id=123794

Reviewed by Andreas Kling.

HTMLCollection and NodeList are unrelated types in DOM yet our HTMLCollection inherits NodeList
for code sharing reasons. While some code does get shared the types are sufficiently different
that this results in lots of unnecessary branches, complexity and general awkwardness. Code sharing
can be better achieved by means other than inheritance.

This patch splits HTMLCollection from NodeList by copy-pasting and eliminating resulting redundancies.
Sharing comes later.

  • dom/Attr.cpp:

(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):

  • dom/ClassNodeList.cpp:

(WebCore::ClassNodeList::~ClassNodeList):

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::childrenChanged):
(WebCore::ContainerNode::getElementsByTagName):
(WebCore::ContainerNode::getElementsByName):
(WebCore::ContainerNode::getElementsByClassName):
(WebCore::ContainerNode::radioNodeList):

  • dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::~Document):
(WebCore::Document::registerNodeList):
(WebCore::Document::unregisterNodeList):
(WebCore::Document::registerCollection):
(WebCore::Document::unregisterCollection):
(WebCore::Document::ensureCachedCollection):

Add separate functions and map for registering HTMLCollections.

(WebCore::Document::all):
(WebCore::Document::windowNamedItems):
(WebCore::Document::documentNamedItems):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::attributeChanged):
(WebCore::Element::ensureCachedHTMLCollection):
(WebCore::Element::cachedHTMLCollection):

  • dom/LiveNodeList.cpp:

(WebCore::LiveNodeList::rootNode):
(WebCore::isMatchingElement):
(WebCore::LiveNodeList::iterateForPreviousElement):
(WebCore::LiveNodeList::itemBefore):
(WebCore::firstMatchingElement):
(WebCore::nextMatchingElement):
(WebCore::traverseMatchingElementsForwardToOffset):
(WebCore::LiveNodeList::traverseLiveNodeListFirstElement):
(WebCore::LiveNodeList::traverseLiveNodeListForwardToOffset):
(WebCore::LiveNodeList::isLastItemCloserThanLastOrCachedItem):
(WebCore::LiveNodeList::isFirstItemCloserThanCachedItem):
(WebCore::LiveNodeList::length):
(WebCore::LiveNodeList::item):
(WebCore::LiveNodeList::elementBeforeOrAfterCachedElement):

This code used to live in HTMLCollection.cpp. Copy-paste here and remove all branches not needed for NodeLists.

(WebCore::LiveNodeList::invalidateCache):

NodeLists have no name caches.

  • dom/LiveNodeList.h:

(WebCore::LiveNodeList::LiveNodeList):
(WebCore::LiveNodeList::~LiveNodeList):
(WebCore::LiveNodeList::isRootedAtDocument):
(WebCore::LiveNodeList::type):
(WebCore::LiveNodeList::invalidateCache):
(WebCore::LiveNodeList::setCachedElement):

Merge LiveNodeListBase and LiveNodeList.
Remove fields and code supporting HTMLCollection.

(WebCore::shouldInvalidateTypeOnAttributeChange):

Move to global scope. This function is used both HTMLCollections and LiveNodeLists.

  • dom/NameNodeList.cpp:

(WebCore::NameNodeList::~NameNodeList):

  • dom/NameNodeList.h:

(WebCore::NameNodeList::create):

  • dom/Node.cpp:

(WebCore::shouldInvalidateNodeListCachesForAttr):
(WebCore::Document::shouldInvalidateNodeListAndCollectionCaches):
(WebCore::Document::invalidateNodeListAndCollectionCaches):
(WebCore::Node::invalidateNodeListAndCollectionCachesInAncestors):
(WebCore::NodeListsNodeData::invalidateCaches):

  • dom/Node.h:
  • dom/NodeRareData.h:

(WebCore::NodeListsNodeData::addCacheWithAtomicName):
(WebCore::NodeListsNodeData::addCacheWithName):
(WebCore::NodeListsNodeData::addCacheWithQualifiedName):
(WebCore::NodeListsNodeData::addCachedCollection):
(WebCore::NodeListsNodeData::cachedCollection):
(WebCore::NodeListsNodeData::removeCacheWithAtomicName):
(WebCore::NodeListsNodeData::removeCacheWithName):
(WebCore::NodeListsNodeData::removeCachedCollection):
(WebCore::NodeListsNodeData::isEmpty):
(WebCore::NodeListsNodeData::adoptDocument):
(WebCore::NodeListsNodeData::namedCollectionKey):
(WebCore::NodeListsNodeData::namedNodeListKey):
(WebCore::NodeListsNodeData::deleteThisAndUpdateNodeRareDataIfAboutToRemoveLastList):

Add separate cache for HTMLCollections.

  • dom/TagNodeList.cpp:

(WebCore::TagNodeList::TagNodeList):
(WebCore::TagNodeList::~TagNodeList):

  • dom/TagNodeList.h:

(WebCore::TagNodeList::create):
(WebCore::HTMLTagNodeList::create):

  • html/CollectionType.h:


Remove NodeList types.

  • html/HTMLCollection.cpp:

(WebCore::shouldOnlyIncludeDirectChildren):
(WebCore::rootTypeFromCollectionType):
(WebCore::invalidationTypeExcludingIdAndNameAttributes):
(WebCore::HTMLCollection::HTMLCollection):
(WebCore::HTMLCollection::~HTMLCollection):
(WebCore::HTMLCollection::rootNode):
(WebCore::isMatchingElement):
(WebCore::HTMLCollection::iterateForPreviousElement):
(WebCore::HTMLCollection::itemBefore):
(WebCore::firstMatchingElement):
(WebCore::nextMatchingElement):
(WebCore::traverseMatchingElementsForwardToOffset):
(WebCore::HTMLCollection::isLastItemCloserThanLastOrCachedItem):
(WebCore::HTMLCollection::isFirstItemCloserThanCachedItem):
(WebCore::HTMLCollection::setCachedElement):
(WebCore::HTMLCollection::length):
(WebCore::HTMLCollection::item):
(WebCore::HTMLCollection::elementBeforeOrAfterCachedElement):
(WebCore::HTMLCollection::traverseFirstElement):
(WebCore::HTMLCollection::traverseNextElement):
(WebCore::HTMLCollection::traverseForwardToOffset):
(WebCore::HTMLCollection::invalidateCache):
(WebCore::HTMLCollection::invalidateIdNameCacheMaps):
(WebCore::HTMLCollection::namedItem):

Remove NodeList specific branches and functions.
LiveNodeListBase functions are now HTMLCollection functions.

  • html/HTMLCollection.h:

(WebCore::HTMLCollection::isRootedAtDocument):
(WebCore::HTMLCollection::invalidationType):
(WebCore::HTMLCollection::type):
(WebCore::HTMLCollection::ownerNode):
(WebCore::HTMLCollection::invalidateCache):
(WebCore::HTMLCollection::document):
(WebCore::HTMLCollection::overridesItemAfter):
(WebCore::HTMLCollection::isElementCacheValid):
(WebCore::HTMLCollection::cachedElement):
(WebCore::HTMLCollection::cachedElementOffset):
(WebCore::HTMLCollection::isLengthCacheValid):
(WebCore::HTMLCollection::cachedLength):
(WebCore::HTMLCollection::setLengthCache):
(WebCore::HTMLCollection::setCachedElement):
(WebCore::HTMLCollection::isItemRefElementsCacheValid):
(WebCore::HTMLCollection::setItemRefElementsCacheValid):
(WebCore::HTMLCollection::rootType):
(WebCore::HTMLCollection::hasNameCache):
(WebCore::HTMLCollection::setHasNameCache):

Copy-paste functions and fields from former LiveNodeListBase.

  • html/HTMLNameCollection.cpp:

(WebCore::HTMLNameCollection::~HTMLNameCollection):

  • html/LabelableElement.cpp:

(WebCore::LabelableElement::labels):

  • html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::~LabelsNodeList):

  • html/LabelsNodeList.h:
  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::~RadioNodeList):

  • html/RadioNodeList.h:

(WebCore::RadioNodeList::create):

5:02 AM Changeset in webkit [158662] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[GTK] Add stubs for missing symbols in dom bindings
https://bugs.webkit.org/show_bug.cgi?id=123663

Patch by Emilio Pozuelo Monfort <pochu27@gmail.com> on 2013-11-05
Reviewed by Carlos Garcia Campos.

  • bindings/gobject/WebKitDOMCustom.cpp:

(webkit_dom_html_head_element_get_profile):
(webkit_dom_html_head_element_set_profile):
(webkit_dom_processing_instruction_get_data):
(webkit_dom_processing_instruction_set_data):

  • bindings/gobject/WebKitDOMCustom.h:
  • bindings/gobject/WebKitDOMCustom.symbols:
2:48 AM Changeset in webkit [158661] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Main thread tasks in ThreadableBlobRegistry should use std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=122946

Reviewed by Darin Adler.

The new BlobRegistryContext objects don't have to be adopted into OwnPtr and then have OwnPtr's leaked pointer
passed into the WTF::callOnMainThread call - the pointer to the new heap-allocated object is passed in directly,
with the object ending up being managed by std::unique_ptr in the designated main thread task.

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore::registerBlobURLTask):
(WebCore::ThreadableBlobRegistry::registerBlobURL):
(WebCore::registerBlobURLFromTask):
(WebCore::unregisterBlobURLTask):
(WebCore::ThreadableBlobRegistry::unregisterBlobURL):

2:17 AM Changeset in webkit [158660] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Update a test expected result.
https://bugs.webkit.org/show_bug.cgi?id=123792

Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2013-11-05
Reviewed by Gyuyoung Kim.

Need to update some length properties in this expected file.
The test expected reseult is mismatched with return-values of eval() method in LayoutTests/resources/js-test-pre.js.

  • platform/efl/js/dom/constructor-length-expected.txt:
1:39 AM Changeset in webkit [158659] by gyuyoung.kim@samsung.com
  • 5 edits in trunk

[CSS] Enable css-image-orientation on EFL and GTK ports.
https://bugs.webkit.org/show_bug.cgi?id=123698

Reviewed by Beth Dakin.

Source/WebCore:

r157909 added wrong early return for css-image-orientation. It causes about 20 regressions in layout test
when enabling css-image-orientation. This fixes those wrong implementation as well as enables it on EFL
and GTK ports by default.

Test: fast/css/image-orientation/image-orientation.html

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::imageSizeForRenderer):

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::updateSize):

Tools:

r157909 added wrong early return for css-image-orientation. It causes about 20 regressions in layout test
when enabling css-image-orientaiton. This fixes those wrong implementation as well as enables it on EFL
and GTK ports by default.

  • Scripts/webkitperl/FeatureList.pm:
1:35 AM Changeset in webkit [158658] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] accessibility/tabindex-elements-are-accessible.html is failing after r158195
https://bugs.webkit.org/show_bug.cgi?id=123741

Unreviewed EFL gardening.

Patch by Artur Moryc <a.moryc@samsung.com> on 2013-11-05

  • platform/efl/TestExpectations: adding failing test
1:29 AM Changeset in webkit [158657] by akling@apple.com
  • 8 edits in trunk/Source/WebCore

RenderEmbeddedObject shouldn't know about fallback content.
<https://webkit.org/b/123781>

Stop caching the presence of fallback (DOM) content in a flag on
RenderEmbeddedObject and have SubframeLoader fetch it directly from
HTMLObjectElement instead.

Also made SubframeLoader::requestObject() take the owner element
by reference since we don't support owner-less embedded objects.

Reviewed by Antti Koivisto.

1:08 AM Changeset in webkit [158656] by calvaris@igalia.com
  • 17 edits
    13 deletes in trunk/Source

[GStreamer] Remove NATIVE_FULLSCREEN_VIDEO support
https://bugs.webkit.org/show_bug.cgi?id=123437

Reviewed by Philippe Normand.

Source/WebCore:

Removed some dead code as no GStreamer port is using the native
fullscreen video support.

  • GNUmakefile.list.am:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake: Removed compilation of deleted files.
  • platform/graphics/MediaPlayer.h: Removed structures related to

GStreamer and NATIVE_FULLSCREEN_VIDEO.

  • platform/graphics/gstreamer/FullscreenVideoControllerGStreamer.cpp: Removed.
  • platform/graphics/gstreamer/FullscreenVideoControllerGStreamer.h: Removed.
  • platform/graphics/gstreamer/GStreamerGWorld.cpp: Removed.
  • platform/graphics/gstreamer/GStreamerGWorld.h: Removed.
  • platform/graphics/gstreamer/ImageGStreamerCairo.cpp: Removed

gst/video/video.h include.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::platformMedia):
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

Removed code related to GStreamer and NATIVE_FULLSCREEN_VIDEO.

  • platform/graphics/gstreamer/PlatformVideoWindow.h: Removed.
  • platform/graphics/gstreamer/PlatformVideoWindowEfl.cpp: Removed.
  • platform/graphics/gstreamer/PlatformVideoWindowGtk.cpp: Removed.
  • platform/graphics/gstreamer/PlatformVideoWindowMac.mm: Removed.
  • platform/graphics/gstreamer/PlatformVideoWindowNix.cpp: Removed.
  • platform/graphics/gstreamer/PlatformVideoWindowPrivate.h: Removed.
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

(webkitVideoSinkRender):
(webkitVideoSinkNew):

  • platform/graphics/gstreamer/VideoSinkGStreamer.h: Removed code

related to GStreamer and NATIVE_FULLSCREEN_VIDEO.

  • platform/graphics/gtk/FullscreenVideoControllerGtk.cpp: Removed.
  • platform/graphics/gtk/FullscreenVideoControllerGtk.h: Removed.

Source/WebCore/platform/gtk/po:

  • POTFILES.in: Removed FullscreenVideoControllerGtk.cpp.
  • gl.po: Removed appearances of strings of

FullscreenVideoControllerGtk.cpp.

Source/WebKit/efl:

Removed some dead code as no GStreamer port is using the native
fullscreen video support.

  • WebCoreSupport/FullscreenVideoControllerEfl.h: Removed.

Source/WebKit/gtk:

Removed some dead code as no GStreamer port is using the native
fullscreen video support.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::ChromeClient::enterFullScreenForElement):
(WebKit::ChromeClient::exitFullScreenForElement):

  • WebCoreSupport/ChromeClientGtk.h: Removed code related to

GStreamer and NATIVE_FULLSCREEN_VIDEO.

12:53 AM Changeset in webkit [158655] by akling@apple.com
  • 8 edits in trunk/Source/WebCore

Remove RenderWidget::viewCleared().
<https://webkit.org/b/123777>

This was some ancient hand-waving code from the KHTML era.

It was obviously confused (e.g RenderEmbeddedObject trying to handle
iframe owners, even though that setup is impossible.)

Reviewed by Anders Carlsson.

Note: See TracTimeline for information about the timeline view.