Timeline



Nov 12, 2013:

11:24 PM Changeset in webkit [159179] by ap@apple.com
  • 10 edits in trunk

Disable WebCrypto on Mountain Lion
​https://bugs.webkit.org/show_bug.cgi?id=124261

Rubber-stamped by Sam Weinig.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

LayoutTests:

  • platform/mac/TestExpectations:
10:52 PM Changeset in webkit [159178] by zandobersek@gmail.com
  • 10 edits in trunk/Source/WebCore

Manage XMLHttpRequestUpload, XSLImportRule, XMLErrors, XML pending callback classes through std::unique_ptr
​https://bugs.webkit.org/show_bug.cgi?id=124224

Reviewed by Anders Carlsson.

Use std::unique_ptr to handle objects of various XML classes that were previously managed by OwnPtr.
This removes usage of OwnPtr and PassOwnPtr under Source/WebCore/xml/.

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::upload):

  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequestUpload.h:
  • xml/XSLImportRule.h:
  • xml/XSLStyleSheet.h:
  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::loadChildSheet):

  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::handleError):

  • xml/parser/XMLDocumentParser.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::PendingCallbacks::PendingCallbacks):
(WebCore::PendingCallbacks::appendStartElementNSCallback):
(WebCore::PendingCallbacks::appendEndElementNSCallback):
(WebCore::PendingCallbacks::appendCharactersCallback):
(WebCore::PendingCallbacks::appendProcessingInstructionCallback):
(WebCore::PendingCallbacks::appendCDATABlockCallback):
(WebCore::PendingCallbacks::appendCommentCallback):
(WebCore::PendingCallbacks::appendInternalSubsetCallback):
(WebCore::PendingCallbacks::appendErrorCallback):
(WebCore::PendingCallbacks::callAndRemoveFirstCallback):
(WebCore::XMLDocumentParser::XMLDocumentParser):

7:59 PM Changeset in webkit [159177] by beidson@apple.com
  • 13 edits in trunk/Source/WebCore

Move basic IDBBackingStoreTransaction operations to IDBServerConnection
​https://bugs.webkit.org/show_bug.cgi?id=124244

Reviewed by Tim Horton (and unofficially Anders Carlsson).

This patch:

  • Makes IDBBackingStore the owner of an IDBBackingStoreTransaction.
  • Adds the integer transaction ID to IDBBackingStoreTransaction for reference.
  • Removes IDBTransactionBackend’s reliance on IDBBackingStoreTransaction by moving necessary methods to IDBServerConnection.
  • Renames the IDBTransactionBackend::backingStoreTransaction() accessor to deprecatedBackingStoreTransaction to make it clear it’s on the way out.
  • Modules/indexeddb/IDBBackingStoreInterface.h:
  • Modules/indexeddb/IDBDatabaseBackend.cpp:

(WebCore::IDBDatabaseBackend::setIndexKeys):

  • Modules/indexeddb/IDBServerConnection.h:
  • Modules/indexeddb/IDBTransactionBackend.cpp:

(WebCore::IDBTransactionBackend::IDBTransactionBackend):
(WebCore::IDBTransactionBackend::~IDBTransactionBackend):
(WebCore::IDBTransactionBackend::deprecatedBackingStoreTransaction):
(WebCore::IDBTransactionBackend::scheduleTask):
(WebCore::IDBTransactionBackend::abort):
(WebCore::IDBTransactionBackend::commit):
(WebCore::IDBTransactionBackend::taskTimerFired):

  • Modules/indexeddb/IDBTransactionBackend.h:
  • Modules/indexeddb/IDBTransactionBackendOperations.cpp:

(WebCore::CreateObjectStoreOperation::perform):
(WebCore::CreateIndexOperation::perform):
(WebCore::DeleteIndexOperation::perform):
(WebCore::GetOperation::perform):
(WebCore::PutOperation::perform):
(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::DeleteRangeOperation::perform):
(WebCore::ClearOperation::perform):
(WebCore::DeleteObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackend::VersionChangeOperation::perform):

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:

(WebCore::IDBBackingStoreLevelDB::makeIndexWriters):
(WebCore::IDBBackingStoreLevelDB::generateKey):
(WebCore::IDBBackingStoreLevelDB::updateKeyGenerator):
(WebCore::IDBBackingStoreLevelDB::establishBackingStoreTransaction):
(WebCore::IDBBackingStoreLevelDB::deprecatedBackingStoreTransaction):
(WebCore::IDBBackingStoreLevelDB::removeBackingStoreTransaction):

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.cpp:

(WebCore::IDBBackingStoreTransactionLevelDB::IDBBackingStoreTransactionLevelDB):
(WebCore::IDBBackingStoreTransactionLevelDB::~IDBBackingStoreTransactionLevelDB):
(WebCore::IDBBackingStoreTransactionLevelDB::resetTransaction):

  • Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.h:
  • Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:

(WebCore::IDBServerConnectionLevelDB::IDBServerConnectionLevelDB):
(WebCore::IDBServerConnectionLevelDB::deprecatedBackingStoreTransaction):
(WebCore::IDBServerConnectionLevelDB::openTransaction):
(WebCore::IDBServerConnectionLevelDB::beginTransaction):
(WebCore::IDBServerConnectionLevelDB::commitTransaction):
(WebCore::IDBServerConnectionLevelDB::resetTransaction):
(WebCore::IDBServerConnectionLevelDB::rollbackTransaction):

  • Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:
6:47 PM Changeset in webkit [159176] by commit-queue@webkit.org
  • 26 edits in trunk/Source/WebKit2

[GTK][EFL] More on renaming WebKit::APIObject to API::Object
​https://bugs.webkit.org/show_bug.cgi?id=124255

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-11-12
Reviewed by Anders Carlsson.

In r159163 WebKit::APIObject has been renamed to API::Object.
This patch refactors the remaining files which were still
using WebKit::APIObject and WebKit::TypedAPIObject.

  • Shared/WebBatteryStatus.h:
  • Shared/WebNetworkInfo.h:
  • UIProcess/API/C/WKGrammarDetail.cpp:
  • UIProcess/API/gtk/WebKitContextMenuItem.cpp:
  • UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
  • UIProcess/API/gtk/WebKitWebViewGroup.cpp:
  • UIProcess/CoordinatedGraphics/WebView.h:
  • UIProcess/WebBatteryManagerProxy.cpp:
  • UIProcess/WebBatteryManagerProxy.h:
  • UIProcess/WebGrammarDetail.cpp:
  • UIProcess/WebNetworkInfoManagerProxy.cpp:
  • UIProcess/WebNetworkInfoManagerProxy.h:
  • UIProcess/WebTextChecker.h:
  • UIProcess/WebVibrationProxy.h:
  • UIProcess/WebViewportAttributes.h:
  • UIProcess/efl/EwkTouchEvent.h:
  • UIProcess/efl/EwkTouchPoint.h:
  • UIProcess/efl/WebPopupItemEfl.h:
  • UIProcess/efl/WebUIPopupMenuClient.cpp:
  • UIProcess/gtk/WebFullScreenClientGtk.h:
  • UIProcess/gtk/WebInspectorClientGtk.h:
  • UIProcess/soup/WebSoupRequestManagerProxy.cpp:
  • UIProcess/soup/WebSoupRequestManagerProxy.h:
  • WebProcess/InjectedBundle/efl/InjectedBundleEfl.cpp:
  • WebProcess/InjectedBundle/gtk/InjectedBundleGtk.cpp:
6:44 PM Changeset in webkit [159175] by ryuan.choi@samsung.com
  • 2 edits in trunk/Tools

[EFL] Added libxss-dev to install-dependencies
​https://bugs.webkit.org/show_bug.cgi?id=124254

Reviewed by Gyuyoung Kim.

libxss-dev is required to build EFL packages.
see building part in ​http://www.enlightenment.org/p.php?p=contribute

  • efl/install-dependencies: Added libxss-dev to parameter of apt-get command.
6:38 PM Changeset in webkit [159174] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

Revert r159140, as it is theoretically fixed by r159173.

  • platform/mac-wk2/TestExpectations:
6:24 PM Changeset in webkit [159173] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

fast/canvas/webgl/draw-arrays-out-of-bounds.html is flaky on Mavericks WK2 testers, fails about 20% of the time
​https://bugs.webkit.org/show_bug.cgi?id=124223
<rdar://problem/15333977>

Reviewed by Tim Horton.

It's wrong to use DataReferences in sync IPC replies; the underlying MessageDecoder will be freed after the call to
sendSync returns and the DataReference will point to freed memory. Use a Vector<char> instead.

  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • NetworkProcess/SynchronousNetworkLoaderClient.cpp:

(WebKit::SynchronousNetworkLoaderClient::didReceiveBuffer):
(WebKit::SynchronousNetworkLoaderClient::sendDelayedReply):

  • NetworkProcess/SynchronousNetworkLoaderClient.h:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::loadResourceSynchronously):

6:19 PM Changeset in webkit [159172] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the Mountain Lion build after r159171.

  • platform/mac/HTMLConverter.mm:

(_dateForString): +[NSCalendar calendarWithIdentifier:] only exists on
10.9. Use -[NSCalendar initWithIdentifier:] instead.

6:04 PM Changeset in webkit [159171] by aestes@apple.com
  • 5 edits in trunk/Source

[Mac] Fix some deprecation warnings
​https://bugs.webkit.org/show_bug.cgi?id=124252

Reviewed by Mark Rowe.

Source/WebCore:

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create): Use CFPropertyListCreateWithData()
instead of CFPropertyListCreateFromXMLData().
(WebCore::LegacyWebArchive::rawDataRepresentation): Use
CFPropertyListWrite() instead of CFPropertyListWriteToStream().

  • platform/mac/HTMLConverter.mm:

(_dateForString): Rewrite this method in terms of NSDateComponents and
NSCalendar instead of using CFGregorianDate.

Source/WebKit/mac:

  • Plugins/WebBasePluginPackage.mm:

(-[WebBasePluginPackage pListForPath:createFile:]): Use +[NSPropertyListSerialization propertyListWithData:options:format:error:] instead of +[NSPropertyListSerialization propertyListFromData:mutabilityOption:format:errorDescription:].

5:59 PM Changeset in webkit [159170] by Gustavo Noronha Silva
  • 2 edits in trunk/Source/WebKit2

Unreviewed try at fixing the GTK+ build.

  • UIProcess/soup/WebSoupRequestManagerProxy.h: rename TypedAPIObject to API:TypedObject.
5:50 PM Changeset in webkit [159169] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Remove -[WebHistoryItem _lastVisitedDate]
​https://bugs.webkit.org/show_bug.cgi?id=124250

Reviewed by Mark Rowe.

This method is not called by anyone and NSCalendarDate is deprecated so get rid of it.

  • History/WebHistoryItem.mm:
  • History/WebHistoryItemPrivate.h:
5:40 PM Changeset in webkit [159168] by roger_fong@apple.com
  • 14 edits
    1 move
    1 add in trunk/LayoutTests

[Windows] Unreviewed. More edits to Windows test expectations following r159157.

  • platform/win/editing/selection/extend-selection-home-end-expected.txt:
  • platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt:
  • platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt:
  • platform/win/fast/canvas/canvas-scale-shadowBlur-expected.txt:
  • platform/win/fast/canvas/canvas-scale-strokePath-shadow-expected.txt:
  • platform/win/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt:
  • platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt:
  • platform/win/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt:
  • platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt:
  • platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt:
  • platform/win/fast/forms/cursor-at-editable-content-boundary-expected.txt:
  • platform/win/fast/forms/implicit-submission-expected.txt:
  • platform/win/fast/forms/range: Added.
  • platform/win/fast/forms/range/slider-mouse-events-expected.txt: Copied from platform/win/fast/forms/slider-mouse-events-expected.txt.
  • platform/win/fast/forms/select-popup-pagekeys-expected.txt:
  • platform/win/fast/forms/slider-mouse-events-expected.txt: Removed.
5:34 PM Changeset in webkit [159167] by commit-queue@webkit.org
  • 22 edits
    14 deletes in trunk

Unreviewed, rolling out r159160, r159161, and r159164.
​http://trac.webkit.org/changeset/159160
​http://trac.webkit.org/changeset/159161
​http://trac.webkit.org/changeset/159164
​https://bugs.webkit.org/show_bug.cgi?id=124253

Too many errors (make fewer) (Requested by ap on #webkit).

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCryptoAlgorithmBuilder.cpp:
  • bindings/js/JSCryptoAlgorithmBuilder.h:
  • bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::createAesCbcParams):
(WebCore::createAesKeyGenParams):
(WebCore::createHmacParams):
(WebCore::createHmacKeyParams):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForSign):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForVerify):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDigest):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveBits):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForExportKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForWrapKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForUnwrapKey):

  • bindings/js/JSCryptoKeySerializationJWK.cpp:

(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm):
(WebCore::JSCryptoKeySerializationJWK::keyData):

  • bindings/js/JSCryptoKeySerializationJWK.h:
  • crypto/CryptoAlgorithmDescriptionBuilder.h:
  • crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: Removed.
  • crypto/CryptoKey.h:

(WebCore::ENUM_CLASS):

  • crypto/CryptoKeyData.h:

(WebCore::CryptoKeyData::ENUM_CLASS):

  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::importKey):

  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::importKey):

  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp: Removed.
  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h: Removed.
  • crypto/keys/CryptoKeyAES.h:

(WebCore::asCryptoKeyAES):

  • crypto/keys/CryptoKeyDataOctetSequence.h:

(WebCore::asCryptoKeyDataOctetSequence):

  • crypto/keys/CryptoKeyDataRSAComponents.cpp: Removed.
  • crypto/keys/CryptoKeyDataRSAComponents.h: Removed.
  • crypto/keys/CryptoKeyHMAC.h:

(WebCore::asCryptoKeyHMAC):

  • crypto/keys/CryptoKeyRSA.h: Removed.
  • crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:

(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):

  • crypto/mac/CryptoAlgorithmHMACMac.cpp:

(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):

  • crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):

  • crypto/mac/CryptoKeyRSAMac.cpp: Removed.
  • crypto/parameters/CryptoAlgorithmHmacKeyParams.h:
  • crypto/parameters/CryptoAlgorithmRsaKeyGenParams.h: Removed.
  • crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h: Removed.
  • crypto/parameters/CryptoAlgorithmRsaSsaParams.h: Removed.

LayoutTests:

  • crypto/subtle/resources/common.js:

(hexToArrayBuffer):

  • crypto/subtle/rsassa-pkcs1-v1_5-generate-key-expected.txt: Removed.
  • crypto/subtle/rsassa-pkcs1-v1_5-generate-key.html: Removed.
  • crypto/subtle/rsassa-pkcs1-v1_5-import-jwk-expected.txt: Removed.
  • crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html: Removed.
  • platform/mac/TestExpectations:
5:32 PM Changeset in webkit [159166] by Bem Jones-Bey
  • 3 edits in trunk/Source/WebCore

Make the placed floats tree use LayoutUnit instead of int
​https://bugs.webkit.org/show_bug.cgi?id=124207

Reviewed by Alexandru Chiculita.

The dimensions of floats are in LayoutUnits, so it doesn't make sense
to be converting to ints for use in the placed floats tree.

Also add missed "explicit" to single argument FloatingObjects
constructor.

No new tests, no behavior change.

  • rendering/FloatingObjects.cpp:

(WebCore::rangesIntersect):
(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter):
(WebCore::ComputeFloatOffsetAdapter::lowValue):
(WebCore::ComputeFloatOffsetAdapter::highValue):
(WebCore::FindNextFloatLogicalBottomAdapter::FindNextFloatLogicalBottomAdapter):
(WebCore::FindNextFloatLogicalBottomAdapter::lowValue):
(WebCore::FindNextFloatLogicalBottomAdapter::highValue):

  • rendering/FloatingObjects.h:
  • rendering/RenderFlowThread.h:
5:24 PM Changeset in webkit [159165] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[EFL][GTK] Remove MutableArray leftovers from build systems
​https://bugs.webkit.org/show_bug.cgi?id=124248

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-11-12
Reviewed by Anders Carlsson.

MutableArray.cpp and .h file has been removed by r159155.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
5:13 PM Changeset in webkit [159164] by ap@apple.com
  • 5 edits in trunk

Implement key generation and JWK import for RSASSA-PKCS1-v1_5
​https://bugs.webkit.org/show_bug.cgi?id=124236

Source/WebCore:

Build fix.

  • crypto/mac/CryptoKeyRSAMac.cpp: (WebCore::CryptoKeyRSA::buildAlgorithmDescription):

ifdef out some code on Mountain Lion. Bug 124249 track fixing this.

LayoutTests:

  • platform/mac/TestExpectations: Update expectations for Mountain Lion.

I'll investigate this later.

  • crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html: Quickly fail is promise is rejected.
4:57 PM Changeset in webkit [159163] by andersca@apple.com
  • 169 edits in trunk/Source/WebKit2

Rename APIObject to API::Object
​https://bugs.webkit.org/show_bug.cgi?id=124247

Reviewed by Tim Horton.

  • Shared/API/Cocoa/WKRemoteObjectRegistry.mm:

(-[WKRemoteObjectRegistry _handleMessageWithName:body:]):

  • Shared/API/c/WKArray.cpp:

(WKArrayCreate):
(WKArrayCreateAdoptingValues):

  • Shared/API/c/WKContextMenuItem.cpp:

(WKContextMenuItemGetTypeID):

  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):

  • Shared/API/c/WKType.cpp:

(WKGetTypeID):
(WKRetain):
(WKRelease):

  • Shared/APIObject.cpp:

(API::Object::Object):

  • Shared/APIObject.h:

(API::Object::~Object):
(API::TypedObject::~TypedObject):
(API::TypedObject::TypedObject):

  • Shared/Cocoa/APIObject.mm:

(API::Object::ref):
(API::Object::deref):
(API::Object::newObject):

  • Shared/Cocoa/WKNSArray.mm:

(-[WKNSArray objectAtIndex:]):
(-[WKNSArray API::]):

  • Shared/Cocoa/WKNSDictionary.mm:

(-[WKNSDictionary objectForKey:]):
(-[WKNSDictionary API::]):

  • Shared/Cocoa/WKObject.h:
  • Shared/Cocoa/WKObject.mm:

(-[WKObject dealloc]):
(-[WKObject API::]):

  • Shared/ImmutableArray.cpp:

(WebKit::ImmutableArray::create):
(WebKit::ImmutableArray::createStringArray):
(WebKit::ImmutableArray::ImmutableArray):

  • Shared/ImmutableArray.h:
  • Shared/ImmutableDictionary.cpp:

(WebKit::ImmutableDictionary::keys):

  • Shared/ImmutableDictionary.h:

(WebKit::ImmutableDictionary::get):

  • Shared/MutableDictionary.cpp:

(WebKit::MutableDictionary::add):
(WebKit::MutableDictionary::set):

  • Shared/MutableDictionary.h:
  • Shared/SecurityOriginData.cpp:

(WebKit::performAPICallbackWithSecurityOriginDataVector):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageEncoder::UserMessageEncoder):
(WebKit::UserMessageDecoder::baseDecode):
(WebKit::UserMessageDecoder::UserMessageDecoder):

  • Shared/WebArchive.cpp:

(WebKit::WebArchive::subresources):
(WebKit::WebArchive::subframeArchives):

  • Shared/WebArchive.h:
  • Shared/WebArchiveResource.h:
  • Shared/WebBackForwardListItem.h:
  • Shared/WebCertificateInfo.h:
  • Shared/WebConnection.cpp:

(WebKit::WebConnection::postMessage):
(WebKit::WebConnection::handleMessage):

  • Shared/WebConnection.h:
  • Shared/WebConnectionClient.cpp:

(WebKit::WebConnectionClient::didReceiveMessage):

  • Shared/WebConnectionClient.h:
  • Shared/WebContextMenuItem.cpp:

(WebKit::WebContextMenuItem::submenuItemsAsImmutableArray):
(WebKit::WebContextMenuItem::userData):
(WebKit::WebContextMenuItem::setUserData):

  • Shared/WebContextMenuItem.h:
  • Shared/WebContextMenuItemData.cpp:

(WebKit::WebContextMenuItemData::userData):
(WebKit::WebContextMenuItemData::setUserData):

  • Shared/WebContextMenuItemData.h:
  • Shared/WebData.h:
  • Shared/WebError.h:
  • Shared/WebGeolocationPosition.h:
  • Shared/WebGeometry.h:
  • Shared/WebGraphicsContext.h:
  • Shared/WebHitTestResult.h:
  • Shared/WebImage.h:
  • Shared/WebNumber.h:
  • Shared/WebOpenPanelParameters.h:
  • Shared/WebRenderLayer.cpp:

(WebKit::WebRenderLayer::createArrayFromLayerList):

  • Shared/WebRenderLayer.h:
  • Shared/WebRenderObject.cpp:

(WebKit::WebRenderObject::WebRenderObject):

  • Shared/WebRenderObject.h:
  • Shared/WebSecurityOrigin.h:
  • Shared/WebSerializedScriptValue.h:
  • Shared/WebString.h:
  • Shared/WebURL.h:
  • Shared/WebURLRequest.h:
  • Shared/WebURLResponse.h:
  • Shared/WebUserContentURLPattern.h:
  • Shared/mac/ObjCObjectGraph.h:
  • Shared/mac/ObjCObjectGraphCoders.mm:

(WebKit::WebContextObjCObjectGraphDecoderImpl::decode):
(WebKit::InjectedBundleObjCObjectGraphDecoderImpl::decode):

  • UIProcess/API/C/WKPluginSiteDataManager.cpp:

(WKPluginSiteDataManagerGetTypeID):

  • UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextGetInfoForInstalledPlugIns):

  • UIProcess/API/Cocoa/WKBackForwardList.mm:

(-[WKBackForwardList API::]):

  • UIProcess/API/Cocoa/WKBackForwardListItem.mm:

(-[WKBackForwardListItem API::]):

  • UIProcess/API/Cocoa/WKNavigationData.mm:

(-[WKNavigationData API::]):

  • UIProcess/API/mac/WKBrowsingContextGroup.mm:

(createWKArray):

  • UIProcess/Authentication/AuthenticationChallengeProxy.h:
  • UIProcess/Authentication/AuthenticationDecisionListener.h:
  • UIProcess/Authentication/WebCredential.h:
  • UIProcess/Authentication/WebProtectionSpace.h:
  • UIProcess/Downloads/DownloadProxy.h:
  • UIProcess/GeolocationPermissionRequestProxy.h:
  • UIProcess/Notifications/NotificationPermissionRequest.h:
  • UIProcess/Notifications/WebNotification.h:
  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::refWebContextSupplement):
(WebKit::WebNotificationManagerProxy::derefWebContextSupplement):

  • UIProcess/Notifications/WebNotificationManagerProxy.h:
  • UIProcess/Notifications/WebNotificationProvider.cpp:

(WebKit::WebNotificationProvider::clearNotifications):

  • UIProcess/Plugins/WebPluginSiteDataManager.h:
  • UIProcess/StatisticsRequest.cpp:

(WebKit::StatisticsRequest::completedRequest):

  • UIProcess/WebApplicationCacheManagerProxy.cpp:

(WebKit::WebApplicationCacheManagerProxy::refWebContextSupplement):
(WebKit::WebApplicationCacheManagerProxy::derefWebContextSupplement):

  • UIProcess/WebApplicationCacheManagerProxy.h:
  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::addItem):
(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::clear):

  • UIProcess/WebBackForwardList.h:
  • UIProcess/WebColorPickerResultListenerProxy.h:
  • UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::encodeMessageBody):
(WebKit::WebConnectionToWebProcess::decodeMessageBody):

  • UIProcess/WebConnectionToWebProcess.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::postMessageToInjectedBundle):
(WebKit::WebContext::didReceiveMessageFromInjectedBundle):
(WebKit::WebContext::didReceiveSynchronousMessageFromInjectedBundle):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):

  • UIProcess/WebContext.h:

(WebKit::WebContext::setInjectedBundleInitializationUserData):

  • UIProcess/WebContextInjectedBundleClient.cpp:

(WebKit::WebContextInjectedBundleClient::didReceiveMessageFromInjectedBundle):
(WebKit::WebContextInjectedBundleClient::didReceiveSynchronousMessageFromInjectedBundle):
(WebKit::WebContextInjectedBundleClient::getInjectedBundleInitializationUserData):

  • UIProcess/WebContextInjectedBundleClient.h:
  • UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageEncoder::WebContextUserMessageEncoder):
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::WebContextUserMessageDecoder):
(WebKit::WebContextUserMessageDecoder::decode):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::refWebContextSupplement):
(WebKit::WebCookieManagerProxy::derefWebContextSupplement):

  • UIProcess/WebCookieManagerProxy.h:
  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::refWebContextSupplement):
(WebKit::WebDatabaseManagerProxy::derefWebContextSupplement):
(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):

  • UIProcess/WebDatabaseManagerProxy.h:
  • UIProcess/WebEditCommandProxy.h:
  • UIProcess/WebFormClient.cpp:

(WebKit::WebFormClient::willSubmitForm):

  • UIProcess/WebFormClient.h:
  • UIProcess/WebFrameListenerProxy.h:
  • UIProcess/WebFrameProxy.h:
  • UIProcess/WebGeolocationManagerProxy.cpp:

(WebKit::WebGeolocationManagerProxy::refWebContextSupplement):
(WebKit::WebGeolocationManagerProxy::derefWebContextSupplement):

  • UIProcess/WebGeolocationManagerProxy.h:
  • UIProcess/WebGrammarDetail.h:
  • UIProcess/WebIconDatabase.h:
  • UIProcess/WebIconDatabaseClient.h:
  • UIProcess/WebInspectorProxy.h:
  • UIProcess/WebKeyValueStorageManager.cpp:

(WebKit::WebKeyValueStorageManager::refWebContextSupplement):
(WebKit::WebKeyValueStorageManager::derefWebContextSupplement):
(WebKit::didGetKeyValueStorageOrigins):

  • UIProcess/WebKeyValueStorageManager.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didStartProvisionalLoadForFrame):
(WebKit::WebLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didCommitLoadForFrame):
(WebKit::WebLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::WebLoaderClient::didFinishLoadForFrame):
(WebKit::WebLoaderClient::didFailLoadWithErrorForFrame):
(WebKit::WebLoaderClient::didSameDocumentNavigationForFrame):
(WebKit::WebLoaderClient::didReceiveTitleForFrame):
(WebKit::WebLoaderClient::didFirstLayoutForFrame):
(WebKit::WebLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::WebLoaderClient::didLayout):
(WebKit::WebLoaderClient::didRemoveFrameFromHierarchy):
(WebKit::WebLoaderClient::didDisplayInsecureContentForFrame):
(WebKit::WebLoaderClient::didRunInsecureContentForFrame):
(WebKit::WebLoaderClient::didDetectXSSForFrame):
(WebKit::WebLoaderClient::didChangeBackForwardList):
(WebKit::WebLoaderClient::willGoToBackForwardListItem):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebMediaCacheManagerProxy.cpp:

(WebKit::WebMediaCacheManagerProxy::refWebContextSupplement):
(WebKit::WebMediaCacheManagerProxy::derefWebContextSupplement):

  • UIProcess/WebMediaCacheManagerProxy.h:
  • UIProcess/WebNavigationData.h:
  • UIProcess/WebOpenPanelResultListenerProxy.h:
  • UIProcess/WebOriginDataManagerProxy.cpp:

(WebKit::WebOriginDataManagerProxy::refWebContextSupplement):
(WebKit::WebOriginDataManagerProxy::derefWebContextSupplement):

  • UIProcess/WebOriginDataManagerProxy.h:
  • UIProcess/WebPageContextMenuClient.cpp:

(WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):
(WebKit::WebPageContextMenuClient::showContextMenu):

  • UIProcess/WebPageContextMenuClient.h:
  • UIProcess/WebPageGroup.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::relatedPages):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::loadPlainTextString):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::didChangeBackForwardList):
(WebKit::WebPageProxy::willGoToBackForwardListItem):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
(WebKit::WebPageProxy::didReceiveTitleForFrame):
(WebKit::WebPageProxy::didFirstLayoutForFrame):
(WebKit::WebPageProxy::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::WebPageProxy::didLayout):
(WebKit::WebPageProxy::didRemoveFrameFromHierarchy):
(WebKit::WebPageProxy::didDisplayInsecureContentForFrame):
(WebKit::WebPageProxy::didRunInsecureContentForFrame):
(WebKit::WebPageProxy::didDetectXSSForFrame):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
(WebKit::WebPageProxy::unableToImplementPolicy):
(WebKit::WebPageProxy::willSubmitForm):
(WebKit::WebPageProxy::mouseDidMoveOverElement):
(WebKit::WebPageProxy::didFindStringMatches):
(WebKit::WebPageProxy::postMessageToInjectedBundle):
(WebKit::WebPageProxy::internalShowContextMenu):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPolicyClient.cpp:

(WebKit::WebPolicyClient::decidePolicyForNavigationAction):
(WebKit::WebPolicyClient::decidePolicyForNewWindowAction):
(WebKit::WebPolicyClient::decidePolicyForResponse):
(WebKit::WebPolicyClient::unableToImplementPolicy):

  • UIProcess/WebPolicyClient.h:
  • UIProcess/WebPreferences.h:
  • UIProcess/WebResourceCacheManagerProxy.cpp:

(WebKit::WebResourceCacheManagerProxy::refWebContextSupplement):
(WebKit::WebResourceCacheManagerProxy::derefWebContextSupplement):

  • UIProcess/WebResourceCacheManagerProxy.h:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::mouseDidMoveOverElement):

  • UIProcess/WebUIClient.h:
  • UIProcess/mac/WebContextMenuProxyMac.mm:

(-[WKUserDataWrapper initWithUserData:API::]):
(-[WKUserDataWrapper API::]):

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundlePostSynchronousMessage):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(contextMenuItems):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::postMessage):
(WebKit::InjectedBundle::postSynchronousMessage):
(WebKit::InjectedBundle::originsWithApplicationCache):
(WebKit::InjectedBundle::didReceiveMessage):
(WebKit::InjectedBundle::didReceiveMessageToPage):

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/InjectedBundleBackForwardList.h:
  • WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp:

(WebKit::InjectedBundleBackForwardListItem::children):

  • WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.h:
  • WebProcess/InjectedBundle/InjectedBundleClient.cpp:

(WebKit::InjectedBundleClient::didReceiveMessage):
(WebKit::InjectedBundleClient::didReceiveMessageToPage):

  • WebProcess/InjectedBundle/InjectedBundleClient.h:
  • WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.h:
  • WebProcess/InjectedBundle/InjectedBundleHitTestResult.h:
  • WebProcess/InjectedBundle/InjectedBundleNavigationAction.h:
  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:

(WebKit::InjectedBundlePageContextMenuClient::getCustomMenuFromDefaultItems):

  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:

(WebKit::InjectedBundlePageFormClient::willSubmitForm):
(WebKit::InjectedBundlePageFormClient::didAssociateFormControls):

  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::willLoadURLRequest):
(WebKit::InjectedBundlePageLoaderClient::willLoadDataRequest):
(WebKit::InjectedBundlePageLoaderClient::shouldGoToBackForwardListItem):
(WebKit::InjectedBundlePageLoaderClient::didStartProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didCommitLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didSameDocumentNavigationForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveTitleForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRemoveFrameFromHierarchy):
(WebKit::InjectedBundlePageLoaderClient::didDisplayInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRunInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didDetectXSSForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFirstLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didLayout):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp:

(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNavigationAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForNewWindowAction):
(WebKit::InjectedBundlePagePolicyClient::decidePolicyForResponse):
(WebKit::InjectedBundlePagePolicyClient::unableToImplementPolicy):

  • WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageResourceLoadClient.h:
  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::mouseDidMoveOverElement):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.h:
  • WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:

(WebKit::InjectedBundleUserMessageEncoder::InjectedBundleUserMessageEncoder):
(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::InjectedBundleUserMessageDecoder):
(WebKit::InjectedBundleUserMessageDecoder::decode):

  • WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::load):

  • WebProcess/WebConnectionToUIProcess.cpp:

(WebKit::WebConnectionToUIProcess::encodeMessageBody):
(WebKit::WebConnectionToUIProcess::decodeMessageBody):

  • WebProcess/WebConnectionToUIProcess.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::mouseDidMoveOverElement):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::detachedFromParent2):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidPushStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidReplaceStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidPopStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle):
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):
(WebKit::WebFrameLoaderClient::dispatchDidLayout):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchUnableToImplementPolicy):
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):
(WebKit::WebFrameLoaderClient::shouldGoToHistoryItem):
(WebKit::WebFrameLoaderClient::didDisplayInsecureContent):
(WebKit::WebFrameLoaderClient::didRunInsecureContent):
(WebKit::WebFrameLoaderClient::didDetectXSS):

  • WebProcess/WebPage/PageBanner.h:
  • WebProcess/WebPage/PageOverlay.h:
  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):
(WebKit::WebContextMenu::menuItemsWithUserData):
(WebKit::WebContextMenu::items):

  • WebProcess/WebPage/WebContextMenu.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::childFrames):

  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebInspector.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::trackedRepaintRects):
(WebKit::WebPage::loadURLRequest):
(WebKit::WebPage::loadDataImpl):
(WebKit::WebPage::postInjectedBundleMessage):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPageGroupProxy.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::postInjectedBundleMessage):

4:53 PM Changeset in webkit [159162] by commit-queue@webkit.org
  • 11 edits
    2 adds
    1 delete in trunk/Source/WebCore

Web Inspector: Extract InspectorAgentRegistry from InspectorBaseAgent
​https://bugs.webkit.org/show_bug.cgi?id=124190

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-12
Reviewed by Timothy Hatcher.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorAgentRegistry.cpp: Added.

(WebCore::InspectorAgentRegistry::append):
(WebCore::InspectorAgentRegistry::setFrontend):
(WebCore::InspectorAgentRegistry::clearFrontend):
(WebCore::InspectorAgentRegistry::registerInDispatcher):
(WebCore::InspectorAgentRegistry::discardAgents):

  • inspector/InspectorAgentRegistry.h: Added.
  • inspector/InspectorAllInOne.cpp:
  • inspector/InspectorBaseAgent.cpp: Removed.
  • inspector/InspectorBaseAgent.h:

(WebCore::InspectorBaseAgentInterface::InspectorBaseAgentInterface):
(WebCore::InspectorBaseAgentInterface::~InspectorBaseAgentInterface):

  • inspector/InspectorController.h:
  • inspector/InspectorMemoryAgent.h:
  • inspector/WorkerInspectorController.h:
4:40 PM Changeset in webkit [159161] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Implement key generation and JWK import for RSASSA-PKCS1-v1_5
​https://bugs.webkit.org/show_bug.cgi?id=124236

Release build fix.

  • bindings/js/JSCryptoAlgorithmBuilder.cpp: Include TypedArrayInlines.h
4:32 PM Changeset in webkit [159160] by ap@apple.com
  • 21 edits
    14 adds in trunk

Implement key generation and JWK import for RSASSA-PKCS1-v1_5
​https://bugs.webkit.org/show_bug.cgi?id=124236

Reviewed by Sam Weinig.

Source/WebCore:

Tests: crypto/subtle/rsassa-pkcs1-v1_5-generate-key.html

crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html

  • WebCore.xcodeproj/project.pbxproj: Added new files.
  • bindings/js/JSCryptoAlgorithmBuilder.cpp:

(WebCore::JSCryptoAlgorithmBuilder::add):

  • bindings/js/JSCryptoAlgorithmBuilder.h:
  • crypto/CryptoAlgorithmDescriptionBuilder.h:

Added a way to add an Uint8Array, as needed for RSA key.algorithm.publicExponent.

  • bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::createAesCbcParams): Removed unneeded JSC prefixes.
(WebCore::createAesKeyGenParams): Ditto.
(WebCore::createHmacParams): Ditto.
(WebCore::createHmacKeyParams): Ditto.
(WebCore::createRsaKeyGenParams): Added.
(WebCore::createRsaSsaKeyParams): Added. WebCrypto currently doesn't specify any
parameters for importKey, so the structure remains blank (unlike with JWK).
(WebCore::createRsaSsaParams): Added (currently unused, will be sued for sign/verify soon).
(WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt): Removed unneeded JSC prefixes.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt): Ditto.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForSign): Added support for RSAES_PKCS1_v1_5.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForVerify): Ditto.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDigest): Removed unneeded JSC prefixes.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey): Ditto.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveKey): Ditto.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveBits): Ditto.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey): Added support for RSAES_PKCS1_v1_5.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForExportKey): Removed unneeded JSC prefixes.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForWrapKey): Ditto.
(WebCore::JSCryptoAlgorithmDictionary::createParametersForUnwrapKey): Ditto.

  • bindings/js/JSCryptoKeySerializationJWK.h:
  • bindings/js/JSCryptoKeySerializationJWK.cpp:

(WebCore::getJSArrayFromJSON): Added.
(WebCore::getBigIntegerVectorFromJSON): Added.
(WebCore::createRSASSAKeyParameters): Create parameters for key import. The key
will remember which algorithm it's allowed to be used with.
(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm): Added support for
RS256...RS512 (tha is, RSAES_PKCS1_v1_5 with SHA-256...SHA-512).
(WebCore::JSCryptoKeySerializationJWK::keyDataOctetSequence): Split out of keyData().
(WebCore::JSCryptoKeySerializationJWK::keyDataRSAComponents): Added code to read
RSA key components from JWK.
(WebCore::JSCryptoKeySerializationJWK::keyData): Call one of the above functions.

  • crypto/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp: Added.

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::sign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::verify):
Placeholders.

  • crypto/CryptoKey.h: (WebCore::CryptoKeyClass): Added RSA key class for poor man's RTTI.
  • crypto/CryptoKeyData.h: (WebCore::CryptoKeyData::FormatRSAComponents): Added RSAComponents

for poor man's RTTI.

  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp: (WebCore::CryptoAlgorithmAES_CBC::importKey):
  • crypto/algorithms/CryptoAlgorithmHMAC.cpp: (WebCore::CryptoAlgorithmHMAC::importKey):
  • crypto/keys/CryptoKeyAES.h:

(WebCore::isCryptoKeyAES):
(WebCore::toCryptoKeyAES):

  • crypto/keys/CryptoKeyDataOctetSequence.h:

(WebCore::toCryptoKeyDataOctetSequence):

  • crypto/keys/CryptoKeyHMAC.h:

(WebCore::isCryptoKeyHMAC):
(WebCore::toCryptoKeyHMAC):

  • crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:

(WebCore::CryptoAlgorithmAES_CBC::encrypt):
(WebCore::CryptoAlgorithmAES_CBC::decrypt):

  • crypto/mac/CryptoAlgorithmHMACMac.cpp:

(WebCore::CryptoAlgorithmHMAC::sign):
(WebCore::CryptoAlgorithmHMAC::verify):
Switched from "as" functions to "is" and "to" ones, as that's more idiomatic.

  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp: Added.
  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h: Added.

Glue code for importKey/generateKey for now.

  • crypto/keys/CryptoKeyDataRSAComponents.cpp: Added.

(WebCore::CryptoKeyDataRSAComponents::CryptoKeyDataRSAComponents):
(WebCore::CryptoKeyDataRSAComponents::~CryptoKeyDataRSAComponents):

  • crypto/keys/CryptoKeyDataRSAComponents.h: Added.

(WebCore::toCryptoKeyDataRSAComponents):
Added a structure to hold RSA key components, extracted from JWK or another format.

  • crypto/keys/CryptoKeyRSA.h: Added.
  • crypto/mac/CryptoKeyRSAMac.cpp: Added.
  • crypto/mac/CryptoAlgorithmRegistryMac.cpp:

(WebCore::CryptoAlgorithmRegistry::platformRegisterAlgorithms):
Register RSASSA_PKCS1_v1_5.

  • crypto/parameters/CryptoAlgorithmHmacKeyParams.h: Added a constructor to make

sure that hasLength is never left uninitialized, even when reading formats that
don't contain a length.

  • crypto/parameters/CryptoAlgorithmRsaKeyGenParams.h: Added.
  • crypto/parameters/CryptoAlgorithmRsaSsaKeyParams.h: Added.
  • crypto/parameters/CryptoAlgorithmRsaSsaParams.h: Added.

Added parameter structures that are needed for RSASSA_PKCS1_v1_5.

LayoutTests:

  • crypto/subtle/resources/common.js:

(hexToArrayBuffer): Fixed a typo
(Base64URL.stringify):
(Base64URL.parse):
Added helpers to deal with Base64URL, as needed for JWK.

  • crypto/subtle/rsassa-pkcs1-v1_5-generate-key-expected.txt: Added.
  • crypto/subtle/rsassa-pkcs1-v1_5-generate-key.html: Added.
  • crypto/subtle/rsassa-pkcs1-v1_5-import-jwk-expected.txt: Added.
  • crypto/subtle/rsassa-pkcs1-v1_5-import-jwk.html: Added.
4:31 PM Changeset in webkit [159159] by Bem Jones-Bey
  • 14 edits
    1 add in trunk/Source/WebCore

Move ValueToString out to its own header file to remove duplication
​https://bugs.webkit.org/show_bug.cgi?id=124237

Reviewed by Alexandru Chiculita.

The ValueToString struct is used in many places for debugging. Move it
out to its own header file to remove all the duplicated definitions
and make it possible for the specializations to be placed in the
header files with the implementation of the classes they print.

No new tests, no behavior change.

  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.h:
  • platform/LayoutUnit.h:
  • platform/PODInterval.h:
  • platform/PODIntervalTree.h:
  • platform/PODRedBlackTree.h:
  • platform/ValueToString.h: Added.
  • platform/graphics/FloatPolygon.h:
  • rendering/FloatingObjects.cpp:
  • rendering/FloatingObjects.h:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.h:
  • rendering/RenderFlowThread.h:
4:28 PM Changeset in webkit [159158] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix GTK build after r159142
​https://bugs.webkit.org/show_bug.cgi?id=124243

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-11-12
Reviewed by Anders Carlsson.

Use Vector + ImmutableArray instead of MutableArray

  • UIProcess/API/gtk/WebKitContextMenuItem.cpp:

(webkitContextMenuItemCreate):

4:20 PM Changeset in webkit [159157] by roger_fong@apple.com
  • 2 edits
    15 adds in trunk/LayoutTests

[Windows] Unreviewed gardening. Re-add someone Windows expections that were erroneously removed.

  • platform/win/editing/selection/extend-selection-home-end-expected.txt: Added.
  • platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Added.
  • platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Added.
  • platform/win/fast/canvas/canvas-render-layer-expected.txt: Added.
  • platform/win/fast/canvas/canvas-scale-shadowBlur-expected.txt: Added.
  • platform/win/fast/canvas/canvas-scale-strokePath-shadow-expected.txt: Added.
  • platform/win/fast/canvas/canvas-strokePath-gradient-shadow-expected.txt: Added.
  • platform/win/fast/canvas/canvas-strokeRect-alpha-shadow-expected.txt: Added.
  • platform/win/fast/canvas/canvas-strokeRect-gradient-shadow-expected.txt: Added.
  • platform/win/fast/dom/horizontal-scrollbar-in-rtl-expected.txt: Added.
  • platform/win/fast/dom/vertical-scrollbar-in-rtl-expected.txt: Added.
  • platform/win/fast/forms/cursor-at-editable-content-boundary-expected.txt: Added.
  • platform/win/fast/forms/implicit-submission-expected.txt: Added.
  • platform/win/fast/forms/select-popup-pagekeys-expected.txt: Added.
  • platform/win/fast/forms/slider-mouse-events-expected.txt: Added.
  • platform/win/media/media-can-play-wav-audio-expected.txt:
4:04 PM Changeset in webkit [159156] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Remove ImmutableArray::isMutable
​https://bugs.webkit.org/show_bug.cgi?id=124242

Reviewed by Dan Bernstein.

  • Shared/API/c/WKMutableArray.cpp:

(WKArrayIsMutable):

  • Shared/Cocoa/WKNSArray.mm:

(-[WKNSArray copyWithZone:]):

  • Shared/ImmutableArray.h:
3:37 PM Changeset in webkit [159155] by andersca@apple.com
  • 10 edits
    2 deletes in trunk/Source/WebKit2

WKMutableArrayRef should be an ImmutableArray
​https://bugs.webkit.org/show_bug.cgi?id=124239

Reviewed by Sam Weinig.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(ensureObjectStream):

  • Shared/API/c/WKMutableArray.cpp:

(WKMutableArrayCreate):

  • Shared/API/c/WKSharedAPICast.h:
3:14 PM Changeset in webkit [159154] by hyatt@apple.com
  • 1 edit in trunk/Source/WebCore/rendering/RenderBlock.cpp

Fix windows build bustage.

3:09 PM Changeset in webkit [159153] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[sh4] Fix load32WithUnalignedHalfWords function in baseline JIT.
​https://bugs.webkit.org/show_bug.cgi?id=124233

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-11-12
Reviewed by Michael Saboff.

  • assembler/MacroAssemblerSH4.h:

(JSC::MacroAssemblerSH4::load32WithUnalignedHalfWords): Do not claim scratch register too early.
Test already covered by fast/regex/pcre-test-1.

3:04 PM Changeset in webkit [159152] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Remove more functionality from MutableArray
​https://bugs.webkit.org/show_bug.cgi?id=124235

Reviewed by Beth Dakin.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeToObjectStream):

  • Shared/API/c/WKMutableArray.cpp:

(WKArrayAppendItem):
(WKArrayRemoveItemAtIndex):

  • Shared/Cocoa/WKNSArray.mm:

(-[WKNSArray copyWithZone:]):

  • Shared/ImmutableArray.h:

(WebKit::ImmutableArray::elements):

  • Shared/MutableArray.cpp:
  • Shared/MutableArray.h:
3:03 PM Changeset in webkit [159151] by Alexandru Chiculita
  • 4 edits
    2 adds
    1 delete in trunk/Source/WebInspectorUI

Web Inspector: ContentFlowTreeContentView should use only one DOMTreeOutline
​https://bugs.webkit.org/show_bug.cgi?id=124230

Reviewed by Timothy Hatcher.

Changed ContentFlowTreeContentView to use one DOMTreeOutline by just
populating it with root DOMTreeElements directly. That is very
similar to how DOMTreeOutline works when omitRootDOMNode is used.

Now that ContentFlowTreeContentView has only one DOMTreeOutline,
it makes sense to change its base class to be DOMTreeContentView instead.
Also, with that I've changed its name to ContentFlowDOMTreeContentView.

I had to move all the DOMTree document loading code from DOMTreeContentView to a
new class called FrameDOMTreeContentView. This is used to display the DOM of the
frame objects. FrameDOMTreeContentView is also inheriting from DOMTreeContentView.

Issues that are fixed as a side effect:

  • Selection path components are now displaying all the sibling elements for contentFlow.contentNodes

(those are the nodes that have "-webkit-flow-into" set directly).

  • Keyboard navigation works for the contentFlow.contentNodes.
  • Search is implemented in DOMTreeContentView, so that code now works for flows too.

The DOMAgents's search API will use all the Documents to lookup for nodes, so it might
find DOM nodes that are not part of the flow. This is in line with the behavior for the
frames.

  • UserInterface/ContentFlowDOMTreeContentView.js: Renamed from ContentFlowTreeContentView

to better reflect the inheritance from DOMTreeContentView.
(WebInspector.ContentFlowDOMTreeContentView):
(WebInspector.ContentFlowDOMTreeContentView.prototype.closed):
(WebInspector.ContentFlowDOMTreeContentView.prototype._createContentTrees):
(WebInspector.ContentFlowDOMTreeContentView.prototype._contentNodeWasAdded):
(WebInspector.ContentFlowDOMTreeContentView.prototype._contentNodeWasRemoved):

  • UserInterface/ContentView.js:

(WebInspector.ContentView):

  • UserInterface/DOMTreeContentView.js:

(WebInspector.DOMTreeContentView):
(WebInspector.DOMTreeContentView.prototype.closed):
(WebInspector.DOMTreeContentView.prototype.):
(WebInspector.DOMTreeContentView.prototype._restoreSelectedNodeAfterUpdate):
(WebInspector.DOMTreeContentView.prototype._selectedNodeDidChange):

  • UserInterface/FrameDOMTreeContentView.js: Added.

(WebInspector.FrameDOMTreeContentView):
(WebInspector.FrameDOMTreeContentView.prototype.get domTree):
(WebInspector.FrameDOMTreeContentView.prototype.closed):
(WebInspector.FrameDOMTreeContentView.prototype._rootDOMNodeAvailable):
(WebInspector.FrameDOMTreeContentView.prototype._rootDOMNodeInvalidated):
(WebInspector.FrameDOMTreeContentView.prototype._requestRootDOMNode):

  • UserInterface/Main.html:
2:51 PM Changeset in webkit [159150] by hyatt@apple.com
  • 5 edits in trunk/Source/WebCore

Make RenderBlockRareData be in a hashtable instead of being a member variable.
​https://bugs.webkit.org/show_bug.cgi?id=124056

Reviewed by Anders Carlsson.

Right now RenderBlock has 4 bytes taken up by a m_rareData member that is almost
never allocated. This is better off in a separate hash, so that RenderBlock can
get 4 bytes back.

Since RenderBlockFlow's rare data member was recently removed and folded into
RenderBlock, we need to undo that change and put the rare data member back in
RenderBlockFlow. RenderBlockFlowRareData inheriting from RenderBlockRareData
was not a good idea anyway, since RenderBlockFlows also very rarely need the
RenderBlockRareData members, and were thus paying a heavier cost when the rare
data was created than was necessary.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlockRareData::RenderBlockRareData):
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::hasRareData):
(WebCore::getRareData):
(WebCore::ensureRareData):
(WebCore::RenderBlock::ensureShapeInsideInfo):
(WebCore::RenderBlock::shapeInsideInfo):
(WebCore::RenderBlock::setShapeInsideInfo):
(WebCore::RenderBlock::paginationStrut):
(WebCore::RenderBlock::pageLogicalOffset):
(WebCore::RenderBlock::setPaginationStrut):
(WebCore::RenderBlock::setPageLogicalOffset):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::setMaxMarginBeforeValues):
(WebCore::RenderBlockFlow::setMaxMarginAfterValues):
(WebCore::RenderBlockFlow::setMustDiscardMarginBefore):
(WebCore::RenderBlockFlow::setMustDiscardMarginAfter):
(WebCore::RenderBlockFlow::mustDiscardMarginBefore):
(WebCore::RenderBlockFlow::mustDiscardMarginAfter):
(WebCore::RenderBlockFlow::setBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::setDidBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::clearDidBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::clearShouldBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::setRenderNamedFlowFragment):
(WebCore::RenderBlockFlow::ensureRareBlockFlowData):
(WebCore::RenderBlockFlow::materializeRareBlockFlowData):

  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::shouldBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::lineBreakToAvoidWidow):
(WebCore::RenderBlockFlow::didBreakAtLineToAvoidWidow):
(WebCore::RenderBlockFlow::lineGridBox):
(WebCore::RenderBlockFlow::setLineGridBox):
(WebCore::RenderBlockFlow::renderNamedFlowFragment):
(WebCore::RenderBlockFlow::maxPositiveMarginBefore):
(WebCore::RenderBlockFlow::maxNegativeMarginBefore):
(WebCore::RenderBlockFlow::maxPositiveMarginAfter):
(WebCore::RenderBlockFlow::maxNegativeMarginAfter):
(WebCore::RenderBlockFlow::initMaxMarginValues):
(WebCore::RenderBlockFlow::hasRareBlockFlowData):
(WebCore::RenderBlockFlow::rareBlockFlowData):

2:20 PM Changeset in webkit [159149] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Remove most uses of MutableArray
​https://bugs.webkit.org/show_bug.cgi?id=124232

Reviewed by Sam Weinig.

  • Shared/API/c/WKMutableArray.cpp:

(WKMutableArrayCreate):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageDecoder::baseDecode):

  • Shared/WebRenderLayer.h:

(WebKit::WebRenderLayer::create):
(WebKit::WebRenderLayer::WebRenderLayer):

  • Shared/WebRenderObject.cpp:

(WebKit::WebRenderObject::WebRenderObject):

  • Shared/WebRenderObject.h:

(WebKit::WebRenderObject::create):
(WebKit::WebRenderObject::WebRenderObject):

  • WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:

(WebKit::InjectedBundlePageContextMenuClient::getCustomMenuFromDefaultItems):

1:51 PM Changeset in webkit [159148] by Brent Fulgham
  • 2 edits in trunk/Source/WTF

[Win] Unreviewed gardening.

  • WTF.vcxproj/WTF.vcxproj.filters: Tidy up filters so files show up

in their proper directories.

1:46 PM Changeset in webkit [159147] by Lucas Forschler
  • 1 delete in tags/Safari-537.73.5/safari-537.73-branch
1:44 PM Changeset in webkit [159146] by alex.christensen@flexsim.com
  • 8 edits in trunk/Source

Build GStreamer files on Windows.
​https://bugs.webkit.org/show_bug.cgi?id=124180

Reviewed by Brent Fulgham.

Source/WebCore:

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.vcxproj/copyForwardingHeaders.cmd:

Include gstreamer files in WinCairo build.

Source/WTF:

  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
  • WTF.vcxproj/copy-files.cmd:

Include gobject files in WinCairo build.

1:33 PM Changeset in webkit [159145] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

Add fast/images/pdf-as-image-crop-box.html to the pile of tiny-color-mismatch tests.

  • platform/mac-wk2/TestExpectations:
1:31 PM Changeset in webkit [159144] by beidson@apple.com
  • 12 edits
    3 adds in trunk/Source/WebCore

Introduce IDBServerConnection (and start moving things to it).
​https://bugs.webkit.org/show_bug.cgi?id=124193

Reviewed by Alexey Proskuryakov.

IDBServerConnection will be a purely asynchronous interface for database connections, transactions, and cursors.
Its interface will be 100% asynchronous and callback based - Perfect for an IPC divide.
Eventually none of the IDB<Foo>Backend classes will need IDBBackingStore<Foo> classes at all,
and they’ll all use IDBServerConnection directly.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:
  • Modules/indexeddb/IDBServerConnection.h: Added.

(WebCore::IDBServerConnection::~IDBServerConnection):

Concrete implementation that - for now - wraps an IDBBackingStoreLevelDB:

  • Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp: Added.

(WebCore::IDBServerConnectionLevelDB::IDBServerConnectionLevelDB):
(WebCore::IDBServerConnectionLevelDB::deprecatedBackingStore):
(WebCore::IDBServerConnectionLevelDB::isClosed):
(WebCore::IDBServerConnectionLevelDB::getOrEstablishIDBDatabaseMetadata):
(WebCore::IDBServerConnectionLevelDB::deleteDatabase):
(WebCore::IDBServerConnectionLevelDB::close):

  • Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h: Added.

LevelDB created databases get LevelDB server connections:

  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:

(WebCore::IDBFactoryBackendLevelDB::deleteDatabase):
(WebCore::IDBFactoryBackendLevelDB::open):

Replace most uses of IDBBackingStore with server connection:

  • Modules/indexeddb/IDBDatabaseBackend.cpp:

(WebCore::IDBDatabaseBackend::create):
(WebCore::IDBDatabaseBackend::IDBDatabaseBackend):
(WebCore::IDBDatabaseBackend::openInternalAsync):
(WebCore::IDBDatabaseBackend::setIndexKeys):
(WebCore::IDBDatabaseBackend::openConnectionInternal):
(WebCore::IDBDatabaseBackend::deleteDatabaseAsync):
(WebCore::IDBDatabaseBackend::close):

  • Modules/indexeddb/IDBDatabaseBackend.h:

(WebCore::IDBDatabaseBackend::serverConnection):

Change all the operations to access their DatabaseBackend’s server connection instead
if hanging on to a backing store directly:

  • Modules/indexeddb/IDBTransactionBackend.cpp:

(WebCore::IDBTransactionBackend::IDBTransactionBackend):
(WebCore::IDBTransactionBackend::scheduleCreateObjectStoreOperation):
(WebCore::IDBTransactionBackend::scheduleDeleteObjectStoreOperation):
(WebCore::IDBTransactionBackend::scheduleCreateIndexOperation):
(WebCore::IDBTransactionBackend::scheduleDeleteIndexOperation):
(WebCore::IDBTransactionBackend::scheduleGetOperation):
(WebCore::IDBTransactionBackend::schedulePutOperation):
(WebCore::IDBTransactionBackend::scheduleOpenCursorOperation):
(WebCore::IDBTransactionBackend::scheduleCountOperation):
(WebCore::IDBTransactionBackend::scheduleDeleteRangeOperation):
(WebCore::IDBTransactionBackend::scheduleClearOperation):

  • Modules/indexeddb/IDBTransactionBackend.h:
  • Modules/indexeddb/IDBTransactionBackendOperations.cpp:

(WebCore::CreateObjectStoreOperation::perform):
(WebCore::CreateIndexOperation::perform):
(WebCore::DeleteIndexOperation::perform):
(WebCore::GetOperation::perform):
(WebCore::PutOperation::perform):
(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::DeleteRangeOperation::perform):
(WebCore::ClearOperation::perform):
(WebCore::DeleteObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackend::VersionChangeOperation::perform):

  • Modules/indexeddb/IDBTransactionBackendOperations.h:

(WebCore::CreateObjectStoreOperation::create):
(WebCore::CreateObjectStoreOperation::CreateObjectStoreOperation):
(WebCore::DeleteObjectStoreOperation::create):
(WebCore::DeleteObjectStoreOperation::DeleteObjectStoreOperation):
(WebCore::CreateIndexOperation::create):
(WebCore::CreateIndexOperation::CreateIndexOperation):
(WebCore::DeleteIndexOperation::create):
(WebCore::DeleteIndexOperation::DeleteIndexOperation):
(WebCore::GetOperation::create):
(WebCore::GetOperation::GetOperation):
(WebCore::PutOperation::create):
(WebCore::PutOperation::PutOperation):
(WebCore::OpenCursorOperation::create):
(WebCore::OpenCursorOperation::OpenCursorOperation):
(WebCore::CountOperation::create):
(WebCore::CountOperation::CountOperation):
(WebCore::DeleteRangeOperation::create):
(WebCore::DeleteRangeOperation::DeleteRangeOperation):
(WebCore::ClearOperation::create):
(WebCore::ClearOperation::ClearOperation):

  • Modules/indexeddb/IDBTransactionCoordinator.h:
1:17 PM Changeset in webkit [159143] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Unreviewed gardening.

  • WebCore.vcxproj/WebCore.vcxproj.filters: Correct filter file so that source

files show up in their proper directories in Visual Studio.

1:04 PM Changeset in webkit [159142] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Use Vector + ImmutableArray instead of MutableArray
​https://bugs.webkit.org/show_bug.cgi?id=124221

Reviewed by Andreas Kling.

  • Shared/WebRenderLayer.cpp:

(WebKit::WebRenderLayer::createArrayFromLayerList):

  • Shared/WebRenderLayer.h:
  • UIProcess/Notifications/WebNotificationProvider.cpp:

(WebKit::WebNotificationProvider::clearNotifications):

  • UIProcess/WebPageContextMenuClient.cpp:

(WebKit::WebPageContextMenuClient::getContextMenuFromProposedMenu):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(contextMenuItems):
(WKBundlePageCopyContextMenuItems):
(WKBundlePageCopyContextMenuAtPointInWindow):

1:02 PM Changeset in webkit [159141] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Liveness analysis should take less memory in CodeBlock when it is unused
​https://bugs.webkit.org/show_bug.cgi?id=124225

Reviewed by Mark Hahnenberg.

Basically, I turned CodeBlock::m_livenessAnalysis into a pointer that is null by
default.

  • bytecode/BytecodeLivenessAnalysis.cpp:

(JSC::BytecodeLivenessAnalysis::BytecodeLivenessAnalysis):
(JSC::BytecodeLivenessAnalysis::runLivenessFixpoint):
(JSC::BytecodeLivenessAnalysis::operandIsLiveAtBytecodeOffset):
(JSC::BytecodeLivenessAnalysis::dumpResults):
(JSC::BytecodeLivenessAnalysis::compute):

  • bytecode/BytecodeLivenessAnalysis.h:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::livenessAnalysis):

12:57 PM Changeset in webkit [159140] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

fast/canvas/webgl/draw-arrays-out-of-bounds.html is flaky on Mavericks WK2 testers, fails about 20% of the time
​https://bugs.webkit.org/show_bug.cgi?id=124223

Mark as flaky on Mac-Mavericks-WebKit2.

  • platform/mac-wk2/TestExpectations:
12:55 PM Changeset in webkit [159139] by oliver@apple.com
  • 11 edits in trunk

Support unprefixed deconstructing assignment
​https://bugs.webkit.org/show_bug.cgi?id=124172

Reviewed by Mark Lam.

Source/JavaScriptCore:

Add support for unprefixed descontructive assignment.

Happily non-reference types on the left hand side of an assignment
are a runtime error, so we're able to defer validation of the binding
pattern to codegen time when we're already doing a lot more work.

We're also able to predicate our attempt to parse on the existence of
'[' or '{' as they are not as common as other constructs.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ArrayPatternNode::emitDirectBinding):

  • parser/ASTBuilder.h:
  • parser/Parser.cpp:

(JSC::::createBindingPattern):
(JSC::::tryParseDeconstructionPatternExpression):
(JSC::::parseDeconstructionPattern):
(JSC::::parseForStatement):
(JSC::::parseAssignmentExpression):

  • parser/Parser.h:

(JSC::Parser::createSavePoint):
(JSC::Parser::restoreSavePoint):

  • parser/SyntaxChecker.h:

LayoutTests:

Add and expand testing of destructuring assignment

  • js/basic-for-of-expected.txt:
  • js/destructuring-assignment-expected.txt:
  • js/parser-syntax-check-expected.txt:
  • js/script-tests/basic-for-of.js:
  • js/script-tests/destructuring-assignment.js:

(testDestructuring):

  • js/script-tests/parser-syntax-check.js:
12:50 PM Changeset in webkit [159138] by aestes@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Run JavaScriptCore Objective-C API tests on all supported platforms
​https://bugs.webkit.org/show_bug.cgi?id=124214

Reviewed by Mark Hahnenberg.

Now that we support the API on iOS and on OS X 10.8, there's no reason
to limit the tests to OS X 10.9 (or greater).

  • API/tests/CurrentThisInsideBlockGetterTest.h:
  • API/tests/CurrentThisInsideBlockGetterTest.mm:
  • API/tests/testapi.mm:
12:43 PM Changeset in webkit [159137] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[Windows] Unreviewed gardening of some media tests.

  • platform/win/TestExpectations:
12:35 PM Changeset in webkit [159136] by mhahnenberg@apple.com
  • 13 edits
    4 adds in trunk/Source

CodeBlocks should be able to determine bytecode liveness
​https://bugs.webkit.org/show_bug.cgi?id=118546

Reviewed by Filip Pizlo.

This will simplify some things in the DFG related to OSR exits and determining
which bytecode variables are live at which points during execution. It will
also be useful for making our conservative GC scan more precise. Currently it
doesn't properly account for liveness while the DFG is running, so it will be
off by default behing a runtime Options flag.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/BytecodeBasicBlock.cpp: Added.

(JSC::isBranch): Used to determine the end of basic blocks.
(JSC::isUnconditionalBranch): Used to determine when a branch at the end of a
basic block can't possibly fall through to the next basic block in program order.
(JSC::isTerminal): Also used to detect the end of a block.
(JSC::isThrow):
(JSC::isJumpTarget): Used to correctly separate basic blocks. Any jump destination
must be the head of its own basic block.
(JSC::linkBlocks): Links two blocks together in a bi-direcitonal fashion.
(JSC::computeBytecodeBasicBlocks): Creates a set of basic blocks given a particular
CodeBlock and links them together.

  • bytecode/BytecodeBasicBlock.h: Added.

(JSC::BytecodeBasicBlock::isEntryBlock): Entry blocks are a special basic blocks
that indicate the beginning of the function.
(JSC::BytecodeBasicBlock::isExitBlock): Exit blocks are a special basic block that
all blocks that exit the function have as a successor. Entry and exit blocks allows
the various code paths to be more regular.
(JSC::BytecodeBasicBlock::leaderBytecodeOffset): The leader bytecode offset is the
bytecode offset of the first instruction in the block.
(JSC::BytecodeBasicBlock::totalBytecodeLength): The total length of all the bytecodes
in this block.
(JSC::BytecodeBasicBlock::bytecodeOffsets): The bytecode offsets in this particular
basic block. This Vector allows us to iterate over the bytecodes in reverse order
which wouldn't be possible normally since they are of variable size.
(JSC::BytecodeBasicBlock::addPredecessor): Links a block to a specified predecessor.
Only creates one direction of the link.
(JSC::BytecodeBasicBlock::addSuccessor): Same as addPredecessor, but for successors.
(JSC::BytecodeBasicBlock::predecessors): Getter for predecessors.
(JSC::BytecodeBasicBlock::successors): Getter for successors.
(JSC::BytecodeBasicBlock::in): Getter for the liveness info at the head of the block.
(JSC::BytecodeBasicBlock::out): Getter for the liveness info at the tail of the block.
(JSC::BytecodeBasicBlock::BytecodeBasicBlock):
(JSC::BytecodeBasicBlock::addBytecodeLength): When creating basic blocks we call
this function when we want to add the next bytecode in program order to this block.

  • bytecode/BytecodeLivenessAnalysis.cpp: Added.

(JSC::BytecodeLivenessAnalysis::BytecodeLivenessAnalysis):
(JSC::numberOfCapturedVariables): Convenience wrapper. Returns the
number of captured variables for a particular CodeBlock, or 0 if
the CodeBlock has no SymbolTable.
(JSC::captureStart): Ditto, but for captureStart().
(JSC::captureEnd): Ditto, but for captureEnd().
(JSC::isValidRegisterForLiveness): Returns true if the liveness analysis should
track the liveness of a particular operand. We ignore constants, arguments, and
captured variables. We ignore arguments because they're live for the duration of
a function call. We ignore captured variables because we also treat them as live
for the duration of the function. This could probably be improved to be more precise,
but it didn't seem worth it for now.
(JSC::setForOperand): Convenience wrapper that sets the bit in the provided bit
vector for the provided operand. It handles skipping over captured variables.
(JSC::computeUsesForBytecodeOffset): Computes which operands are used by a particular bytecode.
(JSC::computeDefsForBytecodeOffset): Computes which operands are defined by a particular
bytecode. Typically this is just the left-most operand.
(JSC::findBasicBlockWithLeaderOffset):
(JSC::findBasicBlockForBytecodeOffset): Scans over basic blocks to find the block
which contains a particular bytecode offset.
(JSC::computeLocalLivenessForBytecodeOffset): Computes block-local liveness from the
bottom of the block until a specified bytecode offset is reached.
(JSC::computeLocalLivenessForBlock): Computes liveness for the entire block and
stores the resulting liveness at the head.
(JSC::BytecodeLivenessAnalysis::runLivenessFixpoint): Runs backward flow liveness
analysis to fixpoint.
(JSC::BytecodeLivenessAnalysis::getLivenessInfoForNonCapturedVarsAtBytecodeOffset):
Slow path to get liveness info for non-captured, non-argument variable.
(JSC::BytecodeLivenessAnalysis::operandIsLiveAtBytecodeOffset):
(JSC::BytecodeLivenessAnalysis::getLivenessInfoAtBytecodeOffset): Returns the liveness
info for both captured and non-captured vars at a particular bytecode offset.
(JSC::BytecodeLivenessAnalysis::dumpResults): Dumps the output of the liveness analysis.
Controlled by new flag in Options.h/.cpp.
(JSC::BytecodeLivenessAnalysis::compute): Creates bytecode basic blocks and runs
full liveness analysis.

  • bytecode/BytecodeLivenessAnalysis.h: Added.

(JSC::BytecodeLivenessAnalysis::hasBeenComputed):
(JSC::BytecodeLivenessAnalysis::computeIfNecessary):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::livenessAnalysis):

  • bytecode/PreciseJumpTargets.cpp: Refactored to be able to get the jump targets for

a particular bytecode offset for use during bytecode basic block construction.
(JSC::getJumpTargetsForBytecodeOffset):
(JSC::computePreciseJumpTargets):
(JSC::findJumpTargetsForBytecodeOffset):

  • bytecode/PreciseJumpTargets.h:
  • runtime/Options.cpp:

(JSC::Options::initialize):

  • runtime/Options.h:
12:30 PM Changeset in webkit [159135] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

"AVF info: hasOfflineRenderer, board-id check : true" in media/track/track-forced-subtitles-in-band.html
​https://bugs.webkit.org/show_bug.cgi?id=124219

Logging that happens unpredictably underneath us; marking the test as flaky on Mavericks for now.

  • platform/mac/TestExpectations:
12:19 PM Changeset in webkit [159134] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r159129.

  • UIProcess/API/gtk/WebKitFileChooserRequest.cpp:

(webkit_file_chooser_request_select_files): Use ImmutableArray::create() instead.

  • UIProcess/API/gtk/WebKitWebViewGroup.cpp:

(toImmutableArray): Ditto.

12:16 PM Changeset in webkit [159133] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Stop using WKArrayCreate internally
​https://bugs.webkit.org/show_bug.cgi?id=124217

Reviewed by Andreas Kling.

  • UIProcess/API/mac/WKBrowsingContextGroup.mm:

(createWKArray):
(-[WKBrowsingContextGroup addUserStyleSheet:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:mainFrameOnly:]):
(-[WKBrowsingContextGroup addUserScript:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:injectionTime:mainFrameOnly:]):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageCopyContextMenuItems):

12:05 PM Changeset in webkit [159132] by stavila@adobe.com
  • 1 edit
    2 adds in trunk/LayoutTests

Created test for testing repaint rects for elements inside relative-positioned regions.

[CSS Regions] clip rectangles are incorrectly computed in some positioned elements
​https://bugs.webkit.org/show_bug.cgi?id=114722

Reviewed by Mihnea Ovidenie.

  • fast/repaint/increasing-region-content-height-expected.txt: Added.
  • fast/repaint/increasing-region-content-height.html: Added.
11:40 AM Changeset in webkit [159131] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit2

URTBF after r159129, use create() instead of adopt() everywhere.

  • UIProcess/WebGrammarDetail.cpp:

(WebKit::WebGrammarDetail::guesses):

  • UIProcess/efl/WebUIPopupMenuClient.cpp:

(WebUIPopupMenuClient::showPopupMenu):

11:40 AM Changeset in webkit [159130] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

After ​http://trac.webkit.org/changeset/159109, update
rebaseline_unittest to use the new GTK bot names.

  • Scripts/webkitpy/tool/commands/rebaseline_unittest.py:

(TestRebaselineTest.test_baseline_directory):

11:24 AM Changeset in webkit [159129] by andersca@apple.com
  • 25 edits in trunk/Source/WebKit2

Simplify ImmutableArray creation
​https://bugs.webkit.org/show_bug.cgi?id=124213

Reviewed by Andreas Kling.

Get rid of the various ImmutableArray::adopt functions and have a single create function instead.
Use std::move to avoid unnecessarily copying vector data.

  • Shared/API/c/WKArray.cpp:

(WKArrayCreate):
(WKArrayCreateAdoptingValues):

  • Shared/Cocoa/WKNSArray.mm:

(-[WKNSArray copyWithZone:]):

  • Shared/ImmutableArray.cpp:

(WebKit::ImmutableArray::create):
(WebKit::ImmutableArray::createStringArray):
(WebKit::ImmutableArray::ImmutableArray):

  • Shared/ImmutableArray.h:

(WebKit::ImmutableArray::at):
(WebKit::ImmutableArray::size):
(WebKit::ImmutableArray::entries):

  • Shared/ImmutableDictionary.cpp:

(WebKit::ImmutableDictionary::keys):

  • Shared/MutableArray.cpp:

(WebKit::MutableArray::MutableArray):
(WebKit::MutableArray::append):
(WebKit::MutableArray::reserveCapacity):
(WebKit::MutableArray::removeItemAtIndex):

  • Shared/SecurityOriginData.cpp:

(WebKit::performAPICallbackWithSecurityOriginDataVector):

  • Shared/UserMessageCoders.h:

(WebKit::UserMessageDecoder::baseDecode):

  • Shared/WebArchive.cpp:

(WebKit::WebArchive::subresources):
(WebKit::WebArchive::subframeArchives):

  • Shared/WebContextMenuItem.cpp:

(WebKit::WebContextMenuItem::submenuItemsAsImmutableArray):

  • UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextGetInfoForInstalledPlugIns):

  • UIProcess/StatisticsRequest.cpp:

(WebKit::StatisticsRequest::completedRequest):

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::backListAsImmutableArrayWithLimit):
(WebKit::WebBackForwardList::forwardListAsImmutableArrayWithLimit):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):

  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):

  • UIProcess/WebKeyValueStorageManager.cpp:

(WebKit::didGetKeyValueStorageOrigins):

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::didChangeBackForwardList):

  • UIProcess/WebPageContextMenuClient.cpp:

(WebKit::WebPageContextMenuClient::showContextMenu):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::relatedPages):
(WebKit::WebPageProxy::didFindStringMatches):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::originsWithApplicationCache):

  • WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp:

(WebKit::InjectedBundleBackForwardListItem::children):

  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:

(WebKit::InjectedBundlePageFormClient::didAssociateFormControls):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::childFrames):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::trackedRepaintRects):

11:21 AM Changeset in webkit [159128] by timothy_horton@apple.com
  • 2 edits in trunk/LayoutTests

Fix accessibility/aria-help after r159067.

It's failing everywhere because the path to its script is wrong.

  • accessibility/aria-help.html:
11:18 AM Changeset in webkit [159127] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

The last URTBF after r159108 to make GTK happy.

  • GNUmakefile.am:
11:06 AM Changeset in webkit [159126] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

One more URTBF after r159108, I hope the last one.

  • GNUmakefile.am:
11:01 AM Changeset in webkit [159125] by aestes@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

[iOS] Define JSC_OBJC_API_ENABLED
​https://bugs.webkit.org/show_bug.cgi?id=124192

Reviewed by Geoffrey Garen.

  • API/JSBase.h: JSC_OBJC_API_ENABLED should evaluate to true if

TARGET_OS_IPHONE is true.

  • API/JSValue.h: Ensure CG types referenced later in the file are defined.
10:55 AM Changeset in webkit [159124] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Remote Layer Tree: Assertions during layer flushing after replaceSublayer()
​https://bugs.webkit.org/show_bug.cgi?id=124194

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::replaceSublayer):
Only remove the old layer from the children array once (via removeFromSuperlayer).
Update the superlayer backpointer on the new layer.

10:32 AM Changeset in webkit [159123] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

Add ImmutableArray::createStringArray
​https://bugs.webkit.org/show_bug.cgi?id=124210

Reviewed by Andreas Kling.

Creating an ImmutableArray of WebStrings is a common operation, so add a
helper function to ImmutableArray that does this from a Vector of Strings.

  • Shared/ImmutableArray.cpp:

(WebKit::ImmutableArray::createStringArray):

  • Shared/ImmutableArray.h:
  • Shared/ImmutableDictionary.cpp:

(WebKit::ImmutableDictionary::keys):

  • Shared/WebOpenPanelParameters.cpp:

(WebKit::WebOpenPanelParameters::acceptMIMETypes):
(WebKit::WebOpenPanelParameters::selectedFileNames):

  • UIProcess/Plugins/WebPluginSiteDataManager.cpp:

(WebKit::WebPluginSiteDataManager::didGetSitesWithData):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::didGetHostnamesWithCookies):

  • UIProcess/WebMediaCacheManagerProxy.cpp:

(WebKit::WebMediaCacheManagerProxy::didGetHostnamesWithMediaCache):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::featuresUsedInPage):

10:22 AM Changeset in webkit [159122] by alex.christensen@flexsim.com
  • 7 edits in trunk/Source

[WinCairo] Preparation for ENABLE(VIDEO).
​https://bugs.webkit.org/show_bug.cgi?id=57420

Reviewed by Martin Robinson.

Source/WebCore:

  • platform/FileSystem.h:
  • platform/graphics/MediaPlayer.cpp:
  • rendering/RenderMediaControls.cpp:
  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::adjustSliderThumbSize):
Separated CG code from GStreamer code.

Source/WebKit/win:

  • FullscreenVideoController.cpp:

Don't compile if using GStreamer.

10:19 AM Changeset in webkit [159121] by akling@apple.com
  • 3 edits in trunk/PerformanceTests

Remove body onload handler from html5-8266.html that was causing
the test to sometimes finish before doing anything interesting.

Unskip Parser/HTML5-8266-FullRender.html now that it's stable.

Rubber-stamped by Antti Koivisto.

  • Parser/resources/html5-8266.html:
  • Skipped:
9:56 AM Changeset in webkit [159120] by Michał Pakuła vel Rutka
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Skip media/media-source tests, as EFL port does not support MEDIA_SOURCE.

  • platform/efl/TestExpectations:
9:55 AM Changeset in webkit [159119] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix reported build warnings for GTK
​https://bugs.webkit.org/show_bug.cgi?id=123439

Patch by Tibor Meszaros <​mtibor@inf.u-szeged.hu> on 2013-11-12
Reviewed by Carlos Garcia Campos.

There was a void method, that has return value in it's documentation, so I removed it.

  • bindings/gobject/WebKitDOMCustom.h:
9:51 AM Changeset in webkit [159118] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

One more URTBF after r159108.

  • GNUmakefile.am:
9:40 AM Changeset in webkit [159117] by andersca@apple.com
  • 19 edits in trunk/Source/WebKit2

Begin cleaning up handling of ImmutableArray vectors
​https://bugs.webkit.org/show_bug.cgi?id=124208

Reviewed by Andreas Kling.

Use range based for to iterate the loops. Use reserveInitialCapacity + uncheckedAppend
when appending vector elements.

  • Shared/SecurityOriginData.cpp:

(WebKit::performAPICallbackWithSecurityOriginDataVector):

  • Shared/WebArchive.cpp:

(WebKit::WebArchive::subresources):
(WebKit::WebArchive::subframeArchives):

  • Shared/WebContextMenuItem.cpp:

(WebKit::WebContextMenuItem::submenuItemsAsImmutableArray):

  • Shared/WebOpenPanelParameters.cpp:

(WebKit::WebOpenPanelParameters::acceptMIMETypes):
(WebKit::WebOpenPanelParameters::selectedFileNames):

  • UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextGetInfoForInstalledPlugIns):

  • UIProcess/Plugins/WebPluginSiteDataManager.cpp:

(WebKit::WebPluginSiteDataManager::didGetSitesWithData):

  • UIProcess/StatisticsRequest.cpp:

(WebKit::StatisticsRequest::completedRequest):

  • UIProcess/WebContext.cpp:

(WebKit::WebContext::pluginInfoStoreDidLoadPlugins):

  • UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::didGetHostnamesWithCookies):

  • UIProcess/WebDatabaseManagerProxy.cpp:

(WebKit::WebDatabaseManagerProxy::didGetDatabasesByOrigin):
(WebKit::WebDatabaseManagerProxy::didGetDatabaseOrigins):

  • UIProcess/WebMediaCacheManagerProxy.cpp:

(WebKit::WebMediaCacheManagerProxy::didGetHostnamesWithMediaCache):

  • UIProcess/WebPageContextMenuClient.cpp:

(WebKit::WebPageContextMenuClient::showContextMenu):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::relatedPages):
(WebKit::WebPageProxy::didFindStringMatches):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::originsWithApplicationCache):

  • WebProcess/InjectedBundle/InjectedBundleBackForwardListItem.cpp:

(WebKit::InjectedBundleBackForwardListItem::children):

  • WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:

(WebKit::InjectedBundlePageFormClient::didAssociateFormControls):

  • WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:

(WebKit::InjectedBundlePageLoaderClient::featuresUsedInPage):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::trackedRepaintRects):

9:38 AM Changeset in webkit [159116] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Fix undefined reference issues in JavaScriptCore build.
​https://bugs.webkit.org/show_bug.cgi?id=124152

Patch by Balazs Kilvady <​kilvadyb@homejinni.com> on 2013-11-12
Reviewed by Michael Saboff.

Missing includes added.

  • runtime/SymbolTable.cpp:
9:33 AM Changeset in webkit [159115] by zandobersek@gmail.com
  • 7 edits in trunk/Source/WebCore

Manage StorageThread through std::unique_ptr
​https://bugs.webkit.org/show_bug.cgi?id=124197

Reviewed by Anders Carlsson.

New StorageThread objects are crafted through std::make_unique. This removes the need for the static
StorageThread::create() method but requires that the StorageThread constructor is made public.

  • storage/StorageSyncManager.cpp:

(WebCore::StorageSyncManager::StorageSyncManager):

  • storage/StorageSyncManager.h:
  • storage/StorageThread.cpp:
  • storage/StorageThread.h:
  • storage/StorageTracker.cpp:

(WebCore::StorageTracker::StorageTracker):

  • storage/StorageTracker.h:
9:30 AM Changeset in webkit [159114] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebCore

Remove unnecessary PassOwnPtr.h header includes under Source/WebCore/fileapi
​https://bugs.webkit.org/show_bug.cgi?id=124196

Reviewed by Anders Carlsson.

PassOwnPtr is not used anywhere under Source/WebCore/fileapi/, so PassOwnPtr.h inclusions can be removed.

  • fileapi/Blob.h:
  • fileapi/FileThread.h:
  • fileapi/FileThreadTask.h:
9:25 AM Changeset in webkit [159113] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK gardening.

  • platform/gtk/js/dom/global-constructors-attributes-expected.txt: Rebaseline after new constructors

were made available with enabling the Media Stream feature.

8:28 AM Changeset in webkit [159112] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

One more URTBF after r159108.

  • CMakeLists.txt:
8:16 AM Changeset in webkit [159111] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit2

URTBF after r159108.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
7:41 AM Changeset in webkit [159110] by Alexandru Chiculita
  • 5 edits
    12 adds in trunk

Web Inspector: Crash when closing the Inspector while debugging an exception inside a breakpoint condition.
​https://bugs.webkit.org/show_bug.cgi?id=124078

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

The crash would happen because the Debugger is not designed to support nested
breaks. For example, when the debugger handles a breakpoint and the Inspector
executes a console command that would hit the breakpoint again, the Debugger
will just ignore the breakpoint.

There were no checks for conditions and actions. Because of that conditions and actions
could trigger exceptions and breakpoints. This patch disables that functionality as it
cannot be supported without a bigger rewrite of the code.

  • debugger/Debugger.cpp:

(JSC::TemporaryPausedState::TemporaryPausedState):
(JSC::TemporaryPausedState::~TemporaryPausedState):
(JSC::Debugger::hasBreakpoint):
(JSC::Debugger::pauseIfNeeded):

  • debugger/Debugger.h:

LayoutTests:

Checking that the debugger will not crash nor stall when exceptions are throw while the debugger
is already paused. The cases when that can happen include breakpoint conditions, actions, eval
or runtime object inspection.

The current behavior was to ignore the exceptions or breakpoints while executing "console commands"
when the debugger was already paused. I'm extending this mechanism to breakpoint conditions and
actions as the Debugger is not designed to support nested "debugger breaks".

  • http/tests/inspector-protocol/resources/protocol-test.js:

(closeTest): Avoid having internals.closeDummyInspectorFrontend and testRunner.notifyDone
in the same function. The debugger will not have a chance to exit the temporary EventLoop
before loading the next test.

  • inspector-protocol/debugger/breakpoint-action-detach-expected.txt: Added.
  • inspector-protocol/debugger/breakpoint-action-detach.html: Added.
  • inspector-protocol/debugger/breakpoint-action-with-exception-expected.txt: Added.
  • inspector-protocol/debugger/breakpoint-action-with-exception.html: Added.
  • inspector-protocol/debugger/breakpoint-condition-detach-expected.txt: Added.
  • inspector-protocol/debugger/breakpoint-condition-detach.html: Added.
  • inspector-protocol/debugger/breakpoint-condition-with-exception-expected.txt: Added.
  • inspector-protocol/debugger/breakpoint-condition-with-exception.html: Added.
  • inspector-protocol/debugger/breakpoint-eval-with-exception-expected.txt: Added.
  • inspector-protocol/debugger/breakpoint-eval-with-exception.html: Added.
  • inspector-protocol/debugger/breakpoint-inside-conditons-and-actions-expected.txt: Added.
  • inspector-protocol/debugger/breakpoint-inside-conditons-and-actions.html: Added.
7:23 AM Changeset in webkit [159109] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Update GTK builders in Tools/Scripts/webkitpy/port/builders.py
​https://bugs.webkit.org/show_bug.cgi?id=124144

Patch by Denis Nomiyama <​d.nomiyama@samsung.com> on 2013-11-12
Reviewed by Gustavo Noronha Silva.

Updated the list of GTK builders in Tools/Scripts/webkitpy/port/builders.py
according to ​http://build.webkit.org/builders.

  • Scripts/webkitpy/port/builders.py:
7:21 AM Changeset in webkit [159108] by andersca@apple.com
  • 2 edits
    2 moves
    1 add in trunk/Source/WebKit2

Move StringReference to Platform/IPC
​https://bugs.webkit.org/show_bug.cgi?id=124203

Reviewed by Antti Koivisto.

  • Platform/IPC/StringReference.cpp: Renamed from Source/WebKit2/Platform/CoreIPC/StringReference.cpp.

(CoreIPC::StringReference::toString):
(CoreIPC::StringReference::encode):
(CoreIPC::StringReference::decode):
(CoreIPC::StringReference::Hash::hash):

  • Platform/IPC/StringReference.h: Renamed from Source/WebKit2/Platform/CoreIPC/StringReference.h.

(CoreIPC::StringReference::StringReference):
(CoreIPC::StringReference::isEmpty):
(CoreIPC::StringReference::size):
(CoreIPC::StringReference::data):
(CoreIPC::StringReference::operator==):
(CoreIPC::StringReference::Hash::equal):

  • WebKit2.xcodeproj/project.pbxproj:
6:56 AM WebKitGTK/2.2.x edited by mario@webkit.org
SVN r157631 is not actually needed to be merged since the problem it … (diff)
6:56 AM Changeset in webkit [159107] by mario@webkit.org
  • 1 edit
    2 deletes in trunk/LayoutTests

Unreviewed GTK gardening. Share expectations for vertical text among WK1 and WK2.

  • platform/gtk-wk2/fast/repaint/japanese-rl-selection-clear-expected.txt: Removed.
  • platform/gtk-wk2/fast/repaint/japanese-rl-selection-repaint-expected.txt: Removed.
  • platform/gtk-wk2/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Removed.
  • platform/gtk-wk2/fast/text/international/vertical-text-glyph-test-expected.txt: Removed.
  • platform/gtk-wk2/fast/text/justify-ideograph-vertical-expected.txt: Removed.
6:53 AM Changeset in webkit [159106] by Michał Pakuła vel Rutka
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Mark 73 tests as failing/skipped after r158954.

  • platform/efl/TestExpectations:
6:44 AM Changeset in webkit [159105] by Antti Koivisto
  • 4 edits
    2 adds in trunk

Text on simple lines sometimes paints one pixel off
​https://bugs.webkit.org/show_bug.cgi?id=124200

Reviewed by Andreas Kling.

Source/WebCore:

Test: fast/text/line-runs-simple-lines.html

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::adjustRunOffsets):

Don't round on run construction time.

(WebCore::SimpleLineLayout::createTextRuns):

  • rendering/SimpleLineLayoutResolver.h:

(WebCore::SimpleLineLayout::RunResolver::Run::rect):

Instead round when generating rects.

(WebCore::SimpleLineLayout::RunResolver::Run::baseline):

Provide the baseline (used by painting) as unrounded FloatPoint.

LayoutTests:

  • fast/text/line-runs-rounding-simple-lines-expected.html: Added.
  • fast/text/line-runs-rounding-simple-lines.html: Added.
6:40 AM Changeset in webkit [159104] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Elements with class names automatically get unique ElementData.
<​https://webkit.org/b/124184>

We were calling Element::ensureUniqueElementData() for all Elements
with a non-empty list of class names. Doing that on parser-fresh
Elements caused us to upgrade them to UniqueElementData despite not
needing it (ElementData::setClass() is a const function for caching
the "cooked" class and can be called on ShareableElementData.)

1.09 MB progression on HTML5 spec at <​http://whatwg.org/c>

Reviewed by Antti Koivisto.

6:13 AM Changeset in webkit [159103] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Webkit - Updated Tamil translation
​https://bugs.webkit.org/show_bug.cgi?id=124142

Patch by Shantha kumar <​shkumar@redhat.com> on 2013-11-12
Reviewed by Gustavo Noronha Silva.

  • ta.po: updated.
6:03 AM Changeset in webkit [159102] by akling@apple.com
  • 3 edits in trunk/PerformanceTests

Neutralize external resource loads in the new HTML5 spec copy.

Skip Parser/HTML5-8266-FullRender.html until I can make it less flaky.

  • Parser/resources/html5-8266.html:
  • Skipped:
1:44 AM Changeset in webkit [159101] by akling@apple.com
  • 1 edit
    3 adds in trunk/PerformanceTests

Import a fresh version of the full HTML5 spec for perf testing.

Rubber-stamped by Antti Koivisto.

  • Parser/HTML5-8266-FullRender.html: Added.
  • Parser/HTML5-8266-ParseOnly.html: Added.
  • Parser/resources/html5-8266.html: Added.
12:33 AM Changeset in webkit [159100] by zandobersek@gmail.com
  • 12 edits
    2 adds
    1 delete in trunk

JSC bindings generator should generate deletable JSC functions
​https://bugs.webkit.org/show_bug.cgi?id=122422

Reviewed by Geoffrey Garen.

Source/WebCore:

The JSC functions that the JSC bindings generator generates should be deletable to conform to
the WebIDL specification, which instructs that the WebIDL operations must be configurable (which
translates to the JSC functions being deletable).

The generator will still produce a non-deletable JSC function for operations under almost all
Web-facing interfaces since they're annotated with the OperationsNotDeletable attribute. The
exception here is the Node interface that is having the attribute removed, with the provided
test case testing that all the functions on the Node prototype object are writable, enumerable
and configurable. This behavior conforms to the WebIDL specification and the behaviors of IE
and Firefox. Chrome at the moment still provides non-configurable functions.

Test: fast/dom/webidl-operations-on-node-prototype.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation): Enforce the non-deletable behavior of the JSC function if either the
operation's interface is annotated with the OperationsNotDeletable attribute or the operation itself
is annotated with the NotDeletable attribute.

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp: Update the JSC generator test baselines.
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestEventTarget.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestInterface.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestObj.cpp: Ditto.
  • bindings/scripts/test/JS/JSTestTypedefs.cpp: Ditto.
  • dom/Node.idl: Remove the OperationsNotDeletable attribute.

LayoutTests:

Test that all the functions on the Node prototype object (apart from the constructor) are
writable, enumerable and configurable, as expected for WebIDL operations. This matches the
WebIDL specification as well as IE and Firefox.

Other affected test cases and baselines are updated to reflect the new behavior.

  • fast/dom/webidl-operations-on-node-prototype-expected.txt: Added.
  • fast/dom/webidl-operations-on-node-prototype.html: Added.
  • js/dom/getOwnPropertyDescriptor-expected.txt:
  • js/resources/getOwnPropertyDescriptor.js:
  • platform/mac/canvas/philip/tests/type.prototype-expected.txt: Removed.
12:21 AM Changeset in webkit [159099] by Csaba Osztrogonác
  • 3 edits in trunk/Source/JavaScriptCore

InvalidIndex shouldn't be private in GPRInfo and FPRInfo for sh4, mips and arm64 architectures.
​https://bugs.webkit.org/show_bug.cgi?id=124156

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-11-12
Reviewed by Michael Saboff.

  • jit/FPRInfo.h:

(JSC::FPRInfo::debugName):

  • jit/GPRInfo.h:

(JSC::GPRInfo::debugName):

Nov 11, 2013:

11:56 PM Changeset in webkit [159098] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Remote Layer Tree: Sporadic memory corruption during painting
​https://bugs.webkit.org/show_bug.cgi?id=124191

Reviewed by Brady Eidson.

Fix a logic error (flipped the logic, didn't flip the operator)
made in the last version of r158982 that caused some crashes because
it allowed us to overrun the end of cgPaintingRects.

  • Shared/mac/RemoteLayerBackingStore.mm:

(RemoteLayerBackingStore::drawInContext):

11:56 PM Changeset in webkit [159097] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

CodeBlock: Un-segment some Vectors.
<​https://webkit.org/b/124188>

Turn some SegmentedVectors into Vectors where the final item count
is known at CodeBlock construction time. This removes unnecessary
allocation and indirection.

I've got ~4.5 MB below SegmentedVector<ValueProfile>::ensureSegment
on Membuster3 (peak, before pressure signal) so this should help
take a bit of the edge off there.

Reviewed by Geoffrey Garen.

10:43 PM Changeset in webkit [159096] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit2

Unreviewed, rolling out r159088.
​http://trac.webkit.org/changeset/159088
​https://bugs.webkit.org/show_bug.cgi?id=124187

It broke the EFL build, because it removed a used function
(rs=thorton) (Requested by Ossy_night on #webkit).

Patch by Commit Queue <​commit-queue@webkit.org> on 2013-11-11

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::resetStateAfterProcessExited):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::urlAtProcessExit):
(WebKit::WebPageProxy::loadStateAtProcessExit):

10:35 PM Changeset in webkit [159095] by beidson@apple.com
  • 7 edits in trunk/Source/WebCore

Make IDBTransaction tasks asynchronous
​https://bugs.webkit.org/show_bug.cgi?id=124183

Reviewed by Tim Horton.

This is an almost zero-change in behavior.

The one thing that is different is that previously, IDBTransactionBackends would synchronously
run through their entire set of IDBOperation’s without ever returning control to the runloop.

Now, they start one task and then wait for its completion to schedule the start of the next task.

Change IDBOperation’s perform() to take a completion handler so it can be asynchronous.
Add an IDBSynchronousOperation class to handle "Abort" tasks, which never need to perform i/o
and therefore can be entirely synchronous.

  • Modules/indexeddb/IDBOperation.h:

(WebCore::IDBSynchronousOperation::~IDBSynchronousOperation):

  • Modules/indexeddb/IDBTransactionBackend.cpp:

(WebCore::IDBTransactionBackend::scheduleTask): "Abort tasks" are now IDBSynchronousOperations.
(WebCore::IDBTransactionBackend::abort):
(WebCore::IDBTransactionBackend::taskTimerFired): Instead of running through the entire set of tasks,

perform a single task asynchronously. The completion handler for the task will reset the task timer
to asynchronously start the next task.

  • Modules/indexeddb/IDBTransactionBackend.h:

(WebCore::IDBTransactionBackend::scheduleTask): "Abort tasks" are now IDBSynchronousOperations.

Update all operations to take completion handlers.
For now, perform things synchronously like before, calling the completion handler when complete.

  • Modules/indexeddb/IDBCursorBackend.cpp:

(WebCore::CallOnDestruct::CallOnDestruct): Helper class to make sure completion callbacks are always called perform() exits.
(WebCore::CallOnDestruct::~CallOnDestruct):
(WebCore::IDBCursorBackend::CursorIterationOperation::create):
(WebCore::IDBCursorBackend::CursorAdvanceOperation::create):
(WebCore::IDBCursorBackend::CursorPrefetchIterationOperation::create):
(WebCore::IDBCursorBackend::CursorAdvanceOperation::perform):
(WebCore::IDBCursorBackend::CursorIterationOperation::perform):
(WebCore::IDBCursorBackend::CursorPrefetchIterationOperation::perform):

  • Modules/indexeddb/IDBTransactionBackendOperations.cpp:

(WebCore::CallOnDestruct::CallOnDestruct): Helper class to make sure completion callbacks are always called when perform() exits.
(WebCore::CallOnDestruct::~CallOnDestruct):
(WebCore::CreateObjectStoreOperation::perform):
(WebCore::CreateIndexOperation::perform):
(WebCore::DeleteIndexOperation::perform):
(WebCore::GetOperation::perform):
(WebCore::PutOperation::perform):
(WebCore::SetIndexesReadyOperation::perform):
(WebCore::OpenCursorOperation::perform):
(WebCore::CountOperation::perform):
(WebCore::DeleteRangeOperation::perform):
(WebCore::ClearOperation::perform):
(WebCore::DeleteObjectStoreOperation::perform):
(WebCore::IDBDatabaseBackend::VersionChangeOperation::perform):

  • Modules/indexeddb/IDBTransactionBackendOperations.h:

(WebCore::CreateObjectStoreOperation::create):
(WebCore::DeleteObjectStoreOperation::create):
(WebCore::IDBDatabaseBackend::VersionChangeOperation::create):
(WebCore::CreateObjectStoreAbortOperation::create):
(WebCore::DeleteObjectStoreAbortOperation::create):
(WebCore::IDBDatabaseBackend::VersionChangeAbortOperation::create):
(WebCore::CreateIndexOperation::create):
(WebCore::CreateIndexAbortOperation::create):
(WebCore::DeleteIndexOperation::create):
(WebCore::DeleteIndexAbortOperation::create):
(WebCore::GetOperation::create):
(WebCore::PutOperation::create):
(WebCore::SetIndexesReadyOperation::create):
(WebCore::OpenCursorOperation::create):
(WebCore::CountOperation::create):
(WebCore::DeleteRangeOperation::create):
(WebCore::ClearOperation::create):

10:15 PM Changeset in webkit [159094] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

URTBF after r159077 to make GTK build happy.

  • GNUmakefile.list.am:
8:39 PM Changeset in webkit [159093] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Remove some unused generated code
​https://bugs.webkit.org/show_bug.cgi?id=124179

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-11
Reviewed by Timothy Hatcher.

  • inspector/CodeGeneratorInspectorStrings.py:
8:39 PM Changeset in webkit [159092] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebCore

Clean up static_cast<Element*> usage
​https://bugs.webkit.org/show_bug.cgi?id=124133

Reviewed by Andreas Kling.

We need to use toFoo cast function instead of static_cast<>. Though there is toElement(),
static_cast<Element*> is still being used.

No new tests, no behavior changes.

  • bindings/gobject/WebKitDOMPrivate.cpp:

(WebKit::wrap):

  • dom/ElementTraversal.h:

(WebCore::::lastWithinTemplate):
(WebCore::::nextTemplate):
(WebCore::::previousTemplate):

7:28 PM Changeset in webkit [159091] by fpizlo@apple.com
  • 21 edits in trunk/Source/JavaScriptCore

Get rid of the lastResultRegister optimization in the baseline JIT
​https://bugs.webkit.org/show_bug.cgi?id=124171

Rubber stamped by Mark Hahnenberg.

The baseline JIT no longer needs amazing throughput. And this optimization has caused
way too many OSR exit bugs. And it constrains how much we can do in the DFG/FTL. So,
I'm getting rid of it.

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::OSRExit::convertToForward):

  • dfg/DFGOSRExit.h:
  • dfg/DFGOSRExitCompiler32_64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGOSRExitCompiler64.cpp:

(JSC::DFG::OSRExitCompiler::compileExit):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):

  • dfg/DFGSpeculativeJIT.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::compileZombieHint):
(JSC::FTL::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::observeMovHint):

  • ftl/FTLOSRExit.cpp:

(JSC::FTL::OSRExit::OSRExit):
(JSC::FTL::OSRExit::convertToForward):

  • ftl/FTLOSRExit.h:
  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • jit/JIT.cpp:

(JSC::JIT::JIT):
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):

  • jit/JIT.h:

(JSC::JIT::appendCall):

  • jit/JITArithmetic32_64.cpp:

(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_inc):
(JSC::JIT::emit_op_dec):

  • jit/JITCall.cpp:

(JSC::JIT::emitPutCallResult):
(JSC::JIT::compileLoadVarargs):

  • jit/JITInlines.h:

(JSC::JIT::emitGetFromCallFrameHeaderPtr):
(JSC::JIT::emitGetFromCallFrameHeader32):
(JSC::JIT::emitGetFromCallFrameHeader64):
(JSC::JIT::emitLoadTag):
(JSC::JIT::emitLoadPayload):
(JSC::JIT::emitLoad2):
(JSC::JIT::emitGetVirtualRegister):
(JSC::JIT::emitGetVirtualRegisters):
(JSC::JIT::emitPutVirtualRegister):

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_mov):
(JSC::JIT::emit_op_catch):
(JSC::JIT::emit_op_new_func):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_mov):
(JSC::JIT::emit_op_to_primitive):
(JSC::JIT::emit_op_to_number):
(JSC::JIT::emit_op_catch):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emit_op_put_to_scope):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_get_by_pname):
(JSC::JIT::emitResolveClosure):
(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emit_op_init_global_const):

  • jit/SlowPathCall.h:

(JSC::JITSlowPathCall::call):

5:55 PM Changeset in webkit [159090] by Gustavo Noronha Silva
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r158976): Web Inspector: unable to start docked or dock
​https://bugs.webkit.org/show_bug.cgi?id=124148

Reviewed by Timothy Hatcher.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorProxy::canAttach): check for a level that is greater than 1 rather than 0
to deny attachment, since 1 is the first level of inspectors.

5:51 PM Changeset in webkit [159089] by andersca@apple.com
  • 8 edits in trunk/Source

FrameFilter can just be an std::function instead
​https://bugs.webkit.org/show_bug.cgi?id=124176

Reviewed by Tim Horton.

Source/WebCore:

  • WebCore.exp.in:
  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

  • loader/archive/cf/LegacyWebArchive.h:

Source/WebKit/mac:

  • DOM/WebDOMOperations.mm:

(-[DOMNode webArchiveByFilteringSubframes:]):

Source/WebKit2:

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::webArchiveData):

5:17 PM Changeset in webkit [159088] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Remove unused Qt cruft
​https://bugs.webkit.org/show_bug.cgi?id=124174

Reviewed by Tim Horton.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::resetStateAfterProcessExited):

  • UIProcess/WebPageProxy.h:
5:15 PM Changeset in webkit [159087] by Lucas Forschler
  • 5 edits in branches/safari-537.73-branch/Source

Versioning.

5:13 PM Changeset in webkit [159086] by Lucas Forschler
  • 1 copy in tags/Safari-537.73.6

New Tag.

5:12 PM Changeset in webkit [159085] by Lucas Forschler
  • 1 copy in tags/Safari-537.73.5/safari-537.73-branch

New Tag.

5:08 PM Changeset in webkit [159084] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r158927): curly-braces-escaping.html is broken on Mac WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=124164

Reviewed by Alexey Proskuryakov.

Back out the change to use NSSecureCoding for encoding/decoding NSURLRequest and
NSURLResponse objects; turns out the NSURL encoding/decoding doesn't preserve the raw URL bytes.

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::encodePlatformData):
(CoreIPC::decodePlatformData):

4:52 PM Changeset in webkit [159083] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix on CMake Based port since r159077.

  • CMakeLists.txt:
4:50 PM Changeset in webkit [159082] by Simon Fraser
  • 5 edits
    2 adds in trunk

REGRESSION (r155660): box-shadow causes overlay scrollbars to be in the wrong position when element is composited (85647)
​https://bugs.webkit.org/show_bug.cgi?id=124090

Source/WebCore:

Reviewed by Beth Dakin.

After r155660 we did fewer layouts, so were left with overlay scrollbars in the
wrong locations because nothing would update them after RenderLayerBacking
computed a new offsetFromRenderer.

First part of the fix is to wean positionOverflowControlsLayers() off of
an absolute offset from the root. Do this by not using Widget::frameRect()
to position the layers, but instead RenderLayer::rectFor{Horizontal|Vertical}Scrollbar
which is what we used to position the scrollbars in the first place.

Second part of the fix is to call positionOverflowControlsLayers() from
RenderLayerBacking::updateGraphicsLayerGeometry() if the offsetFromRenderer
changed.

Test: compositing/overflow/overflow-scrollbar-layer-positions.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::positionOverflowControls):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::positionOverflowControlsLayers):

  • rendering/RenderLayerBacking.h:

LayoutTests:

Reviewed by Beth Dakin.

Test, but it doesn't actually test the fix until we enable overlay scrollbars
in tests (bug 60716).

  • compositing/overflow/overflow-scrollbar-layer-positions-expected.txt: Added.
  • compositing/overflow/overflow-scrollbar-layer-positions.html: Added.
4:33 PM Changeset in webkit [159081] by Brent Fulgham
  • 4 edits in trunk/Source/WebCore

[Win] m_isCompositeFontReference is uninitialized.
​https://bugs.webkit.org/show_bug.cgi?id=124170

Reviewed by Tim Horton.

Initialize value to false, as is done in the other constructors for this data type.

  • platform/graphics/win/FontPlatformDataCGWin.cpp:

(WebCore::FontPlatformData::FontPlatformData):

  • platform/graphics/win/FontPlatformDataCairoWin.cpp:

(WebCore::FontPlatformData::FontPlatformData):

  • platform/graphics/win/FontPlatformDataWin.cpp:

(WebCore::FontPlatformData::FontPlatformData):

4:21 PM Changeset in webkit [159080] by Simon Fraser
  • 2 edits
    1 add in trunk/LayoutTests

Actually land a result for the test that I added (and make it a text test).

  • compositing/tiling/tiled-in-iframe-expected.txt: Added.
  • compositing/tiling/tiled-in-iframe.html:
4:20 PM Changeset in webkit [159079] by timothy_horton@apple.com
  • 5 edits in trunk/Source/WebKit2

Remote Layer Tree: Implement Page Overlays
​https://bugs.webkit.org/show_bug.cgi?id=124165
<rdar://problem/15199056>

Reviewed by Anders Carlsson.

Implement page overlays, very similar to how they work in TiledCoreAnimationDrawingArea,
but manipulating the PlatformCALayer tree instead of the CALayer tree directly.

  • WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeContext.mm:

(WebKit::RemoteLayerTreeContext::outOfTreeLayerWasAdded):
(WebKit::RemoteLayerTreeContext::outOfTreeLayerWillBeRemoved):
(WebKit::RemoteLayerTreeContext::flushLayers):
Add a list of out-of-tree GraphicsLayers which are flushed in addition
to the page's GraphicsLayer tree, and functions to manipulate this list.

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:

Make RemoteLayerTreeDrawingArea a GraphicsLayerClient, so we can get callbacks
from the GraphicsLayers that drive our page overlays.
Override the relevant page overlay functions.
Add storage for the root layer, view size, and a map of PageOverlay->GraphicsLayer.

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::setRootCompositingLayer):
Store the root GraphicsLayer for later use.

(WebKit::RemoteLayerTreeDrawingArea::updateGeometry):
Update the size of the page overlays when the DrawingArea's geometry changes.

(WebKit::RemoteLayerTreeDrawingArea::updatePreferences):
Update the page overlay settings when necessary.

(WebKit::RemoteLayerTreeDrawingArea::didInstallPageOverlay):
Create a GraphicsLayer for our page overlay, set it up, and parent it.
Inform the RemoteLayerTreeContext that it will need to flush this GraphicsLayer,
since it's not a part of the page's GraphicsLayer tree.

(WebKit::RemoteLayerTreeDrawingArea::didUninstallPageOverlay):
Tear down our page overlay's GraphicsLayer.

(WebKit::RemoteLayerTreeDrawingArea::setPageOverlayNeedsDisplay):
(WebKit::RemoteLayerTreeDrawingArea::setPageOverlayOpacity):
(WebKit::RemoteLayerTreeDrawingArea::paintContents):
(WebKit::RemoteLayerTreeDrawingArea::deviceScaleFactor):

4:19 PM Changeset in webkit [159078] by Lucas Forschler
  • 1 edit in branches/safari-537.73-branch/Tools/ChangeLog

svn auth test.

3:32 PM Changeset in webkit [159077] by andersca@apple.com
  • 7 edits
    2 adds in trunk/Source/WebKit2

Add a FrameLoadState object and begin moving loading related members from WebFrameProxy
​https://bugs.webkit.org/show_bug.cgi?id=124163

Reviewed by Beth Dakin.

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameGetFrameLoadState):

  • UIProcess/FrameLoadState.cpp: Added.

(WebKit::FrameLoadState::FrameLoadState):
(WebKit::FrameLoadState::~FrameLoadState):

  • UIProcess/FrameLoadState.h: Added.
  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::WebFrameProxy):
(WebKit::WebFrameProxy::didStartProvisionalLoad):
(WebKit::WebFrameProxy::didReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameProxy::didFailProvisionalLoad):
(WebKit::WebFrameProxy::didCommitLoad):
(WebKit::WebFrameProxy::didFinishLoad):
(WebKit::WebFrameProxy::didFailLoad):
(WebKit::WebFrameProxy::didSameDocumentNavigation):
(WebKit::WebFrameProxy::setUnreachableURL):

  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::frameLoadState):
(WebKit::WebFrameProxy::loadState):
(WebKit::WebFrameProxy::url):
(WebKit::WebFrameProxy::provisionalURL):
(WebKit::WebFrameProxy::unreachableURL):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::activeURL):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::loadStateAtProcessExit):

  • WebKit2.xcodeproj/project.pbxproj:
3:31 PM Changeset in webkit [159076] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

[Mac] Characters too close together in complex Arabic text
​https://bugs.webkit.org/show_bug.cgi?id=124057

Patch by Myles C. Maxfield <​mmaxfield@apple.com> on 2013-11-11
Reviewed by Darin Adler.

Source/WebCore:

We weren't updating our total width variable with run's initial
advance information, leading to widths that were too narrow.

In addition, while initial advances for runs that aren't the first
run are accounted for by baking in the initial advances into the
previous character's advance, the initial advance for the first run
has to be accounted for in ComplexTextController::offsetForPosition.

Test: fast/text/complex-grapheme-cluster-with-initial-advance.html
Test: fast/text/selection-in-initial-advance-region.html

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Update
total width variable
(WebCore::ComplexTextController::offsetOfPosition): Account for
the first run's initial advance.

LayoutTests:

complex-grapheme-cluster-with-initial-advance adds a span around a word in some
complex Arabic text, and expects that the word spacing is the same as without the
span.

selection-in-initial-advance-region simulates a mouse drag across a complex text run
with an initial advance. This makes sure that ComplexTextController::offsetForPosition
doesn't crash when there is an initial advance.

  • fast/text/complex-grapheme-cluster-with-initial-advance-expected.html: Added.
  • fast/text/complex-grapheme-cluster-with-initial-advance.html: Added.
  • fast/text/selection-in-initial-advance-region-expected.txt: added
  • fast/text/selection-in-initial-advance-region.html: added
3:29 PM Changeset in webkit [159075] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Remove #include from test input of the *Messages.in processing scripts.
​https://bugs.webkit.org/show_bug.cgi?id=123563

Patch by Gergo Balogh <​geryxyz@inf.u-szeged.hu> on 2013-11-11
Reviewed by Darin Adler.

  • Scripts/webkit2/messages_unittest.py:
3:01 PM Changeset in webkit [159074] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Remove ConstantFoldingPhase's weirdo compile-time optimization
​https://bugs.webkit.org/show_bug.cgi?id=124169

Reviewed by Mark Hahnenberg.

It turns out that this compile-time optimization doesn't optimize compile times
anymore. Kill it with fire.

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

2:47 PM Changeset in webkit [159073] by alex.christensen@flexsim.com
  • 2 edits in trunk/Source/WebKit

Unreviewed build fix for Win64.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Fixed 64-bit linker symbols.

2:41 PM Changeset in webkit [159072] by beidson@apple.com
  • 7 edits in trunk/Source/WebCore

Make IDBBackingStoreTransaction be RefCounted
​https://bugs.webkit.org/show_bug.cgi?id=124168

Reviewed by Tim Horton.

This is necessarily to safely add a fully asynchronous interface into the IDB mechanism.

  • Modules/indexeddb/IDBBackingStoreInterface.h:
  • Modules/indexeddb/IDBBackingStoreTransactionInterface.h:
  • Modules/indexeddb/IDBTransactionBackend.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:

(WebCore::IDBBackingStoreLevelDB::createBackingStoreTransaction):

  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreTransactionLevelDB.h:
2:39 PM Changeset in webkit [159071] by Antti Koivisto
  • 9 edits
    2 adds in trunk

End of line whitespace should collapse with white-space:pre-wrap; overflow-wrap:break-word in all cases
​https://bugs.webkit.org/show_bug.cgi?id=124158

Source/WebCore:

Reviewed by Dave Hyatt.

If a word just fits the line but the following space overflows we fail to collapse whitespaces
at the end of the line. This happens because with break-word we end up taking word breaking
code path that does not have pre-wrap whitespace handling.

This patch makes the behavior consistent and also matches Firefox.

Test: fast/text/break-word-pre-wrap.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::BreakingContext::handleText):

Don't take the word break code path if we are pre-wrap and the current character is space.
Instead proceed to break the line normally as this is a valid break position.

LayoutTests:

Reviewed by Dave Hyatt.

Added a specific test and updates the test results of some complex tests that demonstrate the same issue.

  • fast/text/break-word-pre-wrap-expected.html: Added.
  • fast/text/break-word-pre-wrap.html: Added.
  • platform/mac/fast/forms/basic-textareas-expected.png:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.png:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/mac-mountainlion/fast/forms/basic-textareas-expected.txt:
  • platform/mac-mountainlion/fast/forms/basic-textareas-quirks-expected.txt:
2:25 PM Changeset in webkit [159070] by betravis@adobe.com
  • 9 edits
    3 adds in trunk

Web Inspector: [CSS Shapes] Highlight shape-outside when its element is selected in the Web Inspector
​https://bugs.webkit.org/show_bug.cgi?id=124071

Reviewed by Timothy Hatcher.

Source/WebCore:

Adding code to pass computed shape information (path and bounds) to the Inspector overlay
canvas, and the code to display it. The code creates a path based on ShapeInfo's computed
shape. The shape highlight draws whenever an element is highlighted, via selection in
the Inspector elements view.

Test: inspector-protocol/model/highlight-shape-outside.html

  • inspector/InspectorOverlay.cpp:

(WebCore::localPointToRoot): Convert a local point to be relative to the root view.
(WebCore::appendPathCommandAndPoints): Helper for building a single segment's worth
of the overall path.
(WebCore::appendPathSegment): Build a single segment's worth of the overall path.
(WebCore::buildObjectForShapeOutside): Build an object to pass to the Inspector overlay
that represents the shape.
(WebCore::buildObjectForElementInfo): Call buildObjectForShapeOutside and pass the
resulting object along.

  • inspector/InspectorOverlayPage.js:

(pathCommand): Draw a single path command.
(drawPath): Draw the overall path.
(_drawShapeHighlight): Draw the highlight for the given shapeInfo.
(drawNodeHighlight): Call _drawShapeHighlight.

  • rendering/shapes/PolygonShape.h:

(WebCore::PolygonShape::polygon): Expose the underlying vertex information for a
PolygonShape.

  • rendering/shapes/RasterShape.h:
  • rendering/shapes/RectangleShape.h:

(WebCore::RectangleShape::logicalRx): Expose the logical radii for a shape.
(WebCore::RectangleShape::logicalRy): Ditto.

  • rendering/shapes/Shape.h:
  • rendering/shapes/ShapeInfo.h:

(WebCore::ShapeInfo::computedShapePhysicalBoundingBox): The physical bounds of a
shape in renderer coordinates.
(WebCore::ShapeInfo::shapeToRendererPoint): Convert shape coordinates to renderer
coordinates.
(WebCore::ShapeInfo::shapeToRendererSize): Ditto.
(WebCore::ShapeInfo::ShapeInfo):

LayoutTests:

Test that the information passed to the Inspector overlay properly corresponds to the
underlying shape. Retrieving the shape highlight information involves a series of
steps and has been abstracted into shape-info-helper.js, which supplies
Inspector.shapeOutsideInfo inside an Inspector test, and the ShapeInfoHelper.runShapesTest
method to begin a test.

  • inspector-protocol/model/highlight-shape-outside-expected.txt: Added.
  • inspector-protocol/model/highlight-shape-outside.html: Added.
  • inspector-protocol/resources/shape-info-helper.js: Added.

(window.ShapeInfoHelper): Exposes ShapeInfoHelper.runShapesTest.

1:46 PM Changeset in webkit [159069] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Make bytecode dumping use the right opcode names for inc/dec.

Rubber stamped by Mark Hahnenberg.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):

1:20 PM Changeset in webkit [159068] by ap@apple.com
  • 7 edits
    4 copies in trunk/Source/WebCore

Support WebCrypto KeyPair interface
​https://bugs.webkit.org/show_bug.cgi?id=124161

Reviewed by Geoffrey Garen.

No new tests yet, will be tested once generateKey is implemented for any RSA algorithms.

  • CMakeLists.txt:
  • DerivedSources.make:
  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:

Added new files.

  • bindings/js/JSDOMPromise.h: Support returning a key pair via a promise.
  • bindings/js/JSCryptoKeyPairCustom.cpp: Added.

(WebCore::JSCryptoKeyPair::visitChildren):

  • crypto/CryptoKey.idl:

CryptoKey wrapper is reachable through KeyPair, but it doesn't have (or need)
a back pointer.

  • crypto/CryptoKeyPair.cpp: Added.

(WebCore::CryptoKeyPair::CryptoKeyPair):
(WebCore::CryptoKeyPair::~CryptoKeyPair):

  • crypto/CryptoKeyPair.h: Added.

(WebCore::CryptoKeyPair::create):
(WebCore::CryptoKeyPair::publicKey):
(WebCore::CryptoKeyPair::privateKey):

  • crypto/CryptoKeyPair.idl: Added.
1:09 PM Changeset in webkit [159067] by Samuel White
  • 3 edits
    1 move in trunk

AX: support helpText() in DumpRenderTree
​https://bugs.webkit.org/show_bug.cgi?id=40194

Reviewed by Chris Fleizach.

Tools:

Implemented stubbed helpText methods so we can move aria-help.html back to LayoutTests/accessibility.

  • DumpRenderTree/win/AccessibilityUIElementWin.cpp:

(AccessibilityUIElement::helpText):

LayoutTests:

Moving layout test back to its original location. Shouldn't be platform specific.

  • accessibility/aria-help.html: Renamed from LayoutTests/platform/mac/accessibility/aria-help.html.
1:05 PM Changeset in webkit [159066] by Michał Pakuła vel Rutka
  • 6 edits in trunk/LayoutTests

Unreviewed EFL gardening

Update test expectations after r158188.

  • platform/efl/css2.1/t0804-c5507-padn-r-00-c-ag-expected.png:
  • platform/efl/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
  • platform/efl/css2.1/t0804-c5509-padn-l-00-b-ag-expected.png:
  • platform/efl/css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt:
  • platform/efl/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
1:04 PM Changeset in webkit [159065] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix build after r158967
​https://bugs.webkit.org/show_bug.cgi?id=124160

Patch by Nick Diego Yamane <​nick.yamane@openbossa.org> on 2013-11-11
Reviewed by Anders Carlsson.

After r158967, gcc debug builds with "-Werror=type-limits" enabled
fail. This patch fixes it.

  • rendering/shapes/RasterShape.h:

(WebCore::RasterShapeIntervals::intervalsAt):

12:57 PM Changeset in webkit [159064] by fpizlo@apple.com
  • 5 edits
    3 adds in trunk

DFG Int52 boxing code may clobber the source without telling anyone
​https://bugs.webkit.org/show_bug.cgi?id=124137

Source/JavaScriptCore:

Reviewed by Mark Hahnenberg.

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::boxInt52): This is called in places where source is expected to be unchanged. We never call this expecting super-amazing codegen. So, preserve the source's value the dumb way (by recovering it mathematically).

  • jit/AssemblyHelpers.h: Document the invariant for boxInt52.
  • jsc.cpp:

(GlobalObject::finishCreation): It's been super annoying that sometimes we say noInline() and sometimes we say neverInlineFunction(). The LayoutTests harnesses ensure that we have something called noInline(), but it's great to also ensure that the shell has it.

LayoutTests:

Reviewed by Mark Hahnenberg.

Write the test as a JSRegress test because we currently need a couple
recompiles to get the bug. JSRegress tests are meant to be longer-running
stress tests and they are usually run with different compilation thresholds, so
that ensures that we will actually hit the relevant code path.

  • js/regress/int52-spill-expected.txt: Added.
  • js/regress/int52-spill.html: Added.
  • js/regress/script-tests/int52-spill.js: Added.

(bar):
(foo):

12:53 PM Changeset in webkit [159063] by oliver@apple.com
  • 9 edits in trunk

ExtJS breaks with modern Array.prototype.values API due to use of with()
​https://bugs.webkit.org/show_bug.cgi?id=123440

Reviewed by Beth Dakin.

Source/JavaScriptCore:

As with our attempt to make Arguments use the Array prototype, ExtJS has
a weird dependency on not adding new APIs to core types. In this case
Array.prototype.values. The fix is to remove it, and push for ES6 to drop
the API.

  • runtime/ArrayPrototype.cpp:

LayoutTests:

Update tests for removal of Array.prototype.values, and add test to ensure that
it's gone.

  • js/Object-getOwnPropertyNames-expected.txt:
  • js/array-iterators-expected.txt:
  • js/basic-for-of-expected.txt:
  • js/script-tests/Object-getOwnPropertyNames.js:
  • js/script-tests/array-iterators.js:
  • js/script-tests/basic-for-of.js:
12:17 PM Changeset in webkit [159062] by oliver@apple.com
  • 2 edits in trunk/LayoutTests

Fix layout test

11:58 AM Changeset in webkit [159061] by zandobersek@gmail.com
  • 238 edits in trunk/Source/WebCore

Remove the OperationsNotDeletable attribute from most of the WebIDL interfaces
​https://bugs.webkit.org/show_bug.cgi?id=124151

Reviewed by Geoffrey Garen.

The OperationsNotDeletable attribute currently doesn't have any effect, but will soon enforce
non-configurability of operations on the interface that uses the attribute. Non-configurability
of operations is the default behavior at the moment, but will be changed to follow the WebIDL
specification which requires that the operations are configurable (i.e. -- in JSC terms -- deletable).
IE and Firefox already exhibit this behavior in the majority of cases, while Chrome and Opera don't.

The attribute remains in use on the Location interface to mimic the Unforgeable attribute which
also makes operations of an interface non-configurable. Unforgeable attribute will be used instead
when support for it will be added to the JSC bindings generator.

  • Modules/battery/BatteryManager.idl:
  • Modules/encryptedmedia/MediaKeySession.idl:
  • Modules/encryptedmedia/MediaKeys.idl:
  • Modules/gamepad/GamepadList.idl:
  • Modules/geolocation/Geolocation.idl:
  • Modules/indexeddb/IDBCursor.idl:
  • Modules/indexeddb/IDBDatabase.idl:
  • Modules/indexeddb/IDBFactory.idl:
  • Modules/indexeddb/IDBIndex.idl:
  • Modules/indexeddb/IDBKeyRange.idl:
  • Modules/indexeddb/IDBObjectStore.idl:
  • Modules/indexeddb/IDBTransaction.idl:
  • Modules/indexeddb/IDBVersionChangeEvent.idl:
  • Modules/mediacontrols/MediaControlsHost.idl:
  • Modules/mediasource/MediaSource.idl:
  • Modules/mediasource/SourceBuffer.idl:
  • Modules/mediasource/SourceBufferList.idl:
  • Modules/mediastream/MediaStream.idl:
  • Modules/mediastream/MediaStreamTrack.idl:
  • Modules/mediastream/RTCDTMFSender.idl:
  • Modules/mediastream/RTCDataChannel.idl:
  • Modules/mediastream/RTCPeerConnection.idl:
  • Modules/mediastream/RTCStatsReport.idl:
  • Modules/mediastream/RTCStatsResponse.idl:
  • Modules/networkinfo/NetworkInfoConnection.idl:
  • Modules/notifications/Notification.idl:
  • Modules/notifications/NotificationCenter.idl:
  • Modules/proximity/DeviceProximityEvent.idl:
  • Modules/quota/StorageInfo.idl:
  • Modules/quota/StorageQuota.idl:
  • Modules/speech/SpeechGrammarList.idl:
  • Modules/speech/SpeechRecognition.idl:
  • Modules/speech/SpeechRecognitionResult.idl:
  • Modules/speech/SpeechRecognitionResultList.idl:
  • Modules/speech/SpeechSynthesis.idl:
  • Modules/webaudio/AnalyserNode.idl:
  • Modules/webaudio/AudioBuffer.idl:
  • Modules/webaudio/AudioBufferSourceNode.idl:
  • Modules/webaudio/AudioContext.idl:
  • Modules/webaudio/AudioListener.idl:
  • Modules/webaudio/AudioNode.idl:
  • Modules/webaudio/AudioParam.idl:
  • Modules/webaudio/BiquadFilterNode.idl:
  • Modules/webaudio/OscillatorNode.idl:
  • Modules/webaudio/PannerNode.idl:
  • Modules/webdatabase/Database.idl:
  • Modules/webdatabase/DatabaseSync.idl:
  • Modules/webdatabase/SQLResultSetRowList.idl:
  • Modules/webdatabase/SQLTransaction.idl:
  • Modules/webdatabase/SQLTransactionSync.idl:
  • Modules/websockets/WebSocket.idl:
  • crypto/CryptoKey.idl:
  • crypto/SubtleCrypto.idl:
  • css/CSSHostRule.idl:
  • css/CSSMediaRule.idl:
  • css/CSSPrimitiveValue.idl:
  • css/CSSRuleList.idl:
  • css/CSSStyleDeclaration.idl:
  • css/CSSStyleSheet.idl:
  • css/CSSSupportsRule.idl:
  • css/CSSValueList.idl:
  • css/DOMWindowCSS.idl:
  • css/FontLoader.idl:
  • css/MediaList.idl:
  • css/MediaQueryList.idl:
  • css/MediaQueryListListener.idl:
  • css/StyleMedia.idl:
  • css/StyleSheet.idl:
  • css/StyleSheetList.idl:
  • css/WebKitCSSFilterValue.idl:
  • css/WebKitCSSKeyframesRule.idl:
  • css/WebKitCSSMatrix.idl:
  • css/WebKitCSSTransformValue.idl:
  • dom/CharacterData.idl:
  • dom/ChildNode.idl:
  • dom/ClientRectList.idl:
  • dom/Clipboard.idl:
  • dom/CompositionEvent.idl:
  • dom/CustomEvent.idl:
  • dom/DOMCoreException.idl:
  • dom/DOMImplementation.idl:
  • dom/DOMNamedFlowCollection.idl:
  • dom/DOMStringList.idl:
  • dom/DOMStringMap.idl:
  • dom/DataTransferItem.idl:
  • dom/DataTransferItemList.idl:
  • dom/DeviceMotionEvent.idl:
  • dom/DeviceOrientationEvent.idl:
  • dom/Document.idl:
  • dom/DocumentFragment.idl:
  • dom/DocumentType.idl:
  • dom/Element.idl:
  • dom/Event.idl:
  • dom/EventException.idl:
  • dom/EventListener.idl:
  • dom/EventTarget.idl:
  • dom/HashChangeEvent.idl:
  • dom/KeyboardEvent.idl:
  • dom/MessageEvent.idl:
  • dom/MessagePort.idl:
  • dom/MouseEvent.idl:
  • dom/MutationEvent.idl:
  • dom/MutationObserver.idl:
  • dom/NamedNodeMap.idl:
  • dom/Node.idl:
  • dom/NodeFilter.idl:
  • dom/NodeIterator.idl:
  • dom/NodeList.idl:
  • dom/Range.idl:
  • dom/RangeException.idl:
  • dom/ShadowRoot.idl:
  • dom/Text.idl:
  • dom/TextEvent.idl:
  • dom/TouchEvent.idl:
  • dom/TouchList.idl:
  • dom/TreeWalker.idl:
  • dom/UIEvent.idl:
  • dom/WebKitNamedFlow.idl:
  • dom/WheelEvent.idl:
  • fileapi/Blob.idl:
  • fileapi/FileException.idl:
  • fileapi/FileList.idl:
  • fileapi/FileReader.idl:
  • fileapi/FileReaderSync.idl:
  • html/DOMFormData.idl:
  • html/DOMSettableTokenList.idl:
  • html/DOMTokenList.idl:
  • html/DOMURL.idl:
  • html/HTMLAllCollection.idl:
  • html/HTMLAnchorElement.idl:
  • html/HTMLButtonElement.idl:
  • html/HTMLCanvasElement.idl:
  • html/HTMLCollection.idl:
  • html/HTMLDocument.idl:
  • html/HTMLElement.idl:
  • html/HTMLEmbedElement.idl:
  • html/HTMLFieldSetElement.idl:
  • html/HTMLFormControlsCollection.idl:
  • html/HTMLFormElement.idl:
  • html/HTMLFrameElement.idl:
  • html/HTMLIFrameElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLKeygenElement.idl:
  • html/HTMLMarqueeElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLObjectElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLOutputElement.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTableRowElement.idl:
  • html/HTMLTableSectionElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/HTMLVideoElement.idl:
  • html/MediaController.idl:
  • html/RadioNodeList.idl:
  • html/TimeRanges.idl:
  • html/canvas/CanvasGradient.idl:
  • html/canvas/CanvasRenderingContext2D.idl:
  • html/canvas/DOMPath.idl:
  • html/canvas/EXTDrawBuffers.idl:
  • html/canvas/OESVertexArrayObject.idl:
  • html/canvas/WebGLDebugShaders.idl:
  • html/canvas/WebGLLoseContext.idl:
  • html/canvas/WebGLRenderingContext.idl:
  • html/track/AudioTrackList.idl:
  • html/track/TextTrack.idl:
  • html/track/TextTrackCue.idl:
  • html/track/TextTrackCueList.idl:
  • html/track/TextTrackList.idl:
  • html/track/TextTrackRegionList.idl:
  • html/track/VideoTrackList.idl:
  • loader/appcache/DOMApplicationCache.idl:
  • page/Console.idl:
  • page/Crypto.idl:
  • page/DOMSecurityPolicy.idl:
  • page/DOMSelection.idl:
  • page/DOMWindow.idl:
  • page/EventSource.idl:
  • page/History.idl:
  • page/Navigator.idl:
  • page/Performance.idl:
  • page/PerformanceEntryList.idl:
  • page/SpeechInputResultList.idl:
  • page/WindowBase64.idl:
  • page/WindowTimers.idl:
  • plugins/DOMMimeTypeArray.idl:
  • plugins/DOMPlugin.idl:
  • plugins/DOMPluginArray.idl:
  • storage/Storage.idl:
  • storage/StorageEvent.idl:
  • svg/SVGAngle.idl:
  • svg/SVGAnimationElement.idl:
  • svg/SVGColor.idl:
  • svg/SVGCursorElement.idl:
  • svg/SVGDocument.idl:
  • svg/SVGElement.idl:
  • svg/SVGElementInstanceList.idl:
  • svg/SVGException.idl:
  • svg/SVGFEDropShadowElement.idl:
  • svg/SVGFEGaussianBlurElement.idl:
  • svg/SVGFEMorphologyElement.idl:
  • svg/SVGFilterElement.idl:
  • svg/SVGGraphicsElement.idl:
  • svg/SVGLength.idl:
  • svg/SVGLengthList.idl:
  • svg/SVGMarkerElement.idl:
  • svg/SVGMaskElement.idl:
  • svg/SVGMatrix.idl:
  • svg/SVGNumberList.idl:
  • svg/SVGPaint.idl:
  • svg/SVGPathElement.idl:
  • svg/SVGPathSegList.idl:
  • svg/SVGPatternElement.idl:
  • svg/SVGPoint.idl:
  • svg/SVGPointList.idl:
  • svg/SVGSVGElement.idl:
  • svg/SVGStringList.idl:
  • svg/SVGTests.idl:
  • svg/SVGTextContentElement.idl:
  • svg/SVGTransform.idl:
  • svg/SVGTransformList.idl:
  • workers/DedicatedWorkerGlobalScope.idl:
  • workers/Worker.idl:
  • workers/WorkerGlobalScope.idl:
  • workers/WorkerLocation.idl:
  • xml/DOMParser.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XMLHttpRequestException.idl:
  • xml/XMLHttpRequestUpload.idl:
  • xml/XMLSerializer.idl:
  • xml/XPathEvaluator.idl:
  • xml/XPathException.idl:
  • xml/XPathExpression.idl:
  • xml/XPathNSResolver.idl:
  • xml/XPathResult.idl:
  • xml/XSLTProcessor.idl:
11:49 AM Changeset in webkit [159060] by Simon Fraser
  • 1 edit
    3 adds in trunk/LayoutTests

Add a testcase for a tiled layer inside an iframe
​https://bugs.webkit.org/show_bug.cgi?id=124159

Reviewed by Tim Horton.

Add a test for a tiled compositing layer inside an iframe.

  • compositing/tiling/resources/tiled-layer-tall.html: Added.
  • compositing/tiling/tiled-in-iframe.html: Added.
11:18 AM Changeset in webkit [159059] by andersca@apple.com
  • 10 edits in trunk

Remove block based APIs from the WebKit2 C API
​https://bugs.webkit.org/show_bug.cgi?id=124157

Reviewed by Sam Weinig.

Source/WebKit2:

Remove most of the block based C APIs from WebKit2. We want to discourage people from using
them since any C API "objects" captured by blocks won't be implicitly retained which
can lead to dangling pointer bugs.

  • UIProcess/API/C/WKDatabaseManager.cpp:
  • UIProcess/API/C/WKDatabaseManager.h:
  • UIProcess/API/C/WKFrame.cpp:
  • UIProcess/API/C/WKFrame.h:
  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/C/WKPagePrivate.h:

Tools:

Update for WK2 changes.

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(dumpSource):
(-[WK2BrowserWindowController dumpSourceToConsole:]):

10:21 AM Changeset in webkit [159058] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.2.2

Tagging the WebKitGTK+ 2.2.2 release

10:21 AM Changeset in webkit [159057] by commit-queue@webkit.org
  • 8 edits
    12 adds in trunk

[CSS Regions] Selection focusNode set to the "region" block, instead of the "source" block
​https://bugs.webkit.org/show_bug.cgi?id=120769

Patch by Javier Fernandez <​jfernandez@igalia.com> on 2013-11-11
Reviewed by David Hyatt.

Source/WebCore:

When a point hits a Region block, current positionForPoint algorithm determines its
position in the DOM and returns either the start or end offset for such block, since
Region blocks have no children in the DOM.

It's necessary to map the point into Flow Thread coordinates in order to determine
the DOM position of the specific element rendered by the Region.

Top margin, padding and border points should be mapped to the beginning of the Region
block, while bottom points are mapped to the block end. The Left coordinate its just
adjusted to fit in the Flow Thread boundaries, since its not affected by the Flow
direction.

Besides, when inspecting the Flow Thread blocks looking for the last candidate box,
the Region originally associated to the point might be taken into account. Only the
blocks/boxes rendered by the Region are potential candidates.

Tests: fast/regions/selection/position-for-point-1-vert-lr.html

fast/regions/selection/position-for-point-1-vert-rl.html
fast/regions/selection/position-for-point-1.html
fast/regions/selection/position-for-point-vert-lr.html
fast/regions/selection/position-for-point-vert-rl.html
fast/regions/selection/position-for-point.html

  • rendering/RenderBlock.cpp:

(WebCore::isChildHitTestCandidate):
(WebCore::RenderBlock::positionForPoint):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::positionForPoint): Added.
It just redirects the call to the associated RenderNamedFlowFragment instance.

  • rendering/RenderBlockFlow.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::mapRegionPointIntoFlowThreadCoordinates): Added.
It performs the coordinates mapping.
(WebCore::RenderRegion::positionForPoint): Added.
It determines the corresponding LayoutPoint in the FlowThread the Region
is associated to, forwarding the call to the RenderBlock class using the
FlowThread's first child block and such new point.

  • rendering/RenderRegion.h:

LayoutTests:

  • fast/regions/resources/helper.js:

(selectContentFromIdToPos):
(selectContentFromIdToPosVert):
(.document.onmouseup):
(onMouseUpLogSelectionAndFocus):

  • fast/regions/selection/position-for-point-1-expected.txt: Added.
  • fast/regions/selection/position-for-point-1-vert-lr-expected.txt: Added.
  • fast/regions/selection/position-for-point-1-vert-lr.html: Added.
  • fast/regions/selection/position-for-point-1-vert-rl-expected.txt: Added.
  • fast/regions/selection/position-for-point-1-vert-rl.html: Added.
  • fast/regions/selection/position-for-point-1.html: Added.
  • fast/regions/selection/position-for-point-expected.txt: Added.
  • fast/regions/selection/position-for-point-vert-lr-expected.txt: Added.
  • fast/regions/selection/position-for-point-vert-lr.html: Added.
  • fast/regions/selection/position-for-point-vert-rl-expected.txt: Added.
  • fast/regions/selection/position-for-point-vert-rl.html: Added.
  • fast/regions/selection/position-for-point.html: Added.
10:19 AM Changeset in webkit [159056] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.2

Unreviewed. Update NEWS and Versions.m4 for 2.2.2 release.

.:

  • Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Add release notes.
10:14 AM Changeset in webkit [159055] by rgabor@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Fix CPU(ARM_TRADITIONAL) build after r159039.
​https://bugs.webkit.org/show_bug.cgi?id=124149

Reviewed by Geoffrey Garen.

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::firstRegister):
(JSC::ARMAssembler::lastRegister):
(JSC::ARMAssembler::firstFPRegister):
(JSC::ARMAssembler::lastFPRegister):

  • assembler/MacroAssemblerARM.h:
  • jit/FPRInfo.h:
10:00 AM Changeset in webkit [159054] by mitz@apple.com
  • 4 edits in trunk/Source/WebKit

[Mac] .exp files are not source code
​https://bugs.webkit.org/show_bug.cgi?id=124154

Reviewed by Andy Estes.

../WebKit:

  • WebKit.xcodeproj/project.pbxproj: Removed WebKit.iOS.exp from the Compile Sources build

phase.

../WebKit/mac:

  • Configurations/WebKit.xcconfig: Removed WebKit.iOS.exp from

EXCLUDED_SOURCE_FILE_NAMES_macosx.

9:37 AM Changeset in webkit [159053] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[curl] Remove unused includes.
​https://bugs.webkit.org/show_bug.cgi?id=120415

Patch by Gergo Balogh <​geryxyz@inf.u-szeged.hu> on 2013-11-11
Reviewed by Csaba Osztrogonác.

Original patch by 2013-08-28 Tamas Czene <​tczene@inf.u-szeged.hu>

  • platform/network/curl/ProxyServerCurl.cpp:
  • platform/network/curl/ResourceHandleCurl.cpp:
  • platform/network/curl/ResourceHandleManager.cpp:
9:37 AM Changeset in webkit [159052] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

The feeder queue will not feed patches older than one week.
​https://bugs.webkit.org/show_bug.cgi?id=107152

Patch by Tamas Gergely <​gertom@inf.u-szeged.hu> on 2013-11-11
Reviewed by Csaba Osztrogonác.

The feeder queue will not feed patches older than one week.
Unit test added to this scenario.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla.py:

(BugzillaQueries._parse_attachment_ids_request_query):

Handle date parameter.

(BugzillaQueries):
(BugzillaQueries._fetch_attachment_ids_request_query):

Propagate date.

(BugzillaQueries.fetch_attachment_ids_from_review_queue):

Propagate date.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:

(MockBugzillaQueries.fetch_attachment_ids_from_review_queue):

Handle date.

  • Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:

(test_request_page_parsing):

Unit test added.

  • Scripts/webkitpy/tool/bot/feeders.py:

(EWSFeeder.feed):

Query patch ids with date parameter (now - 1 week).

9:33 AM Changeset in webkit [159051] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Do not shut down ImageDiff server after every diff during the tests.
​https://bugs.webkit.org/show_bug.cgi?id=124140

Patch by Tamas Gergely <​gertom@inf.u-szeged.hu> on 2013-11-11
Reviewed by Csaba Osztrogonác.

There was a FIXME: There is no need to shut down the ImageDiff
server after every diff. Shutdown is removed from that point.

  • Scripts/webkitpy/port/image_diff.py:

(ImageDiffer._read):

9:28 AM Changeset in webkit [159050] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

URTBF after r159027 to make Apple Windows build happy.

  • platform/graphics/cg/ImageSourceCG.cpp:

(WebCore::sharedBufferGetBytesAtPosition):

2:38 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
2:33 AM Changeset in webkit [159049] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Kill InlineFlowBox::rendererLineBoxes().
<​https://webkit.org/b/124141>

We only ever used this to access the RenderLineBoxList for non-root
boxes, and those always have a RenderInline renderer.

Tighten things up by losing the virtual rendererLineBoxes() and
calling RenderInline::lineBoxes() directly.

Reviewed by Antti Koivisto.

2:13 AM Changeset in webkit [159048] by Carlos Garcia Campos
  • 9 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r159042 - [GTK] Crash when printing via javascript in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=124043

Reviewed by Martin Robinson.

It happens because the print operation when started by the
WebProcess due to a DOM operation is supposed to be synchronous
and our print operation is always asynchronous. This is currently
handled only in the UI process because other ports print
synchronously in the WebProcess. In the GTK+ port we need to
notify the WebProcess that the print operation should run
synchronously when request by a DOM operation. Together with the
print settings and page setup we now send a print mode that can be
sync or async. When printing in sync mode we run a nested main loop
for the print operation, making sure that print sources have a
higher priority.

  • Shared/PrintInfo.cpp:

(WebKit::PrintInfo::encode): Encode the print mode.
(WebKit::PrintInfo::decode): Decode the print mode.

  • Shared/PrintInfo.h: Add PrintMode enum.
  • Shared/gtk/PrintInfoGtk.cpp:

(WebKit::PrintInfo::PrintInfo): Initialize print mode.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(drawPagesForPrintingCompleted): Do not call endPrinting() when
printing synchronously because WebPageProxy already calls it right
after sending the message to the WebProcess.
(webkitPrintOperationPrintPagesForFrame): Create the PrintInfo
struct with a print mode.
(webkitPrintOperationSetPrintMode): Helper private function to set
the print mode of the print operation.

  • UIProcess/API/gtk/WebKitPrintOperationPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewPrintFrame): Set sync print mode when printing due
to a UIClient request.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::PrintPagesData::PrintPagesData): Create a main loop when
printing synchronously.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
print mode.
(WebKit::WebPrintOperationGtk::printPagesIdleDone): Finish the
nested main loop when printing synchronously.
(WebKit::WebPrintOperationGtk::print): Run a nested main loop when
printing synchronously.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.h:

(WebKit::WebPrintOperationGtk::printMode): Return the print mode.

2:11 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
2:10 AM Changeset in webkit [159047] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r159041 - [GTK] [WebKit2] Crash when printing to a file via javascript
​https://bugs.webkit.org/show_bug.cgi?id=122801

Reviewed by Martin Robinson.

This crash is caused by a GTK+ bug, but we can work around it by
ensuring the print dialog is always shown with a valid
GtkPrintSettings object.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationRunDialog):

2:07 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
2:07 AM Changeset in webkit [159046] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r156892 - [GTK] Enable text edition UndoOperations support in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=122305

Patch by Lorenzo Tilve <​ltilve@igalia.com> on 2013-10-04
Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Replaced the notImplemented() function calls for
the corresponding implementation of the edit operations
provided by the DefaultUndoController class.

  • GNUmakefile.list.am:
  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::registerEditCommand):
(WebKit::PageClientImpl::clearAllEditCommands):
(WebKit::PageClientImpl::canUndoRedo):
(WebKit::PageClientImpl::executeUndoRedo):

  • UIProcess/API/gtk/PageClientImpl.h:
2:05 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
1:52 AM Changeset in webkit [159045] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.2/Source/WTF

Merge r158445 - HPPA build fixes
​https://bugs.webkit.org/show_bug.cgi?id=123625

Original patch from John David Anglin <​dave.anglin@bell.net>

Patch by Emilio Pozuelo Monfort <​pochu27@gmail.com> on 2013-11-01
Reviewed by Darin Adler.

  • wtf/Platform.h:
  • wtf/dtoa/utils.h:
1:50 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
1:38 AM Changeset in webkit [159044] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Bring the LineFragmentationData back to RootInlineBox.
<​https://webkit.org/b/124136>

Now that we have the simple line layout path, almost all the root
line boxes end up with some kind of fragmentation data, so we might
as well put the members back on RootInlineBox and avoid the extra
allocation (and indirection.)

1.74 MB progression on HTML5 spec at <​http://whatwg.org/c>

Reviewed by Antti Koivisto.

1:22 AM Changeset in webkit [159043] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.2/Source/WebKit2

Merge r158444 - Fix build on non-linux platforms
​https://bugs.webkit.org/show_bug.cgi?id=123622

Patch by Emilio Pozuelo Monfort <​pochu27@gmail.com> on 2013-11-01
Reviewed by Darin Adler.

  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
1:20 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
12:30 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
12:30 AM Changeset in webkit [159042] by Carlos Garcia Campos
  • 9 edits in trunk/Source/WebKit2

[GTK] Crash when printing via javascript in WebKit2
​https://bugs.webkit.org/show_bug.cgi?id=124043

Reviewed by Martin Robinson.

It happens because the print operation when started by the
WebProcess due to a DOM operation is supposed to be synchronous
and our print operation is always asynchronous. This is currently
handled only in the UI process because other ports print
synchronously in the WebProcess. In the GTK+ port we need to
notify the WebProcess that the print operation should run
synchronously when request by a DOM operation. Together with the
print settings and page setup we now send a print mode that can be
sync or async. When printing in sync mode we run a nested main loop
for the print operation, making sure that print sources have a
higher priority.

  • Shared/PrintInfo.cpp:

(WebKit::PrintInfo::encode): Encode the print mode.
(WebKit::PrintInfo::decode): Decode the print mode.

  • Shared/PrintInfo.h: Add PrintMode enum.
  • Shared/gtk/PrintInfoGtk.cpp:

(WebKit::PrintInfo::PrintInfo): Initialize print mode.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(drawPagesForPrintingCompleted): Do not call endPrinting() when
printing synchronously because WebPageProxy already calls it right
after sending the message to the WebProcess.
(webkitPrintOperationPrintPagesForFrame): Create the PrintInfo
struct with a print mode.
(webkitPrintOperationSetPrintMode): Helper private function to set
the print mode of the print operation.

  • UIProcess/API/gtk/WebKitPrintOperationPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewPrintFrame): Set sync print mode when printing due
to a UIClient request.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::PrintPagesData::PrintPagesData): Create a main loop when
printing synchronously.
(WebKit::WebPrintOperationGtk::WebPrintOperationGtk): Initialize
print mode.
(WebKit::WebPrintOperationGtk::printPagesIdleDone): Finish the
nested main loop when printing synchronously.
(WebKit::WebPrintOperationGtk::print): Run a nested main loop when
printing synchronously.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.h:

(WebKit::WebPrintOperationGtk::printMode): Return the print mode.

12:24 AM Changeset in webkit [159041] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] [WebKit2] Crash when printing to a file via javascript
​https://bugs.webkit.org/show_bug.cgi?id=122801

Reviewed by Martin Robinson.

This crash is caused by a GTK+ bug, but we can work around it by
ensuring the print dialog is always shown with a valid
GtkPrintSettings object.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(webkitPrintOperationRunDialog):

Nov 10, 2013:

11:43 PM Changeset in webkit [159040] by commit-queue@webkit.org
  • 6 edits in trunk/LayoutTests

[EFL] Layout tests with css1 box properties need to be rebaselined.
​https://bugs.webkit.org/show_bug.cgi?id=124135

Patch by Sun-woo Nam <​sunny.nam@samsung.com> on 2013-11-10
Reviewed by Gyuyoung Kim.

EFL css1 rebaseline after r101343 for EFL gardening.

  • platform/efl/css1/box_properties/margin_right-expected.txt:
  • platform/efl/css1/box_properties/padding-expected.txt:
  • platform/efl/css1/box_properties/padding_left-expected.txt:
  • platform/efl/css1/box_properties/padding_right-expected.txt:
  • platform/efl/css1/box_properties/padding_top-expected.txt:
11:30 PM Changeset in webkit [159039] by fpizlo@apple.com
  • 26 edits in trunk/Source

Switch FTL GetById/PutById IC's over to using AnyRegCC
​https://bugs.webkit.org/show_bug.cgi?id=124094

Source/JavaScriptCore:

Reviewed by Sam Weinig.

This closes the loop on inline caches (IC's) in the FTL. The goal is to have IC's
in LLVM-generated code that are just as efficient (if not more so) than what a
custom JIT could do. As in zero sources of overhead. Not a single extra instruction
or even register allocation pathology. We accomplish this by having two thingies in
LLVM. First is the llvm.experimental.patchpoint intrinsic, which is sort of an
inline machine code snippet that we can fill in with whatever we want and then
modify subsequently. But you have only two choices of how to pass values to a
patchpoint: (1) via the calling convention or (2) via the stackmap. Neither are good
for operands to an IC (like the base pointer for a GetById, for example). (1) is bad
because it results in things being pinned to certain registers a priori; a custom
JIT (like the DFG) will not pin IC operands to any registers a priori but will allow
the register allocator to do whatever it wants. (2) is bad because the operands may
be spilled or may be represented in other crazy ways. You generally want an IC to
have its operands in registers. Also, patchpoints only return values using the
calling convention, which is unfortunate since it pins the return value to a
register a priori. This is where the second thingy comes in: the AnyRegCC. This is
a special calling convention only for use with patchpoints. It means that arguments
passed "by CC" in the patchpoint can be placed in any register, and the register
that gets used is reported as part of the stackmap. It also means that the return
value (if there is one) can be placed in any register, and the stackmap will tell
you which one it was. Thus, patchpoints combined with AnyRegCC mean that you not
only get the kind of self-modifying code that you want for IC's, but you also get
all of the register allocation goodness that a custom JIT would have given you.
Except that you're getting it from LLVM and not a custom JIT. Awesome.

Even though all of the fun stuff is on the LLVM side, this patch was harder than
you'd expect.

First the obvious bits:

  • IC patchpoints now use AnyRegCC instead of the C CC. (CC = calling convention.)


  • FTL::fixFunctionBasedOnStackMaps() now correctly figures out which registers the IC is supposed to use instead of assuming C CC argument registers.


And then all of the stuff that broke and that this patch fixes:

  • IC sizing based on generating a dummy IC (what FTLInlineCacheSize did) is totally bad on x86-64, where various register permutations lead to bizarre header bytes and eclectic SIB encodings. I changed that to have magic constants, for now.


  • Slow path calls didn't preserve the CC return register.


  • Repatch's scratch register allocation would get totally confused if the operand registers weren't one of the DFG-style "temp" registers. And by "totally confused" I mean that it would crash.


  • We assumed that r10 is callee-saved. It's not. That one dude's PPT about x86-64 cdecl that I found on the intertubes was not a trustworthy source of information, apparently.


  • Call repatching didn't know that the FTL does its IC slow calls via specially generated thunks. This was particularly fun to fix: basically, now when we relink an IC call in the FTL, we use the old call target to find the SlowPathCallKey, which tells us everything we need to know to generate (or look up) a new thunk for the new function we want to call.


  • assembler/MacroAssemblerCodeRef.h:

(JSC::MacroAssemblerCodePtr::MacroAssemblerCodePtr):
(JSC::MacroAssemblerCodePtr::isEmptyValue):
(JSC::MacroAssemblerCodePtr::isDeletedValue):
(JSC::MacroAssemblerCodePtr::hash):
(JSC::MacroAssemblerCodePtr::emptyValue):
(JSC::MacroAssemblerCodePtr::deletedValue):
(JSC::MacroAssemblerCodePtrHash::hash):
(JSC::MacroAssemblerCodePtrHash::equal):

  • assembler/MacroAssemblerX86Common.h:
  • assembler/RepatchBuffer.h:

(JSC::RepatchBuffer::RepatchBuffer):
(JSC::RepatchBuffer::codeBlock):

  • ftl/FTLAbbreviations.h:

(JSC::FTL::setInstructionCallingConvention):

  • ftl/FTLCompile.cpp:

(JSC::FTL::fixFunctionBasedOnStackMaps):

  • ftl/FTLInlineCacheSize.cpp:

(JSC::FTL::sizeOfGetById):
(JSC::FTL::sizeOfPutById):

  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeFunction):

  • ftl/FTLLocation.cpp:

(JSC::FTL::Location::forStackmaps):

  • ftl/FTLLocation.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetById):
(JSC::FTL::LowerDFGToLLVM::compilePutById):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • ftl/FTLSlowPathCall.cpp:
  • ftl/FTLSlowPathCallKey.h:

(JSC::FTL::SlowPathCallKey::withCallTarget):

  • ftl/FTLStackMaps.cpp:

(JSC::FTL::StackMaps::Location::directGPR):
(JSC::FTL::StackMaps::Location::restoreInto):

  • ftl/FTLStackMaps.h:
  • ftl/FTLThunks.h:

(JSC::FTL::generateIfNecessary):
(JSC::FTL::keyForThunk):
(JSC::FTL::Thunks::keyForSlowPathCallThunk):

  • jit/FPRInfo.h:

(JSC::FPRInfo::toIndex):

  • jit/GPRInfo.h:

(JSC::GPRInfo::toIndex):
(JSC::GPRInfo::debugName):

  • jit/RegisterSet.cpp:

(JSC::RegisterSet::calleeSaveRegisters):

  • jit/RegisterSet.h:

(JSC::RegisterSet::filter):

  • jit/Repatch.cpp:

(JSC::readCallTarget):
(JSC::repatchCall):
(JSC::repatchByIdSelfAccess):
(JSC::tryCacheGetByID):
(JSC::tryCachePutByID):
(JSC::tryBuildPutByIdList):
(JSC::resetGetByID):
(JSC::resetPutByID):

  • jit/ScratchRegisterAllocator.h:

(JSC::ScratchRegisterAllocator::lock):

Source/WTF:

Reviewed by Sam Weinig.

I needed to add another set operation, namely filter(), which is an in-place set
intersection.

  • wtf/BitVector.cpp:

(WTF::BitVector::filterSlow):

  • wtf/BitVector.h:

(WTF::BitVector::filter):

10:20 PM Changeset in webkit [159038] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Shrink RenderInline.
<​https://webkit.org/b/124134>

Move the "always create line boxes" bit from RenderInline up to
RenderElement. I didn't do this earlier because there were no bits
free on RenderObject but thanks to RenderElement we now have tons!

540 kB progression on HTML5 spec at <​http://whatwg.org/c>

Reviewed by Anders Carlsson.

8:58 PM Changeset in webkit [159037] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WTF

[EFL] Build break on Ubuntu 13.10
​https://bugs.webkit.org/show_bug.cgi?id=124131

Reviewed by Gyuyoung Kim.

Turned DisallowCType macros off on EFL port because gtest-internal.h uses isspace().

  • wtf/DisallowCType.h: Added !PLATFORM(EFL) guard.
8:02 PM Changeset in webkit [159036] by weinig@apple.com
  • 53 edits in trunk/Source/WebCore

Make childShouldCreateRenderer() take a Node reference
​https://bugs.webkit.org/show_bug.cgi?id=124132

Reviewed by Andreas Kling.

The Node passed to childShouldCreateRenderer() is never null.

5:58 PM Changeset in webkit [159035] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

CSS direction must be reset to ltr on <math> element.
<​https://webkit.org/b/124121>

Patch by Frédéric Wang <​fred.wang@free.fr> on 2013-11-10
Reviewed by Darin Adler.

Source/WebCore:

Test: mathml/presentation/direction.html

  • css/mathml.css:

(math): set direction: ltr; on the <math> element.

LayoutTests:

  • mathml/presentation/direction-expected.html: Added.
  • mathml/presentation/direction.html: Added.
4:22 PM Changeset in webkit [159034] by weinig@apple.com
  • 5 edits in trunk/Source/WebCore

Reduce the size of RenderBlockFlow by making its rare data inherit from RenderBlockRareData
​https://bugs.webkit.org/show_bug.cgi?id=124124

Reviewed by Anders Carlsson.

Reduce RenderBlockFlow by one word.

  • rendering/RenderBlock.cpp:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.cpp:
  • rendering/RenderBlockFlow.h:
4:13 PM Changeset in webkit [159033] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit/efl

Cleanup the EFL --minimal build from unused parameters
​https://bugs.webkit.org/show_bug.cgi?id=124048

Patch by Tibor Meszaros <​mtibor@inf.u-szeged.hu> on 2013-11-10
Reviewed by Gyuyoung Kim.

  • WebCoreSupport/ChromeClientEfl.cpp:

(WebCore::ChromeClientEfl::createWindow):

  • ewk/ewk_settings.cpp:

(ewk_settings_web_database_path_set):

  • ewk/ewk_view.cpp:

(ewk_view_visibility_state_set):
(ewk_view_visibility_state_get):

3:32 PM Changeset in webkit [159032] by Antti Koivisto
  • 5 edits in trunk/Source/WebCore

Use start/end instead of textOffset/textLength for simple text runs
​https://bugs.webkit.org/show_bug.cgi?id=124130

Reviewed by Oliver Hunt.

The code reads better this way.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::createTextRuns):

  • rendering/SimpleLineLayout.h:

(WebCore::SimpleLineLayout::Run::Run):

  • rendering/SimpleLineLayoutFunctions.h:

(WebCore::SimpleLineLayout::findTextCaretMinimumOffset):
(WebCore::SimpleLineLayout::findTextCaretMaximumOffset):
(WebCore::SimpleLineLayout::containsTextCaretOffset):
(WebCore::SimpleLineLayout::isTextRendered):

  • rendering/SimpleLineLayoutResolver.h:

(WebCore::SimpleLineLayout::RunResolver::Run::text):

2:28 PM Changeset in webkit [159031] by oliver@apple.com
  • 11 edits
    3 moves
    6 adds in trunk

Implement Set iterators
​https://bugs.webkit.org/show_bug.cgi?id=124129

Reviewed by Antti Koivisto.

Source/JavaScriptCore:

Add Set iterator classes and implementations

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/CommonIdentifiers.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/JSSetIterator.cpp: Added.

(JSC::JSSetIterator::finishCreation):
(JSC::JSSetIterator::visitChildren):
(JSC::JSSetIterator::createPair):

  • runtime/JSSetIterator.h: Added.

(JSC::JSSetIterator::createStructure):
(JSC::JSSetIterator::create):
(JSC::JSSetIterator::next):
(JSC::JSSetIterator::JSSetIterator):

  • runtime/SetIteratorConstructor.cpp: Added.

(JSC::SetIteratorConstructor::finishCreation):

  • runtime/SetIteratorConstructor.h: Added.

(JSC::SetIteratorConstructor::create):
(JSC::SetIteratorConstructor::createStructure):
(JSC::SetIteratorConstructor::SetIteratorConstructor):

  • runtime/SetIteratorPrototype.cpp: Added.

(JSC::SetIteratorPrototype::finishCreation):
(JSC::SetIteratorPrototypeFuncIterator):
(JSC::SetIteratorPrototypeFuncNext):

  • runtime/SetIteratorPrototype.h: Added.

(JSC::SetIteratorPrototype::create):
(JSC::SetIteratorPrototype::createStructure):
(JSC::SetIteratorPrototype::SetIteratorPrototype):

  • runtime/SetPrototype.cpp:

(JSC::SetPrototype::finishCreation):
(JSC::setProtoFuncValues):
(JSC::setProtoFuncEntries):
(JSC::setProtoFuncKeys):

LayoutTests:

Move Set tests to more sensible location and add iterator tests

  • js/basic-set-expected.txt: Renamed from LayoutTests/js/dom/basic-set-expected.txt.
  • js/basic-set.html: Renamed from LayoutTests/js/dom/basic-set.html.
  • js/script-tests/basic-set.js: Renamed from LayoutTests/js/dom/script-tests/basic-set.js.

(set new):
(otherString.string_appeared_here.set add):
(try.set forEach):
(set forEach):
(set gc):

2:17 PM Changeset in webkit [159030] by Antti Koivisto
  • 9 edits
    10 adds in trunk

Implement white-space property on simple line layout path
​https://bugs.webkit.org/show_bug.cgi?id=124122

Source/WebCore:

Reviewed by Andreas Kling.

Support all values of the white-space property and the tab-size property.

Tests: fast/forms/basic-textareas-simple-lines.html

fast/text/embed-at-end-of-pre-wrap-line-simple-lines.html
fast/text/whitespace/pre-wrap-line-test-simple-lines.html
fast/text/whitespace/pre-wrap-long-word-simple-lines.html
fast/text/whitespace/pre-wrap-spaces-after-newline-simple-lines.html

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor):
(WebCore::SimpleLineLayout::isWhitespace):
(WebCore::SimpleLineLayout::skipWhitespaces):
(WebCore::SimpleLineLayout::textWidth):
(WebCore::SimpleLineLayout::measureWord):
(WebCore::SimpleLineLayout::createTextRuns):

  • rendering/SimpleLineLayoutFunctions.cpp:

(WebCore::SimpleLineLayout::paintDebugBorders):
(WebCore::SimpleLineLayout::paintFlow):

LayoutTests:

Reviewed by Andreas Kling.

The simple line layout produces slightly different runs in some pre-wrap cases compared
to the line box path (with less unnecessary boxes). To keep the test coverage this patch forces the
existing render tree dump based tests to use line boxes. It also adds new ref tests for
the same cases where the test uses the simple line path and the ref is forced on the line box path.
This ensures that the paths produce pixel-identical results.

  • fast/forms/basic-textareas-simple-lines-expected.html: Added.
  • fast/forms/basic-textareas-simple-lines.html: Added.
  • fast/forms/basic-textareas.html:
  • fast/text/embed-at-end-of-pre-wrap-line-simple-lines-expected.html: Added.
  • fast/text/embed-at-end-of-pre-wrap-line-simple-lines.html: Added.
  • fast/text/embed-at-end-of-pre-wrap-line.html:
  • fast/text/whitespace/pre-wrap-line-test-simple-lines-expected.html: Added.
  • fast/text/whitespace/pre-wrap-line-test-simple-lines.html: Added.
  • fast/text/whitespace/pre-wrap-line-test.html:
  • fast/text/whitespace/pre-wrap-long-word-simple-lines-expected.html: Added.
  • fast/text/whitespace/pre-wrap-long-word-simple-lines.html: Added. New simple test for overflowing lines which was only covered by the very large basic-textareas.html.
  • fast/text/whitespace/pre-wrap-spaces-after-newline-simple-lines-expected.html: Added.
  • fast/text/whitespace/pre-wrap-spaces-after-newline-simple-lines.html: Added.
  • fast/text/whitespace/pre-wrap-spaces-after-newline.html:
12:59 PM Changeset in webkit [159029] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix EFL build after r159027
​https://bugs.webkit.org/show_bug.cgi?id=124127

Patch by Sergio Correia <Sergio Correia> on 2013-11-10
Reviewed by Anders Carlsson.

No new tests, build fix.

  • page/Settings.in: Add std to numeric_limits, since we don't have

'using std' directives anymore.

11:50 AM Changeset in webkit [159028] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix build.

  • rendering/RenderMultiColumnBlock.cpp:

(WebCore::RenderMultiColumnBlock::computeColumnCountAndWidth):
(WebCore::RenderMultiColumnBlock::checkForPaginationLogicalHeightChange):

11:32 AM Changeset in webkit [159027] by andersca@apple.com
  • 151 edits in trunk/Source/WebCore

Remove all 'std' using directives from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=124125

Reviewed by Sam Weinig.

As per the coding style guidelines.

  • loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCache::appendEntry):
(WebCore::CrossOriginPreflightResultCache::canSkipPreflight):

  • loader/WorkerThreadableLoader.cpp:
  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::loadCache):

  • loader/appcache/ManifestParser.cpp:

(WebCore::parseManifest):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::deadCapacity):
(WebCore::MemoryCache::lruListFor):

  • page/CaptionUserPreferencesMediaAF.cpp:
  • page/Chrome.cpp:
  • page/DOMTimer.cpp:

(WebCore::DOMTimer::intervalClampedToMinimum):

  • page/FocusController.cpp:
  • page/Frame.cpp:

(WebCore::Frame::resizePageRectsKeepingRatio):

  • page/PageGroupLoadDeferrer.cpp:
  • page/Settings.cpp:
  • page/animation/AnimationBase.cpp:

(WebCore::solveStepsFunction):
(WebCore::AnimationBase::fireAnimationEventsIfNeeded):
(WebCore::AnimationBase::timeToNextService):
(WebCore::AnimationBase::fractionalTime):
(WebCore::AnimationBase::getTimeToNextEvent):

  • page/animation/KeyframeAnimation.cpp:

(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty):

  • platform/DateComponents.cpp:
  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent):

  • platform/ScrollView.cpp:

(WebCore::ScrollView::unscaledVisibleContentSize):
(WebCore::ScrollView::setScrollOffset):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::scrollContents):

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::moveThumb):

  • platform/ScrollbarThemeComposite.cpp:

(WebCore::usedTotalSize):
(WebCore::ScrollbarThemeComposite::thumbPosition):
(WebCore::ScrollbarThemeComposite::thumbLength):

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::append):
(WebCore::SharedBuffer::copyBufferAndClear):
(WebCore::SharedBuffer::getSomeData):

  • platform/ThreadTimers.cpp:

(WebCore::ThreadTimers::updateSharedTimer):

  • platform/Timer.cpp:

(WebCore::TimerHeapLessThanFunction::operator()):
(WebCore::TimerBase::heapPop):
(WebCore::TimerBase::nextUnalignedFireInterval):

  • platform/URL.cpp:

(WebCore::findHostnamesInMailToURL):
(WebCore::portAllowed):

  • platform/audio/AudioResampler.cpp:

(WebCore::AudioResampler::setRate):

  • platform/audio/AudioResamplerKernel.cpp:

(WebCore::AudioResamplerKernel::process):

  • platform/audio/Distance.cpp:

(WebCore::DistanceEffect::gain):

  • platform/audio/DynamicsCompressorKernel.cpp:

(WebCore::DynamicsCompressorKernel::process):

  • platform/audio/EqualPowerPanner.cpp:

(WebCore::EqualPowerPanner::pan):

  • platform/audio/HRTFDatabase.cpp:

(WebCore::HRTFDatabase::indexFromElevationAngle):

  • platform/audio/HRTFElevation.cpp:

(WebCore::HRTFElevation::createForSubject):

  • platform/audio/HRTFKernel.cpp:

(WebCore::HRTFKernel::HRTFKernel):
(WebCore::HRTFKernel::createInterpolatedKernel):

  • platform/audio/HRTFPanner.cpp:

(WebCore::HRTFPanner::calculateDesiredAzimuthIndexAndBlend):

  • platform/audio/Reverb.cpp:
  • platform/audio/SincResampler.cpp:

(WebCore::SincResampler::process):

  • platform/cf/URLCF.cpp:
  • platform/graphics/Color.cpp:

(WebCore::makeRGB):
(WebCore::makeRGBA):
(WebCore::colorFloatToRGBAByte):
(WebCore::Color::light):
(WebCore::Color::dark):

  • platform/graphics/CrossfadeGeneratedImage.cpp:
  • platform/graphics/FloatQuad.cpp:

(WebCore::min4):
(WebCore::max4):
(WebCore::withinEpsilon):

  • platform/graphics/FloatSize.cpp:

(WebCore::FloatSize::isZero):

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::floatWidthForSimpleText):

  • platform/graphics/FontPlatformData.cpp:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/RoundedRect.cpp:

(WebCore::RoundedRect::Radii::expand):

  • platform/graphics/ShadowBlur.cpp:

(WebCore::calculateLobes):
(WebCore::computeSliceSizesFromRadii):

  • platform/graphics/SimpleFontData.cpp:

(WebCore::SimpleFontData::initCharWidths):

  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::advanceInternal):

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::processCue):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.mm:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.mm:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration):
(WebCore::MediaPlayerPrivateAVFoundationObjC::currentTime):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setOpacity):
(WebCore::GraphicsLayerCA::setNeedsDisplay):
(WebCore::GraphicsLayerCA::setupAnimation):
(WebCore::clampedContentsScaleForScale):

  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::getTileIndexRangeForRect):
(WebCore::TileController::computeTileCoverageRect):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::computeLineBoundsAndAntialiasingModeForText):

  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/cg/ImageBufferDataCG.cpp:

(WebCore::ImageBufferData::getData):

  • platform/graphics/cg/ImageSourceCG.cpp:
  • platform/graphics/filters/FEDropShadow.cpp:
  • platform/graphics/filters/FEGaussianBlur.cpp:

(WebCore::boxBlur):
(WebCore::FEGaussianBlur::platformApplyGeneric):
(WebCore::FEGaussianBlur::calculateUnscaledKernelSize):
(WebCore::FEGaussianBlur::calculateStdDeviation):

  • platform/graphics/gpu/Texture.cpp:

(WebCore::Texture::updateSubRect):

  • platform/graphics/gpu/TilingData.cpp:

(WebCore::computeNumTiles):
(WebCore::TilingData::tileXIndexFromSrcCoord):
(WebCore::TilingData::tileYIndexFromSrcCoord):

  • platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::offsetForPosition):
(WebCore::ComplexTextController::advance):
(WebCore::ComplexTextController::adjustGlyphsAndAdvances):

  • platform/graphics/mac/FontComplexTextMac.cpp:

(WebCore::Font::floatWidthForComplexText):

  • platform/graphics/mac/FontMac.mm:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::duration):

  • platform/graphics/mac/SimpleFontDataMac.mm:
  • platform/graphics/transforms/Matrix3DTransformOperation.cpp:
  • platform/graphics/transforms/MatrixTransformOperation.cpp:
  • platform/graphics/transforms/PerspectiveTransformOperation.cpp:
  • platform/graphics/transforms/RotateTransformOperation.cpp:
  • platform/graphics/transforms/TransformOperations.cpp:

(WebCore::TransformOperations::blendByMatchingOperations):

  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::clampEdgeValue):

  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::adjustScrollPositionIfNecessary):

  • platform/mac/ScrollViewMac.mm:

(WebCore::ScrollView::platformSetContentsSize):
(WebCore::ScrollView::platformSetScrollPosition):

  • platform/mac/ScrollbarThemeMac.mm:
  • platform/mac/ThemeMac.mm:
  • platform/mac/WebVideoFullscreenHUDWindowController.mm:

(-[WebVideoFullscreenHUDWindowController incrementVolume]):
(timeToString):

  • platform/network/HTTPHeaderMap.cpp:

(WebCore::HTTPHeaderMap::copyData):

  • platform/network/ResourceRequestBase.cpp:
  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::parseCacheControlDirectives):

  • platform/network/cf/ResourceResponseCFNet.cpp:
  • platform/network/mac/ResourceResponseMac.mm:

(WebCore::ResourceResponse::initNSURLResponse):

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::textClone):
(WebCore::textLatin1MoveInPrimaryContext):
(WebCore::textLatin1MoveInPriorContext):
(WebCore::textInChunkOrOutOfRange):
(WebCore::textOpenLatin1):
(WebCore::textUTF16MoveInPrimaryContext):
(WebCore::textUTF16MoveInPriorContext):
(WebCore::textOpenUTF16):

  • platform/text/TextCodecUTF16.cpp:

(WebCore::TextCodecUTF16::encode):

  • platform/text/TextCodecUTF8.cpp:

(WebCore::TextCodecUTF8::encode):

  • platform/text/TextStream.cpp:
  • platform/text/mac/LocaleMac.mm:
  • platform/text/mac/TextCodecMac.cpp:

(WebCore::TextCodecMac::decode):

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths):
(WebCore::AutoTableLayout::applyPreferredLogicalWidthQuirks):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):

  • rendering/FixedTableLayout.cpp:

(WebCore::FixedTableLayout::applyPreferredLogicalWidthQuirks):

  • rendering/FloatingObjects.cpp:

(WebCore::FindNextFloatLogicalBottomAdapter::collectIfNeeded):
(WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalRightOffset):

  • rendering/InlineBox.cpp:
  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxRangeInInlineDirection):
(WebCore::InlineFlowBox::adjustMaxAscentAndDescent):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::computeMaxLogicalTop):
(WebCore::InlineFlowBox::addBoxShadowVisualOverflow):
(WebCore::InlineFlowBox::addBorderOutsetVisualOverflow):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::constrainToLineTopAndBottomIfNeeded):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):
(WebCore::InlineFlowBox::collectLeafBoxesInLogicalOrder):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::isSelected):
(WebCore::InlineTextBox::localSelectionRect):
(WebCore::InlineTextBox::placeEllipsisBox):
(WebCore::InlineTextBox::applyShadowToGraphicsContext):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::selectionStartEnd):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::computeUnderlineOffset):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintDocumentMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
(WebCore::RenderBlock::paintChild):
(WebCore::RenderBlock::blockSelectionGap):
(WebCore::RenderBlock::logicalLeftSelectionGap):
(WebCore::RenderBlock::logicalRightSelectionGap):
(WebCore::RenderBlock::calcColumnWidth):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::computeIntrinsicLogicalWidths):
(WebCore::RenderBlock::computePreferredLogicalWidths):
(WebCore::RenderBlock::adjustIntrinsicLogicalWidthsForColumns):
(WebCore::updatePreferredWidth):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::clearFloats):
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::layoutBlockChild):
(WebCore::RenderBlockFlow::collapseMargins):
(WebCore::RenderBlockFlow::clearFloatsIfNeeded):
(WebCore::RenderBlockFlow::marginBeforeEstimateForChild):
(WebCore::RenderBlockFlow::estimateLogicalTopPosition):
(WebCore::RenderBlockFlow::setCollapsedBottomMargin):
(WebCore::RenderBlockFlow::handleAfterSideOfBlock):
(WebCore::calculateMinimumPageHeight):
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):
(WebCore::RenderBlockFlow::removeFloatingObject):
(WebCore::RenderBlockFlow::computeLogicalLocationForFloat):
(WebCore::RenderBlockFlow::positionNewFloats):
(WebCore::RenderBlockFlow::lowestFloatLogicalBottom):
(WebCore::RenderBlockFlow::addOverhangingFloats):
(WebCore::RenderBlockFlow::getClearDelta):
(WebCore::RenderBlockFlow::adjustForBorderFit):
(WebCore::RenderBlockFlow::fitBorderToLinesIfNeeded):
(WebCore::RenderBlockFlow::updateLogicalHeight):
(WebCore::RenderBlockFlow::positionForPointWithInlineChildren):
(WebCore::RenderBlockFlow::addFocusRingRectsForInlineChildren):
(WebCore::RenderBlockFlow::relayoutForPagination):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::updateLogicalWidthForLeftAlignedBlock):
(WebCore::updateLogicalWidthForRightAlignedBlock):
(WebCore::updateLogicalWidthForCenterAlignedBlock):
(WebCore::setLogicalWidthForTextRun):
(WebCore::RenderBlockFlow::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::layoutLineBoxes):
(WebCore::RenderBlockFlow::checkFloatsInCleanLine):
(WebCore::RenderBlockFlow::checkPaginationAndFloatsAtEndLine):
(WebCore::tryHyphenating):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::scrollWidth):
(WebCore::RenderBox::scrollHeight):
(WebCore::RenderBox::constrainLogicalWidthInRegionByMinMax):
(WebCore::RenderBox::constrainLogicalHeightByMinMax):
(WebCore::RenderBox::constrainContentBoxLogicalHeightByMinMax):
(WebCore::RenderBox::adjustBorderBoxLogicalWidthForBoxSizing):
(WebCore::RenderBox::adjustBorderBoxLogicalHeightForBoxSizing):
(WebCore::RenderBox::adjustContentBoxLogicalWidthForBoxSizing):
(WebCore::RenderBox::adjustContentBoxLogicalHeightForBoxSizing):
(WebCore::RenderBox::repaintLayerRectsForImage):
(WebCore::RenderBox::shrinkLogicalWidthToAvoidFloats):
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeIntrinsicLogicalWidthUsing):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
(WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::applyVisualEffectOverflow):
(WebCore::RenderBox::addLayoutOverflow):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatX):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::setNoRepeatY):
(WebCore::RenderBoxModelObject::BackgroundImageGeometry::useFixedAttachment):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
(WebCore::RenderBoxModelObject::paintOneBorderSide):
(WebCore::calculateAdjustedInnerBorder):
(WebCore::RenderBoxModelObject::paintBoxShadow):
(WebCore::RenderBoxModelObject::localCaretRectForEmptyElement):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::next):
(WebCore::RenderDeprecatedFlexibleBox::computeIntrinsicLogicalWidths):
(WebCore::RenderDeprecatedFlexibleBox::computePreferredLogicalWidths):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
(WebCore::RenderDeprecatedFlexibleBox::allowedChildFlex):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::maxFilenameWidth):
(WebCore::RenderFileUploadControl::computeIntrinsicLogicalWidths):
(WebCore::RenderFileUploadControl::computePreferredLogicalWidths):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::setImageSizeForAltText):

  • rendering/RenderInline.cpp:

(WebCore::computeMargin):
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
(WebCore::RenderInline::paintOutline):
(WebCore::RenderInline::paintOutlineForLine):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::clampScrollOffset):
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::visibleContentRect):
(WebCore::RenderLayer::updateScrollbarsAfterLayout):
(WebCore::RenderLayer::hitTestOverflowControls):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::calculateLayerBounds):

  • rendering/RenderLayerBacking.cpp:
  • rendering/RenderLayerModelObject.cpp:
  • rendering/RenderLineBoxList.cpp:

(WebCore::RenderLineBoxList::rangeIntersectsRect):
(WebCore::RenderLineBoxList::anyLineIntersectsRect):
(WebCore::RenderLineBoxList::lineIntersectsDirtyRect):
(WebCore::RenderLineBoxList::paint):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::layout):
(WebCore::RenderListBox::computePreferredLogicalWidths):
(WebCore::RenderListBox::size):
(WebCore::RenderListBox::numVisibleItems):
(WebCore::RenderListBox::panScroll):
(WebCore::RenderListBox::scrollHeight):

  • rendering/RenderListItem.cpp:
  • rendering/RenderListMarker.cpp:
  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::marqueeSpeed):
(WebCore::RenderMarquee::computePosition):
(WebCore::RenderMarquee::timerFired):

  • rendering/RenderMediaControls.cpp:
  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::updateOptionsWidth):
(WebCore::RenderMenuList::computeIntrinsicLogicalWidths):
(WebCore::RenderMenuList::computePreferredLogicalWidths):

  • rendering/RenderMeter.cpp:
  • rendering/RenderMultiColumnBlock.cpp:
  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::heightAdjustedForSetOffset):
(WebCore::RenderMultiColumnSet::calculateBalancedHeight):
(WebCore::RenderMultiColumnSet::updateLogicalWidth):

  • rendering/RenderNamedFlowFragment.cpp:
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::drawLineForBoxSide):
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
(WebCore::RenderObject::caretMaxOffset):

  • rendering/RenderProgress.cpp:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::overflowRectForFlowThreadPortion):

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computePreferredLogicalWidths):

  • rendering/RenderRubyBase.cpp:
  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::getOverhang):

  • rendering/RenderRubyText.cpp:

(WebCore::RenderRubyText::adjustInlineDirectionLineBounds):

  • rendering/RenderScrollbarPart.cpp:

(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):

  • rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::computeControlLogicalHeight):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::updateLogicalWidth):
(WebCore::RenderTable::convertStyleLogicalHeightToComputedHeight):
(WebCore::RenderTable::layout):
(WebCore::RenderTable::computePreferredLogicalWidths):
(WebCore::RenderTable::calcBorderStart):
(WebCore::RenderTable::calcBorderEnd):
(WebCore::RenderTable::outerBorderBefore):
(WebCore::RenderTable::outerBorderAfter):
(WebCore::RenderTable::outerBorderStart):
(WebCore::RenderTable::outerBorderEnd):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::parseColSpanFromDOM):
(WebCore::RenderTableCell::parseRowSpanFromDOM):
(WebCore::RenderTableCell::logicalWidthFromColumns):
(WebCore::RenderTableCell::computePreferredLogicalWidths):
(WebCore::RenderTableCell::layout):
(WebCore::RenderTableCell::setOverrideLogicalContentHeightFromRowHeight):
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::alignLeftRightBorderPaintRect):
(WebCore::RenderTableCell::alignTopBottomBorderPaintRect):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::ensureRows):
(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::distributeExtraLogicalHeightToPercentRows):
(WebCore::RenderTableSection::layoutRows):
(WebCore::RenderTableSection::firstLineBaseline):
(WebCore::RenderTableSection::removeCachedCollapsedBorders):
(WebCore::RenderTableSection::setCachedCollapsedBorder):
(WebCore::RenderTableSection::cachedCollapsedBorder):

  • rendering/RenderText.cpp:

(WebCore::makeCapitalized):
(WebCore::RenderText::absoluteRectsForRange):
(WebCore::RenderText::absoluteQuadsForRange):
(WebCore::maxWordFragmentWidth):
(WebCore::RenderText::computePreferredLogicalWidths):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computePreferredLogicalWidths):

  • rendering/RenderTextControlSingleLine.cpp:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintProgressBar):
(WebCore::RenderThemeMac::paintMenuListButton):

  • rendering/RenderWidget.cpp:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::RootInlineBox::beforeAnnotationsAdjustment):
(WebCore::RootInlineBox::selectionTopAdjustedForPrecedingBlock):
(WebCore::RootInlineBox::blockDirectionPointInLine):
(WebCore::RootInlineBox::paddedLayoutOverflowRect):
(WebCore::setAscentAndDescent):
(WebCore::RootInlineBox::ascentAndDescentForBox):

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::layout):

  • rendering/style/RenderStyle.cpp:

(WebCore::calcConstraintScaleFor):
(WebCore::RenderStyle::setFontSize):
(WebCore::RenderStyle::getShadowExtent):
(WebCore::RenderStyle::getShadowInsetExtent):
(WebCore::RenderStyle::getShadowHorizontalExtent):
(WebCore::RenderStyle::getShadowVerticalExtent):

  • rendering/style/SVGRenderStyle.cpp:
  • rendering/style/ShadowData.cpp:

(WebCore::calculateShadowExtent):

  • rendering/svg/RenderSVGResourceFilter.cpp:
  • rendering/svg/RenderSVGRoot.cpp:
  • rendering/svg/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::localSelectionRect):

  • svg/SVGAnimatedNumber.cpp:
  • svg/SVGAnimatedNumberOptionalNumber.cpp:
  • svg/animation/SMILTimeContainer.cpp:

(WebCore::SMILTimeContainer::startTimer):
(WebCore::SMILTimeContainer::updateAnimations):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::simpleDuration):
(WebCore::SVGSMILElement::repeatingDuration):
(WebCore::SVGSMILElement::resolveActiveEnd):
(WebCore::SVGSMILElement::resolveInterval):
(WebCore::SVGSMILElement::resolveFirstInterval):
(WebCore::SVGSMILElement::resolveNextInterval):
(WebCore::SVGSMILElement::calculateAnimationPercentAndRepeat):

  • xml/XMLTreeViewer.cpp:
  • xml/parser/XMLDocumentParser.cpp:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::OffsetBuffer::readOutBytes):

8:59 AM Changeset in webkit [159026] by gyuyoung.kim@samsung.com
  • 23 edits in trunk/Source

[AX] Clean up static_cast<> to cast from AccessibilityObject
​https://bugs.webkit.org/show_bug.cgi?id=124032

Reviewed by Mario Sanchez Prada.

Source/WebCore:

ACCESSIBILITY_OBJECT_TYPE_CASTS can support more helpful casting functions.
So, we need to use them as much as possible. This patch cleans up all static_cast<> in accessibility.

This patch generates toAccessibilityFoo() in order to replace static_cast<> with it. Below toAccessibilityFoo()
are generated.

  • toAccessibilityARIAGridRow()
  • toAccessibilityImageMapLink()
  • toAccessibilityListBox()
  • toAccessibilityListBoxOption()
  • toAccessibilityMenuListOption()
  • toAccessibilityMenuListPopup()
  • toAccessibilityScrollbar()
  • toAccessibilitySlider()

No new tests, no behavior changes.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::focusedImageMapUIElement):

  • accessibility/AccessibilityARIAGridRow.h:
  • accessibility/AccessibilityImageMapLink.h:
  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::setSelectedChildren):
(WebCore::AccessibilityListBox::selectedChildren):
(WebCore::AccessibilityListBox::listBoxOptionAccessibilityObject):

  • accessibility/AccessibilityListBox.h:
  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::addChildren):
(WebCore::AccessibilityMenuList::didUpdateActiveOption):

  • accessibility/AccessibilityMenuListOption.h:
  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):

  • accessibility/AccessibilityMenuListPopup.h:
  • accessibility/AccessibilityObject.h:

(WebCore::AccessibilityObject::isListBoxOption):
(WebCore::AccessibilityObject::isSliderThumb):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::getDocumentLinks):
(WebCore::AccessibilityRenderObject::addImageMapChildren):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):

  • accessibility/AccessibilityScrollView.cpp:

(WebCore::AccessibilityScrollView::addChildScrollbar):

  • accessibility/AccessibilityScrollbar.h:
  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::addChildren):

  • accessibility/AccessibilitySlider.h:
  • accessibility/AccessibilitySpinButton.cpp:

(WebCore::AccessibilitySpinButton::addChildren):

  • accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:

(webkitAccessibleSelectionClearSelection):
(webkitAccessibleSelectionSelectAllSelection):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):

  • rendering/RenderMenuList.cpp:

(WebCore::RenderMenuList::didUpdateActiveOption):

Source/WebKit/win:

Use toAccessibilityListBox instead of using static_cast<AccessibilityListBox*>.

  • AccessibleBase.cpp:

(AccessibleBase::accSelect):

8:34 AM Changeset in webkit [159025] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Rebaseline bindings tests after r158997.

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
6:52 AM Changeset in webkit [159024] by commit-queue@webkit.org
  • 11 edits in trunk/Source/WebCore

[GStreamer] Consolidate more code into TrackPrivateBaseGStreamer
​https://bugs.webkit.org/show_bug.cgi?id=124020

Patch by Brendan Long <​b.long@cablelabs.com> on 2013-11-10
Reviewed by Philippe Normand.

No new tests because this is just refactoring.

  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.cpp:

(WebCore::AudioTrackPrivateGStreamer::AudioTrackPrivateGStreamer): Don't pass playbin to TrackPrivateBaseGStreamer, and do pass a pointer to "this".
(WebCore::AudioTrackPrivateGStreamer::disconnect): Clear m_playbin().

  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h: Move labelChanged() and languageChanged() to TrackPrivateBaseGStreamer. Move m_playbin to this class (along with disconnect() to clear it).
  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.cpp: Move tag handling, pad and index to TrackPrivateBaseGStreamer.

(WebCore::textTrackPrivateEventCallback):
(WebCore::InbandTextTrackPrivateGStreamer::InbandTextTrackPrivateGStreamer):
(WebCore::InbandTextTrackPrivateGStreamer::disconnect):

  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
  • platform/graphics/gstreamer/TextCombinerGStreamer.cpp: Add WebKitTextCombinerPad with "tags" property, set in the same was as input-selector's pads.

(webkit_text_combiner_pad_init): Initialize tags to 0.
(webkitTextCombinerPadFinalize): Clear tags.
(webkitTextCombinerPadGetProperty): Handling "tags" property.
(webkitTextCombinerPadEvent): Changed to be a pad event function instead of a pad probe, and now intercepts tags and merges them (like input-selector pads do).
(webkitTextCombinerRequestNewPad): Using WebKitTextCombinerPad instead of just GhostPad.
(webkit_text_combiner_pad_class_init): Setup WebKitTextCombinerPad.

  • platform/graphics/gstreamer/TextCombinerGStreamer.h: Remove superfluous code.
  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:

(WebCore::TrackPrivateBaseGStreamer::TrackPrivateBaseGStreamer): Use "notify::active" so we don't need a playbin, and immediately check for tags after the constructor.
(WebCore::TrackPrivateBaseGStreamer::disconnect): Remove m_playbin.
(WebCore::TrackPrivateBaseGStreamer::getTag): Refactored out from notifyTrackOfTagsChanged.
(WebCore::TrackPrivateBaseGStreamer::notifyTrackOfTagsChanged): Simplify using m_owner (so we can call labelChanged() and languageChanged() directly), and use getTag() above.

  • platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h: Add m_owner to we can access the owning track, and change some functions to match our needs better.

(WebCore::TrackPrivateBaseGStreamer::setActive): Add empty default since InbandTextTrackPrivateGStreamer doesn't need this.

  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.cpp: Same as AudioTrackPrivateGStreamer.

(WebCore::VideoTrackPrivateGStreamer::VideoTrackPrivateGStreamer):
(WebCore::VideoTrackPrivateGStreamer::disconnect):

  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h: Same as AudioTrackPrivateGStreamer.
2:59 AM Changeset in webkit [159023] by akling@apple.com
  • 10 edits in trunk/Source/WebCore

Generate type casting helpers for Widget classes.
<​https://webkit.org/b/124120>

Add a WIDGET_TYPE_CASTS macro and replace all the hand-written
toFoo() helpers we had for Widget subclasses. Fixed up a handful
of places that were still using static_cast.

Reviewed by Antti Koivisto.

2:58 AM Changeset in webkit [159022] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Remove unused FragmentationDisabler class.
<​https://webkit.org/b/124118>

This RAII object was added in r144744 to avoid a crash when using
MathML inside CSS regions. Its only user was removed in r157070.

Reviewed by Antti Koivisto.

2:56 AM Changeset in webkit [159021] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Simplify some is-this-a-MathML-element? checks.
<​https://webkit.org/b/124119>

As of r158198, the MathML-ness of an Element is determined by
a Node flag, so there's no need to cast to Element before checking
on this. Simplify accordingly.

Reviewed by Antti Koivisto.

12:57 AM Changeset in webkit [159020] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Remove RenderTheme::shouldOpenPickerWithF4Key().

Rubber-stamped by Anders Carlsson.

12:39 AM Changeset in webkit [159019] by akling@apple.com
  • 2 edits
    2 copies
    128 moves
    2 adds
    134 deletes in trunk/LayoutTests

Optimize baselines: svg/*

Unreviewed; run "webkit-patch optimize-baselines svg"

  • platform/efl-wk2/svg/dom/SVGLengthList-basics-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGLengthList-basics-expected.png.
  • platform/efl/svg/wicd/sizing-flakiness-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Removed.
  • platform/gtk/svg/as-image/svg-as-image-expected.png: Removed.
  • platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Removed.
  • platform/gtk/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Removed.
  • platform/gtk/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Removed.
  • platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Removed.
  • platform/gtk/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Removed.
  • platform/gtk/svg/custom/feDisplacementMap-01-expected.txt: Removed.
  • platform/gtk/svg/custom/pattern-skew-transformed-expected.png: Removed.
  • platform/gtk/svg/custom/radialGradient-focal-radius-expected.txt: Removed.
  • platform/gtk/svg/custom/simple-text-double-shadow-expected.png: Removed.
  • platform/gtk/svg/custom/simple-text-double-shadow-expected.txt: Removed.
  • platform/gtk/svg/dom/SVGPathSegList-segment-modification-expected.txt: Removed.
  • platform/gtk/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Removed.
  • platform/gtk/svg/dom/SVGRectElement/rect-modify-rx-expected.png: Removed.
  • platform/gtk/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png: Removed.
  • platform/gtk/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png: Removed.
  • platform/gtk/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png: Removed.
  • platform/gtk/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png: Removed.
  • platform/gtk/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png: Removed.
  • platform/gtk/svg/foreignObject/fO-display-none-expected.png: Removed.
  • platform/gtk/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.png: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-display-changes-expected.png: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-display-changes-expected.txt: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-display-none-expected.png: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.png: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-expected.png: Removed.
  • platform/gtk/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.png: Removed.
  • platform/gtk/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png: Removed.
  • platform/gtk/svg/foreignObject/svg-document-as-direct-child-expected.png: Removed.
  • platform/gtk/svg/foreignObject/svg-document-as-direct-child-expected.txt: Removed.
  • platform/gtk/svg/in-html/by-reference-expected.txt: Removed.
  • platform/gtk/svg/overflow/overflow-on-foreignObject-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-inner-svg-element-defaults-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png: Removed.
  • platform/gtk/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png: Removed.
  • platform/gtk/svg/repaint/filter-repaint-expected.txt: Removed.
  • platform/gtk/svg/repaint/image-href-change-expected.png: Removed.
  • platform/gtk/svg/repaint/inner-svg-change-viewBox-contract-expected.png: Removed.
  • platform/gtk/svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Removed.
  • platform/gtk/svg/repaint/text-mask-update-expected.png: Removed.
  • platform/gtk/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Removed.
  • platform/gtk/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Removed.
  • platform/gtk/svg/text/append-text-node-to-tspan-expected.txt: Removed.
  • platform/gtk/svg/text/bidi-embedded-direction-expected.txt: Removed.
  • platform/gtk/svg/text/bidi-reorder-value-lists-expected.txt: Removed.
  • platform/gtk/svg/text/bidi-text-anchor-direction-expected.txt: Removed.
  • platform/gtk/svg/text/bidi-text-query-expected.txt: Removed.
  • platform/gtk/svg/text/bidi-tspans-expected.txt: Removed.
  • platform/gtk/svg/text/ems-display-none-expected.txt: Removed.
  • platform/gtk/svg/text/exs-display-none-expected.txt: Removed.
  • platform/gtk/svg/text/font-size-below-point-five-expected.txt: Removed.
  • platform/gtk/svg/text/modify-text-node-in-tspan-expected.txt: Removed.
  • platform/gtk/svg/text/remove-text-node-from-tspan-expected.txt: Removed.
  • platform/gtk/svg/text/remove-tspan-from-text-expected.txt: Removed.
  • platform/gtk/svg/text/scaled-font-expected.txt: Removed.
  • platform/gtk/svg/text/scaling-font-with-geometric-precision-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-1-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-3-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-squeeze-4-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-1-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-2-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-3-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacing-stretch-4-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Removed.
  • platform/gtk/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-1-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-2-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-3-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-4-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-with-tspans-1-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-with-tspans-2-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-with-tspans-3-expected.txt: Removed.
  • platform/gtk/svg/text/select-x-list-with-tspans-4-expected.txt: Removed.
  • platform/gtk/svg/text/selection-doubleclick-expected.txt: Removed.
  • platform/gtk/svg/text/small-fonts-2-expected.txt: Removed.
  • platform/gtk/svg/text/small-fonts-3-expected.txt: Removed.
  • platform/gtk/svg/text/small-fonts-expected.txt: Removed.
  • platform/gtk/svg/text/text-align-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-align-02-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-align-03-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-align-04-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-align-05-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-align-06-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-altglyph-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-deco-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-fill-opacity-expected.txt: Removed.
  • platform/gtk/svg/text/text-fonts-01-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-fonts-02-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-gradient-positioning-expected.txt: Removed.
  • platform/gtk/svg/text/text-intro-05-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-midpoint-split-bug-expected.txt: Removed.
  • platform/gtk/svg/text/text-path-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-path-middle-align-expected.txt: Removed.
  • platform/gtk/svg/text/text-spacing-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-text-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-text-03-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-text-04-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-text-05-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-text-06-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-text-07-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-text-08-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-tref-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-tselect-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-tselect-02-f-expected.txt: Removed.
  • platform/gtk/svg/text/text-tspan-01-b-expected.txt: Removed.
  • platform/gtk/svg/text/text-ws-01-t-expected.txt: Removed.
  • platform/gtk/svg/text/text-ws-02-t-expected.txt: Removed.
  • platform/gtk/svg/text/tspan-dynamic-positioning-expected.txt: Removed.
  • platform/gtk/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Removed.
  • platform/gtk/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Removed.
  • platform/gtk/svg/wicd/sizing-flakiness-expected.txt: Removed.
  • platform/mac/svg/custom/feDisplacementMap-01-expected.txt: Removed.
  • platform/mac/svg/custom/radialGradient-focal-radius-expected.txt: Removed.
  • platform/mac/svg/custom/stroked-pattern-expected.txt: Removed.
  • platform/mac/svg/text/selection-tripleclick-expected.txt: Removed.
  • platform/win-future/svg/wicd/sizing-flakiness-expected.txt: Copied from LayoutTests/svg/wicd/sizing-flakiness-expected.txt.
  • platform/win/svg/custom/pattern-scaling-expected.txt: Removed.
  • svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt.
  • svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt.
  • svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt.
  • svg/as-image/svg-as-image-expected.png: Renamed from LayoutTests/platform/efl/svg/as-image/svg-as-image-expected.png.
  • svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Renamed from LayoutTests/platform/efl/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png.
  • svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Renamed from LayoutTests/platform/efl/svg/as-object/deep-nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png.
  • svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png: Renamed from LayoutTests/platform/efl/svg/as-object/embedded-svg-size-changes-no-layout-triggers-expected.png.
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png: Renamed from LayoutTests/platform/efl/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-1-expected.png.
  • svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png: Renamed from LayoutTests/platform/efl/svg/as-object/nested-embedded-svg-size-changes-no-layout-triggers-2-expected.png.
  • svg/custom/feDisplacementMap-01-expected.txt: Renamed from LayoutTests/platform/efl/svg/custom/feDisplacementMap-01-expected.txt.
  • svg/custom/pattern-skew-transformed-expected.png: Renamed from LayoutTests/platform/efl/svg/custom/pattern-skew-transformed-expected.png.
  • svg/custom/radialGradient-focal-radius-expected.txt: Renamed from LayoutTests/platform/efl/svg/custom/radialGradient-focal-radius-expected.txt.
  • svg/custom/simple-text-double-shadow-expected.png: Renamed from LayoutTests/platform/efl/svg/custom/simple-text-double-shadow-expected.png.
  • svg/custom/simple-text-double-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/custom/simple-text-double-shadow-expected.txt.
  • svg/custom/stroked-pattern-expected.txt: Renamed from LayoutTests/platform/efl/svg/custom/stroked-pattern-expected.txt.
  • svg/dom/SVGPathSegList-segment-modification-expected.txt: Renamed from LayoutTests/platform/efl/svg/dom/SVGPathSegList-segment-modification-expected.txt.
  • svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Renamed from LayoutTests/platform/efl/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt.
  • svg/dom/SVGRectElement/rect-modify-rx-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGRectElement/rect-modify-rx-expected.png.
  • svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png: Renamed from LayoutTests/platform/efl/svg/dynamic-updates/SVGAElement-dom-href-attr-expected.png.
  • svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png: Renamed from LayoutTests/platform/efl/svg/dynamic-updates/SVGAElement-dom-target-attr-expected.png.
  • svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png: Renamed from LayoutTests/platform/efl/svg/dynamic-updates/SVGAElement-svgdom-href-prop-expected.png.
  • svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png: Renamed from LayoutTests/platform/efl/svg/dynamic-updates/SVGAElement-svgdom-target-prop-expected.png.
  • svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/disallowed-svg-nodes-as-direct-children-expected.png.
  • svg/foreignObject/fO-display-none-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-display-none-expected.png.
  • svg/foreignObject/fO-display-none-with-relative-pos-content-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-display-none-with-relative-pos-content-expected.png.
  • svg/foreignObject/fO-parent-display-changes-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-display-changes-expected.png.
  • svg/foreignObject/fO-parent-display-changes-expected.txt: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-display-changes-expected.txt.
  • svg/foreignObject/fO-parent-display-none-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-display-none-expected.png.
  • svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-display-none-with-relative-pos-content-expected.png.
  • svg/foreignObject/fO-parent-of-parent-display-none-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-expected.png.
  • svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/fO-parent-of-parent-display-none-with-relative-pos-content-expected.png.
  • svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/no-crash-with-svg-content-in-html-document-expected.png.
  • svg/foreignObject/svg-document-as-direct-child-expected.png: Renamed from LayoutTests/platform/efl/svg/foreignObject/svg-document-as-direct-child-expected.png.
  • svg/foreignObject/svg-document-as-direct-child-expected.txt: Renamed from LayoutTests/platform/efl/svg/foreignObject/svg-document-as-direct-child-expected.txt.
  • svg/in-html/by-reference-expected.txt: Renamed from LayoutTests/platform/efl/svg/in-html/by-reference-expected.txt.
  • svg/overflow/overflow-on-foreignObject-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-foreignObject-expected.png.
  • svg/overflow/overflow-on-inner-svg-element-defaults-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-inner-svg-element-defaults-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-defaults-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-1-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-2-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-ignore-attribute-3-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-auto-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-hidden-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-scroll-expected.png.
  • svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png: Renamed from LayoutTests/platform/efl/svg/overflow/overflow-on-outermost-svg-element-in-xhtml-visible-expected.png.
  • svg/repaint/filter-repaint-expected.txt: Renamed from LayoutTests/platform/efl/svg/repaint/filter-repaint-expected.txt.
  • svg/repaint/image-href-change-expected.png: Renamed from LayoutTests/platform/efl/svg/repaint/image-href-change-expected.png.
  • svg/repaint/inner-svg-change-viewBox-contract-expected.png: Renamed from LayoutTests/platform/efl/svg/repaint/inner-svg-change-viewBox-contract-expected.png.
  • svg/repaint/inner-svg-change-viewPort-relative-expected.txt: Renamed from LayoutTests/platform/efl/svg/repaint/inner-svg-change-viewPort-relative-expected.txt.
  • svg/repaint/text-mask-update-expected.png: Renamed from LayoutTests/platform/efl/svg/repaint/text-mask-update-expected.png.
  • svg/stroke/zero-length-path-linecap-rendering-expected.txt: Renamed from LayoutTests/platform/efl/svg/stroke/zero-length-path-linecap-rendering-expected.txt.
  • svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Renamed from LayoutTests/platform/efl/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt.
  • svg/text/append-text-node-to-tspan-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/append-text-node-to-tspan-expected.txt.
  • svg/text/bidi-embedded-direction-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/bidi-embedded-direction-expected.txt.
  • svg/text/bidi-reorder-value-lists-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/bidi-reorder-value-lists-expected.txt.
  • svg/text/bidi-text-anchor-direction-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/bidi-text-anchor-direction-expected.txt.
  • svg/text/bidi-text-query-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/bidi-text-query-expected.txt.
  • svg/text/bidi-tspans-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/bidi-tspans-expected.txt.
  • svg/text/ems-display-none-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/ems-display-none-expected.txt.
  • svg/text/exs-display-none-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/exs-display-none-expected.txt.
  • svg/text/font-size-below-point-five-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/font-size-below-point-five-expected.txt.
  • svg/text/modify-text-node-in-tspan-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/modify-text-node-in-tspan-expected.txt.
  • svg/text/remove-text-node-from-tspan-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/remove-text-node-from-tspan-expected.txt.
  • svg/text/remove-tspan-from-text-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/remove-tspan-from-text-expected.txt.
  • svg/text/scaled-font-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/scaled-font-expected.txt.
  • svg/text/scaling-font-with-geometric-precision-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/scaling-font-with-geometric-precision-expected.txt.
  • svg/text/select-textLength-spacing-squeeze-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-squeeze-1-expected.txt.
  • svg/text/select-textLength-spacing-squeeze-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-squeeze-2-expected.txt.
  • svg/text/select-textLength-spacing-squeeze-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-squeeze-3-expected.txt.
  • svg/text/select-textLength-spacing-squeeze-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-squeeze-4-expected.txt.
  • svg/text/select-textLength-spacing-stretch-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-stretch-1-expected.txt.
  • svg/text/select-textLength-spacing-stretch-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-stretch-2-expected.txt.
  • svg/text/select-textLength-spacing-stretch-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-stretch-3-expected.txt.
  • svg/text/select-textLength-spacing-stretch-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacing-stretch-4-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt.
  • svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt.
  • svg/text/select-x-list-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-1-expected.txt.
  • svg/text/select-x-list-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-2-expected.txt.
  • svg/text/select-x-list-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-3-expected.txt.
  • svg/text/select-x-list-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-4-expected.txt.
  • svg/text/select-x-list-with-tspans-1-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-with-tspans-1-expected.txt.
  • svg/text/select-x-list-with-tspans-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-with-tspans-2-expected.txt.
  • svg/text/select-x-list-with-tspans-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-with-tspans-3-expected.txt.
  • svg/text/select-x-list-with-tspans-4-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/select-x-list-with-tspans-4-expected.txt.
  • svg/text/selection-doubleclick-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/selection-doubleclick-expected.txt.
  • svg/text/selection-tripleclick-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/selection-tripleclick-expected.txt.
  • svg/text/small-fonts-2-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/small-fonts-2-expected.txt.
  • svg/text/small-fonts-3-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/small-fonts-3-expected.txt.
  • svg/text/small-fonts-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/small-fonts-expected.txt.
  • svg/text/text-align-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-01-b-expected.txt.
  • svg/text/text-align-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-02-b-expected.txt.
  • svg/text/text-align-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-03-b-expected.txt.
  • svg/text/text-align-04-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-04-b-expected.txt.
  • svg/text/text-align-05-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-05-b-expected.txt.
  • svg/text/text-align-06-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-align-06-b-expected.txt.
  • svg/text/text-altglyph-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-altglyph-01-b-expected.txt.
  • svg/text/text-deco-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-deco-01-b-expected.txt.
  • svg/text/text-fill-opacity-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-fill-opacity-expected.txt.
  • svg/text/text-fonts-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-fonts-01-t-expected.txt.
  • svg/text/text-fonts-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-fonts-02-t-expected.txt.
  • svg/text/text-gradient-positioning-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-gradient-positioning-expected.txt.
  • svg/text/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-intro-05-t-expected.txt.
  • svg/text/text-midpoint-split-bug-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-midpoint-split-bug-expected.txt.
  • svg/text/text-path-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-path-01-b-expected.txt.
  • svg/text/text-path-middle-align-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-path-middle-align-expected.txt.
  • svg/text/text-spacing-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-spacing-01-b-expected.txt.
  • svg/text/text-text-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-01-b-expected.txt.
  • svg/text/text-text-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-03-b-expected.txt.
  • svg/text/text-text-04-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-04-t-expected.txt.
  • svg/text/text-text-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-05-t-expected.txt.
  • svg/text/text-text-06-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-06-t-expected.txt.
  • svg/text/text-text-07-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-07-t-expected.txt.
  • svg/text/text-text-08-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-text-08-b-expected.txt.
  • svg/text/text-tref-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-tref-01-b-expected.txt.
  • svg/text/text-tselect-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-tselect-01-b-expected.txt.
  • svg/text/text-tselect-02-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-tselect-02-f-expected.txt.
  • svg/text/text-tspan-01-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-tspan-01-b-expected.txt.
  • svg/text/text-ws-01-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-ws-01-t-expected.txt.
  • svg/text/text-ws-02-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/text-ws-02-t-expected.txt.
  • svg/text/tspan-dynamic-positioning-expected.txt: Renamed from LayoutTests/platform/efl/svg/text/tspan-dynamic-positioning-expected.txt.
  • svg/transforms/text-with-mask-with-svg-transform-expected.txt: Renamed from LayoutTests/platform/efl/svg/transforms/text-with-mask-with-svg-transform-expected.txt.
  • svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Renamed from LayoutTests/platform/efl/svg/transforms/text-with-pattern-with-svg-transform-expected.txt.
  • svg/wicd/sizing-flakiness-expected.txt:

Nov 9, 2013:

11:28 PM Changeset in webkit [159018] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

CSSValuePool::createFontFamilyValue() should return PassRef.
<​https://webkit.org/b/124114>

Unlike createFontFaceValue(), createFontFamilyValue() can never
fail to return an object and thus should return PassRef.

Reviewed by Anders Carlsson.

11:26 PM Changeset in webkit [159017] by akling@apple.com
  • 371 edits in trunk

RenderIFrame should display its name correctly in DRT output.
<​https://webkit.org/b/124117>

Source/WebCore:

Nuke an age-old FIXME about making RenderIFrame show its true name
in DRT output. No more "RenderPartObject {IFRAME}"!

Reviewed by Anders Carlsson.

LayoutTests:

Rebaseline results now that RenderIFrame correctly dumps its name
as "RenderIFrame".

Reviewed by Anders Carlsson.

  • compositing/iframes/composited-iframe-scroll-expected.txt:
  • compositing/iframes/iframe-content-flipping-expected.txt:
  • compositing/iframes/nested-iframe-scrolling-expected.txt:
  • fast/css/replaced-element-implicit-size-expected.txt:
  • fast/css/resize-corner-tracking-expected.txt:
  • fast/dom/attr_dead_doc-expected.txt:
  • fast/frames/content-opacity-1-expected.txt:
  • fast/frames/content-opacity-2-expected.txt:
  • fast/frames/iframe-scaling-with-scroll-expected.txt:
  • fast/frames/iframe-text-contents-expected.txt:
  • fast/frames/paint-iframe-background-expected.txt:
  • fast/repaint/4774354-expected.txt:
  • fast/repaint/iframe-scroll-repaint-expected.txt:
  • fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
  • fast/replaced/percent-height-in-anonymous-block-expected.txt:
  • http/tests/misc/acid3-expected.txt:
  • media/media-document-audio-repaint-expected.txt:
  • platform/efl/compositing/iframes/composited-iframe-alignment-expected.txt:
  • platform/efl/compositing/iframes/iframe-copy-on-scroll-expected.txt:
  • platform/efl/compositing/iframes/iframe-in-composited-layer-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-004-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-005-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-007-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-011-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-012-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-014-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-018-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-019-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-021-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-025-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-026-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-028-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-032-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-033-expected.txt:
  • platform/efl/css2.1/20110323/absolute-replaced-height-035-expected.txt:
  • platform/efl/css2.1/20110323/block-replaced-height-004-expected.txt:
  • platform/efl/css2.1/20110323/block-replaced-height-005-expected.txt:
  • platform/efl/css2.1/20110323/block-replaced-height-007-expected.txt:
  • platform/efl/css2.1/20110323/float-replaced-height-004-expected.txt:
  • platform/efl/css2.1/20110323/float-replaced-height-005-expected.txt:
  • platform/efl/css2.1/20110323/float-replaced-height-007-expected.txt:
  • platform/efl/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
  • platform/efl/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
  • platform/efl/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
  • platform/efl/css2.1/20110323/inline-replaced-height-004-expected.txt:
  • platform/efl/css2.1/20110323/inline-replaced-height-005-expected.txt:
  • platform/efl/css2.1/20110323/inline-replaced-height-007-expected.txt:
  • platform/efl/editing/pasteboard/4631972-expected.txt:
  • platform/efl/editing/selection/4776665-expected.txt:
  • platform/efl/editing/selection/4960137-expected.txt:
  • platform/efl/editing/selection/4975120-expected.txt:
  • platform/efl/editing/selection/drag-in-iframe-expected.txt:
  • platform/efl/editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • platform/efl/editing/selection/iframe-expected.txt:
  • platform/efl/editing/selection/select-all-iframe-expected.txt:
  • platform/efl/fast/block/basic/013-expected.txt:
  • platform/efl/fast/block/positioning/window-height-change-expected.txt:
  • platform/efl/fast/css/line-height-overflow-expected.txt:
  • platform/efl/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt:
  • platform/efl/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
  • platform/efl/fast/flexbox/016-expected.txt:
  • platform/efl/fast/forms/basic-textareas-expected.txt:
  • platform/efl/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/efl/fast/forms/targeted-frame-submission-expected.txt:
  • platform/efl/fast/frames/001-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-nested-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
  • platform/efl/fast/frames/flattening/iframe-flattening-simple-expected.txt:
  • platform/efl/fast/frames/frameElement-iframe-expected.txt:
  • platform/efl/fast/frames/iframe-option-crash-expected.txt:
  • platform/efl/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/efl/fast/frames/iframe-with-frameborder-expected.txt:
  • platform/efl/fast/frames/onlyCommentInIFrame-expected.txt:
  • platform/efl/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/efl/fast/frames/viewsource-attribute-expected.txt:
  • platform/efl/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/efl/fast/images/favicon-as-image-expected.txt:
  • platform/efl/fast/overflow/scrollRevealButton-expected.txt:
  • platform/efl/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/efl/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/efl/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
  • platform/efl/fast/replaced/007-expected.txt:
  • platform/efl/fast/replaced/border-radius-clip-expected.txt:
  • platform/efl/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
  • platform/efl/fast/replaced/replaced-breaking-expected.txt:
  • platform/efl/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
  • platform/efl/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt:
  • platform/efl/fast/table/quote-text-around-iframe-expected.txt:
  • platform/efl/fast/text/selection-hard-linebreak-expected.txt:
  • platform/efl/http/tests/loading/simple-subframe-expected.txt:
  • platform/efl/http/tests/local/file-url-sent-as-referer-expected.txt:
  • platform/efl/http/tests/misc/acid3-expected.txt:
  • platform/efl/http/tests/misc/favicon-as-image-expected.txt:
  • platform/efl/http/tests/misc/frame-access-during-load-expected.txt:
  • platform/efl/http/tests/misc/iframe404-expected.txt:
  • platform/efl/http/tests/misc/location-replace-crossdomain-expected.txt:
  • platform/efl/http/tests/multipart/invalid-image-data-standalone-expected.txt:
  • platform/efl/media/media-document-audio-repaint-expected.txt:
  • platform/efl/svg/hixie/rendering-model/003-expected.txt:
  • platform/efl/svg/in-html/by-reference-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug38916-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt:
  • platform/gtk-wk1/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-004-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-005-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-007-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-011-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-012-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-014-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-018-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-019-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-021-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-025-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-026-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-028-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-032-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-033-expected.txt:
  • platform/gtk/css2.1/20110323/absolute-replaced-height-035-expected.txt:
  • platform/gtk/css2.1/20110323/block-replaced-height-004-expected.txt:
  • platform/gtk/css2.1/20110323/block-replaced-height-005-expected.txt:
  • platform/gtk/css2.1/20110323/block-replaced-height-007-expected.txt:
  • platform/gtk/css2.1/20110323/float-replaced-height-004-expected.txt:
  • platform/gtk/css2.1/20110323/float-replaced-height-005-expected.txt:
  • platform/gtk/css2.1/20110323/float-replaced-height-007-expected.txt:
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
  • platform/gtk/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
  • platform/gtk/css2.1/20110323/inline-replaced-height-004-expected.txt:
  • platform/gtk/css2.1/20110323/inline-replaced-height-005-expected.txt:
  • platform/gtk/css2.1/20110323/inline-replaced-height-007-expected.txt:
  • platform/gtk/editing/execCommand/find-after-replace-expected.txt:
  • platform/gtk/editing/execCommand/paste-1-expected.txt:
  • platform/gtk/editing/pasteboard/4631972-expected.txt:
  • platform/gtk/editing/pasteboard/copy-standalone-image-expected.txt:
  • platform/gtk/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
  • platform/gtk/editing/pasteboard/paste-2-expected.txt:
  • platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/gtk/editing/selection/4776665-expected.txt:
  • platform/gtk/editing/selection/4960137-expected.txt:
  • platform/gtk/editing/selection/4975120-expected.txt:
  • platform/gtk/editing/selection/drag-in-iframe-expected.txt:
  • platform/gtk/editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • platform/gtk/editing/selection/iframe-expected.txt:
  • platform/gtk/editing/selection/select-all-iframe-expected.txt:
  • platform/gtk/fast/block/basic/013-expected.txt:
  • platform/gtk/fast/block/positioning/window-height-change-expected.txt:
  • platform/gtk/fast/css/line-height-overflow-expected.txt:
  • platform/gtk/fast/css/resize-corner-tracking-expected.txt:
  • platform/gtk/fast/css/resize-corner-tracking-transformed-iframe-expected.txt:
  • platform/gtk/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt:
  • platform/gtk/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
  • platform/gtk/fast/flexbox/016-expected.txt:
  • platform/gtk/fast/forms/basic-textareas-expected.txt:
  • platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/gtk/fast/forms/targeted-frame-submission-expected.txt:
  • platform/gtk/fast/frames/001-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-nested-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
  • platform/gtk/fast/frames/flattening/iframe-flattening-simple-expected.txt:
  • platform/gtk/fast/frames/frameElement-iframe-expected.txt:
  • platform/gtk/fast/frames/iframe-option-crash-expected.txt:
  • platform/gtk/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/gtk/fast/frames/iframe-with-frameborder-expected.txt:
  • platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt:
  • platform/gtk/fast/frames/scrolling-iframe-out-of-viewport-expected.txt:
  • platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/gtk/fast/frames/viewsource-attribute-expected.txt:
  • platform/gtk/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/gtk/fast/images/favicon-as-image-expected.txt:
  • platform/gtk/fast/overflow/scrollRevealButton-expected.txt:
  • platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/gtk/fast/repaint/iframe-scroll-repaint-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/gtk/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/gtk/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
  • platform/gtk/fast/replaced/007-expected.txt:
  • platform/gtk/fast/replaced/border-radius-clip-expected.txt:
  • platform/gtk/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
  • platform/gtk/fast/replaced/replaced-breaking-expected.txt:
  • platform/gtk/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
  • platform/gtk/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt:
  • platform/gtk/fast/table/quote-text-around-iframe-expected.txt:
  • platform/gtk/fast/text/selection-hard-linebreak-expected.txt:
  • platform/gtk/http/tests/loading/simple-subframe-expected.txt:
  • platform/gtk/http/tests/local/file-url-sent-as-referer-expected.txt:
  • platform/gtk/http/tests/misc/favicon-as-image-expected.txt:
  • platform/gtk/http/tests/misc/frame-access-during-load-expected.txt:
  • platform/gtk/http/tests/misc/iframe404-expected.txt:
  • platform/gtk/http/tests/misc/location-replace-crossdomain-expected.txt:
  • platform/gtk/http/tests/multipart/invalid-image-data-standalone-expected.txt:
  • platform/gtk/media/media-document-audio-repaint-expected.txt:
  • platform/gtk/plugins/iframe-plugin-bgcolor-expected.txt:
  • platform/gtk/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
  • platform/gtk/svg/custom/embedding-external-svgs-expected.txt:
  • platform/gtk/svg/hixie/rendering-model/003-expected.txt:
  • platform/gtk/svg/in-html/by-reference-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug38916-expected.txt:
  • platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/iphone-simulator/text-autosizing/contenteditable-expected.txt:
  • platform/mac-mountainlion/editing/selection/4975120-expected.txt:
  • platform/mac-mountainlion/fast/forms/basic-textareas-expected.txt:
  • platform/mac-mountainlion/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac-mountainlion/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac-wk2/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/mac/compositing/iframes/composited-iframe-alignment-expected.txt:
  • platform/mac/compositing/iframes/iframe-copy-on-scroll-expected.txt:
  • platform/mac/compositing/iframes/iframe-in-composited-layer-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-004-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-005-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-007-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-011-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-012-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-014-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-018-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-019-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-021-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-025-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-026-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-028-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-032-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-033-expected.txt:
  • platform/mac/css2.1/20110323/absolute-replaced-height-035-expected.txt:
  • platform/mac/css2.1/20110323/block-replaced-height-004-expected.txt:
  • platform/mac/css2.1/20110323/block-replaced-height-005-expected.txt:
  • platform/mac/css2.1/20110323/block-replaced-height-007-expected.txt:
  • platform/mac/css2.1/20110323/float-replaced-height-004-expected.txt:
  • platform/mac/css2.1/20110323/float-replaced-height-005-expected.txt:
  • platform/mac/css2.1/20110323/float-replaced-height-007-expected.txt:
  • platform/mac/css2.1/20110323/inline-block-replaced-height-004-expected.txt:
  • platform/mac/css2.1/20110323/inline-block-replaced-height-005-expected.txt:
  • platform/mac/css2.1/20110323/inline-block-replaced-height-007-expected.txt:
  • platform/mac/css2.1/20110323/inline-replaced-height-004-expected.txt:
  • platform/mac/css2.1/20110323/inline-replaced-height-005-expected.txt:
  • platform/mac/css2.1/20110323/inline-replaced-height-007-expected.txt:
  • platform/mac/editing/execCommand/find-after-replace-expected.txt:
  • platform/mac/editing/execCommand/paste-1-expected.txt:
  • platform/mac/editing/pasteboard/4631972-expected.txt:
  • platform/mac/editing/pasteboard/copy-standalone-image-expected.txt:
  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
  • platform/mac/editing/pasteboard/paste-2-expected.txt:
  • platform/mac/editing/pasteboard/subframe-dragndrop-1-expected.txt:
  • platform/mac/editing/selection/4776665-expected.txt:
  • platform/mac/editing/selection/4960137-expected.txt:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/drag-in-iframe-expected.txt:
  • platform/mac/editing/selection/drag-to-contenteditable-iframe-expected.txt:
  • platform/mac/editing/selection/iframe-expected.txt:
  • platform/mac/editing/selection/select-all-iframe-expected.txt:
  • platform/mac/fast/block/basic/013-expected.txt:
  • platform/mac/fast/block/positioning/window-height-change-expected.txt:
  • platform/mac/fast/css/line-height-overflow-expected.txt:
  • platform/mac/fast/css/resize-corner-tracking-transformed-iframe-expected.txt:
  • platform/mac/fast/css3-text/css3-text-decoration/text-decoration-line-scaled-expected.txt:
  • platform/mac/fast/dom/Window/open-existing-pop-up-blocking-expected.txt:
  • platform/mac/fast/flexbox/016-expected.txt:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/targeted-frame-submission-expected.txt:
  • platform/mac/fast/frames/001-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-height-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-and-height-no-scrolling-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-fixed-width-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-nested-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-offscreen-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-and-scroll-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-out-of-view-scroll-and-relayout-expected.txt:
  • platform/mac/fast/frames/flattening/iframe-flattening-simple-expected.txt:
  • platform/mac/fast/frames/frameElement-iframe-expected.txt:
  • platform/mac/fast/frames/iframe-option-crash-expected.txt:
  • platform/mac/fast/frames/iframe-scrolling-attribute-expected.txt:
  • platform/mac/fast/frames/iframe-with-frameborder-expected.txt:
  • platform/mac/fast/frames/onlyCommentInIFrame-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/frames/viewsource-attribute-expected.txt:
  • platform/mac/fast/frames/viewsource-on-image-file-expected.txt:
  • platform/mac/fast/images/favicon-as-image-expected.txt:
  • platform/mac/fast/overflow/scrollRevealButton-expected.txt:
  • platform/mac/fast/repaint/4774354-expected.txt:
  • platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
  • platform/mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
  • platform/mac/fast/repaint/text-selection-rect-in-overflow-2-expected.txt:
  • platform/mac/fast/replaced/007-expected.txt:
  • platform/mac/fast/replaced/border-radius-clip-expected.txt:
  • platform/mac/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/sub-pixel/sub-pixel-iframe-copy-on-scroll-expected.txt:
  • platform/mac/fast/sub-pixel/transformed-iframe-copy-on-scroll-expected.txt:
  • platform/mac/fast/table/quote-text-around-iframe-expected.txt:
  • platform/mac/fast/text/selection-hard-linebreak-expected.txt:
  • platform/mac/http/tests/loading/simple-subframe-expected.txt:
  • platform/mac/http/tests/local/file-url-sent-as-referer-expected.txt:
  • platform/mac/http/tests/misc/acid3-expected.txt:
  • platform/mac/http/tests/misc/favicon-as-image-expected.txt:
  • platform/mac/http/tests/misc/frame-access-during-load-expected.txt:
  • platform/mac/http/tests/misc/iframe404-expected.txt:
  • platform/mac/http/tests/misc/location-replace-crossdomain-expected.txt:
  • platform/mac/http/tests/multipart/invalid-image-data-standalone-expected.txt:
  • platform/mac/plugins/update-widget-from-style-recalc-expected.txt:
  • platform/mac/plugins/update-widget-from-style-recalc.html:
  • platform/mac/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt:
  • platform/mac/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt:
  • platform/mac/svg/custom/embedding-external-svgs-expected.txt:
  • platform/mac/svg/hixie/rendering-model/003-expected.txt:
  • platform/mac/svg/in-html/by-reference-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug38916-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/webarchive/loading/cache-expired-subresource-expected.txt:
  • platform/win-xp/media/media-document-audio-repaint-expected.txt:
  • platform/win/http/tests/misc/acid3-expected.txt:
  • plugins/iframe-plugin-bgcolor-expected.txt:
  • printing/iframe-print-expected.txt:
  • scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt:
  • scrollingcoordinator/non-fast-scrollable-region-transformed-iframe-expected.txt:
  • svg/as-object/svg-embedded-in-html-in-iframe-expected.txt:
  • tables/mozilla/bugs/bug137388-1-expected.txt:
  • tables/mozilla/bugs/bug137388-2-expected.txt:
  • tables/mozilla/bugs/bug137388-3-expected.txt:
  • tables/mozilla/bugs/bug50695-2-expected.txt:
10:49 PM Changeset in webkit [159016] by mitz@apple.com
  • 6 edits
    2 adds in trunk/Source/WebKit2

Use createCFURLFromBuffer when converting a String to a CFURL
​https://bugs.webkit.org/show_bug.cgi?id=124113

Reviewed by Anders Carlsson.

  • Shared/API/c/cf/WKURLCF.mm:

(WKURLCopyCFURL): Replaced some code with a call to createCFURLFromBuffer(), which does the
same thing.

  • Shared/Cocoa/WKNSURLExtras.h: Added.
  • Shared/Cocoa/WKNSURLExtras.mm: Added.

(+[NSURL _web_URLWithWTFString:relativeToURL:]): Added. Returns nil for the null String,
otherwise returns the result of createCFURLFromBuffer().

  • UIProcess/API/Cocoa/WKBackForwardListItem.mm:

(-[WKBackForwardListItem URL]): Changed to use +_web_URLWithWTFString:relativeToURL:.
(-[WKBackForwardListItem originalURL]): Ditto.

  • UIProcess/API/Cocoa/WKNavigationData.mm:

(-[WKNavigationData destinationURL]): Ditto.

  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController unreachableURL]): Ditto.

  • WebKit2.xcodeproj/project.pbxproj: Added references to new files.
10:45 PM Changeset in webkit [159015] by akling@apple.com
  • 3 edits
    2 copies
    9 moves
    1 add
    13 deletes in trunk/LayoutTests

Optimize baselines: svg/W3C-SVG-1.1-SE

Unreviewed; run "webkit-patch optimize-baselines svg/W3C-SVG-1.1-SE"

  • platform/efl/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
  • platform/efl/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Removed.
  • platform/gtk/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Removed.
  • platform/win-future/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt.
  • platform/win-future/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Copied from LayoutTests/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt.
  • svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt.
  • svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt.
  • svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.
  • svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Renamed from LayoutTests/platform/efl/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt.
  • svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
10:42 PM Changeset in webkit [159014] by akling@apple.com
  • 1 edit
    9 moves
    9 deletes in trunk/LayoutTests

Optimize baselines: svg/carto.net

Unreviewed; run "webkit-patch optimize-baselines svg/carto.net"

  • platform/gtk/svg/carto.net/button-expected.txt: Removed.
  • platform/gtk/svg/carto.net/colourpicker-expected.txt: Removed.
  • platform/gtk/svg/carto.net/combobox-expected.txt: Removed.
  • platform/gtk/svg/carto.net/scrollbar-expected.txt: Removed.
  • platform/gtk/svg/carto.net/selectionlist-expected.txt: Removed.
  • platform/gtk/svg/carto.net/slider-expected.txt: Removed.
  • platform/gtk/svg/carto.net/tabgroup-expected.txt: Removed.
  • platform/gtk/svg/carto.net/textbox-expected.txt: Removed.
  • platform/gtk/svg/carto.net/window-expected.txt: Removed.
  • svg/carto.net/button-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/button-expected.txt.
  • svg/carto.net/colourpicker-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/colourpicker-expected.txt.
  • svg/carto.net/combobox-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/combobox-expected.txt.
  • svg/carto.net/scrollbar-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/scrollbar-expected.txt.
  • svg/carto.net/selectionlist-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/selectionlist-expected.txt.
  • svg/carto.net/slider-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/slider-expected.txt.
  • svg/carto.net/tabgroup-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/tabgroup-expected.txt.
  • svg/carto.net/textbox-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/textbox-expected.txt.
  • svg/carto.net/window-expected.txt: Renamed from LayoutTests/platform/efl/svg/carto.net/window-expected.txt.
10:39 PM Changeset in webkit [159013] by akling@apple.com
  • 1 edit
    10 moves
    10 deletes in trunk/LayoutTests

Optimize baselines: svg/css

Unreviewed; run "webkit-patch optimize-baselines svg/css"

  • platform/gtk/svg/css/circle-in-mask-with-shadow-expected.png: Removed.
  • platform/gtk/svg/css/clippath-with-shadow-expected.png: Removed.
  • platform/gtk/svg/css/group-with-shadow-expected.txt: Removed.
  • platform/gtk/svg/css/path-with-shadow-expected.png: Removed.
  • platform/gtk/svg/css/shadow-with-large-radius-expected.png: Removed.
  • platform/gtk/svg/css/shadow-with-negative-offset-expected.png: Removed.
  • platform/gtk/svg/css/stars-with-shadow-expected.txt: Removed.
  • platform/gtk/svg/css/text-gradient-shadow-expected.txt: Removed.
  • platform/mac/svg/css/composite-shadow-example-expected.txt: Removed.
  • platform/mac/svg/css/composite-shadow-with-opacity-expected.txt: Removed.
  • svg/css/circle-in-mask-with-shadow-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/circle-in-mask-with-shadow-expected.png.
  • svg/css/clippath-with-shadow-expected.png: Renamed from LayoutTests/platform/efl/svg/css/clippath-with-shadow-expected.png.
  • svg/css/composite-shadow-example-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/composite-shadow-example-expected.txt.
  • svg/css/composite-shadow-with-opacity-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/composite-shadow-with-opacity-expected.txt.
  • svg/css/group-with-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/group-with-shadow-expected.txt.
  • svg/css/path-with-shadow-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/path-with-shadow-expected.png.
  • svg/css/shadow-with-large-radius-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/shadow-with-large-radius-expected.png.
  • svg/css/shadow-with-negative-offset-expected.png: Renamed from LayoutTests/platform/efl-wk1/svg/css/shadow-with-negative-offset-expected.png.
  • svg/css/stars-with-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/stars-with-shadow-expected.txt.
  • svg/css/text-gradient-shadow-expected.txt: Renamed from LayoutTests/platform/efl/svg/css/text-gradient-shadow-expected.txt.
10:37 PM Changeset in webkit [159012] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

SVGTextMetricsBuilder::walkTree() should take a RenderElement.
<​https://webkit.org/b/124105>

Make walkTree() take a RenderElement so we can use the non-virtual
firstChild() internally. All call sites had pointers to compatible
objects already.

Reviewed by Anders Carlsson.

9:48 PM Changeset in webkit [159011] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

RenderMathMLFenced should pass around operators in tighter types.
<​https://webkit.org/b/124115>

Store operator renderers in RenderMathMLOperator pointers instead
of passing them around as RenderObject.

Reviewed by Martin Robinson.

9:47 PM Changeset in webkit [159010] by akling@apple.com
  • 6 edits in trunk/Source/WebCore

Use RENDER_OBJECT_TYPE_CASTS for more types.
<​https://webkit.org/b/124112>

Generate toRenderFoo() type casting helpers for these classes:

  • RenderCombineText
  • RenderDetailsMarker
  • RenderListMarker
  • RenderVideo
  • RenderView

Reviewed by Anders Carlsson.

9:08 PM Changeset in webkit [159009] by akling@apple.com
  • 13 edits in trunk/Source/WebCore

Move MathML type checking virtuals to RenderObject.
<​https://webkit.org/b/124111>

Previously, checking the type of a MathML renderer would require
that you first check if it's a RenderMathMLBlock, and then casting
to that type to access the check you really wanted.

This change moves all the isRenderMathMLFoo() virtual functions
to RenderObject. I also made sure all the overloads were private
and marked them OVERRIDE/FINAL as appropriate.

Finally I replaced all the hand-written casting functions with
autogenerated ones using RENDER_OBJECT_TYPE_CASTS.

Reviewed by Anders Carlsson.

8:20 PM Changeset in webkit [159008] by oliver@apple.com
  • 12 edits
    3 moves
    6 adds in trunk

Add Map Iterators
​https://bugs.webkit.org/show_bug.cgi?id=124109

Reviewed by Andreas Kling.

Source/JavaScriptCore:

Added new Map iterator implementation. This is a mostly boilerplate patch
however there's a a little bit of additional logic added to the MapData iterator
to deal with the possibility of map mutation between creation of the iterator
and use of it. We'll be able to improve the performance of this substantially
by using intrinsics, however I'm pondering coming up with a better way to define
these thunks without requiring so much duplicated logic.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • runtime/CommonIdentifiers.h:
  • runtime/JSGlobalObject.cpp:
  • runtime/JSGlobalObject.h:
  • runtime/JSMapIterator.cpp: Added.

(JSC::JSMapIterator::finishCreation):
(JSC::JSMapIterator::visitChildren):
(JSC::JSMapIterator::createPair):

  • runtime/JSMapIterator.h: Added.

(JSC::JSMapIterator::createStructure):
(JSC::JSMapIterator::create):
(JSC::JSMapIterator::next):
(JSC::JSMapIterator::JSMapIterator):

  • runtime/MapData.h:

(JSC::MapData::const_iterator::ensureSlot):

  • runtime/MapIteratorConstructor.cpp: Added.

(JSC::MapIteratorConstructor::finishCreation):

  • runtime/MapIteratorConstructor.h: Added.

(JSC::MapIteratorConstructor::create):
(JSC::MapIteratorConstructor::createStructure):
(JSC::MapIteratorConstructor::MapIteratorConstructor):

  • runtime/MapIteratorPrototype.cpp: Added.

(JSC::MapIteratorPrototype::finishCreation):
(JSC::MapIteratorPrototypeFuncIterator):
(JSC::MapIteratorPrototypeFuncNext):

  • runtime/MapIteratorPrototype.h: Added.

(JSC::MapIteratorPrototype::create):
(JSC::MapIteratorPrototype::createStructure):
(JSC::MapIteratorPrototype::MapIteratorPrototype):

  • runtime/MapPrototype.cpp:

(JSC::MapPrototype::finishCreation):
(JSC::mapProtoFuncValues):
(JSC::mapProtoFuncEntries):
(JSC::mapProtoFuncKeys):

LayoutTests:

Moved map tests to a more sensible location, and added new iteration tests.

  • js/basic-map-expected.txt: Renamed from LayoutTests/js/dom/basic-map-expected.txt.
  • js/basic-map.html: Renamed from LayoutTests/js/dom/basic-map.html.
  • js/script-tests/basic-map.js: Renamed from LayoutTests/js/dom/script-tests/basic-map.js.

(set shouldBe):
(set var):

7:39 PM Changeset in webkit [159007] by Martin Robinson
  • 7 edits in trunk

[MathML] Poor spacing around delimiters in MathML Torture Test 14
​https://bugs.webkit.org/show_bug.cgi?id=122837

Reviewed by Brent Fulgham.

Instead of stretching the vertical bar with the stretchable version, just repeat
the normal vertical bar. This follows what Gecko does when rendering tall vertical
bars and also works around an issue with STIX fonts leading to poor spacing in
formulas.

Source/WebCore:

  • rendering/mathml/RenderMathMLOperator.cpp: Stretch the vertical bar with the

normal variant.

LayoutTests:

  • platform/gtk/mathml/presentation/mo-stretch-expected.png: Update to reflect new results.
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt: Ditto.
  • platform/mac/mathml/presentation/mo-stretch-expected.png: Ditto.
  • platform/mac/mathml/presentation/mo-stretch-expected.txt: Ditto.
7:36 PM Changeset in webkit [159006] by akling@apple.com
  • 2 edits
    1 copy
    20 moves
    1 add
    22 deletes in trunk/LayoutTests

Optimize baselines: svg/clip-path

Unreviewed; run "webkit-patch optimize-baselines svg/clip-path"

  • platform/efl/svg/clip-path/clip-path-pixelation-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-in-clip-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-clipped-no-content-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-pixelation-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-recursive-call-by-child-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-recursive-call-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-text-and-shape-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-text-and-stroke-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-text-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child2-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child3-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child4-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-use-as-child5-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-container-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-different-unittypes-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-different-unittypes2-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-invisibile-child-expected.png: Removed.
  • platform/gtk/svg/clip-path/clip-path-with-text-clipped-expected.txt: Removed.
  • platform/gtk/svg/clip-path/clipper-placement-issue-expected.png: Removed.
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-expected.txt: Removed.
  • platform/gtk/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Removed.
  • platform/win-future/svg/clip-path/clip-path-pixelation-expected.txt: Copied from LayoutTests/svg/clip-path/clip-path-pixelation-expected.txt.
  • svg/clip-path/clip-in-clip-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-in-clip-expected.png.
  • svg/clip-path/clip-path-clipped-no-content-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-clipped-no-content-expected.png.
  • svg/clip-path/clip-path-pixelation-expected.txt:
  • svg/clip-path/clip-path-recursive-call-by-child-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-recursive-call-by-child-expected.png.
  • svg/clip-path/clip-path-recursive-call-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-recursive-call-expected.png.
  • svg/clip-path/clip-path-text-and-shape-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-text-and-shape-expected.txt.
  • svg/clip-path/clip-path-text-and-stroke-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-text-and-stroke-expected.txt.
  • svg/clip-path/clip-path-text-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-text-expected.txt.
  • svg/clip-path/clip-path-tspan-and-stroke-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-tspan-and-stroke-expected.txt.
  • svg/clip-path/clip-path-use-as-child2-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child2-expected.png.
  • svg/clip-path/clip-path-use-as-child3-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child3-expected.png.
  • svg/clip-path/clip-path-use-as-child4-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child4-expected.png.
  • svg/clip-path/clip-path-use-as-child5-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-use-as-child5-expected.png.
  • svg/clip-path/clip-path-with-container-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-container-expected.png.
  • svg/clip-path/clip-path-with-different-unittypes-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-different-unittypes-expected.png.
  • svg/clip-path/clip-path-with-different-unittypes2-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-different-unittypes2-expected.png.
  • svg/clip-path/clip-path-with-invisibile-child-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-invisibile-child-expected.png.
  • svg/clip-path/clip-path-with-text-clipped-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/clip-path-with-text-clipped-expected.txt.
  • svg/clip-path/clipper-placement-issue-expected.png: Renamed from LayoutTests/platform/efl/svg/clip-path/clipper-placement-issue-expected.png.
  • svg/clip-path/deep-nested-clip-in-mask-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/deep-nested-clip-in-mask-expected.txt.
  • svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt: Renamed from LayoutTests/platform/efl/svg/clip-path/deep-nested-clip-in-mask-panning-expected.txt.
7:32 PM Changeset in webkit [159005] by akling@apple.com
  • 2 edits
    5 copies
    48 moves
    2 adds
    57 deletes in trunk/LayoutTests

Optimize baselines: svg/hixie

Unreviewed; run "webkit-patch optimize-baselines svg/hixie"

  • platform/efl/svg/hixie/perf/007-expected.txt: Removed.
  • platform/gtk/svg/hixie/dynamic/002-expected.png: Removed.
  • platform/gtk/svg/hixie/dynamic/003-expected.png: Removed.
  • platform/gtk/svg/hixie/dynamic/004-expected.png: Removed.
  • platform/gtk/svg/hixie/dynamic/005-expected.png: Removed.
  • platform/gtk/svg/hixie/dynamic/006-expected.png: Removed.
  • platform/gtk/svg/hixie/error/001-expected.png: Removed.
  • platform/gtk/svg/hixie/error/002-expected.png: Removed.
  • platform/gtk/svg/hixie/error/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/003-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/006-expected.png: Removed.
  • platform/gtk/svg/hixie/error/007-expected.png: Removed.
  • platform/gtk/svg/hixie/error/008-expected.png: Removed.
  • platform/gtk/svg/hixie/error/009-expected.png: Removed.
  • platform/gtk/svg/hixie/error/010-expected.png: Removed.
  • platform/gtk/svg/hixie/error/010-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/011-expected.png: Removed.
  • platform/gtk/svg/hixie/error/011-expected.txt: Removed.
  • platform/gtk/svg/hixie/error/014-expected.png: Removed.
  • platform/gtk/svg/hixie/error/014-test-expected.png: Removed.
  • platform/gtk/svg/hixie/error/015-expected.png: Removed.
  • platform/gtk/svg/hixie/error/016-expected.png: Removed.
  • platform/gtk/svg/hixie/error/017-expected.txt: Removed.
  • platform/gtk/svg/hixie/intrinsic/001-expected.png: Removed.
  • platform/gtk/svg/hixie/intrinsic/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/intrinsic/002-expected.png: Removed.
  • platform/gtk/svg/hixie/intrinsic/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/links/002-expected.png: Removed.
  • platform/gtk/svg/hixie/links/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/mixed/007-expected.png: Removed.
  • platform/gtk/svg/hixie/painting/001-expected.png: Removed.
  • platform/gtk/svg/hixie/perf/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/003-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/004-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/005-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/006-expected.txt: Removed.
  • platform/gtk/svg/hixie/perf/007-expected.txt: Removed.
  • platform/gtk/svg/hixie/processing-model/003-expected.png: Removed.
  • platform/gtk/svg/hixie/processing-model/004-expected.png: Removed.
  • platform/gtk/svg/hixie/processing-model/005-expected.png: Removed.
  • platform/gtk/svg/hixie/rendering-model/003a-expected.png: Removed.
  • platform/gtk/svg/hixie/shapes/path/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/text/002-expected.txt: Removed.
  • platform/gtk/svg/hixie/text/003a-expected.txt: Removed.
  • platform/gtk/svg/hixie/text/003b-expected.txt: Removed.
  • platform/gtk/svg/hixie/use/001-expected.png: Removed.
  • platform/gtk/svg/hixie/use/002-expected.png: Removed.
  • platform/gtk/svg/hixie/use/002-test-expected.png: Removed.
  • platform/gtk/svg/hixie/viewbox/001-expected.png: Removed.
  • platform/gtk/svg/hixie/viewbox/004-expected.png: Removed.
  • platform/gtk/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Removed.
  • platform/gtk/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Removed.
  • platform/mac/svg/hixie/cascade/002-expected.txt: Removed.
  • platform/mac/svg/hixie/perf/004-expected.txt: Removed.
  • platform/mac/svg/hixie/perf/005-expected.txt: Removed.
  • platform/mac/svg/hixie/perf/006-expected.txt: Removed.
  • platform/win-future/svg/hixie/perf/007-expected.txt: Copied from LayoutTests/svg/hixie/perf/007-expected.txt.
  • svg/hixie/cascade/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/cascade/002-expected.txt.
  • svg/hixie/dynamic/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/002-expected.png.
  • svg/hixie/dynamic/003-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/003-expected.png.
  • svg/hixie/dynamic/004-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/004-expected.png.
  • svg/hixie/dynamic/005-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/005-expected.png.
  • svg/hixie/dynamic/006-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/dynamic/006-expected.png.
  • svg/hixie/error/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/001-expected.png.
  • svg/hixie/error/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/002-expected.png.
  • svg/hixie/error/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/002-expected.txt.
  • svg/hixie/error/003-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/003-expected.txt.
  • svg/hixie/error/006-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/006-expected.png.
  • svg/hixie/error/007-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/007-expected.png.
  • svg/hixie/error/008-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/008-expected.png.
  • svg/hixie/error/009-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/009-expected.png.
  • svg/hixie/error/010-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/010-expected.png.
  • svg/hixie/error/010-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/010-expected.txt.
  • svg/hixie/error/011-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/011-expected.png.
  • svg/hixie/error/011-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/011-expected.txt.
  • svg/hixie/error/014-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/014-expected.png.
  • svg/hixie/error/014-test-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/014-test-expected.png.
  • svg/hixie/error/015-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/015-expected.png.
  • svg/hixie/error/016-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/error/016-expected.png.
  • svg/hixie/error/017-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/error/017-expected.txt.
  • svg/hixie/intrinsic/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/001-expected.png.
  • svg/hixie/intrinsic/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/001-expected.txt.
  • svg/hixie/intrinsic/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/002-expected.png.
  • svg/hixie/intrinsic/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/intrinsic/002-expected.txt.
  • svg/hixie/links/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/links/002-expected.png.
  • svg/hixie/links/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/links/002-expected.txt.
  • svg/hixie/mixed/007-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/mixed/007-expected.png.
  • svg/hixie/painting/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/painting/001-expected.png.
  • svg/hixie/perf/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/001-expected.txt.
  • svg/hixie/perf/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/002-expected.txt.
  • svg/hixie/perf/003-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/003-expected.txt.
  • svg/hixie/perf/004-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/004-expected.txt.
  • svg/hixie/perf/005-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/005-expected.txt.
  • svg/hixie/perf/006-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/perf/006-expected.txt.
  • svg/hixie/perf/007-expected.txt:
  • svg/hixie/processing-model/003-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/processing-model/003-expected.png.
  • svg/hixie/processing-model/004-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/processing-model/004-expected.png.
  • svg/hixie/processing-model/005-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/processing-model/005-expected.png.
  • svg/hixie/rendering-model/003a-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/rendering-model/003a-expected.png.
  • svg/hixie/shapes/path/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/shapes/path/001-expected.txt.
  • svg/hixie/text/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/text/002-expected.txt.
  • svg/hixie/text/003a-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/text/003a-expected.txt.
  • svg/hixie/text/003b-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/text/003b-expected.txt.
  • svg/hixie/use/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/use/001-expected.png.
  • svg/hixie/use/002-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/use/002-expected.png.
  • svg/hixie/use/002-test-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/use/002-test-expected.png.
  • svg/hixie/viewbox/001-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/001-expected.png.
  • svg/hixie/viewbox/004-expected.png: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/004-expected.png.
  • svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt.
  • svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Renamed from LayoutTests/platform/efl/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt.
5:27 PM Changeset in webkit [159004] by andersca@apple.com
  • 7 edits in trunk/Source

Encode form data using the KeyedEncoder
​https://bugs.webkit.org/show_bug.cgi?id=124107

Reviewed by Sam Weinig.

Source/WebCore:

  • platform/KeyedCoding.h:

(WebCore::KeyedEncoder::encodeEnum):

  • platform/network/FormData.cpp:

(WebCore::encodeElement):
(WebCore::FormData::encode):

  • platform/network/FormData.h:

Source/WebKit2:

  • Shared/cf/KeyedEncoder.cpp:

(WebKit::KeyedEncoder::encodeBool):
(WebKit::KeyedEncoder::encodeDouble):

  • Shared/cf/KeyedEncoder.h:
3:26 PM Changeset in webkit [159003] by andersca@apple.com
  • 1 edit
    1 delete in trunk/Source/WebKit2

Remove an unused file.

Rubber-stamped by Andreas Kling.

  • WebProcess/WebPage/gtk/ChunkedUpdateDrawingAreaGtk.cpp: Removed.
1:41 PM Changeset in webkit [159002] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Modernize CanvasObserverProxy
​https://bugs.webkit.org/show_bug.cgi?id=124106

Reviewed by Anders Carlsson.

  • css/CSSCanvasValue.h:
12:59 PM Changeset in webkit [159001] by Patrick Gansterer
  • 101 edits
    7 moves
    1 add in trunk/Source

Move RunLoop from WebCore to WTF
​https://bugs.webkit.org/show_bug.cgi?id=116606

Reviewed by Anders Carlsson.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • PlatformBlackBerry.cmake:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • PlatformWin.cmake:
  • WebCore.exp.in:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

Source/WebKit/mac:

  • Carbon/CarbonWindowAdapter.mm:

(+[CarbonWindowAdapter initialize]):

  • History/WebBackForwardList.mm:

(+[WebBackForwardList initialize]):

  • History/WebHistoryItem.mm:

(+[WebHistoryItem initialize]):

  • Misc/WebCache.mm:

(+[WebCache initialize]):

  • Misc/WebElementDictionary.mm:

(+[WebElementDictionary initialize]):

  • Misc/WebIconDatabase.mm:

(+[WebIconDatabase initialize]):

  • Plugins/Hosted/WebHostedNetscapePluginView.mm:

(+[WebHostedNetscapePluginView initialize]):

  • Plugins/WebBaseNetscapePluginView.mm:
  • Plugins/WebBasePluginPackage.mm:
  • Plugins/WebNetscapePluginView.mm:

(+[WebNetscapePluginView initialize]):

  • WebCoreSupport/WebEditorClient.mm:

(+[WebUndoStep initialize]):

  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebView/WebArchive.mm:

(+[WebArchivePrivate initialize]):

  • WebView/WebDataSource.mm:

(+[WebDataSource initialize]):

  • WebView/WebHTMLView.mm:

(+[WebHTMLViewPrivate initialize]):
(+[WebHTMLView initialize]):

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

  • WebView/WebResource.mm:

(+[WebResourcePrivate initialize]):

  • WebView/WebTextIterator.mm:

(+[WebTextIteratorPrivate initialize]):

  • WebView/WebView.mm:

(+[WebView initialize]):

  • WebView/WebViewData.mm:

(+[WebViewPrivate initialize]):

Source/WebKit2:

  • DatabaseProcess/DatabaseProcess.cpp:
  • DatabaseProcess/DatabaseToWebProcessConnection.cpp:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:
  • NetworkProcess/NetworkProcess.cpp:
  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/mac/DiskCacheMonitor.h:
  • NetworkProcess/unix/NetworkProcessMainUnix.cpp:
  • Platform/CoreIPC/Connection.cpp:
  • Platform/CoreIPC/Connection.h:
  • Platform/CoreIPC/mac/ConnectionMac.cpp:
  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
  • PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:
  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginProcess.cpp:
  • PluginProcess/PluginProcess.h:
  • PluginProcess/WebProcessConnection.cpp:
  • PluginProcess/unix/PluginProcessMainUnix.cpp:
  • Shared/ChildProcess.cpp:
  • Shared/ChildProcess.h:
  • Shared/ChildProcessProxy.cpp:
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.h:
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.mm:
  • Shared/Plugins/NPObjectProxy.cpp:
  • Shared/WebKit2Initialize.cpp:

(WebKit::InitializeWebKit2):

  • UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
  • UIProcess/API/mac/FindIndicatorWindow.h:
  • UIProcess/API/mac/WKPrintingView.mm:
  • UIProcess/API/mac/WKView.mm:
  • UIProcess/CoordinatedGraphics/CoordinatedDrawingAreaProxy.h:
  • UIProcess/DrawingAreaProxyImpl.h:
  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:
  • UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:
  • UIProcess/Network/NetworkProcessProxy.cpp:
  • UIProcess/Plugins/PluginProcessProxy.cpp:
  • UIProcess/ResponsivenessTimer.cpp:
  • UIProcess/ResponsivenessTimer.h:
  • UIProcess/VisitedLinkProvider.h:
  • UIProcess/WebContext.cpp:
  • UIProcess/WebProcessProxy.cpp:
  • WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
  • WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
  • WebProcess/Network/WebResourceLoadScheduler.h:
  • WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/Netscape/NetscapePluginStream.h:
  • WebProcess/Plugins/PluginView.h:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/EventDispatcher.cpp:
  • WebProcess/WebPage/PageOverlay.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebProcess.cpp:
  • WebProcess/efl/WebProcessMainEfl.cpp:
  • WebProcess/gtk/WebProcessMainGtk.cpp:

Source/WTF:

With this change RunLoop can be used in JavaScriptCore too.

  • GNUmakefile.list.am:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/PlatformBlackBerry.cmake:
  • wtf/PlatformEfl.cmake:
  • wtf/PlatformGTK.cmake:
  • wtf/PlatformWin.cmake:
  • wtf/RunLoop.cpp: Renamed from Source/WebCore/platform/RunLoop.cpp.

(WTF::RunLoop::Holder::Holder):
(WTF::RunLoop::Holder::runLoop):
(WTF::RunLoop::initializeMainRunLoop):
(WTF::RunLoop::current):
(WTF::RunLoop::main):
(WTF::RunLoop::isMain):
(WTF::RunLoop::performWork):
(WTF::RunLoop::dispatch):

  • wtf/RunLoop.h: Renamed from Source/WebCore/platform/RunLoop.h.

(WTF::RunLoop::TimerBase::startRepeating):
(WTF::RunLoop::TimerBase::startOneShot):
(WTF::RunLoop::TimerBase::isRepeating):
(WTF::RunLoop::Timer::Timer):
(WTF::RunLoop::Timer::fired):

  • wtf/blackberry/RunLoopBlackBerry.cpp: Renamed from Source/WebCore/platform/blackberry/RunLoopBlackBerry.cpp.

(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::wakeUp):

  • wtf/cf/RunLoopCF.cpp: Renamed from Source/WebCore/platform/cf/RunLoopCF.cpp.

(WTF::RunLoop::performWork):
(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::runForDuration):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::run):
(WTF::RunLoop::stop):
(WTF::RunLoop::TimerBase::timerFired):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

  • wtf/efl/RunLoopEfl.cpp: Renamed from Source/WebCore/platform/efl/RunLoopEfl.cpp.

(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::run):
(WTF::RunLoop::stop):
(WTF::RunLoop::wakeUpEvent):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::timerFired):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

  • wtf/gtk/RunLoopGtk.cpp: Renamed from Source/WebCore/platform/gtk/RunLoopGtk.cpp.

(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::run):
(WTF::RunLoop::innermostLoop):
(WTF::RunLoop::pushNestedMainLoop):
(WTF::RunLoop::popNestedMainLoop):
(WTF::RunLoop::stop):
(WTF::RunLoop::queueWork):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::clearTimerSource):
(WTF::RunLoop::TimerBase::timerFiredCallback):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

  • wtf/win/RunLoopWin.cpp: Renamed from Source/WebCore/platform/win/RunLoopWin.cpp.

(WTF::RunLoop::RunLoopWndProc):
(WTF::RunLoop::wndProc):
(WTF::RunLoop::run):
(WTF::RunLoop::stop):
(WTF::RunLoop::registerRunLoopMessageWindowClass):
(WTF::RunLoop::RunLoop):
(WTF::RunLoop::~RunLoop):
(WTF::RunLoop::wakeUp):
(WTF::RunLoop::TimerBase::timerFired):
(WTF::generateTimerID):
(WTF::RunLoop::TimerBase::TimerBase):
(WTF::RunLoop::TimerBase::~TimerBase):
(WTF::RunLoop::TimerBase::start):
(WTF::RunLoop::TimerBase::stop):
(WTF::RunLoop::TimerBase::isActive):

8:11 AM Changeset in webkit [159000] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Tighten typing in SVGResourcesCycleSolver a bit.
<​https://webkit.org/b/124104>

Make the SVGResourcesCycleSolver constructor take a RenderElement&
and a SVGResources&.

While I was in the neighborhood, also converted one loop to use a
renderer iterator instead of walking siblings manually.

Finally used "auto" to clean up some overly wordy loops.

Reviewed by Anders Carlsson.

3:32 AM Changeset in webkit [158999] by akling@apple.com
  • 18 edits in trunk/Source/WebCore

Beat SVGRenderSupport with the RenderElement stick.
<​https://webkit.org/b/124102>

Tighten up all the SVGRenderSupport helper functions by making them
take const RenderElements references instead of raw RenderObject
pointers as much as possible.

This tunes up a bunch of branchy style() calls.

The patch looks big but it's mostly mechanical. I just changed the
signatures and then worked backwards until everything built again.

Reviewed by Antti Koivisto.

3:17 AM Changeset in webkit [158998] by akling@apple.com
  • 10 edits in trunk/Source/WebCore

SVGTextLayoutAttributes always has a RenderSVGInlineText.
<​https://webkit.org/b/124101>

No SVGTextLayoutAttributes object is without a RenderSVGInlineText
"context" so make context() return a reference.

Reviewed by Antti Koivisto.

3:16 AM Changeset in webkit [158997] by akling@apple.com
  • 13 edits
    2 deletes in trunk/Source/WebCore

Move BindingSecurity stuff under JSDOMBinding umbrella.
<​https://webkit.org/b/124099>

We are hitting shouldAllowAccessToDOMWindow() pretty hard on the
demo here: <​http://www.jasondavies.com/maps/rotate/>

Putting it together with the rest of the JSDOMBinding code takes
CPU time spent in there from 8.7% to 6.5%. The abstraction was
only used to support alternate JS engines in the past.

Reviewed by Antti Koivisto.

3:14 AM Changeset in webkit [158996] by Antti Koivisto
  • 2 edits in trunk/PerformanceTests

Add subtest for word-break:break-all to Layout/line-layout-simple.html
​https://bugs.webkit.org/show_bug.cgi?id=124103

Reviewed by Andreas Kling.

  • Layout/line-layout-simple.html:

Combination "white-space:pre-wrap; word-break:break-all" is common for pure text.

Nov 8, 2013:

11:57 PM Changeset in webkit [158995] by zandobersek@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed GTK build fix.

  • GNUmakefile.list.am: Remove redundant build targets.
10:55 PM Changeset in webkit [158994] by fpizlo@apple.com
  • 4 edits
    2 deletes in trunk/Source/JavaScriptCore

Remove dead FTL C ABI support
​https://bugs.webkit.org/show_bug.cgi?id=124100

Reviewed by Jer Noble.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • ftl/FTLCArgumentGetter.cpp: Removed.
  • ftl/FTLCArgumentGetter.h: Removed.
  • ftl/FTLOSRExitCompiler.cpp:
  • jit/FPRInfo.h:
10:53 PM Changeset in webkit [158993] by fpizlo@apple.com
  • 3 edits in trunk/WebKitLibraries

Update binary drops to a version that includes new stackmap fixes and exposes the new calling conventions.

  • LLVMIncludesMountainLion.tar.bz2:
  • LLVMLibrariesMountainLion.tar.bz2:
10:27 PM Changeset in webkit [158992] by beidson@apple.com
  • 39 edits
    2 moves
    1 delete in trunk/Source

Merge IDBDatabaseBackendInterface and IDBDatabaseBackendImpl
​https://bugs.webkit.org/show_bug.cgi?id=124088

Source/WebCore:

Reviewed by Tim Horton.

Source/WebKit2:

Reviewed by Tim Horton.

This abstraction is no longer meaningful in its current form in WebCore.
The current groundwork for the WK2 DatabaseProcess relied on this abstraction,
but that will be reworked in a future patch.

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBDatabaseBackend.h:
  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::maybeCreateTransactionBackend):
(WebKit::WebIDBFactoryBackend::createCursorBackend):

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
  • WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.cpp:

(WebKit::WebProcessIDBDatabaseBackend::put):
(WebKit::WebProcessIDBDatabaseBackend::openCursor):

  • WebProcess/Databases/IndexedDB/WebProcessIDBDatabaseBackend.h:
10:00 PM Changeset in webkit [158991] by commit-queue@webkit.org
  • 12 edits in trunk/LayoutTests

Updating LayoutTests that depend on RTCPeerConnection
​https://bugs.webkit.org/show_bug.cgi?id=124097

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-11-08
Reviewed by Eric Carlson.

Needed to do not throw unwanted exception

  • fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
  • fast/mediastream/RTCPeerConnection-createAnswer.html:
  • fast/mediastream/RTCPeerConnection-createOffer.html:
  • fast/mediastream/RTCPeerConnection-datachannel.html:
  • fast/mediastream/RTCPeerConnection-dtmf.html:
  • fast/mediastream/RTCPeerConnection-events.html:
  • fast/mediastream/RTCPeerConnection-ice.html:
  • fast/mediastream/RTCPeerConnection-localDescription.html:
  • fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
  • fast/mediastream/RTCPeerConnection-remoteDescription.html:
  • fast/mediastream/RTCPeerConnection-state.html:
8:40 PM Changeset in webkit [158990] by ljaehun.lim@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix after r158984.

No needs to include "KeyedEncoder.h".
WebKit/Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp:31:26: fatal error: KeyedEncoder.h: No such file or directory

  • WebProcess/WebPage/WebBackForwardListProxy.cpp: Removed #include line.
8:24 PM Changeset in webkit [158989] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

FTL should support Phantom(FinalObject:)
​https://bugs.webkit.org/show_bug.cgi?id=124092

Reviewed by Oliver Hunt.

  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::isType):
(JSC::FTL::LowerDFGToLLVM::isNotType):
(JSC::FTL::LowerDFGToLLVM::speculateFinalObject):

8:20 PM Changeset in webkit [158988] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Get rid of the FTL tail call APIs since they are unused
​https://bugs.webkit.org/show_bug.cgi?id=124093

Reviewed by Oliver Hunt.

  • ftl/FTLAbbreviations.h:

(JSC::FTL::buildCall):

  • ftl/FTLOutput.h:
8:17 PM Changeset in webkit [158987] by commit-queue@webkit.org
  • 25 edits in trunk/LayoutTests

Improving readability of LayoutTests in fast/mediastream
​https://bugs.webkit.org/show_bug.cgi?id=124095

Adding some indentation

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-11-08
Reviewed by Eric Carlson.

  • fast/mediastream/MediaStream-add-remove-tracks.html:
  • fast/mediastream/MediaStream-onended.html:
  • fast/mediastream/MediaStreamConstructor.html:
  • fast/mediastream/RTCIceCandidate.html:
  • fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
  • fast/mediastream/RTCPeerConnection-createAnswer.html:
  • fast/mediastream/RTCPeerConnection-createOffer.html:
  • fast/mediastream/RTCPeerConnection-datachannel.html:
  • fast/mediastream/RTCPeerConnection-dtmf.html:
  • fast/mediastream/RTCPeerConnection-events.html:
  • fast/mediastream/RTCPeerConnection-ice.html:
  • fast/mediastream/RTCPeerConnection-localDescription.html:
  • fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
  • fast/mediastream/RTCPeerConnection-remoteDescription.html:
  • fast/mediastream/RTCPeerConnection-state.html:
  • fast/mediastream/RTCPeerConnection-stats.html:
  • fast/mediastream/RTCPeerConnection-statsSelector.html:
  • fast/mediastream/RTCPeerConnection.html:
  • fast/mediastream/RTCSessionDescription.html:
  • fast/mediastream/argument-types.html:
  • fast/mediastream/constructors.html:
  • fast/mediastream/enabled.html:
  • fast/mediastream/getusermedia.html:
  • fast/mediastream/no-interface-object.html:
7:40 PM Changeset in webkit [158986] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Reindent JSDOMBinding.h (finally.)

Rubber-stamped by Sam Weinig.

7:24 PM Changeset in webkit [158985] by weinig@apple.com
  • 64 edits in trunk/Source/WebCore

Change collectStyleForPresentationAttribute and related functions to take a MutableStylePropertySet by reference
​https://bugs.webkit.org/show_bug.cgi?id=124096

Reviewed by Andreas Kling.

Pass MutableStylePropertySet by reference. It is never null.

5:51 PM Changeset in webkit [158984] by andersca@apple.com
  • 7 edits in trunk/Source

Implement encoding of arrays of objects
​https://bugs.webkit.org/show_bug.cgi?id=124091

Reviewed by Beth Dakin.

Source/WebCore:

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTreeNode):
Encode the rest of the members.

  • platform/KeyedCoding.h:

(WebCore::KeyedEncoder::encodeObjects):
Call beginArray, then beginArrayElement/endArrayElement for every element and lastly endArray.

Source/WebKit2:

Add a new array stack and push and pop from it accordingly.

  • Shared/cf/KeyedEncoder.cpp:

(WebKit::KeyedEncoder::~KeyedEncoder):
(WebKit::KeyedEncoder::encodeBytes):
(WebKit::KeyedEncoder::encodeUInt32):
(WebKit::KeyedEncoder::encodeInt32):
(WebKit::KeyedEncoder::encodeInt64):
(WebKit::KeyedEncoder::encodeFloat):
(WebKit::KeyedEncoder::beginArray):
(WebKit::KeyedEncoder::beginArrayElement):
(WebKit::KeyedEncoder::endArrayElement):
(WebKit::KeyedEncoder::endArray):

  • Shared/cf/KeyedEncoder.h:
5:44 PM Changeset in webkit [158983] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

FTL should support AllocatePropertyStorage
​https://bugs.webkit.org/show_bug.cgi?id=124086

Reviewed by Oliver Hunt.

Also rationalized some offsets in the DFG.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileAllocatePropertyStorage):

5:43 PM Changeset in webkit [158982] by timothy_horton@apple.com
  • 13 edits in trunk/Source

Remote Layer Tree: RemoteLayerBackingStore partial repaint is broken for the tile cache
​https://bugs.webkit.org/show_bug.cgi?id=123944

Reviewed by Simon Fraser.

Ensure that the tile cache retrieves repaint rects from the tile layer,
not from the tiled backing layer.

Rework RemoteLayerBackingStore painting to fix some rounding issues
that would cause pixel cracks upon repaint, and to speed it up a bit.

  • Shared/mac/RemoteLayerBackingStore.h:

Redefine RepaintRectList because we can't include WebLayer.h here yet.
Remove createBackingStore, which was never implemented.
Remove mapToContentCoordinates, because we don't need it on Mac.

(WebKit::RemoteLayerBackingStore::paintingRects): Added.

  • Shared/mac/RemoteLayerBackingStore.mm:

(RemoteLayerBackingStore::setNeedsDisplay):
(RemoteLayerBackingStore::display):
Stop using mapToContentCoordinates.

(RemoteLayerBackingStore::drawInContext):
Use clipping instead of painting the image multiple times.
Never repaint more than the dirty region's bounds.
Don't waste time with all of the drawNativeImage code, just use CG.
Unindent the switch's cases.
Store the rects we're painting so that enumerateRectsBeingDrawn can get them.
Pixel-snap the rects we're painting.
Clip the context before going to paint.

  • WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:

(PlatformCALayerRemote::enumerateRectsBeingDrawn):

  • WebProcess/WebPage/mac/PlatformCALayerRemote.h:

Retrieve the rects currently being painted from our backing store, and
transform them (mostly) according to the CTM, to match the transformation
that will have occurred underneath wkCALayerEnumerateRectsBeingDrawnWithBlock.

  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayerMac::enumerateRectsBeingDrawn):
Allow the PlatformCALayer to decide how to enumerate rects to paint.

  • WebCore.exp.in:
  • platform/graphics/mac/WebLayer.h:

Add RepaintRectList, remove some unnecessary WebCore::s.

  • platform/graphics/mac/WebLayer.mm:

(WebCore::collectRectsToPaint):
Factor collectRectsToPaint out; it just grabs the rects from
the layer and makes the decision whether to repaint the bounds
of the dirty region or just the subregions.

Move calls to collectRectsToPaint() to callers of drawLayerContents(),
so that TileController can collect rects from the appropriate source
(the Tile layer) and other layers just continue grabbing them from
their relevant layers.

Make sure that the list that comes from collectRectsToPaint() always
has at least one rect in it (appending the clip bounds if we don't
want to repaint subregions) so we can simplify logic in drawLayerContents.

(WebCore::drawLayerContents):
Remove code to support CompositingCoordinatesBottomUp, as it's only
used on Windows, so this Mac-specific code doesn't need to support it.

Simplify logic given that dirtyRects will always be non-empty.

(-[WebLayer drawInContext:]):
(-[WebSimpleLayer setNeedsDisplayInRect:]):

  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::platformCALayerPaintContents):
Adopt collectRectsToPaint.

5:29 PM Changeset in webkit [158981] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Get rid of the bizarre Darwin/x86-only MacroAssembler::shouldBlindForSpecificArch(uintptr_t) overload
​https://bugs.webkit.org/show_bug.cgi?id=124087

Reviewed by Michael Saboff.

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::shouldBlindPointerForSpecificArch):
(JSC::MacroAssembler::shouldBlind):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::shouldBlindForSpecificArch):

5:16 PM Changeset in webkit [158980] by andersca@apple.com
  • 7 edits in trunk/Source

Implement more KeyedEncoder functionality
​https://bugs.webkit.org/show_bug.cgi?id=124089

Reviewed by Beth Dakin.

Source/WebCore:

  • bindings/js/SerializedScriptValue.h:
  • history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTreeNode):

  • platform/KeyedCoding.h:

(WebCore::KeyedEncoder::encodeConditionalObject):

Source/WebKit2:

  • Shared/cf/KeyedEncoder.cpp:

(WebKit::KeyedEncoder::encodeBytes):
(WebKit::KeyedEncoder::encodeInt32):
(WebKit::KeyedEncoder::encodeFloat):

  • Shared/cf/KeyedEncoder.h:
5:13 PM Changeset in webkit [158979] by eric.carlson@apple.com
  • 3 edits
    2 adds in trunk

getCueAsHTML() on an empty cue should return a document fragment
​https://bugs.webkit.org/show_bug.cgi?id=124084

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-cue-empty-cue-text.html

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::createDocumentFragmentFromCueText): Don't return early when the

passed an empty string.

LayoutTests:

  • media/track/track-cue-empty-cue-text-expected.txt: Added.
  • media/track/track-cue-empty-cue-text.html: Added.
4:51 PM Changeset in webkit [158978] by andersca@apple.com
  • 7 edits in trunk/Source

KeyedEncoder should be able to encoder objects
​https://bugs.webkit.org/show_bug.cgi?id=124085

Reviewed by Sam Weinig.

Source/WebCore:

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTree):
Encode the root object.

(WebCore::HistoryItem::encodeBackForwardTreeNode):
Encode the target.

  • history/HistoryItem.h:

Add new members.

  • platform/KeyedCoding.h:

(WebCore::KeyedEncoder::encodeObject):
Call beginObject, call the functor and then call endObject().

Source/WebKit2:

Add a dictionary stack to KeyedEncoder that's pushed and popped by
beginObject/endObject.

  • Shared/cf/KeyedEncoder.cpp:

(WebKit::KeyedEncoder::KeyedEncoder):
(WebKit::KeyedEncoder::~KeyedEncoder):
(WebKit::KeyedEncoder::encodeUInt32):
(WebKit::KeyedEncoder::encodeString):
(WebKit::KeyedEncoder::beginObject):
(WebKit::KeyedEncoder::endObject):

  • Shared/cf/KeyedEncoder.h:
4:42 PM Changeset in webkit [158977] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

FTL should support NewArrayBuffer
​https://bugs.webkit.org/show_bug.cgi?id=124067

Reviewed by Michael Saboff.

This expanded coverage and revealed some bugs.

This revealed a bug in FTL::OSRExitCompiler where it was assuming that it could save
the framePointer in regT3 even though DFG::reifyInlinedCallFrames() would clobber it.
It turns out that this can be fixed by just completely restoring the stack prior to
doing reifyInlineCallFrames().

I used this as an opportunity to simplify NewArray. That revealed a bug; whenever we say
lowJSValue() in there we need to use ManualOperandSpeculation since we're using it to
rebox values even when we also have to do some speculations. The speculations are done
at the top of compileNewArray().

This also revealed a bug in StringCharAt() for the OOB case.

  • ftl/FTLAbstractHeapRepository.h:

(JSC::FTL::AbstractHeapRepository::forIndexingType):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNewArray):
(JSC::FTL::LowerDFGToLLVM::compileNewArrayBuffer):
(JSC::FTL::LowerDFGToLLVM::compileStringCharAt):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

4:39 PM Changeset in webkit [158976] by Alexandru Chiculita
  • 4 edits
    2 adds in trunk

Web Inspector: It should be possible to debug the Inspector code
​https://bugs.webkit.org/show_bug.cgi?id=124065

Reviewed by Timothy Hatcher.

Source/WebKit2:

When the script is paused, the debugger will pause all the pages in the same PageGroup.
All the Inspector windows were created in the same PageGroup, so pausing one debugger
would stop the other too.

Added WebInspectorPageGroups to manage the PageGroups created for the Inspectors.
The WebInspectors will now use the inspection "level" to figure out which PageGroup to use.
The inspector that debugs the main page will use "WebInspectorPageGroupLevel1",
the second inspector (that debugs the first inspector) will use "WebInspectorPageGroupLevel2" ...

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorPageGroups::shared):
(WebKit::WebInspectorPageGroups::inspectorLevel):
(WebKit::WebInspectorPageGroups::isInspectorPageGroup):
(WebKit::WebInspectorPageGroups::inspectorPageGroupLevel):
(WebKit::WebInspectorPageGroups::inspectorPageGroupForLevel):
(WebKit::WebInspectorPageGroups::createInspectorPageGroup):
(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::inspectorPageGroup):
(WebKit::WebInspectorProxy::isInspectorPage):
(WebKit::WebInspectorProxy::canAttach):

  • UIProcess/WebInspectorProxy.h:

LayoutTests:

Added test to check that a second inspector window can be used to debug the first one.

  • inspector-protocol/debugger/nested-inspectors-expected.txt: Added.
  • inspector-protocol/debugger/nested-inspectors.html: Added.
4:39 PM Changeset in webkit [158975] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

It should be easy to disable blinding on a per-architecture basis
​https://bugs.webkit.org/show_bug.cgi?id=124083

Reviewed by Michael Saboff.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::haveScratchRegisterForBlinding):
(JSC::AbstractMacroAssembler::scratchRegisterForBlinding):
(JSC::AbstractMacroAssembler::canBlind):
(JSC::AbstractMacroAssembler::shouldBlindForSpecificArch):

  • assembler/MacroAssembler.h:

(JSC::MacroAssembler::shouldBlind):
(JSC::MacroAssembler::store32):
(JSC::MacroAssembler::branch32):
(JSC::MacroAssembler::branchAdd32):
(JSC::MacroAssembler::branchMul32):

  • assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::canBlind):

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::haveScratchRegisterForBlinding):

4:32 PM Changeset in webkit [158974] by matthew_hanson@apple.com
  • 5 edits in branches/safari-537.73-branch/Source

Versioning.

4:29 PM Changeset in webkit [158973] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-537.73.5

New Tag.

4:27 PM Changeset in webkit [158972] by weinig@apple.com
  • 5 edits in trunk/Source/WebCore

Teach CanvasObserver about references
​https://bugs.webkit.org/show_bug.cgi?id=124082

Reviewed by Anders Carlsson.

  • css/CSSCanvasValue.cpp:
  • css/CSSCanvasValue.h:
  • html/HTMLCanvasElement.cpp:
  • html/HTMLCanvasElement.h:
4:25 PM Changeset in webkit [158971] by andersca@apple.com
  • 8 edits
    3 moves
    2 deletes in trunk/Source

Begin stubbing out a KeyedEncoder class in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=124079

Reviewed by Sam Weinig.

Source/WebCore:

  • WebCore.exp.in:

Add symbol needed by WebCore.

  • WebCore.xcodeproj/project.pbxproj:

Add new header file.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::encodeBackForwardTree):

  • history/HistoryItem.h:

Add an encodeBackForwardTree overload that takes a KeyedEncoder object. Encode the version.

  • platform/KeyedCoding.h:

Add a KeyedEncoder class that just has a single encodeUInt32 member function for now.

Source/WebKit2:

  • Shared/KeyedEncoder.h: Removed.
  • Shared/cf/KeyedCodingValueCF.cpp: Removed.
  • Shared/cf/KeyedEncoder.cpp: Added.

Remove old keyed encoders.

(WebKit::createDictionary):
Helper function to create a mutable dictionary.
(WebKit::KeyedEncoder::KeyedEncoder):
Create the root dictionary.

(WebKit::KeyedEncoder::encodeUInt32):
Create a CFNumberRef and add it to the dictionary.

  • Shared/cf/KeyedEncoder.h: Added.
  • WebKit2.xcodeproj/project.pbxproj:

Add new files.

  • WebProcess/WebPage/WebBackForwardListProxy.cpp:

(WebKit::updateBackForwardItem):
Create a KeyedEncoder and encode the history tree.

4:18 PM Changeset in webkit [158970] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/JavaScriptCore

Rollout r158882. <rdar://problem/15426318>

4:09 PM Changeset in webkit [158969] by beidson@apple.com
  • 20 edits
    1 move
    1 add
    2 deletes in trunk/Source

Merge IDBTransactionBackendInterface and IDBTransactionBackendImpl
​https://bugs.webkit.org/show_bug.cgi?id=124077

Reviewed by Alexey Proskuryakov.

Source/WebCore:

The abstraction is no longer needed.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:
  • Modules/indexeddb/IDBTransactionBackendInterface.h: Removed.
  • Modules/indexeddb/IDBTransactionBackend.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.cpp.
  • Modules/indexeddb/IDBTransactionBackend.h: Renamed from Source/WebCore/Modules/indexeddb/IDBTransactionBackendImpl.h.
  • Modules/indexeddb/IDBBackingStoreInterface.h:
  • Modules/indexeddb/IDBCursorBackend.cpp:
  • Modules/indexeddb/IDBCursorBackend.h:
  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
  • Modules/indexeddb/IDBDatabaseBackendImpl.h:
  • Modules/indexeddb/IDBFactoryBackendInterface.h:
  • Modules/indexeddb/IDBTransactionBackendOperations.h:
  • Modules/indexeddb/IDBTransactionCoordinator.cpp:
  • Modules/indexeddb/IDBTransactionCoordinator.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.h:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:

Source/WebKit2:

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:
  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
3:53 PM Changeset in webkit [158968] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

REGRESSION (r155660): Some Etherpad pages not scrollable with overlay scrollbars
​https://bugs.webkit.org/show_bug.cgi?id=124075

Reviewed by Beth Dakin.

In r155660 I removed some scrollbar-related layouts when scrollbars
are in overlay mode.

However, ScrollView::updateScrollbars() has a case where we still need
to do multiple pases, related to its "Never ever try to both gain/lose a
scrollbar in the same pass" comment. When we avoid making a new scrollbar
because the other was removed, we need to do another pass to bring the
correct scrollbar back.

Can't test overlay scrollbars in tests.

  • platform/ScrollView.cpp:

(WebCore::ScrollView::updateScrollbars):

3:46 PM Changeset in webkit [158967] by hmuller@adobe.com
  • 4 edits
    4 adds in trunk

[CSS Shapes] Image valued shape-outside that extends vertically into the margin-box is top-clipped
​https://bugs.webkit.org/show_bug.cgi?id=123769

Reviewed by Dirk Schulze.

Source/WebCore:

Remove the assumption that Y coordinates are >= 0 from the RasterShapeIntervals class
and correct its computeShapeMarginIntervals() method. The computeShapeMarginIntervals()
method now generates intervals with Y coordinates that begin at the image shape's
bounds.y - shape-margin, which may be less than 0.

The RasterShapeIntervals::intervalsAt() method now offsets its Y coordinate parameter
by the shape-margin. A non-const overload of the method was added to centralize all
access to m_intervalLists.

Test: fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-004.html

fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-005.html

  • rendering/shapes/RasterShape.cpp:

(WebCore::MarginIntervalGenerator::intervalAt): Don't clip X coordinates to 0 since they can extend into the margin-box.
(WebCore::RasterShapeIntervals::appendInterval): Use the non-const intervalsAt() method.
(WebCore::RasterShapeIntervals::uniteMarginInterval): Ditto.
(WebCore::RasterShapeIntervals::computeShapeMarginIntervals): See above.

  • rendering/shapes/RasterShape.h:

(WebCore::RasterShapeIntervals::RasterShapeIntervals): Added a field for the margin.
(WebCore::RasterShapeIntervals::intervalsAt): Offset y coordinates by the margin; added a non-const overload.

LayoutTests:

Verify that lines overlap a shape-outside that extends into the top of the margin-box
do wrap around the top of the shape as well its side and bottom.

  • fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-004-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-004.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-005-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-image-margin-005.html: Added.
3:46 PM Changeset in webkit [158966] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: remove -webkit-min and -webkit-max from CSS completions
​https://bugs.webkit.org/show_bug.cgi?id=124072

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2013-11-08
Reviewed by Timothy Hatcher.

-webkit-min and -webkit-max are not implemented in WebCore, despite mentions of it.

  • UserInterface/CSSKeywordCompletions.js:
3:45 PM Changeset in webkit [158965] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Ended event should work also when playback rate is negative
​https://bugs.webkit.org/show_bug.cgi?id=123879

Patch by Piotr Grad <​p.grad@samsung.com> on 2013-11-08
Reviewed by Eric Carlson.

Source/WebCore:

According to W3C specification playback is ended also when playback rate is
negative and position is the earliest possible position.

Test: media/video-ended-event-negative-playback.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):

LayoutTests:

Tests if ended event is triggered for audio/video elements after
changing playback rate to negative.

  • media/video-ended-event-negative-playback-expected.txt: Added.
  • media/video-ended-event-negative-playback.html: Added.
3:36 PM Changeset in webkit [158964] by commit-queue@webkit.org
  • 25 edits
    1 add in trunk

Checking for TypeError in RTCPeerConnection object creation
​https://bugs.webkit.org/show_bug.cgi?id=124049

Patch by Thiago de Barros Lacerda <​thiago.lacerda@openbossa.org> on 2013-11-08
Reviewed by Eric Carlson.

Source/WebCore:

If invalid parameters are passed on RTCPeerConnection creation we must throw a TypeError exception.
According to the spec it requires a Dictionary argument, the RTCConfiguration, which is mandatory.

Please notice that this patch does not make every tests run as expected,
RTCPeerConnectionHandlerMock needs to be update to deal with contraints.

Existing tests were updated.

  • GNUmakefile.list.am:
  • Modules/mediastream/RTCPeerConnection.idl:
  • UseJSC.cmake:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSRTCPeerConnectionCustom.cpp: Added.

(WebCore::JSRTCPeerConnectionConstructor::constructJSRTCPeerConnection):

LayoutTests:

Please notice that this patch does not make every tests run as expected,
RTCPeerConnectionHandlerMock needs to be update to deal with contraints.

  • fast/mediastream/RTCPeerConnection-AddRemoveStream.html:
  • fast/mediastream/RTCPeerConnection-createAnswer.html:
  • fast/mediastream/RTCPeerConnection-createOffer.html:
  • fast/mediastream/RTCPeerConnection-datachannel.html:
  • fast/mediastream/RTCPeerConnection-dtmf.html:
  • fast/mediastream/RTCPeerConnection-events.html:
  • fast/mediastream/RTCPeerConnection-expected.txt:
  • fast/mediastream/RTCPeerConnection-ice-expected.txt:
  • fast/mediastream/RTCPeerConnection-ice.html:
  • fast/mediastream/RTCPeerConnection-localDescription.html:
  • fast/mediastream/RTCPeerConnection-onnegotiationneeded.html:
  • fast/mediastream/RTCPeerConnection-remoteDescription.html:
  • fast/mediastream/RTCPeerConnection-stats-expected.txt:
  • fast/mediastream/RTCPeerConnection-stats.html:
  • fast/mediastream/RTCPeerConnection-statsSelector-expected.txt:
  • fast/mediastream/RTCPeerConnection-statsSelector.html:
  • fast/mediastream/RTCPeerConnection.html:
3:24 PM Changeset in webkit [158963] by Bem Jones-Bey
  • 4 edits in trunk/Source/WebCore

Use references instead of pointers to RenderBlockFlow in FloatingObjects and ComputeFloatOffsetAdapter
​https://bugs.webkit.org/show_bug.cgi?id=124074

Reviewed by Sam Weinig.

Just a straightforward conversion from const pointers to const references.

Also, remove unneeded argument from FloatingObjects constructor.

No new tests, no behavior change.

  • rendering/FloatingObjects.cpp:

(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelow):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelowForBlock):
(WebCore::FloatingObjects::FloatingObjects):
(WebCore::FloatingObjects::clearLineBoxTreePointers):
(WebCore::FloatingObjects::computePlacedFloatsTree):
(WebCore::shapeInfoForFloat):
(WebCore::::updateOffsetIfNeeded):
(WebCore::::collectIfNeeded):
(WebCore::::heightRemaining):

  • rendering/FloatingObjects.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::createFloatingObjects):

3:23 PM Changeset in webkit [158962] by weinig@apple.com
  • 6 edits in trunk/Source/WebCore

Teach SubframeLoader a bit about references
​https://bugs.webkit.org/show_bug.cgi?id=124076

Reviewed by Anders Carlsson.

  • html/HTMLAppletElement.cpp:
  • html/HTMLFrameElementBase.cpp:
  • html/HTMLMediaElement.cpp:
  • loader/SubframeLoader.cpp:
  • loader/SubframeLoader.h:
3:16 PM Changeset in webkit [158961] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Blind Windows build-fix attempt after r158959

  • WebCore.vcxproj/WebCore.vcxproj:
3:10 PM Changeset in webkit [158960] by matthew_hanson@apple.com
  • 5 edits in branches/safari-537.73-branch/Source/WebKit2

Merge r158101.

2:48 PM Changeset in webkit [158959] by beidson@apple.com
  • 22 edits
    2 moves
    1 delete in trunk/Source

Merge IDBCursorBackendInterface and IDBCursorBackendImpl
​https://bugs.webkit.org/show_bug.cgi?id=124068

Reviewed by Anders Carlsson.

Source/WebCore:

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.xcodeproj/project.pbxproj:
  • Modules/indexeddb/IDBCursorBackendInterface.h: Removed.
  • Modules/indexeddb/IDBCursorBackend.cpp: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.cpp.
  • Modules/indexeddb/IDBCursorBackend.h: Renamed from Source/WebCore/Modules/indexeddb/IDBCursorBackendImpl.h.
  • Modules/indexeddb/IDBCallbacks.h:
  • Modules/indexeddb/IDBCursor.cpp:
  • Modules/indexeddb/IDBCursor.h:
  • Modules/indexeddb/IDBCursorWithValue.cpp:
  • Modules/indexeddb/IDBCursorWithValue.h:
  • Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
  • Modules/indexeddb/IDBFactoryBackendInterface.h:
  • Modules/indexeddb/IDBRequest.cpp:
  • Modules/indexeddb/IDBRequest.h:
  • Modules/indexeddb/IDBTransactionBackendImpl.cpp:
  • Modules/indexeddb/IDBTransactionBackendImpl.h:
  • Modules/indexeddb/IDBTransactionBackendInterface.h:
  • Modules/indexeddb/IDBTransactionBackendOperations.cpp:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:

Source/WebKit2:

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.cpp:

(WebKit::WebIDBFactoryBackend::createCursorBackend):

  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
2:42 PM Changeset in webkit [158958] by weinig@apple.com
  • 5 edits in trunk/Source/WebCore

Modernize FrameLoader a bit
​https://bugs.webkit.org/show_bug.cgi?id=124073

Reviewed by Anders Carlsson.

  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:

Use std::unique_ptrs rather than OwnPtrs.

  • loader/MixedContentChecker.cpp:
  • loader/MixedContentChecker.h:

Switch to hold a Frame& rather than Frame*.

2:11 PM Changeset in webkit [158957] by oliver@apple.com
  • 1 edit
    4 deletes in trunk/Source/JavaScriptCore

Remove more accidentally added files.

2:09 PM Changeset in webkit [158956] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

Remove code guarded with ENABLE(STREAM)
​https://bugs.webkit.org/show_bug.cgi?id=123667

Reviewed by Anders Carlsson.

Remove ENABLE(STREAM)-guarded code. This was added in the effort to provide Stream API support, but
no port enables the feature and the work on this feature has wound down after the Chromium port forked,
leaving this code unmaintained.

  • fileapi/FileReaderLoader.cpp:
  • fileapi/FileReaderLoader.h:
2:04 PM Changeset in webkit [158955] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Remove a workaround for a bug in malloc on Symbian
​https://bugs.webkit.org/show_bug.cgi?id=124069

Reviewed by Sam Weinig.

  • Platform/CoreIPC/ArgumentDecoder.cpp:

(CoreIPC::ArgumentDecoder::~ArgumentDecoder):
(CoreIPC::ArgumentDecoder::initialize):

  • Platform/CoreIPC/ArgumentDecoder.h:
2:01 PM Changeset in webkit [158954] by Bem Jones-Bey
  • 6 edits in trunk/Source/WebCore

RenderBlockFlow::nextFloatLogicalBottomBelow should not use ShapeOutsideFloatOffsetMode
​https://bugs.webkit.org/show_bug.cgi?id=123931

Reviewed by Sam Weinig.

Rewrite nextFloatLogicalBottomBelow to use the placed floats tree for
the search and to not need ShapeOutsideFloatOffsetMode anymore. This
moves almost all of the logic into FloatingObjects, making a small
reduction in the amount that RenderBlockFlow needs to know about the
implementation of FloatingObjects.

In addition, change ComputeFloatOffsetAdapter to take in LayoutUnits
and roundToInt itself so that all of it's callers can be simplified.

No new tests, no new behavior.

  • rendering/FloatingObjects.cpp:

(WebCore::rangesIntersect):
(WebCore::ComputeFloatOffsetAdapter::ComputeFloatOffsetAdapter):
(WebCore::FindNextFloatLogicalBottomAdapter::FindNextFloatLogicalBottomAdapter):
(WebCore::FindNextFloatLogicalBottomAdapter::lowValue):
(WebCore::FindNextFloatLogicalBottomAdapter::highValue):
(WebCore::FindNextFloatLogicalBottomAdapter::nextLogicalBottom):
(WebCore::FindNextFloatLogicalBottomAdapter::nextShapeLogicalBottom):
(WebCore::FindNextFloatLogicalBottomAdapter::collectIfNeeded):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelow):
(WebCore::FloatingObjects::findNextFloatLogicalBottomBelowForBlock):
(WebCore::FloatingObjects::logicalLeftOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset):

  • rendering/FloatingObjects.h:
  • rendering/LineWidth.cpp:

(WebCore::LineWidth::fitBelowFloats):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelow):
(WebCore::RenderBlockFlow::nextFloatLogicalBottomBelowForBlock):
(WebCore::RenderBlockFlow::getClearDelta):

  • rendering/RenderBlockFlow.h:
2:01 PM Changeset in webkit [158953] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebInspectorUI

Merged r157459. <rdar://problem/15411420>

1:55 PM Changeset in webkit [158952] by Lucas Forschler
  • 15 edits in branches/safari-537.73-branch/Source/WebKit2

Merged r157137. <rdar://problem/15411426>

1:50 PM Changeset in webkit [158951] by matthew_hanson@apple.com
  • 3 edits in tags/Safari-538.5/Source/WebCore

Merge r158923.

1:42 PM Changeset in webkit [158950] by Lucas Forschler
  • 2 edits in branches/safari-537.73-branch/Source/WebCore

Merged r152867. <rdar://problem/15411424>

1:35 PM Changeset in webkit [158949] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

More build fixes.

  • UIProcess/API/mac/WKBrowsingContextController.mm:
  • UIProcess/API/mac/WKConnection.mm:

(didReceiveMessage):

1:22 PM Changeset in webkit [158948] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

More build fixes.

  • UIProcess/API/mac/WKConnection.h:
  • UIProcess/API/mac/WKConnection.mm:

(didReceiveMessage):

1:19 PM Changeset in webkit [158947] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Try to fix the 32-bit build.

  • Shared/API/Cocoa/WKBrowsingContextHandleInternal.h:
1:17 PM Changeset in webkit [158946] by matthew_hanson@apple.com
  • 2 edits in trunk/Tools

Added myself as a contributor.

1:07 PM Changeset in webkit [158945] by ap@apple.com
  • 2 edits
    5 moves in trunk/Source/WebCore

​https://bugs.webkit.org/show_bug.cgi?id=124064
Some WebCrypto files are not in correct directories

Rubber-stamped by Anders Carlsson.

  • WebCore.xcodeproj/project.pbxproj:
  • crypto/CryptoAlgorithmAesCbcParams.h: Removed.
  • crypto/CryptoAlgorithmAesKeyGenParams.h: Removed.
  • crypto/CryptoKeyAES.cpp: Removed.
  • crypto/CryptoKeyAES.h: Removed.
  • crypto/CryptoKeyMac.cpp: Removed.
  • crypto/keys/CryptoKeyAES.cpp: Copied from Source/WebCore/crypto/CryptoKeyAES.cpp.
  • crypto/keys/CryptoKeyAES.h: Copied from Source/WebCore/crypto/CryptoKeyAES.h.
  • crypto/mac/CryptoKeyMac.cpp: Copied from Source/WebCore/crypto/CryptoKeyMac.cpp.
  • crypto/parameters/CryptoAlgorithmAesCbcParams.h: Copied from Source/WebCore/crypto/CryptoAlgorithmAesCbcParams.h.
  • crypto/parameters/CryptoAlgorithmAesKeyGenParams.h: Copied from Source/WebCore/crypto/CryptoAlgorithmAesKeyGenParams.h.
1:05 PM Changeset in webkit [158944] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Replace alignof with alignof.

Rubber-stamped by Beth Dakin.

  • Platform/CoreIPC/ArgumentCoders.cpp:

(CoreIPC::::encode):
(CoreIPC::decodeStringText):

  • Platform/CoreIPC/ArgumentCoders.h:

(CoreIPC::SimpleArgumentCoder::encode):
(CoreIPC::SimpleArgumentCoder::decode):

  • Platform/CoreIPC/ArgumentDecoder.h:

(CoreIPC::ArgumentDecoder::bufferIsLargeEnoughToContain):

  • WebProcess/WebPage/DecoderAdapter.cpp:

(WebKit::DecoderAdapter::decodeString):

  • WebProcess/WebPage/EncoderAdapter.cpp:

(WebKit::EncoderAdapter::encodeString):

1:01 PM Changeset in webkit [158943] by ap@apple.com
  • 10 edits
    14 adds
    1 delete in trunk

Implement JWK key import for HMAC and AES-CBC
​https://bugs.webkit.org/show_bug.cgi?id=124059

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: crypto/subtle/aes-cbc-import-jwk.html

crypto/subtle/hmac-import-jwk.html
crypto/subtle/import-jwk.html

WebCrypto supports multiple key formats - raw, pkcs8, spki, jwk. The design is that
we'll transform these into parsed KeyData subclasses before passing to algorithms.

CryptoKeySerialization is a base class for handling all these formats.

  • WebCore.xcodeproj/project.pbxproj: Added new files. Removed CryptoKeyFormat.h.


  • bindings/js/JSCryptoKeySerializationJWK.h: Added.
  • bindings/js/JSCryptoKeySerializationJWK.cpp: Added.

(WebCore::getStringFromJSON): A helper. Note that we can rely on the object being
a nice freshly parsed JSON, no getters or anything.
(WebCore::getBooleanFromJSON): Ditto.
(WebCore::JSCryptoKeySerializationJWK::JSCryptoKeySerializationJWK):
(WebCore::JSCryptoKeySerializationJWK::~JSCryptoKeySerializationJWK):
(WebCore::createHMACParameters): A simple helper.
(WebCore::JSCryptoKeySerializationJWK::reconcileAlgorithm): WebCrypto API is weird,
you can have algorithm parameters both inside a JWK key and passed as importKey()
arguments. They need to agree, whatever that means for specific serialization's
algorithm options (not all necessarily have a 1-1 matching to WebCrypto).
(WebCore::JSCryptoKeySerializationJWK::reconcileUsages): Take an intersection of usages.
(WebCore::JSCryptoKeySerializationJWK::reconcileExtractable): Only extractable if
both JWK and the caller agree.
(WebCore::JSCryptoKeySerializationJWK::keySizeIsValid): Verify validity of JWK key.
(WebCore::JSCryptoKeySerializationJWK::keyData): Return an appropriate KeyData
subclass.

  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::ENUM_CLASS): Moved CryptoKeyFormat here.
(WebCore::cryptoKeyFormatFromJSValue): Added a human readable string to an exception.
(WebCore::JSSubtleCrypto::importKey): Support multiple key formats, not just raw.

  • crypto/CryptoAlgorithm.cpp: (WebCore::CryptoAlgorithm::importKey):
  • crypto/CryptoAlgorithm.h:

Updated signature for importKey to one that makes more sense. Decoding formats all
the way from a binary blob is not something that CryptoAlgorithm subclasses should
do, we now pass a KeyData subclass instead.
Removed exportKey/wrapKey/unwrapKey altogether, because I don't yet know what the
signatures will be.

  • crypto/CryptoKeyData.h: Added.

(WebCore::CryptoKeyData::ENUM_CLASS):
(WebCore::CryptoKeyData::CryptoKeyData):
(WebCore::CryptoKeyData::~CryptoKeyData):
(WebCore::CryptoKeyData::format):
A base class for passing key material to algorithms. Currently, only one type is
supported, that being OctetSequence for secret keys. Keys for RSA and EC are more
complicated, and secret/public ones are different too.

  • crypto/CryptoKeyFormat.h: Removed. There are too many key format classes

confusingly floating around, and this was only needed in one file for parsing.

  • crypto/CryptoKeySerialization.h: Added.

Base class for handling raw/pkcs8/spki/jwk keys.

  • crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::importKey):

  • crypto/algorithms/CryptoAlgorithmAES_CBC.h:

Updated to use CryptoKeyData.

  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::importKey):

  • crypto/algorithms/CryptoAlgorithmHMAC.h:

Updated to use CryptoKeyData.

  • crypto/keys/CryptoKeyDataOctetSequence.cpp: Added.

(WebCore::CryptoKeyDataOctetSequence::CryptoKeyDataOctetSequence):
(WebCore::CryptoKeyDataOctetSequence::~CryptoKeyDataOctetSequence):

  • crypto/keys/CryptoKeyDataOctetSequence.h: Added.

(WebCore::asCryptoKeyDataOctetSequence):

  • crypto/keys/CryptoKeySerializationRaw.cpp: Added.

(WebCore::CryptoKeySerializationRaw::CryptoKeySerializationRaw):
(WebCore::CryptoKeySerializationRaw::~CryptoKeySerializationRaw):
(WebCore::CryptoKeySerializationRaw::reconcileAlgorithm):
(WebCore::CryptoKeySerializationRaw::reconcileUsages):
(WebCore::CryptoKeySerializationRaw::reconcileExtractable):
(WebCore::CryptoKeySerializationRaw::keyData):

  • crypto/keys/CryptoKeySerializationRaw.h: Added.

Much code to pass around a Vector<char>.

LayoutTests:

  • crypto/subtle/aes-cbc-import-jwk-expected.txt: Added.
  • crypto/subtle/aes-cbc-import-jwk.html: Added.
  • crypto/subtle/hmac-import-jwk-expected.txt: Added.
  • crypto/subtle/hmac-import-jwk.html: Added.
  • crypto/subtle/import-jwk-expected.txt: Added.
  • crypto/subtle/import-jwk.html: Added.
12:42 PM Changeset in webkit [158942] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add a way to get a WKWebProcessPlugInBrowserContextController from a handle
​https://bugs.webkit.org/show_bug.cgi?id=124063

Reviewed by Beth Dakin.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(+[WKWebProcessPlugInBrowserContextController lookUpBrowsingContextFromHandle:]):

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:
12:41 PM Changeset in webkit [158941] by oliver@apple.com
  • 1 edit
    2 deletes in trunk/Source/JavaScriptCore

Remove accidentally added files.

12:27 PM Changeset in webkit [158940] by oliver@apple.com
  • 2 edits
    6 adds in trunk/Source/JavaScriptCore

Fix minor (unobservable) bug in ArrayIterator::next()
​https://bugs.webkit.org/show_bug.cgi?id=124061

Reviewed by Beth Dakin.

I noticed this while reading the array iterator code. Due to how
ArrayIterator::next() and our enumeration behaviour is implemented
this is not actually a code path that can be hit. But in order to
future proof this it should be correct.

  • runtime/JSArrayIterator.cpp:

(JSC::arrayIteratorNext):

12:22 PM Changeset in webkit [158939] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

More work on WKBrowsingContextHandle
​https://bugs.webkit.org/show_bug.cgi?id=124060

Reviewed by Beth Dakin.

Implement -hash and -isEqual: and add -[WKWebProcessPlugInBrowserContextController handle].

  • Shared/API/Cocoa/WKBrowsingContextHandle.mm:

(-[WKBrowsingContextHandle hash]):
(-[WKBrowsingContextHandle isEqual:]):

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(decodeInvocation):

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(-[WKWebProcessPlugInBrowserContextController mainFrameDocument]):
(-[WKWebProcessPlugInBrowserContextController selectedRange]):
(-[WKWebProcessPlugInBrowserContextController handle]):

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerInternal.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextControllerPrivate.h:
12:06 PM Changeset in webkit [158938] by matthew_hanson@apple.com
  • 2 edits in tags/Safari-538.5/Tools

Unreviewed. Added myself as a committer.

12:03 PM Changeset in webkit [158937] by mark.lam@apple.com
  • 24 edits
    4 adds in trunk/Source

Move breakpoint (and exception break) functionality into JSC::Debugger.
​https://bugs.webkit.org/show_bug.cgi?id=121796.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • In ScriptDebugServer and JSC::Debugger, SourceID and BreakpointID are now numeric tokens.
  • JSC::Debugger now tracks user defined breakpoints in a JSC::Breakpoint record. Previously, this info is tracked in the ScriptBreakpoint record in ScriptDebugServer. The only element of ScriptBreakpoint that is not being tracked by JSC::Breakpoint is the ScriptBreakpointAction.

The ScriptBreakpointAction is still tracked by the ScriptDebugServer

in a list keyed on the corresponding BreakpointID.

The ScriptBreakpoint record is now only used as a means of passing

breakpoint paramaters to the ScriptDebugServer.

  • ScriptDebugServer now no longer accesses the JSC::CallFrame* directly. It always goes through the DebuggerCallFrame.

(JSC::Breakpoint::Breakpoint):

  • Breakpoint class to track info for each breakpoint in JSC::Debugger.
  • debugger/Debugger.cpp:

(JSC::DebuggerCallFrameScope::DebuggerCallFrameScope):
(JSC::DebuggerCallFrameScope::~DebuggerCallFrameScope):
(JSC::Debugger::Debugger):
(JSC::Debugger::detach):
(JSC::Debugger::updateNeedForOpDebugCallbacks):
(JSC::Debugger::setBreakpoint):
(JSC::Debugger::removeBreakpoint):
(JSC::Debugger::hasBreakpoint):
(JSC::Debugger::clearBreakpoints):
(JSC::Debugger::setBreakpointsActivated):
(JSC::Debugger::setPauseOnExceptionsState):
(JSC::Debugger::setPauseOnNextStatement):
(JSC::Debugger::breakProgram):
(JSC::Debugger::continueProgram):
(JSC::Debugger::stepIntoStatement):
(JSC::Debugger::stepOverStatement):
(JSC::Debugger::stepOutOfFunction):
(JSC::Debugger::updateCallFrame):
(JSC::Debugger::updateCallFrameAndPauseIfNeeded):
(JSC::Debugger::pauseIfNeeded):
(JSC::Debugger::exception):
(JSC::Debugger::atStatement):
(JSC::Debugger::callEvent):
(JSC::Debugger::returnEvent):
(JSC::Debugger::willExecuteProgram):
(JSC::Debugger::didExecuteProgram):
(JSC::Debugger::didReachBreakpoint):
(JSC::Debugger::currentDebuggerCallFrame):

  • debugger/Debugger.h:
  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::sourceID):
(JSC::DebuggerCallFrame::sourceIDForCallFrame):

  • debugger/DebuggerCallFrame.h:
  • debugger/DebuggerPrimitives.h: Added.
  • define SourceID, noSourceID, BreakpointID, and noBreakpointID.

Source/WebCore:

No new tests.

  • In ScriptDebugServer and JSC::Debugger, SourceID and BreakpointID are now numeric tokens.
  • JSC::Debugger now tracks user defined breakpoints in a JSC::Breakpoint record. Previously, this info is tracked in the ScriptBreakpoint record in ScriptDebugServer. The only element of ScriptBreakpoint that is not being tracked by JSC::Breakpoint is the ScriptBreakpointAction.

The ScriptBreakpointAction is still tracked by the ScriptDebugServer

in a list keyed on the corresponding BreakpointID.

The ScriptBreakpoint record is now only used as a means of passing

breakpoint paramaters to the ScriptDebugServer.

  • ScriptDebugServer now no longer accesses the JSC::CallFrame* directly. It always goes through the DebuggerCallFrame.
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/BreakpointID.h: Added.
  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
(WebCore::ScriptDebugServer::dispatchDidPause):
(WebCore::ScriptDebugServer::dispatchDidContinue):
(WebCore::ScriptDebugServer::dispatchDidParseSource):
(WebCore::ScriptDebugServer::notifyDoneProcessingDebuggerEvents):
(WebCore::ScriptDebugServer::needPauseHandling):
(WebCore::ScriptDebugServer::handleBreakpointHit):
(WebCore::ScriptDebugServer::handleExceptionInBreakpointCondition):
(WebCore::ScriptDebugServer::handlePause):

  • bindings/js/ScriptDebugServer.h:
  • bindings/js/SourceID.h: Added.
  • bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):

  • bindings/js/WorkerScriptDebugServer.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::parseLocation):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::continueToLocation):
(WebCore::InspectorDebuggerAgent::resolveBreakpoint):
(WebCore::InspectorDebuggerAgent::searchInContent):
(WebCore::InspectorDebuggerAgent::getScriptSource):
(WebCore::InspectorDebuggerAgent::didParseSource):
(WebCore::InspectorDebuggerAgent::didPause):
(WebCore::InspectorDebuggerAgent::clear):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/ScriptDebugListener.h:

Source/WebKit/mac:

  • WebView/WebScriptDebugger.h:
  • WebView/WebScriptDebugger.mm:

(WebScriptDebugger::WebScriptDebugger):
(WebScriptDebugger::handlePause):

11:49 AM Changeset in webkit [158936] by andersca@apple.com
  • 5 edits
    3 copies in trunk/Source/WebKit2

Add A WKBrowsingContextHandle class
​https://bugs.webkit.org/show_bug.cgi?id=124058

Reviewed by Sam Weinig.

The WKBrowsingContextHandle class represents a browsing context and can be sent across process boundaries.

  • Shared/API/Cocoa/WKBrowsingContextHandle.h: Added.
  • Shared/API/Cocoa/WKBrowsingContextHandle.mm: Added.

(-[WKBrowsingContextHandle _initWithPageID:]):
(-[WKBrowsingContextHandle encodeWithCoder:]):
(-[WKBrowsingContextHandle initWithCoder:]):
(+[WKBrowsingContextHandle supportsSecureCoding]):

  • Shared/API/Cocoa/WKBrowsingContextHandleInternal.h: Added.
  • UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController handle]):

  • UIProcess/API/mac/WKBrowsingContextControllerInternal.h:
  • UIProcess/API/mac/WKBrowsingContextControllerPrivate.h:

(NS_ENUM):

  • WebKit2.xcodeproj/project.pbxproj:
11:45 AM Changeset in webkit [158935] by commit-queue@webkit.org
  • 8 edits in trunk/Source/WebCore

InspectorConsoleAgent::didFinishXHRLoading ConsoleMessage should include a column number
​https://bugs.webkit.org/show_bug.cgi?id=114316

Patch by László Langó <​lango@inf.u-szeged.hu> on 2013-11-08
Reviewed by Timothy Hatcher.

InspectorConsoleAgent::didFinishXHRLoading creates a ConsoleMessage with a line number,
but it should also include a column number. It looks like ultimately the line number comes from
JSXMLHttpRequest::send, it should also be possible to get the column number at the time.
The column number would be needed by the Web Inspector to jump to the proper place in source code
to show where the XHR originated from.

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::SendFunctor::SendFunctor):
(WebCore::SendFunctor::column):
(WebCore::SendFunctor::operator()):
(WebCore::JSXMLHttpRequest::send):

  • inspector/InspectorConsoleAgent.cpp:

(WebCore::InspectorConsoleAgent::didFinishXHRLoading):

  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didFinishXHRLoadingImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didFinishXHRLoading):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::setLastSendLineAndColumnNumber):
(WebCore::XMLHttpRequest::didFinishLoading):

  • xml/XMLHttpRequest.h:
11:38 AM Changeset in webkit [158934] by Simon Fraser
  • 3 edits
    4 adds in trunk

Left sidebar on cubic-bezier.com flickers
​https://bugs.webkit.org/show_bug.cgi?id=123128

Source/WebCore:

Reviewed by Dean Jackson.

The logic that determined whether position:fixed elements outside the viewport
should be composited was incorrect if the fixed element also had a transform.

layer.calculateLayerBounds() only takes into account painted transforms (since they
affect layer bounds). So we need to compute the bounds relative to the layer
itself, then use localToContainerQuad() to map them to document coordinates,
but only to the RenderView so that we don't hit the page scale transform.

Tests: compositing/layer-creation/fixed-position-transformed-into-view.html

compositing/layer-creation/fixed-position-transformed-outside-view.html

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

LayoutTests:

Reviewed by Dean Jackson.

Tests with transformed, fixed elements which dump the layer tree to see
which layers get composited.

  • compositing/layer-creation/fixed-position-transformed-into-view-expected.txt: Added.
  • compositing/layer-creation/fixed-position-transformed-into-view.html: Added.
  • compositing/layer-creation/fixed-position-transformed-outside-view-expected.txt: Added.
  • compositing/layer-creation/fixed-position-transformed-outside-view.html: Added.
11:37 AM Changeset in webkit [158933] by ap@apple.com
  • 2 edits in trunk/Source/WTF

Make base64url decoding actually work
​https://bugs.webkit.org/show_bug.cgi?id=124050

Reviewed by Sam Weinig.

  • wtf/text/Base64.cpp: (WTF::base64DecodeInternal): Don't hardcode knowledge about

alphabet, put it into the map.

11:28 AM Changeset in webkit [158932] by oliver@apple.com
  • 2 edits in trunk/LayoutTests

Fix layout test that was actually testing incorrect behaviour.

11:27 AM Changeset in webkit [158931] by Martin Robinson
  • 9 edits in trunk

[MathML] Center of stretched curly bracket not always vertically centered
​https://bugs.webkit.org/show_bug.cgi?id=123715

Reviewed by Brent Fulgham.

Source/WebCore:

  • rendering/mathml/RenderMathMLOperator.cpp:

(WebCore::RenderMathMLOperator::fillWithExtensionGlyph): Update an assertion and
handle the case where two glyph pieces abut.
(WebCore::RenderMathMLOperator::paint): Do not offset the center glyph by y().

LayoutTests:

because MathML is changing rapidly, but we need it to test these changes.

  • mathml/presentation/mo-stretch.html: Update to show stretching characteristics

of all stretchable glyphs.

  • platform/gtk/mathml/presentation/mo-stretch-expected.png:
  • platform/gtk/mathml/presentation/mo-stretch-expected.txt:
11:10 AM Changeset in webkit [158930] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Add WKRemoteObjectRegistry to WKConnection
​https://bugs.webkit.org/show_bug.cgi?id=124054

Reviewed by Sam Weinig.

  • UIProcess/API/mac/WKConnection.h:
  • UIProcess/API/mac/WKConnection.mm:

(-[WKConnection delegate]):
(-[WKConnection setDelegate:]):
(-[WKConnection remoteObjectRegistry]):
(didReceiveMessage):

10:47 AM Changeset in webkit [158929] by oliver@apple.com
  • 3 edits
    3 adds in trunk

Map.forEach crashes on deleted values
​https://bugs.webkit.org/show_bug.cgi?id=124017

Reviewed by Ryosuke Niwa.

Source/JavaScriptCore:

MapData iterator did not consider the case of the first entries
being holes. To fix this I've refactored iteration so that we
can perform an initialisation increment on construction, whle
retaining the useful assertion in MapData::const_iterator::operator++

  • runtime/MapData.h:

(JSC::MapData::const_iterator::operator++):
(JSC::MapData::const_iterator::internalIncrement):
(JSC::MapData::const_iterator::const_iterator):

LayoutTests:

Test case

  • js/map-iterate-first-entry-is-a-hole-expected.txt: Added.
  • js/map-iterate-first-entry-is-a-hole.html: Added.
  • js/script-tests/map-iterate-first-entry-is-a-hole.js: Added.

(set map0):

10:30 AM Changeset in webkit [158928] by jer.noble@apple.com
  • 7 edits
    2 adds in trunk

[MSE] Bring SourceBuffer.append up to the most recent spec.
​https://bugs.webkit.org/show_bug.cgi?id=123377

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-append-failed.html

Bring the MediaSource append() implementation up to the current spec.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::appendBufferInternal):
(WebCore::SourceBuffer::appendBufferTimerFired):

  • platform/graphics/SourceBufferPrivate.h:
  • platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockSourceBufferPrivate::append):
(WebCore::MockSourceBufferPrivate::evictCodedFrames):
(WebCore::MockSourceBufferPrivate::isFull):

  • platform/mock/mediasource/MockSourceBufferPrivate.h:

LayoutTests:

  • media/media-source/media-source-append-failed-expected.txt: Added.
  • media/media-source/media-source-append-failed.html: Added.
  • media/media-source/mock-media-source.js:
10:28 AM Changeset in webkit [158927] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Encode and decode NSURLRequests using NSCoder
​https://bugs.webkit.org/show_bug.cgi?id=124051

Reviewed by Sam Weinig.

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(CoreIPC::archiveAndEncodeObject):
(CoreIPC::decodeAndUnarchiveObject):
(CoreIPC::::encodePlatformData):
(CoreIPC::::decodePlatformData):

10:25 AM Changeset in webkit [158926] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

REGRESSION(r158883): Fix crashes for ARM architecture.
​https://bugs.webkit.org/show_bug.cgi?id=124038

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-11-08
Reviewed by Michael Saboff.

  • jit/GPRInfo.h: Remove r11 from the temporary register set, use a free register for

nonPreservedNonReturnGPR and remove obsolete declaration of bucketCounterRegister.
(JSC::GPRInfo::toRegister):
(JSC::GPRInfo::toIndex):

  • jit/JITOperations.cpp: Frame pointer register is r11 for ARM_TRADITIONAL and

r7 for ARM_THUMB2 instead of r5 since r158883.

10:24 AM Changeset in webkit [158925] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

REGRESSION(r158883): Fix crashes for MIPS architecture.
​https://bugs.webkit.org/show_bug.cgi?id=124044

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-11-08
Reviewed by Michael Saboff.

  • jit/JITOperations.cpp: Frame pointer register is fp instead of s0 since r158883 for MIPS.
  • jit/ThunkGenerators.cpp: Save and restore the new frame pointer register.

(JSC::returnFromJavaScript):
(JSC::callToJavaScript):

10:03 AM Changeset in webkit [158924] by Chris Fleizach
  • 3 edits in branches/safari-537.73-branch/LayoutTests

Fix up failing layout tests that in branch due to recent accessibility patches.

Unreviewed.

  • media/track/track-in-band-mode-expected.txt:
  • platform/mac/accessibility/listitem-title-expected.txt:
9:55 AM Changeset in webkit [158923] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

[Mac] Crash at com.apple.WebCore: WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange + 26
​https://bugs.webkit.org/show_bug.cgi?id=124031

Reviewed by Eric Carlson.

WTF::bind() causes errors when given a bare id pointer as a parameter,
when that parameter is casted to a specific NS type pointer (in this
case, a NSArray*) in order to pass it as a parameter to the bound
function.

Instead of passing around bare id pointers, wrap them in RetainPtr<>
objects before passing them to WTF::bind().

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::loadedTimeRangesDidChange):
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksDidChange):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):

9:31 AM WebKitGTK/2.2.x edited by Carlos Garcia Campos
(diff)
9:12 AM Changeset in webkit [158922] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Win] JavaScript crash in getHostCallReturnValue.
​https://bugs.webkit.org/show_bug.cgi?id=124040

Patch by ​peavo@outlook.com <​peavo@outlook.com> on 2013-11-08
Reviewed by Geoffrey Garen.

  • jit/JITOperations.cpp: Update MSVC assembler code in getHostCallReturnValue according to gcc x86 version.
7:27 AM Changeset in webkit [158921] by Michał Pakuła vel Rutka
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Add test expectations for failing tests.

  • platform/efl/TestExpectations:
6:57 AM Changeset in webkit [158920] by Antti Koivisto
  • 1 edit
    1 add in trunk/PerformanceTests

Add line layout performance test that exercises more cases
​https://bugs.webkit.org/show_bug.cgi?id=124041

Reviewed by Anders Carlsson.

The existing line-layout.html covers the most basic left-aligned case only.
Add a test with more coverage for things that are mostly not yet supported by the simple
line layout path:

  • centered text
  • right aligned text
  • justified text
  • pre
  • white-space:pre-wrap
  • text with simple inlines
  • text with br
  • Layout/line-layout-simple.html: Added.
6:42 AM Changeset in webkit [158919] by commit-queue@webkit.org
  • 6 edits
    5 copies
    3 adds
    5 deletes in trunk/LayoutTests

[GTK] Add new GTK-specific layout test results for vertical text
​https://bugs.webkit.org/show_bug.cgi?id=124000

Patch by Denis Nomiyama <​d.nomiyama@samsung.com> on 2013-11-08
Reviewed by Mario Sanchez Prada.

Rebaselined some expected results for tests that use vertical text.
These tests are now working fine after the fix from Bug 50619.
They have specific results for WebKit2 GTK+ because WebKit1 has a
permanent area in the bottom for the horizontal scroll bar.
This area reduces the layout area in WebKit1 and consequently the
results differ from WebKit2.

  • fast/repaint/japanese-rl-selection-clear-expected.txt:
  • fast/repaint/japanese-rl-selection-repaint-expected.txt:
  • fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
  • fast/text/international/vertical-text-glyph-test-expected.txt:
  • fast/text/justify-ideograph-vertical-expected.txt:
  • platform/efl/fast/repaint/japanese-rl-selection-clear-expected.txt: Removed.
  • platform/efl/fast/repaint/japanese-rl-selection-repaint-expected.txt: Removed.
  • platform/efl/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Removed.
  • platform/efl/fast/text/international/vertical-text-glyph-test-expected.txt: Removed.
  • platform/efl/fast/text/justify-ideograph-vertical-expected.txt: Removed.
  • platform/gtk-wk2/fast/repaint/japanese-rl-selection-clear-expected.txt: Copied from LayoutTests/fast/repaint/japanese-rl-selection-clear-expected.txt.
  • platform/gtk-wk2/fast/repaint/japanese-rl-selection-repaint-expected.txt: Copied from LayoutTests/fast/repaint/japanese-rl-selection-repaint-expected.txt.
  • platform/gtk-wk2/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Copied from LayoutTests/fast/repaint/repaint-across-writing-mode-boundary-expected.txt.
  • platform/gtk-wk2/fast/text/international/vertical-text-glyph-test-expected.txt: Copied from LayoutTests/fast/text/international/vertical-text-glyph-test-expected.txt.
  • platform/gtk-wk2/fast/text/justify-ideograph-vertical-expected.txt: Copied from LayoutTests/fast/text/justify-ideograph-vertical-expected.txt.
4:53 AM Changeset in webkit [158918] by Antti Koivisto
  • 4 edits in trunk/Source/WebCore

Templated LChar/UChar paths for simple line layout
​https://bugs.webkit.org/show_bug.cgi?id=124035

Reviewed by Andreas Kling.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseForText):
(WebCore::SimpleLineLayout::canUseFor):

Use a templated function to check for illegal characters.

(WebCore::SimpleLineLayout::skipWhitespaces):

Make a template function.

(WebCore::SimpleLineLayout::textWidth):

Make a template function plus some argument changes.

(WebCore::SimpleLineLayout::createTextRuns):

Template function for creating runs while operating with either LChars or UChar.
Also simplified line breaking and text width measuring logic.

(WebCore::SimpleLineLayout::create):

Pick the template.

  • rendering/break_lines.cpp:
  • rendering/break_lines.h:


Move the implementation to the header (except for the table) so we can use the template
versions directly.

(WebCore::isBreakableSpace):
(WebCore::shouldBreakAfter):
(WebCore::needsLineBreakIterator):
(WebCore::nextBreakablePosition):
(WebCore::nextBreakablePositionIgnoringNBSP):

4:16 AM Changeset in webkit [158917] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[EFL] accessibility/aria-link-supports-press.html
​https://bugs.webkit.org/show_bug.cgi?id=111987

Unreviewed EFL gardening, passes after r158913.

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-11-08

  • platform/efl-wk1/TestExpectations: test is no longer failing.
  • platform/efl-wk2/TestExpectations: test is no longer failing.
3:26 AM Changeset in webkit [158916] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

[mips] Fix typo (introduced in r158751).
​https://bugs.webkit.org/show_bug.cgi?id=124033.

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-11-08
Reviewed by Csaba Osztrogonác.

  • jit/ThunkGenerators.cpp:

(JSC::callToJavaScript):

3:22 AM Changeset in webkit [158915] by Csaba Osztrogonác
  • 4 edits in trunk/Source/JavaScriptCore

[arm] Use specific PatchableJump implementation for CPU(ARM_TRADITIONAL).
​https://bugs.webkit.org/show_bug.cgi?id=123891

Patch by Julien Brianceau <​jbriance@cisco.com> on 2013-11-08
Reviewed by Michael Saboff.

Although patchableBranch32 is implemented in MacroAssemblerARM.h, the used implementation
is the generic one in MacroAssembler.h. This patch fixes it and also implements the
patchableJump() function for CPU(ARM_TRADITIONAL). These specific implementations are
needed for this architecture backend to ensure that these jumps can be relinked.

  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::patchableJump):

  • jit/GPRInfo.h: Remove static_cast that are generating warnings in debug builds.

(JSC::GPRInfo::toIndex):
(JSC::GPRInfo::debugName):

2:55 AM Changeset in webkit [158914] by mario@webkit.org
  • 9 edits in trunk

AX: [ATK] <span> elements exposed through ATK when not needed
​https://bugs.webkit.org/show_bug.cgi?id=123885

Reviewed by Chris Fleizach.

Source/WebCore:

As per SVN r158195, the way it's decided whether <span> elements
should be ignored or not has slightly changed, causing that the
GTK/EFL ports expose them in cases that they should be ignored,
such as for text elements that neither are focusable (e.g. by
explicitly setting tabindex) nor have a meaningful accessible name
suggesting they should be exposed.

As a result, the flattening that ATK based ports normally do for
this kind of elements (by folding them into their parents) do not
work correctly anymore, making two tests to fail:

platform/gtk/accessibility/spans-paragraphs-and-divs.html
platform/gtk/accessibility/spans.html

This patch encapsulates the part of the logic that affects this in
the computeAccessibilityIsIgnored() method, placing it in a
new method of AccessibilityObject that we can call from ATK's
accessibilityPlatformIncludesObject() to ensure we hide those
<span> elements when they don't fulfill those requirements.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::hasAttributesRequiredForInclusion):
New virtual method encapsulating part of the logic from the function
that computes whether accessibility should be ignored or not.

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::hasAttributesRequiredForInclusion):
Override of the new method adding additional checks, as extracted from
the original bits in computeAccessibilityIsIgnored().

  • accessibility/AccessibilityNodeObject.h:
  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
Use the newly added function where we had the original code before.

  • accessibility/atk/AccessibilityObjectAtk.cpp:

(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
Make sure <span> elements are ignored if they are not focusable
and they don't have a meaningful accessible name.

LayoutTests:

Removed failure expectations for tests now passing.

  • platform/gtk/TestExpectations: Removed expectations.
2:24 AM Changeset in webkit [158913] by commit-queue@webkit.org
  • 5 edits in trunk

[GTK] accessibility/aria-link-supports-press.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=98355

Patch by Krzysztof Czech <​k.czech@samsung.com> on 2013-11-08
Reviewed by Mario Sanchez Prada.

Tools:

Checking "jump" action for link elements. Action "jump" occurs when a link
element is pressed/clicked.

  • DumpRenderTree/atk/AccessibilityUIElementAtk.cpp:

(AccessibilityUIElement::isPressActionSupported):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::isPressActionSupported):

LayoutTests:

Removed failure expectation.

  • platform/gtk/TestExpectations: test is no longer failing.
1:43 AM Changeset in webkit [158912] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[JHBUILD] Jhbuild Makefile build bug workaround
​https://bugs.webkit.org/show_bug.cgi?id=123971

Patch by Przemyslaw Szymanski <​p.szymanski3@samsung.com> on 2013-11-08
Reviewed by Ryosuke Niwa.

After Jhbuild repository is cloned (for instance when you use
Tools/Scripts/update-webkitefl-libs) it is built from sources.
If you have GREP_OPTIONS grep env variable set (for instance
GREP_OPTIONS=-n) then it is jhbuild build error. Makefile.plain
uses shell grep. For specific GREP_OPTIONS grep output will be
different than expected one by Jhbuild and there is an error
with Jhbuild build. Jhbuild will not be built and then WebKit
source also will not be built. This patch is a workaround to this
issue. It disables GREP_OPTIONS for Jhbuild build time.

  • jhbuild/jhbuild-wrapper:

(install_jhbuild):

1:06 AM Changeset in webkit [158911] by akling@apple.com
  • 1 edit
    1 add in trunk/LayoutTests

Add back expectation for test that went missing in r158813.

  • svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
12:16 AM Changeset in webkit [158910] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebCore

[GTK] Add missing symbols to WebKitDOMEventTarget.symbols
​https://bugs.webkit.org/show_bug.cgi?id=123990

Reviewed by Philippe Normand.

Add webkit_dom_event_target_add_event_listener_with_closure and
webkit_dom_event_target_remove_event_listener_with_closure to the
symbols files.

  • bindings/gobject/WebKitDOMEventTarget.symbols:
  • bindings/gobject/webkitdom.symbols:
12:14 AM Changeset in webkit [158909] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Ignore deprecated macros when generating gtk-doc
​https://bugs.webkit.org/show_bug.cgi?id=123988

Reviewed by Philippe Normand.

  • gtk/generate-gtkdoc:

(get_common_options): Ignore also WEBKIT_DEPRECATED and
WEBKIT_DEPRECATED_FOR decorators.

12:12 AM Changeset in webkit [158908] by Carlos Garcia Campos
  • 3 edits in trunk/Tools

[GTK] Pass the library namespace to gtkdoc-mkdb
​https://bugs.webkit.org/show_bug.cgi?id=123900

Reviewed by Martin Robinson.

This fixes the generation of the index of symbols in the API
documentation.

  • gtk/generate-gtkdoc:

(get_webkit2_options): Define namespace as WebKit.
(get_webkit1_options): Ditto.
(get_webkitdom_options): Define namespace as WebKitDOM.

  • gtk/gtkdoc.py:

(GTKDoc.init): Add namespace option.
(GTKDoc._run_gtkdoc_mkdb): Pass namespace to mkdb if present.

12:09 AM Changeset in webkit [158907] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebCore

[GTK] Use deprecation guards around deprecated API in GObject DOM bindings
​https://bugs.webkit.org/show_bug.cgi?id=123899

Reviewed by Martin Robinson.

Do not include deprecated API when compiling with
WEBKIT_DISABLE_DEPRECATED option.

  • bindings/scripts/CodeGeneratorGObject.pm:

(GenerateFunction):

  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.cpp:
  • bindings/scripts/test/GObject/WebKitDOMTestEventTarget.h:
Note: See TracTimeline for information about the timeline view.