Context Navigation

← Previous Period
Next Period →

Timeline

Nov 26, 2013:

10:14 PM Changeset in webkit [159807] by rniwa@webkit.org

2 edits
2 adds in trunk/LayoutTests

Windows rebaselines after r158547.

platform/win/editing/selection/collapse-selection-in-bidi-expected.txt: Added.
platform/win/editing/selection/drag-text-delay-expected.txt: Added.
platform/win/editing/selection/extend-selection-home-end-expected.txt:

10:05 PM Changeset in webkit [159806] by marcelo.lira@openbossa.org

19 edits
14 adds in trunk

Nix upstreaming - Adding build files and supporting scripts
https://bugs.webkit.org/show_bug.cgi?id=118367

Reviewed by Ryosuke Niwa.

CMakeLists.txt:
Source/CMakeLists.txt:
Source/cmake/FindEGL.cmake:
Source/cmake/FindOpenGLES2.cmake: Added.
Source/cmake/OptionsCommon.cmake:
Source/cmake/OptionsNix.cmake: Added.

Source/Platform:

CMakeLists.txt: Added.
PlatformNix.cmake: Added.

Source/WebCore:

No new tests needed.

CMakeLists.txt:
PlatformNix.cmake: Added.

Source/WTF:

wtf/FeatureDefines.h:
wtf/Platform.h:
wtf/PlatformNix.cmake: Added.

Tools:

Scripts/build-webkit:
Scripts/run-nix-tests: Added.
Scripts/run-webkit-tests:
Scripts/update-webkit-libs-jhbuild:
Scripts/update-webkitnix-libs: Added.
Scripts/webkitdirs.pm:

(determineArchitecture):
(argumentsForConfiguration):
(jscProductDir):
(builtDylibPathForName):
(determineIsNix):
(isNix):
(isAppleWebKit):
(launcherPath):
(launcherName):
(checkRequiredSystemConfig):
(copyInspectorFrontendFiles):
(jhbuildWrapperPrefixIfNeeded):
(buildCMakeProjectOrExit):
(cmakeBasedPortName):

Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.port):
(EflWK2Port.build_webkit_command):
(NixPort):
(NixPort.build_webkit_command):

Scripts/webkitpy/port/factory.py:

(platform_options):
(PortFactory):

Scripts/webkitpy/port/nix.py: Added.

(NixPort):
(NixPort._wk2_port_name):
(NixPort.determine_full_port_name):
(NixPort.init):
(NixPort._port_flag_for_scripts):
(NixPort.setup_test_run):
(NixPort.setup_environ_for_server):
(NixPort.default_timeout_ms):
(NixPort.clean_up_test_run):
(NixPort._generate_all_test_configurations):
(NixPort._path_to_driver):
(NixPort._path_to_image_diff):
(NixPort._image_diff_command):
(NixPort._search_paths):
(NixPort.show_results_html_file):
(NixPort._port_specific_expectations_files):
(NixPort.default_baseline_search_path):

Scripts/webkitpy/port/nix_unittest.py: Added.

(NixPortTest):
(NixPortTest._assert_search_path):
(NixPortTest._assert_expectations_files):
(NixPortTest.test_baseline_search_path):
(NixPortTest.test_expectations_files):
(NixPortTest.test_default_timeout_ms):

jhbuild/jhbuild-wrapper:

(determine_platform):

nix/common.py: Added.

(script_path):
(top_level_path):

nix/jhbuild.modules: Added.
nix/jhbuildrc: Added.

9:33 PM Changeset in webkit [159805] by rniwa@webkit.org

10 edits in trunk

Record subtest values in Dromaeo tests
https://bugs.webkit.org/show_bug.cgi?id=124498

Reviewed by Andreas Kling.

PerformanceTests:

Made Dromaeo's test runner report values in DRT.progress via newly added PerfTestRunner.reportValues.

Dromaeo/resources/dromaeorunner.js:

(.): Moved the definition out of DRT.setup.
(DRT.setup): Ditto.
(DRT.testObject): Extracted from DRT.setup. Set the subtest name and continueTesting.
continueTesting is set true for subtests; i.e. when name is specified.
(DRT.progress): Call PerfTestRunner.reportValues to report subtest results.
(DRT.teardown): Call PerfTestRunner.reportValues instead of measureValueAsync.

resources/runner.js: Made various changes for newly added PerfTestRunner.reportValues.

(.): Moved the initialization of completedIterations, results, jsHeapResults, and mallocHeapResults into
start since they need to be initialized before running each subtest. Initialize logLines here since we
need to use the same logger for all subtests.
(.start): Initialize the variables mentioned above here. Also respect doNotLogStart used by reportValues.
(ignoreWarmUpAndLog): Added doNotLogProgress. Used by reportValues since it reports all values at once.
(finish): Compute the metric name such as FrameFrame and Runs from unit. Also don't log or notify done
when continueTesting is set on the test object.
(PerfTestRunner.reportValues): Added. Reports all values for the main/sub test.

Tools:

Supported parsing subtest results.

Scripts/webkitpy/performance_tests/perftest.py: Replaced _metrics with an ordered list of subtests, each of

which contains a dictionary with its name and an ordered list of subtest's metrics.
(PerfTest.init): Initialize _metrics as a list.
(PerfTest.run): Go through each subtest and its metrics to create a list of TestMetrics.
(PerfTest._run_with_driver):
(PerfTest._ensure_metrics): Look for a subtest then a metric in _metrics.

Scripts/webkitpy/performance_tests/perftest_unittest.py:

(TestPerfTest._assert_results_are_correct): Updated the assertions per changes to _metrics.
(TestPerfTest.test_parse_output): Ditto.
(TestPerfTest.test_parse_output_with_subtests): Added the metric and the unit on each subtest result as well as
assertions to ensure subtest results are parsed properly.
(TestReplayPerfTest.test_run_with_driver_accumulates_results): Updated the assertions per changes to _metrics.
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results): Dittp.

Scripts/webkitpy/performance_tests/perftestsrunner.py:

(_generate_results_dict): When the metric for a subtest is processed before that of the main test, the url is
incorrectly suffixed with '/'. Fix this later by re-computing the url with TestPerfMetric.test_file_name when
adding new results.

Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:

(TestWithSubtestsData): Added.
(TestDriver.run_test):
(MainTest.test_run_test_with_subtests): Added.

LayoutTests:

Rebaselined the test.

fast/harness/perftests/runs-per-second-log-expected.txt:

9:13 PM Changeset in webkit [159804] by rniwa@webkit.org

5 edits in trunk

Enable HTML template element on Windows ports
https://bugs.webkit.org/show_bug.cgi?id=124758

Reviewed by Andreas Kling.

Tools:

Scripts/webkitperl/FeatureList.pm:

WebKitLibraries:

Enable TEMPLATE_ELEMENT. Also removed UNDO_MANAGER since that feature has been removed
from the tree in r133326.

win/tools/vsprops/FeatureDefines.props:
win/tools/vsprops/FeatureDefinesCairo.props:

8:36 PM Changeset in webkit [159803] by rniwa@webkit.org

8 edits
1 delete in trunk

Remove replay performance tests as it's not actively maintained
https://bugs.webkit.org/show_bug.cgi?id=124764

Reviewed by Andreas Kling.

PerformanceTests:

Removed the replay performance tests. We can add them back when time comes.

Replay/Chinese/chinaz.com.replay: Removed.
Replay/Chinese/www.163.com.replay: Removed.
Replay/Chinese/www.alipay.com.replay: Removed.
Replay/Chinese/www.baidu.com.replay: Removed.
Replay/Chinese/www.csdn.net.replay: Removed.
Replay/Chinese/www.douban.com.replay: Removed.
Replay/Chinese/www.hao123.com.replay: Removed.
Replay/Chinese/www.xinhuanet.com.replay: Removed.
Replay/Chinese/www.xunlei.com.replay: Removed.
Replay/Chinese/www.youku.com.replay: Removed.
Replay/English/beatonna.livejournal.com.replay: Removed.
Replay/English/cakewrecks.blogspot.com.replay: Removed.
Replay/English/chemistry.about.com.replay: Removed.
Replay/English/digg.com.replay: Removed.
Replay/English/en.wikipedia.org-rorschach_test.replay: Removed.
Replay/English/icanhascheezburger.com.replay: Removed.
Replay/English/imgur.com-gallery.replay: Removed.
Replay/English/online.wsj.com.replay: Removed.
Replay/English/stockoverflow.com-best-comment.replay: Removed.
Replay/English/www.alibaba.com.replay: Removed.
Replay/English/www.amazon.com-kindle.replay: Removed.
Replay/English/www.apple.com.replay: Removed.
Replay/English/www.cnet.com.replay: Removed.
Replay/English/www.dailymotion.com.replay: Removed.
Replay/English/www.ehow.com-prevent-fire.replay: Removed.
Replay/English/www.filestube.com-amy-adams.replay: Removed.
Replay/English/www.foxnews.replay: Removed.
Replay/English/www.huffingtonpost.com.replay: Removed.
Replay/English/www.imdb.com-twilight.replay: Removed.
Replay/English/www.mozilla.com-all-order.replay: Removed.
Replay/English/www.php.net.replay: Removed.
Replay/English/www.reddit.com.replay: Removed.
Replay/English/www.telegraph.co.uk.replay: Removed.
Replay/English/www.w3.org-htmlcss.replay: Removed.
Replay/English/www.w3schools.com-html.replay: Removed.
Replay/English/www.youtube.com-music.replay: Removed.
Replay/French/www.orange.fr.replay: Removed.
Replay/Italian/www.repubblica.it.replay: Removed.
Replay/Japanese/2ch.net-newsplus.replay: Removed.
Replay/Japanese/entameblog.seesaa.net.replay: Removed.
Replay/Japanese/ja.wikipedia.org.replay: Removed.
Replay/Japanese/www.hatena.ne.jp.replay: Removed.
Replay/Japanese/www.livedoor.com.replay: Removed.
Replay/Japanese/www.nicovideo.jp.replay: Removed.
Replay/Japanese/www.rakuten.co.jp.replay: Removed.
Replay/Japanese/www.yahoo.co.jp.replay: Removed.
Replay/Korean/www.naver.com.replay: Removed.
Replay/Persian/blogfa.com.replay: Removed.
Replay/Polish/www.wp.pl.replay: Removed.
Replay/Portuguese/www.uol.com.br.replay: Removed.
Replay/Russian/lenta.ru.replay: Removed.
Replay/Russian/vkontakte.ru-help.replay: Removed.
Replay/Russian/www.ixbt.com.replay: Removed.
Replay/Russian/www.kp.ru.replay: Removed.
Replay/Russian/www.liveinternet.ru.replay: Removed.
Replay/Russian/www.pravda.ru.replay: Removed.
Replay/Russian/www.rambler.ru.replay: Removed.
Replay/Russian/www.ucoz.ru.replay: Removed.
Replay/Russian/www.yandex.ru.replay: Removed.
Replay/Spanish/www.taringa.net.replay: Removed.
Replay/Swedish/www.flashback.se.replay: Removed.
Replay/Swedish/www.tradera.com.replay: Removed.
Replay/www.google.com.replay: Removed.
Replay/www.techcrunch.com.replay: Removed.
Replay/www.youtube.com.replay: Removed.

Tools:

Removed the feature.

Scripts/webkitpy/performance_tests/perftest.py:

(SingleProcessPerfTest.init):
(PerfTestFactory):

Scripts/webkitpy/performance_tests/perftest_unittest.py:
Scripts/webkitpy/performance_tests/perftestsrunner.py:

(PerfTestsRunner._parse_args):
(PerfTestsRunner._collect_tests):

Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:

(MainTest.test_collect_tests_with_ignored_skipped_list):
(MainTest.test_default_args):

Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_unittest2):

Scripts/webkitpy/thirdparty/init_unittest.py:

(ThirdpartyTest.test_imports):

8:32 PM Changeset in webkit [159802] by rniwa@webkit.org

1 edit
12 adds in trunk/LayoutTests/imported/w3c

Import W3C tests for cloning template elements and default stylesheet for template element
https://bugs.webkit.org/show_bug.cgi?id=124882

Reviewed by Andreas Kling.

Imported tests under html-templates/additions-to-the-steps-to-clone-a-node and
html-templates/additions-to-the-css-user-agent-style-sheet at d38dbd5b492808811bc0fe04a8cc49f28863c5cc.

Renamed and replicated css-user-agent-style-sheet-test-001-ref.html as -00*-expected.html for ref testing.

html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-001-expected.html: Added.
html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-001.html: Added.
html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-002-expected.html: Added.
html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-002.html: Added.
html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-003-expected.html: Added.
html-templates/additions-to-the-css-user-agent-style-sheet/css-user-agent-style-sheet-test-003.html: Added.
html-templates/additions-to-the-steps-to-clone-a-node/template-clone-children-expected.txt: Added.
html-templates/additions-to-the-steps-to-clone-a-node/template-clone-children.html: Added.
html-templates/additions-to-the-steps-to-clone-a-node/templates-copy-document-owner-expected.txt: Added.
html-templates/additions-to-the-steps-to-clone-a-node/templates-copy-document-owner.html: Added.

8:05 PM Changeset in webkit [159801] by fpizlo@apple.com

2 edits in trunk/Tools

Enable aggressive DFG validation in testing
https://bugs.webkit.org/show_bug.cgi?id=124911

Rubber stamped by Ryosuke Niwa.

This enables validation testing in non-concurrent-JIT runs.

Scripts/run-jsc-stress-tests:

7:50 PM Changeset in webkit [159800] by timothy_horton@apple.com

2 edits in trunk/Source/WebCore

Don't parent the TileController root layer in two places
https://bugs.webkit.org/show_bug.cgi?id=124873

Reviewed by Brent Fulgham.

platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::TileController):
The TileController's layer is already parented by callers of
TileController::create, and in a special way. TileController
shouldn't parent itself, anyway...

7:35 PM Changeset in webkit [159799] by commit-queue@webkit.org

3 edits in trunk/Source/WTF

ASSERT_WITH_SECURITY_IMPLICATION should crash in a distinct way.
https://bugs.webkit.org/show_bug.cgi?id=124757

Change ASSERT_WITH_SECURITY_IMPLICATION to access a different address from CRASH()
in order to help screen fuzzing bugs.

Patch by Drew Yao <ayao@apple.com> on 2013-11-26
Reviewed by Brent Fulgham.

wtf/Assertions.cpp:
wtf/Assertions.h:

6:47 PM Changeset in webkit [159798] by fpizlo@apple.com

37 edits
1 add in trunk/Source/JavaScriptCore

Restructure global variable constant inference so that it could work for any kind of symbol table variable
https://bugs.webkit.org/show_bug.cgi?id=124760

Reviewed by Oliver Hunt.

This changes the way global variable constant inference works so that it can be reused
for closure variable constant inference. Some of the premises that originally motivated
this patch are somewhat wrong, but it led to some simplifications anyway and I suspect
that we'll be able to fix those premises in the future. The main point of this patch is
to make it easy to reuse global variable constant inference for closure variable
constant inference, and this will be possible provided we can also either (a) infer
one-shot closures (easy) or (b) infer closure variables that are always assigned prior
to first use.

One of the things that this patch is meant to enable is constant inference for closure
variables that may be part of a multi-shot closure. Closure variables may be
instantiated multiple times, like:

function foo() {

var WIDTH = 45;
function bar() {

... use WIDTH ...

}
...

}

Even if foo() is called many times and WIDTH is assigned to multiple times, that
doesn't change the fact that it's a constant. The goal of closure variable constant
inference is to catch any case where a closure variable has been assigned at least once
and its value has never changed. This patch doesn't implement that, but it does change
global variable constant inference to have most of the powers needed to do that. Note
that most likely we will use this functionality only to implement constant inference
for one-shot closures, but the resulting machinery is still simpler than what we had
before.

This involves three changes:

The watchpoint object now contains the inferred value. This involves creating a new kind of watchpoint set, the VariableWatchpointSet. We will reuse this object for closure variables.

Writing to a variable that is watchpointed still involves these three states that we proceed through monotonically (Uninitialized->Initialized->Invalidated) but now, the Initialized->Invalidated state transition only happens if we change the variable's value, rather than store to the variable. Repeatedly storing the same value won't change the variable's state.

On 64-bit systems (the only systems on which we do concurrent JIT), you no longer need fancy fencing to get a consistent view of the watchpoint in the JIT. The state of the VariableWatchpointSet for the purposes of constant folding is entirely encapsulated in the VariableWatchpointSet::m_inferredValue. If that is JSValue() then you cannot fold (either because the set is uninitialized or because it's invalidated - doesn't matter which); on the other hand if the value is anything other than JSValue() then you can fold, and that's the value you fold to. Simple!

This also changes the way that DFG IR deals with variable watchpoints. It's now
oblivious to global variables. You install a watchpoint using VariableWatchpoint and
you notify write using NotifyWrite. Easy!

Note that this will requires some more tweaks because of the fact that op_enter will
store Undefined into every captured variable. Hence it won't even work for one-shot
closures. One-shot closures are easily fixed by introducing another state (so we'll
have Uninitialized->Undefined->Initialized->Invalidated). Multi-shot closures will
require static analysis. One-shot closures are clearly a higher priority.

GNUmakefile.list.am:
JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
JavaScriptCore.xcodeproj/project.pbxproj:
bytecode/Instruction.h:
bytecode/VariableWatchpointSet.h: Added.

(JSC::VariableWatchpointSet::VariableWatchpointSet):
(JSC::VariableWatchpointSet::~VariableWatchpointSet):
(JSC::VariableWatchpointSet::inferredValue):
(JSC::VariableWatchpointSet::notifyWrite):
(JSC::VariableWatchpointSet::invalidate):
(JSC::VariableWatchpointSet::finalizeUnconditionally):
(JSC::VariableWatchpointSet::addressOfInferredValue):

bytecode/Watchpoint.h:
dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::::executeEffects):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::performNodeCSE):

dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

dfg/DFGNode.h:

(JSC::DFG::Node::hasRegisterPointer):
(JSC::DFG::Node::hasVariableWatchpointSet):
(JSC::DFG::Node::variableWatchpointSet):

dfg/DFGNodeType.h:
dfg/DFGOperations.cpp:
dfg/DFGOperations.h:
dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithMod):

dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

dfg/DFGWatchpointCollectionPhase.cpp:

(JSC::DFG::WatchpointCollectionPhase::handle):

ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileNotifyWrite):

jit/JIT.h:
jit/JITOperations.h:
jit/JITPropertyAccess.cpp:

(JSC::JIT::emitNotifyWrite):
(JSC::JIT::emitPutGlobalVar):

jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emitNotifyWrite):
(JSC::JIT::emitPutGlobalVar):

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::addGlobalVar):
(JSC::JSGlobalObject::addFunction):

runtime/JSGlobalObject.h:
runtime/JSScope.h:

(JSC::ResolveOp::ResolveOp):

runtime/JSSymbolTableObject.h:

(JSC::symbolTablePut):
(JSC::symbolTablePutWithAttributes):

runtime/SymbolTable.cpp:

(JSC::SymbolTableEntry::inferredValue):
(JSC::SymbolTableEntry::prepareToWatch):
(JSC::SymbolTableEntry::addWatchpoint):
(JSC::SymbolTableEntry::notifyWriteSlow):
(JSC::SymbolTable::visitChildren):
(JSC::SymbolTable::WatchpointCleanup::WatchpointCleanup):
(JSC::SymbolTable::WatchpointCleanup::~WatchpointCleanup):
(JSC::SymbolTable::WatchpointCleanup::finalizeUnconditionally):

runtime/SymbolTable.h:

(JSC::SymbolTableEntry::watchpointSet):
(JSC::SymbolTableEntry::notifyWrite):

6:13 PM Changeset in webkit [159797] by commit-queue@webkit.org

10 edits
5 adds in trunk

[MediaStream API] HTMLMediaElement should be able to use MediaStream as source
https://bugs.webkit.org/show_bug.cgi?id=121943

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-26
Reviewed by Eric Carlson.

Source/WebCore:

Implement MediaStream direct assignment to Media Elements using the new 'srcObject'
attribute: http://www.w3.org/TR/mediacapture-streams/#direct-assignment-to-media-elements

Test: fast/mediastream/MediaStream-MediaElement-srcObject.html

CMakeLists.txt: Added new HTMLMediaElementMediaStream.h and .cpp to cmake build.
DerivedSources.make: Added HTMLMediaElementMediaStream.idl.
GNUmakefile.list.am: Added new HTMLMediaElementMediaStream* to autotools build.
WebCore.xcodeproj/project.pbxproj: Added new files.
Modules/mediastream/HTMLMediaElementMediaStream.cpp: Added.

(WebCore::HTMLMediaElementMediaStream::srcObject): implements srcObject getter.
(WebCore::HTMLMediaElementMediaStream::setSrcObject): implements srcObject setter.

Modules/mediastream/HTMLMediaElementMediaStream.h: Added.
Modules/mediastream/HTMLMediaElementMediaStream.idl: Added.
html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setSrcObject): This is an initial implementation, and
is still incomplete, that will be addressed in a separate bug: https://webkit.org/b/124896

html/HTMLMediaElement.h: Added m_mediaStreamSrcObject class variable

and its corresponding getter.

Source/WebKit2:

Add mediastream module and platform to cmake include directories.

CMakeLists.txt:

LayoutTests:

Add layout tests to MediaStream direct assignment to HTMLMediaElement
using brand new srcObject attribute.

fast/mediastream/MediaStream-MediaElement-srcObject-expected.txt: Added.
fast/mediastream/MediaStream-MediaElement-srcObject.html: Added.

5:27 PM Changeset in webkit [159796] by commit-queue@webkit.org

6 edits in trunk/Tools

Moved methods which belong to Checkout into checkout.py
https://bugs.webkit.org/show_bug.cgi?id=124889

Patch by Dániel Bátyai <Batyai.Daniel@stud.u-szeged.hu> on 2013-11-26
Reviewed by Ryosuke Niwa.

Scripts/webkitpy/common/checkout/checkout.py:

(Checkout.scripts_directory):
(Checkout):
(Checkout.script_path):
(Checkout.commit_message_for_this_commit):
(Checkout.apply_patch):

Scripts/webkitpy/common/checkout/checkout_unittest.py:

(test_commit_message_for_this_commit):
(CheckoutTest.test_apply_patch):

Scripts/webkitpy/common/checkout/scm/scm.py:

(SCM.absolute_path):

Scripts/webkitpy/common/checkout/scm/scm_unittest.py:

(SCMTest._setup_webkittools_scripts_symlink):

Scripts/webkitpy/common/checkout/scm/svn.py:

(SVN.create_patch):

5:22 PM Changeset in webkit [159795] by fpizlo@apple.com

8 edits in trunk/Source/JavaScriptCore

Create a new SymbolTable every time code is loaded so that the watchpoints don't get reused
https://bugs.webkit.org/show_bug.cgi?id=124824

Reviewed by Oliver Hunt.

This helps with one shot closure inference as well as closure variable constant
inference, since without this, if code was reloaded from the cache then we would
think that the first run was actually an Nth run. This would cause us to think that
the watchpoint(s) should all be invalidated.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::stronglyVisitStrongReferences):

bytecode/CodeBlock.h:

(JSC::CodeBlock::symbolTable):

runtime/Executable.cpp:

(JSC::FunctionExecutable::symbolTable):

runtime/Executable.h:
runtime/SymbolTable.cpp:

(JSC::SymbolTable::clone):

runtime/SymbolTable.h:

3:55 PM Changeset in webkit [159794] by Brent Fulgham

3 edits in trunk/Source/WebCore

Use child iterator to find operators in RenderMathMLRow::layout().
<https://webkit.org/b/124108>

Replace manual children walk with childrenOfType<RenderMathMLBlock>.
Minor update to fix build.

Patch by Andreas Kling <akling@apple.com> on 2013-11-26
Reviewed by Martin Robinson.

3:36 PM Changeset in webkit [159793] by akling@apple.com

3 edits in trunk/Source/WebCore

RenderObject: Inline isBody() and isHR().
<https://webkit.org/b/124901>

Together these account for ~0.3% of samples on HTML5-8266.
Almost all of it is call overhead.

Reviewed by Anders Carlsson.

3:05 PM Changeset in webkit [159792] by betravis@adobe.com

36 edits
6 adds in trunk

[CSS Shapes] Layout using [<box>

<shape>] value

https://bugs.webkit.org/show_bug.cgi?id=124428

Reviewed by David Hyatt.

Source/WebCore:

When a box value is supplied, use it to size and position the shape. Otherwise,
use a default value (content-box for shape-inside, margin-box for shape-outside).
This patch extends the sizing and positioning code used for the box patch (Bug 124227)
to also apply to shapes. With this patch, we also no longer use the box-sizing
property to size and position shapes.

Tests: fast/shapes/shape-outside-floats/shape-outside-shape-boxes-001.html

fast/shapes/shape-outside-floats/shape-outside-shape-boxes-002.html
fast/shapes/shape-outside-floats/shape-outside-shape-boxes-003.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue): Adjust for ShapeValues storing
BasicShape::ReferenceBox as their box value, rather than a CSSValueID.

css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyShape::applyValue): Ditto.

rendering/shapes/ShapeInfo.h:

(WebCore::ShapeInfo::setShapeSize): Adjust for BasicShapes with reference boxes
as well as plain box values. Also, remove old box-sizing code.
(WebCore::ShapeInfo::logicalTopOffset): Ditto.
(WebCore::ShapeInfo::logicalLeftOffset): Ditto.

rendering/shapes/ShapeInsideInfo.h:
rendering/shapes/ShapeOutsideInfo.h:
rendering/style/ShapeValue.h:

(WebCore::ShapeValue::createBoxValue): Adjust for boxes being stored as
BasicShape::ReferenceBoxes.
(WebCore::ShapeValue::box): Ditto.
(WebCore::ShapeValue::ShapeValue): Ditto.

LayoutTests:

Adding tests to make sure that shapes properly size and position themselves across box values
and writing modes. Some shape-outside tests needed to be updated to explicitly size themselves
to content-box, as they were relying on that being the default value. Some shape-inside tests
needed to be adjusted as box-sizing no longer affects the shape size and position.

csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-circle-001.html:

Explicitly size to content-box.

csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-001.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-002.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-003.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-004.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-010.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-011.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-012.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-014.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-015.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-016.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-017.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-018.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-margin-021.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-001.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-002.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-003.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-padding-004.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-000.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-001.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-polygon-002.html: Ditto.
csswg/contributors/adobe/submitted/shapes/shape-outside/shape-outside-floats-square-border-000.html: Ditto.
fast/shapes/shape-inside/shape-inside-box-sizing-expected.html: Small test cleanup.
fast/shapes/shape-inside/shape-inside-box-sizing.html: Modify shapes to provide their sizing box.
fast/shapes/shape-inside/shape-inside-empty-expected.html: Small test cleanup.
fast/shapes/shape-inside/shape-inside-empty.html: Modify shapes to provide their sizing box.
fast/shapes/shape-outside-floats/shape-outside-floats-different-writing-modes.html: Ditto.
fast/shapes/shape-outside-floats/shape-outside-shape-boxes-001-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-shape-boxes-001.html: Added.
fast/shapes/shape-outside-floats/shape-outside-shape-boxes-002-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-shape-boxes-002.html: Added.
fast/shapes/shape-outside-floats/shape-outside-shape-boxes-003-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-shape-boxes-003.html: Added.
inspector-protocol/model/highlight-shape-outside.html: Modify shapes to provide their sizing box.

2:58 PM Changeset in webkit [159791] by commit-queue@webkit.org

45 edits in trunk/Source/WebCore

ImageBuffer::create should return a std::unique_ptr instead of OwnPtr.
https://bugs.webkit.org/show_bug.cgi?id=124822

Patch by Brian J. Burg <Brian Burg> on 2013-11-26
Reviewed by Andreas Kling.

Replace all uses of OwnPtr<ImageBuffer> and PassOwnPtr<ImageBuffer> with
std::unique_ptr<ImageBuffer>. Replace calls to OwnPtr::clear() and
OwnPtr::release() with reset() and std::move(). Remove unnecessary includes.

No new tests. This is a mechanical refactoring.

css/CSSFilterImageValue.cpp:

(WebCore::CSSFilterImageValue::image):

html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::setSurfaceSize):

html/HTMLCanvasElement.h:
html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::createCompositingBuffer):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedFill):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

html/canvas/CanvasRenderingContext2D.h:
html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::LRUImageBufferCache::LRUImageBufferCache):
(WebCore::WebGLRenderingContext::LRUImageBufferCache::imageBuffer):

html/canvas/WebGLRenderingContext.h:
html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):

page/Frame.cpp:

(WebCore::Frame::nodeImage):
(WebCore::Frame::dragImageForSelection):

platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::drawPattern):

platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::drawPattern):

platform/graphics/GradientImage.h:
platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::createCompatibleBuffer):

platform/graphics/GraphicsContext.h:
platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::createCompatibleBuffer):

platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::create):

platform/graphics/ShadowBlur.cpp:
platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::putByteArray):

platform/graphics/cg/PDFDocumentImage.h:
platform/graphics/filters/FETile.cpp:

(WebCore::FETile::platformApplySoftware):

platform/graphics/filters/Filter.h:

(WebCore::Filter::setSourceImage):

platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::clearResult):

platform/graphics/filters/FilterEffect.h:
platform/graphics/texmap/TextureMapper.cpp:

(WebCore::BitmapTexture::updateContents):

platform/graphics/texmap/TextureMapperImageBuffer.h:
rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDecoration):

rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintProgressBar):

rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape):

rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::invalidateBufferedForeground):

rendering/svg/RenderSVGImage.h:
rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyClippingToContext):

rendering/svg/RenderSVGResourceClipper.h:
rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::postApplyResource):

rendering/svg/RenderSVGResourceFilter.h:
rendering/svg/RenderSVGResourceGradient.cpp: Remove method parameter wrapping/indentation.

(WebCore::createMaskAndSwapContextForTextGradient):
(WebCore::clipToTextMask):
(WebCore::RenderSVGResourceGradient::applyResource):

rendering/svg/RenderSVGResourceGradient.h:
rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):

rendering/svg/RenderSVGResourceMasker.h:
rendering/svg/RenderSVGResourcePattern.cpp: Remove method parameter wrapping/indentation.

(WebCore::RenderSVGResourcePattern::buildPattern):
(WebCore::RenderSVGResourcePattern::createTileImage):

rendering/svg/RenderSVGResourcePattern.h: Remove method parameter wrapping/indentation.
rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::createImageBuffer):
(WebCore::SVGRenderingContext::createImageBufferForPattern):
(WebCore::SVGRenderingContext::clipToImageBuffer):
(WebCore::SVGRenderingContext::bufferForeground):

rendering/svg/SVGRenderingContext.h:
svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::nativeImageForCurrentFrame):
(WebCore::SVGImage::drawPatternForContainer):

12:24 PM Changeset in webkit [159790] by oliver@apple.com

5 edits in trunk

Crash in JSC::ASTBuilder::Expression JSC::Parser<JSC::Lexer<unsigned char> >::parseUnaryExpression<JSC::ASTBuilder>(JSC::ASTBuilder&)
https://bugs.webkit.org/show_bug.cgi?id=124886

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Make sure the error macros propagate an existing error before
trying to create a new error message. We need to do this as
the parser state may not be safe for any specific error message
if we are already unwinding due to an error.

parser/Parser.cpp:

LayoutTests:

Add tests

js/parser-syntax-check-expected.txt:
js/script-tests/parser-syntax-check.js:

12:11 PM Changeset in webkit [159789] by eric.carlson@apple.com

3 edits
2 adds in trunk

video.currentSrc should return empty when no resource is loaded
https://bugs.webkit.org/show_bug.cgi?id=124898

Reviewed by Dan Bernstein.

Source/WebCore:

Test: media/video-currentsrc-cleared.html

html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::prepareForLoad): Set m_currentSrc to empty in

preparation for attempting to load a new url.

LayoutTests:

media/video-currentsrc-cleared-expected.txt: Added.
media/video-currentsrc-cleared.html: Added.

12:07 PM Changeset in webkit [159788] by mitz@apple.com

31 edits in trunk/Source/WebKit2

Some WebKit2 headers are not self-contained
https://bugs.webkit.org/show_bug.cgi?id=124884

Reviewed by Anders Carlsson.

Shared/API/Cocoa/WKRemoteObjectInterface.h: Added import.
Shared/API/Cocoa/WKRemoteObjectRegistry.h: Ditto.
Shared/API/c/WKContextMenuItemTypes.h: Added include.
Shared/API/c/WKFindOptions.h: Ditto.
Shared/API/c/WKMutableArray.h: Ditto.
Shared/API/c/WKPageLoadTypes.h: Ditto.
Shared/API/c/WKPageVisibilityTypes.h: Ditto.

Shared/API/c/WKPluginInformation.cpp:

(WKPluginInformationBundleIdentifierKey): Made this API function always be defined. When
the Netscape plug-in API is not enabled, it returns 0.
(WKPluginInformationBundleVersionKey): Ditto.
(WKPluginInformationBundleShortVersionKey): Ditto.
(WKPluginInformationPathKey): Ditto.
(WKPluginInformationDisplayNameKey): Ditto.
(WKPluginInformationDefaultLoadPolicyKey): Ditto.
(WKPluginInformationUpdatePastLastBlockedVersionIsKnownAvailableKey): Ditto.
(WKPluginInformationHasSandboxProfileKey): Ditto.
(WKPluginInformationFrameURLKey): Ditto.
(WKPluginInformationMIMETypeKey): Ditto.
(WKPluginInformationPageURLKey): Ditto.
(WKPluginInformationPluginspageAttributeURLKey): Ditto.
(WKPluginInformationPluginURLKey): Ditto.
(WKPlugInInformationReplacementObscuredKey): Ditto.

Shared/API/c/WKString.h: Added include.
UIProcess/API/C/WKCredentialTypes.h: Ditto.
UIProcess/API/C/WKPageContextMenuClient.h: Ditto.
UIProcess/API/C/WKPageLoaderClient.h: Added includes.
UIProcess/API/C/WKPagePolicyClient.h: Ditto.
UIProcess/API/C/WKPageUIClient.h: Ditto.

UIProcess/API/C/WKPluginSiteDataManager.cpp:

(WKPluginSiteDataManagerGetTypeID): Fixed the !ENABLE(NETSCAPE_PLUGIN_API) build.

UIProcess/API/C/mac/WKContextPrivateMac.h: Removed use of ENABLE() from this private

header.

UIProcess/API/C/mac/WKContextPrivateMac.mm:

(WKContextCopyPlugInInfoForBundleIdentifier): Made this API function always be defined.
When the Netscape plug-in API is not enabled, it returns 0.
(WKContextGetInfoForInstalledPlugIns): Made this API function always be defined.

UIProcess/API/C/mac/WKInspectorPrivateMac.h: Added imports.
UIProcess/API/C/mac/WKPagePrivateMac.h: Added include.
UIProcess/API/Cocoa/WKBackForwardListItem.h: Added import.
UIProcess/API/Cocoa/WKNavigationData.h: Ditto.
UIProcess/API/cpp/WKRetainPtr.h: Replaced use of WARN_UNUSED_RETURN in this private header

with an equivalent macro defined in the header.

WebProcess/InjectedBundle/API/c/WKBundleFramePrivate.h: Added include.
WebProcess/InjectedBundle/API/c/WKBundleInspector.cpp:

(WKBundleInspectorGetTypeID): Made this API function always be defined. When the Inspector
is not enabled, it returns the Null type.
(WKBundleInspectorShow): Made this API function always be defined.
(WKBundleInspectorClose): Ditto.
(WKBundleInspectorEvaluateScriptForTest): Ditto.
(WKBundleInspectorSetPageProfilingEnabled): Ditto.

WebProcess/InjectedBundle/API/c/WKBundleInspector.h: Removed use of ENABLE() from this

private header.

WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h: Added includes.
WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Added include.

WebProcess/Plugins/Netscape/mac/WKNPAPIPlugInContainer.mm:

(-[WKNPAPIPlugInContainer openPlugInPreferencePane]): Fixed the !ENABLE(NETSCAPE_PLUGIN_API)
build.

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::createJavaAppletWidget): Ditto.

WebProcess/WebPage/mac/WebInspectorMac.mm: Fixed the !ENABLE(INSPECTOR) build.

11:19 AM Changeset in webkit [159787] by hmuller@adobe.com

5 edits
4 adds in trunk

[CSS Shapes] Support for shape-margin in BoxShape
https://bugs.webkit.org/show_bug.cgi?id=124788

Source/WebCore:

Reviewed by Andreas Kling.

Corrected BoxShape's internal shape-margin/padding bounds FloatRoundedRect
initialization. Tests for the padding bounds will be added when the rest of
shape-padding for box shapes implementation is ready.

Tests: fast/shapes/shape-outside-floats/shape-outside-margin-boxes-001.html

fast/shapes/shape-outside-floats/shape-outside-margin-boxes-002.html

rendering/shapes/BoxShape.cpp: Use constructor shape-margin,shape-padding parameters.

(WebCore::BoxShape::BoxShape):

rendering/shapes/BoxShape.h:
rendering/shapes/Shape.cpp:

(WebCore::createBoxShape): Pass the shape-margin and shape-padding values along to the BoxShape constructor.
(WebCore::Shape::createShape): Ditto.

LayoutTests:

Verify that shape-margin has the expected effect on the four possible shape-outside box values
for left and right floats.

Reviewed by Andreas Kling.

fast/shapes/shape-outside-floats/shape-outside-margin-boxes-001-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-margin-boxes-001.html: Added.
fast/shapes/shape-outside-floats/shape-outside-margin-boxes-002-expected.html: Added.
fast/shapes/shape-outside-floats/shape-outside-margin-boxes-002.html: Added.

10:34 AM Changeset in webkit [159786] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Remove unnecessary webaudio include from MediaStreamSource header
https://bugs.webkit.org/show_bug.cgi?id=124897

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-26
Reviewed by Eric Carlson.

AudioDestinationConsumer.h is included but not used anywhere in
MediaStreamSource implementation.

platform/mediastream/MediaStreamSource.h:

9:47 AM Changeset in webkit [159785] by Gustavo Noronha Silva

2 edits in trunk/Source/WebCore/platform/gtk/po

Updated Brazilian Portuguese translation of WebKitGTK+ - November 02, 2013
https://bugs.webkit.org/show_bug.cgi?id=123694

Patch by Enrico Nicoletto <liverig@gmail.com> on 2013-11-26
Reviewed by Gustavo Noronha.

pt_BR.po: updated.

9:21 AM Changeset in webkit [159784] by Michał Pakuła vel Rutka

2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Add test expectations for failing accessibility tests.

platform/efl/TestExpectations:

9:10 AM Changeset in webkit [159783] by nrotem@apple.com

2 edits in trunk/Source/JavaScriptCore

Optimize away OR with zero - a common ASM.js pattern.
https://bugs.webkit.org/show_bug.cgi?id=124869

Reviewed by Filip Pizlo.

dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

8:20 AM Changeset in webkit [159782] by akling@apple.com

2 edits in trunk/Source/WebCore

Avoid unnecessary copy-on-write in FillLayer style application.
<https://webkit.org/b/124878>

We ended up with a lot of cloned StyleBackgroundData objects on
HTML5-8266. This happened because we always forced a copy-on-write
when applying background-image:inherit / background-image:initial.

This patch adds early returns to both functions. In the "inherit"
case, we bail early if the target style already has the same fill
layer data as its parent style.

In the "initial" case, we optimize for the single-FillLayer case
and add an early return if the relevant value is either unset or
equal to the templatized initial value.

2.46 MB progression on HTML5-8266 locally.

Reviewed by Antti Koivisto.

6:09 AM Changeset in webkit [159781] by Michał Pakuła vel Rutka

4 edits in trunk/LayoutTests

Unreviewed ATK gardening

Rebaseline accessibility tests after r159747.

platform/efl-wk1/accessibility/table-detection-expected.txt:
platform/efl-wk2/accessibility/table-detection-expected.txt:
platform/gtk/accessibility/table-detection-expected.txt:

12:29 AM Changeset in webkit [159780] by Antoine Quint

6 edits in trunk/Source

Web Inspector: Allow showing a context menu on all mouse events.
https://bugs.webkit.org/show_bug.cgi?id=124747

Reviewed by Joseph Pecoraro.

Source/WebCore:

Add a new InspectorFrontendHost::dispatchEventAsContextMenuEvent(Event*) method
to let the inspector front-end dispatch a native contextmenu event that will allow
for a context menu to be shown from within a non-contextmenu event handler.

inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::dispatchEventAsContextMenuEvent):
Check that we're dealing with a mouse event, get the frame for the event target
and the event's location to call ContextMenuController::showContextMenuAt()
which will handle the new contextmenu event dispatch to the original event target.

inspector/InspectorFrontendHost.h:
inspector/InspectorFrontendHost.idl:

Source/WebInspectorUI:

Automatically dispatch a contextmenu event in case WebInspector.ContextMenu.prototype.show()
is called outside of a contextmenu event handler and would therefore not show the expected
context menu (except in the Remote Web Inspector where this already works).

UserInterface/ContextMenu.js:

(WebInspector.ContextMenu.prototype.show):
Check whether the event is a contextmenu event, and if not, add an event listener for a manually
dispatched contextmenu event such that we may then call InspectorFrontendHost.showContextMenu()
in a contextmenu event handler.

(WebInspector.ContextMenu.prototype.handleEvent):
Call InspectorFrontendHost.showContextMenu() now that we received the manually dispatched
contextmenu event.

Nov 25, 2013:

9:54 PM Changeset in webkit [159779] by weinig@apple.com

17 edits in trunk/Source/WebCore

Convert some Shape code to use references
https://bugs.webkit.org/show_bug.cgi?id=124876

Reviewed by Andreas Kling.

inspector/InspectorOverlay.cpp:
rendering/FloatingObjects.cpp:
rendering/LayoutState.cpp:
rendering/RenderBlock.cpp:
rendering/RenderBlock.h:
rendering/RenderBlockLineLayout.cpp:
rendering/RenderBox.cpp:
rendering/RenderBox.h:
rendering/line/BreakingContextInlineHeaders.h:
rendering/line/LineWidth.cpp:
rendering/shapes/ShapeInfo.cpp:
rendering/shapes/ShapeInfo.h:
rendering/shapes/ShapeInsideInfo.cpp:
rendering/shapes/ShapeInsideInfo.h:
rendering/shapes/ShapeOutsideInfo.cpp:
rendering/shapes/ShapeOutsideInfo.h:

Replace yet more pointers with references.

9:46 PM Changeset in webkit [159778] by ryuan.choi@samsung.com

2 edits in trunk

[EFL] E_DBus should be an optional
https://bugs.webkit.org/show_bug.cgi?id=124881

Reviewed by Gyuyoung Kim.

Source/cmake/OptionsEfl.cmake:

Checked E_DBus when only ENABLE_BATTERY_STATUS is on.

6:21 PM Changeset in webkit [159777] by Alexandru Chiculita

3 edits in trunk/Source/WebInspectorUI

Web Inspector: [CSS Regions] A page with many flows should collapse the resources tree
https://bugs.webkit.org/show_bug.cgi?id=122926

Reviewed by Timothy Hatcher.

Refactored the code in FrameTreeElement._shouldGroupIntoFolders to make it easy to track
more types of resources. Added the content flows as another type of resource that would trigger the
collapsing.

UserInterface/DOMTreeManager.js:

(WebInspector.DOMTreeManager.prototype.namedFlowRemoved): Added code to remove the content nodes from
a flow that has been removed.

UserInterface/FrameTreeElement.js:

(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushCategory):
(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders.pushResourceType):
(WebInspector.FrameTreeElement.prototype._shouldGroupIntoFolders):

6:16 PM Changeset in webkit [159776] by ryuan.choi@samsung.com

4 edits
1 delete in trunk

[EFL] Use Config mode of find_package for EFL 1.8
https://bugs.webkit.org/show_bug.cgi?id=124555

Reviewed by Gyuyoung Kim.

EFL 1.8 changed VERSION macro so it's difficult to use tricky approach
which parses header files to know the version. Instead, EFL 1.8 supports
FooConfig.cmake such as EinaConfig.cmake.

This patch tries to use a config mode if it is available.
If config mode is not available with Eo, FindFoo.cmake will be used without
version requirement.

Source/cmake/FindEo.cmake: Removed.

EoConfig.cmake is only preffered for EFL 1.8.

Source/cmake/OptionsEfl.cmake:

Tools:

MiniBrowser/efl/CMakeLists.txt:

Added optional config mode and made version requirement optional.

4:47 PM Changeset in webkit [159775] by mitz@apple.com

7 edits in trunk/Source/WebKit2

[Cocoa] Use class extensions for IPI
https://bugs.webkit.org/show_bug.cgi?id=124870

Reviewed by Sam Weinig.

UIProcess/API/mac/WKBrowsingContextController.mm: Reordered methods so that the Private

cateogry isn’t stuck between the API methods and the internal methods.
(-[WKBrowsingContextController setPaginationMode:]):
(-[WKBrowsingContextController paginationMode]):
(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]):
(-[WKBrowsingContextController paginationBehavesLikeColumns]):
(-[WKBrowsingContextController setPageLength:]):
(-[WKBrowsingContextController pageLength]):
(-[WKBrowsingContextController setGapBetweenPages:]):
(-[WKBrowsingContextController gapBetweenPages]):
(-[WKBrowsingContextController pageCount]):
(-[WKBrowsingContextController handle]):

UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Changed Internal category into

a class extension.

UIProcess/API/mac/WKConnection.mm:
UIProcess/API/mac/WKConnectionInternal.h: Changed Internal category into a class

extension.

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:
WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInInternal.h: Ditto.

4:21 PM Changeset in webkit [159774] by commit-queue@webkit.org

2 edits in trunk/Tools

[GTK] Search functionality in MiniBrowser provides feedback on search fail
https://bugs.webkit.org/show_bug.cgi?id=122681

Patch by Andres Gomez <Andres Gomez> on 2013-11-25
Reviewed by Mario Sanchez Prada.

When using the search functionality in MiniBrowser, if the search
fails, the entry background color gets red to report the user
about the failing condition. When the entry is cleaned or the
search is again succesful the background turns back to its
original color.

MiniBrowser/gtk/BrowserSearchBar.c:

(setFailedStyleForEntry): Added.
(doSearch): Sets the entry's background to its original style if
there is no text to search.
(findControllerFailedToFindTextCallback): Added.
(findControllerFoundTextCallback): Added.
(browser_search_bar_init): Creates and adds a new CSS provider to
the text entry so we can change its style based on the success
condition of the search.
(browserSearchBarFinalize): Frees the new CSS provider.
(browser_search_bar_new): Connects the two new handlers to the
"failed-to-find-text" and "found-text" signals emitted by the
WebKitFindController.

4:20 PM Changeset in webkit [159773] by mitz@apple.com

2 edits in trunk/Source/WebKit2

Fixed the iOS build.

UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadDelegateInternal]):
(-[WKBrowsingContextController setLoadDelegateInternal:]):

3:55 PM Changeset in webkit [159772] by simon.pena@samsung.com

2 edits in trunk/Source/WebCore

[EFL] X11Helper::createPixmap doesn't initialise out value handleId
https://bugs.webkit.org/show_bug.cgi?id=124722

Reviewed by Gyuyoung Kim.

The overloaded functions X11Helper::createPixmap don't initialise out
value handleId, and they do early returns on error situations. Since
the functions are void and they don't communicate their failure in any
way, returning an out value without initialising it could make the
error go farther unnoticed. With the variable being initialised, it can
be reliably checked for errors when the function returns.

platform/graphics/surfaces/glx/X11Helper.cpp:

(WebCore::X11Helper::createPixmap): Initialise handleId to 0.

3:50 PM Changeset in webkit [159771] by commit-queue@webkit.org

7 edits in trunk/Source/WebCore

Mark URLRegistry's lookup() as const and its child classes as final
https://bugs.webkit.org/show_bug.cgi?id=124865

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-25
Reviewed by Eric Carlson.

No new tests needed. No behavior changes.

Modules/mediasource/MediaSourceRegistry.cpp:

(WebCore::MediaSourceRegistry::lookup): marked as const.

Modules/mediasource/MediaSourceRegistry.h: MediaSourceRegistry

marked as final.

Modules/mediastream/MediaStreamRegistry.cpp:

(WebCore::MediaStreamRegistry::lookup): marked as const.

Modules/mediastream/MediaStreamRegistry.h: MediaStreamRegistry

marked as final.

fileapi/Blob.cpp:
html/URLRegistry.h: lookup() marked as const.

(WebCore::URLRegistry::lookup): marked as const.

3:50 PM Changeset in webkit [159770] by mitz@apple.com

9 edits in trunk/Source/WebKit2

[Cocoa] Remove some indirection that was only necessary for supporting the legacy Objective-C runtime
https://bugs.webkit.org/show_bug.cgi?id=123065

Reviewed by Sam Weinig.

UIProcess/API/mac/WKBrowsingContextController.h: Removed _data ivar and

WKBrowsingContextControllerData class declaration.

UIProcess/API/mac/WKBrowsingContextController.mm:

(-[WKBrowsingContextController dealloc]): Removed
WKBrowsingContextControllerData class and moved ivars directly into
WKBrowsingContextController, declaring them in the @implementation. Removed ivar and
accessors for the delegate properties, letting the compiler synthesize them.
(-[WKBrowsingContextController _pageRef]): Removed indirection via _data.
(-[WKBrowsingContextController loadRequest:userData:]): Removed indirection via -_pageRef.
(-[WKBrowsingContextController loadFileURL:restrictToFilesWithin:userData:]): Ditto.
(-[WKBrowsingContextController loadHTMLString:baseURL:userData:]): Ditto.
(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]): Ditto.
(-[WKBrowsingContextController stopLoading]): Ditto.
(-[WKBrowsingContextController reload]): Ditto.
(-[WKBrowsingContextController reloadFromOrigin]): Ditto.
(-[WKBrowsingContextController goForward]): Ditto.
(-[WKBrowsingContextController canGoForward]): Ditto.
(-[WKBrowsingContextController goBack]): Ditto.
(-[WKBrowsingContextController canGoBack]): Ditto.
(-[WKBrowsingContextController goToBackForwardListItem:]): Ditto.
(-[WKBrowsingContextController backForwardList]): Ditto.
(-[WKBrowsingContextController activeURL]): Ditto.
(-[WKBrowsingContextController provisionalURL]): Ditto.
(-[WKBrowsingContextController committedURL]): Ditto.
(-[WKBrowsingContextController unreachableURL]): Removed idirection via _data.
(-[WKBrowsingContextController estimatedProgress]): Removed indirection via -_pageRef.
(-[WKBrowsingContextController title]): Ditto.
(-[WKBrowsingContextController textZoom]): Ditto.
(-[WKBrowsingContextController setTextZoom:]): Ditto.
(-[WKBrowsingContextController pageZoom]): Ditto.
(-[WKBrowsingContextController setPageZoom:]): Ditto.
(-[WKBrowsingContextController setPaginationMode:]): Ditto.
(-[WKBrowsingContextController paginationMode]): Ditto.
(-[WKBrowsingContextController setPaginationBehavesLikeColumns:]): Ditto.
(-[WKBrowsingContextController paginationBehavesLikeColumns]): Ditto.
(-[WKBrowsingContextController setPageLength:]): Ditto.
(-[WKBrowsingContextController pageLength]): Ditto.
(-[WKBrowsingContextController setGapBetweenPages:]): Ditto.
(-[WKBrowsingContextController gapBetweenPages]): Ditto.
(-[WKBrowsingContextController pageCount]): Ditto.
(-[WKBrowsingContextController handle]): Ditto.
(-[WKBrowsingContextController _initWithPageRef:]): Removed indirection via _data.

UIProcess/API/mac/WKBrowsingContextGroup.h: Removed _data ivar and

WKBrowsingContextGroupData class declaration.

UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed WKBrowsingContextGroupData class and

moved _pageGroupRef ivar directly into WKBrowsingContextGroup, declaring it in the
@implementation.
(-[WKBrowsingContextGroup initWithIdentifier:]): Removed indirection via _data.
(-[WKBrowsingContextGroup allowsJavaScript]): Removed indirection via -_pageGroupRef.
(-[WKBrowsingContextGroup setAllowsJavaScript:]): Ditto.
(-[WKBrowsingContextGroup allowsJavaScriptMarkup]): Ditto.
(-[WKBrowsingContextGroup setAllowsJavaScriptMarkup:]): Ditto.
(-[WKBrowsingContextGroup allowsPlugIns]): Ditto.
(-[WKBrowsingContextGroup setAllowsPlugIns:]): Ditto.
(-[WKBrowsingContextGroup addUserStyleSheet:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:mainFrameOnly:]): Ditto.
(-[WKBrowsingContextGroup removeAllUserStyleSheets]): Ditto.
(-[WKBrowsingContextGroup addUserScript:baseURL:whitelistedURLPatterns:blacklistedURLPatterns:injectionTime:mainFrameOnly:]): Ditto.
(-[WKBrowsingContextGroup removeAllUserScripts]): Ditto.
(-[WKBrowsingContextGroup _pageGroupRef]): Removed indirection via _data.

UIProcess/API/mac/WKConnection.h: Removed _data ivar and WKConnectionData class declaration.
UIProcess/API/mac/WKConnection.mm: Removed WKConnectionData class and moved _connectionRef

ivar directly into WKConnection, declaring it in the @implementation. Removed ivar and
accessors for the delegate property, letting the compiler synthesize them.
(-[WKConnection dealloc]): Removed indirection via _data.
(-[WKConnection sendMessageWithName:body:]): Ditto.
(-[WKConnection remoteObjectRegistry]): Ditto.
(didReceiveMessage): Ditto.
(-[WKConnection _initWithConnectionRef:]): Ditto.

UIProcess/API/mac/WKProcessGroup.h: Replaced forward declaration of WKConnection with an

import. Removed _data ivar and WKProcessGroupData class declaration.

UIProcess/API/mac/WKProcessGroup.mm: Removed WKProcessGroupData class and moved

_contextRef ivar directly into WKProcessGroup, declaring it in the @implementation. Removed
ivar and accessors for the delegate property, letting the compiler synthesize them.
(-[WKProcessGroup initWithInjectedBundleURL:]): Removed indirection via _data.
(-[WKProcessGroup dealloc]): Ditto.
(-[WKProcessGroup _contextRef]): Ditto.
(-[WKProcessGroup _geolocationProvider]): Ditto.

3:21 PM Changeset in webkit [159769] by commit-queue@webkit.org

14 edits in trunk/Source/WebCore

[MediaStream] Use std::unique_ptr instead of OwnPtr/PassOwnPtr
https://bugs.webkit.org/show_bug.cgi?id=124858

Patch by Sergio Correia <Sergio Correia> on 2013-11-25
Reviewed by Eric Carlson.

Another step of the OwnPtr/PassOwnPtr => std::unique_ptr conversion,
now targeting mediastream-related code.

No new tests, covered by existing ones.

Modules/mediastream/RTCDTMFSender.cpp:
Modules/mediastream/RTCDTMFSender.h:
Modules/mediastream/RTCDataChannel.cpp:
Modules/mediastream/RTCDataChannel.h:
Modules/mediastream/RTCPeerConnection.cpp:
Modules/mediastream/RTCPeerConnection.h:
platform/mediastream/MediaStreamSource.cpp:
platform/mediastream/RTCPeerConnectionHandler.cpp:
platform/mediastream/RTCPeerConnectionHandler.h:
platform/mediastream/RTCPeerConnectionHandlerClient.h:
platform/mock/RTCNotifiersMock.cpp:
platform/mock/RTCPeerConnectionHandlerMock.cpp:
platform/mock/RTCPeerConnectionHandlerMock.h:

3:08 PM Changeset in webkit [159768] by commit-queue@webkit.org

5 edits
1 add in trunk/Source/WebKit

[Win] WebKit version in user agent string is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=124454

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-25
Reviewed by Brent Fulgham.

Source/WebKit:

Generate WebKitVersion.h file from mac's Version.xcconfig file.

WebKit.vcxproj/WebKit/WebKit.vcxproj:
WebKit.vcxproj/WebKit/WebKit.vcxproj.filters:
WebKit.vcxproj/WebKit/WebKitVersion.cmd: Added.

Source/WebKit/win:

WebView.cpp: Use WebKit version from WebKitVersion.h in user agent.

(webKitVersionString):

2:55 PM Changeset in webkit [159767] by commit-queue@webkit.org

4 edits in trunk/Source/WebCore

MediaStreamRegistry should store MediaStreams instead of MediaStreamPrivates
https://bugs.webkit.org/show_bug.cgi?id=124860

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-25
Reviewed by Eric Carlson.

MediaStreamRegistry::lookup() should return a MediaStream instead of MediaStreamPrivate.

No new tests needed. No behavior changes.

Modules/mediastream/MediaStreamRegistry.cpp:

(WebCore::MediaStreamRegistry::registerURL): m_privateStreams -> m_mediaStreams
(WebCore::MediaStreamRegistry::unregisterURL): Ditto.
(WebCore::MediaStreamRegistry::lookup): Override URLRegistry::lookup() instead of add a
new method MediaStream::lookupMediaStreamPrivate().

Modules/mediastream/MediaStreamRegistry.h:
html/HTMLMediaElement.cpp:

(HTMLMediaElement::loadResource): call lookup() instead of lookupMediaStreamPrivate()

2:08 PM Changeset in webkit [159766] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[WinCairo] Compile fails when GSTREAMER is not used.
https://bugs.webkit.org/show_bug.cgi?id=124853

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-11-25
Reviewed by Philippe Normand.

platform/graphics/gstreamer/GStreamerUtilities.cpp: Don't include GStreamerUtilities.h when GSTREAMER is not used.

2:02 PM Changeset in webkit [159765] by commit-queue@webkit.org

21 edits in trunk/Source/WebKit2

Unreviewed, rolling out r159740.
http://trac.webkit.org/changeset/159740
https://bugs.webkit.org/show_bug.cgi?id=124859

Crashing xmlhttprequest/access-control-repeated-failed-
preflight-crash.html on Mavericks and Mountain Lion -
ASSERT(m_pageGroup) WebPage.cpp:352 (Requested by dino_ on
#webkit).

Scripts/webkit2/messages.py:

(struct_or_class):

Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):

Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

Shared/WebPageCreationParameters.h:
Shared/mac/ObjCObjectGraphCoders.h:
Shared/mac/ObjCObjectGraphCoders.mm:

(WebKit::ObjCObjectGraphEncoder::baseEncode):
(WebKit::WebContextObjCObjectGraphEncoderImpl::WebContextObjCObjectGraphEncoderImpl):
(WebKit::WebContextObjCObjectGraphEncoderImpl::encode):
(WebKit::InjectedBundleObjCObjectGraphEncoderImpl::encode):
(WebKit::WebContextObjCObjectGraphEncoder::WebContextObjCObjectGraphEncoder):
(WebKit::WebContextObjCObjectGraphEncoder::encode):

UIProcess/WebConnectionToWebProcess.cpp:

(WebKit::WebConnectionToWebProcess::encodeMessageBody):

UIProcess/WebContext.cpp:

(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):
(WebKit::WebContext::postMessageToInjectedBundle):
(WebKit::WebContext::didReceiveSyncMessage):

UIProcess/WebContextUserMessageCoders.h:

(WebKit::WebContextUserMessageEncoder::WebContextUserMessageEncoder):
(WebKit::WebContextUserMessageEncoder::encode):
(WebKit::WebContextUserMessageDecoder::decode):

UIProcess/WebPageGroup.cpp:
UIProcess/WebPageGroup.h:

(WebKit::WebPageGroup::sendToAllProcessesInGroup):

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadAlternateHTMLString):
(WebKit::WebPageProxy::loadPlainTextString):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::postMessageToInjectedBundle):
(WebKit::WebPageProxy::initializeCreationParameters):

UIProcess/WebPageProxy.h:
UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::disconnect):
(WebKit::WebProcessProxy::createWebPage):

UIProcess/WebProcessProxy.h:
WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:

(WebKit::InjectedBundleUserMessageEncoder::encode):
(WebKit::InjectedBundleUserMessageDecoder::decode):

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::webPageGroup):

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

1:53 PM Changeset in webkit [159764] by akling@apple.com

3 edits in trunk/Source/WebCore

Deduplicate shortish Text node strings during tree construction.
<https://webkit.org/b/124855>

Let HTMLConstructionSite keep a hash set of already seen strings over
its lifetime. Use this to deduplicate the strings inside Text nodes
for any string up to 64 characters of length.

This optimization already sort-of existed for whitespace-only Texts,
but those are laundered in the AtomicString table which we definitely
don't want to pollute with every single Text. It might be a good idea
to stop using the AtomicString table for all-whitespace Text too.

3.82 MB progression on HTML5-8266 locally.

Reviewed by Anders Carlsson.

1:36 PM Changeset in webkit [159763] by dino@apple.com

2 edits in trunk/LayoutTests

RenderTableSection Blink merge asserting
https://bugs.webkit.org/show_bug.cgi?id=124857

Skipping these tests for now, since Ossy + Laszlo checked
in a lot of rebaselines and I didn't want to roll
everything out.

TestExpectations:

1:29 PM Changeset in webkit [159762] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Remove unnecessary MediaStreamTrackDescriptor forward declaration
https://bugs.webkit.org/show_bug.cgi?id=124854

Patch by Nick Diego Yamane <nick.yamane@openbossa.org> on 2013-11-25
Reviewed by Eric Carlson.

No new tests needed. No behavior changed.

Modules/mediastream/VideoStreamTrack.h:

12:53 PM Changeset in webkit [159761] by mitz@apple.com

1 edit in trunk/Source/WebKit2/ChangeLog

Fixed a typo in the change log.

12:52 PM Changeset in webkit [159760] by mitz@apple.com

52 edits in trunk

[Cocoa] Put most of the Cocoa API behind WK_API_ENABLED guards
https://bugs.webkit.org/show_bug.cgi?id=124850

Reviewed by Brady Eidson.

Source/WebKit2:

Guarded all Cocoa API headers and implementatiosn with WK_API_ENABLED. Left the WKView class
unguarded, but limited its API.

Shared/API/Cocoa/WKFoundation.h: Replaced OBJ_VISIBLE with an explicit attribute.
Shared/API/Cocoa/WKRemoteObjectCoder.mm: Moved #if WK_API_ENABLED before the rest of the

imports.

Shared/API/Cocoa/WKRemoteObjectInterface.mm: Ditto.
Shared/API/Cocoa/WKRemoteObjectRegistry.mm: Ditto.
Shared/API/Cocoa/WKRemoteObjectRegistryPrivate.h: Ditto.
UIProcess/API/mac/WKBrowsingContextController.h: Guarded all declarations with

WK_API_ENABLED, changed to use WK_API_CLASS instead of WK_EXPORT.

UIProcess/API/mac/WKBrowsingContextController.mm: Guarded everything with WK_API_ENABLED.

(-[WKBrowsingContextController dealloc]):
(-[WKBrowsingContextController setPolicyDelegate:]):
(-[WKBrowsingContextController backForwardList]):
(didChangeBackForwardList):
(setUpPageLoaderClient):
(setUpPagePolicyClient):
(-[WKBrowsingContextController _initWithPageRef:]):

UIProcess/API/mac/WKBrowsingContextControllerInternal.h: Ditto.
UIProcess/API/mac/WKBrowsingContextControllerPrivate.h: Ditto.
UIProcess/API/mac/WKBrowsingContextGroup.h: Guarded all declarations with WK_API_ENABLED,

chanegd to use WK_API_CLASS instead of WK_EXPORT.

UIProcess/API/mac/WKBrowsingContextGroup.mm: Removed redundant import, guarded everything

with WK_API_ENABLED.

UIProcess/API/mac/WKBrowsingContextGroupPrivate.h: Guarded with WK_API_ENABLED.
UIProcess/API/mac/WKBrowsingContextPolicyDelegate.h: Added necessary import.
UIProcess/API/mac/WKConnection.h: Guarded all declarations with WK_API_ENABLED, chanegd to

use WK_API_CLASS instead of WK_EXPORT.

UIProcess/API/mac/WKConnection.mm: Guarded everything with WK_API_ENABLED.

(-[WKConnection remoteObjectRegistry]):
(didReceiveMessage):

UIProcess/API/mac/WKConnectionInternal.h: Guarded the delcarations with WK_API_ENABLED.
UIProcess/API/mac/WKProcessGroup.h: Ditto. Also changed to use WK_API_CLASS instead of

WK_EXPORT.

UIProcess/API/mac/WKProcessGroup.mm: Guarded everything with WK_API_ENABLED.

(-[WKProcessGroup initWithInjectedBundleURL:]):

UIProcess/API/mac/WKProcessGroupPrivate.h: Guarded the declarations with WK_API_ENABLED.
UIProcess/API/mac/WKTypeRefWrapper.h: Moved #if WK_API_ENABLED before the rest of the

imports, changed to use WK_API_CLASS instead of WK_EXPORT.

UIProcess/API/mac/WKTypeRefWrapper.mm: Removed empty line after #import "config.h".
UIProcess/API/mac/WKView.h: Added #if WK_API_ENABLED around API that uses other Cocoa API

types.

UIProcess/API/mac/WKView.mm: Added #if WK_API_ENABLED around implementations of methods

that are only declared when the API is enabled.

UIProcess/API/mac/WKViewInternal.h: Reordered imports.
UIProcess/mac/WKFullScreenWindowController.mm: Added comment to #endif.
UIProcess/mac/WebContextMac.mm:

(WebKit::WebContext::platformInitializeWebProcess): Guarded use of
WKBrowsingContextController with WK_API_ENABLED.
(WebKit::WebContext::platformInitializeNetworkProcess): Ditto.

UIProcess/mac/WebContextMenuProxyMac.mm: Removed newline between imports.
WebProcess/InjectedBundle/API/mac/WKDOMDocument.h: Moved #if WK_API_ENABLED before the