Timeline



Jan 14, 2014:

11:56 PM Changeset in webkit [162057] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] UI process crashes when closing the window right after printing with javascript
https://bugs.webkit.org/show_bug.cgi?id=126981

Reviewed by Gustavo Noronha Silva.

The UI process crashes because when the page is closed, the web
view is destroyed before the print operation has actually
finished. Use a weak pointer to make sure the web view pointer is
set to NULL when the it's destroyed and emit the finished callback
always so that the user can clean up the operation even when the
web view has been closed.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(drawPagesForPrintingCompleted):

11:47 PM Changeset in webkit [162056] by Carlos Garcia Campos
  • 6 edits in trunk

[GTK] UI process crashes when the web process crashes while printing
https://bugs.webkit.org/show_bug.cgi?id=126977

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

When the web process crashes, the printing callback is
invalidated, so the function is called with a NULL error.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(drawPagesForPrintingCompleted): Check wkError is not NULL before
trying to use it.

  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewPrintFrame): Set the print mode of the operation
before emitting the print signal.

Tools:

Add new test case to check that closing the window right after
printing works. It's skipped for now, because this patch only
fixes the UI process crash, but not the web process one.

  • Scripts/run-gtk-tests:

(TestRunner): Skip
/webkit2/WebKitPrintOperation/close-after-print.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:

(testPrintOperationPrintPrinter):
(findPrintToFilePrinter):
(testPrintOperationPrint):
(testPrintOperationErrors):
(testPrintOperationCloseAfterPrint):
(beforeAll):

11:41 PM Changeset in webkit [162055] by ChangSeok Oh
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r161980.

CachedResourcesLoader.h should not belong to the CSS_SHADERS flag since it is used
out of the flag so it causes a compile failure when svg and css shaders are concurrently disabled.

  • css/StyleResolver.cpp:
11:18 PM Changeset in webkit [162054] by ap@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Crash when multiple WebView instances have different PrivateBrowsing settings
https://bugs.webkit.org/show_bug.cgi?id=127019

Reviewed by Sam Weinig.

  • WebView/WebView.mm: (-[WebView _preferencesChanged:]): Don't delete a private

browsing session simply because one preferences object doesn't use private browsing.
There could be others that do.

  • WebView/WebPreferences.mm: Track how many WebPreferences objects use private

browsing, and only delete the private session when there are none any more.

11:00 PM Changeset in webkit [162053] by Simon Fraser
  • 3 edits in trunk/Source/WebKit/mac

Fix the iOS build after r162034.

  • WebCoreSupport/WebProgressTrackerClient.mm:
  • WebView/WebView.mm:

(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):

10:51 PM Changeset in webkit [162052] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Pack ResourceResponse harder.
<https://webkit.org/b/127005>

Re-arrange the members of ResourceResponse to reduce padding,
shrinking it by 8 bytes.

This nudges CachedResource and CachedImage into smaller size
classes, yielding a ~700 kB progression on Membuster3.

Reviewed by Anders Carlsson.

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::ResourceResponseBase):

  • platform/network/ResourceResponseBase.h:
  • platform/network/cf/ResourceResponse.h:

(WebCore::ResourceResponse::ResourceResponse):

10:50 PM Changeset in webkit [162051] by krit@webkit.org
  • 23 edits
    2 deletes in trunk

Remove unnecessary WebkitCSSSVGDocumentValue
https://bugs.webkit.org/show_bug.cgi?id=126997

Reviewed by Andreas Kling.

Source/WebCore:

Removing redundant code path. WebkitCSSSVGDocumentValue
can be expressed by a CSSPrimitiveValue.

No new tests.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.order:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseFilter):

  • css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

  • css/CSSValue.h:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::createFilterOperations):

  • css/StyleResolver.h:
  • css/WebKitCSSSVGDocumentValue.cpp: Removed.
  • css/WebKitCSSSVGDocumentValue.h: Removed.
  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::valueForFilter):

  • css/WebKitCSSFilterValue.cpp:

(WebCore::WebKitCSSFilterValue::customCSSText):

LayoutTests:

Update results after use of CSSPrimitiveValue.

  • css3/filters/filter-property-computed-style-expected.txt:
  • css3/filters/filter-property-expected.txt:
  • css3/filters/filter-property-parsing-expected.txt:
  • css3/filters/script-tests/filter-property-computed-style.js:
  • css3/filters/script-tests/filter-property-parsing.js:
  • css3/filters/script-tests/filter-property.js:
  • fast/filter-image/parse-filter-image-expected.txt:
  • fast/filter-image/parse-filter-image.html:
10:43 PM Changeset in webkit [162050] by mihnea@adobe.com
  • 5 edits
    4 adds in trunk

[CSSRegions] Incorrect repaint of fixed element with transformed parent
https://bugs.webkit.org/show_bug.cgi?id=125756

Reviewed by Simon Fraser.

Source/WebCore:

When collecting the layers for fixed positioned elements with named flow
as a containing block, use layers collection at named flow layer level
instead of relying on the positioned elements collection.

With this approach, there are situations with nested named flows laid out in
auto-height regions and thus assuming 2 step layouts, in which is enough to lay
out the inner named flow once instead of twice with a performance gain.
In such situations, the layers lists for the inner named flow are not yet updated
when collectFixedPositionedLayers is called to paint the fixed positioned layers.
Therefore I called updateLayerListsIfNeeded for all named flows layers, via the flow thread controller, before inspecting the named flow layers to avoid hitting the assertions when
accessing the named flows layers lists.

Tests: fast/regions/repaint/fixed-in-named-flow-cb-changed.html

fast/regions/repaint/fixed-in-named-flow-cb-changed2.html

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::updateNamedFlowsLayerListsIfNeeded):
(WebCore::FlowThreadController::collectFixedPositionedLayers):

  • rendering/FlowThreadController.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintFixedLayersInNamedFlows):

LayoutTests:

Add tests for a fixed positioned element with a parent that:

  1. dynamically gets a transform, in which case the fixed positioned element should be positioned

relative to its parent

  1. dynamically loses its transform, in which case the fixed positioned element should be positioned

relative to the view.

  • fast/regions/repaint/fixed-in-named-flow-cb-changed-expected.html: Added.
  • fast/regions/repaint/fixed-in-named-flow-cb-changed.html: Added.
  • fast/regions/repaint/fixed-in-named-flow-cb-changed2-expected.html: Added.
  • fast/regions/repaint/fixed-in-named-flow-cb-changed2.html: Added.
10:36 PM Changeset in webkit [162049] by Brent Fulgham
  • 4 edits in trunk

Unreviewed test fix.

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateCompressedTexDimensions): Emit
error state expected by Khronos test suite.

LayoutTests:

  • fast/canvas/webgl/webgl-compressed-texture-size-limit.html: Use same

failure mode as the khronos test suite.

10:34 PM Changeset in webkit [162048] by mrowe@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Stop cmp from spewing useless info during postprocess-headers.sh.

  • postprocess-headers.sh: Pass -s to silence cmp since we only care about the

exit status.

10:31 PM Changeset in webkit [162047] by beidson@apple.com
  • 20 edits
    4 copies in trunk/Source

IDB: create object store support
<rdar://problem/15779639> and https://bugs.webkit.org/show_bug.cgi?id=127011

Reviewed by Anders Carlsson.

Source/WebCore:

Split the 3 objects declared in IDBDatabaseMetadata into their own header files:

  • Modules/indexeddb/IDBDatabaseMetadata.h:
  • Modules/indexeddb/IDBIndexMetadata.h:

(WebCore::IDBIndexMetadata::IDBIndexMetadata):

  • Modules/indexeddb/IDBObjectStoreMetadata.h:

(WebCore::IDBObjectStoreMetadata::IDBObjectStoreMetadata):

Add cross thread copying for IDBDatabaseMetadata:

  • platform/CrossThreadCopier.cpp:

(WebCore::IDBIndexMetadata>::copy):
(WebCore::IDBObjectStoreMetadata>::copy):

  • platform/CrossThreadCopier.h:
  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

Add messaging/callback infrastructure for creating object stores:

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::createObjectStore):

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:
  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::createObjectStore):
(WebKit::WebIDBServerConnection::didCreateObjectStore):

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:
  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::didChangeDatabaseVersion):
(WebKit::UniqueIDBDatabase::didCreateObjectStore):
(WebKit::UniqueIDBDatabase::didCompleteBoolRequest):
(WebKit::UniqueIDBDatabase::createObjectStore):
(WebKit::UniqueIDBDatabase::createObjectStoreInBackingStore):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
  • DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:

Add serialization helpers to save/restore an IDBKeyPath to/from disk:

  • DatabaseProcess/IndexedDB/IDBSerialization.cpp:

(WebKit::serializeIDBKeyPath):
(WebKit::deserializeIDBKeyPath):

  • DatabaseProcess/IndexedDB/IDBSerialization.h:

Add object store metadata to the schema, and save/restore the metadata:

  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createAndPopulateInitialMetadata):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::extractExistingMetadata):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createObjectStore):

  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
  • Scripts/webkit2/messages.py:

(struct_or_class):

  • WebKit2.xcodeproj/project.pbxproj:
10:21 PM Changeset in webkit [162046] by fpizlo@apple.com
  • 6 edits
    5 adds in branches/jsCStack/Source/JavaScriptCore

FTL slow path calls in inline caches should be down with exceptions
https://bugs.webkit.org/show_bug.cgi?id=127020

Not yet reviewed.

This just adds the relatively straight-forward glue code for emitting an exception
check on FTL IC slow paths and then jumping to the exception handling path.

Note that half of the attached tests failed before this change, often in very
funny ways, since the FTL IC slow paths previously just ignored exceptions. The
other half of the tests were some combination of accidental passes (because if you
ignore the exception but someone else along some path checks it then it will be
thrown and things will seem OK) and inadequate FTL coverage (so they would have
failed if the FTL supported GetByIdFlush for example).

Also updated some copyright notices that I previously forgot about.

  • ftl/FTLCompile.cpp:

(JSC::FTL::fixFunctionBasedOnStackMaps):

  • ftl/FTLJITFinalizer.cpp:
  • ftl/FTLSlowPathCall.cpp:

(JSC::FTL::storeCodeOrigin):
(JSC::FTL::callOperation):

  • ftl/FTLSlowPathCall.h:
  • ftl/FTLState.h:
  • tests/stress/get-by-id-throw-from-getter-through-optimized-code.js: Added.

(foo):
(makeWithGetter.return):
(makeWithGetter):

  • tests/stress/get-by-id-throw-from-unexpected-getter-through-optimized-code-that-does-not-exit.js: Added.

(foo):
(makeWithGetter.return):
(makeWithGetter):

  • tests/stress/get-by-id-throw-from-unexpected-getter-through-optimized-code.js: Added.

(foo):
(makeWithGetter.return):
(makeWithGetter):

  • tests/stress/ic-throw-through-optimized-code.js: Added.

(foo):

  • tests/stress/put-by-id-throw-through-optimized-code.js: Added.

(foo):

10:10 PM Changeset in webkit [162045] by mitz@apple.com
  • 2 edits in trunk

Only use color in make output when it’s going to a terminal.

Reviewed by Mark Rowe.

  • Makefile.shared:
9:43 PM Changeset in webkit [162044] by jae.park@company100.net
  • 2 edits in trunk/Source/WebKit2

[GTK] Unreviewed build fix after r162034

  • GNUmakefile.list.am:
8:26 PM Changeset in webkit [162043] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[iOS] Crash in NavigatorBase::vendor loading apple.com
https://bugs.webkit.org/show_bug.cgi?id=127028

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-14
Reviewed by Daniel Bates.

Source/WebCore:

Export function pointers to be filled in with WebKitSystemInterface functions.

  • WebCore.exp.in:

Source/WebKit/mac:

Fill in iOS WebKitSystemInterface functions.

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

8:22 PM Changeset in webkit [162042] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix for CMake based ports after r162034.

  • CMakeLists.txt:
7:56 PM Changeset in webkit [162041] by jpfau@apple.com
  • 4 edits in trunk/Source

Build fix after r162034

Rubber-stamped by Benjamin Poulain.

Source/WebCore:

  • WebCore.exp.in:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebProgressTrackerClient.cpp:
7:39 PM Changeset in webkit [162040] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

Merged some subpixel skipped tests. Unreviewed.

webkit.org/b/126893 is a duplicate of webkit.org/b/126892

  • platform/mac/TestExpectations:
7:08 PM Changeset in webkit [162039] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Web Inspector: Resource finish time is sometimes earlier than response received time.

https://bugs.webkit.org/show_bug.cgi?id=127027

Reviewed by Joseph Pecoraro.

  • inspector/InspectorResourceAgent.cpp:

(WebCore::InspectorResourceAgent::didFinishLoading): Use currentTime() and not the
passed in finishTime.

7:04 PM Changeset in webkit [162038] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Follow up build fix attempt.

  • WebCore.exp.in:
6:59 PM Changeset in webkit [162037] by Lucas Forschler
  • 1 copy in tags/Safari-538.12

New Tag.

6:58 PM Changeset in webkit [162036] by roger_fong@apple.com
  • 6 edits in trunk/Source/WebCore

Add support for handling WebGL load policies.
https://bugs.webkit.org/show_bug.cgi?id=126935
<rdar://problem/15790448>.

Reviewed by Brent Fulgham.

  • WebCore.xcodeproj/project.pbxproj: Copy over HTMLCanvasElement.h to the private headers directory.
  • html/HTMLCanvasElement.cpp: Show the policy dialog and retrieve policies as necessary.

(WebCore::HTMLCanvasElement::getContext): Make sure that WebGL is allowed on the site.

If it isn't, be sure to notify the frame loader client that
the site is trying to create a WebGL context.

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::webGLPolicyForHost): Used to get the WebGL load policy for a site.

  • loader/FrameLoaderTypes.h:
  • page/ChromeClient.h:

(WebCore::ChromeClient::webGLContextCreated): Called when a site is creating a WebGL context.

6:57 PM Changeset in webkit [162035] by fpizlo@apple.com
  • 7 edits
    3 adds in branches/jsCStack/Source/JavaScriptCore

FTL should be cool with runtime functions throwing exceptions
https://bugs.webkit.org/show_bug.cgi?id=127018

Reviewed by Geoffrey Garen.

This just adds the appropriate exception throwing off-ramp to the FTL. There's no
way to express that off-ramp in LLVM IR, so we just use a stackmap that we fill
with a jump to our own off-ramp. It's easy!

The throw-through-optimized-code test already worked because the architecture of
the FTL allows our existing unwinding to "just work". The
runtime-throw-through-optimized-code test used to crash but now works. The
empty-function test currently covers the case where there won't be any exception
handlers, though that will cease to be the case once we have real stack checks.
But even then the test will be useful - an overly optimizable function leads to
many otherwise-needed stackmaps not being emitted, so this will always test some
fun corner cases in FTL::fixFunctionBasedOnStackMaps().

  • assembler/LinkBuffer.h:

(JSC::LinkBuffer::entrypoint):

  • ftl/FTLCompile.cpp:

(JSC::FTL::fixFunctionBasedOnStackMaps):

  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeFunction):

  • ftl/FTLJITFinalizer.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::callCheck):

  • ftl/FTLState.h:
  • tests/stress/empty-function.js: Added.

(foo):

  • tests/stress/runtime-throw-through-optimized-code.js: Added.

(foo):
(bar):

  • tests/stress/throw-through-optimized-code.js: Added.

(foo):
(bar):

6:43 PM Changeset in webkit [162034] by andersca@apple.com
  • 14 edits
    3 copies
    1 add in trunk/Source

Create separate progress tracker clients
https://bugs.webkit.org/show_bug.cgi?id=127025

Reviewed by Sam Weinig.

Source/WebCore:

  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::~ProgressTracker):

  • loader/ProgressTrackerClient.h:

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebCoreSupport/WebProgressTrackerClient.h: Copied from Source/WebCore/loader/ProgressTrackerClient.h.
  • WebCoreSupport/WebProgressTrackerClient.mm: Added.

(WebProgressTrackerClient::WebProgressTrackerClient):
(WebProgressTrackerClient::progressTrackerDestroyed):
(WebProgressTrackerClient::willChangeEstimatedProgress):
(WebProgressTrackerClient::didChangeEstimatedProgress):
(WebProgressTrackerClient::progressStarted):
(WebProgressTrackerClient::progressEstimateChanged):
(WebProgressTrackerClient::progressFinished):

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):

Source/WebKit2:

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebCoreSupport/WebProgressTrackerClient.cpp: Copied from Source/WebCore/loader/ProgressTrackerClient.h.

(WebKit::WebProgressTrackerClient::WebProgressTrackerClient):
(WebKit::WebProgressTrackerClient::progressTrackerDestroyed):
(WebKit::WebProgressTrackerClient::progressStarted):
(WebKit::WebProgressTrackerClient::progressEstimateChanged):
(WebKit::WebProgressTrackerClient::progressFinished):

  • WebProcess/WebCoreSupport/WebProgressTrackerClient.h: Copied from Source/WebCore/loader/ProgressTrackerClient.h.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

6:26 PM Changeset in webkit [162033] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

And yet another build fix.

  • wtf/SizeLimits.cpp:
6:21 PM Changeset in webkit [162032] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Another build fix.

  • wtf/SizeLimits.cpp:
6:03 PM Changeset in webkit [162031] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

[WebGL] WebGLRenderingContext::validateCompressedTexDimensions improperly calculates values
https://bugs.webkit.org/show_bug.cgi?id=126926

Reviewed by Dean Jackson.

Test coverage in fast/canvas/webgl/webgl-compressed-texture-size-limit.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::compressedTexImage2D): Pass target to
validation function.
(WebCore::WebGLRenderingContext::validateCompressedTexDimensions): Revise
calculation to also confirm size is in bounds.
(WebCore::WebGLRenderingContext::validateCompressedTexSubDimensions): Pass

target to validation function.

  • html/canvas/WebGLRenderingContext.h: Modify signature.
5:58 PM Changeset in webkit [162030] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

On iOS, we never want to make scrollbar layers
https://bugs.webkit.org/show_bug.cgi?id=127024
<rdar://problem/15745768>

Reviewed by Dean Jackson.

On platforms that delegate scrolling, don't try to make layers
for scrollbars.

This fixes a crash in RenderLayerCompositor::updateOverflowControlsLayers()
where m_overflowControlsHostLayer is null.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::shouldCompositeOverflowControls):

5:39 PM Changeset in webkit [162029] by dino@apple.com
  • 4 edits in trunk/Source/WebKit

Correct grave mistake in updating the pbxproj file rather than xcconfig.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • Configurations/WebKit.xcconfig:
5:35 PM Changeset in webkit [162028] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

[WK2] Make WebPageProxy's setUserAgent private
https://bugs.webkit.org/show_bug.cgi?id=127013

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-14
Reviewed by Anders Carlsson.

  • UIProcess/WebPageProxy.h:

The API to modify the user agent already has 3 "setters":
-standardUserAgent
-setApplicationNameForUserAgent
-setCustomUserAgent

The method WebPageProxy::setUserAgent() is supposed to be internal, not used directly.
Using it directly would cause unexpected behaviors, for example:
-Set the user agent with setUserAgent.
-Set CustomUserAgent.
-Reset CustomUserAgent.
->The user agent is now standardUserAgent instead of the user agent defined initially.

4:52 PM Changeset in webkit [162027] by Simon Fraser
  • 6 edits in trunk/Source

Source/WebCore: Avoid PLATFORM() macros in exported headers.

  • platform/ios/WebEvent.h:

Source/WebKit/ios: Avoid PLATFORM() macros in exported headers.

  • WebView/WebPDFViewPlaceholder.h:

Source/WebKit/mac: #define ENABLE_DASHBOARD_SUPPORT for iOS.

  • WebView/WebViewPrivate.h:
4:46 PM Changeset in webkit [162026] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

[iOS] Build fix for 32-bit simulator and device

CGFloat is defined to be float, double for 32-bit, and 64-bit devices respectively.
Because WebCore::createCGColorWithDeviceWhite() takes CGFloat arguments we need to
list both the float and double-variants of this symbol in WebCore.exp.in. Currently
we only list the version whose arguments are of type double.

  • WebCore.exp.in:
4:28 PM Changeset in webkit [162025] by dino@apple.com
  • 2 edits in trunk/Source/WebKit

Attempt to fix 32-bit Mac build.

  • WebKit.xcodeproj/project.pbxproj:
4:17 PM Changeset in webkit [162024] by Simon Fraser
  • 9 edits in trunk/Source

Source/WebCore: Clean up exports and headers for iOS.

Don't use ENABLE() macro in an exported header.

  • platform/ios/wak/WAKResponder.h:

Source/WebKit/ios: Clean up exports and headers for iOS.

  • Misc/WebNSStringDrawing.h: Don't use PLATFORM() macro in an exported header.
  • WebCoreSupport/WebFrameIOS.h: Ditto.
  • WebCoreSupport/WebSelectionRect.h: Ditto.

Source/WebKit/mac: Clean up exports and headers for iOS.

Need to export WebArchivePboardType on Mac and iOS.

  • WebKit.exp:
  • WebKit.mac.exp:
4:13 PM Changeset in webkit [162023] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

[iOS] Move symbol ZN7WebCore34registerQLPreviewConverterIfNeededEP5NSURLP8NSStringP6NSData to
section USE(QUICK_LOOK)

  • WebCore.exp.in:
4:07 PM Changeset in webkit [162022] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Clean up DNSResolveQueue
https://bugs.webkit.org/show_bug.cgi?id=127007

Reviewed by Geoffrey Garen.

Move the shared() getter out of line and make it use NeverDestroyed.
Add a Timer member variable instead of inheriting from TimerBase.
Use std::atomic<int> for the m_requestsInFlight member variable.

  • platform/network/DNSResolveQueue.cpp:

(WebCore::DNSResolveQueue::shared):
(WebCore::DNSResolveQueue::DNSResolveQueue):
(WebCore::DNSResolveQueue::add):
(WebCore::DNSResolveQueue::timerFired):

  • platform/network/DNSResolveQueue.h:

(WebCore::DNSResolveQueue::decrementRequestCount):

4:00 PM Changeset in webkit [162021] by Simon Fraser
  • 2 edits in trunk/Source/WebKit/mac

Fix header availability checks on iOS
https://bugs.webkit.org/show_bug.cgi?id=127016

Reviewed by Andy Estes.

Make DOMTouch* and DOMGesture* headers public headers on iOS,
and fix MigrateHeaders.make to skip availability checks when
building for iOS.

  • MigrateHeaders.make:
4:00 PM Changeset in webkit [162020] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Two more exports for iOS.

  • WebCore.exp.in:
3:22 PM Changeset in webkit [162019] by Simon Fraser
  • 2 edits in trunk/Source/WebKit/mac

Need to #import <WebCore/QuickLook.h>.

  • WebView/WebDataSource.mm:
3:05 PM Changeset in webkit [162018] by dbates@webkit.org
  • 2 edits in trunk/Source/WTF

[iOS] Enable WTF_USE_UIKIT_EDITING

  • wtf/Platform.h:
3:03 PM Changeset in webkit [162017] by mhahnenberg@apple.com
  • 13 edits in trunk/Source/JavaScriptCore

Copying should be generational
https://bugs.webkit.org/show_bug.cgi?id=126555

Reviewed by Geoffrey Garen.

This patch adds support for copying to our generational collector. Eden collections
always trigger copying. Full collections use our normal fragmentation-based heuristics.

The way this works is that the CopiedSpace now has the notion of an old generation set of CopiedBlocks
and a new generation of CopiedBlocks. During each mutator cycle new CopiedSpace allocations reside
in the new generation. When a collection occurs, those blocks are moved to the old generation.

One key thing to remember is that both new and old generation objects in the MarkedSpace can
refer to old or new generation allocations in CopiedSpace. This is why we must fire write barriers
when assigning to an old (MarkedSpace) object's Butterfly.

  • heap/CopiedAllocator.h:

(JSC::CopiedAllocator::tryAllocateDuringCopying):

  • heap/CopiedBlock.h:

(JSC::CopiedBlock::CopiedBlock):
(JSC::CopiedBlock::didEvacuateBytes):
(JSC::CopiedBlock::isOld):
(JSC::CopiedBlock::didPromote):

  • heap/CopiedBlockInlines.h:

(JSC::CopiedBlock::reportLiveBytes):
(JSC::CopiedBlock::reportLiveBytesDuringCopying):

  • heap/CopiedSpace.cpp:

(JSC::CopiedSpace::CopiedSpace):
(JSC::CopiedSpace::~CopiedSpace):
(JSC::CopiedSpace::init):
(JSC::CopiedSpace::tryAllocateOversize):
(JSC::CopiedSpace::tryReallocateOversize):
(JSC::CopiedSpace::doneFillingBlock):
(JSC::CopiedSpace::didStartFullCollection):
(JSC::CopiedSpace::doneCopying):
(JSC::CopiedSpace::size):
(JSC::CopiedSpace::capacity):
(JSC::CopiedSpace::isPagedOut):

  • heap/CopiedSpace.h:

(JSC::CopiedSpace::CopiedGeneration::CopiedGeneration):

  • heap/CopiedSpaceInlines.h:

(JSC::CopiedSpace::contains):
(JSC::CopiedSpace::recycleEvacuatedBlock):
(JSC::CopiedSpace::allocateBlock):
(JSC::CopiedSpace::startedCopying):

  • heap/CopyVisitor.cpp:

(JSC::CopyVisitor::copyFromShared):

  • heap/CopyVisitorInlines.h:

(JSC::CopyVisitor::allocateNewSpace):
(JSC::CopyVisitor::allocateNewSpaceSlow):

  • heap/GCThreadSharedData.cpp:

(JSC::GCThreadSharedData::didStartCopying):

  • heap/Heap.cpp:

(JSC::Heap::copyBackingStores):

  • heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::copyLater):

  • heap/TinyBloomFilter.h:

(JSC::TinyBloomFilter::add):

3:01 PM Changeset in webkit [162016] by dbates@webkit.org
  • 4 edits in trunk/Source

[iOS] Enable QuickLook
https://bugs.webkit.org/show_bug.cgi?id=126954

Reviewed by David Kilzer.

Source/WebKit/mac:

Remove empty implementation for quickLookContentForURL: since we always enable QuickLook on iOS.

  • WebView/WebView.mm:

(-[WebView quickLookContentForURL:]):

Source/WTF:

  • wtf/Platform.h:
2:56 PM Changeset in webkit [162015] by dino@apple.com
  • 5 edits in trunk/Source/WebKit

Source/WebKit/ios: Remove .objc_class_name_WebInspectorXPCWrapper from export on iOS build.

  • WebKit.iOS.exp:

Source/WebKit/mac: Move some Mac-only exports to WebKit.mac.exp for iOS build.

  • WebKit.exp:
  • WebKit.mac.exp:
2:55 PM Changeset in webkit [162014] by ggaren@apple.com
  • 1 edit in branches/jsCStack/Source/JavaScriptCore/ChangeLog

Updated review status on some bugs

2:44 PM Changeset in webkit [162013] by Simon Fraser
  • 3 edits in trunk/Source/WebKit/mac

Move some Mac-only exports to WebKit.mac.exp for iOS build.

  • WebKit.exp:
  • WebKit.mac.exp:
2:38 PM Changeset in webkit [162012] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

One more buildfix after r161999.

  • Modules/webaudio/MediaStreamAudioSource.h:
2:34 PM Changeset in webkit [162011] by Simon Fraser
  • 7 edits in trunk/Source

Source/WebCore: Export ZN7WebCore11FileChooser16chooseMediaFilesERKN3WTF6VectorINS1_6StringELm0ENS1_15CrashOnOverflowEEERKS3_PNS_4IconE
to fix WK1 iOS linking.

  • WebCore.exp.in:

Source/WebKit/ios: Fix WK1 iOS build: need implementations of these functions in WebInspectorClientIOS.

  • WebCoreSupport/WebInspectorClientIOS.mm:

(WebInspectorClient::indicate):
(WebInspectorClient::hideIndication):

Source/WebKit/mac: Fix iOS WK1 linking.

  • Configurations/WebKit.xcconfig: We do need WebOpenPanelResultListener

on iOS.

  • WebCoreSupport/WebOpenPanelResultListener.mm: Need <WebCore/Icon.h>
2:33 PM Changeset in webkit [162010] by Brent Fulgham
  • 2 edits in trunk/Tools

[WIN] Set MSBuild environment variable to avoid long-lived processes locking log files
https://bugs.webkit.org/show_bug.cgi?id=127002

Reviewed by David Kilzer.

  • Scripts/webkitdirs.pm:

(setupAppleWinEnv): Export MSBUILDDISABLENODEREUSE=1 to the environment.

2:20 PM Changeset in webkit [162009] by Simon Fraser
  • 4 edits in trunk/Source

Source/WebCore: iOS build fixing: export required by iOS WebKit1.

  • WebCore.exp.in:

Source/WebKit/mac: iOS build fixing: link WebKit against Security.framework on iOS.

  • Configurations/WebKit.xcconfig:
2:18 PM Changeset in webkit [162008] by dino@apple.com
  • 4 edits
    1 add in trunk/Source/WebKit

[WK1] Allow generated export files on iOS
https://bugs.webkit.org/show_bug.cgi?id=127008

Reviewed by Simon Fraser.

Source/WebKit:

Modify the export file generation rule to read from
a shared and platform-specific input file.

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Add a new Mac-only symbol file.

  • WebKit.exp: To begin, move the WebIcon* into the Mac-specific exports.
  • WebKit.mac.exp: Added. New file holds Mac-only symbols.
2:13 PM Changeset in webkit [162007] by commit-queue@webkit.org
  • 27 edits in trunk

Unreviewed, rolling out r162000.
http://trac.webkit.org/changeset/162000
https://bugs.webkit.org/show_bug.cgi?id=127009

API versioning is wrong (Requested by rfong on #webkit).

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):

  • loader/FrameLoaderClient.h:
  • loader/FrameLoaderTypes.h:
  • page/ChromeClient.h:

Source/WebKit2:

  • UIProcess/API/C/WKAPICast.h:
  • UIProcess/API/C/WKPageLoaderClient.h:
  • UIProcess/API/C/WKPageUIClient.h:
  • UIProcess/WebLoaderClient.cpp:
  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:
  • UIProcess/WebUIClient.h:
  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:
  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:

Tools:

  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):

2:11 PM Changeset in webkit [162006] by mark.lam@apple.com
  • 3 edits
    3 adds in trunk

ASSERTION FAILED: !hasError() in JSC::Parser<LexerType>::createSavePoint().
https://bugs.webkit.org/show_bug.cgi?id=126990.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseConstDeclarationList):

  • We were missing an error check after attempting to parse an initializer expression. This is now fixed.

LayoutTests:

  • js/dom/parse-syntax-error-in-initializer-expected.txt: Added.
  • js/dom/parse-syntax-error-in-initializer.html: Added.
  • js/resources/parse-syntax-error-in-initializer.js: Added.
  • Added bug test case as a regression test.
2:10 PM Changeset in webkit [162005] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Speculative buildfix after r161999.

  • Shared/APIObject.h:
1:53 PM Changeset in webkit [162004] by Lucas Forschler
  • 5 edits in branches/safari-537.60-branch/Source

Versioning.

1:50 PM Changeset in webkit [162003] by Lucas Forschler
  • 1 copy in tags/Safari-537.60.13

New Tag.

1:46 PM Changeset in webkit [162002] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Skip some tests that now fail after r162000.
https://bugs.webkit.org/show_bug.cgi?id=127000.

  • platform/mac/TestExpectations:
1:42 PM Changeset in webkit [162001] by betravis@adobe.com
  • 5 edits in trunk/Source/WebCore

[CSS Shapes] Move CSSPrimitiveValue <-> LayoutBox Conversion to CSSPrimitiveValueMappings
https://bugs.webkit.org/show_bug.cgi?id=126719

Reviewed by Dirk Schulze.

The standard location for conversions to/from CSSPrimitiveValues is CSSPrimitiveValueMappings.
This patch moves the conversion for LayoutBoxes from BasicShapeFunctions to
CSSPrimitiveValueMappings.h.

Refactoring, no new tests.

  • css/BasicShapeFunctions.cpp:

(WebCore::valueForBasicShape):
(WebCore::basicShapeForValue):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LayoutBox):

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):

1:41 PM Changeset in webkit [162000] by roger_fong@apple.com
  • 27 edits in trunk

Add support for handling WebGL load policies.
https://bugs.webkit.org/show_bug.cgi?id=126935
<rdar://problem/15790448>.

Reviewed by Brent Fulgham.

  • WebCore.xcodeproj/project.pbxproj: Copy over HTMLCanvasElement.h to the private headers directory.
  • html/HTMLCanvasElement.cpp: Show the policy dialog and retrieve policies as necessary.

(WebCore::HTMLCanvasElement::getContext): Make sure that WebGL is allowed on the site.

If it isn't, be sure to notify the frame loader client that
the site is trying to create a WebGL context.

Boiler plate code for sending messages to and from the UI and Web Process.

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::webGLPolicyForHost): Used to get the WebGL load policy for a site.

  • loader/FrameLoaderTypes.h:
  • page/ChromeClient.h:

(WebCore::ChromeClient::webGLContextCreated): Called when a site is creating a WebGL context.

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toWebGLLoadPolicy):

  • UIProcess/API/C/WKPageLoaderClient.h:
  • UIProcess/API/C/WKPageUIClient.h:
  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::webGLLoadPolicy):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::webGLContextCreated):
(WebKit::WebPageProxy::webGLPolicyForHost):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/WebUIClient.cpp:

(WebKit::WebUIClient::webGLContextCreated):

  • UIProcess/WebUIClient.h:
  • UIProcess/mac/WebInspectorProxyMac.mm:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::webGLContextCreated):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::webGLPolicyForHost):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/WebPage.cpp: A sendSync is used here to get the webGLPolicyForHost message sent between the Web and UI process.

In the future this will be replaced with a strategy is non-blocking.

(WebKit::WebPage::getWebGLPolicyForHost):

  • WebProcess/WebPage/WebPage.h:
  • MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController awakeFromNib]):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::createWebViewWithOptions):

1:38 PM Changeset in webkit [161999] by andersca@apple.com
  • 9 edits
    1 delete in trunk/Source

Get rid of ThreadRestrictionVerifier
https://bugs.webkit.org/show_bug.cgi?id=127004

Reviewed by Sam Weinig.

Source/WebCore:

Remove now unneeded calls.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::defaultIcon):
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::getOrCreateIconRecord):
(WebCore::IconDatabase::readFromDatabase):

Source/WTF:

The ThreadRestrictionVerifier mechanism has been turned off for a while
since it doesn't really have a good solution for objects that are passed between threads.
Instead of having dead code in the tree, just get rid of it.

  • GNUmakefile.list.am:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/RefCounted.h:

(WTF::RefCountedBase::ref):
(WTF::RefCountedBase::hasOneRef):
(WTF::RefCountedBase::refCount):
(WTF::RefCountedBase::derefBase):

  • wtf/ThreadRestrictionVerifier.h: Removed.
1:19 PM Changeset in webkit [161998] by mrowe@apple.com
  • 3 edits in trunk/Source/WebKit2

WebKit2 leaks sudden termination assertions when a page with unload handlers is closed.
<https://webkit.org/b/126974> / <rdar://problem/15812954>

When a page with an unload handler is loaded, the web process tells the UI process that it
should disable sudden termination. However, when the page is closed the connection between
the web and UI process is torn down before the web content has a chance to tell the UI
process to reenable sudden termination.

Reviewed by Anders Carlsson.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::~WebProcessProxy): Balance any outstanding disableSuddenTermination calls.
(WebKit::WebProcessProxy::enableSuddenTermination): Decrement the count.
(WebKit::WebProcessProxy::disableSuddenTermination): Increment the count.

  • UIProcess/WebProcessProxy.h:
12:59 PM Changeset in webkit [161997] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

[iOS] Directly allocate NSMutableDictionary in QLPreviewConverterDictionary() and QLContentDictionary()
https://bugs.webkit.org/show_bug.cgi?id=126999
<rdar://problem/15810305>

Reviewed by Joseph Pecoraro.

Fixes an issue where we may crash when subsequently accessing WebCore::QLPreviewConverterDictionary()
or WebCore::QLContentDictionary(). Currently neither of these functions retain'ed the NSMutable dictionary
returned by [NSMutableDictionary dictionary]. Instead, we should allocate and initialize NSMutableDictionary
directly to ensure that the dictionary is retained.

  • platform/network/ios/QuickLook.mm:

(QLPreviewConverterDictionary):
(QLContentDictionary):

12:52 PM Changeset in webkit [161996] by Brent Fulgham
  • 4 edits
    2 adds in trunk

Source/WebCore: [WebGL] Invalid range checking in WebGLRenderingContext::validateTexFuncLevel
https://bugs.webkit.org/show_bug.cgi?id=126925

Reviewed by Dean Jackson.

Added fast/canvas/webgl/webgl-compressed-texture-size-limit.html.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateTexFuncLevel): Avoid off-by-one error

LayoutTests: [WebGL] Invalid range checking in WebGLRenderContext::validateTexFunctionLevel
https://bugs.webkit.org/show_bug.cgi?id=126925

Reviewed by Dean Jackson.

  • fast/canvas/webgl/resources/webgl-test-utils.js:

(WebGLTestUtils): Add missing 'waitForComposite' implementatino.

  • fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Added.
  • fast/canvas/webgl/webgl-compressed-texture-size-limit.html: Added.
12:28 PM Changeset in webkit [161995] by mrowe@apple.com
  • 4 edits in trunk/Source/WebCore

WebCore icon database appears to leak sudden termination assertions
<https://webkit.org/b/126971> / <rdar://problem/15808797>

Introduce an RAII wrapper around disableSuddenTermination / enableSuddenTermination
and adopt it in IconDatabase to address the incorrect management of sudden termination.

IconDatabase now owns up to two SuddenTerminationDisabler objects. One ensures that
sudden termination is disabled while we're waiting on the sync timer to fire. The second
ensures that sudden termination is disabled while we're waiting on the sync thread to
process any pending work.

Reviewed by Alexey Proskuryakov.

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::wakeSyncThread): Disable sudden termination until the sync thread
has finished this unit of work.
(WebCore::IconDatabase::scheduleOrDeferSyncTimer): Disable sudden termination until the
sync timer has fired.
(WebCore::IconDatabase::syncTimerFired): Clear the member variable to reenable sudden termination.
(WebCore::IconDatabase::syncThreadMainLoop): Taken ownership of the SuddenTerminationDisabler
instance when we start processing a unit of work. Discard the object when our work is complete.

  • loader/icon/IconDatabase.h:
  • platform/SuddenTermination.h:

(WebCore::SuddenTerminationDisabler::SuddenTerminationDisabler): Disable sudden termination when created.
(WebCore::SuddenTerminationDisabler::~SuddenTerminationDisabler): Enable it when destroyed.

12:23 PM Changeset in webkit [161994] by commit-queue@webkit.org
  • 12 edits in trunk/Source

Web Inspector: For Remote Inspection link WebProcess's to their parent UIProcess
https://bugs.webkit.org/show_bug.cgi?id=126995

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-14
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::listingForDebuggable):
For each WebView, list the parent process. Listing the parent per WebView
is already supported back when we supported processes that could host WebViews
for multiple applications.

  • inspector/remote/RemoteInspectorConstants.h:

Add a separate key for the bundle identifier, separate from application identifier.

  • inspector/remote/RemoteInspectorDebuggable.cpp:

(Inspector::RemoteInspectorDebuggable::info):

  • inspector/remote/RemoteInspectorDebuggable.h:

(Inspector::RemoteInspectorDebuggableInfo::RemoteInspectorDebuggableInfo):
(Inspector::RemoteInspectorDebuggableInfo::hasParentProcess):
If a RemoteInspectorDebuggable has a non-zero parent process identifier
it is a proxy for the parent process.

Source/WebCore:

  • inspector/InspectorClient.h:

(WebCore::InspectorClient::parentProcessIdentifier):
Client method intended for WebKit2 so a WebProcess can link to its UIProcess.

  • page/PageDebuggable.h:
  • page/PageDebuggable.cpp:

(WebCore::PageDebuggable::parentProcessIdentifier):
Provide parent process identifier if there is one.

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebInspectorClient.h:
  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::parentProcessIdentifier):
WebProcesses are proxies for a parent UIProcess.

12:17 PM Changeset in webkit [161993] by benjamin@webkit.org
  • 2 edits in trunk/Source/WTF

Enable the experimental selector code generator by default
https://bugs.webkit.org/show_bug.cgi?id=126953

Reviewed by Gavin Barraclough.

  • wtf/Platform.h:

Enable CSS_SELECTOR_JIT on OS X x86_64 by default.
The feature is not ready to ship but it is stable enough to enable
for the bots and nightly.

12:14 PM Changeset in webkit [161992] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

iOS WebKit2 build fixes, part 3

  • WebKit2.xcodeproj/project.pbxproj:

Remove some files from the 'All' target that should never have been a part of it.

12:07 PM Changeset in webkit [161991] by timothy_horton@apple.com
  • 4 edits in trunk/Source

iOS WebKit2 build fixes, part 2

  • WebKit2.xcodeproj/project.pbxproj:

Add some missing files.

  • WebCore.exp.in:

Export some more symbols.

11:50 AM Changeset in webkit [161990] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[GTK] Skip FontConfig initialization in WebKitTestRunner if requested
https://bugs.webkit.org/show_bug.cgi?id=120110

Reviewed by Martin Robinson.

Skip the FontConfig settings initialization in WebKitTestRunner if the
WEBKIT_SKIP_WEBKITTESTRUNNER_FONTCONFIG_INITIALIZATION environment variable is set.
This is useful when profiling the WebKitTestRunner execution, where at the startup
this step takes considerable amount of time and disturbs the profiling output.

  • WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:

(WTR::initializeFontConfigSetting):

11:41 AM Changeset in webkit [161989] by Brent Fulgham
  • 12 edits
    2 copies in branches/safari-537.60-branch

Merge r154470

2013-08-22 Simon Fraser <Simon Fraser>

compositing/geometry/bounds-ignores-hidden-dynamic.html has incorrect initial rendering
https://bugs.webkit.org/show_bug.cgi?id=119825

Source/WebCore:

Reviewed by Tim Horton.


r137526 and some earlier commits attempted to avoid unconditionally
repainting layers when their size changes, because this was causing
TiledBacking layers to repaint when the document size changed.


However, the approach required that we have good information about
whether size changes require a repaint, which in some cases is hard
to determine, especially when RenderLayer changes affect our
decisions about which layers are composited.


Fix by pushing the decision about whether to repaint on size change
into GraphicsLayer. The default is to repaint on size change,
but GraphicsLayer provides a function that can be overridden to
modify this behavior; GraphicsLayerCA does so to avoid repaints
when layers with TiledBackings get resized.

Test: compositing/repaint/repaint-on-layer-grouping-change.html

  • WebCore.exp.in: WebKit2 needs GraphicsLayer::setSize, which is no longer inline.
  • platform/graphics/GraphicsLayer.cpp: (WebCore::GraphicsLayer::setOffsetFromRenderer): (WebCore::GraphicsLayer::setSize):
  • platform/graphics/GraphicsLayer.h: (WebCore::GraphicsLayer::shouldRepaintOnSizeChange):
  • platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::shouldRepaintOnSizeChange):
  • platform/graphics/ca/GraphicsLayerCA.h:
  • rendering/RenderLayerBacking.h: No longer need m_boundsConstrainedByClipping
  • rendering/RenderLayerBacking.cpp: (WebCore::RenderLayerBacking::RenderLayerBacking): (WebCore::RenderLayerBacking::updateCompositedBounds): (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): setSize takes care of repainting for us now, so we can remove all the conditional code.

LayoutTests:

Reviewed by Tim Horton.


Test that dumps repaint rects on layers after visibility changes affect
the layer hierarchy.

  • compositing/repaint/repaint-on-layer-grouping-change-expected.txt: Added.
  • compositing/repaint/repaint-on-layer-grouping-change.html: Added.
  • compositing/repaint/resize-repaint-expected.txt: Update result.
11:21 AM Changeset in webkit [161988] by commit-queue@webkit.org
  • 12 edits in trunk

Add ENABLE(WEB_REPLAY) feature flag to the build system
https://bugs.webkit.org/show_bug.cgi?id=126949

Patch by Brian J. Burg <Brian Burg> on 2014-01-14
Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h: for now, disable the flag by default.

Tools:

  • Scripts/webkitperl/FeatureList.pm:
11:19 AM Changeset in webkit [161987] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Crash in WebCore::MediaSourcePrivateAVFObjC::hasAudio const + 13
https://bugs.webkit.org/show_bug.cgi?id=126768

Reviewed by Eric Carlson.

Null-check m_mediaSourcePrivate before calling.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::hasVideo):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::hasAudio):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):

11:13 AM Changeset in webkit [161986] by commit-queue@webkit.org
  • 5 edits in trunk/Tools

REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte.
https://bugs.webkit.org/show_bug.cgi?id=126702

Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-01-14
Reviewed by Alexey Proskuryakov.

Resolve regression and remove a FIXME comment that is already fixed.

  • Scripts/webkitpy/common/system/filesystem.py:

(FileSystem.open_text_file_for_reading):

  • Scripts/webkitpy/common/system/filesystem_unittest.py:

(RealFileSystemTest.test_read_and_write_file):

  • Scripts/webkitpy/style/filereader.py:

(TextFileReader._read_lines):

  • Scripts/webkitpy/style/filereader_unittest.py:

(TextFileReaderTest.test_count_delete_only_file):
(TextFileReaderTest):
(TextFileReaderTest.test_process_malformed_file):

10:59 AM Changeset in webkit [161985] by timothy_horton@apple.com
  • 1 edit
    1 move in trunk/Source/WebKit2

Move WKView.mm to WKViewIOS.mm as 161950 was supposed to do.

  • UIProcess/API/ios/WKView.mm: Removed.
  • UIProcess/API/ios/WKViewIOS.mm: Copied from UIProcess/API/ios/WKView.mm.
10:59 AM Changeset in webkit [161984] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[GStreamer] Playback rate is not set when pipeline is not ready.
https://bugs.webkit.org/show_bug.cgi?id=126692

Patch by Piotr Grad <p.grad@samsung.com> on 2014-01-14
Reviewed by Philippe Normand.

No new tests. Covered by existing tests.

Added new method updatePlaybackRate which is called when playback rate change is possible.
Added m_lastPlaybackRate in order to retrieve last correct playback rate and notify upper
layers about that setting playback rate failed.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::updatePlaybackRate):
(WebCore::MediaPlayerPrivateGStreamer::setRate):
(WebCore::MediaPlayerPrivateGStreamer::updateStates):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
10:42 AM Changeset in webkit [161983] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[Win] Application name in user agent string is truncated.
https://bugs.webkit.org/show_bug.cgi?id=126810

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-01-14
Reviewed by Anders Carlsson.

  • wtf/text/StringConcatenate.h:

(WTF::tryMakeString): Add missing 8 bit check for last argument.

10:39 AM Changeset in webkit [161982] by commit-queue@webkit.org
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r161978.
http://trac.webkit.org/changeset/161978
https://bugs.webkit.org/show_bug.cgi?id=126992

Test case causes crash on some hardware (Requested by bfulgham
on #webkit).

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateTexFuncLevel):

LayoutTests:

  • fast/canvas/webgl/resources/webgl-test-utils.js:

(WebGLTestUtils):

  • fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Removed.
  • fast/canvas/webgl/webgl-compressed-texture-size-limit.html: Removed.
10:19 AM Changeset in webkit [161981] by commit-queue@webkit.org
  • 6 edits
    4 deletes in trunk

Unreviewed, rolling out r161964 and r161965.
http://trac.webkit.org/changeset/161964
http://trac.webkit.org/changeset/161965
https://bugs.webkit.org/show_bug.cgi?id=126988

Tests do not pass on the bots because of slight color
differences. The tests should be redone with squared results
and blending that leads to stable colors. (Requested by krit_
on #webkit).

Source/WebCore:

  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::draw):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawPatternForContainer):

  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageForContainer.cpp:

(WebCore::SVGImageForContainer::drawPattern):

LayoutTests:

  • css3/compositing/background-blend-mode-crossfade-image-expected.html: Removed.
  • css3/compositing/background-blend-mode-crossfade-image.html: Removed.
  • css3/compositing/background-blend-mode-data-uri-svg-image-expected.html: Removed.
  • css3/compositing/background-blend-mode-data-uri-svg-image.html: Removed.
10:16 AM Changeset in webkit [161980] by hmuller@adobe.com
  • 11 edits
    4 adds in trunk

[CSS Shapes] Shape images are now <image> types, not just URIs
https://bugs.webkit.org/show_bug.cgi?id=125224

Reviewed by Andreas Kling.

Source/WebCore:

Added support for image-set valued shapes. Added an optional ResourceLoaderOptions
parameter to CSSImageSetValue::cachedImageSet() to enable CORS-enabled fetch of
image-set images. This change is based on a similar patch for ordinary shape image values:
https://bugs.webkit.org/show_bug.cgi?id=123114.

Tests: fast/shapes/shape-inside/shape-inside-image-set.html

fast/shapes/shape-outside-floats/shape-outside-image-set.html

  • css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::cachedImageSet):

  • css/CSSImageSetValue.h:
  • css/CSSParser.cpp:

(WebCore::CSSParser::parseShapeProperty):

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyShape::applyValue):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingShapeImage):

  • css/StyleResolver.h:
  • rendering/shapes/Shape.cpp:

(WebCore::Shape::createShape):

LayoutTests:

  • fast/shapes/shape-inside/shape-inside-image-set-expected.html: Added.
  • fast/shapes/shape-inside/shape-inside-image-set.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-image-set-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-image-set.html: Added.
10:09 AM Changeset in webkit [161979] by Chris Fleizach
  • 19 edits in trunk/Source/WebCore

AX: Modernize AccessibilityChildrenVector loops
https://bugs.webkit.org/show_bug.cgi?id=126915

Reviewed by Anders Carlsson.

Change appropriate for loops to use the new style.
Use auto where appropriate.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::focusedImageMapUIElement):

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addRowDescendant):

  • accessibility/AccessibilityARIAGridCell.cpp:

(WebCore::AccessibilityARIAGridCell::rowIndexRange):

  • accessibility/AccessibilityARIAGridRow.cpp:

(WebCore::AccessibilityARIAGridRow::disclosedRows):
(WebCore::AccessibilityARIAGridRow::disclosedByRow):
(WebCore::AccessibilityARIAGridRow::parentTable):
(WebCore::AccessibilityARIAGridRow::headerObject):

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::addChildren):
(WebCore::AccessibilityListBox::setSelectedChildren):
(WebCore::AccessibilityListBox::selectedChildren):

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::listBoxOptionIndex):

  • accessibility/AccessibilityMenuList.cpp:

(WebCore::AccessibilityMenuList::didUpdateActiveOption):

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::addChildren):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::insertChild):
(WebCore::AccessibilityNodeObject::selectedRadioButton):
(WebCore::AccessibilityNodeObject::selectedTabItem):
(WebCore::AccessibilityNodeObject::ariaLabeledByText):

  • accessibility/AccessibilityObject.cpp:

(WebCore::appendChildrenToArray):
(WebCore::AccessibilityObject::clearChildren):
(WebCore::AccessibilityObject::ariaTreeRows):
(WebCore::AccessibilityObject::ariaTreeItemContent):
(WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::ariaFlowToElements):
(WebCore::AccessibilityRenderObject::isTabItemSelected):
(WebCore::AccessibilityRenderObject::setSelectedRows):
(WebCore::AccessibilityRenderObject::ariaOwnsElements):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
(WebCore::AccessibilityRenderObject::addRemoteSVGChildren):
(WebCore::AccessibilityRenderObject::updateAttachmentViewParents):
(WebCore::AccessibilityRenderObject::addHiddenChildren):
(WebCore::AccessibilityRenderObject::ariaSelectedRows):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityRenderObject::ariaListboxVisibleChildren):
(WebCore::AccessibilityRenderObject::tabChildren):
(WebCore::AccessibilityRenderObject::mathRadicandObject):
(WebCore::AccessibilityRenderObject::mathRootIndexObject):
(WebCore::AccessibilityRenderObject::mathNumeratorObject):
(WebCore::AccessibilityRenderObject::mathDenominatorObject):
(WebCore::AccessibilityRenderObject::mathUnderObject):
(WebCore::AccessibilityRenderObject::mathOverObject):
(WebCore::AccessibilityRenderObject::mathBaseObject):
(WebCore::AccessibilityRenderObject::mathSubscriptObject):
(WebCore::AccessibilityRenderObject::mathSuperscriptObject):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::columnHeaders):
(WebCore::AccessibilityTable::rowHeaders):
(WebCore::AccessibilityTable::visibleRows):
(WebCore::AccessibilityTable::cells):
(WebCore::AccessibilityTable::cellForColumnAndRow):

  • accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::headerObject):

  • accessibility/AccessibilityTableHeaderContainer.cpp:

(WebCore::AccessibilityTableHeaderContainer::addChildren):

  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::headerObject):

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):
(-[WebAccessibilityObjectWrapper indexOfAccessibilityElement:]):
(-[WebAccessibilityObjectWrapper containsUnnaturallySegmentedChildren]):

  • accessibility/mac/WebAccessibilityObjectWrapperBase.mm:

(convertMathPairsToNSArray):
(-[WebAccessibilityObjectWrapperBase accessibilityTitle]):
(-[WebAccessibilityObjectWrapperBase accessibilityDescription]):
(-[WebAccessibilityObjectWrapperBase accessibilityHelpText]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(convertToNSArray):
(convertStringsToNSArray):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityIndexOfChild:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):

9:53 AM Changeset in webkit [161978] by Brent Fulgham
  • 4 edits
    2 adds in trunk

Source/WebCore: [WebGL] Invalid range checking in WebGLRenderingContext::validateTexFuncLevel
https://bugs.webkit.org/show_bug.cgi?id=126925

Reviewed by Dean Jackson.

Added fast/canvas/webgl/webgl-compressed-texture-size-limit.html.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateTexFuncLevel): Avoid off-by-one error

LayoutTests: [WebGL] Invalid range checking in WebGLRenderContext::validateTexFunctionLevel
https://bugs.webkit.org/show_bug.cgi?id=126925

Reviewed by Dean Jackson.

  • fast/canvas/webgl/resources/webgl-test-utils.js:

(WebGLTestUtils): Add missing 'waitForComposite' implementatino.

  • fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Added.
  • fast/canvas/webgl/webgl-compressed-texture-size-limit.html: Added.
9:41 AM Changeset in webkit [161977] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

Unreviewed Mac TestExpectations update.

<https://webkit.org/b/126890> is duplicate of <https://webkit.org/b/126889>

  • platform/mac/TestExpectations: Mark it as such.
9:30 AM Changeset in webkit [161976] by Carlos Garcia Campos
  • 8 edits in trunk/Source/WebKit2

[GTK] Test /webkit2/WebKitWebContext/languages crashes with network process enabled
https://bugs.webkit.org/show_bug.cgi?id=126130

Reviewed by Anders Carlsson.

We need to notify the network process when the user preferred
languages have changed to update the SoupSession accordingly.

  • NetworkProcess/NetworkProcess.h: Add

userPreferredLanguagesChanged when using soup network backend.

  • NetworkProcess/NetworkProcess.messages.in: Add

UserPreferredLanguagesChanged message when using soup network
backend.

  • NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::userPreferredLanguagesChanged): Update
the SoupSession to use the given languages.
(WebKit::NetworkProcess::platformInitializeNetworkProcess): Call
userPreferredLanguagesChanged() when initialization parameters
contain languages.
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
Remove unnedded WebCore prefix.
(WebKit::NetworkProcess::clearCacheForAllOrigins): Simplify using
a single line.

  • Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode): Encode the
languages vector.
(WebKit::NetworkProcessCreationParameters::decode): Decode the
languages vector.

  • Shared/Network/NetworkProcessCreationParameters.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::languageChanged): Send a message also to the
network process.

  • UIProcess/soup/WebContextSoup.cpp:

(WebKit::WebContext::platformInitializeNetworkProcess): Set
languages initial parameter.

9:16 AM Changeset in webkit [161975] by mark.lam@apple.com
  • 2 edits in branches/jsCStack/Source/JavaScriptCore

Fix 64-bit C Loop LLINT for !ENABLE(COMPUTED_GOTO_OPCODES).
https://bugs.webkit.org/show_bug.cgi?id=126959.

Reviewed by Michael Saboff.

  • llint/LowLevelInterpreter.asm:
  • The LLINT sanitizeStackForVM() is not needed by the C loop, and will cause a build failure in the non-computed goto C loop build. This is now fixed by excluding the LLINT sanitizeStackForVM() from the C loop build.
9:02 AM Changeset in webkit [161974] by Carlos Garcia Campos
  • 5 edits in trunk/Source

[SOUP] SoupNetworkSession::setAcceptLanguages should receive a const reference
https://bugs.webkit.org/show_bug.cgi?id=126966

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

We don't really need to modify the Vector just to ignore the C
locale.

  • platform/network/soup/SoupNetworkSession.cpp:

(WebCore::buildAcceptLanguages): Rework it to not modify the
passed vector to ignore the C locale when it's present.
(WebCore::SoupNetworkSession::setAcceptLanguages): Use const Vector<String>&.

  • platform/network/soup/SoupNetworkSession.h:

Source/WebKit2:

  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::setSoupSessionAcceptLanguage): Use const Vector<String>&.

8:41 AM Changeset in webkit [161973] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

HTMLMediaElement::potentiallyPlaying can be more simple.
https://bugs.webkit.org/show_bug.cgi?id=111

Patch by Piotr Grad <p.grad@samsung.com> on 2014-01-14
Reviewed by Eric Carlson.

Tests: No new tests, just refactorings.

Expression is simplified because the first 'if' statement depends on the same condition
as pausedToBuffer value.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

8:29 AM Changeset in webkit [161972] by Lucas Forschler
  • 2 edits
    1 copy in tags/Safari-538.11.1/Source/JavaScriptCore

Merged r161574. <rdar://problem/15762689>

8:29 AM Changeset in webkit [161971] by akling@apple.com
  • 5 edits in trunk/Source

Remove deprecated DeferrableOneShotTimer constructor.
<https://webkit.org/b/126984>

Source/WebCore:

Remove the deprecated constructor for callback functions that take
the timer by pointer instead of by reference.

This shrinks DeferrableOneShotTimer by 8 bytes.

Reviewed by Anders Carlsson.

  • platform/Timer.h:

(WebCore::DeferrableOneShotTimer::DeferrableOneShotTimer):

Source/WebKit2:

Reviewed by Anders Carlsson.

  • WebProcess/Plugins/PluginView.h:
  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::pluginSnapshotTimerFired):

Take the timer by reference so we can use the new constructor.

8:21 AM Changeset in webkit [161970] by Lucas Forschler
  • 4 edits
    2 copies in tags/Safari-538.11.1

Merged r161404. <rdar://problem/15398575>

8:03 AM Changeset in webkit [161969] by Lucas Forschler
  • 5 edits in tags/Safari-538.11.1/Source

Versioning.

8:00 AM Changeset in webkit [161968] by Lucas Forschler
  • 1 copy in tags/Safari-538.11.1

New Tag.

7:58 AM Changeset in webkit [161967] by krit@webkit.org
  • 7 edits in trunk/Source/WebCore

Make CachedSVGDocument independent of CSS Filters
https://bugs.webkit.org/show_bug.cgi?id=126133

Reviewed by Antti Koivisto.

Clean-up the pendingSVGDocuments code in StyleResolver.
CachedSVGDocumentReference is responsible for requesting the
SVG document instead of WebKitCSSSVGDocumentValue.
CachedSVGDocumentReference can be used by other SVG resource like
clip-path and mask now so that these may load external resources
as well.
WebKitCSSSVGDocumentValue does not provide any further value
and will be removed in the next patch.

Refactoring, no new test cases.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::createFilterOperations):

  • css/StyleResolver.h: Replace Map with a Set.

(WebCore::StyleResolver::State::pendingSVGDocuments): Use the Set from now on.

  • loader/cache/CachedSVGDocumentReference.cpp:

(WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::load):

  • loader/cache/CachedSVGDocumentReference.h: Is responsible for

requesting the SVG document.

(WebCore::CachedSVGDocumentReference::create):
(WebCore::CachedSVGDocumentReference::loadRequested):

  • platform/graphics/filters/FilterOperation.cpp:

(WebCore::ReferenceFilterOperation::createCachedSVGDocumentReference):

  • platform/graphics/filters/FilterOperation.h:
7:45 AM Changeset in webkit [161966] by mario.prada@samsung.com
  • 4 edits in trunk

[ATK] AXChildrenChanged notification handling is a performance black hole
https://bugs.webkit.org/show_bug.cgi?id=126970

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Remove code that is causing a huge performance problem when
loading big pages, just to be able to emit the children-changed:add
signal at the exact time a child is added.

This removal does not imply that the signal won't be ever emitted,
just that it will be emitted a bit later (when the new child is
asynchronously added to the tree), which should be good enough
anyway for Accessible Technologies, without impacting perfformance
in such a negative way.

  • accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::postPlatformNotification): Removed
extremely expensive referring loop when AXChildrenChanged is received.

LayoutTests:

Because of the removal of the referring test when
AXChildrenChanged is received, the children-changed:add signal is
now emitted later, so we need to reorder the expectations.

  • accessibility/children-changed-sends-notification-expected.txt: Updated.
7:41 AM Changeset in webkit [161965] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Source/WebCore: [CSS Background Blending] Background layer with -webkit-cross-fade doesn't blend
when having -webkit-background-blending applied. Turns out the problem was
the blending parameter not being passed to WebCore::CrossfadeGeneratedImage::draw

https://bugs.webkit.org/show_bug.cgi?id=126887

Patch by Mihai Tica <mitica@adobe.com> on 2014-01-14
Reviewed by Dirk Schulze.

Test: css3/compositing/background-blend-mode-crossfade-image.html

  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::draw): set blendMode on context.

LayoutTests: [CSS Background Blending] Background layer with -webkit-cross-fade doesn't blend
when having -webkit-background-blending applied.

https://bugs.webkit.org/show_bug.cgi?id=126887
Patch by Mihai Tica <mitica@adobe.com> on 2014-01-14
Reviewed by Dirk Schulze.

  • css3/compositing/background-blend-mode-crossfade-image-expected.html: Added.
  • css3/compositing/background-blend-mode-crossfade-image.html: Added.
7:38 AM Changeset in webkit [161964] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Source/WebCore: Background-blend-mode doesn't work for an element with an
SVG image as background and border-style or padding set.
The problem consisted in the drawing path using the default
blending parameter at all times.
https://bugs.webkit.org/show_bug.cgi?id=118894

Patch by Mihai Tica <mitica@adobe.com> on 2014-01-14
Reviewed by Dirk Schulze.

Test: css3/compositing/background-blend-mode-data-uri-svg-image.html

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawPatternForContainer): Pass blendMode to Image::drawPattern.

  • svg/graphics/SVGImage.h: Add a blendMode parameter to drawPatternForContainer.
  • svg/graphics/SVGImageForContainer.cpp:

(WebCore::SVGImageForContainer::drawPattern): Pass blendMode to drawPatternForContainer call.

LayoutTests: Background-blend-mode doesn't work for an element with an
SVG image as background and border-style or padding set.
https://bugs.webkit.org/show_bug.cgi?id=118894

Patch by Mihai Tica <mitica@adobe.com> on 2014-01-14
Reviewed by Dirk Schulze.

  • css3/compositing/background-blend-mode-data-uri-svg-image-expected.html: Added.
  • css3/compositing/background-blend-mode-data-uri-svg-image.html: Added.
7:35 AM Changeset in webkit [161963] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove accidentally added PLATFORM(QT) from Source/WebCore/editing/EditorCommand.cpp after r161638
https://bugs.webkit.org/show_bug.cgi?id=126980

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-14
Reviewed by Andreas Kling.

  • editing/EditorCommand.cpp:

(WebCore::createCommandMap):

7:20 AM Changeset in webkit [161962] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[EFL] FTL buildfix, add missing includes
https://bugs.webkit.org/show_bug.cgi?id=126641

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-14
Reviewed by Csaba Osztrogonác.

  • ftl/FTLOSREntry.cpp:
  • ftl/FTLOSRExitCompiler.cpp:
7:13 AM Changeset in webkit [161961] by mihnea@adobe.com
  • 1 edit
    2 adds in trunk/LayoutTests

[CSSRegions] Test dynamic change of position for fixed element in named flow
https://bugs.webkit.org/show_bug.cgi?id=126807

Reviewed by Dirk Schulze.

  • fast/regions/fixed-in-named-flow-position-changed-expected.html: Added.
  • fast/regions/fixed-in-named-flow-position-changed.html: Added.
6:51 AM Changeset in webkit [161960] by mihnea@adobe.com
  • 3 edits in trunk/Source/WebCore

[CSSRegions] The list of fixed positioned layers in named flows should be sorted by z-index
https://bugs.webkit.org/show_bug.cgi?id=126978

Reviewed by Antti Koivisto.

Return the list of fixed positioned layers sorted by z-index from
FlowThreadController::collectFixedPositionedLayers instead of manually sort it
every time we need it (RenderLayer::paintFixedLayersInNamedFlows, RenderLayer::hitTestFixedLayersInNamedFlows).
Refactoring covered by existing regions tests.

  • rendering/FlowThreadController.cpp:

(WebCore::compareZIndex):
(WebCore::FlowThreadController::collectFixedPositionedLayers):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintFixedLayersInNamedFlows):
(WebCore::RenderLayer::hitTestFixedLayersInNamedFlows):

6:20 AM Changeset in webkit [161959] by Manuel Rego Casasnovas
  • 2 edits
    9 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Added missing baselines for some regions tests.

  • platform/gtk/TestExpectations: Unskip tests as new baselines have been added.
  • platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
  • platform/gtk/fast/regions/region-dynamic-after-before-expected.txt: Added.
  • platform/gtk/fast/regions/region-generated-content-before-after-expected.txt: Added.
  • platform/gtk/fast/regions/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
  • platform/gtk/fast/regions/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
  • platform/gtk/fast/regions/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added.
  • platform/gtk/fast/regions/repaint/region-painting-invalidation-expected.txt: Added.
  • platform/gtk/fast/regions/repaint/region-painting-via-layout-expected.txt: Added.
  • platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Added.
5:26 AM Changeset in webkit [161958] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Pack ResourceLoaderOptions harder.
<https://webkit.org/b/126972>

Make all ResourceLoaderOptions members bitfields to reduce padding,
shrinking it from 28 to 4 bytes.

Reviewed by Antti Koivisto.

  • loader/ResourceLoaderOptions.h:
5:14 AM Changeset in webkit [161957] by Manuel Rego Casasnovas
  • 1 edit
    5 adds in trunk/LayoutTests

Unreviewed GTK gardening.

Added missing baselines for some regions tests.

  • platform/gtk/fast/regions/auto-size/autoheight-regions-mark-expected.txt: Added.
  • platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
  • platform/gtk/fast/regions/flows-dependency-same-flow-expected.txt: Added.
  • platform/gtk/fast/regions/iframe-html-collected-expected.txt: Added.
3:51 AM Changeset in webkit [161956] by brian.holt@samsung.com
  • 2 edits
    2 adds in trunk/Tools

[GTK] Parse Valgrind xml leak files
https://bugs.webkit.org/show_bug.cgi?id=119446

Reviewed by Alejandro G. Castro.

Parse the xml files generated by Valgrind to yield useful
information about the memory leaks.

  • Scripts/webkitpy/port/gtk.py:

(GtkPort.init):
(GtkPort.setup_test_run): Clear the previous output files before new
run.
(GtkPort.print_leaks_summary):

  • Scripts/webkitpy/port/leakdetector_valgrind.py: Added.

Parse the xml files generated by Valgrind and summarise leaks
into an easily understandable list.
(get_text_of):
(get_CDATA_of):
(gather_frames):
(ValgrindError):
(ValgrindError.init):
(ValgrindError.str):
(ValgrindError.unique_string):
(ValgrindError.error_hash):
(ValgrindError.hash):
(ValgrindError.eq):
(LeakDetectorValgrind):
(LeakDetectorValgrind.init):
(LeakDetectorValgrind._parse_leaks_output):
(LeakDetectorValgrind.leaks_files_in_results_directory):
(LeakDetectorValgrind.clean_leaks_files_from_results_directory):
(LeakDetectorValgrind.parse_and_print_leaks_detail):

  • Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.

(make_mock_valgrind_output):
(make_mock_incomplete_valgrind_output):
(make_mock_valgrind_results):
(make_mock_valgrind_results_incomplete):
(make_mock_valgrind_results_empty):
(make_mock_valgrind_results_misformatted):
(mock_run_cppfilt_command):
(LeakDetectorValgrindTest):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):

2:39 AM Changeset in webkit [161955] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Pack ResourceError harder.
<https://webkit.org/b/126969>

Re-arrange the members of ResourceError to reduce padding,
shrinking it by 8 bytes.

Reviewed by Antti Koivisto.

  • platform/network/ResourceErrorBase.h:

(WebCore::ResourceErrorBase::ResourceErrorBase):

2:35 AM Changeset in webkit [161954] by akling@apple.com
  • 4 edits in trunk/Source/WebCore

Pack RenderLayer harder.
<https://webkit.org/b/126967>

Re-arrange the members of ScrollableArea a bit so that RenderLayer
can combine its bitfields with the ones in ScrollableArea.
This makes RenderLayer fit into a snugger size class, saving 32 bytes
per layer.

296 kB progression on Membuster3.

Reviewed by Antti Koivisto.

  • platform/ScrollableArea.cpp:
  • platform/ScrollableArea.h:

Put bitfield members at the end of ScrollableArea so inheriting
classes can synergize with the padding.

  • rendering/RenderLayer.h:

Make m_blendMode a bitfield to avoid bloating the class.

12:35 AM Changeset in webkit [161953] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Web Inspector: RemoteInspector::updateDebuggable may miss a push
https://bugs.webkit.org/show_bug.cgi?id=126965

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-14
Reviewed by Timothy Hatcher.

  • inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::updateDebuggable):
Always push an update. If a debuggable went from allowed to
not allowed, we would have missed pushing an update.

Jan 13, 2014:

11:48 PM Changeset in webkit [161952] by g.czajkowski@samsung.com
  • 16 edits in trunk/LayoutTests

Make spelling tests added in r141354 to be able to run asynchronously
https://bugs.webkit.org/show_bug.cgi?id=126895

Reviewed by Ryosuke Niwa.

As we started running spelling tests asynchronously, invoke 'finishJSTest()'
when all operations are completed, for example, required spelling markers have appeared.
It might happen later then during 'initSpellTest' testing callback.

Due to the tests perform other checks that do not affect expectation order (selection,
context menu suggestion items), the asynchronous operations were pushed back to the end of
the tests to be sure that those won't break expectation order.

  • editing/spelling/context-menu-suggestions-multiword-selection-expected.txt:
  • editing/spelling/context-menu-suggestions-multiword-selection.html:
  • editing/spelling/context-menu-suggestions-subword-selection-expected.txt:
  • editing/spelling/context-menu-suggestions-subword-selection.html:
  • editing/spelling/resources/util.js:
  • editing/spelling/spelling-changed-text-expected.txt:
  • editing/spelling/spelling-changed-text.html:
  • editing/spelling/spelling-double-clicked-word-expected.txt:
  • editing/spelling/spelling-double-clicked-word.html:
  • editing/spelling/spelling-exactly-selected-word-expected.txt:
  • editing/spelling/spelling-exactly-selected-word.html:
  • editing/spelling/spelling-with-whitespace-selection-expected.txt:
  • editing/spelling/spelling-with-whitespace-selection.html:
  • editing/spelling/spelling-with-punctuation-selection-expected.txt:
  • editing/spelling/spelling-with-punctuation-selection.html:

Additionally fix description format and get rid of context click, needless after r148282.

11:15 PM Changeset in webkit [161951] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

iOS WebCore build fixes

Add WebKit and WebKit2 as allowable clients of WebCore.

  • Configurations/WebCore.xcconfig:
11:02 PM Changeset in webkit [161950] by timothy_horton@apple.com
  • 17 edits in trunk/Source

iOS WebKit2 build fixes, part 1

  • WebCore.xcodeproj/project.pbxproj:

Move some headers to 'private', from 'project'.

  • Configurations/WebKit2.xcconfig:
  • NetworkProcess/NetworkResourceLoader.cpp:
  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/RemoteNetworkingContext.h:
  • Shared/WebEventConversion.h:
  • UIProcess/API/ios/WKGeolocationProviderIOS.mm:
  • UIProcess/API/ios/WKInteractionView.mm:

(-[WKTextPosition isEqual:]):

  • UIProcess/API/ios/WKViewIOS.mm: Renamed from Source/WebKit2/UIProcess/API/ios/WKView.mm.
  • UIProcess/ios/WebPageProxyIOS.mm:
  • UIProcess/ios/WebProcessProxyIOS.mm:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::elementDidFocus):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
10:58 PM Changeset in webkit [161949] by Lucas Forschler
  • 3 edits in trunk/Tools

Update the LLINT CLoop Bot build infrastructure
https://bugs.webkit.org/show_bug.cgi?id=126604

Unreviewed.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(CompileLLINTCLoop):
(RunLLINTCLoopTests):
(BuildAndTestLLINTCLoopFactory):
(BuildAndTestLLINTCLoopFactory.init):

10:54 PM Changeset in webkit [161948] by jinwoo7.song@samsung.com
  • 4 edits in trunk

[EFL][WK2] Disable failing API tests
https://bugs.webkit.org/show_bug.cgi?id=126960

Reviewed by Gyuyoung Kim.

Source/WebKit2:

Disable color picker test until bug 119120 is resolved.

  • UIProcess/API/efl/tests/test_ewk2_color_picker.cpp:

(TEST_F):

Tools:

Disable WKViewUserViewportToContents test until bug 126261 is resolved.

  • TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:

(TestWebKitAPI::TEST):

10:06 PM Changeset in webkit [161947] by commit-queue@webkit.org
  • 4 edits
    2 deletes in trunk

Unreviewed, rolling out r161907.
http://trac.webkit.org/changeset/161907
https://bugs.webkit.org/show_bug.cgi?id=126963

fast/canvas/webgl/webgl-compressed-texture-size-limit.html
fails on many bots (Requested by ap on #webkit).

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateTexFuncLevel):

LayoutTests:

  • fast/canvas/webgl/resources/webgl-test-utils.js:

(WebGLTestUtils):

  • fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Removed.
  • fast/canvas/webgl/webgl-compressed-texture-size-limit.html: Removed.
9:57 PM Changeset in webkit [161946] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test plugins/plugin-document-load-prevented-userscript.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=126962

  • platform/mac-wk2/TestExpectations: Marking as such.
9:53 PM Changeset in webkit [161945] by fpizlo@apple.com
  • 11 edits
    3 adds in branches/jsCStack/Source/JavaScriptCore

FTL PutByVal should have a complete story for OOB
https://bugs.webkit.org/show_bug.cgi?id=126961

Not yet reviewed.

Previously, the DFG would handle OOB by just ignoring the store, while the FTL
would handle it by speculating. This blind speculation in the FTL caused many
recompiles in Octane/gbemu.

This patch makes both the DFG and FTL speculate on OOB, but we switch to ignoring
the store if we have a frequent exit site.

Speculating is slightly better because it allows us to hoist and fold the checks.
It also makes it easier to reason about the store (that is, we know that it must
have happened).

This also fixes the handling of FTL OSR exits in the profiler.

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::refine):

  • dfg/DFGArrayMode.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::attemptToMakeGetArrayLength):

  • dfg/DFGSSALoweringPhase.cpp:

(JSC::DFG::SSALoweringPhase::handleNode):
(JSC::DFG::SSALoweringPhase::lowerBoundsCheck):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePutByValForIntTypedArray):
(JSC::DFG::SpeculativeJIT::compilePutByValForFloatTypedArray):

  • ftl/FTLCompile.cpp:

(JSC::FTL::fixFunctionBasedOnStackMaps):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compilePutByVal):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • tests/stress/int16-put-by-val-in-and-out-of-bounds.js: Added.

(foo):
(test):

  • tests/stress/int16-put-by-val-in-bounds-then-exit-out-of-bounds.js: Added.

(foo):
(test):

  • tests/stress/int16-put-by-val-out-of-bounds-bounds-then-do-in-bounds.js: Added.

(foo):
(test):

9:16 PM Changeset in webkit [161944] by ddkilzer@apple.com
  • 4 edits in trunk/Source/WebCore

Fix typedef of DragDataRef from id back to id<NSDraggingInfo>
<http://webkit.org/b/126958>
<rdar://problem/14814649>

Reviewed by Mark Rowe.

  • WebCore.exp.in: Export different symbols based on

has_feature(objc_protocol_qualifier_mangling) since clang
mangles the type differently with that change.

  • platform/DragData.h:
  • platform/mac/DragDataMac.mm:

(WebCore::DragData::DragData):

  • Revert r154493 by switching back to id<NSDraggingInfo>.
9:07 PM Changeset in webkit [161943] by jinwoo7.song@samsung.com
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] ewk_view_page_contents_get() API test is failing
https://bugs.webkit.org/show_bug.cgi?id=126957

Reviewed by Gyuyoung Kim.

As the day in 'Date' field may be one digit or two digit,
the data length may also be varied by one byte.

  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(EWK2ViewTest::PageContentsAsMHTMLCallback):

8:51 PM Changeset in webkit [161942] by mark.lam@apple.com
  • 2 edits in branches/jsCStack/Source/JavaScriptCore

Gardening: fix bad merge of https://bugs.webkit.org/show_bug.cgi?id=126790
on top of https://bugs.webkit.org/show_bug.cgi?id=126932.

Not reviewed.

  • llint/LowLevelInterpreter.asm:
  • the 2 patches implemented the same change in callToJavaScriptPrologue() and callToJavaScriptEpilogue(), but svn merged the changes without reporting a conflict. The result is a redundant push of lr and pop of cfr. This is now fixed.
7:59 PM Changeset in webkit [161941] by commit-queue@webkit.org
  • 13 edits in trunk/Source

Unreviewed, rolling out r161939.
http://trac.webkit.org/changeset/161939
https://bugs.webkit.org/show_bug.cgi?id=126956

didn't work with mac, of course (Requested by thorton on
#webkit).

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

  • NetworkProcess/NetworkResourceLoader.cpp:
  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/RemoteNetworkingContext.h:
  • Shared/WebEventConversion.h:
  • UIProcess/API/ios/WKGeolocationProviderIOS.mm:
  • UIProcess/API/ios/WKInteractionView.mm:

(-[WKTextPosition isEqual:]):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
7:52 PM Changeset in webkit [161940] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Update WebPageProxyIOS's user agent string
https://bugs.webkit.org/show_bug.cgi?id=126933

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-13
Reviewed by Darin Adler.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::standardUserAgent):
Send a more reasonable user agent. The previous one was forcing
iOS 5.1's iPad user-agent.

7:35 PM Changeset in webkit [161939] by timothy_horton@apple.com
  • 13 edits in trunk/Source

iOS WebKit2 build fixes

  • NetworkProcess/NetworkResourceLoader.cpp:
  • NetworkProcess/NetworkResourceLoader.h:

Introduce/clarify some confusion about CFNETWORK vs. PLATFORM(IOS).

  • NetworkProcess/RemoteNetworkingContext.h:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:

Get rid of an override of something that doesn't exist anymore.

  • WebKit2.xcodeproj/project.pbxproj:

Add some files. It's likely there are more missing, but this is a start.

  • Shared/WebEventConversion.h:
  • WebProcess/WebPage/WebPage.h:

Use WebKitAdditions.

  • UIProcess/API/ios/WKGeolocationProviderIOS.mm:

Something bizarre is happening with internal deprecation warnings.

  • UIProcess/API/ios/WKInteractionView.mm:

(-[WKTextPosition isEqual:]):
Fix a typo.

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:

Remove an override of something that doesn't exist anymore.

  • WebCore.xcodeproj/project.pbxproj:

Make some headers private instead of project for WK2's use.

6:43 PM Changeset in webkit [161938] by mark.lam@apple.com
  • 1 edit in branches/jsCStack/Source/JavaScriptCore/ChangeLog

Updated ChangeLog review status for patches which have been reviewed.

6:41 PM Changeset in webkit [161937] by Simon Fraser
  • 3 edits in trunk/Source/WebKit/mac

Fix the Mac build. WebViewPrivate.h declares quickLookContentForURL:
for iOS, but the implementation conditionalizes on USE(QUICK_LOOK),
which we are confused about.

  • WebView/WebView.mm:

(-[WebView quickLookContentForURL:]):

  • WebView/WebViewPrivate.h:
6:10 PM Changeset in webkit [161936] by Simon Fraser
  • 9 edits in trunk/Source

Source/WebCore: Make NetworkStateNotifier.h a private header, needed by iOS.

  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/mac: Fix the remaining compiler errors in iOS WK1.

  • WebView/WebFrame.mm:

(vectorForDictationPhrasesArray): Need this function on iOS.
(-[WebFrame setSelectedDOMRange:affinity:closeTyping:]): We're already inside
a huge if PLATFORM(IOS) block.
(-[WebFrame resetTextAutosizingBeforeLayout]): Document now exposes RenderView.

  • WebView/WebFrameInternal.h: Declare vectorForDictationPhrasesArray() (not a good place for it!)
  • WebView/WebView.mm: #import cleanup for iOS.

(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Declare autoStartRemoteInspector
here but this needs cleaning up (<rdar://problem/15810991>).
(-[WebView setHostApplicationBundleId:name:]): No [WebView sharedWebInspectorServer] any more.
(-[WebView _didCommitLoadForFrame:]): Ditto.

  • WebView/WebViewData.h: Add allowsRemoteInspection.
  • WebView/WebViewData.mm: Initialize allowsRemoteInspection

(-[WebViewPrivate init]):

  • WebView/WebViewPrivate.h: Fumbled #ifdef.
6:02 PM Changeset in webkit [161935] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r161916.
http://trac.webkit.org/changeset/161916
https://bugs.webkit.org/show_bug.cgi?id=126952

it is a lie - still fails on some configs (Requested by dino
on #webkit).

  • platform/mac/TestExpectations:
6:01 PM Changeset in webkit [161934] by mark.lam@apple.com
  • 1 edit in branches/jsCStack/Source/JavaScriptCore/ChangeLog

Updated the ChangeLog review status for a few prior commits.

5:42 PM Changeset in webkit [161933] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit/efl

[EFL] Do not store reference variables as a pointer in private data structure
https://bugs.webkit.org/show_bug.cgi?id=126945

Reviewed by Gyuyoung Kim.

Remove pageSettings, mainFrame and storageSession variables from Ewk_View_Private_Data.

  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):
(_ewk_view_smart_add):
(_ewk_view_smart_repaints_process):
(_ewk_view_smart_calculate):
(ewk_view_fixed_layout_size_set):
(ewk_view_fixed_layout_size_get):
(ewk_view_bg_color_set):
(ewk_view_setting_user_agent_set):
(ewk_view_setting_user_stylesheet_set):
(ewk_view_setting_auto_load_images_set):
(ewk_view_setting_auto_shrink_images_set):
(ewk_view_setting_enable_scripts_set):
(ewk_view_setting_enable_plugins_set):
(ewk_view_setting_enable_frame_flattening_set):
(ewk_view_setting_scripts_can_open_windows_set):
(ewk_view_setting_scripts_can_close_windows_set):
(ewk_view_setting_scripts_can_access_clipboard_set):
(ewk_view_setting_resizable_textareas_set):
(ewk_view_setting_private_browsing_set):
(ewk_view_setting_application_cache_set):
(ewk_view_setting_caret_browsing_set):
(ewk_view_setting_encoding_default_set):
(ewk_view_setting_encoding_detector_set):
(ewk_view_setting_enable_developer_extras_set):
(ewk_view_setting_font_minimum_size_set):
(ewk_view_setting_font_minimum_logical_size_set):
(ewk_view_setting_font_default_size_set):
(ewk_view_setting_font_monospace_size_set):
(ewk_view_font_family_name_set):
(ewk_view_setting_spatial_navigation_set):
(ewk_view_setting_local_storage_set):
(ewk_view_setting_page_cache_set):
(ewk_view_setting_local_storage_database_path_set):
(ewk_view_setting_minimum_timer_interval_set):
(ewk_view_setting_enable_webgl_set):
(ewk_view_setting_enable_hyperlink_auditing_set):
(ewk_view_setting_allow_universal_access_from_file_urls_set):
(ewk_view_setting_allow_file_access_from_file_urls_set):
(ewk_view_layout_if_needed_recursive):
(ewk_view_paint):
(ewk_view_paint_contents):
(ewk_view_js_object_add):
(ewk_view_page_rect_get):
(ewk_view_soup_session_get):
(ewk_view_soup_session_set):
(ewk_view_setting_enable_xss_auditor_set):
(ewk_view_setting_should_display_captions_set):
(ewk_view_setting_should_display_subtitles_set):
(ewk_view_setting_should_display_text_descriptions_set):
(ewk_view_setting_enable_fullscreen_set):
(ewk_view_setting_tiled_backing_store_enabled_set):
(ewk_view_setting_tiled_backing_store_enabled_get):
(ewk_view_tiled_backing_store_invalidate):
(EWKPrivate::storageSession):

5:37 PM Changeset in webkit [161932] by matthew_hanson@apple.com
  • 5 edits in branches/safari-537.74-branch/Source

Versioning.

5:27 PM Changeset in webkit [161931] by Simon Fraser
  • 15 edits in trunk/Source

More work towards getting iOS WK1 building.

Source/WebCore:

Some more Private headers for iOS.

  • WebCore.xcodeproj/project.pbxproj:

Source/WebKit/ios:

  • WebCoreSupport/WebFrameIOS.mm:

(-[WebFrame imageForNode:allowDownsampling:drawContentBehindTransparentNodes:]): Stub out this
function, since it should use recently-refactored node snapshotting code. Covered by <rdar://problem/15808709>.

Source/WebKit/mac:

  • DOM/WebDOMOperations.mm: Need RenderObject.h.
  • DOM/WebDOMOperationsPrivate.h:
  • History/WebBackForwardList.mm: Need Foundation/NSGeometry.h for NSRect

(-[WebBackForwardList dictionaryRepresentation]): Fix array iteration to match
other code.

  • Misc/WebIconDatabase.h: #ifdef out functions that return NSImages.
  • Plugins/WebPluginController.mm: Need <WebCore/AudioSession.h>
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::transitionToCommittedForNewPage): Some new code to
handle the error case.

  • WebView/WebFrameView.mm: Avoid including some headers which pull in AppKit classes.
  • WebView/WebHTMLView.mm: Ditto.

(-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]): Handle
different return type of createDragImageForSelection().

  • WebView/WebPolicyDelegatePrivate.h:
  • WebView/WebPreferences.mm: <WebCore/AudioSession.h> and <AudioToolbox/AudioSession.h>
5:21 PM Changeset in webkit [161930] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-537.74.7

New Tag.

5:13 PM Changeset in webkit [161929] by alex.christensen@flexsim.com
  • 2 edits in trunk/Source/WebKit

Unreviewed build fix for Win64.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Corrected 64-bit linker symbols.

5:09 PM Changeset in webkit [161928] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] Build Fix: Don't build the 'All-iOS' target on iOS. Just use 'All'.

  • Makefile:
5:08 PM Changeset in webkit [161927] by mark.lam@apple.com
  • 14 edits in branches/jsCStack/Source/JavaScriptCore

CStack: Fix 64-bit C Loop LLINT.
https://bugs.webkit.org/show_bug.cgi?id=126790.

Reviewed by Geoffrey Garen.

  1. Fixed miscellaneous bugs relevant for the C Loop LLINT (details below).
  1. Simplified CLoop::execute() by making it more emulate CPU calls as well. This is done by automatically synthesizing an opcode label at the return point after the call to JS code. The "lr" register (named after the ARM link register) will be set to that return opcode label before the call. The call itself is implemented as an opcode dispatch.
  • heap/Heap.cpp:

(JSC::Heap::markRoots):

  • Fixed typo: LLINT_CLOOP ==> LLINT_C_LOOP.
  • interpreter/JSStack.cpp:

(JSC::JSStack::gatherConservativeRoots):

  • Previously, we were declaring a span from baseOfStack() to topOfStack(). baseOfStack() points to the highest slot in the stack. topOfStack() points to the word below the lowest slot in the stack. The ConservativeRoots class will invert the high and low pointers to ensure that it iterates from low to high. However, with this span, the GC will miss not scan the highest slot in the stack, and will instead scan the slot below the stack which is technically outside the stack.

The span is now fixed to be from topOfStack() + 1 to highAddress().
highAddress() points at the slot above the highest slot in the stack.
This means GC will now correctly scan the stack from its lowest to its
highest slots (inclusive).

(JSC::JSStack::sanitizeStack):

  • Similar to the gatherConservativeRoots() case, sanitizeStack() is nullifying a span of stack that starts at 2 past the lowest slot in the stack.

This is because topOfStack() points at the slot below the lowest slot
in the stack. m_lastStackTop() points to an old topOfStack() i.e. it
potentially points to a slot that is not in the region of memory
allocated for the stack.

We now add 1 to both of these values to ensure that we're zeroing a
region that is in the stack's allocated memory, and stop at the slot
(inclusive) just below the stack's current lowest used slot.

  • interpreter/JSStack.h:
  • interpreter/JSStackInlines.h:
  • Made topOfStack() public because CLoop::execute() needs it.
  • The LLINT assembly (in CLoop::execute()) now takes care of pushing and popping the stack. Hence, we no longer need JSStack's pushFrame, popFrame, and stack fence infrastruture which relies on pushFrame and popFrame. These are now removed.
  • llint/LLIntOpcode.h:
  • Added new pseudo opcodes:
    • llint_return_to_host: this is the pseudo return address for returning to the host i.e. return from CLoop::execute().
    • llint_cloop_did_return_from_js_X: these are synthesized by the cloop offlineasm as needed i.e. every time it needs to generate code for a cloopCallJSFunction "instruction". These are the opcodes that will serve as the return point that we store in lr and return to when we see a "ret" opcode.

While the offlineasm automatically generates these in LLIntAssembly.h,
we have to manually add the declaration of these opcodes here. If we end
up generating more or less in the future (due to changes in the LLINT
assembly code), then we'll get compiler errors that will tell us to
update this list.

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::llint_stack_check_at_vm_entry):

  • llint/LLIntSlowPaths.h:
  • This slow path isn't needed for the non C loop build because the stack is finite sized and grows itself on access. For the C loop, we need this check function to give the JSStack a chance to grow the stack.
  • llint/LowLevelInterpreter64.asm:
  • Added call to llint_stack_check_at_vm_entry in doCallToJavaScript().
  • Fixed up calls and stack adjustments.
  • In makeHostFunctionCall(), the non C loop build will push lr and cfr when we call the host function. That's why we adjust the sp by 16 before the call. For the C loop build, we need to set the lr and cfr ourselves here.
  • In nativeCallTrampoline(), unlike makeHostFunctionCall(), the return address and cfr has already been set in the frame. Hence, we didn't have to do anything extra. Also got rid of the distinct block for the C_LOOP and just reuse the block for ARM64 since it is exactly what the C_LOOP needs for the most part.
  • llint/LowLevelInterpreter.asm:
  • Added push/pop or lr and cfr as needed.
  • In callTargetFunction(), make the C_LOOP use the same code as other targets except for the call instruction.
  • Same for slowPathForCall().
  • In prologue(), exclude the OSR check code for the C_LOOP build since it is not needed. Also added popping of cfr and lr since I'm working through this logic already.
  • llint/LowLevelInterpreter.cpp:

(JSC::CLoopRegister::operator Register*):
(JSC::CLoop::execute):

  • Added TRACE_OPCODE() for debugging use only.
  • Simplified some CLoopRegister names.
  • Initialize the needed registers and incoming arguments before entering the interpreter loop.
  • Added llint_return_to_host as the exit opcode for returning from CLoop::execute(). We set it as the value for lr (the return address) before we enter the interpreter loop.
  • Updated the getHostCallReturnValue opcode handler to match the current getHostCallReturnValue and getHostCallReturnValueWithExecState code in JITOperations.cpp.
  • offlineasm/cloop.rb:
  • Updated C loop register names.
  • Added tracking of the number of cloop_did_return_from_js labels.
  • Added push, pop, and change the implementation of the cloopCallJSFunction pseudo instruction to use synthesized cloop_did_return_from_js opcodes / labels as return addresses.
  • runtime/Executable.cpp:
  • Fix C loop build breaker by a prior patch.
  • runtime/VM.cpp:

(JSC::VM::VM):

  • Fixed typo: LLINT_CLOOP ==> LLINT_C_LOOP.
5:05 PM Changeset in webkit [161926] by jinwoo7.song@samsung.com
  • 1 edit
    10 adds in trunk/LayoutTests

Unreviewed EFL gardening. Rebaselining after r161669.

  • platform/efl/css3/masking/clip-path-circle-border-box-expected.png: Added.
  • platform/efl/css3/masking/clip-path-circle-border-box-expected.txt: Added.
  • platform/efl/css3/masking/clip-path-circle-bounding-box-expected.png: Added.
  • platform/efl/css3/masking/clip-path-circle-bounding-box-expected.txt: Added.
  • platform/efl/css3/masking/clip-path-circle-content-box-expected.png: Added.
  • platform/efl/css3/masking/clip-path-circle-content-box-expected.txt: Added.
  • platform/efl/css3/masking/clip-path-circle-margin-box-expected.png: Added.
  • platform/efl/css3/masking/clip-path-circle-margin-box-expected.txt: Added.
  • platform/efl/css3/masking/clip-path-circle-padding-box-expected.png: Added.
  • platform/efl/css3/masking/clip-path-circle-padding-box-expected.txt: Added.
5:02 PM Changeset in webkit [161925] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Highlighting password field then making a Sticky Note via Safari Services exposes password
https://bugs.webkit.org/show_bug.cgi?id=126946

Reviewed by Enrica Casucci.

Using the Services menu has a slightly different codepath than Editor::copy() does. This
patch duplicates the canCopy() check that Editor::copy() does.

Testing is not possible because the Services menu is not accessible to our tests.

  • editing/mac/EditorMac.mm:

(WebCore::Editor::stringSelectionForPasteboard):
(WebCore::Editor::stringSelectionForPasteboardWithImageAltText):
(WebCore::Editor::dataSelectionForPasteboard):

5:00 PM Changeset in webkit [161924] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

[WebGL] Crash due to forceLostContext
https://bugs.webkit.org/show_bug.cgi?id=126947

Reviewed by Dean Jackson.

Covered by webgl/conformance/textures/origin-clean-conformance.html.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::isContextLost): Make const.
(WebCore::WebGLRenderingContext::platformLayer): Don't attempt to use
a lost context.

  • html/canvas/WebGLRenderingContext.h: isContextLost should be const.
4:53 PM Changeset in webkit [161923] by jinwoo7.song@samsung.com
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening. Rebaseline after r161696.

  • platform/efl/css1/text_properties/word_spacing-expected.png:
  • platform/efl/css1/text_properties/word_spacing-expected.txt:
4:43 PM Changeset in webkit [161922] by Martin Robinson
  • 11 edits in trunk

[CMake] Mark all dependency include paths and libraries as advanced variables
https://bugs.webkit.org/show_bug.cgi?id=126504

Reviewed by Daniel Bates.

.:

  • Source/cmake/FindATK.cmake: Mark result variable as advanced.
  • Source/cmake/FindCairo.cmake: Ditto.
  • Source/cmake/FindEGL.cmake: Ditto.
  • Source/cmake/FindEnchant.cmake: Ditto.
  • Source/cmake/FindGLIB.cmake: Ditto.
  • Source/cmake/FindGStreamer.cmake: Ditto.
  • Source/cmake/FindHarfBuzz.cmake: Ditto.
  • Source/cmake/FindLibSoup.cmake: Ditto.

Source/WebKit2:

  • CMakeLists.txt: Mark the LIBRT_LIBRARIES variable as advanced.
4:42 PM Changeset in webkit [161921] by Martin Robinson
  • 2 edits in trunk

[GTK][CMake] Add a 'check' target
https://bugs.webkit.org/show_bug.cgi?id=126770

Reviewed by Daniel Bates.

  • Source/PlatformGTK.cmake: Add a 'check' target that calls run-gtk-tests.
4:38 PM Changeset in webkit [161920] by Martin Robinson
  • 2 edits in trunk/Source/WebCore

[GTK][CMake] WebCorePlatform build can sometimes fail due to missing generated headers
https://bugs.webkit.org/show_bug.cgi?id=126911

Reviewed by Daniel Bates.

  • PlatformGTK.cmake: Add an explicit dependency from WebCorePlatform to WebCore.
4:37 PM Changeset in webkit [161919] by Martin Robinson
  • 2 edits in trunk/Source/WebKit2

[GTK][CMake] Circular dependency in generation of WebKitEnumTypes.h
https://bugs.webkit.org/show_bug.cgi?id=126912

Reviewed by Daniel Bates.

  • PlatformGTK.cmake: Remove the circular dependency by generating WebKitEnumTypes.h with

all installed headers except for WebKitEnumTypes.h itself.

4:33 PM Changeset in webkit [161918] by aestes@apple.com
  • 8 edits
    4 adds in trunk/Source/WebKit2

[iOS] Exclude shims and PluginProcess.app from the WebKit2 build
https://bugs.webkit.org/show_bug.cgi?id=126936

Reviewed by Daniel Bates.

  • Configurations/All.xcconfig: Added. Excluded PluginProcess.app from

being copied into WebKit2.framework on iOS.

  • Configurations/NetworkProcess.xcconfig: Excluded SecItemShim.dylib

from being copied into NetworkProcess.app on iOS.

  • Configurations/PluginProcess.xcconfig: Excluded

PluginProcessShim.dylib from being copied into PluginProcess.app and
set SKIP_INSTALL to YES on iOS.

  • Configurations/PluginProcessShim.xcconfig: Added. Linked the shim

against necessary frameworks on Mac.

  • Configurations/SecItemShim.xcconfig: Ditto.
  • Configurations/WebProcessShim.xcconfig: Ditto.
  • Configurations/WebContentProcess.xcconfig: Excluded

WebProcessShim.dylib from being copied into WebProcess.app on iOS.

  • PluginProcess/mac/PluginProcessShim.mm: Added #if !PLATFORM(IOS) guards.
  • Shared/mac/CookieStorageShimLibrary.cpp: Ditto.
  • WebProcess/mac/SecItemShimLibrary.mm: Ditto.
  • WebKit2.xcodeproj/project.pbxproj: Removed Mac-only frameworks from

the shims' 'Link Binary with Libraries' build phases. Added new xcconfigs.

4:27 PM Changeset in webkit [161917] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebCore

Use the Selector Code Generator for resolving style
https://bugs.webkit.org/show_bug.cgi?id=126199

Reviewed by Ryosuke Niwa.

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::ruleMatches):

  • css/RuleSet.h:
4:14 PM Changeset in webkit [161916] by dino@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Unskipping WebGL 1.0.2/conformance/ogles/GL/build/build_009_to_016.html
It now passes.

  • platform/mac/TestExpectations:
4:02 PM Changeset in webkit [161915] by jinwoo7.song@samsung.com
  • 7 edits in trunk/Source/WebKit2

[EFL][WK2] Replace usage of DEFINE_STATIC_LOCAL with NeverDestroyed
https://bugs.webkit.org/show_bug.cgi?id=126882

Reviewed by Gyuyoung Kim.

  • Shared/efl/ProcessExecutablePathEfl.cpp:

(WebKit::executablePathOfWebProcess):
(WebKit::executablePathOfPluginProcess):
(WebKit::executablePathOfNetworkProcess):

  • UIProcess/API/efl/EwkView.cpp:

(wkPageToEvasObjectMap):

  • UIProcess/API/efl/ewk_context.cpp:

(contextMap):

  • UIProcess/API/efl/ewk_page_group.cpp:

(pageGroupMap):

  • UIProcess/efl/TextCheckerClientEfl.cpp:

(TextCheckerClientEfl::instance):

  • UIProcess/efl/TextCheckerClientEfl.h:
3:50 PM Changeset in webkit [161914] by mhahnenberg@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Performance regression on dromaeo due to generational marking
https://bugs.webkit.org/show_bug.cgi?id=126901

Reviewed by Oliver Hunt.

We were seeing some performance regression with ENABLE_GGC == 0, so this patch
ifdefs out more things to get rid of the additional overhead.

  • heap/Heap.cpp:

(JSC::Heap::markRoots):
(JSC::Heap::writeBarrier):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::clearMarks):
(JSC::MarkedBlock::clearMarksWithCollectionType):

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::resetAllocators):

  • heap/MarkedSpace.h:

(JSC::MarkedSpace::didAllocateInBlock):

  • heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::internalAppend):
(JSC::SlotVisitor::reportExtraMemoryUsage):

3:23 PM Changeset in webkit [161913] by msaboff@apple.com
  • 4 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: Fix unwind on branch for X86-64
https://bugs.webkit.org/show_bug.cgi?id=126932

Reviewed by Geoffrey Garen.

Added code to push bp ; move sp, bp as the first instructions in callToJavaScript.
This complies with what happens at the top of most functions. This added push
is used to restore bp in the prologue. The values for the return PC and save BP in
the sentinel frame are only used for unwinding. Made similar mods to other platforms.
Added eh_frame directives to LLInt global labels to get unwinding through them working
as well.

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter.cpp:
  • llint/LowLevelInterpreter64.asm:
3:03 PM Changeset in webkit [161912] by dbates@webkit.org
  • 3 edits in trunk/Source/WebKit/mac

[iOS] Remove duplicate inclusions of header WAKView.h
following <http://trac.webkit.org/changeset/161910>

  • WebView/WebFrameView.h:
  • WebView/WebHTMLView.h:
2:59 PM Changeset in webkit [161911] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Update the SelectorQuery code using compiled selector after r161196
https://bugs.webkit.org/show_bug.cgi?id=126860

Reviewed by Andreas Kling.

Update tree traversal code to the current traversal functions.

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::executeCompiledSimpleSelectorChecker):
(WebCore::SelectorDataList::executeCompiledSelectorCheckerWithContext):

2:55 PM Changeset in webkit [161910] by Simon Fraser
  • 18 edits in trunk/Source

Various iOS WebKit1 build fixes.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj: iOS WebKit1 needs various

headers to be Private.

Source/WebKit/mac:

  • Configurations/WebKit.xcconfig: Add more Mac-only files

to the excluded files list for iOS.

  • DefaultDelegates/WebDefaultUIDelegate.m: Don't include WebJavaScriptTextInputPanel.h

on iOS

  • History/WebHistory.h: NSCalendarDate doesn't exist on iOS.
  • Misc/WebDownload.h: Need WAKAppKitStubs.h
  • Misc/WebNSViewExtras.m: No WebNSPasteboardExtras on iOS
  • Storage/WebDatabaseManagerClient.mm: Need DatabaseTracker.h, no harm

in including it for all platforms.

  • WebCoreSupport/WebEditorClient.h: Remove useless comment.
  • WebCoreSupport/WebEditorClient.mm:

(nsStringWithoutCopying): Moved
(WebEditorClient::checkTextOfParagraph): Modernized.

  • WebInspector/WebNodeHighlightView.mm: Need FloatQuad.h.
  • WebView/WebDataSource.mm: Need WebFrameViewInternal.h
  • WebView/WebDocument.h: Needs WAKView.h.
  • WebView/WebFrameView.h: Ditto.
  • WebView/WebHTMLView.h: Ditto.
  • WebView/WebPDFDocumentExtras.mm:

(allScriptsInPDFDocument): No PDFDocument on iOS.

  • WebView/WebPolicyDelegate.h:
  • WebView/WebView.h: Fix incorrect #if.
2:33 PM Changeset in webkit [161909] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

Map RootInlineBox to containing region via bit+hashmap.
<https://webkit.org/b/126917>

The vas majority of RootInlineBox objects don't have a containing
RenderRegion, so let's store that in a bit+hashmap configuration
instead of having a dedicated pointer member for it.

148 kB progression on Membuster3.

Reviewed by Antti Koivisto.

  • rendering/InlineFlowBox.h:

(WebCore::InlineFlowBox::InlineFlowBox):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):

Added m_hasContainingRegion bit.

(WebCore::containingRegionMap):

Global map between RootInlineBox and RenderRegion.

(WebCore::RootInlineBox::~RootInlineBox):

Remove self from aforementioned global map if needed.

(WebCore::RootInlineBox::paint):

Tweak a condition to avoid double hash lookup.

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::containingRegion):
(WebCore::RootInlineBox::clearContainingRegion):
(WebCore::RootInlineBox::setContainingRegion):

Store the containing region in a bit+hashmap.

2:29 PM Changeset in webkit [161908] by dbates@webkit.org
  • 9 edits in trunk/Source/WebKit

[iOS] More build fixes for WebKit

Source/WebKit:

Add iOS-specific logic to build phases: "Symlink WebKitPluginHost in to place" and "Migrate Headers".

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • Configurations/Base.xcconfig: Removed extraneous definition of SUPPORTED_PLATFORMS.
  • Configurations/WebKit.xcconfig: Exclude more Mac-specific files when building for iOS:

CarbonUtils.m, CarbonWindowAdapter.mm, CarbonWindowContentView.m, CarbonWindowFrame.m,
HIViewAdapter.m, HIWebView.mm, MailQuirksUserScript.js, OutlookQuirksUserScript.js,
PopupMenuMac.mm, SearchPopupMenuMac.mm, WebClipView.mm, WebInspectorClient.mm,
WebNetscapeContainerCheckContextInfo.mm, WebNetscapeContainerCheckPrivate.mm, WebRenderNode.mm,
WebStringTruncator.mm, and WebTextCompletionController.mm. I haven't verified the Mac-specific
nature of each of these files. We may be able to reduce this list upon further investigation.

  • WebView/WebDocument.h: Include header <WebKit/WAKView.h> for definition of WAKView.
  • WebView/WebFrameView.h: Ditto.
  • WebView/WebUIDelegate.h: Ditto.
  • WebView/WebView.h: Ditto.
2:27 PM Changeset in webkit [161907] by Brent Fulgham
  • 4 edits
    2 adds in trunk

Source/WebCore: [WebGL] Invalid range checking in WebGLRenderingContext::validateTexFuncLevel
https://bugs.webkit.org/show_bug.cgi?id=126925

Reviewed by Dean Jackson.

Added fast/canvas/webgl/webgl-compressed-texture-size-limit.html.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateTexFuncLevel): Avoid off-by-one error

LayoutTests: [WebGL] Invalid range checking in WebGLRenderContext::validateTexFunctionLevel
https://bugs.webkit.org/show_bug.cgi?id=126925

Reviewed by Dean Jackson.

  • fast/canvas/webgl/resources/webgl-test-utils.js:

(WebGLTestUtils): Add missing 'waitForComposite' implementatino.

  • fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Added.
  • fast/canvas/webgl/webgl-compressed-texture-size-limit.html: Added.
2:20 PM Changeset in webkit [161906] by ap@apple.com
  • 88 edits
    6 adds in trunk/LayoutTests

Update Mountain Lion test results for subpixel layout chanegs.

Patch by Zalan Bujtas.

  • platform/mac-mountainlion/compositing: Added.
  • platform/mac-mountainlion/compositing/contents-opaque: Added.
  • platform/mac-mountainlion/compositing/contents-opaque/control-layer-expected.txt: Added.
  • platform/mac-mountainlion/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/mac-mountainlion/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/mac-mountainlion/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/mac-mountainlion/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/mac-mountainlion/editing/selection/3690703-2-expected.txt:
  • platform/mac-mountainlion/editing/selection/3690703-expected.txt:
  • platform/mac-mountainlion/editing/selection/3690719-expected.txt:
  • platform/mac-mountainlion/fast/block/margin-collapse/103-expected.txt:
  • platform/mac-mountainlion/fast/css/continuationCrash-expected.txt:
  • platform/mac-mountainlion/fast/css/css2-system-fonts-expected.txt:
  • platform/mac-mountainlion/fast/css/margin-top-bottom-dynamic-expected.txt: Added.
  • platform/mac-mountainlion/fast/css/text-overflow-input-expected.txt:
  • platform/mac-mountainlion/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/mac-mountainlion/fast/forms/basic-inputs-expected.txt:
  • platform/mac-mountainlion/fast/forms/basic-textareas-expected.txt:
  • platform/mac-mountainlion/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/mac-mountainlion/fast/forms/box-shadow-override-expected.txt:
  • platform/mac-mountainlion/fast/forms/button-cannot-be-nested-expected.txt: Added.
  • platform/mac-mountainlion/fast/forms/button-positioned-expected.txt:
  • platform/mac-mountainlion/fast/forms/button-sizes-expected.txt:
  • platform/mac-mountainlion/fast/forms/button-style-color-expected.txt:
  • platform/mac-mountainlion/fast/forms/button-table-styles-expected.txt:
  • platform/mac-mountainlion/fast/forms/button-text-transform-expected.txt:
  • platform/mac-mountainlion/fast/forms/button-white-space-expected.txt:
  • platform/mac-mountainlion/fast/forms/control-restrict-line-height-expected.txt:
  • platform/mac-mountainlion/fast/forms/fieldset-align-expected.txt:
  • platform/mac-mountainlion/fast/forms/file/input-file-re-render-expected.txt:
  • platform/mac-mountainlion/fast/forms/form-element-geometry-expected.txt:
  • platform/mac-mountainlion/fast/forms/input-appearance-height-expected.txt:
  • platform/mac-mountainlion/fast/forms/input-button-sizes-expected.txt:
  • platform/mac-mountainlion/fast/forms/input-disabled-color-expected.txt:
  • platform/mac-mountainlion/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac-mountainlion/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/mac-mountainlion/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac-mountainlion/fast/forms/input-value-expected.txt:
  • platform/mac-mountainlion/fast/forms/listbox-hit-test-zoomed-expected.txt:
  • platform/mac-mountainlion/fast/forms/minWidthPercent-expected.txt:
  • platform/mac-mountainlion/fast/forms/search-rtl-expected.txt:
  • platform/mac-mountainlion/fast/forms/search-vertical-alignment-expected.txt:
  • platform/mac-mountainlion/fast/forms/searchfield-heights-expected.txt:
  • platform/mac-mountainlion/fast/forms/select-baseline-expected.txt: Added.
  • platform/mac-mountainlion/fast/forms/textAreaLineHeight-expected.txt:
  • platform/mac-mountainlion/fast/forms/validation-message-appearance-expected.txt:
  • platform/mac-mountainlion/fast/html/details-no-summary4-expected.txt:
  • platform/mac-mountainlion/fast/html/details-open-javascript-expected.txt:
  • platform/mac-mountainlion/fast/html/details-open2-expected.txt:
  • platform/mac-mountainlion/fast/html/details-open4-expected.txt:
  • platform/mac-mountainlion/fast/html/details-replace-summary-child-expected.txt:
  • platform/mac-mountainlion/fast/html/details-replace-text-expected.txt:
  • platform/mac-mountainlion/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac-mountainlion/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/mac-mountainlion/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/mac-mountainlion/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug30692-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug52505-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/core/margins-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/dom/tableDom-expected.txt:
  • platform/mac-mountainlion/tables/mozilla/other/move_row-expected.txt:
  • platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/mac-mountainlion/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
  • platform/mac-mountainlion/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
  • platform/mac-mountainlion/transforms/2d/zoom-menulist-expected.txt:
2:02 PM Changeset in webkit [161905] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit

[iOS] Fix up WebKit build phases

Add iOS-specific logic to build phrases "Generate 64-bit Export File" and "Migrate Headers".

  • WebKit.xcodeproj/project.pbxproj:
2:01 PM Changeset in webkit [161904] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit

[iOS] Fix up WebKit build phases

Add iOS-specific logic to build phrases "Generate 64-bit Export File" and "Migrate Headers".

  • WebKit.xcodeproj/project.pbxproj:
12:56 PM Changeset in webkit [161903] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Add uint8_t specialization for WebCore::writeLittleEndian()
https://bugs.webkit.org/show_bug.cgi?id=126924

Reviewed by Darin Adler.

Specialize WebCore::writeLittleEndian() for datatype uint8_t so as to avoid
a compiler warning when right shifting a uint8_t by 8 because the result of
such a computation is undefined.

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::writeLittleEndian<uint8_t>): Added.

12:54 PM Changeset in webkit [161902] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebKit

Unreviewed build fix.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add missing

exports needed for Windows build after r161899.

12:21 PM Changeset in webkit [161901] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

r161638 broke the Windows build
https://bugs.webkit.org/show_bug.cgi?id=126916

  • DerivedSources.make:
12:10 PM Changeset in webkit [161900] by BJ Burg
  • 2 edits in trunk/Source/JavaScriptCore

Web Inspector: protocol generator should support integer-typed declarations
https://bugs.webkit.org/show_bug.cgi?id=126828

Reviewed by Joseph Pecoraro.

Add new binding classes for parameter/ad-hoc and normal integer type declarations.

  • inspector/scripts/CodeGeneratorInspector.py:

(TypeBindings.create_type_declaration_):
(TypeBindings.create_type_declaration_.PlainInteger):
(TypeBindings.create_type_declaration_.PlainInteger.resolve_inner):
(TypeBindings.create_type_declaration_.PlainInteger.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.PlainInteger.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.PlainInteger.get_code_generator):
(TypeBindings.create_type_declaration_.PlainInteger.get_validator_call_text):
(TypeBindings.create_type_declaration_.PlainInteger.reduce_to_raw_type):
(TypeBindings.create_type_declaration_.PlainInteger.get_type_model):
(TypeBindings.create_type_declaration_.PlainInteger.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.PlainInteger.get_array_item_c_type_text):
(TypeBindings.create_type_declaration_.TypedefInteger):
(TypeBindings.create_type_declaration_.TypedefInteger.resolve_inner):
(TypeBindings.create_type_declaration_.TypedefInteger.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.TypedefInteger.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.generate_type_builder.int):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.register_use):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.get_generate_pass_id):
(TypeBindings.create_type_declaration_.TypedefInteger.get_validator_call_text):
(TypeBindings.create_type_declaration_.TypedefInteger.reduce_to_raw_type):
(TypeBindings.create_type_declaration_.TypedefInteger.get_type_model):
(TypeBindings.create_type_declaration_.TypedefInteger.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.TypedefInteger.get_array_item_c_type_text):

11:42 AM Changeset in webkit [161899] by eric.carlson@apple.com
  • 18 edits
    6 adds in trunk

Allow MediaSessionManager to restrict media playback
https://bugs.webkit.org/show_bug.cgi?id=126780

Reviewed by Jer Noble.

Source/WebCore:

Test: media/video-concurrent-playback.html

  • WebCore.exp.in: Export functions needed by Internals.

Add HTMLMediaSession.

  • WebCore.xcodeproj/project.pbxproj:
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:

Add a media session object to manage HTMLMediaElement restrictions.

  • html/HTMLMediaSession.cpp: Added.
  • html/HTMLMediaSession.h: Added.

Move media restriction management to a MediaSession.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement): Use the media session to manage restrictions.
(WebCore::HTMLMediaElement::parseAttribute): Ditto.
(WebCore::HTMLMediaElement::insertedInto): Ditto.
(WebCore::HTMLMediaElement::parseAttribute): Ditto.
(WebCore::HTMLMediaElement::loadInternal): Ditto.
(WebCore::HTMLMediaElement::loadResource): Ditto.
(WebCore::HTMLMediaElement::setReadyState): Ditto.
(WebCore::HTMLMediaElement::autoplay): Ditto.
(WebCore::HTMLMediaElement::play): Ditto.
(WebCore::HTMLMediaElement::pause): Ditto
(WebCore::HTMLMediaElement::pauseInternal): Ditto
(WebCore::HTMLMediaElement::suspend): Ditto
(WebCore::HTMLMediaElement::resume): Ditto.
(WebCore::HTMLMediaElement::updatePlayState): Tell media session playback is about to start.
(WebCore::HTMLMediaElement::deliverNotification): Ditto.
(WebCore::HTMLMediaElement::webkitShowPlaybackTargetPicker): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerIsFullscreenPermitted): Ditto.
(WebCore::HTMLMediaElement::removeBehaviorsRestrictionsAfterFirstUserGesture): Ditto.
(WebCore::HTMLMediaElement::pausePlayback): New, allows the media session to pause playback.

  • html/HTMLMediaElement.h:
  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::webkitEnterFullscreen): Use the media session to manage restrictions.

  • platform/audio/MediaSession.cpp:

(WebCore::MediaSession::beginInterruption): Add logging.
(WebCore::MediaSession::endInterruption): Ditto.
(WebCore::MediaSession::pauseSession): New, allows the session manager to pause playback.

  • platform/audio/MediaSession.h:

Add per-media type restrictions.

  • platform/audio/MediaSessionManager.cpp:

(WebCore::MediaSessionManager::MediaSessionManager): Initialize restrictions.
(WebCore::MediaSessionManager::addRestriction): New.
(WebCore::MediaSessionManager::removeRestriction): New.
(WebCore::MediaSessionManager::restrictions): New.
(WebCore::MediaSessionManager::sessionWillBeginPlayback): New. If only one session if the same

type is allowed to play, pause all others.

  • platform/audio/MediaSessionManager.h:
  • platform/audio/ios/MediaSessionManagerIOS.h: Added.
  • platform/audio/ios/MediaSessionManagerIOS.mm: Added.

(WebCore::MediaSessionManager::sharedManager):
(WebCore::m_objcObserver):
(-[WebAVAudioSessionHelper initWithCallback:]):
(-[WebAVAudioSessionHelper dealloc]):
(-[WebAVAudioSessionHelper interruption:]):

  • platform/audio/mac/AudioDestinationMac.h: Add pausePlayback.

Allow tests to set media session restrictions.

  • testing/Internals.cpp:
  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

  • media/video-concurrent-playback-expected.txt: Added.
  • media/video-concurrent-playback.html: Added.
11:34 AM Changeset in webkit [161898] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

Unreviewed Mac WK2 gardering after r161882.

  • platform/mac-wk2/fast/dynamic/012-expected.txt:
11:32 AM Changeset in webkit [161897] by Simon Fraser
  • 2 edits in trunk/Source/WebKit/mac

Include WAKAppKitStubs.h to get NSSelectionAffinity.

  • WebView/WebEditingDelegate.h:
11:17 AM Changeset in webkit [161896] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build more.

  • xml/XMLHttpRequestProgressEventThrottle.cpp:

(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent):

11:13 AM Changeset in webkit [161895] by Simon Fraser
  • 2 edits in trunk/Source/WebKit/mac

DOMTouch* etc should not be public headers on iOS.

  • MigrateHeaders.make:
11:11 AM Changeset in webkit [161894] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build.

  • xml/XMLHttpRequestProgressEventThrottle.cpp:

(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent):

11:07 AM Changeset in webkit [161893] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Snap time dividers to nearest numbers instead of just dividing the time span into max density slices.

https://bugs.webkit.org/show_bug.cgi?id=125081

Reviewed by Joseph Pecoraro.

  • UserInterface/TimelineDecorations.js:

(WebInspector.TimelineDecorations.prototype.updateHeaderTimes): Snap the time slice to a nearest number.
(WebInspector.TimelineDecorations.prototype.updateEventMarkers): Rename boundarySpan to timeSpan.

10:46 AM Changeset in webkit [161892] by Simon Fraser
  • 2 edits
    1 move in trunk/Source/WebCore

Fix copy of SystemMemory.h in iOS WebKit build.

Move SystemMemory.h from platform/SystemMemory.h to platform/ios/SystemMemory.h.
Add it to the project file.
Make it a Private header.
Add PLATFORM(IOS) #idfefs around its contents.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/ios/SystemMemory.h: Renamed from Source/WebCore/platform/SystemMemory.h.
10:41 AM Changeset in webkit [161891] by commit-queue@webkit.org
  • 14 edits in trunk

Dispatch a progress event before dispatching abort, error or timeout event
https://bugs.webkit.org/show_bug.cgi?id=126575

Source/WebCore:

Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-13
Reviewed by Alexey Proskuryakov.

Added sending of progress event after readystatechange event (switching to DONE state) in case of abort, error or timeout.
Fixed assertions in XMLHttpRequestProgressEventThrottle and XMLHttpRequestUpload.

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::dispatchErrorEvents): added sending of progress event before the specific error event

  • xml/XMLHttpRequestProgressEventThrottle.cpp:

(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): fixed assertion

  • xml/XMLHttpRequestUpload.cpp:

(WebCore::XMLHttpRequestUpload::dispatchProgressEvent): fixed assertion

LayoutTests:

Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-13
Reviewed by Alexey Proskuryakov.

Updated onloadend-event-after-abort.html and onloadend-event-after-error.html to check for progress event.
Fixed the other tests to cope with additional progress event.

  • http/tests/xmlhttprequest/onabort-progressevent-attributes.html:
  • http/tests/xmlhttprequest/onloadend-event-after-abort-expected.txt:
  • http/tests/xmlhttprequest/onloadend-event-after-abort.html:
  • http/tests/xmlhttprequest/onloadend-event-after-error-expected.txt:
  • http/tests/xmlhttprequest/onloadend-event-after-error.html:
  • http/tests/xmlhttprequest/simple-cross-origin-progress-events-expected.txt:
  • http/tests/xmlhttprequest/simple-cross-origin-progress-events.html:
  • http/tests/xmlhttprequest/upload-onloadend-event-after-abort.html:
  • http/tests/xmlhttprequest/xmlhttprequest-sync-no-progress-events-expected.txt:
10:25 AM Changeset in webkit [161890] by Carlos Garcia Campos
  • 25 edits
    2 adds in trunk/Source

[SOUP] Add SoupNetworkSession class to wrap a SoupSession
https://bugs.webkit.org/show_bug.cgi?id=126813

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Add SoupNetworkSession class that wraps a SoupSession and move all
the code related to the SoupSession from ResourceHandle to
SoupNetworkSession, including the static methods to get the
default session and create testing and private sessions.

  • GNUmakefile.list.am: Add new files to compilation.
  • PlatformEfl.cmake: Ditto.
  • PlatformGTK.cmake: Ditto.
  • platform/network/NetworkStorageSession.h: Use SoupNetworkSession

instead of SoupSession.

  • platform/network/ResourceHandle.h:
  • platform/network/soup/CookieJarSoup.cpp:

(WebCore::cookieJarForSession): Use SoupNetworkSession to get the
SoupSession.

  • platform/network/soup/DNSSoup.cpp:

(WebCore::DNSResolveQueue::platformResolve): Ditto.

  • platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::NetworkStorageSession::NetworkStorageSession): Use
SoupNetworkSession instead of SoupSession.
(WebCore::NetworkStorageSession::~NetworkStorageSession):
(WebCore::NetworkStorageSession::defaultStorageSession): Create a
NetworkStorageSession with a NULL SoupNetworkSession which means
that the default SoupNetworkSession will be used.
(WebCore::NetworkStorageSession::createPrivateBrowsingSession):
Call SoupNetworkSession::createPrivateBrowsingSession() to create
the private session.
(WebCore::NetworkStorageSession::switchToNewTestingSession): Call
SoupNetworkSession::createTestingSession() to create the testing
session.
(WebCore::NetworkStorageSession::soupNetworkSession): Return the
SoupNetworkSession or the default one.
(WebCore::NetworkStorageSession::setSoupNetworkSession): Set a new
SoupNetworkSession.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::sessionFromContext): Use SoupNetworkSession to get the
SoupSession.
(WebCore::ResourceHandleInternal::soupSession): Simply call
sessionFromContext(), since ensureSessionIsInitialized() is no
longer needed, because the SoupSession are now initialized in the
SoupNetworkSession constructor.
(WebCore::ResourceHandle::didStartRequest): Function to notify the
ResourceHandle that current request has just started for web timing.

  • platform/network/soup/SoupNetworkSession.cpp: Added.

(WebCore::soupLogPrinter): Logger callback.
(WebCore::SoupNetworkSession::defaultSession): Return a reference
to the default SoupNetworkSession.
(WebCore::SoupNetworkSession::createPrivateBrowsingSession):
Create a new private session.
(WebCore::SoupNetworkSession::createTestingSession): Create a new
testing session.
(WebCore::SoupNetworkSession::createForSoupSession): Create a new
SoupNetworkSession for the given SoupSession.
(WebCore::authenticateCallback): Callback emitted by the
SoupSession when the request needs authentication.
(WebCore::requestStartedCallback): Callback emitted by the
SoupSession when as request has just started.
(WebCore::SoupNetworkSession::SoupNetworkSession):
(WebCore::SoupNetworkSession::~SoupNetworkSession):
(WebCore::SoupNetworkSession::setupLogger): Helper private
function to setup the logger.
(WebCore::SoupNetworkSession::setCookieJar): Set a new CookieJar
in the session replacing the existing one.
(WebCore::SoupNetworkSession::cookieJar): Return the current
CookieJar of the session.
(WebCore::SoupNetworkSession::setCache): Set a disk cache.
(WebCore::SoupNetworkSession::cache): Return the current disk cache.
(WebCore::SoupNetworkSession::setSSLPolicy): Set the SSL policy.
(WebCore::SoupNetworkSession::sslPolicy): Get the current SSL policy.
(WebCore::SoupNetworkSession::setHTTPProxy): Set the HTTP proxy.
(WebCore::SoupNetworkSession::httpProxy): Get the current HTTP proxy.
(WebCore::SoupNetworkSession::setupHTTPProxyFromEnvironment): Set
the HTTP proxy using the environment variables.
(WebCore::buildAcceptLanguages): Helper function build the accept
language string in the format expected by soup (RFC 2616).
(WebCore::SoupNetworkSession::setAcceptLanguages): Set the accept
language for the given list of languages.

  • platform/network/soup/SoupNetworkSession.h: Added.

(WebCore::SoupNetworkSession::soupSession): Return the SoupSession.

Source/WebKit/efl:

Use the new SoupNetworkSession API.

  • ewk/ewk_cookies.cpp:

(ewk_cookies_file_set):

  • ewk/ewk_main.cpp:

(_ewk_init_body):

  • ewk/ewk_network.cpp:

(ewk_network_proxy_uri_set):
(ewk_network_proxy_uri_get):
(ewk_network_tls_certificate_check_get):
(ewk_network_tls_certificate_check_set):
(ewk_network_tls_ca_certificates_path_get):
(ewk_network_tls_ca_certificates_path_set):
(ewk_network_default_soup_session_get):

  • ewk/ewk_view.cpp:

(ewk_view_soup_session_get):
(ewk_view_soup_session_set):

Source/WebKit/gtk:

  • webkit/webkitglobals.cpp:

(webkit_get_default_session): Use the new SoupNetworkSession API
to get the default SoupSession

Source/WebKit2:

Use the new SoupNetworkSession API.

  • NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformInitializeNetworkProcess):
(WebKit::NetworkProcess::platformSetCacheModel):
(WebKit::NetworkProcess::clearCacheForAllOrigins):

  • NetworkProcess/unix/NetworkProcessMainUnix.cpp:

(WebKit::NetworkProcessMain):

  • WebProcess/Cookies/soup/WebCookieManagerSoup.cpp:

(WebKit::WebCookieManager::setCookiePersistentStorage):

  • WebProcess/efl/WebProcessMainEfl.cpp:

(WebKit::WebProcessMainEfl):

  • WebProcess/gtk/WebProcessMainGtk.cpp:

(WebKit::WebProcessMainGtk):

  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformClearResourceCaches):
(WebKit::setSoupSessionAcceptLanguage):
(WebKit::WebProcess::platformInitializeWebProcess):

  • WebProcess/soup/WebSoupRequestManager.cpp:

(WebKit::WebSoupRequestManager::registerURIScheme):

10:21 AM Changeset in webkit [161889] by Brent Fulgham
  • 8 edits in trunk

[WebGL] Error messages should use source code labels, not internal mangled symbols.
https://bugs.webkit.org/show_bug.cgi?id=126832

Reviewed by Dean Jackson.

Source/WebCore:

Revised fast/canvas/webgl/glsl-conformance.html.

  • platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::getSymbolInfo): Correct missing 'break'.
(WebCore::ANGLEWebKitBridge::compileShaderSource): Call 'getSymbolInfo'
for SH_VARYINGS.

  • platform/graphics/GraphicsContext3D.h: Add new declarations.
  • platform/graphics/filters/CustomFilterValidatedProgram.cpp: Add case

for SHADER_SYMBOL_TYPE_VARYING. This is a no-op to match existing
behavior.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::compileShader): Demangle log output.
(WebCore::GraphicsContext3D::mappedSymbolName): Added.
(WebCore::GraphicsContext3D::getUnmangledInfoLog): Added.
(WebCore::GraphicsContext3D::getProgramInfoLog): Demangle log output.
(WebCore::GraphicsContext3D::getShaderInfoLog): Demangle log output.

LayoutTests:

  • fast/canvas/webgl/glsl-conformance.html: Add log to program output

showing error message to confirm proper labels are being used.

  • fast/canvas/webgl/glsl-conformance-expected.txt: updated.
10:20 AM Changeset in webkit [161888] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Include RenderElement.h to fix BaseChooserOnlyDateAndTimeInputType.cpp

Fixes the following build failure:

Undefined symbols for architecture x86_64:

"ZNK7WebCore13ContainerNode8rendererEv", referenced from:

ZN7WebCore35BaseChooserOnlyDateAndTimeInputType22handleDOMActivateEventEPNS_5EventE in BaseChooserOnlyDateAndTimeInputType.o

  • html/BaseChooserOnlyDateAndTimeInputType.cpp: Include

RenderElement.h.

10:20 AM Changeset in webkit [161887] by aestes@apple.com
  • 4 edits in trunk/Source/WebKit

[iOS] Build Fix: switch back to calling postprocess-headers.sh

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • postprocess-headers.sh:
9:46 AM Changeset in webkit [161886] by andersca@apple.com
  • 4 edits in trunk/Source/WTF

Move another deprecated symbol to DeprecatedSymbolsUsedBySafari.mm
https://bugs.webkit.org/show_bug.cgi?id=126909

Reviewed by Ryosuke Niwa.

  • wtf/MainThread.cpp:
  • wtf/MainThread.h:
  • wtf/mac/DeprecatedSymbolsUsedBySafari.mm:

(WTF::callOnMainThread):

9:34 AM Changeset in webkit [161885] by aestes@apple.com
  • 3 edits in trunk/Source/WebCore

[iOS] Build Fix: copy iOS-specific generated headers

  • Configurations/WebCore.xcconfig: Excluded DOMTouch* and DOMGesture* headers on Mac.
  • WebCore.xcodeproj/project.pbxproj:
9:24 AM Changeset in webkit [161884] by Alan Bujtas
  • 1225 edits
    1 copy
    29 adds
    2 deletes in trunk/LayoutTests

Unreviewed MAC gardening. Rebaselining after subpixel layout is enabled (r161882).

  • css3/background/background-repeat-space-content-expected.html:
  • css3/background/background-repeat-space-padding-expected.html:
  • css3/masking/mask-repeat-space-content-expected.html:
  • css3/masking/mask-repeat-space-padding-expected.html:
  • fast/regions/auto-size/autoheight-correct-region-for-lines-2.html:
  • fast/regions/overflow-region-transform.html:
  • platform/mac/TestExpectations:
  • platform/mac/accessibility/image-link-expected.txt:
  • platform/mac/accessibility/internal-link-anchors2-expected.txt:
  • platform/mac/accessibility/svg-bounds-expected.txt:
  • platform/mac/accessibility/svg-remote-element-expected.txt:
  • platform/mac/accessibility/table-attributes-expected.txt:
  • platform/mac/accessibility/table-cell-spans-expected.txt:
  • platform/mac/accessibility/table-cells-expected.txt:
  • platform/mac/accessibility/table-detection-expected.txt:
  • platform/mac/accessibility/table-sections-expected.txt:
  • platform/mac/compositing/contents-opaque/control-layer-expected.txt: Added.
  • platform/mac/compositing/direct-image-compositing-expected.txt:
  • platform/mac/compositing/layer-creation/overlap-animation-container-expected.txt:
  • platform/mac/compositing/overflow/theme-affects-visual-overflow-expected.txt:
  • platform/mac/compositing/shadows/shadow-drawing-expected.txt:
  • platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt:
  • platform/mac/css1/basic/inheritance-expected.txt:
  • platform/mac/css1/box_properties/acid_test-expected.txt:
  • platform/mac/css1/box_properties/clear_float-expected.txt:
  • platform/mac/css1/box_properties/float_on_text_elements-expected.txt:
  • platform/mac/css1/box_properties/margin-expected.txt:
  • platform/mac/css1/box_properties/margin_bottom-expected.txt:
  • platform/mac/css1/box_properties/margin_right-expected.txt:
  • platform/mac/css1/box_properties/margin_top-expected.txt:
  • platform/mac/css1/box_properties/padding-expected.txt:
  • platform/mac/css1/box_properties/padding_bottom-expected.txt:
  • platform/mac/css1/box_properties/padding_left-expected.txt:
  • platform/mac/css1/box_properties/padding_right-expected.txt:
  • platform/mac/css1/box_properties/padding_top-expected.txt:
  • platform/mac/css1/box_properties/width-expected.txt:
  • platform/mac/css1/color_and_background/background_attachment-expected.txt:
  • platform/mac/css1/font_properties/font-expected.txt:
  • platform/mac/css1/font_properties/font_size-expected.txt:
  • platform/mac/css1/font_properties/font_weight-expected.txt:
  • platform/mac/css1/formatting_model/floating_elements-expected.txt:
  • platform/mac/css1/formatting_model/horizontal_formatting-expected.txt:
  • platform/mac/css1/formatting_model/inline_elements-expected.txt:
  • platform/mac/css1/formatting_model/replaced_elements-expected.txt:
  • platform/mac/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/mac/css1/text_properties/text_indent-expected.txt:
  • platform/mac/css1/text_properties/vertical_align-expected.txt:
  • platform/mac/css1/units/percentage_units-expected.txt:
  • platform/mac/css2.1/20110323/block-replaced-width-001-expected.txt:
  • platform/mac/css2.1/20110323/floating-replaced-height-008-expected.txt:
  • platform/mac/css2.1/20110323/inline-block-replaced-height-008-expected.txt:
  • platform/mac/css2.1/20110323/inline-replaced-height-008-expected.txt:
  • platform/mac/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt:
  • platform/mac/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt:
  • platform/mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
  • platform/mac/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
  • platform/mac/css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt:
  • platform/mac/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
  • platform/mac/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
  • platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt:
  • platform/mac/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
  • platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
  • platform/mac/css2.1/t1002-c5523-width-02-b-g-expected.txt:
  • platform/mac/css2.1/t100801-c544-valgn-00-a-ag-expected.txt:
  • platform/mac/css2.1/t100801-c544-valgn-02-d-agi-expected.txt:
  • platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
  • platform/mac/css2.1/t100801-c544-valgn-04-d-agi-expected.txt:
  • platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.txt:
  • platform/mac/css2.1/t1506-c525-font-wt-00-b-expected.txt:
  • platform/mac/css2.1/t1508-c527-font-09-b-expected.txt:
  • platform/mac/css2.1/t1602-c43-center-00-d-ag-expected.txt:
  • platform/mac/css3/flexbox/flexbox-baseline-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-25-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt:
  • platform/mac/css3/selectors3/html/css3-modsel-70-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
  • platform/mac/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-25-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt:
  • platform/mac/css3/selectors3/xml/css3-modsel-70-expected.txt:
  • platform/mac/css3/unicode-bidi-isolate-basic-expected.txt:
  • platform/mac/editing/inserting/before-after-input-element-expected.txt:
  • platform/mac/editing/inserting/editing-empty-divs-expected.txt:
  • platform/mac/editing/pasteboard/4806874-expected.txt:
  • platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
  • platform/mac/editing/pasteboard/drop-text-without-selection-expected.txt:
  • platform/mac/editing/pasteboard/input-field-1-expected.txt:
  • platform/mac/editing/selection/3690703-2-expected.txt:
  • platform/mac/editing/selection/3690703-expected.txt:
  • platform/mac/editing/selection/3690719-expected.txt:
  • platform/mac/editing/selection/4397952-expected.txt:
  • platform/mac/editing/selection/4895428-3-expected.txt:
  • platform/mac/editing/selection/4975120-expected.txt:
  • platform/mac/editing/selection/5240265-expected.txt:
  • platform/mac/editing/selection/5354455-2-expected.txt:
  • platform/mac/editing/selection/caret-ltr-2-expected.txt:
  • platform/mac/editing/selection/caret-ltr-2-left-expected.txt:
  • platform/mac/editing/selection/caret-ltr-expected.txt:
  • platform/mac/editing/selection/caret-ltr-right-expected.txt:
  • platform/mac/editing/selection/caret-rtl-2-expected.txt:
  • platform/mac/editing/selection/caret-rtl-2-left-expected.txt:
  • platform/mac/editing/selection/caret-rtl-expected.txt:
  • platform/mac/editing/selection/caret-rtl-right-expected.txt:
  • platform/mac/editing/selection/collapse-selection-in-bidi-expected.txt:
  • platform/mac/editing/selection/drag-select-1-expected.txt:
  • platform/mac/editing/selection/drag-start-event-client-x-y-expected.txt:
  • platform/mac/editing/selection/mixed-editability-10-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-2-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-3-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
  • platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
  • platform/mac/editing/selection/select-text-overflow-ellipsis-expected.txt:
  • platform/mac/editing/selection/selection-button-text-expected.txt:
  • platform/mac/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/mac/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/mac/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
  • platform/mac/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
  • platform/mac/fast/backgrounds/background-inherit-color-bug-expected.txt:
  • platform/mac/fast/backgrounds/background-position-parsing-expected.txt:
  • platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt:
  • platform/mac/fast/block/basic/001-expected.txt:
  • platform/mac/fast/block/basic/011-expected.txt:
  • platform/mac/fast/block/basic/014-expected.txt:
  • platform/mac/fast/block/basic/015-expected.txt:
  • platform/mac/fast/block/basic/016-expected.txt:
  • platform/mac/fast/block/basic/019-expected.txt:
  • platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
  • platform/mac/fast/block/float/013-expected.txt:
  • platform/mac/fast/block/float/025-expected.txt:
  • platform/mac/fast/block/float/026-expected.txt:
  • platform/mac/fast/block/float/027-expected.txt:
  • platform/mac/fast/block/float/028-expected.txt:
  • platform/mac/fast/block/float/032-expected.txt:
  • platform/mac/fast/block/float/centered-float-avoidance-complexity-expected.txt:
  • platform/mac/fast/block/float/float-avoidance-expected.txt:
  • platform/mac/fast/block/float/float-in-float-painting-expected.txt:
  • platform/mac/fast/block/float/nopaint-after-layer-destruction2-expected.txt:
  • platform/mac/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
  • platform/mac/fast/block/margin-collapse/100-expected.txt:
  • platform/mac/fast/block/margin-collapse/103-expected.txt:
  • platform/mac/fast/block/positioning/047-expected.txt:
  • platform/mac/fast/block/positioning/051-expected.txt:
  • platform/mac/fast/block/positioning/inline-block-relposition-expected.txt:
  • platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt:
  • platform/mac/fast/borders/bidi-002-expected.txt:
  • platform/mac/fast/borders/bidi-009a-expected.txt:
  • platform/mac/fast/borders/bidi-012-expected.txt:
  • platform/mac/fast/borders/fieldsetBorderRadius-expected.txt:
  • platform/mac/fast/borders/rtl-border-01-expected.txt:
  • platform/mac/fast/borders/rtl-border-02-expected.txt:
  • platform/mac/fast/borders/rtl-border-03-expected.txt:
  • platform/mac/fast/box-sizing/box-sizing-expected.txt:
  • platform/mac/fast/clip/overflow-border-radius-composited-expected.txt:
  • platform/mac/fast/clip/overflow-border-radius-transformed-expected.txt:
  • platform/mac/fast/css-generated-content/011-expected.txt:
  • platform/mac/fast/css-generated-content/012-expected.txt:
  • platform/mac/fast/css-generated-content/013-expected.txt:
  • platform/mac/fast/css-generated-content/014-expected.txt:
  • platform/mac/fast/css-generated-content/015-expected.txt:
  • platform/mac/fast/css-generated-content/details-summary-before-after-expected.txt:
  • platform/mac/fast/css-generated-content/inline-display-types-expected.txt:
  • platform/mac/fast/css/003-expected.txt:
  • platform/mac/fast/css/004-expected.txt:
  • platform/mac/fast/css/005-expected.txt:
  • platform/mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Removed.
  • platform/mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Removed.
  • platform/mac/fast/css/background-shorthand-invalid-url-expected.txt:
  • platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/mac/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt:
  • platform/mac/fast/css/continuationCrash-expected.txt:
  • platform/mac/fast/css/css1_forward_compatible_parsing-expected.txt:
  • platform/mac/fast/css/css2-system-fonts-expected.txt:
  • platform/mac/fast/css/empty-pseudo-class-expected.txt:
  • platform/mac/fast/css/ex-after-font-variant-expected.txt:
  • platform/mac/fast/css/fieldset-display-row-expected.txt:
  • platform/mac/fast/css/first-child-pseudo-class-expected.txt:
  • platform/mac/fast/css/first-line-text-decoration-expected.txt:
  • platform/mac/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
  • platform/mac/fast/css/first-of-type-pseudo-class-expected.txt:
  • platform/mac/fast/css/getComputedStyle/getComputedStyle-margin-percentage-expected.txt:
  • platform/mac/fast/css/h1-in-section-elements-expected.txt:
  • platform/mac/fast/css/hsl-color-expected.txt:
  • platform/mac/fast/css/hsla-color-expected.txt:
  • platform/mac/fast/css/inline-properties-important-expected.txt:
  • platform/mac/fast/css/input-search-padding-expected.txt:
  • platform/mac/fast/css/invalid-percentage-property-expected.txt:
  • platform/mac/fast/css/last-child-pseudo-class-expected.txt:
  • platform/mac/fast/css/last-of-type-pseudo-class-expected.txt:
  • platform/mac/fast/css/line-height-expected.txt:
  • platform/mac/fast/css/margin-top-bottom-dynamic-expected.txt:
  • platform/mac/fast/css/non-standard-checkbox-size-expected.txt:
  • platform/mac/fast/css/only-child-pseudo-class-expected.txt:
  • platform/mac/fast/css/only-of-type-pseudo-class-expected.txt:
  • platform/mac/fast/css/percentage-non-integer-expected.txt:
  • platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt:
  • platform/mac/fast/css/rgb-float-expected.txt:
  • platform/mac/fast/css/rtl-ordering-expected.txt:
  • platform/mac/fast/css/selector-set-attribute-expected.txt:
  • platform/mac/fast/css/text-align-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-strict-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-text-align-left-expected.txt:
  • platform/mac/fast/css/text-overflow-ellipsis-text-align-right-expected.txt:
  • platform/mac/fast/css/text-overflow-input-expected.txt:
  • platform/mac/fast/css/transform-default-parameter-expected.txt:
  • platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
  • platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt:
  • platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt:
  • platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt:
  • platform/mac/fast/css/word-space-extra-expected.txt:
  • platform/mac/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt: Added.
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
  • platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
  • platform/mac/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt:
  • platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
  • platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
  • platform/mac/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
  • platform/mac/fast/dom/clone-node-dynamic-style-expected.txt:
  • platform/mac/fast/dom/isindex-001-expected.txt:
  • platform/mac/fast/dom/isindex-002-expected.txt:
  • platform/mac/fast/dynamic/012-expected.txt:
  • platform/mac/fast/dynamic/anchor-lock-expected.txt:
  • platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
  • platform/mac/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/mac/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/mac/fast/events/context-no-deselect-expected.txt:
  • platform/mac/fast/events/document-elementFromPoint-expected.txt:
  • platform/mac/fast/events/pointer-events-2-expected.txt:
  • platform/mac/fast/flexbox/flex-hang-expected.txt:
  • platform/mac/fast/forms/001-expected.txt:
  • platform/mac/fast/forms/006-expected.txt:
  • platform/mac/fast/forms/007-expected.txt:
  • platform/mac/fast/forms/basic-buttons-expected.txt:
  • platform/mac/fast/forms/basic-inputs-expected.txt:
  • platform/mac/fast/forms/basic-textareas-expected.txt:
  • platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
  • platform/mac/fast/forms/blankbuttons-expected.txt:
  • platform/mac/fast/forms/box-shadow-override-expected.txt:
  • platform/mac/fast/forms/button-cannot-be-nested-expected.txt:
  • platform/mac/fast/forms/button-default-title-expected.txt:
  • platform/mac/fast/forms/button-generated-content-expected.txt:
  • platform/mac/fast/forms/button-positioned-expected.txt:
  • platform/mac/fast/forms/button-sizes-expected.txt:
  • platform/mac/fast/forms/button-style-color-expected.txt:
  • platform/mac/fast/forms/button-table-styles-expected.txt:
  • platform/mac/fast/forms/button-text-transform-expected.txt:
  • platform/mac/fast/forms/button-white-space-expected.txt:
  • platform/mac/fast/forms/color/input-appearance-color-expected.txt:
  • platform/mac/fast/forms/control-restrict-line-height-expected.txt:
  • platform/mac/fast/forms/encoding-test-expected.txt:
  • platform/mac/fast/forms/fieldset-align-expected.txt:
  • platform/mac/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added.
  • platform/mac/fast/forms/fieldset-with-float-expected.txt:
  • platform/mac/fast/forms/file/file-input-direction-expected.txt:
  • platform/mac/fast/forms/file/file-input-disabled-expected.txt:
  • platform/mac/fast/forms/file/input-file-re-render-expected.txt:
  • platform/mac/fast/forms/float-before-fieldset-expected.txt:
  • platform/mac/fast/forms/form-element-geometry-expected.txt:
  • platform/mac/fast/forms/formmove-expected.txt:
  • platform/mac/fast/forms/formmove2-expected.txt:
  • platform/mac/fast/forms/formmove3-expected.txt:
  • platform/mac/fast/forms/indeterminate-expected.txt:
  • platform/mac/fast/forms/input-align-expected.txt:
  • platform/mac/fast/forms/input-appearance-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-default-bkcolor-expected.txt:
  • platform/mac/fast/forms/input-appearance-disabled-expected.txt:
  • platform/mac/fast/forms/input-appearance-focus-expected.txt:
  • platform/mac/fast/forms/input-appearance-height-expected.txt:
  • platform/mac/fast/forms/input-appearance-preventDefault-expected.txt:
  • platform/mac/fast/forms/input-appearance-readonly-expected.txt:
  • platform/mac/fast/forms/input-appearance-selection-expected.txt:
  • platform/mac/fast/forms/input-appearance-visibility-expected.txt:
  • platform/mac/fast/forms/input-appearance-width-expected.txt:
  • platform/mac/fast/forms/input-baseline-expected.txt:
  • platform/mac/fast/forms/input-button-sizes-expected.txt:
  • platform/mac/fast/forms/input-disabled-color-expected.txt:
  • platform/mac/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-1-expected.txt:
  • platform/mac/fast/forms/input-placeholder-visibility-3-expected.txt:
  • platform/mac/fast/forms/input-readonly-autoscroll-expected.txt:
  • platform/mac/fast/forms/input-readonly-dimmed-expected.txt:
  • platform/mac/fast/forms/input-readonly-empty-expected.txt:
  • platform/mac/fast/forms/input-spaces-expected.txt:
  • platform/mac/fast/forms/input-table-expected.txt:
  • platform/mac/fast/forms/input-text-click-inside-expected.txt:
  • platform/mac/fast/forms/input-text-click-outside-expected.txt:
  • platform/mac/fast/forms/input-text-double-click-expected.txt:
  • platform/mac/fast/forms/input-text-drag-down-expected.txt:
  • platform/mac/fast/forms/input-text-option-delete-expected.txt:
  • platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt:
  • platform/mac/fast/forms/input-text-self-emptying-click-expected.txt:
  • platform/mac/fast/forms/input-text-word-wrap-expected.txt:
  • platform/mac/fast/forms/input-value-expected.txt:
  • platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
  • platform/mac/fast/forms/listbox-hit-test-zoomed-expected.txt:
  • platform/mac/fast/forms/menulist-clip-expected.txt:
  • platform/mac/fast/forms/minWidthPercent-expected.txt:
  • platform/mac/fast/forms/number/number-appearance-rtl-expected.txt:
  • platform/mac/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
  • platform/mac/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:
  • platform/mac/fast/forms/placeholder-position-expected.txt:
  • platform/mac/fast/forms/placeholder-pseudo-style-expected.txt:
  • platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/mac/fast/forms/range/input-appearance-range-expected.txt:
  • platform/mac/fast/forms/search-cancel-button-style-sharing-expected.txt:
  • platform/mac/fast/forms/search-display-none-cancel-button-expected.txt:
  • platform/mac/fast/forms/search-rtl-expected.txt:
  • platform/mac/fast/forms/search-vertical-alignment-expected.txt:
  • platform/mac/fast/forms/search/search-size-with-decorations-expected.txt:
  • platform/mac/fast/forms/searchfield-heights-expected.txt:
  • platform/mac/fast/forms/select-baseline-expected.txt:
  • platform/mac/fast/forms/tabbing-input-iframe-expected.txt:
  • platform/mac/fast/forms/targeted-frame-submission-expected.txt:
  • platform/mac/fast/forms/text-style-color-expected.txt:
  • platform/mac/fast/forms/textAreaLineHeight-expected.txt:
  • platform/mac/fast/forms/textfield-focus-ring-expected.txt:
  • platform/mac/fast/forms/textfield-overflow-expected.txt:
  • platform/mac/fast/forms/validation-message-appearance-expected.txt:
  • platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
  • platform/mac/fast/frames/onlyCommentInIFrame-expected.txt:
  • platform/mac/fast/frames/take-focus-from-iframe-expected.txt:
  • platform/mac/fast/gradients/crash-on-zero-radius-expected.txt:
  • platform/mac/fast/gradients/generated-gradients-expected.txt:
  • platform/mac/fast/gradients/radial-centered-expected.txt:
  • platform/mac/fast/gradients/simple-gradients-expected.txt:
  • platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
  • platform/mac/fast/html/details-add-child-1-expected.txt:
  • platform/mac/fast/html/details-add-child-2-expected.txt:
  • platform/mac/fast/html/details-add-details-child-1-expected.txt:
  • platform/mac/fast/html/details-add-details-child-2-expected.txt:
  • platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-1-expected.txt:
  • platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-10-expected.txt:
  • platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-2-expected.txt:
  • platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-3-expected.txt:
  • platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-4-expected.txt:
  • platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-5-expected.txt:
  • platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-6-expected.txt:
  • platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-7-expected.txt:
  • platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-8-expected.txt:
  • platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
  • platform/mac/fast/html/details-add-summary-9-expected.txt:
  • platform/mac/fast/html/details-add-summary-child-1-expected.txt:
  • platform/mac/fast/html/details-add-summary-child-2-expected.txt:
  • platform/mac/fast/html/details-marker-style-expected.txt:
  • platform/mac/fast/html/details-nested-1-expected.txt:
  • platform/mac/fast/html/details-nested-2-expected.txt:
  • platform/mac/fast/html/details-no-summary1-expected.txt:
  • platform/mac/fast/html/details-no-summary2-expected.txt:
  • platform/mac/fast/html/details-no-summary3-expected.txt:
  • platform/mac/fast/html/details-no-summary4-expected.txt:
  • platform/mac/fast/html/details-open-javascript-expected.txt:
  • platform/mac/fast/html/details-open1-expected.txt:
  • platform/mac/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-open3-expected.txt:
  • platform/mac/fast/html/details-open4-expected.txt:
  • platform/mac/fast/html/details-open5-expected.txt:
  • platform/mac/fast/html/details-open6-expected.txt:
  • platform/mac/fast/html/details-position-expected.txt:
  • platform/mac/fast/html/details-remove-child-1-expected.txt:
  • platform/mac/fast/html/details-remove-child-2-expected.txt:
  • platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-1-expected.txt:
  • platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-2-expected.txt:
  • platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-3-expected.txt:
  • platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-4-expected.txt:
  • platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-5-expected.txt:
  • platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
  • platform/mac/fast/html/details-remove-summary-6-expected.txt:
  • platform/mac/fast/html/details-remove-summary-child-1-expected.txt:
  • platform/mac/fast/html/details-remove-summary-child-2-expected.txt:
  • platform/mac/fast/html/details-replace-summary-child-expected.txt:
  • platform/mac/fast/html/details-replace-text-expected.txt:
  • platform/mac/fast/html/details-writing-mode-expected.txt:
  • platform/mac/fast/images/imagemap-focus-ring-zoom-expected.txt:
  • platform/mac/fast/images/repaint-subrect-grid-expected.txt:
  • platform/mac/fast/images/zoomed-img-size-expected.txt:
  • platform/mac/fast/inline-block/inline-block-vertical-align-expected.txt:
  • platform/mac/fast/inline/002-expected.txt:
  • platform/mac/fast/inline/continuation-outlines-expected.txt:
  • platform/mac/fast/inline/continuation-outlines-with-layers-expected.txt:
  • platform/mac/fast/inline/inline-borders-with-bidi-override-expected.txt:
  • platform/mac/fast/inline/inline-box-background-expected.txt:
  • platform/mac/fast/inline/inline-box-background-long-image-expected.txt:
  • platform/mac/fast/inline/inline-box-background-repeat-x-expected.txt:
  • platform/mac/fast/inline/inline-box-background-repeat-y-expected.txt:
  • platform/mac/fast/inline/outline-continuations-expected.txt:
  • platform/mac/fast/inline/positionedLifetime-expected.txt:
  • platform/mac/fast/invalid/010-expected.txt:
  • platform/mac/fast/invalid/014-expected.txt:
  • platform/mac/fast/invalid/junk-data-expected.txt:
  • platform/mac/fast/invalid/missing-end-tag-expected.txt:
  • platform/mac/fast/invalid/nestedh3s-expected.txt:
  • platform/mac/fast/layers/video-layer-expected.txt:
  • platform/mac/fast/line-grid/line-align-left-edges-expected.txt:
  • platform/mac/fast/line-grid/line-grid-contains-value-expected.txt:
  • platform/mac/fast/lists/003-expected.txt:
  • platform/mac/fast/lists/003-vertical-expected.txt:
  • platform/mac/fast/lists/008-expected.txt:
  • platform/mac/fast/lists/008-vertical-expected.txt:
  • platform/mac/fast/lists/dynamic-marker-crash-expected.txt:
  • platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.txt:
  • platform/mac/fast/multicol/break-properties-expected.txt:
  • platform/mac/fast/multicol/client-rects-expected.txt:
  • platform/mac/fast/multicol/column-break-with-balancing-expected.txt:
  • platform/mac/fast/multicol/float-multicol-expected.txt:
  • platform/mac/fast/multicol/float-paginate-complex-expected.txt:
  • platform/mac/fast/multicol/layers-in-multicol-expected.txt:
  • platform/mac/fast/multicol/nested-columns-expected.txt:
  • platform/mac/fast/multicol/overflow-across-columns-expected.txt:
  • platform/mac/fast/multicol/overflow-across-columns-percent-height-expected.txt:
  • platform/mac/fast/multicol/overflow-unsplittable-expected.txt:
  • platform/mac/fast/multicol/scrolling-overflow-expected.txt:
  • platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
  • platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
  • platform/mac/fast/multicol/span/anonymous-style-inheritance-expected.txt:
  • platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
  • platform/mac/fast/multicol/span/clone-flexbox-expected.txt:
  • platform/mac/fast/multicol/span/clone-summary-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
  • platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
  • platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
  • platform/mac/fast/multicol/span/span-margin-collapsing-expected.txt:
  • platform/mac/fast/multicol/table-vertical-align-expected.txt:
  • platform/mac/fast/multicol/vertical-lr/break-properties-expected.txt:
  • platform/mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
  • platform/mac/fast/multicol/vertical-lr/float-multicol-expected.txt:
  • platform/mac/fast/multicol/vertical-lr/nested-columns-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/break-properties-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/float-multicol-expected.txt:
  • platform/mac/fast/multicol/vertical-rl/nested-columns-expected.txt:
  • platform/mac/fast/overflow/007-expected.txt:
  • platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
  • platform/mac/fast/overflow/overflow-rtl-expected.txt:
  • platform/mac/fast/overflow/overflow-rtl-vertical-expected.txt:
  • platform/mac/fast/overflow/overflow_hidden-expected.txt:
  • platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
  • platform/mac/fast/overflow/scrollRevealButton-expected.txt:
  • platform/mac/fast/parser/bad-xml-slash-expected.txt:
  • platform/mac/fast/parser/entity-comment-in-style-expected.txt:
  • platform/mac/fast/parser/style-script-head-test-expected.txt:
  • platform/mac/fast/parser/xhtml-alternate-entities-expected.txt:
  • platform/mac/fast/reflections/reflection-with-zoom-expected.txt:
  • platform/mac/fast/regions/floats-basic-in-variable-width-regions-expected.png: Added.
  • platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
  • platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.png: Added.
  • platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.png: Added.
  • platform/mac/fast/regions/overflow-size-change-in-variable-width-regions-expected.png: Added.
  • platform/mac/fast/regions/overflow-size-change-with-stacking-context-expected.png: Added.
  • platform/mac/fast/regions/repaint/line-flow-with-floats-in-regions-expected.txt:
  • platform/mac/fast/regions/selection/selecting-text-through-different-region-flows-expected.png: Added.
  • platform/mac/fast/repaint/control-clip-expected.txt:
  • platform/mac/fast/repaint/delete-into-nested-block-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-1-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-10-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-2-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-3-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-4-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-5-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-6-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-7-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-8-expected.txt:
  • platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt:
  • platform/mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
  • platform/mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
  • platform/mac/fast/repaint/search-field-cancel-expected.txt:
  • platform/mac/fast/repaint/subtree-root-skipped-expected.txt:
  • platform/mac/fast/repaint/transform-translate-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-expected.txt:
  • platform/mac/fast/replaced/replaced-breaking-mixture-expected.txt:
  • platform/mac/fast/replaced/table-percent-height-expected.txt:
  • platform/mac/fast/replaced/width100percent-button-expected.txt:
  • platform/mac/fast/replaced/width100percent-checkbox-expected.txt:
  • platform/mac/fast/replaced/width100percent-radio-expected.txt:
  • platform/mac/fast/replaced/width100percent-textarea-expected.txt:
  • platform/mac/fast/ruby/ruby-inline-table-expected.txt:
  • platform/mac/fast/selectors/032-expected.txt:
  • platform/mac/fast/selectors/166-expected.txt:
  • platform/mac/fast/selectors/unqualified-hover-quirks-expected.txt:
  • platform/mac/fast/selectors/unqualified-hover-strict-expected.txt:
  • platform/mac/fast/shapes/shape-inside/shape-inside-circle-expected.png: Added.
  • platform/mac/fast/shapes/shape-inside/shape-inside-circle-padding-expected.png: Added.
  • platform/mac/fast/shapes/shape-inside/shape-inside-ellipse-expected.png: Added.
  • platform/mac/fast/shapes/shape-inside/shape-inside-ellipse-padding-expected.png: Added.
  • platform/mac/fast/shapes/shape-inside/shape-inside-rounded-rectangle-fit-002-expected.png: Added.
  • platform/mac/fast/shapes/shape-inside/shape-inside-subpixel-rectangle-top-expected.png: Added.
  • platform/mac/fast/table/009-expected.txt:
  • platform/mac/fast/table/014-expected.txt:
  • platform/mac/fast/table/040-expected.txt:
  • platform/mac/fast/table/040-vertical-expected.txt:
  • platform/mac/fast/table/041-expected.txt:
  • platform/mac/fast/table/absolute-table-at-bottom-expected.txt:
  • platform/mac/fast/table/append-cells2-expected.txt:
  • platform/mac/fast/table/border-collapsing/004-expected.txt:
  • platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-expected.txt:
  • platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/mac/fast/table/frame-and-rules-expected.txt:
  • platform/mac/fast/table/mozilla-bug10296-vertical-align-1-expected.txt:
  • platform/mac/fast/table/mozilla-bug10296-vertical-align-2-expected.txt:
  • platform/mac/fast/table/nested-percent-height-table-expected.txt:
  • platform/mac/fast/table/overflowHidden-expected.txt:
  • platform/mac/fast/table/percent-heights-expected.txt:
  • platform/mac/fast/table/remove-td-display-none-expected.txt:
  • platform/mac/fast/table/spanOverlapRepaint-expected.txt:
  • platform/mac/fast/table/table-display-types-strict-expected.txt:
  • platform/mac/fast/table/table-hspace-align-center-expected.txt:
  • platform/mac/fast/table/text-field-baseline-expected.txt:
  • platform/mac/fast/text/basic/012-expected.txt:
  • platform/mac/fast/text/basic/013-expected.txt:
  • platform/mac/fast/text/basic/generic-family-reset-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/mac/fast/text/line-breaks-expected.txt:
  • platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/mac/fast/text/vertical-rl-rtl-linebreak-expected.txt:
  • platform/mac/fast/text/whitespace/024-expected.txt:
  • platform/mac/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
  • platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
  • platform/mac/fast/transforms/bounding-rect-zoom-expected.txt:
  • platform/mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt:
  • platform/mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt:
  • platform/mac/fast/transforms/transformed-focused-text-input-expected.txt:
  • platform/mac/fast/transforms/transforms-with-zoom-expected.txt:
  • platform/mac/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
  • platform/mac/fast/writing-mode/broken-ideographic-font-expected.txt:
  • platform/mac/fast/writing-mode/fieldsets-expected.txt:
  • platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt:
  • platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
  • platform/mac/http/tests/misc/acid3-expected.txt:
  • platform/mac/http/tests/misc/iframe404-expected.txt:
  • platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
  • platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt:
  • platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt:
  • platform/mac/mathml/presentation/mo-stretch-expected.txt:
  • platform/mac/media/audio-controls-rendering-expected.txt:
  • platform/mac/media/controls-after-reload-expected.txt:
  • platform/mac/media/controls-strict-expected.txt:
  • platform/mac/media/controls-styling-strict-expected.txt:
  • platform/mac/media/controls-without-preload-expected.txt:
  • platform/mac/media/media-controls-clone-expected.txt:
  • platform/mac/media/video-no-audio-expected.txt:
  • platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-expected.txt:
  • platform/mac/platform/mac/fast/forms/input-appearance-spinbutton-up-expected.txt:
  • platform/mac/platform/mac/fast/text/vertical-no-sideways-expected.txt:
  • platform/mac/platform/mac/fast/text/x-height-expected.txt: Added.
  • platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt:
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt:
  • platform/mac/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt:
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt:
  • platform/mac/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt:
  • platform/mac/svg/W3C-I18N/text-anchor-no-markup-expected.txt:
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt:
  • platform/mac/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt:
  • platform/mac/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-direction-ltr-expected.txt:
  • platform/mac/svg/W3C-I18N/tspan-direction-rtl-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-12-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-15-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-16-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-17-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-19-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-33-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-37-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-41-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/interact-events-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/interact-order-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-13-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-dom-06-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-04-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-05-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-06-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-align-08-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-path-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-03-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-07-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-text-08-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-ws-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/text-ws-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt:
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-01-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-02-t-expected.txt:
  • platform/mac/svg/W3C-SVG-1.2-Tiny/struct-use-recursion-03-t-expected.txt:
  • platform/mac/svg/as-border-image/svg-as-border-image-2-expected.txt:
  • platform/mac/svg/as-border-image/svg-as-border-image-expected.txt:
  • platform/mac/svg/as-image/img-preserveAspectRatio-support-2-expected.txt:
  • platform/mac/svg/as-image/svg-non-integer-scaled-image-expected.txt:
  • platform/mac/svg/batik/filters/filterRegions-expected.txt:
  • platform/mac/svg/batik/paints/patternPreserveAspectRatioA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegionA-expected.txt:
  • platform/mac/svg/batik/paints/patternRegions-expected.txt:
  • platform/mac/svg/batik/text/smallFonts-expected.txt:
  • platform/mac/svg/batik/text/textAnchor-expected.txt:
  • platform/mac/svg/batik/text/textAnchor2-expected.txt:
  • platform/mac/svg/batik/text/textAnchor3-expected.txt:
  • platform/mac/svg/batik/text/textDecoration2-expected.txt:
  • platform/mac/svg/batik/text/textEffect2-expected.txt:
  • platform/mac/svg/batik/text/textEffect3-expected.txt:
  • platform/mac/svg/batik/text/textFeatures-expected.txt:
  • platform/mac/svg/batik/text/textGlyphOrientationHorizontal-expected.txt:
  • platform/mac/svg/batik/text/textLayout-expected.txt:
  • platform/mac/svg/batik/text/textLayout2-expected.txt:
  • platform/mac/svg/batik/text/textOnPath2-expected.txt:
  • platform/mac/svg/batik/text/textOnPath3-expected.txt:
  • platform/mac/svg/batik/text/textOnPathSpaces-expected.txt:
  • platform/mac/svg/batik/text/textPCDATA-expected.txt:
  • platform/mac/svg/batik/text/textPosition2-expected.txt: Added.
  • platform/mac/svg/batik/text/textProperties-expected.txt:
  • platform/mac/svg/batik/text/textProperties2-expected.txt:
  • platform/mac/svg/batik/text/textStyles-expected.txt:
  • platform/mac/svg/batik/text/xmlSpace-expected.txt:
  • platform/mac/svg/carto.net/button-expected.txt:
  • platform/mac/svg/carto.net/colourpicker-expected.txt:
  • platform/mac/svg/carto.net/combobox-expected.txt:
  • platform/mac/svg/carto.net/scrollbar-expected.txt:
  • platform/mac/svg/carto.net/selectionlist-expected.txt:
  • platform/mac/svg/carto.net/slider-expected.txt:
  • platform/mac/svg/carto.net/tabgroup-expected.txt:
  • platform/mac/svg/carto.net/textbox-expected.txt:
  • platform/mac/svg/carto.net/window-expected.txt:
  • platform/mac/svg/clip-path/clip-path-pixelation-expected.txt:
  • platform/mac/svg/css/shadow-changes-expected.txt:
  • platform/mac/svg/css/text-shadow-multiple-expected.txt:
  • platform/mac/svg/custom/SVGPoint-matrixTransform-expected.txt:
  • platform/mac/svg/custom/bug45331-expected.txt:
  • platform/mac/svg/custom/dominant-baseline-hanging-expected.txt:
  • platform/mac/svg/custom/dominant-baseline-modes-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Discrete-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Gamma-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Linear-expected.txt:
  • platform/mac/svg/custom/feComponentTransfer-Table-expected.txt:
  • platform/mac/svg/custom/font-face-cascade-order-expected.txt:
  • platform/mac/svg/custom/font-face-simple-expected.txt:
  • platform/mac/svg/custom/fractional-rects-expected.txt:
  • platform/mac/svg/custom/getTransformToElement-expected.txt:
  • platform/mac/svg/custom/glyph-setting-d-attribute-expected.txt:
  • platform/mac/svg/custom/gradient-with-1d-boundingbox-expected.txt:
  • platform/mac/svg/custom/image-parent-translation-expected.txt:
  • platform/mac/svg/custom/image-small-width-height-expected.txt:
  • platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
  • platform/mac/svg/custom/invalid-css-expected.txt:
  • platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-gradient-creation-expected.txt:
  • platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.txt:
  • platform/mac/svg/custom/js-late-pattern-creation-expected.txt:
  • platform/mac/svg/custom/js-update-container-expected.txt:
  • platform/mac/svg/custom/junk-data-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-preserveAspectRatio-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-transform-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-viewTarget-expected.txt:
  • platform/mac/svg/custom/linking-a-03-b-zoomAndPan-expected.txt:
  • platform/mac/svg/custom/linking-uri-01-b-expected.txt:
  • platform/mac/svg/custom/marker-default-width-height-expected.txt:
  • platform/mac/svg/custom/missing-xlink-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-container-expected.txt:
  • platform/mac/svg/custom/mouse-move-on-svg-container-standalone-expected.txt:
  • platform/mac/svg/custom/object-sizing-expected.txt:
  • platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
  • platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
  • platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt:
  • platform/mac/svg/custom/path-bad-data-expected.txt:
  • platform/mac/svg/custom/path-textPath-simulation-expected.txt:
  • platform/mac/svg/custom/pattern-incorrect-tiling-expected.txt:
  • platform/mac/svg/custom/pattern-rotate-expected.txt:
  • platform/mac/svg/custom/pattern-rotate-gaps-expected.txt:
  • platform/mac/svg/custom/pattern-with-transformation-expected.txt:
  • platform/mac/svg/custom/pointer-events-text-css-transform-expected.txt:
  • platform/mac/svg/custom/rootmost-svg-xy-attrs-expected.txt:
  • platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
  • platform/mac/svg/custom/shapes-supporting-markers-expected.txt:
  • platform/mac/svg/custom/stroked-pattern-expected.txt: Added.
  • platform/mac/svg/custom/style-attribute-font-size-expected.txt:
  • platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
  • platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
  • platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
  • platform/mac/svg/custom/text-clip-expected.txt:
  • platform/mac/svg/custom/text-ctm-expected.txt:
  • platform/mac/svg/custom/text-dom-01-f-expected.txt:
  • platform/mac/svg/custom/text-filter-expected.txt:
  • platform/mac/svg/custom/text-hit-test-expected.txt:
  • platform/mac/svg/custom/text-letter-spacing-expected.txt:
  • platform/mac/svg/custom/text-repaint-including-stroke-expected.txt:
  • platform/mac/svg/custom/text-rotation-expected.txt:
  • platform/mac/svg/custom/text-tref-03-b-change-href-dom-expected.txt:
  • platform/mac/svg/custom/text-tref-03-b-change-href-expected.txt:
  • platform/mac/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt:
  • platform/mac/svg/custom/text-tref-03-b-tref-removal-expected.txt:
  • platform/mac/svg/custom/text-whitespace-handling-expected.txt:
  • platform/mac/svg/custom/text-x-dx-lists-expected.txt:
  • platform/mac/svg/custom/text-x-dy-lists-expected.txt:
  • platform/mac/svg/custom/text-x-override-in-tspan-child-expected.txt:
  • platform/mac/svg/custom/tref-own-content-removal-expected.txt:
  • platform/mac/svg/custom/tref-update-expected.txt:
  • platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt:
  • platform/mac/svg/custom/use-detach-expected.txt:
  • platform/mac/svg/custom/use-dynamic-append-expected.txt:
  • platform/mac/svg/custom/use-font-face-crash-expected.txt:
  • platform/mac/svg/custom/use-modify-container-in-target-expected.txt:
  • platform/mac/svg/custom/use-modify-target-container-expected.txt:
  • platform/mac/svg/custom/use-modify-target-symbol-expected.txt:
  • platform/mac/svg/custom/use-recursion-1-expected.txt:
  • platform/mac/svg/custom/use-recursion-2-expected.txt:
  • platform/mac/svg/custom/use-recursion-3-expected.txt:
  • platform/mac/svg/custom/use-recursion-4-expected.txt:
  • platform/mac/svg/custom/viewBox-hit-expected.txt:
  • platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
  • platform/mac/svg/hixie/error/002-expected.txt:
  • platform/mac/svg/hixie/error/012-expected.txt:
  • platform/mac/svg/hixie/error/013-expected.txt:
  • platform/mac/svg/hixie/perf/001-expected.txt:
  • platform/mac/svg/hixie/perf/002-expected.txt:
  • platform/mac/svg/hixie/perf/003-expected.txt:
  • platform/mac/svg/hixie/perf/004-expected.txt: Added.
  • platform/mac/svg/hixie/perf/005-expected.txt: Added.
  • platform/mac/svg/hixie/perf/006-expected.txt: Added.
  • platform/mac/svg/hixie/perf/007-expected.txt:
  • platform/mac/svg/hixie/text/001-expected.txt:
  • platform/mac/svg/hixie/text/003-expected.txt:
  • platform/mac/svg/hixie/text/003a-expected.txt:
  • platform/mac/svg/hixie/text/003b-expected.txt:
  • platform/mac/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
  • platform/mac/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:
  • platform/mac/svg/text/append-text-node-to-tspan-expected.txt:
  • platform/mac/svg/text/bidi-embedded-direction-expected.txt:
  • platform/mac/svg/text/bidi-reorder-value-lists-expected.txt:
  • platform/mac/svg/text/bidi-text-query-expected.txt:
  • platform/mac/svg/text/bidi-tspans-expected.txt:
  • platform/mac/svg/text/font-size-below-point-five-expected.txt:
  • platform/mac/svg/text/modify-text-node-in-tspan-expected.txt:
  • platform/mac/svg/text/non-bmp-positioning-lists-expected.txt:
  • platform/mac/svg/text/remove-text-node-from-tspan-expected.txt:
  • platform/mac/svg/text/remove-tspan-from-text-expected.txt:
  • platform/mac/svg/text/scaled-font-expected.txt:
  • platform/mac/svg/text/scaling-font-with-geometric-precision-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-1-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-3-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-squeeze-4-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-stretch-1-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-stretch-2-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-stretch-3-expected.txt:
  • platform/mac/svg/text/select-textLength-spacing-stretch-4-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.txt:
  • platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
  • platform/mac/svg/text/select-x-list-1-expected.txt:
  • platform/mac/svg/text/select-x-list-2-expected.txt:
  • platform/mac/svg/text/select-x-list-3-expected.txt:
  • platform/mac/svg/text/select-x-list-4-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-1-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-2-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-3-expected.txt:
  • platform/mac/svg/text/select-x-list-with-tspans-4-expected.txt:
  • platform/mac/svg/text/selection-doubleclick-expected.txt:
  • platform/mac/svg/text/selection-tripleclick-expected.txt: Copied from LayoutTests/platform/mac/svg/text/selection-doubleclick-expected.txt.
  • platform/mac/svg/text/small-fonts-2-expected.txt:
  • platform/mac/svg/text/small-fonts-3-expected.txt:
  • platform/mac/svg/text/small-fonts-expected.txt:
  • platform/mac/svg/text/small-fonts-in-html5-expected.txt:
  • platform/mac/svg/text/text-align-01-b-expected.txt:
  • platform/mac/svg/text/text-align-02-b-expected.txt:
  • platform/mac/svg/text/text-align-03-b-expected.txt:
  • platform/mac/svg/text/text-align-04-b-expected.txt:
  • platform/mac/svg/text/text-align-05-b-expected.txt:
  • platform/mac/svg/text/text-align-06-b-expected.txt:
  • platform/mac/svg/text/text-altglyph-01-b-expected.txt:
  • platform/mac/svg/text/text-deco-01-b-expected.txt:
  • platform/mac/svg/text/text-fonts-01-t-expected.txt:
  • platform/mac/svg/text/text-fonts-02-t-expected.txt:
  • platform/mac/svg/text/text-hkern-expected.txt:
  • platform/mac/svg/text/text-intro-05-t-expected.txt:
  • platform/mac/svg/text/text-midpoint-split-bug-expected.txt:
  • platform/mac/svg/text/text-overflow-ellipsis-svgfont-expected.txt:
  • platform/mac/svg/text/text-overflow-ellipsis-svgfont-kerning-ligatures-expected.txt:
  • platform/mac/svg/text/text-path-01-b-expected.txt:
  • platform/mac/svg/text/text-path-middle-align-expected.txt:
  • platform/mac/svg/text/text-repaint-rects-expected.txt:
  • platform/mac/svg/text/text-spacing-01-b-expected.txt:
  • platform/mac/svg/text/text-text-01-b-expected.txt:
  • platform/mac/svg/text/text-text-03-b-expected.txt:
  • platform/mac/svg/text/text-text-04-t-expected.txt:
  • platform/mac/svg/text/text-text-05-t-expected.txt:
  • platform/mac/svg/text/text-text-06-t-expected.txt:
  • platform/mac/svg/text/text-text-07-t-expected.txt:
  • platform/mac/svg/text/text-text-08-b-expected.txt:
  • platform/mac/svg/text/text-tref-01-b-expected.txt:
  • platform/mac/svg/text/text-tselect-01-b-expected.txt:
  • platform/mac/svg/text/text-tselect-02-f-expected.txt:
  • platform/mac/svg/text/text-tspan-01-b-expected.txt:
  • platform/mac/svg/text/text-viewbox-rescale-expected.txt:
  • platform/mac/svg/text/text-ws-01-t-expected.txt:
  • platform/mac/svg/text/text-ws-02-t-expected.txt:
  • platform/mac/svg/transforms/animated-path-inside-transformed-html-expected.txt:
  • platform/mac/svg/transforms/svg-css-transforms-clip-path-expected.txt:
  • platform/mac/svg/transforms/svg-css-transforms-expected.txt:
  • platform/mac/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
  • platform/mac/svg/wicd/rightsizing-grid-expected.txt:
  • platform/mac/svg/wicd/sizing-flakiness-expected.txt:
  • platform/mac/svg/wicd/test-rightsizing-a-expected.txt:
  • platform/mac/svg/wicd/test-rightsizing-b-expected.txt:
  • platform/mac/svg/wicd/test-scalable-background-image1-expected.txt:
  • platform/mac/svg/wicd/test-scalable-background-image2-expected.txt:
  • platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt:
  • platform/mac/svg/zoom/page/zoom-background-images-expected.txt:
  • platform/mac/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt:
  • platform/mac/svg/zoom/page/zoom-foreignObject-expected.txt:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
  • platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
  • platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
  • platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
  • platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-as-image-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-as-object-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-as-relative-image-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
  • platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
  • platform/mac/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
  • platform/mac/svg/zoom/text/zoom-foreignObject-expected.txt:
  • platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
  • platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
  • platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug10269-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug10296-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug1055-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug106816-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug113235-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug113424-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug11384q-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug11384s-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug12384-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug126742-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug131020-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug13118-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug139524-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug159108-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug17130-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug17130-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug17138-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug19061-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug19061-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug26553-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug2886-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug3309-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug3309-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug33137-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug42187-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4284-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4382-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4429-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46480-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug46480-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug52505-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug52506-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug5538-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug60749-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug6304-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug67915-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug69187-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug7112-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug7112-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug73321-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug8032-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug83786-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug8381-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug9271-1-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug9271-2-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/mac/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/mac/tables/mozilla/core/bloomberg-expected.txt:
  • platform/mac/tables/mozilla/core/margins-expected.txt:
  • platform/mac/tables/mozilla/core/misc-expected.txt:
  • platform/mac/tables/mozilla/dom/tableDom-expected.txt:
  • platform/mac/tables/mozilla/marvin/backgr_index-expected.txt:
  • platform/mac/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • platform/mac/tables/mozilla/marvin/backgr_position-table-expected.txt:
  • platform/mac/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • platform/mac/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • platform/mac/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • platform/mac/tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • platform/mac/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • platform/mac/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • platform/mac/tables/mozilla/other/move_row-expected.txt:
  • platform/mac/tables/mozilla/other/test3-expected.txt:
  • platform/mac/tables/mozilla/other/test6-expected.txt:
  • platform/mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt: Added.
  • platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug3166-18-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug61042-1-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug61042-2-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/core/captions3-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/core/standards1-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
  • platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
  • platform/mac/transforms/2d/hindi-rotated-expected.txt:
  • platform/mac/transforms/2d/zoom-menulist-expected.txt:
  • platform/mac/transforms/3d/general/perspective-non-layer-expected.txt:
  • platform/mac/transforms/svg-vs-css-expected.txt:
9:19 AM Changeset in webkit [161883] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Fix Windows build.

  • wtf/ThreadingWin.cpp:

(WTF::initializeThreading):

9:17 AM Changeset in webkit [161882] by Alan Bujtas
  • 8 edits in trunk/Source

Enable SUBPIXEL_LAYOUT on Mac
<https://webkit.org/b/126283>

Reviewed by Simon Fraser.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:
8:47 AM Changeset in webkit [161881] by commit-queue@webkit.org
  • 9 edits in trunk/Tools

Remove wdiff
https://bugs.webkit.org/show_bug.cgi?id=124766

Patch by Daniel Batyai <Dániel Bátyai> on 2014-01-13
Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/common/net/resultsjsonparser_unittest.py:

(ResultsJSONParserTest):

  • Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:

(TestResultWriter):
(TestResultWriter.create_text_diff_and_write_result):

  • Scripts/webkitpy/layout_tests/models/test_run_results.py:

(summarize_results):

  • Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:

(RunTest.test_output_diffs):

  • Scripts/webkitpy/port/base.py:

(Port.init):
(Port.driver_stop_timeout):
(Port.check_image_diff):
(Port.repository_paths):
(Port._path_to_lighttpd_php):

  • Scripts/webkitpy/port/base_unittest.py:

(PortTest.test_default_child_processes):
(PortTest.test_pretty_patch_script_error):

  • Scripts/webkitpy/port/port_testcase.py:

(PortTestCase.test_diff_image_crashed):

  • Scripts/webkitpy/port/test.py:

(TestPort.operating_system):

8:40 AM Changeset in webkit [161880] by Martin Robinson
  • 2 edits in trunk/Tools

Build fix for the GTK+ CMake port

  • TestWebKitAPI/PlatformGTK.cmake: The WKConnection test is no longer with us.
8:38 AM Changeset in webkit [161879] by andersca@apple.com
  • 5 edits
    1 add in trunk/Source/WTF

Remove AtomicallyInitializedStatic
https://bugs.webkit.org/show_bug.cgi?id=126864

Reviewed by Andreas Kling.

Remove the lockAtomicallyInitializedStaticMutex and unlockAtomicallyInitializedStaticMutex functions
everywhere except on Mac (where they unfortunately were used by Safari).

On Mac, add them to a separate file which will hold functions and symbols that we would like
to remove but that are used by Safari. Reimplement them in terms of std::call_once and std::mutex.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/Threading.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):

  • wtf/ThreadingWin.cpp:

(WTF::initializeThreading):

  • wtf/mac/DeprecatedSymbolsUsedBySafari.mm: Added.

(WTF::atomicallyInitializedStaticMutex):
(WTF::lockAtomicallyInitializedStaticMutex):
(WTF::unlockAtomicallyInitializedStaticMutex):

8:15 AM Changeset in webkit [161878] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION(r161715): Use of uninitialized value $ENV{"PLATFORM_NAME"}
https://bugs.webkit.org/show_bug.cgi?id=126873

Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-01-13
Reviewed by Csaba Osztrogonác.

  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

6:33 AM Changeset in webkit [161877] by akling@apple.com
  • 5 edits in trunk/Source/WebCore

CTTE: Autoscroll renderer is always a RenderBox.
<https://webkit.org/b/126884>

Reviewed by Antti Koivisto.

  • page/EventHandler.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::autoscrollRenderer):

Make autoscrollRenderer() return a RenderBox*.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::willBeDestroyed):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::willBeDestroyed):

Only check if the autoscroll renderer is being torn down
in RenderBox::willBeDestroyed() since it's not relevant for
other renderer types.

5:29 AM WebKitEFLLayoutTest edited by k.wolanski@samsung.com
(diff)
4:52 AM Changeset in webkit [161876] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

Text should be constructable.
https://bugs.webkit.org/show_bug.cgi?id=115640

Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-01-13
Reviewed by Csaba Osztrogonác.

Source/WebCore:

http://dom.spec.whatwg.org/#interface-text
Make Text constructable so that one can do "new Text('abc')"
instead of "document.createTexte('abc')".

Backported from Blink: https://chromium.googlesource.com/chromium/blink/+/cdd5a914daf3862379a5ce4596149bd690d0fa08

Test: fast/dom/Text/text-constructor.html

  • dom/Text.cpp:

(WebCore::Text::create):

  • dom/Text.h:
  • dom/Text.idl:

LayoutTests:

  • fast/dom/Text/text-constructor-expected.txt: Added.
  • fast/dom/Text/text-constructor.html: Added.
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
3:50 AM Changeset in webkit [161875] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Add cast in call to g_object_add_weak_pointer in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=126881

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2014-01-13
Reviewed by Carlos Garcia Campos.

  • MiniBrowser/gtk/BrowserWindow.c:

(browser_window_new):
Explicitly cast GtkWindow to gpointer* in call to
g_object_add_weak_pointer to avoid compiler warnings.

3:29 AM Changeset in webkit [161874] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.3.4

Tagging the WebKitGTK+ 2.3.4 release

3:19 AM Changeset in webkit [161873] by zandobersek@gmail.com
  • 19 edits in trunk/Source/WebCore

Avoid unnecessary copies of AccessibilityObject::AccessibilityChildrenVector
https://bugs.webkit.org/show_bug.cgi?id=126876

Reviewed by Andreas Kling.

AccessibilityObject::children() returns a reference to the Vector of that AccessibilityObject's children.
The majority of callsites stores the return value in a temporary value instead of a reference, causing
a copy each time. A reference to the return value should be used instead.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::focusedImageMapUIElement):

  • accessibility/AccessibilityARIAGrid.cpp:

(WebCore::AccessibilityARIAGrid::addRowDescendant):

  • accessibility/AccessibilityARIAGridCell.cpp:

(WebCore::AccessibilityARIAGridCell::rowIndexRange):
(WebCore::AccessibilityARIAGridCell::columnIndexRange):

  • accessibility/AccessibilityARIAGridRow.cpp:

(WebCore::AccessibilityARIAGridRow::headerObject):

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::setSelectedChildren):

  • accessibility/AccessibilityListBox.h:
  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::insertChild):
(WebCore::AccessibilityNodeObject::selectedRadioButton):
(WebCore::AccessibilityNodeObject::selectedTabItem):

  • accessibility/AccessibilityObject.cpp:

(WebCore::appendChildrenToArray):
(WebCore::AccessibilityObject::ariaTreeRows):
(WebCore::AccessibilityObject::ariaTreeItemContent):
(WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
(WebCore::AccessibilityRenderObject::addRemoteSVGChildren):
(WebCore::AccessibilityRenderObject::addHiddenChildren):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityRenderObject::ariaListboxVisibleChildren):
(WebCore::AccessibilityRenderObject::tabChildren):
(WebCore::AccessibilityRenderObject::mathRadicandObject):
(WebCore::AccessibilityRenderObject::mathRootIndexObject):
(WebCore::AccessibilityRenderObject::mathNumeratorObject):
(WebCore::AccessibilityRenderObject::mathDenominatorObject):
(WebCore::AccessibilityRenderObject::mathUnderObject):
(WebCore::AccessibilityRenderObject::mathOverObject):
(WebCore::AccessibilityRenderObject::mathBaseObject):
(WebCore::AccessibilityRenderObject::mathSubscriptObject):
(WebCore::AccessibilityRenderObject::mathSuperscriptObject):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::cellForColumnAndRow):

  • accessibility/AccessibilityTableColumn.cpp:

(WebCore::AccessibilityTableColumn::headerObject):

  • accessibility/AccessibilityTableRow.cpp:

(WebCore::AccessibilityTableRow::headerObject):

  • accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::getListObject):
(WebCore::notifyChildrenSelectionChange):

  • accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp:

(webkitAccessibleHypertextGetLink):
(webkitAccessibleHypertextGetNLinks):

  • accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:

(listObjectForSelection):
(optionFromList):
(webkitAccessibleSelectionSelectAllSelection):

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(getNChildrenForTable):
(getChildForTable):
(webkitAccessibleRefChild):
(getIndexInParentForCellInRow):
(getInterfaceMaskFromObject):

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):
(-[WebAccessibilityObjectWrapper indexOfAccessibilityElement:]):
(-[WebAccessibilityObjectWrapper containsUnnaturallySegmentedChildren]):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

2:45 AM Changeset in webkit [161872] by zandobersek@gmail.com
  • 4 edits in trunk/LayoutTests

Unreviewed GTK gardening. Rebaselining after r161696. Adding failure expectations
for a few reference tests that were introduced in r161573 and r161626.

  • platform/gtk/TestExpectations:
  • platform/gtk/css1/text_properties/word_spacing-expected.png:
  • platform/gtk/css1/text_properties/word_spacing-expected.txt:
2:44 AM Changeset in webkit [161871] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Unreviewed, rolling out r161855.
http://trac.webkit.org/changeset/161855
https://bugs.webkit.org/show_bug.cgi?id=126880

Sister commit of r161852 (Requested by kling on #webkit).

  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):

2:25 AM Changeset in webkit [161870] by Carlos Garcia Campos
  • 4 edits in trunk

Unreviewed. Update NEWS and Versions.m4 for 2.3.4 release.

.:

  • Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Added release notes for 2.3.4.
2:12 AM Changeset in webkit [161869] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WTF

Unreviewed, rolling out r161852.
http://trac.webkit.org/changeset/161852
https://bugs.webkit.org/show_bug.cgi?id=126877

Broke ToT with system Safari (Requested by kling on #webkit).

  • wtf/Threading.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):
(WTF::lockAtomicallyInitializedStaticMutex):
(WTF::unlockAtomicallyInitializedStaticMutex):

  • wtf/ThreadingWin.cpp:

(WTF::lockAtomicallyInitializedStaticMutex):
(WTF::unlockAtomicallyInitializedStaticMutex):
(WTF::initializeThreading):

1:54 AM Changeset in webkit [161868] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Remove parsing of old-run-webkit-tests output from master.cfg
https://bugs.webkit.org/show_bug.cgi?id=126690

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-13
Reviewed by Csaba Osztrogonác.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

Removed parsing of ORWT output, as it is not used anymore.

  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:

Updated unit tests accordingly.

1:46 AM Changeset in webkit [161867] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

Comment should be consructable.
https://bugs.webkit.org/show_bug.cgi?id=115642

Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-01-13
Reviewed by Andreas Kling.

Source/WebCore:

http://dom.spec.whatwg.org/#comment
This allows us to do new Comment('abc') instead of document.createComment('abc').

Backported from Blink: https://chromium.googlesource.com/chromium/blink/+/06e4a37f6b11348606de5405edac1ada97499d2a%5E%21

Test: fast/dom/Comment/comment-constructor.html

  • dom/Comment.cpp:

(WebCore::Comment::create):

  • dom/Comment.h:
  • dom/Comment.idl:

LayoutTests:

  • fast/dom/Comment/comment-constructor-expected.txt: Added.
  • fast/dom/Comment/comment-constructor.html: Added.
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
1:23 AM Changeset in webkit [161866] by zandobersek@gmail.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Changes in r161686 are exposing a bug in GCC where the global .cfi_startproc directive
is not inserted early enough into the generated assembler code when building in debug mode, causing
compilation failures on ports using the GCC compilers. To work around the problem, only utilize the
OFFLINE_ASM_* macros that use .cfi_ directives when compiling with Clang.

  • llint/LowLevelInterpreter.cpp:
1:02 AM Changeset in webkit [161865] by commit-queue@webkit.org
  • 7 edits in trunk

Unreviewed, rolling out r161808.
http://trac.webkit.org/changeset/161808
https://bugs.webkit.org/show_bug.cgi?id=126874

This patch make several files to be always regenerated on
every make (Requested by KaL on #webkit).

Source/WebCore:

  • GNUmakefile.am:
  • bindings/gobject/GNUmakefile.am:

Source/WebKit/gtk:

  • GNUmakefile.am:

Tools:

  • WebKitTestRunner/GNUmakefile.am:
12:12 AM Changeset in webkit [161864] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Make MiniBrowser windows non-transient by default
https://bugs.webkit.org/show_bug.cgi?id=126840

Patch by Adrian Perez de Castro <Adrian Perez de Castro> on 2014-01-13
Reviewed by Carlos Garcia Campos.

Instead of making new browser windows transient as soon as they are
created, save the pointer to the parent window and set the transient
state later on when handling the "run-as-modal" signal. This makes
it easier to use the MiniBrowser to do tests involving multiple
windows, and will be useful as well when multi-web-process mode is
enabled for the GTK port.

  • MiniBrowser/gtk/BrowserWindow.c:

(webViewRunAsModal): Set the parent window using
gtk_window_set_transient_for() using the saved parent
window.
(browser_window_new): Save the parent window using
g_object_set_data() instead of making the new window
transient immediately.

Jan 12, 2014:

11:20 PM Changeset in webkit [161863] by fpizlo@apple.com
  • 12 edits in branches/jsCStack/Source/JavaScriptCore

internal-js-tests.yaml/Octane/mandreel.js.default-ftl fails about 1/30 times with "TypeError: undefined is not an object"
https://bugs.webkit.org/show_bug.cgi?id=126797

Not yet reviewed.

This bug was a hilarious combination of concurrent JIT (making it a flake),
LLInt->JIT OSR, and the FTL's register preservation wrapper.

Consider that a CodeBlock with a LLInt JITCode may get called, and while running,
it may decide to tier up to the baseline JIT. At that point, the old JITCode gets
summarily deleted and replaced by the baseline JITCode. This used to be "correct"
because the LLInt's JITCode only held a reference to an immortal entrypoint thunk.
But not anymore: now the LLInt's JITCode may also hold references to register
preservation wrappers, which get generated lazily.

So consider that the FTL calls a LLInt'd CodeBlock and that LLInt JITCode lazily
creates a register preservation wrapper. That register preservation wrapper is on
the stack and the stack will have a return PC that points to it. Then the LLInt
code decides to tier up to the baseline JIT. This causes the LLInt JITCode to get
deleted. That means that the register preservation wrapper also gets deleted. Now
all it takes is for some more executable memory to get allocated, and when that
baseline JIT frame (that used to be a LLInt frame) returns, it returns into what
it *thinks* is a register preservation wrapper - except now it's something else!

Hilariously, the thing that we'd return into in mandreel was a PutByVal stub. When
the concurrent JIT interleaved itself in such a way as to make this case happen
(i.e. the FTL code for runMandreel was compiled just as some mandreel init routine
was *about* to get tiered up to baseline JIT), then the baseline code would
*always* allocate a PutByVal stub right where the register preservation wrapper's
return site used to be. Thus, returning from the baseline code for that
initialization function would cause it to jump to a PutByVal stub for one of the
PutByVal's in that same function. Somehow, we'd always end up returning to a valid
instruction rather than into the middle of something. That PutByVal stub would
then do a type check on some random variable that it thought was the base - it
would of course fail - and then the slow path would try to do conversions - that
would result in it seeing undefined - and then usually we would crash while trying
to throw the exception.

The solution is to make the return site of the register preservation thunk be
always immortal. We already had a standalone immortal return ramp for that thunk
for use by FTL OSR exit. I figure it doesn't hurt to just always use that immortal
return site.

This bug took several days to track down. I don't think I can add more tests for
this, although I'll think about it. Basically the lesson here is that running big
tests like Mandreel over and over again with the concurrent JIT enabled shakes out
interesting bugs.

This change also adds some useful debug flags, like --breakOnThrow=true, which
causes us to CRASH() whenever an exception is thrown. Without this, this bug was
basically impossible to figure out: we would wind up somewhere in
handleUncaughtException and then that code would go *completely berserk* because
the stack is of course totally screwed up once we "returned" into that PutByVal
stub.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpAssumingJITType):
(JSC::CodeBlock::CodeBlock):

  • dfg/DFGCompilationMode.h:

(JSC::DFG::isFTL):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::reportCompileTimes):
(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGPlan.h:
  • ftl/FTLCompile.cpp:

(JSC::FTL::compile):

  • jit/JITExceptions.cpp:

(JSC::genericUnwind):

  • jit/RegisterPreservationWrapperGenerator.cpp:

(JSC::generateRegisterPreservationWrapper):
(JSC::generateRegisterRestoration):

  • jit/RegisterPreservationWrapperGenerator.h:
  • runtime/Options.cpp:

(JSC::recomputeDependentOptions):

  • runtime/Options.h:
  • runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::throwException):

10:29 PM Changeset in webkit [161862] by commit-queue@webkit.org
  • 7 edits in trunk

Unreviewed, rolling out r161843.
http://trac.webkit.org/changeset/161843
https://bugs.webkit.org/show_bug.cgi?id=126871

Caused CSS custom filter tests to assert (Requested by smfr on
#webkit).

Source/WebCore:

  • platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::getSymbolInfo):
(WebCore::ANGLEWebKitBridge::compileShaderSource):

  • platform/graphics/GraphicsContext3D.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::getProgramInfoLog):
(WebCore::GraphicsContext3D::getShaderInfoLog):

LayoutTests:

  • fast/canvas/webgl/glsl-conformance-expected.txt:
  • fast/canvas/webgl/glsl-conformance.html:
10:26 PM Changeset in webkit [161861] by commit-queue@webkit.org
  • 29 edits in trunk/Source

Unreviewed, rolling out r161840.
http://trac.webkit.org/changeset/161840
https://bugs.webkit.org/show_bug.cgi?id=126870

Caused jsscore and layout test failures (Requested by smfr on
#webkit).

Source/JavaScriptCore:

  • API/JSValueRef.cpp:

(JSValueMakeFromJSONString):

  • bindings/ScriptValue.cpp:

(Deprecated::jsToInspectorValue):

  • inspector/InspectorValues.cpp:
  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):

  • runtime/Identifier.h:

(JSC::Identifier::characters):

  • runtime/JSStringBuilder.h:

(JSC::JSStringBuilder::append):

Source/WebCore:

  • bindings/objc/WebScriptObject.mm:

(+[WebScriptObject _convertValueToObjcValue:JSC::originRootObject:rootObject:]):

  • editing/CompositeEditCommand.cpp:

(WebCore::containsOnlyWhitespace):

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::insertText):

  • editing/VisibleUnits.cpp:

(WebCore::startOfParagraph):
(WebCore::endOfParagraph):

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::stripLeadingAndTrailingHTMLSpaces):
(WebCore::parseHTMLNonNegativeInteger):

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::createSearchRegexSource):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters):

  • inspector/InspectorStyleTextEditor.cpp:

(WebCore::InspectorStyleTextEditor::insertProperty):
(WebCore::InspectorStyleTextEditor::internalReplaceProperty):

  • platform/Length.cpp:

(WebCore::newCoordsArray):

  • platform/LinkHash.cpp:

(WebCore::visitedLinkHash):

  • platform/graphics/Color.cpp:

(WebCore::Color::parseHexColor):
(WebCore::Color::Color):

  • platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::atomicCanonicalTextEncodingName):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::constructTextRun):

  • rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::width):

  • svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::registerLigaturesInGlyphCache):

  • xml/XPathFunctions.cpp:

(WebCore::XPath::FunId::evaluate):

  • xml/XPathNodeSet.h:

Source/WTF:

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::replace):

  • wtf/text/WTFString.h:

(WTF::String::isAllSpecialCharacters):

10:18 PM Changeset in webkit [161860] by jinwoo7.song@samsung.com
  • 4 edits in trunk/Source

Fix build warnings by unused parameter
https://bugs.webkit.org/show_bug.cgi?id=126867

Reviewed by Gyuyoung Kim.

Source/WebCore:

  • Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.cpp:

(WebCore::IDBServerConnectionLevelDB::changeDatabaseVersion): Remove unused parameter 'operation'.

Source/WebKit/efl:

  • WebCoreSupport/EditorClientEfl.h:

(WebCore::EditorClientEfl::checkTextOfParagraph): Remove unused parameter 'checkingTypes'.

8:37 PM Changeset in webkit [161859] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix for WinCairo.

  • WebCore.vcxproj/WebCoreCairo.props: Add missing include path

to locate SelectorCompiler.h.

8:31 PM Changeset in webkit [161858] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

Unreviewed test maintenance.

  • platform/mac/TestExpectations: Re-enable the typedarray/data-view-test.html

WebGL test now that it works properly.

8:09 PM Changeset in webkit [161857] by commit-queue@webkit.org
  • 7 edits in trunk

[EFL][WK2] Make API tests work again
https://bugs.webkit.org/show_bug.cgi?id=126769

Patch by Sergio Correia <Sergio Correia> on 2014-01-12
Reviewed by Gyuyoung Kim.

The EFL and WK2 test binaries are currently being generated at *TestWebKitAPI/
[E]WebKit2, respectively, and this causes problems because the logic to find
where WebProcess is to look in the same directory of the running process and
then proceed to use LIBEXECDIR (typically /usr/loca/bin).

This patch introduces a WEBKIT_EXEC_PATH environment variable, inspired in the
Gtk port, which allows us to look for WebProcess initially in this directory,
if it's defined.

.:

  • Source/cmake/OptionsEfl.cmake: Define WEBKIT_EXEC_PATH, to be used by

[E]WebKit2 tests.

Source/WebKit2:

  • Shared/efl/ProcessExecutablePathEfl.cpp:

(WebKit::findProcessPath): Change the logic to look initially in
WEBKIT_EXEC_PATH, then proceed with the existing checks.

  • UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestEnvironment.cpp:

(EWK2UnitTest::EWK2UnitTestEnvironment::EWK2UnitTestEnvironment):
Define WEBKIT_EXEC_PATH to be used by EWebKit2 tests.

Tools:

  • TestWebKitAPI/efl/main.cpp:

(main): Define WEBKIT_EXEC_PATH to be used by WebKit2 API tests.

8:03 PM Changeset in webkit [161856] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit

Try to fix the Windows build after r161852.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
7:55 PM Changeset in webkit [161855] by mitz@apple.com
  • 2 edits in trunk/Source/WTF

Fix an assertion failure in initializeDates() when launching Safari, which was introduced in r161852.

Reviewed by Andy Estes.

  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading): Set isInitialized to true.

7:18 PM Changeset in webkit [161854] by mjs@apple.com
  • 2 edits in trunk/Source/WebCore

Fix iOS build breakage from http://trac.webkit.org/changeset/161844
https://bugs.webkit.org/show_bug.cgi?id=126866

Reviewed by Simon Fraser.

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::cursorMovementIterator): Use initializeIterator instead of createSharedIterator,
which does not exist.

6:42 PM Changeset in webkit [161853] by Darin Adler
  • 4 edits in trunk/Source

Add PLATFORM(COCOA) and USE(FOUNDATION)
https://bugs.webkit.org/show_bug.cgi?id=126859

Reviewed by Anders Carlsson.

Source/WebCore:

config.h: Use PLATFORM(COCOA) instead of PLATFORM(MAC)
PLATFORM(IOS)

to set USE(FILE_LOCK). Would be nice to use OS(DARWIN), but that would be
a change in behavior that might be incorrect. Removed bogus comments in
the USE(NEW_THEME) setting code. Removed redundant code to set USE(CA),
which exactly duplicates code that already exists in Platform.h.

Source/WTF:

  • wtf/Platform.h: Added PLATFORM(COCOA), which for now is set at exactly the same

times that PLATFORM(MAC) is. Added USE(FOUNDATION), which is set at the same times
that PLATFORM(COCOA) is. Re-organize the PLATFORM(MAC) and PLATFORM(IOS) settings
in the header so they are a bit easier to read. Put HAVE_LANGINFO_H in with the
rest of the OS(UNIX) settings and put HAVE_READLINE in with the rest of the
OS(DARWIN) settings. Tweak formatting a bit.

6:36 PM Changeset in webkit [161852] by andersca@apple.com
  • 4 edits in trunk/Source/WTF

Remove AtomicallyInitializedStatic
https://bugs.webkit.org/show_bug.cgi?id=126864

Reviewed by Darin Adler.

  • wtf/Threading.h:
  • wtf/ThreadingPthreads.cpp:

(WTF::initializeThreading):

  • wtf/ThreadingWin.cpp:

(WTF::initializeThreading):

6:29 PM Changeset in webkit [161851] by Darin Adler
  • 89 edits in trunk/Source

Add deprecatedCharacters as a synonym for characters and convert most call sites
https://bugs.webkit.org/show_bug.cgi?id=126858

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

  • API/JSStringRef.cpp:

(JSStringGetCharactersPtr):
(JSStringGetUTF8CString):
(JSStringIsEqual):

  • API/JSStringRefCF.cpp:

(JSStringCopyCFString):

  • API/OpaqueJSString.h:

(OpaqueJSString::characters):
(OpaqueJSString::deprecatedCharacters):
(OpaqueJSString::length):
(OpaqueJSString::OpaqueJSString):

  • inspector/InspectorValues.cpp:

(Inspector::InspectorValue::parseJSON):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::parseInt):

  • runtime/StringPrototype.cpp:

(JSC::localeCompare):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncLink):
Use deprecatedCharacters instead of characters.

Source/WebCore:

  • Modules/indexeddb/IDBKeyPath.cpp:

(WebCore::IDBKeyPathLexer::IDBKeyPathLexer):

  • Modules/websockets/ThreadableWebSocketChannelClientWrapper.cpp:

(WebCore::ThreadableWebSocketChannelClientWrapper::setSubprotocol):
(WebCore::ThreadableWebSocketChannelClientWrapper::setExtensions):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::hasMisspelling):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper doAXAttributedStringForTextMarkerRange:]):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::serialize):
(WebCore::CloneSerializer::write):

  • dom/CharacterData.cpp:

(WebCore::CharacterData::parserAppendData):

  • dom/Document.cpp:

(WebCore::Document::parseQualifiedName):

  • editing/Editor.cpp:

(WebCore::Editor::misspelledWordAtCaretOrRange):
(WebCore::Editor::misspelledSelectionString):
(WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):

  • editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
(WebCore::TextCheckingHelper::findFirstBadGrammar):
(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):

  • editing/TextCheckingHelper.h:

(WebCore::TextCheckingParagraph::textDeprecatedCharacters):

  • editing/TextIterator.cpp:

(WebCore::collapsedSpaceLength):
(WebCore::SimplifiedBackwardsTextIterator::handleTextNode):
(WebCore::containsKanaLetters):
(WebCore::SearchBuffer::SearchBuffer):

  • editing/TextIterator.h:

(WebCore::TextIterator::characters):

  • editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::characterAfter):

  • editing/VisibleUnits.cpp:

(WebCore::wordBreakIteratorForMinOffsetBoundary):
(WebCore::wordBreakIteratorForMaxOffsetBoundary):
(WebCore::visualWordPosition):
(WebCore::previousBoundary):
(WebCore::nextBoundary):

  • fileapi/WebKitBlobBuilder.cpp:

(WebCore::BlobBuilder::append):

  • html/FormDataList.cpp:

(WebCore::FormDataList::appendString):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::normalizeSpaces):

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::parseImagesWithScaleFromSrcsetAttribute):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::ExternalCharacterTokenBuffer::ExternalCharacterTokenBuffer):

  • loader/appcache/ManifestParser.cpp:

(WebCore::parseManifest):

  • page/ContentSecurityPolicy.cpp:

(WebCore::isSourceListNone):
(WebCore::CSPSourceList::parse):
(WebCore::NonceDirective::parse):
(WebCore::MediaListDirective::parse):
(WebCore::CSPDirectiveList::parse):
(WebCore::CSPDirectiveList::parseReportURI):
(WebCore::CSPDirectiveList::parseReflectedXSS):
(WebCore::ContentSecurityPolicy::didReceiveHeader):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):
(WebCore::PageSerializer::serializeCSSStyleSheet):

  • platform/Length.cpp:

(WebCore::newCoordsArray):
(WebCore::newLengthArray):

  • platform/LinkHash.cpp:

(WebCore::visitedURL):
(WebCore::visitedLinkHash):

  • platform/SharedBuffer.cpp:

(WebCore::utf8Buffer):

  • platform/URL.cpp:

(WebCore::URL::port):
(WebCore::encodeHostnames):

  • platform/graphics/StringTruncator.cpp:

(WebCore::centerTruncateToBuffer):
(WebCore::rightTruncateToBuffer):
(WebCore::rightClipToCharacterBuffer):
(WebCore::rightClipToWordBuffer):
(WebCore::leftTruncateToBuffer):
(WebCore::truncateString):
(WebCore::StringTruncator::width):

  • platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):

  • platform/network/FormDataBuilder.cpp:

(WebCore::FormDataBuilder::addFilenameToMultiPartHeader):

  • platform/sql/SQLiteStatement.cpp:

(WebCore::SQLiteStatement::bindBlob):
(WebCore::SQLiteStatement::bindText):

  • platform/text/DecodeEscapeSequences.h:

(WebCore::decodeEscapeSequences):

  • platform/text/TextBreakIterator.cpp:

(WebCore::numGraphemeClusters):
(WebCore::numCharactersInGraphemeClusters):

  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::setUpIteratorWithRules):

  • platform/text/TextCodecICU.cpp:

(WebCore::TextCodecICU::encode):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::constructTextRun):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::paint):

  • rendering/RenderText.cpp:

(WebCore::maxWordFragmentWidth):
(WebCore::RenderText::computePreferredLogicalWidths):
(WebCore::RenderText::computeCanUseSimpleFontCodePath):

  • rendering/RenderText.h:

(WebCore::RenderText::characters):
(WebCore::RenderText::deprecatedCharacters):

  • rendering/line/BreakingContextInlineHeaders.h:

(WebCore::tryHyphenating):

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::constructTextRun):

  • rendering/svg/SVGTextLayoutAttributesBuilder.cpp:

(WebCore::processRenderSVGInlineText):

  • rendering/svg/SVGTextLayoutEngine.cpp:

(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):

  • rendering/svg/SVGTextMetrics.cpp:

(WebCore::SVGTextMetrics::measureCharacterRange):
(WebCore::SVGTextMetrics::SVGTextMetrics):

  • rendering/svg/SVGTextMetricsBuilder.cpp:

(WebCore::SVGTextMetricsBuilder::initializeMeasurementWithTextRenderer):

  • svg/SVGAngle.cpp:

(WebCore::SVGAngle::setValueAsString):

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::parsePoint):

  • svg/SVGAnimationElement.cpp:

(WebCore::parseKeySplines):

  • svg/SVGFitToViewBox.cpp:

(WebCore::SVGFitToViewBox::parseViewBox):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

  • svg/SVGGlyphMap.h:

(WebCore::SVGGlyphMap::addGlyph):
(WebCore::SVGGlyphMap::collectGlyphsForString):

  • svg/SVGGlyphRefElement.cpp:

(WebCore::SVGGlyphRefElement::parseAttribute):

  • svg/SVGLength.cpp:

(WebCore::SVGLength::setValueAsString):

  • svg/SVGLengthList.cpp:

(WebCore::SVGLengthList::parse):

  • svg/SVGNumberList.cpp:

(WebCore::SVGNumberList::parse):

  • svg/SVGParserUtilities.cpp:

(WebCore::parseNumberFromString):
(WebCore::parseNumberOptionalNumber):
(WebCore::parseRect):
(WebCore::pointsListFromSVGData):
(WebCore::parseGlyphName):
(WebCore::parseKerningUnicodeString):
(WebCore::parseDelimitedString):

  • svg/SVGPreserveAspectRatio.cpp:

(WebCore::SVGPreserveAspectRatio::parse):

  • svg/SVGStringList.cpp:

(WebCore::SVGStringList::parse):

  • svg/SVGTransformList.cpp:

(WebCore::SVGTransformList::parse):

  • svg/SVGTransformable.cpp:

(WebCore::SVGTransformable::parseTransformType):

  • svg/SVGViewSpec.cpp:

(WebCore::SVGViewSpec::parseViewSpec):

  • svg/SVGZoomAndPan.h:

(WebCore::SVGZoomAndPan::parseAttribute):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):

  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::parseString):

  • xml/XSLTUnicodeSort.cpp:

(WebCore::xsltUnicodeSortFunction):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::doWrite):
(WebCore::parseAttributes):
Use deprecatedCharacters instead of characters.

Source/WebKit/mac:

  • History/BinaryPropertyList.cpp:

(BinaryPropertyListSerializer::appendStringObject):
Use deprecatedCharacters instead of characters.

Source/WebKit2:

  • Shared/APIString.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::checkTextOfParagraph):
(WebKit::WebPageProxy::checkSpellingOfString):
(WebKit::WebPageProxy::checkGrammarOfString):

  • WebProcess/WebPage/EncoderAdapter.cpp:

(WebKit::EncoderAdapter::encodeString):
Use deprecatedCharacters instead of characters.

Source/WTF:

  • wtf/text/AtomicString.cpp:

(WTF::HashAndUTF8CharactersTranslator::equal):
(WTF::SubstringTranslator::hash):
(WTF::SubstringTranslator::equal):

  • wtf/text/AtomicString.h:

(WTF::AtomicString::characters):

  • wtf/text/Base64.cpp:

(WTF::base64Decode):
(WTF::base64URLDecode):

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::characters):
(WTF::StringBuilder::deprecatedCharacters):

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::getData16SlowCase):
(WTF::StringImpl::upper):
(WTF::StringImpl::lower):
(WTF::StringImpl::find):
(WTF::StringImpl::findIgnoringCase):

  • wtf/text/StringImpl.h:

(WTF::StringImpl::characters):
(WTF::StringImpl::deprecatedCharacters):
(WTF::StringImpl::getCharacters<UChar>):
(WTF::equalIgnoringNullity):

  • wtf/text/WTFString.cpp:

(WTF::String::append):
(WTF::String::appendInternal):
(WTF::String::insert):
(WTF::String::truncate):
(WTF::String::percentage):

  • wtf/text/WTFString.h:

(WTF::String::characters):
(WTF::String::deprecatedCharacters):
(WTF::String::getCharactersWithUpconvert<UChar>):
(WTF::append):
Use deprecatedCharacters instead of characters.

6:27 PM Changeset in webkit [161850] by Darin Adler
  • 9 edits in trunk/Source

Add type checking to isEqual methods
https://bugs.webkit.org/show_bug.cgi?id=126862

Reviewed by Anders Carlsson.

Source/WebCore:

  • page/ios/WebEventRegion.mm:

(-[WebEventRegion isEqual:]): Add type checking on the argument.
Add a FIXME about the lack of a hash method override. Formatted to match
the usual WebKit coding style.

Source/WebKit/ios:

  • WebCoreSupport/WebVisiblePosition.mm:

(-[WebVisiblePosition isEqual:]): Add type checking on the argument.
Add a FIXME about the lack of a hash method override. Simplified by
removing the unneeded local variables.

Source/WebKit/mac:

  • WebCoreSupport/WebSecurityOrigin.mm:

(-[WebSecurityOrigin isEqual:]): Added a FIXME about the lack of a hash method
override. Tweaked formatting.

  • WebView/WebDashboardRegion.mm:

(-[WebDashboardRegion isEqual:]): Added type checking on the argument. Added a
FIXME about the lack of a hash method override.

Source/WebKit2:

  • UIProcess/API/ios/WKInteractionView.mm:

(-[WKTextRange isEqual:]): Added type checking for the argument. The old
code asserted instead, and it's not clear what guarantees that assertion is
true. Added a FIXME about the lack of a hash method. Added another FIXME
about the fact that this method ignores much of the object state. Removed
an unneeded extra fetch of the isRange property. Deleted some dead code.
(-[WKTextPosition isEqual:]): Ditto.

6:23 PM Changeset in webkit [161849] by andersca@apple.com
  • 5 edits in trunk/Source

Remove the last remaining uses of AtomicallyInitializedStatic
https://bugs.webkit.org/show_bug.cgi?id=126863

Reviewed by Darin Adler.

Source/WebKit2:

  • Shared/mac/SecItemShim.cpp:

(WebKit::responseMap):

Source/WTF:

  • wtf/HashTable.cpp:

(WTF::hashTableStatsMutex):
(WTF::HashTableStats::recordCollisionAtCount):
(WTF::HashTableStats::dumpStats):

  • wtf/unicode/icu/CollatorICU.cpp:

(WTF::cachedCollatorMutex):
(WTF::Collator::createCollator):
(WTF::Collator::releaseCollator):

6:07 PM Changeset in webkit [161848] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the 32-bit build.

  • platform/text/icu/UTextProviderLatin1.cpp:

(WebCore::uTextLatin1Clone):
(WebCore::uTextLatin1Extract):
(WebCore::uTextLatin1MapNativeIndexToUTF16):

6:01 PM Changeset in webkit [161847] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Remove all uses of AtomicallyInitializedStatic from WebCore
https://bugs.webkit.org/show_bug.cgi?id=126861

Reviewed by Darin Adler.

  • Modules/indexeddb/IDBPendingTransactionMonitor.cpp:

(WebCore::transactions):

  • fileapi/ThreadableBlobRegistry.cpp:

(WebCore::originMap):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::encodingRegistryMutex):
(WebCore::newTextCodec):
(WebCore::atomicCanonicalTextEncodingName):
(WebCore::dumpTextEncodingNameMap):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::DefaultSharedWorkerRepository::instance):

5:44 PM Changeset in webkit [161846] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Use an std::atomic<uint32_t> when computing IDBDatabase transaction IDs
https://bugs.webkit.org/show_bug.cgi?id=126853

Reviewed by Sam Weinig.

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::nextTransactionId):

5:38 PM Changeset in webkit [161845] by dbates@webkit.org
  • 2 edits in trunk/Tools

[iOS] Fix the build

For now, ensure we build WebKit System Interface before we build WebKit.
We'll remove this constraint and the constraint to build WebKit Additions
in a subsequent commit.

  • Scripts/build-webkit:
5:28 PM Changeset in webkit [161844] by weinig@apple.com
  • 9 edits in trunk/Source/WebCore

TextBreakIterator's should support Latin-1 for all iterator types (Part 1)
https://bugs.webkit.org/show_bug.cgi?id=126856

Reviewed by Darin Adler.

  • Do some initial cleanup before adding complete Latin-1 support.
  • platform/text/TextBreakIterator.cpp:

Remove non-ICU acquireLineBreakIterator() implementation.

  • platform/text/TextBreakIterator.h:
  • Changes acquireLineBreakIterator() to take a StringView.
  • platform/text/TextBreakIteratorICU.cpp:
  • Refactor iterator initialization and setting of text on the iterator.
  • Add support for using a Latin-1 provider (this is not currently used).
  • platform/text/icu/UTextProviderLatin1.cpp:
  • platform/text/icu/UTextProviderLatin1.h:
  • Add back non-context aware Latin-1 provider (from r129662).
  • Rename context aware provider.
  • platform/text/icu/UTextProviderUTF16.cpp:
  • platform/text/icu/UTextProviderUTF16.h:
  • Rename context aware provider.
5:26 PM Changeset in webkit [161843] by Brent Fulgham
  • 7 edits in trunk

[WebGL] Error messages should use source code labels, not internal mangled symbols.
https://bugs.webkit.org/show_bug.cgi?id=126832

Reviewed by Dean Jackson.

Source/WebCore:

Revised fast/canvas/webgl/glsl-conformance.html.

  • platform/graphics/ANGLEWebKitBridge.cpp:

(WebCore::getSymbolInfo): Correct missing 'break'.
(WebCore::ANGLEWebKitBridge::compileShaderSource): Call 'getSymbolInfo'
for SH_VARYINGS.

  • platform/graphics/GraphicsContext3D.h: Add new declarations.
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::compileShader): Demangle log output.
(WebCore::GraphicsContext3D::mappedSymbolName): Added.
(WebCore::GraphicsContext3D::getUnmangledInfoLog): Added.
(WebCore::GraphicsContext3D::getProgramInfoLog): Demangle log output.
(WebCore::GraphicsContext3D::getShaderInfoLog): Demangle log output.

LayoutTests:

  • fast/canvas/webgl/glsl-conformance.html: Add log to program output

showing error message to confirm proper labels are being used.

  • fast/canvas/webgl/glsl-conformance-expected.txt: updated.
4:57 PM Changeset in webkit [161842] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the Windows build after r161839.

  • WebCore.vcxproj/WebCoreCommon.props:
3:52 PM Changeset in webkit [161841] by aestes@apple.com
  • 2 edits in trunk/Source/ThirdParty

Fix the Mac build after r161777.

  • gtest/xcode/Config/General.xcconfig: AspenFamily.xcconfig excludes

macosx from SUPPORTED_PLATFORMS, so add it back in ourselves.

3:23 PM Changeset in webkit [161840] by Darin Adler
  • 29 edits in trunk/Source

Reduce use of String::characters
https://bugs.webkit.org/show_bug.cgi?id=126854

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • API/JSValueRef.cpp:

(JSValueMakeFromJSONString): Use characters16 instead of characters for 16-bit case.
Had to remove length check because an empty string could be either 8 bit or 16 bit.
Don't need a null string check before calling is8Bit because JSStringRef can't hold
a null string.

  • bindings/ScriptValue.cpp:

(Deprecated::jsToInspectorValue): Use the existing string here instead of creating
a new one by calling characters and length on the old string. I think this may be
left over from when string types were not the same in JavaScriptCore and WebCore.
Also rewrite the property names loop to use modern for syntax and fewer locals.

  • inspector/InspectorValues.cpp:

(Inspector::escapeChar): Changed to use appendLiteral instead of hard-coding string
lengths. Moved handling of "<" and ">" in here instead of at the call site.
(Inspector::doubleQuoteString): Simplify the code so there is no use of characters
and length. This is still an inefficient way of doing this job and could use a rethink.

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate): Use RetainPtr, createCFString, and the conversion from
CFStringRef to WTF::String to remove a lot of unneeded code.

  • runtime/Identifier.h: Removed unneeded Identifier::characters function.
  • runtime/JSStringBuilder.h:

(JSC::JSStringBuilder::append): Use characters16 instead of characters function here,
since we have already checked is8Bit above.

Source/WebCore:

  • bindings/objc/WebScriptObject.mm:

(+[WebScriptObject _convertValueToObjcValue:JSC::originRootObject:rootObject:]):
Get rid of unneeded code to turn a WTF::String into an NSString, since that's
built into the WTF::String class.

  • editing/CompositeEditCommand.cpp:

(WebCore::containsOnlyWhitespace): Use WTF::String's [] operator instead of
an explicit call to the characters function. Small performance cost.

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::insertText): Ditto.

  • editing/VisibleUnits.cpp:

(WebCore::startOfParagraph): Use reverseFind instead of writing our own loop.
(WebCore::endOfParagraph): Use find instead of writing our own loop.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::stripLeadingAndTrailingHTMLSpaces): Use characters16 instead of
characters since we have already checked is8Bit.
(WebCore::parseHTMLNonNegativeInteger): Ditto. Replace the length check with
a check of isNull since a zero length string could be 8 bit, but it's not
safe to call is8Bit on a null WTF::String. (That should probably be fixed.)

  • inspector/ContentSearchUtils.cpp:

(WebCore::ContentSearchUtils::createSearchRegexSource): Use StringBuilder
instead of String in code that builds up a string one character at a time.
The old way was ridiculously slow because it allocated a new string for every
character; the new way still isn't all that efficient, but it's better. Also
changed to use strchr instead of WTF::String::find for special characters.

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters): Use WTF::String's
[] operator instead of an explicit call to the characters function.

  • inspector/InspectorStyleTextEditor.cpp:

(WebCore::InspectorStyleTextEditor::insertProperty): Ditto.
(WebCore::InspectorStyleTextEditor::internalReplaceProperty): Ditto.

  • platform/Length.cpp:

(WebCore::newCoordsArray): Ditto.

  • platform/LinkHash.cpp:

(WebCore::visitedLinkHash): Use characters16 instead of characters since
we have already checked is8Bit. Replace the length check with a check of
isNull (as above in parseHTMLNonNegativeInteger).

  • platform/graphics/Color.cpp:

(WebCore::Color::parseHexColor): Use characters16 since we already checked is8Bit.
(WebCore::Color::Color): Ditto.

  • platform/graphics/TextRun.h:

(WebCore::TextRun::TextRun): Use characters16 instead of characters since
we have already checked is8Bit. Replace the length check with a check of
isNull (as above in parseHTMLNonNegativeInteger).

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::atomicCanonicalTextEncodingName): Use characters16 instead of
characters since we already checked is8Bit. Also use isEmpty instead of !length.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::constructTextRun): Use characters16 instead of characters
since we have already checked is8Bit. Replace the length check with a check of
isNull (as above in parseHTMLNonNegativeInteger).

  • rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::width): Check for zero length instead of checking
for null characters.

  • svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::registerLigaturesInGlyphCache): Rewrite ligatures
for loop and give local variables a better name. Construct the substring with
the substring function. Still a really inefficient approach -- allocating a new
string for every character is absurdly expensive.

  • xml/XPathFunctions.cpp:

(WebCore::XPath::FunId::evaluate): Use String instead of StringBuilder. Still
not all that efficient, but better than before. Use substring to construct the
substring.

  • xml/XPathNodeSet.h: Added begin and end functions so we can use a C++11 for

loop with this class.

Source/WTF:

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::replace): Use characters16 here since is8Bit was already checked.

  • wtf/text/WTFString.h:

(WTF::String::isAllSpecialCharacters): Use characters16 here since is8Bit was
already checked. Also renamed "len" to "length".

3:04 PM Changeset in webkit [161839] by benjamin@webkit.org
  • 5 edits
    12 adds in trunk

Use the Selector Code Generator for matching in SelectorQuery
https://bugs.webkit.org/show_bug.cgi?id=126185

Reviewed by Ryosuke Niwa.

Source/WebCore:

Compile selectors on demand and use the generated binary to perform
element matching in SelectorQuery.

Tests: fast/selectors/querySelector-long-adjacent-backtracking.html

fast/selectors/querySelector-long-child-backtracking.html
fast/selectors/querySelector-mixed-child-adjacent-backtracking.html
fast/selectors/querySelector-multiple-simple-child-backtracking.html
fast/selectors/querySelector-simple-adjacent-backtracking.html
fast/selectors/querySelector-simple-child-backtracking.html

  • dom/SelectorQuery.cpp:

(WebCore::SelectorDataList::executeCompiledSimpleSelectorChecker):
(WebCore::SelectorDataList::executeCompiledSelectorCheckerWithContext):
(WebCore::SelectorDataList::execute):

  • dom/SelectorQuery.h:

LayoutTests:

Add some tests for longer backtracking cases typically not covered by the other tests.

  • fast/selectors/querySelector-long-adjacent-backtracking-expected.txt: Added.
  • fast/selectors/querySelector-long-adjacent-backtracking.html: Added.
  • fast/selectors/querySelector-long-child-backtracking-expected.txt: Added.
  • fast/selectors/querySelector-long-child-backtracking.html: Added.
  • fast/selectors/querySelector-mixed-child-adjacent-backtracking-expected.txt: Added.
  • fast/selectors/querySelector-mixed-child-adjacent-backtracking.html: Added.
  • fast/selectors/querySelector-multiple-simple-child-backtracking-expected.txt: Added.
  • fast/selectors/querySelector-multiple-simple-child-backtracking.html: Added.
  • fast/selectors/querySelector-simple-adjacent-backtracking-expected.txt: Added.
  • fast/selectors/querySelector-simple-adjacent-backtracking.html: Added.
  • fast/selectors/querySelector-simple-child-backtracking-expected.txt: Added.
  • fast/selectors/querySelector-simple-child-backtracking.html: Added.
2:07 PM Changeset in webkit [161838] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Simplify creation of XMLHttpRequestStaticData
https://bugs.webkit.org/show_bug.cgi?id=126852

Reviewed by Sam Weinig.

Add a staticData() getter that does the initialization and get rid of the explicit
calls to initializeXMLHttpRequestStaticData().

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequestStaticData::XMLHttpRequestStaticData):
(WebCore::staticData):
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::isAllowedHTTPHeader):

1:38 PM Changeset in webkit [161837] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Final WebCore link error: update a symbol in WebCoreSystemInterfaceIOS.mm.

  • platform/ios/WebCoreSystemInterfaceIOS.mm:
1:37 PM Changeset in webkit [161836] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Added a reference to WebContentService/Info-OSX.plist to the project.

  • WebKit2.xcodeproj/project.pbxproj:
1:31 PM Changeset in webkit [161835] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Use std::call_once instead of AtomicallyInitializedStatic in DatabaseBackendBase
https://bugs.webkit.org/show_bug.cgi?id=126851

Reviewed by Sam Weinig.

  • Modules/webdatabase/DatabaseBackendBase.cpp:

(WebCore::guidMutex):
(WebCore::guidToVersionMap):
(WebCore::updateGuidVersionMap):
(WebCore::guidToDatabaseMap):
(WebCore::guidForOriginAndName):
(WebCore::DatabaseBackendBase::DatabaseBackendBase):
(WebCore::DatabaseBackendBase::closeDatabase):
(WebCore::DatabaseBackendBase::performOpenAndVerify):
(WebCore::DatabaseBackendBase::getCachedVersion):
(WebCore::DatabaseBackendBase::setCachedVersion):

1:23 PM Changeset in webkit [161834] by mitz@apple.com
  • 2 edits
    1 move in trunk/Source/WebKit2

OS X build fix.

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist: Copied from WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist.
  • WebProcess/EntryPoint/mac/XPCService/WebContentService/Info.plist: Removed.
1:14 PM Changeset in webkit [161833] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the Windows build after r161830.

  • platform/network/NetworkStateNotifier.h:
1:09 PM Changeset in webkit [161832] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Don't build JSTouch* and JSGesture* files on Mac.

  • Configurations/WebCore.xcconfig:
1:04 PM Changeset in webkit [161831] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Build Fix: Objective-C GC should be unsupported in iOS WebKit2

  • Configurations/Base.xcconfig:
12:59 PM Changeset in webkit [161830] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Clean up NetworkStateNotifier class
https://bugs.webkit.org/show_bug.cgi?id=126850

Reviewed by Andreas Kling.

Use std::call_once instead of AtomicallyInitializedStatic and a std::function
instead of a custom function pointer typedef.

  • platform/network/NetworkStateNotifier.cpp:

(WebCore::networkStateNotifier):
(WebCore::NetworkStateNotifier::addNetworkStateChangeListener):
(WebCore::NetworkStateNotifier::notifyNetworkStateChange):

  • platform/network/NetworkStateNotifier.h:
12:54 PM Changeset in webkit [161829] by aestes@apple.com
  • 7 edits
    2 copies in trunk/Source/WebKit2

[iOS] Upstream WebKit2 xcconfig changes to fix the build

  • Configurations/All-iOS.xcconfig: Added.
  • Configurations/Base.xcconfig:
  • Configurations/BaseLegacyProcess.xcconfig:
  • Configurations/BaseTarget.xcconfig:
  • Configurations/BaseXPCService.xcconfig:
  • Configurations/DebugRelease.xcconfig:
  • Configurations/WebContentService.xcconfig:
  • Configurations/iOS.xcconfig: Added.
12:50 PM Changeset in webkit [161828] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Add implementations of Frame::viewportArguments() and
Frame::setViewportArguments().

  • page/ios/FrameIOS.mm:

(WebCore::Frame::viewportArguments):
(WebCore::Frame::setViewportArguments):

12:38 PM Changeset in webkit [161827] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Add JSWebKitPlaybackTargetAvailabilityEvent.* to the project.

  • WebCore.xcodeproj/project.pbxproj:
12:38 PM Changeset in webkit [161826] by Simon Fraser
  • 2 edits
    1 add in trunk/Source/WebCore

Stub out some DragImage functions for iOS.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/ios/DragImageIOS.mm: Added.

(WebCore::dragImageSize):
(WebCore::scaleDragImage):
(WebCore::createDragImageFromImage):

12:12 PM Changeset in webkit [161825] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

We need DragImage.cpp code even when ENABLE_DRAG_SUPPORT is
not defined, because these are actually generic snapshotting
functions.

  • platform/DragImage.cpp:
12:12 PM Changeset in webkit [161824] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Fix linker errors: add DateTimeFormat.cpp to the project,
and make DateInputType::DateInputType not inline.

  • WebCore.xcodeproj/project.pbxproj:
  • html/DateInputType.cpp:

(WebCore::DateInputType::DateInputType):

  • platform/DragImage.cpp:
12:12 PM Changeset in webkit [161823] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix a bunch of linker errors related to exported functions.
I removed some iOS symbols from the .exp.in file; we may have
to add some back.

  • WebCore.exp.in:
12:12 PM Changeset in webkit [161822] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Add generated JSTouch* and JSGestureEvent.* files to the project.

  • WebCore.xcodeproj/project.pbxproj:
12:06 PM Changeset in webkit [161821] by ddkilzer@apple.com
  • 3 edits in trunk/Source/WebCore

Move implementation of AuthenticationChallenge::setAuthenticationClient() to source file for USE(CFNETWORK)
<http://webkit.org/b/126848>

Reviewed by Simon Fraser.

  • platform/network/cf/AuthenticationCF.cpp:

(WebCore::AuthenticationChallenge::setAuthenticationClient):
Move implementation to here...

  • platform/network/cf/AuthenticationChallenge.h: ...from here.

Remove duplicate header definitions inside USE(CFNETWORK).

12:04 PM Changeset in webkit [161820] by aestes@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[iOS] Enable the JSC Objective-C API

Rubber-stamped by Simon Fraser.

  • API/JSBase.h:
11:50 AM Changeset in webkit [161819] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix windows.

  • WebCore.vcxproj/WebCore.vcxproj:
11:45 AM Changeset in webkit [161818] by andersca@apple.com
  • 7 edits in trunk/Source

Replace more uses of AtomicallyInitializedStatic with std::call_once
https://bugs.webkit.org/show_bug.cgi?id=126847

Reviewed by Sam Weinig.

Source/WebCore:

  • crypto/CryptoAlgorithmRegistry.cpp:

(WebCore::CryptoAlgorithmRegistry::shared):
(WebCore::registryMutex):
(WebCore::CryptoAlgorithmRegistry::getIdentifierForName):
(WebCore::CryptoAlgorithmRegistry::nameForIdentifier):
(WebCore::CryptoAlgorithmRegistry::create):
(WebCore::CryptoAlgorithmRegistry::registerAlgorithm):

  • crypto/CryptoAlgorithmRegistry.h:
  • inspector/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::~WorkerDebuggerAgent):
(WebCore::WorkerDebuggerAgent::interruptAndDispatchInspectorCommands):

  • workers/WorkerThread.cpp:

(WebCore::threadSetMutex):
(WebCore::workerThreads):
(WebCore::WorkerThread::workerThreadCount):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::~WorkerThread):
(WebCore::WorkerThread::releaseFastMallocFreeMemoryInAllThreads):

Source/WTF:

  • wtf/Forward.h:

Forward declare NeverDestroyed.

11:24 AM Changeset in webkit [161817] by weinig@apple.com
  • 11 edits
    7 adds in trunk/Source

Split ICU UText providers out into their own files
https://bugs.webkit.org/show_bug.cgi?id=126834

Reviewed by Anders Carlsson.

Moves the implementation of our custom UText providers out into
their own files.

  • UTextProviderLatin1.h/cpp contains the Latin-1 provider.
  • UTextProviderUTF16.h/cpp contains the UTF-16 provider.
  • UTextProvider.h/cpp contains code common to all the providers.
  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • PlatformGTK.cmake:
  • WebCore.vcxproj/WebCoreCommon.props:
  • WebCore.vcxproj/copyForwardingHeaders.cmd:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/text/TextAllInOne.cpp:
  • platform/text/TextBreakIteratorICU.cpp:

(WebCore::setUpIterator):
(WebCore::wordBreakIterator):
(WebCore::acquireLineBreakIterator):
(WebCore::sentenceBreakIterator):
(WebCore::setUpIteratorWithRules):

  • platform/text/icu: Added.
  • platform/text/icu/UTextProvider.cpp: Added.

(WebCore::fixPointer):
(WebCore::uTextCloneImpl):

  • platform/text/icu/UTextProvider.h: Added.

(WebCore::uTextProviderContext):
(WebCore::uTextInitialize):
(WebCore::uTextAccessPinIndex):
(WebCore::uTextAccessInChunkOrOutOfRange):

  • platform/text/icu/UTextProviderLatin1.cpp: Added.
  • platform/text/icu/UTextProviderLatin1.h: Added.
  • platform/text/icu/UTextProviderUTF16.cpp: Added.
  • platform/text/icu/UTextProviderUTF16.h: Added.
11:15 AM Changeset in webkit [161816] by Carlos Garcia Campos
  • 13 edits in trunk

Unreviewed. Fix make distcheck.

Source/JavaScriptCore:

  • GNUmakefile.am: Add inline-and-minify-stylesheets-and-scripts.py

to EXTRA_DIST and fix InjectedScriptSource.h generation rule.

  • GNUmakefile.list.am: Move InjectedScriptSource.h to

built_nosources to make sure it's not disted.

Source/WebCore:

  • GNUmakefile.list.am: Add missing files.

Source/WebKit/gtk:

  • GNUmakefile.am: Add enum types template files to EXTRA_DIST.

Source/WebKit2:

  • GNUmakefile.am: Add WebKit2InspectorGResourceBundle.xml to

EXTRA_DIST.

  • GNUmakefile.list.am: Removed deleted files and add missing ones.
  • NetworkProcess/unix/NetworkProcessMainUnix.cpp: Move

ProxyResolverSoup.h to EFL platform ifdef, because GTK port doesn't
build the proxy resolver.

Tools:

  • gtk/GNUmakefile.am: Add generate-inspector-gresource-manifest.py

to EXTRA_DIST.

11:01 AM Changeset in webkit [161815] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix some CoreVideo linker errors on iOS by softlinking with more CoreVideo
symbols.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
10:55 AM Changeset in webkit [161814] by akling@apple.com
  • 3 edits
    2 adds in trunk

REGRESSION(r160806): line-height is not applied when only present in :link style.
<http://webkit.org/b/126839>
<rdar://problem/15799899>

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/css/line-height-link-style.html

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::CascadedProperties::Property::apply):

Use the CSSValue for SelectorChecker::MatchLink when applying
style inside a link.

LayoutTests:

  • fast/css/line-height-link-style-expected.txt: Added.
  • fast/css/line-height-link-style.html: Added.
10:47 AM Changeset in webkit [161813] by ddkilzer@apple.com
  • 3 edits in trunk/Source/WebCore

[iOS] Fix link errors for iOS: Part 3

  • WebCore.exp.in:
  • Move some Mac-only symbols to Mac-only section.
  • WebCore.xcodeproj/project.pbxproj:
  • Add missing references to AuthenticationCF.cpp and CookieJarCFNet.cpp.
9:33 AM Changeset in webkit [161812] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Remove unsafe uses of AtomicallyInitializedStatic
https://bugs.webkit.org/show_bug.cgi?id=126838

Reviewed by Andreas Kling.

AtomicStrings are per thread so any static initialization of them is potentially dangerous
unless it's certain that they're only ever used from the same thread.

This goes against using them with AtomicallyInitializedStatic, so just create AtomicStrings where needed.
(This is highly unlikely to have any real negative performance impact since these two functions
aren't called very frequently).

  • loader/CrossOriginAccessControl.cpp:

(WebCore::passesAccessControlCheck):

  • page/PerformanceResourceTiming.cpp:

(WebCore::passesTimingAllowCheck):

9:29 AM Changeset in webkit [161811] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Fix link errors for iOS: Part 2

  • WebCore.exp.in:
  • Move some Mac-only symbols to Mac-only section.
9:13 AM Changeset in webkit [161810] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] First of many iOS fixes to WebCore.exp.in

  • WebCore.exp.in:
  • Move some Mac-only symbols to Mac-only section.
  • Upstream some changes to iOS-only section.
8:56 AM Changeset in webkit [161809] by ddkilzer@apple.com
  • 4 edits in trunk/Source/WebCore

[iOS] Don't link to Mac-only frameworks when building iOS
<http://webkit.org/b/126841>

  • Configurations/WebCore.xcconfig:

(OTHER_LDFLAGS_iphonesimulator): Remove common frameworks that
are already in the Xcode project.
(OTHER_LDFLAGS_macosx): Add Mac-only frameworks removed from the
Xcode project.

  • Configurations/WebCoreTestShim.xcconfig:

(OTHER_LDFLAGS[sdk=macosx*]): Link to Carbon.framework for Mac
since it was removed from the Xcode project.

  • WebCore.xcodeproj/project.pbxproj: Remove Mac-only frameworks.
8:15 AM Changeset in webkit [161808] by commit-queue@webkit.org
  • 7 edits in trunk

Source/WebCore: --disable-dependency-tracking causes build failure due to missing directories
https://bugs.webkit.org/show_bug.cgi?id=94488

Patch by Tobias Mueller <tobiasmue@gnome.org> on 2014-01-12
Reviewed by Gustavo Noronha Silva.

Ensure output directory existing
before generating DerivedSources. This allows for
--disable-dependency-tracking to be run.

  • GNUmakefile.am: Added new target DerivedSources/ANGLE which is a directory to be created
  • bindings/gobject/GNUmakefile.am: Added new target DerivedSources/webkitdom which is a directory to be created

Source/WebKit/gtk: --disable-dependency-tracking causes build failure due to missing directories
https://bugs.webkit.org/show_bug.cgi?id=94488

Patch by Tobias Mueller <tobiasmue@gnome.org> on 2014-01-12
Reviewed by Gustavo Noronha Silva.

Autotools build fix: Ensure output directory existing
before generating DerivedSources. This allows for
--disable-dependency-tracking to be run.

  • GNUmakefile.am: Added a new target of the directory in which files are meant to be stored ($(GENSOURCES_WEBKIT)).

Tools: --disable-dependency-tracking causes build failure due to missing directories
https://bugs.webkit.org/show_bug.cgi?id=94488

Patch by Tobias Mueller <tobiasmue@gnome.org> on 2014-01-12
Reviewed by Gustavo Noronha Silva.

Autotools build fix: Ensure output directory existing
before generating DerivedSources. This allows for
--disable-dependency-tracking to be run.

  • WebKitTestRunner/GNUmakefile.am: Added a new target of the directory in which files are meant to be stored.
8:09 AM Changeset in webkit [161807] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] WebFontCache is Mac-only

  • WebCore.exp.in: Move export to Mac-only section.
8:09 AM Changeset in webkit [161806] by ddkilzer@apple.com
  • 2 edits
    2 adds in trunk/Source/WebCore

[iOS] Upstream WebEventRegion.{h|mm} to fix the build

  • WebCore.xcodeproj/project.pbxproj: Add to project.
  • page/ios/WebEventRegion.h: Added.
  • page/ios/WebEventRegion.mm: Added.

(-[WebEventRegion initWithPoints::::]):
(-[WebEventRegion copyWithZone:]):
(-[WebEventRegion description]):
(-[WebEventRegion hitTest:]):
(-[WebEventRegion isEqual:]):
(-[WebEventRegion quad]):

12:45 AM Changeset in webkit [161805] by Carlos Garcia Campos
  • 4 edits in trunk

[GTK] Fix return value of WebKitDownload::created-destination
https://bugs.webkit.org/show_bug.cgi?id=126741

Reviewed by Martin Robinson.

Source/WebKit2:

WebKitDownload::created-destination signal should be void instead
of gboolean. This doesn't break the API/ABI.

  • UIProcess/API/gtk/WebKitDownload.cpp:

(webkit_download_class_init):
(webkitDownloadDestinationCreated):

Tools:

  • TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp: Fix return

value of several callbacks.

Jan 11, 2014:

11:31 PM Changeset in webkit [161804] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

Support bool argument for encoding/decoding invocations.
https://bugs.webkit.org/show_bug.cgi?id=126823

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-01-11
Reviewed by Sam Weinig.

For remote invocation method argument, current we support int, double and ObjC
object, this patch add support for bool type too.

  • Shared/API/Cocoa/WKRemoteObjectCoder.mm:

(encodeInvocation):
(decodeInvocationArguments):

11:15 PM Changeset in webkit [161803] by ap@apple.com
  • 3 edits in trunk/WebKitLibraries

[Mac] [Windows] Stop scheduling network requests in WebCore
https://bugs.webkit.org/show_bug.cgi?id=126789
<rdar://problem/15114727>

Update Windows WKSI.

  • win/include/WebKitSystemInterface/WebKitSystemInterface.h:
  • win/lib32/WebKitSystemInterface.lib:
11:15 PM Changeset in webkit [161802] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WTF

Unreviewed build fix for ports using GCC after r161770.

  • wtf/IteratorAdaptors.h:

(WTF::FilterIterator::operator*): Replicating r161797, the const qualifier for
FilterIterator::operator*() is removed since it clashes with some iterator types
that are also const, causing compilation failures with GCC.

10:30 PM Changeset in webkit [161801] by andersca@apple.com
  • 4 edits in trunk/Source

Use std::call_once instead of AtomicallyInitializedStatic when creating a HTTP header set
https://bugs.webkit.org/show_bug.cgi?id=126837

Reviewed by Sam Weinig.

Source/WebCore:

Use std::call_once when constructing the HTTPHeaderSet.

  • loader/CrossOriginAccessControl.cpp:

(WebCore::isOnAccessControlResponseHeaderWhitelist):

Source/WTF:

  • wtf/HashSet.h:

(WTF::HashSet::HashSet):
Add a HashSet constructor that takes an initializer list.

9:59 PM Changeset in webkit [161800] by ddkilzer@apple.com
  • 3 edits in trunk/Source/WebCore

[iOS] Do not link to ApplicationServices.framework for iOS
<http://webkit.org/b/126835>

Reviewed by Dan Bernstein.

  • Configurations/WebCore.xcconfig:

(OTHER_LDFLAGS_macosx): Add -framework ApplicationServices.

  • WebCore.xcodeproj/project.pbxproj: Remove reference to

ApplicationServices.framework.

9:27 PM Changeset in webkit [161799] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Build fix for StyleResolver.cpp

  • rendering/style/RenderStyle.h:

(WebCore::RenderStyle::setCompositionFillColor): Added.

8:56 PM Changeset in webkit [161798] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Fix build of RenderLayerCompositor::registerAllViewportConstrainedLayers()

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::registerAllViewportConstrainedLayers):
Fix use of std::make_unique<>() and add an adoptPtr() call.

8:33 PM Changeset in webkit [161797] by weinig@apple.com
  • 2 edits in trunk/Source/WTF

Fix the EFL build.

  • wtf/IteratorAdaptors.h:

(WTF::TransformIterator::operator*):

8:20 PM Changeset in webkit [161796] by ap@apple.com
  • 23 edits in trunk

[Mac] [Windows] Stop scheduling network requests in WebCore
https://bugs.webkit.org/show_bug.cgi?id=126789
<rdar://problem/15114727>

Source/WebCore:

Reviewed by Sam Weinig.

We'll just send all requests to CFNetwork now, along with associated priorities.

  • WebCore.exp.in: WebKitSystemInterface functions are changing to support priorities

for more than just pipelining.

  • loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::scheduleLoad):

  • platform/ios/WebCoreSystemInterfaceIOS.mm:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:
  • platform/network/ResourceHandle.h: For syncronous requests, make it so that they

don't count against HTTP connection limit, to avoid the possibility of hanging the process.

  • platform/network/cf/ResourceHandleCFNet.cpp:

(WebCore::ResourceHandle::createCFURLConnection):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):

  • platform/network/cf/ResourceRequestCFNet.cpp:

(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::initializeMaximumHTTPConnectionCountPerHost):
(WebCore::initializeHTTPConnectionSettingsOnStartup):

  • platform/network/cf/ResourceRequestCFNet.h:

(WebCore::toPlatformRequestPriority):

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::createNSURLConnection):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):

  • platform/network/mac/ResourceRequestMac.mm:

(WebCore::ResourceRequest::doUpdateResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):

Source/WebKit/mac:

Reviewed by Sam Weinig.

  • WebCoreSupport/WebSystemInterface.mm: (InitWebCoreSystemInterface): Updated

for new WKSI function names.

Source/WebKit2:

Reviewed by Sam Weinig.

  • NetworkProcess/mac/NetworkResourceLoadSchedulerMac.mm:

(WebKit::NetworkResourceLoadScheduler::platformInitializeMaximumHTTPConnectionCountPerHost):
We no longer need the trick with 7 connections, as synchronous requests always have
the right of way.

  • UIProcess/API/C/WKContext.cpp: Removed long obsolete functions.
  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm: (InitWebCoreSystemInterface):

Updated for new WKSI function names.

WebKitLibraries:

Update WKSI.

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMavericks.a:
  • libWebKitSystemInterfaceMountainLion.a:
8:13 PM Changeset in webkit [161795] by ddkilzer@apple.com
  • 3 edits in trunk/Source/WebCore

[iOS] Fix build failure in WebCore::findEndWordBoundary()

Filed Bug 126830 for the proper fix:
<http://webkit.org/b/126830>

  • editing/VisibleUnits.cpp:

(WebCore::endWordBoundary): Switch back to using
WebCore::findWordBoundary() on iOS.

  • platform/text/mac/TextBoundaries.mm:

(WebCore::findEndWordBoundary): Add FIXME for iOS implementation
that doesn't use NSAttributedString.

7:53 PM Changeset in webkit [161794] by Brent Fulgham
  • 3 edits
    1 add in trunk/LayoutTests

[WebGL] Correct uniform input validation for texture sampler uniforms
https://bugs.webkit.org/show_bug.cgi?id=126775

Reviewed by Anders Carlsson.

  • fast/canvas/webgl/uniform-samplers-test-expected.txt: Added.
  • fast/canvas/webgl/uniform-samplers-test.html: Corrected resource

includes when moving from khronos suite to our fast suite.

  • resources/js-test-pre.js:

(expectTrue): Added.

7:23 PM Changeset in webkit [161793] by andersca@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Try again to fix the build.

  • inspector/InspectorAgentRegistry.cpp:
  • inspector/InspectorAgentRegistry.h:
7:00 PM Changeset in webkit [161792] by andersca@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Try to prevent the Vector copy constructor from being instantiated.

  • inspector/InspectorAgentRegistry.cpp:

(Inspector::InspectorAgentRegistry::InspectorAgentRegistry):

  • inspector/InspectorAgentRegistry.h:
6:56 PM Changeset in webkit [161791] by andersca@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Try something else.

  • inspector/InspectorAgentRegistry.cpp:

(Inspector::InspectorAgentRegistry::~InspectorAgentRegistry):

  • inspector/InspectorAgentRegistry.h:
6:51 PM Changeset in webkit [161790] by aestes@apple.com
  • 6 edits in trunk/Source/WebCore

[iOS] Move text autosizing code from RenderBlock to RenderBlockFlow
https://bugs.webkit.org/show_bug.cgi?id=126829

Reviewed by Sam Weinig.

Some newly-upstreamed iOS text autosizing code needs to move to
RenderBlockFlow in order to build.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::RenderBlock):

  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::RenderBlockFlow):
(WebCore::isVisibleRenderText):
(WebCore::resizeTextPermitted):
(WebCore::RenderBlockFlow::immediateLineCount):
(WebCore::isNonBlocksOrNonFixedHeightListItems):
(WebCore::oneLineTextMultiplier):
(WebCore::textMultiplier):
(WebCore::RenderBlockFlow::adjustComputedFontSizes):

  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::resetComputedFontSize):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::adjustComputedFontSizesOnBlocks):
(WebCore::RenderObject::resetTextAutosizing):

6:51 PM Changeset in webkit [161789] by Brent Fulgham
  • 5 edits
    3 adds in trunk

[JSC] Revise typed array implementations to match ECMAScript and WebGL Specification
https://bugs.webkit.org/show_bug.cgi?id=126754

Patch by Dean Jackson <dino@apple.com> on 2014-01-11
Reviewed by Filip Pizlo.

Source/JavaScriptCore:

The ECMAScript specification forbids calling the typed array
constructors without using "new". Change the call data to return
none so we throw and exception in these cases.

  • runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):

LayoutTests:

New test which checks that we throw an exception when calling
any of the typed array constructors without using "new".

  • js/script-tests/typedarray-constructors.js: Added.
  • js/typedarray-constructors-expected.txt: Added.
  • js/typedarray-constructors.html: Added.
  • resources/standalone-pre.js: Add missing 'shouldNotThrow'

method (duplicated from resources/js-test-pre.js)

6:49 PM Changeset in webkit [161788] by andersca@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Try to fix the build by introducing a constructor.

  • inspector/InspectorAgentRegistry.cpp:

(Inspector::InspectorAgentRegistry::InspectorAgentRegistry):

  • inspector/InspectorAgentRegistry.h:
6:43 PM Changeset in webkit [161787] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore
  • inspector/InspectorAgentRegistry.h:

Remove an unused function.

6:25 PM Changeset in webkit [161786] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

[iOS] Fix the build

Only call CGContextFlush() when building for OS X < 10.9.

  • platform/graphics/cg/ImageBufferBackingStoreCache.cpp:

(WebCore::ImageBufferBackingStoreCache::deallocate):

5:54 PM Changeset in webkit [161785] by weinig@apple.com
  • 4 edits
    1 add in trunk

Add support for null StringViews
https://bugs.webkit.org/show_bug.cgi?id=126827

Reviewed by Anders Carlsson.

Source/WTF:

  • Do some style cleanup while in the neighborhood.
  • wtf/text/StringView.h:

(WTF::StringView::StringView):
Add default constructor to create a null StringView.

(WTF::StringView::isNull):
Add isNull(), matching the semantics of String.

(WTF::StringView::operator bool):
Add an explicit operator bool() to allow use in if-statements.

Tools:

Add new test for StringView.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/StringView.cpp: Added.

(TestWebKitAPI::TEST):

4:54 PM Changeset in webkit [161784] by andersca@apple.com
  • 39 edits in trunk/Source

InspectorAgentRegistry should use std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=126826

Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • inspector/InspectorAgentRegistry.cpp:

(Inspector::InspectorAgentRegistry::append):

  • inspector/InspectorAgentRegistry.h:
  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):

  • inspector/agents/InspectorAgent.h:

Source/WebCore:

  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorCanvasAgent.h:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMDebuggerAgent.cpp:
  • inspector/InspectorDOMDebuggerAgent.h:
  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorHeapProfilerAgent.cpp:
  • inspector/InspectorHeapProfilerAgent.h:
  • inspector/InspectorIndexedDBAgent.h:
  • inspector/InspectorInputAgent.h:
  • inspector/InspectorLayerTreeAgent.h:
  • inspector/InspectorMemoryAgent.cpp:
  • inspector/InspectorMemoryAgent.h:
  • inspector/InspectorPageAgent.cpp:
  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::create):

  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorTimelineAgent.h:
  • inspector/InspectorWorkerAgent.cpp:
  • inspector/InspectorWorkerAgent.h:
  • inspector/PageConsoleAgent.h:
  • inspector/PageDebuggerAgent.cpp:
  • inspector/PageDebuggerAgent.h:
  • inspector/PageRuntimeAgent.h:
  • inspector/WorkerConsoleAgent.h:
  • inspector/WorkerDebuggerAgent.cpp:
  • inspector/WorkerDebuggerAgent.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):

  • inspector/WorkerRuntimeAgent.h:
2:56 PM Changeset in webkit [161783] by commit-queue@webkit.org
  • 8 edits
    1 copy
    1 add in trunk/Source/WebCore

Extract the FormatConverter class out of GraphicsContext3D.cpp and into its own file
https://bugs.webkit.org/show_bug.cgi?id=126820

Patch by Sam Weinig <sam@webkit.org> on 2014-01-11
Reviewed by Anders Carlsson.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/FormatConverter.cpp: Copied from Source/WebCore/platform/graphics/GraphicsContext3D.cpp.

(WebCore::convertFloatToHalfFloat):
(WebCore::FormatConverter::convert):

  • platform/graphics/FormatConverter.h: Copied from Source/WebCore/platform/graphics/GraphicsContext3D.cpp.

(WebCore::FormatConverter::FormatConverter):
(WebCore::FormatConverter::success):

  • platform/graphics/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::computeFormatAndTypeParameters):
(WebCore::GraphicsContext3D::computeImageSizeInBytes):
(WebCore::GraphicsContext3D::packImageData):
(WebCore::GraphicsContext3D::extractImageData):
(WebCore::GraphicsContext3D::extractTextureData):
(WebCore::GraphicsContext3D::packPixels):

  • platform/graphics/GraphicsContext3D.h:

(WebCore::GraphicsContext3D::hasAlpha):
(WebCore::GraphicsContext3D::hasColor):

1:58 PM Changeset in webkit [161782] by fpizlo@apple.com
  • 2 edits in branches/jsCStack/Source/JavaScriptCore

Eliminate obviously redundant InvalidationPoints
https://bugs.webkit.org/show_bug.cgi?id=126825

Not yet reviewed.

  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::invalidationPointElimination):
(JSC::DFG::CSEPhase::performNodeCSE):

1:03 PM Changeset in webkit [161781] by fpizlo@apple.com
  • 1 edit
    1 add in branches/jsCStack/Source/JavaScriptCore

Unreviewed, add a test for InvalidationPoint in the FTL.

Probably there are other tests that cover this in various ways and it's possible
that we're just not running those tests in the FTL, yet. But anyway I think it's
good to have an FTL-specific test for this.

  • tests/stress/invalidation-point.js: Added.

(foo):
(Thingy):
(Thingy.prototype.f):
(possiblyDoBadThings.Thingy.prototype.f):
(possiblyDoBadThings):

12:59 PM Changeset in webkit [161780] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix updateScrollingLayerWithClient() for iOS.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::updateScrollingLayerWithClient):

12:59 PM Changeset in webkit [161779] by Simon Fraser
  • 11 edits in trunk/Source

Unfork GraphicsContext::drawNativeImage for iOS
https://bugs.webkit.org/show_bug.cgi?id=126824

Reviewed by Dean Jackson.

GraphicsContext::drawNativeImage had a different signature for iOS,
which required #ifdefs at all the call sites. Unfork by passing the "scale"
parameter everywhere (it's only used on iOS).

Source/WebCore:

  • WebCore.exp.in:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::BitmapImage::draw):

  • platform/graphics/cg/GraphicsContext3DCG.cpp:

(WebCore::GraphicsContext3D::paintToCanvas):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::platformInit):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/ios/IconIOS.mm:

(WebCore::Icon::paint):

Source/WebKit2:

  • Shared/API/c/cg/WKImageCG.cpp:

(WKImageCreateFromCGImage):

12:59 PM Changeset in webkit [161778] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Work around USE(CFNETWORK) build failure on iOS.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForResponseToAuthenticationChallenge):

12:56 PM Changeset in webkit [161777] by ddkilzer@apple.com
  • 3 edits
    1 add in trunk/Source/ThirdParty

[iOS] Upstream gtest
<http://webkit.org/b/126811>

Reviewed by Mark Rowe.

  • gtest/xcode/Config/General.xcconfig: Include iOS.xcconfig.
  • gtest/xcode/Config/iOS.xcconfig: Added.
  • gtest/xcode/gtest.xcodeproj/project.pbxproj: Add iOS.xcconfig.

Sort.

12:31 PM Changeset in webkit [161776] by fpizlo@apple.com
  • 4 edits in branches/jsCStack/Source/JavaScriptCore

FTL tier-up should behave the same with CountExecution's as it does without
https://bugs.webkit.org/show_bug.cgi?id=126822

Not yet reviewed.

CountExecution nodes are inserted by the profiler. Prior to this change, their
presence would change how we inserted CheckTierUp nodes, since a CountExecution
might be inserted before a LoopHint thereby making it so the LoopHint was no
longer at the top of a loop header. This makes the code resilient against such
things. The result is that when you enable the profiler, you get the same OSR
behavior as with the profiler disabled.

  • dfg/DFGNode.h:

(JSC::DFG::Node::isSemanticallySkippable):

  • dfg/DFGOSREntrypointCreationPhase.cpp:

(JSC::DFG::OSREntrypointCreationPhase::run):

  • dfg/DFGTierUpCheckInjectionPhase.cpp:

(JSC::DFG::TierUpCheckInjectionPhase::run):

12:05 PM Changeset in webkit [161775] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix LegacyWebArchive.cpp:567:91: error: calling 'utf8' with incomplete return type 'WTF::CString'

  • loader/archive/cf/LegacyWebArchive.cpp:
12:03 PM Changeset in webkit [161774] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Fix the easy half of the build errors in RenderBlock.cpp

  • rendering/RenderBlock.cpp:

(WebCore::isNonBlocksOrNonFixedHeightListItems):
(WebCore::oneLineTextMultiplier):
(WebCore::textMultiplier):
(WebCore::RenderBlock::adjustComputedFontSizes):

11:56 AM Changeset in webkit [161773] by Simon Fraser
  • 7 edits in trunk/Source/WebCore

Change touch-related headers to include WebKitAdditions headers,
which have been renamed to have IOS suffixes.

  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ios/TouchConstructors.cpp:
  • dom/Touch.h:
  • dom/TouchEvent.h:
  • dom/TouchList.h:
  • dom/ios/TouchEvents.cpp:
11:48 AM Changeset in webkit [161772] by mitz@apple.com
  • 2 edits in trunk

[Mac] xcodebuild color output is suppressed when using make
https://bugs.webkit.org/show_bug.cgi?id=126815

Reviewed by Anders Carlsson.

WHen using make, xcodebuild’s output is piped through a filter, which causes it not to
format its output with color and emphasis.

  • Makefile.shared: Pass COLOR_DIAGNOSTICS=YES to xcodebuild to force color output on. Due to

xcodebuild limitations, this restores some of the formatting, but not all of it.

11:31 AM Changeset in webkit [161771] by andersca@apple.com
  • 8 edits in trunk/Source/WebCore

ScriptDebugServer should use a separate member function for its timer handler
https://bugs.webkit.org/show_bug.cgi?id=126819

Reviewed by Sam Weinig.

It's weird to have subclasses override a timer handler and sometimes invoke
the timer handler directly so make it a separate member function instead.

  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::recompileAllJSFunctions):

  • bindings/js/PageScriptDebugServer.h:
  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::recompileAllJSFunctionsTimerFired):

  • bindings/js/ScriptDebugServer.h:
  • bindings/js/WorkerScriptDebugServer.cpp:

(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):

  • bindings/js/WorkerScriptDebugServer.h:
  • inspector/InspectorProfilerAgent.cpp:

(WebCore::InspectorProfilerAgent::start):

11:17 AM Changeset in webkit [161770] by weinig@apple.com
  • 10 edits
    2 moves in trunk/Source

Clean up iterator filter / iterator range code
https://bugs.webkit.org/show_bug.cgi?id=126817

Reviewed by Anders Carlsson.

Source/WebKit2:

  • Shared/APIArray.h:

Update elementsOfType() to use combination of FilterIterator and TransformIterator
(now that FilterIterator no longer has a transform predicate) and make use of the
makeFoo() helpers.

Source/WTF:

  • Renames IteratorPair to IteratorRange.
  • Splits FilterIterator into FilterIterator (which now only filters) and TransformIterator (which does the transform part of the old FilterIterator). Move both of these to IteratorAdaptors.h
  • GNUmakefile.list.am:
  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/FilterIterator.h: Removed.

Add/remove files.

  • wtf/HashMap.h:

(WTF::HashMap::keys):
(WTF::HashMap::values):

  • wtf/RefPtrHashMap.h:

Update for rename to IteratorRange. Simplify by using makeIteratorRange().

  • wtf/IteratorAdaptors.h: Copied from wtf/FilterIterator.h.

(WTF::FilterIterator::FilterIterator):
(WTF::FilterIterator::operator*):
(WTF::makeFilterIterator):
(WTF::TransformIterator::TransformIterator):
(WTF::TransformIterator::operator++):
(WTF::TransformIterator::operator*):
(WTF::TransformIterator::operator==):
(WTF::TransformIterator::operator!=):
(WTF::makeTransformIterator):
Split up filtering and transforming. Add makeFilterIterator() and makeTransformIterator()
helpers.

  • wtf/IteratorPair.h: Removed.
  • wtf/IteratorRange.h: Copied from wtf/IteratorPair.h.

(WTF::IteratorRange::IteratorRange):
(WTF::makeIteratorRange):
Renamed to IteratorRange and adds makeIteratorRange() helper.

11:16 AM Changeset in webkit [161769] by andersca@apple.com
  • 4 edits in trunk/Source

Simplify Timer and DeferrableOneShotTimer using std::function
https://bugs.webkit.org/show_bug.cgi?id=126816

Reviewed by Sam Weinig.

Source/WebCore:

  • platform/Timer.h:

(WebCore::Timer::Timer):

Source/WebKit2:

Add another unexported symbol.

  • Configurations/WebKit2.xcconfig:
10:19 AM Changeset in webkit [161768] by andersca@apple.com
  • 133 edits in trunk/Source/WebCore

CTTE Timer and DeferrableOneShotTimer
https://bugs.webkit.org/show_bug.cgi?id=126814

Reviewed by Antti Koivisto.

Add new Timer and DeferrableOneShotTimer constructors whose member function pointers
take a reference instead of a pointer.
Also, convert a bunch of classes over to using these new constructors.

  • Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::keyRequestTimerFired):
(WebCore::MediaKeySession::addKeyTimerFired):

  • Modules/encryptedmedia/MediaKeySession.h:
  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::GeoNotifier::timerFired):
(WebCore::Geolocation::resumeTimerFired):

  • Modules/geolocation/Geolocation.h:
  • Modules/indexeddb/IDBTransactionBackend.cpp:

(WebCore::IDBTransactionBackend::taskTimerFired):

  • Modules/indexeddb/IDBTransactionBackend.h:
  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::appendBufferTimerFired):

  • Modules/mediasource/SourceBuffer.h:
  • Modules/notifications/Notification.cpp:

(WebCore::Notification::taskTimerFired):

  • Modules/notifications/Notification.h:
  • Modules/notifications/NotificationCenter.cpp:

(WebCore::NotificationCenter::NotificationRequestCallback::timerFired):

  • Modules/notifications/NotificationCenter.h:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::notificationPostTimerFired):

  • accessibility/AXObjectCache.h:
  • css/CSSFontSelector.cpp:

(WebCore::CSSFontSelector::beginLoadTimerFired):

  • css/CSSFontSelector.h:
  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::CachedGeneratedImage::evictionTimerFired):

  • css/CSSImageGeneratorValue.h:
  • dom/Document.cpp:

(WebCore::Document::visualUpdatesSuppressionTimerFired):
(WebCore::Document::styleRecalcTimerFired):
(WebCore::Document::optimizedStyleSheetUpdateTimerFired):
(WebCore::Document::sharedObjectPoolClearTimerFired):
(WebCore::Document::styleResolverThrowawayTimerFired):
(WebCore::Document::updateFocusAppearanceTimerFired):
(WebCore::Document::resetHiddenFocusElementTimer):
(WebCore::Document::pendingTasksTimerFired):
(WebCore::Document::fullScreenChangeDelayTimerFired):
(WebCore::Document::loadEventDelayTimerFired):
(WebCore::Document::didAssociateFormControlsTimerFired):

  • dom/Document.h:
  • dom/EventSender.h:

(WebCore::EventSender::timerFired):

  • dom/GenericEventQueue.cpp:

(WebCore::GenericEventQueue::timerFired):

  • dom/GenericEventQueue.h:
  • dom/ScriptRunner.cpp:

(WebCore::ScriptRunner::timerFired):

  • dom/ScriptRunner.h:
  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::animationTimerFired):

  • dom/ScriptedAnimationController.h:
  • editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::timerFired):

  • editing/AlternativeTextController.h:
  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::caretBlinkTimerFired):

  • editing/FrameSelection.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • html/HTMLMediaElement.h:
  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::swapRendererTimerFired):

  • html/HTMLPlugInElement.h:
  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::removeSnapshotTimerFired):
(WebCore::HTMLPlugInImageElement::simulatedMouseClickTimerFired):

  • html/HTMLPlugInImageElement.h:
  • html/HTMLSourceElement.cpp:

(WebCore::HTMLSourceElement::errorEventTimerFired):

  • html/HTMLSourceElement.h:
  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::loadTimerFired):

  • html/HTMLTrackElement.h:
  • html/MediaController.cpp:

(MediaController::asyncEventTimerFired):
(MediaController::clearPositionTimerFired):
(MediaController::timeupdateTimerFired):

  • html/MediaController.h:
  • html/MediaDocument.cpp:

(WebCore::MediaDocument::replaceMediaElementTimerFired):

  • html/MediaDocument.h:
  • html/parser/HTMLParserScheduler.cpp:

(WebCore::HTMLParserScheduler::continueNextChunkTimerFired):

  • html/parser/HTMLParserScheduler.h:
  • html/shadow/MediaControlElementTypes.cpp:

(WebCore::MediaControlSeekButtonElement::seekTimerFired):

  • html/shadow/MediaControlElementTypes.h:
  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlPanelElement::transitionTimerFired):
(WebCore::MediaControlTextTrackContainerElement::updateTimerFired):

  • html/shadow/MediaControlElements.h:
  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::hideFullscreenControlsTimerFired):

  • html/shadow/MediaControls.h:
  • html/track/LoadableTextTrack.cpp:

(WebCore::LoadableTextTrack::loadTimerFired):

  • html/track/LoadableTextTrack.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::UpdateRegionLayoutTask::UpdateRegionLayoutTask):
(WebCore::UpdateRegionLayoutTask::timerFired):
(WebCore::ChangeRegionOversetTask::ChangeRegionOversetTask):
(WebCore::ChangeRegionOversetTask::timerFired):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::RevalidateStyleAttributeTask::RevalidateStyleAttributeTask):
(WebCore::RevalidateStyleAttributeTask::timerFired):

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorBackendDispatchTask::InspectorBackendDispatchTask):
(WebCore::InspectorBackendDispatchTask::timerFired):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):

  • loader/DocumentLoader.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkTimerFired):

  • loader/FrameLoader.h:
  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::timerFired):

  • loader/ImageLoader.h:
  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::linkLoadTimerFired):
(WebCore::LinkLoader::linkLoadingErrorTimerFired):

  • loader/LinkLoader.h:
  • loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::timerFired):

  • loader/NavigationScheduler.h:
  • loader/PingLoader.cpp:

(WebCore::PingLoader::PingLoader):

  • loader/PingLoader.h:

(WebCore::PingLoader::timeoutTimerFired):

  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::progressHeartbeatTimerFired):

  • loader/ProgressTracker.h:
  • loader/ResourceLoadScheduler.cpp:

(WebCore::ResourceLoadScheduler::requestTimerFired):

  • loader/ResourceLoadScheduler.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::decodedDataDeletionTimerFired):
(WebCore::CachedResource::CachedResourceCallback::timerFired):

  • loader/cache/CachedResource.h:
  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):

  • loader/cache/CachedResourceLoader.h:
  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::syncTimerFired):

  • loader/icon/IconDatabase.h:
  • page/AutoscrollController.cpp:

(WebCore::AutoscrollController::autoscrollTimerFired):

  • page/AutoscrollController.h:
  • page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::timerFired):

  • page/CaptionUserPreferences.h:
  • page/DeviceController.cpp:

(WebCore::DeviceController::fireDeviceEvent):

  • page/DeviceController.h:
  • page/EventHandler.cpp:

(WebCore::EventHandler::cursorUpdateTimerFired):
(WebCore::EventHandler::autoHideCursorTimerFired):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):
(WebCore::EventHandler::hoverTimerFired):

  • page/EventHandler.h:
  • page/EventSource.cpp:

(WebCore::EventSource::connectTimerFired):

  • page/EventSource.h:
  • page/FrameView.cpp:

(WebCore::FrameView::deferredRepaintTimerFired):
(WebCore::FrameView::layoutTimerFired):
(WebCore::FrameView::postLayoutTimerFired):

  • page/FrameView.h:
  • page/PageThrottler.cpp:

(WebCore::PageThrottler::throttleHysteresisTimerFired):

  • page/PageThrottler.h:
  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::updateStyleIfNeededDispatcherFired):
(WebCore::AnimationControllerPrivate::animationTimerFired):

  • page/animation/AnimationControllerPrivate.h:
  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::autoscrollTimerFired):

  • platform/Scrollbar.h:
  • platform/Timer.h:

(WebCore::Timer::Timer):
(WebCore::DeferrableOneShotTimer::DeferrableOneShotTimer):

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::advanceAnimation):

  • platform/graphics/BitmapImage.h:
  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::reloadTimerFired):

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/ca/mac/LayerPool.h:
  • platform/graphics/ca/mac/LayerPool.mm:

(WebCore::LayerPool::pruneTimerFired):

  • platform/graphics/cg/ImageBufferBackingStoreCache.cpp:

(WebCore::ImageBufferBackingStoreCache::timerFired):

  • platform/graphics/cg/ImageBufferBackingStoreCache.h:
  • platform/graphics/cg/SubimageCacheWithTimer.cpp:

(WebCore::SubimageCacheWithTimer::invalidateCacheTimerFired):

  • platform/graphics/cg/SubimageCacheWithTimer.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h:
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::MediaPlayerPrivateQTKit::seekTimerFired):

  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollAnimatorMac.mm:

(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
(WebCore::ScrollAnimatorMac::initialScrollbarPaintTimerFired):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):

  • platform/mock/DeviceOrientationClientMock.cpp:

(WebCore::DeviceOrientationClientMock::timerFired):

  • platform/mock/DeviceOrientationClientMock.h:
  • platform/network/NetworkStateNotifier.h:
  • platform/network/ResourceHandle.cpp:

(WebCore::ResourceHandle::failureTimerFired):

  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):

  • platform/network/mac/NetworkStateNotifierMac.cpp:

(WebCore::NetworkStateNotifier::networkStateChangeTimerFired):

  • rendering/ImageQualityController.cpp:

(WebCore::ImageQualityController::highQualityRepaintTimerFired):

  • rendering/ImageQualityController.h:
  • rendering/RenderButton.cpp:

(WebCore::RenderButton::timerFired):

  • rendering/RenderButton.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired):
(WebCore::RenderLayerCompositor::layerFlushTimerFired):
(WebCore::RenderLayerCompositor::paintRelatedMilestonesTimerFired):

  • rendering/RenderLayerCompositor.h:
  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::timerFired):

  • rendering/RenderMarquee.h:
  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::regionLayoutUpdateEventTimerFired):
(WebCore::RenderNamedFlowThread::regionOversetChangeEventTimerFired):

  • rendering/RenderNamedFlowThread.h:
  • rendering/RenderProgress.cpp:

(WebCore::RenderProgress::animationTimerFired):

  • rendering/RenderProgress.h:
8:58 AM Changeset in webkit [161767] by Simon Fraser
  • 4 edits in trunk/Source/WebCore
  • dom/Touch.h:
  • dom/TouchEvent.h:
  • dom/TouchList.h:
8:58 AM Changeset in webkit [161766] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

No need to include <ApplicationServices/ApplicationServices.h> in
the header. Can use <CoreGraphics/CoreGraphics.h> in the .cpp file.

  • platform/graphics/cg/ImageBufferBackingStoreCache.cpp:
  • platform/graphics/cg/ImageBufferBackingStoreCache.h:
8:58 AM Changeset in webkit [161765] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Fix DOM headers: TARGET_OS_EMBEDDED -> TARGET_OS_IPHONE
and a drive-by cleanup of DOMUIKitExtensions.mm #includes.

  • bindings/objc/DOMPrivate.h:
  • bindings/objc/DOMUIKitExtensions.h:
  • bindings/objc/DOMUIKitExtensions.mm:
8:29 AM Changeset in webkit [161764] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix use of GL_HALF_FLOAT_ARB on iOS.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::texSubImage2D):

8:29 AM Changeset in webkit [161763] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix build of SourceBufferPrivateAVFObjC.mm on iOS.

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
8:29 AM Changeset in webkit [161762] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix use of nonexistent kCGColorSpaceSRGB on iOS.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::sRGBColorSpaceRef):

7:51 AM Changeset in webkit [161761] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebCore

Web Inspector: Some ScriptDebugServer Cleanup
https://bugs.webkit.org/show_bug.cgi?id=126793

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-11
Reviewed by Timothy Hatcher.

  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::didContinue):
(WebCore::PageScriptDebugServer::runEventLoopWhilePaused):
Move the special iOS WebThread EventLoop nesting handling here.

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::ScriptDebugServer):
(WebCore::ScriptDebugServer::handlePause):

  • bindings/js/ScriptDebugServer.h:
  • inspector/InspectorDebuggerAgent.cpp:
  • inspector/InspectorDebuggerAgent.h:

Remove unused headers and functions.

6:17 AM Changeset in webkit [161760] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Add USE(IOSURFACE_CANVAS_BACKING_STORE) to fix build

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::ImageBuffer): The 'width' and 'height'
variables are only used by code protected by
USE(IOSURFACE_CANVAS_BACKING_STORE).

5:02 AM Changeset in webkit [161759] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Multisampling is not available on iOS

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::GraphicsContext3D):

12:52 AM Changeset in webkit [161758] by jinwoo7.song@samsung.com
  • 23 edits in trunk/Source/WebKit2

[EFL][WK2] Use nullptr instead of 0 in EFL API layer
https://bugs.webkit.org/show_bug.cgi?id=126806

Reviewed by Anders Carlsson.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::create):

  • UIProcess/API/efl/ewk_auth_request.cpp:

(ewk_auth_request_suggested_username_get):
(ewk_auth_request_realm_get):
(ewk_auth_request_host_get):

  • UIProcess/API/efl/ewk_back_forward_list.cpp:

(ewk_back_forward_list_current_item_get):
(ewk_back_forward_list_previous_item_get):
(ewk_back_forward_list_next_item_get):
(ewk_back_forward_list_item_at_index_get):
(ewk_back_forward_list_n_back_items_copy):
(ewk_back_forward_list_n_forward_items_copy):

  • UIProcess/API/efl/ewk_back_forward_list_item.cpp:

(ewk_back_forward_list_item_url_get):
(ewk_back_forward_list_item_title_get):
(ewk_back_forward_list_item_original_url_get):

  • UIProcess/API/efl/ewk_context.cpp:

(ewk_context_cookie_manager_get):
(ewk_context_database_manager_get):
(ewk_context_favicon_database_get):
(ewk_context_storage_manager_get):
(ewk_context_new_with_injected_bundle_path):

  • UIProcess/API/efl/ewk_context_menu.cpp:

(ewk_context_menu_items_get):

  • UIProcess/API/efl/ewk_context_menu_item.cpp:

(ewk_context_menu_item_new_with_submenu):
(ewk_context_menu_item_title_get):
(ewk_context_menu_item_parent_menu_get):
(ewk_context_menu_item_submenu_get):

  • UIProcess/API/efl/ewk_download_job.cpp:

(ewk_download_job_request_get):
(ewk_download_job_response_get):
(ewk_download_job_destination_get):
(ewk_download_job_suggested_filename_get):

  • UIProcess/API/efl/ewk_error.cpp:

(ewk_error_url_get):
(ewk_error_description_get):

  • UIProcess/API/efl/ewk_file_chooser_request.cpp:

(ewk_file_chooser_request_accepted_mimetypes_get):

  • UIProcess/API/efl/ewk_form_submission_request.cpp:

(ewk_form_submission_request_field_names_get):
(ewk_form_submission_request_field_value_get):

  • UIProcess/API/efl/ewk_navigation_data.cpp:

(ewk_navigation_data_title_get):
(ewk_navigation_data_original_request_get):
(ewk_navigation_data_url_get):

  • UIProcess/API/efl/ewk_navigation_policy_decision.cpp:

(ewk_navigation_policy_frame_name_get):
(ewk_navigation_policy_request_get):

  • UIProcess/API/efl/ewk_object.cpp:

(ewk_object_ref):

  • UIProcess/API/efl/ewk_popup_menu.cpp:

(ewk_popup_menu_items_get):

  • UIProcess/API/efl/ewk_popup_menu_item.cpp:

(ewk_popup_menu_item_text_get):
(ewk_popup_menu_item_tooltip_get):
(ewk_popup_menu_item_accessibility_text_get):

  • UIProcess/API/efl/ewk_security_origin.cpp:

(ewk_security_origin_host_get):
(ewk_security_origin_protocol_get):

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_default_text_encoding_name_get):

  • UIProcess/API/efl/ewk_url_request.cpp:

(ewk_url_request_url_get):
(ewk_request_cookies_first_party_get):
(ewk_url_request_http_method_get):

  • UIProcess/API/efl/ewk_url_response.cpp:

(ewk_url_response_url_get):
(ewk_url_response_mime_type_get):

  • UIProcess/API/efl/ewk_url_scheme_request.cpp:

(ewk_url_scheme_request_scheme_get):
(ewk_url_scheme_request_url_get):
(ewk_url_scheme_request_path_get):

  • UIProcess/API/efl/ewk_view.cpp:

(toEwkViewChecked):
(EWKViewGetWKView):
(ewk_view_smart_add):
(ewk_view_add_with_context):
(ewk_view_context_get):
(ewk_view_page_group_get):
(ewk_view_url_get):
(ewk_view_favicon_get):
(ewk_view_settings_get):
(ewk_view_title_get):
(ewk_view_theme_get):
(ewk_view_back_forward_list_get):
(ewk_view_custom_encoding_get):
(ewk_view_user_agent_get):

12:34 AM Changeset in webkit [161757] by bshafiei@apple.com
  • 5 edits in tags/Safari-538.10.3/Source

Versioning.

12:31 AM Changeset in webkit [161756] by bshafiei@apple.com
  • 1 copy in tags/Safari-538.10.3

New tag.

12:11 AM Changeset in webkit [161755] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/efl

Build fix.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::progressStarted):

Jan 10, 2014:

11:43 PM Changeset in webkit [161754] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Fix build for HTMLImageElement::willRespondToMouseClickEvents()

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::willRespondToMouseClickEvents):

11:38 PM Changeset in webkit [161753] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Fix test crashes.

  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::~ProgressTracker):
Comment out the call to progressTrackerDestroyed for now.

11:34 PM Changeset in webkit [161752] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Fix build for RenderEmbeddedObject::canHaveChildren()

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::canHaveChildren):

11:33 PM Changeset in webkit [161751] by andersca@apple.com
  • 19 edits in trunk/Source

Tweak ProgressTrackerClient functions
https://bugs.webkit.org/show_bug.cgi?id=126808

Reviewed by Sam Weinig.

Source/WebCore:

Rename the three progress state related member functions since it's up to the various
WebKit implementations to decide what to do - not everyone wants to post a notification.
Also add an originating progress frame parameter since WebKit2 doesn't report progress for
subframe navigation and we need to be able to keep track of that.

Finally, tweak ProgressTracker::completeProgress to get rid of an unnecessary hash lookup.

  • loader/EmptyClients.h:
  • loader/ProgressTracker.cpp:

(WebCore::ProgressItem::ProgressItem):
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::finalProgressComplete):
(WebCore::ProgressTracker::incrementProgress):
(WebCore::ProgressTracker::completeProgress):

  • loader/ProgressTrackerClient.h:

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:

(WebCore::FrameLoaderClientEfl::progressStarted):
(WebCore::FrameLoaderClientEfl::progressEstimateChanged):
(WebCore::FrameLoaderClientEfl::progressFinished):

  • WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:

(WebKit::FrameLoaderClient::progressStarted):
(WebKit::FrameLoaderClient::progressEstimateChanged):
(WebKit::FrameLoaderClient::progressFinished):

  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::progressStarted):
(WebFrameLoaderClient::progressEstimateChanged):
(WebFrameLoaderClient::progressFinished):

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::progressStarted):
(WebFrameLoaderClient::progressEstimateChanged):
(WebFrameLoaderClient::progressFinished):

  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::progressStarted):
(WebKit::WebFrameLoaderClient::progressEstimateChanged):
(WebKit::WebFrameLoaderClient::progressFinished):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
11:27 PM Changeset in webkit [161750] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Fix COMPILE_ASSERT by updating struct SameSizeAsStyleRareInheritedData

  • rendering/style/StyleRareInheritedData.cpp:
11:05 PM Changeset in webkit [161749] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Fix build of SubframeLoader.cpp

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::loadMediaPlayerProxyPlugin):
(WebCore::SubframeLoader::loadPlugin):

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
10:56 PM Changeset in webkit [161748] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix Mac after r161747. One part of that is iOS specific.

Unreviewed build fix.

  • bindings/js/GCController.cpp:

(WebCore::GCController::releaseExecutableMemory):

10:53 PM Changeset in webkit [161747] by Joseph Pecoraro
  • 3 edits in trunk/Source/WebCore

[iOS] Fix GCController::releaseExecutableMemory
https://bugs.webkit.org/show_bug.cgi?id=126805

Reviewed by Sam Weinig and Mark Lam.

VM::dynamicGlobalObject has since been replaced by VMEntryScope.
Update to check entryScope instead of the dynamicGlobalObject.
Also, make this non-iOS only.

  • bindings/js/GCController.h:
  • bindings/js/GCController.cpp:

(WebCore::GCController::releaseExecutableMemory):

10:41 PM Changeset in webkit [161746] by Joseph Pecoraro
  • 3 edits in trunk/Source/WebCore

Fix HTMLMediaElement.o for iOS. Unreviewed build fix.

There is now local variable mediaElement. Just call the
functions since they are methods on this class.

Fix RequireUserGestureToShowPlaybackTargetPickerRestriction typos.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

10:33 PM Changeset in webkit [161745] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Convert HandleMessage.h to use variadic templates
https://bugs.webkit.org/show_bug.cgi?id=126469

Reviewed by Anders Carlsson.

  • Platform/IPC/HandleMessage.h:

(IPC::callMemberFunctionImpl):
(IPC::callMemberFunction):
Replace massive copy and pasted code with variadic magic.

10:33 PM Changeset in webkit [161744] by andersca@apple.com
  • 27 edits
    1 add in trunk/Source

Move progress tracking functions from FrameLoaderClient to a new ProgressTrackerClient
https://bugs.webkit.org/show_bug.cgi?id=126801

Reviewed by Sam Weinig.

Source/WebCore:

  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/EmptyClients.cpp:

(WebCore::fillWithEmptyClients):

  • loader/EmptyClients.h:
  • loader/FrameLoaderClient.h:
  • loader/ProgressTracker.cpp:

(WebCore::ProgressTracker::ProgressTracker):
(WebCore::ProgressTracker::~ProgressTracker):
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::progressCompleted):
(WebCore::ProgressTracker::finalProgressComplete):
(WebCore::ProgressTracker::incrementProgress):

  • loader/ProgressTracker.h:
  • loader/ProgressTrackerClient.h: Added.

(WebCore::ProgressTrackerClient::~ProgressTrackerClient):
(WebCore::ProgressTrackerClient::progressTrackerDestroyed):
(WebCore::ProgressTrackerClient::willChangeEstimatedProgress):
(WebCore::ProgressTrackerClient::didChangeEstimatedProgress):

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::PageClients::PageClients):

  • page/Page.h:

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.h:
  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.h:
  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebView.cpp:

(WebView::initWithFrame):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):

10:18 PM Changeset in webkit [161743] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix RenderObject.o for iOS. Unreviewed build fix.

r156285 renamed firstChild() to firstChildSlow(), so update
occurances in IOS_TEXT_AUTOSIZING code. Also account for a
RenderObject::style reference / pointer change.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::traverseNext):
(WebCore::includeNonFixedHeight):

10:08 PM Changeset in webkit [161742] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix MediaPlayerPrivateMediaSourceAVFObjC.o for iOS. Unreviewed build fix.

Import CALayer, which Mac must have been getting some other way.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
10:02 PM Changeset in webkit [161741] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix TileGrid.o for iOS. Unreviewed build fix.

Explicitly use namespace std in std::pair.

  • platform/ios/TileGrid.mm:

(WebCore::isFartherAway):
(WebCore::TileGrid::dropDistantTiles):

9:59 PM Changeset in webkit [161740] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix RenderImage.o for iOS. Unreviewed build fix.

inlineBoxWrapper() returns an InlineElementBox type, which is an InlineBox but
without including InlineElementBox.h, iOS didn't know what an InlineElementBox was!

  • rendering/RenderImage.cpp:
9:53 PM Changeset in webkit [161739] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Fix macros in Scrollbar::supportsUpdateOnSecondaryThread()

Fixes the following build error:

WebCore/platform/Scrollbar.cpp:552:22: error: 'MAC_OS_X_VERSION_MIN_REQUIRED' is not defined, evaluates to 0 [-Werror,-Wundef]
#if PLATFORM(MAC) &&
MAC_OS_X_VERSION_MIN_REQUIRED >= 101000 && ENABLE(ASYNC_SCROLLING)


  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::supportsUpdateOnSecondaryThread):

9:50 PM Changeset in webkit [161738] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix RenderFileUploadControl.o for iOS. Unreviewed build fix.

WebCore::theme() returns a reference now, not a pointer.

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

9:48 PM Changeset in webkit [161737] by fpizlo@apple.com
  • 12 edits in branches/jsCStack

FTL should work with the bytecode profiler
https://bugs.webkit.org/show_bug.cgi?id=126804

Source/JavaScriptCore:

Reviewed by Sam Weinig.

Implement CountExecution in FTL and make the FTL report a compilation with some kind
of description to the database. This still leaves a lot to be desired; for example
the descriptions we report don't have disassembly. But, this small step already
allows for some basic profiling.

  • dfg/DFGPlan.cpp:

(JSC::DFG::profilerCompilationKindForMode):
(JSC::DFG::Plan::Plan):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeFunction):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCountExecution):

  • profiler/ProfilerCompilation.cpp:

(JSC::Profiler::Compilation::addDescription):

  • profiler/ProfilerCompilation.h:
  • profiler/ProfilerCompilationKind.cpp:

(WTF::printInternal):

  • profiler/ProfilerCompilationKind.h:

Tools:

Reviewed by Sam Weinig.

Teach this that there are more JITs.

  • Scripts/display-profiler-output:
9:45 PM Changeset in webkit [161736] by Joseph Pecoraro
  • 2 edits
    2 adds in trunk/Source/WebCore

Fix HTMLPlugInImageElement.o for iOS. Unreviewed build fix.

Forgot to upstream YouTubeEmbedShadowElement.*. Do so and
add the files to the Xcode project so they build.

  • WebCore.xcodeproj/project.pbxproj:
  • html/shadow/YouTubeEmbedShadowElement.cpp: Added.

(WebCore::YouTubeEmbedShadowElement::create):
(WebCore::YouTubeEmbedShadowElement::YouTubeEmbedShadowElement):
(WebCore::YouTubeEmbedShadowElement::pluginElement):
(WebCore::YouTubeEmbedShadowElement::shadowPseudoId):

  • html/shadow/YouTubeEmbedShadowElement.h: Added.
9:34 PM Changeset in webkit [161735] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Update EditorIOS.mm to switch from pointers to references

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):
(WebCore::Editor::insertParagraphSeparatorInQuotedContent):
(WebCore::styleForSelectionStart):
(WebCore::Editor::selectionInWebArchiveFormat):
(WebCore::Editor::writeImageToPasteboard):
(WebCore::Editor::WebContentReader::readWebArchive):
(WebCore::Editor::WebContentReader::readRTFD):
(WebCore::Editor::WebContentReader::readRTF):
(WebCore::uniqueURLWithRelativePart):
(WebCore::Editor::WebContentReader::readPlainText):
(WebCore::Editor::webContentFromPasteboard):
(WebCore::Editor::createFragmentAndAddResources):
(WebCore::Editor::createFragmentForImageResourceAndAddResource):

9:33 PM Changeset in webkit [161734] by fpizlo@apple.com
  • 3 edits in branches/jsCStack/Source/JavaScriptCore

Unreviewed, unbreak all tests by undoing some assertions junk in
http://trac.webkit.org/changeset/161732 and changing typo "node->function()"
which should have been "node->executable()".

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileCheckExecutable):

  • runtime/Options.cpp:

(JSC::recomputeDependentOptions):
(JSC::Options::initialize):

9:18 PM Changeset in webkit [161733] by Joseph Pecoraro
  • 27 edits
    2 moves
    5 adds in trunk/Source

Web Inspector: Push InspectorAgent down into JSC, give JSC an InspectorController
https://bugs.webkit.org/show_bug.cgi?id=126763

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Introduce JSGlobalObjectInspectorController. This is the InspectorController
for a JSContext. It is created by the JSGlobalObject Remote Inspector Debuggable
when a remote frontend connects, and is destroyed when the remote frontend
disconnects of the JSGlobalObject is destroyed.

  • inspector/JSGlobalObjectInspectorController.h: Added.
  • inspector/JSGlobalObjectInspectorController.cpp: Added.

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::~JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::connectFrontend):
(Inspector::JSGlobalObjectInspectorController::disconnectFrontend):
(Inspector::JSGlobalObjectInspectorController::dispatchMessageFromFrontend):
(Inspector::JSGlobalObjectInspectorController::functionCallHandler):
(Inspector::JSGlobalObjectInspectorController::evaluateHandler):
Create/destory agents, create/destroy dispatches, implement InspectorEnvironment.

  • runtime/JSGlobalObjectDebuggable.h:
  • runtime/JSGlobalObjectDebuggable.cpp:

(JSC::JSGlobalObjectDebuggable::~JSGlobalObjectDebuggable):
(JSC::JSGlobalObjectDebuggable::connect):
(JSC::JSGlobalObjectDebuggable::disconnect):
(JSC::JSGlobalObjectDebuggable::dispatchMessageFromRemoteFrontend):
Forward actions to the InspectorController object.

  • inspector/agents/InspectorAgent.h: Renamed from Source/WebCore/inspector/InspectorAgent.h.
  • inspector/agents/InspectorAgent.cpp: Renamed from Source/WebCore/inspector/InspectorAgent.cpp.

(Inspector::InspectorAgent::InspectorAgent):
(Inspector::InspectorAgent::~InspectorAgent):
(Inspector::InspectorAgent::didCreateFrontendAndBackend):
(Inspector::InspectorAgent::inspect):
(Inspector::InspectorAgent::evaluateForTestInFrontend):
Implement InspectorAgent in JavaScriptCore in namespace Inspector.

Add files and new inspector/agents subdirectory.

Source/WebCore:

No new tests, no observable change in functionality.

  • CMakeLists.txt:
  • ForwardingHeaders/inspector/InspectorAgent.h: Added.
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • inspector/InspectorAllInOne.cpp:

InspectorAgent moved to JavaScriptCore.

  • inspector/PageConsoleAgent.cpp:

(WebCore::PageConsoleAgent::PageConsoleAgent):
(WebCore::PageConsoleAgent::~PageConsoleAgent):

  • inspector/PageConsoleAgent.h:

(WebCore::PageConsoleAgent::create):

  • inspector/InspectorApplicationCacheAgent.cpp:
  • inspector/InspectorApplicationCacheAgent.h:

InspectorAgent was not used by these files, remove it.

  • inspector/CommandLineAPIHost.cpp:
  • inspector/CommandLineAPIHost.h:

(WebCore::CommandLineAPIHost::init):

  • inspector/InspectorInstrumentation.cpp:
  • inspector/InstrumentingAgents.h:

(WebCore::InstrumentingAgents::inspectorAgent):
(WebCore::InstrumentingAgents::setInspectorAgent):
Switch to Inspector::InspectorAgent where applicable.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):

  • inspector/InspectorController.h:

Manually add InspectorAgent to the InstrumentingAgents. It is one
of the agents that is always available in InstrumentingAgents.

9:06 PM Changeset in webkit [161732] by fpizlo@apple.com
  • 6 edits
    1 add in branches/jsCStack/Source/JavaScriptCore

FTL should enough things to compile inlined closure calls (like CheckExecutable and GetScope)
https://bugs.webkit.org/show_bug.cgi?id=126799

Reviewed by Oliver Hunt.

Added FTL support for CheckExecutable and GetScope because I wanted to compile
closure calls. But then I realized that closure call inlining was broken because
the baseline JIT would link the closure stubs to the slow path, thereby causing
the DFG's profiling to think that all closure calls are actually virtual calls.

Also fixed some hash() computing stuff to make debugging easier.

  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCheckExecutable):
(JSC::FTL::LowerDFGToLLVM::compileGetScope):

  • jit/Repatch.cpp:

(JSC::linkClosureCall):

  • runtime/Options.cpp:

(JSC::recomputeDependentOptions):
(JSC::Options::initialize):
(JSC::Options::setOption):

  • tests/stress/inline-closure-call.js: Added.

(bar):

9:02 PM Changeset in webkit [161731] by Simon Fraser
  • 3 edits
    2 adds in trunk/Source/WebCore

Add TextAutoSizing.* for iOS, and fix DeviceOrientationController creation.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::Document):

  • rendering/TextAutoSizing.cpp: Added.

(WebCore::cloneRenderStyleWithState):
(WebCore::TextAutoSizingKey::TextAutoSizingKey):
(WebCore::TextAutoSizingKey::~TextAutoSizingKey):
(WebCore::TextAutoSizingKey::operator=):
(WebCore::TextAutoSizingKey::ref):
(WebCore::TextAutoSizingKey::deref):
(WebCore::TextAutoSizingValue::numNodes):
(WebCore::TextAutoSizingValue::addNode):
(WebCore::TextAutoSizingValue::adjustNodeSizes):
(WebCore::TextAutoSizingValue::reset):

  • rendering/TextAutoSizing.h: Added.

(WebCore::TextAutoSizingKey::doc):
(WebCore::TextAutoSizingKey::style):
(WebCore::TextAutoSizingKey::isValidDoc):
(WebCore::TextAutoSizingKey::isValidStyle):
(WebCore::TextAutoSizingKey::deletedKeyDoc):
(WebCore::TextAutoSizingKey::deletedKeyStyle):
(WebCore::operator==):
(WebCore::TextAutoSizingHash::hash):
(WebCore::TextAutoSizingHash::equal):
(WebCore::TextAutoSizingValue::create):
(WebCore::TextAutoSizingValue::TextAutoSizingValue):

8:44 PM Changeset in webkit [161730] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix GraphicsLayerCA.o for iOS. Unreviewed build fix.

Use of systemMemoryLevel was missing include of SystemMemory.h.

  • platform/graphics/ca/GraphicsLayerCA.cpp:
8:41 PM Changeset in webkit [161729] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Fix iOS build.

  • bindings/objc/DOM.mm:

(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):

  • bindings/objc/DOMExtensions.h:
  • platform/DragImage.h:
8:41 PM Changeset in webkit [161728] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Fix iOS build.

Generated DOMTouch* and DOMGesture* files need to be in the project.
Exclude them on Mac via EXCLUDED_SOURCE_FILE_NAMES_macosx.

Use TARGET_OS_IPHONE instead of TARGET_OS_EMBEDDED in DOMPrivate.h

  • Configurations/WebCore.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/objc/DOMPrivate.h:
8:39 PM Changeset in webkit [161727] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix RenderThemeIOS.o for iOS. Unreviewed build fix.

Typo referring to generated name. Should be "iOS" not "IOS".

  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::mediaControlsScript):

8:31 PM Changeset in webkit [161726] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix WebAccessibilityObjectWrapperIOS.o for iOS. Unreviewed build fix.

The upstreamed WebAccessibilityObjectWrapperIOS.mm was out of date, e.g.
it was using GSFonts. Just upstream a newer version of the file. Also
explicitly namespace qualify std::pair.

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(AXAttributeStringSetStyle):

8:26 PM Changeset in webkit [161725] by jinwoo7.song@samsung.com
  • 3 edits in trunk/Source/WebCore

Remove willRespondToTouchEvents() which was used by chromium port
https://bugs.webkit.org/show_bug.cgi?id=126739

Reviewed by Alexey Proskuryakov.

willRespondToTouchEvents() was added to check if a node listens to touch events in r126945.
However, it is not used anywhere after chromium port is removed.

  • dom/Node.cpp:
  • dom/Node.h:
8:17 PM Changeset in webkit [161724] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix SystemVersionMac.o for iOS. Unreviewed build fix.

Add missing expected function. Maybe we can avoid including
this file entirely on iOS, there was already a FIXME.

  • platform/mac/SystemVersionMac.mm:

(WebCore::systemMarketingVersion):

8:13 PM Changeset in webkit [161723] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix JSDOMWindowBase.o for iOS. Unreviewed build fix.

Add missing iOS method declarations.

  • bindings/js/JSDOMWindowBase.h:
8:06 PM Changeset in webkit [161722] by commit-queue@webkit.org
  • 3 edits
    3 deletes in trunk

Unreviewed, rolling out r161702.
http://trac.webkit.org/changeset/161702
https://bugs.webkit.org/show_bug.cgi?id=126803

Broke multiple tests (Requested by ap on #webkit).

Source/JavaScriptCore:

  • runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):

LayoutTests:

  • js/script-tests/typedarray-constructors.js: Removed.
  • js/typedarray-constructors-expected.txt: Removed.
  • js/typedarray-constructors.html: Removed.
8:05 PM Changeset in webkit [161721] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix InputType.o for iOS. Unreviewed build fix.

The RuntimeEnabledFeatures function pointer type should have a
const qualifier, because the implementations are all const.

  • html/InputType.cpp:
7:58 PM Changeset in webkit [161720] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix MediaPlayerPrivateIOS.o for iOS. Unreviewed build fix.

Add missing MediaPlayerProxy Objective C methods and forward declarations.

  • platform/graphics/mac/MediaPlayerProxy.h:
7:49 PM Changeset in webkit [161719] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix FrameSelection.o for iOS. Unreviewed build fix.

r160966 renamed rendererIsEditable to hasEditableStyle.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::setSelectionFromNone):

7:46 PM Changeset in webkit [161718] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix DragData.o for iOS. Unreviewed build fix.

String m_pasteboardName is unused on iOS, so ifdef it out.

  • platform/DragData.h:
7:32 PM Changeset in webkit [161717] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix FrameIOS.o for iOS. Unreviewed build fix.

Remove stale include to file that no longer exists. It was not needed.

  • page/ios/FrameIOS.mm:
7:29 PM Changeset in webkit [161716] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix MonthInputType.o for iOS. Unreviewed build fix.

When ENABLE_INPUT_MULTIPLE_FIELDS_UI was removed in r150876,
the wrong class name lingered. Fix it to be the base class.

  • html/TimeInputType.cpp:

(WebCore::TimeInputType::TimeInputType):

6:26 PM Changeset in webkit [161715] by aestes@apple.com
  • 3 edits in trunk/Source/WebCore

[iOS] Build fix: make sure WTF_PLATFORM_IOS is defined when preprocessing

  • DerivedSources.make:
  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

6:25 PM Changeset in webkit [161714] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Use TARGET_OS_IPHONE in this API file, and #if TARGET_OS_MAC
for a non-iOS function.

  • bindings/objc/DOMExtensions.h:
6:19 PM Changeset in webkit [161713] by ddkilzer@apple.com
  • 12 edits in trunk/Source

Clean up architectures in xcconfig files
<http://webkit.org/b/126794>

Reviewed by Andy Estes.

Source/JavaScriptCore:

  • Configurations/Base.xcconfig:
  • Configurations/JavaScriptCore.xcconfig: Remove armv6, ppc.
  • Configurations/ToolExecutable.xcconfig: Sort.
  • Add new arch.

Source/WebCore:

  • Configurations/Base.xcconfig:
  • Configurations/WebCore.xcconfig: Remove armv6.
  • DerivedSources.make: Remove armv6, armv7f. Sort.
  • Add new arch.

Source/WebKit/mac:

  • Configurations/WebKit.xcconfig: Remove armv6, armv7f, ppc.
  • Add new arch.

Source/WTF:

  • Configurations/Base.xcconfig:
  • Add new arch.
6:16 PM Changeset in webkit [161712] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Fix iOS build

  • Configurations/WebCore.xcconfig:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyLineHeightForIOSTextAutosizing::applyValue):

5:59 PM Changeset in webkit [161711] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Fix iOS build.

  • html/DateTimeLocalInputType.h:

(WebCore::DateTimeLocalInputType::DateTimeLocalInputType):

  • loader/ios/DiskImageCacheIOS.h:
5:59 PM Changeset in webkit [161710] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

iOS build fix: add StyleRareInheritedData::compositionFillColor

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:
5:50 PM Changeset in webkit [161709] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix MonthInputType.o for iOS. Unreviewed build fix.

Incorrect base class name. Must have been typo'd when upstreaming.

  • html/MonthInputType.h:

(WebCore::MonthInputType::MonthInputType):

5:33 PM Changeset in webkit [161708] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix RenderButton.o for iOS. Unreviewed build fix.

Missing prototype in header for override of the layout method.

  • rendering/RenderButton.h:
5:29 PM Changeset in webkit [161707] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

A couple of iOS build fixes.

  • accessibility/ios/AXObjectCacheIOS.mm:

(WebCore::AXObjectCache::handleFocusedUIElementChanged):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):

5:29 PM Changeset in webkit [161706] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix iOS build.

  • loader/ResourceLoader.h:
5:29 PM Changeset in webkit [161705] by fpizlo@apple.com
  • 8 edits in branches/jsCStack/Source/JavaScriptCore

It should be easier to diagnose FTL performance issues due to register preservation thunks
https://bugs.webkit.org/show_bug.cgi?id=126798

Not yet reviewed.

You can now use --verboseFTLToJSThunk=true --verboseFTLFailure=true to figure out
which code blocks are rejected by the FTL and yet get called from functions that
were FTL compiled. Any such rejections in major benchmarks should be fixed.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::verboseCapabilities):
(JSC::FTL::canCompile):

  • jit/RegisterPreservationWrapperGenerator.cpp:

(JSC::generateRegisterPreservationWrapper):

  • runtime/Executable.cpp:

(JSC::ExecutableBase::dump):

  • runtime/Executable.h:
  • runtime/Options.cpp:

(JSC::Options::initialize):

  • runtime/Options.h:
5:26 PM Changeset in webkit [161704] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Fix PlatformScreenIOS.mm for iOS. Unreviewed build fix.

PlatformScreen.h removed screenVerticalDPI and screenHorizontalDPI in r132419,
so remove the stale implementations on iOS. Also, add a notImplemented version
of screenColorProfile, which matches Mac and is unused in WebCore for this port.

  • platform/ios/PlatformScreenIOS.mm:

(WebCore::screenColorProfile):

5:19 PM Changeset in webkit [161703] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

CTTE FrameTree
https://bugs.webkit.org/show_bug.cgi?id=126795

Reviewed by Tim Horton.

  • page/Frame.cpp:

(WebCore::Frame::Frame):

  • page/FrameTree.cpp:

(WebCore::FrameTree::transferChild):
(WebCore::FrameTree::appendChild):
(WebCore::FrameTree::actuallyAppendChild):
(WebCore::FrameTree::uniqueChildName):
(WebCore::FrameTree::scopedChild):
(WebCore::FrameTree::scopedChildCount):
(WebCore::FrameTree::child):
(WebCore::FrameTree::find):
(WebCore::FrameTree::isDescendantOf):
(WebCore::FrameTree::traverseNext):
(WebCore::FrameTree::traverseNextWithWrap):
(WebCore::FrameTree::traversePreviousWithWrap):
(WebCore::FrameTree::deepLastChild):
(WebCore::FrameTree::top):

  • page/FrameTree.h:

(WebCore::FrameTree::FrameTree):

5:09 PM Changeset in webkit [161702] by dino@apple.com
  • 3 edits
    3 adds in trunk

[JSC] Revise typed array implementations to match ECMAScript and WebGL Specification
https://bugs.webkit.org/show_bug.cgi?id=126754

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

The ECMAScript specification forbids calling the typed array
constructors without using "new". Change the call data to return
none so we throw and exception in these cases.

  • runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::getCallData):

LayoutTests:

New test which checks that we throw an exception when calling
any of the typed array constructors without using "new".

  • js/script-tests/typedarray-constructors.js: Added.
  • js/typedarray-constructors-expected.txt: Added.
  • js/typedarray-constructors.html: Added.
5:05 PM Changeset in webkit [161701] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix iOS build.

  • platform/graphics/ImageSource.h:

(WebCore::ImageSource::acceleratedImageDecodingEnabled):
(WebCore::ImageSource::setAcceleratedImageDecodingEnabled):

4:55 PM Changeset in webkit [161700] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebCore

Unreviewed EFL build fix after r161678.

static_cast a size_t to unsigned long for %lu format string.

  • page/Console.cpp:

(WebCore::internalAddMessage):

4:53 PM Changeset in webkit [161699] by benjamin@webkit.org
  • 38 edits in trunk

Remove the BlackBerry port from trunk
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-10
Reviewed by Anders Carlsson.

.:

  • CMakeLists.txt:
  • Source/cmake/OptionsCommon.cmake:

Source/JavaScriptCore:

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::cacheFlush):

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::replaceWithJump):
(JSC::ARMv7Assembler::maxJumpReplacementSize):
(JSC::ARMv7Assembler::cacheFlush):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::revertJumpReplacementToBranchPtrWithPatch):

  • heap/MachineStackMarker.cpp:

(JSC::getPlatformThreadRegisters):
(JSC::otherThreadStackPointer):
(JSC::freePlatformThreadRegisters):

  • jit/ExecutableAllocator.h:

Source/WebCore:

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::readPixels):

  • platform/graphics/ImageBuffer.cpp:
  • platform/graphics/ImageBufferData.h:
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.h:
  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/NativeImagePtr.h:
  • platform/graphics/OpenGLESShims.h:
  • platform/graphics/Path.cpp:

(WebCore::Path::addPathForRoundedRect):

  • platform/graphics/Path.h:
  • platform/graphics/PlatformLayer.h:
  • platform/graphics/filters/CustomFilterValidatedProgram.cpp:
  • platform/graphics/filters/CustomFilterValidatedProgram.h:
  • platform/graphics/filters/FilterOperation.h:
  • platform/graphics/gpu/DrawingBuffer.cpp:
  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
  • platform/graphics/opengl/Extensions3DOpenGLES.cpp:

(WebCore::Extensions3DOpenGLES::getGraphicsResetStatusARB):

  • platform/graphics/opengl/Extensions3DOpenGLES.h:
  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):
(WebCore::GraphicsContext3D::prepareTexture):
(WebCore::GraphicsContext3D::bindFramebuffer):
(WebCore::GraphicsContext3D::compileShader):
(WebCore::GraphicsContext3D::copyTexImage2D):
(WebCore::GraphicsContext3D::copyTexSubImage2D):

  • platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:

(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):
(WebCore::GraphicsContext3D::reshapeFBOs):

  • platform/network/NetworkStateNotifier.h:
  • platform/network/ResourceHandle.h:
  • platform/network/ResourceHandleInternal.h:
  • platform/network/ResourceRequestBase.cpp:

Tools:

  • DumpRenderTree/DumpRenderTree.h:
  • DumpRenderTree/PixelDumpSupport.cpp:
4:44 PM Changeset in webkit [161698] by Simon Fraser
  • 3 edits
    1 add in trunk/Source/WebCore

Fix CharsetData.cpp build for iOS
https://bugs.webkit.org/show_bug.cgi?id=126792

Reviewed by Mark Rowe.

CharsetData.cpp should have an empty CharsetTable list for iOS.
Achieve this with an iOS-specific encodings.txt file.

  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/text/mac/ios-encodings.txt: Added.
4:38 PM Changeset in webkit [161697] by andersca@apple.com
  • 8 edits in trunk/Source/WebCore

CTTE in NavigationScheduler
https://bugs.webkit.org/show_bug.cgi?id=126788

Reviewed by Tim Horton.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::frameScheduledNavigationImpl):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigationImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::frameScheduledNavigation):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigation):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::frameScheduledNavigation):
(WebCore::InspectorPageAgent::frameClearedScheduledNavigation):

  • inspector/InspectorPageAgent.h:
  • loader/NavigationScheduler.cpp:

(WebCore::ScheduledNavigation::shouldStartTimer):
(WebCore::ScheduledNavigation::didStartTimer):
(WebCore::ScheduledNavigation::didStopTimer):
(WebCore::NavigationScheduler::NavigationScheduler):
(WebCore::NavigationScheduler::clear):
(WebCore::NavigationScheduler::shouldScheduleNavigation):
(WebCore::NavigationScheduler::scheduleRedirect):
(WebCore::NavigationScheduler::mustLockBackForwardList):
(WebCore::NavigationScheduler::scheduleLocationChange):
(WebCore::NavigationScheduler::scheduleFormSubmission):
(WebCore::NavigationScheduler::scheduleRefresh):
(WebCore::NavigationScheduler::scheduleHistoryNavigation):
(WebCore::NavigationScheduler::timerFired):
(WebCore::NavigationScheduler::schedule):
(WebCore::NavigationScheduler::startTimer):
(WebCore::NavigationScheduler::cancel):

  • loader/NavigationScheduler.h:
  • page/Frame.cpp:

(WebCore::Frame::Frame):

4:31 PM Changeset in webkit [161696] by mmaxfield@apple.com
  • 19 edits
    7 adds in trunk

CSS word-spacing property does not obey percentages
https://bugs.webkit.org/show_bug.cgi?id=126674

Reviewed by Simon Fraser.

Source/WebCore:

One change between CSS2.1 and CSS3 is that the word-spacing CSS property can
take percentages (of the width of the space character) in CSS3. In order to
implement this, the datatype must be changed from a float to a Length, which
can hold percentage values. Then, during layout, we can query the width of
the space character and update the Font's word-spacing value appropriately.
However, the RenderStyle still holds on to the Length (as a rare inherited
value).

Tests: fast/css3-text/css3-word-spacing-percentage/word-spacing-change-font.html

fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage-parse.html
fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue): Use Font's computed value instead
of style's Length value.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue): word-spacing and letter-spacing no longer are
parsed the same way.

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyWordSpacing::applyValue): Construct a length from a given
CSSValue and set the style's word spacing with it.
(WebCore::ApplyPropertyWordSpacing::createHandler):
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): Use ApplyPropertyWordSpacing.

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimationWrapperMap::CSSPropertyAnimationWrapperMap):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun): Use Font's computed value instead
of style's Length value.

  • rendering/RenderText.cpp:

(WebCore::RenderText::computePreferredLogicalWidths): Ditto.

  • rendering/SimpleLineLayout.cpp:

(WebCore::SimpleLineLayout::canUseFor): Opt-out of the SimpleLineLayout
if either the percentage or the length is nonzero.

  • rendering/line/BreakingContextInlineHeaders.h:

(WebCore::BreakingContext::handleText): Use Font's computed value instead
of style's Length value.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::wordSpacing):
(WebCore::RenderStyle::setWordSpacing): Consult the Font's space with to compute
percentage values, but hold on to the original Length.

  • rendering/style/RenderStyle.h:
  • rendering/style/StyleRareInheritedData.cpp:
  • rendering/style/StyleRareInheritedData.h: Hold on to the specified Length

LayoutTests:

See per-file description

  • fast/css3-text/css3-word-spacing-percentage/word-spacing-change-font-expected.html: Added.
  • fast/css3-text/css3-word-spacing-percentage/word-spacing-change-font.html: Added.

Make sure that if Javascript changes the font after initial layout, that the word-spacing
value gets appropriately updated.

  • fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage-expected.html: Added.
  • fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage-parse-expected.txt: Added.
  • fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage-parse.html: Added.

Make sure that the CSSOM yields the correct percentage values when queried.

  • fast/css3-text/css3-word-spacing-percentage/word-spacing-percentage.html: Added.

Try some specific values of percentages (-100%, 0%, and 100%).

  • css1/text_properties/word_spacing.html: Updated to not disregard percentages
  • css2.1/20110323/c541-word-sp-001-expected.html:
  • css2.1/20110323/c541-word-sp-001.htm: Ditto
  • platform/mac/css1/text_properties/word_spacing-expected.png:
  • platform/mac/css1/text_properties/word_spacing-expected.txt: Ditto
4:29 PM Changeset in webkit [161695] by fpizlo@apple.com
  • 1 edit
    1 add in branches/jsCStack/Source/JavaScriptCore

Unreviewed, add a test for the case where LLVM finds a constant folding
opportunity that the DFG missed, and it involves a large constant, and then we
exit with the large constant folded into a stackmap for an OSR exit.

We fixed this incidentally as part of http://trac.webkit.org/changeset/161543, but
it only showed up as part of new tests specific to add/sub recovery and as a
Octane/gbemu *slow-down* because gbemu had such a constant. It seems like we
should have an explicit test for this since it's a really gross bug to have in a
rather critical code path.

  • tests/stress/exit-after-llvm-folds-large-int-constant.js: Added.

(foo):

4:19 PM Changeset in webkit [161694] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix the iOS build.

  • platform/audio/mac/MediaSessionManagerMac.cpp:
4:17 PM Changeset in webkit [161693] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

iOS doesn't have <OpenGL/gl.h>; fix iOS build.

  • platform/graphics/opengl/TemporaryOpenGLSetting.cpp:
4:16 PM Changeset in webkit [161692] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Build Fix: Properly add $SDKROOT/usr/local/include/ to the search path when building PublicDOMInterfaces.h

  • bindings/scripts/CodeGeneratorObjC.pm:

(ReadPublicInterfaces):

3:55 PM Changeset in webkit [161691] by commit-queue@webkit.org
  • 22 edits in trunk/Source

Web Inspector: Remove unimplemented or static ScriptDebugServer features
https://bugs.webkit.org/show_bug.cgi?id=126784

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-10
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • inspector/protocol/Debugger.json:

Source/WebCore:

These features are unimplemented in the backend, and unused by the
current frontend. Most deal with features that were supported by v8
and are as yet unimplemented by JSC. If we decide to add such features
we can reimplement without conforming to an old implementation.

  • bindings/js/ScriptDebugServer.cpp:
  • bindings/js/ScriptDebugServer.h:
  • bindings/js/ScriptProfiler.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::InspectorDebuggerAgent::disable):

  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::reload):
(WebCore::InspectorPageAgent::frameNavigated):

  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.cpp:
  • inspector/InspectorProfilerAgent.h:
  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::didClearMainFrameWindowObject):

  • inspector/protocol/Page.json:
  • inspector/protocol/Profiler.json:

Source/WebInspectorUI:

  • UserInterface/InspectorJSBackendCommands.js:
  • UserInterface/InspectorWebBackendCommands.js:
  • UserInterface/Legacy/6.0/InspectorWebBackendCommands.js:
  • UserInterface/Legacy/7.0/InspectorWebBackendCommands.js:
  • Versions/Inspector-iOS-6.0.json:
  • Versions/Inspector-iOS-7.0.json:
3:54 PM Changeset in webkit [161690] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Remove unused variable from TileGrid::dropTilesBetweenRects()

Fixes the following build error:

WebCore/platform/ios/TileGrid.mm:88:23: error: unused variable 'end' [-Werror,-Wunused-variable]

TileMap::iterator end = m_tiles.end();


  • platform/ios/TileGrid.mm:

(WebCore::TileGrid::dropTilesBetweenRects): Remove unused
variable now that the for loop uses an auto iterator.

3:54 PM Changeset in webkit [161689] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: support negative numbers in secondsToString and bytesToString.

https://bugs.webkit.org/show_bug.cgi?id=125708

Reviewed by Joseph Pecoraro.

  • UserInterface/Utilities.js:

(Number.secondsToString): Use Math.abs in the size checks.
(Number.bytesToString): Ditto.

3:53 PM Changeset in webkit [161688] by dino@apple.com
  • 18 edits
    5 adds in trunk

Implement OES texture half float linear
https://bugs.webkit.org/show_bug.cgi?id=125060

Reviewed by Brent Fulgham.

Source/WebCore:

Test: fast/canvas/webgl/oes-texture-half-float-linear.html

  • CMakeLists.txt: Add new files.
  • DerivedSources.cpp: Ditto.
  • DerivedSources.make: Generate new file from IDL.
  • GNUmakefile.list.am: Add new files.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: New files for OESTextureHalfFloatLinear.
  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::toJS): Map from extension name to native object.

  • html/canvas/OESTextureHalfFloatLinear.cpp: Added. New files. These are boiler-plate.
  • html/canvas/OESTextureHalfFloatLinear.h: Added.
  • html/canvas/OESTextureHalfFloatLinear.idl: Added.
  • html/canvas/WebGLExtension.h: Add new enum for the new extension.
  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension): Create the extension object if the
context is asked for one.
(WebCore::WebGLRenderingContext::getSupportedExtensions): Add the new extension to the
list of supported extensions. Actually remember to do it this time :)
(WebCore::WebGLRenderingContext::checkTextureCompleteness): Need to check for the half-float
extension as well, and update the log message.

  • html/canvas/WebGLRenderingContext.h: New extension object.
  • html/canvas/WebGLTexture.cpp:

(WebCore::WebGLTexture::WebGLTexture):
(WebCore::WebGLTexture::needToUseBlackTexture): Check for half-float type.
(WebCore::WebGLTexture::update): Mark a texture as half-float if necessary.

  • html/canvas/WebGLTexture.h:
  • platform/graphics/Extensions3D.h: Add a comment about the new extension.
  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::supportsExtension): This extension is available
when GL_ARB_texture_float is supported, so add the name to the translation.

LayoutTests:

Exercise the OES_texture_half_float_linear extension. The new test
is copied from the official Khronos WebGL repository.

  • fast/canvas/webgl/oes-texture-float-linear-expected.txt: Change the console log

messages, which now also mention half float linear.

  • fast/canvas/webgl/oes-texture-half-float-linear-expected.txt: Added.
  • fast/canvas/webgl/oes-texture-half-float-linear.html: Added.
3:48 PM Changeset in webkit [161687] by BJ Burg
  • 7 edits in trunk/Source/WebInspectorUI

Web Inspector: cycle clicked breakpoints between enabled, auto-continue, and disabled
https://bugs.webkit.org/show_bug.cgi?id=126669

Reviewed by Joseph Pecoraro.

It's time-consuming to change a breakpoint's auto-continue setting through the
breakpoint editor popup. This patch enables the user to toggle between enabled,
auto-continue, and disabled by clicking on the breakpoint wedge in the sidebar
tree and in the source text editor gutter. The auto-continue option is only
cycled when the breakpoint has associated actions.

Clean up the breakpoint editor dialog so it hides irrelevant options when
no breakpoint actions have been added.

Automatically unset auto-continue when the last breakpoint action is removed.

Rename the delegate textEditorBreakpointToggled to textEditorBreakpointClicked, since
the behavior of the click depends on breakpoint state not available in the text editor.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Breakpoint.js:

(WebInspector.Breakpoint.prototype.cycleToNextMode): Added.
(WebInspector.Breakpoint.prototype.toggleAutoContinue): Added.
(WebInspector.Breakpoint.prototype.appendContextMenuItems): Add auto-continue options.
(WebInspector.Breakpoint.prototype.removeAction):

(WebInspector.Breakpoint.prototype._editBreakpointPopoverContentElement):
(WebInspector.Breakpoint.prototype._popoverActionsAddActionButtonClicked):
(WebInspector.Breakpoint.prototype.breakpointActionViewAppendActionView):
(WebInspector.Breakpoint.prototype.breakpointActionViewRemoveActionView):
(WebInspector.Breakpoint.prototype.willDismissPopover):

  • UserInterface/BreakpointTreeElement.css:

(.item.breakpoint .status > .status-image.auto-continue):
(.item.breakpoint .status > .status-image.disabled):

  • UserInterface/BreakpointTreeElement.js:

(WebInspector.BreakpointTreeElement):
(WebInspector.BreakpointTreeElement.prototype.onenter):
(WebInspector.BreakpointTreeElement.prototype.onspace):
(WebInspector.BreakpointTreeElement.prototype._updateStatus):
(WebInspector.BreakpointTreeElement.prototype._breakpointLocationDidChange):
(WebInspector.BreakpointTreeElement.prototype._statusImageElementClicked):

  • UserInterface/SourceCodeTextEditor.js:

(WebInspector.SourceCodeTextEditor):
(WebInspector.SourceCodeTextEditor.prototype.close):
(WebInspector.SourceCodeTextEditor.prototype._breakpointInfoForBreakpoint):
(WebInspector.SourceCodeTextEditor.prototype.textEditorBreakpointClicked):

  • UserInterface/TextEditor.css:

(.text-editor > .CodeMirror .breakpoint-auto-continue:not(.breakpoint-disabled) .CodeMirror-linenumber::before):

  • UserInterface/TextEditor.js:

(WebInspector.TextEditor.prototype._setBreakpointStylesOnLine.updateStyles):
(WebInspector.TextEditor.prototype._setBreakpointStylesOnLine):
(WebInspector.TextEditor.prototype.updateStyles):
(WebInspector.TextEditor.prototype._removeBreakpointFromLineAndColumn):
(WebInspector.TextEditor.prototype._documentMouseUp):

3:47 PM Changeset in webkit [161686] by msaboff@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

REGRESSION(C stack work): stack traces no longer work in CrashTracer, lldb, and other tools
https://bugs.webkit.org/show_bug.cgi?id=126764

Reviewed by Geoffrey Garen.

Updated callToJavaScript and cllToNativeFunction to properly replicate the caller's
return PC and frame pointer in the sentinel frame. For X86-64, added .cfi_
directives to create eh_frame info for all LLInt symbols so that the various
unwinding code understands that we are using a separate JS stack referenced
by BP and at what offsets in that frame the prior PC (register 16) and prior
BP (register 6) can be found. These two changes are sufficient for stack tracing
to work for Mac OSX.

  • llint/LowLevelInterpreter.cpp:
  • llint/LowLevelInterpreter64.asm:
3:36 PM Changeset in webkit [161685] by dbates@webkit.org
  • 2 edits in trunk/Tools

[iOS] Fix project build order

Ensure we build WebKitAdditions before WebCore (if applicable). Also, we don't
build WebInspectorUI, Tools/MiniBrowser, or Tools/WebKitTestRunner on iOS at the
time of writing.

  • Scripts/build-webkit:
3:28 PM Changeset in webkit [161684] by Brent Fulgham
  • 3 edits
    1 copy in trunk

Source/WebCore: [WebGL] Correct uniform input validation for texture sampler uniform
https://bugs.webkit.org/show_bug.cgi?id=126775

Reviewed by Dean Jackson.

Added fast/canvas/webgl/uniform-samplers-test.html

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::uniform1iv): Access Int32Array data properly.

LayoutTests: [WebGL] Correct uniform input validation for texture sampler uniforms.
https://bugs.webkit.org/show_bug.cgi?id=126775

Reviewed by Dean Jackson.

  • fast/canvas/webgl/uniform-samplers-test.html: Add a test that

shows that we can set sampler uniforms using Int32Array types.

3:17 PM Changeset in webkit [161683] by fpizlo@apple.com
  • 5 edits
    3 adds in branches/jsCStack/Source/JavaScriptCore

DFG should insert Phantoms when it uses conversion nodes
https://bugs.webkit.org/show_bug.cgi?id=126777

Reviewed by Oliver Hunt.

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupSetLocalsInBlock):
(JSC::DFG::FixupPhase::fixupUntypedSetLocalsInBlock):
(JSC::DFG::FixupPhase::fixEdge):
(JSC::DFG::FixupPhase::fixIntEdge):
(JSC::DFG::FixupPhase::injectInt32ToDoubleNode):
(JSC::DFG::FixupPhase::addPhantomsIfNecessary):

  • dfg/DFGNodeFlags.cpp:

(JSC::DFG::dumpNodeFlags):

  • dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validate):

  • tests/stress/exit-after-int32-to-double.js: Added.

(foo):

  • tests/stress/exit-after-int52-to-double.js: Added.

(foo):

  • tests/stress/exit-after-int52-to-value.js: Added.

(foo):
(makeWeirdObject):

2:54 PM Changeset in webkit [161682] by Manuel Rego Casasnovas
  • 2 edits in trunk/Source/WebCore

[GTK] Unreviewed build fix after r161644.

  • Modules/webaudio/MediaStreamAudioSourceNode.cpp:

(WebCore::MediaStreamAudioSourceNode::setFormat):

2:52 PM Changeset in webkit [161681] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Remove an unused FrameLoader function
https://bugs.webkit.org/show_bug.cgi?id=126785

Reviewed by Beth Dakin.

  • WebCore.exp.in:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::setState):

  • loader/FrameLoader.h:
2:48 PM Changeset in webkit [161680] by benjamin@webkit.org
  • 22 edits in trunk/Source/WebCore

Remove the BlackBerry port from trunk
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-10
Reviewed by Anders Carlsson.

  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypesForEncoding):

  • platform/PlatformKeyboardEvent.h:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

  • platform/PlatformMouseEvent.h:
  • platform/PlatformTouchEvent.h:

(WebCore::PlatformTouchEvent::PlatformTouchEvent):

  • platform/PlatformTouchPoint.h:
  • platform/ScrollAnimatorNone.cpp:

(WebCore::ScrollAnimator::create):

  • platform/URL.cpp:

(WebCore::URL::parse):
(WebCore::portAllowed):

  • platform/Widget.h:
  • platform/graphics/ANGLEWebKitBridge.h:
  • platform/graphics/DisplayRefreshMonitor.cpp:

(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):

  • platform/graphics/DisplayRefreshMonitor.h:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.h:
  • platform/graphics/FontCache.h:
  • platform/graphics/FontPlatformData.h:
  • platform/graphics/GlyphBuffer.h:
  • platform/graphics/Gradient.cpp:
  • platform/graphics/Gradient.h:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsContext3D.h:
2:24 PM Changeset in webkit [161679] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Remove dead code
https://bugs.webkit.org/show_bug.cgi?id=126782

Reviewed by Tim Horton.

  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
2:16 PM Changeset in webkit [161678] by timothy@apple.com
  • 4 edits in trunk/Source/WebCore

Clean up and fix some issues with stdout formatting of console messages.

  • Fix URLs not printing line numbers unless column number is > 0.
  • Change "CONSOLEAPI" to "CONSOLE" for the source.
  • Clean up how console.trace outputs and print URL, line and column for each frame.
  • Print "(unknown)" for anonymous and native code call frames.

https://bugs.webkit.org/show_bug.cgi?id=126767

Reviewed by Joseph Pecoraro.

  • page/Console.cpp:

(WebCore::internalAddMessage):

  • page/PageConsole.cpp:

(WebCore::PageConsole::printSourceURLAndPosition):
(WebCore::PageConsole::printMessageSourceAndLevelPrefix):

  • page/PageConsole.h:
2:13 PM Changeset in webkit [161677] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Clean up some areas of TreeOutline.

https://bugs.webkit.org/show_bug.cgi?id=123924

Reviewed by Joseph Pecoraro.

  • UserInterface/TreeOutline.js:

(TreeOutline.prototype.appendChild): Don't force create _childrenListNode, it will be created
when the tree element is expanded. Only attach if _childrenListNode already exists.
(TreeOutline.prototype.insertChild): Ditto.
(TreeOutline.prototype.getCachedTreeElement): Check the value of treeElementIdentifier
not just the existence of the property. It should never be null/undefined/0, but be safe.
(TreeOutline.prototype.findTreeElement): Null check isAncestor, it isn't required.

2:11 PM Changeset in webkit [161676] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[iOS] Fill in missing WebCoreThread function pointers
https://bugs.webkit.org/show_bug.cgi?id=126776

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-10
Reviewed by Timothy Hatcher.

  • platform/ios/wak/WebCoreThreadSystemInterface.cpp:

(InitWebCoreThreadSystemInterface):

2:10 PM Changeset in webkit [161675] by commit-queue@webkit.org
  • 8 edits
    2 adds in trunk/Source

Clear unparented tiled layers on memory pressure.
https://bugs.webkit.org/show_bug.cgi?id=126737

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2014-01-10
Reviewed by Simon Fraser.

Source/WebCore:

TileController hold unparented tiles for a short period of time (1 -3 sec); we should clear these unparented
tiles immediately if we are under memory pressure.

The patch does 3 things to improve the behavior:
1) When the system free memory is low (<35%), reduce the tiling threshold. This could reduce
the peak memory usage when system is under low memory since we will convert more web layers into
tiled backing.
2) Under memory pressure, immediately clear all unparented tiles.
3) Add a cap (16 tiles) to limit the total number of unparented tiles in TileController's.

  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj: Add a new class TileControllerMemoryHandler.
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::requiresTiledLayer): Use a smaller tiling threshold if the system free memory is low.

  • platform/graphics/ca/mac/TileController.h:

(WebCore::TileController::numberOfUnparentedTiles):

  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::startedNewCohort):
(WebCore::TileController::removeUnparentedTilesNow): Remove all unparentd tiles.

  • platform/ios/MemoryPressureHandlerIOS.mm:
  • platform/ios/TileControllerMemoryHandlerIOS.cpp: Added.

(WebCore::TileControllerMemoryHandler::removeTileController):
(WebCore::TileControllerMemoryHandler::totalUnparentedTiledLayers):
(WebCore::TileControllerMemoryHandler::tileControllerGainUnparentedTiles):
(WebCore::TileControllerMemoryHandler::trimUnparentedTilesToTarget): Trims the number of unparented tiles until

it reaches the target.

(WebCore::tileControllerMemoryHandler):

  • platform/ios/TileControllerMemoryHandlerIOS.h: Added.

(WebCore::TileControllerMemoryHandler::TileControllerMemoryHandler):

Source/WebKit/mac:

  • WebView/WebView.mm:

(+[WebView _handleMemoryWarning]): Clear all unparented tiles when under memory pressure.

2:06 PM Changeset in webkit [161674] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Fix an exception in WebInspector.Color.

https://bugs.webkit.org/show_bug.cgi?id=126765

Reviewed by Joseph Pecoraro.

  • UserInterface/Color.js:

(WebInspector.Color.fromString): Check hasOwnPrperty before using the nickname color array.
(WebInspector.Color.prototype._toNicknameString): Ditto.

1:42 PM Changeset in webkit [161673] by commit-queue@webkit.org
  • 6 edits in trunk/Source

[CSS Blending] Log blending as a layer creation reason in the WI
https://bugs.webkit.org/show_bug.cgi?id=126159

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-10
Reviewed by Timothy Hatcher.

Source/WebCore:

  • inspector/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):

  • inspector/protocol/LayerTree.json:

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/LayerTreeSidebarPanel.js:

(WebInspector.LayerTreeSidebarPanel.prototype._populateListOfCompositingReasons):

1:37 PM Changeset in webkit [161672] by commit-queue@webkit.org
  • 10 edits in trunk

[EFL][JSC] Enable udis86 disassembler on efl.
https://bugs.webkit.org/show_bug.cgi?id=125502

Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2014-01-10
Reviewed by Michael Saboff.

Enable udis86 disassembler on efl and fix build warnings.

.:

  • Source/cmake/OptionsEfl.cmake: Enable udis86 disassembler.

Source/JavaScriptCore:

  • CMakeLists.txt: Add udis86 disassembler source files.
  • disassembler/udis86/udis86_decode.c:

(decode_modrm_rm):

Build warning fixes.

  • disassembler/udis86/udis86_syn-att.c:

(gen_operand):

Build warning fixes.

  • disassembler/udis86/udis86_syn-intel.c:

(gen_operand):

Build warning fixes.

  • disassembler/udis86/udis86_types.h: Correct FMT64 for uint64_t.

Source/WTF:

  • wtf/Platform.h: Enable udis86 disassembler on EFL.
1:37 PM Changeset in webkit [161671] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Fix some iOS build errors during bindings generation.

  • bindings/objc/PublicDOMInterfaces.h: Included

WebKitAdditions/PublicDOMInterfacesIOS.h and change
-[DOMRGBColor color] to return a CGColorRef on iOS.

1:31 PM Changeset in webkit [161670] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

Prevent some resources from showing up in Web Inspector as years in duration.

No WebKit port passed a monotonic time to InspectorInstrumentation::didFinishLoading -- except Chromium.

https://bugs.webkit.org/show_bug.cgi?id=126760

Reviewed by Joseph Pecoraro.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didFinishLoadingImpl):
Revert part of r102961 to use finishTime as-is and not expect a monotonic time.

1:29 PM Changeset in webkit [161669] by krit@webkit.org
  • 4 edits
    16 adds in trunk

Make clipping path from basic-shapes relative to <box> value
https://bugs.webkit.org/show_bug.cgi?id=126206

Reviewed by Simon Fraser.

Source/WebCore:

Tests: css3/masking/clip-path-circle-border-box.html

css3/masking/clip-path-circle-bounding-box.html
css3/masking/clip-path-circle-content-box.html
css3/masking/clip-path-circle-margin-box.html
css3/masking/clip-path-circle-padding-box.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::setupClipPath): Add switch to differ between boxes

and use different reference boxes to size the clipping path.

LayoutTests:

Add new tests to check that different reference boxes are chosen for sizing and
positioning the clipping path.

  • css3/masking/clip-path-circle-border-box.html: Added.
  • css3/masking/clip-path-circle-bounding-box.html: Added.
  • css3/masking/clip-path-circle-content-box.html: Added.
  • css3/masking/clip-path-circle-margin-box.html: Added.
  • css3/masking/clip-path-circle-padding-box.html: Added.
  • platform/mac/css3/masking/clip-path-circle-border-box-expected.png: Added.
  • platform/mac/css3/masking/clip-path-circle-border-box-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-circle-bounding-box-expected.png: Added.
  • platform/mac/css3/masking/clip-path-circle-bounding-box-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-circle-content-box-expected.png: Added.
  • platform/mac/css3/masking/clip-path-circle-content-box-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-circle-margin-box-expected.png: Added.
  • platform/mac/css3/masking/clip-path-circle-margin-box-expected.txt: Added.
  • platform/mac/css3/masking/clip-path-circle-padding-box-expected.png: Added.
  • platform/mac/css3/masking/clip-path-circle-padding-box-expected.txt: Added.
  • platform/mac/css3/masking/mask-luminance-png-expected.png: Added.
1:22 PM Changeset in webkit [161668] by commit-queue@webkit.org
  • 9 edits
    10 adds in trunk

Source/WebCore: Correctly set XHR loadend attributes (loaded and total).
https://bugs.webkit.org/show_bug.cgi?id=120828

Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-10
Reviewed by Alexey Proskuryakov.

Added correct initialization of lengthComputable, loaded and total attributes
to XHR ProgressEvent events (load, loadstart, loadend, abort, error and timeout).

XMLHttpRequestProgressEventThrottle and XMLHttpRequestUpload now keep persistent knowledge
of m_loaded and m_total values with this patch.

Code refactoring to handle event dispatching in case of error in a single manner.
XMLHttpRequestProgressEventThrottle::dispatchProgressEvent is renamed as dispatchThrottledProgressEvent
XMLHttpRequestProgressEventThrottle::dispatchEventAndLoadend is replaced by dispatchProgressEvent(const AtomicString&)

Fixed assertion issues over bug 120828 patch

Tests: http/tests/xmlhttprequest/loadstart-event-init.html

http/tests/xmlhttprequest/onabort-progressevent-attributes.html
http/tests/xmlhttprequest/onload-progressevent-attributes.html
http/tests/xmlhttprequest/upload-onabort-progressevent-attributes.html
http/tests/xmlhttprequest/upload-onload-progressevent-attributes.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::callReadyStateChangeListener): changed readystatechange event from ProgressEvent to Event (not cancellable, not bubblable) to better match the spec
(WebCore::XMLHttpRequest::createRequest):
(WebCore::XMLHttpRequest::abort): code refactoring to handle error event dispatching in a single way
(WebCore::XMLHttpRequest::networkError): code refactoring to handle error event dispatching in a single way
(WebCore::XMLHttpRequest::abortError): code refactoring to handle error event dispatching in a single way
(WebCore::XMLHttpRequest::didSendData):
(WebCore::XMLHttpRequest::didReceiveData):
(WebCore::XMLHttpRequest::dispatchErrorEvents): dispatch progress events in case of error
(WebCore::XMLHttpRequest::didTimeout): code refactoring to handle error event dispatching in a single way

  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequestProgressEventThrottle.cpp: before the patch, the fact that a progress event is being throttled is stored indirectly (m_loaded or m_total not equal to zero). With the patch, this information is stored in m_hasThrottledProgressEvent. The m_loaded and m_total values are no longer set back to zero after a progress event is dispatched. This allows using these values to correctly initialize other ProgressEvent events (in particular loadend, abort, timeout...)

(WebCore::XMLHttpRequestProgressEventThrottle::XMLHttpRequestProgressEventThrottle):
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchThrottledProgressEvent): always update the new m_loaded and m_total values. If progress event is not sent as part of the function call, store the fact that a progress event is being throttled through m_hasThrottledProgressEvent.
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent): used to send any ProgressEvent event that is not be throttled
(WebCore::XMLHttpRequestProgressEventThrottle::flushProgressEvent): after the call, no progress event is throttled anymore
(WebCore::XMLHttpRequestProgressEventThrottle::fired): after the call, no progress event is throttled anymore
(WebCore::XMLHttpRequestProgressEventThrottle::hasEventToDispatch):
(WebCore::XMLHttpRequestProgressEventThrottle::suspend):

  • xml/XMLHttpRequestProgressEventThrottle.h: introduced m_hasThrottledProgressEvent which stores whether a progress event is being throttled and m_computableLength which is used to initialize ProgressEvent computableLength
  • xml/XMLHttpRequestUpload.cpp:

(WebCore::XMLHttpRequestUpload::XMLHttpRequestUpload):
(WebCore::XMLHttpRequestUpload::dispatchProgressEvent):

  • xml/XMLHttpRequestUpload.h: introduced m_loaded, m_total and m_lengthComputable, similarly to XMLHttpRequestProgressEventThrottle

LayoutTests: Correctly set XHR loadend event attributes (loaded and total).
https://bugs.webkit.org/show_bug.cgi?id=120828

Patch by Youenn Fablet <youennf@gmail.com> on 2014-01-10
Reviewed by Alexey Proskuryakov.

Tests for abort, load, loadstart and loadend ProgressEvent events for XMLHttpRequest and XMLHttpRequestUpload

  • fast/xmlhttprequest/xmlhttprequest-get-expected.txt: Changed to correct event values
  • http/tests/xmlhttprequest/loadstart-event-init-expected.txt: Added.
  • http/tests/xmlhttprequest/loadstart-event-init.html: Added.
  • http/tests/xmlhttprequest/onabort-progressevent-attributes-expected.txt: Added.
  • http/tests/xmlhttprequest/onabort-progressevent-attributes.html: Added.
  • http/tests/xmlhttprequest/onload-progressevent-attributes-expected.txt: Added.
  • http/tests/xmlhttprequest/onload-progressevent-attributes.html: Added.
  • http/tests/xmlhttprequest/upload-onabort-progressevent-attributes-expected.txt: Added.
  • http/tests/xmlhttprequest/upload-onabort-progressevent-attributes.html: Added.
  • http/tests/xmlhttprequest/upload-onload-progressevent-attributes-expected.txt: Added.
  • http/tests/xmlhttprequest/upload-onload-progressevent-attributes.html: Added.
1:12 PM Changeset in webkit [161667] by betravis@adobe.com
  • 3 edits in trunk/Source/WebCore

[CSS Shapes] Change parseBasicShape to return a CSSPrimitiveValue
https://bugs.webkit.org/show_bug.cgi?id=126713

Reviewed by Dirk Schulze.

Avoid the duplicated code wrapping the CSSBasicShape in a CSSPrimitiveValue
by having parseBasicShape return a CSSPrimitiveValue reference.

Refactoring, no new tests.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseShapeProperty):
(WebCore::CSSParser::parseClipPath):
(WebCore::CSSParser::parseBasicShape):

  • css/CSSParser.h:
1:10 PM Changeset in webkit [161666] by mario.prada@samsung.com
  • 29 edits in trunk

Move platformName property from testRunner to accessibilityController
https://bugs.webkit.org/show_bug.cgi?id=126689

Reviewed by Chris Fleizach.

Tools:

Move the platformName property from the testRunner into
accessibilityController, since this is a concept that has only be
used by accessibility tests since it got added, and also because
the real intention was not to distinguish among "ports" (mac, win,
gtk, efl) but between platforms (atk, mac, win).

This change will be very useful to merge GTK's roles-exposed.html
and Mac's role-subrole-roledescription.html into one single test,
since we will be specifying in the test itself which elements are
supported in which accessibility "platform". In this context,
being able to check accessibilityController.platformName directly
against a list of supported accessibility platforms (e.g. "atk,mac")
will certainly maintain the code cleaner and simpler.

  • DumpRenderTree/TestRunner.h:

(TestRunner::platformName): Removed.

  • DumpRenderTree/TestRunner.cpp:

(getPlatformNameCallback): Removed.
(TestRunner::staticValues): Removed platformName

  • DumpRenderTree/efl/TestRunnerEfl.cpp:

(TestRunner::platformName): Removed.

  • DumpRenderTree/gtk/TestRunnerGtk.cpp:

(TestRunner::platformName): Removed.

  • DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::platformName): Removed.

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::platformName): Removed.

  • DumpRenderTree/AccessibilityController.h:

(AccessibilityController::platformName): Added.

  • DumpRenderTree/AccessibilityController.cpp:

(getPlatformNameCallback): Added.
(AccessibilityController::getJSClass): Added platformName.

  • DumpRenderTree/atk/AccessibilityControllerAtk.cpp:

(AccessibilityController::platformName): Added, returning "atk".

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::platformName): Ditto, returning "mac".

  • DumpRenderTree/ios/AccessibilityControllerIOS.mm:

(AccessibilityController::platformName): Ditto, returning "ios".

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::platformName): Ditto, returning "win".

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:

(platformName): Removed.

  • WebKitTestRunner/InjectedBundle/TestRunner.h:

(TestRunner::platformName): Removed.

  • WebKitTestRunner/InjectedBundle/efl/TestRunnerEfl.cpp:

(TestRunner::platformName): Removed.

  • WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:

(TestRunner::platformName): Removed.

  • WebKitTestRunner/InjectedBundle/mac/TestRunnerMac.mm:

(TestRunner::platformName): Removed.

  • WebKitTestRunner/InjectedBundle/win/TestRunnerWin.cpp:

(TestRunner::platformName): Removed.

  • WebKitTestRunner/InjectedBundle/AccessibilityController.h:

(WTR:AccessibilityController::platformName): Added.

  • WebKitTestRunner/InjectedBundle/Bindings/AccessibilityController.idl:

(platformName): Added.

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:

(WTR::AccessibilityController::platformName): Added, returning "atk".

  • WebKitTestRunner/InjectedBundle/mac/AccessibilityControllerMac.mm:

(WTR::AccessibilityController::platformName): Added, returning "mac".

LayoutTests:

Updated tests and expectations affected by the move of
platformName from TestRunner to AccessibilityController.

  • accessibility/canvas-fallback-content.html:
  • accessibility/ignore-spacer-elements.html:
  • accessibility/platform-name.html:
  • platform/efl/accessibility/platform-name-expected.txt:
  • platform/gtk/accessibility/platform-name-expected.txt:
1:08 PM Changeset in webkit [161665] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Possible crash in ApplicationCache::removeResource.
https://bugs.webkit.org/show_bug.cgi?id=126695

Patch by Piotr Grad <p.grad@samsung.com> on 2014-01-10
Reviewed by Alexey Proskuryakov.

No new tests.

Iterator variable was used after it was removed.

  • loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::removeResource):

12:51 PM Changeset in webkit [161664] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Another build fix for the Production Mac build following <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

Move the logic for appending the port-specific IDL files {Touch, TouchEvent, TouchList}.idl to the
list of binding IDLs (BINDING_IDLS) before the definition of variables DOM_CLASSES and JS_DOM_HEADERS
so that we generate the DOM and JS bindings for these IDLs.

  • DerivedSources.make:
12:47 PM Changeset in webkit [161663] by andersca@apple.com
  • 5 edits
    6 deletes in trunk

Remove supportMultipleWindows setting
https://bugs.webkit.org/show_bug.cgi?id=126772

Reviewed by Beth Dakin.

Source/WebCore:

This setting was added in https://bugs.webkit.org/show_bug.cgi?id=99716 for the Chromium port
and is unused by everyone else so get rid of it.

  • loader/FrameLoader.cpp:

(WebCore::createWindow):

  • page/ContextMenuController.cpp:

(WebCore::openNewWindow):

  • page/Settings.in:

LayoutTests:

  • fast/dom/HTMLAnchorElement/anchor-no-multiple-windows-expected.txt: Removed.
  • fast/dom/HTMLAnchorElement/anchor-no-multiple-windows.html: Removed.
  • fast/dom/Window/window-open-no-multiple-windows-expected.txt: Removed.
  • fast/dom/Window/window-open-no-multiple-windows.html: Removed.
  • fast/forms/post-popup-no-multiple-windows-expected.txt: Removed.
  • fast/forms/post-popup-no-multiple-windows.html: Removed.
12:41 PM Changeset in webkit [161662] by benjamin@webkit.org
  • 29 edits in trunk/Source

Remove the BlackBerry port from trunk
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-10
Reviewed by Anders Carlsson.

Source/WebCore:

  • dom/TouchEvent.cpp:

(WebCore::TouchEvent::TouchEvent):
(WebCore::TouchEvent::initTouchEvent):

  • dom/TouchEvent.h:
  • dom/ViewportArguments.cpp:
  • dom/ViewportArguments.h:
  • history/HistoryItem.h:
  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::createResourceHandle):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading):

  • page/NavigatorBase.cpp:
  • page/Settings.cpp:
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::ScrollingCoordinator::create):

  • platform/Cursor.cpp:
  • platform/Cursor.h:

(WebCore::Cursor::Cursor):

  • platform/DragData.h:
  • platform/DragImage.h:
  • plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::defaultPluginDirectories):
(WebCore::PluginDatabase::isPreferredPluginDirectory):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintsIntoWindow):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::shouldRespectImageOrientation):

  • testing/Internals.cpp:

(WebCore::Internals::getCurrentCursorInfo):

  • workers/DefaultSharedWorkerRepository.cpp:

(WebCore::SharedWorkerScriptLoader::load):

  • workers/Worker.cpp:

(WebCore::Worker::create):

  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::importScripts):

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::createResourceRequest):

  • workers/WorkerScriptLoader.h:
  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::setCursor):

12:40 PM Changeset in webkit [161661] by benjamin@webkit.org
  • 12 edits in trunk

Remove the BlackBerry port from trunk
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-10
Reviewed by Anders Carlsson.

.:

  • CMakeLists.txt:

Source/WebCore:

  • Modules/navigatorcontentutils/NavigatorContentUtils.cpp:

(WebCore::initProtocolHandlerWhitelist):

  • UseJSC.cmake:
  • bindings/generic/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::RuntimeEnabledFeatures):

  • bindings/js/GCController.cpp:

(WebCore::GCController::GCController):
(WebCore::GCController::garbageCollectSoon):

  • bindings/js/GCController.h:

Source/WebKit2:

  • Scripts/generate-forwarding-headers.pl:

Tools:

  • Scripts/webkitpy/common/config/watchlist:
12:38 PM Changeset in webkit [161660] by dbates@webkit.org
  • 4 edits in trunk/Source

Fix the WebCore, WebKit build targets following <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

Source/WebCore:

Tell Xcode that the supported platforms for all WebKit targets are iOS and OS X.

  • Configurations/Base.xcconfig:

Source/WebKit/mac:

Tell Xcode that the supported platforms for all WebCore targets are iOS and OS X.

  • Configurations/Base.xcconfig:
11:50 AM Changeset in webkit [161659] by benjamin@webkit.org
  • 4 edits
    5 deletes in trunk

Remove the BlackBerry files outside WebCore
https://bugs.webkit.org/show_bug.cgi?id=126715

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-09
Reviewed by Anders Carlsson.

.:

  • ManualTests/blackberry: Removed.
  • Source/cmake/OptionsBlackBerry.cmake: Removed.

Source/JavaScriptCore:

  • PlatformBlackBerry.cmake: Removed.
  • runtime/GCActivityCallbackBlackBerry.cpp: Removed.
  • shell/PlatformBlackBerry.cmake: Removed.

Tools:

  • DumpRenderTree/blackberry: Removed.

LayoutTests:

  • platform/blackberry: Removed.
11:32 AM Changeset in webkit [161658] by aestes@apple.com
  • 4 edits in trunk/Source

[iOS] Upstream iOS changes to MigrateHeaders.make
https://bugs.webkit.org/show_bug.cgi?id=126731

Reviewed by David Kilzer.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj: Mark an iOS-specific header at

Private that will later be migrated by WebKit.

Source/WebKit/mac:

  • MigrateHeaders.make: Migrate iOS-specific headers when building for iOS.
11:13 AM Changeset in webkit [161657] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the Production Mac build following <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

Substitute JAVASCRIPTCORE_PRIVATE_HEADERS_DIR_Production_ for JAVASCRIPTCORE_PRIVATE_HEADERS_Production_.

  • Configurations/WebCore.xcconfig:
11:12 AM Changeset in webkit [161656] by Simon Fraser
  • 6 edits in trunk/Tools

Remove knowledge of Blackberry from build scripts
https://bugs.webkit.org/show_bug.cgi?id=126766

Reviewed by Anders Carlsson.

Remove isBlackBerry() and references to it, and rmeove
blackberry-related stuff from the watchlist.

  • Scripts/build-webkit:
  • Scripts/webkit-build-directory:
  • Scripts/webkitdirs.pm:

(determineBaseProductDir):
(argumentsForConfiguration):
(builtDylibPathForName):
(isAppleWebKit):
(buildCMakeProjectOrExit):
(cmakeBasedPortArguments):
(cmakeBasedPortName):

  • Scripts/webkitperl/FeatureList.pm:
  • Scripts/webkitpy/common/config/watchlist:
11:07 AM Changeset in webkit [161655] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Add a missing include.

  • Modules/webdatabase/DatabaseManager.h:
11:02 AM Changeset in webkit [161654] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Use STL threading primitives in DatabaseDetails and DatabaseManager
https://bugs.webkit.org/show_bug.cgi?id=126759

Reviewed by Geoffrey Garen.

  • Modules/webdatabase/DatabaseDetails.h:

(WebCore::DatabaseDetails::DatabaseDetails):
(WebCore::DatabaseDetails::threadID):

  • Modules/webdatabase/DatabaseManager.cpp:

(WebCore::DatabaseManager::existingDatabaseContextFor):
(WebCore::DatabaseManager::registerDatabaseContext):
(WebCore::DatabaseManager::unregisterDatabaseContext):
(WebCore::DatabaseManager::didConstructDatabaseContext):
(WebCore::DatabaseManager::didDestructDatabaseContext):
(WebCore::DatabaseManager::addProposedDatabase):
(WebCore::DatabaseManager::removeProposedDatabase):
(WebCore::DatabaseManager::fullPathForDatabase):
(WebCore::DatabaseManager::detailsForNameAndOrigin):

  • Modules/webdatabase/DatabaseManager.h:
10:59 AM Changeset in webkit [161653] by commit-queue@webkit.org
  • 4 edits
    7 deletes in trunk

Unreviewed, rolling out r161629.
http://trac.webkit.org/changeset/161629
https://bugs.webkit.org/show_bug.cgi?id=126762

Fails svg/custom/conditional-processing-2.html (Requested by
ap on #webkit).

Source/WebCore:

  • svg/SVGSwitchElement.cpp:

(WebCore::SVGSwitchElement::childShouldCreateRenderer):

  • svg/SVGTests.cpp:

(WebCore::SVGTests::hasExtension):
(WebCore::SVGTests::isValid):

LayoutTests:

  • svg/custom/conditional-processing-1-expected.txt: Removed.
  • svg/custom/conditional-processing-1.svg: Removed.
  • svg/custom/conditional-processing-2-expected.txt: Removed.
  • svg/custom/conditional-processing-2.html: Removed.
  • svg/dom/SVGTests-expected.txt: Removed.
  • svg/dom/SVGTests.html: Removed.
  • svg/dom/script-tests/SVGTests.js: Removed.
10:53 AM Changeset in webkit [161652] by ChangSeok Oh
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix since r161589.

The changeset causes a compile failure with --no-svg.

  • platform/graphics/FontFastPath.cpp:

(WebCore::Font::drawGlyphBuffer):

10:49 AM Changeset in webkit [161651] by dbates@webkit.org
  • 3 edits in trunk/Tools

[iOS] Fix up simulator build and enable default features

Rubber-stamped by Joseph Pecoraro.

  • Scripts/webkitdirs.pm:

(determineArchitecture):
(determinePassedArchitecture):

  • Scripts/webkitperl/FeatureList.pm: Also expose command line option to toggle ENABLE_PLUGIN_PROXY_FOR_VIDEO (enabled

by default only in iOS).

10:38 AM Changeset in webkit [161650] by ggaren@apple.com
  • 7 edits
    2 deletes in trunk/Source/JavaScriptCore

Removed Blackberry #ifdefs and platform code from JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=126757

Reviewed by Sam Weinig.

  • PlatformBlackBerry.cmake: Removed.
  • heap/HeapTimer.cpp:
  • heap/HeapTimer.h:
  • heap/IncrementalSweeper.cpp:
  • heap/IncrementalSweeper.h:
  • jsc.cpp:

(main):

  • runtime/GCActivityCallbackBlackBerry.cpp: Removed.
  • runtime/MemoryStatistics.cpp:

(JSC::globalMemoryStatistics):

10:22 AM Changeset in webkit [161649] by Brent Fulgham
  • 1 edit in trunk/Source/WebCore/ChangeLog

[WebGL] Removing unnecessary pointer checks
https://bugs.webkit.org/show_bug.cgi?id=124046

Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2014-01-10
Reviewed by Brent Fulgham.

We do not need to check for a null array three times in
the same call. Let's just do it once!

No new tests. Covered by existing ones.

  • html/canvas/WebGLBuffer.cpp:

(WebCore::WebGLBuffer::associateBufferData):

10:22 AM Changeset in webkit [161648] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Speculative build fix for Windows following <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

Patch by Daniel Bates <dabates@apple.com> on 2014-01-10
Reviewed by David Kilzer.

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

10:20 AM Changeset in webkit [161647] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Speculative build fix for Windows following <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

10:15 AM Changeset in webkit [161646] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

Unreviewed test correction after r161605.

  • platform/mac/TestExpectations: Reactivate tests fixed by

https://bugs.webkit.org/show_bug.cgi?id=126718.

10:12 AM Changeset in webkit [161645] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[WebGL] Wrong condition order in the if statement
https://bugs.webkit.org/show_bug.cgi?id=125000

Patch by Przemyslaw Szymanski <p.szymanski3@samsung.com> on 2014-01-10
Reviewed by Brent Fulgham.

We should only pay the cost of string comparison once. The
current logic requires a string comparison every time we
pass through the function. Instead, by reordering the statements
we can short-circuit through the boolean test after the initial
setup is complete.

No new tests. No behaviour changes.

  • platform/graphics/opengl/Extensions3DOpenGLES.cpp:

(WebCore::Extensions3DOpenGLES::supportsExtension):

9:50 AM Changeset in webkit [161644] by andersca@apple.com
  • 8 edits in trunk/Source/WebCore

CTTE in AudioContext::AutoLocker
https://bugs.webkit.org/show_bug.cgi?id=126758

Reviewed by Antti Koivisto.

  • Modules/webaudio/AudioBasicInspectorNode.cpp:

(WebCore::AudioBasicInspectorNode::connect):
(WebCore::AudioBasicInspectorNode::disconnect):

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::setBuffer):

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::refNode):
(WebCore::AudioContext::deleteMarkedNodes):
(WebCore::AudioContext::removeMarkedSummingJunction):

  • Modules/webaudio/AudioContext.h:

(WebCore::AudioContext::AutoLocker::AutoLocker):
(WebCore::AudioContext::AutoLocker::~AutoLocker):

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::connect):
(WebCore::AudioNode::disconnect):
(WebCore::AudioNode::setChannelCount):
(WebCore::AudioNode::setChannelCountMode):
(WebCore::AudioNode::setChannelInterpretation):
(WebCore::AudioNode::enableOutputsIfNecessary):

  • Modules/webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::setFormat):

  • Modules/webaudio/WaveShaperNode.cpp:

(WebCore::WaveShaperNode::setOversample):

9:45 AM Changeset in webkit [161643] by Antti Koivisto
  • 6 edits in trunk/Source/WebCore

Use element iterators more
https://bugs.webkit.org/show_bug.cgi?id=126756

Reviewed by Anders Carlsson.

  • dom/VisitedLinkState.cpp:

(WebCore::VisitedLinkState::invalidateStyleForAllLinks):
(WebCore::VisitedLinkState::invalidateStyleForLink):

  • html/HTMLMeterElement.cpp:

(WebCore::HTMLMeterElement::renderMeter):

  • html/HTMLProgressElement.cpp:

(WebCore::HTMLProgressElement::renderProgress):

  • html/shadow/ContentDistributor.cpp:

(WebCore::ContentDistributor::ensureInsertionPointList):

  • style/StyleResolveTree.cpp:
9:37 AM Changeset in webkit [161642] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to fix the iOS build after <http://trac.webkit.org/changeset/161589>
(https://bugs.webkit.org/show_bug.cgi?id=126654)

  • platform/audio/ios/AudioSessionIOS.mm: Import header PassOwnPtr.h so that we can use adoptPtr().
9:19 AM Changeset in webkit [161641] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Attempt to fix the build after <http://trac.webkit.org/changeset/161638>
(https://bugs.webkit.org/show_bug.cgi?id=126698)

Substitute tab characters for space characters.

  • DerivedSources.make:
9:17 AM Changeset in webkit [161640] by commit-queue@webkit.org
  • 3 edits in trunk/WebKitLibraries

[WinCairo] Crash when rendering (in pixman dll)
https://bugs.webkit.org/show_bug.cgi?id=126750

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-01-10
Reviewed by Brent Fulgham.

Since we link with cairo.lib, and the gstreamer installation also comes with cairo.lib,
we link with the wrong cairo.lib, and loads gstreamers cairo dll, instead of our own.
We should user our own cairo dll for rendering.

  • win/tools/vsprops/GStreamer32.props: Put gstreamer lib path last, so we link with the correct cairo.lib.
  • win/tools/vsprops/GStreamer64.props: Ditto.
9:07 AM Changeset in webkit [161639] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

DOMWindow::showModalDialog should use std::function
https://bugs.webkit.org/show_bug.cgi?id=126753

Reviewed by Antti Koivisto.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::DialogHandler::dialogCreated):
(WebCore::JSDOMWindow::showModalDialog):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::createWindow):
(WebCore::DOMWindow::showModalDialog):

  • page/DOMWindow.h:
9:06 AM Changeset in webkit [161638] by dbates@webkit.org
  • 107 edits
    2 copies
    27 adds in trunk

[iOS] Upstream WebCore and Tools miscellaneous changes
https://bugs.webkit.org/show_bug.cgi?id=126698

Reviewed by David Kilzer.

Source/WebCore:

  • Configurations/Base.xcconfig:
  • Configurations/WebCore.xcconfig:
  • Configurations/WebCoreTestSupport.xcconfig:
  • Configurations/iOS.xcconfig: Added.
  • DerivedSources.make:
  • English.lproj/Localizable.strings:
  • Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.cpp: Copied from Source/WebCore/editing/TextAffinity.h.

(WebCore::stringForPlaybackTargetAvailability):
(WebCore::WebKitPlaybackTargetAvailabilityEvent::WebKitPlaybackTargetAvailabilityEvent):

  • Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h: Added.

(WebCore::WebKitPlaybackTargetAvailabilityEventInit::WebKitPlaybackTargetAvailabilityEventInit):
(WebCore::WebKitPlaybackTargetAvailabilityEvent::~WebKitPlaybackTargetAvailabilityEvent):
(WebCore::WebKitPlaybackTargetAvailabilityEvent::create):
(WebCore::WebKitPlaybackTargetAvailabilityEvent::availability):

  • Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.idl: Copied from Source/WebCore/editing/DeleteButton.h.
  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::Geolocation):
(WebCore::Geolocation::canSuspend):
(WebCore::Geolocation::suspend):
(WebCore::Geolocation::resume):
(WebCore::Geolocation::resumeTimerFired):
(WebCore::Geolocation::resetAllGeolocationPermission):
(WebCore::Geolocation::stop):
(WebCore::Geolocation::setIsAllowed):
(WebCore::Geolocation::positionChanged):
(WebCore::Geolocation::setError):

  • Modules/geolocation/Geolocation.h:
  • Modules/geolocation/NavigatorGeolocation.cpp:

(WebCore::NavigatorGeolocation::resetAllGeolocationPermission):

  • Modules/geolocation/NavigatorGeolocation.h:
  • Modules/speech/SpeechSynthesis.cpp:

(WebCore::SpeechSynthesis::SpeechSynthesis):
(WebCore::SpeechSynthesis::speak):

  • Modules/speech/SpeechSynthesis.h:

(WebCore::SpeechSynthesis::userGestureRequiredForSpeechStart):
(WebCore::SpeechSynthesis::removeBehaviorRestriction):

  • Modules/webaudio/AudioContext.cpp:
  • Modules/webaudio/AudioContext.h:
  • Modules/webaudio/AudioScheduledSourceNode.cpp:
  • Modules/webdatabase/Database.cpp:
  • Modules/webdatabase/DatabaseBackendBase.cpp:

(WebCore::DatabaseBackendBase::performOpenAndVerify):
(WebCore::DatabaseBackendBase::incrementalVacuumIfNeeded):

  • Modules/webdatabase/DatabaseContext.cpp:

(WebCore::DatabaseContext::DatabaseContext):
(WebCore::DatabaseContext::databaseThread):
(WebCore::DatabaseContext::setPaused):

  • Modules/webdatabase/DatabaseContext.h:
  • Modules/webdatabase/DatabaseManagerClient.h:
  • Modules/webdatabase/DatabaseTask.cpp:

(WebCore::DatabaseTask::performTask):
(WebCore::Database::DatabaseTransactionTask::shouldPerformWhilePaused):

  • Modules/webdatabase/DatabaseTask.h:
  • Modules/webdatabase/DatabaseThread.cpp:

(WebCore::DatabaseThread::DatabaseThread):
(WebCore::DatabaseThread::requestTermination):
(WebCore::DatabaseUnpauseTask::create):
(WebCore::DatabaseUnpauseTask::shouldPerformWhilePaused):
(WebCore::DatabaseUnpauseTask::DatabaseUnpauseTask):
(WebCore::DatabaseUnpauseTask::doPerformTask):
(WebCore::DatabaseUnpauseTask::debugTaskName):
(WebCore::DatabaseThread::setPaused):
(WebCore::DatabaseThread::handlePausedQueue):
(WebCore::DatabaseThread::databaseThread):

  • Modules/webdatabase/DatabaseThread.h:
  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::setQuota):
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
(WebCore::DatabaseTracker::deleteDatabaseFile):
(WebCore::DatabaseTracker::removeDeletedOpenedDatabases):
(WebCore::isZeroByteFile):
(WebCore::DatabaseTracker::deleteDatabaseFileIfEmpty):
(WebCore::DatabaseTracker::openDatabaseMutex):
(WebCore::DatabaseTracker::emptyDatabaseFilesRemovalTaskWillBeScheduled):
(WebCore::DatabaseTracker::emptyDatabaseFilesRemovalTaskDidFinish):
(WebCore::DatabaseTracker::setDatabasesPaused):

  • Modules/webdatabase/DatabaseTracker.h:
  • Modules/webdatabase/SQLTransactionBackend.cpp:

(WebCore::SQLTransactionBackend::shouldPerformWhilePaused):

  • Modules/webdatabase/SQLTransactionBackend.h:
  • Resources/DictationPhraseWithAlternativesDot.png: Added.
  • Resources/DictationPhraseWithAlternativesDot@2x.png: Added.
  • Resources/SpellingDot.png: Added.
  • Resources/SpellingDot@2x.png: Added.
  • Resources/decrementArrow.tiff: Added.
  • Resources/hScrollControl_left.png: Added.
  • Resources/hScrollControl_middle.png: Added.
  • Resources/hScrollControl_right.png: Added.
  • Resources/incrementArrow.tiff: Added.
  • Resources/markedLeft.png: Added.
  • Resources/markedMiddle.png: Added.
  • Resources/markedRight.png: Added.
  • Resources/vScrollControl_bottom.png: Added.
  • Resources/vScrollControl_middle.png: Added.
  • Resources/vScrollControl_top.png: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/GCController.cpp:

(WebCore::GCController::garbageCollectNow):
(WebCore::GCController::releaseExecutableMemory):

  • bindings/js/GCController.h:
  • bindings/js/JSCallbackData.h:

(WebCore::JSCallbackData::~JSCallbackData):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::supportsProfiling):
(WebCore::JSDOMWindowBase::shouldInterruptScriptBeforeTimeout):
(WebCore::JSDOMWindowBase::commonVM):
(WebCore::JSDOMWindowBase::commonVMExists):
(WebCore::JSDOMWindowBase::commonVMInternal):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::touch):
(WebCore::JSDOMWindow::touchList):

  • bindings/js/JSDeviceOrientationEventCustom.cpp:

(WebCore::JSDeviceOrientationEvent::webkitCompassHeading):
(WebCore::JSDeviceOrientationEvent::webkitCompassAccuracy):
(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):

  • bindings/js/JSMainThreadExecState.h:
  • bindings/js/JSTouchCustom.cpp:
  • bindings/js/JSTouchListCustom.cpp:
  • bindings/js/PageScriptDebugServer.cpp:

(WebCore::PageScriptDebugServer::didContinue):

  • bindings/js/ScriptController.cpp:

(WebCore::ScriptController::initializeThreading):

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::handlePause):

  • bindings/js/ios/TouchConstructors.cpp: Added.
  • bindings/objc/DOM.mm:

(WebCore::wkQuadFromFloatQuad):
(WebCore::kit):
(WebCore::min4):
(WebCore::max4):
(WebCore::emptyQuad):
(-[WKQuadObject initWithQuad:]):
(-[WKQuadObject quad]):
(-[WKQuadObject boundingBox]):
(-[DOMNode boundingBox]):
(-[DOMNode absoluteQuad]):
(-[DOMNode absoluteQuadAndInsideFixedPosition:]):
(-[DOMNode boundingBoxUsingTransforms]):
(-[DOMNode lineBoxQuads]):
(-[DOMNode _linkElement]):
(-[DOMNode hrefURL]):
(-[DOMNode hrefTarget]):
(-[DOMNode hrefFrame]):
(-[DOMNode hrefLabel]):
(-[DOMNode hrefTitle]):
(-[DOMNode boundingFrame]):
(-[DOMNode innerFrameQuad]):
(-[DOMNode computedFontSize]):
(-[DOMNode nextFocusNode]):
(-[DOMNode previousFocusNode]):
(-[DOMRange boundingBox]):
(-[DOMRange renderedImageForcingBlackText:renderedImageForcingBlackText:]):
(-[DOMElement _font]):
(-[DOMHTMLLinkElement _mediaQueryMatchesForOrientation:]):
(-[DOMHTMLLinkElement _mediaQueryMatches]):

  • bindings/objc/DOMEvents.h:
  • bindings/objc/DOMEvents.mm:

(kitClass):

  • bindings/objc/DOMExtensions.h:
  • bindings/objc/DOMHTML.mm:

(-[DOMHTMLElement scrollYOffset]):
(-[DOMHTMLElement setScrollXOffset:scrollYOffset:]):
(-[DOMHTMLElement setScrollXOffset:scrollYOffset:adjustForIOSCaret:]):
(-[DOMHTMLElement absolutePosition::::]):
(-[DOMHTMLInputElement _autocapitalizeType]):
(-[DOMHTMLTextAreaElement _autocapitalizeType]):
(-[DOMHTMLInputElement setValueWithChangeEvent:]):
(-[DOMHTMLInputElement setValueAsNumberWithChangeEvent:]):

  • bindings/objc/DOMInternal.h:
  • bindings/objc/DOMInternal.mm:

(wrapperCacheLock):
(getDOMWrapper):
(addDOMWrapper):
(removeDOMWrapper):

  • bindings/objc/DOMPrivate.h:
  • bindings/objc/DOMUIKitExtensions.h: Added.
  • bindings/objc/DOMUIKitExtensions.mm: Added.
  • bindings/objc/PublicDOMInterfaces.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeaderContentHeader):
(GenerateImplementationContentHeader):
(GenerateHeader):
(GenerateImplementation):
(GenerateCallbackImplementation):

  • bindings/scripts/CodeGeneratorObjC.pm:

(ReadPublicInterfaces):
(GetClassName):
(IsCoreFoundationType):
(GetObjCType):
(AddIncludesForType):
(GenerateHeader):
(GenerateImplementation):
(WriteData):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/preprocessor.pm:

(applyPreprocessor):

  • bridge/objc/objc_class.mm:

(JSC::Bindings::ObjcClass::fieldNamed):

  • bridge/objc/objc_instance.mm:
  • config.h:
  • dom/Document.cpp:

(WebCore::Document::addAutoSizingNode):

  • dom/Document.h:
  • dom/Document.idl:
  • dom/ios/TouchEvents.cpp: Added.
  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyBlockStyle):

  • editing/CompositeEditCommand.cpp:

(WebCore::EditCommandComposition::unapply):
(WebCore::CompositeEditCommand::apply):
(WebCore::CompositeEditCommand::inputText):
(WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
(WebCore::CompositeEditCommand::moveParagraphs):

  • editing/CompositeEditCommand.h:
  • editing/DeleteButton.h:
  • editing/DeleteButtonController.cpp:

(WebCore::DeleteButtonController::enable):
(WebCore::DeleteButtonController::disable):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::doApply):

  • editing/DeleteSelectionCommand.h:
  • editing/EditAction.h:
  • editing/EditCommand.h:

(WebCore::EditCommand::isInsertTextCommand):

  • editing/EditingStyle.cpp:
  • editing/Editor.cpp:

(WebCore::ClearTextCommand::ClearTextCommand):
(WebCore::ClearTextCommand::editingAction):
(WebCore::ClearTextCommand::CreateAndApply):
(WebCore::Editor::handleTextEvent):
(WebCore::Editor::clearText):
(WebCore::Editor::insertDictationPhrases):
(WebCore::Editor::setDictationPhrasesAsChildOfElement):
(WebCore::Editor::confirmMarkedText):
(WebCore::Editor::setTextAsChildOfElement):
(WebCore::Editor::notifyComponentsOnChangedSelection):
(WebCore::Editor::ensureLastEditCommandHasCurrentSelectionIfOpenForMoreTyping):
(WebCore::Editor::copy):
(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::setComposition):
(WebCore::Editor::showSpellingGuessPanel):
(WebCore::Editor::markMisspellingsAfterTypingToWord):
(WebCore::Editor::markMisspellingsOrBadGrammar):
(WebCore::Editor::changeBackToReplacedString):
(WebCore::Editor::updateMarkersForWordsAffectedByEditing):
(WebCore::Editor::setIgnoreCompositionSelectionChange):
(WebCore::Editor::changeSelectionAfterCommand):
(WebCore::Editor::shouldChangeSelection):
(WebCore::Editor::respondToChangedSelection):
(WebCore::Editor::resolveTextCheckingTypeMask):

  • editing/Editor.h:
  • editing/EditorCommand.cpp:

(WebCore::executeClearText):
(WebCore::enabledCopy):
(WebCore::enabledCut):
(WebCore::enabledClearText):
(WebCore::createCommandMap):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::FrameSelection):
(WebCore::FrameSelection::setSelection):
(WebCore::FrameSelection::modifyExtendingRight):
(WebCore::FrameSelection::modifyExtendingForward):
(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingForward):
(WebCore::FrameSelection::modifyExtendingLeft):
(WebCore::FrameSelection::modifyExtendingBackward):
(WebCore::FrameSelection::modifyMovingLeft):
(WebCore::FrameSelection::modifyMovingBackward):
(WebCore::FrameSelection::setSelectedRange):
(WebCore::FrameSelection::focusedOrActiveStateChanged):
(WebCore::FrameSelection::updateAppearance):
(WebCore::FrameSelection::shouldDeleteSelection):
(WebCore::FrameSelection::revealSelection):
(WebCore::FrameSelection::setSelectionFromNone):
(WebCore::FrameSelection::shouldChangeSelection):
(WebCore::FrameSelection::expandSelectionToElementContainingCaretSelection):
(WebCore::FrameSelection::elementRangeContainingCaretSelection):
(WebCore::FrameSelection::expandSelectionToWordContainingCaretSelection):
(WebCore::FrameSelection::wordRangeContainingCaretSelection):
(WebCore::FrameSelection::expandSelectionToStartOfWordContainingCaretSelection):
(WebCore::FrameSelection::characterInRelationToCaretSelection):
(WebCore::FrameSelection::characterBeforeCaretSelection):
(WebCore::FrameSelection::characterAfterCaretSelection):
(WebCore::FrameSelection::wordOffsetInRange):
(WebCore::FrameSelection::spaceFollowsWordInRange):
(WebCore::FrameSelection::selectionAtDocumentStart):
(WebCore::FrameSelection::selectionAtSentenceStart):
(WebCore::FrameSelection::selectionAtWordStart):
(WebCore::FrameSelection::rangeByMovingCurrentSelection):
(WebCore::FrameSelection::rangeByExtendingCurrentSelection):
(WebCore::FrameSelection::selectRangeOnElement):
(WebCore::FrameSelection::wordSelectionContainingCaretSelection):
(WebCore::FrameSelection::actualSelectionAtSentenceStart):
(WebCore::FrameSelection::rangeByAlteringCurrentSelection):
(WebCore::FrameSelection::clearCurrentSelection):
(WebCore::FrameSelection::setCaretBlinks):
(WebCore::FrameSelection::setCaretColor):

  • editing/FrameSelection.h:

(WebCore::FrameSelection::suppressCloseTyping):
(WebCore::FrameSelection::restoreCloseTyping):
(WebCore::FrameSelection::setUpdateAppearanceEnabled):
(WebCore::FrameSelection::suppressScrolling):
(WebCore::FrameSelection::restoreScrolling):

  • editing/InsertIntoTextNodeCommand.cpp:

(WebCore::InsertIntoTextNodeCommand::doReapply):

  • editing/InsertIntoTextNodeCommand.h:
  • editing/InsertTextCommand.h:
  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::doApply):

  • editing/TextAffinity.h:
  • editing/TextCheckingHelper.cpp:
  • editing/TextGranularity.h:
  • editing/TextIterator.cpp:

(WebCore::isRendererReplacedElement):

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::ensureLastEditCommandHasCurrentSelectionIfOpenForMoreTyping):
(WebCore::TypingCommand::markMisspellingsAfterTyping):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
(WebCore::FriendlyEditCommand::setEndingSelection):
(WebCore::TypingCommand::setEndingSelectionOnLastInsertCommand):

  • editing/TypingCommand.h:
  • editing/VisiblePosition.h:

(WebCore::operator<):
(WebCore::operator>):
(WebCore::operator<=):
(WebCore::operator>=):

  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::setStartAndEndFromBaseAndExtentRespectingGranularity):
(WebCore::VisibleSelection::adjustSelectionToAvoidCrossingEditingBoundaries):

  • editing/VisibleUnits.cpp:

(WebCore::previousBoundary):
(WebCore::nextBoundary):
(WebCore::startOfDocument):
(WebCore::endOfDocument):
(WebCore::directionIsDownstream):
(WebCore::atBoundaryOfGranularity):
(WebCore::withinTextUnitOfGranularity):
(WebCore::nextCharacterBoundaryInDirection):
(WebCore::nextWordBoundaryInDirection):
(WebCore::nextSentenceBoundaryInDirection):
(WebCore::nextLineBoundaryInDirection):
(WebCore::nextParagraphBoundaryInDirection):
(WebCore::nextDocumentBoundaryInDirection):
(WebCore::positionOfNextBoundaryOfGranularity):
(WebCore::enclosingTextUnitOfGranularity):
(WebCore::distanceBetweenPositions):
(WebCore::wordRangeFromPosition):
(WebCore::closestWordBoundaryForPosition):

  • editing/VisibleUnits.h:
  • editing/ios/DictationCommandIOS.cpp: Added.
  • editing/ios/DictationCommandIOS.h: Added.

(WebCore::DictationCommandIOS::create):
(WebCore::DictationCommandIOS::editingAction):

  • editing/mac/FrameSelectionMac.mm:

(WebCore::FrameSelection::notifyAccessibilityForSelectionChange):

  • fileapi/AsyncFileStream.cpp:
  • generate-export-file: Added.
  • inspector/InspectorCounters.h:
  • inspector/InspectorFrontendHost.h:
  • make-export-file-generator:
  • plugins/PluginPackage.h:
  • plugins/PluginViewBase.h:

(WebCore::PluginViewBase::willProvidePluginLayer):
(WebCore::PluginViewBase::attachPluginLayer):
(WebCore::PluginViewBase::detachPluginLayer):

  • style/StyleResolveForDocument.cpp:

(WebCore::Style::resolveForDocument):

  • style/StyleResolveTree.cpp:

(WebCore::Style::elementImplicitVisibility):

  • testing/Internals.cpp:

(WebCore::Internals::getCurrentCursorInfo):
(WebCore::Internals::isSelectPopupVisible):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThread::workerThread):

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • MigrateHeaders.make:

Tools:

  • Scripts/check-for-inappropriate-objc-class-names:
  • Scripts/check-for-webkit-framework-include-consistency:
8:55 AM Changeset in webkit [161637] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the iOS build after <http://trac.webkit.org/changeset/161589>
(https://bugs.webkit.org/show_bug.cgi?id=126654)

  • platform/graphics/ios/MediaPlayerPrivateIOS.h:

(WebCore::MediaPlayerPrivateIOS::engineDescription): Adding missing return keyword.

8:31 AM Changeset in webkit [161636] by abucur@adobe.com
  • 3 edits in trunk/Source/WebCore

[CSS Regions] Remove unused CSSParser::parseFlowThread
https://bugs.webkit.org/show_bug.cgi?id=126749

Reviewed by Antti Koivisto.

There are two versions of CSSParser::parseFlowThread. Remove the unused one:
bool parseFlowThread(const String& flowName);

Tests: No tests, code cleanup.

  • css/CSSParser.cpp:
  • css/CSSParser.h:
8:27 AM Changeset in webkit [161635] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[WinCairo] Build fix after r161589.
https://bugs.webkit.org/show_bug.cgi?id=126747

Patch by Alex Christensen <achristensen@webkit.org> on 2014-01-10
Reviewed by Anders Carlsson.

  • platform/network/ResourceHandle.cpp:

Include NotImplemented.h for all platforms.

8:19 AM Changeset in webkit [161634] by andersca@apple.com
  • 9 edits in trunk/Source/WebCore

Convert some for loops over to range-based for
https://bugs.webkit.org/show_bug.cgi?id=126752

Reviewed by Antti Koivisto.

  • inspector/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::buildArrayForApplicationCacheResources):

  • loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::clearStorageID):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::clearStorageID):

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::fillResourceList):

  • loader/appcache/ApplicationCacheResource.cpp:

(WebCore::ApplicationCacheResource::estimatedSizeInStorage):

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::ApplicationCacheStorage::cacheGroupForURL):

  • loader/archive/ArchiveFactory.cpp:

(WebCore::ArchiveFactory::registerKnownArchiveMIMETypes):

  • page/animation/AnimationController.cpp:

(WebCore::AnimationControllerPrivate::styleAvailable):
(WebCore::AnimationControllerPrivate::startTimeResponse):

7:40 AM Changeset in webkit [161633] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Tighten up two functions in the inspector code
https://bugs.webkit.org/show_bug.cgi?id=126751

Reviewed by Antti Koivisto.

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::frameStartedLoadingImpl):
(WebCore::InspectorInstrumentation::frameStoppedLoadingImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::frameStartedLoading):
(WebCore::InspectorInstrumentation::frameStoppedLoading):

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::frameStartedLoading):
(WebCore::InspectorPageAgent::frameStoppedLoading):

  • inspector/InspectorPageAgent.h:
6:30 AM Changeset in webkit [161632] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Add missing function stub in InspectorFrontendHostStub.js
https://bugs.webkit.org/show_bug.cgi?id=126745

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-10
Reviewed by Timothy Hatcher.

  • UserInterface/InspectorFrontendHostStub.js:

(.WebInspector.InspectorFrontendHostStub.prototype.debuggableType):
The function debuggableType() was added to InspectorFrontendHost.idl and InspectorFrontendHost.cpp
in r160887, but not to InspectorFrontendHostStub.js.

4:47 AM Changeset in webkit [161631] by mihnea@adobe.com
  • 5 edits in trunk/LayoutTests

[CSSRegions] Disable accelerated compositing for fixed elements in regions tests
https://bugs.webkit.org/show_bug.cgi?id=126743

Reviewed by Dirk Schulze.

Once we enable the support of accelerated compositing for fixed positioned elements in regions
in https://bugs.webkit.org/show_bug.cgi?id=125144, those tests will be added into compositing/regions as well.

  • fast/regions/fixed-inside-fixed-in-named-flow-expected.html:
  • fast/regions/fixed-inside-fixed-in-named-flow.html:
  • fast/regions/fixed-pos-elem-in-region-expected.html:
  • fast/regions/fixed-pos-elem-in-region.html:
4:33 AM Changeset in webkit [161630] by Antti Koivisto
  • 3 edits
    2 adds in trunk

Crash when mutating SVG text with transform
https://bugs.webkit.org/show_bug.cgi?id=126744

Reviewed by Dirk Schulze.

Source/WebCore:

Test: svg/custom/mutation-text-transform-crash.html

Text-transform property triggers subtreeTextDidChange when an SVG text renderer is
being added to the render tree. The function assumes the child is already fully in the tree
but in this case we are still in middle of adding it.

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::subtreeTextDidChange):

Bail out if the changed RenderSVGInlineText can't be found from m_layoutAttributes.
This means that subtreeChildWasAdded hasn't been invoked yet for it and there is nothing
to update. The required updates will happen in subtreeChildWasAdded.

LayoutTests:

  • svg/custom/mutation-text-transform-crash-expected.txt: Added.
  • svg/custom/mutation-text-transform-crash.html: Added.
4:03 AM Changeset in webkit [161629] by commit-queue@webkit.org
  • 4 edits
    7 adds in trunk

[SVG] Accept HTML and MathML namespaces as valid requiredExtensions
https://bugs.webkit.org/show_bug.cgi?id=88188

Patch by Frédéric Wang <fred.wang@free.fr> on 2014-01-10
Reviewed by Dirk Schulze.

Source/WebCore:

When HTML and MathML are used as foreign objects of an SVG image, it is
important for Web authors to be able to specify a fallback content for
SVG-only readers or browsers without MathML support. We rely on the
requiredExtensions for that purpose and we use the XHTML/MathML
namespaces as suggested in SVG Tiny 1.2 and implemented in Gecko.

Tests: svg/custom/conditional-processing-1.svg

svg/custom/conditional-processing-2.html
svg/dom/SVGTests.html

  • svg/SVGSwitchElement.cpp: Remove an incorrect FIXME comment and replace it with a reference to bug 74749.

(WebCore::SVGSwitchElement::childShouldCreateRenderer):

  • svg/SVGTests.cpp: Check if the list of required extensions contains only the XHTML/MathML namespaces.

(WebCore::SVGTests::hasExtension):
(WebCore::SVGTests::isValid):

LayoutTests:

conditional-processing-1 verifies that indeed a renderer object is only
created for the first "valid" SVG element of a <switch>, contrary to
what an incorrect FIXME comment said. conditional-processing-2 verifies
that the <switch> takes into account XHTML and MathML namespaces in the
requiredExtensions attribute to decide which SVG element is "valid".
SVGTests.html verifies the SVGTests interface of SVG DOM: three
SVGStringList attributes (already tested in svg/dom/SVGStringList.html)
and the hasExtension() function.

  • svg/custom/conditional-processing-1-expected.txt: Added.
  • svg/custom/conditional-processing-1.svg: Added.
  • svg/custom/conditional-processing-2-expected.txt: Added.
  • svg/custom/conditional-processing-2.html: Added.
  • svg/dom/SVGTests-expected.txt: Added.
  • svg/dom/SVGTests.html: Added.
  • svg/dom/script-tests/SVGTests.js: Added.
3:30 AM Changeset in webkit [161628] by commit-queue@webkit.org
  • 18 edits
    15 adds in trunk

Add support for blendmode to Core Animation layer.
Patch by Rik Cabanier, Dean Jackson and Mihai Tica.

https://bugs.webkit.org/show_bug.cgi?id=99200

Patch by Mihai Tica <mitica@adobe.com> on 2014-01-10
Reviewed by Dirk Schulze.

Source/WebCore:

Tests: css3/compositing/blend-mode-layers.html

css3/compositing/blend-mode-overflow.html
css3/compositing/blend-mode-reflection.html
css3/compositing/blend-mode-should-not-have-compositing-layer.html
css3/compositing/blend-mode-simple.html

  • WebCore.exp.in: export PlatformCALayer::setBlendMode for WebKit::PlatformCALayerRemote
  • WebCore.xcodeproj/project.pbxproj: Add PlatformCAFiltersMac.h
  • platform/graphics/GraphicsLayer.cpp: add blendMode member

(WebCore::GraphicsLayer::GraphicsLayer):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::blendMode):
(WebCore::GraphicsLayer::setBlendMode):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setBlendMode):
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers): add call to updateBlendMode()
(WebCore::GraphicsLayerCA::updateBlendMode):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/PlatformCAFilters.h:
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/mac/PlatformCAFiltersMac.h: Added.
  • platform/graphics/ca/mac/PlatformCAFiltersMac.mm:

(PlatformCAFilters::setBlendingFiltersOnLayer): set a compositing CAFilter on CALayer

  • platform/graphics/ca/mac/PlatformCALayerMac.mm:

(PlatformCALayer::setBlendMode): call to PlatformCAFilters::setBlendingFiltersOnLayer

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore::RenderLayerBacking::updateBlendMode):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::setBlendMode):

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::CompositingState::CompositingState): add m_subtreeHasBlending member
(WebCore::RenderLayerCompositor::computeCompositingRequirements): promote layer if subtree has blending
(WebCore::RenderLayerCompositor::reasonsForCompositing):
(WebCore::RenderLayerCompositor::logReasonsForCompositing): log blending reason
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason): add blending reason

  • rendering/RenderLayerCompositor.h:

LayoutTests:

  • css3/compositing/blend-mode-layers.html: Added.
  • css3/compositing/blend-mode-overflow-expected.txt: Added.
  • css3/compositing/blend-mode-overflow.html: Added.
  • css3/compositing/blend-mode-reflection.html: Added.
  • css3/compositing/blend-mode-should-not-have-compositing-layer-expected.txt: Added.
  • css3/compositing/blend-mode-should-not-have-compositing-layer.html: Added.
  • css3/compositing/blend-mode-simple.html: Added.
  • css3/compositing/should-have-compositing-layer-expected.txt:
  • platform/efl/TestExpectations: Efl doesn't support blend modes at the moment.
  • platform/mac/css3/compositing/blend-mode-layers-expected.png: Added.
  • platform/mac/css3/compositing/blend-mode-layers-expected.txt: Added.
  • platform/mac/css3/compositing/blend-mode-overflow-expected.png: Added.
  • platform/mac/css3/compositing/blend-mode-reflection-expected.png: Added.
  • platform/mac/css3/compositing/blend-mode-reflection-expected.txt: Added.
  • platform/mac/css3/compositing/blend-mode-simple-expected.png: Added.
  • platform/mac/css3/compositing/blend-mode-simple-expected.txt: Added.
3:17 AM Changeset in webkit [161627] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

[EFL] Enable the DFG_JIT on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=126742

Patch by Hunseop Jeong <Hunseop Jeong> on 2014-01-10
Reviewed by Gyuyoung Kim.

Turn on ENABLE_DFG_JIT on ARMv7 for EFL.

  • wtf/Platform.h:
2:38 AM Changeset in webkit [161626] by abucur@adobe.com
  • 8 edits
    10 adds in trunk

[CSS Regions] Implement visual overflow computation for inline elements
https://bugs.webkit.org/show_bug.cgi?id=125291

Reviewed by David Hyatt.

Source/WebCore:

The patch implements visual overflow computation for inline elements per region. The algorithm
uses the container region of each root line box to determine the lines in a region generated by
a RenderInline. The overflow of a RenderInline inside a region is the smallest rectangle that fits
all the line boxes belonging to that region.

The patch also correctly flips for writing mode the overflow of a renderer before clipping with it.

Tests: fast/regions/overflow-in-variable-width-regions-inline-bt.html

fast/regions/overflow-in-variable-width-regions-inline-continuation.html
fast/regions/overflow-in-variable-width-regions-inline-lr.html
fast/regions/overflow-in-variable-width-regions-inline-rl.html
fast/regions/overflow-in-variable-width-regions-inline.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::objectShouldPaintInFlowRegion):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::updateAlwaysCreateLineBoxes): Always create line boxes for RenderInline
(WebCore::RenderInline::linesVisualOverflowBoundingBoxInRegion):

  • rendering/RenderInline.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::visualOverflowRectForBox):
(WebCore::RenderRegion::visualOverflowRectForBoxForPropagation):

  • rendering/RenderRegion.h:

LayoutTests:

Tests for inline elements overflow correct painting inside regions.

  • fast/regions/overflow-in-variable-width-regions-inline-bt-expected.html: Added.
  • fast/regions/overflow-in-variable-width-regions-inline-bt.html: Added.
  • fast/regions/overflow-in-variable-width-regions-inline-continuation-expected.html: Added.
  • fast/regions/overflow-in-variable-width-regions-inline-continuation.html: Added.
  • fast/regions/overflow-in-variable-width-regions-inline-expected.html: Added.
  • fast/regions/overflow-in-variable-width-regions-inline-lr-expected.html: Added.
  • fast/regions/overflow-in-variable-width-regions-inline-lr.html: Added.
  • fast/regions/overflow-in-variable-width-regions-inline-rl-expected.html: Added.
  • fast/regions/overflow-in-variable-width-regions-inline-rl.html: Added.
  • fast/regions/overflow-in-variable-width-regions-inline.html: Added.
1:11 AM Changeset in webkit [161625] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

Implement NetworkResourceLoader::receivedCancellation
https://bugs.webkit.org/show_bug.cgi?id=126129

Reviewed Alexey Proskuryakov.

Implement ResourceHandleClient::receivedCancellation() in the
network process to cancel the load when cancellation is received
from the authentication manager like the web process does.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::receivedCancellation): Cancel the load.

  • NetworkProcess/NetworkResourceLoader.h:
12:00 AM Changeset in webkit [161624] by jinwoo7.song@samsung.com
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] Add APIs for setting and getting the default text encoding name
https://bugs.webkit.org/show_bug.cgi?id=126736

Reviewed by Gyuyoung Kim.

Add APIs to set and get the default text encoding name.

  • UIProcess/API/efl/ewk_settings.cpp:

(ewk_settings_default_text_encoding_name_get):
(ewk_settings_default_text_encoding_name_set):

  • UIProcess/API/efl/ewk_settings.h:
  • UIProcess/API/efl/tests/test_ewk2_settings.cpp:

(TEST_F):

Note: See TracTimeline for information about the timeline view.