Timeline



Jan 19, 2014:

11:25 PM Changeset in webkit [162305] by jinwoo7.song@samsung.com
  • 2 edits in trunk/Source/WebCore

Use unsigned type for the size of CSSParserValueList
​https://bugs.webkit.org/show_bug.cgi?id=127211

Reviewed by Andreas Kling.

  • css/CSSParser.cpp: Changed variable type from int to unsigned.

(WebCore::CSSParser::parseValue):

11:03 PM Changeset in webkit [162304] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebKit2

Unreviewed GTK build fix after r162276.

Updating the WorkQueue implementation to use std::function and std::chrono.

  • Platform/WorkQueue.h:
  • Platform/gtk/WorkQueueGtk.cpp:

(WorkQueue::dispatchOnSource):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):

10:44 PM Changeset in webkit [162303] by ryuan.choi@samsung.com
  • 8 edits in trunk

[EFL][WK1] Remove and refactor the APIs which use single and base keyword
​https://bugs.webkit.org/show_bug.cgi?id=127214

Reviewed by Gyuyoung Kim.

Source/WebKit/efl:

Since removed ewk_vie_tiled, we don't need to use single or base in the API name.
Removed them and clean up the code.

  • ewk/ewk_view.cpp:

(ewk_view_smart_set):
(_ewk_view_smart_class_new):
(ewk_view_add):

  • ewk/ewk_view.h:
  • ewk/ewk_view_private.h:

Removed the class names and macro to distinguish single or tiled.

  • tests/UnitTestUtils/EWKTestView.cpp:

(EWKUnitTests::EWKTestView::init):

Tools:

Followed the changes of API.

  • DumpRenderTree/efl/DumpRenderTreeView.cpp:

(drtViewAdd):

  • EWebLauncher/main.c:

(windowCreate):

10:34 PM Changeset in webkit [162302] by eunmi15.lee@samsung.com
  • 2 edits in trunk/Tools

[EFL][WK2] Add touch events option to MiniBrowser.
​https://bugs.webkit.org/show_bug.cgi?id=127262

Reviewed by Gyuyoung Kim.

As a default, touch events are disabled and mouse events are enabled.
If touch events option sets to true, touch events are enabled and mouse
events are disabled.

  • MiniBrowser/efl/main.c:

(window_create):
(elm_main):

8:42 PM Changeset in webkit [162301] by jinwoo7.song@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed debug build fix on EFL port after r162300.

  • Platform/efl/DispatchQueueWorkItemEfl.h:

(TimerWorkItem::create):

8:13 PM Changeset in webkit [162300] by jinwoo7.song@samsung.com
  • 4 edits in trunk/Source/WebKit2

[EFL][WK2] build fix after r162276
​https://bugs.webkit.org/show_bug.cgi?id=127259

Reviewed by Anders Carlsson.

  • Platform/efl/DispatchQueueEfl.cpp:

(DispatchQueue::performTimerWork):
(DispatchQueue::getNextTimeOut):

  • Platform/efl/DispatchQueueWorkItemEfl.h:

(WorkItem::create):
(WorkItem::WorkItem):
(TimerWorkItem::create):
(TimerWorkItem::TimerWorkItem):

  • Platform/efl/WorkQueueEfl.cpp:

(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):

5:26 PM Changeset in webkit [162299] by fpizlo@apple.com
  • 6 edits
    2 adds in branches/jsCStack/Source/JavaScriptCore

FTL should ascribe range meta-data when loading array.length
​https://bugs.webkit.org/show_bug.cgi?id=126543

Not yet reviewed.

The main thing this accomplishes is we now have Output::load32NonNegative() which is
a 32-bit integer load that promises that the value is not negative. We then use that
for all length loads.

But underneath that, we have the notion of ValueRange, which is a simplified
encapsulation of LLVM "range" metadata.

I considered making the range meta-data part of AbstractHeap. It would make sense
there. But considering that we just use this for basically one thing (the length), it
feels like conflating this with the AbstractHeap would result in some
overengineering. We should revisit this if we ever have other ranges.

(JSC::FTL::CommonValues::CommonValues):

  • ftl/FTLCommonValues.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileGetArrayLength):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compileStringCharAt):
(JSC::FTL::LowerDFGToLLVM::compileStringCharCodeAt):
(JSC::FTL::LowerDFGToLLVM::compileSwitch):
(JSC::FTL::LowerDFGToLLVM::typedArrayLength):
(JSC::FTL::LowerDFGToLLVM::boolify):
(JSC::FTL::LowerDFGToLLVM::contiguousPutByValOutOfBounds):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::ascribeRange):
(JSC::FTL::Output::nonNegative32):
(JSC::FTL::Output::load32NonNegative):

  • ftl/FTLValueRange.cpp: Added.

(JSC::FTL::ValueRange::decorateInstruction):

  • ftl/FTLValueRange.h: Added.

(JSC::FTL::ValueRange::ValueRange):
(JSC::FTL::ValueRange::begin):
(JSC::FTL::ValueRange::end):

5:18 PM Changeset in webkit [162298] by ljaehun.lim@samsung.com
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r162293

Fix debug build.

[ 13%] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/html/parser/HTMLTreeBuilder.cpp.o
/source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp: In member function ‘void WebCore::HTMLTreeBuilder::processStartTagForInTable(WebCore::AtomicHTMLToken*)’:
/source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: error: no match for ‘operator!’ in ‘!(WebCore::HTMLTreeBuilder::InsertionMode)12’
/source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: note: candidate is:
/source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: note: operator!(bool) <built-in>
/source/WebKit/Source/WebCore/html/parser/HTMLTreeBuilder.cpp:1037:40: note: no known conversion for argument 1 from ‘WebCore::HTMLTreeBuilder::InsertionMode’ to ‘bool’
make[2]: * [Source/WebCore/CMakeFiles/WebCore.dir/html/parser/HTMLTreeBuilder.cpp.o] Error 1
make[1]: * [Source/WebCore/CMakeFiles/WebCore.dir/all] Error 2
make: * [all] Error 2

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInTable): Fix ASSERT.

4:07 PM Changeset in webkit [162297] by Alan Bujtas
  • 3 edits in trunk/Tools

Pretty print LayoutUnit, LayoutPoint, and LayoutSize in lldb and gdb.
​https://bugs.webkit.org/show_bug.cgi?id=126080

Reviewed by Sam Weinig.

This changes the output of printing LayoutUnits to be in px but it also
preserves the original LayoutUnit value.

This will lead to lldb output like: (and it works even when subpixel is disabled)

(const WebCore::LayoutRect) $0 = {

m_location = { x = 2.25px (144), y = 1px (64)}
m_size = { width = 13.75px (880), height = 20px (1280) }

And gdb output like:

m_frameRect = {

m_location = LayoutPoint(0px (0), 0px(0)),
m_size = LayoutSize(8px (512), 5px (320))

}

This patch is based on patch by Bem Jones-Bey and for Blink by ​cbiesinger@chromium.org.

  • gdb/webkit.py:

(WebCoreLayoutUnitPrinter):
(WebCoreLayoutUnitPrinter.init):
(WebCoreLayoutUnitPrinter.to_string):
(WebCoreLayoutSizePrinter):
(WebCoreLayoutSizePrinter.init):
(WebCoreLayoutSizePrinter.to_string):
(WebCoreLayoutPointPrinter):
(WebCoreLayoutPointPrinter.init):
(WebCoreLayoutPointPrinter.to_string):
(add_pretty_printers):

  • lldb/lldb_webkit.py:

(lldb_init_module):
(WebCoreLayoutUnit_SummaryProvider):
(WebCoreLayoutSize_SummaryProvider):
(WebCoreLayoutPoint_SummaryProvider):
(WebCoreLayoutUnitProvider):
(WebCoreLayoutUnitProvider.init):
(WebCoreLayoutUnitProvider.to_string):
(WebCoreLayoutSizeProvider):
(WebCoreLayoutSizeProvider.init):
(WebCoreLayoutSizeProvider.get_width):
(WebCoreLayoutSizeProvider.get_height):
(WebCoreLayoutPointProvider):
(WebCoreLayoutPointProvider.init):
(WebCoreLayoutPointProvider.get_x):
(WebCoreLayoutPointProvider.get_y):

12:37 PM Changeset in webkit [162296] by andersca@apple.com
  • 17 edits in trunk/Source/WebCore

Stop using MutexTryLocker in WebCore
​https://bugs.webkit.org/show_bug.cgi?id=127254

Reviewed by Andreas Kling.

Instead use std::mutex and std::unique_lock with the std::try_to_lock constructor.

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::process):
(WebCore::AudioBufferSourceNode::setBuffer):

  • Modules/webaudio/AudioBufferSourceNode.h:
  • Modules/webaudio/AudioParamTimeline.cpp:

(WebCore::AudioParamTimeline::insertEvent):
(WebCore::AudioParamTimeline::cancelScheduledValues):
(WebCore::AudioParamTimeline::valueForContextTime):
(WebCore::AudioParamTimeline::valuesForTimeRange):
(WebCore::AudioParamTimeline::valuesForTimeRangeImpl):

  • Modules/webaudio/AudioParamTimeline.h:
  • Modules/webaudio/ConvolverNode.cpp:

(WebCore::ConvolverNode::process):
(WebCore::ConvolverNode::reset):
(WebCore::ConvolverNode::setBuffer):

  • Modules/webaudio/ConvolverNode.h:
  • Modules/webaudio/MediaElementAudioSourceNode.cpp:

(WebCore::MediaElementAudioSourceNode::setFormat):
(WebCore::MediaElementAudioSourceNode::process):
(WebCore::MediaElementAudioSourceNode::lock):
(WebCore::MediaElementAudioSourceNode::unlock):

  • Modules/webaudio/MediaElementAudioSourceNode.h:
  • Modules/webaudio/MediaStreamAudioSourceNode.cpp:

(WebCore::MediaStreamAudioSourceNode::setFormat):
(WebCore::MediaStreamAudioSourceNode::process):

  • Modules/webaudio/MediaStreamAudioSourceNode.h:
  • Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::process):
(WebCore::OscillatorNode::setPeriodicWave):

  • Modules/webaudio/OscillatorNode.h:
  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::process):
(WebCore::PannerNode::setPanningModel):

  • Modules/webaudio/PannerNode.h:
  • Modules/webaudio/WaveShaperProcessor.cpp:

(WebCore::WaveShaperProcessor::setCurve):
(WebCore::WaveShaperProcessor::setOversample):
(WebCore::WaveShaperProcessor::process):

  • Modules/webaudio/WaveShaperProcessor.h:
11:13 AM Changeset in webkit [162295] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore

Does not build with SVG disabled
​https://bugs.webkit.org/show_bug.cgi?id=127248

Reviewed by Sam Weinig.

Add missing #if ENABLE(SVG) guard.

  • dom/ElementData.h:
11:00 AM Changeset in webkit [162294] by Alan Bujtas
  • 3 edits in trunk/LayoutTests

Unreviewed Apple Windows port gardering.

A few more missing newlines.

  • platform/win/svg/batik/masking/maskRegions-expected.txt:
  • platform/win/svg/batik/text/textPosition-expected.txt:
11:00 AM Changeset in webkit [162293] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Use a strong enum for HTMLTreeBuilder::InsertionMode
​https://bugs.webkit.org/show_bug.cgi?id=127252

Reviewed by Antti Koivisto.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::constructTree):
(WebCore::HTMLTreeBuilder::processDoctypeToken):
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processTemplateStartTag):
(WebCore::HTMLTreeBuilder::processColgroupEndTagForInColumnGroup):
(WebCore::HTMLTreeBuilder::closeTheCell):
(WebCore::HTMLTreeBuilder::processStartTagForInTable):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processBodyEndTagForInBody):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTagForInTableBody):
(WebCore::HTMLTreeBuilder::processEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTagForInCell):
(WebCore::HTMLTreeBuilder::processCaptionEndTagForInCaption):
(WebCore::HTMLTreeBuilder::processTrEndTagForInRow):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processComment):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
(WebCore::HTMLTreeBuilder::processEndOfFile):
(WebCore::HTMLTreeBuilder::defaultForInitial):
(WebCore::HTMLTreeBuilder::defaultForBeforeHTML):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):
(WebCore::HTMLTreeBuilder::processGenericRCDATAStartTag):
(WebCore::HTMLTreeBuilder::processGenericRawTextStartTag):
(WebCore::HTMLTreeBuilder::processScriptStartTag):

  • html/parser/HTMLTreeBuilder.h:
10:42 AM Changeset in webkit [162292] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Convert LoaderRunLoopCF.cpp and WebCoreThreadRun.cpp over to modern threading primitives
​https://bugs.webkit.org/show_bug.cgi?id=127251

Reviewed by Antti Koivisto.

Also add a condition to the loaderRunLoop() function to protect against spurious wake-ups.

  • platform/ios/wak/WebCoreThreadRun.cpp:
  • platform/network/cf/LoaderRunLoopCF.cpp:

(WebCore::loaderRunLoopMutex):
(WebCore::loaderRunLoopConditionVariable):
(WebCore::runLoaderThread):
(WebCore::loaderRunLoop):

10:20 AM Changeset in webkit [162291] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Modernize ReverbConvolver
​https://bugs.webkit.org/show_bug.cgi?id=127250

Reviewed by Andreas Kling.

Use std::unique_ptr instead of OwnPtr and the STL threading primitives instead of the WTF ones.

  • platform/audio/ReverbConvolver.cpp:

(WebCore::ReverbConvolver::ReverbConvolver):
(WebCore::ReverbConvolver::~ReverbConvolver):
(WebCore::ReverbConvolver::backgroundThreadEntry):
(WebCore::ReverbConvolver::process):

  • platform/audio/ReverbConvolver.h:

Jan 18, 2014:

10:53 PM Changeset in webkit [162290] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Rename GestureEventIOS.{cpp,h} to GestureEvent.{cpp,h} to fix the build

InFilesCompiler.pm assumes that <interface name>.h exists for each
interface it processes. We renamed GestureEvent.h to GestureEventIOS.h
but kept the interface named GestureEvent, so a non-existant file was
being referenced by InFilesCompiler.pm (this was hard to detect since
GestureEvent.h still existed in the SDK due to not having submitted
WebKitAdditions recently).

Since we cannot rename the GestureEvent interface, and since there is
no conflicting GestureEvent in open source, we can just rename
GestureEventIOS.{cpp,h} back to GestureEvent.{cpp,h}.

  • dom/ios/TouchEvents.cpp: Updated to include GestureEvent.cpp.
10:47 PM Changeset in webkit [162289] by ap@apple.com
  • 2 edits in trunk/Tools

Add robots.txt to ​http://webkit-queues.appspot.com
​https://bugs.webkit.org/show_bug.cgi?id=127240

  • QueueStatusServer/app.yaml: Added required "upload" attribute for robots.txt.
10:43 PM Changeset in webkit [162288] by ap@apple.com
  • 2 edits
    1 add in trunk/Tools

Add robots.txt to ​http://webkit-queues.appspot.com
​https://bugs.webkit.org/show_bug.cgi?id=127240

Reviewed by Ryosuke Niwa.

  • QueueStatusServer/app.yaml: Added robots.txt as a static file. Updated version.
  • QueueStatusServer/robots.txt: Added.
10:39 PM Changeset in webkit [162287] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Memory leak in JSSubtleCrypto::wrapKey
​https://bugs.webkit.org/show_bug.cgi?id=127241

Reviewed by Sam Weinig.

  • bindings/js/JSSubtleCryptoCustom.cpp: (WebCore::JSSubtleCrypto::wrapKey):

Delete algorithmPtr and parametersPtr that aren't smart pointers because of lambdas.

9:16 PM Changeset in webkit [162286] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the iOS Production build.

  • Configurations/WebCore.xcconfig:
6:32 PM Changeset in webkit [162285] by Alan Bujtas
  • 48 edits in trunk/LayoutTests

Unreviewed Apple Windows port gardering.

Add missing newlines.

  • platform/win/css1/box_properties/margin_right-expected.txt:
  • platform/win/css1/box_properties/padding-expected.txt:
  • platform/win/css1/box_properties/padding_left-expected.txt:
  • platform/win/css1/box_properties/padding_right-expected.txt:
  • platform/win/css1/box_properties/padding_top-expected.txt:
  • platform/win/css1/font_properties/font-expected.txt:
  • platform/win/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/win/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
  • platform/win/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
  • platform/win/css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt:
  • platform/win/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
  • platform/win/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
  • platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
  • platform/win/fast/borders/bidi-012-expected.txt:
  • platform/win/fast/css/empty-pseudo-class-expected.txt:
  • platform/win/fast/css/fieldset-display-row-expected.txt:
  • platform/win/fast/css/first-child-pseudo-class-expected.txt:
  • platform/win/fast/css/last-child-pseudo-class-expected.txt:
  • platform/win/fast/css/only-child-pseudo-class-expected.txt:
  • platform/win/fast/forms/file/file-input-disabled-expected.txt:
  • platform/win/fast/inline/inline-box-background-expected.txt:
  • platform/win/fast/inline/inline-box-background-long-image-expected.txt:
  • platform/win/fast/inline/inline-box-background-repeat-x-expected.txt:
  • platform/win/fast/inline/inline-box-background-repeat-y-expected.txt:
  • platform/win/fast/lists/003-vertical-expected.txt:
  • platform/win/fast/multicol/vertical-rl/float-multicol-expected.txt:
  • platform/win/fast/multicol/vertical-rl/nested-columns-expected.txt:
  • platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/win/svg/batik/filters/feTile-expected.txt:
  • platform/win/svg/batik/masking/maskRegions-expected.txt:
  • platform/win/svg/batik/paints/gradientLimit-expected.txt:
  • platform/win/svg/batik/text/textDecoration-expected.txt:
  • platform/win/svg/batik/text/textEffect-expected.txt:
  • platform/win/svg/batik/text/textLength-expected.txt:
  • platform/win/svg/batik/text/textPosition-expected.txt:
  • platform/win/svg/batik/text/verticalText-expected.txt:
  • platform/win/transforms/2d/hindi-rotated-expected.txt:
5:11 PM Changeset in webkit [162284] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

CodeBlock: Size m_callLinkInfos and m_byValInfos to fit earlier.
<​https://webkit.org/b/127239>

Reviewed by Anders Carlsson.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::setNumberOfByValInfos):
(JSC::CodeBlock::setNumberOfCallLinkInfos):

Use resizeToFit() instead of grow() for these vectors, since
we know the final size here.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::shrinkToFit):

No need to shrink here anymore. We were not even shrinking
m_byValInfo before!

3:59 PM Changeset in webkit [162283] by berto@igalia.com
  • 2 edits in trunk/Tools

Tools/Scripts/test-webkitperl fails: 'tempdir' can't be called as a method
​https://bugs.webkit.org/show_bug.cgi?id=127217

Reviewed by Daniel Bates.

The syntax File::Temp->tempdir() was explicitly made invalid
following <​https://github.com/Perl-Toolchain-Gang/File-Temp/commit/c8920b2161ab6900a09e02b9410e0e4c3d74f565>
which was included in File::Temp v2.30, shipped with Perl v5.18.0.

Use File::Temp::tempdir() instead.

  • Scripts/webkitperl/VCSUtils_unittest/parseDiffWithMockFiles.pl:
3:55 PM Changeset in webkit [162282] by Alan Bujtas
  • 27 edits
    26 adds in trunk/LayoutTests

Unreviewed Apple Windows port gardering.

Rebaseline subpixel layout results.

  • platform/win/TestExpectations:
  • platform/win/css1/box_properties/margin_right-expected.txt: Added.
  • platform/win/css1/box_properties/padding-expected.txt: Added.
  • platform/win/css1/box_properties/padding_left-expected.txt: Added.
  • platform/win/css1/box_properties/padding_right-expected.txt: Added.
  • platform/win/css1/box_properties/padding_top-expected.txt: Added.
  • platform/win/css1/font_properties/font-expected.txt:
  • platform/win/css1/formatting_model/vertical_formatting-expected.txt: Added.
  • platform/win/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt: Added.
  • platform/win/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt: Added.
  • platform/win/css2.1/t0804-c5509-padn-l-00-b-ag-expected.txt: Added.
  • platform/win/css2.1/t0804-c5510-padn-00-b-ag-expected.txt: Added.
  • platform/win/css2.1/t0905-c414-flt-wrap-00-e-expected.txt: Added.
  • platform/win/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
  • platform/win/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
  • platform/win/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
  • platform/win/fast/borders/bidi-012-expected.txt:
  • platform/win/fast/css/empty-pseudo-class-expected.txt: Added.
  • platform/win/fast/css/fieldset-display-row-expected.txt: Added.
  • platform/win/fast/css/first-child-pseudo-class-expected.txt: Added.
  • platform/win/fast/css/last-child-pseudo-class-expected.txt: Added.
  • platform/win/fast/css/only-child-pseudo-class-expected.txt: Added.
  • platform/win/fast/forms/file/file-input-disabled-expected.txt:
  • platform/win/fast/forms/range/slider-mouse-events-expected.txt:
  • platform/win/fast/inline/inline-box-background-expected.txt:
  • platform/win/fast/inline/inline-box-background-long-image-expected.txt:
  • platform/win/fast/inline/inline-box-background-repeat-x-expected.txt:
  • platform/win/fast/inline/inline-box-background-repeat-y-expected.txt:
  • platform/win/fast/lists/003-vertical-expected.txt:
  • platform/win/fast/multicol/vertical-rl/float-multicol-expected.txt:
  • platform/win/fast/multicol/vertical-rl/nested-columns-expected.txt:
  • platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:
  • platform/win/svg/batik/filters/feTile-expected.txt: Added.
  • platform/win/svg/batik/masking/maskRegions-expected.txt: Added.
  • platform/win/svg/batik/paints/gradientLimit-expected.txt:
  • platform/win/svg/batik/text/textDecoration-expected.txt: Added.
  • platform/win/svg/batik/text/textEffect-expected.txt: Added.
  • platform/win/svg/batik/text/textLength-expected.txt: Added.
  • platform/win/svg/batik/text/textPosition-expected.txt: Added.
  • platform/win/svg/batik/text/verticalText-expected.txt: Added.
  • platform/win/transforms/2d/hindi-rotated-expected.txt:
3:35 PM Changeset in webkit [162281] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

CodeBlock: Size m_function{Exprs,Decls} to fit from creation.
<​https://webkit.org/b/127238>

Reviewed by Anders Carlsson.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

Use resizeToFit() instead of grow() for m_functionExprs and
m_functionDecls since we know they will never change size.

(JSC::CodeBlock::shrinkToFit):

No need to shrink them here anymore.

3:31 PM Changeset in webkit [162280] by berto@igalia.com
  • 19 edits in trunk/Source/WebCore

[CodeGeneratorJS] Sort output of StructureFlags and function parameters

​https://bugs.webkit.org/show_bug.cgi?id=127226

Reviewed by Alexey Proskuryakov.

The order of the keys in a hash is undefined and subject to change
between different Perl versions, so we have to sort them to make
sure that the output is always the same.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateParametersCheckExpression):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.h:
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
  • bindings/scripts/test/JS/JSTestEventConstructor.h:
  • bindings/scripts/test/JS/JSTestEventTarget.h:
  • bindings/scripts/test/JS/JSTestException.h:
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
  • bindings/scripts/test/JS/JSTestNamedConstructor.h:
  • bindings/scripts/test/JS/JSTestNode.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/JS/JSTestTypedefs.h:
  • bindings/scripts/test/JS/JSattribute.h:
  • bindings/scripts/test/JS/JSreadonly.h:
3:20 PM Changeset in webkit [162279] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove unused CodeBlock::m_additionalIdentifiers member.
<​https://webkit.org/b/127237>

Reviewed by Anders Carlsson.

  • bytecode/CodeBlock.h:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::shrinkToFit):

Remove m_additionalIdentifiers, nothing uses it.

3:10 PM Changeset in webkit [162278] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove two unused CodeBlock functions.
<​https://webkit.org/b/127235>

Kill copyPostParseDataFrom() and copyPostParseDataFromAlternative()
since they are not used.

Reviewed by Anders Carlsson.

  • bytecode/CodeBlock.cpp:
  • bytecode/CodeBlock.h:
3:09 PM Changeset in webkit [162277] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

CodeBlock: Size m_exceptionHandlers to fit from creation.
<​https://webkit.org/b/127234>

Avoid allocation churn for CodeBlock::m_exceptionHandlers.

Reviewed by Anders Carlsson.

  • bytecode/CodeBlock.h:

Removed unused CodeBlock::allocateHandlers() function.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::CodeBlock):

Use resizeToFit() instead of grow() for m_exceptionHandlers
since we know it's never going to change size.

(JSC::CodeBlock::shrinkToFit):

No need to shrink m_exceptionHandlers here since it's already
the perfect size.

3:00 PM Changeset in webkit [162276] by andersca@apple.com
  • 15 edits in trunk/Source

Replace a couple of uses of WTF::Function with std::function
​https://bugs.webkit.org/show_bug.cgi?id=127218

Reviewed by Andreas Kling.

Source/WebCore:

  • WebCore.exp.in:
  • page/scrolling/ScrollingThread.cpp:

(WebCore::ScrollingThread::dispatch):
(WebCore::ScrollingThread::dispatchBarrier):
(WebCore::ScrollingThread::shared):
(WebCore::ScrollingThread::createThreadIfNeeded):
(WebCore::ScrollingThread::dispatchFunctionsFromScrollingThread):

  • page/scrolling/ScrollingThread.h:
  • page/scrolling/mac/ScrollingThreadMac.mm:

(WebCore::ScrollingThread::initializeRunLoop):

Source/WebKit2:

  • Platform/IPC/mac/ConnectionMac.cpp:

(IPC::createDataAvailableSource):

  • Platform/WorkQueue.h:
  • Platform/mac/WorkQueueMac.cpp:

(WorkQueue::dispatch):
(WorkQueue::dispatchAfter):

  • Shared/ChildProcess.cpp:

(WebKit::didCloseOnConnectionWorkQueue):

  • UIProcess/Storage/LocalStorageDatabase.cpp:

(WebKit::LocalStorageDatabase::scheduleDatabaseUpdate):

  • WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):

2:48 PM Changeset in webkit [162275] by andersca@apple.com
  • 25 edits in trunk/Source/WebCore

Modernize HTML parser code
​https://bugs.webkit.org/show_bug.cgi?id=127236

Reviewed by Andreas Kling.

  • html/parser/AtomicHTMLToken.h:
  • html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::emitRule):

  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::detach):
(WebCore::HTMLDocumentParser::stopParsing):
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLElementStack::ElementRecord::ElementRecord):
(WebCore::HTMLElementStack::insertAbove):
(WebCore::HTMLElementStack::pushCommon):

  • html/parser/HTMLElementStack.h:

(WebCore::HTMLElementStack::ElementRecord::releaseNext):
(WebCore::HTMLElementStack::ElementRecord::setNext):

  • html/parser/HTMLMetaCharsetParser.cpp:

(WebCore::HTMLMetaCharsetParser::HTMLMetaCharsetParser):

  • html/parser/HTMLMetaCharsetParser.h:
  • html/parser/HTMLParserScheduler.h:
  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
(WebCore::TokenPreloadScanner::scan):
(WebCore::HTMLPreloadScanner::HTMLPreloadScanner):

  • html/parser/HTMLPreloadScanner.h:
  • html/parser/HTMLResourcePreloader.cpp:

(WebCore::HTMLResourcePreloader::takeAndPreload):
(WebCore::HTMLResourcePreloader::preload):

  • html/parser/HTMLResourcePreloader.h:

(WebCore::PreloadRequest::PreloadRequest):

  • html/parser/HTMLScriptRunner.h:
  • html/parser/HTMLToken.h:

(WebCore::HTMLToken::beginDOCTYPE):
(WebCore::HTMLToken::releaseDoctypeData):

  • html/parser/HTMLTokenizer.h:
  • html/parser/HTMLTreeBuilder.h:
  • html/parser/HTMLViewSourceParser.cpp:

(WebCore::HTMLViewSourceParser::HTMLViewSourceParser):

  • html/parser/HTMLViewSourceParser.h:
  • html/parser/XSSAuditor.cpp:

(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):

  • html/parser/XSSAuditor.h:
  • html/parser/XSSAuditorDelegate.h:

(WebCore::XSSInfo::XSSInfo):

  • loader/TextResourceDecoder.cpp:

(WebCore::TextResourceDecoder::checkForHeadCharset):
(WebCore::TextResourceDecoder::checkForMetaCharset):

  • loader/TextResourceDecoder.h:
2:17 PM Changeset in webkit [162274] by benjamin@webkit.org
  • 8 edits in trunk/Source/WebCore

Make ElementData JIT friendly
​https://bugs.webkit.org/show_bug.cgi?id=127209

Reviewed by Geoffrey Garen.

The offsets of ElementData's flags were not accessible by the JIT. This patch
refactor ElementData to use explicit flags so that they can be used from
the code generators.

  • dom/Element.cpp:

(WebCore::Element::synchronizeAllAttributes):
(WebCore::Element::synchronizeAttribute):
(WebCore::Element::attributeChanged):
(WebCore::Element::removeAttribute):

  • dom/ElementData.cpp:

(WebCore::ElementData::destroy):
(WebCore::ElementData::ElementData):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::ShareableElementData::~ShareableElementData):
(WebCore::ElementData::arraySizeAndFlagsFromOther):

  • dom/ElementData.h:

(WebCore::ElementData::hasName):
(WebCore::ElementData::isUnique):
(WebCore::ElementData::updateFlag):
(WebCore::ElementData::arraySize):
(WebCore::ElementData::setHasNameAttribute):
(WebCore::ElementData::styleAttributeIsDirty):
(WebCore::ElementData::setStyleAttributeIsDirty):
(WebCore::ElementData::presentationAttributeStyleIsDirty):
(WebCore::ElementData::setPresentationAttributeStyleIsDirty):
(WebCore::ElementData::animatedSVGAttributesAreDirty):
(WebCore::ElementData::setAnimatedSVGAttributesAreDirty):
(WebCore::ElementData::length):
(WebCore::ElementData::attributeBase):
(WebCore::ElementData::presentationAttributeStyle):

  • dom/StyledElement.cpp:

(WebCore::StyledElement::synchronizeStyleAttributeInternal):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::styleAttributeChanged):
(WebCore::StyledElement::inlineStyleChanged):
(WebCore::StyledElement::rebuildPresentationAttributeStyle):

  • dom/StyledElement.h:

(WebCore::StyledElement::invalidateStyleAttribute):
(WebCore::StyledElement::presentationAttributeStyle):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::synchronizeAnimatedSVGAttribute):

  • svg/SVGElement.h:

(WebCore::SVGElement::invalidateSVGAttributes):

1:24 PM Changeset in webkit [162273] by Alan Bujtas
  • 4 edits in trunk

Subpixel layout: IntRect::infiniteRect() overflows when subpixel layout is enabled.
​https://bugs.webkit.org/show_bug.cgi?id=126899

Reviewed by Tim Horton.

Use LayoutUnits when setting the infinite values on IntRect::infiniteRect() to ensure
it won't overflow later when the IntRect gets converted to LayoutRect.

Source/WebCore:

Covered by existing tests.

  • platform/graphics/IntRect.h:

(WebCore::IntRect::infiniteRect):

LayoutTests:

  • platform/mac/TestExpectations: Unskipping svg test (failed with subpixel on)
1:15 PM Changeset in webkit [162272] by andersca@apple.com
  • 7 edits
    37 deletes in trunk

Remove support for the viewsource attribute
​https://bugs.webkit.org/show_bug.cgi?id=127232

Reviewed by Andreas Kling.

Source/WebCore:

The 'viewsource' attribute on frames is nonstandard, not used by anyone (the inspector has
its own syntax highlighting) and not audited.

This patch removes parsing of the viewsource attribute and the associated tests. A subsequent
patch will remove the code as well.

  • html/HTMLFrameElementBase.cpp:

(WebCore::HTMLFrameElementBase::parseAttribute):

Source/WTF:

  • wtf/FeatureDefines.h:

LayoutTests:

  • .gitattributes:
  • fast/frames/resources/viewsource-fake-image-file.png: Removed.
  • fast/frames/resources/viewsource-frame-1.html: Removed.
  • fast/frames/resources/viewsource-frame-2.html: Removed.
  • fast/frames/resources/viewsource-frame-3.html: Removed.
  • fast/frames/resources/viewsource-frame-4.html: Removed.
  • fast/frames/resources/viewsource-frame-5.html: Removed.
  • fast/frames/resources/viewsource-frame-unfinished-script.html: Removed.
  • fast/frames/resources/viewsource-frame-unfinished-textarea.html: Removed.
  • fast/frames/viewsource-attribute.html: Removed.
  • fast/frames/viewsource-empty-attribute-value-expected.txt: Removed.
  • fast/frames/viewsource-empty-attribute-value.html: Removed.
  • fast/frames/viewsource-linebreak-expected.txt: Removed.
  • fast/frames/viewsource-linebreak.html: Removed.
  • fast/frames/viewsource-link-on-href-value-expected.txt: Removed.
  • fast/frames/viewsource-link-on-href-value.html: Removed.
  • fast/frames/viewsource-on-image-file.html: Removed.
  • fast/frames/viewsource-plain-text-tags-expected.txt: Removed.
  • fast/frames/viewsource-plain-text-tags.html: Removed.
  • fast/frames/viewsource-unfinished-tags-expected.txt: Removed.
  • fast/frames/viewsource-unfinished-tags.html: Removed.
  • fast/frames/viewsource-xml-expected.txt: Removed.
  • fast/frames/viewsource-xml.html: Removed.
  • http/tests/security/resources/view-source-no-refresh.php: Removed.
  • http/tests/security/view-source-javascript-url-in-document-expected.txt: Removed.
  • http/tests/security/view-source-javascript-url-in-document.html: Removed.
  • http/tests/security/view-source-no-javascript-url-expected.txt: Removed.
  • http/tests/security/view-source-no-javascript-url.html: Removed.
  • http/tests/security/view-source-no-refresh-expected.txt: Removed.
  • http/tests/security/view-source-no-refresh.html: Removed.
  • platform/efl/fast/frames/viewsource-attribute-expected.png: Removed.
  • platform/efl/fast/frames/viewsource-attribute-expected.txt: Removed.
  • platform/efl/fast/frames/viewsource-on-image-file-expected.png: Removed.
  • platform/efl/fast/frames/viewsource-on-image-file-expected.txt: Removed.
  • platform/mac/fast/frames/viewsource-attribute-expected.png: Removed.
  • platform/mac/fast/frames/viewsource-attribute-expected.txt: Removed.
  • platform/mac/fast/frames/viewsource-on-image-file-expected.png: Removed.
  • platform/mac/fast/frames/viewsource-on-image-file-expected.txt: Removed.
  • platform/win/TestExpectations:
1:14 PM Changeset in webkit [162271] by commit-queue@webkit.org
  • 31 edits
    2 copies in trunk/Source/WebKit2

Flesh out session APIs (still not enabled at API level).
​https://bugs.webkit.org/show_bug.cgi?id=126918

Patch by Martin Hock <​mhock@apple.com> on 2014-01-18
Reviewed by Alexey Proskuryakov.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::storageSession):
(WebKit::NetworkConnectionToWebProcess::startDownload):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
(WebKit::NetworkConnectionToWebProcess::getRawCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookie):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::ensurePrivateBrowsingSession):
(WebKit::NetworkProcess::destroyPrivateBrowsingSession):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/RemoteNetworkingContext.h:
  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::storageSession):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):

  • NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:

(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):

  • Shared/SessionTracker.cpp: Copied from Source/WebKit2/UIProcess/APISession.cpp.

(WebKit::sessionMap):
(WebKit::identifierBase):
(WebKit::SessionTracker::getSessionMap):
(WebKit::SessionTracker::getIdentifierBase):
(WebKit::SessionTracker::session):
(WebKit::SessionTracker::destroySession):
(WebKit::SessionTracker::setIdentifierBase):

  • Shared/SessionTracker.h: Copied from Source/WebKit2/UIProcess/APISession.h.

(WebKit::SessionTracker::isEphemeralID):

  • Shared/mac/CookieStorageShim.cpp:

(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):

  • UIProcess/APISession.cpp:

(API::generateID):
(API::Session::defaultSession):
(API::Session::legacyPrivateSession):
(API::Session::Session):
(API::Session::create):
(API::Session::isEphemeral):
(API::Session::getID):

  • UIProcess/APISession.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):

  • UIProcess/WebContext.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::sessionID):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

  • UIProcess/WebProcessProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPrivateBrowsingEnabled):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::legacySessionID):
(WebKit::WebPlatformStrategies::cookiesForDOM):
(WebKit::WebPlatformStrategies::setCookiesFromDOM):
(WebKit::WebPlatformStrategies::cookiesEnabled):
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
(WebKit::WebPlatformStrategies::getRawCookies):
(WebKit::WebPlatformStrategies::deleteCookie):

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::storageSession):

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::ensurePrivateBrowsingSession):
(WebKit::WebProcess::destroyPrivateBrowsingSession):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
1:11 PM Changeset in webkit [162270] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Add a hasBreakpointFlag arg to the op_debug bytecode.
​https://bugs.webkit.org/show_bug.cgi?id=127230.

Reviewed by Geoffrey Garen.

This is in anticipation of upcoming changes to support bytecode level
breakpoints. This patch adds the flag to the op_debug bytecode and
initializes it, but does not use it yet.

  • bytecode/Opcode.h:

(JSC::padOpcodeName):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitDebugHook):

  • llint/LowLevelInterpreter.asm:
12:35 PM Changeset in webkit [162269] by andersca@apple.com
  • 6 edits in trunk/Source/WebCore

XMLTreeViewer shouldn't use the view source mode
​https://bugs.webkit.org/show_bug.cgi?id=127229

Reviewed by Andreas Kling.

Add the relevant styles from view-source.css to XMLViewer.css.

  • xml/XMLTreeViewer.cpp:

(WebCore::XMLTreeViewer::transformDocumentToTreeView):

  • xml/XMLViewer.css:

(body):
(.comment):
(.tag):
(.attribute-name):
(.attribute-value):

  • xml/XMLViewer.js:

(createComment):
(createTag):
(createAttribute):

12:32 PM Changeset in webkit [162268] by BJ Burg
  • 5 edits in trunk/Source/WebKit

Another build fix attempt for Windows and EFL WebKit1.

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/efl:

  • ewk/ewk_paint_context.cpp:

(ewk_paint_context_paint_contents):

  • ewk/ewk_view.cpp:

(_ewk_view_smart_repaints_process):

12:19 PM Changeset in webkit [162267] by BJ Burg
  • 2 edits in trunk/Source/WebKit

Unreviewed build fix attempt for Windows.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
11:41 AM Changeset in webkit [162266] by berto@igalia.com
  • 3 edits in trunk/Source/JavaScriptCore

JavaScriptCore uses PLATFORM(MAC) when it means OS(DARWIN)
​https://bugs.webkit.org/show_bug.cgi?id=99683

Reviewed by Anders Carlsson.

  • jit/ThunkGenerators.cpp:
  • tools/CodeProfile.cpp:

(JSC::symbolName):
(JSC::CodeProfile::sample):

11:16 AM Changeset in webkit [162265] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Remove unused "touchDragDropEnabled" setting.
<​https://webkit.org/b/127227>

Reviewed by Sam Weinig.

  • page/Settings.in:
11:15 AM Changeset in webkit [162264] by BJ Burg
  • 44 edits in trunk/Source

Web Inspector: Page should use std::unique_ptr for InspectorController
​https://bugs.webkit.org/show_bug.cgi?id=127068

Reviewed by Joseph Pecoraro.

Source/WebCore:

Make Page and WorkerGlobalScope keep a std::unique_ptr to InspectorController
and WorkerInspectorController. Store page references and return controller
references where possible.

Convert call sites to use an InspectorController reference.
Convert instantiations of InspectorFrontendClient to use std::unique_ptr.
Convert InspectorOverlay to keep Page references.

  • WebCore.exp.in:
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::supportsProfiling):
(WebCore::JSDOMWindowBase::supportsRichSourceInfo):

  • dom/Node.cpp:

(WebCore::Node::inspect):

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::setInspectorFrontendClient):
(WebCore::InspectorController::hasInspectorFrontendClient):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::inspectedPage):
(WebCore::InspectorController::developerExtrasEnabled):

  • inspector/InspectorController.h:
  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::canAttachWindow):
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowHeight):
(WebCore::InspectorFrontendClientLocal::changeAttachedWindowWidth):
(WebCore::InspectorFrontendClientLocal::openInNewTab):
(WebCore::InspectorFrontendClientLocal::restoreAttachedWindowHeight):

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::getHighlight):
(WebCore::InspectorOverlay::highlightQuad):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::buildObjectForHighlightedNode):
(WebCore::InspectorOverlay::drawQuadHighlight):
(WebCore::InspectorOverlay::overlayPage):
(WebCore::InspectorOverlay::reset):

  • inspector/InspectorOverlay.h:
  • inspector/InstrumentingAgents.cpp:

(WebCore::instrumentationForPage): remove null checks.
(WebCore::instrumentationForWorkerGlobalScope): remove null checks.

  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):

  • inspector/WorkerInspectorController.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):

  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::showContextMenu):
(WebCore::ContextMenuController::contextMenuItemSelected):
(WebCore::ContextMenuController::populate):
(WebCore::ContextMenuController::addInspectElementItem):

  • page/FrameView.cpp:

(WebCore::FrameView::sendResizeEventIfNeeded):

  • page/Page.cpp:

(WebCore::Page::Page):

  • page/Page.h:

(WebCore::Page::inspectorController):

  • page/PageDebuggable.cpp:

(WebCore::PageDebuggable::hasLocalDebugger):
(WebCore::PageDebuggable::parentProcessIdentifier):
(WebCore::PageDebuggable::connect):
(WebCore::PageDebuggable::disconnect):
(WebCore::PageDebuggable::dispatchMessageFromRemoteFrontend):
(WebCore::PageDebuggable::setIndicating):

  • platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:

(WebCore::CompositingCoordinator::syncDisplayState):

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::inspectorHighlightRects):
(WebCore::Internals::inspectorHighlightObject):
(WebCore::Internals::emitInspectorDidBeginFrame):
(WebCore::Internals::emitInspectorDidCancelFrame):
(WebCore::Internals::openDummyInspectorFrontend):
(WebCore::Internals::closeDummyInspectorFrontend):
(WebCore::Internals::setInspectorResourcesDataSizeLimits):
(WebCore::Internals::setJavaScriptProfilingEnabled):

  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope):

  • workers/WorkerGlobalScope.h: remove clearInspector().

(WebCore::WorkerGlobalScope::workerInspectorController):

  • workers/WorkerMessagingProxy.cpp:

(WebCore::connectToWorkerGlobalScopeInspectorTask):
(WebCore::disconnectFromWorkerGlobalScopeInspectorTask):
(WebCore::dispatchOnInspectorBackendTask):

  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadShutdownFinishTask::performTask):

Source/WebKit/efl:

Convert call sites to use a InspectorController reference.
Convert instantiations of InspectorFrontendClient to use std::unique_ptr.

  • WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

(DumpRenderTreeSupportEfl::evaluateInWebInspector):

  • WebCoreSupport/InspectorClientEfl.cpp:

(WebCore::InspectorClientEfl::openInspectorFrontend):

  • ewk/ewk_view.cpp:

(ewk_view_inspector_show):
(ewk_view_inspector_close):

Source/WebKit/gtk:

Convert call sites to use a InspectorController reference.
Convert instantiations of InspectorFrontendClient to use std::unique_ptr.

  • WebCoreSupport/ChromeClientGtk.cpp:

(WebKit::paintWebView):

  • WebCoreSupport/InspectorClientGtk.cpp:

(WebKit::InspectorClient::openInspectorFrontend):

  • webkit/webkitwebinspector.cpp:

(webkit_web_inspector_set_property):
(webkit_web_inspector_get_property):
(webkit_web_inspector_show):
(webkit_web_inspector_inspect_node):
(webkit_web_inspector_inspect_coordinates):
(webkit_web_inspector_close):
(webkit_web_inspector_execute_script):

Source/WebKit/mac:

Convert call sites to use a InspectorController reference.
Convert instantiations of InspectorFrontendClient to use std::unique_ptr.

  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::openInspectorFrontend):
(-[WebInspectorWindowController destroyInspectorView:]):

  • WebInspector/WebInspector.mm:

(-showWindow):
(-isJavaScriptProfilingEnabled):
(-setJavaScriptProfilingEnabled:):
(-close:):
(-evaluateInFrontend:callId:script:):

  • WebInspector/WebNodeHighlighter.mm:

(-[WebNodeHighlighter highlight]):

Source/WebKit/win:

Convert call sites to use a InspectorController reference.

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::openInspectorFrontend):
(WebInspectorFrontendClient::destroyInspectorView):
(WebInspectorFrontendClient::onClose):

(WebInspector::show):
(WebInspector::close):
(WebInspector::isJavaScriptProfilingEnabled):
(WebInspector::setJavaScriptProfilingEnabled):
(WebInspector::evaluateInFrontend):

  • WebNodeHighlight.cpp:

(WebNodeHighlight::update):

Source/WebKit2:

Convert call sites to use a InspectorController reference.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::drawRect):

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:

(WebKit::WebInspectorFrontendClient::WebInspectorFrontendClient):
(WebKit::WebInspectorFrontendClient::closeWindow):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::createInspectorPage):
(WebKit::WebInspector::show):
(WebKit::WebInspector::close):
(WebKit::WebInspector::evaluateScriptForTest):
(WebKit::WebInspector::showConsole):
(WebKit::WebInspector::showResources):
(WebKit::WebInspector::showMainResourceForFrame):
(WebKit::WebInspector::startJavaScriptDebugging):
(WebKit::WebInspector::stopJavaScriptDebugging):
(WebKit::WebInspector::setJavaScriptProfilingEnabled):
(WebKit::WebInspector::startJavaScriptProfiling):
(WebKit::WebInspector::stopJavaScriptProfiling):
(WebKit::WebInspector::startPageProfiling):
(WebKit::WebInspector::stopPageProfiling):
(WebKit::WebInspector::dispatchMessageFromRemoteFrontend):
(WebKit::WebInspector::remoteFrontendConnected):
(WebKit::WebInspector::remoteFrontendDisconnected):

10:57 AM Changeset in webkit [162263] by ap@apple.com
  • 4 edits in trunk/Tools

build.webkit.org/dashboard should have image diff links in test results popovers
​https://bugs.webkit.org/show_bug.cgi?id=127188

Reviewed by Timothy Hatcher.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:

(Buildbot.prototype.layoutTestImagesURLForIteration):
(Buildbot.prototype.layoutTestImageDiffURLForIteration):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration.prototype.loadLayoutTestResults):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoLink):
(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions.addFailureInfoText):
(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):

10:50 AM Changeset in webkit [162262] by ap@apple.com
  • 3 edits in trunk/LayoutTests

media/video-size.html is flaky
​https://bugs.webkit.org/show_bug.cgi?id=124932

  • platform/efl/TestExpectations:
  • platform/TestExpectations:

Moving flakiness expectation to cross-platform file, as it also fails on Mac in the same way.

10:43 AM Changeset in webkit [162261] by ap@apple.com
  • 2 edits in trunk/LayoutTests

media/video-display-aspect-ratio.html fails
​https://bugs.webkit.org/show_bug.cgi?id=35297

  • platform/mac/TestExpectations: Marking as flaky.
10:42 AM Changeset in webkit [162260] by andersca@apple.com
  • 16 edits in trunk

Remove ENABLE_THREADED_HTML_PARSER defines everywhere
​https://bugs.webkit.org/show_bug.cgi?id=127225

Reviewed by Andreas Kling.

This concludes the removal of over 8.8 million lines of threaded parser code.

.:

  • Source/autotools/SetupWebKitFeatures.m4:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
10:30 AM Changeset in webkit [162259] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk/Source/WebKit2

Make WKRenderingProgressEvents a shareable API.
​https://bugs.webkit.org/show_bug.cgi?id=127213

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2014-01-18
Reviewed by Dan Bernstein.

Move WKRenderingProgressEvents from UIProcess to Shared, so that an inject bundle
could also use this enum when listening to layout milestones.

  • Shared/API/Cocoa/WKRenderingProgressEvents.h: Added.

(NS_OPTIONS):

  • Shared/API/Cocoa/WKRenderingProgressEventsInternal.h: Added.

(renderingProgressEvents):

  • UIProcess/API/Cocoa/WKBrowsingContextController.h: Move WKRenderingProgressEvents to Shared/API/Cocoa/WKRenderingProgressEvents.h.
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm: Move renderingProgressEvents() to WKRenderingProgressEventsInternal.h.
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h: Add

webProcessPlugInBrowserContextController:renderingProgressDidChange: to load delegate.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(didLayout):
(setUpPageLoaderClient): Also listen to didLayout callback for layout milestones.

10:25 AM Changeset in webkit [162258] by andersca@apple.com
  • 11 edits in trunk/Source/WebCore

Remove the remaining threaded parser code
​https://bugs.webkit.org/show_bug.cgi?id=127224

Reviewed by Andreas Kling.

  • dom/Document.cpp:

(WebCore::Document::decrementActiveParserCount):

  • html/parser/AtomicHTMLToken.h:
  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):
(WebCore::HTMLDocumentParser::detach):
(WebCore::HTMLDocumentParser::stopParsing):
(WebCore::HTMLDocumentParser::prepareToStopParsing):
(WebCore::HTMLDocumentParser::resumeParsingAfterYield):
(WebCore::HTMLDocumentParser::forcePlaintextForTextDocument):
(WebCore::HTMLDocumentParser::insert):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::end):
(WebCore::HTMLDocumentParser::finish):
(WebCore::HTMLDocumentParser::textPosition):
(WebCore::HTMLDocumentParser::resumeParsingAfterScriptExecution):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLParserIdioms.cpp:
  • html/parser/HTMLParserIdioms.h:
  • html/parser/HTMLTokenizer.cpp:
  • html/parser/HTMLTokenizer.h:
  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::isLoading):
(WebCore::DocumentLoader::checkLoadComplete):

  • page/Settings.in:
10:06 AM Changeset in webkit [162257] by andersca@apple.com
  • 5 edits in trunk/Source/WebCore

Remove threaded parser code from the preload scanners
​https://bugs.webkit.org/show_bug.cgi?id=127222

Reviewed by Andreas Kling.

  • html/parser/CSSPreloadScanner.cpp:

(WebCore::CSSPreloadScanner::CSSPreloadScanner):
Use nullptr.

(WebCore::CSSPreloadScanner::scan):
Move scanCommon here and simplify the code.

  • html/parser/CSSPreloadScanner.h:

Remove scanCommon.

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::tagIdFor):
TagId is a strong enum now, update enum values.

(WebCore::TokenPreloadScanner::initiatorFor):
Ditto.

(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
Ditto.

(WebCore::TokenPreloadScanner::StartTagScanner::match):
Indent this.

(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
TagId is a strong enum now, update enum values.

(WebCore::TokenPreloadScanner::StartTagScanner::charset):
Ditto.

(WebCore::TokenPreloadScanner::StartTagScanner::resourceType):
Ditto.

(WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):
Ditto.

(WebCore::TokenPreloadScanner::scan):
Merge scan and scanCommon.

  • html/parser/HTMLPreloadScanner.h:
9:55 AM Changeset in webkit [162256] by mark.lam@apple.com
  • 9 edits
    1 add
    1 delete in trunk/Source/JavaScriptCore

Adding UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn()..
​https://bugs.webkit.org/show_bug.cgi?id=127127.

Reviewed by Geoffrey Garen.

In order to implement bytecode level breakpoints, we need a mechanism
for computing the best fit op_debug bytecode offset for any valid given
line and column value in the source. The "best fit" op_debug bytecode
in this case is defined below in the comment for
UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn().

(JSC::CodeBlock::opDebugBytecodeOffsetForLineAndColumn):

  • Convert the line and column to unlinked line and column values and pass them to UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn() to do the real work.
  • bytecode/CodeBlock.h:
  • bytecode/LineColumnInfo.h: Added.

(JSC::LineColumnInfo::operator <):
(JSC::LineColumnInfo::LineColumnPair::LineColumnPair):
(JSC::LineColumnInfo::operator ==):
(JSC::LineColumnInfo::operator !=):
(JSC::LineColumnInfo::operator <=):
(JSC::LineColumnInfo::operator >):
(JSC::LineColumnInfo::operator >=):

  • bytecode/LineInfo.h: Removed.
  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::decodeExpressionRangeLineAndColumn):

  • Factored this out of expressionRangeForBytecodeOffset() so that it can be called from multiple places.

(JSC::dumpLineColumnEntry):
(JSC::UnlinkedCodeBlock::dumpExpressionRangeInfo):
(JSC::UnlinkedCodeBlock::dumpOpDebugLineColumnInfoList):

  • Some dumpers for debugging use only.

(JSC::UnlinkedCodeBlock::expressionRangeForBytecodeOffset):
(JSC::UnlinkedCodeBlock::opDebugBytecodeOffsetForLineAndColumn):

  • Finds the earliest op_debug bytecode whose line and column matches the specified line and column values. If an exact match is not found, then finds the nearest op_debug bytecode that precedes the specified line and column values. If there are more than one op_debug at that preceding line and column value, then the earliest of those op_debug bytecodes will be be selected. The offset of the selected bytecode will be returned.

We want the earliest one because when we have multiple op_debug bytecodes
that map to a given line and column, a debugger user would expect to break
on the first one and step through the rest thereafter if needed.

(JSC::compareLineColumnInfo):
(JSC::UnlinkedCodeBlock::opDebugLineColumnInfoList):

  • Creates the sorted opDebugLineColumnInfoList on demand. This list is stored in the UnlinkedCodeBlock's rareData.
  • bytecode/UnlinkedCodeBlock.h:
9:19 AM Changeset in webkit [162255] by akling@apple.com
  • 2 edits
    10 deletes in trunk

Remove Nix files from WebCore
​https://bugs.webkit.org/show_bug.cgi?id=127176

Patch by Lauro Neto <​lauro.neto@openbossa.org> on 2014-01-18
Reviewed by Anders Carlsson.

.:

  • Source/cmake/OptionsNix.cmake: Removed.

Source/WebCore:

  • PlatformNix.cmake: Removed.
  • css/mediaControlsNix.css: Removed.
  • css/mediaControlsNixFullscreen.css: Removed.
  • editing/nix/EditorNix.cpp: Removed.
  • page/nix/EventHandlerNix.cpp: Removed.
  • platform/audio/nix/AudioBusNix.cpp: Removed.
  • platform/audio/nix/AudioDestinationNix.cpp: Removed.
  • platform/audio/nix/AudioDestinationNix.h: Removed.
  • platform/audio/nix/FFTFrameNix.cpp: Removed.
  • platform/graphics/nix/IconNix.cpp: Removed.
  • platform/graphics/nix/ImageNix.cpp: Removed.
  • platform/nix/CursorNix.cpp: Removed.
  • platform/nix/DragDataNix.cpp: Removed.
  • platform/nix/DragImageNix.cpp: Removed.
  • platform/nix/ErrorsNix.cpp: Removed.
  • platform/nix/ErrorsNix.h: Removed.
  • platform/nix/FileSystemNix.cpp: Removed.
  • platform/nix/GamepadsNix.cpp: Removed.
  • platform/nix/LanguageNix.cpp: Removed.
  • platform/nix/LocalizedStringsNix.cpp: Removed.
  • platform/nix/MIMETypeRegistryNix.cpp: Removed.
  • platform/nix/NixKeyboardUtilities.cpp: Removed.
  • platform/nix/NixKeyboardUtilities.h: Removed.
  • platform/nix/PasteboardNix.cpp: Removed.
  • platform/nix/PlatformKeyboardEventNix.cpp: Removed.
  • platform/nix/PlatformScreenNix.cpp: Removed.
  • platform/nix/RenderThemeNix.cpp: Removed.
  • platform/nix/RenderThemeNix.h: Removed.
  • platform/nix/ScrollbarThemeNix.cpp: Removed.
  • platform/nix/ScrollbarThemeNix.h: Removed.
  • platform/nix/SharedTimerNix.cpp: Removed.
  • platform/nix/SoundNix.cpp: Removed.
  • platform/nix/TemporaryLinkStubs.cpp: Removed.
  • platform/nix/WidgetNix.cpp: Removed.
  • platform/nix/support/MultiChannelPCMData.cpp: Removed.
  • platform/text/nix/TextBreakIteratorInternalICUNix.cpp: Removed.
9:11 AM Changeset in webkit [162254] by andersca@apple.com
  • 9 edits in trunk/Source/WebCore

Remove DocumentParser::pinToMainThread() and related code
​https://bugs.webkit.org/show_bug.cgi?id=127221

Reviewed by Andreas Kling.

  • dom/Document.cpp:

(WebCore::Document::setContent):

  • dom/DocumentParser.h:
  • html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::HTMLDocumentParser):

  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLParserOptions.cpp:

(WebCore::HTMLParserOptions::HTMLParserOptions):

  • html/parser/HTMLParserOptions.h:
  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processEndTag):

  • loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::replaceDocument):

9:00 AM Changeset in webkit [162253] by andersca@apple.com
  • 7 edits
    2 deletes in trunk/Source/WebCore

Remove HTMLParserThread
​https://bugs.webkit.org/show_bug.cgi?id=127220

Reviewed by Andreas Kling.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/HTMLDocumentParser.cpp:
  • html/parser/HTMLParserThread.cpp: Removed.
  • html/parser/HTMLParserThread.h: Removed.
8:50 AM Changeset in webkit [162252] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

GC soon after responding to fake memory pressure.
<​https://webkit.org/b/127210>

Ask JSC to garbage collect "soon" after handling the fake memory
pressure signal on Mac. This seems to stabilize the post-pressure
numbers on Membuster3 a bit on my laptop. The difference is mostly
made up of JSC::CodeBlock objects.

Reviewed by Geoffrey Garen.

  • platform/mac/MemoryPressureHandlerMac.mm:

(WebCore::MemoryPressureHandler::install):

8:48 AM Changeset in webkit [162251] by andersca@apple.com
  • 11 edits
    10 deletes in trunk/Source/WebCore

Remove files only used by the threaded HTML parser
​https://bugs.webkit.org/show_bug.cgi?id=127219
<rdar://problem/13331277>

Reviewed by Andreas Kling.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/parser/AtomicHTMLToken.h:
  • html/parser/BackgroundHTMLInputStream.cpp: Removed.
  • html/parser/BackgroundHTMLInputStream.h: Removed.
  • html/parser/BackgroundHTMLParser.cpp: Removed.
  • html/parser/BackgroundHTMLParser.h: Removed.
  • html/parser/CompactHTMLToken.cpp: Removed.
  • html/parser/CompactHTMLToken.h: Removed.
  • html/parser/HTMLDocumentParser.cpp:
  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLIdentifier.cpp: Removed.
  • html/parser/HTMLIdentifier.h: Removed.
  • html/parser/HTMLParserIdioms.h:
  • html/parser/HTMLPreloadScanner.h:
  • html/parser/HTMLTreeBuilderSimulator.cpp: Removed.
  • html/parser/HTMLTreeBuilderSimulator.h: Removed.
1:04 AM Changeset in webkit [162250] by zandobersek@gmail.com
  • 3 edits in trunk/Source/JavaScriptCore

Inspector scripts are not compatible with Python v3
​https://bugs.webkit.org/show_bug.cgi?id=127128

Reviewed by Benjamin Poulain.

  • inspector/scripts/generate-combined-inspector-json.py: Turn print statements into print function calls.
  • inspector/scripts/jsmin.py: Try importing the StringIO class from the StringIO module (which will work for

Python v2) or, on import error, import the class from the io module (which will work for Python v3).

12:22 AM Changeset in webkit [162249] by zandobersek@gmail.com
  • 2 edits in trunk

[GTK] Bump the minimum required Clang version to 3.3
​https://bugs.webkit.org/show_bug.cgi?id=127178

Reviewed by Martin Robinson.

  • Source/autotools/CheckSystemAndBasicDependencies.m4: Require Clang 3.3 or later when using the Clang compiler to

build the GTK port. Building with Clang 3.2 doesn't work anymore and there's no point in fixing that, as we should
support the latest two versions of Clang (3.3 and 3.4), just like we do with GCC (4.7 and 4.8).

Jan 17, 2014:

11:26 PM Changeset in webkit [162248] by mark.lam@apple.com
  • 2 edits in branches/jsCStack/Source/JavaScriptCore

Fix 32-bit C loop LLINT.
​https://bugs.webkit.org/show_bug.cgi?id=127086.

Reviewed by Geoffrey Garen.

  • llint/LowLevelInterpreter32_64.asm:
10:54 PM Changeset in webkit [162247] by fpizlo@apple.com
  • 2 edits in branches/jsCStack/Tools

Unreviewed, run Mozilla tests with the FTL.

All of those tests pass. Because the FTL is now awesome.

  • Scripts/run-jsc-stress-tests:
10:32 PM Changeset in webkit [162246] by fpizlo@apple.com
  • 2 edits in branches/jsCStack/Source/JavaScriptCore

FTL mishandles (-2147483648 % 0) | 0
​https://bugs.webkit.org/show_bug.cgi?id=127215

Not yet reviewed.

This fixes:

jsc-layout-tests.yaml/js/script-tests/dfg-mod-neg2tothe31-by-one-and-then-or-zero-with-interesting-reg-alloc.js.layout-ftl-eager-no-cjit


Now the FTL passes all JSC layout tests.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithDivMod):

10:27 PM Changeset in webkit [162245] by commit-queue@webkit.org
  • 30 edits
    2 deletes in trunk/Source/WebKit2

Unreviewed, rolling out r162237 and r162241.
​http://trac.webkit.org/changeset/162237
​http://trac.webkit.org/changeset/162241
​https://bugs.webkit.org/show_bug.cgi?id=127216

Broke lots of API tests (Requested by ap on #webkit).

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::storageSession):
(WebKit::NetworkConnectionToWebProcess::startDownload):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
(WebKit::NetworkConnectionToWebProcess::getRawCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookie):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::ensurePrivateBrowsingSession):
(WebKit::NetworkProcess::destroyPrivateBrowsingSession):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/RemoteNetworkingContext.h:
  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::privateBrowsingStorageSession):
(WebKit::RemoteNetworkingContext::storageSession):
(WebKit::RemoteNetworkingContext::privateBrowsingSession):
(WebKit::privateBrowsingStorageSessionIdentifierBase):
(WebKit::RemoteNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::RemoteNetworkingContext::destroyPrivateBrowsingSession):

  • NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:

(WebKit::RemoteNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::RemoteNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::RemoteNetworkingContext::privateBrowsingSession):

  • Shared/SessionTracker.cpp: Removed.
  • Shared/SessionTracker.h: Removed.
  • UIProcess/APISession.cpp:

(API::Session::Session):
(API::Session::create):
(API::Session::isEphemeral):

  • UIProcess/APISession.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):

  • UIProcess/WebContext.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

  • UIProcess/WebProcessProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPrivateBrowsingEnabled):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::cookiesForDOM):
(WebKit::WebPlatformStrategies::setCookiesFromDOM):
(WebKit::WebPlatformStrategies::cookiesEnabled):
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
(WebKit::WebPlatformStrategies::getRawCookies):
(WebKit::WebPlatformStrategies::deleteCookie):

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::privateSession):
(WebKit::identifierBase):
(WebKit::WebFrameNetworkingContext::setPrivateBrowsingStorageSessionIdentifierBase):
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::storageSession):

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::privateSession):
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::ensurePrivateBrowsingSession):
(WebKit::WebProcess::destroyPrivateBrowsingSession):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
9:48 PM Changeset in webkit [162244] by fpizlo@apple.com
  • 3 edits in branches/jsCStack/Source/JavaScriptCore

FTL should update machine virtual registers in runtime meta-data according to the captured stackmap
​https://bugs.webkit.org/show_bug.cgi?id=125725

Reviewed by Michael Saboff.

This is pretty awesome - it closes the loop on our FTL stackwalking story. We use
an alloca for storing all of the things that the runtime will want to discover
during a stack walk, like the closure pointer for inlined closure calls and the
arguments to inlined functions. We then pass that alloca as an argument to a
stackmap in the prologue, and LLVM reports the alloca's frame offset using a
stackmap direct entry. We call this the "localsOffset". Previously we just used
this to update some OSR exit meta-data. Now we also use it to properly adjust the
ValueRecovery meta-data in inline call frames.

Currently we only have to do this for inline call frames and OSR exits, but in the
future we'll use similar techniques for activations. This bug doesn't cover that
since the FTL doesn't support compiling functions that create activations, yet.
This change makes us incorporate localsOffset into all of the relevant things that
the FTL supports.

This fixes:

jsc-layout-tests.yaml/js/script-tests/dfg-inline-arguments-use-from-all-the-places.js.layout-ftl-eager-no-cjit


With this fix, the FTL only fails one of the JSC layout tests.

  • bytecode/ValueRecovery.h:

(JSC::ValueRecovery::withLocalsOffset):

  • ftl/FTLCompile.cpp:

(JSC::FTL::fixFunctionBasedOnStackMaps):

9:33 PM Changeset in webkit [162243] by Martin Robinson
  • 2 edits in trunk/Source/WebKit

Build fix for the CMake GTK+ build

  • PlatformGTK.cmake: We need to include ProgressTrackerClientGtk in the source list.
9:10 PM Changeset in webkit [162242] by msaboff@apple.com
  • 8 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: Fix Baseline JIT for X86-32
​https://bugs.webkit.org/show_bug.cgi?id=127201

Reviewed by Geoffrey Garen.

Most of the changes are to follow calling convention (emiting function prologues and
epilogues) and making room on the stack for outgoing arguments.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwind):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile): Eliminated stack alignment check before moving the stack
pointer down for locals since it will not be aligned at that time. The move will align
the stack pointer.
(JSC::JIT::frameRegisterCountFor): Changed to allocate the outgoing register space
after rounding the number of local registers as the outgoing register count will
properly align the local registers.

  • jit/JITCall32_64.cpp:

(JSC::JIT::emit_op_ret): Changed to emit epilogue.
(JSC::JIT::emit_op_ret_object_or_this): Changed to emit epilogue.
(JSC::JIT::compileLoadVarargs): Alignment changes matching what is in
JITCall.cpp::JIT::compileLoadVarargs.
(JSC::JIT::compileCallEvalSlowCase): Changed to use the stack pointer to fill-in the
new callee frame.
(JSC::JIT::compileOpCall): Changed to use the stack pointer to fill-in the
new callee frame.
(JSC::JIT::compileOpCallSlowCase): Code to restore the stack pointer after the call.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_ret_object_or_this): Remove dead code in 64 bit path found while
working on this patch.

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::privateCompileCTINativeCall): Changes to follow native calling convention,
allocate space and populate outgoing args and pass the caller to operationVMHandleException.
(JSC::JIT::emit_op_end): Emit the epilogue.

  • jit/ThunkGenerators.cpp:

(JSC::slowPathFor): Allocate stack space for arguments.
(JSC::arityFixup): Changes to match 64 bit code.

  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL): Whitespace cleanup.

9:06 PM Changeset in webkit [162241] by ryuan.choi@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed build fix on EFL port after r162237

The EFL port disabled NETWORK_PROCESS yet and use -Werror=unused-function.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

Guarded legacySessionID with ENABLE(NETWORK_PROCESS)

9:05 PM Changeset in webkit [162240] by msaboff@apple.com
  • 13 edits in branches/jsCStack/Source/JavaScriptCore

CStack Branch: X86-32 Fix LLInt
​https://bugs.webkit.org/show_bug.cgi?id=127071

Reviewed by Filip Pizlo.

This fixes X86-32 compilation issues in JITCall32_64.cpp and JITPropertyAccess32_64.cpp.

Fixed the 32 bit LLInt to work with X86. Since X86 passes arguments on the stack,
calls (e.g. LLInt CCall2, JITOperations::getHostCallReturnValue) need to make an
outgoing argument area on the stack, populate the arguments and then make the call.

Much of the argument and call logic is based on the alignment of the stack pointer
and call frame register. The stack pointer at the time of a call needs to be
stackAlignmentBytes() (16 byte) aligned. The call frame register, which points at
the current call frame will be at an alignment that is stackAlignmentBytes() minus
what gets pushed on the stack as part of the call, i.e. the caller PC and caller
frame pointer. For us this is JSStack::CallerFrameAndPCSize * sizeof(Register).

Using roundLocalRegisterCountForFramePointerOffset() eliminates the need for
maxFrameExtentForSlowPathCall needing additional bytes to pad out the stack
to be aligned.

Tested on X86-32 with LLInt only testapi. Tested on X86-64 with all javascript tests.

  • assembler/MaxFrameExtentForSlowPathCall.h:
  • interpreter/ProtoCallFrame.cpp:

(JSC::ProtoCallFrame::init):

  • interpreter/ProtoCallFrame.h:

(JSC::ProtoCallFrame::setPaddedArgCount):

  • jit/JITCall32_64.cpp:

(JSC::JIT::compileCallEval):
(JSC::JIT::compileOpCallSlowCase):

  • jit/JITOperations.cpp:
  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_get_by_id):
(JSC::JIT::emit_op_put_by_id):

  • llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

  • llint/LLIntEntrypoint.cpp:

(JSC::LLInt::frameRegisterCountFor):

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • runtime/StackAlignment.h:

(JSC::roundArgumentCountToAlignFrame):
(JSC::roundLocalRegisterCountForFramePointerOffset):

7:54 PM Changeset in webkit [162239] by fpizlo@apple.com
  • 8 edits in branches/jsCStack/Source/JavaScriptCore

FTL watchpoint tests that use dfgIncrement() and friends fail because numberOfDFGCompiles() returns zero with --testTheFTL=true and right after the first FTL OSR exit but just before recompilation is triggered
​https://bugs.webkit.org/show_bug.cgi?id=127163

Reviewed by Michael Saboff.

We just need to track if we had ever compiled with the FTL. Also rework the various
bool's in CodeBlock so that they are bitfields if possible. To that end, make sure
we only write to them from the main thread.

This fixes a bunch of LayoutTests with --ftl-jit. Now only two fail.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpAssumingJITType):
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::numberOfDFGCompiles):

  • bytecode/CodeBlock.h:
  • dfg/DFGJITCode.cpp:

(JSC::DFG::JITCode::setOptimizationThresholdBasedOnCompilationResult):

  • dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::finalizeCommon):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::Plan):

  • dfg/DFGPlan.h:
  • dfg/DFGTierUpCheckInjectionPhase.cpp:

(JSC::DFG::TierUpCheckInjectionPhase::run):

6:31 PM Changeset in webkit [162238] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

Micro-optimize RenderBoxModelObject::computedCSSPadding().
<​https://webkit.org/b/127208>

Make computedCSSPadding() take the Length as a const reference
to avoid creating a temporary copy. This was showing up (0.2%)
on DoYouEvenBench.

Reviewed by Anders Carlsson.

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::computedCSSPadding):

6:17 PM Changeset in webkit [162237] by commit-queue@webkit.org
  • 30 edits
    2 copies in trunk/Source/WebKit2

Flesh out session APIs (still not enabled at API level).
​https://bugs.webkit.org/show_bug.cgi?id=126918

Patch by Martin Hock <​mhock@apple.com> on 2014-01-17
Reviewed by Alexey Proskuryakov.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::storageSession):
(WebKit::NetworkConnectionToWebProcess::startDownload):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
(WebKit::NetworkConnectionToWebProcess::getRawCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookie):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::ensurePrivateBrowsingSession):
(WebKit::NetworkProcess::destroyPrivateBrowsingSession):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • NetworkProcess/RemoteNetworkingContext.h:
  • NetworkProcess/mac/RemoteNetworkingContext.mm:

(WebKit::RemoteNetworkingContext::storageSession):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):

  • NetworkProcess/soup/RemoteNetworkingContextSoup.cpp:

(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession):

  • Shared/SessionTracker.cpp: Copied from Source/WebKit2/UIProcess/APISession.cpp.

(WebKit::sessionMap):
(WebKit::identifierBase):
(WebKit::SessionTracker::getSessionMap):
(WebKit::SessionTracker::getIdentifierBase):
(WebKit::SessionTracker::session):
(WebKit::SessionTracker::destroySession):
(WebKit::SessionTracker::setIdentifierBase):

  • Shared/SessionTracker.h: Copied from Source/WebKit2/UIProcess/APISession.h.

(WebKit::SessionTracker::isEphemeralID):

  • UIProcess/APISession.cpp:

(API::generateID):
(API::Session::defaultSession):
(API::Session::legacyPrivateSession):
(API::Session::Session):
(API::Session::create):
(API::Session::isEphemeral):
(API::Session::getID):

  • UIProcess/APISession.h:
  • UIProcess/WebContext.cpp:

(WebKit::WebContext::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebContext::createNewWebProcess):
(WebKit::WebContext::createWebPage):

  • UIProcess/WebContext.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::create):
(WebKit::WebPageProxy::WebPageProxy):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::sessionID):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::createWebPage):

  • UIProcess/WebProcessProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPrivateBrowsingEnabled):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::legacySessionID):
(WebKit::WebPlatformStrategies::cookiesForDOM):
(WebKit::WebPlatformStrategies::setCookiesFromDOM):
(WebKit::WebPlatformStrategies::cookiesEnabled):
(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):
(WebKit::WebPlatformStrategies::getRawCookies):
(WebKit::WebPlatformStrategies::deleteCookie):

  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebKit::WebFrameNetworkingContext::storageSession):

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebKit::WebFrameNetworkingContext::storageSession):

  • WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):
(WebKit::WebProcess::ensurePrivateBrowsingSession):
(WebKit::WebProcess::destroyPrivateBrowsingSession):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:
6:08 PM Changeset in webkit [162236] by ap@apple.com
  • 4 edits in trunk/Tools

build.webkit.org/dashboard should have diff links in test results popovers
​https://bugs.webkit.org/show_bug.cgi?id=126986

Reviewed by Tim Horton.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:

(Buildbot.prototype.layoutTestCrashLogURLForIteration):
(Buildbot.prototype.layoutTestStderrURLForIteration):
(Buildbot.prototype.layoutTestDiffURLForIteration):
(Buildbot.prototype.layoutTestPrettyDiffURLForIteration):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration.prototype.loadLayoutTestResults):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):

5:58 PM Changeset in webkit [162235] by andersca@apple.com
  • 6 edits in trunk/Source

Add a callOnMainThreadAndWait variant in SocketStreamHandle
​https://bugs.webkit.org/show_bug.cgi?id=127180

Reviewed by Geoffrey Garen.

Source/WebCore:

WTF::callOnMainThreadAndWait was only used inside SocketStreamHandleCFNet.cpp,
so add an improved version there which is implemented in terms of callOnMainThread and
with the bonus of handling spurious wake-ups correctly (the old version didn't).

  • platform/network/cf/SocketStreamHandle.h:
  • platform/network/cf/SocketStreamHandleCFNet.cpp:

(WebCore::callOnMainThreadAndWait):
(WebCore::SocketStreamHandle::pacExecutionCallback):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):

Source/WTF:

Remove callOnMainThreadAndWait from WTF.

  • wtf/MainThread.cpp:
  • wtf/MainThread.h:
5:47 PM Changeset in webkit [162234] by andersca@apple.com
  • 15 edits in trunk/Source

Clean up PageCache classes
​https://bugs.webkit.org/show_bug.cgi?id=127202

Reviewed by Andreas Kling.

Source/WebCore:

  • WebCore.exp.in:
  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::~CachedFrameBase):
(WebCore::CachedFrame::CachedFrame):
(WebCore::CachedFrame::clear):
(WebCore::CachedFrame::setCachedFramePlatformData):

  • history/CachedFrame.h:
  • history/CachedPage.cpp:

(WebCore::CachedPage::CachedPage):

  • history/CachedPage.h:
  • history/HistoryItem.h:

(WebCore::HistoryItem::isInPageCache):

  • history/PageCache.cpp:

(WebCore::PageCache::add):
(WebCore::PageCache::take):
(WebCore::PageCache::remove):

  • history/PageCache.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::invalidateCurrentItemCachedPage):

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::savePlatformDataToCachedFrame):
(WebFrameLoaderClient::transitionToCommittedFromCachedFrame):

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::savePlatformDataToCachedFrame):

5:18 PM Changeset in webkit [162233] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Work around a preprocessor warning in mediaControlsApple.js
​https://bugs.webkit.org/show_bug.cgi?id=127204

Reviewed by Dan Bernstein.

  • Modules/mediacontrols/mediaControlsApple.js: Changed to String().
4:36 PM Changeset in webkit [162232] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the iOS build after <​http://trac.webkit.org/changeset/162184>
(​https://bugs.webkit.org/show_bug.cgi?id=126856)

Remove symbol for WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator(unsigned short const*, int).
Add symbol for WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator(WTF::StringView).

  • WebCore.exp.in:
4:34 PM Changeset in webkit [162231] by akling@apple.com
  • 9 edits
    2 deletes in trunk/Source

Remove unused TOUCH_ADJUSTMENT code.
<​https://webkit.org/b/127181>

Source/WebCore:

There are no ports using the ENABLE(TOUCH_ADJUSTMENT) feature
anymore, so nuke it from orbit.

Reviewed by Anders Carlsson.

  • page/EventHandler.cpp:
  • page/EventHandler.h:
  • page/Settings.in:
  • page/TouchAdjustment.cpp: Removed.
  • page/TouchAdjustment.h: Removed.
  • testing/Internals.cpp:
  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit2:

Reviewed by Anders Carlsson.

  • WebProcess/WebPage/CoordinatedGraphics/WebPageCoordinatedGraphics.cpp:

(WebKit::WebPage::findZoomableAreaForPoint):

4:05 PM Changeset in webkit [162230] by Beth Dakin
  • 16 edits
    2 adds in trunk

Need a way to test the tile cache with margins enabled
​https://bugs.webkit.org/show_bug.cgi?id=127194
-and corresponding-
<rdar://problem/15571327>

Reviewed by Tim Horton.

Source/WebCore:

This patch adds a new function to InternalSettings that will allow layout tests to
flip the setting Settings::setBackgroundShouldExtendBeyondPage(). This patch also
makes changing that setting take effect immediately.

To make this setting dynamic, we can no longer generate the Setting function, so
we have to export the symbol manually.

  • WebCore.exp.in:

This new function on FrameView will call into RenderLayerBacking to add or remove
margins.

  • page/FrameView.cpp:

(WebCore::FrameView::setBackgroundExtendsBeyondPage):

  • page/FrameView.h:

Again, we’re no longer using the boiler-plate generated Setting functions, so now
we can call into FrameView to make the background extend.

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setBackgroundShouldExtendBeyondPage):

  • page/Settings.h:

(WebCore::Settings::backgroundShouldExtendBeyondPage):

  • page/Settings.in:

Whenever tile margins are set, call setNeedsRevalidateTiles() to make the change
dynamic.

  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::setTileMargins):

Move the call to TiledBacking::setTileMargins() into a helper function so that the
same code can be used for FrameView.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::RenderLayerBacking):
(WebCore::RenderLayerBacking::setTiledBackingHasMargins):

  • rendering/RenderLayerBacking.h:

New InternalSetting.

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::setBackgroundShouldExtendBeyondPage):

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:

Source/WebKit:

Attempt to keep Windows building.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

LayoutTests:

  • platform/mac-wk2/tiled-drawing/simple-document-with-margin-tiles-expected.txt: Added.
  • platform/mac-wk2/tiled-drawing/simple-document-with-margin-tiles.html: Added.
3:49 PM Changeset in webkit [162229] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix build.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
3:43 PM Changeset in webkit [162228] by matthew_hanson@apple.com
  • 3 edits in trunk/Tools

Add the bare minimum support for branches to the bot-watchers dashboard
​https://bugs.webkit.org/show_bug.cgi?id=127124

This patch simply introduces the notion of branches into the bot-watchers dashboard.
Subsequent patches will build functionality on top of this simple bit of infrastructure.

Reviewed by Timothy Hatcher.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueue.js:

(BuildbotQueue): store the branch property in the BuildbotQueue constructor

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:

Initialize the Dashboard.Branch object

3:17 PM Changeset in webkit [162227] by andersca@apple.com
  • 25 edits in trunk/Source

Remove another unused FrameLoaderClient callback
​https://bugs.webkit.org/show_bug.cgi?id=127192

Reviewed by Dan Bernstein.

Source/WebCore:

FrameLoaderClient::dispatchDocumentElementAvailable() was only used by the Chromium port, so remove it.

  • html/ImageDocument.cpp:

(WebCore::ImageDocument::createDocumentStructure):

  • html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

  • html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::dispatchDocumentElementAvailableIfNeeded):

  • loader/EmptyClients.h:
  • loader/FrameLoader.cpp:
  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):

Source/WebKit/efl:

  • WebCoreSupport/FrameLoaderClientEfl.cpp:
  • WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/mac:

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:
  • WebCoreSupport/FrameLoaderClientWinCE.h:
2:59 PM Changeset in webkit [162226] by andersca@apple.com
  • 9 edits in trunk/Source

Remove FrameLoaderClient::didPerformFirstNavigation()
​https://bugs.webkit.org/show_bug.cgi?id=127191

Reviewed by Dan Bernstein.

Source/WebCore:

  • loader/EmptyClients.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::FrameLoader):

  • loader/FrameLoader.h:
  • loader/FrameLoaderClient.h:
  • loader/HistoryController.cpp:

(WebCore::HistoryController::updateBackForwardListClippedAtTarget):

Source/WebKit2:

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
2:49 PM Changeset in webkit [162225] by andersca@apple.com
  • 14 edits in trunk/Source/WebKit

Remove didPerformFirstNavigation from all FrameLoaderClient subclasses
​https://bugs.webkit.org/show_bug.cgi?id=127190

Reviewed by Dan Bernstein.

Source/WebKit/efl:

According to the EFl maintainers, this is not used by any applications so it's safe to remove it.

  • WebCoreSupport/FrameLoaderClientEfl.cpp:
  • WebCoreSupport/FrameLoaderClientEfl.h:
  • ewk/ewk_frame.cpp:
  • ewk/ewk_frame_private.h:

Source/WebKit/gtk:

Removing this shouldn't have any bad effects, but if that is the case it's possible to
set the cache model in didCommitLoadForFrame, similar to what is done in r162224.

  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/win:

  • WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit/wince:

  • WebCoreSupport/FrameLoaderClientWinCE.cpp:
  • WebCoreSupport/FrameLoaderClientWinCE.h:
2:38 PM Changeset in webkit [162224] by andersca@apple.com
  • 7 edits in trunk/Source

Move didPerformFirstNavigation() logic to -[WebView _didCommitLoadForFrame:]
​https://bugs.webkit.org/show_bug.cgi?id=127189

Reviewed by Dan Bernstein.

Source/WebCore:

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::didPerformFirstNavigation):
Add an empty implementation of didPerformFirstNavigation() to make it easier to remove it from subclasses.

Source/WebKit/mac:

This is a first step towards completely eliminating the didPerformFirstNavigation() client callback.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

Remove didPerformFirstNavigation() implementation.

  • WebView/WebView.mm:

(-[WebView _checkDidPerformFirstNavigation]):
Check if we have both a current item and a previous item which indicates that we've navigated once.
The old code was called before there was a current item but since this is called from _didCommitLoadForFrame
we have to check that there's a current item as well.

(-[WebView _didCommitLoadForFrame:]):
Call _didCommitLoadForFrame.

  • WebView/WebViewData.h:

Add new ivar.

2:22 PM Changeset in webkit [162223] by Manuel Rego Casasnovas
  • 7 edits in trunk/PerformanceTests

[CSS Regions] Minor fixes in regions performance tests
​https://bugs.webkit.org/show_bug.cgi?id=127041

Reviewed by Ryosuke Niwa.

Fix minor issues in CSS Regions performance tests.

  • Layout/RegionsAuto.html: Change type to lower case.
  • Layout/RegionsAutoMaxHeight.html: Ditto.
  • Layout/RegionsFixed.html: Ditto.
  • Layout/RegionsFixedShort.html: Ditto.
  • Layout/RegionsSelection.html: Ditto. Move test methods from regions.js.
  • Layout/resources/regions.js: Remove moved methods.
1:54 PM Changeset in webkit [162222] by Chris Fleizach
  • 7 edits in trunk/Tools

platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
​https://bugs.webkit.org/show_bug.cgi?id=127141

Reviewed by Alexey Proskuryakov.

Make sure to reset the notification handler each time.

  • DumpRenderTree/AccessibilityController.cpp:

(AccessibilityController::resetToConsistentState):

  • DumpRenderTree/AccessibilityController.h:
  • DumpRenderTree/atk/AccessibilityControllerAtk.cpp:

(AccessibilityController::platformResetToConsistentState):

  • DumpRenderTree/ios/AccessibilityControllerIOS.mm:

(AccessibilityController::platformResetToConsistentState):

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::~AccessibilityController):
(AccessibilityController::platformResetToConsistentState):
(AccessibilityController::removeNotificationListener):

  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::platformResetToConsistentState):

1:36 PM Changeset in webkit [162221] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] HTMLMediaSession should set AudioSession category
​https://bugs.webkit.org/show_bug.cgi?id=127137

Reviewed by Sam Weinig.

  • html/HTMLMediaSession.cpp:

(WebCore::initializeAudioSession): New, set the audio session to "media" on iOS.
(WebCore::HTMLMediaSession::HTMLMediaSession): Call initializeAudioSession.

1:31 PM Changeset in webkit [162220] by rniwa@webkit.org
  • 2 edits in trunk/Websites/webkit.org

Host DoYouEvenBench on webkit.org
​https://bugs.webkit.org/show_bug.cgi?id=127185

Reviewed by Benjamin Poulain.

The previous patch didn't quite work due to cross-origin restrictions.
Simply add a hyperlink to a trac page.

  • perf/DoYouEvenBench/index.html:
1:24 PM Changeset in webkit [162219] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

More iOS build fix.

  • WebView/WebPreferences.mm: (-[WebPreferences _synchronizeWebStoragePolicyWithCookiePolicy]):

NSHTTPCookieAcceptPolicyExclusivelyFromMainDocumentDomain is not part of NSHTTPCookieAcceptPolicy enum.

1:13 PM Changeset in webkit [162218] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the iOS build after <​http://trac.webkit.org/changeset/162178>
(​https://bugs.webkit.org/show_bug.cgi?id=127147)

Declare WebMediaSessionHelper outside of namespace WebCore to resolve error that
"Objective-C declarations may only appear in global scope".

  • platform/audio/ios/MediaSessionManagerIOS.mm:
1:11 PM Changeset in webkit [162217] by Bem Jones-Bey
  • 6 edits
    6 adds in trunk

[CSS Shapes] Stacked floats with shape-outside should allow inline content to interact with the non-outermost float
​https://bugs.webkit.org/show_bug.cgi?id=122576

Reviewed by David Hyatt.

Source/WebCore:

Make inline content interact with stacked floats with shape-outside
per the spec. This means that content can interact with floats on the
line that are not the outermost float.

This refactors ComputeFloatOffsetAdapter into a superclass and two
subclasses: one adaptor for determining the offset for float layout,
and one for determining the offset for inline layout.

The logic in LineWidth::shrinkAvailableWidthForNewFloatIfNeeded has
been updated to handle stacked floats with shape-outside properly and
has been considerably simplified in the process. It was previously
doing a whole bunch of unnecessary work.

Tests: fast/shapes/shape-outside-floats/shape-outside-floats-stacked-000.html

fast/shapes/shape-outside-floats/shape-outside-floats-stacked-001.html
fast/shapes/shape-outside-floats/shape-outside-floats-stacked-002.html

  • rendering/FloatingObjects.cpp:

(WebCore::ComputeFloatOffsetAdapter::~ComputeFloatOffsetAdapter):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter::ComputeFloatOffsetForFloatLayoutAdapter):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter::~ComputeFloatOffsetForFloatLayoutAdapter):
(WebCore::ComputeFloatOffsetForLineLayoutAdapter::ComputeFloatOffsetForLineLayoutAdapter):
(WebCore::ComputeFloatOffsetForLineLayoutAdapter::~ComputeFloatOffsetForLineLayoutAdapter):
(WebCore::FloatingObjects::logicalLeftOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalRightOffsetForPositioningFloat):
(WebCore::FloatingObjects::logicalLeftOffset):
(WebCore::FloatingObjects::logicalRightOffset):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter<FloatingObject::FloatLeft>::updateOffsetIfNeeded):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter<FloatingObject::FloatRight>::updateOffsetIfNeeded):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter<FloatTypeValue>::heightRemaining):
(WebCore::shapeInfoForFloat):
(WebCore::ComputeFloatOffsetForLineLayoutAdapter<FloatingObject::FloatLeft>::updateOffsetIfNeeded):
(WebCore::ComputeFloatOffsetForLineLayoutAdapter<FloatingObject::FloatRight>::updateOffsetIfNeeded):

  • rendering/line/LineWidth.cpp:

(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

  • rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::updateDeltasForContainingBlockLine):

  • rendering/shapes/ShapeOutsideInfo.h:

LayoutTests:

Tests for shape-outside on stacked floats and interaction with inline
content.

  • fast/shapes/shape-outside-floats/shape-outside-floats-stacked-000-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-stacked-000.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-stacked-001-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-stacked-001.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-stacked-002-expected.html: Added.
  • fast/shapes/shape-outside-floats/shape-outside-floats-stacked-002.html: Added.
1:10 PM Changeset in webkit [162216] by rniwa@webkit.org
  • 3 edits
    1 copy
    1 add in trunk

Host DoYouEvenBench on webkit.org
​https://bugs.webkit.org/show_bug.cgi?id=127185

Reviewed by Benjamin Poulain.

PerformanceTests:

Compute the resources directory relative to the benchmark-runner's location
so that we can load tests even if the runner HTML was located elsewhere.

  • DoYouEvenBench/Full.html:
  • DoYouEvenBench/resources/benchmark-runner.js:

(BenchmarkState._containingDirectory):

Websites/webkit.org:

Added webkit.org/perf/DoYouEvenBench.

  • perf/DoYouEvenBench: Added.
  • perf/DoYouEvenBench/index.html: Copied from PerformanceTests/DoYouEvenBench/Full.html.
12:56 PM Changeset in webkit [162215] by Manuel Rego Casasnovas
  • 4 edits in trunk/Source/WebKit2

[GTK] Add CSS Grid Layout as experimental feature
​https://bugs.webkit.org/show_bug.cgi?id=127089

Reviewed by Martin Robinson.

Allow CSS Grid Layout to be enabled through the environment variable WEBKITGTK_EXPERIMENTAL_FEATURES.

Example: WEBKITGTK_EXPERIMENTAL_FEATURES="CSS_GRID_LAYOUT=1"

  • UIProcess/API/gtk/WebKitSettings.cpp:

(webKitSettingsConstructed): Use new experimental feature to enable or disable CSS Grid Layout.

  • UIProcess/gtk/ExperimentalFeatures.cpp: Add new experimental feature.
  • UIProcess/gtk/ExperimentalFeatures.h: Ditto.
12:43 PM Changeset in webkit [162214] by rniwa@webkit.org
  • 3 edits
    3 moves in trunk/PerformanceTests

DoYouEvenBench: Move flightjs-example-app and todomvc into resources
​https://bugs.webkit.org/show_bug.cgi?id=127183

Rubber-stamped by Anders Carlsson.

  • DoYouEvenBench/InteractiveRunner.html: Copied from PerformanceTests/DoYouEvenBench/benchmark.html.
  • DoYouEvenBench/benchmark.html: Removed.
  • DoYouEvenBench/flightjs-example-app: Removed.
  • DoYouEvenBench/flightjs-example-app/LICENSE.md: Removed.
  • DoYouEvenBench/flightjs-example-app/README.md: Removed.
  • DoYouEvenBench/flightjs-example-app/app: Removed.
  • DoYouEvenBench/flightjs-example-app/app/boot: Removed.
  • DoYouEvenBench/flightjs-example-app/app/boot/page.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_data: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_data/compose_box.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_data/mail_items.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_data/move_to.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_ui: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_ui/compose_box.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_ui/folders.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_ui/mail_controls.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_ui/mail_items.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_ui/move_to_selector.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/component_ui/with_select.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/css: Removed.
  • DoYouEvenBench/flightjs-example-app/app/css/custom.css: Removed.
  • DoYouEvenBench/flightjs-example-app/app/data.js: Removed.
  • DoYouEvenBench/flightjs-example-app/app/templates.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/css: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap-responsive.css: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap-responsive.min.css: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap.css: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/css/bootstrap.min.css: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/img: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/img/glyphicons-halflings-white.png: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/img/glyphicons-halflings.png: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/js/bootstrap.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/bootstrap/js/bootstrap.min.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/.gitignore: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/CHANGES: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/CONTRIBUTORS.md: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/LICENSE: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/README.md: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/component.json: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-sham.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-sham.min.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-shim.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/es5-shim.min.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/package.json: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers/h-kill.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers/h-matchers.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/helpers/h.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/index.html: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine-html.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine.css: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/jasmine_favicon.png: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/lib/json2.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-array.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-date.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-function.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-object.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/es5-shim/tests/spec/s-string.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/.travis.yml: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/lib: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/lib/advice.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/lib/component.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/lib/compose.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/lib/index.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/lib/logger.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/lib/registry.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/lib/utils.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/tools: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/tools/debug: Removed.
  • DoYouEvenBench/flightjs-example-app/components/flight/tools/debug/debug.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jasmine-flight: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jasmine-flight/LICENSE.md: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jasmine-flight/README.md: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jasmine-flight/bower.json: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jasmine-flight/lib: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jasmine-flight/lib/jasmine-flight.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jasmine-jquery: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jasmine-jquery/lib: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jasmine-jquery/lib/jasmine-jquery.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jquery: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jquery/component.json: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jquery/composer.json: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jquery/jquery.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/jquery/jquery.min.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/mustache: Removed.
  • DoYouEvenBench/flightjs-example-app/components/mustache/mustache.js: Removed.
  • DoYouEvenBench/flightjs-example-app/components/requirejs: Removed.
  • DoYouEvenBench/flightjs-example-app/components/requirejs/require.js: Removed.
  • DoYouEvenBench/flightjs-example-app/index.html: Removed.
  • DoYouEvenBench/flightjs-example-app/karma.conf.js: Removed.
  • DoYouEvenBench/flightjs-example-app/package.json: Removed.
  • DoYouEvenBench/flightjs-example-app/requireMain.js: Removed.
  • DoYouEvenBench/resources/benchmark-runner.js:
  • DoYouEvenBench/resources/flightjs-example-app: Copied from PerformanceTests/DoYouEvenBench/flightjs-example-app.
  • DoYouEvenBench/resources/todomvc: Copied from PerformanceTests/DoYouEvenBench/todomvc.
  • DoYouEvenBench/todomvc: Removed.
  • DoYouEvenBench/todomvc/architecture-examples: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower.json: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular-mocks: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular-mocks/angular-mocks.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/angular/angular.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.css: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/base.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/bower_components/todomvc-common/bg.png: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/index.html: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/app.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/controllers: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/controllers/todoCtrl.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoBlur.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoEscape.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/directives/todoFocus.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/services: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/js/services/todoStorage.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/readme.md: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test/config: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test/config/testacular.conf.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test/package.json: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test/readme.md: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit/directivesSpec.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/angularjs/test/unit/todoCtrlSpec.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower.json: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone.localStorage: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone.localStorage/backbone.localStorage.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/backbone/backbone.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/jquery: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/jquery/jquery.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.css: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common/base.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/todomvc-common/bg.png: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/underscore: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/bower_components/underscore/underscore.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/index.html: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/app.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/collections: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/collections/todos.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/models: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/models/todo.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/routers: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/routers/router.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/views: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/views/app-view.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/js/views/todo-view.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/backbone/readme.md: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower.json: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember-localstorage-adapter: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember-localstorage-adapter/localstorage_adapter.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/ember/ember.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/handlebars: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/handlebars/handlebars.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/jquery: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/jquery/jquery.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.css: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/base.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/bower_components/todomvc-common/bg.png: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/index.html: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/app.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/controllers: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/controllers/todo_controller.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/controllers/todos_controller.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/libs: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/libs/ember-data.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/models: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/models/store.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/models/todo.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/router.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/views: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/js/views/edit_todo_view.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/readme.md: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/emberjs/test.html: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower.json: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/handlebars: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/handlebars/handlebars.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/jquery: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/jquery/jquery.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.css: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common/base.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/bower_components/todomvc-common/bg.png: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/css: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/css/app.css: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/index.html: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/js/app.js: Removed.
  • DoYouEvenBench/todomvc/architecture-examples/jquery/readme.md: Removed.
  • DoYouEvenBench/todomvc/labs: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower.json: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/LICENSE: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/README.md: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build/director.js: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build/director.min.js: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/director/build/ender.js: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/JSXTransformer.js: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/bower.json: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/react.js: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/react/react.min.js: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/base.css: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/base.js: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/bower_components/todomvc-common/bg.png: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/index.html: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/js: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/js/app.jsx: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/js/footer.jsx: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/js/todoItem.jsx: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/js/utils.jsx: Removed.
  • DoYouEvenBench/todomvc/labs/architecture-examples/react/readme.md: Removed.
  • DoYouEvenBench/todomvc/license.md: Removed.
  • DoYouEvenBench/todomvc/readme.md: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower.json: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.css: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/base.js: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/bower_components/todomvc-common/bg.png: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/index.html: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/app.js: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/controller.js: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/helpers.js: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/model.js: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/store.js: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/js/view.js: Removed.
  • DoYouEvenBench/todomvc/vanilla-examples/vanillajs/readme.md: Removed.
  • Skipped:
12:33 PM Changeset in webkit [162213] by zoltan@webkit.org
  • 4 edits
    4 adds in trunk

[CSS3] Add rendering support for -webkit-text-align-last
​https://bugs.webkit.org/show_bug.cgi?id=99584

Reviewed by David Hyatt.

Source/WebCore:

Add support for the text-align-last CSS3 property, according to the latest specification:
​http://dev.w3.org/csswg/css-text-3/#text-align-last-property

Tests: fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify.html

fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify.html

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::textAlignmentForLine):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayout):

LayoutTests:

  • fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify-expected.html: Added.
  • fast/css3-text/css3-text-align-last/text-align-last-with-text-align-justify.html: Added.
  • fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify-expected.html: Added.
  • fast/css3-text/css3-text-align-last/text-align-last-with-text-align-non-justify.html: Added.
12:29 PM Changeset in webkit [162212] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the iOS build after <​http://trac.webkit.org/changeset/162208>
(​https://bugs.webkit.org/show_bug.cgi?id=127139)

MAC_OS_X_VERSION_MIN_REQUIRED isn't defined when building for iOS. Instead, explicitly
check that we're not PLATFORM(IOS) to avoid defining the enum value CFHTTPCookieStorageAcceptPolicyExclusivelyFromMainDocumentDomain.

  • platform/network/cf/CookieJarCFNet.cpp:
12:26 PM Changeset in webkit [162211] by berto@igalia.com
  • 2 edits in trunk/Tools

[GTK] Test /webkit/download/not-found fails in GTK Linux 64-bit Release bot
​https://bugs.webkit.org/show_bug.cgi?id=82329

Reviewed by Carlos Garcia Campos.

Unskip, this is working fine now.

  • Scripts/run-gtk-tests:

(TestRunner):

12:13 PM Changeset in webkit [162210] by betravis@adobe.com
  • 12 edits in trunk

[CSS Shapes] Basic shapes' computed position should be a horizontal and vertical offset
​https://bugs.webkit.org/show_bug.cgi?id=127010

Reviewed by Rob Buis.

Source/WebCore:

This patch updates the computed position values used for blending to be a horizontal
left offset and a vertical top offset. When positions include a center, bottom, or
right position offset, it is converted to the appropriate top/left coordinate as
a calc expression. Serialized values still use the original bottom/right directions
when present, and also omit the top/left keywords where possible.

Updated parsing and animation tests.

  • css/BasicShapeFunctions.cpp:

(WebCore::valueForCenterCoordinate): Use the simplified BasicShapeCenterCoordinate,
which includes an offset and whether the direction is from the top/left or bottom/right.
(WebCore::valueForBasicShape): Ditto.
(WebCore::convertToCenterCoordinate): Ditto.
(WebCore::basicShapeForValue): Ditto.
(WebCore::floatValueForCenterCoordinate): Ditto.

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFunc): Remove the RenderBox parameter, which is no longer needed.

  • rendering/style/BasicShapes.cpp:

(WebCore::BasicShapeCenterCoordinate::updateComputedLength): Calculate the computed
position offset for this center coordinate.
(WebCore::BasicShapeRectangle::blend): Remove the RenderBox parameter.
(WebCore::DeprecatedBasicShapeCircle::blend): Ditto.
(WebCore::BasicShapeCircle::blend): Ditto.
(WebCore::DeprecatedBasicShapeEllipse::blend): Ditto.
(WebCore::BasicShapeEllipse::blend): Ditto.
(WebCore::BasicShapePolygon::blend): Ditto.
(WebCore::BasicShapeInsetRectangle::blend): Ditto.
(WebCore::BasicShapeInset::blend): Ditto.

  • rendering/style/BasicShapes.h:

(WebCore::BasicShapeCenterCoordinate::BasicShapeCenterCoordinate): Simplify
BasicShapeCenterCoordinate to contain an offset and a direction. Also add a
computed length, which is an offset from the top/left direction.
(WebCore::BasicShapeCenterCoordinate::direction):
(WebCore::BasicShapeCenterCoordinate::computedLength):
(WebCore::BasicShapeCenterCoordinate::blend):

LayoutTests:

Update existing parsing and animation tests. For parsing tests, top / left keywords
are omitted whenever possible. For animation tests, animations to bottom / right
offsets will use calc values based from the top / left direction.

  • animations/resources/animation-test-helpers.js:

(parseBasicShape): Parse non-numerical arguments to the shape function.
(basicShapeParametersMatch): Match non-numerical arguments to the shape function.

  • fast/shapes/parsing/parsing-shape-inside-expected.txt: Update serialized values

to omit top / left keywords when possible.

  • fast/shapes/parsing/parsing-shape-outside-expected.txt: Update serialized values

to omit top / left keywords when possible.

  • fast/shapes/parsing/parsing-test-utils.js: Modify shape parsing test expectations.
  • fast/shapes/shape-outside-floats/shape-outside-animation-expected.txt: Ditto.
  • fast/shapes/shape-outside-floats/shape-outside-animation.html: Ditto.
11:55 AM Changeset in webkit [162209] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

String::is8Bit() crashes if m_impl is null, handle this.

  • API/OpaqueJSString.h:

(OpaqueJSString::OpaqueJSString):

11:34 AM Changeset in webkit [162208] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

More non-Mac build fix.

  • platform/network/cf/CookieJarCFNet.cpp:
11:32 AM Changeset in webkit [162207] by mmaxfield@apple.com
  • 3 edits
    2 adds in trunk

Unprefix text-emphasis CSS properties
​https://bugs.webkit.org/show_bug.cgi?id=127160

Reviewed by Sam Weinig.

Source/WebCore:

Add synonym CSS properties. We don't want to delete the old ones because
we've shipped with them included.

Test: fast/css3-text/css3-text-decoration/text-decoration-unprefix.html

  • css/CSSPropertyNames.in:

LayoutTests:

Add a reftest to compare the prefixed and unprefixed properties

  • fast/css3-text/css3-text-decoration/text-decoration-unprefix-expected.html: Added.
  • fast/css3-text/css3-text-decoration/text-decoration-unprefix.html: Added.
11:25 AM Changeset in webkit [162206] by andersca@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Try to fix the Windows build.

  • API/OpaqueJSString.cpp:

(OpaqueJSString::~OpaqueJSString):
(OpaqueJSString::characters):

  • API/OpaqueJSString.h:

(OpaqueJSString::OpaqueJSString):

9:44 AM Changeset in webkit [162205] by andersca@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Get rid of OpaqueJSString::deprecatedCharacters()
​https://bugs.webkit.org/show_bug.cgi?id=127161

Reviewed by Sam Weinig.

Handle OpaqueJSString::m_string being either 8-bit or 16-bit and add extra
code paths for the 8-bit cases.

Unfortunately, JSStringGetCharactersPtr is still expected to return a 16-bit character pointer.
Handle this by storing a separate 16-bit string and initializing it on demand when JSStringGetCharactersPtr
is called and the backing string is 8-bit.

This has the nice side effect of making JSStringGetCharactersPtr thread-safe when it wasn't before.
(In theory, someone could have a JSStringRef backed by an 8-bit string and call JSStringGetCharactersPtr on it
causing an unsafe upconversion to a 16-bit string).

  • API/JSStringRef.cpp:

(JSStringGetCharactersPtr):
Call OpaqueJSString::characters.

(JSStringGetUTF8CString):
Add a code path that handles 8-bit strings.

(JSStringIsEqual):
Call OpaqueJSString::equal.

  • API/JSStringRefCF.cpp:

(JSStringCreateWithCFString):
Reformat the code to use an early return instead of putting most of the code inside the body of an if statement.

(JSStringCopyCFString):
Create an 8-bit CFStringRef if possible.

  • API/OpaqueJSString.cpp:

(OpaqueJSString::create):
Use nullptr.

(OpaqueJSString::~OpaqueJSString):
Free m_characters.

(OpaqueJSString::characters):
Do the up-conversion and store the result in m_characters.

(OpaqueJSString::equal):
New helper function.

  • API/OpaqueJSString.h:

(OpaqueJSString::is8Bit):
New function that returns whether a string is 8-bit or not.

(OpaqueJSString::characters8):
(OpaqueJSString::characters16):
Add getters.

9:34 AM Changeset in webkit [162204] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

Support WebSelections in WK2 on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=127015
<rdar://problem/15843090>

Reviewed by Dan Bernstein.

Removing unused variable in selectWithGesture that
causes Release build to fail after r162103.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::selectWithGesture):

9:21 AM Changeset in webkit [162203] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=127138
Add more delegate callback methods to WKWebProcessPlugInLoadDelegate.

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2014-01-17
Reviewed by Sam Weinig.

Add more WKWebProcessPlugInLoadDelegate callback methods so that a injected
bundle can listen/react to more frame loading events.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInLoadDelegate.h: Add more delegate callback methods for

WKWebProcessPlugInLoadDelegate.

  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(didCommitLoadForFrame):
(didFinishDocumentLoadForFrame):
(didFailLoadWithErrorForFrame):
(didSameDocumentNavigationForFrame):
(didLayoutForFrame):
(setUpPageLoaderClient):

8:00 AM Changeset in webkit [162202] by Michał Pakuła vel Rutka
  • 5 edits in trunk/LayoutTests

Unreviewed EFL gardening

  • platform/efl/js/dom/dom-static-property-for-in-iteration-expected.txt: Rebaseline after r153772 and r154057.
  • platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Rebaseline after r153772 and r154127.
  • platform/efl/js/dom/global-constructors-attributes-expected.txt: Ditto.
  • platform/efl/js/dom/global-constructors-attributes-shared-worker-expected.txt: Ditto.
6:37 AM Changeset in webkit [162201] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore

[GTK] WebKitGtk/testcopyandpaste fails in debug builds
​https://bugs.webkit.org/show_bug.cgi?id=127173

Reviewed by Carlos Garcia Campos.

Remove duplicate "PasteGlobalSelection" entry.

  • editing/EditorCommand.cpp:

(WebCore::createCommandMap):

6:32 AM Changeset in webkit [162200] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Pack ResourceRequest harder.
<​https://webkit.org/b/126982>

Re-arrange the members of ResourceRequest to reduce padding,
shrinking it by 8 bytes.

Reviewed by Anders Carlsson.

  • platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::ResourceRequestBase):

6:04 AM Changeset in webkit [162199] by berto@igalia.com
  • 2 edits in trunk/Tools

[GTK] Test /webkit/webview/icon-uri times out in GTK Linux 64-bit Release bot
​https://bugs.webkit.org/show_bug.cgi?id=82328

Reviewed by Carlos Garcia Campos.

This was caused by the icon database being corrupted in the
Release bot. After removing it the test works fine so it can be
run again.

  • Scripts/run-gtk-tests:

(TestRunner):

4:24 AM Changeset in webkit [162198] by commit-queue@webkit.org
  • 60 edits in trunk/Source

Remove workaround for compilers not supporting deleted functions
​https://bugs.webkit.org/show_bug.cgi?id=127166

Patch by Peter Molnar <​pmolnar.u-szeged@partner.samsung.com> on 2014-01-17
Reviewed by Andreas Kling.

Source/JavaScriptCore:

  • inspector/InspectorAgentRegistry.h:

Source/WebCore:

  • bindings/js/JSLazyEventListener.h:
  • dom/ContainerNode.h:
  • dom/Document.h:
  • dom/Element.h:
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.h:
  • rendering/RenderButton.h:
  • rendering/RenderCombineText.h:
  • rendering/RenderElement.h:
  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderFrame.h:
  • rendering/RenderFrameBase.h:
  • rendering/RenderFrameSet.h:
  • rendering/RenderHTMLCanvas.h:
  • rendering/RenderIFrame.h:
  • rendering/RenderLineBreak.h:
  • rendering/RenderListBox.h:
  • rendering/RenderListMarker.h:
  • rendering/RenderMedia.h:
  • rendering/RenderMenuList.h:
  • rendering/RenderSnapshottedPlugIn.h:
  • rendering/RenderTableCell.h:
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.h:
  • rendering/RenderText.h:
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderVideo.h:
  • rendering/RenderWidget.h:
  • rendering/svg/RenderSVGBlock.h:
  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGImage.h:
  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGRect.h:
  • rendering/svg/RenderSVGResourceClipper.h:
  • rendering/svg/RenderSVGResourceFilter.h:
  • rendering/svg/RenderSVGResourceFilterPrimitive.h:
  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourceLinearGradient.h:
  • rendering/svg/RenderSVGResourceMarker.h:
  • rendering/svg/RenderSVGResourceMasker.h:
  • rendering/svg/RenderSVGResourcePattern.h:
  • rendering/svg/RenderSVGResourceRadialGradient.h:
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGShape.h:
  • rendering/svg/RenderSVGTSpan.h:
  • rendering/svg/RenderSVGText.h:
  • rendering/svg/RenderSVGTextPath.h:
  • rendering/svg/RenderSVGTransformableContainer.h:
  • rendering/svg/RenderSVGViewportContainer.h:
  • xml/XPathValue.h:

Source/WTF:

  • wtf/Compiler.h:
  • wtf/Noncopyable.h:
  • wtf/PassRefPtr.h:
3:46 AM WebKitGTK/2.2.x edited by ltilve@igalia.com
(diff)
3:02 AM Changeset in webkit [162197] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

[ATK] Modernize the for loops in ATK AX code
​https://bugs.webkit.org/show_bug.cgi?id=127120

Reviewed by Mario Sanchez Prada.

Update the for loops to be range-based in ATK accessibility code.
This work is complementary to r161979.

  • accessibility/atk/WebKitAccessibleInterfaceHypertext.cpp:

(webkitAccessibleHypertextGetLink):

  • accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(webkitAccessibleTableGetColumnHeader):
(webkitAccessibleTableGetRowHeader):

  • accessibility/atk/WebKitAccessibleUtil.cpp:

(accessibilityTitle):
(accessibilityDescription):

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(getNChildrenForTable):
(getChildForTable):
(getIndexInParentForCellInRow):

1:41 AM Changeset in webkit [162196] by Michał Pakuła vel Rutka
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Fix wrong test expectations added in r162128.

  • platform/efl-wk2/TestExpectations:
1:23 AM Changeset in webkit [162195] by rniwa@webkit.org
  • 2 edits in trunk/PerformanceTests

Build fix. Skip HTML files that are not tests.

  • Skipped:
1:18 AM Changeset in webkit [162194] by g.czajkowski@samsung.com
  • 9 edits in trunk/LayoutTests

Allow grammar checking tests to be able to run asynchronously
​https://bugs.webkit.org/show_bug.cgi?id=127099

Reviewed by Ryosuke Niwa.

Some grammar checking tests have already used asynchronous text checking path.
Due to WebKit tends to use asynchronous spell checking, this patch adapts grammar
checking tests that used synchronous path to be able to run asynchronously.

Additionally, the tests description was fixed.

  • editing/spelling/grammar-edit-word-expected.txt:
  • editing/spelling/grammar-edit-word.html:
  • editing/spelling/grammar-expected.txt:
  • editing/spelling/grammar-markers.html:
  • editing/spelling/grammar.html:
  • editing/spelling/markers-expected.txt:
  • editing/spelling/markers.html:
  • platform/mac-wk2/TestExpectations:

Marking markers.html as failing for mac-wk2 due to bug 125690.

1:15 AM Changeset in webkit [162193] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

[Soup] Remove unnecessary using-directives for the std namespace
​https://bugs.webkit.org/show_bug.cgi?id=127122

Reviewed by Martin Robinson.

  • platform/network/soup/ResourceRequestSoup.cpp: Remove the unnecessary using-directive for the std namespace

as no symbols from that namespace are in use in this implementation file.

  • platform/network/soup/ResourceResponseSoup.cpp: Ditto.
12:16 AM Changeset in webkit [162192] by commit-queue@webkit.org
  • 5 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r162185, r162186, and r162187.
​http://trac.webkit.org/changeset/162185
​http://trac.webkit.org/changeset/162186
​http://trac.webkit.org/changeset/162187
​https://bugs.webkit.org/show_bug.cgi?id=127164

Broke JSStringCreateWithCharactersNoCopy, as evidenced by a
JSC API test (Requested by ap on #webkit).

  • API/JSStringRef.cpp:

(JSStringGetCharactersPtr):
(JSStringGetUTF8CString):
(JSStringIsEqual):

  • API/JSStringRefCF.cpp:

(JSStringCreateWithCFString):
(JSStringCopyCFString):

  • API/OpaqueJSString.cpp:

(OpaqueJSString::create):
(OpaqueJSString::identifier):

  • API/OpaqueJSString.h:

(OpaqueJSString::create):
(OpaqueJSString::characters):
(OpaqueJSString::deprecatedCharacters):
(OpaqueJSString::OpaqueJSString):

Jan 16, 2014:

11:59 PM Changeset in webkit [162191] by ap@apple.com
  • 5 edits in trunk/Tools

Test results popovers at ​http://build.webkit.org/dashboard should link to stderr
​https://bugs.webkit.org/show_bug.cgi?id=126929

Reviewed by Timothy Hatcher.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:

(Buildbot.prototype.layoutTestCrashLogURLForIteration): Renamed for consistency.
(Buildbot.prototype.layoutTestStderrURLForIteration): Added.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration.prototype.loadLayoutTestResults): Store has_stderr attribute.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTesterQueueView.js:

(BuildbotTesterQueueView.prototype._popoverContentForLayoutTestRegressions):
Add a link to stderr output if present.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/QueueView.css:

(.test-results-popover .additional-link): Style with light grey (will use the same style
for diff links).

11:50 PM Changeset in webkit [162190] by Carlos Garcia Campos
  • 7 edits
    4 adds in trunk/Source/WebKit2

[SOUP] Add stubs for CustomProtocol classes
​https://bugs.webkit.org/show_bug.cgi?id=126343

Reviewed by Gustavo Noronha Silva.

  • CMakeLists.txt:
  • GNUmakefile.am:
  • GNUmakefile.list.am:
  • PlatformGTK.cmake:
  • Shared/Network/CustomProtocols/soup/CustomProtocolManagerSoup.cpp: Added.

(WebKit::generateCustomProtocolID):
(WebKit::WebSoupRequestAsyncData::WebSoupRequestAsyncData):
(WebKit::WebSoupRequestAsyncData::~WebSoupRequestAsyncData):
(WebKit::WebSoupRequestAsyncData::requestFailed):
(WebKit::WebSoupRequestAsyncData::releaseTask):
(WebKit::CustomProtocolManager::supplementName):
(WebKit::CustomProtocolManager::CustomProtocolManager):
(WebKit::CustomProtocolManager::initializeConnection):
(WebKit::CustomProtocolManager::initialize):

  • Shared/Network/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode): Move
urlSchemesRegisteredForCustomProtocols encoding out of platform
ifdefs, since it's already guarded by ENABLE(CUSTOM_PROTOCOLS).
(WebKit::NetworkProcessCreationParameters::decode): Ditto.

  • Shared/Network/NetworkProcessCreationParameters.h: Ditto.
  • UIProcess/Network/CustomProtocols/soup/CustomProtocolManagerProxySoup.cpp: Added.

(WebKit::CustomProtocolManagerProxy::CustomProtocolManagerProxy):
(WebKit::CustomProtocolManagerProxy::startLoading):
(WebKit::CustomProtocolManagerProxy::stopLoading):

11:31 PM Changeset in webkit [162189] by timothy_horton@apple.com
  • 6 edits in trunk/Source

On iOS, zooming in with a TileController-backed main frame makes hundreds of tiles
​https://bugs.webkit.org/show_bug.cgi?id=126531
<rdar://problem/15745862>

Reviewed by Anders Carlsson.

Source/WebCore:

  • platform/graphics/ca/mac/TileController.h:
  • platform/graphics/ca/mac/TileController.mm:

(WebCore::TileController::tilesWouldChangeForVisibleRect):
(WebCore::TileController::scaledExposedRect):
(WebCore::TileController::computeTileCoverageRect):
(WebCore::TileController::revalidateTiles):
(WebCore::TileController::updateTileCoverageMap):
Scale the FrameView-space exposedRect into document space, to match the visibleRect.

Flipping on WKView's clipsToExposedRect now works correctly even in Safari
or MiniBrowser with zooming.

Source/WebKit2:

  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _updateViewExposedRect]):
(-[WKContentView setViewportSize:]):
(-[WKContentView didFinishScrollTo:]):
(-[WKContentView didScrollTo:]):
(-[WKContentView didZoomToScale:]):
Because zooming is performed by the UIScrollView, we need to transform
the exposedRect's offset in order to get it in FrameView-relative coordinates.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::didFinishZooming):
Save the pageScaleFactor when it changes.

11:19 PM Changeset in webkit [162188] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK] Remove the weak pointer added to the web view in WebKitPrintOperation
​https://bugs.webkit.org/show_bug.cgi?id=127098

Reviewed by Martin Robinson.

If the print operation finishes and the web view is still alive,
the weak pointer added to the view should be removed.

  • UIProcess/API/gtk/WebKitPrintOperation.cpp:

(_WebKitPrintOperationPrivate::~_WebKitPrintOperationPrivate):

11:08 PM Changeset in webkit [162187] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Export OpaqueJSString destructor.

  • API/OpaqueJSString.h:
11:05 PM Changeset in webkit [162186] by andersca@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Build fix.

  • API/OpaqueJSString.h:
10:50 PM Changeset in webkit [162185] by andersca@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Get rid of OpaqueJSString::deprecatedCharacters()
​https://bugs.webkit.org/show_bug.cgi?id=127161

Reviewed by Sam Weinig.

Handle OpaqueJSString::m_string being either 8-bit or 16-bit and add extra
code paths for the 8-bit cases.

Unfortunately, JSStringGetCharactersPtr is still expected to return a 16-bit character pointer.
Handle this by storing a separate 16-bit string and initializing it on demand when JSStringGetCharactersPtr
is called. This has the nice side effect of making JSStringGetCharactersPtr thread-safe when it wasn't before.
(In theory, someone could have a JSStringRef backed by an 8-bit string and call JSStringGetCharactersPtr on it
causing an unsafe upconversion to a 16-bit string).

  • API/JSStringRef.cpp:

(JSStringGetCharactersPtr):
Call OpaqueJSString::characters.

(JSStringGetUTF8CString):
Add a code path that handles 8-bit strings.

(JSStringIsEqual):
Call OpaqueJSString::equal.

  • API/JSStringRefCF.cpp:

(JSStringCreateWithCFString):
Reformat the code to use an early return instead of putting most of the code inside the body of an if statement.

(JSStringCopyCFString):
Create an 8-bit CFStringRef if possible.

  • API/OpaqueJSString.cpp:

(OpaqueJSString::create):
Use nullptr.

(OpaqueJSString::~OpaqueJSString):
Free m_characters.

(OpaqueJSString::characters):
Do the up-conversion and store the result in m_characters.

(OpaqueJSString::equal):
New helper function.

  • API/OpaqueJSString.h:

(OpaqueJSString::is8Bit):
New function that returns whether a string is 8-bit or not.

(OpaqueJSString::characters8):
(OpaqueJSString::characters16):
Add getters.

10:22 PM Changeset in webkit [162184] by weinig@apple.com
  • 15 edits in trunk/Source

TextBreakIterator's should support Latin-1 for all iterator types (Part 3)
​https://bugs.webkit.org/show_bug.cgi?id=126856

Reviewed by Ryosuke Niwa.

Change all the TextBreakIterator creation functions to take StringViews. Remove a few
now unnecessary up-conversions to UTF-16 in the process.

../WebCore:

  • dom/CharacterData.cpp:
  • editing/TextCheckingHelper.cpp:
  • editing/VisibleUnits.cpp:
  • platform/graphics/StringTruncator.cpp:
  • platform/graphics/mac/ComplexTextController.cpp:
  • platform/text/TextBoundaries.cpp:
  • platform/text/TextBreakIterator.cpp:
  • platform/text/TextBreakIterator.h:
  • rendering/RenderText.cpp:

../WebKit/ios:

  • Misc/WebNSStringDrawing.mm:

../WebKit2:

  • UIProcess/efl/TextCheckerEfl.cpp:

(WebKit::nextWordOffset):
(WebKit::TextChecker::checkTextOfParagraph):

10:06 PM Changeset in webkit [162183] by rniwa@webkit.org
  • 9 edits in trunk

Automate DoYouEvenBench
​https://bugs.webkit.org/show_bug.cgi?id=124497

Reviewed by Geoffrey Garen.

PerformanceTests:

Enable DoYouEvenBench/Full.html on perf bots by default.

Put a space between the time and ms, and fixed a typo in runner.js so that the aggregator name will be reported.

  • DoYouEvenBench/Full.html:
  • Skipped:
  • resources/runner.js:

Tools:

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTestMetric.init): Added the aggregator name as an argument.
(PerfTestMetric.aggregator): Added.
(PerfTest._metrics_regex): Made the subtest name match non-greedy so that the metric names will be
won't be eagerly parsed as a part of the subtest name. e.g. "Time" and "Total" in "a:Time:Total"
should be parsed as the metric and the aggregator respectively.
(PerfTest._run_with_driver): Pass in the aggregator name.
(PerfTest._ensure_metrics): Ditto. Also split the subtest name by / as required by DoYouEvenBench
which generates subtests of subtests within a single test file.

  • Scripts/webkitpy/performance_tests/perftest_unittest.py:

(test_parse_output_with_subtests_and_total): Added.

  • Scripts/webkitpy/performance_tests/perftestsrunner.py:

(_generate_results_dict): Add the aggregator name to the JSON when one is available.

  • Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:

(TestWithSubtestsData): Added a sub test with an aggregator and a sub-sub test.

9:27 PM Changeset in webkit [162182] by eunmi15.lee@samsung.com
  • 2 edits in trunk/Source/WebKit2

[EFL][WK2] EwkView can not be shown without re-sizing once it is hidden.
​https://bugs.webkit.org/show_bug.cgi?id=127084

Reviewed by Gyuyoung Kim.

Visibility of EwkView can not be controlled by evas_object_show/hide
because EwkView can be shown only if re-sizing is requested, so modify
codes to show EwkView directly if we do not wait for re-sizing.
Additionally, we have to set default value of m_pendingSurfaceResize
to true for accelerated mode to prevent to show black empty view for
the first request to show.

  • UIProcess/API/efl/EwkView.cpp:

(EwkView::EwkView):
(EwkView::handleEvasObjectShow):

7:42 PM Changeset in webkit [162181] by fpizlo@apple.com
  • 1 edit
    3 deletes in branches/jsCStack/LayoutTests

Unreviewed, remove sstepanov_container because it is too slow.

  • js/regress/script-tests/stepanov_container.js: Removed.
  • js/regress/stepanov_container-expected.txt: Removed.
  • js/regress/stepanov_container.html: Removed.
7:23 PM Changeset in webkit [162180] by andersca@apple.com
  • 209 edits in trunk/Source/WebCore

Run clang-modernize and let it add a bunch of missing overrides.

Rubber-stamped by Sam Weinig.

  • dom/BeforeLoadEvent.h:
  • dom/ClassNodeList.h:
  • dom/Comment.h:
  • dom/CompositionEvent.h:
  • dom/DecodedDataDocumentParser.h:
  • dom/DeviceMotionEvent.h:
  • dom/DeviceOrientationEvent.h:
  • dom/DocumentMarker.cpp:
  • dom/DocumentType.h:
  • dom/EntityReference.h:
  • dom/FocusEvent.h:
  • dom/HashChangeEvent.h:
  • dom/MessageEvent.h:
  • dom/MouseEvent.h:
  • dom/MouseRelatedEvent.h:
  • dom/MutationEvent.h:
  • dom/NameNodeList.h:
  • dom/Notation.h:
  • dom/OverflowEvent.h:
  • dom/PendingScript.h:
  • dom/PopStateEvent.h:
  • dom/ProcessingInstruction.h:
  • dom/ScriptElement.h:
  • dom/ScriptExecutionContext.cpp:
  • dom/ScriptableDocumentParser.h:
  • dom/ScriptedAnimationController.h:
  • dom/StringCallback.cpp:
  • dom/WheelEvent.h:
  • html/FTPDirectoryDocument.h:
  • html/FileInputType.cpp:
  • html/HTMLAppletElement.h:
  • html/HTMLBRElement.h:
  • html/HTMLBaseElement.h:
  • html/HTMLBodyElement.h:
  • html/HTMLButtonElement.h:
  • html/HTMLDocument.h:
  • html/HTMLEmbedElement.h:
  • html/HTMLFormControlsCollection.h:
  • html/HTMLFrameElement.h:
  • html/HTMLFrameSetElement.h:
  • html/HTMLHRElement.h:
  • html/HTMLIFrameElement.h:
  • html/HTMLKeygenElement.cpp:
  • html/HTMLKeygenElement.h:
  • html/HTMLLinkElement.h:
  • html/HTMLMarqueeElement.h:
  • html/HTMLObjectElement.h:
  • html/HTMLOutputElement.h:
  • html/HTMLParamElement.h:
  • html/HTMLScriptElement.h:
  • html/HTMLStyleElement.h:
  • html/HTMLSummaryElement.h:
  • html/HTMLTrackElement.h:
  • html/HTMLViewSourceDocument.h:
  • html/ImageDocument.cpp:
  • html/ImageDocument.h:
  • html/MediaDocument.cpp:
  • html/MediaDocument.h:
  • html/MediaKeyEvent.h:
  • html/PluginDocument.cpp:
  • html/RadioNodeList.h:
  • html/TextDocument.h:
  • html/canvas/EXTDrawBuffers.h:
  • html/canvas/EXTTextureFilterAnisotropic.h:
  • html/canvas/OESElementIndexUint.h:
  • html/canvas/OESStandardDerivatives.h:
  • html/canvas/OESTextureFloat.h:
  • html/canvas/OESTextureFloatLinear.h:
  • html/canvas/OESTextureHalfFloat.h:
  • html/canvas/OESTextureHalfFloatLinear.h:
  • html/canvas/OESVertexArrayObject.h:
  • html/canvas/WebGLBuffer.h:
  • html/canvas/WebGLCompressedTextureATC.h:
  • html/canvas/WebGLCompressedTexturePVRTC.h:
  • html/canvas/WebGLCompressedTextureS3TC.h:
  • html/canvas/WebGLContextEvent.h:
  • html/canvas/WebGLContextObject.h:
  • html/canvas/WebGLDebugRendererInfo.h:
  • html/canvas/WebGLDebugShaders.h:
  • html/canvas/WebGLDepthTexture.h:
  • html/canvas/WebGLFramebuffer.cpp:
  • html/canvas/WebGLFramebuffer.h:
  • html/canvas/WebGLLoseContext.h:
  • html/canvas/WebGLProgram.h:
  • html/canvas/WebGLRenderbuffer.h:
  • html/canvas/WebGLRenderingContext.cpp:
  • html/canvas/WebGLRenderingContext.h:
  • html/canvas/WebGLShader.h:
  • html/canvas/WebGLSharedObject.h:
  • html/canvas/WebGLTexture.h:
  • html/canvas/WebGLVertexArrayObjectOES.h:
  • html/parser/HTMLDocumentParser.h:
  • html/parser/HTMLViewSourceParser.h:
  • html/shadow/DetailsMarkerControl.h:
  • html/shadow/MediaControls.h:
  • html/shadow/MediaControlsApple.h:
  • html/shadow/MeterShadowElement.h:
  • html/shadow/ProgressShadowElement.h:
  • html/shadow/SliderThumbElement.h:
  • html/track/LoadableTextTrack.h:
  • html/track/TrackEvent.h:
  • svg/SVGAElement.h:
  • svg/SVGAnimateColorElement.h:
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimateMotionElement.h:
  • svg/SVGAnimateTransformElement.h:
  • svg/SVGAnimationElement.h:
  • svg/SVGCircleElement.h:
  • svg/SVGClipPathElement.h:
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGCursorElement.h:
  • svg/SVGDefsElement.h:
  • svg/SVGDescElement.h:
  • svg/SVGEllipseElement.h:
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEDistantLightElement.h:
  • svg/SVGFEDropShadowElement.h:
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.h:
  • svg/SVGFELightElement.h:
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFEPointLightElement.h:
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFESpotLightElement.h:
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGFontData.h:
  • svg/SVGForeignObjectElement.h:
  • svg/SVGGlyphElement.h:
  • svg/SVGGlyphRefElement.h:
  • svg/SVGGradientElement.h:
  • svg/SVGHKernElement.h:
  • svg/SVGImageElement.h:
  • svg/SVGImageLoader.h:
  • svg/SVGLineElement.h:
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMPathElement.h:
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.h:
  • svg/SVGMissingGlyphElement.h:
  • svg/SVGPathBuilder.h:
  • svg/SVGPathByteStreamBuilder.h:
  • svg/SVGPathByteStreamSource.h:
  • svg/SVGPathElement.h:
  • svg/SVGPathSegArcAbs.h:
  • svg/SVGPathSegArcRel.h:
  • svg/SVGPathSegClosePath.h:
  • svg/SVGPathSegCurvetoCubicAbs.h:
  • svg/SVGPathSegCurvetoCubicRel.h:
  • svg/SVGPathSegCurvetoCubicSmoothAbs.h:
  • svg/SVGPathSegCurvetoCubicSmoothRel.h:
  • svg/SVGPathSegCurvetoQuadraticAbs.h:
  • svg/SVGPathSegCurvetoQuadraticRel.h:
  • svg/SVGPathSegCurvetoQuadraticSmoothAbs.h:
  • svg/SVGPathSegCurvetoQuadraticSmoothRel.h:
  • svg/SVGPathSegLinetoAbs.h:
  • svg/SVGPathSegLinetoHorizontalAbs.h:
  • svg/SVGPathSegLinetoHorizontalRel.h:
  • svg/SVGPathSegLinetoRel.h:
  • svg/SVGPathSegLinetoVerticalAbs.h:
  • svg/SVGPathSegLinetoVerticalRel.h:
  • svg/SVGPathSegListBuilder.h:
  • svg/SVGPathSegListSource.h:
  • svg/SVGPathSegMovetoAbs.h:
  • svg/SVGPathSegMovetoRel.h:
  • svg/SVGPathStringSource.h:
  • svg/SVGPathTraversalStateBuilder.h:
  • svg/SVGPatternElement.h:
  • svg/SVGPolyElement.h:
  • svg/SVGRadialGradientElement.h:
  • svg/SVGRectElement.h:
  • svg/SVGSVGElement.h:
  • svg/SVGScriptElement.h:
  • svg/SVGStopElement.h:
  • svg/SVGStyleElement.h:
  • svg/SVGSwitchElement.h:
  • svg/SVGSymbolElement.h:
  • svg/SVGTRefElement.h:
  • svg/SVGTSpanElement.h:
  • svg/SVGTextContentElement.h:
  • svg/SVGTextElement.h:
  • svg/SVGTextPathElement.h:
  • svg/SVGTextPositioningElement.h:
  • svg/SVGTitleElement.h:
  • svg/SVGUseElement.h:
  • svg/SVGVKernElement.h:
  • svg/SVGViewElement.h:
  • svg/SVGZoomEvent.h:
  • svg/animation/SVGSMILElement.cpp:
  • svg/animation/SVGSMILElement.h:
  • svg/graphics/SVGImageChromeClient.h:
  • svg/graphics/filters/SVGFEImage.h:
  • svg/graphics/filters/SVGFilter.h:
  • svg/properties/SVGAnimatedEnumerationPropertyTearOff.h:
  • svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:
  • svg/properties/SVGPathSegListPropertyTearOff.h:
6:32 PM Changeset in webkit [162179] by Chris Fleizach
  • 2 edits in trunk/Tools

platform/mac/accessibility/aria-multiline.html sometimes asserts in AccessibilityController::removeNotificationListener
​https://bugs.webkit.org/show_bug.cgi?id=127141

Reviewed by Alexey Proskuryakov.

Don't assert that the notification handler needs to be cleaned up. Deallocing the controller should be enough to clean up as it is.

  • DumpRenderTree/mac/AccessibilityControllerMac.mm:

(AccessibilityController::~AccessibilityController):

6:12 PM Changeset in webkit [162178] by jer.noble@apple.com
  • 8 edits in trunk

REGRESSION(r162145): media/video-controls-visible-audio-only.html fails
​https://bugs.webkit.org/show_bug.cgi?id=127147

Source/WebCore:

Reviewed by Eric Carlson.

Reset the MediaSessionManager's restrictions to their default values before
each run.

Add a new virtual method "resetRestrictions()" so that each port-specific
MediaSessionManager can reset the restrictions to their default values.
Call this from Internals::resetToConsistentState() so that tests which change
the restrictions don't affect later tests.

  • platform/audio/MediaSessionManager.cpp:

(WebCore::MediaSessionManager::MediaSessionManager):
(WebCore::MediaSessionManager::resetRestrictions):

  • platform/audio/MediaSessionManager.h:

(WebCore::MediaSessionManager::~MediaSessionManager):

  • platform/audio/ios/MediaSessionManagerIOS.h:
  • platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::resetRestrictions):

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):

LayoutTests:

Re-enable media/video-controls-visible-audio-only.html.

Reviewed by Eric Carlson.

  • platform/mac/TestExpectations:
5:58 PM Changeset in webkit [162177] by aestes@apple.com
  • 3 edits in trunk/Source/WebKit2

Build Fix: Use standard architectures when building for iOS

Even though we don't use the plug-in services on iOS, we still need
them to build (we won't install them). Be sure we specify valid iOS
architectures when doing so.

  • Configurations/PluginService.32.xcconfig:
  • Configurations/PluginService.64.xcconfig:
5:51 PM Changeset in webkit [162176] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Compile fix for WinCairo after r162138.
​https://bugs.webkit.org/show_bug.cgi?id=127140

Patch by Alex Christensen <​achristensen@webkit.org> on 2014-01-16
Reviewed by Beth Dakin.

  • page/FrameView.cpp:

(WebCore::FrameView::extendedBackgroundRect):
Use unscaledDocumentRect for extendedBackgroundRect without accelerated compositing.

5:45 PM Changeset in webkit [162175] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash when destroying WKInteractionView.
​https://bugs.webkit.org/show_bug.cgi?id=127153
<rdar://problem/15840761>

Reviewed by Anders Carlsson.

UIWKSelectionAssistant is a RetainPtr and it is being
deallocated after the view and its gesture recognizers
have been destroyed.
The parent class UIWebSelectionAssistant assumes to be
deallocated before the view is gone.
We deallocate the interaction assistants explicitly to
fix the problem.

  • UIProcess/API/ios/WKInteractionView.mm:

(-[WKInteractionView dealloc]):

5:20 PM Changeset in webkit [162174] by beidson@apple.com
  • 14 edits in trunk/Source

IDB: delete object store support
<rdar://problem/15779641> and ​https://bugs.webkit.org/show_bug.cgi?id=127123

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • Modules/indexeddb/IDBTransactionBackendOperations.h:

(WebCore::DeleteObjectStoreOperation::transaction):

Source/WebKit2:

Pipe through Web -> Database -> Web process messaging for delete object store.
Perform dropping the object store in the backing store.

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:

(WebKit::DatabaseProcessIDBConnection::deleteObjectStore):

  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.messages.in:
  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::didDeleteObjectStore):
(WebKit::UniqueIDBDatabase::deleteObjectStore):
(WebKit::UniqueIDBDatabase::deleteObjectStoreInBackingStore):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
  • DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:
  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteObjectStore):

  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.cpp:

(WebKit::WebIDBServerConnection::deleteObjectStore):
(WebKit::WebIDBServerConnection::didDeleteObjectStore):

  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.messages.in:
5:09 PM Changeset in webkit [162173] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

[iOS] MobileSafari build fix. Declare iOS-specific method mainFrameIconURL

For now, add mainFrameIconURL() to WebView.h. We should further investigate its
usage and API/SPI status.

  • WebView/WebView.h:
5:04 PM Changeset in webkit [162172] by benjamin@webkit.org
  • 4 edits
    2 deletes in trunk/Source/WTF

Remove Nix from WTF
​https://bugs.webkit.org/show_bug.cgi?id=127150

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-01-16
Reviewed by Alexey Proskuryakov.

  • wtf/DisallowCType.h:
  • wtf/FeatureDefines.h:
  • wtf/Platform.h:
  • wtf/PlatformNix.cmake: Removed.
  • wtf/nix: Removed.
4:59 PM Changeset in webkit [162171] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

More non-Mac build fix.

  • platform/network/cf/CookieJarCFNet.cpp:

(WebCore::copyCookiesForURLWithFirstPartyURL):

4:46 PM Changeset in webkit [162170] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix.

  • platform/network/cf/CookieJarCFNet.cpp: Remove a spurious semicolon.
4:41 PM Changeset in webkit [162169] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Another iOS build fix.

  • platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::m_objcObserver):

4:40 PM Changeset in webkit [162168] by matthew_hanson@apple.com
  • 5 edits in branches/safari-537.74-branch/Source

Versioning.

4:38 PM Changeset in webkit [162167] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-537.74.8

New Tag.

4:33 PM Changeset in webkit [162166] by ap@apple.com
  • 18 edits in trunk

[Mac] [iOS] Add support for CFHTTPCookieStorageAcceptPolicyExclusivelyFromMainDocumentDomain
​https://bugs.webkit.org/show_bug.cgi?id=127139

Reviewed by Brady Eidson.

Source/WebCore:

  • platform/ios/WebCoreSystemInterfaceIOS.mm:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Pass first party URL down, because reading cookies depends on it when this policy
in in action.

  • platform/network/cf/CookieJarCFNet.cpp:

(WebCore::copyCookiesForURLWithFirstPartyURL):
(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
Use a new CFNetwork API that takes first party URL.

  • platform/network/mac/CookieJarMac.mm:

(WebCore::cookiesForDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
Pass first party URL (and null in deleteCookie, as there is none).

  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::platformLoadResourceSynchronously):
Removed a call to shouldRelaxThirdPartyCookiePolicy(), which no longer exists
in trunk.

Source/WebKit/mac:

  • WebView/WebPreferences.mm: (-[WebPreferences _synchronizeWebStoragePolicyWithCookiePolicy]):

Handle the new case.

Source/WebKit2:

  • Shared/HTTPCookieAcceptPolicy.h:
  • UIProcess/API/C/WKAPICast.h:

(WebKit::toHTTPCookieAcceptPolicy):
(WebKit::toAPI):

  • UIProcess/API/C/WKCookieManager.h:

Added the policy to appropriate switches and enums.

WebKitLibraries:

  • WebKitSystemInterface.h:
  • libWebKitSystemInterfaceLion.a:
  • libWebKitSystemInterfaceMavericks.a:
  • libWebKitSystemInterfaceMountainLion.a:

Update WebKitSystemInterface.

4:22 PM Changeset in webkit [162165] by ljaehun.lim@samsung.com
  • 4 edits in trunk/Source/WebKit

Use final instead of FINAL

Unreviewed build fix.

Source/WebKit/efl:

  • WebCoreSupport/ProgressTrackerClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/ProgressTrackerClientGtk.h:
4:13 PM Changeset in webkit [162164] by aestes@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the iOS build after r162150.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::platformInit):

3:59 PM Changeset in webkit [162163] by jpfau@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix build after r162161. One FINAL was still present.

  • Shared/cf/KeyedDecoder.h:
3:55 PM Changeset in webkit [162162] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit/mac

[iOS] Fix UIKit build warning about undefined macro ENABLE_NETSCAPE_PLUGIN_API

  • WebView/WebFramePrivate.h: Wrap use of ENABLE_NETSCAPE_PLUGIN_API in TARGET_OS_IPHONE.
3:28 PM Changeset in webkit [162161] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Remove FINAL macro
​https://bugs.webkit.org/show_bug.cgi?id=127149

Reviewed by Tim Horton.

  • wtf/Compiler.h:
3:25 PM Changeset in webkit [162160] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

glReadPixels should use UNSIGNED_BYTE on iOS
​https://bugs.webkit.org/show_bug.cgi?id=127148

Reviewed by Benjamin Poulain.

We were incorrectly mapping GL_UNSIGNED_INT_8_8_8_8_REV to
GL_RGBA on iOS. It's only used in glReadPixels, so should
be GL_UNSIGNED_BYTE.

This is covered by lots of tests in the Khronos test suite,
that now pass on iOS.

  • platform/graphics/ios/GraphicsContext3DIOS.h:
3:15 PM Changeset in webkit [162159] by rniwa@webkit.org
  • 3 edits in trunk/Tools

EWS shouldn't comment on Bugzilla for failing builds or style errors
​https://bugs.webkit.org/show_bug.cgi?id=127079

Reviewed by Anders Carlsson.

Since patch authors and reviewers could retrieve this information from bubbles,
we shouldn't spam the Bugzilla with useless comments.

We still post style errors but not python paths we used since it's a pure noise.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem._post_reject_message_on_bug):

  • Scripts/webkitpy/tool/commands/queues.py:

(StyleQueue.review_patch):

3:08 PM Changeset in webkit [162158] by andersca@apple.com
  • 563 edits in trunk/Source

Change all uses of FINAL to final now that all our compilers support it
​https://bugs.webkit.org/show_bug.cgi?id=127142

Reviewed by Benjamin Poulain.

Source/JavaScriptCore:

  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/agents/InspectorAgent.h:
  • inspector/remote/RemoteInspector.h:
  • inspector/remote/RemoteInspectorDebuggableConnection.h:
  • inspector/scripts/CodeGeneratorInspector.py:

(Generator.go):

  • runtime/JSGlobalObjectDebuggable.h:
  • runtime/JSPromiseReaction.cpp:

Source/WebCore:

  • Modules/encryptedmedia/MediaKeySession.h:
  • Modules/indexeddb/IDBCursorBackendOperations.h:
  • Modules/indexeddb/IDBDatabase.h:
  • Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
  • Modules/indexeddb/IDBRequest.h:
  • Modules/indexeddb/IDBTransaction.h:
  • Modules/indexeddb/IDBTransactionBackendOperations.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:
  • Modules/mediasource/MediaSource.h:
  • Modules/mediasource/MediaSourceRegistry.h:
  • Modules/mediasource/SourceBuffer.h:
  • Modules/mediasource/SourceBufferList.h:
  • Modules/mediastream/AudioStreamTrack.h:
  • Modules/mediastream/MediaStream.h:
  • Modules/mediastream/MediaStreamRegistry.h:
  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/RTCDTMFSender.h:
  • Modules/mediastream/RTCDataChannel.h:
  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/UserMediaRequest.h:
  • Modules/mediastream/VideoStreamTrack.h:
  • Modules/notifications/Notification.h:
  • Modules/speech/SpeechSynthesisUtterance.h:
  • Modules/webaudio/AudioContext.h:
  • Modules/webaudio/AudioNode.h:
  • Modules/websockets/WebSocket.h:
  • accessibility/AccessibilityList.h:
  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityNodeObject.h:
  • accessibility/AccessibilitySearchFieldButtons.h:
  • accessibility/AccessibilitySlider.h:
  • bindings/js/JSCryptoAlgorithmBuilder.h:
  • bindings/js/JSCryptoKeySerializationJWK.h:
  • bindings/js/JSDOMGlobalObjectTask.cpp:
  • bindings/js/JSDOMGlobalObjectTask.h:
  • bindings/js/JSLazyEventListener.h:
  • bindings/js/ScriptDebugServer.h:
  • bindings/js/WorkerScriptDebugServer.h:
  • crypto/algorithms/CryptoAlgorithmAES_CBC.h:
  • crypto/algorithms/CryptoAlgorithmAES_KW.h:
  • crypto/algorithms/CryptoAlgorithmHMAC.h:
  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
  • crypto/algorithms/CryptoAlgorithmSHA1.h:
  • crypto/algorithms/CryptoAlgorithmSHA224.h:
  • crypto/algorithms/CryptoAlgorithmSHA256.h:
  • crypto/algorithms/CryptoAlgorithmSHA384.h:
  • crypto/algorithms/CryptoAlgorithmSHA512.h:
  • crypto/keys/CryptoKeyAES.h:
  • crypto/keys/CryptoKeyDataOctetSequence.h:
  • crypto/keys/CryptoKeyDataRSAComponents.h:
  • crypto/keys/CryptoKeyHMAC.h:
  • crypto/keys/CryptoKeyRSA.h:
  • crypto/keys/CryptoKeySerializationRaw.h:
  • crypto/parameters/CryptoAlgorithmAesCbcParams.h:
  • crypto/parameters/CryptoAlgorithmAesKeyGenParams.h:
  • crypto/parameters/CryptoAlgorithmHmacKeyParams.h:
  • crypto/parameters/CryptoAlgorithmHmacParams.h:
  • crypto/parameters/CryptoAlgorithmRsaKeyGenParams.h:
  • crypto/parameters/CryptoAlgorithmRsaKeyParamsWithHash.h:
  • crypto/parameters/CryptoAlgorithmRsaOaepParams.h:
  • crypto/parameters/CryptoAlgorithmRsaSsaParams.h:
  • css/CSSCanvasValue.h:
  • css/CSSFontSelector.h:
  • css/CSSStyleSheet.h:
  • dom/Attr.h:
  • dom/BeforeUnloadEvent.h:
  • dom/CDATASection.h:
  • dom/CharacterData.h:
  • dom/ChildNodeList.h:
  • dom/Clipboard.cpp:
  • dom/Comment.h:
  • dom/DatasetDOMStringMap.h:
  • dom/Document.h:
  • dom/DocumentEventQueue.cpp:
  • dom/DocumentEventQueue.h:
  • dom/DocumentType.h:
  • dom/Element.h:
  • dom/EntityReference.h:
  • dom/EventContext.h:
  • dom/EventTarget.h:
  • dom/FocusEvent.h:
  • dom/LiveNodeList.h:
  • dom/MessagePort.h:
  • dom/MouseEvent.h:
  • dom/Node.h:
  • dom/Notation.h:
  • dom/ProcessingInstruction.h:
  • dom/PseudoElement.h:
  • dom/ShadowRoot.h:
  • dom/StaticNodeList.h:
  • dom/StyledElement.h:
  • dom/TemplateContentDocumentFragment.h:
  • dom/Text.h:
  • dom/WebKitNamedFlow.h:
  • editing/ios/EditorIOS.mm:
  • editing/mac/EditorMac.mm:
  • editing/markup.cpp:
  • fileapi/Blob.cpp:
  • fileapi/FileReader.h:
  • html/ClassList.h:
  • html/DOMSettableTokenList.h:
  • html/FTPDirectoryDocument.cpp:
  • html/FormAssociatedElement.cpp:
  • html/FormAssociatedElement.h:
  • html/HTMLAllCollection.h:
  • html/HTMLAnchorElement.h:
  • html/HTMLAppletElement.h:
  • html/HTMLAreaElement.h:
  • html/HTMLAudioElement.h:
  • html/HTMLBDIElement.h:
  • html/HTMLBRElement.h:
  • html/HTMLBaseElement.h:
  • html/HTMLBaseFontElement.h:
  • html/HTMLBodyElement.h:
  • html/HTMLButtonElement.h:
  • html/HTMLCanvasElement.h:
  • html/HTMLDListElement.h:
  • html/HTMLDataListElement.h:
  • html/HTMLDetailsElement.h:
  • html/HTMLDirectoryElement.h:
  • html/HTMLDocument.h:
  • html/HTMLElement.h:
  • html/HTMLEmbedElement.h:
  • html/HTMLFieldSetElement.h:
  • html/HTMLFontElement.h:
  • html/HTMLFormControlElement.h:
  • html/HTMLFormElement.h:
  • html/HTMLFrameElement.h:
  • html/HTMLFrameSetElement.h:
  • html/HTMLHRElement.h:
  • html/HTMLHeadElement.h:
  • html/HTMLHeadingElement.h:
  • html/HTMLHtmlElement.h:
  • html/HTMLIFrameElement.h:
  • html/HTMLImageElement.h:
  • html/HTMLInputElement.h:
  • html/HTMLKeygenElement.cpp:
  • html/HTMLKeygenElement.h:
  • html/HTMLLIElement.h:
  • html/HTMLLabelElement.h:
  • html/HTMLLegendElement.h:
  • html/HTMLLinkElement.h:
  • html/HTMLMapElement.h:
  • html/HTMLMarqueeElement.h:
  • html/HTMLMenuElement.h:
  • html/HTMLMetaElement.h:
  • html/HTMLMeterElement.h:
  • html/HTMLModElement.h:
  • html/HTMLNameCollection.h:
  • html/HTMLOListElement.h:
  • html/HTMLObjectElement.h:
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.h:
  • html/HTMLOptionsCollection.h:
  • html/HTMLOutputElement.h:
  • html/HTMLParagraphElement.h:
  • html/HTMLParamElement.h:
  • html/HTMLPlugInElement.h:
  • html/HTMLPreElement.h:
  • html/HTMLProgressElement.h:
  • html/HTMLQuoteElement.h:
  • html/HTMLScriptElement.h:
  • html/HTMLSelectElement.h:
  • html/HTMLSourceElement.h:
  • html/HTMLStyleElement.h:
  • html/HTMLSummaryElement.h:
  • html/HTMLTableCaptionElement.h:
  • html/HTMLTableCellElement.h:
  • html/HTMLTableColElement.h:
  • html/HTMLTableElement.h:
  • html/HTMLTableRowElement.h:
  • html/HTMLTableRowsCollection.h:
  • html/HTMLTableSectionElement.h:
  • html/HTMLTemplateElement.h:
  • html/HTMLTextAreaElement.h:
  • html/HTMLTextFormControlElement.h:
  • html/HTMLTitleElement.h:
  • html/HTMLTrackElement.h:
  • html/HTMLUListElement.h:
  • html/HTMLUnknownElement.h:
  • html/HTMLVideoElement.h:
  • html/HTMLViewSourceDocument.h:
  • html/ImageDocument.cpp:
  • html/ImageDocument.h:
  • html/LabelableElement.h:
  • html/LabelsNodeList.h:
  • html/MediaController.h:
  • html/MediaDocument.cpp:
  • html/MediaDocument.h:
  • html/MediaFragmentURIParser.h:
  • html/PluginDocument.cpp:
  • html/PluginDocument.h:
  • html/RangeInputType.h:
  • html/TextDocument.h:
  • html/parser/TextDocumentParser.h:
  • html/parser/TextViewSourceParser.h:
  • html/shadow/DetailsMarkerControl.h:
  • html/shadow/MediaControlElementTypes.h:
  • html/shadow/MediaControlElements.h:
  • html/shadow/MeterShadowElement.h:
  • html/shadow/ProgressShadowElement.h:
  • html/shadow/SliderThumbElement.h:
  • html/shadow/SpinButtonElement.h:
  • html/shadow/TextControlInnerElements.h:
  • html/shadow/YouTubeEmbedShadowElement.h:
  • html/track/TextTrack.h:
  • html/track/TextTrackCue.h:
  • html/track/TextTrackCueGeneric.cpp:
  • html/track/TextTrackCueGeneric.h:
  • html/track/TrackListBase.h:
  • html/track/WebVTTElement.h:
  • inspector/CommandLineAPIModule.h:
  • inspector/InjectedScriptCanvasModule.h:
  • inspector/InspectorConsoleAgent.cpp:
  • inspector/InspectorController.h:
  • inspector/InspectorDebuggerAgent.h:
  • inspector/PageConsoleAgent.cpp:
  • inspector/PageInjectedScriptHost.h:
  • inspector/PageInjectedScriptManager.h:
  • inspector/WorkerInspectorController.h:
  • loader/SinkDocument.cpp:
  • loader/SinkDocument.h:
  • loader/appcache/DOMApplicationCache.h:
  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedFont.h:
  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedSVGDocument.h:
  • loader/cache/CachedScript.h:
  • loader/cache/CachedShader.h:
  • loader/cache/CachedTextTrack.h:
  • loader/cache/CachedXSLStyleSheet.h:
  • loader/icon/IconLoader.h:
  • mathml/MathMLSelectElement.h:
  • page/DOMTimer.h:
  • page/DOMWindow.h:
  • page/EventSource.h:
  • page/Frame.h:
  • page/FrameView.h:
  • page/MainFrame.h:
  • page/PageDebuggable.h:
  • page/PageSerializer.cpp:
  • page/Performance.h:
  • page/SuspendableTimer.h:
  • page/animation/KeyframeAnimation.h:
  • page/scrolling/ScrollingStateFixedNode.h:
  • page/scrolling/ScrollingStateScrollingNode.h:
  • page/scrolling/ScrollingStateStickyNode.h:
  • platform/ClockGeneric.h:
  • platform/efl/ScrollbarThemeEfl.h:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/CrossfadeGeneratedImage.h:
  • platform/graphics/GradientImage.h:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
  • platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.h:
  • platform/graphics/ca/win/PlatformCALayerWin.h:
  • platform/graphics/cg/PDFDocumentImage.h:
  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
  • platform/graphics/gstreamer/MediaSourceGStreamer.h:
  • platform/graphics/gstreamer/SourceBufferPrivateGStreamer.h:
  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
  • platform/ios/WebSafeGCActivityCallbackIOS.h:
  • platform/ios/WebSafeIncrementalSweeperIOS.h:
  • platform/mac/PlatformClockCA.h:
  • platform/mac/PlatformClockCM.h:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mediastream/MediaStreamTrackPrivate.h:
  • platform/mediastream/mac/MediaStreamCenterMac.h:
  • platform/mock/MockMediaStreamCenter.h:
  • platform/mock/RTCDataChannelHandlerMock.h:
  • platform/mock/RTCPeerConnectionHandlerMock.h:
  • platform/mock/mediasource/MockBox.h:
  • platform/mock/mediasource/MockMediaSourcePrivate.h:
  • platform/mock/mediasource/MockSourceBufferPrivate.cpp:
  • platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h:
  • platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.h:
  • platform/text/LocaleNone.cpp:
  • platform/text/PlatformLocale.cpp:
  • rendering/EllipsisBox.h:
  • rendering/FilterEffectRenderer.h:
  • rendering/InlineElementBox.h:
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.h:
  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

  • rendering/RenderBox.h:
  • rendering/RenderButton.h:
  • rendering/RenderCombineText.h:
  • rendering/RenderCounter.h:
  • rendering/RenderDeprecatedFlexibleBox.h:
  • rendering/RenderDetailsMarker.h:
  • rendering/RenderElement.h:
  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFlowThread.h:
  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.h:
  • rendering/RenderFullScreen.cpp:
  • rendering/RenderFullScreen.h:
  • rendering/RenderGrid.h:
  • rendering/RenderHTMLCanvas.h:
  • rendering/RenderIFrame.h:
  • rendering/RenderImage.h:
  • rendering/RenderInline.h:
  • rendering/RenderLayer.h:
  • rendering/RenderLayerFilterInfo.h:
  • rendering/RenderLineBreak.h:
  • rendering/RenderListBox.h:
  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.h:
  • rendering/RenderMedia.h:
  • rendering/RenderMediaControlElements.h:
  • rendering/RenderMenuList.h:
  • rendering/RenderMeter.h:
  • rendering/RenderMultiColumnBlock.h:
  • rendering/RenderMultiColumnFlowThread.h:
  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderNamedFlowFragment.h:
  • rendering/RenderNamedFlowThread.h:
  • rendering/RenderProgress.h:
  • rendering/RenderQuote.h:
  • rendering/RenderRegion.h:
  • rendering/RenderRegionSet.h:
  • rendering/RenderReplaced.h:
  • rendering/RenderReplica.h:
  • rendering/RenderRuby.h:
  • rendering/RenderRubyBase.h:
  • rendering/RenderRubyRun.h:
  • rendering/RenderRubyText.h:
  • rendering/RenderScrollbar.h:
  • rendering/RenderScrollbarPart.h:
  • rendering/RenderSearchField.h:
  • rendering/RenderSlider.h:
  • rendering/RenderSnapshottedPlugIn.h:
  • rendering/RenderTable.h:
  • rendering/RenderTableCaption.h:
  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.h:
  • rendering/RenderText.h:
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderTextFragment.h:
  • rendering/RenderTextTrackCue.h:
  • rendering/RenderVideo.h:
  • rendering/RenderView.h:
  • rendering/RenderWidget.h:
  • rendering/RootInlineBox.h:
  • rendering/TrailingFloatsRootInlineBox.h:
  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLFenced.h:
  • rendering/mathml/RenderMathMLFraction.h:
  • rendering/mathml/RenderMathMLMath.h:
  • rendering/mathml/RenderMathMLOperator.h:
  • rendering/mathml/RenderMathMLRoot.h:
  • rendering/mathml/RenderMathMLRow.h:
  • rendering/mathml/RenderMathMLScripts.h:
  • rendering/mathml/RenderMathMLSpace.h:
  • rendering/mathml/RenderMathMLSquareRoot.h:
  • rendering/shapes/ShapeInsideInfo.h:
  • rendering/shapes/ShapeOutsideInfo.h:
  • rendering/style/ContentData.h:
  • rendering/style/StyleCachedImage.h:
  • rendering/style/StyleCachedImageSet.h:
  • rendering/style/StyleGeneratedImage.h:
  • rendering/svg/RenderSVGBlock.h:
  • rendering/svg/RenderSVGContainer.h:
  • rendering/svg/RenderSVGEllipse.h:
  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGGradientStop.h:
  • rendering/svg/RenderSVGHiddenContainer.h:
  • rendering/svg/RenderSVGImage.h:
  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGInlineText.h:
  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGPath.h:
  • rendering/svg/RenderSVGRect.h:
  • rendering/svg/RenderSVGResourceClipper.h:
  • rendering/svg/RenderSVGResourceContainer.h:
  • rendering/svg/RenderSVGResourceFilter.h:
  • rendering/svg/RenderSVGResourceFilterPrimitive.h:
  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourceLinearGradient.h:
  • rendering/svg/RenderSVGResourceMarker.h:
  • rendering/svg/RenderSVGResourceMasker.h:
  • rendering/svg/RenderSVGResourcePattern.h:
  • rendering/svg/RenderSVGResourceRadialGradient.h:
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGShape.cpp:
  • rendering/svg/RenderSVGShape.h:
  • rendering/svg/RenderSVGTSpan.h:
  • rendering/svg/RenderSVGText.h:
  • rendering/svg/RenderSVGTextPath.h:
  • rendering/svg/RenderSVGTransformableContainer.h:
  • rendering/svg/RenderSVGViewportContainer.h:
  • rendering/svg/SVGInlineFlowBox.h:
  • rendering/svg/SVGInlineTextBox.h:
  • rendering/svg/SVGRootInlineBox.h:
  • rendering/svg/SVGTextRunRenderingContext.h:
  • svg/SVGAElement.h:
  • svg/SVGAltGlyphDefElement.h:
  • svg/SVGAltGlyphElement.h:
  • svg/SVGAltGlyphItemElement.h:
  • svg/SVGAnimateColorElement.h:
  • svg/SVGAnimateMotionElement.h:
  • svg/SVGAnimateTransformElement.h:
  • svg/SVGAnimatedAngle.h:
  • svg/SVGAnimatedBoolean.h:
  • svg/SVGAnimatedColor.h:
  • svg/SVGAnimatedEnumeration.h:
  • svg/SVGAnimatedInteger.h:
  • svg/SVGAnimatedIntegerOptionalInteger.h:
  • svg/SVGAnimatedLength.h:
  • svg/SVGAnimatedLengthList.h:
  • svg/SVGAnimatedNumber.h:
  • svg/SVGAnimatedNumberList.h:
  • svg/SVGAnimatedNumberOptionalNumber.h:
  • svg/SVGAnimatedPath.h:
  • svg/SVGAnimatedPointList.h:
  • svg/SVGAnimatedPreserveAspectRatio.h:
  • svg/SVGAnimatedRect.h:
  • svg/SVGAnimatedString.h:
  • svg/SVGAnimatedTransformList.h:
  • svg/SVGCircleElement.h:
  • svg/SVGClipPathElement.h:
  • svg/SVGCursorElement.h:
  • svg/SVGDefsElement.h:
  • svg/SVGDescElement.h:
  • svg/SVGDocument.h:
  • svg/SVGElement.h:
  • svg/SVGEllipseElement.h:
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEDistantLightElement.h:
  • svg/SVGFEDropShadowElement.h:
  • svg/SVGFEFloodElement.h:
  • svg/SVGFEFuncAElement.h:
  • svg/SVGFEFuncBElement.h:
  • svg/SVGFEFuncGElement.h:
  • svg/SVGFEFuncRElement.h:
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.h:
  • svg/SVGFEMergeElement.h:
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFEPointLightElement.h:
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFESpotLightElement.h:
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterElement.h:
  • svg/SVGFontElement.h:
  • svg/SVGFontFaceElement.h:
  • svg/SVGFontFaceFormatElement.h:
  • svg/SVGFontFaceNameElement.h:
  • svg/SVGFontFaceSrcElement.h:
  • svg/SVGFontFaceUriElement.h:
  • svg/SVGForeignObjectElement.h:
  • svg/SVGGElement.h:
  • svg/SVGGlyphElement.h:
  • svg/SVGGlyphRefElement.h:
  • svg/SVGHKernElement.h:
  • svg/SVGImageElement.h:
  • svg/SVGLineElement.h:
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMPathElement.h:
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.h:
  • svg/SVGMetadataElement.h:
  • svg/SVGMissingGlyphElement.h:
  • svg/SVGPathElement.h:
  • svg/SVGPathStringBuilder.h:
  • svg/SVGPatternElement.h:
  • svg/SVGPolygonElement.h:
  • svg/SVGPolylineElement.h:
  • svg/SVGRadialGradientElement.h:
  • svg/SVGRectElement.h:
  • svg/SVGSVGElement.h:
  • svg/SVGScriptElement.h:
  • svg/SVGSetElement.h:
  • svg/SVGStopElement.h:
  • svg/SVGStyleElement.h:
  • svg/SVGSwitchElement.h:
  • svg/SVGSymbolElement.h:
  • svg/SVGTRefElement.h:
  • svg/SVGTSpanElement.h:
  • svg/SVGTextContentElement.h:
  • svg/SVGTextElement.h:
  • svg/SVGTextPathElement.h:
  • svg/SVGTitleElement.h:
  • svg/SVGUnknownElement.h:
  • svg/SVGUseElement.h:
  • svg/SVGVKernElement.h:
  • svg/SVGViewElement.h:
  • svg/animation/SVGSMILElement.h:
  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageForContainer.h:
  • svg/graphics/filters/SVGFilter.h:
  • workers/AbstractWorker.h:
  • workers/SharedWorker.h:
  • workers/Worker.h:
  • workers/WorkerEventQueue.cpp:
  • workers/WorkerEventQueue.h:
  • workers/WorkerGlobalScope.h:
  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequestUpload.h:
  • xml/XPathFunctions.cpp:
  • xml/XPathPath.h:
  • xml/XPathPredicate.h:
  • xml/XSLStyleSheet.h:

Source/WebKit/ios:

  • WebCoreSupport/WebDiskImageCacheClientIOS.h:

Source/WebKit/mac:

  • WebCoreSupport/WebUserMediaClient.h:
  • WebView/WebScriptDebugger.h:

Source/WebKit2:

  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
  • NetworkProcess/RemoteNetworkingContext.h:
  • Shared/API/Cocoa/RemoteObjectRegistry.h:
  • Shared/APIArray.h:
  • Shared/APIString.h:
  • Shared/AsyncRequest.h:
  • Shared/AsyncTask.h:
  • Shared/cf/KeyedEncoder.h:
  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/efl/WebViewEfl.h:
  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
  • WebProcess/Plugins/PDF/PDFPlugin.h:
  • WebProcess/Storage/StorageAreaImpl.h:
  • WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
  • WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:
  • WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h:
3:00 PM Changeset in webkit [162157] by ap@apple.com
  • 2 edits in trunk/LayoutTests

REGRESSION(r162145): media/video-controls-visible-audio-only.html fails
​https://bugs.webkit.org/show_bug.cgi?id=127147

  • platform/mac/TestExpectations: Marking it as flaky while Jer investigates.
2:55 PM Changeset in webkit [162156] by oliver@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

throwing an objc object (or general binding object) triggers an assertion
​https://bugs.webkit.org/show_bug.cgi?id=127146

Reviewed by Alexey Proskuryakov.

This is simply a bogus assertion as we can't guarantee a bindings object
won't intercept assignment to .stack

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwind):

2:54 PM Changeset in webkit [162155] by benjamin@webkit.org
  • 1 edit
    2 deletes in trunk/Source/Platform

Remove Nix from Source/Platform
​https://bugs.webkit.org/show_bug.cgi?id=127132

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-01-16
Reviewed by Anders Carlsson.

  • PlatformNix.cmake: Removed.
  • nix: Removed.
2:40 PM Changeset in webkit [162154] by fpizlo@apple.com
  • 8 edits in branches/jsCStack

JSC layout tests should run with the FTL
​https://bugs.webkit.org/show_bug.cgi?id=127144

Source/JavaScriptCore:

Not yet reviewed.

Note that this currently leads to the following failures with --ftl-jit. I will
fix them in future commits.

jsc-layout-tests.yaml/js/script-tests/dfg-call-function-hit-watchpoint.js.layout-ftl
jsc-layout-tests.yaml/js/script-tests/dfg-call-function-hit-watchpoint.js.layout-ftl-no-cjit
jsc-layout-tests.yaml/js/script-tests/dfg-call-function-hit-watchpoint.js.layout-ftl-eager-no-cjit
jsc-layout-tests.yaml/js/script-tests/dfg-call-method-hit-watchpoint.js.layout-ftl
jsc-layout-tests.yaml/js/script-tests/dfg-call-method-hit-watchpoint.js.layout-ftl-no-cjit
jsc-layout-tests.yaml/js/script-tests/dfg-inline-arguments-use-from-all-the-places.js.layout-ftl-eager-no-cjit
jsc-layout-tests.yaml/js/script-tests/dfg-mod-neg2tothe31-by-one-and-then-or-zero-with-interesting-reg-alloc.js.layout-ftl-eager-no-cjit

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::numberOfDFGCompiles):

  • dfg/DFGTierUpCheckInjectionPhase.cpp:

(JSC::DFG::TierUpCheckInjectionPhase::run):

  • runtime/Options.h:

Tools:

Not yet reviewed.

  • Scripts/run-jsc-stress-tests:

LayoutTests:

Not yet reviewed.

  • js/script-tests/dfg-add-not-number.js:
2:21 PM Changeset in webkit [162153] by Lucas Forschler
  • 5 edits in tags/Safari-538.12.1/Source

Versioning.

2:18 PM Changeset in webkit [162152] by Lucas Forschler
  • 1 copy in tags/Safari-538.12.1

New Tag.

2:05 PM Changeset in webkit [162151] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix the build after r162148

  • Shared/cf/KeyedEncoder.h: s/OVERRIDE/override/
1:56 PM Changeset in webkit [162150] by mmaxfield@apple.com
  • 6 edits in trunk/Source/WebCore

Draw all underline segments in a particular run in the same call
​https://bugs.webkit.org/show_bug.cgi?id=127082

Reviewed by Simon Fraser.

Instead of running CGContextFillRect() in a loop, we can instead call CGContextFillRects()

In my tests, this seems to have about 0.5% speedup.

This patch creates some redundant code, but I think that refactoring would make the code
much less readable. I also am hesitant to make drawLineForText call drawLinesForText because
of the overhead of the vector that would be needed.

As there is no behavior change, no new tests are necessary

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawLinesForText):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::platformInit):

  • platform/graphics/wince/GraphicsContextWinCE.cpp:

(WebCore::GraphicsContext::drawLinesForText):

  • rendering/InlineTextBox.cpp:

(WebCore::drawSkipInkUnderline):

1:52 PM Changeset in webkit [162149] by BJ Burg
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: add more context to Object.addEventListener assertions
​https://bugs.webkit.org/show_bug.cgi?id=127125

Reviewed by Joseph Pecoraro.

Log invalid event type and listener parameters, and log the other
parameters so the callsite is easier to figure out.

  • UserInterface/Object.js:

(WebInspector.Object.addEventListener):

1:45 PM Changeset in webkit [162148] by beidson@apple.com
  • 12 edits
    1 copy
    1 add in trunk/Source

Use KeyedCoding as a persistent storage mechanism for blobs
​https://bugs.webkit.org/show_bug.cgi?id=127012

Reviewed by Anders Carlsson.

Source/WebCore:

Add basic KeyedDecoder interface that is the inverse of KeyedEncoder:

  • platform/KeyedCoding.h:

(WebCore::KeyedDecoder::decodeVerifiedEnum):
(WebCore::KeyedDecoder::decodeObject):
(WebCore::KeyedDecoder::decodeObjects):

Use KeyedEncoder/Decoder to encode/decode IDBKeyPath:

  • Modules/indexeddb/IDBKeyPath.cpp:

(WebCore::IDBKeyPath::encode):
(WebCore::IDBKeyPath::decode):

  • Modules/indexeddb/IDBKeyPath.h:
  • WebCore.exp.in:

Source/WebKit2:

Add a way to get the encoded buffer to save:

  • Shared/cf/KeyedEncoder.cpp:

(WebKit::KeyedEncoder::finishEncoding):

  • Shared/cf/KeyedEncoder.h:

Add a WebKit KeyedDecoder for CF platforms that can decode the previously encoded buffer:

  • Shared/cf/KeyedDecoder.cpp: Added.

(WebKit::KeyedDecoder::KeyedDecoder):
(WebKit::KeyedDecoder::~KeyedDecoder):
(WebKit::KeyedDecoder::decodeInt64):
(WebKit::KeyedDecoder::decodeUInt32):
(WebKit::KeyedDecoder::decodeString):
(WebKit::KeyedDecoder::beginObject):
(WebKit::KeyedDecoder::endObject):
(WebKit::KeyedDecoder::beginArray):
(WebKit::KeyedDecoder::beginArrayElement):
(WebKit::KeyedDecoder::endArrayElement):
(WebKit::KeyedDecoder::endArray):

  • Shared/cf/KeyedDecoder.h:

Create a WebKit KeyedEncoder/Decoder and use to encode/decode IDBKeyPaths:

  • DatabaseProcess/IndexedDB/IDBSerialization.cpp:

(WebKit::serializeIDBKeyPath):
(WebKit::deserializeIDBKeyPath):

  • DatabaseProcess/IndexedDB/IDBSerialization.h:
  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:

(WebKit::UniqueIDBDatabaseBackingStoreSQLite::createObjectStore):

  • WebKit2.xcodeproj/project.pbxproj:
1:30 PM Changeset in webkit [162147] by aestes@apple.com
  • 2 edits in trunk/Source/WebKit2

Stop copying WKOriginDataManager.cpp into WebKit2.framework
​https://bugs.webkit.org/show_bug.cgi?id=127100

Reviewed by Sam Weinig.

The file was mistakenly added to the 'All' target. Remove it.

  • WebKit2.xcodeproj/project.pbxproj:
1:30 PM Changeset in webkit [162146] by aestes@apple.com
  • 5 edits in trunk/Source/WebKit2

[iOS] Install WebKit2 XPC services correctly
​https://bugs.webkit.org/show_bug.cgi?id=127097

Reviewed by Anders Carlsson.

  • Configurations/PluginService.32.xcconfig: Set SKIP_INSTALL to YES on iOS.
  • Configurations/PluginService.64.xcconfig: Ditto.
  • Configurations/PluginService.Development.xcconfig: Ditto.
  • WebKit2.xcodeproj/project.pbxproj: Modified the "Add XPCServices symlink"

build phase to only execute on OS X. Modified the
"Copy XPC services for engineering builds" build phase to copy files
directly to WebKit2.framework/XPCServices/ on iOS, and modified its
output file paths to omit "Versions/A/" (since OS X will have a
XPCServices symlink at the root of the framework bundle).

1:26 PM Changeset in webkit [162145] by eric.carlson@apple.com
  • 10 edits
    2 adds in trunk

Allow MediaSessionManager to restrict inline <video> playback
​https://bugs.webkit.org/show_bug.cgi?id=127113

Reviewed by Jer Noble.

Source/WebCore:

Test: media/video-fullscreeen-only-playback.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::updatePlayState): Drive-by change to not tell the media session that

playback is starting if the media player is already playing. Enter fullscreen if the media
session says it is required.

  • html/HTMLMediaSession.cpp:

(WebCore::HTMLMediaSession::clientWillBeginPlayback): Make it const.
(WebCore::HTMLMediaSession::requiresFullscreenForVideoPlayback): New, see if the specified

media element must be played in fullscreen based on the media session settings, document
settings, and attributes.

  • html/HTMLMediaSession.h:
  • platform/audio/MediaSession.h: pauseSession shouldn't be virtual.
  • platform/audio/MediaSessionManager.cpp:

(WebCore::MediaSessionManager::sessionWillBeginPlayback): Return immediately if ConcurrentPlaybackNotPermitted

is not set.

(WebCore::MediaSessionManager::sessionRestrictsInlineVideoPlayback): New.

  • platform/audio/MediaSessionManager.h:
  • platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::MediaSessionManageriOS): Set InlineVideoPlaybackRestricted if

running on an iPhone or iPod class device.

  • testing/Internals.cpp:

(WebCore::Internals::setMediaSessionRestrictions): Support InlineVideoPlaybackRestricted.

LayoutTests:

  • media/video-fullscreeen-only-playback-expected.txt: Added.
  • media/video-fullscreeen-only-playback.html: Added.
1:23 PM Changeset in webkit [162144] by BJ Burg
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: CallFrame is missing saveIdentityToCookie, or should be excluded
​https://bugs.webkit.org/show_bug.cgi?id=126791

Reviewed by Timothy Hatcher.

  • UserInterface/CallFrame.js: Add a dummy saveIdentityToCookie() implementation.
1:07 PM Changeset in webkit [162143] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebKit2

Build fix for mac following r162141.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h: Switch OVERRIDE to override.
12:57 PM Changeset in webkit [162142] by fpizlo@apple.com
  • 5 edits
    1 add in branches/jsCStack/Source/JavaScriptCore

ArithSin in FTL
​https://bugs.webkit.org/show_bug.cgi?id=127129

Patch by Matthew Mirman <​mmirman@apple.com> on 2014-01-16
Reviewed by Filip Pizlo.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileArithSin):

  • ftl/FTLOutput.h:

(JSC::FTL::Output::doubleSin):

  • tests/stress/ftl-arithsin.js: Added.
12:48 PM Changeset in webkit [162141] by roger_fong@apple.com
  • 18 edits in trunk

Add support for handling WebGL load policies.
​https://bugs.webkit.org/show_bug.cgi?id=126935
<rdar://problem/15790448>.

Reviewed by Timothy Horton.

Boiler plate code for getting the load policy logic from WebProcess to the UIProcess.

  • UIProcess/API/C/WKAPICast.h:

(WebKit::toWebGLLoadPolicy):

  • UIProcess/API/C/WKPageLoaderClient.h: Define a new WKPageLoaderClientV4 struct.
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(setUpPageLoaderClient):

  • UIProcess/WebLoaderClient.cpp:

(WebKit::WebLoaderClient::webGLLoadPolicy):

  • UIProcess/WebLoaderClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::webGLPolicyForURL):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::webGLPolicyForURL):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::webGLPolicyForURL): We use a sendSync to get the load policy value from the UIProcess.

  • WebProcess/WebPage/WebPage.h:
  • WebKitTestRunner/TestController.cpp: Update WKPageLoaderClient to V4.

(WTR::TestController::createWebViewWithOptions):

Rename webGLPolicyForSite to webGLPolicyForURL.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):

  • loader/FrameLoaderClient.h:

(WebCore::FrameLoaderClient::webGLPolicyForURL):

12:11 PM Changeset in webkit [162140] by thiago.lacerda@openbossa.org
  • 3 edits in trunk/Source/WebCore

Guarding HTMLMediaSession with ENABLE(VIDEO)
​https://bugs.webkit.org/show_bug.cgi?id=127126

Reviewed by Eric Carlson.

No new tests needed.

  • html/HTMLMediaSession.cpp:
  • html/HTMLMediaSession.h:
11:42 AM Changeset in webkit [162139] by commit-queue@webkit.org
  • 1157 edits in trunk

Remove workaround for compilers not supporting explicit override control
​https://bugs.webkit.org/show_bug.cgi?id=127111

Patch by Peter Molnar <​pmolnar.u-szeged@partner.samsung.com> on 2014-01-16
Reviewed by Anders Carlsson.

Now all compilers support explicit override control, this workaround can be removed.

Source/JavaScriptCore:

  • API/JSAPIWrapperObject.mm:
  • API/JSCallbackObject.h:
  • API/JSManagedValue.mm:
  • API/JSScriptRef.cpp:
  • bytecode/CodeBlock.h:
  • bytecode/CodeBlockJettisoningWatchpoint.h:
  • bytecode/ProfiledCodeBlockJettisoningWatchpoint.h:
  • bytecode/StructureStubClearingWatchpoint.h:
  • dfg/DFGArrayifySlowPathGenerator.h:
  • dfg/DFGCallArrayAllocatorSlowPathGenerator.h:
  • dfg/DFGFailedFinalizer.h:
  • dfg/DFGJITCode.h:
  • dfg/DFGJITFinalizer.h:
  • dfg/DFGSaneStringGetByValSlowPathGenerator.h:
  • dfg/DFGSlowPathGenerator.h:
  • dfg/DFGSpeculativeJIT64.cpp:
  • heap/Heap.h:
  • heap/IncrementalSweeper.h:
  • heap/SuperRegion.h:
  • inspector/InspectorValues.h:
  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/agents/InspectorAgent.h:
  • inspector/remote/RemoteInspector.h:
  • inspector/remote/RemoteInspectorDebuggableConnection.h:
  • inspector/scripts/CodeGeneratorInspector.py:

(Generator.go):

  • jit/ClosureCallStubRoutine.h:
  • jit/ExecutableAllocatorFixedVMPool.cpp:
  • jit/GCAwareJITStubRoutine.h:
  • jit/JITCode.h:
  • jit/JITToDFGDeferredCompilationCallback.h:
  • parser/Nodes.h:
  • parser/SourceProvider.h:
  • runtime/DataView.h:
  • runtime/GCActivityCallback.h:
  • runtime/GenericTypedArrayView.h:
  • runtime/JSGlobalObjectDebuggable.h:
  • runtime/JSPromiseReaction.cpp:
  • runtime/RegExpCache.h:
  • runtime/SimpleTypedArrayController.h:
  • runtime/SymbolTable.h:
  • runtime/WeakMapData.h:

Source/WebCore:

  • Modules/airplay/WebKitPlaybackTargetAvailabilityEvent.h:
  • Modules/encryptedmedia/CDMPrivateAVFoundation.h:
  • Modules/encryptedmedia/CDMPrivateAVFoundation.mm:
  • Modules/encryptedmedia/MediaKeyMessageEvent.h:
  • Modules/encryptedmedia/MediaKeyNeededEvent.h:
  • Modules/encryptedmedia/MediaKeySession.h:
  • Modules/encryptedmedia/MediaKeys.h:
  • Modules/geolocation/Geolocation.h:
  • Modules/indexeddb/DOMWindowIndexedDatabase.h:
  • Modules/indexeddb/IDBCursorBackendOperations.h:
  • Modules/indexeddb/IDBCursorWithValue.h:
  • Modules/indexeddb/IDBDatabase.h:
  • Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
  • Modules/indexeddb/IDBOpenDBRequest.h:
  • Modules/indexeddb/IDBRequest.h:
  • Modules/indexeddb/IDBTransaction.h:
  • Modules/indexeddb/IDBTransactionBackendOperations.h:
  • Modules/indexeddb/leveldb/IDBBackingStoreLevelDB.cpp:
  • Modules/indexeddb/leveldb/IDBFactoryBackendLevelDB.h:
  • Modules/indexeddb/leveldb/IDBServerConnectionLevelDB.h:
  • Modules/indieui/UIRequestEvent.h:
  • Modules/mediasource/MediaSource.h:
  • Modules/mediasource/MediaSourceRegistry.h:
  • Modules/mediasource/SourceBuffer.h:
  • Modules/mediasource/SourceBufferList.h:
  • Modules/mediastream/AudioStreamTrack.h:
  • Modules/mediastream/MediaConstraintsImpl.h:
  • Modules/mediastream/MediaStream.h:
  • Modules/mediastream/MediaStreamRegistry.h:
  • Modules/mediastream/MediaStreamTrack.h:
  • Modules/mediastream/MediaStreamTrackEvent.h:
  • Modules/mediastream/MediaStreamTrackSourcesRequest.h:
  • Modules/mediastream/RTCDTMFSender.h:
  • Modules/mediastream/RTCDataChannel.h:
  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/RTCSessionDescriptionRequestImpl.h:
  • Modules/mediastream/RTCStatsRequestImpl.h:
  • Modules/mediastream/RTCStatsResponse.h:
  • Modules/mediastream/RTCVoidRequestImpl.h:
  • Modules/mediastream/UserMediaRequest.h:
  • Modules/mediastream/VideoStreamTrack.h:
  • Modules/networkinfo/NetworkInfoConnection.h:
  • Modules/notifications/DOMWindowNotifications.h:
  • Modules/notifications/Notification.h:
  • Modules/notifications/NotificationCenter.h:
  • Modules/plugins/QuickTimePluginReplacement.h:
  • Modules/speech/SpeechRecognition.h:
  • Modules/speech/SpeechRecognitionError.h:
  • Modules/speech/SpeechRecognitionEvent.h:
  • Modules/speech/SpeechSynthesis.h:
  • Modules/speech/SpeechSynthesisUtterance.h:
  • Modules/webaudio/AnalyserNode.h:
  • Modules/webaudio/AudioBasicInspectorNode.h:
  • Modules/webaudio/AudioBasicProcessorNode.h:
  • Modules/webaudio/AudioBufferSourceNode.h:
  • Modules/webaudio/AudioContext.h:
  • Modules/webaudio/AudioDestinationNode.h:
  • Modules/webaudio/AudioNode.h:
  • Modules/webaudio/AudioNodeInput.h:
  • Modules/webaudio/AudioParam.h:
  • Modules/webaudio/AudioProcessingEvent.h:
  • Modules/webaudio/BiquadDSPKernel.h:
  • Modules/webaudio/BiquadProcessor.h:
  • Modules/webaudio/ChannelMergerNode.h:
  • Modules/webaudio/ChannelSplitterNode.h:
  • Modules/webaudio/ConvolverNode.h:
  • Modules/webaudio/DefaultAudioDestinationNode.h:
  • Modules/webaudio/DelayDSPKernel.h:
  • Modules/webaudio/DelayProcessor.h:
  • Modules/webaudio/DynamicsCompressorNode.h:
  • Modules/webaudio/GainNode.h:
  • Modules/webaudio/MediaElementAudioSourceNode.h:
  • Modules/webaudio/MediaStreamAudioDestinationNode.h:
  • Modules/webaudio/MediaStreamAudioSourceNode.h:
  • Modules/webaudio/OfflineAudioCompletionEvent.h:
  • Modules/webaudio/OfflineAudioDestinationNode.h:
  • Modules/webaudio/OscillatorNode.h:
  • Modules/webaudio/PannerNode.h:
  • Modules/webaudio/ScriptProcessorNode.h:
  • Modules/webaudio/WaveShaperDSPKernel.h:
  • Modules/webaudio/WaveShaperProcessor.h:
  • Modules/webdatabase/DatabaseTask.h:
  • Modules/webdatabase/SQLTransaction.h:
  • Modules/webdatabase/SQLTransactionBackend.h:
  • Modules/websockets/CloseEvent.h:
  • Modules/websockets/WebSocket.h:
  • Modules/websockets/WebSocketChannel.h:
  • Modules/websockets/WebSocketDeflateFramer.cpp:
  • Modules/websockets/WorkerThreadableWebSocketChannel.cpp:
  • Modules/websockets/WorkerThreadableWebSocketChannel.h:
  • accessibility/AccessibilityARIAGrid.h:
  • accessibility/AccessibilityARIAGridCell.h:
  • accessibility/AccessibilityARIAGridRow.h:
  • accessibility/AccessibilityImageMapLink.h:
  • accessibility/AccessibilityList.h:
  • accessibility/AccessibilityListBox.h:
  • accessibility/AccessibilityListBoxOption.h:
  • accessibility/AccessibilityMediaControls.h:
  • accessibility/AccessibilityMenuList.h:
  • accessibility/AccessibilityMenuListOption.h:
  • accessibility/AccessibilityMenuListPopup.h:
  • accessibility/AccessibilityMockObject.h:
  • accessibility/AccessibilityNodeObject.h:
  • accessibility/AccessibilityProgressIndicator.h:
  • accessibility/AccessibilityRenderObject.h:
  • accessibility/AccessibilitySVGRoot.h:
  • accessibility/AccessibilityScrollView.h:
  • accessibility/AccessibilityScrollbar.h:
  • accessibility/AccessibilitySearchFieldButtons.h:
  • accessibility/AccessibilitySlider.h:
  • accessibility/AccessibilitySpinButton.h:
  • accessibility/AccessibilityTable.h:
  • accessibility/AccessibilityTableCell.h:
  • accessibility/AccessibilityTableColumn.h:
  • accessibility/AccessibilityTableHeaderContainer.h:
  • accessibility/AccessibilityTableRow.h:
  • bindings/js/JSCryptoAlgorithmBuilder.h:
  • bindings/js/JSCryptoKeySerializationJWK.h:
  • bindings/js/JSDOMGlobalObjectTask.h:
  • bindings/js/JSEventListener.h:
  • bindings/js/JSLazyEventListener.h:
  • bindings/js/JSMutationCallback.h:
  • bindings/js/PageScriptDebugServer.h:
  • bindings/js/ScriptDebugServer.h:
  • bindings/js/WebCoreTypedArrayController.h:
  • bindings/js/WorkerScriptDebugServer.h:
  • bridge/c/c_class.h:
  • bridge/c/c_instance.h:
  • bridge/c/c_runtime.h:
  • bridge/runtime_root.h:
  • crypto/algorithms/CryptoAlgorithmAES_CBC.h:
  • crypto/algorithms/CryptoAlgorithmAES_KW.h:
  • crypto/algorithms/CryptoAlgorithmHMAC.h:
  • crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
  • crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
  • crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
  • crypto/algorithms/CryptoAlgorithmSHA1.h:
  • crypto/algorithms/CryptoAlgorithmSHA224.h:
  • crypto/algorithms/CryptoAlgorithmSHA256.h:
  • crypto/algorithms/CryptoAlgorithmSHA384.h:
  • crypto/algorithms/CryptoAlgorithmSHA512.h:
  • crypto/keys/CryptoKeyAES.h:
  • crypto/keys/CryptoKeyHMAC.h:
  • crypto/keys/CryptoKeyRSA.h:
  • crypto/keys/CryptoKeySerializationRaw.h:
  • crypto/parameters/CryptoAlgorithmAesCbcParams.h:
  • crypto/parameters/CryptoAlgorithmAesKeyGenParams.h:
  • crypto/parameters/CryptoAlgorithmHmacKeyParams.h:
  • crypto/parameters/CryptoAlgorithmHmacParams.h:
  • crypto/parameters/CryptoAlgorithmRsaKeyGenParams.h:
  • crypto/parameters/CryptoAlgorithmRsaKeyParamsWithHash.h:
  • crypto/parameters/CryptoAlgorithmRsaOaepParams.h:
  • crypto/parameters/CryptoAlgorithmRsaSsaParams.h:
  • css/CSSBasicShapes.h:
  • css/CSSCanvasValue.h:
  • css/CSSCharsetRule.h:
  • css/CSSComputedStyleDeclaration.h:
  • css/CSSCrossfadeValue.h:
  • css/CSSFilterImageValue.h:
  • css/CSSFontFaceRule.h:
  • css/CSSFontSelector.h:
  • css/CSSGroupingRule.h:
  • css/CSSHostRule.h:
  • css/CSSImportRule.h:
  • css/CSSMediaRule.h:
  • css/CSSPageRule.h:
  • css/CSSStyleRule.h:
  • css/CSSStyleSheet.h:
  • css/CSSSupportsRule.h:
  • css/CSSUnknownRule.h:
  • css/FontLoader.cpp:
  • css/FontLoader.h:
  • css/PropertySetCSSStyleDeclaration.h:
  • css/WebKitCSSFilterRule.h:
  • css/WebKitCSSKeyframeRule.h:
  • css/WebKitCSSKeyframesRule.h:
  • css/WebKitCSSRegionRule.h:
  • css/WebKitCSSViewportRule.h:
  • dom/Attr.h:
  • dom/BeforeTextInsertedEvent.h:
  • dom/BeforeUnloadEvent.h:
  • dom/CDATASection.h:
  • dom/CharacterData.h:
  • dom/ChildNodeList.h:
  • dom/Clipboard.cpp:
  • dom/ClipboardEvent.h:
  • dom/ContainerNode.h:
  • dom/DOMImplementation.cpp:
  • dom/DatasetDOMStringMap.h:
  • dom/DeviceMotionController.h:
  • dom/DeviceOrientationController.h:
  • dom/Document.h:
  • dom/DocumentEventQueue.cpp:
  • dom/DocumentEventQueue.h:
  • dom/DocumentFragment.h:
  • dom/Element.h:
  • dom/ErrorEvent.h:
  • dom/EventContext.h:
  • dom/EventTarget.h:
  • dom/FocusEvent.h:
  • dom/KeyboardEvent.h:
  • dom/LiveNodeList.h:
  • dom/MessagePort.h:
  • dom/MouseEvent.h:
  • dom/MutationRecord.cpp:
  • dom/Node.h:
  • dom/PageTransitionEvent.h:
  • dom/ProcessingInstruction.h:
  • dom/ProgressEvent.h:
  • dom/PseudoElement.h:
  • dom/ScriptExecutionContext.h:
  • dom/ShadowRoot.h:
  • dom/StaticNodeList.h:
  • dom/StyledElement.h:
  • dom/TagNodeList.h:
  • dom/TemplateContentDocumentFragment.h:
  • dom/Text.h:
  • dom/TextEvent.h:
  • dom/TouchEvent.h:
  • dom/TransitionEvent.h:
  • dom/UIEvent.h:
  • dom/WebKitAnimationEvent.h:
  • dom/WebKitNamedFlow.h:
  • dom/WebKitTransitionEvent.h:
  • editing/AppendNodeCommand.h:
  • editing/ApplyBlockElementCommand.h:
  • editing/ApplyStyleCommand.h:
  • editing/BreakBlockquoteCommand.h:
  • editing/CompositeEditCommand.h:
  • editing/DeleteButton.h:
  • editing/DeleteFromTextNodeCommand.h:
  • editing/EditCommand.h:
  • editing/InsertIntoTextNodeCommand.h:
  • editing/InsertNodeBeforeCommand.h:
  • editing/InsertTextCommand.h:
  • editing/MergeIdenticalElementsCommand.h:
  • editing/RemoveCSSPropertyCommand.h:
  • editing/RemoveNodeCommand.h:
  • editing/ReplaceNodeWithSpanCommand.h:
  • editing/SetNodeAttributeCommand.h:
  • editing/SetSelectionCommand.h:
  • editing/SpellChecker.h:
  • editing/SpellingCorrectionCommand.cpp:
  • editing/SpellingCorrectionCommand.h:
  • editing/SplitElementCommand.h:
  • editing/SplitTextNodeCommand.h:
  • editing/WrapContentsInDummySpanCommand.h:
  • editing/ios/EditorIOS.mm:
  • editing/markup.cpp:
  • fileapi/Blob.cpp:
  • fileapi/Blob.h:
  • fileapi/File.h:
  • fileapi/FileReader.h:
  • fileapi/FileThreadTask.h:
  • history/BackForwardList.h:
  • html/BaseButtonInputType.h:
  • html/BaseCheckableInputType.h:
  • html/BaseChooserOnlyDateAndTimeInputType.h:
  • html/BaseClickableWithKeyInputType.h:
  • html/BaseDateAndTimeInputType.h:
  • html/BaseTextInputType.h:
  • html/ButtonInputType.h:
  • html/CheckboxInputType.h:
  • html/ClassList.h:
  • html/ColorInputType.h:
  • html/DOMSettableTokenList.h:
  • html/DateInputType.h:
  • html/DateTimeInputType.h:
  • html/DateTimeLocalInputType.h:
  • html/EmailInputType.h:
  • html/FTPDirectoryDocument.cpp:
  • html/FileInputType.h:
  • html/FormAssociatedElement.cpp:
  • html/FormAssociatedElement.h:
  • html/HTMLAnchorElement.h:
  • html/HTMLAppletElement.h:
  • html/HTMLAreaElement.h:
  • html/HTMLBRElement.h:
  • html/HTMLBaseElement.h:
  • html/HTMLBodyElement.h:
  • html/HTMLButtonElement.h:
  • html/HTMLCanvasElement.h:
  • html/HTMLDetailsElement.cpp:
  • html/HTMLDetailsElement.h:
  • html/HTMLDivElement.h:
  • html/HTMLDocument.h:
  • html/HTMLElement.h:
  • html/HTMLEmbedElement.h:
  • html/HTMLFieldSetElement.h:
  • html/HTMLFontElement.h:
  • html/HTMLFormControlElement.h:
  • html/HTMLFormControlElementWithState.h:
  • html/HTMLFormControlsCollection.h:
  • html/HTMLFormElement.h:
  • html/HTMLFrameElement.h:
  • html/HTMLFrameElementBase.h:
  • html/HTMLFrameOwnerElement.h:
  • html/HTMLFrameSetElement.h:
  • html/HTMLHRElement.h:
  • html/HTMLHtmlElement.h:
  • html/HTMLIFrameElement.h:
  • html/HTMLImageElement.h:
  • html/HTMLImageLoader.h:
  • html/HTMLInputElement.cpp:
  • html/HTMLInputElement.h:
  • html/HTMLKeygenElement.h:
  • html/HTMLLIElement.h:
  • html/HTMLLabelElement.h:
  • html/HTMLLegendElement.h:
  • html/HTMLLinkElement.h:
  • html/HTMLMapElement.h:
  • html/HTMLMarqueeElement.h:
  • html/HTMLMediaElement.h:
  • html/HTMLMediaSession.h:
  • html/HTMLMediaSource.h:
  • html/HTMLMetaElement.h:
  • html/HTMLMeterElement.h:
  • html/HTMLModElement.h:
  • html/HTMLOListElement.h:
  • html/HTMLObjectElement.h:
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.h:
  • html/HTMLOutputElement.h:
  • html/HTMLParagraphElement.h:
  • html/HTMLParamElement.h:
  • html/HTMLPlugInElement.h:
  • html/HTMLPlugInImageElement.h:
  • html/HTMLPreElement.h:
  • html/HTMLProgressElement.h:
  • html/HTMLQuoteElement.h:
  • html/HTMLScriptElement.h:
  • html/HTMLSelectElement.h:
  • html/HTMLSourceElement.h:
  • html/HTMLStyleElement.h:
  • html/HTMLSummaryElement.h:
  • html/HTMLTableCaptionElement.h:
  • html/HTMLTableCellElement.h:
  • html/HTMLTableColElement.h:
  • html/HTMLTableElement.h:
  • html/HTMLTablePartElement.h:
  • html/HTMLTableRowsCollection.h:
  • html/HTMLTableSectionElement.h:
  • html/HTMLTemplateElement.h:
  • html/HTMLTextAreaElement.h:
  • html/HTMLTextFormControlElement.h:
  • html/HTMLTitleElement.h:
  • html/HTMLTrackElement.h:
  • html/HTMLUListElement.h:
  • html/HTMLUnknownElement.h:
  • html/HTMLVideoElement.h:
  • html/HiddenInputType.h:
  • html/ImageDocument.cpp:
  • html/ImageInputType.h:
  • html/LabelableElement.h:
  • html/LabelsNodeList.h:
  • html/MediaController.h:
  • html/MonthInputType.h:
  • html/NumberInputType.h:
  • html/PasswordInputType.h:
  • html/PluginDocument.h:
  • html/RadioInputType.h:
  • html/RangeInputType.h:
  • html/ResetInputType.h:
  • html/SearchInputType.h:
  • html/SubmitInputType.h:
  • html/TelephoneInputType.h:
  • html/TextFieldInputType.h:
  • html/TextInputType.h:
  • html/TimeInputType.h:
  • html/URLInputType.h:
  • html/WeekInputType.h:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/WebGLRenderingContext.h:
  • html/parser/HTMLDocumentParser.h:
  • html/parser/TextDocumentParser.h:
  • html/shadow/DetailsMarkerControl.h:
  • html/shadow/InsertionPoint.h:
  • html/shadow/MediaControlElementTypes.h:
  • html/shadow/MediaControlElements.h:
  • html/shadow/MediaControls.h:
  • html/shadow/MediaControlsApple.h:
  • html/shadow/MediaControlsGtk.h:
  • html/shadow/MeterShadowElement.h:
  • html/shadow/ProgressShadowElement.h:
  • html/shadow/SliderThumbElement.cpp:
  • html/shadow/SliderThumbElement.h:
  • html/shadow/SpinButtonElement.h:
  • html/shadow/TextControlInnerElements.h:
  • html/shadow/YouTubeEmbedShadowElement.h:
  • html/track/AudioTrack.h:
  • html/track/AudioTrackList.h:
  • html/track/InbandGenericTextTrack.h:
  • html/track/InbandTextTrack.h:
  • html/track/InbandWebVTTTextTrack.h:
  • html/track/LoadableTextTrack.h:
  • html/track/TextTrack.h:
  • html/track/TextTrackCue.h:
  • html/track/TextTrackCueGeneric.cpp:
  • html/track/TextTrackCueGeneric.h:
  • html/track/TextTrackList.h:
  • html/track/TrackListBase.h:
  • html/track/VideoTrack.h:
  • html/track/VideoTrackList.h:
  • html/track/WebVTTElement.h:
  • inspector/CommandLineAPIModule.h:
  • inspector/InjectedScriptCanvasModule.h:
  • inspector/InspectorApplicationCacheAgent.h:
  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorCanvasAgent.h:
  • inspector/InspectorConsoleAgent.cpp:
  • inspector/InspectorConsoleAgent.h:
  • inspector/InspectorController.h:
  • inspector/InspectorDOMAgent.h:
  • inspector/InspectorDOMDebuggerAgent.h:
  • inspector/InspectorDOMStorageAgent.h:
  • inspector/InspectorDatabaseAgent.h:
  • inspector/InspectorDebuggerAgent.h:
  • inspector/InspectorHeapProfilerAgent.h:
  • inspector/InspectorIndexedDBAgent.cpp:
  • inspector/InspectorIndexedDBAgent.h:
  • inspector/InspectorInputAgent.h:
  • inspector/InspectorLayerTreeAgent.h:
  • inspector/InspectorMemoryAgent.h:
  • inspector/InspectorPageAgent.h:
  • inspector/InspectorProfilerAgent.h:
  • inspector/InspectorResourceAgent.h:
  • inspector/InspectorTimelineAgent.h:
  • inspector/InspectorWorkerAgent.h:
  • inspector/PageConsoleAgent.cpp:
  • inspector/PageConsoleAgent.h:
  • inspector/PageInjectedScriptHost.h:
  • inspector/PageInjectedScriptManager.h:
  • inspector/PageRuntimeAgent.h:
  • inspector/WorkerConsoleAgent.h:
  • inspector/WorkerDebuggerAgent.h:
  • inspector/WorkerInspectorController.h:
  • inspector/WorkerRuntimeAgent.h:
  • loader/DocumentLoader.h:
  • loader/EmptyClients.h:
  • loader/FrameNetworkingContext.h:
  • loader/ImageLoader.h:
  • loader/NavigationScheduler.cpp:
  • loader/NetscapePlugInStreamLoader.h:
  • loader/PingLoader.h:
  • loader/ResourceLoader.h:
  • loader/SubresourceLoader.h:
  • loader/WorkerThreadableLoader.h:
  • loader/appcache/ApplicationCacheGroup.cpp:
  • loader/appcache/ApplicationCacheGroup.h:
  • loader/appcache/DOMApplicationCache.h:
  • loader/archive/cf/LegacyWebArchive.h:
  • loader/cache/CachedCSSStyleSheet.h:
  • loader/cache/CachedFont.h:
  • loader/cache/CachedFontClient.h:
  • loader/cache/CachedImage.h:
  • loader/cache/CachedImageClient.h:
  • loader/cache/CachedRawResource.h:
  • loader/cache/CachedRawResourceClient.h:
  • loader/cache/CachedSVGDocument.h:
  • loader/cache/CachedSVGDocumentClient.h:
  • loader/cache/CachedScript.h:
  • loader/cache/CachedShader.h:
  • loader/cache/CachedStyleSheetClient.h:
  • loader/cache/CachedTextTrack.h:
  • loader/cache/CachedXSLStyleSheet.h:
  • loader/icon/IconLoader.h:
  • mathml/MathMLElement.h:
  • mathml/MathMLInlineContainerElement.h:
  • mathml/MathMLMathElement.h:
  • mathml/MathMLSelectElement.h:
  • mathml/MathMLTextElement.h:
  • page/CaptionUserPreferencesMediaAF.h:
  • page/Chrome.h:
  • page/DOMTimer.h:
  • page/DOMWindow.h:
  • page/DOMWindowExtension.h:
  • page/EventSource.h:
  • page/Frame.h:
  • page/FrameView.h:
  • page/PageDebuggable.h:
  • page/PageSerializer.cpp:
  • page/Performance.h:
  • page/SuspendableTimer.h:
  • page/animation/ImplicitAnimation.h:
  • page/animation/KeyframeAnimation.h:
  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ScrollingConstraints.h:
  • page/scrolling/ScrollingStateFixedNode.h:
  • page/scrolling/ScrollingStateScrollingNode.h:
  • page/scrolling/ScrollingStateStickyNode.h:
  • page/scrolling/ScrollingTreeScrollingNode.h:
  • page/scrolling/ThreadedScrollingTree.h:
  • page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.h:
  • page/scrolling/ios/ScrollingCoordinatorIOS.h:
  • page/scrolling/ios/ScrollingTreeIOS.h:
  • page/scrolling/ios/ScrollingTreeScrollingNodeIOS.h:
  • page/scrolling/mac/ScrollingCoordinatorMac.h:
  • page/scrolling/mac/ScrollingTreeFixedNode.h:
  • page/scrolling/mac/ScrollingTreeScrollingNodeMac.h:
  • page/scrolling/mac/ScrollingTreeStickyNode.h:
  • pdf/ios/PDFDocument.cpp:
  • pdf/ios/PDFDocument.h:
  • platform/CalculationValue.h:
  • platform/ClockGeneric.h:
  • platform/MainThreadTask.h:
  • platform/PODIntervalTree.h:
  • platform/PODRedBlackTree.h:
  • platform/RefCountedSupplement.h:
  • platform/ScrollView.h:
  • platform/Scrollbar.h:
  • platform/Timer.h:
  • platform/animation/TimingFunction.h:
  • platform/audio/AudioDSPKernelProcessor.h:
  • platform/audio/EqualPowerPanner.h:
  • platform/audio/HRTFPanner.h:
  • platform/audio/ios/AudioDestinationIOS.h:
  • platform/audio/mac/AudioDestinationMac.h:
  • platform/audio/nix/AudioDestinationNix.h:
  • platform/efl/RenderThemeEfl.h:
  • platform/efl/ScrollbarEfl.h:
  • platform/efl/ScrollbarThemeEfl.h:
  • platform/graphics/AudioTrackPrivate.h:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/CrossfadeGeneratedImage.h:
  • platform/graphics/FloatPolygon.h:
  • platform/graphics/GeneratedImage.h:
  • platform/graphics/GradientImage.h:
  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/InbandTextTrackPrivate.h:
  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/VideoTrackPrivate.h:
  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
  • platform/graphics/avfoundation/VideoTrackPrivateAVF.h:
  • platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.h:
  • platform/graphics/avfoundation/cf/InbandTextTrackPrivateLegacyAVCF.h:
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h:
  • platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/InbandTextTrackPrivateLegacyAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
  • platform/graphics/avfoundation/objc/VideoTrackPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:
  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/mac/PlatformCALayerMac.h:
  • platform/graphics/ca/mac/TileController.h:
  • platform/graphics/ca/win/LegacyCACFLayerTreeHost.h:
  • platform/graphics/ca/win/PlatformCALayerWin.h:
  • platform/graphics/ca/win/WKCACFViewLayerTreeHost.h:
  • platform/graphics/cg/PDFDocumentImage.h:
  • platform/graphics/efl/GraphicsContext3DPrivate.h:
  • platform/graphics/egl/GLContextFromCurrentEGL.h:
  • platform/graphics/filters/DistantLightSource.h:
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FEDisplacementMap.h:
  • platform/graphics/filters/FEFlood.h:
  • platform/graphics/filters/FilterOperation.h:
  • platform/graphics/filters/PointLightSource.h:
  • platform/graphics/filters/SpotLightSource.h:
  • platform/graphics/gstreamer/AudioTrackPrivateGStreamer.h:
  • platform/graphics/gstreamer/InbandMetadataTextTrackPrivateGStreamer.h:
  • platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
  • platform/graphics/gstreamer/VideoTrackPrivateGStreamer.h:
  • platform/graphics/ios/InbandTextTrackPrivateAVFIOS.h:
  • platform/graphics/ios/MediaPlayerPrivateIOS.h:
  • platform/graphics/ios/TextTrackRepresentationIOS.h:
  • platform/graphics/surfaces/GLTransportSurface.h:
  • platform/graphics/surfaces/egl/EGLContext.h:
  • platform/graphics/surfaces/egl/EGLSurface.h:
  • platform/graphics/surfaces/egl/EGLXSurface.h:
  • platform/graphics/surfaces/glx/GLXContext.h:
  • platform/graphics/surfaces/glx/GLXSurface.h:
  • platform/graphics/texmap/GraphicsLayerTextureMapper.h:
  • platform/graphics/texmap/TextureMapperGL.h:
  • platform/graphics/texmap/TextureMapperImageBuffer.h:
  • platform/graphics/texmap/TextureMapperLayer.h:
  • platform/graphics/texmap/TextureMapperTiledBackingStore.h:
  • platform/graphics/texmap/coordinated/CompositingCoordinator.h:
  • platform/graphics/texmap/coordinated/CoordinatedBackingStore.h:
  • platform/graphics/texmap/coordinated/CoordinatedCustomFilterProgram.h:
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
  • platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:
  • platform/graphics/texmap/coordinated/CoordinatedTile.h:
  • platform/graphics/texmap/coordinated/UpdateAtlas.cpp:
  • platform/gtk/RenderThemeGtk.h:
  • platform/ios/DeviceMotionClientIOS.h:
  • platform/ios/DeviceOrientationClientIOS.h:
  • platform/ios/ScrollAnimatorIOS.h:
  • platform/ios/ScrollbarThemeIOS.h:
  • platform/ios/WebSafeGCActivityCallbackIOS.h:
  • platform/ios/WebSafeIncrementalSweeperIOS.h:
  • platform/mac/PlatformClockCA.h:
  • platform/mac/PlatformClockCM.h:
  • platform/mac/ScrollAnimatorMac.h:
  • platform/mac/ScrollbarThemeMac.h:
  • platform/mediastream/MediaStreamTrackPrivate.h:
  • platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
  • platform/mediastream/mac/AVAudioCaptureSource.h:
  • platform/mediastream/mac/AVMediaCaptureSource.h:
  • platform/mediastream/mac/AVVideoCaptureSource.h:
  • platform/mediastream/mac/MediaStreamCenterMac.h:
  • platform/mock/DeviceMotionClientMock.h:
  • platform/mock/DeviceOrientationClientMock.h:
  • platform/mock/MockMediaStreamCenter.h:
  • platform/mock/RTCDataChannelHandlerMock.h:
  • platform/mock/RTCNotifiersMock.h:
  • platform/mock/RTCPeerConnectionHandlerMock.h:
  • platform/mock/mediasource/MockMediaPlayerMediaSource.h:
  • platform/mock/mediasource/MockMediaSourcePrivate.h:
  • platform/mock/mediasource/MockSourceBufferPrivate.cpp:
  • platform/mock/mediasource/MockSourceBufferPrivate.h:
  • platform/network/BlobRegistryImpl.h:
  • platform/network/BlobResourceHandle.cpp:
  • platform/network/BlobResourceHandle.h:
  • platform/network/ResourceHandle.h:
  • platform/network/SynchronousLoaderClient.h:
  • platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.h:
  • platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.h:
  • platform/nix/RenderThemeNix.h:
  • platform/nix/ScrollbarThemeNix.h:
  • platform/text/LocaleICU.h:
  • platform/text/LocaleNone.cpp:
  • platform/text/PlatformLocale.cpp:
  • platform/text/mac/LocaleMac.h:
  • platform/text/win/LocaleWin.h:
  • platform/win/PopupMenuWin.h:
  • plugins/PluginView.h:
  • rendering/AutoTableLayout.h:
  • rendering/ClipPathOperation.h:
  • rendering/EllipsisBox.h:
  • rendering/FilterEffectRenderer.h:
  • rendering/FixedTableLayout.h:
  • rendering/InlineElementBox.h:
  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.h:
  • rendering/RenderBlock.h:
  • rendering/RenderBlockFlow.h:
  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.h:
  • rendering/RenderButton.h:
  • rendering/RenderCombineText.h:
  • rendering/RenderCounter.h:
  • rendering/RenderDeprecatedFlexibleBox.h:
  • rendering/RenderDetailsMarker.h:
  • rendering/RenderElement.h:
  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.h:
  • rendering/RenderFlexibleBox.h:
  • rendering/RenderFlowThread.h:
  • rendering/RenderFrame.h:
  • rendering/RenderFrameSet.h:
  • rendering/RenderFullScreen.h:
  • rendering/RenderGrid.h:
  • rendering/RenderHTMLCanvas.h:
  • rendering/RenderIFrame.h:
  • rendering/RenderImage.h:
  • rendering/RenderImageResourceStyleImage.h:
  • rendering/RenderInline.h:
  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.h:
  • rendering/RenderLayerFilterInfo.h:
  • rendering/RenderLayerModelObject.h:
  • rendering/RenderLineBreak.h:
  • rendering/RenderListBox.h:
  • rendering/RenderListItem.h:
  • rendering/RenderListMarker.h:
  • rendering/RenderMedia.h:
  • rendering/RenderMenuList.h:
  • rendering/RenderMeter.h:
  • rendering/RenderMultiColumnBlock.h:
  • rendering/RenderMultiColumnFlowThread.h:
  • rendering/RenderMultiColumnSet.h:
  • rendering/RenderNamedFlowFragment.h:
  • rendering/RenderNamedFlowThread.h:
  • rendering/RenderObject.h:
  • rendering/RenderProgress.h:
  • rendering/RenderQuote.h:
  • rendering/RenderRegion.h:
  • rendering/RenderRegionSet.h:
  • rendering/RenderReplaced.h:
  • rendering/RenderReplica.h:
  • rendering/RenderRuby.h:
  • rendering/RenderRubyRun.h:
  • rendering/RenderRubyText.h:
  • rendering/RenderScrollbar.h:
  • rendering/RenderScrollbarPart.h:
  • rendering/RenderScrollbarTheme.h:
  • rendering/RenderSearchField.h:
  • rendering/RenderSlider.h:
  • rendering/RenderSnapshottedPlugIn.h:
  • rendering/RenderTable.h:
  • rendering/RenderTableCaption.h:
  • rendering/RenderTableCell.h:
  • rendering/RenderTableCol.h:
  • rendering/RenderTableRow.h:
  • rendering/RenderTableSection.h:
  • rendering/RenderText.h:
  • rendering/RenderTextControl.h:
  • rendering/RenderTextControlMultiLine.h:
  • rendering/RenderTextControlSingleLine.h:
  • rendering/RenderTextFragment.h:
  • rendering/RenderTextTrackCue.h:
  • rendering/RenderThemeIOS.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeSafari.h:
  • rendering/RenderThemeWin.h:
  • rendering/RenderVideo.h:
  • rendering/RenderView.h:
  • rendering/RenderWidget.h:
  • rendering/RootInlineBox.h:
  • rendering/mathml/RenderMathMLBlock.h:
  • rendering/mathml/RenderMathMLFenced.h:
  • rendering/mathml/RenderMathMLFraction.h:
  • rendering/mathml/RenderMathMLMath.h:
  • rendering/mathml/RenderMathMLOperator.h:
  • rendering/mathml/RenderMathMLRoot.h:
  • rendering/mathml/RenderMathMLRow.h:
  • rendering/mathml/RenderMathMLScripts.h:
  • rendering/mathml/RenderMathMLSpace.h:
  • rendering/mathml/RenderMathMLSquareRoot.h:
  • rendering/mathml/RenderMathMLUnderOver.h:
  • rendering/shapes/BoxShape.h:
  • rendering/shapes/PolygonShape.h:
  • rendering/shapes/RasterShape.h:
  • rendering/shapes/RectangleShape.h:
  • rendering/shapes/ShapeInsideInfo.h:
  • rendering/shapes/ShapeOutsideInfo.h:
  • rendering/style/BasicShapes.h:
  • rendering/style/ContentData.h:
  • rendering/style/StyleCachedImage.h:
  • rendering/style/StyleCachedImageSet.h:
  • rendering/style/StyleGeneratedImage.h:
  • rendering/style/StylePendingImage.h:
  • rendering/svg/RenderSVGBlock.h:
  • rendering/svg/RenderSVGContainer.h:
  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGGradientStop.h:
  • rendering/svg/RenderSVGHiddenContainer.h:
  • rendering/svg/RenderSVGImage.h:
  • rendering/svg/RenderSVGInline.h:
  • rendering/svg/RenderSVGInlineText.h:
  • rendering/svg/RenderSVGModelObject.h:
  • rendering/svg/RenderSVGPath.h:
  • rendering/svg/RenderSVGResourceClipper.h:
  • rendering/svg/RenderSVGResourceContainer.h:
  • rendering/svg/RenderSVGResourceFilter.h:
  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourceLinearGradient.h:
  • rendering/svg/RenderSVGResourceMarker.h:
  • rendering/svg/RenderSVGResourceMasker.h:
  • rendering/svg/RenderSVGResourcePattern.h:
  • rendering/svg/RenderSVGResourceRadialGradient.h:
  • rendering/svg/RenderSVGResourceSolidColor.h:
  • rendering/svg/RenderSVGRoot.h:
  • rendering/svg/RenderSVGShape.cpp:
  • rendering/svg/RenderSVGShape.h:
  • rendering/svg/RenderSVGText.h:
  • rendering/svg/RenderSVGTextPath.h:
  • rendering/svg/RenderSVGViewportContainer.h:
  • rendering/svg/SVGInlineFlowBox.h:
  • rendering/svg/SVGInlineTextBox.h:
  • rendering/svg/SVGRootInlineBox.h:
  • rendering/svg/SVGTextRunRenderingContext.h:
  • storage/StorageAreaImpl.h:
  • storage/StorageNamespaceImpl.h:
  • svg/SVGAElement.h:
  • svg/SVGAltGlyphDefElement.h:
  • svg/SVGAltGlyphElement.h:
  • svg/SVGAltGlyphItemElement.h:
  • svg/SVGAnimateElement.h:
  • svg/SVGAnimateMotionElement.h:
  • svg/SVGAnimateTransformElement.h:
  • svg/SVGAnimatedAngle.h:
  • svg/SVGAnimatedBoolean.h:
  • svg/SVGAnimatedColor.h:
  • svg/SVGAnimatedEnumeration.h:
  • svg/SVGAnimatedInteger.h:
  • svg/SVGAnimatedIntegerOptionalInteger.h:
  • svg/SVGAnimatedLength.h:
  • svg/SVGAnimatedLengthList.h:
  • svg/SVGAnimatedNumber.h:
  • svg/SVGAnimatedNumberList.h:
  • svg/SVGAnimatedNumberOptionalNumber.h:
  • svg/SVGAnimatedPath.h:
  • svg/SVGAnimatedPointList.h:
  • svg/SVGAnimatedPreserveAspectRatio.h:
  • svg/SVGAnimatedRect.h:
  • svg/SVGAnimatedString.h:
  • svg/SVGAnimatedTransformList.h:
  • svg/SVGAnimationElement.h:
  • svg/SVGCircleElement.h:
  • svg/SVGClipPathElement.h:
  • svg/SVGComponentTransferFunctionElement.h:
  • svg/SVGCursorElement.h:
  • svg/SVGDefsElement.h:
  • svg/SVGDocument.h:
  • svg/SVGElement.h:
  • svg/SVGElementInstance.h:
  • svg/SVGEllipseElement.h:
  • svg/SVGFEBlendElement.h:
  • svg/SVGFEColorMatrixElement.h:
  • svg/SVGFEComponentTransferElement.h:
  • svg/SVGFECompositeElement.h:
  • svg/SVGFEConvolveMatrixElement.h:
  • svg/SVGFEDiffuseLightingElement.h:
  • svg/SVGFEDisplacementMapElement.h:
  • svg/SVGFEDropShadowElement.h:
  • svg/SVGFEGaussianBlurElement.h:
  • svg/SVGFEImageElement.h:
  • svg/SVGFELightElement.h:
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEMorphologyElement.h:
  • svg/SVGFEOffsetElement.h:
  • svg/SVGFESpecularLightingElement.h:
  • svg/SVGFETileElement.h:
  • svg/SVGFETurbulenceElement.h:
  • svg/SVGFilterElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/SVGFontElement.h:
  • svg/SVGFontFaceElement.h:
  • svg/SVGFontFaceFormatElement.h:
  • svg/SVGFontFaceNameElement.h:
  • svg/SVGFontFaceSrcElement.h:
  • svg/SVGFontFaceUriElement.h:
  • svg/SVGForeignObjectElement.h:
  • svg/SVGGElement.h:
  • svg/SVGGlyphElement.h:
  • svg/SVGGlyphRefElement.h:
  • svg/SVGGradientElement.h:
  • svg/SVGGraphicsElement.h:
  • svg/SVGHKernElement.h:
  • svg/SVGImageElement.h:
  • svg/SVGLineElement.h:
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMPathElement.h:
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.h:
  • svg/SVGMetadataElement.h:
  • svg/SVGPathElement.h:
  • svg/SVGPathStringBuilder.h:
  • svg/SVGPatternElement.h:
  • svg/SVGPolyElement.h:
  • svg/SVGRadialGradientElement.h:
  • svg/SVGRectElement.h:
  • svg/SVGSVGElement.h:
  • svg/SVGScriptElement.h:
  • svg/SVGSetElement.h:
  • svg/SVGStopElement.h:
  • svg/SVGStyleElement.h:
  • svg/SVGSwitchElement.h:
  • svg/SVGSymbolElement.h:
  • svg/SVGTRefElement.cpp:
  • svg/SVGTRefElement.h:
  • svg/SVGTSpanElement.h:
  • svg/SVGTextContentElement.h:
  • svg/SVGTextElement.h:
  • svg/SVGTextPathElement.h:
  • svg/SVGTextPositioningElement.h:
  • svg/SVGTitleElement.h:
  • svg/SVGTransformable.h:
  • svg/SVGUnknownElement.h:
  • svg/SVGUseElement.h:
  • svg/SVGVKernElement.h:
  • svg/SVGViewElement.h:
  • svg/animation/SVGSMILElement.h:
  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageForContainer.h:
  • svg/graphics/filters/SVGFilter.h:
  • svg/properties/SVGAnimatedListPropertyTearOff.h:
  • svg/properties/SVGAnimatedTransformListPropertyTearOff.h:
  • svg/properties/SVGListPropertyTearOff.h:
  • svg/properties/SVGPathSegListPropertyTearOff.h:
  • svg/properties/SVGPropertyTearOff.h:
  • testing/InternalSettings.cpp:
  • testing/Internals.cpp:
  • testing/MockCDM.cpp:
  • testing/MockCDM.h:
  • workers/AbstractWorker.h:
  • workers/DedicatedWorkerGlobalScope.h:
  • workers/DedicatedWorkerThread.h:
  • workers/SharedWorker.h:
  • workers/SharedWorkerGlobalScope.h:
  • workers/SharedWorkerThread.h:
  • workers/Worker.h:
  • workers/WorkerEventQueue.cpp:
  • workers/WorkerEventQueue.h:
  • workers/WorkerGlobalScope.h:
  • workers/WorkerMessagingProxy.h:
  • workers/WorkerObjectProxy.h:
  • workers/WorkerScriptLoader.h:
  • workers/WorkerThread.cpp:
  • xml/XMLHttpRequest.h:
  • xml/XMLHttpRequestUpload.h:
  • xml/XPathFunctions.cpp:
  • xml/XPathPath.h:
  • xml/XPathPredicate.h:
  • xml/XSLStyleSheet.h:

Source/WebKit/efl:

  • WebCoreSupport/InspectorClientEfl.h:
  • WebCoreSupport/ProgressTrackerClientEfl.h:

Source/WebKit/gtk:

  • WebCoreSupport/EditorClientGtk.h:
  • WebCoreSupport/InspectorClientGtk.h:
  • WebCoreSupport/ProgressTrackerClientGtk.h:

Source/WebKit/ios:

  • Misc/EmojiFallbackFontSelector.h:
  • Storage/WebSQLiteDatabaseTrackerClient.h:
  • WebCoreSupport/PopupMenuIOS.h:
  • WebCoreSupport/SearchPopupMenuIOS.h:
  • WebCoreSupport/WebChromeClientIOS.h:
  • WebCoreSupport/WebDiskImageCacheClientIOS.h:

Source/WebKit/mac:

  • Storage/WebDatabaseManagerClient.h:
  • Storage/WebStorageTrackerClient.h:
  • WebCoreSupport/WebAlternativeTextClient.h:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebContextMenuClient.h:
  • WebCoreSupport/WebDeviceOrientationClient.h:
  • WebCoreSupport/WebDragClient.h:
  • WebCoreSupport/WebEditorClient.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameNetworkingContext.h:
  • WebCoreSupport/WebGeolocationClient.h:
  • WebCoreSupport/WebIconDatabaseClient.h:
  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebNotificationClient.h:
  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebProgressTrackerClient.h:
  • WebCoreSupport/WebUserMediaClient.h:
  • WebView/WebScriptDebugger.h:
  • WebView/WebViewData.h:

Source/WebKit/win:

  • AccessibleDocument.h:
  • FullscreenVideoController.cpp:
  • WebCoreSupport/WebChromeClient.h:
  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameNetworkingContext.h:
  • WebCoreSupport/WebInspectorClient.h:
  • WebHistory.h:

Source/WebKit/wince:

  • WebCoreSupport/ChromeClientWinCE.h:
  • WebCoreSupport/ContextMenuClientWinCE.h:
  • WebCoreSupport/DragClientWinCE.h:
  • WebCoreSupport/EditorClientWinCE.h:
  • WebCoreSupport/FrameLoaderClientWinCE.h:
  • WebCoreSupport/FrameNetworkingContextWinCE.h:
  • WebCoreSupport/InspectorClientWinCE.h:
  • WebCoreSupport/PlatformStrategiesWinCE.h:

Source/WebKit2:

  • DatabaseProcess/DatabaseProcess.h:
  • DatabaseProcess/DatabaseToWebProcessConnection.h:
  • DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.h:
  • DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.h:
  • NetworkProcess/AsynchronousNetworkLoaderClient.h:
  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcessPlatformStrategies.h:
  • NetworkProcess/NetworkResourceLoader.h:
  • NetworkProcess/RemoteNetworkingContext.h:
  • NetworkProcess/SynchronousNetworkLoaderClient.h:
  • NetworkProcess/mac/DiskCacheMonitor.h:
  • PluginProcess/EntryPoint/mac/LegacyProcess/PluginProcessMain.mm:
  • PluginProcess/PluginControllerProxy.h:
  • PluginProcess/PluginProcess.h:
  • PluginProcess/WebProcessConnection.h:
  • Shared/API/Cocoa/RemoteObjectRegistry.h:
  • Shared/APIObject.h:
  • Shared/AsyncRequest.h:
  • Shared/AsyncTask.h:
  • Shared/Authentication/AuthenticationManager.h:
  • Shared/ChildProcess.h:
  • Shared/ChildProcessProxy.h:
  • Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
  • Shared/Downloads/Download.h:
  • Shared/Network/CustomProtocols/CustomProtocolManager.h:
  • Shared/WebConnection.h:
  • Shared/WebResourceBuffer.h:
  • Shared/cf/KeyedEncoder.h:
  • Shared/mac/SecItemShim.h:
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:
  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/ios/PageClientImplIOS.h:
  • UIProcess/API/mac/PageClientImpl.h:
  • UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
  • UIProcess/CoordinatedGraphics/WebView.h:
  • UIProcess/Databases/DatabaseProcessProxy.h:
  • UIProcess/Downloads/DownloadProxy.h:
  • UIProcess/DrawingAreaProxy.h:
  • UIProcess/Network/CustomProtocols/CustomProtocolManagerProxy.h:
  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Notifications/WebNotificationManagerProxy.h:
  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/Scrolling/RemoteScrollingTree.h:
  • UIProcess/Storage/StorageManager.h:
  • UIProcess/WebApplicationCacheManagerProxy.h:
  • UIProcess/WebBatteryManagerProxy.h:
  • UIProcess/WebConnectionToWebProcess.h:
  • UIProcess/WebContext.h:
  • UIProcess/WebCookieManagerProxy.h:
  • UIProcess/WebDatabaseManagerProxy.h:
  • UIProcess/WebFullScreenManagerProxy.h:
  • UIProcess/WebGeolocationManagerProxy.h:
  • UIProcess/WebIconDatabase.h:
  • UIProcess/WebInspectorProxy.h:
  • UIProcess/WebKeyValueStorageManager.h:
  • UIProcess/WebMediaCacheManagerProxy.h:
  • UIProcess/WebNetworkInfoManagerProxy.h:
  • UIProcess/WebOriginDataManagerProxy.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessProxy.h:
  • UIProcess/WebResourceCacheManagerProxy.h:
  • UIProcess/WebVibrationProxy.h:
  • UIProcess/efl/PageViewportControllerClientEfl.h:
  • UIProcess/efl/WebViewEfl.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
  • UIProcess/mac/SecItemShimProxy.h:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
  • UIProcess/mac/ViewGestureController.h:
  • UIProcess/mac/WebColorPickerMac.h:
  • UIProcess/soup/WebSoupRequestManagerProxy.h:
  • WebProcess/ApplicationCache/WebApplicationCacheManager.h:
  • WebProcess/Battery/WebBatteryManager.h:
  • WebProcess/Cookies/WebCookieManager.h:
  • WebProcess/Databases/IndexedDB/WebIDBFactoryBackend.h:
  • WebProcess/Databases/IndexedDB/WebIDBServerConnection.h:
  • WebProcess/Databases/WebToDatabaseProcessConnection.h:
  • WebProcess/EntryPoint/mac/LegacyProcess/WebContentProcessMain.mm:
  • WebProcess/FileAPI/BlobRegistryProxy.h:
  • WebProcess/Geolocation/WebGeolocationManager.h:
  • WebProcess/IconDatabase/WebIconDatabaseProxy.h:
  • WebProcess/InjectedBundle/API/c/mac/WKBundlePageBannerMac.mm:
  • WebProcess/MediaCache/WebMediaCacheManager.h:
  • WebProcess/Network/NetworkProcessConnection.h:
  • WebProcess/Network/WebResourceLoadScheduler.h:
  • WebProcess/Network/WebResourceLoader.h:
  • WebProcess/NetworkInfo/WebNetworkInfoManager.h:
  • WebProcess/Notifications/WebNotificationManager.h:
  • WebProcess/OriginData/WebOriginDataManager.h:
  • WebProcess/Plugins/Netscape/NetscapePlugin.h:
  • WebProcess/Plugins/PDF/PDFPlugin.h:
  • WebProcess/Plugins/PDF/PDFPluginAnnotation.h:
  • WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.h:
  • WebProcess/Plugins/PDF/PDFPluginPasswordField.h:
  • WebProcess/Plugins/PDF/PDFPluginTextAnnotation.h:
  • WebProcess/Plugins/PluginProcessConnection.h:
  • WebProcess/Plugins/PluginProcessConnectionManager.h:
  • WebProcess/Plugins/PluginProxy.h:
  • WebProcess/Plugins/PluginView.h:
  • WebProcess/ResourceCache/WebResourceCacheManager.h:
  • WebProcess/Scrolling/RemoteScrollingCoordinator.h:
  • WebProcess/Storage/StorageAreaImpl.h:
  • WebProcess/Storage/StorageAreaMap.h:
  • WebProcess/Storage/StorageNamespaceImpl.h:
  • WebProcess/WebConnectionToUIProcess.h:
  • WebProcess/WebCoreSupport/WebAlternativeTextClient.h:
  • WebProcess/WebCoreSupport/WebBatteryClient.h:
  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/WebColorChooser.h:
  • WebProcess/WebCoreSupport/WebContextMenuClient.h:
  • WebProcess/WebCoreSupport/WebDatabaseManager.h:
  • WebProcess/WebCoreSupport/WebDeviceProximityClient.h:
  • WebProcess/WebCoreSupport/WebDragClient.h:
  • WebProcess/WebCoreSupport/WebEditorClient.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebCoreSupport/WebGeolocationClient.h:
  • WebProcess/WebCoreSupport/WebInspectorClient.h:
  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.h:
  • WebProcess/WebCoreSupport/WebNavigatorContentUtilsClient.h:
  • WebProcess/WebCoreSupport/WebNetworkInfoClient.h:
  • WebProcess/WebCoreSupport/WebNotificationClient.h:
  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:
  • WebProcess/WebCoreSupport/WebPopupMenu.h:
  • WebProcess/WebCoreSupport/WebProgressTrackerClient.h:
  • WebProcess/WebCoreSupport/WebSearchPopupMenu.h:
  • WebProcess/WebCoreSupport/WebVibrationClient.h:
  • WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedDrawingArea.h:
  • WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/EventDispatcher.h:
  • WebProcess/WebPage/ViewGestureGeometryCollector.h:
  • WebProcess/WebPage/WebBackForwardListProxy.h:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
  • WebProcess/WebPage/mac/GraphicsLayerCARemote.h:
  • WebProcess/WebPage/mac/PlatformCALayerRemote.h:
  • WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:
  • WebProcess/WebPage/mac/PlatformCALayerRemoteTiledBacking.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeContext.h:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
  • WebProcess/WebProcess.h:
  • WebProcess/soup/WebSoupRequestManager.h:

Source/WTF:

  • wtf/Compiler.h:
  • wtf/FilePrintStream.h:
  • wtf/RunLoop.h:
  • wtf/StringPrintStream.h:

Tools:

  • DumpRenderTree/gtk/fonts/fonts.conf:
  • Scripts/do-webcore-rename:

Removed this rename operation from the list of contemplated future renames.

  • TestWebKitAPI/Tests/WebKit2/DidAssociateFormControls_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/InjectedBundleFrameHitTest_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2/WillLoad_Bundle.cpp:
  • TestWebKitAPI/Tests/WebKit2ObjC/CustomProtocolsInvalidScheme_Bundle.cpp:
  • TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
11:34 AM Changeset in webkit [162138] by Beth Dakin
  • 2 edits in trunk/Source/WebCore

Speculative Win Cairo build fix.

These need to be inside an ifdef.

  • page/FrameView.cpp:

(WebCore::FrameView::hasExtendedBackground):
(WebCore::FrameView::extendedBackgroundRect):

11:23 AM Changeset in webkit [162137] by berto@igalia.com
  • 2 edits in trunk/Source/WTF

Source/WTF/wtf/Atomics.h:300: Error: bad register name `%bpl'
​https://bugs.webkit.org/show_bug.cgi?id=126985

Reviewed by Csaba Osztrogonác.

Use the 'q' constraint to force using a register that allows
access to its lower byte.

  • wtf/Atomics.h:

(WTF::weakCompareAndSwap):

11:06 AM Changeset in webkit [162136] by BJ Burg
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: add probe breakpoint action to popup breakpoint editor
​https://bugs.webkit.org/show_bug.cgi?id=126931

Reviewed by Timothy Hatcher.

Add probes to the breakpoint action dropdown.
Reuse the "evaluate JavaScript" input UI.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/BreakpointAction.js:
  • UserInterface/BreakpointActionView.js:

(WebInspector.BreakpointActionView.displayStringForType):
(WebInspector.BreakpointActionView.prototype._updateBody.switch.break):

10:47 AM Changeset in webkit [162135] by mmaxfield@apple.com
  • 19 edits
    6 adds in trunk

text-emphasis-position CSS property doesn't recognize 'left' and 'right'
​https://bugs.webkit.org/show_bug.cgi?id=126611

Reviewed by Simon Fraser.

Source/WebCore:

This patch allows the text-emphasis-position to accept the "left" and
"right" CSS values. In horizontal writing modes, these values no not
change behavior. In vertical writing modes, however, these values specify
which side to place the emphasis mark. Similarly, in vertical writing
modes, the "above" and "below" values should not change behavior.

However, in order to keep existing behavior, if neither "left" nor "right"
is specified, we should draw as if the appropriate value were
specified ("over" -> "right" and "under" -> "left"). Note that this
will have to be updated when we implement the
"text-orientation: sideways-left" CSS property.

Tests: fast/text/emphasis-horizontal-left-right.html

fast/text/emphasis-vertical-over-right.html
fast/text/emphasis-vertical-over-under.html

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::renderEmphasisPositionFlagsToCSSValue):
(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTextEmphasisPosition):

  • css/CSSParser.h:
  • css/CSSPrimitiveValueMappings.h:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::valueToEmphasisPosition):
(WebCore::ApplyPropertyTextEmphasisPosition::applyValue):
(WebCore::ApplyPropertyTextEmphasisPosition::createHandler):
(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment):
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment):

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::emphasisMarkExistsAndIsAbove):
(WebCore::InlineTextBox::paint):

  • rendering/InlineTextBox.h:
  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):

  • rendering/style/StyleRareInheritedData.h:

LayoutTests:

With regards to text-emphasis-position, "left" and "right" are only valid in
vertical writing modes, and "over" and "under" are only valid in horizontal
writing modes.

In order to keep in line with existing pages, specifying "under" without
"left" or "right" should draw text as if "under left" was specified (and
vice-versa).

The default value for text-emphasis-position should be "over right".

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • fast/css/parsing-text-emphasis-expected.txt:
  • fast/css/parsing-text-emphasis.html:
  • fast/text/emphasis-horizontal-left-right-expected.html: Added.
  • fast/text/emphasis-horizontal-left-right.html: Added.
  • fast/text/emphasis-vertical-over-right-expected.html: Added.
  • fast/text/emphasis-vertical-over-right.html: Added.
  • fast/text/emphasis-vertical-over-under-expected.html: Added.
  • fast/text/emphasis-vertical-over-under.html: Added.
10:21 AM Changeset in webkit [162134] by Michał Pakuła vel Rutka
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Add failure test expectations for tests introduced in r162117.

  • platform/efl-wk2/TestExpectations:
9:43 AM Changeset in webkit [162133] by oliver@apple.com
  • 2 edits in trunk/Tools

Stop run-jsc from consuming stderr output
​https://bugs.webkit.org/show_bug.cgi?id=127115

Reviewed by Mark Lam.

Simple patch to make run-jsc easier to deal with

  • Scripts/run-jsc:
9:33 AM Changeset in webkit [162132] by Chris Fleizach
  • 7 edits
    2 adds in trunk

AX: WebKit is not firing AXMenuOpenedNotification
​https://bugs.webkit.org/show_bug.cgi?id=126993

Reviewed by Mario Sanchez Prada.

Source/WebCore:

To monitor for menu open notifications, we need to know which children are added to
the render tree, so the childrenChanged() method has been updated to allow for that.
Once we know the new child, we can then check what kind of role it has.

I also found a flakiness issue with DRT where posting a notification back to DRT
would sometimes cause a new notification to be queued, which would then be lost when the
queue was cleared. This was fixed by copying the notifications to post before iterating them.

Test: platform/mac/accessibility/aria-menu-open-notification.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::checkForOpenMenu):
(WebCore::AXObjectCache::childrenChanged):
(WebCore::AXObjectCache::notificationPostTimerFired):

  • accessibility/AXObjectCache.h:

(WebCore::AXObjectCache::childrenChanged):

  • accessibility/AccessibilityNodeObject.h:
  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::styleWillChange):

LayoutTests:

  • platform/mac/accessibility/aria-menu-open-notification-expected.txt: Added.
  • platform/mac/accessibility/aria-menu-open-notification.html: Added.
9:07 AM Changeset in webkit [162131] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

Merged some more subpixel skipped tests. Unreviewed.

webkit.org/b/126891 is a duplicate of webkit.org/b/126892

  • platform/mac/TestExpectations:
9:03 AM Changeset in webkit [162130] by Chris Fleizach
  • 9 edits
    2 adds in trunk

AX: WebKit is not firing AXMenuItemSelectedNotification
​https://bugs.webkit.org/show_bug.cgi?id=127081

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Monitor for when a menu item either gains focus() or has aria-selected set,
in which case, we need to fire a specific notification.

Test: platform/mac/accessibility/aria-menu-item-selected-notification.html

  • accessibility/AXObjectCache.cpp:

(WebCore::nodeHasRole):

This method was declared in the header, but never implemented, leading to compilation issues.

(WebCore::AXObjectCache::handleMenuItemSelected):
(WebCore::AXObjectCache::handleFocusedUIElementChanged):

Allow the core class to handle focus changes first, then pass off to platform

(WebCore::AXObjectCache::selectedChildrenChanged):

  • accessibility/AXObjectCache.h:
  • accessibility/ios/AXObjectCacheIOS.mm:

(WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):

  • accessibility/mac/AXObjectCacheMac.mm:

(WebCore::AXObjectCache::postPlatformNotification):
(WebCore::AXObjectCache::platformHandleFocusedUIElementChanged):

  • accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeNames]):

Allow menu items to expose a description attribute.

LayoutTests:

  • platform/mac/accessibility/aria-menu-item-selected-notification-expected.txt: Added.
  • platform/mac/accessibility/aria-menu-item-selected-notification.html: Added.
8:14 AM Changeset in webkit [162129] by Alan Bujtas
  • 2 edits in trunk/WebKitLibraries

Subpixel layout: Enable subpixel layout for Apple Windows.
​https://bugs.webkit.org/show_bug.cgi?id=127074

Reviewed by Antti Koivisto.

This should make the Apple Windows bots happier. It probably still needs rebaselining.

  • win/tools/vsprops/FeatureDefines.props:
7:25 AM Changeset in webkit [162128] by Michał Pakuła vel Rutka
  • 3 edits in trunk/LayoutTests

Unreviewed EFL gardening

Add failure test expectations for media tests.

  • platform/efl-wk2/TestExpectations:
  • platform/efl/TestExpectations:
7:07 AM Changeset in webkit [162127] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Fix unnecessary checks for Clang compiler if the compiler is MSVC.
​https://bugs.webkit.org/show_bug.cgi?id=127037

Patch by Peter Molnar <​pmolnar.u-szeged@partner.samsung.com> on 2014-01-16
Reviewed by Csaba Osztrogonác.

Inside the #if defined(_MSC_VER) there's no need for checking whether the compiler is not Clang.

  • wtf/Compiler.h:
7:06 AM Changeset in webkit [162126] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Require at least GCC version 4.7
​https://bugs.webkit.org/show_bug.cgi?id=127049

Patch by Peter Molnar <​pmolnar.u-szeged@partner.samsung.com> on 2014-01-16
Reviewed by Csaba Osztrogonác.

r161770 added a template alias, so the minimum GCC version is 4.7 now.

Also fixed a typo in the error message about old MSVC version.

  • wtf/Compiler.h:
7:01 AM Changeset in webkit [162125] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Tools/gtk/generate-feature-defines-files doesn't work with older versions of python
​https://bugs.webkit.org/show_bug.cgi?id=126323

Patch by Eva Balazsfalvi <​balazsfalvi.eva@stud.u-szeged.hu> on 2014-01-16
Reviewed by Csaba Osztrogonác.

  • gtk/generate-feature-defines-files:
6:59 AM Changeset in webkit [162124] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

[EFL] Rebaselining after r161404
​https://bugs.webkit.org/show_bug.cgi?id=127105

Unreviewed gardening.

Patch by Krzysztof Wolanski <​k.wolanski@samsung.com> on 2014-01-16

  • platform/efl/editing/selection/after-line-wrap-expected.txt:
6:14 AM Changeset in webkit [162123] by Michał Pakuła vel Rutka
  • 2 edits in trunk/Tools

[EFL][WK2] Implement TestController::setHidden
​https://bugs.webkit.org/show_bug.cgi?id=127036

Reviewed by Gyuyoung Kim.

WebKitTestRunner needs TestController::setHidden implementation to
properly handle page visibility API layout tests after r161105.

  • WebKitTestRunner/efl/TestControllerEfl.cpp:

(WTR::TestController::setHidden):

3:12 AM Changeset in webkit [162122] by zandobersek@gmail.com
  • 2 edits in trunk/Tools

[GTK][MiniBrowser] The progress entry reset callback can be fired after the BrowserWindow is destroyed
​https://bugs.webkit.org/show_bug.cgi?id=127083

Reviewed by Carlos Garcia Campos.

When the load progress reaches 1.0 (i.e. 100%), a timeout callback is set up in webViewLoadProgressChanged.
The progress entry is then reset back to 0 in that callback and the timeout source is removed.

The callback can be fired after the relevant BrowserWindow and its progress entry are destroyed, causing
assertion failures in gtk_entry_set_progress_fraction due to an invalid GtkEntry object. To avoid that,
To avoid that, the ID of the timeout source is stored on the BrowserWindow and is destroyed when the
BrowserWindow object is being finalized, preventing the callback from firing.

  • MiniBrowser/gtk/BrowserWindow.c:

(resetEntryProgress):
(webViewLoadProgressChanged):
(browserWindowFinalize):

2:53 AM Changeset in webkit [162121] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

Expose scrollView on WKView
​https://bugs.webkit.org/show_bug.cgi?id=127085

Patch by Ian Henderson <​ianh@apple.com> on 2014-01-16
Reviewed by Antti Koivisto.

Expose WKView's scroll view as a property. In order to support
clients calling setDelegate:, we create a forwarder object that sends
delegate methods to both WKView (the "internal delegate") and the
publicly-exposed delegate (the "external delegate").

  • UIProcess/API/Cocoa/WKView.h:
  • UIProcess/API/ios/WKScrollView.h:
  • UIProcess/API/ios/WKScrollView.mm:

(-[WKScrollViewDelegateForwarder initWithInternalDelegate:externalDelegate:]):
(-[WKScrollViewDelegateForwarder methodSignatureForSelector:]):
(-[WKScrollViewDelegateForwarder respondsToSelector:]):
(-[WKScrollViewDelegateForwarder forwardInvocation:]):
(-[WKScrollView setInternalDelegate:]):
(-[WKScrollView setDelegate:]):
(-[WKScrollView delegate]):
Pretend like _externalDelegate is the real delegate to avoid exposing
our internal delegate or forwarder object.
(-[WKScrollView _updateDelegate]):
(-[WKScrollView dealloc]):

  • UIProcess/API/ios/WKViewIOS.mm:

(-[WKView scrollView]):
(-[WKView _commonInitializationWithContextRef:pageGroupRef:relatedToPage:]):

2:22 AM Changeset in webkit [162120] by aestes@apple.com
  • 14 edits
    1 delete in trunk/Source

[iOS] Fix build issues with exported headers

Source/WebCore:

  • Configurations/WebCore.xcconfig: Allowed UIKit to link against

WebCore.

  • page/ios/WebEventRegion.h: Removed ENABLE(TOUCH_EVENTS), which are

always enabled on iOS.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj: Removed WebPluginPrivate.h from

the project.

Source/WebKit/ios:

  • Misc/WebNSStringExtrasIOS.h: Changed PLATFORM(IOS) to

TARGET_OS_IPHONE.

Source/WebKit/mac:

  • DOM/WebDOMOperationsPrivate.h: Changed PLATFORM(IOS) to

TARGET_OS_IPHONE.

  • MigrateHeaders.make: Excluded WAKScrollView.h from normal replacement

rules so that WebCoreFrameScrollView won't inadvertently get changed to
WebKitFrameScrollView.

  • Plugins/WebPlugin.h: Moved contents of WebPluginPrivate.h to here in

order to maintain source compatibility.

  • Plugins/WebPluginController.mm: Removed an import of WebPluginPrivate.h.
  • Plugins/WebPluginPrivate.h: Removed.
  • Storage/WebDatabaseManagerPrivate.h: Replaced ENABLE(SQL_DATABASE)

with ENABLE_SQL_DATABASE.

  • WebView/WebViewPrivate.h: Added declaration of

-[WebView _touchEventRegions] for source compatibility.

1:09 AM Changeset in webkit [162119] by krit@webkit.org
  • 8 edits in trunk/Source/WebCore

Rename functions in SVGDocumentExtension
​https://bugs.webkit.org/show_bug.cgi?id=127046

Reviewed by Sam Weinig.

Change some function names in SVGDocumentExtension
to make them more descriptive.

Simple refactoring. No new tests.

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::registerResource):

  • svg/SVGDocumentExtensions.cpp:

(WebCore::SVGDocumentExtensions::addPendingResource):
(WebCore::SVGDocumentExtensions::isIdOfPendingResource):
(WebCore::SVGDocumentExtensions::isElementWithPendingResources):
(WebCore::SVGDocumentExtensions::isPendingResource):
(WebCore::SVGDocumentExtensions::clearHasPendingResourcesIfPossible):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removePendingResource):
(WebCore::SVGDocumentExtensions::removePendingResourceForRemoval):
(WebCore::SVGDocumentExtensions::markPendingResourcesForRemoval):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResourcesForRemovalMap): The name is not great but a bit more descriptive.

  • svg/SVGDocumentExtensions.h:
  • svg/SVGElement.cpp:

(WebCore::SVGElement::buildPendingResourcesIfNeeded):

  • svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::buildPendingResource):

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::buildPendingResource):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::buildPendingResource):

Jan 15, 2014:

11:37 PM Changeset in webkit [162118] by Carlos Garcia Campos
  • 10 edits in trunk/Source

[GTK][EFL][NIX] Do not use PrintContext, Frame and DocumentLoader in Errors
​https://bugs.webkit.org/show_bug.cgi?id=127047

Reviewed by Martin Robinson.

Source/WebCore:

Using PrintContext, Frame and DocumentLoader in platform is a
layering violation.
Change printing error methods to receive a failing URL instead of
receiving a PrintContext that was used only to get the failing
URL.

  • platform/efl/ErrorsEfl.cpp:

(WebCore::printError):
(WebCore::printerNotFoundError):
(WebCore::invalidPageRangeToPrint):

  • platform/efl/ErrorsEfl.h:
  • platform/gtk/ErrorsGtk.cpp:

(WebCore::printError):
(WebCore::printerNotFoundError):
(WebCore::invalidPageRangeToPrint):

  • platform/gtk/ErrorsGtk.h:
  • platform/nix/ErrorsNix.cpp:

(WebCore::printError):
(WebCore::printerNotFoundError):
(WebCore::invalidPageRangeToPrint):

  • platform/nix/ErrorsNix.h:

Source/WebKit2:

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:

(WebKit::WebPrintOperationGtk::frameURL): Helper function to get
the URL of the frame being printed.
(WebKit::WebPrintOperationGtk::print): Use frameURL() as failing
URL for printing errors.

  • WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
11:33 PM Changeset in webkit [162117] by mihnea@adobe.com
  • 11 edits
    26 adds in trunk

[CSS Regions] Enable accelerated compositing for fixed elements in named flows
​https://bugs.webkit.org/show_bug.cgi?id=125144

Reviewed by David Hyatt.

Source/WebCore:

Add support for compositing for fixed positioned element that are collected
inside a named flow. Prior to this patch, the fixed positioned elements were
positioned and sized properly but only in the non-compositing scenario.

Tests: compositing/regions/abs-in-named-flow-from-fixed-in-named-flow.html

compositing/regions/fixed-in-diff-named-flows-zIndex.html
compositing/regions/fixed-in-named-flow-clip-descendant.html
compositing/regions/fixed-in-named-flow-from-abs-in-named-flow.html
compositing/regions/fixed-in-named-flow-from-outflow.html
compositing/regions/fixed-in-named-flow-got-transformed-parent.html
compositing/regions/fixed-in-named-flow-lost-transformed-parent.html
compositing/regions/fixed-in-named-flow-overlap-composited.html
compositing/regions/fixed-in-named-flow-position-changed.html
compositing/regions/fixed-in-named-flow-transformed-parent.html
compositing/regions/fixed-in-named-flow-zIndex.html
compositing/regions/fixed-in-named-flow.html
compositing/regions/fixed-transformed-in-named-flow.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::regionForCompositedLayer):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirementsForNamedFlowFixed):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTreeForNamedFlowFixed):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):

  • rendering/RenderLayerCompositor.h:
  • rendering/RenderNamedFlowFragment.h:
  • rendering/RenderNamedFlowThread.h:

LayoutTests:

Added new tests and made the existing tests for fixed positioned elements use the
non-compositing mode.

  • compositing/regions/abs-in-named-flow-from-fixed-in-named-flow-expected.txt: Added.
  • compositing/regions/abs-in-named-flow-from-fixed-in-named-flow.html: Added.
  • compositing/regions/fixed-in-diff-named-flows-zIndex-expected.html: Added.
  • compositing/regions/fixed-in-diff-named-flows-zIndex.html: Added.
  • compositing/regions/fixed-in-named-flow-clip-descendant-expected.txt: Added.
  • compositing/regions/fixed-in-named-flow-clip-descendant.html: Added.
  • compositing/regions/fixed-in-named-flow-expected.txt: Added.
  • compositing/regions/fixed-in-named-flow-from-abs-in-named-flow-expected.txt: Added.
  • compositing/regions/fixed-in-named-flow-from-abs-in-named-flow.html: Added.
  • compositing/regions/fixed-in-named-flow-from-outflow-expected.txt: Added.
  • compositing/regions/fixed-in-named-flow-from-outflow.html: Added.
  • compositing/regions/fixed-in-named-flow-got-transformed-parent-expected.txt: Added.
  • compositing/regions/fixed-in-named-flow-got-transformed-parent.html: Added.
  • compositing/regions/fixed-in-named-flow-lost-transformed-parent-expected.txt: Added.
  • compositing/regions/fixed-in-named-flow-lost-transformed-parent.html: Added.
  • compositing/regions/fixed-in-named-flow-overlap-composited-expected.txt: Added.
  • compositing/regions/fixed-in-named-flow-overlap-composited.html: Added.
  • compositing/regions/fixed-in-named-flow-position-changed-expected.html: Added.
  • compositing/regions/fixed-in-named-flow-position-changed.html: Added.
  • compositing/regions/fixed-in-named-flow-transformed-parent-expected.txt: Added.
  • compositing/regions/fixed-in-named-flow-transformed-parent.html: Added.
  • compositing/regions/fixed-in-named-flow-zIndex-expected.html: Added.
  • compositing/regions/fixed-in-named-flow-zIndex.html: Added.
  • compositing/regions/fixed-in-named-flow.html: Added.
  • compositing/regions/fixed-transformed-in-named-flow-expected.txt: Added.
  • compositing/regions/fixed-transformed-in-named-flow.html: Added.
  • fast/regions/repaint/element-in-named-flow-absolute-from-fixed.html:
  • fast/regions/repaint/element-in-named-flow-fixed-from-absolute.html:
  • fast/regions/repaint/element-inflow-fixed-from-outflow-static.html:
  • fast/regions/repaint/element-outflow-static-from-inflow-fixed.html:
11:19 PM Changeset in webkit [162116] by benjamin@webkit.org
  • 4 edits in trunk/Source

Fix the iOS build after r162114

Unreviewed.

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-01-15

Source/WebCore:

  • WebCore.exp.in: Move the symbol to the right section and add the missing symbols for iOS.

Source/WebKit/mac:

  • WebView/WebViewPrivate.h: I forgot to remove the declaration, fix that.
11:00 PM Changeset in webkit [162115] by commit-queue@webkit.org
  • 3 edits
    4 adds in trunk

[CSS Regions] Fix painting when the composited region has overflow:hidden
​https://bugs.webkit.org/show_bug.cgi?id=124887

Patch by Mihai Maerean <Mihai Maerean> on 2014-01-15
Reviewed by Alexandru Chiculita.

Source/WebCore:

When the layer of the region is composited, the region receives a GraphicsLayer of its own
so the clipping coordinates (caused by overflow:hidden) must be relative to the
GraphicsLayer coordinates in which the region gets painted.

Also, while the painting is done relative to the location of the region's content box, the
clipping is bound to the padding box of the region.

Tests: compositing/regions/paint-inside-composited-region-overflow-hidden-versus-div.html

compositing/regions/paint-inside-composited-region-overflow-hidden-versus-region.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintFlowThreadIfRegion):

LayoutTests:

  • compositing/regions/paint-inside-composited-region-overflow-hidden-versus-div.html: Added.
  • compositing/regions/paint-inside-composited-region-overflow-hidden-versus-div-expected.html: Added.
  • compositing/regions/paint-inside-composited-region-overflow-hidden-versus-region.html: Added.
  • compositing/regions/paint-inside-composited-region-overflow-hidden-versus-region-expected.html: Added.
10:42 PM Changeset in webkit [162114] by benjamin@webkit.org
  • 13 edits
    3 adds in trunk/Source

Move user agent code to WebCore and unify some code between OS X and iOS
​https://bugs.webkit.org/show_bug.cgi?id=127080

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-01-15
Reviewed by Sam Weinig.

Source/WebCore:

Move the duplicated code from WebView and WebPageProxy to two files
in WebCore: UserAgentMac and UserAgentIOS.

  • Configurations/WebCore.xcconfig:
  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • page/ios/UserAgentIOS.mm: Added.

(WebCore::platformSystemRootDirectory):
(WebCore::osMarketingVersion):
(WebCore::standardUserAgentWithApplicationName):

  • page/mac/UserAgent.h: Added.
  • page/mac/UserAgentMac.mm: Added.

(WebCore::systemMarketingVersionForUserAgentString):
(WebCore::standardUserAgentWithApplicationName):

  • platform/ios/WebCoreSystemInterfaceIOS.h:
  • platform/ios/WebCoreSystemInterfaceIOS.mm:

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

  • WebView/WebView.mm:

(userVisibleWebKitVersionString):
(+[WebView _standardUserAgentWithApplicationName:]):
(-[WebView _setUIWebViewUserAgentWithBuildVersion:]):

Source/WebKit2:

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::userVisibleWebKitVersionString):
(WebKit::WebPageProxy::standardUserAgent):

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::standardUserAgent):

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface):

9:27 PM Changeset in webkit [162113] by weinig@apple.com
  • 2 edits in trunk/Source/WebCore

Fix windows build.

  • platform/text/TextAllInOne.cpp:
9:05 PM Changeset in webkit [162112] by commit-queue@webkit.org
  • 11 edits in trunk/Source

[iOS] Clean up REMOTE_INSPECTOR code in OpenSource after the iOS merge
​https://bugs.webkit.org/show_bug.cgi?id=127069

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-01-15
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Export XPCConnection because it is needed by RemoteInspector.h.

  • inspector/remote/RemoteInspectorXPCConnection.h:
  • inspector/remote/RemoteInspector.h:
  • inspector/remote/RemoteInspector.mm:

(Inspector::RemoteInspector::startDisabled):
(Inspector::RemoteInspector::shared):
Allow RemoteInspector singleton to start disabled.

Source/WebCore:

  • WebCore.exp.in:

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
(+[WebView _enableRemoteInspector]):
(+[WebView _disableRemoteInspector]):
(+[WebView _disableAutoStartRemoteInspector]):
(+[WebView _isRemoteInspectorEnabled]):
(+[WebView _hasRemoteInspectorSession]):
(-[WebView allowsRemoteInspection]):
Implement with RemoteInspector.h SPIs.

(-[WebView setAllowsRemoteInspection:]):
(-[WebView setHostApplicationBundleId:name:]):
Still unimplemented, update comment.

(-[WebView _didCommitLoadForFrame:]):
Remove dead path, WebCore now pushes updates on navigations.

  • WebView/WebViewData.h:
  • WebView/WebViewData.mm:

(-[WebViewPrivate init]):
Remove now unused ivar.

8:29 PM Changeset in webkit [162111] by eunmi15.lee@samsung.com
  • 5 edits in trunk/Source/WebKit2

[EFL][WK2] Use timestamp when event occurs for touch events.
​https://bugs.webkit.org/show_bug.cgi?id=126424

Reviewed by Gyuyoung Kim.

Current time is used for touch event's timestamp instead of timestamp
when event occurs. Timestamp of touch event is used to implement flick
gesture, so it should be real value for accurate gesture processing.

  • UIProcess/API/efl/EwkView.cpp:

Function names for handling touch events are changed to distinguish
mouse events and multi events.
(EwkView::setTouchEventsEnabled):
(EwkView::feedTouchEvents):
(EwkView::handleMouseDownForTouch):
(EwkView::handleMouseUpForTouch):
(EwkView::handleMouseMoveForTouch):
(EwkView::handleMultiDownForTouch):
(EwkView::handleMultiUpForTouch):
(EwkView::handleMultiMoveForTouch):

  • UIProcess/API/efl/EwkView.h:
  • UIProcess/API/efl/GestureRecognizer.cpp:

(WebKit::GestureHandler::handlePan):
(WebKit::GestureRecognizer::processTouchEvent):
(WebKit::GestureRecognizer::noGesture):
(WebKit::GestureRecognizer::singleTapGesture):
(WebKit::GestureRecognizer::doubleTapGesture):
(WebKit::GestureRecognizer::panGesture):
(WebKit::GestureRecognizer::pinchGesture):

  • UIProcess/API/efl/GestureRecognizer.h:
8:06 PM Changeset in webkit [162110] by ryuan.choi@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed. EFL Gardening.

  • platform/efl-wk1/TestExpectations:

Unskipped some tests in svg/dynamic-updates which are passing now.

7:59 PM Changeset in webkit [162109] by weinig@apple.com
  • 8 edits
    1 delete in trunk/Source/WebCore

TextBreakIterator's should support Latin-1 for all iterator types (Part 2)
​https://bugs.webkit.org/show_bug.cgi?id=126856

Reviewed by Ryosuke Niwa.

Move the contents of TextBreakIteratorICU.cpp to TextBreakIterator.cpp and remove TextBreakIteratorICU.cpp.

  • CMakeLists.txt:
  • GNUmakefile.list.am:
  • PlatformGTK.cmake:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/text/TextBreakIterator.cpp:
  • platform/text/TextBreakIteratorICU.cpp: Removed.
7:40 PM Changeset in webkit [162108] by eric.carlson@apple.com
  • 4 edits in trunk/Source/WebCore

MediaSessionManager shouldn't use std::map
​https://bugs.webkit.org/show_bug.cgi?id=127003

Reviewed by Sam Weinig.

No new tests, no functional change.

Use an array instead of std::map.

  • platform/audio/MediaSessionManager.cpp:

(WebCore::MediaSessionManager::MediaSessionManager):
(WebCore::MediaSessionManager::addRestriction):
(WebCore::MediaSessionManager::removeRestriction):
(WebCore::MediaSessionManager::restrictions):
(WebCore::MediaSessionManager::sessionWillBeginPlayback):

  • platform/audio/MediaSessionManager.h:
6:18 PM Changeset in webkit [162107] by barraclough@apple.com
  • 9 edits in trunk/Source

Change Page, FocusController to use ViewState
​https://bugs.webkit.org/show_bug.cgi?id=126533

Unreviewed rollout, this caused a regression.

Source/WebCore:

  • WebCore.exp.in:
  • page/FocusController.cpp:

(WebCore::FocusController::FocusController):
(WebCore::FocusController::setFocused):
(WebCore::FocusController::setActive):
(WebCore::FocusController::setContentIsVisible):

  • page/FocusController.h:

(WebCore::FocusController::isActive):
(WebCore::FocusController::isFocused):

  • page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::setIsInWindow):
(WebCore::Page::setIsVisuallyIdle):
(WebCore::Page::setIsVisible):
(WebCore::Page::visibilityState):
(WebCore::Page::hiddenPageCSSAnimationSuspensionStateChanged):

  • page/Page.h:

(WebCore::Page::isVisible):
(WebCore::Page::isInWindow):

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::setActive):
(WebKit::WebPage::setViewIsVisible):
(WebKit::WebPage::setFocused):
(WebKit::WebPage::setIsInWindow):
(WebKit::WebPage::setViewStateInternal):
(WebKit::WebPage::setIsVisuallyIdle):

  • WebProcess/WebPage/WebPage.h:
6:04 PM Changeset in webkit [162106] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=127072
Don't autorelease wrapper object (WebProcessPlugInScriptWorld) for InjectedBundleScriptWorld::normalWorld().

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2014-01-15
Reviewed by Geoffrey Garen.

In [WKWebProcessPlugInScriptWorld normalWorld], InjectedBundleScriptWorld::normalWorld() returns a static
instance, autoreleasing its wrapper object could cause a dangling pointer and crash later.

  • WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInScriptWorld.mm:

(+[WKWebProcessPlugInScriptWorld normalWorld]):

5:51 PM Changeset in webkit [162105] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

[WebGL] Resizing and entering/exiting full screen draws garbage
​https://bugs.webkit.org/show_bug.cgi?id=127077

Reviewed by Dean Jackson.

  • platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:

(WebCore::GraphicsContext3D::reshapeFBOs): Simplified logic regarding FBO switching.
(WebCore::GraphicsContext3D::resolveMultisamplingIfNecessary): Make sure a few things
are turned off that might affect blitting data from one FBO to another.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::prepareTexture): Actually turn dithering off!
(WebCore::GraphicsContext3D::reshape): Mark the context as dirty when resizing so that
the GL view is redrawn during resizing events.

5:06 PM Changeset in webkit [162104] by aestes@apple.com
  • 5 edits in trunk/Source/WebKit2

[iOS] Properly exclude the shim dylibs this time
​https://bugs.webkit.org/show_bug.cgi?id=127075

Reviewed by Anders Carlsson.

BaseLegacyProcess.xcconfig was setting EXCLUDED_SOURCE_FILE_NAMES in
conflict with what I added in r161918, and I misspelled the setting
name in two instances. Fix these two bugs.

Also remove a vestigial OTHER_LDFLAGS from WebContentProcess.xcconfig
while we're here.

  • Configurations/BaseLegacyProcess.xcconfig:
  • Configurations/NetworkProcess.xcconfig:
  • Configurations/PluginProcess.xcconfig:
  • Configurations/WebContentProcess.xcconfig:
4:52 PM Changeset in webkit [162103] by enrica@apple.com
  • 16 edits
    2 adds in trunk/Source/WebKit2

Support WebSelections in WK2 on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=127015

Reviewed by Benjamin Poulain.

This is the first step towards adding support for selections in
non editable content on iOS for WK2.
In particular, this patch adds the basic plumbing to decide which
gesture recognizers are enabled and adds empty stubs for the gestures
that we'll need to support.
There are two separate assistants for selections, one to be used
in editable text (UIWKTextInteractionAssistant) and one for non editable
text (UIWKSelectionAssistant) and they are mutually exclusive.
UIWKSelectionAssistant is created at the time the view is created,
and swapped with UIWKTextInteraction assistant
only when an editable element is focused and the keyboard appears on screen.

gestureRecognizerShouldBegin is the delegate call used to decide which gestures
should begin based on the position the gesture occurred at.
We want to avoid as much as possible synchronous calls to the WebProcess to
retrieve information about the content and in order to do so, we take advantage
of the order in which the gesture recognizers will trigger, based on the delay
configured at initialization.
The first gesture to trigger is highlightLongPress, followed by longpress in the
active assistant and longpress in the WKInteractionView.
There are two different scenarios for highlighlongpress based on which assistant is
currently active.

UIWKSelectionAssistant is active:

We send a request to the WebProcess to get information on the position
and we return YES, allowing the gesture to start.
We delegate to the WebProcess the proper handling of highlight based on the element.
When longPress gesture fires for the assistant, we assume we have received the reply to our
previous request, if not we fetch the information synchronously.
We are then able to make an informed decision about whether
or not to start the gesture. If the reply is NO, the third and last long press
gesture can be evaluated to decide whether to show the action sheet or simply generate
a click event.

UIWKTextInteractionAssistant is active:

In this case we must have information about the position immediately and we issue
a synchronous request to the WebProcess.
If we are not interacting with the same node, we return NO.
Then the longpress gesture fires for the assistant which performs the same check.
If the node is the same, the loupe gesture will start, otherwise the last longpress
gesture will be evaluated to decide about showing the action sheet or generating a
click event.

  • Scripts/webkit2/messages.py:
  • Shared/InteractionInformationAtPosition.cpp: Added.

(WebKit::InteractionInformationAtPosition::encode):
(WebKit::InteractionInformationAtPosition::decode):

  • Shared/InteractionInformationAtPosition.h: Added.

(WebKit::InteractionInformationAtPosition::InteractionInformationAtPosition):

  • UIProcess/API/ios/PageClientImplIOS.h:
  • UIProcess/API/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::positionInformationDidChange):

  • UIProcess/API/ios/WKContentView.mm:

(-[WKContentView _positionInformationDidChange:]):

  • UIProcess/API/ios/WKContentViewInternal.h:
  • UIProcess/API/ios/WKInteractionView.h:
  • UIProcess/API/ios/WKInteractionView.mm:

(-[WKInteractionView initWithFrame:]):
(-[WKInteractionView dealloc]):
(-[WKInteractionView gestureRecognizer:canPreventGestureRecognizer:]):
(-[WKInteractionView gestureRecognizer:canBePreventedByGestureRecognizer:]):
(isSamePair):
(-[WKInteractionView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):
(-[WKInteractionView _showImageSheet]):
(-[WKInteractionView _showLinkSheet]):
(-[WKInteractionView _actionForLongPress]):
(-[WKInteractionView ensurePositionInformationIsUpToDate:]):
(-[WKInteractionView gestureRecognizerShouldBegin:]):
(-[WKInteractionView hasSelectablePositionAtPoint:]):
(-[WKInteractionView pointIsInAssistedNode:]):
(-[WKInteractionView _longPressRecognized:]):
(-[WKInteractionView _doubleTapRecognized:]):
(-[WKInteractionView _twoFingerDoubleTapRecognized:]):
(-[WKInteractionView _twoFingerPanRecognized:]):
(-[WKInteractionView useSelectionAssistantWithMode:]):
(-[WKInteractionView _positionInformationDidChange:]):
(-[WKInteractionView interactionAssistant]):
(-[WKInteractionView _startAssistingKeyboard]):
(-[WKInteractionView _stopAssistingKeyboard]):

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::didReceivePositionInformation):
(WebKit::WebPageProxy::getPositionInformation):
(WebKit::WebPageProxy::requestPositionInformation):

  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::selectWithGesture):
(WebKit::WebPage::getPositionInformation):
(WebKit::WebPage::requestPositionInformation):

4:27 PM Changeset in webkit [162102] by Lucas Forschler
  • 10 edits
    3 deletes in tags/Safari-538.12

Rollout r161455. <rdar://problem/15828719>

4:14 PM Changeset in webkit [162101] by Lucas Forschler
  • 2 edits in tags/Safari-538.12/Source/WebCore

Rollout r161778. <rdar://problem/15828719>

4:08 PM Changeset in webkit [162100] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

​https://bugs.webkit.org/show_bug.cgi?id=127066
Add WKBrowsingContextHandle.h to WebKit2 private headers.

Patch by Yongjun Zhang <​yongjun_zhang@apple.com> on 2014-01-15
Reviewed by Dan Bernstein.

Add WKBrowsingContextHandle.h to WebKit2 private headers so that WebKit2 client
can use WKBrowsingContextHandle class.

  • WebKit2.xcodeproj/project.pbxproj:
4:07 PM Changeset in webkit [162099] by roger_fong@apple.com
  • 6 edits in trunk

Remove unnecessary call to webGLContextCreated
​https://bugs.webkit.org/show_bug.cgi?id=127000

Reviewed by Brent Fulgham.

Source/WebCore:

Note that the functionality of webGLContextCreated will be handled by webGLPolicyForSite now.

Tests: Unskipping tests skipped in r162002.

  • html/HTMLCanvasElement.cpp: Remove webGLContextCreated call.

(WebCore::HTMLCanvasElement::getContext):

  • loader/FrameLoaderClient.h:

Have the returned load policy default to WebGLAllow so as to not break clients that don't implement the method.
(WebCore::FrameLoaderClient::webGLPolicyForSite):
webGLPolicyForSite is now assuming the role of webGLContextCreated as well, pass in the whole site URL instead of just the host.

  • page/ChromeClient.h: Remove webGLContextCreated method.

(WebCore::ChromeClient::decrementActivePageCount):

LayoutTests:

  • platform/mac/TestExpectations: Unskipping tests skipped in r162002.
3:51 PM Changeset in webkit [162098] by Beth Dakin
  • 14 edits in trunk/Source/WebCore

Repeating background images should continue into margin tiles
​https://bugs.webkit.org/show_bug.cgi?id=127021
-and corresponding-
<rdar://problem/15571300>

Reviewed by Simon Fraser.

This patch makes repeating background images continue into margin tiles.

RenderObject::repaintRectangle() now takes an addition bool parameter which
indicates whether or not the repaint rect should be clipped to the layer size.

  • WebCore.exp.in:

These new functions on FrameView provide a way for code in the render tree to know
if the TiledBacking has a margin. tiledBacking() is now const. It should have
always been const, and it needs to be const to make these new functions const.

  • page/FrameView.cpp:

(WebCore::FrameView::tiledBacking):
(WebCore::FrameView::hasExtendedBackground):
(WebCore::FrameView::extendedBackgroundRect):

  • page/FrameView.h:
  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::tiledBacking):

If we’re painting the root background and it is an extended background, we need to
inflate the repaint rect to span the extended background.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::repaintLayerRectsForImage):

To get the phase right on repeated background images on a page with margin tiles,
we need to make sure we factor the size of the margin tiles into the left and top
values that we use when calculating background image geometry.

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):

setBackingNeedsRepaintInRect() now takes GraphicsLayer::ShouldClipToLayer as a
parameter, just like setBackingNeedsRepaint().

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

setContentsNeedDisplayInRect() also takes a GraphicsLayer::ShouldClipToLayer now,
and it passes that information down to the GraphicsLayer.

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):

  • rendering/RenderLayerBacking.h:

These two RenderObject functions now take an optional bool parameter which
indicates whether or not the rect should be clipped to the layer size. They use a
bool instead of the GraphicsLayer enum in order to avoid including GraphicsLayer.h
from within RenderObject.h. This seems like a simpler solution than adding a new
stand-alone file for this very simple enum.

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintUsingContainer):
(WebCore::RenderObject::repaintRectangle):

  • rendering/RenderObject.h:

RenderView::backgroundRect needs to return the extendedBackgroundRect when it had
one.

  • rendering/RenderView.cpp:

(WebCore::RenderView::backgroundRect):

3:26 PM Changeset in webkit [162097] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebKit2

toStringVector static function definition should not be redundant.
​https://bugs.webkit.org/show_bug.cgi?id=126872.

Patch by Piotr Grad <​p.grad@samsung.com> on 2014-01-15
Reviewed by Anders Carlsson.

toStringVector function was declared twice in InjectedBundle.cpp and WebPageGroup.cpp as static.
In order to remove redundant definition this function was moved into API::Array.

  • Shared/APIArray.cpp:

(API::Array::toStringVector):

  • Shared/APIArray.h:
  • UIProcess/WebPageGroup.cpp:

(WebKit::WebPageGroup::addUserStyleSheet):
(WebKit::WebPageGroup::addUserScript):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::addUserScript):
(WebKit::InjectedBundle::addUserStyleSheet):

3:22 PM Changeset in webkit [162096] by BJ Burg
  • 15 edits
    3 adds in trunk

Web Inspector: capture probe samples on the backend
​https://bugs.webkit.org/show_bug.cgi?id=126668

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Add the 'probe' breakpoint action to the protocol. Change the setBreakpoint
commands to return a list of assigned breakpoint action identifiers
Add a type for breakpoint action identifiers. Add an event for sending
captured probe samples to the inspector frontend.

  • inspector/protocol/Debugger.json:

Source/WebCore:

Test: inspector-protocol/debugger/setProbe-multiple-actions.html

Add the probe breakpoint action type. A probe action
evaluates an expression on the script call frame, and
the result is aggregated on a per-probe basis. Each
evaluated expression result is called a probe sample.

  • bindings/js/ScriptDebugServer.cpp:

(WebCore::ScriptDebugServer::evaluateBreakpointAction): Teach
the debug server to evaluate a probe.

(WebCore::ScriptDebugServer::dispatchDidSampleProbe): Added.
(WebCore::ScriptDebugServer::handleBreakpointHit): Increment a hit count.
(WebCore::ScriptDebugServer::getActionsForBreakpoint):

  • bindings/js/ScriptDebugServer.h:
  • inspector/InspectorDebuggerAgent.cpp:

(WebCore::objectGroupForBreakpointAction): Added. Create an object
group for each breakpoint action. Currently only probes make objects.
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::disable):
(WebCore::InspectorDebuggerAgent::enable): Remove stale comment.
(WebCore::breakpointActionTypeForString): Add new case.
(WebCore::InspectorDebuggerAgent::breakpointActionsFromProtocol): Make
this a member function instead of a static function, so it can increment
the breakpoint action identifier counter.
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl): Propagate the
assigned breakpoint action identifiers.
(WebCore::InspectorDebuggerAgent::setBreakpoint): Propagate the
assigned breakpoint action identifiers.
(WebCore::InspectorDebuggerAgent::removeBreakpoint): Release object
groups for any actions that were associated with the removed breakpoint.
(WebCore::InspectorDebuggerAgent::didSampleProbe): Added.
(WebCore::InspectorDebuggerAgent::clearResolvedBreakpointState): Renamed from clear().
(WebCore::InspectorDebuggerAgent::didClearGlobalObject): Renamed from reset().

  • inspector/InspectorDebuggerAgent.h:
  • inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::didClearMainFrameWindowObject):

  • inspector/ScriptBreakpoint.h:

(WebCore::ScriptBreakpointAction::ScriptBreakpointAction): Add identifier member.

  • inspector/ScriptDebugListener.h:

Source/WebInspectorUI:

  • UserInterface/InspectorJSBackendCommands.js: Add probe enumeration value.

LayoutTests:

Add protocol tests for setting and hitting the probe breakpoint action type.

  • inspector-protocol/debugger/setBreakpoint-actions-expected.txt:
  • inspector-protocol/debugger/setBreakpoint-actions.html:
  • inspector-protocol/debugger/setProbe-multiple-actions-expected.txt: Added.
  • inspector-protocol/debugger/setProbe-multiple-actions.html: Added.
  • inspector-protocol/resources/probe-helper.js: Added.

(ProbeHelper.simplifiedProbeSample):

3:01 PM Changeset in webkit [162095] by Lucas Forschler
  • 9 edits in tags/Safari-538.12/Source

Rollout 161609. <rdar://problem/15826281>

2:58 PM Changeset in webkit [162094] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

More iOS build fixing.

  • WebView/WebPreferences.mm: (-[WebPreferences _invalidateCachedPreferences]):

Removed a now unused local variable.

2:53 PM Changeset in webkit [162093] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Build fix for iOS.

  • WebView/WebPreferences.mm: (-[WebPreferences _invalidateCachedPreferences]):

Update a remaining call site of _updatePrivateBrowsingStateFram:to:.

2:43 PM Changeset in webkit [162092] by ap@apple.com
  • 2 edits in trunk/Tools

DumpRenderTree doesn't disable web preferences autosave
​https://bugs.webkit.org/show_bug.cgi?id=127062

Reviewed by Dan Bernstein.

  • DumpRenderTree/mac/DumpRenderTree.mm: (prepareConsistentTestingEnvironment):

Do it.

2:35 PM Changeset in webkit [162091] by ap@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Crash when multiple WebView instances have different PrivateBrowsing settings
​https://bugs.webkit.org/show_bug.cgi?id=127019

  • WebView/WebPreferences.mm: (-[WebPreferences _updatePrivateBrowsingStateTo:]):

Added a null check to fix Safari crash on startup when extensions are enabled.

2:25 PM Changeset in webkit [162090] by dino@apple.com
  • 2 edits in trunk/Tools

Improve filter-build-webkit, especially for iOS builds
​https://bugs.webkit.org/show_bug.cgi?id=81046

Reviewed by Joseph Pecoraro.

Lots of updates to the filtering rules, mostly from the
iOS build output. Other highlights include:

  • ignoring escape sequences for color ouput
  • detecting escaped spaces in file name regexps
  • Scripts/filter-build-webkit:

(shouldIgnoreLine):

2:16 PM Changeset in webkit [162089] by fpizlo@apple.com
  • 12 edits
    1 add in branches/jsCStack/Source/JavaScriptCore

reentrant-caching sometimes fails with LLInt disabled
​https://bugs.webkit.org/show_bug.cgi?id=126781

Reviewed by Michael Saboff.

The lookupExceptionHandler->genericUnwind->handleUncaughtException paths need to
be resilient against the frame from which we claim to be throwing the exception
being the sentinel frame.

Also attempted to add a test that pinpoints the problem, but it didn't cause a
crash either before or after my change. That's fine, I figured it would be good to
have more coverage for madness like this.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compileExceptionHandlers):

  • ftl/FTLCompile.cpp:

(JSC::FTL::fixFunctionBasedOnStackMaps):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::unwind):

  • interpreter/Interpreter.h:

(JSC::NativeCallFrameTracer::NativeCallFrameTracer):

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArguments):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileExceptionHandlers):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/Repatch.cpp:

(JSC::tryBuildGetByIDList):

  • jit/ThunkGenerators.cpp:

(JSC::throwExceptionFromCallSlowPathGenerator):

  • llint/LowLevelInterpreter64.asm:
  • tests/stress/recurse-infinitely-on-getter.js: Added.

(.var):

1:39 PM Changeset in webkit [162088] by barraclough@apple.com
  • 8 edits in trunk

REGRESSION (r158369): Some pop-up windows open at incorrect size (affects GMail, theblaze.com)
​https://bugs.webkit.org/show_bug.cgi?id=126289

Reviewed by Anders Carlson.

Partial revert of ​https://bugs.webkit.org/show_bug.cgi?id=123557.
On window.open, update page when the UIProcess sends the create message

Source/WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::initializeWebPage):
(WebKit::WebPageProxy::creationParameters):

  • UIProcess/WebPageProxy.h:
    • creation paraments are not preserved at window.open.
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::reinitializeWebPage):
(WebKit::WebPage::setViewState):
(WebKit::WebPage::setViewStateInternal):

  • WebProcess/WebPage/WebPage.h:
    • add interface to update page.
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::createWebPage):

  • if we try to create a page that already exists, update the current page's view state.

LayoutTests:

  • platform/mac-wk2/TestExpectations:
    • test is bad (results in DRT don't reflect in browser behaviour).
1:30 PM Changeset in webkit [162087] by ap@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Crash when multiple WebView instances have different PrivateBrowsing settings
​https://bugs.webkit.org/show_bug.cgi?id=127019

Reviewed by Sam Weinig.

  • WebView/WebView.mm: (-[WebView _preferencesChanged:]): Don't delete a private

browsing session simply because one preferences object doesn't use private browsing.
There could be others that do.

  • WebView/WebPreferences.mm: Track how many WebPreferences objects use private

browsing, and only delete the private session when there are none any more.

1:21 PM Changeset in webkit [162086] by berto@igalia.com
  • 2 edits in trunk/Source/WTF

[GTK] v2.3.3 fails to build in Debian / FreeBSD
​https://bugs.webkit.org/show_bug.cgi?id=126502

Reviewed by Mark Lam.

  • wtf/Platform.h: Add LLINT support to FreeBSD.
12:13 PM Changeset in webkit [162085] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[WebGL] Validation function for compressed formats incorrect
​https://bugs.webkit.org/show_bug.cgi?id=127023

Reviewed by Dean Jackson.

No new tests. Covered by existing WebGL compressed texture tests.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::validateCompressedTexFuncData): Revise to match specifications.

12:09 PM Changeset in webkit [162084] by akling@apple.com
  • 17 edits
    3 deletes in trunk/Source

Remove the CSS selector profiler.
<​https://webkit.org/b/127039>

Source/WebCore:

The selector profiler was painting a mostly fictional picture of what
selectors we were spending time on. It never really grokked the fast
path selectors, nor did it understand recent additions like the extra
cascading pass or the selector JIT.

Somewhat ironically, this may end up making some selectors run faster
since it removes a number of brances in hot code.

Reviewed by Sam Weinig.

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::collectMatchingRulesForList):

  • css/ElementRuleCollector.h:
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::willDestroyFrontendAndBackend):

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorInstrumentation.cpp:
  • inspector/InspectorInstrumentation.h:
  • inspector/protocol/CSS.json:

Source/WebInspectorUI:

Purge selector profiler code from the new Web Inspector UI.

Reviewed by Sam Weinig.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/CSSSelectorProfileObject.js: Removed.
  • UserInterface/CSSSelectorProfileType.js: Removed.
  • UserInterface/CSSSelectorProfileView.js: Removed.
  • UserInterface/ContentView.js:

(WebInspector.ContentView):
(WebInspector.ContentView.isViewable):

  • UserInterface/InspectorWebBackendCommands.js:
  • UserInterface/InstrumentSidebarPanel.js:

(WebInspector.InstrumentSidebarPanel):
(WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphMousedOver):
(WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphMousedDown):
(WebInspector.InstrumentSidebarPanel.prototype._recordProfileGlyphClicked):
(WebInspector.InstrumentSidebarPanel.prototype._profileTypeWasSelected):
(WebInspector.InstrumentSidebarPanel.prototype._profilesCleared):

  • UserInterface/Main.html:
  • UserInterface/ProfileManager.js:

(WebInspector.ProfileManager):
(WebInspector.ProfileManager.prototype.initialize):
(WebInspector.ProfileManager.prototype._checkForInterruptions):
(WebInspector.ProfileManager.prototype._attemptToResumeProfiling):

  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
11:01 AM Changeset in webkit [162083] by commit-queue@webkit.org
  • 4 edits
    7 adds in trunk

[SVG] Accept HTML and MathML namespaces as valid requiredExtensions
​https://bugs.webkit.org/show_bug.cgi?id=88188

Patch by Frédéric Wang <​fred.wang@free.fr> on 2014-01-15
Reviewed by Chris Fleizach.

Source/WebCore:

When HTML and MathML are used as foreign objects of an SVG image, it is
important for Web authors to be able to specify a fallback content for
SVG-only readers or browsers without MathML support. We rely on the
requiredExtensions for that purpose and we use the XHTML/MathML
namespaces as suggested in SVG Tiny 1.2 and implemented in Gecko.

Tests: svg/custom/conditional-processing-1.svg

svg/custom/conditional-processing-2.html
svg/dom/SVGTests.html

  • svg/SVGSwitchElement.cpp: Remove an incorrect FIXME comment and replace it with a reference to bug 74749.

(WebCore::SVGSwitchElement::childShouldCreateRenderer):

  • svg/SVGTests.cpp: Check if the list of required extensions contains only the XHTML/MathML namespaces.

(WebCore::SVGTests::hasExtension):
(WebCore::SVGTests::isValid):

LayoutTests:

conditional-processing-1 verifies that indeed a renderer object is only
created for the first "valid" SVG element of a <switch>, contrary to
what an incorrect FIXME comment said. conditional-processing-2 verifies
that the <switch> takes into account XHTML and MathML namespaces in the
requiredExtensions attribute to decide which SVG element is "valid".
SVGTests.html verifies the SVGTests interface of SVG DOM: three
SVGStringList attributes (already tested in svg/dom/SVGStringList.html)
and the hasExtension() function.

  • svg/custom/conditional-processing-1-expected.svg: Added.
  • svg/custom/conditional-processing-1.svg: Added.
  • svg/custom/conditional-processing-2-expected.html: Added.
  • svg/custom/conditional-processing-2.html: Added.
  • svg/dom/SVGTests-expected.txt: Added.
  • svg/dom/SVGTests.html: Added.
  • svg/dom/script-tests/SVGTests.js: Added.
11:00 AM Changeset in webkit [162082] by ap@apple.com
  • 2 edits
    1 copy
    1 delete in trunk/LayoutTests

AX: Merge layout test from Mac and GTK checking accessibility roles
​https://bugs.webkit.org/show_bug.cgi?id=126685

Fix Mac test results.

  • platform/mac-mountainlion/platform/mac/accessibility/role-subrole-roledescription-expected.txt: Removed.

This test was merged into another, but its Mountain Lion results were not moved accordingly.

  • platform/mac-mountainlion/accessibility/roles-exposed-expected.txt: Copied from LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt.

Custom results with a different role for "dl".

  • platform/mac/accessibility/roles-exposed-expected.txt: Changed to have results that

are correct forward looking.

10:37 AM Changeset in webkit [162081] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebKit/mac

[iOS] Missing RenderObject::style() symbol in WebDOMOperations.mm

Fixes the following linker error:

Undefined symbols for architecture x86_64:

"ZNK7WebCore12RenderObject5styleEv", referenced from:

-[DOMNode(WebDOMNodeOperations) isHorizontalWritingMode] in WebDOMOperations.o

  • DOM/WebDOMOperations.mm: Include RenderElement.h instead of

RenderObject.h since the inline RenderObject::style() method
moved to the former header.

10:29 AM Changeset in webkit [162080] by commit-queue@webkit.org
  • 6 edits
    2 deletes in trunk

Unreviewed, rolling out r162066.
​http://trac.webkit.org/changeset/162066
​https://bugs.webkit.org/show_bug.cgi?id=127056

The added test still fails on some bots (Requested by ap on
#webkit).

Source/WebCore:

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawPatternForContainer):

  • svg/graphics/SVGImage.h:
  • svg/graphics/SVGImageForContainer.cpp:

(WebCore::SVGImageForContainer::drawPattern):

LayoutTests:

  • css3/compositing/background-blend-mode-data-uri-svg-image-expected.html: Removed.
  • css3/compositing/background-blend-mode-data-uri-svg-image.html: Removed.
  • platform/efl/TestExpectations:
10:23 AM Changeset in webkit [162079] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] Fix intialization order of ResourceResponse constructor

Fixes the following build failure:

WebCore/platform/network/mac/ResourceResponseMac.mm:83:7: error: field 'm_nsResponse' will be initialized after field 'm_initLevel' [-Werror,-Wreorder]

, m_nsResponse(nsResponse)


  • platform/network/mac/ResourceResponseMac.mm:

(WebCore::ResourceResponse::ResourceResponse): Reorder member
initializers to match the order that they are defined in the
header.

10:11 AM Changeset in webkit [162078] by roger_fong@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Comment out part of r162036 which broke WebGL on many ports.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::getContext):

10:03 AM Changeset in webkit [162077] by Brent Fulgham
  • 2 edits
    1 delete in trunk/LayoutTests

Unreviewed test correctino for webgl compressed textures.

  • fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt:
  • platform/mac-mountainlion/fast/canvas: Removed.
  • platform/mac-mountainlion/fast/canvas/webgl: Removed.
  • platform/mac-mountainlion/fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Removed.
9:53 AM Changeset in webkit [162076] by Michał Pakuła vel Rutka
  • 2 edits in trunk/LayoutTests

Unreviewed EFL gardening

Add failure test expectations for reftests added in r161626.

  • platform/efl/TestExpectations:
9:46 AM Changeset in webkit [162075] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/mac

Unreviewed, rolling out r162054.
​http://trac.webkit.org/changeset/162054
​https://bugs.webkit.org/show_bug.cgi?id=127053

Causes assertion failures in DumpRenderTree (Requested by ap
on #webkit).

  • WebView/WebPreferences.mm:

(-[WebPreferences initWithIdentifier:sendChangeNotification:initWithIdentifier:]):
(-[WebPreferences initWithCoder:]):
(+[WebPreferences standardPreferences]):
(-[WebPreferences dealloc]):
(-[WebPreferences setPrivateBrowsingEnabled:]):
(-[WebPreferences _invalidateCachedPreferences]):

  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

9:45 AM Changeset in webkit [162074] by andersca@apple.com
  • 3 edits in trunk/Source/WTF

Get rid of RefCountedCustomAllocated
​https://bugs.webkit.org/show_bug.cgi?id=127051

Reviewed by Antti Koivisto.

It's not used anywhere anymore, get rid of it.

  • wtf/RefCounted.h:
  • wtf/SizeLimits.cpp:
9:37 AM Changeset in webkit [162073] by Carlos Garcia Campos
  • 7 edits
    2 adds in trunk

[GTK] Web process sometimes crashes when printing in synchronous mode
​https://bugs.webkit.org/show_bug.cgi?id=126979

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

When printing synchronously in GTK+ we need to make sure that we
have a list of Printers before starting the print operation. Getting
the list of printers is done synchronously by GTK+, but using a
nested main loop that might process IPC messages comming from the
UI process like EndPrinting. When the EndPrinting message is
received while the printer list is being populated, the print
operation is finished unexpectely and the web process crashes. The
PrinterListGtk class gets the list of printers in the constructor
so we just need to ensure there's an instance alive during the
synchronous print operation. In case of asynchronous printing the
printer list will be created during the print operation without
any risk, because the EndPrinting message is not sent until the
printing callback has been received in the UI process.

  • GNUmakefile.list.am: Add new files to compilation.
  • PlatformGTK.cmake: Ditto.
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::print): Ensure PrinterListGtk is created
before the synchronous printing and destroyed afterwards.

  • WebProcess/WebPage/gtk/PrinterListGtk.cpp: Added.

(WebKit::PrinterListGtk::shared): Return the singleton.
(WebKit::PrinterListGtk::enumeratePrintersFunction): Callback
called by gtk_enumerate_printers() when a new printer is found.
(WebKit::PrinterListGtk::PrinterListGtk): Call
gtk_enumerate_printers() in syhchronous mode.
(WebKit::PrinterListGtk::~PrinterListGtk):
(WebKit::PrinterListGtk::addPrinter): Add the printer to the list
and set the default printer if needed.
(WebKit::PrinterListGtk::findPrinter): Find the printer for the
given name.

  • WebProcess/WebPage/gtk/PrinterListGtk.h: Added.
  • WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp: Use

PrinterListGtk class to find the printer instead of calling
gtk_enumerate_printers().

Tools:

  • Scripts/run-gtk-tests:

(TestRunner): Unskip
/webkit2/WebKitPrintOperation/close-after-print.

9:22 AM Changeset in webkit [162072] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

Merged some subpixel skipped tests. Unreviewed.

webkit.org/b/126894 is a duplicate of webkit.org/b/126892

  • platform/mac/TestExpectations:
9:19 AM Changeset in webkit [162071] by zoltan@webkit.org
  • 3 edits in trunk/Source/WebCore

WordMeasurement is a struct, not a class
​https://bugs.webkit.org/show_bug.cgi?id=125373

Reviewed by Anders Carlsson.

Change class to struct, because there is no reason for WordMeasurement to be a class.

No new tests, no behavior change.

  • rendering/RenderBlockFlow.h:
  • rendering/line/BreakingContextInlineHeaders.h:
9:10 AM Changeset in webkit [162070] by Brent Fulgham
  • 1 edit
    3 adds in trunk/LayoutTests

Unreviewed test fix for Mountain Lion WebGL behavior.

Add Mountain Lion expected output matching ML's output of INVALID_OPERATION for improperly-sized textures.

  • platform/mac-mountainlion/fast/canvas: Added.
  • platform/mac-mountainlion/fast/canvas/webgl: Added.
  • platform/mac-mountainlion/fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Added.
9:03 AM Changeset in webkit [162069] by zandobersek@gmail.com
  • 5 edits
    2 adds in trunk/Source/WebKit/gtk

[GTK][WK1] Add ProgressTrackerClient implementation
​https://bugs.webkit.org/show_bug.cgi?id=127048

Reviewed by Anders Carlsson.

In r162034, the progress tracker client was separated from FrameLoaderClient into the
ProgressTrackerClient class. This patch adds the WebKit layer implementation of that
class for GTK-WK1 that's practically identical to the client implementation that was
in use under WebKit::FrameLoaderClient.

  • GNUmakefile.am:
  • WebCoreSupport/FrameLoaderClientGtk.cpp:
  • WebCoreSupport/FrameLoaderClientGtk.h:
  • WebCoreSupport/ProgressTrackerClientGtk.cpp: Added.

(WebKit::ProgressTrackerClient::ProgressTrackerClient):
(WebKit::ProgressTrackerClient::progressTrackerDestroyed):
(WebKit::ProgressTrackerClient::progressStarted):
(WebKit::ProgressTrackerClient::progressEstimateChanged):
(WebKit::ProgressTrackerClient::progressFinished):

  • WebCoreSupport/ProgressTrackerClientGtk.h: Added.
  • webkit/webkitwebview.cpp:

(webkit_web_view_init):

9:01 AM Changeset in webkit [162068] by zandobersek@gmail.com
  • 1 edit
    1 delete in trunk/LayoutTests

Unreviewed GTK gardening. Removing an unneeded GTK-specific baseline
for a layout test that was fixed proper in r161549.

  • platform/gtk/http/tests/security/redirect-BLOCKED-to-localURL-expected.txt: Removed.
5:15 AM Changeset in webkit [162067] by mario.prada@samsung.com
  • 1 edit
    2 moves
    1 add
    2 deletes in trunk/LayoutTests

AX: Merge layout test from Mac and GTK checking accessibility roles
​https://bugs.webkit.org/show_bug.cgi?id=126685

Reviewed by Chris Fleizach.

Merged GTK and Mac tests into one cross-platform test that is
aware of the platform-specific differences by declaring which
elements are supported in which platforms and which platform
specific roles (if it's the case) should be expected.

  • accessibility/roles-exposed-expected.txt: Renamed from LayoutTests/platform/gtk/accessibility/roles-exposed-expected.txt.
  • accessibility/roles-exposed.html: Added.
  • platform/gtk/accessibility/roles-exposed.html: Removed.
  • platform/mac/accessibility/role-subrole-roledescription.html: Removed.
  • platform/mac/accessibility/roles-exposed-expected.txt: Renamed from LayoutTests/platform/mac/accessibility/role-subrole-roledescription-expected.txt.
4:32 AM Changeset in webkit [162066] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Source/WebCore: Reapplying:
Background-blend-mode doesn't work for an element with an
SVG image as background and border-style or padding set.
The problem consisted in the drawing path using the default
blending parameter at all times.
​https://bugs.webkit.org/show_bug.cgi?id=118894

Patch by Mihai Tica <​mitica@adobe.com> on 2014-01-15
Reviewed by Dirk Schulze.

Test: css3/compositing/background-blend-mode-data-uri-svg-image.html

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::drawPatternForContainer): Pass blendMode to Image::drawPattern.

  • svg/graphics/SVGImage.h: Add a blendMode parameter to drawPatternForContainer.
  • svg/graphics/SVGImageForContainer.cpp:

(WebCore::SVGImageForContainer::drawPattern): Pass blendMode to drawPatternForContainer call.

LayoutTests: Reapplying:
Background-blend-mode doesn't work for an element with an
SVG image as background and border-style or padding set.
Tests now use rectangles instead of circles for SVGs.
​https://bugs.webkit.org/show_bug.cgi?id=118894

Patch by Mihai Tica <​mitica@adobe.com> on 2014-01-15
Reviewed by Dirk Schulze.

  • css3/compositing/background-blend-mode-data-uri-svg-image-expected.html:
  • css3/compositing/background-blend-mode-data-uri-svg-image.html:
  • platform/efl/TestExpectations: pass tests for efl, blendMode is not implemented.
3:26 AM Changeset in webkit [162065] by Manuel Rego Casasnovas
  • 4 edits
    2 adds in trunk/PerformanceTests

[CSS Regions] Add performance tests for selection with mixed content
​https://bugs.webkit.org/show_bug.cgi?id=126427

Reviewed by Ryosuke Niwa.

Add new performance tests for selection in CSS Regions mixing regular
content with regions. 2 new tests are added, one checking select all
command and another simulating a user selection passing through all the
paragraphs (similar to Layout/RegionsSelection.html).

Test are skipped for now while implementation of selection in CSS
Regions is still evolving.

  • Layout/RegionsExtendingSelectionMixedContent.html: Added.
  • Layout/RegionsSelectAllMixedContent.html: Added.
  • Layout/resources/regions.css:

(.regular):

  • Layout/resources/regions.js:
  • Skipped:
2:30 AM Changeset in webkit [162064] by abucur@adobe.com
  • 3 edits
    2 adds in trunk

[CSS Regions] Hit-testing goes through clipped layer in fast/regions/overflow-first-and-last-regions-in-container-hidden.html
​https://bugs.webkit.org/show_bug.cgi?id=126886

Reviewed by Mihnea Ovidenie.

Source/WebCore:

Currently, when hit testing a location inside a flow thread we ignore the clipping rectangle of
the region. This leads to false positives when the location is over the clipped out content of a
flow thread. The patch verifies that the location is inside the clipping rectangle of the region before
forwarding the hit test verification to the flow thread layer.

Test: fast/regions/hover-and-js-in-visual-overflow-hidden.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTestFlowThreadIfRegion):

LayoutTests:

Add a test that verifies you can't hover an element flowed inside a region but found inside
the hidden overflow of the region.

  • fast/regions/hover-and-js-in-visual-overflow-hidden-expected.html: Added.
  • fast/regions/hover-and-js-in-visual-overflow-hidden.html: Added.
2:28 AM Changeset in webkit [162063] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Suspend resource requests during computedStyle
​https://bugs.webkit.org/show_bug.cgi?id=127034

Reviewed by Andreas Kling.

We have some cases where getting computed style leads to crashes in loadPendingImages.
This is probably caused by load callbacks resulting in re-entering WebKit and killing the StyleResolver.

As a speculative fix suspend resource loads (and so callbacks) when getting the computed style.
We do similar suspension during style recalc for the same reason.

  • dom/Document.cpp:

(WebCore::Document::styleForElementIgnoringPendingStylesheets):

  • loader/ResourceLoadScheduler.h:

(WebCore::ResourceLoadScheduler::Suspender::Suspender):
(WebCore::ResourceLoadScheduler::Suspender::~Suspender):

2:14 AM Changeset in webkit [162062] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk

DocumentFragment should be constructable.
​https://bugs.webkit.org/show_bug.cgi?id=115641

Patch by László Langó <​llango.u-szeged@partner.samsung.com> on 2014-01-15
Reviewed by Ryosuke Niwa.

Source/WebCore:

​http://www.w3.org/TR/2013/WD-dom-20131107/#interface-documentfragment
This allows us to do new DocumentFragment instead of
document.createDocumentFragment().

Backported from Blink: ​https://chromium.googlesource.com/chromium/blink/+/86855c44a5a127716840fb377281b1c428e5eb2d%5E%21

Test: fast/dom/DocumentFragment/document-fragment-constructor.html

  • dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::create):

  • dom/DocumentFragment.h:
  • dom/DocumentFragment.idl:

LayoutTests:

  • fast/dom/DocumentFragment/document-fragment-constructor-expected.txt: Added.
  • fast/dom/DocumentFragment/document-fragment-constructor.html: Added.
  • fast/dom/dom-constructors-expected.txt:
  • fast/dom/dom-constructors.html:
2:01 AM Changeset in webkit [162061] by ryuan.choi@samsung.com
  • 6 edits
    2 adds in trunk/Source/WebKit

[EFL][WK1] Implement ProgressTrackerClientEfl to fix the crash
​https://bugs.webkit.org/show_bug.cgi?id=127031

Reviewed by Gyuyoung Kim.

Source/WebKit:

  • PlatformEfl.cmake: Added ProgressTrackerClientEfl.cpp into source lists.

Source/WebKit/efl:

Implmemented and moved ProgressTrackerClient logic from FrameLoaderClientEfl.
ProgressTrackerClient should be indenpendent instance since r162034

  • WebCoreSupport/FrameLoaderClientEfl.cpp:
  • WebCoreSupport/FrameLoaderClientEfl.h:
  • WebCoreSupport/ProgressTrackerClientEfl.cpp:

(WebCore::ProgressTrackerClientEfl::ProgressTrackerClientEfl):
(WebCore::ProgressTrackerClientEfl::progressTrackerDestroyed):
(WebCore::ProgressTrackerClientEfl::progressStarted):
(WebCore::ProgressTrackerClientEfl::progressEstimateChanged):
(WebCore::ProgressTrackerClientEfl::progressFinished):

  • WebCoreSupport/ProgressTrackerClientEfl.h: Added.
  • ewk/ewk_view.cpp:

(_ewk_view_priv_new):

1:58 AM WebKitGTK/2.2.x edited by tpopela@redhat.com
(diff)
1:55 AM Changeset in webkit [162060] by ChangSeok Oh
  • 4 edits in trunk/Tools

[EFL] Change test font installed path to webkitgtk-font-tests
​https://bugs.webkit.org/show_bug.cgi?id=126723

Reviewed by Gyuyoung Kim.

I'd like to change the test fonts installed directory from 'webkitgtk-test-fonts-0.0.3'
to 'webkitgtk-test-fonts'. webkitgtk-test-fonts-0.0.3 doesn't match the path
hard-coded in FontManagement.cpp#105

  • DumpRenderTree/PlatformEfl.cmake:
  • WebKitTestRunner/PlatformEfl.cmake:
  • efl/jhbuild.modules:
1:45 AM Changeset in webkit [162059] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[SOUP] [WK2] - Disable MemoryCache when the DOCUMENT_VIEWER cache model is set
​https://bugs.webkit.org/show_bug.cgi?id=126577

Patch by Tomas Popela <​tpopela@redhat.com> on 2014-01-15
Reviewed by Carlos Garcia Campos.

As in ​http://trac.webkit.org/changeset/152483, but this time for
WebKit2. When WEBKIT_CACHE_MODEL_DOCUMENT_VIEWER is set we need to
disable the MemoryCache completely to prevent caching of the resources.

  • WebProcess/soup/WebProcessSoup.cpp:

(WebKit::WebProcess::platformSetCacheModel):

12:01 AM Changeset in webkit [162058] by rniwa@webkit.org
  • 9 edits
    2 adds in trunk

Make DoYouEvenBench runnable by run-perf-tests
​https://bugs.webkit.org/show_bug.cgi?id=127030

Reviewed by Andreas Kling.

PerformanceTests:

Added Full.html that runs 5 iterations of DoYouEvenBench. This is the canonical DoYouEvenBench,
which is also runnable by run-perf-tests.

  • DoYouEvenBench/Full.html: Added.
  • DoYouEvenBench/benchmark.html:

(startTest): Updated the code to account for the fact old measuredValues is pushed down to tests
property and we now have total property so that we don't have to manually compute the total.

  • DoYouEvenBench/resources/benchmark-report.js: Added. When we're inside a DRT/WTR, use

PerfTestRunner to output that can be parsed by run-perf-tests. Do the same when the query part
or the fragment part of the current URL is "webkit" for debugging purposes.

  • DoYouEvenBench/resources/benchmark-runner.js:

(BenchmarkRunner):
(BenchmarkRunner.prototype._appendFrame): Position the frame at (0, 0) inside DRT and WTR since
we have exactly 800px by 600px inside those two test runners. Also always insert the iframe as
the first child of body to avoid inserting it after the pre inserted by the test runner.
(BenchmarkRunner.prototype.step): Initializes _measuredValues.
(BenchmarkRunner.prototype.runAllSteps): Merged callNextStep in benchmark.html.
(BenchmarkRunner.prototype.runMultipleIterations): Added.
(BenchmarkRunner.prototype._runTestAndRecordResults): Compute the grand total among suites.
Also push down the sync and async time into tests property for consistency.
(BenchmarkRunner.prototype._finalize):

  • Dromaeo/resources/dromaeorunner.js:

(DRT.testObject): Renamed dromaeoIterationCount to customIterationCount as this option is also
used by DoYouEvenBench.

  • resources/runner.js: Ditto.

(.finish): Spit out the aggregator name.

Tools:

Ignore console messages spit out by DoYouEvenBench and support aggregator names such as
":Total" to appear at the end of a test name. We don't do anything with it for now.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest._metrics_regex): Handle aggregator names such as ":Total". We'll pass it down
to the JSON in a follow up patch for the perf dashboard.
(PerfTest._lines_to_ignore_in_parser_result): Added lines to ignore for DoYouEvenBench.

LayoutTests:

Use customIterationCount as it has been renamed from dromaeoIterationCount.

  • fast/harness/perftests/runs-per-second-iterations.html:
Note: See TracTimeline for information about the timeline view.