Timeline
Jun 7, 2014:
- 4:25 PM Changeset in webkit [169681] by
-
- 5 edits in trunk/Source/WebCore
Regression r168397 - Form layout is incorrect on OS X Yosemite
https://bugs.webkit.org/show_bug.cgi?id=133612
<rdar://problem/16850492>
<rdar://problem/17016914>
Reviewed by Anders Carlson.
Revision 168397 introduced a new animated style of form controls. Part of
it included extending the margins for the controls to take into account the
focus ring that animates in from a large radius to a small radius. This
caused two problems:
- the incorrect margins broke many layouts
- despite increased margins, there were still some areas that did not repaint correctly.
Restore the old margins and (temporarily) turn off focus ring animation.
Bad layout is much worse than a missing animation. Another benefit
of this is that we will use less memory.
- platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::drawFocusRingToContextAtTime): Pass in a time far far far in the future to
get the static rendering.
- platform/mac/ThemeMac.mm:
(WebCore::checkboxMargins): Restore correct margins.
(WebCore::radioMargins): Ditto.
(WebCore::drawCellFocusRing): New method that calls WKSI with a future time.
(WebCore::paintToggleButton): Call the new wrapper.
(WebCore::buttonMargins): Restore correct margins.
(WebCore::paintButton): Call the new wrapper.
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintMenuList): Use a future time.
(WebCore::RenderThemeMac::platformFocusRingMaxWidth): Deleted. Use old outline value.
- 1:32 PM Changeset in webkit [169680] by
-
- 3 edits2 deletes in trunk/Source/WebKit2
Get rid of _WKScriptWorld
https://bugs.webkit.org/show_bug.cgi?id=133610
Reviewed by Dan Bernstein.
- Shared/API/Cocoa/WebKitPrivate.h:
- UIProcess/API/Cocoa/_WKScriptWorld.h: Removed.
- UIProcess/API/Cocoa/_WKScriptWorld.mm: Removed.
- WebKit2.xcodeproj/project.pbxproj:
- 1:17 PM Changeset in webkit [169679] by
-
- 16 edits in trunk/Source
HTTPHeaderMap should not derive from HashMap
https://bugs.webkit.org/show_bug.cgi?id=133392
Reviewed by Darin Adler.
Source/WebCore:
Use a HashMap member variable instead.
- WebCore.exp.in:
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
- platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::copyData):
(WebCore::HTTPHeaderMap::adopt):
(WebCore::HTTPHeaderMap::get):
(WebCore::HTTPHeaderMap::set):
(WebCore::HTTPHeaderMap::add):
(WebCore::HTTPHeaderMap::contains):
(WebCore::HTTPHeaderMap::find):
(WebCore::HTTPHeaderMap::remove):
(WebCore::HTTPHeaderMap::keys):
- platform/network/HTTPHeaderMap.h:
(WebCore::HTTPHeaderMap::isEmpty):
(WebCore::HTTPHeaderMap::size):
(WebCore::HTTPHeaderMap::clear):
(WebCore::HTTPHeaderMap::begin):
(WebCore::HTTPHeaderMap::end):
(WebCore::HTTPHeaderMap::operator==):
(WebCore::HTTPHeaderMap::operator!=):
- platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::adopt):
- platform/network/ResourceRequestBase.h:
- platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
- platform/network/ResourceResponseBase.h:
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
Source/WebKit2:
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<HTTPHeaderMap>::encode):
(IPC::ArgumentCoder<HTTPHeaderMap>::decode):
- 12:56 PM Changeset in webkit [169678] by
-
- 2 edits in tags/Safari-538.39.1/Source/WebKit2
Merged r169672.
- 12:51 PM Changeset in webkit [169677] by
-
- 5 edits in tags/Safari-538.39.1/Source
Versioning.
- 12:49 PM Changeset in webkit [169676] by
-
- 1 copy in tags/Safari-538.39.1
New tag.
- 6:29 AM Changeset in webkit [169675] by
-
- 5 edits in trunk/Source/WebCore
Use C++11 lambdas to construct FileThread::Task objects
https://bugs.webkit.org/show_bug.cgi?id=133079
Reviewed by Darin Adler.
Have FileThread::Task constructor take in a std::function<void ()>-like object
as the second parameter. Much like with ScriptExecutionContext::Task, the idea here
is to use inlined C++11 lambdas in FileThread::postTask() calls. Because FileThread::Task
also requires an instance pointer, a brace-init list is passed to these calls, passing
in the instance pointer as the first parameter and the C++11 lambda as the second.
FileThread::postTask() now takes in a FileThread::Task rvalue and moves it onto the heap
and into the queue.
In AsyncFileStream.cpp, calls to FileThread::postTask() are updated to use C++11 lambdas.
Uses of MainThreadTask are also replaced by C++11 lambdas. This modernizes the code and
removes a lot of helper functions.
FileThread::Task doesn't use CrossThreadCopier anymore. Instead, we manually produce
thread-safe copies as necessary. At the moment this approach produces another copy when
passing the freshly-copied object into the lambda, but this will be avoidable once we
make C++14 and the lambda capture expression support mandatory.
- fileapi/AsyncFileStream.cpp:
(WebCore::AsyncFileStream::create):
(WebCore::AsyncFileStream::stop):
(WebCore::AsyncFileStream::getSize):
(WebCore::AsyncFileStream::openForRead):
(WebCore::AsyncFileStream::openForWrite):
(WebCore::AsyncFileStream::close):
(WebCore::AsyncFileStream::read):
(WebCore::AsyncFileStream::write):
(WebCore::AsyncFileStream::truncate):
(WebCore::didStart): Deleted.
(WebCore::AsyncFileStream::startOnFileThread): Deleted.
(WebCore::derefProxyOnMainThread): Deleted.
(WebCore::AsyncFileStream::stopOnFileThread): Deleted.
(WebCore::didGetSize): Deleted.
(WebCore::AsyncFileStream::getSizeOnFileThread): Deleted.
(WebCore::didOpen): Deleted.
(WebCore::AsyncFileStream::openForReadOnFileThread): Deleted.
(WebCore::AsyncFileStream::openForWriteOnFileThread): Deleted.
(WebCore::AsyncFileStream::closeOnFileThread): Deleted.
(WebCore::didRead): Deleted.
(WebCore::AsyncFileStream::readOnFileThread): Deleted.
(WebCore::didWrite): Deleted.
(WebCore::AsyncFileStream::writeOnFileThread): Deleted.
(WebCore::didTruncate): Deleted.
(WebCore::AsyncFileStream::truncateOnFileThread): Deleted.
- fileapi/AsyncFileStream.h:
- fileapi/FileThread.cpp:
(WebCore::FileThread::postTask):
- fileapi/FileThread.h:
(WebCore::FileThread::Task::Task):
- 6:10 AM Changeset in webkit [169674] by
-
- 3 edits in trunk/Source/WebCore
Pass C++11 lambdas to callOnMainThread() calls in IconDatabase
https://bugs.webkit.org/show_bug.cgi?id=133374
Reviewed by Darin Adler.
Use C++11 lambads to inline the main thread tasks into the calling code,
modernizing the look of the code and removing a few static methods and
classes that were used as helpers.
- loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::scheduleOrDeferSyncTimer):
(WebCore::IconDatabase::performURLImport):
(WebCore::IconDatabase::dispatchDidImportIconURLForPageURLOnMainThread):
(WebCore::IconDatabase::dispatchDidImportIconDataForPageURLOnMainThread):
(WebCore::IconDatabase::dispatchDidRemoveAllIconsOnMainThread):
(WebCore::IconDatabase::dispatchDidFinishURLImportOnMainThread):
(WebCore::IconDatabase::notifyPendingLoadDecisionsOnMainThread): Deleted.
(WebCore::IconDatabase::performScheduleOrDeferSyncTimer): Deleted.
(WebCore::IconDatabase::performScheduleOrDeferSyncTimerOnMainThread): Deleted.
(WebCore::ClientWorkItem::ClientWorkItem): Deleted.
(WebCore::ClientWorkItem::~ClientWorkItem): Deleted.
(WebCore::ImportedIconURLForPageURLWorkItem::ImportedIconURLForPageURLWorkItem): Deleted.
(WebCore::ImportedIconURLForPageURLWorkItem::~ImportedIconURLForPageURLWorkItem): Deleted.
(WebCore::ImportedIconURLForPageURLWorkItem::performWork): Deleted.
(WebCore::ImportedIconDataForPageURLWorkItem::ImportedIconDataForPageURLWorkItem): Deleted.
(WebCore::ImportedIconDataForPageURLWorkItem::~ImportedIconDataForPageURLWorkItem): Deleted.
(WebCore::ImportedIconDataForPageURLWorkItem::performWork): Deleted.
(WebCore::RemovedAllIconsWorkItem::RemovedAllIconsWorkItem): Deleted.
(WebCore::RemovedAllIconsWorkItem::performWork): Deleted.
(WebCore::FinishedURLImport::FinishedURLImport): Deleted.
(WebCore::FinishedURLImport::performWork): Deleted.
(WebCore::performWorkItem): Deleted.
- loader/icon/IconDatabase.h:
- 6:06 AM Changeset in webkit [169673] by
-
- 4 edits in trunk/Source/WebCore
Replace uses of CrossThreadTask in DefaultSharedWorkerRepository, WorkerMessagingProxy with C++11 lambdas
https://bugs.webkit.org/show_bug.cgi?id=133375
Reviewed by Darin Adler.
Uses of CrossThreadTask in the two classes are replaced with C++11 lambdas.
The necessary cross-thread copies are created manually and passed into the
lambdas by value, removing the need for CrossThreadTask and its use of CrossThreadCopier.
Remove the explicit use of this pointer in some lambdas -- it is captured automatically when
capturing by value, so enforcing its capturing through explicit use is not necessary.
- workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerProxy::postExceptionToWorkerObject):
(WebCore::SharedWorkerProxy::postConsoleMessageToWorkerObject):
(WebCore::postExceptionTask): Deleted.
(WebCore::postConsoleMessageTask): Deleted.
- workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::postMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::postConsoleMessageToWorkerObject):
(WebCore::WorkerMessagingProxy::workerObjectDestroyed):
(WebCore::WorkerMessagingProxy::notifyNetworkStateChange):
(WebCore::WorkerMessagingProxy::connectToInspector):
(WebCore::WorkerMessagingProxy::disconnectFromInspector):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):
(WebCore::WorkerMessagingProxy::postMessageToPageInspector):
(WebCore::WorkerMessagingProxy::confirmMessageFromWorkerObject):
(WebCore::WorkerMessagingProxy::reportPendingActivity):
(WebCore::postConsoleMessageTask): Deleted.
(WebCore::WorkerMessagingProxy::workerObjectDestroyedInternal): Deleted.
(WebCore::connectToWorkerGlobalScopeInspectorTask): Deleted.
(WebCore::disconnectFromWorkerGlobalScopeInspectorTask): Deleted.
(WebCore::dispatchOnInspectorBackendTask): Deleted.
- workers/WorkerMessagingProxy.h:
- 2:21 AM Changeset in webkit [169672] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Fix a path used for sandbox profiles
https://bugs.webkit.org/show_bug.cgi?id=133602
<rdar://problem/17212011>
Reviewed by David Kilzer.
- WebKit2.xcodeproj/project.pbxproj:
- 1:10 AM Changeset in webkit [169671] by
-
- 2 edits4 adds in trunk/LayoutTests
Add tests for dynamic changes in msqrt/mroot
https://bugs.webkit.org/show_bug.cgi?id=133557
Reviewed by Chris Fleizach.
This patch adds some tests to verify that a MathML msqrt/mroot element to which we applied dynamic additions and removals of children renders the same as its static equivalent and that no crashes happen.
Unfortunately, the existing code does not handle them very well so they are skipped until we do the refactoring of bug 119038.
- TestExpectations: skip the tests.
- mathml/roots-addChild-expected.html: Added.
- mathml/roots-addChild.html: Added.
- mathml/roots-removeChild-expected.html: Added.
- mathml/roots-removeChild.html: Added.
Jun 6, 2014:
- 6:29 PM Changeset in webkit [169670] by
-
- 9 edits in trunk
Scheme of content utils should be compared in an ASCII case-insensitive manner
https://bugs.webkit.org/show_bug.cgi?id=133502
Reviewed by Darin Adler.
Source/WebCore:
According to spec, scheme must be compared in an ASCII case-insensitive manner by user agents.
Covered by existing tests.
- Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::isProtocolWhitelisted):
LayoutTests:
Tests are updated to compare protocol in ASCII case-insensitive manner.
- fast/dom/NavigatorContentUtils/register-protocol-handler-expected.txt:
- fast/dom/NavigatorContentUtils/register-protocol-handler.html:
- fast/dom/NavigatorContentUtils/unregister-protocol-handler-expected.txt:
- fast/dom/NavigatorContentUtils/unregister-protocol-handler.html:
- platform/efl/fast/dom/NavigatorContentUtils/register-protocol-handler-expected.txt:
- platform/efl/fast/dom/NavigatorContentUtils/unregister-protocol-handler-expected.txt:
- 5:30 PM Changeset in webkit [169669] by
-
- 7 edits in trunk/Source/WebKit2
REGRESSION (iOS WebKit2): backspace key does not repeat beyond a single word.
https://bugs.webkit.org/show_bug.cgi?id=133593
<rdar://problem/16352228>
Reviewed by Benjamin Poulain.
We need to provide a way for the keyboard layer to select from
the current position to the beginning of the word moving backwards
and implement the method to know when we have reached the beginning of the document.
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView selectWordBackward]):
(-[WKContentView _selectionAtDocumentStart]):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::selectWordBackward):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::selectWordBackward):
- 4:56 PM Changeset in webkit [169668] by
-
- 11 edits in trunk/Source
Indexed getters should return values directly on the PropertySlot.
<https://webkit.org/b/133586>
Source/JavaScriptCore:
Remove PropertySlot's custom index mode.
Reviewed by Darin Adler.
- runtime/JSObject.h:
(JSC::PropertySlot::getValue):
- runtime/PropertySlot.h:
(JSC::PropertySlot::setCustomIndex): Deleted.
Source/WebCore:
Make indexed getters more efficient by using PropertySlot::setValue()
to pass the value directly back through the slot, instead of giving it
a function pointer that JSC would then immediately call back through
to retrieve the value.
The function pointer approach would make sense if we did inline caching
of indexed getters but since we currently don't, this is pure overhead.
Reviewed by Darin Adler.
- bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::getOwnPropertySlotDelegate):
(WebCore::cssPropertyGetterPixelOrPosPrefixCallback): Deleted.
(WebCore::cssPropertyGetterCallback): Deleted.
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):
(WebCore::indexGetter): Deleted.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateGetOwnPropertySlotBody):
(GenerateHeader):
(GetIndexedGetterExpression):
(GenerateImplementation):
- bridge/runtime_array.cpp:
(JSC::RuntimeArray::getOwnPropertySlot):
(JSC::RuntimeArray::getOwnPropertySlotByIndex):
(JSC::RuntimeArray::indexGetter): Deleted.
- bridge/runtime_array.h:
- 4:32 PM Changeset in webkit [169667] by
-
- 2 edits in tags/Safari-538.39/Source/WebCore
Merge r169665. <rdar://problem/15840022>
- 4:18 PM Changeset in webkit [169666] by
-
- 3 edits in trunk/Source/WebCore
GenericCueData elements prematurely removed
https://bugs.webkit.org/show_bug.cgi?id=133588
Reviewed by Eric Carlson.
Add a 'removeCompletedCues' method instead of using the 'resetCueValues' method
after processing new cues. We do not want to reset cue state if we have pending
cues that are being extended by future updates (such as paint-on cues).
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processCue): Call new 'removeCompletedCues' method.
(WebCore::InbandTextTrackPrivateAVF::removeCompletedCues): Added.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.h:
- 4:07 PM Changeset in webkit [169665] by
-
- 2 edits in trunk/Source/WebCore
Initialize a char* that needs to be initialized.
<rdar://problem/15840022> and https://bugs.webkit.org/show_bug.cgi?id=133585
Reviewed by Mark Rowe.
r152134 (erroneously) removed this initialization.
- platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare): tail should start out initialized to 0.
- 3:06 PM Changeset in webkit [169664] by
-
- 8 edits in trunk/Source/WebKit2
Adopt the new UIAlertController API to replace UIActionSheet.
https://bugs.webkit.org/show_bug.cgi?id=133582
<rdar://problem/16845223>
Reviewed by Joseph Pecoraro.
UIActionSheet is deprecated. We need to move out action sheets
implementation to UIAlertView.
- UIProcess/API/Cocoa/_WKElementAction.h:
- UIProcess/API/Cocoa/_WKElementAction.mm:
- UIProcess/ios/WKActionSheet.h:
- UIProcess/ios/WKActionSheet.mm:
(-[WKActionSheet presentSheetFromRect:]):
(-[WKActionSheet doneWithSheet]):
(-[WKActionSheet willRotate]):
(-[WKActionSheet updateSheetPosition]):
(-[WKActionSheet _didRotateAndLayout]):
(-[WKActionSheet didRotate]):
- UIProcess/ios/WKActionSheetAssistant.h:
- UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant _createSheetWithElementActions:showLinkTitle:]):
(-[WKActionSheetAssistant showImageSheet]):
(-[WKActionSheetAssistant showLinkSheet]):
(-[WKActionSheetAssistant showDataDetectorsSheet]):
(-[WKActionSheetAssistant cleanupSheet]):
(-[WKActionSheetAssistant actionSheet:clickedButtonAtIndex:]): Deleted.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _longPressRecognized:]):
- 2:43 PM Changeset in webkit [169663] by
-
- 2 edits in trunk/Source/WebKit2
Should boost ChildProcesses on iOS
https://bugs.webkit.org/show_bug.cgi?id=133583
Reviewed by Sam Weinig.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToService):
- boost all child processes on iOS.
- 2:08 PM Changeset in webkit [169662] by
-
- 2 edits in trunk/Tools
32-bit build fix.
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
- 2:07 PM Changeset in webkit [169661] by
-
- 7 edits in tags/Safari-538.39/Source
Rollout r169656. <rdar://problem/17095692>
- 2:04 PM Changeset in webkit [169660] by
-
- 3 edits in trunk/Source/WebCore
[iOS] Support pasting HTML
https://bugs.webkit.org/show_bug.cgi?id=133581
<rdar://problem/17070305>
Reviewed by Enrica Casucci.
We can probably share a lot of code between Mac and iOS here, but for now, just
implement the unimplemented functions.
- editing/ios/EditorIOS.mm: (WebCore::Editor::WebContentReader::readHTML):
Implemented based on WebArchive reading code above, and on Mac version of readHTML.
Unlike on Mac, we don't need to support Microsoft CF_HTML format, as nothing
generates it.
- platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::read):
(WebCore::Pasteboard::supportedPasteboardTypes):
Added HTML support, as the second preferred format after WebArchive.
- 1:59 PM Changeset in webkit [169659] by
-
- 4 edits in trunk/Tools
Fix builds on 10.8; -firstObject isn't declared on NSArray there.
- DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
- DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController mouseScrollByX:andY:continuously:]):
(-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
- 1:34 PM Changeset in webkit [169658] by
-
- 5 edits in trunk/Source/WebKit2
Build fix after <http://trac.webkit.org/changeset/169655>.
The SPIs used do not exist on Mac, limit the code to iOS.
- Shared/Authentication/mac/AuthenticationManager.mac.mm:
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<Credential>::encode):
(IPC::ArgumentCoder<Credential>::decode):
- Shared/cf/ArgumentCodersCF.cpp:
(IPC::typeFromCFTypeRef):
(IPC::encode):
(IPC::decode):
- Shared/cf/ArgumentCodersCF.h:
- 1:07 PM Changeset in webkit [169657] by
-
- 2 edits in trunk/Source/WebCore
Try to fix the build after http://trac.webkit.org/changeset/169655
Unfortunately, the fix is very fragile, and will likely not work for some SDKs
or possibly local headers - all OS versions have multiple SecBase.h headers with
different definitions for SecIdentityRef.
We'll see.
- WebCore.exp.in:
- 12:57 PM Changeset in webkit [169656] by
-
- 7 edits in tags/Safari-538.39/Source
Merge r169655. <rdar://problem/17095692>
- 12:04 PM Changeset in webkit [169655] by
-
- 7 edits in trunk/Source
Source/WebCore: WebCore part of <rdar://problem/17095692> [iOS] Client-certificate authentication isn’t working
https://bugs.webkit.org/show_bug.cgi?id=133527
Reviewed by Darin Adler.
- WebCore.exp.in: Exported some Credential member functions.
Source/WebKit2: <rdar://problem/17095692> [iOS] Client-certificate authentication isn’t working
https://bugs.webkit.org/show_bug.cgi?id=133527
Reviewed by Darin Adler.
- Configurations/Network-iOS.entitlements: Enabled the Network process to access the keys
needed to create identities to authenticate with.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<Credential>::encode): Encode the credential type, and if it is a client
certificate, encode the identity and the certificates.
(IPC::ArgumentCoder<Credential>::decode): Decode the credential type. If it is a client
certificate, decode the identity and the certificates and use the proper Credential
constructor.
- Shared/cf/ArgumentCodersCF.cpp:
(IPC::typeFromCFTypeRef): Handle SecIdentityRef.
(IPC::encode): Encode an identity by encoding its certificate and a persistent reference to
its key.
(IPC::decode): Decode a certificate and a persistent reference to a key, find the key, and
create an identity.
- Shared/cf/ArgumentCodersCF.h:
- 11:37 AM Changeset in webkit [169654] by
-
- 3 edits in trunk/Source/WebCore
[iOS WebGL] Float texture extension has a slightly different name
https://bugs.webkit.org/show_bug.cgi?id=133580
<rdar://problem/17113451>
Reviewed by Brady Eidson.
Floating point textures were not available on iOS, because we were
looking for the wrong extension.
Covered by the Khronos test (and in LayoutTests):
conformance/extensions/oes-texture-float.html
- platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::supportsExtension): Look for GL_OES_texture_float
as well as GL_ARB_texture_float.
- platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
(WebCore::GraphicsContext3D::texImage2D): Increase the set of things skipped
on PLATFORM(IOS) since they are supported natively there.
- 11:00 AM Changeset in webkit [169653] by
-
- 5 edits in trunk/Source
Versioning.
- 10:59 AM Changeset in webkit [169652] by
-
- 2 edits in tags/Safari-538.39/Source/WebCore
Add UNUSED_PARAM when GRID is off.
- 10:57 AM Changeset in webkit [169651] by
-
- 7 edits in trunk
REGRESSION: Hit testing of composited elements is broken in new multicolumn layout.
https://bugs.webkit.org/show_bug.cgi?id=133522 (<rdar://problem/17060556>)
Reviewed by Simon Fraser.
Source/WebCore:
Hit testing for the new columns doesn't care about compositing but does still
need a pagination layer set to work. The old column code didn't care about this
because it was top down (and wrong). The new code lets each layer paint and hit
test its own fragments, so having a pagination layer set suddenly becomes relevant
for composited layers.
The solution is to cache whether or not the pagination layer crosses a compositing
boundary, and then to force call sites of enclosingPaginationLayer to pass an argument
indicating whether compositing layers should be included. Typically painting wants to
exclude them but hit testing wants to include them.
- page/FrameView.cpp:
(WebCore::updateLayerPositionFlags):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updatePagination):
(WebCore::transparencyClipBox):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::enclosingPaginationLayerInSubtree):
(WebCore::RenderLayer::collectFragments):
(WebCore::RenderLayer::paintTransformedLayerIntoFragments):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestTransformedLayerInFragments):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
LayoutTests:
- compositing/columns/hittest-composited-in-paginated-expected.txt:
- 10:41 AM Changeset in webkit [169650] by
-
- 18 edits in trunk
Latched scrolling tests are flakey on Mavericks
https://bugs.webkit.org/show_bug.cgi?id=133578
<rdar://problem/17180591>
Reviewed by Brent Fulgham.
Tools:
The latched scrolling tests rely on synthetic mousewheel events whose coordinates can
be wrong on machines with more than one screen. This is because we use
[NSScreen mainScreen] when computing the global coordinates of the events, but
[NSScreen mainScreen] returns the screen with the key window, not the first screen.
So replace calls to [NSScreen mainScreen] with [[NSScreen screens] firstObject]. Also
add comments clarifying why the coordinate math works (which is not obvious given
the events have no target window).
Some scrolling tests also dispatched events outside the 800x600 test window, so
fix those tests, and add logging that will appear in test output when this happens.
- DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
- DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController mouseScrollByX:andY:continuously:]):
(-[EventSendingController mouseScrollByX:andY:withWheel:andMomentumPhases:]):
- WebKitTestRunner/mac/EventSenderProxy.mm:
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::continuousMouseScrollBy):
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
LayoutTests:
Fix these tests to not dispatch events outside the window, and correct some of the wording
in the tests.
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div-expected.txt:
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div-with-handler-expected.txt:
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div-with-handler.html:
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-div.html:
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe-with-handler.html:
- platform/mac-wk2/tiled-drawing/fast-scroll-div-latched-mainframe.html:
- platform/mac-wk2/tiled-drawing/fast-scroll-iframe-latched-mainframe.html:
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe-with-handler.html:
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-mainframe.html:
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-expected.txt:
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-with-handler-expected.txt:
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select-with-handler.html:
- platform/mac-wk2/tiled-drawing/fast-scroll-select-latched-select.html:
- 9:54 AM Changeset in webkit [169649] by
-
- 2 edits in trunk/LayoutTests
Run passing WebGL tests on Windows.
https://bugs.webkit.org/show_bug.cgi?id=133563
Patch by Alex Christensen <achristensen@webkit.org> on 2014-06-06
Reviewed by Brent Fulgham.
- platform/win/TestExpectations:
Replaced all WebGL tests with lists of failing and crashing tests to fix.
- 9:33 AM Changeset in webkit [169648] by
-
- 7 edits in trunk
[MediaStream] 'get' prefix is missing for capabilities and constraints.
https://bugs.webkit.org/show_bug.cgi?id=133573
Patch by Kiran <kiran.guduru@samsung.com> on 2014-06-06
Reviewed by Eric Carlson.
Source/WebCore:
Modified the existing MediaStreamTrack.html to test the changes.
As per the Media Capture and Streams spec method names constreaints and
capabilities should be prefixed by 'get'. So updated the method names.
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::getConstraints):
(WebCore::MediaStreamTrack::getCapabilities):
(WebCore::MediaStreamTrack::constraints): Deleted.
(WebCore::MediaStreamTrack::capabilities): Deleted.
- Modules/mediastream/MediaStreamTrack.h:
- Modules/mediastream/MediaStreamTrack.idl:
LayoutTests:
- fast/mediastream/MediaStreamTrack-expected.txt:
- fast/mediastream/MediaStreamTrack.html:
- 9:20 AM Changeset in webkit [169647] by
-
- 4 edits in trunk/Source/WebCore
REGRESSION(169440): Repro crash when playing a video with captions
https://bugs.webkit.org/show_bug.cgi?id=133459
<rdar://problem/17079081>
Reviewed by Eric Carlson.
The change I made in r169440 introduced a crash for paint-on captions. This
resolves the problem as follows:
- No longer attempt to modify the start/endTime in the TextTrack implementation.
- Check for extensions to existing cues when we are about to add new arriving cues. If they extend a current pending cue, don't set an end-time for the pending cue, and throw away the new duplicate. Otherwise set the end time as previously and continue.
- html/track/TextTrack.cpp:
(WebCore::TextTrack::hasCue): Remove 'doesExtendCue' case since this is
no longer possible.
- platform/graphics/InbandTextTrackPrivateClient.h:
(WebCore::GenericCueData::doesExtendCueData): Added.
- platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::InbandTextTrackPrivateAVF::processCue): Check for cues extending
other cues and handle appropriately.
- 9:19 AM Changeset in webkit [169646] by
-
- 4 edits1 copy in trunk/LayoutTests
[GTK] Layout Test accessibility/table-fallback-roles-expose-element-attributes.html is failing
https://bugs.webkit.org/show_bug.cgi?id=133519
Reviewed by Chris Fleizach.
Adapted test to play nicely with the different types of
accessibility hierarchies exposed for Mac and ATK.
- accessibility/table-fallback-roles-expose-element-attributes.html:
Updated text to print information of cells from every platform but
only print information of their children in the Mac.
- accessibility/table-fallback-roles-expose-element-attributes-expected.txt:
Updated expectation to match ATK platforms (GTK & EFL).
- platform/mac/accessibility/table-fallback-roles-expose-element-attributes-expected.txt:
Copied from LayoutTests/accessibility/table-fallback-roles-expose-element-attributes-expected.txt.
- platform/gtk/TestExpectations: Removed expected failure.
- 8:49 AM Changeset in webkit [169645] by
-
- 4 edits in trunk/Source/WebCore
ROLLOUT: r169630: Caused a retain cycle.
https://bugs.webkit.org/show_bug.cgi?id=133463
<rdar://problem/17098100>
Rolling out this change as it introduced a retain cycle.
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::setControllerJSObject): Deleted.
- Modules/mediacontrols/MediaControlsHost.h:
(WebCore::MediaControlsHost::controllerJSValue):
(WebCore::MediaControlsHost::setControllerJSValue):
(WebCore::MediaControlsHost::controllerJSObject): Deleted.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- 12:37 AM Changeset in webkit [169644] by
-
- 1 edit7 adds in trunk/LayoutTests
Add test references for horizontal stretchy operators.
https://bugs.webkit.org/show_bug.cgi?id=72828
Unreviewed Win and EFL gardening.
- platform/efl/mathml/opentype/horizontal-LatinModern-expected.txt: Added.
- platform/efl/mathml/opentype/horizontal-LatinModern-munderover-expected.txt: Added.
- platform/efl/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Added.
- platform/win/mathml/opentype/horizontal-LatinModern-expected.txt: Added.
- platform/win/mathml/opentype/horizontal-LatinModern-munderover-expected.txt: Added.
- platform/win/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Added.
- 12:26 AM Changeset in webkit [169643] by
-
- 1 edit3 adds in trunk/LayoutTests
Add test references for horizontal stretchy operators.
https://bugs.webkit.org/show_bug.cgi?id=72828
Unreviewed Mac gardening.
- platform/mac/mathml/horizontal-LatinModern-expected.txt: Added.
- platform/mac/mathml/horizontal-LatinModern-munderover-expected.txt: Added.
- platform/mac/mathml/opentype-stretchy-horizontal-expected.txt: Added.
- 12:19 AM Changeset in webkit [169642] by
-
- 8 edits in tags/Safari-538.39/Source
Custom patch for <rdar://problem/16650338>.
- 12:08 AM Changeset in webkit [169641] by
-
- 6 edits in releases/WebKitGTK/webkit-2.2
Merge r154727 - [Soup] WebTiming information not shown in the inspector
https://bugs.webkit.org/show_bug.cgi?id=118395
Reviewed by Martin Robinson.
Source/WebCore:
WebTiming information was not correctly provided to WebCore
because the gotHeadersCallback was incorrectly resetting the
original ResourceResponse (which had the ResourceLoadTiming
object) instead of simply updating their contents using the
SoupMessage.
No new test required as this feature is already covered by the
existing webtiming tests. In any case this change includes a fix
for the http/tests/misc/webtiming-ssl.php test which was not
failing even if it should because it was not correct.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::gotHeadersCallback):
(WebCore::restartedCallback): restartedCallback should be
available only if WEB_TIMING is defined.
(WebCore::createSoupMessageForHandleAndRequest): Ditto.
LayoutTests:
Fixed the webiming-ssl.php test that was incorrectly considering a
FAIL as the expected result. It was probably just a legacy
decision which came from the times where DRT was responsible of
reporting WebTiming information.
Also added a new test that fails due to wkb.ug/103927. It was not
detected before because there were no timing information in the
response.
- http/tests/misc/resources/webtiming-ssl.html:
- http/tests/misc/webtiming-ssl-expected.txt:
- platform/gtk/TestExpectations: added
http/tests/w3c/webperf/submission/Google/resource-timing/html/test_resource_attribute_order.html.
Jun 5, 2014:
- 11:53 PM Changeset in webkit [169640] by
-
- 2 edits in trunk/Source/WebCore
StyleResolver doesn't compile without CSS_GRID_LAYOUT enabled
https://bugs.webkit.org/show_bug.cgi?id=133568
Reviewed by Tim Horton.
- css/StyleResolver.cpp:
(WebCore::isDisplayGridBox): Add UNUSED_PARAM.
- 11:44 PM Changeset in webkit [169639] by
-
- 3 edits2 adds in trunk
[CSSRegions] Region box incorrectly overlaps floating box
https://bugs.webkit.org/show_bug.cgi?id=133545
Reviewed by David Hyatt.
Source/WebCore:
A region box creates a BFC and it should not overlap a floating box in the same formatting context: http://www.w3.org/TR/CSS21/visuren.html#bfc-next-to-float
Test: fast/regions/region-as-bfc-avoids-float.html
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::avoidsFloats):
LayoutTests:
Add test to check that a region does not incorrectly overlap a floating
element in the same formatting context.
- fast/regions/region-as-bfc-avoids-float-expected.html: Added.
- fast/regions/region-as-bfc-avoids-float.html: Added.
- 11:43 PM Changeset in webkit [169638] by
-
- 1 copy in tags/Safari-538.39
Create the Safari-538.39 tag.
- 11:06 PM Changeset in webkit [169637] by
-
- 17 edits1 move2 deletes in trunk
Align srcset parser with recent spec changes
https://bugs.webkit.org/show_bug.cgi?id=133504
Reviewed by Darin Adler.
Source/WebCore:
New tests were added to fast/hidpi/image-srcset-invalid-descriptor.html
The srcset parser changes align it with the spec:
http://picture.responsiveimages.org/#parse-srcset-attr.
The spec changes are meant to give the parser better future
compatibility, and enable it to work well with the 'w' descriptor, the
soon to be added 'h' descriptor and function descriptors (e.g.
future-descriptor(a, b, c) ).
- CMakeLists.txt:
- WebCore.vcxproj/WebCore.vcxproj:
- WebCore.vcxproj/WebCore.vcxproj.filters:
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::setBestFitURLAndDPRFromImageCandidate):
(WebCore::HTMLImageElement::parseAttribute):
- html/HTMLImageElement.h:
- html/parser/HTMLParserIdioms.h:
(WebCore::isHTMLSpace):
(WebCore::isComma):
(WebCore::isHTMLSpaceOrComma):
- html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
- html/parser/HTMLSrcsetParser.cpp:
(WebCore::compareByDensity):
(WebCore::appendDescriptorAndReset):
(WebCore::appendCharacter):
(WebCore::isEOF):
(WebCore::tokenizeDescriptors):
(WebCore::stringViewToFloat):
(WebCore::stringViewToInt):
(WebCore::parseDescriptors):
(WebCore::parseImageCandidatesFromSrcsetAttribute):
(WebCore::pickBestImageCandidate):
(WebCore::bestFitSourceForImageAttributes):
(WebCore::compareByScaleFactor): Deleted.
(WebCore::parseImagesWithScaleFromSrcsetAttribute): Deleted.
- html/parser/HTMLSrcsetParser.h:
(WebCore::DescriptorParsingResult::DescriptorParsingResult):
(WebCore::DescriptorParsingResult::hasDensity):
(WebCore::DescriptorParsingResult::hasWidth):
(WebCore::DescriptorParsingResult::hasHeight):
(WebCore::DescriptorParsingResult::density):
(WebCore::DescriptorParsingResult::resourceWidth):
(WebCore::DescriptorParsingResult::resourceHeight):
(WebCore::DescriptorParsingResult::setResourceWidth):
(WebCore::DescriptorParsingResult::setResourceHeight):
(WebCore::DescriptorParsingResult::setDensity):
(WebCore::ImageCandidate::ImageCandidate):
(WebCore::ImageCandidate::toString):
(WebCore::ImageCandidate::url):
(WebCore::ImageCandidate::setDensity):
(WebCore::ImageCandidate::density):
(WebCore::ImageCandidate::resourceWidth):
(WebCore::ImageCandidate::srcOrigin):
(WebCore::ImageCandidate::isEmpty):
(WebCore::ImageWithScale::ImageWithScale): Deleted.
(WebCore::ImageWithScale::imageURL): Deleted.
(WebCore::ImageWithScale::scaleFactor): Deleted.
- html/parser/ParsingUtilities.h: Renamed from Source/WebCore/html/track/ParsingUtilities.h.
(skipExactly):
(skipUntil):
(skipWhile):
(reverseSkipWhile):
Source/WTF:
I've added toInt and toFloat methods to StringView, and exposed
charactersToInt so that they can be used by
HTMLSrcsetParser.cpp.
- wtf/text/WTFString.h:
- wtf/text/StringView.h:
(WTF::StringView::toInt):
(WTF::StringView::toFloat):
LayoutTests:
I have changed the "invalid-descriptor" test and removed the "invalid
inputs correct src" test to reflect the fact that invalid descriptors
are now treated identically to null descriptors. That is according to
the spec.
I've also added new tests that make sure that the spec's future
compatible changes are working.
- fast/hidpi/image-srcset-invalid-descriptor-expected.txt:
- fast/hidpi/image-srcset-invalid-descriptor.html:
- fast/hidpi/image-srcset-invalid-inputs-correct-src-expected.txt: Removed.
- fast/hidpi/image-srcset-invalid-inputs-correct-src.html: Removed.
- 10:11 PM Changeset in webkit [169636] by
-
- 3 edits2 adds in trunk
Source/WebCore: Current media controls look different from previous media controls. Adjusted CSS to make media elements more similar by adding padding, adjusting hues/svg, resizing elements, etc.
https://bugs.webkit.org/show_bug.cgi?id=133521
Patch by Wenson Hsieh <Wenson Hsieh> on 2014-06-05
Reviewed by Eric Carlson.
The main issues:
- The widths between elements of both audio and video players are incorrect.
- The hues of audio player elements are incorrect.
- The hues of video player elements are content dependent (refer to full-screen mode), and this cannot be exactly replicated using just css. This patch only attempts to make them more similar.
- The height of the audio player is incorrect.
Test: platform/ios-sim/media/audio-width.html
- Modules/mediacontrols/mediaControlsiOS.css: Updated style elements for audio/video elements.
(::-webkit-media-controls): Enforce a minimum width on audio/video controls.
(audio): Enforce a minimum width on audio elements.
(audio::-webkit-media-controls): see below
(audio::-webkit-media-controls-wireless-playback-picker-button): modified SVG, hue and width/height.
(audio::-webkit-media-controls-panel): adjusted hue, added left/right padding.
(audio::-webkit-media-controls-fullscreen-button): removed. There's no fullscreen for audio anyways.
(audio::-webkit-media-controls-current-time-display): adjusted font size, added left padding.
(audio::-webkit-media-controls-time-remaining-display): adjusted font size, added right padding.
(video::-webkit-media-controls-panel): adjusted hue, added left/right padding.
(video::-webkit-media-controls-current-time-display): added left padding.
(video::-webkit-media-controls-time-remaining-display): added right padding.
(video::-webkit-media-controls-wireless-playback-picker-button): modified SVG, hue, opacity and width/height.
(video::-webkit-media-controls-fullscreen-button): modified SVG, hue, opacity, and width/height. In particular, made the svg seem sharper.
(video::-webkit-media-controls-play-button): modified SVG, hue, opacity, and width/height.
LayoutTests: REGRESSION (Pluginless): Media controls look different from iOS7 media controls.
https://bugs.webkit.org/show_bug.cgi?id=133521
Patch by Wenson Hsieh <Wenson Hsieh> on 2014-06-05
Reviewed by Eric Carlson.
Tests that audio elements are properly sized. Will add tests for video players in the (near) future.
- platform/ios-sim/media/audio-width-expected.txt: Checks that audio width tests were OK'd
- platform/ios-sim/media/audio-width.html: Checks that minimum audio width is properly enforced
- 7:22 PM Changeset in webkit [169635] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r169570.
https://bugs.webkit.org/show_bug.cgi?id=133565
It breaks Baidu (Requested by benjaminp on #webkit).
Reverted changeset:
"[iOS] Start ignoring common bogus viewport parameters"
https://bugs.webkit.org/show_bug.cgi?id=133466
http://trac.webkit.org/changeset/169570
- 7:02 PM Changeset in webkit [169634] by
-
- 5 edits in branches/safari-538.34-branch/Source
Bump versioning
- 6:45 PM Changeset in webkit [169633] by
-
- 1 copy in tags/Safari-538.34.49
Tagging Safari-538.34.49
- 5:23 PM Changeset in webkit [169632] by
-
- 3 edits2 adds in trunk
AX: Add support for ARIA 1.1 'none' role
https://bugs.webkit.org/show_bug.cgi?id=133367
Patch by Michael Timbrook <timbrook@apple.com> on 2014-06-05
Reviewed by Chris Fleizach.
Source/WebCore:
Added support for the 'none' role by added a lookup for it to go to PresentationalRole
Test: accessibility/aria-none-role.html
- accessibility/AccessibilityObject.cpp:
(WebCore::initializeRoleMap):
LayoutTests:
Added the tests to cover the behavior of the 'none' role
- accessibility/aria-none-role-expected.txt: Added.
- accessibility/aria-none-role.html: Added.
- 4:53 PM Changeset in webkit [169631] by
-
- 6 edits3 adds in trunk
AX: [ATK] Children of tables and lists with role='presentation' should each be exposed as if they were div elements
https://bugs.webkit.org/show_bug.cgi?id=133133
Reviewed by Chris Fleizach.
Source/WebCore:
When a table or list has role='presentation', accessibility is "ignored"
for that element, but not for the required children. The default roles
for the children (CellRole and ListItemRole) do not make sense without
the parent, therefore map them to DivRole in ATK if they inherit the
presentational role.
Test: accessibility/aria-inherits-presentational.html
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::inheritsPresentationalRole):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::inheritsPresentationalRole):
- accessibility/AccessibilityRenderObject.h:
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkRole):
LayoutTests:
Added a new test with platform-specific expectations due to differences
in accessible hierarchies.
- accessibility/aria-inherits-presentational.html: Added.
- platform/gtk/accessibility/aria-inherits-presentational-expected.txt: Added.
- platform/mac/accessibility/aria-inherits-presentational-expected.txt: Added.
- 4:46 PM Changeset in webkit [169630] by
-
- 4 edits in trunk/Source/WebCore
REGRESSION (r167962): Out of bounds read in JSC::StructureIDTable::get()
https://bugs.webkit.org/show_bug.cgi?id=133463
<rdar://problem/17098100>
Reviewed by Dean Jackson.
Revise MediaControllerHost implementation so that it holds a Strong
reference to the JavaScript 'Controller' object it mirrors. The
MediaControllerHost is constructed when we create an HTMLMediaElement,
and is the logical place to retain ownership of the JS object so that
it does not get garbage collected as long as HTMLMediaElement exists.
- Modules/mediacontrols/MediaControlsHost.cpp:
(WebCore::MediaControlsHost::setControllerJSObject): Create a strong
reference to the JavaScript Controller object.
- Modules/mediacontrols/MediaControlsHost.h: Use JSC::Strong to hold a
JSObject, rather than a bare JSValue.
(WebCore::MediaControlsHost::controllerJSObject): Change name to reflect
that we are working with JSObjects, not JSValues.
(WebCore::MediaControlsHost::controllerJSValue): Deleted.
(WebCore::MediaControlsHost::setControllerJSValue): Deleted.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute): Revise for changed method
signature.
- 4:19 PM Changeset in webkit [169629] by
-
- 4 edits2 adds2 deletes in trunk/LayoutTests
Share platform/mac/editing/spelling/move-cursor-around-misspelled-word.html with other platforms
https://bugs.webkit.org/show_bug.cgi?id=133208
Reviewed by Darin Adler.
Move the test to common editing/spelling since it just verifies spelling
markers and other platforms might be interested in running it as well.
Due to bug 125688, the test starts using asynchronous spellchecking.
Add additional test case which checks spelling marker after typing
the text, before any caret change.
- editing/spelling/move-cursor-around-misspelled-word-expected.txt:
Renamed from platform/mac/editing/spelling/move-cursor-around-misspelled-word-expected.txt
- editing/spelling/move-cursor-around-misspelled-word.html:
Renamed from platform/mac/editing/spelling/move-cursor-around-misspelled-word.html
- platform/gtk/TestExpectations:
- platform/mac-wk2/TestExpectations:
- platform/win/TestExpectations:
Add failing expectation for platforms which didn't switch to
asynchronous spellchecking.
- 3:54 PM Changeset in webkit [169628] by
-
- 29 edits4 adds1 delete in branches/ftlopt/Source/JavaScriptCore
Added system for inlining native functions via the FTL.
https://bugs.webkit.org/show_bug.cgi?id=131515
Patch by Matthew Mirman <mmirman@apple.com> on 2014-06-04
Reviewed by Filip Pizlo.
Also fixed the build to not compress the bitcode and to
include all of the relevant runtime. With GCC_GENERATE_DEBUGGING_SYMBOLS = NO,
the produced bitcode files are a 100th the size they were before.
Now we can include all of the relevant runtime files with only a 3mb overhead.
This is the same overhead as for two compressed files before,
but done more efficiently (on both ends) and with less code.
Deciding whether to inline native functions is left up to LLVM.
The entire module containing the function is linked into the current
compiled JS so that inlining the native functions shouldn't make them smaller.
Rather than loading Runtime.symtbl at runtime FTLState.cpp now generates a file
InlineRuntimeSymbolTable.h which statically builds the symbol table hash table.
- JavaScriptCore.xcodeproj/project.pbxproj: Added back runtime files to compile.
- build-symbol-table-index.py: Changed bitcode suffix.
Added inclusion of only tested symbols.
Added output to InlineRuntimeSymbolTable.h.
- build-symbol-table-index.sh: Changed bitcode suffix.
- copy-llvm-ir-to-derived-sources.sh: Removed gzip compression.
- tested-symbols.symlst: Added.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
Now sets the knownFunction of the call node if such a function exists
and emits a check that during runtime the callee is in fact known.
- dfg/DFGNode.h:
Added functions to set the known function of a call node.
(JSC::DFG::Node::canBeKnownFunction): Added.
(JSC::DFG::Node::hasKnownFunction): Added.
(JSC::DFG::Node::knownFunction): Added.
(JSC::DFG::Node::giveKnownFunction): Added.
- ftl/FTLAbbreviatedTypes.h: Added a typedef for LLVMMemoryBufferRef
- ftl/FTLAbbreviations.h: Added some abbreviations.
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::isInlinableSize): Added. Hardcoded threshold to 275.
(JSC::FTL::LowerDFGToLLVM::getModuleByPathForSymbol): Added.
(JSC::FTL::LowerDFGToLLVM::getFunctionBySymbol): Added.
(JSC::FTL::LowerDFGToLLVM::possiblyCompileInlineableNativeCall): Added.
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
Added call to possiblyCompileInlineableNativeCall
- ftl/FTLOutput.h:
(JSC::FTL::Output::allocaName): Added. Useful for debugging.
- ftl/FTLState.cpp:
(JSC::FTL::State::State): Added an include for InlineRuntimeSymbolTable.h
- ftl/FTLState.h: Added symbol table hash table.
- ftl/FTLCompile.cpp:
(JSC::FTL::compile): Added inlining and dead function elimination passes.
- heap/HandleStack.h: Added JS_EXPORT_PRIVATE to a few functions to get inlining to compile.
- llvm/InitializeLLVMMac.mm: Deleted.
- llvm/InitializeLLVMMac.cpp: Added.
- llvm/LLVMAPIFunctions.h: Added macros to include Bitcode parsing and linking functions.
- llvm/LLVMHeaders.h: Added includes for Bitcode parsing and linking.
- runtime/BundlePath.h: Added.
- runtime/BundlePath.mm: Added.
- runtime/DateInstance.h: Added JS_EXPORT_PRIVATE to a few functions to get inlining to compile.
- runtime/DateInstance.h: ditto.
- runtime/DateConversion.h: ditto.
- runtime/ExceptionHelpers.h: ditto.
- runtime/JSCJSValue.h: ditto.
- runtime/JSArray.h: ditto.
- runtime/JSDateMath.h: ditto.
- runtime/JSObject.h: ditto.
- runtime/JSObject.h: ditto.
- runtime/RegExp.h: ditto.
- runtime/Structure.h: ditto.
- runtime/Options.h: Added maximumLLVMInstructionCountForNativeInlining.
- 2:40 PM Changeset in webkit [169627] by
-
- 3 edits in trunk/Source/WebKit/mac
Remove unsused method _setAcceleratedImageDecoding
https://bugs.webkit.org/show_bug.cgi?id=133554
Reviewed by Jon Honeycutt.
- WebView/WebView.mm:
(+[WebView _setAcceleratedImageDecoding:]): Deleted.
- WebView/WebViewPrivate.h:
- 2:36 PM Changeset in webkit [169626] by
-
- 2 edits in trunk/Source/WebKit2
[iOS][WK2] WebPage sometimes forces two resize events on animated resize
https://bugs.webkit.org/show_bug.cgi?id=133534
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-05
Reviewed by Enrica Casucci.
When I updated the patch for resize events (r168556) to use the unobscured rect in scrollview coordinates,
I forgot to update a snippet of code in dynamicViewportSizeUpdate(). Since that code was still using
the scaled unobscured rect, there was sometimes a difference of 1 pixel between the size set by that
call site and the others.
This path nukes the bad code and use the unobscured rect in scrollview coordinates given by the UIProcess.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::dynamicViewportSizeUpdate):
- 2:14 PM Changeset in webkit [169625] by
-
- 26 edits in trunk/Source
[iOS][WK2] Add device orientation
https://bugs.webkit.org/show_bug.cgi?id=133530
Source/WebCore:
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-05
Reviewed by Tim Horton.
Previously, WebCore was getting the orientation directly from the WebKit layer.
This had to be done during the frame creation and was very fragile.
Frame is changed to pull the value from the chrome client. That way we avoid races
and we can maintain a single value for all frames.
Sending the values to all the subframes is aslo done here so that we do not have to repeat
it in both WebKit layers.
- WebCore.exp.in:
- loader/EmptyClients.h:
- page/ChromeClient.h:
- page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::orientationChanged):
(WebCore::Frame::orientation):
(WebCore::Frame::sendOrientationChangeEvent): Deleted.
- page/Frame.h:
(WebCore::Frame::orientation): Deleted.
Source/WebKit/ios:
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-05
Reviewed by Tim Horton.
Change WebKit1 to provide the deviceOrientation as pull instead of push.
- DefaultDelegates/WebDefaultUIKitDelegate.m:
(-[WebDefaultUIKitDelegate deviceOrientation]):
- WebCoreSupport/WebChromeClientIOS.h:
- WebCoreSupport/WebChromeClientIOS.mm:
(WebChromeClientIOS::deviceOrientation):
- WebView/WebUIKitDelegate.h:
Source/WebKit/mac:
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-05
Reviewed by Tim Horton.
- WebView/WebFrame.mm:
(-[WebFrame deviceOrientationChanged]):
(-[WebFrame sendOrientationChangeEvent:]):
- WebView/WebFramePrivate.h:
Source/WebKit2:
<rdar://problem/16680041>
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-05
Reviewed by Tim Horton.
Add device orientation for WebKit2.
For the public API, WKWebView get the updates through the notification UIWindowDidRotateNotification.
We do not have any control over how the API is used, but we can expect the size will be updated before
the end of rotation in most cases and the events should be sent in the right order.
For Safari, we use an override to support animated resize (and some tabs corner cases).
On the WebProcess side, we just get the new orientation directly or on DynamicViewportSizeUpdate.
- UIProcess/API/Cocoa/WKWebView.mm:
(deviceOrientationForUIInterfaceOrientation):
(deviceOrientation):
(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView _windowDidRotate:]):
(-[WKWebView _setInterfaceOrientationOverride:]):
(-[WKWebView _interfaceOrientationOverride]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::deviceOrientation):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::dynamicViewportSizeUpdate):
(WebKit::WebPageProxy::setDeviceOrientation):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:
(WebKit::WebChromeClient::deviceOrientation):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::deviceOrientation):
- WebProcess/WebPage/WebPage.messages.in:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::setDeviceOrientation):
(WebKit::WebPage::dynamicViewportSizeUpdate):
- 2:10 PM Changeset in webkit [169624] by
-
- 2 edits in trunk/LayoutTests
media/video-rtl.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=133363
- platform/mac/TestExpectations: Marked as such.
- 2:00 PM Changeset in webkit [169623] by
-
- 2 edits in trunk/Source/WebCore
Fix the !CACHE_SUBIMAGES build
- platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawNativeImage):
- 12:49 PM Changeset in webkit [169622] by
-
- 2 edits in trunk/Source/WebKit2
Enable SANDBOX_EXTENSIONS build flag universally on cocoa
https://bugs.webkit.org/show_bug.cgi?id=133556
Reviewed by Alexey Proskuryakov.
Remove unnecessary iOS exception.
- WebKit2Prefix.h:
- 11:40 AM Changeset in webkit [169621] by
-
- 2 edits in trunk/Source/WebCore
CSS JIT: Clean up StackAllocator
https://bugs.webkit.org/show_bug.cgi?id=133506
Patch by Yusuke Suzuki <Yusuke Suzuki> on 2014-06-05
Reviewed by Benjamin Poulain.
Cleaning up CSS JIt StackAllocator code. Sharing push / pop code and
using information provided by MacroAssembler more aggressively
to drop ifdefs.
- cssjit/StackAllocator.h:
(WebCore::StackAllocator::allocateUninitialized):
(WebCore::StackAllocator::push):
(WebCore::StackAllocator::pop):
(WebCore::StackAllocator::popAndDiscard):
(WebCore::StackAllocator::popAndDiscardUpTo):
(WebCore::StackAllocator::alignStackPreFunctionCall):
(WebCore::StackAllocator::unalignStackPostFunctionCall):
(WebCore::StackAllocator::stackUnitInBytes):
- 11:18 AM Changeset in webkit [169620] by
-
- 4 edits2 adds in trunk
Subpixel rendering: border-radius painting falls back to rectangle when the snapped rounded rect becomes non-renderable.
https://bugs.webkit.org/show_bug.cgi?id=133491
Reviewed by Simon Fraser.
Pixel snapping can change the rectangle's size when it is on a certain subpixel position. (usually it does not)
This patch ensures that the snapped rect is still renderable by adjusting the radii as well.
Source/WebCore:
Test: fast/borders/hidpi-border-radius-with-subpixel-margin-not-renderable.html
- platform/graphics/RoundedRect.cpp:
(WebCore::RoundedRect::Radii::scale):
(WebCore::RoundedRect::pixelSnappedRoundedRectForPainting):
- platform/graphics/RoundedRect.h:
LayoutTests:
- fast/borders/hidpi-border-radius-with-subpixel-margin-not-renderable-expected.html: Added.
- fast/borders/hidpi-border-radius-with-subpixel-margin-not-renderable.html: Added.
- 10:21 AM Changeset in webkit [169619] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, rolling out r169587.
https://bugs.webkit.org/show_bug.cgi?id=133552
Calls a pure virtual method, crashes (Requested by ap on
#webkit).
Reverted changeset:
"WebKit should adopt journal_mode=wal for all SQLite
databases."
https://bugs.webkit.org/show_bug.cgi?id=133496
http://trac.webkit.org/changeset/169587
- 10:21 AM Changeset in webkit [169618] by
-
- 3 edits in trunk/Source/WebKit2
[Mac] Tweak plug-in sandbox profiles
https://bugs.webkit.org/show_bug.cgi?id=133549
Fix <rdar://problem/17068055> and <rdar://problem/17148837>.
Reviewed by Sam Weinig and Simon Cooper.
- Resources/PlugInSandboxProfiles/com.apple.ist.ds.appleconnect.webplugin.sb:
- Resources/PlugInSandboxProfiles/com.microsoft.SilverlightPlugin.sb:
- 9:23 AM Changeset in webkit [169617] by
-
- 3 edits2 adds in trunk
Apply Character-level mirroring to stretchy operators in RTL mode.
https://bugs.webkit.org/show_bug.cgi?id=130839
Reviewed by Chris Fleizach.
Source/WebCore:
We add support for character-level mirroring for stretchy MathML operators in RTL mode.
Glyph-level mirroring (via the rtlm OpenType feature) will be handled in bug 130840.
Test: mathml/presentation/stretchy-rtl.html
- rendering/mathml/RenderMathMLOperator.cpp: reorganize the Unicode stretchyCharacters table to make mirroring easy.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): pass the right boolean to glyphDataForCharacter.
(WebCore::RenderMathMLOperator::getDisplayStyleLargeOperator): ditto
(WebCore::RenderMathMLOperator::findStretchyData): ditto and change the index for the stretchyCharacters fallback.
(WebCore::RenderMathMLOperator::updateStyle): pass the right boolean to glyphDataForCharacter.
(WebCore::RenderMathMLOperator::paint): remove the FIXME comment.
(WebCore::RenderMathMLOperator::paintVerticalGlyphAssembly): switch the leading/trailing space in RTL mode.
LayoutTests:
Add some tests to verify that stretchy operators are correctly mirrored in RTL mode.
- mathml/presentation/stretchy-rtl-expected.html: Added.
- mathml/presentation/stretchy-rtl.html: Added.
- 9:16 AM Changeset in webkit [169616] by
-
- 1 edit2 adds in trunk/LayoutTests
[CSS Regions][CSS Shapes] Add Shapes tests which flow through multiple regions
https://bugs.webkit.org/show_bug.cgi?id=133487
Reviewed by Mihnea Ovidenie.
The test verifies if the content with the shape wraps correctly through a region chain.
- fast/regions/shape-outside-floats/regions-shape-outside-content-flows-multiple-regions-expected.html: Added.
- fast/regions/shape-outside-floats/regions-shape-outside-content-flows-multiple-regions.html: Added.
- 8:59 AM Changeset in webkit [169615] by
-
- 6 edits2 adds in trunk
Subpixel rendering: Buttons in default media controls shift vertically when controls fade in or out.
https://bugs.webkit.org/show_bug.cgi?id=133488
Reviewed by Simon Fraser.
Filter effects are not subpixel aware yet. They paint to integrally sized image buffers.
In order to ensure that the content is rendered to the the same position on the filter
source context as if there was no filter, the repaint rects need to be adjusted to match with
the internal filter snapping (enclosingIntRect).
This is a temporary change until after filter effects get subpixelized.
However, this changeset regresses RenderNameFlow clipping when the content is on subpixel position
and filter effect is present. Instead of adding the failing test cases to TestExpectations, I removed
the video controls from the <video> to make the tests pass, when possible (they just happen to have <video>)
and filed webkit.org/b/133523 to track the regression.
Source/WebCore:
Test: css3/filters/filter-is-on-subpixel-position.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setupFilters):
LayoutTests:
- css3/filters/filter-is-on-subpixel-position-expected.html: Added.
- css3/filters/filter-is-on-subpixel-position.html: Added.
- fast/regions/inline-block-inside-anonymous-overflow.html:
- fast/regions/inline-block-overflow.html:
- 6:45 AM Changeset in webkit [169614] by
-
- 4 edits in trunk/Tools
[GTK] run-perf-tests should run the tests inside the jhbuild shell.
https://bugs.webkit.org/show_bug.cgi?id=133533
Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-06-05
Reviewed by Carlos Garcia Campos.
- Scripts/webkitpy/common/multiprocessing_bootstrap.py:
(run): Remove the jhbuild-wrapper wrapper from here. It should be
on Scripts/webkitpy/port/gtk.py.
- Scripts/webkitpy/port/base.py:
(Port.set_option): Add a set_option(name, value) function to set
the optparse parameter "name" to the value "value", even if the
parameter "name" is already initialized.
- Scripts/webkitpy/port/gtk.py:
(GtkPort.init): Set the default wrapper to jhbuild-wrapper.
If another wrapper is specified via the option "-l --wrapper=x",
then prepend the jhbuild-wrapper to the one specified.
- 5:47 AM Changeset in webkit [169613] by
-
- 2 edits in trunk/LayoutTests
[EFL] Change expectations for three layout tests.
https://bugs.webkit.org/show_bug.cgi?id=133538
Unreviewed EFL gardening.
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-06-05
- platform/efl-wk2/TestExpectations:
- 4:30 AM Changeset in webkit [169612] by
-
- 2 edits in trunk/Source/WebKit2
Resolve compiler error (call of overloaded 'schedule' function is ambiguous)
https://bugs.webkit.org/show_bug.cgi?id=133467
Patch by Tanay C <tanay.c@samsung.com> on 2014-06-05
Reviewed by Carlos Garcia Campos.
- Shared/Downloads/soup/DownloadSoup.cpp:
(WebKit::DownloadClient::handleResponseLater): Explicitly casting second parameter to std::function<void()>
- 2:41 AM Changeset in webkit [169611] by
-
- 3 edits2 adds in trunk
[MediaStream] MediaStream.addTrack should not check for tracks ended state.
https://bugs.webkit.org/show_bug.cgi?id=133510
Patch by Kiran <kiran.guduru@samsung.com> on 2014-06-05
Reviewed by Eric Carlson.
Source/WebCore:
Adding and removing of tracks to a MediaStream should not have dependency
on tracks state. So the check for MediaStreamTrack's ended state has been
removed while adding a track in MediaStreamPrivate.cpp.
Test: fast/mediastream/MediaStream-add-ended-tracks.html
- platform/mediastream/MediaStreamPrivate.cpp:
(WebCore::MediaStreamPrivate::addTrack):
LayoutTests:
- fast/mediastream/MediaStream-add-ended-tracks-expected.txt: Added.
- fast/mediastream/MediaStream-add-ended-tracks.html: Added.
- 2:25 AM Changeset in webkit [169610] by
-
- 3 edits1 delete in trunk/Source/WebCore
[GTK] Remove ScrollViewGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=133535
Reviewed by Carlos Garcia Campos.
Because GTK+ WK1 was removed, we don't have to consider special cases
handled in ScrollViewGtk.cpp.
No new tests are necessary because there is no behavior change.
- PlatformGTK.cmake:
- platform/ScrollView.cpp:
(WebCore::ScrollView::setScrollbarModes):
(WebCore::ScrollView::visibleContentRectInternal):
- platform/gtk/ScrollViewGtk.cpp: Removed.
- 2:23 AM Changeset in webkit [169609] by
-
- 3 edits in trunk/LayoutTests
[EFL] Add expectations for two accessibility layout tests.
https://bugs.webkit.org/show_bug.cgi?id=133485
Unreviewed EFL gardening.
Patch by Andrzej Badowski <a.badowski@samsung.com> on 2014-06-05
- platform/efl-wk2/TestExpectations:
- platform/efl-wk2/accessibility/lists-expected.txt:
- 12:31 AM Changeset in webkit [169608] by
-
- 5 edits in trunk/Source
Versioning.
Jun 4, 2014:
- 11:35 PM Changeset in webkit [169607] by
-
- 9 edits9 adds in trunk
MathML operators not stretched horizontally
https://bugs.webkit.org/show_bug.cgi?id=72828
Reviewed by Chris Fleizach.
Source/WebCore:
This patch adds basic horizontal stretching rules for operators inside
an <munder>, <mover> or <munderover> elements. The stretchy operators
in such an element stretch to cover the size of the non-stretchy
operators. This only works when fonts that have an OpenType MATH table
are used.
Tests: mathml/opentype/horizontal-LatinModern.html
mathml/opentype/opentype-stretchy-horizontal.html
mathml/opentype/horizontal-LatinModern-munderover.html
- rendering/mathml/RenderMathMLOperator.cpp:
(WebCore::MathMLOperatorDictionary::ExtractKeyHorizontal): We add an ordered list of operators that have horizontal stretch direction.
(WebCore::RenderMathMLOperator::RenderMathMLOperator): init m_Vertical
(WebCore::RenderMathMLOperator::SetOperatorProperties): set m_Vertical by checking whether the operator is in the horizontalOperators list.
(WebCore::RenderMathMLOperator::stretchTo): We do not stretch vertically
if the operator has horizontal direction.
We also add a new version stretchTo(LayoutUnit width) for horizontal stretching only.
(WebCore::RenderMathMLOperator::computePreferredLogicalWidths): Handle horizontal stretching: the maximumGlyphWidth is the maximum of
the base size or of the stretch size.
(WebCore::RenderMathMLOperator::getDisplayStyleLargeOperator): Add an ASSERT to ensure that this function is only called for vertical stretching.
(WebCore::RenderMathMLOperator::findStretchyData): Add an ASSERT to ensure that this function is not called to get the maximum width of a horizontal stretchy operator.
We take into account m_isVertical when calling getMathVariants or computing sizes.
There is not any Unicode-only construction for horizontal stretching, so a MATH table is required for horizontal stretching.
(WebCore::RenderMathMLOperator::updateStyle): Ignore some code paths specific to vertical stretching and take into account the m_Vertical parameters.
For horizontal stretching, the m_stretch*Baseline parameters are now updated to match the metrics of the size variant or of the maximum of the parts in the glyph assembly.
(WebCore::RenderMathMLOperator::computeLogicalHeight): logicalHeight is now explicitely the sum of m_stretchHeightAboveBaseline and m_stretchDepthBelowBaseline, since it can be different from the stretchSize() in horizontal stretching.
(WebCore::RenderMathMLOperator::paintGlyph): handle trimming for horizontal stretching.
(WebCore::RenderMathMLOperator::fillWithVerticalExtensionGlyph): rename the function and ensure it is only call for m_isVertical.
(WebCore::RenderMathMLOperator::fillWithHorizontalExtensionGlyph): same as fillWithVerticalExtensionGlyph, but for horizontal stretching.
(WebCore::RenderMathMLOperator::paint): For glyph assembly, choose between paintVerticalGlyphAssembly or paintHorizontalGlyphAssembly.
(WebCore::RenderMathMLOperator::paintVerticalGlyphAssembly): rename the function and ensure it is only call for m_isVertical.
(WebCore::RenderMathMLOperator::paintHorizontalGlyphAssembly): same as paintVerticalGlyphAssembly but for horizontal stretching.
- rendering/mathml/RenderMathMLOperator.h: we add a m_isVertical member to indicate the stretch direction and a m_stretchWidth to indicate the width of the stretchy character.
We define the horizontal counterparts of fillWith*ExtensionGlyph, paint*GlyphAssembly, GlyphPaintTrimming StretchyData.
Finally stretchSize() takes into account the stretch direction.
- rendering/mathml/RenderMathMLUnderOver.cpp: We override the layout() function to stretch munderover children horizontally.
(WebCore::RenderMathMLUnderOver::layout):
- rendering/mathml/RenderMathMLUnderOver.h: we declare layout().
LayoutTests:
Add some tests to verify horizontal stretching with the MATH data.
- mathml/opentype/horizontal-LatinModern-munderover.html: Added.
- mathml/opentype/horizontal-LatinModern.html: Added.
- mathml/opentype/opentype-stretchy-horizontal.html: Added.
- platform/efl/TestExpectations: mark tests as failing.
- platform/gtk/mathml/opentype/horizontal-LatinModern-expected.png: Added.
- platform/gtk/mathml/opentype/horizontal-LatinModern-expected.txt: Added.
- platform/gtk/mathml/opentype/horizontal-LatinModern-munderover-expected.png: Added.
- platform/gtk/mathml/opentype/horizontal-LatinModern-munderover-expected.txt: Added.
- platform/gtk/mathml/opentype/opentype-stretchy-horizontal-expected.png: Added.
- platform/gtk/mathml/opentype/opentype-stretchy-horizontal-expected.txt: Added.
- platform/mac/TestExpectations: mark tests as failing.
- platform/win/TestExpectations: ditto.
- 9:52 PM Changeset in webkit [169606] by
-
- 4 edits2 adds in trunk
[CSS Shapes] Image lifetime is not properly handled for gradient shapes
https://bugs.webkit.org/show_bug.cgi?id=133414
Reviewed by Simon Fraser.
Source/WebCore:
Refactor computedShape() and it's helpers to be able to properly
manage the lifetime of the image returned from StyleImage.
This is a port of a Blink patch by Hans Muller.
Test: fast/shapes/shape-outside-floats/shape-outside-uncached-gradient.html
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::createShapeForImage): Properly handle the
lifetime of the image. Changed to use StyleImage::image() to get
the image in all cases there's no need to special case cached
images.
(WebCore::ShapeOutsideInfo::computedShape): Call createShapeForImage.
(WebCore::getShapeImageAndRect): Deleted.
- rendering/shapes/ShapeOutsideInfo.h:
LayoutTests:
- fast/shapes/shape-outside-floats/shape-outside-uncached-gradient-expected.txt: Added.
- fast/shapes/shape-outside-floats/shape-outside-uncached-gradient.html: Added.
- 6:55 PM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 6:05 PM Changeset in webkit [169605] by
-
- 2 edits in trunk/Source/JavaScriptCore
iOS Debug build fix
Rubber-stamped by Filip Pizlo.
- Configurations/LLVMForJSC.xcconfig:
Dead-code strip the llvmForJSC library unconditionally, to work around <rdar://problem/16920916>.
- 5:45 PM Changeset in webkit [169604] by
-
- 3 edits2 adds in trunk
[CSS Shapes] Fix off by one in creating a RasterShape
https://bugs.webkit.org/show_bug.cgi?id=133499
Reviewed by Darin Adler.
Source/WebCore:
Test: fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash.html
- rendering/shapes/RasterShape.cpp:
(WebCore::RasterShapeIntervals::computeShapeMarginIntervals):
marginY1 is supposed to be an inclusive endpoint, however, maxY()
is an exclusive endpoint. This simply changes marginY1 into an
exclusive endpoint.
LayoutTests:
- fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash-expected.txt: Added.
- fast/shapes/shape-outside-floats/shape-outside-floats-shape-margin-crash.html: Added.
- 4:41 PM Changeset in webkit [169603] by
-
- 9 edits in trunk/Source
[iOS][WK2] Restore the visual scroll position instead of the dom scroll position when restoring states from the history
https://bugs.webkit.org/show_bug.cgi?id=133490
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-04
Reviewed by Tim Horton.
Source/WebCore:
Expose the WebKit1 parameter "ScaleIsInitial". It is used for a similar concept in WebKit2 (userHasChangedPageScaleFactor).
Add "exposedContentPosition", which is the scroll position of the exposed rect.
- history/HistoryItem.h:
(WebCore::HistoryItem::exposedContentPosition):
(WebCore::HistoryItem::setExposedContentPosition):
(WebCore::HistoryItem::setScaleIsInitial):
- loader/HistoryController.cpp:
(WebCore::HistoryController::saveScrollPositionAndViewStateToItem):
Source/WebKit2:
Instead of restoring the scroll position, restore the visual position. This makes pages appear at the same position
on screen ignoring changes in the obscured top inset.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
- WebProcess/WebCoreSupport/ios/WebFrameLoaderClientIOS.mm:
(WebKit::WebFrameLoaderClient::saveViewStateToItem):
(WebKit::WebFrameLoaderClient::restoreViewState):
Save and restore userHasChangedPageScaleFactor to handle rescaling correctly.
Limit the scale into valid viewport limits in case the viewport meta tag has changed or the device has rotated.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::userHasChangedPageScaleFactor):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::restorePageState):
(WebKit::WebPage::updateVisibleContentRects):
In updateVisibleContentRects, we keep track or the current difference between the exposed rect and the unobscured rect.
When restoring the page position, we use the current top inset and the saved exposed rect to restore the visual
scroll position.
It is not very robust as it does not resolve races between the two processes, but that is not worse than what we is there now.
- 3:37 PM Changeset in webkit [169602] by
-
- 5 edits in branches/safari-537.77-branch/Source
Fix versioning.
- 3:22 PM Changeset in webkit [169601] by
-
- 19 edits2 adds in trunk/Source
Enable WebGL on Windows.
https://bugs.webkit.org/show_bug.cgi?id=133503
Reviewed by Brent Fulgham.
Source/ThirdParty/ANGLE:
- changes.diff
Recorded additional changes from ANGLE.
- ANGLE.vcxproj/libEGL.vcxproj:
- ANGLE.vcxproj/libEGL.vcxproj.filters:
- ANGLE.vcxproj/libGLESv2.vcxproj:
- ANGLE.vcxproj/libGLESv2.vcxproj.filters:
- include/EGL/egl.h:
- include/EGL/eglsoftlinking.h: Added.
- include/GLES2/gl2.h:
- include/GLES2/gl2softlinking.h: Added.
Resurrected soft linking headers from r153664.
- src/libGLESv2/renderer/VertexBuffer.cpp:
(rx::VertexBufferInterface::directStoragePossible):
Compile fix for Win64.
Source/WebCore:
No new tests, but we should enable the webgl tests soon.
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::markContextChanged):
Check if the context and RenderBox are accelerated to use accelerated code path.
- html/canvas/WebGLRenderingContext.h:
Disable accelerated compositing on WebGL canvases until that works.
- platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs):
Compile fix after r166563.
Source/WebKit:
- WebKit.vcxproj/WebKit.sln:
Build ANGLE projects and add them as a dependency for linking WebKit.dll.
- WebKit.vcxproj/WebKit/WebKitCommon.props:
Link to ANGLE libraries to get EGL, GLESv2, and GLSL translator symbols.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Added 64-bit linker symbol.
Source/WTF:
- wtf/FeatureDefines.h:
Enable WebGL for AppleWin and WinCairo ports.
- 3:19 PM Changeset in webkit [169600] by
-
- 4 edits2 copies in tags/Safari-538.38
Merge r169599. <rdar://problem/17154371>
- 3:08 PM Changeset in webkit [169599] by
-
- 4 edits2 adds in trunk
Regression(r169547): Crash in WebCore::styleForFirstLetter() while loading http://thenextweb.com/apple/2014/02/21/apple-confirms-acquired-testflight-creator-burstly/
https://bugs.webkit.org/show_bug.cgi?id=133500
Reviewed by Antti Koivisto.
Source/WebCore:
Unlike the other tree marking optimization, adding HasPseudoStyle() on an element style
during style resolution must be conservative and not set the flag unless every other filter
matched first.
After r169547, the SelectorChecker was setting flags on HasPseudoStyle() during the pseudo
element matching. If that passed but the remaining filter did not match, the element style
could have the flag "FIRST_LETTER" while not being able to resolve a style for "FIRST_LETTER".
When the layout code was creating the renderer, it would find the FIRST_LETTER flag on the main style
and try to get the specific style for FIRST_LETTER. Since no rule would resolve for FIRST_LETTER,
the style would be null and the code would be crashing when accessing its parameters.
This patch fixes the issue by moving the style marking for pseudo element at the end of the matching.
Test: fast/css/first-letter-on-non-matching-selectors.html
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::match):
(WebCore::SelectorChecker::matchRecursively):
- css/SelectorChecker.h:
(WebCore::SelectorChecker::match): Deleted.
LayoutTests:
- fast/css/first-letter-on-non-matching-selectors-expected.txt: Added.
- fast/css/first-letter-on-non-matching-selectors.html: Added.
- 2:54 PM Changeset in webkit [169598] by
-
- 4 edits3 adds in trunk
ArrayIterator should not be exposed in Safari 8
https://bugs.webkit.org/show_bug.cgi?id=133494
Reviewed by Michael Saboff.
Source/JavaScriptCore:
Separate out types that require constructor objects, and don't
include the iterator types in that list.
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
- runtime/JSGlobalObject.h:
LayoutTests:
Add tests.
- js/no-iterator-constructors.html: Added.
- js/script-tests/no-iterator-constructors.js: Added.
- 2:44 PM Changeset in webkit [169597] by
-
- 2 edits in branches/ftlopt/Source/JavaScriptCore
[ftlopt] Unreviewed, fix 32-bit.
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- 2:40 PM Changeset in webkit [169596] by
-
- 6 edits in trunk/Source/WebCore
[iOS] allow UA to specify network interface
https://bugs.webkit.org/show_bug.cgi?id=133396
Reviewed by Jer Noble.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerInterfaceName): Return settings->networkInterfaceName.
- html/HTMLMediaElement.h:
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::mediaPlayerNetworkInterfaceName): Pass through the media element.
- platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerNetworkInterfaceName):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL): If the media player
wants to use a specific netork interface name, pass it to the AVAsset allocator.
- 2:28 PM Changeset in webkit [169595] by
-
- 2 edits in trunk/Source/JavaScriptCore
DFG::Safepoint::begin() should set m_didCallBegin before releasing the rightToRun lock, because otherwise, Safepoint::checkLivenessAndVisitChildren() may assert due to a race
https://bugs.webkit.org/show_bug.cgi?id=133525
<rdar://problem/16790296>
Reviewed by Oliver Hunt.
- dfg/DFGSafepoint.cpp:
(JSC::DFG::Safepoint::begin):
- 1:46 PM Changeset in webkit [169594] by
-
- 2 edits in trunk/Source/WebCore
Pasting multiple photos on iOS only pastes one photo
<https://bugs.webkit.org/show_bug.cgi?id=133495>
<rdar://problem/16138616>
Reviewed by Alexey Proskuryakov.
- editing/ios/EditorIOS.mm:
(WebCore::Editor::pasteWithPasteboard):
Create a WebContentReader. For each pasteboard item, get the document
fragment for that item, and add it to the reader. If we fail to get
the fragment from the delegate, fall back to using
webContentFromPasteboard() as before.
- 1:42 PM Changeset in webkit [169593] by
-
- 5 edits in trunk/Source/WebCore
Use references instead of pointers for non-optional arguments during text layout
https://bugs.webkit.org/show_bug.cgi?id=133501
Patch by Myles C. Maxfield <litherum@gmail.com> on 2014-06-04
Reviewed by Tim Horton.
This patch applies some cleanup to InlineBox layout functions to take
references instead of pointers where appropriate.
No new tests are necessary because there is no behavior change.
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeLogicalBoxHeights): Make the function take a
reference to the RootInlineBox instead of a pointer. This function does some
rounding.
(WebCore::InlineFlowBox::addTextBoxVisualOverflow): Make the function take a
reference to the InlineTextBox instead of a pointer.
(WebCore::InlineFlowBox::computeOverflow): Update call to addTextBoxVisualOverflow
to pass a reference instead of a pointer.
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection): Update call to
computeLogicalBoxHeights to pass a reference instead of a pointer.
(WebCore::RootInlineBox::ascentAndDescentForBox): Make the function take a
reference to the InlineBox instead of a pointer.
(WebCore::RootInlineBox::includeLeadingForBox): Make the function take a reference
instead of a pointer.
(WebCore::RootInlineBox::includeFontForBox): Ditto.
(WebCore::RootInlineBox::includeGlyphsForBox): Ditto.
(WebCore::RootInlineBox::includeMarginForBox): Ditto.
- rendering/RootInlineBox.h: Move functions that are not externally called into
a private: section. In addition, update function signatures to take references
instead of pointers.
- 1:25 PM Changeset in webkit [169592] by
-
- 9 edits in branches/safari-538.34-branch/Source
Merged r168763.
- 1:22 PM Changeset in webkit [169591] by
-
- 6 edits5 adds in trunk
Lists styled with SVG fonts are not rendered as expected
https://bugs.webkit.org/show_bug.cgi?id=133198
Reviewed by Simon Fraser.
Source/WebCore:
There were a couple places in RenderListMarker and RenderMenuList that were
implicitly creating TextRuns by passing a String to a function which
expected a TextRun. Because TextRun has a constructor which takes a single
String and isn't marked explicit, TextRuns were being created without
any of the associated code that initializes the TextRun (such as creating
a RenderingContext if necessary).
There is currently one more client of this code that needs to be fixed.
This is in RenderThemeIOS::adjustMenuListButtonStyle(). However, fixing
this will be a somewhat large change, and is out of scope for this patch.
I will submit a follow-up patch that fixes this permanently. Once this is
fixed, I can mark TextRun's constructors as explicit.
Test: svg/custom/list-items-with-svg-font-family.html
- platform/graphics/TextRun.h:
(WebCore::TextRun::TextRun): Mark constructors as explicit.
- rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::computePreferredLogicalWidths): Call
RenderBlock::constructTextRun.
(WebCore::RenderListMarker::getRelativeMarkerRect): Ditto.
- rendering/RenderMenuList.cpp:
(RenderMenuList::updateOptionsWidth): Ditto.
- rendering/RenderThemeIOS.mm:
(WebCore::adjustInputElementButtonStyle): Instead of crashing, mark
form controls rendered with SVG fonts as having 0 width. This isn't
perfect, but fixing this is out of scope for this patch.
LayoutTests:
See per-file comments.
- platform/ios-sim/fonts/input-style-with-svg-font-crash.html: Added. Make sure
that iOS input elements don't crash when styled with SVG fonts.
- platform/ios-sim/fonts/resources/graffiti.svg: Added. SVG font for above test.
- svg/custom/list-items-with-svg-font-family-expected.txt: Added.
- svg/custom/list-items-with-svg-font-family.html: Added. Make sure there is
no crash when styling list elements with SVG fonts.
- 12:25 PM Changeset in webkit [169590] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed GTK gardening.
Add the new HiDPI tests to the bug that tracks support for this
feature on GTK.
Mark and report the new tests introduced on r169407 that timeout.
Mark and report the new accesibility test introduced on r169427
that fails.
Move the reported timeout tests to the timeout section of the
TestExpectations file.
Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-06-04
- platform/gtk/TestExpectations:
- 11:57 AM HackingWebInspector edited by
- (diff)
- 11:18 AM Changeset in webkit [169589] by
-
- 4 edits in trunk/Tools
Build ASan WebKit for iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=133489
Reviewed by Darin Adler.
- DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig:
- DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
- Add missing ASan LDFLAGS.
- asan/asan.xcconfig:
- Split compiler-rt linker flags for OS X and iOS Simulator
- 11:03 AM Changeset in webkit [169588] by
-
- 57 edits23 adds in branches/ftlopt
[ftlopt] AI should be able track structure sets larger than 1
https://bugs.webkit.org/show_bug.cgi?id=128073
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
This makes two major changes to how AI (abstract interpreter) proves that a value has
some structure:
- StructureAbstractValue can now track an arbitrary number of structures. A set whose size is greater than one means that the value may have any of the structures, and we don't know which - but we do know that it cannot be any structure not in the set. The structure abstract value can still be TOP, which means the set of all structures. We artificially limit the set size to StructureAbstractValue::polymorphismLimit to guard memory explosion on pathological programs. This limit is big enough that it wouldn't kick in for normal code, since we have other heuristics that limit the number of structures that we would allow an inline cache to know about.
- We eagerly set watchpoints on all watchable structures and then we assume that watchable structures are being watched, and that the watchpoint will jettison the code. This allows tracking of watchable structures to be far simpler than before. Previously, a structure being tracked as "future possible" was predicated on it being watchable but we might not actually watch it. This makes algebra over sets of future possible structures quite weird. But watching all watchable structures means that we simple say that a structure set can be in the following states: unclobbered, which means it's just a set of structures and it doesn't matter what is watchable or what isn't because we've proven that the value must have one of these structures right now; and clobbered, which means that we have a set of structures, plus all possible structures temporarily, with invalidation removing the "plus all possible structures". Clobbering a set means that if any of its structures are unwatchable, the set just becomes TOP; but if all structures in the set are watchable then we just set the clobbered bit to add the "plus all possible structures temporarily" thing. This precisely tracks the exact meaning of watchability and invalidation points.
Slight SunSpider slow-down, neutral on Octane, slight AsmBench speed-up. I believe that
we will ultimately undo the SunSpider slow-down by making further improvements to the set
representation. I believe that Octane perfromance will ultimately improve once we remove
remaining singleton special-cases. The ultimate goal of this is to remove the need to
try quite so desperately hard to make everything monomorphic as we do currently.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/StructureSet.cpp:
(JSC::StructureSet::clear):
(JSC::StructureSet::remove):
(JSC::StructureSet::filter):
(JSC::StructureSet::copyFromOutOfLine):
(JSC::StructureSet::StructureSet): Deleted.
(JSC::StructureSet::operator=): Deleted.
(JSC::StructureSet::copyFrom): Deleted.
- bytecode/StructureSet.h:
(JSC::StructureSet::StructureSet):
(JSC::StructureSet::operator=):
(JSC::StructureSet::isEmpty):
(JSC::StructureSet::genericFilter):
(JSC::StructureSet::ContainsOutOfLine::ContainsOutOfLine):
(JSC::StructureSet::ContainsOutOfLine::operator()):
(JSC::StructureSet::copyFrom):
(JSC::StructureSet::deleteStructureListIfNecessary):
(JSC::StructureSet::setEmpty):
(JSC::StructureSet::getReservedFlag):
(JSC::StructureSet::setReservedFlag):
- dfg/DFGAbstractInterpreter.h:
(JSC::DFG::AbstractInterpreter::setBuiltInConstant):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::booleanResult):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::verifyEdge):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::clobberCapturedVars):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::forAllValues):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::clobberStructures):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::observeTransition):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::observeTransitions):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::setDidClobber):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::dump):
- dfg/DFGAbstractValue.cpp:
(JSC::DFG::AbstractValue::observeTransitions):
(JSC::DFG::AbstractValue::setMostSpecific):
(JSC::DFG::AbstractValue::set):
(JSC::DFG::AbstractValue::filter):
(JSC::DFG::AbstractValue::shouldBeClear):
(JSC::DFG::AbstractValue::normalizeClarity):
(JSC::DFG::AbstractValue::checkConsistency):
(JSC::DFG::AbstractValue::assertIsWatched):
(JSC::DFG::AbstractValue::dumpInContext):
(JSC::DFG::AbstractValue::setFuturePossibleStructure): Deleted.
- dfg/DFGAbstractValue.h:
(JSC::DFG::AbstractValue::clear):
(JSC::DFG::AbstractValue::clobberStructures):
(JSC::DFG::AbstractValue::clobberStructuresFor):
(JSC::DFG::AbstractValue::observeInvalidationPoint):
(JSC::DFG::AbstractValue::observeInvalidationPointFor):
(JSC::DFG::AbstractValue::observeTransition):
(JSC::DFG::AbstractValue::TransitionObserver::TransitionObserver):
(JSC::DFG::AbstractValue::TransitionObserver::operator()):
(JSC::DFG::AbstractValue::TransitionsObserver::TransitionsObserver):
(JSC::DFG::AbstractValue::TransitionsObserver::operator()):
(JSC::DFG::AbstractValue::isHeapTop):
(JSC::DFG::AbstractValue::setType):
(JSC::DFG::AbstractValue::operator==):
(JSC::DFG::AbstractValue::merge):
(JSC::DFG::AbstractValue::validate):
(JSC::DFG::AbstractValue::hasClobberableState):
(JSC::DFG::AbstractValue::assertIsWatched):
(JSC::DFG::AbstractValue::observeIndexingTypeTransition):
(JSC::DFG::AbstractValue::makeTop):
(JSC::DFG::AbstractValue::bestProvenStructure): Deleted.
- dfg/DFGAllocator.h:
- dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::alreadyChecked):
- dfg/DFGAtTailAbstractState.h:
(JSC::DFG::AtTailAbstractState::structureClobberState):
(JSC::DFG::AtTailAbstractState::setStructureClobberState):
(JSC::DFG::AtTailAbstractState::setFoundConstants):
(JSC::DFG::AtTailAbstractState::haveStructures): Deleted.
(JSC::DFG::AtTailAbstractState::setHaveStructures): Deleted.
- dfg/DFGBasicBlock.cpp:
(JSC::DFG::BasicBlock::BasicBlock):
- dfg/DFGBasicBlock.h:
- dfg/DFGBranchDirection.h:
(JSC::DFG::branchDirectionToString):
(WTF::printInternal):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handlePutById):
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::performBlockCFA):
- dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::checkStructureElimination):
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination):
(JSC::DFG::CSEPhase::performNodeCSE):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGCommon.cpp:
(JSC::DFG::startCrashing):
(JSC::DFG::isCrashing):
- dfg/DFGCommon.h:
- dfg/DFGCommonData.cpp:
(JSC::DFG::CommonData::notifyCompilingStructureTransition):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
(JSC::DFG::ConstantFoldingPhase::emitGetByOffset):
(JSC::DFG::ConstantFoldingPhase::emitPutByOffset):
(JSC::DFG::ConstantFoldingPhase::addStructureTransitionCheck):
- dfg/DFGDesiredWatchpoints.cpp:
(JSC::DFG::DesiredWatchpoints::consider):
(JSC::DFG::DesiredWatchpoints::addLazily): Deleted.
- dfg/DFGDesiredWatchpoints.h:
(JSC::DFG::GenericDesiredWatchpoints::reallyAdd):
(JSC::DFG::GenericDesiredWatchpoints::areStillValid):
(JSC::DFG::GenericDesiredWatchpoints::isWatched):
(JSC::DFG::DesiredWatchpoints::isWatched):
(JSC::DFG::WatchpointForGenericWatchpointSet::WatchpointForGenericWatchpointSet): Deleted.
(JSC::DFG::GenericDesiredWatchpoints::addLazily): Deleted.
(JSC::DFG::GenericDesiredWatchpoints::isStillValid): Deleted.
(JSC::DFG::GenericDesiredWatchpoints::shouldAssumeMixedState): Deleted.
(JSC::DFG::GenericDesiredWatchpoints::isValidOrMixed): Deleted.
(JSC::DFG::DesiredWatchpoints::isStillValid): Deleted.
(JSC::DFG::DesiredWatchpoints::shouldAssumeMixedState): Deleted.
(JSC::DFG::DesiredWatchpoints::isValidOrMixed): Deleted.
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::canOptimizeStringObjectAccess):
(JSC::DFG::FixupPhase::injectTypeConversionsForEdge):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::~Graph):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dumpBlockHeader):
(JSC::DFG::Graph::tryGetFoldableView):
(JSC::DFG::Graph::visitChildren):
(JSC::DFG::Graph::assertIsWatched):
(JSC::DFG::Graph::handleAssertionFailure):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::convertToConstant):
(JSC::DFG::Graph::masqueradesAsUndefinedWatchpointIsStillValid):
(JSC::DFG::Graph::addStructureTransitionData): Deleted.
- dfg/DFGInPlaceAbstractState.cpp:
(JSC::DFG::InPlaceAbstractState::beginBasicBlock):
(JSC::DFG::InPlaceAbstractState::initialize):
(JSC::DFG::InPlaceAbstractState::endBasicBlock):
(JSC::DFG::InPlaceAbstractState::reset):
(JSC::DFG::InPlaceAbstractState::merge):
- dfg/DFGInPlaceAbstractState.h:
(JSC::DFG::InPlaceAbstractState::structureClobberState):
(JSC::DFG::InPlaceAbstractState::setStructureClobberState):
(JSC::DFG::InPlaceAbstractState::setFoundConstants):
(JSC::DFG::InPlaceAbstractState::haveStructures): Deleted.
(JSC::DFG::InPlaceAbstractState::setHaveStructures): Deleted.
- dfg/DFGLivenessAnalysisPhase.cpp:
(JSC::DFG::LivenessAnalysisPhase::run):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasTransition):
(JSC::DFG::Node::transition):
(JSC::DFG::Node::hasStructure):
(JSC::DFG::StructureTransitionData::StructureTransitionData): Deleted.
(JSC::DFG::Node::convertToStructureTransitionWatchpoint): Deleted.
(JSC::DFG::Node::hasStructureTransitionData): Deleted.
(JSC::DFG::Node::structureTransitionData): Deleted.
- dfg/DFGNodeType.h:
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::speculateStringObjectForStructure):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStructureAbstractValue.cpp: Added.
(JSC::DFG::StructureAbstractValue::assertIsWatched):
(JSC::DFG::StructureAbstractValue::clobber):
(JSC::DFG::StructureAbstractValue::observeTransition):
(JSC::DFG::StructureAbstractValue::observeTransitions):
(JSC::DFG::StructureAbstractValue::add):
(JSC::DFG::StructureAbstractValue::merge):
(JSC::DFG::StructureAbstractValue::mergeSlow):
(JSC::DFG::StructureAbstractValue::mergeNotTop):
(JSC::DFG::StructureAbstractValue::filter):
(JSC::DFG::StructureAbstractValue::filterSlow):
(JSC::DFG::StructureAbstractValue::contains):
(JSC::DFG::StructureAbstractValue::isSubsetOf):
(JSC::DFG::StructureAbstractValue::isSupersetOf):
(JSC::DFG::StructureAbstractValue::overlaps):
(JSC::DFG::StructureAbstractValue::equalsSlow):
(JSC::DFG::StructureAbstractValue::dumpInContext):
(JSC::DFG::StructureAbstractValue::dump):
- dfg/DFGStructureAbstractValue.h:
(JSC::DFG::StructureAbstractValue::StructureAbstractValue):
(JSC::DFG::StructureAbstractValue::operator=):
(JSC::DFG::StructureAbstractValue::clear):
(JSC::DFG::StructureAbstractValue::makeTop):
(JSC::DFG::StructureAbstractValue::assertIsWatched):
(JSC::DFG::StructureAbstractValue::observeInvalidationPoint):
(JSC::DFG::StructureAbstractValue::top):
(JSC::DFG::StructureAbstractValue::isClear):
(JSC::DFG::StructureAbstractValue::isTop):
(JSC::DFG::StructureAbstractValue::isNeitherClearNorTop):
(JSC::DFG::StructureAbstractValue::isClobbered):
(JSC::DFG::StructureAbstractValue::merge):
(JSC::DFG::StructureAbstractValue::filter):
(JSC::DFG::StructureAbstractValue::operator==):
(JSC::DFG::StructureAbstractValue::size):
(JSC::DFG::StructureAbstractValue::at):
(JSC::DFG::StructureAbstractValue::operator[]):
(JSC::DFG::StructureAbstractValue::onlyStructure):
(JSC::DFG::StructureAbstractValue::isSupersetOf):
(JSC::DFG::StructureAbstractValue::makeTopWhenThin):
(JSC::DFG::StructureAbstractValue::setClobbered):
(JSC::DFG::StructureAbstractValue::add): Deleted.
(JSC::DFG::StructureAbstractValue::addAll): Deleted.
(JSC::DFG::StructureAbstractValue::contains): Deleted.
(JSC::DFG::StructureAbstractValue::isSubsetOf): Deleted.
(JSC::DFG::StructureAbstractValue::doesNotContainAnyOtherThan): Deleted.
(JSC::DFG::StructureAbstractValue::isClearOrTop): Deleted.
(JSC::DFG::StructureAbstractValue::last): Deleted.
(JSC::DFG::StructureAbstractValue::speculationFromStructures): Deleted.
(JSC::DFG::StructureAbstractValue::isValidOffset): Deleted.
(JSC::DFG::StructureAbstractValue::hasSingleton): Deleted.
(JSC::DFG::StructureAbstractValue::singleton): Deleted.
(JSC::DFG::StructureAbstractValue::dumpInContext): Deleted.
(JSC::DFG::StructureAbstractValue::dump): Deleted.
(JSC::DFG::StructureAbstractValue::topValue): Deleted.
- dfg/DFGStructureClobberState.h: Added.
(JSC::DFG::merge):
(WTF::printInternal):
- dfg/DFGTransition.cpp: Added.
(JSC::DFG::Transition::dumpInContext):
(JSC::DFG::Transition::dump):
- dfg/DFGTransition.h: Added.
(JSC::DFG::Transition::Transition):
- dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantStructureChecks):
(JSC::DFG::TypeCheckHoistingPhase::identifyRedundantArrayChecks):
- dfg/DFGWatchableStructureWatchingPhase.cpp: Added.
(JSC::DFG::WatchableStructureWatchingPhase::WatchableStructureWatchingPhase):
(JSC::DFG::WatchableStructureWatchingPhase::run):
(JSC::DFG::WatchableStructureWatchingPhase::tryWatch):
(JSC::DFG::performWatchableStructureWatching):
- dfg/DFGWatchableStructureWatchingPhase.h: Added.
- dfg/DFGWatchpointCollectionPhase.cpp:
(JSC::DFG::WatchpointCollectionPhase::handle):
(JSC::DFG::WatchpointCollectionPhase::handleEdge): Deleted.
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLIntrinsicRepository.h:
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::ftlUnreachable):
(JSC::FTL::LowerDFGToLLVM::createPhiVariables):
(JSC::FTL::LowerDFGToLLVM::compileBlock):
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileUpsilon):
(JSC::FTL::LowerDFGToLLVM::compilePhi):
(JSC::FTL::LowerDFGToLLVM::compileDoubleRep):
(JSC::FTL::LowerDFGToLLVM::compileValueRep):
(JSC::FTL::LowerDFGToLLVM::compileValueToInt32):
(JSC::FTL::LowerDFGToLLVM::compileGetArgument):
(JSC::FTL::LowerDFGToLLVM::compileGetLocal):
(JSC::FTL::LowerDFGToLLVM::compileSetLocal):
(JSC::FTL::LowerDFGToLLVM::compileArithAddOrSub):
(JSC::FTL::LowerDFGToLLVM::compileArithMul):
(JSC::FTL::LowerDFGToLLVM::compileArithDiv):
(JSC::FTL::LowerDFGToLLVM::compileArithMod):
(JSC::FTL::LowerDFGToLLVM::compileArithMinOrMax):
(JSC::FTL::LowerDFGToLLVM::compileArithAbs):
(JSC::FTL::LowerDFGToLLVM::compileArithNegate):
(JSC::FTL::LowerDFGToLLVM::compileArrayifyToStructure):
(JSC::FTL::LowerDFGToLLVM::compilePutStructure):
(JSC::FTL::LowerDFGToLLVM::compileGetById):
(JSC::FTL::LowerDFGToLLVM::compileGetMyArgumentsLength):
(JSC::FTL::LowerDFGToLLVM::compileGetMyArgumentByVal):
(JSC::FTL::LowerDFGToLLVM::compileGetArrayLength):
(JSC::FTL::LowerDFGToLLVM::compileGetByVal):
(JSC::FTL::LowerDFGToLLVM::compilePutByVal):
(JSC::FTL::LowerDFGToLLVM::compileArrayPush):
(JSC::FTL::LowerDFGToLLVM::compileArrayPop):
(JSC::FTL::LowerDFGToLLVM::compileNewArray):
(JSC::FTL::LowerDFGToLLVM::compileNewArrayBuffer):
(JSC::FTL::LowerDFGToLLVM::compileAllocatePropertyStorage):
(JSC::FTL::LowerDFGToLLVM::compileReallocatePropertyStorage):
(JSC::FTL::LowerDFGToLLVM::compileToString):
(JSC::FTL::LowerDFGToLLVM::compileMakeRope):
(JSC::FTL::LowerDFGToLLVM::compileMultiGetByOffset):
(JSC::FTL::LowerDFGToLLVM::compileMultiPutByOffset):
(JSC::FTL::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::LowerDFGToLLVM::compileCompareStrictEq):
(JSC::FTL::LowerDFGToLLVM::compileSwitch):
(JSC::FTL::LowerDFGToLLVM::compare):
(JSC::FTL::LowerDFGToLLVM::boolify):
(JSC::FTL::LowerDFGToLLVM::terminate):
(JSC::FTL::LowerDFGToLLVM::lowInt32):
(JSC::FTL::LowerDFGToLLVM::lowInt52):
(JSC::FTL::LowerDFGToLLVM::opposite):
(JSC::FTL::LowerDFGToLLVM::lowCell):
(JSC::FTL::LowerDFGToLLVM::lowBoolean):
(JSC::FTL::LowerDFGToLLVM::lowDouble):
(JSC::FTL::LowerDFGToLLVM::lowJSValue):
(JSC::FTL::LowerDFGToLLVM::speculate):
(JSC::FTL::LowerDFGToLLVM::isArrayType):
(JSC::FTL::LowerDFGToLLVM::speculateStringObjectForStructureID):
(JSC::FTL::LowerDFGToLLVM::callCheck):
(JSC::FTL::LowerDFGToLLVM::buildExitArguments):
(JSC::FTL::LowerDFGToLLVM::addExitArgumentForNode):
(JSC::FTL::LowerDFGToLLVM::setInt52):
(JSC::FTL::LowerDFGToLLVM::crash):
(JSC::FTL::LowerDFGToLLVM::compileStructureTransitionWatchpoint): Deleted.
- ftl/FTLOutput.cpp:
(JSC::FTL::Output::crashNonTerminal): Deleted.
- ftl/FTLOutput.h:
(JSC::FTL::Output::crash): Deleted.
- jit/JITOperations.h:
- jsc.cpp:
(WTF::jscExit):
(functionQuit):
(main):
(printUsageStatement):
(CommandLine::parseArguments):
- runtime/Structure.h:
(JSC::Structure::dfgShouldWatchIfPossible):
(JSC::Structure::dfgShouldWatch):
- tests/stress/arrayify-to-structure-contradiction.js: Added.
(foo):
- tests/stress/ftl-getmyargumentslength-inline.js: Added.
(foo):
- tests/stress/multi-put-by-offset-multiple-transitions.js: Added.
(foo):
(Foo):
- tests/stress/throw-from-ftl-in-loop.js: Added.
- tests/stress/throw-from-ftl.js: Added.
(foo):
Source/WTF:
- wtf/Bag.h:
(WTF::Bag::Node::Node):
(WTF::Bag::add):
LayoutTests:
- js/regress/get-by-id-bimorphic-check-structure-elimination-expected.txt: Added.
- js/regress/get-by-id-bimorphic-check-structure-elimination-simple-expected.txt: Added.
- js/regress/get-by-id-bimorphic-check-structure-elimination-simple.html: Added.
- js/regress/get-by-id-bimorphic-check-structure-elimination.html: Added.
- js/regress/get-by-id-check-structure-elimination-expected.txt: Added.
- js/regress/get-by-id-check-structure-elimination.html: Added.
- js/regress/get-by-id-quadmorphic-check-structure-elimination-simple-expected.txt: Added.
- js/regress/get-by-id-quadmorphic-check-structure-elimination-simple.html: Added.
- js/regress/script-tests/get-by-id-bimorphic-check-structure-elimination-simple.js: Added.
- js/regress/script-tests/get-by-id-bimorphic-check-structure-elimination.js: Added.
- js/regress/script-tests/get-by-id-check-structure-elimination.js: Added.
- js/regress/script-tests/get-by-id-quadmorphic-check-structure-elimination-simple.js: Added.
- 10:10 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 9:24 AM Changeset in webkit [169587] by
-
- 2 edits in trunk/Source/WebCore
WebKit should adopt journal_mode=wal for all SQLite databases.
<https://webkit.org/b/133496>
<rdar://problem/15600186>
We already had code to enable write-ahead logging, but it didn't work
since calling SQLiteStatement::step() without first calling prepare()
is a no-op.
Converted it to use into a simple executeCommand() instead.
Reviewed by Brady Eidson.
- platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::open):
- 5:41 AM Changeset in webkit [169586] by
-
- 3 edits2 adds in trunk
REGRESSION: [CSS Regions] Regions with overflow:auto generate scrollbars even if the content flows into the following regions and as such, should not be scrolled
https://bugs.webkit.org/show_bug.cgi?id=133481
Reviewed by Antti Koivisto.
Source/WebCore:
When enlarging the layout overflow of a scrollable region, the portion of the content that flows
in the region must be taken into consideration. If the content continues to flow into the next
region, the layout overflow of the current region must not be enlarged.
Test: fast/regions/scrollable-first-region.html
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::addRegionsOverflowFromChild):
LayoutTests:
Added test for a large item flowed through two regions with the first region having overflow:auto.
The region must NOT scroll.
- fast/regions/scrollable-first-region-expected.html: Added.
- fast/regions/scrollable-first-region.html: Added.
- 12:25 AM Changeset in webkit [169585] by
-
- 7 edits in trunk
Fix some corner cases of :hover and :active in quirks mode
https://bugs.webkit.org/show_bug.cgi?id=133493
Reviewed by Andreas Kling.
Source/WebCore:
Previously, the quirks mode of :hover and :active were evaluated from the SelectorFragment
in fragmentOnlyMatchesLinksInQuirksMode(). There were two problems with that approach:
1) The FragmentGenerator optimizes out some filter when they always match or can never match.
Those fragment should still qualify :hover and :active, but they were lost
for fragmentOnlyMatchesLinksInQuirksMode().
2) Explicitely listing every attribute of SelectorFragment in fragmentOnlyMatchesLinksInQuirksMode()
was extremly fragile. When :not() and :-webkit-any() were added, we forgot to update the quirks
exceptions.
This patch moves the quirks mode exception code from the code generator to the Fragment generator.
The useless filters are no longer ignored for the quirks, and we don't need to update the quirks mode detection
with every change of SelectorFragment.
It is inefficient and ugly, but that is how that quirks is defined. It is only a problem for compilation,
execution time remains unchanged.
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorFragment::SelectorFragment):
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::SelectorCodeGenerator::SelectorCodeGenerator):
(WebCore::SelectorCompiler::pseudoClassOnlyMatchesLinksInQuirksMode):
(WebCore::SelectorCompiler::constructFragments):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateSpecialFailureInQuirksModeForActiveAndHoverIfNeeded):
(WebCore::SelectorCompiler::fragmentOnlyMatchesLinksInQuirksMode): Deleted.
LayoutTests:
Add test case for the corner cases.
- fast/selectors/active-hover-quirks-expected.txt:
- fast/selectors/active-quirks-expected.txt:
- fast/selectors/hover-quirks-expected.txt:
- fast/selectors/resources/hover-active-quirks-utility.js:
Jun 3, 2014:
- 9:47 PM Changeset in webkit [169584] by
-
- 28 edits1 add5 deletes in branches/ftlopt/Source/JavaScriptCore
[ftlopt] Unreviewed, roll out r169578. The build system needs some more love.
- InlineRuntimeSymbolTable.h: Removed.
- JavaScriptCore.xcodeproj/project.pbxproj:
- build-symbol-table-index.py:
- build-symbol-table-index.sh:
- copy-llvm-ir-to-derived-sources.sh:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
- dfg/DFGNode.h:
(JSC::DFG::Node::canBeKnownFunction): Deleted.
(JSC::DFG::Node::hasKnownFunction): Deleted.
(JSC::DFG::Node::knownFunction): Deleted.
(JSC::DFG::Node::giveKnownFunction): Deleted.
- ftl/FTLAbbreviatedTypes.h:
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::LowerDFGToLLVM):
(JSC::FTL::LowerDFGToLLVM::lower):
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
(JSC::FTL::LowerDFGToLLVM::possiblyCompileInlineableNativeCall): Deleted.
(JSC::FTL::LowerDFGToLLVM::getFunctionBySymbol): Deleted.
(JSC::FTL::LowerDFGToLLVM::getModuleByPathForSymbol): Deleted.
(JSC::FTL::LowerDFGToLLVM::isInlinableSize): Deleted.
- ftl/FTLState.cpp:
(JSC::FTL::State::State):
- ftl/FTLState.h:
- heap/HandleStack.h:
- llvm/InitializeLLVM.h:
- llvm/InitializeLLVMMac.cpp: Removed.
- llvm/InitializeLLVMMac.mm: Added.
(JSC::initializeLLVMImpl):
- llvm/LLVMAPIFunctions.h:
- llvm/LLVMHeaders.h:
- runtime/BundlePath.h: Removed.
- runtime/BundlePath.mm: Removed.
- runtime/DateConversion.h:
- runtime/DateInstance.h:
- runtime/ExceptionHelpers.h:
- runtime/JSArray.h:
- runtime/JSCJSValue.h:
(JSC::JSValue::toFloat):
- runtime/JSDateMath.h:
- runtime/JSObject.h:
- runtime/JSWrapperObject.h:
- runtime/Options.h:
- runtime/RegExp.h:
- runtime/StringObject.h:
- runtime/Structure.h:
- tested-symbols.symlst: Removed.
- 9:34 PM Changeset in webkit [169583] by
-
- 1 copy in tags/Safari-538.38
Tagging Safari-538.38
- 9:28 PM Changeset in webkit [169582] by
-
- 7 edits2 moves2 adds7 deletes in branches/ftlopt
[ftlopt] FTL native inlining tests take far too long
https://bugs.webkit.org/show_bug.cgi?id=133498
Unreviewed test gardening.
Source/JavaScriptCore:
Added a new exceptions test since the other one appears to not work.
- tests/stress/ftl-library-exception.js:
- tests/stress/ftl-library-inline-gettimezoneoffset.js: Added.
(foo):
- tests/stress/ftl-library-inlining-exceptions-dataview.js: Added.
(foo):
- tests/stress/ftl-library-inlining-exceptions.js: Copied from LayoutTests/js/regress/script-tests/ftl-library-inlining-exceptions.js.
- tests/stress/ftl-library-inlining-loops.js: Copied from LayoutTests/js/regress/script-tests/ftl-library-inlining-loops.js.
- tests/stress/ftl-library-inlining-random.js:
- tests/stress/ftl-library-substring.js:
LayoutTests:
Move long-running tests that focus on correctness into JSC/tests/stress.
Speed up the performance tests by reducing allocation and call overhead.
- js/regress/ftl-library-inlining-exceptions-expected.txt: Removed.
- js/regress/ftl-library-inlining-exceptions.html: Removed.
- js/regress/ftl-library-inlining-folding-expected.txt: Removed.
- js/regress/ftl-library-inlining-folding.html: Removed.
- js/regress/ftl-library-inlining-loops-expected.txt: Removed.
- js/regress/ftl-library-inlining-loops.html: Removed.
- js/regress/script-tests/ftl-library-inlining-dataview.js:
(foo): Deleted.
- js/regress/script-tests/ftl-library-inlining-exceptions.js: Removed.
- js/regress/script-tests/ftl-library-inlining-folding.js: Removed.
- js/regress/script-tests/ftl-library-inlining-loops.js: Removed.
- js/regress/script-tests/ftl-library-inlining.js:
(foo): Deleted.
- 9:22 PM Changeset in webkit [169581] by
-
- 5 edits in branches/safari-537.77-branch/Source
Version bump.
- 9:12 PM Changeset in webkit [169580] by
-
- 1 copy in tags/Safari-537.77.4
Tagging
- 8:33 PM Changeset in webkit [169579] by
-
- 11 edits in trunk
Need to check invalid scheme in navigator content utils
https://bugs.webkit.org/show_bug.cgi?id=133296
Reviewed by Darin Adler.
Source/WebCore:
- Modules/navigatorcontentutils/NavigatorContentUtils.cpp:
(WebCore::verifyProtocolHandlerScheme): Just fix a wrong typo.
LayoutTests:
Add tests that check that schemes with colons in their names are rejected.
Spec: http://www.whatwg.org/specs/web-apps/current-work/#custom-handlers
- fast/dom/NavigatorContentUtils/is-protocol-handler-registered-expected.txt:
- fast/dom/NavigatorContentUtils/is-protocol-handler-registered.html:
- fast/dom/NavigatorContentUtils/register-protocol-handler-expected.txt:
- fast/dom/NavigatorContentUtils/register-protocol-handler.html:
- fast/dom/NavigatorContentUtils/unregister-protocol-handler-expected.txt:
- fast/dom/NavigatorContentUtils/unregister-protocol-handler.html:
- platform/efl/fast/dom/NavigatorContentUtils/register-protocol-handler-expected.txt:
- platform/efl/fast/dom/NavigatorContentUtils/unregister-protocol-handler-expected.txt:
- 7:50 PM Changeset in webkit [169578] by
-
- 29 edits23 adds1 delete in branches/ftlopt
[ftlopt] Added system for inlining native functions via the FTL.
https://bugs.webkit.org/show_bug.cgi?id=131515
Patch by Matthew Mirman <mmirman@apple.com> on 2014-06-03
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
Also fixed the build to not compress the bitcode and to
include all of the relevant runtime. With GCC_GENERATE_DEBUGGING_SYMBOLS = NO,
the produced bitcode files are a 100th the size they were before.
Now we can include all of the relevant runtime files with only a 3mb overhead.
This is the same overhead as for two compressed files before,
but done more efficiently (on both ends) and with less code.
Deciding whether to inline native functions is left up to LLVM.
The entire module containing the function is linked into the current
compiled JS so that inlining the native functions shouldn't make them smaller.
Rather than loading Runtime.symtbl at runtime FTLState.cpp now includes a file
InlineRuntimeSymbolTable.h which statically builds the symbol table hash table.
Currently build-symbol-table-index.py updates this file from the
contents of tested-symbols.symlst when done building as a matter of convenience.
However, in order to include the new contents of the file in the build
you'd need to build twice. This will be fixed in future versions.
- JavaScriptCore.xcodeproj/project.pbxproj: Added back runtime files to compile.
- build-symbol-table-index.py: Changed bitcode suffix.
Added inclusion of only tested symbols.
Added output to InlineRuntimeSymbolTable.h.
- build-symbol-table-index.sh: Changed bitcode suffix.
- copy-llvm-ir-to-derived-sources.sh: Removed gzip compression.
- tested-symbols.symlst: Added.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
Now sets the knownFunction of the call node if such a function exists
and emits a check that during runtime the callee is in fact known.
- dfg/DFGNode.h:
Added functions to set the known function of a call node.
(JSC::DFG::Node::canBeKnownFunction): Added.
(JSC::DFG::Node::hasKnownFunction): Added.
(JSC::DFG::Node::knownFunction): Added.
(JSC::DFG::Node::giveKnownFunction): Added.
- ftl/FTLAbbreviatedTypes.h: Added a typedef for LLVMMemoryBufferRef
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::isInlinableSize): Added. Hardcoded threshold to 275.
(JSC::FTL::LowerDFGToLLVM::getModuleByPathForSymbol): Added.
(JSC::FTL::LowerDFGToLLVM::getFunctionBySymbol): Added.
(JSC::FTL::LowerDFGToLLVM::possiblyCompileInlineableNativeCall): Added.
(JSC::FTL::LowerDFGToLLVM::compileCallOrConstruct):
Added call to possiblyCompileInlineableNativeCall
- ftl/FTLOutput.h:
(JSC::FTL::Output::allocaName): Added. Useful for debugging.
- ftl/FTLState.cpp:
(JSC::FTL::State::State): Added an include for InlineRuntimeSymbolTable.h
- ftl/FTLState.h: Added symbol table hash table.
- ftl/FTLCompile.cpp:
(JSC::FTL::compile): Added inlining and dead function elimination passes.
- heap/HandleStack.h: Added JS_EXPORT_PRIVATE to a few functions to get inlining to compile.
- InlineRuntimeSymbolTable.h: Added.
- llvm/InitializeLLVMMac.mm: Deleted.
- llvm/InitializeLLVMMac.cpp: Added.
- llvm/LLVMAPIFunctions.h: Added macros to include Bitcode parsing and linking functions.
- llvm/LLVMHeaders.h: Added includes for Bitcode parsing and linking.
- runtime/BundlePath.h: Added.
- runtime/BundlePath.mm: Added.
- runtime/DateInstance.h: Added JS_EXPORT_PRIVATE to a few functions to get inlining to compile.
- runtime/DateInstance.h: ditto.
- runtime/DateConversion.h: ditto.
- runtime/ExceptionHelpers.h: ditto.
- runtime/JSCJSValue.h: ditto.
- runtime/JSArray.h: ditto.
- runtime/JSDateMath.h: ditto.
- runtime/JSObject.h: ditto.
- runtime/JSObject.h: ditto.
- runtime/RegExp.h: ditto.
- runtime/Structure.h: ditto.
- runtime/Options.h: Added maximumLLVMInstructionCountForNativeInlining.
- tests/stress/ftl-library-inlining-random.js: Added.
- tests/stress/ftl-library-substring.js: Added.
LayoutTests:
Adds microbenchmarks.
- js/regress/script-tests/ftl-library-inlining.js: Added.
- js/regress/ftl-library-inlining-expected.txt: Added.
- js/regress/ftl-library-inlining.html: Added.
- js/regress/script-tests/ftl-library-inlining-dataview.js: Added.
- js/regress/ftl-library-inlining-dataview-expected.txt: Added.
- js/regress/ftl-library-inlining-dataview.html: Added.
- js/regress/script-tests/ftl-library-inlining-exceptions.js: Added.
- js/regress/ftl-library-inlining-exceptions-expected.txt: Added.
- js/regress/ftl-library-inlining-exceptions.html: Added.
- js/regress/script-tests/ftl-library-inlining-folding.js: Added.
- js/regress/ftl-library-inlining-folding-expected.txt: Added.
- js/regress/ftl-library-inlining-folding-expected.html: Added.
- js/regress/script-tests/ftl-library-inlining-loops.js: Added.
- js/regress/ftl-library-inlining-loops-expected.txt: Added.
- js/regress/ftl-library-inlining-loops.html: Added.
- 7:08 PM Changeset in webkit [169577] by
-
- 5 edits in branches/safari-537.77-branch/Source
Bump version to 537.77.4
- 6:27 PM Changeset in webkit [169576] by
-
- 5 edits in trunk/Source
WebKit2 View Gestures (Zoom): Can show unpainted regions when zoom-pinching-out
https://bugs.webkit.org/show_bug.cgi?id=133472
<rdar://problem/15686848>
Reviewed by Simon Fraser.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):
(WebKit::TiledCoreAnimationDrawingArea::applyTransientZoomToLayers):
(WebKit::TiledCoreAnimationDrawingArea::adjustTransientZoom):
Use prepopulateRect() when zooming out to ensure that we have tiles for the current exposed area.
Factor applyTransientZoomToLayers out of adjustTransientZoom, so that
flushLayers can call applyTransientZoomToLayers without ending up calling prepopulateRect()
during layer flushing, which causes trouble.
It is OK to populate layers at the current scale even when zooming out, because the overdraw
already covers most of the zoomed out area, and we're only adding a few more tiles at worst.
- WebCore.exp.in:
- 4:01 PM Changeset in webkit [169575] by
-
- 9 edits in branches/safari-537.77-branch/Source/WebCore
Back out r169227
- 3:50 PM Changeset in webkit [169574] by
-
- 2 edits in trunk/Tools
Add myself (yoav@yoav.ws) to contributors.json
- 3:44 PM Changeset in webkit [169573] by
-
- 9 edits2 adds in trunk/Source/WebCore
Refactor the srcset parser into its own file
https://bugs.webkit.org/show_bug.cgi?id=133480
Reviewed by Andreas Kling.
No new tests, since this patch doesn't change the parser's behavior.
This patch moves the srcset parser into its own file,
in order to prepare the code for alignment with recent spec changes.
- CMakeLists.txt:
- html/HTMLImageElement.cpp:
- html/parser/HTMLParserIdioms.cpp:
(WebCore::compareByScaleFactor): Deleted.
(WebCore::parseDescriptors): Deleted.
(WebCore::parseImagesWithScaleFromSrcsetAttribute): Deleted.
(WebCore::bestFitSourceForImageAttributes): Deleted.
- html/parser/HTMLParserIdioms.h:
(WebCore::ImageWithScale::ImageWithScale): Deleted.
(WebCore::ImageWithScale::imageURL): Deleted.
(WebCore::ImageWithScale::scaleFactor): Deleted.
- html/parser/HTMLPreloadScanner.cpp:
- html/parser/HTMLSrcsetParser.cpp: Added.
(WebCore::compareByScaleFactor):
(WebCore::parseDescriptors):
(WebCore::parseImagesWithScaleFromSrcsetAttribute):
(WebCore::bestFitSourceForImageAttributes):
- html/parser/HTMLSrcsetParser.h: Added.
(WebCore::ImageWithScale::ImageWithScale):
(WebCore::ImageWithScale::imageURL):
(WebCore::ImageWithScale::scaleFactor):
- 2:38 PM Changeset in webkit [169572] by
-
- 2 edits in trunk/Source/WebCore
[ATK] accessibility/textarea-selected-text-range.html is failing
https://bugs.webkit.org/show_bug.cgi?id=133479
Reviewed by Chris Fleizach.
Implement atk_text_set_caret_offset() in terms of
atk_text_set_selection() for zero-length selections.
No new tests needed, the following test should just start
passing again now: accessibility/textarea-selected-text-range.html.
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(webkitAccessibleTextSetCaretOffset): Reimplemented this function
in terms of webkitAccessibleTextSetSelection().
- 2:37 PM Changeset in webkit [169571] by
-
- 2 edits in trunk/Source/WebCore
Corrected arm64 assertion in css jit.
Rubber stamped by Benjamin Poulain.
- cssjit/StackAllocator.h:
(WebCore::StackAllocator::pop):
Changed assertion from incorrectly matching x86_64 to using the correct minimum offset,
taking into account that a stackUnitInBytes is used for two registers on arm64
except the last stack unit, which could only be used for one register if there are
an odd number of registers.
- 2:31 PM Changeset in webkit [169570] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Start ignoring common bogus viewport parameters
https://bugs.webkit.org/show_bug.cgi?id=133466
<rdar://problem/16203396>
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-03
Reviewed by Sam Weinig.
Incorrect viewports are spreading really quickly lately. We have to start ignoring
some combinations of arguments as they are almost always used incorrectly, causing
a poor user experience on those websites.
- dom/ViewportArguments.cpp:
(WebCore::finalizeViewportArguments):
- 2:26 PM Changeset in webkit [169569] by
-
- 3 edits2 adds in trunk
CSS JIT: add support for the "any" pseudo class
https://bugs.webkit.org/show_bug.cgi?id=133473
Patch by Yusuke Suzuki <Yusuke Suzuki> on 2014-06-03
Reviewed by Benjamin Poulain.
Add support for the :any pseudo class.
Source/WebCore:
Test: fast/selectors/pseudo-class-any.html
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::addPseudoClassType):
(WebCore::SelectorCompiler::minimumRegisterRequirements):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatching):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementMatchesAnyPseudoClass):
LayoutTests:
- fast/selectors/pseudo-class-any-expected.txt: Added.
- fast/selectors/pseudo-class-any.html: Added.
- 2:09 PM Changeset in webkit [169568] by
-
- 17 edits in trunk
Update PlatformTimeRanges to use MediaTime rather than doubles for time values.
https://bugs.webkit.org/show_bug.cgi?id=133454
Reviewed by Eric Carlson.
Source/WebCore:
PlatformTimeRanges will now use MediaTime, so operations at the platform level won't
lose precision when converting to and from doubles and rational time values like CMTime.
- Modules/mediasource/SourceBuffer.cpp:
(WebCore::currentTimeFudgeFactor):
(WebCore::SourceBuffer::hasCurrentTime):
(WebCore::SourceBuffer::hasFutureTime):
(WebCore::SourceBuffer::canPlayThrough):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- html/TimeRanges.cpp:
(WebCore::TimeRanges::TimeRanges):
(WebCore::TimeRanges::start):
(WebCore::TimeRanges::end):
(WebCore::TimeRanges::add):
(WebCore::TimeRanges::contain):
(WebCore::TimeRanges::find):
(WebCore::TimeRanges::nearest):
(WebCore::TimeRanges::totalDuration):
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::seekable):
- platform/graphics/PlatformTimeRanges.cpp:
(WebCore::PlatformTimeRanges::create):
(WebCore::PlatformTimeRanges::PlatformTimeRanges):
(WebCore::PlatformTimeRanges::invert):
(WebCore::PlatformTimeRanges::start):
(WebCore::PlatformTimeRanges::end):
(WebCore::PlatformTimeRanges::add):
(WebCore::PlatformTimeRanges::contain):
(WebCore::PlatformTimeRanges::find):
(WebCore::PlatformTimeRanges::nearest):
(WebCore::PlatformTimeRanges::totalDuration):
- platform/graphics/PlatformTimeRanges.h:
(WebCore::PlatformTimeRanges::Range::Range):
(WebCore::PlatformTimeRanges::Range::isPointInRange):
- platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::extraMemoryCost):
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::MediaPlayerPrivateAVFoundationCF::platformBufferedTimeRanges):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformBufferedTimeRanges):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekable):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::buffered): Deleted.
- platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::buffered):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::buffered):
- platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:
(WebCore::MockMediaPlayerMediaSource::advanceCurrentTime):
LayoutTests:
Update the video-pause-immediately to allow for small floating point differences.
- media/video-pause-immediately-expected.txt:
- media/video-pause-immediately.html:
- 1:59 PM Changeset in webkit [169567] by
-
- 7 edits in trunk/Source
[iOS][WK2] Align the highlight rects with device pixels
https://bugs.webkit.org/show_bug.cgi?id=133464
Source/WebCore:
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-03
Reviewed by Enrica Casucci.
Add utility functions to pixel align points and rects.
- WebCore.exp.in:
- platform/graphics/FloatPoint.h:
(WebCore::flooredToDevicePixels):
(WebCore::ceiledToDevicePixels):
- platform/graphics/FloatRect.cpp:
(WebCore::enclosingRectExtendedToDevicePixels):
- platform/graphics/FloatRect.h:
Source/WebKit2:
<rdar://problem/16708861>
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-06-03
Reviewed by Enrica Casucci.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _showTapHighlightWithColor:WebCore::quads:WebCore::topLeftRadius:WebCore::topRightRadius:WebCore::bottomLeftRadius:WebCore::bottomRightRadius:WebCore::]):
- 1:13 PM Changeset in webkit [169566] by
-
- 2 edits in trunk/Websites/planet.webkit.org
Add Igalia WebKit blog to the planet
https://bugs.webkit.org/show_bug.cgi?id=133446
Reviewed by Bem Jones-Bey.
- config.ini: Add Igalia WebKit blog to the planet and remove Martin's
and Xan's blogs as they will be included there.
- 11:59 AM Changeset in webkit [169565] by
-
- 4 edits in trunk/Source/WebCore
Prepopulated tiles may never be unparented from TileGrids with aggressive tile retention on
https://bugs.webkit.org/show_bug.cgi?id=133471
Reviewed by Simon Fraser.
- platform/graphics/ca/mac/TileController.h:
- platform/graphics/ca/mac/TileGrid.h:
(WebCore::TileGrid::TileCohortInfo::TileCohortInfo):
- platform/graphics/ca/mac/TileGrid.mm:
(WebCore::TileGrid::TileCohortInfo::timeUntilExpiration):
(WebCore::TileGrid::cohortRemovalTimerFired):
Factor timeUntilExpiration() out of cohortRemovalTimerFired().
(WebCore::TileGrid::revalidateTiles):
Ensure that secondary tiles that never touch the primary coverage rect
are still unparented eventually (after 2 seconds, the same lifetime we use
for cohorts in non-aggressive retention).
Schedule another revalidateTiles if we left parented secondary tiles behind.
- 11:13 AM Changeset in webkit [169564] by
-
- 3 edits in trunk/Source/WebCore
TileGrid::prepopulateRect populates the wrong tiles if scale != 1
https://bugs.webkit.org/show_bug.cgi?id=133470
Reviewed by Simon Fraser.
- page/FrameView.cpp:
(WebCore::FrameView::requestScrollPositionUpdate):
- platform/graphics/ca/mac/TileGrid.mm:
(WebCore::TileGrid::prepopulateRect):
(WebCore::TileGrid::revalidateTiles):
prepopulateRect takes rects in "content" coordinates, but when later passed to
ensureTilesForRect, they're expected to be in the same coordinate space as the layer's
visible rect, and are scaled up. So, apply the inverse scale to counter that.
- 11:12 AM Changeset in webkit [169563] by
-
- 5 edits in trunk/Source/WebCore
Minor TileCoverageMap refinements
https://bugs.webkit.org/show_bug.cgi?id=133468
Reviewed by Simon Fraser.
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::setContentsScale):
- platform/graphics/ca/mac/TileCoverageMap.h:
- platform/graphics/ca/mac/TileCoverageMap.mm:
(WebCore::TileCoverageMap::TileCoverageMap):
(WebCore::TileCoverageMap::setDeviceScaleFactor):
Keep the TileCoverageMap's contentsScale at the device scale factor, so that it
looks sharp on non-1x displays.
(WebCore::TileCoverageMap::update):
Decrease the height available for the TileCoverageMap by the topContentInset;
it's already being vertically offset by the topContentInset, but the height was
not adjusted, so it would run off the bottom of the window.
- platform/graphics/ca/mac/TileGrid.mm:
(WebCore::TileGrid::drawTileMapContents):
If using aggressive tile retention (and thus not coloring tiles based on age),
dim tiles that aren't in the visible cohort.
- 11:11 AM Changeset in webkit [169562] by
-
- 4 edits in trunk/Source/WebCore
Fix a typo, TileGrid::updateTilerLayerProperties
https://bugs.webkit.org/show_bug.cgi?id=133474
Reviewed by Anders Carlsson.
- platform/graphics/ca/mac/TileController.mm:
(WebCore::TileController::setAcceleratesDrawing):
(WebCore::TileController::setTilesOpaque):
(WebCore::TileController::setTileDebugBorderWidth):
(WebCore::TileController::setTileDebugBorderColor):
- platform/graphics/ca/mac/TileGrid.h:
- platform/graphics/ca/mac/TileGrid.mm:
(WebCore::TileGrid::updateTileLayerProperties):
(WebCore::TileGrid::updateTilerLayerProperties):
s/updateTilerLayerProperties/updateTileLayerProperties/g
- 10:52 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 9:42 AM Changeset in webkit [169561] by
-
- 2 edits in trunk/Source/JavaScriptCore
LLVM soft-linking should be truly fail-silent
https://bugs.webkit.org/show_bug.cgi?id=133482
Reviewed by Mark Lam.
- llvm/InitializeLLVMPOSIX.cpp:
(JSC::initializeLLVMPOSIX): Missing return statement in the dlsym() returning null case.
- 5:04 AM Changeset in webkit [169560] by
-
- 2 edits in trunk/Source/WebCore
[SOUP] ResourceLoadTiming.responseStart is always 0
https://bugs.webkit.org/show_bug.cgi?id=133469
Reviewed by Sergio Villar Senin.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sendRequestCallback): Record the responseStart time.
- 4:40 AM Changeset in webkit [169559] by
-
- 8 edits in trunk
REGRESSION(r169092 and r169102): Skip failing JSC tests poperly on non-x86 Darwin platforms
https://bugs.webkit.org/show_bug.cgi?id=133149
Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-06-03
Reviewed by Csaba Osztrogonác.
PerformanceTests/SunSpider:
- profiler-test.yaml: Skip profiler tests only if the architecture isn't x86 and the host is Darwin.
Source/JavaScriptCore:
- tests/mozilla/mozilla-tests.yaml: Skip js1_5/Regress/regress-159334.js only if the architecture isn't x86 and the host is Darwin.
Tools:
- Scripts/run-jsc-stress-tests: Added determineOS to determine the host operating system the script run on.
LayoutTests:
- js/script-tests/function-apply-many-args.js: Skip it only if the architecture isn't x86 and the host is Darwin.
