Jul 15, 2014:

11:04 PM Changeset in webkit [171139] by ryuan.choi@samsung.com
  • 2 edits in trunk


Reviewed by Gyuyoung Kim.

ENCRYPTED_MEDIA_V2 requires VIDEO enabled.

  • Source/cmake/WebKitFeatures.cmake: Added the dependency for ENABLE_ENCRYPTED_MEDIA_V2.
9:44 PM Changeset in webkit [171138] by Yusuke Suzuki
  • 7 edits in trunk/Source/WebCore

CSS: Generalize CSS First Letter treatment

Reviewed by Benjamin Poulain.

first-letter pseudo element rule is handled differently from the other rules
such as first-line. This patch removes this special handling in SelectorChecker
and handles it in RulesFeatureSet.

  • css/RuleFeature.cpp:


  • css/RuleFeature.h:


  • css/SelectorChecker.cpp:


  • css/StyleResolver.h:


  • dom/DocumentStyleSheetCollection.cpp:


  • dom/DocumentStyleSheetCollection.h:

(WebCore::DocumentStyleSheetCollection::setUsesFirstLetterRules): Deleted.

9:33 PM Changeset in webkit [171137] by ryuan.choi@samsung.com
  • 2 edits in trunk/Tools

[EFL] Remove EFL WK1 directory from the checker.py

Reviewed by Gyuyoung Kim.

  • Scripts/webkitpy/style/checker.py:
9:31 PM Changeset in webkit [171136] by clopez@igalia.com
  • 2 edits in trunk/Tools

Adding myself to contributors.json breaks a webkitpy test

Reviewed by Ryosuke Niwa.

  • Scripts/webkitpy/tool/bot/irc_command_unittest.py:

(IRCCommandTest.test_whois): Be more specific and include also the
first name when asking for the whois of Xan in the unit test.

8:56 PM Changeset in webkit [171135] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebKit2

Fix r171124

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-07-15

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _scrollToContentOffset:]):
On landing, I changed the min/max branches to shrunkTo/expandedTo, but the return value
of those was ignored.

8:07 PM Changeset in webkit [171134] by jonowells@apple.com
  • 25 edits
    2 copies in trunk/Source/WebInspectorUI

Web Inspector: Modernize UI styles and better sync with platform styles

Reviewed by Timothy Hatcher.

Updated styles to better match the OS UI design. Updated the forward/back button.
Moved several rules to selectors that support older OS designs. Added global platform
data to support this patch.

  • UserInterface/Images/BackArrow.svg: Added.
  • UserInterface/Images/BackArrowLegacy.svg: Copied from Source/WebInspectorUI/UserInterface/Images/BackArrow.svg.
  • UserInterface/Images/ForwardArrow.svg: Added.
  • UserInterface/Images/ForwardArrowLegacy.svg: Copied from Source/WebInspectorUI/UserInterface/Images/ForwardArrow.svg.
  • UserInterface/Base/ImageUtilities.js: Updated image version

Updated image generation to support modern look. Updated versioning scheme and version.

  • UserInterface/Base/Main.js:

Added global platform information.

  • UserInterface/Views/ContentBrowser.js:

Updated back and forward buttons.

  • UserInterface/Views/FindBanner.js:

Updated images for the find banner.

  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:

Added new images.

  • UserInterface/Views/ButtonToolbarItem.css:

(.toolbar .item.button > .label):
(body.mac-platform.legacy .toolbar .item.button > .label):

  • UserInterface/Views/CSSStyleDeclarationSection.css:

(body.mac-platform.legacy .style-declaration-section):
(body.mac-platform.legacy .style-declaration-section + .style-declaration-section):
(body.mac-platform.legacy .style-declaration-section.last-in-group):
(.style-declaration-section.last-in-group + .style-declaration-section):
(body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section):
(body.mac-platform.legacy .style-declaration-section.last-in-group + .style-declaration-section:last-child):
(.style-declaration-section + .style-declaration-section): Deleted.
(.style-declaration-section.last-in-group + .style-declaration-section:last-child): Deleted.

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.css:

(.sidebar > .panel.details.css-style > .content > .pseudo-classes):

  • UserInterface/Views/DOMTreeOutline.css:

(.dom-tree-outline li.hovered:not(.selected) .selection):
(body.mac-platform.legacy .dom-tree-outline li.hovered:not(.selected) .selection):
(.dom-tree-outline li.elements-drag-over .selection):
(body.mac-platform.legacy .dom-tree-outline li.elements-drag-over .selection):
(.dom-tree-outline:focus li.selected .selection):
(body.mac-platform.legacy .dom-tree-outline:focus li.selected .selection):

  • UserInterface/Views/DashboardContainerView.css:

(.toolbar .dashboard-container):
(body.mac-platform.legacy .toolbar .dashboard-container):
(body.window-inactive .toolbar .dashboard-container):
(body.mac-platform.legacy.window-inactive .toolbar .dashboard-container):
(.toolbar .dashboard):
(body.window-inactive .toolbar .dashboard):
(body.mac-platform.legacy.window-inactive .toolbar .dashboard):

  • UserInterface/Views/DataGrid.css:

(.data-grid th):
(body.mac-platform.legacy .data-grid th):
(.data-grid tr.selected):
(body.mac-platform.legacy .data-grid tr.selected):
(.data-grid:focus tr.selected):
(body.mac-platform.legacy .data-grid:focus tr.selected):

  • UserInterface/Views/DetailsSection.css:

(body.mac-platform.legacy .details-section):
(.details-section .details-section):
(body.mac-platform.legacy .details-section .details-section):
(.details-section .details-section:last-child):
(.details-section .details-section:first-child):
(.details-section > .header):
(body.mac-platform.legacy .details-section > .header):
(.details-section .details-section > .header):
(body.mac-platform.mountain-lion .details-section .details-section > .header):
(.details-section .details-section.collaspsed > .header):
(.details-section.computed-style-properties:not(.collapsed) > .header):
(body.mac-platform.legacy .details-section.computed-style-properties:not(.collapsed) > .header):
(.details-section > .content > .group):
(body.mac-platform.legacy .details-section > .content > .group):
(.details-section > .content > .group:last-child):
(.details-section > .content > .group:nth-child(even)):
(body.mac-platform.legacy .details-section > .content > .group:nth-child(even)):
(body.mac-platform.legacy .details-section > .content > .group:last-child > .row.simple:last-child > *):
(.details-section > .content > .group:last-child > .row.simple:last-child > *): Deleted.

  • UserInterface/Views/FilterBar.css:

(.filter-bar > input[type="search"]):
(body.mac-platform.legacy .filter-bar > input[type="search"]):

  • UserInterface/Views/NavigationSidebarPanel.css:

(.navigation-sidebar-panel-content-tree-outline .item.selected):
(body.mac-platform.legacy .navigation-sidebar-panel-content-tree-outline .item.selected):
(.navigation-sidebar-panel-content-tree-outline:focus .item.selected):
(body.mac-platform.legacy .navigation-sidebar-panel-content-tree-outline:focus .item.selected):
(body.window-inactive .navigation-sidebar-panel-content-tree-outline .item.selected):
(body.mac-platform.legacy.window-inactive .navigation-sidebar-panel-content-tree-outline .item.selected):

  • UserInterface/Views/RadioButtonNavigationItem.css:

(.navigation-bar .item.radio.button.text-only.selected):
(body.mac-platform.legacy .navigation-bar .item.radio.button.text-only.selected):

  • UserInterface/Views/RulesStyleDetailsPanel.css:

(.sidebar > .panel.details.css-style .rules .label + .style-declaration-section):
(body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .label + .style-declaration-section):
(.sidebar > .panel.details.css-style .rules .new-rule):
(body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .new-rule):
(.sidebar > .panel.details.css-style .rules .new-rule + .style-declaration-section):
(body.mac-platform.legacy .sidebar > .panel.details.css-style .rules .new-rule + .style-declaration-section):

  • UserInterface/Views/ScopeBar.css:

(.scope-bar > li):
(body.mac-platform.legacy .scope-bar > li):
(.scope-bar > li.selected):
(body.mac-platform.legacy .scope-bar > li.selected):

  • UserInterface/Views/SearchBar.css:

(.search-bar > input[type="search"]):
(body.mac-platform.legacy .search-bar > input[type="search"]):

  • UserInterface/Views/Sidebar.css:

(body.mac-platform.legacy .sidebar):
(body.mac-platform.legacy.window-inactive .sidebar):
(body.mac-platform.legacy .sidebar.right):
(body.window-inactive .sidebar): Deleted.
(.sidebar.right): Deleted.

  • UserInterface/Views/TimelineSidebarPanel.css:

(.sidebar > .panel.navigation.timeline > .title-bar):
(body.mac-platform.legacy .sidebar > .panel.navigation.timeline > .title-bar):
Style updates for new look and feel.

8:06 PM Changeset in webkit [171133] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix non-iOS builds.

  • rendering/RenderBox.cpp:


7:58 PM Changeset in webkit [171132] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

[iOS] Fix touches inside accelerated overflow:scroll

Reviewed by Benjamin Poulain.

When individual elements inside an overflow:scroll with -webkit-overflow-scrolling: touch
had touch event listeners, we would fail to take the scroll offset into account when
building the touch event region, causing touches on those elements to fail after scrolling.

Touch event region building uses RenderObject::absoluteClippedOverflowRect(), and that
code path tries to fix up repaint rects to work correctly in composited overflow:scroll.
However, that broke the touch region computation.

Fix by only ignoring the scroll offset for calls to computeRectForRepaint() which
have a non-null repaintContainer (which indicates that we're doing a repaint in the
compositing layer), and for which the repaintContainer is the containing block
which is using composited scrolling. This restores correct behavior to the event region
code which always calls this with a null repaintContainer.

  • rendering/RenderBox.cpp:


7:26 PM Changeset in webkit [171131] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Unreviewed, rolling out r171107.

This was not the problem! (Requested by kling on #webkit).

Reverted changeset:

"Revert: Run the FastMalloc scavenger thread on iOS as well."

6:40 PM Changeset in webkit [171130] by achristensen@apple.com
  • 2 edits in trunk/Websites/webkit.org

Make css jit benchmark work on IE11.

Reviewed by Benjamin Poulain.

  • blog-files/css-jit-introduction/html5-single-page-microbenchmark.html:

Remove an iframe which caused IE11 to try to open content as a URL.

6:29 PM Changeset in webkit [171129] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

WKWebView’s FormClient::willSubmitForm should use CompletionHandlerCallChecker

Reviewed by Tim Horton.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setFormDelegate:]):

5:53 PM Changeset in webkit [171128] by bshafiei@apple.com
  • 2 edits in tags/Safari-538.46.3/Source/WebCore

Merged r171099. <rdar://problem/16917699>

5:51 PM Changeset in webkit [171127] by bshafiei@apple.com
  • 2 edits in tags/Safari-538.46.3/Source/WebCore

Merged r171089. <rdar://problem/16917699>

5:47 PM Changeset in webkit [171126] by bshafiei@apple.com
  • 5 edits in tags/Safari-538.46.3/Source


5:43 PM Changeset in webkit [171125] by bshafiei@apple.com
  • 1 copy in tags/Safari-538.46.3

New tag.

5:14 PM Changeset in webkit [171124] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebKit2

[iOS][WK2] Scrolling request from the scrolling tree must be limited to offsets in the document

Reviewed by Enrica Casucci.

When we received a scroll request, we were taking that offset directly to set the UIScrollView
scroll position. This is a problem if a page request scrolling to an invalid position, we were
still doing it.

This patch limits the position to be inside the document.

-- Why not limit the scroll offset in the WebProcess when we receive the scroll request? --

Some pages rely on the page scale factor changing instantly, because that is how it worked
on WebKit1.

On WebKit2, the WebProcess cannot know the valid range because the obscured insets are changing
dynamically, and the page scale factor can change in response to WebProcess events (the focus
changing for example). To make the page works, the WebProcess does not restrict the scroll position.

In that architecture, the UIProcess has to sanitize the input, which was not done before this patch.

-- Why not use changeContentOffsetBoundedInValidRange()?

The scroll offset as seen by the page is relative to the unobscured rect. While the position used
for history item is a visual position. All we need in this case is a position in the view.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _scrollToContentOffset:]):

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WebPageProxyIOS.mm:


4:59 PM Changeset in webkit [171123] by benjamin@webkit.org
  • 8 edits in trunk/Source/JavaScriptCore

Reduce the overhead of updating the AssemblerBuffer

Reviewed by Gavin Barraclough.

In r164548, the linker was changed to allow the LinkBuffer to survive its MacroAssembler.
That feature is useful for JSC to get offsets inside a linked buffer in order to jump directly

On ARM, we use branch compaction and we need to keep the "compaction offset" somewher to be able
to get the real address of a lable. That is done by reusing the memory of AssemblerData.

To share the memory between LinkBuffer and the Assembler, r164548 moved the AssemblerData into
a ref-counted object. Unfortunately, the extra complexity related to the new AssemblerData was enough
to make clang give up a bunch of optimizations.

This patch solve (some of) the problems by making AssemblerBuffer and AssemblerData super low overhead structures.
In particular, the grow() function becomes 8 Thumb instructions, which is easily inlined everywhere it is used.

Instead of sharing ownership between the Assembler and LinkBuffer, LinkBuffer now takes full ownership of
the AssemblerData. I feel this is also safer since LinkBuffer is reusing the AssemblerData is a very
specific way that would make it unusable for the Assembler.

-- Technical details --

From LinkBuffer, we don't want to ever access the Assembler after releasing its buffer (or writting anything
into it really). This was obviously already the case, but that was hard to prove from LinkBuffer::copyCompactAndLinkCode().
To make this easier to work with, I changed all the assembler specific function to be static. This way we know
exactly what code access the Assembler instance. The code that does access the instance is then moved
at the beginning, before we modify anything.

The function recordLinkOffsets() that was on the MacroAssembler and copied in Assembler was moved directly
to LinkBuffer. This make the modification of AssemblerData completely explicit, and that code is specific
to LinkBuffer anyway (see LinkBuffer::executableOffsetFor()).

-- Perf impact --

This does not put us exactly at before r164548 due to the missing inline buffer. Still, it is very close.
On ARMv7, this reduces the time spent in Assembler by half. On the CSS JIT, this reduces the compilation
time by ~20%.

I could not measure any difference on x86_64.

  • assembler/ARM64Assembler.h:

(JSC::ARM64Assembler::recordLinkOffsets): Deleted.

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::recordLinkOffsets): Deleted.

  • assembler/AssemblerBuffer.h:

(JSC::AssemblerBuffer::~AssemblerBuffer): Deleted.
(JSC::AssemblerBuffer::storage): Deleted.

  • assembler/LinkBuffer.cpp:


  • assembler/LinkBuffer.h:


  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::recordLinkOffsets): Deleted.

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::recordLinkOffsets): Deleted.

4:12 PM Changeset in webkit [171122] by Lucas Forschler
  • 5 edits in tags/Safari-538.46.40/Source


3:55 PM Changeset in webkit [171121] by Lucas Forschler
  • 1 copy in tags/Safari-538.46.40

New Tag.

3:51 PM Changeset in webkit [171120] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebKit/mac

[OSX] [WK1] Crash when exiting fullscreen

Reviewed by Dean Jackson.

AppKit doesn't remove a view from the Key View Loop when removing it from its superview.

This codepath is already "tested" in fullscreen/full-screen-cancel.html, but because of our
testing infrastructure, the broken codepath doesn't actually get hit in DRT. Therefore,
there is no test.

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController enterFullScreen:]):

3:25 PM Changeset in webkit [171119] by Simon Fraser
  • 9 edits in trunk/Source/WebCore

[iOS] Fix issues drawing subsampled image elements and CSS images

Reviewed by Dean Jackson.

After r170675 it is important for BitmapImage::draw() to be given a srcRect computed
using the original size of the image, not the subsampled size.

So fix various code paths that end up in image drawing to use the originalSize(),
which requires giving Image a virtual function that just returns size(), and hence has
a FloatSize return value.

Tested by setting a very low subsampling threshold and browsing various sites.

A better longterm fix will happen via bug 134916.

  • platform/graphics/BitmapImage.cpp:


  • platform/graphics/BitmapImage.h:
  • platform/graphics/GraphicsContext.cpp:


  • platform/graphics/Image.cpp:


  • platform/graphics/Image.h:


  • platform/graphics/cg/BitmapImageCG.cpp:

(WebCore::BitmapImage::BitmapImage): Just use m_size for initializing the other members.

  • platform/graphics/cg/GraphicsContext3DCG.cpp:


  • platform/graphics/cg/ImageCG.cpp:


2:32 PM Changeset in webkit [171118] by Lucas Forschler
  • 5 edits in trunk/Source


2:26 PM Changeset in webkit [171117] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Dispatch top content inset changes immediately if synchronously waiting for view state changes

Reviewed by Simon Fraser.

  • UIProcess/API/mac/WKView.mm:

(-[WKView endDeferringViewInWindowChanges]):
(-[WKView endDeferringViewInWindowChangesSync]):
(-[WKView _dispatchSetTopContentInset]):
(-[WKView _setTopContentInset:]):
Send top content inset changes immediately before sync-waiting for new tiles from the Web Process.
This will ensure that the incoming contents have the right top content inset, and we don't
flash between the wrong inset and the right one.

2:17 PM Changeset in webkit [171116] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

[Win] Unreviewed build fix after r171069.

Add missing AudioHardwareListener implementation on Windows.

  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
2:05 PM Changeset in webkit [171115] by mhahnenberg@apple.com
  • 10 edits in trunk/Source/JavaScriptCore

Stores to PropertyTable use the Structure as the owner

Reviewed by Darin Adler.

Since PropertyTable is the object that does the marking of these references, it should be the owner.

Also removed some unused parameters to other methods that historically used the Structure as the owner.

  • runtime/JSPropertyNameIterator.h:


  • runtime/ObjectPrototype.cpp:


  • runtime/PropertyMapHashTable.h:


  • runtime/PropertyTable.cpp:


  • runtime/Structure.cpp:


  • runtime/Structure.h:


  • runtime/StructureInlines.h:


  • runtime/StructureRareData.h:
  • runtime/StructureRareDataInlines.h:


1:52 PM Changeset in webkit [171114] by enrica@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION(WK2 iOS): Safari hangs when switching focus from a field using the Tab key.

Reviewed by Tim Horton.

  • UIProcess/ios/WKContentViewInteraction.mm:

Tab and back tab should be handled as special keys that have
a command associated. The command specifies for each key the relevant
action. This patch implements the commands property to create the association
between key and command and the relevant actions that will execute the same
code executed when the used taps on the < > buttons in the accessory bar.

(-[WKContentView keyCommands]):
(-[WKContentView _nextAccessoryTab:]):
(-[WKContentView _prevAccessoryTab:]):

1:31 PM Changeset in webkit [171113] by oliver@apple.com
  • 2 edits in trunk/Source/WebKit2

More tidying of the webcontent sandbox profile

Reviewed by Alexey Proskuryakov.

Remove some excessive abilities from the profile and make
the required ones explicit.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
12:41 PM Changeset in webkit [171112] by bshafiei@apple.com
  • 2 edits in tags/Safari-538.46.1.1/Source/WebCore

Merged r171099. <rdar://problem/16917699>

12:38 PM Changeset in webkit [171111] by bshafiei@apple.com
  • 2 edits in tags/Safari-538.46.1.1/Source/WebCore

Merged r171089. <rdar://problem/16917699>

12:30 PM Changeset in webkit [171110] by bshafiei@apple.com
  • 5 edits in tags/Safari-538.46.1.1/Source


12:27 PM Changeset in webkit [171109] by bshafiei@apple.com
  • 1 copy in tags/Safari-538.46.1.1

New tag.

12:11 PM Changeset in webkit [171108] by mhahnenberg@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

ScriptExecutable::forEachCodeBlock can dereference null CodeBlocks

Reviewed by Andreas Kling.

  • bytecode/CodeBlock.h:

(JSC::ScriptExecutable::forEachCodeBlock): Check for null CodeBlocks before calling forEachRelatedCodeBlock.

11:34 AM Changeset in webkit [171107] by akling@apple.com
  • 2 edits in trunk/Source/WTF

Revert: Run the FastMalloc scavenger thread on iOS as well.

This appears to be the cause of some elusive crashes, and since I don't
have a way to reproduce them, let's just go back to not running the
scavenger thread on iOS.

Reviewed by Antti Koivisto.

  • wtf/FastMalloc.cpp:
8:48 AM Changeset in webkit [171106] by fpizlo@apple.com
  • 21 edits
    13 adds in branches/ftlopt

[ftlopt] DFG should be able to do GCSE in SSA and this should be unified with the CSE in CPS, and both of these things should use abstract heaps for reasoning about effects

Reviewed by Sam Weinig.


This removes the old local CSE phase, which was based on manually written backward-search
rules for all of the different kinds of things we cared about, and adds a new local/global
CSE (local for CPS and global for SSA) that leaves the node semantics almost entirely up to
clobberize(). Thus, the CSE phase itself just worries about the algorithms and data
structures used for storing sets of available values. This results in a large reduction in
code size in CSEPhase.cpp while greatly increasing the phase's power (since it now does
global CSE) and reducing compile time (since local CSE is now rewritten to use smarter data
structures). Even though LLVM was already running GVN, the extra GCSE at DFG IR level means
that this is a significant (~0.7%) throughput improvement.

This work is based on the concept of "def" to clobberize(). If clobberize() calls def(), it
means that the node being analyzed makes available some value in some DFG node, and that
future attempts to compute that value can simply use that node. In other words, it
establishes an available value mapping of the form value=>node. There are two kinds of
values that can be passed to def():

PureValue. This captures everything needed to determine whether two pure nodes - nodes that

neither read nor write, and produce a value that is a CSE candidate - are identical. It
carries the NodeType, an AdjacencyList, and one word of meta-data. The meta-data is
usually used for things like the arithmetic mode or constant pointer. Passing a
PureValue to def() means that the node produces a value that is valid anywhere that the
node dominates.

HeapLocation. This describes a location in the heap that could be written to or read from.

Both stores and loads can def() a HeapLocation. HeapLocation carries around an abstract
heap that both serves as part of the "name" of the heap location (together with the
other fields of HeapLocation) and also tells us what write()'s to watch for. If someone
write()'s to an abstract heap that overlaps the heap associated with the HeapLocation,
then it means that the values for that location are no longer available.

This approach is sufficiently clever that the CSEPhase itself can focus on the mechanism of
tracking the PureValue=>node and HeapLocation=>node maps, without having to worry about
interpreting the semantics of different DFG node types - that is now almost entirely in
clobberize(). The only things we special-case inside CSEPhase are the Identity node, which
CSE is traditionally responsible for eliminating even though it has nothing to do with CSE,
and the LocalCSE rule for turning PutByVal into PutByValAlias.

This is a slight Octane, SunSpider, and Kraken speed-up - all somewhere arond 0.7% . It's
not a bigger win because LLVM was already giving us most of what we needed in its GVN.
Also, the SunSpider speed-up isn't from GCSE as much as it's a clean-up of local CSE - that
is no longer O(n2). Basically this is purely good: it reduces the amount of LLVM IR we
generate, it removes the old CSE's heap modeling (which was a constant source of bugs), and
it improves both the quality of the code we generate and the speed with which we generate
it. Also, any future optimizations that depend on GCSE will now be easier to implement.

During the development of this patch I also rationalized some other stuff, like Graph's
ordered traversals - we now have preorder and postorder rather than just "depth first".

  • CMakeLists.txt:
  • JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • dfg/DFGAbstractHeap.h:
  • dfg/DFGAdjacencyList.h:


  • dfg/DFGBasicBlock.h:
  • dfg/DFGCSEPhase.cpp:

(JSC::DFG::CSEPhase::CSEPhase): Deleted.
(JSC::DFG::CSEPhase::run): Deleted.
(JSC::DFG::CSEPhase::endIndexForPureCSE): Deleted.
(JSC::DFG::CSEPhase::pureCSE): Deleted.
(JSC::DFG::CSEPhase::constantCSE): Deleted.
(JSC::DFG::CSEPhase::constantStoragePointerCSE): Deleted.
(JSC::DFG::CSEPhase::getCalleeLoadElimination): Deleted.
(JSC::DFG::CSEPhase::getArrayLengthElimination): Deleted.
(JSC::DFG::CSEPhase::globalVarLoadElimination): Deleted.
(JSC::DFG::CSEPhase::scopedVarLoadElimination): Deleted.
(JSC::DFG::CSEPhase::varInjectionWatchpointElimination): Deleted.
(JSC::DFG::CSEPhase::getByValLoadElimination): Deleted.
(JSC::DFG::CSEPhase::checkFunctionElimination): Deleted.
(JSC::DFG::CSEPhase::checkExecutableElimination): Deleted.
(JSC::DFG::CSEPhase::checkStructureElimination): Deleted.
(JSC::DFG::CSEPhase::structureTransitionWatchpointElimination): Deleted.
(JSC::DFG::CSEPhase::getByOffsetLoadElimination): Deleted.
(JSC::DFG::CSEPhase::getGetterSetterByOffsetLoadElimination): Deleted.
(JSC::DFG::CSEPhase::getPropertyStorageLoadElimination): Deleted.
(JSC::DFG::CSEPhase::checkArrayElimination): Deleted.
(JSC::DFG::CSEPhase::getIndexedPropertyStorageLoadElimination): Deleted.
(JSC::DFG::CSEPhase::getInternalFieldLoadElimination): Deleted.
(JSC::DFG::CSEPhase::getMyScopeLoadElimination): Deleted.
(JSC::DFG::CSEPhase::getLocalLoadElimination): Deleted.
(JSC::DFG::CSEPhase::invalidationPointElimination): Deleted.
(JSC::DFG::CSEPhase::setReplacement): Deleted.
(JSC::DFG::CSEPhase::eliminate): Deleted.
(JSC::DFG::CSEPhase::performNodeCSE): Deleted.
(JSC::DFG::CSEPhase::performBlockCSE): Deleted.
(JSC::DFG::performCSE): Deleted.

  • dfg/DFGCSEPhase.h:
  • dfg/DFGClobberSet.cpp:


  • dfg/DFGClobberize.cpp:


  • dfg/DFGClobberize.h:


  • dfg/DFGDCEPhase.cpp:


  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::addForDepthFirstSort): Deleted.
(JSC::DFG::Graph::getBlocksInDepthFirstOrder): Deleted.

  • dfg/DFGGraph.h:
  • dfg/DFGHeapLocation.cpp: Added.


  • dfg/DFGHeapLocation.h: Added.


  • dfg/DFGLICMPhase.cpp:


  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToPhantomUnchecked): Deleted.

  • dfg/DFGPlan.cpp:


  • dfg/DFGPureValue.cpp: Added.


  • dfg/DFGPureValue.h: Added.


  • dfg/DFGSSAConversionPhase.cpp:


  • ftl/FTLLowerDFGToLLVM.cpp:



  • js/regress/gcse-expected.txt: Added.
  • js/regress/gcse-poly-get-expected.txt: Added.
  • js/regress/gcse-poly-get-less-obvious-expected.txt: Added.
  • js/regress/gcse-poly-get-less-obvious.html: Added.
  • js/regress/gcse-poly-get.html: Added.
  • js/regress/gcse.html: Added.
  • js/regress/script-tests/gcse-poly-get-less-obvious.js: Added.
  • js/regress/script-tests/gcse-poly-get.js: Added.
  • js/regress/script-tests/gcse.js: Added.
7:59 AM Changeset in webkit [171105] by Antti Koivisto
  • 3 edits
    2 adds in trunk

REGRESSION (r155957): Invalid cast in WebCore::RenderNamedFlowThread::getRanges

Reviewed by Mihnea Ovidenie.

Test: fast/regions/flowthread-getranges-box-cast.html

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::getRanges): Test the type before casting.


  • fast/regions/flowthread-getranges-box-cast-expected.txt: Added.
  • fast/regions/flowthread-getranges-box-cast.html: Added.
3:49 AM Changeset in webkit [171104] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Buildfix if LLINT_SLOW_PATH_TRACING is enabled

Patch by Eva Balazsfalvi <evab.u-szeged@partner.samsung.com> on 2014-07-15
Reviewed by Mark Lam.

  • llint/LLIntSlowPaths.cpp:


2:34 AM Changeset in webkit [171103] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GTK] Update GObject DOM bindings symbols file after r171014.

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-07-15
Reviewed by Philippe Normand.

  • bindings/gobject/webkitdom.symbols: Update to the current API.
2:15 AM Changeset in webkit [171102] by Manuel Rego Casasnovas
  • 2 edits in trunk/Source/WebCore

Unreviwed fix wrong indentation from r171082.

  • rendering/RenderGrid.cpp:


Jul 14, 2014:

8:04 PM Changeset in webkit [171101] by akling@apple.com
  • 2 edits in trunk/Source/WebKit2

[iOS] Don't progressively re-render tiles while pinch-zooming under memory pressure.

When we're under memory pressure, the last thing we want to be doing is
creating gratuitous new IOSurfaces. Just wait for the gesture to end before
rendering at the new scale.

Reviewed by Tim Horton.

  • WebProcess/WebPage/ios/WebPageIOS.mm:


7:55 PM Changeset in webkit [171100] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Subpixel rendering: Zero sized compositing container's content positioned off by one device pixel.

Reviewed by Simon Fraser.

The compositing layer boundaries are calculated using its renderer()'s and the renderer()'s
descendants' bounds. However when the renderer() is zero sized, its bounds are omitted.
In such cases, when the child content has offset from the renderer(), the subpixel adjustment
of the compositing layer becomes negative (-meaning that the compositing layer is to the right/bottom
direction from its renderer()). Remove fabs() to be able to express such direction.

Test: compositing/hidpi-compositing-layer-with-zero-sized-container.html

  • rendering/RenderLayerBacking.cpp:



  • compositing/hidpi-compositing-layer-with-zero-sized-container-expected.html: Added.
  • compositing/hidpi-compositing-layer-with-zero-sized-container.html: Added.
7:15 PM Changeset in webkit [171099] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix crash on WebVideoFullscreenManagerProxy construction.

Unreviewed fix crash from r171089

Remove unnecessary dispatch to main queue since it can happen during construction.

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-07-14

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::setWebVideoFullscreenModel): remove dispatch_async

6:52 PM Changeset in webkit [171098] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[Cocoa] _WKRemoteObjectInterface leaks NSString ivar

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-14
Reviewed by Simon Fraser.

Release our copied NSString in dealloc.

  • Shared/API/Cocoa/_WKRemoteObjectInterface.mm:

(-[_WKRemoteObjectInterface dealloc]):

6:37 PM Changeset in webkit [171097] by dino@apple.com
  • 1 edit
    4 adds in trunk/LayoutTests

Provide some large JPEG images with EXIF orientation for subsampling tests

Reviewed by Sam Weinig.

Four images (either 3000x2000 or 2000x3000) that each have EXIF rotation
attributes that should render with an arrow pointing UP. The
orientation-rotate-0.jpg should always render correctly, even if EXIF
rotation is ignored. The others are variations on that image that were
saved in rotated form, then reverted to the correct orientation via EXIF.

  • fast/canvas/resources/orientation-rotate-0.jpg: Added.
  • fast/canvas/resources/orientation-rotate-180.jpg: Added.
  • fast/canvas/resources/orientation-rotate-90-ccw.jpg: Added.
  • fast/canvas/resources/orientation-rotate-90-cw.jpg: Added.
5:41 PM Changeset in webkit [171096] by fpizlo@apple.com
  • 29 edits
    19 adds in trunk/Source/JavaScriptCore

Allow for Int52Rep to see things other than Int32, and make this testable

Reviewed by Geoffrey Garen and Mark Hahnenberg.

A major premise of our type inference is that prediction propagation can say whatever it
wants and we'll still have valid IR after Fixup. This previously didn't work with Int52s.
We required some kind of agreement between prediction propagation and fixup over which
data flow paths were Int52 and which weren't.

It turns out that we basically had such an agreement, with the exception of code that was
unreachable due to ForceOSRExit. Then, fixup and prediction propagation would disagree. It
might be nice to fix that bug - but it's only in the case of Int52 that such a thing would
be a bug! Normally, we allow sloppiness in prediction propagation.

This patch allows us to be sloppy with Int52 prediction propagation by giving Int52Rep the
ability to see inputs other than Int32. This fixes the particular ForceOSRExit bug (see
int52-force-osr-exit-path.js for the reduced test case). To make sure that the newly
empowered Int52Rep is actually correct - in case we end up using it on paths other than
ForceOSRExit - this patch introduces an internal intrinsic called fiatInt52() that forces
us to attempt Int52 conversion on the input. This patch adds a bunch of tests that stress
this intrinsic. This means that we're now stressing Int52Rep more so than ever before!

Note that it would still be a bug for prediction propagation to ever cause us to create an
Int52Rep node for a non-Int32 input. But, this will now be a performance bug, rather than
a crash bug.

  • dfg/DFGAbstractInterpreterInlines.h:


  • dfg/DFGAbstractValue.cpp:


  • dfg/DFGByteCodeParser.cpp:


  • dfg/DFGClobberize.h:


  • dfg/DFGFixupPhase.cpp:


  • dfg/DFGGraph.h:


  • dfg/DFGNode.h:


  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGPredictionPropagationPhase.cpp:


  • dfg/DFGSafeToExecute.h:


  • dfg/DFGSpeculativeJIT.cpp:


  • dfg/DFGSpeculativeJIT.h:


  • dfg/DFGSpeculativeJIT32_64.cpp:


  • dfg/DFGSpeculativeJIT64.cpp:


  • dfg/DFGStrengthReductionPhase.cpp:


  • dfg/DFGUseKind.cpp:


  • dfg/DFGUseKind.h:


  • dfg/DFGValidate.cpp:


  • ftl/FTLCapabilities.cpp:


  • ftl/FTLIntrinsicRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:


  • jit/JITOperations.h:
  • jsc.cpp:


  • runtime/Intrinsic.h:
  • runtime/JSCJSValue.h:
  • runtime/JSCJSValueInlines.h:


  • tests/stress/dead-fiat-double-to-int52-then-exit-not-int52.js: Added.


  • tests/stress/dead-fiat-double-to-int52.js: Added.


  • tests/stress/dead-fiat-int32-to-int52.js: Added.


  • tests/stress/dead-fiat-value-to-int52-double-path.js: Added.


  • tests/stress/dead-fiat-value-to-int52-then-exit-not-double.js: Added.


  • tests/stress/dead-fiat-value-to-int52-then-exit-not-int52.js: Added.


  • tests/stress/dead-fiat-value-to-int52.js: Added.


  • tests/stress/fiat-double-to-int52-then-exit-not-int52.js: Added.


  • tests/stress/fiat-double-to-int52-then-fail-to-fold.js: Added.


  • tests/stress/fiat-double-to-int52-then-fold.js: Added.


  • tests/stress/fiat-double-to-int52.js: Added.


  • tests/stress/fiat-int32-to-int52.js: Added.


  • tests/stress/fiat-value-to-int52-double-path.js: Added.


  • tests/stress/fiat-value-to-int52-then-exit-not-double.js: Added.


  • tests/stress/fiat-value-to-int52-then-exit-not-int52.js: Added.


  • tests/stress/fiat-value-to-int52-then-fail-to-fold.js: Added.


  • tests/stress/fiat-value-to-int52-then-fold.js: Added.


  • tests/stress/fiat-value-to-int52.js: Added.


  • tests/stress/int52-force-osr-exit-path.js: Added.


5:14 PM Changeset in webkit [171095] by dino@apple.com
  • 2 edits in trunk/Source/WebKit2

[PlugIns] Check for a non-null snapshot image before trying to decode it

Reviewed by Tim Horton.

Changeset r169820 introduced a bug where we could examine the pixels of
an image (looking for solid colors) before checking if the image actually

I added a null check, and moved the code around a bit to avoid checking
for existence three times.

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::pluginSnapshotTimerFired): Check that snapshotImage exists
before trying to look at it.

5:14 PM Changeset in webkit [171094] by dbates@webkit.org
  • 2 edits
    6 adds in trunk

[iOS] Add tests to ensure CSS :active and :hover are applied when processing touch events

Reviewed by Simon Fraser.

Add a manual test to ensure that styles for CSS pseudo-class :hover aren't temporarily cleared
on the tapped element when processing a touchend as a result of finger pressing and releasing
on the same element that is initially positioned outside the visible content area.

  • ManualTests/ios/touchstart-touchend-on-same-element-should-not-clear-hover.html: Added.

Upstream tests by Andreas Kling for <rdar://problem/14324231>.

Add a DRT test to ensure that we apply the style for the CSS pseudo-class :active when
processing touch events.

  • platform/iphone-simulator/fast/events/ontouchstart-active-selector-expected.txt: Added.
  • platform/iphone-simulator/fast/events/ontouchstart-active-selector.html: Added.
5:09 PM Changeset in webkit [171093] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix 32-bit build.

  • UIProcess/Cocoa/SessionStateCoding.mm:


4:59 PM Changeset in webkit [171092] by mhahnenberg@apple.com
  • 4 edits
    1 add in trunk/Source/JavaScriptCore

Flattening dictionaries with oversize backing stores can cause crashes

Reviewed by Filip Pizlo.

The collector expects any pointers into CopiedSpace passed to copyLater are within 32 KB
of the CopiedBlock header. This was always the case except for when flattening a dictionary
caused the size of the Butterfly to decrease. This was equivalent to moving the base of the
Butterfly to higher addresses. If the object was reduced sufficiently in size, the base
would no longer be within the first 32 KB of the CopiedBlock and the next collection would
choke on the Butterfly pointer.

This patch fixes this issue by detect this situation during flattening and memmove-ing
the Butterfly down to where the old base was.

  • runtime/JSObject.cpp:


  • runtime/JSObject.h:


  • runtime/Structure.cpp:


  • tests/stress/flatten-oversize-dictionary-object.js: Added.


4:35 PM Changeset in webkit [171091] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Use the legacy session coder for encoding/decoding session state

Reviewed by Beth Dakin.

  • UIProcess/Cocoa/SessionStateCoding.mm:


4:13 PM Changeset in webkit [171090] by oliver@apple.com
  • 2 edits in trunk/Source/WebKit2

Restrict network process to remote connections

Reviewed by Geoffrey Garen.

Further restrict network client

  • Resources/SandboxProfiles/ios/com.apple.WebKit.Networking.sb:
3:32 PM Changeset in webkit [171089] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

WebVideoFullscreenInterfaceAVKit should only call the UI from main thread.

Patch by Jeremy Jones <jeremyj@apple.com> on 2014-07-14
Reviewed by Eric Carlson.

dispatch_async to the main thread before setting properties that would affect the UI.

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::setWebVideoFullscreenModel): wrap in call to dispatch_async
(WebVideoFullscreenInterfaceAVKit::setDuration): ditto
(WebVideoFullscreenInterfaceAVKit::setCurrentTime): ditto
(WebVideoFullscreenInterfaceAVKit::setRate): ditto
(WebVideoFullscreenInterfaceAVKit::setVideoDimensions): ditto
(WebVideoFullscreenInterfaceAVKit::setSeekableRanges): ditto
(WebVideoFullscreenInterfaceAVKit::setAudioMediaSelectionOptions): ditto
(WebVideoFullscreenInterfaceAVKit::setLegibleMediaSelectionOptions): ditto
(WebVideoFullscreenInterfaceAVKit::setExternalPlayback): ditto

3:22 PM Changeset in webkit [171088] by dbates@webkit.org
  • 3 edits in trunk/Tools

check-webkit-style should apply C++ rules to Objective-C++ files

Reviewed by Joseph Pecoraro.

Fixes an issue where check-webkit-style doesn't apply applicable C++ rules to
Objective-C++ files.

Currently check-webkit-style doesn't apply the following rules to Objective-C++
files: build/using_std, runtime/max_min_macros, runtime/wtf_move, readability/null.
Instead, we should teach check-webkit-style to apply these rules because, as
its name implies, an Objective-C++ file may contain C++ code.

  • Scripts/webkitpy/style/checkers/cpp.py:

(_FileState.init): Add instance variable _is_objective_cpp to track whether a file has
extension mm (i.e. an Objective-C++ file).
(_FileState.is_objective_c_or_objective_cpp): Added; returns true if the file
has extension m or mm or if the file has extension h and contains Objective-C directives.
(check_for_null): No change in behavior; don't apply rule to Objective-C++ file.
(check_identifier_name_in_declaration): Substitute _FileState.is_objective_c_or_objective_cpp() for

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_null_false_zero): Added test case for Objective-C++ file.
(WebKitStyleTest.test_max_macro): Add test case for Objective-C and Objective-C++ file.
(WebKitStyleTest.test_min_macro): Ditto.
(WebKitStyleTest.test_wtf_move): Add test case for Objective-C++ file.

3:00 PM Changeset in webkit [171087] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

ASSERT(isMainThread()) under OneShotDisplayLinkHandler

Reviewed by Simon Fraser.

  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(-[OneShotDisplayLinkHandler displayLinkFired:]):
isMainThread means the Web thread sometimes.

2:57 PM Changeset in webkit [171086] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

Fix the build.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):

  • UIProcess/API/ios/WKViewIOS.mm:

(-[WKView _frameOrBoundsChanged]):

2:42 PM Changeset in webkit [171085] by Lucas Forschler
  • 10 edits in tags/Safari-538.46.2/Source/WebKit2

Merged r171057. <rdar://problem/17295636>

2:37 PM Changeset in webkit [171084] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[UNIX] Log error description when failing to create shared memory file.

Patch by Carlos Alberto Lopez Perez <clopez@igalia.com> on 2014-07-14
Reviewed by Darin Adler.

  • Platform/unix/SharedMemoryUnix.cpp:

(WebKit::SharedMemory::create): Print the string describing the error number (errno).

2:29 PM Changeset in webkit [171083] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Fix the !ENABLE(FILTERS) && !ENABLE(CSS_FILTERS) build after r167497

Patch by Tibor Meszaros <tmeszaros.u-szeged@partner.samsung.com> on 2014-07-14
Reviewed by Darin Adler.

  • html/ImageData.cpp:
  • platform/graphics/cairo/ImageBufferCairo.cpp:
2:23 PM Changeset in webkit [171082] by Manuel Rego Casasnovas
  • 14 edits
    2 adds in trunk

[CSS Grid Layout] Support sparse in auto-placement algorithm

Reviewed by Sergio Villar Senin.

This patch implements sparse mode for auto-placement algorithm, which is
the default mode in the new grid-auto-flow syntax. It keeps track of the
auto-placement cursor in
RenderGrid::placeAutoMajorAxisItemsOnGrid() and updates it accordingly
when auto-positioned items are placed.
If we're in dense mode it resets the cursor after each item (which keeps
the old behavior that was using dense mode by default).

GridIterator has been adapted to look for empty areas from a given
position in both directions.

Test: fast/css-grid-layout/grid-auto-flow-sparse.html

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::GridIterator::GridIterator): Modify constructor to
add an optional argument for the varying index. This allows to look for
empty areas in both axis.
(WebCore::RenderGrid::placeAutoMajorAxisItemsOnGrid): Defined the
auto-placement cursor and rested after each item if we're in dense mode.
(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid): Use auto-placement
cursor to look for empty areas from the last auto-positioned item

  • rendering/RenderGrid.h: Modify placeAutoMajorAxisItemOnGrid() header

to receive the auto-placement cursor.

Test cases have been adapted accordingly, adding new cases to cover both
sparse and dense options.

  • fast/css-grid-layout/grid-auto-flow-resolution-expected.txt:
  • fast/css-grid-layout/grid-auto-flow-resolution.html:
  • fast/css-grid-layout/grid-auto-flow-sparse-expected.txt: Added.
  • fast/css-grid-layout/grid-auto-flow-sparse.html: Added.
  • fast/css-grid-layout/grid-container-change-named-grid-lines-recompute-child.html:
  • fast/css-grid-layout/grid-item-auto-placement-automatic-span-expected.txt:
  • fast/css-grid-layout/grid-item-auto-placement-automatic-span.html:
  • fast/css-grid-layout/grid-item-auto-placement-definite-span-expected.txt:
  • fast/css-grid-layout/grid-item-auto-placement-definite-span.html:
  • fast/css-grid-layout/grid-item-removal-auto-placement-update.html:
  • fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html:
  • fast/css-grid-layout/resources/grid.css:


2:22 PM Changeset in webkit [171081] by Brent Fulgham
  • 8 edits in trunk/Source/WebCore

[iOS] Some videos play as inline audio-only content

Reviewed by Eric Carlson.

Add a new 'presentationType' accessor that indicates if the media
element is playing in 'audio' mode. This can happen if a video
element plays an HLS stream that starts off in audio-only mode.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::presentationType): Added.

  • html/HTMLMediaElement.h:
  • platform/audio/MediaSession.cpp:

(WebCore::MediaSession::presentationType): Added.

  • platform/audio/MediaSession.h:
  • platform/audio/MediaSessionManager.cpp:

Use the presentationType, rather than the mediaType to control
inline playback behavior.

  • platform/audio/ios/AudioDestinationIOS.h:

(WebCore::AudioDestinationMac::presentationType): Add presentationType.

  • platform/audio/mac/AudioDestinationMac.h:

(WebCore::AudioDestinationMac::presentationType): Ditto.

2:07 PM Changeset in webkit [171080] by benjamin@webkit.org
  • 5 edits in trunk/Source/WebKit2

[iOS][WK2] On rotation, RemoteLayerTreeDrawingArea renders one extra frame at the wrong orientation

Reviewed by Tim Horton.

On animated resize, the size of the DrawingAreaProxy was changed before the layout parameters were
changed. This in turn caused the WebProcess's DrawingArea to flush the layer tree while still
at the wrong orientation.

This patch fixes the issue by making a special case for animated resize:
-While starting animated resize, _frameOrBoundsChanged can be called several times in response to

the API's client changing the WKWebView. In that case, we do not update the drawing area.

-After the "updateBlock" is executed and the size have been changed, the dynamic viewport update

is computed, the dynamicViewportSizeUpdate is sent to the WebProcess, followed by the message
DrawingArea::updateGeometry(). Since both messages are asynchronous, they are received in that
order, and the updateGeometry() is always done after the viewport configuration has been updated.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _beginAnimatedResizeWithUpdates:]):

  • UIProcess/ios/WKContentView.h:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView setMinimumSize:]): Deleted.

2:06 PM Changeset in webkit [171079] by Lucas Forschler
  • 5 edits in tags/Safari-538.46.2/Source


2:02 PM Changeset in webkit [171078] by benjamin@webkit.org
  • 3 edits in trunk/Source/WebKit2

[iOS][WK2] Fix withinEpsilon()

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-07-14
Reviewed by Darin Adler.

Move the function back to WKWebView, it is no longer needed in WKContentView.

Use the real types as input to properly verify that the two inputs are within
a small value of the 32bit floating point.

The epsilon we use is always on 32 bits float because we want to avoid doing work for changes
that would not make any difference on float.

The source of those small changes comes from the fact UIProcess does a lot of processing
on CGFloat, which are double on 64bits architecture, while the WebProcess use 32bits floating point
for scale. When we are getting updates from the WebProcess, we should ignore any small differences
caused by the computations done with less precision.

  • UIProcess/API/Cocoa/WKWebView.mm:


  • UIProcess/ios/WKContentViewInteraction.h:

(withinEpsilon): Deleted.

2:01 PM Changeset in webkit [171077] by Lucas Forschler
  • 1 copy in tags/Safari-538.46.2

New Tag.

1:55 PM Changeset in webkit [171076] by benjamin@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Remove some dead code from FTLJITFinalizer

Reviewed by Geoffrey Garen.

Not sure what that code was for...but it does not do anything :)

  • ftl/FTLJITFinalizer.cpp:

The pointer of the label is computed but never used.

  • ftl/FTLJITFinalizer.h:
  • ftl/FTLLink.cpp:

The label is never set to anything.

1:12 PM Changeset in webkit [171075] by betravis@adobe.com
  • 10 edits in trunk

[Feature Queries] Enable Feature Queries on Mac

Reviewed by Antti Koivisto.

Enable Feature Queries on Mac and resume running the
feature tests.

  • Configurations/FeatureDefines.xcconfig: Turn on


Enable Feature Queries on Mac and resume running the
feature tests.

  • Configurations/FeatureDefines.xcconfig: Turn on


Enable Feature Queries on Mac and resume running the
feature tests.

  • Configurations/FeatureDefines.xcconfig: Turn on


Enable Feature Queries on Mac and resume running the
feature tests.

  • Configurations/FeatureDefines.xcconfig: Turn on


Resume running the Feature Queries tests on Mac.

  • platform/mac/TestExpectations: Unskip the tests.
12:51 PM Changeset in webkit [171074] by hyatt@apple.com
  • 3 edits in trunk/Source/WebCore

<rdar://problem/17305458> Cannot interact with video controls in ePubs
Bug 134836 - [New Multicolumn] Crawl to check for compositing between us and the enclosingPaginationLayer

Reviewed by Dean Jackson.

The paginatedAndComposited bit being set in updateLayerPositions just didn't work, since compositing states
can change without triggering that function. This patch just gets rid of the bit and does a crawl every time
to check. This ensures that changes in compositing states don't necessitate any changes in pagination,
since the lookup will always check the current compositing state.

The new function that does this check is hasCompositedLayerInEnclosingPaginationChain.

I have been unable to reproduce this issue, and this is therefore a purely speculative fix. I have no test
case to provide because of this.

  • rendering/RenderLayer.cpp:


  • rendering/RenderLayer.h:
12:15 PM Changeset in webkit [171073] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

Move composite bounds calculation to RenderLayerBacking.

Reviewed by Darin Adler.

No change in functionality.

  • rendering/RenderLayerBacking.cpp:


  • rendering/RenderLayerCompositor.cpp: it was just proxying the calculateLayerBounds()

to the RenderLayer.
(WebCore::RenderLayerCompositor::calculateCompositedBounds): Deleted.

  • rendering/RenderLayerCompositor.h:
12:14 PM Changeset in webkit [171072] by andersca@apple.com
  • 6 edits in trunk

Make shouldKeepCurrentBackForwardListItemInList part of WKPageLoaderClientV5 to avoid breaking ABI

Reviewed by Beth Dakin.


  • UIProcess/API/C/WKPage.cpp:
  • UIProcess/API/C/WKPageLoaderClient.h:

Bump loader version number to 5.

  • TestWebKitAPI/Tests/WebKit2/ShouldKeepCurrentBackForwardListItemInList.cpp:


  • WebKitTestRunner/TestController.cpp:


11:54 AM Changeset in webkit [171071] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Fix the build.

  • platform/audio/MediaSessionManager.h:
11:31 AM Changeset in webkit [171070] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r171045): Reproducible crash on navigation in PageClientImpl::willRecordNavigationSnapshot

Reviewed by Tim Horton.

  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::navigationGestureDidBegin): nil-check m_webView. It can be nil when
the client is using WKView directly.
(WebKit::PageClientImpl::navigationGestureWillEnd): Ditto.
(WebKit::PageClientImpl::navigationGestureDidEnd): Ditto.
(WebKit::PageClientImpl::willRecordNavigationSnapshot): Ditto.

11:17 AM Changeset in webkit [171069] by eric.carlson@apple.com
  • 16 edits
    1 delete in trunk/Source

[Mac] don't enable low power audio mode on external output devices

Reviewed by Sam Weinig.

No new tests, this deals with changes to the audio hardware at runtime.

  • WebCore.xcodeproj/project.pbxproj: Remove AudioSessionListener.h.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • platform/audio/AudioHardwareListener.cpp:

(WebCore::AudioHardwareListener::AudioHardwareListener): Initialize m_outputDeviceSupportsLowPowerMode

to true on iOS.

  • platform/audio/AudioHardwareListener.h:

(WebCore::AudioHardwareListener::outputDeviceSupportsLowPowerMode): New accessor.
(WebCore::AudioHardwareListener::setHardwareActivity): New setter for derived classes.
(WebCore::AudioHardwareListener::setOutputDeviceSupportsLowPowerMode): Ditto.

Remove AudioSessionListener interface, it wasn't being used.

  • platform/audio/AudioSession.cpp:

(WebCore::AudioSession::addListener): Deleted.
(WebCore::AudioSession::removeListener): Deleted.
(WebCore::AudioSession::beganAudioInterruption): Deleted.
(WebCore::AudioSession::endedAudioInterruption): Deleted.

  • platform/audio/AudioSession.h:
  • platform/audio/AudioSessionListener.h: Removed.
  • platform/audio/MediaSessionManager.cpp:

(WebCore::MediaSessionManager::addSession): Allocate the AudioHardwareListener if necessary.
(WebCore::MediaSessionManager::removeSession): Free the AudioHardwareListener if necessary.
(WebCore::MediaSessionManager::audioOutputDeviceChanged): AudioHardwareListener client interface

called when the output device changes, call updateSessionState to make sure we are using
the correct buffer size.

  • platform/audio/MediaSessionManager.h:
  • platform/audio/ios/AudioDestinationIOS.h:
  • platform/audio/ios/AudioSessionIOS.mm:

(WebCore::AudioSessionPrivate::AudioSessionPrivate): Drive-by cleanup, remove ObjC helper object

that was used to listen for OS notifications, it is no longer used.

(-[WebAudioSessionHelper initWithCallback:]): Deleted.
(-[WebAudioSessionHelper dealloc]): Deleted.
(-[WebAudioSessionHelper interruption:]): Deleted.

  • platform/audio/mac/AudioHardwareListenerMac.cpp:

(WebCore::currentDeviceSupportsLowPowerBufferSize): New, return true only if using build-in

transport device.

(WebCore::processIsRunningPropertyDescriptor): Return reference to static AudioObjectPropertyAddress

for kAudioHardwarePropertyProcessIsRunning instead of declaring one in every method
that needs one.

(WebCore::outputDevicePropertyDescriptor): Return reference to static AudioObjectPropertyAddress

for kAudioHardwarePropertyDefaultOutputDevice.

(WebCore::AudioHardwareListenerMac::AudioHardwareListenerMac): Restructure and add audio object

listener for default output device.

(WebCore::AudioHardwareListenerMac::~AudioHardwareListenerMac): *Remove* listener audio object

property listener instead of *Adding* a new one. Remove new listener.

(WebCore::AudioHardwareListenerMac::propertyChanged): Enumerate the properties that changed,

call appropriate method.

(WebCore::AudioHardwareListenerMac::processIsRunningChanged): Renamed from setHardwareActive,


(WebCore::AudioHardwareListenerMac::outputDeviceChanged): New, call client.audioHardwareOutputDeviceChanged.
(WebCore::AudioHardwareListenerMac::setHardwareActive): Deleted, renamed processIsRunningChanged.

  • platform/audio/mac/AudioHardwareListenerMac.h:
  • platform/audio/mac/MediaSessionManagerMac.cpp:

(MediaSessionManager::updateSessionState): Only set the output buffer size to 4K when hardware

supports it.


  • PluginProcess/PluginProcess.h: Add an empty implementation of


11:11 AM Changeset in webkit [171068] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebKit2

[iOS] Throttle painting using a UI-process-side CADisplayLink

Reviewed by Simon Fraser.

Just waiting for CA to commit is insufficient to actually throttle to 60fps,
because nothing will block the main runloop from spinning.

Instead, listen to a CADisplayLink, and send didUpdate to the WebProcess
the first time it fires after we commit. This is not a guarantee that
our content is on the screen, but we don't have any way to make that guarantee yet.

This will throttle painting, rAF, etc. to the display refresh rate.

  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(-[OneShotDisplayLinkHandler initWithDrawingAreaProxy:]):
(-[OneShotDisplayLinkHandler dealloc]):
(-[OneShotDisplayLinkHandler displayLinkFired:]):
(-[OneShotDisplayLinkHandler invalidate]):
(-[OneShotDisplayLinkHandler schedule]):
(WebKit::RemoteLayerTreeDrawingAreaProxy::coreAnimationDidCommitLayers): Deleted.

10:16 AM Changeset in webkit [171067] by Bruno de Oliveira Abinader
  • 3 edits
    2 adds in trunk/LayoutTests

[css3-text] Add editing test for CSS3 Text Decoration properties

Reviewed by Darin Adler.

Adds editing layout test to verify that CSS3 Text Decoration properties
are being properly propagated.

  • editing/pasteboard/insert-text-decoration-expected.txt: Added.
  • editing/pasteboard/insert-text-decoration.html: Added.
  • platform/mac/TestExpectations: Skip while CSS3_TEXT is disabled by default.
  • platform/win/TestExpectations: Skip while CSS3_TEXT is disabled by default.
9:17 AM Changeset in webkit [171066] by mitz@apple.com
  • 6 edits in trunk/Source/WebKit2

<rdar://problem/17657391> [iOS] Networking process writes persistent credentials to the keychain

Reviewed by Sam Weinig.

Route CFNetwork’s calls to Security API through to the UI process.

  • NetworkProcess/ios/NetworkProcessIOS.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcess): Initialize SecItemShim.

  • Shared/mac/SecItemShim.cpp:

(WebKit::SecItemShim::initialize): On iOS, rather than using a shim library, supply
CFNetwork with alternate functions to call.

  • Shared/mac/SecItemShim.messages.in: Removed #if !PLATFORM(IOS).
  • UIProcess/mac/SecItemShimProxy.messages.in: Ditto.
  • config.h: Define ENABLE_SEC_ITEM_SHIM to 1 on iOS as well.
9:16 AM Changeset in webkit [171065] by dbates@webkit.org
  • 3 edits in trunk/Tools

Teach check-webkit-style to suggest WTF::move() when it sees std::move()

Reviewed by Joseph Pecoraro.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_max_min_macros): Fix up comment so that it reads well.
(check_wtf_move): Added.
(check_style): Modified to call check_wtf_move().
(CppChecker): Add category "runtime/wtf_move".

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_wtf_move): Added.

3:56 AM Changeset in webkit [171064] by jinwoo7.song@samsung.com
  • 22 edits
    3 adds in trunk/LayoutTests

[EFL] Unreviewed EFL gardening.

Rebaseline tests after r170418 and r170433.

  • platform/efl/fast/regions/repaint/japanese-rl-selection-repaint-in-regions-expected.png: Added. Rebaseline after r170418.
  • platform/efl/fast/regions/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Rebaseline after r170418.
  • platform/efl/fast/text/decorations-with-text-combine-expected.png: Rebaseline after r170418.
  • platform/efl/fast/text/decorations-with-text-combine-expected.txt: Rebaseline after r170418.
  • platform/efl/fast/text/emphasis-vertical-expected.png: Rebaseline after r170418.
  • platform/efl/fast/text/emphasis-vertical-expected.txt: Rebaseline after r170418.
  • platform/efl/fast/text/international/002-expected.png: Rebaseline after r170418.
  • platform/efl/fast/text/international/002-expected.txt: Rebaseline after r170418.
  • platform/efl/fast/text/international/text-combine-image-test-expected.png: Rebaseline after r170418.
  • platform/efl/fast/text/international/text-combine-image-test-expected.txt: Rebaseline after r170418.
  • platform/efl/fast/text/international/wrap-CJK-001-expected.png: Rebaseline after r170418.
  • platform/efl/fast/writing-mode/border-vertical-lr-expected.png: Rebaseline after r170418.
  • platform/efl/fast/writing-mode/border-vertical-lr-expected.txt: Rebaseline after r170418.
  • platform/efl/fast/writing-mode/japanese-lr-selection-expected.png: Rebaseline after r170418.
  • platform/efl/fast/writing-mode/japanese-lr-selection-expected.txt: Rebaseline after r170418.
  • platform/efl/fast/writing-mode/japanese-lr-text-expected.png: Rebaseline after r170418.
  • platform/efl/fast/writing-mode/japanese-lr-text-expected.txt: Rebaseline after r170418.
  • platform/efl/fast/writing-mode/japanese-rl-selection-expected.png: Rebaseline after r170418.
  • platform/efl/fast/writing-mode/japanese-rl-selection-expected.txt: Rebaseline after r170418.
  • platform/efl/fast/writing-mode/japanese-rl-text-expected.png: Rebaseline after r170418.
  • platform/efl/fast/writing-mode/japanese-rl-text-expected.txt: Rebaseline after r170418.
  • platform/efl/svg/W3C-SVG-1.1/filters-blend-01-b-expected.png: Rebaseline after r170433.
  • platform/efl/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Added. Rebaseline after r170433.
  • platform/efl/svg/filters/feBlend-all-blendmodes-expected.txt: Added. Rebaseline after r170433.
3:25 AM Changeset in webkit [171063] by jinwoo7.song@samsung.com
  • 2 edits in trunk/LayoutTests

[EFL] Unreviewed EFL gardening.

Remove failure expectations for tests that have been passing after r168350, r169309 and r169620.

  • platform/efl/TestExpectations:
3:07 AM Changeset in webkit [171062] by jinwoo7.song@samsung.com
  • 3 edits in trunk/LayoutTests

[EFL] Unreviewed EFL gardening.

  • platform/efl/css1/formatting_model/inline_elements-expected.png: Rebaseline after r170875.
  • platform/efl/css1/formatting_model/inline_elements-expected.txt: Rebaseline after r170875.
12:19 AM Changeset in webkit [171061] by mitz@apple.com
  • 1 edit in trunk/Source/WebKit2/ChangeLog

Added Radar link to the last ChangeLog entry

12:18 AM Changeset in webkit [171060] by mitz@apple.com
  • 4 edits in trunk/Source/WebKit2

NetworkProcess sometimes hangs under copyDefaultCredentialForProtectionSpace

Reviewed by Tim Horton.

A SecItem may have an attribute whose value is a SecAccessControlRef, which is not supported
by ArgumentCodersCF. In debug builds, trying to encode a CFDictionary containing a value of
unsupprted type causes an assertion to fail, but in release builds encoding succeeds, and
only decoding fails, in this case silently, simply not delivering the
SecItemShim::secItemResponse message.

The fix is to teach ArgumentCodersCF about SecAccessControlRef.

  • Shared/cf/ArgumentCodersCF.cpp:

(IPC::typeFromCFTypeRef): Check for the SecAccessControlRef type.
(IPC::encode): Encode the SecAccessControl serialized into CFData.
(IPC::decode): Deserialize a SecAccessControl from the decoded CFData.

  • Shared/cf/ArgumentCodersCF.h:
  • config.h: Defined HAVE_SEC_ACCESS_CONTROL.

Jul 13, 2014:

2:51 PM Changeset in webkit [171059] by benjamin@webkit.org
  • 5 edits in trunk/Source/WebCore

Remove SelectorCheckerFastPath from the style resolution algorithm

Reviewed by Antti Koivisto.

SelectorCheckerFastPath is now pure overhead because it can almost never match
if the CSS JIT was unable to compile.

  • css/ElementRuleCollector.cpp:

The "pre-filter" behind fastCheckableSelector had two parts:
1) Filtering the pseudoID.
2) Filtering on the rule hash.

The first part has been generalized (RuleDatacanMatchPseudoElement())
and moved to collectMatchingRulesForList().


  • css/RuleSet.cpp:


  • css/RuleSet.h:

(WebCore::RuleData::hasFastCheckableSelector): Deleted.

  • css/StyleResolver.cpp:
2:46 PM Changeset in webkit [171058] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove an useless check from SelectorChecker

Reviewed by Darin Adler.

  • css/SelectorChecker.cpp:

The condition of this if() branch can never be met for the mode "QueryingRules".

The next condition in that if() is "dynamicPseudo != NOPSEUDO", which implies
a pseudo element was matched prior to the current context/simple selector.
This cannot happen with QueryingRules, since we never match pseudo elements for

12:39 PM Changeset in webkit [171057] by mitz@apple.com
  • 10 edits in trunk/Source/WebKit2

<rdar://problem/17295636> [Cocoa] Include element snapshot in _WKActivatedElementInfo

Reviewed by Sam Weinig.

  • Shared/InteractionInformationAtPosition.cpp:

(WebKit::InteractionInformationAtPosition::encode): Encode the image if there is one.
(WebKit::InteractionInformationAtPosition::decode): Decode the image if there is one.

  • Shared/InteractionInformationAtPosition.h: Added an image member to the struct.
  • UIProcess/API/Cocoa/_WKActivatedElementInfo.h: Exposed the boundingRect property and added

an image property.

  • UIProcess/API/Cocoa/_WKActivatedElementInfo.mm:

(-[_WKActivatedElementInfo _initWithType:URL:location:title:rect:image:]): Added an image
parameter, which is stored in a new ivar.
(-[_WKActivatedElementInfo image]): Added this getter, which converts the ShareableBitmap
into a cached Cocoa image and returns it.

  • UIProcess/API/Cocoa/_WKActivatedElementInfoInternal.h: Added image parameter to the

initializer, removed _boundingRect property declaration from here.

  • UIProcess/ios/WKActionSheetAssistant.mm:

(-[WKActionSheetAssistant showImageSheet]): Pass the image from the position information
into the _WKActivatedElementInfo initializer.
(-[WKActionSheetAssistant showLinkSheet]): Ditto.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::snapshotNode): Added.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPositionInformation): If the element is a link or an image, store a
snapshot of it in the image member of the InteractionInformationAtPosition.

11:55 AM Changeset in webkit [171056] by bshafiei@apple.com
  • 5 edits in tags/Safari-538.43.42/Source


11:54 AM Changeset in webkit [171055] by bshafiei@apple.com
  • 1 copy in tags/Safari-538.43.42

New tag.

11:39 AM Changeset in webkit [171054] by bshafiei@apple.com
  • 5 edits in tags/Safari-538.43.41/Source


11:36 AM Changeset in webkit [171053] by bshafiei@apple.com
  • 1 copy in tags/Safari-538.43.41

New tag.

10:26 AM Changeset in webkit [171052] by fpizlo@apple.com
  • 2 edits in branches/ftlopt/Source/JavaScriptCore

Unreviewed, revert unintended change in r171051.

  • dfg/DFGCSEPhase.cpp:
10:18 AM Changeset in webkit [171051] by fpizlo@apple.com
  • 4 edits in branches/ftlopt/Source

Merge trunk r171049.

2014-07-13 Filip Pizlo <fpizlo@apple.com>

HashMap should have removeIf()

Reviewed by Sam Weinig.

Expose a new HashMap method, called removeIf(), which allows you to do an efficient
pass over the map and remove a bunch of things at once. This is used by DFG GCSE as
part of https://bugs.webkit.org/show_bug.cgi?id=134677.

  • wtf/HashMap.h: (WTF::X>::removeIf):
  • wtf/HashTable.h: (WTF::KeyTraits>::removeIf):
10:09 AM Changeset in webkit [171050] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

[Cocoa] Clean up session state API a little

Reviewed by Darin Adler.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _sessionState]):
(-[WKWebView _restoreFromSessionState:]): Deleted.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
10:03 AM Changeset in webkit [171049] by fpizlo@apple.com
  • 3 edits in trunk/Source/WTF

HashMap should have removeIf()

Reviewed by Sam Weinig.

Expose a new HashMap method, called removeIf(), which allows you to do an efficient
pass over the map and remove a bunch of things at once. This is used by DFG GCSE as
part of https://bugs.webkit.org/show_bug.cgi?id=134677.

  • wtf/HashMap.h:


  • wtf/HashTable.h:


4:28 AM Changeset in webkit [171048] by jfernandez@igalia.com
  • 3 edits in trunk/Source/WebKit2

REGRESSION(r171045) [GTK] Build broken.

Unreviewed GTK build fix after r171045.

  • UIProcess/API/gtk/PageClientImpl.cpp:


  • UIProcess/API/gtk/PageClientImpl.h:
3:35 AM Changeset in webkit [171047] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed, EFL build fix since r171045.

  • UIProcess/CoordinatedGraphics/WebView.h:

Jul 12, 2014:

11:35 PM Changeset in webkit [171046] by commit-queue@webkit.org
  • 11 edits
    12 adds in trunk

Elements with rendering disabled due to dimensions should not contribute to parent bounding box

Patch by Nikos Andronikos <nikos.andronikos-webkit@cisra.canon.com.au> on 2014-07-12
Reviewed by Dirk Schulze.

SVG elements that have rendering disabled should not contribute to any ancestor elements bounding box.
Examples of elements with rendering disabled:

  • basic shape with width <= 0 or height <= 0
  • path with no path data (d attribute missing or empty)
  • polyline or polygon element with no point data (points attribute missing or empty)

To achieve this a method (isRenderingDisabled) was added to RenderSVGShape and it's derived classes.
This is used to determine if an element is included when creating the union of child bounding boxes
in a container element.

Tests: svg/custom/GetBBox-path-nodata.html


  • rendering/svg/RenderSVGEllipse.cpp:

New method added. Checks bounding box to determine if rendering is disabled.

  • rendering/svg/RenderSVGEllipse.h:
  • rendering/svg/RenderSVGPath.cpp:

New method added. Checks bounding box to determine if rendering is disabled.

  • rendering/svg/RenderSVGPath.h:
  • rendering/svg/RenderSVGRect.cpp:

New method added. Checks bounding box to determine if rendering is disabled.

  • rendering/svg/RenderSVGRect.h:
  • rendering/svg/RenderSVGShape.h:

New method added. Always returns false so that derived classes that do not
implement this method retain the existing behaviour.

  • rendering/svg/SVGRenderSupport.cpp:

For each element potentially being included in the unioned bounding box of
a container, check isRenderingDisabled and skip that element if true.

  • rendering/svg/RenderSVGEllipse.cpp:


  • rendering/svg/RenderSVGEllipse.h:
  • rendering/svg/RenderSVGPath.cpp:


  • rendering/svg/RenderSVGPath.h:
  • rendering/svg/RenderSVGRect.cpp:


  • rendering/svg/RenderSVGRect.h:
  • rendering/svg/RenderSVGShape.h:
  • rendering/svg/SVGRenderSupport.cpp:


Test, for each element type, that when rendering is disabled, that element does not contribute
to the bounding box for an ancestor element.

Added test to ensure zero width/height polyline and polygon do contribute to ancestor bounding box.

Updated expected results for 1 existing test (shapes-rect-02-t) as this test included zero
width and zero height rects and these were previously included in the repaint rect.

  • platform/mac/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt:
  • svg/custom/GetBBox-path-nodata-expected.txt: Added.
  • svg/custom/GetBBox-path-nodata.html: Added.
  • svg/custom/GetBBox-polygon-nodata-expected.txt: Added.
  • svg/custom/GetBBox-polygon-nodata.html: Added.
  • svg/custom/GetBBox-polyline-nodata-expected.txt: Added.
  • svg/custom/GetBBox-polyline-nodata.html: Added.
  • svg/custom/getBBox-container-hiddenchild-expected.txt: Added.
  • svg/custom/getBBox-container-hiddenchild.html: Added.
  • svg/custom/getBBox-perpendicular-polygon-expected.txt: Added.
  • svg/custom/getBBox-perpendicular-polygon.svg: Added.
  • svg/custom/getBBox-perpendicular-polyline-expected.txt: Added.
  • svg/custom/getBBox-perpendicular-polyline.svg: Added.
10:51 PM Changeset in webkit [171045] by mitz@apple.com
  • 12 edits in trunk/Source/WebKit2

[Cocoa] Notify the client when a navigation snapshot is taken

Reviewed by Sam Weinig.

  • UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h: Declared new delegate method.
  • UIProcess/Cocoa/NavigationState.h:
  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::setNavigationDelegate): Initialize new flag in
(WebKit::NavigationState::willRecordNavigationSnapshot): Added. Calls the new
WKNavigationDelegate method.

  • UIProcess/PageClient.h: Declared new client function.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::willRecordNavigationSnapshot): Added. Calls the new client function.

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::willRecordNavigationSnapshot): Override that calls

  • UIProcess/mac/PageClientImpl.h:
  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::willRecordNavigationSnapshot): Ditto.

  • UIProcess/mac/ViewSnapshotStore.mm:

(WebKit::ViewSnapshotStore::recordSnapshot): Added a call to

7:37 PM Changeset in webkit [171044] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Style checker complains about namespace indentation when there is no namespace

Patch by Peter Szanka <h868064@stud.u-szeged.hu> on 2014-07-12
Reviewed by Darin Adler.

  • Scripts/webkitpy/style/checkers/cpp.py:


  • Scripts/webkitpy/style/checkers/cpp_unittest.py:


The indentation level depends on the parantheses too, to avoid false warning in case of several statements inside macros.

7:24 PM Changeset in webkit [171043] by benjamin@webkit.org
  • 2 edits in trunk/Source/WebCore

Rename selectorListContainsUncommonAttributeSelector() to selectorListContainsAttributeSelector()

Reviewed by Sam Weinig.

Unlike containsUncommonAttributeSelector(), selectorListContainsUncommonAttributeSelector() does not
evaluate the attribute for "uncommon" types.

It would be possible to change the function instead to evaluate common attributes based
on the match type and the pseudo class type. Such change would be more risky
and we would get very little benefit from it, I leave that for later if that ever becomes useful.

  • css/RuleSet.cpp:

(WebCore::selectorListContainsUncommonAttributeSelector): Deleted.

6:44 PM Changeset in webkit [171042] by gyuyoung.kim@samsung.com
  • 3 edits in trunk/Source/WebKit2

Unreviewed, fix EFL build break since r171034.

  • UIProcess/CoordinatedGraphics/WebView.h:
  • UIProcess/efl/WebContextEfl.cpp:


6:27 PM Changeset in webkit [171041] by Darin Adler
  • 2 edits in trunk/Source/WebKit2

Try to fix 32-bit Mac build.

  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::navigationGestureDidBegin): Added WK_API_ENABLED conditional.
(WebKit::PageClientImpl::navigationGestureWillEnd): Ditto.
(WebKit::PageClientImpl::navigationGestureDidEnd): Ditto.

6:09 PM Changeset in webkit [171040] by jfernandez@igalia.com
  • 3 edits in trunk/Source/WebKit2

REGRESSION(r171034) [GTK] Build broken.

Unreviewed GTK build fix.

  • UIProcess/API/gtk/PageClientImpl.cpp:


  • UIProcess/API/gtk/PageClientImpl.h:
5:54 PM Changeset in webkit [171039] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove excessive nesting from _EnumState.process_clean_line at cpp style checker

Patch by Daker Fernandes Pinheiro <daker.pinheiro@openbossa.org> on 2014-07-12
Reviewed by Darin Adler.

  • Scripts/webkitpy/style/checkers/cpp.py:


5:31 PM Changeset in webkit [171038] by brian.holt@samsung.com
  • 3 edits in trunk/Tools

Style Checker should prevent enums in bitfields

Reviewed by Darin Adler.

Added check that enums are not used as types for bitfields
and a unit test.

  • Scripts/webkitpy/style/checkers/cpp.py:


  • Scripts/webkitpy/style/checkers/cpp_unittest.py:


5:19 PM Changeset in webkit [171037] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Use braced-init-list to create one-item Vector object in insertPerformanceEntry

Patch by Zan Dobersek <zdobersek@igalia.com> on 2014-07-12
Reviewed by Darin Adler.

  • page/PerformanceUserTiming.cpp:

(WebCore::insertPerformanceEntry): Avoid wasting three lines for creating a
Vector object with just one item that in the end gets copied. Use the
braced-init-list syntax instead, leveraging Vector's std::initializer_list

5:10 PM Changeset in webkit [171036] by allan.jensen@digia.com
  • 2 edits in trunk/Source/WebCore

Memory leaks with autoLoadImages off

Reviewed by Darin Adler.

Do not emit notifyFinished for images with deferred load,
and allow deferred loads to be cancelled.

  • loader/cache/CachedResource.cpp:


4:39 PM Changeset in webkit [171035] by jfernandez@igalia.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION(r171024) [GTK] Build broken.

Unreviewed GTK build fix.

  • UIProcess/gtk/WebContextGtk.cpp:


4:32 PM Changeset in webkit [171034] by mitz@apple.com
  • 15 edits in trunk/Source/WebKit2

<rdar://problem/16020380> [Cocoa] Inform the client when back-forward navigation gestures begin and end

Reviewed by Sam Weinig.

  • UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h: Declared new WKNavigationDelegate


  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _isShowingNavigationGestureSnapshot]): Added this getter.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h: Declared new property


  • UIProcess/Cocoa/NavigationState.h:
  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::setNavigationDelegate): Initialize new flags in
(WebKit::NavigationState::navigationGestureDidBegin): Added. Calls the new
WKNavigationDelegate method.
(WebKit::NavigationState::navigationGestureWillEnd): Ditto.
(WebKit::NavigationState::navigationGestureDidEnd): Ditto.

  • UIProcess/PageClient.h: Declared new client functions.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy): Initialize new member variable.
(WebKit::WebPageProxy::navigationGestureDidBegin): Set m_isShowingNavigationGestureSnapshot
and call the new client function.
(WebKit::WebPageProxy::navigationGestureWillEnd): Call the new client function.
(WebKit::WebPageProxy::navigationGestureDidEnd): Ditto.
(WebKit::WebPageProxy::navigationGestureSnapshotWasRemoved): Clear

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::isShowingNavigationGestureSnapshot): Added this getter.

  • UIProcess/ios/PageClientImplIOS.h: Declared overrides of new client functions.
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::navigationGestureDidBegin): Override that calls the new
NavigationState function.
(WebKit::PageClientImpl::navigationGestureWillEnd): Ditto.
(WebKit::PageClientImpl::navigationGestureDidEnd): Ditto.

  • UIProcess/ios/ViewGestureControllerIOS.mm:

(WebKit::ViewGestureController::beginSwipeGesture): Added calls to
WebPageProxy::navigationGestureDidBegin and WebPageProxy::navigationGestureWillEnd.
(WebKit::ViewGestureController::endSwipeGesture): Added calls to
(WebKit::ViewGestureController::removeSwipeSnapshot): Added call to

  • UIProcess/mac/PageClientImpl.h: Declared overrides of new client functions.
  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::navigationGestureDidBegin): Override that calls the new
NavigationState function.
(WebKit::PageClientImpl::navigationGestureWillEnd): Ditto.
(WebKit::PageClientImpl::navigationGestureDidEnd): Ditto.

  • UIProcess/mac/ViewGestureControllerMac.mm:

(WebKit::ViewGestureController::beginSwipeGesture): Added call to
(WebKit::ViewGestureController::endSwipeGesture): Added calls to
(WebKit::ViewGestureController::removeSwipeSnapshot): Added call to

3:39 PM Changeset in webkit [171033] by jer.noble@apple.com
  • 22 edits in trunk

[MSE] http/tests/media/media-source/mediasource-duration.html is failing.

Reviewed by Eric Carlson.

Fixes the following tests:

The primary change necessary to fix the mediasource-duration.html test was to add support
for delaying the completion of a seek operation until the HTMLMediaElement's readyState
rises to > HAVE_CURRENT_DATA. This is accomplished by modifying MediaSourcePrivate to have
waitForSeekCompleted() and seekCompleted() virtual methods. These are called by MediaSource
when a seek operation results in the current time moving outside the currently buffered time
ranges, and when an append operation results in the readyState changing, respectively.

A number of other drive-by fixes were necessary to get this test fully passing, as noted

Make the MediaSource the primary owner of the media's duration, rather than the MediaSourcePrivate.
Move the MediaSourcePrivateClient pointer to the MediaSourcePrivate from the MediaPlayerPrivate, so
the MediaSource's duration can be retrieved. While we're at it, do the same thing for buffered.

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::MediaSource): Initialize m_duration.
(WebCore::MediaSource::duration): Simple accessor.
(WebCore::MediaSource::setDurationInternal): Bring 'duration change algorithm' up to spec.
(WebCore::MediaSource::setReadyState): Reset m_duration on close.

  • Modules/mediasource/MediaSource.h:
  • platform/graphics/MediaSourcePrivate.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::load): Do not call setPrivateAndOpen().
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::durationDouble): Pass through to MediaSourcePrivateAVFObjC.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::buffered): Ditto.

  • platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:

(WebCore::MediaSourcePrivateAVFObjC::create): Call setPrivateAndOpen().
(WebCore::MediaSourcePrivateAVFObjC::MediaSourcePrivateAVFObjC): Set m_client.
(WebCore::MediaSourcePrivateAVFObjC::duration): Pass through to MediaSourcePrivateClient.
(WebCore::MediaSourcePrivateAVFObjC::buffered): Ditto.
(WebCore::MediaSourcePrivateAVFObjC::durationChanged): Pass through to MediaPlayerPrivateMediaSourceAVFObjC.
(WebCore::MediaSourcePrivateAVFObjC::setDuration): Deleted.

  • platform/graphics/gstreamer/MediaSourceGStreamer.cpp:

(WebCore::MediaSourceGStreamer::open): Pass in MediaSourcePrivateClient.
(WebCore::MediaSourceGStreamer::MediaSourceGStreamer): Initialize m_mediaSource.
(WebCore::MediaSourceGStreamer::durationChanged): Retrieve the duration from MediaSourcePrivateClient.
(WebCore::MediaSourceGStreamer::markEndOfStream): Remove unnecssary ASSERT.
(WebCore::MediaSourceGStreamer::unmarkEndOfStream): Ditto.
(WebCore::MediaSourceGStreamer::setDuration): Deleted.

  • platform/graphics/gstreamer/MediaSourceGStreamer.h:
  • platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::MockMediaPlayerMediaSource::load): Do not call setPrivateAndOpen().
(WebCore::MockMediaPlayerMediaSource::buffered): Pass through to MockMediaSourcePrivate.
(WebCore::MockMediaPlayerMediaSource::durationDouble): Ditto.
(WebCore::MockMediaPlayerMediaSource::advanceCurrentTime): Ditto.

  • platform/mock/mediasource/MockMediaSourcePrivate.cpp:

(WebCore::MockMediaSourcePrivate::create): Call setPrivateAndOpen().
(WebCore::MockMediaSourcePrivate::MockMediaSourcePrivate): Set m_client.
(WebCore::MockMediaSourcePrivate::duration): Pass through to MediaSourcePrivateClient.
(WebCore::MockMediaSourcePrivate::buffered): Ditto.
(WebCore::MockMediaSourcePrivate::durationChanged): Pass thorugh to MockMediaPlayerMediaSource.
(WebCore::MockMediaSourcePrivate::setDuration): Deleted.

Route seekToTime through MediaSource, rather than through MediaSourcePrivate, so that
the time can be compared against the buffered ranges, and trigger the delay of the seek
operation if necessary. Add a seekTimer to MediaPlayerPrivateMediaSourceAVFObjC, as this
guarantees the order of asynchronous operations, rather than callOnMainThread, which can
cause async operations to occur out of order.

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::seekToTime): Bring up to spec.
(WebCore::MediaSource::completeSeek): Ditto.
(WebCore::MediaSource::monitorSourceBuffers): Call completeSeek() when appropriate.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateSeekToTime): Deleted.
(WebCore::SourceBuffer::seekToTime): Renamed from sourceBufferPrivateSeekToTime().

  • platform/graphics/MediaSourcePrivate.h:
  • platform/graphics/MediaSourcePrivateClient.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC): Add seekTimer. Only

call timeChanged() if no longer seeking, thereby triggering a 'seeked' event.

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::~MediaPlayerPrivateMediaSourceAVFObjC): Clear m_seekTimer.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekWithTolerance): Use m_seekTimer.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekTimerFired): Call seekInternal.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal): Add logging.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::waitForSeekCompleted): Added.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekCompleted): Added; trigger 'seeked'.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setReadyState): No longer attempt to finish seek when

readyState changes here; this has been moved up to MediaSource.cpp.

  • platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:

(WebCore::MediaSourcePrivateAVFObjC::waitForSeekCompleted): Pass through to MediaPlayerPrivateMediaSourceAVFObjC.
(WebCore::MediaSourcePrivateAVFObjC::seekCompleted): Ditto.
(WebCore::MediaSourcePrivateAVFObjC::seekToTime): Pass through to MediaSourcePrivateClient.
(WebCore::MediaSourcePrivateAVFObjC::fastSeekTimeForMediaTime): Ditto.

  • platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::MockMediaPlayerMediaSource::MockMediaPlayerMediaSource): Initialize m_seekCompleted.
(WebCore::MockMediaPlayerMediaSource::seeking): Check for an uncompleted seek operation.
(WebCore::MockMediaPlayerMediaSource::seekWithTolerance): Ditto.
(WebCore::MockMediaPlayerMediaSource::waitForSeekCompleted): Added.
(WebCore::MockMediaPlayerMediaSource::seekCompleted): Added; trigger 'seeked'.

  • platform/mock/mediasource/MockMediaPlayerMediaSource.h:
  • platform/mock/mediasource/MockMediaSourcePrivate.cpp:

(WebCore::MockMediaSourcePrivate::waitForSeekCompleted): Pass through to MockMediaPlayerMediaSource.
(WebCore::MockMediaSourcePrivate::seekCompleted): Ditto.

  • platform/mock/mediasource/MockMediaSourcePrivate.h:

Drive-by fixes.

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::streamEndedWithError): Re-order the steps in streamEndedWithError()

to avoid the MediaSource being closed and re-opened by the resulting duration change

  • Modules/mediasource/MediaSource.h:
  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::remove): Added logging.
(WebCore::SourceBuffer::removeCodedFrames): Ditto.
(WebCore::SourceBuffer::hasFutureTime): Swap an ASSERT for an early-return; it's possible

for currentTime() to be outside of a buffered area.

  • Modules/mediasource/SourceBuffer.h:
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute): Do not issue an additional 'timeupdate' event

after finishSeek() issues one of its own.

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::globalDataParserQueue): Allow parsing operations to happen concurrently on

background queues.

Eliminate flakiness in the mediasource-duration.html test by not playing
the media while testing seeking and duration.

  • http/tests/media/media-source/mediasource-duration.html:

Update testharness.js to the latest W3C version:

  • http/tests/w3c/resources/testharness.js:
3:14 PM Changeset in webkit [171032] by eric.carlson@apple.com
  • 3 edits in trunk/Source/WebCore

[iOS] update control type when playback state changes

Reviewed by Dean Jackson.

Check to make sure the correct type of media controls are showing when playback state
changes so we don't end up with the wrong type of controls during playback.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.HandledVideoEvents): Drive-by fix, call handlePlay on 'playing' instead

of 'play' so controls don't hide too early.

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.setPlaying): New, call updateControls to make sure inline

controls are shown when appropriate.

2:55 PM Changeset in webkit [171031] by bshafiei@apple.com
  • 2 edits in tags/Safari-538.46.1/Source/WebKit2

Merged r171030.

2:49 PM Changeset in webkit [171030] by oliver@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix typo in prior patch

Reviewed by Sam Weinig.

Fix typo

  • UIProcess/mac/WebContextMac.mm:


2:36 PM Changeset in webkit [171029] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS Media] Start playback button should indicate when it can't play

Post-commit review with Eric Carlson on IRC.

  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.updateStatusDisplay): Remove the line that sets the
class on the inline play button.

2:17 PM Changeset in webkit [171028] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

[iOS Media] Start playback button should indicate when it can't play

Reviewed by Sam Weinig.

If a video element has errors and cannot play, then the start
playback button should use the "broken" icon.

  • Modules/mediacontrols/mediaControlsApple.js: Add a new "failed" class.
  • Modules/mediacontrols/mediaControlsiOS.js:

(ControllerIOS.prototype.shouldHaveStartPlaybackButton): We need a playback button
even when there is an error.
(ControllerIOS.prototype.handleWirelessPickerButtonTouchStart): Don't offer Airplay
if we're in an error state.
(ControllerIOS.prototype.updateStatusDisplay): Set the "failed" class on
the playback buttons if we are in an error state.

1:40 PM Changeset in webkit [171027] by mitz@apple.com
  • 10 edits in trunk/Source/WebKit2

[Cocoa] Client is not notified of same-document navigations

Reviewed by Sam Weinig.

  • UIProcess/API/APILoaderClient.h:

(API::LoaderClient::didSameDocumentNavigationForFrame): Added navigationID parameter.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageLoaderClient): Ditto.

  • UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h: Added new enum and delegate method.
  • UIProcess/Cocoa/NavigationState.h: Declare override of

API::LoaderClient::didSameDocumentNavigationForFrame. Added flag in
m_navigationDelegateMethods struct.

  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::setNavigationDelegate): Initialize new m_navigationDelegateMethods
(WebKit::toWKSameDocumentNavigationType): Added this helper to convert from internal to API
(WebKit::NavigationState::LoaderClient::didSameDocumentNavigationForFrame): Override to call
the delegate method, if implemented.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didSameDocumentNavigationForFrame): Added navigationID parameter,
which is forwarded to the client.

  • UIProcess/WebPageProxy.h: Added navigationID parameter.
  • UIProcess/WebPageProxy.messages.in: Ditto.
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidChangeLocationWithinPage): Send the navigation ID.
(WebKit::WebFrameLoaderClient::dispatchDidPushStateWithinPage): Ditto.
(WebKit::WebFrameLoaderClient::dispatchDidReplaceStateWithinPage): Ditto.
(WebKit::WebFrameLoaderClient::dispatchDidPopStateWithinPage): Ditto.

12:10 PM Changeset in webkit [171026] by bshafiei@apple.com
  • 8 edits in tags/Safari-538.46.1/Source/WebKit2

Merged r171024.

12:02 PM Changeset in webkit [171025] by bshafiei@apple.com
  • 2 edits in tags/Safari-538.46.1/Source/WebKit2

Merged r171023.

11:33 AM Changeset in webkit [171024] by oliver@apple.com
  • 8 edits in trunk/Source/WebKit2

Extend WebContent sandbox to allow some extra access for frameworks

Reviewed by Sam Weinig.

Open up the webcontent sandbox a bit so that some external frameworks
can work correctly.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
  • Shared/WebProcessCreationParameters.cpp:


  • Shared/WebProcessCreationParameters.h:
  • UIProcess/WebContext.cpp:


  • UIProcess/WebContext.h:
  • UIProcess/mac/WebContextMac.mm:


  • WebProcess/cocoa/WebProcessCocoa.mm:


11:32 AM Changeset in webkit [171023] by oliver@apple.com
  • 2 edits in trunk/Source/WebKit2

Temporary work around for <rdar://<rdar://problem/17513375>

Reviewed by Sam Weinig.

Temporarily work around <rdar://<rdar://problem/17513375> by
dropping the explicit cookie storage if it points out of the

  • UIProcess/mac/WebContextMac.mm:


11:13 AM Changeset in webkit [171022] by bshafiei@apple.com
  • 5 edits in tags/Safari-538.46.1/Source


11:07 AM Changeset in webkit [171021] by bshafiei@apple.com
  • 1 copy in tags/Safari-538.46.1

New tag.

Jul 11, 2014:

10:08 PM Changeset in webkit [171020] by benjamin@webkit.org
  • 4 edits in trunk/Source/WebCore

Partition the CSS rules based on the most specific filter of the rightmost fragment

Reviewed by Andreas Kling.

Previously, RuleSet was partitioning each rule based on the rightmost filter.
While fast, this had the side effect of putting many selectors with ID match in the class
bucket (because the selectors are generally written starting with the ID).

This patch replace the code of findBestRuleSetAndAdd() by a simple loop going over all
the simple selectors in the rightmost fragment to find the best bucket.

  • css/ElementRuleCollector.cpp:


  • css/RuleSet.cpp:

I unified ruleData.hasRightmostSelectorMatchingHTMLBasedOnRuleHash() and hasMultipartSelector().

I removed the recursive part of findBestRuleSetAndAdd() (which was wrong anyway). The function
was useless so I just moved the algorithm to addRule() directly.

We first loop over all the CSSSelectors related by SubSelector, this correspond to the rightmost fragment.
If a filter with high specificity is found, we add the rule immediately and end there.
If a filter that is not very specific is found, we keep a pointer to the selector to use it later.

(WebCore::RuleSet::findBestRuleSetAndAdd): Deleted.

  • css/RuleSet.h:

(WebCore::RuleData::hasMultipartSelector): Deleted.

8:54 PM Changeset in webkit [171019] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

[WinCairo] Unreviewed build fix after r170937.

  • WebCore.vcxproj/WebCoreGeneratedWinCairo.make:

Update and apply changes applied to WebCoreGenerated.make in r170937.

6:49 PM Changeset in webkit [171018] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Web Inspector: Crash when using a stale InspectableNode Node

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-11
Reviewed by Timothy Hatcher.

  • inspector/PageConsoleAgent.cpp:
5:53 PM Changeset in webkit [171017] by jer.noble@apple.com
  • 5 edits in trunk/Source/WebCore

[MSE] Separate MediaSource logging into its own log channel

Reviewed by Eric Carlson.

Separate out MediaSource logging (which can be quite verbose) into its own log channel,
distinct from the Media log channel. Add some per-sample logging and further sequester that
logging into its own MediaSourceSamples log channel.

Add the MediaSource and MediaSourceSamples channels:

  • platform/Logging.h:

Move LOG(Media) -> LOG(MediaSource):

  • Modules/mediasource/MediaSource.cpp:


  • Modules/mediasource/SourceBuffer.cpp:


  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:


4:54 PM Changeset in webkit [171016] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Phone numbers that span two lines are not detected.
<rdar://problem/17601146> and https://bugs.webkit.org/show_bug.cgi?id=134808

Reviewed by Tim Horton.

  • editing/Editor.cpp:

(WebCore::Editor::scanSelectionForTelephoneNumbers): After scanning a range from the TextIterator,

create an "edge range" window around the end of the TextIterator range, and scan it.
Also make sure to not accumulate duplicate ranges that might have showed up in both the
TextIterator range and the edge window range.

4:24 PM Changeset in webkit [171015] by enrica@apple.com
  • 8 edits in trunk/Source

Implement textStylingAtPosition in WK2.


Reviewed by Benjamin Poulain.

Adding some exports and making styleForSelectionStart public.

  • WebCore.exp.in:
  • editing/Editor.h:


Reviewed by Benjamin Poulain.

Adding information about typing attributes to EditorState so
that we can implement textStylingAtPosition.

  • Shared/EditorState.cpp:


  • Shared/EditorState.h:


  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView textStylingAtPosition:inDirection:]):
(-[WKContentView canPerformAction:withSender:]):
(-[WKContentView toggleBoldface:]):
(-[WKContentView toggleItalics:]):
(-[WKContentView toggleUnderline:]):

  • WebProcess/WebPage/WebPage.cpp:


3:36 PM Changeset in webkit [171014] by Alan Bujtas
  • 9 edits
    2 adds in trunk

REGRESSION (r168868): eBay 'see all' links fail due to different JS bindings conversion behavior.

Reviewed by Simon Fraser.

Revert back to type int for Element.scroll* APIs in order to preserve exception handling

Test: cssom/non-subpixel-scroll-top-left-values.html

  • dom/Element.cpp:


  • dom/Element.h:
  • dom/Element.idl:
  • html/HTMLBodyElement.cpp:


  • html/HTMLBodyElement.h:


  • cssom/non-subpixel-scroll-top-left-values-expected.txt: Added.
  • cssom/non-subpixel-scroll-top-left-values.html: Added.
2:54 PM Changeset in webkit [171013] by Joseph Pecoraro
  • 9 edits in trunk/Source

Web Inspector: Debugger Pause button does not work

Reviewed by Timothy Hatcher.


  • CMakeLists.txt:
  • DerivedSources.make:

Minification strips the sourceURL command. Add it back with minification.


  • CMakeLists.txt:
  • DerivedSources.make:
  • inspector/CommandLineAPIModuleSource.js:

Minification strips the sourceURL command. Add it back with minification.

Previously we were automatically resuming if we had no recognized
call frames in the call stack we get when paused. However, we
were accidentally skipping over anonymous scripts instead of
just Web Inspector originated call frames.

Now that we allow anonymous scripts we can step into anonymous
scripts (e.g. evals, new Function(...)) as expected.

Also, remove the condition of automatically resuming if the
call stack was empty. The UI handles this with "No Call Frames".

  • UserInterface/Controllers/DebuggerManager.js:


2:10 PM Changeset in webkit [171012] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

Use the bare minimum tile coverage rect when under memory pressure.

When the browser is under critical memory pressure, don't generate any
more tiles than are needed to cover the exposed viewport rect.

Reviewed by Pratik Solanki.

  • page/FrameView.cpp:


2:04 PM Changeset in webkit [171011] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: CSS Autocompletion: "background" only has colors, should support others

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-07-11
Reviewed by Timothy Hatcher.

Update and consolidate the background related CSS properties
and include sub-property completions in the shorthand property.

Also take the opportunity to add or update other properties
(-webkit-alt, -webkit-text-decoration-skip, -webkit-aspect-ratio)
and remove unnecessary newlines / commas in the list.

  • UserInterface/Models/CSSKeywordCompletions.js:
1:26 PM Changeset in webkit [171010] by jfernandez@igalia.com
  • 13 edits
    2 adds in trunk

[CSS Grid Layout] Implement justify-self css property

Reviewed by Dean Jackson.

This change adds the justify-self property from CSS 3 Box Alignment
and implements the parsing.

From Blink r164685 by <jchaffraix@chromium.org>

Test: fast/css/parse-justify-self.html

  • css/CSSComputedStyleDeclaration.cpp:


  • css/CSSParser.cpp:


  • css/CSSParser.h:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator EJustifySelf):
(WebCore::CSSPrimitiveValue::operator EJustifySelfOverflowAlignment):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/DeprecatedStyleBuilder.cpp:


  • css/StyleResolver.cpp:


  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:
  • rendering/style/StyleRareNonInheritedData.cpp:


  • rendering/style/StyleRareNonInheritedData.h:


  • fast/css/parse-justify-self-expected.txt: Added.
  • fast/css/parse-justify-self.html: Added.
12:47 PM Changeset in webkit [171009] by Lucas Forschler
  • 6 edits in tags/Safari-538.46

Rollout r170675. <rdar://problem/17643689>.

12:00 PM Changeset in webkit [171008] by betravis@adobe.com
  • 2 edits in trunk/Source/WebCore

[Feature Queries] Feature Query CSS Grammar Productions Should Return a Value

Reviewed by Antti Koivisto.

The parsing return values are used to determine if a feature query is valid. Two
grammar productions have been updated to correctly return a value.

Tests exist for this feature but will not be run until the feature is turned on.
See https://bugs.webkit.org/show_bug.cgi?id=134404.

  • css/CSSGrammar.y.in: Adding return values for two valid feature query productions.
11:56 AM Changeset in webkit [171007] by Lucas Forschler
  • 2 edits in tags/Safari-538.46/Source/WebKit2

Merged r171003. <rdar://problem/17642184>

11:54 AM Changeset in webkit [171006] by Lucas Forschler
  • 10 edits in tags/Safari-538.46

Merged r171001. <rdar://problem/17435776>

11:53 AM Changeset in webkit [171005] by commit-queue@webkit.org
  • 7 edits in trunk/Source

[Win] Enable DFG JIT.

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-07-11
Reviewed by Mark Lam.

When the return type of a JIT generated function call is larger than 64-bit (e.g. SlowPathReturnType),
the normal call() implementation cannot be used on 64-bit Windows, because the 64-bit Windows ABI is different in this case.
Also, when generating calls with double arguments, we need to make sure the arguments are put in the correct registers,
since the register allocation differs on 64-bit Windows.

  • assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::callWithSlowPathReturnType): Added method to handle function calls where the return value type size is larger than 64-bit.

  • jit/CCallHelpers.h:

(JSC::CCallHelpers::setupArgumentsWithExecState): Move arguments to correct registers when there are floating point arguments.
(JSC::CCallHelpers::setupArgumentsWithExecStateForCallWithSlowPathReturnType): Added method.

  • jit/JIT.h:

(JSC::JIT::appendCallWithSlowPathReturnType): Added method.

  • jit/JITInlines.h:

(JSC::JIT::appendCallWithExceptionCheckAndSlowPathReturnType): Added method.
(JSC::JIT::callOperation): Call new method.


  • wtf/Platform.h:
10:32 AM Changeset in webkit [171004] by Brent Fulgham
  • 11 edits in trunk

Use a separate backdrop element to allow cues to have highlight and background color

Reviewed by Eric Carlson.

Add a new <div> element wrapping the existing cue <span>. This allows
us to have a highlight on the cue (in the <span> background), as well
as an overall background color.

  • Modules/mediacontrols/mediaControlsApple.css:

(video::-webkit-media-text-track-display-backdrop): New markup for
the backdrop element of the caption.

  • html/track/VTTCue.cpp:

(WebCore::VTTCue::cueBackdropShadowPseudoId): Added to
allow user customization of the cue backdrop.
(WebCore::VTTCue::initialize): Rename the old "m_cueBackgroundBox" to
"m_cueHighlightBox" and add a new "m_cueBackdropBox" member.
(WebCore::VTTCue::updateDisplayTree): Update for m_cueHighlightBox.
(WebCore::VTTCue::getDisplayTree): Make m_cueHighlightBox a child
of the new m_cueBackdropBox element, and add m_cueBackdropBox to
the display tree.

  • html/track/VTTCue.h:


  • page/CaptionUserPreferencesMediaAF.cpp:

Fix for missing caption style updates. Even if we are already
listening for caption changes, we still want to update the new
instance's style sheet to match.

  • rendering/RenderVTTCue.cpp:

(WebCore::RenderVTTCue::initializeLayoutParameters): Take the new
<div> into consideration when looking for the Cue text element.

Updated tests for new formatting logic.

  • platform/mac/media/track/track-cue-rendering-horizontal-expected.png:
  • platform/mac/media/track/track-cue-rendering-horizontal-expected.txt:
10:15 AM Changeset in webkit [171003] by oliver@apple.com
  • 2 edits in trunk/Source/WebKit2

Tighten WebContent sandbox

Reviewed by Sam Weinig.

Define a much tighter sandbox profile for the WebContent process

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
9:29 AM Changeset in webkit [171002] by Antti Koivisto
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r170163?): Web content shifts revealing space equivalent to the find bar when clicking a link while a phrase is targeted via Cmd+F

Reviewed by Zalan Bujtas.

Some versions of OS X Safari can't handle the new unfreeze timing. Revert back to DidFirstLayout on Mac.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:


8:27 AM Changeset in webkit [171001] by Alan Bujtas
  • 10 edits in trunk

Subpixel layout: return integral results for offset*, client*, scroll* by default.

Reviewed by Simon Fraser.

Revert to returning integral values for Element.offset* client* scroll* by default.
Fractional values break number of sites(tight design) and JS frameworks(fail to handle fractional values).

Since snapped dimension depends on both the original point and the width/height of the box,
we need to call RenderBoxModelObject::pixelSnapped*() helpers, instead of round().

Covered by existing tests


  • dom/Element.cpp:


  • page/Settings.in:


  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):


  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/C/WKPreferencesRefPrivate.h:


  • cssom/subpixel-offsetleft-top-width-height-values-expected.txt:
7:19 AM Changeset in webkit [171000] by Alan Bujtas
  • 4 edits
    2 adds in trunk

Subpixel rendering: icloud.com password arrow has clipped circle at some window sizes.

Reviewed by Simon Fraser.

Transparent layer clipping needs device pixel offset adjusting.

Test: fast/layers/wrong-clipping-semi-transparent-compositing-layer-on-subpixel-position.html

  • rendering/RenderLayer.cpp:


  • rendering/RenderLayer.h:


  • fast/layers/wrong-clipping-semi-transparent-compositing-layer-on-subpixel-position-expected.html: Added.
  • fast/layers/wrong-clipping-semi-transparent-compositing-layer-on-subpixel-position.html: Added.
5:26 AM Changeset in webkit [170999] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WTF

Unreviewed, rolling out r170995.

Causing odd crashes in debug builds (Requested by zdobersek on

Reverted changeset:

"[WTF] Add the move constructor, move assignment operator for

5:15 AM Changeset in webkit [170998] by Carlos Garcia Campos
  • 1 edit
    1 delete in trunk/Source/WebCore

Unreviewed. Remove unused file.

  • html/shadow/MediaControlsGtk.h: Removed.
5:12 AM Changeset in webkit [170997] by Carlos Garcia Campos
  • 2 edits in trunk

[GTK] Enable VIDEO_TRACK by default

Reviewed by Philippe Normand.

  • Source/cmake/OptionsGTK.cmake:
3:42 AM Changeset in webkit [170996] by Manuel Rego Casasnovas
  • 33 edits in trunk

[CSS Grid Layout] Update grid-auto-flow to the new syntax

Reviewed by Sergio Villar Senin.

In last versions of the spec grid-auto-flow syntax has changed. New
syntax is:
[ row | column ] && dense? | stack && [ row | column ]?

Implemented parsing for new syntax and added/modified test cases in
current layout tests.

For the moment, the implementation keeps working in the same way, but
using "stack" value for grid-auto-flow property instead of "none". This
should be fixed in a follow-up patch once "stack" is properly

Also "dense" needs to be reviewed. Right now auto-placement algorithm is
always "dense" and never "sparse".

No new tests, update current tests to add new cases.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue): Adapt to new syntax.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue): Removed grid-auto-flow as it
is not a keyword anymore.
(WebCore::isKeywordPropertyID): Ditto.
(WebCore::CSSParser::parseValue): Add specific method for parsing
(WebCore::CSSParser::parseGridShorthand): Adapt parsing for
grid-auto-flow property inside the shorthand.
(WebCore::isValidGridAutoFlowId): Helper method to check if the CSSValue
id is a valid keyword for grid-auto-flow property.
(WebCore::CSSParser::parseGridAutoFlow): Implement new parsing for

  • css/CSSParser.h: Method header for grid-auto-flow parsing.
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator GridAutoFlow): Deleted.
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Deleted.

  • css/CSSValueKeywords.in: Add new keywords required by grid-auto-flow:

"dense" and "stack".

  • css/DeprecatedStyleBuilder.cpp:

(WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder): Remove
default handler as grid-auto-flow is not a keyword now.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty): Implement particular handler
for new grid-auto-flow syntax.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::placeItemsOnGrid): Keep old "none" behavior as
"stack" behavior for the moment.
(WebCore::RenderGrid::autoPlacementMajorAxisDirection): Use the new
helper methods in RenderStyle.
(WebCore::RenderGrid::autoPlacementMinorAxisDirection): Ditto.

  • rendering/style/GridResolvedPosition.cpp:

(WebCore::GridResolvedPosition::resolveGridPositionsFromStyle): Again
keep old "none" behavior for "stack".

  • rendering/style/RenderStyle.h: Add new helper methods to know the

direction and algorithm of grid-auto-flow property.

  • rendering/style/RenderStyleConstants.h: Redefine GridAutoFlow enum

using flags for algorithm and direction.

  • rendering/style/StyleGridData.h: Change m_gridAutoFlow type to


Adapted current tests to the new syntax. Keeping old "none" behavior
using "stack".

Add new use cases to cover the new syntax to grid-auto-flow-get-set.html
and grid-shorthand-get-set.html.

  • fast/css-grid-layout/grid-auto-flow-get-set-expected.txt:
  • fast/css-grid-layout/grid-auto-flow-get-set.html:
  • fast/css-grid-layout/grid-auto-flow-resolution.html:
  • fast/css-grid-layout/grid-auto-flow-update-expected.txt:
  • fast/css-grid-layout/grid-auto-flow-update.html:
  • fast/css-grid-layout/grid-item-named-grid-area-resolution.html:
  • fast/css-grid-layout/grid-item-z-index-change-repaint.html:
  • fast/css-grid-layout/grid-item-z-index-stacking-context.html:
  • fast/css-grid-layout/grid-shorthand-get-set-expected.txt:
  • fast/css-grid-layout/grid-shorthand-get-set.html:
  • fast/css-grid-layout/named-grid-lines-with-named-grid-areas-dynamic-get-set.html:
  • fast/css-grid-layout/named-grid-lines-with-named-grid-areas-resolution.html:
  • fast/css-grid-layout/resources/grid.css:

(.gridAutoFlowNone): Deleted.

  • fast/css/getComputedStyle/computed-style-expected.txt:
  • fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
  • ietestcenter/css3/grid/grid-column-001.htm:
  • ietestcenter/css3/grid/grid-column-002.htm:
  • ietestcenter/css3/grid/grid-column-003.htm:
  • svg/css/getComputedStyle-basic-expected.txt:
1:16 AM Changeset in webkit [170995] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WTF

[WTF] Add the move constructor, move assignment operator for HashTable

Reviewed by Darin Adler.

HashTable has both copy constructor and copy assignment operator, meaning that the move constructor
and move assignment operator are implicitly deleted. This patch defines both to avoid unnecessary
copies when moves can be performed.

  • wtf/HashTable.h:


Note: See TracTimeline for information about the timeline view.