Timeline



Sep 25, 2014:

11:24 PM Changeset in webkit [173997] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
​https://bugs.webkit.org/show_bug.cgi?id=136854

Patch by Rohit Kumar <​kumar.rohit@samsung.com> on 2014-09-25
Reviewed by Gyuyoung Kim.

'Escape' key should exit fullscreen first and then should be used to stop page load.

  • MiniBrowser/efl/main.c:

(on_key_down):

11:03 PM Changeset in webkit [173996] by timothy@apple.com
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Show type info icon is blurry
​https://bugs.webkit.org/show_bug.cgi?id=137125

Reviewed by Darin Adler.

  • UserInterface/Images/NavigationItemTypes.svg:
  • UserInterface/Views/ScriptContentView.js:

(WebInspector.ScriptContentView):

  • UserInterface/Views/TextContentView.js:

(WebInspector.TextContentView):

  • UserInterface/Views/TextResourceContentView.js:

(WebInspector.TextResourceContentView):

10:37 PM Changeset in webkit [173995] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. Mark SVG 1.1 tests are flaky.

  • platform/efl/TestExpectations:
9:31 PM Changeset in webkit [173994] by saambarati1@gmail.com
  • 5 edits in trunk/Source

Web Inspector: console.assert(bitString) TypeSet:50
​https://bugs.webkit.org/show_bug.cgi?id=137051

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

This patch creates stricter requirements on a TypeDescription
being valid. To be valid, a TypeDescription now ensures that
the TypeSet it describes has non null type information.

  • inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):

  • runtime/TypeSet.h:

(JSC::TypeSet::isEmpty):

Source/WebInspectorUI:

This fixes TypeSet's isContainedIn method by ensuring that
the type bit string isn't zero because the test would trivially
pass if the bit string is zero.

  • UserInterface/Models/TypeSet.js:

(WebInspector.TypeSet.prototype.isContainedIn):

8:59 PM Changeset in webkit [173993] by fpizlo@apple.com
  • 51 edits
    52 adds in trunk

FTL should sink object allocations
​https://bugs.webkit.org/show_bug.cgi?id=136330

Reviewed by Oliver Hunt.
Source/JavaScriptCore:


This adds a comprehensive infrastructure for sinking object allocations in DFG SSA form. The
ultimate goal of sinking is to sink an allocation "past the points of its death" - i.e. to
eliminate it completely. The way sinking reasons about the CFG means that it resembles a
partial escape analysis: we create paths through a function where some allocation(s) don't
have to be done at all even if there are other paths along which those allocations still have
to happen. But it also produces other side benefits. Even if an allocation isn't eliminated
along any path, the act of sinking reduces the number of barriers that have to execute.

Because this was a fairly ambituous SSA analysis and transformation, I added a bunch of C++11
sugar to the DFG's internal APIs to allow for easier iteration over blocks, nodes, and
successors; and to add more functor goodness to allow for more lambdas.

This is just the beginning. The bug has a bunch of other bugs that depend on it. So far this
is a spectacular speed-up on microbenchmarks but it's still too limited to affect big
benchmarks. For example, doing o == p makes the sinking phase think that o and p escape.
That's just an omission and there are likely others; we can easily fix them. I think it's
best to land it in its current form and then to worry about the big benchmarks in subsequent
work (see bug 137126).

(JSC::StructureSet::iterator::iterator):
(JSC::StructureSet::iterator::operator*):
(JSC::StructureSet::iterator::operator++):
(JSC::StructureSet::iterator::operator==):
(JSC::StructureSet::iterator::operator!=):
(JSC::StructureSet::begin):
(JSC::StructureSet::end):

  • dfg/DFGAbstractInterpreter.h:

(JSC::DFG::AbstractInterpreter::phiChildren):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::AbstractInterpreter):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::startExecuting):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::execute):

  • dfg/DFGAvailability.h:

(JSC::DFG::Availability::shouldUseNode):
(JSC::DFG::Availability::isFlushUseful):
(JSC::DFG::Availability::isDead):
(JSC::DFG::Availability::operator!=):

  • dfg/DFGAvailabilityMap.cpp: Added.

(JSC::DFG::AvailabilityMap::prune):
(JSC::DFG::AvailabilityMap::clear):
(JSC::DFG::AvailabilityMap::dump):
(JSC::DFG::AvailabilityMap::operator==):
(JSC::DFG::AvailabilityMap::merge):

  • dfg/DFGAvailabilityMap.h: Added.

(JSC::DFG::AvailabilityMap::forEachAvailability):

  • dfg/DFGBasicBlock.cpp:

(JSC::DFG::BasicBlock::SSAData::SSAData):

  • dfg/DFGBasicBlock.h:

(JSC::DFG::BasicBlock::begin):
(JSC::DFG::BasicBlock::end):
(JSC::DFG::BasicBlock::SuccessorsIterable::SuccessorsIterable):
(JSC::DFG::BasicBlock::SuccessorsIterable::iterator::iterator):
(JSC::DFG::BasicBlock::SuccessorsIterable::iterator::operator*):
(JSC::DFG::BasicBlock::SuccessorsIterable::iterator::operator++):
(JSC::DFG::BasicBlock::SuccessorsIterable::iterator::operator==):
(JSC::DFG::BasicBlock::SuccessorsIterable::iterator::operator!=):
(JSC::DFG::BasicBlock::SuccessorsIterable::begin):
(JSC::DFG::BasicBlock::SuccessorsIterable::end):
(JSC::DFG::BasicBlock::successors):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGFlushedAt.cpp:

(JSC::DFG::FlushedAt::dump):

  • dfg/DFGFlushedAt.h:

(JSC::DFG::FlushedAt::FlushedAt):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dumpBlockHeader):
(JSC::DFG::Graph::mergeRelevantToOSR):
(JSC::DFG::Graph::invalidateCFG):

  • dfg/DFGGraph.h:

(JSC::DFG::Graph::NaturalBlockIterable::NaturalBlockIterable):
(JSC::DFG::Graph::NaturalBlockIterable::iterator::iterator):
(JSC::DFG::Graph::NaturalBlockIterable::iterator::operator*):
(JSC::DFG::Graph::NaturalBlockIterable::iterator::operator++):
(JSC::DFG::Graph::NaturalBlockIterable::iterator::operator==):
(JSC::DFG::Graph::NaturalBlockIterable::iterator::operator!=):
(JSC::DFG::Graph::NaturalBlockIterable::iterator::findNext):
(JSC::DFG::Graph::NaturalBlockIterable::begin):
(JSC::DFG::Graph::NaturalBlockIterable::end):
(JSC::DFG::Graph::blocksInNaturalOrder):
(JSC::DFG::Graph::doToChildrenWithNode):
(JSC::DFG::Graph::doToChildren):

  • dfg/DFGHeapLocation.cpp:

(WTF::printInternal):

  • dfg/DFGHeapLocation.h:
  • dfg/DFGInsertOSRHintsForUpdate.cpp: Added.

(JSC::DFG::insertOSRHintsForUpdate):

  • dfg/DFGInsertOSRHintsForUpdate.h: Added.
  • dfg/DFGInsertionSet.h:

(JSC::DFG::InsertionSet::graph):

  • dfg/DFGMayExit.cpp:

(JSC::DFG::mayExit):

  • dfg/DFGNode.h:

(JSC::DFG::Node::convertToPutByOffsetHint):
(JSC::DFG::Node::convertToPutStructureHint):
(JSC::DFG::Node::convertToPhantomNewObject):
(JSC::DFG::Node::isCellConstant):
(JSC::DFG::Node::castConstant):
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::hasStorageAccessData):
(JSC::DFG::Node::hasObjectMaterializationData):
(JSC::DFG::Node::objectMaterializationData):
(JSC::DFG::Node::isPhantomObjectAllocation):

  • dfg/DFGNodeType.h:
  • dfg/DFGOSRAvailabilityAnalysisPhase.cpp:

(JSC::DFG::OSRAvailabilityAnalysisPhase::run):
(JSC::DFG::LocalOSRAvailabilityCalculator::endBlock):
(JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):

  • dfg/DFGOSRAvailabilityAnalysisPhase.h:
  • dfg/DFGObjectAllocationSinkingPhase.cpp: Added.

(JSC::DFG::ObjectAllocationSinkingPhase::ObjectAllocationSinkingPhase):
(JSC::DFG::ObjectAllocationSinkingPhase::run):
(JSC::DFG::ObjectAllocationSinkingPhase::performSinking):
(JSC::DFG::ObjectAllocationSinkingPhase::determineMaterializationPoints):
(JSC::DFG::ObjectAllocationSinkingPhase::placeMaterializationPoints):
(JSC::DFG::ObjectAllocationSinkingPhase::lowerNonReadingOperationsOnPhantomAllocations):
(JSC::DFG::ObjectAllocationSinkingPhase::promoteSunkenFields):
(JSC::DFG::ObjectAllocationSinkingPhase::resolve):
(JSC::DFG::ObjectAllocationSinkingPhase::handleNode):
(JSC::DFG::ObjectAllocationSinkingPhase::createMaterialize):
(JSC::DFG::ObjectAllocationSinkingPhase::populateMaterialize):
(JSC::DFG::performObjectAllocationSinking):

  • dfg/DFGObjectAllocationSinkingPhase.h: Added.
  • dfg/DFGObjectMaterializationData.cpp: Added.

(JSC::DFG::PhantomPropertyValue::dump):
(JSC::DFG::ObjectMaterializationData::dump):
(JSC::DFG::ObjectMaterializationData::oneWaySimilarityScore):
(JSC::DFG::ObjectMaterializationData::similarityScore):

  • dfg/DFGObjectMaterializationData.h: Added.

(JSC::DFG::PhantomPropertyValue::PhantomPropertyValue):
(JSC::DFG::PhantomPropertyValue::operator==):

  • dfg/DFGPhantomCanonicalizationPhase.cpp:

(JSC::DFG::PhantomCanonicalizationPhase::run):

  • dfg/DFGPhantomRemovalPhase.cpp:

(JSC::DFG::PhantomRemovalPhase::run):

  • dfg/DFGPhiChildren.cpp: Added.

(JSC::DFG::PhiChildren::PhiChildren):
(JSC::DFG::PhiChildren::~PhiChildren):
(JSC::DFG::PhiChildren::upsilonsOf):

  • dfg/DFGPhiChildren.h: Added.

(JSC::DFG::PhiChildren::forAllIncomingValues):
(JSC::DFG::PhiChildren::forAllTransitiveIncomingValues):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGPrePostNumbering.cpp: Added.

(JSC::DFG::PrePostNumbering::PrePostNumbering):
(JSC::DFG::PrePostNumbering::~PrePostNumbering):
(JSC::DFG::PrePostNumbering::compute):
(WTF::printInternal):

  • dfg/DFGPrePostNumbering.h: Added.

(JSC::DFG::PrePostNumbering::preNumber):
(JSC::DFG::PrePostNumbering::postNumber):
(JSC::DFG::PrePostNumbering::isStrictAncestorOf):
(JSC::DFG::PrePostNumbering::isAncestorOf):
(JSC::DFG::PrePostNumbering::isStrictDescendantOf):
(JSC::DFG::PrePostNumbering::isDescendantOf):
(JSC::DFG::PrePostNumbering::edgeKind):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGPromoteHeapAccess.h: Added.

(JSC::DFG::promoteHeapAccess):

  • dfg/DFGPromotedHeapLocation.cpp: Added.

(JSC::DFG::PromotedLocationDescriptor::dump):
(JSC::DFG::PromotedHeapLocation::createHint):
(JSC::DFG::PromotedHeapLocation::dump):
(WTF::printInternal):

  • dfg/DFGPromotedHeapLocation.h: Added.

(JSC::DFG::PromotedLocationDescriptor::PromotedLocationDescriptor):
(JSC::DFG::PromotedLocationDescriptor::operator!):
(JSC::DFG::PromotedLocationDescriptor::kind):
(JSC::DFG::PromotedLocationDescriptor::info):
(JSC::DFG::PromotedLocationDescriptor::hash):
(JSC::DFG::PromotedLocationDescriptor::operator==):
(JSC::DFG::PromotedLocationDescriptor::operator!=):
(JSC::DFG::PromotedLocationDescriptor::isHashTableDeletedValue):
(JSC::DFG::PromotedHeapLocation::PromotedHeapLocation):
(JSC::DFG::PromotedHeapLocation::operator!):
(JSC::DFG::PromotedHeapLocation::kind):
(JSC::DFG::PromotedHeapLocation::base):
(JSC::DFG::PromotedHeapLocation::info):
(JSC::DFG::PromotedHeapLocation::descriptor):
(JSC::DFG::PromotedHeapLocation::hash):
(JSC::DFG::PromotedHeapLocation::operator==):
(JSC::DFG::PromotedHeapLocation::isHashTableDeletedValue):
(JSC::DFG::PromotedHeapLocationHash::hash):
(JSC::DFG::PromotedHeapLocationHash::equal):

  • dfg/DFGSSACalculator.cpp:

(JSC::DFG::SSACalculator::reset):

  • dfg/DFGSSACalculator.h:
  • dfg/DFGSafeToExecute.h:

(JSC::DFG::safeToExecute):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileCurrentBlock):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStructureRegistrationPhase.cpp:

(JSC::DFG::StructureRegistrationPhase::run):

  • dfg/DFGValidate.cpp:

(JSC::DFG::Validate::validate):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLExitPropertyValue.cpp: Added.

(JSC::FTL::ExitPropertyValue::dump):

  • ftl/FTLExitPropertyValue.h: Added.

(JSC::FTL::ExitPropertyValue::ExitPropertyValue):
(JSC::FTL::ExitPropertyValue::operator!):
(JSC::FTL::ExitPropertyValue::location):
(JSC::FTL::ExitPropertyValue::value):

  • ftl/FTLExitTimeObjectMaterialization.cpp: Added.

(JSC::FTL::ExitTimeObjectMaterialization::ExitTimeObjectMaterialization):
(JSC::FTL::ExitTimeObjectMaterialization::~ExitTimeObjectMaterialization):
(JSC::FTL::ExitTimeObjectMaterialization::add):
(JSC::FTL::ExitTimeObjectMaterialization::get):
(JSC::FTL::ExitTimeObjectMaterialization::dump):

  • ftl/FTLExitTimeObjectMaterialization.h: Added.

(JSC::FTL::ExitTimeObjectMaterialization::type):
(JSC::FTL::ExitTimeObjectMaterialization::properties):

  • ftl/FTLExitValue.cpp:

(JSC::FTL::ExitValue::materializeNewObject):
(JSC::FTL::ExitValue::dumpInContext):

  • ftl/FTLExitValue.h:

(JSC::FTL::ExitValue::isObjectMaterialization):
(JSC::FTL::ExitValue::objectMaterialization):
(JSC::FTL::ExitValue::withVirtualRegister):
(JSC::FTL::ExitValue::valueFormat):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCheckStructure):
(JSC::FTL::LowerDFGToLLVM::compileArrayifyToStructure):
(JSC::FTL::LowerDFGToLLVM::compilePutStructure):
(JSC::FTL::LowerDFGToLLVM::compileNewObject):
(JSC::FTL::LowerDFGToLLVM::compileMultiGetByOffset):
(JSC::FTL::LowerDFGToLLVM::compileMultiPutByOffset):
(JSC::FTL::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::LowerDFGToLLVM::compileCheckStructureImmediate):
(JSC::FTL::LowerDFGToLLVM::compileMaterializeNewObject):
(JSC::FTL::LowerDFGToLLVM::checkStructure):
(JSC::FTL::LowerDFGToLLVM::allocateCell):
(JSC::FTL::LowerDFGToLLVM::storeStructure):
(JSC::FTL::LowerDFGToLLVM::allocateObject):
(JSC::FTL::LowerDFGToLLVM::speculateStringObjectForStructureID):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::buildExitArguments):
(JSC::FTL::LowerDFGToLLVM::exitValueForAvailability):
(JSC::FTL::LowerDFGToLLVM::exitValueForNode):
(JSC::FTL::LowerDFGToLLVM::weakStructureID):
(JSC::FTL::LowerDFGToLLVM::weakStructure):
(JSC::FTL::LowerDFGToLLVM::availabilityMap):
(JSC::FTL::LowerDFGToLLVM::availability): Deleted.

  • ftl/FTLOSRExit.h:
  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileRecovery):
(JSC::FTL::compileStub):

  • ftl/FTLOperations.cpp: Added.

(JSC::FTL::operationNewObjectWithButterfly):
(JSC::FTL::operationMaterializeObjectInOSR):

  • ftl/FTLOperations.h: Added.
  • ftl/FTLSwitchCase.h:

(JSC::FTL::SwitchCase::SwitchCase):

  • runtime/JSObject.h:

(JSC::JSObject::finishCreation):
(JSC::JSFinalObject::JSFinalObject):
(JSC::JSFinalObject::create):

  • runtime/Structure.cpp:

(JSC::Structure::canUseForAllocationsOf):

  • runtime/Structure.h:
  • tests/stress/elidable-new-object-roflcopter-then-exit.js: Added.

(sumOfArithSeries):
(foo):

  • tests/stress/elide-new-object-dag-then-exit.js: Added.

(sumOfArithSeries):
(bar):
(verify):
(foo):

  • tests/stress/obviously-elidable-new-object-then-exit.js: Added.

(sumOfArithSeries):
(foo):

Source/WTF:


Make it possible to reset a Bag.

  • wtf/Bag.h:

(WTF::Bag::Bag):
(WTF::Bag::~Bag):
(WTF::Bag::clear):

LayoutTests:

  • js/math-denorm.html: Added.
  • js/regress/elidable-new-object-dag-expected.txt: Added.
  • js/regress/elidable-new-object-dag.html: Added.
  • js/regress/elidable-new-object-roflcopter-expected.txt: Added.
  • js/regress/elidable-new-object-roflcopter.html: Added.
  • js/regress/elidable-new-object-tree-expected.txt: Added.
  • js/regress/elidable-new-object-tree.html: Added.
  • js/regress/obvious-sink-pathology-expected.txt: Added.
  • js/regress/obvious-sink-pathology-taken-expected.txt: Added.
  • js/regress/obvious-sink-pathology-taken.html: Added.
  • js/regress/obvious-sink-pathology.html: Added.
  • js/regress/obviously-elidable-new-object-expected.txt: Added.
  • js/regress/obviously-elidable-new-object.html: Added.
  • js/regress/script-tests/elidable-new-object-dag.js: Added.

(sumOfArithSeries):
(foo):

  • js/regress/script-tests/elidable-new-object-roflcopter.js: Added.

(sumOfArithSeries):
(foo):

  • js/regress/script-tests/elidable-new-object-tree.js: Added.

(sumOfArithSeries):
(foo):

  • js/regress/script-tests/obvious-sink-pathology-taken.js: Added.

(sumOfArithSeries):
(bar):
(foo):

  • js/regress/script-tests/obvious-sink-pathology.js: Added.

(sumOfArithSeries):
(bar):
(foo):

  • js/regress/script-tests/obviously-elidable-new-object.js: Added.

(sumOfArithSeries):
(foo):

  • js/regress/script-tests/sinkable-new-object-dag.js: Added.

(sumOfArithSeries):
(verify):
(foo):

  • js/regress/script-tests/sinkable-new-object-taken.js: Added.

(sumOfArithSeries):
(bar):
(foo):

  • js/regress/script-tests/sinkable-new-object.js: Added.

(sumOfArithSeries):
(bar):
(foo):

  • js/regress/sinkable-new-object-dag-expected.txt: Added.
  • js/regress/sinkable-new-object-dag.html: Added.
  • js/regress/sinkable-new-object-expected.txt: Added.
  • js/regress/sinkable-new-object-taken-expected.txt: Added.
  • js/regress/sinkable-new-object-taken.html: Added.
  • js/regress/sinkable-new-object.html: Added.
7:29 PM Changeset in webkit [173992] by Brian Burg
  • 6 edits
    3 adds in trunk

Web Inspector: FunctionCall timeline records omit profile data if the debugger has paused
​https://bugs.webkit.org/show_bug.cgi?id=136805

Reviewed by Timothy Hatcher.

Source/WebCore:

TimelineAgent was mismanaging its call stack depth counter, which caused nested FunctionCall
records to steal the parent FunctionCall's captured profile in the child's didCallFunction().
Thus, the top FunctionCall node had no profile data and nested FunctionCall nodes each had
their own profiles. The frontend expected just one profile, so it didn't show anything when
it couldn't be found.

Test: inspector/timeline/debugger-paused-while-recording.html

  • inspector/InspectorTimelineAgent.cpp: Rename m_recordingProfileDepth to m_callStackDepth.

(WebCore::InspectorTimelineAgent::willCallFunction): Fix the call stack depth management.
(WebCore::InspectorTimelineAgent::didCallFunction):
(WebCore::InspectorTimelineAgent::willEvaluateScript):
(WebCore::InspectorTimelineAgent::didEvaluateScript):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):

  • inspector/InspectorTimelineAgent.h:

Source/WebInspectorUI:

  • UserInterface/Test.html: Add missing include for ScopeChainNode.js.

LayoutTests:

Add a test to see that script timeline records contain profiles even when
the debugger pauses during timeline capturing.

  • inspector/timeline/debugger-paused-while-recording-expected.txt: Added.
  • inspector/timeline/debugger-paused-while-recording.html: Added.
  • inspector/timeline/resources/timeline-helper.js: Added.

(callFunction):
(hook):

7:20 PM Changeset in webkit [173991] by Brian Burg
  • 4 edits in trunk

StorageTracker::deleteOrigin being called off the main thread (ASSERTs in inspector/test-harness-trivially-works.html test)
​https://bugs.webkit.org/show_bug.cgi?id=129642

Reviewed by Brady Eidson.

Source/WebCore:

When tearing down the inspector frontend's page, we trigger a threading violation
in StorageAreaSync's final sync code underneath StorageAreaSync::deleteEmptyDatabase().

No new tests. Regression is covered by inspector/test-harness-trivially-works.html.

  • storage/StorageAreaSync.cpp:

(WebCore::StorageAreaSync::deleteEmptyDatabase): add a missing callOnMainThread() when
calling StorageTracker::deleteOriginWithIdentifier().

LayoutTests:

Remove the blanket Skip for all tests in inspector/.

  • TestExpectations: clean up expectations for inspector/ and add new tracking bugs.
6:09 PM Changeset in webkit [173990] by Yusuke Suzuki
  • 3 edits in trunk/Source/WebKit2

Clean up unused parameter warnings
​https://bugs.webkit.org/show_bug.cgi?id=137107

Reviewed by Benjamin Poulain.

  • Scripts/webkit/messages.py:

(generate_message_handler):
Sometimes generated code doesn't use connection parameter. So UNUSED_PARAM(connection) is necessary.

  • UIProcess/API/C/WKPage.cpp:

(WKPageIsPlayingAudio):

6:00 PM Changeset in webkit [173989] by commit-queue@webkit.org
  • 12 edits in trunk

Unprefix CSS cursor values zoom-in and zoom-out.
​https://bugs.webkit.org/show_bug.cgi?id=137061

Patch by Sungmann Cho <​sungmann.cho@navercorp.com> on 2014-09-25
Reviewed by Benjamin Poulain.

Source/WebCore:

This patch unprefixes CSS cursor values zoom-in and zoom-out.
-webkit-zoom-in and -webkit-zoom-out are kept as aliases.
ECursor members use InterCaps with an initial capital letter for now.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ECursor):

  • css/CSSValueKeywords.in:
  • css/DeprecatedStyleBuilder.cpp:

(WebCore::ApplyPropertyCursor::applyValue):

  • html/ImageDocument.cpp:

(WebCore::ImageDocument::resizeImageToFit):
(WebCore::ImageDocument::restoreImageSize):
(WebCore::ImageDocument::windowSizeChanged):

  • page/EventHandler.cpp:

(WebCore::EventHandler::selectCursor):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:

LayoutTests:

Add test cases for zoom-in, zoom-out, -webkit-zoom-in, -webkit-zoom-out.

  • fast/css/cursor-parsing-expected.txt:
  • fast/css/cursor-parsing.html:
5:39 PM Changeset in webkit [173988] by Brent Fulgham
  • 57 edits in trunk/Source

[Win] Debug builds of TestWebKitAPI are crashing.
​https://bugs.webkit.org/show_bug.cgi?id=133553

Reviewed by Dean Jackson.

../WebCore:

Avoid crash on shutdown due to invalid mutex state in the
HashMap debug implementation during a static destruction operation.

  • dom/Node.cpp:

(WebCore::ignoreSet): Convert static value into a NeverDestroyed.
(WebCore::Node::trackForDebugging): Use new NeverDestroyed call.
(WebCore::Node::~Node): Ditto.

../WebKit/win:

Switch from global static HashTable to a NeverDestroyed object.
Modify all accessors of the global static to use the new
NeverDestroyed accessor method.

  • AccessibleBase.cpp:

(AccessibleBase::AccessibleBase):
(AccessibleBase::~AccessibleBase):

  • CFDictionaryPropertyBag.cpp:

(CFDictionaryPropertyBag::CFDictionaryPropertyBag):
(CFDictionaryPropertyBag::~CFDictionaryPropertyBag):

  • DefaultDownloadDelegate.cpp:

(DefaultDownloadDelegate::DefaultDownloadDelegate):
(DefaultDownloadDelegate::~DefaultDownloadDelegate):

  • DefaultPolicyDelegate.cpp:

(DefaultPolicyDelegate::DefaultPolicyDelegate):
(DefaultPolicyDelegate::~DefaultPolicyDelegate):

  • MemoryStream.cpp:

(MemoryStream::MemoryStream):
(MemoryStream::~MemoryStream):

  • WebActionPropertyBag.cpp:

(WebActionPropertyBag::WebActionPropertyBag):
(WebActionPropertyBag::~WebActionPropertyBag):

  • WebArchive.cpp:

(WebArchive::WebArchive):
(WebArchive::~WebArchive):

  • WebBackForwardList.cpp:

(WebBackForwardList::WebBackForwardList):
(WebBackForwardList::~WebBackForwardList):

  • WebCache.cpp:

(WebCache::WebCache):
(WebCache::~WebCache):

  • WebCookieManager.cpp:

(WebCookieManager::WebCookieManager):
(WebCookieManager::~WebCookieManager):

  • WebCoreStatistics.cpp:

(WebCoreStatistics::WebCoreStatistics):
(WebCoreStatistics::~WebCoreStatistics):

  • WebDataSource.cpp:

(WebDataSource::~WebDataSource):

  • WebDatabaseManager.cpp:

(WebDatabaseManager::WebDatabaseManager):
(WebDatabaseManager::~WebDatabaseManager):

  • WebDocumentLoader.cpp:

(WebDocumentLoader::WebDocumentLoader):
(WebDocumentLoader::~WebDocumentLoader):

  • WebDownload.cpp:

(WebDownload::WebDownload):
(WebDownload::~WebDownload):

  • WebDropSource.cpp:

(WebDropSource::WebDropSource):
(WebDropSource::~WebDropSource):

  • WebElementPropertyBag.cpp:

(WebElementPropertyBag::WebElementPropertyBag):
(WebElementPropertyBag::~WebElementPropertyBag):

  • WebError.cpp:

(WebError::WebError):
(WebError::~WebError):

  • WebFrame.cpp:

(WebFrame::WebFrame):
(WebFrame::~WebFrame):

  • WebFramePolicyListener.cpp:

(WebFramePolicyListener::WebFramePolicyListener):
(WebFramePolicyListener::~WebFramePolicyListener):

  • WebGeolocationPolicyListener.cpp:

(WebGeolocationPolicyListener::WebGeolocationPolicyListener):
(WebGeolocationPolicyListener::~WebGeolocationPolicyListener):

  • WebGeolocationPosition.cpp:

(WebGeolocationPosition::WebGeolocationPosition):
(WebGeolocationPosition::~WebGeolocationPosition):

  • WebHTMLRepresentation.cpp:

(WebHTMLRepresentation::WebHTMLRepresentation):
(WebHTMLRepresentation::~WebHTMLRepresentation):

  • WebHistory.cpp:

(WebHistory::WebHistory):
(WebHistory::~WebHistory):

  • WebHistoryItem.cpp:

(WebHistoryItem::WebHistoryItem):
(WebHistoryItem::~WebHistoryItem):

  • WebIconDatabase.cpp:

(WebIconDatabase::WebIconDatabase):
(WebIconDatabase::~WebIconDatabase):

(WebInspector::WebInspector):
(WebInspector::~WebInspector):

  • WebJavaScriptCollector.cpp:

(WebJavaScriptCollector::WebJavaScriptCollector):
(WebJavaScriptCollector::~WebJavaScriptCollector):

  • WebKitClassFactory.cpp:

(WebKitClassFactory::WebKitClassFactory):
(WebKitClassFactory::~WebKitClassFactory):

  • WebKitDLL.cpp: Also switch to NeverDestroyed HashTable for

the global class name count.

  • WebKitDLL.h:
  • WebKitStatistics.cpp:

(WebKitStatistics::WebKitStatistics):
(WebKitStatistics::~WebKitStatistics):
(WebKitStatistics::comClassNameCounts):

  • WebMutableURLRequest.cpp:

(WebMutableURLRequest::WebMutableURLRequest):
(WebMutableURLRequest::~WebMutableURLRequest):

  • WebNavigationData.cpp:

(WebNavigationData::WebNavigationData):
(WebNavigationData::~WebNavigationData):

  • WebNotification.cpp:

(WebNotification::WebNotification):
(WebNotification::~WebNotification):

  • WebNotificationCenter.cpp:

(WebNotificationCenter::WebNotificationCenter):
(WebNotificationCenter::~WebNotificationCenter):

  • WebPreferences.cpp:

(webPreferencesInstances):
(WebPreferences::WebPreferences):
(WebPreferences::~WebPreferences):
(WebPreferences::getInstanceForIdentifier):
(WebPreferences::setInstance):
(WebPreferences::removeReferenceForIdentifier):

  • WebResource.cpp:

(WebResource::WebResource):
(WebResource::~WebResource):

  • WebScriptObject.cpp:

(WebScriptObject::WebScriptObject):
(WebScriptObject::~WebScriptObject):

  • WebScriptWorld.cpp:

(WebScriptWorld::WebScriptWorld):
(WebScriptWorld::~WebScriptWorld):

  • WebSecurityOrigin.cpp:

(WebSecurityOrigin::WebSecurityOrigin):
(WebSecurityOrigin::~WebSecurityOrigin):

  • WebSerializedJSValue.cpp:

(WebSerializedJSValue::WebSerializedJSValue):
(WebSerializedJSValue::~WebSerializedJSValue):

  • WebTextRenderer.cpp:

(WebTextRenderer::WebTextRenderer):
(WebTextRenderer::~WebTextRenderer):

  • WebURLAuthenticationChallenge.cpp:

(WebURLAuthenticationChallenge::WebURLAuthenticationChallenge):
(WebURLAuthenticationChallenge::~WebURLAuthenticationChallenge):

  • WebURLAuthenticationChallengeSender.cpp:

(WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
(WebURLAuthenticationChallengeSender::~WebURLAuthenticationChallengeSender):

  • WebURLCredential.cpp:

(WebURLCredential::WebURLCredential):
(WebURLCredential::~WebURLCredential):

  • WebURLProtectionSpace.cpp:

(WebURLProtectionSpace::WebURLProtectionSpace):
(WebURLProtectionSpace::~WebURLProtectionSpace):

  • WebURLResponse.cpp:

(:m_refCount):
(WebURLResponse::~WebURLResponse):

  • WebUserContentURLPattern.cpp:

(WebUserContentURLPattern::WebUserContentURLPattern):
(WebUserContentURLPattern::~WebUserContentURLPattern):

  • WebView.cpp:

(pendingDeleteBackingStoreSet): Switch from a global static
value to a NeverDestroyed object wrapped by an accessor function.
(WebView::WebView): Ditto.
(WebView::~WebView): Ditto.
(WebView::deleteBackingStore): Ditto.
(WebView::deleteBackingStoreSoon): Ditto,
(WebView::cancelDeleteBackingStoreSoon): Ditto.

  • WebWorkersPrivate.cpp: Switch from a global static value for

the preferences objects t a NeverDestroyed container.
(WebWorkersPrivate::WebWorkersPrivate): Ditto.
(WebWorkersPrivate::~WebWorkersPrivate): Ditto.

5:34 PM Changeset in webkit [173987] by Chris Dumez
  • 9 edits in trunk/Source/WebCore

Add support for is<SVGDocument>() / downcast<SVGDocument>()
​https://bugs.webkit.org/show_bug.cgi?id=137128

Reviewed by Ryosuke Niwa.

Add support for is<SVGDocument>() / downcast<SVGDocument>() by using
the SPECIALIZE_TYPE_TRAITS_*() macro, instead of the
DOCUMENT_TYPE_CASTS() one.

No new tests, no behavior change.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::remoteSVGRootElement):

  • html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::getSVGDocument):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):

  • page/Frame.cpp:

(WebCore::Frame::setPageAndTextZoomFactors):

  • page/FrameView.cpp:

(WebCore::FrameView::scrollToAnchor):

  • svg/SVGDocument.h:

(WebCore::isSVGDocument):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::hasSingleSecurityOrigin):
(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::containerSize):
(WebCore::SVGImage::embeddedContentBox):
(WebCore::SVGImage::hasRelativeWidth):
(WebCore::SVGImage::hasRelativeHeight):
(WebCore::SVGImage::computeIntrinsicDimensions):
(WebCore::SVGImage::startAnimation):
(WebCore::SVGImage::stopAnimation):

5:34 PM Changeset in webkit [173986] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Win] 64-bit build fix after r173929.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
5:29 PM Changeset in webkit [173985] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed. Skip quicktime-plugin-snapshotted.html
Quicktime plugin snapshotting is now covered by all other snapshotting tests
and this test in particular seems to fail only on a few bots.

  • platform/mac/TestExpectations:
5:22 PM Changeset in webkit [173984] by roger_fong@apple.com
  • 2 edits in trunk/Source/WTF

[Windows] Unreviewed build fix. Ensure that python2.7 is used for Windows builds.

  • WTF.vcxproj/WTFGenerated.make:
5:04 PM Changeset in webkit [173983] by dino@apple.com
  • 2 edits in trunk/Tools

Add Said to the contributors list so his name completes in bugzilla.

  • Scripts/webkitpy/common/config/contributors.json:
5:03 PM Changeset in webkit [173982] by commit-queue@webkit.org
  • 5 edits in trunk

Rename CSSKeyframesRule insertRule to appendRule (57910)
​https://bugs.webkit.org/show_bug.cgi?id=57910

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2014-09-25
Reviewed by Dean Jackson.

Source/WebCore:

Tests: animations/change-keyframes.html

  • css/WebKitCSSKeyframesRule.h:

(WebCore::WebKitCSSKeyframesRule::appendRule):
-- Make WebKitCSSKeyframesRule::appendRule to be an alias of WebKitCSSKeyframesRule::insertRule()

to conform with CSS specs

  • css/WebKitCSSKeyframesRule.idl:

-- Add the new method WebKitCSSKeyframesRule::appendRule() but keep the original method

WebKitCSSKeyframesRule::appendRule() to not break exiting customers' pages.

LayoutTests:

  • animations/change-keyframes.html:

-- Ensure both WebKitCSSKeyframesRule methods insertRule() and appendRule() are

both supported.

4:49 PM Changeset in webkit [173981] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Null deref in setStateScrollingNodeSnapOffsetsAsFloat
​https://bugs.webkit.org/show_bug.cgi?id=137133
<rdar://problem/18447820>

Reviewed by Beth Dakin.

  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::AsyncScrollingCoordinator::updateOverflowScrollingNode):
Get the deviceScaleFactor from m_page instead of various other places,
because scrolledContentsLayer can be null in the case of non-composited
overflow scroll.

4:37 PM Changeset in webkit [173980] by Chris Dumez
  • 91 edits in trunk/Source

Use is<HTML*Element>() instead of isHTML*Element() - Part 2
​https://bugs.webkit.org/show_bug.cgi?id=137103

Reviewed by Benjamin Poulain.

Source/WebCore:

Use is<HTML*Element>() instead of isHTML*Element() and drop support for
the generated isHTML*Element() macros.

No new tests, no behavior change.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::focusedUIElementForPage):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::labelChanged):

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::isEnabled):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::isNativeImage):
(WebCore::AccessibilityNodeObject::anchorElement):
(WebCore::AccessibilityNodeObject::alternativeText):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::anchorElement):
(WebCore::AccessibilityRenderObject::labelElementContainer):
(WebCore::AccessibilityRenderObject::internalLinkElement):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::url):
(WebCore::AccessibilityRenderObject::getDocumentLinks):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::stringValueForMSAA):
(WebCore::AccessibilityRenderObject::isLinked):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::tableElement):
(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
(WebCore::AccessibilityTable::title):

  • accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(webkitAccessibleTableGetCaption):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::isReachableFromDOM):

  • css/CSSDefaultStyleSheets.cpp:

(WebCore::elementCanUseSimpleDefaultStyle):
(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):

  • css/CSSStyleSheet.cpp:

(WebCore::isAcceptableCSSStyleSheetParent):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

  • css/StyleSheetList.cpp:

(WebCore::StyleSheetList::getNamedItem):

  • dom/CurrentScriptIncrementer.h:

(WebCore::CurrentScriptIncrementer::CurrentScriptIncrementer):

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::setDragImage):

  • dom/DocumentOrderedMap.cpp:

(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):
(WebCore::keyMatchesLowercasedUsemap):
(WebCore::keyMatchesLabelForAttribute):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):

  • dom/Node.cpp:

(WebCore::Node::enclosingLinkEventParentOrSelf):

  • dom/Position.cpp:

(WebCore::endsOfNodeAreVisuallyDistinctPositions):

  • dom/ScriptElement.cpp:

(WebCore::toScriptElementIfPossible):

  • dom/VisitedLinkState.cpp:

(WebCore::linkHashForElement):
(WebCore::VisitedLinkState::determineLinkStateSlowCase):

  • dom/make_names.pl:

(printTypeHelpers):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::handleGeneralDelete):

  • editing/Editor.cpp:

(WebCore::imageElementFromImageDocument):

  • editing/FrameSelection.cpp:

(WebCore::scanForForm):

  • editing/InsertLineBreakCommand.cpp:

(WebCore::InsertLineBreakCommand::doApply):

  • editing/InsertParagraphSeparatorCommand.cpp:

(WebCore::InsertParagraphSeparatorCommand::doApply):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::removeHeadContents):

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverter::_processElement):

  • editing/htmlediting.cpp:

(WebCore::isNonTableCellHTMLBlockElement):

  • editing/markup.cpp:

(WebCore::ancestorToRetainStructureAndAppearanceForBlock):
(WebCore::collectElementsToRemoveFromFragment):

  • html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::findAssociatedForm):

  • html/HTMLAnchorElement.cpp:

(WebCore::appendServerMapMousePosition):

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::imageElement):

  • html/HTMLDocument.cpp:

(WebCore::HTMLDocument::bgColor):
(WebCore::HTMLDocument::setBgColor):
(WebCore::HTMLDocument::fgColor):
(WebCore::HTMLDocument::setFgColor):
(WebCore::HTMLDocument::alinkColor):
(WebCore::HTMLDocument::setAlinkColor):
(WebCore::HTMLDocument::linkColor):
(WebCore::HTMLDocument::setLinkColor):
(WebCore::HTMLDocument::vlinkColor):
(WebCore::HTMLDocument::setVlinkColor):
(WebCore::HTMLDocument::isFrameSet):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::setInnerHTML):

  • html/HTMLFieldSetElement.cpp:

(WebCore::updateFromControlElementsAncestorDisabledStateUnder):
(WebCore::HTMLFieldSetElement::disabledStateChanged):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::computeIsDisabledByFieldsetAncestor):

  • html/HTMLFormControlsCollection.cpp:

(WebCore::HTMLFormControlsCollection::HTMLFormControlsCollection):
(WebCore::HTMLFormControlsCollection::formControlElements):
(WebCore::HTMLFormControlsCollection::formImageElements):
(WebCore::HTMLFormControlsCollection::namedItem):
(WebCore::HTMLFormControlsCollection::updateNamedElementCache):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::rendererIsNeeded):

  • html/HTMLFrameElementBase.h:

(WebCore::isHTMLFrameElementBase):

  • html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::dispatchLoadEvent):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::dataList):

  • html/HTMLLegendElement.cpp:

(WebCore::HTMLLegendElement::virtualForm):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • html/HTMLNameCollection.cpp:

(WebCore::WindowNameCollection::elementMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::elementMatches):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::ownerDataListElement):
(WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
(WebCore::HTMLOptionElement::isDisabledFormControl):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::recalcListItems):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::caption):

  • html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::findParentTable):

  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::rowIndex):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::rowAfter):
(WebCore::HTMLTableRowsCollection::lastRow):

  • html/HTMLTagNames.in:
  • html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::elementMatches):

  • html/MediaDocument.cpp:

(WebCore::descendentVideoElement):
(WebCore::ancestorVideoElement):

  • html/RadioInputType.cpp:

(WebCore::RadioInputType::handleKeydownEvent):

  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::RadioNodeList):
(WebCore::RadioNodeList::checkElementMatchesRadioNodeListFilter):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::hasImpliedEndTag):
(WebCore::insert):
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::ownerDocumentForCurrentNode):

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLNames::isScopeMarker):
(WebCore::HTMLNames::isTableScopeMarker):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForNode):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::InspectorStyleSheet::inlineStyleSheetText):

  • page/DragController.cpp:

(WebCore::DragController::draggableElement):

  • page/FocusController.cpp:

(WebCore::FocusController::advanceFocusDirectionally):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

  • page/SpatialNavigation.cpp:

(WebCore::FocusCandidate::FocusCandidate):
(WebCore::areElementsOnSameLine):

  • page/ios/FrameIOS.mm:

(WebCore::ancestorRespondingToClickEvents):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::mediaSupportsFullscreen):
(WebCore::HitTestResult::mediaElement):
(WebCore::HitTestResult::enterFullscreenForVideo):
(WebCore::HitTestResult::mediaIsVideo):
(WebCore::HitTestResult::isLiveLink):

  • rendering/RenderCounter.cpp:

(WebCore::planCounter):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::RenderImage):
(WebCore::RenderImage::paintAreaElementFocusRing):
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::imageMap):
(WebCore::RenderImage::updateAltText):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::marqueeSpeed):

  • rendering/RenderMenuList.cpp:

(RenderMenuList::itemText):
(RenderMenuList::itemIsEnabled):
(RenderMenuList::itemIsLabel):

  • rendering/RenderMeter.cpp:

(WebCore::RenderMeter::meterElement):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::shouldRespectImageOrientation):
(WebCore::RenderObject::getTextDecorationColors):
(WebCore::RenderObject::offsetParent):

  • rendering/RenderProgress.cpp:

(WebCore::RenderProgress::progressElement):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::convertStyleLogicalHeightToComputedHeight):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageForRenderer):

  • testing/Internals.cpp:

(WebCore::Internals::updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):

Source/WebKit/win:

Use is<HTML*Element>() instead of isHTML*Element().

  • DOMCoreClasses.cpp:

(DOMElement::createInstance):

  • DOMHTMLClasses.cpp:

(DOMHTMLFormElement::action):
(DOMHTMLFormElement::method):

  • WebFrame.cpp:

(formElementFromDOMElement):

Source/WebKit2:

Use is<HTML*Element>() instead of isHTML*Element().

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::containsAnyFormElements):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::determinePrimarySnapshottedPlugIn):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getAssistedNodeInformation):

4:16 PM Changeset in webkit [173979] by ap@apple.com
  • 10 edits
    2 adds in trunk/Tools

EWS only repeats its cycle every two hours
​https://bugs.webkit.org/show_bug.cgi?id=137129

Reviewed by Ryosuke Niwa.

  • QueueStatusServer/app.yaml: Updated version.
  • QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
  • QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing

the patch from work items.

  • QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
  • QueueStatusServer/main.py: Added release-lock.
  • QueueStatusServer/model/activeworkitems.py:

(ActiveWorkItems.deactivate_expired): Use timeout from configuration.

  • QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,

we don't want it to be immediately picked up again, it's better to give other patches
a chance.

  • QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have

these interactive versions, but OK.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):

Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
or svn is down).

  • Scripts/webkitpy/tool/commands/queues.py:

(AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
meaning that these handlers could never do the right thing. We'd either get a duplicate
_did_fail, or try to unlock an already unlocked patch.
(StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
making it eligible for retry immediately.

  • Scripts/webkitpy/common/net/statusserver.py:

(StatusServer._post_release_lock):
(StatusServer.release_lock):
Added a call to release-lock.

2:59 PM Changeset in webkit [173978] by Brian Burg
  • 8 edits in trunk/Source

Source/JavaScriptCore:
Web Replay: Check event loop input extents during replaying too
​https://bugs.webkit.org/show_bug.cgi?id=136316

Reviewed by Timothy Hatcher.

Sometimes we see different nondeterminism during capture and replay
executions, so we should add determinism checks during replay too.

Move the withinEventLoopInputExtent flag to the base class, and tighten
the assertion to address <​http://webkit.org/b/133019>.

  • replay/InputCursor.h:

(JSC::InputCursor::InputCursor):
(JSC::InputCursor::setWithinEventLoopInputExtent): Added.
This assertion is slightly wrong because it does not account for nested run loops.
We can be within two input extents when a nested run loop processes additional
user inputs while the debugger is paused.

This should only be the case when execution is being neither captured or
replayed. The debugger should not pause when capturing, and we should not replay
event loop inputs while in a nested run loop.

(JSC::InputCursor::withinEventLoopInputExtent): Added.

Source/WebCore:
Web Replay: Check event loop input extents during replay too
​https://bugs.webkit.org/show_bug.cgi?id=136316

Reviewed by Timothy Hatcher.

Sometimes we see different nondeterminism during capture and replay
executions, so we should support determinism checks during replay too.

Move the withinEventLoopInputExtent flag to the base class.

No new tests, no behavior changed.

  • replay/CapturingInputCursor.cpp:

(WebCore::CapturingInputCursor::CapturingInputCursor):
(WebCore::CapturingInputCursor::setWithinEventLoopInputExtent): Deleted.

  • replay/CapturingInputCursor.h:
  • replay/EventLoopInput.cpp:

(WebCore::EventLoopInputExtent::EventLoopInputExtent):
(WebCore::EventLoopInputExtent::~EventLoopInputExtent):
Make m_cursor a pointer and add a new constructor so we can conditionally
enter event loop input extents. This is useful in some network replay situations.

  • replay/EventLoopInput.h:
  • replay/ReplayController.cpp:

(WebCore::ReplayController::willDispatchEvent): Expand the assertion to include replaying.

2:53 PM Changeset in webkit [173977] by Brian Burg
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: sort probe details sidebar sections by source code location string
​https://bugs.webkit.org/show_bug.cgi?id=137080

Reviewed by Timothy Hatcher.

Probe sections should display in the same order as associated breakpoint tree elements.

  • UserInterface/Views/ProbeDetailsSidebarPanel.js:

(WebInspector.ProbeDetailsSidebarPanel.prototype.inspect.inspectedProbeSets):
(WebInspector.ProbeDetailsSidebarPanel.prototype.inspect):

2:45 PM Changeset in webkit [173976] by roger_fong@apple.com
  • 2 edits in trunk/Tools

[Windows] Followup to r173972. Don’t set child process to none before reading from stdout.

  • Scripts/webkitpy/common/system/path.py:

(_CygPath.convert):

2:05 PM Changeset in webkit [173975] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Expand WK_MAC_TBA and WK_IOS_TBA to the current deployment target version (or NA).
​https://bugs.webkit.org/show_bug.cgi?id=137127
Part of rdar://problem/17761459.

Reviewed by Dan Bernstein.

  • mac/rewrite-availability-macros.sh:
1:35 PM Changeset in webkit [173974] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Race in ref pointer for WebVideoFullscreenInterfaceAVKit.
​https://bugs.webkit.org/show_bug.cgi?id=137123

Patch by Jeremy Jones <​jeremyj@apple.com> on 2014-09-25
Reviewed by Eric Carlson.

Add WebThreadRun to prevent race with RefPtr of WebVideoFullscreenInterfaceAVKit.

  • platform/ios/WebVideoFullscreenControllerAVKit.mm:

(-[WebVideoFullscreenController didSetupFullscreen]): add WebThreadRun

  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::setDuration): ditto
(WebVideoFullscreenInterfaceAVKit::setCurrentTime): ditto
(WebVideoFullscreenInterfaceAVKit::setRate): ditto
(WebVideoFullscreenInterfaceAVKit::setVideoDimensions): ditto
(WebVideoFullscreenInterfaceAVKit::setSeekableRanges): ditto
(WebVideoFullscreenInterfaceAVKit::setAudioMediaSelectionOptions): ditto
(WebVideoFullscreenInterfaceAVKit::setLegibleMediaSelectionOptions): ditto
(WebVideoFullscreenInterfaceAVKit::setExternalPlayback): ditto
(WebVideoFullscreenInterfaceAVKit::setupFullscreen): ditto
(WebVideoFullscreenInterfaceAVKit::enterFullscreen): ditto
(WebVideoFullscreenInterfaceAVKit::exitFullscreen): ditto
(WebVideoFullscreenInterfaceAVKit::cleanupFullscreen): ditto
(WebVideoFullscreenInterfaceAVKit::requestHideAndExitFullscreen): ditto

12:30 PM Changeset in webkit [173973] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

CommitLayerTree decode fails in 32-bit apps on 64-bit devices (TransformationMatrix alignment differs)
​https://bugs.webkit.org/show_bug.cgi?id=136444
<rdar://problem/17952526>

Reviewed by Anders Carlsson.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<TransformationMatrix>::encode):
(IPC::ArgumentCoder<TransformationMatrix>::decode):
Stop using SimpleArgumentCoder to encode/decode TransformationMatrix,
because the alignment of TransformationMatrix differs between architectures,
and there's no guarantee that both sides of a connection are the same architecture.

12:21 PM Changeset in webkit [173972] by roger_fong@apple.com
  • 2 edits in trunk/Tools

[Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.

  • Scripts/webkitpy/common/system/path.py:

(_CygPath.convert):

10:26 AM Changeset in webkit [173971] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed iOS build fix after r173944.

Add a missing header include.
See <rdar://problem/18454708> for more details.

  • html/parser/HTMLTreeBuilder.cpp:
10:25 AM Changeset in webkit [173970] by Chris Dumez
  • 41 edits in trunk/Source/WebCore

Stop using legacy NODE_TYPE_CASTS() macro in svg/
​https://bugs.webkit.org/show_bug.cgi?id=137106

Reviewed by Ryosuke Niwa.

Stop using legacy NODE_TYPE_CASTS() in svg/ and use the new
SPECIALIZE_TYPE_TRAITS_*() macro instead so that is<>() / downcast<>()
can be used for those types.

No new tests, no behavior change.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • dom/Element.h:
  • dom/Node.h:

(WebCore::is):

  • dom/make_names.pl:

(printTypeHelpers):

  • html/HTMLElement.h:
  • html/HTMLMediaElement.h:
  • html/HTMLPlugInImageElement.h:
  • html/LabelableElement.h:
  • mathml/MathMLElement.h:

Rename NodeTypeCastTraits::is() to NodeTypeCastTraits::isType() to
avoid naming conflict with the global is<>() function. This was an
issue when is<>() was called from one of the template specializations.

  • rendering/svg/RenderSVGBlock.h:

(WebCore::RenderSVGBlock::graphicsElement):

  • rendering/svg/RenderSVGGradientStop.cpp:

(WebCore::RenderSVGGradientStop::gradientElement):

  • rendering/svg/RenderSVGInline.h:

(WebCore::RenderSVGInline::graphicsElement):

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::pathOnlyClipping):

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):

  • rendering/svg/RenderSVGShape.h:

(WebCore::RenderSVGShape::graphicsElement):

  • rendering/svg/RenderSVGTransformableContainer.h:
  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::updateMaskedAncestorShouldIsolateBlending):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::operator<<):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

  • rendering/svg/SVGResources.cpp:

(WebCore::targetReferenceFromResource):

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler):

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::isSVGAnimateElement): Deleted.
Use is<>() / downcast<>() where appropriate.

  • svg/SVGAnimateElement.h:

(WebCore::isSVGAnimateElement):
Use SPECIALIZE_TYPE_TRAITS_*() instead of NODE_TYPE_CASTS() and add
overload for isSVGAnimateElement() taking an SVGElement in argument to
bypass the is<SVGElement>() check when the input type is an SVGElement.

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::getBoundingBox):
Use is<>() / downcast<>() where appropriate.

  • svg/SVGElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.h:

Use SPECIALIZE_TYPE_TRAITS_*() instead of NODE_TYPE_CASTS() and drop
the pre-existing NodeTypeCastTraits template specialization as it is
now generated by the macro.

  • svg/SVGGradientElement.cpp:

(WebCore::isSVGGradientElement): Deleted.

  • svg/SVGGradientElement.h:

(WebCore::isSVGGradientElement):
Use SPECIALIZE_TYPE_TRAITS_*() instead of NODE_TYPE_CASTS() and add
overload for isSVGAnimateElement() taking an SVGElement in argument to
bypass the is<SVGElement>() check when the input type is an SVGElement.

  • svg/SVGGraphicsElement.h:

(WebCore::isSVGGraphicsElement):
Use SPECIALIZE_TYPE_TRAITS_*() instead of NODE_TYPE_CASTS().

  • svg/SVGLinearGradientElement.cpp:

(WebCore::SVGLinearGradientElement::collectGradientAttributes):

  • svg/SVGLocatable.cpp:

(WebCore::SVGLocatable::getTransformToElement):

  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::synchronizePoints):
(WebCore::SVGPolyElement::lookupOrCreatePointsWrapper):
(WebCore::isSVGPolyElement): Deleted.
Use is<>() / downcast<>() where appropriate.

  • svg/SVGPolyElement.h:

(WebCore::isSVGPolyElement):
Use SPECIALIZE_TYPE_TRAITS_*() instead of NODE_TYPE_CASTS() and add
overload for isPolyElement() taking an SVGElement in argument to
bypass the is<SVGElement>() check when the input type is an SVGElement.

  • svg/SVGRadialGradientElement.cpp:

(WebCore::SVGRadialGradientElement::collectGradientAttributes):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::synchronizeTextLength):
(WebCore::SVGTextContentElement::lookupOrCreateTextLengthWrapper):
(WebCore::SVGTextContentElement::elementFromRenderer):
Use is<>() / downcast<>() where appropriate.

  • svg/SVGTextContentElement.h:

WebCore::isSVGTextContentElement):
Use SPECIALIZE_TYPE_TRAITS_*() instead of NODE_TYPE_CASTS().

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::toClipPath):
Use is<>() / downcast<>() where appropriate. Also use tighter typing
for value returned by shadowTreeElement().

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::buildPendingResource):
(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):
Use is<>() / downcast<>() where appropriate.

  • svg/animation/SVGSMILElement.h:

(WebCore::isSVGSMILElement):
Use SPECIALIZE_TYPE_TRAITS_*() instead of NODE_TYPE_CASTS() and drop
the pre-existing NodeTypeCastTraits template specialization as it is
now generated by the macro.

10:23 AM Changeset in webkit [173969] by Brent Fulgham
  • 4 edits in trunk/Source/WebCore

Minor refactoring to mediaType/presentationType
​https://bugs.webkit.org/show_bug.cgi?id=137085

Reviewed by Eric Carlson.

Add overloads for presentationType for the audio and video
HTML elements so that we don't have to explicity check the
tag name (via string comparison) to identify the type of
element.

No new tests. Should create no change in behavior.

  • html/HTMLAudioElement.h: Overload presentationType to always

indicate audio type.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaType): Use the presentationType
method implementation, rather than duplicating that code.

  • html/HTMLVideoElement.h: Overload presentationType to always

return video type.

9:17 AM Changeset in webkit [173968] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.4

Unreviewed. Update NEWS and Versions.m4 for 2.4.6 release.

.:

  • Source/autotools/Versions.m4: Bump version numbers.

Source/WebKit/gtk:

  • NEWS: Added release notes for 2.4.6.
9:11 AM Changeset in webkit [173967] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebInspectorUI

Unreviewed. Fix make distcheck.

  • GNUmakefile.am: Files in EXTRA_DIST need to be explicitly listed.
7:54 AM Changeset in webkit [173966] by berto@igalia.com
  • 2 edits in trunk/Source/WebKit2

Unreviewed typo fix.

  • UIProcess/API/C/soup/WKContextSoup.cpp:
7:50 AM Changeset in webkit [173965] by jfernandez@igalia.com
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: columnCount in WebCore::CSSParser::parseGridTemplateAreasRow
​https://bugs.webkit.org/show_bug.cgi?id=136945

Reviewed by Sergio Villar Senin.

Source/WebCore:

Checking out whether the grid-template-areas value contains a white-space only
string, which is not valid as it does not produce a cell token.

Test: fast/css-grid-layout/grid-template-areas-empty-string-crash.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseGridTemplateAreasRow):

LayoutTests:

Testing the different types of white-space only strings for the grid-template-areas
property, which is not valid as it does not produce a cell token.

  • fast/css-grid-layout/grid-template-areas-empty-string-crash-expected.txt: Added.
  • fast/css-grid-layout/grid-template-areas-empty-string-crash.html: Added.
7:45 AM Changeset in webkit [173964] by commit-queue@webkit.org
  • 4 edits in trunk

[Gtk] build.sh needs a -- before make options when the build command is cmake --build
​https://bugs.webkit.org/show_bug.cgi?id=136377

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2014-09-25
Reviewed by Philippe Normand.

.:

  • Source/cmake/OptionsGTK.cmake: Only create the build.sh script

for CMake versions less than 3.

Tools:

  • Scripts/webkitdirs.pm:

(buildCMakeGeneratedProject): Only use the build.sh script if it exists.

7:21 AM Changeset in webkit [173963] by Carlos Garcia Campos
  • 9 edits in releases/WebKitGTK/webkit-2.4/Tools

Unreviewed. Get rid of runtime warnings about deprecated properties and signals, since they break the tests.

  • TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c:

(main):

  • TestWebKitAPI/Tests/WebKitGtk/testdownload.c:

(main):

  • TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c:

(main):

  • TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c:

(main):

  • TestWebKitAPI/Tests/WebKitGtk/testloading.c:

(main):

  • TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c:

(main):

  • TestWebKitAPI/Tests/WebKitGtk/testwebresource.c:

(main):

  • TestWebKitAPI/Tests/WebKitGtk/testwebview.c:
7:05 AM Changeset in webkit [173962] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r173252 - [SOUP] Race condition when downloading a file due to the intermediate temporary file
​https://bugs.webkit.org/show_bug.cgi?id=136423

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-09-03
Reviewed by Carlos Garcia Campos.

  • Shared/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::DownloadClient): Replace m_destinationURI with
m_destinationFile and add m_createdDestination.
(WebKit::DownloadClient::deleteFilesIfNeeded): Added.
(WebKit::DownloadClient::downloadFailed): Call deleteFilesIfNeeded.
(WebKit::DownloadClient::didReceiveResponse): Attempt to create the
destination file before the intermediate file. Fail here if the file
exists and overwrite is not allowed, so we don't erroneously fire the
didCreateDestination event or waste time downloading the file when we
know the download will fail.
(WebKit::DownloadClient::didFinishLoading): Unconditionally overwrite
the empty destination file.
(WebKit::DownloadClient::cancel): Call deleteFilesIfNeeded.
(WebKit::DownloadClient::deleteIntermediateFileInNeeded): Deleted.

6:56 AM Changeset in webkit [173961] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r173154 - [SOUP] WebKitDownload cannot overwrite existing file
​https://bugs.webkit.org/show_bug.cgi?id=136322

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-09-01
Reviewed by Carlos Garcia Campos.

  • Shared/Downloads/soup/DownloadSoup.cpp:

(WebKit::DownloadClient::didReceiveResponse): pass a member variable
to Download::decideDestinationWithSuggestedFilename instead of a
temporary bool, so we can use the result in didFinishLoading.
(WebKit::DownloadClient::didFinishLoading): overwrite the destination
if Download::decideDestinationWithSuggestedFilename determined we
should do so.

6:49 AM Changeset in webkit [173960] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2

Merge r173658 - [GTK] Typo in webkit_security_manager_register_uri_scheme_as_empty_document documentation
​https://bugs.webkit.org/show_bug.cgi?id=136852

Patch by Tomas Popela <​tpopela@redhat.com> on 2014-09-16
Reviewed by Carlos Garcia Campos.

  • UIProcess/API/gtk/WebKitSecurityManager.cpp:
6:46 AM Changeset in webkit [173959] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Merge r172928 - [GStreamer] ASSERT failure in WebKitWebSource in StreamingClient
​https://bugs.webkit.org/show_bug.cgi?id=136132

adoptGRef() has an ASSERT failure if it's used on a floating pointer. For some reason,
WebKitWebSrc* src in StreamingClient's constructor is floating. Since we
don't construct this ourselves, I assume this is happening in Playbin.

If we remove the ref and adopt, GRefPtr's constructor calls gst_object_ref_sink,
which removes the floating reference and doesn't increment the reference count.
This should work, but actually causes the page to either lock up or crash (different
results for different testers).

In this case, it seems like the adoptGRef / gst_object_ref was the correct thing to do,
but adoptGRef won't actually let us do. Removing the ASSERT is a bad idea, because
usually we don't want to adopt floating pointers.

This is all a long way of saying that making m_src a raw pointer and manually
calling gst_object_ref(), and calling gst_object_unref in the destructor is the
best solution in this case, since it fixes the problem while leaving the ASSERT
to protect us in the much more common case where adopting a floating reference is bad.

Reviewed by Philippe Normand.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(StreamingClient::StreamingClient): Make m_src a raw pointer instead of a GRefPtr.
(StreamingClient::~StreamingClient): Unref m_src.
(StreamingClient::createReadBuffer): Replace m_src.get() with m_src, since it's a raw pointer now.
(StreamingClient::handleResponseReceived): Same.
(StreamingClient::handleDataReceived): Same.
(StreamingClient::handleNotifyFinished): Same.
(CachedResourceStreamingClient::notifyFinished): Same.
(ResourceHandleStreamingClient::didFail): Same.
(ResourceHandleStreamingClient::wasBlocked): Same.
(ResourceHandleStreamingClient::cannotShowURL): Same.

6:39 AM Changeset in webkit [173958] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
​https://bugs.webkit.org/show_bug.cgi?id=137117

Tools/efl/install-dependencies relies on apt-get to install packages.
Unfortunately, if a package does not exist (e.g., for a given
architecture) then apt-get install is not able to ignore the missing
package and install the rest but fails to run entirely (and there
seems to be no intent to change this behaviour).

On ARM64, the luajit package is missing and currently it needs manual
editing of install-dependencies to get the script install as much as it
can.

This patch separates the installation of the universally available
packages from those which might not be available for all architectures.

Patch by Akos Kiss <​akiss@inf.u-szeged.hu> on 2014-09-25
Reviewed by Gyuyoung Kim.

  • efl/install-dependencies:
6:39 AM Changeset in webkit [173957] by Carlos Garcia Campos
  • 1 edit in releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog

Merge r172896 - [GTK] Toggle buttons visually broken with GTK+ 3.13.7
​https://bugs.webkit.org/show_bug.cgi?id=136130

Patch by Michael Catanzaro <Michael Catanzaro> on 2014-08-24
Reviewed by Martin Robinson.

No new tests. Hopefully covered by existing tests, and our tests only
run with GTK+ 3.6 anyway.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::paintToggle): use GTK_STATE_FLAG_CHECKED when compiling for
GTK+ 3.13.7 and above to ensure toggle buttons display as toggled.

6:31 AM Changeset in webkit [173956] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore

Merge r172958 - [GTK] Selection background is rendered white when unfocused with recent GTK+
​https://bugs.webkit.org/show_bug.cgi?id=136251

Reviewed by Martin Robinson.

This is due to a change in the GTK+ theme, but because we are not
using the right flags to get the selections colors. We should use
GTK_STATE_FLAG_SELECTED | GTK_STATE_FLAG_FOCUSED when focused and
GTK_STATE_FLAG_SELECTED when unfocused, instead of
GTK_STATE_FLAG_ACTIVE when unfocused.

  • platform/gtk/RenderThemeGtk3.cpp:

(WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformActiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformInactiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformActiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformInactiveListBoxSelectionForegroundColor):

6:25 AM Changeset in webkit [173955] by Carlos Garcia Campos
  • 4 edits
    6 adds in releases/WebKitGTK/webkit-2.4

Merge r173809 - [GStreamer] Cannot play Vimeo video
​https://bugs.webkit.org/show_bug.cgi?id=134969

Reviewed by Sergio Villar Senin.

Source/WebCore:

Ensure the GStreamer HTTP source element also sends cookies when
it's sending its requests. Some streaming platforms such as Vimeo
do server-side cookie checks on incoming requests before serving
media data.

Test: http/tests/media/hls/video-cookie.html

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart): Set first-party cookie URL to the request so
the ResourceLoader properly sets cookies in the HTTP request.

6:13 AM Changeset in webkit [173954] by Carlos Garcia Campos
  • 3 edits
    189 adds in releases/WebKitGTK/webkit-2.4

Merge r173753 - Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
​https://bugs.webkit.org/show_bug.cgi?id=136632

Reviewed by Gustavo Noronha Silva.

Source/WebInspectorUI:

Add free icons for the GTK port. These icons are from the GNOME
project, some of them adapted by Andres Gomez for the inspector.

6:10 AM Changeset in webkit [173953] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.4

Merge r173751 - [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
​https://bugs.webkit.org/show_bug.cgi?id=136943

Reviewed by Philippe Normand.

Source/WebKit2:

  • PlatformGTK.cmake: Fix the inspector file list and pass it to

the generate-inspector-gresource-manifest.py script.

Tools:

Update the script to receive the list of files from the command
line instead of scanning the given directories.

  • gtk/generate-inspector-gresource-manifest.py:

(get_filenames): Convert filenames to use relative paths.
(find_all_files_in_directory): Deleted.
(find_all_files_in_directory.select_file): Deleted.

4:26 AM Changeset in webkit [173952] by Carlos Garcia Campos
  • 3 edits
    29 adds in trunk/Source/WebInspectorUI

Unreviewed. Add more free icons for the Web Inspector in GTK+.

Patch by Andres Gomez <Andres Gomez> on 2014-09-25

  • UserInterface/Images/gtk/AUTHORS:
  • UserInterface/Images/gtk/ApplicationCacheManifest.png: Added.
  • UserInterface/Images/gtk/​ApplicationCacheManifest@2x.png: Added.
  • UserInterface/Images/gtk/COPYING:
  • UserInterface/Images/gtk/COPYING_LGPL2: Added.
  • UserInterface/Images/gtk/Cookie.png: Added.
  • UserInterface/Images/gtk/​Cookie@2x.png: Added.
  • UserInterface/Images/gtk/HoverMenuButton.png: Added.
  • UserInterface/Images/gtk/​HoverMenuButton@2x.png: Added.
  • UserInterface/Images/gtk/InstructionPointer.png: Added.
  • UserInterface/Images/gtk/​InstructionPointer@2x.png: Added.
  • UserInterface/Images/gtk/Log.png: Added.
  • UserInterface/Images/gtk/​Log@2x.png: Added.
  • UserInterface/Images/gtk/Profile.png: Added.
  • UserInterface/Images/gtk/​Profile@2x.png: Added.
  • UserInterface/Images/gtk/Recording.png: Added.
  • UserInterface/Images/gtk/​Recording@2x.png: Added.
  • UserInterface/Images/gtk/RecordingHovered.png: Added.
  • UserInterface/Images/gtk/​RecordingHovered@2x.png: Added.
  • UserInterface/Images/gtk/RecordingStopped.png: Added.
  • UserInterface/Images/gtk/​RecordingStopped@2x.png: Added.
  • UserInterface/Images/gtk/Script.png: Added.
  • UserInterface/Images/gtk/​Script@2x.png: Added.
  • UserInterface/Images/gtk/ScriptLarge.png: Added.
  • UserInterface/Images/gtk/​ScriptLarge@2x.png: Added.
  • UserInterface/Images/gtk/SliderThumb.png: Added.
  • UserInterface/Images/gtk/​SliderThumb@2x.png: Added.
  • UserInterface/Images/gtk/SliderThumbPressed.png: Added.
  • UserInterface/Images/gtk/​SliderThumbPressed@2x.png: Added.
  • UserInterface/Images/gtk/Stopwatch.png: Added.
  • UserInterface/Images/gtk/​Stopwatch@2x.png: Added.
3:51 AM Changeset in webkit [173951] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[WebKit2] Fix build warning in WebKit2/WebProcess module.
​https://bugs.webkit.org/show_bug.cgi?id=137105

Patch by Shivakumar JM <​shiva.jm@samsung.com> on 2014-09-25
Reviewed by Csaba Osztrogonác.

Fix build warning by removing unused parameter names

  • WebProcess/WebPage/WebInspector.h:

(WebKit::WebInspector::didReceiveInvalidMessage):

  • WebProcess/WebPage/WebInspectorUI.h:

(WebKit::WebInspectorUI::didReceiveInvalidMessage):

3:36 AM Changeset in webkit [173950] by Csaba Osztrogonác
  • 1 delete in trunk/Source/WebKit/wince

Unreviewed, delete the empty Source/WebKit/wince/ChangeLog after r173949.

3:14 AM Changeset in webkit [173949] by Csaba Osztrogonác
  • 101 edits
    54 deletes in trunk

Remove WinCE port from trunk
​https://bugs.webkit.org/show_bug.cgi?id=136951

Reviewed by Alex Christensen.

.:

  • Source/cmake/OptionsWinCE.cmake: Removed.
  • Source/cmake/WebKitPackaging.cmake:

Source/JavaScriptCore:

  • assembler/ARMAssembler.h:

(JSC::ARMAssembler::cacheFlush):

  • assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::cacheFlush):

  • config.h:
  • heap/MachineStackMarker.cpp:

(JSC::MachineThreads::gatherFromCurrentThread):
(JSC::MachineThreads::gatherFromOtherThread):
(JSC::swapIfBackwards): Deleted.

  • jit/ExecutableAllocator.h:
  • jsc.cpp:

(main):

  • runtime/DateConstructor.cpp:
  • runtime/Options.cpp:

(JSC::overrideOptionWithHeuristic):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • testRegExp.cpp:

(main):

  • tools/CodeProfiling.cpp:

(JSC::CodeProfiling::notifyAllocator):

Source/WebCore:

  • Modules/encryptedmedia/CDMPrivateMediaPlayer.cpp:
  • PlatformWinCE.cmake: Removed.
  • accessibility/AXObjectCache.cpp:
  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::modifyMovingRight):

  • loader/icon/wince/IconDatabaseWinCE.cpp: Removed.
  • page/EventHandler.cpp:

(WebCore::EventHandler::sendContextMenuEventForKey):

  • page/Settings.cpp:
  • page/win/EventHandlerWin.cpp:

(WebCore::EventHandler::createDraggingDataTransfer):

  • platform/ContextMenu.h:
  • platform/DragImage.cpp:
  • platform/FileSystem.h:
  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::mayFillWithSolidColor):

  • platform/graphics/FontGlyphs.cpp:

(WebCore::FontGlyphs::glyphDataAndPageForCharacter):

  • platform/graphics/FontPlatformData.h:
  • platform/graphics/ImageBufferData.h:
  • platform/graphics/MediaPlayer.cpp:
  • platform/graphics/SimpleFontData.h:
  • platform/graphics/opentype/OpenTypeUtilities.cpp:

(WebCore::renameAndActivateFont):

  • platform/graphics/opentype/OpenTypeUtilities.h:
  • platform/graphics/win/DIBPixelData.cpp:

(WebCore::DIBPixelData::setRGBABitmapAlpha):

  • platform/graphics/win/GDIExtras.cpp: Removed.
  • platform/graphics/win/GDIExtras.h:

(WebCore::hasAlphaBlendSupport):
(WebCore::alphaBlendIfSupported):

  • platform/graphics/win/IconWin.cpp:

(WebCore::Icon::createIconForFiles):
(WebCore::Icon::paint):

  • platform/graphics/win/SimpleFontDataWin.cpp:

(WebCore::SimpleFontData::initGDIFont):
(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::boundsForGDIGlyph):
(WebCore::SimpleFontData::widthForGDIGlyph):
(WebCore::SimpleFontData::scriptFontProperties):

  • platform/graphics/wince/FontCacheWinCE.cpp: Removed.
  • platform/graphics/wince/FontCustomPlatformData.cpp: Removed.
  • platform/graphics/wince/FontCustomPlatformData.h: Removed.
  • platform/graphics/wince/FontPlatformData.cpp: Removed.
  • platform/graphics/wince/FontPlatformData.h: Removed.
  • platform/graphics/wince/FontWinCE.cpp: Removed.
  • platform/graphics/wince/GlyphPageTreeNodeWinCE.cpp: Removed.
  • platform/graphics/wince/GradientWinCE.cpp: Removed.
  • platform/graphics/wince/GraphicsContextWinCE.cpp: Removed.
  • platform/graphics/wince/ImageBufferDataWince.h: Removed.
  • platform/graphics/wince/ImageBufferWinCE.cpp: Removed.
  • platform/graphics/wince/ImageWinCE.cpp: Removed.
  • platform/graphics/wince/MediaPlayerPrivateWinCE.h: Removed.
  • platform/graphics/wince/MediaPlayerProxy.cpp: Removed.
  • platform/graphics/wince/MediaPlayerProxy.h: Removed.
  • platform/graphics/wince/PathWinCE.cpp: Removed.
  • platform/graphics/wince/PlatformPathWinCE.cpp: Removed.
  • platform/graphics/wince/PlatformPathWinCE.h: Removed.
  • platform/graphics/wince/SharedBitmap.cpp: Removed.
  • platform/graphics/wince/SharedBitmap.h: Removed.
  • platform/graphics/wince/SimpleFontDataWinCE.cpp: Removed.
  • platform/graphics/wince/WinCEGraphicsExtras.h: Removed.
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/network/win/NetworkStateNotifierWin.cpp:

(WebCore::NetworkStateNotifier::NetworkStateNotifier):

  • platform/win/COMPtr.h:
  • platform/win/ClipboardUtilitiesWin.cpp:
  • platform/win/ContextMenuItemWin.cpp:
  • platform/win/ContextMenuWin.cpp:

(WebCore::ContextMenu::getContextMenuItems):
(WebCore::ContextMenu::createPlatformContextMenuFromItems):

  • platform/win/DragImageWin.cpp:

(WebCore::dragLabelFont):

  • platform/win/FileSystemWin.cpp:

(WebCore::pathByAppendingComponent):
(WebCore::pathGetFileName):
(WebCore::storageDirectory):

  • platform/win/LoggingWin.cpp:

(WebCore::logLevelString):

  • platform/win/PasteboardWin.cpp:

(WebCore::PasteboardOwnerWndProc):
(WebCore::Pasteboard::createForCopyAndPaste):
(WebCore::pathRemoveBadFSCharacters):
(WebCore::filesystemPathFromUrlOrTitle):
(WebCore::createGlobalHDropContent):

  • platform/win/PlatformMouseEventWin.cpp:

(WebCore::messageToEventType):
(WebCore::PlatformMouseEvent::PlatformMouseEvent):

  • platform/win/PlatformScreenWin.cpp:

(WebCore::deviceInfoForWidget):
(WebCore::screenIsMonochrome):

  • platform/win/PopupMenuWin.cpp:

(WebCore::PopupMenuWin::show):
(WebCore::PopupMenuWin::paint):
(WebCore::PopupMenuWin::registerClass):
(WebCore::PopupMenuWin::wndProc):

  • platform/win/ScrollbarThemeWin.cpp:

(WebCore::ScrollbarThemeWin::paintButton):

  • platform/win/SharedBufferWin.cpp:
  • platform/win/SharedTimerWin.cpp:

(WebCore::TimerWindowWndProc):
(WebCore::initializeOffScreenTimerWindow):
(WebCore::queueTimerProc):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):

  • platform/win/SoftLinking.h:
  • platform/win/SystemInfo.cpp:

(WebCore::windowsVersion):
(WebCore::processorArchitecture):
(WebCore::architectureTokenForUAString):

  • platform/win/WCDataObject.cpp:

(WebCore::WCDataObject::CopyMedium):

  • plugins/PluginDatabase.cpp:
  • plugins/PluginView.cpp:

(WebCore::PluginView::stop):

  • plugins/PluginViewNone.cpp:
  • plugins/win/PluginDatabaseWin.cpp:

(WebCore::addWindowsMediaPlayerPluginDirectory):
(WebCore::addMacromediaPluginDirectories):

  • plugins/win/PluginPackageWin.cpp:

(WebCore::PluginPackage::load):

  • plugins/win/PluginViewWin.cpp:

(WebCore::setUpOffscreenPaintingHooks):
(WebCore::registerPluginView):
(WebCore::PluginView::wndProc):
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paintIntoTransformedContext):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setParent):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::platformStart):

  • rendering/RenderThemeWinCE.cpp: Removed.
  • rendering/RenderThemeWinCE.h: Removed.
  • storage/wince/DatabaseThreadWinCE.cpp: Removed.
  • storage/wince/DatabaseThreadWinCE.h: Removed.
  • storage/wince/StorageThreadWinCE.cpp: Removed.
  • storage/wince/StorageThreadWinCE.h: Removed.

Source/WebKit:

  • PlatformWinCE.cmake: Removed.
  • wince/WebCoreSupport/ChromeClientWinCE.cpp: Removed.
  • wince/WebCoreSupport/ChromeClientWinCE.h: Removed.
  • wince/WebCoreSupport/ContextMenuClientWinCE.cpp: Removed.
  • wince/WebCoreSupport/ContextMenuClientWinCE.h: Removed.
  • wince/WebCoreSupport/DragClientWinCE.cpp: Removed.
  • wince/WebCoreSupport/DragClientWinCE.h: Removed.
  • wince/WebCoreSupport/EditorClientWinCE.cpp: Removed.
  • wince/WebCoreSupport/EditorClientWinCE.h: Removed.
  • wince/WebCoreSupport/FrameLoaderClientWinCE.cpp: Removed.
  • wince/WebCoreSupport/FrameLoaderClientWinCE.h: Removed.
  • wince/WebCoreSupport/FrameNetworkingContextWinCE.cpp: Removed.
  • wince/WebCoreSupport/FrameNetworkingContextWinCE.h: Removed.
  • wince/WebCoreSupport/InspectorClientWinCE.cpp: Removed.
  • wince/WebCoreSupport/InspectorClientWinCE.h: Removed.
  • wince/WebCoreSupport/PlatformStrategiesWinCE.cpp: Removed.
  • wince/WebCoreSupport/PlatformStrategiesWinCE.h: Removed.
  • wince/WebView.cpp: Removed.
  • wince/WebView.h: Removed.

Source/WebKit/cf:

  • WebCoreSupport/WebInspectorClientCF.cpp:

Source/WTF:

  • config.h:
  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
  • wtf/Atomics.h:

(WTF::weakCompareAndSwap):

  • wtf/CurrentTime.cpp:

(WTF::lowResUTCTime):

  • wtf/DataLog.cpp:
  • wtf/DateMath.cpp:

(WTF::getLocalTime):
(WTF::calculateDSTOffset):

  • wtf/FastMalloc.cpp:
  • wtf/FeatureDefines.h:
  • wtf/OSAllocator.h:

(WTF::OSAllocator::decommitAndRelease):

  • wtf/Platform.h:
  • wtf/PlatformWin.cmake:
  • wtf/RAMSize.cpp:

(WTF::computeRAMSize):

  • wtf/RandomNumberSeed.h:

(WTF::initializeRandomNumberGenerator):

  • wtf/StackBounds.cpp:

(WTF::StackBounds::initialize):

  • wtf/StackBounds.h:

(WTF::StackBounds::isGrowingDownward):

  • wtf/StdLibExtras.h:

(wtf_bsearch): Deleted.

  • wtf/StringExtras.h:

(strnicmp): Deleted.
(stricmp): Deleted.
(strdup): Deleted.

  • wtf/ThreadSpecific.h:
  • wtf/ThreadingWin.cpp:

(WTF::createThreadInternal):

  • wtf/WindowsExtras.h:

(WTF::getRegistryValue):
(WTF::getWindowPointer):
(WTF::setWindowPointer):

  • wtf/dtoa/utils.h:
  • wtf/text/WTFString.cpp:

(WTF::String::format):

Tools:

  • BuildSlaveSupport/build.webkit.org-config/wkbuild.py:

(_should_file_trigger_build):

  • BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:

(ShouldBuildTest):

  • CMakeLists.txt:
  • DumpRenderTree/win/DRTDataObject.cpp:

(DRTDataObject::CopyMedium):

  • Scripts/build-webkit:
  • Scripts/webkit-build-directory:
  • Scripts/webkitdirs.pm:

(argumentsForConfiguration):
(builtDylibPathForName):
(isAppleWinWebKit):
(launcherPath):
(launcherName):
(shouldRemoveCMakeCache):
(cmakeBasedPortArguments):
(cmakeBasedPortName):
(isCMakeBuild):
(isWinCE): Deleted.
(determineIsWinCE): Deleted.

  • Scripts/webkitperl/FeatureList.pm:
  • Scripts/webkitpy/port/port_testcase.py:

(test_apache_config_file_name_for_platform):

  • TestWebKitAPI/config.h:
  • WinCELauncher/CMakeLists.txt: Removed.
  • WinCELauncher/main.cpp: Removed.
  • gtk/manifest.txt:
2:44 AM Changeset in webkit [173948] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[GTK] Unreviewed GTK gardening.

Patch by Lorenzo Tilve <​ltilve@igalia.com> on 2014-09-25

  • platform/gtk/TestExpectations: Report and mark new failures after r173515 and r173582.
  • platform/gtk/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:

Update expectations after r173857.

2:36 AM Changeset in webkit [173947] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

Unreviewed. Fix GTK+ build after r173944.

  • page/ContextMenuController.cpp: Add missing include.
2:27 AM WebKitGTK/KeepingTheTreeGreen edited by ltilve@igalia.com
(diff)

Sep 24, 2014:

9:30 PM Changeset in webkit [173946] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit/ios

[iOS] Another iOS build fix; workaround for CoreLocation
​https://bugs.webkit.org/show_bug.cgi?id=137104
<rdar://problem/18450785>

Rubber-stamped by Benjamin Poulain.

Workaround CoreLocation issue by adding a default statement in -[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]
and -[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:].
We'll remove these default statements once we have the fix for <rdar://problem/18448331>.

  • Misc/WebGeolocationCoreLocationProvider.mm:

(-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):
(-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]):

9:02 PM Changeset in webkit [173945] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Use tighter typing for render objects in RenderGeometryMap
​https://bugs.webkit.org/show_bug.cgi?id=137102

Reviewed by Ryosuke Niwa.

Use tighter typing for render objects in RenderGeometryMap for clarity
and efficiency.

In particular, using RenderElement type instead of RenderObject
in canMapBetweenRenderers() allows us to call the faster
RenderElement::style() instead of RenderObject::style().

No new tests, no behavior change.

  • rendering/RenderGeometryMap.cpp:

(WebCore::canMapBetweenRenderers):
(WebCore::RenderGeometryMap::pushMappingsToAncestor):

8:50 PM Changeset in webkit [173944] by Chris Dumez
  • 39 edits in trunk/Source

Add initial is<>() / downcast<>() support for any type of Nodes
​https://bugs.webkit.org/show_bug.cgi?id=137056

Reviewed by Benjamin Poulain.

Source/WebCore:

Add initial is<>() / downcast<>() support for any type of Nodes, not
just Elements by:

  • Moving the is<>() / downcast<>() declarations from Element.h to Node.h
  • Introducing a SPECIALIZE_TYPE_TRAITS_*() macro that generates the needed template specializations for is<>() / downcast<>() to work. This macro will replace NODE_TYPE_CASTS() entirely once the code base is fully ported.

This patch makes use of SPECIALIZE_TYPE_TRAITS_*() macro for
HTMLFormControlElement, that is an HTMLElement for which the template
specializations cannot be automatically generated because it requires
special handling.

This patch also makes use of SPECIALIZE_TYPE_TRAITS_*() macro for
DocumentFragment to show that it can be used for non-Element Nodes.

No new tests, no behavior change.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::isRequired):
(WebCore::AccessibilityNodeObject::isControl):

  • css/SelectorCheckerTestFunctions.h:

(WebCore::isAutofilled):
(WebCore::isDisabled):
(WebCore::isEnabled):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::adjustRenderStyle):

  • dom/Document.cpp:

(WebCore::Document::importNode):
(WebCore::Document::setFocusedElement):

  • dom/DocumentFragment.h:

(WebCore::isDocumentFragment):

  • dom/Element.cpp:

(WebCore::Element::focus):

  • dom/Element.h:

(WebCore::is): Deleted.
(WebCore::downcast): Deleted.

  • dom/Node.h:

(WebCore::is):
(WebCore::downcast):

  • dom/make_names.pl:

(printTypeHelpers):

  • editing/FrameSelection.cpp:

(WebCore::scanForForm):

  • editing/TextIterator.cpp:

(WebCore::isRendererReplacedElement):

  • html/FormAssociatedElement.h:
  • html/HTMLElement.h:
  • html/HTMLFieldSetElement.cpp:

(WebCore::updateFromControlElementsAncestorDisabledStateUnder):
(WebCore::HTMLFieldSetElement::refreshElementsIfNeeded):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::enclosingFormControlElement):

  • html/HTMLFormControlElement.h:

(WebCore::isHTMLFormControlElement):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::submitImplicitly):
(WebCore::submitElementFromEvent):
(WebCore::HTMLFormElement::validateInteractively):
(WebCore::HTMLFormElement::submit):
(WebCore::HTMLFormElement::reset):
(WebCore::HTMLFormElement::formElementIndex):
(WebCore::HTMLFormElement::defaultButton):
(WebCore::HTMLFormElement::checkInvalidControlsAndCollectUnhandled):
(WebCore::HTMLFormElement::documentDidResumeFromPageCache):

  • html/HTMLMediaElement.h:
  • html/HTMLPlugInImageElement.h:
  • html/HTMLSummaryElement.cpp:

(WebCore::isClickableControl):

  • html/LabelableElement.h:
  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::checkElementMatchesRadioNodeListFilter):
(WebCore::RadioNodeList::elementMatches):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::findFosterSite):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::disallowTelephoneNumberParsing):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • mathml/MathMLElement.h:
  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):

  • page/Frame.cpp:

(WebCore::Frame::searchForLabelsBeforeElement):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::formControlElement):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::resize):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isReadOnlyControl):

  • svg/SVGElement.h:
  • svg/SVGFilterPrimitiveStandardAttributes.h:
  • svg/animation/SVGSMILElement.h:

Source/WebKit/mac:

Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
instead of isFormControlElement() / toHTMLFormControlElement().

  • WebView/WebHTMLRepresentation.mm:

(searchForLabelsBeforeElement):

Source/WebKit/win:

Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
instead of isFormControlElement() / toHTMLFormControlElement().

  • WebFrame.cpp:

(WebFrame::elementWithName):

7:53 PM Changeset in webkit [173943] by Darin Adler
  • 8 edits
    3 adds in trunk

Old Turkic characters behave as left-to-right instead of right-to-left, because they are encoded as surrogate pairs.
​https://bugs.webkit.org/show_bug.cgi?id=70029

Reviewed by Dan Bernstein.

Source/WebCore:

Test: fast/text/international/old-turkic-direction.html

  • CMakeLists.txt: Added InlineIterator.cpp.
  • WebCore.vcxproj/WebCore.vcxproj: Ditto.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • rendering/RenderingAllInOne.cpp: Ditto.
  • rendering/InlineIterator.cpp: Added.

(WebCore::InlineIterator::surrogateTextDirection): New function used to compute the direction
when a surrogate pair is involved.

  • rendering/InlineIterator.h: Made the characterAt function private.

(WebCore::InlineIterator::previousInSameNode): Took out unneeded range check. A zero will underflow
and become a large number and the characterAt function will return 0 in that case.
(WebCore::InlineIterator::direction): Added code to check U16_IS_SINGLE before calling
u_charDirection, and call surrogateTextDirection instead.

LayoutTests:

  • fast/text/international/old-turkic-direction.html: Added.
  • fast/text/international/old-turkic-direction-expected.html: Added.
7:46 PM Changeset in webkit [173942] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r173941.

Rename shadow to m_shadow.

  • rendering/TextPainter.h:

(WebCore::ShadowApplier::shadowIsCompletelyCoveredByText):

7:32 PM Changeset in webkit [173941] by mmaxfield@apple.com
  • 9 edits
    2 deletes in trunk

REGRESSION: Text with a zero offset, zero blur shadow vanishes
​https://bugs.webkit.org/show_bug.cgi?id=136801

Reviewed by Darin Adler.

Source/WebCore:

This patch performs some cleanup regarding TextPainter's shadow logic and handles an
additional case of empty shadows. Previously, there was tight coupling between
applyShadowToGraphicalContext() and paintTextWithShadows(), as they both used a
collection of variables to determine how shadows are to be drawn. This complexity has
been moved into a helper class, ShadowApplier, which performs what
applyShadowToGraphicsContext() used to do, and cleans up correctly in its destructor.
This removes the tight coupling mentioned earlier.

Test: fast/text/empty-shadow.html

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::applyShadowToGraphicsContext): Moved to ShadowApplier.

  • rendering/InlineTextBox.h: Deleted applyShadowToGraphicsContext signature.
  • rendering/TextPainter.cpp:

(WebCore::ShadowApplier::ShadowApplier): Perform the contents of applyShadowToGraphicsContext()
(WebCore::ShadowApplier::~ShadowApplier): Undo the work done previously
(WebCore::paintTextWithShadows): Create a ShadowApplier to do the relevant shadow work. In addition,
refactor some boolean flags to more meaningful ones with relation to the computation at hand.
(WebCore::isEmptyShadow): Moved to TextPainter.h, named shadowIsCompletelyCoveredByText()

  • rendering/TextPainter.h:

(WebCore::ShadowApplier::ShadowApplier): Moved from InlineTextBox::applyShadowToGraphicsContext().
(WebCore::ShadowApplier::extraOffset): Getter.
(WebCore::ShadowApplier::~ShadowApplier): Moved from TextPainter::paintTextWithShadows().
(WebCore::isLastShadowIteration): Helper function.
(WebCore::shadowIsCompletelyCoveredByText): Determines whether or not we should not draw the shadow.

  • rendering/svg/SVGInlineTextBox.cpp:

(WebCore::SVGInlineTextBox::paintTextWithShadows): Update to use ShadowApplier.

LayoutTests:

This test should be a comprehensive test of empty shadows. It tests every
combination of one and two shadows being empty, as well as transparent and
opaque text.

After updating fast/text/empty-shadow.html, fast/text/empty-shadow-with-color.html
is no longer necessary.

  • fast/text/empty-shadow-expected.html:
  • fast/text/empty-shadow-with-color-expected.html: Removed.
  • fast/text/empty-shadow-with-color.html: Removed.
  • fast/text/empty-shadow.html:
7:17 PM Changeset in webkit [173940] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit/ios

[iOS] Fix the iOS build; add case statements for kCLAuthorizationStatusAuthorized
​https://bugs.webkit.org/show_bug.cgi?id=137101
<rdar://problem/18449815>

Reviewed by Mark Lam.

  • Misc/WebGeolocationCoreLocationProvider.mm:

(-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):
(-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]):

5:25 PM Changeset in webkit [173939] by Brian Burg
  • 6 edits in trunk/Source

Web Inspector: subtract elapsed time while debugger is paused from profile nodes
​https://bugs.webkit.org/show_bug.cgi?id=136796

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Rather than accruing no time to any profile node created while the debugger is paused,
we can instead count a node's elapsed time and exclude time elapsed while paused.

Time for a node may elapse in a non-contiguous fashion depending on the interleaving of
didPause, didContinue, willExecute, and didExecute. A node's start time is set to the
start of the last such interval that accrues elapsed time.

  • profiler/ProfileGenerator.cpp:

(JSC::ProfileGenerator::ProfileGenerator):
(JSC::ProfileGenerator::beginCallEntry):
(JSC::ProfileGenerator::endCallEntry):
(JSC::ProfileGenerator::didPause): Added.
(JSC::ProfileGenerator::didContinue): Added.

  • profiler/ProfileGenerator.h:

(JSC::ProfileGenerator::didPause): Deleted.
(JSC::ProfileGenerator::didContinue): Deleted.

  • profiler/ProfileNode.h: Rename totalTime to elapsedTime.

(JSC::ProfileNode::Call::Call):
(JSC::ProfileNode::Call::elapsedTime): Added.
(JSC::ProfileNode::Call::setElapsedTime): Added.
(JSC::CalculateProfileSubtreeDataFunctor::operator()):
(JSC::ProfileNode::Call::totalTime): Deleted.
(JSC::ProfileNode::Call::setTotalTime): Deleted.

Source/WebCore:

  • inspector/TimelineRecordFactory.cpp:

(WebCore::buildInspectorObject):

4:29 PM Changeset in webkit [173938] by Chris Dumez
  • 2 edits in trunk/Source/WebKit/win

Unreviewed build fix after r173932.

Unreviewed build fix after r173932 for Windows. Use WebCore:: namespace
explicitely in DOMCoreClasses.cpp.

  • DOMCoreClasses.cpp:

(DOMElement::createInstance):

4:28 PM Changeset in webkit [173937] by dfarler@apple.com
  • 5 edits in trunk/Tools

[iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
​https://bugs.webkit.org/show_bug.cgi?id=136895

Reviewed by David Kilzer.

Create Device, DeviceType, and Runtime data classes.
Create Simulator class represent simctl output.

Wherever possible, use structured data classes anywhere a raw
identifier or UDID string was used for a cleaner implementation
and to encapsulate the inherent fragility of scraping simctl output.

Create a suitably named testing device if one doesn't exist.

Finally, accurately handle having multiple simulator runtimes (SDKs)
installed in the active Xcode.app bundle.

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(_set_up_derived_options):

  • Scripts/webkitpy/port/driver.py:

(IOSSimulatorDriver.cmd_line):
Construct DeviceType and Runtime objects from identifiers passed at the
command line, still providing sensible defaults for 32- and 64-bit testing.

  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.init):
(IOSSimulatorPort.setup_test_run):
(IOSSimulatorPort):
(IOSSimulatorPort.testing_device):
Cache the testing device once it is created or found.
(IOSSimulatorPort.reset_preferences):
Get the device path from the Device object instead of consructing it
in the port class.
(IOSSimulatorPort.simulator_udid): Deleted.
Get the UDID from the testing_device :: Device object itself.

  • Scripts/webkitpy/xcode/simulator.py:

Created Device, DeviceType, Runtime, and Simulator classes.
(get_runtimes): Deleted.
(get_devices): Deleted.
(get_device_types): Deleted.
(get_latest_runtime): Deleted.

4:11 PM Changeset in webkit [173936] by timothy@apple.com
  • 1 edit in trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm

Attempt to fix crash seen on bots.

3:07 PM Changeset in webkit [173935] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

Do the bmalloc.
​https://bugs.webkit.org/show_bug.cgi?id=132629

Reviewed by Gavin Barraclough.

64-bit only for now, just to try it out.

  • wtf/FastMalloc.cpp:
3:02 PM Changeset in webkit [173934] by weinig@apple.com
  • 2 edits in trunk/Source/WebKit2

Remove incorrect use of the BKSProcessAssertionAllowSuspendOnSleep flag for process suspension in iOS WebKit2
<rdar://problem/18400566>
​https://bugs.webkit.org/show_bug.cgi?id=137077

Reviewed by Anders Carlsson.

  • UIProcess/ios/ProcessAssertionIOS.mm:

Remove use of the BKSProcessAssertionAllowSuspendOnSleep which does not do what we expect, and instead
causes processes to be suspended "forever" after sleep.

2:41 PM Changeset in webkit [173933] by timothy@apple.com
  • 2 edits in trunk/Source/WebKit2/UIProcess

Fix 32-bit Mac build.

2:25 PM Changeset in webkit [173932] by Chris Dumez
  • 72 edits in trunk/Source

Use is<HTML*Element>() instead of isHTML*Element() - Part 1
​https://bugs.webkit.org/show_bug.cgi?id=137068

Reviewed by Ryosuke Niwa.

Start using is<HTML*Element>() instead of isHTML*Element().
Remaining usages will be updated in a follow-up patch to
reduce the size of the change.

Source/WebCore:

No new tests, no behavior change.

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::isSelected):
(WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaTimeline::valueDescription):

  • accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::setElement):

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::isNativeTextControl):
(WebCore::AccessibilityNodeObject::isNativeImage):
(WebCore::AccessibilityNodeObject::isInputImage):
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::valueForRange):
(WebCore::AccessibilityNodeObject::maxValueForRange):
(WebCore::AccessibilityNodeObject::minValueForRange):
(WebCore::isNodeActionElement):
(WebCore::AccessibilityNodeObject::titleElementText):
(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::title):
(WebCore::AccessibilityNodeObject::colorValue):
(WebCore::accessibleNameForNode):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isFileUploadButton):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):

  • accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::notifyChildrenSelectionChange):

  • css/SelectorCheckerTestFunctions.h:

(WebCore::isDisabled):
(WebCore::isEnabled):
(WebCore::isChecked):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectAll):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace):

  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::isInPasswordField):

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverter::_processElement):

  • editing/gtk/EditorGtk.cpp:

(WebCore::elementURL):

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):

  • editing/markup.cpp:

(WebCore::StyledMarkupAccumulator::appendText):
(WebCore::isPlainTextMarkup):
(WebCore::collectElementsToRemoveFromFragment):

  • html/HTMLCollection.cpp:

(WebCore::isMatchingElement):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::rendererIsNeeded):

  • html/HTMLFormControlElement.cpp:

(WebCore::shouldAutofocus):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::getTextFieldValues):
(WebCore::HTMLFormElement::formElementIndex):

  • html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::dispatchLoadEvent):
(WebCore::HTMLImageLoader::notifyFinished):

  • html/HTMLNameCollection.cpp:

(WebCore::DocumentNameCollection::elementMatchesIfIdAttributeMatch):
(WebCore::DocumentNameCollection::elementMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::elementMatches):

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::recalcSelectOptions):
(WebCore::HTMLOptGroupElement::ownerSelectElement):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::index):
(WebCore::HTMLOptionElement::ownerSelectElement):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::add):
(WebCore::HTMLSelectElement::value):
(WebCore::HTMLSelectElement::setValue):
(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore::HTMLSelectElement::setLength):
(WebCore::HTMLSelectElement::nextValidIndex):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::selectOption):
(WebCore::HTMLSelectElement::optionToListIndex):
(WebCore::HTMLSelectElement::listToOptionIndex):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState):
(WebCore::HTMLSelectElement::searchOptionsForValue):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
(WebCore::HTMLSelectElement::lastSelectedListIndex):
(WebCore::HTMLSelectElement::optionAtIndex):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
(WebCore::HTMLSelectElement::length):

  • html/HTMLTagNames.in:
  • html/RadioInputType.cpp:

(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::isKeyboardFocusable):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::hasImpliedEndTag):

  • html/parser/HTMLElementStack.cpp:

(WebCore::HTMLNames::isSelectScopeMarker):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):

  • html/shadow/MediaControlElementTypes.cpp:

(WebCore::mediaControlElementType):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::handleFallbackContent):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestObject):

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::create):

  • page/Chrome.cpp:

(WebCore::Chrome::setToolTip):

  • page/EventHandler.cpp:

(WebCore::isSubmitImage):
(WebCore::EventHandler::handleMousePressEvent):

  • page/FocusController.cpp:

(WebCore::clearSelectionIfNeeded):

  • page/FrameView.cpp:

(WebCore::FrameView::addEmbeddedObjectToUpdate):
(WebCore::FrameView::updateEmbeddedObject):

  • page/PageSerializer.cpp:

(WebCore::frameOwnerURLAttributeName):

  • page/SpatialNavigation.cpp:

(WebCore::canScrollInDirection):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::absolutePDFURL):
(WebCore::HitTestResult::isContentEditable):

  • rendering/RenderBlockFlow.cpp:

(WebCore::resizeTextPermitted):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::sizesLogicalWidthToFitContent):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::updateFromElement):
(WebCore::RenderButton::canHaveGeneratedChildren):

  • rendering/RenderDetailsMarker.cpp:

(WebCore::RenderDetailsMarker::isOpen):

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::uploadButton):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::updateAltText):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):

  • rendering/RenderMenuList.cpp:

(WebCore::selectedOptionCount):
(RenderMenuList::updateOptionsWidth):
(RenderMenuList::setTextFromOption):
(RenderMenuList::itemText):
(RenderMenuList::itemIsEnabled):
(RenderMenuList::itemIsSelected):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paintSliderTicks):

  • testing/Internals.cpp:

(WebCore::Internals::selectColorInColorChooser):
(WebCore::Internals::wasLastChangeUserEdit):
(WebCore::Internals::isSelectPopupVisible):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):

Source/WebKit/ios:

  • WebCoreSupport/WebChromeClientIOS.mm:

(WebChromeClientIOS::focusedElementChanged):

Source/WebKit/mac:

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::focusedElementChanged):

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::textFieldDidBeginEditing):
(WebEditorClient::textFieldDidEndEditing):
(WebEditorClient::textDidChangeInTextField):
(WebEditorClient::doTextFieldCommandFromEvent):
(WebEditorClient::textWillBeDeletedInTextField):
(WebEditorClient::textDidChangeInTextArea):

  • WebView/WebHTMLRepresentation.mm:

(inputElementFromDOMElement):

Source/WebKit/win:

  • DOMCoreClasses.cpp:

(DOMElement::createInstance):

  • DOMHTMLClasses.cpp:

(DOMHTMLOptionElement::text):
(DOMHTMLOptionElement::label):
(DOMHTMLInputElement::form):
(DOMHTMLInputElement::disabled):
(DOMHTMLInputElement::readOnly):
(DOMHTMLInputElement::setType):
(DOMHTMLInputElement::value):
(DOMHTMLInputElement::setValue):
(DOMHTMLInputElement::setValueForUser):
(DOMHTMLInputElement::select):
(DOMHTMLInputElement::setSelectionStart):
(DOMHTMLInputElement::selectionStart):
(DOMHTMLInputElement::setSelectionEnd):
(DOMHTMLInputElement::selectionEnd):
(DOMHTMLInputElement::isTextField):
(DOMHTMLInputElement::rectOnScreen):
(DOMHTMLInputElement::replaceCharactersInRange):
(DOMHTMLInputElement::selectedRange):
(DOMHTMLInputElement::setAutofilled):
(DOMHTMLInputElement::isAutofilled):
(DOMHTMLInputElement::isUserEdited):
(DOMHTMLTextAreaElement::form):
(DOMHTMLTextAreaElement::value):
(DOMHTMLTextAreaElement::setValue):
(DOMHTMLTextAreaElement::select):
(DOMHTMLTextAreaElement::isUserEdited):

  • WebFrame.cpp:

(inputElementFromDOMElement):

Source/WebKit2:

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::setHTMLInputElementValueForUser):
(WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::htmlInputElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::isTextField):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::focusedElementChanged):

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::textFieldDidBeginEditing):
(WebKit::WebEditorClient::textFieldDidEndEditing):
(WebKit::WebEditorClient::textDidChangeInTextField):
(WebKit::WebEditorClient::textDidChangeInTextArea):
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
(WebKit::WebEditorClient::textWillBeDeletedInTextField):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::containsAnyFormControls):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setAssistedNodeValue):
(WebKit::WebPage::setAssistedNodeValueAsNumber):
(WebKit::WebPage::setAssistedNodeSelectedIndex):

2:22 PM Changeset in webkit [173931] by eric.carlson@apple.com
  • 4 edits in trunk/Source/WebCore

[iOS] Remove MediaPlayer::setHasPlaybackTargetAvailabilityListeners
​https://bugs.webkit.org/show_bug.cgi?id=137075

Reviewed by Dean Jackson.

No new tests, this just removes unused code.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::setHasPlaybackTargetAvailabilityListeners): Deleted.

  • platform/graphics/MediaPlayer.h:
  • platform/graphics/MediaPlayerPrivate.h:

(WebCore::MediaPlayerPrivateInterface::setHasPlaybackTargetAvailabilityListeners): Deleted.

1:11 PM Changeset in webkit [173930] by adachan@apple.com
  • 4 edits in trunk/Source/WebKit2

Add stub implementation of WKPageIsPlayingAudio().
​https://bugs.webkit.org/show_bug.cgi?id=137044

Reviewed by Anders Carlsson.

Also add an isPlayingAudioDidChange callback to WKPageUIClient.

  • UIProcess/API/C/WKPage.cpp:

(WKPageIsPlayingAudio):

  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/API/C/WKPageUIClient.h:
12:58 PM Changeset in webkit [173929] by timothy@apple.com
  • 53 edits
    1 copy
    5 adds
    1 delete in trunk/Source

Make the Web Inspector use a separate web process.

​https://bugs.webkit.org/show_bug.cgi?id=135120

Reviewed by Anders Carlsson.

Source/WebCore:

  • English.lproj/Localizable.strings: Updated.
  • WebCore.exp.in:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/ScriptGlobalObject.h:
  • bindings/js/ScriptState.h:
  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorPageAgent.h:
  • page/Chrome.h:

Exported a few functions and private headers.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::setInspectorFrontendClient):
(WebCore::InspectorController::hasInspectorFrontendClient):
(WebCore::InspectorController::show):

  • inspector/InspectorController.h:

Make InspectorFrontendClient a pointer instead of a std::unique_ptr.
This makes it easier to implement InspectorFrontendClient as
part of an existing object that is externally owned.

  • testing/Internals.cpp:

(WebCore::Internals::openDummyInspectorFrontend):
(WebCore::Internals::closeDummyInspectorFrontend):

  • testing/Internals.h:

Change InspectorFrontendClientDummy from being moved to owned.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js: Updated.
  • UserInterface/Base/Main.js:

(WebInspector.loaded):
(WebInspector.contentLoaded):
Move InspectorFrontendHost.loaded to later in the load.
Calling it early just shows the window before we have
a user interface to show.

  • UserInterface/Base/Test.js:

(WebInspector.loaded):
(WebInspector.contentLoaded):
Match the changes in Main.js.

  • UserInterface/Protocol/InspectorFrontendAPI.js:

(InspectorFrontendAPI.savedURL): Change comment.
(InspectorFrontendAPI.appendedToURL): Change comment.
(InspectorFrontendAPI.dispatch): Add an assert and early
return to be safe from unknown commands.
(InspectorFrontendAPI.loadCompleted): Delete _pendingCommands,
no need to keep an empty array around a one time use.

Source/WebKit/ios:

  • WebCoreSupport/WebInspectorClientIOS.mm:

(WebInspectorClient::WebInspectorClient):
Removed m_frontendClient initialization since it is
now a std::unique_ptr that defaults to nullptr.

Source/WebKit/mac:

  • WebCoreSupport/WebInspectorClient.h:
  • WebCoreSupport/WebInspectorClient.mm:

(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::openInspectorFrontend):
(WebInspectorClient::releaseFrontend):
Own WebInspectorFrontendClient instead of moving it.

Source/WebKit/win:

  • WebCoreSupport/WebInspectorClient.cpp:

(WebInspectorClient::openInspectorFrontend):

  • WebCoreSupport/WebInspectorClient.h:

(WebInspectorClient::frontendClient):
Own WebInspectorFrontendClient instead of moving it.

Source/WebKit2:

  • CMakeLists.txt:
  • DerivedSources.make:
  • PlatformEfl.cmake:
  • PlatformGTK.cmake:
  • WebKit2.xcodeproj/project.pbxproj:

Added new WebInspectorUI files and removed WebInspectorFrontendClient.cpp.

  • Shared/APIObject.h: Added BundleInspectorUI.
  • Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.mm:

(WebKit::ChildProcessMainDelegate::getExtraInitializationData):

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceInitializerDelegate::getExtraInitializationData):
Add support for "inspector-process" data, a boolean that is used by
WebProcess::initializeProcessName.

  • UIProcess/API/C/WKInspector.cpp:

(WKInspectorIsDebuggingJavaScript):
(WKInspectorToggleJavaScriptDebugging):
(WKInspectorIsProfilingJavaScript):
(WKInspectorToggleJavaScriptProfiling):

  • UIProcess/API/C/WKInspector.h:

Stub out functions we don't support but need to keep for nightly compatibility.

  • UIProcess/WebInspectorProxy.cpp:

(WebKit::WebInspectorPageGroups::createInspectorPageGroup):
(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::invalidate):
(WebKit::WebInspectorProxy::connect):
(WebKit::WebInspectorProxy::showConsole):
(WebKit::WebInspectorProxy::showResources):
(WebKit::WebInspectorProxy::showMainResourceForFrame):
(WebKit::WebInspectorProxy::attach):
(WebKit::WebInspectorProxy::detach):
(WebKit::WebInspectorProxy::inspectorContext):
(WebKit::WebInspectorProxy::dispatchMessageFromRemoteFrontend):
(WebKit::WebInspectorProxy::eagerlyCreateInspectorPage):
(WebKit::WebInspectorProxy::createInspectorPage):
(WebKit::WebInspectorProxy::open):
(WebKit::WebInspectorProxy::didClose):
(WebKit::WebInspectorProxy::attachAvailabilityChanged):

  • UIProcess/WebInspectorProxy.h:

(WebKit::WebInspectorProxy::isConnected):
(WebKit::WebInspectorProxy::canAttach):

  • UIProcess/WebInspectorProxy.messages.in:
  • UIProcess/efl/WebInspectorProxyEfl.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformAttach):

  • UIProcess/mac/WebInspectorProxyMac.mm:

(-[WKWebInspectorProxyObjCAdapter close]):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformDidClose):
(WebKit::WebInspectorProxy::platformHide):
(WebKit::WebInspectorProxy::platformSave):
(WebKit::WebInspectorProxy::platformAppend):
(WebKit::WebInspectorProxy::platformAttach):
Changed how the Inspector page is created by making it in a new WebContext for
the Inspector. This removes us from the main process pool and guarantees no process
sharing for our user interface. Also send new WebInspectorUI messages to the Inspector
page and not the inspected page when appropriate.

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getLaunchOptions): Add "inspector-process" to extraInitializationData
if the context is the Inspector context. This is used by WebProcess::initializeProcessName.

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::openInspectorFrontend):
(WebKit::WebInspectorClient::closeInspectorFrontend):
(WebKit::WebInspectorClient::bringFrontendToFront):

  • WebProcess/WebCoreSupport/WebInspectorClient.h:

Remove the InspectorFrontendChannel class from WebInspectorClient and clean up a little.
InspectorFrontendChannel implementation moved to WebInspector.

  • WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp: Removed. Superseded by WebInspectorUI.
  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::create):
(WebKit::WebInspector::WebInspector):
(WebKit::WebInspector::createInspectorPage):
(WebKit::WebInspector::closeFrontend):
(WebKit::WebInspector::openInNewTab):
(WebKit::WebInspector::showConsole):
(WebKit::WebInspector::showResources):
(WebKit::WebInspector::showMainResourceForFrame):
(WebKit::WebInspector::startPageProfiling):
(WebKit::WebInspector::stopPageProfiling):
(WebKit::WebInspector::canAttachWindow):
(WebKit::WebInspector::updateDockingAvailability):
(WebKit::WebInspector::sendMessageToBackend):
(WebKit::WebInspector::sendMessageToFrontend):
(WebKit::WebInspector::remoteFrontendConnected):
(WebKit::WebInspector::remoteFrontendDisconnected):

  • WebProcess/WebPage/WebInspector.h:

(WebKit::WebInspector::didClose):
(WebKit::WebInspector::didReceiveInvalidMessage):
(WebKit::WebInspector::setAttached):

  • WebProcess/WebPage/WebInspector.messages.in:

Stop taking an optional InspectorFrontendChannel and inherit it instead. Create a connection that
can be passed to the other web process for WebInspectorUI to use. Stop referencing Inspector's page
directly, since it is in another process now.

  • WebProcess/WebPage/WebInspectorUI.cpp: Added.

(WebKit::WebInspectorUI::create):
(WebKit::WebInspectorUI::WebInspectorUI):
(WebKit::WebInspectorUI::establishConnection):
(WebKit::WebInspectorUI::windowObjectCleared):
(WebKit::WebInspectorUI::frontendLoaded):
(WebKit::WebInspectorUI::moveWindowBy):
(WebKit::WebInspectorUI::bringToFront):
(WebKit::WebInspectorUI::closeWindow):
(WebKit::WebInspectorUI::requestSetDockSide):
(WebKit::WebInspectorUI::setDockSide):
(WebKit::WebInspectorUI::changeAttachedWindowHeight):
(WebKit::WebInspectorUI::changeAttachedWindowWidth):
(WebKit::WebInspectorUI::setToolbarHeight):
(WebKit::WebInspectorUI::openInNewTab):
(WebKit::WebInspectorUI::save):
(WebKit::WebInspectorUI::append):
(WebKit::WebInspectorUI::inspectedURLChanged):
(WebKit::WebInspectorUI::showConsole):
(WebKit::WebInspectorUI::showResources):
(WebKit::WebInspectorUI::showMainResourceForFrame):
(WebKit::WebInspectorUI::startPageProfiling):
(WebKit::WebInspectorUI::stopPageProfiling):
(WebKit::WebInspectorUI::didSave):
(WebKit::WebInspectorUI::didAppend):
(WebKit::WebInspectorUI::sendMessageToFrontend):
(WebKit::WebInspectorUI::sendMessageToBackend):
(WebKit::WebInspectorUI::evaluateCommandOnLoad):
(WebKit::WebInspectorUI::evaluateExpressionOnLoad):
(WebKit::WebInspectorUI::evaluatePendingExpressions):

  • WebProcess/WebPage/WebInspectorUI.h: Added.

(WebKit::WebInspectorUI::page):
(WebKit::WebInspectorUI::didClose):
(WebKit::WebInspectorUI::didReceiveInvalidMessage):
(WebKit::WebInspectorUI::attachedBottom):
(WebKit::WebInspectorUI::attachedRight):
(WebKit::WebInspectorUI::detached):
(WebKit::WebInspectorUI::evaluateCommandOnLoad):

  • WebProcess/WebPage/WebInspectorUI.messages.in: Added.
  • WebProcess/WebPage/efl/WebInspectorUIEfl.cpp: Added.

(WebKit::WebInspectorUI::canSave):
(WebKit::WebInspectorUI::localizedStringsURL):

  • WebProcess/WebPage/gtk/WebInspectorUIGtk.cpp: Added.

(WebKit::WebInspectorUI::canSave):
(WebKit::WebInspectorUI::localizedStringsURL):

  • WebProcess/WebPage/mac/WebInspectorUIMac.mm: Added.

(WebKit::WebInspectorUI::canSave):
(WebKit::WebInspectorUI::localizedStringsURL):
Implement the InspectorFrontendClient and handle a connection to the inspected page's WebInspector.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):
(WebKit::WebPage::inspector):
(WebKit::WebPage::inspectorUI):
(WebKit::WebPage::didReceiveMessage):
Setup as a listener for WebInspectorUI messages.

  • WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::isInspectorPage): It is an Inspector page if we have a m_inspectorUI.

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::initializeProcessName):
Name the process "%@ Web Inspector" if it is an Inspector content process. Processes in that
context are not shared with multiple pages.

12:57 PM Changeset in webkit [173928] by dino@apple.com
  • 5 edits in trunk/Source/WebCore

[Yosemite] Button text doesn't go white while pushing the button, like it does for real buttons
​https://bugs.webkit.org/show_bug.cgi?id=137054
rdar://problem/17559038

Reviewed by NOBODY (OOPS!).

On Yosemite and above, system buttons paint with white-ish text when they
are pressed. Since this isn't exposed by API, I've hardcoded the value
into RenderThemeMac.

The actual state is exposed by adding a :active rule to html.css that
uses a new CSSValueKeyword: ActiveButtonText.

Unfortunately I can't find a way to test this, because the active state isn't
testable. We should really expose the Inspector's forcePseudoState function into
window.internals.

  • css/CSSValueKeywords.in: Add "activebuttontext".
  • css/html.css:

(input[type="button"]:active, input[type="submit"]:active, input[type="reset"]:active, input[type="file"]::-webkit-file-upload-button:active, button:active): New rule for active
button elements.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::systemColor): Handle CSSValueActivebuttontext as black.

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::systemColor): Handle CSSValueActivebuttontext as
white with 75% opacity.

12:52 PM Changeset in webkit [173927] by dino@apple.com
  • 2 edits in trunk/Source/WebKit2

Add a deprecated stub for WKPreferencesSetMultithreadedWebGLEnabled (and Get)
​https://bugs.webkit.org/show_bug.cgi?id=137071

Reviewed by Brent Fulgham.

Put in stubs for WKPreferencesSetMultithreadedWebGLEnabled and
WKPreferencesGetMultithreadedWebGLEnabled. These were removed in
r173776 but are still needed for nightly builds to link
(or will be once Yosemite nightlies are available).

  • Shared/API/c/WKDeprecatedFunctions.cpp:

(WKPreferencesSetMultithreadedWebGLEnabled):
(WKPreferencesGetMultithreadedWebGLEnabled):

12:24 PM Changeset in webkit [173926] by roger_fong@apple.com
  • 2 edits in trunk/Tools

[Windows] Tentative fix for Windows test bots.

  • Scripts/webkitpy/common/system/path.py:

(_CygPath.convert):

10:30 AM Changeset in webkit [173925] by commit-queue@webkit.org
  • 1 edit
    2 adds in trunk/LayoutTests

Add New Test for overrideMimeType in XMLHttpRequest.
​https://bugs.webkit.org/show_bug.cgi?id=137057

Patch by Shivakumar JM <​shiva.jm@samsung.com> on 2014-09-24
Reviewed by Alexey Proskuryakov.

As part of bug: ​https://bugs.webkit.org/show_bug.cgi?id=136699, add more tests to test overrideMimeType for all states.

  • http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror-expected.txt: Added.
  • http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html: Added.
10:26 AM Changeset in webkit [173924] by ap@apple.com
  • 13 edits in trunk/Tools

Change more build.webkit.org links to https
​https://bugs.webkit.org/show_bug.cgi?id=137049

Reviewed by Csaba Osztrogonác.

Fix appspot, svn.webkit.org and Trac links.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:

(ViewController.prototype._domForBuildName):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:

(.):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:

(EWS):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:

(TestHistory):

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
9:59 AM Changeset in webkit [173923] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit2

[iOS] Fix the iOS build after <​http://trac.webkit.org/changeset/173893>
(​https://bugs.webkit.org/show_bug.cgi?id=137007)

Add closing parenthesis characters that were inadvertently removed in <​http://trac.webkit.org/changeset/173893>.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setAssistedNodeSelectedIndex):
(WebKit::WebPage::getAssistedNodeInformation):

9:11 AM Changeset in webkit [173922] by llango.u-szeged@partner.samsung.com
  • 4 edits in trunk

Update the list of u-szeged contributors.

Rubber-stamped by Csaba Osztrogonác <Csaba Osztrogonác>.

Tools:

  • Scripts/webkitpy/common/config/contributors.json:

Websites/webkit.org:

  • team.html:
8:56 AM Changeset in webkit [173921] by Chris Dumez
  • 34 edits in trunk/Source/WebCore

Use is<SVG*Element>() instead of isSVG*Element()
​https://bugs.webkit.org/show_bug.cgi?id=137058

Reviewed by Dirk Schulze.

Use is<SVG*Element>() instead of isSVG*Element() and drop support for
generated isSVG*Element().

No new tests, no behavior change.

  • css/CSSCursorImageValue.cpp:

(WebCore::resourceReferencedByCursorElement):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::useSVGZoomRulesForLength):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):

  • dom/ScriptElement.cpp:

(WebCore::toScriptElementIfPossible):

  • dom/make_names.pl:

(printTypeHelpers):

  • editing/gtk/EditorGtk.cpp:

(WebCore::elementURL):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::isLiveLink):

  • rendering/svg/RenderSVGEllipse.cpp:

(WebCore::RenderSVGEllipse::calculateRadiiAndCenter):

  • rendering/svg/RenderSVGTransformableContainer.cpp:

(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):

  • rendering/svg/SVGPathData.cpp:

(WebCore::updatePathFromCircleElement):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::operator<<):

  • rendering/svg/SVGResources.cpp:

(WebCore::targetReferenceFromResource):

  • svg/SVGAltGlyphDefElement.cpp:

(WebCore::SVGAltGlyphDefElement::hasValidGlyphElements):

  • svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::hasValidGlyphElements):

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::hasValidAttributeType):

  • svg/SVGDocument.cpp:

(WebCore::SVGDocument::rootElement):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::isOutermostSVGSVGElement):
(WebCore::SVGElement::ownerSVGElement):
(WebCore::SVGElement::viewportElement):

  • svg/SVGFEComponentTransferElement.cpp:

(WebCore::SVGFEComponentTransferElement::build):

  • svg/SVGFELightElement.cpp:

(WebCore::SVGFELightElement::findLightElement):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

  • svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::ensureGlyphCache):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::associatedFontElement):
(WebCore::SVGFontFaceElement::rebuildFontFace):

  • svg/SVGFontFaceSrcElement.cpp:

(WebCore::SVGFontFaceSrcElement::srcValue):
(WebCore::SVGFontFaceSrcElement::childrenChanged):

  • svg/SVGGlyphElement.cpp:

(WebCore::SVGGlyphElement::invalidateGlyphCache):

  • svg/SVGHKernElement.cpp:

(WebCore::SVGHKernElement::insertedInto):
(WebCore::SVGHKernElement::removedFrom):

  • svg/SVGLengthContext.cpp:

(WebCore::SVGLengthContext::determineViewport):

  • svg/SVGLocatable.cpp:

(WebCore::isViewportElement):

  • svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::pathElement):
(WebCore::SVGMPathElement::notifyParentOfPathChange):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::invalidateMPathDependencies):

  • svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::collectPatternAttributes):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::setupInitialView):

  • svg/SVGUseElement.cpp:

(WebCore::dumpInstanceTree):
(WebCore::SVGUseElement::expandUseElementsInShadowTree):

  • svg/SVGVKernElement.cpp:

(WebCore::SVGVKernElement::insertedInto):
(WebCore::SVGVKernElement::removedFrom):

8:40 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos
(diff)
8:11 AM Changeset in webkit [173920] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.6.0

WebKitGTK+ 2.6.0

8:10 AM Changeset in webkit [173919] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.6

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.6.0 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.6.0.
6:38 AM Changeset in webkit [173918] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.6/Source/JavaScriptCore

Merge r173886 - [CLoop] - Fix CLoop on the 32-bit Big-Endians
​https://bugs.webkit.org/show_bug.cgi?id=137020

Patch by Tomas Popela <​tpopela@redhat.com> on 2014-09-23
Reviewed by Mark Lam.

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
6:37 AM Changeset in webkit [173917] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r173848 - WebSocket crash when a connection is closed from server side
​https://bugs.webkit.org/show_bug.cgi?id=137009
rdar://problem/18333977
rdar://problem/12708225

Reviewed by Brady Eidson.

I don't think that this can be tested with our test server.

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::WebSocketChannel): Added logging.
(WebCore::WebSocketChannel::~WebSocketChannel): Ditto.
(WebCore::WebSocketChannel::close): Protect self, because startClosingHandshake
can release the last reference.
(WebCore::WebSocketChannel::fail): Added an assertion that the channel is always
closed after this function.
(WebCore::WebSocketChannel::startClosingHandshake): Protect self, and don't change
the stack from closed back to closing if after failing to send closing handshake.
(WebCore::WebSocketChannel::processOutgoingFrameQueue): Protect self.

6:36 AM Changeset in webkit [173916] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.6

Merge r173845 - Bad cast in isValidColumnSpanner.
​https://bugs.webkit.org/show_bug.cgi?id=133380.

Reviewed by Simon Fraser.

Source/WebCore:

Added fast/multicol/multicol-crazy-nesting.html

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::isValidColumnSpanner):
The crawl up the chain looking for unsplittable objects should use containing blocks
and not be casting to parent boxes. You can have an inline in the parent chain, so
this was not the right way to walk up the tree.

LayoutTests:

  • fast/multicol/multicol-crazy-nesting-expected.txt: Added.
  • fast/multicol/multicol-crazy-nesting.html: Added.
6:35 AM Changeset in webkit [173915] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.6

Merge r173843 - ASSERT in RenderMultiColumnSet::requiresBalancing.
​https://bugs.webkit.org/show_bug.cgi?id=136376.

Reviewed by David Kilzer.

Source/WebCore:

Added fast/multicol/multicol-selection.html.

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::isValidColumnSpanner):
Don't allow an object to become a spanner if it does not have the flow
thread as its containing block. Otherwise the flow thread won't get notified
of spanner placeholder insertions, and so the spanner ends up orphaned.

LayoutTests:

  • fast/multicol/multicol-selection-expected.txt: Added.
  • fast/multicol/multicol-selection.html: Added.
6:33 AM Changeset in webkit [173914] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r173836 - REGRESSION(r173631): It broke the !ENABLE(VIDEO) build
​https://bugs.webkit.org/show_bug.cgi?id=136946

Reviewed by Jer Noble.

No new tests required, no new functionality.

  • page/DragController.cpp:

(WebCore::DragController::startDrag):

5:59 AM Changeset in webkit [173913] by Carlos Garcia Campos
  • 5 edits
    1 copy
    104 adds in releases/WebKitGTK/webkit-2.6/Source/WebInspectorUI

Merge r173912 - Unreviewed. Add more free icons for the Web Inspector in GTK+

Patch by Andres Gomez <Andres Gomez> on 2014-09-24

  • UserInterface/Images/gtk/AUTHORS:
  • UserInterface/Images/gtk/ApplicationCache.png: Added.
  • UserInterface/Images/gtk/​ApplicationCache@2x.png: Added.
  • UserInterface/Images/gtk/BottomUpTree.svg: Added.
  • UserInterface/Images/gtk/Breakpoint.png: Added.
  • UserInterface/Images/gtk/​Breakpoint@2x.png: Added.
  • UserInterface/Images/gtk/BreakpointButton.svg:
  • UserInterface/Images/gtk/BreakpointInactive.png: Added.
  • UserInterface/Images/gtk/​BreakpointInactive@2x.png: Added.
  • UserInterface/Images/gtk/BreakpointInactiveButton.svg:
  • UserInterface/Images/gtk/COPYING:
  • UserInterface/Images/gtk/COPYING_CCBYSA3: Copied from Source/WebInspectorUI/UserInterface/Images/gtk/COPYING.
  • UserInterface/Images/gtk/ClippingCSS.png: Added.
  • UserInterface/Images/gtk/​ClippingCSS@2x.png: Added.
  • UserInterface/Images/gtk/ClippingGeneric.png: Added.
  • UserInterface/Images/gtk/​ClippingGeneric@2x.png: Added.
  • UserInterface/Images/gtk/ClippingJS.png: Added.
  • UserInterface/Images/gtk/​ClippingJS@2x.png: Added.
  • UserInterface/Images/gtk/CloseTimeline.png: Added.
  • UserInterface/Images/gtk/​CloseTimeline@2x.png: Added.
  • UserInterface/Images/gtk/ColorIcon.png: Added.
  • UserInterface/Images/gtk/​ColorIcon@2x.png: Added.
  • UserInterface/Images/gtk/Colors.png: Added.
  • UserInterface/Images/gtk/​Colors@2x.png: Added.
  • UserInterface/Images/gtk/ColorsLarge.png: Added.
  • UserInterface/Images/gtk/​ColorsLarge@2x.png: Added.
  • UserInterface/Images/gtk/Database.png: Added.
  • UserInterface/Images/gtk/​Database@2x.png: Added.
  • UserInterface/Images/gtk/DatabaseTable.png: Added.
  • UserInterface/Images/gtk/​DatabaseTable@2x.png: Added.
  • UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg: Added.
  • UserInterface/Images/gtk/Issues.svg: Added.
  • UserInterface/Images/gtk/IssuesEnabled.svg: Added.
  • UserInterface/Images/gtk/LayerBorders.svg: Added.
  • UserInterface/Images/gtk/LessColumns.svg: Added.
  • UserInterface/Images/gtk/LocalStorage.png: Added.
  • UserInterface/Images/gtk/​LocalStorage@2x.png: Added.
  • UserInterface/Images/gtk/Locked.svg: Added.
  • UserInterface/Images/gtk/Logs.svg: Added.
  • UserInterface/Images/gtk/Memory.svg: Added.
  • UserInterface/Images/gtk/MoreColumns.svg: Added.
  • UserInterface/Images/gtk/Native.svg: Added.
  • UserInterface/Images/gtk/NavigationItemAngleBrackets.svg: Added.
  • UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg: Added.
  • UserInterface/Images/gtk/NavigationItemBug.svg: Added.
  • UserInterface/Images/gtk/NavigationItemCurleyBraces.svg: Added.
  • UserInterface/Images/gtk/NavigationItemFile.svg: Added.
  • UserInterface/Images/gtk/NavigationItemLayers.svg: Added.
  • UserInterface/Images/gtk/NavigationItemLog.svg: Added.
  • UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg: Added.
  • UserInterface/Images/gtk/NavigationItemStopwatch.svg: Added.
  • UserInterface/Images/gtk/NavigationItemStorage.svg: Added.
  • UserInterface/Images/gtk/NavigationItemTrash.svg: Added.
  • UserInterface/Images/gtk/NavigationItemVariable.svg: Added.
  • UserInterface/Images/gtk/Network.png: Added.
  • UserInterface/Images/gtk/​Network@2x.png: Added.
  • UserInterface/Images/gtk/NetworkLarge.png: Added.
  • UserInterface/Images/gtk/​NetworkLarge@2x.png: Added.
  • UserInterface/Images/gtk/Pause.svg: Added.
  • UserInterface/Images/gtk/Percent.svg: Added.
  • UserInterface/Images/gtk/Plus.svg: Added.
  • UserInterface/Images/gtk/PseudoElement.svg: Added.
  • UserInterface/Images/gtk/Reflection.svg: Added.
  • UserInterface/Images/gtk/Reload.svg: Added.
  • UserInterface/Images/gtk/Request.svg: Added.
  • UserInterface/Images/gtk/Response.svg: Added.
  • UserInterface/Images/gtk/ResultLine.svg: Added.
  • UserInterface/Images/gtk/Resume.svg: Added.
  • UserInterface/Images/gtk/SessionStorage.png: Added.
  • UserInterface/Images/gtk/​SessionStorage@2x.png: Added.
  • UserInterface/Images/gtk/ShadowDOM.svg: Added.
  • UserInterface/Images/gtk/SourceCode.svg: Added.
  • UserInterface/Images/gtk/SplitToggleDown.svg: Added.
  • UserInterface/Images/gtk/SplitToggleUp.svg: Added.
  • UserInterface/Images/gtk/StepInto.svg: Added.
  • UserInterface/Images/gtk/StepOut.svg: Added.
  • UserInterface/Images/gtk/StepOver.svg: Added.
  • UserInterface/Images/gtk/StyleRuleAuthor.svg: Added.
  • UserInterface/Images/gtk/StyleRuleInherited.svg: Added.
  • UserInterface/Images/gtk/StyleRuleInheritedElement.svg: Added.
  • UserInterface/Images/gtk/StyleRuleInspector.svg: Added.
  • UserInterface/Images/gtk/StyleRuleUser.svg: Added.
  • UserInterface/Images/gtk/StyleRuleUserAgent.svg: Added.
  • UserInterface/Images/gtk/Time.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordAnimation.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordEvent.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordLayout.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordPaint.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordStyle.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordTimer.svg: Added.
  • UserInterface/Images/gtk/Undock.svg: Added.
  • UserInterface/Images/gtk/UserInputPrompt.svg: Added.
  • UserInterface/Images/gtk/UserInputPromptPrevious.svg: Added.
  • UserInterface/Images/gtk/UserInputResult.svg: Added.
  • UserInterface/Images/gtk/Warning.svg: Added.
  • UserInterface/Images/gtk/Weight.svg: Added.
5:53 AM Changeset in webkit [173912] by Carlos Garcia Campos
  • 5 edits
    1 copy
    104 adds in trunk/Source/WebInspectorUI

Unreviewed. Add more free icons for the Web Inspector in GTK+

Patch by Andres Gomez <Andres Gomez> on 2014-09-24

  • UserInterface/Images/gtk/AUTHORS:
  • UserInterface/Images/gtk/ApplicationCache.png: Added.
  • UserInterface/Images/gtk/​ApplicationCache@2x.png: Added.
  • UserInterface/Images/gtk/BottomUpTree.svg: Added.
  • UserInterface/Images/gtk/Breakpoint.png: Added.
  • UserInterface/Images/gtk/​Breakpoint@2x.png: Added.
  • UserInterface/Images/gtk/BreakpointButton.svg:
  • UserInterface/Images/gtk/BreakpointInactive.png: Added.
  • UserInterface/Images/gtk/​BreakpointInactive@2x.png: Added.
  • UserInterface/Images/gtk/BreakpointInactiveButton.svg:
  • UserInterface/Images/gtk/COPYING:
  • UserInterface/Images/gtk/COPYING_CCBYSA3: Copied from Source/WebInspectorUI/UserInterface/Images/gtk/COPYING.
  • UserInterface/Images/gtk/ClippingCSS.png: Added.
  • UserInterface/Images/gtk/​ClippingCSS@2x.png: Added.
  • UserInterface/Images/gtk/ClippingGeneric.png: Added.
  • UserInterface/Images/gtk/​ClippingGeneric@2x.png: Added.
  • UserInterface/Images/gtk/ClippingJS.png: Added.
  • UserInterface/Images/gtk/​ClippingJS@2x.png: Added.
  • UserInterface/Images/gtk/CloseTimeline.png: Added.
  • UserInterface/Images/gtk/​CloseTimeline@2x.png: Added.
  • UserInterface/Images/gtk/ColorIcon.png: Added.
  • UserInterface/Images/gtk/​ColorIcon@2x.png: Added.
  • UserInterface/Images/gtk/Colors.png: Added.
  • UserInterface/Images/gtk/​Colors@2x.png: Added.
  • UserInterface/Images/gtk/ColorsLarge.png: Added.
  • UserInterface/Images/gtk/​ColorsLarge@2x.png: Added.
  • UserInterface/Images/gtk/Database.png: Added.
  • UserInterface/Images/gtk/​Database@2x.png: Added.
  • UserInterface/Images/gtk/DatabaseTable.png: Added.
  • UserInterface/Images/gtk/​DatabaseTable@2x.png: Added.
  • UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg: Added.
  • UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg: Added.
  • UserInterface/Images/gtk/Issues.svg: Added.
  • UserInterface/Images/gtk/IssuesEnabled.svg: Added.
  • UserInterface/Images/gtk/LayerBorders.svg: Added.
  • UserInterface/Images/gtk/LessColumns.svg: Added.
  • UserInterface/Images/gtk/LocalStorage.png: Added.
  • UserInterface/Images/gtk/​LocalStorage@2x.png: Added.
  • UserInterface/Images/gtk/Locked.svg: Added.
  • UserInterface/Images/gtk/Logs.svg: Added.
  • UserInterface/Images/gtk/Memory.svg: Added.
  • UserInterface/Images/gtk/MoreColumns.svg: Added.
  • UserInterface/Images/gtk/Native.svg: Added.
  • UserInterface/Images/gtk/NavigationItemAngleBrackets.svg: Added.
  • UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg: Added.
  • UserInterface/Images/gtk/NavigationItemBug.svg: Added.
  • UserInterface/Images/gtk/NavigationItemCurleyBraces.svg: Added.
  • UserInterface/Images/gtk/NavigationItemFile.svg: Added.
  • UserInterface/Images/gtk/NavigationItemLayers.svg: Added.
  • UserInterface/Images/gtk/NavigationItemLog.svg: Added.
  • UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg: Added.
  • UserInterface/Images/gtk/NavigationItemStopwatch.svg: Added.
  • UserInterface/Images/gtk/NavigationItemStorage.svg: Added.
  • UserInterface/Images/gtk/NavigationItemTrash.svg: Added.
  • UserInterface/Images/gtk/NavigationItemVariable.svg: Added.
  • UserInterface/Images/gtk/Network.png: Added.
  • UserInterface/Images/gtk/​Network@2x.png: Added.
  • UserInterface/Images/gtk/NetworkLarge.png: Added.
  • UserInterface/Images/gtk/​NetworkLarge@2x.png: Added.
  • UserInterface/Images/gtk/Pause.svg: Added.
  • UserInterface/Images/gtk/Percent.svg: Added.
  • UserInterface/Images/gtk/Plus.svg: Added.
  • UserInterface/Images/gtk/PseudoElement.svg: Added.
  • UserInterface/Images/gtk/Reflection.svg: Added.
  • UserInterface/Images/gtk/Reload.svg: Added.
  • UserInterface/Images/gtk/Request.svg: Added.
  • UserInterface/Images/gtk/Response.svg: Added.
  • UserInterface/Images/gtk/ResultLine.svg: Added.
  • UserInterface/Images/gtk/Resume.svg: Added.
  • UserInterface/Images/gtk/SessionStorage.png: Added.
  • UserInterface/Images/gtk/​SessionStorage@2x.png: Added.
  • UserInterface/Images/gtk/ShadowDOM.svg: Added.
  • UserInterface/Images/gtk/SourceCode.svg: Added.
  • UserInterface/Images/gtk/SplitToggleDown.svg: Added.
  • UserInterface/Images/gtk/SplitToggleUp.svg: Added.
  • UserInterface/Images/gtk/StepInto.svg: Added.
  • UserInterface/Images/gtk/StepOut.svg: Added.
  • UserInterface/Images/gtk/StepOver.svg: Added.
  • UserInterface/Images/gtk/StyleRuleAuthor.svg: Added.
  • UserInterface/Images/gtk/StyleRuleInherited.svg: Added.
  • UserInterface/Images/gtk/StyleRuleInheritedElement.svg: Added.
  • UserInterface/Images/gtk/StyleRuleInspector.svg: Added.
  • UserInterface/Images/gtk/StyleRuleUser.svg: Added.
  • UserInterface/Images/gtk/StyleRuleUserAgent.svg: Added.
  • UserInterface/Images/gtk/Time.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordAnimation.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordEvent.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordLayout.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordPaint.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordStyle.svg: Added.
  • UserInterface/Images/gtk/TimelineRecordTimer.svg: Added.
  • UserInterface/Images/gtk/Undock.svg: Added.
  • UserInterface/Images/gtk/UserInputPrompt.svg: Added.
  • UserInterface/Images/gtk/UserInputPromptPrevious.svg: Added.
  • UserInterface/Images/gtk/UserInputResult.svg: Added.
  • UserInterface/Images/gtk/Warning.svg: Added.
  • UserInterface/Images/gtk/Weight.svg: Added.
2:14 AM Changeset in webkit [173911] by commit-queue@webkit.org
  • 7 edits
    3 deletes in trunk

Unreviewed, rolling out r173839.
​https://bugs.webkit.org/show_bug.cgi?id=137062

NumberConstruct should no longer use static tables (Requested
by dpino on #webkit).

Reverted changeset:

"Simple ES6 feature: Number constructor extras"
​https://bugs.webkit.org/show_bug.cgi?id=131707
​http://trac.webkit.org/changeset/173839

1:35 AM WebKitGTK/KeepingTheTreeGreen edited by ltilve@igalia.com
(diff)
12:56 AM Changeset in webkit [173910] by commit-queue@webkit.org
  • 5 edits
    6 adds in trunk

Remove the style marking from :nth-child()
​https://bugs.webkit.org/show_bug.cgi?id=137055

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-09-24
Reviewed by Andreas Kling.

Source/WebCore:

Previously, :nth-child() had to mark the RenderStyle as unique in order
to prevent it from being used for style sharing.

After r173229, :nth-child() use the more generic element marking
"StyleIsAffectedByPreviousSibling".

In StyleResolver::canShareStyleWithElement(), StyleIsAffectedByPreviousSibling
is already used to prevent style sharing of those elements, making the "Unique"
flag redundant.

Since it is now useless, remove the style marking from SelectorChecker and the CSS JIT.

Tests: fast/css/nth-child-style-sharing-even.html

fast/css/nth-child-style-sharing-fixed-integer.html
fast/css/nth-child-style-sharing-odd.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
(WebCore::SelectorCompiler::setElementChildIndexAndUpdateStyle): Deleted.

  • rendering/style/RenderStyle.h:

LayoutTests:

Add basic tests for style sharing with :nth-child().

  • fast/css/nth-child-style-sharing-even-expected.html: Added.
  • fast/css/nth-child-style-sharing-even.html: Added.
  • fast/css/nth-child-style-sharing-fixed-integer-expected.html: Added.
  • fast/css/nth-child-style-sharing-fixed-integer.html: Added.
  • fast/css/nth-child-style-sharing-odd-expected.html: Added.
  • fast/css/nth-child-style-sharing-odd.html: Added.

Sep 23, 2014:

11:31 PM WebKitGTK/2.6.x edited by tpopela@redhat.com
(diff)
10:10 PM Changeset in webkit [173909] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

2014-09-23 Geoffrey Garen <​ggaren@apple.com>

Rolled out r173346.

bmalloc should honor the FastMalloc statistics API
​https://bugs.webkit.org/show_bug.cgi?id=136592

This didn't really work. Because we allow ranges with and without
physical pages to merge, and we allow double-committing and
double-decommitting, we can't rely on commit actions to track memory
footprint.

  • wtf/FastMalloc.cpp: (WTF::fastMallocStatistics):
10:07 PM Changeset in webkit [173908] by ggaren@apple.com
  • 6 edits in trunk/Source/bmalloc

2014-09-23 Geoffrey Garen <​ggaren@apple.com>

Rolled out r173346.

bmalloc should honor the FastMalloc statistics API
​https://bugs.webkit.org/show_bug.cgi?id=136592

This didn't really work. Because we allow ranges with and without
physical pages to merge, and we allow double-committing and
double-decommitting, we can't rely on commit actions to track memory
footprint.

  • bmalloc/Heap.cpp: (bmalloc::Heap::size): Deleted. (bmalloc::Heap::capacity): Deleted.
  • bmalloc/Heap.h:
  • bmalloc/VMHeap.cpp: (bmalloc::VMHeap::VMHeap): (bmalloc::VMHeap::allocateSmallChunk): (bmalloc::VMHeap::allocateMediumChunk): (bmalloc::VMHeap::allocateLargeChunk):
  • bmalloc/VMHeap.h: (bmalloc::VMHeap::allocateSmallPage): (bmalloc::VMHeap::allocateMediumPage): (bmalloc::VMHeap::allocateLargeRange): (bmalloc::VMHeap::deallocateSmallPage): (bmalloc::VMHeap::deallocateMediumPage): (bmalloc::VMHeap::deallocateLargeRange): (bmalloc::VMHeap::size): Deleted. (bmalloc::VMHeap::capacity): Deleted.
  • bmalloc/bmalloc.h: (bmalloc::api::heapSize): Deleted. (bmalloc::api::heapCapacity): Deleted.
8:31 PM Changeset in webkit [173907] by Chris Dumez
  • 9 edits in trunk/Source/WebCore

Add support for is<HTML*Element>() for type checking
​https://bugs.webkit.org/show_bug.cgi?id=137015

Reviewed by Benjamin Poulain.

Add support for is<HTML*Element>() for type checking while keeping
support for the legacy toHTML*Element() form until the code base is
ported.

toHTML*Element() helpers are now macros to the new is<HTML*Element>()
type checking helpers.

No new tests, no behavior change.

  • dom/Document.cpp:

(WebCore::Document::setTitle):

  • dom/Element.cpp:

(WebCore::Element::childShouldCreateRenderer):

  • dom/Element.h:

(WebCore::is):
(WebCore::downcast):
(WebCore::isElementOfType): Deleted.

  • dom/ElementAncestorIterator.h:

(WebCore::lineageOfType):

  • dom/ElementIterator.h:

(WebCore::findElementAncestorOfType):

  • dom/ElementTraversal.h:

(WebCore::Traversal<ElementType>::firstChildTemplate):
(WebCore::Traversal<ElementType>::lastChildTemplate):
(WebCore::Traversal<ElementType>::firstWithinTemplate):
(WebCore::Traversal<ElementType>::lastWithinTemplate):
(WebCore::Traversal<ElementType>::nextTemplate):
(WebCore::Traversal<ElementType>::previous):
(WebCore::Traversal<ElementType>::nextSibling):
(WebCore::Traversal<ElementType>::previousSibling):
(WebCore::Traversal<ElementType>::nextSkippingChildren):

  • dom/TypedElementDescendantIterator.h:

(WebCore::TypedElementDescendantIteratorAdapter<ElementType>::from):
(WebCore::TypedElementDescendantConstIteratorAdapter<ElementType>::from):

  • dom/make_names.pl:

(printTypeHelpers):

8:17 PM Changeset in webkit [173906] by benjamin@webkit.org
  • 3 edits
    8 adds in trunk

The style resolution cache applies properties incorrectly whenever direction != ltr
​https://bugs.webkit.org/show_bug.cgi?id=137052

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-09-23
Reviewed by Andreas Kling.

Source/WebCore:

The optimization r135021 introduced a bug whenever the direction of subtree is not
uniform in the whole page.

When StyleResolver::applyMatchedProperties() resolves the style, some properties are
resolved differently based on the writing-mode and the direction.

In isCacheableInMatchedPropertiesCache(), the cases for writing-mode are already handled
by not caching any style with anything else than the default.
The direction was ignored, causing the bugs solved here.

Tests: css3/flexbox/flex-flow-2.html

fast/css/style-resolver-cache-direction-1.html
fast/css/style-resolver-cache-direction-2.html
fast/css/style-resolver-cache-direction-3.html

  • css/StyleResolver.cpp:

(WebCore::isCacheableInMatchedPropertiesCache):

LayoutTests:

  • css3/flexbox/flex-flow-2-expected.txt: Added.
  • css3/flexbox/flex-flow-2.html: Added.

The test flex-flow.html should have uncovered the bug. It did not because it uses
:nth-child(), which disable style optimizations.

flex-flow-2.html is a copy of flex-flow.html using classes instead of :nth-child().
This would have caught the bug.

  • fast/css/style-resolver-cache-direction-1-expected.html: Added.
  • fast/css/style-resolver-cache-direction-1.html: Added.
  • fast/css/style-resolver-cache-direction-2-expected.html: Added.
  • fast/css/style-resolver-cache-direction-2.html: Added.
  • fast/css/style-resolver-cache-direction-3-expected.html: Added.
  • fast/css/style-resolver-cache-direction-3.html: Added.

New basic tests for the fix.

6:45 PM Changeset in webkit [173905] by Chris Dumez
  • 18 edits in trunk/Source/WebCore

Have CSS classes' methods return more references
​https://bugs.webkit.org/show_bug.cgi?id=137036

Reviewed by Ryosuke Niwa.

Have CSS classes' methods return more references instead of pointers
when possible.

No new tests, no behavior change.

  • css/CSSFontFaceRule.cpp:

(WebCore::CSSFontFaceRule::style):

  • css/CSSFontFaceRule.h:
  • css/CSSGroupingRule.cpp:

(WebCore::CSSGroupingRule::cssRules):

  • css/CSSGroupingRule.h:
  • css/CSSImportRule.cpp:

(WebCore::CSSImportRule::media):

  • css/CSSImportRule.h:
  • css/CSSPageRule.cpp:

(WebCore::CSSPageRule::style):

  • css/CSSPageRule.h:
  • css/CSSStyleRule.cpp:

(WebCore::CSSStyleRule::style):

  • css/CSSStyleRule.h:
  • css/WebKitCSSKeyframeRule.cpp:

(WebCore::WebKitCSSKeyframeRule::style):

  • css/WebKitCSSKeyframeRule.h:
  • css/WebKitCSSKeyframesRule.cpp:

(WebCore::WebKitCSSKeyframesRule::cssRules):

  • css/WebKitCSSKeyframesRule.h:
  • css/WebKitCSSViewportRule.cpp:

(WebCore::WebKitCSSViewportRule::style):

  • css/WebKitCSSViewportRule.h:
  • inspector/InspectorStyleSheet.cpp:

(WebCore::asCSSRuleList):
(WebCore::fillMediaListChain):
(WebCore::InspectorStyleSheet::setRuleSelector):
(WebCore::InspectorStyleSheet::deleteRule):
(WebCore::InspectorStyleSheet::buildObjectForSelectorList):
(WebCore::InspectorStyleSheet::buildObjectForRule):
(WebCore::InspectorStyleSheet::styleForId):
(WebCore::InspectorStyleSheet::ruleIndexByStyle):
(WebCore::InspectorStyleSheet::ruleId):
(WebCore::InspectorStyleSheet::revalidateStyle):

5:52 PM Changeset in webkit [173904] by roger_fong@apple.com
  • 4 edits in trunk

[Windows] Enable CSS Supports Rule on Windows.

  • win/tools/vsprops/FeatureDefines.props:
  • css/CSSAllInOne.cpp:
5:46 PM Changeset in webkit [173903] by roger_fong@apple.com
  • 3 edits in trunk/Tools

[Windows] More debugging for the Windows bots.

  • Scripts/webkitpy/common/system/path.py:

(_CygPath):

5:16 PM Changeset in webkit [173902] by roger_fong@apple.com
  • 2 edits in trunk/Tools

Unreviewed. Fix for r173899, those tabs should be spaces.

  • Scripts/webkitpy/port/driver.py:

(Driver._command_from_driver_input):
(Driver): Deleted.

5:08 PM Changeset in webkit [173901] by roger_fong@apple.com
  • 2 edits
    3 adds in trunk/LayoutTests

[Windows] More windows test gardening of some fast/dom tests.

  • platform/win/TestExpectations:
  • platform/win/fast/dom/NavigatorContentUtils: Added.
  • platform/win/fast/dom/NavigatorContentUtils/is-protocol-handler-registered-expected.txt: Added.
  • platform/win/fast/dom/navigator-detached-no-crash-expected.txt: Added.
4:58 PM Changeset in webkit [173900] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Win] 64-bit Build fix after r173882.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add correct 64-bit mangled symbol name.
4:34 PM Changeset in webkit [173899] by roger_fong@apple.com
  • 2 edits in trunk/Tools

[Windows] Add some logging to debug a problem with the Windows bots that causes layout tests to exit early.

  • Scripts/webkitpy/port/driver.py:

(Driver):

4:07 PM Changeset in webkit [173898] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Rollout 173848. rdar://problem/12708225

3:30 PM Changeset in webkit [173897] by Lucas Forschler
  • 2 edits in branches/safari-600.1-branch/Source/WebCore

Merged r173848. rdar://problem/12708225

3:29 PM Changeset in webkit [173896] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DebuggerCallFrame::invalidate() should invalidate all DebuggerScope chains.
<​https://webkit.org/b/137045>

Reviewed by Geoffrey Garen.

DebuggerCallFrame::invalidate() currently invalidates all DebuggerCallFrames
in the debugger stack, but only invalidates the DebuggerScope chain of the
top most frame. We should also invalidate all the DebuggerScope chains of
the other frames in the debugger stack.

  • debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::invalidate):

  • debugger/DebuggerScope.cpp:

(JSC::DebuggerScope::invalidateChain):

3:27 PM Changeset in webkit [173895] by Chris Dumez
  • 27 edits in trunk/Source

Unreviewed build fix after r173893.

Partial revert of r173893 to fix debug builds.

Source/WebCore:

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::text):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::makeContextStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::makeElementStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::isPlaceholderShown):

  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv):

  • dom/Element.cpp:

(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
(WebCore::Element::updateName):
(WebCore::Element::updateId):

  • editing/Editor.cpp:

(WebCore::Editor::selectionForCommand):
(WebCore::findFirstMarkable):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectAll):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::matchesReadWritePseudoClass):
(WebCore::HTMLElement::directionality):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem):

  • html/HTMLPlugInImageElement.cpp:

(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::enclosingTextFormControl):

  • page/FrameView.cpp:

(WebCore::FrameView::addEmbeddedObjectToUpdate):
(WebCore::FrameView::updateEmbeddedObject):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::absolutePDFURL):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintContents):
(WebCore::RenderEmbeddedObject::layout):

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::plugInImageElement):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::textFormControlElement):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):

  • testing/Internals.cpp:

(WebCore::Internals::visiblePlaceholder):

Source/WebKit/win:

  • DOMHTMLClasses.cpp:

(DOMHTMLDocument::URL):
(DOMHTMLDocument::body):
(DOMHTMLDocument::forms):

Source/WebKit2:

  • WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:

(WebKit::PDFPluginTextAnnotation::value):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::initializePlugin):
(WebKit::PluginView::pluginSnapshotTimerFired):
(WebKit::PluginView::pluginDidReceiveUserInteraction):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):

3:16 PM Changeset in webkit [173894] by Brent Fulgham
  • 6 edits in trunk/Source/WebCore

Implement snapping behavior for Mac overflow scrolling
​https://bugs.webkit.org/show_bug.cgi?id=135774

Patch by Wenson Hsieh <Wenson Hsieh> on 2014-09-22
Reviewed by Beth Dakin.

Hooks into AxisScrollSnapAnimator to implement overflow scroll snapping on Mac.

We need to find a way to test this!

  • dom/Element.cpp:

(WebCore::Element::dispatchWheelEvent):

  • page/EventHandler.cpp:

(WebCore::handleWheelEventInAppropriateEnclosingBoxForSingleAxis):

  • platform/ScrollAnimator.cpp:

(WebCore::ScrollAnimator::handleWheelEvent):
(WebCore::ScrollAnimator::updateScrollAnimatorsAndTimers):
(WebCore::ScrollAnimator::scrollOffsetInAxis):
(WebCore::ScrollAnimator::immediateScrollInAxis):
(WebCore::ScrollAnimator::startScrollSnapTimer):
(WebCore::ScrollAnimator::stopScrollSnapTimer):
(WebCore::ScrollAnimator::horizontalScrollSnapTimerFired):
(WebCore::ScrollAnimator::verticalScrollSnapTimerFired):

  • platform/ScrollAnimator.h:
  • platform/mac/AxisScrollSnapAnimator.h:
  • platform/mac/AxisScrollSnapAnimator.mm:

(WebCore::AxisScrollSnapAnimator::AxisScrollSnapAnimator):
(WebCore::AxisScrollSnapAnimator::beginScrollSnapAnimation):
(WebCore::AxisScrollSnapAnimator::endScrollSnapAnimation):
(WebCore::AxisScrollSnapAnimator::initializeGlideParameters):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateScrollInfoAfterLayout):

3:03 PM Changeset in webkit [173893] by Chris Dumez
  • 155 edits in trunk/Source

Use downcast<HTML*Element>() instead of toHTML*Element()
​https://bugs.webkit.org/show_bug.cgi?id=137007

Reviewed by Benjamin Poulain.

Source/WebCore:

Use downcast<HTML*Element>() instead of toHTML*Element() and drop
transition macros for toHTML*Element().

This patch also cleans up the surrounding code.

No new tests, no behavior change.

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::focusedUIElementForPage):
(WebCore::AXObjectCache::labelChanged):

  • accessibility/AccessibilityListBox.cpp:

(WebCore::AccessibilityListBox::canSetSelectedChildrenAttribute):
(WebCore::AccessibilityListBox::addChildren):

  • accessibility/AccessibilityListBoxOption.cpp:

(WebCore::AccessibilityListBoxOption::isSelected):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):

  • accessibility/AccessibilityMediaControls.cpp:

(WebCore::AccessibilityMediaTimeline::valueDescription):

  • accessibility/AccessibilityMenuListOption.cpp:

(WebCore::AccessibilityMenuListOption::isEnabled):
(WebCore::AccessibilityMenuListOption::isSelected):
(WebCore::AccessibilityMenuListOption::setSelected):
(WebCore::AccessibilityMenuListOption::stringValue):

  • accessibility/AccessibilityMenuListPopup.cpp:

(WebCore::AccessibilityMenuListPopup::addChildren):

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::isNativeTextControl):
(WebCore::AccessibilityNodeObject::isNativeImage):
(WebCore::AccessibilityNodeObject::isInputImage):
(WebCore::AccessibilityNodeObject::isMultiSelectable):
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::valueForRange):
(WebCore::AccessibilityNodeObject::maxValueForRange):
(WebCore::AccessibilityNodeObject::minValueForRange):
(WebCore::isNodeActionElement):
(WebCore::AccessibilityNodeObject::alternativeText):
(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::title):
(WebCore::AccessibilityNodeObject::text):
(WebCore::AccessibilityNodeObject::stringValue):
(WebCore::AccessibilityNodeObject::colorValue):
(WebCore::accessibleNameForNode):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::isFileUploadButton):
(WebCore::AccessibilityRenderObject::stringValue):
(WebCore::AccessibilityRenderObject::labelElementContainer):
(WebCore::AccessibilityRenderObject::internalLinkElement):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::url):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::getDocumentLinks):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):
(WebCore::AccessibilityRenderObject::stringValueForMSAA):
(WebCore::AccessibilityRenderObject::isLinked):

  • accessibility/AccessibilitySlider.cpp:

(WebCore::AccessibilitySlider::inputElement):
(WebCore::AccessibilitySliderThumb::elementRect):

  • accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::tableElement):
(WebCore::AccessibilityTable::title):

  • accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::notifyChildrenSelectionChange):

  • accessibility/atk/WebKitAccessibleInterfaceSelection.cpp:

(optionFromSelection):
(webkitAccessibleSelectionGetSelectionCount):

  • accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(webkitAccessibleTableGetCaption):

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetDescription):

  • accessibility/ios/AccessibilityObjectIOS.mm:

(WebCore::AccessibilityObject::accessibilityPasswordFieldLength):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::namedItemGetter):
(WebCore::JSDOMWindow::getOwnPropertySlot):
(WebCore::JSDOMWindow::getOwnPropertySlotByIndex):

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::nameGetter):

  • bindings/js/JSHTMLFrameSetElementCustom.cpp:

(WebCore::JSHTMLFrameSetElement::nameGetter):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::isReachableFromDOM):

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/SelectorCheckerTestFunctions.h:

(WebCore::isChecked):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::adjustRenderStyle):

  • css/StyleSheetList.cpp:

(WebCore::StyleSheetList::getNamedItem):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::makeContextStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::makeElementStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::isPlaceholderShown):

  • dom/CurrentScriptIncrementer.h:

(WebCore::CurrentScriptIncrementer::CurrentScriptIncrementer):

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::setDragImage):

  • dom/Document.cpp:

(WebCore::Document::setTitle):
(WebCore::Document::processHttpEquiv):
(WebCore::Document::iconURLs):

  • dom/DocumentOrderedMap.cpp:

(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):
(WebCore::keyMatchesLowercasedUsemap):
(WebCore::DocumentOrderedMap::getElementByMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedMapName):
(WebCore::DocumentOrderedMap::getElementByLowercasedUsemap):
(WebCore::DocumentOrderedMap::getElementByLabelForAttribute):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):

  • dom/Element.cpp:

(WebCore::Element::insertedInto):
(WebCore::Element::removedFrom):
(WebCore::Element::updateName):
(WebCore::Element::updateId):
(WebCore::Element::updateLabel):
(WebCore::Element::ensureCachedHTMLCollection):

  • dom/EventDispatcher.cpp:

(WebCore::EventDispatcher::dispatchEvent):

  • dom/ScriptElement.cpp:

(WebCore::toScriptElementIfPossible):

  • dom/VisitedLinkState.cpp:

(WebCore::linkHashForElement):
(WebCore::VisitedLinkState::determineLinkStateSlowCase):

  • dom/make_names.pl:

(printTypeHelpers):

  • editing/Editor.cpp:

(WebCore::Editor::selectionForCommand):
(WebCore::imageElementFromImageDocument):
(WebCore::findFirstMarkable):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::selectAll):
(WebCore::scanForForm):

  • editing/MarkupAccumulator.cpp:

(WebCore::MarkupAccumulator::serializeNodesWithNamespaces):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace):

  • editing/VisibleSelection.cpp:

(WebCore::VisibleSelection::nonBoundaryShadowTreeRootNode):
(WebCore::VisibleSelection::isInPasswordField):

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverter::_processElement):

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):

  • editing/markup.cpp:

(WebCore::isPlainTextMarkup):

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::suggestions):

  • html/FTPDirectoryDocument.cpp:

(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
(WebCore::FTPDirectoryDocumentParser::createBasicDocument):

  • html/FormAssociatedElement.cpp:

(WebCore::FormAssociatedElement::findAssociatedForm):

  • html/HTMLAnchorElement.cpp:

(WebCore::appendServerMapMousePosition):

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::imageElement):

  • html/HTMLCollection.cpp:

(WebCore::isMatchingElement):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::matchesReadWritePseudoClass):
(WebCore::HTMLElement::setInnerHTML):
(WebCore::HTMLElement::directionality):

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::rendererIsNeeded):

  • html/HTMLFieldSetElement.cpp:

(WebCore::HTMLFieldSetElement::refreshElementsIfNeeded):

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::computeIsDisabledByFieldsetAncestor):
(WebCore::shouldAutofocus):

  • html/HTMLFormControlsCollection.cpp:

(WebCore::HTMLFormControlsCollection::formControlElements):
(WebCore::HTMLFormControlsCollection::formImageElements):

  • html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::getTextFieldValues):
(WebCore::HTMLFormElement::assertItemCanBeInPastNamesMap):

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

  • html/HTMLImageLoader.cpp:

(WebCore::HTMLImageLoader::notifyFinished):

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::dataList):
(WebCore::HTMLInputElement::setupDateTimeChooserParameters):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::shadowSelect):

  • html/HTMLLegendElement.cpp:

(WebCore::HTMLLegendElement::virtualForm):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::parseAttribute):

  • html/HTMLNameCollection.cpp:

(WebCore::DocumentNameCollection::elementMatchesIfIdAttributeMatch):
(WebCore::DocumentNameCollection::elementMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::elementMatches):

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::updateDocNamedItem):
(WebCore::HTMLObjectElement::containsJavaApplet):

  • html/HTMLOptGroupElement.cpp:

(WebCore::HTMLOptGroupElement::recalcSelectOptions):
(WebCore::HTMLOptGroupElement::ownerSelectElement):

  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::ownerDataListElement):
(WebCore::HTMLOptionElement::ownerSelectElement):

  • html/HTMLOptionsCollection.cpp:

(WebCore::HTMLOptionsCollection::add):

  • html/HTMLOptionsCollection.h:
  • html/HTMLPlugInImageElement.cpp:

(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin):

  • html/HTMLSelectElement.cpp:

(WebCore::HTMLSelectElement::hasPlaceholderLabelOption):
(WebCore::HTMLSelectElement::value):
(WebCore::HTMLSelectElement::setValue):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::selectOption):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState):
(WebCore::HTMLSelectElement::searchOptionsForValue):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::lastSelectedListIndex):
(WebCore::HTMLSelectElement::optionAtIndex):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):

  • html/HTMLSummaryElement.cpp:

(WebCore::HTMLSummaryElement::detailsElement):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::caption):

  • html/HTMLTablePartElement.cpp:

(WebCore::HTMLTablePartElement::findParentTable):

  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::rowIndex):

  • html/HTMLTableRowsCollection.cpp:

(WebCore::HTMLTableRowsCollection::rowAfter):
(WebCore::HTMLTableRowsCollection::lastRow):
(WebCore::HTMLTableRowsCollection::customElementAfter):

  • html/HTMLTableRowsCollection.h:
  • html/HTMLTemplateElement.cpp:

(WebCore::HTMLTemplateElement::cloneNode):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::enclosingTextFormControl):

  • html/ImageDocument.cpp:

(WebCore::ImageDocument::createDocumentStructure):

  • html/LabelsNodeList.cpp:

(WebCore::LabelsNodeList::elementMatches):

  • html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):
(WebCore::descendentVideoElement):
(WebCore::ancestorVideoElement):
(WebCore::MediaDocument::replaceMediaElementTimerFired):

  • html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

  • html/RadioInputType.cpp:

(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::isKeyboardFocusable):

  • html/RadioNodeList.cpp:

(WebCore::RadioNodeList::checkElementMatchesRadioNodeListFilter):

  • html/RangeInputType.cpp:

(WebCore::RangeInputType::updateTickMarkValues):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::insert):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::ownerDocumentForCurrentNode):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):

  • html/shadow/DetailsMarkerControl.cpp:

(WebCore::DetailsMarkerControl::rendererIsNeeded):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::updateDisplay):

  • html/shadow/MeterShadowElement.cpp:

(WebCore::MeterShadowElement::meterElement):

  • html/shadow/ProgressShadowElement.cpp:

(WebCore::ProgressShadowElement::progressElement):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::SearchFieldResultsButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForNode):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::handleFallbackContent):

  • loader/ImageLoader.cpp:

(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):

  • loader/SubframeLoader.cpp:

(WebCore::SubframeLoader::requestObject):

  • page/Chrome.cpp:

(WebCore::Chrome::setToolTip):

  • page/DragController.cpp:

(WebCore::DragController::draggableElement):

  • page/EventHandler.cpp:

(WebCore::isSubmitImage):

  • page/FocusController.cpp:

(WebCore::FocusController::advanceFocusDirectionally):

  • page/FrameView.cpp:

(WebCore::FrameView::addEmbeddedObjectToUpdate):
(WebCore::FrameView::updateEmbeddedObject):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeFrame):

  • page/SpatialNavigation.cpp:

(WebCore::FocusCandidate::FocusCandidate):

  • page/ios/FrameIOS.mm:

(WebCore::ancestorRespondingToClickEvents):

  • rendering/HitTestResult.cpp:

(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absolutePDFURL):
(WebCore::HitTestResult::enterFullscreenForVideo):
(WebCore::HitTestResult::mediaControlsEnabled):
(WebCore::HitTestResult::isLiveLink):
(WebCore::HitTestResult::isContentEditable):

  • rendering/RenderButton.cpp:

(WebCore::RenderButton::updateFromElement):

  • rendering/RenderCounter.cpp:

(WebCore::planCounter):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintContents):
(WebCore::RenderEmbeddedObject::layout):

  • rendering/RenderFieldset.h:
  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::inputElement):
(WebCore::RenderFileUploadControl::uploadButton):

  • rendering/RenderFrame.cpp:

(WebCore::RenderFrame::frameElement):

  • rendering/RenderFrameSet.cpp:

(WebCore::RenderFrameSet::frameSetElement):

  • rendering/RenderHTMLCanvas.cpp:

(WebCore::RenderHTMLCanvas::canvasElement):

  • rendering/RenderIFrame.cpp:

(WebCore::RenderIFrame::iframeElement):

  • rendering/RenderImage.cpp:

(WebCore::RenderImage::RenderImage):
(WebCore::RenderImage::paintAreaElementFocusRing):
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::imageMap):
(WebCore::RenderImage::updateAltText):

  • rendering/RenderLayerBacking.cpp:

(WebCore::canvasCompositingStrategy):
(WebCore::RenderLayerBacking::createPrimaryGraphicsLayer):
(WebCore::RenderLayerBacking::updateConfiguration):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForCanvas):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::selectElement):
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::calcValue):
(WebCore::RenderListItem::updateListMarkerNumbers):

  • rendering/RenderMarquee.cpp:

(WebCore::RenderMarquee::marqueeSpeed):

  • rendering/RenderMenuList.cpp:

(WebCore::selectedOptionCount):
(RenderMenuList::selectElement):
(RenderMenuList::updateOptionsWidth):
(RenderMenuList::setTextFromOption):
(RenderMenuList::itemText):
(RenderMenuList::itemIsSelected):

  • rendering/RenderMeter.cpp:

(WebCore::RenderMeter::meterElement):

  • rendering/RenderProgress.cpp:

(WebCore::RenderProgress::progressElement):

  • rendering/RenderSlider.cpp:

(WebCore::RenderSlider::element):

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::plugInImageElement):

  • rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::textFormControlElement):

  • rendering/RenderTextControlMultiLine.cpp:

(WebCore::RenderTextControlMultiLine::textAreaElement):

  • rendering/RenderTextControlSingleLine.cpp:

(WebCore::RenderTextControlSingleLine::inputElement):

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::paintSliderTicks):

  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::paintMenuListButtonDecorations):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):

  • rendering/RenderVideo.cpp:

(WebCore::RenderVideo::videoElement):

  • svg/graphics/SVGImageCache.cpp:

(WebCore::SVGImageCache::imageForRenderer):

  • svg/svgtags.in:

Generate helpers to SVGAElement so that isSVGAElement() can be used
instead of hasTagName(SVGNames::aTag). I did such update in this
patch.

  • testing/Internals.cpp:

(WebCore::Internals::visiblePlaceholder):
(WebCore::Internals::wasLastChangeUserEdit):
(WebCore::Internals::updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks):
(WebCore::Internals::isSelectPopupVisible):

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):

Source/WebKit/ios:

Use downcast<HTML*Element>() instead of toHTML*Element().

  • WebCoreSupport/WebChromeClientIOS.mm:

(WebChromeClientIOS::focusedElementChanged):

Source/WebKit/mac:

Use downcast<HTML*Element>() instead of toHTML*Element().

  • DOM/WebDOMOperations.mm:

(-[DOMHTMLInputElement _setAutofilled:]):

  • WebCoreSupport/WebChromeClient.mm:

(WebChromeClient::focusedElementChanged):

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::textFieldDidBeginEditing):
(WebEditorClient::textFieldDidEndEditing):
(WebEditorClient::textDidChangeInTextField):
(WebEditorClient::doTextFieldCommandFromEvent):
(WebEditorClient::textWillBeDeletedInTextField):
(WebEditorClient::textDidChangeInTextArea):

  • WebView/WebHTMLRepresentation.mm:

(inputElementFromDOMElement):

Source/WebKit/win:

Use downcast<HTML*Element>() instead of toHTML*Element().

  • DOMHTMLClasses.cpp:

(DOMHTMLDocument::URL):
(DOMHTMLDocument::body):
(DOMHTMLDocument::forms):
(DOMHTMLFormElement::action):
(DOMHTMLFormElement::method):
(DOMHTMLSelectElement::options):
(DOMHTMLSelectElement::activateItemAtIndex):
(DOMHTMLOptionElement::text):
(DOMHTMLOptionElement::label):
(DOMHTMLInputElement::form):
(DOMHTMLInputElement::disabled):
(DOMHTMLInputElement::readOnly):
(DOMHTMLInputElement::setType):
(DOMHTMLInputElement::value):
(DOMHTMLInputElement::setValue):
(DOMHTMLInputElement::setValueForUser):
(DOMHTMLInputElement::select):
(DOMHTMLInputElement::setSelectionStart):
(DOMHTMLInputElement::selectionStart):
(DOMHTMLInputElement::setSelectionEnd):
(DOMHTMLInputElement::selectionEnd):
(DOMHTMLInputElement::isTextField):
(DOMHTMLInputElement::replaceCharactersInRange):
(DOMHTMLInputElement::selectedRange):
(DOMHTMLInputElement::setAutofilled):
(DOMHTMLInputElement::isAutofilled):
(DOMHTMLInputElement::isUserEdited):
(DOMHTMLTextAreaElement::form):
(DOMHTMLTextAreaElement::value):
(DOMHTMLTextAreaElement::setValue):
(DOMHTMLTextAreaElement::select):
(DOMHTMLTextAreaElement::isUserEdited):
(DOMHTMLIFrameElement::contentFrame):

  • WebFrame.cpp:

(formElementFromDOMElement):
(inputElementFromDOMElement):

Source/WebKit2:

Use downcast<HTML*Element>() instead of toHTML*Element().

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::setHTMLInputElementValueForUser):
(WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::htmlInputElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::isTextField):
(WebKit::InjectedBundleNodeHandle::htmlTableCellElementCellAbove):
(WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame):

  • WebProcess/Plugins/PDF/PDFPluginChoiceAnnotation.mm:

(WebKit::PDFPluginChoiceAnnotation::commit):

  • WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:

(WebKit::PDFPluginTextAnnotation::createAnnotationElement):
(WebKit::PDFPluginTextAnnotation::value):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::initializePlugin):
(WebKit::PluginView::pluginSnapshotTimerFired):
(WebKit::PluginView::pluginDidReceiveUserInteraction):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::focusedElementChanged):

  • WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::textFieldDidBeginEditing):
(WebKit::WebEditorClient::textFieldDidEndEditing):
(WebKit::WebEditorClient::textDidChangeInTextField):
(WebKit::WebEditorClient::textDidChangeInTextArea):
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
(WebKit::WebEditorClient::textWillBeDeletedInTextField):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createPlugin):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::setAssistedNodeValue):
(WebKit::WebPage::setAssistedNodeValueAsNumber):
(WebKit::WebPage::setAssistedNodeSelectedIndex):
(WebKit::isAssistableNode): Deleted.
(WebKit::WebPage::getAssistedNodeInformation): Deleted.

2:24 PM Changeset in webkit [173892] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Renamed DebuggerCallFrameScope to DebuggerPausedScope.
<​https://webkit.org/b/137042>

Reviewed by Michael Saboff.

DebuggerPausedScope is a better name for this data structure because it
is meant for tracking the period within which the debugger is paused,
and doing clean ups after the pause ends.

  • debugger/Debugger.cpp:

(JSC::DebuggerPausedScope::DebuggerPausedScope):
(JSC::DebuggerPausedScope::~DebuggerPausedScope):
(JSC::Debugger::pauseIfNeeded):
(JSC::DebuggerCallFrameScope::DebuggerCallFrameScope): Deleted.
(JSC::DebuggerCallFrameScope::~DebuggerCallFrameScope): Deleted.

  • debugger/Debugger.h:
  • debugger/DebuggerCallFrame.h:
2:21 PM Changeset in webkit [173891] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Have DataTransfer::files() return a reference
​https://bugs.webkit.org/show_bug.cgi?id=137039

Reviewed by Ryosuke Niwa.

Have DataTransfer::files() return a reference instead of a pointer as
it can never return null.

No new tests, no behavior change.

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::files):

  • dom/DataTransfer.h:
2:17 PM Changeset in webkit [173890] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Have NamedNodeMap::element() and DOMStringMap::element() return a reference
​https://bugs.webkit.org/show_bug.cgi?id=137040

Reviewed by Ryosuke Niwa.

Have NamedNodeMap::element() and DOMStringMap::element() return a
reference instead of a pointer as they can never return null.

No new tests, no behavior change.

  • dom/DatasetDOMStringMap.h:
  • dom/NamedNodeMap.h:

(WebCore::NamedNodeMap::element):

2:08 PM Changeset in webkit [173889] by timothy@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove UserInterface/Images/gtk from Apple builds
​https://bugs.webkit.org/show_bug.cgi?id=136955

Reviewed by Joseph Pecoraro.

  • Scripts/copy-user-interface-resources.pl:

Remove Images/Legacy and Images/gtk on Mac and Windows builds by looking
at the MAC_OS_X_VERSION_MAJOR and OFFICIAL_BUILD environment vars.

2:04 PM Changeset in webkit [173888] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r171197): Clip's content is drawn behind Safari window when entering Full Screen youtube html5 first time
​https://bugs.webkit.org/show_bug.cgi?id=137029

Reviewed by Brent Fulgham.

In r171197, we ordered the full screen window on- and off-screen so that the fullscreen animation went to the
correct screen, which introduced a subtle glitch at the beginning and end of an animation. For entering, ensure
that the window is scaled to its starting size before ordering on-screen. For exiting, order the window off-
screen before resetting its clipping rect.

  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):

1:54 PM Changeset in webkit [173887] by jer.noble@apple.com
  • 2 edits in trunk/Tools

[Tools] git-commit uses wrong ChangeLog when run from a subdirectory
​https://bugs.webkit.org/show_bug.cgi?id=137031

Reviewed by Joseph Pecoraro.

commit-log-editor is run from the top of the Git checkout, even when git-commit is invoked
from a subdirectory, making the parsed locations of ChangeLog files incorrect. Git provides
a mapping prefix in the GIT_PREFIX environment variable, so apply this prefix to the parsed
ChangeLog locations before passing them to createCommitMessage().

  • Scripts/commit-log-editor:
1:21 PM Changeset in webkit [173886] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[CLoop] - Fix CLoop on the 32-bit Big-Endians
​https://bugs.webkit.org/show_bug.cgi?id=137020

Patch by Tomas Popela <​tpopela@redhat.com> on 2014-09-23
Reviewed by Mark Lam.

  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter32_64.asm:
12:53 PM Changeset in webkit [173885] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Have DOMImplementation::document() and Element::attributes() return references
​https://bugs.webkit.org/show_bug.cgi?id=137035

Reviewed by Andreas Kling.

Have DOMImplementation::document() and Element::attributes() return
references instead of pointers as they can never return null.

No new tests, no behavior change.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):
Update the JS Bindings code generator to use WTF::getPtr() in a couple
more places so that the implementation can return references instead
of pointers even when [GenerateIsReachable=xxx] IDL extended attribute
is used.

  • dom/DOMImplementation.h:

(WebCore::DOMImplementation::document):

  • dom/Element.cpp:

(WebCore::Element::attributes):

  • dom/Element.h:

(WebCore::Node::attributes):

12:30 PM Changeset in webkit [173884] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

Have Document::ensureTemplateDocument() return a reference
​https://bugs.webkit.org/show_bug.cgi?id=137033

Reviewed by Ryosuke Niwa.

Have Document::ensureTemplateDocument() return a reference instead of
a pointer as it can never return null.

No new tests, no behavior change.

  • dom/Document.cpp:

(WebCore::Document::ensureTemplateDocument):

  • dom/Document.h:
  • editing/markup.cpp:

(WebCore::createFragmentForInnerOuterHTML):

  • html/HTMLTemplateElement.cpp:

(WebCore::HTMLTemplateElement::content):
(WebCore::HTMLTemplateElement::didMoveToNewDocument):

11:44 AM Changeset in webkit [173883] by Chris Dumez
  • 28 edits in trunk/Source/WebCore

Have Document::accessSVGExtensions() return a reference
​https://bugs.webkit.org/show_bug.cgi?id=137030

Reviewed by Ryosuke Niwa.

Have Document::accessSVGExtensions() return a reference instead of a
pointer as it can never return null.

No new tests, no behavior change.

  • dom/ContainerNode.cpp:

(WebCore::ContainerNode::removeChild):
(WebCore::ContainerNode::removeChildren):

  • dom/Document.cpp:

(WebCore::Document::commonTeardown):
(WebCore::Document::implicitClose):
(WebCore::Document::accessSVGExtensions):

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::Element::~Element):
(WebCore::Element::removedFrom):

  • editing/markup.cpp:

(WebCore::isPlainTextMarkup):

  • history/CachedFrame.cpp:

(WebCore::CachedFrameBase::restore):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::buildReferenceFilter):

  • rendering/svg/RenderSVGResource.cpp:

(WebCore::removeFromCacheAndInvalidateDependencies):

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::svgExtensionsFromElement):

  • rendering/svg/RenderSVGResourceContainer.h:

(WebCore::getRenderSVGResourceContainerById):
(WebCore::getRenderSVGResourceById):

  • rendering/svg/SVGResources.cpp:

(WebCore::registerPendingResource):
(WebCore::SVGResources::buildCachedResources):

  • rendering/svg/SVGResourcesCache.cpp:

(WebCore::resourcesCacheFromRenderer):
(WebCore::SVGResourcesCache::resourceDestroyed):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::~SVGElement):
(WebCore::SVGElement::reportAttributeParsingError):
(WebCore::SVGElement::removedFrom):
(WebCore::SVGElement::viewportElement):
(WebCore::SVGElement::attributeChanged):
(WebCore::SVGElement::buildPendingResourcesIfNeeded):
(WebCore::SVGElement::accessDocumentSVGExtensions): Deleted.

  • svg/SVGElement.h:
  • svg/SVGFEConvolveMatrixElement.cpp:

(WebCore::SVGFEConvolveMatrixElement::parseAttribute):

  • svg/SVGFEGaussianBlurElement.cpp:

(WebCore::SVGFEGaussianBlurElement::parseAttribute):

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::clearResourceReferences):
(WebCore::SVGFEImageElement::buildPendingResource):

  • svg/SVGFitToViewBox.cpp:

(WebCore::SVGFitToViewBox::parseViewBox):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::insertedInto):
(WebCore::SVGFontFaceElement::removedFrom):

  • svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::buildPendingResource):
(WebCore::SVGMPathElement::clearResourceReferences):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::parseAttribute):
(WebCore::SVGPathElement::invalidateMPathDependencies):

  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::parseAttribute):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::~SVGSVGElement):
(WebCore::SVGSVGElement::insertedInto):
(WebCore::SVGSVGElement::removedFrom):

  • svg/SVGTRefElement.cpp:

(WebCore::SVGTRefElement::detachTarget):
(WebCore::SVGTRefElement::buildPendingResource):

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::clearResourceReferences):
(WebCore::SVGTextPathElement::buildPendingResource):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::clearResourceReferences):
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::toClipPath):
(WebCore::SVGUseElement::buildInstanceTree):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::clearResourceReferences):
(WebCore::SVGSMILElement::buildPendingResource):

11:38 AM Changeset in webkit [173882] by commit-queue@webkit.org
  • 26 edits in trunk/Source

Web Inspector: Should be able to attach a debugger to a JSContext before anything is executed
​https://bugs.webkit.org/show_bug.cgi?id=136893

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-23
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

Adds new remote inspector protocol handling for automatic inspection.
Debuggers can signal they have enabled automatic inspection, and
when debuggables are created the current application will pause to
see if the debugger will inspect or decline to inspect the debuggable.

  • inspector/remote/RemoteInspectorConstants.h:
  • inspector/remote/RemoteInspector.h:
  • inspector/remote/RemoteInspector.mm:

(Inspector::globalAutomaticInspectionState):
(Inspector::RemoteInspector::RemoteInspector):
(Inspector::RemoteInspector::start):
When first starting, check the global "is there an auto-inspect" debugger state.
This is necessary so that the current application knows if it should pause or
not when a debuggable is created, even without having connected to webinspectord yet.

(Inspector::RemoteInspector::updateDebuggableAutomaticInspectCandidate):
When a debuggable has enabled remote inspection, take this path to propose
it as an automatic inspection candidate if there is an auto-inspect debugger.

(Inspector::RemoteInspector::sendAutomaticInspectionCandidateMessage):
Send the automatic inspection candidate message.

(Inspector::RemoteInspector::receivedSetupMessage):
(Inspector::RemoteInspector::setupFailed):
(Inspector::RemoteInspector::setupSucceeded):
After attempting to open an inspector, unpause if it was for the
automatic inspection candidate.

(Inspector::RemoteInspector::waitingForAutomaticInspection):
When running a nested runloop, check if we should remain paused.

(Inspector::RemoteInspector::setupXPCConnectionIfNeeded):
If by the time we connect to webinspectord we have a candidate, then
immediately send the candidate message.

(Inspector::RemoteInspector::stopInternal):
(Inspector::RemoteInspector::xpcConnectionFailed):
In error cases, clear our state.

(Inspector::RemoteInspector::xpcConnectionReceivedMessage):
(Inspector::RemoteInspector::receivedAutomaticInspectionConfigurationMessage):
(Inspector::RemoteInspector::receivedAutomaticInspectionRejectMessage):
Update state when receiving new messages.

  • inspector/remote/RemoteInspectorDebuggable.h:
  • inspector/remote/RemoteInspectorDebuggable.cpp:

(Inspector::RemoteInspectorDebuggable::setRemoteDebuggingAllowed):
Special case when a debuggable is newly allowed to be debuggable.

(Inspector::RemoteInspectorDebuggable::pauseWaitingForAutomaticInspection):
Run a nested run loop while this is an automatic inspection candidate.

  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::connectFrontend):
When the inspector starts via automatic inspection automatically pause.
We plan on removing this condition by having the frontend signal to the
backend when it is completely initialized.

  • inspector/remote/RemoteInspectorDebuggableConnection.h:
  • inspector/remote/RemoteInspectorDebuggableConnection.mm:

(Inspector::RemoteInspectorDebuggableConnection::setup):
Pass on the flag of whether or not this was automatic inspection.

  • runtime/JSGlobalObjectDebuggable.h:
  • runtime/JSGlobalObjectDebuggable.cpp:

(JSC::JSGlobalObjectDebuggable::connect):
(JSC::JSGlobalObjectDebuggable::pauseWaitingForAutomaticInspection):
When pausing in a JSGlobalObject we need to release the API lock.

Source/WebCore:

Automatic inspection is currently disabled for web pages.
This just updates the interfaces that changed.

  • WebCore.exp.in:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::show):

  • inspector/InspectorController.h:
  • page/PageDebuggable.cpp:

(WebCore::PageDebuggable::connect):

  • page/PageDebuggable.h:
  • testing/Internals.cpp:

(WebCore::Internals::openDummyInspectorFrontend):

Source/WebKit:

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit2:

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::remoteFrontendConnected):

Source/WTF:

Currently automatic inspection only happens in processes that have a
debugger attached. That condition may change in the future, but this
function can stand on its own in WTF. It may be useful in the future
to perhaps continue though ASSERTs if you have a debugger attached.

  • wtf/Assertions.cpp:
  • wtf/Assertions.h:
11:24 AM Changeset in webkit [173881] by ggaren@apple.com
  • 13 edits
    2 adds
    1 delete in trunk/Source/bmalloc

bmalloc: Allocation should be more precise
​https://bugs.webkit.org/show_bug.cgi?id=136993

Reviewed by Gavin Barraclough.

13% reduction in heap size on the MallocBench *_memory_warning benchmarks.

This patch teaches the allocator to merge adjacent free lines into a
single allocatable range. This allows us to shrink the size of an
individual line without increasing fragmentation or the rate of allocator
slow paths.

We'll only take more slow paths when available memory is sparse, which
is exactly when it's worth it. When available memory is dense, we'll
take fewer slow paths.

  • bmalloc.xcodeproj/project.pbxproj:
  • bmalloc/Algorithm.h:

(bmalloc::divideRoundingUp):

  • bmalloc/Allocator.cpp:

(bmalloc::Allocator::Allocator): Updated for interface changes.

(bmalloc::Allocator::scavenge): Scavenge by object instead of by line.
Now that we merge lines, it's not convenient to scavenge by line.

(bmalloc::Allocator::allocateSmallBumpRange):
(bmalloc::Allocator::allocateMediumBumpRange): Allocate whole ranges
instead of individual lines.

(bmalloc::Allocator::allocateSlowCase):
(bmalloc::Allocator::allocateSmallLine): Deleted.
(bmalloc::Allocator::allocateMediumLine): Deleted.
(bmalloc::Allocator::allocateMedium): Deleted.

  • bmalloc/Allocator.h:

(bmalloc::Allocator::allocateFastCase): Folded medium allocations
into the standard fast path with small allocations. Since a BumpAllocator
just allocates out of an arbitrary range, it doesn't need to distinguish
between small and medium lines.

  • bmalloc/BumpAllocator.h:

(bmalloc::BumpAllocator::size):
(bmalloc::BumpAllocator::BumpAllocator):
(bmalloc::BumpAllocator::init):
(bmalloc::BumpAllocator::refill):
(bmalloc::BumpAllocator::line): Deleted. No need to track line information
anymore: the heap just gives us a pointer and a pre-computed number of
objects, and we allocate them.

  • bmalloc/Deallocator.cpp:

(bmalloc::Deallocator::processObjectLog): Updated for interface changes.

  • bmalloc/Heap.cpp:

(bmalloc::Heap::Heap):
(bmalloc::Heap::initializeLineMetadata): Pre-compute precise metadata
detailing where all objects will lie in memory. After we merge two lines,
we might allocate an object that spans from one line to the next. This
metadata details which bits of memory overlap in that way, and how they
overlap.

(bmalloc::Heap::refillSmallBumpRangeCache):
(bmalloc::Heap::refillMediumBumpRangeCache): Scan a whole page at a time,
and merge adjacent free lines into BumpRanges.

(bmalloc::Heap::allocateSmallPage):
(bmalloc::Heap::allocateMediumPage):
(bmalloc::Heap::deallocateSmallLine):
(bmalloc::Heap::deallocateMediumLine): Track pages rather than lines,
since we scan for free memory a page at a time.

(bmalloc::Heap::allocateSmallLineSlowCase): Deleted.
(bmalloc::Heap::allocateMediumLineSlowCase): Deleted. Folded into the
fast path.

  • bmalloc/Heap.h:

(bmalloc::Heap::derefSmallLine):
(bmalloc::Heap::derefMediumLine):
(bmalloc::Heap::deallocateSmallLine): Deleted.
(bmalloc::Heap::allocateSmallLine): Deleted.
(bmalloc::Heap::deallocateMediumLine): Deleted.
(bmalloc::Heap::allocateMediumLine): Deleted. Updated for interface changes.

  • bmalloc/Line.h:

(bmalloc::Line<Traits>::ref):
(bmalloc::Line<Traits>::deref):
(bmalloc::Line<Traits>::concurrentRef): Deleted. We don't pass a derefCount
anymore, since we only ever deref by 1 now.

  • bmalloc/MediumAllocator.h:

(bmalloc::MediumAllocator::isNull): Deleted.
(bmalloc::MediumAllocator::MediumAllocator): Deleted.
(bmalloc::MediumAllocator::line): Deleted.
(bmalloc::MediumAllocator::allocate): Deleted.
(bmalloc::MediumAllocator::derefCount): Deleted.
(bmalloc::MediumAllocator::refill): Deleted.
(bmalloc::MediumAllocator::clear): Deleted. Deleted some code that's
been dead for a while, since it doesn't build anymore with this patch.

  • bmalloc/Page.h:

(bmalloc::Page::sizeClass):
(bmalloc::Page::setSizeClass):
(bmalloc::Page::smallSizeClass): Deleted.
(bmalloc::Page::setSmallSizeClass): Deleted. Renamed setSmallSizeClass
to sizeClass, since we use it for medium sizes too.

  • bmalloc/Sizes.h:

(bmalloc::Sizes::sizeClass):
(bmalloc::Sizes::objectSize): Shrank line sizes to save memory.

(bmalloc::Sizes::smallSizeClassFor): Deleted.
(bmalloc::Sizes::mediumSizeClassFor): Deleted.

  • bmalloc/bmalloc.h:

(bmalloc::api::realloc): Now that we have precise objects sizes, realloc
can be a bit more precise. It also has to be, since we can't guarantee
that an object ends at the end of a line anymore.

11:09 AM Changeset in webkit [173880] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

W3C test importer should detect manual and reference tests according their filenames
​https://bugs.webkit.org/show_bug.cgi?id=133852

Patch by Youenn Fablet <​youenn.fablet@crf.canon.fr> on 2014-09-23
Reviewed by Bem Jones-Bey.

  • Scripts/webkitpy/w3c/test_parser.py:

(TestParser.analyze_test): Adding checks based on WPT filename rules.
(TestParser.is_wpt_manualtest): Detecting whether the test is a manual test based on its filename.
(TestParser):
(TestParser.potential_ref_filename): Getting the potential reference filename of a test from its filename.
(TestParser.is_wpt_reftest): Detecting whether the test is a ref test based on its filename.

  • Scripts/webkitpy/w3c/test_parser_unittest.py:

(test_analyze_manual_wpt_test): Adding a test for a "-manual.html" file with testharness.js link in it.

10:32 AM Changeset in webkit [173879] by Bem Jones-Bey
  • 2 edits in trunk/Tools

Unreviewed, add Rebecca Hauck as a contributor.

  • Scripts/webkitpy/common/config/contributors.json:
10:11 AM Changeset in webkit [173878] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Win] Correct 64-bit Windows export definitions after r173804.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Provide proper

64-bit mangled symbol names.

10:11 AM Changeset in webkit [173877] by ddkilzer@apple.com
  • 18 edits in trunk/Tools

Switch build.webkit.org URLs to https

Reviewed by Lucas Forschler and Alexey Proskuryakov.

  • TestResultServer/app.yaml: Update version to this commit

revision.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:
  • BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/WebKitBuildbot.js:

(WebKitBuildbot):

  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:

(.):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
  • Scripts/webkitpy/common/config/urls.py:
  • Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:

(test_builder_with_name):

  • Scripts/webkitpy/tool/commands/queries.py:

(TreeStatus):

  • TestResultServer/generate_builders_json.py:

(main):

  • TestResultServer/generate_builders_json_unittest.py:

(GenerateBuildersJsonTest.test_generate_json_data.dummy_fetch_json):
(GenerateBuildersJsonTest):
(GenerateBuildersJsonTest.test_generate_json_data):

  • TestResultServer/static-dashboards/builders.jsonp:
  • TestResultServer/static-dashboards/flakiness_dashboard.js:

(loadExpectationsLayoutTests):

  • TestResultServer/static-dashboards/timeline_explorer.js:
10:10 AM Changeset in webkit [173876] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

W3C test importer should copy .htaccess files
​https://bugs.webkit.org/show_bug.cgi?id=136850

Patch by Youenn Fablet <​youenn.fablet@crf.canon.fr> on 2014-09-23
Reviewed by Bem Jones-Bey.

  • Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.should_skip_file): Helper function to check whether to skip file or not. Added ".htaccess" file specific check.
(TestImporter):
(TestImporter.find_importable_tests): Making use of new helper function.

9:56 AM Changeset in webkit [173875] by ap@apple.com
  • 2 edits in trunk/Tools

Trying to revive bot watcher's dashboard after HSTS.

Unreviewed.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot): It looks like XMLHttpRequest may not like HSTS redirects, let's try to avoid these.

9:41 AM Changeset in webkit [173874] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] Adds implementation of subtle crypto HMAC algorithm
​https://bugs.webkit.org/show_bug.cgi?id=133320

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2014-09-23
Reviewed by Philippe Normand.

Source/WebCore:

Tests are already in place under crypto/subtle/hmac-*.html

  • crypto/gtk/CryptoAlgorithmHMACGtk.cpp:

(WebCore::getGnutlsDigestAlgorithm):
(WebCore::calculateSignature):
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):

LayoutTests:

  • platform/gtk/TestExpectations: Whitelists HMAC related tests that are passing
9:14 AM Changeset in webkit [173873] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, rolling out r173864.

It still make tests failes on EFL bots

Reverted changeset:

"Unreviewed, EFL gardening. Unskip media test on EFL port.
Almost media tests"
​http://trac.webkit.org/changeset/173864

8:17 AM Changeset in webkit [173872] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK] Adds implementation of Subtle Crypto digest algorithms
​https://bugs.webkit.org/show_bug.cgi?id=133319

Source/WebCore:

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2014-09-23
Reviewed by Philippe Normand.

Tests are already in place under crypto/subtle/sha-*.html

  • crypto/gtk/CryptoDigestGtk.cpp:

(WebCore::CryptoDigest::CryptoDigest):
(WebCore::CryptoDigest::~CryptoDigest):
(WebCore::CryptoDigest::create):
(WebCore::CryptoDigest::addBytes):
(WebCore::CryptoDigest::computeHash):

LayoutTests:

Leaves all crypto/subtle tests skipped and whitelist only those related to
digest algorithms (sha-*.html). When enough crypto algorithms are implemented,
we can invert the approach and blacklist only those tests whose algorithms are
not implemented.

Patch by Eduardo Lima Mitev <​elima@igalia.com> on 2014-09-23
Reviewed by Philippe Normand.

  • platform/gtk/TestExpectations: Unskip tests for Subtle-Crypto digest algorithms.
7:47 AM Changeset in webkit [173871] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Make Tools/BuildSlaveSupport/wait-for-SVN-server.py handle server donwtime
​https://bugs.webkit.org/show_bug.cgi?id=137026

Patch by Tibor Meszaros <​tmeszaros.u-szeged@partner.samsung.com> on 2014-09-23
Reviewed by Csaba Osztrogonác.

  • BuildSlaveSupport/wait-for-SVN-server.py:

(getLatestSVNRevision):
(waitForSVNRevision):

2:57 AM Changeset in webkit [173870] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove unlinkZeroFiles from build-webkit
​https://bugs.webkit.org/show_bug.cgi?id=137018

Patch by Tibor Meszaros <​tmeszaros.u-szeged@partner.samsung.com> on 2014-09-23
Reviewed by Csaba Osztrogonác.

  • Scripts/build-webkit:

(unlinkZeroFiles): Deleted.

2:26 AM Changeset in webkit [173869] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Minibrowser : Add keyboard support for stop page load
​https://bugs.webkit.org/show_bug.cgi?id=136857

Patch by Rohit Kumar <​kumar.rohit@samsung.com> on 2014-09-23
Reviewed by Philippe Normand.

Keyboard support to stop page load in GTK Minibrowser using F6 and Escape keys.

  • MiniBrowser/gtk/BrowserWindow.c:

(stopPageLoad): Callback to stop page load.
(browser_window_init):

1:37 AM Changeset in webkit [173868] by svillar@igalia.com
  • 2 edits in trunk/Source/WebCore

[CSS Grid Layout] Do not grow tracks when the growth factor is 0
​https://bugs.webkit.org/show_bug.cgi?id=136575

Reviewed by Darin Adler.

A couple of performance optimizations for the track sizing
algorithm. On the one hand we avoid the computation of the
available logical space share if the track has no growth potential
(the current breadth is the maximum breadth) and on the other
hand, we avoid calling RenderGrid::distributeSpaceToTracks() if
the available logical space is not greater than 0.

The combined effect of these two changes is an impressive +16%
improvement in auto-grid-lots-of-data.html performance test.

No new tests as there is no change in the functionality.

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctionsForItems):
(WebCore::RenderGrid::distributeSpaceToTracks):

12:47 AM Changeset in webkit [173867] by Ion Rosca
  • 6 edits
    4 adds in trunk

[CSS Blending] The composited layers isolated by the page group should blend with the default white background color.
​https://bugs.webkit.org/show_bug.cgi?id=136563

Reviewed by Simon Fraser.

Source/WebCore:

If a blending layer is not isolated, then it should blend with a white backdrop:
​http://dev.w3.org/fxtf/compositing-1/#pagebackdrop

Tests: css3/blending/blend-mode-body-composited-child-background-color.html

css3/blending/blend-mode-body-composited-child.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
If the isolating composited layer is the root renderer, then it should have a backing store
into which the initial white backdrop will be painted.

LayoutTests:

  • css3/blending/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer-expected.txt:
  • css3/blending/blend-mode-body-composited-child-background-color-expected.html: Added.
  • css3/blending/blend-mode-body-composited-child-background-color.html: Added.
  • css3/blending/blend-mode-body-composited-child-expected.html: Added.
  • css3/blending/blend-mode-body-composited-child.html: Added.
  • css3/blending/blend-mode-parent-of-composited-blended-has-layer-expected.txt:
  • css3/blending/blend-mode-with-composited-descendant-should-have-layer-expected.txt:

Sep 22, 2014:

11:00 PM Changeset in webkit [173866] by Chris Dumez
  • 29 edits in trunk/Source/WebCore

Unreviewed build fix after r173859.

Partial revert to fix debug build after r173859.

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::remoteSVGRootElement):

  • html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::getSVGDocument):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):

  • page/Frame.cpp:

(WebCore::Frame::setPageAndTextZoomFactors):

  • page/FrameView.cpp:

(WebCore::FrameView::scrollToAnchor):

  • rendering/svg/RenderSVGBlock.h:

(WebCore::RenderSVGBlock::graphicsElement):

  • rendering/svg/RenderSVGGradientStop.cpp:

(WebCore::RenderSVGGradientStop::gradientElement):

  • rendering/svg/RenderSVGInline.h:

(WebCore::RenderSVGInline::graphicsElement):

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::pathOnlyClipping):

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):

  • rendering/svg/RenderSVGShape.h:

(WebCore::RenderSVGShape::graphicsElement):

  • rendering/svg/RenderSVGTransformableContainer.h:
  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::updateMaskedAncestorShouldIsolateBlending):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::operator<<):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

  • rendering/svg/SVGResources.cpp:

(WebCore::targetReferenceFromResource):

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::defaultEventHandler):

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::calculateAnimatedValue):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::getBoundingBox):

  • svg/SVGLinearGradientElement.cpp:

(WebCore::SVGLinearGradientElement::collectGradientAttributes):

  • svg/SVGLocatable.cpp:

(WebCore::SVGLocatable::getTransformToElement):

  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::synchronizePoints):
(WebCore::SVGPolyElement::lookupOrCreatePointsWrapper):

  • svg/SVGRadialGradientElement.cpp:

(WebCore::SVGRadialGradientElement::collectGradientAttributes):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::synchronizeTextLength):
(WebCore::SVGTextContentElement::lookupOrCreateTextLengthWrapper):
(WebCore::SVGTextContentElement::elementFromRenderer):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::toClipPath):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::hasSingleSecurityOrigin):
(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::containerSize):
(WebCore::SVGImage::embeddedContentBox):
(WebCore::SVGImage::hasRelativeWidth):
(WebCore::SVGImage::hasRelativeHeight):
(WebCore::SVGImage::computeIntrinsicDimensions):
(WebCore::SVGImage::startAnimation):
(WebCore::SVGImage::stopAnimation):

9:39 PM Changeset in webkit [173865] by Simon Fraser
  • 8 edits in trunk/Source/WebCore

Ensure that layout is up-to-date before hit-testing via RenderView
​https://bugs.webkit.org/show_bug.cgi?id=136651

Reviewed by David Hyatt.

Ensure that layout is up-to-date before we do hit-testing via the RenderView.
Previously, RenderLayer::hitTest() called updateLayout(), but it's better
to push that responsibility onto RenderView before entering the RenderLayer
tree.

Make callers a little more consistent in getting the RenderView via
Frame::contentRenderer(), though perhaps we should remove that and just
call Document::renderView() everywhere.

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::press): Hit test via the RenderView, rather
than doing so on the RenderView's layer, to ensure that we updateLayout().

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::accessibilityHitTest): This code calls
hitTest() on arbitrary layers, so needs to explicitly update layout.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::contains):

  • page/EventHandler.cpp:

(WebCore::EventHandler::eventMayStartDrag):
(WebCore::EventHandler::updateSelectionForMouseDrag):
(WebCore::EventHandler::hitTestResultAtPoint): The explicit updateLayout() is
no longer needed.
(WebCore::EventHandler::updateCursor):
(WebCore::EventHandler::handleWheelEvent):
(WebCore::EventHandler::hoverTimerFired):
(WebCore::hitTestResultInFrame):

  • page/Frame.cpp:

(WebCore::Frame::contentRenderer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::hitTest):

  • rendering/RenderView.cpp:

(WebCore::RenderView::hitTest): Here's where we ensure that layout is up-to-date.

9:31 PM Changeset in webkit [173864] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. Unskip media test on EFL port. Almost media tests
are passed except for some tests. Unfortunately what revision fixed this crash on media test.
To maintain media test on EFL port again, this commit unskips those tests.

  • platform/efl/TestExpectations:
9:13 PM Changeset in webkit [173863] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/LayoutTests

Unreviewed, EFL gardening. Unskip batterystatus, which doesn't come to crash anymore.

  • platform/efl/TestExpectations:
8:08 PM Changeset in webkit [173862] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[Windows] More test expectation gardening.

  • platform/win/TestExpectations: Skip some failing image only failures, unskip some tests reported as now passing.
7:25 PM Changeset in webkit [173861] by roger_fong@apple.com
  • 2 edits in trunk/LayoutTests

[Windows] More test expectation gardening.

  • platform/win/TestExpectations:
6:05 PM Changeset in webkit [173860] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL][WK2] Minibrowser : Add keyboard support for page reload while ignoring cache
​https://bugs.webkit.org/show_bug.cgi?id=136813

Patch by Rohit Kumar <​kumar.rohit@samsung.com> on 2014-09-22
Reviewed by Gyuyoung Kim.

Ctrl+r is used for page reload along with F5. Ctrl+Shift+r and Ctrl+F5 is used for page reload while ignoring cache.

  • MiniBrowser/efl/main.c:

(on_key_down):

5:55 PM Changeset in webkit [173859] by Chris Dumez
  • 102 edits in trunk/Source/WebCore

Use downcast<SVG*Element>() instead of toSVG*Element()
​https://bugs.webkit.org/show_bug.cgi?id=137004

Reviewed by Benjamin Poulain.

Use downcast<SVG*Element>() instead of toSVG*Element() for casting SVG
Elements and get rid of the transition toSVG*Element() macros.

Also use downcast<MathML*Element>() instead of toMathML*Element() for
casting MathML Elements.

The HTML Elements casting counterparts will be taken care of in a
separate patch.

No new tests, no behavior change.

  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::AccessibilityNodeObject::alternativeText):
(WebCore::AccessibilityNodeObject::accessibilityDescription):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::remoteSVGRootElement):

  • bindings/js/JSElementCustom.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::createWrapperInline):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSCursorImageValue.cpp:

(WebCore::resourceReferencedByCursorElement):
(WebCore::CSSCursorImageValue::updateIfSVGCursorIsUsed):

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::matchAllRules):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::locateCousinList):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):

  • dom/DocumentStyleSheetCollection.cpp:

(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):

  • dom/Element.cpp:

(WebCore::Element::synchronizeAllAttributes):
(WebCore::Element::synchronizeAttribute):
(WebCore::Element::boundsInRootViewSpace):
(WebCore::Element::getBoundingClientRect):
(WebCore::Element::childShouldCreateRenderer):
(WebCore::Element::fastAttributeLookupAllowed):

  • dom/EventDispatcher.cpp:

(WebCore::eventTargetRespectingTargetRules):

  • dom/ScriptElement.cpp:

(WebCore::toScriptElementIfPossible):

  • dom/make_names.pl:

(printTypeHelpers):

  • html/HTMLFrameOwnerElement.cpp:

(WebCore::HTMLFrameOwnerElement::getSVGDocument):

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

  • mathml/MathMLElement.cpp:

(WebCore::MathMLElement::isPhrasingContent):
(WebCore::MathMLElement::childShouldCreateRenderer):
(WebCore::MathMLElement::attributeChanged):

  • mathml/MathMLElement.h:

(WebCore::Node::hasTagName):

  • mathml/MathMLSelectElement.cpp:

(WebCore::MathMLSelectElement::getSelectedSemanticsChild):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
(WebCore::instanceAssociatedWithShadowTreeElement):

  • page/Frame.cpp:

(WebCore::Frame::setPageAndTextZoomFactors):

  • page/FrameView.cpp:

(WebCore::FrameView::scrollToAnchor):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::parseColSpanFromDOM):
(WebCore::RenderTableCell::parseRowSpanFromDOM):
(WebCore::RenderTableCell::computePreferredLogicalWidths):

  • rendering/mathml/RenderMathMLMenclose.cpp:

(WebCore::RenderMathMLMenclose::addChild):
(WebCore::RenderMathMLMenclose::computePreferredLogicalWidths):
(WebCore::RenderMathMLMenclose::updateLogicalHeight):
(WebCore::RenderMathMLMenclose::paint):

  • rendering/svg/RenderSVGBlock.h:

(WebCore::RenderSVGBlock::graphicsElement):

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::foreignObjectElement):

  • rendering/svg/RenderSVGGradientStop.cpp:

(WebCore::RenderSVGGradientStop::gradientElement):

  • rendering/svg/RenderSVGGradientStop.h:
  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::imageElement):

  • rendering/svg/RenderSVGInline.h:

(WebCore::RenderSVGInline::graphicsElement):

  • rendering/svg/RenderSVGModelObject.cpp:

(WebCore::getElementCTM):
(WebCore::RenderSVGModelObject::checkIntersection):
(WebCore::RenderSVGModelObject::checkEnclosure):

  • rendering/svg/RenderSVGModelObject.h:

(WebCore::RenderSVGModelObject::element):

  • rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::rectElement):

  • rendering/svg/RenderSVGResource.cpp:

(WebCore::removeFromCacheAndInvalidateDependencies):

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::pathOnlyClipping):
(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):

  • rendering/svg/RenderSVGResourceClipper.h:
  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):

  • rendering/svg/RenderSVGResourceFilter.h:
  • rendering/svg/RenderSVGResourceLinearGradient.h:
  • rendering/svg/RenderSVGResourceMarker.h:
  • rendering/svg/RenderSVGResourceMasker.h:
  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::patternElement):

  • rendering/svg/RenderSVGResourceRadialGradient.h:
  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::svgSVGElement):

  • rendering/svg/RenderSVGShape.h:

(WebCore::RenderSVGShape::graphicsElement):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::textElement):

  • rendering/svg/RenderSVGTextPath.cpp:

(WebCore::RenderSVGTextPath::textPathElement):
(WebCore::RenderSVGTextPath::layoutPath):

  • rendering/svg/RenderSVGTransformableContainer.cpp:

(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):

  • rendering/svg/RenderSVGTransformableContainer.h:
  • rendering/svg/RenderSVGViewportContainer.cpp:

(WebCore::RenderSVGViewportContainer::svgSVGElement):

  • rendering/svg/SVGPathData.cpp:

(WebCore::updatePathFromLineElement):
(WebCore::updatePathFromPathElement):
(WebCore::updatePathFromPolygonElement):
(WebCore::updatePathFromPolylineElement):

  • rendering/svg/SVGRenderSupport.cpp:

(WebCore::SVGRenderSupport::layoutChildren):
(WebCore::SVGRenderSupport::applyStrokeStyleToContext):
(WebCore::SVGRenderSupport::updateMaskedAncestorShouldIsolateBlending):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::operator<<):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

  • rendering/svg/SVGResources.cpp:

(WebCore::targetReferenceFromResource):
(WebCore::SVGResources::buildCachedResources):

  • rendering/svg/SVGTextLayoutEngine.cpp:

(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):

  • svg/SVGAElement.cpp:

(WebCore::SVGAElement::createElementRenderer):
(WebCore::SVGAElement::defaultEventHandler):

  • svg/SVGAltGlyphDefElement.cpp:

(WebCore::SVGAltGlyphDefElement::hasValidGlyphElements):

  • svg/SVGAltGlyphElement.cpp:

(WebCore::SVGAltGlyphElement::hasValidGlyphElements):

  • svg/SVGAnimateElement.cpp:

(WebCore::SVGAnimateElement::calculateAnimatedValue):

  • svg/SVGAnimatedTransformList.cpp:

(WebCore::SVGAnimatedTransformListAnimator::SVGAnimatedTransformListAnimator):

  • svg/SVGAnimationElement.cpp:

(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
(WebCore::SVGAnimationElement::adjustForInheritance):

  • svg/SVGDocument.cpp:

(WebCore::SVGDocument::rootElement):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::ownerSVGElement):
(WebCore::SVGElement::viewportElement):
(WebCore::SVGElement::getBoundingBox):
(WebCore::SVGElement::childShouldCreateRenderer):
(WebCore::SVGElement::title):
(WebCore::SVGElement::updateRelativeLengthsInformation):

  • svg/SVGElement.h:

(WebCore::Node::hasTagName):

  • svg/SVGFEComponentTransferElement.cpp:

(WebCore::SVGFEComponentTransferElement::build):

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::buildPendingResource):

  • svg/SVGFilterElement.cpp:

(WebCore::SVGFilterElement::childShouldCreateRenderer):

  • svg/SVGFilterPrimitiveStandardAttributes.h:

(WebCore::isSVGFilterPrimitiveStandardAttributes):

  • svg/SVGFontData.cpp:

(WebCore::SVGFontData::applySVGGlyphSelection):

  • svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::ensureGlyphCache):

  • svg/SVGFontFaceElement.cpp:

(WebCore::SVGFontFaceElement::rebuildFontFace):

  • svg/SVGFontFaceFormatElement.cpp:

(WebCore::SVGFontFaceFormatElement::childrenChanged):

  • svg/SVGFontFaceSrcElement.cpp:

(WebCore::SVGFontFaceSrcElement::srcValue):
(WebCore::SVGFontFaceSrcElement::childrenChanged):

  • svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::childrenChanged):

  • svg/SVGGlyphElement.cpp:

(WebCore::SVGGlyphElement::invalidateGlyphCache):

  • svg/SVGGraphicsElement.h:

(WebCore::isSVGGraphicsElement):

  • svg/SVGHKernElement.cpp:

(WebCore::SVGHKernElement::insertedInto):
(WebCore::SVGHKernElement::removedFrom):

  • svg/SVGImageLoader.cpp:

(WebCore::SVGImageLoader::dispatchLoadEvent):

  • svg/SVGLengthContext.cpp:

(WebCore::SVGLengthContext::determineViewport):

  • svg/SVGLinearGradientElement.cpp:

(WebCore::setGradientAttributes):
(WebCore::SVGLinearGradientElement::collectGradientAttributes):

  • svg/SVGLocatable.cpp:

(WebCore::SVGLocatable::nearestViewportElement):
(WebCore::SVGLocatable::farthestViewportElement):
(WebCore::SVGLocatable::computeCTM):
(WebCore::SVGLocatable::getTransformToElement):

  • svg/SVGMPathElement.cpp:

(WebCore::SVGMPathElement::buildPendingResource):
(WebCore::SVGMPathElement::pathElement):
(WebCore::SVGMPathElement::notifyParentOfPathChange):

  • svg/SVGMarkerElement.cpp:

(WebCore::SVGMarkerElement::synchronizeOrientType):
(WebCore::SVGMarkerElement::lookupOrCreateOrientTypeWrapper):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::invalidateMPathDependencies):
(WebCore::SVGPathElement::lookupOrCreateDWrapper):
(WebCore::SVGPathElement::synchronizeD):

  • svg/SVGPathSegList.cpp:

(WebCore::SVGPathSegList::commitChange):

  • svg/SVGPatternElement.cpp:

(WebCore::SVGPatternElement::collectPatternAttributes):

  • svg/SVGPolyElement.cpp:

(WebCore::SVGPolyElement::synchronizePoints):
(WebCore::SVGPolyElement::lookupOrCreatePointsWrapper):

  • svg/SVGRadialGradientElement.cpp:

(WebCore::setGradientAttributes):
(WebCore::SVGRadialGradientElement::collectGradientAttributes):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::setupInitialView):

  • svg/SVGTextContentElement.cpp:

(WebCore::SVGTextContentElement::synchronizeTextLength):
(WebCore::SVGTextContentElement::lookupOrCreateTextLengthWrapper):
(WebCore::SVGTextContentElement::elementFromRenderer):

  • svg/SVGTextContentElement.h:

(WebCore::isSVGTextContentElement):

  • svg/SVGTextPathElement.cpp:

(WebCore::SVGTextPathElement::buildPendingResource):

  • svg/SVGUseElement.cpp:

(WebCore::dumpInstanceTree):
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::toClipPath):
(WebCore::SVGUseElement::buildInstanceTree):
(WebCore::SVGUseElement::hasCycleUseReferencing):
(WebCore::SVGUseElement::expandUseElementsInShadowTree):
(WebCore::SVGUseElement::associateInstancesWithShadowTreeElements):

  • svg/SVGVKernElement.cpp:

(WebCore::SVGVKernElement::insertedInto):
(WebCore::SVGVKernElement::removedFrom):

  • svg/SVGViewSpec.cpp:

(WebCore::SVGViewSpec::viewTarget):

  • svg/animation/SVGSMILElement.cpp:

(WebCore::SVGSMILElement::buildPendingResource):
(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):

  • svg/animation/SVGSMILElement.h:

(WebCore::isSVGSMILElement):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::hasSingleSecurityOrigin):
(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::containerSize):
(WebCore::SVGImage::embeddedContentBox):
(WebCore::SVGImage::hasRelativeWidth):
(WebCore::SVGImage::hasRelativeHeight):
(WebCore::SVGImage::computeIntrinsicDimensions):
(WebCore::SVGImage::startAnimation):
(WebCore::SVGImage::stopAnimation):

  • svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::platformApplySoftware):

  • svg/properties/SVGAnimatedPathSegListPropertyTearOff.h:

(WebCore::SVGAnimatedPathSegListPropertyTearOff::animValDidChange):

  • svg/properties/SVGPathSegListPropertyTearOff.cpp:

(WebCore::SVGPathSegListPropertyTearOff::contextElement):

5:47 PM Changeset in webkit [173858] by psolanki@apple.com
  • 2 edits in trunk/Source/WebCore

Follow on fix for [iOS] ASSERTION FAILED: WTF::isMainThread() in WebCore::memoryCache() when using WebKit1
​https://bugs.webkit.org/show_bug.cgi?id=136962

Rubber-stamped by Simon Fraser.

Remove the const per review comment. It is not needed.

  • loader/cocoa/DiskCacheMonitorCocoa.mm:

(WebCore::DiskCacheMonitor::DiskCacheMonitor):

5:23 PM Changeset in webkit [173857] by Simon Fraser
  • 10 edits in trunk

Move nodeFromPoint() back to Document where it belongs
​https://bugs.webkit.org/show_bug.cgi?id=137012

Reviewed by Zalan Bujtas.
Source/WebCore:

nodeFromPoint() was moved into TreeScope for ShadowDOM work, but now we can move
it back to its logical place.

Make versions of elementFromPoint and caretRangeFromPoint that take LayoutPoints,
and change the current scale/offset code to be in layout units (which results
in a small behavior change).

elementFromPoint(int, int) and caretRangeFromPoint(int, int) are still required
for bindings code.

  • dom/Document.cpp:

(WebCore::Document::nodeFromPoint):
(WebCore::Document::elementFromPoint):
(WebCore::Document::caretRangeFromPoint):

  • dom/Document.h:

(WebCore::Document::elementFromPoint): Move logic from TreeScope::elementFromPoint()
here.

  • dom/TreeScope.cpp:

(WebCore::nodeFromPoint): Deleted.
(WebCore::TreeScope::elementFromPoint): Deleted.

  • dom/TreeScope.h:

LayoutTests:

All platforms use subpixel layout now, so remove the conditional behavior in this test.
Fix the test to account for scaling now being done in layout units.

  • fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
  • fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport.html:
  • platform/mac/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
4:10 PM Changeset in webkit [173856] by benjamin@webkit.org
  • 1 edit
    6 adds
    2 deletes in trunk/LayoutTests

Split the test parsing-css-nth-child-of.html in 3
​https://bugs.webkit.org/show_bug.cgi?id=137013

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-09-22
Rubber-stamped by Christophe Dumez.

parsing-css-nth-child-of.html tends to be too slow in debug, causing timeout from time to time.

The speed issues will be fixed once we JIT the selector. Since it will take a while before the JIT is ready,
this patch splits the test in three to avoid timeouts on the bots.

  • fast/css/parsing-css-nth-child-of-1-expected.txt: Renamed from LayoutTests/fast/css/parsing-css-nth-child-of-expected.txt.
  • fast/css/parsing-css-nth-child-of-1.html: Added.
  • fast/css/parsing-css-nth-child-of-2-expected.txt: Added.
  • fast/css/parsing-css-nth-child-of-2.html: Renamed from LayoutTests/fast/css/parsing-css-nth-child-of.html.
  • fast/css/parsing-css-nth-child-of-3-expected.txt: Added.
  • fast/css/parsing-css-nth-child-of-3.html: Added.
3:37 PM Changeset in webkit [173855] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.11-branch/Source

Versioning.

3:34 PM Changeset in webkit [173854] by bshafiei@apple.com
  • 1 copy in tags/Safari-600.1.4.11.10

New tag.

3:09 PM Changeset in webkit [173853] by benjamin@webkit.org
  • 4 edits
    16 adds in trunk

Add the baseline implementation of :nth-child(An+B of selector-list)
​https://bugs.webkit.org/show_bug.cgi?id=136975

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2014-09-22
Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/css/nth-child-of-classname.html

fast/css/nth-child-of-complex-selector.html
fast/css/nth-child-of-compound-selector.html
fast/css/nth-child-of-tagname.html
fast/selectors/nth-child-of-basics.html
fast/selectors/nth-child-of-class-style-update.html
fast/selectors/nth-child-of-complex-selectors.html
fast/selectors/nth-child-of-selector-list.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):
Pretty basic:
-Go over the previous siblings.
-For each sibling, test the selector list. If it matches, increase the count.

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):
Skip any case of the new selector. This will be implemented separately.

LayoutTests:

  • fast/css/nth-child-of-classname-expected.html: Added.
  • fast/css/nth-child-of-classname.html: Added.
  • fast/css/nth-child-of-complex-selector-expected.html: Added.
  • fast/css/nth-child-of-complex-selector.html: Added.
  • fast/css/nth-child-of-compound-selector-expected.html: Added.
  • fast/css/nth-child-of-compound-selector.html: Added.
  • fast/css/nth-child-of-tagname-expected.html: Added.
  • fast/css/nth-child-of-tagname.html: Added.

Cover basic styling and style sharing.

  • fast/selectors/nth-child-of-basics-expected.txt: Added.
  • fast/selectors/nth-child-of-basics.html: Added.
  • fast/selectors/nth-child-of-complex-selectors-expected.txt: Added.
  • fast/selectors/nth-child-of-complex-selectors.html: Added.
  • fast/selectors/nth-child-of-selector-list-expected.txt: Added.
  • fast/selectors/nth-child-of-selector-list.html: Added.

Cover querySelector and styling of various cases.

  • fast/selectors/nth-child-of-class-style-update-expected.txt: Added.
  • fast/selectors/nth-child-of-class-style-update.html: Added.

Basic case of style invalidation.

3:08 PM Changeset in webkit [173852] by mmaxfield@apple.com
  • 7 edits in trunk/Source/WebCore

Implement 'vhea', 'vmtx', and 'kern' tables in SVG -> OTF converter
​https://bugs.webkit.org/show_bug.cgi?id=136971

Reviewed by Darin Adler.

This patch fills in the tables related to vertical metrics and kerning. The vertical metrics tables are
fairly straightforward. On the other hand, the 'kern' table has subtables which can be in a variety
of formats; however, according to Microsoft, Windows only allows one particular format, which doesn't
allow for ranges of glyphs to be described and therefore might lead to a large 'kern' table size. In
the interest of platform agnosticism I have implemented this particular format, and have not actually
witnessed any extremely large 'kern' tables in any of the fonts that I have looked at.

I also added basic support for the horiz-origin-x and horiz-origin-y SVG properties, though support
might not be perfect based on my testing.

Regarding testing, after this patch, almost all of our SVG fonts tests pass (barring tiny rebaselining;
the platform font system calculates slightly different advances than we did. These differences are tiny
and expected from such a dramatic shift in text handling engines.) There are around two dozen failing
tests left that look like they are actually indiciative of code problems.

  • svg/SVGFontElement.cpp:

(WebCore::SVGFontElement::ensureGlyphCache): Refactor to accept new signature of
SVG*KernElement::build*KerningPair().

  • svg/SVGHKernElement.cpp:

(WebCore::SVGHKernElement::buildHorizontalKerningPair): Refactor to allow for intermediate data to be
returned, which the SVG -> OTF font converter can use.

  • svg/SVGHKernElement.h: New signature for buildHorizontalKerningPair().
  • svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::GlyphData::GlyphData): Save the glyph's vertical advance along with
the glyph's horizontal advance.
(WebCore::SVGToOTFFontConverter::KerningData::KerningData): This data represents a record in one of
the two 'kern' subtables, and as such needs to be sorted.
(WebCore::SVGToOTFFontConverter::KerningData::operator<): Sort comparator.
(WebCore::SVGToOTFFontConverter::appendHEADTable): Save the unitsPerEm locally to save a conditional.
(WebCore::SVGToOTFFontConverter::appendHHEATable): Ditto.
(WebCore::SVGToOTFFontConverter::appendHMTXTable): Ditto. Also use the horizontal advance as opposed to
the vertical advance.
(WebCore::SVGToOTFFontConverter::appendOS2Table): Save the unitsPerEm locally to save a conditional.
Also if the average advance isn't found in the font, use the missing glyph's advance. If there is no
missing glyph, bail and use the unitsPerEm.
(WebCore::SVGToOTFFontConverter::appendVORGTable): If the default vertical origin isn't found in the
font, use the missing glyphs's vertical origin. If there is no missing glyph, bail and use 0.
(WebCore::SVGToOTFFontConverter::appendVHEATable): Parallel of 'hhea' table, except for vertical info.
(WebCore::SVGToOTFFontConverter::appendVMTXTable): Parallel of 'hmtx' table, except for vertical info.
(WebCore::SVGToOTFFontConverter::appendKerningHelperFields): Computes and appends 4 fields that font
parsers need in order to do a binary search on the kern records.
(WebCore::SVGToOTFFontConverter::addCodepointRanges): For each codepoint in the ranges, look up its
representative glyph and append it to a set.
(WebCore::SVGToOTFFontConverter::addCodepoints): For each codepoint in the range, look up its
representative glyph and append it to a set.
(WebCore::SVGToOTFFontConverter::addGlyphNames): For each glyph name, look up its representative glyph
and append it to a set.
(WebCore::SVGToOTFFontConverter::computeKerningData): Call SVG*KernElement::build*KerningPair() and
iterate through all the data it returned, building up records into a Vector.
(WebCore::SVGToOTFFontConverter::appendKERNTable): Go through the vector that computeKerningData()
returned and actually write out the two subtables. One is for horizontal kerning and the other is for
vertical kerning.
(WebCore::CFFBuilder::CFFBuilder): Use the position of the glyph origin to perform the initial moveto
command.
(WebCore::transcodeGlyphPaths): Get the glyph's origin and pass it to the CFFBuilder.
(WebCore::SVGToOTFFontConverter::appendGlyphData): Templated overloading so that the missing glyph
gets a null SVGGlyphElement pointer but the rest of the glyphs get a non-null one.
(WebCore::SVGToOTFFontConverter::processGlyphElement): Called on both SVGGlyphElements and
SVGMissingGlyphElements, this pulls out information from the element and computs its path information.
(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter): Use the new templated version of
processGlyphElement so we can get the same glyph parsing behavior on SVGMissingGlyphElements. In
addition, populate two maps for the kerning table creation function to use.
(WebCore::SVGToOTFFontConverter::convertSVGToOTFFont): Append new tables.

  • svg/SVGVKernElement.cpp:

(WebCore::SVGVKernElement::buildVerticalKerningPair): Refactor to allow for intermediate data to be
returned, which the SVG -> OTF font converter can use.

  • svg/SVGVKernElement.h: New signature for buildVerticalKerningPair().
3:00 PM Changeset in webkit [173851] by dbates@webkit.org
  • 6 edits
    2 adds in trunk

[Cocoa] Add UI delegate callback when window.close() is called
​https://bugs.webkit.org/show_bug.cgi?id=137008
<rdar://problem/17801001>

Reviewed by Anders Carlsson.

Source/WebKit2:

Implement support infrastructure to notify the UI client when window.close() is called.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h: Added method declaration for -_webViewClose:.
  • UIProcess/Cocoa/UIDelegate.h: Added override declaration for API::UIClient::close().
  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate): Wire up delegate method to Objective-C selector, -[WKUIDelegatePrivate _webViewClose:].
(WebKit::UIDelegate::UIClient::close): Added; turns around and calls -[WKUIDelegatePrivate _webViewClose:] (if applicable).

Tools:

Add a test to ensure that -[WKUIDelegatePrivate _webViewClose:] is called on window.close()
for window opened via JavaScript (i.e. window.open()).

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/open-and-close-window.html: Added.
  • TestWebKitAPI/Tests/WebKit2Cocoa/OpenAndCloseWindow.mm: Added.
2:13 PM Changeset in webkit [173850] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.11-branch/Source/WebKit2

Merged r173788. <rdar://problem/17878728>

2:10 PM Changeset in webkit [173849] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.11-branch/Source/WebKit2

Roll out r171775. <rdar://problem/17173916>

2:10 PM Changeset in webkit [173848] by ap@apple.com
  • 2 edits in trunk/Source/WebCore

WebSocket crash when a connection is closed from server side
​https://bugs.webkit.org/show_bug.cgi?id=137009
rdar://problem/18333977
rdar://problem/12708225

Reviewed by Brady Eidson.

I don't think that this can be tested with our test server.

  • Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::WebSocketChannel): Added logging.
(WebCore::WebSocketChannel::~WebSocketChannel): Ditto.
(WebCore::WebSocketChannel::close): Protect self, because startClosingHandshake
can release the last reference.
(WebCore::WebSocketChannel::fail): Added an assertion that the channel is always
closed after this function.
(WebCore::WebSocketChannel::startClosingHandshake): Protect self, and don't change
the stack from closed back to closing if after failing to send closing handshake.
(WebCore::WebSocketChannel::processOutgoingFrameQueue): Protect self.

1:25 PM Changeset in webkit [173847] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

FTL allocatePropertyStorage code should involve less copy-paste
​https://bugs.webkit.org/show_bug.cgi?id=137006

Reviewed by Michael Saboff.

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::allocatePropertyStorage):
(JSC::FTL::LowerDFGToLLVM::reallocatePropertyStorage):
(JSC::FTL::LowerDFGToLLVM::allocatePropertyStorageWithSizeImpl):

1:04 PM Changeset in webkit [173846] by bshafiei@apple.com
  • 2 edits in branches/safari-600.1.4.11-branch/Source/WebKit2

Merged r171775. <rdar://problem/17173916>

12:52 PM Changeset in webkit [173845] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

Bad cast in isValidColumnSpanner.
​https://bugs.webkit.org/show_bug.cgi?id=133380.

Reviewed by Simon Fraser.

Source/WebCore:

Added fast/multicol/multicol-crazy-nesting.html

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::isValidColumnSpanner):
The crawl up the chain looking for unsplittable objects should use containing blocks
and not be casting to parent boxes. You can have an inline in the parent chain, so
this was not the right way to walk up the tree.

LayoutTests:

  • fast/multicol/multicol-crazy-nesting-expected.txt: Added.
  • fast/multicol/multicol-crazy-nesting.html: Added.
12:01 PM Changeset in webkit [173844] by Lucas Forschler
  • 1 move in branches/safari-600.1.4.10-branch

Fix typo.

11:55 AM Changeset in webkit [173843] by hyatt@apple.com
  • 3 edits
    2 adds in trunk

ASSERT in RenderMultiColumnSet::requiresBalancing.
​https://bugs.webkit.org/show_bug.cgi?id=136376.

Reviewed by David Kilzer.

Source/WebCore:

Added fast/multicol/multicol-selection.html.

  • rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::isValidColumnSpanner):
Don't allow an object to become a spanner if it does not have the flow
thread as its containing block. Otherwise the flow thread won't get notified
of spanner placeholder insertions, and so the spanner ends up orphaned.

LayoutTests:

  • fast/multicol/multicol-selection-expected.txt: Added.
  • fast/multicol/multicol-selection.html: Added.
11:51 AM Changeset in webkit [173842] by bshafiei@apple.com
  • 5 edits in branches/safari-600.1.4.11-branch/Source

Versioning.

11:36 AM Changeset in webkit [173841] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

W3C importer should import html files within resources folders
​https://bugs.webkit.org/show_bug.cgi?id=127548

Patch by Youenn Fablet <​youennf@gmail.com> on 2014-09-22
Reviewed by Ryosuke Niwa.

Import HTML files in any folder named "resources" even if file is not detected as a HTML test file

  • Scripts/webkitpy/w3c/test_importer.py:

(TestImporter.find_importable_tests):

11:35 AM Changeset in webkit [173840] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

[Win] Implement cap height in SimpleFontDataWin to enable initial-letter support for Windows.
​https://bugs.webkit.org/show_bug.cgi?id=136841

Reviewed by David Hyatt.

  • platform/graphics/win/SimpleFontDataCGWin.cpp:

(WebCore::SimpleFontData::platformInit): Add missing calls to set up our fonts.

9:53 AM Changeset in webkit [173839] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk

Simple ES6 feature: Number constructor extras
​https://bugs.webkit.org/show_bug.cgi?id=131707

Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-09-22
Reviewed by Darin Adler.

Source/JavaScriptCore:

  • runtime/CommonIdentifiers.h: Added new identifiers.
  • runtime/NumberConstructor.cpp:

(JSC::NumberConstructor::getOwnPropertySlot):
(JSC::NumberConstructor::isFunction): Added.
(JSC::numberConstructorEpsilonValue): Added.
(JSC::numberConstructorNegInfinity): Added.
(JSC::numberConstructorPosInfinity): Added.
(JSC::numberConstructorMaxValue): Added.
(JSC::numberConstructorMinValue): Added.
(JSC::numberConstructorMaxSafeInteger): Added.
(JSC::numberConstructorMinSafeInteger): Added.
(JSC::numberConstructorFuncIsFinite): Added.
(JSC::numberConstructorFuncIsInteger): Added.
(JSC::numberConstructorFuncIsNaN): Added.
(JSC::numberConstructorFuncIsSafeInteger): Added.

  • runtime/NumberConstructor.h:

LayoutTests:

  • js/Object-getOwnPropertyNames-expected.txt:
  • js/number-constructor-expected.txt: Added.
  • js/number-constructor.html: Added.
  • js/script-tests/Object-getOwnPropertyNames.js:
  • js/script-tests/number-constructor.js: Added.
8:51 AM Changeset in webkit [173838] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Update HTMLMediaElement logging
​https://bugs.webkit.org/show_bug.cgi?id=136991

Reviewed by Alexey Proskuryakov.

No new tests, only logging was changed.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::~HTMLMediaElement):
(WebCore::HTMLMediaElement::parseAttribute):

8:34 AM Changeset in webkit [173837] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

FTL should store the four bytes of the cell header using a 32-bit store rather than four 8-bit stores
​https://bugs.webkit.org/show_bug.cgi?id=136992

Reviewed by Sam Weinig.

LLVM ought to be able to do this optimization for us given how the code was written, but
any such lower-level attempts to optimize this would get into trouble with the weird
object materialization logic I'll be introducing in bug 136330. So, this brings the
merging of the byte stores into the FTL lowering so that we can control it explicitly.

  • ftl/FTLAbstractHeap.h:

(JSC::FTL::AbstractHeap::changeParent):

  • ftl/FTLAbstractHeapRepository.cpp:

(JSC::FTL::AbstractHeapRepository::AbstractHeapRepository):

  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::LowerDFGToLLVM::allocateCell):

8:00 AM Changeset in webkit [173836] by evab.u-szeged@partner.samsung.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r173631): It broke the !ENABLE(VIDEO) build
​https://bugs.webkit.org/show_bug.cgi?id=136946

Reviewed by Jer Noble.

No new tests required, no new functionality.

  • page/DragController.cpp:

(WebCore::DragController::startDrag):

7:47 AM Changeset in webkit [173835] by mihnea@adobe.com
  • 6 edits in trunk/Source/WebCore

[CSSRegions] Use nullptr in regions code
​https://bugs.webkit.org/show_bug.cgi?id=137001

Reviewed by Andrei Bucur.

No new tests as no new functionality is introduced.

  • dom/DOMNamedFlowCollection.cpp:

(WebCore::DOMNamedFlowCollection::item):
(WebCore::DOMNamedFlowCollection::namedItem):

  • dom/NamedFlowCollection.cpp:

(WebCore::NamedFlowCollection::flowByName):

  • dom/WebKitNamedFlow.cpp:

(WebCore::WebKitNamedFlow::WebKitNamedFlow):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::getLayerListForRegion):
(WebCore::RenderFlowThread::regionForCompositedLayer):
(WebCore::RenderFlowThread::regionAtBlockOffset):
(WebCore::RenderFlowThread::mapFromFlowToRegion):
(WebCore::RenderFlowThread::firstRegion):
(WebCore::RenderFlowThread::lastRegion):
(WebCore::RenderFlowThread::currentActiveRenderBox):

  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::nextRendererForElement):

4:20 AM Changeset in webkit [173834] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Tools

Merge r173832 - [GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
​https://bugs.webkit.org/show_bug.cgi?id=136998

Reviewed by Philippe Normand.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(testWebViewCanShowMIMEType): Remove the check of PDF as
unsupported MIME type.

4:19 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos
(diff)
4:19 AM Changeset in webkit [173833] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po

Merge r173831 - [kn] Kannada Translation for webkit - Updated
​https://bugs.webkit.org/show_bug.cgi?id=116941

Patch by Shankar Prasad <​svenkate@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.

  • kn.po:
4:15 AM Changeset in webkit [173832] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Test /webkit2/WebKitWebView/can-show-mime-type fails if evince browser plugin is installed
​https://bugs.webkit.org/show_bug.cgi?id=136998

Reviewed by Philippe Normand.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:

(testWebViewCanShowMIMEType): Remove the check of PDF as
unsupported MIME type.

4:11 AM WebKitGTK/2.6.x edited by berto@igalia.com
(diff)
4:10 AM Changeset in webkit [173831] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[kn] Kannada Translation for webkit - Updated
​https://bugs.webkit.org/show_bug.cgi?id=116941

Patch by Shankar Prasad <​svenkate@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.

  • kn.po:
3:40 AM Changeset in webkit [173830] by Carlos Garcia Campos
  • 7 edits
    2 adds in releases/WebKitGTK/webkit-2.6

Merge r173806 - [CSS Regions] Assertion failure and null dereference crash when using animations and regions
​https://bugs.webkit.org/show_bug.cgi?id=136918

Reviewed by Andrei Bucur.

Source/WebCore:

In some situations, for instance when an image has an attached animation, the style change caused by the animation
triggers a geometry update for the backing store associated with the image's layer. This may occur before
the layout for the image has finished.

Moreover, if the image in such situation - having a composited layer - is displayed in a region,
sicne the layout did not finish yet, the mappings between the layers of the elements collected in the named flow
and the regions associated with the named flow are not updated and cannot be used.

Therefore in those situations, we have to bail out early and use these mappings only after the layout has finished.

This patch also changes RenderLayerBacking method updateAfterDescendents -> updateAfterDescendants.

Test: fast/regions/animated-image-in-region.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::cachedRegionForCompositedLayer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterDescendants):

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):

LayoutTests:

  • fast/regions/animated-image-in-region-expected.txt: Added.
  • fast/regions/animated-image-in-region.html: Added.
3:34 AM Changeset in webkit [173829] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r173800 - Fix post-mortem nits for r173724
​https://bugs.webkit.org/show_bug.cgi?id=136986

Reviewed by Darin Adler.

Fix post-mortem nits for r173724.

No new tests, no behavior change.

  • editing/EditingStyle.cpp:

(WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue):
(WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue):
Use nullptr instead of 0.

  • editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::doUnapply):
Use getIdAttribute() / setIdAttribute().

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computePreferredLogicalWidths):
Use fastHasAttribute() for nowrap and do an early return to avoid
calling styleOrColLogicalWidth() if the nowrap attribute is missing.

3:32 AM Changeset in webkit [173828] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/JavaScriptCore

Merge r173787 - Leak of mallocs under StructureSet::OutOfLineList::create
​https://bugs.webkit.org/show_bug.cgi?id=136970

Reviewed by Filip Pizlo.

addOutOfLine should free the old list when expanding the capacity.

  • bytecode/StructureSet.cpp:

(JSC::StructureSet::addOutOfLine):

3:29 AM Changeset in webkit [173827] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore

Merge r173767 - REGRESSION(r173464): It broke the !ENABLE(PICTURE_SIZES) build
​https://bugs.webkit.org/show_bug.cgi?id=136942

Reviewed by Simon Fraser.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):

3:01 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos
(diff)
2:56 AM Changeset in webkit [173826] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po

Merge r173824 - [l10n] [mr] WebKitGTK+ Marathi Translations
​https://bugs.webkit.org/show_bug.cgi?id=136979

Patch by Sandeep Shedmake <​sandeep.shedmake@gmail.com> on 2014-09-22
Reviewed by Philippe Normand.

  • mr.po:
2:53 AM Changeset in webkit [173825] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Fix WebKitGTKTranslations rule in watchlist.

In r145081 GTK+ translations were moved from Source/WebKit/gtk/po/
to Source/WebCore/platform/gtk/po/ but the rule was not updated.

  • Scripts/webkitpy/common/config/watchlist: Use

Source/WebCore/platform/gtk/po/ as directory to watch for
WebKitGTKTranslations rule and add berto and myself to the list of
watchers.

2:48 AM Changeset in webkit [173824] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] [mr] WebKitGTK+ Marathi Translations
​https://bugs.webkit.org/show_bug.cgi?id=136979

Patch by Sandeep Shedmake <​sandeep.shedmake@gmail.com> on 2014-09-22
Reviewed by Philippe Normand.

  • mr.po:
2:47 AM WebKitGTK/2.6.x edited by berto@igalia.com
(diff)
2:42 AM Changeset in webkit [173823] by Carlos Garcia Campos
  • 6 edits
    4 adds in releases/WebKitGTK/webkit-2.6

Merge r173809 - [GStreamer] Cannot play Vimeo video
​https://bugs.webkit.org/show_bug.cgi?id=134969

Reviewed by Sergio Villar Senin.

Source/WebCore:

Ensure the GStreamer HTTP source element also sends cookies when
it's sending its requests. Some streaming platforms such as Vimeo
do server-side cookie checks on incoming requests before serving
media data.

Test: http/tests/media/hls/video-cookie.html

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart): Set first-party cookie URL to the request so
the ResourceLoader properly sets cookies in the HTTP request.

LayoutTests:

New test for a HLS stream enforcing a specific cookie before
serving its fragments, like Vimeo does.

  • http/tests/media/hls/video-cookie-expected.txt: Added.
  • http/tests/media/hls/video-cookie.html: Added.
  • http/tests/media/resources/hls/playlist-with-cookie.m3u8: Added.
  • http/tests/media/resources/hls/sub-playlist-with-cookie.php: Added.
  • http/tests/media/resources/video-cookie-check-cookie.php:
  • platform/gtk/TestExpectations: Marked test as slow, as the other

HLS test.

2:41 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos
(diff)
2:37 AM Changeset in webkit [173822] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po

Merge r173815 - [l10n] Updated Polish translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=136976

Patch by Piotr Drąg <​piotrdrag@gmail.com> on 2014-09-22
Reviewed by Philippe Normand.

  • pl.po:
2:36 AM Changeset in webkit [173821] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po

Merge r173814 - [l10n] Updated Hebrew translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=136678

Patch by Yosef Or Boczko <​yoseforb@gnome.org> on 2014-09-22
Reviewed by Philippe Normand.

  • he.po:
2:36 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos
(diff)
2:35 AM Changeset in webkit [173820] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po

Merge r173813 - Webkit Tamil translations updated
​https://bugs.webkit.org/show_bug.cgi?id=136816

Patch by Shantha kumar <​shantha.thamizh@gmail.com> on 2014-09-22
Reviewed by Philippe Normand.

  • ta.po:
2:34 AM Changeset in webkit [173819] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po

Merge r173812 - [as] Updated Assamese translations of WebKitGtk+
​https://bugs.webkit.org/show_bug.cgi?id=136908

Patch by Nilamdyuti Goswami <​ngoswami@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.

  • as.po:
2:33 AM Changeset in webkit [173818] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po

Merge r173811 - Odia (or_IN) translation for webkit
​https://bugs.webkit.org/show_bug.cgi?id=136920

Patch by Manoj Kumar Giri <​mgiri@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.

  • or.po:
2:32 AM Changeset in webkit [173817] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore/platform/gtk/po

Merge r173810 - Webkit Gujarati Translations
​https://bugs.webkit.org/show_bug.cgi?id=136525

Patch by Sweta Kothari <​swkothar@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.

  • gu.po:
2:29 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos
(diff)
2:29 AM WebKitGTK/2.6.x edited by Carlos Garcia Campos
(diff)
1:51 AM Changeset in webkit [173816] by ryuan.choi@gmail.com
  • 2 edits in trunk/Tools

Fix syntaxError in watchlist since r173594
​https://bugs.webkit.org/show_bug.cgi?id=136996

Reviewed by Philippe Normand.

  • Scripts/webkitpy/common/config/watchlist: Removed unnecessary comma.
1:44 AM WebKitGTK/2.6.x edited by philn@igalia.com
(diff)
1:41 AM WebKitGTK/2.6.x edited by berto@igalia.com
(diff)
1:36 AM Changeset in webkit [173815] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Polish translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=136976

Patch by Piotr Drąg <​piotrdrag@gmail.com> on 2014-09-22
Reviewed by Philippe Normand.

  • pl.po:
1:34 AM Changeset in webkit [173814] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[l10n] Updated Hebrew translation of WebKitGTK+
​https://bugs.webkit.org/show_bug.cgi?id=136678

Patch by Yosef Or Boczko <​yoseforb@gnome.org> on 2014-09-22
Reviewed by Philippe Normand.

  • he.po:
1:33 AM Changeset in webkit [173813] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Webkit Tamil translations updated
​https://bugs.webkit.org/show_bug.cgi?id=136816

Patch by Shantha kumar <​shantha.thamizh@gmail.com> on 2014-09-22
Reviewed by Philippe Normand.

  • ta.po:
1:32 AM Changeset in webkit [173812] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

[as] Updated Assamese translations of WebKitGtk+
​https://bugs.webkit.org/show_bug.cgi?id=136908

Patch by Nilamdyuti Goswami <​ngoswami@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.

  • as.po:
1:30 AM Changeset in webkit [173811] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Odia (or_IN) translation for webkit
​https://bugs.webkit.org/show_bug.cgi?id=136920

Patch by Manoj Kumar Giri <​mgiri@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.

  • or.po:
1:28 AM Changeset in webkit [173810] by berto@igalia.com
  • 2 edits in trunk/Source/WebCore/platform/gtk/po

Webkit Gujarati Translations
​https://bugs.webkit.org/show_bug.cgi?id=136525

Patch by Sweta Kothari <​swkothar@redhat.com> on 2014-09-22
Reviewed by Philippe Normand.

  • gu.po:
1:15 AM Changeset in webkit [173809] by Philippe Normand
  • 6 edits
    4 adds in trunk

[GStreamer] Cannot play Vimeo video
​https://bugs.webkit.org/show_bug.cgi?id=134969

Reviewed by Sergio Villar Senin.

Source/WebCore:

Ensure the GStreamer HTTP source element also sends cookies when
it's sending its requests. Some streaming platforms such as Vimeo
do server-side cookie checks on incoming requests before serving
media data.

Test: http/tests/media/hls/video-cookie.html

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcStart): Set first-party cookie URL to the request so
the ResourceLoader properly sets cookies in the HTTP request.

LayoutTests:

New test for a HLS stream enforcing a specific cookie before
serving its fragments, like Vimeo does.

  • http/tests/media/hls/video-cookie-expected.txt: Added.
  • http/tests/media/hls/video-cookie.html: Added.
  • http/tests/media/resources/hls/playlist-with-cookie.m3u8: Added.
  • http/tests/media/resources/hls/sub-playlist-with-cookie.php: Added.
  • http/tests/media/resources/video-cookie-check-cookie.php:
  • platform/gtk/TestExpectations: Marked test as slow, as the other

HLS test.

12:51 AM Changeset in webkit [173808] by mihnea@adobe.com
  • 2 edits in trunk/Source/WebCore

Leverage RenderLayerBacking::renderer() instead of m_owningLayer.renderer()
​https://bugs.webkit.org/show_bug.cgi?id=136954

Reviewed by Darin Adler.

No new tests just refactoring.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateCompositedBounds):
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundImage):
(WebCore::RenderLayerBacking::paintIntoLayer):

12:20 AM Changeset in webkit [173807] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WTF

Eliminate redundant PtrHash specializations
​https://bugs.webkit.org/show_bug.cgi?id=136990

Patch by Sam Weinig <​sam@webkit.org> on 2014-09-22
Reviewed by Darin Adler.

Now that we have IsSmartPtr, we can eliminate all the specializations
of PtrHash that we had (for RefPtr, OwnPtr, RetainPtr, and std::unique_ptr)
and instead just have one that uses GetPtrHelper.

No changes of behavior intended.

  • wtf/GetPtr.h:

Remove unnecessary const_cast that Darin noticed.

  • wtf/HashFunctions.h:

(WTF::PtrHash::hash): Deleted.
(WTF::PtrHash::equal): Deleted.
(WTF::PtrHash<RefPtr<P>>::hash): Deleted.
(WTF::PtrHash<RefPtr<P>>::equal): Deleted.
Specialize PtrHash based on whether the type is a smart pointer, and use GetPtrHelper
to implement the smart pointer specialized variant.

  • wtf/HashMap.h:

Remove include of GetPtr.h that is now included by HashFunctions.h

  • wtf/OwnPtr.h:

(WTF::PtrHash<OwnPtr<P>>::hash): Deleted.
(WTF::PtrHash<OwnPtr<P>>::equal): Deleted.
Remove unnecessary specialization of PtrHash.

  • wtf/RetainPtr.h:

(WTF::PtrHash<RetainPtr<P>>::hash): Deleted.
(WTF::PtrHash<RetainPtr<P>>::equal): Deleted.
Specialize IsSmartPointer for RetainPtr and remove the then unnecessary specialization of PtrHash.
(This is already tested in the API test WTF/cf/RetainPtrHashing).

12:08 AM Changeset in webkit [173806] by mihnea@adobe.com
  • 7 edits
    2 adds in trunk

[CSS Regions] Assertion failure and null dereference crash when using animations and regions
​https://bugs.webkit.org/show_bug.cgi?id=136918

Reviewed by Andrei Bucur.

Source/WebCore:

In some situations, for instance when an image has an attached animation, the style change caused by the animation
triggers a geometry update for the backing store associated with the image's layer. This may occur before
the layout for the image has finished.

Moreover, if the image in such situation - having a composited layer - is displayed in a region,
sicne the layout did not finish yet, the mappings between the layers of the elements collected in the named flow
and the regions associated with the named flow are not updated and cannot be used.

Therefore in those situations, we have to bail out early and use these mappings only after the layout has finished.

This patch also changes RenderLayerBacking method updateAfterDescendents -> updateAfterDescendants.

Test: fast/regions/animated-image-in-region.html

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::cachedRegionForCompositedLayer):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterDescendants):

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):

LayoutTests:

  • fast/regions/animated-image-in-region-expected.txt: Added.
  • fast/regions/animated-image-in-region.html: Added.

Sep 21, 2014:

11:58 PM Changeset in webkit [173805] by saambarati1@gmail.com
  • 5 edits in trunk/Source

Web Inspector: fix TypeSet hierarchy in TypeTokenView
​https://bugs.webkit.org/show_bug.cgi?id=136982

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

TypeSet was computing the set of type booleans in the Inspector::Protocol::Runtime::TypeSet
object incorrectly because it was calling TypeSet::doesTypeConformTo(T) which checks if the
type set has only been of type T. It now checks '(m_seenTypes & T) != TypeNothing' to see
if type T is in the set of seen types, but not the entire set itself.

  • runtime/TypeSet.cpp:

(JSC::TypeSet::inspectorTypeSet):

Source/WebInspectorUI:

The protocol object representation of TypeSet was being computed
incorrectly in JSC::TypeSet. This patch fixes that problem
and also asserts that the type information that the Web Inspector
receives is not empty.

  • UserInterface/Models/TypeSet.js:

(WebInspector.TypeSet):

  • UserInterface/Views/TypeTokenView.js:

(WebInspector.TypeTokenView.prototype._displayTypeName):

10:59 PM BadContent edited by Csaba Osztrogonác
add one more spammer (diff)
8:51 PM Changeset in webkit [173804] by Chris Dumez
  • 167 edits in trunk/Source

Generate Element casting helper functions
​https://bugs.webkit.org/show_bug.cgi?id=136839

Reviewed by Darin Adler.

Source/WebCore:

Generate Element casting helper functions instead of requiring explicit
use of NODE_TYPE_CASTS() macro. Casting is now done using the following
form: downcast<HTMLDivElement>(), instead of toHTMLDivElement().

The previous form (i.e. toHTMLDivElement()) is still supported for now
by generating macros that convert these calls into the new form, until
the code base is ported to the new casting helpers.

The plan is also to use is<HTMLDivElement>() instead of
isHTMLDivElement() for consistency but this was not changed in this
patch to avoid blowing up the size.

This CL also updates the way we convert a JSValue into an
implementation pointer. Instead of using toHTMLDivElement(), which
looked like a cast, we now use JSHTMLDivElement::toWrapped(). This
avoids conflicting with the toXXXElement() macros and makes it
clearer this is not a simple cast.

No new tests, no behavior change.

  • Modules/plugins/QuickTimePluginReplacement.mm:

(WebCore::QuickTimePluginReplacement::installReplacement):

  • WebCore.exp.in:
  • bindings/js/JSAudioBufferSourceNodeCustom.cpp:

(WebCore::JSAudioBufferSourceNode::setBuffer):

  • bindings/js/JSBlobCustom.cpp:

(WebCore::constructJSBlob):

  • bindings/js/JSCommandLineAPIHostCustom.cpp:

(WebCore::JSCommandLineAPIHost::getEventListeners):
(WebCore::JSCommandLineAPIHost::databaseId):
(WebCore::JSCommandLineAPIHost::storageId):

  • bindings/js/JSDOMFormDataCustom.cpp:

(WebCore::toHTMLFormElementOrNull):
(WebCore::constructJSDOMFormData):
(WebCore::JSDOMFormData::append):
(WebCore::toHTMLFormElement): Deleted.

  • bindings/js/JSDOMStringListCustom.cpp:

(WebCore::JSDOMStringList::toWrapped):
(WebCore::toDOMStringList): Deleted.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::toWrapped):
(WebCore::toDOMWindow): Deleted.

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSDocumentCustom.cpp:

(WebCore::JSDocument::createTouchList):

  • bindings/js/JSEventTargetCustom.cpp:

(WebCore::JSEventTarget::toWrapped):
(WebCore::toEventTarget): Deleted.

  • bindings/js/JSExceptionBase.cpp:

(WebCore::toExceptionBase):

  • bindings/js/JSHTMLMediaElementCustom.cpp:

(WebCore::JSHTMLMediaElement::setController):

  • bindings/js/JSHTMLOptionsCollectionCustom.cpp:

(WebCore::JSHTMLOptionsCollection::add):
(WebCore::JSHTMLOptionsCollection::remove):

  • bindings/js/JSHTMLSelectElementCustom.cpp:

(WebCore::JSHTMLSelectElement::remove):
(WebCore::selectIndexSetter):

  • bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::showContextMenu):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::handleInitMessageEvent):

  • bindings/js/JSMessagePortCustom.cpp:

(WebCore::fillMessagePortArray):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::JSNode::insertBefore):
(WebCore::JSNode::replaceChild):
(WebCore::JSNode::removeChild):
(WebCore::JSNode::appendChild):

  • bindings/js/JSNodeFilterCustom.cpp:

(WebCore::JSNodeFilter::toWrapped):
(WebCore::toNodeFilter): Deleted.

  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::JSSubtleCrypto::encrypt):
(WebCore::JSSubtleCrypto::decrypt):
(WebCore::JSSubtleCrypto::sign):
(WebCore::JSSubtleCrypto::verify):
(WebCore::JSSubtleCrypto::exportKey):
(WebCore::JSSubtleCrypto::wrapKey):
(WebCore::JSSubtleCrypto::unwrapKey):

  • bindings/js/JSWebGLRenderingContextCustom.cpp:

(WebCore::JSWebGLRenderingContext::getAttachedShaders):
(WebCore::JSWebGLRenderingContext::getProgramParameter):
(WebCore::JSWebGLRenderingContext::getShaderParameter):
(WebCore::JSWebGLRenderingContext::getUniform):
(WebCore::dataFunctionf):
(WebCore::dataFunctioni):
(WebCore::dataFunctionMatrix):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpIfTerminal):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GenerateImplementation):
(GenerateParametersCheck):
(JSValueToNative):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):
(WebCore::JSTestActiveDOMObject::toWrapped):
(WebCore::toTestActiveDOMObject): Deleted.

  • bindings/scripts/test/JS/JSTestActiveDOMObject.h:
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetter::toWrapped):
(WebCore::toTestCustomNamedGetter): Deleted.

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::toWrapped):
(WebCore::toTestEventConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestEventConstructor.h:
  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::jsTestEventTargetPrototypeFunctionDispatchEvent):
(WebCore::JSTestEventTarget::toWrapped):
(WebCore::toTestEventTarget): Deleted.

  • bindings/scripts/test/JS/JSTestEventTarget.h:
  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestException::toWrapped):
(WebCore::toTestException): Deleted.

  • bindings/scripts/test/JS/JSTestException.h:
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachable::toWrapped):
(WebCore::toTestGenerateIsReachable): Deleted.

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::setJSTestInterfaceImplementsNode):
(WebCore::setJSTestInterfaceSupplementalNode):
(WebCore::jsTestInterfacePrototypeFunctionImplementsMethod2):
(WebCore::jsTestInterfacePrototypeFunctionSupplementalMethod2):
(WebCore::JSTestInterface::toWrapped):
(WebCore::toTestInterface): Deleted.

  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListener::toWrapped):
(WebCore::toTestMediaQueryListListener): Deleted.

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructor::toWrapped):
(WebCore::toTestNamedConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:
  • bindings/scripts/test/JS/JSTestNondeterministic.cpp:

(WebCore::JSTestNondeterministic::toWrapped):
(WebCore::toTestNondeterministic): Deleted.

  • bindings/scripts/test/JS/JSTestNondeterministic.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjTestObjAttr):
(WebCore::setJSTestObjXMLObjAttr):
(WebCore::setJSTestObjWithScriptExecutionContextAttribute):
(WebCore::setJSTestObjWithScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptArgumentsAndCallStackAttribute):
(WebCore::setJSTestObjMutablePoint):
(WebCore::setJSTestObjImmutablePoint):
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionByteMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionOctetMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionLongMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs):
(WebCore::jsTestObjPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestObjPrototypeFunctionMethodThatRequiresAllArgsAndThrows):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod8):
(WebCore::jsTestObjPrototypeFunctionConvert1):
(WebCore::jsTestObjPrototypeFunctionConvert2):
(WebCore::jsTestObjPrototypeFunctionConvert4):
(WebCore::jsTestObjPrototypeFunctionConvert5):
(WebCore::jsTestObjPrototypeFunctionStrictFunctionWithSequence):
(WebCore::jsTestObjPrototypeFunctionStrictFunctionWithArray):
(WebCore::jsTestObjPrototypeFunctionVariadicNodeMethod):
(WebCore::JSTestObj::toWrapped):
(WebCore::toTestObj): Deleted.

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructorsConstructor::constructJSTestOverloadedConstructors3):
(WebCore::JSTestOverloadedConstructors::toWrapped):
(WebCore::toTestOverloadedConstructors): Deleted.

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::toWrapped):
(WebCore::toTestSerializedScriptValueInterface): Deleted.

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::jsTestTypedefsPrototypeFunctionMethodWithSequenceArg):
(WebCore::jsTestTypedefsPrototypeFunctionCallWithSequenceThatRequiresInclude):
(WebCore::JSTestTypedefs::toWrapped):
(WebCore::toTestTypedefs): Deleted.

  • bindings/scripts/test/JS/JSTestTypedefs.h:
  • bindings/scripts/test/JS/JSattribute.cpp:

(WebCore::JSattribute::toWrapped):
(WebCore::toattribute): Deleted.

  • bindings/scripts/test/JS/JSattribute.h:
  • bindings/scripts/test/JS/JSreadonly.cpp:

(WebCore::JSreadonly::toWrapped):
(WebCore::toreadonly): Deleted.

  • bindings/scripts/test/JS/JSreadonly.h:
  • dom/Element.h:

(WebCore::downcast):

  • dom/make_names.pl:

(printTypeHelpers):

  • html/HTMLAnchorElement.h:
  • html/HTMLAreaElement.h:
  • html/HTMLAudioElement.h:
  • html/HTMLBaseElement.h:
  • html/HTMLBodyElement.h:
  • html/HTMLCanvasElement.h:
  • html/HTMLDataListElement.h:
  • html/HTMLDetailsElement.h:
  • html/HTMLDivElement.h:
  • html/HTMLEmbedElement.h:
  • html/HTMLFieldSetElement.h:
  • html/HTMLFormElement.h:
  • html/HTMLFrameElement.h:
  • html/HTMLFrameSetElement.h:
  • html/HTMLHtmlElement.h:
  • html/HTMLIFrameElement.h:
  • html/HTMLImageElement.h:
  • html/HTMLInputElement.h:
  • html/HTMLLabelElement.h:
  • html/HTMLLegendElement.h:
  • html/HTMLLinkElement.h:
  • html/HTMLMapElement.h:
  • html/HTMLMarqueeElement.h:
  • html/HTMLMetaElement.h:
  • html/HTMLMeterElement.h:
  • html/HTMLOListElement.h:
  • html/HTMLObjectElement.h:
  • html/HTMLOptGroupElement.h:
  • html/HTMLOptionElement.h:
  • html/HTMLParamElement.h:
  • html/HTMLProgressElement.h:
  • html/HTMLScriptElement.h:
  • html/HTMLSelectElement.h:
  • html/HTMLSourceElement.h:
  • html/HTMLStyleElement.h:
  • html/HTMLSummaryElement.h:
  • html/HTMLTableCaptionElement.h:
  • html/HTMLTableElement.h:
  • html/HTMLTableRowElement.h:
  • html/HTMLTemplateElement.h:
  • html/HTMLTextAreaElement.h:
  • html/HTMLTitleElement.h:
  • html/HTMLTrackElement.h:
  • html/HTMLVideoElement.h:
  • inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::scriptValueAsNode):

  • mathml/MathMLMencloseElement.h:
  • svg/SVGAltGlyphDefElement.h:
  • svg/SVGAltGlyphElement.h:
  • svg/SVGAltGlyphItemElement.h:
  • svg/SVGAnimateMotionElement.h:
  • svg/SVGAnimateTransformElement.h:
  • svg/SVGCircleElement.h:
  • svg/SVGClipPathElement.h:
  • svg/SVGCursorElement.h:
  • svg/SVGEllipseElement.h:
  • svg/SVGFEDistantLightElement.h:
  • svg/SVGFEFuncAElement.h:
  • svg/SVGFEFuncBElement.h:
  • svg/SVGFEFuncGElement.h:
  • svg/SVGFEFuncRElement.h:
  • svg/SVGFEMergeNodeElement.h:
  • svg/SVGFEPointLightElement.h:
  • svg/SVGFESpotLightElement.h:
  • svg/SVGFilterElement.h:
  • svg/SVGFontElement.h:
  • svg/SVGFontFaceElement.h:
  • svg/SVGFontFaceNameElement.h:
  • svg/SVGFontFaceSrcElement.h:
  • svg/SVGFontFaceUriElement.h:
  • svg/SVGForeignObjectElement.h:
  • svg/SVGGlyphElement.h:
  • svg/SVGGlyphRefElement.h:
  • svg/SVGHKernElement.h:
  • svg/SVGImageElement.h:
  • svg/SVGLineElement.h:
  • svg/SVGLinearGradientElement.h:
  • svg/SVGMPathElement.h:
  • svg/SVGMarkerElement.h:
  • svg/SVGMaskElement.h:
  • svg/SVGMissingGlyphElement.h:
  • svg/SVGPathElement.h:
  • svg/SVGPatternElement.h:
  • svg/SVGPolygonElement.h:
  • svg/SVGPolylineElement.h:
  • svg/SVGRadialGradientElement.h:
  • svg/SVGRectElement.h:
  • svg/SVGSVGElement.h:
  • svg/SVGScriptElement.h:
  • svg/SVGStopElement.h:
  • svg/SVGStyleElement.h:
  • svg/SVGTextElement.h:
  • svg/SVGTextPathElement.h:
  • svg/SVGTitleElement.h:
  • svg/SVGUseElement.h:
  • svg/SVGVKernElement.h:
  • svg/SVGViewElement.h:

Source/WebKit:

Update some of the exported symbols on Windows for functions that were
renamed.

  • WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/mac:

Use JSXXX::toWrapped() instead of toXXX() function.

  • DOM/WebDOMOperations.mm:
  • WebView/WebView.mm:

(-[WebView _notificationIDForTesting:]):

Source/WebKit/win:

Use JSXXX::toWrapped() instead of toXXX() function.

  • WebView.cpp:

(WebView::elementFromJS):

Source/WebKit2:

Use JSXXX::toWrapped() instead of toXXX() function.

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::InjectedBundleNodeHandle::getOrCreate):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::getOrCreate):

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::webNotificationID):

8:42 PM Changeset in webkit [173803] by saambarati1@gmail.com
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: unlocalized 'many' string in type profiler inline bubble
​https://bugs.webkit.org/show_bug.cgi?id=136980

Reviewed by Timothy Hatcher.

Generate the localizable string for the type profiler's "many" inline bubble.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Views/TypeTokenView.js:
5:31 PM Changeset in webkit [173802] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit/mac

Leak: WebNotificationPrivate ObjC leaks seen on leaks bot
​https://bugs.webkit.org/show_bug.cgi?id=136972

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-21
Reviewed by Darin Adler.

  • WebView/WebNotification.h:
  • WebView/WebNotification.mm:

(-[WebNotification initWithCoreNotification:notificationID:]):
Switch to RetainPtr and adopt into _private to ensure when we are
deallocated that _private will get deallocated.

5:24 PM Changeset in webkit [173801] by weinig@apple.com
  • 15 edits
    1 move
    1 add in trunk

Make possible HashSet<std::unique_ptr<>>
​https://bugs.webkit.org/show_bug.cgi?id=136166

Reviewed by Darin Adler.

Source/WTF:

  • wtf/GetPtr.h:

(WTF::getPtr):
(WTF::GetPtrHelper<std::unique_ptr<T>>::getPtr):
Make specializing GetPtrHelper a bit cleaner (you don't have to put
IsSmartPtr<T>::value everywhere any more) and add specializations for
std::unique_ptr.

  • wtf/HashFunctions.h:

(WTF::PtrHash<std::unique_ptr<P>>):
Add specialization for PtrHash for std::unique_ptr and set it as the DefaultHash
for it as well.

  • wtf/HashMap.h:
  • wtf/HashSet.h:

Add overloads of find(), contains(), remove(), take() (and get() for HashMap) for "smart pointers" that
take the raw pointer type as the parameter. These use SFINAE to make themselves only available
when the IsSmartPtr<KeyType>::value is true.

  • wtf/HashTraits.h:

Override constructDeletedValue() and isDeletedValue() in the std::unique_ptr specialization
since the default implementation depends on the type having a constructor that takes a HashTableDeletedValue
and function named isHashTableDeletedValue().

  • wtf/OwnPtr.h:

(WTF::OwnPtr::OwnPtr):
(WTF::OwnPtr::isHashTableDeletedValue):
(WTF::OwnPtr::hashTableDeletedValue):
Add HashTableDeletedValue constructor/functions to allow the constructDeletedValue() and isDeletedValue()
hash traits to work.

(WTF::PtrHash<OwnPtr<P>>::hash):
(WTF::PtrHash<OwnPtr<P>>::equal):
Add specialization for PtrHash for OwnPtr and set it as the DefaultHash
for it as well.

  • wtf/Ref.h:

Update for the less verbose GetPtrHelper specialization.

Tools:

  • TestWebKitAPI/Tests/WTF/CopyMoveCounter.h: Removed.
  • TestWebKitAPI/Counters.cpp: Added.
  • TestWebKitAPI/Counters.h: Copied from Tools/TestWebKitAPI/Tests/WTF/CopyMoveCounter.h.

Move the CopyMoveCounter helper from CopyMoveCounter.h to Counters.h, and add a ConstructorDestructorCounter
helper to the mix as well. Add Counters.cpp to allow for the global variables to be used in more than one
translation unit.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:

Add new files.

  • TestWebKitAPI/Tests/WTF/HashMap.cpp:

Add tests for using std::unique_ptr and OwnPtr as the key's of a HashMap.

  • TestWebKitAPI/Tests/WTF/HashSet.cpp:

Add tests for using std::unique_ptr and OwnPtr as the values of a HashSet.

5:18 PM Changeset in webkit [173800] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Fix post-mortem nits for r173724
​https://bugs.webkit.org/show_bug.cgi?id=136986

Reviewed by Darin Adler.

Fix post-mortem nits for r173724.

No new tests, no behavior change.

  • editing/EditingStyle.cpp:

(WebCore::HTMLAttributeEquivalent::attributeValueAsCSSValue):
(WebCore::HTMLFontSizeEquivalent::attributeValueAsCSSValue):
Use nullptr instead of 0.

  • editing/SplitElementCommand.cpp:

(WebCore::SplitElementCommand::doUnapply):
Use getIdAttribute() / setIdAttribute().

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::computePreferredLogicalWidths):
Use fastHasAttribute() for nowrap and do an early return to avoid
calling styleOrColLogicalWidth() if the nowrap attribute is missing.

4:52 PM Changeset in webkit [173799] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Structure should have a method for concurrently getting all of the property map entries, and this method shouldn't involve copy-paste
​https://bugs.webkit.org/show_bug.cgi?id=136983

Reviewed by Mark Hahnenberg.

  • runtime/PropertyMapHashTable.h:

(JSC::PropertyMapEntry::PropertyMapEntry): Moved PropertyMapEntry struct to Structure.h so that Structure can refer to it.

  • runtime/Structure.cpp:

(JSC::Structure::getConcurrently): Switch to using the new forEachPropertyConcurrently() method.
(JSC::Structure::getPropertiesConcurrently): The subject of this patch. It will be useful for object allocation sinking (bug 136330).
(JSC::Structure::dump): Switch to using the new forEachPropertyConcurrently() method.

  • runtime/Structure.h:

(JSC::PropertyMapEntry::PropertyMapEntry): Moved from PropertyMapHashTable.h.

  • runtime/StructureInlines.h:

(JSC::Structure::forEachPropertyConcurrently): Capture this very common concurrent structure iteration pattern into a template method.

1:30 PM Changeset in webkit [173798] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

run-webkit-tests should count tests submitted as absolute paths once
​https://bugs.webkit.org/show_bug.cgi?id=136848

Patch by Youenn Fablet <​youenn.fablet@crf.canon.fr> on 2014-09-21
Reviewed by Darin Adler.

  • Scripts/webkitpy/port/base.py:

(Port._expanded_paths): In case of absolute path, do not search for platform specific tests.

12:18 PM Changeset in webkit [173797] by fpizlo@apple.com
  • 16 edits in trunk/Source/JavaScriptCore

Structure::getConcurrently() doesn't need to take a VM& argument.

Rubber stamped by Dan Bernstein.

Removed the extra argument, and then removed similar arguments from other methods until
I could build successfully again. It turned out that many methods took a VM& argument
just for calling getConcurrently().

  • bytecode/CodeBlock.cpp:

(JSC::dumpStructure):
(JSC::dumpChain):
(JSC::CodeBlock::printGetByIdCacheStatus):
(JSC::CodeBlock::printPutByIdCacheStatus):

  • bytecode/ComplexGetStatus.cpp:

(JSC::ComplexGetStatus::computeFor):

  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeForStubInfo):
(JSC::GetByIdStatus::computeFor):

  • bytecode/GetByIdStatus.h:
  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeForStubInfo):
(JSC::PutByIdStatus::computeFor):

  • bytecode/PutByIdStatus.h:
  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):

  • runtime/IntendedStructureChain.cpp:

(JSC::IntendedStructureChain::mayInterceptStoreTo):

  • runtime/IntendedStructureChain.h:
  • runtime/Structure.cpp:

(JSC::Structure::getConcurrently):

  • runtime/Structure.h:
  • runtime/StructureInlines.h:

(JSC::Structure::getConcurrently):

11:26 AM Changeset in webkit [173796] by fpizlo@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, speculative build fix.

If you use typed arrays, you gotta include runtime/TypedArrayInlines.h.

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:
Note: See TracTimeline for information about the timeline view.