Timeline
Sep 28, 2014:
- 8:42 PM Changeset in webkit [174052] by
-
- 13 edits1 add in trunk/Source
Replace wkGetGlyphsForCharacters() with CGFontGetGlyphsForUnichars()
https://bugs.webkit.org/show_bug.cgi?id=137197
Reviewed by Alexey Proskuryakov.
No new tests because there is no behavior change.
Source/WebCore:
- WebCore.exp.in:
- WebCore.order:
- WebCore.xcodeproj/project.pbxproj:
- platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
(WebCore::GlyphPage::fill): Use SPI call instead of WKSI call
- platform/mac/WebCoreSystemInterface.h:
- platform/mac/WebCoreSystemInterface.mm:
- platform/spi/cocoa/CGFontUnicodeSupport.h: Added for SPI call.
Source/WebKit:
- mac/WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- WebKit.order:
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):
- mac/WebKit2.order:
- 8:02 PM Changeset in webkit [174051] by
-
- 3 edits in trunk/Tools
Allow webkit-patch upload to respect the --directory argument with git checkouts
https://bugs.webkit.org/show_bug.cgi?id=137166
Reviewed by Darin Adler.
We simply hadn't plumbed it through.
- Scripts/webkitpy/common/checkout/scm/detection.py:
(SCMDetector.detect_scm_system):
- Scripts/webkitpy/common/checkout/scm/git.py:
(Git.init):
(Git.changed_files):
- 7:13 PM Changeset in webkit [174050] by
-
- 32 edits2 copies in trunk/Source/WebCore
Automatically generate template specializations for most Elements
https://bugs.webkit.org/show_bug.cgi?id=137174
Reviewed by Darin Adler.
Previously, the template specializations to make is<>() / downcast<>()
work for HTML/SVG/MathML elements were only generated if
"generateTypeHelpers" parameter was explicitly specified for the
corresponding tag name in the *Tags.in file.
We are however able to generate the template specializations for most
types so this patch drops the "generateTypeHelpers" parameter and
generates those template specializations by default.
One case we cannot generate the specialization ifor is when a class is
associated to several tag names but this patch updates the
make_names.pl script to detect this and skip those classes.
No new tests, no behavior change.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- dom/make_names.pl:
(defaultTagPropertyHash):
(printTypeHelpers):
- html/HTMLTagNames.in:
- mathml/mathtags.in:
- svg/SVGAllInOne.cpp:
- svg/SVGAnimateColorElement.cpp:
(WebCore::SVGAnimateColorElement::SVGAnimateColorElement):
(WebCore::SVGAnimateColorElement::determinePropertyValueTypes):
- svg/SVGAnimateColorElement.h:
- svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::SVGAnimateElement):
(WebCore::SVGAnimateElement::~SVGAnimateElement): Deleted.
(WebCore::SVGAnimateElement::hasValidAttributeType): Deleted.
(WebCore::SVGAnimateElement::determineAnimatedPropertyType): Deleted.
(WebCore::SVGAnimateElement::calculateAnimatedValue): Deleted.
(WebCore::SVGAnimateElement::calculateToAtEndOfDurationValue): Deleted.
(WebCore::SVGAnimateElement::calculateFromAndToValues): Deleted.
(WebCore::SVGAnimateElement::calculateFromAndByValues): Deleted.
(WebCore::propertyTypesAreConsistent): Deleted.
(WebCore::SVGAnimateElement::resetAnimatedType): Deleted.
(WebCore::applyCSSPropertyToTarget): Deleted.
(WebCore::removeCSSPropertyFromTarget): Deleted.
(WebCore::applyCSSPropertyToTargetAndInstances): Deleted.
(WebCore::removeCSSPropertyFromTargetAndInstances): Deleted.
(WebCore::notifyTargetAboutAnimValChange): Deleted.
(WebCore::notifyTargetAndInstancesAboutAnimValChange): Deleted.
(WebCore::SVGAnimateElement::clearAnimatedType): Deleted.
(WebCore::SVGAnimateElement::applyResultsToTarget): Deleted.
(WebCore::SVGAnimateElement::animatedPropertyTypeSupportsAddition): Deleted.
(WebCore::SVGAnimateElement::isAdditive): Deleted.
(WebCore::SVGAnimateElement::calculateDistance): Deleted.
(WebCore::SVGAnimateElement::setTargetElement): Deleted.
(WebCore::SVGAnimateElement::setAttributeName): Deleted.
(WebCore::SVGAnimateElement::resetAnimatedPropertyType): Deleted.
(WebCore::SVGAnimateElement::ensureAnimator): Deleted.
- svg/SVGAnimateElement.h:
(WebCore::isSVGAnimateElement): Deleted.
- svg/SVGAnimateElementBase.cpp: Copied from Source/WebCore/svg/SVGAnimateElement.cpp.
(WebCore::SVGAnimateElementBase::SVGAnimateElementBase):
(WebCore::SVGAnimateElementBase::~SVGAnimateElementBase):
(WebCore::SVGAnimateElementBase::hasValidAttributeType):
(WebCore::SVGAnimateElementBase::determineAnimatedPropertyType):
(WebCore::SVGAnimateElementBase::calculateAnimatedValue):
(WebCore::SVGAnimateElementBase::calculateToAtEndOfDurationValue):
(WebCore::SVGAnimateElementBase::calculateFromAndToValues):
(WebCore::SVGAnimateElementBase::calculateFromAndByValues):
(WebCore::propertyTypesAreConsistent):
(WebCore::SVGAnimateElementBase::resetAnimatedType):
(WebCore::applyCSSPropertyToTarget):
(WebCore::removeCSSPropertyFromTarget):
(WebCore::applyCSSPropertyToTargetAndInstances):
(WebCore::removeCSSPropertyFromTargetAndInstances):
(WebCore::notifyTargetAboutAnimValChange):
(WebCore::notifyTargetAndInstancesAboutAnimValChange):
(WebCore::SVGAnimateElementBase::clearAnimatedType):
(WebCore::SVGAnimateElementBase::applyResultsToTarget):
(WebCore::SVGAnimateElementBase::animatedPropertyTypeSupportsAddition):
(WebCore::SVGAnimateElementBase::isAdditive):
(WebCore::SVGAnimateElementBase::calculateDistance):
(WebCore::SVGAnimateElementBase::setTargetElement):
(WebCore::SVGAnimateElementBase::setAttributeName):
(WebCore::SVGAnimateElementBase::resetAnimatedPropertyType):
(WebCore::SVGAnimateElementBase::ensureAnimator):
- svg/SVGAnimateElementBase.h: Copied from Source/WebCore/svg/SVGAnimateElement.h.
(WebCore::isSVGAnimateElementBase):
- svg/SVGAnimateTransformElement.cpp:
(WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
(WebCore::SVGAnimateTransformElement::parseAttribute):
- svg/SVGAnimateTransformElement.h:
- svg/SVGAnimatedAngle.cpp:
- svg/SVGAnimatedBoolean.cpp:
- svg/SVGAnimatedColor.cpp:
- svg/SVGAnimatedInteger.cpp:
- svg/SVGAnimatedIntegerOptionalInteger.cpp:
- svg/SVGAnimatedLength.cpp:
- svg/SVGAnimatedLengthList.cpp:
- svg/SVGAnimatedNumber.cpp:
- svg/SVGAnimatedNumberList.cpp:
- svg/SVGAnimatedNumberOptionalNumber.cpp:
- svg/SVGAnimatedPath.cpp:
- svg/SVGAnimatedPointList.cpp:
- svg/SVGAnimatedPreserveAspectRatio.cpp:
- svg/SVGAnimatedRect.cpp:
- svg/SVGAnimatedString.cpp:
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
- svg/SVGSetElement.cpp:
(WebCore::SVGSetElement::SVGSetElement):
- svg/SVGSetElement.h:
- svg/svgtags.in:
- 6:52 PM Changeset in webkit [174049] by
-
- 7 edits3 adds in trunk
Simple ES6 feature: Number constructor extras
https://bugs.webkit.org/show_bug.cgi?id=131707
Patch by Diego Pino Garcia <Diego Pino Garcia> on 2014-09-28
Reviewed by Darin Adler.
Source/JavaScriptCore:
- runtime/CommonIdentifiers.h:
- runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::finishCreation): Setup constants and
functions.
(JSC::numberConstructorFuncIsFinite): Added.
(JSC::numberConstructorFuncIsInteger): Added.
(JSC::numberConstructorFuncIsNaN): Added.
(JSC::numberConstructorFuncIsSafeInteger): Added.
(JSC::NumberConstructor::getOwnPropertySlot): Deleted.
(JSC::numberConstructorNaNValue): Deleted.
(JSC::numberConstructorNegInfinity): Deleted.
(JSC::numberConstructorPosInfinity): Deleted.
(JSC::numberConstructorMaxValue): Deleted.
(JSC::numberConstructorMinValue): Deleted.
- runtime/NumberConstructor.h:
LayoutTests:
- js/Object-getOwnPropertyNames-expected.txt:
- js/number-constructor-expected.txt: Added.
- js/number-constructor.html: Added.
- js/script-tests/Object-getOwnPropertyNames.js:
- js/script-tests/number-constructor.js: Added.
- 6:18 PM Changeset in webkit [174048] by
-
- 12 edits in trunk/Source
Use std::unique_ptr for ContextMenuController
https://bugs.webkit.org/show_bug.cgi?id=137178
Reviewed by Darin Adler.
Switch to using std::unique_ptr instead of OwnPtr and PassOwnPtr
for ContextMenuController class. Inherited class is changed by this use as well.
Source/WebCore:
No new tests, no behavior changes.
- loader/EmptyClients.cpp:
(WebCore::EmptyContextMenuClient::customizeMenu):
- loader/EmptyClients.h:
- page/ContextMenuClient.h:
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::clearContextMenu):
(WebCore::ContextMenuController::maybeCreateContextMenu):
(WebCore::ContextMenuController::showContextMenu):
- page/ContextMenuController.h:
Source/WebKit/win:
- WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::customizeMenu):
- WebCoreSupport/WebContextMenuClient.h:
Source/WebKit2:
- WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::customizeMenu):
- WebProcess/WebCoreSupport/WebContextMenuClient.h:
- 6:04 PM Changeset in webkit [174047] by
-
- 14 edits in trunk/Source
Move ColorInputType class to std::unique_ptr
https://bugs.webkit.org/show_bug.cgi?id=137173
Reviewed by Darin Adler.
Replace uses of PassOwnPtr in code under ColorInputType class with std::unique_ptr.
Child classes follow this change as well.
Source/WebCore:
No new tests, no behavior changes.
- html/ColorInputType.cpp:
(WebCore::ColorInputType::didEndChooser):
- html/ColorInputType.h:
- loader/EmptyClients.cpp:
(WebCore::EmptyChromeClient::createColorChooser):
- loader/EmptyClients.h:
- page/Chrome.cpp:
(WebCore::Chrome::createColorChooser):
- page/Chrome.h:
- page/ChromeClient.h:
Source/WebKit/mac:
- WebCoreSupport/WebChromeClient.h:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::createColorChooser):
Source/WebKit2:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createColorChooser):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- 4:18 PM Changeset in webkit [174046] by
-
- 16 edits in trunk
Fix some minor typos: psuedo -> pseudo
https://bugs.webkit.org/show_bug.cgi?id=137192
Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2014-09-28
Reviewed by Alexey Proskuryakov.
PerformanceTests:
- Speedometer/resources/todomvc/architecture-examples/emberjs/bower_components/handlebars/handlebars.js:
Source/WebCore:
No new tests, no behavior change.
- css/CSSSelector.cpp:
(WebCore::CSSSelector::specificityForOneSelector):
LayoutTests:
- fast/dom/Window/getMatchedCSSRules-with-invalid-pseudo-elements-expected.txt:
- fast/dom/Window/getMatchedCSSRules-with-invalid-pseudo-elements.html:
- fast/dom/Window/getMatchedCSSRules-with-pseudo-elements-expected.txt:
- fast/dom/Window/getMatchedCSSRules-with-pseudo-elements.html:
- fast/selectors/159.html:
- fast/selectors/160.html:
- fast/selectors/166.html:
- platform/efl/fast/selectors/166-expected.txt:
- platform/gtk/fast/selectors/166-expected.txt:
- platform/ios-sim/fast/selectors/166-expected.txt:
- platform/mac/fast/selectors/166-expected.txt:
- 1:59 PM Changeset in webkit [174045] by
-
- 17 edits1 move1 delete in trunk
Replace OSObjectPtr with RetainPtr/adoptOS
https://bugs.webkit.org/show_bug.cgi?id=137158
Reviewed by Dan Bernstein.
Source/WebKit2:
- DatabaseProcess/EntryPoint/mac/XPCService/DatabaseServiceEntryPoint.mm:
(DatabaseServiceInitializer):
- NetworkProcess/EntryPoint/mac/XPCService/NetworkServiceEntryPoint.mm:
(WebKit::NetworkServiceInitializerDelegate::NetworkServiceInitializerDelegate):
(NetworkServiceInitializer):
- Platform/IPC/Connection.h:
(IPC::Connection::Identifier::Identifier):
- Platform/IPC/mac/ConnectionMac.mm:
(IPC::ConnectionTerminationWatchdog::createConnectionTerminationWatchdog):
(IPC::ConnectionTerminationWatchdog::ConnectionTerminationWatchdog):
- PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:
(WebKit::PluginServiceInitializerDelegate::PluginServiceInitializerDelegate):
(PluginServiceInitializer):
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializerDelegate::XPCServiceInitializerDelegate):
(WebKit::XPCServiceInitializer):
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:
(WebKit::XPCServiceInitializerDelegate::checkEntitlements):
(WebKit::XPCServiceInitializerDelegate::hasEntitlement):
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
(WebKit::XPCServiceEventHandler):
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceEventHandler):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToService):
(WebKit::connectToReExecService):
- WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
(WebContentServiceInitializer):
Source/WTF:
- WTF.xcodeproj/project.pbxproj:
- wtf/OSObjectPtr.h: Removed.
- wtf/RetainPtr.h:
(WTF::adoptOS):
Added. This adopt function is slightly different than both adoptCF and adoptNS,
in that unlike adoptCF(), it can be passed an Objective-C type (since OS objects
are sometimes Objective-C objects, but not always), and unlike adoptNS() it doesn't
require us to jump through hoops to appease GC (since OS objects are not Objective-C
objects if GC is enabled).
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp: Removed.
- TestWebKitAPI/Tests/WTF/darwin/RetainPtrOSObject.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/darwin/OSObjectPtr.cpp.
Rename and change test to use RetainPtr. Remove now unneeded part testing WTF::retainOSObject/WTF::releaseOSObject.
- 7:07 AM WebKitGTK/2.6.x edited by
- (diff)
- 1:23 AM Changeset in webkit [174044] by
-
- 1 edit1 move in trunk/Source/WebCore
Unreviewed. Move RenderThemeGtk.h from platform/gtk to rendering.
I forgot to move this file in r173111.
- rendering/RenderThemeGtk.h: Renamed from Source/WebCore/platform/gtk/RenderThemeGtk.h.
- 1:18 AM Changeset in webkit [174043] by
-
- 4 edits in trunk/Source/WebCore
[ATK] WebKitAccessibleWrapperAtk should not depend on GTK
https://bugs.webkit.org/show_bug.cgi?id=137177
Reviewed by Martin Robinson.
It's used to get the web view widget, but there's no GtkWidget in
the web process and platformPageClient is always NULL.
- PlatformGTK.cmake: Move accessibility sources to the WebCore
sources list.
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(atkParentOfRootObject): Remove code to get view GtkWidget.
- editing/atk/FrameSelectionAtk.cpp: Remove unneeded header include.
- 1:14 AM Changeset in webkit [174042] by
-
- 2 edits2 deletes in trunk/Source/WebCore
[GTK] Remove unused GtkPluginWidget
https://bugs.webkit.org/show_bug.cgi?id=137176
Reviewed by Csaba Osztrogonác.
It was only used by WebKit1.
- PlatformGTK.cmake:
- platform/gtk/GtkPluginWidget.cpp: Removed.
- platform/gtk/GtkPluginWidget.h: Removed.
- 1:06 AM Changeset in webkit [174041] by
-
- 5 edits in trunk/Source/WebCore
[cairo] GraphicsContext should not depend on GTK+
https://bugs.webkit.org/show_bug.cgi?id=137175
Reviewed by Martin Robinson.
Remove the unused methods depending on GDK and simplify
GraphicsContext::drawFocusRing() using only cairo API.
- PlatformGTK.cmake: Move GraphicsContextCairo.cpp to the webcore sources.
- platform/graphics/GraphicsContext.h:
- platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawFocusRing): Iterate the rectangles
instead of creating a region for the rectangles and call gdk_cairo_region().
(WebCore::GraphicsContext::setGdkExposeEvent): Deleted.
(WebCore::GraphicsContext::gdkExposeEvent): Deleted.
(WebCore::GraphicsContext::gdkWindow): Deleted.
- platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
Sep 27, 2014:
- 10:57 PM Changeset in webkit [174040] by
-
- 11 edits in trunk/Source/WebCore
HTMLPlugInElement::isUserObservable() is causing layout
https://bugs.webkit.org/show_bug.cgi?id=137156
Reviewed by Ryosuke Niwa.
While profiling the page load of nytimes.com, I noticed that we were
spending ~4-5% of cpu time in HTMLPlugInElement::isUserObservable().
The reason is that the function calls pluginWidget(), which causes a
layout update in HTMLObjectElement::renderWidgetForJSBindings(), to
make sure the plugin is loaded and its renderer is created.
HTMLPlugInElement::isUserObservable() shouldn't need to do a layout.
This patch does the following to address the problem:
- Rename renderWidgetForJSBindings() to renderWidgetLoadingPlugin() because this function is not always called from the JS Bindings nowadays. The new name makes it clearer that this will load the plugin if needed (to make sure the renderer is created, and by doing a layout).
- Add a PluginLoadingPolicy argument to HTMLPlugInElement::pluginWidget() to let the caller control if the plugin should be loaded or not.
- Update the call to pluginWidget() in isUserObservable() so that we do not attempt to load the plugin (thus not causing a layout).
No new tests, no behavior change.
- WebCore.exp.in:
- WebCore.order:
- html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::renderWidgetLoadingPlugin):
(WebCore::HTMLAppletElement::renderWidgetForJSBindings): Deleted.
- html/HTMLAppletElement.h:
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::renderWidgetLoadingPlugin):
(WebCore::HTMLEmbedElement::renderWidgetForJSBindings): Deleted.
- html/HTMLEmbedElement.h:
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::renderWidgetLoadingPlugin):
(WebCore::HTMLObjectElement::renderWidgetForJSBindings): Deleted.
- html/HTMLObjectElement.h:
- html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::pluginWidget):
(WebCore::HTMLPlugInElement::isUserObservable):
- html/HTMLPlugInElement.h:
- 10:21 PM Changeset in webkit [174039] by
-
- 22 edits in trunk/Source/WebCore
Use the new is<>() / downcast<>() for more Node subclasses
https://bugs.webkit.org/show_bug.cgi?id=137184
Reviewed by Ryosuke Niwa.
Use the new is<>() / downcast<>() for more Node subclasses:
CDATASection, CharacterData, Comment, DocumentType,
ProcessingInstruction, and PseudoElement.
No new tests, no behavior change.
- dom/CDATASection.h:
(WebCore::isCDATASection):
- dom/CharacterData.cpp:
(WebCore::CharacterData::setDataAndUpdate):
- dom/CharacterData.h:
(WebCore::isCharacterData):
- dom/Comment.h:
(WebCore::isComment):
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
- dom/DocumentType.h:
(WebCore::isDocumentType):
- dom/EventDispatcher.cpp:
(WebCore::eventTargetRespectingTargetRules):
(WebCore::nodeOrHostIfPseudoElement):
- dom/Node.cpp:
(WebCore::markAncestorsWithChildNeedsStyleRecalc):
(WebCore::Node::pseudoAwarePreviousSibling):
(WebCore::Node::pseudoAwareNextSibling):
- dom/NodeTraversal.cpp:
(WebCore::NodeTraversal::previousIncludingPseudo):
(WebCore::NodeTraversal::nextIncludingPseudo):
(WebCore::NodeTraversal::nextIncludingPseudoSkippingChildren):
- dom/ProcessingInstruction.h:
(WebCore::isProcessingInstruction):
- dom/PseudoElement.h:
(WebCore::isPseudoElement):
- dom/Range.cpp:
(WebCore::lengthOfContentsInNode):
(WebCore::Range::processContentsBetweenOffsets):
(WebCore::Range::checkNodeWOffset):
- editing/Editor.cpp:
(WebCore::Editor::shouldInsertFragment):
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::appendStartMarkup):
- editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_traverseNode):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForNode):
- inspector/InspectorLayerTreeAgent.cpp:
(WebCore::InspectorLayerTreeAgent::buildObjectForLayer):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::setInnerNode):
(WebCore::HitTestResult::setInnerNonSharedNode):
- rendering/RenderListItem.cpp:
(WebCore::enclosingList):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::generatingPseudoHostElement):
- xml/XPathFunctions.cpp:
(WebCore::XPath::expandedNameLocalPart):
- 9:13 PM Changeset in webkit [174038] by
-
- 8 edits in trunk/Source/WebCore
Use the new is<>() / downcast<>() for Attr Nodes
https://bugs.webkit.org/show_bug.cgi?id=137183
Reviewed by Ryosuke Niwa.
Use the new is<>() / downcast<>() for Attr Nodes instead of isAttr() /
toAttr().
No new tests, no behavior change.
- dom/Attr.h:
(WebCore::isAttr):
- dom/Document.cpp:
(WebCore::Document::importNode):
(WebCore::Document::adoptNode):
- dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::setNamedItem):
- dom/Node.cpp:
(WebCore::Node::compareDocumentPosition):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForNode):
- inspector/InspectorNodeFinder.cpp:
(WebCore::InspectorNodeFinder::searchUsingXPath):
- xml/XPathNodeSet.cpp:
(WebCore::XPath::sortBlock):
(WebCore::XPath::NodeSet::sort):
(WebCore::XPath::findRootNode):
- 3:17 PM Changeset in webkit [174037] by
-
- 5 edits in trunk/Source
Web Replay: Playback position updates should be sent before the next event loop input is dispatched
https://bugs.webkit.org/show_bug.cgi?id=137162
Reviewed by Timothy Hatcher.
Source/WebCore:
To drive playback position updates in the Inspector UI, we send playbackHitPosition protocol
messages as the replay backend dispatches inputs. However, right now the semantics of that
message are muddy. The update is sent *after* the input at the offset is dispatched. This leads
to unexpected results if the debugger pauses while the input is being dispatched: the frontend
will only know about the previous (stale) playback position when the debugger pauses.
With this patch, the backend sends the playbackHitPosition(segmentOffset=n, inputOffset=m)
message when backend is about to dispatch input m, but has not yet begun to do so. Thus, any
subsequent page execution events (profiling, debugger pauses, etc) until the next
playbackHitPosition are caused by input m's being dispatched.
- inspector/protocol/Replay.json: Clarify the message's semantics.
- replay/ReplayController.cpp:
(WebCore::ReplayController::willDispatchInput):
(WebCore::ReplayController::didDispatchInput):
Source/WebInspectorUI:
Pausing playback from the UI was broken because of a typo. Fix this, and rename
stopPlayback to cancelPlayback.
- UserInterface/Controllers/ReplayManager.js:
(WebInspector.ReplayManager.prototype.switchSession.if):
- 1:27 PM Changeset in webkit [174036] by
-
- 8 edits1 add in trunk
Disable function.arguments
https://bugs.webkit.org/show_bug.cgi?id=137167
Source/JavaScriptCore:
Rubber stamped by Geoffrey Garen.
Add an option to disable function.arguments. Add a test for disabling it.
Disabling function.arguments means that it returns an Arguments object that claims that
there were zero arguments. All other Arguments functionality still works, so any code
that tries to inspect this object will still think that it is looking at a perfectly
valid Arguments object.
This also makes function.arguments disabled by default. Note that the RJST harness will
enable them by default, to continue to get test coverage for the code that implements
the feature.
We will rip out that code once we're confident that it's really safe to remove this
feature. Only once we rip out that support will we be able to do optimizations to
leverage the lack of this feature. It's important to keep the support code, and the test
infrastructure, in place before we are confident. The logic to keep this working touches
the entire compiler and a large chunk of the runtime, so reimplementing it - or even
merging it back in - would be a nightmare. That's also basically the reason why we want
to rip it out if at all possible. It's a lot of terrible code.
- interpreter/StackVisitor.cpp:
(JSC::StackVisitor::Frame::createArguments):
- runtime/Arguments.h:
(JSC::Arguments::create):
(JSC::Arguments::finishCreation):
- runtime/Options.h:
- tests/stress/disable-function-dot-arguments.js: Added.
(foo):
(bar):
Tools:
Rubber stamped by Geoffrey Garen
Enable the feature by default during tests.
- Scripts/run-jsc-stress-tests:
LayoutTests:
Rubber stamped by Geoffrey Garen.
Don't remove the tests for this, yet - but mark them as failing. We will rebase these,
or remove them entirely, once we know that it's safe to rip out this feature entirely.
- 11:49 AM Changeset in webkit [174035] by
-
- 3 edits8 adds in trunk
Chaining multiple :nth-child() does not work properly
https://bugs.webkit.org/show_bug.cgi?id=137032
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-09-27
Reviewed by Gavin Barraclough.
Source/WebCore:
When multiple :nth-child() are chained, the evaluation of each "An+B" could depend on
the execution of the previous "An+B". The reason is that the register holding the position
of the current element could be modified by the evaluation of "An+B".
There are two cases in which the register was used as the destination of an operation:
1) When A and B are positive, the counter would be the destination of "counter - B".
2) When A is not 1 or 2, the modulo operation was not preserving the input register.
For (1), we a copy of the counter in that case of generateElementIsNthChild().
For (2), we also preserve a copy of the input if it is used by the operation. In this case,
if the input register is one of the argument we need for idiv, we preserve it on the stack
or in a register depending on what is available.
This increases the register requirements by 2 in the worst case on x86. The extra registers
can push generateElementIsNthChild() above the 4 available registers. To accomodate for that,
minimumRegisterRequirements() reserve more registers on x86.
The extra register pressure has strictly no effect on performance, x86_64 has 9 registers
available without pushing anything. The extra allocation is only necessary for debugging.
Tests: fast/selectors/nth-child-basics.html
fast/selectors/nth-child-chained.html
fast/selectors/nth-child-of-basics-2.html
fast/selectors/nth-child-of-chained.html
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::minimumRegisterRequirements):
(WebCore::SelectorCompiler::SelectorCodeGenerator::modulo):
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
LayoutTests:
- fast/selectors/nth-child-chained-expected.txt: Added.
- fast/selectors/nth-child-chained.html: Added.
- fast/selectors/nth-child-of-chained-expected.txt: Added.
- fast/selectors/nth-child-of-chained.html: Added.
Those new tests target specifically the register reuse bug fixed by the patch.
- fast/selectors/nth-child-basics-expected.txt: Added.
- fast/selectors/nth-child-basics.html: Added.
- fast/selectors/nth-child-of-basics-2-expected.txt: Added.
- fast/selectors/nth-child-of-basics-2.html: Added.
Those tests add coverage for the examples used by http://nthmaster.com. This is to increase
the general test coverage.
I added nth-child-of-basics-2.html instead of extending nth-child-of-basics.html because
of the speed issue in debug without CSS JIT (otherwise the test can timeout).
- 12:13 AM Changeset in webkit [174034] by
-
- 5 edits in trunk
WebKit top of tree sources won't build in 10.9 w/ Xcode 6.0.1
https://bugs.webkit.org/show_bug.cgi?id=137053
Reviewed by Mark Rowe.
.:
- WebKit.xcworkspace/xcshareddata/xcschemes/All Source (target WebProcess).xcscheme:
In the build pre-action, pass the --wksi and --llvm options to
copy-webkitlibraries-to-product-directory.
- WebKit.xcworkspace/xcshareddata/xcschemes/All Source.xcscheme: Ditto.
Websites/webkit.org:
- building/build.html: Removed instructions how to work around this bug, now that it’s fixed.
Sep 26, 2014:
- 10:18 PM Changeset in webkit [174033] by
-
- 2 edits in trunk/Websites/webkit.org
WebKit top of tree sources won't build in 10.9 w/ Xcode 6.0.1
https://bugs.webkit.org/show_bug.cgi?id=137053
Patch by David Gatwood. Reviewed, tweaked and landed by Alexey Proskuryakov.
Explain that to build from Xcode, one needs to build from command line once first.
Removed a Windows section that explained how to launch cygwin shell, which was
silly given that we then link to a long document explaining further steps.
- building/build.html:
- 8:52 PM Changeset in webkit [174032] by
-
- 2 edits in trunk/LayoutTests
Mark fast/selectors/nth-child-of-basics as Slow
https://bugs.webkit.org/show_bug.cgi?id=137149
Reviewed by Benjamin Poulain.
Since there are many tests in fast/selectors/nth-child-of-basics,
it takes long time and sometime LayoutTests timeout[1].
[1]: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20(Tests)/builds/3042
Mark fast/selectors/nth-child-of-basics as Slow.
- 6:32 PM Changeset in webkit [174031] by
-
- 97 edits in trunk/Source
Stop using legacy NODE_TYPE_CASTS() macro for HTML Elements
https://bugs.webkit.org/show_bug.cgi?id=137137
Reviewed by Benjamin Poulain.
Source/WebCore:
Stop using legacy NODE_TYPE_CASTS() macro for HTML Elements and use the
new SPECIALIZE_TYPE_TRAITS_*() macro instead so that is<>() /
downcast<>() works for those types.
No new tests, no behavior change.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::labelForElement):
(WebCore::AccessibilityNodeObject::text):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::isDataTable):
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetName):
(webkitAccessibleGetDescription):
- bindings/gobject/WebKitDOMPrivate.cpp:
(WebKit::wrap):
- bindings/js/JSElementCustom.cpp:
(WebCore::toJSNewlyCreated):
- bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
- bindings/js/JSPluginElementFunctions.cpp:
(WebCore::pluginInstance):
(WebCore::pluginScriptObjectFromPluginViewBase):
(WebCore::pluginScriptObject):
(WebCore::pluginElementCustomPut):
(WebCore::isPluginElement): Deleted.
- bindings/objc/DOM.mm:
(kitClass):
- css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::matchAllRules):
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::locateCousinList):
(WebCore::elementHasDirectionAuto):
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::makeContextStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::makeElementStyleUniqueIfNecessaryAndTestIsPlaceholderShown):
(WebCore::SelectorCompiler::isPlaceholderShown):
- dom/ContainerNodeAlgorithms.cpp:
(WebCore::assertConnectedSubrameCountIsConsistent):
(WebCore::collectFrameOwners):
(WebCore::disconnectSubframes):
- dom/Document.cpp:
(WebCore::Document::adoptNode):
(WebCore::Document::setBody):
(WebCore::Document::iconURLs):
(WebCore::Document::dispatchFullScreenChangeOrErrorEvent):
(WebCore::Document::updateHoverActiveState):
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
- dom/Range.cpp:
(WebCore::Range::createContextualFragment):
- dom/make_names.pl:
(printTypeHelpers):
- editing/ApplyStyleCommand.cpp:
(WebCore::isLegacyAppleStyleSpan):
(WebCore::isStyleSpanOrSpanWithOnlyStyleAttribute):
(WebCore::isSpanWithoutAttributesOrUnstyledStyleSpan):
(WebCore::isEmptyFontTag):
(WebCore::ApplyStyleCommand::applyBlockStyle):
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi):
(WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange):
(WebCore::ApplyStyleCommand::removeConflictingInlineStyleFromRun):
(WebCore::ApplyStyleCommand::highestAncestorWithConflictingInlineStyle):
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):
(WebCore::ApplyStyleCommand::removeInlineStyle):
(WebCore::ApplyStyleCommand::shouldSplitTextElement):
(WebCore::ApplyStyleCommand::applyInlineStyleChange):
- editing/DeleteButtonController.cpp:
(WebCore::enclosingDeletableElement):
- editing/Editor.cpp:
(WebCore::Editor::selectionForCommand):
(WebCore::Editor::setBaseWritingDirection):
(WebCore::findFirstMarkable):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::selectAll):
(WebCore::scanForForm):
- editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::mergeWithNeighboringLists):
- editing/MarkupAccumulator.cpp:
(WebCore::MarkupAccumulator::elementCannotHaveEndTag):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::ReplaceSelectionCommand::makeInsertedContentRoundTrippableWithHTMLTreeBuilder):
(WebCore::ReplaceSelectionCommand::handleStyleSpans):
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::insertAsListItems):
- editing/TextIterator.cpp:
(WebCore::shouldEmitNewlinesBeforeAndAfterNode):
(WebCore::shouldEmitExtraNewlineForNode):
- editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_addTableCellForElement):
(HTMLConverter::_processElement):
- editing/htmlediting.cpp:
(WebCore::enclosingList):
(WebCore::embeddedSublist):
(WebCore::appendedSublist):
- editing/ios/EditorIOS.mm:
(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):
- editing/mac/EditorMac.mm:
(WebCore::maybeCopyNodeAttributesToFragment):
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendElement):
- html/BaseChooserOnlyDateAndTimeInputType.cpp:
(WebCore::BaseChooserOnlyDateAndTimeInputType::updateAppearance):
- html/ColorInputType.cpp:
(WebCore::ColorInputType::shadowColorSwatch):
- html/HTMLBodyElement.cpp:
(WebCore::HTMLBodyElement::insertedInto):
- html/HTMLCollection.cpp:
(WebCore::HTMLCollection::namedItem):
(WebCore::HTMLCollection::updateNamedElementCache):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::matchesReadWritePseudoClass):
(WebCore::HTMLElement::setOuterHTML):
(WebCore::elementAffectsDirectionality):
(WebCore::HTMLElement::directionality):
(WebCore::HTMLElement::dirAttributeChanged):
- html/HTMLElement.h:
(WebCore::isHTMLElement):
(WebCore::Node::hasTagName):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::getNamedElements):
- html/HTMLFrameElementBase.h:
(WebCore::isHTMLFrameElementBase):
- html/HTMLFrameOwnerElement.h:
(WebCore::isHTMLFrameOwnerElement):
- html/HTMLMediaElement.h:
(WebCore::isHTMLMediaElement):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::isDisabledFormControl):
- html/HTMLPlugInElement.h:
(WebCore::isHTMLPlugInElement):
- html/HTMLPlugInImageElement.cpp:
(WebCore::addPlugInsFromNodeListMatchingPlugInOrigin):
- html/HTMLPlugInImageElement.h:
(WebCore::isHTMLPlugInImageElement):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setOption):
(WebCore::HTMLSelectElement::setLength):
(WebCore::HTMLSelectElement::recalcListItems):
- html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::insertedInto):
(WebCore::HTMLSourceElement::removedFrom):
- html/HTMLTableCellElement.cpp:
(WebCore::HTMLTableCellElement::cellAbove):
- html/HTMLTableCellElement.h:
(WebCore::isHTMLTableCellElement):
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::tHead):
(WebCore::HTMLTableElement::tFoot):
(WebCore::HTMLTableElement::lastBody):
- html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::rowIndex):
- html/HTMLTableRowsCollection.cpp:
(WebCore::isInSection):
- html/HTMLTableSectionElement.h:
(WebCore::isHTMLTableSectionElement):
- html/HTMLTagNames.in:
- html/HTMLTextFormControlElement.cpp:
(WebCore::enclosingTextFormControl):
- html/HTMLTextFormControlElement.h:
(WebCore::isHTMLTextFormControlElement):
- html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::removedFrom):
(WebCore::HTMLTrackElement::mediaElement):
- html/LabelableElement.h:
(WebCore::isLabelableElement):
- html/RangeInputType.cpp:
(WebCore::RangeInputType::sliderTrackElement):
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::parentMediaElement):
(WebCore::mediaControlElementType):
- html/shadow/TextControlInnerElements.h:
(WebCore::isTextControlInnerTextElement):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForNode):
- inspector/InspectorNodeFinder.cpp:
(WebCore::InspectorNodeFinder::searchUsingDOMTreeTraversal):
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::loadSubframe):
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
- mathml/MathMLElement.cpp:
(WebCore::MathMLElement::isPhrasingContent):
(WebCore::MathMLElement::isFlowContent):
(WebCore::MathMLElement::childShouldCreateRenderer):
- mathml/mathtags.in:
- page/DragController.cpp:
(WebCore::DragController::canProcessDrag):
- page/EventHandler.cpp:
(WebCore::targetIsFrame):
- page/FocusController.cpp:
(WebCore::hasCustomFocusLogic):
(WebCore::FocusController::findFocusableElementDescendingDownIntoFrameDocument):
(WebCore::FocusController::advanceFocusInDocumentOrder):
- page/Frame.cpp:
(WebCore::Frame::searchForLabelsBeforeElement):
- page/FrameView.cpp:
(WebCore::FrameView::init):
(WebCore::FrameView::addEmbeddedObjectToUpdate):
(WebCore::FrameView::updateEmbeddedObject):
- page/PageSerializer.cpp:
(WebCore::isCharsetSpecifyingNode):
(WebCore::SerializerMarkupAccumulator::appendCustomAttributes):
- page/SpatialNavigation.cpp:
(WebCore::frameOwnerElement):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::absolutePDFURL):
(WebCore::HitTestResult::mediaElement):
- rendering/RenderBlockFlow.cpp:
(WebCore::resizeTextPermitted):
- rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::paintContents):
(WebCore::RenderEmbeddedObject::layout):
(WebCore::RenderEmbeddedObject::handleUnavailablePluginIndicatorEvent):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
(WebCore::RenderLayer::updateSnapOffsets):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateConfiguration):
(WebCore::isRestartedPlugin):
- rendering/RenderMedia.h:
(WebCore::RenderMedia::mediaElement):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::offsetParent):
- rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::plugInImageElement):
- rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::parseColSpanFromDOM):
(WebCore::RenderTableCell::parseRowSpanFromDOM):
- rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::textFormControlElement):
- rendering/RenderThemeGtk.cpp:
(WebCore::getMediaElementFromRenderObject):
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):
- rendering/RenderTreeAsText.cpp:
(WebCore::isEmptyOrUnstyledAppleStyleSpan):
- rendering/RenderWidget.h:
(WebCore::RenderWidget::frameOwnerElement):
- testing/Internals.cpp:
(WebCore::Internals::visiblePlaceholder):
(WebCore::Internals::simulateAudioInterruption):
(WebCore::Internals::isPluginSnapshotted):
- xml/XPathStep.cpp:
(WebCore::XPath::nodeMatchesBasicTest):
Source/WebKit/win:
Use is<>() / downcast<>() where appropriate.
- DOMHTMLClasses.cpp:
(DOMHTMLElement::idName):
(DOMHTMLElement::innerText):
(DOMHTMLElement::setInnerText):
Source/WebKit2:
Use is<>() / downcast<>() where appropriate.
- WebProcess/Plugins/PDF/PDFPluginTextAnnotation.mm:
(WebKit::PDFPluginTextAnnotation::value):
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::initializePlugin):
(WebKit::PluginView::pluginSnapshotTimerFired):
(WebKit::PluginView::pluginDidReceiveUserInteraction):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::performActionOnElement):
- 4:55 PM Changeset in webkit [174030] by
-
- 2 edits in trunk/LayoutTests
[Win] Unreviewed. More gardening on Windows tests.
- platform/win/TestExpectations:
Enable some css3 conditional tests that are now passing.
Disable some failing hidpi tests since we don’t have hidpi test support on Windows.
- 4:38 PM Changeset in webkit [174029] by
-
- 5 edits in trunk/Source/WebKit2
Add API for loading local files
https://bugs.webkit.org/show_bug.cgi?id=137153
rdar://problem/17761459
Reviewed by Oliver Hunt.
- UIProcess/API/Cocoa/WKWebView.h:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView loadFileURL:allowingReadAccessToURL:]):
Load the file, wrapping the navigation ID in a WKNavigation using createLoadRequestNavigation.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadFile):
- UIProcess/WebPageProxy.h:
Return the navigation ID (or 0 if the navigation failed).
- 4:25 PM Changeset in webkit [174028] by
-
- 19 edits in trunk/Source
Web Inspector: Automatic Inspection should continue once all breakpoints are loaded
https://bugs.webkit.org/show_bug.cgi?id=137038
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2014-09-26
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
Add a new protocol command "Inspector.initialized" that signifies to the backend
when the frontend has sent all its initialization messages to the backend. This
can include information like breakpoints, which we would want to have loaded
before any JavaScript evaluates in the context.
- inspector/protocol/InspectorDomain.json:
New protocol command, Inspector.initialized.
- inspector/agents/InspectorAgent.h:
- inspector/agents/InspectorAgent.cpp:
(Inspector::InspectorAgent::InspectorAgent):
(Inspector::InspectorAgent::initialized):
Tell the InspectorEnvironment (the Controller) the frontend has initialized.
- inspector/InspectorEnvironment.h:
Abstract virtual method to handle frontend initialization. To be
implemented by all of the InspectorControllers.
- inspector/JSGlobalObjectInspectorController.h:
- inspector/JSGlobalObjectInspectorController.cpp:
(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::connectFrontend):
(Inspector::JSGlobalObjectInspectorController::disconnectFrontend):
(Inspector::JSGlobalObjectInspectorController::frontendInitialized):
When a frontend is initialized, if it was automatic inspection unpause the debuggable.
- inspector/remote/RemoteInspectorDebuggable.cpp:
(Inspector::RemoteInspectorDebuggable::unpauseForInitializedInspector):
Complete setup for this debuggable.
- inspector/remote/RemoteInspectorDebuggable.h:
- inspector/remote/RemoteInspectorDebuggableConnection.mm:
(Inspector::RemoteInspectorDebuggableConnection::setup):
Move the setup complete to later, when the frontend sends an "initialized" message.
- inspector/remote/RemoteInspector.h:
- inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::updateDebuggableAutomaticInspectCandidate):
Provide a longer timeout now that the frontend must send messages after the connection
has established. The longest I have seen in 600ms, but the average tends to be 200ms.
So bump the timeout to 800ms for a buffer.
(Inspector::RemoteInspector::setupSucceeded): Deleted.
(Inspector::RemoteInspector::setupCompleted):
Rename, as this happens at a slightly different time.
Source/WebCore:
Handle frontend initialization messages even though pages cannot
be automatically inspected yet.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::frontendInitialized):
- inspector/InspectorController.h:
- inspector/WorkerInspectorController.h:
- page/Page.h:
(WebCore::Page::inspectorDebuggable):
Source/WebInspectorUI:
- UserInterface/Base/Main.js:
Send the initialized message after we have sent all other setup messages,
such as enabling features and setting breakpoints.
- 4:18 PM Changeset in webkit [174027] by
-
- 2 edits in trunk/Tools
Many platform/mac-wk2/tiled-drawing/ tests fail when run on a retina device
https://bugs.webkit.org/show_bug.cgi?id=137089
Reviewed by Tim Horton.
This is a little sneaky since updateWindowScaleForTest() should ensure that these
tests run at 1x, but that code does not seem to execute at the right time for
these tests, so if we just ensure we start out at 1x, that appears to fix these
tests and does not break the HiDPI tests either.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):
- 3:54 PM Changeset in webkit [174026] by
-
- 2 edits in trunk/Tools
[Windows] Decrease default number of child processes used by Windows.
- Scripts/webkitpy/port/win.py:
(WinPort.default_child_processes):
Having too many seems to cause many tests to crash or timeout.
We may even need to make it have only 1 child process if we’re still seeing problems after this.
- 3:53 PM Changeset in webkit [174025] by
-
- 4 edits in trunk/Source/JavaScriptCore
DFG shouldn't insert store barriers when it has it on good authority that we're not storing a cell
https://bugs.webkit.org/show_bug.cgi?id=137161
Reviewed by Mark Hahnenberg.
This looks like a 1% Octane speed-up.
- bytecode/SpeculatedType.h:
(JSC::isNotCellSpeculation):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::insertStoreBarrier):
(JSC::DFG::FixupPhase::insertCheck):
- dfg/DFGNode.h:
(JSC::DFG::Node::shouldSpeculateNotCell):
- 3:17 PM Changeset in webkit [174024] by
-
- 7 edits5 deletes in tags/Safari-601.1.1
Roll out r172794. <rdar://problem/18447606>
- 3:05 PM Changeset in webkit [174023] by
-
- 2 edits in tags/Safari-601.1.1/Source/WebCore
Merged r173981. <rdar://problem/18447820>
- 2:57 PM Changeset in webkit [174022] by
-
- 5 edits in trunk/Source
Versioning.
- 2:53 PM Changeset in webkit [174021] by
-
- 1 copy in tags/Safari-601.1.1
New tag.
- 2:41 PM Changeset in webkit [174020] by
-
- 2 edits in trunk/LayoutTests
[Mac] Some inspector tests time out following r173992.
https://bugs.webkit.org/show_bug.cgi?id=137157
- platform/mac/TestExpectations:
- 2:39 PM Changeset in webkit [174019] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Type Token View shows type information on hover when it shouldn't
https://bugs.webkit.org/show_bug.cgi?id=137152
Reviewed by Brian J. Burg.
TypeTokenView should only show type information when there is
more than one primitive type or more than zero objects types.
This fixes a bug in checking the length of object types.
- UserInterface/Views/TypeTokenView.js:
(WebInspector.TypeTokenView.prototype._shouldShowPopover):
- 2:05 PM Changeset in webkit [174018] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r173988): Fix unused variable warning in PDFDocumentImage.cpp
Fixes the following build failure in release builds:
WebCore/platform/graphics/cg/PDFDocumentImage.cpp:230:12: error: unused variable 'pageCount' [-Werror,-Wunused-variable]
- platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::computeBoundsForCurrentPage): Change
ASSERT() to call pageCount().
- 12:02 PM Changeset in webkit [174017] by
-
- 2 edits in trunk/Tools
Mac EWS bots do not keep logs as promised
https://bugs.webkit.org/show_bug.cgi?id=137151
Reviewed by Ryosuke Niwa.
- EWSTools/start-queue-mac.sh: Actually keep the logs for 14 days.
- 11:51 AM Changeset in webkit [174016] by
-
- 2 edits in trunk/Source/WebKit2
Add WKInspector back function stubs that went missing from r173929.
My changes to WKDeprecatedFunctions.cpp got lost in the shuffle.
- Shared/API/c/WKDeprecatedFunctions.cpp:
(WKInspectorIsDebuggingJavaScript):
(WKInspectorToggleJavaScriptDebugging):
(WKInspectorIsProfilingJavaScript):
(WKInspectorToggleJavaScriptProfiling):
- 11:49 AM Changeset in webkit [174015] by
-
- 7 edits1 move2 deletes in trunk/Tools
Get rid of webkit-queues dashboard
https://bugs.webkit.org/show_bug.cgi?id=137141
Reviewed by Ryosuke Niwa.
- QueueStatusServer/app.yaml: Updated version.
- QueueStatusServer/templates/dashboard.html: Removed.
- QueueStatusServer/handlers/dashboard.py: Removed.
- QueueStatusServer/main.py:
Kill it!
- QueueStatusServer/stylesheets/common.css: Copied from Tools/QueueStatusServer/stylesheets/dashboard.css.
(.status-cell): Deleted.
(.status-cell:hover): Deleted.
(.status-cell.pass): Deleted.
(.status-cell.fail): Deleted.
(.status-cell.pending): Deleted.
(.status-cell.error): Deleted.
- QueueStatusServer/stylesheets/dashboard.css: Removed.
- QueueStatusServer/templates/activebots.html:
- QueueStatusServer/templates/patch.html:
- QueueStatusServer/templates/queuestatus.html:
- QueueStatusServer/templates/recentstatus.html:
Renamed dashboard.css to common.css, and removed dashboard-only rules.
- 11:26 AM Changeset in webkit [174014] by
-
- 2 edits in trunk/Source/WebCore
StorageTracker::deleteOrigin being called off the main thread (ASSERTs in inspector/test-harness-trivially-works.html test)
https://bugs.webkit.org/show_bug.cgi?id=129642
Apply post-review comments from Alexey Proskuryakov.
- storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::deleteEmptyDatabase): Make a thread-safe isolated copy of the string.
- 10:50 AM Changeset in webkit [174013] by
-
- 3 edits in trunk/Source/WebKit2
REGRESSION(r173929): Web inspector doesn't work after r173929 when INSPECTOR_SERVER is enabled
https://bugs.webkit.org/show_bug.cgi?id=137150
Reviewed by Timothy Hatcher.
The inspector doesn't show any information about the inspected
page because it's sending messages to a remote frontend that is
not running.
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::WebInspector): Initialize m_remoteFrontendConnected.
(WebKit::WebInspector::sendMessageToFrontend): Send
SendMessageToRemoteFrontend message to the UI process when remote
frontend is connected, or SendMessageToFrontend message to
WebInspectorUI otherwise.
(WebKit::WebInspector::remoteFrontendConnected): Set m_remoteFrontendConnected to true.
(WebKit::WebInspector::remoteFrontendDisconnected): Set m_remoteFrontendConnected to false.
- WebProcess/WebPage/WebInspector.h:
- 10:49 AM Changeset in webkit [174012] by
-
- 2 edits in trunk/Source/JavaScriptCore
Fix typo in YARR at BOL check
https://bugs.webkit.org/show_bug.cgi?id=137144
Reviewed by Darin Adler.
- yarr/YarrPattern.cpp: replace bitwise and operator by logical and
(JSC::Yarr::YarrPatternConstructor::assertionBOL):
- 10:18 AM Changeset in webkit [174011] by
-
- 2 edits in trunk/Source/WebCore
SVG -> OTF converter bug gardening
https://bugs.webkit.org/show_bug.cgi?id=137088
Reviewed by Darin Adler.
This test fixes some (but not all) of the svg/ layout tests that never worked with the
SVG -> OTF font converter. The actual list of tests this fixes is shown below. I will be
filing bugs for the remaining issues along with the relevant tests that those issues
cause to fail.
Tests: svg/W3C-SVG-1.1/fonts-elem-05-t.svg
svg/W3C-SVG-1.1/fonts-kern-01-t.svg
svg/custom/glyph-setting-d-attribute.svg
svg/custom/scrolling-embedded-svg-file-image-repaint-problem.html
svg/custom/skip-underline-missing-glyph.html
svg/custom/svg-fonts-fallback.xhtml
svg/custom/svg-fonts-in-text-controls.html
- svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::appendHEADTable): We use the font's minimum and maximum
bounding box information to size <textarea>s and <input>s.
(WebCore::SVGToOTFFontConverter::addCodepointRanges): Codepoint ranges are closed.
(WebCore::SVGToOTFFontConverter::computeKerningData): Typo in appending glyphs to the
wrong set.
(WebCore::SVGToOTFFontConverter::transcodeGlyphPaths): Use the font's horizontal
origin if the glyph doesn't have one.
(WebCore::SVGToOTFFontConverter::convertSVGToOTFFont): r173852 implemented vhea, vmtx,
and kern.
(WebCore::transcodeGlyphPaths): Moved inside SVGToOTFFontConverter.
- 10:02 AM Changeset in webkit [174010] by
-
- 2 edits in trunk/Source/WebCore
iOS build fix following r173989.
- page/ios/FrameIOS.mm:
(WebCore::ancestorRespondingToClickEvents):
- 9:58 AM Changeset in webkit [174009] by
-
- 10 edits in trunk/Tools
Get rid of Retry status in webkit-queues
https://bugs.webkit.org/show_bug.cgi?id=137135
Reviewed by Ryosuke Niwa.
- QueueStatusServer/config/messages.py: Removed Retry.
- QueueStatusServer/handlers/releasepatch.py: This is now straightforward, as it
no longer needs to check the latest status. It just always both unlocks the patch
and removes it from WorkItems.
- QueueStatusServer/handlers/submittoews.py: (SubmitToEWS._should_add_to_ews_queue):
I don't understand why we even needed to check for retries here, but now that there
are no retries, that code can go to /dev/null.
- QueueStatusServer/loggers/recordpatchevent.py:
(RecordPatchEvent.started):
(RecordPatchEvent.retrying): Deleted.
Fixed retry counting, it should work for all queues now.
- QueueStatusServer/model/queuestatus.py:
(QueueStatus.is_retry_request): Deleted. These are no more.
- Scripts/webkitpy/common/net/statusserver_mock.py:
(MockStatusServer.release_lock):
- Scripts/webkitpy/tool/commands/queues_unittest.py:
Did whatever it took to keep passing the tests. The particular test doesn't seem
quite right, but whatever.
- Scripts/webkitpy/tool/commands/queues.py:
(CommitQueue.process_work_item): Instead of posting a retry status, just unlock
and let others pick up. Also, added explicit returns for clarity.
(AbstractPatchQueue._did_retry): Deleted.
- 9:57 AM Changeset in webkit [174008] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Don't include full path names in WebKitEnumTypes.h
https://bugs.webkit.org/show_bug.cgi?id=137148
Reviewed by Carlos Garcia Campos.
Replace @filename@ with @basename@ in the template, since we don't
want to include the full path name in the generated header.
- UIProcess/API/gtk/WebKitEnumTypes.h.template:
- 9:57 AM WebKitGTK/2.6.x edited by
- (diff)
- 7:27 AM Changeset in webkit [174007] by
-
- 2 edits in trunk/Source/WebCore
[CSS Grid Layout] Empty string case already covered by containesOnlyWhiteSpace.
https://bugs.webkit.org/show_bug.cgi?id=137146
Reviewed by Sergio Villar Senin.
When checking out for white-space only strings in the grid-template-areas
property values, it's not neccessary to check out for empty strings as
such case is already covered.
No new tests, already covered by fast/css-grid-layout/grid-template-areas-empty-string-crash.html.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTemplateAreasRow):
- 6:41 AM Changeset in webkit [174006] by
-
- 4 edits2 adds in trunk
[CSS Grid Layout] Fix the handling of infinity in track growth limits
https://bugs.webkit.org/show_bug.cgi?id=137019
Reviewed by Darin Adler.
Source/WebCore:
The growth limit of content sized tracks is initialized to
infinity which is internally represented as -1. We were not
specialcasing this situation, and thus, -1 was used in the
computations as any other value. This change makes the code aware
of the existence of infinites (like when sorting tracks by growth
potential or when initializing the track growth limits).
There was another bug related to infinities. The code that was
replacing a infinite growth limit by a finite one was not using
the proper indexes so the tracks that were being updated were the
wrong ones.
Test: fast/css-grid-layout/grid-content-sized-columns-resolution.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::resolveContentBasedTrackSizingFunctions):
(WebCore::sortByGridTrackGrowthPotential):
(WebCore::RenderGrid::distributeSpaceToTracks):
LayoutTests:
- fast/css-grid-layout/grid-content-sized-columns-resolution-expected.txt: Added.
- fast/css-grid-layout/grid-content-sized-columns-resolution.html: Added.
- fast/css-grid-layout/grid-item-order-in-content-sized-columns-resolution-expected.txt:
- 6:14 AM Changeset in webkit [174005] by
-
- 2 edits1 add in trunk/Tools
[EFL] Fix the gst-libav build on ARM Thumb2
https://bugs.webkit.org/show_bug.cgi?id=137022
Reviewed by Zoltan Herczeg.
- efl/jhbuild.modules:
- efl/patches/gst-libav.patch: Added.
- 5:16 AM Changeset in webkit [174004] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore
Unreviewed. Fix make distcheck.
- GNUmakefile.list.am: Add missing header file.
- 2:50 AM Changeset in webkit [174003] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4
Merge r170997 - [GTK] Enable VIDEO_TRACK by default
https://bugs.webkit.org/show_bug.cgi?id=134801
Reviewed by Philippe Normand.
- Source/cmake/OptionsGTK.cmake:
- 1:39 AM Changeset in webkit [174002] by
-
- 3 edits6 adds in trunk
[GTK] Fix support for the initial-letter CSS property to first-letter
https://bugs.webkit.org/show_bug.cgi?id=137108
Patch by Lorenzo Tilve <ltilve@igalia.com> on 2014-09-26
Reviewed by Alejandro G. Castro.
Source/WebCore:
Add support for cap-height to the font system.
- platform/graphics/freetype/SimpleFontDataFreeType.cpp:
(WebCore::SimpleFontData::platformInit):
LayoutTests:
Add missing GTK test expectation files after http://webkit.org/b/136484
- platform/gtk/fast/css-generated-content/initial-letter-basic-expected.txt: Added.
- platform/gtk/fast/css-generated-content/initial-letter-border-padding-expected.txt: Added.
- platform/gtk/fast/css-generated-content/initial-letter-clearance-expected.txt: Added.
- platform/gtk/fast/css-generated-content/initial-letter-descender-expected.txt: Added.
- platform/gtk/fast/css-generated-content/initial-letter-raised-expected.txt: Added.
- platform/gtk/fast/css-generated-content/initial-letter-sunken-expected.txt: Added.
- 1:20 AM Changeset in webkit [174001] by
-
- 2 edits in trunk/Tools
[EFL] Bump up dependencies not to conflict with the GTK port.
https://bugs.webkit.org/show_bug.cgi?id=137143
Patch by Akos Kiss <akiss@inf.u-szeged.hu> on 2014-09-26
Reviewed by Gyuyoung Kim.
Tools/efl/install-dependencies and Tools/gtk/install-dependencies keep
installing and removing different versions of libgnutls-dev, thus
hindering the development for both ports on the same machine. GTK is
using the newer version of the package, now bumping up EFL to use the
same.
- efl/install-dependencies:
- 1:17 AM Changeset in webkit [174000] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4
Merge r173999 - [GTK] Enable CSS_IMAGE_SET in production builds
https://bugs.webkit.org/show_bug.cgi?id=137142
Reviewed by Alejandro G. Castro.
This is required by the inspector to show some of the icons that
has a HiDPI variant.
- Source/cmake/OptionsGTK.cmake:
- 12:39 AM Changeset in webkit [173999] by
-
- 2 edits in trunk
[GTK] Enable CSS_IMAGE_SET in production builds
https://bugs.webkit.org/show_bug.cgi?id=137142
Reviewed by Alejandro G. Castro.
This is required by the inspector to show some of the icons that
has a HiDPI variant.
- Source/cmake/OptionsGTK.cmake:
- 12:32 AM Changeset in webkit [173998] by
-
- 2 edits in trunk/LayoutTests
Unreviewed gardening after r173992. Skip inspector/timelines/.
- TestExpectations: mark inspector/timelines/ as Skip, since
it seems to be running into unexplained nondeterminism similar to
inspector/debugger/ tests. These should be investigated together.
Sep 25, 2014:
- 11:24 PM Changeset in webkit [173997] by
-
- 2 edits in trunk/Tools
[EFL][WK2] Minibrowser : Fix the 'Escape' button issue to exit fullscreen
https://bugs.webkit.org/show_bug.cgi?id=136854
Patch by Rohit Kumar <kumar.rohit@samsung.com> on 2014-09-25
Reviewed by Gyuyoung Kim.
'Escape' key should exit fullscreen first and then should be used to stop page load.
- MiniBrowser/efl/main.c:
(on_key_down):
- 11:03 PM Changeset in webkit [173996] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Show type info icon is blurry
https://bugs.webkit.org/show_bug.cgi?id=137125
Reviewed by Darin Adler.
- UserInterface/Images/NavigationItemTypes.svg:
- UserInterface/Views/ScriptContentView.js:
(WebInspector.ScriptContentView):
- UserInterface/Views/TextContentView.js:
(WebInspector.TextContentView):
- UserInterface/Views/TextResourceContentView.js:
(WebInspector.TextResourceContentView):
- 10:37 PM Changeset in webkit [173995] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, EFL gardening. Mark SVG 1.1 tests are flaky.
- platform/efl/TestExpectations:
- 9:31 PM Changeset in webkit [173994] by
-
- 5 edits in trunk/Source
Web Inspector: console.assert(bitString) TypeSet:50
https://bugs.webkit.org/show_bug.cgi?id=137051
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
This patch creates stricter requirements on a TypeDescription
being valid. To be valid, a TypeDescription now ensures that
the TypeSet it describes has non null type information.
- inspector/agents/InspectorRuntimeAgent.cpp:
(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
- runtime/TypeSet.h:
(JSC::TypeSet::isEmpty):
Source/WebInspectorUI:
This fixes TypeSet's isContainedIn method by ensuring that
the type bit string isn't zero because the test would trivially
pass if the bit string is zero.
- UserInterface/Models/TypeSet.js:
(WebInspector.TypeSet.prototype.isContainedIn):
- 8:59 PM Changeset in webkit [173993] by
-
- 51 edits52 adds in trunk
FTL should sink object allocations
https://bugs.webkit.org/show_bug.cgi?id=136330
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
This adds a comprehensive infrastructure for sinking object allocations in DFG SSA form. The
ultimate goal of sinking is to sink an allocation "past the points of its death" - i.e. to
eliminate it completely. The way sinking reasons about the CFG means that it resembles a
partial escape analysis: we create paths through a function where some allocation(s) don't
have to be done at all even if there are other paths along which those allocations still have
to happen. But it also produces other side benefits. Even if an allocation isn't eliminated
along any path, the act of sinking reduces the number of barriers that have to execute.
Because this was a fairly ambituous SSA analysis and transformation, I added a bunch of C++11
sugar to the DFG's internal APIs to allow for easier iteration over blocks, nodes, and
successors; and to add more functor goodness to allow for more lambdas.
This is just the beginning. The bug has a bunch of other bugs that depend on it. So far this
is a spectacular speed-up on microbenchmarks but it's still too limited to affect big
benchmarks. For example, doing o == p makes the sinking phase think that o and p escape.
That's just an omission and there are likely others; we can easily fix them. I think it's
best to land it in its current form and then to worry about the big benchmarks in subsequent
work (see bug 137126).
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/StructureSet.h:
(JSC::StructureSet::iterator::iterator):
(JSC::StructureSet::iterator::operator*):
(JSC::StructureSet::iterator::operator++):
(JSC::StructureSet::iterator::operator==):
(JSC::StructureSet::iterator::operator!=):
(JSC::StructureSet::begin):
(JSC::StructureSet::end):
- dfg/DFGAbstractInterpreter.h:
(JSC::DFG::AbstractInterpreter::phiChildren):
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::AbstractInterpreter):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::startExecuting):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::execute):
- dfg/DFGAvailability.h:
(JSC::DFG::Availability::shouldUseNode):
(JSC::DFG::Availability::isFlushUseful):
(JSC::DFG::Availability::isDead):
(JSC::DFG::Availability::operator!=):
- dfg/DFGAvailabilityMap.cpp: Added.
(JSC::DFG::AvailabilityMap::prune):
(JSC::DFG::AvailabilityMap::clear):
(JSC::DFG::AvailabilityMap::dump):
(JSC::DFG::AvailabilityMap::operator==):
(JSC::DFG::AvailabilityMap::merge):
- dfg/DFGAvailabilityMap.h: Added.
(JSC::DFG::AvailabilityMap::forEachAvailability):
- dfg/DFGBasicBlock.cpp:
(JSC::DFG::BasicBlock::SSAData::SSAData):
- dfg/DFGBasicBlock.h:
(JSC::DFG::BasicBlock::begin):
(JSC::DFG::BasicBlock::end):
(JSC::DFG::BasicBlock::SuccessorsIterable::SuccessorsIterable):
(JSC::DFG::BasicBlock::SuccessorsIterable::iterator::iterator):
(JSC::DFG::BasicBlock::SuccessorsIterable::iterator::operator*):
(JSC::DFG::BasicBlock::SuccessorsIterable::iterator::operator++):
(JSC::DFG::BasicBlock::SuccessorsIterable::iterator::operator==):
(JSC::DFG::BasicBlock::SuccessorsIterable::iterator::operator!=):
(JSC::DFG::BasicBlock::SuccessorsIterable::begin):
(JSC::DFG::BasicBlock::SuccessorsIterable::end):
(JSC::DFG::BasicBlock::successors):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGFlushedAt.cpp:
(JSC::DFG::FlushedAt::dump):
- dfg/DFGFlushedAt.h:
(JSC::DFG::FlushedAt::FlushedAt):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dumpBlockHeader):
(JSC::DFG::Graph::mergeRelevantToOSR):
(JSC::DFG::Graph::invalidateCFG):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::NaturalBlockIterable::NaturalBlockIterable):
(JSC::DFG::Graph::NaturalBlockIterable::iterator::iterator):
(JSC::DFG::Graph::NaturalBlockIterable::iterator::operator*):
(JSC::DFG::Graph::NaturalBlockIterable::iterator::operator++):
(JSC::DFG::Graph::NaturalBlockIterable::iterator::operator==):
(JSC::DFG::Graph::NaturalBlockIterable::iterator::operator!=):
(JSC::DFG::Graph::NaturalBlockIterable::iterator::findNext):
(JSC::DFG::Graph::NaturalBlockIterable::begin):
(JSC::DFG::Graph::NaturalBlockIterable::end):
(JSC::DFG::Graph::blocksInNaturalOrder):
(JSC::DFG::Graph::doToChildrenWithNode):
(JSC::DFG::Graph::doToChildren):
- dfg/DFGHeapLocation.cpp:
(WTF::printInternal):
- dfg/DFGHeapLocation.h:
- dfg/DFGInsertOSRHintsForUpdate.cpp: Added.
(JSC::DFG::insertOSRHintsForUpdate):
- dfg/DFGInsertOSRHintsForUpdate.h: Added.
- dfg/DFGInsertionSet.h:
(JSC::DFG::InsertionSet::graph):
- dfg/DFGMayExit.cpp:
(JSC::DFG::mayExit):
- dfg/DFGNode.h:
(JSC::DFG::Node::convertToPutByOffsetHint):
(JSC::DFG::Node::convertToPutStructureHint):
(JSC::DFG::Node::convertToPhantomNewObject):
(JSC::DFG::Node::isCellConstant):
(JSC::DFG::Node::castConstant):
(JSC::DFG::Node::hasIdentifier):
(JSC::DFG::Node::hasStorageAccessData):
(JSC::DFG::Node::hasObjectMaterializationData):
(JSC::DFG::Node::objectMaterializationData):
(JSC::DFG::Node::isPhantomObjectAllocation):
- dfg/DFGNodeType.h:
- dfg/DFGOSRAvailabilityAnalysisPhase.cpp:
(JSC::DFG::OSRAvailabilityAnalysisPhase::run):
(JSC::DFG::LocalOSRAvailabilityCalculator::endBlock):
(JSC::DFG::LocalOSRAvailabilityCalculator::executeNode):
- dfg/DFGOSRAvailabilityAnalysisPhase.h:
- dfg/DFGObjectAllocationSinkingPhase.cpp: Added.
(JSC::DFG::ObjectAllocationSinkingPhase::ObjectAllocationSinkingPhase):
(JSC::DFG::ObjectAllocationSinkingPhase::run):
(JSC::DFG::ObjectAllocationSinkingPhase::performSinking):
(JSC::DFG::ObjectAllocationSinkingPhase::determineMaterializationPoints):
(JSC::DFG::ObjectAllocationSinkingPhase::placeMaterializationPoints):
(JSC::DFG::ObjectAllocationSinkingPhase::lowerNonReadingOperationsOnPhantomAllocations):
(JSC::DFG::ObjectAllocationSinkingPhase::promoteSunkenFields):
(JSC::DFG::ObjectAllocationSinkingPhase::resolve):
(JSC::DFG::ObjectAllocationSinkingPhase::handleNode):
(JSC::DFG::ObjectAllocationSinkingPhase::createMaterialize):
(JSC::DFG::ObjectAllocationSinkingPhase::populateMaterialize):
(JSC::DFG::performObjectAllocationSinking):
- dfg/DFGObjectAllocationSinkingPhase.h: Added.
- dfg/DFGObjectMaterializationData.cpp: Added.
(JSC::DFG::PhantomPropertyValue::dump):
(JSC::DFG::ObjectMaterializationData::dump):
(JSC::DFG::ObjectMaterializationData::oneWaySimilarityScore):
(JSC::DFG::ObjectMaterializationData::similarityScore):
- dfg/DFGObjectMaterializationData.h: Added.
(JSC::DFG::PhantomPropertyValue::PhantomPropertyValue):
(JSC::DFG::PhantomPropertyValue::operator==):
- dfg/DFGPhantomCanonicalizationPhase.cpp:
(JSC::DFG::PhantomCanonicalizationPhase::run):
- dfg/DFGPhantomRemovalPhase.cpp:
(JSC::DFG::PhantomRemovalPhase::run):
- dfg/DFGPhiChildren.cpp: Added.
(JSC::DFG::PhiChildren::PhiChildren):
(JSC::DFG::PhiChildren::~PhiChildren):
(JSC::DFG::PhiChildren::upsilonsOf):
- dfg/DFGPhiChildren.h: Added.
(JSC::DFG::PhiChildren::forAllIncomingValues):
(JSC::DFG::PhiChildren::forAllTransitiveIncomingValues):
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::compileInThreadImpl):
- dfg/DFGPrePostNumbering.cpp: Added.
(JSC::DFG::PrePostNumbering::PrePostNumbering):
(JSC::DFG::PrePostNumbering::~PrePostNumbering):
(JSC::DFG::PrePostNumbering::compute):
(WTF::printInternal):
- dfg/DFGPrePostNumbering.h: Added.
(JSC::DFG::PrePostNumbering::preNumber):
(JSC::DFG::PrePostNumbering::postNumber):
(JSC::DFG::PrePostNumbering::isStrictAncestorOf):
(JSC::DFG::PrePostNumbering::isAncestorOf):
(JSC::DFG::PrePostNumbering::isStrictDescendantOf):
(JSC::DFG::PrePostNumbering::isDescendantOf):
(JSC::DFG::PrePostNumbering::edgeKind):
- dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
- dfg/DFGPromoteHeapAccess.h: Added.
(JSC::DFG::promoteHeapAccess):
- dfg/DFGPromotedHeapLocation.cpp: Added.
(JSC::DFG::PromotedLocationDescriptor::dump):
(JSC::DFG::PromotedHeapLocation::createHint):
(JSC::DFG::PromotedHeapLocation::dump):
(WTF::printInternal):
- dfg/DFGPromotedHeapLocation.h: Added.
(JSC::DFG::PromotedLocationDescriptor::PromotedLocationDescriptor):
(JSC::DFG::PromotedLocationDescriptor::operator!):
(JSC::DFG::PromotedLocationDescriptor::kind):
(JSC::DFG::PromotedLocationDescriptor::info):
(JSC::DFG::PromotedLocationDescriptor::hash):
(JSC::DFG::PromotedLocationDescriptor::operator==):
(JSC::DFG::PromotedLocationDescriptor::operator!=):
(JSC::DFG::PromotedLocationDescriptor::isHashTableDeletedValue):
(JSC::DFG::PromotedHeapLocation::PromotedHeapLocation):
(JSC::DFG::PromotedHeapLocation::operator!):
(JSC::DFG::PromotedHeapLocation::kind):
(JSC::DFG::PromotedHeapLocation::base):
(JSC::DFG::PromotedHeapLocation::info):
(JSC::DFG::PromotedHeapLocation::descriptor):
(JSC::DFG::PromotedHeapLocation::hash):
(JSC::DFG::PromotedHeapLocation::operator==):
(JSC::DFG::PromotedHeapLocation::isHashTableDeletedValue):
(JSC::DFG::PromotedHeapLocationHash::hash):
(JSC::DFG::PromotedHeapLocationHash::equal):
- dfg/DFGSSACalculator.cpp:
(JSC::DFG::SSACalculator::reset):
- dfg/DFGSSACalculator.h:
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCurrentBlock):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGStructureRegistrationPhase.cpp:
(JSC::DFG::StructureRegistrationPhase::run):
- dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLExitPropertyValue.cpp: Added.
(JSC::FTL::ExitPropertyValue::dump):
- ftl/FTLExitPropertyValue.h: Added.
(JSC::FTL::ExitPropertyValue::ExitPropertyValue):
(JSC::FTL::ExitPropertyValue::operator!):
(JSC::FTL::ExitPropertyValue::location):
(JSC::FTL::ExitPropertyValue::value):
- ftl/FTLExitTimeObjectMaterialization.cpp: Added.
(JSC::FTL::ExitTimeObjectMaterialization::ExitTimeObjectMaterialization):
(JSC::FTL::ExitTimeObjectMaterialization::~ExitTimeObjectMaterialization):
(JSC::FTL::ExitTimeObjectMaterialization::add):
(JSC::FTL::ExitTimeObjectMaterialization::get):
(JSC::FTL::ExitTimeObjectMaterialization::dump):
- ftl/FTLExitTimeObjectMaterialization.h: Added.
(JSC::FTL::ExitTimeObjectMaterialization::type):
(JSC::FTL::ExitTimeObjectMaterialization::properties):
- ftl/FTLExitValue.cpp:
(JSC::FTL::ExitValue::materializeNewObject):
(JSC::FTL::ExitValue::dumpInContext):
- ftl/FTLExitValue.h:
(JSC::FTL::ExitValue::isObjectMaterialization):
(JSC::FTL::ExitValue::objectMaterialization):
(JSC::FTL::ExitValue::withVirtualRegister):
(JSC::FTL::ExitValue::valueFormat):
- ftl/FTLLowerDFGToLLVM.cpp:
(JSC::FTL::LowerDFGToLLVM::compileNode):
(JSC::FTL::LowerDFGToLLVM::compileCheckStructure):
(JSC::FTL::LowerDFGToLLVM::compileArrayifyToStructure):
(JSC::FTL::LowerDFGToLLVM::compilePutStructure):
(JSC::FTL::LowerDFGToLLVM::compileNewObject):
(JSC::FTL::LowerDFGToLLVM::compileMultiGetByOffset):
(JSC::FTL::LowerDFGToLLVM::compileMultiPutByOffset):
(JSC::FTL::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::LowerDFGToLLVM::compileCheckStructureImmediate):
(JSC::FTL::LowerDFGToLLVM::compileMaterializeNewObject):
(JSC::FTL::LowerDFGToLLVM::checkStructure):
(JSC::FTL::LowerDFGToLLVM::allocateCell):
(JSC::FTL::LowerDFGToLLVM::storeStructure):
(JSC::FTL::LowerDFGToLLVM::allocateObject):
(JSC::FTL::LowerDFGToLLVM::speculateStringObjectForStructureID):
(JSC::FTL::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::LowerDFGToLLVM::buildExitArguments):
(JSC::FTL::LowerDFGToLLVM::exitValueForAvailability):
(JSC::FTL::LowerDFGToLLVM::exitValueForNode):
(JSC::FTL::LowerDFGToLLVM::weakStructureID):
(JSC::FTL::LowerDFGToLLVM::weakStructure):
(JSC::FTL::LowerDFGToLLVM::availabilityMap):
(JSC::FTL::LowerDFGToLLVM::availability): Deleted.
- ftl/FTLOSRExit.h:
- ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileRecovery):
(JSC::FTL::compileStub):
- ftl/FTLOperations.cpp: Added.
(JSC::FTL::operationNewObjectWithButterfly):
(JSC::FTL::operationMaterializeObjectInOSR):
- ftl/FTLOperations.h: Added.
- ftl/FTLSwitchCase.h:
(JSC::FTL::SwitchCase::SwitchCase):
- runtime/JSObject.h:
(JSC::JSObject::finishCreation):
(JSC::JSFinalObject::JSFinalObject):
(JSC::JSFinalObject::create):
- runtime/Structure.cpp:
(JSC::Structure::canUseForAllocationsOf):
- runtime/Structure.h:
- tests/stress/elidable-new-object-roflcopter-then-exit.js: Added.
(sumOfArithSeries):
(foo):
- tests/stress/elide-new-object-dag-then-exit.js: Added.
(sumOfArithSeries):
(bar):
(verify):
(foo):
- tests/stress/obviously-elidable-new-object-then-exit.js: Added.
(sumOfArithSeries):
(foo):
Source/WTF:
Make it possible to reset a Bag.
- wtf/Bag.h:
(WTF::Bag::Bag):
(WTF::Bag::~Bag):
(WTF::Bag::clear):
LayoutTests:
- js/math-denorm.html: Added.
- js/regress/elidable-new-object-dag-expected.txt: Added.
- js/regress/elidable-new-object-dag.html: Added.
- js/regress/elidable-new-object-roflcopter-expected.txt: Added.
- js/regress/elidable-new-object-roflcopter.html: Added.
- js/regress/elidable-new-object-tree-expected.txt: Added.
- js/regress/elidable-new-object-tree.html: Added.
- js/regress/obvious-sink-pathology-expected.txt: Added.
- js/regress/obvious-sink-pathology-taken-expected.txt: Added.
- js/regress/obvious-sink-pathology-taken.html: Added.
- js/regress/obvious-sink-pathology.html: Added.
- js/regress/obviously-elidable-new-object-expected.txt: Added.
- js/regress/obviously-elidable-new-object.html: Added.
- js/regress/script-tests/elidable-new-object-dag.js: Added.
(sumOfArithSeries):
(foo):
- js/regress/script-tests/elidable-new-object-roflcopter.js: Added.
(sumOfArithSeries):
(foo):
- js/regress/script-tests/elidable-new-object-tree.js: Added.
(sumOfArithSeries):
(foo):
- js/regress/script-tests/obvious-sink-pathology-taken.js: Added.
(sumOfArithSeries):
(bar):
(foo):
- js/regress/script-tests/obvious-sink-pathology.js: Added.
(sumOfArithSeries):
(bar):
(foo):
- js/regress/script-tests/obviously-elidable-new-object.js: Added.
(sumOfArithSeries):
(foo):
- js/regress/script-tests/sinkable-new-object-dag.js: Added.
(sumOfArithSeries):
(verify):
(foo):
- js/regress/script-tests/sinkable-new-object-taken.js: Added.
(sumOfArithSeries):
(bar):
(foo):
- js/regress/script-tests/sinkable-new-object.js: Added.
(sumOfArithSeries):
(bar):
(foo):
- js/regress/sinkable-new-object-dag-expected.txt: Added.
- js/regress/sinkable-new-object-dag.html: Added.
- js/regress/sinkable-new-object-expected.txt: Added.
- js/regress/sinkable-new-object-taken-expected.txt: Added.
- js/regress/sinkable-new-object-taken.html: Added.
- js/regress/sinkable-new-object.html: Added.
- 7:29 PM Changeset in webkit [173992] by
-
- 6 edits3 adds in trunk
Web Inspector: FunctionCall timeline records omit profile data if the debugger has paused
https://bugs.webkit.org/show_bug.cgi?id=136805
Reviewed by Timothy Hatcher.
Source/WebCore:
TimelineAgent was mismanaging its call stack depth counter, which caused nested FunctionCall
records to steal the parent FunctionCall's captured profile in the child's didCallFunction().
Thus, the top FunctionCall node had no profile data and nested FunctionCall nodes each had
their own profiles. The frontend expected just one profile, so it didn't show anything when
it couldn't be found.
Test: inspector/timeline/debugger-paused-while-recording.html
- inspector/InspectorTimelineAgent.cpp: Rename m_recordingProfileDepth to m_callStackDepth.
(WebCore::InspectorTimelineAgent::willCallFunction): Fix the call stack depth management.
(WebCore::InspectorTimelineAgent::didCallFunction):
(WebCore::InspectorTimelineAgent::willEvaluateScript):
(WebCore::InspectorTimelineAgent::didEvaluateScript):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
- inspector/InspectorTimelineAgent.h:
Source/WebInspectorUI:
- UserInterface/Test.html: Add missing include for ScopeChainNode.js.
LayoutTests:
Add a test to see that script timeline records contain profiles even when
the debugger pauses during timeline capturing.
- inspector/timeline/debugger-paused-while-recording-expected.txt: Added.
- inspector/timeline/debugger-paused-while-recording.html: Added.
- inspector/timeline/resources/timeline-helper.js: Added.
(callFunction):
(hook):
- 7:20 PM Changeset in webkit [173991] by
-
- 4 edits in trunk
StorageTracker::deleteOrigin being called off the main thread (ASSERTs in inspector/test-harness-trivially-works.html test)
https://bugs.webkit.org/show_bug.cgi?id=129642
Reviewed by Brady Eidson.
Source/WebCore:
When tearing down the inspector frontend's page, we trigger a threading violation
in StorageAreaSync's final sync code underneath StorageAreaSync::deleteEmptyDatabase().
No new tests. Regression is covered by inspector/test-harness-trivially-works.html.
- storage/StorageAreaSync.cpp:
(WebCore::StorageAreaSync::deleteEmptyDatabase): add a missing callOnMainThread() when
calling StorageTracker::deleteOriginWithIdentifier().
LayoutTests:
Remove the blanket Skip for all tests in inspector/.
- TestExpectations: clean up expectations for inspector/ and add new tracking bugs.
- 6:09 PM Changeset in webkit [173990] by
-
- 3 edits in trunk/Source/WebKit2
Clean up unused parameter warnings
https://bugs.webkit.org/show_bug.cgi?id=137107
Reviewed by Benjamin Poulain.
- Scripts/webkit/messages.py:
(generate_message_handler):
Sometimes generated code doesn't useconnectionparameter. SoUNUSED_PARAM(connection)is necessary.
- UIProcess/API/C/WKPage.cpp:
(WKPageIsPlayingAudio):
- 6:00 PM Changeset in webkit [173989] by
-
- 12 edits in trunk
Unprefix CSS cursor values zoom-in and zoom-out.
https://bugs.webkit.org/show_bug.cgi?id=137061
Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2014-09-25
Reviewed by Benjamin Poulain.
Source/WebCore:
This patch unprefixes CSS cursor values zoom-in and zoom-out.
-webkit-zoom-in and -webkit-zoom-out are kept as aliases.
ECursor members use InterCaps with an initial capital letter for now.
- css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator ECursor):
- css/CSSValueKeywords.in:
- css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyCursor::applyValue):
- html/ImageDocument.cpp:
(WebCore::ImageDocument::resizeImageToFit):
(WebCore::ImageDocument::restoreImageSize):
(WebCore::ImageDocument::windowSizeChanged):
- page/EventHandler.cpp:
(WebCore::EventHandler::selectCursor):
- rendering/style/RenderStyle.h:
- rendering/style/RenderStyleConstants.h:
LayoutTests:
Add test cases for zoom-in, zoom-out, -webkit-zoom-in, -webkit-zoom-out.
- fast/css/cursor-parsing-expected.txt:
- fast/css/cursor-parsing.html:
- 5:39 PM Changeset in webkit [173988] by
-
- 57 edits in trunk/Source
[Win] Debug builds of TestWebKitAPI are crashing.
https://bugs.webkit.org/show_bug.cgi?id=133553
Reviewed by Dean Jackson.
../WebCore:
Avoid crash on shutdown due to invalid mutex state in the
HashMap debug implementation during a static destruction operation.
- dom/Node.cpp:
(WebCore::ignoreSet): Convert static value into a NeverDestroyed.
(WebCore::Node::trackForDebugging): Use new NeverDestroyed call.
(WebCore::Node::~Node): Ditto.
../WebKit/win:
Switch from global static HashTable to a NeverDestroyed object.
Modify all accessors of the global static to use the new
NeverDestroyed accessor method.
- AccessibleBase.cpp:
(AccessibleBase::AccessibleBase):
(AccessibleBase::~AccessibleBase):
- CFDictionaryPropertyBag.cpp:
(CFDictionaryPropertyBag::CFDictionaryPropertyBag):
(CFDictionaryPropertyBag::~CFDictionaryPropertyBag):
- DefaultDownloadDelegate.cpp:
(DefaultDownloadDelegate::DefaultDownloadDelegate):
(DefaultDownloadDelegate::~DefaultDownloadDelegate):
- DefaultPolicyDelegate.cpp:
(DefaultPolicyDelegate::DefaultPolicyDelegate):
(DefaultPolicyDelegate::~DefaultPolicyDelegate):
- MemoryStream.cpp:
(MemoryStream::MemoryStream):
(MemoryStream::~MemoryStream):
- WebActionPropertyBag.cpp:
(WebActionPropertyBag::WebActionPropertyBag):
(WebActionPropertyBag::~WebActionPropertyBag):
- WebArchive.cpp:
(WebArchive::WebArchive):
(WebArchive::~WebArchive):
- WebBackForwardList.cpp:
(WebBackForwardList::WebBackForwardList):
(WebBackForwardList::~WebBackForwardList):
- WebCache.cpp:
(WebCache::WebCache):
(WebCache::~WebCache):
- WebCookieManager.cpp:
(WebCookieManager::WebCookieManager):
(WebCookieManager::~WebCookieManager):
- WebCoreStatistics.cpp:
(WebCoreStatistics::WebCoreStatistics):
(WebCoreStatistics::~WebCoreStatistics):
- WebDataSource.cpp:
(WebDataSource::~WebDataSource):
- WebDatabaseManager.cpp:
(WebDatabaseManager::WebDatabaseManager):
(WebDatabaseManager::~WebDatabaseManager):
- WebDocumentLoader.cpp:
(WebDocumentLoader::WebDocumentLoader):
(WebDocumentLoader::~WebDocumentLoader):
- WebDownload.cpp:
(WebDownload::WebDownload):
(WebDownload::~WebDownload):
- WebDropSource.cpp:
(WebDropSource::WebDropSource):
(WebDropSource::~WebDropSource):
- WebElementPropertyBag.cpp:
(WebElementPropertyBag::WebElementPropertyBag):
(WebElementPropertyBag::~WebElementPropertyBag):
- WebError.cpp:
(WebError::WebError):
(WebError::~WebError):
- WebFrame.cpp:
(WebFrame::WebFrame):
(WebFrame::~WebFrame):
- WebFramePolicyListener.cpp:
(WebFramePolicyListener::WebFramePolicyListener):
(WebFramePolicyListener::~WebFramePolicyListener):
- WebGeolocationPolicyListener.cpp:
(WebGeolocationPolicyListener::WebGeolocationPolicyListener):
(WebGeolocationPolicyListener::~WebGeolocationPolicyListener):
- WebGeolocationPosition.cpp:
(WebGeolocationPosition::WebGeolocationPosition):
(WebGeolocationPosition::~WebGeolocationPosition):
- WebHTMLRepresentation.cpp:
(WebHTMLRepresentation::WebHTMLRepresentation):
(WebHTMLRepresentation::~WebHTMLRepresentation):
- WebHistory.cpp:
(WebHistory::WebHistory):
(WebHistory::~WebHistory):
- WebHistoryItem.cpp:
(WebHistoryItem::WebHistoryItem):
(WebHistoryItem::~WebHistoryItem):
- WebIconDatabase.cpp:
(WebIconDatabase::WebIconDatabase):
(WebIconDatabase::~WebIconDatabase):
- WebInspector.cpp:
(WebInspector::WebInspector):
(WebInspector::~WebInspector):
- WebJavaScriptCollector.cpp:
(WebJavaScriptCollector::WebJavaScriptCollector):
(WebJavaScriptCollector::~WebJavaScriptCollector):
- WebKitClassFactory.cpp:
(WebKitClassFactory::WebKitClassFactory):
(WebKitClassFactory::~WebKitClassFactory):
- WebKitDLL.cpp: Also switch to NeverDestroyed HashTable for
the global class name count.
- WebKitDLL.h:
- WebKitStatistics.cpp:
(WebKitStatistics::WebKitStatistics):
(WebKitStatistics::~WebKitStatistics):
(WebKitStatistics::comClassNameCounts):
- WebMutableURLRequest.cpp:
(WebMutableURLRequest::WebMutableURLRequest):
(WebMutableURLRequest::~WebMutableURLRequest):
- WebNavigationData.cpp:
(WebNavigationData::WebNavigationData):
(WebNavigationData::~WebNavigationData):
- WebNotification.cpp:
(WebNotification::WebNotification):
(WebNotification::~WebNotification):
- WebNotificationCenter.cpp:
(WebNotificationCenter::WebNotificationCenter):
(WebNotificationCenter::~WebNotificationCenter):
- WebPreferences.cpp:
(webPreferencesInstances):
(WebPreferences::WebPreferences):
(WebPreferences::~WebPreferences):
(WebPreferences::getInstanceForIdentifier):
(WebPreferences::setInstance):
(WebPreferences::removeReferenceForIdentifier):
- WebResource.cpp:
(WebResource::WebResource):
(WebResource::~WebResource):
- WebScriptObject.cpp:
(WebScriptObject::WebScriptObject):
(WebScriptObject::~WebScriptObject):
- WebScriptWorld.cpp:
(WebScriptWorld::WebScriptWorld):
(WebScriptWorld::~WebScriptWorld):
- WebSecurityOrigin.cpp:
(WebSecurityOrigin::WebSecurityOrigin):
(WebSecurityOrigin::~WebSecurityOrigin):
- WebSerializedJSValue.cpp:
(WebSerializedJSValue::WebSerializedJSValue):
(WebSerializedJSValue::~WebSerializedJSValue):
- WebTextRenderer.cpp:
(WebTextRenderer::WebTextRenderer):
(WebTextRenderer::~WebTextRenderer):
- WebURLAuthenticationChallenge.cpp:
(WebURLAuthenticationChallenge::WebURLAuthenticationChallenge):
(WebURLAuthenticationChallenge::~WebURLAuthenticationChallenge):
- WebURLAuthenticationChallengeSender.cpp:
(WebURLAuthenticationChallengeSender::WebURLAuthenticationChallengeSender):
(WebURLAuthenticationChallengeSender::~WebURLAuthenticationChallengeSender):
- WebURLCredential.cpp:
(WebURLCredential::WebURLCredential):
(WebURLCredential::~WebURLCredential):
- WebURLProtectionSpace.cpp:
(WebURLProtectionSpace::WebURLProtectionSpace):
(WebURLProtectionSpace::~WebURLProtectionSpace):
- WebURLResponse.cpp:
(:m_refCount):
(WebURLResponse::~WebURLResponse):
- WebUserContentURLPattern.cpp:
(WebUserContentURLPattern::WebUserContentURLPattern):
(WebUserContentURLPattern::~WebUserContentURLPattern):
- WebView.cpp:
(pendingDeleteBackingStoreSet): Switch from a global static
value to a NeverDestroyed object wrapped by an accessor function.
(WebView::WebView): Ditto.
(WebView::~WebView): Ditto.
(WebView::deleteBackingStore): Ditto.
(WebView::deleteBackingStoreSoon): Ditto,
(WebView::cancelDeleteBackingStoreSoon): Ditto.
- WebWorkersPrivate.cpp: Switch from a global static value for
the preferences objects t a NeverDestroyed container.
(WebWorkersPrivate::WebWorkersPrivate): Ditto.
(WebWorkersPrivate::~WebWorkersPrivate): Ditto.
- 5:34 PM Changeset in webkit [173987] by
-
- 9 edits in trunk/Source/WebCore
Add support for is<SVGDocument>() / downcast<SVGDocument>()
https://bugs.webkit.org/show_bug.cgi?id=137128
Reviewed by Ryosuke Niwa.
Add support for is<SVGDocument>() / downcast<SVGDocument>() by using
the SPECIALIZE_TYPE_TRAITS_*() macro, instead of the
DOCUMENT_TYPE_CASTS() one.
No new tests, no behavior change.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::remoteSVGRootElement):
- html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::getSVGDocument):
- page/EventHandler.cpp:
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
- page/Frame.cpp:
(WebCore::Frame::setPageAndTextZoomFactors):
- page/FrameView.cpp:
(WebCore::FrameView::scrollToAnchor):
- svg/SVGDocument.h:
(WebCore::isSVGDocument):
- svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::hasSingleSecurityOrigin):
(WebCore::SVGImage::setContainerSize):
(WebCore::SVGImage::containerSize):
(WebCore::SVGImage::embeddedContentBox):
(WebCore::SVGImage::hasRelativeWidth):
(WebCore::SVGImage::hasRelativeHeight):
(WebCore::SVGImage::computeIntrinsicDimensions):
(WebCore::SVGImage::startAnimation):
(WebCore::SVGImage::stopAnimation):
- 5:34 PM Changeset in webkit [173986] by
-
- 2 edits in trunk/Source/WebKit
[Win] 64-bit build fix after r173929.
- WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
- 5:29 PM Changeset in webkit [173985] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Skip quicktime-plugin-snapshotted.html
Quicktime plugin snapshotting is now covered by all other snapshotting tests
and this test in particular seems to fail only on a few bots.
- platform/mac/TestExpectations:
- 5:22 PM Changeset in webkit [173984] by
-
- 2 edits in trunk/Source/WTF
[Windows] Unreviewed build fix. Ensure that python2.7 is used for Windows builds.
- WTF.vcxproj/WTFGenerated.make:
- 5:04 PM Changeset in webkit [173983] by
-
- 2 edits in trunk/Tools
Add Said to the contributors list so his name completes in bugzilla.
- Scripts/webkitpy/common/config/contributors.json:
- 5:03 PM Changeset in webkit [173982] by
-
- 5 edits in trunk
Rename CSSKeyframesRule insertRule to appendRule (57910)
https://bugs.webkit.org/show_bug.cgi?id=57910
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2014-09-25
Reviewed by Dean Jackson.
Source/WebCore:
Tests: animations/change-keyframes.html
- css/WebKitCSSKeyframesRule.h:
(WebCore::WebKitCSSKeyframesRule::appendRule):
-- Make WebKitCSSKeyframesRule::appendRule to be an alias of WebKitCSSKeyframesRule::insertRule()
to conform with CSS specs
- css/WebKitCSSKeyframesRule.idl:
-- Add the new method WebKitCSSKeyframesRule::appendRule() but keep the original method
WebKitCSSKeyframesRule::appendRule() to not break exiting customers' pages.
LayoutTests:
- animations/change-keyframes.html:
-- Ensure both WebKitCSSKeyframesRule methods insertRule() and appendRule() are
both supported.
- 4:49 PM Changeset in webkit [173981] by
-
- 2 edits in trunk/Source/WebCore
Null deref in setStateScrollingNodeSnapOffsetsAsFloat
https://bugs.webkit.org/show_bug.cgi?id=137133
<rdar://problem/18447820>
Reviewed by Beth Dakin.
- page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated):
(WebCore::AsyncScrollingCoordinator::updateOverflowScrollingNode):
Get the deviceScaleFactor from m_page instead of various other places,
because scrolledContentsLayer can be null in the case of non-composited
overflow scroll.
- 4:37 PM Changeset in webkit [173980] by
-
- 91 edits in trunk/Source
Use is<HTML*Element>() instead of isHTML*Element() - Part 2
https://bugs.webkit.org/show_bug.cgi?id=137103
Reviewed by Benjamin Poulain.
Source/WebCore:
Use is<HTML*Element>() instead of isHTML*Element() and drop support for
the generated isHTML*Element() macros.
No new tests, no behavior change.
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedUIElementForPage):
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::labelChanged):
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::isEnabled):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::isNativeImage):
(WebCore::AccessibilityNodeObject::anchorElement):
(WebCore::AccessibilityNodeObject::alternativeText):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::anchorElement):
(WebCore::AccessibilityRenderObject::labelElementContainer):
(WebCore::AccessibilityRenderObject::internalLinkElement):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::url):
(WebCore::AccessibilityRenderObject::getDocumentLinks):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::stringValueForMSAA):
(WebCore::AccessibilityRenderObject::isLinked):
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::tableElement):
(WebCore::AccessibilityTable::isTableExposableThroughAccessibility):
(WebCore::AccessibilityTable::title):
- accessibility/atk/WebKitAccessibleInterfaceTable.cpp:
(webkitAccessibleTableGetCaption):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
- bindings/js/JSNodeCustom.cpp:
(WebCore::isReachableFromDOM):
- css/CSSDefaultStyleSheets.cpp:
(WebCore::elementCanUseSimpleDefaultStyle):
(WebCore::CSSDefaultStyleSheets::ensureDefaultStyleSheetsForElement):
- css/CSSStyleSheet.cpp:
(WebCore::isAcceptableCSSStyleSheetParent):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
- css/StyleSheetList.cpp:
(WebCore::StyleSheetList::getNamedItem):
- dom/CurrentScriptIncrementer.h:
(WebCore::CurrentScriptIncrementer::CurrentScriptIncrementer):
- dom/DataTransfer.cpp:
(WebCore::DataTransfer::setDragImage):
- dom/DocumentOrderedMap.cpp:
(WebCore::keyMatchesMapName):
(WebCore::keyMatchesLowercasedMapName):
(WebCore::keyMatchesLowercasedUsemap):
(WebCore::keyMatchesLabelForAttribute):
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
- dom/Node.cpp:
(WebCore::Node::enclosingLinkEventParentOrSelf):
- dom/Position.cpp:
(WebCore::endsOfNodeAreVisuallyDistinctPositions):
- dom/ScriptElement.cpp:
(WebCore::toScriptElementIfPossible):
- dom/VisitedLinkState.cpp:
(WebCore::linkHashForElement):
(WebCore::VisitedLinkState::determineLinkStateSlowCase):
- dom/make_names.pl:
(printTypeHelpers):
- editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
- editing/Editor.cpp:
(WebCore::imageElementFromImageDocument):
- editing/FrameSelection.cpp:
(WebCore::scanForForm):
- editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::doApply):
- editing/InsertParagraphSeparatorCommand.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::removeHeadContents):
- editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_processElement):
- editing/htmlediting.cpp:
(WebCore::isNonTableCellHTMLBlockElement):
- editing/markup.cpp:
(WebCore::ancestorToRetainStructureAndAppearanceForBlock):
(WebCore::collectElementsToRemoveFromFragment):
- html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
- html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::findAssociatedForm):
- html/HTMLAnchorElement.cpp:
(WebCore::appendServerMapMousePosition):
- html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::imageElement):
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::bgColor):
(WebCore::HTMLDocument::setBgColor):
(WebCore::HTMLDocument::fgColor):
(WebCore::HTMLDocument::setFgColor):
(WebCore::HTMLDocument::alinkColor):
(WebCore::HTMLDocument::setAlinkColor):
(WebCore::HTMLDocument::linkColor):
(WebCore::HTMLDocument::setLinkColor):
(WebCore::HTMLDocument::vlinkColor):
(WebCore::HTMLDocument::setVlinkColor):
(WebCore::HTMLDocument::isFrameSet):
- html/HTMLElement.cpp:
(WebCore::HTMLElement::setInnerHTML):
- html/HTMLFieldSetElement.cpp:
(WebCore::updateFromControlElementsAncestorDisabledStateUnder):
(WebCore::HTMLFieldSetElement::disabledStateChanged):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::computeIsDisabledByFieldsetAncestor):
- html/HTMLFormControlsCollection.cpp:
(WebCore::HTMLFormControlsCollection::HTMLFormControlsCollection):
(WebCore::HTMLFormControlsCollection::formControlElements):
(WebCore::HTMLFormControlsCollection::formImageElements):
(WebCore::HTMLFormControlsCollection::namedItem):
(WebCore::HTMLFormControlsCollection::updateNamedElementCache):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::rendererIsNeeded):
- html/HTMLFrameElementBase.h:
(WebCore::isHTMLFrameElementBase):
- html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::dispatchLoadEvent):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::dataList):
- html/HTMLLegendElement.cpp:
(WebCore::HTMLLegendElement::virtualForm):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):
- html/HTMLNameCollection.cpp:
(WebCore::WindowNameCollection::elementMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::elementMatches):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::ownerDataListElement):
(WebCore::HTMLOptionElement::textIndentedToRespectGroupLabel):
(WebCore::HTMLOptionElement::isDisabledFormControl):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::recalcListItems):
- html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::caption):
- html/HTMLTablePartElement.cpp:
(WebCore::HTMLTablePartElement::findParentTable):
- html/HTMLTableRowElement.cpp:
(WebCore::HTMLTableRowElement::rowIndex):
- html/HTMLTableRowsCollection.cpp:
(WebCore::HTMLTableRowsCollection::rowAfter):
(WebCore::HTMLTableRowsCollection::lastRow):
- html/HTMLTagNames.in:
- html/LabelsNodeList.cpp:
(WebCore::LabelsNodeList::elementMatches):
- html/MediaDocument.cpp:
(WebCore::descendentVideoElement):
(WebCore::ancestorVideoElement):
- html/RadioInputType.cpp:
(WebCore::RadioInputType::handleKeydownEvent):
- html/RadioNodeList.cpp:
(WebCore::RadioNodeList::RadioNodeList):
(WebCore::RadioNodeList::checkElementMatchesRadioNodeListFilter):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::hasImpliedEndTag):
(WebCore::insert):
(WebCore::HTMLConstructionSite::insertHTMLFormElement):
(WebCore::HTMLConstructionSite::insertTextNode):
(WebCore::HTMLConstructionSite::ownerDocumentForCurrentNode):
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isScopeMarker):
(WebCore::HTMLNames::isTableScopeMarker):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately):
(WebCore::HTMLTreeBuilder::processEndTag):
(WebCore::HTMLTreeBuilder::processCharacterBuffer):
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForNode):
- inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyleSheet::inlineStyleSheetText):
- page/DragController.cpp:
(WebCore::DragController::draggableElement):
- page/FocusController.cpp:
(WebCore::FocusController::advanceFocusDirectionally):
- page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):
- page/SpatialNavigation.cpp:
(WebCore::FocusCandidate::FocusCandidate):
(WebCore::areElementsOnSameLine):
- page/ios/FrameIOS.mm:
(WebCore::ancestorRespondingToClickEvents):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::mediaSupportsFullscreen):
(WebCore::HitTestResult::mediaElement):
(WebCore::HitTestResult::enterFullscreenForVideo):
(WebCore::HitTestResult::mediaIsVideo):
(WebCore::HitTestResult::isLiveLink):
- rendering/RenderCounter.cpp:
(WebCore::planCounter):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::RenderImage):
(WebCore::RenderImage::paintAreaElementFocusRing):
(WebCore::RenderImage::paintIntoRect):
(WebCore::RenderImage::imageMap):
(WebCore::RenderImage::updateAltText):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):
- rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::marqueeSpeed):
- rendering/RenderMenuList.cpp:
(RenderMenuList::itemText):
(RenderMenuList::itemIsEnabled):
(RenderMenuList::itemIsLabel):
- rendering/RenderMeter.cpp:
(WebCore::RenderMeter::meterElement):
- rendering/RenderObject.cpp:
(WebCore::RenderObject::shouldRespectImageOrientation):
(WebCore::RenderObject::getTextDecorationColors):
(WebCore::RenderObject::offsetParent):
- rendering/RenderProgress.cpp:
(WebCore::RenderProgress::progressElement):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
(WebCore::RenderTable::convertStyleLogicalHeightToComputedHeight):
- svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::imageForRenderer):
- testing/Internals.cpp:
(WebCore::Internals::updateLayoutIgnorePendingStylesheetsAndRunPostLayoutTasks):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startElementNs):
Source/WebKit/win:
Use is<HTML*Element>() instead of isHTML*Element().
- DOMCoreClasses.cpp:
(DOMElement::createInstance):
- DOMHTMLClasses.cpp:
(DOMHTMLFormElement::action):
(DOMHTMLFormElement::method):
- WebFrame.cpp:
(formElementFromDOMElement):
Source/WebKit2:
Use is<HTML*Element>() instead of isHTML*Element().
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::htmlIFrameElementContentFrame):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::containsAnyFormElements):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::determinePrimarySnapshottedPlugIn):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getAssistedNodeInformation):
- 4:16 PM Changeset in webkit [173979] by
-
- 10 edits2 adds in trunk/Tools
EWS only repeats its cycle every two hours
https://bugs.webkit.org/show_bug.cgi?id=137129
Reviewed by Ryosuke Niwa.
- QueueStatusServer/app.yaml: Updated version.
- QueueStatusServer/config/queues.py: Moved timeout from activeworkitems.py to configuration.
- QueueStatusServer/handlers/releaselock.py: Added. Releases the lock without removing
the patch from work items.
- QueueStatusServer/index.yaml: No real change, just let AppEngine have its way with entry order.
- QueueStatusServer/main.py: Added release-lock.
- QueueStatusServer/model/activeworkitems.py:
(ActiveWorkItems.deactivate_expired): Use timeout from configuration.
- QueueStatusServer/model/workitems.py: Added move_to_end. When we unlock a patch,
we don't want it to be immediately picked up again, it's better to give other patches
a chance.
- QueueStatusServer/templates/releaselock.html: Added. Not sure why all commands have
these interactive versions, but OK.
- Scripts/webkitpy/tool/commands/earlywarningsystem.py: (AbstractEarlyWarningSystem.review_patch):
Unlock the patch when a non-final failure occurs (e.g. can't build even without the patch,
or svn is down).
- Scripts/webkitpy/tool/commands/queues.py:
(AbstractReviewQueue.process_work_item): Do not try/catch ScriptError around review_patch.
Style queue never raises these, and EWS already calls _did_fail, before re-throwing,
meaning that these handlers could never do the right thing. We'd either get a duplicate
_did_fail, or try to unlock an already unlocked patch.
(StyleQueue.review_patch): Unlock the patch on transient failure (such as svn failure),
making it eligible for retry immediately.
- Scripts/webkitpy/common/net/statusserver.py:
(StatusServer._post_release_lock):
(StatusServer.release_lock):
Added a call to release-lock.
- 2:59 PM Changeset in webkit [173978] by
-
- 8 edits in trunk/Source
Source/JavaScriptCore:
Web Replay: Check event loop input extents during replaying too
https://bugs.webkit.org/show_bug.cgi?id=136316
Reviewed by Timothy Hatcher.
Sometimes we see different nondeterminism during capture and replay
executions, so we should add determinism checks during replay too.
Move the withinEventLoopInputExtent flag to the base class, and tighten
the assertion to address <http://webkit.org/b/133019>.
- replay/InputCursor.h:
(JSC::InputCursor::InputCursor):
(JSC::InputCursor::setWithinEventLoopInputExtent): Added.
This assertion is slightly wrong because it does not account for nested run loops.
We can be within two input extents when a nested run loop processes additional
user inputs while the debugger is paused.
This should only be the case when execution is being neither captured or
replayed. The debugger should not pause when capturing, and we should not replay
event loop inputs while in a nested run loop.
(JSC::InputCursor::withinEventLoopInputExtent): Added.
Source/WebCore:
Web Replay: Check event loop input extents during replay too
https://bugs.webkit.org/show_bug.cgi?id=136316
Reviewed by Timothy Hatcher.
Sometimes we see different nondeterminism during capture and replay
executions, so we should support determinism checks during replay too.
Move the withinEventLoopInputExtent flag to the base class.
No new tests, no behavior changed.
- replay/CapturingInputCursor.cpp:
(WebCore::CapturingInputCursor::CapturingInputCursor):
(WebCore::CapturingInputCursor::setWithinEventLoopInputExtent): Deleted.
- replay/CapturingInputCursor.h:
- replay/EventLoopInput.cpp:
(WebCore::EventLoopInputExtent::EventLoopInputExtent):
(WebCore::EventLoopInputExtent::~EventLoopInputExtent):
Make m_cursor a pointer and add a new constructor so we can conditionally
enter event loop input extents. This is useful in some network replay situations.
- replay/EventLoopInput.h:
- replay/ReplayController.cpp:
(WebCore::ReplayController::willDispatchEvent): Expand the assertion to include replaying.
- 2:53 PM Changeset in webkit [173977] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: sort probe details sidebar sections by source code location string
https://bugs.webkit.org/show_bug.cgi?id=137080
Reviewed by Timothy Hatcher.
Probe sections should display in the same order as associated breakpoint tree elements.
- UserInterface/Views/ProbeDetailsSidebarPanel.js:
(WebInspector.ProbeDetailsSidebarPanel.prototype.inspect.inspectedProbeSets):
(WebInspector.ProbeDetailsSidebarPanel.prototype.inspect):
- 2:45 PM Changeset in webkit [173976] by
-
- 2 edits in trunk/Tools
[Windows] Followup to r173972. Don’t set child process to none before reading from stdout.
- Scripts/webkitpy/common/system/path.py:
(_CygPath.convert):
- 2:05 PM Changeset in webkit [173975] by
-
- 2 edits in trunk/Source/WebKit2
Expand WK_MAC_TBA and WK_IOS_TBA to the current deployment target version (or NA).
https://bugs.webkit.org/show_bug.cgi?id=137127
Part of rdar://problem/17761459.
Reviewed by Dan Bernstein.
- mac/rewrite-availability-macros.sh:
- 1:35 PM Changeset in webkit [173974] by
-
- 3 edits in trunk/Source/WebCore
Race in ref pointer for WebVideoFullscreenInterfaceAVKit.
https://bugs.webkit.org/show_bug.cgi?id=137123
Patch by Jeremy Jones <jeremyj@apple.com> on 2014-09-25
Reviewed by Eric Carlson.
Add WebThreadRun to prevent race with RefPtr of WebVideoFullscreenInterfaceAVKit.
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(-[WebVideoFullscreenController didSetupFullscreen]): add WebThreadRun
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::setDuration): ditto
(WebVideoFullscreenInterfaceAVKit::setCurrentTime): ditto
(WebVideoFullscreenInterfaceAVKit::setRate): ditto
(WebVideoFullscreenInterfaceAVKit::setVideoDimensions): ditto
(WebVideoFullscreenInterfaceAVKit::setSeekableRanges): ditto
(WebVideoFullscreenInterfaceAVKit::setAudioMediaSelectionOptions): ditto
(WebVideoFullscreenInterfaceAVKit::setLegibleMediaSelectionOptions): ditto
(WebVideoFullscreenInterfaceAVKit::setExternalPlayback): ditto
(WebVideoFullscreenInterfaceAVKit::setupFullscreen): ditto
(WebVideoFullscreenInterfaceAVKit::enterFullscreen): ditto
(WebVideoFullscreenInterfaceAVKit::exitFullscreen): ditto
(WebVideoFullscreenInterfaceAVKit::cleanupFullscreen): ditto
(WebVideoFullscreenInterfaceAVKit::requestHideAndExitFullscreen): ditto
- 12:30 PM Changeset in webkit [173973] by
-
- 2 edits in trunk/Source/WebKit2
CommitLayerTree decode fails in 32-bit apps on 64-bit devices (TransformationMatrix alignment differs)
https://bugs.webkit.org/show_bug.cgi?id=136444
<rdar://problem/17952526>
Reviewed by Anders Carlsson.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<TransformationMatrix>::encode):
(IPC::ArgumentCoder<TransformationMatrix>::decode):
Stop using SimpleArgumentCoder to encode/decode TransformationMatrix,
because the alignment of TransformationMatrix differs between architectures,
and there's no guarantee that both sides of a connection are the same architecture.
- 12:21 PM Changeset in webkit [173972] by
-
- 2 edits in trunk/Tools
[Windows] Close stdin to force a flush to stdout if no test path is read during layout tests.
- Scripts/webkitpy/common/system/path.py:
(_CygPath.convert):
- 10:26 AM Changeset in webkit [173971] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed iOS build fix after r173944.
Add a missing header include.
See <rdar://problem/18454708> for more details.
- html/parser/HTMLTreeBuilder.cpp:
- 10:25 AM Changeset in webkit [173970] by
-
- 41 edits in trunk/Source/WebCore
Stop using legacy NODE_TYPE_CASTS() macro in svg/
https://bugs.webkit.org/show_bug.cgi?id=137106
Reviewed by Ryosuke Niwa.
Stop using legacy NODE_TYPE_CASTS() in svg/ and use the new
SPECIALIZE_TYPE_TRAITS_*() macro instead so that is<>() / downcast<>()
can be used for those types.
No new tests, no behavior change.
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
- dom/Element.h:
- dom/Node.h:
(WebCore::is):
- dom/make_names.pl:
(printTypeHelpers):
- html/HTMLElement.h:
- html/HTMLMediaElement.h:
- html/HTMLPlugInImageElement.h:
- html/LabelableElement.h:
- mathml/MathMLElement.h:
Rename NodeTypeCastTraits::is() to NodeTypeCastTraits::isType() to
avoid naming conflict with the global is<>() function. This was an
issue when is<>() was called from one of the template specializations.
- rendering/svg/RenderSVGBlock.h:
(WebCore::RenderSVGBlock::graphicsElement):
- rendering/svg/RenderSVGGradientStop.cpp:
(WebCore::RenderSVGGradientStop::gradientElement):
- rendering/svg/RenderSVGInline.h:
(WebCore::RenderSVGInline::graphicsElement):
- rendering/svg/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::pathOnlyClipping):
- rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::transformOnNonScalingStroke):
- rendering/svg/RenderSVGShape.h:
(WebCore::RenderSVGShape::graphicsElement):
- rendering/svg/RenderSVGTransformableContainer.h:
- rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::updateMaskedAncestorShouldIsolateBlending):
- rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::operator<<):
- rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
- rendering/svg/SVGResources.cpp:
(WebCore::targetReferenceFromResource):
- svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler):
- svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::isSVGAnimateElement): Deleted.
Use is<>() / downcast<>() where appropriate.
- svg/SVGAnimateElement.h:
(WebCore::isSVGAnimateElement):
Use SPECIALIZE_TYPE_TRAITS_*() instead of NODE_TYPE_CASTS() and add
overload for isSVGAnimateElement() taking an SVGElement in argument to
bypass the is<SVGElement>() check when the input type is an SVGElement.
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::currentValuesForValuesAnimation):
- svg/SVGElement.cpp:
(WebCore::SVGElement::getBoundingBox):
Use is<>() / downcast<>() where appropriate.
- svg/SVGElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.h:
Use SPECIALIZE_TYPE_TRAITS_*() instead of NODE_TYPE_CASTS() and drop
the pre-existing NodeTypeCastTraits template specialization as it is
now generated by the macro.
- svg/SVGGradientElement.cpp:
(WebCore::isSVGGradientElement): Deleted.
- svg/SVGGradientElement.h:
(WebCore::isSVGGradientElement):
Use SPECIALIZE_TYPE_TRAITS_*() instead of NODE_TYPE_CASTS() and add
overload for isSVGAnimateElement() taking an SVGElement in argument to
bypass the is<SVGElement>() check when the input type is an SVGElement.
- svg/SVGGraphicsElement.h:
(WebCore::isSVGGraphicsElement):
Use SPECIALIZE_TYPE_TRAITS_*() instead of NODE_TYPE_CASTS().
- svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::collectGradientAttributes):
- svg/SVGLocatable.cpp:
(WebCore::SVGLocatable::getTransformToElement):
- svg/SVGPolyElement.cpp:
(WebCore::SVGPolyElement::synchronizePoints):
(WebCore::SVGPolyElement::lookupOrCreatePointsWrapper):
(WebCore::isSVGPolyElement): Deleted.
Use is<>() / downcast<>() where appropriate.
- svg/SVGPolyElement.h:
(WebCore::isSVGPolyElement):
Use SPECIALIZE_TYPE_TRAITS_*() instead of NODE_TYPE_CASTS() and add
overload for isPolyElement() taking an SVGElement in argument to
bypass the is<SVGElement>() check when the input type is an SVGElement.
- svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::collectGradientAttributes):
- svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::synchronizeTextLength):
(WebCore::SVGTextContentElement::lookupOrCreateTextLengthWrapper):
(WebCore::SVGTextContentElement::elementFromRenderer):
Use is<>() / downcast<>() where appropriate.
- svg/SVGTextContentElement.h:
WebCore::isSVGTextContentElement):
Use SPECIALIZE_TYPE_TRAITS_*() instead of NODE_TYPE_CASTS().
- svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::toClipPath):
Use is<>() / downcast<>() where appropriate. Also use tighter typing
for value returned by shadowTreeElement().
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::buildPendingResource):
(WebCore::SVGSMILElement::connectConditions):
(WebCore::SVGSMILElement::disconnectConditions):
Use is<>() / downcast<>() where appropriate.
- svg/animation/SVGSMILElement.h:
(WebCore::isSVGSMILElement):
Use SPECIALIZE_TYPE_TRAITS_*() instead of NODE_TYPE_CASTS() and drop
the pre-existing NodeTypeCastTraits template specialization as it is
now generated by the macro.
- 10:23 AM Changeset in webkit [173969] by
-
- 4 edits in trunk/Source/WebCore
Minor refactoring to mediaType/presentationType
https://bugs.webkit.org/show_bug.cgi?id=137085
Reviewed by Eric Carlson.
Add overloads for presentationType for the audio and video
HTML elements so that we don't have to explicity check the
tag name (via string comparison) to identify the type of
element.
No new tests. Should create no change in behavior.
- html/HTMLAudioElement.h: Overload presentationType to always
indicate audio type.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaType): Use the presentationType
method implementation, rather than duplicating that code.
- html/HTMLVideoElement.h: Overload presentationType to always
return video type.
- 9:17 AM Changeset in webkit [173968] by
-
- 4 edits in releases/WebKitGTK/webkit-2.4
Unreviewed. Update NEWS and Versions.m4 for 2.4.6 release.
.:
- Source/autotools/Versions.m4: Bump version numbers.
Source/WebKit/gtk:
- NEWS: Added release notes for 2.4.6.
- 9:11 AM Changeset in webkit [173967] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebInspectorUI
Unreviewed. Fix make distcheck.
- GNUmakefile.am: Files in EXTRA_DIST need to be explicitly listed.
- 7:54 AM Changeset in webkit [173966] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed typo fix.
- UIProcess/API/C/soup/WKContextSoup.cpp:
- 7:50 AM Changeset in webkit [173965] by
-
- 3 edits2 adds in trunk
ASSERTION FAILED: columnCount in WebCore::CSSParser::parseGridTemplateAreasRow
https://bugs.webkit.org/show_bug.cgi?id=136945
Reviewed by Sergio Villar Senin.
Source/WebCore:
Checking out whether the grid-template-areas value contains a white-space only
string, which is not valid as it does not produce a cell token.
Test: fast/css-grid-layout/grid-template-areas-empty-string-crash.html
- css/CSSParser.cpp:
(WebCore::CSSParser::parseGridTemplateAreasRow):
LayoutTests:
Testing the different types of white-space only strings for the grid-template-areas
property, which is not valid as it does not produce a cell token.
- fast/css-grid-layout/grid-template-areas-empty-string-crash-expected.txt: Added.
- fast/css-grid-layout/grid-template-areas-empty-string-crash.html: Added.
- 7:45 AM Changeset in webkit [173964] by
-
- 4 edits in trunk
[Gtk] build.sh needs a -- before make options when the build command is cmake --build
https://bugs.webkit.org/show_bug.cgi?id=136377
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2014-09-25
Reviewed by Philippe Normand.
.:
- Source/cmake/OptionsGTK.cmake: Only create the build.sh script
for CMake versions less than 3.
Tools:
- Scripts/webkitdirs.pm:
(buildCMakeGeneratedProject): Only use the build.sh script if it exists.
- 7:21 AM Changeset in webkit [173963] by
-
- 9 edits in releases/WebKitGTK/webkit-2.4/Tools
Unreviewed. Get rid of runtime warnings about deprecated properties and signals, since they break the tests.
- TestWebKitAPI/Tests/WebKitGtk/testcontextmenu.c:
(main):
- TestWebKitAPI/Tests/WebKitGtk/testdownload.c:
(main):
- TestWebKitAPI/Tests/WebKitGtk/testfavicondatabase.c:
(main):
- TestWebKitAPI/Tests/WebKitGtk/testhittestresult.c:
(main):
- TestWebKitAPI/Tests/WebKitGtk/testloading.c:
(main):
- TestWebKitAPI/Tests/WebKitGtk/testmimehandling.c:
(main):
- TestWebKitAPI/Tests/WebKitGtk/testwebresource.c:
(main):
- TestWebKitAPI/Tests/WebKitGtk/testwebview.c:
- 7:05 AM Changeset in webkit [173962] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2
Merge r173252 - [SOUP] Race condition when downloading a file due to the intermediate temporary file
https://bugs.webkit.org/show_bug.cgi?id=136423
Patch by Michael Catanzaro <Michael Catanzaro> on 2014-09-03
Reviewed by Carlos Garcia Campos.
- Shared/Downloads/soup/DownloadSoup.cpp:
(WebKit::DownloadClient::DownloadClient): Replace m_destinationURI with
m_destinationFile and add m_createdDestination.
(WebKit::DownloadClient::deleteFilesIfNeeded): Added.
(WebKit::DownloadClient::downloadFailed): Call deleteFilesIfNeeded.
(WebKit::DownloadClient::didReceiveResponse): Attempt to create the
destination file before the intermediate file. Fail here if the file
exists and overwrite is not allowed, so we don't erroneously fire the
didCreateDestination event or waste time downloading the file when we
know the download will fail.
(WebKit::DownloadClient::didFinishLoading): Unconditionally overwrite
the empty destination file.
(WebKit::DownloadClient::cancel): Call deleteFilesIfNeeded.
(WebKit::DownloadClient::deleteIntermediateFileInNeeded): Deleted.
- 6:56 AM Changeset in webkit [173961] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2
Merge r173154 - [SOUP] WebKitDownload cannot overwrite existing file
https://bugs.webkit.org/show_bug.cgi?id=136322
Patch by Michael Catanzaro <Michael Catanzaro> on 2014-09-01
Reviewed by Carlos Garcia Campos.
- Shared/Downloads/soup/DownloadSoup.cpp:
(WebKit::DownloadClient::didReceiveResponse): pass a member variable
to Download::decideDestinationWithSuggestedFilename instead of a
temporary bool, so we can use the result in didFinishLoading.
(WebKit::DownloadClient::didFinishLoading): overwrite the destination
if Download::decideDestinationWithSuggestedFilename determined we
should do so.
- 6:49 AM Changeset in webkit [173960] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebKit2
Merge r173658 - [GTK] Typo in webkit_security_manager_register_uri_scheme_as_empty_document documentation
https://bugs.webkit.org/show_bug.cgi?id=136852
Patch by Tomas Popela <tpopela@redhat.com> on 2014-09-16
Reviewed by Carlos Garcia Campos.
- UIProcess/API/gtk/WebKitSecurityManager.cpp:
- 6:46 AM Changeset in webkit [173959] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore
Merge r172928 - [GStreamer] ASSERT failure in WebKitWebSource in StreamingClient
https://bugs.webkit.org/show_bug.cgi?id=136132
adoptGRef() has an ASSERT failure if it's used on a floating pointer. For some reason,
WebKitWebSrc* src in StreamingClient's constructor is floating. Since we
don't construct this ourselves, I assume this is happening in Playbin.
If we remove the ref and adopt, GRefPtr's constructor calls gst_object_ref_sink,
which removes the floating reference and doesn't increment the reference count.
This should work, but actually causes the page to either lock up or crash (different
results for different testers).
In this case, it seems like the adoptGRef / gst_object_ref was the correct thing to do,
but adoptGRef won't actually let us do. Removing the ASSERT is a bad idea, because
usually we don't want to adopt floating pointers.
This is all a long way of saying that making m_src a raw pointer and manually
calling gst_object_ref(), and calling gst_object_unref in the destructor is the
best solution in this case, since it fixes the problem while leaving the ASSERT
to protect us in the much more common case where adopting a floating reference is bad.
Reviewed by Philippe Normand.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient::StreamingClient): Make m_src a raw pointer instead of a GRefPtr.
(StreamingClient::~StreamingClient): Unref m_src.
(StreamingClient::createReadBuffer): Replace m_src.get() with m_src, since it's a raw pointer now.
(StreamingClient::handleResponseReceived): Same.
(StreamingClient::handleDataReceived): Same.
(StreamingClient::handleNotifyFinished): Same.
(CachedResourceStreamingClient::notifyFinished): Same.
(ResourceHandleStreamingClient::didFail): Same.
(ResourceHandleStreamingClient::wasBlocked): Same.
(ResourceHandleStreamingClient::cannotShowURL): Same.
- 6:39 AM Changeset in webkit [173958] by
-
- 2 edits in trunk/Tools
[EFL] Split the list of dependencies to make sure that at least the universally available packages get installed
https://bugs.webkit.org/show_bug.cgi?id=137117
Tools/efl/install-dependencies relies on apt-get to install packages.
Unfortunately, if a package does not exist (e.g., for a given
architecture) then apt-get install is not able to ignore the missing
package and install the rest but fails to run entirely (and there
seems to be no intent to change this behaviour).
On ARM64, the luajit package is missing and currently it needs manual
editing of install-dependencies to get the script install as much as it
can.
This patch separates the installation of the universally available
packages from those which might not be available for all architectures.
Patch by Akos Kiss <akiss@inf.u-szeged.hu> on 2014-09-25
Reviewed by Gyuyoung Kim.
- efl/install-dependencies:
- 6:39 AM Changeset in webkit [173957] by
-
- 1 edit in releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog
Merge r172896 - [GTK] Toggle buttons visually broken with GTK+ 3.13.7
https://bugs.webkit.org/show_bug.cgi?id=136130
Patch by Michael Catanzaro <Michael Catanzaro> on 2014-08-24
Reviewed by Martin Robinson.
No new tests. Hopefully covered by existing tests, and our tests only
run with GTK+ 3.6 anyway.
- platform/gtk/RenderThemeGtk3.cpp:
(WebCore::paintToggle): use GTK_STATE_FLAG_CHECKED when compiling for
GTK+ 3.13.7 and above to ensure toggle buttons display as toggled.
- 6:31 AM Changeset in webkit [173956] by
-
- 2 edits in releases/WebKitGTK/webkit-2.4/Source/WebCore
Merge r172958 - [GTK] Selection background is rendered white when unfocused with recent GTK+
https://bugs.webkit.org/show_bug.cgi?id=136251
Reviewed by Martin Robinson.
This is due to a change in the GTK+ theme, but because we are not
using the right flags to get the selections colors. We should use
GTK_STATE_FLAG_SELECTED | GTK_STATE_FLAG_FOCUSED when focused and
GTK_STATE_FLAG_SELECTED when unfocused, instead of
GTK_STATE_FLAG_ACTIVE when unfocused.
- platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::platformActiveSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformInactiveSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformActiveSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformInactiveSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformActiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformInactiveListBoxSelectionBackgroundColor):
(WebCore::RenderThemeGtk::platformActiveListBoxSelectionForegroundColor):
(WebCore::RenderThemeGtk::platformInactiveListBoxSelectionForegroundColor):
- 6:25 AM Changeset in webkit [173955] by
-
- 4 edits6 adds in releases/WebKitGTK/webkit-2.4
Merge r173809 - [GStreamer] Cannot play Vimeo video
https://bugs.webkit.org/show_bug.cgi?id=134969
Reviewed by Sergio Villar Senin.
Source/WebCore:
Ensure the GStreamer HTTP source element also sends cookies when
it's sending its requests. Some streaming platforms such as Vimeo
do server-side cookie checks on incoming requests before serving
media data.
Test: http/tests/media/hls/video-cookie.html
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webKitWebSrcStart): Set first-party cookie URL to the request so
the ResourceLoader properly sets cookies in the HTTP request.
- 6:13 AM Changeset in webkit [173954] by
-
- 3 edits189 adds in releases/WebKitGTK/webkit-2.4
Merge r173753 - Webkitgtk 2.5.3: tarball contains APPLE LICENSE file - stating not distributable
https://bugs.webkit.org/show_bug.cgi?id=136632
Reviewed by Gustavo Noronha Silva.
Source/WebInspectorUI:
Add free icons for the GTK port. These icons are from the GNOME
project, some of them adapted by Andres Gomez for the inspector.
- 6:10 AM Changeset in webkit [173953] by
-
- 5 edits in releases/WebKitGTK/webkit-2.4
Merge r173751 - [GTK] generate-inspector-gresource-manifest.py should receive the list of files from the makefile
https://bugs.webkit.org/show_bug.cgi?id=136943
Reviewed by Philippe Normand.
Source/WebKit2:
- PlatformGTK.cmake: Fix the inspector file list and pass it to
the generate-inspector-gresource-manifest.py script.
Tools:
Update the script to receive the list of files from the command
line instead of scanning the given directories.
- gtk/generate-inspector-gresource-manifest.py:
(get_filenames): Convert filenames to use relative paths.
(find_all_files_in_directory): Deleted.
(find_all_files_in_directory.select_file): Deleted.
- 4:26 AM Changeset in webkit [173952] by
-
- 3 edits29 adds in trunk/Source/WebInspectorUI
Unreviewed. Add more free icons for the Web Inspector in GTK+.
Patch by Andres Gomez <Andres Gomez> on 2014-09-25
- UserInterface/Images/gtk/AUTHORS:
- UserInterface/Images/gtk/ApplicationCacheManifest.png: Added.
- UserInterface/Images/gtk/ApplicationCacheManifest@2x.png: Added.
- UserInterface/Images/gtk/COPYING:
- UserInterface/Images/gtk/COPYING_LGPL2: Added.
- UserInterface/Images/gtk/Cookie.png: Added.
- UserInterface/Images/gtk/Cookie@2x.png: Added.
- UserInterface/Images/gtk/HoverMenuButton.png: Added.
- UserInterface/Images/gtk/HoverMenuButton@2x.png: Added.
- UserInterface/Images/gtk/InstructionPointer.png: Added.
- UserInterface/Images/gtk/InstructionPointer@2x.png: Added.
- UserInterface/Images/gtk/Log.png: Added.
- UserInterface/Images/gtk/Log@2x.png: Added.
- UserInterface/Images/gtk/Profile.png: Added.
- UserInterface/Images/gtk/Profile@2x.png: Added.
- UserInterface/Images/gtk/Recording.png: Added.
- UserInterface/Images/gtk/Recording@2x.png: Added.
- UserInterface/Images/gtk/RecordingHovered.png: Added.
- UserInterface/Images/gtk/RecordingHovered@2x.png: Added.
- UserInterface/Images/gtk/RecordingStopped.png: Added.
- UserInterface/Images/gtk/RecordingStopped@2x.png: Added.
- UserInterface/Images/gtk/Script.png: Added.
- UserInterface/Images/gtk/Script@2x.png: Added.
- UserInterface/Images/gtk/ScriptLarge.png: Added.
- UserInterface/Images/gtk/ScriptLarge@2x.png: Added.
- UserInterface/Images/gtk/SliderThumb.png: Added.
- UserInterface/Images/gtk/SliderThumb@2x.png: Added.
- UserInterface/Images/gtk/SliderThumbPressed.png: Added.
- UserInterface/Images/gtk/SliderThumbPressed@2x.png: Added.
- UserInterface/Images/gtk/Stopwatch.png: Added.
- UserInterface/Images/gtk/Stopwatch@2x.png: Added.
- 3:51 AM Changeset in webkit [173951] by
-
- 3 edits in trunk/Source/WebKit2
[WebKit2] Fix build warning in WebKit2/WebProcess module.
https://bugs.webkit.org/show_bug.cgi?id=137105
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-09-25
Reviewed by Csaba Osztrogonác.
Fix build warning by removing unused parameter names
- WebProcess/WebPage/WebInspector.h:
(WebKit::WebInspector::didReceiveInvalidMessage):
- WebProcess/WebPage/WebInspectorUI.h:
(WebKit::WebInspectorUI::didReceiveInvalidMessage):
- 3:36 AM Changeset in webkit [173950] by
-
- 1 delete in trunk/Source/WebKit/wince
Unreviewed, delete the empty Source/WebKit/wince/ChangeLog after r173949.
- 3:14 AM Changeset in webkit [173949] by
-
- 101 edits54 deletes in trunk
Remove WinCE port from trunk
https://bugs.webkit.org/show_bug.cgi?id=136951
Reviewed by Alex Christensen.
.:
- Source/cmake/OptionsWinCE.cmake: Removed.
- Source/cmake/WebKitPackaging.cmake:
Source/JavaScriptCore:
- assembler/ARMAssembler.h:
(JSC::ARMAssembler::cacheFlush):
- assembler/ARMv7Assembler.h:
(JSC::ARMv7Assembler::cacheFlush):
- config.h:
- heap/MachineStackMarker.cpp:
(JSC::MachineThreads::gatherFromCurrentThread):
(JSC::MachineThreads::gatherFromOtherThread):
(JSC::swapIfBackwards): Deleted.
- jit/ExecutableAllocator.h:
- jsc.cpp:
(main):
- runtime/DateConstructor.cpp:
- runtime/Options.cpp:
(JSC::overrideOptionWithHeuristic):
- runtime/VM.cpp:
(JSC::VM::VM):
- testRegExp.cpp:
(main):
- tools/CodeProfiling.cpp:
(JSC::CodeProfiling::notifyAllocator):
Source/WebCore:
- Modules/encryptedmedia/CDMPrivateMediaPlayer.cpp:
- PlatformWinCE.cmake: Removed.
- accessibility/AXObjectCache.cpp:
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::modifyMovingRight):
- loader/icon/wince/IconDatabaseWinCE.cpp: Removed.
- page/EventHandler.cpp:
(WebCore::EventHandler::sendContextMenuEventForKey):
- page/Settings.cpp:
- page/win/EventHandlerWin.cpp:
(WebCore::EventHandler::createDraggingDataTransfer):
- platform/ContextMenu.h:
- platform/DragImage.cpp:
- platform/FileSystem.h:
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::mayFillWithSolidColor):
- platform/graphics/FontGlyphs.cpp:
(WebCore::FontGlyphs::glyphDataAndPageForCharacter):
- platform/graphics/FontPlatformData.h:
- platform/graphics/ImageBufferData.h:
- platform/graphics/MediaPlayer.cpp:
- platform/graphics/SimpleFontData.h:
- platform/graphics/opentype/OpenTypeUtilities.cpp:
(WebCore::renameAndActivateFont):
- platform/graphics/opentype/OpenTypeUtilities.h:
- platform/graphics/win/DIBPixelData.cpp:
(WebCore::DIBPixelData::setRGBABitmapAlpha):
- platform/graphics/win/GDIExtras.cpp: Removed.
- platform/graphics/win/GDIExtras.h:
(WebCore::hasAlphaBlendSupport):
(WebCore::alphaBlendIfSupported):
- platform/graphics/win/IconWin.cpp:
(WebCore::Icon::createIconForFiles):
(WebCore::Icon::paint):
- platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::initGDIFont):
(WebCore::SimpleFontData::platformDestroy):
(WebCore::SimpleFontData::boundsForGDIGlyph):
(WebCore::SimpleFontData::widthForGDIGlyph):
(WebCore::SimpleFontData::scriptFontProperties):
- platform/graphics/wince/FontCacheWinCE.cpp: Removed.
- platform/graphics/wince/FontCustomPlatformData.cpp: Removed.
- platform/graphics/wince/FontCustomPlatformData.h: Removed.
- platform/graphics/wince/FontPlatformData.cpp: Removed.
- platform/graphics/wince/FontPlatformData.h: Removed.
- platform/graphics/wince/FontWinCE.cpp: Removed.
- platform/graphics/wince/GlyphPageTreeNodeWinCE.cpp: Removed.
- platform/graphics/wince/GradientWinCE.cpp: Removed.
- platform/graphics/wince/GraphicsContextWinCE.cpp: Removed.
- platform/graphics/wince/ImageBufferDataWince.h: Removed.
- platform/graphics/wince/ImageBufferWinCE.cpp: Removed.
- platform/graphics/wince/ImageWinCE.cpp: Removed.
- platform/graphics/wince/MediaPlayerPrivateWinCE.h: Removed.
- platform/graphics/wince/MediaPlayerProxy.cpp: Removed.
- platform/graphics/wince/MediaPlayerProxy.h: Removed.
- platform/graphics/wince/PathWinCE.cpp: Removed.
- platform/graphics/wince/PlatformPathWinCE.cpp: Removed.
- platform/graphics/wince/PlatformPathWinCE.h: Removed.
- platform/graphics/wince/SharedBitmap.cpp: Removed.
- platform/graphics/wince/SharedBitmap.h: Removed.
- platform/graphics/wince/SimpleFontDataWinCE.cpp: Removed.
- platform/graphics/wince/WinCEGraphicsExtras.h: Removed.
- platform/image-decoders/jpeg/JPEGImageDecoder.h:
- platform/network/win/NetworkStateNotifierWin.cpp:
(WebCore::NetworkStateNotifier::NetworkStateNotifier):
- platform/win/COMPtr.h:
- platform/win/ClipboardUtilitiesWin.cpp:
- platform/win/ContextMenuItemWin.cpp:
- platform/win/ContextMenuWin.cpp:
(WebCore::ContextMenu::getContextMenuItems):
(WebCore::ContextMenu::createPlatformContextMenuFromItems):
- platform/win/DragImageWin.cpp:
(WebCore::dragLabelFont):
- platform/win/FileSystemWin.cpp:
(WebCore::pathByAppendingComponent):
(WebCore::pathGetFileName):
(WebCore::storageDirectory):
- platform/win/LoggingWin.cpp:
(WebCore::logLevelString):
- platform/win/PasteboardWin.cpp:
(WebCore::PasteboardOwnerWndProc):
(WebCore::Pasteboard::createForCopyAndPaste):
(WebCore::pathRemoveBadFSCharacters):
(WebCore::filesystemPathFromUrlOrTitle):
(WebCore::createGlobalHDropContent):
- platform/win/PlatformMouseEventWin.cpp:
(WebCore::messageToEventType):
(WebCore::PlatformMouseEvent::PlatformMouseEvent):
- platform/win/PlatformScreenWin.cpp:
(WebCore::deviceInfoForWidget):
(WebCore::screenIsMonochrome):
- platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::show):
(WebCore::PopupMenuWin::paint):
(WebCore::PopupMenuWin::registerClass):
(WebCore::PopupMenuWin::wndProc):
- platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::paintButton):
- platform/win/SharedBufferWin.cpp:
- platform/win/SharedTimerWin.cpp:
(WebCore::TimerWindowWndProc):
(WebCore::initializeOffScreenTimerWindow):
(WebCore::queueTimerProc):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):
- platform/win/SoftLinking.h:
- platform/win/SystemInfo.cpp:
(WebCore::windowsVersion):
(WebCore::processorArchitecture):
(WebCore::architectureTokenForUAString):
- platform/win/WCDataObject.cpp:
(WebCore::WCDataObject::CopyMedium):
- plugins/PluginDatabase.cpp:
- plugins/PluginView.cpp:
(WebCore::PluginView::stop):
- plugins/PluginViewNone.cpp:
- plugins/win/PluginDatabaseWin.cpp:
(WebCore::addWindowsMediaPlayerPluginDirectory):
(WebCore::addMacromediaPluginDirectories):
- plugins/win/PluginPackageWin.cpp:
(WebCore::PluginPackage::load):
- plugins/win/PluginViewWin.cpp:
(WebCore::setUpOffscreenPaintingHooks):
(WebCore::registerPluginView):
(WebCore::PluginView::wndProc):
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paintIntoTransformedContext):
(WebCore::PluginView::paint):
(WebCore::PluginView::handleMouseEvent):
(WebCore::PluginView::setParent):
(WebCore::PluginView::setNPWindowRect):
(WebCore::PluginView::platformStart):
- rendering/RenderThemeWinCE.cpp: Removed.
- rendering/RenderThemeWinCE.h: Removed.
- storage/wince/DatabaseThreadWinCE.cpp: Removed.
- storage/wince/DatabaseThreadWinCE.h: Removed.
- storage/wince/StorageThreadWinCE.cpp: Removed.
- storage/wince/StorageThreadWinCE.h: Removed.
Source/WebKit:
- PlatformWinCE.cmake: Removed.
- wince/WebCoreSupport/ChromeClientWinCE.cpp: Removed.
- wince/WebCoreSupport/ChromeClientWinCE.h: Removed.
- wince/WebCoreSupport/ContextMenuClientWinCE.cpp: Removed.
- wince/WebCoreSupport/ContextMenuClientWinCE.h: Removed.
- wince/WebCoreSupport/DragClientWinCE.cpp: Removed.
- wince/WebCoreSupport/DragClientWinCE.h: Removed.
- wince/WebCoreSupport/EditorClientWinCE.cpp: Removed.
- wince/WebCoreSupport/EditorClientWinCE.h: Removed.
- wince/WebCoreSupport/FrameLoaderClientWinCE.cpp: Removed.
- wince/WebCoreSupport/FrameLoaderClientWinCE.h: Removed.
- wince/WebCoreSupport/FrameNetworkingContextWinCE.cpp: Removed.
- wince/WebCoreSupport/FrameNetworkingContextWinCE.h: Removed.
- wince/WebCoreSupport/InspectorClientWinCE.cpp: Removed.
- wince/WebCoreSupport/InspectorClientWinCE.h: Removed.
- wince/WebCoreSupport/PlatformStrategiesWinCE.cpp: Removed.
- wince/WebCoreSupport/PlatformStrategiesWinCE.h: Removed.
- wince/WebView.cpp: Removed.
- wince/WebView.h: Removed.
Source/WebKit/cf:
- WebCoreSupport/WebInspectorClientCF.cpp:
Source/WTF:
- config.h:
- wtf/Assertions.cpp:
- wtf/Assertions.h:
- wtf/Atomics.h:
(WTF::weakCompareAndSwap):
- wtf/CurrentTime.cpp:
(WTF::lowResUTCTime):
- wtf/DataLog.cpp:
- wtf/DateMath.cpp:
(WTF::getLocalTime):
(WTF::calculateDSTOffset):
- wtf/FastMalloc.cpp:
- wtf/FeatureDefines.h:
- wtf/OSAllocator.h:
(WTF::OSAllocator::decommitAndRelease):
- wtf/Platform.h:
- wtf/PlatformWin.cmake:
- wtf/RAMSize.cpp:
(WTF::computeRAMSize):
- wtf/RandomNumberSeed.h:
(WTF::initializeRandomNumberGenerator):
- wtf/StackBounds.cpp:
(WTF::StackBounds::initialize):
- wtf/StackBounds.h:
(WTF::StackBounds::isGrowingDownward):
- wtf/StdLibExtras.h:
(wtf_bsearch): Deleted.
- wtf/StringExtras.h:
(strnicmp): Deleted.
(stricmp): Deleted.
(strdup): Deleted.
- wtf/ThreadSpecific.h:
- wtf/ThreadingWin.cpp:
(WTF::createThreadInternal):
- wtf/WindowsExtras.h:
(WTF::getRegistryValue):
(WTF::getWindowPointer):
(WTF::setWindowPointer):
- wtf/dtoa/utils.h:
- wtf/text/WTFString.cpp:
(WTF::String::format):
Tools:
- BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
(_should_file_trigger_build):
- BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
(ShouldBuildTest):
- CMakeLists.txt:
- DumpRenderTree/win/DRTDataObject.cpp:
(DRTDataObject::CopyMedium):
- Scripts/build-webkit:
- Scripts/webkit-build-directory:
- Scripts/webkitdirs.pm:
(argumentsForConfiguration):
(builtDylibPathForName):
(isAppleWinWebKit):
(launcherPath):
(launcherName):
(shouldRemoveCMakeCache):
(cmakeBasedPortArguments):
(cmakeBasedPortName):
(isCMakeBuild):
(isWinCE): Deleted.
(determineIsWinCE): Deleted.
- Scripts/webkitperl/FeatureList.pm:
- Scripts/webkitpy/port/port_testcase.py:
(test_apache_config_file_name_for_platform):
- TestWebKitAPI/config.h:
- WinCELauncher/CMakeLists.txt: Removed.
- WinCELauncher/main.cpp: Removed.
- gtk/manifest.txt:
- 2:44 AM Changeset in webkit [173948] by
-
- 3 edits in trunk/LayoutTests
[GTK] Unreviewed GTK gardening.
Patch by Lorenzo Tilve <ltilve@igalia.com> on 2014-09-25
- platform/gtk/TestExpectations: Report and mark new failures after r173515 and r173582.
- platform/gtk/fast/dom/Document/CaretRangeFromPoint/hittest-relative-to-viewport-expected.txt:
Update expectations after r173857.
- 2:36 AM Changeset in webkit [173947] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed. Fix GTK+ build after r173944.
- page/ContextMenuController.cpp: Add missing include.
- 2:27 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
Sep 24, 2014:
- 9:30 PM Changeset in webkit [173946] by
-
- 2 edits in trunk/Source/WebKit/ios
[iOS] Another iOS build fix; workaround for CoreLocation
https://bugs.webkit.org/show_bug.cgi?id=137104
<rdar://problem/18450785>
Rubber-stamped by Benjamin Poulain.
Workaround CoreLocation issue by adding a default statement in -[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]
and -[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:].
We'll remove these default statements once we have the fix for <rdar://problem/18448331>.
- Misc/WebGeolocationCoreLocationProvider.mm:
(-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):
(-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]):
- 9:02 PM Changeset in webkit [173945] by
-
- 2 edits in trunk/Source/WebCore
Use tighter typing for render objects in RenderGeometryMap
https://bugs.webkit.org/show_bug.cgi?id=137102
Reviewed by Ryosuke Niwa.
Use tighter typing for render objects in RenderGeometryMap for clarity
and efficiency.
In particular, using RenderElement type instead of RenderObject
in canMapBetweenRenderers() allows us to call the faster
RenderElement::style() instead of RenderObject::style().
No new tests, no behavior change.
- rendering/RenderGeometryMap.cpp:
(WebCore::canMapBetweenRenderers):
(WebCore::RenderGeometryMap::pushMappingsToAncestor):
- 8:50 PM Changeset in webkit [173944] by
-
- 39 edits in trunk/Source
Add initial is<>() / downcast<>() support for any type of Nodes
https://bugs.webkit.org/show_bug.cgi?id=137056
Reviewed by Benjamin Poulain.
Source/WebCore:
Add initial is<>() / downcast<>() support for any type of Nodes, not
just Elements by:
- Moving the is<>() / downcast<>() declarations from Element.h to Node.h
- Introducing a SPECIALIZE_TYPE_TRAITS_*() macro that generates the needed template specializations for is<>() / downcast<>() to work. This macro will replace NODE_TYPE_CASTS() entirely once the code base is fully ported.
This patch makes use of SPECIALIZE_TYPE_TRAITS_*() macro for
HTMLFormControlElement, that is an HTMLElement for which the template
specializations cannot be automatically generated because it requires
special handling.
This patch also makes use of SPECIALIZE_TYPE_TRAITS_*() macro for
DocumentFragment to show that it can be used for non-Element Nodes.
No new tests, no behavior change.
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::isRequired):
(WebCore::AccessibilityNodeObject::isControl):
- css/SelectorCheckerTestFunctions.h:
(WebCore::isAutofilled):
(WebCore::isDisabled):
(WebCore::isEnabled):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::adjustRenderStyle):
- dom/Document.cpp:
(WebCore::Document::importNode):
(WebCore::Document::setFocusedElement):
- dom/DocumentFragment.h:
(WebCore::isDocumentFragment):
- dom/Element.cpp:
(WebCore::Element::focus):
- dom/Element.h:
(WebCore::is): Deleted.
(WebCore::downcast): Deleted.
- dom/Node.h:
(WebCore::is):
(WebCore::downcast):
- dom/make_names.pl:
(printTypeHelpers):
- editing/FrameSelection.cpp:
(WebCore::scanForForm):
- editing/TextIterator.cpp:
(WebCore::isRendererReplacedElement):
- html/FormAssociatedElement.h:
- html/HTMLElement.h:
- html/HTMLFieldSetElement.cpp:
(WebCore::updateFromControlElementsAncestorDisabledStateUnder):
(WebCore::HTMLFieldSetElement::refreshElementsIfNeeded):
- html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::enclosingFormControlElement):
- html/HTMLFormControlElement.h:
(WebCore::isHTMLFormControlElement):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::submitImplicitly):
(WebCore::submitElementFromEvent):
(WebCore::HTMLFormElement::validateInteractively):
(WebCore::HTMLFormElement::submit):
(WebCore::HTMLFormElement::reset):
(WebCore::HTMLFormElement::formElementIndex):
(WebCore::HTMLFormElement::defaultButton):
(WebCore::HTMLFormElement::checkInvalidControlsAndCollectUnhandled):
(WebCore::HTMLFormElement::documentDidResumeFromPageCache):
- html/HTMLMediaElement.h:
- html/HTMLPlugInImageElement.h:
- html/HTMLSummaryElement.cpp:
(WebCore::isClickableControl):
- html/LabelableElement.h:
- html/RadioNodeList.cpp:
(WebCore::RadioNodeList::checkElementMatchesRadioNodeListFilter):
(WebCore::RadioNodeList::elementMatches):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::findFosterSite):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::disallowTelephoneNumberParsing):
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
- mathml/MathMLElement.h:
- page/ContextMenuController.cpp:
(WebCore::ContextMenuController::populate):
- page/Frame.cpp:
(WebCore::Frame::searchForLabelsBeforeElement):
- rendering/RenderButton.cpp:
(WebCore::RenderButton::formControlElement):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::resize):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isReadOnlyControl):
- svg/SVGElement.h:
- svg/SVGFilterPrimitiveStandardAttributes.h:
- svg/animation/SVGSMILElement.h:
Source/WebKit/mac:
Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
instead of isFormControlElement() / toHTMLFormControlElement().
- WebView/WebHTMLRepresentation.mm:
(searchForLabelsBeforeElement):
Source/WebKit/win:
Use is<HTMLFormControlElement>() / downcast<HTMLFormControlElement>()
instead of isFormControlElement() / toHTMLFormControlElement().
- WebFrame.cpp:
(WebFrame::elementWithName):
- 7:53 PM Changeset in webkit [173943] by
-
- 8 edits3 adds in trunk
Old Turkic characters behave as left-to-right instead of right-to-left, because they are encoded as surrogate pairs.
https://bugs.webkit.org/show_bug.cgi?id=70029
Reviewed by Dan Bernstein.
Source/WebCore:
Test: fast/text/international/old-turkic-direction.html
- CMakeLists.txt: Added InlineIterator.cpp.
- WebCore.vcxproj/WebCore.vcxproj: Ditto.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- rendering/RenderingAllInOne.cpp: Ditto.
- rendering/InlineIterator.cpp: Added.
(WebCore::InlineIterator::surrogateTextDirection): New function used to compute the direction
when a surrogate pair is involved.
- rendering/InlineIterator.h: Made the characterAt function private.
(WebCore::InlineIterator::previousInSameNode): Took out unneeded range check. A zero will underflow
and become a large number and the characterAt function will return 0 in that case.
(WebCore::InlineIterator::direction): Added code to check U16_IS_SINGLE before calling
u_charDirection, and call surrogateTextDirection instead.
LayoutTests:
- fast/text/international/old-turkic-direction.html: Added.
- fast/text/international/old-turkic-direction-expected.html: Added.
- 7:46 PM Changeset in webkit [173942] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r173941.
Rename shadow to m_shadow.
- rendering/TextPainter.h:
(WebCore::ShadowApplier::shadowIsCompletelyCoveredByText):
- 7:32 PM Changeset in webkit [173941] by
-
- 9 edits2 deletes in trunk
REGRESSION: Text with a zero offset, zero blur shadow vanishes
https://bugs.webkit.org/show_bug.cgi?id=136801
Reviewed by Darin Adler.
Source/WebCore:
This patch performs some cleanup regarding TextPainter's shadow logic and handles an
additional case of empty shadows. Previously, there was tight coupling between
applyShadowToGraphicalContext() and paintTextWithShadows(), as they both used a
collection of variables to determine how shadows are to be drawn. This complexity has
been moved into a helper class, ShadowApplier, which performs what
applyShadowToGraphicsContext() used to do, and cleans up correctly in its destructor.
This removes the tight coupling mentioned earlier.
Test: fast/text/empty-shadow.html
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::applyShadowToGraphicsContext): Moved to ShadowApplier.
- rendering/InlineTextBox.h: Deleted applyShadowToGraphicsContext signature.
- rendering/TextPainter.cpp:
(WebCore::ShadowApplier::ShadowApplier): Perform the contents of applyShadowToGraphicsContext()
(WebCore::ShadowApplier::~ShadowApplier): Undo the work done previously
(WebCore::paintTextWithShadows): Create a ShadowApplier to do the relevant shadow work. In addition,
refactor some boolean flags to more meaningful ones with relation to the computation at hand.
(WebCore::isEmptyShadow): Moved to TextPainter.h, named shadowIsCompletelyCoveredByText()
- rendering/TextPainter.h:
(WebCore::ShadowApplier::ShadowApplier): Moved from InlineTextBox::applyShadowToGraphicsContext().
(WebCore::ShadowApplier::extraOffset): Getter.
(WebCore::ShadowApplier::~ShadowApplier): Moved from TextPainter::paintTextWithShadows().
(WebCore::isLastShadowIteration): Helper function.
(WebCore::shadowIsCompletelyCoveredByText): Determines whether or not we should not draw the shadow.
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paintTextWithShadows): Update to use ShadowApplier.
LayoutTests:
This test should be a comprehensive test of empty shadows. It tests every
combination of one and two shadows being empty, as well as transparent and
opaque text.
After updating fast/text/empty-shadow.html, fast/text/empty-shadow-with-color.html
is no longer necessary.
- fast/text/empty-shadow-expected.html:
- fast/text/empty-shadow-with-color-expected.html: Removed.
- fast/text/empty-shadow-with-color.html: Removed.
- fast/text/empty-shadow.html:
- 7:17 PM Changeset in webkit [173940] by
-
- 2 edits in trunk/Source/WebKit/ios
[iOS] Fix the iOS build; add case statements for kCLAuthorizationStatusAuthorized
https://bugs.webkit.org/show_bug.cgi?id=137101
<rdar://problem/18449815>
Reviewed by Mark Lam.
- Misc/WebGeolocationCoreLocationProvider.mm:
(-[WebGeolocationCoreLocationProvider requestGeolocationAuthorization]):
(-[WebGeolocationCoreLocationProvider locationManager:didChangeAuthorizationStatus:]):
- 5:25 PM Changeset in webkit [173939] by
-
- 6 edits in trunk/Source
Web Inspector: subtract elapsed time while debugger is paused from profile nodes
https://bugs.webkit.org/show_bug.cgi?id=136796
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
Rather than accruing no time to any profile node created while the debugger is paused,
we can instead count a node's elapsed time and exclude time elapsed while paused.
Time for a node may elapse in a non-contiguous fashion depending on the interleaving of
didPause, didContinue, willExecute, and didExecute. A node's start time is set to the
start of the last such interval that accrues elapsed time.
- profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::ProfileGenerator):
(JSC::ProfileGenerator::beginCallEntry):
(JSC::ProfileGenerator::endCallEntry):
(JSC::ProfileGenerator::didPause): Added.
(JSC::ProfileGenerator::didContinue): Added.
- profiler/ProfileGenerator.h:
(JSC::ProfileGenerator::didPause): Deleted.
(JSC::ProfileGenerator::didContinue): Deleted.
- profiler/ProfileNode.h: Rename totalTime to elapsedTime.
(JSC::ProfileNode::Call::Call):
(JSC::ProfileNode::Call::elapsedTime): Added.
(JSC::ProfileNode::Call::setElapsedTime): Added.
(JSC::CalculateProfileSubtreeDataFunctor::operator()):
(JSC::ProfileNode::Call::totalTime): Deleted.
(JSC::ProfileNode::Call::setTotalTime): Deleted.
Source/WebCore:
- inspector/TimelineRecordFactory.cpp:
(WebCore::buildInspectorObject):
- 4:29 PM Changeset in webkit [173938] by
-
- 2 edits in trunk/Source/WebKit/win
Unreviewed build fix after r173932.
Unreviewed build fix after r173932 for Windows. Use WebCore:: namespace
explicitely in DOMCoreClasses.cpp.
- DOMCoreClasses.cpp:
(DOMElement::createInstance):
- 4:28 PM Changeset in webkit [173937] by
-
- 5 edits in trunk/Tools
[iOS] run-webkit-tests should support minor versions under devices and create a testing device under the right runtime
https://bugs.webkit.org/show_bug.cgi?id=136895
Reviewed by David Kilzer.
Create Device, DeviceType, and Runtime data classes.
Create Simulator class represent simctl output.
Wherever possible, use structured data classes anywhere a raw
identifier or UDID string was used for a cleaner implementation
and to encapsulate the inherent fragility of scraping simctl output.
Create a suitably named testing device if one doesn't exist.
Finally, accurately handle having multiple simulator runtimes (SDKs)
installed in the active Xcode.app bundle.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
- Scripts/webkitpy/port/driver.py:
(IOSSimulatorDriver.cmd_line):
Construct DeviceType and Runtime objects from identifiers passed at the
command line, still providing sensible defaults for 32- and 64-bit testing.
- Scripts/webkitpy/port/ios.py:
(IOSSimulatorPort.init):
(IOSSimulatorPort.setup_test_run):
(IOSSimulatorPort):
(IOSSimulatorPort.testing_device):
Cache the testing device once it is created or found.
(IOSSimulatorPort.reset_preferences):
Get the device path from the Device object instead of consructing it
in the port class.
(IOSSimulatorPort.simulator_udid): Deleted.
Get the UDID from the testing_device :: Device object itself.
- Scripts/webkitpy/xcode/simulator.py:
Created Device, DeviceType, Runtime, and Simulator classes.
(get_runtimes): Deleted.
(get_devices): Deleted.
(get_device_types): Deleted.
(get_latest_runtime): Deleted.
- 4:11 PM Changeset in webkit [173936] by
-
- 1 edit in trunk/Source/WebKit/mac/WebCoreSupport/WebInspectorClient.mm
Attempt to fix crash seen on bots.
- 3:07 PM Changeset in webkit [173935] by
-
- 2 edits in trunk/Source/WTF
Do the bmalloc.
https://bugs.webkit.org/show_bug.cgi?id=132629
Reviewed by Gavin Barraclough.
64-bit only for now, just to try it out.
- wtf/FastMalloc.cpp:
- 3:02 PM Changeset in webkit [173934] by
-
- 2 edits in trunk/Source/WebKit2
Remove incorrect use of the BKSProcessAssertionAllowSuspendOnSleep flag for process suspension in iOS WebKit2
<rdar://problem/18400566>
https://bugs.webkit.org/show_bug.cgi?id=137077
Reviewed by Anders Carlsson.
- UIProcess/ios/ProcessAssertionIOS.mm:
Remove use of the BKSProcessAssertionAllowSuspendOnSleep which does not do what we expect, and instead
causes processes to be suspended "forever" after sleep.
- 2:41 PM Changeset in webkit [173933] by
-
- 2 edits in trunk/Source/WebKit2/UIProcess
Fix 32-bit Mac build.
- 2:25 PM Changeset in webkit [173932] by
-
- 72 edits in trunk/Source
Use is<HTML*Element>() instead of isHTML*Element() - Part 1
https://bugs.webkit.org/show_bug.cgi?id=137068
Reviewed by Ryosuke Niwa.
Start using is<HTML*Element>() instead of isHTML*Element().
Remaining usages will be updated in a follow-up patch to
reduce the size of the change.
Source/WebCore:
No new tests, no behavior change.
- accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::isSelected):
(WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):
(WebCore::AccessibilityListBoxOption::stringValue):
(WebCore::AccessibilityListBoxOption::listBoxOptionParentNode):
- accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaTimeline::valueDescription):
- accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::setElement):
- accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::determineAccessibilityRole):
(WebCore::AccessibilityNodeObject::isNativeTextControl):
(WebCore::AccessibilityNodeObject::isNativeImage):
(WebCore::AccessibilityNodeObject::isInputImage):
(WebCore::AccessibilityNodeObject::isReadOnly):
(WebCore::AccessibilityNodeObject::valueForRange):
(WebCore::AccessibilityNodeObject::maxValueForRange):
(WebCore::AccessibilityNodeObject::minValueForRange):
(WebCore::isNodeActionElement):
(WebCore::AccessibilityNodeObject::titleElementText):
(WebCore::AccessibilityNodeObject::visibleText):
(WebCore::AccessibilityNodeObject::title):
(WebCore::AccessibilityNodeObject::colorValue):
(WebCore::accessibleNameForNode):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::isFileUploadButton):
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::setValue):
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::addTextFieldChildren):
- accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::notifyChildrenSelectionChange):
- css/SelectorCheckerTestFunctions.h:
(WebCore::isDisabled):
(WebCore::isEnabled):
(WebCore::isChecked):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
- dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchEvent):
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::selectAll):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::shouldPerformSmartReplace):
- editing/VisibleSelection.cpp:
(WebCore::VisibleSelection::isInPasswordField):
- editing/cocoa/HTMLConverter.mm:
(HTMLConverter::_processElement):
- editing/gtk/EditorGtk.cpp:
(WebCore::elementURL):
- editing/ios/EditorIOS.mm:
(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendText):
(WebCore::isPlainTextMarkup):
(WebCore::collectElementsToRemoveFromFragment):
- html/HTMLCollection.cpp:
(WebCore::isMatchingElement):
- html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::rendererIsNeeded):
- html/HTMLFormControlElement.cpp:
(WebCore::shouldAutofocus):
- html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::getTextFieldValues):
(WebCore::HTMLFormElement::formElementIndex):
- html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::dispatchLoadEvent):
(WebCore::HTMLImageLoader::notifyFinished):
- html/HTMLNameCollection.cpp:
(WebCore::DocumentNameCollection::elementMatchesIfIdAttributeMatch):
(WebCore::DocumentNameCollection::elementMatchesIfNameAttributeMatch):
(WebCore::DocumentNameCollection::elementMatches):
- html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::recalcSelectOptions):
(WebCore::HTMLOptGroupElement::ownerSelectElement):
- html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::index):
(WebCore::HTMLOptionElement::ownerSelectElement):
- html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::add):
(WebCore::HTMLSelectElement::value):
(WebCore::HTMLSelectElement::setValue):
(WebCore::HTMLSelectElement::childShouldCreateRenderer):
(WebCore::HTMLSelectElement::setLength):
(WebCore::HTMLSelectElement::nextValidIndex):
(WebCore::HTMLSelectElement::saveLastSelection):
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::listBoxOnChange):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::selectedIndex):
(WebCore::HTMLSelectElement::selectOption):
(WebCore::HTMLSelectElement::optionToListIndex):
(WebCore::HTMLSelectElement::listToOptionIndex):
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
(WebCore::HTMLSelectElement::saveFormControlState):
(WebCore::HTMLSelectElement::searchOptionsForValue):
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::reset):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
(WebCore::HTMLSelectElement::lastSelectedListIndex):
(WebCore::HTMLSelectElement::optionAtIndex):
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex):
(WebCore::HTMLSelectElement::length):
- html/HTMLTagNames.in:
- html/RadioInputType.cpp:
(WebCore::RadioInputType::handleKeydownEvent):
(WebCore::RadioInputType::isKeyboardFocusable):
- html/parser/HTMLConstructionSite.cpp:
(WebCore::hasImpliedEndTag):
- html/parser/HTMLElementStack.cpp:
(WebCore::HTMLNames::isSelectScopeMarker):
- html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processEndTag):
- html/shadow/MediaControlElementTypes.cpp:
(WebCore::mediaControlElementType):
- loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::handleFallbackContent):
- loader/ImageLoader.cpp:
(WebCore::ImageLoader::dispatchPendingBeforeLoadEvent):
- loader/SubframeLoader.cpp:
(WebCore::SubframeLoader::requestObject):
- loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::create):
- page/Chrome.cpp:
(WebCore::Chrome::setToolTip):
- page/EventHandler.cpp:
(WebCore::isSubmitImage):
(WebCore::EventHandler::handleMousePressEvent):
- page/FocusController.cpp:
(WebCore::clearSelectionIfNeeded):
- page/FrameView.cpp:
(WebCore::FrameView::addEmbeddedObjectToUpdate):
(WebCore::FrameView::updateEmbeddedObject):
- page/PageSerializer.cpp:
(WebCore::frameOwnerURLAttributeName):
- page/SpatialNavigation.cpp:
(WebCore::canScrollInDirection):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::altDisplayString):
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::absolutePDFURL):
(WebCore::HitTestResult::isContentEditable):
- rendering/RenderBlockFlow.cpp:
(WebCore::resizeTextPermitted):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesLogicalWidthToFitContent):
- rendering/RenderButton.cpp:
(WebCore::RenderButton::updateFromElement):
(WebCore::RenderButton::canHaveGeneratedChildren):
- rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::isOpen):
- rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::uploadButton):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::updateAltText):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
(WebCore::RenderListBox::paintItemBackground):
- rendering/RenderMenuList.cpp:
(WebCore::selectedOptionCount):
(RenderMenuList::updateOptionsWidth):
(RenderMenuList::setTextFromOption):
(RenderMenuList::itemText):
(RenderMenuList::itemIsEnabled):
(RenderMenuList::itemIsSelected):
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paintSliderTicks):
- testing/Internals.cpp:
(WebCore::Internals::selectColorInColorChooser):
(WebCore::Internals::wasLastChangeUserEdit):
(WebCore::Internals::isSelectPopupVisible):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::startElementNs):
Source/WebKit/ios:
- WebCoreSupport/WebChromeClientIOS.mm:
(WebChromeClientIOS::focusedElementChanged):
Source/WebKit/mac:
- WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::focusedElementChanged):
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::textFieldDidBeginEditing):
(WebEditorClient::textFieldDidEndEditing):
(WebEditorClient::textDidChangeInTextField):
(WebEditorClient::doTextFieldCommandFromEvent):
(WebEditorClient::textWillBeDeletedInTextField):
(WebEditorClient::textDidChangeInTextArea):
- WebView/WebHTMLRepresentation.mm:
(inputElementFromDOMElement):
Source/WebKit/win:
- DOMCoreClasses.cpp:
(DOMElement::createInstance):
- DOMHTMLClasses.cpp:
(DOMHTMLOptionElement::text):
(DOMHTMLOptionElement::label):
(DOMHTMLInputElement::form):
(DOMHTMLInputElement::disabled):
(DOMHTMLInputElement::readOnly):
(DOMHTMLInputElement::setType):
(DOMHTMLInputElement::value):
(DOMHTMLInputElement::setValue):
(DOMHTMLInputElement::setValueForUser):
(DOMHTMLInputElement::select):
(DOMHTMLInputElement::setSelectionStart):
(DOMHTMLInputElement::selectionStart):
(DOMHTMLInputElement::setSelectionEnd):
(DOMHTMLInputElement::selectionEnd):
(DOMHTMLInputElement::isTextField):
(DOMHTMLInputElement::rectOnScreen):
(DOMHTMLInputElement::replaceCharactersInRange):
(DOMHTMLInputElement::selectedRange):
(DOMHTMLInputElement::setAutofilled):
(DOMHTMLInputElement::isAutofilled):
(DOMHTMLInputElement::isUserEdited):
(DOMHTMLTextAreaElement::form):
(DOMHTMLTextAreaElement::value):
(DOMHTMLTextAreaElement::setValue):
(DOMHTMLTextAreaElement::select):
(DOMHTMLTextAreaElement::isUserEdited):
- WebFrame.cpp:
(inputElementFromDOMElement):
Source/WebKit2:
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementValueForUser):
(WebKit::InjectedBundleNodeHandle::isHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::setHTMLInputElementAutofilled):
(WebKit::InjectedBundleNodeHandle::htmlInputElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::htmlTextAreaElementLastChangeWasUserEdit):
(WebKit::InjectedBundleNodeHandle::isTextField):
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::focusedElementChanged):
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::textFieldDidBeginEditing):
(WebKit::WebEditorClient::textFieldDidEndEditing):
(WebKit::WebEditorClient::textDidChangeInTextField):
(WebKit::WebEditorClient::textDidChangeInTextArea):
(WebKit::WebEditorClient::doTextFieldCommandFromEvent):
(WebKit::WebEditorClient::textWillBeDeletedInTextField):
- WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::containsAnyFormControls):
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::setAssistedNodeValue):
(WebKit::WebPage::setAssistedNodeValueAsNumber):
(WebKit::WebPage::setAssistedNodeSelectedIndex):
- 2:22 PM Changeset in webkit [173931] by
-
- 4 edits in trunk/Source/WebCore
[iOS] Remove MediaPlayer::setHasPlaybackTargetAvailabilityListeners
https://bugs.webkit.org/show_bug.cgi?id=137075
Reviewed by Dean Jackson.
No new tests, this just removes unused code.
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::setHasPlaybackTargetAvailabilityListeners): Deleted.
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::setHasPlaybackTargetAvailabilityListeners): Deleted.
- 1:11 PM Changeset in webkit [173930] by
-
- 4 edits in trunk/Source/WebKit2
Add stub implementation of WKPageIsPlayingAudio().
https://bugs.webkit.org/show_bug.cgi?id=137044
Reviewed by Anders Carlsson.
Also add an isPlayingAudioDidChange callback to WKPageUIClient.
- UIProcess/API/C/WKPage.cpp:
(WKPageIsPlayingAudio):
- UIProcess/API/C/WKPagePrivate.h:
- UIProcess/API/C/WKPageUIClient.h:
- 12:58 PM Changeset in webkit [173929] by
-
- 53 edits1 copy5 adds1 delete in trunk/Source
Make the Web Inspector use a separate web process.
https://bugs.webkit.org/show_bug.cgi?id=135120
Reviewed by Anders Carlsson.
Source/WebCore:
- English.lproj/Localizable.strings: Updated.
- WebCore.exp.in:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/ScriptGlobalObject.h:
- bindings/js/ScriptState.h:
- inspector/InspectorFrontendHost.h:
- inspector/InspectorPageAgent.h:
- page/Chrome.h:
Exported a few functions and private headers.
- inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::setInspectorFrontendClient):
(WebCore::InspectorController::hasInspectorFrontendClient):
(WebCore::InspectorController::show):
- inspector/InspectorController.h:
Make InspectorFrontendClient a pointer instead of a std::unique_ptr.
This makes it easier to implement InspectorFrontendClient as
part of an existing object that is externally owned.
- testing/Internals.cpp:
(WebCore::Internals::openDummyInspectorFrontend):
(WebCore::Internals::closeDummyInspectorFrontend):
- testing/Internals.h:
Change InspectorFrontendClientDummy from being moved to owned.
Source/WebInspectorUI:
- Localizations/en.lproj/localizedStrings.js: Updated.
- UserInterface/Base/Main.js:
(WebInspector.loaded):
(WebInspector.contentLoaded):
Move InspectorFrontendHost.loaded to later in the load.
Calling it early just shows the window before we have
a user interface to show.
- UserInterface/Base/Test.js:
(WebInspector.loaded):
(WebInspector.contentLoaded):
Match the changes in Main.js.
- UserInterface/Protocol/InspectorFrontendAPI.js:
(InspectorFrontendAPI.savedURL): Change comment.
(InspectorFrontendAPI.appendedToURL): Change comment.
(InspectorFrontendAPI.dispatch): Add an assert and early
return to be safe from unknown commands.
(InspectorFrontendAPI.loadCompleted): Delete _pendingCommands,
no need to keep an empty array around a one time use.
Source/WebKit/ios:
- WebCoreSupport/WebInspectorClientIOS.mm:
(WebInspectorClient::WebInspectorClient):
Removed m_frontendClient initialization since it is
now a std::unique_ptr that defaults to nullptr.
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.h:
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::WebInspectorClient):
(WebInspectorClient::openInspectorFrontend):
(WebInspectorClient::releaseFrontend):
Own WebInspectorFrontendClient instead of moving it.
Source/WebKit/win:
- WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::openInspectorFrontend):
- WebCoreSupport/WebInspectorClient.h:
(WebInspectorClient::frontendClient):
Own WebInspectorFrontendClient instead of moving it.
Source/WebKit2:
- CMakeLists.txt:
- DerivedSources.make:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- WebKit2.xcodeproj/project.pbxproj:
Added new WebInspectorUI files and removed WebInspectorFrontendClient.cpp.
- Shared/APIObject.h: Added BundleInspectorUI.
- Shared/EntryPointUtilities/mac/LegacyProcess/ChildProcessEntryPoint.mm:
(WebKit::ChildProcessMainDelegate::getExtraInitializationData):
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:
(WebKit::XPCServiceInitializerDelegate::getExtraInitializationData):
Add support for "inspector-process" data, a boolean that is used by
WebProcess::initializeProcessName.
- UIProcess/API/C/WKInspector.cpp:
(WKInspectorIsDebuggingJavaScript):
(WKInspectorToggleJavaScriptDebugging):
(WKInspectorIsProfilingJavaScript):
(WKInspectorToggleJavaScriptProfiling):
- UIProcess/API/C/WKInspector.h:
Stub out functions we don't support but need to keep for nightly compatibility.
- UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorPageGroups::createInspectorPageGroup):
(WebKit::WebInspectorProxy::WebInspectorProxy):
(WebKit::WebInspectorProxy::invalidate):
(WebKit::WebInspectorProxy::connect):
(WebKit::WebInspectorProxy::showConsole):
(WebKit::WebInspectorProxy::showResources):
(WebKit::WebInspectorProxy::showMainResourceForFrame):
(WebKit::WebInspectorProxy::attach):
(WebKit::WebInspectorProxy::detach):
(WebKit::WebInspectorProxy::inspectorContext):
(WebKit::WebInspectorProxy::dispatchMessageFromRemoteFrontend):
(WebKit::WebInspectorProxy::eagerlyCreateInspectorPage):
(WebKit::WebInspectorProxy::createInspectorPage):
(WebKit::WebInspectorProxy::open):
(WebKit::WebInspectorProxy::didClose):
(WebKit::WebInspectorProxy::attachAvailabilityChanged):
- UIProcess/WebInspectorProxy.h:
(WebKit::WebInspectorProxy::isConnected):
(WebKit::WebInspectorProxy::canAttach):
- UIProcess/WebInspectorProxy.messages.in:
- UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformAttach):
- UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorProxyObjCAdapter close]):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformDidClose):
(WebKit::WebInspectorProxy::platformHide):
(WebKit::WebInspectorProxy::platformSave):
(WebKit::WebInspectorProxy::platformAppend):
(WebKit::WebInspectorProxy::platformAttach):
Changed how the Inspector page is created by making it in a new WebContext for
the Inspector. This removes us from the main process pool and guarantees no process
sharing for our user interface. Also send new WebInspectorUI messages to the Inspector
page and not the inspected page when appropriate.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getLaunchOptions): Add "inspector-process" to extraInitializationData
if the context is the Inspector context. This is used by WebProcess::initializeProcessName.
- WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::openInspectorFrontend):
(WebKit::WebInspectorClient::closeInspectorFrontend):
(WebKit::WebInspectorClient::bringFrontendToFront):
- WebProcess/WebCoreSupport/WebInspectorClient.h:
Remove the InspectorFrontendChannel class from WebInspectorClient and clean up a little.
InspectorFrontendChannel implementation moved to WebInspector.
- WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp: Removed. Superseded by WebInspectorUI.
- WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::create):
(WebKit::WebInspector::WebInspector):
(WebKit::WebInspector::createInspectorPage):
(WebKit::WebInspector::closeFrontend):
(WebKit::WebInspector::openInNewTab):
(WebKit::WebInspector::showConsole):
(WebKit::WebInspector::showResources):
(WebKit::WebInspector::showMainResourceForFrame):
(WebKit::WebInspector::startPageProfiling):
(WebKit::WebInspector::stopPageProfiling):
(WebKit::WebInspector::canAttachWindow):
(WebKit::WebInspector::updateDockingAvailability):
(WebKit::WebInspector::sendMessageToBackend):
(WebKit::WebInspector::sendMessageToFrontend):
(WebKit::WebInspector::remoteFrontendConnected):
(WebKit::WebInspector::remoteFrontendDisconnected):
- WebProcess/WebPage/WebInspector.h:
(WebKit::WebInspector::didClose):
(WebKit::WebInspector::didReceiveInvalidMessage):
(WebKit::WebInspector::setAttached):
- WebProcess/WebPage/WebInspector.messages.in:
Stop taking an optional InspectorFrontendChannel and inherit it instead. Create a connection that
can be passed to the other web process for WebInspectorUI to use. Stop referencing Inspector's page
directly, since it is in another process now.
- WebProcess/WebPage/WebInspectorUI.cpp: Added.
(WebKit::WebInspectorUI::create):
(WebKit::WebInspectorUI::WebInspectorUI):
(WebKit::WebInspectorUI::establishConnection):
(WebKit::WebInspectorUI::windowObjectCleared):
(WebKit::WebInspectorUI::frontendLoaded):
(WebKit::WebInspectorUI::moveWindowBy):
(WebKit::WebInspectorUI::bringToFront):
(WebKit::WebInspectorUI::closeWindow):
(WebKit::WebInspectorUI::requestSetDockSide):
(WebKit::WebInspectorUI::setDockSide):
(WebKit::WebInspectorUI::changeAttachedWindowHeight):
(WebKit::WebInspectorUI::changeAttachedWindowWidth):
(WebKit::WebInspectorUI::setToolbarHeight):
(WebKit::WebInspectorUI::openInNewTab):
(WebKit::WebInspectorUI::save):
(WebKit::WebInspectorUI::append):
(WebKit::WebInspectorUI::inspectedURLChanged):
(WebKit::WebInspectorUI::showConsole):
(WebKit::WebInspectorUI::showResources):
(WebKit::WebInspectorUI::showMainResourceForFrame):
(WebKit::WebInspectorUI::startPageProfiling):
(WebKit::WebInspectorUI::stopPageProfiling):
(WebKit::WebInspectorUI::didSave):
(WebKit::WebInspectorUI::didAppend):
(WebKit::WebInspectorUI::sendMessageToFrontend):
(WebKit::WebInspectorUI::sendMessageToBackend):
(WebKit::WebInspectorUI::evaluateCommandOnLoad):
(WebKit::WebInspectorUI::evaluateExpressionOnLoad):
(WebKit::WebInspectorUI::evaluatePendingExpressions):
- WebProcess/WebPage/WebInspectorUI.h: Added.
(WebKit::WebInspectorUI::page):
(WebKit::WebInspectorUI::didClose):
(WebKit::WebInspectorUI::didReceiveInvalidMessage):
(WebKit::WebInspectorUI::attachedBottom):
(WebKit::WebInspectorUI::attachedRight):
(WebKit::WebInspectorUI::detached):
(WebKit::WebInspectorUI::evaluateCommandOnLoad):
- WebProcess/WebPage/WebInspectorUI.messages.in: Added.
- WebProcess/WebPage/efl/WebInspectorUIEfl.cpp: Added.
(WebKit::WebInspectorUI::canSave):
(WebKit::WebInspectorUI::localizedStringsURL):
- WebProcess/WebPage/gtk/WebInspectorUIGtk.cpp: Added.
(WebKit::WebInspectorUI::canSave):
(WebKit::WebInspectorUI::localizedStringsURL):
- WebProcess/WebPage/mac/WebInspectorUIMac.mm: Added.
(WebKit::WebInspectorUI::canSave):
(WebKit::WebInspectorUI::localizedStringsURL):
Implement the InspectorFrontendClient and handle a connection to the inspected page's WebInspector.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
(WebKit::WebPage::~WebPage):
(WebKit::WebPage::inspector):
(WebKit::WebPage::inspectorUI):
(WebKit::WebPage::didReceiveMessage):
Setup as a listener for WebInspectorUI messages.
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::isInspectorPage): It is an Inspector page if we have a m_inspectorUI.
- WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::initializeProcessName):
Name the process "%@ Web Inspector" if it is an Inspector content process. Processes in that
context are not shared with multiple pages.
- 12:57 PM Changeset in webkit [173928] by
-
- 5 edits in trunk/Source/WebCore
[Yosemite] Button text doesn't go white while pushing the button, like it does for real buttons
https://bugs.webkit.org/show_bug.cgi?id=137054
rdar://problem/17559038
Reviewed by NOBODY (OOPS!).
On Yosemite and above, system buttons paint with white-ish text when they
are pressed. Since this isn't exposed by API, I've hardcoded the value
into RenderThemeMac.
The actual state is exposed by adding a :active rule to html.css that
uses a new CSSValueKeyword: ActiveButtonText.
Unfortunately I can't find a way to test this, because the active state isn't
testable. We should really expose the Inspector's forcePseudoState function into
window.internals.
- css/CSSValueKeywords.in: Add "activebuttontext".
- css/html.css:
(input[type="button"]:active, input[type="submit"]:active, input[type="reset"]:active, input[type="file"]::-webkit-file-upload-button:active, button:active): New rule for active
button elements.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::systemColor): Handle CSSValueActivebuttontext as black.
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::systemColor): Handle CSSValueActivebuttontext as
white with 75% opacity.
- 12:52 PM Changeset in webkit [173927] by
-
- 2 edits in trunk/Source/WebKit2
Add a deprecated stub for WKPreferencesSetMultithreadedWebGLEnabled (and Get)
https://bugs.webkit.org/show_bug.cgi?id=137071
Reviewed by Brent Fulgham.
Put in stubs for WKPreferencesSetMultithreadedWebGLEnabled and
WKPreferencesGetMultithreadedWebGLEnabled. These were removed in
r173776 but are still needed for nightly builds to link
(or will be once Yosemite nightlies are available).
- Shared/API/c/WKDeprecatedFunctions.cpp:
(WKPreferencesSetMultithreadedWebGLEnabled):
(WKPreferencesGetMultithreadedWebGLEnabled):
- 12:24 PM Changeset in webkit [173926] by
-
- 2 edits in trunk/Tools
[Windows] Tentative fix for Windows test bots.
- Scripts/webkitpy/common/system/path.py:
(_CygPath.convert):
- 10:30 AM Changeset in webkit [173925] by
-
- 1 edit2 adds in trunk/LayoutTests
Add New Test for overrideMimeType in XMLHttpRequest.
https://bugs.webkit.org/show_bug.cgi?id=137057
Patch by Shivakumar JM <shiva.jm@samsung.com> on 2014-09-24
Reviewed by Alexey Proskuryakov.
As part of bug: https://bugs.webkit.org/show_bug.cgi?id=136699, add more tests to test overrideMimeType for all states.
- http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror-expected.txt: Added.
- http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html: Added.
- 10:26 AM Changeset in webkit [173924] by
-
- 13 edits in trunk/Tools
Change more build.webkit.org links to https
https://bugs.webkit.org/show_bug.cgi?id=137049
Reviewed by Csaba Osztrogonác.
Fix appspot, svn.webkit.org and Trac links.
- BuildSlaveSupport/build.webkit.org-config/master.cfg:
- BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ViewController.js:
(ViewController.prototype._domForBuildName):
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
(.):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/EWS.js:
(EWS):
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Initialization.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitTestHistory.js:
(TestHistory):
- BuildSlaveSupport/build.webkit.org-config/templates/root.html:
- 9:59 AM Changeset in webkit [173923] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Fix the iOS build after <http://trac.webkit.org/changeset/173893>
(https://bugs.webkit.org/show_bug.cgi?id=137007)
Add closing parenthesis characters that were inadvertently removed in <http://trac.webkit.org/changeset/173893>.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::setAssistedNodeSelectedIndex):
(WebKit::WebPage::getAssistedNodeInformation):
- 9:11 AM Changeset in webkit [173922] by
-
- 4 edits in trunk
Update the list of u-szeged contributors.
Rubber-stamped by Csaba Osztrogonác <Csaba Osztrogonác>.
Tools:
- Scripts/webkitpy/common/config/contributors.json:
Websites/webkit.org:
- team.html:
- 8:56 AM Changeset in webkit [173921] by
-
- 34 edits in trunk/Source/WebCore
Use is<SVG*Element>() instead of isSVG*Element()
https://bugs.webkit.org/show_bug.cgi?id=137058
Reviewed by Dirk Schulze.
Use is<SVG*Element>() instead of isSVG*Element() and drop support for
generated isSVG*Element().
No new tests, no behavior change.
- css/CSSCursorImageValue.cpp:
(WebCore::resourceReferencedByCursorElement):
- css/StyleResolver.cpp:
(WebCore::StyleResolver::useSVGZoomRulesForLength):
- dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::collectActiveStyleSheets):
- dom/ScriptElement.cpp:
(WebCore::toScriptElementIfPossible):
- dom/make_names.pl:
(printTypeHelpers):
- editing/gtk/EditorGtk.cpp:
(WebCore::elementURL):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::absoluteImageURL):
(WebCore::HitTestResult::isLiveLink):
- rendering/svg/RenderSVGEllipse.cpp:
(WebCore::RenderSVGEllipse::calculateRadiiAndCenter):
- rendering/svg/RenderSVGTransformableContainer.cpp:
(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
- rendering/svg/SVGPathData.cpp:
(WebCore::updatePathFromCircleElement):
- rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::operator<<):
- rendering/svg/SVGResources.cpp:
(WebCore::targetReferenceFromResource):
- svg/SVGAltGlyphDefElement.cpp:
(WebCore::SVGAltGlyphDefElement::hasValidGlyphElements):
- svg/SVGAltGlyphElement.cpp:
(WebCore::SVGAltGlyphElement::hasValidGlyphElements):
- svg/SVGAnimateMotionElement.cpp:
(WebCore::SVGAnimateMotionElement::hasValidAttributeType):
- svg/SVGDocument.cpp:
(WebCore::SVGDocument::rootElement):
- svg/SVGElement.cpp:
(WebCore::SVGElement::isOutermostSVGSVGElement):
(WebCore::SVGElement::ownerSVGElement):
(WebCore::SVGElement::viewportElement):
- svg/SVGFEComponentTransferElement.cpp:
(WebCore::SVGFEComponentTransferElement::build):
- svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::findLightElement):
- svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
- svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::ensureGlyphCache):
- svg/SVGFontFaceElement.cpp:
(WebCore::SVGFontFaceElement::associatedFontElement):
(WebCore::SVGFontFaceElement::rebuildFontFace):
- svg/SVGFontFaceSrcElement.cpp:
(WebCore::SVGFontFaceSrcElement::srcValue):
(WebCore::SVGFontFaceSrcElement::childrenChanged):
- svg/SVGGlyphElement.cpp:
(WebCore::SVGGlyphElement::invalidateGlyphCache):
- svg/SVGHKernElement.cpp:
(WebCore::SVGHKernElement::insertedInto):
(WebCore::SVGHKernElement::removedFrom):
- svg/SVGLengthContext.cpp:
(WebCore::SVGLengthContext::determineViewport):
- svg/SVGLocatable.cpp:
(WebCore::isViewportElement):
- svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::pathElement):
(WebCore::SVGMPathElement::notifyParentOfPathChange):
- svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::invalidateMPathDependencies):
- svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::collectPatternAttributes):
- svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::setupInitialView):
- svg/SVGUseElement.cpp:
(WebCore::dumpInstanceTree):
(WebCore::SVGUseElement::expandUseElementsInShadowTree):
- svg/SVGVKernElement.cpp:
(WebCore::SVGVKernElement::insertedInto):
(WebCore::SVGVKernElement::removedFrom):
- 8:40 AM WebKitGTK/2.6.x edited by
- (diff)
- 8:11 AM Changeset in webkit [173920] by
-
- 1 copy in releases/WebKitGTK/webkit-2.6.0
WebKitGTK+ 2.6.0
- 8:10 AM Changeset in webkit [173919] by
-
- 4 edits in releases/WebKitGTK/webkit-2.6
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.6.0 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.6.0.
- 6:38 AM Changeset in webkit [173918] by
-
- 3 edits in releases/WebKitGTK/webkit-2.6/Source/JavaScriptCore
Merge r173886 - [CLoop] - Fix CLoop on the 32-bit Big-Endians
https://bugs.webkit.org/show_bug.cgi?id=137020
Patch by Tomas Popela <tpopela@redhat.com> on 2014-09-23
Reviewed by Mark Lam.
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- 6:37 AM Changeset in webkit [173917] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r173848 - WebSocket crash when a connection is closed from server side
https://bugs.webkit.org/show_bug.cgi?id=137009
rdar://problem/18333977
rdar://problem/12708225
Reviewed by Brady Eidson.
I don't think that this can be tested with our test server.
- Modules/websockets/WebSocketChannel.cpp:
(WebCore::WebSocketChannel::WebSocketChannel): Added logging.
(WebCore::WebSocketChannel::~WebSocketChannel): Ditto.
(WebCore::WebSocketChannel::close): Protect self, because startClosingHandshake
can release the last reference.
(WebCore::WebSocketChannel::fail): Added an assertion that the channel is always
closed after this function.
(WebCore::WebSocketChannel::startClosingHandshake): Protect self, and don't change
the stack from closed back to closing if after failing to send closing handshake.
(WebCore::WebSocketChannel::processOutgoingFrameQueue): Protect self.
- 6:36 AM Changeset in webkit [173916] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r173845 - Bad cast in isValidColumnSpanner.
https://bugs.webkit.org/show_bug.cgi?id=133380.
Reviewed by Simon Fraser.
Source/WebCore:
Added fast/multicol/multicol-crazy-nesting.html
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::isValidColumnSpanner):
The crawl up the chain looking for unsplittable objects should use containing blocks
and not be casting to parent boxes. You can have an inline in the parent chain, so
this was not the right way to walk up the tree.
LayoutTests:
- fast/multicol/multicol-crazy-nesting-expected.txt: Added.
- fast/multicol/multicol-crazy-nesting.html: Added.
- 6:35 AM Changeset in webkit [173915] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.6
Merge r173843 - ASSERT in RenderMultiColumnSet::requiresBalancing.
https://bugs.webkit.org/show_bug.cgi?id=136376.
Reviewed by David Kilzer.
Source/WebCore:
Added fast/multicol/multicol-selection.html.
- rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::isValidColumnSpanner):
Don't allow an object to become a spanner if it does not have the flow
thread as its containing block. Otherwise the flow thread won't get notified
of spanner placeholder insertions, and so the spanner ends up orphaned.
LayoutTests:
- fast/multicol/multicol-selection-expected.txt: Added.
- fast/multicol/multicol-selection.html: Added.
- 6:33 AM Changeset in webkit [173914] by
-
- 2 edits in releases/WebKitGTK/webkit-2.6/Source/WebCore
Merge r173836 - REGRESSION(r173631): It broke the !ENABLE(VIDEO) build
https://bugs.webkit.org/show_bug.cgi?id=136946
Reviewed by Jer Noble.
No new tests required, no new functionality.
- page/DragController.cpp:
(WebCore::DragController::startDrag):
- 5:59 AM Changeset in webkit [173913] by
-
- 5 edits1 copy104 adds in releases/WebKitGTK/webkit-2.6/Source/WebInspectorUI
Merge r173912 - Unreviewed. Add more free icons for the Web Inspector in GTK+
Patch by Andres Gomez <Andres Gomez> on 2014-09-24
- UserInterface/Images/gtk/AUTHORS:
- UserInterface/Images/gtk/ApplicationCache.png: Added.
- UserInterface/Images/gtk/ApplicationCache@2x.png: Added.
- UserInterface/Images/gtk/BottomUpTree.svg: Added.
- UserInterface/Images/gtk/Breakpoint.png: Added.
- UserInterface/Images/gtk/Breakpoint@2x.png: Added.
- UserInterface/Images/gtk/BreakpointButton.svg:
- UserInterface/Images/gtk/BreakpointInactive.png: Added.
- UserInterface/Images/gtk/BreakpointInactive@2x.png: Added.
- UserInterface/Images/gtk/BreakpointInactiveButton.svg:
- UserInterface/Images/gtk/COPYING:
- UserInterface/Images/gtk/COPYING_CCBYSA3: Copied from Source/WebInspectorUI/UserInterface/Images/gtk/COPYING.
- UserInterface/Images/gtk/ClippingCSS.png: Added.
- UserInterface/Images/gtk/ClippingCSS@2x.png: Added.
- UserInterface/Images/gtk/ClippingGeneric.png: Added.
- UserInterface/Images/gtk/ClippingGeneric@2x.png: Added.
- UserInterface/Images/gtk/ClippingJS.png: Added.
- UserInterface/Images/gtk/ClippingJS@2x.png: Added.
- UserInterface/Images/gtk/CloseTimeline.png: Added.
- UserInterface/Images/gtk/CloseTimeline@2x.png: Added.
- UserInterface/Images/gtk/ColorIcon.png: Added.
- UserInterface/Images/gtk/ColorIcon@2x.png: Added.
- UserInterface/Images/gtk/Colors.png: Added.
- UserInterface/Images/gtk/Colors@2x.png: Added.
- UserInterface/Images/gtk/ColorsLarge.png: Added.
- UserInterface/Images/gtk/ColorsLarge@2x.png: Added.
- UserInterface/Images/gtk/Database.png: Added.
- UserInterface/Images/gtk/Database@2x.png: Added.
- UserInterface/Images/gtk/DatabaseTable.png: Added.
- UserInterface/Images/gtk/DatabaseTable@2x.png: Added.
- UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg: Added.
- UserInterface/Images/gtk/Issues.svg: Added.
- UserInterface/Images/gtk/IssuesEnabled.svg: Added.
- UserInterface/Images/gtk/LayerBorders.svg: Added.
- UserInterface/Images/gtk/LessColumns.svg: Added.
- UserInterface/Images/gtk/LocalStorage.png: Added.
- UserInterface/Images/gtk/LocalStorage@2x.png: Added.
- UserInterface/Images/gtk/Locked.svg: Added.
- UserInterface/Images/gtk/Logs.svg: Added.
- UserInterface/Images/gtk/Memory.svg: Added.
- UserInterface/Images/gtk/MoreColumns.svg: Added.
- UserInterface/Images/gtk/Native.svg: Added.
- UserInterface/Images/gtk/NavigationItemAngleBrackets.svg: Added.
- UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg: Added.
- UserInterface/Images/gtk/NavigationItemBug.svg: Added.
- UserInterface/Images/gtk/NavigationItemCurleyBraces.svg: Added.
- UserInterface/Images/gtk/NavigationItemFile.svg: Added.
- UserInterface/Images/gtk/NavigationItemLayers.svg: Added.
- UserInterface/Images/gtk/NavigationItemLog.svg: Added.
- UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg: Added.
- UserInterface/Images/gtk/NavigationItemStopwatch.svg: Added.
- UserInterface/Images/gtk/NavigationItemStorage.svg: Added.
- UserInterface/Images/gtk/NavigationItemTrash.svg: Added.
- UserInterface/Images/gtk/NavigationItemVariable.svg: Added.
- UserInterface/Images/gtk/Network.png: Added.
- UserInterface/Images/gtk/Network@2x.png: Added.
- UserInterface/Images/gtk/NetworkLarge.png: Added.
- UserInterface/Images/gtk/NetworkLarge@2x.png: Added.
- UserInterface/Images/gtk/Pause.svg: Added.
- UserInterface/Images/gtk/Percent.svg: Added.
- UserInterface/Images/gtk/Plus.svg: Added.
- UserInterface/Images/gtk/PseudoElement.svg: Added.
- UserInterface/Images/gtk/Reflection.svg: Added.
- UserInterface/Images/gtk/Reload.svg: Added.
- UserInterface/Images/gtk/Request.svg: Added.
- UserInterface/Images/gtk/Response.svg: Added.
- UserInterface/Images/gtk/ResultLine.svg: Added.
- UserInterface/Images/gtk/Resume.svg: Added.
- UserInterface/Images/gtk/SessionStorage.png: Added.
- UserInterface/Images/gtk/SessionStorage@2x.png: Added.
- UserInterface/Images/gtk/ShadowDOM.svg: Added.
- UserInterface/Images/gtk/SourceCode.svg: Added.
- UserInterface/Images/gtk/SplitToggleDown.svg: Added.
- UserInterface/Images/gtk/SplitToggleUp.svg: Added.
- UserInterface/Images/gtk/StepInto.svg: Added.
- UserInterface/Images/gtk/StepOut.svg: Added.
- UserInterface/Images/gtk/StepOver.svg: Added.
- UserInterface/Images/gtk/StyleRuleAuthor.svg: Added.
- UserInterface/Images/gtk/StyleRuleInherited.svg: Added.
- UserInterface/Images/gtk/StyleRuleInheritedElement.svg: Added.
- UserInterface/Images/gtk/StyleRuleInspector.svg: Added.
- UserInterface/Images/gtk/StyleRuleUser.svg: Added.
- UserInterface/Images/gtk/StyleRuleUserAgent.svg: Added.
- UserInterface/Images/gtk/Time.svg: Added.
- UserInterface/Images/gtk/TimelineRecordAnimation.svg: Added.
- UserInterface/Images/gtk/TimelineRecordEvent.svg: Added.
- UserInterface/Images/gtk/TimelineRecordLayout.svg: Added.
- UserInterface/Images/gtk/TimelineRecordPaint.svg: Added.
- UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg: Added.
- UserInterface/Images/gtk/TimelineRecordStyle.svg: Added.
- UserInterface/Images/gtk/TimelineRecordTimer.svg: Added.
- UserInterface/Images/gtk/Undock.svg: Added.
- UserInterface/Images/gtk/UserInputPrompt.svg: Added.
- UserInterface/Images/gtk/UserInputPromptPrevious.svg: Added.
- UserInterface/Images/gtk/UserInputResult.svg: Added.
- UserInterface/Images/gtk/Warning.svg: Added.
- UserInterface/Images/gtk/Weight.svg: Added.
- 5:53 AM Changeset in webkit [173912] by
-
- 5 edits1 copy104 adds in trunk/Source/WebInspectorUI
Unreviewed. Add more free icons for the Web Inspector in GTK+
Patch by Andres Gomez <Andres Gomez> on 2014-09-24
- UserInterface/Images/gtk/AUTHORS:
- UserInterface/Images/gtk/ApplicationCache.png: Added.
- UserInterface/Images/gtk/ApplicationCache@2x.png: Added.
- UserInterface/Images/gtk/BottomUpTree.svg: Added.
- UserInterface/Images/gtk/Breakpoint.png: Added.
- UserInterface/Images/gtk/Breakpoint@2x.png: Added.
- UserInterface/Images/gtk/BreakpointButton.svg:
- UserInterface/Images/gtk/BreakpointInactive.png: Added.
- UserInterface/Images/gtk/BreakpointInactive@2x.png: Added.
- UserInterface/Images/gtk/BreakpointInactiveButton.svg:
- UserInterface/Images/gtk/COPYING:
- UserInterface/Images/gtk/COPYING_CCBYSA3: Copied from Source/WebInspectorUI/UserInterface/Images/gtk/COPYING.
- UserInterface/Images/gtk/ClippingCSS.png: Added.
- UserInterface/Images/gtk/ClippingCSS@2x.png: Added.
- UserInterface/Images/gtk/ClippingGeneric.png: Added.
- UserInterface/Images/gtk/ClippingGeneric@2x.png: Added.
- UserInterface/Images/gtk/ClippingJS.png: Added.
- UserInterface/Images/gtk/ClippingJS@2x.png: Added.
- UserInterface/Images/gtk/CloseTimeline.png: Added.
- UserInterface/Images/gtk/CloseTimeline@2x.png: Added.
- UserInterface/Images/gtk/ColorIcon.png: Added.
- UserInterface/Images/gtk/ColorIcon@2x.png: Added.
- UserInterface/Images/gtk/Colors.png: Added.
- UserInterface/Images/gtk/Colors@2x.png: Added.
- UserInterface/Images/gtk/ColorsLarge.png: Added.
- UserInterface/Images/gtk/ColorsLarge@2x.png: Added.
- UserInterface/Images/gtk/Database.png: Added.
- UserInterface/Images/gtk/Database@2x.png: Added.
- UserInterface/Images/gtk/DatabaseTable.png: Added.
- UserInterface/Images/gtk/DatabaseTable@2x.png: Added.
- UserInterface/Images/gtk/HierarchicalNavigationItemChevron.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner1.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner10.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner11.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner12.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner2.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner3.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner4.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner5.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner6.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner7.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner8.svg: Added.
- UserInterface/Images/gtk/IndeterminateProgressSpinner9.svg: Added.
- UserInterface/Images/gtk/Issues.svg: Added.
- UserInterface/Images/gtk/IssuesEnabled.svg: Added.
- UserInterface/Images/gtk/LayerBorders.svg: Added.
- UserInterface/Images/gtk/LessColumns.svg: Added.
- UserInterface/Images/gtk/LocalStorage.png: Added.
- UserInterface/Images/gtk/LocalStorage@2x.png: Added.
- UserInterface/Images/gtk/Locked.svg: Added.
- UserInterface/Images/gtk/Logs.svg: Added.
- UserInterface/Images/gtk/Memory.svg: Added.
- UserInterface/Images/gtk/MoreColumns.svg: Added.
- UserInterface/Images/gtk/Native.svg: Added.
- UserInterface/Images/gtk/NavigationItemAngleBrackets.svg: Added.
- UserInterface/Images/gtk/NavigationItemBrushAndRuler.svg: Added.
- UserInterface/Images/gtk/NavigationItemBug.svg: Added.
- UserInterface/Images/gtk/NavigationItemCurleyBraces.svg: Added.
- UserInterface/Images/gtk/NavigationItemFile.svg: Added.
- UserInterface/Images/gtk/NavigationItemLayers.svg: Added.
- UserInterface/Images/gtk/NavigationItemLog.svg: Added.
- UserInterface/Images/gtk/NavigationItemMagnifyingGlass.svg: Added.
- UserInterface/Images/gtk/NavigationItemStopwatch.svg: Added.
- UserInterface/Images/gtk/NavigationItemStorage.svg: Added.
- UserInterface/Images/gtk/NavigationItemTrash.svg: Added.
- UserInterface/Images/gtk/NavigationItemVariable.svg: Added.
- UserInterface/Images/gtk/Network.png: Added.
- UserInterface/Images/gtk/Network@2x.png: Added.
- UserInterface/Images/gtk/NetworkLarge.png: Added.
- UserInterface/Images/gtk/NetworkLarge@2x.png: Added.
- UserInterface/Images/gtk/Pause.svg: Added.
- UserInterface/Images/gtk/Percent.svg: Added.
- UserInterface/Images/gtk/Plus.svg: Added.
- UserInterface/Images/gtk/PseudoElement.svg: Added.
- UserInterface/Images/gtk/Reflection.svg: Added.
- UserInterface/Images/gtk/Reload.svg: Added.
- UserInterface/Images/gtk/Request.svg: Added.
- UserInterface/Images/gtk/Response.svg: Added.
- UserInterface/Images/gtk/ResultLine.svg: Added.
- UserInterface/Images/gtk/Resume.svg: Added.
- UserInterface/Images/gtk/SessionStorage.png: Added.
- UserInterface/Images/gtk/SessionStorage@2x.png: Added.
- UserInterface/Images/gtk/ShadowDOM.svg: Added.
- UserInterface/Images/gtk/SourceCode.svg: Added.
- UserInterface/Images/gtk/SplitToggleDown.svg: Added.
- UserInterface/Images/gtk/SplitToggleUp.svg: Added.
- UserInterface/Images/gtk/StepInto.svg: Added.
- UserInterface/Images/gtk/StepOut.svg: Added.
- UserInterface/Images/gtk/StepOver.svg: Added.
- UserInterface/Images/gtk/StyleRuleAuthor.svg: Added.
- UserInterface/Images/gtk/StyleRuleInherited.svg: Added.
- UserInterface/Images/gtk/StyleRuleInheritedElement.svg: Added.
- UserInterface/Images/gtk/StyleRuleInspector.svg: Added.
- UserInterface/Images/gtk/StyleRuleUser.svg: Added.
- UserInterface/Images/gtk/StyleRuleUserAgent.svg: Added.
- UserInterface/Images/gtk/Time.svg: Added.
- UserInterface/Images/gtk/TimelineRecordAnimation.svg: Added.
- UserInterface/Images/gtk/TimelineRecordEvent.svg: Added.
- UserInterface/Images/gtk/TimelineRecordLayout.svg: Added.
- UserInterface/Images/gtk/TimelineRecordPaint.svg: Added.
- UserInterface/Images/gtk/TimelineRecordScriptEvaluated.svg: Added.
- UserInterface/Images/gtk/TimelineRecordStyle.svg: Added.
- UserInterface/Images/gtk/TimelineRecordTimer.svg: Added.
- UserInterface/Images/gtk/Undock.svg: Added.
- UserInterface/Images/gtk/UserInputPrompt.svg: Added.
- UserInterface/Images/gtk/UserInputPromptPrevious.svg: Added.
- UserInterface/Images/gtk/UserInputResult.svg: Added.
- UserInterface/Images/gtk/Warning.svg: Added.
- UserInterface/Images/gtk/Weight.svg: Added.
- 2:14 AM Changeset in webkit [173911] by
-
- 7 edits3 deletes in trunk
Unreviewed, rolling out r173839.
https://bugs.webkit.org/show_bug.cgi?id=137062
NumberConstruct should no longer use static tables (Requested
by dpino on #webkit).
Reverted changeset:
"Simple ES6 feature: Number constructor extras"
https://bugs.webkit.org/show_bug.cgi?id=131707
http://trac.webkit.org/changeset/173839
- 1:35 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 12:56 AM Changeset in webkit [173910] by
-
- 5 edits6 adds in trunk
Remove the style marking from :nth-child()
https://bugs.webkit.org/show_bug.cgi?id=137055
Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-09-24
Reviewed by Andreas Kling.
Source/WebCore:
Previously, :nth-child() had to mark the RenderStyle as unique in order
to prevent it from being used for style sharing.
After r173229, :nth-child() use the more generic element marking
"StyleIsAffectedByPreviousSibling".
In StyleResolver::canShareStyleWithElement(), StyleIsAffectedByPreviousSibling
is already used to prevent style sharing of those elements, making the "Unique"
flag redundant.
Since it is now useless, remove the style marking from SelectorChecker and the CSS JIT.
Tests: fast/css/nth-child-style-sharing-even.html
fast/css/nth-child-style-sharing-fixed-integer.html
fast/css/nth-child-style-sharing-odd.html
- css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
- cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::SelectorCodeGenerator::generateElementIsNthChild):
(WebCore::SelectorCompiler::setElementChildIndexAndUpdateStyle): Deleted.
- rendering/style/RenderStyle.h:
LayoutTests:
Add basic tests for style sharing with :nth-child().
- fast/css/nth-child-style-sharing-even-expected.html: Added.
- fast/css/nth-child-style-sharing-even.html: Added.
- fast/css/nth-child-style-sharing-fixed-integer-expected.html: Added.
- fast/css/nth-child-style-sharing-fixed-integer.html: Added.
- fast/css/nth-child-style-sharing-odd-expected.html: Added.
- fast/css/nth-child-style-sharing-odd.html: Added.
