Timeline



Nov 29, 2014:

6:36 PM Changeset in webkit [176585] by gyuyoung.kim@samsung.com
  • 2 edits in trunk/Source/WebCore

Fix a build warning when CSS_SCROLL_SNAP is enabled
​https://bugs.webkit.org/show_bug.cgi?id=139084

Reviewed by Andrei Bucur.

Fix a build warning. Copy constructor of StyleScrollSnapPoints should initialize its base class.

  • rendering/style/StyleScrollSnapPoints.cpp:

(WebCore::StyleScrollSnapPoints::StyleScrollSnapPoints): Call RefCounted().

4:39 PM Changeset in webkit [176584] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Move the '-webkit-locale', '-webkit-text-orientation', '-webkit-writing-mode', '-webkit-justify-self' and '-webkit-perspective' CSS properties to the new StyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=139104

Patch by Sam Weinig <​sam@webkit.org> on 2014-11-29
Reviewed by Anders Carlsson.

  • css/CSSPropertyNames.in:
  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderFunctions::applyValueWebkitLocale):
(WebCore::StyleBuilderFunctions::applyValueWebkitWritingMode):
(WebCore::StyleBuilderFunctions::applyValueWebkitTextOrientation):
(WebCore::StyleBuilderFunctions::applyValueWebkitJustifySelf):
(WebCore::StyleBuilderFunctions::applyValueWebkitPerspective):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

4:06 PM Changeset in webkit [176583] by akling@apple.com
  • 19 edits in trunk/Source/JavaScriptCore

PropertyTable keys should be AtomicStringImpl.
<​https://webkit.org/b/139096>

Reviewed by Sam Weinig.

Since PropertyTable keys are really always Identifiers, switch the key
type from StringImpl* to AtomicStringImpl*.

We have code in the GetByVal opcode implementations that assumes things
about this, so this change adds confidence to those algorithms.

  • bytecode/ComplexGetStatus.cpp:

(JSC::ComplexGetStatus::computeFor):

  • bytecode/ComplexGetStatus.h:
  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeFromLLInt):
(JSC::GetByIdStatus::computeFor):
(JSC::GetByIdStatus::computeForStubInfo):

  • bytecode/GetByIdStatus.h:
  • bytecode/PutByIdStatus.cpp:

(JSC::PutByIdStatus::computeFromLLInt):
(JSC::PutByIdStatus::computeFor):
(JSC::PutByIdStatus::computeForStubInfo):

  • bytecode/PutByIdStatus.h:
  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):

  • dfg/DFGDesiredIdentifiers.cpp:

(JSC::DFG::DesiredIdentifiers::addLazily):
(JSC::DFG::DesiredIdentifiers::at):

  • dfg/DFGDesiredIdentifiers.h:

(JSC::DFG::DesiredIdentifiers::operator[]):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::isStringPrototypeMethodSane):

  • runtime/Identifier.h:

(JSC::Identifier::impl):

  • runtime/IntendedStructureChain.cpp:

(JSC::IntendedStructureChain::mayInterceptStoreTo):

  • runtime/IntendedStructureChain.h:
  • runtime/PropertyMapHashTable.h:
  • runtime/Structure.cpp:

(JSC::StructureTransitionTable::contains):
(JSC::StructureTransitionTable::get):
(JSC::Structure::addPropertyTransitionToExistingStructureImpl):
(JSC::Structure::addPropertyTransitionToExistingStructureConcurrently):
(JSC::Structure::getConcurrently):
(JSC::Structure::add):
(JSC::Structure::remove):

  • runtime/Structure.h:

(JSC::PropertyMapEntry::PropertyMapEntry):

  • runtime/StructureInlines.h:

(JSC::Structure::getConcurrently):

  • runtime/StructureTransitionTable.h:

(JSC::StructureTransitionTable::Hash::hash):

3:40 PM Changeset in webkit [176582] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit/win

Switch over to using WebVisitedLinkStore on Windows
​https://bugs.webkit.org/show_bug.cgi?id=139103

Reviewed by Antti Koivisto.

  • WebCoreSupport/WebChromeClient.cpp:

(WebChromeClient::populateVisitedLinks):

  • WebHistory.cpp:

(WebHistory::setOptionalSharedHistory):
(WebHistory::removeAllItems):
(WebHistory::setVisitedLinkTrackingEnabled):
(WebHistory::removeAllVisitedLinks):
(WebHistory::removeItemForURLString):
(WebHistory::addVisitedLinksToVisitedLinkStore):
(WebHistory::addVisitedLinksToPageGroup): Deleted.

  • WebHistory.h:
  • WebView.cpp:

(WebView::initWithFrame):

2:52 PM Changeset in webkit [176581] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/win

Another build fix.

  • WebHistory.cpp:

(WebHistory::addVisitedLinksToVisitedLinkStore):

2:48 PM Changeset in webkit [176580] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/win

Another build fix.

  • WebHistory.cpp:

(WebHistory::addVisitedLinksToVisitedLinkStore):
(WebHistory::removeAllVisitedLinks): Deleted.
(WebHistory::setHistoryItemLimit): Deleted.

2:43 PM Changeset in webkit [176579] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit/win

Try to fix build.

  • WebHistory.h:
2:23 PM Changeset in webkit [176578] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit/win

Stub out more of WebVisitedLinkStore on Windows
​https://bugs.webkit.org/show_bug.cgi?id=139098

Reviewed by Sam Weinig.

  • WebCoreSupport/WebVisitedLinkStore.cpp:

(WebVisitedLinkStore::WebVisitedLinkStore):
Initialize m_visitedLinksPopulated to false.

(WebVisitedLinkStore::setShouldTrackVisitedLinks):
Update s_shouldTrackVisitedLinks and remove all visited links if needed.

(WebVisitedLinkStore::removeAllVisitedLinks):
Remove all hashes from our shared link store.

(WebVisitedLinkStore::addVisitedLink):
Compute the visited link hash and add it to the store.

(WebVisitedLinkStore::isLinkVisited):
Populate visited links and then look up the hash in our hash map.

(WebVisitedLinkStore::populateVisitedLinksIfNeeded):
Call out to the history delegate or populate visited links from shared history.

(WebVisitedLinkStore::addVisitedLinkHash):
Add the hash if we're tracking hashes.

(WebVisitedLinkStore::removeVisitedLinkHashes):
Clear the map.

  • WebCoreSupport/WebVisitedLinkStore.h:

Add members.

  • WebHistory.cpp:

(WebHistory::addVisitedLinksToVisitedLinkStore):
New function that adds visited links from the history to a given store.

  • WebHistory.h:

Add new member.

  • WebView.cpp:

(WebView::addVisitedLinks):
Add links to the visited link store as well.

2:17 PM Changeset in webkit [176577] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Add an EmptyVisitedLinkStore implementation
​https://bugs.webkit.org/show_bug.cgi?id=139102

Reviewed by Sam Weinig.

  • loader/EmptyClients.cpp:

(WebCore::fillWithEmptyClients):

  • loader/EmptyClients.h:
2:11 PM Changeset in webkit [176576] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit/mac

Populate visited links
​https://bugs.webkit.org/show_bug.cgi?id=139101

Reviewed by Sam Weinig.

  • History/WebHistory.mm:

(-[WebHistoryPrivate addVisitedLinksToVisitedLinkStore:]):
Helper function that adds all visited link to the given store.

(-[WebHistory _addVisitedLinksToVisitedLinkStore:]):
Call the private method.

  • History/WebHistoryInternal.h:
  • WebCoreSupport/WebVisitedLinkStore.h:

Add new members.

  • WebCoreSupport/WebVisitedLinkStore.mm:

(WebVisitedLinkStore::addVisitedLink):
Get the characters from the URL string and hash them, then call addVisitedLinkHash.

(WebVisitedLinkStore::populateVisitedLinksIfNeeded):
Implement this. First try the delegate, then try the shared history.

(WebVisitedLinkStore::addVisitedLinkHash):
Factor code that adds the link to the hash table into a separate function.

  • WebView/WebView.mm:

(-[WebView addVisitedLinks:]):
Add the visited links to the store.

1:49 PM Changeset in webkit [176575] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit/mac

More work on the legacy WebKit visited link store
​https://bugs.webkit.org/show_bug.cgi?id=139100

Reviewed by Sam Weinig.

  • History/WebHistory.mm:

(+[WebHistory setOptionalSharedHistory:]):
Call WebVisitedLinkStore::setShouldTrackVisitedLinks and WebVisitedLinkStore::removeAllVisitedLinks.

  • WebCoreSupport/WebVisitedLinkStore.h:
  • WebCoreSupport/WebVisitedLinkStore.mm:

(visitedLinkStores):
(WebVisitedLinkStore::WebVisitedLinkStore):
(WebVisitedLinkStore::~WebVisitedLinkStore):
Keep track of live visited link stores.

(WebVisitedLinkStore::setShouldTrackVisitedLinks):
Update s_shouldTrackVisitedLinks and call removeAllVisitedLinks if necessary.

(WebVisitedLinkStore::removeAllVisitedLinks):
Iterate over all live link stores and remove their links.

(WebVisitedLinkStore::isLinkVisited):
Populate visited links and check if our hash table contains the link.

(WebVisitedLinkStore::addVisitedLink):
Add the link hash to the table.

(WebVisitedLinkStore::populateVisitedLinksIfNeeded):
Add stub.

(WebVisitedLinkStore::removeVisitedLinkHashes):
Clear out the hash table.

1:12 PM Changeset in webkit [176574] by andersca@apple.com
  • 6 edits
    2 adds in trunk

Crash when calling WKPageClose on the originated page from within createNewPage callback
​https://bugs.webkit.org/show_bug.cgi?id=139099
<rdar://problem/19052564>

Reviewed by Sam Weinig.

Source/WebKit2:

Null check the namespace ID.

  • UIProcess/Storage/StorageManager.cpp:

(WebKit::StorageManager::cloneSessionStorageNamespaceInternal):

Tools:

Add a test.

  • TestWebKitAPI/PlatformWebView.h:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/CloseFromWithinCreatePage.cpp: Added.

(TestWebKitAPI::runJavaScriptAlert):
(TestWebKitAPI::createNewPage):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2/close-from-within-create-page.html: Added.
  • TestWebKitAPI/mac/PlatformWebViewMac.mm:

(TestWebKitAPI::PlatformWebView::PlatformWebView):

9:47 AM Changeset in webkit [176573] by andersca@apple.com
  • 3 edits
    2 adds in trunk/Source/WebKit

Add a stubbed out WebVisitedLinkStore class on Windows
​https://bugs.webkit.org/show_bug.cgi?id=139078

Reviewed by Sam Weinig.

Source/WebKit:

  • WebKit.vcxproj/WebKit/WebKit.vcxproj:

Source/WebKit/win:

  • WebCoreSupport/WebVisitedLinkStore.cpp: Added.

(WebVisitedLinkStore::shared):
(WebVisitedLinkStore::WebVisitedLinkStore):
(WebVisitedLinkStore::~WebVisitedLinkStore):
(WebVisitedLinkStore::isLinkVisited):
(WebVisitedLinkStore::addVisitedLink):

  • WebCoreSupport/WebVisitedLinkStore.h: Added.

Nov 28, 2014:

11:11 PM Changeset in webkit [176572] by gyuyoung.kim@samsung.com
  • 7 edits in trunk/Source/JavaScriptCore

Use std::unique_ptr<>|make_unique<> in ftl, bytecode of JSC
​https://bugs.webkit.org/show_bug.cgi?id=139063

Reviewed by Andreas Kling.

Clean up OwnPtr and PassOwnPtr in JSC.

  • bytecode/StructureStubClearingWatchpoint.cpp:

(JSC::StructureStubClearingWatchpoint::push):

  • bytecode/StructureStubClearingWatchpoint.h:

(JSC::StructureStubClearingWatchpoint::StructureStubClearingWatchpoint):

  • ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):

  • ftl/FTLJITFinalizer.h:
  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • parser/SourceProviderCacheItem.h:
10:20 PM Changeset in webkit [176571] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Move the '-webkit-initial-letter', '-webkit-line-box-contain' and '-webkit-text-stroke-width' CSS properties to the new StyleBuilder
​https://bugs.webkit.org/show_bug.cgi?id=139053

Patch by Sam Weinig <​sam@webkit.org> on 2014-11-28
Reviewed by Andreas Kling.

  • css/CSSPropertyNames.in:
  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertInitialLetter):
(WebCore::StyleBuilderConverter::convertTextStrokeWidth):
(WebCore::StyleBuilderConverter::convertLineBoxContain):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):

2:10 PM Changeset in webkit [176570] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Stale userData is handed to WKView _actionMenuItemsForHitTestResult under prepareForMenu
​https://bugs.webkit.org/show_bug.cgi?id=139069
<rdar://problem/19075587>

Reviewed by Sam Weinig.

  • UIProcess/mac/WKActionMenuController.mm:

(-[WKActionMenuController wkView:willHandleMouseDown:]):
(-[WKActionMenuController didCloseMenu:withEvent:]):
(-[WKActionMenuController _clearActionMenuState]):
Previously, _userData was not being cleared in didCloseMenu, so a subsequent
action menu invocation would end up sending stale userData to _actionMenuItemsForHitTestResult.

Additionally, factor all of the cleanup code out into _clearActionMenuState,
and call it from both wkView:willHandleMouseDown: and didCloseMenu:withEvent:.

2:09 PM Changeset in webkit [176569] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

DataDetectors PageOverlay callbacks are never called
​https://bugs.webkit.org/show_bug.cgi?id=139067
<rdar://problem/19086676>

Reviewed by Anders Carlsson.

  • Shared/mac/ActionMenuHitTestResult.mm:

(WebKit::ActionMenuHitTestResult::encode):
(WebKit::ActionMenuHitTestResult::decode):
Encode/decode the PageOverlay ID.

10:39 AM Changeset in webkit [176568] by Simon Fraser
  • 6 edits in trunk/Source/WebKit2

Allow clients of the WKRenderLayerRef C SPI to connect layer trees across frame boundaries
​https://bugs.webkit.org/show_bug.cgi?id=139021

Reviewed by Dan Bernstein.

Add WKRenderLayerGetFrameContentsLayer which returns a WKRenderLayerRef for
the content document of a RenderWidget, if its has one (e.g. frames, iframes
and <object> with document contents).

  • Shared/API/c/WKRenderLayer.cpp:

(WKRenderLayerGetFrameContentsLayer):

  • Shared/API/c/WKRenderLayer.h:
  • Shared/UserMessageCoders.h:

(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):

  • Shared/WebRenderLayer.cpp:

(WebKit::WebRenderLayer::create):
(WebKit::WebRenderLayer::WebRenderLayer):

  • Shared/WebRenderLayer.h:

(WebKit::WebRenderLayer::frameContentsLayer):

9:05 AM Changeset in webkit [176567] by commit-queue@webkit.org
  • 2 edits
    3 adds in trunk/Tools

Unreviewed, rolling out r176564.
​https://bugs.webkit.org/show_bug.cgi?id=139093

massive failures on release test bot (Requested by philn on
#webkit).

Reverted changeset:

"[GStreamer] Bump internal jhbuild versions to 1.4.4"
​https://bugs.webkit.org/show_bug.cgi?id=138866
​http://trac.webkit.org/changeset/176564

8:39 AM Changeset in webkit [176566] by Carlos Garcia Campos
  • 4 edits in trunk/Tools

[GTK] Use GMainLoopSource in WebKitTestRunner
​https://bugs.webkit.org/show_bug.cgi?id=138831

Reviewed by Sergio Villar Senin.

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:

(WTR::TestRunner::platformInitialize):
(WTR::TestRunner::invalidateWaitToDumpWatchdogTimer):
(WTR::TestRunner::initializeWaitToDumpWatchdogTimerIfNeeded):
(WTR::waitToDumpWatchdogTimerCallback): Deleted.

  • WebKitTestRunner/gtk/TestControllerGtk.cpp:

(WTR::TestController::notifyDone):
(WTR::TestController::platformRunUntil):
(WTR::cancelTimeout): Deleted.

7:27 AM Changeset in webkit [176565] by Philippe Normand
  • 2 edits in trunk

[CMake] Build failure against GStreamer git master
​https://bugs.webkit.org/show_bug.cgi?id=138872

Reviewed by Csaba Osztrogon.

  • Source/cmake/FindGStreamer.cmake: Simplified the

FIND_GSTREAMER_COMPONENT macro. Trust pkg-config for include
headers lookup, there's no need to do this manually. Also
explicitely check the version specified in GStreamer_FIND_VERSION.

6:42 AM Changeset in webkit [176564] by Philippe Normand
  • 2 edits
    3 deletes in trunk/Tools

[GStreamer] Bump internal jhbuild versions to 1.4.4
​https://bugs.webkit.org/show_bug.cgi?id=138866

Reviewed by Carlos Garcia Campos.

  • gtk/jhbuild.modules:
  • gtk/patches/gst-events-arent-gstobjects.patch: Removed.
  • gtk/patches/gst-plugins-base-fix-build-gcc-4.9-x86.patch: Removed.
  • gtk/patches/gst-prevent-neon-check-in-configure-from-passing-under-aarch64.patch: Removed.
6:29 AM Changeset in webkit [176563] by Carlos Garcia Campos
  • 14 edits
    2 deletes in trunk/Tools

[GTK] Use custom JavaScript instead of DBus to implement WebProcess tests
​https://bugs.webkit.org/show_bug.cgi?id=138834

Reviewed by Sergio Villar Senin.

It makes everyting simpler and the tests run faster too, since we
don't need to spawn the private bus and wait until the DBus name
is registered. The web extension registers a new JavaSCript class
with a status method to run the tests, similar to the DBus
method. In the UI process side, tests use webkit_web_view_run_java_script()
instead of sending a DBus message.

  • TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
  • TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:

(WebKitDOMNodeFilterTest::create):
(WebKitDOMNodeFilterTest::testTreeWalker):
(WebKitDOMNodeFilterTest::testNodeIterator):
(WebKitDOMNodeFilterTest::webPageFromArgs): Deleted.
(WebKitDOMNodeFilterTest::runTest): Deleted.

  • TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:

(WebKitDOMNodeTest::create):
(WebKitDOMNodeTest::testHierarchyNavigation):
(WebKitDOMNodeTest::testInsertion):
(WebKitDOMNodeTest::testTagNames):
(WebKitDOMNodeTest::webPageFromArgs): Deleted.
(WebKitDOMNodeTest::runTest): Deleted.

  • TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:

(WebKitDOMXPathNSResolverTest::create):
(WebKitDOMXPathNSResolverTest::testXPathNSResolverNative):
(WebKitDOMXPathNSResolverTest::testXPathNSResolverCustom):
(WebKitDOMXPathNSResolverTest::webPageFromArgs): Deleted.
(WebKitDOMXPathNSResolverTest::runTest): Deleted.

  • TestWebKitAPI/Tests/WebKit2Gtk/FrameTest.cpp:

(WebKitFrameTest::create):
(WebKitFrameTest::testMainFrame):
(WebKitFrameTest::testURI):
(WebKitFrameTest::testJavaScriptContext):
(WebKitFrameTest::webPageFromArgs): Deleted.
(WebKitFrameTest::runTest): Deleted.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:

(testWebKitDOMNodeHierarchyNavigation):
(testWebKitDOMNodeInsertion):
(testWebKitDOMNodeTagNames):
(beforeAll):
(afterAll):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNodeFilter.cpp:

(runTest):
(beforeAll):
(afterAll):

  • TestWebKitAPI/Tests/WebKit2Gtk/TestDOMXPathNSResolver.cpp:

(testWebKitDOMXPathNSResolverNative):
(testWebKitDOMXPathNSResolverCustom):
(beforeAll):
(afterAll):
(runTest): Deleted.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestFrame.cpp:

(webkitFrameTestRun):
(beforeAll):
(afterAll):

  • TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:

(testsMap):
(WebProcessTest::add):
(WebProcessTest::create):
(runTest):
(windowObjectClearedCallback):
(webkit_web_extension_initialize):
(methodCallCallback): Deleted.
(webkit_web_extension_initialize_with_user_data): Deleted.

  • TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
  • TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.cpp: Removed.
  • TestWebKitAPI/gtk/WebKit2Gtk/WebProcessTestRunner.h: Removed.
  • TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:

(WebViewTest::runWebProcessTest):

  • TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.h:
5:41 AM Changeset in webkit [176562] by Csaba Osztrogonác
  • 2 edits
    1 add in trunk/Tools

[EFL] libseccomp should pick up CC environment variable to be conform to other jhbuild modules
​https://bugs.webkit.org/show_bug.cgi?id=139086

Reviewed by Gyuyoung Kim.

  • efl/jhbuild.modules:
  • efl/patches/libseccomp-pick-up-CC.patch: Added.
3:05 AM Changeset in webkit [176561] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer] HTTP source element lacks SCHEDULING query support
​https://bugs.webkit.org/show_bug.cgi?id=139064

Reviewed by Carlos Garcia Campos.

No new tests, covered by http/tests/media/hls.

  • platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcQueryWithParent): Make the element handle SCHEDULING
queries with the BANDWIDTH_LIMITED flag. This helps uridecodebin
to configure itself for adaptive streaming playback scenarios.

1:50 AM Changeset in webkit [176560] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] Add warning if CMake version is too old for building with ninja.
​https://bugs.webkit.org/show_bug.cgi?id=139055

Patch by Bartlomiej Gajda <​b.gajda@samsung.com> on 2014-11-28
Reviewed by Gyuyoung Kim.

CMake need to be >= 2.8.10 to build WebKit using ninja, some repos don't have
that version in their repositories.

  • efl/install-dependencies:
1:10 AM Changeset in webkit [176559] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

[WK2] SecComp buildfix after r176452
​https://bugs.webkit.org/show_bug.cgi?id=139081

Reviewed by Antti Koivisto.

  • Shared/linux/SeccompFilters/SeccompBroker.cpp:

(WebKit::SeccompBrokerClient::dispatch):
(WebKit::SeccompBroker::runLoop):

1:09 AM Changeset in webkit [176558] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit2

Fix -Wc++11-narrowing error in SeccompFilters.cpp
​https://bugs.webkit.org/show_bug.cgi?id=139079

Reviewed by Carlos Garcia Campos.

  • Shared/linux/SeccompFilters/SeccompFilters.cpp:

(WebKit::SeccompFilters::addRule):

  • Shared/linux/SeccompFilters/SeccompFilters.h:
1:04 AM Changeset in webkit [176557] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

[WK2] SecComp buildfix after r168605 and r168999
​https://bugs.webkit.org/show_bug.cgi?id=139080

Reviewed by Carlos Garcia Campos.

  • Shared/linux/SeccompFilters/SyscallPolicy.cpp:

(WebKit::SyscallPolicy::addDefaultWebProcessPolicy):

1:00 AM Changeset in webkit [176556] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

[ATK] Allowing the use of AccessibilityUIElement::columnHeaders method for table.
​https://bugs.webkit.org/show_bug.cgi?id=139044

Patch by Andrzej Badowski <​a.badowski@samsung.com> on 2014-11-28
Reviewed by Chris Fleizach.

ATK method AccessibilityUIElement::columnHeaders currently focused only on the object table cell.
The proposed solution will enable the use of this method for the object table.
Existing test shows the result.

Tools:

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::columnHeaders):

LayoutTests:

  • accessibility/table-column-headers-with-captions.html: Updated for ATK platform.
  • platform/efl/accessibility/table-column-headers-with-captions-expected.txt: Added.
  • platform/gtk/TestExpectations: Updated for GTK.
  • platform/gtk/accessibility/table-column-headers-with-captions-expected.txt: Added.

Nov 27, 2014:

11:04 PM Changeset in webkit [176555] by ryuan.choi@navercorp.com
  • 10 edits
    1 delete in trunk

[EFL] Remove E_Dbus dependency
​https://bugs.webkit.org/show_bug.cgi?id=136355

Reviewed by Gyuyoung Kim.

.:

  • Source/cmake/FindE_DBus.cmake: Removed.
  • Source/cmake/OptionsEfl.cmake:

Source/WebCore:

E_Dbus is the simple wrapper of Dbus but it has not been maintained since EFL 1.8.
Instead, EFL introduced Eldbus, which is almost similar with E_Dbus but provides more dbus like interface.
This patch replaces E_Dbus implementation to Eldbus.

  • PlatformEfl.cmake:
  • platform/efl/BatteryProviderEfl.cpp:

(WebCore::BatteryProviderEfl::BatteryProviderEfl):
(WebCore::BatteryProviderEfl::~BatteryProviderEfl):
(WebCore::BatteryProviderEfl::stopUpdating):
(WebCore::batteryProperties):
(WebCore::batteryPropertiesChanged):
(WebCore::BatteryProviderEfl::deviceTypeCallback):
(WebCore::BatteryProviderEfl::enumerateDevices):
(WebCore::BatteryProviderEfl::startUpdating):
(WebCore::BatteryProviderEfl::setBatteryStatus):
(WebCore::BatteryProviderEfl::timerFired): Deleted.
(WebCore::BatteryProviderEfl::getBatteryStatus): Deleted.
(WebCore::BatteryProviderEfl::setBatteryClient): Deleted.

  • platform/efl/BatteryProviderEfl.h:

(WebCore::BatteryProviderEfl::connection):
(WebCore::BatteryProviderEfl::setSignalHandler):
(WebCore::BatteryProviderEfl::~BatteryProviderEfl): Deleted.

Source/WebKit2:

  • UIProcess/API/efl/ewk_main.cpp: Added init/shutdown for eldbus.

(WebKit::EwkMain::initialize):
(WebKit::EwkMain::finalize):
(WebKit::EwkMain::shutdownInitializedEFLModules):

Tools:

  • MiniBrowser/efl/CMakeLists.txt: Removed E_DBUS includes.
5:40 PM Changeset in webkit [176554] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

CrashTracer: com.apple.WebKit.WebContent at com.apple.WebCore: WebCore::HTMLPlugInImageElement::updateSnapshot + 108
​https://bugs.webkit.org/show_bug.cgi?id=139057

Reviewed by Anders Carlsson.

No test, don't know how to repro.

  • html/HTMLPlugInImageElement.cpp:

(WebCore::HTMLPlugInImageElement::updateSnapshot): Null check the renderer.

4:51 PM Changeset in webkit [176553] by gyuyoung.kim@samsung.com
  • 11 edits in trunk/Source/JavaScriptCore

Use std::unique_ptr instead of OwnPtr in JSC classes
​https://bugs.webkit.org/show_bug.cgi?id=139009

Reviewed by Filip Pizlo.

As a step of using std::unique_ptr<>, this patch replaces OwnPtr with
std::unique_ptr<>|std::make_unique<>.

  • bytecode/DFGExitProfile.cpp:

(JSC::DFG::ExitProfile::add):

  • bytecode/DFGExitProfile.h:
  • bytecode/LazyOperandValueProfile.cpp:

(JSC::CompressedLazyOperandValueProfileHolder::add):

  • bytecode/LazyOperandValueProfile.h:
  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::stopAllocating):

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::clearNewlyAllocated):

  • inspector/ContentSearchUtilities.cpp:

(Inspector::ContentSearchUtilities::findMagicComment):

  • runtime/RegExp.cpp:

(JSC::RegExp::invalidateCode):

  • runtime/RegExp.h:
  • yarr/RegularExpression.cpp:

(JSC::Yarr::RegularExpression::Private::compile):
(JSC::Yarr::RegularExpression::isValid):

  • yarr/YarrInterpreter.cpp:

(JSC::Yarr::ByteCompiler::compile):
(JSC::Yarr::ByteCompiler::regexBegin):
(JSC::Yarr::byteCompile):

  • yarr/YarrInterpreter.h:

(JSC::Yarr::BytecodePattern::BytecodePattern):

4:24 PM Changeset in webkit [176552] by jdiggs@igalia.com
  • 9 edits in trunk

AX: [ATK] Meter and Option elements do not expose their id attribute
​https://bugs.webkit.org/show_bug.cgi?id=139017

Reviewed by Mario Sanchez Prada.

Source/WebCore:

The options in a collapsed select element lack a node, so get the id
attribute from the associated action element. In the case of a meter,
the meter element itself is not exposed; its RenderMeter is instead.
So associate the meter element's id with the exposed RenderMeter.

No new tests. Instead, updated existing expectations to reflect the fix.

  • accessibility/AccessibilityObject.h:
  • accessibility/AccessibilityProgressIndicator.cpp:

(WebCore::AccessibilityProgressIndicator::element):

  • accessibility/AccessibilityProgressIndicator.h:
  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes):

LayoutTests:

  • accessibility/roles-exposed.html: Unskipped the meter element test.
  • platform/efl/accessibility/roles-exposed-expected.txt: Updated to reflect fixes.
  • platform/gtk/accessibility/roles-exposed-expected.txt: Updated to reflect fixes.
10:00 AM Changeset in webkit [176551] by andersca@apple.com
  • 5 edits
    2 copies in trunk/Source/WebKit

Add a stubbed out WebVisitedLinkStore to WebViewGroup
​https://bugs.webkit.org/show_bug.cgi?id=139066

Reviewed by Antti Koivisto.

Source/WebKit:

  • WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

  • WebCoreSupport/WebViewGroup.h:

(WebViewGroup::visitedLinkStore):

  • WebCoreSupport/WebViewGroup.mm:

(WebViewGroup::WebViewGroup):

  • WebCoreSupport/WebVisitedLinkStore.h: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.
  • WebCoreSupport/WebVisitedLinkStore.mm: Copied from Source/WebKit/mac/WebCoreSupport/WebViewGroup.h.

(WebVisitedLinkStore::create):
(WebVisitedLinkStore::WebVisitedLinkStore):
(WebVisitedLinkStore::~WebVisitedLinkStore):
(WebVisitedLinkStore::isLinkVisited):
(WebVisitedLinkStore::addVisitedLink):

9:58 AM Changeset in webkit [176550] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Add a Page::setVisitedLinkStore member function
​https://bugs.webkit.org/show_bug.cgi?id=139065

Reviewed by Antti Koivisto.

This will be used in a subsequent commit.

  • WebCore.exp.in:
  • page/Page.cpp:

(WebCore::Page::setVisitedLinkStore):

  • page/Page.h:
4:47 AM WebKitGTK/2.4.x edited by Andres Gomez
(diff)
4:04 AM Changeset in webkit [176549] by commit-queue@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

[GTK] Unreviewed GTK gardening.
​https://bugs.webkit.org/show_bug.cgi?id=139061

rebaseline after r176354.

Patch by Hunseop Jeong <Hunseop Jeong> on 2014-11-27

  • platform/gtk/fast/multicol/tall-image-behavior-expected.png: Added.
  • platform/gtk/fast/multicol/tall-image-behavior-expected.txt: Added.
  • platform/gtk/fast/multicol/tall-image-behavior-lr-expected.png: Added.
  • platform/gtk/fast/multicol/tall-image-behavior-lr-expected.txt: Added.
  • platform/gtk/fast/multicol/tall-image-behavior-rl-expected.png: Added.
  • platform/gtk/fast/multicol/tall-image-behavior-rl-expected.txt: Added.
3:39 AM Changeset in webkit [176548] by Andres Gomez
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Update NavigationItemProbes icon for the GTK+ port
​https://bugs.webkit.org/show_bug.cgi?id=139074

Reviewed by Carlos Garcia Campos.

NavigationItemProbes was updated for the Mac port and we are now
having a similar ideogram in GTK+.

  • UserInterface/Images/gtk/NavigationItemProbes.svg: Updated.

Nov 26, 2014:

5:39 AM Changeset in webkit [176547] by commit-queue@webkit.org
  • 1 edit
    6 adds in trunk/LayoutTests

[EFL] Unreviewed EFL gardening after r176354.
​https://bugs.webkit.org/show_bug.cgi?id=139060

rebaseline after r176354.

Patch by Hunseop Jeong <Hunseop Jeong> on 2014-11-26

  • platform/efl/fast/multicol/tall-image-behavior-expected.png: Added.
  • platform/efl/fast/multicol/tall-image-behavior-expected.txt: Added.
  • platform/efl/fast/multicol/tall-image-behavior-lr-expected.png: Added.
  • platform/efl/fast/multicol/tall-image-behavior-lr-expected.txt: Added.
  • platform/efl/fast/multicol/tall-image-behavior-rl-expected.png: Added.
  • platform/efl/fast/multicol/tall-image-behavior-rl-expected.txt: Added.
12:08 AM Changeset in webkit [176546] by commit-queue@webkit.org
  • 3 edits
    2 adds
    2 deletes in trunk/Tools

[EFL][GTK] Bump up FDE relocation fixing patch to version accepted to LLVM trunk.
​https://bugs.webkit.org/show_bug.cgi?id=139047

Patch by Akos Kiss <​akiss@inf.u-szeged.hu> on 2014-11-26
Reviewed by Carlos Garcia Campos.

  • efl/jhbuild.modules:
  • efl/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
  • efl/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.
  • gtk/jhbuild-optional.modules:
  • gtk/patches/llvm-elf-allow-fde-references-outside-the-2gb-range.patch: Added.
  • gtk/patches/llvm-elf-fix-x86_64-fdecfiencoding.patch: Removed.

Nov 25, 2014:

4:27 PM Changeset in webkit [176545] by commit-queue@webkit.org
  • 15 edits in trunk

Add parsing for :dir()
​https://bugs.webkit.org/show_bug.cgi?id=138932

Patch by Sukolsak Sakshuwong <Sukolsak Sakshuwong> on 2014-11-25
Reviewed by Benjamin Poulain.

Source/WebCore:

Add support for parsing :dir() pseudo class. The implementation of selector
matching will be in a follow-up patch.

  • css/CSSGrammar.y.in:
  • css/CSSParser.cpp:

(WebCore::CSSParser::detectFunctionTypeToken):

  • css/CSSSelector.cpp:

(WebCore::appendPseudoClassFunctionTail):
(WebCore::CSSSelector::selectorText):

  • css/CSSSelector.h:
  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • css/SelectorPseudoClassAndCompatibilityElementMap.in:
  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):

LayoutTests:

  • fast/css/css-selector-text-expected.txt:
  • fast/css/css-selector-text.html:
  • fast/css/css-set-selector-text-expected.txt:
  • fast/css/css-set-selector-text.html:
  • fast/selectors/invalid-functional-pseudo-class-expected.txt:
  • fast/selectors/invalid-functional-pseudo-class.html:
11:50 AM Changeset in webkit [176544] by andersca@apple.com
  • 11 edits in trunk/Source

Remove user content handling from PageGroup
​https://bugs.webkit.org/show_bug.cgi?id=139051

Reviewed by Antti Koivisto.

Source/WebCore:

Remove m_userContentController from PageGroup and the related functions and symbol exports.

  • WebCore.exp.in:
  • page/PageGroup.cpp:

(WebCore::PageGroup::PageGroup):
(WebCore::PageGroup::~PageGroup):
(WebCore::PageGroup::addPage):
(WebCore::PageGroup::removePage):
(WebCore::PageGroup::addUserScriptToWorld): Deleted.
(WebCore::PageGroup::addUserStyleSheetToWorld): Deleted.
(WebCore::PageGroup::removeUserScriptFromWorld): Deleted.
(WebCore::PageGroup::removeUserStyleSheetFromWorld): Deleted.
(WebCore::PageGroup::removeUserScriptsFromWorld): Deleted.
(WebCore::PageGroup::removeUserStyleSheetsFromWorld): Deleted.
(WebCore::PageGroup::removeAllUserContent): Deleted.

  • page/PageGroup.h:

Source/WebKit/mac:

Use the user content controller in the web view group.

  • WebView/WebView.mm:

(-[WebView _injectOutlookQuirksScript]):

Source/WebKit2:

  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::addUserScript):
(WebKit::InjectedBundle::addUserStyleSheet):
(WebKit::InjectedBundle::removeUserScript):
(WebKit::InjectedBundle::removeUserStyleSheet):
(WebKit::InjectedBundle::removeUserScripts):
(WebKit::InjectedBundle::removeUserStyleSheets):
(WebKit::InjectedBundle::removeAllUserContent):
Talk to the user content controller from the passed in WebPageGroupProxy.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::WebPage):
Create the WebPageGroupProxy before creating the page so we can get its user content controller and
pass it to the page configuration if necessary.

  • WebProcess/WebPage/WebPageGroupProxy.cpp:

(WebKit::WebPageGroupProxy::userContentController):
New function that lazily creates a user content controller. We don't want to create this eagerly since
it's not used with the modern API.

(WebKit::WebPageGroupProxy::addUserStyleSheet):
(WebKit::WebPageGroupProxy::addUserScript):
(WebKit::WebPageGroupProxy::removeAllUserStyleSheets):
(WebKit::WebPageGroupProxy::removeAllUserScripts):
(WebKit::WebPageGroupProxy::removeAllUserContent):
Call through to the user content controller.

  • WebProcess/WebPage/WebPageGroupProxy.h:

Add an m_userContentController member.

10:05 AM Changeset in webkit [176543] by alex
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed, upload two missing test files in the commit r174677.

  • mathml/presentation/mo-stretch-update-expected.html: Added.
  • mathml/presentation/mo-stretch-update.html: Added.
8:16 AM Changeset in webkit [176542] by andersca@apple.com
  • 7 edits in trunk/Source

Add a user content controller to WebViewGroup and use it for user content
​https://bugs.webkit.org/show_bug.cgi?id=139043

Reviewed by Antti Koivisto.

Source/WebCore:

  • WebCore.exp.in:

Export symbols.

  • page/Page.cpp:

(WebCore::Page::setUserContentController):
Invalidate the injected style cache when setting a new user content controller.

Source/WebKit/mac:

This is another tiny step towards getting rid of user content handling inside PageGroup.

  • WebCoreSupport/WebViewGroup.h:

(WebViewGroup::userContentController):
Add a UserContentController member and getter.

  • WebCoreSupport/WebViewGroup.mm:

(WebViewGroup::get):
Helper function that returns a WebViewGroup by its name (or null if it doesn't exist).

(WebViewGroup::WebViewGroup):
Create a user content controller.

  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
Instead of calling -[WebView setGroupName:], create a WebViewGroup before creating the page, that way we can
set its user content controller in the PageConfiguration.

(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):
Ditto.

(+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
(+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):
(+[WebView _removeUserScriptFromGroup:world:url:]):
(+[WebView _removeUserStyleSheetFromGroup:world:url:]):
(+[WebView _removeUserScriptsFromGroup:world:]):
(+[WebView _removeUserStyleSheetsFromGroup:world:]):
(+[WebView _removeAllUserContentFromGroup:]):
Instead of calling into the PageGroup, get the WebViewGroup's user content controller and call into that.

(-[WebView setGroupName:]):
Set the user content controller to the new WebViewGroup's user content controller.

6:49 AM Changeset in webkit [176541] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer] gstmpegts is not initialized
​https://bugs.webkit.org/show_bug.cgi?id=139039

Reviewed by Carlos Garcia Campos.

  • platform/graphics/gstreamer/GStreamerUtilities.cpp:

(WebCore::initializeGStreamer): Initialize the gstmpegts library.

6:29 AM Changeset in webkit [176540] by berto@igalia.com
  • 2 edits in trunk/Source/WebKit2

[GTK] Use LD_LIBRARY_PATH to make g-ir-scanner use the newly-built
version of libraries when running the temporary executable
​https://bugs.webkit.org/show_bug.cgi?id=138833

Patch by Ting-Wei Lan <Ting-Wei Lan> on 2014-11-25
Reviewed by Carlos Garcia Campos.

This patch modifies LD_LIBRARY_PATH to make sure the dynamic linker
find the correct version of libraries when running the temporary
executable to generate the .gir file.

  • PlatformGTK.cmake:
5:48 AM Changeset in webkit [176539] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[GTK] Minibrowser: Add support for zoom using Control Key + Mouse scroll
​https://bugs.webkit.org/show_bug.cgi?id=138090

Patch by Tanay C <​tanay.c@samsung.com> on 2014-11-25
Reviewed by Carlos Garcia Campos.

  • MiniBrowser/gtk/BrowserWindow.c: Implementing zoom using Cntrl + Mouse scroll

(browserWindowZoomIn): Added.
(browserWindowZoomOut): Added.
(scrollEventCallback): Added.
(zoomInCallback): Modified.
(zoomOutCallback): Modified.
(browserWindowConstructed): Modified.

1:59 AM Changeset in webkit [176538] by Csaba Osztrogonác
  • 5 edits in trunk

[EFL] REGRESSION(r176514): It made performance tests fail
​https://bugs.webkit.org/show_bug.cgi?id=139037

Reviewed by Gyuyoung Kim.

Source/WebKit2:

  • WebProcess/efl/WebProcessMainEfl.cpp: Don't try to load/shutdown eail if eailLibraryPath() is empty.

Tools:

  • Scripts/webkitpy/port/efl.py:

(EflPort.setup_environ_for_server): Pass ACCESSIBILITY_EAIL_LIBRARY_PATH environment variable to WTR.

  • efl/jhbuildrc: Set ACCESSIBILITY_EAIL_LIBRARY_PATH to point to DependenciesEFL/lib/libeail.so

only if ACCESSIBILITY_EAIL_LIBRARY_PATH isn't already set and DependenciesEFL/lib/libeail.so exists.

Note: See TracTimeline for information about the timeline view.