Timeline
Jun 15, 2015:
- 11:47 PM Changeset in webkit [185584] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed, following gardening of r185583.
- platform/efl/TestExpectations: Unskip passing tests, mark new failure tests since disabling USE_NATIVE_XDISPLAY.
- 11:16 PM Changeset in webkit [185583] by
-
- 2 edits in trunk/LayoutTests
[EFL] Unreviewed, gardening on Jun 16th.
Too many flaky tests happens on efl bot when enabling USE_NATIVE_XDISPLAY and DISPLAY.
Those options were enabled for removing TextureMapperImageBuffer. However now EFL Layout Test
can be run without enabling the options. To remove many flaky tests, EFL buildbot disables
the env variables.
Thanks to disable it, many tests can be unskipped which were marked to failure, imageonlyfailure
and so on since r183540.
- platform/efl/TestExpectations: Unskip passing tests, mark failure tests after disabling USE_NATIVE_XDISPLAY.
- 10:55 PM Changeset in webkit [185582] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Build fix after r185574.
- public/v2/app.js:
(set get App.Pane.Ember.Object.extend.):
- 10:47 PM Changeset in webkit [185581] by
-
- 38 edits23 copies20 adds in trunk
Add test expectations for El Capitan
https://bugs.webkit.org/show_bug.cgi?id=146005
Rubber-stamped by Dan Bernstein.
Tools:
Add appropriate tools code.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/ElCapitan@2x.png: Added.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
Added dashboard support.
- BuildSlaveSupport/build.webkit.org-config/wkbuild.py:
- BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:
Trigger the right build queues on check-in.
- Scripts/webkitpy/common/system/platforminfo.py:
- Scripts/webkitpy/common/system/platforminfo_unittest.py:
- Scripts/webkitpy/layout_tests/models/test_expectations.py:
- Scripts/webkitpy/port/mac.py:
- Scripts/webkitpy/port/mac_unittest.py:
- Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
- TestResultServer/static-dashboards/flakiness_dashboard.js:
Added cases for El Capitan, and updated tests for new baseline search paths.
LayoutTests:
- platform/mac-wk1/TestExpectations:
- platform/mac-yosemite: Added.
- platform/mac-yosemite/fast: Added.
- platform/mac-yosemite/fast/dom: Added.
- platform/mac-yosemite/fast/dom/52776-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/52776-expected.txt.
- platform/mac-yosemite/fast/text: Added.
- platform/mac-yosemite/fast/text/complex-text-opacity-expected.txt: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.txt.
- platform/mac-yosemite/fast/text/hyphenate-locale-expected.txt: Copied from LayoutTests/platform/mac/fast/text/hyphenate-locale-expected.txt.
- platform/mac-yosemite/fast/text/international: Added.
- platform/mac-yosemite/fast/text/international/arabic-justify-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/arabic-justify-expected.txt.
- platform/mac-yosemite/fast/text/international/bidi-AN-after-L-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.txt.
- platform/mac-yosemite/fast/text/international/bidi-mirror-he-ar-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt.
- platform/mac-yosemite/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt.
- platform/mac-yosemite/fast/text/international/bidi-neutral-run-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-run-expected.txt.
- platform/mac-yosemite/fast/text/line-initial-and-final-swashes-expected.txt: Copied from LayoutTests/platform/mac/fast/text/line-initial-and-final-swashes-expected.txt.
- platform/mac-yosemite/js: Added.
- platform/mac-yosemite/js/dom: Added.
- platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt: Copied from LayoutTests/platform/mac/js/dom/global-constructors-attributes-expected.txt.
- platform/mac-yosemite/platform: Added.
- platform/mac-yosemite/platform/mac: Added.
- platform/mac-yosemite/platform/mac/editing: Added.
- platform/mac-yosemite/platform/mac/editing/attributed-string: Added.
- platform/mac-yosemite/platform/mac/editing/attributed-string/anchor-element-expected.txt: Copied from LayoutTests/platform/mac/editing/attributed-string/anchor-element-expected.txt.
- platform/mac-yosemite/platform/mac/editing/attributed-string/basic-expected.txt: Copied from LayoutTests/platform/mac/editing/attributed-string/basic-expected.txt.
- platform/mac-yosemite/platform/mac/editing/attributed-string/font-size-expected.txt: Copied from LayoutTests/platform/mac/editing/attributed-string/font-size-expected.txt.
- platform/mac-yosemite/platform/mac/editing/attributed-string/font-style-variant-effect-expected.txt: Copied from LayoutTests/platform/mac/editing/attributed-string/font-style-variant-effect-expected.txt.
- platform/mac-yosemite/platform/mac/editing/attributed-string/font-weight-expected.txt: Copied from LayoutTests/platform/mac/editing/attributed-string/font-weight-expected.txt.
- platform/mac-yosemite/platform/mac/editing/attributed-string/letter-spacing-expected.txt: Copied from LayoutTests/platform/mac/editing/attributed-string/letter-spacing-expected.txt.
- platform/mac-yosemite/platform/mac/editing/attributed-string/text-decorations-expected.txt: Copied from LayoutTests/platform/mac/editing/attributed-string/text-decorations-expected.txt.
- platform/mac-yosemite/platform/mac/editing/attributed-string/vertical-align-expected.txt: Copied from LayoutTests/platform/mac/editing/attributed-string/vertical-align-expected.txt.
- platform/mac-yosemite/platform/mac/fast: Added.
- platform/mac-yosemite/platform/mac/fast/text: Added.
- platform/mac-yosemite/platform/mac/fast/text/ligature-subdivision-expected.txt: Copied from LayoutTests/platform/mac/fast/text/ligature-subdivision-expected.txt.
- platform/mac-yosemite/svg: Added.
- platform/mac-yosemite/svg/W3C-SVG-1.1: Added.
- platform/mac-yosemite/svg/W3C-SVG-1.1-SE: Added.
- platform/mac-yosemite/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png.
- platform/mac-yosemite/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt.
- platform/mac-yosemite/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt.
- platform/mac-yosemite/svg/text: Added.
- platform/mac-yosemite/svg/text-intro-05-t-expected.txt: Copied from LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.txt.
- platform/mac-yosemite/svg/text/text-intro-05-t-expected.txt: Added.
- platform/mac/TestExpectations:
- platform/mac/editing/attributed-string/anchor-element-expected.txt:
- platform/mac/editing/attributed-string/basic-expected.txt:
- platform/mac/editing/attributed-string/font-size-expected.txt:
- platform/mac/editing/attributed-string/font-style-variant-effect-expected.txt:
- platform/mac/editing/attributed-string/font-weight-expected.txt:
- platform/mac/editing/attributed-string/letter-spacing-expected.txt:
- platform/mac/editing/attributed-string/text-decorations-expected.txt:
- platform/mac/editing/attributed-string/vertical-align-expected.txt:
- platform/mac/fast/dom/52776-expected.txt:
- platform/mac/fast/text/complex-text-opacity-expected.txt:
- platform/mac/fast/text/hyphenate-locale-expected.txt:
- platform/mac/fast/text/international/arabic-justify-expected.txt:
- platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
- platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
- platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
- platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
- platform/mac/fast/text/ligature-subdivision-expected.txt:
- platform/mac/fast/text/line-initial-and-final-swashes-expected.txt:
- platform/mac/js/dom/global-constructors-attributes-expected.txt:
- platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
- platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
- platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
- platform/mac/svg/text/text-intro-05-t-expected.txt:
- 10:05 PM Changeset in webkit [185580] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r175251, Mavericks Only): Playback may stall
https://bugs.webkit.org/show_bug.cgi?id=145989
<rdar://problem/21271919>
Unreviewed post-review correction.
Dave Kilzer pointed out that the macro around the waitForVideoOutputMediaDataWillChange
call was incorrect. This patch corrects this error.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput): Correct the
macro definition.
- 9:57 PM Changeset in webkit [185579] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Fix a typo.
- tools/pull-os-versions.py:
(main):
- 9:49 PM Changeset in webkit [185578] by
-
- 1 edit1 move in trunk/Websites/perf.webkit.org
Perf dashboard should be able to list iOS versions as well as OS X versions
https://bugs.webkit.org/show_bug.cgi?id=146003
Reviewed by Stephanie Lewis.
Generalized pull-osx.py so that it can run an arbitrary shell command to fetch OS versions based on
information specified in config.json.
- tools/pull-os-versions.py: Renamed from pull-osx.py.
(main): Use available_builds_from_command when 'customCommands' is specified.
(available_builds_from_command): Added. Executes a shell command to fetch a list of available builds.
(fetch_available_builds): Now takes the repository name.
- 7:11 PM Changeset in webkit [185577] by
-
- 13 edits3 moves1 add5 deletes in trunk/Source/JavaScriptCore
[ES6] Introduce %IteratorPrototype% and drop all XXXIteratorConstructor
https://bugs.webkit.org/show_bug.cgi?id=145963
Reviewed by Darin Adler.
ES6 iterators inherit %IteratorPrototype%.
And these prototype objects of derived iterators don't have @@iterator methods.
Instead they use the %IteratorPrototype%[@@iterator] method.
To encourage inlining in for-of statement, we define this method in JS builtins.
And these iterator prototype objects don't have any constructor function.
This patch drops them (like StringIteratorConstructor).
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
- JavaScriptCore.xcodeproj/project.pbxproj:
- builtins/Iterator.prototype.js: Renamed from Source/JavaScriptCore/runtime/StringIteratorConstructor.cpp.
(SymbolIterator):
- runtime/ArrayIteratorConstructor.cpp:
(JSC::ArrayIteratorConstructor::finishCreation): Deleted.
- runtime/ArrayIteratorConstructor.h: Removed.
(JSC::ArrayIteratorConstructor::create): Deleted.
(JSC::ArrayIteratorConstructor::createStructure): Deleted.
(JSC::ArrayIteratorConstructor::ArrayIteratorConstructor): Deleted.
- runtime/ArrayIteratorPrototype.cpp:
(JSC::ArrayIteratorPrototype::finishCreation):
(JSC::arrayIteratorProtoFuncIterator): Deleted.
- runtime/IteratorPrototype.cpp: Renamed from Source/JavaScriptCore/runtime/ArrayIteratorConstructor.cpp.
(JSC::IteratorPrototype::finishCreation):
- runtime/IteratorPrototype.h: Renamed from Source/JavaScriptCore/runtime/SetIteratorConstructor.h.
(JSC::IteratorPrototype::create):
(JSC::IteratorPrototype::createStructure):
(JSC::IteratorPrototype::IteratorPrototype):
- runtime/JSFunction.cpp:
(JSC::JSFunction::createBuiltinFunction):
- runtime/JSFunction.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::iteratorPrototype):
- runtime/MapIteratorConstructor.cpp: Removed.
(JSC::MapIteratorConstructor::finishCreation): Deleted.
- runtime/MapIteratorConstructor.h: Removed.
(JSC::MapIteratorConstructor::create): Deleted.
(JSC::MapIteratorConstructor::createStructure): Deleted.
(JSC::MapIteratorConstructor::MapIteratorConstructor): Deleted.
- runtime/MapIteratorPrototype.cpp:
(JSC::MapIteratorPrototype::finishCreation): Deleted.
(JSC::MapIteratorPrototypeFuncIterator): Deleted.
- runtime/SetIteratorConstructor.cpp: Removed.
(JSC::SetIteratorConstructor::finishCreation): Deleted.
- runtime/SetIteratorConstructor.h:
(JSC::SetIteratorConstructor::create): Deleted.
(JSC::SetIteratorConstructor::createStructure): Deleted.
(JSC::SetIteratorConstructor::SetIteratorConstructor): Deleted.
- runtime/SetIteratorPrototype.cpp:
(JSC::SetIteratorPrototype::finishCreation): Deleted.
(JSC::SetIteratorPrototypeFuncIterator): Deleted.
- runtime/StringIteratorConstructor.cpp:
(JSC::StringIteratorConstructor::finishCreation): Deleted.
- runtime/StringIteratorConstructor.h: Removed.
(JSC::StringIteratorConstructor::create): Deleted.
(JSC::StringIteratorConstructor::createStructure): Deleted.
(JSC::StringIteratorConstructor::StringIteratorConstructor): Deleted.
- runtime/StringIteratorPrototype.cpp:
(JSC::StringIteratorPrototype::finishCreation):
(JSC::stringIteratorPrototypeIterator): Deleted.
- tests/stress/iterator-prototype.js: Added.
(shouldBe):
(inheritIteratorPrototype):
(testChain):
- 7:10 PM Changeset in webkit [185576] by
-
- 2 edits in trunk/Source/WebKit2
[iOS WK2] position:fixed elements sometimes truncated on scroll view bouncing
https://bugs.webkit.org/show_bug.cgi?id=146000
rdar://problem/19448439
Reviewed by Benjamin Poulain.
When in the middle of a rubber-band (UIScrollView bounce), we could send a bad
fixed position rect down to WebCore, causing 100% height elements to get laid out
at the wrong height, possible too short. This occurred when -_updateVisibleContentRects
said we were in a stable state, but the rubber-band offset caused WebPageProxy::computeCustomFixedPositionRect()
to compute a bad rect via constrainedUnobscuredRect.intersect(documentRect).
Fix by not claiming to be in a stable state during rubber-banding. Added _scrollViewIsRubberBanding
to compute that, taking care with floating point comparisons for 3x devices.
- UIProcess/API/Cocoa/WKWebView.mm:
(isGreaterInDevicePixels):
(-[WKWebView _scrollViewIsRubberBanding]):
(-[WKWebView _updateVisibleContentRects]):
- 6:57 PM Changeset in webkit [185575] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Removed a superfluous console.log per Chris's comment.
- public/v2/app.js:
- 6:40 PM Changeset in webkit [185574] by
-
- 5 edits in trunk/Websites/perf.webkit.org
Analysis task should show all possible revisions for A/B testing
https://bugs.webkit.org/show_bug.cgi?id=145996
Reviewed by Chris Dumez.
- public/api/commits.php:
(fetch_commits_between): When the time stamp is not available for commits, use revision numbers
to find revisions between two ranges. This is necessary for OS X and iOS versions since they don't
have a "commit time".
- public/v2/app.js:
(App.AnalysisTaskController.updateRootConfigurations): Fetch commits between two end points.
(App.AnalysisTaskController._createConfiguration): Extracted from updateRootConfigurations. List
the fetched list of commits if available.
(App.AnalysisTaskController._serializeNumbersSkippingConsecutiveEntries): Added. Serializes an list
of numbers intelligently. For example, [1, 2, 4, 5] turns into "1-2, 4-5". Without this, some lists
of points shown in the A/B testing configurations become too long.
- public/v2/commits-viewer.js:
(App.CommitsViewerComponent.commitsChanged):
- public/v2/data.js:
(CommitLogs.fetchCommits): Renamed from fetchForTimeRange.
- 5:40 PM Changeset in webkit [185573] by
-
- 2 edits in trunk/Source/WebCore
AX: Changing state of radio buttons causes VoiceOver to go busy for a short time.
https://bugs.webkit.org/show_bug.cgi?id=145933
Reviewed by Dean Jackson.
When radio buttons animate the new focus selection state, the thread activity looks a lot like short burst of
activity to draw, then wait on CoreAnimation to apply those changes.
Since those periods of activity during animation are so short, VoiceOver is not able to query for all the
attributes it needs, and gets stuck in the queue behind rendering.
The fix here is to turn off button state animations while VoiceOver is running.
- platform/mac/ThemeMac.mm:
(WebCore::updateStates):
- 4:56 PM Changeset in webkit [185572] by
-
- 4 edits2 adds in trunk
RootInlineBox::m_lineBreakObj becomes invalid when a child renderer is removed and the line does not get marked dirty.
https://bugs.webkit.org/show_bug.cgi?id=145988
rdar://problem/20959137
Reviewed by David Hyatt.
This patch ensures that we find the right first inline box so that we can dirty the
the appropriate line boxes.
With marking the right line boxes dirty, now we can update RootInlineBox::m_lineBreakObj at the next layout.
Source/WebCore:
Test: fast/inline/crash-when-child-renderer-is-removed-and-line-stays-clean.html
- rendering/RenderInline.cpp:
(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):
- rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::setLineBreakInfo): Deleted. Remove misleading assert and comment.
LayoutTests:
- fast/inline/crash-when-child-renderer-is-removed-and-line-stays-clean-expected.txt: Added.
- fast/inline/crash-when-child-renderer-is-removed-and-line-stays-clean.html: Added.
- 4:32 PM Changeset in webkit [185571] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Stylize Node Previews
https://bugs.webkit.org/show_bug.cgi?id=145990
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-15
Reviewed by Timothy Hatcher.
- UserInterface/Views/FormattedValue.js:
(WebInspector.FormattedValue.createElementForNodePreview):
Style a node preview like a DOMNode. It is a simple small snippet.
- UserInterface/Views/ObjectPreviewView.js:
(WebInspector.ObjectPreviewView.prototype._appendPropertyPreviews):
Use node previews in ObjectPreviewViews.
- 4:06 PM Changeset in webkit [185570] by
-
- 3 edits in trunk/Source/WebCore
Media Session: Improve the safety of playback toggling
https://bugs.webkit.org/show_bug.cgi?id=145986
Patch by Matt Rajca <mrajca@apple.com> on 2015-06-15
Reviewed by Darin Adler.
- Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::togglePlayback): Improved the safety of the loop so that we don't re-visit elements that
may have been deleted underneath us.
- Modules/mediasession/MediaSession.h: Added a pointer to the set of iterated active participating elements so we can remove any elements that are deleted from the underlying "real" set.
- 3:48 PM Changeset in webkit [185569] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r175251, Mavericks Only): Playback may stall
https://bugs.webkit.org/show_bug.cgi?id=145989
<rdar://problem/21271919>
Reviewed by Dean Jackson.
Revert r175251 for Mavericks build targets.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoLayer):
(WebCore::MediaPlayerPrivateAVFoundationObjC::createVideoOutput):
(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):
- 3:27 PM Changeset in webkit [185568] by
-
- 2 edits in trunk/Source/WebKit2
Fix build break when ENABLE_SECCOMP_FILTERS is ON
https://bugs.webkit.org/show_bug.cgi?id=145967
Reviewed by Carlos Garcia Campos.
Since r183189, ArgumentEncoder::addAttachment requires rvalue reference.
- Shared/linux/SeccompFilters/OpenSyscall.cpp:
(WebKit::OpenSyscallResult::encode): Use WTF::move().
- 3:01 PM Changeset in webkit [185567] by
-
- 3 edits3 adds in trunk
REGRESSION (r182215): Reproducible crash at drawsvg.org due to reentrant layout
https://bugs.webkit.org/show_bug.cgi?id=145964
Reviewed by Simon Fraser.
Source/WebCore:
Test: svg/as-object/mutate-on-load.html
- page/FrameView.cpp:
(WebCore::FrameView::forceLayoutParentViewIfNeeded): Don't do a synchronous layout here,
because it can lead indirectly to unwanted layout reentrancy. Instead schedule a layout.
LayoutTests:
- svg/as-object/mutate-on-load-expected.html: Added.
- svg/as-object/mutate-on-load.html: Added.
- svg/as-object/resources/embedded-mutates-on-load.svg: Added.
- 2:26 PM Changeset in webkit [185566] by
-
- 3 edits3 adds in trunk
JIT bug - fails when inspector closed, works when open
https://bugs.webkit.org/show_bug.cgi?id=145243
Reviewed by Oliver Hunt.
Source/JavaScriptCore:
We need to provide the Arguments object as the base when creating the HeapLocation for
GetFromArguments and PutToArguments. Otherwise we endup creating a HeapLocation for
any arguments object, not the one we need.
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
LayoutTests:
New regression test.
- js/regress-145243-expected.txt: Added.
- js/regress-145243.html: Added.
- js/script-tests/regress-145243.js: Added.
(bar):
(foo):
(test):
- 12:47 PM Changeset in webkit [185565] by
-
- 5 edits in tags/Safari-601.1.35.1/Source
Versioning.
- 12:36 PM Changeset in webkit [185564] by
-
- 18 edits in tags/Safari-601.1.35.1
Merge r185487. rdar://problem/21277462
- 12:29 PM Changeset in webkit [185563] by
-
- 5 edits in trunk/Source/WebKit2
[WK2] BrowsingContextController.loadData API is leaking Navigation objects
https://bugs.webkit.org/show_bug.cgi?id=145977
<rdar://problem/21305706>
Reviewed by Darin Adler.
BrowsingContextController.loadData API was leaking Navigation objects.
The issue was due to WebPageProxy::loadData() creating a Navigation
object but not passing along the navigationID to the WebProcess when
sending the Messages::WebPage::LoadData IPC. As a result, the
WebProcess would use 0 as navigationID and we would end up creating a
new Navigation object later on for the same navigation.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadData):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadData):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 12:16 PM Changeset in webkit [185562] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Improve some cases of "Object?" Type Annotations
https://bugs.webkit.org/show_bug.cgi?id=145954
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-15
Reviewed by Timothy Hatcher.
- UserInterface/Views/TypeTokenView.js:
(WebInspector.TypeTokenView.prototype._displayTypeName):
The TypeSet inclusions cover all types, so we can use the leastCommonAncestor
name as long as the type set is just object or object and null/undefined.
If the typeset includes other primitives then it will gracefully go down
below to become something like Object or (many).
- 12:07 PM Changeset in webkit [185561] by
-
- 1 copy in tags/Safari-601.1.35.1
New Tag.
- 11:55 AM Changeset in webkit [185560] by
-
- 2 edits in trunk/Source/WebCore
Media Session: Active participating elements can change while being iterated
https://bugs.webkit.org/show_bug.cgi?id=145978
Patch by Matt Rajca <mrajca@apple.com> on 2015-06-15
Reviewed by Alex Christensen.
- Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::togglePlayback): Iterate through a copy of m_activeParticipatingElements since its contents
can be modified in the loop.
- 11:50 AM Changeset in webkit [185559] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, gardening for Windows.
- platform/win/TestExpectations:
- 11:39 AM Changeset in webkit [185558] by
-
- 9 edits2 adds in trunk
AX: no accessibility support for details element
https://bugs.webkit.org/show_bug.cgi?id=131111
Reviewed by Darin Adler.
Source/WebCore:
Add accessibility support for Mac for details element by:
1) Returning new subroles for <details> and <summary>
2) Exposing isExpanded property for <details> element.
Test: platform/mac/accessibility/details-summary.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::supportsARIAPressed):
(WebCore::AccessibilityObject::supportsExpanded):
(WebCore::AccessibilityObject::isExpanded):
(WebCore::AccessibilityObject::supportsARIAExpanded): Deleted.
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::canvasHasFallbackContent):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilitySupportsARIAExpanded]):
(-[WebAccessibilityObjectWrapper accessibilityIsExpanded]):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
- html/HTMLDetailsElement.h:
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::buildObjectForAccessibilityProperties):
LayoutTests:
- platform/mac/accessibility/details-summary-expected.txt: Added.
- platform/mac/accessibility/details-summary.html: Added.
- 11:08 AM Changeset in webkit [185557] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r185298): Databases service has Web Content service’s entitlements
https://bugs.webkit.org/show_bug.cgi?id=145980
Reviewed by Darin Adler.
- Configurations/DatabaseService.xcconfig: Set WK_XPC_SERVICE_IOS_ENTITLEMENTS_BASE to
Databases-iOS.
- 11:07 AM Changeset in webkit [185556] by
-
- 5 edits in trunk/Source/WebKit2
[WK2] Add allowsPictureInPictureMediaPlayback
https://bugs.webkit.org/show_bug.cgi?id=145901
rdar://problem/21349851
Reviewed by Anders Carlsson.
Replace _allowsAlternateFullscreen with allowsPictureInPictureMediaPlayback.
- UIProcess/API/Cocoa/WKWebViewConfiguration.h: Add allowsPictureInPictureMediaPlayback.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration init]): Remove _allowsAlternateFullscreen.
(-[WKWebViewConfiguration copyWithZone:]): Replace the variable.
(-[WKWebViewConfiguration _allowsAlternateFullscreen]): Deleted.
(-[WKWebViewConfiguration _setAllowsAlternateFullscreen:]): Deleted.
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h: Remove the SPI.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]): Update to use the new API.
- 10:23 AM Changeset in webkit [185555] by
-
- 6 edits in trunk
Source/WebCore:
[Content Extensions] Limit number of rules.
https://bugs.webkit.org/show_bug.cgi?id=145663
Patch by Alex Christensen <achristensen@webkit.org> on 2015-06-15
Reviewed by Benjamin Poulain.
Added an API test to make sure that parsing fails when there are too many rules.
- contentextensions/ContentExtensionError.cpp:
(WebCore::ContentExtensions::contentExtensionErrorCategory):
- contentextensions/ContentExtensionError.h:
- contentextensions/ContentExtensionParser.cpp:
(WebCore::ContentExtensions::loadEncodedRules):
Fail to parse a content extension with more than 50000 rules.
Tools:
[Content Extensions] Make max NFA size and max rule count user defaults.
https://bugs.webkit.org/show_bug.cgi?id=145663
Patch by Alex Christensen <achristensen@webkit.org> on 2015-06-15
Reviewed by Benjamin Poulain.
- TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
(TestWebKitAPI::TEST_F):
- 9:57 AM Changeset in webkit [185554] by
-
- 14 edits in trunk
-[WKWebView evaluateJavaScript] provides a misleading error when the return cannot be serialized
https://bugs.webkit.org/show_bug.cgi?id=145900
Reviewed by Sam Weinig.
Source/WebCore:
- English.lproj/Localizable.strings:
Source/WebKit2:
We used to conflate to cases: (1) when there was a JavaScript exception, and
(2) when the result could not be serialized for IPC. Turns out that it was quite
misleading!
- UIProcess/API/C/WKPage.cpp:
(WKPageRunJavaScriptInMainFrame):
- UIProcess/API/Cocoa/WKError.h:
- UIProcess/API/Cocoa/WKError.mm:
(localizedDescriptionForErrorCode):
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView evaluateJavaScript:completionHandler:]):
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runJavaScriptInMainFrame):
(WebKit::WebPageProxy::scriptValueCallback):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScriptInMainFrame):
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_run_javascript):
(resourcesStreamReadCallback):
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/WKWebViewEvaluateJavaScript.mm:
(TEST): Added tests.
- 9:36 AM Changeset in webkit [185553] by
-
- 8 edits in trunk
[SOUP] Custom URI schemes don't work for requests containing a fragment identifier
https://bugs.webkit.org/show_bug.cgi?id=145969
Reviewed by Sergio Villar Senin.
Source/WebCore:
For URIs like foo:bar#baz, what the custom protocol manager
receives in the UI process is foo:bar, so the user can't handle fragments.
- platform/network/soup/ResourceRequestSoup.cpp:
(WebCore::ResourceRequest::updateSoupRequest): If the SoupRequest
is a WebKitSoupRequestGeneric, call
webkitSoupRequestGenericSetRequest with the ResourceRequest.
- platform/network/soup/WebKitSoupRequestGeneric.cpp:
(webkitSoupRequestGenericSetRequest):
(webkitSoupRequestGenericGetRequest):
- platform/network/soup/WebKitSoupRequestGeneric.h:
Source/WebKit2:
Use the WebKitSoupRequestGeneric request instead of creating a new one
from the SoupRequest URI, since that is the network one and doesn't
contain the fragment identifier part.
- Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp:
(WebKit::CustomProtocolManagerImpl::start):
Tools:
Add a test case to the custom URI schemes unit test.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
(testWebContextURIScheme):
- 8:43 AM Changeset in webkit [185552] by
-
- 4 edits in trunk/Source/WebKit2
[EFL] Make send/receive messages to communicate the Web and UI Processes using Injected Bundle.
https://bugs.webkit.org/show_bug.cgi?id=145685
Patch by Hyungwook Lee <hyungwook.lee@navercorp.com> on 2015-06-15
Reviewed by Gyuyoung Kim.
To have extensible port specific API facility using Injected Bundle,
we need to load libewebkit_extension_manager.so in default that is same as what gtk port does.
- UIProcess/API/efl/ewk_context.cpp:
(EwkContext::EwkContext):
(EwkContext::~EwkContext):
(EwkContext::findOrCreateWrapper):
(bundlePathForExtension):
(EwkContext::create): Deleted.
- UIProcess/API/efl/ewk_context_private.h:
- WebProcess/efl/ExtensionManagerEfl.cpp:
(WebKit::ExtensionManagerEfl::initialize):
- 8:34 AM Changeset in webkit [185551] by
-
- 8 edits3 moves in trunk/Source
[SOUP] Move WebKitSoupRequestGeneric to platform layer
https://bugs.webkit.org/show_bug.cgi?id=145968
Reviewed by Sergio Villar Senin.
Source/WebCore:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- platform/network/soup/WebKitSoupRequestGeneric.cpp: Renamed from Source/WebKit2/WebProcess/soup/WebKitSoupRequestGeneric.cpp.
(webkitSoupRequestGenericFinalize):
(webkit_soup_request_generic_init):
(webkitSoupRequestGenericSendAsync):
(webkitSoupRequestGenericSendFinish):
(webkitSoupRequestGenericGetContentLength):
(webkitSoupRequestGenericGetContentType):
(webkit_soup_request_generic_class_init):
(webkitSoupRequestGenericSetContentLength):
(webkitSoupRequestGenericSetContentType):
- platform/network/soup/WebKitSoupRequestGeneric.h: Renamed from Source/WebKit2/WebProcess/soup/WebKitSoupRequestGeneric.h.
- platform/network/soup/WebKitSoupRequestGenericClient.h: Renamed from Source/WebKit2/WebProcess/soup/WebKitSoupRequestGenericClient.h.
Source/WebKit2:
- PlatformEfl.cmake: Remove WebKitSoupRequestGeneric.
- PlatformGTK.cmake: Ditto.
- Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp:
- Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.h:
- 6:09 AM Changeset in webkit [185550] by
-
- 2 edits1 add in trunk/Tools
[GTK] Fix deprecated-register warning in the generated WebKitMarshal.cpp
https://bugs.webkit.org/show_bug.cgi?id=145922
Reviewed by Carlos Garcia Campos.
- gtk/jhbuild.modules:
- gtk/patches/glib-warning-fix.patch: Added.
- 4:20 AM Changeset in webkit [185549] by
-
- 4 edits in trunk/Source/WebKit2
Fix unused private field warning in PageBanner.h
https://bugs.webkit.org/show_bug.cgi?id=145925
Reviewed by Darin Adler.
- WebProcess/WebPage/PageBanner.cpp:
(WebKit::PageBanner::~PageBanner):
- WebProcess/WebPage/PageBanner.h: Initialize m_type, m_webPage, m_mouseDownInBanner, and m_isHidden here instead of in the constructor.
- WebProcess/WebPage/mac/PageBannerMac.mm: Use PLATFORM(MAC) instead of !PLATFORM(IOS), they are same in objc files.
- 4:09 AM Changeset in webkit [185548] by
-
- 5 edits1 add in trunk/Source/WebKit2
[SOUP] Make WebKitSoupRequestGeneric independent from CustomProtocolManagerImpl
https://bugs.webkit.org/show_bug.cgi?id=145966
Reviewed by Sergio Villar Senin.
Add WebKitSoupRequestGenericClient with start and finish methods,
that are implemented by WebKitSoupRequestGeneric.
This allows us to move WebKitSoupRequestGeneric to platform layer.
- Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.cpp:
(WebKit::CustomProtocolManagerImpl::registerScheme):
(WebKit::CustomProtocolManagerImpl::start):
- Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.h:
- WebProcess/soup/WebKitSoupRequestGeneric.cpp:
(webkitSoupRequestGenericSendAsync):
(webkitSoupRequestGenericSendFinish):
- WebProcess/soup/WebKitSoupRequestGeneric.h:
- WebProcess/soup/WebKitSoupRequestGenericClient.h: Added.
Jun 14, 2015:
- 9:13 PM Changeset in webkit [185547] by
-
- 2 edits in trunk/Source/WebKit2
Fixed the build.
- mac/postprocess-framework-headers.sh:
- 2:10 PM Changeset in webkit [185546] by
-
- 3 edits in trunk/Source/WebKit2
Format string misuse in DatabaseProcessIDBConnection.cpp and UniqueIDBDatabaseBackingStoreSQLite.cpp
https://bugs.webkit.org/show_bug.cgi?id=145960
Reviewed by Darin Adler.
Use PRIu64 and PRIi64 to print uint64_t and int64_t, respectively. These things are
different types on x86_64 Linux (unsigned long) and on Mac (unsigned long long).
- DatabaseProcess/IndexedDB/DatabaseProcessIDBConnection.cpp:
(WebKit::DatabaseProcessIDBConnection::getOrEstablishIDBDatabaseMetadata):
(WebKit::DatabaseProcessIDBConnection::deleteDatabase):
(WebKit::DatabaseProcessIDBConnection::openTransaction):
(WebKit::DatabaseProcessIDBConnection::beginTransaction):
(WebKit::DatabaseProcessIDBConnection::commitTransaction):
(WebKit::DatabaseProcessIDBConnection::resetTransaction):
(WebKit::DatabaseProcessIDBConnection::rollbackTransaction):
(WebKit::DatabaseProcessIDBConnection::changeDatabaseVersion):
(WebKit::DatabaseProcessIDBConnection::createObjectStore):
(WebKit::DatabaseProcessIDBConnection::deleteObjectStore):
(WebKit::DatabaseProcessIDBConnection::clearObjectStore):
(WebKit::DatabaseProcessIDBConnection::createIndex):
(WebKit::DatabaseProcessIDBConnection::deleteIndex):
(WebKit::DatabaseProcessIDBConnection::putRecord):
(WebKit::DatabaseProcessIDBConnection::getRecord):
(WebKit::DatabaseProcessIDBConnection::count):
(WebKit::DatabaseProcessIDBConnection::deleteRange):
(WebKit::DatabaseProcessIDBConnection::openCursor):
(WebKit::DatabaseProcessIDBConnection::cursorAdvance):
(WebKit::DatabaseProcessIDBConnection::cursorIterate):
- DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::clearObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteIndex):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::generateKeyNumber):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::keyExistsInObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::putRecord):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::uncheckedPutIndexRecord):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::deleteRecord):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getKeyRecordFromObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::getKeyRangeRecordFromObjectStore):
(WebKit::UniqueIDBDatabaseBackingStoreSQLite::advanceCursor):
- 2:00 PM Changeset in webkit [185545] by
-
- 2 edits in trunk/Source/WebKit2
[Cocoa] Clean up postprocess-framework-headers.sh
https://bugs.webkit.org/show_bug.cgi?id=145962
Reviewed by Darin Adler.
- mac/postprocess-framework-headers.sh: Gather all the sed options in a variable, and then
run sed only once on each header. Also, correctly exit with the sed return value if it
fails.
- 1:37 AM Changeset in webkit [185544] by
-
- 2 edits in trunk/Source/WebInspectorUI
[GTK] Web Inspector: Update icon so Rendering Frames timeline distinguish between layout and painting
https://bugs.webkit.org/show_bug.cgi?id=145956
Reviewed by Carlos Garcia Campos.
- UserInterface/Images/gtk/TimelineRecordPaint.svg:
Changed to use green color.
Jun 13, 2015:
- 11:57 PM Changeset in webkit [185543] by
-
- 1 edit1 move1 delete in trunk/LayoutTests
AX: WebKit exposes all Ruby Text as Unknown (Japanese EPUB accessibility blocker)
https://bugs.webkit.org/show_bug.cgi?id=141303
Unreviewed. Move ruby tests to Mac platform only, since they don't apply to other platforms.
- accessibility/ruby-hierarchy-roles-expected.txt: Removed.
- accessibility/ruby-hierarchy-roles.html: Removed.
- platform/mac/accessibility/ruby-hierarchy-roles.html: Copied from LayoutTests/accessibility/ruby-hierarchy-roles.html.
- 9:53 PM Changeset in webkit [185542] by
-
- 13 edits in trunk/Source
[WK2] API::Navigation objects are leaked on history navigation to HistoryItems in PageCache
https://bugs.webkit.org/show_bug.cgi?id=145948
Reviewed by Darin Adler.
Source/WebCore:
API::Navigation objects were leaked on history navigation to
HistoryItems in PageCache. In such case, we would create 2 Navigation
objects instead of 1 and the first one would be leaked. The reason
we create the second one is because we fail to pass along the
navigationID from the UIProcess to the WebProcess and then back to the
UIProcess. On the IPC back to the UIProcess, the navigationID ends up
being 0 so the UIProcess creates a new Navigation object, thinking that
the load was triggered by the WebContent process.
We now pass along the navigationID, even if the HistoryItem is in the
PageCache and we end up reusing the cached DocumentLoader, instead of
creating a new one. A new updateCachedDocumentLoader() delegate is
added to the FrameLoaderClient, similarly to the pre-existing
createDocumentLoader() but for the case where the DocumentLoader gets
reused.
- loader/EmptyClients.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadDifferentDocumentItem):
- loader/FrameLoaderClient.h:
Source/WebKit/mac:
Add empty implementation for new
FrameLoaderClient::updatedCachedDocumentLoader().
- WebCoreSupport/WebFrameLoaderClient.h:
Source/WebKit/win:
Add empty implementation for new
FrameLoaderClient::updatedCachedDocumentLoader().
- WebCoreSupport/WebFrameLoaderClient.h:
Source/WebKit2:
API::Navigation objects were leaked on history navigation to
HistoryItems in PageCache. In such case, we would create 2 Navigation
objects instead of 1 and the first one would be leaked. The reason
we create the second one is because we fail to pass along the
navigationID from the UIProcess to the WebProcess and then back to the
UIProcess. On the IPC back to the UIProcess, the navigationID ends up
being 0 so the UIProcess creates a new Navigation object, thinking that
the load was triggered by the WebContent process.
We now pass along the navigationID, even if the HistoryItem is in the
PageCache and we end up reusing the cached DocumentLoader, instead of
creating a new one. A new updateCachedDocumentLoader() delegate is
added to the FrameLoaderClient, similarly to the pre-existing
createDocumentLoader() but for the case where the DocumentLoader gets
reused.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::updateCachedDocumentLoader):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::goForward):
(WebKit::WebPage::goBack):
(WebKit::WebPage::goToBackForwardItem):
(WebKit::WebPage::updateCachedDocumentLoader):
- WebProcess/WebPage/WebPage.h:
- 5:24 PM Changeset in webkit [185541] by
-
- 6 edits in trunk/Source/WebKit2
Add private API to force page to always run at foreground priority
https://bugs.webkit.org/show_bug.cgi?id=145946
<rdar://problem/21267221>
Reviewed by Anders Carlsson.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView initWithFrame:configuration:]):
- copy _alwaysRunsAtForegroundPriority to WebPageConfiguration.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _alwaysRunsAtForegroundPriority]):
(-[WKWebViewConfiguration _setAlwaysRunsAtForegroundPriority:]):
- added _alwaysRunsAtForegroundPriority.
- UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:
- added _alwaysRunsAtForegroundPriority.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
- initialize m_alwaysRunsAtForegroundPriority.
(WebKit::WebPageProxy::updateActivityToken):
- if m_alwaysRunsAtForegroundPriority is set always take the foreground activity token.
- UIProcess/WebPageProxy.h:
- added m_alwaysRunsAtForegroundPriority, alwaysRunsAtForegroundPriority.
- 1:42 PM Changeset in webkit [185540] by
-
- 6 edits1 copy1 add in trunk
Web Inspector: console.table() with a list of objects no longer works
https://bugs.webkit.org/show_bug.cgi?id=145952
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-13
Reviewed by Timothy Hatcher.
Source/JavaScriptCore:
- inspector/InjectedScriptSource.js:
(InjectedScript.RemoteObject.prototype._generatePreview):
Calling generatePreview again was actually starting with a preview
of the current object instead of the sub-value. Go down the other
path that correctly generates sub-previews. Leave filtering on the
backend unimplemented, which we were already ignoring.
Source/WebInspectorUI:
- UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._appendMessageTextAndArguments):
(WebInspector.ConsoleMessageView.prototype._formatParameterAsTable):
Don't allow expanding a cosole.table message, and don't output the total
object even if the table preview was lossless, as the experience is poor.
LayoutTests:
- inspector/console/console-api.html:
- inspector/console/console-table-expected.txt: Added.
- inspector/console/console-table.html:
Add a similiar console API test all about console.table().
- 12:28 PM Changeset in webkit [185539] by
-
- 3 edits2 adds in trunk/Websites/perf.webkit.org
Add a script to post new OS X builds to perf dashboard
https://bugs.webkit.org/show_bug.cgi?id=145955
Reviewed by Darin Adler.
Added a new script pull-osx.py and relaxed the restrictions on commits accepted by the dashboard API.
- public/api/report-commits.php:
(main): Allow more characters than [A-Za-z0-9] in revision. e.g. "10.10.3 14D136".
Also allow commits without the author, commit time, and commit message as OS versions do not have those.
- tools/pull-osx.py: Added.
(main): Fetch the list of builds from a website and submit them per submissionSize with submissionInterval.
Once all builds have been submitted, wait for a long time as specified by fetchInterval.
(setup_auth): Sets up basic or digest auth to access the dashboard.
(fetch_available_builds): Fetches and parses the XML document from an internal website.
(textContent): A helper function to get the text content out of a XML node.
(submit_commits): Submits commits to the perf dashboard.
- tools/pull-svn.py:
(fetch_commit):
- tools/util.py: Extracted submit_commits and text_content from pull-svn.py to be reused in pull-osx.py.
- 8:25 AM Changeset in webkit [185538] by
-
- 2 edits in trunk/LayoutTests
[EFL] Mark fast/forms/select-element-focus-ring.html to Missing
Unreviwed, gardening for EFL port.
- platform/efl/TestExpectations: The test was added only for Mac port.
- 2:09 AM Changeset in webkit [185537] by
-
- 11 edits in trunk
[Streams API] ReadableJSStream should handle promises returned by JS source start callback
https://bugs.webkit.org/show_bug.cgi?id=145792
Source/JavaScriptCore:
Reviewed by Darin Adler.
Added support for JSFunction implemented by std::function.
- runtime/JSFunction.cpp:
(JSC::getNativeExecutable): Refactored code to share it with the two JSFunction::create
(JSC::JSFunction::create):
(JSC::runStdFunction):
- runtime/JSFunction.h: Added std::function based JSFunction::create prototype.
- runtime.JSPromise.h:
Source/WebCore:
Reviewed by Darin Adler.
Covered by rebased tests.
When calling start callback, the returned value is checked.
If it is not a promise, we do as if it is a resolved promise.
If it is a promise, we call its then() method with two resolve/reject JS functions.
- Modules/streams/ReadableStream.cpp:
- bindings/js/ReadableJSStream.cpp:
(WebCore::ReadableJSStream::invoke): Returns a JSPromise* if any is returned by the JS source callback.
(WebCore::thenPromise): Utility method to call the promise.
(WebCore::createStartResultFulfilledFunction): The promise resolve callback.
(WebCore::ReadableJSStream::doStart): Calls thenPromise if a JSPromise* is returned by invoke.
(WebCore::ReadableJSStream::ReadableJSStream):
- bindings/js/ReadableJSStream.h:
LayoutTests:
Reviewed by Darin Adler.
Rebasing expectations, and removing timeouts for tests that no longer timeout.
- streams/reference-implementation/readable-stream-expected.txt:
- streams/reference-implementation/readable-stream.html:
- 1:29 AM Changeset in webkit [185536] by
-
- 5 edits4 adds in trunk
AX: WebKit exposes all Ruby Text as Unknown (Japanese EPUB accessibility blocker)
https://bugs.webkit.org/show_bug.cgi?id=141303
Patch by Andres Gonzalez <agonzalez334@nc.rr.com> on 2015-06-13
Reviewed by Chris Fleizach.
Source/WebCore:
Test: accessibility/ruby-hierarchy-roles.html
- accessibility/AccessibilityObject.h:
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(createAccessibilityRoleMap):
(-[WebAccessibilityObjectWrapper subrole]):
LayoutTests:
- accessibility/ruby-hierarchy-roles-expected.txt: Added.
- accessibility/ruby-hierarchy-roles.html: Added.
- platform/mac-mavericks/accessibility/ruby-hierarchy-roles-expected.txt: Added.
- platform/mac/accessibility/ruby-hierarchy-roles-expected.txt: Added.
- 1:16 AM Changeset in webkit [185535] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Perf dashboard's v2 UI shouldn't hide auto-detected outliers
https://bugs.webkit.org/show_bug.cgi?id=145940
Reviewed by Darin Adler.
Don't fallback to the default strategies for moving averages and envelope when one is not specified.
Also deleted the code to mark points outside the envelop as outliers.
- public/v2/app.js:
Jun 12, 2015:
- 11:31 PM Changeset in webkit [185534] by
-
- 4 edits in trunk/Source/WebCore
AX: iOS: after updating control, VoiceOver speaks aria-expanded states reversed (says "collapsed" when "expanded")
https://bugs.webkit.org/show_bug.cgi?id=145943
Reviewed by Darin Adler.
iOS Accessibility platform needs to be notified of when aria expanded changes.
- accessibility/ios/AXObjectCacheIOS.mm:
(WebCore::AXObjectCache::postPlatformNotification):
- accessibility/ios/WebAccessibilityObjectWrapperIOS.h:
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper postValueChangedNotification]):
(-[WebAccessibilityObjectWrapper postExpandedChangedNotification]):
(-[WebAccessibilityObjectWrapper postScrollStatusChangeNotification]):
- 11:04 PM Changeset in webkit [185533] by
-
- 8 edits in trunk
AX:ARIA Toggle buttons aren't properly conveyed on iOS using VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=145949
Reviewed by Darin Adler.
Source/WebCore:
Expose pressed state information to the iOS platform AX API.
Test: Updated inspector-protocol/dom/getAccessibilityPropertiesForNode.html
There was a FIXME for this issue in that test: https://bugs.webkit.org/show_bug.cgi?id=129830
- accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isPressed):
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::classList):
(WebCore::AccessibilityObject::supportsARIAPressed):
(WebCore::AccessibilityObject::supportsARIAExpanded):
- accessibility/AccessibilityObject.h:
- accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityARIALiveRegionIsAtomic]):
(-[WebAccessibilityObjectWrapper accessibilitySupportsARIAPressed]):
(-[WebAccessibilityObjectWrapper accessibilityIsPressed]):
(-[WebAccessibilityObjectWrapper accessibilitySupportsARIAExpanded]):
LayoutTests:
- inspector-protocol/dom/getAccessibilityPropertiesForNode-expected.txt:
- inspector-protocol/dom/getAccessibilityPropertiesForNode.html:
- 8:52 PM Changeset in webkit [185532] by
-
- 22 edits in trunk/Source
Purge PassRefPtr in JavaScriptCore - 2
https://bugs.webkit.org/show_bug.cgi?id=145834
Reviewed by Darin Adler.
Source/JavaScriptCore:
As a step to remove PassRefPtr, this patch cleans up PassRefPtr as much as possible
in JavaScriptCore.
- API/JSClassRef.cpp:
(OpaqueJSClass::create):
- API/JSClassRef.h:
- debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::callerFrame):
- debugger/DebuggerCallFrame.h:
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::jitCode):
- inspector/ScriptCallStackFactory.cpp:
(Inspector::createScriptCallStack):
(Inspector::createScriptCallStackForConsole):
(Inspector::createScriptCallStackFromException):
(Inspector::createScriptArguments):
- inspector/ScriptCallStackFactory.h:
- jit/ExecutableAllocator.cpp:
(JSC::ExecutableAllocator::allocate):
- jit/ExecutableAllocator.h:
- jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::ExecutableAllocator::allocate):
- profiler/LegacyProfiler.cpp:
(JSC::LegacyProfiler::stopProfiling):
- profiler/LegacyProfiler.h:
- runtime/DateInstanceCache.h:
- runtime/Executable.cpp:
(JSC::ScriptExecutable::newCodeBlockFor):
- runtime/Executable.h:
- runtime/GenericTypedArrayView.h:
- runtime/GenericTypedArrayViewInlines.h:
(JSC::GenericTypedArrayView<Adaptor>::create):
(JSC::GenericTypedArrayView<Adaptor>::createUninitialized):
Source/WebCore:
Fix call sites depends on changing of JSC.
- html/canvas/WebGL2RenderingContext.cpp:
(WebCore::WebGL2RenderingContext::getParameter):
- html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::getParameter):
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::getUniform):
(WebCore::WebGLRenderingContextBase::getVertexAttrib):
(WebCore::WebGLRenderingContextBase::getWebGLFloatArrayParameter):
(WebCore::WebGLRenderingContextBase::getWebGLIntArrayParameter):
- 8:25 PM Changeset in webkit [185531] by
-
- 2 edits in trunk/Source/WebCore
Be more defensive at renderer type checking when initializing flow segments.
https://bugs.webkit.org/show_bug.cgi?id=145942
Reviewed by Simon Fraser.
FlowContents::initializeSegments should ignore unsupported renderers so that when we miss
a simple line layout path invalidation, we don't downcast the unsupported renderer to RenderText.
I have not reproduced this issue (but related to rdar://problem/21312452)
- rendering/SimpleLineLayoutFlowContents.cpp:
(WebCore::SimpleLineLayout::initializeSegments):
- 7:27 PM Changeset in webkit [185530] by
-
- 5 edits in trunk/Tools
Update springLoadingHighlight type
https://bugs.webkit.org/show_bug.cgi?id=145939
rdar://problem/20880213
Reviewed by Darin Adler.
- DumpRenderTree/mac/DumpRenderTreeDraggingInfo.h:
- DumpRenderTree/mac/DumpRenderTreeDraggingInfo.mm:
- WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.h:
- WebKitTestRunner/mac/WebKitTestRunnerDraggingInfo.mm:
- 6:40 PM Changeset in webkit [185529] by
-
- 4 edits in trunk/Source/WebKit2
Reimplement WKResourceCacheManagerRef on top of WKWebsiteDataStoreRef
https://bugs.webkit.org/show_bug.cgi?id=145951
Reviewed by Darin Adler.
- UIProcess/API/C/WKContext.cpp:
(WKContextGetResourceCacheManager):
- UIProcess/API/C/WKResourceCacheManager.cpp:
(WKResourceCacheManagerGetTypeID):
(toWebsiteDataTypes):
(WKResourceCacheManagerGetCacheOrigins):
(WKResourceCacheManagerClearCacheForOrigin):
(WKResourceCacheManagerClearCacheForAllOrigins):
- 6:35 PM Changeset in webkit [185528] by
-
- 3 edits3 adds in trunk
Fix minor ES6 compliance issue in RegExp.prototype.toString and optimize performance a little
https://bugs.webkit.org/show_bug.cgi?id=145935
Reviewed by Anders Carlsson.
Source/JavaScriptCore:
Test: js/regexp-toString.html
- runtime/RegExpPrototype.cpp:
(JSC::getFlags): Avoid memory allocation for the flags string by returning it in a character
buffer instead of constructing a WTF::String for it.
(JSC::regExpProtoFuncToString): Require only that the this value be an object; don't require
that it is actually a regular expression object. This is covered in the ES6 specification.
Also removed comment about the "/(?:)/" trick since that is now the repsonsibility of the
getter for the "source" property. Updated to use getFlags so we do one less memory allocation.
(JSC::regExpProtoGetterFlags): Chagned to use getFlags instead of the old flagsString.
LayoutTests:
- js/regexp-toString-expected.txt: Added.
- js/regexp-toString.html: Added.
- js/script-tests/regexp-toString.js: Added.
- 5:30 PM Changeset in webkit [185527] by
-
- 4 edits in trunk/Source/WebKit2
Reimplement WKApplicationCacheManagerRef as WKWebsiteDataStoreRef
https://bugs.webkit.org/show_bug.cgi?id=145950
Reviewed by Dan Bernstein.
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKApplicationCacheManager.cpp:
(WKApplicationCacheManagerGetTypeID):
(WKApplicationCacheManagerGetApplicationCacheOrigins):
(WKApplicationCacheManagerDeleteEntriesForOrigin):
(WKApplicationCacheManagerDeleteAllEntries):
- UIProcess/API/C/WKContext.cpp:
(WKContextGetApplicationCacheManager):
(WKContextGetPluginSiteDataManager):
- 5:28 PM Changeset in webkit [185526] by
-
- 5 edits in branches/safari-600.1.4.16-branch/Source
Versioning.
- 5:18 PM Changeset in webkit [185525] by
-
- 3 edits in trunk/Source/WebCore
deleteEmptyDirectory should delete .DS_Store files on OS X
https://bugs.webkit.org/show_bug.cgi?id=145944
Reviewed by Dan Bernstein.
deleteEmptyDirectory is often used when clearing website data, so we should
take extra care to delete empty directories so the user won't think that clearing
website data didn't do anything because it would leave directories with .DS_Store
files behind.
- platform/mac/FileSystemMac.mm:
(WebCore::deleteEmptyDirectory):
- platform/posix/FileSystemPOSIX.cpp:
- 4:40 PM Changeset in webkit [185524] by
-
- 3 edits in trunk/Tools
Move cursor to (10, 0) instead of (0, 0) and polish the mouse move code
https://bugs.webkit.org/show_bug.cgi?id=145945
Patch by Dewei Zhu <Dewei Zhu> on 2015-06-12
Reviewed by Stephanie Lewis.
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
(OSXBrowserDriver.prepareEnv):
(OSXBrowserDriver.moveCursor): Deleted.
(OSXBrowserDriver): Deleted.
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
(OSXSafariDriver.prepareEnv):
- 3:49 PM Changeset in webkit [185523] by
-
- 2 edits in trunk/Websites/perf.webkit.org
Unreviewed build fix for merging platforms.
- public/admin/platforms.php:
- 3:08 PM Changeset in webkit [185522] by
-
- 2 edits in trunk/Tools
Revise update-webkit-dependency to use LWP::UserAgent instead of LWP::Simple for better handling of https
https://bugs.webkit.org/show_bug.cgi?id=145938
Reviewed by Alexey Proskuryakov.
- Scripts/update-webkit-dependency: Switch from LWP::Simple to
LWP::UserAgent to get access to more robust HTTPS support.
- 3:04 PM Changeset in webkit [185521] by
-
- 4 edits in trunk/Source/WebKit2
Clean up IndexedDB website data retrieval and removal
https://bugs.webkit.org/show_bug.cgi?id=145941
Reviewed by Andreas Kling.
- Use SecurityOrigin instead of SecurityOriginData; It's not possible to pass SecurityOriginData
safely between threads.
- Use std::chrono instead of double for modification times.
- Get rid of endTime since it's not used.
- Change deleteIndexedDatabaseEntriesForOrigin to deleteIndexedDatabaseEntriesForOrigins and make it take
a vector of origins instead of a single one.
- Get rid of deleteAllIndexedDatabaseEntries.
- Change SecurityOriginData::securityOrigin to call isolatedCopy on the origin components, since it's common
to pass origins to other threads and we want that to be safe.
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::fetchWebsiteData):
(WebKit::DatabaseProcess::deleteWebsiteData):
(WebKit::DatabaseProcess::deleteWebsiteDataForOrigins):
(WebKit::DatabaseProcess::indexedDatabaseOrigins):
(WebKit::removeAllDatabasesForOriginPath):
(WebKit::DatabaseProcess::deleteIndexedDatabaseEntriesForOrigins):
(WebKit::DatabaseProcess::deleteIndexedDatabaseEntriesModifiedSince):
(WebKit::DatabaseProcess::getIndexedDatabaseOrigins): Deleted.
(WebKit::DatabaseProcess::deleteIndexedDatabaseEntriesForOrigin): Deleted.
(WebKit::DatabaseProcess::deleteIndexedDatabaseEntriesModifiedBetweenDates): Deleted.
(WebKit::DatabaseProcess::deleteAllIndexedDatabaseEntries): Deleted.
- DatabaseProcess/DatabaseProcess.h:
- Shared/SecurityOriginData.cpp:
(WebKit::SecurityOriginData::securityOrigin):
- 2:01 PM Changeset in webkit [185520] by
-
- 5 edits in trunk
[CSS Grid Layout] Fix grid-template-areas parsing to avoid spaces
https://bugs.webkit.org/show_bug.cgi?id=145860
Reviewed by Sergio Villar Senin.
Source/WebCore:
The spec doesn't require to have spaces between unnamed and named areas
in grid-template-areas syntax. But spaces are currently required in our
code.
This was confirmed in the CSS WG mailing list:
https://lists.w3.org/Archives/Public/www-style/2015May/0239.html
This patch updates grid-template-areas parsing to allow the possibility
of removing spaces between unnamed and named areas.
Added new cases to fast/css-grid-layout/grid-template-areas-get-set.html.
- css/CSSParser.cpp:
(WebCore::parseGridTemplateAreasColumnNames): New helper method to
determine the column names split by white spaces or dots.
(WebCore::CSSParser::parseGridTemplateAreasRow): Use the new helper
method to get the column names.
(WebCore::containsOnlyDots): Deleted. Not needed anymore as
parseGridTemplateAreasColumnNames() is using a single dot for unnamed
grid areas (despite of being defined with 1 or more dots).
LayoutTests:
- fast/css-grid-layout/grid-template-areas-get-set-expected.txt:
- fast/css-grid-layout/grid-template-areas-get-set.html: Add new test
cases.
- 1:41 PM Changeset in webkit [185519] by
-
- 5 edits in trunk/Source/WebCore
[Mac] AirPlay menu button doesn't always show on page load
https://bugs.webkit.org/show_bug.cgi?id=145936
Reviewed by Brent Fulgham.
- Modules/mediasession/WebMediaSessionManager.cpp:
(WebCore::mediaProducerStateString): New, return a string representing MediaStateFlags.
(WebCore::WebMediaSessionManager::clientStateDidChange): Log the states as strings.
(WebCore::WebMediaSessionManager::toString): New, return a string representing ConfigurationTasks.
(WebCore::WebMediaSessionManager::scheduleDelayedTask): Add logging.
(WebCore::WebMediaSessionManager::taskTimerFired): Add logging.
- Modules/mediasession/WebMediaSessionManager.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h: Override wirelessVideoPlaybackDisabled so it is possible to activate route monitoring for a movie loaded with this engine.
- platform/graphics/mac/MediaPlayerPrivateQTKit.h: Ditto.
- 1:30 PM isectestpage created by
- 11:48 AM Changeset in webkit [185518] by
-
- 26 edits in trunk/Source/WebCore
Add the remaining missing override specifiers under Source/WebCore/
https://bugs.webkit.org/show_bug.cgi?id=145907
Reviewed by Darin Adler.
Fix the remaining compiler warnings about missing override specifiers
for overriding method declarations in classes under Source/WebCore/.
Where the addition had to be performed on all virtual methods of the
class, the virtual specifier was removed so now only the override
specifier is in use.
- Modules/indexeddb/IDBOpenDBRequest.h:
- Modules/indexeddb/IDBRequest.h:
- Modules/webdatabase/DatabaseServer.h:
- bindings/js/ReadableJSStream.h:
- editing/InsertTextCommand.h:
- mathml/MathMLInlineContainerElement.h:
- platform/audio/EqualPowerPanner.h:
(WebCore::EqualPowerPanner::reset):
- platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::load):
(WebCore::NullMediaPlayerPrivate::cancelLoad):
(WebCore::NullMediaPlayerPrivate::prepareToPlay):
(WebCore::NullMediaPlayerPrivate::play):
(WebCore::NullMediaPlayerPrivate::pause):
(WebCore::NullMediaPlayerPrivate::platformMedia):
(WebCore::NullMediaPlayerPrivate::platformLayer):
(WebCore::NullMediaPlayerPrivate::naturalSize):
(WebCore::NullMediaPlayerPrivate::hasVideo):
(WebCore::NullMediaPlayerPrivate::hasAudio):
(WebCore::NullMediaPlayerPrivate::setVisible):
(WebCore::NullMediaPlayerPrivate::durationDouble):
(WebCore::NullMediaPlayerPrivate::currentTimeDouble):
(WebCore::NullMediaPlayerPrivate::seekDouble):
(WebCore::NullMediaPlayerPrivate::seeking):
(WebCore::NullMediaPlayerPrivate::setRateDouble):
(WebCore::NullMediaPlayerPrivate::setPreservesPitch):
(WebCore::NullMediaPlayerPrivate::paused):
(WebCore::NullMediaPlayerPrivate::setVolumeDouble):
(WebCore::NullMediaPlayerPrivate::supportsMuting):
(WebCore::NullMediaPlayerPrivate::setMuted):
(WebCore::NullMediaPlayerPrivate::hasClosedCaptions):
(WebCore::NullMediaPlayerPrivate::setClosedCaptionsVisible):
(WebCore::NullMediaPlayerPrivate::networkState):
(WebCore::NullMediaPlayerPrivate::readyState):
(WebCore::NullMediaPlayerPrivate::maxTimeSeekableDouble):
(WebCore::NullMediaPlayerPrivate::minTimeSeekable):
(WebCore::NullMediaPlayerPrivate::buffered):
(WebCore::NullMediaPlayerPrivate::totalBytes):
(WebCore::NullMediaPlayerPrivate::didLoadingProgress):
(WebCore::NullMediaPlayerPrivate::setSize):
(WebCore::NullMediaPlayerPrivate::canLoadPoster):
(WebCore::NullMediaPlayerPrivate::setPoster):
(WebCore::NullMediaPlayerPrivate::hasSingleSecurityOrigin):
- platform/graphics/filters/DistantLightSource.h:
- platform/graphics/filters/FEComposite.h:
- platform/graphics/filters/FEDisplacementMap.h:
(WebCore::FEDisplacementMap::determineAbsolutePaintRect):
- platform/graphics/filters/FEFlood.h:
(WebCore::FEFlood::determineAbsolutePaintRect):
- platform/graphics/filters/PointLightSource.h:
- platform/graphics/filters/SpotLightSource.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(WebCore::MediaPlayerPrivateGStreamer::hasVideo):
(WebCore::MediaPlayerPrivateGStreamer::hasAudio):
(WebCore::MediaPlayerPrivateGStreamer::audioSourceProvider):
(WebCore::MediaPlayerPrivateGStreamer::engineDescription):
(WebCore::MediaPlayerPrivateGStreamer::isLiveStream):
(WebCore::MediaPlayerPrivateGStreamer::totalVideoFrames):
(WebCore::MediaPlayerPrivateGStreamer::droppedVideoFrames):
(WebCore::MediaPlayerPrivateGStreamer::corruptedVideoFrames):
(WebCore::MediaPlayerPrivateGStreamer::totalFrameDelay):
- platform/graphics/texmap/BitmapTextureGL.h:
(WebCore::BitmapTextureGL::isBackedByOpenGL):
- platform/graphics/transforms/Matrix3DTransformOperation.h:
- platform/graphics/transforms/MatrixTransformOperation.h:
- platform/graphics/transforms/PerspectiveTransformOperation.h:
- platform/graphics/transforms/RotateTransformOperation.h:
- platform/graphics/transforms/ScaleTransformOperation.h:
- platform/graphics/transforms/SkewTransformOperation.h:
- platform/image-decoders/png/PNGImageDecoder.h:
(WebCore::PNGImageDecoder::filenameExtension):
- platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.h:
- platform/mock/MockRealtimeMediaSourceCenter.h:
- 11:43 AM Changeset in webkit [185517] by
-
- 22 edits in trunk/Source/WebCore
Unreviewed, rolling out r185512.
https://bugs.webkit.org/show_bug.cgi?id=145932
Many asserts on layout tests and on API tests (Requested by
ap_ on #webkit).
Reverted changeset:
"Use modern for-loops in WebCore/rendering - 1"
https://bugs.webkit.org/show_bug.cgi?id=145831
http://trac.webkit.org/changeset/185512
- 11:22 AM Changeset in webkit [185516] by
-
- 2 edits in trunk/Source/WebCore
OpenGLESSPI.h doesn't need to include UIKit.h
https://bugs.webkit.org/show_bug.cgi?id=145931
Reviewed by Darin Adler.
No need to suck in all of UIKit from OpenGLESSPI.h.
- platform/spi/ios/OpenGLESSPI.h:
- 11:19 AM Changeset in webkit [185515] by
-
- 2 edits in tags/Safari-601.1.35/Source/WebCore
Merge r185501. rdar://problem/21129111
- 10:53 AM Changeset in webkit [185514] by
-
- 4 edits in trunk/Source/WebCore
Add barebones implementation of media session invocation algorithm.
https://bugs.webkit.org/show_bug.cgi?id=145847
Patch by Matt Rajca <mrajca@apple.com> on 2015-06-12
Reviewed by Darin Adler.
- Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::invoke): Move the media session to an active state.
- Modules/mediasession/MediaSession.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::playInternal): Call the media session invocation algorithm as described in the
Media Session spec.
- 10:43 AM Changeset in webkit [185513] by
-
- 3 edits in trunk/Source/WebKit2
Network Cache: Use SHA1 for header checksum
https://bugs.webkit.org/show_bug.cgi?id=145928
Reviewed by Chris Dumez.
Use SHA1 everywhere for consistency and robustness.
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::bodyPathForKey):
(WebKit::NetworkCache::RecordMetaData::RecordMetaData):
(WebKit::NetworkCache::decodeRecordMetaData):
(WebKit::NetworkCache::decodeRecordHeader):
(WebKit::NetworkCache::encodeRecordMetaData):
(WebKit::NetworkCache::Storage::encodeRecord):
(WebKit::NetworkCache::hashData): Deleted.
This was the last user of 32 bit hashes in cache code.
- NetworkProcess/cache/NetworkCacheStorage.h:
Also bump the cache version number as recent changes have changed the format.
Old caches would transition fine but this makes it easier to identify which version user has.
- 10:10 AM Changeset in webkit [185512] by
-
- 22 edits in trunk/Source/WebCore
Use modern for-loops in WebCore/rendering - 1
https://bugs.webkit.org/show_bug.cgi?id=145831
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-06-12
Reviewed by Darin Adler.
No new tests because there is no behavior change.
- rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::computeIntrinsicLogicalWidths):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
- rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):
(WebCore::FilterEffectRenderer::clearIntermediateResults):
- rendering/FilterEffectRenderer.h:
- rendering/FloatingObjects.cpp:
(WebCore::FloatingObjects::clearLineBoxTreePointers):
(WebCore::FloatingObjects::moveAllToFloatInfoMap):
(WebCore::FloatingObjects::computePlacedFloatsTree):
- rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::collectFixedPositionedLayers):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::append):
- rendering/ImageQualityController.cpp:
(WebCore::ImageQualityController::highQualityRepaintTimerFired):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
- rendering/RenderBlock.cpp:
(WebCore::removeBlockFromDescendantAndContainerMaps):
(WebCore::RenderBlock::addOverflowFromPositionedObjects):
(WebCore::RenderBlock::dirtyForLayoutFromPercentageHeightDescendants):
(WebCore::RenderBlock::simplifiedNormalFlowLayout):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::markPositionedObjectsForLayout):
(WebCore::RenderBlock::paintContinuationOutlines):
(WebCore::clipOutPositionedObjects):
(WebCore::RenderBlock::removeFromTrackedRendererMaps):
(WebCore::RenderBlock::removePositionedObjects):
(WebCore::RenderBlock::checkPositionedObjectsNeedLayout):
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats):
(WebCore::RenderBlockFlow::styleDidChange):
(WebCore::RenderBlockFlow::moveFloatsTo):
(WebCore::RenderBlockFlow::addOverflowFromFloats):
(WebCore::RenderBlockFlow::repaintOverhangingFloats):
(WebCore::RenderBlockFlow::paintFloats):
(WebCore::RenderBlockFlow::clipOutFloatingObjects):
(WebCore::RenderBlockFlow::lowestFloatLogicalBottom):
(WebCore::RenderBlockFlow::lowestInitialLetterLogicalBottom):
(WebCore::RenderBlockFlow::addOverhangingFloats):
(WebCore::RenderBlockFlow::addIntrudingFloats):
(WebCore::RenderBlockFlow::markSiblingsWithFloatsForLayout):
(WebCore::RenderBlockFlow::adjustForBorderFit):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::setLogicalWidthForTextRun):
(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::linkToEndLineIfNeeded):
(WebCore::RenderBlockFlow::repaintDirtyFloats):
(WebCore::RenderBlockFlow::layoutLineBoxes):
(WebCore::RenderBlockFlow::checkFloatsInCleanLine):
(WebCore::RenderBlockFlow::determineStartPosition):
(WebCore::RenderBlockFlow::checkPaginationAndFloatsAtEndLine):
- rendering/RenderCounter.cpp:
(WebCore::RenderCounter::destroyCounterNodes):
(WebCore::updateCounters):
(WebCore::RenderCounter::rendererStyleChanged):
- rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::autoMarginOffsetInMainAxis):
(WebCore::RenderFlexibleBox::freezeViolations):
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
(WebCore::RenderFlexibleBox::numberOfInFlowPositionedChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse):
(WebCore::RenderFlexibleBox::alignFlexLines):
(WebCore::RenderFlexibleBox::alignChildren):
(WebCore::RenderFlexibleBox::flipForWrapReverse):
- rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::updateAllLayerToRegionMappings):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::addAnnotatedRegions):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateDescendantsAreContiguousInStackingOrder):
(WebCore::RenderLayer::updateDescendantDependentFlags):
- rendering/RenderLayerBacking.cpp:
(WebCore::descendantLayerPaintsIntoAncestor):
(WebCore::RenderLayerBacking::startAnimation):
- rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::paint):
- rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
- rendering/RenderMenuList.cpp:
(WebCore::selectedOptionCount):
(RenderMenuList::updateOptionsWidth):
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::distributeImplicitBreaks):
- 10:04 AM Changeset in webkit [185511] by
-
- 2 edits in trunk/Source/WebKit2
[iOS WK2] Video with reflection crashes WebKit and Safari
https://bugs.webkit.org/show_bug.cgi?id=145905
rdar://problem/18364939
Reviewed by Anders Carlsson.
On iOS, AVPlayerLayers are contained inside a WebVideoContainerLayer, but
the layer type is still LayerTypeAVPlayerLayer.
Avoid throwing exceptions when cloning such layers by checking the layer class.
- WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.mm:
(WebKit::PlatformCALayerRemoteCustom::clone):
- 9:59 AM Changeset in webkit [185510] by
-
- 2 edits in trunk/Source/WebCore
Fix unused private field warning in ResourceHandleSoup.cpp
https://bugs.webkit.org/show_bug.cgi?id=145910
Reviewed by Darin Adler.
- platform/network/soup/ResourceHandleSoup.cpp:
- 9:56 AM Changeset in webkit [185509] by
-
- 3 edits in trunk/Source/WebKit2
[EFL] Fix unused private field warning in WebContextMenuProxyEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=145911
Reviewed by Darin Adler.
- UIProcess/efl/WebContextMenuProxyEfl.cpp:
(WebKit::WebContextMenuProxyEfl::WebContextMenuProxyEfl): Deleted.
- UIProcess/efl/WebContextMenuProxyEfl.h:
- 9:52 AM Changeset in webkit [185508] by
-
- 2 edits in trunk/Tools
[GTK] Fix return type warning in WebViewTest.cpp
https://bugs.webkit.org/show_bug.cgi?id=145914
Reviewed by Darin Adler.
- TestWebKitAPI/gtk/WebKit2Gtk/WebViewTest.cpp:
(WebViewTest::isEditable):
- 9:48 AM Changeset in webkit [185507] by
-
- 2 edits in trunk/Source/WebCore
Web Inspector: CRASH trying to inspect text that was removed/replaced
https://bugs.webkit.org/show_bug.cgi?id=145898
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-12
Reviewed by Darin Adler.
- inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::inspect):
(WebCore::InspectorDOMAgent::focusNode):
Ensure we only cause focusNode with a node to focus. If the original
node that was provided is no longer in the document, then we won't
actually find a node to inspect.
- 9:45 AM Changeset in webkit [185506] by
-
- 3 edits in trunk/Source/WebCore
[EFL] canvas/philip/tests/toDataURL.jpeg.foo tests have been failed since r185417.
https://bugs.webkit.org/show_bug.cgi?id=145878
Reviewed by Gyuyoung Kim.
Fix input buffer alignment issue.
No new tests, canvas/philip/tests/toDataURL.jpeg.foo can be used.
- platform/graphics/efl/ImageBufferEfl.cpp:
(WebCore::encodeImagePNG):
(WebCore::encodeImageJPEG):
(WebCore::ImageBuffer::toDataURL):
- 9:33 AM Changeset in webkit [185505] by
-
- 3 edits in trunk/Source/JavaScriptCore
DFG Object Allocation Sinking should not consider GetClosureVar as escapes
https://bugs.webkit.org/show_bug.cgi?id=145904
Reviewed by Filip Pizlo.
The object allocation sinking phase is currently able to sink
CreateActivation nodes, but will consider any GetClosureVar node as
escaping.
This is not problematic in general as most of the GetClosureVar nodes
we would have been able to sink over will have been eliminated by CSE
anyway. Still, this is an oversight that we should fix since the
machinery is already in place.
- dfg/DFGObjectAllocationSinkingPhase.cpp:
(JSC::DFG::ObjectAllocationSinkingPhase::handleNode):
- dfg/DFGPromoteHeapAccess.h:
(JSC::DFG::promoteHeapAccess):
- 7:46 AM Changeset in webkit [185504] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed build fix after r185502.
- NetworkProcess/cache/NetworkCacheFileSystem.cpp:
GRefPtr.h header has been moved to a different place.
- 6:44 AM Changeset in webkit [185503] by
-
- 47 edits in trunk/Source/WebCore
Add missing override specifiers under Source/WebCore/svg/
https://bugs.webkit.org/show_bug.cgi?id=145841
Reviewed by Darin Adler.
Add missing override specifiers to virtual method overrides for classes
under Source/WebCore/svg/, suppressing a bunch of warnings when compiling
with Clang 3.6.
Add the BEGIN_DECLARE_ANIMATED_PROPERTIES_BASE() macro that doesn't
override the localAttributeToPropertyMap() method declaration, and
have the BEGIN_DECLARE_ANIMATED_PROPERTIES() macro add the override
specifier. The new macro is used in SVGElement.
Change the DECLARE_ANIMATED_PROPERTY() to accept the optional override
specifier as the fifth parameter. Current DECLARE_ANIMATED_*() macros
are modified to just pass an empty argument, not adding any specifier.
DECLARE_ANIMATED_BOOLEAN_OVERRIDE() and DECLARE_ANIMATED_STRING_OVERRIDE()
macros are added to override the methods for the externalResourcesRequired
and href animated properties, where required.
- svg/SVGAElement.h:
- svg/SVGAltGlyphElement.h:
- svg/SVGAnimatedAngle.h:
- svg/SVGAnimatedBoolean.h:
- svg/SVGAnimatedEnumeration.h:
- svg/SVGAnimatedInteger.h:
- svg/SVGAnimatedLength.h:
- svg/SVGAnimatedNumber.h:
- svg/SVGAnimatedPreserveAspectRatio.h:
- svg/SVGAnimatedRect.h:
- svg/SVGAnimatedString.h:
- svg/SVGAnimationElement.h:
- svg/SVGCircleElement.h:
- svg/SVGClipPathElement.h:
- svg/SVGCursorElement.h:
- svg/SVGDefsElement.h:
- svg/SVGElement.h:
- svg/SVGEllipseElement.h:
- svg/SVGFEImageElement.h:
- svg/SVGFilterElement.h:
- svg/SVGFontElement.h:
- svg/SVGForeignObjectElement.h:
- svg/SVGGElement.h:
- svg/SVGGlyphRefElement.h:
- svg/SVGGradientElement.h:
- svg/SVGImageElement.h:
- svg/SVGLineElement.h:
- svg/SVGMPathElement.h:
- svg/SVGMarkerElement.h:
- svg/SVGMaskElement.h:
- svg/SVGPathElement.h:
- svg/SVGPatternElement.h:
- svg/SVGPolyElement.h:
- svg/SVGRectElement.h:
- svg/SVGSVGElement.h:
- svg/SVGScriptElement.h:
- svg/SVGSwitchElement.h:
- svg/SVGSymbolElement.h:
- svg/SVGTRefElement.h:
- svg/SVGTextContentElement.h:
- svg/SVGTextPathElement.h:
- svg/SVGURIReference.h: Add the hrefBaseValue() pure virtual method
so it can be overridden by any class that also overrides the
corresponding setHrefBaseValue() method.
- svg/SVGUseElement.h:
- svg/SVGViewElement.h:
- svg/properties/SVGAnimatedPropertyMacros.h:
- svg/properties/SVGMatrixTearOff.h:
(WebCore::SVGMatrixTearOff::commitChange):
- 6:32 AM Changeset in webkit [185502] by
-
- 195 edits13 adds2 deletes in trunk
[GLib] Move files under Source/WTF/wtf/gobject to Source/WTF/wtf/glib
https://bugs.webkit.org/show_bug.cgi?id=145799
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Update header inclusions for headers that have been moved
to Source/WTF/wtf/glib/.
- accessibility/atk/AXObjectCacheAtk.cpp:
- accessibility/atk/WebKitAccessibleInterfaceText.cpp:
- bindings/gobject/DOMObjectCache.cpp:
- bindings/gobject/GObjectEventListener.h:
- bindings/gobject/GObjectNodeFilterCondition.h:
- bindings/gobject/GObjectXPathNSResolver.h:
- bindings/gobject/WebKitDOMEventTarget.cpp:
- platform/Pasteboard.h:
- platform/audio/gstreamer/AudioDestinationGStreamer.cpp:
- platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
- platform/audio/gstreamer/AudioSourceProviderGStreamer.cpp:
- platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
- platform/audio/gtk/AudioBusGtk.cpp:
- platform/geoclue/GeolocationProviderGeoclue.h:
- platform/geoclue/GeolocationProviderGeoclue2.cpp:
- platform/glib/BatteryProviderUPower.cpp:
- platform/glib/BatteryProviderUPower.h:
- platform/graphics/gstreamer/GRefPtrGStreamer.h:
- platform/graphics/gstreamer/GStreamerUtilities.cpp:
- platform/graphics/gstreamer/GUniquePtrGStreamer.h:
- platform/graphics/gstreamer/InbandTextTrackPrivateGStreamer.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- platform/graphics/gstreamer/MediaSourceGStreamer.cpp:
- platform/graphics/gstreamer/TrackPrivateBaseGStreamer.cpp:
- platform/graphics/gstreamer/TrackPrivateBaseGStreamer.h:
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
- platform/graphics/gstreamer/WebKitMediaSourceGStreamer.cpp:
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
- platform/graphics/gtk/ImageBufferGtk.cpp:
- platform/graphics/gtk/ImageGtk.cpp:
- platform/gtk/ContextMenuGtk.cpp:
- platform/gtk/ContextMenuItemGtk.cpp:
- platform/gtk/DataObjectGtk.cpp:
- platform/gtk/DataObjectGtk.h:
- platform/gtk/FileSystemGtk.cpp:
- platform/gtk/GRefPtrGtk.h:
- platform/gtk/GUniquePtrGtk.h:
- platform/gtk/GamepadsGtk.cpp:
- platform/gtk/GtkUtilities.cpp:
- platform/gtk/LanguageGtk.cpp:
- platform/gtk/LocalizedStringsGtk.cpp:
- platform/gtk/PasteboardHelper.cpp:
- platform/gtk/ScrollbarThemeGtk.cpp:
- platform/gtk/SharedBufferGtk.cpp:
- platform/gtk/SharedTimerGtk.cpp:
- platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:
- platform/network/ResourceHandleInternal.h:
- platform/network/gtk/CredentialBackingStore.cpp:
- platform/network/soup/CertificateInfo.h:
- platform/network/soup/CookieJarSoup.cpp:
- platform/network/soup/DNSSoup.cpp:
- platform/network/soup/GRefPtrSoup.h:
- platform/network/soup/GUniquePtrSoup.h:
- platform/network/soup/ResourceError.h:
- platform/network/soup/ResourceErrorSoup.cpp:
- platform/network/soup/ResourceHandleSoup.cpp:
- platform/network/soup/ResourceResponse.h:
- platform/network/soup/SocketStreamHandle.h:
- platform/network/soup/SocketStreamHandleSoup.cpp:
- platform/network/soup/SoupNetworkSession.h:
- platform/text/gtk/HyphenationLibHyphen.cpp:
- rendering/RenderThemeGtk.cpp:
Source/WebKit2:
Update header inclusions for headers that have been moved
to Source/WTF/wtf/glib/.
- NetworkProcess/cache/NetworkCacheFileSystemPosix.h:
- NetworkProcess/cache/NetworkCacheIOChannel.h:
- NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:
- NetworkProcess/soup/NetworkProcessSoup.cpp:
- PlatformEfl.cmake:
- PlatformGTK.cmake:
- Shared/Downloads/soup/DownloadSoup.cpp:
- Shared/Network/CustomProtocols/soup/CustomProtocolManagerImpl.h:
- Shared/PrintInfo.h:
- Shared/gtk/ArgumentCodersGtk.cpp:
- Shared/gtk/ArgumentCodersGtk.h:
- Shared/gtk/KeyedDecoder.h:
- Shared/gtk/KeyedEncoder.h:
- Shared/gtk/ProcessExecutablePathGtk.cpp:
- UIProcess/API/gtk/WebKitBackForwardList.cpp:
- UIProcess/API/gtk/WebKitBackForwardListItem.cpp:
- UIProcess/API/gtk/WebKitColorChooser.h:
- UIProcess/API/gtk/WebKitContextMenu.cpp:
- UIProcess/API/gtk/WebKitContextMenuItem.cpp:
- UIProcess/API/gtk/WebKitCookieManager.cpp:
- UIProcess/API/gtk/WebKitDownload.cpp:
- UIProcess/API/gtk/WebKitDownloadClient.cpp:
- UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
- UIProcess/API/gtk/WebKitFileChooserRequest.cpp:
- UIProcess/API/gtk/WebKitFindController.cpp:
- UIProcess/API/gtk/WebKitFormClient.cpp:
- UIProcess/API/gtk/WebKitFormSubmissionRequest.cpp:
- UIProcess/API/gtk/WebKitInjectedBundleClient.cpp:
- UIProcess/API/gtk/WebKitJavascriptResult.cpp:
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
- UIProcess/API/gtk/WebKitMimeInfo.cpp:
- UIProcess/API/gtk/WebKitNavigationAction.cpp:
- UIProcess/API/gtk/WebKitNavigationPolicyDecision.cpp:
- UIProcess/API/gtk/WebKitPolicyClient.cpp:
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
- UIProcess/API/gtk/WebKitResponsePolicyDecision.cpp:
- UIProcess/API/gtk/WebKitUIClient.cpp:
- UIProcess/API/gtk/WebKitURISchemeRequest.cpp:
- UIProcess/API/gtk/WebKitUserContentManager.cpp:
- UIProcess/API/gtk/WebKitWebContext.cpp:
- UIProcess/API/gtk/WebKitWebInspector.cpp:
- UIProcess/API/gtk/WebKitWebResource.cpp:
- UIProcess/API/gtk/WebKitWebView.cpp:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
- UIProcess/InspectorServer/WebSocketServer.h:
- UIProcess/InspectorServer/gtk/WebInspectorServerGtk.cpp:
- UIProcess/InspectorServer/soup/WebSocketServerSoup.cpp:
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
- UIProcess/Plugins/gtk/PluginInfoCache.h:
- UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
- UIProcess/gtk/DragAndDropHandler.cpp:
- UIProcess/gtk/GestureController.h:
- UIProcess/gtk/InputMethodFilter.cpp:
- UIProcess/gtk/InputMethodFilter.h:
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
- UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
- UIProcess/gtk/WebPopupMenuProxyGtk.h:
- UIProcess/gtk/WebProcessPoolGtk.cpp:
- WebProcess/Cookies/soup/WebCookieManagerSoup.cpp:
- WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:
- WebProcess/InjectedBundle/API/gtk/WebKitWebHitTestResult.cpp:
- WebProcess/WebCoreSupport/gtk/WebEditorClientGtk.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
- WebProcess/WebPage/gtk/PrinterListGtk.h:
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
- WebProcess/WebPage/gtk/WebPrintOperationGtk.cpp:
- WebProcess/WebPage/gtk/WebPrintOperationGtk.h:
- WebProcess/gtk/WebGtkExtensionManager.h:
- WebProcess/soup/WebKitSoupRequestInputStream.cpp:
- WebProcess/soup/WebProcessSoup.cpp:
- WebProcess/soup/WebSoupRequestManager.h:
Source/WTF:
Move the GLib-specific files to the Source/WTF/wtf/glib/ directory.
'gobject' wasn't the most appropriate name for the directory since
GObject is a submodule of GLib, but a lot of the code there didn't
have much to do with GObject specifically.
Build rules for the moved files are also updated.
- WTF.vcxproj/WTF.vcxproj:
- WTF.vcxproj/WTF.vcxproj.filters:
- wtf/Platform.h:
- wtf/PlatformEfl.cmake:
- wtf/PlatformGTK.cmake:
- wtf/RunLoop.h:
- wtf/WorkQueue.h:
- wtf/glib/GLibUtilities.cpp: Renamed from Source/WTF/wtf/gobject/GlibUtilities.cpp.
(getCurrentExecutablePath):
- wtf/glib/GLibUtilities.h: Renamed from Source/WTF/wtf/gobject/GlibUtilities.h.
- wtf/glib/GMainLoopSource.cpp: Renamed from Source/WTF/wtf/gobject/GMainLoopSource.cpp.
(WTF::GMainLoopSource::create):
(WTF::GMainLoopSource::GMainLoopSource):
(WTF::GMainLoopSource::~GMainLoopSource):
(WTF::GMainLoopSource::isScheduled):
(WTF::GMainLoopSource::isActive):
(WTF::GMainLoopSource::cancel):
(WTF::GMainLoopSource::scheduleIdleSource):
(WTF::GMainLoopSource::schedule):
(WTF::GMainLoopSource::scheduleTimeoutSource):
(WTF::GMainLoopSource::scheduleAfterDelay):
(WTF::createMicrosecondsTimeoutSource):
(WTF::GMainLoopSource::scheduleAndDeleteOnDestroy):
(WTF::GMainLoopSource::scheduleAfterDelayAndDeleteOnDestroy):
(WTF::GMainLoopSource::prepareVoidCallback):
(WTF::GMainLoopSource::finishVoidCallback):
(WTF::GMainLoopSource::voidCallback):
(WTF::GMainLoopSource::prepareBoolCallback):
(WTF::GMainLoopSource::finishBoolCallback):
(WTF::GMainLoopSource::boolCallback):
(WTF::GMainLoopSource::socketCallback):
(WTF::GMainLoopSource::voidSourceCallback):
(WTF::GMainLoopSource::boolSourceCallback):
(WTF::GMainLoopSource::socketSourceCallback):
(WTF::GMainLoopSource::Context::destroySource):
- wtf/glib/GMainLoopSource.h: Renamed from Source/WTF/wtf/gobject/GMainLoopSource.h.
(WTF::GMainLoopSource::Context::operator=):
- wtf/glib/GMutexLocker.h: Renamed from Source/WTF/wtf/gobject/GMutexLocker.h.
(WTF::MutexWrapper<GMutex>::lock):
(WTF::MutexWrapper<GMutex>::unlock):
(WTF::MutexWrapper<GRecMutex>::lock):
(WTF::MutexWrapper<GRecMutex>::unlock):
(WTF::GMutexLocker::GMutexLocker):
(WTF::GMutexLocker::~GMutexLocker):
(WTF::GMutexLocker::lock):
(WTF::GMutexLocker::unlock):
- wtf/glib/GRefPtr.cpp: Renamed from Source/WTF/wtf/gobject/GRefPtr.cpp.
(WTF::refGPtr):
(WTF::derefGPtr):
- wtf/glib/GRefPtr.h: Renamed from Source/WTF/wtf/gobject/GRefPtr.h.
(WTF::GRefPtr::GRefPtr):
(WTF::GRefPtr::~GRefPtr):
(WTF::GRefPtr::clear):
(WTF::GRefPtr::outPtr):
(WTF::GRefPtr::isHashTableDeletedValue):
(WTF::GRefPtr::get):
(WTF::GRefPtr::operator*):
(WTF::GRefPtr::operator->):
(WTF::GRefPtr::operator!):
(WTF::GRefPtr::operator UnspecifiedBoolType):
(WTF::GRefPtr::hashTableDeletedValue):
(WTF::=):
(WTF::GRefPtr<T>::swap):
(WTF::swap):
(WTF::operator==):
(WTF::operator!=):
(WTF::static_pointer_cast):
(WTF::const_pointer_cast):
(WTF::adoptGRef):
(WTF::refGPtr):
(WTF::derefGPtr):
- wtf/glib/GThreadSafeMainLoopSource.cpp: Renamed from Source/WTF/wtf/gobject/GThreadSafeMainLoopSource.cpp.
(WTF::GThreadSafeMainLoopSource::GThreadSafeMainLoopSource):
(WTF::GThreadSafeMainLoopSource::~GThreadSafeMainLoopSource):
(WTF::GThreadSafeMainLoopSource::cancel):
(WTF::GThreadSafeMainLoopSource::schedule):
(WTF::GThreadSafeMainLoopSource::scheduleAfterDelay):
(WTF::GThreadSafeMainLoopSource::prepareVoidCallback):
(WTF::GThreadSafeMainLoopSource::finishVoidCallback):
(WTF::GThreadSafeMainLoopSource::voidCallback):
(WTF::GThreadSafeMainLoopSource::prepareBoolCallback):
(WTF::GThreadSafeMainLoopSource::finishBoolCallback):
(WTF::GThreadSafeMainLoopSource::boolCallback):
- wtf/glib/GThreadSafeMainLoopSource.h: Renamed from Source/WTF/wtf/gobject/GThreadSafeMainLoopSource.h.
- wtf/glib/GTypedefs.h: Renamed from Source/WTF/wtf/gobject/GTypedefs.h.
- wtf/glib/GUniquePtr.h: Renamed from Source/WTF/wtf/gobject/GUniquePtr.h.
(WTF::GPtrDeleter::operator()):
(WTF::GUniqueOutPtr::GUniqueOutPtr):
(WTF::GUniqueOutPtr::~GUniqueOutPtr):
(WTF::GUniqueOutPtr::outPtr):
(WTF::GUniqueOutPtr::release):
(WTF::GUniqueOutPtr::operator*):
(WTF::GUniqueOutPtr::operator->):
(WTF::GUniqueOutPtr::get):
(WTF::GUniqueOutPtr::operator!):
(WTF::GUniqueOutPtr::operator UnspecifiedBoolType):
(WTF::GUniqueOutPtr::reset):
- wtf/glib/MainThreadGLib.cpp:
- wtf/gobject/GMainLoopSource.cpp:
(WTF::GMainLoopSource::create): Deleted.
(WTF::GMainLoopSource::GMainLoopSource): Deleted.
(WTF::GMainLoopSource::~GMainLoopSource): Deleted.
(WTF::GMainLoopSource::isScheduled): Deleted.
(WTF::GMainLoopSource::isActive): Deleted.
(WTF::GMainLoopSource::cancel): Deleted.
(WTF::GMainLoopSource::scheduleIdleSource): Deleted.
(WTF::GMainLoopSource::schedule): Deleted.
(WTF::GMainLoopSource::scheduleTimeoutSource): Deleted.
(WTF::GMainLoopSource::scheduleAfterDelay): Deleted.
(WTF::createMicrosecondsTimeoutSource): Deleted.
(WTF::GMainLoopSource::scheduleAndDeleteOnDestroy): Deleted.
(WTF::GMainLoopSource::scheduleAfterDelayAndDeleteOnDestroy): Deleted.
(WTF::GMainLoopSource::prepareVoidCallback): Deleted.
(WTF::GMainLoopSource::finishVoidCallback): Deleted.
(WTF::GMainLoopSource::voidCallback): Deleted.
(WTF::GMainLoopSource::prepareBoolCallback): Deleted.
(WTF::GMainLoopSource::finishBoolCallback): Deleted.
(WTF::GMainLoopSource::boolCallback): Deleted.
(WTF::GMainLoopSource::socketCallback): Deleted.
(WTF::GMainLoopSource::voidSourceCallback): Deleted.
(WTF::GMainLoopSource::boolSourceCallback): Deleted.
(WTF::GMainLoopSource::socketSourceCallback): Deleted.
(WTF::GMainLoopSource::Context::destroySource): Deleted.
- wtf/gobject/GMainLoopSource.h:
(WTF::GMainLoopSource::Context::operator=): Deleted.
- wtf/gobject/GMutexLocker.h:
(WTF::MutexWrapper<GMutex>::lock): Deleted.
(WTF::MutexWrapper<GMutex>::unlock): Deleted.
(WTF::MutexWrapper<GRecMutex>::lock): Deleted.
(WTF::MutexWrapper<GRecMutex>::unlock): Deleted.
(WTF::GMutexLocker::GMutexLocker): Deleted.
(WTF::GMutexLocker::~GMutexLocker): Deleted.
(WTF::GMutexLocker::lock): Deleted.
(WTF::GMutexLocker::unlock): Deleted.
- wtf/gobject/GRefPtr.cpp:
(WTF::refGPtr): Deleted.
(WTF::derefGPtr): Deleted.
- wtf/gobject/GRefPtr.h:
(WTF::GRefPtr::GRefPtr): Deleted.
(WTF::GRefPtr::~GRefPtr): Deleted.
(WTF::GRefPtr::clear): Deleted.
(WTF::GRefPtr::outPtr): Deleted.
(WTF::GRefPtr::isHashTableDeletedValue): Deleted.
(WTF::GRefPtr::get): Deleted.
(WTF::GRefPtr::operator*): Deleted.
(WTF::GRefPtr::operator->): Deleted.
(WTF::GRefPtr::operator!): Deleted.
(WTF::GRefPtr::operator UnspecifiedBoolType): Deleted.
(WTF::GRefPtr::hashTableDeletedValue): Deleted.
(WTF::=): Deleted.
(WTF::GRefPtr<T>::swap): Deleted.
(WTF::swap): Deleted.
(WTF::operator==): Deleted.
(WTF::operator!=): Deleted.
(WTF::static_pointer_cast): Deleted.
(WTF::const_pointer_cast): Deleted.
(WTF::adoptGRef): Deleted.
(WTF::refGPtr): Deleted.
(WTF::derefGPtr): Deleted.
- wtf/gobject/GThreadSafeMainLoopSource.cpp:
(WTF::GThreadSafeMainLoopSource::GThreadSafeMainLoopSource): Deleted.
(WTF::GThreadSafeMainLoopSource::~GThreadSafeMainLoopSource): Deleted.
(WTF::GThreadSafeMainLoopSource::cancel): Deleted.
(WTF::GThreadSafeMainLoopSource::schedule): Deleted.
(WTF::GThreadSafeMainLoopSource::scheduleAfterDelay): Deleted.
(WTF::GThreadSafeMainLoopSource::prepareVoidCallback): Deleted.
(WTF::GThreadSafeMainLoopSource::finishVoidCallback): Deleted.
(WTF::GThreadSafeMainLoopSource::voidCallback): Deleted.
(WTF::GThreadSafeMainLoopSource::prepareBoolCallback): Deleted.
(WTF::GThreadSafeMainLoopSource::finishBoolCallback): Deleted.
(WTF::GThreadSafeMainLoopSource::boolCallback): Deleted.
- wtf/gobject/GUniquePtr.h:
(WTF::GPtrDeleter::operator()): Deleted.
(WTF::GUniqueOutPtr::GUniqueOutPtr): Deleted.
(WTF::GUniqueOutPtr::~GUniqueOutPtr): Deleted.
(WTF::GUniqueOutPtr::outPtr): Deleted.
(WTF::GUniqueOutPtr::release): Deleted.
(WTF::GUniqueOutPtr::operator*): Deleted.
(WTF::GUniqueOutPtr::operator->): Deleted.
(WTF::GUniqueOutPtr::get): Deleted.
(WTF::GUniqueOutPtr::operator!): Deleted.
(WTF::GUniqueOutPtr::operator UnspecifiedBoolType): Deleted.
(WTF::GUniqueOutPtr::reset): Deleted.
- wtf/gobject/GlibUtilities.cpp:
(getCurrentExecutablePath): Deleted.
Tools:
Update header inclusions for headers that have been moved
to Source/WTF/wtf/glib/.
Also move the unit tests under TestWebKitAPI/Tests/WTF/gobject/
to TestWebKitAPI/Tests/WTF/glib/ and update the build rules.
- TestWebKitAPI/PlatformGTK.cmake:
- TestWebKitAPI/Tests/WTF/glib/GMainLoopSource.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp.
(TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest):
(TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest):
(TestWebKitAPI::GMainLoopSourceTest::runLoop):
(TestWebKitAPI::GMainLoopSourceTest::delayedFinish):
(TestWebKitAPI::GMainLoopSourceTest::finish):
(TestWebKitAPI::GMainLoopSourceTest::source):
(TestWebKitAPI::basicRescheduling):
(TestWebKitAPI::TEST):
(TestWebKitAPI::reentrantRescheduling):
(TestWebKitAPI::cancelRepeatingSourceDuringDispatch):
(TestWebKitAPI::basicDestroyCallbacks):
(TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch):
(TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch):
- TestWebKitAPI/Tests/WTF/glib/GUniquePtr.cpp: Renamed from Tools/TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp.
(log):
(takeLogStr):
(TestWebKitAPI::TEST):
(TestWebKitAPI::returnOutChar):
- TestWebKitAPI/Tests/WTF/glib/WorkQueueGLib.cpp:
- TestWebKitAPI/Tests/WTF/gobject/GMainLoopSource.cpp:
(TestWebKitAPI::GMainLoopSourceTest::GMainLoopSourceTest): Deleted.
(TestWebKitAPI::GMainLoopSourceTest::~GMainLoopSourceTest): Deleted.
(TestWebKitAPI::GMainLoopSourceTest::runLoop): Deleted.
(TestWebKitAPI::GMainLoopSourceTest::delayedFinish): Deleted.
(TestWebKitAPI::GMainLoopSourceTest::finish): Deleted.
(TestWebKitAPI::GMainLoopSourceTest::source): Deleted.
(TestWebKitAPI::basicRescheduling): Deleted.
(TestWebKitAPI::TEST): Deleted.
(TestWebKitAPI::reentrantRescheduling): Deleted.
(TestWebKitAPI::cancelRepeatingSourceDuringDispatch): Deleted.
(TestWebKitAPI::basicDestroyCallbacks): Deleted.
(TestWebKitAPI::destroyCallbacksAfterCancellingDuringDispatch): Deleted.
(TestWebKitAPI::destroyCallbacksAfterReschedulingDuringDispatch): Deleted.
- TestWebKitAPI/Tests/WTF/gobject/GUniquePtr.cpp:
(log): Deleted.
(takeLogStr): Deleted.
(TestWebKitAPI::TEST): Deleted.
(TestWebKitAPI::returnOutChar): Deleted.
- TestWebKitAPI/Tests/WebKit2/gtk/InputMethodFilter.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeFilterTest.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/DOMXPathNSResolverTest.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/TestInspector.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/TestPrinting.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/TestResources.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/TestUIClient.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitAccessibility.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFaviconDatabase.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitFindController.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitPolicyClient.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitSettings.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebContext.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/WebExtensionTest.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.cpp:
- TestWebKitAPI/Tests/WebKit2Gtk/WebProcessTest.h:
- TestWebKitAPI/gtk/PlatformUtilitiesGtk.cpp:
- TestWebKitAPI/gtk/PlatformWebViewGtk.cpp:
- TestWebKitAPI/gtk/WebKit2Gtk/TestMain.h:
- TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.cpp:
- TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestBus.h:
- TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.cpp:
- TestWebKitAPI/gtk/WebKit2Gtk/WebKitTestServer.h:
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityControllerAtk.cpp:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.h:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
- WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
- WebKitTestRunner/InjectedBundle/gtk/InjectedBundleUtilities.cpp:
- WebKitTestRunner/InjectedBundle/gtk/TestRunnerGtk.cpp:
- WebKitTestRunner/PlatformGTK.cmake:
- WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
- WebKitTestRunner/gtk/TestControllerGtk.cpp:
- 6:17 AM Changeset in webkit [185501] by
-
- 2 edits in trunk/Source/WebCore
Fix the build when the PICTURE_SIZES flag is off
https://bugs.webkit.org/show_bug.cgi?id=145926
Reviewed by Csaba Osztrogonác.
No new tests since there's no functionality change.
- html/parser/HTMLPreloadScanner.cpp: Remove the guard around the definition of m_sizesAttribute.
- 5:58 AM Changeset in webkit [185500] by
-
- 6 edits in trunk/Source/WebKit2
Network Cache: Use SHA1 for key hash
https://bugs.webkit.org/show_bug.cgi?id=143829
Reviewed by Anders Carlsson.
For consistency with blobs, use SHA1 instead of MD5.
- NetworkProcess/cache/NetworkCacheCoders.cpp:
(WebKit::NetworkCache::Coder<MD5::Digest>::encode): Deleted.
(WebKit::NetworkCache::Coder<MD5::Digest>::decode): Deleted.
No longer needed.
- NetworkProcess/cache/NetworkCacheCoders.h:
- NetworkProcess/cache/NetworkCacheKey.cpp:
(WebKit::NetworkCache::hashString):
(WebKit::NetworkCache::Key::computeHash):
- NetworkProcess/cache/NetworkCacheKey.h:
- 5:54 AM Changeset in webkit [185499] by
-
- 5 edits in trunk
Unreviewed, rolling out r185492.
https://bugs.webkit.org/show_bug.cgi?id=145927
Causes crashes on debug (Requested by rego on #webkit).
Reverted changeset:
"[CSS Grid Layout] Fix grid-template-areas parsing to avoid
spaces"
https://bugs.webkit.org/show_bug.cgi?id=145860
http://trac.webkit.org/changeset/185492
Patch by Commit Queue <commit-queue@webkit.org> on 2015-06-12
- 5:47 AM Changeset in webkit [185498] by
-
- 2 edits in trunk/Source/WebKit2
Fix mismatched-tags warning in Source/WebKit2/UIProcess/gtk/InputMethodFilter.h
https://bugs.webkit.org/show_bug.cgi?id=145923
Reviewed by Carlos Garcia Campos.
- UIProcess/gtk/InputMethodFilter.h:
- 3:46 AM Changeset in webkit [185497] by
-
- 5 edits in trunk/Source/WebKit2
Use SHA1 for cache coder checksums
https://bugs.webkit.org/show_bug.cgi?id=145880
Reviewed by Anders Carlsson.
Make cache data error detection more robust by using SHA1 for checksums.
- NetworkProcess/cache/NetworkCacheDecoder.cpp:
(WebKit::NetworkCache::Decoder::Decoder):
(WebKit::NetworkCache::Decoder::decodeFixedLengthData):
(WebKit::NetworkCache::Decoder::decodeNumber):
(WebKit::NetworkCache::Decoder::verifyChecksum):
- NetworkProcess/cache/NetworkCacheDecoder.h:
- NetworkProcess/cache/NetworkCacheEncoder.cpp:
(WebKit::NetworkCache::Encoder::Encoder):
(WebKit::NetworkCache::Encoder::grow):
(WebKit::NetworkCache::Encoder::updateChecksumForData):
(WebKit::NetworkCache::Encoder::encodeFixedLengthData):
(WebKit::NetworkCache::Encoder::encodeNumber):
(WebKit::NetworkCache::Encoder::encodeChecksum):
- NetworkProcess/cache/NetworkCacheEncoder.h:
(WebKit::NetworkCache::Encoder::buffer):
(WebKit::NetworkCache::Encoder::bufferSize):
(WebKit::NetworkCache::Encoder::updateChecksumForNumber):
- 3:34 AM Changeset in webkit [185496] by
-
- 14 edits in trunk
[EFL] Fix deprecated declarations warnings related to WK2 versioned structs
https://bugs.webkit.org/show_bug.cgi?id=145913
Reviewed by Gyuyoung Kim.
Source/WebKit2:
- UIProcess/API/efl/ewk_favicon_database.cpp:
(EwkFaviconDatabase::EwkFaviconDatabase):
- UIProcess/efl/ContextHistoryClientEfl.cpp:
(WebKit::ContextHistoryClientEfl::ContextHistoryClientEfl):
- UIProcess/efl/ContextMenuClientEfl.cpp:
(ContextMenuClientEfl::ContextMenuClientEfl):
- UIProcess/efl/DownloadManagerEfl.cpp:
(WebKit::DownloadManagerEfl::DownloadManagerEfl):
- UIProcess/efl/FindClientEfl.cpp:
(WebKit::FindClientEfl::FindClientEfl):
- UIProcess/efl/FormClientEfl.cpp:
(WebKit::FormClientEfl::FormClientEfl):
- UIProcess/efl/PageUIClientEfl.cpp:
(WebKit::PageUIClientEfl::PageUIClientEfl):
Tools:
- TestWebKitAPI/Tests/WebKit2/Geolocation.cpp:
(TestWebKitAPI::setupGeolocationProvider):
- TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayoutFrames.cpp:
(TestWebKitAPI::setPageLoaderClient):
- TestWebKitAPI/Tests/WebKit2/UserMessage.cpp:
(TestWebKitAPI::WebKit2UserMessageRoundTripTest::setPageLoaderClient):
- WebKitTestRunner/GeolocationProviderMock.cpp:
(WTR::GeolocationProviderMock::GeolocationProviderMock):
- WebKitTestRunner/WebNotificationProvider.cpp:
(WTR::WebNotificationProvider::provider):
- 3:30 AM Changeset in webkit [185495] by
-
- 2 edits in trunk
[EFL] Bump EWebKit version from 1.11.0 to 1.14.0
https://bugs.webkit.org/show_bug.cgi?id=145909
Reviewed by Csaba Osztrogonác.
Bump EWebKit version based on efl library version used by the EWebKit.
- Source/cmake/OptionsEfl.cmake:
- 3:03 AM Changeset in webkit [185494] by
-
- 3 edits in trunk/Tools
Fix the libusrsctp build with clang
https://bugs.webkit.org/show_bug.cgi?id=145128
Reviewed by Gyuyoung Kim.
- efl/jhbuild.modules:
- gtk/jhbuild.modules:
- 2:25 AM Changeset in webkit [185493] by
-
- 10 edits in trunk/Source/WebCore
Bindings generator should generate code for Promise-based APIs
https://bugs.webkit.org/show_bug.cgi?id=145833
Reviewed by Darin Adler.
Covered by existing tests.
- Modules/webaudio/AudioContext.idl: Removing custom binding for resume, suspend and close.
- bindings/js/JSAudioContextCustom.cpp: Ditto.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Refactoring to use IsReturningPromise.
(GenerateImplementation): Disabling include for return type if it is a promise.
(GenerateParametersCheck): Adding DeferredWrapper() as argument to the DOM method if JS method returns a promise.
(GenerateImplementationFunctionCall): Added support for promise-returning API.
(IsReturningPromise): Checking whether function is returning a promise.
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_test_promise_function):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionTestPromiseFunction):
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj testPromiseFunction]):
- bindings/scripts/test/TestObj.idl: Adding promise returning function.
- 1:19 AM Changeset in webkit [185492] by
-
- 5 edits in trunk
[CSS Grid Layout] Fix grid-template-areas parsing to avoid spaces
https://bugs.webkit.org/show_bug.cgi?id=145860
Reviewed by Sergio Villar Senin.
Source/WebCore:
The spec doesn't require to have spaces between unnamed and named areas
in grid-template-areas syntax. But spaces are currently required in our
code.
This was confirmed in the CSS WG mailing list:
https://lists.w3.org/Archives/Public/www-style/2015May/0239.html
This patch updates grid-template-areas parsing to allow the possibility
of removing spaces between unnamed and named areas.
Added new cases to fast/css-grid-layout/grid-template-areas-get-set.html.
- css/CSSParser.cpp:
(WebCore::parseGridTemplateAreasColumnNames): New helper method to
determine the column names split by white spaces or dots.
(WebCore::CSSParser::parseGridTemplateAreasRow): Use the new helper
method to get the column names.
(WebCore::containsOnlyDots): Deleted. Not needed anymore as
parseGridTemplateAreasColumnNames() is using a single dot for unnamed
grid areas (despite of being defined with 1 or more dots).
LayoutTests:
- fast/css-grid-layout/grid-template-areas-get-set-expected.txt:
- fast/css-grid-layout/grid-template-areas-get-set.html: Add new test
cases.
- 12:37 AM Changeset in webkit [185491] by
-
- 10 edits in tags/Safari-601.1.35/Source
Merge custom patch. rdar://problem/21129111
- 12:29 AM Changeset in webkit [185490] by
-
- 10 edits in tags/Safari-601.1.35/Source
Merge custom patch. rdar://problem/21129111
- 12:05 AM Changeset in webkit [185489] by
-
- 1 copy in tags/Safari-601.1.35
New tag.
- 12:00 AM Changeset in webkit [185488] by
-
- 5 edits in trunk/Source
Versioning.
Jun 11, 2015:
- 10:39 PM Changeset in webkit [185487] by
-
- 18 edits in trunk
WebCore::reportException() needs to be able to accept a raw thrown value in addition to Exception objects.
https://bugs.webkit.org/show_bug.cgi?id=145872
Reviewed by Michael Saboff.
Source/JavaScriptCore:
In r185259, we changed exception handling code inside the VM to work with
Exception objects instead of the thrown JSValue. The handling code will get the
exception stack trace from the Exception object.
However, there is some code that cannot be updated to pass the Exception object.
An example of this are the ObjC API functions. Those functions are specified to
return any thrown exception JSValue in a JSValueRef. Since these APIs are
public, we cannot arbitrarily change them to use the Exception object.
There are client code that calls these APIs and then passes the returned exception
JSValue to WebCore::reportException() to be reported. WebCore::reportException()
previously relied on the VM::exceptionStackTrace() to provide a cache of the
stack trace of the last thrown exception. VM::exceptionStackTrace() no longer
exists in the current code.
To restore this functionality, we will introduce VM::lastException() which
caches the last thrown Exception object. With this, if the exception passed to
WebCore::reportException() to be reported isn't an Exception object (which has its
own stack trace), reportException() can again use the cached exception stack trace
which is available from VM::lastException().
- heap/Heap.cpp:
(JSC::Heap::visitException):
- visit VM::m_lastException on GCs.
- interpreter/CallFrame.h:
(JSC::ExecState::lastException):
(JSC::ExecState::clearLastException):
- convenience functions to get and clear the last exception.
- runtime/Exception.cpp:
(JSC::Exception::create):
(JSC::Exception::finishCreation):
- add support to create an Exception object without capturing the JS stack trace. This is needed for making an Exception object to wrap a thrown value that does not have a stack trace. Currently, this is only used by WebCore::reportException() when there is no Exception object and no last exception available to provide a stack trace.
- runtime/Exception.h:
(JSC::Exception::cast): Deleted. No longer needed.
- runtime/VM.h:
(JSC::VM::clearLastException):
(JSC::VM::setException):
(JSC::VM::lastException):
(JSC::VM::addressOfLastException):
- Added support for VM::m_lastException. VM::m_lastException serves to cache the exception stack of the most recently thrown exception like VM::exceptionStackTrace() used to before r185259.
- runtime/VMEntryScope.cpp:
(JSC::VMEntryScope::VMEntryScope):
- Clear VM::m_lastException when we re-enter the VM. Exceptions should have been handled before we re-enter the VM anyway. So, this is a good place to release the cached last exception.
NOTE: this is also where the old code before r185259 clears the last exception
stack trace. So, we're just restoring the previous behavior here in terms of
the lifecycle of the last exception stack.
Source/WebCore:
API test added: WebKit1.ReportExceptionTest.
- bindings/js/JSDOMBinding.cpp:
(WebCore::reportException):
- Added a version of reportException() that takes a JSValue instead of an Exception object. This version will ensure that we have an Exception object before calling into the original reportException() as follows:
- If the JSValue is already an Exception object, we're good to go.
- Else, if VM::lastException() is available, use that as the exception. This is how the old code use to behave (in terms of where it gets the exception stack trace). The assumption is that reportException() will be called in a timely manner before the exception stack trace has been purged.
- Else, create an Exception object with no stack trace. This is the fall back in case the client did not call reportException() in a timely manner.
- Also clear the last exception after we've reported it. This is how the old code before r185259 behave (in terms of the lifecycle of the last exception stack trace). We're restoring that behavior here.
- bindings/js/JSDOMBinding.h:
Source/WebKit/mac:
- WebView/WebView.mm:
(+[WebView _reportException:inContext:]):
- Don't assume we have an Exception object. Let WebCore::reportException() take care of it.
Source/WebKit/win:
- WebView.cpp:
(WebView::reportException):
- Don't assume we have an Exception object. Let WebCore::reportException() take care of it.
Source/WebKit2:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::reportException):
- Don't assume we have an Exception object. Let WebCore::reportException() take care of it.
Tools:
- TestWebKitAPI/Tests/mac/WebViewDidCreateJavaScriptContext.mm:
(-[DidCreateJavaScriptContextFrameLoadDelegate webView:didCreateJavaScriptContext:forFrame:]):
- Exercises the JSC ObjC API to call a function which throws an exception. That exception will be returned as a JSValue instead of an Exception object. We will use this JSValue to test WebCore::reportException() to confirm that it is able to handle an exception value which is not an Exception object.
- 9:09 PM Changeset in webkit [185486] by
-
- 2 edits in trunk/Source/JavaScriptCore
jsSubstring() should support creating substrings from substrings.
<https://webkit.org/b/145427>
Reviewed by Geoffrey Garen
Tweak jsSubstring() to support base strings that are themselves substrings.
They will now share the same grandparent base. This avoids creating a new StringImpl.
- runtime/JSString.h:
(JSC::jsSubstring): Don't force rope resolution here. Instead do that in finishCreation()
if the base string is a non-substring rope. Note that resolveRope() is the very last thing
called, since it may allocate and the JSRopeString needs to be ready for marking.
(JSC::JSString::isSubstring): Added a helper to find out if a JSString is
a substring. This is just for internal use, so you don't have to cast to
JSRopeString for the real substringness flag.
- 7:59 PM Changeset in webkit [185485] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: CSS Regions not displaying DOM Trees in inspector
https://bugs.webkit.org/show_bug.cgi?id=145903
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-11
Reviewed by Timothy Hatcher.
- UserInterface/Controllers/DOMTreeManager.js:
(WebInspector.DOMTreeManager.prototype._updateContentFlowFromPayload):
Fix function inside the assertion to actually return a value.
- UserInterface/Views/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline.prototype.update):
For DOMTreeOutlines without a root node, don't clear the tree on updates,
since that will clear the nodes that have already been added explicitly.
- UserInterface/Views/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel.prototype._treeElementSelected):
- UserInterface/Views/ResourcesTabContentView.js:
(WebInspector.ResourcesTabContentView.prototype.canShowRepresentedObject):
ResourceTab and sidebar can deal with ContentFlow related views.
- 7:49 PM Changeset in webkit [185484] by
-
- 10 edits in trunk
Do not crash when the descendant frame tree is destroyed during layout.
https://bugs.webkit.org/show_bug.cgi?id=144540
rdar://problem/20793184
Reviewed by Andreas Kling.
Source/WebCore:
Widget::setFrameRect(), through WebHTMLView layout, could trigger a style recalc, which in turn
could initiate an onBeforeLoad callback.
If javascript happens to destroy the current iframe in the onBeforeLoad callback, we lose the descendant
render tree, including the child FrameView (the iframe element's view). However the RenderIFrame
object stays protected until after the layout is done. (see protectRenderWidgetUntilLayoutIsDone())
Climbing back on the callstack, we need to make sure that
- the root widget of the descendant render tree (FrameView) stays valid as long as it is needed.
- RenderFrameBase::layoutWithFlattening() can handle the case when the associated widget (child FrameView) is set to nullptr.
(see RenderWidget::willBeDestroyed() -> setWidget(nullptr))
(and later, when layout is finished this (RenderIFrame) object gets destroyed too.)
Covered by fast/frames/flattening/crash-remove-iframe-during-object-beforeload.html.
- page/FrameView.cpp:
(WebCore::FrameView::setFrameRect):
(WebCore::FrameView::updateEmbeddedObject):
(WebCore::FrameView::updateWidgetPositions):
- platform/ScrollView.cpp:
(WebCore::ScrollView::setFrameRect):
- platform/mac/WidgetMac.mm:
(WebCore::Widget::setFrameRect):
- rendering/RenderFrameBase.cpp:
(WebCore::RenderFrameBase::layoutWithFlattening):
(WebCore::RenderFrameBase::childRenderView):
(WebCore::RenderFrameBase::peformLayoutWithFlattening):
- rendering/RenderFrameBase.h:
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::updateWidgetPosition):
- rendering/RenderWidget.h:
LayoutTests:
Unskip fast/frames/flattening/crash-remove-iframe-during-object-beforeload.html.
- 7:16 PM Changeset in webkit [185483] by
-
- 5 edits in trunk/Tools
Move cursor to corner and fix safari window size before running benchmark
https://bugs.webkit.org/show_bug.cgi?id=145858
Patch by Dewei Zhu <Dewei Zhu> on 2015-06-11
Reviewed by Ryosuke Niwa
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
(OSXBrowserDriver.prepareEnv):
(OSXBrowserDriver):
(OSXBrowserDriver.moveCursor):
(OSXBrowserDriver.getScreenSize):
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
(OSXChromeDriver.launchUrl):
(OSXChromeCanaryDriver.launchUrl):
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
(OSXFirefoxDriver.launchUrl):
(OSXFirefoxNightlyDriver.launchUrl):
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
(OSXSafariDriver.prepareEnv):
(OSXSafariDriver):
(OSXSafariDriver.maximizeWindow):
- 6:46 PM Changeset in webkit [185482] by
-
- 2 edits in trunk/Source/WebKit2
[CMake] Unreviewed build fix after r185479.
- CMakeLists.txt: Unlist the files that r185479 deleted.
- 5:21 PM Changeset in webkit [185481] by
-
- 10 edits2 deletes in trunk
Unreviewed, rolling out r185470.
https://bugs.webkit.org/show_bug.cgi?id=145902
Caused ASan violations (Requested by ap on #webkit).
Reverted changeset:
"Add an appearance keyword for wireless playback / airplay
icon"
https://bugs.webkit.org/show_bug.cgi?id=145892
http://trac.webkit.org/changeset/185470
- 5:17 PM Changeset in webkit [185480] by
-
- 13 edits2 adds in trunk
IndexedDB onupgradeneeded event has incorrect value for oldVersion.
<rdar://problem/18309792> and https://bugs.webkit.org/show_bug.cgi?id=136888
Reviewed by Sam Weinig.
Source/WebCore:
Test: storage/indexeddb/version-change-event-basic.html
"NoIntVersion" is an internal bookkeeping concept that we never should've been passing to Javascript.
This cleans up things by:
- Adjusting an old version of "NoIntVersion" to "0" before making the version change callback.
- Removing the VersionNullness parameter from almost everywhere.
- Removing the nullability of the newVersion parameter from the IDL.
- Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::onVersionChange):
- Modules/indexeddb/IDBDatabase.h:
- Modules/indexeddb/IDBDatabaseBackend.cpp:
(WebCore::IDBDatabaseBackend::runIntVersionChangeTransaction):
(WebCore::IDBDatabaseBackend::deleteDatabase):
- Modules/indexeddb/IDBDatabaseCallbacks.h:
- Modules/indexeddb/IDBDatabaseCallbacksImpl.cpp:
(WebCore::IDBDatabaseCallbacksImpl::onVersionChange):
- Modules/indexeddb/IDBDatabaseCallbacksImpl.h:
- Modules/indexeddb/IDBOpenDBRequest.cpp:
(WebCore::IDBOpenDBRequest::onBlocked):
(WebCore::IDBOpenDBRequest::onUpgradeNeeded):
- Modules/indexeddb/IDBTransactionBackendOperations.cpp:
(WebCore::IDBDatabaseBackend::VersionChangeOperation::perform):
- Modules/indexeddb/IDBVersionChangeEvent.cpp:
(WebCore::IDBVersionChangeEvent::IDBVersionChangeEvent):
- Modules/indexeddb/IDBVersionChangeEvent.h:
(WebCore::IDBVersionChangeEvent::create):
(WebCore::IDBVersionChangeEvent::newVersion):
- Modules/indexeddb/IDBVersionChangeEvent.idl:
LayoutTests:
- storage/indexeddb/version-change-event-basic-expected.txt: Added.
- storage/indexeddb/version-change-event-basic.html: Added.
- 5:13 PM Changeset in webkit [185479] by
-
- 14 edits4 deletes in trunk/Source/WebKit2
Get rid of WebOriginDataManager
https://bugs.webkit.org/show_bug.cgi?id=145896
Reviewed by Andreas Kling.
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::DatabaseProcess): Deleted.
(WebKit::DatabaseProcess::getOrigins): Deleted.
(WebKit::DatabaseProcess::deleteEntriesForOrigin): Deleted.
(WebKit::DatabaseProcess::deleteEntriesModifiedBetweenDates): Deleted.
(WebKit::DatabaseProcess::deleteAllEntries): Deleted.
- DatabaseProcess/DatabaseProcess.h:
- DerivedSources.make:
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKContext.cpp:
- UIProcess/Databases/DatabaseProcessProxy.cpp:
(WebKit::DatabaseProcessProxy::didReceiveMessage): Deleted.
- UIProcess/WebOriginDataManagerProxy.cpp: Removed.
(WebKit::WebOriginDataManagerProxy::supplementName): Deleted.
(WebKit::WebOriginDataManagerProxy::create): Deleted.
(WebKit::WebOriginDataManagerProxy::WebOriginDataManagerProxy): Deleted.
(WebKit::WebOriginDataManagerProxy::~WebOriginDataManagerProxy): Deleted.
(WebKit::WebOriginDataManagerProxy::processPoolDestroyed): Deleted.
(WebKit::WebOriginDataManagerProxy::processDidClose): Deleted.
(WebKit::WebOriginDataManagerProxy::shouldTerminate): Deleted.
(WebKit::WebOriginDataManagerProxy::refWebContextSupplement): Deleted.
(WebKit::WebOriginDataManagerProxy::derefWebContextSupplement): Deleted.
(WebKit::CallbackSynchronizer::create): Deleted.
(WebKit::CallbackSynchronizer::~CallbackSynchronizer): Deleted.
(WebKit::CallbackSynchronizer::taskStarted): Deleted.
(WebKit::CallbackSynchronizer::taskCompleted): Deleted.
(WebKit::CallbackSynchronizer::CallbackSynchronizer): Deleted.
(WebKit::createSynchronizedCallback): Deleted.
(WebKit::sendMessageToAllProcessesInProcessPool): Deleted.
(WebKit::WebOriginDataManagerProxy::getOrigins): Deleted.
(WebKit::WebOriginDataManagerProxy::didGetOrigins): Deleted.
(WebKit::WebOriginDataManagerProxy::deleteEntriesForOrigin): Deleted.
(WebKit::WebOriginDataManagerProxy::deleteEntriesModifiedBetweenDates): Deleted.
(WebKit::WebOriginDataManagerProxy::didDeleteEntries): Deleted.
(WebKit::WebOriginDataManagerProxy::deleteAllEntries): Deleted.
(WebKit::WebOriginDataManagerProxy::didDeleteAllEntries): Deleted.
- UIProcess/WebOriginDataManagerProxy.h: Removed.
- UIProcess/WebOriginDataManagerProxy.messages.in: Removed.
- UIProcess/WebProcessPool.cpp:
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/OriginData/WebOriginDataManager.cpp: Removed.
(WebKit::WebOriginDataManager::WebOriginDataManager): Deleted.
(WebKit::WebOriginDataManager::getOrigins): Deleted.
(WebKit::WebOriginDataManager::deleteEntriesForOrigin): Deleted.
(WebKit::WebOriginDataManager::deleteEntriesModifiedBetweenDates): Deleted.
(WebKit::WebOriginDataManager::deleteAllEntries): Deleted.
- WebProcess/OriginData/WebOriginDataManager.h: Removed.
- WebProcess/OriginData/WebOriginDataManager.messages.in: Removed.
- WebProcess/OriginData/WebOriginDataManagerSupplement.h: Removed.
(WebKit::WebOriginDataManagerSupplement::WebOriginDataManagerSupplement): Deleted.
(WebKit::WebOriginDataManagerSupplement::~WebOriginDataManagerSupplement): Deleted.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::~WebProcess):
(WebKit::WebProcess::WebProcess): Deleted.
(WebKit::WebProcess::getOrigins): Deleted.
(WebKit::WebProcess::deleteEntriesForOrigin): Deleted.
(WebKit::WebProcess::deleteEntriesModifiedBetweenDates): Deleted.
(WebKit::WebProcess::deleteAllEntries): Deleted.
- WebProcess/WebProcess.h:
- WebProcess/cocoa/WebProcessCocoa.mm:
- 3:30 PM Changeset in webkit [185478] by
-
- 4 edits1 add in trunk/Tools
[iOS] Cannot run run-webkit-tests with public SDK; LayoutTestRelay fails to build
https://bugs.webkit.org/show_bug.cgi?id=145319
Reviewed by David Kilzer.
Add SPI wrapper header for CoreSimulator and update the source files to reference
it instead of directly referencing the CoreSimulator header.
- LayoutTestRelay/LayoutTestRelay.xcodeproj/project.pbxproj:
- LayoutTestRelay/LayoutTestRelay/CoreSimulatorSPI.h: Added.
- LayoutTestRelay/LayoutTestRelay/LTRelayController.m:
- LayoutTestRelay/LayoutTestRelay/main.m:
- 2:49 PM Changeset in webkit [185477] by
-
- 12 edits1 add in trunk/Source
Media Session: Add plumbing for media control event delivery.
https://bugs.webkit.org/show_bug.cgi?id=145859
Patch by Matt Rajca <mrajca@apple.com> on 2015-06-11
Reviewed by Anders Carlsson.
Source/WebCore:
- Modules/mediasession/MediaEventTypes.h: Added.
- WebCore.xcodeproj/project.pbxproj:
- page/Page.cpp:
(WebCore::Page::handleMediaEvent): Toggle media playback upon receiving the PlayPause event as described in the spec.
- page/Page.h:
Source/WebKit2:
- UIProcess/API/C/WKPage.cpp:
(WKPageHandleMediaEvent):
- UIProcess/API/C/WKPagePrivate.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleMediaEvent):
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::handleMediaEvent):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 2:40 PM Changeset in webkit [185476] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: IndexedDB data not showing for MDN example page
https://bugs.webkit.org/show_bug.cgi?id=145851
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-06-11
Reviewed by Anders Carlsson.
- UserInterface/Views/StorageSidebarPanel.js:
(WebInspector.StorageSidebarPanel.prototype._indexedDatabaseWasAdded):
Fix typo in Storage tab refactoring that was causing an
uncaught exception and not showing Indexed DBs.
- 2:29 PM Changeset in webkit [185475] by
-
- 2 edits in trunk/Source/WebKit2
[OS X] Decoding fonts may return nil when using force click
https://bugs.webkit.org/show_bug.cgi?id=145890
Reviewed by Beth Dakin.
[NSFontDescriptor fontDescriptorWithFontAttributes] might return nil, which
causes the encoding of an NSFont to erroneously return true.
- Shared/mac/ArgumentCodersMac.mm:
(IPC::decode):
- 2:11 PM Changeset in webkit [185474] by
-
- 4 edits in trunk/Source/WebKit2
Reimplement WKOriginDataManager in terms of API::WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=145889
Reviewed by Dan Bernstein.
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKContext.cpp:
(WKContextGetOriginDataManager):
- UIProcess/API/C/WKOriginDataManager.cpp:
(WKOriginDataManagerGetTypeID):
(WKOriginDataManagerGetOrigins):
(WKOriginDataManagerDeleteEntriesForOrigin):
(WKOriginDataManagerDeleteEntriesModifiedBetweenDates):
(WKOriginDataManagerDeleteAllEntries):
- 2:06 PM Changeset in webkit [185473] by
-
- 2 edits in trunk/Source/WebKit2
Full screen video space can be resized to 1pt wide
https://bugs.webkit.org/show_bug.cgi?id=145895
<rdar://problem/20907914>
Reviewed by Simon Fraser.
Prior to the upcoming OS X, full screen mode was not resizable. Now that it is,
we need to set a minimum window width that is large enough to hold the media
controls. This makes our full-screen video behave the same as the QuickTimeX player.
- UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Active that new
kWKLayoutModeDynamicSizeWithMinimumViewSize style, and set the minimum view size to
be the width of our media controls, with 20 pixels of padding on either side.
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]): Set the layout
mode back to the default style.
- 1:53 PM Changeset in webkit [185472] by
-
- 18 edits in trunk/Source
Update media controls JS and CSS to use picture-in-picture
https://bugs.webkit.org/show_bug.cgi?id=145827
<rdar://problem/21311576>
Reviewed by Dean Jackson.
Source/WebCore:
- English.lproj/mediaControlsLocalizedStrings.js: Update localized strings.
Add a string for the placeholder text, and for the aria-label of the
placard.
- Modules/mediacontrols/MediaControlsHost.idl: Remove uncalled functions.
- Modules/mediacontrols/MediaControlsHost.h: Also remove optimizedFullscreenSupported(),
which was never used.
- Modules/mediacontrols/MediaControlsHost.cpp: Remove uncalled functions and media part IDs.
(WebCore::MediaControlsHost::enterFullscreenOptimized): Deleted.
(WebCore::MediaControlsHost::mediaUIImageData): Deleted.
- Modules/mediacontrols/mediaControlsApple.css:
(audio::-webkit-media-controls-picture-in-picture-button): Update pseudo-element name.
(audio::-webkit-media-controls-optimized-fullscreen-button): Deleted.
- Modules/mediacontrols/mediaControlsApple.js: Update global variable name, and classes.
(Controller.prototype.createControls): Update button name. Add aria-label to the placeholder.
(Controller.prototype.updateFullscreenButtons):
(Controller.prototype.updateLayoutForDisplayedWidth):
(Controller.prototype.handlePictureInPictureButtonClicked): Update handler names.
(Controller.prototype.handleOptimizedFullscreenButtonClicked): Deleted.
- Modules/mediacontrols/mediaControlsiOS.css: Rename pseudo-element.
(audio::-webkit-media-controls-picture-in-picture-button): Add mask images.
(audio::-webkit-media-controls-picture-in-picture-button:active):
(video::-webkit-media-controls-picture-in-picture-button):
(video::-webkit-media-controls-picture-in-picture-button.return-from-picture-in-picture):
(audio::-webkit-media-controls-wireless-playback-status.picture-in-picture):
(audio::-webkit-media-controls-wireless-playback-text-top.picture-in-picture):
(audio::-webkit-media-controls-wireless-playback-text-bottom.picture-in-picture):
(audio::-webkit-media-controls-optimized-fullscreen-button): Deleted.
(audio::-webkit-media-controls-optimized-fullscreen-button:active): Deleted.
(video::-webkit-media-controls-optimized-fullscreen-button): Deleted.
(audio::-webkit-media-controls-wireless-playback-status.optimized): Deleted. The placard
pseudo-element should be updated from wireless-playback-status to just playback-status
since it serves both for pip and AirPlay.
(audio::-webkit-media-controls-wireless-playback-text-top.optimized): Deleted.
(audio::-webkit-media-controls-wireless-playback-text-bottom.optimized): Deleted.
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.createControls): Update button names.
(ControllerIOS.prototype.configureInlineControls):
(ControllerIOS.prototype.handlePictureInPictureButtonClicked): Update handler name.
(ControllerIOS.prototype.handlePictureInPictureTouchStart):
(ControllerIOS.prototype.handlePictureInPictureTouchEnd):
(ControllerIOS.prototype.handlePictureInPictureTouchCancel):
(ControllerIOS.prototype.handlePresentationModeChange): Remove changes to the inline bg
image style, and rely on the CSS to fill those in. Use localized strings for the placard.
Move the aria-label to createControls().
(ControllerIOS.prototype.handleOptimizedFullscreenButtonClicked): Deleted.
(ControllerIOS.prototype.handleOptimizedFullscreenTouchStart): Deleted.
(ControllerIOS.prototype.handleOptimizedFullscreenTouchEnd): Deleted.
(ControllerIOS.prototype.handleOptimizedFullscreenTouchCancel): Deleted.
- html/HTMLMediaElement.cpp: Remove enterFullscreenOptimized since it is never called.
(WebCore::HTMLMediaElement::enterFullscreenOptimized): Deleted.
- html/HTMLMediaElement.h:
- platform/ios/WebCoreSystemInterfaceIOS.h: Remove wkGetMediaUIImageData.
- platform/ios/WebCoreSystemInterfaceIOS.mm:
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::mediaControlsStyleSheet): Remove calls to wkGetMediaUIImageData.
Source/WebKit/mac:
- WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Deleted GetMediaUIImageData.
Source/WebKit2:
- WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Deleted GetMediaUIImageData.
- 1:51 PM Changeset in webkit [185471] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: font-family names interpreted as color
https://bugs.webkit.org/show_bug.cgi?id=123468
Patch by Devin Rousso <Devin Rousso> on 2015-06-11
Reviewed by Timothy Hatcher.
- UserInterface/Views/CodeMirrorAdditions.js: Added logic to prevent color picker buttons from appearing before colors that come after a quote character (both " and ').
- 1:50 PM Changeset in webkit [185470] by
-
- 10 edits2 adds in trunk
Add an appearance keyword for wireless playback / airplay icon
https://bugs.webkit.org/show_bug.cgi?id=145892
<rdar://problem/21344872>
Reviewed by Simon Fraser.
Source/WebCore:
Add a new "-webkit-appearance" value named "-apple-airplay"
which will be used to render an icon. This change simply
adds support for the value, and puts in hooks for drawing.
At the moment this is only going to be used by Airplay, so
the public-facing name is "-apple-airplay". However, the
implementation in Theme has a more generic name, in case
we hook it up for other ports later.
Test: fast/css/appearance-airplay.html
- css/CSSParser.cpp:
(WebCore::cssValueKeywordID): This new keyword should not get
translated into having a -webkit prefix.
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue): New mapping from
the Theme to the CSS value.
- css/CSSValueKeywords.in: Add "-apple-airplay".
- platform/ThemeTypes.h: New ControlPart.
- rendering/RenderTheme.cpp: Stub implementation of the rendering and
style update for the new appearance.
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::paint):
(WebCore::RenderTheme::adjustWirelessPlaybackIconStyle):
(WebCore::RenderTheme::paintWirelessPlaybackIcon):
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::adjustWirelessPlaybackIconStyle):
(WebCore::RenderThemeMac::paintWirelessPlaybackIcon):
LayoutTests:
Simple test that makes sure we parse and evaluate
the new appearance value.
- fast/css/appearance-airplay-expected.txt: Added.
- fast/css/appearance-airplay.html: Added.
- 1:23 PM Changeset in webkit [185469] by
-
- 3 edits in trunk/LayoutTests
Update plugins/embed-attributes-style.html to not use the QuickTime plug-in
https://bugs.webkit.org/show_bug.cgi?id=145891
Reviewed by Anders Carlsson.
- platform/mac/plugins/embed-attributes-style-expected.png:
- plugins/embed-attributes-style.html:
- 1:21 PM Changeset in webkit [185468] by
-
- 10 edits in trunk/Source/WebCore
Unreviewed, rolling out r185464.
https://bugs.webkit.org/show_bug.cgi?id=145894
"This patch is breaking binding tests" (Requested by youenn on
#webkit).
Reverted changeset:
"Bindings generator should generate code for Promise-based
APIs"
https://bugs.webkit.org/show_bug.cgi?id=145833
http://trac.webkit.org/changeset/185464
- 1:12 PM Changeset in webkit [185467] by
-
- 11 edits in trunk
Unreviewed, rolling out r185465.
https://bugs.webkit.org/show_bug.cgi?id=145893
"This patch is breaking 32bit mac build" (Requested by youenn
on #webkit).
Reverted changeset:
"[Streams API] ReadableJSStream should handle promises
returned by JS source start callback"
https://bugs.webkit.org/show_bug.cgi?id=145792
http://trac.webkit.org/changeset/185465
- 1:09 PM Changeset in webkit [185466] by
-
- 2 edits in trunk/Source/WebKit2
Speculative build fix for GTK after r185463.
- CMakeLists.txt:
Remove WebPluginSiteDataManager.cpp from CMake build.
- 12:30 PM Changeset in webkit [185465] by
-
- 11 edits in trunk
[Streams API] ReadableJSStream should handle promises returned by JS source start callback
https://bugs.webkit.org/show_bug.cgi?id=145792
Source/JavaScriptCore:
Reviewed by Darin Adler.
Added support for JSFunction implemented by std::function.
- runtime/JSFunction.cpp:
(JSC::getNativeExecutable): Refactored code to share it with the two JSFunction::create
(JSC::JSFunction::create):
(JSC::runStdFunction):
- runtime/JSFunction.h: Added std::function based JSFunction::create prototype.
- runtime.JSPromise.h:
Source/WebCore:
Reviewed by Darin Adler.
Covered by rebased tests.
When calling start callback, the returned value is checked.
If it is not a promise, we do as if it is a resolved promise.
If it is a promise, we call its then() method with two resolve/reject JS functions.
- Modules/streams/ReadableStream.cpp:
- bindings/js/ReadableJSStream.cpp:
(WebCore::ReadableJSStream::invoke): Returns a JSPromise* if any is returned by the JS source callback.
(WebCore::thenPromise): Utility method to call the promise.
(WebCore::createStartResultFulfilledFunction): The promise resolve callback.
(WebCore::ReadableJSStream::doStart): Calls thenPromise if a JSPromise* is returned by invoke.
(WebCore::ReadableJSStream::ReadableJSStream):
- bindings/js/ReadableJSStream.h:
LayoutTests:
Reviewed by Darin Adler.
Rebasing expectations, and removing timeouts for tests that no longer timeout.
- streams/reference-implementation/readable-stream-expected.txt:
- streams/reference-implementation/readable-stream.html:
- 12:26 PM Changeset in webkit [185464] by
-
- 10 edits in trunk/Source/WebCore
Bindings generator should generate code for Promise-based APIs
https://bugs.webkit.org/show_bug.cgi?id=145833
Reviewed by Darin Adler.
Covered by existing tests.
- Modules/webaudio/AudioContext.idl: Removing custom binding for resume, suspend and close.
- bindings/js/JSAudioContextCustom.cpp: Ditto.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader): Refactoring to use IsReturningPromise.
(GenerateImplementation): Disabling include for return type if it is a promise.
(GenerateParametersCheck): Adding DeferredWrapper() as argument to the DOM method if JS method returns a promise.
(GenerateImplementationFunctionCall): Added support for promise-returning API.
(IsReturningPromise): Checking whether function is returning a promise.
- bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_test_promise_function):
- bindings/scripts/test/GObject/WebKitDOMTestObj.h:
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionTestPromiseFunction):
- bindings/scripts/test/ObjC/DOMTestObj.h:
- bindings/scripts/test/ObjC/DOMTestObj.mm:
(-[DOMTestObj testPromiseFunction]):
- bindings/scripts/test/TestObj.idl: Adding promise returning function.
- 11:33 AM Changeset in webkit [185463] by
-
- 16 edits2 deletes in trunk/Source/WebKit2
Remove WebPluginSiteDataManager
https://bugs.webkit.org/show_bug.cgi?id=145884
Reviewed by Andreas Kling.
- PluginProcess/PluginProcess.cpp:
(WebKit::PluginProcess::clearSiteData): Deleted.
- PluginProcess/PluginProcess.h:
- PluginProcess/PluginProcess.messages.in:
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKContext.cpp:
- UIProcess/API/C/WKPluginSiteDataManager.cpp:
- UIProcess/Plugins/PluginProcessManager.cpp:
(WebKit::PluginProcessManager::clearSiteData): Deleted.
- UIProcess/Plugins/PluginProcessManager.h:
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::clearSiteData): Deleted.
(WebKit::PluginProcessProxy::pluginProcessCrashedOrFailedToLaunch): Deleted.
(WebKit::PluginProcessProxy::didFinishLaunching): Deleted.
(WebKit::PluginProcessProxy::didClearSiteData): Deleted.
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/Plugins/PluginProcessProxy.messages.in:
- UIProcess/Plugins/WebPluginSiteDataManager.cpp: Removed.
(WebKit::WebPluginSiteDataManager::GetSitesWithDataState::GetSitesWithDataState): Deleted.
(WebKit::WebPluginSiteDataManager::GetSitesWithDataState::getSitesWithDataForNextPlugin): Deleted.
(WebKit::WebPluginSiteDataManager::GetSitesWithDataState::didGetSitesWithDataForSinglePlugin): Deleted.
(WebKit::WebPluginSiteDataManager::ClearSiteDataState::ClearSiteDataState): Deleted.
(WebKit::WebPluginSiteDataManager::ClearSiteDataState::clearSiteDataForNextPlugin): Deleted.
(WebKit::WebPluginSiteDataManager::ClearSiteDataState::didClearSiteDataForSinglePlugin): Deleted.
(WebKit::WebPluginSiteDataManager::create): Deleted.
(WebKit::WebPluginSiteDataManager::WebPluginSiteDataManager): Deleted.
(WebKit::WebPluginSiteDataManager::~WebPluginSiteDataManager): Deleted.
(WebKit::WebPluginSiteDataManager::invalidate): Deleted.
(WebKit::WebPluginSiteDataManager::getSitesWithData): Deleted.
(WebKit::WebPluginSiteDataManager::didGetSitesWithData): Deleted.
(WebKit::WebPluginSiteDataManager::clearSiteData): Deleted.
(WebKit::WebPluginSiteDataManager::didClearSiteData): Deleted.
(WebKit::WebPluginSiteDataManager::didGetSitesWithDataForSinglePlugin): Deleted.
(WebKit::WebPluginSiteDataManager::didGetSitesWithDataForAllPlugins): Deleted.
(WebKit::WebPluginSiteDataManager::didClearSiteDataForSinglePlugin): Deleted.
(WebKit::WebPluginSiteDataManager::didClearSiteDataForAllPlugins): Deleted.
- UIProcess/Plugins/WebPluginSiteDataManager.h: Removed.
(WebKit::WebPluginSiteDataManager::processPool): Deleted.
(WebKit::WebPluginSiteDataManager::clearProcessPool): Deleted.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::~WebProcessPool): Deleted.
- UIProcess/WebProcessPool.h:
- UIProcess/WebProcessProxy.cpp:
- WebKit2.xcodeproj/project.pbxproj:
- 11:30 AM Changeset in webkit [185462] by
-
- 1 copy in tags/Safari-600.1.4.16.7
New tag.
- 11:01 AM Changeset in webkit [185461] by
-
- 4 edits in trunk/Source/WebCore
Missing content in UIWebView snapshots sometimes
https://bugs.webkit.org/show_bug.cgi?id=145779
rdar://problem/20744708
Reviewed by Darin Adler.
When expanding collapsed parts of quoted text on iOS, sometimes the "concertina"
images would be blank. This happened because we'd fail to create tiles for regions
outside the LegacyTileCache's visibleRect.
Fix by giving LegacyTileCache an optional override visibleRect, which is set
and cleared during -renderInContext: using the context clip rect.
- platform/ios/LegacyTileCache.h:
- platform/ios/LegacyTileCache.mm:
(WebCore::LegacyTileCache::visibleRectInLayer):
(WebCore::LegacyTileCache::setOverrideVisibleRect):
- platform/ios/LegacyTileLayer.mm:
(-[LegacyTileHostLayer renderInContext:]):
- 10:45 AM Changeset in webkit [185460] by
-
- 4 edits in trunk/Source/WebKit2
Make WKWebsiteDataStoreRef backed by an API::WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=145882
Reviewed by Dan Bernstein.
- UIProcess/API/C/WKAPICast.h:
- UIProcess/API/C/WKContext.cpp:
(WKContextGetPluginSiteDataManager):
- UIProcess/API/C/WKPluginSiteDataManager.cpp:
(WKPluginSiteDataManagerGetTypeID):
(WKPluginSiteDataManagerGetSitesWithData):
(WKPluginSiteDataManagerClearSiteData):
(WKPluginSiteDataManagerClearAllSiteData):
- 10:20 AM Changeset in webkit [185459] by
-
- 10 edits2 deletes in trunk/Source/WebCore
Simplify event handling logic for search cancel button
https://bugs.webkit.org/show_bug.cgi?id=145780
Reviewed by Darin Adler.
Following the patch for <https://bugs.webkit.org/show_bug.cgi?id=145774> we can take advantage
of the DOM click event to simplify the event handling logic for the search cancel button.
It is sufficient to listen for mousedown and click events instead of listening for mousedown
and mouseup events, capturing all events during drag, and using the hover state of the button
on mouse release together with a instance variable set on mouse press to determine whether
the cancel button was clicked.
As a side effect of removing the requirement that the search cancel button be hovered (a
workaround to ensure that the mouse was pressed and released on the button in absence of
listening for an explicit DOM click event) we can remove the accessibility-specific class,
AccessibilitySearchFieldCancelButton, that was primarily used to fake the hover state of
the button so that the accessibility machinery could simulate a click on it. Instead we
can add use the default accessibility machinery for clicking on an element.
No new tests since no functionality was changed.
- CMakeLists.txt: Remove reference to file AccessibilitySearchFieldButtons.cpp.
- WebCore.vcxproj/WebCore.vcxproj: Remove reference to files AccessibilitySearchFieldButtons.{cpp, h}.
- WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto.
- accessibility/AXObjectCache.cpp:
(WebCore::createFromRenderer): Remove special-purpose logic that instantiated
AccessibilitySearchFieldCancelButton for the search cancel button. Instead we can make
use of the existing accessibility machinery to handle this button.
- accessibility/AccessibilityAllInOne.cpp: Remove #include of AccessibilitySearchFieldButtons.cpp
since the file is no longer needed.
- accessibility/AccessibilitySearchFieldButtons.cpp: Removed.
- accessibility/AccessibilitySearchFieldButtons.h: Removed.
- dom/Element.h:
(WebCore::Element::isSearchFieldCancelButtonElement): Deleted.
- html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::SearchFieldCancelButtonElement): Set the ARIA role
and label attributes so that the accessibility system identifies the search cancel button as
a button and shows a description for the button, respectively.
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler): Simplify the event handling logic
such that we clear the field when we receive a DOM click event (i.e. the mouse was pressed
and released on the button). Remove unused variable, oldValue. Substitute emptyString() for the
empty string literal in the call to HTMLInputElement::setValueForUser() to avoid an implicit
conversion to String. Also remove out-of-date comment that repeated what the code does.
(WebCore::SearchFieldCancelButtonElement::willDetachRenderers): Deleted. We no longer need to use
custom style resolve callbacks to reset the state of the EventHandler since we no longer need to
have the EventHandler dispatch all mouse events to us on mouse press.
- html/shadow/TextControlInnerElements.h:
- 10:03 AM Changeset in webkit [185458] by
-
- 5 edits in trunk/Source/WebKit2
Network process crashes decoding invalid cache entry on 32bit system
https://bugs.webkit.org/show_bug.cgi?id=145842
rdar://problem/21228334
Reviewed by Anders Carlsson.
After cache scheme changes we may end up decoding invalid cache entries. This is by design,
we should just fail decoding and delete these entries.
However Decoder::bufferIsLargeEnoughToContain test in some cases would allow corrupted large
sizes due to overflow in 32bit pointer math and we would crash when allocating a string.
- NetworkProcess/cache/NetworkCacheCoders.cpp:
(WebKit::NetworkCache::Coder<CString>::decode):
(WebKit::NetworkCache::decodeStringText):
(WebKit::NetworkCache::Coder<WebCore::CertificateInfo>::decode):
(WebKit::NetworkCache::Coder<MD5::Digest>::encode):
- NetworkProcess/cache/NetworkCacheCoders.h:
- NetworkProcess/cache/NetworkCacheDecoder.cpp:
(WebKit::NetworkCache::Decoder::Decoder):
(WebKit::NetworkCache::Decoder::bufferIsLargeEnoughToContain):
Reshuffle to avoid sum.
(WebKit::NetworkCache::Decoder::decodeFixedLengthData):
- NetworkProcess/cache/NetworkCacheDecoder.h:
(WebKit::NetworkCache::Decoder::bufferSize):
(WebKit::NetworkCache::Decoder::currentOffset):
(WebKit::NetworkCache::Decoder::length): Deleted.
(WebKit::NetworkCache::Decoder::isInvalid): Deleted.
(WebKit::NetworkCache::Decoder::markInvalid): Deleted.
Remove these, they are not really used or needed.
- 10:01 AM Changeset in webkit [185457] by
-
- 3 edits in trunk/Source/WebKit2
Rewrite WKPluginSiteDataManager using WebsiteDataStore functions
https://bugs.webkit.org/show_bug.cgi?id=145868
Reviewed by Antti Koivisto.
- UIProcess/API/C/WKPluginSiteDataManager.cpp:
(WKPluginSiteDataManagerGetSitesWithData):
(WKPluginSiteDataManagerClearSiteData):
(WKPluginSiteDataManagerClearAllSiteData):
(toNPClearSiteDataFlags): Deleted.
- UIProcess/Plugins/WebPluginSiteDataManager.h:
(WebKit::WebPluginSiteDataManager::processPool):
- 9:00 AM Changeset in webkit [185456] by
-
- 5 edits in trunk
Unreviewed, rolling out r185453.
https://bugs.webkit.org/show_bug.cgi?id=145881
it broke the 32-bit build (Requested by clopez on #webkit).
Reverted changeset:
"[GTK] [Wayland] Should be possible to build with support for
both X11 and Wayland."
https://bugs.webkit.org/show_bug.cgi?id=145701
http://trac.webkit.org/changeset/185453
- 8:42 AM Changeset in webkit [185455] by
-
- 8 edits in trunk/Source/WebInspectorUI
Web Inspector: Rendering Frames timeline should distinguish between layout and painting
https://bugs.webkit.org/show_bug.cgi?id=145856
Reviewed by Timothy Hatcher.
This patch formalizes the runloop task concept in the frontend, adds new Paint task type to the Rendering
Frames timeline, and reorders UI elements such as chart sections and frame "segments" to match the order in
which tasks are executed within the runloop.
We will need to make UI changes to the standard Timelines view in a follow up patch, since tree element icons
for Paint records now use a different color that those of other Layout records.
- UserInterface/Images/TimelineRecordPaint.svg:
Changed to use green color.
- UserInterface/Models/RenderingFrameTimelineRecord.js:
(WebInspector.RenderingFrameTimelineRecord):
(WebInspector.RenderingFrameTimelineRecord.displayNameForTaskType):
(WebInspector.RenderingFrameTimelineRecord.prototype.durationForTask.get validRecordForTaskType):
(WebInspector.RenderingFrameTimelineRecord.prototype.durationForTask.set return):
(WebInspector.RenderingFrameTimelineRecord.prototype.durationForTask):
(WebInspector.RenderingFrameTimelineRecord.prototype.get durationRemainder): Deleted.
(WebInspector.RenderingFrameTimelineRecord.prototype.durationForRecords.get var): Deleted.
Added TaskType enum to decouple runloop task types from timeline record types, and removed duration remainder
support now that "Other" has an associated task type.
- UserInterface/Views/RenderingFrameTimelineDataGridNode.js:
(WebInspector.RenderingFrameTimelineDataGridNode.prototype.get data):
(WebInspector.RenderingFrameTimelineDataGridNode.prototype.createCellContent):
- UserInterface/Views/RenderingFrameTimelineView.js:
(WebInspector.RenderingFrameTimelineView):
Added new grid column for Paint task, reordered columns to be consistent with the rest of the UI.
- UserInterface/Views/TimelineRecordFrame.css:
(.timeline-record-frame > .frame > .duration.rendering-frame-timeline-record-script):
(.timeline-record-frame > .frame > .duration.rendering-frame-timeline-record-layout):
(.timeline-record-frame > .frame > .duration.rendering-frame-timeline-record-paint):
(.timeline-record-frame > .frame > .duration): Deleted.
(.timeline-record-frame > .frame > .duration.timeline-record-type-network): Deleted.
(.timeline-record-frame > .frame > .duration.timeline-record-type-layout): Deleted.
(.timeline-record-frame > .frame > .duration.timeline-record-type-script): Deleted.
Updated styles for Render Frame tasks.
- UserInterface/Views/TimelineRecordFrame.js:
(WebInspector.TimelineRecordFrame.prototype._updateChildElements.createDurationElement):
Updated to use Render Frame task types. Frame segment insertion order is now consistent with the rest of the UI.
- UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart.chartData.Object.keys.map):
(WebInspector.TimelineSidebarPanel.set this):
(WebInspector.TimelineSidebarPanel._refreshFrameSelectionChart.get this):
(WebInspector.TimelineSidebarPanel): Deleted.
(WebInspector.TimelineSidebarPanel.prototype._refreshFrameSelectionChart.durationForRecordType): Deleted.
(WebInspector.TimelineSidebarPanel.prototype._refreshFrameSelectionChart): Deleted.
Updated to use Render Frame task types.
- 8:24 AM Changeset in webkit [185454] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Wrong overview graph shown after switching from Frames to Timelines
https://bugs.webkit.org/show_bug.cgi?id=145778
Reviewed by Timothy Hatcher.
TimelineSidebarPanel stores a reference to the selected timeline before switching to the Rendering Frames view,
which is used to restore the tree selection, overview graph, and content views when switching back to the
standard Timelines view. However if another recording is created before switching, the previously selected
timeline tracked by the sidebar cannot be restored, since it doesn't belong to the active recording.
This is addressed by storing the previously selected timeline type, rather than the timeline object itself.
The type is also updated whenever the selected timeline in the tree outline changes, ensuring that the correct
timeline will always be restored.
- UserInterface/Views/TimelineSidebarPanel.js:
(WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if.get if):
(WebInspector.TimelineSidebarPanel.get else): Deleted.
(WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject.get if): Deleted.
(WebInspector.TimelineSidebarPanel.prototype.treeElementForRepresentedObject): Deleted.
- 8:21 AM Changeset in webkit [185453] by
-
- 5 edits in trunk
[GTK] [Wayland] Should be possible to build with support for both X11 and Wayland.
https://bugs.webkit.org/show_bug.cgi?id=145701
Reviewed by Žan Doberšek.
.:
- Source/cmake/OptionsGTK.cmake: Remove conflicting options.
Source/WebCore:
No new tests, no behavior changes.
When building both targets, we have to include the wayland-egl
headers in order to build the Wayland target. This causes that
EGLNativePixmapType and EGLNativeWindowType get defined as
different types than when building only the X11 target.
By type casting them to the ones that are expected, we are able
to build both targets at the same time.
I have done tests (building each target alone as also both targets
at the same time), and everything seems to works as expected.
Once built for both targets, if you try to launch the MiniBrowser
from inside a Wayland compositor (Weston on top of X for example),
it will trigger the X11 target if the DISPLAY environment variable
is set and the environment variable GDK_BACKEND is not set to wayland,
otherwise it will trigger the Wayland target.
- platform/graphics/GLContext.cpp:
(WebCore::GLContext::createContextForWindow): Add type cast.
- platform/graphics/egl/GLContextEGL.cpp: Add missing include when
building both targets that is required for defining DefaultRootWindow().
(WebCore::GLContextEGL::createPixmapContext): Add type cast.
- 5:05 AM Changeset in webkit [185452] by
-
- 4 edits in trunk/Source/WebKit2
3% cold PLT regression from network cache on iOS
https://bugs.webkit.org/show_bug.cgi?id=145694
rdar://problem/21158245
Reviewed by Chris Dumez.
Cache does not help in cold page loads but it shouldn't' be hurting either. Write I/O needs to be toned down a bit.
- NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:
(WebKit::NetworkCache::IOChannel::IOChannel):
(WebKit::NetworkCache::IOChannel::open):
Dispatch channels inherit their I/O priority from the target queue. Use background queue for write I/O.
- NetworkProcess/cache/NetworkCacheStorage.cpp:
(WebKit::NetworkCache::Storage::Storage):
(WebKit::NetworkCache::Storage::dispatchPendingReadOperations):
(WebKit::NetworkCache::Storage::dispatchPendingWriteOperations):
Only write one file at a time instead of maximum of three.
(WebKit::NetworkCache::Storage::retrieve):
For consistency with store prepend new entries here too.
(WebKit::NetworkCache::Storage::store):
Delay start of the first write operation by 1s.
Prepend instead of append to the pending write deque so retrieveFromMemory lookup finds newest entries first in case of duplicates
(WebKit::NetworkCache::Storage::traverse):
- NetworkProcess/cache/NetworkCacheStorage.h:
- 2:30 AM Changeset in webkit [185451] by
-
- 2 edits in trunk/Source/WebCore
[EFL] Fix the debug build after r185417.
https://bugs.webkit.org/show_bug.cgi?id=145876
Patch by Hunseop Jeong <Hunseop Jeong> on 2015-06-11
Reviewed by Gyuyoung Kim.
- platform/graphics/efl/ImageBufferEfl.cpp: added the missing "MIMETypeRegistry.h".
- 12:00 AM Changeset in webkit [185450] by
-
- 2 edits in trunk/Source/WebCore
[iOS] Tahoma isn't installed on iOS, so there is no need to blacklist it
https://bugs.webkit.org/show_bug.cgi?id=145865
Reviewed by Dan Bernstein.
No new tests because I can't copy Tahoma into our open source repository.
- platform/graphics/cocoa/FontCocoa.mm:
(WebCore::fontFamilyShouldNotBeUsedForArabic):
