Timeline
Jul 20, 2015:
- 11:18 PM Changeset in webkit [187101] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r184376): [SOUP] Multiple assertions when downloading files
https://bugs.webkit.org/show_bug.cgi?id=147039
Reviewed by Darin Adler.
No new tests; this will be covered once we enable the network process for API tests.
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::releaseForDownload): Call RefPtrBase::relaxAdoptionRequirement so
that we don't assert when storing the non-adopted ResourceHandle in a RefPtr. The ref will
be dropped in ResourceHandle::cleanupSoupOperation, which as the comment says should always
run. HOPEFULLY.
(WebCore::ResourceHandle::continueWillSendRequest): Don't assert that client() is nonnull,
because the code clearly expects and handles the case where it is null.
(WebCore::ResourceHandle::continueDidReceiveResponse): Ditto; note that here client() will
always be null for a download.
- 11:06 PM Changeset in webkit [187100] by
-
- 20 edits3 adds in trunk
[GTK] Add API to be notified about editor state changes
https://bugs.webkit.org/show_bug.cgi?id=145875
Reviewed by Gustavo Noronha Silva.
Source/WebKit2:
Add WebKitEditorState object, that is created on demand by the
WebKitWebView and can be used to get the typing attributes of the
editor at the current position or selection.
- PlatformGTK.cmake:
- Shared/EditorState.cpp: Use part of the PostLayoutData struct
for the GTK port too.
(WebKit::EditorState::encode): Encode PostLayoutData for GTK and
remove our custom cursorRect.
(WebKit::EditorState::decode): Decode PostLayoutData for GTK and
remove our custom cursorRect.
(WebKit::EditorState::PostLayoutData::encode): Reorder it to
reduce the amonut of ifdefs.
(WebKit::EditorState::PostLayoutData::decode): Ditto.
- Shared/EditorState.h: Add AttributeStrikeThrough to
TypingAttributes enum.
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::selectionDidChange): Rename
updateTextInputState() to selectionDidChange() and also notify the
WebKitWebView.
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/API/gtk/WebKitEditorState.cpp: Added.
(webkitEditorStateGetProperty):
(webkit_editor_state_class_init):
(webkitEditorStateSetTypingAttributes):
(webkitEditorStateCreate):
(webkitEditorStateChanged):
(webkit_editor_state_get_typing_attributes):
- UIProcess/API/gtk/WebKitEditorState.h: Added.
- UIProcess/API/gtk/WebKitEditorStatePrivate.h: Added.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewSelectionDidChange): Notify the WebKitEditorState if
it has already been created.
(webkit_web_view_get_editor_state): Ensure a WebKitEditorState and
return it.
- UIProcess/API/gtk/WebKitWebView.h:
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseUpdateTextInputState): Get the caret cursor rect
from PostLayoutData.
- UIProcess/API/gtk/WebKitWebViewPrivate.h:
- UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Add new symbols.
- UIProcess/API/gtk/docs/webkit2gtk-4.0.types: Add webkit_editor_state_get_type.
- UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for WebKitEditorState.
- UIProcess/API/gtk/webkit2.h: Include WebKitEditorState.h.
- UIProcess/PageClient.h:
- UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::editorStateChanged): Call PageClientImpl::selectionDidChange().
- WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformEditorState): Add typing attributes to EditorState.
Tools:
Update the typing attributes toggle buttons state according to the
editor state in MiniBrowser, and add a test case to the
WebViewEditor unit tests.
- MiniBrowser/gtk/BrowserWindow.c:
(browserWindowEditingCommandToggleButtonSetActive):
(typingAttributesChanged):
(browserWindowSetupEditorToolbar):
(browserWindowConstructed):
(browser_window_init):
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
(testWebViewEditorEditorStateTypingAttributes):
(beforeAll):
- 10:56 PM Changeset in webkit [187099] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merge r187098. rdar://problem/21878275
- 10:39 PM Changeset in webkit [187098] by
-
- 2 edits in trunk/Source/WebCore
Follow-up to my earlier fix for r147085
https://bugs.webkit.org/show_bug.cgi?id=147085
Reviewed by Eric Carlson.
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::isPlayingAudioDidChange):
Null-check document() before dereferencing it in case the audio context's document is destroyed
by the time the code block is called on the main thread.
- 10:35 PM Changeset in webkit [187097] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187072. rdar://problem/21582858
- 10:35 PM Changeset in webkit [187096] by
-
- 5 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187050. rdar://problem/21582858
- 10:33 PM Changeset in webkit [187095] by
-
- 10 edits in trunk/Source/WebCore
Remove RenderTheme::shouldShowPlaceholderWhenFocused()
https://bugs.webkit.org/show_bug.cgi?id=147104
Reviewed by Martin Robinson.
GTK+ is the only port that returns false in
shouldShowPlaceholderWhenFocused(). That's inconsistent with all
other browsers that show the placeholder text even for focused
entries in all platforms. We should change the GTK+ port
behaviour, but that would leave all implementations of
shouldShowPlaceholderWhenFocused returning true, so let's just
remove it.
- html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
Do not consider whether the entry is focused or not.
- platform/efl/RenderThemeEfl.h:
- rendering/RenderTheme.h:
(WebCore::RenderTheme::shouldShowPlaceholderWhenFocused): Deleted.
- rendering/RenderThemeIOS.h:
- rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::shouldShowPlaceholderWhenFocused): Deleted.
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused): Deleted.
- rendering/RenderThemeSafari.h:
(WebCore::RenderThemeSafari::shouldShowPlaceholderWhenFocused): Deleted.
- rendering/RenderThemeWin.h:
- 10:27 PM Changeset in webkit [187094] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187054. rdar://problem/21823349
- 10:27 PM Changeset in webkit [187093] by
-
- 3 edits2 adds in branches/safari-601.1-branch
Merge r187053. rdar://problem/21778212
- 10:27 PM Changeset in webkit [187092] by
-
- 14 edits in branches/safari-601.1-branch/Source
Merge r187044. rdar://problem/21661808
- 10:27 PM Changeset in webkit [187091] by
-
- 4 edits in branches/safari-601.1-branch/Source
Merge r187039. rdar://problem/21474317
- 10:27 PM Changeset in webkit [187090] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit
Merge r187027. rdar://problem/21882777
- 10:27 PM Changeset in webkit [187089] by
-
- 4 edits in branches/safari-601.1-branch/Source/JavaScriptCore
Merge r186819. rdar://problem/21729083
- 10:16 PM Changeset in webkit [187088] by
-
- 2 edits in trunk/Source/WebCore
[CoordinatedGraphics] CoordinatedGraphicsLayer::setContentsToImage() should avoid scheduling unnecessary flushes
https://bugs.webkit.org/show_bug.cgi?id=147118
Reviewed by Martin Robinson.
Have CoordinatedGraphicsLayer::setContentsToImage() return early if the new
passed-in Image and the corresponding native image pointer are equal to the
currently set values.
This specifically avoids scheduling unnecessary flushes when setContentsToImage()
is repeatedly called with a null Image pointer, which in previous code would
unconditionally result in a scheduled flush even if there was no Image assigned
as the content of this layer before. Until now the layer flush scheduling was only
avoided if the two non-null native image pointers were equal.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setContentsToImage):
- 10:08 PM Changeset in webkit [187087] by
-
- 12 edits1 add in branches/safari-601.1-branch
Merge r186910. rdar://problem/21863296
- 10:08 PM Changeset in webkit [187086] by
-
- 4 edits in branches/safari-601.1-branch/Source/WebCore
Merge r186715. rdar://problem/21863296
- 9:38 PM Changeset in webkit [187085] by
-
- 20 edits1 copy4 adds in branches/safari-601.1-branch
Merge r186955. rdar://problem/14489674
- 9:38 PM Changeset in webkit [187084] by
-
- 7 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187047. rdar://problem/20860410
- 9:38 PM Changeset in webkit [187083] by
-
- 4 edits in branches/safari-601.1-branch/WebKitLibraries
Merge r187038. rdar://problem/20860410
- 9:38 PM Changeset in webkit [187082] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merge r187035. rdar://problem/21712311
- 9:38 PM Changeset in webkit [187081] by
-
- 9 edits in branches/safari-601.1-branch
Merge r187031. rdar://problem/21712311
- 9:37 PM Changeset in webkit [187080] by
-
- 2 edits in branches/safari-601.1-branch/Source/JavaScriptCore
Merge r187028. rdar://problem/21869970
- 9:37 PM Changeset in webkit [187079] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merge r187025. rdar://problem/21878275
- 9:37 PM Changeset in webkit [187078] by
-
- 3 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187023. rdar://problem/21799011
- 9:37 PM Changeset in webkit [187077] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r187001. rdar://problem/21769577
- 9:37 PM Changeset in webkit [187076] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merge r186991. rdar://problem/21643094
- 9:37 PM Changeset in webkit [187075] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merge r186990. rdar://problem/21643094
- 9:37 PM Changeset in webkit [187074] by
-
- 3 edits in branches/safari-601.1-branch/LayoutTests
Merge r186988. rdar://problem/21567820
- 9:37 PM Changeset in webkit [187073] by
-
- 12 edits17 adds in branches/safari-601.1-branch
Merge r186982. rdar://problem/21567820
- 9:37 PM Changeset in webkit [187072] by
-
- 2 edits in trunk/Source/WebKit2
Fix the iOS build.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
- 9:37 PM Changeset in webkit [187071] by
-
- 3 edits in branches/safari-601.1-branch/Source/WebCore
Merge r186979. rdar://problem/19192076
- 9:37 PM Changeset in webkit [187070] by
-
- 6 edits in branches/safari-601.1-branch/Source
Merge r186978. rdar://problem/21643094
- 9:37 PM Changeset in webkit [187069] by
-
- 9 edits in branches/safari-601.1-branch
Merge r186976. rdar://problem/21643094
- 9:37 PM Changeset in webkit [187068] by
-
- 3 edits2 adds in branches/safari-601.1-branch
Merge r186974. rdar://problem/21106945
- 9:37 PM Changeset in webkit [187067] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r186969. rdar://problem/21803781
- 9:37 PM Changeset in webkit [187066] by
-
- 3 edits2 adds in branches/safari-601.1-branch
Merge r186968. rdar://problem/21359811
- 9:37 PM Changeset in webkit [187065] by
-
- 10 edits1 add in branches/safari-601.1-branch
Merge r186964. rdar://problem/21803781
- 9:37 PM Changeset in webkit [187064] by
-
- 7 edits9 adds in branches/safari-601.1-branch
Merge r186957. rdar://problem/21867831
- 9:37 PM Changeset in webkit [187063] by
-
- 9 edits in branches/safari-601.1-branch/Source
Merge r186956. rdar://problem/21643094
- 9:36 PM Changeset in webkit [187062] by
-
- 10 edits in branches/safari-601.1-branch/Source
Merge r186916. rdar://problem/21643094
- 9:36 PM Changeset in webkit [187061] by
-
- 8 edits in branches/safari-601.1-branch
Merge r186912. rdar://problem/21866271
- 9:36 PM Changeset in webkit [187060] by
-
- 3 edits in branches/safari-601.1-branch/Source/WebCore
Merge r186890. rdar://problem/21643094
- 9:36 PM Changeset in webkit [187059] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merge r186875. rdar://problem/21643094
- 9:36 PM Changeset in webkit [187058] by
-
- 3 edits in branches/safari-601.1-branch/Source/WebCore
Merge r186867. rdar://problem/21643094
- 9:36 PM Changeset in webkit [187057] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merge r186863. rdar://problem/21715050
- 9:36 PM Changeset in webkit [187056] by
-
- 12 edits1 copy6 adds in branches/safari-601.1-branch
Merge r186858. rdar://problem/21643094
- 9:36 PM Changeset in webkit [187055] by
-
- 6 edits in branches/safari-601.1-branch/Source/WebCore
Merge r186854. rdar://problem/21840147
- 7:00 PM Changeset in webkit [187054] by
-
- 2 edits in trunk/Source/WebKit2
Facebook in tiled fullscreen is slow
https://bugs.webkit.org/show_bug.cgi?id=147134
rdar://problem/21823349
Reviewed by Tim Horton.
TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded() could cause a page to toggle
between two fixed layout sizes differing by a pixel, because of rounding. This would cause
lots of extra layouts and painting.
This happened because the the fixed layout size was computed using ceil(m_webPage.size().width() / viewScale)
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded):
- 6:08 PM Changeset in webkit [187053] by
-
- 3 edits2 adds in trunk
AX: Selection change as a result of focusing an element may cause Safari to crash
https://bugs.webkit.org/show_bug.cgi?id=147052
<rdar://problem/21778212>
Patch by Nan Wang <n_wang@apple.com> on 2015-07-20
Reviewed by Chris Fleizach.
Source/WebCore:
When focusing an element, it may trigger a deferred layout that invalidates the render
element, which will cause axObjectCache() to be a nullptr, and lead to a crash. Fix that
by using a RefPtr to hold the object and also caching the axObjectCache().
Test: platform/mac/accessibility/focus-crash.html
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setFocused):
(WebCore::AccessibilityRenderObject::setSelectedRows):
LayoutTests:
- platform/mac/accessibility/focus-crash-expected.txt: Added.
- platform/mac/accessibility/focus-crash.html: Added.
- 5:58 PM Changeset in webkit [187052] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: console.assert(false, "Message") message is not visible in console
https://bugs.webkit.org/show_bug.cgi?id=147130
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-20
Reviewed by Timothy Hatcher.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._appendMessageTextAndArguments):
We were forgetting to assign the result of args.concat back into args.
In re-addressing this, improve the formatting of output if there is
a string message or not as the second argument to console.assert(), as
that is the common usage.
- 5:27 PM Changeset in webkit [187051] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed build fix after r187049.
- contentextensions/ContentExtension.cpp:
(WebCore::ContentExtensions::ContentExtension::populateDomainCacheIfNeeded):
Can't shrinkToFit HashSets.
- 5:23 PM Changeset in webkit [187050] by
-
- 5 edits in trunk/Source/WebKit2
Fix crash due to RemoteLayerTreeDisplayRefreshMonitor outliving RemoteLayerTreeDrawingArea
https://bugs.webkit.org/show_bug.cgi?id=147124
<rdar://problem/21582858>
Reviewed by Simon Fraser.
Refactors RemoteLayerTreeDisplayRefreshMonitor to use a weak pointer rather than a reference
to its RemoteLayerTreeDrawingArea, since the drawing area may be deallocated before the monitor
in some rare cases. This rarely caused pages using requestAnimationFrame to crash on iOS. However,
this should not be the case: logically, a RemoteLayerTreeDrawingArea should always outlive its
refresh monitors. Refer to https://bugs.webkit.org/show_bug.cgi?id=147128 for more details.
- WebProcess/WebPage/Cocoa/RemoteLayerTreeDisplayRefreshMonitor.h:
- WebProcess/WebPage/Cocoa/RemoteLayerTreeDisplayRefreshMonitor.mm:
(WebKit::RemoteLayerTreeDisplayRefreshMonitor::RemoteLayerTreeDisplayRefreshMonitor):
(WebKit::RemoteLayerTreeDisplayRefreshMonitor::~RemoteLayerTreeDisplayRefreshMonitor): On destruction, checks
first to see whether or not the drawing area has been deallocated before telling it to update its monitors.
(WebKit::RemoteLayerTreeDisplayRefreshMonitor::requestRefreshCallback):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
(WebKit::RemoteLayerTreeDrawingArea::createWeakPtr): Creates and returns a new weak pointer to itself.
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
- 5:12 PM Changeset in webkit [187049] by
-
- 16 edits in trunk/Source
[Content Extensions] Cache actions with domains that match everything
https://bugs.webkit.org/show_bug.cgi?id=147050
Reviewed by Benjamin Poulain.
Source/WebCore:
If you have lots of rules with triggers like {"url-filter":".*","if-domain":*webkit.org?}
we will spend a lot of time adding unnecessary actions to HashSets when you are not on webkit.org.
Caching all the rules and only adding them to a collection once when the domain changes saves a lot of URL interpreting time.
We already had an optimization for the css-display-none actions with triggers that matched everything using a special bytecode operation.
This removes the need for a special bytecode operation by caching the triggers that match everything with and without domains,
then from those cached actions we compile a stylesheet, and create cached actions for every new domain we visit.
All functionality is covered by existing API tests.
- contentextensions/CompiledContentExtension.cpp:
(WebCore::ContentExtensions::CompiledContentExtension::~CompiledContentExtension):
(WebCore::ContentExtensions::CompiledContentExtension::globalDisplayNoneSelectors): Deleted.
- contentextensions/CompiledContentExtension.h:
- contentextensions/ContentExtension.cpp:
(WebCore::ContentExtensions::ContentExtension::ContentExtension):
(WebCore::ContentExtensions::ContentExtension::findFirstIgnorePreviousRules):
(WebCore::ContentExtensions::ContentExtension::globalDisplayNoneStyleSheet):
(WebCore::ContentExtensions::ContentExtension::compileGlobalDisplayNoneStyleSheet):
(WebCore::ContentExtensions::ContentExtension::populateDomainCacheIfNeeded):
(WebCore::ContentExtensions::ContentExtension::cachedDomainActions):
(WebCore::ContentExtensions::ContentExtension::universalActionsWithDomains):
- contentextensions/ContentExtension.h:
(WebCore::ContentExtensions::ContentExtension::compiledExtension):
(WebCore::ContentExtensions::ContentExtension::universalActionsWithoutDomains):
- contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::compileRuleList):
- contentextensions/ContentExtensionRule.cpp:
(WebCore::ContentExtensions::ContentExtensionRule::ContentExtensionRule):
(WebCore::ContentExtensions::Action::deserialize):
(WebCore::ContentExtensions::Action::deserializeType):
(WebCore::ContentExtensions::Action::serializedLength):
- contentextensions/ContentExtensionRule.h:
(WebCore::ContentExtensions::Action::operator==):
(WebCore::ContentExtensions::Action::setExtensionIdentifier):
(WebCore::ContentExtensions::Action::extensionIdentifier):
- contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad):
- contentextensions/DFABytecode.h:
(WebCore::ContentExtensions::instructionSizeWithArguments):
- contentextensions/DFABytecodeCompiler.cpp:
(WebCore::ContentExtensions::DFABytecodeCompiler::emitAppendAction):
- contentextensions/DFABytecodeInterpreter.cpp:
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretTestFlagsAndAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::actionsMatchingEverything):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpret):
(WebCore::ContentExtensions::DFABytecodeInterpreter::actionsForDefaultStylesheetFromDFARoot): Deleted.
- contentextensions/DFABytecodeInterpreter.h:
- loader/ResourceLoadInfo.h:
Source/WebKit2:
- UIProcess/API/APIUserContentExtensionStore.h:
- 4:48 PM Changeset in webkit [187048] by
-
- 1 edit in branches/safari-600.1.4.17-branch/Source/WebCore/platform/network/cf/CookieJarCFNet.cpp
Follow-up fix after r187042.
- 4:45 PM Changeset in webkit [187047] by
-
- 7 edits in trunk/Source/WebKit2
Support blocking a plug-in for non-security reasons
https://bugs.webkit.org/show_bug.cgi?id=145009
Patch by Gordon Sheridan <gordon_sheridan@apple.com> on 2015-07-20
Reviewed by Anders Carlsson.
- Shared/Plugins/PluginModuleInfo.h:
Replace PluginModuleBlocked with separate enum values for blocking for security and compatibility.
- UIProcess/API/C/WKAPICast.h:
(WebKit::toWKPluginLoadPolicy):
Modify to handle change to PluginModuleBlocked enum.
(WebKit::toPluginModuleLoadPolicy):
Ditto.
- UIProcess/API/C/WKPluginLoadPolicy.h:
Added enum value for blocking a plugin for compatibility reasons.
- UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::shouldBlockPlugin):
Check load policy for both reasons a plugin may be blocked.
(WebKit::WKPlugInModuleLoadPolicyToPluginModuleLoadPolicy):
Added function to convert between load policy enum types.
(WebKit::PluginInfoStore::defaultLoadPolicyForPlugin):
Modified to call WKLoadPolicyForPluginVersion() which can distinguish between blocked for security or compatibility.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin):
Updated to recognize both PluginModuleBlocked enum values that indicate a plugin is blocked.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Ditto.
(WebKit::WebPage::canPluginHandleResponse):
Ditto.
- 4:35 PM Changeset in webkit [187046] by
-
- 4 edits4 adds in trunk/LayoutTests
Web Inspector: start using Promises to handle asynchronous steps in protocol tests
https://bugs.webkit.org/show_bug.cgi?id=147096
Reviewed by Joseph Pecoraro.
Existing protocol tests use lots of reinvented wheels to run
multiple asynchronous tests. This patch begins consolidation of
these redundant wheels, using a tiny test framework based on
promises.
The first change is to introduce InspectorTest.awaitCommand,
which returns a promise that is fulfilled or rejected if the command
succeeds or fails. This is the building block for writing protocol
tests with promises.
The second change is the introduction of InspectorTest.AsyncTestSuite.
This properly chains together multiple asynchronous test methods
using the promise interface. A synchronous version is also added.
To demonstrate how async tests can be written using this new approach,
this patch converts existing protocol test. Test coverage for the
new frameworks also demonstrates their use.
- http/tests/inspector-protocol/resources/InspectorTest.js:
(InspectorTest.sendCommand):
(InspectorTest.awaitCommand):
(InspectorTest.sendMessage):
(InspectorFrontendAPI.dispatchMessageAsync):
(InspectorTest.AsyncTestSuite): Add tests for this micro framework.
(InspectorTest.AsyncTestSuite.prototype.get passCount):
(InspectorTest.AsyncTestSuite.prototype.get skipCount):
(InspectorTest.AsyncTestSuite.prototype.addTestCase):
(InspectorTest.AsyncTestSuite.prototype.runTestCasesAndFinish.finish):
(InspectorTest.AsyncTestSuite.prototype.runTestCasesAndFinish):
(InspectorTest.AsyncTestSuite.prototype.runTestCases):
(InspectorTest.SyncTestSuite): Add tests for this micro framework.
(InspectorTest.SyncTestSuite.prototype.get passCount):
(InspectorTest.SyncTestSuite.prototype.get skipCount):
(InspectorTest.SyncTestSuite.prototype.addTestCase):
(InspectorTest.SyncTestSuite.prototype.runTestCasesAndFinish):
(InspectorTest.SyncTestSuite.prototype.runTestCases):
(InspectorTest.log):
(InspectorTest.assert):
- inspector-protocol/runtime/getProperties-expected.txt:
- inspector-protocol/runtime/getProperties.html: Rewrite.
- 4:31 PM Changeset in webkit [187045] by
-
- 2 edits in trunk/Source/WebKit2
NSURLCache fallback does not work on iOS due to sandboxing
https://bugs.webkit.org/show_bug.cgi?id=146314
<rdar://problem/21433691>
Reviewed by Anders Carlsson.
This broke with earlier cache path computation changes.
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
NSURLCache path is relative to the container cache path so "." is sufficient.
This puts the cache files under
<container>/Library/Caches/com.apple.WebKit.Networking/
- 4:27 PM Changeset in webkit [187044] by
-
- 14 edits in trunk/Source
Adopt AVPlayerLayerView
https://bugs.webkit.org/show_bug.cgi?id=146862
Patch by Jeremy Jones <jeremyj@apple.com> on 2015-07-20
Source/WebCore:
Reviewed by Jer Noble.
The CALayerHost is replaced with WebLayerHostView to be compatible with UIView animations.
Some animation is improved in the conversion.
WebAVPlayerLayerView and WebAVPictureInPicturePlayerLayerView derive from AVKit and UIKit respectively.
Because these frameworks are loaded at runtime, these classes must be generate using objc/runtime.h to
register them from c functions at runtime. The most important part of these UIViews is that their
backing layer is a WebAVPlayerLayer.
WebCALayerHostWrapper and WebAVVideoLayer are combined into WebAVPlayerLayer to simplify the hierarchy.
WebAVPlayerLayer is a stand-in for an AVPlayerLayer.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenLayer): -removeFromSuperlayer is redundant.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenGravity): syncTextTrackBounds on change.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenFrame):
We never want animation here, since all animation will happen in UIViews.
This is just for going into the final size after a transform based animation.
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
(WebVideoFullscreenControllerContext::didSetupFullscreen): layer -> view
(WebVideoFullscreenControllerContext::didCleanupFullscreen): layer -> view
(WebVideoFullscreenControllerContext::setUpFullscreen): layer -> view
(WebVideoFullscreenControllerContext::setVideoLayerFrame): layer -> view
Use fence port to synchronize between the UIThread and the WebThread,
the same way WebKit2 uses a fence port to synchronize between processes.
(WebVideoFullscreenControllerContext::setVideoLayerGravity):
No longer necessary to cache videoGravity at this level.
- platform/ios/WebVideoFullscreenInterfaceAVKit.h:
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(-[WebAVPlayerLayer init]):
(-[WebAVPlayerLayer dealloc]):
(-[WebAVPlayerLayer playerController]):
(-[WebAVPlayerLayer setBounds:]):
(-[WebAVPlayerLayer resolveBounds]):
(-[WebAVPlayerLayer setVideoGravity:]):
(-[WebAVPlayerLayer videoGravity]):
(-[WebAVPlayerLayer videoRect]):
(+[WebAVPlayerLayer keyPathsForValuesAffectingVideoRect]):
Added class WebAVPlayerLayer, replacing WebAVVideoLayer and WebCALayerHostWrapper.
(WebAVPictureInPicturePlayerLayerView_layerClass):
(getWebAVPictureInPicturePlayerLayerViewClass):
Added runtime class WebAVPictureInPicturePlayerLayerView
(WebAVPlayerLayerView_layerClass):
(WebAVPlayerLayerView_playerController):
(WebAVPlayerLayerView_setPlayerController):
(WebAVPlayerLayerView_videoView):
(WebAVPlayerLayerView_setVideoView):
(WebAVPlayerLayerView_startRoutingVideoToPictureInPicturePlayerLayerView):
(WebAVPlayerLayerView_stopRoutingVideoToPictureInPicturePlayerLayerView):
(WebAVPlayerLayerView_pictureInPicturePlayerLayerView):
(getWebAVPlayerLayerViewClass):
Added runtime class WebAVPlayerLayerView
(WebVideoFullscreenInterfaceAVKit::setVideoDimensions):
Dimensions are also stored in WebAVPlayerLayer so it can make decisions about
animating the video layer.
(WebVideoFullscreenInterfaceAVKit::setExternalPlayback):
(WebVideoFullscreenInterfaceAVKit::enterFullscreen):
(WebVideoFullscreenInterfaceAVKit::didStopPictureInPicture):
(WebVideoFullscreenInterfaceAVKit::cleanupFullscreen):
Straightforward layer to view conversion.
(WebVideoFullscreenInterfaceAVKit::preparedToReturnToInline):
Set view frame using the view hierarchy instead of assuming it is directly in a window.
(WebVideoFullscreenInterfaceAVKit::exitFullscreen):
Set view frame using the view hierarchy instead of assuming it is directly in a window.
dispatch_async before calling didExitFullscreen() to allows CATransactions to complete.
(WebVideoFullscreenInterfaceAVKit::setupFullscreen):
Set view frame using the view hierarchy instead of assuming it is directly in a window.
dispatch_async before calling didSetupFullscreen() to allows CATransactions to complete.
(-[WebCALayerHostWrapper dealloc]): Deleted.
(-[WebCALayerHostWrapper setVideoSublayer:]): Deleted.
(-[WebCALayerHostWrapper videoSublayer]): Deleted.
(-[WebCALayerHostWrapper setBounds:]): Deleted.
(-[WebCALayerHostWrapper resolveBounds]): Deleted.
Class WebCALayerHostWrapper deleted. Functionality rolled into WebAVPlayerLayer.
(+[WebAVVideoLayer videoLayer]): Deleted.
(-[WebAVVideoLayer init]): Deleted.
(-[WebAVVideoLayer setPlayerViewController:]): Deleted.
(-[WebAVVideoLayer setVideoSublayer:]): Deleted.
(-[WebAVVideoLayer setBounds:]): Deleted.
(-[WebAVVideoLayer setVideoLayerGravity:]): Deleted.
(-[WebAVVideoLayer videoLayerGravity]): Deleted.
(-[WebAVVideoLayer enterPIPModeRedirectingVideoToLayer:]): Deleted.
(-[WebAVVideoLayer leavePIPMode]): Deleted.
Class WebAVVideoLayer deleted. Functionality rolled into WebAVPlayerLayer.
- platform/ios/WebVideoFullscreenModel.h:
- platform/ios/WebVideoFullscreenModelVideoElement.h:
- platform/ios/WebVideoFullscreenModelVideoElement.mm:
No need to store frame and gravity in the model. It is stored in the UI where it is used.
(WebVideoFullscreenModelVideoElement::videoLayerFrame): Deleted.
(WebVideoFullscreenModelVideoElement::videoLayerGravity): Deleted.
- platform/spi/cocoa/AVKitSPI.h: Add AVPlayerLayerView.
Source/WebKit2:
Reviewed by Simon Fraser.
The CALayerHost is replaced with WebLayerHostView to be compatible with UIView animations.
videoLayerFrame and videoLayerGravity no longer need to be stored because they are stored
where they are used in the interface. Some animation is improved in the conversion.
- UIProcess/ios/WebVideoFullscreenManagerProxy.h:
- UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(+[WebLayerHostView layerClass]): Add class WebLayerHostView.
(-[WebLayerHostView contextID]):
(-[WebLayerHostView setContextID:]):
(-[WebLayerHostView layerHost]):
(WebKit::WebVideoFullscreenManagerProxy::invalidate): layer -> view
(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID):
Apply the hostingDeviceScaleFactor transform to -sublayerTransform instead of to
-transform. This more directly inverts the tranform WebProcess and allows -transform
to be used for animation in the UIProcess. This is important because UIView's actions
animate -transform, but not -sublayerTrasform.
(WebKit::WebVideoFullscreenManagerProxy::didCleanupFullscreen): layer -> view
(WebKit::WebVideoFullscreenModelContext::setVideoLayerFrame): Deleted.
(WebKit::WebVideoFullscreenModelContext::videoLayerFrame): Deleted.
(WebKit::WebVideoFullscreenModelContext::setVideoLayerGravity): Deleted.
(WebKit::WebVideoFullscreenModelContext::videoLayerGravity): Deleted.
- WebProcess/ios/WebVideoFullscreenManager.mm:
(WebKit::WebVideoFullscreenManager::enterVideoFullscreenForVideoElement):
Set initial video layer frame to fix start point of animation.
(WebKit::WebVideoFullscreenManager::didSetupFullscreen):
dispatch_async allows the CATransaction to complete before continuing with the animation.
This prevents a flash during animation.
- 4:26 PM Changeset in webkit [187043] by
-
- 7 edits in trunk/Source/WebCore
Add PLATFORM #ifdefs for Mac SPI headers
https://bugs.webkit.org/show_bug.cgi?id=147129
Reviewed by Tim Horton.
- Configurations/WebCore.xcconfig:
Skip NPAPI headers on iOS.
- platform/mac/WebVideoFullscreenController.h:
- platform/spi/mac/DataDetectorsSPI.h:
- platform/spi/mac/NSEventSPI.h:
- platform/spi/mac/NSFontSPI.h:
- platform/spi/mac/NSMenuSPI.h:
- 4:24 PM WebInspectorCodingStyleGuide edited by
- tweaks to style guide (diff)
- 4:23 PM Changeset in webkit [187042] by
-
- 2 edits in branches/safari-600.1.4.17-branch/Source/WebCore
Merged r186895. rdar://problem/21714851
- 3:52 PM Changeset in webkit [187041] by
-
- 2 edits in branches/safari-600.1.4.17-branch/Source/WebKit2
Merged r186812. rdar://problem/21877914
- 3:36 PM Changeset in webkit [187040] by
-
- 1 edit in branches/safari-600.1.4.17-branch/Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
Build fix after r186983.
- 3:33 PM Changeset in webkit [187039] by
-
- 4 edits in trunk/Source
REGRESSION (r174287): Flash of black when opening a new web view or navigating to a new page
https://bugs.webkit.org/show_bug.cgi?id=147127
<rdar://problem/21474317>
Reviewed by Simon Fraser.
- rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::snapshotAtSize):
Avoid using an invalid documentBackgroundColor, fall back to baseBackgroundColor
like we did before r174287.
- 2:48 PM Changeset in webkit [187038] by
-
- 4 edits in trunk/WebKitLibraries
WKSI support for blocking a plug-in for non-security reasons.
https://bugs.webkit.org/show_bug.cgi?id=145009
Patch by Gordon Sheridan <gordon_sheridan@apple.com> on 2015-07-20
Reviewed by Anders Carlsson.
- WebKitSystemInterface.h:
- libWebKitSystemInterfaceMavericks.a:
- libWebKitSystemInterfaceYosemite.a:
- 2:43 PM Changeset in webkit [187037] by
-
- 2 edits in trunk/Source/WebCore
[Win] Unreviewed build fix after r187022.
- platform/win/WindowsTouch.h:
Undid changes from r187022
- 2:37 PM Changeset in webkit [187036] by
-
- 2 edits in trunk/Source/WebCore
Allow video to rotate when app doesnt allow rotation.
https://bugs.webkit.org/show_bug.cgi?id=147121
Patch by Jeremy Jones <jeremyj@apple.com> on 2015-07-20
Reviewed by Jer Noble.
Set an SPI bool on the fullscreen video root view controller to allow it to override app rotation restrictions.
This allows video to be played in landscape in portrait only apps.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::setupFullscreen):
- 2:28 PM Changeset in webkit [187035] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed assertion fix following r187031.
Just have GenericEventQueue::resume() return early if the queue isn't suspended.
Suspend/Resume calls are not always symmetrical in HTMLMediaElement.
- dom/GenericEventQueue.cpp:
(WebCore::GenericEventQueue::resume):
- 2:20 PM Changeset in webkit [187034] by
-
- 2 edits in trunk/Source/WebCore
Unexpected ABI diffference between armv7 and armv7s in WebCore::GraphicsLayerCA::~GraphicsLayerCA()
<http://webkit.org/b/147101>
Reviewed by Michael Saboff.
- platform/graphics/transforms/TransformationMatrix.h: Align
Matrix4 on both armv7 and armv7s.
- 2:16 PM Changeset in webkit [187033] by
-
- 12 edits in trunk/Source/JavaScriptCore
"let" scoping introduced incoherent story about symbol table cloning
https://bugs.webkit.org/show_bug.cgi?id=147046
Reviewed by Filip Pizlo.
This patch now establishes a clear set of rules for how SymbolTables
are owned by CodeBlock. Every SymbolTable that is used by a bytecode
instruction must live in CodeBlock's constant register pool. When CodeBlock
is being linked, it ensures that every SymbolTable in the constant pool is cloned.
This leaves no room for an un-cloned symbol table to be used by a bytecode instruction.
Some instructions may refer to SymbolTable's indirectly through a JSLexicalEnvironment.
This is fine, all JSLexicalEnvironment's are allocated with references to cloned symbol tables.
Another goal of this patch is to remove the notion that a SymbolTable is 1 to 1
with a CodeBlock. With lexical scoping, this view of the world is no longer
correct. This patch begins to remove this assumption by making CodeBlock's
symbolTable() getter method private. There is still one place where we need
to purge our codebase of this assumption and that is the type profiler. It
has not been updated for lexical scoping. After it is updated in
https://bugs.webkit.org/show_bug.cgi?id=145438
we will be able to remove CodeBlock's symbolTable() getter entirely.
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::nameForRegister):
- bytecode/CodeBlock.h:
(JSC::CodeBlock::addStringSwitchJumpTable):
(JSC::CodeBlock::stringSwitchJumpTable):
(JSC::CodeBlock::evalCodeCache):
(JSC::CodeBlock::symbolTable):
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::visitChildren):
(JSC::UnlinkedFunctionExecutable::link):
(JSC::UnlinkedFunctionExecutable::codeBlockFor):
- bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::addExceptionHandler):
(JSC::UnlinkedCodeBlock::exceptionHandler):
(JSC::UnlinkedCodeBlock::setSymbolTableConstantIndex):
(JSC::UnlinkedCodeBlock::symbolTableConstantIndex):
(JSC::UnlinkedCodeBlock::symbolTable): Deleted.
(JSC::UnlinkedCodeBlock::setSymbolTable): Deleted.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::pushLexicalScope):
(JSC::BytecodeGenerator::variableForLocalEntry):
(JSC::BytecodeGenerator::createVariable):
(JSC::BytecodeGenerator::resolveType):
(JSC::BytecodeGenerator::emitResolveScope):
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::thisRegister):
(JSC::BytecodeGenerator::instructions):
(JSC::BytecodeGenerator::symbolTable): Deleted.
- dfg/DFGGraph.h:
(JSC::DFG::Graph::baselineCodeBlockFor):
(JSC::DFG::Graph::isStrictModeFor):
(JSC::DFG::Graph::symbolTableFor): Deleted.
- jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::baselineCodeBlock):
(JSC::AssemblyHelpers::argumentsStart):
(JSC::AssemblyHelpers::symbolTableFor): Deleted.
- runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
- runtime/Executable.cpp:
(JSC::FunctionExecutable::visitChildren):
(JSC::FunctionExecutable::clearUnlinkedCodeForRecompilation):
(JSC::FunctionExecutable::symbolTable): Deleted.
- runtime/Executable.h:
- 1:45 PM Changeset in webkit [187032] by
-
- 4 edits in trunk/Source/WebCore
Add the necessary platform checks to iOS SPI headers
https://bugs.webkit.org/show_bug.cgi?id=147120
Reviewed by Tim Horton.
- platform/spi/ios/GraphicsServicesSPI.h:
- platform/spi/ios/MediaPlayerSPI.h:
- platform/spi/ios/MobileGestaltSPI.h:
- 1:16 PM Changeset in webkit [187031] by
-
- 9 edits in trunk
Improve behavior of media elements in page cache.
<https://webkit.org/b/147020>
<rdar://problem/21712311>
Reviewed by Chris Dumez.
Source/WebCore:
Make improvements for media elements when transitioning in/out of page cache:
- Events that were scheduled when going into cache will now be delivered when the page is restored from cache.
- Data buffering is turned off while in the cache. This reduces the memory cost of cached pages with media elements on iOS (where mediaserverd would keep upcoming video frames in memory for cached pages.)
Test: media/restore-from-page-cache.html (amended)
- dom/GenericEventQueue.h:
- dom/GenericEventQueue.cpp:
(WebCore::GenericEventQueue::enqueueEvent):
(WebCore::GenericEventQueue::suspend):
(WebCore::GenericEventQueue::resume):
Add a simple suspend/resume mechanism to GenericEventQueue that can
be used to support page caching.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::stop):
(WebCore::HTMLMediaElement::suspend):
(WebCore::HTMLMediaElement::resume):
(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer):
Adapt to event queueing changes and add calls to setShouldBufferData().
- html/HTMLSourceElement.h:
- html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::HTMLSourceElement):
(WebCore::HTMLSourceElement::create):
(WebCore::HTMLSourceElement::activeDOMObjectName):
(WebCore::HTMLSourceElement::canSuspendForPageCache):
(WebCore::HTMLSourceElement::suspend):
(WebCore::HTMLSourceElement::resume):
(WebCore::HTMLSourceElement::stop):
Turn HTMLSourceElement into an ActiveDOMObject so it gets all the
appropriate page cache notifications directly. Suspend the delayed
error event delivery timer when cached.
LayoutTests:
Add some coverage for suspend/resume of queued events on cached media elements.
- media/restore-from-page-cache-expected.txt:
- media/restore-from-page-cache.html:
- 1:06 PM Changeset in webkit [187030] by
-
- 5 edits in trunk/Source/WebKit2
[Seccomp] Should be easier to debug blocked syscalls
https://bugs.webkit.org/show_bug.cgi?id=142980
These should be printed even when not running in debug mode. There is no
value in hiding errors from release build users.
Reviewed by Žan Doberšek.
- Shared/linux/SeccompFilters/SeccompBroker.cpp:
(WebKit::SeccompBroker::runLoop): Don't close stderr et. al. in release builds.
- Shared/linux/SeccompFilters/Syscall.cpp:
(WebKit::write_uint): Added.
(WebKit::reportUnexpectedSyscall): Added.
(WebKit::Syscall::createFromContext): Call reportUnexpectedSyscall. Also, no need to crash
here in release builds.
- Shared/linux/SeccompFilters/SyscallPolicy.cpp:
(WebKit::SyscallPolicy::hasPermissionForPath): Print a warning when access is denied.
(WebKit::SyscallPolicy::permissionToString): Added.
- Shared/linux/SeccompFilters/SyscallPolicy.h: Add permissionToString.
- 12:50 PM Changeset in webkit [187029] by
-
- 2 edits in trunk/Source/WebKit2
Fix the !ENABLE(VIDEO) build after r186396
https://bugs.webkit.org/show_bug.cgi?id=147116
Reviewed by Brent Fulgham.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didClose):
- 12:04 PM Changeset in webkit [187028] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(186691): OSR entry is broken on loop headers that have no live variables
https://bugs.webkit.org/show_bug.cgi?id=147074
rdar://problem/21869970
Reviewed by Michael Saboff.
The OSR entry must-handle block/value widening introduced in r186691 would cause the
CFA to reexecute if it caused any live local variables to change value. But this fails
if the must-handle block has no live local variables, and the entry block otherwise
appears to be unreachable.
This fixes the bug by having the change detection include whether the block hadn't been
visited in addition to whether any local variable values got widened.
This is a ~4% speed-up on SunSpider in browser.
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::run):
- 11:51 AM Changeset in webkit [187027] by
-
- 2 edits in trunk/Source/WebKit
[Win] Certain Debug builds can take close to 3 hours to link
https://bugs.webkit.org/show_bug.cgi?id=147114
<rdar://problem/21882777>
Reviewed by Tim Horton.
Correct the 64-bit DebugSuffix link target to match the 32-bit version.
- WebKit.vcxproj/WebKit/WebKit.vcxproj: Turn off the REF and ICF
flags for the 64-bit DebugSuffix link target.
- 11:12 AM Changeset in webkit [187026] by
-
- 10 edits in trunk/Source
Rollout r187020 and r187021: breaks JSC API tests on debug builds.
https://bugs.webkit.org/show_bug.cgi?id=147110
Source/JavaScriptCore:
- heap/MachineStackMarker.cpp:
(JSC::MachineThreads::addCurrentThread):
- runtime/JSLock.cpp:
(JSC::JSLockHolder::~JSLockHolder):
(JSC::JSLock::JSLock):
(JSC::JSLock::willDestroyVM):
(JSC::JSLock::setExclusiveThread):
(JSC::JSLock::lock):
(JSC::JSLock::unlock):
(JSC::JSLock::currentThreadIsHoldingLock):
(JSC::JSLock::dropAllLocks):
- runtime/JSLock.h:
(JSC::JSLock::vm):
(JSC::JSLock::hasExclusiveThread):
(JSC::JSLock::exclusiveThread):
- runtime/VM.h:
(JSC::VM::hasExclusiveThread):
(JSC::VM::exclusiveThread):
(JSC::VM::setExclusiveThread):
Source/WebCore:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonVM):
Source/WTF:
- wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
- wtf/WTFThreadData.h:
(WTF::WTFThreadData::stack):
- 11:05 AM Changeset in webkit [187025] by
-
- 2 edits in trunk/Source/WebCore
Fix deadlock between -[AVPlayerItem currentTime] and -[AVPlayer isExternalPlaybackActive]
https://bugs.webkit.org/show_bug.cgi?id=147085
<rdar://problem/21878275>
Reviewed by Jer Noble.
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::isPlayingAudioDidChange):
Call Document::updateIsPlayingMedia() on the main thread, since we could be on the audio I/O
thread here and the Document::updateIsPlayingMedia() call could block, causing a deadlock.
- 10:42 AM Changeset in webkit [187024] by
-
- 9 edits2 copies3 adds in trunk
[GTK] Add selection-changed signal to the WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=137116
Patch by Tomas Popela <tpopela@redhat.com> on 2015-07-20
Reviewed by Carlos Garcia Campos.
Source/WebKit2:
Add a new object WebKitWebEditor where the editing capabilities of a
WebPage will be grouped and exposed. Add the selection-changed signal
there (we used the same name as in WK1 API).
- PlatformGTK.cmake:
- UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
- WebProcess/InjectedBundle/API/gtk/WebKitWebEditor.cpp: Added.
(didChangeSelection):
(webkitWebEditorCreate):
(webkit_web_editor_get_page):
- WebProcess/InjectedBundle/API/gtk/WebKitWebEditor.h: Added.
- WebProcess/InjectedBundle/API/gtk/WebKitWebEditorPrivate.h: Added.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkitWebPageGetPage):
(webkit_web_page_get_editor):
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h:
- WebProcess/InjectedBundle/API/gtk/WebKitWebPagePrivate.h:
- WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h:
Tools:
Add a new WebProcess test TestEditor that is testing the WebKitWebEditor
(namely the selection-changed signal).
- TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
- TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Added.
(WebKitWebEditorTest::create):
(WebKitWebEditorTest::selectionChangedCallback):
(WebKitWebEditorTest::testSelectionSelectAll):
(WebKitWebEditorTest::testSelectionCollapse):
(WebKitWebEditorTest::testSelectionModifyMove):
(WebKitWebEditorTest::testSelectionModifyExtend):
(WebKitWebEditorTest::testSelectionUnselect):
(registerTests):
- TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Added.
(testWebKitWebEditorSelectionChanged):
(beforeAll):
(afterAll):
- 10:08 AM Changeset in webkit [187023] by
-
- 3 edits in trunk/Source/WebKit2
WebsiteDataStore operations need to grab background assertions
https://bugs.webkit.org/show_bug.cgi?id=147015
rdar://problem/21799011
Reviewed by Sam Weinig.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::fetchWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteDataForOrigins):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::fetchWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteDataForOrigins):
- 8:55 AM Changeset in webkit [187022] by
-
- 19 edits2 adds in trunk
Resurrect CMake build on Windows.
https://bugs.webkit.org/show_bug.cgi?id=147083
Reviewed by Gyuyoung Kim.
.:
- Source/cmake/OptionsCommon.cmake:
- Source/cmake/OptionsWindows.cmake:
Change features to get it to compile. Still not a complete feature set.
Source/WebCore:
- CMakeLists.txt:
- PlatformWin.cmake:
- dom/Document.cpp:
(WebCore::Document::~Document):
- dom/Range.cpp:
- dom/Text.cpp:
- editing/CompositeEditCommand.cpp:
- platform/graphics/texmap/BitmapTexturePool.cpp:
(WebCore::BitmapTexturePool::createTexture):
- platform/win/WindowsTouch.h:
- rendering/RenderThemeWin.h:
Fixed some including and compiling quirks needed for different configurations.
Source/WebKit:
- PlatformWin.cmake: Added.
Based on original work by Patrick Gansterer and Mark Salisbury
in https://bugs.webkit.org/show_bug.cgi?id=72816
Source/WTF:
- wtf/PlatformWin.cmake:
Tools:
- DumpRenderTree/CMakeLists.txt:
- DumpRenderTree/PlatformWin.cmake: Added.
- WinLauncher/CMakeLists.txt:
- 5:04 AM Changeset in webkit [187021] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed debug build fix after r187020.
- heap/MachineStackMarker.cpp:
(JSC::MachineThreads::addCurrentThread):
VM::exclusiveThread() has changed return type to ThreadIdentifier.
- 2:14 AM Changeset in webkit [187020] by
-
- 9 edits in trunk/Source
JavaScriptCore performance is very bad on Windows
https://bugs.webkit.org/show_bug.cgi?id=146448
Reviewed by Mark Lam.
Source/JavaScriptCore:
Profiling shows that std::this_thread::get_id() is slow on Windows.
Use WTF::currentThread() instead, which calls GetCurrentThreadId().
This is faster on Windows. The issue has been reported to Microsoft,
https://connect.microsoft.com/VisualStudio/feedback/details/1558211.
- runtime/JSLock.cpp:
(JSC::JSLockHolder::~JSLockHolder):
(JSC::JSLock::JSLock):
(JSC::JSLock::willDestroyVM):
(JSC::JSLock::setExclusiveThread):
(JSC::JSLock::lock):
(JSC::JSLock::unlock):
(JSC::JSLock::currentThreadIsHoldingLock):
- runtime/JSLock.h:
(JSC::JSLock::vm):
(JSC::JSLock::hasExclusiveThread):
(JSC::JSLock::exclusiveThread):
- runtime/VM.h:
(JSC::VM::hasExclusiveThread):
(JSC::VM::exclusiveThread):
(JSC::VM::setExclusiveThread):
Source/WebCore:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonVM): Compile fix.
Source/WTF:
Updating the stack bounds is time consuming.
Only update the stack bounds when a new fiber is running.
- wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
- wtf/WTFThreadData.h:
(WTF::WTFThreadData::stack):
- 12:19 AM Changeset in webkit [187019] by
-
- 2 edits in trunk/Source/WTF
Use isnan from std namespace in Stopwatch.h.
https://bugs.webkit.org/show_bug.cgi?id=146911
Reviewed by Žan Doberšek.
- wtf/Stopwatch.h:
(WTF::Stopwatch::isActive):
(WTF::Stopwatch::start):
(WTF::Stopwatch::stop):
(WTF::Stopwatch::elapsedTime):
Jul 19, 2015:
- 11:38 PM Changeset in webkit [187018] by
-
- 8 edits1 add2 deletes in trunk
Make shrink-wrapping test a ref-test instead of pixel-test
https://bugs.webkit.org/show_bug.cgi?id=147081
Reviewed by Sam Weinig.
Source/WebCore:
Nobody runs pixel tests.
- svg/SVGPathUtilities.cpp:
(WebCore::pathIteratorForBuildingString):
(WebCore::buildStringFromPath):
- svg/SVGPathUtilities.h:
Add a helper that turns a Path into a SVG path string.
- testing/Internals.cpp:
(WebCore::Internals::pathStringWithShrinkWrappedRects):
- testing/Internals.h:
- testing/Internals.idl:
Have the internals shrink-wrap method return an SVG path instead of a DOMPath.
LayoutTests:
- fast/shrink-wrap/rect-shrink-wrap-expected.html: Added.
- fast/shrink-wrap/rect-shrink-wrap-expected.png: Removed.
- fast/shrink-wrap/rect-shrink-wrap-expected.txt: Removed.
- fast/shrink-wrap/rect-shrink-wrap.html:
SVG all the things.
- 4:37 PM Changeset in webkit [187017] by
-
- 2 edits1 add in trunk/Source/JavaScriptCore
In strict mode,
Object.keys(arguments)includes "length"
https://bugs.webkit.org/show_bug.cgi?id=147071
Reviewed by Darin Adler.
ClonedAguments didn't set the "length" with DontEnum.
- runtime/ClonedArguments.cpp:
(JSC::ClonedArguments::createWithInlineFrame):
(JSC::ClonedArguments::createByCopyingFrom):
- tests/stress/arguments-length-always-dont-enum.js: Added.
(shouldBe):
(argsSloppy):
(argsStrict):
- 4:10 PM Changeset in webkit [187016] by
-
- 5 edits in trunk
new Date(NaN).toJSON() must return null instead of throwing a TypeError
https://bugs.webkit.org/show_bug.cgi?id=141115
Patch by Jordan Harband <ljharb@gmail.com> on 2015-07-19
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
- runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToJSON):
LayoutTests:
- js/dom/JSON-stringify-expected.txt:
- js/resources/JSON-stringify.js:
- 3:27 PM Changeset in webkit [187015] by
-
- 2 edits in trunk/Tools
[GTK] Enable seccomp filter API tests
https://bugs.webkit.org/show_bug.cgi?id=140071
Reviewed by Žan Doberšek.
These tests will now be run by the run-gtk-tests script.
- TestWebKitAPI/PlatformGTK.cmake:
- 12:31 PM Changeset in webkit [187014] by
-
- 3 edits3 adds in trunk
Parser::parseFunctionInfo hits RELEASE_ASSERT for Arrow Functions
https://bugs.webkit.org/show_bug.cgi?id=147090
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
ArrowFunction's have there ParserFunctionInfo "name" field to
be a non-null pointer. This is obviously allowed and valid except we
had a RELEASE_ASSERT that claimed otherwise. This is a mistake.
Note: ArrowFunction's will never actually have a function name;
there ParserFunctionInfo "name" field will be the empty string.
This is not be mistaken with the name field being a null pointer.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseFunctionInfo):
LayoutTests:
- js/arrowfunction-strict-mode-expected.txt: Added.
- js/arrowfunction-strict-mode.html: Added.
- js/script-tests/arrowfunction-strict-mode.js: Added.
(foo):
- 12:14 PM Changeset in webkit [187013] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed, placate -Wmismatched-tags after r187011
It's basically bug #146990 again. Oops.
- WebProcess/gtk/SeccompFiltersWebProcessGtk.h:
- 9:57 AM Changeset in webkit [187012] by
-
- 77 edits6 adds in trunk
[ES6] Add support for block scope const
https://bugs.webkit.org/show_bug.cgi?id=31813
Reviewed by Filip Pizlo.
Source/JavaScriptCore:
'const' is now implemented in an ES6 spec compliant manner.
'const' variables are always block scoped and always live
either on the stack or in a JSLexicalEnvironment. 'const'
variables never live on the global object.
Inside the BytecodeGenerator, when assigning to a stack
'const' variable or a LocalClosureVar 'const' variable,
we will emit code that just throws a type error.
When assigning to a ClosureVar const variable, CodeBlock linking
will ensure that we perform a dynamic lookup of that variable so
that put_to_scope's slow path throws a type error.
The old 'const' implementation has been removed in this patch.
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::pushLexicalScope):
(JSC::BytecodeGenerator::prepareLexicalScopeForNextForLoopIteration):
(JSC::BytecodeGenerator::variable):
(JSC::BytecodeGenerator::variableForLocalEntry):
(JSC::BytecodeGenerator::createVariable):
(JSC::BytecodeGenerator::emitResolveScope):
(JSC::BytecodeGenerator::emitInstanceOf):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::isArgumentNumber):
(JSC::BytecodeGenerator::emitReadOnlyExceptionIfNeeded):
(JSC::BytecodeGenerator::emitEnumeration):
(JSC::BytecodeGenerator::variablePerSymbolTable): Deleted.
(JSC::BytecodeGenerator::emitInitGlobalConst): Deleted.
- bytecompiler/BytecodeGenerator.h:
(JSC::Variable::Variable):
(JSC::Variable::isReadOnly):
(JSC::Variable::isSpecial):
(JSC::Variable::isConst):
(JSC::BytecodeGenerator::thisRegister):
(JSC::BytecodeGenerator::emitTypeOf):
(JSC::BytecodeGenerator::emitIn):
- bytecompiler/NodesCodegen.cpp:
(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::CommaNode::emitBytecode):
(JSC::BindingNode::bindValue):
(JSC::ConstDeclNode::emitCodeSingle): Deleted.
(JSC::ConstDeclNode::emitBytecode): Deleted.
(JSC::ConstStatementNode::emitBytecode): Deleted.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_to_arguments):
(JSC::JIT::emit_op_init_global_const): Deleted.
- jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_to_arguments):
(JSC::JIT::emit_op_init_global_const): Deleted.
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createDeclarationStatement):
(JSC::ASTBuilder::createEmptyVarExpression):
(JSC::ASTBuilder::createDebugger):
(JSC::ASTBuilder::appendStatement):
(JSC::ASTBuilder::createVarStatement): Deleted.
(JSC::ASTBuilder::createLetStatement): Deleted.
(JSC::ASTBuilder::createConstStatement): Deleted.
(JSC::ASTBuilder::appendConstDecl): Deleted.
- parser/NodeConstructors.h:
(JSC::CommaNode::CommaNode):
(JSC::SourceElements::SourceElements):
(JSC::SwitchNode::SwitchNode):
(JSC::BlockNode::BlockNode):
(JSC::ConstStatementNode::ConstStatementNode): Deleted.
(JSC::ConstDeclNode::ConstDeclNode): Deleted.
- parser/Nodes.h:
(JSC::ConstDeclNode::hasInitializer): Deleted.
(JSC::ConstDeclNode::ident): Deleted.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::parseStatementListItem):
(JSC::Parser<LexerType>::parseVariableDeclaration):
(JSC::Parser<LexerType>::parseWhileStatement):
(JSC::Parser<LexerType>::parseVariableDeclarationList):
(JSC::Parser<LexerType>::createBindingPattern):
(JSC::Parser<LexerType>::parseDestructuringPattern):
(JSC::Parser<LexerType>::parseDefaultValueForDestructuringPattern):
(JSC::Parser<LexerType>::parseForStatement):
(JSC::Parser<LexerType>::parseTryStatement):
(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseConstDeclaration): Deleted.
(JSC::Parser<LexerType>::parseConstDeclarationList): Deleted.
- parser/Parser.h:
(JSC::isEvalNode):
(JSC::isEvalNode<EvalNode>):
(JSC::isArguments):
(JSC::isEval):
(JSC::isEvalOrArgumentsIdentifier):
(JSC::Scope::Scope):
(JSC::Scope::declareCallee):
(JSC::Scope::declareVariable):
(JSC::Scope::declareLexicalVariable):
(JSC::Scope::hasDeclaredVariable):
(JSC::Scope::allowsVarDeclarations):
(JSC::Scope::allowsLexicalDeclarations):
(JSC::Scope::declareParameter):
(JSC::Scope::declareBoundParameter):
(JSC::Parser::destructuringKindFromDeclarationType):
(JSC::Parser::assignmentContextFromDeclarationType):
(JSC::Parser::isEvalOrArguments):
(JSC::Parser::currentScope):
(JSC::Parser::popScope):
(JSC::Parser::declareVariable):
(JSC::Parser::hasDeclaredVariable):
(JSC::Parser::setStrictMode):
(JSC::Parser::strictMode):
(JSC::Parser::isValidStrictMode):
(JSC::Parser::declareParameter):
(JSC::Parser::declareBoundParameter):
(JSC::Parser::breakIsValid):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::createForOfLoop):
(JSC::SyntaxChecker::createEmptyStatement):
(JSC::SyntaxChecker::createDeclarationStatement):
(JSC::SyntaxChecker::createReturnStatement):
(JSC::SyntaxChecker::createBreakStatement):
(JSC::SyntaxChecker::createVarStatement): Deleted.
(JSC::SyntaxChecker::createLetStatement): Deleted.
- parser/VariableEnvironment.h:
(JSC::VariableEnvironmentEntry::isCaptured):
(JSC::VariableEnvironmentEntry::isConst):
(JSC::VariableEnvironmentEntry::isVar):
(JSC::VariableEnvironmentEntry::isLet):
(JSC::VariableEnvironmentEntry::setIsCaptured):
(JSC::VariableEnvironmentEntry::setIsConst):
(JSC::VariableEnvironmentEntry::setIsVar):
(JSC::VariableEnvironmentEntry::setIsLet):
(JSC::VariableEnvironmentEntry::isConstant): Deleted.
(JSC::VariableEnvironmentEntry::setIsConstant): Deleted.
- runtime/Executable.cpp:
(JSC::ProgramExecutable::initializeGlobalProperties):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::defineOwnProperty):
(JSC::JSGlobalObject::addGlobalVar):
(JSC::JSGlobalObject::addFunction):
(JSC::lastInPrototypeChain):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::finishCreation):
(JSC::JSGlobalObject::addVar):
(JSC::JSGlobalObject::addConst): Deleted.
- runtime/JSLexicalEnvironment.cpp:
(JSC::JSLexicalEnvironment::symbolTablePut):
- tests/stress/const-and-with-statement.js: Added.
(truth):
(assert):
(shouldThrowInvalidConstAssignment):
(.):
- tests/stress/const-exception-handling.js: Added.
(truth):
(assert):
(.):
- tests/stress/const-loop-semantics.js: Added.
(truth):
(assert):
(shouldThrowInvalidConstAssignment):
(.):
- tests/stress/const-not-strict-mode.js: Added.
(truth):
(assert):
(shouldThrowTDZ):
(.):
- tests/stress/const-semantics.js: Added.
(truth):
(assert):
(shouldThrowInvalidConstAssignment):
(.):
- tests/stress/const-tdz.js: Added.
(truth):
(assert):
(shouldThrowTDZ):
(.):
Source/WebInspectorUI:
"const" variables do not live on the global object and are only
accessible within the "Program" they're defined in. Therefore,
the WebInspector global must be defined as "var" and not "const".
- UserInterface/Base/WebInspector.js:
LayoutTests:
"const" variables do not live on the global object. They
are only available in the "Program" (read: JavaScript file or
script tag) that they're defined in. Tests have been updated
accordingly to switch the "const" variables assumed to be globals
into "var"s. "var" declared variables in the top level scope
of a program do live on the global object.
- fast/canvas/webgl/compressed-tex-image.html:
- fast/dom/event-handler-attributes.html:
- fast/forms/listbox-visible-size.html:
- js/arguments-expected.txt:
- js/arrowfunction-syntax-errors-expected.txt:
- js/const-expected.txt:
- js/const-without-initializer-expected.txt:
- js/constant-count-expected.txt:
- js/dom/inc-const-valueOf-expected.txt:
- js/dom/script-tests/inc-const-valueOf.js:
(testPreIncConstVarWithAssign):
- js/function-toString-parentheses-expected.txt:
- js/kde/const-expected.txt:
- js/kde/resources/const.js:
- js/parser-syntax-check-expected.txt:
- js/script-tests/arguments.js:
(argumentsVarUndefined):
(argumentsConst):
(argumentCalleeInException):
(argumentsConstUndefined): Deleted.
- js/script-tests/class-syntax-declaration.js:
(A):
- js/script-tests/class-syntax-expression.js:
- js/script-tests/const-without-initializer.js:
- js/script-tests/const.js:
(shouldThrowInvalidConstAssignment):
(assert):
(f):
(tryCatch1):
(tryCatch2):
(with1):
(with2):
(.):
- js/script-tests/constant-count.js:
(f):
- js/script-tests/function-dot-arguments.js:
(assignConstInitTest2.g):
(assignConstInitTest2):
- js/script-tests/function-toString-parentheses.js:
- js/script-tests/parser-syntax-check.js:
- sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.6-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T7-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T8-expected.txt:
- sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T9-expected.txt:
- sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A13_T3-expected.txt:
- sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A14_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T1-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T2-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T3-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T4-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T6-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T7-expected.txt:
- sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T8-expected.txt:
- transforms/3d/hit-testing/composited-hit-test.html:
- transforms/3d/hit-testing/coplanar-with-camera.html:
- transforms/3d/hit-testing/hover-rotated-negative-z.html:
- transforms/3d/hit-testing/hover-rotated-with-children-negative-z.html:
- transforms/3d/hit-testing/negative-zoffset-hit-test.html:
- transforms/3d/hit-testing/overlapping-layers-hit-test.html:
- transforms/3d/hit-testing/perspective-clipped.html:
- transforms/3d/hit-testing/rotated-hit-test-with-child.html:
- transforms/3d/hit-testing/rotated-hit-test.html:
- transforms/3d/hit-testing/rotated-hit-test2.html:
- transitions/resources/transition-test-helpers.js:
(roundNumber):
- 9:32 AM Changeset in webkit [187011] by
-
- 7 edits2 adds in trunk
[GTK] Add seccomp filters support
https://bugs.webkit.org/show_bug.cgi?id=110014
Reviewed by Žan Doberšek.
.:
Find needed compiler and linker flags for libseccomp.
- Source/cmake/OptionsGTK.cmake:
Source/WebKit2:
Allow building with ENABLE_SECCOMP_FILTERS=ON. Based on work by Thiago Marcos P. Santos.
- PlatformGTK.cmake: Support ENABLE_SECCOMP_FILTERS build option.
- WebProcess/gtk/SeccompFiltersWebProcessGtk.cpp: Added.
(WebKit::SeccompFiltersWebProcessGtk::SeccompFiltersWebProcessGtk):
(WebKit::SeccompFiltersWebProcessGtk::platformInitialize):
- WebProcess/gtk/SeccompFiltersWebProcessGtk.h: Added.
- WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformInitializeWebProcess): Initialize default
GTK+ web process seccomp filters.
Tools:
Add libseccomp to jhbuild modulesets.
- gtk/jhbuild.modules:
- 6:16 AM Changeset in webkit [187010] by
-
- 5 edits in trunk/Source/WebKit/win
REGRESSION (r187002): Broke the Windows build: Reduce PassRefPtr in WebKit2 - 3
<https://bugs.webkit.org/show_bug.cgi?id=146995>
Attempt to fix the Windows build.
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createDocumentLoader):
(WebFrameLoaderClient::createFrame):
(WebFrameLoaderClient::createPlugin):
- WebCoreSupport/WebFrameLoaderClient.h:
- WebDocumentLoader.cpp:
(WebDocumentLoader::create):
- WebDocumentLoader.h:
- 5:35 AM Changeset in webkit [187009] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r187008): CGPathCreateMutableCopyByTransformingPath() is not available on Windows
<https://bugs.webkit.org/show_bug.cgi?id=147077>
- platform/graphics/cg/PathCG.cpp:
(WebCore::Path::transform): Restore less efficient code path
for Windows.
Jul 18, 2015:
- 9:38 PM Changeset in webkit [187008] by
-
- 2 edits in trunk/Source/WebCore
Simplify Path(CG)::transform/translate
https://bugs.webkit.org/show_bug.cgi?id=147077
Reviewed by Simon Fraser.
No new tests; no behavior change.
- platform/graphics/cg/PathCG.cpp:
(WebCore::Path::translate):
(WebCore::Path::transform):
Use CGPathCreateMutableCopyByTransformingPath to do the copy and transform
in a single call instead of two.
Make use of transform() to implement translate() instead of duplicating the code.
Move the two functions near each other.
(WebCore::Path::boundingRect):
Remove irrelevant reference to Snow Leopard.
- 8:37 PM Changeset in webkit [187007] by
-
- 3 edits in trunk/Tools
MiniBrowser window title is just "Window" when page has no <title>
https://bugs.webkit.org/show_bug.cgi?id=147076
Reviewed by Tim Horton.
Make MiniBrowser windows show the filename from the URL if we never get a title changed
notification.
- MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController updateTitle:]):
(-[WK1BrowserWindowController webView:didCommitLoadForFrame:]):
(-[WK1BrowserWindowController webView:didReceiveTitle:forFrame:]):
- MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController updateTitle:]):
(-[WK2BrowserWindowController observeValueForKeyPath:ofObject:change:context:]):
(-[WK2BrowserWindowController webView:didCommitNavigation:]):
- 7:14 PM Changeset in webkit [187006] by
-
- 5 edits2 adds in trunk
Media Session: Add support for 'Content' interruption types
https://bugs.webkit.org/show_bug.cgi?id=147042
Reviewed by Eric Carlson.
Tests: Added media/session/content-interruptions
- Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::handleIndefinitePauseInterruption): Indefinitely pause the session by pausing media
elements and removing them from the set of active participating elements.
- Modules/mediasession/MediaSession.h:
- Modules/mediasession/MediaSessionManager.cpp:
(WebCore::MediaSessionManager::didReceiveStartOfInterruptionNotification): Implemented support for 'Content'
interruption types as described in 4.5.2.
- 6:36 PM Changeset in webkit [187005] by
-
- 2 edits in trunk/Source/WebCore
Media Session: add support for telephony interruptions
https://bugs.webkit.org/show_bug.cgi?id=147016
Reviewed by Eric Carlson.
- platform/audio/mac/MediaSessionInterruptionProviderMac.mm:
(WebCore::callDidBeginRinging): Forward this event to media sessions as a 'Transient' interruption.
(WebCore::MediaSessionInterruptionProviderMac::beginListeningForInterruptions):
(WebCore::MediaSessionInterruptionProviderMac::stopListeningForInterruptions):
- 6:30 PM Changeset in webkit [187004] by
-
- 7 edits in trunk/Source/WebCore
Media Session: add infrastructure for testing interruptions
https://bugs.webkit.org/show_bug.cgi?id=147060
Reviewed by Eric Carlson.
- Modules/mediasession/MediaSession.h: Export methods to be used with tests.
- Modules/mediasession/MediaSessionManager.h: Ditto.
- bindings/scripts/CodeGeneratorJS.pm: JSMediaSession needs to be marked with WEBCORE_EXPORT so it works with JSInternals.
- testing/Internals.cpp:
(WebCore::Internals::sendMediaSessionStartOfInterruptionNotification): Let tests send interruptions to MediaSessionManager.
(WebCore::Internals::sendMediaSessionEndOfInterruptionNotification): Ditto.
(WebCore::Internals::mediaSessionCurrentState): Expose the current state of media sessions to tests.
- testing/Internals.h:
- testing/Internals.idl: Add interfaces for sending interruptions from JS tests.
- 5:36 PM Changeset in webkit [187003] by
-
- 4 edits1 add in trunk/Source/JavaScriptCore
lexical scoping is broken with respect to "break" and "continue"
https://bugs.webkit.org/show_bug.cgi?id=147063
Reviewed by Filip Pizlo.
Bug #142944 which introduced "let" and lexical scoping
didn't properly hook into the bytecode generator's machinery
for calculating scope depth deltas for "break" and "continue". This
resulted in the bytecode generator popping an incorrect number
of scopes when lexical scopes were involved.
This patch fixes this problem and generalizes this machinery a bit.
This patch also renames old functions in a sensible way that is more
coherent in a world with lexical scoping.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::newLabelScope):
(JSC::BytecodeGenerator::emitProfileType):
(JSC::BytecodeGenerator::pushLexicalScope):
(JSC::BytecodeGenerator::popLexicalScope):
(JSC::BytecodeGenerator::prepareLexicalScopeForNextForLoopIteration):
(JSC::BytecodeGenerator::resolveType):
(JSC::BytecodeGenerator::emitResolveScope):
(JSC::BytecodeGenerator::emitGetFromScope):
(JSC::BytecodeGenerator::emitPutToScope):
(JSC::BytecodeGenerator::emitPushWithScope):
(JSC::BytecodeGenerator::emitGetParentScope):
(JSC::BytecodeGenerator::emitPopScope):
(JSC::BytecodeGenerator::emitPopWithOrCatchScope):
(JSC::BytecodeGenerator::emitPopScopes):
(JSC::BytecodeGenerator::calculateTargetScopeDepthForExceptionHandler):
(JSC::BytecodeGenerator::localScopeDepth):
(JSC::BytecodeGenerator::labelScopeDepth):
(JSC::BytecodeGenerator::emitThrowReferenceError):
(JSC::BytecodeGenerator::emitPushFunctionNameScope):
(JSC::BytecodeGenerator::pushScopedControlFlowContext):
(JSC::BytecodeGenerator::popScopedControlFlowContext):
(JSC::BytecodeGenerator::emitPushCatchScope):
(JSC::BytecodeGenerator::currentScopeDepth): Deleted.
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::hasFinaliser):
(JSC::BytecodeGenerator::scopeDepth): Deleted.
- bytecompiler/NodesCodegen.cpp:
(JSC::ContinueNode::trivialTarget):
(JSC::BreakNode::trivialTarget):
(JSC::ReturnNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::TryNode::emitBytecode):
- tests/stress/lexical-scoping-break-continue.js: Added.
(assert):
(.):
- 5:16 PM Changeset in webkit [187002] by
-
- 86 edits in trunk/Source
Reduce PassRefPtr in WebKit2 - 3
https://bugs.webkit.org/show_bug.cgi?id=146995
Reviewed by Daniel Bates.
To remove PassRefPtr, this patch reduces use of PassRefPtr in WebKit2.
Because some uses depend on WebCore, WebCore, WK1 ports are modified as well.
Source/WebCore:
- loader/EmptyClients.cpp:
(WebCore::EmptyChromeClient::createPopupMenu):
(WebCore::EmptyChromeClient::createSearchPopupMenu):
(WebCore::EmptyFrameLoaderClient::createDocumentLoader):
(WebCore::EmptyFrameLoaderClient::createFrame):
(WebCore::EmptyFrameLoaderClient::createPlugin):
- loader/EmptyClients.h:
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::init):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithNavigationAction):
(WebCore::FrameLoader::reloadWithOverrideEncoding):
(WebCore::FrameLoader::reload):
- loader/FrameLoaderClient.h:
- loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::scheduleSubresourceLoad):
(WebCore::ResourceLoadScheduler::schedulePluginStreamLoad):
- loader/ResourceLoadScheduler.h:
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::create):
- loader/SubresourceLoader.h:
- page/ChromeClient.h:
- platform/graphics/texmap/TextureMapperBackingStore.h:
- platform/graphics/texmap/TextureMapperLayer.h:
(WebCore::TextureMapperLayer::texture):
- platform/graphics/texmap/TextureMapperSurfaceBackingStore.cpp:
(WebCore::TextureMapperSurfaceBackingStore::texture):
- platform/graphics/texmap/TextureMapperSurfaceBackingStore.h:
- platform/graphics/texmap/TextureMapperTile.h:
(WebCore::TextureMapperTile::texture):
- platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:
(WebCore::TextureMapperTiledBackingStore::texture):
- platform/graphics/texmap/TextureMapperTiledBackingStore.h:
- storage/StorageNamespace.h:
Source/WebKit/mac:
- WebCoreSupport/WebFrameLoaderClient.h:
- WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createDocumentLoader):
Source/WebKit/win:
- WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createDocumentLoader):
- WebCoreSupport/WebFrameLoaderClient.h:
Source/WebKit2:
- DatabaseProcess/DatabaseProcess.cpp:
(WebKit::DatabaseProcess::getOrCreateUniqueIDBDatabase):
- DatabaseProcess/DatabaseProcess.h:
- PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::takeInitializationReply):
- PluginProcess/PluginControllerProxy.h:
- Shared/CoordinatedGraphics/CoordinatedBackingStore.cpp:
(WebKit::CoordinatedBackingStore::texture):
- Shared/CoordinatedGraphics/CoordinatedBackingStore.h:
(WebKit::CoordinatedBackingStore::create):
- Shared/CoordinatedGraphics/WebCoordinatedSurface.cpp:
(WebKit::WebCoordinatedSurface::create):
(WebKit::WebCoordinatedSurface::createWithSurface):
- Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
- UIProcess/API/APILoaderClient.h:
(API::LoaderClient::webCryptoMasterKey):
- UIProcess/API/APINavigationClient.h:
(API::NavigationClient::webCryptoMasterKey):
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPageLoaderClient):
(WKPageSetPageNavigationClient):
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::createPopupMenuProxy):
(WebKit::PageClientImpl::createContextMenuProxy):
(WebKit::PageClientImpl::createColorPicker):
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/Authentication/WebCredential.h:
- UIProcess/Authentication/WebProtectionSpace.h:
- UIProcess/AutoCorrectionCallback.h:
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::webCryptoMasterKey):
- UIProcess/CoordinatedGraphics/WebView.cpp:
(WebKit::WebView::createPopupMenuProxy):
(WebKit::WebView::createContextMenuProxy):
(WebKit::WebView::createColorPicker):
- UIProcess/CoordinatedGraphics/WebView.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.h:
- UIProcess/efl/WebViewEfl.cpp:
(WebKit::WebViewEfl::createPopupMenuProxy):
(WebKit::WebViewEfl::createContextMenuProxy):
(WebKit::WebViewEfl::createColorPicker):
- UIProcess/efl/WebViewEfl.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::createPopupMenuProxy):
(WebKit::PageClientImpl::createContextMenuProxy):
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::dataSelectionForPasteboard):
- UIProcess/mac/PageClientImpl.h:
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::createPopupMenuProxy):
(WebKit::PageClientImpl::createContextMenuProxy):
(WebKit::PageClientImpl::createColorPicker):
- UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::dataSelectionForPasteboard):
- WebProcess/Network/WebResourceLoadScheduler.cpp:
(WebKit::WebResourceLoadScheduler::scheduleSubresourceLoad):
(WebKit::WebResourceLoadScheduler::schedulePluginStreamLoad):
- WebProcess/Network/WebResourceLoadScheduler.h:
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::fromNPP):
(WebKit::NetscapePlugin::snapshot):
(WebKit::NetscapePlugin::liveResourceData):
- WebProcess/Plugins/Netscape/NetscapePlugin.h:
- WebProcess/Plugins/Plugin.h:
- WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::snapshot):
(WebKit::PluginProxy::liveResourceData):
- WebProcess/Plugins/PluginProxy.h:
- WebProcess/Storage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::storageArea):
(WebKit::StorageNamespaceImpl::copy):
- WebProcess/Storage/StorageNamespaceImpl.h:
- WebProcess/WebCoreSupport/SessionStateConversion.cpp:
(WebKit::toHistoryItem):
- WebProcess/WebCoreSupport/SessionStateConversion.h:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createPopupMenu):
(WebKit::WebChromeClient::createSearchPopupMenu):
- WebProcess/WebCoreSupport/WebChromeClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createDocumentLoader):
(WebKit::WebFrameLoaderClient::createFrame):
(WebKit::WebFrameLoaderClient::createPlugin):
- WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::create):
(WebKit::WebPage::createDocumentLoader):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::lookupTextAtLocation):
- 4:54 PM Changeset in webkit [187001] by
-
- 2 edits in trunk/Source/WebKit2
Scroll position jumps when scrolling scaling pages down in split view
https://bugs.webkit.org/show_bug.cgi?id=147072
rdar://problem/21769577
Reviewed by Sam Weinig.
When apple.com/music is in Split View at a reduced scale, scrolling the page
can cause unwanted scroll jumps. This happened because we'd enter
TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded() with a pending
layout, so run the autosizing logic. When scrolled near the bottom, the unconstrained
layout resulted in a shorter document, which truncated the scroll position. The
scaled layout then restored the longer document, but it also restored that
truncated scroll position.
Forcing a layout is sufficient to fix the bug for this page, and doing a single
layout (which will happen anyway) is preferable to running the autosize logic
if layout happens to be dirty.
I was not able to make a test to reproduce the problem. Entering
scaleViewToFitDocumentIfNeeded() with pending layout was triggerable
using a transform transition, but I was not able to reproduce incorrect
scroll position restoration.
- WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded):
- 4:41 PM Changeset in webkit [187000] by
-
- 2 edits in trunk/LayoutTests
inspector/console/command-line-api.html is slow on Debug Yosemite WK2
- platform/mac-wk2/TestExpectations: Mark test as slow on Debug
Yosemite WK2:
- inspector/console/command-line-api.html
- 4:32 PM Changeset in webkit [186999] by
-
- 2 edits in trunk/LayoutTests
http/tests/cache/disk-cache/disk-cache-disable.html is flaky on Release Yosemite WK2
- platform/mac-wk2/TestExpectations: Mark test as flaky on
Release Yosemite WK2:
- http/tests/cache/disk-cache/disk-cache-disable.html
- 4:32 PM Changeset in webkit [186998] by
-
- 2 edits in trunk/LayoutTests
media/restore-from-page-cache.html is flaky on Debug Mavericks
When the test fails, the computed width and height is
300px × 150px instead of the expected 320px × 240px.
- platform/mac/TestExpectations: Mark test as flaky on Debug Mavericks:
- media/restore-from-page-cache.html
- 2:21 PM Changeset in webkit [186997] by
-
- 4 edits1 delete in trunk/Source/JavaScriptCore
Unreviewed, rolling out r186996.
https://bugs.webkit.org/show_bug.cgi?id=147070
Broke JSC tests (Requested by smfr on #webkit).
Reverted changeset:
"lexical scoping is broken with respect to "break" and
"continue""
https://bugs.webkit.org/show_bug.cgi?id=147063
http://trac.webkit.org/changeset/186996
- 1:12 PM Changeset in webkit [186996] by
-
- 4 edits1 add in trunk/Source/JavaScriptCore
lexical scoping is broken with respect to "break" and "continue"
https://bugs.webkit.org/show_bug.cgi?id=147063
Reviewed by Filip Pizlo.
Bug #142944 which introduced "let" and lexical scoping
didn't properly hook into the bytecode generator's machinery
for calculating scope depth deltas for "break" and "continue". This
resulted in the bytecode generator popping an incorrect number
of scopes when lexical scopes were involved.
This patch fixes this problem and generalizes this machinery a bit.
This patch also renames old functions in a sensible way that is more
coherent in a world with lexical scoping.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::newLabelScope):
(JSC::BytecodeGenerator::emitProfileType):
(JSC::BytecodeGenerator::pushLexicalScope):
(JSC::BytecodeGenerator::popLexicalScope):
(JSC::BytecodeGenerator::prepareLexicalScopeForNextForLoopIteration):
(JSC::BytecodeGenerator::resolveType):
(JSC::BytecodeGenerator::emitResolveScope):
(JSC::BytecodeGenerator::emitGetFromScope):
(JSC::BytecodeGenerator::emitPutToScope):
(JSC::BytecodeGenerator::emitPushWithScope):
(JSC::BytecodeGenerator::emitGetParentScope):
(JSC::BytecodeGenerator::emitPopScope):
(JSC::BytecodeGenerator::emitPopWithOrCatchScope):
(JSC::BytecodeGenerator::emitPopScopes):
(JSC::BytecodeGenerator::calculateTargetScopeDepthForExceptionHandler):
(JSC::BytecodeGenerator::localScopeDepth):
(JSC::BytecodeGenerator::labelScopeDepth):
(JSC::BytecodeGenerator::emitThrowReferenceError):
(JSC::BytecodeGenerator::emitPushFunctionNameScope):
(JSC::BytecodeGenerator::pushScopedControlFlowContext):
(JSC::BytecodeGenerator::popScopedControlFlowContext):
(JSC::BytecodeGenerator::emitPushCatchScope):
(JSC::BytecodeGenerator::currentScopeDepth): Deleted.
- bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::hasFinaliser):
(JSC::BytecodeGenerator::scopeDepth): Deleted.
- bytecompiler/NodesCodegen.cpp:
(JSC::ContinueNode::trivialTarget):
(JSC::BreakNode::trivialTarget):
(JSC::ReturnNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::TryNode::emitBytecode):
- tests/stress/lexical-scoping-break-continue.js: Added.
(assert):
(.):
- 12:48 PM Changeset in webkit [186995] by
-
- 2 edits in trunk/LayoutTests
[Win] Skip input range repaint test.
- platform/win/TestExpectations:
- 7:22 AM Changeset in webkit [186994] by
-
- 2 edits in trunk/LayoutTests
REGRESSION (r186981): fast/repaint/block-inputrange-repaint.html is starting out life as flaky
- fast/repaint/block-inputrange-repaint.html:
- Use setTimeout() to give WebKit time to repaint.
- 6:54 AM Changeset in webkit [186993] by
-
- 4 edits in trunk/LayoutTests
REGRESSION (r186905,r186992): Incorrect results for platform/{gtk,efl,win}/fast/shrink-wrap/rect-shrink-wrap-expected.txt
- platform/efl/fast/shrink-wrap/rect-shrink-wrap-expected.txt:
- platform/gtk/fast/shrink-wrap/rect-shrink-wrap-expected.txt:
- platform/win/fast/shrink-wrap/rect-shrink-wrap-expected.txt:
- Update to correct expected results.
- 5:54 AM Changeset in webkit [186992] by
-
- 1 edit4 adds in trunk/LayoutTests
REGRESSION (r186858): GTK and EFL ports don't composite <canvas> elements
See also r186905 for Windows.
- platform/efl/fast/shrink-wrap/rect-shrink-wrap-expected.txt: Added.
- platform/gtk/fast/shrink-wrap/rect-shrink-wrap-expected.txt: Added.
- 5:30 AM Changeset in webkit [186991] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r186976): Use piFloat instead of M_PI
Attempt to fix the following build failure:
PathUtilities.cpp(183): error C2065: 'M_PI' : undeclared identifier [...\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj]
- platform/graphics/PathUtilities.cpp:
(WebCore::walkGraphAndExtractPolygon): Use piFloat since M_PI is
not defined on Windows.
- 5:20 AM Changeset in webkit [186990] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION (r186976): Windows build broke due to missing definition of M_PI
Attempt to fix the following build failure:
PathUtilities.cpp(182): error C2065: 'M_PI' : undeclared identifier [...\Source\WebCore\WebCore.vcxproj\WebCore.vcxproj]
- platform/graphics/PathUtilities.cpp: Include <wtf/MathExtras.h>.
- 5:19 AM Changeset in webkit [186989] by
-
- 3 edits in branches/safari-600.1.4.17-branch/LayoutTests
Merge r186988. rdar://problem/21709404
- 5:07 AM Changeset in webkit [186988] by
-
- 3 edits in trunk/LayoutTests
REGRESSION (r186982): http/tests/contentdispositionattachmentsandbox/form-submission-disabled.html and loader/meta-refresh-disabled.html fail
Part of:
<https://bugs.webkit.org/show_bug.cgi?id=147044>
<rdar://problem/21567820>
- http/tests/contentdispositionattachmentsandbox/form-submission-disabled-expected.txt:
- Fix line number of console message.
- loader/meta-refresh-disabled-expected.txt:
- Add newly expected console message.
Jul 17, 2015:
- 11:32 PM Changeset in webkit [186987] by
-
- 2 edits in trunk
Bring back the GNU ar check to create thin archives on non-Linux systems
https://bugs.webkit.org/show_bug.cgi?id=146681
Patch by Ting-Wei Lan <Ting-Wei Lan> on 2015-07-17
Reviewed by Martin Robinson.
We already use GNU ar thin archive feature to save time and disk space
on creating static archives, but it is only enabled on Linux. Without
this feature, the debug build of WebCore can be larger than 4 GiB,
which can cause error because GNU ar format uses 32-bit integer to
store offsets in the symbol table. This patch is similar to
https://bugs.webkit.org/show_bug.cgi?id=128596.
- Source/cmake/OptionsCommon.cmake:
- 10:51 PM Changeset in webkit [186986] by
-
- 5 edits in trunk/Source/JavaScriptCore
DFG should have some obvious mitigations against watching structures that are unprofitable to watch
https://bugs.webkit.org/show_bug.cgi?id=147034
Reviewed by Mark Lam and Michael Saboff.
This implements two guards against the DFG watching structures that are likely to fire
their watchpoints:
- Don't watch dictionaries or any structure that had a dictionary in its past. Dictionaries can be flattened, and then they can transform back to dictionaries.
- Don't watch structures whose past structures were transitioned-away from while their transition watchpoints were being watched. This property gives us monotonicity: if we recompile because we watched structure S1 of object O, then we won't make the same mistake again when object O has structure S2, S3, and so on.
This is a 1.5% speed-up on Kraken. It does penalize some Octane tests, but it also seems to
help some of them, so on Octane it's basically neutral.
- bytecode/Watchpoint.h:
(JSC::WatchpointSet::invalidate):
(JSC::WatchpointSet::isBeingWatched):
(JSC::WatchpointSet::addressOfState):
(JSC::WatchpointSet::addressOfSetIsNotEmpty):
(JSC::InlineWatchpointSet::touch):
(JSC::InlineWatchpointSet::isBeingWatched):
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::createStructure):
(JSC::JSGlobalObject::registerWeakMap):
- runtime/Structure.cpp:
(JSC::Structure::Structure):
(JSC::Structure::toDictionaryTransition):
(JSC::Structure::didTransitionFromThisStructure):
- runtime/Structure.h:
- 10:49 PM Changeset in webkit [186985] by
-
- 8 edits2 deletes in trunk/Source/JavaScriptCore
Remove DFG::DesiredWriteBarriers because it's just a very difficult way of saying "please barrier the machine code block owner"
https://bugs.webkit.org/show_bug.cgi?id=147030
Reviewed by Andreas Kling.
All of the users of DesiredWriteBarriers were just using it to request that Plan
finalization executes a barrier on codeBlock->ownerExecutable. Indeed, that's the only
owning cell in the heap that compilation affects. So, we might as well just have Plan
unconditionally execute that barrier and then we don't need DesiredWriteBarriers at
all.
- CMakeLists.txt:
- JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
- JavaScriptCore.xcodeproj/project.pbxproj:
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
- dfg/DFGDesiredWriteBarriers.cpp: Removed.
- dfg/DFGDesiredWriteBarriers.h: Removed.
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::registerFrozenValues):
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::reallyAdd):
(JSC::DFG::Plan::notifyCompiling):
(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):
(JSC::DFG::Plan::checkLivenessAndVisitChildren):
(JSC::DFG::Plan::cancel):
- dfg/DFGPlan.h:
- 10:20 PM Changeset in webkit [186984] by
-
- 3 edits2 adds in trunk
REGRESSION (r169105): Do not assign a renderer to multiple selection subtrees.
https://bugs.webkit.org/show_bug.cgi?id=147038
rdar://problem/21819351
Reviewed by David Kilzer.
A renderer should never be assigned to multiple selection subtrees. (Currently RenderObject maintains the last selection state.)
RenderView::applySubtreeSelection() loops from the start to the end of the selection to find renderers that are inside the selection.
However, in case of regions (when multiple selection roots are present) traversing the renderer tree by calling RenderObject::nextInPreOrder() could
end up going across selection roots.
This patch ensures that we assign renderers to a specific selection only when the current selection root and the renderer's selection root match.
Source/WebCore:
Test: fast/regions/crash-when-renderer-is-in-multiple-selection-subtrees2.html
- rendering/RenderView.cpp:
(WebCore::SelectionIterator::SelectionIterator):
(WebCore::SelectionIterator::current):
(WebCore::SelectionIterator::checkForSpanner):
(WebCore::RenderView::applySubtreeSelection):
LayoutTests:
- fast/regions/crash-when-renderer-is-in-multiple-selection-subtrees2-expected.txt: Added.
- fast/regions/crash-when-renderer-is-in-multiple-selection-subtrees2.html: Added.
- 9:44 PM Changeset in webkit [186983] by
-
- 12 edits17 adds in branches/safari-600.1.4.17-branch
Merge r186982. rdar://problem/21709404
- 8:47 PM Changeset in webkit [186982] by
-
- 12 edits17 adds in trunk
[iOS] Further tighten the sandbox around pages fetched with Content-Disposition: attachment
https://bugs.webkit.org/show_bug.cgi?id=147044
rdar://problem/21567820
Reviewed by Brady Eidson.
Source/WebCore:
In addition to placing resources fetched with 'Content-Disposition: attachment' in a unique origin,
this change does the following:
- Switches the sandbox type from SandboxOrigin to SandboxAll, which enforces the same restrictions as <iframe sandbox>.
- Disables processing of <meta http-equiv> elements.
- Disables loading of cross-origin subframes.
Tests: http/tests/contentdispositionattachmentsandbox/cross-origin-frames-disabled.html
http/tests/contentdispositionattachmentsandbox/form-submission-disabled.html
http/tests/contentdispositionattachmentsandbox/http-equiv-disabled.html
http/tests/contentdispositionattachmentsandbox/plugins-disabled.html
http/tests/contentdispositionattachmentsandbox/scripts-disabled.html
- dom/Document.cpp:
(WebCore::Document::processHttpEquiv): Switched to calling Document::httpEquivPolicy(). Logged an error to the console for policies other than Enabled.
(WebCore::Document::initSecurityContext): Switched sandbox enforcement from SandboxOrigin to SandboxAll.
(WebCore::Document::httpEquivPolicy): Returned a HttpEquivPolicy based on shouldEnforceContentDispositionAttachmentSandbox() and Settings::httpEquivEnabled().
(WebCore::Document::shouldEnforceContentDispositionAttachmentSandbox): Returned true if Settings::contentDispositionAttachmentSandboxEnabled()
and the document was fetched as an attachment.
- dom/Document.h:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest): When requesting a subframe main resource when the parent frame enforces an attachment sandbox,
only continue if the parent frame's SecurityOrigin allows the request.
- page/Settings.in: Added contentDispositionAttachmentSandboxEnabled with an initial value of false.
Source/WebKit/mac:
- WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]): Enabled Content-Disposition: attachment sandbox on iOS.
Source/WebKit2:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage): Enabled Content-Disposition: attachment sandbox on iOS.
Tools:
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::decidePolicyForResponse): Only log the message about attachments if the custom policy delegate is enabled.
This matches the behavior of DumpRenderTree.
LayoutTests:
- http/tests/contentdispositionattachmentsandbox/cross-origin-frames-disabled-expected.txt: Added.
- http/tests/contentdispositionattachmentsandbox/cross-origin-frames-disabled.html: Added.
- http/tests/contentdispositionattachmentsandbox/form-submission-disabled-expected.txt: Added.
- http/tests/contentdispositionattachmentsandbox/form-submission-disabled.html: Added.
- http/tests/contentdispositionattachmentsandbox/http-equiv-disabled-expected.txt: Added.
- http/tests/contentdispositionattachmentsandbox/http-equiv-disabled.html: Added.
- http/tests/contentdispositionattachmentsandbox/plugins-disabled-expected.html: Added.
- http/tests/contentdispositionattachmentsandbox/plugins-disabled.html: Added.
- http/tests/contentdispositionattachmentsandbox/resources/cross-origin-frames-frame.php: Added.
- http/tests/contentdispositionattachmentsandbox/resources/form-submission-frame.php: Added.
- http/tests/contentdispositionattachmentsandbox/resources/http-equiv-frame.php: Added.
- http/tests/contentdispositionattachmentsandbox/resources/plugins-frame.php: Added.
- http/tests/contentdispositionattachmentsandbox/resources/scripts-frame.php: Added.
- http/tests/contentdispositionattachmentsandbox/scripts-disabled-expected.txt: Added.
- http/tests/contentdispositionattachmentsandbox/scripts-disabled.html: Added.
- 8:46 PM Changeset in webkit [186981] by
-
- 3 edits2 adds in trunk
(display: block)input range's thumb disappears when moved.
https://bugs.webkit.org/show_bug.cgi?id=146896
<rdar://problem/21787807>
Reviewed by Simon Fraser.
Since the thumb is positioned after the layout for the input (shadow) subtree is finished, the repaint rects
issued during the layout will not cover the re-positioned thumb.
We need to issue a repaint soon after the thumb is re-positioned.
Source/WebCore:
Test: fast/repaint/block-inputrange-repaint.html
- html/shadow/SliderThumbElement.cpp:
(WebCore::RenderSliderContainer::layout):
LayoutTests:
- fast/repaint/block-inputrange-repaint-expected.txt: Added.
- fast/repaint/block-inputrange-repaint.html: Added.
- 8:16 PM Changeset in webkit [186980] by
-
- 3 edits in trunk/Source/WebCore
Attempt to fix the build.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::webkitCurrentPlaybackTargetIsWireless):
- html/HTMLMediaElement.h:
- 5:30 PM Changeset in webkit [186979] by
-
- 3 edits in trunk/Source/WebCore
Picture in Picture interacts poorly with AirPlay/HDMI
https://bugs.webkit.org/show_bug.cgi?id=147061
<rdar://problem/19192076>
Reviewed by Tim Horton.
When we are actively playing to an external target, the
picture in picture button should be hidden.
Also, the availability of picture in picture is also
dependent on AirPlay, so that we don't auto-pip when
we're displaying on a TV.
- Modules/mediacontrols/mediaControlsiOS.js:
(ControllerIOS.prototype.configureInlineControls): Call the update function.
(ControllerIOS.prototype.updatePictureInPictureButton): Add or remove a hidden class.
- html/MediaElementSession.cpp:
(WebCore::MediaElementSession::allowsPictureInPicture): Check Airplay status.
- 5:20 PM Changeset in webkit [186978] by
-
- 6 edits in trunk/Source
[iOS] TextIndicator has a large forehead when line-height > 1
https://bugs.webkit.org/show_bug.cgi?id=147058
<rdar://problem/21643094>
Reviewed by Dean Jackson.
- editing/FrameSelection.cpp:
(WebCore::FrameSelection::getClippedVisibleTextRectangles):
- editing/FrameSelection.h:
Add a parameter controlling whether getClippedVisibleTextRectangles
returns selection-height rects (including extra line-height) or text-height
rects (including only the text height). Plumb it down.
- page/TextIndicator.cpp:
(WebCore::TextIndicator::createWithRange):
(WebCore::TextIndicator::createWithSelectionInFrame):
Use the tighter text-height rects on iOS, where there's no selection highlight to cover up.
Remove an assertion that is no longer always true, and which is mostly obsoleted by the
fact that we don't let FrameSnapshotting code arbitrarily decide the rect to snapshot anymore.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
Apply a review comment that I left myself and then forgot about.
- 4:59 PM Changeset in webkit [186977] by
-
- 2 edits in trunk/Source/WebKit2
[iOS] Implement selectionInteractionAssistant accessor.
https://bugs.webkit.org/show_bug.cgi?id=147054
rdar://problem/20864286
Reviewed by Tim Horton.
One more change to adopt the new selection interaction
model on iOS.
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView selectionInteractionAssistant]):
- 4:55 PM Changeset in webkit [186976] by
-
- 9 edits in trunk
Improve rect shrink-wrapping algorithm
https://bugs.webkit.org/show_bug.cgi?id=147037
<rdar://problem/21643094>
Reviewed by Simon Fraser.
- platform/graphics/FloatPoint.h:
(WebCore::areEssentiallyEqual):
Added; implementation is the same as FloatSize's.
- platform/graphics/PathUtilities.cpp:
(WebCore::FloatPointGraph::FloatPointGraph):
(WebCore::FloatPointGraph::~FloatPointGraph):
(WebCore::FloatPointGraph::Node::Node):
(WebCore::FloatPointGraph::Node::nextPoints):
(WebCore::FloatPointGraph::Node::addNextPoint):
(WebCore::FloatPointGraph::Node::isVisited):
(WebCore::FloatPointGraph::Node::visit):
(WebCore::FloatPointGraph::Node::reset):
(WebCore::FloatPointGraph::reset):
(WebCore::FloatPointGraph::findOrCreateNode):
(WebCore::findLineSegmentIntersection):
(WebCore::addIntersectionPoints):
(WebCore::walkGraphAndExtractPolygon):
(WebCore::findUnvisitedPolygonStartPoint):
(WebCore::unitePolygons):
(WebCore::edgesForRect):
(WebCore::PathUtilities::pathWithShrinkWrappedRects):
(WebCore::addShrinkWrapRightCorner): Deleted.
(WebCore::addShrinkWrapLeftCorner): Deleted.
(WebCore::addShrinkWrappedPathForRects): Deleted.
(WebCore::rectsIntersectOrTouch): Deleted.
(WebCore::findSetContainingRect): Deleted.
Add a new implementation of shrink-wrap, which is significantly more
generic than the old one, which assumed a top-down progression of rects.
This version uses polygon intersection to find the path around the
set of rects, and then follows said path and adds appropriately-sized
arcs for the corners.
The polygon intersection algorithm first finds all the intersection points
between all of the rects, then builds a graph of edges outward from one point.
It then traverses the graph, choosing at each point the next edge which
has not been visited and has the greatest interior angle, recording the polygon as it goes.
If at the end of the traversal we have not returned to the initial node,
we give up on shrink-wrapping and just use a bounding box around the rects.
If any of the original rects have not been visited at all, we repeat the traversal
starting with that rect, making an additional polygon (since we removed completely contained
rects before we started, having not visited the rect at all means that it's not connected
to the others).
Once we have a set of united polygons, we follow each one, determining the ideal (always
equal in width and height, never more than half the length of either edge, so that we always
have a smooth curve) arc radius and projecting it onto the edge, and then
adding an arc between the end of the previous path and beginning of the next.
Because the shrink-wrap algorithm is fairly expensive, if there are more than 20 rects,
we fall back to a bounding box. Given the current use cases, this is more than enough
rects, but can certainly be adjusted in the future if needed.
- testing/Internals.cpp:
(WebCore::Internals::pathWithShrinkWrappedRects):
- testing/Internals.h:
- testing/Internals.idl:
Add a radius parameter.
- fast/shrink-wrap/rect-shrink-wrap-expected.png:
- fast/shrink-wrap/rect-shrink-wrap.html:
Add a radius parameter to testRects, defaulting to 8.
Add an offset parameter to testRects, making it easier to slide
the rect sets around.
Add some more test cases.
- 4:47 PM Changeset in webkit [186975] by
-
- 1 copy in tags/Safari-601.1.41
New tag.
- 4:32 PM Changeset in webkit [186974] by
-
- 3 edits2 adds in trunk
AX: iframe within table cell is inaccessible to VoiceOver
https://bugs.webkit.org/show_bug.cgi?id=147001
<rdar://problem/21106945>
Patch by Nan Wang <n_wang@apple.com> on 2015-07-17
Reviewed by Chris Fleizach.
Source/WebCore:
When a table cell is created before its parent table determines if it should be ignored or not,
the table cell may cache the wrong role. Fix that by allowing each table cell to update its role
after the table makes this determination.
Test: accessibility/iframe-within-cell.html
- accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::addChildrenFromSection):
LayoutTests:
- accessibility/iframe-within-cell-expected.txt: Added.
- accessibility/iframe-within-cell.html: Added.
- 4:32 PM Changeset in webkit [186973] by
-
- 5 edits in branches/safari-601.1-branch/Source
Versioning.
- 4:26 PM Changeset in webkit [186972] by
-
- 5 edits in branches/safari-600.8-branch/Source
Versioning.
- 4:26 PM Changeset in webkit [186971] by
-
- 3 edits2 adds in trunk
style.fontFamily accessor crashes on unstyled node created from DOMParser().parseFromString()
https://bugs.webkit.org/show_bug.cgi?id=147026
<rdar://problem/21864487>
Reviewed by Andreas Kling.
Source/WebCore:
Font CSS properties are a little special because they are used as indices into caches.
Normally, StyleResolver gives all nodes a default font family, so our cache works correctly.
However, if the document doesn't have a Settings object, StyleResolver wasn't doing this.
Documents created from DOMParser().parseFromString() don't have a Settings object.
Test: fast/text/crash-font-family-parsed.html
- css/StyleResolver.cpp:
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::initializeFontStyle): Set a font family even if we don't have a
Settings object.
LayoutTests:
- fast/text/crash-font-family-parsed-expected.txt: Added.
- fast/text/crash-font-family-parsed.html: Added.
- 4:18 PM Changeset in webkit [186970] by
-
- 2 edits1 move in trunk/LayoutTests
Unreviewed, rename test file from promise-resolve-non-dom.js to promise-resolve-in-non-dom.js
https://bugs.webkit.org/show_bug.cgi?id=146828
This is the simple follow up patch.
When executing the JSC stress tests, script-tests's file name and the expectation file name should be equal.
- js/promise-resolve-in-non-dom.html:
- js/script-tests/promise-resolve-in-non-dom.js: Renamed from LayoutTests/js/script-tests/promise-resolve-non-dom.js.
(value.then):
- js/script-tests/promise-resolve-non-dom.js:
(value.then): Deleted.
- 4:05 PM Changeset in webkit [186969] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION (r186964): Crash in WebKit2.CloseFromWithinCreatePage
https://bugs.webkit.org/show_bug.cgi?id=147055
Reviewed by Alex Christensen.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createNewPage): Grab the main frame’s URL before calling out to the
client, who may destroy the frame.
- 4:01 PM Changeset in webkit [186968] by
-
- 3 edits2 adds in trunk
Video posters disappear once media has loaded
https://bugs.webkit.org/show_bug.cgi?id=147045
Reviewed by Simon Fraser.
Source/WebCore:
After r184932, all video elements are composited. However, there is logic in
RenderLayerBacking::updateConfiguration() which adds the video layer to the page
if the video is composited, without checking first to see if it should actually
do so.
Test: compositing/video/poster.html
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateConfiguration):
LayoutTests:
- compositing/video/poster-expected.html: Added.
- compositing/video/poster.html: Added.
- 3:54 PM Changeset in webkit [186967] by
-
- 1 copy in tags/Safari-600.8.4
New tag.
- 3:40 PM Changeset in webkit [186966] by
-
- 11 edits6 adds in trunk
Integrate automatic microtask draining into JSC framework and re-enable Promise
https://bugs.webkit.org/show_bug.cgi?id=146828
Reviewed by Sam Weinig.
Source/JavaScriptCore:
Add automatic microtask draining system into JSC framework.
When the depth of VM lock becomes 0, before this, we drain the queued microtasks.
Enqueuing behavior can be injected by the JSGlobalObject's method table.
It is utilized in WebCore to post the microtask to WebCore's event loop.
In the case of JSC interactive shell, VM depth is always greater than 0.
So we manually drains the queued microtasks after evaluating the written line.
Since now JSC framework has the microtask queue, we can drain the queued microtasks.
So re-enable the Promise in the JSC framework context.
- API/JSContextRef.cpp:
(javaScriptRuntimeFlags): Deleted.
- API/tests/testapi.c:
(main):
- API/tests/testapi.mm:
(testObjectiveCAPIMain):
- jsc.cpp:
(runInteractive):
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::queueMicrotask):
- runtime/JSLock.cpp:
(JSC::JSLock::willReleaseLock):
- runtime/VM.cpp:
(JSC::VM::queueMicrotask):
(JSC::VM::drainMicrotasks):
(JSC::QueuedTask::run):
- runtime/VM.h:
(JSC::QueuedTask::QueuedTask):
LayoutTests:
Add Promise tests mainly focusing on microtasks.
They can be executed in JSC shell. So they are locate in js/ directory (not js/dom).
- js/promise-nested-microtasks-expected.txt: Added.
- js/promise-nested-microtasks.html: Added.
- js/promise-resolve-in-non-dom-expected.txt: Added.
- js/promise-resolve-in-non-dom.html: Added.
- js/script-tests/promise-nested-microtasks.js: Added.
(Promise.resolve.then):
- js/script-tests/promise-resolve-non-dom.js: Added.
(value.then):
- resources/standalone-post.js:
- 2:47 PM Changeset in webkit [186965] by
-
- 4 edits in trunk
[Content Extensions] Term::isUniversalTransition() incorrectly expects the end-of-line assertion in character sets
https://bugs.webkit.org/show_bug.cgi?id=147032
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-07-17
Reviewed by Alex Christensen.
Source/WebCore:
- contentextensions/Term.h:
(WebCore::ContentExtensions::Term::isUniversalTransition):
The universal transition is not supposed to account for the end-of-line assertion,
it should be a transition matching any character.
Here, we were counting 128 transitions, the 127 characters plus the
transition on zero we are using for EOL.
The end result is Term::isUniversalTransition() was completely useless.
The only code using it is the pattern simplificaton phase. That part
was not working correclty and was allowing useless ".*" in the patterns.
Tools:
- TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
Test that the useless terms are eliminated by counting
the number of NFA nodes generated.
- 2:16 PM Changeset in webkit [186964] by
-
- 10 edits1 add in trunk
Source/WebCore:
WebCore part of <rdar://problem/21803781> The external URL policy is not reported correctly in navigation actions that create new windows
https://bugs.webkit.org/show_bug.cgi?id=147040
Reviewed by Dean Jackson.
Test: TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm
- loader/FrameLoader.cpp:
(WebCore::shouldOpenExternalURLsPolicyToApply): Pulled the logic out of
applyShouldOpenExternalURLsPolicyToNewDocumentLoader into this new helper.
(WebCore::FrameLoader::loadURL): When targeting a new frame, apply the external URLs policy
to the action passed to checkNewWindowPolicy.
(WebCore::FrameLoader::applyShouldOpenExternalURLsPolicyToNewDocumentLoader): Call the new
helper function.
(WebCore::createWindow): Include the external URL policy in the action passed to
createWindow.
Source/WebKit2:
WebKit2 part of <rdar://problem/21803781> The external URL policy is not reported correctly in navigation actions that create new windows
https://bugs.webkit.org/show_bug.cgi?id=147040
Reviewed by Dean Jackson.
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::createNewPage): Disallow App Links if the new page is for the
same protocol, host and port as the main frame of this page.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNavigationAction): Disallow App Links if
m_shouldSuppressAppLinksInNextNavigationPolicyDecision is set, and reset it. See below for
when we set it.
(WebKit::WebPageProxy::decidePolicyForNewWindowAction): Disallow App Links if the new window
is for the same protocol, host and port as the main frame of this page.
(WebKit::WebPageProxy::createNewPage): Make the new page disallow App Links in the first
policy decision if it is for the same protocol, host and port as the main frame of this
page.
- UIProcess/WebPageProxy.h: Added m_shouldSuppressAppLinksInNextNavigationPolicyDecision
member variable.
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow): Pass the shouldOpenExternalURLsPolicy.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction): Ditto.
Tools:
Tests for <rdar://problem/21803781> The external URL policy is not reported correctly in navigation actions that create new windows
https://bugs.webkit.org/show_bug.cgi?id=147040
Reviewed by Dean Jackson.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/ShouldOpenExternalURLsInNewWindowActions.mm: Added.
(-[ShouldOpenExternalURLsInNewWindowActionsController webView:decidePolicyForNavigationAction:decisionHandler:]):
(-[ShouldOpenExternalURLsInNewWindowActionsController webView:didFinishNavigation:]):
(-[ShouldOpenExternalURLsInNewWindowActionsController webView:createWebViewWithConfiguration:forNavigationAction:windowFeatures:]):
(TEST):
- 12:35 PM Changeset in webkit [186963] by
-
- 2 edits in trunk/Source/WebCore
ScrollView.h should be self-contained
https://bugs.webkit.org/show_bug.cgi?id=147004
Reviewed by Sam Weinig.
- platform/ScrollView.h:
- 12:23 PM Changeset in webkit [186962] by
-
- 33 edits in tags/Safari-601.1.36.2
Merged r186881. rdar://problem/21822278
- 12:00 PM Changeset in webkit [186961] by
-
- 2 edits in trunk/Source/WebCore
Rolling r186895 back in, in its entirety.
https://bugs.webkit.org/show_bug.cgi?id=146976
Rubberstamped by Tim Horton.
- platform/network/cf/CookieJarCFNet.cpp:
(WebCore::createCookies): Use new CFNetwork SPI.
- 11:50 AM Changeset in webkit [186960] by
-
- 5 edits in tags/Safari-601.1.36.2/Source
Versioning.
- 11:48 AM Changeset in webkit [186959] by
-
- 65 edits in trunk
Function parameters should be parsed in the same parser arena as the function body
https://bugs.webkit.org/show_bug.cgi?id=145995
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
This patch changes how functions are parsed in JSC. A function's
parameters are now parsed in the same arena as the function itself.
This allows us to arena allocate all destructuring AST nodes and
the FunctionParameters node. This will help make implementing ES6
default parameter values sane.
A source code that represents a function now includes the text of the function's
parameters. The starting offset is at the opening parenthesis of the parameter
list or at the starting character of the identifier for arrow functions that
have single arguments and don't start with parenthesis.
For example:
"function (param1, param2) { ... }"
| This offset used to be the starting offset of a function's SourceCode
| This is the new starting offset for a function's SourceCode.
This requires us to change how some offsets are calculated
and also requires us to report some different line numbers for internal
metrics that use a SourceCode's starting line and column numbers.
This patch also does a bit of cleanup with regards to how
functions are parsed in general (especially arrow functions).
It removes some unnecessary #ifdefs and the likes for arrow
to make things clearer and more deliberate.
- API/JSScriptRef.cpp:
(parseScript):
- builtins/BuiltinExecutables.cpp:
(JSC::BuiltinExecutables::createExecutableInternal):
- bytecode/UnlinkedCodeBlock.cpp:
(JSC::generateFunctionCodeBlock):
(JSC::UnlinkedFunctionExecutable::UnlinkedFunctionExecutable):
(JSC::UnlinkedFunctionExecutable::visitChildren):
(JSC::UnlinkedFunctionExecutable::parameterCount): Deleted.
- bytecode/UnlinkedCodeBlock.h:
- bytecompiler/NodesCodegen.cpp:
(JSC::DestructuringAssignmentNode::emitBytecode):
(JSC::assignDefaultValueIfUndefined):
(JSC::ArrayPatternNode::collectBoundIdentifiers):
(JSC::DestructuringPatternNode::~DestructuringPatternNode): Deleted.
- parser/ASTBuilder.h:
(JSC::ASTBuilder::createClassExpr):
(JSC::ASTBuilder::createFunctionExpr):
(JSC::ASTBuilder::createFunctionBody):
(JSC::ASTBuilder::createArrowFunctionExpr):
(JSC::ASTBuilder::createGetterOrSetterProperty):
(JSC::ASTBuilder::createElementList):
(JSC::ASTBuilder::createFormalParameterList):
(JSC::ASTBuilder::appendParameter):
(JSC::ASTBuilder::createClause):
(JSC::ASTBuilder::createClauseList):
(JSC::ASTBuilder::createFuncDeclStatement):
(JSC::ASTBuilder::createForInLoop):
(JSC::ASTBuilder::createForOfLoop):
(JSC::ASTBuilder::isResolve):
(JSC::ASTBuilder::createDestructuringAssignment):
(JSC::ASTBuilder::createArrayPattern):
(JSC::ASTBuilder::appendArrayPatternSkipEntry):
(JSC::ASTBuilder::appendArrayPatternEntry):
(JSC::ASTBuilder::appendArrayPatternRestEntry):
(JSC::ASTBuilder::finishArrayPattern):
(JSC::ASTBuilder::createObjectPattern):
(JSC::ASTBuilder::appendObjectPatternEntry):
(JSC::ASTBuilder::createBindingLocation):
(JSC::ASTBuilder::setEndOffset):
- parser/Lexer.cpp:
(JSC::Lexer<T>::Lexer):
(JSC::Lexer<T>::nextTokenIsColon):
(JSC::Lexer<T>::setTokenPosition):
(JSC::Lexer<T>::lex):
(JSC::Lexer<T>::clear):
- parser/Lexer.h:
(JSC::Lexer::setIsReparsingFunction):
(JSC::Lexer::isReparsingFunction):
(JSC::Lexer::lineNumber):
(JSC::Lexer::setIsReparsing): Deleted.
(JSC::Lexer::isReparsing): Deleted.
- parser/NodeConstructors.h:
(JSC::TryNode::TryNode):
(JSC::FunctionParameters::FunctionParameters):
(JSC::FuncExprNode::FuncExprNode):
(JSC::FuncDeclNode::FuncDeclNode):
(JSC::ArrayPatternNode::ArrayPatternNode):
(JSC::ObjectPatternNode::ObjectPatternNode):
(JSC::BindingNode::BindingNode):
(JSC::DestructuringAssignmentNode::DestructuringAssignmentNode):
(JSC::ParameterNode::ParameterNode): Deleted.
(JSC::ArrayPatternNode::create): Deleted.
(JSC::ObjectPatternNode::create): Deleted.
(JSC::BindingNode::create): Deleted.
- parser/Nodes.cpp:
(JSC::ProgramNode::ProgramNode):
(JSC::EvalNode::EvalNode):
(JSC::FunctionBodyNode::FunctionBodyNode):
(JSC::FunctionBodyNode::finishParsing):
(JSC::FunctionNode::FunctionNode):
(JSC::FunctionNode::finishParsing):
(JSC::FunctionParameters::create): Deleted.
(JSC::FunctionParameters::FunctionParameters): Deleted.
(JSC::FunctionParameters::~FunctionParameters): Deleted.
- parser/Nodes.h:
(JSC::ProgramNode::startColumn):
(JSC::ProgramNode::endColumn):
(JSC::EvalNode::startColumn):
(JSC::EvalNode::endColumn):
(JSC::FunctionParameters::size):
(JSC::FunctionParameters::at):
(JSC::FunctionParameters::append):
(JSC::FuncExprNode::body):
(JSC::DestructuringPatternNode::~DestructuringPatternNode):
(JSC::DestructuringPatternNode::isBindingNode):
(JSC::DestructuringPatternNode::emitDirectBinding):
(JSC::ArrayPatternNode::appendIndex):
(JSC::ObjectPatternNode::appendEntry):
(JSC::BindingNode::boundProperty):
(JSC::BindingNode::divotStart):
(JSC::BindingNode::divotEnd):
(JSC::DestructuringAssignmentNode::bindings):
(JSC::FuncDeclNode::body):
(JSC::ParameterNode::pattern): Deleted.
(JSC::ParameterNode::nextParam): Deleted.
(JSC::FunctionParameters::patterns): Deleted.
- parser/Parser.cpp:
(JSC::Parser<LexerType>::Parser):
(JSC::Parser<LexerType>::~Parser):
(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::allowAutomaticSemicolon):
(JSC::Parser<LexerType>::parseSourceElements):
(JSC::Parser<LexerType>::createBindingPattern):
(JSC::Parser<LexerType>::parseArrowFunctionSingleExpressionBodySourceElements):
(JSC::Parser<LexerType>::tryParseDestructuringPatternExpression):
(JSC::Parser<LexerType>::parseSwitchClauses):
(JSC::Parser<LexerType>::parseSwitchDefaultClause):
(JSC::Parser<LexerType>::parseBlockStatement):
(JSC::Parser<LexerType>::parseStatement):
(JSC::Parser<LexerType>::parseFormalParameters):
(JSC::Parser<LexerType>::parseFunctionBody):
(JSC::stringForFunctionMode):
(JSC::Parser<LexerType>::parseFunctionParameters):
(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parsePrimaryExpression):
(JSC::Parser<LexerType>::parseMemberExpression):
(JSC::Parser<LexerType>::parseArrowFunctionExpression):
(JSC::operatorString):
(JSC::Parser<LexerType>::parseArrowFunctionSingleExpressionBody): Deleted.
- parser/Parser.h:
(JSC::Parser::positionBeforeLastNewline):
(JSC::Parser::locationBeforeLastToken):
(JSC::Parser::findCachedFunctionInfo):
(JSC::Parser::isofToken):
(JSC::Parser::isEndOfArrowFunction):
(JSC::Parser::isArrowFunctionParamters):
(JSC::Parser::tokenStart):
(JSC::Parser::isLETMaskedAsIDENT):
(JSC::Parser::autoSemiColon):
(JSC::Parser::setEndOfStatement):
(JSC::Parser::canRecurse):
(JSC::Parser<LexerType>::parse):
(JSC::parse):
- parser/ParserFunctionInfo.h:
- parser/ParserModes.h:
(JSC::functionNameIsInScope):
- parser/SourceCode.h:
(JSC::makeSource):
(JSC::SourceCode::subExpression):
(JSC::SourceCode::subArrowExpression): Deleted.
- parser/SourceProviderCache.h:
(JSC::SourceProviderCache::get):
- parser/SourceProviderCacheItem.h:
(JSC::SourceProviderCacheItem::endFunctionToken):
(JSC::SourceProviderCacheItem::usedVariables):
(JSC::SourceProviderCacheItem::writtenVariables):
(JSC::SourceProviderCacheItem::SourceProviderCacheItem):
- parser/SyntaxChecker.h:
(JSC::SyntaxChecker::SyntaxChecker):
(JSC::SyntaxChecker::createClassExpr):
(JSC::SyntaxChecker::createFunctionExpr):
(JSC::SyntaxChecker::createFunctionBody):
(JSC::SyntaxChecker::createArrowFunctionExpr):
(JSC::SyntaxChecker::setFunctionNameStart):
(JSC::SyntaxChecker::createArguments):
(JSC::SyntaxChecker::createPropertyList):
(JSC::SyntaxChecker::createElementList):
(JSC::SyntaxChecker::createFormalParameterList):
(JSC::SyntaxChecker::appendParameter):
(JSC::SyntaxChecker::createClause):
(JSC::SyntaxChecker::createClauseList):
- runtime/CodeCache.cpp:
(JSC::CodeCache::getGlobalCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
- runtime/Completion.cpp:
(JSC::checkSyntax):
- runtime/Executable.cpp:
(JSC::ProgramExecutable::checkSyntax):
- tests/controlFlowProfiler/conditional-expression.js:
(testConditionalFunctionCall):
LayoutTests:
- fast/profiler/anonymous-event-handler-expected.txt:
- fast/profiler/anonymous-function-called-from-different-contexts-expected.txt:
- fast/profiler/anonymous-function-calls-built-in-functions-expected.txt:
- fast/profiler/anonymous-function-calls-eval-expected.txt:
- fast/profiler/anonymous-functions-with-display-names-expected.txt:
- fast/profiler/apply-expected.txt:
- fast/profiler/built-in-function-calls-anonymous-expected.txt:
- fast/profiler/built-in-function-calls-user-defined-function-expected.txt:
- fast/profiler/call-expected.txt:
- fast/profiler/calling-the-function-that-started-the-profiler-from-another-scope-expected.txt:
- fast/profiler/compare-multiple-profiles-expected.txt:
- fast/profiler/constructor-expected.txt:
- fast/profiler/dead-time-expected.txt:
- fast/profiler/document-dot-write-expected.txt:
- fast/profiler/event-handler-expected.txt:
- fast/profiler/execution-context-and-eval-on-same-line-expected.txt:
- fast/profiler/inline-event-handler-expected.txt:
- fast/profiler/many-calls-in-the-same-scope-expected.txt:
- fast/profiler/multiple-and-different-scoped-anonymous-function-calls-expected.txt:
- fast/profiler/multiple-and-different-scoped-function-calls-expected.txt:
- fast/profiler/multiple-anonymous-functions-called-from-the-same-function-expected.txt:
- fast/profiler/multiple-frames-expected.txt:
- fast/profiler/named-functions-with-display-names-expected.txt:
- fast/profiler/nested-anonymous-functon-expected.txt:
- fast/profiler/nested-start-and-stop-profiler-expected.txt:
- fast/profiler/one-execution-context-expected.txt:
- fast/profiler/profile-calls-in-included-file-expected.txt:
- fast/profiler/profile-with-no-title-expected.txt:
- fast/profiler/profiling-from-a-nested-location-but-stop-profiling-outside-the-nesting-expected.txt:
- fast/profiler/profiling-from-a-nested-location-expected.txt:
- fast/profiler/simple-event-call-expected.txt:
- fast/profiler/simple-no-level-change-expected.txt:
- fast/profiler/start-and-stop-profiler-multiple-times-expected.txt:
- fast/profiler/start-and-stop-profiling-in-the-same-function-expected.txt:
- fast/profiler/stop-profiling-after-setTimeout-expected.txt:
- fast/profiler/stop-then-function-call-expected.txt:
- fast/profiler/two-execution-contexts-expected.txt:
- fast/profiler/user-defined-function-calls-built-in-functions-expected.txt:
- fast/profiler/window-dot-eval-expected.txt:
- js/dom/script-start-end-locations-expected.txt:
- 11:46 AM Changeset in webkit [186958] by
-
- 1 copy in tags/Safari-601.1.36.2
New tag.
- 11:28 AM Changeset in webkit [186957] by
-
- 7 edits9 adds in trunk
[Content Extensions] CSS-display-none rules are not working properly
https://bugs.webkit.org/show_bug.cgi?id=147024
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-07-17
Reviewed by Sam Weinig.
Source/WebCore:
There were 2 bugs prevening rules with css-display-none and a url-filter from working
correctly.
First, ContentExtensions::serializeActions() was merging selectors regardless of their
trigger. All the CSS Selectors would be grouped together and applied regardless of which
rule apply.
That problem was fixed by grouping CSS rules by trigger. We want all the undistinguishable
CSS rules to be merged. The trigger makes 2 rules dinstinguishable as one rule can apply
on a page while the next rule does not. The simplest approach is to group by trigger.
The second problem had to do with rules added before the document is created.
When accumulating those rules, we were only keeping the last one. The reason was that
DocumentLoader::addPendingContentExtensionDisplayNoneSelector() would only keep a single
selector list by extension.
This is fixed by keeping a vector of all the rules that apply.
Tests: http/tests/contentextensions/css-display-none-with-different-case-sensitivity-are-not-merged.html
http/tests/contentextensions/css-display-none-with-different-triggers-are-not-merged.html
http/tests/contentextensions/two-distinguishable-css-display-none-rules-on-main-resource.html
- contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::serializeActions):
- contentextensions/ContentExtensionRule.h:
(WebCore::ContentExtensions::Trigger::isEmpty):
(WebCore::ContentExtensions::TriggerHash::hash):
(WebCore::ContentExtensions::TriggerHash::equal):
(WebCore::ContentExtensions::TriggerHashTraits::constructDeletedValue):
(WebCore::ContentExtensions::TriggerHashTraits::isDeletedValue):
(WebCore::ContentExtensions::TriggerHashTraits::emptyValue):
(WebCore::ContentExtensions::TriggerHashTraits::isEmptyValue):
- contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad): Deleted.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::commitData):
(WebCore::DocumentLoader::addPendingContentExtensionDisplayNoneSelector):
- loader/DocumentLoader.h:
LayoutTests:
- http/tests/contentextensions/css-display-none-with-different-case-sensitivity-are-not-merged-expected.txt: Added.
- http/tests/contentextensions/css-display-none-with-different-case-sensitivity-are-not-merged.html: Added.
- http/tests/contentextensions/css-display-none-with-different-case-sensitivity-are-not-merged.html.json: Added.
- http/tests/contentextensions/css-display-none-with-different-triggers-are-not-merged-expected.txt: Added.
- http/tests/contentextensions/css-display-none-with-different-triggers-are-not-merged.html: Added.
- http/tests/contentextensions/css-display-none-with-different-triggers-are-not-merged.html.json: Added.
- http/tests/contentextensions/two-distinguishable-css-display-none-rules-on-main-resource-expected.txt: Added.
- http/tests/contentextensions/two-distinguishable-css-display-none-rules-on-main-resource.html: Added.
- http/tests/contentextensions/two-distinguishable-css-display-none-rules-on-main-resource.html.json: Added.
- 11:24 AM Changeset in webkit [186956] by
-
- 9 edits in trunk/Source
iOS TextIndicators include text that is not supposed to be indicated
https://bugs.webkit.org/show_bug.cgi?id=147028
<rdar://problem/21643094>
Reviewed by Sam Weinig.
Paint the selection and background, but not other foregrounds, for iOS TextIndicators.
- page/FrameSnapshotting.cpp:
(WebCore::snapshotFrameRect):
- page/FrameSnapshotting.h:
Add a new snapshot option where we'll paint backgrounds and the selected
foreground and nothing else.
Pass the new snapshot option through as a paint behavior.
- page/TextIndicator.cpp:
(WebCore::TextIndicator::createWithRange):
Implement the incantations necessary to make a temporary selection
change not get sent to the UI process and actually have WebCore know about it
and accurately respond to questions about it.
(WebCore::TextIndicator::createWithSelectionInFrame):
Paint selection and backgrounds on iOS.
- rendering/PaintPhase.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
- rendering/RenderElement.cpp:
(WebCore::RenderElement::selectionColor):
Add a new paint behavior, SelectionAndBackgroundsOnly, which behaves
the same as selection only except it allows backgrounds to paint.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::shouldCreateTransientPaintingSnapshot):
- 11:11 AM Changeset in webkit [186955] by
-
- 25 edits in trunk
Remove leak of objects between isolated worlds on custom events, message events, and pop state events.
https://bugs.webkit.org/show_bug.cgi?id=118884
Reviewed by Filip Pizlo and Mark Lam.
Patch by Keith Miller <keith_miller@apple.com>.
Source/WebCore:
Tests: fast/events/event-leak-objects.html
fast/events/event-properties-gc.html
Fixes an issue where objects passed as certain properties of events could cross isolated worlds. This
was fixed by checking that any object passed by an event must be serializable or originate from the same
isolated world as the one it is currently being accessed in. In the case of MessageEvents and PopStateEvents we
cache the values of the data and state properties, respectively, as they may be a deserialized object. In case
an object was deserialized in a world with elevated privileges we also check the cached value is from the same
world, if it is from a different world we recompute it. For testing purposes, I added a new function to Internals
that determines whether a JSObject originated in the current world.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/DOMWrapperWorld.h:
(WebCore::worldForDOMObject):
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSCustomEventCustom.cpp: Copied from Source/WebCore/dom/CustomEvent.cpp.
(WebCore::JSCustomEvent::detail):
- bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::data):
- bindings/js/JSPopStateEventCustom.cpp:
(WebCore::JSPopStateEvent::state):
- dom/CustomEvent.cpp:
(WebCore::CustomEvent::initCustomEvent):
(WebCore::CustomEvent::trySerializeDetail):
- dom/CustomEvent.h:
- dom/CustomEvent.idl:
- dom/MessageEvent.cpp:
(WebCore::MessageEvent::initMessageEvent):
(WebCore::MessageEvent::trySerializeData):
- dom/MessageEvent.h:
- dom/PopStateEvent.cpp:
(WebCore::PopStateEvent::trySerializeState):
- dom/PopStateEvent.h:
- testing/Internals.cpp:
(WebCore::Internals::isFromCurrentWorld):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
These tests ensure ensure objects are not leaked across isolated worlds and that those properties are not prematurely
garbage collected.
- fast/events/constructors/custom-event-constructor-expected.txt:
- fast/events/constructors/custom-event-constructor.html:
- fast/events/event-leak-objects-expected.txt: Added.
- fast/events/event-leak-objects.html: Added.
- fast/events/event-properties-gc-expected.txt: Added.
- fast/events/event-properties-gc.html: Added.
- 2:23 AM Changeset in webkit [186954] by
-
- 7 edits in trunk/Source
[GTK] Cleanup PasteboardHelper
https://bugs.webkit.org/show_bug.cgi?id=147035
Reviewed by Žan Doberšek.
Source/WebCore:
It's actually a singleton, but the API suggests you can create
your own or use the default one, but the default one should be the
only one. Rename PasteboardHelper::defaultPasteboardHelper() as
PasteboardHelper::singleton() and make it non-copyable and never
destroyed.
- platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writePlainText): Use PasteboardHelper::singleton().
(WebCore::Pasteboard::write): Ditto.
(WebCore::Pasteboard::writePasteboard): Ditto.
(WebCore::Pasteboard::clear): Ditto.
(WebCore::Pasteboard::canSmartReplace): Ditto.
(WebCore::Pasteboard::read): Ditto.
(WebCore::Pasteboard::hasData): Ditto.
(WebCore::Pasteboard::types): Ditto.
(WebCore::Pasteboard::readString): Ditto.
(WebCore::Pasteboard::readFilenames): Ditto.
- platform/gtk/PasteboardHelper.cpp:
(WebCore::PasteboardHelper::singleton): Renamed as singleton, also
use NeverDestroyed and return a reference instead of a pointer.
(WebCore::PasteboardHelper::PasteboardHelper): Do all
initializations here and remove the initialization static flag,
since this is a real singleton now. Also use
gdk_atom_intern_static_string() to initialize the atoms instead of
gdk_atom_intern().
(WebCore::PasteboardHelper::targetList):
(WebCore::PasteboardHelper::targetListForDataObject):
(WebCore::getClipboardContentsCallback):
- platform/gtk/PasteboardHelper.h:
Source/WebKit2:
Use PasteboardHelper::singleton() instead of
PasteboardHelper::defaultPasteboardHelper().
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseConstructed):
- UIProcess/gtk/DragAndDropHandler.cpp:
(WebKit::DragAndDropHandler::startDrag):
(WebKit::DragAndDropHandler::fillDragData):
(WebKit::DragAndDropHandler::dataObjectForDropData):
(WebKit::DragAndDropHandler::requestDragData):
Jul 16, 2015:
- 11:24 PM Changeset in webkit [186953] by
-
- 3 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r186808. rdar://problem/21801544
- 11:15 PM Changeset in webkit [186952] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebInspectorUI
Merge r186926. rdar://problem/21868062
- 11:15 PM Changeset in webkit [186951] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebInspectorUI
Merge r186925. rdar://problem/21868413
- 11:15 PM Changeset in webkit [186950] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r186924. rdar://problem/21669802
- 11:15 PM Changeset in webkit [186949] by
-
- 2 edits in branches/safari-601.1-branch/Source/JavaScriptCore
Merge r186920. rdar://problem/21764196
- 11:15 PM Changeset in webkit [186948] by
-
- 4 edits in branches/safari-601.1-branch/Source
Merge r186919. rdar://problem/21834578
- 11:15 PM Changeset in webkit [186947] by
-
- 34 edits in branches/safari-601.1-branch
Merge r186881. rdar://problem/21822278
- 11:15 PM Changeset in webkit [186946] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merge r186799. rdar://problem/20542574
- 11:15 PM Changeset in webkit [186945] by
-
- 7 edits in branches/safari-601.1-branch/Source/WebCore
Merge r186798. rdar://problem/20542574
- 10:33 PM Changeset in webkit [186944] by
-
- 3 edits2 adds in branches/safari-601.1-branch
Merge r186911. rdar://problem/21822541
- 10:33 PM Changeset in webkit [186943] by
-
- 3 edits in branches/safari-601.1-branch/Source/WebKit/mac
Merge r186909. rdar://problem/21802456
- 10:33 PM Changeset in webkit [186942] by
-
- 3 edits in branches/safari-601.1-branch/Source/WebCore
Merge r186895. rdar://problem/21692212
- 10:33 PM Changeset in webkit [186941] by
-
- 9 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r186887. rdar://problem/21692212
- 10:33 PM Changeset in webkit [186940] by
-
- 3 edits in branches/safari-601.1-branch/Source/WebCore
Merge r186879. rdar://problem/21758704
- 10:33 PM Changeset in webkit [186939] by
-
- 6 edits in branches/safari-601.1-branch/Source
Merge r186878. rdar://problem/21758722
- 10:33 PM Changeset in webkit [186938] by
-
- 4 edits3 adds in branches/safari-601.1-branch
Merge r186868. rdar://problem/21758704
- 10:32 PM Changeset in webkit [186937] by
-
- 5 edits2 adds in branches/safari-601.1-branch
Merge r186865. rdar://problem/21823835
- 10:32 PM Changeset in webkit [186936] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merge r186857. rdar://problem/21840845
- 10:32 PM Changeset in webkit [186935] by
-
- 4 edits4 adds in branches/safari-601.1-branch
Merge r186840. rdar://problem/21823681
- 10:32 PM Changeset in webkit [186934] by
-
- 3 edits in branches/safari-601.1-branch/Source/WebCore
Merge r186837. rdar://problem/21774358
- 10:32 PM Changeset in webkit [186933] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebCore
Merge r186828. rdar://problem/19925709
- 10:32 PM Changeset in webkit [186932] by
-
- 5 edits2 adds in branches/safari-601.1-branch
Merge r186827. rdar://problem/21736723
- 10:32 PM Changeset in webkit [186931] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r186814. rdar://problem/21605505
- 10:32 PM Changeset in webkit [186930] by
-
- 2 edits in branches/safari-601.1-branch/Source/WebKit2
Merge r186812. rdar://problem/21818117
- 10:32 PM Changeset in webkit [186929] by
-
- 4 edits15 adds in branches/safari-601.1-branch
Merge r186807. rdar://problem/21782350
- 10:32 PM Changeset in webkit [186928] by
-
- 5 edits in branches/safari-601.1-branch/Source
Merge r186786. rdar://problem/9222837
- 8:59 PM Changeset in webkit [186927] by
-
- 4 edits in trunk/Tools
webkit-patch uses incorrect credentials from keychain to login until account lockout
https://bugs.webkit.org/show_bug.cgi?id=146923
Patch by Dean Johnson <dean_johnson@apple.com> on 2015-07-16
Reviewed by Daniel Bates.
When
webkit-patch uploadasks for login credentials for bugs.webkit.org, if you
provide incorrect credentials then ask for them to be saved to the keychain
webkit-patch will then use those incorrect credentials until 5 total attempts
have been made to log in. This will lock the user out of Bugzilla for a
half hour.
- Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.authenticate): Added argument to read_credentials() that
passes in whether or not to use stored credentials.
- Scripts/webkitpy/common/net/credentials.py:
(Credentials.read_credentials): Added optional argument 'use_stored_credentials'
that specifies whether or not to use credentials stored on the system. If it
does, we do not auto-fill credentials since either the credentials caused
the failure, or they weren't used in the first place so there is no reason
to try and use them again if a failure happened.
- Scripts/webkitpy/common/net/credentials_unittest.py: Added unit test for newly added
use_stored_credentials argument.
(test_do_not_use_stored_credentials): Added unit test to make sure functions that
retrieve username/password information from the local system (environment, Git, keychain,
keyring) are never called. It also tests that we get back our mocked username and password.
(test_do_not_use_stored_credentials.MockKeyring): Mock keyring
(test_do_not_use_stored_credentials.MockKeyring.get_password): Assert this is never called.
(test_do_not_use_stored_credentials.FakeCredentials): Mock credentials
(test_do_not_use_stored_credentials.FakeCredentials._credentials_from_keychain): Assert this
is never called.
(test_do_not_use_stored_credentials.FakeCredentials._credentials_from_environment): Ditto
(test_do_not_use_stored_credentials.FakeCredentials._offer_to_store_credentials_in_keyring): Ditto
(test_do_not_use_stored_credentials.FakeUser): Mock the User class
(test_do_not_use_stored_credentials.FakeUser.prompt): Returns a username to assert against.
(test_do_not_use_stored_credentials.FakeUser.prompt_password): Returns a password to assert
against.
- 8:59 PM Changeset in webkit [186926] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION (r186218) ScriptTimelineRecord attempts to access null property
https://bugs.webkit.org/show_bug.cgi?id=147025
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-16
Reviewed by Timothy Hatcher.
The issue here was two ScriptTimelineRecord's were created for the same
profile payload. When the first ScriptTimelineRecord processed the
payload to create a Profile we modified the payload, then when the
second ScriptTimelineRecord tries to process the payload the data is
in an unexpected state and it crashes.
The solution here is to stash the result on the payload, so when the
payload is shared we can just immediately jump to the resulting Profile.
The longer term solution will be to share higher level objects and not
attempt to process the payload multiple times. That is tracked by:
<https://webkit.org/b/147029> Web Inspector: Better share objects generated from timeline events (Records)
- UserInterface/Models/ScriptTimelineRecord.js:
(WebInspector.ScriptTimelineRecord.prototype._initializeProfileFromPayload):
When processing the profile payload, store the Profile on the payload
so if another ScriptTimelineRecord has that payload they can avoid
re-processing it.
- 8:55 PM Changeset in webkit [186925] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Total Size of Resources number in dashboard is wrong (does not update during load)
https://bugs.webkit.org/show_bug.cgi?id=147027
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-16
Reviewed by Timothy Hatcher.
- UserInterface/Models/DefaultDashboard.js:
(WebInspector.DefaultDashboard.prototype._resourceSizeDidChange):
Restore implementation of callback from r183328 to update total resource
size as resources are downloaded.
- 8:55 PM Changeset in webkit [186924] by
-
- 2 edits in trunk/Source/WebKit2
[Mac] Web Inspector toolbar can be covered by the Safari tab bar when docked to the right
https://bugs.webkit.org/show_bug.cgi?id=146994
Reviewed by Timothy Hatcher.
WebInspectorProxy contained logic which ignored the next frame change notification from the inspected view,
whenever it updated the frames of both the Inspector view and inspected view. This patch removes that logic,
as it prevented the Inspector's frame from being adjusted after changes to the browser's top content inset.
- UIProcess/mac/WebInspectorProxyMac.mm:
(-[WKWebInspectorProxyObjCAdapter ignoreNextInspectedViewFrameDidChange]): Deleted.
(-[WKWebInspectorProxyObjCAdapter inspectedViewFrameDidChange:]): Deleted.
(WebKit::WebInspectorProxy::inspectedViewFrameDidChange): Deleted.
- 8:33 PM Changeset in webkit [186923] by
-
- 3 edits in trunk/Source/JavaScriptCore
Unreviewed, fix build for newer LLVMs.
- llvm/LLVMHeaders.h:
- llvm/library/LLVMExports.cpp:
- 7:56 PM Changeset in webkit [186922] by
-
- 2 edits in trunk/Tools
Unreviewed, remove my redundant email information.
- Scripts/webkitpy/common/config/contributors.json:
- 7:45 PM Changeset in webkit [186921] by
-
- 2 edits in trunk/Tools
Unreviewed. Add Hyungwook Lee as a committer.
- Scripts/webkitpy/common/config/contributors.json:
- 7:27 PM Changeset in webkit [186920] by
-
- 2 edits in trunk/Source/JavaScriptCore
RegExp::match() should set m_state to ByteCode if compilation fails.
https://bugs.webkit.org/show_bug.cgi?id=147023
Reviewed by Michael Saboff.
A RegExp has a YarrCodeBlock that has 4 MacroAssemblerCodeRefs for compiled code.
If one of these compilations succeeds, RegExp::m_state will be set to JITCode.
Subsequently, if RegExp tries to compile another one of these but fails, m_state
will be left untouched i.e. it still says JITCode. As a result, when
RegExp::match() later tries to execute the non-existant compiled code, it will
crash.
The fix is to downgrade m_state to ByteCode if RegExp ever fails to compile.
This failure should be rare. We'll do the minimal work here to fix the issue and
keep an eye on the perf bots. If perf regresses, we can do some optimization work then.
This issue is difficult to test for since it either requires a low memory condition
to trigger a failed RegExp compilation at the right moment, or for the RegExp to
succeed compilation in the MatchedOnly mode but fail in IncludeSubpatterns mode.
Instead, I manually tested it by instrumenting RegExp::compile() to fail once in every
10 compilation attempts.
- runtime/RegExp.cpp:
(JSC::RegExp::compile):
(JSC::RegExp::compileMatchOnly):
- 5:29 PM Changeset in webkit [186919] by
-
- 4 edits in trunk/Source
Web Inspector: [Mac] Save dialog not working when inspector is docked
https://bugs.webkit.org/show_bug.cgi?id=146991
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-16
Reviewed by Sam Weinig.
Source/WebKit/mac:
- WebCoreSupport/WebInspectorClient.mm:
(WebInspectorFrontendClient::save):
(-[WebInspectorWindowController webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles:]):
When the window is nil (docked) use a non-window version of running the dialog.
Source/WebKit2:
- UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::runOpenPanel):
(WebKit::WebInspectorProxy::platformSave):
When the window is nil (docked) use a non-window version of running the dialog.
- 4:36 PM Changeset in webkit [186918] by
-
- 5 edits in trunk/Source/WebCore
Media Session: handle 'Transient' and 'Transient Solo' interruption events https://bugs.webkit.org/show_bug.cgi?id=146840
Reviewed by Eric Carlson.
- Modules/mediasession/MediaSession.cpp:
(WebCore::MediaSession::handleDuckInterruption): Added stub.
(WebCore::MediaSession::handleUnduckInterruption): Added stub.
(WebCore::MediaSession::handlePauseInterruption): Pause active media elements. We use our helper method to do this
"safely" since pausing a media element can change the collection we're iterating.
(WebCore::MediaSession::handleUnpauseInterruption): Unpause active media elements. We use our helper method to do this
"safely" since unpausing a media element can change the collection we're iterating.
(WebCore::MediaSession::togglePlayback): Factored out "safe" iteration into a helper method elsewhere.
(WebCore::MediaSession::safelyIterateActiveMediaElements): Safely iterate through the collection of active media
elements.
- Modules/mediasession/MediaSession.h:
- Modules/mediasession/MediaSessionManager.cpp:
(WebCore::MediaSessionManager::MediaSessionManager): On Mac, register for platform-specific interruptions.
(WebCore::MediaSessionManager::didReceiveStartOfInterruptionNotification): Implemented section 4.5.2 of Media Session spec.
(WebCore::MediaSessionManager::didReceiveEndOfInterruptionNotification): Ditto.
- Modules/mediasession/MediaSessionManager.h:
- 4:22 PM Changeset in webkit [186917] by
-
- 2 edits6 adds in trunk/Source/WebCore
Media Session: add support for platform-specific interruption providers
https://bugs.webkit.org/show_bug.cgi?id=147008
Reviewed by Eric Carlson.
- WebCore.xcodeproj/project.pbxproj: Include new source files.
- platform/mediasession/MediaSessionInterruptionProvider.cpp: Added base class to be used by MediaSessionManager to listen for interruption notifications.
(WebCore::MediaSessionInterruptionProvider::MediaSessionInterruptionProvider): Begin listening for interruptions
upon construction.
(WebCore::MediaSessionInterruptionProvider::~MediaSessionInterruptionProvider): Stop listening for interruptions
before destruction.
(WebCore::MediaSessionInterruptionProvider::beginListeningForInterruptions): To be overridden by subclasses.
(WebCore::MediaSessionInterruptionProvider::stopListeningForInterruptions): To be overridden by subclasses.
- platform/mediasession/MediaSessionInterruptionProvider.h: Added.
(WebCore::MediaSessionInterruptionProviderClient::~MediaSessionInterruptionProviderClient):
(WebCore::MediaSessionInterruptionProvider::client):
- platform/mediasession/mac/MediaSessionInterruptionProviderMac.h: Added for providing Mac-specific interruptions.
(WebCore::MediaSessionInterruptionProviderMac::~MediaSessionInterruptionProviderMac):
- platform/mediasession/mac/MediaSessionInterruptionProviderMac.mm: Added stubs.
(WebCore::MediaSessionInterruptionProviderMac::beginListeningForInterruptions):
(WebCore::MediaSessionInterruptionProviderMac::stopListeningForInterruptions):
- 4:14 PM Changeset in webkit [186916] by
-
- 10 edits in trunk/Source
Add shrink-wrapped link highlights
https://bugs.webkit.org/show_bug.cgi?id=147021
<rdar://problem/21643094>
Reviewed by Enrica Casucci.
- Shared/InteractionInformationAtPosition.cpp:
(WebKit::InteractionInformationAtPosition::encode):
(WebKit::InteractionInformationAtPosition::decode):
- Shared/InteractionInformationAtPosition.h:
Add a TextIndicator to InteractionInformationAtPosition.
Make use of some new C++ features.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView willPresentPreviewViewController:forPosition:inSourceView:]):
(-[WKContentView didDismissPreviewViewController:committing:]):
Make use of the TextIndicator (if we have one) to show a shrink-wrapped
snapshot of the link.
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::getPositionInformation):
Build a TextIndicator for the link if possible.
- WebCore.xcodeproj/project.pbxproj:
- page/TextIndicator.cpp:
(WebCore::TextIndicator::createWithRange):
(WebCore::TextIndicator::createWithSelectionInFrame):
- page/TextIndicator.h:
Add a margin parameter to TextIndicator; this inflates each text rect
by the given amount.
Use snapshotFrameRect instead of snapshotSelection because we really
want an image that exactly fits textBoundingRectInDocumentCoordinates,
and snapshotSelection comes up with selection rects in different ways,
especially on iOS (where it comes up with nothing!).
For now, avoid forcing black text or painting only the selection on iOS.
Eventually, we should have TextIndicator options for these things that
are then respected at the presentation layer.
- 3:57 PM Changeset in webkit [186915] by
-
- 2 edits in trunk/Tools
Added myself to the list of contributors.
Reviewed by Brent Fulgham.
- Scripts/webkitpy/common/config/contributors.json:
- 3:50 PM Changeset in webkit [186914] by
-
- 3 edits in branches/safari-601.1-branch/Source/WebCore
Merged r186764. rdar://problem/9222837
- 3:27 PM Changeset in webkit [186913] by
-
- 12 edits in trunk/Source
Media Session: remove plumbing for delivering start/end-of-interruption events
https://bugs.webkit.org/show_bug.cgi?id=147005
Reviewed by Eric Carlson.
Instead of receiving interruptions through WebKit, we will provide platform-specific implementations in WebCore
so the same behavior is available to all clients.
WebCore:
- Modules/mediasession/MediaSessionEvents.h:
- page/Page.cpp:
- page/Page.h:
WebKit:
- UIProcess/API/C/WKPage.cpp:
- UIProcess/API/C/WKPagePrivate.h:
- UIProcess/WebPageProxy.cpp:
- UIProcess/WebPageProxy.h:
- WebProcess/WebPage/WebPage.cpp:
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 3:08 PM Changeset in webkit [186912] by
-
- 8 edits in trunk
[Content Extensions] Cache domain actions
https://bugs.webkit.org/show_bug.cgi?id=146817
Reviewed by Benjamin Poulain.
Source/WebCore:
Right now we run regular expressions on the domain every time we have any rules that match with if-domain or unless-domain.
This caches the results of running regular expressions on the domain of the main document's url so we only need to
run those regular expressions when the main document changes domain. We also spend less time adding unused actions into HashSets.
All behavior is covered by existing api tests, but I added some to explicitly test if-domain and unless-domain with multiple load types.
- contentextensions/ContentExtension.cpp:
(WebCore::ContentExtensions::ContentExtension::globalDisplayNoneStyleSheet):
(WebCore::ContentExtensions::ContentExtension::cachedDomainActions):
- contentextensions/ContentExtension.h:
(WebCore::ContentExtensions::ContentExtension::identifier):
(WebCore::ContentExtensions::ContentExtension::compiledExtension):
- contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad):
- contentextensions/DFABytecodeInterpreter.cpp:
(WebCore::ContentExtensions::getJumpDistance):
(WebCore::ContentExtensions::matchesDomain):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretTestFlagsAndAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::actionsForDefaultStylesheetFromDFARoot):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretWithDomains):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpret):
- contentextensions/DFABytecodeInterpreter.h:
Tools:
- TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
(TestWebKitAPI::TEST_F):
Test if-domain and unless-domain with multiple load types.
- 2:54 PM Changeset in webkit [186911] by
-
- 3 edits2 adds in trunk
Fix disappearing position:fixed elements in fixed layout mode
https://bugs.webkit.org/show_bug.cgi?id=147019
Reviewed by Tim Horton.
Source/WebCore:
Test: compositing/fixed-with-fixed-layout.html
When in fixed layout mode, and being scaled down, viewportConstrainedVisibleContentRect() is
the wrong thing to use to determine if position:fixed elements are clipped out. In this case,
use the simpler document bounds (before scaling).
In the long term, there needs to be an equivalent of viewportConstrainedVisibleContentRect()
that gives an appropriate rect that can be used here.
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition):
LayoutTests:
Test with four fixed elements in fixed layout mode.
- compositing/fixed-with-fixed-layout-expected.txt: Added.
- compositing/fixed-with-fixed-layout.html: Added.
- 2:51 PM Changeset in webkit [186910] by
-
- 12 edits1 add in trunk
[Content extensions] Combine suffixes when generating NFAs
https://bugs.webkit.org/show_bug.cgi?id=146961
Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-07-16
Reviewed by Alex Christensen.
Source/WebCore:
In this patch, I add a mechanism very similar to the prefix tree
but for the suffix (called a reverse suffix tree here).
The idea is here is to reuse the existing NFA nodes when generating
a chain of suffix Term that were already generated previously.
When generating a disjunction ending with the same suffix, we now
have the same trailing NFA nodes for both sides of the disjunction.
Mixing the prefix and suffix generation can be tricky, we do not want
transitions from a pattern to creep into the suffix of an other.
To avoid any conflict, the rules here are very simple:
-Only use the reverse suffix tree for terms without actions
up to a leaf term with actions.
This rule ensure that no action will accidentally make its way
to an other rule by resuing a vertex of the reverse suffix tree.
-Only use the reverse suffix tree for chains of terms in which
each term only has zero or one following term.
With this condition, when taking any vertex of the reverse suffix
tree, there is only one edge that move out of that vertex when reading
from left to right.
For any vertex, there is only one possible string generated
left-to-right, a single suffix.
This is overly restrictive but it is fast, easier to verify, and it works
well in practice.
For all the more complicated cases, we can count on the Minimizer to
find a better solution.
With all the simple suffixes merged, our NFAs are smaller, which
let us combine more patterns.
The DFAs are also smaller and faster to produce since their size
is relative to the NFA sizes.
Overall, I get the following gains:
-Chris's test case:
compile time -40%.
bytecode size -14%.
-Armand's test case:
compile time -53%.
bytecode size -13%.
- WebCore.xcodeproj/project.pbxproj:
- contentextensions/CombinedURLFilters.cpp:
(WebCore::ContentExtensions::ActiveSubtree::ActiveSubtree):
(WebCore::ContentExtensions::generateInfixUnsuitableForReverseSuffixTree):
(WebCore::ContentExtensions::generateSuffixWithReverseSuffixTree):
(WebCore::ContentExtensions::clearReverseSuffixTree):
(WebCore::ContentExtensions::generateNFAForSubtree):
- contentextensions/DFA.cpp:
(WebCore::ContentExtensions::DFA::debugPrintDot):
Forgot to close a tag, dot was not happy.
- contentextensions/HashableActionList.h: Added.
(WebCore::ContentExtensions::HashableActionList::HashableActionList):
(WebCore::ContentExtensions::HashableActionList::isEmptyValue):
(WebCore::ContentExtensions::HashableActionList::isDeletedValue):
(WebCore::ContentExtensions::HashableActionList::operator==):
(WebCore::ContentExtensions::HashableActionList::operator!=):
(WebCore::ContentExtensions::HashableActionListHash::hash):
(WebCore::ContentExtensions::HashableActionListHash::equal):
We need a way to group reverse suffix tree by their terminal actions.
This new hash structure lets us find unique vertex for a list of actions
in any order.
- contentextensions/ImmutableNFANodeBuilder.h:
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::isValid):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::nodeId):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::addTransition):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::addEpsilonTransition):
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::ImmutableNFANodeBuilder): Deleted.
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::~ImmutableNFANodeBuilder): Deleted.
(WebCore::ContentExtensions::ImmutableNFANodeBuilder::operator=): Deleted.
- contentextensions/Term.h:
(WebCore::ContentExtensions::Term::generateGraph):
(WebCore::ContentExtensions::Term::generateSubgraphForAtom):
Node building changes a bit.
Previously, it was assumed nodes are always built from left to right.
Getting the node on the right was done by providing the left node and the term
doing the transition.
Now we have both left to right and right to left generation.
The right-to-left has a specific property: no edge can be added after
it's initial term (rule 2 of our reverse suffix tree). This simplifies
things a bit since we can finalize all the nodes in the suffix tree.
All we need is to keep their ID to be able to link new nodes
to the reverse suffix tree.
Source/WTF:
- wtf/Vector.h:
(WTF::minCapacity>::Vector):
(WTF::=):
Copying a vector with a different inline capacity was broken due to
the addition of MinimumCapacity.
This feature was needed by this patch so I fixed WTF.
Tools:
- TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:
(TestWebKitAPI::compareContents):
- TestWebKitAPI/Tests/WebCore/DFAMinimizer.cpp:
- 2:50 PM Changeset in webkit [186909] by
-
- 3 edits in trunk/Source/WebKit/mac
[iOS] Expose contentsSizeRespectingOverflow() via WebView so UIWebView can use it
https://bugs.webkit.org/show_bug.cgi?id=146924
WebKit part of rdar://problem/21802456
Reviewed by Tim Horton.
Expose the FrameView's contentsSizeRespectingOverflow() via WebView, for use
by UIKit.
- WebView/WebView.mm:
(-[WebView _contentsSizeRespectingOverflow]):
- WebView/WebViewPrivate.h:
- 2:40 PM Changeset in webkit [186908] by
-
- 3 edits in trunk/Source/WebInspectorUI
[GTK] Web Inspector: Further optimize the weight and time icons taken back to the toolbar dashboard for the GTK+ port
https://bugs.webkit.org/show_bug.cgi?id=147010
SVG images optimized with a combination of sed replacements, the
usage of the scour tool (http://www.codedread.com/scour/) and a
forked version of the svgo tool (https://github.com/tanty/svgo).
Also, added the class attribute to the shape elements following
the convention used in Apple's images.
Reviewed by Martin Robinson.
- UserInterface/Images/gtk/Time.svg: Optimized.
- UserInterface/Images/gtk/Weight.svg: Optimized.
- 1:24 PM Changeset in webkit [186907] by
-
- 2 edits in trunk/Source/WebCore
Rolling out part of r186895 until rdar://problem/21861167 is resolved.
https://bugs.webkit.org/show_bug.cgi?id=146976
- platform/network/cf/CookieJarCFNet.cpp:
(WebCore::createCookies): Don’t use this new SPI quite yet.
- 1:19 PM Changeset in webkit [186906] by
-
- 25 edits in trunk
Unreviewed, roll out http://trac.webkit.org/changeset/186903. It broke the build.
Source/WebCore:
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/DOMWrapperWorld.h:
(WebCore::currentWorld):
(WebCore::worldForDOMObject): Deleted.
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSCustomEventCustom.cpp:
(WebCore::JSCustomEvent::detail): Deleted.
- bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::data):
- bindings/js/JSPopStateEventCustom.cpp:
(WebCore::JSPopStateEvent::state):
- dom/CustomEvent.cpp:
(WebCore::CustomEvent::initCustomEvent):
(WebCore::CustomEvent::eventInterface):
(WebCore::CustomEvent::trySerializeDetail): Deleted.
- dom/CustomEvent.h:
- dom/CustomEvent.idl:
- dom/MessageEvent.cpp:
(WebCore::MessageEvent::initMessageEvent):
(WebCore::MessageEvent::data):
(WebCore::MessageEvent::trySerializeData): Deleted.
- dom/MessageEvent.h:
- dom/PopStateEvent.cpp:
(WebCore::PopStateEvent::create):
(WebCore::PopStateEvent::eventInterface):
(WebCore::PopStateEvent::trySerializeState): Deleted.
- dom/PopStateEvent.h:
- testing/Internals.cpp:
(WebCore::Internals::deserializeBuffer):
(WebCore::Internals::setUsesOverlayScrollbars):
(WebCore::Internals::isFromCurrentWorld): Deleted.
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- fast/events/constructors/custom-event-constructor-expected.txt:
- fast/events/constructors/custom-event-constructor.html:
- fast/events/event-leak-objects-expected.txt:
- fast/events/event-leak-objects.html:
- fast/events/event-properties-gc-expected.txt:
- fast/events/event-properties-gc.html:
- 1:07 PM Changeset in webkit [186905] by
-
- 1 edit2 adds in trunk/LayoutTests
Rebaseline test for Windows.
- platform/win/fast/shrink-wrap: Added.
- platform/win/fast/shrink-wrap/rect-shrink-wrap-expected.txt: Added.
- 1:06 PM Changeset in webkit [186904] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r186464): [SOUP] ASSERTION FAILED: !m_messageReceiverMapCount when closing any tab
https://bugs.webkit.org/show_bug.cgi?id=147006
Reviewed by Anders Carlsson.
Remove the message receiver before it is deallocated.
- UIProcess/Network/CustomProtocols/soup/CustomProtocolManagerProxySoup.cpp:
(WebKit::CustomProtocolManagerProxy::~CustomProtocolManagerProxy):
- 12:30 PM Changeset in webkit [186903] by
-
- 20 edits5 adds in trunk
Remove leak of objects between isolated worlds on custom events, message events, and pop state events.
https://bugs.webkit.org/show_bug.cgi?id=118884
Patch by Keith Miller <keith_miller@apple.com> on 2015-07-16
Reviewed by Filip Pizlo.
Source/WebCore:
Tests: fast/events/event-leak-objects.html
fast/events/event-properties-gc.html
Fixes an issue where objects passed as certain properties of events could cross isolated worlds. This
was fixed by checking that any object passed by an event must be serializable or originate from the same
isolated world as the one it is currently being accessed in. In the case of MessageEvents and PopStateEvents we
cache the values of the data and state properties, respectively, as they may be a deserialized object. In case
an object was deserialized in a world with elevated privileges we also check the cached value is from the same
world, if it is from a different world we recompute it. For testing purposes, I added a new function to Internals
that determines whether a JSObject originated in the current world.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/DOMWrapperWorld.h:
(WebCore::worldForDOMObject):
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSCustomEventCustom.cpp: Copied from Source/WebCore/dom/CustomEvent.cpp.
(WebCore::JSCustomEvent::detail):
- bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::data):
- bindings/js/JSPopStateEventCustom.cpp:
(WebCore::JSPopStateEvent::state):
- dom/CustomEvent.cpp:
(WebCore::CustomEvent::initCustomEvent):
(WebCore::CustomEvent::trySerializeDetail):
- dom/CustomEvent.h:
- dom/CustomEvent.idl:
- dom/MessageEvent.cpp:
(WebCore::MessageEvent::initMessageEvent):
(WebCore::MessageEvent::trySerializeData):
- dom/MessageEvent.h:
- dom/PopStateEvent.cpp:
(WebCore::PopStateEvent::trySerializeState):
- dom/PopStateEvent.h:
- testing/Internals.cpp:
(WebCore::Internals::isFromCurrentWorld):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
These tests ensure ensure objects are not leaked across isolated worlds and that those properties are not prematurely
garbage collected.
- fast/events/constructors/custom-event-constructor-expected.txt:
- fast/events/constructors/custom-event-constructor.html:
- fast/events/event-leak-objects-expected.txt: Added.
- fast/events/event-leak-objects.html: Added.
- fast/events/event-properties-gc-expected.txt: Added.
- fast/events/event-properties-gc.html: Added.
- 12:16 PM Changeset in webkit [186902] by
-
- 5 edits in branches/safari-600.1.4.17-branch/Source
Versioning.
- 11:31 AM Changeset in webkit [186901] by
-
- 1 edit1 add in trunk/Source/WebInspectorUI
[GTK] Web Inspector: Add new Network icon for the GTK+ port
https://bugs.webkit.org/show_bug.cgi?id=147002
Reviewed by Martin Robinson.
- UserInterface/Images/gtk/Network.svg: Added.
Icon for the new Network tab.
- 11:23 AM Changeset in webkit [186900] by
-
- 2 edits in trunk/LayoutTests
Mark fast/canvas/canvas-too-large-to-draw.html as crashing on El Capitan
Fix is tracked by <rdar://problem/21857102>.
- platform/mac/TestExpectations: Mark test as crashing:
- fast/canvas/canvas-too-large-to-draw.html
- 10:52 AM Changeset in webkit [186899] by
-
- 2 edits in trunk/Source/WebKit
[Win] Unreviewed gardening.
- WebKit.vcxproj/WebKit/WebKit.vcxproj.filters: Move file into the
appropriate category in the project.
- 10:42 AM Changeset in webkit [186898] by
-
- 2 edits in trunk/Source/WebKit/win
[Win] Gross workaround to fix build after r186858.
- WebView.cpp:
(WebView::unused5): Force export of WebCore symbol through
WebKit.dll.
- 10:39 AM Changeset in webkit [186897] by
-
- 2 edits in trunk/Source/WebKit2
Review feedback followup for:
REGRESSION(r186088): Crash under WebKit::WebPageProxy::didFailLoadForFrame
<rdar://problem/21692212> and https://bugs.webkit.org/show_bug.cgi?id=146988
- UIProcess/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::refView): CFRetain instead of Obj-C retain.
(WebKit::PageClientImpl::derefView): CFRelease instead of Obj-C release.
- 10:26 AM Changeset in webkit [186896] by
-
- 1 edit1 add in trunk/Source/WebInspectorUI
[GTK] Web Inspector: Add new composite record icon for the GTK+ port
https://bugs.webkit.org/show_bug.cgi?id=146998
Reviewed by Martin Robinson.
- UserInterface/Images/gtk/TimelineRecordComposite.svg: Added.
New composite record icon.
- 10:25 AM Changeset in webkit [186895] by
-
- 3 edits in trunk/Source/WebCore
WebKit document.cookie mis-parsing.
rdar://problem/21715050 and https://bugs.webkit.org/show_bug.cgi?id=146976
Reviewed by Sam Weinig.
- platform/network/cf/CookieJarCFNet.cpp:
(WebCore::createCookies): Use new SPI if available.
(WebCore::setCookiesFromDOM):
- platform/spi/cf/CFNetworkSPI.h:
- 10:21 AM Changeset in webkit [186894] by
-
- 19 edits in trunk/Source/WebCore
Headers that use WEBCORE_EXPORT should include PlatformExportMacros.h
https://bugs.webkit.org/show_bug.cgi?id=146984
Reviewed by Daniel Bates.
- contentextensions/DFA.h:
- dom/ContextDestructionObserver.h:
- dom/DeviceOrientationData.h:
- dom/ExceptionCodePlaceholder.h:
- editing/cocoa/HTMLConverter.h:
- html/track/AudioTrack.h:
- loader/FrameLoaderStateMachine.h:
- loader/appcache/ApplicationCacheHost.h:
- loader/cache/CachedResourceHandle.h:
- platform/URL.h:
- platform/animation/Animation.h:
- platform/audio/AudioHardwareListener.h:
- platform/audio/AudioSession.h:
- platform/graphics/transforms/AffineTransform.h:
- platform/network/Credential.h:
- platform/network/CredentialBase.h:
- platform/network/ResourceHandleClient.h:
- platform/network/mac/AuthenticationMac.h:
- 8:34 AM Changeset in webkit [186893] by
-
- 2 edits in trunk/Source/WebKit2
[Linux] Seccomp: fix -Wmismatched-tags
https://bugs.webkit.org/show_bug.cgi?id=146990
Reviewed by Žan Doberšek.
WebProcessCreationParameters is a struct nowadays, not a class, so declare it appropriately.
- Shared/linux/SeccompFilters/SyscallPolicy.h:
- 3:29 AM Changeset in webkit [186892] by
-
- 2 edits in trunk/Source/WebKit2
REGRESSION(r185415): [GTK] Browsers crash when an input method is enabled
https://bugs.webkit.org/show_bug.cgi?id=146639
Reviewed by Žan Doberšek.
In r185415 I assumed that preedit signals were always emitted
after a keypress was handled by the WebView. However, some input
methods handle the keyboard events before the WebView, and preedit
signals are emitted but no key event has been handled by the
WebView. So, instead of asserting when filter key event completion
handler is nullptr, we should check whether the current event was
generated for a WebView filter request or not. In case the
completion handler is nullptr, we send the event directly to the
page, instead of going through the WebView, since there won't be
editing commands for those events anyway.
- UIProcess/gtk/InputMethodFilter.cpp:
(WebKit::InputMethodFilter::handleKeyboardEvent):
(WebKit::InputMethodFilter::handleKeyboardEventWithCompositionResults):
- 1:57 AM Changeset in webkit [186891] by
-
- 4 edits2 adds2 deletes in trunk
Web Inspector: update $$() to return an Array
https://bugs.webkit.org/show_bug.cgi?id=146964
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-07-16
Reviewed by Brian Burg.
Source/WebCore:
Test: inspector/console/command-line-api.html
- inspector/CommandLineAPIModuleSource.js:
Update $$(...) to return an array.
Also InjectedScriptHost.type was renamed to subtype
a while ago.
LayoutTests:
- inspector/console/command-line-api-expected.txt: Added.
- inspector/console/command-line-api.html: Added.
Add back a command line api test.
- platform/efl/inspector/console/command-line-api-expected.txt: Removed.
- platform/mac/inspector/console/command-line-api-expected.txt: Removed.
Remove old platform expected results for the old version of this test.
- platform/win/TestExpectations:
Speculatively skipping on Windows since other inspector/console tests are skipped.
