Timeline



Oct 3, 2015:

7:38 PM Changeset in webkit [190547] by commit-queue@webkit.org
  • 5 edits in trunk/Source

"Plug-in is blocked" message doesn't draw correctly
https://bugs.webkit.org/show_bug.cgi?id=149741
<rdar://problem/22920949>

Patch by Conrad Shultz and Ricky Mondello.

Patch by Ricky Mondello <Ricky Mondello> on 2015-10-03
Reviewed by Anders Carlsson.

Source/WebCore:

No new tests are added.

Add PluginData API to check whether a MIME type is supported, regardless of plug-in visibility.

  • plugins/PluginData.cpp:

(WebCore::PluginData::getWebVisibleMimesAndPluginIndices): Adopt getMimesAndPluginIndiciesForPlugins.
(WebCore::PluginData::getMimesAndPluginIndices): Added.
(WebCore::PluginData::getMimesAndPluginIndiciesForPlugins): Essentially factored out of

getWebVisibleMimesAndPluginIndices.

(WebCore::PluginData::supportsMimeType): Added. Somewhat similar to preexisting supportsWebVisibleMimeType.

  • plugins/PluginData.h: Declare supportsMimeType.

Source/WebKit2:

If a WebKit client sets plug-in X to not be visible to the web, that doesn't mean we shouldn't consult
that plug-in when determining what kind of object type an object is. Properly classifying a non-web-visible
Netscape plug-in as such allows its bounds to properly measured, allowing it to be drawn properly.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::objectContentType): Use PluginData's supportsMimeType, rather than its

supportsWebVisibleMimeType, when determining the ObjectContentType for a MIME type on a url.

6:45 PM Changeset in webkit [190546] by commit-queue@webkit.org
  • 56 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r190522.
https://bugs.webkit.org/show_bug.cgi?id=149787

Caused a lot of leaks (Requested by ap on #webkit).

Reverted changeset:

"Unreviewed, rolling back in r190450"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/190522

5:43 PM Changeset in webkit [190545] by ap@apple.com
  • 2 edits in trunk/LayoutTests

fast/events/overflow-scroll-fake-mouse-move.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=138697

Reviewed by Brent Fulgham.

  • fast/events/overflow-scroll-fake-mouse-move.html:
3:13 AM Changeset in webkit [190544] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

Make the test added in r190530 not time out on the ports that don't enable shadow DOM.

Call waitUntilDone after calling attachShadow so that an exception thrown by calling attachShadow
will prevent waitUntilDone from getting called on those ports.

  • fast/shadow-dom/insert-child-to-assigned-node.html:

Oct 2, 2015:

10:04 PM Changeset in webkit [190543] by dbates@webkit.org
  • 4 edits
    2 adds in trunk/Tools

Add iOS 9 Simulator builders and testers to WebKit Bot Watcher's Dashboard
https://bugs.webkit.org/show_bug.cgi?id=149769

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/IOS9Simulator@2x.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(table.queue-grid tr.platform.ios-simulator-9 img.logo):

8:18 PM Changeset in webkit [190542] by Matt Baker
  • 13 edits in trunk/Source

Web Inspector: Add breakpoint option to ignore n times before stopping
https://bugs.webkit.org/show_bug.cgi?id=147664

Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

  • debugger/Breakpoint.h:

(JSC::Breakpoint::Breakpoint):
Added ignoreCount and hitCount fields. Cleaned up initializers.

  • debugger/Debugger.cpp:

(JSC::Debugger::hasBreakpoint):
If a breakpoint matches the current text position, increment breakpoint hit count and
compare with ignore count before testing the breakpoint condition.

  • inspector/ScriptBreakpoint.h:

(Inspector::ScriptBreakpoint::ScriptBreakpoint):
Added ignoreCount field. Cleaned up initializers.

  • inspector/ScriptDebugServer.cpp:

(Inspector::ScriptDebugServer::setBreakpoint):
Added ignoreCount field.

  • inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::buildObjectForBreakpointCookie):
(Inspector::InspectorDebuggerAgent::setBreakpointByUrl):
(Inspector::InspectorDebuggerAgent::setBreakpoint):
(Inspector::InspectorDebuggerAgent::continueToLocation):
(Inspector::InspectorDebuggerAgent::didParseSource):
Plumbing for ignoreCount property.

  • inspector/protocol/Debugger.json:

Added optional ignoreCount property to BreakpointOptions object.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:

New strings for breakpoint popover labels.

  • UserInterface/Controllers/BreakpointPopoverController.js:

(WebInspector.BreakpointPopoverController.prototype._createPopoverContent):
Add ignoreCount UI to popover, if backend support exists. UI based on same
feature in Xcode's breakpoint editing dialog.
(WebInspector.BreakpointPopoverController.prototype._popoverIgnoreInputChanged):
User input sanity checks on numeric input.

  • UserInterface/Controllers/DebuggerManager.js:

Listen for changes to breakpoint ignoreCount property.

  • UserInterface/Models/Breakpoint.js:

(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.get ignoreCount):
(WebInspector.Breakpoint.prototype.set ignoreCount):
New property for ignoreCount.
(WebInspector.Breakpoint.prototype.get options):
Added ignoreCount to options object.
(WebInspector.Breakpoint.prototype.get info):
Added ignoreCount to info object.

  • UserInterface/Views/BreakpointPopoverController.css:

(#edit-breakpoint-popover-ignore):
New styles for breakpoint popover.

8:10 PM Changeset in webkit [190541] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/PerformanceTests

Add shared code for a new a graphics benchmark
https://bugs.webkit.org/show_bug.cgi?id=149691

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-10-02
Reviewed by Ryosuke Niwa.

This set of classes will be shared and used by the tests and the runner
of a new graphics benchmark.

  • Animometer/resources: Added.
  • Animometer/resources/algorithm.js: Added.

(Array.prototype.swap): Swaps two elements in an array.
(Heap): Binary Min/Max Heap object
(Heap.prototype._parentIndex): Given the child node index, it returns the parent index.
(Heap.prototype._leftIndex): Given the parent node index, it returns the left node index.
(Heap.prototype._rightIndex): Given the parent node index, it returns the right node index.
(Heap.prototype._childIndex): Given the parent node index, it returns the child index that may violate the heap property.
(Heap.prototype.init): Initializes the heap state.
(Heap.prototype.top): Returns the value stored at the top of the heap.
(Heap.prototype.push): Pushes a new node at the top of the heap.
(Heap.prototype.pop): Extracts the top node of the heap.
(Heap.prototype._bubble): Fixes the heap property by moving upward.
(Heap.prototype._sink): Fixes the heap property by moving downward.
(Heap.prototype.str): Prints the nodes of the heap to a string.
(Heap.prototype.values): Returns the last "size" heap elements values.

(Algorithm.createMinHeap): Creates a size-bounded min-heap object.
(Algorithm.createMaxHeap): Creates a size-bounded max-heap object.

  • Animometer/resources/extensions.js: Added.

(Point): Point object but can be used as size also.
(Point.pointOnCircle): Given, the radius of the circle and the angle of the point, it returns a point object.
(Point.pointOnEllipse): Given, the radiuses of the ellipse and the angle of the point, it returns a point object.
(Point.prototype.get width): Should be called when the point is used as size.
(Point.prototype.get height): Should be called when the point is used as size.
(Point.prototype.get center): Should be called when the point is used as size.
(Point.prototype.add): Returns a new point = this + other.
(Point.prototype.subtract): Returns a new point = this - other.
(Point.prototype.multiply): Returns a new point = this * other.
(Point.prototype.move): Moves the point in a given direction, velocity, time period.

(Insets): Represents borders of a container.
(Insets.prototype.get width): Returns left + right.
(Insets.prototype.get height): Returns top + bottom.

(SimplePromise):
(SimplePromise.prototype.then):
(SimplePromise.prototype.resolve):
Moved from Animometer/runner/resources/benchmark-runner.js since tests also need it.

(Options): Benchmark running options as they are set by the user.

(ProgressBar): Manages a progress bar element. The progress bar is divided into equal length ranges.
(ProgressBar.prototype._progressToPercent): Converts the progress into a percentage.
(ProgressBar.prototype.incRange): Moves to the next range (a range is the running time of a single test).
(ProgressBar.prototype.setPos): Draws the current progress in the current range.

(RecordTable): Shows the results of running a benchmark in a tabular form.
(RecordTable.prototype.clear): Clears the results table.
(RecordTable.prototype._showTitles): Shows the header titles and appends the sub-titles to a queue.
(RecordTable.prototype._showHeader): Shows the table header titles.
(RecordTable.prototype._showEmpty): Shows an empty table cell.
(RecordTable.prototype._showValue): Shows a number value in the results table.
(RecordTable.prototype._showSamples): Shows a button for the sampled data graph.
(RecordTable.prototype._showTest): Shows the results of a single test.
(RecordTable.prototype._showSuite): Shows the results of a single suite.
(RecordTable.prototype.showRecord): Shows a single iteration for a single test.
(RecordTable.prototype.showIterations): Shows the results of all the suites of the iterations.

  • Animometer/resources/sampler.js: Added.

(Statistics.sampleMean): Returns the sample mean.
(Statistics.unbiasedSampleStandardDeviation): Returns the unbiased sample variance (i.e. with Bessel's correction)
(Statistics.geometricMean): Returns the geometric mean.

(Experiment): Represents a sampling experiment.
(Experiment.prototype._init): Called when the object is created and when startSampling() is called.
(Experiment.prototype.startSampling): Called after warmup period. Restarts collecting sampled data points.
(Experiment.prototype.sample): Add a new data point.
(Experiment.prototype.mean): Returns the sample mean for the current sampled data points.
(Experiment.prototype.standardDeviation): Returns the sample standard deviation for the current sampled data points.
(Experiment.prototype.percentage): Returns the percentage of the standard deviation divided to the mean.
(Experiment.prototype.confidenceIntervalDelta): Calculates the confidence delta for the current sampled data given a confidence level.
(Experiment.prototype.concern): Returns the average of the worst given percentage from the sampled data.
(Experiment.prototype.score): Returns a score for the sampled data. It is the geometric mean of sampleMean and concern.

(Sampler): Represents a compound experiment. It manages sampling multiple data points at the same time offset.
(Sampler.prototype.startSampling): Called after warming up period. Restarts collecting sampled data points.
(Sampler.prototype.sample): Add a new data vector at a given time offset.

7:28 PM Changeset in webkit [190540] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Cleanup DebuggerManager, reduce delete and use Maps instead of objects
https://bugs.webkit.org/show_bug.cgi?id=149760

Reviewed by Joseph Pecoraro.

Replaced objects used as hashmaps with Map.

  • UserInterface/Controllers/DebuggerManager.js:

(WebInspector.DebuggerManager.prototype.breakpointsForSourceCode):
(WebInspector.DebuggerManager.prototype.breakpointForIdentifier):
(WebInspector.DebuggerManager.prototype.scriptForIdentifier):
(WebInspector.DebuggerManager.prototype.scriptsForURL):
(WebInspector.DebuggerManager.prototype.get knownNonResourceScripts):
(WebInspector.DebuggerManager.prototype.removeBreakpoint):
(WebInspector.DebuggerManager.prototype.breakpointResolved):
(WebInspector.DebuggerManager.prototype.reset):
(WebInspector.DebuggerManager.prototype.scriptDidParse):
(WebInspector.DebuggerManager.prototype._sourceCodeLocationFromPayload):
(WebInspector.DebuggerManager.prototype._setBreakpoint.didSetBreakpoint):
(WebInspector.DebuggerManager.prototype._setBreakpoint):
(WebInspector.DebuggerManager.prototype._removeBreakpoint.didRemoveBreakpoint):
(WebInspector.DebuggerManager.prototype._removeBreakpoint):

6:13 PM Changeset in webkit [190539] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.40

New tag.

6:11 PM Changeset in webkit [190538] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Roll out r190447. rdar://problem/22865007

6:09 PM Changeset in webkit [190537] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1.46-branch/LayoutTests

Roll out r190438. rdar://problem/22865007

6:07 PM Changeset in webkit [190536] by bshafiei@apple.com
  • 18 edits in branches/safari-601.1.46-branch

Roll out r190434. rdar://problem/22865007

5:50 PM Changeset in webkit [190535] by rniwa@webkit.org
  • 2 edits in trunk/Tools

REGRESSION(r190370): Speedometer spits out an extra console message
https://bugs.webkit.org/show_bug.cgi?id=149720

Unreviewed. Temporarily ignore the console error message.

  • Scripts/webkitpy/performance_tests/perftest.py:

(PerfTest._filter_output):

5:37 PM Changeset in webkit [190534] by Simon Fraser
  • 2 edits
    3 adds in trunk/LayoutTests

New baselines for some compositing tests.

  • platform/ios-simulator/compositing/layer-creation/overlap-animation-clipping-expected.txt: Added.
  • platform/ios-simulator/compositing/layer-creation/overlap-animation-container-expected.txt: Added.
  • platform/ios-simulator/compositing/repaint/become-overlay-composited-layer-expected.txt:
  • platform/ios-simulator/compositing/visible-rect/animated-from-none-expected.txt: Added.
5:33 PM Changeset in webkit [190533] by bshafiei@apple.com
  • 3 edits
    6 copies in tags/Safari-601.3.1

Merged r190418. rdar://problem/22936771

5:26 PM Changeset in webkit [190532] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.3.2

New tag.

4:57 PM Changeset in webkit [190531] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.3.1

New tag.

4:32 PM Changeset in webkit [190530] by Antti Koivisto
  • 3 edits
    2 adds in trunk

Inserting a child to a slot assigned node doesn't trigger repaint
https://bugs.webkit.org/show_bug.cgi?id=149739

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/shadow-dom/insert-child-to-assigned-node.html

  • dom/Node.cpp:

(WebCore::Node::derefEventTarget):
(WebCore::traverseStyleParent):
(WebCore::traverseFirstStyleParent):
(WebCore::Node::updateAncestorsForStyleRecalc):

Traverse in style parent order.

LayoutTests:

  • fast/shadow-dom/insert-child-to-assigned-node-expected.html: Added.
  • fast/shadow-dom/insert-child-to-assigned-node.html: Added.
4:09 PM Changeset in webkit [190529] by fpizlo@apple.com
  • 3 edits
    1 add in trunk/Source/JavaScriptCore

We should not add InferredTypeTables to old Structures
https://bugs.webkit.org/show_bug.cgi?id=149767
rdar://problem/22825526

Patch by Filip Pizlo <fpizlo@apple.com> and Mark Lam <mark.lam@apple.com> on 2015-10-02
Reviewed by Saam Barati.

Our property type inference has an optimization where the absence of an InferredTypeTable is
taken to mean that all properties are TOP. This is great because most Structures come into
existence through reflective stores, and we don't want to waste time inferring types for
those.

But our code was not obeying this rule properly. If we were doing a transition, we would
assume that this meant that we were creating a new structure, and so we would give it an
InferredTypeTable if we were doing a non-reflective store (i.e. context = PutById). But that
same structure could already have been in use prior to us giving it an InferredTypeTable. At
that point bad things will start to happen because the objects created before we created the
table, and the inline caches compiled before then, will have types that disagree with the new
objects and inline caches despite them sharing the same structure and property names.

  • runtime/JSObject.h:

(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):

  • runtime/Structure.h:
  • tests/stress/add-inferred-type-table-to-existing-structure.js: Added.

(foo):
(bar):
(baz):

3:33 PM Changeset in webkit [190528] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Web Inspector: Copying inline style text puts "undefined" in the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=149155

Patch by Devin Rousso <Devin Rousso> on 2015-10-02
Reviewed by Brian Burg.

Source/WebInspectorUI:

CSSStyleDeclarations for inline styles do not have a owner CSSRule, which means
that they do not have a selector or media list. CSS strings must have a selector
and, for inline styles without an owner rule and selector, this was a problem.

  • UserInterface/Models/CSSStyleDeclaration.js:

(WebInspector.CSSStyleDeclaration.prototype.get mediaList):
(WebInspector.CSSStyleDeclaration.prototype.get selectorText):
(WebInspector.CSSStyleDeclaration.prototype.generateCSSRuleString):
Added getters for the list of media queries and selector text with fallbacks
for CSSStyleDeclarations that do not have an owner CSSRule (inline styles).

  • UserInterface/Test.html:

Added CSSMedia include for new inspector/css/generate-css-rule-string.html test.

  • UserInterface/Views/VisualStyleSelectorTreeItem.js:

(WebInspector.VisualStyleSelectorTreeItem.prototype._handleContextMenuEvent):
Removed parameter that no longer exists.

LayoutTests:

Added test for generating CSS rule strings with default formatting.

  • inspector/css/generate-css-rule-string.html:
3:24 PM Changeset in webkit [190527] by Joseph Pecoraro
  • 35 edits
    11 deletes in trunk

Unreviewed, rolling out r190520, some tests assert / crash.

Source/JavaScriptCore:

  • CMakeLists.txt:
  • DerivedSources.make:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/Heap.cpp:

(JSC::Heap::willStartCollection): Deleted.
(JSC::Heap::didFinishCollection): Deleted.

  • heap/Heap.h:

(JSC::Heap::addObserver): Deleted.
(JSC::Heap::removeObserver): Deleted.

  • heap/HeapObserver.h: Removed.
  • heap/MarkedSpace.h:
  • inspector/InspectorEnvironment.h:
  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::vm): Deleted.

  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/agents/InspectorHeapAgent.cpp: Removed.
  • inspector/agents/InspectorHeapAgent.h: Removed.
  • inspector/protocol/Heap.json: Removed.

Source/WebCore:

  • ForwardingHeaders/heap/HeapObserver.h: Removed.
  • ForwardingHeaders/inspector/agents/InspectorHeapAgent.h: Removed.
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController): Deleted.
(WebCore::InspectorController::vm): Deleted.

  • inspector/InspectorController.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::vm): Deleted.

  • inspector/WorkerInspectorController.h:

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Base/Main.js:

(WebInspector.loaded): Deleted.

  • UserInterface/Base/Utilities.js:

(value): Deleted.

  • UserInterface/Controllers/HeapManager.js: Removed.
  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager): Deleted.
(WebInspector.TimelineManager.prototype._garbageCollected): Deleted.

  • UserInterface/Images/TimelineRecordGarbageCollection.svg: Removed.
  • UserInterface/Main.html:
  • UserInterface/Models/GarbageCollection.js: Removed.
  • UserInterface/Models/ScriptTimelineRecord.js:

(WebInspector.ScriptTimelineRecord.EventType.displayName):
(WebInspector.ScriptTimelineRecord.prototype.isGarbageCollection): Deleted.

  • UserInterface/Protocol/HeapObserver.js: Removed.
  • UserInterface/Test.html:
  • UserInterface/Test/Test.js:

(WebInspector.loaded): Deleted.

  • UserInterface/Views/ScriptTimelineDataGridNode.js:

(WebInspector.ScriptTimelineDataGridNode.prototype.get data):
(WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent): Deleted.
(WebInspector.ScriptTimelineDataGridNode): Deleted.

  • UserInterface/Views/ScriptTimelineOverviewGraph.js:

(WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout):

  • UserInterface/Views/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView.prototype._processPendingRecords):

  • UserInterface/Views/SourceCodeTimelineTreeElement.js:

(WebInspector.SourceCodeTimelineTreeElement):

  • UserInterface/Views/TimelineIcons.css:

(.garbage-collection-profile-record .icon): Deleted.

  • UserInterface/Views/TimelineRecordBar.css:

(.timeline-record-bar.timeline-record-type-script.script-timeline-record-garbage-collected > .segment): Deleted.

  • UserInterface/Views/TimelineRecordBar.js:

(WebInspector.TimelineRecordBar.createCombinedBars):

  • UserInterface/Views/TimelineRecordTreeElement.js:

(WebInspector.TimelineRecordTreeElement):

LayoutTests:

  • inspector/heap/garbageCollected-expected.txt: Removed.
  • inspector/heap/garbageCollected.html: Removed.
  • inspector/heap/gc-expected.txt: Removed.
  • inspector/heap/gc.html: Removed.
3:15 PM Changeset in webkit [190526] by commit-queue@webkit.org
  • 2 edits
    9 adds in trunk/PerformanceTests

Add the test runner for a new a graphics benchmark
https://bugs.webkit.org/show_bug.cgi?id=149683

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-10-02
Reviewed by Ryosuke Niwa.

The test runner collects the selected test suites and the running options
from its home page. It loops through all the tests, runs them and collects
their running results. At the end, it shows summary results and a final
score. It can also show a chart for a test sampled data.

  • Animometer: Added.
  • Animometer/runner: Added.
  • Animometer/runner/resources: Added.
  • Animometer/runner/animometer.html: Added.
  • Animometer/runner/resources/animometer.css: Added.

The benchmark runner page and css.

  • Animometer/runner/resources/animometer.js: Added.

(window.benchmarkRunnerClient.willAddTestFrame): Called after the test <iframe> is created.
(window.benchmarkRunnerClient.didRunTest): Called after running a test is finished.
(window.benchmarkRunnerClient.willStartFirstIteration): Called at the beginning before running any test.
(window.benchmarkRunnerClient.didRunSuites): Called after running all tests of a suite.
(window.benchmarkRunnerClient.didFinishLastIteration): Called after running the last test.

(showSection): Shows a section in the animometer.html page.
(startTest): Called when the "Start Test" button is clicked.
(showResults): Called after finishing all the tests.
(showGraph): Called when "Click..." button in the "Samples" column of the results table is clicked

  • Animometer/runner/resources/benchmark-runner.js: Copied from PerformanceTests/Speedometer/resources/benchmark-runner.js.

(BenchmarkRunnerState): Tracks the current running <suite, test>
(BenchmarkRunnerState.prototype.currentSuite): Returns the current running suite.
(BenchmarkRunnerState.prototype.currentTest): Returns the current running test.
(BenchmarkRunnerState.prototype.isFirstTest): Returns true if we are running the first test in the current suite.
(BenchmarkRunnerState.prototype.next): Advances to the next test.
(BenchmarkRunnerState.prototype.prepareCurrentTest): Creates a new <iframe> and waits for it to load a test.

(BenchmarkRunner): Manages running the tests and communicating with the benchmarkRunnerClient.
(BenchmarkRunner.prototype.waitForElement): Waits for an element to be created.
(BenchmarkRunner.prototype._appendFrame): Creates a new <iframe> element.
(BenchmarkRunner.prototype._removeFrame): Removed the current <iframe> element.
(BenchmarkRunner.prototype._runTestAndRecordResults): Runs the current test and saves its results.
(BenchmarkRunner.prototype.step): Either runs the current test if there is or start a new iteration.
(BenchmarkRunner.prototype.runAllSteps): Loops to run all the tests and move to the next iteration.
(this._runNextIteration): Starts a new iteration or show the results.
(BenchmarkRunner.prototype.runMultipleIterations): Loops to run all the iterations and show the results
(BenchmarkRunner.prototype._finalize): Finalizes the current iteration and starts a new one.

(SimplePromise): Deleted.
(SimplePromise.prototype.then): Deleted.
(SimplePromise.prototype.resolve): Deleted.
(BenchmarkTestStep): Deleted.
(Fibonacci): Deleted.
SimplePromise was moved t Animometer/resources/extensions.js because it is used by the runner and the tests.

(BenchmarkRunner.prototype._waitAndWarmUp): Deleted.
(BenchmarkRunner.prototype._runTest): Deleted.
(BenchmarkState.prototype.currentSuite): Deleted.
(BenchmarkState.prototype.currentTest): Deleted.
(BenchmarkState.prototype.next): Deleted.
(BenchmarkState.prototype.isFirstTest): Deleted.
(BenchmarkState.prototype.prepareCurrentSuite): Deleted.
BenchmarkState was renamed to BenchmarkRunnerState to not be confused with the tests BenchmarkState.

  • Animometer/runner/resources/d3.min.js: Copied from Websites/perf.webkit.org/public/v2/js/d3/d3.min.js.

Needed for drawing charts for the sampled scores and frame rates.

  • Animometer/runner/resources/graph.js: Added.

(graph): Draws a chart for a test sampled data. It shows two y-axes: one for the animated items and the second for FPS.

  • Skipped: Skip the Animometer benchmark for now.
2:52 PM Changeset in webkit [190525] by bshafiei@apple.com
  • 5 edits in branches/safari-601.2.7-branch/Source

Versioning.

2:44 PM Changeset in webkit [190524] by Brent Fulgham
  • 2 edits in trunk/Tools

Provide "--no-ninja" option to avoid using Ninja
https://bugs.webkit.org/show_bug.cgi?id=149757

Reviewed by Alex Christensen.

Add a new command line argument understood by webkitdirs.pm so
that we can conditionally avoid using Ninja. This is an
'opt-out' argument, so no existing Ninja users should be affected.

  • Scripts/webkitdirs.pm:

(canUseNinja): Check for option and block ninja if present.

2:38 PM Changeset in webkit [190523] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Flakiness dashboard should support OS X El Capitan
https://bugs.webkit.org/show_bug.cgi?id=149648

Patch by Aakash Jain <aakash_jain@apple.com> on 2015-10-02
Reviewed by Alexey Proskuryakov.

  • TestResultServer/static-dashboards/flakiness_dashboard.js: Fix the broken dashboard for ElCapitan.
2:16 PM Changeset in webkit [190522] by ggaren@apple.com
  • 56 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling back in r190450
https://bugs.webkit.org/show_bug.cgi?id=149727

The cause of the crash was a CodeBlock, after surviving a call to
deleteAllCode by virtue of being in the remembered set, trying to mark
its inlined CodeBlocks via pointers from its inlined executables.
Since deleteAllCode clears those pointers, the CodeBlock would ASSERT.
(Any other choice to retain a CodeBlock after deleteAllCode -- for
example, conservative marking -- could trigger the same bug.)

The fix is for InlineCallFrame to point directly to its inlined CodeBlock
instead of pointing indirectly via an executable. This guarantees that
CodeBlocks are GC safe regardless of whether we've called deleteAllCode.

Restored changesets:

"CodeBlock should be a GC object"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/190450

2:11 PM Changeset in webkit [190521] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Option-Click on a property name in the Computed view should jump to resource view
https://bugs.webkit.org/show_bug.cgi?id=149521

Patch by Devin Rousso <Devin Rousso> on 2015-10-02
Reviewed by Timothy Hatcher.

  • UserInterface/Models/DOMNodeStyles.js:

(WebInspector.DOMNodeStyles.prototype.effectivePropertyForName):
Now tries to search for a non-canonical property before falling back to
the canonical version.

  • UserInterface/Views/CSSStyleDeclarationTextEditor.js:

(WebInspector.CSSStyleDeclarationTextEditor.prototype._createTextMarkerForPropertyIfNeeded):
If the user option-clicks the goto arrow, it shows the source for the
property instead.

  • UserInterface/Views/ComputedStyleDetailsPanel.js:

(WebInspector.ComputedStyleDetailsPanel.prototype.cssStyleDeclarationTextEditorShowProperty.delegateShowProperty):
(WebInspector.ComputedStyleDetailsPanel.prototype.cssStyleDeclarationTextEditorShowProperty):
Attempts to show the source of the given property. Will fallback to
highlighting the property in the rules panel.

1:40 PM Changeset in webkit [190520] by commit-queue@webkit.org
  • 35 edits
    4 copies
    11 adds in trunk

Web Inspector: Include Garbage Collection Event in Timeline
https://bugs.webkit.org/show_bug.cgi?id=142510

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-02
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • CMakeLists.txt:
  • DerivedSources.make:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/HeapObserver.h:
  • heap/Heap.cpp:

(JSC::Heap::willStartCollection):
(JSC::Heap::didFinishCollection):

  • heap/Heap.h:

(JSC::Heap::addObserver):
(JSC::Heap::removeObserver):
Allow observers on heap to add hooks for starting / ending garbage collection.

  • inspector/InspectorEnvironment.h:
  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::vm):

  • inspector/JSGlobalObjectInspectorController.h:

Access the VM through the InspectorEnvironment as it won't change.

  • inspector/agents/InspectorHeapAgent.cpp: Added.

(Inspector::InspectorHeapAgent::InspectorHeapAgent):
(Inspector::InspectorHeapAgent::~InspectorHeapAgent):
(Inspector::InspectorHeapAgent::didCreateFrontendAndBackend):
(Inspector::InspectorHeapAgent::willDestroyFrontendAndBackend):
(Inspector::InspectorHeapAgent::enable):
(Inspector::InspectorHeapAgent::disable):
(Inspector::InspectorHeapAgent::gc):
(Inspector::protocolTypeForHeapOperation):
(Inspector::InspectorHeapAgent::willGarbageCollect):
(Inspector::InspectorHeapAgent::didGarbageCollect):

  • inspector/agents/InspectorHeapAgent.h: Added.
  • inspector/protocol/Heap.json: Added.

New domain and agent to handle tasks related to the JavaScriptCore heap.

Source/WebCore:

Tests: inspector/heap/garbageCollected.html

inspector/heap/gc.html

  • ForwardingHeaders/heap/HeapObserver.h: Added.
  • ForwardingHeaders/inspector/agents/InspectorHeapAgent.h: Added.
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:

Forwarding headers.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::vm):

  • inspector/InspectorController.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::vm):

  • inspector/WorkerInspectorController.h:

Implement InspectorEnvironment::vm and create a Heap agent for the
Page inspector controller.

Source/WebInspectorUI:

  • UserInterface/Base/Utilities.js:

(Array.prototype.parition):
Helper to partition an Array into two arrays.

  • UserInterface/Main.html:
  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Base/Main.js:

(WebInspector.loaded):

  • UserInterface/Test.html:
  • UserInterface/Test/Test.js:

(WebInspector.loaded):

  • UserInterface/Protocol/HeapObserver.js:

(WebInspector.HeapObserver.prototype.garbageCollected):
(WebInspector.HeapObserver):
Create the new observer and manager.

  • UserInterface/Models/GarbageCollection.js:

(WebInspector.GarbageCollection):
(WebInspector.GarbageCollection.fromPayload):
(WebInspector.GarbageCollection.prototype.get type):
(WebInspector.GarbageCollection.prototype.get startTime):
(WebInspector.GarbageCollection.prototype.get endTime):
(WebInspector.GarbageCollection.prototype.get duration):
Model object for Heap.GarbageCollection.

  • UserInterface/Controllers/HeapManager.js:

(WebInspector.HeapManager):
(WebInspector.HeapManager.prototype.garbageCollected):
Dispatch events with.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager):
(WebInspector.TimelineManager.prototype._garbageCollected):
Include new GC Timeline Events as Script events.

  • UserInterface/Views/ScriptTimelineOverviewGraph.js:

(WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout):
For the Script overview, make two sets of bars, one for Scripts and one for GCs.
The GCs bar will be on top of the the Scripts bar. This is particularly useful
since a GC can happen during script execution.

  • UserInterface/Views/ScriptTimelineDataGridNode.js:

(WebInspector.ScriptTimelineDataGridNode.prototype.get data):
(WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent):
(WebInspector.ScriptTimelineDataGridNode):
Give a NaN call count to top level Script DataGridNodes.
In the UI, display the empty placeholder for NaN call counts.

  • UserInterface/Images/TimelineRecordGarbageCollection.svg: Added.
  • UserInterface/Models/ScriptTimelineRecord.js:

(WebInspector.ScriptTimelineRecord.prototype.isGarbageCollection):
(WebInspector.ScriptTimelineRecord.EventType.displayName):

  • UserInterface/Views/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView.prototype._processPendingRecords):

  • UserInterface/Views/SourceCodeTimelineTreeElement.js:

(WebInspector.SourceCodeTimelineTreeElement):

  • UserInterface/Views/TimelineIcons.css:

(.garbage-collection-profile-record .icon):

  • UserInterface/Views/TimelineRecordBar.css:

(.timeline-record-bar.timeline-record-type-script.script-timeline-record-garbage-collected > .segment):
UI for GC events.

  • UserInterface/Views/TimelineRecordBar.js:

(WebInspector.TimelineRecordBar.createCombinedBars):
Simplify by storing start time into a variable.

  • UserInterface/Views/TimelineRecordTreeElement.js:

(WebInspector.TimelineRecordTreeElement):
Icon for GC events.

LayoutTests:

  • inspector/heap/garbageCollected-expected.txt: Added.
  • inspector/heap/garbageCollected.html: Added.
  • inspector/heap/gc-expected.txt: Added.
  • inspector/heap/gc.html: Added.
1:38 PM Changeset in webkit [190519] by dbates@webkit.org
  • 2 edits in trunk/Tools

Fix run-webkit-tests --ios-simulator after <http://trac.webkit.org/changeset/190515>
(https://bugs.webkit.org/show_bug.cgi?id=149753)

For now, pass --ios-simulator.

  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort._build_relay):

1:37 PM Changeset in webkit [190518] by Simon Fraser
  • 6 edits in trunk/LayoutTests

Test gardening.

  • TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/ios-simulator/TestExpectations:
  • platform/mac-wk1/TestExpectations:
  • platform/mac/TestExpectations:
1:18 PM Changeset in webkit [190517] by Simon Fraser
  • 2 edits in trunk/Tools

Remove a "nullable" that breaks the iOS 8 build.

  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]):

12:51 PM Changeset in webkit [190516] by jer.noble@apple.com
  • 3 edits
    3 adds in trunk

[MSE] Browser crashes when appending invalid data to MSE source buffer
https://bugs.webkit.org/show_bug.cgi?id=149689

Reviewed by Darin Adler.

Source/WebCore:

Test: media/media-source/media-source-stpp-crash.html

Bail out early (as specced) after disconnecting the SourceBuffer from its MediaSource.

  • Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveInitializationSegment):

LayoutTests:

  • media/content/stpp.mp4: Added.
  • media/media-source/media-source-stpp-crash-expected.txt: Added.
  • media/media-source/media-source-stpp-crash.html: Added.
12:43 PM Changeset in webkit [190515] by dbates@webkit.org
  • 4 edits in trunk/Tools

LayoutTestRelay is not built and archived when building for iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=149753

Reviewed by Alexey Proskuryakov and Andy Estes.

Towards running layout tests on the iOS Simulator test bots, we need to teach scripts build-webkit
and built-product-archive to build the Mac tool LayoutTestRelay and include this tool in the built
product archive when building for iOS Simulator, respectively.

  • BuildSlaveSupport/built-product-archive:

(main): Pass the full platform name (options.platform) to archiveBuiltProduct() so that it can
differentiate between iOS device and iOS Simulator platforms.
(webkitBuildDirectoryForConfigurationAndPlatform): Extracted logic to run the script webkit-build-directory
from determineWebKitBuildDirectories() into this function so that it can be used by both
determineWebKitBuildDirectories() and archiveBuiltProduct().
(determineWebKitBuildDirectories): Moved logic to execute the script webkit-build-directory from here to
webkitBuildDirectoryForConfigurationAndPlatform().
(createZip): Added parameter embedParentDirectoryNameOnDarwin (defaults to False) to specify whether
we should call ditto(1) with --keepParent to embed the parent directory name in the zip archive. This
argument is only applicable when building on Darwin. We only pass embedParentDirectoryNameOnDarwin=True
when making an archive for a Mac or iOS device build. For iOS Simulator builds we archive two directories
and we do not want to keep the parent directory because it is a placeholder directory used as a workaround
for the limitation that ditto(1) can only accept a single directory to archive on its command line.
(archiveBuiltProduct): Modified to take the full platform name as an argument. Added logic for iOS.
For iOS device builds we use the same logic as for a Mac build and archive the configuration-specific
build directory. For iOS Simulator builds we archive the configuration-specific iOS build directory,
LayoutTestRelay and LayoutTestRelay.dSYM (if it exists) from the configuration-specific Mac build.

  • Scripts/build-layouttestrelay:
    • Remove unnecessary include of Perl module POSIX.
    • Only build LayoutTestRelay when building for iOS Simulator (i.e. --ios-simulator is passed).
  • Scripts/build-webkit:
    • Invoke script build-layouttestrelay when building for iOS Simulator.
12:36 PM Changeset in webkit [190514] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

ASSERTION FAILED: param >= 0 in AnimationBase::updateStateMachine()
https://bugs.webkit.org/show_bug.cgi?id=149737
rdar://problem/19017465

Reviewed by Dean Jackson.

CoreAnimation can give us an animation beginTime that is slightly into the future,
which results in 'param' here being < 0, so relax the assertion slightly.

Fixes lots of assertions running iOS WK2 layout tests.

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::updateStateMachine):

11:33 AM Changeset in webkit [190513] by peavo@outlook.com
  • 2 edits in trunk/Source/WebCore

[WinCairo] Fix linker warnings.
https://bugs.webkit.org/show_bug.cgi?id=149754

Reviewed by Alex Christensen.

Avoid compiling these files twice, they are already included in
RenderingAllInOne.cpp.

  • PlatformWinCairo.cmake:
11:29 AM Changeset in webkit [190512] by enrica@apple.com
  • 4 edits in trunk/Source/WebKit2

Text selection is inaccurate in Wikipedia pages when starting navigation from wikipedia.org.
https://bugs.webkit.org/show_bug.cgi?id=149756
rdar://problem/22332409

Reviewed by Tim Horton.

When loading a new document into the same WebPage object, we need
to clear the assisted node, since there is no guarantee that the
node will be blurred. The bug is caused by the use of a stale
assisted node to constrain the point where the gesture occurs.
A fix for this problem was landed in http://trac.webkit.org/changeset/179885
where the cleanup was added when FrameLoaderClient::detach2 was called.
This method doesn't seem to be called any longer for the main frame,
so the correct solution is to add the cleanup to didCommitLoad in WebPage.
I've also added some checks to webSelectionsRects and selectedTextRange to avoid
the use of postLayoutData when the selection is none.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView webSelectionRects]):
(-[WKContentView selectedTextRange]):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::detachedFromParent2): Removed call to resetAssistedNodeForFrame.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didCommitLoad): Added call to resetAssistedNodeForFrame.

10:58 AM Changeset in webkit [190511] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] Unreviewed test fix.

You cannot run 'run-webkit-tests' from the command line because it does not know
to append the binary subdirectory (bin32/bin64). We don't see this on our builders
because they explicitly set use the 'root' argument to provide the full path to
the test binaries.

  • Scripts/webkitpy/port/win.py:

(WinPort._build_path): Added.

10:46 AM Changeset in webkit [190510] by achristensen@apple.com
  • 15 edits
    3 adds in trunk

Source/WebCore:
Reloading without content blockers doesn't apply to resource loads after the main frame finishes
https://bugs.webkit.org/show_bug.cgi?id=149430
rdar://problem/22742222

Reviewed by Geoffrey Garen.

Test: http/tests/contentextensions/disable-blocker.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadResource):

  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::userContentExtensionsEnabled):
(WebCore::DocumentLoader::setUserContentExtensionsEnabled):
Store and use the state of whether content blockers are enabled or not on the DocumentLoader
so that it stays constant for a document's entire life. This state comes from the Page when
making the DocumentLoader in WebKit2.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadResourceSynchronously):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::willSendRequestInternal):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::open):

  • page/UserContentController.cpp:

(WebCore::UserContentController::removeAllUserContentExtensions):
(WebCore::UserContentController::processContentExtensionRulesForLoad):
(WebCore::UserContentController::actionsForResourceLoad):

  • page/UserContentController.h:

Source/WebKit2:
Reloading without content blockers doesn't apply to resource loads after the main frame finishes
https://bugs.webkit.org/show_bug.cgi?id=149430
rdar://problem/22742222

Reviewed by Geoffrey Garen.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::createDocumentLoader):
Copy the state of whether content extensions are disabled from the Page to the DocumentLoader
when making a DocumentLoader.

Tools:
Reloading without content blockers doesn't apply to resource loads after the main frame finishes
https://bugs.webkit.org/show_bug.cgi?id=149430
rdar://problem/22742222

Reviewed by Geoffrey Garen.

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaResetStateToConsistentValues):

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformConfigureViewForTest):
Test what happens when you disable content blockers from the SPI.

LayoutTests:
Reloading without content blockers doesn’t apply to resource loads after the main frame finishes
https://bugs.webkit.org/show_bug.cgi?id=149430
rdar://problem/22742222

Reviewed by Geoffrey Garen.

  • http/tests/contentextensions/disable-blocker-expected.txt: Added.
  • http/tests/contentextensions/disable-blocker.html: Added.
  • http/tests/contentextensions/disable-blocker.html.json: Added.
10:30 AM Changeset in webkit [190509] by bshafiei@apple.com
  • 3 edits
    6 copies in branches/safari-601-branch

Merged r190418. rdar://problem/22936771

10:28 AM Changeset in webkit [190508] by bshafiei@apple.com
  • 5 edits in branches/safari-601-branch/Source

Versioning.

9:55 AM Changeset in webkit [190507] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source

Versioning.

8:13 AM Changeset in webkit [190506] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Fix indentation of console message parameters
https://bugs.webkit.org/show_bug.cgi?id=149740

Reviewed by Darin Adler.

  • UserInterface/Views/ConsoleMessageView.css:

(.console-message .console-message-stack-trace-container > li):
(.console-message .console-message-extra-parameters-container > li::before):

8:13 AM Changeset in webkit [190505] by commit-queue@webkit.org
  • 28 edits in trunk

popstate is fired at the wrong time on load
https://bugs.webkit.org/show_bug.cgi?id=94265

Patch by Antoine Quint <Antoine Quint> on 2015-10-02
Reviewed by Darin Adler.

Source/WebCore:

Don't fire popstate event on initial document load

According to the specification [1], a popstate event should only be fired
when the document has a "last entry" and the entry being navigated to isn't
it. A document is created without a "last entry" and gets one just after
this check when it is first navigated to, so a popstate should be fired any
time a document is navigated to except for the first time after it has been
created.

Patch adapted from work by jl@opera.com on Blink [2].

[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#traverse-the-history (step 12-14 in particular)
[2] https://src.chromium.org/viewvc/blink?revision=165221&view=revision

  • dom/Document.cpp:

(WebCore::Document::implicitClose):

Source/WebKit2:

Ensure we have a valid page before trying to get to its drawingArea as this could lead
to a crash as observed with fast/loader/stateobjects/pushstate-object-types.html.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::restoreViewState):

LayoutTests:

Updating tests that relied on a "popstate" event being fired at page load.

  • fast/history/same-document-iframes-changing-fragment-expected.txt:
  • fast/history/same-document-iframes-changing-pushstate-expected.txt:
  • fast/loader/javascript-url-iframe-remove-on-navigate.html:
  • fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html:
  • fast/loader/stateobjects/document-destroyed-navigate-back.html:
  • fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html:
  • fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html:
  • fast/loader/stateobjects/popstate-after-load-complete-body-inline-attribute.html:
  • fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html:
  • fast/loader/stateobjects/popstate-fires-on-history-traversal-expected.txt:
  • fast/loader/stateobjects/popstate-fires-on-history-traversal.html:
  • fast/loader/stateobjects/popstate-fires-with-page-cache-expected.txt:
  • fast/loader/stateobjects/popstate-fires-with-page-cache.html:
  • fast/loader/stateobjects/pushstate-object-types.html:
  • fast/loader/stateobjects/pushstate-then-replacestate.html:
  • fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html:
  • fast/loader/stateobjects/replacestate-then-pushstate.html:
  • fast/loader/stateobjects/resources/popstate-fires-with-page-cache-1.html:
  • fast/loader/stateobjects/resources/popstate-fires-with-page-cache-2.html:
  • fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html:
  • http/tests/history/popstate-fires-with-pending-requests.html:
  • http/tests/navigation/redirect-on-back-updates-history-item-expected.txt:
  • http/tests/navigation/redirect-on-reload-updates-history-item-expected.txt:
7:08 AM Changeset in webkit [190504] by Andres Gomez
  • 2 edits
    1 copy
    1 move in trunk/Source/WebInspectorUI

[GTK] Web Inspector: Add GTK+ icons for new plus icons in the style sidebar
https://bugs.webkit.org/show_bug.cgi?id=149227

Reviewed by Carlos Garcia Campos.

  • UserInterface/Images/gtk/NewTabPlus.svg: Updated.
  • UserInterface/Images/gtk/Plus13.svg: Copied from Source/WebInspectorUI/UserInterface/Images/gtk/Plus.svg.
  • UserInterface/Images/gtk/Plus15.svg: Renamed from Source/WebInspectorUI/UserInterface/Images/gtk/Plus.svg.
6:58 AM Changeset in webkit [190503] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601-branch/Source/WebCore

Merge r190380. rdar://problem/22888962

6:58 AM Changeset in webkit [190502] by matthew_hanson@apple.com
  • 4 edits in branches/safari-601-branch/Source

Merge r190252. rdar://problem/22867962

6:58 AM Changeset in webkit [190501] by matthew_hanson@apple.com
  • 3 edits
    6 adds in branches/safari-601-branch

Merge r189560. rdar://problem/22824659

6:57 AM Changeset in webkit [190500] by matthew_hanson@apple.com
  • 3 edits in branches/safari-601-branch/Source/JavaScriptCore

Merge r189460. rdar://problem/22802036

6:57 AM Changeset in webkit [190499] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601-branch/Source/WebKit/mac

Merge r189122. rdar://problem/22801996

6:57 AM Changeset in webkit [190498] by matthew_hanson@apple.com
  • 7 edits in branches/safari-601-branch/Source

Merge r188990. rdar://problem/22802029

6:57 AM Changeset in webkit [190497] by matthew_hanson@apple.com
  • 3 edits
    4 adds in branches/safari-601-branch

Merge r188768. rdar://problem/22802019

6:57 AM Changeset in webkit [190496] by matthew_hanson@apple.com
  • 3 edits in branches/safari-601-branch

Merge r188755. rdar://problem/22802005

6:57 AM Changeset in webkit [190495] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601-branch/Source/WebInspectorUI

Merge r188748. rdar://problem/22802023

6:57 AM Changeset in webkit [190494] by matthew_hanson@apple.com
  • 4 edits
    2 adds in branches/safari-601-branch

Merge r188690. rdar://problem/22802006

6:56 AM Changeset in webkit [190493] by matthew_hanson@apple.com
  • 11 edits in branches/safari-601-branch/Source

Merge r189102. rdar://problem/22802034

6:56 AM Changeset in webkit [190492] by matthew_hanson@apple.com
  • 7 edits
    3 adds in branches/safari-601-branch

Merge r188640. rdar://problem/22802005

6:56 AM Changeset in webkit [190491] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-601-branch

Merge r188634. rdar://problem/22802013

6:56 AM Changeset in webkit [190490] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601-branch/Source/WebCore

Merge r188622. rdar://problem/22802016

6:56 AM Changeset in webkit [190489] by matthew_hanson@apple.com
  • 3 edits in branches/safari-601-branch/Source/WebCore

Merge r188298. rdar://problem/22885242

6:56 AM Changeset in webkit [190488] by matthew_hanson@apple.com
  • 4 edits
    2 adds in branches/safari-601-branch

Merge r187921. rdar://problem/22801988

6:56 AM Changeset in webkit [190487] by matthew_hanson@apple.com
  • 4 edits
    2 adds in branches/safari-601-branch

Merge r187593. rdar://problem/22801973

6:56 AM Changeset in webkit [190486] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-601-branch

Merge r187210. rdar://problem/22801995

6:56 AM Changeset in webkit [190485] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601-branch/Source/WebCore

Merge r187145. rdar://problem/22801952

5:14 AM Changeset in webkit [190484] by jfernandez@igalia.com
  • 9 edits
    42 adds in trunk

[CSS Grid Layout] Support for Content Alignment in grid layout
https://bugs.webkit.org/show_bug.cgi?id=145520

Reviewed by Darin Adler.

Source/WebCore:

According to CSS Box Alignment specification, Content Distribution
alignment controls alignment of the box's content within the box. The
alignment container is the grid container's content box. The alignment
subjects are the grid tracks.

This patch implements Grid Layout support for Content Distribution
alignment along both block/column and inline/row axis, which are handled
by align-content and justify-content properties respectively.

This patch provides support for overflow handling, similar to what
Self Alignment provides with grid items, and both <content-position>
and <content-distribution> values.

Baseline Alignment is still missing because it requires some additional
behavior to be supported on grids before considering its implementation.

Tests: css3/overwrite-content-alignment.html

css3/overwrite-self-alignment.html
fast/css-grid-layout/grid-align-content-distribution-vertical-lr.html
fast/css-grid-layout/grid-align-content-distribution-vertical-rl.html
fast/css-grid-layout/grid-align-content-distribution.html
fast/css-grid-layout/grid-align-content-vertical-lr.html
fast/css-grid-layout/grid-align-content-vertical-rl.html
fast/css-grid-layout/grid-align-content.html
fast/css-grid-layout/grid-content-alignment-overflow.html
fast/css-grid-layout/grid-content-alignment-with-different-sized-tracks.html
fast/css-grid-layout/grid-content-alignment-with-span-vertical-lr.html
fast/css-grid-layout/grid-content-alignment-with-span-vertical-rl.html
fast/css-grid-layout/grid-content-alignment-with-span.html
fast/css-grid-layout/grid-justify-content-distribution-vertical-lr.html
fast/css-grid-layout/grid-justify-content-distribution-vertical-rl.html
fast/css-grid-layout/grid-justify-content-distribution.html
fast/css-grid-layout/grid-justify-content-vertical-lr.html
fast/css-grid-layout/grid-justify-content-vertical-rl.html
fast/css-grid-layout/grid-justify-content.html

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse):
(WebCore::RenderFlexibleBox::alignFlexLines):

  • rendering/RenderGrid.cpp:

(WebCore::ContentAlignmentData::ContentAlignmentData):
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::gridAreaBreadthForChild):
(WebCore::RenderGrid::populateGridPositions):
(WebCore::resolveContentDistributionFallback):
(WebCore::offsetToStartEdge):
(WebCore::offsetToEndEdge):
(WebCore::contentDistributionOffset):
(WebCore::RenderGrid::computeContentPositionAndDistributionColumnOffset):
(WebCore::RenderGrid::computeContentPositionAndDistributionRowOffset):
(WebCore::RenderGrid::findChildLogicalPosition):
(WebCore::RenderGrid::computePreferredLogicalWidths): Deleted.
(WebCore::RenderGrid::autoPlacementMajorAxisDirection): Deleted.
(WebCore::RenderGrid::autoPlacementMinorAxisDirection): Deleted.
(WebCore::RenderGrid::cachedGridCoordinate): Deleted.
(WebCore::RenderGrid::rowPositionForChild): Deleted.

  • rendering/RenderGrid.h:
  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::resolvedAlignContentPosition):
(WebCore::RenderStyle::resolvedAlignContentDistribution):
(WebCore::RenderStyle::resolvedJustifyContentPosition):
(WebCore::RenderStyle::resolvedJustifyContentDistribution):

  • rendering/style/RenderStyle.h:

LayoutTests:

Content Distribution alignment controls alignment of the box's
content within the box. The alignment container is the grid
container's content box. The alignment subjects are the grid
tracks.

In addition to the tests to verify the new functionality, I've
added some tests to check out that the new complex values are
overwritten properly.

I had to modify the grid-item-margin-auto-columns-rows-horizontal-rtl
test because when using RTL direction the whole grid must flow form
right to left, not only its items, so I rebaselined text expectations
to adapt it to the new behavior.

  • css3/overwrite-content-alignment-expected.txt: Added.
  • css3/overwrite-content-alignment.html: Added.
  • css3/overwrite-self-alignment-expected.txt: Added.
  • css3/overwrite-self-alignment.html: Added.
  • fast/css-grid-layout/grid-align-content-distribution-expected.txt: Added.
  • fast/css-grid-layout/grid-align-content-distribution-vertical-lr-expected.txt: Added.
  • fast/css-grid-layout/grid-align-content-distribution-vertical-lr.html: Added.
  • fast/css-grid-layout/grid-align-content-distribution-vertical-rl-expected.txt: Added.
  • fast/css-grid-layout/grid-align-content-distribution-vertical-rl.html: Added.
  • fast/css-grid-layout/grid-align-content-distribution.html: Added.
  • fast/css-grid-layout/grid-align-content-expected.txt: Added.
  • fast/css-grid-layout/grid-align-content-vertical-lr-expected.txt: Added.
  • fast/css-grid-layout/grid-align-content-vertical-lr.html: Added.
  • fast/css-grid-layout/grid-align-content-vertical-rl-expected.txt: Added.
  • fast/css-grid-layout/grid-align-content-vertical-rl.html: Added.
  • fast/css-grid-layout/grid-align-content.html: Added.
  • fast/css-grid-layout/grid-content-alignment-overflow-expected.txt: Added.
  • fast/css-grid-layout/grid-content-alignment-overflow.html: Added.
  • fast/css-grid-layout/grid-content-alignment-with-different-sized-tracks.html: Added.
  • fast/css-grid-layout/grid-content-alignment-with-different-sized-tracks-expected.txt: Added.
  • fast/css-grid-layout/grid-content-alignment-with-span-expected.txt: Added.
  • fast/css-grid-layout/grid-content-alignment-with-span-vertical-lr-expected.txt: Added.
  • fast/css-grid-layout/grid-content-alignment-with-span-vertical-lr.html: Added.
  • fast/css-grid-layout/grid-content-alignment-with-span-vertical-rl-expected.txt: Added.
  • fast/css-grid-layout/grid-content-alignment-with-span-vertical-rl.html: Added.
  • fast/css-grid-layout/grid-content-alignment-with-span.html: Added.
  • fast/css-grid-layout/grid-item-margin-auto-columns-rows-horizontal-rtl-expected.html:
  • fast/css-grid-layout/grid-justify-content-distribution-expected.txt: Added.
  • fast/css-grid-layout/grid-justify-content-distribution-vertical-lr-expected.txt: Added.
  • fast/css-grid-layout/grid-justify-content-distribution-vertical-lr.html: Added.
  • fast/css-grid-layout/grid-justify-content-distribution-vertical-rl-expected.txt: Added.
  • fast/css-grid-layout/grid-justify-content-distribution-vertical-rl.html: Added.
  • fast/css-grid-layout/grid-justify-content-distribution.html: Added.
  • fast/css-grid-layout/grid-justify-content-expected.txt: Added.
  • fast/css-grid-layout/grid-justify-content-vertical-lr-expected.txt: Added.
  • fast/css-grid-layout/grid-justify-content-vertical-lr.html: Added.
  • fast/css-grid-layout/grid-justify-content-vertical-rl-expected.txt: Added.
  • fast/css-grid-layout/grid-justify-content-vertical-rl.html: Added.
  • fast/css-grid-layout/grid-justify-content.html: Added.
  • fast/css-grid-layout/resources/grid.css:

(.firstRowThirdColumn):
(.firstRowFourthColumn):
(.secondRowThirdColumn):
(.secondRowFourthColumn):
(.thirdRowFirstColumn):
(.thirdRowSecondColumn):
(.fourthRowFirstColumn):
(.fourthRowSecondColumn):

4:26 AM Changeset in webkit [190483] by matthew_hanson@apple.com
  • 5 edits in branches/safari-601-branch/Source

Versioning.

4:07 AM Changeset in webkit [190482] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

Attempted build fix.

  • DerivedSources.make:
  • page/make_settings.pl:

(printGetterAndSetter):

3:53 AM Changeset in webkit [190481] by dino@apple.com
  • 8 edits
    2 adds in trunk

Expose WEBGL_debug_renderer_info
https://bugs.webkit.org/show_bug.cgi?id=149735
<rdar://problem/18343500>

Reviewed by Simon Fraser.

Source/WebCore:

Enable the extension that allows content to query
for the GPUs vendor and details.

Now that we're enabling this, there was no need for
the internal setting that identified privileged situations.
However, since this meant that WEBGL_debug_shaders was
also exposed, I explicitly disable it since it is
not yet conformant.

Test: fast/canvas/webgl/webgl-debug-renderer-info.html
as well as the general conformance suite.

  • html/canvas/WebGL2RenderingContext.cpp: No need to guard around allowPrivilegedExtensions().

(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContext.cpp: Ditto.

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::allowPrivilegedExtensions): Deleted.

  • html/canvas/WebGLRenderingContextBase.h:
  • page/Settings.in: Remove privilegedWebGLExtensions.
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: Forbid the translated shader

extension while it is still buggy.
(WebCore::Extensions3DOpenGL::supportsExtension):

LayoutTests:

Modify a test from the 1.0.2 conformance suite to make sure
we're actually enabling and passing the info.

  • fast/canvas/webgl/webgl-debug-renderer-info-expected.txt: Added.
  • fast/canvas/webgl/webgl-debug-renderer-info.html: Added.
1:17 AM Changeset in webkit [190480] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r190447. rdar://problem/22865007

1:16 AM Changeset in webkit [190479] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1.46-branch/LayoutTests

Merged r190438. rdar://problem/22865007

1:15 AM Changeset in webkit [190478] by bshafiei@apple.com
  • 18 edits in branches/safari-601.1.46-branch

Merged r190434. rdar://problem/22865007

1:14 AM Changeset in webkit [190477] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r190380. rdar://problem/22888927

1:13 AM Changeset in webkit [190476] by bshafiei@apple.com
  • 4 edits
    2 copies in branches/safari-601.1.46-branch

Merged r190375. rdar://problem/22881731

1:12 AM Changeset in webkit [190475] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r190327. rdar://problem/22865398

1:11 AM Changeset in webkit [190474] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebKit/mac

Merged r190092. rdar://problem/22824439

1:10 AM Changeset in webkit [190473] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merged r189773. rdar://problem/22824430

1:09 AM Changeset in webkit [190472] by bshafiei@apple.com
  • 3 edits
    6 copies in branches/safari-601.1.46-branch

Merged r189560. rdar://problem/22824445

1:08 AM Changeset in webkit [190471] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merged r189366. rdar://problem/22824453

1:07 AM Changeset in webkit [190470] by bshafiei@apple.com
  • 6 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r189322. rdar://problem/22824435

1:06 AM Changeset in webkit [190469] by bshafiei@apple.com
  • 3 edits
    4 copies in branches/safari-601.1.46-branch

Merged r188768. rdar://problem/22707478

1:05 AM Changeset in webkit [190468] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1.46-branch

Merged r188755. rdar://problem/22707467

1:04 AM Changeset in webkit [190467] by bshafiei@apple.com
  • 4 edits
    2 copies in branches/safari-601.1.46-branch

Merged r188690. rdar://problem/22707471

1:03 AM Changeset in webkit [190466] by bshafiei@apple.com
  • 7 edits
    3 copies in branches/safari-601.1.46-branch

Merged r188640. rdar://problem/22707467

1:02 AM Changeset in webkit [190465] by bshafiei@apple.com
  • 3 edits
    2 copies in branches/safari-601.1.46-branch

Merged r188634. rdar://problem/22707475

1:01 AM Changeset in webkit [190464] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r188622. rdar://problem/22823235

1:00 AM Changeset in webkit [190463] by bshafiei@apple.com
  • 11 edits
    2 copies in branches/safari-601.1.46-branch

Merged r188405. rdar://problem/22707490

12:58 AM Changeset in webkit [190462] by bshafiei@apple.com
  • 8 edits
    2 copies in branches/safari-601.1.46-branch

Merged r188182. rdar://problem/22707488

12:57 AM Changeset in webkit [190461] by bshafiei@apple.com
  • 1 edit
    4 copies in branches/safari-601.1.46-branch/LayoutTests

Merged r188016. rdar://problem/22707482

12:56 AM Changeset in webkit [190460] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r187994. rdar://problem/22707482

12:55 AM Changeset in webkit [190459] by bshafiei@apple.com
  • 4 edits
    2 copies in branches/safari-601.1.46-branch

Merged r187921. rdar://problem/22707460

12:54 AM Changeset in webkit [190458] by bshafiei@apple.com
  • 3 edits
    2 copies in branches/safari-601.1.46-branch

Merged r187210. rdar://problem/22707464

12:53 AM Changeset in webkit [190457] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r187145. rdar://problem/22707457

Oct 1, 2015:

10:44 PM Changeset in webkit [190456] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Fix the #if guard in PointerLockController.cpp
https://bugs.webkit.org/show_bug.cgi?id=149705

Reviewed by Gyuyoung Kim.

  • page/PointerLockController.cpp:
10:37 PM Changeset in webkit [190455] by bshafiei@apple.com
  • 3 edits
    6 copies in branches/safari-601.1.46-branch

Merged r190418. rdar://problem/22936628

10:35 PM Changeset in webkit [190454] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r188298. rdar://problem/22936040

9:48 PM Changeset in webkit [190453] by ggaren@apple.com
  • 44 edits in trunk/Source/JavaScriptCore

2015-10-01 Geoffrey Garen <ggaren@apple.com>

Unreviewed, rolling out r190450
https://bugs.webkit.org/show_bug.cgi?id=148560

Crashes seen on el cap wk1 bots.

Reverted changesets:

"CodeBlock should be a GC object"
https://bugs.webkit.org/show_bug.cgi?id=149727
http://trac.webkit.org/changeset/190450

  • bytecode/CodeBlock.cpp: (JSC::CodeBlock::inferredName): (JSC::CodeBlock::dumpAssumingJITType): (JSC::CodeBlock::CodeBlock): (JSC::CodeBlock::~CodeBlock): (JSC::CodeBlock::setNumParameters): (JSC::CodeBlock::specialOSREntryBlockOrNull): (JSC::CodeBlock::visitStrongly): (JSC::CodeBlock::visitAggregate): (JSC::CodeBlock::shouldVisitStrongly): (JSC::CodeBlock::isKnownToBeLiveDuringGC): (JSC::CodeBlock::shouldJettisonDueToWeakReference): (JSC::CodeBlock::shouldJettisonDueToOldAge): (JSC::CodeBlock::determineLiveness): (JSC::CodeBlock::visitWeakReferences): (JSC::CodeBlock::finalizeLLIntInlineCaches): (JSC::CodeBlock::finalizeBaselineJITInlineCaches): (JSC::CodeBlock::finalizeUnconditionally): (JSC::CodeBlock::visitOSRExitTargets): (JSC::CodeBlock::unlinkIncomingCalls): (JSC::CodeBlock::linkIncomingCall): (JSC::CodeBlock::newReplacement): (JSC::ProgramCodeBlock::replacement): (JSC::ModuleProgramCodeBlock::replacement): (JSC::EvalCodeBlock::replacement): (JSC::FunctionCodeBlock::replacement): (JSC::ProgramCodeBlock::capabilityLevelInternal): (JSC::ModuleProgramCodeBlock::capabilityLevelInternal): (JSC::EvalCodeBlock::capabilityLevelInternal): (JSC::FunctionCodeBlock::capabilityLevelInternal): (JSC::WebAssemblyCodeBlock::replacement): (JSC::WebAssemblyCodeBlock::capabilityLevelInternal): (JSC::CodeBlock::jettison): (JSC::CodeBlock::capabilityLevel): (JSC::FunctionCodeBlock::destroy): Deleted. (JSC::WebAssemblyCodeBlock::destroy): Deleted. (JSC::ProgramCodeBlock::destroy): Deleted. (JSC::ModuleProgramCodeBlock::destroy): Deleted. (JSC::EvalCodeBlock::destroy): Deleted. (JSC::CodeBlock::finishCreation): Deleted. (JSC::CodeBlock::setAlternative): Deleted. (JSC::CodeBlock::visitWeakly): Deleted. (JSC::CodeBlock::visitChildren): Deleted. (JSC::timeToLive): Deleted. (JSC::CodeBlock::WeakReferenceHarvester::visitWeakReferences): Deleted. (JSC::CodeBlock::UnconditionalFinalizer::finalizeUnconditionally): Deleted. (JSC::CodeBlock::replacement): Deleted. (JSC::CodeBlock::computeCapabilityLevel): Deleted.
  • bytecode/CodeBlock.h: (JSC::CodeBlock::unlinkedCodeBlock): (JSC::CodeBlock::addressOfNumParameters): (JSC::CodeBlock::offsetOfNumParameters): (JSC::CodeBlock::alternative): (JSC::CodeBlock::setAlternative): (JSC::CodeBlock::forEachRelatedCodeBlock): (JSC::CodeBlock::specializationKind): (JSC::CodeBlock::instructionCount): (JSC::CodeBlock::setJITCode): (JSC::CodeBlock::hasBaselineJITProfiling): (JSC::CodeBlock::capabilityLevelState): (JSC::CodeBlock::addConstant): (JSC::CodeBlock::appendExceptionHandler): (JSC::CodeBlock::setConstantRegisters): (JSC::CodeBlock::replaceConstant): (JSC::GlobalCodeBlock::GlobalCodeBlock): (JSC::ProgramCodeBlock::ProgramCodeBlock): (JSC::ModuleProgramCodeBlock::ModuleProgramCodeBlock): (JSC::EvalCodeBlock::EvalCodeBlock): (JSC::EvalCodeBlock::variable): (JSC::EvalCodeBlock::numVariables): (JSC::EvalCodeBlock::unlinkedEvalCodeBlock): (JSC::FunctionCodeBlock::FunctionCodeBlock): (JSC::WebAssemblyCodeBlock::WebAssemblyCodeBlock): (JSC::ExecState::uncheckedR): (JSC::CodeBlock::clearMarks): (JSC::CodeBlockSet::mark): (JSC::ScriptExecutable::forEachCodeBlock): (JSC::ProgramCodeBlock::create): Deleted. (JSC::ProgramCodeBlock::createStructure): Deleted. (JSC::ModuleProgramCodeBlock::create): Deleted. (JSC::ModuleProgramCodeBlock::createStructure): Deleted. (JSC::EvalCodeBlock::create): Deleted. (JSC::EvalCodeBlock::createStructure): Deleted. (JSC::FunctionCodeBlock::create): Deleted. (JSC::FunctionCodeBlock::createStructure): Deleted. (JSC::WebAssemblyCodeBlock::create): Deleted. (JSC::WebAssemblyCodeBlock::createStructure): Deleted. (JSC::CodeBlock::clearVisitWeaklyHasBeenCalled): Deleted.
  • bytecode/DeferredCompilationCallback.cpp: (JSC::DeferredCompilationCallback::DeferredCompilationCallback): (JSC::DeferredCompilationCallback::~DeferredCompilationCallback): (JSC::DeferredCompilationCallback::compilationDidComplete):
  • bytecode/DeferredCompilationCallback.h:
  • bytecode/EvalCodeCache.h: (JSC::EvalCodeCache::tryGet): (JSC::EvalCodeCache::getSlow):
  • bytecode/PolymorphicAccess.cpp: (JSC::AccessCase::generate): (JSC::PolymorphicAccess::regenerate):
  • bytecode/StructureStubInfo.cpp: (JSC::StructureStubInfo::addAccessCase):
  • dfg/DFGByteCodeParser.cpp: (JSC::DFG::ByteCodeParser::parse):
  • dfg/DFGDesiredTransitions.cpp: (JSC::DFG::DesiredTransition::reallyAdd):
  • dfg/DFGDesiredWeakReferences.cpp: (JSC::DFG::DesiredWeakReferences::reallyAdd):
  • dfg/DFGDriver.cpp: (JSC::DFG::compile):
  • dfg/DFGGraph.cpp: (JSC::DFG::Graph::Graph):
  • dfg/DFGJITCode.h: (JSC::DFG::JITCode::osrEntryBlock): Deleted. (JSC::DFG::JITCode::setOSREntryBlock): Deleted. (JSC::DFG::JITCode::clearOSREntryBlock): Deleted.
  • dfg/DFGJITFinalizer.cpp: (JSC::DFG::JITFinalizer::finalize): (JSC::DFG::JITFinalizer::finalizeFunction): (JSC::DFG::JITFinalizer::finalizeCommon):
  • dfg/DFGOSRExitCompilerCommon.cpp: (JSC::DFG::adjustAndJumpToTarget):
  • dfg/DFGOperations.cpp:
  • dfg/DFGPlan.cpp: (JSC::DFG::Plan::Plan): (JSC::DFG::Plan::reallyAdd): (JSC::DFG::Plan::notifyReady): (JSC::DFG::Plan::finalizeWithoutNotifyingCallback): (JSC::DFG::Plan::finalizeAndNotifyCallback): (JSC::DFG::Plan::key): (JSC::DFG::Plan::clearCodeBlockMarks): (JSC::DFG::Plan::checkLivenessAndVisitChildren): (JSC::DFG::Plan::rememberCodeBlocks): Deleted.
  • dfg/DFGPlan.h:
  • dfg/DFGToFTLDeferredCompilationCallback.cpp: (JSC::DFG::ToFTLDeferredCompilationCallback::ToFTLDeferredCompilationCallback): (JSC::DFG::ToFTLDeferredCompilationCallback::~ToFTLDeferredCompilationCallback): (JSC::DFG::ToFTLDeferredCompilationCallback::create): (JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously): (JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidComplete):
  • dfg/DFGToFTLDeferredCompilationCallback.h:
  • dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp: (JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::ToFTLForOSREntryDeferredCompilationCallback): (JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::~ToFTLForOSREntryDeferredCompilationCallback): (JSC::DFG::Ref<ToFTLForOSREntryDeferredCompilationCallback>ToFTLForOSREntryDeferredCompilationCallback::create): (JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously): (JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidComplete):
  • dfg/DFGToFTLForOSREntryDeferredCompilationCallback.h:
  • dfg/DFGWorklist.cpp: (JSC::DFG::Worklist::completeAllPlansForVM): (JSC::DFG::Worklist::clearCodeBlockMarks): (JSC::DFG::completeAllPlansForVM): (JSC::DFG::clearCodeBlockMarks): (JSC::DFG::Worklist::rememberCodeBlocks): Deleted. (JSC::DFG::rememberCodeBlocks): Deleted.
  • dfg/DFGWorklist.h: (JSC::DFG::worklistForIndexOrNull):
  • ftl/FTLJITFinalizer.cpp: (JSC::FTL::JITFinalizer::finalizeFunction):
  • heap/CodeBlockSet.cpp: (JSC::CodeBlockSet::~CodeBlockSet): (JSC::CodeBlockSet::add): (JSC::CodeBlockSet::clearMarksForFullCollection): (JSC::CodeBlockSet::clearMarksForEdenCollection): (JSC::CodeBlockSet::deleteUnmarkedAndUnreferenced): (JSC::CodeBlockSet::remove): (JSC::CodeBlockSet::traceMarked): (JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks): (JSC::CodeBlockSet::dump):
  • heap/CodeBlockSet.h:
  • heap/Heap.cpp: (JSC::Heap::markRoots): (JSC::Heap::clearLivenessData): (JSC::Heap::traceCodeBlocksAndJITStubRoutines): (JSC::Heap::deleteAllCodeBlocks): (JSC::Heap::deleteAllUnlinkedCodeBlocks): (JSC::Heap::clearUnmarkedExecutables): (JSC::Heap::willStartCollection):
  • interpreter/Interpreter.cpp: (JSC::eval):
  • jit/GCAwareJITStubRoutine.h:
  • jit/JITCode.h: (JSC::JITCode::isJIT): (JSC::JITCode::timeToLive): (JSC::JITCode::isLowerTier):
  • jit/JITOpcodes.cpp: (JSC::JIT::emit_op_enter):
  • jit/JITOperations.cpp:
  • jit/JITToDFGDeferredCompilationCallback.cpp: (JSC::JITToDFGDeferredCompilationCallback::create): (JSC::JITToDFGDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously): (JSC::JITToDFGDeferredCompilationCallback::compilationDidComplete):
  • jit/JITToDFGDeferredCompilationCallback.h:
  • jit/Repatch.cpp: (JSC::tryCacheGetByID): (JSC::tryCachePutByID): (JSC::tryRepatchIn): (JSC::linkFor): (JSC::linkPolymorphicCall):
  • llint/LLIntSlowPaths.cpp: (JSC::LLInt::LLINT_SLOW_PATH_DECL): (JSC::LLInt::setUpCall):
  • runtime/CommonSlowPaths.cpp: (JSC::SLOW_PATH_DECL):
  • runtime/CommonSlowPaths.h: (JSC::CommonSlowPaths::tryCachePutToScopeGlobal): (JSC::CommonSlowPaths::tryCacheGetFromScopeGlobal):
  • runtime/Executable.cpp: (JSC::ExecutableBase::clearCode): (JSC::ScriptExecutable::installCode): (JSC::ScriptExecutable::newCodeBlockFor): (JSC::ScriptExecutable::newReplacementCodeBlockFor): (JSC::ScriptExecutable::prepareForExecutionImpl): (JSC::EvalExecutable::visitChildren): (JSC::EvalExecutable::clearCode): (JSC::ProgramExecutable::checkSyntax): (JSC::ProgramExecutable::visitChildren): (JSC::ProgramExecutable::clearCode): (JSC::ModuleProgramExecutable::visitChildren): (JSC::ModuleProgramExecutable::clearCode): (JSC::FunctionExecutable::baselineCodeBlockFor): (JSC::FunctionExecutable::visitChildren): (JSC::FunctionExecutable::clearCode): (JSC::FunctionExecutable::fromGlobalCode): (JSC::WebAssemblyExecutable::visitChildren): (JSC::WebAssemblyExecutable::clearCode): (JSC::WebAssemblyExecutable::prepareForExecution):
  • runtime/Executable.h: (JSC::ExecutableBase::generatedJITCodeForCall): (JSC::ScriptExecutable::prepareForExecution): (JSC::ExecutableBase::clearCodeVirtual):
  • runtime/VM.cpp: (JSC::VM::VM):
  • runtime/VM.h:
9:35 PM Changeset in webkit [190452] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] Unreviewed build fix for run-api-tests

  • Scripts/run-api-tests:

(testToolPaths): Windows run needs to specify the binary path.

9:27 PM Changeset in webkit [190451] by Wenson Hsieh
  • 2 edits
    2 adds
    1 delete in trunk

Convert focused-input-should-assist-on-touch.html into an automated test
https://bugs.webkit.org/show_bug.cgi?id=149724

Reviewed by Simon Fraser.

.:

Remove a manual test that can now be rewritten as an automated test.

  • ManualTests/ios/focused-input-should-assist-on-touch.html: Removed.

LayoutTests:

Tests that an input that focuses itself on touch and then prevents default is
able to trigger node assistance, even when it is already focused before the
user gesture.

  • fast/events/ios/focused-input-should-assist-on-touch-expected.txt: Added.
  • fast/events/ios/focused-input-should-assist-on-touch.html: Added.
8:45 PM Changeset in webkit [190450] by ggaren@apple.com
  • 44 edits in trunk/Source/JavaScriptCore

CodeBlock should be a GC object
https://bugs.webkit.org/show_bug.cgi?id=149727

Reviewed by Filip Pizlo.

We want CodeBlock to be a GC object:

(1) Sane write barriers. Because CodeBlock wasn't a GC object, we couldn't
execute a write barrier on it. This caused us to do weird things that
were hard to reason about, like executing a barrier on a related executable
(even though the executable might stop pointing to the CodeBlock before
the next GC), or pretending that an object had written to itself. Now,
when we write to a CodeBlock, we barrier the CodeBlock, and that's that.

(2) Simpler marking and destruction logic. There's no need to have a
custom remembered set or a destruction fixpoint if we just obey normal
GC rules.

  • bytecode/CodeBlock.cpp:

(JSC::FunctionCodeBlock::destroy):
(JSC::WebAssemblyCodeBlock::destroy):
(JSC::ProgramCodeBlock::destroy):
(JSC::ModuleProgramCodeBlock::destroy):
(JSC::EvalCodeBlock::destroy): Add ClassInfo and destroy functions
because our GC object model requires them.

Note that we do not set the needsDestruction flag. Since CodeBlock needs
eager destruction, it runs its destructors through CodeBlockSet,
and not through normal object sweeping.

(JSC::CodeBlock::finishCreation): Factor out finishCreation from the
constructor because our GC object model requires it. Change write
barriers to note the CodeBlock as the owner.

(JSC::CodeBlock::~CodeBlock): Refactor to use the shared
unlinkIncomingCalls() function instead of rolling a copy by hand.

(JSC::CodeBlock::visitWeakly): New helper function for owner executables
to do weak marking that might jettison a CodeBlock. Our new GC logic
says that a CodeBlock pointer is a strong reference by default, and
clients need to opt in if they want to allow a CodeBlock to jettison.
This is easier to get right because it means that only those
specific owners that want jettison behavior need to worry about it,
while all other pointers are valid by default.

(JSC::CodeBlock::visitChildren): The default visit function keeps
everything alive.

(JSC::CodeBlock::shouldVisitStrongly):
(JSC::CodeBlock::isKnownToBeLiveDuringGC): No need to keep special state
anymore. If we're marked, we're live -- just like any other object.

(JSC::timeToLive): Move this code into CodeBlock.cpp so you can mess
with it without recompiling, and also because it's really a CodeBlock
policy.

(JSC::CodeBlock::WeakReferenceHarvester::visitWeakReferences):
(JSC::CodeBlock::UnconditionalFinalizer::finalizeUnconditionally): Use
internal objects for virtual callbacks because GC objects can't have
vtables.

(JSC::CodeBlock::unlinkIncomingCalls): Remove a fast path check that does
not exist in the copy of this code in ~CodeBlock because it is not
actually an optimization.

(JSC::CodeBlock::replacement):
(JSC::CodeBlock::computeCapabilityLevel): Make these functions generic
instead of virtual because GC objects can't have vtables.

(JSC::CodeBlock::visitStrongly): Deleted.
(JSC::CodeBlock::visitAggregate): Deleted.
(JSC::CodeBlock::visitWeakReferences): Deleted.
(JSC::CodeBlock::finalizeUnconditionally): Deleted.
(JSC::ProgramCodeBlock::replacement): Deleted.
(JSC::ModuleProgramCodeBlock::replacement): Deleted.
(JSC::EvalCodeBlock::replacement): Deleted.
(JSC::FunctionCodeBlock::replacement): Deleted.
(JSC::ProgramCodeBlock::capabilityLevelInternal): Deleted.
(JSC::ModuleProgramCodeBlock::capabilityLevelInternal): Deleted.
(JSC::EvalCodeBlock::capabilityLevelInternal): Deleted.
(JSC::FunctionCodeBlock::capabilityLevelInternal): Deleted.
(JSC::WebAssemblyCodeBlock::replacement): Deleted.
(JSC::WebAssemblyCodeBlock::capabilityLevelInternal): Deleted.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::unlinkedCodeBlock):
(JSC::CodeBlock::addressOfNumParameters):
(JSC::CodeBlock::offsetOfNumParameters):
(JSC::CodeBlock::alternative):
(JSC::CodeBlock::forEachRelatedCodeBlock):
(JSC::CodeBlock::specializationKind):
(JSC::CodeBlock::instructionCount):
(JSC::CodeBlock::setJITCode):
(JSC::CodeBlock::hasBaselineJITProfiling):
(JSC::CodeBlock::capabilityLevelState):
(JSC::CodeBlock::addConstant):
(JSC::CodeBlock::appendExceptionHandler):
(JSC::CodeBlock::setConstantRegisters):
(JSC::CodeBlock::replaceConstant):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::create):
(JSC::ProgramCodeBlock::createStructure):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::ModuleProgramCodeBlock::create):
(JSC::ModuleProgramCodeBlock::createStructure):
(JSC::ModuleProgramCodeBlock::ModuleProgramCodeBlock):
(JSC::EvalCodeBlock::create):
(JSC::EvalCodeBlock::createStructure):
(JSC::EvalCodeBlock::variable):
(JSC::EvalCodeBlock::numVariables):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::EvalCodeBlock::unlinkedEvalCodeBlock):
(JSC::FunctionCodeBlock::create):
(JSC::FunctionCodeBlock::createStructure):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
(JSC::WebAssemblyCodeBlock::create):
(JSC::WebAssemblyCodeBlock::createStructure):
(JSC::WebAssemblyCodeBlock::WebAssemblyCodeBlock):
(JSC::ExecState::uncheckedR):
(JSC::CodeBlock::clearVisitWeaklyHasBeenCalled):
(JSC::CodeBlockSet::mark):
(JSC::ScriptExecutable::forEachCodeBlock):
(JSC::CodeBlock::setAlternative): Deleted.
(JSC::CodeBlock::clearMarks): Deleted. Lots of mechanical changes to
match the logic changes above.

  • bytecode/DeferredCompilationCallback.cpp:

(JSC::DeferredCompilationCallback::DeferredCompilationCallback):
(JSC::DeferredCompilationCallback::~DeferredCompilationCallback):
(JSC::DeferredCompilationCallback::compilationDidComplete):

  • bytecode/DeferredCompilationCallback.h: Provide a profiledDFGCodeBlock

to all compilation callbacks instead of requiring the callback to
store the profiledDFGCodeBlock. This is how the rest of compilation
around the callback works anyway, and it is easier to do things this
way than to think about how a non-GC malloc'd object should keep its
CodeBlock alive.

  • bytecode/EvalCodeCache.h:

(JSC::EvalCodeCache::tryGet):
(JSC::EvalCodeCache::getSlow):

  • bytecode/PolymorphicAccess.cpp:

(JSC::AccessCase::generate):
(JSC::PolymorphicAccess::regenerate):

  • bytecode/StructureStubInfo.cpp:

(JSC::StructureStubInfo::addAccessCase): Change the owner for write
barrier purposes to CodeBlock.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGDesiredTransitions.cpp:

(JSC::DFG::DesiredTransition::reallyAdd):

  • dfg/DFGDesiredWeakReferences.cpp:

(JSC::DFG::DesiredWeakReferences::reallyAdd):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compile):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::Graph): Ditto.

  • dfg/DFGJITCode.h:

(JSC::DFG::JITCode::osrEntryBlock):
(JSC::DFG::JITCode::setOSREntryBlock):
(JSC::DFG::JITCode::clearOSREntryBlock): Use helper functions for
accessing osrEntryBlock to help with write barrier stuff.

  • dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::finalize):
(JSC::DFG::JITFinalizer::finalizeFunction):
(JSC::DFG::JITFinalizer::finalizeCommon):

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::adjustAndJumpToTarget): Use CodeBlock as owner instead of
executable.

  • dfg/DFGOperations.cpp:
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::reallyAdd):
(JSC::DFG::Plan::notifyReady):
(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):
(JSC::DFG::Plan::finalizeAndNotifyCallback):
(JSC::DFG::Plan::key):
(JSC::DFG::Plan::rememberCodeBlocks):
(JSC::DFG::Plan::checkLivenessAndVisitChildren):
(JSC::DFG::Plan::clearCodeBlockMarks): Deleted.

  • dfg/DFGPlan.h: Use normal GC write barrier concepts to model the fact

that the compiler writes to CodeBlocks.

  • dfg/DFGToFTLDeferredCompilationCallback.cpp:

(JSC::DFG::ToFTLDeferredCompilationCallback::ToFTLDeferredCompilationCallback):
(JSC::DFG::ToFTLDeferredCompilationCallback::~ToFTLDeferredCompilationCallback):
(JSC::DFG::ToFTLDeferredCompilationCallback::create):
(JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::DFG::ToFTLDeferredCompilationCallback::compilationDidComplete):

  • dfg/DFGToFTLDeferredCompilationCallback.h:
  • dfg/DFGToFTLForOSREntryDeferredCompilationCallback.cpp:

(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::ToFTLForOSREntryDeferredCompilationCallback):
(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::~ToFTLForOSREntryDeferredCompilationCallback):
(JSC::DFG::Ref<ToFTLForOSREntryDeferredCompilationCallback>ToFTLForOSREntryDeferredCompilationCallback::create):
(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::DFG::ToFTLForOSREntryDeferredCompilationCallback::compilationDidComplete):

  • dfg/DFGToFTLForOSREntryDeferredCompilationCallback.h: We always have

a profiledDFGCodeBlock passed to use -- see above.

  • dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::completeAllPlansForVM):
(JSC::DFG::Worklist::rememberCodeBlocks):
(JSC::DFG::completeAllPlansForVM):
(JSC::DFG::rememberCodeBlocks):
(JSC::DFG::Worklist::clearCodeBlockMarks): Deleted.
(JSC::DFG::clearCodeBlockMarks): Deleted.

  • dfg/DFGWorklist.h:

(JSC::DFG::worklistForIndexOrNull): Renamed to use remembered set terminology.

  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeFunction):

  • heap/CodeBlockSet.cpp:

(JSC::CodeBlockSet::~CodeBlockSet):
(JSC::CodeBlockSet::add):
(JSC::CodeBlockSet::clearMarksForFullCollection):
(JSC::CodeBlockSet::deleteUnmarkedAndUnreferenced): No need for a fixpoint
anymore since the GC can tell us if we are live.

(JSC::CodeBlockSet::remove):
(JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):
(JSC::CodeBlockSet::dump):
(JSC::CodeBlockSet::clearMarksForEdenCollection): Deleted. No need for
this logic anymore since the GC will clear our mark bit.

(JSC::CodeBlockSet::traceMarked): Deleted. No need for this marking
fixpoint anymore either.

  • heap/CodeBlockSet.h:
  • heap/Heap.cpp:

(JSC::Heap::markRoots): Moved some of this logic around to make the
algorithm clearer.

(JSC::Heap::deleteAllCodeBlocks): Deleting CodeBlocks can only clear
pointers immediately; they won't fully delete until the next GC and sweep.

  • interpreter/Interpreter.cpp:

(JSC::eval):

  • jit/GCAwareJITStubRoutine.h: CodeBlock is owner now.
  • jit/JITCode.h:

(JSC::JITCode::isJIT):
(JSC::JITCode::isLowerTier):
(JSC::JITCode::timeToLive): Deleted.

  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_enter): CodeBlock is owner now.

  • jit/JITOperations.cpp:
  • jit/JITToDFGDeferredCompilationCallback.cpp:

(JSC::JITToDFGDeferredCompilationCallback::create):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidBecomeReadyAsynchronously):
(JSC::JITToDFGDeferredCompilationCallback::compilationDidComplete):

  • jit/JITToDFGDeferredCompilationCallback.h:
  • jit/Repatch.cpp:

(JSC::tryCacheGetByID):
(JSC::tryCachePutByID):
(JSC::tryRepatchIn):
(JSC::linkFor):
(JSC::linkPolymorphicCall):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):
(JSC::LLInt::setUpCall):

  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/CommonSlowPaths.h:

(JSC::CommonSlowPaths::tryCachePutToScopeGlobal):
(JSC::CommonSlowPaths::tryCacheGetFromScopeGlobal): CodeBlock is owner now.

  • runtime/Executable.cpp:

(JSC::ExecutableBase::clearCode): Provide a generic clearCode() so that
it can be used on any Executable. This fixes a very subtle bug where
deleteAllCode() does not remove CodeBlocks from non-function executables
that have been saved in stack traces.

(JSC::ScriptExecutable::installCode): WriteBarrier requires special
handling for pointers that may be null.

(JSC::ScriptExecutable::newCodeBlockFor):
(JSC::ScriptExecutable::newReplacementCodeBlockFor):
(JSC::ScriptExecutable::prepareForExecutionImpl): Update for interface
changes.

(JSC::EvalExecutable::visitChildren):
(JSC::ProgramExecutable::visitChildren):
(JSC::ModuleProgramExecutable::visitChildren):
(JSC::FunctionExecutable::visitChildren):
(JSC::WebAssemblyExecutable::visitChildren): Visit weakly because we want
to participate in jettisoning.

(JSC::WebAssemblyExecutable::prepareForExecution):
(JSC::EvalExecutable::clearCode): Deleted.
(JSC::ProgramExecutable::clearCode): Deleted.
(JSC::ModuleProgramExecutable::clearCode): Deleted.
(JSC::FunctionExecutable::clearCode): Deleted.
(JSC::WebAssemblyExecutable::clearCode): Deleted.

  • runtime/Executable.h:

(JSC::ExecutableBase::generatedJITCodeForCall):
(JSC::ScriptExecutable::prepareForExecution):
(JSC::ExecutableBase::clearCodeVirtual): Deleted.

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h: Provide structures because our GC requires it.
7:15 PM Changeset in webkit [190449] by dino@apple.com
  • 8 edits
    2 deletes in trunk

Rollout r190446 for the moment. It broke the build.

6:53 PM Changeset in webkit [190448] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Simplify filterableData processing
https://bugs.webkit.org/show_bug.cgi?id=149730

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-01
Reviewed by Timothy Hatcher.

  • UserInterface/Views/BreakpointTreeElement.js:

(WebInspector.BreakpointTreeElement.prototype.get filterableData):

  • UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype.applyFiltersToTreeElement.matchTextFilter):

  • UserInterface/Views/ResourceTreeElement.js:

(WebInspector.ResourceTreeElement.prototype.get filterableData):

  • UserInterface/Views/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView.prototype.matchTreeElementAgainstCustomFilters): Deleted.

  • UserInterface/Views/SearchResultTreeElement.js:

(WebInspector.SearchResultTreeElement.prototype.get filterableData):
(WebInspector.SearchResultTreeElement):

6:29 PM Changeset in webkit [190447] by ljaehun.lim@samsung.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix build warning after r190434

Fix error: variable ‘interruption’ set but not used [-Werror=unused-but-set-variable]

  • testing/Internals.cpp:

(WebCore::Internals::beginMediaSessionInterruption):

6:09 PM Changeset in webkit [190446] by dino@apple.com
  • 8 edits
    2 adds in trunk

Expose WEBGL_debug_renderer_info
https://bugs.webkit.org/show_bug.cgi?id=149735
<rdar://problem/18343500>

Reviewed by Simon Fraser.

Source/WebCore:

Enable the extension that allows content to query
for the GPUs vendor and details.

Now that we're enabling this, there was no need for
the internal setting that identified privileged situations.
However, since this meant that WEBGL_debug_shaders was
also exposed, I explicitly disable it since it is
not yet conformant.

Test: fast/canvas/webgl/webgl-debug-renderer-info.html
as well as the general conformance suite.

  • html/canvas/WebGL2RenderingContext.cpp: No need to guard around allowPrivilegedExtensions().

(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContext.cpp: Ditto.

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::allowPrivilegedExtensions): Deleted.

  • html/canvas/WebGLRenderingContextBase.h:
  • page/Settings.in: Remove privilegedWebGLExtensions.
  • platform/graphics/opengl/Extensions3DOpenGL.cpp: Forbid the translated shader

extension while it is still buggy.
(WebCore::Extensions3DOpenGL::supportsExtension):

LayoutTests:

Modify a test from the 1.0.2 conformance suite to make sure
we're actually enabling and passing the info.

  • fast/canvas/webgl/webgl-debug-renderer-info-expected.txt: Added.
  • fast/canvas/webgl/webgl-debug-renderer-info.html: Added.
6:03 PM Changeset in webkit [190445] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.2.7.2

New tag.

6:01 PM Changeset in webkit [190444] by bshafiei@apple.com
  • 5 edits in branches/safari-601.2.7-branch/Source

Versioning.

5:56 PM Changeset in webkit [190443] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.25.1

New tag.

5:56 PM Changeset in webkit [190442] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.2.7.1

New tag.

5:21 PM Changeset in webkit [190441] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Rebaselining fast/text/mark-matches-overflow-clip.html for Win
https://webkit.org/b/149728

Unreviewed test gardening.

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-01

  • platform/win/fast/text/mark-matches-overflow-clip-expected.txt:
5:09 PM Changeset in webkit [190440] by Brent Fulgham
  • 4 edits in trunk

.:
[Win] Unreviewed CMake build fix.

  • Source/cmake/OptionsWin.cmake: Clean up options setttings,

and make sure exception handling is turned off.

Tools:
Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)

Following r190424 we can now rely on webkit-build-directory to return the path to
the correct configuration-specific build directory on Windows.

Patch by Daniel Bates <dabates@apple.com> on 2015-10-01

  • BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):

5:03 PM Changeset in webkit [190439] by dbates@webkit.org
  • 2 edits in trunk/Tools

Another attempt to fix the Windows builders after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)

Following r190424 we can now rely on webkit-build-directory to return the path to
the correct configuration-specific build directory on Windows.

  • BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):

4:43 PM Changeset in webkit [190438] by Brent Fulgham
  • 3 edits in trunk/LayoutTests

Unreviewed test fix after r190434.

One test was not updated to pass the new required interruption type
argument to 'internals.beginMediaSessionInterruption'.

  • webaudio/audiocontext-state-interrupted-expected.txt:
  • webaudio/audiocontext-state-interrupted.html:
4:34 PM Changeset in webkit [190437] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Do not immediately create all ProfileNodeTreeElements when showing JavaScript and Events timeline
https://bugs.webkit.org/show_bug.cgi?id=149726

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-01
Reviewed by Timothy Hatcher.

  • UserInterface/Views/NavigationSidebarPanel.js:

(WebInspector.NavigationSidebarPanel.prototype.shouldFilterPopulate):
(WebInspector.NavigationSidebarPanel.prototype._updateFilter):
(WebInspector.NavigationSidebarPanel.prototype._treeElementAddedOrChanged):
We were populating during filtering if there were any custom filters.
However the TimelineSidebarPanel has custom filters (based on time and type)
but those don't need to trigger population. Delay population until it
would actually be needed (like a text search).

  • UserInterface/Views/TimelineSidebarPanel.js:

(WebInspector.TimelineSidebarPanel.prototype.shouldFilterPopulate):
Do not populate on filter via this custom filters.

4:33 PM Changeset in webkit [190436] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION (r189567): Toolbar collapses when inspector at minimum height with console open
https://bugs.webkit.org/show_bug.cgi?id=149725

Reviewed by Timothy Hatcher.

CSS Flexible Box Layout Module Level 1 introduces a new auto initial value for the min-{width|height}
of flex box items, breaking some areas of the inspector UI. This is fixed by setting a min-height of
zero for the #main <div>.

  • UserInterface/Views/Main.css:

(#main):

4:21 PM Changeset in webkit [190435] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove unnecessary SpecialFastCaseProfiles.
https://bugs.webkit.org/show_bug.cgi?id=149729

Reviewed by Saam Barati.

The current baseline code creates special fast case profiles records for
bytecodes that don't need them. This was done to keep the DFG from crashing when
it searches for such a profile and don't find one. Instead, we will fix the code
to check for the existence of the profile before dereferencing it to get a count.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::specialFastCaseProfileCountForBytecodeOffset):
(JSC::CodeBlock::couldTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::numberOfArrayProfiles):
(JSC::CodeBlock::arrayProfiles):
(JSC::CodeBlock::addArrayProfile):
(JSC::CodeBlock::likelyToTakeSpecialFastCase): Deleted. Not used.
(JSC::CodeBlock::likelyToTakeAnySlowCase): Deleted. Not used.

  • jit/JITArithmetic.cpp:

(JSC::JIT::compileBinaryArithOp):

  • Only op_mul needs the profile. So, only allocate it in the op_mul case.

(JSC::JIT::emit_op_mul):

  • These op_mul cases create the profile but never increments its counter. Hence, we can get rid of these.
3:32 PM Changeset in webkit [190434] by Brent Fulgham
  • 18 edits in trunk

[iOS] AirPlay should not stop when the screen locks
https://bugs.webkit.org/show_bug.cgi?id=148315
<rdar://problem/22770703>

Patch by Eric Carlson <eric.carlson@apple.com> on 2015-10-01
Reviewed by Jer Noble.

Source/WebCore:

Tested by media/video-interruption-with-resume-allowing-play.html

media/video-interruption-with-resume-not-allowing-play.html

  • Modules/webaudio/AudioContext.h: overrideBackgroundPlaybackRestriction -> shouldOverrideBackgroundPlaybackRestriction.
  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::suspendPlayback): Fix a typo in the logging.
(WebCore::HTMLMediaElement::mayResumePlayback): Ditto.
(WebCore::HTMLMediaElement::shouldOverrideBackgroundPlaybackRestriction): Renamed from

overrideBackgroundPlaybackRestriction.

(WebCore::HTMLMediaElement::overrideBackgroundPlaybackRestriction): Deleted.

  • html/HTMLMediaElement.h:
  • platform/audio/PlatformMediaSession.cpp:

(WebCore::stateName):
(WebCore::interruptionName): New, log the name of the interruption.
(WebCore::PlatformMediaSession::beginInterruption): Log the interruption type. Don't

increment the interruption counter if we are going to ignore it. Incorporate logic
from doInterruption.

(WebCore::PlatformMediaSession::doInterruption): Deleted.
(WebCore::PlatformMediaSession::shouldDoInterruption): Deleted.
(WebCore::PlatformMediaSession::forceInterruption): Deleted.

  • platform/audio/PlatformMediaSession.h: Add SuspendedUnderLock interruption type.
  • platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::applicationDidEnterBackground): Deleted.

  • platform/audio/PlatformMediaSessionManager.h:
  • platform/audio/ios/MediaSessionManagerIOS.h:
  • platform/audio/ios/MediaSessionManagerIOS.mm:

(WebCore::MediaSessionManageriOS::applicationDidEnterBackground): Call beginInterruption

when appropriate.

LayoutTests:

  • media/video-interruption-with-resume-allowing-play.html:
  • media/video-interruption-with-resume-not-allowing-play.html:
2:40 PM Changeset in webkit [190433] by bshafiei@apple.com
  • 3 edits
    6 copies in branches/safari-601.2.7-branch

Merged r190418. rdar://problem/22936771

2:37 PM Changeset in webkit [190432] by bshafiei@apple.com
  • 5 edits in branches/safari-601.2.7-branch/Source

Versioning.

1:47 PM Changeset in webkit [190431] by bshafiei@apple.com
  • 3 edits
    6 copies in branches/safari-601.1.46.25-branch

Merged r190418. rdar://problem/22936628

1:36 PM Changeset in webkit [190430] by rniwa@webkit.org
  • 3 edits
    4 adds in trunk

Slot elements should support fallback contents
https://bugs.webkit.org/show_bug.cgi?id=149701

Reviewed by Antti Koivisto.

Source/WebCore:

Following discussions on Github discussions [1] [2], we're adding the default rule of display: contents
on slot elements and making slot elements render its children when there are no assigned nodes [3].

Make these changes by attaching renderers on direct-children of slot elements when there are no assigned
nodes during render tree construction. Note display: contents will be aded in webkit.org/b/149439.

[1] https://github.com/w3c/webcomponents/issues/317
[2] https://github.com/w3c/webcomponents/issues/308
[3] https://github.com/w3c/webcomponents/issues/308#issuecomment-143655347

Tests: fast/shadow-dom/css-scoping-shadow-slot-fallback.html

fast/shadow-dom/shadow-layout-after-slot-fallback-changes.html

  • style/StyleResolveTree.cpp:

(WebCore::Style::attachSlotAssignees):
(WebCore::Style::detachSlotAssignees):
(WebCore::Style::resolveSlotAssignees):

LayoutTests:

Added tests for fallback contents in slot elements. One of them could be safely submitted to CSS WG,
and the other one is a style recalc test.

  • fast/shadow-dom/css-scoping-shadow-slot-fallback-expected.html: Added.
  • fast/shadow-dom/css-scoping-shadow-slot-fallback.html: Added.
  • fast/shadow-dom/shadow-layout-after-slot-fallback-changes-expected.html: Added.
  • fast/shadow-dom/shadow-layout-after-slot-fallback-changes.html: Added.
1:24 PM Writing Layout Tests to test iOS UI features edited by Wenson Hsieh
Added documentation on key event testing to UIScriptController wiki page (diff)
1:20 PM Changeset in webkit [190429] by keith_miller@apple.com
  • 19 edits
    1 copy
    21 adds in trunk

[ES6] Add TypedArray.prototype functionality.
https://bugs.webkit.org/show_bug.cgi?id=148035

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This patch should add most of the functionality for
the prototype properties of TypedArray objects in ES6.
There are a few exceptions to this, which will be added
in upcoming patches:

1) First we do not use the species constructor for some
of the TypedArray prototype functions (namely: map, filter,
slice, and subarray). That will need to be added when
species constructors are finished.

2) TypedArrays still have a length, byteOffset, byteLength,
and buffer are still attached to the TypedArray instance (in
the spec they are on the TypedArray.prototype instance object)
since the JIT currently assumes those properties are fixed.

3) The TypedArray.constructor property is not added yet
as it should point to the TypedArray instance object,
which will be added in a future patch.

(every):
(find):
(findIndex):
(forEach):
(some):
(sort.min):
(sort.merge):
(sort.mergeSort):
(sort):
(reduce):
(reduceRight):
(map):
(filter):
(toLocaleString):

  • runtime/ArrayPrototype.cpp:
  • runtime/ArrayPrototype.h:
  • runtime/CommonIdentifiers.h:
  • runtime/JSGenericTypedArrayView.h:

(JSC::JSGenericTypedArrayView::toAdaptorNativeFromValue):
(JSC::JSGenericTypedArrayView::setRangeToValue):
(JSC::JSGenericTypedArrayView::sort):
(JSC::JSGenericTypedArrayView::purifyArray):
(JSC::JSGenericTypedArrayView::sortComparison):
(JSC::JSGenericTypedArrayView::sortFloat):

  • runtime/JSGenericTypedArrayViewInlines.h:
  • runtime/JSGenericTypedArrayViewPrototypeFunctions.h: Added.

(JSC::argumentClampedIndexFromStartOrEnd):
(JSC::genericTypedArrayViewProtoFuncSet):
(JSC::genericTypedArrayViewProtoFuncEntries):
(JSC::genericTypedArrayViewProtoFuncCopyWithin):
(JSC::genericTypedArrayViewProtoFuncFill):
(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncJoin):
(JSC::genericTypedArrayViewProtoFuncKeys):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):
(JSC::genericTypedArrayViewProtoGetterFuncLength):
(JSC::genericTypedArrayViewProtoGetterFuncByteLength):
(JSC::genericTypedArrayViewProtoGetterFuncByteOffset):
(JSC::genericTypedArrayViewProtoFuncReverse):
(JSC::genericTypedArrayViewPrivateFuncSort):
(JSC::genericTypedArrayViewProtoFuncSlice):
(JSC::genericTypedArrayViewProtoFuncSubarray):
(JSC::typedArrayViewProtoFuncValues):

  • runtime/JSGenericTypedArrayViewPrototypeInlines.h:

(JSC::JSGenericTypedArrayViewPrototype<ViewClass>::finishCreation):
(JSC::genericTypedArrayViewProtoFuncSet): Deleted.
(JSC::genericTypedArrayViewProtoFuncSubarray): Deleted.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/JSObject.h:
  • runtime/JSTypedArrayPrototypes.cpp:
  • runtime/JSTypedArrayPrototypes.h:
  • runtime/JSTypedArrayViewPrototype.cpp: Added.

(JSC::typedArrayViewPrivateFuncLength):
(JSC::typedArrayViewPrivateFuncSort):
(JSC::typedArrayViewProtoFuncSet):
(JSC::typedArrayViewProtoFuncEntries):
(JSC::typedArrayViewProtoFuncCopyWithin):
(JSC::typedArrayViewProtoFuncFill):
(JSC::typedArrayViewProtoFuncLastIndexOf):
(JSC::typedArrayViewProtoFuncIndexOf):
(JSC::typedArrayViewProtoFuncJoin):
(JSC::typedArrayViewProtoFuncKeys):
(JSC::typedArrayViewProtoGetterFuncLength):
(JSC::typedArrayViewProtoGetterFuncByteLength):
(JSC::typedArrayViewProtoGetterFuncByteOffset):
(JSC::typedArrayViewProtoFuncReverse):
(JSC::typedArrayViewProtoFuncSubarray):
(JSC::typedArrayViewProtoFuncSlice):
(JSC::typedArrayViewProtoFuncValues):
(JSC::JSTypedArrayViewPrototype::JSTypedArrayViewPrototype):
(JSC::JSTypedArrayViewPrototype::finishCreation):
(JSC::JSTypedArrayViewPrototype::create):
(JSC::JSTypedArrayViewPrototype::createStructure):

  • runtime/JSTypedArrayViewPrototype.h: Copied from Source/JavaScriptCore/runtime/JSTypedArrayPrototypes.cpp.
  • tests/es6.yaml:
  • tests/stress/resources/standalone-pre.js: Added.

(description):
(debug):
(escapeString):
(testPassed):
(testFailed):
(areNumbersEqual):
(areArraysEqual):
(isMinusZero):
(isTypedArray):
(isResultCorrect):
(stringify):
(shouldBe):
(dfgShouldBe):
(shouldBeType):
(shouldBeTrue):
(shouldBeFalse):
(shouldBeNaN):
(shouldBeNull):
(shouldBeEqualToString):
(shouldBeUndefined):
(shouldNotThrow):
(shouldThrow):
(dfgCompiled):
(dfgIncrement):
(noInline):
(finishJSTest):

  • tests/stress/resources/typedarray-test-helper-functions.js: Added.

(forEachTypedArray):
(isSameFunctionForEachTypedArrayPrototype.eq):
(isSameFunctionForEachTypedArrayPrototype):
(hasSameValues):
(foo):
(testPrototypeFunctionHelper):
(testPrototypeFunctionOnSigned):
(testPrototypeFunctionOnFloat):
(testPrototypeFunction):
(tester):
(testPrototypeReceivesArray):

  • tests/stress/typedarray-copyWithin.js: Added.
  • tests/stress/typedarray-every.js: Added.

(isBigEnough):
(isBigEnoughAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-fill.js: Added.
  • tests/stress/typedarray-filter.js: Added.

(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-find.js: Added.

(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-findIndex.js: Added.

(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-forEach.js: Added.

(checkCorrect.let.list):
(checkCorrect):
(createChecker):
(foo):
(changeArray):
(isBigEnoughAndException):

  • tests/stress/typedarray-indexOf.js: Added.

(keepEven):

  • tests/stress/typedarray-lastIndexOf.js: Added.
  • tests/stress/typedarray-map.js: Added.

(even):
(evenAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-reduce.js: Added.

(createArray):
(sum):
(createArrayAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-reduceRight.js: Added.

(createArray):
(sum):
(createArrayAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-slice.js: Added.
  • tests/stress/typedarray-some.js: Added.

(isBigEnough):
(isBigEnoughAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-sort.js: Added.

(sortBackwards):
(compareException):

LayoutTests:

Fixed tests for new toString behavior on TypedArrays.

  • fast/canvas/webgl/type-conversion-test-expected.txt:
  • fast/dom/Window/window-postmessage-clone-expected.txt:
1:18 PM Changeset in webkit [190428] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] Fix TestWebKitAPI build under CMake.

Reviewed by Alex Christensen.

  • TestWebKitAPI/PlatformWin.cmake: Add missing link command

for Psapi.lib.

1:05 PM Changeset in webkit [190427] by bshafiei@apple.com
  • 3 edits in branches/safari-601.1.46.25-branch/Source/WebCore

Merged r188298. rdar://problem/22936040

12:54 PM Changeset in webkit [190426] by Nikita Vasilyev
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Clip string previews
https://bugs.webkit.org/show_bug.cgi?id=149708

Only show first 140 characters in strings previews.

Reviewed by Joseph Pecoraro.

  • UserInterface/Base/Utilities.js:

(String.prototype.truncate): Added.
A smart trancate function that doesn't split words.

  • UserInterface/Views/ConsoleMessageView.js:

(WebInspector.ConsoleMessageView.prototype._shouldConsiderObjectLossless):

  • UserInterface/Views/FormattedValue.js:

(WebInspector.FormattedValue.createElementForTypesAndValue):

12:50 PM Changeset in webkit [190425] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

[Win] Another CMake build fix

  • PlatformWin.cmake: Add missing Psapi.lib to link list.
12:38 PM Changeset in webkit [190424] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] Fix behavior of webkit-build-directory script
https://bugs.webkit.org/show_bug.cgi?id=149718

Reviewed by Alex Christensen.

  • Scripts/webkitdirs.pm:

(determineConfigurationProductDir): Do not include the binary
sub-directory in the configuration product directory output.
(jscProductDir): Append correct binary path for Windows build.
(setPathForRunningWebKitApp): Include properly binary subdirectories.
(runSafari): Update for revised productDir behavior.
(runMiniBrowser): Ditto.

12:31 PM Changeset in webkit [190423] by Brent Fulgham
  • 3 edits
    2 adds in trunk

Latch does not clear when a scroll snap animation is triggered
https://bugs.webkit.org/show_bug.cgi?id=149681
<rdar://problem/22733922>

Reviewed by Simon Fraser.

Source/WebCore:

Test: tiled-drawing/scrolling/latched-div-with-scroll-snap.html

The scroll snap animation logic bypasses some of the normal clean-up code used
for wheel event handling. When this happens, the scroll latching state is not
cleared. In some cases this "stale" latch state is used when starting a new
gesture in the same frame. This causes the wrong page element to receive the
mouse wheel events, and hilarity ensues.

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::platformNotifyIfEndGesture): Clear latched state when
ending the gesture.

LayoutTests:

Add a new test that confirms latched state is cleared when scroll snap animations
are triggered.

  • tiled-drawing/scrolling/latched-div-with-scroll-snap-expected.txt: Added.
  • tiled-drawing/scrolling/latched-div-with-scroll-snap.html: Added.
12:12 PM Changeset in webkit [190422] by Simon Fraser
  • 4 edits in trunk/LayoutTests

Remove some tests that now pass.

  • TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
11:47 AM Changeset in webkit [190421] by Brent Fulgham
  • 9 edits in trunk/Source

[Win] Unreviewed CMake build fixes.

Source/WebCore:

  • CMakeLists.txt: Match original Windows build flags for WebCoreTest.
  • PlatformAppleWin.cmake: Use the same build defines as the

original Windows build.

Source/WebKit:

  • CMakeLists.txt: Set the same build definitions as the original

project file.

  • PlatformWin.cmake: Remove some soft-linked files from the static

link commands. Set build flags to match original project files.

Source/WTF:

  • wtf/CMakeLists.txt: Correct build flags to match

the original project files.

11:26 AM Changeset in webkit [190420] by Simon Fraser
  • 3 edits
    3 adds in trunk/LayoutTests

Add iOS touch event test
https://bugs.webkit.org/show_bug.cgi?id=149688

Reviewed by Ryosuke Niwa.

Basic touch event test that synthesizes touches in the UI process.

  • TestExpectations:
  • fast/events/touch/ios/touch-event-expected.txt: Added.
  • fast/events/touch/ios/touch-event.html: Added.
  • platform/ios-simulator-wk2/TestExpectations:
11:14 AM Changeset in webkit [190419] by ap@apple.com
  • 2 edits in trunk/Tools

Stop building LayoutTestRelay for now. It's a Mac project, but build-webkit tries to
use iOS SDK, like with all the others.

  • Scripts/build-webkit:
11:09 AM Changeset in webkit [190418] by Antti Koivisto
  • 3 edits
    6 adds in trunk

Network cache: Subresource referer header wrong after cached redirect
https://bugs.webkit.org/show_bug.cgi?id=149709
rdar://problem/22917174

Reviewed by Chris Dumez.

Source/WebKit2:

If a main resource is loaded from a cache entry that involved redirects the document
will end up setting the Referer-headers of the subresources to the request URL not the redirected URL

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):

If a cache entry involved a redirect synthesize a minimal willSendRequest message so that WebCore side
runs through the same code paths as when receiving a redirect from network.

LayoutTests:

  • http/tests/cache/redirect-referer-expected.html: Added.
  • http/tests/cache/redirect-referer.html: Added.
  • http/tests/cache/resources/load-and-check-referer.php: Added.
  • http/tests/cache/resources/permanent-redirect.php: Added.
  • http/tests/cache/resources/redirect-referer-iframe.html: Added.
  • http/tests/cache/resources/redirect-referer-iframe-expected.html: Added.
10:45 AM Changeset in webkit [190417] by mmaxfield@apple.com
  • 4 edits in trunk/LayoutTests

accessibility/mac/aria-expanded-notifications.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=149510

Reviewed by Chris Fleizach.

The problem is triggered by our resumable parser. AXLoadComplete gets called
synchronously from DocumentLoader::finishedLoading(). This means that the order of
the AXLoadComplete message isn't FIFO.

If the parser yielded previously, the AXLoadComplete will be handled after some AX
messages had been handled.

If the parser hadn't yielded, the AXLoadComplete will be the first message
processed (no matter what had been queued up before it).

Because making the AXLoadComplete message asynchonous is not desirable, the
solution is to relax the test to handle various orderings.

  • accessibility/mac/aria-expanded-notifications-expected.txt:
  • accessibility/mac/aria-expanded-notifications.html:
  • platform/mac/TestExpectations:
10:42 AM Changeset in webkit [190416] by BJ Burg
  • 6 edits in trunk/Source

Web Inspector: Adjust font size of Developer Tools using Command,+ or Command,-
https://bugs.webkit.org/show_bug.cgi?id=149590

Patch by João Oliveira <hello@jxs.pt> on 2015-09-30
Reviewed by Joseph Pecoraro.

Patch by João Oliveira and Brian Burg.

Source/WebCore:

Expose the frontend page's zoom factor so we can implement relative zoom.

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::zoomFactor): Added.

  • inspector/InspectorFrontendHost.h:
  • inspector/InspectorFrontendHost.idl:
  • page/Frame.h:

(WebCore::Frame::pageZoomFactor):

Source/WebInspectorUI:

  • UserInterface/Base/Main.js:

(WebInspector.contentLoaded): Add global keyboard shortcuts for zoom in and zoom out.

10:38 AM Changeset in webkit [190415] by dbates@webkit.org
  • 3 edits in trunk/Tools

Attempt to fix the iOS 9 Simulator testers

Add dependency DumpRenderTree.app to target All of project DumpRenderTree so that we
build DumpRenderTree.app, if applicable. Also, teach build-webkit to build project
LayoutTestRelay when building for iOS Simulator.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
  • Scripts/build-webkit:
10:20 AM Changeset in webkit [190414] by Yusuke Suzuki
  • 8 edits
    1 add in trunk/Source/JavaScriptCore

Introduce SymbolUse optimization into CompareEq and CompareStrictEq
https://bugs.webkit.org/show_bug.cgi?id=149616

Reviewed by Saam Barati.

Since ES6 Symbols are used as an enum value[1] (And WebKit inspector do so for Esprima's type of nodes),
optimizing equality comparison for symbols makes much sense.

This patch leverages SymbolUse for CompareEq and CompareStrictEq.
Optimizations for both DFG and FTL are implemented.

[1]: http://www.2ality.com/2014/12/es6-symbols.html

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateSymbol):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compare):
(JSC::DFG::SpeculativeJIT::compileStrictEq):
(JSC::DFG::SpeculativeJIT::extractStringImplFromBinarySymbols):
(JSC::DFG::SpeculativeJIT::compileSymbolEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleSymbolEquality):

  • dfg/DFGSpeculativeJIT.h:
  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileCompareEq):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCompareStrictEq):

  • tests/stress/symbol-equality.js: Added.

(shouldBe):
(equal):
(strictEqual):
(list.forEach.result.set 1):

10:18 AM Changeset in webkit [190413] by Carlos Garcia Campos
  • 6 edits in trunk

[GTK] Websites with invalid auth header keep loading forever
https://bugs.webkit.org/show_bug.cgi?id=149710

Reviewed by Martin Robinson.

Source/WebCore:

We don't correctly handle a null realm from the server when
retrieving and storing credentials from libsecret. First
secret_attributes_build() fails because we pass a null domain, and
we pass null attributes to secret_service_search() that returns
early on a g_return macro and the callback is never called so the
load doesn't continue after the auth challenge.

  • platform/network/gtk/CredentialBackingStore.cpp:

(WebCore::createAttributeHashTableFromChallenge):
(WebCore::CredentialBackingStore::credentialForChallenge):
(WebCore::CredentialBackingStore::storeCredentialsForChallenge):

Source/WebKit2:

Do not show the remember credentials checkbutton in the auth
dialog if the realm is empty.

  • UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:

(webkitAuthenticationDialogInitialize):

Tools:

Add test case to check that we can authenticate sites with an
empty realm.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:

(testWebViewAuthenticationEmptyRealm):
(serverCallback):
(beforeAll):

10:16 AM Changeset in webkit [190412] by ap@apple.com
  • 2 edits in trunk/Tools

[Mac] Make run-api-tests work with System Integrity Protection
https://bugs.webkit.org/show_bug.cgi?id=149711
rdar://problem/22928202

Reviewed by Dan Bernstein.

  • Scripts/run-api-tests:

(runTest):
(archCommandLineArgumentsForRestrictedEnvironmentVariables):

10:10 AM Changeset in webkit [190411] by dbates@webkit.org
  • 2 edits in trunk/Tools

Attempt to fix the Windows build after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)

For some reason built-product-archive hardcodes the assumption that we build for 32-bit Windows.
For now, use the path to the top-level WebKit build directory instead of using the configuration-
specific build directory.

  • BuildSlaveSupport/built-product-archive:

(archiveBuiltProduct):

9:43 AM Changeset in webkit [190410] by dbates@webkit.org
  • 3 edits
    7 moves
    7 adds
    1 delete in trunk/LayoutTests

Move <a ping> tests from LayoutTests/http/tests/navigation to LayoutTests/http/tests/navigation/ping-attribute
https://bugs.webkit.org/show_bug.cgi?id=148828

Reviewed by Alexey Proskuryakov.

Towards adding <area ping> tests (bug #79438), we should move the existing <a ping> tests from
LayoutTests/http/tests/navigation to LayoutTests/http/tests/navigation/ping-attribute and rename
them so as to make it clear from their name that they test the ping attribute on a HTML a element.

  • http/tests/navigation/ping-attribute/anchor-cookie-expected.txt: Renamed from LayoutTests/http/tests/navigation/ping-cookie-expected.txt.
  • http/tests/navigation/ping-attribute/anchor-cookie.html: Renamed from LayoutTests/http/tests/navigation/ping-cookie.html.
  • http/tests/navigation/ping-attribute/anchor-cross-origin-expected.txt: Added.
  • http/tests/navigation/ping-attribute/anchor-cross-origin-from-https-expected.txt: Renamed from LayoutTests/http/tests/navigation/ping-cross-origin-from-https-expected.txt.
  • http/tests/navigation/ping-attribute/anchor-cross-origin-from-https.html: Renamed from LayoutTests/http/tests/navigation/ping-cross-origin-from-https.html.
  • http/tests/navigation/ping-attribute/anchor-cross-origin.html: Renamed from LayoutTests/http/tests/navigation/ping-cross-origin.html.
  • http/tests/navigation/ping-attribute/anchor-same-origin-expected.txt: Renamed from LayoutTests/http/tests/navigation/ping-same-origin-expected.txt.
  • http/tests/navigation/ping-attribute/anchor-same-origin.html: Renamed from LayoutTests/http/tests/navigation/ping-same-origin.html.
  • http/tests/navigation/ping-attribute/resources/check-ping.php: Added.
  • http/tests/navigation/ping-attribute/resources/delete-ping.php: Added.
  • http/tests/navigation/ping-attribute/resources/ping-file-path.php: Added.
  • http/tests/navigation/ping-attribute/resources/save-Ping.php: Added.
  • http/tests/navigation/ping-cross-origin-expected.txt: Removed.
  • platform/ios-simulator-wk2/TestExpectations: Updated as needed for the above file renames.
  • platform/win/TestExpectations: Ditto.
8:39 AM Changeset in webkit [190409] by Csaba Osztrogonác
  • 2 edits
    2 adds in trunk/Tools

[EFL] Fix the openwebrtc and gst-plugins-openwebrtc build with clang
https://bugs.webkit.org/show_bug.cgi?id=145837

Reviewed by Philippe Normand.

  • efl/jhbuild.modules:
  • efl/patches/openwebrtc-clang-warning-fix.patch: Added.
  • efl/patches/openwebrtc-gst-plugins-clang-warning-fix.patch: Added.
8:18 AM Changeset in webkit [190408] by Wenson Hsieh
  • 2 edits in trunk/Tools

Unreviewed. Fix the iOS build after r190407.

  • WebKitTestRunner/ios/IOKitSPI.h:
7:28 AM Changeset in webkit [190407] by Wenson Hsieh
  • 11 edits
    2 adds in trunk

Implement keyboard event sending for iOS in WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=149676

Reviewed by Simon Fraser.

Tools:

Adds support for generating and sending key events in WebKitTestRunner. This is accomplished in a similar
way as touch events, using IOHIDEvent machinery. Also adds callbacks to the UIScriptController JS API that
allows us to run code when the keyboard is shown or hidden.

  • WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Adds the typeCharacter JS interface.
  • WebKitTestRunner/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::setDidShowKeyboardCallback):
(WTR::UIScriptController::didShowKeyboardCallback):
(WTR::UIScriptController::setDidHideKeyboardCallback):
(WTR::UIScriptController::didHideKeyboardCallback):
(WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
(WTR::UIScriptController::platformSetDidShowKeyboardCallback):
(WTR::UIScriptController::platformSetDidHideKeyboardCallback):

  • WebKitTestRunner/UIScriptContext/UIScriptController.h:
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView initWithFrame:configuration:]): Registers the TestRunnerWKWebView to listen to

the notifications that the keyboard has been raised or lowered.

(-[TestRunnerWKWebView _keyboardDidShow:]):
(-[TestRunnerWKWebView _keyboardDidHide:]):

  • WebKitTestRunner/ios/HIDEventGenerator.h:
  • WebKitTestRunner/ios/HIDEventGenerator.m:

(-[HIDEventGenerator _sendIOHIDKeyboardEvent:usage:isKeyDown:]): Helper to send a HID keyboard event.
(shouldWrapWithShiftKeyEventForCharacter): Helper used to generate key events.
(hidUsageCodeForCharacter): Ditto.
(-[HIDEventGenerator keyDown:completionBlock:]): Synthesizes and sends HIDKeyboardEvents, triggering

a keyDown event in WebKit.

  • WebKitTestRunner/ios/IOKitSPI.h:
  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

LayoutTests:

Adds a new basic test for the oninput event listener when typing in a text field.

  • fast/events/ios/input-value-after-oninput-expected.txt: Added.
  • fast/events/ios/input-value-after-oninput.html: Added.
6:38 AM Changeset in webkit [190406] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed, rolling out r190399.

Tests are still failing even after r190362

Reverted changeset:

"Unreviewed. Unskip GTK+ user media unit tests after r190362."
http://trac.webkit.org/changeset/190399

6:38 AM Changeset in webkit [190405] by Andres Gomez
  • 1 edit
    2 adds in trunk/Source/WebInspectorUI

[GTK] Web Inspector: Add GTK+ icons for the numerical input and slider based Visual editors for CSS properties
https://bugs.webkit.org/show_bug.cgi?id=147847

Reviewed by Carlos Garcia Campos.

  • UserInterface/Images/gtk/VisualStylePropertyLinked.svg: Added.
  • UserInterface/Images/gtk/VisualStylePropertyUnlinked.svg: Added.
6:36 AM Changeset in webkit [190404] by Andres Gomez
  • 3 edits
    19 adds in trunk/Source/WebInspectorUI

[GTK] Web Inspector: Add GTK+ icons for the different types of non-numerical Visual editors for CSS properties
https://bugs.webkit.org/show_bug.cgi?id=147846

Reviewed by Carlos Garcia Campos.

  • UserInterface/Images/gtk/AUTHORS: Updated.
  • UserInterface/Images/gtk/ClearBoth.svg: Added.
  • UserInterface/Images/gtk/ClearLeft.svg: Added.
  • UserInterface/Images/gtk/ClearRight.svg: Added.
  • UserInterface/Images/gtk/CubicBezier.svg: Updated.
  • UserInterface/Images/gtk/FloatLeft.svg: Added.
  • UserInterface/Images/gtk/FloatRight.svg: Added.
  • UserInterface/Images/gtk/FontStyleItalic.svg: Added.
  • UserInterface/Images/gtk/FontStyleNormal.svg: Added.
  • UserInterface/Images/gtk/FontVariantSmallCaps.svg: Added.
  • UserInterface/Images/gtk/TextAlignCenter.svg: Added.
  • UserInterface/Images/gtk/TextAlignJustify.svg: Added.
  • UserInterface/Images/gtk/TextAlignLeft.svg: Added.
  • UserInterface/Images/gtk/TextAlignRight.svg: Added.
  • UserInterface/Images/gtk/TextDecorationLineThrough.svg: Added.
  • UserInterface/Images/gtk/TextDecorationOverline.svg: Added.
  • UserInterface/Images/gtk/TextDecorationUnderline.svg: Added.
  • UserInterface/Images/gtk/TextTransformCapitalize.svg: Added.
  • UserInterface/Images/gtk/TextTransformLowercase.svg: Added.
  • UserInterface/Images/gtk/TextTransformUppercase.svg: Added.
  • UserInterface/Images/gtk/VisualStyleNone.svg: Added.
6:07 AM Changeset in webkit [190403] by youenn.fablet@crf.canon.fr
  • 47 edits in trunk/Source/WebCore

Refactor binding generator to factor JS DOM class m_impl handling
https://bugs.webkit.org/show_bug.cgi?id=149660

Reviewed by Darin Adler.

Added JSDOMWrapperWithImplementation template class to move m_impl out of the binding generator.
Updated custom bindings to use impl() instead of m_impl directly.
Updated binding generator accordingly.

Covered by existing tests and binding tests.

  • bindings/js/JSDOMStringMapCustom.cpp:

(WebCore::JSDOMStringMap::getOwnPropertyNames):
(WebCore::JSDOMStringMap::deleteProperty):

  • bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMWrapperWithImplementation::impl):
(WebCore::JSDOMWrapperWithImplementation::~JSDOMWrapperWithImplementation):
(WebCore::JSDOMWrapperWithImplementation::JSDOMWrapperWithImplementation):
(WebCore::JSDOMWrapperWithImplementation::releaseImpl):

  • bindings/js/JSGeolocationCustom.cpp:

(WebCore::JSGeolocation::getCurrentPosition):
(WebCore::JSGeolocation::watchPosition):

  • bindings/js/JSSQLResultSetRowListCustom.cpp:

(WebCore::JSSQLResultSetRowList::item):

  • bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql):

  • bindings/js/JSStorageCustom.cpp:

(WebCore::JSStorage::deleteProperty):
(WebCore::JSStorage::getOwnPropertyNames):

  • bindings/js/JSSubtleCryptoCustom.cpp:

(WebCore::JSSubtleCrypto::encrypt):
(WebCore::JSSubtleCrypto::decrypt):
(WebCore::JSSubtleCrypto::sign):
(WebCore::JSSubtleCrypto::verify):
(WebCore::JSSubtleCrypto::wrapKey):
(WebCore::JSSubtleCrypto::unwrapKey):

  • bindings/scripts/CodeGeneratorJS.pm:

(GetParentClassName):
(GetImplClassName):
(GenerateHeader):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObject::JSTestActiveDOMObject):
(WebCore::JSTestActiveDOMObject::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestActiveDOMObject.h:

(WebCore::JSTestActiveDOMObject::~JSTestActiveDOMObject):

  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::JSTestCustomConstructorWithNoInterfaceObject::JSTestCustomConstructorWithNoInterfaceObject):
(WebCore::jsTestCustomConstructorWithNoInterfaceObjectConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.h:

(WebCore::JSTestCustomConstructorWithNoInterfaceObject::~JSTestCustomConstructorWithNoInterfaceObject):
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter):
(WebCore::JSTestCustomNamedGetter::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.h:

(WebCore::JSTestCustomNamedGetter::~JSTestCustomNamedGetter):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::JSTestEventConstructor):
(WebCore::jsTestEventConstructorAttr1): Deleted.

  • bindings/scripts/test/JS/JSTestEventConstructor.h:

(WebCore::JSTestEventConstructor::~JSTestEventConstructor):
(WebCore::JSTestEventConstructor::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTarget::JSTestEventTarget):
(WebCore::JSTestEventTarget::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestEventTarget.h:

(WebCore::JSTestEventTarget::~JSTestEventTarget):

  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestException::JSTestException):
(WebCore::JSTestException::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestException.h:

(WebCore::JSTestException::~JSTestException):

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachable::JSTestGenerateIsReachable):
(WebCore::jsTestGenerateIsReachableConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.h:

(WebCore::JSTestGenerateIsReachable::~JSTestGenerateIsReachable):
(WebCore::JSTestGenerateIsReachable::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::JSTestInterface):
(WebCore::JSTestInterface::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:

(WebCore::jsTestJSBuiltinConstructorConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h:

(WebCore::JSTestJSBuiltinConstructor::~JSTestJSBuiltinConstructor):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
(WebCore::jsTestMediaQueryListListenerConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:

(WebCore::JSTestMediaQueryListListener::~JSTestMediaQueryListListener):
(WebCore::JSTestMediaQueryListListener::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructor::JSTestNamedConstructor):
(WebCore::jsTestNamedConstructorConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:

(WebCore::JSTestNamedConstructor::~JSTestNamedConstructor):
(WebCore::JSTestNamedConstructor::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestNondeterministic.cpp:

(WebCore::JSTestNondeterministic::JSTestNondeterministic):
(WebCore::jsTestNondeterministicNondeterministicReadonlyAttr): Deleted.

  • bindings/scripts/test/JS/JSTestNondeterministic.h:

(WebCore::JSTestNondeterministic::~JSTestNondeterministic):
(WebCore::JSTestNondeterministic::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::JSTestObj):
(WebCore::JSTestObj::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestObj.h:

(WebCore::JSTestObj::~JSTestObj):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructors::JSTestOverloadedConstructors):
(WebCore::jsTestOverloadedConstructorsConstructor): Deleted.

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.h:

(WebCore::JSTestOverloadedConstructors::~JSTestOverloadedConstructors):
(WebCore::JSTestOverloadedConstructors::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::JSTestOverrideBuiltins::JSTestOverrideBuiltins):
(WebCore::JSTestOverrideBuiltins::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestOverrideBuiltins.h:

(WebCore::JSTestOverrideBuiltins::~JSTestOverrideBuiltins):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
(WebCore::jsTestSerializedScriptValueInterfaceValue): Deleted.

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:

(WebCore::JSTestSerializedScriptValueInterface::~JSTestSerializedScriptValueInterface):
(WebCore::JSTestSerializedScriptValueInterface::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefs::JSTestTypedefs):
(WebCore::JSTestTypedefs::getOwnPropertySlot): Deleted.

  • bindings/scripts/test/JS/JSTestTypedefs.h:

(WebCore::JSTestTypedefs::~JSTestTypedefs):

  • bindings/scripts/test/JS/JSattribute.cpp:

(WebCore::JSattribute::JSattribute):
(WebCore::jsattributeReadonly): Deleted.

  • bindings/scripts/test/JS/JSattribute.h:

(WebCore::JSattribute::~JSattribute):
(WebCore::JSattribute::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSreadonly.cpp:

(WebCore::JSreadonly::JSreadonly):
(WebCore::jsreadonlyConstructor): Deleted.

  • bindings/scripts/test/JS/JSreadonly.h:

(WebCore::JSreadonly::~JSreadonly):
(WebCore::JSreadonly::finishCreation): Deleted.

5:59 AM WebKitGTK/2.10.x edited by Andres Gomez
Added Web Inspector icons bugs (diff)
5:35 AM Changeset in webkit [190402] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Fix the ARM build after r190192
https://bugs.webkit.org/show_bug.cgi?id=149620

Reviewed by Darin Adler.

  • platform/graphics/FontFeatureSettings.h:

(WebCore::fontFeatureTag):

5:30 AM Changeset in webkit [190401] by youenn.fablet@crf.canon.fr
  • 20 edits
    1 copy in trunk

[Streams API] Add support for private WebCore JS builtins functions
https://bugs.webkit.org/show_bug.cgi?id=149518

Reviewed by Darin Adler.

Source/JavaScriptCore:

Adding API to add private identifiers on the fly.
This is used to support private JS Builtin functions/private JS Builtin names in WebCore.

  • builtins/BuiltinNames.h:

(JSC::BuiltinNames::appendExternalName):

  • runtime/CommonIdentifiers.cpp:

(JSC::CommonIdentifiers::appendExternalName):

  • runtime/CommonIdentifiers.h:

Source/WebCore:

Using ReadableStream tee method as a testbed to add support for private WebCore JS builtins functions.
Private functions are hooked to JSDOMWindowBase, as it is the one connected to WebCoreClientData.
WebCoreClientData is responsible to export the private function symbols to the VM.

Updated generate-js-builtins script to generate a class that can create and own all JS functions.
This class is used by JSDOMWindowBase to create the JS builtin functions.
It is also used to manage the GC of these objects.

Covered by rebased tests.

  • CMakeLists.txt: Adding ReadableStreamInternals builtin files.
  • DerivedSources.cpp: Ditto.
  • DerivedSources.make: Ditto.
  • Modules/streams/ReadableStream.idl: Adding tee declaration as builtin
  • Modules/streams/ReadableStream.js:

(tee): Calling @teeReadableStream

  • Modules/streams/ReadableStreamInternals.js: Barebone @teeReadableStream implementation.

(teeReadableStream):

  • WebCore.vcxproj/WebCore.vcxproj: Adding ReadableStreamInternals builtin files.
  • WebCore.xcodeproj/project.pbxproj: Adding ReadableStreamInternals builtin files.
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::JSDOMWindowBase): Creating ReadableStreamInternalsBuiltinFunctions object.
(WebCore::JSDOMWindowBase::finishCreation): Creating builtin functions through ReadableStreamInternalsBuiltinFunctions and registering them to the JS engine.
(WebCore::JSDOMWindowBase::visitChildren): Ensuring GC does not collect private builtin functions through ReadableStreamInternalsBuiltinFunctions object

  • bindings/js/JSDOMWindowBase.h:
  • bindings/js/WebCoreJSClientData.h:

(WebCore::WebCoreJSClientData::WebCoreJSClientData): Exporting private names of ReadableStreamInternalsBuiltins
(WebCore::WebCoreJSClientData::readableStreamBuiltins):
(WebCore::WebCoreJSClientData::readableStreamInternalsBuiltins):

  • generate-js-builtins: Adding support for ReadableStreamInternalsBuiltinFunctions and exportNames.

LayoutTests:

Rebasing tests now that tee is appearing in the IDL, although not yet conformant in its implementation.

  • streams/reference-implementation/readable-stream-expected.txt:
  • streams/reference-implementation/readable-stream-tee-expected.txt:
  • streams/reference-implementation/readable-stream-templated-expected.txt:
3:52 AM Changeset in webkit [190400] by Csaba Osztrogonác
  • 3 edits in trunk/Tools

[jhbuild] switch to new upstream usrsctp library
https://bugs.webkit.org/show_bug.cgi?id=149494

Reviewed by Philippe Normand.

  • efl/jhbuild.modules:
  • gtk/jhbuild.modules:
2:28 AM Changeset in webkit [190399] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

Unreviewed. Unskip GTK+ user media unit tests after r190362.

They should pass now.

  • Scripts/run-gtk-tests:

(TestRunner):

1:12 AM Changeset in webkit [190398] by youenn.fablet@crf.canon.fr
  • 9 edits in trunk/Source/WebCore

Binding generator should make mutable CachedAttribute member fields
https://bugs.webkit.org/show_bug.cgi?id=148056

Reviewed by Chris Dumez.

Making mutable CachedAttribute member fields.
Removing const_cast from custom binding code.
Rebased bindings tests.

No change in behavior.

  • bindings/js/JSHistoryCustom.cpp:

(WebCore::JSHistory::state):

  • bindings/js/JSMessageEventCustom.cpp:

(WebCore::JSMessageEvent::data):

  • bindings/js/JSPopStateEventCustom.cpp:

(WebCore::cacheState):
(WebCore::JSPopStateEvent::state):

  • bindings/js/JSReadableStreamReaderEventCustom.cpp:

(WebCore::JSReadableStreamReader::closed):

  • bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::response):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
1:00 AM Changeset in webkit [190397] by bshafiei@apple.com
  • 1 copy in branches/safari-601.2.7-branch

New Branch.

12:44 AM Changeset in webkit [190396] by calvaris@igalia.com
  • 3 edits in trunk/LayoutTests

[Streams API] Update readable-stream tests against latest reference
https://bugs.webkit.org/show_bug.cgi?id=149668

Reviewed by Darin Adler.

  • streams/reference-implementation/readable-stream-expected.txt: Updated expectations.
  • streams/reference-implementation/readable-stream.html: Updated tests.
12:41 AM Changeset in webkit [190395] by calvaris@igalia.com
  • 10 edits in trunk/LayoutTests

[Stream API] Add pending checkpoints for up-to-date readable stream related tests and fix checkpoint URL
https://bugs.webkit.org/show_bug.cgi?id=149666

Reviewed by Darin Adler.

  • streams/readable-stream-reader-read.html:
  • streams/reference-implementation/abstract-ops.html:
  • streams/reference-implementation/bad-strategies.html:
  • streams/reference-implementation/bad-underlying-sources.html:
  • streams/reference-implementation/pipe-to-options.html:
  • streams/reference-implementation/pipe-to.html:
  • streams/reference-implementation/readable-stream-cancel.html:
  • streams/reference-implementation/writable-stream-abort.html:
  • streams/reference-implementation/writable-stream.html: Added and fixed checkpoint URLs.
12:38 AM Changeset in webkit [190394] by calvaris@igalia.com
  • 19 edits
    1 copy
    1 add
    1 delete in trunk

[Streams API] Create ByteLengthQueuingStrategy object as per spec
https://bugs.webkit.org/show_bug.cgi?id=147153

Reviewed by Darin Adler.

Source/WebCore:

Added ByteLengthQueuingStream class as the spec defines at https://streams.spec.whatwg.org/#blqs-class.

Tests are covered by current set.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/WebCoreJSBuiltins.cpp: Added build instructions.
  • Modules/streams/ByteLengthQueuingStrategy.idl: Added.
  • Modules/streams/ByteLengthQueuingStrategy.js: Copied from Source/WebCore/bindings/js/WebCoreJSBuiltins.cpp.

(size): Return byteLength attribute of the chunk.
(initializeByteLengthQueuingStrategy): Initialize the highWaterMark property.

  • bindings/js/WebCoreJSClientData.h:

(WebCore::WebCoreJSClientData::WebCoreJSClientData): Initialize the blqs builtins.
(WebCore::WebCoreJSClientData::byteLengthQueuingStrategyBuiltins): Return the attribute.

LayoutTests:

  • js/dom/global-constructors-attributes-expected.txt:
  • platform/efl/js/dom/global-constructors-attributes-expected.txt:
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/win/js/dom/global-constructors-attributes-expected.txt: Added ByteLengthQueuingStrategy to the

constructor expectations.

  • streams/reference-implementation/brand-checks.html:
  • streams/reference-implementation/byte-length-queuing-strategy.html: Removed reference to

byte-length-queuing-strategy.js as it should be now builtin in WebKit.

  • streams/reference-implementation/resources/byte-length-queuing-strategy.js: Removed.

(ByteLengthQueuingStrategy): Deleted.

12:31 AM Changeset in webkit [190393] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46.25-branch/Source

Versioning.

12:29 AM Changeset in webkit [190392] by bshafiei@apple.com
  • 1 copy in branches/safari-601.1.46.25-branch

New Branch.

12:22 AM Changeset in webkit [190391] by Gyuyoung Kim
  • 10 edits in trunk/Source/WebCore

Clean up all uses of PassRefPtr in Modules/geolocation
https://bugs.webkit.org/show_bug.cgi?id=149552

Reviewed by Darin Adler.

  • Modules/geolocation/GeoNotifier.cpp:

(WebCore::GeoNotifier::GeoNotifier):
(WebCore::GeoNotifier::setFatalError):

  • Modules/geolocation/GeoNotifier.h:

(WebCore::GeoNotifier::create):

  • Modules/geolocation/Geolocation.cpp:

(WebCore::createGeoposition):
(WebCore::createPositionError):
(WebCore::Geolocation::Watchers::add):
(WebCore::Geolocation::getCurrentPosition):
(WebCore::Geolocation::watchPosition):
(WebCore::Geolocation::startRequest):

  • Modules/geolocation/Geolocation.h:
  • Modules/geolocation/GeolocationError.h:
  • Modules/geolocation/GeolocationPosition.h:
  • Modules/geolocation/Geoposition.h:

(WebCore::Geoposition::create):
(WebCore::Geoposition::isolatedCopy):
(WebCore::Geoposition::Geoposition):

  • Modules/geolocation/PositionError.h:
  • Modules/geolocation/PositionOptions.h:

Sep 30, 2015:

11:00 PM Changeset in webkit [190390] by ljaehun.lim@samsung.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, cleanup after r190385

TypedArray.prototype.js is removed at r190385.
Remove it from CMakeLists.txt as well.

  • CMakeLists.txt:
10:54 PM Changeset in webkit [190389] by dbates@webkit.org
  • 2 edits in trunk/Tools

Another attempt to fix the build after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)

  • BuildSlaveSupport/built-product-archive:

(determineWebKitBuildDirectories): Substitute _configurationBuildDirectory for _buildDirectory.
(extractBuiltProduct): Substitute _topLevelBuildDirectory for _buildDirectory.

10:45 PM Changeset in webkit [190388] by dbates@webkit.org
  • 2 edits in trunk/Tools

Attempt to fix the build after <https://trac.webkit.org/changeset/190387>
(https://bugs.webkit.org/show_bug.cgi?id=149695)

Actually, we need to pass --configuration to script webkit-build-directory to have
it return the path to the configuration-specific build directory.

  • BuildSlaveSupport/built-product-archive:

(determineWebKitBuildDirectories):

9:57 PM Changeset in webkit [190387] by dbates@webkit.org
  • 2 edits in trunk/Tools

built-product-archive archives incorrect build directory for iOS port
https://bugs.webkit.org/show_bug.cgi?id=149695

Reviewed by Darin Adler.

Fixes an issue where the script built-product-archive archives a non-existent
build directory for the iOS port. Without loss of generality, the script assumes
the path to the Release configuration build for iOS is in directory WebKitBuild/Release.
But the built products for this configuration are in directory WebKitBuild/Release-iphonesimulator.

Currently the script built-product-archive calls webkit-build-directory --top-level ...
to determine the top-level build directory and computes the configuration-specific
build directory to be the concatenation of the the top-level build directory and
the configuration (e.g. Release). This is incorrect. Instead we should call
webkit-build-directory omitting the flag --top-level to compute the path to the
configuration-specific build directory.

  • BuildSlaveSupport/built-product-archive: Fix up the style such that we use single quoted literals.

(main): Renamed global variable _buildDirectory to _topLevelBuildDirectory to better describe
its purpose and added global variable _configurationBuildDirectory to store the path
to the configuration-specific build directory. Ensure that we have a non-empty string
for both the top-level and configuration-specific build directories.
(determineWebKitBuildDirectories): Formerly named determineWebKitBuildDirectory.
Compute the configuration-specific build directory and store it in the global variable
_configurationBuildDirectory.
(archiveBuiltProduct): Modified to use _configurationBuildDirectory.
(extractBuiltProduct): Modified to use _configurationBuildDirectory and _topLevelBuildDirectory
as needed.
(determineWebKitBuildDirectory): Deleted.

9:21 PM Changeset in webkit [190386] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[EFL] css3/device-adapt/* tests failed after r190335.
https://bugs.webkit.org/show_bug.cgi?id=149655

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-09-30
Reviewed by Simon Fraser.

device-adapt/* tests need the fixedLayout option but useFixedLayout option is
overwritten by updatePlatformSpecificViewOptionsForTest after r190335.

  • WebKitTestRunner/efl/TestControllerEfl.cpp:

(WTR::shouldUseFixedLayout):

9:16 PM Changeset in webkit [190385] by commit-queue@webkit.org
  • 19 edits
    20 deletes in trunk

Unreviewed, rolling out r190367 and r190373.
https://bugs.webkit.org/show_bug.cgi?id=149694

Windows build broken (Requested by smfr on #webkit).

Reverted changesets:

"[ES6] Add TypedArray.prototype functionality."
https://bugs.webkit.org/show_bug.cgi?id=148035
http://trac.webkit.org/changeset/190367

"Unreviewed Windows buildfix."
http://trac.webkit.org/changeset/190373

8:55 PM Changeset in webkit [190384] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[EFL][Gtk] Try to fix the build after r190379.
https://bugs.webkit.org/show_bug.cgi?id=149693

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-09-30
Reviewed by Gyuyoung Kim.

  • Modules/indexeddb/server/MemoryIDBBackingStore.h:
8:17 PM Changeset in webkit [190383] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Source/WebCore:
Add support for the imageSmoothingQuality property for CanvasRenderingContext2D.
https://bugs.webkit.org/show_bug.cgi?id=149541

Patch by Katlyn Graff <kgraff@apple.com> on 2015-09-30
Reviewed by Ryosuke Niwa.

As documented here: https://html.spec.whatwg.org/multipage/scripting.html#image-smoothing
Exposes the smooothing quality of algorithms used for scaling images. Valid input
values are low, medium, and high: associated algorithms are expected to vary for
differing hardware. setImageSmoothingQuality provides a handle into CGInterpolationQuality.

Test: fast/canvas/canvas-imageSmoothingQuality.html

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::State::operator=):
(WebCore::smoothingToInterpolationQuality):
(WebCore::CanvasRenderingContext2D::imageSmoothingQuality):
(WebCore::CanvasRenderingContext2D::setImageSmoothingQuality):
(WebCore::CanvasRenderingContext2D::setImageSmoothingEnabled):

  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:
Tests support for imageSmoothingQuality attribute of Canvas element.
https://bugs.webkit.org/show_bug.cgi?id=149541

Patch by Katlyn Graff <kgraff@apple.com> on 2015-09-30
Reviewed by Ryosuke Niwa.

Tests low, medium, high, and default values, value persistence when
imageSmoothingEnabled is changed, and invalid input.

  • fast/canvas/canvas-imageSmoothingQuality-expected.txt: Added.
  • fast/canvas/canvas-imageSmoothingQuality.html: Added.
6:39 PM Changeset in webkit [190382] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

GraphicsContext3D::mappedSymbolName should initialize count variable
https://bugs.webkit.org/show_bug.cgi?id=149692
<rdar://problem/22871304>

Reviewed by Simon Fraser.

While debugging another WebGL issue, I noticed that some
OpenGL renderers can get into a state where they
drop resources (e.g. a GPU reset). If we don't detect that
in time, we might try to ask for the currently attached
resources and our in-parameter will not be set. In this
case, initialize it to zero so that we don't do silly things.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::mappedSymbolName): Initialize count to 0.

6:32 PM Changeset in webkit [190381] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Reduce delete in Timeline related classes
https://bugs.webkit.org/show_bug.cgi?id=149686

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-30
Reviewed by Timothy Hatcher.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.prototype.capturingStopped):

  • UserInterface/Views/TimelineDataGrid.js:

(WebInspector.TimelineDataGrid.prototype._refreshDirtyDataGridNodes):
(WebInspector.TimelineDataGrid.prototype._sort):
(WebInspector.TimelineDataGrid.prototype._updatePopoverForSelectedNode):

  • UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview.prototype.updateLayout):
(WebInspector.TimelineOverview.prototype._handleScrollEvent):

  • UserInterface/Views/TreeOutlineDataGridSynchronizer.js:

(WebInspector.TreeOutlineDataGridSynchronizer.prototype._treeOutlineScrolled):
(WebInspector.TreeOutlineDataGridSynchronizer.prototype._dataGridScrolled):

  • UserInterface/Views/ProbeSetDataGrid.js:

(WebInspector.ProbeSetDataGrid):
(WebInspector.ProbeSetDataGrid.prototype._teardownData):
Remove an unused member variable as well.

6:29 PM Changeset in webkit [190380] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

Crash in gleLookupHashObject when context is lost
https://bugs.webkit.org/show_bug.cgi?id=149690
<rdar://problem/22751585>
<rdar://problem/22465495>

Reviewed by Simon Fraser.

When we received notification that the GPU has reset,
we were nulling out and deleting our OpenGL contexts
and then trying to do it all over again. The fix was
to flip the order of operations.

While there I added some logging, and changed the
way we check GPU status to make sure we do a check
after the first draw call.

Unfortunately we can't test automatically because it
involves resetting the GPU which can possibly cause
concurrent tests to fail.

  • platform/graphics/mac/GraphicsContext3DMac.mm:

(WebCore::GraphicsContext3D::checkGPUStatusIfNecessary): Move forceContextLost()
to be the first thing we do after we've realised we need to
bail.

6:04 PM Changeset in webkit [190379] by beidson@apple.com
  • 19 edits
    8 copies
    3 adds in trunk

Add UniqueIDBDatabase object, IDBBackingStore objects, and a database operation thread.
https://bugs.webkit.org/show_bug.cgi?id=149678

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/opendatabase-request-event.html

  • UniqueIDBDatabase represents a specific IDB database instance that can have multiple connections to it.
  • IDBBackingStore is an abstract representation of a unique database's backing store, and has a concrete in-memory implementation for now.
  • The database thread exists on IDBServer and is for offloading actual database I/O from the main thread.
  • CMakeLists.txt:
  • Modules/indexeddb/IDBDatabaseIdentifier.cpp:

(WebCore::IDBDatabaseIdentifier::isolatedCopy):

  • Modules/indexeddb/IDBDatabaseIdentifier.h:
  • Modules/indexeddb/client/IDBConnectionToServer.cpp:

(WebCore::IDBClient::IDBConnectionToServer::openDatabase):
(WebCore::IDBClient::IDBConnectionToServer::didOpenDatabase):

  • Modules/indexeddb/client/IDBConnectionToServer.h:
  • Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
  • Modules/indexeddb/client/IDBFactoryImpl.cpp:

(WebCore::IDBClient::IDBFactory::openInternal):

  • Modules/indexeddb/server/IDBBackingStore.h: Copied from Source/WebCore/Modules/indexeddb/server/IDBConnectionToClientDelegate.h.

(WebCore::IDBServer::IDBBackingStore::~IDBBackingStore):

  • Modules/indexeddb/server/IDBConnectionToClient.cpp:

(WebCore::IDBServer::IDBConnectionToClient::didOpenDatabase):

  • Modules/indexeddb/server/IDBConnectionToClient.h:
  • Modules/indexeddb/server/IDBConnectionToClientDelegate.h:
  • Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::IDBServer):
(WebCore::IDBServer::IDBServer::getOrCreateUniqueIDBDatabase):
(WebCore::IDBServer::IDBServer::createBackingStore):
(WebCore::IDBServer::IDBServer::openDatabase):
(WebCore::IDBServer::IDBServer::deleteDatabase):
(WebCore::IDBServer::IDBServer::postDatabaseTask):
(WebCore::IDBServer::IDBServer::postDatabaseTaskReply):
(WebCore::IDBServer::IDBServer::databaseThreadEntry):
(WebCore::IDBServer::IDBServer::databaseRunLoop):
(WebCore::IDBServer::IDBServer::handleTaskRepliesOnMainThread):

  • Modules/indexeddb/server/IDBServer.h:
  • Modules/indexeddb/server/IDBServerOperation.cpp: Copied from Source/WebCore/Modules/indexeddb/server/IDBConnectionToClientDelegate.h.

(WebCore::IDBServer::IDBServerOperation::create):
(WebCore::IDBServer::IDBServerOperation::IDBServerOperation):

  • Modules/indexeddb/server/IDBServerOperation.h: Copied from Source/WebCore/Modules/indexeddb/server/IDBServer.h.

(WebCore::IDBServer::IDBServerOperation::connection):
(WebCore::IDBServer::IDBServerOperation::requestData):

  • Modules/indexeddb/server/MemoryIDBBackingStore.cpp: Copied from Source/WebCore/Modules/indexeddb/server/IDBConnectionToClient.cpp.

(WebCore::IDBServer::MemoryIDBBackingStore::create):
(WebCore::IDBServer::MemoryIDBBackingStore::MemoryIDBBackingStore):
(WebCore::IDBServer::MemoryIDBBackingStore::~MemoryIDBBackingStore):
(WebCore::IDBServer::MemoryIDBBackingStore::getOrEstablishDatabaseInfo):

  • Modules/indexeddb/server/MemoryIDBBackingStore.h: Copied from Source/WebCore/Modules/indexeddb/server/IDBConnectionToClient.h.
  • Modules/indexeddb/server/UniqueIDBDatabase.cpp: Added.

(WebCore::IDBServer::UniqueIDBDatabase::UniqueIDBDatabase):
(WebCore::IDBServer::UniqueIDBDatabase::openDatabaseConnection):
(WebCore::IDBServer::UniqueIDBDatabase::handleOpenDatabaseOperations):
(WebCore::IDBServer::UniqueIDBDatabase::openBackingStore):
(WebCore::IDBServer::UniqueIDBDatabase::didOpenBackingStore):

  • Modules/indexeddb/server/UniqueIDBDatabase.h: Copied from Source/WebCore/Modules/indexeddb/server/IDBServer.h.

(WebCore::IDBServer::UniqueIDBDatabase::create):

  • Modules/indexeddb/shared/IDBDatabaseInfo.cpp: Copied from Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h.

(WebCore::IDBDatabaseInfo::IDBDatabaseInfo):
(WebCore::IDBDatabaseInfo::isolatedCopy):

  • Modules/indexeddb/shared/IDBDatabaseInfo.h: Copied from Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h.

(WebCore::IDBDatabaseInfo::IDBDatabaseInfo):

  • Modules/indexeddb/shared/InProcessIDBServer.cpp:

(WebCore::InProcessIDBServer::didDeleteDatabase):
(WebCore::InProcessIDBServer::openDatabase):
(WebCore::InProcessIDBServer::didOpenDatabase):

  • Modules/indexeddb/shared/InProcessIDBServer.h:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/CrossThreadCopier.cpp:

(WebCore::IDBDatabaseInfo>::copy):
(WebCore::IDBDatabaseIdentifier>::copy):

  • platform/CrossThreadCopier.h:

LayoutTests:

  • storage/indexeddb/modern/opendatabase-request-event-expected.txt: Added.
  • storage/indexeddb/modern/opendatabase-request-event.html: Added.
5:40 PM Changeset in webkit [190378] by Dewei Zhu
  • 2 edits in trunk/Tools

Extend JetStream timeout for slow devices.

Reviewed by Chris Dumez.

Extend JetStream timeout to 20 minutes.

  • Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
5:26 PM Changeset in webkit [190377] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Thousands of timers fire after switching to JavaScript and Events timeline
https://bugs.webkit.org/show_bug.cgi?id=149682

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-30
Reviewed by Timothy Hatcher.

Setting the status element of a GeneralTreeElement was triggering a
TreeOutline.onchange event. For TreeOutlines with lots of tree elements
(JavaScript & Events with profile nodes) this could result in thousands
of onchange events that causes lots of unnecessary work and blocks
future timers (like scroll synchronization) from firing.

This change eliminates TreeOutline change events for tree element
changes that are not interesting.

  • UserInterface/Views/GeneralTreeElement.js:

(WebInspector.GeneralTreeElement.prototype.set status): Deleted.

  • UserInterface/Views/TreeOutline.js:

(WebInspector.TreeElement.prototype.set tooltip): Deleted.

5:08 PM Changeset in webkit [190376] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebInspectorUI

Web Inspector: Reduce delete in TreeElements and DataGridNodes
https://bugs.webkit.org/show_bug.cgi?id=149680

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-30
Reviewed by Timothy Hatcher.

  • UserInterface/Views/BreakpointTreeElement.js:

(WebInspector.BreakpointTreeElement):
(WebInspector.BreakpointTreeElement.prototype._removeProbeSet):

  • UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype._editingCommitted.moveToNextCell):
(WebInspector.DataGrid.prototype._editingCommitted):
(WebInspector.DataGrid.prototype._editingCancelled):
(WebInspector.DataGrid.prototype.removeColumn):
(WebInspector.DataGridNode.prototype.refreshIfNeeded):
(WebInspector.DataGridNode.prototype.refresh):
(WebInspector.DataGridNode.prototype.expand):
(WebInspector.DataGridNode.prototype.restorePosition):
(WebInspector.DataGridNode):

  • UserInterface/Views/GeneralTreeElement.js:

(WebInspector.GeneralTreeElement.prototype.ondetach):

  • UserInterface/Views/ResourceTimelineDataGridNode.js:

(WebInspector.ResourceTimelineDataGridNode.prototype.refresh):

  • UserInterface/Views/TreeOutline.js:

(WebInspector.TreeElement.prototype._fireDidChange):
(WebInspector.TreeElement.prototype.expand):

5:04 PM Changeset in webkit [190375] by mmaxfield@apple.com
  • 4 edits
    2 adds in trunk

Crash when using an SVG font with > 390 glyphs
https://bugs.webkit.org/show_bug.cgi?id=149677
<rdar://problem/21676402>

Reviewed by Simon Fraser.

Source/WebCore:

The "Charset Index" in OTF are indices into a collection of strings. There are
390 predefined strings in this collection. We were currently assigning each
glyph to one of these strings. However, if there are more glyphs than strings,
we will be using invalid indices.

The values of the strings themselves are not necessary for SVG fonts. Therefore,
the solution is to create a single dummy string, and have all glyphs target it.

Tests: svg/custom/many-glyphs.svg

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::font):

  • svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::appendCFFTable):

LayoutTests:

  • svg/custom/many-glyphs-expected.svg: Added.
  • svg/custom/many-glyphs.svg: Added.
4:56 PM Changeset in webkit [190374] by dbates@webkit.org
  • 3 edits in trunk/Tools

Rename iOS builders/testers to include version
https://bugs.webkit.org/show_bug.cgi?id=149685

Reviewed by Simon Fraser.

Substitute "Apple iOS 9" for "Apple iOS" in the names of iOS builders/testers so as
make it clear to a reader the version of iOS these builders/testers are using.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
4:34 PM Changeset in webkit [190373] by msaboff@apple.com
  • 1 edit in trunk/Source/JavaScriptCore/ChangeLog

Fixed change set order to match reality. Some how the tools messed up the merge of ChangeLog entries.
-This line, and those below, will be ignored--

M Source/JavaScriptCore/ChangeLog

4:27 PM Changeset in webkit [190372] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Relanding r190289 with the following two fixes:

  1. REGRESSION(r190289): It made Speedometer/Full.html performance test fail https://bugs.webkit.org/show_bug.cgi?id=149621

Reviewed by Saam Barati.

We need to restore callee saves for both the fast and slow paths before making a
tail call in the FTL.

  • ftl/FTLJSCallBase.cpp: (JSC::FTL::JSCallBase::emit):
  1. [ARM] REGRESSION(r190289): It made 374 tests crash on 32 bit ARM Linux https://bugs.webkit.org/show_bug.cgi?id=149619

Reviewed by Filip Pizlo.

Need to check for ARMv7_TRADITIONAL and ARMv7 in addition to ARM in "if"
statement to handle platforms with a link register.

  • llint/LowLevelInterpreter.asm: (prepareForTailCall):

Patch by Michael Saboff <msaboff@apple.com> on 2015-09-30

4:03 PM Changeset in webkit [190371] by dbates@webkit.org
  • 3 edits in trunk/Tools

Add iOS criterion for triggering a build
https://bugs.webkit.org/show_bug.cgi?id=149679

Rubber-stamped by Alexey Proskuryakov.

First pass at defining criterion for triggering an iOS build.

  • BuildSlaveSupport/build.webkit.org-config/wkbuild.py:

(_should_file_trigger_build):

  • BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:

(ShouldBuildTest):
(ShouldBuildTest.test_should_build):

3:51 PM Writing Layout Tests to test iOS UI features edited by Simon Fraser
(diff)
3:48 PM Writing Layout Tests to test iOS UI features edited by Simon Fraser
(diff)
3:44 PM Writing Layout Tests to test iOS UI features edited by Simon Fraser
(diff)
3:38 PM Writing Layout Tests to test iOS UI features edited by Simon Fraser
(diff)
3:28 PM Changeset in webkit [190370] by msaboff@apple.com
  • 34 edits
    8 adds in trunk

Source/JavaScriptCore:
Relanding r190289 with the following two fixes:

  1. REGRESSION(r190289): It made Speedometer/Full.html performance test fail https://bugs.webkit.org/show_bug.cgi?id=149621

Reviewed by Saam Barati.

We need to restore callee saves for both the fast and slow paths before making a
tail call in the FTL.

  • ftl/FTLJSCallBase.cpp: (JSC::FTL::JSCallBase::emit):
  1. [ARM] REGRESSION(r190289): It made 374 tests crash on 32 bit ARM Linux https://bugs.webkit.org/show_bug.cgi?id=149619

Reviewed by Filip Pizlo.

Need to check for ARMv7_TRADITIONAL and ARMv7 in addition to ARM in "if"
statement to handle platforms with a link register.


  • llint/LowLevelInterpreter.asm: (prepareForTailCall):

LayoutTests:
Relanding r190289 after fixes tracked in https://bugs.webkit.org/show_bug.cgi?id=149619
and https://bugs.webkit.org/show_bug.cgi?id=149621

Reviewed by Saam Barati.

3:26 PM Writing Layout Tests to test iOS UI features edited by Simon Fraser
(diff)
3:23 PM Writing Layout Tests to test iOS UI features edited by Simon Fraser
(diff)
3:13 PM Writing Layout Tests to test iOS UI features edited by Simon Fraser
(diff)
3:11 PM Changeset in webkit [190369] by Andres Gomez
  • 1 edit
    1 add in trunk/Source/WebInspectorUI

[GTK] Web Inspector: Add GTK+ icon for the Bezier curve visual editor
https://bugs.webkit.org/show_bug.cgi?id=147681

Reviewed by Joseph Pecoraro.

  • UserInterface/Images/gtk/CubicBezier.svg: Added.
3:08 PM Writing Layout Tests to test iOS UI features edited by Simon Fraser
(diff)
3:00 PM Writing Layout Tests to test iOS UI features created by Simon Fraser
2:56 PM WikiStart edited by Simon Fraser
(diff)
2:48 PM Changeset in webkit [190368] by Simon Fraser
  • 15 edits
    2 copies
    7 adds in trunk

[iOS] Allow tests to generate user gestures for UI testing
https://bugs.webkit.org/show_bug.cgi?id=149653

Reviewed by Tim Horton.

Tools:

Expose functionality in UIScriptController to allow for testing single- and double-tap,
and to listen for completion of scrolling and zooming in the WKWebView.

Tap generation is done using synthetic IOHIDEvents, via a new HIDEventGenerator class
which hides the complexity of creating these events. Event dispatch is asynchronous.
We detect when the last event has been handled by dispatching a vendor-specific event,
which is detected via -_handleHIDEvent: in our UIApplication subclass.

  • WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Link with IOKit.
  • WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl: Two new properties

for 'will begin zooming' and 'did end zooming' callbacks, and functions to dispatch
single and double taps.

  • WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:

(UIScriptContext::registerCallback): Used to store the callbacks for zooming.
Unlike the "task" callbacks, these are persistent, but we store them in the same hash map.
(UIScriptContext::unregisterCallback):
(UIScriptContext::callbackWithID):
(UIScriptContext::fireCallback):

  • WebKitTestRunner/UIScriptContext/UIScriptContext.h:
  • WebKitTestRunner/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::setWillBeginZoomingCallback): Cross-platform code.
(WTR::UIScriptController::willBeginZoomingCallback): Ditto.
(WTR::UIScriptController::setDidEndZoomingCallback):
(WTR::UIScriptController::didEndZoomingCallback):
(WTR::UIScriptController::singleTapAtPoint): Non-iOS stub.
(WTR::UIScriptController::doubleTapAtPoint): Ditto.
(WTR::UIScriptController::platformSetWillBeginZoomingCallback):
(WTR::UIScriptController::platformSetDidEndZoomingCallback):

  • WebKitTestRunner/UIScriptContext/UIScriptController.h:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.h: Properties for the zooming callbacks.
  • WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView zoomToScale:animated:completionHandler:]): Dispatch the zooming callback.
(-[TestRunnerWKWebView scrollViewWillBeginZooming:withView:]): Ditto.
(-[TestRunnerWKWebView scrollViewDidEndZooming:withView:atScale:]): Ditto.
(-[TestRunnerWKWebView onDidEndZooming:]): Deleted.

  • WebKitTestRunner/ios/HIDEventGenerator.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
  • WebKitTestRunner/ios/HIDEventGenerator.m: Added.

(simpleDragCurve):
(calculateNextLocation):
(delayBetweenMove):
(+[HIDEventGenerator sharedHIDEventGenerator]):
(+[HIDEventGenerator nextEventCallbackID]):
(-[HIDEventGenerator init]):
(-[HIDEventGenerator _createIOHIDEventType:]):
(-[HIDEventGenerator _sendHIDEvent:]):
(-[HIDEventGenerator _sendMarkerHIDEventWithCompletionBlock:]):
(-[HIDEventGenerator _updateTouchPoints:count:]):
(-[HIDEventGenerator touchDownAtPoints:touchCount:]):
(-[HIDEventGenerator touchDown:touchCount:]):
(-[HIDEventGenerator touchDown:]):
(-[HIDEventGenerator liftUpAtPoints:touchCount:]):
(-[HIDEventGenerator liftUp:touchCount:]):
(-[HIDEventGenerator liftUp:]):
(-[HIDEventGenerator moveToPoints:touchCount:duration:]):
(-[HIDEventGenerator sendTaps:location:withNumberOfTouches:completionBlock:]):
(-[HIDEventGenerator tap:completionBlock:]):
(-[HIDEventGenerator doubleTap:completionBlock:]):
(-[HIDEventGenerator twoFingerTap:completionBlock:]):
(-[HIDEventGenerator dragWithStartPoint:endPoint:duration:completionBlock:]):
(-[HIDEventGenerator pinchCloseWithStartPoint:endPoint:duration:completionBlock:]):
(-[HIDEventGenerator pinchOpenWithStartPoint:endPoint:duration:completionBlock:]):
(-[HIDEventGenerator markerEventReceived:]):

  • WebKitTestRunner/ios/IOKitSPI.h: Added.
  • WebKitTestRunner/ios/UIKitSPI.h: Copied from Tools/WebKitTestRunner/cocoa/TestRunnerWKWebView.h.
  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::globalToContentCoordinates):
(WTR::UIScriptController::singleTapAtPoint):
(WTR::UIScriptController::doubleTapAtPoint):
(WTR::UIScriptController::platformSetWillBeginZoomingCallback):
(WTR::UIScriptController::platformSetDidEndZoomingCallback):

  • WebKitTestRunner/ios/mainIOS.mm:

(-[WebKitTestRunnerApp _handleHIDEvent:]):

LayoutTests:

Simple tests for single tap triggering a click, and double-tap zoom.

  • TestExpectations:
  • fast/events/ios/double-tap-zoom-expected.txt: Added.
  • fast/events/ios/double-tap-zoom.html: Added.
  • fast/events/ios/single-tap-generates-click-expected.txt: Added.
  • fast/events/ios/single-tap-generates-click.html: Added.
  • platform/ios-simulator-wk2/TestExpectations:
2:00 PM Changeset in webkit [190367] by keith_miller@apple.com
  • 19 edits
    1 copy
    21 adds in trunk

[ES6] Add TypedArray.prototype functionality.
https://bugs.webkit.org/show_bug.cgi?id=148035

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This patch should add most of the functionality for
the prototype properties of TypedArray objects in ES6.
There are a few exceptions to this, which will be added
in upcoming patches:

1) First we do not use the species constructor for some
of the TypedArray prototype functions (namely: map, filter,
slice, and subarray). That will need to be added when
species constructors are finished.

2) TypedArrays still have a length, byteOffset, byteLength,
and buffer are still attached to the TypedArray instance (in
the spec they are on the TypedArray.prototype instance object)
since the JIT currently assumes those properties are fixed.

3) The TypedArray.constructor property is not added yet
as it should point to the TypedArray instance object,
which will be added in a future patch.

(every):
(find):
(findIndex):
(forEach):
(some):
(sort.min):
(sort.merge):
(sort.mergeSort):
(sort):
(reduce):
(reduceRight):
(map):
(filter):
(toLocaleString):

  • runtime/ArrayPrototype.cpp:
  • runtime/ArrayPrototype.h:
  • runtime/CommonIdentifiers.h:
  • runtime/JSGenericTypedArrayView.h:

(JSC::JSGenericTypedArrayView::toAdaptorNativeFromValue):
(JSC::JSGenericTypedArrayView::setRangeToValue):
(JSC::JSGenericTypedArrayView::sort):
(JSC::JSGenericTypedArrayView::purifyArray):
(JSC::JSGenericTypedArrayView::sortComparison):
(JSC::JSGenericTypedArrayView::sortFloat):

  • runtime/JSGenericTypedArrayViewInlines.h:
  • runtime/JSGenericTypedArrayViewPrototypeFunctions.h: Added.

(JSC::argumentClampedIndexFromStartOrEnd):
(JSC::genericTypedArrayViewProtoFuncSet):
(JSC::genericTypedArrayViewProtoFuncEntries):
(JSC::genericTypedArrayViewProtoFuncCopyWithin):
(JSC::genericTypedArrayViewProtoFuncFill):
(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncJoin):
(JSC::genericTypedArrayViewProtoFuncKeys):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):
(JSC::genericTypedArrayViewProtoGetterFuncLength):
(JSC::genericTypedArrayViewProtoGetterFuncByteLength):
(JSC::genericTypedArrayViewProtoGetterFuncByteOffset):
(JSC::genericTypedArrayViewProtoFuncReverse):
(JSC::genericTypedArrayViewPrivateFuncSort):
(JSC::genericTypedArrayViewProtoFuncSlice):
(JSC::genericTypedArrayViewProtoFuncSubarray):
(JSC::typedArrayViewProtoFuncValues):

  • runtime/JSGenericTypedArrayViewPrototypeInlines.h:

(JSC::JSGenericTypedArrayViewPrototype<ViewClass>::finishCreation):
(JSC::genericTypedArrayViewProtoFuncSet): Deleted.
(JSC::genericTypedArrayViewProtoFuncSubarray): Deleted.

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/JSObject.h:
  • runtime/JSTypedArrayPrototypes.cpp:
  • runtime/JSTypedArrayPrototypes.h:
  • runtime/JSTypedArrayViewPrototype.cpp: Added.

(JSC::typedArrayViewPrivateFuncLength):
(JSC::typedArrayViewPrivateFuncSort):
(JSC::typedArrayViewProtoFuncSet):
(JSC::typedArrayViewProtoFuncEntries):
(JSC::typedArrayViewProtoFuncCopyWithin):
(JSC::typedArrayViewProtoFuncFill):
(JSC::typedArrayViewProtoFuncLastIndexOf):
(JSC::typedArrayViewProtoFuncIndexOf):
(JSC::typedArrayViewProtoFuncJoin):
(JSC::typedArrayViewProtoFuncKeys):
(JSC::typedArrayViewProtoGetterFuncLength):
(JSC::typedArrayViewProtoGetterFuncByteLength):
(JSC::typedArrayViewProtoGetterFuncByteOffset):
(JSC::typedArrayViewProtoFuncReverse):
(JSC::typedArrayViewProtoFuncSubarray):
(JSC::typedArrayViewProtoFuncSlice):
(JSC::typedArrayViewProtoFuncValues):
(JSC::JSTypedArrayViewPrototype::JSTypedArrayViewPrototype):
(JSC::JSTypedArrayViewPrototype::finishCreation):
(JSC::JSTypedArrayViewPrototype::create):
(JSC::JSTypedArrayViewPrototype::createStructure):

  • runtime/JSTypedArrayViewPrototype.h: Copied from Source/JavaScriptCore/runtime/JSTypedArrayPrototypes.cpp.
  • tests/stress/resources/standalone-pre.js: Added.

(description):
(debug):
(escapeString):
(testPassed):
(testFailed):
(areNumbersEqual):
(areArraysEqual):
(isMinusZero):
(isTypedArray):
(isResultCorrect):
(stringify):
(shouldBe):
(dfgShouldBe):
(shouldBeType):
(shouldBeTrue):
(shouldBeFalse):
(shouldBeNaN):
(shouldBeNull):
(shouldBeEqualToString):
(shouldBeUndefined):
(shouldNotThrow):
(shouldThrow):
(dfgCompiled):
(dfgIncrement):
(noInline):
(finishJSTest):

  • tests/stress/resources/typedarray-test-helper-functions.js: Added.

(forEachTypedArray):
(isSameFunctionForEachTypedArrayPrototype.eq):
(isSameFunctionForEachTypedArrayPrototype):
(hasSameValues):
(.foo):
(testPrototypeFunctionHelper):
(testPrototypeFunctionOnSigned):
(testPrototypeFunctionOnFloat):
(testPrototypeFunction):
(.tester):
(testPrototypeReceivesArray):

  • tests/stress/typedarray-copyWithin.js: Added.
  • tests/stress/typedarray-every.js: Added.

(isBigEnough):
(isBigEnoughAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-fill.js: Added.
  • tests/stress/typedarray-filter.js: Added.

(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-find.js: Added.

(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-findIndex.js: Added.

(keepEven):
(keepEvenAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-forEach.js: Added.

(.checkCorrect.let.list):
(.checkCorrect):
(createChecker):
(foo):
(changeArray):
(isBigEnoughAndException):

  • tests/stress/typedarray-indexOf.js: Added.

(keepEven):

  • tests/stress/typedarray-lastIndexOf.js: Added.
  • tests/stress/typedarray-map.js: Added.

(even):
(evenAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-reduce.js: Added.

(createArray):
(sum):
(createArrayAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-reduceRight.js: Added.

(createArray):
(sum):
(createArrayAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-slice.js: Added.
  • tests/stress/typedarray-some.js: Added.

(isBigEnough):
(isBigEnoughAndChange):
(isBigEnoughAndException):

  • tests/stress/typedarray-sort.js: Added.

(sortBackwards):
(compareException):

LayoutTests:

Fixed tests for new toString behavior on TypedArrays.

  • fast/canvas/webgl/type-conversion-test-expected.txt:
  • fast/dom/Window/window-postmessage-clone-expected.txt:
1:05 PM Changeset in webkit [190366] by dburkart@apple.com
  • 2 edits in trunk/Tools

git-add-reviewer should trim trailing spaces/newlines
https://bugs.webkit.org/show_bug.cgi?id=149513

Reviewed by Darin Adler.

  • Scripts/git-add-reviewer:

(nonInteractive):

1:00 PM Changeset in webkit [190365] by timothy_horton@apple.com
  • 3 edits in trunk/LayoutTests

Compute document marker rects at use time instead of paint time
https://bugs.webkit.org/show_bug.cgi?id=149643

  • fast/text/mark-matches-overflow-clip-expected.txt:
  • fast/text/mark-matches-overflow-clip.html:

Adjust one recently-added test and its result slightly.

12:44 PM Changeset in webkit [190364] by Chris Dumez
  • 15 edits in trunk/Source

Unreviewed, roll out r188331: "NetworkProcess: DNS prefetch happens in the Web Process"
<rdar://problem/22560715>

Speculative roll out of r188331 as we had a ~2.5% PLT regression around
the time it landed and it seems the most likely culprit. I'll reland if
the perf bots do not recover after the roll out.

Source/WebCore:

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute):

  • loader/FrameLoaderClient.h:
  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::loadLink):

  • page/Chrome.cpp:

(WebCore::Chrome::mouseDidMoveOverElement):

Source/WebKit2:

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::storageSession): Deleted.

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:

(webkitWebExtensionDidReceiveMessage):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):

  • WebProcess/WebProcess.cpp:
  • WebProcess/WebProcess.h:
12:36 PM Changeset in webkit [190363] by timothy_horton@apple.com
  • 27 edits in trunk/Source

Compute document marker rects at use time instead of paint time
https://bugs.webkit.org/show_bug.cgi?id=149643

Reviewed by Darin Adler.

  • dom/DocumentMarkerController.cpp:

(WebCore::DocumentMarkerController::DocumentMarkerController):
(WebCore::DocumentMarkerController::detach):
Store and zero the Document backpointer.

(WebCore::DocumentMarkerController::addMarker):
(WebCore::DocumentMarkerController::addTextMatchMarker):
(WebCore::DocumentMarkerController::addDictationPhraseWithAlternativesMarker):
(WebCore::DocumentMarkerController::addDictationResultMarker):
(WebCore::DocumentMarkerController::copyMarkers):
Remove some useless comments.

(WebCore::updateRenderedRectsForMarker):
Use Range to compute the (unclipped, absolute) text rects, and store them
on the RenderedDocumentMarker.

(WebCore::DocumentMarkerController::invalidateRectsForAllMarkers):
(WebCore::DocumentMarkerController::invalidateRectsForMarkersInNode):
Mark the relevant markers' rects as invalid, and notify the ChromeClient.

(WebCore::DocumentMarkerController::updateRectsForInvalidatedMarkersOfType):
Run through all markers, computing rects for ones that don't have valid rects.
We will do layout (once) if necessary. However, this is most commonly
called from a place where layout should already be up to date, so this
should not happen often. updateRenderedRectsForMarker also asserts
that layout is up to date.

(WebCore::DocumentMarkerController::renderedRectsForMarkers):
Retrieve all markers of the given type, clip them by overflow clip and
frame clip, and return them to the caller.

(WebCore::DocumentMarkerController::addMarker):
(WebCore::DocumentMarkerController::markerContainingPoint):
(WebCore::DocumentMarkerController::markersFor):
(WebCore::DocumentMarkerController::repaintMarkers):
(WebCore::DocumentMarkerController::shiftMarkers):
(DocumentMarkerController::setMarkersActive):
(DocumentMarkerController::hasMarkers):
Modern iteration.

(WebCore::DocumentMarkerController::invalidateRenderedRectsForMarkersInRect): Deleted.

  • dom/DocumentMarkerController.h:
  • dom/Document.cpp:

(WebCore::Document::Document):
Pass the Document to the DocumentMarkerController.

  • dom/RenderedDocumentMarker.h:

(WebCore::RenderedDocumentMarker::contains):
(WebCore::RenderedDocumentMarker::setUnclippedAbsoluteRects):
(WebCore::RenderedDocumentMarker::unclippedAbsoluteRects):
(WebCore::RenderedDocumentMarker::invalidate):
(WebCore::RenderedDocumentMarker::isValid):
(WebCore::RenderedDocumentMarker::addRenderedRect): Deleted.
(WebCore::RenderedDocumentMarker::renderedRects): Deleted.
Instead of keeping "rendered" rects, keep unclipped rects in absolute
document coordinates. Invalidation will happen wholesale instead of
based on dirty rects, because computation no longer happens at paint
time, so it's safe to throw all of the rects away.
Keep track of whether we have valid rects or not.

  • editing/Editor.cpp:

(WebCore::Editor::countMatchesForText):
We don't need to do a fake whole-document paint just to compute the
document marker rects. They are computed on demand, using layout information
instead of paint-time information.

  • page/ChromeClient.h:

Remove an unnecessary semicolon.
Add didInvalidateDocumentMarkerRects, which DocumentMarkerController
will call whenever document marker rects are invalidated (and when e.g.
the find holes PageOverlay should repaint itself).

  • page/FrameView.cpp:

(WebCore::FrameView::layout):
Invalidate document marker's layout-computed rects after layout is complete.
They'll be lazily recomputed when next requested.

(WebCore::FrameView::willPaintContents):
Remove the pre-painting invalidation of document marker rects.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::paintDocumentMarker): Deleted.
(WebCore::InlineTextBox::computeRectForReplacementMarker): Deleted.
(WebCore::InlineTextBox::paintDocumentMarkers): Deleted.
Don't bother computing rendered rects for document markers at paint time.
Just do the actual painting work (which, for replacement markers, is
nothing at all).

  • rendering/InlineTextBox.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
When RenderLayers move, invalidate document marker rects.

  • rendering/svg/SVGInlineFlowBox.cpp:

(WebCore::SVGInlineFlowBox::paint):
(WebCore::SVGInlineFlowBox::computeTextMatchMarkerRectForRenderer): Deleted.

  • rendering/svg/SVGInlineFlowBox.h:
  • rendering/svg/SVGRootInlineBox.cpp:

(WebCore::SVGRootInlineBox::paint):
Don't bother computing rendered rects for document markers at paint time.

  • testing/Internals.cpp:

(WebCore::markerTypeFrom):
(WebCore::markerTypesFrom):
Add markerTypeFrom, which returns MarkerType enum values for the input string
instead of a MarkerTypes class.

(WebCore::Internals::dumpMarkerRects):
Dump all markers for the given type, and request them from DocumentMarkerController
instead of from the RenderedDocumentMarker, because we want fully clipped
rects, which can only be obtained from DocumentMarkerController.

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::getTextRectangles):
Avoid enclosing unnecessarily, to avoid inflating zero-width text rects
to have a non-zero width. Callers appear to be OK with non-integral positions.

  • testing/Internals.h:
  • testing/Internals.idl:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::didInvalidateDocumentMarkerRects):

  • WebProcess/WebCoreSupport/WebChromeClient.h:

Plumb the notification about invalidated document marker rects through to FindController.

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindUIAfterPageScroll):
Make a document-relative PageOverlay, so that we get fast scrolling.

(WebKit::FindController::rectsForTextMatchesInRect):
Return find hole rects in main-FrameView content coordinates, to
match the document-relative page overlay.
We'll only return rects that intersect the passed-in rect, which
comes from the dirty rect passed to drawRect.

(WebKit::FindController::drawRect):
Inflate the dirty rect by the border width so that we hit all relevant
markers in each tile. Otherwise, we would end up missing the border of a marker
that touched the edge of a tile.

(WebKit::FindController::didInvalidateDocumentMarkerRects):
Repaint (for now, the entire overlay) when document marker rects change.

  • WebProcess/WebPage/FindController.h:
  • WebView/WebHTMLView.mm:

(-[WebHTMLView rectsForTextMatches]):

  • WebView.cpp:

(WebView::rectsForTextMatches):

12:16 PM Changeset in webkit [190362] by eric.carlson@apple.com
  • 15 edits in trunk

REGRESSION(r190262): User media unit test failures after r190262
https://bugs.webkit.org/show_bug.cgi?id=149580

Reviewed by Darin Adler.

Source/WebCore:

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::getStats): Drive-by fix to deal with optional param.

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::constraintsValidated): Swap the track parameter order.

  • Modules/mediastream/UserMediaRequest.h:
  • platform/mediastream/MediaStreamCreationClient.h:

(WebCore::MediaStreamCreationClient::validateRequestConstraints): Swap the track parameter order.

  • platform/mediastream/mac/RealtimeMediaSourceCenterMac.cpp:

(WebCore::RealtimeMediaSourceCenterMac::validateRequestConstraints): If there is no

constraint for a media type, don't return a device of that type.

  • platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:

(WebCore::RealtimeMediaSourceCenterOwr::mediaSourcesAvailable): Ditto.

  • platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeMediaSourceCenter::validateRequestConstraints): Ditto.

  • platform/mock/TimerEventBasedMock.h:

(WebCore::TimerEvent::~TimerEvent): Clear the m_mock pointer.

  • platform/mock/UserMediaClientMock.h:

(WebCore::UserMediaClientMock::fire): Deal with empty device vectors.

  • testing/Internals.cpp:

(WebCore::Internals::Internals): Don't register UserMediaController, it isn't needed for

WKTR.

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::decidePolicyForUserMediaPermissionRequestIfPossible): Fix parameter

order to WKUserMediaPermissionRequestAllow.

LayoutTests:

  • platform/gtk/TestExpectations: Unskip tests.
12:10 PM Changeset in webkit [190361] by Brent Fulgham
  • 2 edits in trunk

[Win] Unreviewed build fix after CMake conversion.

  • Source/cmake/OptionsWin.cmake: Correct some Windows build flags.
11:57 AM Changeset in webkit [190360] by Lucas Forschler
  • 1 edit in trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js

Add El Capitan to the dashboard.

11:19 AM Changeset in webkit [190359] by dbates@webkit.org
  • 3 edits in trunk/Tools

Add iOS builders and testers
https://bugs.webkit.org/show_bug.cgi?id=149549

Reviewed by Alexey Proskuryakov.

Adds definitions for 64-bit iOS Simulator release builders and testers and a iOS device
builder that builds universal release binaries for armv7, armv7s and arm64 architectures.

  • BuildSlaveSupport/build.webkit.org-config/config.json: Add definitions for builders and testers.
  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py: Update unit tests.
10:56 AM Changeset in webkit [190358] by timothy@apple.com
  • 2 edits
    1 add in trunk/Tools

Give WebKitLauncher the get-task-allow entitlement to allow it to work on El Capitan
https://bugs.webkit.org/show_bug.cgi?id=149674

Reviewed by Lucas Forschler.

  • WebKitLauncher/WebKitLauncher.entitlements: Added.
  • WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj:
10:53 AM Changeset in webkit [190357] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

10:51 AM Changeset in webkit [190356] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.5

New tag.

10:49 AM Changeset in webkit [190355] by jmarcell@apple.com
  • 2 edits in trunk/Tools

BuildbotQueueView.prototype._appendPendingRevisionCount should skip repositories that don't
have an associated trac instance.
https://bugs.webkit.org/show_bug.cgi?id=149673

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:

(BuildbotQueueView.prototype._appendPendingRevisionCount): Skip repositories that don't
have an associated trac instance.

10:43 AM Changeset in webkit [190354] by dbates@webkit.org
  • 2 edits in trunk/Tools

Prioritize testing latest build request on iOS test bots
https://bugs.webkit.org/show_bug.cgi?id=149669

Reviewed by Darin Adler.

We should prioritize testing of the latest build request on the iOS test bots
as we do for Mac and Windows test bots.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

10:28 AM Changeset in webkit [190353] by dbates@webkit.org
  • 3 edits in trunk/Tools

Add buildbot category for iOS builders and testers
https://bugs.webkit.org/show_bug.cgi?id=149667

Reviewed by Darin Adler.

Group iOS builders and testers under category iOS and add dashboard and console hyperlinks
for iOS to the build.webkit.org home page.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(loadBuilderConfig):

  • BuildSlaveSupport/build.webkit.org-config/templates/root.html:
10:23 AM Changeset in webkit [190352] by dbates@webkit.org
  • 2 edits in trunk/Tools

Actually fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
(https://bugs.webkit.org/show_bug.cgi?id=149539)

I inadvertently didn't remove the ONLY_ACTIVE_ARCH=NO flag when building on a Mac
in <http://trac.webkit.org/changeset/190351>.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(CompileWebKit.start):

10:19 AM Changeset in webkit [190351] by dbates@webkit.org
  • 2 edits in trunk/Tools

Attempt to fix the Mac builders build after <http://trac.webkit.org/changeset/190219>
(https://bugs.webkit.org/show_bug.cgi?id=149539)

{32, 64}-bit Mac builders should not try to build project {Plugin.64, Plugin.32},
respectively; only pass ONLY_ACTIVE_ARCH=NO when building for iOS.

  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(CompileWebKit.start):

10:17 AM Changeset in webkit [190350] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Unreviewed, rolling out r190324.
https://bugs.webkit.org/show_bug.cgi?id=149671

Caused flaky crashes, rdar://problem/22916304 (Requested by ap
on #webkit).

Reverted changeset:

"ParallelHelperPool::runFunctionInParallel() shouldn't
allocate, and ParallelHelperPool.h shouldn't be included
everywhere"
https://bugs.webkit.org/show_bug.cgi?id=149635
http://trac.webkit.org/changeset/190324

9:56 AM Changeset in webkit [190349] by Lucas Forschler
  • 2 edits in trunk/Tools

bot210 was configured for a queue instead of bot126.

Unreviewed config.json fix.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
9:35 AM Changeset in webkit [190348] by Lucas Forschler
  • 3 edits in trunk/Tools

Bring El Capitan buildbot infrastructure online.
https://bugs.webkit.org/show_bug.cgi?id=149605

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
8:39 AM Changeset in webkit [190347] by Antti Koivisto
  • 18 edits in trunk/Source/WebCore

Use separate style resolver for user agent shadow trees
https://bugs.webkit.org/show_bug.cgi?id=149626

Reviewed by Andreas Kling.

We now support separate style resolvers for shadow trees. Use this mechanism to have a separate
per-document style resolver for user agent shadow trees. This isolates user agent shadow trees
from author style better and simplifies the style resolver. It can also avoid some unnecessary style recalcs.

  • css/DocumentRuleSets.cpp:

(WebCore::DocumentRuleSets::resetAuthorStyle):
(WebCore::DocumentRuleSets::appendAuthorStyleSheets):

Change interface so that only the new rules are provided.

  • css/DocumentRuleSets.h:
  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::addElementStyleProperties):
(WebCore::ElementRuleCollector::collectMatchingRules):

We can remove special bailout as shadow tree style resolver won't have other author style

(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):

Remove the exception that disables property whitelists for UA stylesheets. We don't seem to use the feature.

(WebCore::ElementRuleCollector::matchUARules):
(WebCore::MatchingUARulesScope::MatchingUARulesScope): Deleted.
(WebCore::MatchingUARulesScope::~MatchingUARulesScope): Deleted.
(WebCore::MatchingUARulesScope::isMatchingUARules): Deleted.

Remove this unnecessary hack.

  • css/ElementRuleCollector.h:

(WebCore::ElementRuleCollector::ElementRuleCollector):

  • css/RuleSet.cpp:

(WebCore::RuleSet::addStyleRule):
(WebCore::RuleSet::copyShadowPseudoElementRulesFrom):

Also copy WebVTT rules. They are currently a sort of mixture of UA and author shadow tree.

(WebCore::shrinkMapVectorsToFit):

  • css/RuleSet.h:

(WebCore::RuleData::containsUncommonAttributeSelector):
(WebCore::RuleData::linkMatchType):
(WebCore::RuleData::hasDocumentSecurityOrigin):
(WebCore::RuleData::propertyWhitelistType):
(WebCore::RuleData::descendantSelectorIdentifierHashes):
(WebCore::RuleSet::ruleCount):
(WebCore::RuleSet::hasShadowPseudoElementRules):

  • css/StyleInvalidationAnalysis.cpp:

(WebCore::StyleInvalidationAnalysis::StyleInvalidationAnalysis):
(WebCore::StyleInvalidationAnalysis::invalidateIfNeeded):

Don't invalidate the whole tree when author shadow pseudo element rules change. Just invalidate the shadow trees.

(WebCore::StyleInvalidationAnalysis::invalidateStyleForTree):
(WebCore::StyleInvalidationAnalysis::invalidateStyle):
(WebCore::invalidateIfNeeded): Deleted.
(WebCore::invalidateStyleForTree): Deleted.

  • css/StyleInvalidationAnalysis.h:

(WebCore::StyleInvalidationAnalysis::dirtiesAllStyle):
(WebCore::StyleInvalidationAnalysis::hasShadowPseudoElementRulesInAuthorSheet):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::MatchResult::addMatchedProperties):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::appendAuthorStyleSheets):

Simpler interface.

  • css/StyleResolver.h:

(WebCore::StyleResolver::document):
(WebCore::StyleResolver::documentSettings):
(WebCore::StyleResolver::ruleSets):

  • dom/AuthorStyleSheets.cpp:

(WebCore::AuthorStyleSheets::collectActiveStyleSheets):
(WebCore::AuthorStyleSheets::analyzeStyleSheetChange):

Cleanups.

(WebCore::filterEnabledNonemptyCSSStyleSheets):
(WebCore::AuthorStyleSheets::updateActiveStyleSheets):
(WebCore::AuthorStyleSheets::updateStyleResolver):

Factor to a function.
Copy any author shadow pseudo elements to user agent shadow tree resolver.

(WebCore::AuthorStyleSheets::activeStyleSheetsForInspector):

  • dom/AuthorStyleSheets.h:
  • dom/Document.cpp:

(WebCore::Document::createStyleResolver):
(WebCore::Document::userAgentShadowTreeStyleResolver):

Use separate resolver.

(WebCore::Document::fontsNeedUpdate):
(WebCore::Document::clearStyleResolver):

  • dom/Document.h:

(WebCore::Document::ensureStyleResolver):

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::styleResolver):

Return document-global shadow tree resolver for ua trees.

  • style/StyleResolveTree.cpp:

(WebCore::Style::resolveShadowTree):

Take styleChange of shadow root into account.

7:07 AM Changeset in webkit [190346] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

[GTK] Deprecation warnings in DOMNodeTest
https://bugs.webkit.org/show_bug.cgi?id=149663

After the webkit_dom_document_get_elements_by_tag_name deprecation we
need to update the tests to use webkit_dom_document_query_selector_all
to avoid compilation warnings.

Also add a new test for webkit_dom_document_get_elements_by_tag_name_as_html_collection
(the suggested replacement for the deprecated function).

Patch by Tomas Popela <tpopela@redhat.com> on 2015-09-30
Reviewed by Carlos Garcia Campos.

  • TestWebKitAPI/Tests/WebKit2Gtk/DOMNodeTest.cpp:

(WebKitDOMNodeTest::testTagNamesNodeList):
(WebKitDOMNodeTest::testTagNamesHTMLCollection):
(registerTests):
(WebKitDOMNodeTest::testTagNames): Deleted.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestDOMNode.cpp:

(prepareDOMForTagNamesTests):
(testWebKitDOMNodeTagNamesNodeList):
(testWebKitDOMNodeTagNamesHTMLCollection):
(beforeAll):
(testWebKitDOMNodeTagNames): Deleted.

5:58 AM WebKitGTK/2.10.x edited by clopez@igalia.com
(diff)
5:55 AM Changeset in webkit [190345] by clopez@igalia.com
  • 2 edits in trunk/Source/WebKit2

[GTK] Build error with -DENABLE_SPELLCHECK=OFF
https://bugs.webkit.org/show_bug.cgi?id=146904

Reviewed by Carlos Garcia Campos.

Add ifdef guards to allow building when SPELLCHECK is not enabled.

  • UIProcess/gtk/TextCheckerGtk.cpp:

(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::getGuessesForWord):
(WebKit::TextChecker::learnWord):
(WebKit::TextChecker::ignoreWord):
(WebKit::TextChecker::requestCheckingOfString):
(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::setSpellCheckingLanguages):
(WebKit::TextChecker::loadedSpellCheckingLanguages):

2:55 AM Changeset in webkit [190344] by yoon@igalia.com
  • 14 edits in trunk/Source

[GTK] Support HiDPI Properly in WebKitGtk+ with the TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=141782

Reviewed by Carlos Garcia Campos.

Source/WebCore:

This patch fixes HiDPI issue in the TextureMapper.
To support HiDPI in the TextureMapper, we need to draw scaled contents
in the TextureMapperTile, and apply the global scale in the root layer
to apply transforms correctly.

Supporting the device scale is handled at LayerTreeHostGtk and
TextureMapperBackingStore, and GraphicsLayerTextureMapper doesn't handle
the device scale directly.

From the TextureMapperLayer, deviceScale and pageScale do not have to be
handled differently. These are multiplied and provided to
TextureMapperBackingStore.

  • platform/graphics/texmap/TextureMapperTile.cpp:

(WebCore::TextureMapperTile::updateContents):

  • platform/graphics/texmap/TextureMapperTile.h:
  • platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:

Modified to increase the cover rect for tiles creation. For the image
contents, it just creates texture with a image size, regardless of the
contents scale.

  • platform/graphics/texmap/BitmapTexture.cpp:

(WebCore::BitmapTexture::updateContents):

Apply the device scale to the graphics context before painting contents.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setContentsToImage):
(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded):

Apply the device scale and the page scale to the backing store

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:
  • UIProcess/gtk/RedirectedXCompositeWindow.cpp:

Modified to create scaled size of window.

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::initialize):
(WebKit::LayerTreeHostGtk::deviceOrPageScaleFactorChanged):

We should apply device scale factor to the root layer to apply
the scale matrix before applying other transform matrices.

(WebKit::LayerTreeHostGtk::deviceScaleFactor): Added.
(WebKit::LayerTreeHostGtk::pageScaleFactor): Added.

Sep 29, 2015:

11:00 PM Changeset in webkit [190343] by commit-queue@webkit.org
  • 1 edit
    1 add in trunk/LayoutTests

Update iOS-simulator results for fast/text/mark-matches-overflow-clip.html
<https://bugs.webkit.org/show_bug.cgi?id=149637>

Patch by Ryan Haddad <Ryan Haddad> on 2015-09-29
Reviewed by Darin Adler.

  • platform/ios-simulator/fast/text/mark-matches-overflow-clip-expected.txt: Added.
10:58 PM Changeset in webkit [190342] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Console completion suggestions should include properties on Object (hasOwnProperty, toString, etc)
https://bugs.webkit.org/show_bug.cgi?id=149649

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-29
Reviewed by Darin Adler.

  • UserInterface/Base/Utilities.js:

(value):
Since keySets in this instance are often used as hash maps with the
in operator, create a blank object that won't have Object.prototype
functions that would be seen by in.

  • UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:

(WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.receivedPropertyNames.compare):
Sort defineGetter and lookupGetter and friends last, since they
are rarely used properties.

10:57 PM Changeset in webkit [190341] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Missing completions for Symbol objects, console.error warning
https://bugs.webkit.org/show_bug.cgi?id=149641

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-09-29
Reviewed by Darin Adler.

  • UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:

(WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.getCompletions):
(WebInspector.JavaScriptRuntimeCompletionProvider.prototype.completionControllerCompletionsNeeded.evaluated):
Include completions for symbol types.

10:55 PM Changeset in webkit [190340] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

ASSERTION FAILED: !isUnreachableNode(m_target.get()) when hovering over any input element
https://bugs.webkit.org/show_bug.cgi?id=149589

Reviewed by Darin Adler.

The bug was caused by target not being reset across shadow boundary when SHADOW_DOM was disabled.

No new tests since exiting tests cover this in debug builds. e.g. editing/deleting/5290534.html

  • dom/EventDispatcher.cpp:

(WebCore::EventPath::EventPath):

10:54 PM Changeset in webkit [190339] by jhoneycutt@apple.com
  • 4 edits
    2 adds in trunk

Avoid reparsing an XSLT stylesheet after the first failure.
https://bugs.webkit.org/show_bug.cgi?id=149188
<rdar://problem/22709912>

Reviewed by Dave Hyatt.

Patch by Jiewen Tan, jiewen_tan@apple.com.

Source/WebCore:

Test: svg/custom/invalid-xslt-crash.svg

  • xml/XSLStyleSheet.h:

Add a new member variable m_compilationFailed that tracks whether
compilation has failed. Default value is false.

  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::compileStyleSheet):
Return early if the compilation has failed before. After compiling the
style sheet, if we failed, set m_compilationFailed to true.

LayoutTests:

  • svg/custom/invalid-xslt-crash-expected.txt: Added.
  • svg/custom/invalid-xslt-crash.svg: Added.
10:53 PM Changeset in webkit [190338] by commit-queue@webkit.org
  • 19 edits in trunk/Source/WebCore

Use modern for-loops in WebCore/loader.
https://bugs.webkit.org/show_bug.cgi?id=149397

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-09-29
Reviewed by Darin Adler.

No new tests because there is no behavior change.

  • loader/CrossOriginAccessControl.cpp:

(WebCore::parseAccessControlExposeHeadersAllowList):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::substituteResourceDeliveryTimerFired):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::create):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::~FrameLoader):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::detachChildren):
(WebCore::FrameLoader::shouldClose):
(WebCore::FrameLoader::tellClientAboutPastMemoryCacheLoads):

  • loader/HistoryController.cpp:

(WebCore::HistoryController::currentFramesMatchItem):

  • loader/SubframeLoader.cpp:

(WebCore::findPluginMIMETypeFromURL):
(WebCore::SubframeLoader::createJavaAppletWidget):

  • loader/appcache/ApplicationCache.cpp:

(WebCore::ApplicationCache::isURLInOnlineWhitelist):
(WebCore::ApplicationCache::urlMatchesFallbackNamespace):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):
(WebCore::ApplicationCacheGroup::postListenerTask):

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::stopDeferringEvents):

  • loader/appcache/ApplicationCacheStorage.cpp:

(WebCore::StorageIDJournal::~StorageIDJournal):
(WebCore::ApplicationCacheStorage::store):
(WebCore::ApplicationCacheStorage::getOriginsWithCache):

  • loader/archive/Archive.cpp:

(WebCore::Archive::clearAllSubframeArchivesImpl):

  • loader/archive/ArchiveResourceCollection.cpp:

(WebCore::ArchiveResourceCollection::addAllResources):

  • loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::LegacyWebArchive::createPropertyListRepresentation):
(WebCore::LegacyWebArchive::create):

  • loader/archive/mhtml/MHTMLArchive.cpp:

(WebCore::MHTMLArchive::generateMHTMLData):

  • loader/cache/CachedImage.cpp:

(WebCore::CachedImage::switchClientsToRevalidatedResource):
(WebCore::CachedImage::createImage):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::switchClientsToRevalidatedResource):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::~CachedResourceLoader):
(WebCore::CachedResourceLoader::reloadImagesIfNotDeferred):
(WebCore::CachedResourceLoader::garbageCollectDocumentResources):
(WebCore::CachedResourceLoader::isPreloaded):
(WebCore::CachedResourceLoader::printPreloadStats):

  • loader/icon/IconDatabase.cpp:

(WebCore::IconDatabase::removeAllIcons):
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::iconRecordCountWithData):
(WebCore::IconDatabase::notifyPendingLoadDecisions):
(WebCore::IconDatabase::performURLImport):
(WebCore::IconDatabase::performPendingRetainAndReleaseOperations):
(WebCore::IconDatabase::readFromDatabase):
(WebCore::IconDatabase::writeToDatabase):

9:31 PM Changeset in webkit [190337] by Chris Dumez
  • 4 edits in trunk

sectionRowIndex must return -1 when its parent is not a table, tbody, thead, or tfoot
https://bugs.webkit.org/show_bug.cgi?id=148841
<rdar://problem/22586870>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline W3C HTML test now that more checks are passing.

  • web-platform-tests/html/semantics/tabular-data/the-tr-element/sectionRowIndex-expected.txt:

Source/WebCore:

Update HTMLTableRowElement.sectionRowIndex to match the specification:
https://html.spec.whatwg.org/multipage/tables.html#dom-tr-sectionrowindex

In particular, it now returns -1 if the parent is not a table, tbody,
thead and tfoot.

No new tests, already covered by existing test.

  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::sectionRowIndex):

6:30 PM Changeset in webkit [190336] by dbates@webkit.org
  • 10 edits
    1 copy in trunk/Source

Make WebKit for iOS Simulator build with the public iOS 9 SDK
https://bugs.webkit.org/show_bug.cgi?id=149652

Reviewed by Simon Fraser.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj: Add private header pthreadSPI.h. Also move entry for IDBTransaction.h so that it is in sorted order.
  • platform/ios/WebVideoFullscreenInterfaceAVKit.mm: Substitute AVPlayerViewControllerDelegate_WebKitOnly for AVPlayerViewControllerDelegate.
  • platform/spi/cocoa/AVKitSPI.h: As of iOS 9, AVPlayerViewControllerDelegate is a public protocol. Separate out WebKit-specific SPI into protocol

AVPlayerViewControllerDelegate_WebKitOnly, which extends AVPlayerViewControllerDelegate. Also, the properties -[AVPlayerViewController allowsPictureInPicturePlayback] and -[AVPlayerViewController delegate] are public in iOS 9.

  • platform/spi/cocoa/pthreadSPI.h: Added.
  • platform/spi/ios/LaunchServicesSPI.h: Add more SPI.
  • platform/spi/ios/MediaPlayerSPI.h: Ignore deprecation warnings for UIPopoverController and UIActionSheet.

Source/WebKit2:

  • Platform/spi/ios/SafariServicesSPI.h: Add definition for SFSafariViewController.
  • Platform/spi/ios/UIKitSPI.h: Add more SPI.
  • WebProcess/cocoa/WebProcessCocoa.mm: Include header pthreadSPI.h.
6:20 PM Changeset in webkit [190335] by Simon Fraser
  • 12 edits
    1 copy in trunk/Tools

WebKitTestRunner fails to apply "useFlexibleViewport" when it's specified in a file comment
https://bugs.webkit.org/show_bug.cgi?id=149650

Reviewed by Tim Horton.

TestInvocation::invoke() consulted shouldMakeViewportFlexible(), but that only
looks at the file path, and not the custom options that come from file comments.

Fix by computing TestOptions before making the TestInvocation, and setting them
as const TestInvocation data. This meant changing various call sites to take
the std::string pathOrURL, rather than the TestInvocation itself.

Also initialize TestInvocation with a WKURLRef, rather than a std::string.

  • WebKitTestRunner/CMakeLists.txt:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::ensureViewSupportsOptionsForTest):
(WTR::testPath):
(WTR::createTestURL):
(WTR::updateTestOptionsFromTestHeader):
(WTR::TestController::testOptionsForTest):
(WTR::TestController::updateWebViewSizeForTest):
(WTR::TestController::updateWindowScaleForTest):
(WTR::TestController::runTest):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::TestInvocation):
(WTR::TestInvocation::invoke):
(WTR::createWKURL): Deleted.
(WTR::TestInvocation::shouldMakeViewportFlexible): Deleted.
(WTR::TestInvocation::shouldUseFixedLayout): Deleted.

  • WebKitTestRunner/TestInvocation.h:

(WTR::TestInvocation::options):

  • WebKitTestRunner/TestOptions.cpp: Copied from Tools/WebKitTestRunner/TestOptions.h.

(WTR::pathContains):
(WTR::shouldMakeViewportFlexible):
(WTR::shouldUseFixedLayout):
(WTR::isSVGTestPath):
(WTR::isHiDPITestPath):
(WTR::TestOptions::TestOptions):

  • WebKitTestRunner/TestOptions.h:
  • WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
  • WebKitTestRunner/efl/TestControllerEfl.cpp:

(WTR::pathContains):
(WTR::shouldUseFixedLayout):
(WTR::TestController::updatePlatformSpecificTestOptionsForTest):

  • WebKitTestRunner/gtk/TestControllerGtk.cpp:

(WTR::TestController::updatePlatformSpecificTestOptionsForTest):

  • WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::updatePlatformSpecificTestOptionsForTest):

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::updatePlatformSpecificTestOptionsForTest):

5:29 PM Changeset in webkit [190334] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

Flakiness dashboard should support OS X El Capitan
https://bugs.webkit.org/show_bug.cgi?id=149648

Patch by Aakash Jain <aakash_jain@apple.com> on 2015-09-29
Reviewed by Alexey Proskuryakov.

  • QueueStatusServer/app.yaml: We do not need to maintain SVN revision here because of

difference between new appscale and old Google App Engine implementation.

  • TestResultServer/app.yaml: Same.
  • TestResultServer/static-dashboards/builders.jsonp: Added OSX El Capitan support.
5:21 PM Changeset in webkit [190333] by dbates@webkit.org
  • 2 edits in trunk/Tools

configure-xcode-for-ios-development does not work with Xcode 7
https://bugs.webkit.org/show_bug.cgi?id=149640

Reviewed by Alexey Proskuryakov.

When Xcode 7 is installed, running configure-xcode-for-ios-development dies with an error
because it cannot find the Xcode specification files for iOS simulator and device. These
files have moved to a new location in Xcode 7 distribution. Moreover we must add the
relevant definitions to the Xcode 7 specification files directly as opposed to creating
new specification files with the added definitions (as we did in older versions of Xcode)
in order for Xcode 7 to honor these definitions.

  • Scripts/configure-xcode-for-ios-development: Sorted forward declarations.

(updateXcodeSpecificationFilesForSDKIfNeeded): Added.
(updateXcode7SpecificationFile): Added.
(createLegacyXcodeSpecificationFilesForSDKIfNeeded): Formerly named createXcodeSpecificationFilesForSDKIfNeeded.
(writeXcodeSpecification): Moved congratulations line to caller so as to write out the
appropriate success message.
(mergeXcodeSpecificationWithSpecificationAndId): Formerly named createXcodeSpecificationFromSpecificationAndId.
(createXcodeSpecificationFilesForSDKIfNeeded): Deleted.
(createXcodeSpecificationFromSpecificationAndId): Deleted.

5:16 PM Changeset in webkit [190332] by beidson@apple.com
  • 5 edits in trunk/Source

Followup to "Move WebKit2 AsyncTask to WebCore CrossThreadTask."
https://bugs.webkit.org/show_bug.cgi?id=149651

Rubberstamped by Alex Christensen.

Source/WebCore:

No new tests (No change in behavior).

  • platform/CrossThreadTask.h: Now in WebCore, use the WebCore namespace.

Source/WebKit2:

  • DatabaseProcess/DatabaseProcess.h: CrossThreadTask is in the WebCore namespace, not WebKit.
  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.h: Ditto.
4:28 PM Changeset in webkit [190331] by beidson@apple.com
  • 8 edits
    1 move in trunk/Source

Move WebKit2 AsyncTask to WebCore CrossThreadTask.
https://bugs.webkit.org/show_bug.cgi?id=149651

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (No change in behavior).

It will be needed in WebCore to support IndexedDB.

  • WebCore.xcodeproj/project.pbxproj:
  • platform/CrossThreadTask.h: Renamed from Source/WebKit2/Shared/AsyncTask.h.

(WebKit::CrossThreadTask::CrossThreadTask):
(WebKit::CrossThreadTask::performTask):
(WebKit::createCrossThreadTask):

Source/WebKit2:

  • DatabaseProcess/DatabaseProcess.cpp:

(WebKit::DatabaseProcess::ensureIndexedDatabaseRelativePathExists):
(WebKit::DatabaseProcess::postDatabaseTask):
(WebKit::DatabaseProcess::performNextDatabaseTask):
(WebKit::DatabaseProcess::fetchWebsiteData):
(WebKit::DatabaseProcess::deleteWebsiteData):
(WebKit::DatabaseProcess::deleteWebsiteDataForOrigins):

  • DatabaseProcess/DatabaseProcess.h:
  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.cpp:

(WebKit::UniqueIDBDatabase::shutdown):
(WebKit::UniqueIDBDatabase::shutdownBackingStore):
(WebKit::UniqueIDBDatabase::getOrEstablishIDBDatabaseMetadata):
(WebKit::UniqueIDBDatabase::openBackingStoreAndReadMetadata):
(WebKit::UniqueIDBDatabase::openTransaction):
(WebKit::UniqueIDBDatabase::beginTransaction):
(WebKit::UniqueIDBDatabase::commitTransaction):
(WebKit::UniqueIDBDatabase::resetTransaction):
(WebKit::UniqueIDBDatabase::rollbackTransaction):
(WebKit::UniqueIDBDatabase::postTransactionOperation):
(WebKit::UniqueIDBDatabase::changeDatabaseVersion):
(WebKit::UniqueIDBDatabase::createObjectStore):
(WebKit::UniqueIDBDatabase::deleteObjectStore):
(WebKit::UniqueIDBDatabase::clearObjectStore):
(WebKit::UniqueIDBDatabase::createIndex):
(WebKit::UniqueIDBDatabase::deleteIndex):
(WebKit::UniqueIDBDatabase::putRecord):
(WebKit::UniqueIDBDatabase::getRecord):
(WebKit::UniqueIDBDatabase::openCursor):
(WebKit::UniqueIDBDatabase::cursorAdvance):
(WebKit::UniqueIDBDatabase::cursorIterate):
(WebKit::UniqueIDBDatabase::count):
(WebKit::UniqueIDBDatabase::deleteRange):
(WebKit::UniqueIDBDatabase::openBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::beginBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::commitBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::resetBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::rollbackBackingStoreTransaction):
(WebKit::UniqueIDBDatabase::changeDatabaseVersionInBackingStore):
(WebKit::UniqueIDBDatabase::createObjectStoreInBackingStore):
(WebKit::UniqueIDBDatabase::deleteObjectStoreInBackingStore):
(WebKit::UniqueIDBDatabase::clearObjectStoreInBackingStore):
(WebKit::UniqueIDBDatabase::createIndexInBackingStore):
(WebKit::UniqueIDBDatabase::deleteIndexInBackingStore):
(WebKit::UniqueIDBDatabase::putRecordInBackingStore):
(WebKit::UniqueIDBDatabase::getRecordFromBackingStore):
(WebKit::UniqueIDBDatabase::openCursorInBackingStore):
(WebKit::UniqueIDBDatabase::advanceCursorInBackingStore):
(WebKit::UniqueIDBDatabase::iterateCursorInBackingStore):
(WebKit::UniqueIDBDatabase::countInBackingStore):
(WebKit::UniqueIDBDatabase::deleteRangeInBackingStore):
(WebKit::UniqueIDBDatabase::postMainThreadTask):
(WebKit::UniqueIDBDatabase::performNextMainThreadTask):
(WebKit::UniqueIDBDatabase::postDatabaseTask):
(WebKit::UniqueIDBDatabase::performNextDatabaseTask):

  • DatabaseProcess/IndexedDB/UniqueIDBDatabase.h:
  • WebKit2.xcodeproj/project.pbxproj:
3:56 PM Changeset in webkit [190330] by Wenson Hsieh
  • 10 edits
    4 adds in trunk

Snap offsets should update when style is programmatically changed
https://bugs.webkit.org/show_bug.cgi?id=135964
<rdar://problem/18162411>

Reviewed by Darin Adler.

Source/WebCore:

Tests: css3/scroll-snap/scroll-snap-style-changed-coordinates.html

css3/scroll-snap/scroll-snap-style-changed-repeat.html

Updating scroll snap style properties now programmatically updates the scroll snap container. Does not yet
handle the case of reparented elements with scroll snap coordinates. Adds some plumbing the FrameView and
RenderLayerCompositor to immediately update the scrolling coordinator when updating the FrameView due to
style changes.

  • page/FrameView.cpp:

(WebCore::FrameView::updateScrollingCoordinatorScrollSnapProperties): Calls on the compositor to reupdate scroll snap

properties on the FrameView.

  • page/FrameView.h:
  • page/scrolling/AsyncScrollingCoordinator.cpp: Sets snap offsets to an empty vector when appropriate.

(WebCore::setStateScrollingNodeSnapOffsetsAsFloat): Ditto.
(WebCore::AsyncScrollingCoordinator::frameViewLayoutUpdated): Ditto.
(WebCore::AsyncScrollingCoordinator::updateOverflowScrollingNode): Ditto.
(WebCore::AsyncScrollingCoordinator::updateScrollSnapPropertiesWithFrameView): Updates scroll snap properties

from a given FrameView.

  • page/scrolling/AsyncScrollingCoordinator.h:
  • page/scrolling/ScrollingCoordinator.h:

(WebCore::ScrollingCoordinator::updateScrollSnapPropertiesWithFrameView):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateScrollSnapPropertiesWithFrameView): Updates the scrolling coordinator's

scroll snap properties.

  • rendering/RenderLayerCompositor.h: Plumb scroll snap property updating to the FrameView.
  • rendering/RenderLayerModelObject.cpp: Checks for style changes and updates snap offsets when appropriate.

(WebCore::scrollSnapContainerRequiresUpdateForStyleUpdate): Ditto.
(WebCore::RenderLayerModelObject::styleDidChange): Ditto.

LayoutTests:

Tests style updates in both cases where -points and -coordinates are used to position snap points.

  • css3/scroll-snap/scroll-snap-style-changed-coordinates-expected.txt: Added.
  • css3/scroll-snap/scroll-snap-style-changed-coordinates.html: Added.
  • css3/scroll-snap/scroll-snap-style-changed-repeat-expected.txt: Added.
  • css3/scroll-snap/scroll-snap-style-changed-repeat.html: Added.
2:25 PM Changeset in webkit [190329] by commit-queue@webkit.org
  • 33 edits
    8 deletes in trunk

Unreviewed, rolling out r190289.
https://bugs.webkit.org/show_bug.cgi?id=149647

Crashing speedometer and some ARM32 tests (Requested by
msaboff on #webkit).

Reverted changeset:

"[ES6] Implement tail calls in the FTL"
https://bugs.webkit.org/show_bug.cgi?id=148664
http://trac.webkit.org/changeset/190289

2:16 PM Changeset in webkit [190328] by Brent Fulgham
  • 4 edits in trunk/Tools

[Win] Allow 'prepare-ChangeLog' to be used without Cygwin
https://bugs.webkit.org/show_bug.cgi?id=149639

Reviewed by Alex Christensen.

  • Scripts/VCSUtils.pm:

(exitStatus): Use 'isWindows()' method.
(isSVNVersion16OrNewer): 'eval' is not needed here, and just causes
an error. This method could probably just go away.
(normalizePath): Leave Windows (or Unix) paths as platform paths, rather than
always changing to Unix style.
(unixPath): Added. Needed so Windows can always show a Unix path in the
ChangeLog file.
(changeLogName): Work around the fact that 'getpwuid' is not available on
a pure Windows build of Perl.

  • Scripts/prepare-ChangeLog:

(generateFunctionLists): Normalize path received from 'svn' in case it's a Unix
path on Windows.
(svnUpdateCommand): Added helper function. Needed because Windows Perl does not
support using arrays for 'open' arguments.
(resolveChangeLogsPath): Ditto.
(resolveConflictedChangeLogs): Use new helper functions.
(generateNewChangeLogs): Force Windows to use Unix paths in ChangeLog output.
(diffCommand): Use double-quotes for paths, since Windows doesn't understand single
quotes. Unix systems are happy either way.
(statusCommand): Ditto.

  • Scripts/webkitdirs.pm:

(launcherName): Drive-by fix. WinLauncher was renamed to MiniBrowser some time ago.

2:03 PM Changeset in webkit [190327] by jer.noble@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION: WebAudio user-gesture restriction is no longer lifted by touchstart event
https://bugs.webkit.org/show_bug.cgi?id=149367

Reviewed by Eric Carlson.

Use processingUserGestureForMedia() rather than processingUserGesture(),
as the former includes touchstart and the latter does not.

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::willBeginPlayback):
(WebCore::AudioContext::willPausePlayback):

  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::playbackPermitted):
(WebCore::MediaElementSession::dataLoadingPermitted):
(WebCore::MediaElementSession::fullscreenPermitted):
(WebCore::MediaElementSession::showPlaybackTargetPicker):

2:01 PM Changeset in webkit [190326] by Brent Fulgham
  • 2 edits
    1 add in trunk/LayoutTests

[Win] Rebaseline test.

Rubberstamped by Tim Horton.

  • platform/win/TestExpectations: Remove test failure.
  • platform/win/fast/text/mark-matches-overflow-clip-expected.txt: Added.
1:56 PM Changeset in webkit [190325] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardening.

  • platform/win/TestExpectations: Mark new test added in

r190254 as failing.

1:25 PM Changeset in webkit [190324] by fpizlo@apple.com
  • 5 edits in trunk/Source

ParallelHelperPool::runFunctionInParallel() shouldn't allocate, and ParallelHelperPool.h shouldn't be included everywhere
https://bugs.webkit.org/show_bug.cgi?id=149635

Reviewed by Saam Barati.

Source/JavaScriptCore:

It bugged me that this change caused a whole-world recompile. So, I changed the code so
that ParallelHelperPool.h is only included by Heap.cpp and not by Heap.h.

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::markRoots):
(JSC::Heap::copyBackingStores):

  • heap/Heap.h:

Source/WTF:

  • wtf/ParallelHelperPool.h:

(WTF::ParallelHelperClient::runFunctionInParallel): Stack-allocate the task instead of heap-allocating it.

1:22 PM Changeset in webkit [190323] by rniwa@webkit.org
  • 8 edits in trunk

Update style/layout when a slot is added or removed
https://bugs.webkit.org/show_bug.cgi?id=149593

Reviewed by Antti Koivisto.

Source/WebCore:

Fixed the bug by forcing the render tree reconstruction on the shadow host when a slot is inserted or removed.
We should optimize these reconstructions by only triggering them on the affected slot elements in the future.

Also fixed a bug that we were not invalidating the slot assignments when a default slot is introduced dynamically
after the slot assignment algorithm had run.

Test (existing): fast/shadow-dom/shadow-layout-after-slot-changes.html

  • dom/ShadowRoot.cpp:

(WebCore::ShadowRoot::addSlotElementByName): Passes in ShadowRoot.
(WebCore::ShadowRoot::removeSlotElementByName): Ditto.

  • dom/SlotAssignment.cpp:

(WebCore::SlotAssignment::addSlotElementByName): Call setNeedsStyleRecalc.
(WebCore::SlotAssignment::removeSlotElementByName): Call setNeedsStyleRecalc if the host is still alive since this
function can be called while the host is being destructed in which case shadowRoot.host() would be nullptr.

  • dom/SlotAssignment.h:

LayoutTests:

Removed failing test expectations from fast/shadow-dom/shadow-layout-after-slot-changes.html

Also added an explicit test case for when a default slot is introduced dynamically after
calling getDistributedNodes() once, thereby forcing the slot assignments.

  • fast/shadow-dom/HTMLSlotElement-interface-expected.txt:
  • fast/shadow-dom/HTMLSlotElement-interface.html:
  • fast/shadow-dom/shadow-layout-after-slot-changes.html:
  • platform/mac/TestExpectations:
12:20 PM Changeset in webkit [190322] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Update test expectations to mark quicklook/pages.html as crashing
<https://bugs.webkit.org/show_bug.cgi?id=149634>

Patch by Ryan Haddad <Ryan Haddad> on 2015-09-29
Reviewed by David Kilzer.

  • platform/ios-simulator/TestExpectations:
12:18 PM Changeset in webkit [190321] by Michael Catanzaro
  • 2 edits in trunk

[GTK][CMake] Warning about CMP0058
https://bugs.webkit.org/show_bug.cgi?id=149627

Reviewed by Martin Robinson.

Opt-in to the new behavior for CMP0058.

  • CMakeLists.txt:
12:04 PM Changeset in webkit [190320] by Chris Dumez
  • 5 edits
    2 adds in trunk

Memory cache revalidations should refresh the network disk cache
https://bugs.webkit.org/show_bug.cgi?id=149606

Reviewed by Darin Adler.

Source/WebKit2:

Previously, resource revalidations triggered by the memory cache would
bypass the disk cache entirely because the requests are conditional. As
a result, when the server responds with a 304, we were unable to update
the headers (e.g. new expiration date) of the corresponding entry in
the disk cache.

This patch updates our disk cache implementation to not bypass the disk
cache when the request is conditional. Instead, we look up the cached
entry and force its revalidation from the network. If the server then
returns a 304, we are now able to update the headers of this cached
entry. In such case though, we let the 304 response through to WebCore
unlike revalidations triggered by the disk cache.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponseAsync):

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::makeUseDecision):
(WebKit::NetworkCache::makeRetrieveDecision):

LayoutTests:

Add layout test to check that revalidations requested by the memory cache
update the corresponding disk cache entry when the server responds with a
304 status code.

  • http/tests/cache/disk-cache/memory-cache-revalidation-updates-disk-cache-expected.txt: Added.
  • http/tests/cache/disk-cache/memory-cache-revalidation-updates-disk-cache.html: Added.
11:35 AM Changeset in webkit [190319] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed, mark several newly imported W3C media tests as flaky on Mavericks.
https://bugs.webkit.org/show_bug.cgi?id=149636

  • platform/mac/TestExpectations:
11:32 AM Changeset in webkit [190318] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Revise failure case per Alexey's comments.

  • platform/win/TestExpectations:
11:24 AM Changeset in webkit [190317] by calvaris@igalia.com
  • 1 edit
    2 adds in trunk/LayoutTests

[Streams API] Add abstract ops tests
https://bugs.webkit.org/show_bug.cgi?id=149629

Reviewed by Darin Adler.

  • streams/reference-implementation/abstract-ops-expected.txt: Added.
  • streams/reference-implementation/abstract-ops.html: Added.
11:08 AM Changeset in webkit [190316] by calvaris@igalia.com
  • 7 edits in trunk/LayoutTests

[Streams API] Update tests according to latest spec
https://bugs.webkit.org/show_bug.cgi?id=149628

Reviewed by Darin Adler.

Added checkpoints and updated all tests that don't disrupt the current implementation and the tests that are
passing now.

  • streams/reference-implementation/bad-strategies-expected.txt:
  • streams/reference-implementation/bad-strategies.html:
  • streams/reference-implementation/pipe-to-options.html:
  • streams/reference-implementation/pipe-to.html:
  • streams/reference-implementation/writable-stream-abort.html:
  • streams/reference-implementation/writable-stream.html:
10:53 AM Changeset in webkit [190315] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Test gardening

  • platform/win/TestExpectations: Mark some expected failures.
10:49 AM Changeset in webkit [190314] by youenn.fablet@crf.canon.fr
  • 21 edits
    9 adds in trunk/Source/WebCore

Improve binding of JSBuiltinConstructor classes
https://bugs.webkit.org/show_bug.cgi?id=149556

Reviewed by Darin Adler.

JSBuiltinConstructor classes no longer need definition of a DOM class.
These classes no longer go through the JS wrapper cache.
Removed code related to DOM class handling (m_impl, releaseImpl, WrapperOwner, toJS, ...)
Updated creation code.

Refactoring of the binding generator code to simplify whether generating or not some methods.

Removed unneeded include of DOM class in JSXX.cpp (already done in JSXX.h)

Added new binding test to cover JSBuiltinConstructor keyword.

Covered by binding tests.

  • bindings/js/JSDOMBinding.h:

(WebCore::createJSBuiltin):
(WebCore::DOMConstructorObject::createStructure):.

  • bindings/scripts/CodeGeneratorJS.pm:

(NeedsImplementationClass):
(ShouldGenerateToWrapped):
(ShouldGenerateWrapperOwnerCode):
(ShouldGenerateToJSDeclaration):
(ShouldGenerateToJSImplementation):
(GenerateHeader):
(GenerateImplementation):
(GenerateConstructorDefinition):
(ComputeFunctionSpecial):.
(UseJSBuiltins):.

  • bindings/scripts/test/GObject/WebKitDOMTestJSBuiltinConstructor.cpp: Added.

(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestJSBuiltinConstructor):
(webkit_dom_test_js_builtin_constructor_finalize):
(webkit_dom_test_js_builtin_constructor_constructor):
(webkit_dom_test_js_builtin_constructor_class_init):
(webkit_dom_test_js_builtin_constructor_init):

  • bindings/scripts/test/GObject/WebKitDOMTestJSBuiltinConstructor.h: Added.
  • bindings/scripts/test/GObject/WebKitDOMTestJSBuiltinConstructorPrivate.h: Added.
  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:
  • bindings/scripts/test/JS/JSTestEventTarget.cpp:
  • bindings/scripts/test/JS/JSTestException.cpp:
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp: Added.

(WebCore::JSTestJSBuiltinConstructorPrototype::create):
(WebCore::JSTestJSBuiltinConstructorPrototype::createStructure):
(WebCore::JSTestJSBuiltinConstructorPrototype::JSTestJSBuiltinConstructorPrototype):
(WebCore::JSTestJSBuiltinConstructorConstructor::create):
(WebCore::JSTestJSBuiltinConstructorConstructor::createStructure):
(WebCore::JSTestJSBuiltinConstructorConstructor::constructJSTestJSBuiltinConstructor):
(WebCore::JSTestJSBuiltinConstructorConstructor::JSTestJSBuiltinConstructorConstructor):
(WebCore::JSTestJSBuiltinConstructorConstructor::finishCreation):
(WebCore::JSTestJSBuiltinConstructorConstructor::getConstructData):
(WebCore::JSTestJSBuiltinConstructorPrototype::finishCreation):
(WebCore::JSTestJSBuiltinConstructor::JSTestJSBuiltinConstructor):
(WebCore::JSTestJSBuiltinConstructor::createPrototype):
(WebCore::JSTestJSBuiltinConstructor::getPrototype):
(WebCore::JSTestJSBuiltinConstructor::destroy):
(WebCore::JSTestJSBuiltinConstructor::~JSTestJSBuiltinConstructor):
(WebCore::jsTestJSBuiltinConstructorConstructor):
(WebCore::JSTestJSBuiltinConstructor::getConstructor):
(WebCore::JSTestJSBuiltinConstructor::visitChildren):

  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h: Added.

(WebCore::JSTestJSBuiltinConstructor::create):
(WebCore::JSTestJSBuiltinConstructor::createStructure):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
  • bindings/scripts/test/JS/JSTestNode.cpp:
  • bindings/scripts/test/JS/JSTestNondeterministic.cpp:
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
  • bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/JS/JSTestTypedefs.cpp:
  • bindings/scripts/test/JS/JSattribute.cpp:
  • bindings/scripts/test/JS/JSreadonly.cpp:
  • bindings/scripts/test/ObjC/DOMTestJSBuiltinConstructor.h: Added.
  • bindings/scripts/test/ObjC/DOMTestJSBuiltinConstructor.mm: Added.

(-[DOMTestJSBuiltinConstructor dealloc]):
(-[DOMTestJSBuiltinConstructor finalize]):
(core):
(kit):

  • bindings/scripts/test/ObjC/DOMTestJSBuiltinConstructorInternal.h: Added.
  • bindings/scripts/test/TestJSBuiltinConstructor.idl: Added.
10:41 AM Changeset in webkit [190313] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] [Font Features] Implement font-variant-*
https://bugs.webkit.org/show_bug.cgi?id=149630

Unreviewed gardening.

  • platform/win/TestExpectations: Mark expected failures due

to missing Windows feature.

10:24 AM Changeset in webkit [190312] by calvaris@igalia.com
  • 2 edits in trunk/Source/WebCore

[Streams API] [Win] Remove reference to dead CountQueuingStrategy.h
https://bugs.webkit.org/show_bug.cgi?id=149623

Reviewed by Darin Adler.

No new tests needed.

  • WebCore.vcxproj/WebCore.vcxproj.filters:
10:10 AM Changeset in webkit [190311] by Brent Fulgham
  • 2 edits in trunk/Tools

[Win] Unreviewed 64-bit build fix after switch to CMake.

  • Scripts/webkitdirs.pm:

(determineIsWin64FromArchitecture): Added.

9:39 AM Changeset in webkit [190310] by fpizlo@apple.com
  • 12 edits
    1 add in trunk/Source

GC copy phase spans too many files
https://bugs.webkit.org/show_bug.cgi?id=149586

Reviewed by Andreas Kling.

Source/JavaScriptCore:

This puts the core logic of the copy phase into Heap::copyBackingStores(). Now, instead of
using many helpers in many places, the actual algorithm is all in one place.

This lets me do a lot of simplification.

  • CopyVisitor no longer requires that you call startCopying() before, and doneCopying() and WTF::releaseFastMallocFreeMemoryForThisThread() after. The constructor and destructor now do this for you.
  • CopyVisitor no longer contains the algorithm that drives copying. That's all in Heap::copyBackingStores() now. Basically, copyBackingStores() glues together the new WTF::ParallelVectorIterator with the copying algorithm that we used to have in CopyVisitor::copyFromShared().
  • Lots of stuff that was in headers is now in .cpp files. That includes all non-hot-path code in CopyVisitor. Also, the code for copying in HeapInlines.h is now in ParallelVectorVisotor, and it's only included by Heap.cpp.

Overall, I like this direction for the GC. I don't think it's useful for Heap.cpp to have
calls to algorithms in some other file, unless those algorithms are either reusable or just
very dense. That's not actually true for the copy phase, and it's probably not true for
some other stuff like marking. I'll probably do the same refactoring for marking in another
bug.

This should have no effect on performance.

  • heap/CopyVisitor.cpp:

(JSC::CopyVisitor::CopyVisitor):
(JSC::CopyVisitor::~CopyVisitor):
(JSC::CopyVisitor::copyFromShared): Deleted.

  • heap/CopyVisitor.h:
  • heap/CopyVisitorInlines.h:

(JSC::CopyVisitor::checkIfShouldCopy):
(JSC::CopyVisitor::allocateNewSpaceSlow):
(JSC::CopyVisitor::didCopy):
(JSC::CopyVisitor::visitItem): Deleted.
(JSC::CopyVisitor::startCopying): Deleted.
(JSC::CopyVisitor::doneCopying): Deleted.

  • heap/Heap.cpp:

(JSC::Heap::copyBackingStores):

  • heap/Heap.h:
  • heap/HeapInlines.h:

(JSC::Heap::unregisterWeakGCMap):
(JSC::Heap::getNextBlocksToCopy): Deleted.

Source/WTF:

Extract the load balancing algorithm used by the GC's copy phase into a reusable template.
The GC copy phase now uses this.

  • WTF.vcxproj/WTF.vcxproj:
  • WTF.vcxproj/WTF.vcxproj.filters:
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/ParallelVectorIterator.h: Added.

(WTF::ParallelVectorIterator::ParallelVectorIterator):
(WTF::ParallelVectorIterator::iterate):

7:05 AM Changeset in webkit [190309] by youenn.fablet@crf.canon.fr
  • 6 edits
    1 add in trunk/Source/WebCore

Build WebCore JS Builtins according the ENABLE flags
https://bugs.webkit.org/show_bug.cgi?id=149624

Reviewed by Csaba Osztrogonác.

Created WebCoreJSBuiltins.cpp to include all JSXXBuiltins.cpp files with the right #ifdef.
Added WebCoreJSBuiltins.cpp to CMake, win and mac build systems.

No change in behavior.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/WebCoreJSBuiltins.cpp: Added.
5:32 AM Changeset in webkit [190308] by jfernandez@igalia.com
  • 9 edits in trunk

[CSS Grid Layout] Flex tracks sizing alg must handle 0fr values
https://bugs.webkit.org/show_bug.cgi?id=148944

Reviewed by Darin Adler.

Source/WebCore:

We don't allow 0 as flexible size value, which is not following current
specs; it just states that it must be a positive value. This patch
adds such change in the parser but some additional logic must be added
as well to handle 0 values during the flex tracks sizing algorithm.

The old algorithm didn't take 0 values into account, so there is the risk
of division by zero. Additionally, it was not handling fraction values
in the best way. The last versions of the spec changed this algorithm in
order to handle fraction values so that they don't cause exponential
grow of tracks using values bigger than 1.

This patch implements also such new algorithm, so we can deal not only
with 0 values, but managing fraction values properly.

No new tests, just some additional test cases and some of them rebaselined.

  • rendering/RenderGrid.cpp:

(WebCore::normalizedFlexFraction):
(WebCore::RenderGrid::computeUsedBreadthOfGridTracks):
(WebCore::RenderGrid::computeFlexFactorUnitSize): Added.
(WebCore::RenderGrid::findFlexFactorUnitSize): Added.
(WebCore::RenderGrid::GridTrackForNormalization): Deleted.
(WebCore::RenderGrid::computeNormalizedFractionBreadth): Deleted.

  • rendering/RenderGrid.h:

LayoutTests:

Allow 0 as flex factor value and implement the new flex track sizing algorithm.

  • fast/css-grid-layout/flex-and-minmax-content-resolution-rows.html: Updated some cases.
  • fast/css-grid-layout/flex-content-resolution-columns-expected.txt:
  • fast/css-grid-layout/flex-content-resolution-columns.html: Added some new cases.
  • fast/css-grid-layout/flex-content-resolution-rows-expected.txt:
  • fast/css-grid-layout/flex-content-resolution-rows.html: Added some new cases.
3:23 AM Changeset in webkit [190307] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Fix the broken !ENABLE(STREAM_API) build
https://bugs.webkit.org/show_bug.cgi?id=149525

Reviewed by Darin Adler.

  • bindings/js/WebCoreJSClientData.h: Revert r190225.
1:38 AM Changeset in webkit [190306] by Carlos Garcia Campos
  • 17 edits in trunk

printing does not use minimum page zoom factor
https://bugs.webkit.org/show_bug.cgi?id=108507

Reviewed by Darin Adler.

Source/WebCore:

  • page/PrintContext.cpp:

(WebCore::PrintContext::beginAndComputePageRectsWithPageSize):
Helper function to share common code from numberOfPages() and
spoolAllPagesWithBoundaries().
(WebCore::PrintContext::numberOfPages): Use beginAndComputePageRectsWithPageSize().
(WebCore::PrintContext::spoolAllPagesWithBoundaries): Use
beginAndComputePageRectsWithPageSize() and don't flip the Y axis
for non Cocoa platforms.

  • page/PrintContext.h:

Source/WebKit/mac:

Pass a the frame as a reference instead of using pointers.

  • Misc/WebCoreStatistics.mm:

(-[WebFrame numberOfPagesWithPageWidth:pageHeight:]):
(-[WebFrame printToCGContext:pageWidth:pageHeight:]):

Source/WebKit2:

Add kWKSnapshotOptionsPrinting flag to indicate the snapshot
should be generated in printing mode.

  • Shared/API/c/WKImage.h:
  • Shared/API/c/WKSharedAPICast.h:

(WebKit::toSnapshotOptions):

  • Shared/ImageOptions.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::numberOfPages): Pass the frame as a
reference instead of a pointer.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::scaledSnapshotWithOptions): In case of printing,
calculate the bitmap height based on the number of pages.
(WebKit::WebPage::snapshotAtSize): In case of printing, use
PrintContext::spoolAllPagesWithBoundaries() and return.

Tools:

WebKitTestRunner always takes the snapshots from the UI process
(expect for IOS), so in the case of printing, the layout in the
web view is not the expected one. When printing, we need to take
the snapshot in the web process and ensure it's rendered with a
PrintContext.

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::dump): When dumping pixels, pass
kWKSnapshotOptionsPrinting option to
WKBundlePageCreateSnapshotWithOptions() when printing.

LayoutTests:

Unskip printing reftests that should pass now.

  • platform/gtk/TestExpectations:
  • platform/mac-wk2/TestExpectations:
1:01 AM Changeset in webkit [190305] by youenn.fablet@crf.canon.fr
  • 10 edits in trunk/Source

Add support for WebIDL JSBuiltin attributes
https://bugs.webkit.org/show_bug.cgi?id=149554

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • runtime/Lookup.cpp:

(JSC::reifyStaticAccessor): Adding support for creating attribute getter from JS builtin functions.

  • runtime/Lookup.h:

(JSC::HashTableValue::builtinAccessorGetterGenerator):
(JSC::HashTableValue::builtinAccessorSetterGenerator):
(JSC::reifyStaticProperties): Ensuring that builtin attributes are not treated as Builtin functions.

Source/WebCore:

Covered by bindings tests.

  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipAttribute): Disabled GObject binding generation of JSBuiltin attribute.

  • bindings/scripts/CodeGeneratorJS.pm:

(GetAttributeGetterName): Handling of Builtin function to retrieve BuiltinGenerator.
(GetAttributeSetterName): Ditto.
(GenerateAttributesHashTable): Set JSBuiltin attributes as "Accessor | Builtin".
(GenerateImplementation): Skip implementation for JSBuiltin attributes

  • bindings/scripts/test/JS/JSTestObj.cpp: Adding binding test for JSBuiltin attributes.
  • bindings/scripts/test/ObjC/DOMTestObj.h:
  • bindings/scripts/test/ObjC/DOMTestObj.mm:

(-[DOMTestObj jsBuiltinAttribute]):
(-[DOMTestObj setJsBuiltinAttribute:]):
(-[DOMTestObj jsBuiltinReadOnlyAttribute]):

  • bindings/scripts/test/TestObj.idl: Ditto.
Note: See TracTimeline for information about the timeline view.