Timeline



Oct 17, 2015:

5:25 PM Changeset in webkit [191254] by mark.lam@apple.com
  • 2 edits in trunk/Source/WTF

Add CPU(X86) to the supported MASM_PROBE CPUs. This was accidentally left out in r191197.

Not reviewed.

  • wtf/Platform.h:
5:00 PM Changeset in webkit [191253] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebKit/mac

Build fix after r191250

Unreviewed.

  • WebView/WebView.mm:

(+[WebView initialize]):

4:13 PM Changeset in webkit [191252] by hyatt@apple.com
  • 15 edits
    16 adds in trunk

Implement the CSS4 'revert' keyword.
https://bugs.webkit.org/show_bug.cgi?id=149702

Reviewed by Simon Fraser.

Source/WebCore:

Added new tests in fast/css and fast/css/variables.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:

Add CSSRevertValue to the project and makefiles.

  • css/CSSParser.cpp:

(WebCore::parseKeywordValue):
Make sure to handle "revert" in the keyword parsing path (along with inherit/initial/unset).

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseCustomPropertyDeclaration):
At the parser level, "revert" is just like inherit/initial/unset and gets its own special
singleton value, CSSRevertValue.

  • css/CSSRevertValue.cpp: Added.

(WebCore::CSSRevertValue::customCSSText):

  • css/CSSRevertValue.h: Added.

(WebCore::CSSRevertValue::create):
(WebCore::CSSRevertValue::equals):
(WebCore::CSSRevertValue::CSSRevertValue):
This value is identical to the inherit/initial/unset values, i.e., its own special value
that can be used to indicate a revert when doing style resolution.

  • css/CSSValue.cpp:

(WebCore::CSSValue::cssValueType):
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):

  • css/CSSValue.h:

(WebCore::CSSValue::isInheritedValue):
(WebCore::CSSValue::isInitialValue):
(WebCore::CSSValue::isUnsetValue):
(WebCore::CSSValue::isRevertValue):
Add the RevertClass to CSSValue and make sure it is handled in all the appropriate methods.

  • css/CSSValueKeywords.in:

Add the "revert" keyword to the list of allowed CSS keywords.

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::CSSValuePool):

  • css/CSSValuePool.h:

(WebCore::CSSValuePool::createRevertValue):
Add support for a CSSRevertValue singleton, just like inherit/unset/initial.

  • css/FontLoader.cpp:

(WebCore::FontLoader::resolveFontStyle):
Add "unset" and "revert" as special keywords to be ignored. This code seems to be turned off,
but patching it anyway.

  • css/SelectorChecker.h:

Add a MatchDefault value of 0 to the LinkMatchMask. This enables it to be used as an index
to the correct value in Property (in the style resolution code).

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::State::initForStyleResolve):
Delete any lingering old CascadedProperty rollbacks for UA/user rules.

(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyMatchedProperties):
Pass along the MatchResult as an additional parameter, since we need it to lazily compute
the cascade rollbacks if the "revert" keyword is encountered.

(WebCore::StyleResolver::cascadedPropertiesForRollback):
This method will lazily create and return a new CascadedProperties pointer that is cached
in the StyleResolver's state. This will contain only UA rules (for user reverts) and UA/user
rules (for author reverts). These will only be computed at most once for a given element
when doing a reversion, and they will be computed lazily, i.e., only if a revert is
requested.

(WebCore::StyleResolver::applyProperty):
Pass along the LinkMatchMask and the MatchResult to applyProperty. This way we know specifically
which link type we were computing if we have to revert (so that we roll back and look at the
same index in the reverted version). The MatchResult is passed along because it is needed
to build the CascadedProperties rollbacks.

The basic idea is that if a revert is encountered, the level that the rule came from is
checked. If it is UA level, just treat as "unset." If it is author or user level, get
the correct CascadedProperties rollback and repeat the applyProperty using the property
found in the rollback. If the property is not present in the cascade rollback, then the
revert becomes an unset.

(WebCore::StyleResolver::CascadedProperties::hasCustomProperty):
(WebCore::StyleResolver::CascadedProperties::customProperty):
Helpers used by applyProperty to check on custom properties, since they can revert too
just like a regular property can.

(WebCore::StyleResolver::CascadedProperties::setPropertyInternal):
(WebCore::StyleResolver::CascadedProperties::set):
(WebCore::StyleResolver::CascadedProperties::setDeferred):
Passing along the CascadeLevel (UA, User, Author) so that it can be stored in the Property.
This way when we do property application, we always know where the rule came from so
that the reversion can be handled properly.

(WebCore::StyleResolver::CascadedProperties::addStyleProperties):
(WebCore::cascadeLevelForIndex):
(WebCore::StyleResolver::CascadedProperties::addMatches):
When style properties are added, also figure out the CascadeLevel and pass it along to be
stored in the Property. We use the MatchResult's ranges to know where a property comes from.

(WebCore::StyleResolver::CascadedProperties::applyDeferredProperties):
(WebCore::StyleResolver::CascadedProperties::Property::apply):
(WebCore::StyleResolver::applyCascadedProperties):
Pass along the MatchResult so we know how to build the rollback.

  • css/StyleResolver.h:

(WebCore::StyleResolver::State::cascadeLevel):
(WebCore::StyleResolver::State::setCascadeLevel):
(WebCore::StyleResolver::State::authorRollback):
(WebCore::StyleResolver::State::userRollback):
(WebCore::StyleResolver::State::setAuthorRollback):
(WebCore::StyleResolver::State::setUserRollback):
(WebCore::StyleResolver::state):
(WebCore::StyleResolver::cascadeLevel):
(WebCore::StyleResolver::setCascadeLevel):
Move CascadedProperties into the header. Add CascadeLevel to Property. Add the level and
rollbacks to the resolver's state.

LayoutTests:

  • fast/css/all-keyword-revert-expected.html: Added.
  • fast/css/all-keyword-revert.html: Added.
  • fast/css/revert-color-expected.html: Added.
  • fast/css/revert-color.html: Added.
  • fast/css/revert-margins-expected.html: Added.
  • fast/css/revert-margins.html: Added.
  • fast/css/variables/all-keyword-revert-expected.html: Added.
  • fast/css/variables/all-keyword-revert.html: Added.
  • fast/css/variables/revert-inheritance-expected.html: Added.
  • fast/css/variables/revert-inheritance.html: Added.
  • fast/css/variables/revert-no-inheritance-expected.html: Added.
  • fast/css/variables/revert-no-inheritance.html: Added.
  • fast/css/variables/revert-variable-reference-expected.html: Added.
  • fast/css/variables/revert-variable-reference.html: Added.
3:40 PM Changeset in webkit [191251] by mmaxfield@apple.com
  • 5 edits
    2 adds in trunk

Delete FontPlatformData::allowsLigatures()
https://bugs.webkit.org/show_bug.cgi?id=150286

Reviewed by Dan Bernstein.

Source/WebCore:

This function is only used to force ligatures on for complex fonts (where "complex"
means "does not support the letter 'a'"). However, ligatures are turned on for all
fonts by default, which means that this function is unnecessary.

Required ligatures, such as those which make these complex scripts legible, are always
enabled, no matter what.

Test: fast/text/required-ligatures.html

  • platform/graphics/FontPlatformData.h:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:

(WebCore::FontPlatformData::allowsLigatures): Deleted.

  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::Font::getCFStringAttributes):

LayoutTests:

Make sure it's impossible to turn off required ligatures with CSS.

  • fast/text/required-ligatures-expected.html: Added.
  • fast/text/required-ligatures.html: Added.
3:31 PM Changeset in webkit [191250] by mmaxfield@apple.com
  • 10 edits in trunk/Source

Stop honoring the user default "WebKitKerningAndLigaturesEnabledByDefault"
https://bugs.webkit.org/show_bug.cgi?id=150287

Reviewed by Simon Fraser.

Source/WebCore:

This user default is currently on by default. Therefore, by setting the user default,
users can only disable kerning / ligatures (rather than enable it).

There are a few reasons why we should stop honoring it:

  1. In the brave new world of font-feature-settings and font-variant-ligatures, there

are many different kinds of ligatures which may be enabled at will. The simplistic
statement of "turn on ligatures" no longer has any meaning.

  1. If a user wants to disable kerning / ligatures, he/she can do it with a user

stylesheet.

  1. The default isn't able to be tested with DumpRenderTree or WebKitTestRunner.
  1. I have never heard of anyone actually using this user default.
  • platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::setDefaultKerning): Deleted.
(WebCore::FontCascade::setDefaultLigatures): Deleted.

  • platform/graphics/FontCascade.h:

(WebCore::FontCascade::advancedTextRenderingMode):

Source/WebKit/mac:

  • WebView/WebView.mm:

(+[WebView initialize]): Deleted.

Source/WebKit2:

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters): Deleted.
(WebKit::WebProcessCreationParameters::encode): Deleted.
(WebKit::WebProcessCreationParameters::decode): Deleted.

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::registerUserDefaultsIfNeeded): Deleted.
(WebKit::WebProcessPool::platformInitializeWebProcess): Deleted.

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess): Deleted.

2:32 PM Changeset in webkit [191249] by mitz@apple.com
  • 5 edits
    2 adds in trunk/Source

[Cocoa] Stop using WKAXRegisterRemoteApp
https://bugs.webkit.org/show_bug.cgi?id=150283

Reviewed by Alexey Proskuryakov.

Source/WebCore:

  • platform/spi/ios/GraphicsServicesSPI.h: Added declaration of GSSystemRootDirectory.

Source/WebKit2:

  • Platform/spi/mac: Added.
  • Platform/spi/mac/AppKitSPI.h: Added. Includes declaration of +[NSAccessibilityRemoteUIElement setRemoteUIApp:].
  • WebKit2.xcodeproj/project.pbxproj: Added reference to new header. Also changed the path of the Platform/spi/Cocoa group to the corresponding path in the source tree.
  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::registerWithAccessibility): Added.
(WebKit::WebProcess::platformInitializeProcess): Use new registerWithAccessibility instead

of WKAXRegisterRemoteApp.

1:27 PM Changeset in webkit [191248] by fpizlo@apple.com
  • 9 edits
    1 add in trunk/Source/JavaScriptCore

Fix some generational heap growth pathologies
https://bugs.webkit.org/show_bug.cgi?id=150270

Reviewed by Andreas Kling.

When doing generational copying, we would pretend that the size of old space was increased
just by the amount of bytes we copied. In reality, it would be increased by the number of
bytes used by the copied blocks we created. This is a larger number, and in some simple
pathological programs, the difference can be huge.

Fixing this bug was relatively easy, and the only really meaningful change here is in
Heap::updateAllocationLimits(). But to convince myself that the change was valid, I had to
add some debugging code and I had to refactor some stuff so that it made more sense.

This change does obviate the need for m_totalBytesCopied, because we no longer use it in
release builds to decide how much heap we are using at the end of collection. But I added a
FIXME about how we could restore our use of m_totalBytesCopied. So, I kept the logic, for
now. The FIXME references https://bugs.webkit.org/show_bug.cgi?id=150268.

Relanding with build fix.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/CopiedBlock.cpp: Added.

(JSC::CopiedBlock::createNoZeroFill):
(JSC::CopiedBlock::destroy):
(JSC::CopiedBlock::create):
(JSC::CopiedBlock::zeroFillWilderness):
(JSC::CopiedBlock::CopiedBlock):

  • heap/CopiedBlock.h:

(JSC::CopiedBlock::didSurviveGC):
(JSC::CopiedBlock::createNoZeroFill): Deleted.
(JSC::CopiedBlock::destroy): Deleted.
(JSC::CopiedBlock::create): Deleted.
(JSC::CopiedBlock::zeroFillWilderness): Deleted.
(JSC::CopiedBlock::CopiedBlock): Deleted.

  • heap/CopiedSpaceInlines.h:

(JSC::CopiedSpace::startedCopying):

  • heap/Heap.cpp:

(JSC::Heap::updateObjectCounts):
(JSC::Heap::resetVisitors):
(JSC::Heap::capacity):
(JSC::Heap::protectedGlobalObjectCount):
(JSC::Heap::collectImpl):
(JSC::Heap::willStartCollection):
(JSC::Heap::updateAllocationLimits):
(JSC::Heap::didFinishCollection):
(JSC::Heap::sizeAfterCollect): Deleted.

  • heap/Heap.h:
  • heap/HeapInlines.h:

(JSC::Heap::shouldCollect):
(JSC::Heap::isBusy):
(JSC::Heap::collectIfNecessaryOrDefer):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::create):
(JSC::MarkedBlock::destroy):

12:38 PM Changeset in webkit [191247] by Chris Dumez
  • 25 edits
    4 adds in trunk

td and th should use HTMLTableDataCellElement and HTMLTableHeaderCellElement interfaces
https://bugs.webkit.org/show_bug.cgi?id=148859
<rdar://problem/22588664>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

  • web-platform-tests/html/dom/interfaces-expected.txt:
  • web-platform-tests/html/semantics/interfaces-expected.txt:

Source/WebCore:

td and th should use HTMLTableDataCellElement and HTMLTableHeaderCellElement interfaces
as per the latest HTML specification:
https://html.spec.whatwg.org/multipage/tables.html#htmltabledatacellelement
https://html.spec.whatwg.org/multipage/tables.html#htmltableheadercellelement

This patch aligns our behavior with the specification and IE. Firefox and Chrome do not
seem to expose HTMLTableDataCellElement / HTMLTableHeaderCellElement at this time.

The compatibility risk is low, given that the API stays the same and those new
interfaces inherit the pre-existing HTMLTableCellElement interface.

No new tests, already covered by existing tests.

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:
  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLTableCellElement.cpp:

(WebCore::HTMLTableCellElement::HTMLTableCellElement):
(WebCore::HTMLTableCellElement::colSpan): Deleted.

  • html/HTMLTableCellElement.h:
  • html/HTMLTableCellElement.idl:
  • html/HTMLTableDataCellElement.h: Added.
  • html/HTMLTableDataCellElement.idl: Added.
  • html/HTMLTableHeaderCellElement.h: Added.
  • html/HTMLTableHeaderCellElement.idl: Added.
  • html/HTMLTableRowElement.cpp:

(WebCore::HTMLTableRowElement::insertCell):

  • html/HTMLTagNames.in:

LayoutTests:

Rebaseline existing tests now that new HTMLTableDataCellElement / HTMLTableHeaderCellElement
types are exposed.

  • fast/dom/wrapper-classes-expected.txt:
  • fast/dom/wrapper-classes.html:
  • js/dom/global-constructors-attributes-expected.txt:
  • platform/efl/js/dom/global-constructors-attributes-expected.txt:
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/win/js/dom/global-constructors-attributes-expected.txt:
12:14 PM Changeset in webkit [191246] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

RenderBlockFlow::xPositionForFloatIncludingMargin/yPositionForFloatIncludingMargin/flipFloatForWritingModeForChild
should all take FloatingObject reference.
https://bugs.webkit.org/show_bug.cgi?id=150267

Reviewed by Simon Fraser.

No change in behaviour.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::addOverflowFromFloats):
(WebCore::RenderBlockFlow::paintFloats):
(WebCore::RenderBlockFlow::clipOutFloatingObjects):
(WebCore::RenderBlockFlow::addOverhangingFloats):
(WebCore::RenderBlockFlow::flipFloatForWritingModeForChild):
(WebCore::RenderBlockFlow::hitTestFloats):
(WebCore::RenderBlockFlow::adjustForBorderFit):

  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::xPositionForFloatIncludingMargin):
(WebCore::RenderBlockFlow::yPositionForFloatIncludingMargin):

11:49 AM Changeset in webkit [191245] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Sort the project file.

  • WebCore.xcodeproj/project.pbxproj:
11:42 AM Changeset in webkit [191244] by commit-queue@webkit.org
  • 9 edits
    1 delete in trunk/Source/JavaScriptCore

Unreviewed, rolling out r191240.
https://bugs.webkit.org/show_bug.cgi?id=150281

Broke 32-bit builds (Requested by smfr on #webkit).

Reverted changeset:

"Fix some generational heap growth pathologies"
https://bugs.webkit.org/show_bug.cgi?id=150270
http://trac.webkit.org/changeset/191240

11:34 AM Changeset in webkit [191243] by Simon Fraser
  • 44 edits
    2 adds in trunk/Source

Enhance TextStream for logging, remove subclasses, log more things
https://bugs.webkit.org/show_bug.cgi?id=150269

Reviewed by Zalan Bujtas.

Remove the various TextStream subclasses that only existed to support indenting,
and output additional types. Add output for more WebCore and WebKit2 types, and
just use TextStream everywhere.

TextStream is enhance to support grouping (open paren and intent), with a
stack-based class to open/end a group.

Remove some SVG-specific duplicate output functions.

Outdent namespace contents of GraphicsTypes.h.
Source/WebCore:

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ViewportArguments.cpp:

(WebCore::operator<<):

  • dom/ViewportArguments.h:
  • page/ViewportConfiguration.cpp:

(WebCore::operator<<):
(WebCore::ViewportConfiguration::description):
(WebCore::ViewportConfigurationTextStream::ViewportConfigurationTextStream): Deleted.
(WebCore::ViewportConfigurationTextStream::increaseIndent): Deleted.
(WebCore::ViewportConfigurationTextStream::decreaseIndent): Deleted.
(WebCore::dumpProperty): Deleted.
(WebCore::ViewportConfigurationTextStream::writeIndent): Deleted.
(WebCore::ViewportConfigurationTextStream::operator<<): Deleted.

  • page/ViewportConfiguration.h:
  • page/scrolling/ScrollingConstraints.cpp:

(WebCore::operator<<):

  • page/scrolling/ScrollingConstraints.h:
  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::operator<<):

  • page/scrolling/ScrollingCoordinator.h:
  • platform/animation/TimingFunction.cpp: Added.

(WebCore::operator<<):

  • platform/animation/TimingFunction.h:
  • platform/graphics/Color.cpp:

(WebCore::operator<<):

  • platform/graphics/Color.h:
  • platform/graphics/FloatPoint3D.cpp:

(WebCore::operator<<):

  • platform/graphics/FloatPoint3D.h:
  • platform/graphics/FloatRoundedRect.cpp:

(WebCore::operator<<):

  • platform/graphics/FloatRoundedRect.h:
  • platform/graphics/GraphicsLayer.cpp:

(WebCore::operator<<):

  • platform/graphics/GraphicsLayer.h:
  • platform/graphics/GraphicsTypes.cpp:

(WebCore::operator<<):

  • platform/graphics/GraphicsTypes.h:
  • platform/graphics/ca/PlatformCAAnimation.cpp: Added.

(WebCore::operator<<):

  • platform/graphics/ca/PlatformCAAnimation.h:
  • platform/graphics/ca/PlatformCALayer.cpp:

(WebCore::operator<<):

  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/filters/FilterOperation.cpp:

(WebCore::operator<<):

  • platform/graphics/filters/FilterOperation.h:
  • platform/graphics/filters/FilterOperations.cpp:

(WebCore::operator<<):

  • platform/graphics/filters/FilterOperations.h:
  • platform/graphics/filters/PointLightSource.cpp:

(WebCore::operator<<): Deleted.

  • platform/graphics/filters/SpotLightSource.cpp:

(WebCore::operator<<): Deleted.

  • platform/graphics/transforms/AffineTransform.cpp:

(WebCore::operator<<):

  • platform/graphics/transforms/AffineTransform.h:
  • platform/graphics/transforms/TransformationMatrix.cpp:

(WebCore::operator<<):

  • platform/graphics/transforms/TransformationMatrix.h:
  • platform/text/TextStream.cpp:

(WebCore::TextStream::startGroup):
(WebCore::TextStream::endGroup):
(WebCore::TextStream::nextLine):
(WebCore::TextStream::writeIndent):

  • platform/text/TextStream.h:

(WebCore::TextStream::operator<<):
(WebCore::TextStream::dumpProperty):
(WebCore::TextStream::increaseIndent):
(WebCore::TextStream::decreaseIndent):
(WebCore::TextStream::GroupScope::GroupScope):
(WebCore::TextStream::GroupScope::~GroupScope):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::operator<<): Deleted.

  • rendering/svg/SVGRenderTreeAsText.h:

Source/WebKit2:

  • Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(WebKit::dump):
(WebKit::recursiveDumpNodes):
(WebKit::RemoteScrollingCoordinatorTransaction::description):
(WebKit::RemoteScrollingTreeTextStream::RemoteScrollingTreeTextStream): Deleted.
(WebKit::RemoteScrollingTreeTextStream::increaseIndent): Deleted.
(WebKit::RemoteScrollingTreeTextStream::decreaseIndent): Deleted.
(WebKit::RemoteScrollingTreeTextStream::writeIndent): Deleted.
(WebKit::dumpProperty): Deleted.
(WebKit::RemoteScrollingTreeTextStream::operator<<): Deleted.
(WebKit::RemoteScrollingTreeTextStream::dump): Deleted.
(WebKit::RemoteScrollingTreeTextStream::recursiveDumpNodes): Deleted.

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::operator<<):
(WebKit::dumpChangedLayers):
(WebKit::RemoteLayerTreeTransaction::description):
(WebKit::RemoteLayerTreeTextStream::RemoteLayerTreeTextStream): Deleted.
(WebKit::RemoteLayerTreeTextStream::increaseIndent): Deleted.
(WebKit::RemoteLayerTreeTextStream::decreaseIndent): Deleted.
(WebKit::dumpProperty): Deleted.
(WebKit::RemoteLayerTreeTextStream::operator<<): Deleted.
(WebKit::RemoteLayerTreeTextStream::writeIndent): Deleted.

  • WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:
  • WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:

(WebKit::operator<<):

11:04 AM Changeset in webkit [191242] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[Win] Fix the Windows build.
https://bugs.webkit.org/show_bug.cgi?id=150278

Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-10-17
Reviewed by Brent Fulgham.

10:52 AM Changeset in webkit [191241] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Fixed typos from r191224.

Not reviewed.

  • jit/JITSubGenerator.h:

(JSC::JITSubGenerator::generateFastPath):

10:26 AM Changeset in webkit [191240] by fpizlo@apple.com
  • 9 edits
    1 add in trunk/Source/JavaScriptCore

Fix some generational heap growth pathologies
https://bugs.webkit.org/show_bug.cgi?id=150270

Reviewed by Andreas Kling.

When doing generational copying, we would pretend that the size of old space was increased
just by the amount of bytes we copied. In reality, it would be increased by the number of
bytes used by the copied blocks we created. This is a larger number, and in some simple
pathological programs, the difference can be huge.

Fixing this bug was relatively easy, and the only really meaningful change here is in
Heap::updateAllocationLimits(). But to convince myself that the change was valid, I had to
add some debugging code and I had to refactor some stuff so that it made more sense.

This change does obviate the need for m_totalBytesCopied, because we no longer use it in
release builds to decide how much heap we are using at the end of collection. But I added a
FIXME about how we could restore our use of m_totalBytesCopied. So, I kept the logic, for
now. The FIXME references https://bugs.webkit.org/show_bug.cgi?id=150268.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • heap/CopiedBlock.cpp: Added.

(JSC::CopiedBlock::createNoZeroFill):
(JSC::CopiedBlock::destroy):
(JSC::CopiedBlock::create):
(JSC::CopiedBlock::zeroFillWilderness):
(JSC::CopiedBlock::CopiedBlock):

  • heap/CopiedBlock.h:

(JSC::CopiedBlock::didSurviveGC):
(JSC::CopiedBlock::createNoZeroFill): Deleted.
(JSC::CopiedBlock::destroy): Deleted.
(JSC::CopiedBlock::create): Deleted.
(JSC::CopiedBlock::zeroFillWilderness): Deleted.
(JSC::CopiedBlock::CopiedBlock): Deleted.

  • heap/CopiedSpaceInlines.h:

(JSC::CopiedSpace::startedCopying):

  • heap/Heap.cpp:

(JSC::Heap::updateObjectCounts):
(JSC::Heap::resetVisitors):
(JSC::Heap::capacity):
(JSC::Heap::protectedGlobalObjectCount):
(JSC::Heap::collectImpl):
(JSC::Heap::willStartCollection):
(JSC::Heap::updateAllocationLimits):
(JSC::Heap::didFinishCollection):
(JSC::Heap::sizeAfterCollect): Deleted.

  • heap/Heap.h:
  • heap/HeapInlines.h:

(JSC::Heap::shouldCollect):
(JSC::Heap::isBusy):
(JSC::Heap::collectIfNecessaryOrDefer):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::create):
(JSC::MarkedBlock::destroy):

1:23 AM Changeset in webkit [191239] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebKit2

URTBF after r191194 to fix EFL build.
https://bugs.webkit.org/show_bug.cgi?id=150272

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-10-17
Reviewed by Csaba Osztrogonác.

  • UIProcess/efl/WebContextMenuProxyEfl.cpp:

(WebKit::WebContextMenuProxyEfl::showContextMenu):

  • UIProcess/efl/WebContextMenuProxyEfl.h:
12:10 AM Changeset in webkit [191238] by youenn.fablet@crf.canon.fr
  • 2 edits in trunk/Source/WebCore

Finalize bug 149952 patch
https://bugs.webkit.org/show_bug.cgi?id=150238

Reviewed by Darin Adler.

No change in behavior.

  • bindings/js/JSDOMConstructor.h:

(WebCore::JSDOMConstructor<JSClass>::finishCreation): Marked as inline.
(WebCore::JSDOMConstructor<JSClass>::getConstructData): Marked as inline.

Oct 16, 2015:

10:20 PM Changeset in webkit [191237] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Remove [ Debug ] qualifiers from expectations for some imported Blink test,
as they sometimes fail in release too.

  • platform/mac-wk2/TestExpectations:
9:48 PM Changeset in webkit [191236] by akling@apple.com
  • 2 edits in trunk/Tools

[EFL, AppleWin] WTF.ConcatenateCharacterArrayAndEmptyString API test failed
<https://webkit.org/b/150153>

Unreviewed.

Just use simple arrays of LChar and UChar for this test instead of creating String
objects and then getting the characters8()/characters16() from them, since that
doesn't guarantee null-termination (the bug.)

  • TestWebKitAPI/Tests/WTF/StringOperators.cpp:

(TestWebKitAPI::TEST):
(TestWebKitAPI::build): Deleted.

9:37 PM Changeset in webkit [191235] by Yusuke Suzuki
  • 6 edits
    1 add in trunk

[ES6] Implement String.prototype.normalize
https://bugs.webkit.org/show_bug.cgi?id=150094

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This patch implements String.prototype.normalize leveraging ICU.
It can provide the feature applying {NFC, NFD, NFKC, NFKD} normalization to a given string.

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):
(JSC::normalize):
(JSC::stringProtoFuncNormalize):

  • tests/es6.yaml:
  • tests/stress/string-normalize.js: Added.

(unicode):
(shouldBe):
(shouldThrow):
(normalizeTest):

LayoutTests:

  • js/Object-getOwnPropertyNames-expected.txt:
  • js/script-tests/Object-getOwnPropertyNames.js:
8:36 PM Changeset in webkit [191234] by Alan Bujtas
  • 10 edits in trunk/Source/WebCore

RenderBlockFlow::*logical*ForFloat should take FloatingObject reference.
https://bugs.webkit.org/show_bug.cgi?id=150266

Reviewed by Simon Fraser.

No change in behaviour.

  • rendering/FloatingObjects.cpp:

(WebCore::FindNextFloatLogicalBottomAdapter::collectIfNeeded):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter<FloatingObject::FloatLeft>::updateOffsetIfNeeded):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter<FloatingObject::FloatRight>::updateOffsetIfNeeded):
(WebCore::ComputeFloatOffsetForFloatLayoutAdapter<FloatTypeValue>::heightRemaining):
(WebCore::ComputeFloatOffsetAdapter<FloatTypeValue>::collectIfNeeded):
(WebCore::ComputeFloatOffsetForLineLayoutAdapter<FloatingObject::FloatLeft>::updateOffsetIfNeeded):
(WebCore::ComputeFloatOffsetForLineLayoutAdapter<FloatingObject::FloatRight>::updateOffsetIfNeeded):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::rebuildFloatingObjectSetFromIntrudingFloats):
(WebCore::RenderBlockFlow::repaintOverhangingFloats):
(WebCore::RenderBlockFlow::insertFloatingObject):
(WebCore::RenderBlockFlow::removeFloatingObject):
(WebCore::RenderBlockFlow::removeFloatingObjectsBelow):
(WebCore::RenderBlockFlow::computeLogicalLocationForFloat):
(WebCore::RenderBlockFlow::positionNewFloats):
(WebCore::RenderBlockFlow::lowestFloatLogicalBottom):
(WebCore::RenderBlockFlow::lowestInitialLetterLogicalBottom):
(WebCore::RenderBlockFlow::addOverhangingFloats):
(WebCore::RenderBlockFlow::hasOverhangingFloat):
(WebCore::RenderBlockFlow::addIntrudingFloats):

  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::logicalTopForFloat):
(WebCore::RenderBlockFlow::logicalBottomForFloat):
(WebCore::RenderBlockFlow::logicalLeftForFloat):
(WebCore::RenderBlockFlow::logicalRightForFloat):
(WebCore::RenderBlockFlow::logicalWidthForFloat):
(WebCore::RenderBlockFlow::logicalHeightForFloat):
(WebCore::RenderBlockFlow::setLogicalTopForFloat):
(WebCore::RenderBlockFlow::setLogicalLeftForFloat):
(WebCore::RenderBlockFlow::setLogicalHeightForFloat):
(WebCore::RenderBlockFlow::setLogicalWidthForFloat):
(WebCore::RenderBlockFlow::logicalSizeForFloat): Deleted.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):
(WebCore::RenderBlockFlow::checkPaginationAndFloatsAtEndLine):
(WebCore::RenderBlockFlow::positionNewFloatOnLine):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::addOverflowFromChild):

  • rendering/RenderBox.h:

(WebCore::RenderBox::addOverflowFromChild):

  • rendering/line/BreakingContext.h:

(WebCore::BreakingContext::handleFloat):

  • rendering/line/LineWidth.cpp:

(WebCore::newFloatShrinksLine):
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

  • rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::computeDeltasForContainingBlockLine):

7:15 PM Changeset in webkit [191233] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Avoid to insert TAB before HTML element.
https://bugs.webkit.org/show_bug.cgi?id=149295
<rdar://problem/22746706>

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-16
Reviewed by Ryosuke Niwa.

Source/WebCore:

This is a merge of Blink r175047:
https://codereview.chromium.org/306583005

This patch avoids InsertTextCommand::insertTab before HTML element because
we can't set Text node as document element.

Test: editing/execCommand/insert-tab-to-html-element-crash.html

  • editing/InsertTextCommand.cpp:

(WebCore::InsertTextCommand::insertTab):

LayoutTests:

  • editing/execCommand/insert-tab-to-html-element-crash-expected.txt: Added.
  • editing/execCommand/insert-tab-to-html-element-crash.html: Added.
5:51 PM Changeset in webkit [191232] by matthew_hanson@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source

Versioning.

5:46 PM Changeset in webkit [191231] by matthew_hanson@apple.com
  • 5 edits in branches/safari-601-branch/Source

Versioning.

4:57 PM Changeset in webkit [191230] by ggaren@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

Update JavaScriptCore API docs
https://bugs.webkit.org/show_bug.cgi?id=150262

Reviewed by Mark Lam.

Apply some edits for clarity. These came out of a docs review.

  • API/JSContext.h:
  • API/JSExport.h:
  • API/JSManagedValue.h:
  • API/JSValue.h:
4:48 PM Changeset in webkit [191229] by commit-queue@webkit.org
  • 10 edits
    2 deletes in trunk

Unreviewed, rolling out r191204.
https://bugs.webkit.org/show_bug.cgi?id=150263

This change is causing existing tests to fail (Requested by
ryanhaddad on #webkit).

Reverted changeset:

"Computed style should work correctly with slotted elements
that have display:none"
https://bugs.webkit.org/show_bug.cgi?id=150237
http://trac.webkit.org/changeset/191204

4:47 PM Changeset in webkit [191228] by wenson_hsieh@apple.com
  • 10 edits
    1 copy
    1 add in trunk/Source/WebKit2

Add a WKWebView input delegate SPI
https://bugs.webkit.org/show_bug.cgi?id=149646

Reviewed by Dan Bernstein.

Renames the existing _WKFormDelegate to _WKInputDelegate and adds a new delegate SPI method
-[_WKInputDelegate _webView:focusShouldStartInputSession:] that allows clients to allow or
disallow showing up the keyboard. To make this decision, clients are given a
_WKFocusedElementInfo, which contains information about the focused element prior to the
keyboard showing up so the client will be able to override default assistance behavior.

While the information contained in a _WKFocusedElementInfo currently seems like overkill for
_webView:focusShouldStartInputSession, our intentions are to give WebKit clients control over more
details of how node assistance works, such as being able to use a custom editor for certain
types of nodes.

  • Shared/API/Cocoa/WebKitPrivate.h: Added new header _WKFocusedElementInfo.h.
  • UIProcess/API/Cocoa/WKWebView.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _inputDelegate]):
(-[WKWebView _formDelegate]):
(-[WKWebView _setInputDelegate:]):
(-[WKWebView _setFormDelegate:]):
(-[WKWebView initWithFrame:configuration:]): Deleted canAssistOnProgrammaticFocus flag.
(-[WKWebView canAssistOnProgrammaticFocus]): Ditto.
(-[WKWebView setCanAssistOnProgrammaticFocus:]): Ditto.

  • UIProcess/API/Cocoa/WKWebViewConfiguration.h:
  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration init]): Deleted.
(-[WKWebViewConfiguration _canAssistOnProgrammaticFocus]): Deleted canAssistOnProgrammaticFocus flag.
(-[WKWebViewConfiguration _setCanAssistOnProgrammaticFocus:]): Ditto.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/API/Cocoa/_WKFocusedElementInfo.h: Added.
  • UIProcess/API/Cocoa/_WKFormDelegate.h:
  • UIProcess/API/Cocoa/_WKInputDelegate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/_WKFormDelegate.h.
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKFocusedElementInfo initWithAssistedNodeInformation:isInteracting:]):
(-[WKFocusedElementInfo type]):
(-[WKFocusedElementInfo value]):
(-[WKFocusedElementInfo isUserInitiated]):
(-[WKContentView accessoryAutoFill]):
(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:userObject:]): If the input delegate responds to

shouldStartInputSession, consult it to see if we should bring up the keyboard; otherwise, use our default behavior.

  • WebKit2.xcodeproj/project.pbxproj:
4:46 PM Changeset in webkit [191227] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-601.1.46.42

New Tag.

4:45 PM Changeset in webkit [191226] by matthew_hanson@apple.com
  • 1 copy in tags/Safari-601.3.4

New Tag.

4:40 PM Changeset in webkit [191225] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Fix typo in TypeError messages in TypedArray.prototype.forEach/filter.

  • builtins/TypedArray.prototype.js:

(forEach):
(filter):

4:26 PM Changeset in webkit [191224] by mark.lam@apple.com
  • 16 edits
    1 add in trunk/Source/JavaScriptCore

Use JITSubGenerator to support UntypedUse operands for op_sub in the DFG.
https://bugs.webkit.org/show_bug.cgi?id=150038

Reviewed by Geoffrey Garen.

  • bytecode/SpeculatedType.h:

(JSC::isUntypedSpeculationForArithmetic): Added

  • Also fixed some comments.


  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGAbstractValue.cpp:

(JSC::DFG::AbstractValue::resultType):

  • dfg/DFGAbstractValue.h:
  • Added function to compute the ResultType of an operand from its SpeculatedType.
  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • Fix up ArithSub to speculate its operands to be numbers. But if an OSR exit due to a BadType was seen at this node, we'll fix it up to expect UntypedUse operands. This gives the generated code a change to run fast if it only receives numeric operands.
  • dfg/DFGNode.h:

(JSC::DFG::Node::shouldSpeculateUntypedForArithmetic):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • Add the C++ runtime function to implement op_sub when we really encounter the hard types in the operands.
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithSub):

  • Added support for UntypedUse operands using the JITSubGenerator.
  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::silentSpillAllRegisters):
(JSC::DFG::SpeculativeJIT::pickCanTrample):
(JSC::DFG::SpeculativeJIT::callOperation):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • Just refuse to FTL compile functions with UntypedUse op_sub operands for now.
  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::boxDouble):
(JSC::AssemblyHelpers::unboxDoubleNonDestructive):
(JSC::AssemblyHelpers::unboxDouble):
(JSC::AssemblyHelpers::boxBooleanPayload):

  • jit/JITArithmetic.cpp:

(JSC::JIT::emit_op_sub):

  • jit/JITSubGenerator.h:

(JSC::JITSubGenerator::generateFastPath):
(JSC::JITSubGenerator::endJumpList):

  • Added some asserts to document the contract that this generator expects in terms of its incoming registers.

Also fixed the generated code to not be destructive with regards to incoming
registers. The DFG expects this.

Also added an endJumpList so that we don't have to jump twice for the fast
path where both operands are ints.

  • parser/ResultType.h:

(JSC::ResultType::ResultType):

  • Make the internal Type bits and the constructor private. Clients should only create ResultType values using one of the provided factory methods.
  • tests/stress/op_sub.js: Added.

(o1.valueOf):
(stringify):
(generateScenarios):
(printScenarios):
(testCases.func):
(func):
(initializeTestCases):
(runTest):

  • test op_sub results by comparing one LLINT result against the output of multiple LLINT, and JIT runs. This test assume that we'll at least get the right result some of the time (if not all the time), and confirms that the various engines produce consistent results for all the various value pairs being tested.
4:21 PM Changeset in webkit [191223] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Disabled content blockers should not block any loads
https://bugs.webkit.org/show_bug.cgi?id=150261

Reviewed by Brady Eidson.

This fix was tested manually by reloading without content blockers
on websites with iframes and content blockers that block the contents of the iframes.

  • page/UserContentController.cpp:

(WebCore::UserContentController::removeAllUserContentExtensions):
(WebCore::contentExtensionsEnabled):
(WebCore::UserContentController::processContentExtensionRulesForLoad):
(WebCore::UserContentController::actionsForResourceLoad):
Check the DocumentLoader of the main frame when checking if content extensions are disabled,
because that is the DocumentLoader that has the flag from reloading without content blockers.

4:15 PM Changeset in webkit [191222] by beidson@apple.com
  • 3 edits in trunk/LayoutTests

Fix flakey test that was added for:
Modern IDB: Add versionchange events.
https://bugs.webkit.org/show_bug.cgi?id=150149

Test flakes because two events come in different orders.

The event order actually does not matter.
The test just needs to handle either order.

  • storage/indexeddb/modern/versionchange-event-expected.txt:
  • storage/indexeddb/modern/versionchange-event.html:
3:53 PM Changeset in webkit [191221] by fpizlo@apple.com
  • 12 edits
    3 adds in trunk/Source/JavaScriptCore

CopyBarrier must be avoided for slow TypedArrays
https://bugs.webkit.org/show_bug.cgi?id=150217
rdar://problem/23128791

Reviewed by Michael Saboff.

Change how we access array buffer views so that we don't fire the barrier slow path, and
don't mask off the spaceBits, if the view is not FastTypedArray. That's because in that case
m_vector could be misaligned and so have meaningful non-space data in the spaceBits. Also in
that case, m_vector does not point into copied space.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::loadVectorWithBarrier):
(JSC::FTL::DFG::LowerDFGToLLVM::copyBarrier):
(JSC::FTL::DFG::LowerDFGToLLVM::isInToSpace):
(JSC::FTL::DFG::LowerDFGToLLVM::loadButterflyReadOnly):
(JSC::FTL::DFG::LowerDFGToLLVM::loadVectorReadOnly):
(JSC::FTL::DFG::LowerDFGToLLVM::removeSpaceBits):
(JSC::FTL::DFG::LowerDFGToLLVM::isFastTypedArray):
(JSC::FTL::DFG::LowerDFGToLLVM::baseIndex):

  • heap/CopyBarrier.h:

(JSC::CopyBarrierBase::getWithoutBarrier):
(JSC::CopyBarrierBase::getPredicated):
(JSC::CopyBarrierBase::get):
(JSC::CopyBarrierBase::copyState):
(JSC::CopyBarrier::get):
(JSC::CopyBarrier::getPredicated):
(JSC::CopyBarrier::set):

  • heap/Heap.cpp:

(JSC::Heap::copyBarrier):

  • jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::branchIfNotType):
(JSC::AssemblyHelpers::branchIfFastTypedArray):
(JSC::AssemblyHelpers::branchIfNotFastTypedArray):
(JSC::AssemblyHelpers::loadTypedArrayVector):
(JSC::AssemblyHelpers::purifyNaN):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::branchStructure):
(JSC::AssemblyHelpers::branchIfToSpace):
(JSC::AssemblyHelpers::branchIfNotToSpace):
(JSC::AssemblyHelpers::removeSpaceBits):
(JSC::AssemblyHelpers::addressForByteOffset):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitIntTypedArrayGetByVal):
(JSC::JIT::emitFloatTypedArrayGetByVal):
(JSC::JIT::emitIntTypedArrayPutByVal):
(JSC::JIT::emitFloatTypedArrayPutByVal):

  • runtime/JSArrayBufferView.h:

(JSC::JSArrayBufferView::vector):
(JSC::JSArrayBufferView::length):

  • runtime/JSArrayBufferViewInlines.h:

(JSC::JSArrayBufferView::byteOffset):

  • runtime/JSGenericTypedArrayView.h:

(JSC::JSGenericTypedArrayView::typedVector):

  • runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::copyBackingStore):
(JSC::JSGenericTypedArrayView<Adaptor>::slowDownAndWasteMemory):

  • tests/stress/misaligned-int8-view-byte-offset.js: Added.
  • tests/stress/misaligned-int8-view-read.js: Added.
  • tests/stress/misaligned-int8-view-write.js: Added.
3:51 PM Changeset in webkit [191220] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix for 191215.

  • jit/IntrinsicEmitter.cpp:
3:44 PM Changeset in webkit [191219] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

Test fix after r191211

Tell the 'Plug-ins.html' test to allow enumeration of all plugins.

  • fast/dom/Window/Plug-ins.html:
3:41 PM Changeset in webkit [191218] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Removing non-existent test from test expectations file
https://bugs.webkit.org/show_bug.cgi?id=150250

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-16
Reviewed by Simon Fraser.

  • platform/mac/TestExpectations:
3:37 PM Changeset in webkit [191217] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

[Win] Update initial-letter test expectation for Win port.

Unreviewed gardening.

  • platform/win/TestExpectations:
3:31 PM Changeset in webkit [191216] by Simon Fraser
  • 26 edits
    2 copies in trunk/Source

Make TextStream the canonical way to log classes in WebCore
https://bugs.webkit.org/show_bug.cgi?id=150256

Reviewed by Sam Weinig.

We vacillated between PrintStream and TextStream as being the canonical way
to stringify WebCore data structures. This patch solidifies TextStream
as the solution, since it has convenient stream syntax, and is what we
use for render tree dumps.

Remove TextStream member functions that output non-simple structs
(sizes, points and rects), replacing them with free operator<< functions
in the .cpp file for the relevant class. Formatting is currently consistent
with RenderTreeAsText output, to avoid breaking tests.

Remove custom FloatRect outputting in SVG and RemoteLayerTreeTransaction.

Source/WebCore:

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/FloatPoint.cpp:

(WebCore::operator<<):
(WebCore::FloatPoint::dump): Deleted.

  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatRect.cpp:

(WebCore::operator<<):
(WebCore::FloatRect::dump): Deleted.

  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatSize.cpp:

(WebCore::FloatSize::FloatSize):
(WebCore::operator<<):
(WebCore::FloatSize::dump): Deleted.

  • platform/graphics/FloatSize.h:
  • platform/graphics/IntPoint.cpp:

(WebCore::operator<<):
(WebCore::IntPoint::dump): Deleted.

  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.cpp:

(WebCore::operator<<):
(WebCore::IntRect::dump): Deleted.

  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.cpp:

(WebCore::operator<<):
(WebCore::IntSize::dump): Deleted.

  • platform/graphics/IntSize.h:
  • platform/graphics/LayoutPoint.cpp: Copied from Source/WebCore/platform/graphics/IntPoint.cpp.

(WebCore::operator<<):

  • platform/graphics/LayoutPoint.h:
  • platform/graphics/LayoutRect.cpp:

(WebCore::operator<<):

  • platform/graphics/LayoutRect.h:
  • platform/graphics/LayoutSize.cpp: Copied from Source/WebCore/platform/graphics/IntPoint.cpp.

(WebCore::operator<<):

  • platform/graphics/LayoutSize.h:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::MediaSampleAVFObjC::dump):

  • platform/text/TextStream.cpp:

(WebCore::TextStream::operator<<):

  • platform/text/TextStream.h:
  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::operator<<): Deleted.

Source/WebKit2:

  • Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:

(WebKit::RemoteScrollingTreeTextStream::operator<<): Deleted.

  • Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTextStream::operator<<): Deleted.

3:18 PM Changeset in webkit [191215] by keith_miller@apple.com
  • 35 edits
    5 adds in trunk

Add Intrinsic Getters and use them to fix performance on the getters of TypedArray properties.
https://bugs.webkit.org/show_bug.cgi?id=149687

Patch by Keith Miller <keith@Keiths-MacBook-Pro-5.local> on 2015-10-16
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Add the ability to create intrinsic getters in both the inline cache and the DFG/FTL. When the
getter fetched by a GetById has an intrinsic we know about we add a new intrinsic access case.
Once we get to the DFG, we observe that the access case was an intrinsic and add an appropriate
GetByIdVariant. We then parse the intrinsic into an appropriate DFG node.

The first intrinsics are the new TypedArray prototype getters length, byteLength, and byteOffset.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • bytecode/GetByIdStatus.cpp:

(JSC::GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback):
(JSC::GetByIdStatus::computeFor):

  • bytecode/GetByIdVariant.cpp:

(JSC::GetByIdVariant::GetByIdVariant):
(JSC::GetByIdVariant::operator=):
(JSC::GetByIdVariant::canMergeIntrinsicStructures):
(JSC::GetByIdVariant::attemptToMerge):
(JSC::GetByIdVariant::dumpInContext):

  • bytecode/GetByIdVariant.h:

(JSC::GetByIdVariant::intrinsicFunction):
(JSC::GetByIdVariant::intrinsic):
(JSC::GetByIdVariant::callLinkStatus): Deleted.

  • bytecode/PolymorphicAccess.cpp:

(JSC::AccessGenerationState::addWatchpoint):
(JSC::AccessGenerationState::restoreScratch):
(JSC::AccessGenerationState::succeed):
(JSC::AccessGenerationState::calculateLiveRegistersForCallAndExceptionHandling):
(JSC::AccessGenerationState::preserveLiveRegistersToStackForCall):
(JSC::AccessGenerationState::restoreLiveRegistersFromStackForCall):
(JSC::AccessGenerationState::restoreLiveRegistersFromStackForCallWithThrownException):
(JSC::AccessGenerationState::callSiteIndexForExceptionHandlingOrOriginal):
(JSC::AccessGenerationState::originalExceptionHandler):
(JSC::AccessGenerationState::originalCallSiteIndex):
(JSC::AccessCase::getIntrinsic):
(JSC::AccessCase::clone):
(JSC::AccessCase::visitWeak):
(JSC::AccessCase::generate):
(WTF::printInternal):
(JSC::AccessCase::AccessCase): Deleted.
(JSC::AccessCase::get): Deleted.
(JSC::AccessCase::replace): Deleted.
(JSC::AccessCase::transition): Deleted.

  • bytecode/PolymorphicAccess.h:

(JSC::AccessCase::isGet):
(JSC::AccessCase::isPut):
(JSC::AccessCase::isIn):
(JSC::AccessCase::intrinsicFunction):
(JSC::AccessCase::intrinsic):
(JSC::AccessGenerationState::AccessGenerationState):
(JSC::AccessGenerationState::liveRegistersForCall):
(JSC::AccessGenerationState::callSiteIndexForExceptionHandling):
(JSC::AccessGenerationState::numberOfStackBytesUsedForRegisterPreservation):
(JSC::AccessGenerationState::needsToRestoreRegistersIfException):
(JSC::AccessGenerationState::liveRegistersToPreserveAtExceptionHandlingCallSite):

  • bytecode/PutByIdVariant.h:

(JSC::PutByIdVariant::intrinsic):

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGArrayMode.cpp:

(JSC::DFG::ArrayMode::alreadyChecked):
(JSC::DFG::arrayTypeToString):
(JSC::DFG::toTypedArrayType):
(JSC::DFG::refineTypedArrayType):
(JSC::DFG::permitsBoundsCheckLowering):

  • dfg/DFGArrayMode.h:

(JSC::DFG::ArrayMode::supportsLength):
(JSC::DFG::ArrayMode::isSomeTypedArrayView):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::attemptToInlineCall):
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
(JSC::DFG::ByteCodeParser::handleIntrinsicGetter):
(JSC::DFG::ByteCodeParser::load):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::presenceLike): Deleted.
(JSC::DFG::ByteCodeParser::store): Deleted.

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::convertToGetArrayLength): Deleted.
(JSC::DFG::FixupPhase::prependGetArrayLength): Deleted.
(JSC::DFG::FixupPhase::fixupChecksInBlock): Deleted.

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::tryGetFoldableView):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::checkArray):
(JSC::DFG::SpeculativeJIT::compileGetArrayLength):

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileGetArrayLength):

  • jit/IntrinsicEmitter.cpp: Added.

(JSC::AccessCase::canEmitIntrinsicGetter):
(JSC::AccessCase::emitIntrinsicGetter):

  • jit/Repatch.cpp:

(JSC::tryCacheGetByID):

  • runtime/Intrinsic.h:
  • runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::put):
(JSC::JSArrayBufferView::defineOwnProperty):
(JSC::JSArrayBufferView::deleteProperty):
(JSC::JSArrayBufferView::getOwnNonIndexPropertyNames):
(JSC::JSArrayBufferView::getOwnPropertySlot): Deleted.
(JSC::JSArrayBufferView::finalize): Deleted.

  • runtime/JSDataView.cpp:

(JSC::JSDataView::getOwnPropertySlot):
(JSC::JSDataView::put):
(JSC::JSDataView::defineOwnProperty):
(JSC::JSDataView::deleteProperty):
(JSC::JSDataView::getOwnNonIndexPropertyNames):

  • runtime/JSDataView.h:
  • runtime/JSFunction.h:
  • runtime/JSFunctionInlines.h:

(JSC::JSFunction::intrinsic):

  • runtime/JSGenericTypedArrayView.h:
  • runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlot):
(JSC::JSGenericTypedArrayView<Adaptor>::defineOwnProperty):
(JSC::JSGenericTypedArrayView<Adaptor>::deleteProperty):
(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlotByIndex): Deleted.
(JSC::JSGenericTypedArrayView<Adaptor>::visitChildren): Deleted.

  • runtime/JSObject.cpp:

(JSC::JSObject::putDirectNativeIntrinsicGetter):

  • runtime/JSObject.h:
  • runtime/JSTypedArrayViewPrototype.cpp:

(JSC::JSTypedArrayViewPrototype::finishCreation):

  • tests/stress/typedarray-add-property-to-base-object.js: Added.

(body.foo):
(body):

  • tests/stress/typedarray-bad-getter.js: Added.

(body.foo):
(body.get Bar):
(body):

  • tests/stress/typedarray-getter-on-self.js: Added.

(body.foo):
(body.bar):
(body.baz):
(body.get for):
(body):

  • tests/stress/typedarray-intrinsic-getters-change-prototype.js: Added.

(body.foo):
(body.bar):
(body.baz):
(body):

LayoutTests:

Fix test since typedarrays no longer have length as a own property.

  • js/dom/getOwnPropertyDescriptor-expected.txt:
  • js/resources/getOwnPropertyDescriptor.js:
3:09 PM Changeset in webkit [191214] by timothy_horton@apple.com
  • 3 edits in trunk/Tools

WebKit2.AutoLayoutIntegration API test is failing on some of the bots
https://bugs.webkit.org/show_bug.cgi?id=150255

Reviewed by Simon Fraser.

  • Scripts/run-api-tests:

(runTest):

  • TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm:

(-[AutoLayoutWKWebView load:withWidth:expectingContentSize:]):
(-[AutoLayoutWKWebView layoutAtMinimumWidth:andExpectContentSizeChange:]):
(-[AutoLayoutWKWebView load:expectingContentSize:]): Deleted.
(-[AutoLayoutWKWebView expectContentSizeChange:]): Deleted.
Don't set the layout size until after the load finishes and we're waiting
for the reply, so that there is no race between the new size coming in
and us waiting for it.

2:58 PM Changeset in webkit [191213] by andersca@apple.com
  • 5 edits in trunk

WebEditingDelegate should be a formal protocol
https://bugs.webkit.org/show_bug.cgi?id=150254
<rdar://problem/23149847>

Reviewed by Dan Bernstein.

Source/WebKit/mac:

  • WebView/WebEditingDelegate.h:

Move all the delegate methods inside the protocol declaration. Also make the header self-contained.

  • WebView/WebView.h:

Change the type of the editing delegate and make it assign.

Tools:

  • DumpRenderTree/mac/EditingDelegate.h:

Conform to the WebEditingDelegate protocol.

2:40 PM Changeset in webkit [191212] by keith_miller@apple.com
  • 4 edits
    1 add in trunk/Source/JavaScriptCore

Fix some issues with TypedArrays
https://bugs.webkit.org/show_bug.cgi?id=150216

Reviewed by Geoffrey Garen.

This fixes a couple of issues:
1) The DFG had a separate case for creating new typedarrays in the dfg when the first argument is an object.

Since the code for creating a Typedarray in the dfg is almost the same as the code in Baseline/LLInt
the two cases have been merged.

2) If the length property on an object was unset then the construction could crash.
3) The TypedArray.prototype.set function and the TypedArray constructor should not call Get? for the

length of the source object when the source object is a TypedArray.

4) The conditions that were used to decide if the iterator could be skipped were incorrect.

Instead of checking for have a bad time we should have checked the Indexing type did not allow for
indexed accessors.

  • dfg/DFGOperations.cpp:
  • runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::constructGenericTypedArrayViewWithArguments):
(JSC::constructGenericTypedArrayView):
(JSC::constructGenericTypedArrayViewWithFirstArgument): Deleted.

2:25 PM Changeset in webkit [191211] by Brent Fulgham
  • 11 edits in trunk

Hide all plugin names except Flash, Java, and QuickTime
https://bugs.webkit.org/show_bug.cgi?id=149014

Reviewed by Darin Adler.

Source/WebCore:

Revise plugin interface so that sites cannot iterate over all plugins to obtain
a list of installed plugins for fingerprinting purposes. Sites need to ask for
specific plugins by name, rather than iterating and comparing to avoid making
this information accessible for fingerprinting purposes.

  • plugins/DOMPluginArray.cpp:

(WebCore::DOMPluginArray::length): Only return length of the plugins we are
allowing to be seen.
(WebCore::DOMPluginArray::item): Only iterate through the plugins we are
allowing to be seen.

  • plugins/PluginData.cpp:

(WebCore::PluginData::publiclyVisiblePlugins): Added.

  • plugins/PluginData.h:

LayoutTests:

Update tests to notify internals that all plugins should be shown, not
just the publicly available ones.

  • plugins/plugin-javascript-access.html:
  • plugins/script-tests/navigator-mimeTypes-length.js:
2:10 PM Changeset in webkit [191210] by beidson@apple.com
  • 9 edits in trunk/Source/WebCore

"enum class" some IDB enums.
https://bugs.webkit.org/show_bug.cgi?id=150246

Reviewed by Alex Christensen.

No new tests (No change in behavior).

  • Modules/indexeddb/IDBKeyPath.cpp:

(WebCore::IDBIsValidKeyPath):
(WebCore::IDBParseKeyPath):
(WebCore::IDBKeyPath::IDBKeyPath):
(WebCore::IDBKeyPath::isValid):
(WebCore::IDBKeyPath::operator==):
(WebCore::IDBKeyPath::encode):
(WebCore::IDBKeyPath::decode):

  • Modules/indexeddb/IDBKeyPath.h:

(WebCore::IDBKeyPath::IDBKeyPath):
(WebCore::IDBKeyPath::type):
(WebCore::IDBKeyPath::array):
(WebCore::IDBKeyPath::string):
(WebCore::IDBKeyPath::isNull):
(WebCore::IDBKeyPath::encode):
(WebCore::IDBKeyPath::decode):

  • Modules/indexeddb/IndexedDB.h:
  • Modules/indexeddb/legacy/LegacyDatabase.cpp:

(WebCore::LegacyDatabase::createObjectStore):

  • Modules/indexeddb/legacy/LegacyObjectStore.cpp:

(WebCore::LegacyObjectStore::createIndex):

  • bindings/js/IDBBindingUtilities.cpp:

(WebCore::internalCreateIDBKeyFromScriptValueAndKeyPath):
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::canInjectIDBKeyIntoScriptValue):

  • bindings/js/JSIDBAnyCustom.cpp:

(WebCore::toJS):

  • inspector/InspectorIndexedDBAgent.cpp:
2:10 PM Changeset in webkit [191209] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601-branch/Source/WebInspectorUI

Follow-up fix for r190246. rdar://problem/22939682

Unreviewed.

In merging r190246, I neglected to change two consts to vars, as per Joe's merge instructions.

  • UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype._scriptsCleared):
const -> var

2:08 PM Changeset in webkit [191208] by andersca@apple.com
  • 2 edits in trunk/Source/WebCore

Add indexeddb/shared to the include paths.

  • WebCore.vcxproj/WebCoreIncludeCommon.props:
2:06 PM Changeset in webkit [191207] by andersca@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fix Windows build.

2:06 PM Changeset in webkit [191206] by msaboff@apple.com
  • 11 edits in trunk

REGRESSION (r191175): Still crashing when clicking back button on netflix.com
https://bugs.webkit.org/show_bug.cgi?id=150251

Rubber stamped by Filip Pizlo.

Turning off Tail Calls and disabling tests until the crash is fixed.

Source/JavaScriptCore:

  • runtime/Options.h:
  • tests/es6.yaml:
  • tests/stress/dfg-tail-calls.js:

(nonInlinedTailCall.callee):

  • tests/stress/mutual-tail-call-no-stack-overflow.js:

(shouldThrow):

  • tests/stress/tail-call-in-inline-cache.js:

(tail):

  • tests/stress/tail-call-no-stack-overflow.js:

(shouldThrow):

  • tests/stress/tail-call-recognize.js:

(callerMustBeRun):

  • tests/stress/tail-call-varargs-no-stack-overflow.js:

(shouldThrow):

LayoutTests:

  • js/caller-property-expected.txt:
2:02 PM Changeset in webkit [191205] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Remove some dead menu code
https://bugs.webkit.org/show_bug.cgi?id=150247

Reviewed by Andreas Kling.

  • Shared/WebContextMenuItemData.cpp:

(WebKit::WebContextMenuItemData::WebContextMenuItemData):
(WebKit::WebContextMenuItemData::encode): Deleted.

  • Shared/WebContextMenuItemData.h:

(WebKit::WebContextMenuItemData::selectionHandler): Deleted.

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::nsMenuItem):

1:50 PM Changeset in webkit [191204] by Antti Koivisto
  • 10 edits
    2 adds in trunk

Computed style should work correctly with slotted elements that have display:none
https://bugs.webkit.org/show_bug.cgi?id=150237

Reviewed by Andreas Kling.

Source/WebCore:

If an element has display:none we don't normally retain or even compute its style (as it is not rendered).
If getComputedStyle is invoked for such element we resolve the style (along with any ancestors) and cache
it separately to rare data. This path needs to work with slotted elements in shadow trees.

This patch also make computedStyle() iterative rather than recursive.

Test: fast/shadow-dom/computed-style-display-none.html

  • dom/Document.cpp:

(WebCore::Document::styleForElementIgnoringPendingStylesheets):

Pass in the parent style instead of invoking computedStyle() recursively.

  • dom/Document.h:
  • dom/Element.cpp:

(WebCore::beforeOrAfterPseudoElement):
(WebCore::Element::existingComputedStyle):
(WebCore::Element::resolveComputedStyle):

Iterative resolve function that uses composed tree iterator.

(WebCore::Element::computedStyle):

Factor into helpers.

  • dom/Element.h:
  • dom/Node.cpp:

(WebCore::Node::computedStyle):

Use the composed tree iterator.

LayoutTests:

  • editing/style/apply-style-atomic-expected.txt:

Rebase.

  • fast/css/getComputedStyle/getComputedStyle-with-pseudo-element-expected.txt:
  • fast/css/getComputedStyle/getComputedStyle-with-pseudo-element.html:

We now also compute style of display:none pseudo elements correctly.
This is a progression and matches other browsers.

  • fast/shadow-dom/computed-style-display-none-expected.txt: Added.
  • fast/shadow-dom/computed-style-display-none.html: Added.
1:46 PM Changeset in webkit [191203] by Alan Bujtas
  • 3 edits in trunk/LayoutTests

[iOS] Update initial-letter results for iOS port.

Unreviewed gardening.

  • platform/ios-simulator/fast/css-generated-content/initial-letter-basic-expected.txt:
  • platform/ios-simulator/fast/css-generated-content/initial-letter-sunken-expected.txt:
1:36 PM Changeset in webkit [191202] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Add MacroAssembler::callProbe() for supporting lambda JIT probes.
https://bugs.webkit.org/show_bug.cgi?id=150186

Reviewed by Geoffrey Garen.

With callProbe(), we can now make probes that are lambdas. For example, we can
now conveniently add probes like so:

When you know exactly which register you want to inspect:
jit.callProbe([] (MacroAssembler::ProbeContext* context) {

intptr_t value = reinterpret_cast<intptr_t>(context->cpu.eax);
dataLogF("eax %p\n", context->cpu.eax); Inspect the register.
ASSERT(value > 10);
Add test code for debugging.

});

When you want to inspect whichever register the JIT allocated:
auto reg = op1.gpr();
jit.callProbe([reg] (MacroAssembler::ProbeContext* context) {

intptr_t value = reinterpret_cast<intptr_t>(context->gpr(reg));
dataLogF("reg %s: %ld\n", context->gprName(reg), value);
ASSERT(value > 10);

});

callProbe() is only meant to be used for debugging sessions. It is not
appropriate to use it in permanent code (even for debug builds).
This is because:

  1. The probe mechanism saves and restores all (and I really mean "all") registers, and is inherently slow.
  2. callProbe() currently works by allocating (via new) a std::function to guarantee that it is persisted for the duration that the JIT generated code is live. We don't currently delete it ever i.e. it leaks a bit of memory each time the JIT generates code that contains such a lambda probe.

These limitations are acceptable for a debugging session (assuming you're not
debugging a memory leak), but not for deployment code. If there's a need, we can
plug that leak in another patch.

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::CPUState::fpr):

  • Removed an unnecessary empty line.

(JSC::AbstractMacroAssembler::ProbeContext::gpr):
(JSC::AbstractMacroAssembler::ProbeContext::fpr):
(JSC::AbstractMacroAssembler::ProbeContext::gprName):
(JSC::AbstractMacroAssembler::ProbeContext::fprName):

  • Added some convenience functions that will make using the probe mechanism easier.
  • assembler/MacroAssembler.cpp:

(JSC::StdFunctionData::StdFunctionData):
(JSC::stdFunctionCallback):
(JSC::MacroAssembler::callProbe):

  • assembler/MacroAssembler.h:
1:29 PM Changeset in webkit [191201] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

ASSERT in imported/blink/fast/block/float/overhanging-float-crashes-when-sibling-becomes-formatting-context.html
https://bugs.webkit.org/show_bug.cgi?id=150249

Reviewed by Myles Maxfield.

Covered by existing tests.

  • css/CSSValue.cpp:

(WebCore::CSSValue::equals):
Make sure the "unset" value has an equals implementation.

1:27 PM Changeset in webkit [191200] by akling@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove unused StructureRareData::m_cachedGenericPropertyNameEnumerator.
<https://webkit.org/b/150244>

Reviewed by Geoffrey Garen.

Remove an unused field from StructureRareData.

  • runtime/StructureRareData.cpp:

(JSC::StructureRareData::visitChildren): Deleted.

  • runtime/StructureRareData.h:
1:05 PM Changeset in webkit [191199] by matthew_hanson@apple.com
  • 12 edits
    2 adds in branches/safari-601.1.46-branch

Merge r190752. rdar://problem/23110932

1:04 PM Changeset in webkit [191198] by beidson@apple.com
  • 8 edits
    2 adds in trunk

Source/WebCore:
Modern IDB: Handle versionchange events.
https://bugs.webkit.org/show_bug.cgi?id=150149

Reviewed by Alex Christensen.

Test: storage/indexeddb/modern/versionchange-event.html

  • IDBVersionChangeEvents are now dispatched to open connections when a version upgrade request comes in.
  • Once all of those open connections have closed, the version upgrade request is handled.
  • Modules/indexeddb/client/IDBConnectionToServer.cpp:

(WebCore::IDBClient::IDBConnectionToServer::fireVersionChangeEvent):
(WebCore::IDBClient::IDBConnectionToServer::registerDatabaseConnection):
(WebCore::IDBClient::IDBConnectionToServer::unregisterDatabaseConnection):

  • Modules/indexeddb/client/IDBConnectionToServer.h:
  • Modules/indexeddb/client/IDBDatabaseImpl.cpp:

(WebCore::IDBClient::IDBDatabase::fireVersionChangeEvent):

  • Modules/indexeddb/client/IDBDatabaseImpl.h:
  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::UniqueIDBDatabase):
(WebCore::IDBServer::UniqueIDBDatabase::connectionClosedFromClient):
(WebCore::IDBServer::UniqueIDBDatabase::invokeTransactionScheduler):
(WebCore::IDBServer::UniqueIDBDatabase::transactionSchedulingTimerFired):

  • Modules/indexeddb/server/UniqueIDBDatabase.h:

LayoutTests:
Modern IDB: Add versionchange events.
https://bugs.webkit.org/show_bug.cgi?id=150149

Reviewed by Alex Christensen.

  • storage/indexeddb/modern/versionchange-event-expected.txt: Added.
  • storage/indexeddb/modern/versionchange-event.html: Added.
1:02 PM Changeset in webkit [191197] by mark.lam@apple.com
  • 2 edits in trunk/Source/WTF

Always enable MASM_PROBE for debug builds.
https://bugs.webkit.org/show_bug.cgi?id=150190

Reviewed by Geoffrey Garen.

  • wtf/Platform.h:
12:59 PM Changeset in webkit [191196] by ggaren@apple.com
  • 6 edits in trunk/Source/bmalloc

bmalloc: per-thread cache data structure should be smaller
https://bugs.webkit.org/show_bug.cgi?id=150218

Reviewed by Andreas Kling.

Reduce the number of entries in the range cache because it's really
big, and the bigness only helps in cases of serious fragmentation, and
it only saves us a little bit of lock acquisition time.

  • bmalloc/Allocator.cpp:

(bmalloc::Allocator::scavenge):
(bmalloc::Allocator::refillAllocatorSlowCase):
(bmalloc::Allocator::refillAllocator):
(bmalloc::Allocator::allocateLarge):
(bmalloc::Allocator::allocateSlowCase):
(bmalloc::Allocator::allocateBumpRangeSlowCase): Deleted.
(bmalloc::Allocator::allocateBumpRange): Deleted.

  • bmalloc/Allocator.h: Pass through the empty allocator and the range

cache when refilling, and refill both. Otherwise, we always immediately
pop the last item in the range cache, wasting that slot of capacity.

  • bmalloc/Heap.cpp:

(bmalloc::Heap::allocateSmallBumpRanges):
(bmalloc::Heap::allocateMediumBumpRanges): Account for the fact that
the range cache is no longer big enough to guarantee that it can hold
all the ranges in a page.

(bmalloc::Heap::refillSmallBumpRangeCache): Deleted.
(bmalloc::Heap::refillMediumBumpRangeCache): Deleted.

  • bmalloc/Heap.h: Move VMHeap to the end of the object because it

contains a lot of unused / wasted space, and we want to pack our data
together in memory.

  • bmalloc/Sizes.h: Make the range cache smaller.
12:53 PM Changeset in webkit [191195] by Alan Bujtas
  • 10 edits
    2 adds in trunk

First line box in paragraph using initial-letter overflows.
https://bugs.webkit.org/show_bug.cgi?id=147977
<rdar://problem/22901553>

Reviewed by David Hyatt.

When initial-letter float is present, we should shrink the first
line even if it's not intersected with the block's current height.
This is because of the sunken behaviour of initial-letter.

Source/WebCore:

Test: fast/css-generated-content/initial-letter-first-line-wrapping.html

  • rendering/RenderBlockFlow.h:
  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::positionNewFloatOnLine):

  • rendering/line/BreakingContext.h:

(WebCore::BreakingContext::handleFloat):

  • rendering/line/LineBreaker.cpp:

(WebCore::LineBreaker::skipLeadingWhitespace):

  • rendering/line/LineBreaker.h:

(WebCore::LineBreaker::positionNewFloatOnLine):

  • rendering/line/LineWidth.cpp:

(WebCore::newFloatShrinksLine):
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded):

  • rendering/line/LineWidth.h:

LayoutTests:

  • fast/css-generated-content/initial-letter-first-line-wrapping-expected.html: Added.
  • fast/css-generated-content/initial-letter-first-line-wrapping.html: Added.
  • platform/mac/fast/css-generated-content/initial-letter-basic-expected.txt: progression.
12:52 PM Changeset in webkit [191194] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Move more code to WebContextMenuProxyMac
https://bugs.webkit.org/show_bug.cgi?id=150240

Reviewed by Tim Horton.

  • UIProcess/WebContextMenuProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::internalShowContextMenu):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::contextMenuClient):

  • UIProcess/mac/WebContextMenuProxyMac.h:
  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::initializeShareMenuItem):
(WebKit::WebContextMenuProxyMac::showContextMenu):

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::platformInitializeShareMenuItem): Deleted.

12:47 PM Changeset in webkit [191193] by keith_miller@apple.com
  • 4 edits
    1 delete in trunk/Source/JavaScriptCore

Unreviewed, rolling out r191190.

Patch needs some design changes.

Reverted changeset:

"Fix some issues with TypedArrays"
https://bugs.webkit.org/show_bug.cgi?id=150216
http://trac.webkit.org/changeset/191190

12:26 PM Changeset in webkit [191192] by youenn.fablet@crf.canon.fr
  • 10 edits in trunk/LayoutTests

Update testharness.js to web-platform-tests version
https://bugs.webkit.org/show_bug.cgi?id=150234

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • resources/web-platform-tests-modules.json: updated testharness module version.
  • web-platform-tests/dom/interfaces-expected.txt: Rebased test expectation.
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_01-expected.txt: Ditto.
  • web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_02-expected.txt: Ditto.
  • web-platform-tests/dom/nodes/Node-isEqualNode-expected.txt: Ditto.
  • web-platform-tests/html/dom/interfaces-expected.txt: Ditto.
  • web-platform-tests/html/dom/interfaces.html: Removed a method from Window as this is timing out the test otherwise.

LayoutTests:

  • resources/testharness.js:

(WindowTestEnvironment):
(WindowTestEnvironment.prototype._dispatch):
(WindowTestEnvironment.prototype._forEach_windows):
(WindowTestEnvironment.prototype.on_tests_ready):
(WindowTestEnvironment.prototype.setup_messages):
(WindowTestEnvironment.prototype.next_default_test_name):
(WindowTestEnvironment.prototype.on_new_harness_properties):
(WindowTestEnvironment.prototype.add_on_loaded_callback):
(WindowTestEnvironment.prototype.test_timeout):
(WindowTestEnvironment.prototype.global_scope):
(WorkerTestEnvironment):
(WorkerTestEnvironment.prototype._dispatch):
(WorkerTestEnvironment.prototype._add_message_port):
(WorkerTestEnvironment.prototype.next_default_test_name):
(WorkerTestEnvironment.prototype.on_new_harness_properties):
(WorkerTestEnvironment.prototype.on_tests_ready):
(WorkerTestEnvironment.prototype.add_on_loaded_callback):
(WorkerTestEnvironment.prototype.test_timeout):
(WorkerTestEnvironment.prototype.global_scope):
(DedicatedWorkerTestEnvironment):
(DedicatedWorkerTestEnvironment.prototype.on_tests_ready):
(SharedWorkerTestEnvironment):
(SharedWorkerTestEnvironment.prototype.on_tests_ready):
(ServiceWorkerTestEnvironment):
(ServiceWorkerTestEnvironment.prototype.add_on_loaded_callback):
(create_test_environment):
(is_shared_worker):
(is_service_worker):
(test):
(async_test):
(promise_test):
(this.wait_for):
(EventWatcher):
(setup):
(step_timeout):
(format_value): Deleted.

12:10 PM Changeset in webkit [191191] by mark.lam@apple.com
  • 19 edits
    8 deletes in trunk/Source/JavaScriptCore

Move all the probe trampolines into their respective MacroAssembler files.
https://bugs.webkit.org/show_bug.cgi?id=150239

Reviewed by Saam Barati.

This patch does not introduce any behavior changes. It only moves the
ctiMasmProbeTrampoline implementations from the respective JITStubs<CPU>.h
files to the corresponding MacroAssembler<CPU>.cpp files.

I also had to make some minor changes to get the code to build after this move:

  1. Added #include <wtf/InlineASM.h> in the MacroAssembler<CPU>.cpp files because the ctiMasmProbeTrampoline is an inline assembly blob.
  2. In the moved code, convert MacroAssembler:: qualifiers to the CPU specific MacroAssembler equivalent. The referenced entities were always defined in the CPU specific MacroAssembler anyway, and indirectly referenced through the generic MacroAssembler.

With this, we can get rid of all the JITStubs<CPU>.cpp files. There is one
exception: JITStubsMSVC64.asm. However, that one is unrelated to the probe
mechanism. So, I'll leave it as is.

We can also remove JITStubs.cpp and JITStubs.h which are now empty except for
some stale unused code.

This patch has been build tested for x86, x86_64, armv7, and arm64.

(JSC::MacroAssemblerARM::probe):

  • assembler/MacroAssemblerARM64.cpp:

(JSC::arm64ProbeTrampoline):
(JSC::MacroAssemblerARM64::probe):

  • assembler/MacroAssemblerARMv7.cpp:

(JSC::MacroAssemblerARMv7::probe):

  • assembler/MacroAssemblerX86Common.cpp:
  • bytecode/CodeBlock.cpp:
  • ftl/FTLCompile.cpp:
  • ftl/FTLLink.cpp:
  • jit/JITArithmetic.cpp:
  • jit/JITArithmetic32_64.cpp:
  • jit/JITCode.h:
  • jit/JITExceptions.cpp:
  • jit/JITStubs.cpp: Removed.
  • jit/JITStubs.h: Removed.
  • jit/JITStubsARM.h: Removed.
  • jit/JITStubsARM64.h: Removed.
  • jit/JITStubsARMv7.h: Removed.
  • jit/JITStubsX86.h: Removed.
  • jit/JITStubsX86Common.h: Removed.
  • jit/JITStubsX86_64.h: Removed.
  • jit/JSInterfaceJIT.h:
  • llint/LLIntOffsetsExtractor.cpp:
  • runtime/CommonSlowPaths.cpp:
11:37 AM Changeset in webkit [191190] by keith_miller@apple.com
  • 4 edits
    1 add in trunk/Source/JavaScriptCore

Fix some issues with TypedArrays
https://bugs.webkit.org/show_bug.cgi?id=150216

Reviewed by Michael Saboff.

This fixes a couple of issues:
1) The DFG had a separate case for creating new typedarrays in the dfg when the first argument is an object.

Since the code for creating a Typedarray in the dfg is almost the same as the code in Baseline/LLInt
the two cases have been merged.

2) If the length property on an object was unset then the construction could crash.
3) The TypedArray.prototype.set function and the TypedArray constructor should not call Get? for the

length of the source object when the source object is a TypedArray.

4) The conditions that were used to decide if the iterator could be skipped were incorrect.

Instead of checking for have a bad time we should have checked the Indexing type did not allow for
indexed accessors.

  • dfg/DFGOperations.cpp:

(JSC::DFG::newTypedArrayWithOneArgument): Deleted.

  • runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::constructGenericTypedArrayViewFromIterator):
(JSC::constructGenericTypedArrayViewWithFirstArgument):
(JSC::constructGenericTypedArrayView):

  • runtime/JSGenericTypedArrayViewPrototypeFunctions.h:

(JSC::genericTypedArrayViewProtoFuncSet):

  • tests/stress/typedarray-construct-iterator.js: Added.

(iterator.return.next):
(iterator):
(body):

11:30 AM Changeset in webkit [191189] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed, skip imported/w3c/web-platform-tests/dom/interfaces.html on Debug builds.

This test is slow and sometimes times out.

11:24 AM Changeset in webkit [191188] by commit-queue@webkit.org
  • 7 edits in trunk

The value sanitization algorithm for input[type=url] should strip whitespaces
https://bugs.webkit.org/show_bug.cgi?id=148864
rdar://problem/22589358

Patch by Keith Rollin <Keith Rollin> on 2015-10-16
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Rebaseline two W3C HTML tests given changes in input[type=url].value
sanitization.

  • web-platform-tests/html/semantics/forms/the-input-element/type-change-state-expected.txt:
  • web-platform-tests/html/semantics/forms/the-input-element/url-expected.txt:

Source/WebCore:

Follow the sanitization algorithm specified in:
https://html.spec.whatwg.org/multipage/forms.html#url-state-(type=url)

Chrome also has the same issue with url.html. Firefox passes. All
three browsers have multiple issues with type-change-state.html, with
each browser having a different set of failures. Addressing this in
WebKit is another issue outside the scope of bz=148864. For now, I'm
updating that test to capture current WebKit behavior.

No new tests (covered by existing tests):

  • web-platform-tests/html/semantics/forms/the-input-element/type-change-state.html
  • web-platform-tests/html/semantics/forms/the-input-element/url.html
  • html/TextFieldInputType.h:
  • html/URLInputType.cpp:

(WebCore::URLInputType::sanitizeValue):

  • html/URLInputType.h:
11:20 AM Changeset in webkit [191187] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Add "unset" to CSS value autocompletion
https://bugs.webkit.org/show_bug.cgi?id=127616

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-16
Reviewed by Brian Burg.

  • UserInterface/Models/CSSCompletions.js:
  • UserInterface/Models/CSSKeywordCompletions.js:

(WebInspector.CSSKeywordCompletions.forProperty):
Treat "unset" similiar to "initial". Also, no need for "initial"
in an individual property's list. We always include it.

  • UserInterface/Views/VisualStyleDetailsPanel.js:

(WebInspector.VisualStyleDetailsPanel):
(WebInspector.VisualStyleDetailsPanel.prototype._populateDisplaySection):
(WebInspector.VisualStyleDetailsPanel.prototype._populateAlignmentSection):
Add "Unset" alongside "Initial".

11:01 AM Changeset in webkit [191186] by Antti Koivisto
  • 5 edits
    2 deletes in trunk/Source/WebCore

Remove NodeRenderingTraversal
https://bugs.webkit.org/show_bug.cgi?id=150226

Reviewed by Chris Dumez.

It has been reduced to an implementation detail of FocusController. Move the remaining
functions there as they have no general utility (and are wrong for focus navigation too).

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMAllInOne.cpp:
  • dom/NodeRenderingTraversal.cpp: Removed.
  • dom/NodeRenderingTraversal.h: Removed.
  • page/FocusController.cpp:

(WebCore::firstChildInScope):
(WebCore::lastChildInScope):
(WebCore::parentInScope):
(WebCore::nextInScope):
(WebCore::previousInScope):
(WebCore::FocusNavigationScope::FocusNavigationScope):
(WebCore::FocusNavigationScope::focusNavigationScopeOf):
(WebCore::FocusController::findElementWithExactTabIndex):
(WebCore::nextElementWithGreaterTabIndex):
(WebCore::previousElementWithLowerTabIndex):
(WebCore::FocusController::nextFocusableElement):
(WebCore::FocusController::previousFocusableElement):

10:56 AM Changeset in webkit [191185] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Fixing test expectations for css2.1/tables/table-anonymous-objects-045.xht on win
https://bugs.webkit.org/show_bug.cgi?id=150125

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-16
Reviewed by Zalan Bujtas.

  • platform/win/css2.1/tables/table-anonymous-objects-045-expected.txt:
10:44 AM Changeset in webkit [191184] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

Build fix. "all" keyword introduction exposed a typo bug in the grid-area property definition.

  • css/CSSPropertyNames.in:
10:30 AM Changeset in webkit [191183] by timothy_horton@apple.com
  • 10 edits
    1 add in trunk

Hook up autolayout intrinsic sizing for WKWebView
https://bugs.webkit.org/show_bug.cgi?id=150219
<rdar://problem/20016905>

Reviewed by Simon Fraser.

New API test: WebKit2.AutoLayoutIntegration.

  • page/FrameView.cpp:

(WebCore::FrameView::autoSizeIfEnabled):
When autosizing a document in which the body expands to the size of
the view (a feature of quirks mode), the first (width-determining)
autosizing will resize the view to the document height (which is at
least the body height), and the second time around, the height will
not decrease (because it was expanded to the size of the view).

Instead, the first time around, we should use the computed width,
but shrink the height back down to the minimum, and then expand
only as much as needed to fit the content.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView initWithFrame:configuration:]):
(-[WKWebView intrinsicContentSize]):
(-[WKWebView _setIntrinsicContentSize:]):
(-[WKWebView _minimumLayoutWidth]):
(-[WKWebView _setMinimumLayoutWidth:]):

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:

Add a simple SPI to specify the minimum width that a WKWebView will attempt
to lay out to, similar to WKView except just a width, not a size, and
with no option to force the height to the view size. Similar behavior can
be achieved by clients by setting custom autolayout constraints on the view.

  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::intrinsicContentSizeDidChange):
Forward intrinsic content size changes to the WKWebView, not its inner WKView,
if we have one.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
Only set the autosizing fixed minimum height if we're using that behavior;
otherwise, setting it to the view's height will end up accidentally
turning on that behavior (which involves an extra layout per resize!).

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/AutoLayoutIntegration.mm: Added.

(-[AutoLayoutNavigationDelegate webView:didFinishNavigation:]):
(-[AutoLayoutWKWebView load:expectingContentSize:]):
(-[AutoLayoutWKWebView expectContentSizeChange:]):
(-[AutoLayoutWKWebView invalidateIntrinsicContentSize]):
(TEST):
Add a variety of tests, including one which catches the bug that
the WebCore part of this patch fixes.

10:18 AM Changeset in webkit [191182] by beidson@apple.com
  • 21 edits in trunk

Modern IDB: Support IDBDatabase.close().
https://bugs.webkit.org/show_bug.cgi?id=150150

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (Covered by changes to storage/indexeddb/modern/opendatabase-versions.html).

  • Modules/indexeddb/client/IDBConnectionToServer.cpp:

(WebCore::IDBClient::IDBConnectionToServer::databaseConnectionClosed):

  • Modules/indexeddb/client/IDBConnectionToServer.h:
  • Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
  • Modules/indexeddb/client/IDBDatabaseImpl.cpp:

(WebCore::IDBClient::IDBDatabase::IDBDatabase):
(WebCore::IDBClient::IDBDatabase::~IDBDatabase):
(WebCore::IDBClient::IDBDatabase::close):
(WebCore::IDBClient::IDBDatabase::maybeCloseInServer):
(WebCore::IDBClient::IDBDatabase::commitTransaction):

  • Modules/indexeddb/client/IDBDatabaseImpl.h:

(WebCore::IDBClient::IDBDatabase::databaseConnectionIdentifier):

  • Modules/indexeddb/client/IDBRequestImpl.cpp:

(WebCore::IDBClient::IDBRequest::result):

  • Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::databaseConnectionClosed):

  • Modules/indexeddb/server/IDBServer.h:
  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::connectionClosedFromClient):
(WebCore::IDBServer::UniqueIDBDatabase::handleOpenDatabaseOperations): Deleted.

  • Modules/indexeddb/server/UniqueIDBDatabase.h:
  • Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:

(WebCore::IDBServer::UniqueIDBDatabaseConnection::UniqueIDBDatabaseConnection):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::~UniqueIDBDatabaseConnection):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::hasNonFinishedTransactions):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::connectionClosedFromClient):

  • Modules/indexeddb/server/UniqueIDBDatabaseConnection.h:
  • Modules/indexeddb/shared/InProcessIDBServer.cpp:

(WebCore::InProcessIDBServer::databaseConnectionClosed):

  • Modules/indexeddb/shared/InProcessIDBServer.h:

LayoutTests:

  • storage/indexeddb/modern/opendatabase-versions-expected.txt:
  • storage/indexeddb/modern/opendatabase-versions.html:
10:08 AM Changeset in webkit [191181] by andersca@apple.com
  • 9 edits in trunk/Source/WebKit2

Use the ShowContextMenu message for service menus as well
https://bugs.webkit.org/show_bug.cgi?id=150206

Reviewed by Tim Horton.

  • Shared/ContextMenuContextData.cpp:

(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::encode):
(WebKit::ContextMenuContextData::decode):

  • Shared/ContextMenuContextData.h:

(WebKit::ContextMenuContextData::type):
(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::isServicesMenu):
(WebKit::ContextMenuContextData::needsServicesMenu): Deleted.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showContextMenu):
(WebKit::WebPageProxy::internalShowContextMenu):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::populate):
(WebKit::WebContextMenuProxyMac::showContextMenu):

  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::showSelectionServiceMenu): Deleted.

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::handleSelectionServiceClick):

10:06 AM Changeset in webkit [191180] by Chris Dumez
  • 4 edits
    5 adds in trunk

HTMLPreloadScanner should preload iframes
https://bugs.webkit.org/show_bug.cgi?id=150097
<rdar://problem/23094475>

Reviewed by Antti Koivisto.

Source/WebCore:

HTMLPreloadScanner should preload iframes to decrease page load time.

Tests:

  • fast/preloader/frame-src.html
  • http/tests/loading/preload-no-store-frame-src.html
  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::tagIdFor):
(WebCore::TokenPreloadScanner::initiatorFor):
(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
(WebCore::TokenPreloadScanner::StartTagScanner::resourceType):
(WebCore::TokenPreloadScanner::StartTagScanner::setUrlToLoad): Deleted.
(WebCore::TokenPreloadScanner::StartTagScanner::charset): Deleted.

  • html/parser/HTMLPreloadScanner.h:

LayoutTests:

Add layout test to check that iframes are indeed preloaded.

  • fast/preloader/frame-src-expected.txt: Added.
  • fast/preloader/frame-src.html: Added.
  • fast/preloader/resources/testFrame.html: Added.
  • http/tests/loading/preload-no-store-frame-src-expected.txt: Added.
  • http/tests/loading/preload-no-store-frame-src.html: Added.
9:30 AM Changeset in webkit [191179] by Csaba Osztrogonác
  • 1 edit
    1 add in trunk/LayoutTests

Unreviewed fix after r191175.

  • js/regress-150220-expected.txt: Added.
9:12 AM Changeset in webkit [191178] by hyatt@apple.com
  • 7 edits
    10 adds in trunk

Implement the "all" CSS property.
https://bugs.webkit.org/show_bug.cgi?id=116966

Reviewed by Zalan Bujtas.

Source/WebCore:

Added new tests in fast/css.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):
Don't support "all" from computed style for now.

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
Make sure to bail after checking inherit/unset/initial for all, since you can't actually
accept longhand values in the shorthand declarations.

(WebCore::CSSParser::parseAnimationProperty):
"all" for animations is a special value and should not be confused with the property. It
animates everything and does not omit unicode-bidi/direction the way the "all" property does.

  • css/CSSPropertyNames.in:

Add the "all" property to the list and use a special keyword in the Longhands value, "all",
that makeprop.pl will look for. This way we don't have to dump every single CSS property
into the Longhands expression, since that would be nuts.

  • css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue):
Look for a common value across all properties supported by "all". That way you can get
back inherit/initial/unset from it.

  • css/makeprop.pl:

Make the perl script look for "all" in the longhand list, and if it sees it, put every
single CSS property into the list for the all shorthand.

LayoutTests:

Added tests for the "all property, including a variables test!

  • fast/css/all-keyword-direction-expected.html: Added.
  • fast/css/all-keyword-direction.html: Added.
  • fast/css/all-keyword-inherit-expected.html: Added.
  • fast/css/all-keyword-inherit.html: Added.
  • fast/css/all-keyword-initial-expected.html: Added.
  • fast/css/all-keyword-initial.html: Added.
  • fast/css/all-keyword-unset-expected.html: Added.
  • fast/css/all-keyword-unset.html: Added.
  • fast/css/variables/all-keyword-unset-expected.html: Added.
  • fast/css/variables/all-keyword-unset.html: Added.
8:57 AM Changeset in webkit [191177] by ap@apple.com
  • 2 edits in branches/safari-601-branch/LayoutTests

Land accurate Yosemite/Mavericks results for http/tests/multipart/multipart-replace-non-html-content.html

  • platform/mac-yosemite/http/tests/multipart/multipart-replace-non-html-content-expected.txt:
8:56 AM Changeset in webkit [191176] by youenn.fablet@crf.canon.fr
  • 28 edits in trunk/Source/WebCore

Binding generator should use templated JSXXConstructor
https://bugs.webkit.org/show_bug.cgi?id=149952

Reviewed by Darin Adler.

Adding constructor templates:

  • JSDOMConstructor: usual JS constructors
  • JSDOMNamedConstructor: for named constructors
  • JSDOMConstructorNotConstructable: for objects that cannot be constructed directly from JS.

Binding generator is using these 3 templates and is generating specializations for construct, initializeProperties and s_info.
These templates may also be used for private or custom constructors as examplified by JSImageConstructor
and JSReadableStream reader and controller private constructors.

Updated binding generator to use those templates.
Updated JSImageConstructor.cpp to use JSDOMNamedConstructor.
Updated default template implementation of JSBuiltinConstructor::createObject.
Updated generated helper routines of binding generator to fit with the templates.

A further patch should remove DOMConstructorWithDocument and DOMConstructorJSBuiltinObject.

Covered by binding tests.

  • bindings/js/JSDOMConstructor.h:

(WebCore::JSDOMConstructorNotConstructable::create):
(WebCore::JSDOMConstructorNotConstructable::createStructure):
(WebCore::JSDOMConstructorNotConstructable::JSDOMConstructorNotConstructable):
(WebCore::JSDOMConstructorNotConstructable::initializeProperties):
(WebCore::JSDOMConstructorNotConstructable<JSClass>::finishCreation):
(WebCore::JSDOMConstructor::create):
(WebCore::JSDOMConstructor::createStructure):
(WebCore::JSDOMConstructor::JSDOMConstructor):
(WebCore::JSDOMConstructor::initializeProperties):
(WebCore::JSDOMConstructor<JSClass>::finishCreation):
(WebCore::JSDOMConstructor<JSClass>::getConstructData):
(WebCore::JSDOMNamedConstructor::create):
(WebCore::JSDOMNamedConstructor::createStructure):
(WebCore::JSDOMNamedConstructor::JSDOMNamedConstructor):
(WebCore::JSDOMNamedConstructor::initializeProperties):
(WebCore::JSDOMNamedConstructor<JSClass>::finishCreation):
(WebCore::JSDOMNamedConstructor<JSClass>::getConstructData):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::image):

  • bindings/js/JSImageConstructor.cpp:

(WebCore::JSImageConstructor::initializeProperties):
(WebCore::JSImageConstructor::construct):
(WebCore::createImageConstructor):

  • bindings/js/JSImageConstructor.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GetConstructorTemplateClassName):
(GenerateConstructorDeclaration):
(GenerateOverloadedConstructorDefinition):
(GenerateConstructorDefinition):
(GenerateConstructorHelperMethods):
(GenerateImplementation): Deleted.
(GenerateConstructorDefinitions): Deleted.
(HasCustomSetter): Deleted.
(HasCustomMethod): Deleted.
(NeedsConstructorProperty): Deleted.
(ComputeFunctionSpecial): Deleted.
(AddJSBuiltinIncludesIfNeeded): Deleted.

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObjectConstructor::initializeProperties):
(WebCore::JSTestActiveDOMObjectPrototype::finishCreation): Deleted.
(WebCore::JSTestActiveDOMObject::JSTestActiveDOMObject): Deleted.

  • bindings/scripts/test/JS/JSTestCallback.cpp:

(WebCore::JSTestCallbackConstructor::initializeProperties):
(WebCore::JSTestCallback::callbackWithNoParam): Deleted.

  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::construct):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::initializeProperties):
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectPrototype::finishCreation): Deleted.
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::JSTestCustomConstructorWithNoInterfaceObject): Deleted.
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::createPrototype): Deleted.
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::getPrototype): Deleted.
(WebCore::JSTestCustomConstructorWithNoInterfaceObject::destroy): Deleted.

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetterConstructor::initializeProperties):
(WebCore::JSTestCustomNamedGetterPrototype::finishCreation): Deleted.
(WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter): Deleted.

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::construct):
(WebCore::JSTestEventConstructorConstructor::initializeProperties):
(WebCore::JSTestEventConstructorPrototype::finishCreation): Deleted.
(WebCore::JSTestEventConstructor::JSTestEventConstructor): Deleted.
(WebCore::JSTestEventConstructor::getPrototype): Deleted.

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTargetConstructor::initializeProperties):
(WebCore::JSTestEventTargetPrototype::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestExceptionConstructor::initializeProperties):
(WebCore::JSTestExceptionPrototype::finishCreation): Deleted.
(WebCore::JSTestException::JSTestException): Deleted.

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachableConstructor::initializeProperties):
(WebCore::JSTestGenerateIsReachablePrototype::finishCreation): Deleted.
(WebCore::JSTestGenerateIsReachable::JSTestGenerateIsReachable): Deleted.

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::construct):
(WebCore::JSTestInterfaceConstructor::initializeProperties):
(WebCore::JSTestInterfaceConstructor::getConstructData):

  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:

(WebCore::JSTestJSBuiltinConstructorConstructor::createJSObject):
(WebCore::JSTestJSBuiltinConstructorConstructor::initializeProperties):
(WebCore::JSTestJSBuiltinConstructorPrototype::finishCreation): Deleted.
(WebCore::JSTestJSBuiltinConstructor::JSTestJSBuiltinConstructor): Deleted.
(WebCore::JSTestJSBuiltinConstructor::createPrototype): Deleted.
(WebCore::JSTestJSBuiltinConstructor::getPrototype): Deleted.
(WebCore::JSTestJSBuiltinConstructor::destroy): Deleted.

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::initializeProperties):
(WebCore::JSTestMediaQueryListListenerPrototype::finishCreation): Deleted.
(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener): Deleted.

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorConstructor::initializeProperties):
(WebCore::JSTestNamedConstructorNamedConstructor::construct):
(WebCore::JSTestNamedConstructorNamedConstructor::initializeProperties):
(WebCore::JSTestNamedConstructorPrototype::finishCreation): Deleted.
(WebCore::JSTestNamedConstructor::JSTestNamedConstructor): Deleted.
(WebCore::jsTestNamedConstructorConstructor): Deleted.
(WebCore::JSTestNamedConstructor::getConstructor): Deleted.
(WebCore::JSTestNamedConstructorOwner::isReachableFromOpaqueRoots): Deleted.

  • bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodeConstructor::construct):
(WebCore::JSTestNodeConstructor::initializeProperties):
(WebCore::JSTestNodePrototype::finishCreation): Deleted.
(WebCore::JSTestNode::JSTestNode): Deleted.
(WebCore::JSTestNode::getPrototype): Deleted.

  • bindings/scripts/test/JS/JSTestNondeterministic.cpp:

(WebCore::JSTestNondeterministicConstructor::initializeProperties):
(WebCore::JSTestNondeterministicPrototype::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::construct):
(WebCore::JSTestObjConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructorsConstructor::construct):
(WebCore::JSTestOverloadedConstructorsConstructor::initializeProperties):
(WebCore::constructJSTestOverloadedConstructors1): Deleted.
(WebCore::constructJSTestOverloadedConstructors2): Deleted.
(WebCore::JSTestOverloadedConstructorsPrototype::finishCreation): Deleted.
(WebCore::JSTestOverloadedConstructors::JSTestOverloadedConstructors): Deleted.
(WebCore::JSTestOverloadedConstructors::createPrototype): Deleted.
(WebCore::JSTestOverloadedConstructors::getPrototype): Deleted.
(WebCore::JSTestOverloadedConstructors::destroy): Deleted.

  • bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::JSTestOverrideBuiltinsConstructor::initializeProperties):
(WebCore::JSTestOverrideBuiltinsPrototype::finishCreation): Deleted.
(WebCore::JSTestOverrideBuiltins::JSTestOverrideBuiltins): Deleted.

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::initializeProperties):
(WebCore::JSTestSerializedScriptValueInterfacePrototype::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::construct):
(WebCore::JSTestTypedefsConstructor::initializeProperties):
(WebCore::JSTestTypedefsPrototype::finishCreation): Deleted.

  • bindings/scripts/test/JS/JSattribute.cpp:

(WebCore::JSattributeConstructor::initializeProperties):
(WebCore::JSattributePrototype::finishCreation): Deleted.
(WebCore::JSattribute::JSattribute): Deleted.

  • bindings/scripts/test/JS/JSreadonly.cpp:

(WebCore::JSreadonlyConstructor::initializeProperties):
(WebCore::JSreadonlyPrototype::finishCreation): Deleted.
(WebCore::JSreadonly::JSreadonly): Deleted.

7:43 AM Changeset in webkit [191175] by msaboff@apple.com
  • 14 edits
    2 adds in trunk

REGRESSION (r190289): Repro crash clicking back button on netflix.com
https://bugs.webkit.org/show_bug.cgi?id=150220

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Since constructors check for a valid new "this" object and return it, we can't make
a tail call to another function from within a constructor.

Re-enabled the tail calls and the related tail call tests.

Did some other miscellaneous clean up in the tail call code as part of the debugging.

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::callPreflight):

  • interpreter/Interpreter.h:

(JSC::calleeFrameForVarargs):

  • runtime/Options.h:
  • tests/es6.yaml:
  • tests/stress/dfg-tail-calls.js:

(nonInlinedTailCall.callee):

  • tests/stress/mutual-tail-call-no-stack-overflow.js:

(shouldThrow):

  • tests/stress/tail-call-in-inline-cache.js:

(tail):

  • tests/stress/tail-call-no-stack-overflow.js:

(shouldThrow):

  • tests/stress/tail-call-recognize.js:

(callerMustBeRun):

  • tests/stress/tail-call-varargs-no-stack-overflow.js:

(shouldThrow):

LayoutTests:

Added a new regression test. Changed the expected output of caller-property
to correspond with tail calls enabled.

  • js/caller-property-expected.txt:
  • js/regress-150220-expected.tx: Added.
  • js/regress-150220.html: Added.
  • js/script-tests/regress-150220.js: Added.

(Obj):
(SubObj):

3:47 AM Changeset in webkit [191174] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebCore

[GStreamer] ASSERTION FAILED: !m_adoptionIsRequired in MediaSourceGStreamer::addSourceBuffer
https://bugs.webkit.org/show_bug.cgi?id=150229

Reviewed by Philippe Normand.

This happens in the debug bot in all media source tests that run
that code. The problem is that we are creating a RefPtr without
adopting the reference.

  • platform/graphics/gstreamer/MediaSourceGStreamer.cpp:

(WebCore::MediaSourceGStreamer::addSourceBuffer): Use
SourceBufferPrivateGStreamer::create().

  • platform/graphics/gstreamer/SourceBufferPrivateGStreamer.cpp:

(WebCore::SourceBufferPrivateGStreamer::create): Added to make
sure you can't create a SourceBufferPrivateGStreamer without
adopting the reference.
(WebCore::SourceBufferPrivateGStreamer::SourceBufferPrivateGStreamer):
Takes a reference to the client instead of a PassRefPtr.

  • platform/graphics/gstreamer/SourceBufferPrivateGStreamer.h:
12:29 AM Changeset in webkit [191173] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed EFL Gardening on 15th Oct.
https://bugs.webkit.org/show_bug.cgi?id=150223

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-10-16

  • platform/efl/TestExpectations:
12:14 AM Changeset in webkit [191172] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebKit2

[GTK] Try to fix the build after r191137
https://bugs.webkit.org/show_bug.cgi?id=150222

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-10-16
Reviewed by Carlos Garcia Campos.

  • UIProcess/API/gtk/PageClientImpl.cpp:

(WebKit::PageClientImpl::doneWithKeyEvent):
(WebKit::PageClientImpl::createPopupMenuProxy):
(WebKit::PageClientImpl::createContextMenuProxy):
(WebKit::PageClientImpl::createColorPicker):

  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/gtk/WebContextMenuProxyGtk.cpp:

(WebKit::WebContextMenuProxyGtk::populate):
(WebKit::WebContextMenuProxyGtk::showContextMenu):
(WebKit::WebContextMenuProxyGtk::hideContextMenu):
(WebKit::WebContextMenuProxyGtk::WebContextMenuProxyGtk):

  • UIProcess/gtk/WebContextMenuProxyGtk.h:

(WebKit::WebContextMenuProxyGtk::create):
(WebKit::WebContextMenuProxyGtk::gtkMenu):

  • UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::WebPopupMenuProxyGtk):

  • UIProcess/gtk/WebPopupMenuProxyGtk.h:

(WebKit::WebPopupMenuProxyGtk::create):
(WebKit::WebPopupMenuProxyGtk::setCurrentlySelectedMenuItem):

Oct 15, 2015:

11:29 PM Changeset in webkit [191171] by matthew_hanson@apple.com
  • 19 edits in branches/safari-601.1.46-branch

Merge r190604. rdar://problem/22993012

11:28 PM Changeset in webkit [191170] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r190447. rdar://problem/22865007

11:28 PM Changeset in webkit [191169] by matthew_hanson@apple.com
  • 3 edits in branches/safari-601.1.46-branch/LayoutTests

Merge r190438. rdar://problem/22865007

11:28 PM Changeset in webkit [191168] by matthew_hanson@apple.com
  • 18 edits in branches/safari-601.1.46-branch

Merge r190434. rdar://problem/22865007

9:26 PM Changeset in webkit [191167] by achristensen@apple.com
  • 3 edits
    27 adds in trunk

[Content Extensions] Content blocking rules are not consulted for pings
https://bugs.webkit.org/show_bug.cgi?id=149873

Patch by Roopesh Chander <roop@roopc.net> on 2015-10-15
Reviewed by Alex Christensen.

Source/WebCore:

This patch makes requests sent through the PingLoader
respect content blocking rules. Specifically, the following
are now subject to content blocking rules:

  1. <a ping> pings
  2. Images loaded in unload / beforeunload / pagehide handlers
  3. X-XSS-Protection / CSP violation reports

Tests: http/tests/contentextensions/block-cookies-in-csp-report.html

http/tests/contentextensions/block-cookies-in-image-load-in-onunload.html
http/tests/contentextensions/block-cookies-in-ping.html
http/tests/contentextensions/block-csp-report.html
http/tests/contentextensions/block-image-load-in-onunload.html
http/tests/contentextensions/block-ping.html
http/tests/contentextensions/hide-on-csp-report.html

  • loader/PingLoader.cpp:

(WebCore::processContentExtensionRulesForLoad):
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):

LayoutTests:

Tests for ensuring that requests loaded through the PingLoader
are subject to content blocking rules.

  • http/tests/contentextensions/block-cookies-in-csp-report-expected.txt: Added.
  • http/tests/contentextensions/block-cookies-in-csp-report.html: Added.
  • http/tests/contentextensions/block-cookies-in-csp-report.html.json: Added.
  • http/tests/contentextensions/block-cookies-in-image-load-in-onunload-expected.txt: Added.
  • http/tests/contentextensions/block-cookies-in-image-load-in-onunload.html: Added.
  • http/tests/contentextensions/block-cookies-in-image-load-in-onunload.html.json: Added.
  • http/tests/contentextensions/block-cookies-in-ping-expected.txt: Added.
  • http/tests/contentextensions/block-cookies-in-ping.html: Added.
  • http/tests/contentextensions/block-cookies-in-ping.html.json: Added.
  • http/tests/contentextensions/block-csp-report-expected.txt: Added.
  • http/tests/contentextensions/block-csp-report.html: Added.
  • http/tests/contentextensions/block-csp-report.html.json: Added.
  • http/tests/contentextensions/block-image-load-in-onunload-expected.txt: Added.
  • http/tests/contentextensions/block-image-load-in-onunload.html: Added.
  • http/tests/contentextensions/block-image-load-in-onunload.html.json: Added.
  • http/tests/contentextensions/block-ping-expected.txt: Added.
  • http/tests/contentextensions/block-ping.html: Added.
  • http/tests/contentextensions/block-ping.html.json: Added.
  • http/tests/contentextensions/hide-on-csp-report-expected.txt: Added.
  • http/tests/contentextensions/hide-on-csp-report.html: Added.
  • http/tests/contentextensions/hide-on-csp-report.html.json: Added.
  • http/tests/contentextensions/resources/check-ping.html: Added.
  • http/tests/contentextensions/resources/delete-ping.php: Added.
  • http/tests/contentextensions/resources/get-ping-data.php: Added.
  • http/tests/contentextensions/resources/ping-file-path.php: Added.
  • http/tests/contentextensions/resources/redirect.php: Added.
  • http/tests/contentextensions/resources/save-ping.php: Added.
8:54 PM Changeset in webkit [191166] by Joseph Pecoraro
  • 2 edits in trunk/LayoutTests

Unreviewed gardening. Make inspector/heap/gc.html more reliable.

  • inspector/heap/gc.html:

Stop outputing after we see the first Full GC. Resolving waits
for pending events which could incldue more GCs.

8:07 PM Changeset in webkit [191165] by Joseph Pecoraro
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Attempted EFL build fix 2 after r191159.

  • PlatformEfl.cmake:
7:58 PM Changeset in webkit [191164] by Joseph Pecoraro
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Attempted EFL build fix after r191159.

  • PlatformEfl.cmake:
7:51 PM Changeset in webkit [191163] by Gyuyoung Kim
  • 8 edits in trunk/Source/WebKit2

EFL build fix since r191137

Unreviewed EFL build fix.

  • UIProcess/CoordinatedGraphics/WebView.cpp: Removed.
7:36 PM Changeset in webkit [191162] by Joseph Pecoraro
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed. Build fix after r191160.

  • inspector/agents/InspectorHeapAgent.cpp:

(Inspector::InspectorHeapAgent::didGarbageCollect):

7:34 PM Changeset in webkit [191161] by Joseph Pecoraro
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed. Revert part of r191159 which caused ASSERTs.

A review comment suggested using WeakPtr. It is not suitable
here and causes ASSERTs across threads. Will address separately.

  • inspector/agents/InspectorHeapAgent.h:
  • inspector/agents/InspectorHeapAgent.cpp:

(Inspector::InspectorHeapAgent::didGarbageCollect):
(Inspector::InspectorHeapAgent::InspectorHeapAgent): Deleted.

7:19 PM Changeset in webkit [191160] by ap@apple.com
  • 2 edits
    1 copy
    3 adds in branches/safari-601-branch/LayoutTests

Update test results on the branch.

  • platform/mac-yosemite/http: Added.
  • platform/mac-yosemite/http/tests: Added.
  • platform/mac-yosemite/http/tests/multipart: Added.
  • platform/mac-yosemite/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Copied from LayoutTests/http/tests/multipart/multipart-replace-non-html-content-expected.txt.
  • platform/mac/http/tests/multipart/multipart-replace-non-html-content-expected.txt:
7:15 PM Changeset in webkit [191159] by Joseph Pecoraro
  • 35 edits
    4 copies
    11 adds in trunk

Web Inspector: Include Garbage Collection Event in Timeline
https://bugs.webkit.org/show_bug.cgi?id=142510

Reviewed by Geoffrey Garen and Brian Burg.

Source/JavaScriptCore:

  • CMakeLists.txt:
  • DerivedSources.make:
  • JavaScriptCore.xcodeproj/project.pbxproj:

Include new files in the build.

  • heap/HeapObserver.h:

(JSC::HeapObserver::~HeapObserver):

  • heap/Heap.cpp:

(JSC::Heap::willStartCollection):
(JSC::Heap::didFinishCollection):

  • heap/Heap.h:

(JSC::Heap::addObserver):
(JSC::Heap::removeObserver):
Allow observers on heap to add hooks for starting / ending garbage collection.

  • inspector/InspectorEnvironment.h:
  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::JSGlobalObjectInspectorController):
(Inspector::JSGlobalObjectInspectorController::vm):

  • inspector/JSGlobalObjectInspectorController.h:

Access the VM through the InspectorEnvironment as it won't change.

  • inspector/agents/InspectorHeapAgent.cpp: Added.

(Inspector::InspectorHeapAgent::InspectorHeapAgent):
(Inspector::InspectorHeapAgent::~InspectorHeapAgent):
(Inspector::InspectorHeapAgent::didCreateFrontendAndBackend):
(Inspector::InspectorHeapAgent::willDestroyFrontendAndBackend):
(Inspector::InspectorHeapAgent::enable):
(Inspector::InspectorHeapAgent::disable):
(Inspector::InspectorHeapAgent::gc):
(Inspector::protocolTypeForHeapOperation):
(Inspector::InspectorHeapAgent::willGarbageCollect):
(Inspector::InspectorHeapAgent::didGarbageCollect):

  • inspector/agents/InspectorHeapAgent.h: Added.
  • inspector/protocol/Heap.json: Added.

New domain and agent to handle tasks related to the JavaScriptCore heap.

Source/WebCore:

Tests: inspector/heap/garbageCollected.html

inspector/heap/gc.html

  • ForwardingHeaders/heap/HeapObserver.h: Added.
  • ForwardingHeaders/inspector/agents/InspectorHeapAgent.h: Added.
  • WebCore.vcxproj/WebCore.vcxproj:
  • WebCore.vcxproj/WebCore.vcxproj.filters:

Forwarding headers.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::vm):

  • inspector/InspectorController.h:
  • inspector/WorkerInspectorController.cpp:

(WebCore::WorkerInspectorController::vm):

  • inspector/WorkerInspectorController.h:

Implement InspectorEnvironment::vm and create a Heap agent for the
Page inspector controller.

Source/WebInspectorUI:

  • UserInterface/Base/Utilities.js:

(Array.prototype.partition):
Helper to partition an Array into two arrays.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Base/Main.js:

(WebInspector.loaded):

  • UserInterface/Test.html:
  • UserInterface/Test/Test.js:

(WebInspector.loaded):

  • UserInterface/Protocol/HeapObserver.js: Added.

(WebInspector.HeapObserver.prototype.garbageCollected):
(WebInspector.HeapObserver):
Create the new observer and manager.

  • UserInterface/Models/GarbageCollection.js: Added.

(WebInspector.GarbageCollection):
(WebInspector.GarbageCollection.fromPayload):
(WebInspector.GarbageCollection.prototype.get type):
(WebInspector.GarbageCollection.prototype.get startTime):
(WebInspector.GarbageCollection.prototype.get endTime):
(WebInspector.GarbageCollection.prototype.get duration):
Model object for Heap.GarbageCollection.

  • UserInterface/Controllers/HeapManager.js: Added.

(WebInspector.HeapManager):
(WebInspector.HeapManager.prototype.garbageCollected):
Dispatch events with the GC object.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager):
(WebInspector.TimelineManager.prototype._garbageCollected):
Include new GC Timeline Events as Script events.

  • UserInterface/Views/ScriptTimelineOverviewGraph.js:

(WebInspector.ScriptTimelineOverviewGraph.prototype.updateLayout):
For the Script overview, make two sets of bars, one for Scripts and one for GCs.
The GCs bar will be overlaid on top of the the Scripts bar. This is particularly
useful since a GC can happen during script execution.

  • UserInterface/Images/TimelineRecordGarbageCollection.svg: Added.
  • UserInterface/Main.html:
  • UserInterface/Models/ScriptTimelineRecord.js:

(WebInspector.ScriptTimelineRecord.prototype.isGarbageCollection):
(WebInspector.ScriptTimelineRecord.EventType.displayName):

  • UserInterface/Views/ScriptTimelineDataGridNode.js:

(WebInspector.ScriptTimelineDataGridNode.prototype.get data):
(WebInspector.ScriptTimelineDataGridNode.prototype.createCellContent):
(WebInspector.ScriptTimelineDataGridNode):

  • UserInterface/Views/ScriptTimelineView.js:

(WebInspector.ScriptTimelineView.prototype._processPendingRecords):

  • UserInterface/Views/SourceCodeTimelineTreeElement.js:

(WebInspector.SourceCodeTimelineTreeElement):

  • UserInterface/Views/TimelineIcons.css:

(.garbage-collection-profile-record .icon):

  • UserInterface/Views/TimelineRecordBar.css:

(.timeline-record-bar.timeline-record-type-script.script-timeline-record-garbage-collected > .segment):
UI for GC events.

  • UserInterface/Views/TimelineRecordBar.js:

(WebInspector.TimelineRecordBar.createCombinedBars):
Simplify by storing start time into a variable.

  • UserInterface/Views/TimelineRecordTreeElement.js:

(WebInspector.TimelineRecordTreeElement):
Icon for GC events.

LayoutTests:

  • inspector/heap/garbageCollected-expected.txt: Added.
  • inspector/heap/garbageCollected.html: Added.
  • inspector/heap/gc-expected.txt: Added.
  • inspector/heap/gc.html: Added.
6:33 PM Changeset in webkit [191158] by dino@apple.com
  • 4 edits in trunk/LayoutTests

Remove deprecated function insertRule(), replace with appendRule()
https://bugs.webkit.org/show_bug.cgi?id=150188

Unreviewed. This was a mistake in my review of Ryan's patch.
The CSSOM is confusing. This test was not always using a CSSKeyframesRule
object, so it should still be calling insertRule. This does produce
a console message, so added that to the expected result.

  • http/tests/css/resources/shared-stylesheet-mutation.js:

(executeTests): Back to insertRule.

  • http/tests/css/shared-stylesheet-mutation-expected.txt:
  • http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt:
  • http/tests/css/resources/shared-stylesheet-mutation.js:

(executeTests): Back to insertRule.

5:34 PM Changeset in webkit [191157] by commit-queue@webkit.org
  • 18 edits in trunk

Unreviewed, rolling out r191156.
https://bugs.webkit.org/show_bug.cgi?id=150215

Introduced crashing test (Requested by bradee-oh on #webkit).

Reverted changeset:

"Modern IDB: Support IDBDatabase.close()."
https://bugs.webkit.org/show_bug.cgi?id=150150
http://trac.webkit.org/changeset/191156

5:25 PM Changeset in webkit [191156] by beidson@apple.com
  • 18 edits in trunk

Modern IDB: Support IDBDatabase.close().
https://bugs.webkit.org/show_bug.cgi?id=150150

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (Covered by changes to storage/indexeddb/modern/opendatabase-versions.html).

  • Modules/indexeddb/client/IDBConnectionToServer.cpp:

(WebCore::IDBClient::IDBConnectionToServer::databaseConnectionClosed):

  • Modules/indexeddb/client/IDBConnectionToServer.h:
  • Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
  • Modules/indexeddb/client/IDBDatabaseImpl.cpp:

(WebCore::IDBClient::IDBDatabase::IDBDatabase):
(WebCore::IDBClient::IDBDatabase::~IDBDatabase):
(WebCore::IDBClient::IDBDatabase::close):
(WebCore::IDBClient::IDBDatabase::maybeCloseInServer):
(WebCore::IDBClient::IDBDatabase::commitTransaction):

  • Modules/indexeddb/client/IDBDatabaseImpl.h:

(WebCore::IDBClient::IDBDatabase::databaseConnectionIdentifier):

  • Modules/indexeddb/client/IDBRequestImpl.cpp:

(WebCore::IDBClient::IDBRequest::result):

  • Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::databaseConnectionClosed):

  • Modules/indexeddb/server/IDBServer.h:
  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::connectionClosedFromClient):
(WebCore::IDBServer::UniqueIDBDatabase::handleOpenDatabaseOperations): Deleted.

  • Modules/indexeddb/server/UniqueIDBDatabase.h:
  • Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:

(WebCore::IDBServer::UniqueIDBDatabaseConnection::UniqueIDBDatabaseConnection):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::~UniqueIDBDatabaseConnection):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::hasNonFinishedTransactions):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::connectionClosedFromClient):

  • Modules/indexeddb/server/UniqueIDBDatabaseConnection.h:
  • Modules/indexeddb/shared/InProcessIDBServer.cpp:

(WebCore::InProcessIDBServer::databaseConnectionClosed):

  • Modules/indexeddb/shared/InProcessIDBServer.h:

LayoutTests:

  • storage/indexeddb/modern/opendatabase-versions-expected.txt:
  • storage/indexeddb/modern/opendatabase-versions.html:
5:18 PM Changeset in webkit [191155] by hyatt@apple.com
  • 2 edits in trunk/Source/WebCore

Patch parseKeywordValue to accept "unset" so that it goes down the faster parsing path.
https://bugs.webkit.org/show_bug.cgi?id=150213

Reviewed by Dean Jackson.

No new tests as correctness doesn't change (just speed).

  • css/CSSParser.cpp:

(WebCore::parseKeywordValue):

5:13 PM Changeset in webkit [191154] by matthew_hanson@apple.com
  • 17 edits in branches/safari-601.1.46-branch

Rollout r188486. rdar://problem/22707497

5:13 PM Changeset in webkit [191153] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Rollout r188531. rdar://problem/22707497

5:09 PM Changeset in webkit [191152] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Marking another disk-cache test as flaky on mac-wk2
https://bugs.webkit.org/show_bug.cgi?id=149087

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-15
Reviewed by Alexey Proskuryakov.

  • platform/mac-wk2/TestExpectations:
4:54 PM Changeset in webkit [191151] by hyatt@apple.com
  • 14 edits
    10 adds
    6 deletes in trunk

Add support for the CSS 'unset' keyword.
https://bugs.webkit.org/show_bug.cgi?id=148614

Reviewed by Dean Jackson.

Source/WebCore:

Added new test in fast/css, and existing variables tests also use unset in several tests.

  • WebCore.xcodeproj/project.pbxproj:

Add CSSUnsetValue.cpp to the project.

  • bindings/objc/DOMCSS.mm:

(kitClass):
Make sure UNSET is handled in the switch.

  • css/CSSParser.cpp:

(WebCore::parseKeywordValue):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseCustomPropertyDeclaration):
Add cases to create a CSSUnsetValue properly.

  • css/CSSToStyleMap.cpp:

(WebCore::CSSToStyleMap::styleImage):
(WebCore::CSSToStyleMap::mapFillAttachment):
(WebCore::CSSToStyleMap::mapFillClip):
(WebCore::CSSToStyleMap::mapFillComposite):
(WebCore::CSSToStyleMap::mapFillBlendMode):
(WebCore::CSSToStyleMap::mapFillOrigin):
(WebCore::CSSToStyleMap::mapFillImage):
(WebCore::CSSToStyleMap::mapFillRepeatX):
(WebCore::CSSToStyleMap::mapFillRepeatY):
(WebCore::convertToLengthSize):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapFillMaskSourceType):
(WebCore::CSSToStyleMap::mapAnimationDelay):
(WebCore::CSSToStyleMap::mapAnimationDirection):
(WebCore::CSSToStyleMap::mapAnimationDuration):
(WebCore::CSSToStyleMap::mapAnimationFillMode):
(WebCore::CSSToStyleMap::mapAnimationIterationCount):
(WebCore::CSSToStyleMap::mapAnimationName):
(WebCore::CSSToStyleMap::mapAnimationPlayState):
(WebCore::CSSToStyleMap::mapAnimationProperty):
(WebCore::CSSToStyleMap::mapAnimationTimingFunction):
(WebCore::CSSToStyleMap::mapAnimationTrigger):
The background and animation functions need to check for unset and be able to map it properly to initial. This is done
with a new treatAsInitial method on CSSValue that can take the property ID and check for both initial
or unset on a non-inherited property.

  • css/CSSUnsetValue.cpp: Added.

(WebCore::CSSUnsetValue::customCSSText):

  • css/CSSUnsetValue.h: Added.

(WebCore::CSSUnsetValue::create):
(WebCore::CSSUnsetValue::equals):
(WebCore::CSSUnsetValue::CSSUnsetValue):
This new value looks exactly like CSSInheritedValue and CSSInitialValue.

  • css/CSSValue.cpp:

(WebCore::CSSValue::cssValueType):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::isInvalidCustomPropertyValue):
(WebCore::CSSValue::treatAsInheritedValue):
(WebCore::CSSValue::treatAsInitialValue):

  • css/CSSValue.h:

(WebCore::CSSValue::isUnsetValue):
Add isUnsetValue and the UnsetClass. Add support for treatAsInheritedValue and treatAsInitialValue to have
a way to query for initial/inherit or the matching unset type.

  • css/CSSValueKeywords.in:

Add the unset keyword.

  • css/CSSValuePool.cpp:

(WebCore::CSSValuePool::CSSValuePool):

  • css/CSSValuePool.h:

(WebCore::CSSValuePool::createUnsetValue):
Have a singleton model for unset just like we do for inherit/initial.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
Handle unset correctly. It maps to inherit for inherited properties and initial for non-inherited ones.

LayoutTests:

Remove the 3 failing variables tests that used the unset keyword now that they pass.

  • fast/css/unset-keyword-expected.html: Added.
  • fast/css/unset-keyword.html: Added.

New test for both inherited and initial properties.

  • fast/css/variables/test-suite/129-expected.html: Added.
  • fast/css/variables/test-suite/129.html: Added.
  • fast/css/variables/test-suite/130-expected.html: Added.
  • fast/css/variables/test-suite/130.html: Added.
  • fast/css/variables/test-suite/134-expected.html: Added.
  • fast/css/variables/test-suite/134.html: Added.
  • fast/css/variables/test-suite/failures/129-expected.html: Removed.
  • fast/css/variables/test-suite/failures/129.html: Removed.
  • fast/css/variables/test-suite/failures/130-expected.html: Removed.
  • fast/css/variables/test-suite/failures/130.html: Removed.
  • fast/css/variables/test-suite/failures/134-expected.html: Removed.
  • fast/css/variables/test-suite/failures/134.html: Removed.

Move these tests into the passing directory.

4:41 PM Changeset in webkit [191150] by bshafiei@apple.com
  • 54 edits
    1 copy
    3 deletes in tags/Safari-602.1.7/Source/JavaScriptCore

Roll out r190896. rdar://problem/23128791

4:38 PM Changeset in webkit [191149] by bshafiei@apple.com
  • 2 edits in tags/Safari-602.1.7/Source/JavaScriptCore

Roll out r190904. rdar://problem/23128791

4:20 PM Changeset in webkit [191148] by mmaxfield@apple.com
  • 12 edits in trunk/Source

Migrate to CGContextSetBaseCTM() and CGContextResetClip() from WKSI
https://bugs.webkit.org/show_bug.cgi?id=150155

Reviewed by Tim Horton.

Source/WebCore:

No new tests because there is no behavior change.

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::drawPattern):
(WebCore::GraphicsContext::platformApplyDeviceScaleFactor):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::putByteArray):

  • platform/ios/WebCoreSystemInterfaceIOS.mm:
  • platform/mac/WebCoreSystemInterface.h:
  • platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Deleted.

  • WebView/WebView.mm:

(-[WebView _setBaseCTM:forContext:]):

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Deleted.

4:18 PM Changeset in webkit [191147] by dino@apple.com
  • 2 edits in trunk/LayoutTests

Remove deprecated function insertRule(), replace with appendRule()
https://bugs.webkit.org/show_bug.cgi?id=150188

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-15
Reviewed by Dean Jackson.

  • http/tests/css/resources/shared-stylesheet-mutation.js:

(executeTests):

4:03 PM Changeset in webkit [191146] by dino@apple.com
  • 8 edits in trunk/Source/WebKit2

Fix the iOS build. And hopefully not breaking the other builds
at the same time.

  • UIProcess/PageClient.h:
  • UIProcess/WebContextMenuProxy.cpp:
  • UIProcess/WebContextMenuProxy.h:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:
  • UIProcess/mac/PageClientImpl.h:
  • UIProcess/mac/PageClientImpl.mm:
4:02 PM Changeset in webkit [191145] by commit-queue@webkit.org
  • 12 edits
    2 deletes in trunk

Unreviewed, rolling out r191135.
https://bugs.webkit.org/show_bug.cgi?id=150197

This patch causes 50+ LayoutTest crashes related to the
inspector (Requested by ryanhaddad on #webkit).

Reverted changeset:

"Web Inspector: JavaScriptCore should parse sourceURL and
sourceMappingURL directives"
https://bugs.webkit.org/show_bug.cgi?id=150096
http://trac.webkit.org/changeset/191135

3:51 PM Changeset in webkit [191144] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Use the context inside WebContextMenuProxyMac
https://bugs.webkit.org/show_bug.cgi?id=150196

Reviewed by Tim Horton.

  • UIProcess/WebContextMenuProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::internalShowContextMenu):

  • UIProcess/mac/WebContextMenuProxyMac.h:
  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::populate):
(WebKit::WebContextMenuProxyMac::showContextMenu):

3:34 PM Changeset in webkit [191143] by andersca@apple.com
  • 5 edits in trunk/Source/WebKit2

Use the context menu location that's stored in the context data
https://bugs.webkit.org/show_bug.cgi?id=150194

Reviewed by Tim Horton.

  • UIProcess/WebContextMenuProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::internalShowContextMenu):

  • UIProcess/mac/WebContextMenuProxyMac.h:
  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::showContextMenu):

3:20 PM Changeset in webkit [191142] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Fixed the build.

  • platform/network/mac/ResourceHandleMac.mm:
3:15 PM Changeset in webkit [191141] by andersca@apple.com
  • 11 edits in trunk/Source/WebKit2

Store the context menu data and user data in the WebContextMenuProxy object
https://bugs.webkit.org/show_bug.cgi?id=150191

Reviewed by Tim Horton.

  • UIProcess/PageClient.h:
  • UIProcess/WebContextMenuProxy.cpp:

(WebKit::WebContextMenuProxy::WebContextMenuProxy):

  • UIProcess/WebContextMenuProxy.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::internalShowContextMenu):

  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::createContextMenuProxy):

  • UIProcess/mac/PageClientImpl.h:
  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::createContextMenuProxy):

  • UIProcess/mac/WebContextMenuProxyMac.h:

(WebKit::WebContextMenuProxyMac::create):

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::WebContextMenuProxyMac):

2:59 PM Changeset in webkit [191140] by mitz@apple.com
  • 10 edits in trunk/Source

[Cocoa] Stop using WKSetNSURLConnectionDefersCallbacks
https://bugs.webkit.org/show_bug.cgi?id=150189

Reviewed by Anders Carlsson.

Source/WebCore:

  • platform/ios/WebCoreSystemInterfaceIOS.mm: Removed definition.
  • platform/mac/WebCoreSystemInterface.h: Removed declaration.
  • platform/mac/WebCoreSystemInterface.mm: Removed definition.
  • platform/network/mac/ResourceHandleMac.mm:

(WebCore::ResourceHandle::start): Changed to use -[NSURLConnection setDefersLoading:].
(WebCore::ResourceHandle::platformSetDefersLoading): Ditto.

  • platform/spi/cocoa/NSURLConnectionSPI.h: Added declaration of -[NSURLConnection setDefersLoading:].

Source/WebKit/mac:

  • WebCoreSupport/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Removed initialization.

Source/WebKit2:

  • WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:

(InitWebCoreSystemInterface): Removed initialization.

2:52 PM Changeset in webkit [191139] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

2015-10-15 Geoffrey Garen <ggaren@apple.com>

Unreviewed, rolling out r191003.
https://bugs.webkit.org/show_bug.cgi?id=150042

We're seeing some crashes in GC beneath speculationFromCell. Maybe this
patch caused them?

Reverted changeset:

CodeBlock write barriers should be precise
https://bugs.webkit.org/show_bug.cgi?id=150042
http://trac.webkit.org/changeset/191003

2:31 PM Changeset in webkit [191138] by andersca@apple.com
  • 4 edits in trunk/Source/WebKit2

Fix build.

  • UIProcess/API/APIFrameInfo.cpp:

(API::FrameInfo::~FrameInfo):

  • UIProcess/API/APIFrameInfo.h:
  • UIProcess/API/Cocoa/WKUserContentController.mm:
2:27 PM Changeset in webkit [191137] by andersca@apple.com
  • 12 edits in trunk/Source/WebKit2

CTTE menu proxies
https://bugs.webkit.org/show_bug.cgi?id=150187

Reviewed by Tim Horton.

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::internalShowContextMenu):

  • UIProcess/WebPopupMenuProxy.h:

(WebKit::WebPopupMenuProxy::WebPopupMenuProxy):

  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::createPopupMenuProxy):
(WebKit::PageClientImpl::createContextMenuProxy): Deleted.

  • UIProcess/mac/PageClientImpl.h:
  • UIProcess/mac/PageClientImpl.mm:

(WebKit::PageClientImpl::createPopupMenuProxy):
(WebKit::PageClientImpl::createContextMenuProxy):

  • UIProcess/mac/WebContextMenuProxyMac.h:

(WebKit::WebContextMenuProxyMac::create):
(WebKit::WebContextMenuProxyMac::page):

  • UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::WebContextMenuProxyMac):
(WebKit::WebContextMenuProxyMac::~WebContextMenuProxyMac):
(WebKit::WebContextMenuProxyMac::contextMenuItemSelected):

  • UIProcess/mac/WebPopupMenuProxyMac.h:

(WebKit::WebPopupMenuProxyMac::create):

  • UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::WebPopupMenuProxyMac):

2:16 PM Changeset in webkit [191136] by andersca@apple.com
  • 6 edits
    1 copy in trunk/Source/WebKit2

Add -[WKFrameInfo _handle]
https://bugs.webkit.org/show_bug.cgi?id=150185
rdar://problem/23132371

Reviewed by Tim Horton.

  • UIProcess/API/APIFrameInfo.cpp:

(API::FrameInfo::FrameInfo):

  • UIProcess/API/APIFrameInfo.h:
  • UIProcess/API/Cocoa/WKFrameInfo.mm:

(-[WKFrameInfo _handle]):

  • UIProcess/API/Cocoa/WKFrameInfoInternal.h:
  • UIProcess/API/Cocoa/WKFrameInfoPrivate.h: Copied from Source/WebKit2/UIProcess/API/Cocoa/WKFrameInfoInternal.h.
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showPopupMenu):
(WebKit::WebPageProxy::internalShowContextMenu):

  • UIProcess/WebPopupMenuProxy.h:

(WebKit::WebPopupMenuProxy::WebPopupMenuProxy):

  • WebKit2.xcodeproj/project.pbxproj:
1:50 PM Changeset in webkit [191135] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk

Web Inspector: JavaScriptCore should parse sourceURL and sourceMappingURL directives
https://bugs.webkit.org/show_bug.cgi?id=150096

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-15
Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • inspector/ContentSearchUtilities.cpp:

(Inspector::ContentSearchUtilities::scriptCommentPattern): Deleted.
(Inspector::ContentSearchUtilities::findScriptSourceURL): Deleted.
(Inspector::ContentSearchUtilities::findScriptSourceMapURL): Deleted.

  • inspector/ContentSearchUtilities.h:

No longer need to search script content.

  • inspector/ScriptDebugServer.cpp:

(Inspector::ScriptDebugServer::dispatchDidParseSource):
Carry over the sourceURL and sourceMappingURL from the SourceProvider.

  • inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::sourceMapURLForScript):
(Inspector::InspectorDebuggerAgent::didParseSource):
No longer do content searching.

  • parser/Lexer.cpp:

(JSC::Lexer<T>::setCode):
(JSC::Lexer<T>::skipWhitespace):
(JSC::Lexer<T>::parseCommentDirective):
(JSC::Lexer<T>::parseCommentDirectiveValue):
(JSC::Lexer<T>::consume):
(JSC::Lexer<T>::lex):

  • parser/Lexer.h:

(JSC::Lexer::sourceURL):
(JSC::Lexer::sourceMappingURL):
(JSC::Lexer::sourceProvider): Deleted.
Give lexer the ability to detect script comment directives.
This just consumes characters in single line comments and
ultimately sets the sourceURL or sourceMappingURL found.

  • parser/Parser.h:

(JSC::Parser<LexerType>::parse):

  • parser/SourceProvider.h:

(JSC::SourceProvider::url):
(JSC::SourceProvider::sourceURL):
(JSC::SourceProvider::sourceMappingURL):
(JSC::SourceProvider::setSourceURL):
(JSC::SourceProvider::setSourceMappingURL):
After parsing a script, update the Source Provider with the
value of directives that may have been found in the script.

Source/WebInspectorUI:

  • UserInterface/Test/InspectorProtocol.js:

(InspectorProtocol._sendMessage):
(InspectorProtocol.dispatchMessageFromBackend):
This is only used for tests, so avoid console.log
and just dump directly to the system console.

LayoutTests:

  • inspector/debugger/sourceURLs-expected.txt: Added.
  • inspector/debugger/sourceURLs.html: Added.

sourceURL and sourceMappingURL detection.

1:34 PM Changeset in webkit [191134] by fpizlo@apple.com
  • 3 edits
    1 add in trunk/Source/JavaScriptCore

InferredTypeTable should ref its keys
https://bugs.webkit.org/show_bug.cgi?id=150138
rdar://problem/23080555

Reviewed by Michael Saboff.

InferredTypeTable was incorrectly using a key hash traits that caused the underlying HashTable to
store keys as UniquedStringImpl* rather than RefPtr<UniquedStringImpl>, even though the HashMap's
nominal key type was RefPtr<UniquedStringImpl>. This arose because I copy-pasted the HashMap type
instantiation from other places and then made random changes to adapt it to my needs, rather than
actually thinking about what I was doing. The solution is to remove the key hash traits argument,
since all it accomplishes is to produce this bug.

The way this bug manifested is probably best described in http://webkit.org/b/150008. After a while
the InferredTypeTable would have dangling references to its strings, if some recompilation or other
thing caused us to drop all other references to those strings. InferredTypeTable is particularly
susceptible to this because it is designed to know about a superset of the property names that its
client Structures know about. The debug assert would then happen when we rehashed the
InferredTypeTable's HashMap, because we'd try to get the hashes of strings that were already
deleted. AFAICT, we didn't have release crashes arising from those strings' memory being returned
to the OS - but it's totally possible that this could have happened. So, we definitely should treat
this bug as more than just a debug issue.

Interestingly, we could have also solved this problem by changing the hash function to use PtrHash.
In all other ways, it's OK for InferredTypeTable to hold dangling references, since it uses the
address of the UniquedStringImpl as a way to name an abstract heap. It's fine if the name of an
abstract heap is a bogus memory address, and it's also fine if that name referred to an entirely
different UniquedStringImpl at some point in the past. That's a nice benefit of any data structure
that keys by abstract heap - if two of them get unified then it's no big deal. I've filed another
bug, http://webkit.org/b/150137 about changing all of our UniquedStringImpl* hashing to use
PtrHash.

  • runtime/Identifier.h: Add a comment about http://webkit.org/b/150137.
  • runtime/InferredTypeTable.h: Fix the bug.
  • tests/stress/inferred-type-table-stale-identifiers.js: Added. I couldn't get this to cause a crash before my change, but it's an interesting test nonetheless.
1:21 PM Changeset in webkit [191133] by Csaba Osztrogonác
  • 2 edits in trunk/Tools

Update the help message of --system-malloc
https://bugs.webkit.org/show_bug.cgi?id=150169

Reviewed by Geoffrey Garen.

  • Scripts/webkitperl/FeatureList.pm:
12:57 PM Changeset in webkit [191132] by dino@apple.com
  • 6 edits in trunk

CSSKeyframesRule::appendRule is deprecated, but is actually the spec
https://bugs.webkit.org/show_bug.cgi?id=150113

Reviewed by Simon Fraser.

Source/WebCore:

I stupidly deprecated the wrong function in
http://trac.webkit.org/changeset/174469

  • css/CSSKeyframesRule.cpp:

(WebCore::CSSKeyframesRule::insertRule): Swap the code between these two.
(WebCore::CSSKeyframesRule::appendRule):

LayoutTests:

Update tests to deprecate the correct function.

  • animations/change-keyframes-expected.txt:
  • animations/keyframes-rule.html:
  • animations/unprefixed-keyframes-rule.html:
12:56 PM Changeset in webkit [191131] by andersca@apple.com
  • 8 edits in trunk/Source/WebKit2

The menu location and menu items should be part of ContextMenuContextData
https://bugs.webkit.org/show_bug.cgi?id=150182

Reviewed by Andreas Kling.

  • Shared/ContextMenuContextData.cpp:

(WebKit::ContextMenuContextData::ContextMenuContextData):
(WebKit::ContextMenuContextData::encode):
(WebKit::ContextMenuContextData::decode):

  • Shared/ContextMenuContextData.h:

(WebKit::ContextMenuContextData::menuLocation):
(WebKit::ContextMenuContextData::menuItems):
(WebKit::ContextMenuContextData::ContextMenuContextData):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showContextMenu):
(WebKit::WebPageProxy::internalShowContextMenu):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/mac/WebPageProxyMac.mm:

(WebKit::WebPageProxy::showSelectionServiceMenu):

  • WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):

12:54 PM Changeset in webkit [191130] by mark.lam@apple.com
  • 6 edits
    2 adds in trunk/Source/JavaScriptCore

Add MASM_PROBE support for ARM64.
https://bugs.webkit.org/show_bug.cgi?id=150128

Reviewed by Michael Saboff.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • assembler/ARM64Assembler.h:
  • Convert the ARM64 registers enum list into a macro list so that we can use it elsewhere e.g. to declare fields in the probe CPUState. Also de-tabbed the contents of the ARM64Registers namespace since the enum list change touches almost all of it anyway. This reduces the amount of complaints from the style checker.
  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::CPUState::registerName):
(JSC::AbstractMacroAssembler::CPUState::registerValue):

  • Change CPUState methods to allow for registers ID that do not map to one of its fields. This is needed because ARM64's registers include aliases for some register names. The CPUState will not allocate separate storage for the aliases.
  • assembler/MacroAssemblerARM64.cpp: Added.

(JSC::arm64ProbeTrampoline):

  • Unlike the probe mechanism for other CPUs, the ARM64 implementation does not allow the probe function to modify the sp and pc registers. We insert this wrapper function between ctiMasmProbeTrampoline() and the user's probe function so that we can check if the user tried to modify sp and pc. If so, we will print an error message so that we can alert the user that we don't support that on ARM64.

See the comment in ctiMasmProbeTrampoline() in JITStubsARM64.h for details
on why we cannot support sp and pc modifications by the probe function.

(JSC::MacroAssemblerARM64::probe):

  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::repatchCall):
(JSC::MacroAssemblerARM64::makeBranch):

  • jit/JITStubs.cpp:
  • jit/JITStubsARM64.h: Added.
12:52 PM Changeset in webkit [191129] by Alan Bujtas
  • 1 edit
    6 adds in trunk/LayoutTests

[Win] Update anonymous table results for Win port.

Unreviewed gardening.

  • platform/win/css2.1/tables/table-anonymous-objects-103-expected.txt: Added.
  • platform/win/css2.1/tables/table-anonymous-objects-104-expected.txt: Added.
  • platform/win/css2.1/tables/table-anonymous-objects-117-expected.txt: Added.
  • platform/win/css2.1/tables/table-anonymous-objects-118-expected.txt: Added.
  • platform/win/css2.1/tables/table-anonymous-objects-119-expected.txt: Added.
  • platform/win/css2.1/tables/table-anonymous-objects-120-expected.txt: Added.
12:48 PM Changeset in webkit [191128] by hyatt@apple.com
  • 29 edits
    380 adds in trunk

Implement CSS Variables.
https://bugs.webkit.org/show_bug.cgi?id=19660

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/css/custom-properties and fast/css/variables.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:

Add CSSVariableValue.cpp and CSSVariableDependentValue.cpp to builds.

  • css/CSSCalculationValue.cpp:

(WebCore::hasDoubleValue):
Handle the new CSS_PARSER_WHITESPACE value.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::customPropertyValue):
Patched to make sure style is updated so that dynamic changes to custom properties are reflected
immediately when querying values.

(WebCore::CSSComputedStyleDeclaration::length):
(WebCore::CSSComputedStyleDeclaration::item):
The custom properties table is a reference and not a pointer now.

  • css/CSSCustomPropertyValue.h:

(WebCore::CSSCustomPropertyValue::create):
(WebCore::CSSCustomPropertyValue::createInvalid):
(WebCore::CSSCustomPropertyValue::customCSSText):
(WebCore::CSSCustomPropertyValue::equals):
(WebCore::CSSCustomPropertyValue::isInvalid):
(WebCore::CSSCustomPropertyValue::containsVariables):
(WebCore::CSSCustomPropertyValue::value):
(WebCore::CSSCustomPropertyValue::CSSCustomPropertyValue):
The CSSCustomPropertyValue represents a custom property/value pair in the back end. It holds on
to both the property name and a CSSValueList that has the original parser terms. This class also
doubles as the invalid-at-compute-time value for custom properties when they contain cycles, etc.

  • css/CSSFunctionValue.cpp:

(WebCore::CSSFunctionValue::buildParserValueSubstitutingVariables):

  • css/CSSFunctionValue.h:

(WebCore::CSSFunctionValue::buildParserValueSubstitutingVariables):
Hands back a CSSParserValue for a function with variables replaced with their real values (or fallback).

  • css/CSSGrammar.y.in:

Many changes to support the var() syntax and to handle error conditions and cases.

  • css/CSSParser.cpp:

(WebCore::filterProperties):
Null check the value here. Shouldn't happen, but being paranoid.

(WebCore::CSSParser::parseVariableDependentValue):
This function converts a CSSValueList back into a CSSParserValueList and then passes
it off to the parser. If the result parses, successfully, then the parsed CSSValue is handed back.

(WebCore::CSSParser::parseValue):
Detect when a property value contains variables and simply make a CSSVariableDependentValue to hold
a copy of the parser value list (as a CSSValueList). We defer parsing the list until compute-time
when we know the values of the variables to use.

(WebCore::CSSParser::parseCustomPropertyDeclaration):
Add support for inherit, initial and variable references in custom properties.

(WebCore::CSSParser::detectFunctionTypeToken):
Add support for detection of the "var" token.

(WebCore::CSSParser::realLex):
Fix the parsing of custom properties to allow "--" and to allow them to start with digits, e.g., "--0".

  • css/CSSParser.h:

Add parseVariableDependentValue function for handling variable substitution and subsequent parsing
of the resolved parser value list.

  • css/CSSParserValues.cpp:

(WebCore::CSSParserValueList::containsVariables):
Get rid of the toString() function (no longer needed) and replace it with containsVariables(). This
check is used to figure out if a parser value list has variables and thus needs to defer parsing
until later.

(WebCore::CSSParserValue::createCSSValue):
Add support for the creation of values for variables, CSSVariableValues.

(WebCore::CSSParserValueList::toString): Deleted.
No longer needed.

  • css/CSSParserValues.h:

Add CSSParserVariable as a new kind of parser value. This represents a var() that is encountered
during parsing. It is similar to a function except it has to hold both the reference (custom property name)
and fallback arguments.

  • css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::formatNumberForCustomCSSText):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):
(WebCore::CSSPrimitiveValue::equals):
Add support for CSS_PARSER_WHITESPACE as a way of preserving whitespace as a parsed item (variables can
be only whitespace, and this has to be retained).

(WebCore::CSSPrimitiveValue::buildParserValue):
Conversion from a CSSPrimitiveValue back into a parser value is handled by this function.

  • css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isParserOperator):
(WebCore::CSSPrimitiveValue::parserOperator):
Add ability to get parser operator info. Add the buildParserValue declaration.

  • css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):
(WebCore::CSSValue::isInvalidCustomPropertyValue):

  • css/CSSValue.h:

Add support for variable values and variable dependent values.

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::customCSSText):
Improve serialization to not output extra spaces when a comma operator is a value.

(WebCore::CSSValueList::containsVariables):
Whether or not a CSSVariableValue can be found somewhere within the list (or its descendants).

(WebCore::CSSValueList::checkVariablesForCycles):
Called to check variables for cycles.

(WebCore::CSSValueList::buildParserValueSubstitutingVariables):
(WebCore::CSSValueList::buildParserValueListSubstitutingVariables):
Functions that handle converting the value list to a parser value list while making
variable substitutions along the way.

  • css/CSSValueList.h:

Add the new buildParserXXX functions.

  • css/CSSVariableDependentValue.cpp: Added.

(WebCore::CSSVariableDependentValue::checkVariablesForCycles):

  • css/CSSVariableDependentValue.h: Added.

(WebCore::CSSVariableDependentValue::create):
(WebCore::CSSVariableDependentValue::customCSSText):
(WebCore::CSSVariableDependentValue::equals):
(WebCore::CSSVariableDependentValue::propertyID):
(WebCore::CSSVariableDependentValue::valueList):
(WebCore::CSSVariableDependentValue::CSSVariableDependentValue):
This value represents a list of terms that have not had variables substituted yet. The list
is held by the value so that it can be converted back into a parser value list once the
variable values are known.

  • css/CSSVariableValue.cpp: Added.

(WebCore::CSSVariableValue::CSSVariableValue):
(WebCore::CSSVariableValue::customCSSText):
(WebCore::CSSVariableValue::equals):
(WebCore::CSSVariableValue::buildParserValueListSubstitutingVariables):

  • css/CSSVariableValue.h: Added.

(WebCore::CSSVariableValue::create):
(WebCore::CSSVariableValue::name):
(WebCore::CSSVariableValue::fallbackArguments):
This value represents a var() itself. It knows how to do the substitution of the variable
value and to apply fallback if that value is not present.

  • css/StyleProperties.cpp:

(WebCore::StyleProperties::getPropertyValue):
(WebCore::StyleProperties::borderSpacingValue):
(WebCore::StyleProperties::getLayeredShorthandValue):
(WebCore::StyleProperties::getShorthandValue):
(WebCore::StyleProperties::getCommonValue):
(WebCore::StyleProperties::getPropertyCSSValue):
(WebCore::StyleProperties::getPropertyCSSValueInternal):
(WebCore::StyleProperties::asText):
(WebCore::StyleProperties::copyPropertiesInSet):

  • css/StyleProperties.h:

Patched to factor property fetching into an internal method so that variables can work with shorthands
in the CSS OM.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::applyProperty):
Resolve variable values at compute time. If they fail to resolve, use inherit or initial as the
value (depending on whether the property inherits by default).

(WebCore::StyleResolver::resolvedVariableValue):
Helper function that calls parseVariableDependentValue and gets the resolved result.

(WebCore::StyleResolver::applyCascadedProperties):
After custom properties have been collected, we check for cycles and perform variable substitutions.
This way we get all the variables replaced before we inherit down the style tree.

  • css/StyleResolver.h:

Add resolvedVariableValue declaration.

  • css/makeprop.pl:

Make sure custom properties are inherited by default.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::checkVariablesInCustomProperties):
This function handles updating variables with cycles to be invalid in the RenderStyle. It then also
handles the replacement of variables found in custom properties with resolved values. All custom
properties are either invalid or are real non-variable-dependent value lists after this function
completes.

  • rendering/style/RenderStyle.h:

Add checkVariablesInCustomProperties declaration.

  • rendering/style/StyleCustomPropertyData.h:

(WebCore::StyleCustomPropertyData::create):
(WebCore::StyleCustomPropertyData::copy):
(WebCore::StyleCustomPropertyData::operator==):
(WebCore::StyleCustomPropertyData::operator!=):
(WebCore::StyleCustomPropertyData::setCustomPropertyValue):
(WebCore::StyleCustomPropertyData::getCustomPropertyValue):
(WebCore::StyleCustomPropertyData::values):
(WebCore::StyleCustomPropertyData::hasCustomProperty):
(WebCore::StyleCustomPropertyData::containsVariables):
(WebCore::StyleCustomPropertyData::setContainsVariables):
(WebCore::StyleCustomPropertyData::StyleCustomPropertyData):
Miscellaneous cleanup, and the addition of whether or not the properties still contain variable
dependent values that need to be resolved.

LayoutTests:

  • fast/css/custom-properties/inheritance-expected.html: Added.
  • fast/css/custom-properties/inheritance.html: Added.
  • fast/css/variables: Added.
  • fast/css/variables/custom-property-computed-style-access-expected.html: Added.
  • fast/css/variables/custom-property-computed-style-access.html: Added.
  • fast/css/variables/custom-property-dynamic-update-expected.html: Added.
  • fast/css/variables/custom-property-dynamic-update.html: Added.
  • fast/css/variables/custom-property-simple-cycle-expected.html: Added.
  • fast/css/variables/custom-property-simple-cycle.html: Added.
  • fast/css/variables/inherited-fallback-expected.html: Added.
  • fast/css/variables/inherited-fallback.html: Added.
  • fast/css/variables/invalid-reference-expected.html: Added.
  • fast/css/variables/invalid-reference.html: Added.
  • fast/css/variables/rule-property-get-css-value-expected.html: Added.
  • fast/css/variables/rule-property-get-css-value.html: Added.
  • fast/css/variables/rule-property-get-expected.html: Added.
  • fast/css/variables/rule-property-get.html: Added.
  • fast/css/variables/rule-serialization-expected.html: Added.
  • fast/css/variables/rule-serialization.html: Added.
12:46 PM Changeset in webkit [191127] by Csaba Osztrogonác
  • 4 edits in trunk/Source/WebCore
Fix the !(ENABLE(SHADOW_DOM)
ENABLE(DETAILS_ELEMENT)) build after r191112

https://bugs.webkit.org/show_bug.cgi?id=150175

Reviewed by Antti Koivisto.

  • dom/ComposedTreeAncestorIterator.h:

(WebCore::ComposedTreeAncestorIterator::traverseParent):

  • dom/ComposedTreeIterator.cpp:

(WebCore::ComposedTreeIterator::initializeShadowStack):

  • dom/Element.cpp:

(WebCore::Element::childrenChanged):

12:34 PM Changeset in webkit [191126] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Get rid of the only once used isIntegerArray function
https://bugs.webkit.org/show_bug.cgi?id=150170

Reviewed by Geoffrey Garen.

  • page/Crypto.cpp:

(WebCore::Crypto::getRandomValues):

12:31 PM Changeset in webkit [191125] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Fix some typos in comments.
https://bugs.webkit.org/show_bug.cgi?id=150181

Rubber stamped by Michael Saboff.

  • jit/JITStubsARM.h:
  • jit/JITStubsARMv7.h:
11:38 AM Changeset in webkit [191124] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Rebaselining css2.1/tables/table-anonymous-objects-045.xht for win
https://bugs.webkit.org/show_bug.cgi?id=150125

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-15
Reviewed by Zalan Bujtas.

  • platform/win/css2.1/tables/table-anonymous-objects-045-expected.txt:
11:37 AM Changeset in webkit [191123] by mark.lam@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Refactoring: give the MASM probe CPUState methods shorter names.
https://bugs.webkit.org/show_bug.cgi?id=150177

Reviewed by Michael Saboff.

The existing names are longer than they need to be. Renaming them as follows:

For GPR, registerName ==> gprName
For GPR, registerValue ==> gpr
For FPR, registerName ==> fprName
For FPR, registerValue ==> fpr

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::CPUState::gprName):
(JSC::AbstractMacroAssembler::CPUState::fprName):
(JSC::AbstractMacroAssembler::CPUState::gpr):
(JSC::AbstractMacroAssembler::CPUState::fpr):
(JSC::AbstractMacroAssembler::CPUState::registerName): Deleted.
(JSC::AbstractMacroAssembler::CPUState::registerValue): Deleted.

  • assembler/MacroAssemblerPrinter.cpp:

(JSC::printRegister):
(JSC::printMemory):

  • Updated to use the new names.
11:09 AM Changeset in webkit [191122] by Alan Bujtas
  • 1 edit
    6 adds in trunk/LayoutTests

[iOS] Update anonymous table results for iOS port.

Unreviewed gardening.

  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-103-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-104-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-117-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-118-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-119-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-120-expected.txt: Added.
11:02 AM Changeset in webkit [191121] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Try to fix the iOS build.

  • page/EventHandler.h:
10:45 AM Changeset in webkit [191120] by youenn.fablet@crf.canon.fr
  • 4 edits in trunk

Update ImportExpectations according currently imported wpt tests
https://bugs.webkit.org/show_bug.cgi?id=150158

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • resources/ImportExpectations:

Tools:

  • Scripts/webkitpy/w3c/test_downloader.py:

(TestDownloader.copy_tests): ensuring that directories marked as [ Skip ] are not copied.

10:30 AM Changeset in webkit [191119] by Alan Bujtas
  • 3 edits
    12 adds in trunk

Anonymous table objects: Collapse anonymous table rows.
https://bugs.webkit.org/show_bug.cgi?id=150154

Reviewed by David Hyatt.

Merge anonymous table rows when they are not needed anymore.
Generated table rows can be collapsed into one when there's no
non-generated sibling table row left in the tree.

Import W3C CSS2.1 anonymous table tests.

Source/WebCore:

  • rendering/RenderObject.cpp:

(WebCore::collapseAnonymousTableRowsIfNeeded):
(WebCore::RenderObject::destroyAndCleanupAnonymousWrappers):

LayoutTests:

  • css2.1/tables/table-anonymous-objects-103.xht: Added.
  • css2.1/tables/table-anonymous-objects-104.xht: Added.
  • css2.1/tables/table-anonymous-objects-117.xht: Added.
  • css2.1/tables/table-anonymous-objects-118.xht: Added.
  • css2.1/tables/table-anonymous-objects-119.xht: Added.
  • css2.1/tables/table-anonymous-objects-120.xht: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-103-expected.txt: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-104-expected.txt: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-117-expected.txt: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-118-expected.txt: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-119-expected.txt: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-120-expected.txt: Added.
10:23 AM Changeset in webkit [191118] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Un-indent contents of the WebCore namespace
in GraphicsContext.h. No code changes.

  • platform/graphics/GraphicsContext.h:
10:20 AM Changeset in webkit [191117] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Move ImageBuffer:clip() into GraphicsContextCG
https://bugs.webkit.org/show_bug.cgi?id=150140

Reviewed by Zalan Bujtas.

Move the guts of CG's ImageBuffer:clip() into GraphicsContextCG.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::GraphicsContext::clipToNativeImage):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::clip):

9:54 AM Changeset in webkit [191116] by Brent Fulgham
  • 2 edits in trunk/LayoutTests

[Win] Unreviewed gardenining after r190816.

Update Windows expectation to match new mac test expectation.

  • platform/win/svg/custom/simple-text-double-shadow-expected.txt:
9:44 AM Changeset in webkit [191115] by rniwa@webkit.org
  • 2 edits in trunk/Websites/perf.webkit.org

Unreviewed fix of a test after r190687.

  • tests/admin-regenerate-manifest.js:
9:41 AM Changeset in webkit [191114] by beidson@apple.com
  • 38 edits
    2 adds in trunk

Modern IDB: Add basic transaction committing.
https://bugs.webkit.org/show_bug.cgi?id=150147

Reviewed by Alex Christensen.

Source/WebCore:

Test: storage/indexeddb/modern/opendatabase-versions.html

  • Modules/indexeddb/IDBTransaction.h:
  • Modules/indexeddb/IndexedDB.h:
  • Modules/indexeddb/client/IDBConnectionToServer.cpp:

(WebCore::IDBClient::IDBConnectionToServer::commitTransaction):
(WebCore::IDBClient::IDBConnectionToServer::didCommitTransaction):

  • Modules/indexeddb/client/IDBConnectionToServer.h:
  • Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
  • Modules/indexeddb/client/IDBDatabaseImpl.cpp:

(WebCore::IDBClient::IDBDatabase::startVersionChangeTransaction):
(WebCore::IDBClient::IDBDatabase::commitTransaction):
(WebCore::IDBClient::IDBDatabase::didCommitTransaction):
(WebCore::IDBClient::IDBDatabase::didAbortTransaction):
(WebCore::IDBClient::IDBDatabase::didCommitOrAbortTransaction):

  • Modules/indexeddb/client/IDBDatabaseImpl.h:
  • Modules/indexeddb/client/IDBFactoryImpl.cpp:

(WebCore::IDBClient::IDBFactory::open):

  • Modules/indexeddb/client/IDBOpenDBRequestImpl.cpp:

(WebCore::IDBClient::IDBOpenDBRequest::onSuccess):

  • Modules/indexeddb/client/IDBOpenDBRequestImpl.h:
  • Modules/indexeddb/client/IDBTransactionImpl.cpp:

(WebCore::IDBClient::IDBTransaction::IDBTransaction):
(WebCore::IDBClient::IDBTransaction::db):
(WebCore::IDBClient::IDBTransaction::hasPendingActivity):
(WebCore::IDBClient::IDBTransaction::isActive):
(WebCore::IDBClient::IDBTransaction::scheduleOperationTimer):
(WebCore::IDBClient::IDBTransaction::operationTimerFired):
(WebCore::IDBClient::IDBTransaction::commit):
(WebCore::IDBClient::IDBTransaction::didCommit):
(WebCore::IDBClient::IDBTransaction::fireOnComplete):
(WebCore::IDBClient::IDBTransaction::fireOnAbort):
(WebCore::IDBClient::IDBTransaction::enqueueEvent):
(WebCore::IDBClient::IDBTransaction::dispatchEvent):

  • Modules/indexeddb/client/IDBTransactionImpl.h:

(WebCore::IDBClient::IDBTransaction::database):

  • Modules/indexeddb/legacy/LegacyTransaction.cpp:

(WebCore::LegacyTransaction::db):

  • Modules/indexeddb/legacy/LegacyTransaction.h:
  • Modules/indexeddb/server/IDBConnectionToClient.cpp:

(WebCore::IDBServer::IDBConnectionToClient::didCommitTransaction):

  • Modules/indexeddb/server/IDBConnectionToClient.h:
  • Modules/indexeddb/server/IDBConnectionToClientDelegate.h:
  • Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::registerTransaction):
(WebCore::IDBServer::IDBServer::unregisterTransaction):
(WebCore::IDBServer::IDBServer::commitTransaction):

  • Modules/indexeddb/server/IDBServer.h:
  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::generateUniqueCallbackIdentifier):
(WebCore::IDBServer::UniqueIDBDatabase::storeCallback):
(WebCore::IDBServer::UniqueIDBDatabase::commitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::performCommitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformCommitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::performErrorCallback):
(WebCore::IDBServer::UniqueIDBDatabase::startVersionChangeTransaction): Deleted.

  • Modules/indexeddb/server/UniqueIDBDatabase.h:

(WebCore::IDBServer::UniqueIDBDatabase::server):

  • Modules/indexeddb/server/UniqueIDBDatabaseConnection.cpp:

(WebCore::IDBServer::UniqueIDBDatabaseConnection::createVersionChangeTransaction):
(WebCore::IDBServer::UniqueIDBDatabaseConnection::didCommitTransaction):

  • Modules/indexeddb/server/UniqueIDBDatabaseConnection.h:
  • Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:

(WebCore::IDBServer::UniqueIDBDatabaseTransaction::UniqueIDBDatabaseTransaction):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::~UniqueIDBDatabaseTransaction):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::commit):

  • Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:
  • Modules/indexeddb/shared/IDBDatabaseInfo.h:

(WebCore::IDBDatabaseInfo::setVersion):

  • Modules/indexeddb/shared/IDBError.cpp:

(WebCore::IDBError::isolatedCopy):

  • Modules/indexeddb/shared/IDBError.h:
  • Modules/indexeddb/shared/IDBRequestData.h:
  • Modules/indexeddb/shared/IDBResourceIdentifier.cpp:

(WebCore::IDBResourceIdentifier::isolatedCopy):

  • Modules/indexeddb/shared/IDBResourceIdentifier.h:
  • Modules/indexeddb/shared/InProcessIDBServer.cpp:

(WebCore::InProcessIDBServer::didCommitTransaction):
(WebCore::InProcessIDBServer::commitTransaction):

  • Modules/indexeddb/shared/InProcessIDBServer.h:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/CrossThreadCopier.cpp:

(WebCore::IDBResourceIdentifier>::copy):
(WebCore::IDBError>::copy):

  • platform/CrossThreadCopier.h:

LayoutTests:

  • storage/indexeddb/modern/opendatabase-versions-expected.txt: Added.
  • storage/indexeddb/modern/opendatabase-versions.html: Added.
9:08 AM Changeset in webkit [191113] by dbates@webkit.org
  • 4 edits
    12 adds in trunk

[iOS] DOM click event may not be dispatched when page has :active style and <input type="search">
https://bugs.webkit.org/show_bug.cgi?id=144451
<rdar://problem/23099482>

Reviewed by Simon Fraser.

Source/WebCore:

Fixes an issue where a DOM click event is not dispatched to an element in a subframe on a page
that has a <input type="search"> and defines a CSS :active pseudo-class for the HTML body element.

On iOS we only dispatch a DOM click event if the content does not change as part
of dispatching a DOM mousemove event at the tapped element. In particular, we do not
dispatch a DOM click event if there is a visibility change to some element on the page
as part of dispatching a mousemove event at the tapped element. For a web page
that specifies CSS :active pseudo-class and contains a search field, applying/unapplying
this pseudo-class as part of dispatching a DOM mousemove event may cause the
visibility of the search field cancel button to change; => a DOM click event will not
be dispatched to the tapped element.

Tests: fast/events/can-click-element-on-page-with-active-pseudo-class-and-search-field.html

fast/forms/search/search-cancel-button-visible-when-input-becomes-disabled.html
fast/forms/search/search-cancel-button-visible-when-input-becomes-readonly.html
fast/forms/search/search-cancel-in-formerly-invisible-element.html
fast/forms/search/search-cancel-toggle-visibility-initially-hidden.html
fast/forms/search/search-cancel-toggle-visibility-initially-visible.html

  • rendering/RenderSearchField.cpp:

(WebCore::RenderSearchField::updateCancelButtonVisibility): Write logic for determining
whether the visibility of the cancel button changed in terms of m_isCancelButtonVisible
instead of querying for the current style data as the latter is overwritten on a full
style recalculation.
(WebCore::RenderSearchField::RenderSearchField): Deleted.
(WebCore::RenderSearchField::visibilityForCancelButton): Deleted.

  • rendering/RenderSearchField.h: Define instance variable m_isCancelButtonVisible to

store the visibility state of the cancel button.

LayoutTests:

Add a test to ensure that a DOM click event is dispatched to an element in a subframe on a page
with a search field and that specifies a CSS :active pseudo-class that changes the tap highlight
color.

Additionally, add tests to ensure we update the cancel button visibility whenever the visibility
of the search field changes.

  • fast/events/can-click-element-on-page-with-active-pseudo-class-and-search-field-expected.txt: Added.
  • fast/events/can-click-element-on-page-with-active-pseudo-class-and-search-field.html: Added.
  • fast/forms/search/search-cancel-button-visible-when-input-becomes-disabled-expected.html: Added.
  • fast/forms/search/search-cancel-button-visible-when-input-becomes-disabled.html: Added.
  • fast/forms/search/search-cancel-button-visible-when-input-becomes-readonly-expected.html: Added.
  • fast/forms/search/search-cancel-button-visible-when-input-becomes-readonly.html: Added.
  • fast/forms/search/search-cancel-in-formerly-invisible-element-expected.html: Added.
  • fast/forms/search/search-cancel-in-formerly-invisible-element.html: Added.
  • fast/forms/search/search-cancel-toggle-visibility-initially-hidden-expected.html: Added.
  • fast/forms/search/search-cancel-toggle-visibility-initially-hidden.html: Added.
  • fast/forms/search/search-cancel-toggle-visibility-initially-visible-expected.html: Added.
  • fast/forms/search/search-cancel-toggle-visibility-initially-visible.html: Added.
8:12 AM Changeset in webkit [191112] by Antti Koivisto
  • 14 edits
    1 add in trunk/Source/WebCore

Implement iterator for traversing composed ancestors
https://bugs.webkit.org/show_bug.cgi?id=150162

Reviewed by Andreas Kling.

The existing general purpose ComposedTreeIterator can traverse parent chain but not efficiently
(since it builds stack). Add a separate stackless iterator for ancestor chain traversal.

  • WebCore.xcodeproj/project.pbxproj:
  • dom/ComposedTreeAncestorIterator.h: Added.

(WebCore::ComposedTreeAncestorIterator::operator*):
(WebCore::ComposedTreeAncestorIterator::operator->):
(WebCore::ComposedTreeAncestorIterator::operator==):
(WebCore::ComposedTreeAncestorIterator::operator!=):
(WebCore::ComposedTreeAncestorIterator::operator++):
(WebCore::ComposedTreeAncestorIterator::get):
(WebCore::ComposedTreeAncestorIterator::ComposedTreeAncestorIterator):
(WebCore::ComposedTreeAncestorIterator::traverseParent):
(WebCore::ComposedTreeAncestorAdapter::ComposedTreeAncestorAdapter):
(WebCore::ComposedTreeAncestorAdapter::begin):
(WebCore::ComposedTreeAncestorAdapter::end):
(WebCore::ComposedTreeAncestorAdapter::first):
(WebCore::composedTreeAncestors):

  • dom/ComposedTreeIterator.h:
  • dom/ContainerNode.h:

(WebCore::Node::highestAncestor):
(WebCore::Node::isTreeScope):
(WebCore::Node::needsNodeRenderingTraversalSlowPath): Deleted.

With NodeRenderingTraversal::parent removed this bit is no longer used.

  • dom/Element.cpp:

(WebCore::Element::shadowRoot):
(WebCore::Element::addShadowRoot):
(WebCore::shouldUseNodeRenderingTraversalSlowPath): Deleted.
(WebCore::Element::resetNeedsNodeRenderingTraversalSlowPath): Deleted.

  • dom/Element.h:

(WebCore::Element::didAddUserAgentShadowRoot):
(WebCore::Element::alwaysCreateUserAgentShadowRoot):

  • dom/Node.cpp:

(WebCore::Node::derefEventTarget):
(WebCore::Node::updateAncestorsForStyleRecalc):
(WebCore::traverseStyleParent): Deleted.
(WebCore::traverseFirstStyleParent): Deleted.

Switch to iterator interface.

  • dom/Node.h:

(WebCore::Node::isDocumentFragment):
(WebCore::Node::isShadowRoot):
(WebCore::Node::isNamedFlowContentNode):
(WebCore::Node::hasCustomStyleResolveCallbacks):
(WebCore::Node::setHasCustomStyleResolveCallbacks):
(WebCore::Node::setTreeScope):
(WebCore::Node::setStyleChange):
(WebCore::Node::setNeedsNodeRenderingTraversalSlowPath): Deleted.

  • dom/NodeRenderingTraversal.cpp:

(WebCore::NodeRenderingTraversal::traverseParent):
(WebCore::NodeRenderingTraversal::traverseFirstChild):
(WebCore::NodeRenderingTraversal::traverseLastChild):
(WebCore::NodeRenderingTraversal::traversePreviousSibling):
(WebCore::NodeRenderingTraversal::nextInScope):
(WebCore::NodeRenderingTraversal::previousInScope):
(WebCore::NodeRenderingTraversal::parentInScope):
(WebCore::NodeRenderingTraversal::lastChildInScope):
(WebCore::NodeRenderingTraversal::parentSlow): Deleted.

  • dom/NodeRenderingTraversal.h:

(WebCore::NodeRenderingTraversal::parent): Deleted.

No longer used.

  • html/HTMLSummaryElement.cpp:
  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::isChildAllowed):

Switch to iterator interface.

  • style/RenderTreePosition.cpp:
  • style/StyleResolveTree.cpp:

(WebCore::Style::updateTextRendererAfterContentChange):

Switch to iterator interface.

7:54 AM Changeset in webkit [191111] by eunmi15.lee@samsung.com
  • 2 edits in trunk/Tools

Unreviewed, Update my email address.

  • Scripts/webkitpy/common/config/contributors.json:
7:35 AM Changeset in webkit [191110] by Yusuke Suzuki
  • 8 edits
    2 adds in trunk/Source/JavaScriptCore

[ES6] Class expression should have lexical environment that has itself as an imutable binding
https://bugs.webkit.org/show_bug.cgi?id=150089

Reviewed by Geoffrey Garen.

According to ES6 spec, class expression has its own lexical environment that holds itself
as an immutable binding[1] (section 14.5.14 step 2, 3, 4, 23)

As a result, even if the binding declared in the outer scope is overridden, methods inside
class expression can refer its class by the class name.

[1]: http://ecma-international.org/ecma-262/6.0/#sec-runtime-semantics-classdefinitionevaluation

  • bytecompiler/NodesCodegen.cpp:

(JSC::ClassExprNode::emitBytecode):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createClassExpr):

  • parser/NodeConstructors.h:

(JSC::ClassExprNode::ClassExprNode):

  • parser/Nodes.h:
  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createClassExpr):

  • tests/es6.yaml:
  • tests/stress/class-expression-generates-environment.js: Added.

(shouldBe):
(shouldThrow):
(prototype.method):
(staticMethod):
(A.prototype.method):
(A.staticMethod):
(A):

  • tests/stress/class-expression-should-be-tdz-in-heritage.js: Added.

(shouldThrow):
(shouldThrow.A):

3:19 AM Changeset in webkit [191109] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.10.2

WebKitGTK+ 2.10.2

3:19 AM Changeset in webkit [191108] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.10

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.10.2 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.10.2
2:17 AM Changeset in webkit [191107] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2

Merge r191102 - Unreviewed. Fix wrong #ifdef added in r190615.

This disabled accelerated compositing unconditionally.

  • UIProcess/gtk/WebPreferencesGtk.cpp:

(WebKit::WebPreferences::platformInitializeStore):

2:15 AM Changeset in webkit [191106] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.10/Tools

Merge r191100 - [GTK] Missing return value on TestWebExtensions.cpp:193
https://bugs.webkit.org/show_bug.cgi?id=149755

Unreviewed. Add missing return value.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:

(permissionRequestCallback):

2:14 AM Changeset in webkit [191105] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.10

Merge r191066 - Postpone mutation events before invoke Editor::Command command(Document*, const String&, bool).
https://bugs.webkit.org/show_bug.cgi?id=149299
<rdar://problem/22746995>

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-14
Reviewed by Andreas Kling.

Source/WebCore:

Test: editing/inserting/insert-with-mutation-event.html

This is a merge of a part of Blink r166294:
https://codereview.chromium.org/141103006

  • dom/Document.cpp:

(WebCore::Document::execCommand):

LayoutTests:

  • editing/inserting/insert-with-mutation-event-expected.txt: Added.
  • editing/inserting/insert-with-mutation-event.html: Added.
1:48 AM Changeset in webkit [191104] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.10

Merge r191042 - [GTK][EFL] Fix build with cmake 3.4
https://bugs.webkit.org/show_bug.cgi?id=150117

Explicitely include the CheckIncludeFiles module before using
the CHECK_INCLUDE_FILES command.

Patch by Tomas Popela <tpopela@redhat.com> on 2015-10-14
Reviewed by Žan Doberšek.

  • Source/cmake/FindOpenGL.cmake:
  • Source/cmake/FindWebP.cmake:
  • Source/cmake/OptionsEfl.cmake:
1:18 AM Changeset in webkit [191103] by Carlos Garcia Campos
  • 5 edits in trunk

[GTK] Test WebKit2.RestoreSessionStateContainingFormData fails
https://bugs.webkit.org/show_bug.cgi?id=84960

Reviewed by Žan Doberšek.

Source/WebKit2:

Add a cross-platform implementation to LegacySessionStateCodingNone
using the new SessionState, so that non mac ports can make unit
tests that use the legacy session state coding pass.

  • UIProcess/LegacySessionStateCodingNone.cpp:

(WebKit::encodeLegacySessionState):
(WebKit::decodeLegacySessionState):
(WebKit::encodeLegacySessionHistoryEntryData): Deleted.
(WebKit::decodeLegacySessionHistoryEntryData): Deleted.

Tools:

  • Scripts/run-gtk-tests:

(TestRunner): Unskip tests using SessionState.

  • TestWebKitAPI/PlatformGTK.cmake: Add

WKPageCopySessionStateWithFiltering test.

1:16 AM Changeset in webkit [191102] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix wrong #ifdef added in r190615.

This disabled accelerated compositing unconditionally.

  • UIProcess/gtk/WebPreferencesGtk.cpp:

(WebKit::WebPreferences::platformInitializeStore):

12:53 AM Changeset in webkit [191101] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Unskip several tests that are passing now.

  • platform/gtk/TestExpectations:
12:51 AM Changeset in webkit [191100] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Missing return value on TestWebExtensions.cpp:193
https://bugs.webkit.org/show_bug.cgi?id=149755

Unreviewed. Add missing return value.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestWebExtensions.cpp:

(permissionRequestCallback):

12:32 AM Changeset in webkit [191099] by matthew_hanson@apple.com
  • 4 edits
    3 adds in branches/safari-601.1.46-branch

Merge r191077. rdar://problem/22993325

12:28 AM Changeset in webkit [191098] by matthew_hanson@apple.com
  • 4 edits
    3 adds in branches/safari-601-branch

Merge r191077. rdar://problem/22993325

Oct 14, 2015:

11:46 PM Changeset in webkit [191097] by matthew_hanson@apple.com
  • 4 edits
    2 adds in branches/safari-601.1.46-branch

Merge r191008. rdar://problem/23110743

11:46 PM Changeset in webkit [191096] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merge r190992. rdar://problem/22823232

11:46 PM Changeset in webkit [191095] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-601.1.46-branch

Merge r190570. rdar://problem/23075838

11:46 PM Changeset in webkit [191094] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r190382. rdar://problem/22934241

11:46 PM Changeset in webkit [191093] by matthew_hanson@apple.com
  • 4 edits
    2 adds in branches/safari-601.1.46-branch

Merge r190339. rdar://problem/23075839

11:46 PM Changeset in webkit [191092] by matthew_hanson@apple.com
  • 3 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r190097. rdar://problem/23075843

11:46 PM Changeset in webkit [191091] by matthew_hanson@apple.com
  • 4 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r190007. rdar://problem/23075843

11:46 PM Changeset in webkit [191090] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r188531. rdar://problem/22707497

11:46 PM Changeset in webkit [191089] by matthew_hanson@apple.com
  • 17 edits in branches/safari-601.1.46-branch

Merge r188486. rdar://problem/22707497

11:46 PM Changeset in webkit [191088] by matthew_hanson@apple.com
  • 3 edits in branches/safari-601.1.46-branch/Source/WebCore

Merge r188416. rdar://problem/22803749

11:46 PM Changeset in webkit [191087] by matthew_hanson@apple.com
  • 14 edits
    2 adds in branches/safari-601.1.46-branch

Merge r188390. rdar://problem/22803749

10:30 PM Changeset in webkit [191086] by Yusuke Suzuki
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

[ES6] Class method should not declare any variables to upper scope.
https://bugs.webkit.org/show_bug.cgi?id=150115

Reviewed by Geoffrey Garen.

In the current implementation, class methods attempt to declare variables to an upper scope with their method names.
But this is not specified behavior in the ES6 spec.

And as a result, previously, we attempted to declare variables with invalid identifiers.
For example, class A { 1() { } } attempt to declare a variable with name 1.
This (declaring variables with incorrect names) is not allowed in the lexical environment.
And it fires assertions in https://bugs.webkit.org/show_bug.cgi?id=150089.

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass): Deleted.

  • tests/stress/class-method-does-not-declare-variable-to-upper-scope.js: Added.

(shouldBe):
(A.prototype.method):
(A.staticMethod):
(A):

10:27 PM Changeset in webkit [191085] by ap@apple.com
  • 1 edit
    1 copy in trunk/LayoutTests

[Win] Layout Test http/tests/multipart/multipart-replace-non-html-content.php has extra whitespace
https://bugs.webkit.org/show_bug.cgi?id=150130

Landing a custom expectation. The test still passes, although it surprisingly gets
the extra newline.

  • platform/win/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Copied from LayoutTests/http/tests/multipart/multipart-replace-non-html-content-expected.txt.
10:19 PM Changeset in webkit [191084] by commit-queue@webkit.org
  • 25 edits
    2 adds in trunk/Source

Augment <input type=search>’s recent search history with the time each entry was added,
in order to allow time-based clearing of search history.
https://bugs.webkit.org/show_bug.cgi?id=148388.

Patch by Zhuo Li <zachli@apple.com> on 2015-10-14
Reviewed by Darin Adler.

Replace Vector<String> with Vector<RecentSearch>, where RecentSearch is a struct
Source/WebCore:

that consists search string and time, for recent searches in order to store additional time
information.

  • WebCore.xcodeproj/project.pbxproj: Added SearchPopupMenuCocoa.h and SearchPopupMenuCocoa.mm

and sort the project file.

  • loader/EmptyClients.cpp:

(WebCore::EmptySearchPopupMenu::saveRecentSearches):
(WebCore::EmptySearchPopupMenu::loadRecentSearches):

  • platform/SearchPopupMenu.h:
  • platform/cocoa/SearchPopupMenuCocoa.h: Added methods for SeachPopupMenuMac in WebKit

and WebPageProxyCocoa in WebKit2 to call.

  • platform/cocoa/SearchPopupMenuCocoa.mm: Added.

(WebCore::searchFieldRecentSearchesStorageDirectory): Recent searches with the new structure
are stored in a new location.
(WebCore::searchFieldRecentSearchesPlistPath): Get the path for the plist of the recent
searches entries.
(WebCore::RetainPtr<NSMutableDictionary> readSearchFieldRecentSearchesPlist): Return the
recent searches plist as NSMutableDictionary.
(WebCore::fromNSDatetoSystemClockTime): Convert from NSDate to system_clock::time_point.
(WebCore::fromSystemClockTimetoNSDate): Convert from system_clock::time_point to NSDate.
(WebCore::SearchPopupMenuCocoa::saveRecentSearches): Add a dictionary where it has two pairs
that the first one is the search string and the second one is the time.
(WebCore::SearchPopupMenuCocoa::loadRecentSearches): We expect the recent search item in the
plist to be a two-pair dictionary, and convert the dictionary to the struct RecentSearch.

  • platform/win/SearchPopupMenuWin.cpp:

(WebCore::SearchPopupMenuWin::saveRecentSearches): Only save the RecentSearch's search
string on Windows platform, which is what we used to do.
(WebCore::SearchPopupMenuWin::loadRecentSearches): Since we need to construct a
RecentSearch, we get the string from the app's preferences, and set the time to be
std::chrono::system_clock::time_point::min().

  • platform/win/SearchPopupMenuWin.h:
  • rendering/RenderSearchField.cpp: Now that m_recentSearches are Vector<RecentSearch>,

we cannot use -removeAll with a search string. Use -removeAllMatching instead to remove the
item that has its member search string equal to the search string user inputs.
(WebCore::RenderSearchField::addSearchResult):
(WebCore::RenderSearchField::itemText):

Source/WebKit/ios:

that consists search string and time, for recent searches in order to store additional time information.

  • WebCoreSupport/SearchPopupMenuIOS.cpp:

(SearchPopupMenuIOS::saveRecentSearches):
(SearchPopupMenuIOS::loadRecentSearches):

  • WebCoreSupport/SearchPopupMenuIOS.h:

Source/WebKit/mac:

that consists search string and time, for recent searches in order to store additional time information.

All these new RecentSearches are stored in a plist in which the structure looks like:
Root {

"items": {

autosave name: {

"searches": [

{ "searchString": searchString, "date": date },
...

]

}

}

}

  • WebCoreSupport/SearchPopupMenuMac.h:
  • WebCoreSupport/SearchPopupMenuMac.mm:

(SearchPopupMenuMac::saveRecentSearches): Call saveRecentSearches in WebCore::SearchPopupMenuCocoa.
(SearchPopupMenuMac::loadRecentSearches): Call loadRecentSearches in WebCore::SearchPopupMenuCocoa.
(autosaveKey): Deleted.

Source/WebKit2:

that consists search string and time, for recent searches in order to store additional time
information.

All these new RecentSearches are stored in a plist in which the structure looks like:
Root {

"items": {

autosave name: {

"searches": [

{ "searchString": searchString, "date": date },
...

]

}

}

}

  • Scripts/webkit/messages.py:

(headers_for_type):

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<RecentSearch>::encode): Encode the new struct RecentSearch
(IPC::ArgumentCoder<RecentSearch>::decode): Decode the new struct RecentSearch

  • Shared/WebCoreArgumentCoders.h:
  • UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::saveRecentSearches): Call saveRecentSearches in WebCore::SearchPopupMenuCocoa.
(WebKit::WebPageProxy::loadRecentSearches): Call loadRecentSearches in WebCore::SearchPopupMenuCocoa.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):

  • UIProcess/gtk/WebPageProxyGtk.cpp:

(WebKit::WebPageProxy::saveRecentSearches):
(WebKit::WebPageProxy::loadRecentSearches):

  • WebProcess/WebCoreSupport/WebSearchPopupMenu.cpp:

(WebKit::WebSearchPopupMenu::saveRecentSearches):
(WebKit::WebSearchPopupMenu::loadRecentSearches):

  • WebProcess/WebCoreSupport/WebSearchPopupMenu.h:
9:55 PM Changeset in webkit [191083] by Simon Fraser
  • 14 edits in trunk/Source/WebCore

Use RefPtr<Image> return type for StyleImage::image()
https://bugs.webkit.org/show_bug.cgi?id=150112

Reviewed by Andreas Kling.

Change StyleImage::image() and subclasses to return RefPtr<Image>
instead of a PassRefPtr<Image>.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::image):

  • rendering/RenderImageResource.h:
  • rendering/RenderImageResourceStyleImage.cpp:

(WebCore::RenderImageResourceStyleImage::image):

  • rendering/RenderImageResourceStyleImage.h:
  • rendering/style/StyleCachedImage.cpp:

(WebCore::StyleCachedImage::image):

  • rendering/style/StyleCachedImage.h:
  • rendering/style/StyleCachedImageSet.cpp:

(WebCore::StyleCachedImageSet::image):

  • rendering/style/StyleCachedImageSet.h:
  • rendering/style/StyleGeneratedImage.cpp:

(WebCore::StyleGeneratedImage::image):

  • rendering/style/StyleGeneratedImage.h:
  • rendering/style/StyleImage.h:
  • rendering/style/StylePendingImage.h:
9:47 PM Changeset in webkit [191082] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

Give subclasses of CSSImageGeneratorValue a consistent image() return type
https://bugs.webkit.org/show_bug.cgi?id=150111

Reviewed by Andreas Kling.

CSSImageGeneratorValue and subclasses had signatures of the non-virtual image() function
with mistmatched return types; some returned RefPtr<Image>, and others PassRefPtr<Image>. Make
them all the same.

  • css/CSSImageGeneratorValue.cpp:

(WebCore::CSSImageGeneratorValue::image):

  • css/CSSImageGeneratorValue.h:
  • css/CSSNamedImageValue.cpp:

(WebCore::CSSNamedImageValue::image):

  • css/CSSNamedImageValue.h:
8:53 PM Changeset in webkit [191081] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION: Web Inspector hangs for many seconds when trying to reload page
https://bugs.webkit.org/show_bug.cgi?id=150065

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-14
Reviewed by Mark Lam.

When debugging Web Pages, the same Debugger (PageScriptDebugServer) is
attached to each of the different JSGlobalObjects on the page. This could
mean multiple frames or isolated scripting contexts. Therefore we should
only need to send sourceParsed events to the frontend for scripts within
this new JSGlobalObject, not any JSGlobalObject that has this debugger.

  • debugger/Debugger.cpp:

(JSC::Debugger::attach):
Only send sourceParsed events for Scripts in this JSGlobalObject.

6:21 PM Changeset in webkit [191080] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebCore

Move some EventHandler initialization to the header
https://bugs.webkit.org/show_bug.cgi?id=150139

Reviewed by Andreas Kling.

No new tests, just cleanup.

  • page/EventHandler.cpp:

(WebCore::EventHandler::EventHandler): Deleted.

  • page/EventHandler.h:

Also found one member which was unused, and a few that were uninitialized.
It's likely the uninitialized ones didn't actually cause any trouble because
they are reset in lots of places, but this seems better.

6:06 PM Changeset in webkit [191079] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Remove unimplemented methods in CopiedSpace
https://bugs.webkit.org/show_bug.cgi?id=150143

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-14
Reviewed by Andreas Kling.

  • heap/CopiedSpace.h:
5:57 PM Changeset in webkit [191078] by aestes@apple.com
  • 2 edits in trunk/Tools

[iOS] build-dumprendertree does not build ImageDiff
https://bugs.webkit.org/show_bug.cgi?id=150152

Reviewed by Tim Horton.

run-webkit-tests attempts to build the tools it requires by calling build-dumprendertree and build-webkittestrunner.
On iOS, build-dumprendertree builds the DumpRenderTree.app target, which does not contain the ImageDiff target
as a dependent. If you haven't built ImageDiff by other means (say, because you built the 'All Source' scheme in
WebKit.xcworkspace), tests that rely on image diffing won't work properly.

There's actually no reason to build the DumpRenderTree.app target on iOS; the default aggregate target works
fine on that platform, and results in ImageDiff being built.

  • Scripts/build-dumprendertree:
5:52 PM Changeset in webkit [191077] by commit-queue@webkit.org
  • 4 edits
    3 adds in trunk

[Content Extensions] Make blocked async XHR call onerror
https://bugs.webkit.org/show_bug.cgi?id=146706

Patch by Alex Christensen <achristensen@webkit.org> on 2015-10-14
Reviewed by Brady Eidson.

Source/WebCore:

Test: http/tests/contentextensions/async-xhr-onerror.html

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::createRequest):
(WebCore::XMLHttpRequest::networkError):
(WebCore::XMLHttpRequest::networkErrorTimerFired):
(WebCore::XMLHttpRequest::abortError):

  • xml/XMLHttpRequest.h:

Make a timer that calls networkError in 0 time if a content blocker blocks the asynchronous load.
It is necessary to call setPendingActivity and dropProtection (which calls unsetPendingActivity)
to keep a reference to the XMLHttpRequest alive.

LayoutTests:

  • http/tests/contentextensions/async-xhr-onerror-expected.txt: Added.
  • http/tests/contentextensions/async-xhr-onerror.html: Added.
  • http/tests/contentextensions/async-xhr-onerror.html.json: Added.
5:21 PM Changeset in webkit [191076] by aestes@apple.com
  • 5 edits
    9 adds in trunk

[iOS] QuickLook documents loaded over https do not load their subresources
https://bugs.webkit.org/show_bug.cgi?id=150145
<rdar://problem/22884521>

Reviewed by Alexey Proskuryakov.

Source/WebCore:

When QuickLook generates an HTML preview of a document, subresources are referenced using the x-apple-ql-id scheme,
for which QuickLook installs an NSURLProtocol. If a document is loaded over https, then this scheme needs to be
considered secure in order to avoid mixed content errors.

Test: http/tests/quicklook/secure-document-with-subresources.html

  • platform/SchemeRegistry.cpp:

(WebCore::secureSchemes): Registered QLPreviewProtocol() as a secure scheme.

LayoutTests:

  • TestExpectations: Skipped http/tests/quicklook on all platforms.
  • http/tests/quicklook/resources/secure-document-with-subresources-expected/index.css: Added.
  • http/tests/quicklook/resources/secure-document-with-subresources-expected/index.html: Added.
  • http/tests/quicklook/resources/secure-document-with-subresources.pages: Added.
  • http/tests/quicklook/resources/webkit-icon.tiff: Added.
  • http/tests/quicklook/secure-document-with-subresources-expected.html: Added.
  • http/tests/quicklook/secure-document-with-subresources.html: Added.
  • platform/ios-simulator/TestExpectations: Expected http/tests/quicklook to pass on iOS.
5:11 PM Changeset in webkit [191075] by Brent Fulgham
  • 8 edits in trunk

[Win] Enforce launcher/library naming scheme
https://bugs.webkit.org/show_bug.cgi?id=150124

Reviewed by Alex Christensen.

Source/JavaScriptCore:

{name}Lib.dll instead of {name}.dll.
(wWinMain):

  • shell/PlatformWin.cmake: Add 'Lib' suffix to DLLs.

Tools:

  • DumpRenderTree/PlatformWin.cmake: Use 'Lib' suffix for DLLs.
  • MiniBrowser/win/CMakeLists.txt: Ditto.
  • TestWebKitAPI/PlatformWin.cmake: Ditto.
  • win/DLLLauncher/DLLLauncherMain.cpp:

(wWinMain): Look for a DLL named {name}Lib.dll, rather than the
original {name}.dll.

4:19 PM Changeset in webkit [191074] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests/imported/w3c

Fixing expectations for imported/w3c/web-platform-tests/html/dom/interfaces.html
https://bugs.webkit.org/show_bug.cgi?id=150144.

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-14
Reviewed by Dean Jackson.

  • web-platform-tests/html/dom/interfaces-expected.txt:
3:51 PM Changeset in webkit [191073] by matthew_hanson@apple.com
  • 4 edits
    2 adds in branches/safari-601-branch

Merge r191008. rdar://problem/23111794

2:20 PM Changeset in webkit [191072] by wenson_hsieh@apple.com
  • 5 edits
    2 adds in trunk

Web pages with unscalable viewports shouldn't have a single tap delay
https://bugs.webkit.org/show_bug.cgi?id=149968
<rdar://problem/23054453>

Reviewed by Simon Fraser.

Source/WebKit2:

When a viewport is unscalable (specified through the meta viewport tag) we
do not add a delay to our single tap gesture recognizer. We do this by
disabling or reinitializing the WKContentView's double tap gesture recognizer
when the viewport becomes unscalable or scalable, respectively. A viewport is
deemed unscalable when it has user-scalable = no, or when the minimum scale is
greater than or equal to the maximum scale.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:]):

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _createAndConfigureDoubleTapGestureRecognizer]): Pulled logic

for initializing a double tap gesture recognizer out into a helper function.

(-[WKContentView setupInteraction]):
(-[WKContentView _setDoubleTapGesturesEnabled:]): Turns gesture recognition for double

taps on or off.

LayoutTests:

Add a layout test to check that when a viewport is unscalable (specified through
the meta viewport tag) we do not add a delay to our single tap gesture recognizer.

  • fast/events/ios/unscalable-viewport-clicks-on-doubletap-expected.txt: Added.
  • fast/events/ios/unscalable-viewport-clicks-on-doubletap.html: Added.
2:03 PM Changeset in webkit [191071] by Joseph Pecoraro
  • 7 edits in trunk/Source/WebInspectorUI

Web Inspector: Console SearchBar should work more like ContentBrowser FindBanner
https://bugs.webkit.org/show_bug.cgi?id=149505

Patch by João Oliveira <hello@jxs.pt> on 2015-10-13
Reviewed by Joseph Pecoraro.

Console tab now uses findBanner, adapted LogContentView to use findBanner,
and findBanner to be more agnostic to both usecases, either as fixed, on console tab,
and hideable on other inspector tabs.

  • UserInterface/Views/FindBanner.css:

(.find-banner.console-find-banner):
(.find-banner.console-findbanner input[type="search"]):

  • UserInterface/Views/FindBanner.js:

(WebInspector.FindBanner):
(WebInspector.FindBanner.set targetElement.delayedWork):
(WebInspector.FindBanner.prototype.set targetElement):
(WebInspector.FindBanner.prototype.get showing):
(WebInspector.FindBanner.prototype.focus):
(WebInspector.FindBanner.prototype._clearAndBlur):
(WebInspector.FindBanner.prototype.show.delayedWork):
(WebInspector.FindBanner.prototype.show):
(WebInspector.FindBanner.prototype.hide):
(WebInspector.FindBanner.prototype.get element): Deleted.
(WebInspector.FindBanner.prototype._inputFieldSearch): Deleted.

  • UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView):
(WebInspector.LogContentView.prototype.get navigationItems):
(WebInspector.LogContentView.prototype.handleFindEvent):
(WebInspector.LogContentView.prototype.findBannerRevealPreviousResult):
(WebInspector.LogContentView.prototype.findBannerRevealNextResult):
(WebInspector.LogContentView.prototype._filterMessageElements):
(WebInspector.LogContentView.prototype.findBannerPerformSearch):
(WebInspector.LogContentView.prototype.findBannerSearchCleared):
(WebInspector.LogContentView.prototype.revealNextSearchResult):
(WebInspector.LogContentView.prototype.revealPreviousSearchResult):
(WebInspector.LogContentView.prototype._performSearch):
(WebInspector.LogContentView.prototype.searchBarDidActivate): Deleted.
(WebInspector.LogContentView.prototype._searchTextDidChange): Deleted.

1:52 PM Changeset in webkit [191070] by dino@apple.com
  • 2 edits in trunk/LayoutTests/imported/w3c

Update test result for Canvas2DRenderingContext::commit.

  • web-platform-tests/html/dom/interfaces-expected.txt:
1:45 PM Changeset in webkit [191069] by akling@apple.com
  • 4 edits in trunk

REGRESSION(r190882): Concatenating a character array and an empty string is broken.
<https://webkit.org/b/150135>

Reviewed by Geoffrey Garen.

Source/WTF:

StringAdapter templates for raw character arrays were always using 1 as the array length
in toString().

  • wtf/text/StringConcatenate.h:

Tools:

Add a new WTF API test that covers this issue.

  • TestWebKitAPI/Tests/WTF/StringOperators.cpp:

(TestWebKitAPI::build):
(TestWebKitAPI::TEST):

1:25 PM Changeset in webkit [191068] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.7

New tag.

1:24 PM Changeset in webkit [191067] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

1:11 PM Changeset in webkit [191066] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

Postpone mutation events before invoke Editor::Command command(Document*, const String&, bool).
https://bugs.webkit.org/show_bug.cgi?id=149299
<rdar://problem/22746995>

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-14
Reviewed by Andreas Kling.

Source/WebCore:

Test: editing/inserting/insert-with-mutation-event.html

This is a merge of a part of Blink r166294:
https://codereview.chromium.org/141103006

  • dom/Document.cpp:

(WebCore::Document::execCommand):

LayoutTests:

  • editing/inserting/insert-with-mutation-event-expected.txt: Added.
  • editing/inserting/insert-with-mutation-event.html: Added.
1:10 PM Changeset in webkit [191065] by andersca@apple.com
  • 7 edits in trunk/Source/WebKit2

Remove a message that isn't used by anyone
https://bugs.webkit.org/show_bug.cgi?id=150136

Reviewed by Andreas Kling.

  • UIProcess/API/APILoaderClient.h:

(API::LoaderClient::didRemoveFrameFromHierarchy): Deleted.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageLoaderClient): Deleted.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didRemoveFrameFromHierarchy): Deleted.

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::detachedFromParent2): Deleted.

1:05 PM Changeset in webkit [191064] by dino@apple.com
  • 4 edits
    2 adds in trunk

Implement CanvasRenderingContext2D::commit
https://bugs.webkit.org/show_bug.cgi?id=150110
<rdar://problem/23057398>

Reviewed by Anders Carlsson.

Source/WebCore:

As part of getting as close as possible to the HTML5 specification,
implement the commit() method on 2d canvas, even though it doesn't
do anything.

Test: fast/canvas/commit.html

  • bindings/js/JSCanvasRenderingContext2DCustom.cpp:

(WebCore::JSCanvasRenderingContext2D::commit): Intercept it here to
avoid adding a method to the actual implementation.

  • html/canvas/CanvasRenderingContext2D.idl: Add commit.

LayoutTests:

  • fast/canvas/commit-expected.txt: Added.
  • fast/canvas/commit.html: Added.
1:03 PM Changeset in webkit [191063] by achristensen@apple.com
  • 25 edits
    3 deletes in trunk

Add SPI for reloading without content blockers
https://bugs.webkit.org/show_bug.cgi?id=150058
rdar://problem/22742222

Reviewed by Sam Weinig.

Source/WebCore:

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::reloadWithOverrideEncoding):
(WebCore::FrameLoader::reload):

  • loader/FrameLoader.h:
  • page/Page.h:

(WebCore::Page::userContentController):
(WebCore::Page::userContentExtensionsEnabled): Deleted.
(WebCore::Page::setUserContentExtensionsEnabled): Deleted.

  • replay/UserInputBridge.cpp:

(WebCore::UserInputBridge::loadRequest):
(WebCore::UserInputBridge::reloadFrame):
(WebCore::UserInputBridge::stopLoadingFrame):

  • replay/UserInputBridge.h:

Pass a bool from the reloadWithoutContentBlockers call to the DocumentLoader,
which stores the state of whether the content blockers are enabled or not.
Remove the state from the Page and copying the state from the Page to the DocumentLoader
because that caused issues with the content blockers being re-enabled at the wrong time.

Source/WebKit2:

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageReload):
(WKPageReloadWithoutContentBlockers):
(WKPageReloadFromOrigin):
(WKPageTryClose):
(WKPageSetUserContentExtensionsEnabled):
(WKPageSupportsTextEncoding):

  • UIProcess/API/C/WKPage.h:
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController reload]):
(-[WKBrowsingContextController reloadFromOrigin]):
(-[WKBrowsingContextController applicationNameForUserAgent]):

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView reload]):
(-[WKWebView reloadFromOrigin]):
(-[WKWebView _setUserContentExtensionsEnabled:]):
(-[WKWebView _userContentExtensionsEnabled]):
(-[WKWebView _webProcessIdentifier]):
(-[WKWebView _killWebContentProcess]):
(-[WKWebView _reloadWithoutContentBlockers]):
(-[WKWebView _killWebContentProcessAndResetState]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/API/gtk/WebKitWebView.cpp:

(webkit_web_view_reload):
(webkit_web_view_reload_bypass_cache):

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didHandleContentFilterUnblockNavigation):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::stopLoading):
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::setShouldScaleViewToFitDocument):
(WebKit::WebPageProxy::setUserContentExtensionsEnabled): Deleted.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::userContentExtensionsEnabled): Deleted.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_shouldDispatchFakeMouseMoveEvents):
(WebKit::WebPage::setDefersLoading):
(WebKit::WebPage::reload):
(WebKit::WebPage::goForward):
(WebKit::WebPage::createDocumentLoader):
(WebKit::WebPage::setShouldScaleViewToFitDocument):
(WebKit::WebPage::imageOrMediaDocumentSizeChanged):
(WebKit::WebPage::setUserContentExtensionsEnabled): Deleted.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Tools:

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaResetStateToConsistentValues):

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformConfigureViewForTest):

LayoutTests:

  • http/tests/contentextensions/disable-blocker-expected.txt: Removed.
  • http/tests/contentextensions/disable-blocker.html: Removed.
  • http/tests/contentextensions/disable-blocker.html.json: Removed.

_userContentExtensionsEnabled is going to be removed, and its functionality is what this test tested.

12:52 PM Changeset in webkit [191062] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601-branch/Source/WebCore

Merge r188477. rdar://problem/22801969

12:52 PM Changeset in webkit [191061] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601-branch/Source/WebCore

Merge r188473. rdar://problem/22801969

12:18 PM Changeset in webkit [191060] by youenn.fablet@crf.canon.fr
  • 49 edits in trunk/Source/WebCore

Rename JSDOMWrapper to JSDOMObject and JSDOMWrapperWithImplementation to JSDOMWrapper
https://bugs.webkit.org/show_bug.cgi?id=150120

Reviewed by Sam Weinig.

No change in behavior.

  • bindings/js/DOMWrapperWorld.h:
  • bindings/js/JSDOMBinding.h:

(WebCore::DOMConstructorObject::DOMConstructorObject):
(WebCore::getInlineCachedWrapper):
(WebCore::setInlineCachedWrapper):
(WebCore::clearInlineCachedWrapper):
(WebCore::createWrapper):
(WebCore::getStaticValueSlotEntryWithoutCaching<JSDOMObject>):

  • bindings/js/JSDOMWrapper.cpp:
  • bindings/js/JSDOMWrapper.h:

(WebCore::JSDOMObject::JSDOMObject):
(WebCore::JSDOMWrapper::~JSDOMWrapper):
(WebCore::JSDOMWrapper::JSDOMWrapper):

  • bindings/js/JSElementCustom.cpp:

(WebCore::toJSNewlyCreated):

  • bindings/js/JSNodeCustom.cpp:

(WebCore::createWrapperInline):

  • bindings/js/ScriptWrappable.h:
  • bindings/js/ScriptWrappableInlines.h:

(WebCore::ScriptWrappable::wrapper):
(WebCore::ScriptWrappable::setWrapper):
(WebCore::ScriptWrappable::clearWrapper):

  • bindings/scripts/CodeGeneratorJS.pm:

(GetParentClassName):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObject::JSTestActiveDOMObject):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.h:
  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::JSTestCustomConstructorWithNoInterfaceObject::JSTestCustomConstructorWithNoInterfaceObject):

  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.h:
  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetter::JSTestCustomNamedGetter):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.h:
  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructor::JSTestEventConstructor):

  • bindings/scripts/test/JS/JSTestEventConstructor.h:
  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTarget::JSTestEventTarget):

  • bindings/scripts/test/JS/JSTestEventTarget.h:
  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestException::JSTestException):

  • bindings/scripts/test/JS/JSTestException.h:
  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachable::JSTestGenerateIsReachable):

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.h:
  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterface::JSTestInterface):

  • bindings/scripts/test/JS/JSTestInterface.h:
  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:

(WebCore::JSTestJSBuiltinConstructor::JSTestJSBuiltinConstructor):

  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.h:
  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructor::JSTestNamedConstructor):

  • bindings/scripts/test/JS/JSTestNamedConstructor.h:
  • bindings/scripts/test/JS/JSTestNondeterministic.cpp:

(WebCore::JSTestNondeterministic::JSTestNondeterministic):

  • bindings/scripts/test/JS/JSTestNondeterministic.h:
  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::JSTestObj):

  • bindings/scripts/test/JS/JSTestObj.h:
  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructors::JSTestOverloadedConstructors):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.h:
  • bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::JSTestOverrideBuiltins::JSTestOverrideBuiltins):

  • bindings/scripts/test/JS/JSTestOverrideBuiltins.h:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefs::JSTestTypedefs):

  • bindings/scripts/test/JS/JSTestTypedefs.h:
  • bindings/scripts/test/JS/JSattribute.cpp:

(WebCore::JSattribute::JSattribute):

  • bindings/scripts/test/JS/JSattribute.h:
  • bindings/scripts/test/JS/JSreadonly.cpp:

(WebCore::JSreadonly::JSreadonly):

  • bindings/scripts/test/JS/JSreadonly.h:
  • dom/make_names.pl:

(printWrapperFunctions):
(printWrapperFactoryCppFile):
(printWrapperFactoryHeaderFile):

12:07 PM Changeset in webkit [191059] by keith_miller@apple.com
  • 13 edits
    1 copy
    6 adds in trunk/Source/JavaScriptCore

ES6 Fix TypedArray constructors.
https://bugs.webkit.org/show_bug.cgi?id=149975

Reviewed by Geoffrey Garen.

The ES6 spec requires that any object argument passed to a TypedArray constructor that is not a TypedArray
and has an iterator should use the iterator to construct the TypedArray. To avoid performance regressions related
to iterating we check if the iterator attached to the object points to the generic array iterator and length is a value.
If so, we do not use the iterator since there should be no observable difference. Another other interesting note is
that the ES6 spec has the of and from functions on a shared constructor between all the TypedArray constructors.
When the TypedArray is constructed the expectation is to crawl the prototype chain of the this value
passed to the function. If the function finds a known TypedArray constructor (Int32Array, Float64Array,...) then
it creates a TypedArray of that type. This is implemented by adding a private function (@allocateTypedArray) to each
of the constructors that can be called in order to construct the array. By using the private functions the JIT should
hopefully be able to optimize this to a direct call.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • builtins/TypedArrayConstructor.js: Added.

(of):
(from):
(allocateInt8Array):
(allocateInt16Array):
(allocateInt32Array):
(allocateUint32Array):
(allocateUint16Array):
(allocateUint8Array):
(allocateUint8ClampedArray):
(allocateFloat32Array):
(allocateFloat64Array):

  • runtime/CommonIdentifiers.h:
  • runtime/JSDataView.cpp:

(JSC::JSDataView::setIndex):

  • runtime/JSDataView.h:
  • runtime/JSGenericTypedArrayView.h:

(JSC::JSGenericTypedArrayView::toAdaptorNativeFromValue):

  • runtime/JSGenericTypedArrayViewConstructor.h:
  • runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::finishCreation):
(JSC::JSGenericTypedArrayViewConstructor<ViewClass>::create):
(JSC::constructGenericTypedArrayViewFromIterator):
(JSC::constructGenericTypedArrayView):

  • runtime/JSGenericTypedArrayViewPrototypeFunctions.h:

(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/JSTypedArrayViewConstructor.cpp: Added.

(JSC::JSTypedArrayViewConstructor::JSTypedArrayViewConstructor):
(JSC::JSTypedArrayViewConstructor::finishCreation):
(JSC::JSTypedArrayViewConstructor::create):
(JSC::JSTypedArrayViewConstructor::createStructure):
(JSC::constructTypedArrayView):
(JSC::JSTypedArrayViewConstructor::getConstructData):
(JSC::JSTypedArrayViewConstructor::getCallData):

  • runtime/JSTypedArrayViewConstructor.h: Copied from Source/JavaScriptCore/runtime/JSGenericTypedArrayViewConstructor.h.
  • runtime/JSTypedArrayViewPrototype.cpp:

(JSC::JSTypedArrayViewPrototype::create):

  • tests/es6.yaml:
  • tests/stress/resources/typedarray-constructor-helper-functions.js: Added.

(forEachTypedArray):
(hasSameValues):
(foo):
(testConstructorFunction):
(testConstructor):

  • tests/stress/typedarray-constructor.js: Added.

(A):
(iterator.return.next):
(iterator):
(obj.valueOf):
(iterator2.return.next):
(iterator2):

  • tests/stress/typedarray-from.js: Added.

(even):
(isBigEnoughAndException):

  • tests/stress/typedarray-of.js: Added.
11:57 AM Changeset in webkit [191058] by mark.lam@apple.com
  • 56 edits in trunk

Rename some JSC option names to be more uniform.
https://bugs.webkit.org/show_bug.cgi?id=150127

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Renaming JSC_enableXXX options to JSC_useXXX, and JSC_showXXX options to JSC_dumpXXX.
Also will renaming a few other miscellaneous to options, to abide by this scheme.

Also renaming some functions to match the option names where relevant.

  • API/tests/ExecutionTimeLimitTest.cpp:

(testExecutionTimeLimit):

  • assembler/AbstractMacroAssembler.h:

(JSC::optimizeForARMv7IDIVSupported):
(JSC::optimizeForARM64):
(JSC::optimizeForX86):

  • assembler/LinkBuffer.cpp:

(JSC::shouldDumpDisassemblyFor):
(JSC::LinkBuffer::finalizeCodeWithoutDisassembly):
(JSC::shouldShowDisassemblyFor): Deleted.

  • assembler/LinkBuffer.h:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::jettison):

  • bytecode/CodeBlockJettisoningWatchpoint.cpp:

(JSC::CodeBlockJettisoningWatchpoint::fireInternal):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):

  • dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp:

(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::fire):

  • dfg/DFGAdaptiveStructureWatchpoint.cpp:

(JSC::DFG::AdaptiveStructureWatchpoint::fireInternal):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parse):

  • dfg/DFGCommon.h:

(JSC::DFG::leastUpperBound):
(JSC::DFG::shouldDumpDisassembly):
(JSC::DFG::shouldShowDisassembly): Deleted.

  • dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::disassemble):

  • dfg/DFGJumpReplacement.cpp:

(JSC::DFG::JumpReplacement::fire):

  • dfg/DFGOSREntry.cpp:

(JSC::DFG::prepareOSREntry):

  • dfg/DFGOSRExitCompiler.cpp:
  • dfg/DFGOSRExitFuzz.h:

(JSC::DFG::doOSRExitFuzzing):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithSqrt):

  • dfg/DFGTierUpCheckInjectionPhase.cpp:

(JSC::DFG::TierUpCheckInjectionPhase::run):

  • ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):

  • ftl/FTLJITCode.cpp:

(JSC::FTL::JITCode::~JITCode):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::callCheck):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):
(JSC::FTL::compileFTLOSRExit):

  • ftl/FTLState.h:

(JSC::FTL::verboseCompilationEnabled):
(JSC::FTL::shouldDumpDisassembly):
(JSC::FTL::shouldShowDisassembly): Deleted.

  • heap/Heap.cpp:

(JSC::Heap::addToRememberedSet):
(JSC::Heap::didFinishCollection):
(JSC::Heap::shouldDoFullCollection):

  • heap/Heap.h:

(JSC::Heap::isDeferred):
(JSC::Heap::structureIDTable):

  • heap/HeapStatistics.cpp:

(JSC::StorageStatistics::storageCapacity):
(JSC::HeapStatistics::dumpObjectStatistics):
(JSC::HeapStatistics::showObjectStatistics): Deleted.

  • heap/HeapStatistics.h:
  • interpreter/StackVisitor.cpp:

(JSC::StackVisitor::Frame::createArguments):

  • jit/AssemblyHelpers.cpp:

(JSC::AssemblyHelpers::callExceptionFuzz):

  • jit/ExecutableAllocationFuzz.cpp:

(JSC::doExecutableAllocationFuzzing):

  • jit/ExecutableAllocationFuzz.h:

(JSC::doExecutableAllocationFuzzingIfEnabled):

  • jit/JIT.cpp:

(JSC::JIT::privateCompile):

  • jit/JITCode.cpp:

(JSC::JITCodeWithCodeRef::~JITCodeWithCodeRef):

  • jit/PolymorphicCallStubRoutine.cpp:

(JSC::PolymorphicCallNode::unlink):
(JSC::PolymorphicCallNode::clearCallLinkInfo):
(JSC::PolymorphicCallStubRoutine::PolymorphicCallStubRoutine):

  • jit/Repatch.cpp:

(JSC::linkFor):
(JSC::unlinkFor):
(JSC::linkVirtualFor):

  • jsc.cpp:

(functionEnableExceptionFuzz):
(jscmain):

  • llvm/InitializeLLVM.cpp:

(JSC::initializeLLVMImpl):

  • runtime/ExceptionFuzz.cpp:

(JSC::doExceptionFuzzing):

  • runtime/ExceptionFuzz.h:

(JSC::doExceptionFuzzingIfEnabled):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/Options.cpp:

(JSC::recomputeDependentOptions):
(JSC::Options::initialize):
(JSC::Options::dumpOptionsIfNeeded):
(JSC::Options::setOption):
(JSC::Options::dumpAllOptions):
(JSC::Options::dumpAllOptionsInALine):
(JSC::Options::dumpOption):

  • runtime/Options.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

(JSC::VM::exceptionFuzzingBuffer):

  • runtime/WriteBarrierInlines.h:

(JSC::WriteBarrierBase<T>::set):
(JSC::WriteBarrierBase<Unknown>::set):

  • tests/executableAllocationFuzz.yaml:
  • tests/stress/arrowfunction-typeof.js:
  • tests/stress/disable-function-dot-arguments.js:

(foo):

  • tests/stress/math-sqrt-basics-disable-architecture-specific-optimizations.js:

(sqrtOnInteger):

  • tests/stress/regress-148564.js:

Tools:

  • Scripts/jsc-stress-test-helpers/js-executable-allocation-fuzz:
  • Scripts/run-jsc-stress-tests:
11:49 AM Changeset in webkit [191057] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-601-branch

Merge r190570. rdar://problem/23075530

11:49 AM Changeset in webkit [191056] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601-branch/Source/WebCore

Merge r190382. rdar://problem/22934301

11:49 AM Changeset in webkit [191055] by matthew_hanson@apple.com
  • 4 edits
    2 adds in branches/safari-601-branch

Merge r190339. rdar://problem/23075538

11:49 AM Changeset in webkit [191054] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601-branch/Source/WebInspectorUI

Merge r190246. rdar://problem/22939682

11:49 AM Changeset in webkit [191053] by matthew_hanson@apple.com
  • 3 edits in branches/safari-601-branch/Source/WebCore

Merge r190097. rdar://problem/23075540

11:49 AM Changeset in webkit [191052] by matthew_hanson@apple.com
  • 4 edits in branches/safari-601-branch/Source/WebCore

Merge r190007. rdar://problem/23075540

11:49 AM Changeset in webkit [191051] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601-branch/Source/WebCore

Merge r189979. rdar://problem/23075525

11:49 AM Changeset in webkit [191050] by matthew_hanson@apple.com
  • 9 edits
    3 adds in branches/safari-601-branch

Merge r189421. rdar://problem/22802049

11:10 AM Changeset in webkit [191049] by Simon Fraser
  • 61 edits in trunk/Source

Change GraphicsContext image-drawing functions to take references
https://bugs.webkit.org/show_bug.cgi?id=150108

Reviewed by Tim Horton and Sam Weinig.

Change GraphicsContext::drawImage(), drawTiledImage(), drawImageBuffer(), clipToImageBuffer()
and isCompatibleWithBuffer() to take references, and adjust calling code, adding
null-checks where necessary.

Source/WebCore:

  • css/CSSCrossfadeValue.cpp:

(WebCore::CSSCrossfadeValue::image):

  • css/CSSFilterImageValue.cpp:

(WebCore::CSSFilterImageValue::image):

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::paint):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::compositeBuffer):
(WebCore::drawImageToContext):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::texSubImage2D):

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::texSubImage2D):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::drawImageIntoBuffer):
(WebCore::WebGLRenderingContextBase::texImage2D):

  • html/canvas/WebGLRenderingContextBase.h:
  • platform/ScrollView.cpp:

(WebCore::ScrollView::paintPanScrollIcon):

  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::CrossfadeGeneratedImage):
(WebCore::drawCrossfadeSubimage):
(WebCore::CrossfadeGeneratedImage::drawCrossfade):

  • platform/graphics/CrossfadeGeneratedImage.h:
  • platform/graphics/GradientImage.cpp:

(WebCore::GradientImage::drawPattern):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawTiledImage):
(WebCore::GraphicsContext::drawImageBuffer):
(WebCore::GraphicsContext::clipToImageBuffer):
(WebCore::GraphicsContext::isCompatibleWithBuffer):

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::drawShadowBuffer):
(WebCore::ShadowBlur::drawRectShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithTiling):
(WebCore::ShadowBlur::drawRectShadowWithTiling):
(WebCore::ShadowBlur::drawLayerPieces):
(WebCore::ShadowBlur::endShadowLayer):

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBuffer::draw):

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::draw):

  • platform/graphics/filters/FEBlend.cpp:

(WebCore::FEBlend::platformApplySoftware):

  • platform/graphics/filters/FEColorMatrix.cpp:

(WebCore::FEColorMatrix::platformApplySoftware):

  • platform/graphics/filters/FEComposite.cpp:

(WebCore::FEComposite::platformApplySoftware):

  • platform/graphics/filters/FEDropShadow.cpp:

(WebCore::FEDropShadow::platformApplySoftware):

  • platform/graphics/filters/FEMerge.cpp:

(WebCore::FEMerge::platformApplySoftware):

  • platform/graphics/filters/FEOffset.cpp:

(WebCore::FEOffset::platformApplySoftware):

  • platform/graphics/filters/FETile.cpp:

(WebCore::FETile::platformApplySoftware):

  • platform/graphics/filters/SourceAlpha.cpp:

(WebCore::SourceAlpha::platformApplySoftware):

  • platform/graphics/filters/SourceGraphic.cpp:

(WebCore::SourceGraphic::platformApplySoftware):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::paint):

  • platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp:

(WebCore::ImageBackingSurfaceClient::ImageBackingSurfaceClient):
(WebCore::CoordinatedImageBacking::update):

  • platform/mac/ThemeMac.mm:

(WebCore::ThemeMac::drawCellOrFocusRingWithViewIntoContext):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRendererHelper::applyFilterEffect):

  • rendering/ImageQualityController.cpp:

(WebCore::ImageQualityController::shouldPaintAtLowQuality):

  • rendering/ImageQualityController.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::shouldPaintAtLowQuality):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::paintSnapshotImage):
(WebCore::RenderEmbeddedObject::paintContents):

  • rendering/RenderEmbeddedObject.h:
  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):

  • rendering/RenderImageResourceStyleImage.cpp:

(WebCore::RenderImageResourceStyleImage::shutdown):
(WebCore::RenderImageResourceStyleImage::image):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::drawPlatformResizerImage):

  • rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::paint):

  • rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::paintSnapshot):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintProgressBar):
(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecorationPart):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):

  • rendering/shapes/Shape.cpp:

(WebCore::Shape::createRasterShape):

  • rendering/shapes/ShapeOutsideInfo.cpp:

(WebCore::ShapeOutsideInfo::createShapeForImage): Deleted.

  • rendering/style/NinePieceImage.cpp:

(WebCore::NinePieceImage::paint):

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::paintForeground):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::clipToImageBuffer):
(WebCore::SVGRenderingContext::bufferForeground):

  • svg/graphics/filters/SVGFEImage.cpp:

(WebCore::FEImage::platformApplySoftware):

Source/WebKit/win:

  • FullscreenVideoController.cpp:

(HUDButton::draw):

  • Plugins/PluginView.cpp:

(WebCore::PluginView::paintMissingPluginIcon):

Source/WebKit2:

  • Shared/ContextMenuContextData.cpp:

(WebKit::ContextMenuContextData::ContextMenuContextData):

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::encodeImage):
(IPC::encodeOptionalImage):
(IPC::ArgumentCoder<Cursor>::encode):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createSelectionSnapshot):

10:29 AM Changeset in webkit [191048] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

REGRESSION(r53318): background-repeat: space with gradients doesn't render correctly
https://bugs.webkit.org/show_bug.cgi?id=150068

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-10-14
Reviewed by Simon Fraser.

Source/WebCore:

This is a regression of r53318 in which we were trying to make the pattern
of the gradient image as small as possible: 1-pixel wide or tall. But this
broke the rendering of the background image when container element has the
style background-repeat: space. The reason for this is tiling the gradient
image is done completely by CG. To do the tiling, we start by creating a
CGPattern by calling CGPatternCreate() which takes the rect of the pattern
and the step. If the width or the height of the pattern image is adjusted
to be 1-pixel wide or tall, that will force CG to leave a space after every
it draws the pattern image which is 1-pixel wide or tall which is wrong.

The fix is to disable this optimization altogether if the container element
has the style background-repeat: space.

Test: fast/gradients/background-image-repeat-space.html

  • platform/graphics/Gradient.cpp:

(WebCore::Gradient::adjustParametersForTiledDrawing):

  • platform/graphics/Gradient.h:
  • platform/graphics/GradientImage.cpp:

(WebCore::GradientImage::drawPattern):

LayoutTests:

Ensure the gradient background-image is drawn correctly when it is repeated
with spaces.

  • fast/gradients/background-image-repeat-space-expected.html: Added.
  • fast/gradients/background-image-repeat-space.html: Added.
10:23 AM Changeset in webkit [191047] by andersca@apple.com
  • 11 edits in trunk

Change the bundle app cache APIs to take a page
https://bugs.webkit.org/show_bug.cgi?id=150123

Reviewed by Sam Weinig.

Source/WebKit2:

This is another step towards getting rid of ApplicationCacheStorage::singleton().
Ideally the WKTR tests that use this should be converted to API tests.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleClearApplicationCache): Deleted.
(WKBundleClearApplicationCacheForOrigin): Deleted.
(WKBundleSetAppCacheMaximumSize): Deleted.
(WKBundleGetAppCacheUsageForOrigin): Deleted.
(WKBundleSetApplicationCacheOriginQuota): Deleted.
(WKBundleResetApplicationCacheOriginQuota): Deleted.
(WKBundleCopyOriginsWithApplicationCache): Deleted.

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageClearApplicationCache):
(WKBundlePageClearApplicationCacheForOrigin):
(WKBundlePageSetAppCacheMaximumSize):
(WKBundlePageGetAppCacheUsageForOrigin):
(WKBundlePageSetApplicationCacheOriginQuota):
(WKBundlePageResetApplicationCacheOriginQuota):
(WKBundlePageCopyOriginsWithApplicationCache):

  • WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::clearApplicationCache): Deleted.
(WebKit::InjectedBundle::clearApplicationCacheForOrigin): Deleted.
(WebKit::InjectedBundle::setAppCacheMaximumSize): Deleted.
(WebKit::InjectedBundle::appCacheUsageForOrigin): Deleted.
(WebKit::InjectedBundle::setApplicationCacheOriginQuota): Deleted.
(WebKit::InjectedBundle::resetApplicationCacheOriginQuota): Deleted.
(WebKit::InjectedBundle::originsWithApplicationCache): Deleted.

  • WebProcess/InjectedBundle/InjectedBundle.h:

Tools:

Update APIs.

  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting):

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::didReachApplicationCacheOriginQuota):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::clearAllApplicationCaches):
(WTR::TestRunner::clearApplicationCacheForOrigin):
(WTR::TestRunner::setAppCacheMaximumSize):
(WTR::TestRunner::applicationCacheDiskUsageForOrigin):
(WTR::TestRunner::originsWithApplicationCache):

9:23 AM Changeset in webkit [191046] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Speculative build fix: the CallSiteIndex constructor is explicit and requires an uint32_t.

Not Reviewed.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::newExceptionHandlingCallSiteIndex):

5:59 AM Changeset in webkit [191045] by peavo@outlook.com
  • 2 edits in trunk/Source/WTF

[Win64] Enable concurrent JIT.
https://bugs.webkit.org/show_bug.cgi?id=150098

Reviewed by Csaba Osztrogonác.

  • wtf/Platform.h:
5:46 AM Changeset in webkit [191044] by youenn.fablet@crf.canon.fr
  • 1 edit in trunk/LayoutTests/imported/w3c/web-platform-tests

Updating LayoutTests/imported/w3c/web-platform-tests svn:ignore property as done in LayoutTests/imported/w3c/web-platform-tests/.gitignore in revision 191043

5:37 AM Changeset in webkit [191043] by youenn.fablet@crf.canon.fr
  • 15 edits
    1 copy
    3 adds
    1 delete in trunk

Update web-platform-tests tools to the latest revision
https://bugs.webkit.org/show_bug.cgi?id=149645

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Removed tools folder.
Updated ImportExpectations and TestRepositories files to match latest wpt repo revision.
Updated web-platform-tests using the import tool.

  • resources/ImportExpectations: Skipping new test suites.
  • resources/TestRepositories: Updating revision of default imported web-platform-tests. Disabled conversion of git submodules information.
  • resources/web-platform-tests-modules.json: Updated by hand the modules description to align with wpt repo.
  • web-platform-tests/.gitignore: Marking tools folder as ignored.
  • web-platform-tests/README.md:
  • web-platform-tests/common/w3c-import.log:
  • web-platform-tests/config.default.json:
  • web-platform-tests/domparsing/w3c-import.log:
  • web-platform-tests/lint: Added.
  • web-platform-tests/lint.whitelist: Renamed from LayoutTests/imported/w3c/web-platform-tests/tools/scripts/lint.whitelist.
  • web-platform-tests/manifest: Added.
  • web-platform-tests/serve: Added.
  • web-platform-tests/serve.py:

(main):

  • web-platform-tests/tools/init.py: Removed.
  • web-platform-tests/tools/runner/css/bootstrap-theme.min.css: Removed.
  • web-platform-tests/tools/runner/css/bootstrap.min.css: Removed.
  • web-platform-tests/tools/runner/css/w3c-import.log: Removed.
  • web-platform-tests/tools/runner/fonts/glyphicons-halflings-regular.eot: Removed.
  • web-platform-tests/tools/runner/fonts/glyphicons-halflings-regular.svg: Removed.
  • web-platform-tests/tools/runner/fonts/glyphicons-halflings-regular.ttf: Removed.
  • web-platform-tests/tools/runner/fonts/glyphicons-halflings-regular.woff: Removed.
  • web-platform-tests/tools/runner/fonts/w3c-import.log: Removed.
  • web-platform-tests/tools/runner/logo.svg: Removed.
  • web-platform-tests/tools/runner/report.css: Removed.
  • web-platform-tests/tools/runner/report.py: Removed.
  • web-platform-tests/tools/runner/runner.css: Removed.
  • web-platform-tests/tools/runner/runner.js: Removed.
  • web-platform-tests/tools/runner/update_manifest.py: Removed.
  • web-platform-tests/tools/runner/w3c-import.log: Removed.
  • web-platform-tests/tools/scripts/init.py: Removed.
  • web-platform-tests/tools/scripts/_env.py: Removed.
  • web-platform-tests/tools/scripts/html5lib_test.xml: Removed.
  • web-platform-tests/tools/scripts/html5lib_test_fragment.xml: Removed.
  • web-platform-tests/tools/scripts/id2path.js: Removed.
  • web-platform-tests/tools/scripts/id2path.json: Removed.
  • web-platform-tests/tools/scripts/lint.py: Removed.
  • web-platform-tests/tools/scripts/manifest.js: Removed.
  • web-platform-tests/tools/scripts/manifest.py: Removed.
  • web-platform-tests/tools/scripts/package.json: Removed.
  • web-platform-tests/tools/scripts/toc.js: Removed.
  • web-platform-tests/tools/scripts/update-directory-structure.js: Removed.
  • web-platform-tests/tools/scripts/update_html5lib_tests.py: Removed.
  • web-platform-tests/tools/scripts/w3c-import.log: Removed.
  • web-platform-tests/tools/sslutils/init.py: Removed.
  • web-platform-tests/tools/sslutils/base.py: Removed.
  • web-platform-tests/tools/sslutils/openssl.py: Removed.
  • web-platform-tests/tools/sslutils/pregenerated.py: Removed.
  • web-platform-tests/tools/sslutils/w3c-import.log: Removed.
  • web-platform-tests/tools/w3c-import.log: Removed.
  • web-platform-tests/tools/webdriver/webdriver/init.py: Removed.
  • web-platform-tests/tools/webdriver/webdriver/alert.py: Removed.
  • web-platform-tests/tools/webdriver/webdriver/capabilities.py: Removed.
  • web-platform-tests/tools/webdriver/webdriver/command.py: Removed.
  • web-platform-tests/tools/webdriver/webdriver/driver.py: Removed.
  • web-platform-tests/tools/webdriver/webdriver/exceptions.py: Removed.
  • web-platform-tests/tools/webdriver/webdriver/keys.py: Removed.
  • web-platform-tests/tools/webdriver/webdriver/searchcontext.py: Removed.
  • web-platform-tests/tools/webdriver/webdriver/w3c-import.log: Removed.
  • web-platform-tests/tools/webdriver/webdriver/wait.py: Removed.
  • web-platform-tests/tools/webdriver/webdriver/webelement.py: Removed.
  • web-platform-tests/w3c-import.log:

Tools:

Disabling git submodules information conversion to json install file for web-platform-tests.
Disabling related python unit tests.
The tools submodules contain submodules and the conversion tool does not support that yet.

Updating wpt launcher script to aling it with web-platform-test main script.

  • Scripts/webkitpy/layout_tests/servers/web_platform_test_launcher.py:

(main):

  • Scripts/webkitpy/layout_tests/servers/web_platform_test_server_unittest.py:

(TestWebPlatformTestServer.test_corrupted_subserver_files): Deleted.

  • Scripts/webkitpy/w3c/test_importer_unittest.py:

(TestImporterTest.test_submodules_generation):

3:57 AM Changeset in webkit [191042] by commit-queue@webkit.org
  • 4 edits in trunk

[GTK][EFL] Fix build with cmake 3.4
https://bugs.webkit.org/show_bug.cgi?id=150117

Explicitely include the CheckIncludeFiles module before using
the CHECK_INCLUDE_FILES command.

Patch by Tomas Popela <tpopela@redhat.com> on 2015-10-14
Reviewed by Žan Doberšek.

  • Source/cmake/FindOpenGL.cmake:
  • Source/cmake/FindWebP.cmake:
  • Source/cmake/OptionsEfl.cmake:
3:34 AM Changeset in webkit [191041] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[EFL] Fix the problem in which environment variable included in webprocess-cmd-prefix can't be parsed
https://bugs.webkit.org/show_bug.cgi?id=148616

Patch by Joonghun Park <jh718.park@samsung.com> on 2015-10-14
Reviewed by Gyuyoung Kim.

This patch fixes the problem in which environment variable in web process-cmd-prefix can't be parsed.
process-cmd-prefix option doesn't work in two cases.

  1. When executing run-layout-tests,
  2. When executing MiniBrowser with web process-cmd-prefix environment variable.
  • UIProcess/Launcher/efl/ProcessLauncherEfl.cpp:

(WebKit::parseAndRemoveEnvironments):
(WebKit::ProcessLauncher::launchProcess):

12:59 AM Changeset in webkit [191040] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

http/tests/xmlhttprequest/xmlhttprequest-overridemimetype-invalidstaterror.html flakily times out during Mac-WK2 tests
https://bugs.webkit.org/show_bug.cgi?id=150095

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-14
Reviewed by Alexey Proskuryakov.

  • platform/mac-wk2/TestExpectations:
12:28 AM Changeset in webkit [191039] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.10.1

WebKitGTK+ 2.10.1

12:28 AM Changeset in webkit [191038] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.10

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.10.1 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.10.1
12:08 AM Changeset in webkit [191037] by commit-queue@webkit.org
  • 8 edits
    2 deletes in trunk/Source/JavaScriptCore

Unreviewed, rolling out r191030.
https://bugs.webkit.org/show_bug.cgi?id=150116

caused js/class-syntax-method-names.html to crash on debug
builds (Requested by alexchristensen_ on #webkit).

Reverted changeset:

"[ES6] Class expression should have lexical environment that
has itself as an imutable binding"
https://bugs.webkit.org/show_bug.cgi?id=150089
http://trac.webkit.org/changeset/191030

Oct 13, 2015:

11:26 PM Changeset in webkit [191036] by ap@apple.com
  • 5 edits in trunk/Tools

More debug queue build fixing.

Preserve the build style in one more place. Changed mock build_style from "both"
to "release", as we don't support testing both debug and release.

  • Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:

(MockCommitQueue.archive_last_test_results):
(MockCommitQueue):
(MockCommitQueue.build_style):
(MockCommitQueue.did_pass_testing_ews):

  • Scripts/webkitpy/tool/bot/patchanalysistask.py:

(PatchAnalysisTask._test):
(PatchAnalysisTask._build_and_test_without_patch):

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(EarlyWarningSystemTest._default_expected_logs):

  • Scripts/webkitpy/tool/commands/queues_unittest.py:
11:16 PM Changeset in webkit [191035] by Carlos Garcia Campos
  • 34 edits in releases/WebKitGTK/webkit-2.10/Source

Merge r191002 - Avoid useless copies in range-loops that are using 'auto'
https://bugs.webkit.org/show_bug.cgi?id=150091

Reviewed by Sam Weinig.

Avoid useless copies in range-loops that are using 'auto'. Also use
'auto*' instead of 'auto' when range values are pointers for clarity.
Source/bmalloc:

  • bmalloc/Deallocator.cpp:

(bmalloc::Deallocator::processObjectLog):

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame getDictationResultRanges:andMetadatas:]):

Source/WebKit2:

  • UIProcess/VisitedLinkStore.cpp:

(WebKit::VisitedLinkStore::pendingVisitedLinksTimerFired):
(WebKit::VisitedLinkStore::resizeTable):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::releaseRemainingIconsForPageURLs):

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchData):
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::plugins):

11:11 PM Changeset in webkit [191034] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore

Merge r190991 - REGRESSION: ASSERT (impl->isAtomic()) @ facebook.com
https://bugs.webkit.org/show_bug.cgi?id=149965

Reviewed by Geoffrey Garen.

Edge filtering for CheckIdent ensures that a given value is either Symbol or StringIdent.
However, this filtering is not applied to CheckIdent when propagating a constant value in
the constant folding phase. As a result, it is not guaranteeed that a constant value
propagated in constant folding is Symbol or StringIdent.

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

10:11 PM Changeset in webkit [191033] by ap@apple.com
  • 2 edits in trunk/Tools

More debug queue build fixing.

Add build_style argument to derived classes as well.

  • Scripts/webkitpy/common/config/ports.py:

(MacPort):
(MacPort.run_webkit_tests_command):
(WinPort.run_bindings_tests_command):
(WinPort):
(WinPort.run_webkit_tests_command):
(GtkWK2Port.build_webkit_command):
(GtkWK2Port):
(GtkWK2Port.run_webkit_tests_command):

10:10 PM Changeset in webkit [191032] by mmaxfield@apple.com
  • 3 edits in trunk/Tools

[iOS] Build fix

Unreviewed.

Mach-O section names are limited to 16 characters.

  • DumpRenderTree/mac/Configurations/DumpRenderTreeApp.xcconfig:
  • DumpRenderTree/mac/DumpRenderTree.mm:

(activateFontsIOS):

9:54 PM Changeset in webkit [191031] by ap@apple.com
  • 7 edits in trunk/Tools

Build fix for mac-debug EWS queue.

Unreviewed.

Pass --debug to run-webkit-tests.

While at it, removed unsupported run_webkit_unit_tests_command. All the test steps
will need to be substantially modified to work in EWS, so the dummy implementation
was not helpful.

  • Scripts/webkitpy/common/config/ports.py:

(DeprecatedPort.run_javascriptcore_tests_command):
(DeprecatedPort):
(DeprecatedPort.run_webkit_tests_command):
(DeprecatedPort.run_python_unittests_command):
(DeprecatedPort.run_webkit_unit_tests_command): Deleted.

  • Scripts/webkitpy/common/config/ports_mock.py:

(MockPort.run_javascriptcore_tests_command):
(MockPort):
(MockPort.run_webkit_tests_command):
(MockPort.run_bindings_tests_command):
(MockPort.run_webkit_unit_tests_command): Deleted.

  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/steps/runtests.py:

(RunTests.run):

  • Scripts/webkitpy/tool/steps/runtests_unittest.py:

(RunTestsTest.test_webkit_run_unit_tests):

  • Scripts/webkitpy/tool/steps/steps_unittest.py:

(StepsTest.test_runtests_args):

8:56 PM Changeset in webkit [191030] by Yusuke Suzuki
  • 8 edits
    2 adds in trunk/Source/JavaScriptCore

[ES6] Class expression should have lexical environment that has itself as an imutable binding
https://bugs.webkit.org/show_bug.cgi?id=150089

Reviewed by Geoffrey Garen.

According to ES6 spec, class expression has its own lexical environment that holds itself
as an immutable binding[1] (section 14.5.14 step 2, 3, 4, 23)

As a result, even if the binding declared in the outer scope is overridden, methods inside
class expression can refer its class by the class name.

[1]: http://ecma-international.org/ecma-262/6.0/#sec-runtime-semantics-classdefinitionevaluation

  • bytecompiler/NodesCodegen.cpp:

(JSC::ClassExprNode::emitBytecode):

  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createClassExpr):

  • parser/NodeConstructors.h:

(JSC::ClassExprNode::ClassExprNode):

  • parser/Nodes.h:
  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseClass):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createClassExpr):

  • tests/es6.yaml:
  • tests/stress/class-expression-generates-environment.js: Added.

(shouldBe):
(shouldThrow):
(prototype.method):
(staticMethod):
(A.prototype.method):
(A.staticMethod):
(A):

  • tests/stress/class-expression-should-be-tdz-in-heritage.js: Added.

(shouldThrow):
(shouldThrow.A):

8:05 PM Changeset in webkit [191029] by Alan Bujtas
  • 1 edit
    17 adds in trunk/LayoutTests

[iOS] Update anonymous table results for iOS port.

Unreviewed gardening.

  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-177-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-178-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-179-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-180-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-181-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-189-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-190-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-191-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-192-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-193-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-194-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-195-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-196-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-205-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-206-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-207-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-208-expected.txt: Added.
7:38 PM Changeset in webkit [191028] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Unreviewed EFL Gardening on 13th Oct.
https://bugs.webkit.org/show_bug.cgi?id=150084

Patch by Hunseop Jeong <Hunseop Jeong> on 2015-10-13

  • platform/efl/TestExpectations:
7:18 PM Changeset in webkit [191027] by matthew_hanson@apple.com
  • 12 edits in branches/safari-601-branch/Source

Merge r189834. rdar://problem/22801966

7:14 PM Changeset in webkit [191026] by Alan Bujtas
  • 1 edit
    16 adds in trunk/LayoutTests

[Win] Update anonymous table results for Windows port.

Unreviewed gardening.

  • platform/win/css2.1/tables/table-anonymous-objects-177-expected.txt: Added.
  • platform/win/css2.1/tables/table-anonymous-objects-178-expected.txt: Added.
  • platform/win/css2.1/tables/table-anonymous-objects-179-expected.txt: Added.
  • platform/win/css2.1/tables/table-anonymous-objects-180-expected.txt: Added.
  • platform/win/css2.1/tables/table-anonymous-objects-189-expected.txt: Added.
  • platform/win/css2.1/tables/table-anonymous-objects-190-expected.txt: Added.
  • platform/win/css2.1/tables/table-anonymous-objects-191-expected.txt: Added.
  • platform/win/css2.1/tables/table-anonymous-objects-192-expected.txt: Added.
  • platform/win/css2.1/tables/table-anonymous-objects-193-expected.txt: Added.
  • platform/win/css2.1/tables/table-anonymous-objects-194-expected.txt: Added.
  • platform/win/css2.1/tables/table-anonymous-objects-195-expected.txt: Added.
  • platform/win/css2.1/tables/table-anonymous-objects-196-expected.txt: Added.
  • platform/win/css2.1/tables/table-anonymous-objects-205-expected.txt: Added.
  • platform/win/css2.1/tables/table-anonymous-objects-206-expected.txt: Added.
  • platform/win/css2.1/tables/table-anonymous-objects-207-expected.txt: Added.
  • platform/win/css2.1/tables/table-anonymous-objects-208-expected.txt: Added.
6:09 PM Changeset in webkit [191025] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.25.2

New tag.

6:02 PM Changeset in webkit [191024] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merged r191022. rdar://problem/23100514

5:29 PM Changeset in webkit [191023] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46.25-branch/Source/WebKit2

Merged r191022. rdar://problem/23100514

5:25 PM Changeset in webkit [191022] by barraclough@apple.com
  • 2 edits in trunk/Source/WebKit2

Use the correct notification strings for view service applications state change.
https://bugs.webkit.org/show_bug.cgi?id=150107

Use the correct notification names "_UIViewServiceHostDidEnterBackgroundNotification" and
"_UIViewServiceHostWillEnterForegroundNotification" to listen to view service application state changes.

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2015-10-13
Reviewed by Gavin Barraclough.

  • UIProcess/ApplicationStateTracker.mm:

(WebKit::ApplicationStateTracker::ApplicationStateTracker):

5:15 PM Changeset in webkit [191021] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46.25-branch/Source

Versioning.

5:15 PM Changeset in webkit [191020] by matthew_hanson@apple.com
  • 3 edits in branches/safari-601-branch/Source/WebKit2

Merge r190141. rdar://problem/23075536

5:15 PM Changeset in webkit [191019] by matthew_hanson@apple.com
  • 7 edits in branches/safari-601-branch/Source

Merge r188443. rdar://problem/22801969

5:15 PM Changeset in webkit [191018] by Brent Fulgham
  • 5 edits in trunk/Tools

[Win] Generate Crash Traces
https://bugs.webkit.org/show_bug.cgi?id=150103

Reviewed by Daniel Bates.

We were using an exception filter to try to emit "#CRASHED" to stderr
when a test program crashed. However, the modern Python implementation
seems capable of recognizing crashes on its own. Furthermore, registering
the exception handler was preventing the JIT debugger (NTSD) from
automatically attaching to the crashing program, so we were not getting
crash traces.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(main): Don't register an exception filter.
(exceptionFilter): Deleted.

  • Scripts/webkitpy/common/system/crashlogs.py:

(CrashLogs): Add another regular expression to handle a second crash trace
syntax I encountered during testing.
(CrashLogs._find_newest_log_win): If the old regular expression doesn't match,
try the new one. The PID found by the new expression is in hexadecimal, so
convert it to an integer before returning it.

  • Scripts/webkitpy/port/driver.py:

(Driver._check_for_driver_crash_or_unresponsiveness): Windows was not recognizing
the "#CRASHED" state because it was appending '\r\n', rather than just '\r'. Instead,
check for "#CRASHED" after stripping off the EOL characters.

  • Scripts/webkitpy/port/win.py:

(WinPort.setup_crash_log_saving): Put back the '-e %ld' flag in the debugger
invocation. This is apparently used to signal an event when the debugger is finished.

5:14 PM Changeset in webkit [191017] by Simon Fraser
  • 15 edits
    1 add in trunk/Source

Add helper funtion for checking pointer equivalency and use it
https://bugs.webkit.org/show_bug.cgi?id=150022

Reviewed by Darin Adler.
Source/WebCore:

A common pattern in WebCore code is to check for equivalency of two pointers,
either both null, or both non-null and with equal values. This was written in
several different ways in different places.

Add arePointingToEqualData() to standardize this pattern.

This obviates the need for StyleImage::imagesEquivalent(), counterDataEquivalent()
etc.

Also change some comparisons of DataRef<> which checked the pointer and then the
values to use DataRef<>::operator== which does the same thing. Comparisons of
m_grid and m_gridItem only checked pointer equality, so this is probably a bug fix there.

page/animation/CSSPropertyAnimation.cpp: if ((!a && !b)
a == b) is redundant so fix,

and add checks for a and b RenderStyle* first.
(WebCore::PropertyWrapperGetter::equals):
(WebCore::StyleImagePropertyWrapper::equals):
(WebCore::PropertyWrapperShadow::equals):
(WebCore::PropertyWrapperMaybeInvalidColor::equals):
(WebCore::FillLayerPropertyWrapperGetter::equals):
(WebCore::FillLayerStyleImagePropertyWrapper::equals):
(WebCore::FillLayersPropertyWrapper::equals):
(WebCore::ShorthandPropertyWrapper::equals):
(WebCore::PropertyWrapperFlex::equals):
(WebCore::PropertyWrapperSVGPaint::equals):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::equalIgnoringHeaderFields):

  • rendering/style/FillLayer.cpp:

(WebCore::FillLayer::operator==):

  • rendering/style/NinePieceImage.cpp:

(WebCore::NinePieceImageData::operator==):

  • rendering/style/RenderStyle.cpp: Some nullptr cleanup.

(WebCore::RenderStyle::getCachedPseudoStyle):
(WebCore::RenderStyle::addCachedPseudoStyle):
(WebCore::RenderStyle::changeAffectsVisualOverflow):
(WebCore::RenderStyle::changeRequiresLayout):
(WebCore::RenderStyle::changeRequiresLayerRepaint):
(WebCore::RenderStyle::setWillChange):

  • rendering/style/SVGRenderStyleDefs.cpp:

(WebCore::StyleShadowSVGData::operator==):

  • rendering/style/ShadowData.cpp:

(WebCore::ShadowData::operator==):

  • rendering/style/StyleImage.h:

(WebCore::StyleImage::imagesEquivalent): Deleted.

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::operator==):
(WebCore::cursorDataEquivalent): Deleted.
(WebCore::quotesDataEquivalent): Deleted.
(WebCore::StyleRareInheritedData::shadowDataEquivalent): Deleted.

  • rendering/style/StyleRareInheritedData.h:
  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::operator==):
(WebCore::StyleRareNonInheritedData::counterDataEquivalent): Deleted.
(WebCore::StyleRareNonInheritedData::shadowDataEquivalent): Deleted.
(WebCore::StyleRareNonInheritedData::willChangeDataEquivalent): Deleted.
(WebCore::StyleRareNonInheritedData::reflectionDataEquivalent): Deleted.
(WebCore::StyleRareNonInheritedData::animationDataEquivalent): Deleted.
(WebCore::StyleRareNonInheritedData::transitionDataEquivalent): Deleted.

  • rendering/style/StyleRareNonInheritedData.h:

Source/WTF:

Add PointerComparison.h which contains the templated pointer comparison
function.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/PointerComparison.h: Added.

(WTF::arePointingToEqualData):

5:12 PM Changeset in webkit [191016] by sbarati@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

We were creating a GCAwareJITStubRoutineWithExceptionHandler when we didn't actually have an exception handler in the CodeBlock's exception handler table
https://bugs.webkit.org/show_bug.cgi?id=150016

Reviewed by Geoffrey Garen.

There was a bug where we created a GCAwareJITStubRoutineWithExceptionHandler
for inline caches that were custom setters/getters (but not JS getters/setters).
This is wrong; we only create GCAwareJITStubRoutineWithExceptionHandler when we have
an inline cache with a JS getter/setter call which causes the inline cache to add itself
to the CodeBlock's exception handling table. The problem was that we created
a GCAwareJITStubRoutineWithExceptionHandler that tried to remove itself from
the exception handler table only to find out that it didn't have an entry in the table.

  • bytecode/PolymorphicAccess.cpp:

(JSC::PolymorphicAccess::regenerate):

5:10 PM Changeset in webkit [191015] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Simplify WeakBlock visit and reap phases
https://bugs.webkit.org/show_bug.cgi?id=150045

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-10-13
Reviewed by Geoffrey Garen.

WeakBlock visiting and reaping both happen after MarkedBlock marking.
All the MarkedBlocks we encounter should be either Marked or Retired.

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::isMarkedOrRetired):

  • heap/WeakBlock.cpp:

(JSC::WeakBlock::visit):
(JSC::WeakBlock::reap):

  • heap/WeakBlock.h:
4:40 PM Changeset in webkit [191014] by mmaxfield@apple.com
  • 26 edits
    1 delete in trunk/Source

Split TypesettingFeatures into kerning and ligatures bools
https://bugs.webkit.org/show_bug.cgi?id=150074

Reviewed by Simon Fraser.

Source/WebCore:

Our TypesettingFeatures type represents whether kerning or ligatures are enabled
when laying out text. However, now that I have implemented font-feature-settings
and font-variant-*, this type is wildly inadequate. There are now multiple kinds
of ligatures, and many other features which are neither kerning nor ligatures.
Adding tons of information to this type doesn't make sense because 1) We already
have a FontVariantSettings struct which contains this information, and 2) None
of the users of TypesettingFeatures care about most of these new features.

In this new world of font features, the font-kerning property isn't changing.
Therefore, all the code which relies only on the Kerning value in
TypesettingFeatures doesn't need to change. The places which rely on Ligatures,
however, need to be updated to understand that there are many different kinds
of ligatures.

Indeed, after inspection, all of the places which inspect ligatures are more
interested in a high-level concept of whether or not we can trust some simple
computation. Therefore, we really have two things we care about: Kerning, and
this high-level concept.

This patch is the second step to update our view of the world to include
font-feature-settings and font-variant-*. In particular, this patch simply
splits TypesettingFeatures into two Booleans, one for Kerning, and one for
Ligatures (which has no behavior change). Then, once they are separated, I can
migrate the Ligatures Boolean to take on its new meaning.

This change is purely mechanical.

No new tests because there is no behavior change.

  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator FontCascadeDescription::Kerning):

  • platform/graphics/Font.cpp:

(WebCore::Font::applyTransforms):

  • platform/graphics/Font.h:
  • platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::FontCascade):
(WebCore::FontCascade::operator=):
(WebCore::FontCascade::update):
(WebCore::FontCascade::drawText):
(WebCore::FontCascade::drawEmphasisMarks):
(WebCore::FontCascade::width):
(WebCore::FontCascade::adjustSelectionRectForText):
(WebCore::FontCascade::offsetForPosition):
(WebCore::FontCascade::setDefaultKerning):
(WebCore::FontCascade::setDefaultLigatures):
(WebCore::FontCascade::codePath):
(WebCore::FontCascade::floatWidthForSimpleText):
(WebCore::FontCascade::setDefaultTypesettingFeatures): Deleted.
(WebCore::FontCascade::defaultTypesettingFeatures): Deleted.

  • platform/graphics/FontCascade.h:

(WebCore::FontCascade::enableKerning):
(WebCore::FontCascade::enableLigatures):
(WebCore::FontCascade::computeEnableKerning):
(WebCore::FontCascade::computeEnableLigatures):
(WebCore::FontCascade::typesettingFeatures): Deleted.
(WebCore::FontCascade::computeTypesettingFeatures): Deleted.

  • platform/graphics/FontDescription.cpp:

(WebCore::FontCascadeDescription::FontCascadeDescription):

  • platform/graphics/FontDescription.h:

(WebCore::FontCascadeDescription::setKerning):
(WebCore::FontCascadeDescription::initialKerning):

  • platform/graphics/TypesettingFeatures.h: Removed.
  • platform/graphics/WidthIterator.cpp:

(WebCore::WidthIterator::WidthIterator):
(WebCore::WidthIterator::applyFontTransforms):
(WebCore::WidthIterator::advanceInternal):

  • platform/graphics/WidthIterator.h:
  • platform/graphics/cocoa/FontCocoa.mm:

(WebCore::Font::canRenderCombiningCharacterSequence):

  • platform/graphics/mac/ComplexTextControllerCoreText.mm:

(WebCore::ComplexTextController::collectComplexTextRunsForCharacters):

  • platform/graphics/mac/SimpleFontDataCoreText.cpp:

(WebCore::Font::getCFStringAttributes):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):

  • rendering/line/BreakingContext.h:

(WebCore::WordTrailingSpace::width):

  • svg/SVGFontData.h:

Source/WebKit/mac:

  • WebView/WebView.mm:

(+[WebView initialize]):

Source/WebKit2:

  • Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::WebProcessCreationParameters):
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):

  • Shared/WebProcessCreationParameters.h:
  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

4:28 PM Changeset in webkit [191013] by dino@apple.com
  • 4 edits in trunk/Source/WebKit2

Fix iOS-family builds.

  • UIProcess/API/C/mac/WKPagePrivateMac.mm:

(WKPageGetObjectRegistry):

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController _remoteObjectRegistry]):

  • UIProcess/API/mac/WKViewInternal.h:
4:01 PM Changeset in webkit [191012] by Brent Fulgham
  • 3 edits in trunk/LayoutTests

[Win] Unreviewed test gardening after r190995.

Update to correct test output, based on similar changes to Mac expectations.

  • platform/win/fast/html/details-add-child-2-expected.txt:
  • platform/win/fast/html/details-open2-expected.txt:
3:53 PM Changeset in webkit [191011] by Alan Bujtas
  • 9 edits
    34 adds in trunk

Anonymous table objects: inline parent box requires inline-table child.
https://bugs.webkit.org/show_bug.cgi?id=150090

Reviewed by David Hyatt.

According to the CSS2.1 specification, if a child needs anonymous table wrapper
and the child's parent is an inline box, the generated table needs to be inline-table.
(inline-block and block parents generate non-inline table)

Import W3C CSS2.1 anonymous table tests.

Source/WebCore:

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::childRequiresTable):
(WebCore::RenderElement::addChild):

  • rendering/RenderElement.h:
  • rendering/RenderInline.cpp:

(WebCore::RenderInline::newChildIsInline):
(WebCore::RenderInline::addChildIgnoringContinuation):
(WebCore::RenderInline::addChildToContinuation):

  • rendering/RenderInline.h:
  • rendering/RenderTable.cpp:

(WebCore::RenderTable::createAnonymousWithParentRenderer):

LayoutTests:

  • css2.1/tables/table-anonymous-objects-177.xht: Added.
  • css2.1/tables/table-anonymous-objects-178.xht: Added.
  • css2.1/tables/table-anonymous-objects-179.xht: Added.
  • css2.1/tables/table-anonymous-objects-180.xht: Added.
  • css2.1/tables/table-anonymous-objects-181.xht: Added.
  • css2.1/tables/table-anonymous-objects-189.xht: Added.
  • css2.1/tables/table-anonymous-objects-190.xht: Added.
  • css2.1/tables/table-anonymous-objects-191.xht: Added.
  • css2.1/tables/table-anonymous-objects-192.xht: Added.
  • css2.1/tables/table-anonymous-objects-193.xht: Added.
  • css2.1/tables/table-anonymous-objects-194.xht: Added.
  • css2.1/tables/table-anonymous-objects-195.xht: Added.
  • css2.1/tables/table-anonymous-objects-196.xht: Added.
  • css2.1/tables/table-anonymous-objects-205.xht: Added.
  • css2.1/tables/table-anonymous-objects-206.xht: Added.
  • css2.1/tables/table-anonymous-objects-207.xht: Added.
  • css2.1/tables/table-anonymous-objects-208.xht: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-177-expected.txt: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-178-expected.txt: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-179-expected.txt: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-180-expected.txt: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-181-expected.txt: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-189-expected.txt: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-190-expected.txt: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-191-expected.txt: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-192-expected.txt: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-193-expected.txt: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-194-expected.txt: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-195-expected.txt: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-196-expected.txt: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-205-expected.txt: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-206-expected.txt: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-207-expected.txt: Added.
  • platform/mac/css2.1/tables/table-anonymous-objects-208-expected.txt: Added.
3:17 PM Changeset in webkit [191010] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Fix 32-bit build.

  • UIProcess/API/C/mac/WKPagePrivateMac.mm:

(WKPageGetObjectRegistry):

2:56 PM Changeset in webkit [191009] by andersca@apple.com
  • 6 edits in trunk/Source/WebKit2

Add and implement WKPageGetObjectRegistry
https://bugs.webkit.org/show_bug.cgi?id=150102

Reviewed by Tim Horton.

Put the _WKObjectRegistry used by WKPageRef and WKBrowsingContextController on the WKView for now.
If we decide to share more code between WKView and WKWebView, the object registry could live in an object that would be shared
between WKView and WKWebView.

  • UIProcess/API/C/mac/WKPagePrivateMac.h:
  • UIProcess/API/C/mac/WKPagePrivateMac.mm:

(WKPageGetObjectRegistry):

  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController _remoteObjectRegistry]):
(-[WKBrowsingContextController dealloc]): Deleted.

  • UIProcess/API/mac/WKView.mm:

(-[WKView dealloc]):
(-[WKView _remoteObjectRegistry]):

  • UIProcess/API/mac/WKViewInternal.h:
2:46 PM Changeset in webkit [191008] by dino@apple.com
  • 4 edits
    2 adds in trunk

Device motion and orientation should only be visible from the main frame's security origin
https://bugs.webkit.org/show_bug.cgi?id=150072
<rdar://problem/23082036>

Reviewed by Brent Fulgham.

.:

Add a manual test for cross-origin device orientation events, while
we're waiting on the mock client to be supported everywhere.

  • ManualTests/deviceorientation-child-frame.html: Added.
  • ManualTests/deviceorientation-main-frame-only.html: Added.

Source/WebCore:

There are reports that gyroscope and accelerometer information can
be used to detect keyboard entry. One initial step to reduce the
risk is to forbid device motion and orientation events from
being fired in frames that are a different security origin from the main page.

Manual test: deviceorientation-main-frame-only.html

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::isSameSecurityOriginAsMainFrame): New helper function.
(WebCore::DOMWindow::addEventListener): Check if we are the main frame, or the
same security origin as the main frame. If not, don't add the event
listeners.

2:45 PM Changeset in webkit [191007] by dino@apple.com
  • 3 edits in trunk/Source/WebCore

ASSERT(m_motionManager) on emgn.com page
https://bugs.webkit.org/show_bug.cgi?id=150070
<rdar://problem/18383732>

Reviewed by Simon Fraser.

In the WebCoreMotionManager init method, we call
into another setup method on the main thread.
However, if a listener was attached before that
ran, we'd ASSERT. This wasn't actually causing a bug
because the main thread initialization would
check the listeners once it got a chance to run.

The fix is to only check status when we've
actually initialized.

  • platform/ios/WebCoreMotionManager.h: New m_initialized boolean.
  • platform/ios/WebCoreMotionManager.mm: Check m_initialized before doing real work.

(-[WebCoreMotionManager init]):
(-[WebCoreMotionManager addMotionClient:]):
(-[WebCoreMotionManager removeMotionClient:]):
(-[WebCoreMotionManager addOrientationClient:]):
(-[WebCoreMotionManager removeOrientationClient:]):
(-[WebCoreMotionManager initializeOnMainThread]):

2:28 PM Changeset in webkit [191006] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

A lot of the http/tests/cache/disk-cache/ tests are flaky on mac-wk2, marking them as such.
https://bugs.webkit.org/show_bug.cgi?id=149087

Patch by Ryan Haddad <Ryan Haddad> on 2015-10-13
Reviewed by Alexey Proskuryakov.

  • platform/mac-wk2/TestExpectations:
1:30 PM Changeset in webkit [191005] by ap@apple.com
  • 4 edits in trunk/Tools

Mac Debug and 32-bit queues should be separate
https://bugs.webkit.org/show_bug.cgi?id=150092

Reviewed by Lucas Forschler.

  • QueueStatusServer/config/queues.py:
  • QueueStatusServer/model/queues.py:

(Queue._capitalize_after_dash):
(Queue._caplitalize_after_dash): Deleted.

  • Scripts/webkitpy/common/config/ews.json:
1:23 PM Changeset in webkit [191004] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

REGRESSION(r189567): Web Inspector: Clipped filter icons when debugger sidebar is narrow
https://bugs.webkit.org/show_bug.cgi?id=150023

r189567 changed flexbox items' default min-width from 0 to auto.
Explicitly set it to 0 in CSS.

Reviewed by Brian Burg.

  • UserInterface/Views/FilterBar.css:

(.filter-bar > input[type="search"]):

1:08 PM Changeset in webkit [191003] by ggaren@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

CodeBlock write barriers should be precise
https://bugs.webkit.org/show_bug.cgi?id=150042

Reviewed by Saam Barati.

CodeBlock performs lots of unnecessary write barriers. This wastes
performance and makes the code a bit harder to follow, and it might mask
important bugs. Now is a good time to unmask important bugs.

  • bytecode/CodeBlock.h:

(JSC::CodeBlockSet::mark): Don't write barrier all CodeBlocks on the
stack. Only CodeBlocks that do value profiling need write barriers, and
they do those themselves.

In steady state, when most of our CodeBlocks are old and FTL-compiled,
and we're doing eden GC's, we should almost never visit a CodeBlock.

  • dfg/DFGOSRExitCompilerCommon.cpp:

(JSC::DFG::osrWriteBarrier):
(JSC::DFG::adjustAndJumpToTarget): Don't write barrier all inlined
CodeBlocks on exit. That's not necessary. Instead, write barrier the
CodeBlock(s) we will exit to, along with the one we will write a value
profile to.

12:15 PM Changeset in webkit [191002] by Chris Dumez
  • 35 edits in trunk/Source

Avoid useless copies in range-loops that are using 'auto'
https://bugs.webkit.org/show_bug.cgi?id=150091

Reviewed by Sam Weinig.

Avoid useless copies in range-loops that are using 'auto'. Also use
'auto*' instead of 'auto' when range values are pointers for clarity.
Source/bmalloc:

  • bmalloc/Deallocator.cpp:

(bmalloc::Deallocator::processObjectLog):

Source/WebKit/mac:

  • WebView/WebFrame.mm:

(-[WebFrame getDictationResultRanges:andMetadatas:]):

Source/WebKit2:

  • UIProcess/VisitedLinkStore.cpp:

(WebKit::VisitedLinkStore::pendingVisitedLinksTimerFired):
(WebKit::VisitedLinkStore::resizeTable):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::releaseRemainingIconsForPageURLs):

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::fetchData):
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::plugins):

12:03 PM Changeset in webkit [191001] by Yusuke Suzuki
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Don't shadow global Object constructor in WebInspector.Object class definition
https://bugs.webkit.org/show_bug.cgi?id=150093

Reviewed by Joseph Pecoraro.

Currently, class expression does not define any variables. So even in class Object { },
we were able to touch the global Object constructor (like Object.keys).
However, that is a bug. After https://bugs.webkit.org/show_bug.cgi?id=150089 fixes that bug,
the global Object is shadowed by the user-defined class Object name.

To solve this issue, we changed the class Object to class WebInspectorObject.
And we expose this class as a WebInspector.Object.

  • UserInterface/Base/Object.js:
12:03 PM Changeset in webkit [191000] by Simon Fraser
  • 6 edits in trunk/Source/WebCore

Move Image::drawPattern for CG into GraphicsContext
https://bugs.webkit.org/show_bug.cgi?id=150077

Reviewed by Myles C. Maxfield.

In order to consolidate code that calls into Core Graphics inside
GraphicsContext, move the body of Image::drawPattern() into
GraphicsContextCG.cpp, and do the same for Cairo.

  • platform/graphics/GraphicsContext.h:
  • platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawPattern):

  • platform/graphics/cairo/ImageCairo.cpp:

(WebCore::Image::drawPattern):

  • platform/graphics/cg/GraphicsContextCG.cpp:

(WebCore::drawPatternCallback):
(WebCore::patternReleaseCallback):
(WebCore::GraphicsContext::drawPattern):

  • platform/graphics/cg/ImageCG.cpp:

(WebCore::Image::drawPattern):
(WebCore::drawPatternCallback): Deleted.
(WebCore::patternReleaseCallback): Deleted.

11:49 AM Changeset in webkit [190999] by mmaxfield@apple.com
  • 5 edits in trunk

Unprefix font-kerning
https://bugs.webkit.org/show_bug.cgi?id=150080

Reviewed by Sam Weinig.

This is the last property in CSS3 Fonts which is prefixed.

Source/WebCore:

Test: fast/text/font-kerning.html

  • css/CSSPropertyNames.in:

LayoutTests:

  • fast/text/font-kerning-expected.html:
  • fast/text/font-kerning.html:
11:46 AM Changeset in webkit [190998] by commit-queue@webkit.org
  • 16 edits in trunk/Source

Add debug settings for using giant tiles (4096x4096)
https://bugs.webkit.org/show_bug.cgi?id=149977
<rdar://problem/23017093>

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-10-13
Reviewed by Tim Horton.

Source/WebCore:

Instead of creating the GraphicsLayer with a fixed size 512x512, we need
to read the useGiantTiles setting. If its value is true, we set the layer
tileSize to 4096x4096.

  • page/Settings.in:

Define the name of the setting and its default value.

  • platform/graphics/GraphicsLayerClient.h:

(WebCore::GraphicsLayerClient::tileSize):
Define tileSize() in the base class GraphicsLayerClient. This is going to
be overridden RenderLayerBacking.

  • platform/graphics/TiledBacking.h:

(WebCore::defaultTileSize):
Define the default tileSize which will depend on the useGiantTiles
setting.

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::platformCALayerTileSize):
Implement the virtual function GraphicsLayerCA::platformCALayerTileSize().
It passes the call to client GraphicsLayerClient which can be RenderLayerBacking
in our case.

  • platform/graphics/ca/GraphicsLayerCA.h:

Override base class function PlatformCALayerClient::PlatformCALayerClient().

  • platform/graphics/ca/PlatformCALayerClient.h:

(WebCore::PlatformCALayerClient::platformCALayerTileSize):
Define platformCALayerTileSize() in the base class PlatformCALayerClient.
This is going to be overridden GraphicsLayerCA.

  • platform/graphics/ca/TileController.cpp:

(WebCore::TileController::TileController):
No need for the member m_tileSize.

(WebCore::TileController::computeTileCoverageRect):
Use the function tileSize() instead of using the static values.

(WebCore::TileController::tileSize):
The tileSize will be retrieved from the owning graphics layer.

  • platform/graphics/ca/TileController.h:

No need for the member m_tileSize. The tileSize will be retrieved from the owning graphics layer.

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::setTiledBackingHasMargins):
Use the function tileSize() instead of using the static values.

(WebCore::RenderLayerBacking::tileSize):
Override base class function GraphicsLayerClient::tileSize().

  • rendering/RenderLayerBacking.h:

Define the concrete method RenderLayerBacking::tilSize().

Source/WebKit2:

  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetUseGiantTiles):
(WKPreferencesGetUseGiantTiles):

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

11:35 AM Changeset in webkit [190997] by bshafiei@apple.com
  • 5 edits in branches/safari-601-branch/Source

Versioning.

11:34 AM Changeset in webkit [190996] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source

Versioning.

11:34 AM Changeset in webkit [190995] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Try to fix ENABLE(DETAILS_ELEMENT) with SHADOW_DOM disabled.

  • dom/Element.cpp:

(WebCore::Element::attributeChanged):

  • dom/Node.cpp:

(WebCore::traverseStyleParent):

11:05 AM Changeset in webkit [190994] by ap@apple.com
  • 3 edits
    1 delete in trunk/LayoutTests

http/tests/multipart/multipart-replace-non-html-content.php shouldn't exercise
edge cases of multipart parsing
https://bugs.webkit.org/show_bug.cgi?id=149978
rdar://problem/22981062

Reviewed by Anders Carlsson.

This test is not about HTTP edge cases, but about handling of multipart content in WebKit.

  • http/tests/multipart/multipart-replace-non-html-content.php:
  • platform/mac/http/tests/multipart/multipart-replace-non-html-content-expected.txt: Removed.
  • platform/win/TestExpectations:
10:44 AM Changeset in webkit [190993] by youenn.fablet@crf.canon.fr
  • 5 edits in trunk/Source/WebCore

Fix license and copyrights of WebCore js binding builtin files
https://bugs.webkit.org/show_bug.cgi?id=150027

Reviewed by Darin Adler.

Fixing copyright on all three files.
Moving to BSD-like license as they should have been in the first place.
Ordering lexicographically the builtin names in WebCoreBuiltinNames.h.

No change in behaviour.

  • bindings/js/WebCoreBuiltinNames.h:
  • bindings/js/WebCoreJSBuiltins.cpp:
  • bindings/js/WebCoreJSBuiltins.h:
  • bindings/js/WebCoreJSBuiltinInternals.h:
9:54 AM Changeset in webkit [190992] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit2

[iOS] Avoid crash due to invalid screen bounds
https://bugs.webkit.org/show_bug.cgi?id=150048
<rdar://problem/22112664>

Reviewed by Jer Noble.

Check for an invalid bounds, and reset it to a known state before
attempting to use it.

  • WebProcess/ios/WebVideoFullscreenManager.mm:

(WebKit::WebVideoFullscreenManager::setVideoLayerFrameFenced):

9:03 AM Changeset in webkit [190991] by Yusuke Suzuki
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION: ASSERT (impl->isAtomic()) @ facebook.com
https://bugs.webkit.org/show_bug.cgi?id=149965

Reviewed by Geoffrey Garen.

Edge filtering for CheckIdent ensures that a given value is either Symbol or StringIdent.
However, this filtering is not applied to CheckIdent when propagating a constant value in
the constant folding phase. As a result, it is not guaranteeed that a constant value
propagated in constant folding is Symbol or StringIdent.

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

8:42 AM Changeset in webkit [190990] by Alan Bujtas
  • 1 edit
    47 adds in trunk/LayoutTests

[iOS] Update anonymous table results for iOS port.

Unreviewed gardening.

  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-015-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-016-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-023-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-024-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-035-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-036-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-037-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-038-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-045-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-046-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-047-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-048-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-049-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-050-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-055-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-056-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-091-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-092-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-099-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-100-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-105-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-106-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-107-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-108-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-109-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-110-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-111-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-112-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-113-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-114-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-115-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-116-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-121-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-122-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-123-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-124-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-139-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-140-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-149-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-150-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-155-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-156-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-159-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-160-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-165-expected.txt: Added.
  • platform/ios-simulator/css2.1/tables/table-anonymous-objects-166-expected.txt: Added.
8:10 AM Changeset in webkit [190989] by Carlos Garcia Campos
  • 9 edits in releases/WebKitGTK/webkit-2.10

Merge r190987 - [GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
https://bugs.webkit.org/show_bug.cgi?id=150085

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

  • Shared/gtk/NativeWebTouchEventGtk.cpp:
  • Shared/gtk/WebEventFactory.cpp:
  • Shared/gtk/WebEventFactory.h:
  • UIProcess/API/gtk/PageClientImpl.cpp:
  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkit_web_view_base_class_init):

Tools:

  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
8:09 AM Changeset in webkit [190988] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2

Merge r190930 - Avoid useless copying of Key::HashType in loops in NetworkCache::Storage::synchronize()
https://bugs.webkit.org/show_bug.cgi?id=150061

Reviewed by Carlos Garcia Campos.

Avoid useless copying of Key::HashType in loops in NetworkCache::Storage::synchronize().
Key::HashType is currently a SHA1::Digest, which is a std::array<uint8_t, 20>.

  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::synchronize):

7:42 AM Changeset in webkit [190987] by svillar@igalia.com
  • 9 edits in trunk

[GTK] Fix build for ENABLE_TOUCH_EVENTS=OFF
https://bugs.webkit.org/show_bug.cgi?id=150085

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

  • Shared/gtk/NativeWebTouchEventGtk.cpp:
  • Shared/gtk/WebEventFactory.cpp:
  • Shared/gtk/WebEventFactory.h:
  • UIProcess/API/gtk/PageClientImpl.cpp:
  • UIProcess/API/gtk/PageClientImpl.h:
  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkit_web_view_base_class_init):

Tools:

  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
6:48 AM Changeset in webkit [190986] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2

Merge r189912 - [GTK] Crash in WebKit::BackingStore::createBackend running under Wayland
https://bugs.webkit.org/show_bug.cgi?id=147453

Reviewed by Carlos Garcia Campos.

Except when running on X11, this function always crashes if called before the web view is
realized, as gdk_window_create_similar_surface will return null in that case. Avoid this by
simply realizing the widget before calling that.

Thanks to Carlos Garnacho for some debugging help.

  • UIProcess/cairo/BackingStoreCairo.cpp:

(WebKit::BackingStore::createBackend):

6:48 AM WebKitGTK/2.10.x edited by Carlos Garcia Campos
(diff)
6:47 AM Changeset in webkit [190985] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.10

Merge r190909 - [GTK] OSX linker doesn't understand --whole-archive
https://bugs.webkit.org/show_bug.cgi?id=144557

Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-10-12
Reviewed by Martin Robinson.

.:

  • Source/cmake/OptionsGTK.cmake: Turn the macro

ADD_WHOLE_ARCHIVE_TO_LIBRARIES into a no-op on Darwin systems,
because XCode's linker doesn't have the --whole-archive option.

Source/WebKit2:

  • PlatformGTK.cmake: Link with extra libraries on Darwin, since

we don't have the --whole-archive linker option.

6:43 AM WebKitGTK/2.10.x edited by Carlos Garcia Campos
(diff)
6:29 AM Changeset in webkit [190984] by Carlos Garcia Campos
  • 12 edits
    4 adds in releases/WebKitGTK/webkit-2.10

Merge r190879 - Clip-path transitions sometimes trigger endless animation timers
https://bugs.webkit.org/show_bug.cgi?id=150018

Reviewed by Tim Horton.

Source/WebCore:

Transitioning -webkit-clip-path could trigger endless animation
timers, because when CompositeAnimation::updateTransitions() calls
isTargetPropertyEqual(), a false negative answer triggers canceling the
current transition and starting a new one over and over.

This happened because StyleRareNonInheritedData simply tested pointer
equality for m_clipPath and m_shapeOutside. Both of these need to do deep
equality testing, requiring the implementation of operator== in BasicShapes
classes.

In addition, the PropertyWrappers in CSSPropertyAnimation need equals()
implementations that also do more than pointer equality testing.

Tests: transitions/clip-path-transitions.html

transitions/shape-outside-transitions.html

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::PropertyWrapperClipPath::equals):
(WebCore::PropertyWrapperShape::equals):

  • rendering/ClipPathOperation.h:
  • rendering/style/BasicShapes.cpp:

(WebCore::BasicShapeCircle::operator==):
(WebCore::BasicShapeEllipse::operator==):
(WebCore::BasicShapePolygon::operator==):
(WebCore::BasicShapeInset::operator==):

  • rendering/style/BasicShapes.h:

(WebCore::BasicShapeCenterCoordinate::operator==):
(WebCore::BasicShapeRadius::operator==):

  • rendering/style/ShapeValue.cpp:

(WebCore::pointersOrValuesEqual):
(WebCore::ShapeValue::operator==):

  • rendering/style/ShapeValue.h:

(WebCore::ShapeValue::operator!=):
(WebCore::ShapeValue::operator==): Deleted.
(WebCore::ShapeValue::ShapeValue): Deleted.

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::operator==):
(WebCore::StyleRareNonInheritedData::clipPathOperationsEquivalent):
(WebCore::StyleRareNonInheritedData::shapeOutsideDataEquivalent):

  • rendering/style/StyleRareNonInheritedData.h:

LayoutTests:

New tests for transitions of clip-path and shape-outside.

  • transitions/clip-path-transitions-expected.txt: Added.
  • transitions/clip-path-transitions.html: Added.
  • transitions/resources/transition-test-helpers.js:

(parseClipPath):
(checkExpectedValue):

  • transitions/shape-outside-transitions-expected.txt: Added.
  • transitions/shape-outside-transitions.html: Added.
  • transitions/svg-transitions-expected.txt:
6:12 AM Changeset in webkit [190983] by Antti Koivisto
  • 18 edits
    2 adds in trunk

Implement iterator for traversing composed DOM
https://bugs.webkit.org/show_bug.cgi?id=149997

Reviewed by Ryosuke Niwa.

Source/WebCore:

ComposedTreeIterator traverses the DOM in composed tree order. This means it enters
shadow trees and follows slots created by Shadow DOM API correctly.

auto children = composedTreeChildren(containerNode);
for (auto& composedChild : children)

...

auto descendants = composedTreeDescendants(containerNode);
for (auto& composedDescendant : descendants)

...

  • WebCore.xcodeproj/project.pbxproj:
  • dom/ComposedTreeIterator.cpp: Added.

(WebCore::ComposedTreeIterator::initializeShadowStack):
(WebCore::ComposedTreeIterator::traverseNextInShadowTree):
(WebCore::ComposedTreeIterator::traverseNextSiblingSlot):
(WebCore::ComposedTreeIterator::traversePreviousSiblingSlot):
(WebCore::ComposedTreeIterator::traverseParentInShadowTree):

  • dom/ComposedTreeIterator.h: Added.

(WebCore::ComposedTreeIterator::operator*):
(WebCore::ComposedTreeIterator::operator->):
(WebCore::ComposedTreeIterator::operator==):
(WebCore::ComposedTreeIterator::operator!=):
(WebCore::ComposedTreeIterator::ShadowContext::ShadowContext):
(WebCore::ComposedTreeIterator::ComposedTreeIterator):
(WebCore::ComposedTreeIterator::traverseNext):
(WebCore::ComposedTreeIterator::traverseNextSibling):
(WebCore::ComposedTreeIterator::traversePreviousSibling):
(WebCore::ComposedTreeIterator::traverseParent):
(WebCore::ComposedTreeChildAdapter::Iterator::Iterator):
(WebCore::ComposedTreeChildAdapter::Iterator::operator++):
(WebCore::ComposedTreeChildAdapter::Iterator::operator--):
(WebCore::ComposedTreeChildAdapter::ComposedTreeChildAdapter):
(WebCore::ComposedTreeChildAdapter::begin):
(WebCore::ComposedTreeChildAdapter::end):
(WebCore::ComposedTreeChildAdapter::at):
(WebCore::composedTreeChildren):

  • dom/NodeRenderingTraversal.cpp:

(WebCore::NodeRenderingTraversal::parentSlow):
(WebCore::NodeRenderingTraversal::nextInScope):
(WebCore::NodeRenderingTraversal::firstChildSlow): Deleted.
(WebCore::NodeRenderingTraversal::nextSiblingSlow): Deleted.
(WebCore::NodeRenderingTraversal::previousSiblingSlow): Deleted.

  • dom/NodeRenderingTraversal.h:

(WebCore::NodeRenderingTraversal::parent):
(WebCore::NodeRenderingTraversal::firstChild): Deleted.
(WebCore::NodeRenderingTraversal::nextSibling): Deleted.
(WebCore::NodeRenderingTraversal::previousSibling): Deleted.

  • style/RenderTreePosition.cpp:

(WebCore::RenderTreePosition::computeNextSibling):

Restore the full assert.

(WebCore::RenderTreePosition::invalidateNextSibling):
(WebCore::RenderTreePosition::previousSiblingRenderer):
(WebCore::RenderTreePosition::nextSiblingRenderer):

Make these member functions.
Use the iterator. This is fixes some bugs and allows enabling a test case.

  • style/RenderTreePosition.h:
  • style/StyleResolveTree.cpp:

(WebCore::Style::textRendererIsNeeded):

LayoutTests:

Re-enable fast/html/details-replace-text.html which is fixed by this change.

  • fast/forms/select-listbox-focus-displaynone-expected.txt:
  • fast/repaint/text-in-relative-positioned-inline-expected.txt:
  • fullscreen/full-screen-fixed-pos-parent-expected.txt:
  • platform/mac-mavericks/fast/html/details-open2-expected.txt:
  • platform/mac/fast/html/details-add-child-2-expected.txt:
  • platform/mac/fast/html/details-open2-expected.txt:

Non-visual whitespace changes.

6:05 AM Changeset in webkit [190982] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore

Merge r190862 - webkit-gtk 2.3.3 fails to build on OS X - Conflicting type "Fixed"
https://bugs.webkit.org/show_bug.cgi?id=126433

Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-10-12
Reviewed by Philippe Normand

Don't include CoreFoundation.h when building the GTK port.

  • Source/JavaScriptCore/API/WebKitAvailability.h: Add !defined(BUILDING_GTK) to defined(APPLE).
6:03 AM Changeset in webkit [190981] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore

Merge r190857 - webkit-gtk-2.3.4 fails to link JavaScriptCore, missing symbols add_history and readline
https://bugs.webkit.org/show_bug.cgi?id=127059

Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-10-12
Reviewed by Philippe Normand.

  • shell/CMakeLists.txt: Link JSC with -ledit on Mac OSX.
6:01 AM Changeset in webkit [190980] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.10

Merge r190856 - [GTK] Use --version-script only on Linux
https://bugs.webkit.org/show_bug.cgi?id=144555

Patch by Philip Chimento <philip.chimento@gmail.com> on 2015-10-12
Reviewed by Philippe Normand.

  • Source/cmake/OptionsGTK.cmake: Don't add --version-script

option on Darwin (whose linker doesn't support it.)

5:46 AM WebKitGTK/2.10.x edited by clopez@igalia.com
(diff)
5:44 AM WebKitGTK/2.8.x edited by clopez@igalia.com
(diff)
5:43 AM Changeset in webkit [190979] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.10/Source/JavaScriptCore

Merge r190843 - Reduce pointless malloc traffic in CodeBlock construction.
<https://webkit.org/b/149999>

Reviewed by Antti Koivisto.

Create the RefCountedArray<Instruction> for CodeBlock's m_instructions directly
instead of first creating a Vector<Instruction> and then creating a RefCountedArray
from that. None of the Vector functionality is needed here anyway.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::insertBasicBlockBoundariesForControlFlowProfiler):

  • bytecode/CodeBlock.h:
5:05 AM Changeset in webkit [190978] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190842 - Reduce pointless malloc traffic in ElementRuleCollector.
<https://webkit.org/b/150003>

Reviewed by Antti Koivisto.

Don't use a unique_ptr for the m_matchedRules vector in ElementRuleCollector.
This is one of our heaviest sources of transient allocations, with ~88000
malloc/free pairs on loading theverge.com.

  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::addMatchedRule):
(WebCore::ElementRuleCollector::clearMatchedRules):
(WebCore::ElementRuleCollector::sortAndTransferMatchedRules):
(WebCore::ElementRuleCollector::sortMatchedRules):
(WebCore::ElementRuleCollector::hasAnyMatchingRules):

  • css/ElementRuleCollector.h:

(WebCore::ElementRuleCollector::hasMatchedRules):

5:03 AM Changeset in webkit [190977] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190835 - Check if start and end positions are still valid after updating them through VisibleSelection.
https://bugs.webkit.org/show_bug.cgi?id=149982

Reviewed by Ryosuke Niwa.

This patch is required to be able to clean up anonymous tables structure.
In certain edge cases, start/end positions could become nullptr after various text splitting
operations.

Covered by editing/execCommand/crash-137961.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
(WebCore::ApplyStyleCommand::applyInlineStyle):

5:01 AM Changeset in webkit [190976] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.10

Merge r190820 - Garbage texture data with composited table row
https://bugs.webkit.org/show_bug.cgi?id=148984

Reviewed by Zalan Bujtas.
Source/WebCore:

Don't pretend to know if the layer for a table header, section or cell is
opaque, since table painting is special.

Test: compositing/contents-opaque/table-parts.html

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

  • compositing/contents-opaque/table-parts-expected.txt: Added.
  • compositing/contents-opaque/table-parts.html: Added.
5:00 AM Changeset in webkit [190975] by Carlos Garcia Campos
  • 7 edits
    2 adds in releases/WebKitGTK/webkit-2.10

Merge r190818 - Garbage pixels on enphaseenergy.com site
https://bugs.webkit.org/show_bug.cgi?id=149915
rdar://problem/22976184

Reviewed by Darin Adler.

Source/WebCore:

When the <html> gets a composited RenderLayer, and we ask whether its background
is opaque, return false, since the document element's background propagates
to the root, and is painted by the RenderView.

Also improve the compositing logging to indicate when fore- and background layers
are present.

Test: compositing/contents-opaque/negative-z-before-html.html

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGeometry):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::logLayerInfo):

LayoutTests:

New ref test. Also update the expected result for another test that uses negative
z-index children.

  • compositing/contents-opaque/body-background-painted-expected.txt:
  • compositing/contents-opaque/negative-z-before-html-expected.html: Added.
  • compositing/contents-opaque/negative-z-before-html.html: Added.
  • platform/mac-wk2/compositing/contents-opaque/body-background-painted-expected.txt:
4:56 AM Changeset in webkit [190974] by Carlos Garcia Campos
  • 5 edits
    3 adds in releases/WebKitGTK/webkit-2.10

Merge r190760 - Gracefully handle XMLDocumentParser being detached by mutation events.
https://bugs.webkit.org/show_bug.cgi?id=149485
<rdar://problem/22811489>

Source/WebCore:

This is a merge of Blink change 200026,
https://codereview.chromium.org/1267283002

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-08
Reviewed by Darin Adler.

Test: fast/parser/xhtml-dom-character-data-modified-crash.html

  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::createLeafTextNode):
Renamed from enterText() to make it more descriptive.

(WebCore::XMLDocumentParser::updateLeafTextNode):
Renamed from exitText to firm up this stage.

(WebCore::XMLDocumentParser::end):
Gracefully handle stopped states.

(WebCore::XMLDocumentParser::enterText): Deleted.
(WebCore::XMLDocumentParser::exitText): Deleted.

  • xml/parser/XMLDocumentParser.h:

Rename enterText to createLeafTextNode.
Rename exitText to updateLeafTextNode.

  • xml/parser/XMLDocumentParserLibxml2.cpp:

(WebCore::XMLDocumentParser::startElementNs):
(WebCore::XMLDocumentParser::endElementNs):
(WebCore::XMLDocumentParser::characters):
(WebCore::XMLDocumentParser::processingInstruction):
(WebCore::XMLDocumentParser::cdataBlock):
(WebCore::XMLDocumentParser::comment):
(WebCore::XMLDocumentParser::endDocument):
Rename function calls and firm up updateLeafTextNode stage accordingly.

LayoutTests:

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-08
Reviewed by Darin Adler.

  • fast/parser/resources/xhtml-overwrite-frame.xhtml: Added.
  • fast/parser/xhtml-dom-character-data-modified-crash-expected.txt: Added.
  • fast/parser/xhtml-dom-character-data-modified-crash.html: Added.
4:50 AM Changeset in webkit [190973] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190755 - data: URLs should not be preloaded
https://bugs.webkit.org/show_bug.cgi?id=149829

Reviewed by Darin Adler.

Fix review comments after r190605:
Use protocolIs() instead of String::startsWith().

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):

4:47 AM Changeset in webkit [190972] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.10

Merge r190732 - Add NULL check for renderBox::layer() on applying zoom level change
https://bugs.webkit.org/show_bug.cgi?id=149302
<rdar://problem/22747292>

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-08
Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/zoom-on-nested-scroll-crash.html

This is a merge of Blink r158238:
https://chromiumcodereview.appspot.com/23526081

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):

LayoutTests:

  • fast/css/zoom-on-nested-scroll-crash-expected.txt: Added.
  • fast/css/zoom-on-nested-scroll-crash.html: Added.
4:38 AM Changeset in webkit [190971] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.10

Merge r190728 - CrashTracer: [USER] com.apple.WebKit.WebContent at …Core::SelectorChecker::checkScrollbarPseudoClass const + 217
https://bugs.webkit.org/show_bug.cgi?id=149921
rdar://problem/22731359

Reviewed by Andreas Kling.

Source/WebCore:

Test: svg/css/use-window-inactive-crash.html

  • css/SelectorCheckerTestFunctions.h:

(WebCore::isWindowInactive):

Null check page.

LayoutTests:

The test crashes with shipping WebKit but not with current ToT (probably due to shadow DOM styling changes). Still adding
it for coverage.

  • svg/css/use-window-inactive-crash-expected.html: Added.
  • svg/css/use-window-inactive-crash.html: Added.
4:30 AM Changeset in webkit [190970] by ChangSeok Oh
  • 2 edits in trunk/Source/WebCore

[GTK] Use GUniquePtr for GtkIconInfo
https://bugs.webkit.org/show_bug.cgi?id=150082

Reviewed by Carlos Garcia Campos.

GtkIconInfo cab be wrapped by a smart pointer, GUniqueptr.

No new test required since no functionality changed.

  • rendering/RenderThemeGtk.cpp:

(WebCore::getStockSymbolicIconForWidgetType):

4:24 AM Changeset in webkit [190969] by Carlos Garcia Campos
  • 3 edits
    5 adds in releases/WebKitGTK/webkit-2.10

Merge r190662 - [GTK] Progress bar is broken on recent GTK+
https://bugs.webkit.org/show_bug.cgi?id=149831

Reviewed by Carlos Garcia Campos.

Source/WebCore:

The gtk progress bar has been broken after bumping up to Gtk+-3.16. This is because
the way of rendering progress bar changed after gtk+-3.13.7. See more
https://mail.gnome.org/archives/commits-list/2014-August/msg03865.html
gtk_render_activity is no longer valid to paint a progress bar on a newer gtk+.
It should be done with gtk_render_background and gtk_render_frame.

Test: fast/dom/HTMLProgressElement/native-progress-bar.html

  • rendering/RenderThemeGtk.cpp:

(WebCore::RenderThemeGtk::paintProgressBar):

LayoutTests:

  • fast/dom/HTMLProgressElement/native-progress-bar.html: Added.
  • platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.png: Added.
  • platform/gtk/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt: Added.
  • platform/mac/fast/dom/HTMLProgressElement/native-progress-bar-expected.png: Added.
  • platform/mac/fast/dom/HTMLProgressElement/native-progress-bar-expected.txt: Added.
4:21 AM Changeset in webkit [190968] by Carlos Garcia Campos
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-2.10

Merge r190658 - Paint artifacts when hovering on http://jsfiddle.net/Sherbrow/T87Mn/
https://bugs.webkit.org/show_bug.cgi?id=149535
rdar://problem/22874920

Reviewed by Simon Fraser.

When due to some style change, a renderer's self-painting layer is getting destroyed
and the parent's overflow is no longer set to visible, we don't clean up the overflow part.

When a renderer has a self-painting layer, the parent stops tracking the child's
visual overflow rect. All overflow painting is delegated to the self-painting layer.
However when this layer gets destroyed, no-one issues repaint to clean up
the overflow bits.
This patch ensures that we issue a repaint when the self-painting layer is destroyed
and the triggering style change requires full repaint.

Source/WebCore:

Test: fast/repaint/overflow-hidden-with-self-painting-child-layer.html

  • rendering/RenderLayer.h:
  • rendering/RenderLayerModelObject.cpp:

(WebCore::RenderLayerModelObject::styleDidChange):

LayoutTests:

  • css3/blending/repaint/blend-mode-isolate-stacking-context-expected.txt: progression.
  • fast/repaint/absolute-position-change-containing-block-expected.txt: progression.
  • fast/repaint/overflow-hidden-with-self-painting-child-layer-expected.txt: Added.
  • fast/repaint/overflow-hidden-with-self-painting-child-layer.html: Added.
4:04 AM Changeset in webkit [190967] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190641 - Refactor TokenPreloadScanner::StartTagScanner::processAttribute()
https://bugs.webkit.org/show_bug.cgi?id=149847

Reviewed by Antti Koivisto.

Refactor TokenPreloadScanner::StartTagScanner::processAttribute() to only
process attributes that make sense given the current tagId. In particular,

  • We only process the charset parameter if the tag is a link or a script.
  • We only process the sizes / srcset attributes if the tag is an img.
  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):
(WebCore::TokenPreloadScanner::StartTagScanner::setUrlToLoad): Deleted.

4:03 AM Changeset in webkit [190966] by Carlos Garcia Campos
  • 3 edits
    4 adds in releases/WebKitGTK/webkit-2.10

Merge r190634 - Fix crash in ApplyStyleCommand::applyRelativeFontStyleChange()
https://bugs.webkit.org/show_bug.cgi?id=149300
<rdar://problem/22747046>

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-06
Reviewed by Chris Dumez.

Source/WebCore:

This is a merge of Blink r167845 and r194944:
https://codereview.chromium.org/177093016
https://codereview.chromium.org/1124863003

Test: editing/style/apply-style-crash2.html

editing/style/apply-style-crash3.html

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
The issue was that we would traverse the DOM tree past the beyondEnd
under some circumstances and thus NodeTraversal::next() would return
null unexpectedly. This CL adds a check to make sure startNode != beyondEnd
before traversing to avoid the problem.

Besides that, this CL hardens changing font style over unknown elements.
When adjusting the start node position of where to apply a font style
command, check that we haven't stepped off the end.

This CL also adds a few more assertions to catch similar issues
more easily in the future.

LayoutTests:

  • editing/style/apply-style-crash2-expected.txt: Added.
  • editing/style/apply-style-crash2.html: Added.
  • editing/style/apply-style-crash3-expected.txt: Added.
  • editing/style/apply-style-crash3.html: Added.
4:02 AM Changeset in webkit [190965] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190627 - Remove redundant isComposited() function and replace
hasLayer() && layer()->isComposited() with RenderObject::isComposited().
https://bugs.webkit.org/show_bug.cgi?id=149846

Reviewed by Simon Fraser.

No change in functionality.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingForPlugin):
(WebCore::RenderLayerCompositor::requiresCompositingForFrame):

  • rendering/RenderObject.cpp:

(WebCore::RenderObject::repaintUsingContainer):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSnapshottedPluginOverlay):

  • rendering/RenderView.cpp:

(WebCore::rendererObscuresBackground):
(WebCore::isComposited): Deleted.

  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::setWidgetGeometry):

4:00 AM Changeset in webkit [190964] by Carlos Garcia Campos
  • 20 edits in releases/WebKitGTK/webkit-2.10

Merge r190615 - Fix ENABLE_OPENGL=OFF builds
https://bugs.webkit.org/show_bug.cgi?id=146511

Patch by Emanuele Aina <Emanuele Aina> on 2015-10-06
Reviewed by Darin Adler.

.:

  • Source/cmake/OptionsGTK.cmake: Make ENABLE_WAYLAND_TARGET depend on

ENABLE_OPENGL due to EGL usage.

Source/WebCore:

  • platform/graphics/texmap/BitmapTextureGL.h:
  • platform/graphics/texmap/BitmapTextureGL.cpp:
  • platform/graphics/texmap/TextureMapperGL.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:
  • platform/graphics/texmap/TextureMapperShaderProgram.h:
  • platform/graphics/texmap/TextureMapperShaderProgram.cpp:

Fix TEXTURE_MAPPER_GL vs. TEXTURE_MAPPER guards to make sure that
ENABLE_OPENGL=OFF only disables the GL-related parts.

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseRealize):
(webkitWebViewBaseDraw):
(webkitWebViewBaseDidRelaunchWebProcess):
Replace USE(TEXTURE_MAPPER_GL) with USE(TEXTURE_MAPPER) around
webkitWebViewRenderAcceleratedCompositingResults()

  • UIProcess/DrawingAreaProxyImpl.cpp:
  • UIProcess/DrawingAreaProxyImpl.h:
  • WebProcess/WebPage/DrawingArea.cpp:

(WebKit::DrawingArea::DrawingArea):

  • WebProcess/WebPage/DrawingArea.h:
  • WebProcess/WebPage/LayerTreeHost.h:

Replace USE(TEXTURE_MAPPER_GL) with USE(TEXTURE_MAPPER) around
setNativeSurfaceHandleForCompositing().

  • UIProcess/gtk/WebPreferencesGtk.cpp:

(WebKit::WebPreferences::platformInitializeStore):
Default to no AC if no GL support has been built.

  • WebProcess/WebPage/DrawingArea.messages.in:

Replace USE(TEXTURE_MAPPER_GL) with USE(TEXTURE_MAPPER) around
SetNativeSurfaceHandleForCompositing.

  • WebProcess/WebPage/DrawingAreaImpl.h:
  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::enterAcceleratedCompositingMode):
Replace USE(TEXTURE_MAPPER_GL) with USE(TEXTURE_MAPPER) around
setNativeSurfaceHandleForCompositing().
(WebKit::DrawingAreaImpl::setNativeSurfaceHandleForCompositing):
Force setAcceleratedCompositingEnabled() only if a LayerTreeHost
implementation is available, to avoid crashing when building without
any GL support.

3:57 AM Changeset in webkit [190963] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.10

Merge r190605 - data: URLs should not be preloaded
https://bugs.webkit.org/show_bug.cgi?id=149829

Reviewed by Ryosuke Niwa.

Source/WebCore:

Update the HTMLPreloadScanner so that data: URLs do not get preloaded.
There is no need as the data is already available.

Test: fast/preloader/image-data-url.html

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::shouldPreload):

LayoutTests:

Add layout test to make sure that images with a data: URL do not
get preloaded.

  • fast/preloader/image-data-url-expected.txt: Added.
  • fast/preloader/image-data-url.html: Added.
3:56 AM Changeset in webkit [190962] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.10

Merge r190597 - CSSGradientValue should check whether gradientLength is zero or not.
https://bugs.webkit.org/show_bug.cgi?id=149373
<rdar://problem/22771418>

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-05
Reviewed by Darin Adler.

Source/WebCore:

This is a merge of Blink r158220,
https://chromiumcodereview.appspot.com/24350008

Test: fast/gradients/css3-repeating-radial-gradients-crash.html

  • css/CSSGradientValue.cpp:

(WebCore::CSSGradientValue::addStops):
Check whether gradientLength > 0 before using it as denominator.

LayoutTests:

  • fast/gradients/css3-repeating-radial-gradients-crash-expected.txt: Added.
  • fast/gradients/css3-repeating-radial-gradients-crash.html: Added.
3:55 AM Changeset in webkit [190961] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.10

Merge r190592 - Reference cycles during SVG dependency invalidation
https://bugs.webkit.org/show_bug.cgi?id=149824
<rdar://problem/22771412>

Reviewed by Tim Horton.

Source/WebCore:

Detect any reference cycles as we are invalidating.

This is mostly a merge of the following Blink commit:
https://chromium.googlesource.com/chromium/blink/+/a4bc83453bda89823b672877dc02247652a02d51

Test: svg/custom/reference-cycle.svg

  • rendering/svg/RenderSVGResource.cpp:

(WebCore::removeFromCacheAndInvalidateDependencies): Keep around a hash
table of dependencies, so that we can detect if an element is already
present before marking it.

LayoutTests:

Adding a test that has a cycle between feImage resources.

Merge Blink commit:
https://chromium.googlesource.com/chromium/blink/+/a4bc83453bda89823b672877dc02247652a02d51

  • svg/custom/reference-cycle-expected.txt: Added.
  • svg/custom/reference-cycle.svg: Added.
3:54 AM Changeset in webkit [190960] by Carlos Garcia Campos
  • 7 edits
    3 adds in releases/WebKitGTK/webkit-2.10

Merge r190588 - Fix null pointer dereference in WebSocket::connect()
https://bugs.webkit.org/show_bug.cgi?id=149311
<rdar://problem/22748858>

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2015-10-05
Reviewed by Chris Dumez.

Source/WebCore:

This is a merge of Blink r187441,
https://codereview.chromium.org/785933005

Test: http/tests/websocket/construct-in-detached-frame.html

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):
Call function implemented below instead of duplicating the code.

  • page/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::shouldBypassMainWorldContentSecurityPolicy):

  • page/ContentSecurityPolicy.h:

Factor the logic to check shouldBypassMainWorldContentSecurityPolicy into
a function in this class. Check Frame pointers are not null before getting
shouldBypassMainWorldContentSecurityPolicy via those pointers.

  • page/EventSource.cpp:

(WebCore::EventSource::create):
This got fixed as a bonus.

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):
This got fixed as a bonus too.

LayoutTests:

  • http/tests/websocket/construct-in-detached-frame-expected.txt: Added.
  • http/tests/websocket/construct-in-detached-frame.html: Added.
  • http/tests/websocket/resources/construct-in-detached-frame.html: Added.
3:53 AM Changeset in webkit [190959] by Sebastian Dröge
  • 2 edits in trunk/Tools

Unreviewed, add myself to the committers list.

3:51 AM Changeset in webkit [190958] by Carlos Garcia Campos
  • 3 edits
    3 adds in releases/WebKitGTK/webkit-2.10

Merge r190585 - ShadowRoot with leading or trailing white space cause a crash
https://bugs.webkit.org/show_bug.cgi?id=149782

Reviewed by Chris Dumez.

Source/WebCore:

Fixed the crash by adding a null pointer check since a TextNode that appears as a direct child
of a ShadowRoot doesn't have a parent element.

Test: fast/shadow-dom/shadow-root-with-child-whitespace-text-crash.html

  • style/RenderTreePosition.cpp:

(WebCore::RenderTreePosition::previousSiblingRenderer):

LayoutTests:

Added a regression test.

  • fast/shadow-dom/shadow-root-with-child-whitespace-text-crash-expected.txt: Added.
  • fast/shadow-dom/shadow-root-with-child-whitespace-text-crash.html: Added.
3:49 AM Changeset in webkit [190957] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.10

Merge r190570 - Mark the line dirty when RenderQuote's text changes.
https://bugs.webkit.org/show_bug.cgi?id=149784
rdar://problem/22558169

Reviewed by Antti Koivisto.

When quotation mark changes ( " -> ' or empty string), we
need to mark the line dirty to ensure its content gets laid out properly.

Source/WebCore:

Test: fast/inline/quotation-text-changes-dynamically.html

  • rendering/RenderQuote.cpp:

(WebCore::quoteTextRenderer):
(WebCore::RenderQuote::updateText):
(WebCore::fragmentChild): Deleted.

LayoutTests:

  • fast/inline/quotation-text-changes-dynamically-expected.txt: Added.
  • fast/inline/quotation-text-changes-dynamically.html: Added.
3:47 AM Changeset in webkit [190956] by Carlos Garcia Campos
  • 5 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190558 - GLContext should control ownership of context-related objects
https://bugs.webkit.org/show_bug.cgi?id=149794

Reviewed by Martin Robinson.

Creation of GLContext objects can depend on various platform-specific
objects like native window representations. Since these objects are
used solely for the GLContext purposes, it would make sense to allow
GLContext to provide an extensible way to impose ownership on these
objects and control their lifetime.

GLContext::Data is declared with a defaulted virtual destructor.
Users of these implementations can declare classes that derive from
GLContext::Data and store context-related objects in instances of the
derived class, and ensure that these objects are properly cleaned up
when GLContext destroys the Data object.

The GLContext::Data object is managed through a protected
std::unique_ptr<> member in the GLContext class. For now the member
is only set in GLContextEGL::createWindowContext() and is destroyed
during the GLContext destruction.

The local OffscreenContextData class in
PlatformDisplayWayland::createSharingGLContext() derives from
GLContext::Data and is used to store the wl_surface and
EGLNativeWindowType (aka wl_egl_window) objects for offscreen
GLContexts under the Wayland platform that are used for the sharing
context and WebGL, effectively avoiding the leak that would further
propagate problems into the compositor and the graphics library.
(Such offscreen contexts are actually mimicked via a 1x1px
wl_egl_window object that acts as a dummy base for the related
wl_surface object).

  • platform/graphics/GLContext.h:
  • platform/graphics/egl/GLContextEGL.cpp:

(WebCore::GLContextEGL::createWindowContext):

  • platform/graphics/egl/GLContextEGL.h:
  • platform/graphics/wayland/PlatformDisplayWayland.cpp:

(WebCore::PlatformDisplayWayland::createSharingGLContext):

3:45 AM Changeset in webkit [190955] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190557 - Make gdk.h inclusion in FontPlatformDataFreeType.cpp properly GTK-specific
https://bugs.webkit.org/show_bug.cgi?id=149793

Reviewed by Carlos Garcia Campos.

  • platform/graphics/freetype/FontPlatformDataFreeType.cpp:

Instead of including <gdk/gdk.h> header for all platforms but EFL, only
include it for the GTK platform, since no other platform depends on the
GDK library.

3:41 AM Changeset in webkit [190954] by Carlos Garcia Campos
  • 28 edits in releases/WebKitGTK/webkit-2.10

Merge r190505 - popstate is fired at the wrong time on load
https://bugs.webkit.org/show_bug.cgi?id=94265

Patch by Antoine Quint <Antoine Quint> on 2015-10-02
Reviewed by Darin Adler.

Source/WebCore:

Don't fire popstate event on initial document load

According to the specification [1], a popstate event should only be fired
when the document has a "last entry" and the entry being navigated to isn't
it. A document is created without a "last entry" and gets one just after
this check when it is first navigated to, so a popstate should be fired any
time a document is navigated to except for the first time after it has been
created.

Patch adapted from work by jl@opera.com on Blink [2].

[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#traverse-the-history (step 12-14 in particular)
[2] https://src.chromium.org/viewvc/blink?revision=165221&view=revision

  • dom/Document.cpp:

(WebCore::Document::implicitClose):

Source/WebKit2:

Ensure we have a valid page before trying to get to its drawingArea as this could lead
to a crash as observed with fast/loader/stateobjects/pushstate-object-types.html.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::restoreViewState):

LayoutTests:

Updating tests that relied on a "popstate" event being fired at page load.

  • fast/history/same-document-iframes-changing-fragment-expected.txt:
  • fast/history/same-document-iframes-changing-pushstate-expected.txt:
  • fast/loader/javascript-url-iframe-remove-on-navigate.html:
  • fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html:
  • fast/loader/stateobjects/document-destroyed-navigate-back.html:
  • fast/loader/stateobjects/popstate-after-load-complete-addeventlistener.html:
  • fast/loader/stateobjects/popstate-after-load-complete-body-attribute.html:
  • fast/loader/stateobjects/popstate-after-load-complete-body-inline-attribute.html:
  • fast/loader/stateobjects/popstate-after-load-complete-window-attribute.html:
  • fast/loader/stateobjects/popstate-fires-on-history-traversal-expected.txt:
  • fast/loader/stateobjects/popstate-fires-on-history-traversal.html:
  • fast/loader/stateobjects/popstate-fires-with-page-cache-expected.txt:
  • fast/loader/stateobjects/popstate-fires-with-page-cache.html:
  • fast/loader/stateobjects/pushstate-object-types.html:
  • fast/loader/stateobjects/pushstate-then-replacestate.html:
  • fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html:
  • fast/loader/stateobjects/replacestate-then-pushstate.html:
  • fast/loader/stateobjects/resources/popstate-fires-with-page-cache-1.html:
  • fast/loader/stateobjects/resources/popstate-fires-with-page-cache-2.html:
  • fast/loader/stateobjects/resources/replacestate-in-iframe-window-child.html:
  • http/tests/history/popstate-fires-with-pending-requests.html:
  • http/tests/navigation/redirect-on-back-updates-history-item-expected.txt:
  • http/tests/navigation/redirect-on-reload-updates-history-item-expected.txt:
3:35 AM Changeset in webkit [190953] by Carlos Garcia Campos
  • 3 edits
    6 adds in releases/WebKitGTK/webkit-2.10

Merge r190418 - Network cache: Subresource referer header wrong after cached redirect
https://bugs.webkit.org/show_bug.cgi?id=149709
rdar://problem/22917174

Reviewed by Chris Dumez.

Source/WebKit2:

If a main resource is loaded from a cache entry that involved redirects the document
will end up setting the Referer-headers of the subresources to the request URL not the redirected URL

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):

If a cache entry involved a redirect synthesize a minimal willSendRequest message so that WebCore side
runs through the same code paths as when receiving a redirect from network.

LayoutTests:

  • http/tests/cache/redirect-referer-expected.html: Added.
  • http/tests/cache/redirect-referer.html: Added.
  • http/tests/cache/resources/load-and-check-referer.php: Added.
  • http/tests/cache/resources/permanent-redirect.php: Added.
  • http/tests/cache/resources/redirect-referer-iframe.html: Added.
  • http/tests/cache/resources/redirect-referer-iframe-expected.html: Added.
3:34 AM Changeset in webkit [190952] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.10

Merge r190413 - [GTK] Websites with invalid auth header keep loading forever
https://bugs.webkit.org/show_bug.cgi?id=149710

Reviewed by Martin Robinson.

Source/WebCore:

We don't correctly handle a null realm from the server when
retrieving and storing credentials from libsecret. First
secret_attributes_build() fails because we pass a null domain, and
we pass null attributes to secret_service_search() that returns
early on a g_return macro and the callback is never called so the
load doesn't continue after the auth challenge.

  • platform/network/gtk/CredentialBackingStore.cpp:

(WebCore::createAttributeHashTableFromChallenge):
(WebCore::CredentialBackingStore::credentialForChallenge):
(WebCore::CredentialBackingStore::storeCredentialsForChallenge):

Source/WebKit2:

Do not show the remember credentials checkbutton in the auth
dialog if the realm is empty.

  • UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:

(webkitAuthenticationDialogInitialize):

Tools:

Add test case to check that we can authenticate sites with an
empty realm.

  • TestWebKitAPI/Tests/WebKit2Gtk/TestAuthentication.cpp:

(testWebViewAuthenticationEmptyRealm):
(serverCallback):
(beforeAll):

3:30 AM Changeset in webkit [190951] by Carlos Garcia Campos
  • 1 edit
    2 adds in releases/WebKitGTK/webkit-2.10/Source/WebInspectorUI

Merge r190405 - [GTK] Web Inspector: Add GTK+ icons for the numerical input and slider based Visual editors for CSS properties
https://bugs.webkit.org/show_bug.cgi?id=147847

Reviewed by Carlos Garcia Campos.

  • UserInterface/Images/gtk/VisualStylePropertyLinked.svg: Added.
  • UserInterface/Images/gtk/VisualStylePropertyUnlinked.svg: Added.
3:30 AM Changeset in webkit [190950] by Carlos Garcia Campos
  • 3 edits
    19 adds in releases/WebKitGTK/webkit-2.10/Source/WebInspectorUI

Merge r190404 - [GTK] Web Inspector: Add GTK+ icons for the different types of non-numerical Visual editors for CSS properties
https://bugs.webkit.org/show_bug.cgi?id=147846

Reviewed by Carlos Garcia Campos.

  • UserInterface/Images/gtk/AUTHORS: Updated.
  • UserInterface/Images/gtk/ClearBoth.svg: Added.
  • UserInterface/Images/gtk/ClearLeft.svg: Added.
  • UserInterface/Images/gtk/ClearRight.svg: Added.
  • UserInterface/Images/gtk/CubicBezier.svg: Updated.
  • UserInterface/Images/gtk/FloatLeft.svg: Added.
  • UserInterface/Images/gtk/FloatRight.svg: Added.
  • UserInterface/Images/gtk/FontStyleItalic.svg: Added.
  • UserInterface/Images/gtk/FontStyleNormal.svg: Added.
  • UserInterface/Images/gtk/FontVariantSmallCaps.svg: Added.
  • UserInterface/Images/gtk/TextAlignCenter.svg: Added.
  • UserInterface/Images/gtk/TextAlignJustify.svg: Added.
  • UserInterface/Images/gtk/TextAlignLeft.svg: Added.
  • UserInterface/Images/gtk/TextAlignRight.svg: Added.
  • UserInterface/Images/gtk/TextDecorationLineThrough.svg: Added.
  • UserInterface/Images/gtk/TextDecorationOverline.svg: Added.
  • UserInterface/Images/gtk/TextDecorationUnderline.svg: Added.
  • UserInterface/Images/gtk/TextTransformCapitalize.svg: Added.
  • UserInterface/Images/gtk/TextTransformLowercase.svg: Added.
  • UserInterface/Images/gtk/TextTransformUppercase.svg: Added.
  • UserInterface/Images/gtk/VisualStyleNone.svg: Added.
3:26 AM Changeset in webkit [190949] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190382 - GraphicsContext3D::mappedSymbolName should initialize count variable
https://bugs.webkit.org/show_bug.cgi?id=149692
<rdar://problem/22871304>

Reviewed by Simon Fraser.

While debugging another WebGL issue, I noticed that some
OpenGL renderers can get into a state where they
drop resources (e.g. a GPU reset). If we don't detect that
in time, we might try to ask for the currently attached
resources and our in-parameter will not be set. In this
case, initialize it to zero so that we don't do silly things.

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::mappedSymbolName): Initialize count to 0.

3:25 AM Changeset in webkit [190948] by Carlos Garcia Campos
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-2.10

Merge r190375 - Crash when using an SVG font with > 390 glyphs
https://bugs.webkit.org/show_bug.cgi?id=149677
<rdar://problem/21676402>

Reviewed by Simon Fraser.

Source/WebCore:

The "Charset Index" in OTF are indices into a collection of strings. There are
390 predefined strings in this collection. We were currently assigning each
glyph to one of these strings. However, if there are more glyphs than strings,
we will be using invalid indices.

The values of the strings themselves are not necessary for SVG fonts. Therefore,
the solution is to create a single dummy string, and have all glyphs target it.

Tests: svg/custom/many-glyphs.svg

  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::font):

  • svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::appendCFFTable):

LayoutTests:

  • svg/custom/many-glyphs-expected.svg: Added.
  • svg/custom/many-glyphs.svg: Added.
3:23 AM Changeset in webkit [190947] by Carlos Garcia Campos
  • 1 edit
    1 add in releases/WebKitGTK/webkit-2.10/Source/WebInspectorUI

Merge r190369 - [GTK] Web Inspector: Add GTK+ icon for the Bezier curve visual editor
https://bugs.webkit.org/show_bug.cgi?id=147681

Reviewed by Joseph Pecoraro.

  • UserInterface/Images/gtk/CubicBezier.svg: Added.
3:23 AM Changeset in webkit [190946] by Carlos Garcia Campos
  • 15 edits in releases/WebKitGTK/webkit-2.10/Source

Merge r190364 - Unreviewed, roll out r188331: "NetworkProcess: DNS prefetch happens in the Web Process"
<rdar://problem/22560715>

Speculative roll out of r188331 as we had a ~2.5% PLT regression around
the time it landed and it seems the most likely culprit. I'll reland if
the perf bots do not recover after the roll out.

Source/WebCore:

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::parseAttribute):

  • loader/FrameLoaderClient.h:
  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::loadLink):

  • page/Chrome.cpp:

(WebCore::Chrome::mouseDidMoveOverElement):

Source/WebKit2:

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::storageSession): Deleted.

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkConnectionToWebProcess.messages.in:
  • WebProcess/InjectedBundle/API/gtk/WebKitWebExtension.cpp:

(webkitWebExtensionDidReceiveMessage):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::sendTapHighlightForNodeIfNecessary):

  • WebProcess/WebProcess.cpp:
  • WebProcess/WebProcess.h:
3:17 AM Changeset in webkit [190945] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2

Merge r190345 - [GTK] Build error with -DENABLE_SPELLCHECK=OFF
https://bugs.webkit.org/show_bug.cgi?id=146904

Reviewed by Carlos Garcia Campos.

Add ifdef guards to allow building when SPELLCHECK is not enabled.

  • UIProcess/gtk/TextCheckerGtk.cpp:

(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
(WebKit::TextChecker::setGrammarCheckingEnabled):
(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
(WebKit::TextChecker::checkSpellingOfString):
(WebKit::TextChecker::getGuessesForWord):
(WebKit::TextChecker::learnWord):
(WebKit::TextChecker::ignoreWord):
(WebKit::TextChecker::requestCheckingOfString):
(WebKit::TextChecker::checkTextOfParagraph):
(WebKit::TextChecker::setSpellCheckingLanguages):
(WebKit::TextChecker::loadedSpellCheckingLanguages):

3:16 AM Changeset in webkit [190944] by Carlos Garcia Campos
  • 14 edits in releases/WebKitGTK/webkit-2.10/Source

Merge r190344 - [GTK] Support HiDPI Properly in WebKitGtk+ with the TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=141782

Reviewed by Carlos Garcia Campos.

Source/WebCore:

This patch fixes HiDPI issue in the TextureMapper.
To support HiDPI in the TextureMapper, we need to draw scaled contents
in the TextureMapperTile, and apply the global scale in the root layer
to apply transforms correctly.

Supporting the device scale is handled at LayerTreeHostGtk and
TextureMapperBackingStore, and GraphicsLayerTextureMapper doesn't handle
the device scale directly.

From the TextureMapperLayer, deviceScale and pageScale do not have to be
handled differently. These are multiplied and provided to
TextureMapperBackingStore.

  • platform/graphics/texmap/TextureMapperTile.cpp:

(WebCore::TextureMapperTile::updateContents):

  • platform/graphics/texmap/TextureMapperTile.h:
  • platform/graphics/texmap/TextureMapperTiledBackingStore.cpp:

Modified to increase the cover rect for tiles creation. For the image
contents, it just creates texture with a image size, regardless of the
contents scale.

  • platform/graphics/texmap/BitmapTexture.cpp:

(WebCore::BitmapTexture::updateContents):

Apply the device scale to the graphics context before painting contents.

  • platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:

(WebCore::GraphicsLayerTextureMapper::setContentsToImage):
(WebCore::GraphicsLayerTextureMapper::updateBackingStoreIfNeeded):

Apply the device scale and the page scale to the backing store

Source/WebKit2:

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:
  • UIProcess/gtk/RedirectedXCompositeWindow.cpp:

Modified to create scaled size of window.

  • WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:

(WebKit::LayerTreeHostGtk::initialize):
(WebKit::LayerTreeHostGtk::deviceOrPageScaleFactorChanged):

We should apply device scale factor to the root layer to apply
the scale matrix before applying other transform matrices.

(WebKit::LayerTreeHostGtk::deviceScaleFactor): Added.
(WebKit::LayerTreeHostGtk::pageScaleFactor): Added.

3:06 AM Changeset in webkit [190943] by Carlos Garcia Campos
  • 4 edits
    2 adds in releases/WebKitGTK/webkit-2.10

Merge r190339 - Avoid reparsing an XSLT stylesheet after the first failure.
https://bugs.webkit.org/show_bug.cgi?id=149188
<rdar://problem/22709912>

Reviewed by Dave Hyatt.

Patch by Jiewen Tan, jiewen_tan@apple.com.

Source/WebCore:

Test: svg/custom/invalid-xslt-crash.svg

  • xml/XSLStyleSheet.h:

Add a new member variable m_compilationFailed that tracks whether
compilation has failed. Default value is false.

  • xml/XSLStyleSheetLibxslt.cpp:

(WebCore::XSLStyleSheet::compileStyleSheet):
Return early if the compilation has failed before. After compiling the
style sheet, if we failed, set m_compilationFailed to true.

LayoutTests:

  • svg/custom/invalid-xslt-crash-expected.txt: Added.
  • svg/custom/invalid-xslt-crash.svg: Added.
3:00 AM Changeset in webkit [190942] by Carlos Garcia Campos
  • 5 edits
    2 adds in releases/WebKitGTK/webkit-2.10

Merge r190320 - Memory cache revalidations should refresh the network disk cache
https://bugs.webkit.org/show_bug.cgi?id=149606

Reviewed by Darin Adler.

Source/WebKit2:

Previously, resource revalidations triggered by the memory cache would
bypass the disk cache entirely because the requests are conditional. As
a result, when the server responds with a 304, we were unable to update
the headers (e.g. new expiration date) of the corresponding entry in
the disk cache.

This patch updates our disk cache implementation to not bypass the disk
cache when the request is conditional. Instead, we look up the cached
entry and force its revalidation from the network. If the server then
returns a 304, we are now able to update the headers of this cached
entry. In such case though, we let the 304 response through to WebCore
unlike revalidations triggered by the disk cache.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponseAsync):

  • NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::makeUseDecision):
(WebKit::NetworkCache::makeRetrieveDecision):

LayoutTests:

Add layout test to check that revalidations requested by the memory cache
update the corresponding disk cache entry when the server responds with a
304 status code.

  • http/tests/cache/disk-cache/memory-cache-revalidation-updates-disk-cache-expected.txt: Added.
  • http/tests/cache/disk-cache/memory-cache-revalidation-updates-disk-cache.html: Added.
2:48 AM Changeset in webkit [190941] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.10

Merge r190238 - [GTK] ASSERTION FAILED: !m_inUpdateBackingStoreState in DrawingAreaImpl::display() after DrawingAreaImpl::forceRepaint()
https://bugs.webkit.org/show_bug.cgi?id=148956

Reviewed by Žan Doberšek.

Source/WebKit2:

This is because those tests call notifyDone in the onresize event
handler. InjectedBundlePage::dump() always calls WKBundlePageForceRepaint()
before dumping. When the view is resized DrawingAreaImpl::updateBackingStoreState()
is called, so if the size has changed the FrameView::resize()
method is called and all children are resized, so the onresize
handlers happen at that point, before the
m_inUpdateBackingStoreState is set to false again. For WTR we
could probably just return early from froceReapaint() when
m_inUpdateBackingStoreState is true, because in that case we know
the layout is updated because of the resize and the actual display
is not really needed. But the UI process can also request a force
repaint, so we could wait until the backing store update is done
and then force the repaint. For WTR it will happen after the
dump, but it shouldn't be a problem.

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::forceRepaint):
(WebKit::DrawingAreaImpl::updateBackingStoreState):

  • WebProcess/WebPage/DrawingAreaImpl.h:

LayoutTests:

Unskip tests that should pass now.

  • platform/gtk/TestExpectations:
2:40 AM Changeset in webkit [190940] by Carlos Garcia Campos
  • 3 edits
    5 adds in releases/WebKitGTK/webkit-2.10

Merge r190160 - [GTK] playbutton in media controls is not changed when it is clicked.
https://bugs.webkit.org/show_bug.cgi?id=149113

Reviewed by Philippe Normand.

Source/WebCore:

When the play button in media controls is clicked, a 'paused' class is added or removed
for the element to update its appearance. Although Document::recalcStyle is triggered
by that class attribute change, the play button is not changed since there is
no difference in styles whether having the 'paused' class or not. Gtk port
does not define the -webkit-media-controls-play-button.paused. To fix this,
-webkit-media-controls-play-button.paused is newly defined with a dummy style,
"position: relative;", which should not change the play button appearance,
but be clearly different in style.

Test: media/media-controls-play-button-updates.html

  • css/mediaControlsGtk.css:

(video::-webkit-media-controls-play-button.paused):

LayoutTests:

  • media/media-controls-play-button-updates-expected.png: Added.
  • media/media-controls-play-button-updates-expected.txt: Added.
  • media/media-controls-play-button-updates.html: Added.
  • platform/gtk/media/media-controls-play-button-updates-expected.png: Added.
  • platform/gtk/media/media-controls-play-button-updates-expected.txt: Added.
2:39 AM Changeset in webkit [190939] by Carlos Garcia Campos
  • 6 edits
    2 adds in releases/WebKitGTK/webkit-2.10

Merge r190153 - Event fired on a detached node does not bubble up
https://bugs.webkit.org/show_bug.cgi?id=149488

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Rebaselined a test now that one more test case passes.

  • web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:

Source/WebCore:

The bug was caused by an explicit check inside EventPath to match an old Firefox behavior (see r19897).
Since Firefox's behavior has changed to match DOM4: https://dom.spec.whatwg.org/#concept-event-dispatch

Fixed the bug by removing the check. The new behavior matches DO4 and behaviors of Firefox and Chrome.

Test: fast/events/event-propagation-in-detached-tree.html

  • dom/EventDispatcher.cpp:

(WebCore::EventPath::EventPath):

LayoutTests:

Added a regression test. Also modified and rebaselined mouseout-dead-node.html added in r19897
since our new behavior matches that of the latest Firefox as well as Chrome.

  • fast/events/event-propagation-in-detached-tree-expected.txt: Added.
  • fast/events/event-propagation-in-detached-tree.html: Added.
  • fast/events/mouseout-dead-node-expected.txt:
  • fast/events/mouseout-dead-node.html:
2:35 AM Changeset in webkit [190938] by Carlos Garcia Campos
  • 31 edits in releases/WebKitGTK/webkit-2.10/Source

Merge r190124 - Make it more obvious when using an unaccelerated image buffer, and fix a few callers who do
https://bugs.webkit.org/show_bug.cgi?id=149428

Reviewed by Simon Fraser and Darin Adler.

  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::createCompatibleBuffer):

  • platform/graphics/ImageBuffer.h:

(WebCore::ImageBuffer::create):
Make the RenderingMode parameter to ImageBuffer::create non-optional.

  • platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContext::renderingMode):

  • platform/graphics/GraphicsTypes.h:

Add renderingMode() getter so that every caller doesn't need to do the conversion to RenderingMode.

  • css/CSSFilterImageValue.cpp:

(WebCore::CSSFilterImageValue::image):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::LRUImageBufferCache::imageBuffer):

  • rendering/shapes/Shape.cpp:

(WebCore::Shape::createRasterShape):

  • html/shadow/MediaControlElements.cpp:

(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::putByteArray):
These five callers create unconditionally unaccelerated ImageBuffers which
should probably instead respect the acceleration bit from the context
that the ImageBuffer will eventually be painted into. Bugs have been filed.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::createImageBuffer):

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::createCompositingBuffer):

  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::CrossfadeGeneratedImage::drawPattern):
Adjust the argument order and remove defaults which are passed explicitly.

  • page/FrameSnapshotting.cpp:

(WebCore::snapshotFrameRect):
Snapshots are (currently) meant to be taken without accelerated drawing.
Make this explicit.

  • platform/graphics/BitmapImage.cpp:

(WebCore::BitmapImage::drawPattern):
Make use of createCompatibleBuffer. This caller was previously creating
an unconditionally unaccelerated context!

  • platform/graphics/NamedImageGeneratedImage.cpp:

(WebCore::NamedImageGeneratedImage::drawPattern):
Remove a comment.

  • platform/graphics/ShadowBlur.cpp:

(WebCore::ScratchBuffer::getScratchBuffer):
ShadowBlur is only used with unaccelerated contexts, so it's OK to hardcode Unaccelerated here.

  • platform/graphics/filters/FilterEffect.cpp:

(WebCore::FilterEffect::asImageBuffer):
(WebCore::FilterEffect::createImageBufferResult):
Flip the order of the arguments.

(WebCore::FilterEffect::openCLImageToImageBuffer):
This caller was previously creating an unaccelerated buffer; instead, match the destination buffer.

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRenderer::allocateBackingStoreIfNeeded):
Adjust the argument order and remove defaults which are passed explicitly.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):
Get rid of the unneeded renderingMode local, and factor out retrieval of Frame.

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::applyClippingToContext):

  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::applyResource):
These two callers are unconditionally creating unaccelerated buffers,
and changing this to match the destination context seems to actually
break things. This needs further investigation.

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::createMaskAndSwapContextForTextGradient):
This caller was previously creating an unaccelerated buffer; instead, match the destination buffer.

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::buildPattern):
Make use of renderingMode().

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::createImageBuffer):
Adjust the argument order.

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::nativeImageForCurrentFrame):

  • WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::imageForCurrentSharingServicePickerItem):

  • Shared/CoordinatedGraphics/threadedcompositor/ThreadSafeCoordinatedSurface.cpp:

(WebKit::ThreadSafeCoordinatedSurface::create):

2:19 AM Changeset in webkit [190937] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2

Merge r190121 - [WK2][NetworkCache] New entry bodies remain in dirty memory after being written to disk.
<https://webkit.org/b/149463>

Reviewed by Antti Koivisto.

Call msync(MS_ASYNC) on cache entry bodies after writing their data to a
memory-mapped file. This turns the previously dirty memory into clean memory,
reducing our effective footprint.

I previously believed this would happen automatically when the kernel finds
itself under memory pressure, around the same time as it starts dropping
volatile pages. Turns out that's not the case. Even under considerable pressure,
we never flush this memory to file. So let's take care of it ourselves.

If this ends up generating more IO activity than we're comfortable with on some
scenario, we can look at throttling.

  • NetworkProcess/cache/NetworkCacheData.cpp:

(WebKit::NetworkCache::Data::mapToFile):

2:18 AM Changeset in webkit [190936] by Carlos Garcia Campos
  • 6 edits in releases/WebKitGTK/webkit-2.10

Merge r190114 - Source/WebCore:
CurrentTime on mediaController is set as 0 when playback is completed.
https://bugs.webkit.org/show_bug.cgi?id=149154

Patch by sangdeug.kim <sangdeug.kim@samsung.com> on 2015-09-22
Reviewed by Eric Carlson.

Test : media/media-controller-time-clamp.html

  • html/MediaController.cpp:

(MediaController::setCurrentTime):
(MediaController::updatePlaybackState):

  • html/MediaController.h:

LayoutTests:
Add test for checking currentTime of mediacontroller when playback is completed.
https://bugs.webkit.org/show_bug.cgi?id=149154

Patch by sangdeug.kim <sangdeug.kim@samsung.com> on 2015-09-22
Reviewed by Eric Carlson.

  • media/media-controller-time-clamp-expected.txt:
  • media/media-controller-time-clamp.html:
2:14 AM Changeset in webkit [190935] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190079 - svg/custom/hidpi-masking-clipping.svg fails with accelerated drawing on
https://bugs.webkit.org/show_bug.cgi?id=149413
<rdar://problem/22787058>

Reviewed by Dean Jackson.

No new tests, this is covered by existing tests.

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::buildPattern):
(WebCore::RenderSVGResourcePattern::applyResource):
(WebCore::RenderSVGResourcePattern::createTileImage):

  • rendering/svg/RenderSVGResourcePattern.h:

Make pattern images respect the accelerated bit of the parent GraphicsContext.

2:03 AM Changeset in webkit [190934] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.10

Merge r190054 - [GTK] media controls does not show up when playing video finishes.
https://bugs.webkit.org/show_bug.cgi?id=149112

Reviewed by Philippe Normand.

Source/WebCore:

GTK port does not show controls after playing video. This behavior is different
from what Mac port does. They do show controls when playing video finishes.
At least, we should update the timeline before showing it up not to show incorrect numbers
when reappearing.

Test: media/media-controls-timeline-updates-after-playing.html

  • Modules/mediacontrols/mediaControlsBase.js:

(Controller.prototype.setPlaying):
(Controller.prototype.showControls):

LayoutTests:

  • media/media-controls-timeline-updates-after-playing-expected.txt: Added.
  • media/media-controls-timeline-updates-after-playing.html: Added.
2:02 AM Changeset in webkit [190933] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.10

Merge r190053 - [GTK] timeline is not updated after few seconds when mouse hovers on controls
https://bugs.webkit.org/show_bug.cgi?id=149111

Reviewed by Philippe Normand.

Source/WebCore:

Timeline is not updated if controlsAreHidden is true. The problem here is that
the function does not mean actually 'hidden' since it only checkes 'show' and 'hidden'
class existences. The panel's visibility are not only controlled by the two classes,
but also by video::-webkit-media-controls-panel:hover. The panel could be visible
by setting the pseudo hover class. So we need to check if panel is hovered as well in controlsAreHidden().

Test: media/media-controls-timeline-updates-when-hovered.html

  • Modules/mediacontrols/mediaControlsBase.js:

(Controller.prototype.controlsAreHidden):

LayoutTests:

  • media/media-controls-timeline-updates-when-hovered-expected.txt: Added.
  • media/media-controls-timeline-updates-when-hovered.html: Added.
2:01 AM Changeset in webkit [190932] by Carlos Garcia Campos
  • 2 edits in releases/WebKitGTK/webkit-2.10/Tools

Merge r190046 - [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
https://bugs.webkit.org/show_bug.cgi?id=149252

Reviewed by Darin Adler.

In case of glib tests the test runner notifies about tests
crashing, but for google tests we don't get any feedback, which
means that in case of a test crashing we get a list of PASS
messages and at the summary we are notified that the test suite
has failed, but it's impossible to know which test cases have failed.

  • Scripts/run-gtk-tests:

(TestRunner._run_google_test): Add a CRASH message if test
case crashed.

1:53 AM Changeset in webkit [190931] by Carlos Garcia Campos
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.10

Merge r190013 - Null dereference loading Blink layout test svg/filters/feImage-failed-load-crash.html
https://bugs.webkit.org/show_bug.cgi?id=149316
<rdar://problem/22749532>

Reviewed by Tim Horton.

Source/WebCore:

If an feImage triggered loading a resource, and then was removed from the document,
we'd still try to notify its parent when the resource arrived (or failed).

Merge Blink commit:
https://chromium.googlesource.com/chromium/blink/+/9cbcfd7866bbaff0c4b3c4c8508b7c97b46d6e6a

Test: svg/filters/feImage-failed-load-crash.html

  • svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::notifyFinished): Add a null check to the parent element
before sending the notification.

LayoutTests:

Merge Blink commit:
https://chromium.googlesource.com/chromium/blink/+/9cbcfd7866bbaff0c4b3c4c8508b7c97b46d6e6a

  • svg/filters/feImage-failed-load-crash-expected.txt: Added.
  • svg/filters/feImage-failed-load-crash.html: Added.
1:53 AM Changeset in webkit [190930] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

Avoid useless copying of Key::HashType in loops in NetworkCache::Storage::synchronize()
https://bugs.webkit.org/show_bug.cgi?id=150061

Reviewed by Carlos Garcia Campos.

Avoid useless copying of Key::HashType in loops in NetworkCache::Storage::synchronize().
Key::HashType is currently a SHA1::Digest, which is a std::array<uint8_t, 20>.

  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::Storage::synchronize):

1:52 AM Changeset in webkit [190929] by Carlos Garcia Campos
  • 3 edits
    6 adds in releases/WebKitGTK/webkit-2.10

Merge r190012 - Null dereference loading Blink layout test svg/custom/use-href-attr-removal-crash.html
https://bugs.webkit.org/show_bug.cgi?id=149315
<rdar://problem/22749358>

Reviewed by Tim Horton.

Source/WebCore:

We were not checking if the corresponding element referenced from
the SVG <use> actually existed before trying to set attributes on it.
The original Blink change is a little more detailed:
https://chromium.googlesource.com/chromium/blink/+/e2f1087f32bb088160ab7d59a715a1403ef267c7
However, we've significantly diverged at this point.

Tests: svg/custom/use-href-attr-removal-crash.html

svg/custom/use-href-attr-removal-crash2.svg
svg/custom/use-href-change-local-to-invalid-remote.html

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::transferSizeAttributesToTargetClone):

LayoutTests:

These tests, copied from Blink, should not crash.
The originals come from:
https://chromium.googlesource.com/chromium/blink/+/e2f1087f32bb088160ab7d59a715a1403ef267c7

  • svg/custom/use-href-attr-removal-crash.html: Added.
  • svg/custom/use-href-attr-removal-crash-expected.txt: Added.
  • svg/custom/use-href-attr-removal-crash2.svg: Added.
  • svg/custom/use-href-attr-removal-crash2-expected.txt: Added.
  • svg/custom/use-href-change-local-to-invalid-remote.html: Added.
  • svg/custom/use-href-change-local-to-invalid-remote-expected.txt: Added.
1:49 AM Changeset in webkit [190928] by Carlos Garcia Campos
  • 3 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r190097 - Fix release builds with security assertion after r190007.

  • dom/DocumentOrderedMap.cpp:
  • dom/DocumentOrderedMap.h:
Note: See TracTimeline for information about the timeline view.