Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Nov 15, 2015:

11:42 PM Changeset in webkit [192465] by sbarati@apple.com

• 2 edits in trunk/Source/JavaScriptCore

64-bit in the DFG: non tail Calls unnecessarily store the argument count twice on the callee frame and tails calls unnecessarily store it once
​https://bugs.webkit.org/show_bug.cgi?id=151297

Reviewed by Geoffrey Garen.

Non tail calls only need to store the count once. Tail calls
never need to store the count on the callee frame because they
will be reusing the caller's frame.

• dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

2:00 PM Changeset in webkit [192464] by adam.bergkvist@ericsson.com

• 34 edits
  7 copies
  5 moves
  4 adds
  7 deletes in trunk

WebRTC: Update RTCPeerConnection API and introduce PeerConnectionBackend
​https://bugs.webkit.org/show_bug.cgi?id=150166

Reviewed by Eric Carlson and Youenn Fablet

Source/JavaScriptCore:

Added generic isDictionary() function to GlobalObject.js that tests if a
value can be interpreted as a dictionary.

• builtins/GlobalObject.js:

(isDictionary):

• runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

Source/WebCore:

This change introduces PeerConnectionBackend which is a WebCore interface
that allows RTCPeerConnection to have platform abstractions at different
levels. For example, the MediaEndpoint interface [1] is a lower level
WebRTC backend abstraction where a big part of the WebRTC specification
is implemented in WebCore to be reusable. RTCPeerConnectionHandler (in
the repo today) is on the other hand a higher level WebRTC backend
abstraction where the calls are mostly forwarded directly to the
backend. The PeerConnectionBackend interface facilitates both approaches.

RTCPeerConnection

| (has)
|

PeerConnectionBackend

| |
| | (realizes)
| MediaEndpointPeerConnection
| | (has)
| |
| MediaEndpoint (platform interface)
|
| (realizes)

RTCPeerHandlerPeerConnection

| (has)
|

RCPeerConnectionHandler (existing platform interface)

Notable changes:

# Overloaded methods on RTCPeerConnection (Promise + legacy callback
signatures) are implemented with JSBuiltins.

# "Queued operations" ([1] Section 4.3.1) is implemented in JS bindings
with Promises.

# New RTCPeerConnection features

• add/removeTrack()
• pending/currentLocal/RemoteDescription attributes
• RTCRtpSender/Receiver

# Information carrying objects like RTCSessionDescription and
RTCCandidate don't encapsulate a "mirrored" platform object anymore.

# Remove RTCPeerConnection specific callback implementations (not used
with JS bindings)

[1] ​http://webkit.org/b/150165
[2] ​https://w3c.github.io/webrtc-pc/archives/20151006/webrtc.html

Tests: Mock should be added to test future WebRTC backend abstractions.

• CMakeLists.txt:
• DerivedSources.make:
• Modules/mediastream/PeerConnectionBackend.cpp: Added.

(WebCore::createPeerConnectionBackend):

• Modules/mediastream/PeerConnectionBackend.h: Added.

(WebCore::PeerConnectionBackendClient::~PeerConnectionBackendClient):
(WebCore::PeerConnectionBackend::~PeerConnectionBackend):

• Modules/mediastream/PeerConnectionStates.h: Added.
• Modules/mediastream/RTCConfiguration.cpp: Added.

(WebCore::validateIceServerURL):
(WebCore::parseIceServer):
(WebCore::RTCConfiguration::create):
(WebCore::RTCConfiguration::RTCConfiguration):
(WebCore::RTCConfiguration::initialize):

• Modules/mediastream/RTCConfiguration.h:

(WebCore::RTCConfiguration::iceTransportPolicy):
(WebCore::RTCConfiguration::bundlePolicy):
(WebCore::RTCConfiguration::iceServers):
(WebCore::RTCConfiguration::create): Deleted.
(WebCore::RTCConfiguration::appendServer): Deleted.
(WebCore::RTCConfiguration::numberOfServers): Deleted.
(WebCore::RTCConfiguration::server): Deleted.
(WebCore::RTCConfiguration::iceTransports): Deleted.
(WebCore::RTCConfiguration::setIceTransports): Deleted.
(WebCore::RTCConfiguration::requestIdentity): Deleted.
(WebCore::RTCConfiguration::setRequestIdentity): Deleted.
(WebCore::RTCConfiguration::privateConfiguration): Deleted.
(WebCore::RTCConfiguration::RTCConfiguration): Deleted.

• Modules/mediastream/RTCConfiguration.idl:
• Modules/mediastream/RTCIceCandidate.cpp:

(WebCore::RTCIceCandidate::create):
(WebCore::RTCIceCandidate::RTCIceCandidate):
(WebCore::RTCIceCandidate::~RTCIceCandidate): Deleted.
(WebCore::RTCIceCandidate::candidate): Deleted.
(WebCore::RTCIceCandidate::sdpMid): Deleted.
(WebCore::RTCIceCandidate::sdpMLineIndex): Deleted.
(WebCore::RTCIceCandidate::descriptor): Deleted.

• Modules/mediastream/RTCIceCandidate.h:

(WebCore::RTCIceCandidate::~RTCIceCandidate):
(WebCore::RTCIceCandidate::candidate):
(WebCore::RTCIceCandidate::setCandidate):
(WebCore::RTCIceCandidate::sdpMid):
(WebCore::RTCIceCandidate::setSdpMid):
(WebCore::RTCIceCandidate::sdpMLineIndex):
(WebCore::RTCIceCandidate::setSdpMLineIndex):

• Modules/mediastream/RTCIceCandidate.idl:
• Modules/mediastream/RTCIceCandidateEvent.cpp:

(WebCore::RTCIceCandidateEvent::create):
(WebCore::RTCIceCandidateEvent::RTCIceCandidateEvent):

• Modules/mediastream/RTCIceCandidateEvent.h:
• Modules/mediastream/RTCIceServer.h:

(WebCore::RTCIceServer::urls):
(WebCore::RTCIceServer::credential):
(WebCore::RTCIceServer::username):
(WebCore::RTCIceServer::RTCIceServer):
(WebCore::RTCIceServer::create): Deleted.
(WebCore::RTCIceServer::privateServer): Deleted.

• Modules/mediastream/RTCOfferAnswerOptions.cpp:

(WebCore::RTCOfferAnswerOptions::RTCOfferAnswerOptions):
(WebCore::RTCOfferAnswerOptions::initialize):
(WebCore::RTCOfferOptions::RTCOfferOptions):
(WebCore::RTCOfferOptions::initialize):
(WebCore::RTCAnswerOptions::create):
(WebCore::RTCAnswerOptions::initialize):
(WebCore::RTCOfferAnswerOptions::create): Deleted.

• Modules/mediastream/RTCOfferAnswerOptions.h:

(WebCore::RTCOfferAnswerOptions::voiceActivityDetection):
(WebCore::RTCOfferOptions::offerToReceiveVideo):
(WebCore::RTCOfferOptions::offerToReceiveAudio):
(WebCore::RTCOfferOptions::iceRestart):
(WebCore::RTCAnswerOptions::RTCAnswerOptions):
(WebCore::RTCOfferAnswerOptions::requestIdentity): Deleted.
(WebCore::RTCOfferAnswerOptions::privateOfferAnswerOptions): Deleted.
(WebCore::RTCOfferAnswerOptions::RTCOfferAnswerOptions): Deleted.
(WebCore::RTCOfferOptions::voiceActivityDetection): Deleted.
(WebCore::RTCOfferOptions::privateOfferOptions): Deleted.
(WebCore::RTCOfferOptions::~RTCOfferOptions): Deleted.
(WebCore::RTCOfferOptions::RTCOfferOptions): Deleted.

• Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::create):
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::getSenders):
(WebCore::RTCPeerConnection::getReceivers):
(WebCore::RTCPeerConnection::addTrack):
(WebCore::RTCPeerConnection::removeTrack):
(WebCore::RTCPeerConnection::queuedCreateOffer):
(WebCore::RTCPeerConnection::queuedCreateAnswer):
(WebCore::RTCPeerConnection::queuedSetLocalDescription):
(WebCore::RTCPeerConnection::localDescription):
(WebCore::RTCPeerConnection::currentLocalDescription):
(WebCore::RTCPeerConnection::pendingLocalDescription):
(WebCore::RTCPeerConnection::queuedSetRemoteDescription):
(WebCore::RTCPeerConnection::remoteDescription):
(WebCore::RTCPeerConnection::currentRemoteDescription):
(WebCore::RTCPeerConnection::pendingRemoteDescription):
(WebCore::RTCPeerConnection::queuedAddIceCandidate):
(WebCore::RTCPeerConnection::signalingState):
(WebCore::RTCPeerConnection::iceGatheringState):
(WebCore::RTCPeerConnection::iceConnectionState):
(WebCore::RTCPeerConnection::setConfiguration):
(WebCore::RTCPeerConnection::privateGetStats):
(WebCore::RTCPeerConnection::createDataChannel):
(WebCore::RTCPeerConnection::close):
(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::setSignalingState):
(WebCore::RTCPeerConnection::updateIceGatheringState):
(WebCore::RTCPeerConnection::updateIceConnectionState):
(WebCore::RTCPeerConnection::scheduleNegotiationNeededEvent):
(WebCore::RTCPeerConnection::fireEvent):
(WebCore::validateIceServerURL): Deleted.
(WebCore::processIceServer): Deleted.
(WebCore::RTCPeerConnection::parseConfiguration): Deleted.
(WebCore::RTCPeerConnection::~RTCPeerConnection): Deleted.
(WebCore::RTCPeerConnection::createOffer): Deleted.
(WebCore::RTCPeerConnection::createAnswer): Deleted.
(WebCore::RTCPeerConnection::checkStateForLocalDescription): Deleted.
(WebCore::RTCPeerConnection::checkStateForRemoteDescription): Deleted.
(WebCore::RTCPeerConnection::setLocalDescription): Deleted.
(WebCore::RTCPeerConnection::setRemoteDescription): Deleted.
(WebCore::RTCPeerConnection::updateIce): Deleted.
(WebCore::RTCPeerConnection::addIceCandidate): Deleted.
(WebCore::RTCPeerConnection::addStream): Deleted.
(WebCore::RTCPeerConnection::removeStream): Deleted.
(WebCore::RTCPeerConnection::getLocalStreams): Deleted.
(WebCore::RTCPeerConnection::getRemoteStreams): Deleted.
(WebCore::RTCPeerConnection::getStreamById): Deleted.
(WebCore::RTCPeerConnection::getStats): Deleted.
(WebCore::RTCPeerConnection::hasLocalStreamWithTrackId): Deleted.
(WebCore::RTCPeerConnection::createDTMFSender): Deleted.
(WebCore::RTCPeerConnection::negotiationNeeded): Deleted.
(WebCore::RTCPeerConnection::didGenerateIceCandidate): Deleted.
(WebCore::RTCPeerConnection::didChangeSignalingState): Deleted.
(WebCore::RTCPeerConnection::didChangeIceGatheringState): Deleted.
(WebCore::RTCPeerConnection::didChangeIceConnectionState): Deleted.
(WebCore::RTCPeerConnection::didAddRemoteStream): Deleted.
(WebCore::RTCPeerConnection::didRemoveRemoteStream): Deleted.
(WebCore::RTCPeerConnection::didAddRemoteDataChannel): Deleted.
(WebCore::RTCPeerConnection::didAddOrRemoveTrack): Deleted.
(WebCore::RTCPeerConnection::changeSignalingState): Deleted.
(WebCore::RTCPeerConnection::changeIceGatheringState): Deleted.
(WebCore::RTCPeerConnection::changeIceConnectionState): Deleted.
(WebCore::RTCPeerConnection::scheduleDispatchEvent): Deleted.
(WebCore::RTCPeerConnection::scheduledEventTimerFired): Deleted.

• Modules/mediastream/RTCPeerConnection.h:
• Modules/mediastream/RTCPeerConnection.idl:
• Modules/mediastream/RTCPeerConnection.js: Added.

(createOffer):
(createAnswer):
(setLocalDescription):
(setRemoteDescription):
(addIceCandidate):
(getStats):

• Modules/mediastream/RTCPeerConnectionErrorCallback.h:

(WebCore::RTCPeerConnectionErrorCallback::~RTCPeerConnectionErrorCallback): Deleted.

• Modules/mediastream/RTCPeerConnectionInternals.js: Added.

(runNext):
(enqueueOperation):
(setLocalOrRemoteDescription):
(extractCallbackArg):

• Modules/mediastream/RTCRtpReceiver.cpp: Added.

(WebCore::RTCRtpReceiver::RTCRtpReceiver):

• Modules/mediastream/RTCRtpReceiver.h: Added.

(WebCore::RTCRtpReceiver::create):

• Modules/mediastream/RTCRtpReceiver.idl: Added.
• Modules/mediastream/RTCRtpSender.cpp: Added.

(WebCore::RTCRtpSender::RTCRtpSender):

• Modules/mediastream/RTCRtpSender.h: Added.

(WebCore::RTCRtpSender::create):
(WebCore::RTCRtpSender::mediaStreamId):

• Modules/mediastream/RTCRtpSender.idl: Added.
• Modules/mediastream/RTCRtpSenderReceiverBase.h: Added.

(WebCore::RTCRtpSenderReceiverBase::~RTCRtpSenderReceiverBase):
(WebCore::RTCRtpSenderReceiverBase::track):
(WebCore::RTCRtpSenderReceiverBase::RTCRtpSenderReceiverBase):

• Modules/mediastream/RTCSessionDescription.cpp:

(WebCore::RTCSessionDescription::create):
(WebCore::RTCSessionDescription::RTCSessionDescription):
(WebCore::RTCSessionDescription::setType):
(WebCore::RTCSessionDescription::~RTCSessionDescription): Deleted.
(WebCore::RTCSessionDescription::type): Deleted.
(WebCore::RTCSessionDescription::sdp): Deleted.
(WebCore::RTCSessionDescription::setSdp): Deleted.
(WebCore::RTCSessionDescription::descriptor): Deleted.

• Modules/mediastream/RTCSessionDescription.h:

(WebCore::RTCSessionDescription::~RTCSessionDescription):
(WebCore::RTCSessionDescription::type):
(WebCore::RTCSessionDescription::sdp):
(WebCore::RTCSessionDescription::setSdp):

• Modules/mediastream/RTCSessionDescriptionCallback.h:

(WebCore::RTCSessionDescriptionCallback::~RTCSessionDescriptionCallback): Deleted.

• Modules/mediastream/RTCSessionDescriptionRequestImpl.cpp: Removed.

(WebCore::RTCSessionDescriptionRequestImpl::create): Deleted.
(WebCore::RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl): Deleted.
(WebCore::RTCSessionDescriptionRequestImpl::~RTCSessionDescriptionRequestImpl): Deleted.
(WebCore::RTCSessionDescriptionRequestImpl::requestSucceeded): Deleted.
(WebCore::RTCSessionDescriptionRequestImpl::requestFailed): Deleted.
(WebCore::RTCSessionDescriptionRequestImpl::stop): Deleted.
(WebCore::RTCSessionDescriptionRequestImpl::activeDOMObjectName): Deleted.
(WebCore::RTCSessionDescriptionRequestImpl::canSuspendForPageCache): Deleted.
(WebCore::RTCSessionDescriptionRequestImpl::clear): Deleted.

• Modules/mediastream/RTCSessionDescriptionRequestImpl.h: Removed.
• Modules/mediastream/RTCStatsCallback.h: Removed.

(WebCore::RTCStatsCallback::~RTCStatsCallback): Deleted.

• Modules/mediastream/RTCStatsCallback.idl: Removed.
• Modules/mediastream/RTCStatsRequestImpl.cpp: Removed.

(WebCore::RTCStatsRequestImpl::create): Deleted.
(WebCore::RTCStatsRequestImpl::RTCStatsRequestImpl): Deleted.
(WebCore::RTCStatsRequestImpl::~RTCStatsRequestImpl): Deleted.
(WebCore::RTCStatsRequestImpl::createResponse): Deleted.
(WebCore::RTCStatsRequestImpl::hasSelector): Deleted.
(WebCore::RTCStatsRequestImpl::track): Deleted.
(WebCore::RTCStatsRequestImpl::requestSucceeded): Deleted.
(WebCore::RTCStatsRequestImpl::requestFailed): Deleted.
(WebCore::RTCStatsRequestImpl::stop): Deleted.
(WebCore::RTCStatsRequestImpl::activeDOMObjectName): Deleted.
(WebCore::RTCStatsRequestImpl::canSuspendForPageCache): Deleted.
(WebCore::RTCStatsRequestImpl::clear): Deleted.

• Modules/mediastream/RTCStatsRequestImpl.h: Removed.
• Modules/mediastream/RTCTrackEvent.cpp: Added.

(WebCore::RTCTrackEventInit::RTCTrackEventInit):
(WebCore::RTCTrackEvent::create):
(WebCore::RTCTrackEvent::RTCTrackEvent):

• Modules/mediastream/RTCTrackEvent.h: Added.

(WebCore::RTCTrackEvent::receiver):
(WebCore::RTCTrackEvent::track):
(WebCore::RTCTrackEvent::eventInterface):

• Modules/mediastream/RTCTrackEvent.idl: Added.
• Modules/mediastream/RTCVoidRequestImpl.cpp: Removed.

(WebCore::RTCVoidRequestImpl::create): Deleted.
(WebCore::RTCVoidRequestImpl::RTCVoidRequestImpl): Deleted.
(WebCore::RTCVoidRequestImpl::~RTCVoidRequestImpl): Deleted.
(WebCore::RTCVoidRequestImpl::requestSucceeded): Deleted.
(WebCore::RTCVoidRequestImpl::requestFailed): Deleted.
(WebCore::RTCVoidRequestImpl::stop): Deleted.
(WebCore::RTCVoidRequestImpl::activeDOMObjectName): Deleted.
(WebCore::RTCVoidRequestImpl::canSuspendForPageCache): Deleted.
(WebCore::RTCVoidRequestImpl::clear): Deleted.

• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

• bindings/js/JSDictionary.h:
• bindings/js/WebCoreBuiltinNames.h:
• bindings/js/WebCoreJSBuiltinInternals.h:

(WebCore::JSBuiltinInternalFunctions::JSBuiltinInternalFunctions):
(WebCore::JSBuiltinInternalFunctions::rTCPeerConnectionInternals):
(WebCore::JSBuiltinInternalFunctions::visit):
(WebCore::JSBuiltinInternalFunctions::init):

• bindings/js/WebCoreJSBuiltins.cpp:
• bindings/js/WebCoreJSBuiltins.h:

(WebCore::JSBuiltinFunctions::JSBuiltinFunctions):
(WebCore::JSBuiltinFunctions::rTCPeerConnectionBuiltins):
(WebCore::JSBuiltinFunctions::rTCPeerConnectionInternalsBuiltins):

• dom/EventNames.in:

LayoutTests:

Updated expected results (listed below) with the new types added by
this change (RTCRtpSender, RTCRtpReceiver and RTCTrackEvent).

• platform/efl/js/dom/global-constructors-attributes-expected.txt:
• platform/gtk/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:

10:52 AM Changeset in webkit [192463] by commit-queue@webkit.org

• 2 edits in trunk/Tools

Unreviewed, rolling out r192462.
​https://bugs.webkit.org/show_bug.cgi?id=151295

failing python tests (Requested by youenn on #webkit).

Reverted changeset:

"WPT server should use its own testharness.js file and
generate a warning when it does not match WebKit version"
​https://bugs.webkit.org/show_bug.cgi?id=150332
​http://trac.webkit.org/changeset/192462

10:17 AM Changeset in webkit [192462] by youenn.fablet@crf.canon.fr

• 2 edits in trunk/Tools

WPT server should use its own testharness.js file and generate a warning when it does not match WebKit version
​https://bugs.webkit.org/show_bug.cgi?id=150332

Reviewed by Darin Adler.

• Scripts/webkitpy/layout_tests/servers/web_platform_test_server.py:

(WebPlatformTestServer.init): Removed testharness.js as file to copy from WK to WPT.
(WebPlatformTestServer._copy_webkit_test_files): Added warning generation when WK testharness.js is not matching WPT version.

8:01 AM Changeset in webkit [192461] by youenn.fablet@crf.canon.fr

• 3 edits in trunk/LayoutTests

WebKit should not need to modify testharness.js
​https://bugs.webkit.org/show_bug.cgi?id=151262

Reviewed by Darin Adler.

• resources/testharness.js: Resetting global testharness.js timeout values to the default ones.
• resources/testharnessreport.js: Disabling global testharness.js timeout.

12:42 AM Changeset in webkit [192460] by ddkilzer@apple.com

• 2 edits in trunk/Source/WebCore

REGRESSION (r192404): Fix tvOS and watchOS builds

• platform/spi/cocoa/QuartzCoreSPI.h: Add more version checks to

fix all the builds.

Nov 14, 2015:

11:56 PM Changeset in webkit [192459] by Gyuyoung Kim

• 3 edits in trunk/Source/WebCore

[EFL][GTK] Remove use of String::format() in versionForUAString()
​https://bugs.webkit.org/show_bug.cgi?id=151250

Reviewed by Darin Adler.

As String::format() will be deprecated due to the security problem, reimplement
versionForUAString() using a macro.

• platform/efl/UserAgentEfl.cpp:

(WebCore::versionForUAString):

• platform/gtk/UserAgentGtk.cpp:

(WebCore::platformVersionForUAString):
(WebCore::versionForUAString):

9:23 PM Changeset in webkit [192458] by Antti Koivisto

• 2 edits in trunk/Source/WebCore

Regression(r188820): Downloads of data URLs is broken
​https://bugs.webkit.org/show_bug.cgi?id=150900
rdar://problem/23399223

Reviewed by Darin Adler.

No test, the current test infrastructure only allows testing policy decisions, not the actual download.

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::continueAfterContentPolicy):

Use normal download path for data URLs instead of trying to convert the main resource load.
Since we decode data URLs locally there is no associated resource load on WebKit side.

6:40 PM WindowsWithoutCygwin edited by mmaxfield@apple.com

(diff)

5:18 PM WindowsWithoutCygwin edited by mmaxfield@apple.com

(diff)

3:51 PM WindowsWithoutCygwin edited by mmaxfield@apple.com

(diff)

1:13 PM Changeset in webkit [192457] by msaboff@apple.com

• 3 edits
  3 adds in trunk

REGRESSION (r190370): CrashTracer: [USER] com.apple.WebKit.WebContent at com.apple.JavaScriptCore: JSC::JITCode::execute + 158
​https://bugs.webkit.org/show_bug.cgi?id=151279

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

We need to restore callee saves even when we take the slow path in a polymorphic call stub.
Move the restoration to the top of the stub so that it is done for all paths.

• jit/Repatch.cpp:

(JSC::linkPolymorphicCall):

LayoutTests:

New regression test.

• js/regress-151279-expected.txt: Added.
• js/regress-151279.html: Added.
• js/script-tests/regress-151279.js: Added.

1:09 PM BuildingQtOnLinux edited by BJ Burg

Add disclaimer about QT not existing any more in WebKit. (diff)

1:39 AM Changeset in webkit [192456] by n_wang@apple.com

• 11 edits
  2 adds in trunk

AX: add a new trait for elements in fieldset on iOS
​https://bugs.webkit.org/show_bug.cgi?id=151281

Reviewed by Chris Fleizach.

Source/WebCore:

Added a new trait for elements in the fieldset, so VoiceOver can speak the legend
information for those elements.

Test: accessibility/ios-simulator/fieldset-traits.html

• accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityCanFuzzyHitTest]):
(-[WebAccessibilityObjectWrapper _accessibilityTableAncestor]):
(-[WebAccessibilityObjectWrapper _accessibilityFieldsetAncestor]):
(-[WebAccessibilityObjectWrapper _accessibilityTraitsFromAncestors]):

Tools:

• DumpRenderTree/AccessibilityUIElement.cpp:

(assistiveTechnologySimulatedFocusCallback):
(fieldsetAncestorElementCallback):
(childAtIndexCallback):
(getElementTextLengthCallback):
(hasContainedByFieldsetTraitCallback):
(AccessibilityUIElement::getJSClass):

• DumpRenderTree/AccessibilityUIElement.h:
• DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::elementTextLength):
(AccessibilityUIElement::hasContainedByFieldsetTrait):
(AccessibilityUIElement::fieldsetAncestorElement):
(AccessibilityUIElement::url):

• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:

(WTR::AccessibilityUIElement::scrollPageDown):
(WTR::AccessibilityUIElement::scrollPageLeft):
(WTR::AccessibilityUIElement::scrollPageRight):
(WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
(WTR::AccessibilityUIElement::fieldsetAncestorElement):

• WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
• WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
• WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

(WTR::AccessibilityUIElement::identifier):
(WTR::AccessibilityUIElement::hasContainedByFieldsetTrait):
(WTR::AccessibilityUIElement::fieldsetAncestorElement):
(WTR::AccessibilityUIElement::rowCount):

LayoutTests:

• accessibility/ios-simulator/fieldset-traits-expected.txt: Added.
• accessibility/ios-simulator/fieldset-traits.html: Added.

Nov 13, 2015:

9:51 PM Changeset in webkit [192455] by commit-queue@webkit.org

• 3 edits in trunk/PerformanceTests

Eliminate a request for layout every time an item is added to the stage of the graphics benchmark
​https://bugs.webkit.org/show_bug.cgi?id=151289

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2015-11-13
Reviewed by Simon Fraser.

Cache the stage size when it is created instead of requesting every time
an object is added via clientWidth and clientHeight.

• Animometer/resources/extensions.js:

(Insets.elementPadding):

• Animometer/tests/resources/stage.js:

(Stage):
(Stage.prototype.get size):

8:03 PM Changeset in webkit [192454] by commit-queue@webkit.org

• 5 edits
  2 deletes in trunk/Source

Unreviewed, rolling out r192445, r192451, and r192452.
​https://bugs.webkit.org/show_bug.cgi?id=151291

Broke Mavericks build (and thus EWS) (Requested by ap on
#webkit).

Reverted changesets:

"Add identifier strings for a bunch of context menu items"
​https://bugs.webkit.org/show_bug.cgi?id=151272
​http://trac.webkit.org/changeset/192445

"Try to fix the 32-bit build"
​http://trac.webkit.org/changeset/192451

"Try to fix the 32-bit build"
​http://trac.webkit.org/changeset/192452

5:18 PM Changeset in webkit [192453] by commit-queue@webkit.org

• 4 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r192416 and r192443.
​https://bugs.webkit.org/show_bug.cgi?id=151285

Broke 32-bit in some mysterious way I need to understand
(Requested by kling on #webkit).

Reverted changesets:

"[JSC] JSPropertyNameEnumerator could be destructorless."
​https://bugs.webkit.org/show_bug.cgi?id=151242
​http://trac.webkit.org/changeset/192416

"Follow-up for 32-bit test failures after..."
​https://bugs.webkit.org/show_bug.cgi?id=151242
​http://trac.webkit.org/changeset/192443

4:56 PM Changeset in webkit [192452] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Try to fix the 32-bit build

• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::createShareMenuItem):

4:41 PM Changeset in webkit [192451] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit2

Try to fix the 32-bit build

• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::menuItemIdentifier):

4:40 PM Changeset in webkit [192450] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r192401.
​https://bugs.webkit.org/show_bug.cgi?id=151282

"caused crashes on animometer" (Requested by thorton on
#webkit).

Reverted changeset:

"Restore CodeBlock jettison code I accidentally removed"
​https://bugs.webkit.org/show_bug.cgi?id=151241
​http://trac.webkit.org/changeset/192401

4:30 PM Changeset in webkit [192449] by keith_miller@apple.com

• 2 edits in trunk/Tools

Unreviewed, change JavaScriptCore watchlist to exclude inspector things.

• Scripts/webkitpy/common/config/watchlist:

4:05 PM Changeset in webkit [192448] by Wenson Hsieh

• 2 edits in trunk/Source/WebKit2

WK2 iOS interaction tests in LayoutTests/fast/events/ios are flaky
​https://bugs.webkit.org/show_bug.cgi?id=151199
<rdar://problem/23518459>

Reviewed by Tim Horton.

While transforming touch positions from document to global coordinates, HIDEventGenerator
sometimes uses an old scale of the webview in computing the transformed position. This happens
in spite of how we force the UI script to run after the UI process receives a layer tree commit
because we invoke the callback before calling WebPageProxy::didCommitLayerTree, which is where
we actually use the layer transaction information to update the WKWebView.

To fix this, we run the drawing-ensured callbacks after committing the layer tree, so the
callbacks will have updated information about the web view's scale and dimensions.

• UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):

4:00 PM Changeset in webkit [192447] by timothy_horton@apple.com

• 7 edits in trunk

Support printing in WKWebView
​https://bugs.webkit.org/show_bug.cgi?id=151276
<rdar://problem/23525715>

Reviewed by Beth Dakin.

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _printOperationWithPrintInfo:]):
(-[WKWebView _printOperationWithPrintInfo:forFrame:]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:

Expose SPI similar to what we have on WKView.

• MiniBrowser/mac/MainMenu.xib:
• MiniBrowser/mac/WK1BrowserWindowController.m:

(-[WK1BrowserWindowController printWebView:]):

• MiniBrowser/mac/WK2BrowserWindowController.m:

(-[WK2BrowserWindowController printWebView:]):
Hook up printing to Minibrowser!

3:47 PM Changeset in webkit [192446] by Joseph Pecoraro

• 2 edits in trunk/Source/WebKit2

Follow-up to r192437. Add availability macros.

Reviewed by Tim Horton.

• UIProcess/API/Cocoa/WKWebViewPrivate.h:

3:37 PM Changeset in webkit [192445] by andersca@apple.com

• 5 edits
  2 adds in trunk/Source

Add identifier strings for a bunch of context menu items
​https://bugs.webkit.org/show_bug.cgi?id=151272

Reviewed by Dan Bernstein.

Source/WebCore:

Have NSMenuItem conform to NSUserInterfaceItemIdentification.

• platform/spi/mac/NSMenuSPI.h:

Source/WebKit2:

• UIProcess/API/Cocoa/WKMenuItemIdentifiers.mm: Added.
• UIProcess/API/Cocoa/WKMenuItemIdentifiersPrivate.h: Added.
• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::menuItemIdentifier):
(WebKit::WebContextMenuProxyMac::createShareMenuItem):
(WebKit::WebContextMenuProxyMac::createContextMenuItem):

• WebKit2.xcodeproj/project.pbxproj:

3:11 PM Changeset in webkit [192444] by Alan Bujtas

• 12 edits in trunk

Always render at least a device pixel line when border/outline width > 0.
​https://bugs.webkit.org/show_bug.cgi?id=151269

This matches Firefox behaviour.

Reviewed by Simon Fraser.

Source/WebCore:

Existing test is modified to reflect the new behaviour.

• css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertLineWidth):

• rendering/BorderEdge.cpp:

(WebCore::BorderEdge::BorderEdge): Deleted.

• rendering/BorderEdge.h:

LayoutTests:

• fast/borders/hidpi-border-width-flooring-expected.html:
• fast/borders/hidpi-border-width-flooring.html:

2:16 PM Changeset in webkit [192443] by akling@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Follow-up for 32-bit test failures after...
[JSC] JSPropertyNameEnumerator could be destructorless.
<​https://webkit.org/b/151242>

Reviewed by Mark Lam

Apparently copied space allocations need to be in multiples of 8 bytes.
Have JSPropertyNameEnumerator do what other copied space clients already do
and round the allocation size up to a multiple of 8.

Added a little helper function to compute the allocation size so this doesn't
have to be repeated everywhere.

• runtime/JSPropertyNameEnumerator.cpp:

(JSC::JSPropertyNameEnumerator::finishCreation):
(JSC::JSPropertyNameEnumerator::visitChildren):
(JSC::JSPropertyNameEnumerator::copyBackingStore):

• runtime/JSPropertyNameEnumerator.h:

1:51 PM Changeset in webkit [192442] by bshafiei@apple.com

• 5 edits in branches/safari-601.1.46.60-branch/Source

Versioning.

1:49 PM Changeset in webkit [192441] by peavo@outlook.com

• 2 edits in trunk/Source/WebCore

[WinCairo][MediaFoundation] Video rendered at wrong position.
​https://bugs.webkit.org/show_bug.cgi?id=151271

Reviewed by Alex Christensen.

The source rectangle used when blitting a frame to the graphics context
should have offset (0, 0).

• platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::MediaPlayerPrivateMediaFoundation::Direct3DPresenter::paintCurrentFrame):

1:47 PM Changeset in webkit [192440] by bshafiei@apple.com

• 1 copy in branches/safari-601.1.46.60-branch

New Branch.

1:36 PM Changeset in webkit [192439] by sbarati@apple.com

• 10 edits
  1 add in trunk/Source/JavaScriptCore

sub IC does not properly handle exception handling now that try/catch is compiled in the FTL
​https://bugs.webkit.org/show_bug.cgi?id=151080

Reviewed by Geoffrey Garen.

This patch implements proper exception handling for ArithSubs with binaryUseKind as
UntypedUse inside try/catch. We implement this in a very similar way as we implement
exception handling from GetById/PutById/LazySlowPaths callOperation calls. We do the needed
spilling if the result is the same register as the left/right register because in the event
of an exception, we don't want to do value recovery on the garbage result, we
want to do it on the original lhs/rhs of the operation.

This patch also does some refactoring. No longer does OSRExitDescriptor
have a long list of booleans that correspond to different OSR exit types.
It now just has an enum property called ExceptionType that tells us
what type of exception handler the OSR exit is. Then, we can just ask
interesting questions about the OSR exit and get answers based on its
ExceptionType property.

• ftl/FTLCompile.cpp:

(JSC::FTL::mmAllocateDataSection):

• ftl/FTLExceptionHandlerManager.cpp:

(JSC::FTL::ExceptionHandlerManager::addNewExit):
(JSC::FTL::ExceptionHandlerManager::callOperationExceptionTarget):
(JSC::FTL::ExceptionHandlerManager::lazySlowPathExceptionTarget):
(JSC::FTL::ExceptionHandlerManager::getByIdOSRExit):
(JSC::FTL::ExceptionHandlerManager::subOSRExit):
(JSC::FTL::ExceptionHandlerManager::getCallOSRExitCommon):
(JSC::FTL::ExceptionHandlerManager::getOrPutByIdCallOperationExceptionTarget): Deleted.

• ftl/FTLExceptionHandlerManager.h:
• ftl/FTLExitThunkGenerator.cpp:

(JSC::FTL::ExitThunkGenerator::emitThunk):

• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::lower):
(JSC::FTL::DFG::LowerDFGToLLVM::compileArithAddOrSub):
(JSC::FTL::DFG::LowerDFGToLLVM::compilePutById):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToLLVM::compileCallOrConstructVarargs):
(JSC::FTL::DFG::LowerDFGToLLVM::compileInvalidationPoint):
(JSC::FTL::DFG::LowerDFGToLLVM::getById):
(JSC::FTL::DFG::LowerDFGToLLVM::lazySlowPath):
(JSC::FTL::DFG::LowerDFGToLLVM::callCheck):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExitArgumentsForPatchpointIfWillCatchException):
(JSC::FTL::DFG::LowerDFGToLLVM::emitBranchToOSRExitIfWillCatchException):
(JSC::FTL::DFG::LowerDFGToLLVM::lowBlock):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExitDescriptor):
(JSC::FTL::DFG::LowerDFGToLLVM::appendOSRExit):
(JSC::FTL::DFG::LowerDFGToLLVM::buildExitArguments):

• ftl/FTLOSRExit.cpp:

(JSC::FTL::OSRExitDescriptor::OSRExitDescriptor):
(JSC::FTL::OSRExitDescriptor::willArriveAtExitFromIndirectExceptionCheck):
(JSC::FTL::OSRExitDescriptor::mightArriveAtOSRExitFromGenericUnwind):
(JSC::FTL::OSRExitDescriptor::mightArriveAtOSRExitFromCallOperation):
(JSC::FTL::OSRExitDescriptor::needsRegisterRecoveryOnGenericUnwindOSRExitPath):
(JSC::FTL::OSRExitDescriptor::isExceptionHandler):
(JSC::FTL::OSRExitDescriptor::validateReferences):
(JSC::FTL::OSRExit::OSRExit):
(JSC::FTL::OSRExit::codeLocationForRepatch):
(JSC::FTL::OSRExit::gatherRegistersToSpillForCallIfException):
(JSC::FTL::OSRExit::spillRegistersToSpillSlot):
(JSC::FTL::OSRExit::recoverRegistersFromSpillSlot):

• ftl/FTLOSRExit.h:
• ftl/FTLOSRExitCompilationInfo.h:

(JSC::FTL::OSRExitCompilationInfo::OSRExitCompilationInfo):

• ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileFTLOSRExit):

• tests/stress/ftl-try-catch-arith-sub-exception.js: Added.

(assert):
(let.o.valueOf):
(baz):
(foo):
(bar):

1:29 PM Changeset in webkit [192438] by bshafiei@apple.com

• 1 copy in tags/Safari-601.1.46.60

New tag.

11:46 AM Changeset in webkit [192437] by Joseph Pecoraro

• 15 edits in trunk/Source

Web Inspector: Provide a way to override the WKWebView remote inspector name
​https://bugs.webkit.org/show_bug.cgi?id=151075

Reviewed by Tim Horton.

Source/WebCore:

• page/Page.cpp:

(WebCore::Page::remoteInspectionNameOverride):
(WebCore::Page::setRemoteInspectionNameOverride):

• page/Page.h:
• page/PageDebuggable.cpp:

(WebCore::PageDebuggable::name):
(WebCore::PageDebuggable::setNameOverride):

• page/PageDebuggable.h:

Source/WebKit2:

• Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

• Shared/WebPageCreationParameters.h:
• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _remoteInspectionNameOverride]):
(-[WKWebView _setRemoteInspectionNameOverride:]):

• UIProcess/API/Cocoa/WKWebViewPrivate.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setRemoteInspectionNameOverride):
(WebKit::WebPageProxy::creationParameters):

• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::remoteInspectionNameOverride):

• WebProcess/WebPage/WebPage.cpp:

(WebKit::m_shouldDispatchFakeMouseMoveEvents):
(WebKit::WebPage::setRemoteInspectionNameOverride):

• WebProcess/WebPage/WebPage.h:
• WebProcess/WebPage/WebPage.messages.in:

11:13 AM Changeset in webkit [192436] by commit-queue@webkit.org

• 10 edits
  3 adds in trunk/Source/JavaScriptCore

Allow any LeftHandSideExpression as a valid AssignmentElement
​https://bugs.webkit.org/show_bug.cgi?id=151026

Patch by Caitlin Potter <​caitpotter88@gmail.com> on 2015-11-13
Reviewed by Geoffrey Garen.

• bytecompiler/NodesCodegen.cpp:

(JSC::AssignmentElementNode::collectBoundIdentifiers):
(JSC::AssignmentElementNode::bindValue):
(JSC::AssignmentElementNode::toString):

• parser/ASTBuilder.h:

(JSC::ASTBuilder::isAssignmentLocation):
(JSC::ASTBuilder::createAssignmentElement):

• parser/NodeConstructors.h:

(JSC::AssignmentElementNode::AssignmentElementNode):

• parser/Nodes.h:

(JSC::AssignmentElementNode::assignmentTarget):
(JSC::AssignmentElementNode::divotStart):
(JSC::AssignmentElementNode::divotEnd):

• parser/Parser.cpp:

(JSC::Parser<LexerType>::createAssignmentElement):
(JSC::Parser<LexerType>::parseDestructuringPattern):

• parser/Parser.h:
• parser/SyntaxChecker.h:

(JSC::SyntaxChecker::operatorStackPop):

11:10 AM Changeset in webkit [192435] by clopez@igalia.com

• 2 edits in trunk/LayoutTests

[GTK] GTK gardening.

Unreviewed.

• platform/gtk/TestExpectations: Update the expectation for a renamed

test and mark as failing some of the tests from imported/blink.

10:52 AM Changeset in webkit [192434] by Yusuke Suzuki

• 2 edits in trunk/Source/JavaScriptCore

op_assert should declare that it uses the first register argument
​https://bugs.webkit.org/show_bug.cgi?id=151183

Reviewed by Geoffrey Garen.

op_assert(conditionRegister, lineNumber) should declare that it
*uses* (in terms of use-def) the first conditionRegister and
it does not define any variables.

• bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):

10:36 AM Changeset in webkit [192433] by jiewen_tan@apple.com

• 3 edits
  2 adds in trunk

Element::focus() should acquire the ownership of Frame.
​https://bugs.webkit.org/show_bug.cgi?id=150204
<rdar://problem/23136794>

Reviewed by Brent Fulgham.

Source/WebCore:

The FrameSelection::setSelection method sometimes releases the last reference to a frame.
When this happens, the Element::updateFocusAppearance would attempt to use dereferenced memory.
Instead, we should ensure that the Frame lifetime is guaranteed to extend through the duration
of the method call.

Test: editing/selection/focus-iframe-removal-crash.html

• dom/Element.cpp:

(WebCore::Element::updateFocusAppearance):

LayoutTests:

• editing/selection/focus-iframe-removal-crash-expected.txt: Added.
• editing/selection/focus-iframe-removal-crash.html: Added.

10:11 AM Changeset in webkit [192432] by timothy_horton@apple.com

• 15 edits
  2 adds in trunk

Hardware keyboard spacebar scrolls too far on iOS
​https://bugs.webkit.org/show_bug.cgi?id=151227
<rdar://problem/23500681>

Reviewed by Simon Fraser.

There were two bugs conspiring here to make spacebar scrolling very wrong on iOS:

1) Incoming key events were being handled twice

• fix this by only propagating the event to super if we don't end up handling the event ourselves

2) _scrollByOffset was not converting the offset delta out of content coordinates

• fix this by doing the relevant conversion and renaming the function to make it more clear exactly what it does

• UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _scrollByContentOffset:]):
(-[WKWebView _scrollByOffset:]): Deleted.

• UIProcess/API/Cocoa/WKWebViewInternal.h:

Rename to _scrollByContentOffset to make it clear that this is
in content coordinates, and do the conversion from content coordinates
(apply the scale) so that we scroll by the right amount.

• UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::doneWithKeyEvent):
Pass whether the event was handled through to WKContentView.

• UIProcess/ios/WKContentViewInteraction.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(-[WKWebEvent dealloc]):
Add WKWebEvent, which is a WebEvent and retains a reference to the UIEvent
from which it came.

(-[WKContentView _handleKeyUIEvent:]):
Only pass the event to super immediately if we don't try to handle it.
We'll re-send it to super asynchronously if we decide not to handle it.

(-[WKContentView handleKeyEvent:]):
If we're in the middle of resending an event we didn't handle the first
time, just ignore it.

Make a WKWebEvent and store the UIEvent on it.

(-[WKContentView _didHandleKeyEvent:eventWasHandled:]):
If the event wasn't handled, and is one of our special events with a
wrapped UIEvent, resend it to super. We'll ignore it as noted above.

(-[WKContentView _interpretKeyEvent:isCharEvent:]):
Factor out unobscured content rect retrieval.
Make use of Scrollbar::pageStep to match the Mac behavior of not
scrolling quite a whole page when scrolling with the spacebar.

• fast/events/ios/keyboard-scrolling-distance-expected.txt: Added.
• fast/events/ios/keyboard-scrolling-distance.html: Added.

Add a test that records how much we scroll when pressing the spacebar.
The test is at a fixed scale of 1.5 to expose the bug fixed by this patch.

• WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
• WebKitTestRunner/UIScriptContext/UIScriptContext.h:
• WebKitTestRunner/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::setDidEndScrollingCallback):
(WTR::UIScriptController::didEndScrollingCallback):
(WTR::UIScriptController::platformSetDidEndScrollingCallback):

• WebKitTestRunner/UIScriptContext/UIScriptController.h:
• WebKitTestRunner/cocoa/TestRunnerWKWebView.h:
• WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView dealloc]):
(-[TestRunnerWKWebView _didFinishScrolling]):

• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::platformSetDidEndScrollingCallback):
(WTR::UIScriptController::platformClearAllCallbacks):
Expose _didFinishScrolling on WKWebView to the UIScriptController.

10:08 AM Changeset in webkit [192431] by Brent Fulgham

• 2 edits in trunk/Tools

[Win] Unreviewed test fix.

• Scripts/webkitpy/port/win.py:

(WinPort.results_directory): Our 'results_directory' should be an absolute path (even when not
using Cygwin), but should be in DOS format for non-Cygwin clients.

9:56 AM Changeset in webkit [192430] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Removing a deleted test from mac-wk2 test expectations.
​https://bugs.webkit.org/show_bug.cgi?id=151103

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

9:03 AM Changeset in webkit [192429] by matthew_hanson@apple.com

• 8 edits in branches/safari-601.1.46-branch

Merge r192269. rdar://problem/23189742

9:03 AM Changeset in webkit [192428] by matthew_hanson@apple.com

• 3 edits
  2 adds in branches/safari-601.1.46-branch

Merge r192120. rdar://problem/23189774

9:03 AM Changeset in webkit [192427] by matthew_hanson@apple.com

• 7 edits
  2 adds in branches/safari-601.1.46-branch

Merge r192042. rdar://problem/23189765

9:03 AM Changeset in webkit [192426] by matthew_hanson@apple.com

• 2 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merge r191872. rdar://problem/23395972

9:03 AM Changeset in webkit [192425] by matthew_hanson@apple.com

• 4 edits
  2 adds in branches/safari-601.1.46-branch

Merge r190595. rdar://problem/23432378

9:03 AM Changeset in webkit [192424] by matthew_hanson@apple.com

• 8 edits
  2 adds in branches/safari-601.1.46-branch

Merge r190446. rdar://problem/23432369

9:03 AM Changeset in webkit [192423] by matthew_hanson@apple.com

• 79 edits
  2 copies
  1 add in branches/safari-601.1.46-branch

Merge r188647. rdar://problem/23432373

9:03 AM Changeset in webkit [192422] by matthew_hanson@apple.com

• 18 edits
  4 adds in branches/safari-601.1.46-branch

Merge r188530. rdar://problem/23432371

9:03 AM Changeset in webkit [192421] by matthew_hanson@apple.com

• 8 edits
  5 adds in branches/safari-601.1.46-branch

Merge r188514. rdar://problem/23432371

9:02 AM Changeset in webkit [192420] by matthew_hanson@apple.com

• 18 edits
  4 adds in branches/safari-601.1.46-branch

Merge r188512. rdar://problem/23432371

9:02 AM Changeset in webkit [192419] by matthew_hanson@apple.com

• 7 edits in branches/safari-601.1.46-branch/Source

Merge r190574. rdar://problem/22846841

9:02 AM Changeset in webkit [192418] by matthew_hanson@apple.com

• 4 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merge r189635. rdar://problem/22846841

9:02 AM Changeset in webkit [192417] by matthew_hanson@apple.com

• 4 edits in branches/safari-601.1.46-branch/Source/WebKit2

Merge r189628. rdar://problem/22846841

7:59 AM Changeset in webkit [192416] by akling@apple.com

• 4 edits in trunk/Source/JavaScriptCore

[JSC] JSPropertyNameEnumerator could be destructorless.
<​https://webkit.org/b/151242>

Reviewed by Mark Lam.

Make JSPropertyNameEnumerator destructorless and have it store the property names
cache in CopiedSpace. This was the most popular occupant of 64-byte destructor cells
in MarkedSpace, so making it destructorless gets rid of some ill-filled MarkedBlocks.

• heap/CopyToken.h:
• runtime/JSPropertyNameEnumerator.cpp:

(JSC::JSPropertyNameEnumerator::finishCreation):
(JSC::JSPropertyNameEnumerator::visitChildren):
(JSC::JSPropertyNameEnumerator::copyBackingStore):
(JSC::JSPropertyNameEnumerator::destroy): Deleted.

• runtime/JSPropertyNameEnumerator.h:

5:49 AM WebKitGTK/Gardening/Howto edited by clopez@igalia.com

(diff)

4:50 AM Changeset in webkit [192415] by svillar@igalia.com

• 3 edits in trunk/LayoutTests

[css-grid] Fix swap-lines-if-start-is-further-endward-than-end-line.html
​https://bugs.webkit.org/show_bug.cgi?id=151257

Reviewed by Mario Sanchez Prada.

I forgot to add a link to resources/grid.css stylesheet when I
added this test so it was not actually testing Grid Layout
code.

• fast/css-grid-layout/swap-lines-if-start-is-further-endward-than-end-line-expected.html:
• fast/css-grid-layout/swap-lines-if-start-is-further-endward-than-end-line.html:

4:48 AM Changeset in webkit [192414] by svillar@igalia.com

• 3 edits in trunk/Source/WebCore

[css-grid] Remove unused GridResolvedPosition constructor
​https://bugs.webkit.org/show_bug.cgi?id=151133

Reviewed by Mario Sanchez Prada.

No new tests required, just deleting dead code.

• rendering/style/GridResolvedPosition.cpp:

(WebCore::GridResolvedPosition::GridResolvedPosition): Deleted.

• rendering/style/GridResolvedPosition.h:

3:13 AM Changeset in webkit [192413] by svillar@igalia.com

• 4 edits
  2 adds in trunk

ASSERTION FAILED: m_isEngaged in WTF::Optional::value
​https://bugs.webkit.org/show_bug.cgi?id=151094

Reviewed by Darin Adler.

Source/WebCore:

That ASSERT was hit because the precondition was incorrectly
met, i.e., we're considering that the main axis length was
definite when it was actually not. The problem is that to
determine whether it was indefinite or not we're using
RenderBox::hasDefiniteLogicalHeight() which did not perfectly
match RenderBox::computePercentageLogicalHeight() for the case
of RenderTables. So computePercentageLogicalHeight() was
returning Nullopt (i.e. indefinite) while
hasDefiniteLogicalHeight() was returning true (so definite).

Some checks were refactored in a helper function to solve the
inconsistency so that both functions behave the same way even
in this particular situation.

Test: css3/flexbox/inline-flex-percentage-height-in-table-crash.html

• rendering/RenderBox.cpp:

(WebCore::tableCellShouldHaveZeroInitialSize):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::percentageLogicalHeightIsResolvable):
(WebCore::RenderBox::percentageLogicalHeightIsResolvableFromBlock):

• rendering/RenderBox.h:

LayoutTests:

• css3/flexbox/inline-flex-percentage-height-in-table-crash-expected.txt: Added.
• css3/flexbox/inline-flex-percentage-height-in-table-crash.html: Added.

2:47 AM Changeset in webkit [192412] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebCore

Unreviewed, really fix the Mac CMake build after r192376.

• PlatformMac.cmake:

2:43 AM Changeset in webkit [192411] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebCore

Unreviewed, fix the Mac CMake build after r192376.

• PlatformMac.cmake:

Nov 12, 2015:

11:57 PM Changeset in webkit [192410] by ryuan.choi@navercorp.com

• 2 edits in trunk/Source/WebKit2

[EFL] Fix wrong test case for window_create since r192196
​https://bugs.webkit.org/show_bug.cgi?id=151247

Reviewed by Gyuyoung Kim.

r192196 introduces new test cases for window_create but there are typos which hide bug
This patch fixes typos and split ewk_view_create_window test case.

• UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

10:13 PM Changeset in webkit [192409] by commit-queue@webkit.org

• 6 edits in trunk/Source/JavaScriptCore

[JSC] Do not generate an Add when adding a zero immediate to something
​https://bugs.webkit.org/show_bug.cgi?id=151171

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-11-12
Reviewed by Geoffrey Garen.

Avoid generating an add if one of arguments is a zero immediate.

On x86, the add32/64() were also used internally for branchAdd32/64.
I split the code that sets flag to add32AndSetFlags() to make sure
we always force the flags before testing.

I could have used CMp to set the flags but I would gain nothing from
that, cmp is just a SUB.

• assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::add32):
(JSC::MacroAssemblerARM64::add64):

• assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::add32):

• assembler/MacroAssemblerX86.h:

(JSC::MacroAssemblerX86::add32):

• assembler/MacroAssemblerX86Common.h:

(JSC::MacroAssemblerX86Common::add32):
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::add32AndSetFlags):

• assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::add32):
(JSC::MacroAssemblerX86_64::add64):
(JSC::MacroAssemblerX86_64::branchAdd64):
(JSC::MacroAssemblerX86_64::add64AndSetFlags):

10:03 PM Changeset in webkit [192408] by Matt Baker

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Deleting a probe should remove probe breakpoint actions only.
​https://bugs.webkit.org/show_bug.cgi?id=151245

Reviewed by Brian Burg.

Fixed breakpoint action filter.

• UserInterface/Models/Breakpoint.js:

(WebInspector.Breakpoint.prototype.clearActions):
Missing return in named function expression.

8:03 PM FeatureFlags edited by jacquesolivier.hache@gmail.com

Added some flag details and links to spec. This is following Eric … (diff)

7:42 PM Changeset in webkit [192407] by bshafiei@apple.com

• 2 edits in tags/Safari-602.1.11.1/Source/WebCore

Merged r192405. rdar://problem/23529113

7:41 PM Changeset in webkit [192406] by bshafiei@apple.com

• 2 edits in tags/Safari-602.1.11.1/Source/WebCore

Merged r192404. rdar://problem/23529113

7:37 PM Changeset in webkit [192405] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

Follow up to the previous change

• platform/spi/cocoa/QuartzCoreSPI.h:

Somehow this escaped.

7:35 PM Changeset in webkit [192404] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

Try to fix the Watch/TV build

• platform/spi/cocoa/QuartzCoreSPI.h:

Be more accurate about where we need these.

7:32 PM Changeset in webkit [192403] by bshafiei@apple.com

• 5 edits in tags/Safari-602.1.11.1/Source

Versioning.

7:30 PM Changeset in webkit [192402] by bshafiei@apple.com

• 1 copy in tags/Safari-602.1.11.1

New tag.

6:53 PM Changeset in webkit [192401] by ggaren@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Restore CodeBlock jettison code I accidentally removed
​https://bugs.webkit.org/show_bug.cgi?id=151241

Reviewed by Andreas Kling.

I meant to add this back in <​http://trac.webkit.org/changeset/190827>
but I missed.

• bytecode/CodeBlock.cpp:

(JSC::timeToLive):
(JSC::CodeBlock::shouldJettisonDueToOldAge):

5:43 PM November 2015 Meeting edited by Joseph Pecoraro

(diff)

5:30 PM Changeset in webkit [192400] by fpizlo@apple.com

• 15 edits in trunk/Source/JavaScriptCore

B3 should be able to compile programs with CheckAdd, CheckSub, and CheckMul
​https://bugs.webkit.org/show_bug.cgi?id=151213

Reviewed by Benjamin Poulain.

This adds lowering code for CheckAdd, CheckSub, and CheckMul along with support for CheckNeg
(i.e. CheckSub with the left child being zero).

This adds tests for these things, by simulating what JS would do: if there is overflow, revert
to double math. To write the test, I needed support for IToD so I added that support.

This also fixes a memory corruption bug in the register allocator.

Also fixes a bug in opcode_generator.rb where we were emitting stray "return" statements inside
switch statements. I think this was benign, but I'm not sure, so I fixed it.

Note that I had to convert CheckMul handling to always use a three-operand form. That's because
there is no other way to tell Air that we need the original value alive. This means that on X86
we'll emit an extra Move just before the checked mul. That's probably fine since that's
necessary anyway.

• assembler/MacroAssemblerX86_64.h:

(JSC::MacroAssemblerX86_64::branchMul64):
(JSC::MacroAssemblerX86_64::branchSub64):

• b3/B3CheckSpecial.cpp:

(JSC::B3::CheckSpecial::generate):

• b3/B3Const32Value.cpp:

(JSC::B3::Const32Value::mulConstant):
(JSC::B3::Const32Value::checkAddConstant):
(JSC::B3::Const32Value::checkSubConstant):
(JSC::B3::Const32Value::checkMulConstant):
(JSC::B3::Const32Value::divConstant):

• b3/B3Const32Value.h:
• b3/B3Const64Value.cpp:

(JSC::B3::Const64Value::mulConstant):
(JSC::B3::Const64Value::checkAddConstant):
(JSC::B3::Const64Value::checkSubConstant):
(JSC::B3::Const64Value::checkMulConstant):
(JSC::B3::Const64Value::divConstant):

• b3/B3Const64Value.h:
• b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::appendUnOp):
(JSC::B3::Air::LowerToAir::ensureSpecial):
(JSC::B3::Air::LowerToAir::ensureCheckSpecial):
(JSC::B3::Air::LowerToAir::fillStackmap):
(JSC::B3::Air::LowerToAir::lower):

• b3/B3ReduceStrength.cpp:
• b3/B3Value.cpp:

(JSC::B3::Value::mulConstant):
(JSC::B3::Value::checkAddConstant):
(JSC::B3::Value::checkSubConstant):
(JSC::B3::Value::checkMulConstant):
(JSC::B3::Value::divConstant):

• b3/B3Value.h:
• b3/air/AirIteratedRegisterCoalescing.cpp:

(JSC::B3::Air::iteratedRegisterCoalescing):

• b3/air/AirOpcode.opcodes:
• b3/air/opcode_generator.rb:
• b3/testb3.cpp:

(JSC::B3::testCheckMegaCombo):
(JSC::B3::testCheckAddImm):
(JSC::B3::testCheckAdd):
(JSC::B3::testCheckAdd64):
(JSC::B3::testCheckAddFold):
(JSC::B3::testCheckAddFoldFail):
(JSC::B3::testCheckSubImm):
(JSC::B3::testCheckSub):
(JSC::B3::doubleSub):
(JSC::B3::testCheckSub64):
(JSC::B3::testCheckSubFold):
(JSC::B3::testCheckSubFoldFail):
(JSC::B3::testCheckNeg):
(JSC::B3::testCheckNeg64):
(JSC::B3::testCheckMul):
(JSC::B3::testCheckMul64):
(JSC::B3::testCheckMulFold):
(JSC::B3::testCheckMulFoldFail):
(JSC::B3::genericTestCompare):
(JSC::B3::run):

5:04 PM CommitQueue edited by dbates@webkit.org

Update and clarify who can set the commit-queue flag on a bug. (diff)

5:00 PM Changeset in webkit [192399] by dbates@webkit.org

• 2 edits in trunk/Tools

Add my apple.com email address to contributors.json

• Scripts/webkitpy/common/config/contributors.json:

4:54 PM Changeset in webkit [192398] by dbates@webkit.org

• 2 edits in trunk/Tools

webkitpy: Remove extraneous word "the" from the description of command attach-to-bug

• Scripts/webkitpy/tool/commands/upload.py:

(AttachToBug):

4:49 PM Changeset in webkit [192397] by andersca@apple.com

• 6 edits in trunk/Source/WebKit2

Add a context menu delegate method that takes a userInfo parameter
​https://bugs.webkit.org/show_bug.cgi?id=151232

Reviewed by Tim Horton.

• UIProcess/API/APIContextMenuClient.h:

(API::ContextMenuClient::menuFromProposedMenu):

• UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
• UIProcess/Cocoa/UIDelegate.h:
• UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::setDelegate):
(WebKit::UIDelegate::ContextMenuClient::menuFromProposedMenu):

• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::showContextMenu):

4:24 PM Changeset in webkit [192396] by beidson@apple.com

• 50 edits
  6 adds in trunk

Modern IDB: Pipe through cursor functions from client to server.
​https://bugs.webkit.org/show_bug.cgi?id=151197

Reviewed by Alex Christensen.

Source/WebCore:

Tests: storage/indexeddb/modern/cursor-1.html

storage/indexeddb/modern/opencursor-failures.html

This patch implements most IDBCursor considerations at the IDL level, as well as pipes the
appropriate messages through from client to server.

All operations currently end in errors. Bug 151196 will fix that by making cursors functional.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:

• Modules/indexeddb/IDBCursor.h:

(WebCore::IDBCursor::isKeyCursor): Deleted.

• Modules/indexeddb/IDBCursorWithValue.h:

• Modules/indexeddb/IDBGetResult.h:

• Modules/indexeddb/IDBKeyData.h:

(WebCore::IDBKeyData::string):
(WebCore::IDBKeyData::date):
(WebCore::IDBKeyData::number):
(WebCore::IDBKeyData::array):

• Modules/indexeddb/IndexedDB.h:

• Modules/indexeddb/client/IDBAnyImpl.cpp:

(WebCore::IDBClient::IDBAny::IDBAny):
(WebCore::IDBClient::IDBAny::idbCursor):
(WebCore::IDBClient::IDBAny::idbCursorWithValue):
(WebCore::IDBClient::IDBAny::idbIndex):
(WebCore::IDBClient::IDBAny::idbObjectStore):
(WebCore::IDBClient::IDBAny::modernIDBCursor):

• Modules/indexeddb/client/IDBAnyImpl.h:

(WebCore::IDBClient::IDBAny::create):

• Modules/indexeddb/client/IDBConnectionToServer.cpp:

(WebCore::IDBClient::IDBConnectionToServer::openCursor):
(WebCore::IDBClient::IDBConnectionToServer::didOpenCursor):
(WebCore::IDBClient::IDBConnectionToServer::iterateCursor):
(WebCore::IDBClient::IDBConnectionToServer::didIterateCursor):

• Modules/indexeddb/client/IDBConnectionToServer.h:
• Modules/indexeddb/client/IDBConnectionToServerDelegate.h:

• Modules/indexeddb/client/IDBCursorImpl.cpp:

(WebCore::IDBClient::IDBCursor::create):
(WebCore::IDBClient::IDBCursor::IDBCursor):
(WebCore::IDBClient::IDBCursor::sourcesDeleted):
(WebCore::IDBClient::IDBCursor::effectiveObjectStore):
(WebCore::IDBClient::IDBCursor::transaction):
(WebCore::IDBClient::IDBCursor::direction):
(WebCore::IDBClient::IDBCursor::key):
(WebCore::IDBClient::IDBCursor::primaryKey):
(WebCore::IDBClient::IDBCursor::value):
(WebCore::IDBClient::IDBCursor::source):
(WebCore::IDBClient::IDBCursor::update):
(WebCore::IDBClient::IDBCursor::advance):
(WebCore::IDBClient::IDBCursor::continueFunction):
(WebCore::IDBClient::IDBCursor::uncheckedIteratorCursor):
(WebCore::IDBClient::IDBCursor::deleteFunction):
(WebCore::IDBClient::IDBCursor::setGetResult):

• Modules/indexeddb/client/IDBCursorImpl.h:

(WebCore::IDBClient::IDBCursor::info):
(WebCore::IDBClient::IDBCursor::setRequest):
(WebCore::IDBClient::IDBCursor::clearRequest):
(WebCore::IDBClient::IDBCursor::request):

• Modules/indexeddb/client/IDBCursorWithValueImpl.cpp:

(WebCore::IDBClient::IDBCursorWithValue::create):
(WebCore::IDBClient::IDBCursorWithValue::IDBCursorWithValue):
(WebCore::IDBClient::IDBCursorWithValue::~IDBCursorWithValue):

• Modules/indexeddb/client/IDBCursorWithValueImpl.h:

• Modules/indexeddb/client/IDBIndexImpl.cpp:

(WebCore::IDBClient::IDBIndex::openCursor):
(WebCore::IDBClient::IDBIndex::openKeyCursor):

• Modules/indexeddb/client/IDBIndexImpl.h:

(WebCore::IDBClient::IDBIndex::modernObjectStore):
(WebCore::IDBClient::IDBIndex::isDeleted):

• Modules/indexeddb/client/IDBObjectStoreImpl.cpp:

(WebCore::IDBClient::IDBObjectStore::openCursor):
(WebCore::IDBClient::IDBObjectStore::deleteFunction):

• Modules/indexeddb/client/IDBObjectStoreImpl.h:

• Modules/indexeddb/client/IDBRequestImpl.cpp:

(WebCore::IDBClient::IDBRequest::create):
(WebCore::IDBClient::IDBRequest::IDBRequest):
(WebCore::IDBClient::IDBRequest::~IDBRequest):
(WebCore::IDBClient::IDBRequest::source):
(WebCore::IDBClient::IDBRequest::resultCursor):
(WebCore::IDBClient::IDBRequest::willIterateCursor):
(WebCore::IDBClient::IDBRequest::didOpenOrIterateCursor):
(WebCore::IDBClient::IDBRequest::requestCompleted):

• Modules/indexeddb/client/IDBRequestImpl.h:

(WebCore::IDBClient::IDBRequest::modernResult):

• Modules/indexeddb/client/IDBTransactionImpl.cpp:

(WebCore::IDBClient::IDBTransaction::requestOpenCursor):
(WebCore::IDBClient::IDBTransaction::doRequestOpenCursor):
(WebCore::IDBClient::IDBTransaction::openCursorOnServer):
(WebCore::IDBClient::IDBTransaction::didOpenCursorOnServer):
(WebCore::IDBClient::IDBTransaction::iterateCursor):
(WebCore::IDBClient::IDBTransaction::iterateCursorOnServer):
(WebCore::IDBClient::IDBTransaction::didIterateCursorOnServer):

• Modules/indexeddb/client/IDBTransactionImpl.h:

• Modules/indexeddb/client/TransactionOperation.h:

(WebCore::IDBClient::createTransactionOperation):

• Modules/indexeddb/legacy/LegacyCursor.cpp:

(WebCore::LegacyCursor::source):

• Modules/indexeddb/legacy/LegacyCursor.h:

(WebCore::LegacyCursor::continueFunction): Deleted.
(WebCore::LegacyCursor::isKeyCursor): Deleted.

• Modules/indexeddb/legacy/LegacyCursorWithValue.h:

• Modules/indexeddb/server/IDBBackingStore.h:

• Modules/indexeddb/server/IDBConnectionToClient.cpp:

(WebCore::IDBServer::IDBConnectionToClient::didOpenCursor):
(WebCore::IDBServer::IDBConnectionToClient::didIterateCursor):

• Modules/indexeddb/server/IDBConnectionToClient.h:
• Modules/indexeddb/server/IDBConnectionToClientDelegate.h:

• Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::openCursor):
(WebCore::IDBServer::IDBServer::iterateCursor):

• Modules/indexeddb/server/IDBServer.h:

• Modules/indexeddb/server/MemoryIDBBackingStore.cpp:

(WebCore::IDBServer::MemoryIDBBackingStore::openCursor):
(WebCore::IDBServer::MemoryIDBBackingStore::iterateCursor):

• Modules/indexeddb/server/MemoryIDBBackingStore.h:

• Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::openCursor):
(WebCore::IDBServer::UniqueIDBDatabase::performOpenCursor):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformOpenCursor):
(WebCore::IDBServer::UniqueIDBDatabase::iterateCursor):
(WebCore::IDBServer::UniqueIDBDatabase::performIterateCursor):
(WebCore::IDBServer::UniqueIDBDatabase::didPerformIterateCursor):

• Modules/indexeddb/server/UniqueIDBDatabase.h:

• Modules/indexeddb/server/UniqueIDBDatabaseTransaction.cpp:

(WebCore::IDBServer::UniqueIDBDatabaseTransaction::deleteRecord):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::openCursor):
(WebCore::IDBServer::UniqueIDBDatabaseTransaction::iterateCursor):

• Modules/indexeddb/server/UniqueIDBDatabaseTransaction.h:

• Modules/indexeddb/shared/IDBCursorInfo.cpp: Added.

(WebCore::IDBCursorInfo::objectStoreCursor):
(WebCore::IDBCursorInfo::indexCursor):
(WebCore::IDBCursorInfo::IDBCursorInfo):
(WebCore::IDBCursorInfo::isDirectionForward):
(WebCore::IDBCursorInfo::isolatedCopy):

• Modules/indexeddb/shared/IDBCursorInfo.h: Added.

(WebCore::IDBCursorInfo::identifier):
(WebCore::IDBCursorInfo::sourceIdentifier):
(WebCore::IDBCursorInfo::cursorSource):
(WebCore::IDBCursorInfo::cursorDirection):
(WebCore::IDBCursorInfo::cursorType):

• Modules/indexeddb/shared/IDBResultData.cpp:

(WebCore::IDBResultData::openCursorSuccess):
(WebCore::IDBResultData::iterateCursorSuccess):

• Modules/indexeddb/shared/IDBResultData.h:

• Modules/indexeddb/shared/InProcessIDBServer.cpp:

(WebCore::InProcessIDBServer::didOpenCursor):
(WebCore::InProcessIDBServer::didIterateCursor):
(WebCore::InProcessIDBServer::openCursor):
(WebCore::InProcessIDBServer::iterateCursor):

• Modules/indexeddb/shared/InProcessIDBServer.h:

• bindings/js/IDBBindingUtilities.cpp:

(WebCore::idbKeyDataToJSValue):

• bindings/js/IDBBindingUtilities.h:

• platform/CrossThreadCopier.cpp:

(WebCore::IDBCursorInfo>::copy):

• platform/CrossThreadCopier.h:

LayoutTests:

• storage/indexeddb/modern/cursor-1-expected.txt: Added.
• storage/indexeddb/modern/cursor-1.html: Added.
• storage/indexeddb/modern/opencursor-failures-expected.txt: Added.
• storage/indexeddb/modern/opencursor-failures.html: Added.

4:23 PM WebComponents2015 created by achristensen@apple.com

4:22 PM November 2015 Meeting edited by achristensen@apple.com

(diff)

4:21 PM Changeset in webkit [192395] by Brent Fulgham

• 4 edits in trunk/Tools

[Win] webkitpy is applying abspath to DOS paths, yielding invalid paths
​https://bugs.webkit.org/show_bug.cgi?id=151156

Reviewed by Anders Carlsson.

My earlier patch was incomplete. There are some Python libraries that want
to receive UNIX style paths, even though all of our applications and tools
use DOS paths. To handle this special case, we need to track a UNIX-style
absolute path that can be given to things like the Python socket server.

When we cut over to all-native Windows Python we can get rid of this
special case code.

• Scripts/webkitpy/common/system/filesystem.py:

(FileSystem.abspath): Add special code for Cygwin to convert a DOS-style
path into something Cygwin can use internally.

• Scripts/webkitpy/port/base.py:

(Port.results_directory): Remove custom Windows code. Instead, override
the method in the windows port object.
(Port.abs_results_directory): Add stub.
(Port.to.start_websocket_server): For Cygwin, use special cygwin absolute
path.

• Scripts/webkitpy/port/win.py:

(WinPort.init): Added to initialze new _abs_results_directory value.
(WinPort.abs_results_directory): Added,
(WinPort.results_directory): Modified to also create a value for
_abs_results_directory

4:15 PM Changeset in webkit [192394] by andersca@apple.com

• 7 edits
  1 delete in trunk/Source/WebCore

Delete PlatformMenuDescription.h
​https://bugs.webkit.org/show_bug.cgi?id=151229

Reviewed by Beth Dakin.

• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• WebCore.xcodeproj/project.pbxproj:
• page/ContextMenuClient.h:
• platform/ContextMenu.h:
• platform/ContextMenuItem.h:
• platform/PlatformMenuDescription.h: Removed.

3:55 PM Changeset in webkit [192393] by andersca@apple.com

• 8 edits in trunk/Source

ContextMenuAction and WebMenuItemTag shouldn't have to be in sync
​https://bugs.webkit.org/show_bug.cgi?id=151226

Reviewed by Tim Horton.

Source/WebCore:

• page/ContextMenuController.cpp:
• platform/ContextMenuItem.h:

Remove now unneeded comments. Also, remove ContextMenuItemTagOpenLinkInThisWindow since it wasn't used by any of our remaining ports.

Source/WebKit/mac:

• WebView/WebHTMLView.mm:

(toAction):
(toTag):
Add conversion functions.

(-[WebMenuTarget forwardContextMenuAction:]):
Use toAction.

(createMenuItem):
Use toTag.

(setMenuItemTarget): Deleted.
(setMenuTargets): Deleted.
(-[WebHTMLView menuForEvent:]):
Don't call setMenuTargets, that's already done when we create the menu items.

• WebView/WebUIDelegatePrivate.h:

Add missing menu item tags. This does break ABI, but the menu item tags were already out of sync
so it's very likely that nobody is relying on this.

Source/WebKit2:

• Shared/API/c/WKSharedAPICast.h:

(WebKit::toAPI):
(WebKit::toImpl):
Remove ContextMenuItemTagOpenLinkInThisWindow.

3:50 PM Changeset in webkit [192392] by mark.lam@apple.com

• 3 edits in trunk/LayoutTests

Layout Test js/regress/ftl-object-sub.html is flaky.
​https://bugs.webkit.org/show_bug.cgi?id=150730

Reviewed by Benjamin Poulain.

Shorten test time by 10x. Looks like we don't need it to run that long
after all. This should fix the timeouts. Also undid the test expectations.

• TestExpectations:
• js/regress/script-tests/ftl-object-sub.js:

(foo):

3:27 PM Changeset in webkit [192391] by commit-queue@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

Web Inspector: Reduce list of saved console messages
​https://bugs.webkit.org/show_bug.cgi?id=151225

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-11-12
Reviewed by Geoffrey Garen.

Inspector saves messages so that when an inspector frontend opens it can report
these messages to the frontend. However we were saving a rather large list of
1000 messages. Most pages do not produce a large number of console messages.
However pages that live for a long time can generate many errors over time,
especially periodic engine issues such as cross-origin access errors. This could
result in a lot of wasted memory for console messages that may never be used.

Likewise when an inspector first open sending all 1000 messages to the frontend
results in a poor experience.

Lets reduce the list of saved messages. Developer will still be able to see
all messages as long as they have Web Inspector open at the time the messages
are generated.

• inspector/agents/InspectorConsoleAgent.cpp:

Reduce the list from 1000 to 100. Also, when expiring
messages from this list, chunk in 10s instead of 100s.

3:12 PM Changeset in webkit [192390] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Adjust timeout values in ExecutionTimeLimitTest.
​https://bugs.webkit.org/show_bug.cgi?id=151223

Reviewed by Geoffrey Garen.

Some bots were not happy with the existing time out values. I adjusted them to give
the system a little more time to fire the timer events, and this made the bots happy.

• API/tests/ExecutionTimeLimitTest.cpp:

(testExecutionTimeLimit):

2:12 PM Changeset in webkit [192389] by Alan Bujtas

• 4 edits
  2 adds in trunk

Ignore visited background color when deciding if the input renderer needs to be painted natively.
​https://bugs.webkit.org/show_bug.cgi?id=151211
rdar://problem/21449823

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/css/pseudo-visited-background-color-on-input.html

• rendering/RenderTheme.cpp:

(WebCore::RenderTheme::isControlStyled):

• rendering/style/RenderStyle.h:

LayoutTests:

• fast/css/pseudo-visited-background-color-on-input-expected.html: Added.
• fast/css/pseudo-visited-background-color-on-input.html: Added.

2:07 PM Changeset in webkit [192388] by hyatt@apple.com

• 3 edits
  3 adds in trunk

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

Tatechuyoko shrink-to-fit breaks after changing color, background-color or text-decoration
​https://bugs.webkit.org/show_bug.cgi?id=151218
<rdar://problem/23521702>

Reviewed by Myles Maxfield.

Source/WebCore:

Added fast/text/text-combine-shrink-on-color-change.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):

LayoutTests:

• fast/text/text-combine-shrink-on-color-change.html: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.png: Added.
• platform/mac/fast/text/text-combine-shrink-on-color-change-expected.txt: Added.

2:06 PM FiveYearPlanFall2015 edited by Jon Davis

(diff)

2:05 PM Changeset in webkit [192387] by andersca@apple.com

• 4 edits in trunk/Source/WebCore

Use ContextMenuItemTagNoAction instead of ContextMenuItemCustomTagNoAction
​https://bugs.webkit.org/show_bug.cgi?id=151222

Reviewed by Joseph Pecoraro.

• bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::populateContextMenuItems):

• page/ContextMenuController.cpp:

(WebCore::ContextMenuController::checkOrEnableIfNeeded): Deleted.

• platform/ContextMenuItem.h:

2:00 PM GTKSecurity2015 edited by achristensen@apple.com

(diff)

1:57 PM Changeset in webkit [192386] by andersca@apple.com

• 2 edits in trunk/Source/WebKit/mac

Fix build.

• WebView/WebHTMLView.mm:

(fixMenusReceivedFromOldClients):

1:55 PM Changeset in webkit [192385] by keith_miller@apple.com

• 2 edits in trunk/Tools

Unreviewed, add Michael Saboff to the JavaScriptCore watchlist, per request.

• Scripts/webkitpy/common/config/watchlist:

1:47 PM Changeset in webkit [192384] by andersca@apple.com

• 3 edits in trunk/Source/WebKit/mac

Remove a couple of unused menu item tag enums
​https://bugs.webkit.org/show_bug.cgi?id=151220

Reviewed by Sam Weinig.

Also, move the old internal tags away from the SPI header.

• WebView/WebHTMLView.mm:

(fixMenusReceivedFromOldClients):

• WebView/WebUIDelegatePrivate.h:

1:40 PM Changeset in webkit [192383] by commit-queue@webkit.org

• 7 edits in trunk/Source/WebInspectorUI

Web Inspector: Auto-log inspect node selected elements to the console
​https://bugs.webkit.org/show_bug.cgi?id=151178

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-11-12
Reviewed by Brian Burg.

Auto-logging user selected elements to the console helps with
quick use in the console. $0 is not very discoverable, and $n
values are expendable. This also makes it convenient to use the
inspect node toolbar search option to select a few different
nodes and use each of them in the console without extra work.

• UserInterface/Controllers/DOMTreeManager.js:

(WebInspector.DOMTreeManager.prototype.inspectNodeObject.nodeAvailable):
(WebInspector.DOMTreeManager.prototype.inspectNodeObject):
Log selected nodes to the console. Treat this as a synthetic log that
will not immediately open the console like normal evaluation results.

• UserInterface/Controllers/JavaScriptLogViewController.js:

(WebInspector.JavaScriptLogViewController.prototype.appendImmediateExecutionWithResult.saveResultCallback):
(WebInspector.JavaScriptLogViewController.prototype.appendImmediateExecutionWithResult):
(WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted.printResult):
(WebInspector.JavaScriptLogViewController.prototype.consolePromptTextCommitted):
Initialize ConsoleCommandResultMessage's synthetic properties.

• UserInterface/Views/DOMTreeOutline.js:

(WebInspector.DOMTreeOutline.prototype._populateContextMenu.logElement):
(WebInspector.DOMTreeOutline.prototype._populateContextMenu):

• UserInterface/Controllers/RuntimeManager.js:

Create a global for the special "console" object group used in multiple places.

• UserInterface/Models/ConsoleCommandResultMessage.js:

(WebInspector.ConsoleCommandResultMessage):
(WebInspector.ConsoleCommandResultMessage.prototype.get synthetic):
Add a synthetic property.

• UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView.prototype.didAppendConsoleMessageView):
When the ConsoleResult is a synthetic result, do not auto-open the console.

1:29 PM Changeset in webkit [192382] by mmaxfield@apple.com

• 2 edits in trunk/Source/WebCore

[Cocoa] Font fallback is not language-sensitive
​https://bugs.webkit.org/show_bug.cgi?id=147390

Reviewed by Dean Jackson.

Test: fast/text/fallback-language-han-2.html

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontCache::systemFallbackForCharacters):

1:22 PM Changeset in webkit [192381] by andersca@apple.com

• 11 edits in trunk/Source

ContextMenuController::contextMenuItemSelected only needs the action and title, not the full item
​https://bugs.webkit.org/show_bug.cgi?id=151217

Reviewed by Joseph Pecoraro.

Source/WebCore:

• inspector/InspectorFrontendHost.cpp:
• page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected):

• page/ContextMenuController.h:
• page/ContextMenuProvider.h:

Source/WebKit/mac:

• WebView/WebHTMLView.mm:

(-[WebMenuTarget forwardContextMenuAction:]):

Source/WebKit/win:

• WebView.cpp:

(WebView::onMenuCommand):

Source/WebKit2:

• WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::itemSelected):

1:21 PM Changeset in webkit [192380] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Marking storage/indexeddb/modern/idbindex-properties-basic.html as flaky on mac-wk1
​https://bugs.webkit.org/show_bug.cgi?id=151219

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

1:19 PM Changeset in webkit [192379] by keith_miller@apple.com

• 2 edits in trunk/Tools

Unreviewed, add watchlist for Source/JavaScriptCore and add myself, Saam, and Mark.

• Scripts/webkitpy/common/config/watchlist:

1:06 PM presentation.pdf attached to GTKSecurity2015 by Michael Catanzaro

1:05 PM GTKSecurity2015 created by Michael Catanzaro

1:05 PM November 2015 Meeting edited by Michael Catanzaro

(diff)

1:02 PM Changeset in webkit [192378] by andersca@apple.com

• 13 edits in trunk/Source

Remove an unused function
​https://bugs.webkit.org/show_bug.cgi?id=151215

Reviewed by Joseph Pecoraro.

Source/WebCore:

• loader/EmptyClients.h:
• page/ContextMenuClient.h:
• page/ContextMenuController.cpp:

(WebCore::ContextMenuController::contextMenuItemSelected): Deleted.

Source/WebKit/mac:

• WebCoreSupport/WebContextMenuClient.h:
• WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::contextMenuItemSelected): Deleted.

Source/WebKit/win:

• WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::contextMenuItemSelected): Deleted.

• WebCoreSupport/WebContextMenuClient.h:

Source/WebKit2:

• WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::contextMenuItemSelected): Deleted.

• WebProcess/WebCoreSupport/WebContextMenuClient.h:

12:59 PM FiveYearPlanFall2015 edited by Simon Fraser

(diff)

12:47 PM FiveYearPlanFall2015 edited by Simon Fraser

(diff)

12:46 PM FiveYearPlanFall2015 edited by Simon Fraser

(diff)

12:46 PM FiveYearPlanFall2015 created by Simon Fraser

12:43 PM November 2015 Meeting edited by Simon Fraser

(diff)

12:41 PM Changeset in webkit [192377] by fpizlo@apple.com

• 5 edits in trunk/Source/JavaScriptCore

B3 should be able to compile Patchpoints with Register and Any constraints
​https://bugs.webkit.org/show_bug.cgi?id=151209

Reviewed by Geoffrey Garen.

Most of this patch is about adding tests, since Register constraints already worked but
were untested, and almost all forms of the Any constraint worked.

One change that I'm making is that Patchpoints now default to forCall effects rather
than no effects. I think this is better because if a client of Patchpoint never supplies
any effects, it's best to assume the worst.

My testing uncovered only one real bug: moveConstants() would turn all non-zero double
constants into Loads, so the optimization to fold constants into a Stackmap would stop
working. Instead of telling the Stackmap that the double value it wanted is actually a
constant, we would tell it that it's a register and it would emit code to materialize
the double into that register. I worked around this by having moveConstants() create
ConstDoubleValue's just for the Stackmaps, which lowerToAir() recognizes and does the
right thing with (i.e. folds into the stackmap instead of materializing).

• b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::fillStackmap):
(JSC::B3::Air::LowerToAir::lower):

• b3/B3MoveConstants.cpp:
• b3/B3PatchpointValue.cpp:

(JSC::B3::PatchpointValue::PatchpointValue):

• b3/testb3.cpp:

(JSC::B3::testPatchpointCallArg):
(JSC::B3::testPatchpointFixedRegister):
(JSC::B3::testPatchpointAny):
(JSC::B3::testPatchpointAnyImm):
(JSC::B3::testPatchpointManyImms):
(JSC::B3::testSimpleCheck):
(JSC::B3::run):

12:08 PM EncouragingOpenSourceContributionsFall2015 created by Martin Robinson

12:06 PM November 2015 Meeting edited by Martin Robinson

(diff)

12:06 PM Changeset in webkit [192376] by andersca@apple.com

• 17 edits
  2 deletes in trunk

Enable cross-platform context menus by default
​https://bugs.webkit.org/show_bug.cgi?id=151173

Reviewed by Tim Horton.

.:

• Source/cmake/OptionsEfl.cmake:

Source/WebCore:

• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::JSInspectorFrontendHost::showContextMenu):

• page/ContextMenuController.cpp:

(WebCore::ContextMenuController::addInspectElementItem): Deleted.

• platform/ContextMenu.cpp:
• platform/ContextMenu.h:
• platform/ContextMenuItem.cpp:
• platform/ContextMenuItem.h:

(WebCore::ContextMenuItem::isNull): Deleted.

• platform/mac/ContextMenuItemMac.mm: Removed.

(WebCore::menuToArray): Deleted.
(WebCore::ContextMenuItem::ContextMenuItem): Deleted.
(WebCore::createPlatformMenuItemDescription): Deleted.
(WebCore::ContextMenuItem::~ContextMenuItem): Deleted.
(WebCore::ContextMenuItem::platformDescription): Deleted.
(WebCore::ContextMenuItem::type): Deleted.
(WebCore::ContextMenuItem::action): Deleted.
(WebCore::ContextMenuItem::title): Deleted.
(WebCore::ContextMenuItem::platformSubMenu): Deleted.
(WebCore::ContextMenuItem::setType): Deleted.
(WebCore::ContextMenuItem::setAction): Deleted.
(WebCore::ContextMenuItem::setTitle): Deleted.
(WebCore::ContextMenuItem::setSubMenu): Deleted.
(WebCore::ContextMenuItem::setChecked): Deleted.
(WebCore::ContextMenuItem::setEnabled): Deleted.
(WebCore::ContextMenuItem::enabled): Deleted.
(WebCore::ContextMenuItem::checked): Deleted.

• platform/mac/ContextMenuMac.mm: Removed.

(WebCore::ContextMenu::ContextMenu): Deleted.
(WebCore::ContextMenu::~ContextMenu): Deleted.
(WebCore::ContextMenu::appendItem): Deleted.
(WebCore::ContextMenu::insertItem): Deleted.
(WebCore::ContextMenu::itemCount): Deleted.
(WebCore::ContextMenu::setPlatformDescription): Deleted.
(WebCore::ContextMenu::platformDescription): Deleted.
(WebCore::ContextMenu::releasePlatformDescription): Deleted.
(WebCore::contextMenuItemVector): Deleted.
(WebCore::platformMenuDescription): Deleted.

Source/WebKit/mac:

• WebView/WebHTMLView.mm:

(createMenuItem):
(customMenuFromDefaultItems):

Source/WebKit2:

• Shared/WebContextMenuItemData.cpp:

(WebKit::WebContextMenuItemData::WebContextMenuItemData): Deleted.

• WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::menuItemsWithUserData): Deleted.

Source/WTF:

• wtf/Platform.h:

12:05 PM November 2015 Meeting edited by rniwa@webkit.org

Added a note for the encouraging open source contribution session (diff)

12:02 PM Changeset in webkit [192375] by dbates@webkit.org

• 8 edits in trunk/Tools

Support building configuration Production of DumpRenderTree and WebKitTestRunner for iOS
​https://bugs.webkit.org/show_bug.cgi?id=151191

Reviewed by Andy Estes.

• DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Remove hardcoded SKIP_INTALL.

Will override this setting in DumpRenderTree.xcconfig.

• DumpRenderTree/mac/Configurations/DumpRenderTree.xcconfig: When building for iOS we now

compile source file DumpRenderTreeMain.mm to produce a built product and make the Apple
Internal build system happy. Do not waste time coping OpenType font files (*.otf files)
and skip installation when building for iOS since we are not interested in the build product
and are only building this target to make the Apple Internal build system happy.

• DumpRenderTree/mac/DumpRenderTreeMain.mm:

(main): Added dummy implementation for iOS so that we build an actual command line tool to
make the Apple Internal build system happy.

• WebKitTestRunner/Configurations/Base.xcconfig: Add iOS-specific definition for WEBKIT_UMBRELLA_FRAMEWORKS_DIR.
• WebKitTestRunner/Configurations/DebugRelease.xcconfig: Remove variable WEBKIT_UMBRELLA_FRAMEWORKS_DIR.
• WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Build file WebKitTestRunner/mac/main.mm

on iOS Only to produce a built product and make the Apple Internal build system happy. No need
to define OTHER_LDFLAGS when building this target for iOS as the default linker flags are sufficient.

• WebKitTestRunner/mac/main.mm:

(main): Added dummy implementation for iOS so that we build an actual command line tool to
make the Apple Internal build system happy.

12:02 PM Changeset in webkit [192374] by Chris Dumez

• 2 edits in trunk/Tools

Unreviewed, add watchlist for history/ and add myself.

• Scripts/webkitpy/common/config/watchlist:

11:57 AM Changeset in webkit [192373] by Chris Dumez

• 2 edits in trunk/Tools

Unreviewed, update my watchlists.

• Scripts/webkitpy/common/config/watchlist:

11:37 AM Changeset in webkit [192372] by mmaxfield@apple.com

• 7 edits
  2 adds in trunk

[Cocoa] Font fallback is not language-sensitive
​https://bugs.webkit.org/show_bug.cgi?id=147390

Reviewed by Dean Jackson.

Source/WebCore:

This re-applies r190754 in a somewhat more performant way.

Test: fast/text/fallback-language-han-2.html

• platform/graphics/Font.cpp:

(WebCore::CharacterFallbackMapKey::CharacterFallbackMapKey):
(WebCore::CharacterFallbackMapKey::operator==):
(WebCore::CharacterFallbackMapKeyHash::hash):
(WebCore::Font::systemFallbackFontForCharacter):

• platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::FontCache::systemFallbackForCharacters):

LayoutTests:

This patch adds a mismatch test to make sure a codepoint gets rendered differently given two different langs.

• fast/text/fallback-language-han-2-expected-mismatch.html: Added.
• fast/text/fallback-language-han-2.html: Added.
• platform/efl/TestExpectations:
• platform/gtk/TestExpectations:
• platform/mac/TestExpectations:
• platform/win/TestExpectations:

11:30 AM November 2015 Meeting edited by Jon Davis

(diff)

11:29 AM ColorDiscussionFall2015 created by Jon Davis

11:22 AM Changeset in webkit [192371] by dbates@webkit.org

• 8 edits in trunk/Tools

Rename webkitdirs::willUseIOS{Device, Simulator}SDKWhenBuilding() to willUseIOS{Device, Simulator}SDK()
​https://bugs.webkit.org/show_bug.cgi?id=151207

Rubber-stamped by Alexey Proskuryakov.

The functions webkitdirs::willUseIOS{Device, Simulator}SDKWhenBuilding() are not specific to building
iOS software. We should rename these functions to webkitdirs::willUseIOS{Device, Simulator}SDK() to
convey their general-purpose nature of determining whether we are using the iphoneos or iphonesimulator SDK.

• Scripts/build-jsc:
• Scripts/build-layouttestrelay:
• Scripts/build-webkit:
• Scripts/copy-webkitlibraries-to-product-directory:
• Scripts/run-api-tests:

(runTest):
(prepareEnvironmentForRunningTestTool):

• Scripts/run-javascriptcore-tests:
• Scripts/webkitdirs.pm:

(XcodeOptions):
(willUseIOSDeviceSDK): Formerly named willUseIOSDeviceSDKWhenBuilding.
(willUseIOSSimulatorSDK): Formerly name willUseIOSSimulatorSDKWhenBuilding.
(isIOSWebKit):
(runIOSWebKitApp):
(willUseIOSDeviceSDKWhenBuilding): Deleted.
(willUseIOSSimulatorSDKWhenBuilding): Deleted.

11:19 AM Changeset in webkit [192370] by dbates@webkit.org

• 3 edits in trunk/Tools

run-api-tests fails to run with public iOS SDK
​https://bugs.webkit.org/show_bug.cgi?id=151076

Reviewed by Alexey Proskuryakov.

Use the command line tool simctl as the sim tool was removed from the public iOS 9 SDK.

A side benefit of this change it is sufficient to run the tests without launching Simulator.app
to boot the simulator device beforehand because simctl will boot the device for us.

Additionally, use Perl pragma sigtrap to install signal handlers to catch SIG{HUP, INT, PIPE, TERM}
signals and ultimately run our END block so that we shutdown the simulator device (if applicable).
This makes Control-C terminate the app gracefully.

• Scripts/run-api-tests:

(runTest):
(listAllTests):
(prepareEnvironmentForRunningTestTool): When running for iOS Simulator use setupIOSWebKitEnvironment()
to setup the environment variables for iOS instead of using setupMacWebKitEnvironment(). We also
prefix the name of these environment variables with "SIMCTL_CHILD_" so that simctl sets these environment
variables in the simulator environment.

• Scripts/webkitdirs.pm:

(shutDownIOSSimulatorDevice): Added.
(restartIOSSimulatorDevice): Added.

11:18 AM November 2015 Meeting edited by Jon Davis

Added web inspector discussion notes (diff)

11:17 AM WebInspectorDiscussionFall2015 created by Jon Davis

10:39 AM Changeset in webkit [192369] by jhoneycutt@apple.com

• 4 edits
  6 adds in trunk

popstate event should be dispatched asynchronously
​https://bugs.webkit.org/show_bug.cgi?id=36202
<rdar://problem/7761279>

Based on an original patch by Mihai Parparita <​mihaip@chromium.org>.

Reviewed by Brent Fulgham.

Source/WebCore:

Tests: fast/loader/remove-iframe-during-history-navigation-different.html

fast/loader/remove-iframe-during-history-navigation-same.html
fast/loader/stateobjects/popstate-is-asynchronous.html

• dom/Document.cpp:

(WebCore::Document::enqueuePopstateEvent):
Use enqueueWindowEvent().

LayoutTests:

• fast/loader/remove-iframe-during-history-navigation-different-expected.txt: Added.
• fast/loader/remove-iframe-during-history-navigation-different.html: Added.

Imported from Blink.

• fast/loader/remove-iframe-during-history-navigation-same-expected.txt: Added.
• fast/loader/remove-iframe-during-history-navigation-same.html: Added.

Ditto.

• fast/loader/stateobjects/popstate-fires-on-history-traversal.html:

Modified to account for popstate firing asynchronously.

• fast/loader/stateobjects/popstate-is-asynchronous-expected.txt: Added.
• fast/loader/stateobjects/popstate-is-asynchronous.html: Added.

Based on Mihai's original test. Modified to pass in current WebKit.

10:21 AM Changeset in webkit [192368] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebCore

Fix build failure due to missing NeverDestroyed.h include after r192169
​https://bugs.webkit.org/show_bug.cgi?id=151186

Reviewed by Darin Adler.

• rendering/RenderCombineText.cpp:

10:17 AM Changeset in webkit [192367] by Csaba Osztrogonác

• 2 edits in trunk/Source/WebCore

Fix build failure due to missing forward declaration of FontVariantSettings after r191968
​https://bugs.webkit.org/show_bug.cgi?id=151185

Reviewed by Myles C. Maxfield.

• css/CSSFontFaceSource.h:

10:12 AM Changeset in webkit [192366] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Move some prototypes to header files.
​https://bugs.webkit.org/show_bug.cgi?id=151194

Reviewed by Michael Saboff.

• assembler/MacroAssemblerPrinter.cpp:

(JSC::printIndent):

• assembler/MacroAssemblerPrinter.h:

(JSC::MacroAssembler::print):

10:08 AM b3Discussion2015 edited by achristensen@apple.com

added newlines (diff)

10:07 AM b3Discussion2015 created by achristensen@apple.com

added b3 discussion notes

10:07 AM November 2015 Meeting edited by achristensen@apple.com

added link to b3 discussion notes, which I'll upload soon (diff)

10:03 AM NetworkCleanupDiscussion2015 edited by achristensen@apple.com

(diff)

10:03 AM Changeset in webkit [192365] by eric.carlson@apple.com

• 19 edits
  4 adds in trunk

[MediaStream] Reflect media stream tracks as HTMLMediaElement tracks
​https://bugs.webkit.org/show_bug.cgi?id=151145

Reviewed by Jer Noble.

Source/WebCore:

Test: fast/mediastream/MediaStream-video-element.html

• WebCore.xcodeproj/project.pbxproj: Add new header files.

• html/track/AudioTrack.h: Add comments to clean things up slightly.
• html/track/VideoTrack.h: Ditto.

Create a AudioTrackPrivateMediaStream or VideoTrackPrivateMediaStream for each track in
the MediaStream.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::load): Call updateTracks.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::didAddTrack): Ditto.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::didRemoveTrack): Ditto.
(WebCore::updateTracksOfType): New, template function to update audio or video tracks.
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::updateTracks): New.

• platform/mediastream/AudioTrackPrivateMediaStream.h: Added.

• platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::currentFrameImage): Fix a typo, early return if the track is

not active OR there is no active video track.

• platform/mediastream/MediaStreamPrivate.h:

(WebCore::MediaStreamPrivate::activeVideoTrack): Accessor for active video track, if any.

• platform/mediastream/VideoTrackPrivateMediaStream.h: Added.

• platform/mediastream/mac/AVAudioCaptureSource.mm:

(WebCore::AVAudioCaptureSource::updateStates): Set current states.

• platform/mediastream/mac/AVMediaCaptureSource.mm:

(WebCore::AVMediaCaptureSource::states): Set source ID.
(WebCore::AVMediaCaptureSource::capabilities): Set source ID directly.

• platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::AVVideoCaptureSource):
(WebCore::AVVideoCaptureSource::updateStates): Set states here instead of in the constructor.

• platform/mock/MockRealtimeMediaSource.cpp:

(WebCore::MockRealtimeMediaSource::capabilities): Set source ID directly.

• platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::updateStates): Set source type.

LayoutTests:

• fast/mediastream/MediaStream-video-element-expected.txt: Added.
• fast/mediastream/MediaStream-video-element.html: Added.
• fast/mediastream/resources/getUserMedia-helper.js: Return early on error.
• platform/gtk/TestExpectations: Skip new test.
• platform/ios-simulator/TestExpectations: Ditto.
• platform/mac-wk2/TestExpectations: Ditto.
• platform/win/TestExpectations: Ditto.

9:54 AM Changeset in webkit [192364] by mitz@apple.com

• 2 edits in trunk/Source/WebKit2

Fixed the build.

• PluginProcess/EntryPoint/mac/XPCService/PluginServiceEntryPoint.mm:

(PluginServiceInitializer):

9:02 AM Changeset in webkit [192363] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: timeline event markers are added to overview even when not capturing a timeline recording
​https://bugs.webkit.org/show_bug.cgi?id=151166

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-11-12
Reviewed by Timothy Hatcher.

• UserInterface/Models/TimelineRecording.js:

(WebInspector.TimelineRecording.prototype.addEventMarker):
Do not add event markers when not capturing. This would have resulted in more
and more markers showing in the Timeline for page loads when the Timeline was
not active. For example reloading when a non-Timeline tab was active.

6:12 AM Changeset in webkit [192362] by hyuki.kim@samsung.com

• 2 edits in trunk/Tools

[EFL] fix EvasGL configuration error
​https://bugs.webkit.org/show_bug.cgi?id=151180

Reviewed by Csaba Osztrogonác.

EvasGL backend and depth, stencil buffer size should be specified before elm_win_add to let EvasGL keep quiet.
Additionally, duplicated elm_config_accel_preference_set() call is eleminated.

• MiniBrowser/efl/main.c:

(window_create):
(elm_main):

5:34 AM Changeset in webkit [192361] by youenn.fablet@crf.canon.fr

• 17 edits in trunk

XHR abort() event firing does not match spec
​https://bugs.webkit.org/show_bug.cgi?id=98404

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

• web-platform-tests/XMLHttpRequest/abort-after-receive-expected.txt:
• web-platform-tests/XMLHttpRequest/abort-after-timeout-expected.txt:
• web-platform-tests/XMLHttpRequest/abort-during-upload-expected.txt:
• web-platform-tests/XMLHttpRequest/abort-event-abort-expected.txt:
• web-platform-tests/XMLHttpRequest/abort-event-order-expected.txt:
• web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-aborted-expected.txt:
• web-platform-tests/XMLHttpRequest/xmlhttprequest-timeout-worker-aborted-expected.txt:

Source/WebCore:

Introducing explicit sendFlag as in the specification.
Previously, sendFlag was computed using !!m_loader.
But this does not work well for loadstart events since sendFlag should be true but m_loader is still null at that time.

Updated abort event firing test according specification.
For instance, compared to previously, the abort event is not fired in DONE state or if sendFlag is not set.

Covered by rebased tests.

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::callReadyStateChangeListener): Compute whether dispatching the load event before calling XHR readystatechange event callback.
(WebCore::XMLHttpRequest::setWithCredentials): Replacing m_loader by m_sendFlag to align with the spec.
(WebCore::XMLHttpRequest::open): Unsetting m_sendFlag..
(WebCore::XMLHttpRequest::initSend): Replacing m_loader by m_sendFlag to align with the spec.
(WebCore::XMLHttpRequest::createRequest): Setting m_sendFlag.
(WebCore::XMLHttpRequest::abort): Checking m_sendFlag and updating code to follow the specification.
(WebCore::XMLHttpRequest::genericError): Unsetting m_sendFlag.
(WebCore::XMLHttpRequest::setRequestHeader): Replacing m_loader by m_sendFlag to align with the spec.
(WebCore::XMLHttpRequest::didFinishLoading): Ditto.
(WebCore::XMLHttpRequest::didReachTimeout): Ditto.

• xml/XMLHttpRequest.h: Added m_sendFlag.

LayoutTests:

Rebasing test expectations.

• fast/events/event-fire-order-expected.txt:
• fast/events/event-fire-order.html: Updated so that it does not expect any event when aborting just after open().
• http/tests/xmlhttprequest/onloadend-event-after-sync-requests.html: Updated to expect load event and not abort event when XHR state is DONE.
• http/tests/xmlhttprequest/upload-onloadend-event-after-sync-requests.html: Ditto.
• platform/gtk/TestExpectations: Removing timeout expectation for imported/w3c/web-platform-tests/XMLHttpRequest/interfaces.html

5:19 AM Changeset in webkit [192360] by Csaba Osztrogonác

• 2 edits in trunk/Tools

[EFL] Fix EFL 1.16 with enabled NEON support
​https://bugs.webkit.org/show_bug.cgi?id=151188

Unreviewed buildfix, disable NEON temporarily after r192358.

• efl/jhbuild.modules:

3:19 AM Changeset in webkit [192359] by Carlos Garcia Campos

• 3 edits in trunk/Source/WebCore

[GStreamer] Use RunLoop::timer in MediaPlayerPrivateGStreamerBase for GL drawing
​https://bugs.webkit.org/show_bug.cgi?id=151099

Reviewed by Philippe Normand.

Instead of the GThreadSafeMainLoopSource.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::repaint):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase): Deleted.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

2:50 AM Changeset in webkit [192358] by Csaba Osztrogonác

• 2 edits
  1 delete in trunk/Tools

[EFL] Bump EFL version to 1.16.0
​https://bugs.webkit.org/show_bug.cgi?id=150228

Reviewed by Gyuyoung Kim.

• efl/jhbuild.modules:
• efl/patches/efl-remove-XPrint.patch: Removed.

2:31 AM Changeset in webkit [192357] by Csaba Osztrogonác

• 19 edits in trunk

Remove ENABLE(SATURATED_LAYOUT_ARITHMETIC) guards
​https://bugs.webkit.org/show_bug.cgi?id=150972

Reviewed by Darin Adler.

.:

• Source/cmake/OptionsMac.cmake:
• Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

• Configurations/FeatureDefines.xcconfig:
• platform/LayoutUnit.h:

(WebCore::operator*):
(WebCore::LayoutUnit::LayoutUnit): Deleted.
(WebCore::LayoutUnit::fromFloatCeil): Deleted.
(WebCore::LayoutUnit::fromFloatFloor): Deleted.
(WebCore::LayoutUnit::fromFloatRound): Deleted.
(WebCore::LayoutUnit::ceil): Deleted.
(WebCore::LayoutUnit::round): Deleted.
(WebCore::LayoutUnit::floor): Deleted.
(WebCore::LayoutUnit::setValue): Deleted.
(WebCore::operator/): Deleted.
(WebCore::operator+): Deleted.
(WebCore::operator-): Deleted.
(WebCore::operator+=): Deleted.
(WebCore::operator-=): Deleted.

• rendering/LayoutState.cpp:

(WebCore::LayoutState::LayoutState):

• rendering/LayoutState.h:

(WebCore::LayoutState::LayoutState):

• rendering/RenderView.h:

Source/WebKit/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

• wtf/FeatureDefines.h:

Tools:

• TestWebKitAPI/Tests/WebCore/LayoutUnit.cpp:

2:20 AM Changeset in webkit [192356] by hyuki.kim@samsung.com

• 2 edits in trunk/Tools

[EFL] fix EvasGL configuration error
​https://bugs.webkit.org/show_bug.cgi?id=151180

Reviewed by Gyuyoung Kim.

EvasGL backend and depth, stencil buffer size should be specified before elm_win_add to let EvasGL keep quiet

• MiniBrowser/efl/main.c:

(window_create):

Nov 11, 2015:

11:38 PM Changeset in webkit [192355] by benjamin@webkit.org

• 3 edits in trunk/Source/JavaScriptCore

[JSC] Air: we have more register than what the allocator believed
​https://bugs.webkit.org/show_bug.cgi?id=151182

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-11-11
Reviewed by Michael Saboff.

I was using GPRInfo/FPRInfo to get the number of register while coloring the interference graph.
The problem is, those classes are lying about register availability.

They don't report stuff reserved by the MacroAssembler and reserve some registers.
FPRInfo is the worst, reporting only 6 of the 15 registers we have.

The ground truth in our case is that we can color with all the registers returned
by regsInPriorityOrder(). I changed IteratedRegisterCoalescingAllocator to use that value.

The new test testSpillFP() covers simple spilling of doubles.

• b3/air/AirIteratedRegisterCoalescing.cpp:

(JSC::B3::Air::IteratedRegisterCoalescingAllocator::IteratedRegisterCoalescingAllocator):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::makeWorkList):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::decrementDegree):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::precoloredCoalescingHeuristic):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::conservativeHeuristic):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::addWorkList):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::combine):
(JSC::B3::Air::IteratedRegisterCoalescingAllocator::freezeMoves):

• b3/testb3.cpp:

(JSC::B3::testSpillFP):
(JSC::B3::run):

11:28 PM Changeset in webkit [192354] by Chris Dumez

• 86 edits in trunk/Source/WebCore

Stop passing a PassRefPtr to dispatchEvent()
​https://bugs.webkit.org/show_bug.cgi?id=151158

Reviewed by Alex Christensen.

Stop passing a PassRefPtr to dispatchEvent() because:

1. PassRefPtr is legacy and should no longer be used
2. We don't actually transfer ownership of the Event to the callee

Pass a C++ reference instead.

11:17 PM Changeset in webkit [192353] by mark.lam@apple.com

• 6 edits in trunk/Source/JavaScriptCore

The BinarySnippetRegisterContext needs to copy the result back from the scratch register.
​https://bugs.webkit.org/show_bug.cgi?id=150712

Reviewed by Geoffrey Garen.

If the BinarySnippetRegisterContext had re-assigned the result register to a scratch
before emitting the snippet, it needs to copy the result back from the scratch after
the snippet is done.

This fixes the cdjs-tests.yaml/main.js.ftl failure reported in
​https://bugs.webkit.org/show_bug.cgi?id=150687.

Also added an optimization to check for the case where any of the left, right,
or result registers are aliased together, and to map them to the corresponding
allocated scratch register for their alias instead of allocating separate ones.

• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
• JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
• Added JITSubGenerator.h to these project files for completeness.

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• Re-enable ArithSub handling of UntypedUse operands.

• ftl/FTLCompile.cpp:

• ftl/FTLInlineCacheSize.cpp:

(JSC::FTL::sizeOfArithSub):

• Adjusted IC sizes to account for the snippet changes.

10:59 PM Changeset in webkit [192352] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Crash in sorting-benchmark.js on ARM64 with full op_sub FTL coverage.
​https://bugs.webkit.org/show_bug.cgi?id=150936

Reviewed by Michael Saboff.

The OSR entry thunk does not currently restore the callee saved registers that the baseline
JIT saves but the DFG does not. As a result, sorting-benchmark.js was crashing with the
following scenario:

1. There exists 2 functions: benchmark() and bottom_up_merge_sort(). Let's call them A() and B() respectively for brevity.
2. A() is FTL compiled.
3. B() is FTL compiled.
4. FTL A() calls FTL B(). FTL B() trashes register x26.
5. FTL B() goes through an OSR exit, and deopts to baseline. The OSR exit off-ramp puts x26's original value in the baseline B()'s stash location for x26 in its stack frame. It expects baseline B() to restore x26 when it returns.
6. Baseline B() gets DFG optimized, and we OSR enter into DFG B(). The OSR entry thunk does nothing to restore x26's original value. Hence, x26 contains whatever value FTL B() left in it.
7. DFG B() returns to FTL A(). x26 is not one of the callee saved registers used by DFG B(). Hence, it does nothing to restore it.
8. FTL A() tries to use x26 and crashes, because x26 contains FTL B()'s value for it, and not FTL A()'s.

This patch fixes this issue by having the OSR entry thunk restore all the callee saved
registers before running the DFG code.

No new test needed because this issue will be covered by sorting-benchmark.js as soon as
​https://bugs.webkit.org/show_bug.cgi?id=150712 lands.

• dfg/DFGThunks.cpp:

(JSC::DFG::osrEntryThunkGenerator):

10:49 PM November 2015 Meeting edited by Joseph Pecoraro

(diff)

10:49 PM schedule2.png attached to November 2015 Meeting by Joseph Pecoraro

schedule2

10:48 PM November 2015 Meeting edited by Joseph Pecoraro

Add screenshot of schedule (diff)

10:46 PM schedule.png attached to November 2015 Meeting by Joseph Pecoraro

Image of Schedule

10:40 PM WebKitWebSiteDiscussion2015 edited by Joseph Pecoraro

(diff)

10:39 PM NetworkCleanupDiscussion2015 created by Joseph Pecoraro

Initial Load

10:36 PM CMakeDiscussion2015 edited by Joseph Pecoraro

(diff)

10:35 PM CMakeDiscussion2015 created by Joseph Pecoraro

Initial Draft

10:33 PM November 2015 Meeting edited by Joseph Pecoraro

(diff)

10:33 PM Changeset in webkit [192351] by commit-queue@webkit.org

• 4 edits
  2 adds
  1 delete in trunk/Source/WebInspectorUI

Web Inspector: Add Debug toolbar button to toggle InspectorBackend.dumpInspectorProtocolMessages
​https://bugs.webkit.org/show_bug.cgi?id=151175

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-11-11
Reviewed by Brian Burg.

Add debug UI and a way to toggle it on and off in non-production builds.
To enable the debug UI use a keyboard shortcut in Inspector:
Option+Shift+Command+D (Mac) or Option+Shift+Ctrl+D (Windows / Linux)

The debug UI setting is a persistent setting, so those of use developing
Web Inspector will turn it on and leave it on.

Currently the only debug UI is a new toolbar button to toggle
the frontend logging on or off.

• Scripts/combine-resources.pl:

(concatenateFiles):
Exclude "Debug" files when combining resources for minification.

• UserInterface/Main.html:

Rename "Base/Bootstrap.js" to "Debug/Bootstrap" so that we can easily exclude it.

• UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
Only evaluate bootstrap functions if they exist.

• UserInterface/Debug/Bootstrap.js: Renamed from Source/WebInspectorUI/UserInterface/Base/Bootstrap.js.

(WebInspector.runBootstrapOperations):
Add a debug setting, toolbar button, and keyboard shortcut.

10:32 PM November 2015 Meeting edited by Joseph Pecoraro

(diff)

10:31 PM WebKitWebSiteDiscussion2015 edited by Joseph Pecoraro

(diff)

10:31 PM WebKitWebSiteDiscussion2015 edited by Joseph Pecoraro

(diff)

10:30 PM WebKitWebSiteDiscussion2015 edited by Joseph Pecoraro

(diff)

10:30 PM WebKitWebSiteDiscussion2015 edited by Joseph Pecoraro

(diff)

10:30 PM WebKitWebSiteDiscussion2015 edited by Joseph Pecoraro

(diff)

10:30 PM WebKitWebSiteDiscussion2015 edited by Joseph Pecoraro

(diff)

10:29 PM WebKitWebSiteDiscussion2015 edited by Joseph Pecoraro

(diff)

10:29 PM WebKitWebSiteDiscussion2015 edited by Joseph Pecoraro

(diff)

10:29 PM WebKitWebSiteDiscussion2015 edited by Joseph Pecoraro

(diff)

10:25 PM WebKitWebSiteDiscussion2015 created by Joseph Pecoraro

10:24 PM November 2015 Meeting edited by Joseph Pecoraro

(diff)

10:24 PM November 2015 Meeting edited by Joseph Pecoraro

(diff)

10:09 PM Changeset in webkit [192350] by Chris Dumez

• 2 edits in trunk/Source/WebCore

Fix leaks in idbKeyFromInspectorObject()
​https://bugs.webkit.org/show_bug.cgi?id=151179

Reviewed by Brian Burg.

Fix leaks in idbKeyFromInspectorObject() that were caused by the
NeverDestroyed<> not being marked as static.

• inspector/InspectorIndexedDBAgent.cpp:

9:48 PM Changeset in webkit [192349] by Gyuyoung Kim

• 2 edits in trunk/Source/WebKit2

Print result of memory sampler more readable
​https://bugs.webkit.org/show_bug.cgi?id=151085

Reviewed by Darin Adler.

Current memory sampler prints result of memory sample horizontally. It makes us hard to read
the result at a glance. To improve readability of the memory sampler result, this patch prints it
vertically.

• Shared/WebMemorySampler.cpp:

(WebKit::WebMemorySampler::appendCurrentMemoryUsageToFile):
(WebKit::WebMemorySampler::writeHeaders):

9:19 PM Changeset in webkit [192348] by benjamin@webkit.org

• 2 edits in trunk/Source/JavaScriptCore

[JSC] Add a comment explaining the opcode suffixes on x86
​https://bugs.webkit.org/show_bug.cgi?id=151176

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-11-11
Reviewed by Alex Christensen.

• assembler/X86Assembler.h:

I was always confused with the prefixes. Gavin pointed out the Intel documentation
explains everything.
I added a comment to help the next person confused about those suffixes.

9:12 PM Changeset in webkit [192347] by benjamin@webkit.org

• 7 edits in trunk/Source/JavaScriptCore

[JSC] Support Doubles with B3's Add
​https://bugs.webkit.org/show_bug.cgi?id=151164

Patch by Benjamin Poulain <​bpoulain@apple.com> on 2015-11-11
Reviewed by Filip Pizlo.

I tweaked ReduceStrength a bit to maintain correctness.
Nothing fancy otherwise.

• b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::lower):

• b3/B3ReduceStrength.cpp:
• b3/B3Value.h:
• b3/B3ValueInlines.h:

(JSC::B3::Value::isInteger):

• b3/air/AirOpcode.opcodes:
• b3/testb3.cpp:

(JSC::B3::bitWiseEqual):
(JSC::B3::testAddArgDouble):
(JSC::B3::testAddArgsDouble):
(JSC::B3::testAddArgImmDouble):
(JSC::B3::testAddImmArgDouble):
(JSC::B3::testAddImmsDouble):
(JSC::B3::run):

8:08 PM Changeset in webkit [192346] by fpizlo@apple.com

• 11 edits in trunk/Source/JavaScriptCore

B3 should be able to compile a program with Switch
​https://bugs.webkit.org/show_bug.cgi?id=151115

Reviewed by Benjamin Poulain.

Adds lowering of Switch to a binary switch. This doesn't require any Air support.

• b3/B3BasicBlock.cpp:

(JSC::B3::BasicBlock::append):
(JSC::B3::BasicBlock::removeLast):
(JSC::B3::BasicBlock::replaceLast):

• b3/B3BasicBlock.h:
• b3/B3BlockInsertionSet.cpp:

(JSC::B3::BlockInsertionSet::insertBefore):
(JSC::B3::BlockInsertionSet::insertAfter):
(JSC::B3::BlockInsertionSet::splitForward):

• b3/B3BlockInsertionSet.h:
• b3/B3ControlValue.h:
• b3/B3Generate.cpp:

(JSC::B3::generateToAir):

• b3/B3LowerMacros.cpp:
• b3/B3SwitchValue.cpp:

(JSC::B3::SwitchValue::dumpMeta):
(JSC::B3::SwitchValue::SwitchValue):

• b3/B3SwitchValue.h:
• b3/testb3.cpp:

(JSC::B3::testChillDiv64):
(JSC::B3::testSwitch):
(JSC::B3::run):

7:39 PM Changeset in webkit [192345] by fpizlo@apple.com

• 6 edits in trunk/Source/JavaScriptCore

Patchpoints with stackArgument constraints should work
​https://bugs.webkit.org/show_bug.cgi?id=151177

Reviewed by Saam Barati.

The only thing broken was that StackmapSpecial's isValidForm would reject Arg::addr, so
validation would fail after allocateStack.

In order for StackmapSpecial to validate Arg::addr, it needs to know the frame size. To know
the frame size, it needs access to Code&. So, this changes Air::Special to always have a
pointer back to Code.

Other than this already worked.

• b3/B3StackmapSpecial.cpp:

(JSC::B3::StackmapSpecial::isValidImpl):

• b3/air/AirCode.cpp:

(JSC::B3::Air::Code::addSpecial):

• b3/air/AirSpecial.cpp:

(JSC::B3::Air::Special::Special):

• b3/air/AirSpecial.h:

(JSC::B3::Air::Special::code):

• b3/testb3.cpp:

(JSC::B3::testSimplePatchpoint):
(JSC::B3::testPatchpointCallArg):
(JSC::B3::testSimpleCheck):
(JSC::B3::run):

7:13 PM Changeset in webkit [192344] by BJ Burg

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: blank debugger tab when opening inspector on unvisited website
​https://bugs.webkit.org/show_bug.cgi?id=151149

Reviewed by Joseph Pecoraro.

When Inspector tries to show default content when initially showing a tab upon opening,
there may not be any tree elements added to the navigation bar yet. In the case of an
unvisited website, there will be no state restoration cookie to trigger deferred selection.
So, showDefaultContentView finds no tree elements it can show, and the main view is blank.

We can fix this by speculatively showing the first script/resource that's added to the tree
if no content view is being shown. If a state restoration cookie exists, it will take priority
over the default-displayed content view.

• UserInterface/Views/DebuggerSidebarPanel.js:

(WebInspector.DebuggerSidebarPanel.prototype._addResource):
(WebInspector.DebuggerSidebarPanel.prototype._addScript):

6:19 PM Changeset in webkit [192343] by andersca@apple.com

• 2 edits in trunk/Source/WebKit/mac

Get rid of -[WebMenuTarget validateMenuItem:]
​https://bugs.webkit.org/show_bug.cgi?id=151172

Reviewed by Beth Dakin.

We don't need the menu items to be validated since we handle enabling/disabling them ourselves (as well as setting their checked state).

• WebView/WebHTMLView.mm:

(-[WebMenuTarget validateMenuItem:]): Deleted.

5:48 PM Changeset in webkit [192342] by ggaren@apple.com

• 19 edits in trunk/Source

Rename handle.*Event to dispatch.*Event
​https://bugs.webkit.org/show_bug.cgi?id=151168

Reviewed by Chris Dumez.

Source/WebCore:

• dom/Document.cpp:

(WebCore::Document::implicitClose):

• dom/Document.h:
• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::getIconDataForIconURL):
(WebCore::DocumentLoader::dispatchOnloadEvents):
(WebCore::DocumentLoader::handledOnloadEvents): Deleted.

• loader/DocumentLoader.h:

(WebCore::DocumentLoader::isClientRedirect):
(WebCore::DocumentLoader::setIsClientRedirect):
(WebCore::DocumentLoader::wasOnloadDispatched):
(WebCore::DocumentLoader::overrideEncoding):
(WebCore::DocumentLoader::wasOnloadHandled): Deleted.

• loader/EmptyClients.h:
• loader/FrameLoader.cpp:

(WebCore::FrameLoader::submitForm):
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::userAgent):
(WebCore::FrameLoader::dispatchOnloadEvents):
(WebCore::FrameLoader::frameDetached):
(WebCore::FrameLoader::shouldClose):
(WebCore::FrameLoader::dispatchUnloadEvents):
(WebCore::FrameLoader::dispatchBeforeUnloadEvent):
(WebCore::FrameLoader::handledOnloadEvents): Deleted.
(WebCore::FrameLoader::handleUnloadEvents): Deleted.
(WebCore::FrameLoader::handleBeforeUnloadEvent): Deleted.

• loader/FrameLoader.h:
• loader/FrameLoaderClient.h:
• loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::mustLockBackForwardList):

Source/WebKit/mac:

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDidFailLoading):
(WebFrameLoaderClient::dispatchDidDispatchOnloadEvents):
(WebFrameLoaderClient::dispatchDidHandleOnloadEvents): Deleted.

Source/WebKit/win:

• WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::shouldCacheResponse):
(WebFrameLoaderClient::dispatchDidDispatchOnloadEvents):
(WebFrameLoaderClient::dispatchDidHandleOnloadEvents): Deleted.

• WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit2:

• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
(WebKit::WebFrameLoaderClient::dispatchDidDispatchOnloadEvents):
(WebKit::WebFrameLoaderClient::dispatchDidHandleOnloadEvents): Deleted.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

5:47 PM Changeset in webkit [192341] by andersca@apple.com

• 4 edits in trunk/Source/WebCore

Remove more dead code
​https://bugs.webkit.org/show_bug.cgi?id=151170

Reviewed by Beth Dakin.

• platform/ContextMenu.cpp:

(WebCore::findItemWithAction): Deleted.
(WebCore::ContextMenu::itemWithAction): Deleted.

• platform/ContextMenu.h:

(WebCore::ContextMenu::itemAtIndex): Deleted.

• platform/ContextMenuItem.h:

5:35 PM Changeset in webkit [192340] by andersca@apple.com

• 3 edits in trunk/Source/WebCore

De-indent ContextMenu.h and ContextMenuItem.h.

Rubber-stamped by Andreas Kling.

• platform/ContextMenu.h:
• platform/ContextMenuItem.h:

5:29 PM Changeset in webkit [192339] by andersca@apple.com

• 4 edits
  2 deletes in trunk/Source/WebCore

Remove ContextMenuWin.cpp and ContextMenuItemWin.cpp
​https://bugs.webkit.org/show_bug.cgi?id=150467

Reviewed by Beth Dakin.

These files are not needed anymore.

• PlatformWin.cmake:
• WebCore.vcxproj/WebCore.vcxproj:
• WebCore.vcxproj/WebCore.vcxproj.filters:
• platform/win/ContextMenuItemWin.cpp: Removed.

(WebCore::ContextMenuItem::ContextMenuItem): Deleted.
(WebCore::ContextMenuItem::platformContextMenuItem): Deleted.

• platform/win/ContextMenuWin.cpp: Removed.

(WebCore::ContextMenu::ContextMenu): Deleted.
(WebCore::ContextMenu::getContextMenuItems): Deleted.
(WebCore::ContextMenu::createPlatformContextMenuFromItems): Deleted.
(WebCore::ContextMenu::platformContextMenu): Deleted.

5:19 PM Changeset in webkit [192338] by andersca@apple.com

• 2 edits
  2 deletes in trunk/Source/WebCore

Get rid of ContextMenuNone.cpp and ContextMenuItemNone.cpp
​https://bugs.webkit.org/show_bug.cgi?id=151169

Reviewed by Beth Dakin.

• PlatformEfl.cmake:
• platform/ContextMenuItemNone.cpp: Removed.

(WebCore::ContextMenuItem::platformContextMenuItem): Deleted.

• platform/ContextMenuNone.cpp: Removed.

(WebCore::ContextMenu::ContextMenu): Deleted.
(WebCore::ContextMenu::getContextMenuItems): Deleted.
(WebCore::ContextMenu::createPlatformContextMenuFromItems): Deleted.
(WebCore::ContextMenu::platformContextMenu): Deleted.

5:11 PM Changeset in webkit [192337] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

Fix builds.

• WebProcess/WebCoreSupport/efl/WebContextMenuClientEfl.cpp:

(WebKit::WebContextMenuClient::shareMenuItem): Deleted.

• WebProcess/WebCoreSupport/gtk/WebContextMenuClientGtk.cpp:

(WebKit::WebContextMenuClient::shareMenuItem): Deleted.

5:02 PM Changeset in webkit [192336] by akiss@inf.u-szeged.hu

• 2 edits in trunk/Source/bmalloc

bmalloc: Add libdl dependency
​https://bugs.webkit.org/show_bug.cgi?id=151140

Reviewed by Csaba Osztrogonác.

Make sure that the linker links libdl and finds the references to
dlopen, dlsym and dlclose in Environment.cpp.

• CMakeLists.txt:

4:47 PM Changeset in webkit [192335] by andersca@apple.com

• 3 edits in trunk/Source/WebKit2

REGRESSION (r191407): Context menus are missing Services
​https://bugs.webkit.org/show_bug.cgi?id=151167
rdar://problem/23500769

Reviewed by Tim Horton.

• UIProcess/mac/WebContextMenuProxyMac.mm:

(WebKit::WebContextMenuProxyMac::showContextMenu):
Use contentsToRootView to better indicate which coordinate system we're using.

• WebProcess/WebPage/WebContextMenu.cpp:

(WebKit::WebContextMenu::show):
Use +[NSMenu popUpContextMenu:withEvent:forView:] so we'll get service menus where applicable.

4:41 PM Changeset in webkit [192334] by mark.lam@apple.com

• 7 edits in trunk/Source/JavaScriptCore

Add ability to insert probes in LLVM IR that we generate.
​https://bugs.webkit.org/show_bug.cgi?id=151159

Reviewed by Geoffrey Garen.

This is done by inserting a stackmap intrinsic and emitting the probe there.

We can now insert probes that take a lambda like so:

probe([] (CCallHelpers::ProbeContext*) {

dataLog("Hello FTL\n");

});

• ftl/FTLCompile.cpp:
• ftl/FTLInlineCacheDescriptor.h:

(JSC::FTL::ProbeDescriptor::ProbeDescriptor):
(JSC::FTL::ProbeDescriptor::probeFunction):

• ftl/FTLInlineCacheSize.cpp:

(JSC::FTL::sizeOfProbe):

• ftl/FTLInlineCacheSize.h:
• ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::probe):

• ftl/FTLState.h:

4:29 PM Changeset in webkit [192333] by andersca@apple.com

• 12 edits in trunk/Source

Remove more dead context menu code
​https://bugs.webkit.org/show_bug.cgi?id=151163

Reviewed by Tim Horton.

Source/WebCore:

• loader/EmptyClients.h:
• page/ContextMenuClient.h:
• page/ContextMenuController.cpp:

(WebCore::ContextMenuController::populate):

• platform/ContextMenuItem.h:
• platform/mac/ContextMenuItemMac.mm:

(WebCore::ContextMenuItem::shareMenuItem): Deleted.

Source/WebKit/mac:

• WebCoreSupport/WebContextMenuClient.h:
• WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::shareMenuItem): Deleted.

Source/WebKit2:

• WebProcess/WebCoreSupport/WebContextMenuClient.h:
• WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:

(WebKit::WebContextMenuClient::shareMenuItem): Deleted.

4:14 PM Changeset in webkit [192332] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebKit2

Remove an unnecessary zero-delay timer from swipe snapshot removal
​https://bugs.webkit.org/show_bug.cgi?id=151161

Reviewed by Anders Carlsson.

• WebProcess/WebPage/ViewGestureGeometryCollector.cpp:

(WebKit::ViewGestureGeometryCollector::mainFrameDidLayout):
(WebKit::ViewGestureGeometryCollector::ViewGestureGeometryCollector): Deleted.
(WebKit::ViewGestureGeometryCollector::renderTreeSizeNotificationTimerFired): Deleted.

• WebProcess/WebPage/ViewGestureGeometryCollector.h:

There's no discernable reason for this zero-delay timer, and it dates back
to the original swipe patch with no explanation given. My only theory
is that I was depending on spinning the runloop to ensure we've painted,
but we have other mechanisms to do that now, on both platforms.

This also was a surprising waste of time in some cases where the web
process was very slow.

3:45 PM Changeset in webkit [192331] by Chris Dumez

• 2 edits in trunk/Source/WebKit2

Unreviewed attempt to fix the Mac CMake build.

• CMakeLists.txt:

3:39 PM Changeset in webkit [192330] by Brent Fulgham

• 3 edits in trunk/Tools

[Win] webkitpy is applying abspath to DOS paths, yielding invalid paths
​https://bugs.webkit.org/show_bug.cgi?id=151156

Reviewed by Anders Carlsson.

• Scripts/webkitpy/port/base.py:

(Port.results_directory): Don't pass paths through 'abspath'
(Port._build_path): Ditto.

• Scripts/webkitpy/port/win.py:

(WinPort._build_path): Ditto.

3:04 PM Changeset in webkit [192329] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Change probe CPUState gpr() and fpr() to return references.
​https://bugs.webkit.org/show_bug.cgi?id=151154

Reviewed by Saam Barati.

This will allow us to set their values as well as reading them.

• assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::CPUState::gpr):
(JSC::AbstractMacroAssembler::CPUState::fpr):
(JSC::AbstractMacroAssembler::ProbeContext::gpr):
(JSC::AbstractMacroAssembler::ProbeContext::fpr):

3:01 PM Changeset in webkit [192328] by Chris Dumez

• 9 edits
  2 adds in trunk/Source/WebKit2

[WK2] Add initial support for speculative resource revalidation to the WebKit disk cache
​https://bugs.webkit.org/show_bug.cgi?id=150856
<rdar://problem/23092196>

Reviewed by Antti Koivisto.

Add initial support for speculative resource revalidation to the WebKit
disk cache. When a main resource is requested by WebCore, we look up its
list of subresources in the cache and speculatively warm them up before
WebCore asks for them, in order to improve page load time. In this
context, warming it up means:

1. If the cached resource is usable (has not expired), keep it around in a memory for a limited amount of time (10 seconds).
2. If the resource has expired, do a speculative revalidation of the resource and then keep it in memory for a while as well (10 seconds).

The feature is currently behind a compile-time flag that is only enabled
on COCOA. Also, it is currently disabled at run-time until it is mature
enough.

Initial results show that speculative revalidation gives a ~5%
progression on throttled warm PLT on iPhone 5s.

• NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::start):

• NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::Cache::retrieve):
(WebKit::NetworkCache::Cache::store):
(WebKit::NetworkCache::Cache::update):

• NetworkProcess/cache/NetworkCache.h:
• NetworkProcess/cache/NetworkCacheEntry.cpp:

(WebKit::NetworkCache::Entry::Entry):

• NetworkProcess/cache/NetworkCacheEntry.h:
• NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp: Added.

(WebKit::NetworkCache::SpeculativeLoad::SpeculativeLoad):
(WebKit::NetworkCache::SpeculativeLoad::~SpeculativeLoad):
(WebKit::NetworkCache::SpeculativeLoad::willSendRedirectedRequest):
(WebKit::NetworkCache::SpeculativeLoad::didReceiveBuffer):
(WebKit::NetworkCache::SpeculativeLoad::didFinishLoading):
(WebKit::NetworkCache::SpeculativeLoad::didFailLoading):
(WebKit::NetworkCache::SpeculativeLoad::didComplete):

• NetworkProcess/cache/NetworkCacheSpeculativeLoad.h: Added.
• NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:

(WebKit::NetworkCache::constructRevalidationRequest):
(WebKit::NetworkCache::responseNeedsRevalidation):
(WebKit::NetworkCache::SpeculativeLoadManager::PreloadedEntry::PreloadedEntry):
(WebKit::NetworkCache::SpeculativeLoadManager::PreloadedEntry::takeCacheEntry):
(WebKit::NetworkCache::SpeculativeLoadManager::PreloadedEntry::lifetimeTimerFired):
(WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::PendingFrameLoad):
(WebKit::NetworkCache::SpeculativeLoadManager::retrieve):
(WebKit::NetworkCache::SpeculativeLoadManager::registerLoad):
(WebKit::NetworkCache::SpeculativeLoadManager::addPreloadedEntry):
(WebKit::NetworkCache::SpeculativeLoadManager::retrieveEntryFromStorage):
(WebKit::NetworkCache::SpeculativeLoadManager::satisfyPendingRequests):
(WebKit::NetworkCache::SpeculativeLoadManager::revalidateEntry):
(WebKit::NetworkCache::SpeculativeLoadManager::preloadEntry):
(WebKit::NetworkCache::SpeculativeLoadManager::startSpeculativeRevalidation):
(WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::registerSubresource): Deleted.
(WebKit::NetworkCache::SpeculativeLoadManager::PendingFrameLoad::encodeAsSubresourcesRecord): Deleted.

• NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.h:
• WebKit2.xcodeproj/project.pbxproj:

2:57 PM Changeset in webkit [192327] by Matt Baker

• 8 edits in trunk/Source/WebInspectorUI

Web Inspector: Convert sidebars to use View base class
​https://bugs.webkit.org/show_bug.cgi?id=151057

Reviewed by Timothy Hatcher.

This patch makes Sidebar a subclass of View. Mostly mechanical changes and cleanup,
such as adding navigation bars and panels as subviews, removing element getters,
and replacing external properties with symbols.

• UserInterface/Base/Main.js:

Added sidebars to view hierarchy.

• UserInterface/Views/DebuggerSidebarPanel.js:

Add navigation bar as a subview.

• UserInterface/Views/NetworkSidebarPanel.js:

Add navigation bar as a subview.
(WebInspector.NetworkSidebarPanel):
(WebInspector.NetworkSidebarPanel.prototype.matchTreeElementAgainstCustomFilters.match):
(WebInspector.NetworkSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
(WebInspector.NetworkSidebarPanel.prototype.treeElementAddedOrChanged):
(WebInspector.NetworkSidebarPanel.prototype._treeElementGoToArrowWasClicked):
External properties replaced with symbols.

• UserInterface/Views/ResourceSidebarPanel.js:

Add navigation bar as a subview.
(WebInspector.ResourceSidebarPanel):
(WebInspector.ResourceSidebarPanel.prototype.matchTreeElementAgainstCustomFilters.match):
(WebInspector.ResourceSidebarPanel.prototype.matchTreeElementAgainstCustomFilters):
External properties replaced with symbols.

• UserInterface/Views/Sidebar.js:

(WebInspector.Sidebar):
(WebInspector.Sidebar.prototype.addSidebarPanel):
(WebInspector.Sidebar.prototype.removeSidebarPanel):
Panels are now added and removed as subviews.
(WebInspector.Sidebar.prototype.get width):
(WebInspector.Sidebar.prototype.set width):
(WebInspector.Sidebar.prototype.get collapsed):
(WebInspector.Sidebar.prototype.set collapsed):
"collapsed" property now backed by private class variable, not DOM state.
(WebInspector.Sidebar.prototype.get element): Deleted.

• UserInterface/Views/SidebarPanel.js:

(WebInspector.SidebarPanel):
(WebInspector.SidebarPanel.prototype.get visible):
(WebInspector.SidebarPanel.prototype.get selected):
(WebInspector.SidebarPanel.prototype.set selected):
"selected" property now backed by private class variable, not DOM state.
(WebInspector.SidebarPanel.prototype.get parentSidebar):
No longer stored as separate property. Wrapper around View.prototype.parentView.
Original getter retained for clarity.
(WebInspector.SidebarPanel.prototype.show):
(WebInspector.SidebarPanel.prototype.hide):
(WebInspector.SidebarPanel.prototype.added):
(WebInspector.SidebarPanel.prototype.removed):
(WebInspector.SidebarPanel.prototype.get element): Deleted.

• UserInterface/Views/StorageSidebarPanel.js:

(WebInspector.StorageSidebarPanel):
Add navigation bar as a subview.

2:31 PM Changeset in webkit [192326] by mark.lam@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Add convenience utility to support dataLogging opcodeIDs.
​https://bugs.webkit.org/show_bug.cgi?id=151117

Reviewed by Saam Barati.

• bytecode/Opcode.cpp:

(WTF::printInternal):

• bytecode/Opcode.h:

2:20 PM Changeset in webkit [192325] by bshafiei@apple.com

• 1 copy in tags/Safari-602.1.11

New tag.

2:19 PM Changeset in webkit [192324] by bshafiei@apple.com

• 5 edits in trunk/Source

Versioning.

2:02 PM Changeset in webkit [192323] by akiss@inf.u-szeged.hu

• 2 edits in trunk/Tools

Unreviewed, add myself to the committers list.

• Scripts/webkitpy/common/config/contributors.json:

1:47 PM Changeset in webkit [192322] by andersca@apple.com

• 3 edits in trunk/Source/WebKit/win

Handle custom menu items in WebKit instead of WebCore on Windows
​https://bugs.webkit.org/show_bug.cgi?id=151147

Reviewed by Tim Horton.

• WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::contextMenuItemSelected):

• WebView.cpp:

(WebView::onMenuCommand):

1:34 PM Changeset in webkit [192321] by keith_miller@apple.com

• 13 edits
  2 copies
  4 adds in trunk

Regression(r191815): 5.3% regression on Dromaeo JS Library Benchmark
​https://bugs.webkit.org/show_bug.cgi?id=150945

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This patch fixes a performance regression introduced by r191815. Before adding Symbol.toStringTag
we would cache the value of Object.prototype.toString() in the rareData of the structure.
In order to cache the result of Object.prototype.toString() we now need to ensure that the
value stored in Symbol.toStringTag is a known constant. Thus, in order to ensure the stored Symbol.toStringTag
value remains constant adaptive inferred value watchpoints have been re-factored to be generalizable and
a new version that clears the toString value cache when fired has been added.

• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/AdaptiveInferredPropertyValueWatchpointBase.cpp: Copied from Source/JavaScriptCore/dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp.

(JSC::AdaptiveInferredPropertyValueWatchpointBase::AdaptiveInferredPropertyValueWatchpointBase):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::install):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::fire):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::StructureWatchpoint::fireInternal):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::PropertyWatchpoint::fireInternal):

• bytecode/AdaptiveInferredPropertyValueWatchpointBase.h: Copied from Source/JavaScriptCore/dfg/DFGAdaptiveInferredPropertyValueWatchpoint.h.

(JSC::AdaptiveInferredPropertyValueWatchpointBase::key):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::StructureWatchpoint::StructureWatchpoint):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::PropertyWatchpoint::PropertyWatchpoint):

• dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp:

(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::AdaptiveInferredPropertyValueWatchpoint):
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::handleFire):
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::install): Deleted.
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::fire): Deleted.
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::StructureWatchpoint::fireInternal): Deleted.
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::PropertyWatchpoint::fireInternal): Deleted.

• dfg/DFGAdaptiveInferredPropertyValueWatchpoint.h:

(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::key): Deleted.
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::StructureWatchpoint::StructureWatchpoint): Deleted.
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::PropertyWatchpoint::PropertyWatchpoint): Deleted.

• runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString):

• runtime/Structure.h:
• runtime/StructureInlines.h:

(JSC::Structure::setObjectToStringValue):

• runtime/StructureRareData.cpp:

(JSC::StructureRareData::StructureRareData):
(JSC::StructureRareData::setObjectToStringValue):
(JSC::StructureRareData::clearObjectToStringValue):
(JSC::ObjectToStringAdaptiveStructureWatchpoint::ObjectToStringAdaptiveStructureWatchpoint):
(JSC::ObjectToStringAdaptiveStructureWatchpoint::install):
(JSC::ObjectToStringAdaptiveStructureWatchpoint::fireInternal):
(JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::ObjectToStringAdaptiveInferredPropertyValueWatchpoint):
(JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::handleFire):

• runtime/StructureRareData.h:
• runtime/StructureRareDataInlines.h:

(JSC::StructureRareData::setObjectToStringValue): Deleted.

• tests/stress/symbol-tostringtag-watchpoints.js: Added.

(Base):

• CMakeLists.txt:
• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/AdaptiveInferredPropertyValueWatchpointBase.cpp: Copied from Source/JavaScriptCore/dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp.

(JSC::AdaptiveInferredPropertyValueWatchpointBase::AdaptiveInferredPropertyValueWatchpointBase):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::install):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::fire):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::StructureWatchpoint::fireInternal):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::PropertyWatchpoint::fireInternal):

• bytecode/AdaptiveInferredPropertyValueWatchpointBase.h: Copied from Source/JavaScriptCore/dfg/DFGAdaptiveInferredPropertyValueWatchpoint.h.

(JSC::AdaptiveInferredPropertyValueWatchpointBase::key):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::StructureWatchpoint::StructureWatchpoint):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::PropertyWatchpoint::PropertyWatchpoint):

• dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp:

(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::AdaptiveInferredPropertyValueWatchpoint):
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::handleFire):
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::install): Deleted.
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::fire): Deleted.
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::StructureWatchpoint::fireInternal): Deleted.
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::PropertyWatchpoint::fireInternal): Deleted.

• dfg/DFGAdaptiveInferredPropertyValueWatchpoint.h:

(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::key): Deleted.
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::StructureWatchpoint::StructureWatchpoint): Deleted.
(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::PropertyWatchpoint::PropertyWatchpoint): Deleted.

• runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString):

• runtime/Structure.h:
• runtime/StructureInlines.h:

(JSC::Structure::setObjectToStringValue):

• runtime/StructureRareData.cpp:

(JSC::StructureRareData::StructureRareData):
(JSC::StructureRareData::setObjectToStringValue):
(JSC::StructureRareData::clearObjectToStringValue):
(JSC::ObjectToStringAdaptiveStructureWatchpoint::ObjectToStringAdaptiveStructureWatchpoint):
(JSC::ObjectToStringAdaptiveStructureWatchpoint::install):
(JSC::ObjectToStringAdaptiveStructureWatchpoint::fireInternal):
(JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::ObjectToStringAdaptiveInferredPropertyValueWatchpoint):
(JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::handleFire):

• runtime/StructureRareData.h:
• runtime/StructureRareDataInlines.h:

(JSC::StructureRareData::setObjectToStringValue): Deleted.

• tests/stress/symbol-tostringtag-watchpoints.js: Added.

(Base):

LayoutTests:

Added a preformance regression test that checks the speed of Symbol.toStringTag.
The change to cross-origin-replace-history-object-child-expected.txt is a
result of the toString value being cached.

• http/tests/history/cross-origin-replace-history-object-child-expected.txt:
• js/regress/script-tests/symbol-tostringtag.js: Added.

(buildChain):
(body):

• js/regress/symbol-tostringtag-expected.txt: Added.
• js/regress/symbol-tostringtag.html: Added.

12:35 PM Changeset in webkit [192320] by fpizlo@apple.com

• 19 edits in trunk/Source

B3 should be able to compile and canonicalize Mul
​https://bugs.webkit.org/show_bug.cgi?id=151124

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This was a strange trip. I wanted to do a quick patch to implement Mul. But then I realized
that our tradition when adding new lowerings was to also add the corresponding strength
reductions. So then I wrote the Mul->Shl strength reduction. But that reminded me that I needed
to canonicalize between Add(x, x) and Shl(x, 1). I decided that it would probably be better to
use Shl(x, 1), since that only has one use of x. But that means that we should compile
Shl(x, 1) to Add x, x in the backend, since that's what X86 wants. While doing that, I almost
introduced a bug where Shl(Load(x), 1) would cause the compiler to either crash or generate bad
code. That's because I was using Add(x, x) to handle Shl(x, 1), so we'd end up with
Add(Load(x), Load(x)) - i.e. we would try to duplicate the Load.

The instruction selector already defends against this, and the only reason why I would have
created the bug was by using the Add helper when compiling a Shl. Still, this was so close to
a bad bug that I added a ton of new tests that cover the Op(x, x) where x = Load case.

• b3/B3Compilation.cpp:

(JSC::B3::Compilation::Compilation):

• b3/B3Compilation.h:

(JSC::B3::Compilation::code):

• b3/B3Const32Value.cpp:

(JSC::B3::Const32Value::subConstant):
(JSC::B3::Const32Value::mulConstant):
(JSC::B3::Const32Value::bitAndConstant):

• b3/B3Const32Value.h:
• b3/B3Const64Value.cpp:

(JSC::B3::Const64Value::subConstant):
(JSC::B3::Const64Value::mulConstant):
(JSC::B3::Const64Value::bitAndConstant):

• b3/B3Const64Value.h:
• b3/B3ConstDoubleValue.cpp:

(JSC::B3::ConstDoubleValue::subConstant):
(JSC::B3::ConstDoubleValue::mulConstant):
(JSC::B3::ConstDoubleValue::equalConstant):

• b3/B3ConstDoubleValue.h:
• b3/B3Generate.cpp:

(JSC::B3::generate):
(JSC::B3::generateToAir):

• b3/B3Generate.h:
• b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::appendBinOp):
(JSC::B3::Air::LowerToAir::createGenericCompare):
(JSC::B3::Air::LowerToAir::lower):

• b3/B3ReduceStrength.cpp:
• b3/B3Value.cpp:

(JSC::B3::Value::subConstant):
(JSC::B3::Value::mulConstant):
(JSC::B3::Value::bitAndConstant):

• b3/B3Value.h:
• b3/air/AirOpcode.opcodes:
• b3/testb3.cpp:

(JSC::B3::compile):
(JSC::B3::testReturnConst64):
(JSC::B3::testAddArg):
(JSC::B3::testAddArgs):
(JSC::B3::testAddArgs32):
(JSC::B3::testAddLoadTwice):
(JSC::B3::testMulArg):
(JSC::B3::testMulArgs):
(JSC::B3::testMulArgImm):
(JSC::B3::testMulImmArg):
(JSC::B3::testMulArgs32):
(JSC::B3::testMulLoadTwice):
(JSC::B3::testSubArg):
(JSC::B3::testSubArgs):
(JSC::B3::testShlArgImm):
(JSC::B3::testShlArg32):
(JSC::B3::testShlArgs32):
(JSC::B3::testSShrArgImm):
(JSC::B3::testSShrArg32):
(JSC::B3::testSShrArgs32):
(JSC::B3::testZShrArgImm):
(JSC::B3::testZShrArg32):
(JSC::B3::testZShrArgs32):
(JSC::B3::genericTestCompare):
(JSC::B3::testCompareLoad):
(JSC::B3::testCompareImpl):
(JSC::B3::run):

Source/WTF:

• wtf/MathExtras.h:

(WTF::fastLog2):

11:50 AM Changeset in webkit [192319] by andersca@apple.com

• 7 edits in trunk

_WKRemoteObjectInterface should handle specifying allowed classes for reply block arguments
​https://bugs.webkit.org/show_bug.cgi?id=151144

Reviewed by Tim Horton.

Source/WebKit2:

• Shared/API/Cocoa/_WKRemoteObjectInterface.h:
• Shared/API/Cocoa/_WKRemoteObjectInterface.mm:

(classesForSelectorArgument):
(-[_WKRemoteObjectInterface classesForSelector:argumentIndex:ofReply:]):
(-[_WKRemoteObjectInterface setClasses:forSelector:argumentIndex:ofReply:]):
(-[_WKRemoteObjectInterface classesForSelector:argumentIndex:]):
(-[_WKRemoteObjectInterface setClasses:forSelector:argumentIndex:]):

Tools:

• TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.h:

(remoteObjectInterface):

• TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistry.mm:

(TEST):

• TestWebKitAPI/Tests/WebKit2Cocoa/RemoteObjectRegistryPlugIn.mm:

(-[RemoteObjectRegistryPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
(-[RemoteObjectRegistryPlugIn selectionAndClickInformationForClickAtPoint:completionHandler:]):

11:25 AM Changeset in webkit [192318] by Yusuke Suzuki

• 2 edits in trunk/Source/JavaScriptCore

Update ES6 Generators' status to "In Development"
​https://bugs.webkit.org/show_bug.cgi?id=151142

Reviewed by Saam Barati.

Currently, features.json raises some linting errors.
This should be cleaned up in another patch.

• features.json:

11:02 AM Changeset in webkit [192317] by jhoneycutt@apple.com

• 3 edits in trunk/LayoutTests

Fix a typo.

Rubber-stamped by Dan Bernstein.

• fast/parser/strip-script-attrs-on-input-expected.txt:
• fast/parser/strip-script-attrs-on-input.html:

10:57 AM DisplayLists edited by Simon Fraser

(diff)

10:56 AM DisplayLists edited by Simon Fraser

(diff)

10:52 AM DisplayLists edited by Simon Fraser

(diff)

10:51 AM DisplayLists created by Simon Fraser

10:50 AM November 2015 Meeting edited by Simon Fraser

(diff)

10:48 AM Changeset in webkit [192316] by jhoneycutt@apple.com

• 3 edits
  2 adds in trunk

Crash loading Blink layout test fast/parser/strip-script-attrs-on-input.html
​https://bugs.webkit.org/show_bug.cgi?id=150201
<rdar://problem/23136478>

Reviewed by Brent Fulgham.

Source/WebCore:

Test: fast/parser/strip-script-attrs-on-input.html

• html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::processStartTagForInBody):
Get the attribute after calling
HTMLConstructionSite::insertSelfClosingHTMLElement(), as this may
mutate the token's attributes.

LayoutTests:

• fast/parser/strip-script-attrs-on-input-expected.txt: Added.
• fast/parser/strip-script-attrs-on-input.html: Added.

10:31 AM November 2015 Meeting edited by Joseph Pecoraro

(diff)

10:31 AM November 2015 Meeting edited by Joseph Pecoraro

Add schedule link (diff)

10:28 AM November 2015 Meeting edited by Simon Fraser

(diff)

10:25 AM NextStepsForColor edited by Simon Fraser

(diff)

10:20 AM Changeset in webkit [192315] by andersca@apple.com

• 3 edits in trunk/Source/WebKit/win

Use Win32 functions to get context menu item info
​https://bugs.webkit.org/show_bug.cgi?id=151123

Reviewed by Tim Horton.

• WebView.cpp:

(WebView::handleContextMenuEvent):
Destroy the menu if it already exists. Before creating the menu, make sure to set its style
to MNS_NOTIFYBYPOS, so we'll be able to know which item was selected (instead of just the action ID).

(WebView::onMenuCommand):
Get the selected menu item's ID and title. Create a fake ContextMenuItem and pass it back to WebCore. In the future,
we'll be able to pass just the action and title.

(WebView::WebViewWndProc):
There's no need to listen for WM_COMMAND. Just always listen for WM_MENUCOMMAND. Rename performContextMenuAction to onMenuCommand.

• WebView.h:

Add new member.

10:19 AM NextStepsForColor edited by Simon Fraser

(diff)

10:17 AM NextStepsForColor edited by Simon Fraser

(diff)

10:16 AM NextStepsForColor created by Simon Fraser

10:15 AM Changeset in webkit [192314] by Wenson Hsieh

• 11 edits in trunk

UI-side scripts in WebKitTestRunner should wait until event handling completes before finishing
​https://bugs.webkit.org/show_bug.cgi?id=151101
<rdar://problem/23428601>

Reviewed by Simon Fraser.

Tools:

WebKitTestRunner may still crash in the scenario where a marker event is dequeued and handled
after uiScriptComplete has been called. This patch teaches the UI script execution context to
defer script completion until all non-persistent tasks (currently tap, double tap and hardware
keyboard) have been handled, so marker events will no longer bleed through tests.

We accomplish this by changing the behavior of uiScriptComplete. When calling uiScriptComplete,
we store that a request to complete the UI-side script for the current parent callback has been
made. Subsequently, when a callback (either persistent or non-persistent) finishes invoking and
a request has been made to complete the UI script (this request may have been made when running
a previous callback) we check if all the non-persistent callbacks that have the same parent
callback as the current one have finished. If so, we complete the callback immediately;
otherwise, we wait until the in-flight non-persistent callbacks finish execution to complete the
UI script.

This patch also refactors some logic in UIScriptContext. It introduces a new convention for
assigning IDs to callbacks: IDs 1000 and above are treated as non-persistent callbacks, whereas
IDs between 0 and 999 are persistent task callbacks. This is similar to the existing convention
for assigning IDs in the 100s range to parent callbacks, and allows us to easily differentiate
between callbacks that are persistent and non-persistent, as well as determine when an existing
persistent callback must be unregistered before a new callback function can be set.

• WebKitTestRunner/UIScriptContext/UIScriptContext.cpp:

(isPersistentCallbackID):
(UIScriptContext::runUIScript):
(UIScriptContext::nextTaskCallbackID):
(UIScriptContext::prepareForAsyncTask):
(UIScriptContext::asyncTaskComplete):
(UIScriptContext::registerCallback):
(UIScriptContext::fireCallback):
(UIScriptContext::requestUIScriptCompletion):
(UIScriptContext::tryToCompleteUIScriptForCurrentParentCallback):
(UIScriptContext::currentParentCallbackHasOutstandingAsyncTasks):
(UIScriptContext::uiScriptComplete): Deleted.

• WebKitTestRunner/UIScriptContext/UIScriptContext.h:

(WTR::UIScriptContext::currentParentCallbackIsPendingCompletion):

• WebKitTestRunner/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::setWillBeginZoomingCallback):
(WTR::UIScriptController::willBeginZoomingCallback):
(WTR::UIScriptController::setDidEndZoomingCallback):
(WTR::UIScriptController::didEndZoomingCallback):
(WTR::UIScriptController::setDidShowKeyboardCallback):
(WTR::UIScriptController::didShowKeyboardCallback):
(WTR::UIScriptController::setDidHideKeyboardCallback):
(WTR::UIScriptController::didHideKeyboardCallback):
(WTR::UIScriptController::uiScriptComplete):

• WebKitTestRunner/UIScriptContext/UIScriptController.h:
• WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::doAsyncTask):
(WTR::UIScriptController::zoomToScale):
(WTR::UIScriptController::singleTapAtPoint):
(WTR::UIScriptController::doubleTapAtPoint):
(WTR::UIScriptController::typeCharacterUsingHardwareKeyboard):
(WTR::UIScriptController::platformSetWillBeginZoomingCallback):
(WTR::UIScriptController::platformSetDidEndZoomingCallback):
(WTR::UIScriptController::platformSetDidShowKeyboardCallback):
(WTR::UIScriptController::platformSetDidHideKeyboardCallback):
(WTR::UIScriptController::platformClearAllCallbacks): Deleted.

• WebKitTestRunner/mac/UIScriptControllerMac.mm:

(WTR::UIScriptController::doAsyncTask):

LayoutTests:

Ensures that all tests using UIScriptController properly complete the UI script from within
a completion callback.

• fast/events/ios/clicking-document-should-not-trigger-focus.html:
• fast/events/ios/input-value-after-oninput.html:
• fast/events/ios/single-tap-generates-click.html:

10:12 AM Changeset in webkit [192313] by timothy_horton@apple.com

• 3 edits in trunk/Source/WebKit2

Add some font-related preferences to the modern API
​https://bugs.webkit.org/show_bug.cgi?id=151138
<rdar://problem/23492636>

Reviewed by Anders Carlsson.

• UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _defaultFontSize]):
(-[WKPreferences _setDefaultFontSize:]):
(-[WKPreferences _defaultFixedPitchFontSize]):
(-[WKPreferences _setDefaultFixedPitchFontSize:]):
(-[WKPreferences _fixedPitchFontFamily]):
(-[WKPreferences _setFixedPitchFontFamily:]):

• UIProcess/API/Cocoa/WKPreferencesPrivate.h:

10:03 AM Changeset in webkit [192312] by commit-queue@webkit.org

• 2 edits in trunk

[GTK][Mac] don't install .frameworks
​https://bugs.webkit.org/show_bug.cgi?id=151136

Patch by Philippe Normand <​pnormand@igalia.com> on 2015-11-11
Reviewed by Alex Christensen.

• Source/cmake/WebKitMacros.cmake: Don't install framework files when building the GTK port on Mac.

8:36 AM Changeset in webkit [192311] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

[GTK] Runtime critical warnings when closing a page containing windowed plugins
​https://bugs.webkit.org/show_bug.cgi?id=151132

Reviewed by Martin Robinson.

This is because our plugin widget, that is a GtkPlug (derived from
GtkWindow), can receive the delete-event signal before
NetscapePlugin::platformDestroy is called. The delete-event
signal, by default, destroys the window when the signal is not
handled. So, after the delete-event the GtkPlug is destroyed, but
our pointer hasn't been reset. We can handle the delete-event
using gtk_widget_hide_on_delete as callback, so that the plugin
widget is hidden instead of destroyed.

• WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePlugin::platformPostInitializeWindowed):

8:19 AM Changeset in webkit [192310] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit2

REGRESSION(r191856): [GTK] SOCK_SEQPACKET no longer used after r191856
​https://bugs.webkit.org/show_bug.cgi?id=151129

Reviewed by Martin Robinson.

r191856 unconditionally disabled SOCK_SEQPACKET for GTK port.

• Platform/IPC/unix/ConnectionUnix.cpp: Use always SOCK_SEQPACKET

when available.

5:25 AM Changeset in webkit [192309] by calvaris@igalia.com

• 2 edits in trunk/Source/WebCore

[Streams API] Remove bind usage
​https://bugs.webkit.org/show_bug.cgi?id=151104

Reviewed by Youenn Fablet.

Instead of using bind, an inline error function was created.

Internal rework, no tests needed.

• Modules/streams/WritableStream.js:

(error):
(initializeWritableStream):

2:17 AM Changeset in webkit [192308] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.10.4

WebKitGTK+ 2.10.4

2:16 AM Changeset in webkit [192307] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.10

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.10.4 release.

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

• gtk/NEWS: Add release notes for 2.10.4

2:16 AM Changeset in webkit [192306] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Unreviewed. Fix the build after Merge r192169.

• rendering/RenderCombineText.cpp:

1:40 AM WebKitGTK/2.10.x edited by Carlos Garcia Campos

(diff)

1:16 AM Changeset in webkit [192305] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.10

Merge r192175 - XHR timeouts should not fire if there is an immediate network error.
​https://bugs.webkit.org/show_bug.cgi?id=150577

Patch by Alex Christensen <​achristensen@webkit.org> on 2015-11-09
Reviewed by Darin Adler.

Source/WebCore:

This fixes flakiness of http/tests/contentextensions/async-xhr-onerror.html since r191077.

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::createRequest):
(WebCore::XMLHttpRequest::internalAbort):
(WebCore::XMLHttpRequest::didFinishLoading):
If the timeout timer has been started and we are going to immediately report a network error, then stop the timeout timer.
The timeout timer sometimes fired before the network error timer if it was a very short timeout (such as 1ms).
Also checks to isActive before calling stop on a timer are not necessary.

LayoutTests:

• platform/mac-wk2/TestExpectations:

http/tests/contentextensions/async-xhr-onerror.html shouldn't be flaky any more.

1:11 AM Changeset in webkit [192304] by Carlos Garcia Campos

• 4 edits
  3 adds in releases/WebKitGTK/webkit-2.10

Merge r191077 - [Content Extensions] Make blocked async XHR call onerror
​https://bugs.webkit.org/show_bug.cgi?id=146706

Patch by Alex Christensen <​achristensen@webkit.org> on 2015-10-14
Reviewed by Brady Eidson.

Source/WebCore:

Test: http/tests/contentextensions/async-xhr-onerror.html

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::createRequest):
(WebCore::XMLHttpRequest::networkError):
(WebCore::XMLHttpRequest::networkErrorTimerFired):
(WebCore::XMLHttpRequest::abortError):

• xml/XMLHttpRequest.h:

Make a timer that calls networkError in 0 time if a content blocker blocks the asynchronous load.
It is necessary to call setPendingActivity and dropProtection (which calls unsetPendingActivity)
to keep a reference to the XMLHttpRequest alive.

LayoutTests:

• http/tests/contentextensions/async-xhr-onerror-expected.txt: Added.
• http/tests/contentextensions/async-xhr-onerror.html: Added.
• http/tests/contentextensions/async-xhr-onerror.html.json: Added.

1:04 AM Changeset in webkit [192303] by Carlos Garcia Campos

• 4 edits
  2 adds in releases/WebKitGTK/webkit-2.10

Merge r189557 - ASSERTION FAILED: typesettingFeatures & (Kerning | Ligatures) in WebCore::applyFontTransforms
​https://bugs.webkit.org/show_bug.cgi?id=146194

Reviewed by Dean Jackson.

Source/WebCore:

We might trigger shaping even if the author hasn't specified kerning or ligatures.

Test: fast/text/softbank-emoji-no-ligatures-nor-kerning.html

• platform/graphics/WidthIterator.cpp:

(WebCore::isSoftBankEmoji):
(WebCore::WidthIterator::applyFontTransforms):
(WebCore::WidthIterator::advanceInternal):
(WebCore::applyFontTransforms): Deleted.

• platform/graphics/WidthIterator.h:

LayoutTests:

• fast/text/softbank-emoji-no-ligatures-nor-kerning-expected.html: Added
• fast/text/softbank-emoji-no-ligatures-nor-kerning.html: Added

12:56 AM Changeset in webkit [192302] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebKit2

Merge r192248 - [UNIX] Environment variable should take precedence over directories in plugin search path
​https://bugs.webkit.org/show_bug.cgi?id=151096

Reviewed by Martin Robinson.

Otherwise you can't override the directories using the env vars
for plugins already installed.

• Shared/Plugins/unix/PluginSearchPath.cpp:

(WebKit::pluginsDirectories):

12:54 AM Changeset in webkit [192301] by Carlos Garcia Campos

• 4 edits
  2 adds in releases/WebKitGTK/webkit-2.10

Merge r192191 - Crash when right clicking in input box with -webkit-user-select: none
​https://bugs.webkit.org/show_bug.cgi?id=145981
<rdar://problem/22441925>

Reviewed by Enrica Casucci.

Source/WebCore:

Test: editing/selection/minimal-user-select-crash.html

• editing/Editor.cpp:

(WebCore::Editor::hasBidiSelection):
Visible position cannot be created because of the style that doesn't allow the selection.

LayoutTests:

• editing/selection/minimal-user-select-crash-expected.txt: Added.
• editing/selection/minimal-user-select-crash.html: Added.

12:52 AM Changeset in webkit [192300] by Carlos Garcia Campos

• 7 edits
  2 adds in releases/WebKitGTK/webkit-2.10

Merge r192170 - Null dereference loading Blink layout test editing/inserting/insert-html-crash-01.html
​https://bugs.webkit.org/show_bug.cgi?id=149298
<rdar://problem/22746918>

Reviewed by Ryosuke Niwa.

Source/WebCore:

The test crashes in the method WebCore::CompositeEditCommand::moveParagraphs() because
the other method WebCore::CompositeEditCommand::cleanupAfterDeletion() accidentally
deletes the destination node. In WebCore::CompositeEditCommand::cleanupAfterDeletion(),
it fails to determine that caretAfterDelete equals to destination as Position::operator==,
which is called in VisiblePosition::operator==, only checks the equality of tuple
<Anchor Node, Anchor Type, Offset>. It is insufficient as a single position can be
represented by multiple tuples. Therefore, this change adds Position::equals() to fortify
the equal checking of two positions by considering combinations of different tuple
representations.

Furthermore, it adds VisiblePosition::equals() which considers affinity and call
Position::equals() while comparing two visible positions.

Test: editing/inserting/insert-html-crash-01.html

• dom/Position.cpp:

(WebCore::Position::equals):

• dom/Position.h:
• editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::cleanupAfterDeletion):
Replace operator== with VisiblePosition::equals() to tackle the test case.

• editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::equals):

• editing/VisiblePosition.h:

LayoutTests:

This test case is from Blink r153982:
​https://codereview.chromium.org/16053005

• editing/inserting/insert-html-crash-01-expected.txt: Added.
• editing/inserting/insert-html-crash-01.html: Added.

12:45 AM Changeset in webkit [192299] by Carlos Garcia Campos

• 3 edits
  2 adds in releases/WebKitGTK/webkit-2.10

Merge r192169 - Some style changes cause tatechuyoko to be drawn off center
​https://bugs.webkit.org/show_bug.cgi?id=150986
<rdar://problem/20748013>

Reviewed by Darin Adler.

Source/WebCore:

Layouts should be idempotent. In particular, during layout, an element should not
rely on a previous call to styleDidChange() with a sufficiently high StyleDifference.
RenderCombineText was assuming that, if a layout occurs, a previous call to
styleDidChange() would have reset the renderedText. However, an ancestor element might
cause the RenderCombineText to re-combine when it is already combined. Therefore, the
recombination should fully uncombine before recombining.

Test: fast/text/text-combine-style-change-extra-layout.html

• rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::combineText): Fully uncombine before recombining.

LayoutTests:

• fast/text/text-combine-style-change-extra-layout-expected.html: Added.
• fast/text/text-combine-style-change-extra-layout.html: Added.

12:39 AM Changeset in webkit [192298] by Carlos Garcia Campos

• 7 edits
  2 adds in releases/WebKitGTK/webkit-2.10

Merge r192133 - Crash when subtree layout is set on FrameView while auto size mode is enabled.
​https://bugs.webkit.org/show_bug.cgi?id=150995
rdar://problem/22785262

Reviewed by Beth Dakin.

Autosizing initiates multiple synchronous layouts to calculate preferred view width for current content.
FrameView::autoSizeIfEnabled() is called from FrameView::layout() while we are in InPreLayout state.
It is safe to do during full layout.
However, since we setup the subtree state just before the autoSizeIfEnabled() call, reentering it with
a newly issued layout confuses SubtreeLayoutStateMaintainer.

This patch reverses the order of autoSizeIfEnabled() call and the subtree layout state setup.
It also ensures that the first layout requested by autoSizeIfEnabled() always runs on the whole tree.

Source/WebCore:

Test: fast/dynamic/crash-subtree-layout-when-auto-size-enabled.html

• page/FrameView.cpp:

(WebCore::FrameView::layout):
(WebCore::FrameView::convertSubtreeLayoutToFullLayout):
(WebCore::FrameView::scheduleRelayout):
(WebCore::FrameView::scheduleRelayoutOfSubtree):
(WebCore::FrameView::autoSizeIfEnabled):

• page/FrameView.h:
• testing/Internals.cpp:

(WebCore::Internals::enableAutoSizeMode):

• testing/Internals.h:
• testing/Internals.idl:

LayoutTests:

• fast/dynamic/crash-subtree-layout-when-auto-size-enabled-expected.txt: Added.
• fast/dynamic/crash-subtree-layout-when-auto-size-enabled.html: Added.

12:26 AM Changeset in webkit [192297] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.10/Source/WebCore

Merge r192130 - Node.h:392:12: warning: 'this' pointer cannot be null in well-defined C++ code
​https://bugs.webkit.org/show_bug.cgi?id=150996

Reviewed by Andreas Kling.

Remove ASSERT(this) statement that is triggering hundreds of warnings from Clang.

• dom/Node.h:

(WebCore::Node::document):

12:10 AM Changeset in webkit [192296] by Carlos Garcia Campos

• 3 edits
  2 adds in releases/WebKitGTK/webkit-2.10

Merge r192120 - REGRESSION(r182286): Tatechuyoko following ruby is drawn too far to the right
​https://bugs.webkit.org/show_bug.cgi?id=150923

Reviewed by Zalan Bujtas.

Source/WebCore:

Ever since r182286, expansion opportunities in justified ruby were moved to their neighboring
elements (thereby forbidding trailing nor leading expansions inside ruby). However, when the
neighboring element is tatechuyoko, we will erroneously honor the expansion opportunity inside
the tatechuyoko, thereby moving it horizontally.

Tatechuyoko should never have expansion opportunities inside it.

Test: fast/text/ruby-justify-tatechuyoko.html

• rendering/RenderBlockLineLayout.cpp:

(WebCore::expansionBehaviorForInlineTextBox):

LayoutTests:

• fast/text/ruby-justify-tatechuyoko-expected.html: Added.
• fast/text/ruby-justify-tatechuyoko.html: Added.