Timeline



Feb 3, 2016:

11:37 PM Changeset in webkit [196111] by Carlos Garcia Campos
  • 1 edit in trunk/Tools/ChangeLog

Fix a typo in Tools/ChangeLog

11:34 PM Changeset in webkit [196110] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[WTR] Crash in EventSendingController::contextClick() when context menu event is not handled
https://bugs.webkit.org/show_bug.cgi?id=153835

Reviewed by Martin Robinson.

WKBundlePageCopyContextMenuAtPointInWindow() returns nullptr when
the context menu event is not hanlded, but we are using the
returned value without null checking it.

  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::EventSendingController::contextClick):

10:07 PM Changeset in webkit [196109] by jmarcell@apple.com
  • 3 edits in trunk/Tools

Format revisions for display according to repository type https://bugs.webkit.org/show_bug.cgi?id=153818

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:

(BuildbotQueueView.prototype._popoverLinesForCommitRange): Use new _formatRevisionForDisplay to display revisions according
to repository type.
(BuildbotQueueView.prototype._revisionContentWithPopoverForIteration): Ditto.
(BuildbotQueueView.prototype._formatRevisionForDisplay): Formats revisions for display according to repository type.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit tests to test new

_formatRevisionForDisplay function.

9:41 PM Changeset in webkit [196108] by Yusuke Suzuki
  • 7 edits in trunk/Source/JavaScriptCore

[JSC] Make some classes non JSDestructibleObject
https://bugs.webkit.org/show_bug.cgi?id=153838

Reviewed by Geoffrey Garen.

SymbolPrototype, JSMapIterator and JSSetIterator are trivially destructible.
So there is no need to inherit JSDestructibleObject.

  • runtime/JSMapIterator.cpp:

(JSC::JSMapIterator::destroy): Deleted.

  • runtime/JSMapIterator.h:
  • runtime/JSSetIterator.cpp:

(JSC::JSSetIterator::destroy): Deleted.

  • runtime/JSSetIterator.h:
  • runtime/MapData.h:
  • runtime/SymbolPrototype.h:
9:38 PM Changeset in webkit [196107] by Yusuke Suzuki
  • 2 edits
    1 add in trunk/Source/JavaScriptCore

[JSC] Symbol structure has unnecessary flags
https://bugs.webkit.org/show_bug.cgi?id=153840

Reviewed by Saam Barati.

  • runtime/Symbol.h:
  • tests/stress/symbol-get-own-property.js: Added.

(shouldBe):

9:16 PM Changeset in webkit [196106] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

Logs/CoreSimulator filling up OS disk on WebKit testers
https://bugs.webkit.org/show_bug.cgi?id=153853
<rdar://problem/24496003>

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.clean_up_test_run): Delete Logs during cleanup.

7:36 PM Changeset in webkit [196105] by Beth Dakin
  • 1 edit
    2 adds in trunk/LayoutTests

Accepted candidates should not be autocorrected
https://bugs.webkit.org/show_bug.cgi?id=153813
-and corresponding-
rdar://problem/24066924

Reviewed by Darin Adler.

  • editing/mac/spelling/accept-misspelled-candidate-expected.txt: Added.
  • editing/mac/spelling/accept-misspelled-candidate.html: Added.
7:12 PM Changeset in webkit [196104] by akling@apple.com
  • 7 edits in trunk/Source

[iOS] Throw away linked code when navigating to a new page.
<https://webkit.org/b/153851>

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Add a VM API for throwing away linked code only.

  • runtime/VM.cpp:

(JSC::VM::deleteAllLinkedCode):

  • runtime/VM.h:

Source/WebCore:

When navigating to a new page, tell JSC to throw out any linked code it has lying around.
Linked code is tied to a specific global object, and as we're creating a new one for the
new page, none of it is useful to us here.
In the event that the user navigates back, the cost of relinking some code will be far
lower than the memory cost of keeping all of it around.

  • bindings/js/GCController.cpp:

(WebCore::GCController::deleteAllLinkedCode):

  • bindings/js/GCController.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):

5:48 PM Changeset in webkit [196103] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking http/tests/history/back-to-post.php as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153314

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
5:41 PM Changeset in webkit [196102] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip imported/w3c/web-platform-tests/html/semantics/forms/the-select-element/select-ask-for-reset.html on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153850

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
5:39 PM Changeset in webkit [196101] by achristensen@apple.com
  • 7 edits in trunk/Source

Report wasBlocked and cannotShowURL errors when using NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=153846

Reviewed by Antti Koivisto.

Source/WebCore:

No new tests, but this fixes http/tests/xmlhttprequest/redirect-cross-origin-2.html
when using NetworkSession.

  • platform/URL.h:

WEBCORE_EXPORT because we are using portAllowed in WebKit2 now.

Source/WebKit2:

  • NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::NetworkLoad):
(WebKit::NetworkLoad::didSendData):
(WebKit::NetworkLoad::wasBlocked):
(WebKit::NetworkLoad::cannotShowURL):
(WebKit::NetworkLoad::didReceiveResponseAsync):

  • NetworkProcess/NetworkLoad.h:

NetworkDataTask is now RefCounted so we can protect it when reporting errors which delete the NetworkLoad.

  • NetworkProcess/NetworkSession.h:

(WebKit::NetworkSessionTaskClient::~NetworkSessionTaskClient):
(WebKit::NetworkDataTask::create):

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSession::takeDownloadID):
(WebKit::NetworkDataTask::NetworkDataTask):
Check the validity of the requested url and check if the port is allowed like we do in the ResourceHandle constructor.
(WebKit::NetworkDataTask::~NetworkDataTask):
Don't remove the task from the NetworkSession's map if we didn't make it because there was an error.
(WebKit::NetworkDataTask::scheduleFailure):
(WebKit::NetworkDataTask::failureTimerFired):
Implemented like ResourceHandle's.
(WebKit::NetworkDataTask::tryPasswordBasedAuthentication):
(WebKit::NetworkDataTask::resume):
(WebKit::NetworkDataTask::suspend):
Handle the failure timer like we do in ResourceHandle::setDefersLoading.

5:33 PM Changeset in webkit [196100] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking displaylists tests as flaky on ios-simulator. Previous attempt was unsuccessful.
https://bugs.webkit.org/show_bug.cgi?id=153656

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
4:57 PM Changeset in webkit [196099] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking transitions/clip-path-transitions.html and transitions/clip-path-path-transitions.html as flaky on Mac
https://bugs.webkit.org/show_bug.cgi?id=153809

Unreviewed test gardening.

  • platform/mac/TestExpectations:
4:56 PM Changeset in webkit [196098] by commit-queue@webkit.org
  • 5 edits
    2 adds in trunk

Web Inspector: JS PrettyPrinting unary - and + issues
https://bugs.webkit.org/show_bug.cgi?id=134007
<rdar://problem/17351953>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-03
Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

  • UserInterface/Views/CodeMirrorFormatters.js:

(shouldHaveSpaceBeforeToken):
(shouldHaveSpaceAfterLastToken):
(removeLastNewline):
(modifyStateForTokenPre):
(modifyStateForTokenPost):

LayoutTests:

  • inspector/codemirror/prettyprinting-javascript-expected.txt:
  • inspector/codemirror/prettyprinting-javascript.html:
  • inspector/codemirror/resources/prettyprinting/javascript-tests/unary-binary-operators-expected.js: Added.
  • inspector/codemirror/resources/prettyprinting/javascript-tests/unary-binary-operators.js: Added.

New tests for unary and some binary operators in JavaScript pretty printing.

4:35 PM Changeset in webkit [196097] by BJ Burg
  • 3 edits in trunk/Tools

git-add-reviewer should work when run from a subdirectory within the repository
https://bugs.webkit.org/show_bug.cgi?id=153842

Reviewed by David Kilzer.

There are two problems that needed to be fixed:

  • We can't assume .git is in $PWD/.git
  • We can't specify absolute paths to git commit

Fix these problems using the helpers in VCSUtils that were added to
fix this same issue for prepare-changeCogs.

  • Scripts/VCSUtils.pm: Export gitDirectory()
  • Scripts/git-add-reviewer:

(nonInteractive): Cache gitDirectory() result.
(addReviewer):
(commit):
(changeLogsForCommit): Make paths relative.

4:27 PM Changeset in webkit [196096] by matthew_hanson@apple.com
  • 14 edits
    2 adds in branches/safari-601-branch

Merge r196010. rdar://problem/24417428

4:26 PM Changeset in webkit [196095] by matthew_hanson@apple.com
  • 4 edits
    4 adds in branches/safari-601-branch

Merge r195912. rdar://problem/24417428

4:26 PM Changeset in webkit [196094] by matthew_hanson@apple.com
  • 4 edits
    2 adds in branches/safari-601-branch

Merge r192570. rdar://problem/24417428

4:16 PM Changeset in webkit [196093] by jer.noble@apple.com
  • 2 edits in trunk/Tools

Yet another Yosemite build fix.

  • TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
4:05 PM Changeset in webkit [196092] by jer.noble@apple.com
  • 5 edits in trunk

iOS build fix after Yosemite build fix broke iOS build.

Source/WebCore:

  • platform/network/cocoa/WebCoreNSURLSession.h:
  • platform/network/cocoa/WebCoreNSURLSession.mm:

Tools:

  • TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
4:04 PM Changeset in webkit [196091] by Chris Dumez
  • 25 edits
    5 copies
    56 adds in trunk/LayoutTests

Re-sync W3C HTML web-platform-tests
https://bugs.webkit.org/show_bug.cgi?id=153832

Reviewed by Sam Weinig.

Re-sync W3C HTML web-platform-tests from:
https://github.com/w3c/web-platform-tests/tree/master/html

  • web-platform-tests/html/dom/dynamic-markup-insertion/document-writeln/document.writeln-03-expected.txt: Added.
  • web-platform-tests/html/dom/dynamic-markup-insertion/document-writeln/document.writeln-03.html: Added.
  • web-platform-tests/html/dom/dynamic-markup-insertion/document-writeln/w3c-import.log:
  • web-platform-tests/html/dom/elements-obsolete.js:
  • web-platform-tests/html/dom/interfaces-expected.txt:
  • web-platform-tests/html/dom/interfaces.html:
  • web-platform-tests/html/semantics/document-metadata/styling/LinkStyle-expected.txt: Added.
  • web-platform-tests/html/semantics/document-metadata/styling/LinkStyle.html: Added.
  • web-platform-tests/html/semantics/document-metadata/styling/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/w3c-import.log.
  • web-platform-tests/html/semantics/embedded-content/media-elements/offsets-into-the-media-resource/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/media-elements/playing-the-media-resource/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/media-elements/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords-expected.txt: Added.
  • web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords.html: Added.
  • web-platform-tests/html/semantics/embedded-content/the-area-element/area-processing-expected.txt: Added.
  • web-platform-tests/html/semantics/embedded-content/the-area-element/area-processing.html: Added.
  • web-platform-tests/html/semantics/embedded-content/the-area-element/area-shape-expected.txt: Added.
  • web-platform-tests/html/semantics/embedded-content/the-area-element/area-shape.html: Added.
  • web-platform-tests/html/semantics/embedded-content/the-area-element/support/hit-test.js: Added.

(onload):

  • web-platform-tests/html/semantics/embedded-content/the-area-element/support/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-area-element/w3c-import.log.
  • web-platform-tests/html/semantics/embedded-content/the-area-element/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/toDataURL.nocontext.html:
  • web-platform-tests/html/semantics/embedded-content/the-embed-element/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_javascript_url_01-expected.txt: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_javascript_url_01.htm: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_script-expected.txt: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_script.html: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_01-expected.txt: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_01.html: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_02-expected.txt: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_02.html: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_03-expected.txt: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_03.html: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_04-expected.txt: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/move_iframe_in_dom_04.html: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/blank.htm: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/sandbox_allow_script.html: Added.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/track/track-element/w3c-import.log.
  • web-platform-tests/html/semantics/embedded-content/the-iframe-element/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-object-element/w3c-import.log.
  • web-platform-tests/html/semantics/embedded-content/the-img-element/w3c-import.log:
  • web-platform-tests/html/semantics/embedded-content/the-object-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/form-submission-0/url-encoded-expected.txt: Added.
  • web-platform-tests/html/semantics/forms/form-submission-0/url-encoded.html: Added.
  • web-platform-tests/html/semantics/forms/form-submission-0/w3c-import.log:
  • web-platform-tests/html/semantics/forms/textfieldselection/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-button-element/button-activate-expected.txt: Added.
  • web-platform-tests/html/semantics/forms/the-button-element/button-activate-frame.html: Added.
  • web-platform-tests/html/semantics/forms/the-button-element/button-activate.html: Added.
  • web-platform-tests/html/semantics/forms/the-button-element/button-events-expected.txt:
  • web-platform-tests/html/semantics/forms/the-button-element/button-events.html:
  • web-platform-tests/html/semantics/forms/the-button-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-form-element/form-elements-sameobject-expected.txt: Added.
  • web-platform-tests/html/semantics/forms/the-form-element/form-elements-sameobject.html: Added.
  • web-platform-tests/html/semantics/forms/the-form-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-input-element/checkbox-expected.txt:
  • web-platform-tests/html/semantics/forms/the-input-element/checkbox.html:
  • web-platform-tests/html/semantics/forms/the-input-element/maxlength-expected.txt: Added.
  • web-platform-tests/html/semantics/forms/the-input-element/maxlength.html: Added.
  • web-platform-tests/html/semantics/forms/the-input-element/radio-expected.txt:
  • web-platform-tests/html/semantics/forms/the-input-element/radio.html:
  • web-platform-tests/html/semantics/forms/the-input-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-option-element/option-selected-expected.txt: Added.
  • web-platform-tests/html/semantics/forms/the-option-element/option-selected.html: Added.
  • web-platform-tests/html/semantics/forms/the-option-element/w3c-import.log:
  • web-platform-tests/html/semantics/forms/the-select-element/select-ask-for-reset-expected.txt: Added.
  • web-platform-tests/html/semantics/forms/the-select-element/select-ask-for-reset.html: Added.
  • web-platform-tests/html/semantics/forms/the-select-element/w3c-import.log:
  • web-platform-tests/html/semantics/interactive-elements/the-details-element/w3c-import.log:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/script-text-expected.txt:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/script-text.html:
  • web-platform-tests/html/semantics/scripting-1/the-script-element/w3c-import.log:
  • web-platform-tests/html/semantics/tabular-data/the-tbody-element/rows-expected.txt: Added.
  • web-platform-tests/html/semantics/tabular-data/the-tbody-element/rows.html: Added.
  • web-platform-tests/html/semantics/tabular-data/the-tbody-element/w3c-import.log:
  • web-platform-tests/html/semantics/tabular-data/the-tfoot-element/rows-expected.txt: Added.
  • web-platform-tests/html/semantics/tabular-data/the-tfoot-element/rows.html: Added.
  • web-platform-tests/html/semantics/tabular-data/the-tfoot-element/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/w3c-import.log.
  • web-platform-tests/html/semantics/tabular-data/the-thead-element/rows-expected.txt: Added.
  • web-platform-tests/html/semantics/tabular-data/the-thead-element/rows.html: Added.
  • web-platform-tests/html/semantics/tabular-data/the-thead-element/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/form-submission-0/w3c-import.log.
  • web-platform-tests/html/semantics/tabular-data/the-tr-element/cells-expected.txt: Added.
  • web-platform-tests/html/semantics/tabular-data/the-tr-element/cells.html: Added.
  • web-platform-tests/html/semantics/tabular-data/the-tr-element/w3c-import.log:
4:01 PM Changeset in webkit [196090] by Beth Dakin
  • 9 edits in trunk/Source/WebCore

Accepted candidates should not be autocorrected
https://bugs.webkit.org/show_bug.cgi?id=153813
-and corresponding-
rdar://problem/24066924

Reviewed by Darin Adler.

New document marker to mark inserted candidates. This was we can treat
inserted candidates just like a RejectedCorrection and we won’t accidentally
autocorrect them later on.

  • dom/DocumentMarker.h:

(WebCore::DocumentMarker::AllMarkers::AllMarkers):

  • editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::processMarkersOnTextToBeReplacedByResult):

When handling an acceptant candidate, set m_isHandlingAcceptedCandidate to
true while the text is being inserted, and then mark the range as an accepted
candidate.

  • editing/Editor.cpp:

(WebCore::Editor::handleAcceptedCandidate):

  • editing/Editor.h:

(WebCore::Editor::isHandlingAcceptedCandidate):

If frame.editor. isHandlingAcceptedCandidate() then return early from
markMisspellingsAfterTyping.

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::markMisspellingsAfterTyping):

Add some test infrastructure.

  • testing/Internals.cpp:

(WebCore::Internals::handleAcceptedCandidate):

  • testing/Internals.h:
  • testing/Internals.idl:
4:00 PM Changeset in webkit [196089] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] Pass entire request (rather than just URL) to clients of WebCoreAVCFResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=153653

Reviewed by Brent Fulgham.

This will allow those clients to see the byte-range request ("Range:") header and respond
appropriately.

  • platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:

(WebCore::WebCoreAVCFResourceLoader::startLoading):

3:53 PM Changeset in webkit [196088] by jer.noble@apple.com
  • 5 edits in trunk

Yosemite build fix; hide the entire WebCoreNSURLSessionDataTask class from Yosemite and prior.

Source/WebCore:

  • platform/network/cocoa/WebCoreNSURLSession.h:
  • platform/network/cocoa/WebCoreNSURLSession.mm:

(-[WebCoreNSURLSessionDataTask initWithSession:identifier:URL:]):
(-[WebCoreNSURLSessionDataTask initWithSession:identifier:request:]):

Tools:

  • TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm:
3:30 PM Changeset in webkit [196087] by bshafiei@apple.com
  • 5 edits in tags/Safari-602.1.18.1.1/Source

Versioning.

3:26 PM Changeset in webkit [196086] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.18.1.1

New tag.

3:06 PM Changeset in webkit [196085] by jh718.park@samsung.com
  • 2 edits in trunk/Tools

[Tools] Remove $additionalCMakeArgs variable because without this variable --cmakeargs options works well
https://bugs.webkit.org/show_bug.cgi?id=153827

Reviewed by Michael Catanzaro.

When an array is passed to subroutines as argument in perl,
a list containing its element is returned from the array.
Currently @$ arguments are being passed, then it is going to be one list
including all the elements not only from @ but also from $.
As a result, --cmakeargs option's value is included in @cmakeArgs
at generateBuildSystemFromCMakeProject subroutine,
so $additionalCMakeArgs doesn't needed anymore.

  • Scripts/webkitdirs.pm:

(generateBuildSystemFromCMakeProject):

3:01 PM Changeset in webkit [196084] by Brent Fulgham
  • 3 edits
    1 delete in trunk/LayoutTests

REGRESSION: LayoutTest http/tests/plugins/visible_plugins.html failing on Yosemite WK1
https://bugs.webkit.org/show_bug.cgi?id=153752

Reviewed by Alexey Proskuryakov.

Revise test to skip the plugins we expect to be displayed, and only display plugins
that are surprising.

  • http/tests/plugins/visible_plugins.html:
  • http/tests/plugins/visible_plugins-expected.txt:
  • platform/mac-wk2/http/tests/plugins/visible_plugins-expected.txt: Removed.
2:59 PM Changeset in webkit [196083] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

[EME][Mac] MediaKeys.createSession() fails with initData containing a contentId whose length is > 1/2 the initData.
https://bugs.webkit.org/show_bug.cgi?id=153517
<rdar://problem/24303782>

Reviewed by Eric Carlson.

The length of contentId is given in bytes, not Uint16 characters. Use the former when extracting
the contentId string from the initData.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::extractKeyURIKeyIDAndCertificateFromInitData):

2:57 PM Changeset in webkit [196082] by jer.noble@apple.com
  • 5 edits
    4 adds in trunk

[Mac] Wrap a resource and resource loader in a NSURLSession-like object for use by lower level frameworks
https://bugs.webkit.org/show_bug.cgi?id=153669

Reviewed by Alex Christensen.

Source/WebCore:

API Test: WebCore.WebCoreNSURLSession

Add a NSURLSession-like object, which wraps a CachedResourceLoader and CachedRawResource, which we can
hand to lower-level frameworks, so that network loads by those frameworks use WebKit's loader.

  • platform/network/cocoa/WebCoreNSURLSession.h: Added.
  • platform/network/cocoa/WebCoreNSURLSession.mm: Added.

(-[WebCoreNSURLSession initWithResourceLoader:delegate:delegateQueue:]):
(-[WebCoreNSURLSession dealloc]):
(-[WebCoreNSURLSession copyWithZone:]):
(-[WebCoreNSURLSession delegateQueue]):
(-[WebCoreNSURLSession configuration]):
(-[WebCoreNSURLSession loader]):
(-[WebCoreNSURLSession finishTasksAndInvalidate]):
(-[WebCoreNSURLSession invalidateAndCancel]):
(-[WebCoreNSURLSession resetWithCompletionHandler:]):
(-[WebCoreNSURLSession flushWithCompletionHandler:]):
(-[WebCoreNSURLSession getTasksWithCompletionHandler:]):
(-[WebCoreNSURLSession getAllTasksWithCompletionHandler:]):
(-[WebCoreNSURLSession dataTaskWithRequest:]):
(-[WebCoreNSURLSession dataTaskWithURL:]):
(-[WebCoreNSURLSession uploadTaskWithRequest:fromFile:]):
(-[WebCoreNSURLSession uploadTaskWithRequest:fromData:]):
(-[WebCoreNSURLSession uploadTaskWithStreamedRequest:]):
(-[WebCoreNSURLSession downloadTaskWithRequest:]):
(-[WebCoreNSURLSession downloadTaskWithURL:]):
(-[WebCoreNSURLSession downloadTaskWithResumeData:]):
(-[WebCoreNSURLSession streamTaskWithHostName:port:]):
(-[WebCoreNSURLSession streamTaskWithNetService:]):
(-[WebCoreNSURLSession isKindOfClass:]):

Add a C++ class which can act as a CachedRawResourceClient, passing the results back to a WebCoreNSURLSessionDataTask:

(WebCore::WebCoreNSURLSessionDataTaskClient::WebCoreNSURLSessionDataTaskClient):
(WebCore::WebCoreNSURLSessionDataTaskClient::dataSent):
(WebCore::WebCoreNSURLSessionDataTaskClient::responseReceived):
(WebCore::WebCoreNSURLSessionDataTaskClient::dataReceived):
(WebCore::WebCoreNSURLSessionDataTaskClient::redirectReceived):
(WebCore::WebCoreNSURLSessionDataTaskClient::notifyFinished):

Add a NSURLSessionDataTask-like object, which takes a request, then uses it to create and wrap a CachedRawResource.
Becase NSURSessionDataTask is intended to be used off-main-thread, care must be taken to dispatch back to the main-
(or web-) thread before calling CachedRawResource functions.

(-[WebCoreNSURLSessionDataTask initWithSession:identifier:URL:]):
(-[WebCoreNSURLSessionDataTask initWithSession:identifier:request:]):
(-[WebCoreNSURLSessionDataTask copyWithZone:]):
(-[WebCoreNSURLSessionDataTask _restart]):
(-[WebCoreNSURLSessionDataTask _cancel]):
(-[WebCoreNSURLSessionDataTask _finish]):
(-[WebCoreNSURLSessionDataTask _setDefersLoading:]):
(-[WebCoreNSURLSessionDataTask cancel]):
(-[WebCoreNSURLSessionDataTask suspend]):
(-[WebCoreNSURLSessionDataTask resume]):
(-[WebCoreNSURLSessionDataTask _timingData]):
(-[WebCoreNSURLSessionDataTask resource:sentBytes:totalBytesToBeSent:]):
(-[WebCoreNSURLSessionDataTask resource:receivedResponse:]):
(-[WebCoreNSURLSessionDataTask resource:receivedData:length:]):
(-[WebCoreNSURLSessionDataTask resource:receivedRedirect:request:]):
(-[WebCoreNSURLSessionDataTask resourceFinished:]):

  • WebCore.xcodeproj/project.pbxproj: Add new files to project.

Tools:

Add an API test for WebCoreNSURLSession, testing that it behaves like a regulare NSURLSession, including
calling appropriate NSURLSessionDelegate callbacks.

Drive-by fix: Add a FeatureDefines.xcconfig to TestWebKitAPI. Without this, the ENABLE macros in WebCore
header files will not match the one used when compiling WebCore, leading to strange crashes and weird
inconsistencies when calling, e.g., inline methods.

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig: Added.
  • TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/WebCoreNSURLSession.mm: Added.

(-[TestNSURLSessionLoaderDelegate webView:didCommitLoadForFrame:]):
(-[TestNSURLSessionDataDelegate URLSession:task:didCompleteWithError:]):
(-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
(-[TestNSURLSessionDataDelegate URLSession:dataTask:didReceiveData:]):
(TestWebKitAPI::WebCoreNSURLSessionTest::SetUp):
(TestWebKitAPI::WebCoreNSURLSessionTest::TearDown):
(TestWebKitAPI::TEST_F):

2:46 PM Changeset in webkit [196081] by matthew_hanson@apple.com
  • 2 edits in branches/safari-601-branch/LayoutTests

Work towards rdar://problem/24190682

2:08 PM Changeset in webkit [196080] by Darin Adler
  • 34 edits in trunk/Source

Convert another batch of String::lower callsites to something better, typically convertToASCIILowercase
https://bugs.webkit.org/show_bug.cgi?id=153789

Reviewed by Sam Weinig.

Source/WebCore:

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::isXMLMIMEType): Use equalLettersIgnoringASCIICase
and the boolean argument to endsWith to ignore ASCII case.
(WebCore::DOMImplementation::isTextMIMEType): Ditto. Also simplified the logic
by removing an if statement.

  • dom/Document.cpp:

(WebCore::isSeparator): Deleted. Moved to WindowFeatures.cpp.
(WebCore::processArguments): Ditto.
(WebCore::Document::processViewport): Call the processFeaturesString function
from WindowFeatures.h; the code here was originally just a pasted copy of that code!
(WebCore::Document::processFormatDetection): Ditto.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::toEncodingMimeType): Remove now-unneeded
lowercasing of MIME type before calling isSupportedImageMIMETypeForEncoding,
since the MIME type registry now ignores ASCII case. Use convertToASCIILowercase
on the return value, to preserve behavior.
(WebCore::HTMLCanvasElement::toDataURL): Minor coding style tweaks.

  • html/HTMLEmbedElement.cpp:

(WebCore::HTMLEmbedElement::parseAttribute): Use convertToASCIILowercase for
the service type here.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement): Remove now-unneeded
lowercasing since MIME type registry now ignores ASCII case. And use
equalLettersIgnoringASCIICase for the case here.

  • html/HTMLInputElement.cpp:

(WebCore::parseAcceptAttribute): Use convertToASCIILowercase for the type here.

  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::parseAttribute): Use convertToASCIILowercase for the
media value here.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::canPlayType): Use convertToASCIILowercase for the
content type here.
(WebCore::HTMLMediaElement::selectNextSourceChild): Ditto.

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parseAttribute): Use convertToASCIILowercase for
the service type here.

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::parseAttribute): Use convertToASCIILowercase for
the kind here.
(WebCore::HTMLTrackElement::ensureTrack): Ditto. Also use fastGetAttribute
since this is neither the style attribute nor an animatable SVG attribute.

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::createCaseMap): Use convertToASCIILowercase for the local names here.

  • inspector/DOMPatchSupport.cpp:

(WebCore::DOMPatchSupport::patchNode): Use containsIgnoringASCIICase instead
of combining lower with find == notFound here.
(WebCore::nodeName): Use convertToASCIILowercase here.

  • inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForElementData): Use convertToASCIILowercase for node
name here.

  • inspector/InspectorPageAgent.cpp:

(WebCore::createXHRTextDecoder): Remove a now-unneeded call to lower since
DOMImplementation::isXMLMIMEType now ignores ASCII case.

  • inspector/InspectorStyleSheet.cpp:

(WebCore::lowercasePropertyName): Use convertToASCIILowercase for property
names here. Also use startsWith rather than a hand-written alternative.
(WebCore::InspectorStyle::populateAllProperties): Use the return value of
the add function to avoid doing a double hash table lookp.
(WebCore::InspectorStyle::styleWithProperties): Use convertToASCIILowercase
to lowercase the property name.

  • inspector/NetworkResourcesData.cpp:

(WebCore::createOtherResourceTextDecoder): Remove unneeded call to lower since
DOMImplement::isXMLMIMEType now ignores ASCII case.

  • loader/CrossOriginAccessControl.cpp:

(WebCore::createAccessControlPreflightRequest): Use convertToASCIILowercase
to lowercase the access control request header field value.

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::mimeType): Use convertToASCIILowercase on the content type.

  • page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::languageIdentifier): Use convertToASCIILowercase on the language code.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::open): Call parseWindowFeatures instead of using the
constructor for WindowFeatures.
(WebCore::DOMWindow::showModalDialog): Call parseDialogFeatures instead of
using the constructor for WindowFeatures.

  • page/EventHandler.cpp:

(WebCore::findDropZone): Remove unneeded lowercasing and empty string checking,
and use the option SpaceSplitString already has to convert to lowercase.
(WebCore::EventHandler::handleAccessKey): Remove unneeded call to lower since
getElementByAccessKey now ignores case. Also tweaked coding style a bit.

  • page/OriginAccessEntry.cpp:

(WebCore::OriginAccessEntry::OriginAccessEntry): Use convertToASCIILowercase
on the protocol and host.
(WebCore::OriginAccessEntry::matchesOrigin): Ditto.

  • page/SecurityOrigin.cpp:

(WebCore::shouldTreatAsUniqueOrigin): Remove unneeded call to lower since
SchemeRegistry now ignores ASCII case.
(WebCore::SecurityOrigin::SecurityOrigin): Use convertToASCIILowercase on
the protocol and host.
(WebCore::SecurityOrigin::setDomainFromDOM): Use convertToASCIILowercase on
the domain.
(WebCore::SecurityOrigin::canDisplay): Remove call to lower since SchemeRegistry
now ignores ASCII case and because this now uses equalIgnoringASCIICase in
one place that used to use exact matching.

  • page/WindowFeatures.cpp: Refactored so this is now some helper functions

plus a struct rather than a class.
(WebCore::isSeparator): Renamed this and removed special handling for NUL.
(WebCore::parseWindowFeatures): Moved the code that was formerly in the
WindowFeatures constructor in here. Refactored the parsing into the
processFeaturesString function, shared with the functions in Document that
do the same kind of parsing. Removed the code that converts the entire string
to lowercase before parsing.
(WebCore::processFeaturesString): Moved the improved version of this function
here from Document.cpp; more efficient because it doesn't allocate strings.
(WebCore::setWindowFeature): Changed to be a function private to this file
with internal linkage. Use equalLettersIgnoringASCIICase so we no longer
rely on converting the string to lowercase before parsing.
(WebCore::parseDialogFeatures): Similar refactoring, but also changed all
the default handling to use Optional<> instead of default values.
(WebCore::boolFeature): Changed to use option and to ignore ASCII case.
(WebCore::floatFeature): Ditto.
(WebCore::parseDialogFeaturesMap): Removed the calls to lower, which are
not needed any more.

  • page/WindowFeatures.h: Added default values for all the data members,

and removed all the functions from the WindowFeatures struct. Added the two
functions for parsing window and dialog features. Also added the
processFeaturesString function so we can share it with Document.cpp.

  • platform/SchemeRegistry.cpp:

(WebCore::SchemeRegistry::removeURLSchemeRegisteredAsLocal): Use
equalLettersIgnoringASCIICase to ignore ASCII case.

  • platform/efl/MIMETypeRegistryEfl.cpp:

(WebCore::MIMETypeRegistry::getMIMETypeForExtension): Use a modern for loop,
and equalIgnoringASCIICase rather than calling lower.

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::load): Use convertToASCIILowercase on MIME type and
key system.
(WebCore::MediaPlayer::generateKeyRequest): Ditto.
(WebCore::MediaPlayer::addKey): Ditto.
(WebCore::MediaPlayer::cancelKeyRequest): Ditto.

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon): Use
convertToASCIILowercase on vendor string.

  • platform/gtk/MIMETypeRegistryGtk.cpp:

(WebCore::MIMETypeRegistry::getMIMETypeForExtension): Use a modern for loop,
and equalIgnoringASCIICase rather than calling lower.

  • platform/mac/PasteboardMac.mm:

(WebCore::cocoaTypeFromHTMLClipboardType): Use convertToASCIILowercase
on the type. Also did a bit of renaming and tweaking the logic.

Source/WTF:

  • wtf/text/StringView.h:

(WTF::StringView::toInt): Added an overload without the out parameter.

1:54 PM Changeset in webkit [196079] by Chris Dumez
  • 18 edits
    1 copy
    1 move
    11 adds in trunk/LayoutTests/imported/w3c

Re-sync W3C DOM web-platform-tests
https://bugs.webkit.org/show_bug.cgi?id=153831

Reviewed by Darin Adler.

Re-sync W3C DOM web-platform-tests from:
https://github.com/w3c/web-platform-tests/tree/master/dom

  • web-platform-tests/dom/collections/domstringmap-supported-property-names-expected.txt: Added.
  • web-platform-tests/dom/collections/domstringmap-supported-property-names.html: Added.
  • web-platform-tests/dom/collections/namednodemap-supported-property-names-expected.txt: Added.
  • web-platform-tests/dom/collections/namednodemap-supported-property-names.html: Added.
  • web-platform-tests/dom/collections/w3c-import.log:
  • web-platform-tests/dom/events/Event-dispatch-propagation-stopped-expected.txt: Added.
  • web-platform-tests/dom/events/Event-dispatch-propagation-stopped.html: Added.
  • web-platform-tests/dom/events/w3c-import.log:
  • web-platform-tests/dom/historical-expected.txt:
  • web-platform-tests/dom/historical.html:
  • web-platform-tests/dom/interface-objects-expected.txt:
  • web-platform-tests/dom/interface-objects.html:
  • web-platform-tests/dom/interfaces-expected.txt:
  • web-platform-tests/dom/interfaces.html:
  • web-platform-tests/dom/nodes/DOMImplementation-createDocument-expected.txt:
  • web-platform-tests/dom/nodes/DOMImplementation-createDocument.html:
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.html: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.svg: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xhtml: Added.
  • web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xml: Added.
  • web-platform-tests/dom/nodes/Element-classlist-expected.txt:
  • web-platform-tests/dom/nodes/Element-classlist.html:
  • web-platform-tests/dom/nodes/Node-contains-xhtml-expected.txt: Added.
  • web-platform-tests/dom/nodes/Node-contains-xhtml.xhtml: Added.
  • web-platform-tests/dom/nodes/Node-isEqualNode-expected.txt:
  • web-platform-tests/dom/nodes/Node-isEqualNode-xhtml-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-isEqualNode-expected.txt.
  • web-platform-tests/dom/nodes/Node-isEqualNode-xhtml.xhtml: Renamed from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-isEqualNode.xhtml.
  • web-platform-tests/dom/nodes/Node-isEqualNode.html: Added.
  • web-platform-tests/dom/nodes/attributes-expected.txt:
  • web-platform-tests/dom/nodes/attributes.html:
  • web-platform-tests/dom/nodes/w3c-import.log:
  • web-platform-tests/dom/ranges/Range-constructor-expected.txt: Added.
  • web-platform-tests/dom/ranges/Range-constructor.html: Added.
  • web-platform-tests/dom/ranges/w3c-import.log:
  • web-platform-tests/dom/w3c-import.log:
1:26 PM Changeset in webkit [196078] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip http/tests/contentdispositionattachmentsandbox/form-submission-disabled.html on ios-simulator until it can be rewritten.
https://bugs.webkit.org/show_bug.cgi?id=152993

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
1:21 PM Changeset in webkit [196077] by Michael Catanzaro
  • 13 edits in trunk

[GTK][EFL] Switch FTL to B3
https://bugs.webkit.org/show_bug.cgi?id=153478

Reviewed by Csaba Osztrogonác.

.:

  • Source/cmake/OptionsEfl.cmake:
  • Source/cmake/OptionsGTK.cmake:

Source/JavaScriptCore:

Conditionalize code to make it possible to build FTL completely without LLVM.

  • CMakeLists.txt:
  • dfg/DFGCommon.h:
  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThreadImpl):

  • ftl/FTLAbbreviatedTypes.h:
  • ftl/FTLFail.cpp:

(JSC::FTL::fail):

  • ftl/FTLState.cpp:

(JSC::FTL::State::State):
(JSC::FTL::State::~State):

Source/WTF:

Enable B3 by default on all x86.

  • wtf/Platform.h:
1:10 PM Changeset in webkit [196076] by hyatt@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Add hanging-punctuation property to Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=153841

Reviewed by Zalan Bujtas.

  • UserInterface/Models/CSSKeywordCompletions.js:
12:54 PM Changeset in webkit [196075] by hyatt@apple.com
  • 14 edits
    3 adds in trunk

Implement hanging-punctuation property parsing.
https://bugs.webkit.org/show_bug.cgi?id=18109.

Reviewed by Zalan Bujtas.

Source/WebCore:

Added parsing test in fast/css.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::renderEmphasisPositionFlagsToCSSValue):
(WebCore::hangingPunctuationToCSSValue):
(WebCore::fillRepeatToCSSValue):
(WebCore::ComputedStyleExtractor::propertyValue):

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseTextIndent):
(WebCore::CSSParser::parseHangingPunctuation):
(WebCore::CSSParser::parseLineBoxContain):

  • css/CSSParser.h:
  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator HangingPunctuation):
(WebCore::CSSPrimitiveValue::operator LineBreak):

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:
  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertRegionBreakInside):
(WebCore::StyleBuilderConverter::convertHangingPunctuation):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayout):

  • rendering/style/RenderStyle.h:
  • rendering/style/RenderStyleConstants.h:

(WebCore::operator| ):
(WebCore::operator|= ):

  • rendering/style/StyleRareInheritedData.cpp:

(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):

  • rendering/style/StyleRareInheritedData.h:

LayoutTests:

  • fast/css/parsing-hanging-punctuation-expected.txt: Added.
  • fast/css/parsing-hanging-punctuation.html: Added.
  • fast/css/resources/parsing-hanging-punctuation.js: Added.

(test):

12:15 PM Changeset in webkit [196074] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught exception TimelineRuler.prototype.resize no longer exists
https://bugs.webkit.org/show_bug.cgi?id=153839

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-03
Reviewed by Brian Burg.

  • UserInterface/Views/MemoryTimelineView.js:

(WebInspector.MemoryTimelineView.prototype.shown):
After r195995 the resize method was eliminated in favor of this approach.

12:14 PM Changeset in webkit [196073] by jeffm@apple.com
  • 2 edits in branches/safari-601-branch/Source/WebKit2

Update WebKit2.framework copyright string to include 2016.

This framework no longer exists on trunk, so we missed this as part of the merge of r194479.

  • mac/Info-WebKit2.plist:
10:58 AM Changeset in webkit [196072] by achristensen@apple.com
  • 2 edits in trunk/Source/WebKit2

Use proposed credentials in authentication challenges with NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=153811

Reviewed by Darin Adler.

This fixes http/tests/xmlhttprequest/basic-auth-default.html

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkDataTask::tryPasswordBasedAuthentication):
Use the proposed credential if there is one. This matches behavior in
ResourceHandle::tryHandlePasswordBasedAuthentication.

10:21 AM Changeset in webkit [196071] by andersca@apple.com
  • 2 edits in trunk/Source/WTF

Fix BlockPtr's call operator
https://bugs.webkit.org/show_bug.cgi?id=153836

Reviewed by Enrica Casucci.

  • wtf/BlockPtr.h:
9:59 AM Changeset in webkit [196070] by jberlin@webkit.org
  • 7 edits in trunk/Source

Build fix.

[NSEvent context] has always returned nil. Replace uses with nullptr.

Source/WebCore:

  • page/mac/EventHandlerMac.mm:

(WebCore::EventHandler::sendFakeEventsAfterWidgetTracking):

Source/WebKit/mac:

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _postFakeMouseMovedEventForFlagsChangedEvent:]):
(-[WebHTMLView _updateMouseoverWithFakeEvent]):
(-[WebHTMLView _updateMouseoverWithEvent:]):
(-[WebHTMLView _autoscroll]):
(-[WebHTMLView draggedImage:endedAt:operation:]):

Source/WebKit2:

  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::postFakeMouseMovedEventForFlagsChangedEvent):

  • UIProcess/mac/WebPopupMenuProxyMac.mm:

(WebKit::WebPopupMenuProxyMac::showPopupMenu):

9:51 AM Changeset in webkit [196069] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip fast/forms/input-user-input-sanitization.html on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=152306

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
9:49 AM Changeset in webkit [196068] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

[iOS] Engineering builds use manual sandboxing, but don’t need to
https://bugs.webkit.org/show_bug.cgi?id=153834

Reviewed by Anders Carlsson.

Now that engineering builds use the non-re-execing variant of XPC services, they can be
statically sandboxed and no longer need to be manually sandboxed.

  • Configurations/DebugRelease.xcconfig: Don’t set WK_MANUAL_SANDBOXING_ENABLED to YES.
  • WebKit2.xcodeproj/project.pbxproj: Let Xcode make changes to the built product references.
9:09 AM Changeset in webkit [196067] by Chris Dumez
  • 2 edits in trunk/Source/WebKit2

Unreviewed, rolling out r195555.

Temporarily disable speculative revalidation to measure the
impact on the bots

Reverted changeset:

"[WK2][NetworkCache] Enable speculative revalidation"
https://bugs.webkit.org/show_bug.cgi?id=153443
http://trac.webkit.org/changeset/195555

8:34 AM Changeset in webkit [196066] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKit2

REGRESSION (r194660): Legacy WebProcess crashes in ChildProcess::initializeSandbox()
https://bugs.webkit.org/show_bug.cgi?id=153734
<rdar://problem/24433179>

Reviewed by Dan Bernstein.

Fixes an issue where clients that used the legacy WebProcess bootstrapping process would crash.

Additionally, only consider the extra initialization parameter user-directory-suffix for
unsigned apps (e.g. WebKitTestRunner).

  • Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::initializeSandbox):

3:38 AM Changeset in webkit [196065] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

[webkitdirs] Clarify logic behind is{PortName} functions.
https://bugs.webkit.org/show_bug.cgi?id=153554

Patch by Konstantin Tokarev <Konstantin Tokarev> on 2016-02-03
Reviewed by Michael Catanzaro.

  • Scripts/webkitdirs.pm:

(prohibitUnknownPort): This function makes determinePortName()
failure fatal.
(determinePortName): Added new function which decides which port are
we building based on command line switches and platform defaults.
(portName): Added getter for determined $portName.
(isEfl): Modified to use portName().
(isGtk): Ditto.
(isWinCairo): Ditto.
(isAppleMacWebKit): Ditto.
(isAppleWinWebKit): Ditto.
(isIOSWebKit): Ditto.
(cmakeBasedPortName): Return portName() with capitalized first letter.
(determineIsEfl): Deleted.
(determineIsGtk): Deleted.
(determineIsWinCairo): Deleted.

  • Scripts/build-jsc: Call prohibitUnknownPort().
  • Scripts/run-minibrowser: Ditto.
  • Scripts/webkitperl/FeatureList.pm: Ditto.
  • Scripts/update-webkit: Call determinePortName() instead of

determineIsWinCairo().

3:29 AM Changeset in webkit [196064] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Unreviewed speculative buildfix after r195979.

  • PlatformMac.cmake:
3:13 AM Changeset in webkit [196063] by Hunseop Jeong
  • 254 edits in trunk/LayoutTests

Unreviewed. EFL gardening: rebaseline tests after r195740.

  • platform/efl/css1/box_properties/border_width_inline-expected.txt:
  • platform/efl/css1/formatting_model/floating_elements-expected.txt:
  • platform/efl/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
  • platform/efl/css2.1/t0805-c5511-brdr-tw-00-b-expected.txt:
  • platform/efl/css2.1/t0805-c5513-brdr-bw-00-b-expected.txt:
  • platform/efl/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
  • platform/efl/css2.1/t0805-c5519-brdr-r-01-e-expected.txt:
  • platform/efl/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
  • platform/efl/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
  • platform/efl/css2.1/t0805-c5522-brdr-02-e-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-01-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-02-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-03-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-05-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-07-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-09-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-10-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-11-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-12-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-15-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-19-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-20-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-21-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-22-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-23-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-26-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-27-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-28-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-29-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-32-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-33-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-35-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-36-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-37-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-38-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-39-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-40-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-41-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-42-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-43-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-45-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-46-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-47-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-48-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-49-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-50-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-51-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-53-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-55-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-56-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-57-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-58-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-60-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-61-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-62-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-63-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-66-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-67-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-68-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-69-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-72-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-73-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-75-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-76-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-77-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-78-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-79-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-80-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-81-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-82-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-83-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-86-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-87-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-88-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-89-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-90-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-91-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-92-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-93-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-95-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-96-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-97-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-98-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-99-d-expected.txt:
  • platform/efl/css3/css3-modsel-33-expected.txt:
  • platform/efl/css3/flexbox/flexbox-baseline-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-161-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-18b-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-28-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-28b-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-32-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-43-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-43b-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-44-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-44b-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-74-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-74b-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-78-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-78b-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-161-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-18b-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-28-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-28b-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-32-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-43-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-43b-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-44-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-44b-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-74-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-74b-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-78-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-78b-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-161-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-18b-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-28-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-28b-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-32-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-43-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-44-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-44b-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-74-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-74b-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-78-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-78b-expected.txt:
  • platform/efl/editing/inserting/5058163-1-expected.txt:
  • platform/efl/editing/inserting/insert-paragraph-01-expected.txt:
  • platform/efl/editing/inserting/insert-paragraph-02-expected.txt:
  • platform/efl/editing/inserting/paragraph-separator-in-table-2-expected.txt:
  • platform/efl/editing/selection/4818145-expected.txt:
  • platform/efl/editing/selection/4889598-expected.txt:
  • platform/efl/editing/selection/4895428-2-expected.txt:
  • platform/efl/editing/selection/5076323-1-expected.txt:
  • platform/efl/editing/selection/5076323-2-expected.txt:
  • platform/efl/editing/selection/5076323-3-expected.txt:
  • platform/efl/editing/selection/7152-1-expected.txt:
  • platform/efl/editing/selection/7152-2-expected.txt:
  • platform/efl/editing/selection/display-table-text-expected.txt:
  • platform/efl/editing/selection/iframe-expected.txt:
  • platform/efl/editing/selection/inline-table-expected.txt:
  • platform/efl/editing/selection/mixed-editability-3-expected.txt:
  • platform/efl/editing/selection/mixed-editability-4-expected.txt:
  • platform/efl/editing/selection/mixed-editability-5-expected.txt:
  • platform/efl/editing/selection/mixed-editability-8-expected.txt:
  • platform/efl/editing/selection/mixed-editability-9-expected.txt:
  • platform/efl/editing/selection/table-caret-1-expected.txt:
  • platform/efl/editing/selection/table-caret-2-expected.txt:
  • platform/efl/editing/selection/table-caret-3-expected.txt:
  • platform/efl/editing/style/5017613-1-expected.txt:
  • platform/efl/editing/style/5017613-2-expected.txt:
  • platform/efl/editing/style/apple-style-editable-mix-expected.txt:
  • platform/efl/editing/style/table-selection-expected.txt:
  • platform/efl/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.txt:
  • platform/efl/fast/block/float/011-expected.txt:
  • platform/efl/fast/block/margin-collapse/001-expected.txt:
  • platform/efl/fast/block/margin-collapse/005-expected.txt:
  • platform/efl/fast/block/margin-collapse/104-expected.txt:
  • platform/efl/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
  • platform/efl/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
  • platform/efl/fast/block/positioning/053-expected.txt:
  • platform/efl/fast/borders/bidi-009a-expected.txt:
  • platform/efl/fast/box-shadow/basic-shadows-expected.txt:
  • platform/efl/fast/css-generated-content/015-expected.txt:
  • platform/efl/fast/css-generated-content/inline-display-types-expected.txt:
  • platform/efl/fast/css-generated-content/table-before-after-child-add-expected.txt:
  • platform/efl/fast/css-generated-content/table-cell-before-content-expected.txt:
  • platform/efl/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
  • platform/efl/fast/css-generated-content/table-row-before-after-expected.txt:
  • platform/efl/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
  • platform/efl/fast/css/first-letter-float-expected.txt:
  • platform/efl/fast/dynamic/007-expected.txt:
  • platform/efl/fast/dynamic/014-expected.txt:
  • platform/efl/fast/dynamic/015-expected.txt:
  • platform/efl/fast/dynamic/create-renderer-for-whitespace-only-text-expected.txt:
  • platform/efl/fast/forms/button-white-space-expected.txt:
  • platform/efl/fast/forms/file/file-input-direction-expected.txt:
  • platform/efl/fast/forms/form-added-to-table-expected.txt:
  • platform/efl/fast/forms/input-double-click-selection-gap-bug-expected.txt:
  • platform/efl/fast/forms/input-value-expected.txt:
  • platform/efl/fast/invalid/table-inside-stray-table-content-expected.txt:
  • platform/efl/fast/invalid/td-inside-object-expected.txt:
  • platform/efl/fast/lists/ordered-list-with-no-ol-tag-expected.txt:
  • platform/efl/fast/overflow/overflow-auto-table-expected.txt:
  • platform/efl/fast/replaced/width100percent-button-expected.txt:
  • platform/efl/fast/ruby/ruby-inline-table-expected.txt:
  • platform/efl/fast/selectors/018-expected.txt:
  • platform/efl/fast/selectors/018b-expected.txt:
  • platform/efl/fast/selectors/032-expected.txt:
  • platform/efl/fast/selectors/043-expected.txt:
  • platform/efl/fast/selectors/043b-expected.txt:
  • platform/efl/fast/selectors/044-expected.txt:
  • platform/efl/fast/selectors/044b-expected.txt:
  • platform/efl/fast/selectors/078b-expected.txt:
  • platform/efl/fast/table/001-expected.txt:
  • platform/efl/fast/table/004-expected.txt:
  • platform/efl/fast/table/006-expected.txt:
  • platform/efl/fast/table/010-expected.txt:
  • platform/efl/fast/table/011-expected.txt:
  • platform/efl/fast/table/015-expected.txt:
  • platform/efl/fast/table/016-expected.txt:
  • platform/efl/fast/table/022-expected.txt:
  • platform/efl/fast/table/026-expected.txt:
  • platform/efl/fast/table/033-expected.txt:
  • platform/efl/fast/table/035-expected.txt:
  • platform/efl/fast/table/035-vertical-expected.txt:
  • platform/efl/fast/table/037-expected.txt:
  • platform/efl/fast/table/041-expected.txt:
  • platform/efl/fast/table/auto-with-percent-height-expected.txt:
  • platform/efl/fast/table/auto-with-percent-height-vertical-expected.txt:
  • platform/efl/fast/table/border-collapsing/002-vertical-expected.txt:
  • platform/efl/fast/table/cell-coalescing-expected.txt:
  • platform/efl/fast/table/cellindex-expected.txt:
  • platform/efl/fast/table/colgroup-preceded-by-caption-expected.txt:
  • platform/efl/fast/table/colgroup-spanning-groups-rules-expected.txt:
  • platform/efl/fast/table/dynamic-descendant-percentage-height-expected.txt:
  • platform/efl/fast/table/floating-th-expected.txt:
  • platform/efl/fast/table/generated-caption-expected.txt:
  • platform/efl/fast/table/insert-before-anonymous-ancestors-expected.txt:
  • platform/efl/fast/table/insert-cell-before-form-expected.txt:
  • platform/efl/fast/table/insert-row-before-form-expected.txt:
  • platform/efl/fast/table/multiple-captions-display-expected.txt:
  • platform/efl/fast/table/nested-percent-height-table-expected.txt:
  • platform/efl/fast/table/quote-text-around-iframe-expected.txt:
  • platform/efl/fast/table/rowindex-expected.txt:
  • platform/efl/fast/table/rtl-cell-display-none-assert-expected.txt:
  • platform/efl/fast/table/rules-attr-dynchange1-expected.txt:
  • platform/efl/fast/table/rules-attr-dynchange2-expected.txt:
  • platform/efl/fast/table/table-after-child-in-table-expected.txt:
  • platform/efl/fast/table/table-and-parts-outline-expected.txt:
  • platform/efl/fast/table/table-before-child-in-table-expected.txt:
  • platform/efl/fast/table/table-cell-after-child-in-block-expected.txt:
  • platform/efl/fast/table/table-cell-after-child-in-table-expected.txt:
  • platform/efl/fast/table/table-cell-before-child-in-block-expected.txt:
  • platform/efl/fast/table/table-continuation-outline-paint-crash-expected.txt:
  • platform/efl/fast/table/table-hspace-align-center-expected.txt:
  • platform/efl/fast/table/table-row-after-child-in-block-expected.txt:
  • platform/efl/fast/table/table-row-after-child-in-table-expected.txt:
  • platform/efl/fast/table/table-row-before-child-in-block-expected.txt:
  • platform/efl/fast/table/table-row-before-child-in-table-expected.txt:
  • platform/efl/fast/table/tableInsideCaption-expected.txt:
  • platform/efl/fast/table/text-field-baseline-expected.txt:
  • platform/efl/fast/table/unbreakable-images-quirk-expected.txt:
  • platform/efl/fast/table/vertical-align-baseline-expected.txt:
  • platform/efl/fast/text/basic/001-expected.txt:
  • platform/efl/fast/text/basic/006-expected.txt:
  • platform/efl/fast/text/basic/007-expected.txt:
  • platform/efl/fast/text/capitalize-boundaries-expected.txt:
  • platform/efl/fast/text/hyphenate-locale-expected.txt:
  • platform/efl/fast/text/international/bidi-layout-across-linebreak-expected.txt:
  • platform/efl/fast/text/whitespace/024-expected.txt:
  • platform/efl/fast/text/whitespace/027-expected.txt:
  • platform/efl/fast/text/word-break-expected.txt:
  • platform/efl/fast/transforms/transform-table-row-expected.txt:
3:04 AM Changeset in webkit [196062] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK] Reduce IPC traffic due to view state changes
https://bugs.webkit.org/show_bug.cgi?id=153745

Reviewed by Sergio Villar Senin.

Very often view state changes happen one after another in a very
short period of time, even in the same run loop iteration. For
example, when you switch to the web view window, the view is
focused and the active window flag changes as well. In that case
we are sending two messages to the web process and the page
updates its status according to the new flags in two steps. So, we
could group all state changes happening in the same run loop
iteration and notify about them all in the next iteration. This
also prevents unnecessary changes of state when we quickly go back
to a previous state, for example in focus follows mouse
configurations if you move the mouse outside the window and then
inside the window again quickly.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(_WebKitWebViewBasePrivate::_WebKitWebViewBasePrivate): Use
VirewState::Flags to keep the web view state instead of
boolean, and also to keep the flags that need to be updated. Use a
timer to update web view state flags.
(_WebKitWebViewBasePrivate::updateViewStateTimerFired): Call
WebPageProxy::viewStateDidChange() and reset the flags that need
to be updated.
(webkitWebViewBaseScheduleUpdateViewState): Update the flags that
need to be updated and schedule the timer if it's not active.
(toplevelWindowFocusInEvent): Use the flags and schedule an update.
(toplevelWindowFocusOutEvent): Ditto.
(toplevelWindowStateEvent): Also mark the view as hidden when minimized.
(webkitWebViewBaseSetToplevelOnScreenWindow): Connect to
window-state-event instead of deprecated visibility-notify-event.
(webkitWebViewBaseMap): Use the flags and schedule an update.
(webkitWebViewBaseUnmap): Ditto.
(webkitWebViewBaseSetFocus): Ditto.
(webkitWebViewBaseIsInWindowActive): Use the flags.
(webkitWebViewBaseIsFocused): Ditto
(webkitWebViewBaseIsVisible): Ditto.
(webkitWebViewBaseIsInWindow): Removed this since it was unused.

  • UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
2:37 AM Changeset in webkit [196061] by Carlos Garcia Campos
  • 4 edits in trunk

[GTK] Layout Test http/tests/appcache/different-https-origin-resource-main.html is failing
https://bugs.webkit.org/show_bug.cgi?id=145253

Reviewed by Michael Catanzaro.

Source/WebCore:

The problem is that when the load is cancelled while the
connection is still being established,
SoupMessage::notify::tls-errors is emitted and the handler calls
ResourceHandleClient::didFail() which can delete the ResourceHandle.

  • platform/network/soup/ResourceHandleSoup.cpp:

(WebCore::tlsErrorsChangedCallback): Protect the ResourceHandle
for the scope of the callback because
ResourceHandleClient::didFail() could delete the object.

LayoutTests:

Update test expectation.

  • platform/gtk/TestExpectations:
2:31 AM Changeset in webkit [196060] by Carlos Garcia Campos
  • 4 edits in trunk

REGRESSION(r191948): [GStreamer] 4 new timeouts on layout tests.
https://bugs.webkit.org/show_bug.cgi?id=152797

Reviewed by Darin Adler.

Source/WebCore:

Always schedule messages to the main thread, even when the bus
sync handlder was called in the main thread. It seems that
GStreamer expects things to happen in the next main loop
iteration.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):

LayoutTests:

Update test expectations.

  • platform/gtk/TestExpectations:
1:56 AM Changeset in webkit [196059] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

Unreviewed. Fix incorrect ASSERT introduced in r196053.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::NetscapePluginX11::paint): Ensure the plugin is not
windowed if paint() is called.

1:54 AM Changeset in webkit [196058] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

[TexMap] CompositingCoordinator should store the overlay layer, flush it as appropriate
https://bugs.webkit.org/show_bug.cgi?id=152058

Reviewed by Michael Catanzaro.

Previously, the CompositingCoordinator only added the overlay layer to the
layer tree, but flushing its compositing state is also required. For that to
happen, CompositingCoordinator has to store a pointer to the overlay layer
object and flush it in ::flushPendingLayerChanges().

Overlay layers are most prominently used by the Web Inspector to highlight
the DOM elements on the Web page that are being hovered in the inspector.

  • platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:

(WebCore::CompositingCoordinator::CompositingCoordinator):
(WebCore::CompositingCoordinator::setRootCompositingLayer):
(WebCore::CompositingCoordinator::flushPendingLayerChanges):

  • platform/graphics/texmap/coordinated/CompositingCoordinator.h:
12:48 AM Changeset in webkit [196057] by Carlos Garcia Campos
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed. Fix JavaScriptCore build with B3 enabled.

Include <limits.h> for UINT_MAX.

  • b3/B3StackSlot.h:
  • b3/air/AirStackSlot.h:
12:41 AM Changeset in webkit [196056] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

[CoordinatedGraphics] CompositingCoordinator destructor is scheduling layer flushes
https://bugs.webkit.org/show_bug.cgi?id=153823

Reviewed by Carlos Garcia Campos.

Purging the backing stores during the CompositingCoordinator destructor
is also scheduling layer flushes in the object's client, which is an object
of the LayerTreeHost-deriving class that owns the CompositingCoordinator
object in question and is also being destroyed.

In case of ThreadedCoordinatedLayerTreeHost, this scheduling can access
the RunLoop::Timer object which has already been destroyed, causing a
crash. Another problem with this is that we're invoking a virtual function
on an object that's being destructed, which works well enough in this case
but should be discouraged in general.

In order to avoid this, add the m_isDestructing boolean to the
CompositingCoordinator class, flip it to true during the destruction,
and check for its falseness before scheduling a layer flush.

  • platform/graphics/texmap/coordinated/CompositingCoordinator.cpp:

(WebCore::CompositingCoordinator::CompositingCoordinator):
(WebCore::CompositingCoordinator::~CompositingCoordinator):
(WebCore::CompositingCoordinator::notifyFlushRequired):

  • platform/graphics/texmap/coordinated/CompositingCoordinator.h:
12:34 AM Changeset in webkit [196055] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[TexMap] Don't use RELEASE_ASSERT in TextureMapperLayer::computeTransformsRecursive()
https://bugs.webkit.org/show_bug.cgi?id=153822

Reviewed by Carlos Garcia Campos.

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::computeTransformsRecursive):
Use ASSERT to check that the m_children members are indeed children
of the current layer, RELEASE_ASSERT probably slipped in unnoticed
at some point.

12:33 AM Changeset in webkit [196054] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

PlatformPathCairo: Lazily allocate the path surface
https://bugs.webkit.org/show_bug.cgi?id=153821

Reviewed by Carlos Garcia Campos.

Move the static variable that holds the Cairo surface into
the pathSurface() function (previously getPathSurface). This
way the surface will only be allocated once the function is
called for the first time from the CairoPath surface.

No change in functionality, just a cleanup.

  • platform/graphics/cairo/PlatformPathCairo.cpp:

(WebCore::pathSurface):
(WebCore::CairoPath::CairoPath):
(WebCore::getPathSurface): Deleted.

12:18 AM Changeset in webkit [196053] by Carlos Garcia Campos
  • 9 edits
    3 adds in trunk/Source/WebKit2

[UNIX] Add support for windowless NPAPI plugins with no UI in non X11 platforms
https://bugs.webkit.org/show_bug.cgi?id=151992

Reviewed by Darin Adler.

We are currently disabling all plugins when running under wayland,
for example. There are some plugins, like the one used by
extensions.gnome.org, that don't do any rendering, so there's not
reason not to support those plugins under wayland or any other
unix non-x11 platform.
X11 specific code has been moved to a new class NetscapePluginX11,
only used under X11. The common code is in NetscapePluginUnix.cpp
that will use the X11 implementatin only when needed and
available. For windowed plugins we will fail the initialization
under non-X11 plaforms, while for windowless plugins we will just
return early from paint method.

  • PlatformEfl.cmake: Add new files to compilation.
  • PlatformGTK.cmake: Ditto.
  • UIProcess/API/gtk/WebKitSettings.cpp:

(webkit_settings_set_enable_plugins): Do not disable plugins in wayland.

  • UIProcess/gtk/WebPreferencesGtk.cpp:

(WebKit::WebPreferences::platformInitializeStore): Ditto.

  • WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:

(WebKit::NPN_GetValue): Use PlatformDisplay instead of
NetscapePlugin::x11HostDisplay() and don't claim to support X11
specific features under non-x11 platforms.

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::NetscapePlugin): Remove X11 and GTK
specific memebers that are now moved to a dedicated class NetscapePluginX11.

  • WebProcess/Plugins/Netscape/NetscapePlugin.h:

(WebKit::NetscapePlugin::frameRectInWindowCoordinates): Make this public.
(WebKit::NetscapePlugin::clipRect): Add getter.
(WebKit::NetscapePlugin::size): Ditto.
(WebKit::NetscapePlugin::isWindowed): Ditto.
(WebKit::NetscapePlugin::isVisible): Ditto.

  • WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.cpp: Added.

(WebKit::NetscapePlugin::platformPreInitialize):
(WebKit::NetscapePlugin::platformPostInitialize):
(WebKit::NetscapePlugin::platformDestroy):
(WebKit::NetscapePlugin::platformInvalidate):
(WebKit::NetscapePlugin::platformGeometryDidChange):
(WebKit::NetscapePlugin::platformVisibilityDidChange):
(WebKit::NetscapePlugin::platformPaint):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformSetFocus):
(WebKit::NetscapePlugin::wantsPluginRelativeNPWindowCoordinates):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
(WebKit::NetscapePlugin::platformHandleKeyboardEvent):

  • WebProcess/Plugins/Netscape/unix/NetscapePluginUnix.h: Added.

(WebKit::NetscapePluginUnix::~NetscapePluginUnix):

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:

(WebKit::getPluginDisplay):
(WebKit::displayDepth):
(WebKit::x11HostDisplay):
(WebKit::NetscapePluginX11::create):
(WebKit::NetscapePluginX11::NetscapePluginX11):
(WebKit::NetscapePluginX11::~NetscapePluginX11):
(WebKit::NetscapePluginX11::windowType):
(WebKit::NetscapePluginX11::window):
(WebKit::NetscapePluginX11::geometryDidChange):
(WebKit::NetscapePluginX11::visibilityDidChange):
(WebKit::NetscapePluginX11::paint):
(WebKit::initializeXEvent):
(WebKit::NetscapePluginX11::handleMouseEvent):
(WebKit::NetscapePluginX11::handleWheelEvent):
(WebKit::NetscapePluginX11::setFocus):
(WebKit::NetscapePluginX11::handleMouseEnterEvent):
(WebKit::NetscapePluginX11::handleMouseLeaveEvent):
(WebKit::NetscapePluginX11::handleKeyboardEvent):
(WebKit::setCommonMouseEventFields): Deleted.
(WebKit::setXKeyEventFields): Deleted.

  • WebProcess/Plugins/Netscape/x11/NetscapePluginX11.h: Added.

Feb 2, 2016:

11:01 PM Changeset in webkit [196052] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

ASSERTION FAILED: roundedIntPoint(rendererMappedResult) == roundedIntPoint(result)
https://bugs.webkit.org/show_bug.cgi?id=153576

Patch by Fujii Hironori <Hironori.Fujii@jp.sony.com> on 2016-02-02
Reviewed by Darin Adler.

Source/WebCore:

Tests: fast/block/geometry-map-assertion-with-rounding-negative-half.html

The results of roundedIntPoint of FloatPoint and LayoutPoint may be different
because of the uniqueness of LayoutUnit::round introduced by this bug
<https://bugs.webkit.org/show_bug.cgi?id=107208>.
Should convert a FloatPoint to a LayoutPoint before rounding.

  • rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::mapToContainer):

LayoutTests:

  • fast/block/geometry-map-assertion-with-rounding-negative-half-expected.txt: Added.
  • fast/block/geometry-map-assertion-with-rounding-negative-half.html: Added.
10:34 PM Changeset in webkit [196051] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk/Source/JavaScriptCore

JSSymbolTableObject::deleteProperty() crashes deleting Symbols
https://bugs.webkit.org/show_bug.cgi?id=153816

Patch by Caitlin Potter <caitp@igalia.com> on 2016-02-02
Reviewed by Darin Adler.

Changes JSSymbolTableObject::deleteProperty() to check if its
symbolTable() contains the property's uid() rather than publicName().
This ensures that it will not crash in the case of Symbols.

  • runtime/JSSymbolTableObject.cpp:

(JSC::JSSymbolTableObject::deleteProperty):

  • tests/es6/Object_static_methods_Object.getOwnPropertyDescriptors.js:

(testGlobalProxy):

  • tests/stress/regress-153816.js: Added.

(deleteSymbolFromJSSymbolTableObject):

10:31 PM Changeset in webkit [196050] by bshafiei@apple.com
  • 5 edits in tags/Safari-602.1.18.3/Source

Versioning.

10:28 PM Changeset in webkit [196049] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.18.3

New tag.

10:14 PM Changeset in webkit [196048] by mitz@apple.com
  • 6 edits in trunk/Tools

Better fix for Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
https://bugs.webkit.org/show_bug.cgi?id=153683

Reviewed by Darin Adler.

  • Scripts/webkitpy/port/driver.py:

(Driver._setup_environ_for_driver): Reverted change from r196013. DUMPRENDERTREE_TEMP is not

used by any code in the Web Content process. If that ever changed, we should send it over
as a bundle parameter.

  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.setup_environ_for_server): Reverted change from r196013.

  • Scripts/webkitpy/port/mac.py:

(MacPort.setup_environ_for_server): Ditto.

  • WebKitTestRunner/InjectedBundle/ios/InjectedBundleIOS.mm:

(WTR::InjectedBundle::platformInitialize): Set XML_CATALOG_FILES in the Web Process

environment. This is early enough that libxml2 has not been initialized yet.

  • WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:

(WTR::InjectedBundle::platformInitialize): Ditto.

10:06 PM Changeset in webkit [196047] by Darin Adler
  • 2 edits in trunk/LayoutTests

Follow up for:
Cut down on calls to String::lower; mostly replace with convertToASCIILowercase
https://bugs.webkit.org/show_bug.cgi?id=153732

  • fast/viewport/viewport-warnings-7-expected.txt: Updated expected results now that

viewport parsing doesn't lowercase the string to parse it.

10:02 PM Changeset in webkit [196046] by Gyuyoung Kim
  • 2 edits in trunk/Source/WebKit2

Remove ENABLE(GLOBAL_FASTMALLOC_NEW) guard in WebMemorySamplerLinux.cpp
https://bugs.webkit.org/show_bug.cgi?id=153812

Reviewed by Darin Adler.

r164261 already removed ENABLE_GLOBAL_FASTMALLOC_NEW guard though, WebMemorySamplerLinux
is still using it. That's why EFL and GTK memory sampler don't show fast malloc memory use.

  • Shared/linux/WebMemorySamplerLinux.cpp:

(WebKit::WebMemorySampler::sampleWebKit): Deleted.

9:03 PM Changeset in webkit [196045] by benjamin@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Do not copy FP when lowering FramePointer
https://bugs.webkit.org/show_bug.cgi?id=153769

Reviewed by Michael Saboff.

That extra move is just wasted time. The fewer Moves we have,
the happier IRC is.

  • b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::tmp):
(JSC::B3::Air::LowerToAir::lower):

8:53 PM Changeset in webkit [196044] by keith_miller@apple.com
  • 12 edits in trunk/Source/JavaScriptCore

DFG, FTL, B3, and Air should all have a unique option for printing their graphs
https://bugs.webkit.org/show_bug.cgi?id=153815

Reviewed by Benjamin Poulain.

This patch adds a new printing option for each of the DFG/FTL compilation phases.

  • b3/B3Common.cpp:

(JSC::B3::shouldDumpIR):
(JSC::B3::shouldDumpIRAtEachPhase):

  • b3/B3Common.h:
  • b3/B3Generate.cpp:

(JSC::B3::generateToAir):

  • b3/B3PhaseScope.cpp:

(JSC::B3::PhaseScope::PhaseScope):

  • b3/air/AirGenerate.cpp:

(JSC::B3::Air::prepareForGeneration):

  • b3/air/AirPhaseScope.cpp:

(JSC::B3::Air::PhaseScope::PhaseScope):

  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::run):

  • dfg/DFGCommon.h:

(JSC::DFG::shouldDumpGraphAtEachPhase):

  • dfg/DFGPhase.cpp:

(JSC::DFG::Phase::beginPhase):

  • runtime/Options.cpp:

(JSC::recomputeDependentOptions):

  • runtime/Options.h:
8:32 PM Changeset in webkit [196043] by Hunseop Jeong
  • 630 edits in trunk/LayoutTests

Unreviewed. EFL gardening: rebaseline tests after r195740.

  • platform/efl/fast/replaced/005-expected.txt:
  • platform/efl/fast/replaced/percent-height-in-anonymous-block-in-table-expected.txt:
  • platform/efl/fast/replaced/selection-rect-in-table-cell-expected.txt:
  • platform/efl/fast/replaced/table-percent-height-positioned-expected.txt:
  • platform/efl/fast/replaced/width100percent-checkbox-expected.txt:
  • platform/efl/fast/replaced/width100percent-image-expected.txt:
  • platform/efl/fast/replaced/width100percent-menulist-expected.txt:
  • platform/efl/fast/replaced/width100percent-radio-expected.txt:
  • platform/efl/fast/replaced/width100percent-searchfield-expected.txt:
  • platform/efl/fast/replaced/width100percent-textarea-expected.txt:
  • platform/efl/fast/replaced/width100percent-textfield-expected.txt:
  • platform/efl/fast/selectors/077-expected.txt:
  • platform/efl/fast/selectors/077b-expected.txt:
  • platform/efl/fast/table/002-expected.txt:
  • platform/efl/fast/table/003-expected.txt:
  • platform/efl/fast/table/005-expected.txt:
  • platform/efl/fast/table/007-expected.txt:
  • platform/efl/fast/table/008-expected.txt:
  • platform/efl/fast/table/009-expected.txt:
  • platform/efl/fast/table/012-expected.txt:
  • platform/efl/fast/table/013-expected.txt:
  • platform/efl/fast/table/021-expected.txt:
  • platform/efl/fast/table/023-expected.txt:
  • platform/efl/fast/table/024-expected.txt:
  • platform/efl/fast/table/025-expected.txt:
  • platform/efl/fast/table/028-expected.txt:
  • platform/efl/fast/table/028-vertical-expected.txt:
  • platform/efl/fast/table/029-expected.txt:
  • platform/efl/fast/table/031-expected.txt:
  • platform/efl/fast/table/032-expected.txt:
  • platform/efl/fast/table/034-expected.txt:
  • platform/efl/fast/table/038-expected.txt:
  • platform/efl/fast/table/038-vertical-expected.txt:
  • platform/efl/fast/table/039-expected.txt:
  • platform/efl/fast/table/040-expected.txt:
  • platform/efl/fast/table/040-vertical-expected.txt:
  • platform/efl/fast/table/100-percent-cell-width-expected.txt:
  • platform/efl/fast/table/add-before-anonymous-child-expected.txt:
  • platform/efl/fast/table/border-collapsing/001-expected.txt:
  • platform/efl/fast/table/border-collapsing/001-vertical-expected.txt:
  • platform/efl/fast/table/border-collapsing/002-expected.txt:
  • platform/efl/fast/table/border-collapsing/003-expected.txt:
  • platform/efl/fast/table/border-collapsing/003-vertical-expected.txt:
  • platform/efl/fast/table/border-collapsing/004-expected.txt:
  • platform/efl/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/efl/fast/table/border-collapsing/border-collapsing-head-foot-expected.txt:
  • platform/efl/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt:
  • platform/efl/fast/table/border-collapsing/bug14274-expected.txt:
  • platform/efl/fast/table/border-collapsing/cached-69296-expected.txt:
  • platform/efl/fast/table/border-collapsing/cached-cell-append-expected.txt:
  • platform/efl/fast/table/border-collapsing/cached-cell-remove-expected.txt:
  • platform/efl/fast/table/border-collapsing/cached-change-cell-border-color-expected.txt:
  • platform/efl/fast/table/border-collapsing/cached-change-cell-border-width-expected.txt:
  • platform/efl/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.txt:
  • platform/efl/fast/table/border-collapsing/cached-change-col-border-color-expected.txt:
  • platform/efl/fast/table/border-collapsing/cached-change-col-border-width-expected.txt:
  • platform/efl/fast/table/border-collapsing/cached-change-colgroup-border-color-expected.txt:
  • platform/efl/fast/table/border-collapsing/cached-change-colgroup-border-width-expected.txt:
  • platform/efl/fast/table/border-collapsing/cached-change-row-border-color-expected.txt:
  • platform/efl/fast/table/border-collapsing/cached-change-row-border-width-expected.txt:
  • platform/efl/fast/table/border-collapsing/cached-change-table-border-color-expected.txt:
  • platform/efl/fast/table/border-collapsing/cached-change-table-border-width-expected.txt:
  • platform/efl/fast/table/border-collapsing/cached-change-tbody-border-color-expected.txt:
  • platform/efl/fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl-expected.txt:
  • platform/efl/fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells-expected.txt:
  • platform/efl/fast/table/border-collapsing/equal-precedence-resolution-expected.txt:
  • platform/efl/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.txt:
  • platform/efl/fast/table/border-collapsing/rtl-border-collapsing-expected.txt:
  • platform/efl/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt:
  • platform/efl/fast/table/caption-relayout-expected.txt:
  • platform/efl/fast/table/cell-absolute-child-expected.txt:
  • platform/efl/fast/table/cell-width-auto-expected.txt:
  • platform/efl/fast/table/colspan-with-all-percent-cells-expected.txt:
  • platform/efl/fast/table/colspanMinWidth-expected.txt:
  • platform/efl/fast/table/colspanMinWidth-vertical-expected.txt:
  • platform/efl/fast/table/dynamic-cellpadding-expected.txt:
  • platform/efl/fast/table/edge-offsets-expected.txt:
  • platform/efl/fast/table/empty-cells-expected.txt:
  • platform/efl/fast/table/frame-and-rules-expected.txt:
  • platform/efl/fast/table/giantRowspan-expected.txt:
  • platform/efl/fast/table/growCellForImageQuirk-expected.txt:
  • platform/efl/fast/table/growCellForImageQuirk-vertical-expected.txt:
  • platform/efl/fast/table/height-percent-test-expected.txt:
  • platform/efl/fast/table/height-percent-test-vertical-expected.txt:
  • platform/efl/fast/table/invisible-cell-background-expected.txt:
  • platform/efl/fast/table/large-width-expected.txt:
  • platform/efl/fast/table/max-width-integer-overflow-expected.txt:
  • platform/efl/fast/table/mozilla-bug10296-vertical-align-1-expected.txt:
  • platform/efl/fast/table/mozilla-bug10296-vertical-align-2-expected.txt:
  • platform/efl/fast/table/nobr-expected.txt:
  • platform/efl/fast/table/overflowHidden-expected.txt:
  • platform/efl/fast/table/percent-heights-expected.txt:
  • platform/efl/fast/table/percent-widths-stretch-expected.txt:
  • platform/efl/fast/table/percent-widths-stretch-vertical-expected.txt:
  • platform/efl/fast/table/prepend-in-anonymous-table-expected.txt:
  • platform/efl/fast/table/relative-position-containment-expected.txt:
  • platform/efl/fast/table/relative-position-offsets-expected.txt:
  • platform/efl/fast/table/relative-position-stacking-expected.txt:
  • platform/efl/fast/table/replaced-percent-height-expected.txt:
  • platform/efl/fast/table/row-height-recalc-expected.txt:
  • platform/efl/fast/table/rowspan-paint-order-expected.txt:
  • platform/efl/fast/table/rowspan-paint-order-vertical-expected.txt:
  • platform/efl/fast/table/simple_paint-expected.txt:
  • platform/efl/fast/table/spanOverlapRepaint-expected.txt:
  • platform/efl/fast/table/stale-grid-crash-expected.txt:
  • platform/efl/fast/table/table-anonymous-cell-bug-expected.txt:
  • platform/efl/fast/table/table-anonymous-row-bug-expected.txt:
  • platform/efl/fast/table/table-anonymous-section-bug-expected.txt:
  • platform/efl/fast/table/table-before-child-style-update-expected.txt:
  • platform/efl/fast/table/table-cell-before-after-content-around-table-block-expected.txt:
  • platform/efl/fast/table/table-cell-before-after-content-around-table-expected.txt:
  • platform/efl/fast/table/table-cell-before-after-content-around-table-row-expected.txt:
  • platform/efl/fast/table/table-cell-before-child-in-table-expected.txt:
  • platform/efl/fast/table/table-cell-split-expected.txt:
  • platform/efl/fast/table/table-display-types-expected.txt:
  • platform/efl/fast/table/table-display-types-strict-expected.txt:
  • platform/efl/fast/table/table-display-types-vertical-expected.txt:
  • platform/efl/fast/table/table-insert-before-non-anonymous-block-expected.txt:
  • platform/efl/fast/table/table-row-before-after-content-around-block-expected.txt:
  • platform/efl/fast/table/table-row-before-after-content-around-table-cell-expected.txt:
  • platform/efl/fast/table/table-row-before-after-content-around-table-expected.txt:
  • platform/efl/fast/table/table-row-before-child-style-update-expected.txt:
  • platform/efl/fast/table/table-row-outline-paint-expected.txt:
  • platform/efl/fast/table/table-row-split2-expected.txt:
  • platform/efl/fast/table/table-row-style-not-updated-expected.txt:
  • platform/efl/fast/table/table-row-style-not-updated-with-after-content-expected.txt:
  • platform/efl/fast/table/table-row-style-not-updated-with-before-content-expected.txt:
  • platform/efl/fast/table/table-section-split2-expected.txt:
  • platform/efl/fast/table/table-split-expected.txt:
  • platform/efl/fast/table/table-split2-expected.txt:
  • platform/efl/fast/table/table-style-not-updated-expected.txt:
  • platform/efl/fast/table/wide-colspan-expected.txt:
  • platform/efl/fast/table/wide-column-expected.txt:
  • platform/efl/fast/text/atsui-negative-spacing-features-expected.txt:
  • platform/efl/fast/text/atsui-spacing-features-expected.txt:
  • platform/efl/fast/text/basic/generic-family-reset-expected.txt:
  • platform/efl/fast/text/international/003-expected.txt:
  • platform/efl/fast/text/international/bidi-LDB-2-CSS-expected.txt:
  • platform/efl/fast/text/international/bidi-LDB-2-HTML-expected.txt:
  • platform/efl/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
  • platform/efl/fast/text/international/bidi-override-expected.txt:
  • platform/efl/fast/text/wbr-expected.txt:
  • platform/efl/fast/text/whitespace/002-expected.txt:
  • platform/efl/fast/text/whitespace/003-expected.txt:
  • platform/efl/fast/text/whitespace/004-expected.txt:
  • platform/efl/fast/text/whitespace/005-expected.txt:
  • platform/efl/fast/text/whitespace/010-expected.txt:
  • platform/efl/fast/text/whitespace/011-expected.txt:
  • platform/efl/fast/text/whitespace/013-expected.txt:
  • platform/efl/fast/text/whitespace/014-expected.txt:
  • platform/efl/fast/text/whitespace/015-expected.txt:
  • platform/efl/fast/text/whitespace/016-expected.txt:
  • platform/efl/fast/text/whitespace/025-expected.txt:
  • platform/efl/fast/text/whitespace/026-expected.txt:
  • platform/efl/fast/writing-mode/table-percent-width-quirk-expected.txt:
  • platform/efl/fast/writing-mode/vertical-align-table-baseline-expected.txt:
  • platform/efl/http/tests/misc/acid2-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/background_properties_greater_than_images-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-006-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-007-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-008-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-009-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-011-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-012-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-013-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-014-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-015-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-applies-to-016-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-shorthand-001-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-001-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-left-radius-values-004-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/border-top-right-radius-values-004-expected.txt:
  • platform/efl/ietestcenter/css3/bordersbackgrounds/none-as-image-layer-expected.txt:
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
  • platform/efl/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
  • platform/efl/tables/layering/paint-test-layering-1-expected.txt:
  • platform/efl/tables/layering/paint-test-layering-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug10009-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug10036-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug101201-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug101674-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug10296-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug1055-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug10565-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug10633-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug1067-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug1067-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug106795-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug106816-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug113235-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug113424-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug1163-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug1188-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug12008-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug120107-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug120364-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug1224-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug12268-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug12709-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug1271-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug12908-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug12908-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug1296-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug1302-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug13169-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug1318-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug137388-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug137388-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug137388-3-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug139524-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug139524-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug139524-3-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug139524-4-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug1430-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug14323-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug14929-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug15247-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug154780-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug15544-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug159108-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug15933-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug16012-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug16252-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug17138-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug175455-4-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug17548-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug17587-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug1800-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug1802-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug1802s-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug1809-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug18440-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug18664-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug18955-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug19061-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug19061-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug19356-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug20804-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug2123-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug215629-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug219693-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug219693-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug22019-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug220536-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug222336-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug22246-3-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug22246-3a-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug22513-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug2296-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug23235-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug2479-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug2479-3-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug25004-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug25074-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug25663-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug26553-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug2684-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug269566-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug277062-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug2773-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug27993-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug2886-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug28933-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug29058-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug29314-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug29429-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug2954-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug2981-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug2981-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug2997-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug30273-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug30559-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug3103-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug32205-3-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug3260-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug33137-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug3454-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug38916-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug3977-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug4093-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug42187-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug4385-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug4427-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug4501-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug4527-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug45350-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug45486-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug4576-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug46268-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug46268-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug46623-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug46623-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug47432-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug4803-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug4849-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug4849-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug5188-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug52505-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug52506-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug53690-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug53690-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug53891-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug5538-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug55789-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug56201-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug57828-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug5797-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug5835-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug60804-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug60807-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug6184-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug6304-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug6404-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug647-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug6674-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug68998-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug69382-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug69382-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug72359-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug7342-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug7714-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug78162-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug82946-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug86708-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug8950-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug9123-1-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug9123-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug92143-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug92647-2-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug963-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug97383-expected.txt:
  • platform/efl/tables/mozilla/bugs/bug9879-1-expected.txt:
  • platform/efl/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
  • platform/efl/tables/mozilla/core/bloomberg-expected.txt:
  • platform/efl/tables/mozilla/core/borders-expected.txt:
  • platform/efl/tables/mozilla/core/cell_heights-expected.txt:
  • platform/efl/tables/mozilla/core/col_span-expected.txt:
  • platform/efl/tables/mozilla/core/col_widths_auto_autoFix-expected.txt:
  • platform/efl/tables/mozilla/core/col_widths_auto_autoFixPer-expected.txt:
  • platform/efl/tables/mozilla/core/col_widths_auto_fix-expected.txt:
  • platform/efl/tables/mozilla/core/col_widths_auto_fixPer-expected.txt:
  • platform/efl/tables/mozilla/core/col_widths_auto_per-expected.txt:
  • platform/efl/tables/mozilla/core/col_widths_fix_autoFix-expected.txt:
  • platform/efl/tables/mozilla/core/col_widths_fix_fix-expected.txt:
  • platform/efl/tables/mozilla/core/col_widths_fix_fixPer-expected.txt:
  • platform/efl/tables/mozilla/core/col_widths_fix_per-expected.txt:
  • platform/efl/tables/mozilla/core/margins-expected.txt:
  • platform/efl/tables/mozilla/core/misc-expected.txt:
  • platform/efl/tables/mozilla/core/nested1-expected.txt:
  • platform/efl/tables/mozilla/core/one_row-expected.txt:
  • platform/efl/tables/mozilla/core/table_frame-expected.txt:
  • platform/efl/tables/mozilla/core/table_heights-expected.txt:
  • platform/efl/tables/mozilla/core/table_rules-expected.txt:
  • platform/efl/tables/mozilla/core/table_widths-expected.txt:
  • platform/efl/tables/mozilla/dom/insertColGroups1-expected.txt:
  • platform/efl/tables/mozilla/dom/insertColGroups2-expected.txt:
  • platform/efl/tables/mozilla/dom/insertCols1-expected.txt:
  • platform/efl/tables/mozilla/dom/insertCols2-expected.txt:
  • platform/efl/tables/mozilla/dom/insertCols3-expected.txt:
  • platform/efl/tables/mozilla/dom/insertCols4-expected.txt:
  • platform/efl/tables/mozilla/dom/insertCols5-expected.txt:
  • platform/efl/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • platform/efl/tables/mozilla/marvin/backgr_position-table-expected.txt:
  • platform/efl/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • platform/efl/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • platform/efl/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • platform/efl/tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • platform/efl/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.png:
  • platform/efl/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • platform/efl/tables/mozilla/marvin/colgroup_align_center-expected.txt:
  • platform/efl/tables/mozilla/marvin/colgroup_align_justify-expected.txt:
  • platform/efl/tables/mozilla/marvin/colgroup_align_left-expected.txt:
  • platform/efl/tables/mozilla/marvin/colgroup_align_right-expected.txt:
  • platform/efl/tables/mozilla/marvin/colgroup_span-expected.txt:
  • platform/efl/tables/mozilla/marvin/colgroup_valign_baseline-expected.txt:
  • platform/efl/tables/mozilla/marvin/colgroup_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/colgroup_valign_middle-expected.txt:
  • platform/efl/tables/mozilla/marvin/colgroup_valign_top-expected.txt:
  • platform/efl/tables/mozilla/marvin/colgroup_width_pct-expected.txt:
  • platform/efl/tables/mozilla/marvin/colgroup_width_px-expected.txt:
  • platform/efl/tables/mozilla/marvin/table_overflow_hidden_td-expected.txt:
  • platform/efl/tables/mozilla/marvin/table_overflow_td_dynamic_deactivate-expected.txt:
  • platform/efl/tables/mozilla/marvin/table_row_align_center-expected.txt:
  • platform/efl/tables/mozilla/marvin/table_row_align_left-expected.txt:
  • platform/efl/tables/mozilla/marvin/table_row_align_right-expected.txt:
  • platform/efl/tables/mozilla/marvin/table_rules_groups-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_aqua-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_aqua_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_black-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_black_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_blue-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_blue_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_fuchsia-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_fuchsia_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_gray-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_gray_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_green-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_green_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_lime-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_lime_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_maroon-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_maroon_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_navy-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_navy_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_olive-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_olive_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_purple-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_purple_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_red-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_red_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_silver-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_silver_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_teal-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_teal_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_white-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_white_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_yellow-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_bgcolor_yellow_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_cellpadding-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_cellpadding_pct-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_td_width-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_th_width-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_width_percent-expected.txt:
  • platform/efl/tables/mozilla/marvin/tables_width_px-expected.txt:
  • platform/efl/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
  • platform/efl/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
  • platform/efl/tables/mozilla/marvin/tbody_valign_top-expected.txt:
  • platform/efl/tables/mozilla/marvin/td_valign_baseline-expected.txt:
  • platform/efl/tables/mozilla/marvin/td_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/td_valign_middle-expected.txt:
  • platform/efl/tables/mozilla/marvin/td_valign_top-expected.txt:
  • platform/efl/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
  • platform/efl/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
  • platform/efl/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
  • platform/efl/tables/mozilla/marvin/th_valign_baseline-expected.txt:
  • platform/efl/tables/mozilla/marvin/th_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/th_valign_middle-expected.txt:
  • platform/efl/tables/mozilla/marvin/th_valign_top-expected.txt:
  • platform/efl/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
  • platform/efl/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/thead_valign_middle-expected.txt:
  • platform/efl/tables/mozilla/marvin/thead_valign_top-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_black-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_blue-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_gray-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_green-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_lime-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_maroon-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_navy-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_olive-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_purple-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_red-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_silver-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_teal-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_white-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_yellow-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_valign_baseline-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_valign_middle-expected.txt:
  • platform/efl/tables/mozilla/marvin/tr_valign_top-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_col_align_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_col_span-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_col_valign_baseline-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_col_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_col_valign_middle-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_col_valign_top-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_col_width_px-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_col_width_rel-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_colgroup_align_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_colgroup_span-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_colgroup_valign_middle-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_colgroup_valign_top-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_colgroup_width_rel-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_td_align_center-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_td_align_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_td_align_justify-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_td_align_left-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_td_align_right-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_td_valign_baseline-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_td_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_td_valign_middle-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_td_valign_top-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_td_width-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_th_align_center-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_th_align_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_th_align_justify-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_th_align_left-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_th_align_right-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_th_rowspan-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_th_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_th_valign_middle-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_th_valign_top-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_th_width-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tr_align_char-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tr_valign_baseline-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tr_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tr_valign_middle-expected.txt:
  • platform/efl/tables/mozilla/marvin/x_tr_valign_top-expected.txt:
  • platform/efl/tables/mozilla/other/cell_widths-expected.txt:
  • platform/efl/tables/mozilla/other/ms-expected.txt:
  • platform/efl/tables/mozilla/other/nested2-expected.txt:
  • platform/efl/tables/mozilla/other/nestedTables-expected.txt:
  • platform/efl/tables/mozilla/other/slashlogo-expected.txt:
  • platform/efl/tables/mozilla/other/test3-expected.txt:
  • platform/efl/tables/mozilla/other/test6-expected.txt:
  • platform/efl/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • platform/efl/tables/mozilla/other/wa_table_tr_align-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/97619-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1164-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug128876-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug14007-1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1647-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug17826-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug27993-2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug3105-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug80762-2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/bugs/bug9879-1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/core/col_span2-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/core/cols1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/core/columns-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/core/standards1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_td_dynamic_deactivate-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
  • platform/efl/tables/mozilla_expected_failures/other/test4-expected.txt:
8:22 PM Changeset in webkit [196042] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[JSC] make Object.getOwnPropertyDescriptors() work with non-JSObject types
https://bugs.webkit.org/show_bug.cgi?id=153814

Patch by Caitlin Potter <caitp@igalia.com> on 2016-02-02
Reviewed by Yusuke Suzuki.

  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetOwnPropertyDescriptors):

  • tests/es6/Object_static_methods_Object.getOwnPropertyDescriptors.js:

(testGlobalProxy):

8:16 PM Changeset in webkit [196041] by aakash_jain@apple.com
  • 4 edits
    1 delete in trunk/Source

Remove references to CallFrameInlines.h
https://bugs.webkit.org/show_bug.cgi?id=153810

Reviewed by Mark Lam.

Source/JavaScriptCore:

Source/WebCore:

  • ForwardingHeaders/interpreter/CallFrameInlines.h: Removed.
7:17 PM Changeset in webkit [196040] by commit-queue@webkit.org
  • 7 edits
    2 adds in trunk

[JSC] Implement Object.getOwnPropertyDescriptors() proposal
https://bugs.webkit.org/show_bug.cgi?id=153799

Patch by Caitlin Potter <caitp@igalia.com> on 2016-02-02
Reviewed by Darin Adler.

Source/JavaScriptCore:

Implements the Object.getOwnPropertyDescriptors() proposal, which
reached Stage 3 in the TC39 process in January 2016.
https://github.com/tc39/proposal-object-getownpropertydescriptors

The method extracts a set of property descriptor objects, which can
be safely used via Object.create().

  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorGetOwnPropertyDescriptors):

LayoutTests:

  • js/Object-getOwnPropertyNames-expected.txt:
  • js/script-tests/Object-getOwnPropertyNames.js:
6:27 PM Changeset in webkit [196039] by hur.ims@navercorp.com
  • 3 edits in trunk/Source/WebCore

WEBGL_debug_shaders should be disabled for OpenGLES backend also
https://bugs.webkit.org/show_bug.cgi?id=153788

Reviewed by Darin Adler.

WEBGL_debug_shaders extension is disabled for OpenGL backed platform
because the implementation is not fully compliant to the spec yet.
Because this is not an OpenGL-specific problem, WEBGL_debug_shaders extension
should be disabled for OpenGLES backed platforms also.

No new tests, already covered by existing tests.

  • platform/graphics/opengl/Extensions3DOpenGL.cpp:

(WebCore::Extensions3DOpenGL::supportsExtension): Deleted.

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::supports):

4:12 PM Changeset in webkit [196038] by beidson@apple.com
  • 5 edits in trunk

Modern IDB: storage/indexeddb/cursor-primary-key-order.html fails with SQLite backend.
https://bugs.webkit.org/show_bug.cgi?id=153800

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (Existing tests now unskipped).

The IndexRecords SQL schema did not order things by primaryKey.

Easy fix to the schema. Sadly requires a migration...

  • Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::v1IndexRecordsTableSchema):
(WebCore::IDBServer::v1IndexRecordsTableSchemaAlternate):
(WebCore::IDBServer::v2IndexRecordsTableSchema):
(WebCore::IDBServer::v2IndexRecordsTableSchemaAlternate):
(WebCore::IDBServer::SQLiteIDBBackingStore::ensureValidIndexRecordsTable):
(WebCore::IDBServer::SQLiteIDBBackingStore::createAndPopulateInitialDatabaseInfo):

  • Modules/indexeddb/server/SQLiteIDBBackingStore.h:

LayoutTests:

  • platform/mac-wk1/TestExpectations:
4:09 PM Changeset in webkit [196037] by enrica@apple.com
  • 3 edits in trunk/Source/WebKit2

Provide handleKeyWebEvent with completion handler.
https://bugs.webkit.org/show_bug.cgi?id=153806
rdar://problem/24399218

Reviewed by Tim Horton.

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView handleKeyWebEvent:withCompletionHandler:]):
(-[WKContentView _didHandleKeyEvent:eventWasHandled:]):

4:08 PM Changeset in webkit [196036] by timothy_horton@apple.com
  • 5 edits
    2 adds in trunk

<attachment> should attempt to guess the icon from the file extension if all else fails
https://bugs.webkit.org/show_bug.cgi?id=153804
<rdar://problem/24448146>

Reviewed by Anders Carlsson.

Source/WebCore:

Test: fast/attachment/attachment-icon-from-file-extension.html

  • platform/graphics/Icon.h:
  • platform/graphics/mac/IconMac.mm:

(WebCore::Icon::createIconForFileExtension):

  • rendering/RenderThemeMac.mm:

(WebCore::iconForAttachment):
If we can't find an icon any other way, try assuming that the title is a filename,
grab its extension, and have NSWorkspace try to work out an icon for it.

LayoutTests:

  • fast/attachment/attachment-icon-from-file-extension-expected.html: Added.
  • fast/attachment/attachment-icon-from-file-extension.html: Added.
3:46 PM Changeset in webkit [196035] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

B3 should be able to compile trivial self-loops
https://bugs.webkit.org/show_bug.cgi?id=153802
rdar://problem/24465632

Reviewed by Michael Saboff.

Tail-duplicating a self-loop would mean doing a kind of loop unrolling. It wouldn't be
profitable even if it did work. It turns out that it doesn't work, because we edit the target
block before reading the source block, which breaks if the target and source block are the
same.

This disables tail duplication of self-loops, adds a test, and adds better validation for this
issue.

  • b3/B3DuplicateTails.cpp:
  • b3/B3Procedure.cpp:

(JSC::B3::Procedure::resetReachability):

  • b3/testb3.cpp:

(JSC::B3::testComputeDivisionMagic):
(JSC::B3::testTrivialInfiniteLoop):
(JSC::B3::zero):
(JSC::B3::run):

3:42 PM Changeset in webkit [196034] by achristensen@apple.com
  • 6 edits in trunk/Source/WebKit2

Fix authentication with NetworkSession
https://bugs.webkit.org/show_bug.cgi?id=153779

Reviewed by Brady Eidson.

This fixes many tests, including http/tests/xmlhttprequest/cross-origin-authorization.html.

  • NetworkProcess/NetworkLoad.cpp:

(WebKit::NetworkLoad::NetworkLoad):
NetworkingContexts are not used with NetworkSession. NetworkSession is used instead.
Pass allowStoredCredentials to the NetworkLoad so it knows whether to use a session with credential storage or not.
(WebKit::NetworkLoad::didReceiveChallenge):
Always call continueCanAuthenticateAgainstProtectionSpace because we might need credentials for synchronous requests.
(WebKit::NetworkLoad::continueCanAuthenticateAgainstProtectionSpace):
Reject the protection space if we cannot authenticate against this protection space.
If the protection space is not password-based (such as ServerTrustEvaluationRequested) and we can authenticate against this protection space,
then perform default handling instead of asking the UI process for a password, which wouldn't mean anything.

  • NetworkProcess/NetworkLoad.h:
  • NetworkProcess/NetworkSession.h:

Use a NSURLSession with configuration.URLCredentialStorage = nil but with the same cookie storage for requests without credentials.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSession::NetworkSession):
(WebKit::NetworkSession::~NetworkSession):
(WebKit::NetworkSession::dataTaskForIdentifier):
(WebKit::NetworkSession::takeDownloadID):
(WebKit::NetworkDataTask::NetworkDataTask):

  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::canAuthenticateAgainstProtectionSpace):
Always send a reply message so we can always do the callbacks of NSURLSession delegates.

3:26 PM Changeset in webkit [196033] by sbarati@apple.com
  • 11 edits in trunk

[ES6] bound functions .name property should be "bound " + the target function's name
https://bugs.webkit.org/show_bug.cgi?id=153796

Reviewed by Mark Lam.

Source/JavaScriptCore:

See http://tc39.github.io/ecma262/#sec-function.prototype.bind for details.
What the spec says:
`
function foo() { }
foo.bind(null).name === "bound foo"

(function bar() { }).bind(null).name === "bound bar"
`

  • runtime/FunctionPrototype.cpp:

(JSC::functionProtoFuncToString):

  • runtime/JSBoundFunction.cpp:

(JSC::hasInstanceBoundFunction):
(JSC::JSBoundFunction::create):
(JSC::JSBoundFunction::visitChildren):
(JSC::JSBoundFunction::toStringName):

  • runtime/JSBoundFunction.h:

(JSC::JSBoundFunction::boundThis):
(JSC::JSBoundFunction::boundArgs):
(JSC::JSBoundFunction::createStructure):

  • tests/es6.yaml:

LayoutTests:

  • inspector/runtime/getProperties-expected.txt:
  • platform/mac/http/tests/media/media-source/SourceBuffer-abort-readyState-expected.txt:
  • platform/mac/http/tests/media/media-source/SourceBuffer-abort-removed-expected.txt:
  • platform/mac/http/tests/media/media-source/SourceBuffer-abort-updating-expected.txt:
  • platform/mac/http/tests/media/media-source/mediasource-sourcebuffer-mode-expected.txt:
3:21 PM Changeset in webkit [196032] by fpizlo@apple.com
  • 62 edits
    2 moves
    5 adds in trunk

Get rid of anonymous stack slots
https://bugs.webkit.org/show_bug.cgi?id=151128

Reviewed by Mark Lam.

Source/JavaScriptCore:

When I first designed stack slots, the idea was that an "anonymous" stack slot was one that
behaved exactly like a C variable: if it never escaped, it would not need to get stack space
for the entire lifetime of the function - it could get any slab of stack so long as it
didn't interfere with other stack slots that would be live at the same time. The reason I
called them "anonymous" is that external code could not get its address. This felt like it
gave the stack slot anonymity. But it was never a good name for this concept.

Then I had the register allocator lower temporaries to anonymous stack slots when it spilled
them. Spilling became the sole client of anonymous stack slots.

Then I realized that there was an aspect of how spill slots work that make them want
slightly different semantics than a normal C variable. A C variable is a proper memory
location - you could do a store to only some bytes in the variable, and it's reasonable to
expect that this will not destroy the other bytes in the variable. But that means that to
compute their liveness, you have to do something like a per-byte liveness. That's overkill
for spill slots. You want any store to the spill slot to kill the whole slot even if it
writes to just part of the slot. This matches how temporaries work. So rather than implement
per-byte liveness, I decided to change the semantics of anonymous stack slots to make them
work like how I wanted spill slots to work. This was quite dirty, and put B3 in the awkward
situation that B3's anonymous stack slots behaved like spill slots. But it was OK since
nobody used anonymous stack slots in B3.

Then I added tail duplication, which required having a mechanism for introducing non-SSA
variables in B3. I decided to use anonymous stack slots for this purpose. All of a sudden
this all felt like it made sense: anonymous stack slots were just like variables! Hooray for
the amazing foresight of anonymous stack slots!

But then I realized that this was all very bad. We want B3 to be able to optimize Store and
Load operations by reasoning about how they affect bytes in memory. For example, if you do
a Load of a 64-bit value, and then you modify just the low 32 bits of that value, and then
you do a 64-bit store back to the same location, then it would be better to transform this
into 32-bit operations. We don't do this optimization yet, but it's the kind of thing that
we want B3 to be able to do. To do it, we need Store to mean that it only affects N bytes
starting at the pointer, where N is the size of the thing being stored. But that's not what
Store means for anonymous stack slots. For anonymous slots, storing to any byte in the slot
clobbers all bytes in the slot. We were never clear if you need to store directly to an
anonymous slot to get this behavior, or if any pointer that points to an anoymous slot must
exhibit this behavior when stored to. Neither kinds of semantics make sense to me.

This change fixes the problem by eradicating anonymous stack slots. In B3, they are replaced
with Variables. In Air, they are replaced with a different stack slot kind, called Spill.
There is no such thing as stack slot kinds in B3 anymore, all B3 stack slots are locked. In
Air, there is still the concept of stack slot kind - Locked or Spill.

B3 Variables are awesome. They are exactly what they seem to be. They have a type. They are
declared at the top level in the Procedure. You can access them with new opcodes, Get and
Set. This greatly simplifies demoting SSA values to variables and promoting them back to
SSA. I even made the instruction selector do the right things for variables, which means
that introducing variables won't hurt instruction selection (there will be extra moves, but
IRC will kill them). It's great to have non-SSA variables as an explicit concept in IR
because it means that you don't have to do any magic to use them - they Just Work.

Air spill slots behave almost like anonymous stack slots, with one exception: you cannot
escape them. We validate this by making it illegal to UseAddr on a spill slot. This removes
the need to answer awkward questions like: does a 32-bit Def on a pointer that may point to
a 64-bit spill slot do anything to the 32 bits above the pointer? Does it write zero to it?
Does it write zero to it just when the pointer actually points to a spill slot or always?
These are silly questions, and we don't have to answer them because the only way to refer to
a spill slot is directly. No escaping means no aliasing.

This doesn't affect performance. It just makes the compiler more fun to work with by
removing some cognitive dissonance.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • b3/B3ArgumentRegValue.h:
  • b3/B3CCallValue.h:
  • b3/B3CheckValue.cpp:

(JSC::B3::CheckValue::cloneImpl):
(JSC::B3::CheckValue::CheckValue):

  • b3/B3CheckValue.h:
  • b3/B3Const32Value.h:
  • b3/B3Const64Value.h:
  • b3/B3ConstDoubleValue.h:
  • b3/B3ConstFloatValue.h:
  • b3/B3ConstPtrValue.h:

(JSC::B3::ConstPtrValue::ConstPtrValue):

  • b3/B3ControlValue.cpp:

(JSC::B3::ControlValue::convertToJump):
(JSC::B3::ControlValue::convertToOops):
(JSC::B3::ControlValue::dumpMeta):

  • b3/B3ControlValue.h:
  • b3/B3Effects.cpp:

(JSC::B3::Effects::interferes):
(JSC::B3::Effects::dump):

  • b3/B3Effects.h:

(JSC::B3::Effects::mustExecute):

  • b3/B3EliminateCommonSubexpressions.cpp:
  • b3/B3FixSSA.cpp:

(JSC::B3::demoteValues):
(JSC::B3::fixSSA):

  • b3/B3FixSSA.h:
  • b3/B3IndexMap.h:

(JSC::B3::IndexMap::resize):
(JSC::B3::IndexMap::clear):
(JSC::B3::IndexMap::size):
(JSC::B3::IndexMap::operator[]):

  • b3/B3IndexSet.h:

(JSC::B3::IndexSet::contains):
(JSC::B3::IndexSet::size):
(JSC::B3::IndexSet::isEmpty):

  • b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::run):
(JSC::B3::Air::LowerToAir::lower):

  • b3/B3MemoryValue.h:
  • b3/B3Opcode.cpp:

(WTF::printInternal):

  • b3/B3Opcode.h:
  • b3/B3PatchpointValue.cpp:

(JSC::B3::PatchpointValue::cloneImpl):
(JSC::B3::PatchpointValue::PatchpointValue):

  • b3/B3PatchpointValue.h:
  • b3/B3Procedure.cpp:

(JSC::B3::Procedure::Procedure):
(JSC::B3::Procedure::addBlock):
(JSC::B3::Procedure::addStackSlot):
(JSC::B3::Procedure::addVariable):
(JSC::B3::Procedure::clone):
(JSC::B3::Procedure::addIntConstant):
(JSC::B3::Procedure::dump):
(JSC::B3::Procedure::deleteStackSlot):
(JSC::B3::Procedure::deleteVariable):
(JSC::B3::Procedure::deleteValue):
(JSC::B3::Procedure::deleteOrphans):
(JSC::B3::Procedure::calleeSaveRegisters):
(JSC::B3::Procedure::addValueImpl):
(JSC::B3::Procedure::setBlockOrderImpl):
(JSC::B3::Procedure::addAnonymousStackSlot): Deleted.
(JSC::B3::Procedure::addStackSlotIndex): Deleted.
(JSC::B3::Procedure::addValueIndex): Deleted.

  • b3/B3Procedure.h:

(JSC::B3::Procedure::setBlockOrder):
(JSC::B3::Procedure::stackSlots):
(JSC::B3::Procedure::variables):
(JSC::B3::Procedure::values):
(JSC::B3::Procedure::StackSlotsCollection::StackSlotsCollection): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::size): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::at): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::operator[]): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::iterator::iterator): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::iterator::operator*): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::iterator::operator++): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::iterator::operator==): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::iterator::operator!=): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::iterator::findNext): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::begin): Deleted.
(JSC::B3::Procedure::StackSlotsCollection::end): Deleted.
(JSC::B3::Procedure::ValuesCollection::ValuesCollection): Deleted.
(JSC::B3::Procedure::ValuesCollection::iterator::iterator): Deleted.
(JSC::B3::Procedure::ValuesCollection::iterator::operator*): Deleted.
(JSC::B3::Procedure::ValuesCollection::iterator::operator++): Deleted.
(JSC::B3::Procedure::ValuesCollection::iterator::operator==): Deleted.
(JSC::B3::Procedure::ValuesCollection::iterator::operator!=): Deleted.
(JSC::B3::Procedure::ValuesCollection::iterator::findNext): Deleted.
(JSC::B3::Procedure::ValuesCollection::begin): Deleted.
(JSC::B3::Procedure::ValuesCollection::end): Deleted.
(JSC::B3::Procedure::ValuesCollection::size): Deleted.
(JSC::B3::Procedure::ValuesCollection::at): Deleted.
(JSC::B3::Procedure::ValuesCollection::operator[]): Deleted.

  • b3/B3ProcedureInlines.h:

(JSC::B3::Procedure::add):

  • b3/B3ReduceStrength.cpp:
  • b3/B3SlotBaseValue.h:
  • b3/B3SparseCollection.h: Added.

(JSC::B3::SparseCollection::SparseCollection):
(JSC::B3::SparseCollection::add):
(JSC::B3::SparseCollection::addNew):
(JSC::B3::SparseCollection::remove):
(JSC::B3::SparseCollection::size):
(JSC::B3::SparseCollection::isEmpty):
(JSC::B3::SparseCollection::at):
(JSC::B3::SparseCollection::operator[]):
(JSC::B3::SparseCollection::iterator::iterator):
(JSC::B3::SparseCollection::iterator::operator*):
(JSC::B3::SparseCollection::iterator::operator++):
(JSC::B3::SparseCollection::iterator::operator==):
(JSC::B3::SparseCollection::iterator::operator!=):
(JSC::B3::SparseCollection::iterator::findNext):
(JSC::B3::SparseCollection::begin):
(JSC::B3::SparseCollection::end):

  • b3/B3StackSlot.cpp:

(JSC::B3::StackSlot::deepDump):
(JSC::B3::StackSlot::StackSlot):

  • b3/B3StackSlot.h:

(JSC::B3::StackSlot::byteSize):
(JSC::B3::StackSlot::index):
(JSC::B3::StackSlot::setOffsetFromFP):
(JSC::B3::StackSlot::kind): Deleted.
(JSC::B3::StackSlot::isLocked): Deleted.

  • b3/B3StackSlotKind.cpp: Removed.
  • b3/B3StackSlotKind.h: Removed.
  • b3/B3StackmapValue.cpp:

(JSC::B3::StackmapValue::dumpMeta):
(JSC::B3::StackmapValue::StackmapValue):

  • b3/B3StackmapValue.h:
  • b3/B3SwitchValue.cpp:

(JSC::B3::SwitchValue::cloneImpl):
(JSC::B3::SwitchValue::SwitchValue):

  • b3/B3SwitchValue.h:
  • b3/B3UpsilonValue.h:
  • b3/B3Validate.cpp:
  • b3/B3Value.cpp:

(JSC::B3::Value::replaceWithIdentity):
(JSC::B3::Value::replaceWithNop):
(JSC::B3::Value::replaceWithPhi):
(JSC::B3::Value::dump):
(JSC::B3::Value::effects):
(JSC::B3::Value::checkOpcode):

  • b3/B3Value.h:
  • b3/B3Variable.cpp: Added.

(JSC::B3::Variable::~Variable):
(JSC::B3::Variable::dump):
(JSC::B3::Variable::deepDump):
(JSC::B3::Variable::Variable):

  • b3/B3Variable.h: Added.

(JSC::B3::Variable::type):
(JSC::B3::Variable::index):
(JSC::B3::DeepVariableDump::DeepVariableDump):
(JSC::B3::DeepVariableDump::dump):
(JSC::B3::deepDump):

  • b3/B3VariableValue.cpp: Added.

(JSC::B3::VariableValue::~VariableValue):
(JSC::B3::VariableValue::dumpMeta):
(JSC::B3::VariableValue::cloneImpl):
(JSC::B3::VariableValue::VariableValue):

  • b3/B3VariableValue.h: Added.
  • b3/air/AirAllocateStack.cpp:

(JSC::B3::Air::allocateStack):

  • b3/air/AirCode.cpp:

(JSC::B3::Air::Code::addStackSlot):
(JSC::B3::Air::Code::addSpecial):
(JSC::B3::Air::Code::cCallSpecial):

  • b3/air/AirCode.h:

(JSC::B3::Air::Code::begin):
(JSC::B3::Air::Code::end):
(JSC::B3::Air::Code::stackSlots):
(JSC::B3::Air::Code::specials):
(JSC::B3::Air::Code::forAllTmps):
(JSC::B3::Air::Code::StackSlotsCollection::StackSlotsCollection): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::size): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::at): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::operator[]): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::iterator::iterator): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::iterator::operator*): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::iterator::operator++): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::iterator::operator==): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::iterator::operator!=): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::begin): Deleted.
(JSC::B3::Air::Code::StackSlotsCollection::end): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::SpecialsCollection): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::size): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::at): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::operator[]): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::iterator::iterator): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::iterator::operator*): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::iterator::operator++): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::iterator::operator==): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::iterator::operator!=): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::begin): Deleted.
(JSC::B3::Air::Code::SpecialsCollection::end): Deleted.

  • b3/air/AirFixObviousSpills.cpp:
  • b3/air/AirInstInlines.h:
  • b3/air/AirIteratedRegisterCoalescing.cpp:
  • b3/air/AirLiveness.h:
  • b3/air/AirLowerAfterRegAlloc.cpp:

(JSC::B3::Air::lowerAfterRegAlloc):

  • b3/air/AirSpecial.cpp:

(JSC::B3::Air::Special::Special):

  • b3/air/AirSpecial.h:
  • b3/air/AirSpillEverything.cpp:

(JSC::B3::Air::spillEverything):

  • b3/air/AirStackSlot.cpp:

(JSC::B3::Air::StackSlot::dump):
(JSC::B3::Air::StackSlot::deepDump):
(JSC::B3::Air::StackSlot::StackSlot):

  • b3/air/AirStackSlot.h:

(JSC::B3::Air::StackSlot::byteSize):
(JSC::B3::Air::StackSlot::kind):
(JSC::B3::Air::StackSlot::isLocked):
(JSC::B3::Air::StackSlot::isSpill):
(JSC::B3::Air::StackSlot::index):
(JSC::B3::Air::StackSlot::ensureSize):

  • b3/air/AirStackSlotKind.cpp: Copied from Source/JavaScriptCore/b3/B3StackSlotKind.cpp.

(WTF::printInternal):

  • b3/air/AirStackSlotKind.h: Copied from Source/JavaScriptCore/b3/B3StackSlotKind.h.
  • b3/air/opcode_generator.rb:
  • b3/air/testair.cpp:

(JSC::B3::Air::testShuffleBroadcastAllRegs):
(JSC::B3::Air::testShuffleShiftAllRegs):
(JSC::B3::Air::testShuffleRotateAllRegs):

  • b3/testb3.cpp:

(JSC::B3::testStackSlot):
(JSC::B3::testStoreLoadStackSlot):

  • ftl/FTLB3Output.cpp:

(JSC::FTL::Output::lockedStackSlot):
(JSC::FTL::Output::neg):

  • ftl/FTLLowerDFGToLLVM.cpp:

(JSC::FTL::DFG::LowerDFGToLLVM::compileInvalidationPoint):

Websites/webkit.org:

This changes the documentation to account for the addition of Variables and the Get and Set
opcodes, and the removal of anonymous stack slots from B3 IR.

  • docs/b3/intermediate-representation.html:
2:34 PM Changeset in webkit [196031] by Antti Koivisto
  • 20 edits
    2 adds in trunk/Source/WebCore

Factor style sharing code out of StyleResolver
https://bugs.webkit.org/show_bug.cgi?id=153768

Reviewed by Darin Adler.

Move the code to a new class, Style::SharingResolver.

When resolving document style we query the sharing resolver first before using the regular style resolver.
Other paths that call style resolver were mostly already disabling it with DisallowStyleSharing flag.

  • WebCore.xcodeproj/project.pbxproj:
  • css/ElementRuleCollector.cpp:

(WebCore::MatchRequest::MatchRequest):
(WebCore::ElementRuleCollector::matchAllRules):
(WebCore::ElementRuleCollector::hasAnyMatchingRules):

More const.

  • css/ElementRuleCollector.h:

(WebCore::ElementRuleCollector::setRegionForStyling):
(WebCore::ElementRuleCollector::setMedium):

  • css/MediaQueryMatcher.cpp:

(WebCore::MediaQueryMatcher::prepareEvaluator):

  • css/StyleMedia.cpp:

(WebCore::StyleMedia::matchMedium):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::State::cacheBorderAndBackground):
(WebCore::StyleResolver::StyleResolver):
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::State::setStyle):
(WebCore::isAtShadowBoundary):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::classNamesAffectedByRules): Deleted.
(WebCore::parentElementPreventsSharing): Deleted.
(WebCore::StyleResolver::locateCousinList): Deleted.
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet): Deleted.
(WebCore::StyleResolver::canShareStyleWithControl): Deleted.
(WebCore::elementHasDirectionAuto): Deleted.
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes): Deleted.
(WebCore::StyleResolver::canShareStyleWithElement): Deleted.
(WebCore::StyleResolver::findSiblingForStyleSharing): Deleted.
(WebCore::StyleResolver::locateSharedStyle): Deleted.

Style sharing code moves to SharingResolver.

  • css/StyleResolver.h:

(WebCore::StyleResolver::mediaQueryEvaluator):
(WebCore::StyleResolver::State::regionForStyling):
(WebCore::StyleResolver::State::elementLinkState):
(WebCore::StyleResolver::State::setApplyPropertyToRegularStyle):
(WebCore::StyleResolver::State::setApplyPropertyToVisitedLinkStyle):
(WebCore::StyleResolver::state):
(WebCore::StyleResolver::setTextOrientation):
(WebCore::StyleResolver::State::setElementAffectedByClassRules): Deleted.
(WebCore::StyleResolver::State::elementAffectedByClassRules): Deleted.
(WebCore::StyleResolver::styleNotYetAvailable): Deleted.

Placeholder code moves to TreeResolver.

  • dom/VisitedLinkState.cpp:

(WebCore::linkAttribute):
(WebCore::VisitedLinkState::invalidateStyleForAllLinks):
(WebCore::linkHashForElement):
(WebCore::VisitedLinkState::invalidateStyleForLink):
(WebCore::VisitedLinkState::determineLinkStateSlowCase):

  • dom/VisitedLinkState.h:

(WebCore::VisitedLinkState::determineLinkState):

  • html/HTMLFormControlElement.h:
  • rendering/RenderElement.cpp:

(WebCore::RenderElement::getUncachedPseudoStyle):

  • rendering/RenderNamedFlowFragment.cpp:

(WebCore::RenderNamedFlowFragment::computeStyleInRegion):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::isStyleAvailable):
(WebCore::RenderStyle::hasUniquePseudoStyle):

  • style/StyleSharingResolver.cpp: Added.

(WebCore::Style::SharingResolver::SharingResolver):
(WebCore::Style::parentElementPreventsSharing):
(WebCore::Style::elementHasDirectionAuto):
(WebCore::Style::SharingResolver::searchSimilar):
(WebCore::Style::SharingResolver::findSibling):
(WebCore::Style::SharingResolver::locateCousinList):
(WebCore::Style::canShareStyleWithControl):
(WebCore::Style::SharingResolver::canShareStyleWithElement):
(WebCore::Style::SharingResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::Style::SharingResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::Style::SharingResolver::classNamesAffectedByRules):

  • style/StyleSharingResolver.h: Added.
  • style/StyleTreeResolver.cpp:

(WebCore::Style::ensurePlaceholderStyle):
(WebCore::Style::TreeResolver::TreeResolver):
(WebCore::Style::TreeResolver::styleForElement):

Try to use SharingResolver first.
Also move placeholder style handling here, it is only relevant when resolving document style.

(WebCore::Style::postResolutionCallbacksAreSuspended):
(WebCore::Style::isPlaceholderStyle):

  • style/StyleTreeResolver.h:
  • svg/SVGElement.cpp:

(WebCore::SVGElement::customStyleForRenderer):

  • svg/SVGElementRareData.h:

(WebCore::SVGElementRareData::overrideComputedStyle):

2:34 PM Changeset in webkit [196030] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking perf/show-hide-table-rows.html as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153803

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
1:58 PM Changeset in webkit [196029] by mitz@apple.com
  • 4 edits in trunk/Websites/webkit.org

Tagline in B3 docs should match the rest of the website
https://bugs.webkit.org/show_bug.cgi?id=153801

Reviewed by Filip Pizlo.

Fix the tagline.

  • docs/b3/assembly-intermediate-representation.html:
  • docs/b3/index.html:
  • docs/b3/intermediate-representation.html:
1:31 PM Changeset in webkit [196028] by timothy_horton@apple.com
  • 3 edits
    2 adds in trunk

<attachment> icon should be a folder for the custom MIME type multipart/x-folder
https://bugs.webkit.org/show_bug.cgi?id=153795
<rdar://problem/24416632>

Reviewed by Anders Carlsson.

Source/WebCore:

Test: fast/attachment/attachment-folder-icon.html

  • rendering/RenderThemeMac.mm:

(WebCore::iconForAttachment):
(WebCore::paintAttachmentIcon):
Mail uses this special MIME type to indicate that something is a folder, which there
isn't a normal non-deprecated MIME type for.

LayoutTests:

  • fast/attachment/attachment-folder-icon-expected.html: Added.
  • fast/attachment/attachment-folder-icon.html: Added.

Make sure that the rendering of an attachment with multipart/x-folder
matches that of a file reference pointing at a folder.

1:16 PM Changeset in webkit [196027] by gns@gnome.org
  • 2 edits in trunk/LayoutTests

[GTK] Layout Test fast/images/animated-gif-no-layout.html is failing
https://bugs.webkit.org/show_bug.cgi?id=153798

Unreviewed gardening.

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> on 2016-02-02

  • platform/gtk/TestExpectations: mark a couple tests as failing. The

green frame of the gif is being rendered in a slightly lighter green.

1:14 PM WebKitGTK/Gardening/Calendar edited by gns@gnome.org
(diff)
1:11 PM Changeset in webkit [196026] by Alan Bujtas
  • 5 edits in trunk/LayoutTests

[Win] gardening after r195740.

Unreviewed.

  • platform/win/editing/selection/5057506-2-expected.txt:
  • platform/win/fast/block/margin-collapse/021-expected.txt:
  • platform/win/fast/table/border-collapsing/cached-change-row-border-color-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tbody_style-expected.txt:
12:51 PM Changeset in webkit [196025] by beidson@apple.com
  • 8 edits in trunk

Modern IDB: storage/indexeddb/cursor-continue-validity.html fails.
https://bugs.webkit.org/show_bug.cgi?id=153791

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (Existing test now unskipped).

There was a preexisting check in the SQLite cursor for remembering the current record and
refusing to refetch it.

This check was causing this bug, because we needed to refetch the current record.

Removing the check (and its associated flag) doesn't regress any other test, and fixes this one.

  • Modules/indexeddb/server/SQLiteIDBCursor.cpp:

(WebCore::IDBServer::SQLiteIDBCursor::resetAndRebindStatement):
(WebCore::IDBServer::SQLiteIDBCursor::internalAdvanceOnce):

  • Modules/indexeddb/server/SQLiteIDBCursor.h:

LayoutTests:

In addition to unskipping the test, I augmented it to print out more of what was going on.

The additional printed info is what helped me track down the bug, and will make it more
likely to catch any future regressions.

  • platform/mac-wk1/TestExpectations:
  • storage/indexeddb/cursor-continue-validity-expected.txt:
  • storage/indexeddb/cursor-continue-validity-private-expected.txt:
  • storage/indexeddb/resources/cursor-continue-validity.js:
11:50 AM Changeset in webkit [196024] by hyatt@apple.com
  • 45 edits
    32 adds in trunk

Add a line grid pagination SPI to WebKit.
https://bugs.webkit.org/show_bug.cgi?id=153757
<rdar://problem/23041598>

Reviewed by Anders Carlsson.

Source/WebCore:

New tests in fast/multicol/pagination.

  • page/Page.cpp:

(WebCore::Page::setPaginationLineGridEnabled):

  • page/Page.h:

(WebCore::Page::paginationLineGridEnabled):
Add a boolean to the page to turn the line grid on and off.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::styleDidChange):
Propagate the body's font up to the paginated RenderView so that
it can be used to establish the line grid.

  • style/StyleResolveForDocument.cpp:

(WebCore::Style::resolveForDocument):
Set up a line grid with containment snapping by default if the
line grid enabled flag is set.

  • testing/Internals.cpp:

(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setPagination):
(WebCore::Internals::setPaginationLineGridEnabled):
(WebCore::Internals::configurationForViewport):

  • testing/Internals.h:

(WebCore::Internals::setPagination):

  • testing/Internals.idl:

Add support for testing the grid being enabled.

Source/WebKit/mac:

  • WebView/WebView.mm:

(-[WebView _setPaginationLineGridEnabled:]):
(-[WebView _paginationLineGridEnabled]):

  • WebView/WebViewPrivate.h:

Source/WebKit2:

  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::encode):
(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPageCreationParameters.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPaginationLineGridEnabled):
(WKPageGetPaginationLineGridEnabled):

  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController setPaginationLineGridEnabled:]):
(-[WKBrowsingContextController paginationLineGridEnabled]):

  • UIProcess/API/Cocoa/WKBrowsingContextControllerPrivate.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _paginationLineGridEnabled]):
(-[WKWebView _setPaginationLineGridEnabled:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::setPaginationLineGridEnabled):
(WebKit::WebPageProxy::creationParameters):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::paginationLineGridEnabled):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setPaginationLineGridEnabled):

WebProcess/WebPage/WebPage.h:

  • WebProcess/WebPage/WebPage.messages.in:

LayoutTests:

  • platform/mac/fast/multicol/pagination/BottomToTop-bt-expected.png:
  • platform/mac/fast/multicol/pagination/BottomToTop-lr-expected.png:
  • platform/mac/fast/multicol/pagination/BottomToTop-rl-expected.png:
  • platform/mac/fast/multicol/pagination/BottomToTop-tb-expected.png:
  • platform/mac/fast/multicol/pagination/BottomToTopGrid-bt-expected.png: Added.
  • platform/mac/fast/multicol/pagination/BottomToTopGrid-bt-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/BottomToTopGrid-lr-expected.png: Added.
  • platform/mac/fast/multicol/pagination/BottomToTopGrid-lr-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/BottomToTopGrid-rl-expected.png: Added.
  • platform/mac/fast/multicol/pagination/BottomToTopGrid-rl-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/BottomToTopGrid-tb-expected.png: Added.
  • platform/mac/fast/multicol/pagination/BottomToTopGrid-tb-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/LeftToRight-bt-expected.png:
  • platform/mac/fast/multicol/pagination/LeftToRight-lr-expected.png:
  • platform/mac/fast/multicol/pagination/LeftToRight-rl-expected.png:
  • platform/mac/fast/multicol/pagination/LeftToRight-tb-expected.png:
  • platform/mac/fast/multicol/pagination/LeftToRightGrid-bt-expected.png: Added.
  • platform/mac/fast/multicol/pagination/LeftToRightGrid-bt-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/LeftToRightGrid-lr-expected.png: Added.
  • platform/mac/fast/multicol/pagination/LeftToRightGrid-lr-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/LeftToRightGrid-rl-expected.png: Added.
  • platform/mac/fast/multicol/pagination/LeftToRightGrid-rl-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/LeftToRightGrid-tb-expected.png: Added.
  • platform/mac/fast/multicol/pagination/LeftToRightGrid-tb-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/RightToLeft-bt-expected.png:
  • platform/mac/fast/multicol/pagination/RightToLeft-lr-expected.png:
  • platform/mac/fast/multicol/pagination/RightToLeft-max-width-expected.png:
  • platform/mac/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.png:
  • platform/mac/fast/multicol/pagination/RightToLeft-rl-expected.png:
  • platform/mac/fast/multicol/pagination/RightToLeft-tb-expected.png:
  • platform/mac/fast/multicol/pagination/RightToLeftGrid-bt-expected.png: Added.
  • platform/mac/fast/multicol/pagination/RightToLeftGrid-bt-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/RightToLeftGrid-lr-expected.png: Added.
  • platform/mac/fast/multicol/pagination/RightToLeftGrid-lr-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/RightToLeftGrid-rl-expected.png: Added.
  • platform/mac/fast/multicol/pagination/RightToLeftGrid-rl-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/RightToLeftGrid-tb-expected.png: Added.
  • platform/mac/fast/multicol/pagination/RightToLeftGrid-tb-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/TopToBottom-bt-expected.png:
  • platform/mac/fast/multicol/pagination/TopToBottom-lr-expected.png:
  • platform/mac/fast/multicol/pagination/TopToBottom-rl-expected.png:
  • platform/mac/fast/multicol/pagination/TopToBottom-tb-expected.png:
  • platform/mac/fast/multicol/pagination/TopToBottomGrid-bt-expected.png: Added.
  • platform/mac/fast/multicol/pagination/TopToBottomGrid-bt-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/TopToBottomGrid-lr-expected.png: Added.
  • platform/mac/fast/multicol/pagination/TopToBottomGrid-lr-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/TopToBottomGrid-rl-expected.png: Added.
  • platform/mac/fast/multicol/pagination/TopToBottomGrid-rl-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/TopToBottomGrid-tb-expected.png: Added.
  • platform/mac/fast/multicol/pagination/TopToBottomGrid-tb-expected.txt: Added.
  • platform/mac/fast/multicol/pagination/nested-transforms-expected.png:
11:43 AM Changeset in webkit [196023] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Tab suspension code shouldn't use page cache cacheability logic
https://bugs.webkit.org/show_bug.cgi?id=153680

Reviewed by Andreas Kling.

Most of PageCache::canCache() is unnecessary for tab suspension.

Also improve robustness and introduce 1 minute delay before suspending.

  • page/Page.cpp:

(WebCore::Page::setPageActivityState):
(WebCore::Page::setIsVisible):
(WebCore::Page::setIsVisibleInternal):
(WebCore::Page::setIsPrerender):
(WebCore::Page::canTabSuspend):

Include visibility test here.

Instead of calling PageCache::canCache() just check for each frame

  • that the document is loaded
  • that active DOM objects allow suspension

(WebCore::Page::setIsTabSuspended):
(WebCore::Page::setTabSuspensionEnabled):
(WebCore::Page::updateTabSuspensionState):

Refactor for robustness.

(WebCore::Page::tabSuspensionTimerFired):

Call canTabSuspend, the result might have changed.

(WebCore::Page::scheduleTabSuspension): Deleted.

  • page/Page.h:
11:33 AM Changeset in webkit [196022] by Yusuke Suzuki
  • 42 edits in trunk/Source

[JSC] Introduce BytecodeIntrinsic constant rep like @undefined
https://bugs.webkit.org/show_bug.cgi?id=153737

Reviewed by Darin Adler.

Source/JavaScriptCore:

This patch enhances existing BytecodeIntrinsic mechanism to accept @xxx form,
that will be used to represent bytecode intrinsic constants.
After this change, we can use 2 forms for bytecode intrinsics. (1) Function form (like, @toString(value))
and (2) Constant form (like @undefined).

Bytecode intrinsic constants allow us to easily expose constant values from C++ world.
For example, we can expose ArrayIterationKind flags to JS world without using private global variables.
Exposed constant values are loaded from bytecodes directly through constant registers.
While previously we expose them through private global variables, bytecode intrinsic constants
can be loaded directly from CodeBlock. And later, it will become JSConstant in DFG.

And by using this mechanism, we implement several constants. @undefined, @arrayIterationKindKeyValue etc.

  • builtins/ArrayConstructor.js:

(from):

  • builtins/ArrayIteratorPrototype.js:

(next):

  • builtins/ArrayPrototype.js:

(reduce):
(reduceRight):
(every):
(forEach):
(filter):
(map):
(some):
(fill):
(find):
(findIndex):
(includes):
(sort.compactSparse):
(sort.compactSlow):
(sort.compact):
(sort):
(copyWithin):

  • builtins/DatePrototype.js:

(toLocaleString.toDateTimeOptionsAnyAll):
(toLocaleString):
(toLocaleDateString.toDateTimeOptionsDateDate):
(toLocaleDateString):
(toLocaleTimeString.toDateTimeOptionsTimeTime):
(toLocaleTimeString):

  • builtins/GeneratorPrototype.js:

(generatorResume):

  • builtins/GlobalObject.js:

(isDictionary):

  • builtins/InternalPromiseConstructor.js:

(internalAll.newResolveElement):
(internalAll):

  • builtins/IteratorPrototype.js:

(symbolIteratorGetter):
(symbolIterator): Deleted.

  • builtins/MapPrototype.js:

(forEach):

  • builtins/ModuleLoaderObject.js:

(newRegistryEntry):
(forceFulfillPromise):
(commitInstantiated):
(requestFetch):
(requestTranslate):
(requestInstantiate):
(requestLink):
(provide):

  • builtins/PromiseConstructor.js:

(all.newResolveElement):
(all):
(race):
(reject):
(resolve):

  • builtins/PromiseOperations.js:

(newPromiseCapability.executor):
(newPromiseCapability):
(rejectPromise):
(fulfillPromise):
(createResolvingFunctions.resolve):
(createResolvingFunctions.reject):
(createResolvingFunctions):
(promiseReactionJob):
(promiseResolveThenableJob):
(initializePromise):

  • builtins/PromisePrototype.js:

(catch):
(then):

  • builtins/SetPrototype.js:

(forEach):

  • builtins/StringConstructor.js:

(raw):

  • builtins/StringIteratorPrototype.js:

(next):

  • builtins/StringPrototype.js:

(localeCompare):

  • builtins/TypedArrayConstructor.js:

(of):
(from):

  • builtins/TypedArrayPrototype.js:

(every):
(find):
(findIndex):
(forEach):
(some):
(reduce):
(reduceRight):
(map):
(filter):

  • bytecode/BytecodeIntrinsicRegistry.cpp:

(JSC::BytecodeIntrinsicRegistry::BytecodeIntrinsicRegistry):
(JSC::BytecodeIntrinsicRegistry::lookup):

  • bytecode/BytecodeIntrinsicRegistry.h:
  • bytecompiler/NodesCodegen.cpp:
  • parser/ASTBuilder.h:

(JSC::ASTBuilder::createResolve):
(JSC::ASTBuilder::makeFunctionCallNode):

  • parser/NodeConstructors.h:

(JSC::BytecodeIntrinsicNode::BytecodeIntrinsicNode):

  • parser/Nodes.h:

(JSC::ExpressionNode::isBytecodeIntrinsicNode):
(JSC::BytecodeIntrinsicNode::type):
(JSC::BytecodeIntrinsicNode::emitter):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseProperty):
(JSC::Parser<LexerType>::parsePrimaryExpression):

  • parser/SyntaxChecker.h:

(JSC::SyntaxChecker::createResolve):

  • runtime/CommonIdentifiers.cpp:

(JSC::CommonIdentifiers::CommonIdentifiers): Deleted.

  • runtime/CommonIdentifiers.h:

(JSC::CommonIdentifiers::bytecodeIntrinsicRegistry): Deleted.

  • runtime/IteratorPrototype.cpp:

(JSC::IteratorPrototype::finishCreation):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init): Deleted.

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

(JSC::VM::bytecodeIntrinsicRegistry):

Source/WebCore:

  • Modules/fetch/FetchHeaders.js:

(initializeFetchHeaders):

  • Modules/streams/ReadableStream.js:

(initializeReadableStream):
(closeDestination):
(abortDestination):
(pipeTo):

  • Modules/streams/ReadableStreamInternals.js:

(privateInitializeReadableStreamController):
(teeReadableStream):
(isReadableStreamReader):
(errorReadableStream):
(finishClosingReadableStream):
(enqueueInReadableStream):
(readFromReadableStreamReader):

  • Modules/streams/ReadableStreamReader.js:

(releaseLock):

  • Modules/streams/StreamInternals.js:

(shieldingPromiseResolve):
(promiseInvokeOrNoopNoCatch):
(promiseInvokeOrFallbackOrNoop):
(validateAndNormalizeQueuingStrategy):

  • Modules/streams/WritableStream.js:

(initializeWritableStream):
(write):

  • Modules/streams/WritableStreamInternals.js:

(errorWritableStream):

11:27 AM Changeset in webkit [196021] by beidson@apple.com
  • 4 edits in trunk

Modern IDB: storage/indexeddb/dont-wedge.html sometimes ASSERTs.
https://bugs.webkit.org/show_bug.cgi?id=153790

Reviewed by Tim Horton.

Source/WebCore:

No new tests (Failing test now unskipped).

This test uncovered an unhandled race where the main thread tried to perform an OpenDB operation
multiple times while it was already in-progress on the server thread.

There was already a flag meant to cover this race, and it just needed to be applied to one more site.

  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::performCurrentOpenOperation):
(WebCore::IDBServer::UniqueIDBDatabase::openBackingStore):

LayoutTests:

  • platform/mac-wk1/TestExpectations:
11:10 AM Changeset in webkit [196020] by Joseph Pecoraro
  • 3 edits in trunk

Unreviewed attempt to fix Mac CMake build after r195999.

  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Add ENABLE_RESOURCE_USAGE to CMake builds.

11:07 AM Changeset in webkit [196019] by peavo@outlook.com
  • 4 edits in trunk/Source/JavaScriptCore

[B3][Win64] Compile fixes.
https://bugs.webkit.org/show_bug.cgi?id=153605

Reviewed by Filip Pizlo.

Fix remaining compile errors on Win64.

  • CMakeLists.txt:
  • b3/B3CFG.h:

(JSC::B3::CFG::newMap):

  • ftl/FTLJITCode.h:
10:52 AM Changeset in webkit [196018] by Joseph Pecoraro
  • 2 edits in trunk/Source/WebInspectorUI

Uncaught Exception: TypeError: undefined is not an object (evaluating 'highlightedRange.from')
https://bugs.webkit.org/show_bug.cgi?id=153685

Reviewed by Timothy Hatcher.

  • UserInterface/Controllers/CodeMirrorTokenTrackingController.js:

(WebInspector.CodeMirrorTokenTrackingController.prototype.highlightRange):
The highlighted range could have just gotten removed, in which case the
marker would return undefined. Just bail in such cases.

10:51 AM Changeset in webkit [196017] by Alan Bujtas
  • 240 edits in trunk/LayoutTests

[Win] gardening after r195740.

Unreviewed.

  • platform/win/tables/mozilla/marvin/x_tbody_align_left-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tbody_align_right-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tbody_class-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tbody_id-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tbody_valign_baseline-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tbody_valign_bottom-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tbody_valign_middle-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tbody_valign_top-expected.txt:
  • platform/win/tables/mozilla/marvin/x_td_align_center-expected.txt:
  • platform/win/tables/mozilla/marvin/x_td_align_char-expected.txt:
  • platform/win/tables/mozilla/marvin/x_td_align_justify-expected.txt:
  • platform/win/tables/mozilla/marvin/x_td_align_left-expected.txt:
  • platform/win/tables/mozilla/marvin/x_td_align_right-expected.txt:
  • platform/win/tables/mozilla/marvin/x_td_bgcolor_name-expected.txt:
  • platform/win/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/x_td_class-expected.txt:
  • platform/win/tables/mozilla/marvin/x_td_colspan-expected.txt:
  • platform/win/tables/mozilla/marvin/x_td_height-expected.txt:
  • platform/win/tables/mozilla/marvin/x_td_id-expected.txt:
  • platform/win/tables/mozilla/marvin/x_td_nowrap-expected.txt:
  • platform/win/tables/mozilla/marvin/x_td_rowspan-expected.txt:
  • platform/win/tables/mozilla/marvin/x_td_style-expected.txt:
  • platform/win/tables/mozilla/marvin/x_td_valign_baseline-expected.txt:
  • platform/win/tables/mozilla/marvin/x_td_valign_bottom-expected.txt:
  • platform/win/tables/mozilla/marvin/x_td_valign_middle-expected.txt:
  • platform/win/tables/mozilla/marvin/x_td_valign_top-expected.txt:
  • platform/win/tables/mozilla/marvin/x_td_width-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tfoot_align_center-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tfoot_align_char-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tfoot_align_left-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tfoot_align_right-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tfoot_class-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tfoot_id-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tfoot_style-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tfoot_valign_middle-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tfoot_valign_top-expected.txt:
  • platform/win/tables/mozilla/marvin/x_th_align_center-expected.txt:
  • platform/win/tables/mozilla/marvin/x_th_align_char-expected.txt:
  • platform/win/tables/mozilla/marvin/x_th_align_justify-expected.txt:
  • platform/win/tables/mozilla/marvin/x_th_align_left-expected.txt:
  • platform/win/tables/mozilla/marvin/x_th_align_right-expected.txt:
  • platform/win/tables/mozilla/marvin/x_th_bgcolor_name-expected.txt:
  • platform/win/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/x_th_class-expected.txt:
  • platform/win/tables/mozilla/marvin/x_th_colspan-expected.txt:
  • platform/win/tables/mozilla/marvin/x_th_height-expected.txt:
  • platform/win/tables/mozilla/marvin/x_th_id-expected.txt:
  • platform/win/tables/mozilla/marvin/x_th_nowrap-expected.txt:
  • platform/win/tables/mozilla/marvin/x_th_rowspan-expected.txt:
  • platform/win/tables/mozilla/marvin/x_th_style-expected.txt:
  • platform/win/tables/mozilla/marvin/x_th_valign_baseline-expected.txt:
  • platform/win/tables/mozilla/marvin/x_th_valign_bottom-expected.txt:
  • platform/win/tables/mozilla/marvin/x_th_valign_middle-expected.txt:
  • platform/win/tables/mozilla/marvin/x_th_valign_top-expected.txt:
  • platform/win/tables/mozilla/marvin/x_th_width-expected.txt:
  • platform/win/tables/mozilla/marvin/x_thead_align_center-expected.txt:
  • platform/win/tables/mozilla/marvin/x_thead_align_char-expected.txt:
  • platform/win/tables/mozilla/marvin/x_thead_align_left-expected.txt:
  • platform/win/tables/mozilla/marvin/x_thead_align_right-expected.txt:
  • platform/win/tables/mozilla/marvin/x_thead_class-expected.txt:
  • platform/win/tables/mozilla/marvin/x_thead_id-expected.txt:
  • platform/win/tables/mozilla/marvin/x_thead_style-expected.txt:
  • platform/win/tables/mozilla/marvin/x_thead_valign_baseline-expected.txt:
  • platform/win/tables/mozilla/marvin/x_thead_valign_bottom-expected.txt:
  • platform/win/tables/mozilla/marvin/x_thead_valign_middle-expected.txt:
  • platform/win/tables/mozilla/marvin/x_thead_valign_top-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tr_align_char-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tr_bgcolor_name-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tr_class-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tr_id-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tr_style-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tr_valign_baseline-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tr_valign_bottom-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tr_valign_middle-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tr_valign_top-expected.txt:
  • platform/win/tables/mozilla/other/body_col-expected.txt:
  • platform/win/tables/mozilla/other/cell_widths-expected.txt:
  • platform/win/tables/mozilla/other/cellspacing-expected.txt:
  • platform/win/tables/mozilla/other/move_row-expected.txt:
  • platform/win/tables/mozilla/other/ms-expected.txt:
  • platform/win/tables/mozilla/other/nested2-expected.txt:
  • platform/win/tables/mozilla/other/nestedTables-expected.txt:
  • platform/win/tables/mozilla/other/padding-expected.txt:
  • platform/win/tables/mozilla/other/slashlogo-expected.txt:
  • platform/win/tables/mozilla/other/test3-expected.txt:
  • platform/win/tables/mozilla/other/test6-expected.txt:
  • platform/win/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
  • platform/win/tables/mozilla/other/wa_table_tr_align-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/97619-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug1010-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug101759-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug106336-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug1164-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug11945-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug128876-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug14007-1-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug14007-2-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug14159-2-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug1647-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug17826-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug178855-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug18770-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug24880-1-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug25707-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug27993-2-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug3105-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug3166-11-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug3166-12-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug3166-18-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug32205-1-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug32205-4-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug4294-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug51000-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug56024-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug59252-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug65372-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug6933-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug7113-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug7121-2-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug7243-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug73629-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug80762-2-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug92868_1-expected.txt:
  • platform/win/tables/mozilla_expected_failures/bugs/bug9879-1-expected.txt:
  • platform/win/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.txt:
  • platform/win/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
  • platform/win/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
  • platform/win/tables/mozilla_expected_failures/core/backgrounds-expected.txt:
  • platform/win/tables/mozilla_expected_failures/core/captions1-expected.txt:
  • platform/win/tables/mozilla_expected_failures/core/captions2-expected.txt:
  • platform/win/tables/mozilla_expected_failures/core/captions3-expected.txt:
  • platform/win/tables/mozilla_expected_failures/core/col_span2-expected.txt:
  • platform/win/tables/mozilla_expected_failures/core/cols1-expected.txt:
  • platform/win/tables/mozilla_expected_failures/core/columns-expected.txt:
  • platform/win/tables/mozilla_expected_failures/core/conflicts-expected.txt:
  • platform/win/tables/mozilla_expected_failures/core/standards1-expected.txt:
  • platform/win/tables/mozilla_expected_failures/dom/appendCells1-expected.txt:
  • platform/win/tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.txt:
  • platform/win/tables/mozilla_expected_failures/dom/appendCol1-expected.txt:
  • platform/win/tables/mozilla_expected_failures/dom/appendColGroup1-expected.txt:
  • platform/win/tables/mozilla_expected_failures/dom/insertTbodyExpand1-expected.txt:
  • platform/win/tables/mozilla_expected_failures/dom/insertTbodyRebuild1-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_frame_above-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_frame_below-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_frame_void-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_caption-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_caption_bottom-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_caption_hidden_table-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_caption_left-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_caption_right-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_caption_top-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_row-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_table-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_dirty_reflow_tbody-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_table-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tbody-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_hidden_tr-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell_sibling-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_td_dynamic_deactivate-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_bottom-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_middle-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_overflow_td_valign_top-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/x_table_rules_all-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/x_table_rules_cols-expected.txt:
  • platform/win/tables/mozilla_expected_failures/marvin/x_table_rules_rows-expected.txt:
  • platform/win/tables/mozilla_expected_failures/other/empty_cells-expected.txt:
  • platform/win/tables/mozilla_expected_failures/other/test4-expected.txt:
10:24 AM Changeset in webkit [196016] by bshafiei@apple.com
  • 5 edits in tags/Safari-602.1.18.2

Merged r195968. rdar://problem/24434627

10:23 AM Changeset in webkit [196015] by bshafiei@apple.com
  • 5 edits in tags/Safari-602.1.18.2/Source

Versioning.

10:19 AM Changeset in webkit [196014] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.18.2

New tag.

10:06 AM Changeset in webkit [196013] by mitz@apple.com
  • 6 edits in trunk

Layout Test fast/parser/external-entities-in-xslt.xml is flaky on El Capitan (but fails most of the time)
https://bugs.webkit.org/show_bug.cgi?id=153683

Reviewed by Alexey Proskuryakov.

Tools:

Ensure that XML_CATALOG_FILES is set in the Web Content service’s environment as well.

  • Scripts/webkitpy/port/driver.py:

(Driver._setup_environ_for_driver): Also set XPC_DUMPRENDERTREE_TEMP.

  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.setup_environ_for_server): Set XPC_XML_CATALOG_FILES.

  • Scripts/webkitpy/port/mac.py:

(MacPort.setup_environ_for_server): Ditto.

LayoutTests:

  • platform/mac/TestExpectations: Removed the failure expectation for this test.
9:57 AM Changeset in webkit [196012] by dbates@webkit.org
  • 5 edits in trunk/Source/WebCore

CSP: Support checking content security policy without a script execution context
https://bugs.webkit.org/show_bug.cgi?id=153748
<rdar://problem/24439149>

Reviewed by Darin Alder.

Towards checking a Web Worker's content security policy against a redirected worker
script load or redirected XHR request for an XHR request initiated from it, we should
support instantiating a ContentSecurityPolicy object without a ScriptExecutionContext.

No functionality was changed. So, no new tests.

  • dom/Document.cpp:

(WebCore::Document::initSecurityContext): Pass |this| as a reference instead of as a pointer.

  • page/csp/ContentSecurityPolicy.cpp: Remove extraneous includes ScriptState.h, TextEncoding.h,

and URL.h as they are included by ContentSecurityPolicy.h, FormDataList.h and FormData.h, respectively.
(WebCore::CSPSource::CSPSource): Take a constant reference to a ContentSecurityPolicy instead
of a pointer since we never expected a null pointer.
(WebCore::CSPSource::schemeMatches): Move logic for checking the protocol of source "self"
from here to ContentSecurityPolicy::protocolMatchesSelf() because we may not have a security
origin if ContentSecurityPolicy was initiated without a ScriptExecutionContext object.
(WebCore::CSPSourceList::allowSelf): Added.
(WebCore::CSPSourceList::CSPSourceList): Take a constant reference to a ContentSecurityPolicy
instead of a pointer since we never expected a null pointer. Remove fields from member
initialization list that can be initialized using C++11 in-class initialization syntax.
(WebCore::CSPSourceList::matches): Call ContentSecurityPolicy::urlMatchesSelf() to match the
effective URL against the URL of source "self".
(WebCore::CSPSourceList::parse): Update code as necessary now that m_policy is a reference
instead of a pointer.
(WebCore::CSPSourceList::parseSource): Simplify code by setting internal member fields directly
instead of via member functions.
(WebCore::CSPSourceList::parsePath): Update code as necessary now that m_policy is a reference
instead of a pointer.
(WebCore::CSPDirective::CSPDirective): Take a constant reference to a ContentSecurityPolicy
instead of a pointer since we never expected a null pointer.
(WebCore::CSPDirective::policy): Return a reference to a const ContentSecurityPolicy.
(WebCore::MediaListDirective::MediaListDirective): Take a constant reference to a ContentSecurityPolicy
instead of a pointer since we never expected a null pointer.
(WebCore::MediaListDirective::parse): Update code as necessary now that m_policy is a reference
instead of a pointer.
(WebCore::SourceListDirective::SourceListDirective): Take a constant reference to a ContentSecurityPolicy
instead of a pointer since we never expected a null pointer.
(WebCore::SourceListDirective::allows): Write in terms of CSPSourceList::allowSelf() because we
may not have a security origin to get a URL from if ContentSecurityPolicy was initiated without
a ScriptExecutionContext object.
(WebCore::CSPDirectiveList::reportURIs): Change return type from Vector<URL> to Vector<String>
The caller will convert the strings to URLs with respect to the script execution context.
(WebCore::CSPDirectiveList::parseReportURI): Store the report URI as a string instead of a URL
because we may not have a security origin to compute the absolute URL if ContentSecurityPolicy
was initiated without a ScriptExecutionContext object.
(WebCore::CSPDirectiveList::CSPDirectiveList): Take a reference to a ContentSecurityPolicy
instead of a pointer since we never expected a null pointer. It would be better to take a const
reference to a ContentSecurityPolicy, but ContentSecurityPolicy::applySandboxPolicy() needs to set
state on ContentSecurityPolicy :(
(WebCore::CSPDirectiveList::create): Ditto.
(WebCore::CSPDirectiveList::reportViolation): Update code as necessary now that m_policy is a reference
instead of a pointer.
(WebCore::CSPDirectiveList::checkEvalAndReportViolation): Ditto.
(WebCore::CSPDirectiveList::checkInlineAndReportViolation): Ditto.
(WebCore::CSPDirectiveList::parseDirective): Ditto.
(WebCore::CSPDirectiveList::parseReportURI): Store the report URI as a string instead of a URL
because we may not have a security origin to compute the absolute URL if ContentSecurityPolicy
was initiated without a ScriptExecutionContext object.
(WebCore::CSPDirectiveList::setCSPDirective): Update code as necessary now that m_policy is a reference
instead of a pointer.
(WebCore::CSPDirectiveList::applySandboxPolicy): Ditto.
(WebCore::CSPDirectiveList::parseReflectedXSS): Ditto.
(WebCore::CSPDirectiveList::addDirective): Ditto.
(WebCore::ContentSecurityPolicy::ContentSecurityPolicy): Modified to take the ScriptExecutionObject
as a reference and compute the CSPSource object for "self" and cache the protocol for "self". Removed
field m_overrideInlineStyleAllowed from the member initialization list and used C++11 in-class
initialization syntax to initialize it. Added overloaded constructor that takes a SecurityOrigin object.
We are not making use of this overloaded constructor at this time. We will in a subsequent patch.
(WebCore::ContentSecurityPolicy::didReceiveHeader): Store the eval disabled error message for
the last parsed policy in a member field instead of using it as part of disabling eval execution
on the script execution context because we may not have such a context.
(WebCore::ContentSecurityPolicy::applyPolicyToScriptExecutionContext): Applies the content security
policy eval and sandbox restrictions to the script execution context.
(WebCore::ContentSecurityPolicy::urlMatchesSelf): Match the specified URL against the URL for
source "self".
(WebCore::ContentSecurityPolicy::protocolMatchesSelf): Match the protocol of the specified URL
against the protocol for source "self".
(WebCore::ContentSecurityPolicy::gatherReportURIs): Modified to use the script execution context
to compute the absolute URL for each report URI.
(WebCore::ContentSecurityPolicy::reportViolation): Bail out if we do not have a script execution
context.
(WebCore::ContentSecurityPolicy::logToConsole): Only log to the console if we have a script
execution context.
(WebCore::ContentSecurityPolicy::reportBlockedScriptExecutionToInspector): Only report blocked
script execution to the Web Inspector if we have a script execution context.
(WebCore::CSPSourceList::addSourceSelf): Deleted.
(WebCore::CSPSourceList::addSourceStar): Deleted.
(WebCore::CSPSourceList::addSourceUnsafeInline): Deleted.
(WebCore::CSPSourceList::addSourceUnsafeEval): Deleted.
(WebCore::CSPDirectiveList::gatherReportURIs): Deleted.
(WebCore::ContentSecurityPolicy::securityOrigin): Deleted.
(WebCore::ContentSecurityPolicy::url): Deleted.
(WebCore::ContentSecurityPolicy::completeURL): Deleted.
(WebCore::ContentSecurityPolicy::enforceSandboxFlags): Deleted.

  • page/csp/ContentSecurityPolicy.h:

(WebCore::ContentSecurityPolicy::enforceSandboxFlags): Accumulates the parsed sandbox flags. We
will apply the sandbox flags in ContentSecurityPolicy::applyPolicyToScriptExecutionContext().

  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope): Instantiate ContentSecurityPolicy.
(WebCore::WorkerGlobalScope::applyContentSecurityPolicyResponseHeaders): Move instantiation of
ContentSecurityPolicy from here to constructor.

8:58 AM Changeset in webkit [196011] by fpizlo@apple.com
  • 2 edits in trunk/Websites/webkit.org

Minor fixes for B3 IR documentation
https://bugs.webkit.org/show_bug.cgi?id=153782

Reviewed by Michael Saboff.

Fix minor issues that Geoff found.

  • docs/b3/intermediate-representation.html:
8:38 AM Changeset in webkit [196010] by eric.carlson@apple.com
  • 14 edits
    2 adds in trunk

Allow ports to disable automatic text track selection
https://bugs.webkit.org/show_bug.cgi?id=153761
<rdar://problem/24416768>

Reviewed by Darin Adler.

Source/WebCore:

Test: media/track/track-manual-mode.html

  • Modules/mediacontrols/MediaControlsHost.cpp:

(WebCore::MediaControlsHost::manualKeyword): New.
(WebCore::MediaControlsHost::captionDisplayMode): Support 'manual' mode.

  • Modules/mediacontrols/MediaControlsHost.h:
  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.buildCaptionMenu): Check the 'off' item when in manual mode.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::addTextTrack): Update m_captionDisplayMode when called for the first

time so it is always correct. Set the track's manual selection mode as appropriate.

(WebCore::HTMLMediaElement::captionPreferencesChanged): Set each track's manual selection

mode as appropriate.

  • html/track/TextTrack.cpp:

(WebCore::TextTrack::kind): Return 'subtitles' for forced tracks when in manual mode.

  • html/track/TextTrack.h:
  • html/track/TrackBase.h:

(WebCore::TrackBase::kind): Make virtual.

  • page/CaptionUserPreferences.cpp:

(WebCore::CaptionUserPreferences::beginBlockingNotifications): New.
(WebCore::CaptionUserPreferences::endBlockingNotifications): Ditto.
(WebCore::CaptionUserPreferences::notify): Don't notify when blocked.

  • page/CaptionUserPreferences.h:
  • page/CaptionUserPreferencesMediaAF.cpp:

(WebCore::CaptionUserPreferencesMediaAF::CaptionUserPreferencesMediaAF): Set manual mode

when appropriate.

(WebCore::CaptionUserPreferencesMediaAF::captionDisplayMode): Check manual mode.
(WebCore::CaptionUserPreferencesMediaAF::setCaptionDisplayMode): Ditto.
(WebCore::CaptionUserPreferencesMediaAF::setPreferredLanguage): Ditto.
(WebCore::CaptionUserPreferencesMediaAF::textTrackSelectionScore): Return zero when in manual mode.
(WebCore::CaptionUserPreferencesMediaAF::sortedTrackListForMenu): Consider manual mode. Fix

typos in logging.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::mediaDescriptionForKind): Return 'auxiliary' when in manual mode.

  • testing/Internals.cpp:

(WebCore::Internals::setCaptionDisplayMode): Support manual mode.

LayoutTests:

  • media/track/track-manual-mode-expected.txt: Added.
  • media/track/track-manual-mode.html: Added.
8:16 AM Changeset in webkit [196009] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

REGRESSION(r195899): ASSERTION FAILED: is<Target>(source) in EventPath::retargetTouch() since r195899
https://bugs.webkit.org/show_bug.cgi?id=153741

Patch by Adrien Plazas <aplazas@igalia.com> on 2016-02-02
Reviewed by Ryosuke Niwa.

  • dom/EventDispatcher.cpp:

(WebCore::EventPath::retargetTouch):

8:11 AM Changeset in webkit [196008] by Alan Bujtas
  • 421 edits in trunk/LayoutTests

[Win] gardening after r195740. (more to follow)

Unreviewed.

  • platform/win/tables/mozilla/bugs/bug101201-expected.txt:
  • platform/win/tables/mozilla/bugs/bug101674-expected.txt:
  • platform/win/tables/mozilla/bugs/bug103533-expected.txt:
  • platform/win/tables/mozilla/bugs/bug106158-1-expected.txt:
  • platform/win/tables/mozilla/bugs/bug106795-expected.txt:
  • platform/win/tables/mozilla/bugs/bug106816-expected.txt:
  • platform/win/tables/mozilla/bugs/bug108340-expected.txt:
  • platform/win/tables/mozilla/bugs/bug110566-expected.txt:
  • platform/win/tables/mozilla/bugs/bug113235-1-expected.txt:
  • platform/win/tables/mozilla/bugs/bug113235-3-expected.txt:
  • platform/win/tables/mozilla/bugs/bug113424-expected.txt:
  • platform/win/tables/mozilla/bugs/bug119786-expected.txt:
  • platform/win/tables/mozilla/bugs/bug120107-expected.txt:
  • platform/win/tables/mozilla/bugs/bug120364-expected.txt:
  • platform/win/tables/mozilla/bugs/bug133756-1-expected.txt:
  • platform/win/tables/mozilla/bugs/bug133756-2-expected.txt:
  • platform/win/tables/mozilla/bugs/bug137388-1-expected.txt:
  • platform/win/tables/mozilla/bugs/bug137388-2-expected.txt:
  • platform/win/tables/mozilla/bugs/bug137388-3-expected.txt:
  • platform/win/tables/mozilla/bugs/bug138725-expected.txt:
  • platform/win/tables/mozilla/bugs/bug139524-1-expected.txt:
  • platform/win/tables/mozilla/bugs/bug139524-2-expected.txt:
  • platform/win/tables/mozilla/bugs/bug139524-3-expected.txt:
  • platform/win/tables/mozilla/bugs/bug139524-4-expected.txt:
  • platform/win/tables/mozilla/bugs/bug149275-2-expected.txt:
  • platform/win/tables/mozilla/bugs/bug154780-expected.txt:
  • platform/win/tables/mozilla/bugs/bug159108-expected.txt:
  • platform/win/tables/mozilla/bugs/bug175455-4-expected.txt:
  • platform/win/tables/mozilla/bugs/bug20579-expected.txt:
  • platform/win/tables/mozilla/bugs/bug20804-expected.txt:
  • platform/win/tables/mozilla/bugs/bug21299-expected.txt:
  • platform/win/tables/mozilla/bugs/bug215629-expected.txt:
  • platform/win/tables/mozilla/bugs/bug21918-expected.txt:
  • platform/win/tables/mozilla/bugs/bug219693-1-expected.txt:
  • platform/win/tables/mozilla/bugs/bug219693-2-expected.txt:
  • platform/win/tables/mozilla/bugs/bug22019-expected.txt:
  • platform/win/tables/mozilla/bugs/bug220536-expected.txt:
  • platform/win/tables/mozilla/bugs/bug221784-1-expected.txt:
  • platform/win/tables/mozilla/bugs/bug221784-2-expected.txt:
  • platform/win/tables/mozilla/bugs/bug222336-expected.txt:
  • platform/win/tables/mozilla/bugs/bug22246-2-expected.txt:
  • platform/win/tables/mozilla/bugs/bug22246-2a-expected.txt:
  • platform/win/tables/mozilla/bugs/bug22246-3-expected.txt:
  • platform/win/tables/mozilla/bugs/bug22246-3a-expected.txt:
  • platform/win/tables/mozilla/bugs/bug22513-expected.txt:
  • platform/win/tables/mozilla/bugs/bug23072-expected.txt:
  • platform/win/tables/mozilla/bugs/bug23151-expected.txt:
  • platform/win/tables/mozilla/bugs/bug23235-expected.txt:
  • platform/win/tables/mozilla/bugs/bug23299-expected.txt:
  • platform/win/tables/mozilla/bugs/bug24200-expected.txt:
  • platform/win/tables/mozilla/bugs/bug24503-expected.txt:
  • platform/win/tables/mozilla/bugs/bug24627-expected.txt:
  • platform/win/tables/mozilla/bugs/bug24880-expected.txt:
  • platform/win/tables/mozilla/bugs/bug25004-expected.txt:
  • platform/win/tables/mozilla/bugs/bug25074-expected.txt:
  • platform/win/tables/mozilla/bugs/bug25086-expected.txt:
  • platform/win/tables/mozilla/bugs/bug25367-expected.txt:
  • platform/win/tables/mozilla/bugs/bug25663-expected.txt:
  • platform/win/tables/mozilla/bugs/bug26178-expected.txt:
  • platform/win/tables/mozilla/bugs/bug26553-expected.txt:
  • platform/win/tables/mozilla/bugs/bug269566-expected.txt:
  • platform/win/tables/mozilla/bugs/bug27038-1-expected.txt:
  • platform/win/tables/mozilla/bugs/bug27038-2-expected.txt:
  • platform/win/tables/mozilla/bugs/bug275625-expected.txt:
  • platform/win/tables/mozilla/bugs/bug277062-expected.txt:
  • platform/win/tables/mozilla/bugs/bug278266-expected.txt:
  • platform/win/tables/mozilla/bugs/bug278385-expected.txt:
  • platform/win/tables/mozilla/bugs/bug27993-1-expected.txt:
  • platform/win/tables/mozilla/bugs/bug28928-expected.txt:
  • platform/win/tables/mozilla/bugs/bug28933-expected.txt:
  • platform/win/tables/mozilla/bugs/bug29058-1-expected.txt:
  • platform/win/tables/mozilla/bugs/bug29157-expected.txt:
  • platform/win/tables/mozilla/bugs/bug29314-expected.txt:
  • platform/win/tables/mozilla/bugs/bug29429-expected.txt:
  • platform/win/tables/mozilla/bugs/bug30273-expected.txt:
  • platform/win/tables/mozilla/bugs/bug30418-expected.txt:
  • platform/win/tables/mozilla/bugs/bug30559-expected.txt:
  • platform/win/tables/mozilla/bugs/bug30985-expected.txt:
  • platform/win/tables/mozilla/bugs/bug32205-2-expected.txt:
  • platform/win/tables/mozilla/bugs/bug32205-3-expected.txt:
  • platform/win/tables/mozilla/bugs/bug32205-5-expected.txt:
  • platform/win/tables/mozilla/bugs/bug32447-expected.txt:
  • platform/win/tables/mozilla/bugs/bug33137-expected.txt:
  • platform/win/tables/mozilla/bugs/bug33855-expected.txt:
  • platform/win/tables/mozilla/bugs/bug34538-expected.txt:
  • platform/win/tables/mozilla/bugs/bug35662-expected.txt:
  • platform/win/tables/mozilla/bugs/bug38916-expected.txt:
  • platform/win/tables/mozilla/bugs/bug39209-expected.txt:
  • platform/win/tables/mozilla/bugs/bug40828-expected.txt:
  • platform/win/tables/mozilla/bugs/bug42187-expected.txt:
  • platform/win/tables/mozilla/bugs/bug44505-expected.txt:
  • platform/win/tables/mozilla/bugs/bug44523-expected.txt:
  • platform/win/tables/mozilla/bugs/bug45055-expected.txt:
  • platform/win/tables/mozilla/bugs/bug45350-expected.txt:
  • platform/win/tables/mozilla/bugs/bug45486-expected.txt:
  • platform/win/tables/mozilla/bugs/bug46268-1-expected.txt:
  • platform/win/tables/mozilla/bugs/bug46268-2-expected.txt:
  • platform/win/tables/mozilla/bugs/bug46268-3-expected.txt:
  • platform/win/tables/mozilla/bugs/bug46268-5-expected.txt:
  • platform/win/tables/mozilla/bugs/bug46268-expected.txt:
  • platform/win/tables/mozilla/bugs/bug46368-1-expected.txt:
  • platform/win/tables/mozilla/bugs/bug46480-1-expected.txt:
  • platform/win/tables/mozilla/bugs/bug46480-2-expected.txt:
  • platform/win/tables/mozilla/bugs/bug46623-1-expected.txt:
  • platform/win/tables/mozilla/bugs/bug46623-2-expected.txt:
  • platform/win/tables/mozilla/bugs/bug47432-expected.txt:
  • platform/win/tables/mozilla/bugs/bug48028-1-expected.txt:
  • platform/win/tables/mozilla/bugs/bug48028-2-expected.txt:
  • platform/win/tables/mozilla/bugs/bug51037-expected.txt:
  • platform/win/tables/mozilla/bugs/bug51140-expected.txt:
  • platform/win/tables/mozilla/bugs/bug51727-expected.txt:
  • platform/win/tables/mozilla/bugs/bug52505-expected.txt:
  • platform/win/tables/mozilla/bugs/bug52506-expected.txt:
  • platform/win/tables/mozilla/bugs/bug53690-1-expected.txt:
  • platform/win/tables/mozilla/bugs/bug53690-2-expected.txt:
  • platform/win/tables/mozilla/bugs/bug53891-expected.txt:
  • platform/win/tables/mozilla/bugs/bug55545-expected.txt:
  • platform/win/tables/mozilla/bugs/bug55694-expected.txt:
  • platform/win/tables/mozilla/bugs/bug55789-expected.txt:
  • platform/win/tables/mozilla/bugs/bug56201-expected.txt:
  • platform/win/tables/mozilla/bugs/bug56405-expected.txt:
  • platform/win/tables/mozilla/bugs/bug57300-expected.txt:
  • platform/win/tables/mozilla/bugs/bug57378-expected.txt:
  • platform/win/tables/mozilla/bugs/bug57828-2-expected.txt:
  • platform/win/tables/mozilla/bugs/bug57828-expected.txt:
  • platform/win/tables/mozilla/bugs/bug58402-1-expected.txt:
  • platform/win/tables/mozilla/bugs/bug59354-expected.txt:
  • platform/win/tables/mozilla/bugs/bug60013-expected.txt:
  • platform/win/tables/mozilla/bugs/bug60749-expected.txt:
  • platform/win/tables/mozilla/bugs/bug60804-expected.txt:
  • platform/win/tables/mozilla/bugs/bug60807-expected.txt:
  • platform/win/tables/mozilla/bugs/bug60992-expected.txt:
  • platform/win/tables/mozilla/bugs/bug63785-expected.txt:
  • platform/win/tables/mozilla/bugs/bug67864-expected.txt:
  • platform/win/tables/mozilla/bugs/bug67915-1-expected.txt:
  • platform/win/tables/mozilla/bugs/bug68998-expected.txt:
  • platform/win/tables/mozilla/bugs/bug69187-expected.txt:
  • platform/win/tables/mozilla/bugs/bug69382-1-expected.txt:
  • platform/win/tables/mozilla/bugs/bug69382-2-expected.txt:
  • platform/win/tables/mozilla/bugs/bug72359-expected.txt:
  • platform/win/tables/mozilla/bugs/bug75250-expected.txt:
  • platform/win/tables/mozilla/bugs/bug78162-expected.txt:
  • platform/win/tables/mozilla/bugs/bug82946-1-expected.txt:
  • platform/win/tables/mozilla/bugs/bug82946-2-expected.txt:
  • platform/win/tables/mozilla/bugs/bug83786-expected.txt:
  • platform/win/tables/mozilla/bugs/bug86708-expected.txt:
  • platform/win/tables/mozilla/bugs/bug92143-expected.txt:
  • platform/win/tables/mozilla/bugs/bug92647-2-expected.txt:
  • platform/win/tables/mozilla/bugs/bug93363-expected.txt:
  • platform/win/tables/mozilla/bugs/bug96334-expected.txt:
  • platform/win/tables/mozilla/bugs/bug96343-expected.txt:
  • platform/win/tables/mozilla/bugs/bug97138-expected.txt:
  • platform/win/tables/mozilla/bugs/bug97383-expected.txt:
  • platform/win/tables/mozilla/bugs/bug99923-expected.txt:
  • platform/win/tables/mozilla/bugs/bug99948-expected.txt:
  • platform/win/tables/mozilla/collapsing_borders/bug127040-expected.txt:
  • platform/win/tables/mozilla/collapsing_borders/bug41262-3-expected.txt:
  • platform/win/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
  • platform/win/tables/mozilla/core/bloomberg-expected.txt:
  • platform/win/tables/mozilla/core/borders-expected.txt:
  • platform/win/tables/mozilla/core/captions-expected.txt:
  • platform/win/tables/mozilla/core/cell_heights-expected.txt:
  • platform/win/tables/mozilla/core/col_span-expected.txt:
  • platform/win/tables/mozilla/core/col_widths_auto_auto-expected.txt:
  • platform/win/tables/mozilla/core/col_widths_auto_autoFix-expected.txt:
  • platform/win/tables/mozilla/core/col_widths_auto_autoFixPer-expected.txt:
  • platform/win/tables/mozilla/core/col_widths_auto_autoPer-expected.txt:
  • platform/win/tables/mozilla/core/col_widths_auto_fix-expected.txt:
  • platform/win/tables/mozilla/core/col_widths_auto_fixPer-expected.txt:
  • platform/win/tables/mozilla/core/col_widths_auto_per-expected.txt:
  • platform/win/tables/mozilla/core/col_widths_fix_autoFix-expected.txt:
  • platform/win/tables/mozilla/core/col_widths_fix_autoPer-expected.txt:
  • platform/win/tables/mozilla/core/col_widths_fix_fix-expected.txt:
  • platform/win/tables/mozilla/core/col_widths_fix_fixPer-expected.txt:
  • platform/win/tables/mozilla/core/col_widths_fix_per-expected.txt:
  • platform/win/tables/mozilla/core/margins-expected.txt:
  • platform/win/tables/mozilla/core/misc-expected.txt:
  • platform/win/tables/mozilla/core/nested1-expected.txt:
  • platform/win/tables/mozilla/core/one_row-expected.txt:
  • platform/win/tables/mozilla/core/row_span-expected.txt:
  • platform/win/tables/mozilla/core/table_frame-expected.txt:
  • platform/win/tables/mozilla/core/table_heights-expected.txt:
  • platform/win/tables/mozilla/core/table_rules-expected.txt:
  • platform/win/tables/mozilla/core/table_widths-expected.txt:
  • platform/win/tables/mozilla/dom/appendCol2-expected.txt:
  • platform/win/tables/mozilla/dom/appendRowsExpand1-expected.txt:
  • platform/win/tables/mozilla/dom/appendTbodyExpand1-expected.txt:
  • platform/win/tables/mozilla/dom/deleteCellsRebuild1-expected.txt:
  • platform/win/tables/mozilla/dom/deleteCellsShrink1-expected.txt:
  • platform/win/tables/mozilla/dom/deleteCellsShrink2-expected.txt:
  • platform/win/tables/mozilla/dom/deleteCol1-expected.txt:
  • platform/win/tables/mozilla/dom/deleteCol2-expected.txt:
  • platform/win/tables/mozilla/dom/deleteCol3-expected.txt:
  • platform/win/tables/mozilla/dom/deleteColGroup1-expected.txt:
  • platform/win/tables/mozilla/dom/deleteColGroup2-expected.txt:
  • platform/win/tables/mozilla/dom/deleteRowsRebuild1-expected.txt:
  • platform/win/tables/mozilla/dom/deleteRowsShrink1-expected.txt:
  • platform/win/tables/mozilla/dom/deleteTbodyExpand1-expected.txt:
  • platform/win/tables/mozilla/dom/deleteTbodyRebuild1-expected.txt:
  • platform/win/tables/mozilla/dom/insertCellsExpand1-expected.txt:
  • platform/win/tables/mozilla/dom/insertCellsExpand2-expected.txt:
  • platform/win/tables/mozilla/dom/insertCellsRebuild1-expected.txt:
  • platform/win/tables/mozilla/dom/insertCellsRebuild2-expected.txt:
  • platform/win/tables/mozilla/dom/insertColGroups1-expected.txt:
  • platform/win/tables/mozilla/dom/insertColGroups2-expected.txt:
  • platform/win/tables/mozilla/dom/insertCols1-expected.txt:
  • platform/win/tables/mozilla/dom/insertCols2-expected.txt:
  • platform/win/tables/mozilla/dom/insertCols3-expected.txt:
  • platform/win/tables/mozilla/dom/insertCols4-expected.txt:
  • platform/win/tables/mozilla/dom/insertCols5-expected.txt:
  • platform/win/tables/mozilla/dom/insertRowsExpand1-expected.txt:
  • platform/win/tables/mozilla/dom/insertRowsRebuild1-expected.txt:
  • platform/win/tables/mozilla/dom/tableDom-expected.txt:
  • platform/win/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
  • platform/win/tables/mozilla/marvin/backgr_position-table-expected.txt:
  • platform/win/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
  • platform/win/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
  • platform/win/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
  • platform/win/tables/mozilla/marvin/backgr_simple-table-expected.txt:
  • platform/win/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
  • platform/win/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
  • platform/win/tables/mozilla/marvin/body_col-expected.txt:
  • platform/win/tables/mozilla/marvin/body_tbody-expected.txt:
  • platform/win/tables/mozilla/marvin/body_tfoot-expected.txt:
  • platform/win/tables/mozilla/marvin/body_thead-expected.txt:
  • platform/win/tables/mozilla/marvin/col_span-expected.txt:
  • platform/win/tables/mozilla/marvin/colgroup_align_center-expected.txt:
  • platform/win/tables/mozilla/marvin/colgroup_align_justify-expected.txt:
  • platform/win/tables/mozilla/marvin/colgroup_align_left-expected.txt:
  • platform/win/tables/mozilla/marvin/colgroup_align_right-expected.txt:
  • platform/win/tables/mozilla/marvin/colgroup_span-expected.txt:
  • platform/win/tables/mozilla/marvin/colgroup_valign_baseline-expected.txt:
  • platform/win/tables/mozilla/marvin/colgroup_valign_bottom-expected.txt:
  • platform/win/tables/mozilla/marvin/colgroup_valign_middle-expected.txt:
  • platform/win/tables/mozilla/marvin/colgroup_valign_top-expected.txt:
  • platform/win/tables/mozilla/marvin/colgroup_width_pct-expected.txt:
  • platform/win/tables/mozilla/marvin/colgroup_width_px-expected.txt:
  • platform/win/tables/mozilla/marvin/table_frame_border-expected.txt:
  • platform/win/tables/mozilla/marvin/table_frame_box-expected.txt:
  • platform/win/tables/mozilla/marvin/table_overflow_hidden_td-expected.txt:
  • platform/win/tables/mozilla/marvin/table_overflow_td_dynamic_deactivate-expected.txt:
  • platform/win/tables/mozilla/marvin/table_row_align_center-expected.txt:
  • platform/win/tables/mozilla/marvin/table_row_align_left-expected.txt:
  • platform/win/tables/mozilla/marvin/table_row_align_right-expected.txt:
  • platform/win/tables/mozilla/marvin/table_rules_all-expected.txt:
  • platform/win/tables/mozilla/marvin/table_rules_groups-expected.txt:
  • platform/win/tables/mozilla/marvin/table_rules_none-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_align_center-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_align_left-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_align_right-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_aqua-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_aqua_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_black-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_black_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_blue-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_blue_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_fuchsia-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_fuchsia_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_gray-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_gray_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_green-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_green_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_lime-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_lime_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_maroon-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_maroon_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_navy-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_navy_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_olive-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_olive_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_purple-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_purple_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_red-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_red_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_silver-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_silver_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_teal-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_teal_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_white-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_white_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_yellow-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_bgcolor_yellow_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_border_0-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_border_1-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_border_2-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_border_3-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_caption_align_bot-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_caption_align_top-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_cellpadding-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_cellpadding_pct-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_cellspacing-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_default-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_id-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_row_th_nowrap-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_td_align_center-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_td_align_left-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_td_align_right-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_td_colspan-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_td_height-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_td_nowrap-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_td_rowspan-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_td_width-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_th_align_center-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_th_align_left-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_th_align_right-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_th_colspan-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_th_height-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_th_rowspan-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_th_width-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_width_percent-expected.txt:
  • platform/win/tables/mozilla/marvin/tables_width_px-expected.txt:
  • platform/win/tables/mozilla/marvin/tbody_align_center-expected.txt:
  • platform/win/tables/mozilla/marvin/tbody_align_char-expected.txt:
  • platform/win/tables/mozilla/marvin/tbody_align_justify-expected.txt:
  • platform/win/tables/mozilla/marvin/tbody_align_left-expected.txt:
  • platform/win/tables/mozilla/marvin/tbody_align_right-expected.txt:
  • platform/win/tables/mozilla/marvin/tbody_char-expected.txt:
  • platform/win/tables/mozilla/marvin/tbody_valign_baseline-expected.txt:
  • platform/win/tables/mozilla/marvin/tbody_valign_bottom-expected.txt:
  • platform/win/tables/mozilla/marvin/tbody_valign_middle-expected.txt:
  • platform/win/tables/mozilla/marvin/tbody_valign_top-expected.txt:
  • platform/win/tables/mozilla/marvin/td_valign_baseline-expected.txt:
  • platform/win/tables/mozilla/marvin/td_valign_bottom-expected.txt:
  • platform/win/tables/mozilla/marvin/td_valign_middle-expected.txt:
  • platform/win/tables/mozilla/marvin/td_valign_top-expected.txt:
  • platform/win/tables/mozilla/marvin/tfoot_align_center-expected.txt:
  • platform/win/tables/mozilla/marvin/tfoot_align_char-expected.txt:
  • platform/win/tables/mozilla/marvin/tfoot_align_justify-expected.txt:
  • platform/win/tables/mozilla/marvin/tfoot_align_left-expected.txt:
  • platform/win/tables/mozilla/marvin/tfoot_align_right-expected.txt:
  • platform/win/tables/mozilla/marvin/tfoot_char-expected.txt:
  • platform/win/tables/mozilla/marvin/tfoot_valign_baseline-expected.txt:
  • platform/win/tables/mozilla/marvin/tfoot_valign_bottom-expected.txt:
  • platform/win/tables/mozilla/marvin/tfoot_valign_middle-expected.txt:
  • platform/win/tables/mozilla/marvin/tfoot_valign_top-expected.txt:
  • platform/win/tables/mozilla/marvin/th_valign_baseline-expected.txt:
  • platform/win/tables/mozilla/marvin/th_valign_bottom-expected.txt:
  • platform/win/tables/mozilla/marvin/th_valign_middle-expected.txt:
  • platform/win/tables/mozilla/marvin/th_valign_top-expected.txt:
  • platform/win/tables/mozilla/marvin/thead_align_center-expected.txt:
  • platform/win/tables/mozilla/marvin/thead_align_char-expected.txt:
  • platform/win/tables/mozilla/marvin/thead_align_justify-expected.txt:
  • platform/win/tables/mozilla/marvin/thead_align_left-expected.txt:
  • platform/win/tables/mozilla/marvin/thead_align_right-expected.txt:
  • platform/win/tables/mozilla/marvin/thead_char-expected.txt:
  • platform/win/tables/mozilla/marvin/thead_valign_baseline-expected.txt:
  • platform/win/tables/mozilla/marvin/thead_valign_bottom-expected.txt:
  • platform/win/tables/mozilla/marvin/thead_valign_middle-expected.txt:
  • platform/win/tables/mozilla/marvin/thead_valign_top-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_aqua_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_black-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_black_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_blue-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_blue_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_fuchsia-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_fuchsia_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_gray-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_gray_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_green-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_green_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_lime-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_lime_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_maroon-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_maroon_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_navy-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_navy_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_olive-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_olive_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_purple-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_purple_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_red-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_red_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_silver-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_silver_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_teal-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_teal_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_white-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_white_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_yellow-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_bgcolor_yellow_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_valign_baseline-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_valign_bottom-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_valign_middle-expected.txt:
  • platform/win/tables/mozilla/marvin/tr_valign_top-expected.txt:
  • platform/win/tables/mozilla/marvin/x_caption_align_bottom-expected.txt:
  • platform/win/tables/mozilla/marvin/x_caption_align_top-expected.txt:
  • platform/win/tables/mozilla/marvin/x_col_align_char-expected.txt:
  • platform/win/tables/mozilla/marvin/x_col_span-expected.txt:
  • platform/win/tables/mozilla/marvin/x_col_valign_baseline-expected.txt:
  • platform/win/tables/mozilla/marvin/x_col_valign_bottom-expected.txt:
  • platform/win/tables/mozilla/marvin/x_col_valign_middle-expected.txt:
  • platform/win/tables/mozilla/marvin/x_col_valign_top-expected.txt:
  • platform/win/tables/mozilla/marvin/x_col_width_px-expected.txt:
  • platform/win/tables/mozilla/marvin/x_col_width_rel-expected.txt:
  • platform/win/tables/mozilla/marvin/x_colgroup_align_char-expected.txt:
  • platform/win/tables/mozilla/marvin/x_colgroup_span-expected.txt:
  • platform/win/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.txt:
  • platform/win/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.txt:
  • platform/win/tables/mozilla/marvin/x_colgroup_valign_middle-expected.txt:
  • platform/win/tables/mozilla/marvin/x_colgroup_valign_top-expected.txt:
  • platform/win/tables/mozilla/marvin/x_colgroup_width_rel-expected.txt:
  • platform/win/tables/mozilla/marvin/x_table-expected.txt:
  • platform/win/tables/mozilla/marvin/x_table_align_center-expected.txt:
  • platform/win/tables/mozilla/marvin/x_table_align_left-expected.txt:
  • platform/win/tables/mozilla/marvin/x_table_align_right-expected.txt:
  • platform/win/tables/mozilla/marvin/x_table_bgcolor_name-expected.txt:
  • platform/win/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.txt:
  • platform/win/tables/mozilla/marvin/x_table_border-expected.txt:
  • platform/win/tables/mozilla/marvin/x_table_border_none-expected.txt:
  • platform/win/tables/mozilla/marvin/x_table_border_px-expected.txt:
  • platform/win/tables/mozilla/marvin/x_table_cellpadding-expected.txt:
  • platform/win/tables/mozilla/marvin/x_table_cellpadding_pct-expected.txt:
  • platform/win/tables/mozilla/marvin/x_table_cellspacing-expected.txt:
  • platform/win/tables/mozilla/marvin/x_table_cellspacing_pct-expected.txt:
  • platform/win/tables/mozilla/marvin/x_table_frame_void-expected.txt:
  • platform/win/tables/mozilla/marvin/x_table_rules_groups-expected.txt:
  • platform/win/tables/mozilla/marvin/x_table_rules_none-expected.txt:
  • platform/win/tables/mozilla/marvin/x_table_style-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tbody_align_center-expected.txt:
  • platform/win/tables/mozilla/marvin/x_tbody_align_char-expected.txt:
4:26 AM Changeset in webkit [196007] by g.czajkowski@samsung.com
  • 2 edits in trunk/Tools

[EFL] Virtual Keyboard overlaps MiniBrowser's WebView
https://bugs.webkit.org/show_bug.cgi?id=153009

Reviewed by Gyuyoung Kim.

On mobile, virtual keyboard represented by ecore_imf module appears on
the top of application layer usually covering bottom part of the screen.
If the web page contains the editable content on the bottom of the page
it will be overlapped by keyboard which prevents user from seeing the
typed text.

Pack MiniBrowser layout into conformant widget to allow EFL to guess
the space that will be required by the keyboard, finally resizing it
to the desired size. As a result, webview gets resized and scrolled
into focused elements which makes the editable elements visible while
typing.

More details about elm_conformant widger can be found at:
https://docs.enlightenment.org/elementary/1.15.0/group__Conformant.html
https://docs.enlightenment.org/elementary/1.15.0/conformant_example.html

  • MiniBrowser/efl/main.c:

(window_create): pack a box into conformant widget.

3:39 AM BuildingGtk edited by alex
(diff)
3:35 AM Changeset in webkit [196006] by alex
  • 8 edits
    1 add in trunk

[GTK][EFL] Upgrade OpenWebRTC dependency
https://bugs.webkit.org/show_bug.cgi?id=153489

Reviewed by Philippe Normand.

.:

  • Source/cmake/FindOpenWebRTC.cmake: Bump OpenWebRTC dependency,

required to make the mediastream work.

Tools:

  • Scripts/run-gtk-tests:

(TestRunner): Avoid running the mediastream API test.

  • Scripts/webkitperl/FeatureList.pm: Stop compiling mediastream by

default for gtk and efl.

  • gtk/jhbuild-webrtc.modules: Added modules files with

dependencies required to compile and test the mediastream.

LayoutTests:

Skiped the mediastream tests by default, until we have the code
ready and gstreamer dependency is bumped.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
3:00 AM Changeset in webkit [196005] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit2

[GTK] Several tests fail due to assert not reached in DrawingArea::dispatchAfterEnsuringDrawing()
https://bugs.webkit.org/show_bug.cgi?id=153785

Patch by Adrien Plazas <aplazas@igalia.com> on 2016-02-02
Reviewed by Carlos Garcia Campos.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::dispatchAfterEnsuringDrawing):

  • UIProcess/DrawingAreaProxyImpl.h:

Feb 1, 2016:

10:35 PM Changeset in webkit [196004] by Chris Dumez
  • 3 edits
    2 adds in trunk

object.lookupGetter() / object.lookupSetter() does not work for native bindings
https://bugs.webkit.org/show_bug.cgi?id=153765
<rdar://problem/24439699>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

Add support for CustomAccessor slots to objectProtoFuncLookupGetter() and
objectProtoFuncLookupSetter() by return getOwnPropertyDescriptor().get / set.
getOwnPropertyDescriptor() now correctly deals with CustomAccessors since
r196001.

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncLookupGetter):
(JSC::objectProtoFuncLookupSetter):

LayoutTests:

Add layout tests to test that object.lookupGetter() / object.lookupSetter()
works for native bindings.

  • js/lookupGetterGetter-native-bindings-expected.txt: Added.
  • js/lookupGetterGetter-native-bindings.html: Added.
10:15 PM Changeset in webkit [196003] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Option+Up/Down should not move cursor outside of number
https://bugs.webkit.org/show_bug.cgi?id=153784
<rdar://problem/24453133>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-02-01
Reviewed by Timothy Hatcher.

  • UserInterface/Views/CodeMirrorAdditions.js:

When selectionStart === selectionEnd we were duplicating the
movement mutation by performing it twice on the same object.
After much experimentation, I left in the existing code path
for handling mutation with a selection. It is not perfect,
but it is better then just applying the ch diff.

10:12 PM Changeset in webkit [196002] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed, fix http/tests/security/cross-origin-window-property-access.html

Update http/tests/security/cross-origin-window-property-access.html that was
introduced in r196001 so that it does not assert on Mac DRT. Mac DRT asserts
that testRunner.waitUntilDone() must be called *BEFORE* calling window.open().

  • http/tests/security/cross-origin-window-property-access.html:
7:47 PM Changeset in webkit [196001] by Chris Dumez
  • 19 edits
    13 adds in trunk

Native Bindings Descriptors are Incomplete
https://bugs.webkit.org/show_bug.cgi?id=140575
<rdar://problem/19506502>

Reviewed by Oliver Hunt.

LayoutTests/imported/w3c:

Rebaseline several W3C tests now that a lot more checks are passing.

  • web-platform-tests/XMLHttpRequest/interfaces-expected.txt:
  • web-platform-tests/dom/interfaces-expected.txt:
  • web-platform-tests/html/dom/interfaces-expected.txt:

Source/JavaScriptCore:

This patch is based on initial work by Joe Pecoraro and Matthew Mirman.

This patch was initially rolled out for breaking chromeexperiments.com,
presumably because our IDL attributes were not marked as [configurable]
at the time. However, since r190104, our IDL attributes are now
configurable. Based on local testing, chromeexperiments.com seems to be
working fine now.

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • inspector/InjectedScriptSource.js:

(endsWith):
(InjectedScript.prototype.processProperties):

  • runtime/JSBoundSlotBaseFunction.cpp: Added.

(JSC::boundSlotBaseFunctionCall):
(JSC::JSBoundSlotBaseFunction::JSBoundSlotBaseFunction):
(JSC::JSBoundSlotBaseFunction::create):
(JSC::JSBoundSlotBaseFunction::visitChildren):
(JSC::JSBoundSlotBaseFunction::finishCreation):

  • runtime/JSBoundSlotBaseFunction.h: Added.

(JSC::JSBoundSlotBaseFunction::createStructure):
(JSC::JSBoundSlotBaseFunction::boundSlotBase):
(JSC::JSBoundSlotBaseFunction::customGetterSetter):
(JSC::JSBoundSlotBaseFunction::isSetter):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):
(JSC::JSGlobalObject::visitChildren):

  • runtime/JSGlobalObject.h:

(JSC::JSGlobalObject::boundSlotBaseFunctionStructure):

  • runtime/JSObject.cpp:

(JSC::getBoundSlotBaseFunctionForGetterSetter):
(JSC::JSObject::getOwnPropertyDescriptor):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

LayoutTests:

Add test coverage.

  • http/tests/security/cross-origin-window-property-access-expected.txt: Added.
  • http/tests/security/cross-origin-window-property-access.html: Added.
  • inspector/runtime/getProperties-expected.txt:
  • js/dom/native-bindings-descriptors-expected.txt: Added.
  • js/dom/native-bindings-descriptors.html: Added.
  • js/dom/native-bindings-descriptors2-expected.txt: Added.
  • js/dom/native-bindings-descriptors2.html: Added.
  • js/dom/native-bindings-descriptors3-expected.txt: Added.
  • js/dom/native-bindings-descriptors3.html: Added.
  • js/dom/native-bindings-descriptors4-expected.txt: Added.
  • js/dom/native-bindings-descriptors4.html: Added.
  • js/dom/native-bindings-descriptors5-expected.txt: Added.
  • js/dom/native-bindings-descriptors5.html: Added.
6:35 PM Changeset in webkit [196000] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

[GTK] [EFL] [AppleWin] Layout Test fast/shadow-dom/slot-removal-crash-2.html timeouts
https://bugs.webkit.org/show_bug.cgi?id=153772

Reviewed by Michael Catanzaro.

Don't call wait untilDone if attachShadow is not available.

  • fast/shadow-dom/slot-removal-crash-2.html:
5:52 PM Changeset in webkit [195999] by Joseph Pecoraro
  • 32 edits
    6 copies
    14 adds in trunk

Web Inspector: High Level Memory Overview Instrument
https://bugs.webkit.org/show_bug.cgi?id=153516
<rdar://problem/24356378>

Reviewed by Brian Burg.

Source/JavaScriptCore:

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • inspector/protocol/Memory.json: Added.
  • inspector/scripts/codegen/generator.py:

New Memory domain guarded by ENABLE(RESOURCE_USAGE).
This feature flag was already used in WebCore.

Source/WebCore:

Add a new agent that gathers data from the ResourceUsageThread
and sends to the frontend.

Test: inspector/memory/tracking.html

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • WebCore.xcodeproj/project.pbxproj:

New files.

  • inspector/InspectorController.cpp:

(WebCore::InspectorController::InspectorController):
Add the new agent.

  • inspector/InspectorMemoryAgent.h: Added.
  • inspector/InspectorMemoryAgent.cpp: Added.

(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
(WebCore::InspectorMemoryAgent::didCreateFrontendAndBackend):
(WebCore::InspectorMemoryAgent::willDestroyFrontendAndBackend):
(WebCore::InspectorMemoryAgent::startTracking):
(WebCore::InspectorMemoryAgent::stopTracking):
(WebCore::InspectorMemoryAgent::collectSample):
Implement the agent by adding / removing it as a ResourceUsage
observer. When receiving the data forward it to the frontend.

Source/WebInspectorUI:

Use the new "Memory" domain to track page memory size over time.
This allows the timeline to help visualize total process memory
broken down into a few different categories. The timeline graph
allows seeing the total size over time, and you can drill in to
a specific section and get a better breakdown and comparison
of the different categories of memory that we currently track.

  • Localizations/en.lproj/localizedStrings.js:

New UI strings.

  • UserInterface/Main.html:

New files.

  • UserInterface/Base/Main.js:

(WebInspector.loaded):

  • UserInterface/Protocol/MemoryObserver.js:

(WebInspector.MemoryObserver.prototype.trackingStart):
(WebInspector.MemoryObserver.prototype.trackingUpdate):
(WebInspector.MemoryObserver.prototype.trackingComplete):
Add a memory observer.

  • UserInterface/Controllers/TimelineManager.js:

(WebInspector.TimelineManager.defaultInstruments):
(WebInspector.TimelineManager.prototype.memoryTrackingStart):
(WebInspector.TimelineManager.prototype.memoryTrackingUpdate):
(WebInspector.TimelineManager.prototype.memoryTrackingComplete):
Create Memory timeline records from Memory tracking updates.

  • UserInterface/Models/MemoryCategory.js:

(WebInspector.MemoryCategory):
Consolidate some of the raw data of categories we get from the backend
into a set of 4 user-facing categories.

  • UserInterface/Models/MemoryTimelineRecord.js: Added.

(WebInspector.MemoryTimelineRecord):
(WebInspector.MemoryTimelineRecord.memoryCategoriesFromProtocol):
(WebInspector.MemoryTimelineRecord.prototype.get timestamp):
(WebInspector.MemoryTimelineRecord.prototype.get categories):
(WebInspector.MemoryTimelineRecord.prototype.get totalSize):
(WebInspector.MemoryTimelineRecord.prototype.get startTime):
(WebInspector.MemoryTimelineRecord.prototype.get endTime):
Memory timeline record for the event data.

  • UserInterface/Models/MemoryInstrument.js:

(WebInspector.MemoryInstrument):
(WebInspector.MemoryInstrument.supported):
(WebInspector.MemoryInstrument.prototype.get timelineRecordType):
(WebInspector.MemoryInstrument.prototype.startInstrumentation):
(WebInspector.MemoryInstrument.prototype.stopInstrumentation):
Instrument to start / stop memory tracking.

  • UserInterface/Models/TimelineRecord.js:

Add a new "Memory" Timeline type.

  • UserInterface/Views/ContentView.js:

(WebInspector.ContentView.createFromRepresentedObject):

  • UserInterface/Models/TimelineRecording.js:

(WebInspector.TimelineRecording):
Add the new "Memory" Timeline.

(WebInspector.TimelineRecording.prototype.addRecord):
Memory timeline records do not show in the SourceCode Timelines Overview.

  • UserInterface/Views/CircleChart.css:

(.circle-chart):
(.circle-chart > svg > path.background):
(.circle-chart > .center):

  • UserInterface/Views/CircleChart.js: Added.

(WebInspector.CircleChart):
(WebInspector.CircleChart.prototype.get element):
(WebInspector.CircleChart.prototype.get points):
(WebInspector.CircleChart.prototype.get size):
(WebInspector.CircleChart.prototype.get centerElement):
(WebInspector.CircleChart.prototype.get segments):
(WebInspector.CircleChart.prototype.set segments):
(WebInspector.CircleChart.prototype.get values):
(WebInspector.CircleChart.prototype.set values):
(WebInspector.CircleChart.prototype.clear):
(WebInspector.CircleChart.prototype.needsLayout):
(WebInspector.CircleChart.prototype.updateLayout):
(WebInspector.CircleChart.prototype._needsLayout):
(WebInspector.CircleChart.prototype._createCompleteCirclePathData):
(WebInspector.CircleChart.prototype._createSegmentPathData):
(WebInspector.CircleChart.prototype._updateLayout):
Standalone circle "donut" chart, copied mostly from Rendering Frames Timeline.
Initialize the chart's segments, then feed it a set of ([v1, v2, ...]) values
corresponding to each of the segments.

  • UserInterface/Views/LineChart.js: Added.

(WebInspector.LineChart):
(WebInspector.LineChart.prototype.get element):
(WebInspector.LineChart.prototype.get points):
(WebInspector.LineChart.prototype.get size):
(WebInspector.LineChart.prototype.set size):
(WebInspector.LineChart.prototype.addPoint):
(WebInspector.LineChart.prototype.clear):
(WebInspector.LineChart.prototype.needsLayout):
(WebInspector.LineChart.prototype.updateLayout):
(WebInspector.LineChart.prototype._needsLayout):
(WebInspector.LineChart.prototype._updateLayout):
Standalone line chart. Uses a single SVG path, given a set of (x, y) points.

  • UserInterface/Views/StackedLineChart.js: Added.

(WebInspector.StackedLineChart):
(WebInspector.StackedLineChart.prototype.get element):
(WebInspector.StackedLineChart.prototype.get points):
(WebInspector.StackedLineChart.prototype.get size):
(WebInspector.StackedLineChart.prototype.set size):
(WebInspector.StackedLineChart.prototype.initializeSections):
(WebInspector.StackedLineChart.prototype.addPointSet):
(WebInspector.StackedLineChart.prototype.clear):
(WebInspector.StackedLineChart.prototype.needsLayout):
(WebInspector.StackedLineChart.prototype.updateLayout):
(WebInspector.StackedLineChart.prototype._needsLayout):
(WebInspector.StackedLineChart.prototype._updateLayout):
Standalone stacked line chart. Initialize the chart's sections,
then feed it a set of (x, [y1, y2 ...]) points where the y
values correspond to each of the sections.

  • UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview.prototype.get scrollContainerWidth):
Add a way to get this value without forcing layout all the time.

  • UserInterface/Views/TimelineTabContentView.js:

(WebInspector.TimelineTabContentView.displayNameForTimeline):
(WebInspector.TimelineTabContentView.iconClassNameForTimeline):
(WebInspector.TimelineTabContentView.genericClassNameForTimeline):
(WebInspector.TimelineTabContentView.iconClassNameForRecord):
(WebInspector.TimelineTabContentView.displayNameForRecord):
Add placeholders for the new Memory Timeline Type.

  • UserInterface/Views/MemoryCategoryView.css:

(.memory-category-view):
(.memory-category-view > .details):
(.memory-category-view > .details > .name):
(.memory-category-view > .graph):

  • UserInterface/Views/MemoryCategoryView.js: Added.

(WebInspector.MemoryCategoryView):
(WebInspector.MemoryCategoryView.prototype.get element):
(WebInspector.MemoryCategoryView.prototype.get category):
(WebInspector.MemoryCategoryView.prototype.clear):
(WebInspector.MemoryCategoryView.prototype.layoutWithDataPoints):
(WebInspector.MemoryCategoryView.prototype._updateDetails):

  • UserInterface/Views/MemoryTimelineOverviewGraph.css:

(body .timeline-overview > .graphs-container > .timeline-overview-graph.memory):
(.timeline-overview-graph.memory):
(.timeline-overview-graph.memory > .legend):
(.timeline-overview-graph.memory > .stacked-line-chart > svg > path.javascript):
(.timeline-overview-graph.memory > .stacked-line-chart > svg > path.images):
(.timeline-overview-graph.memory > .stacked-line-chart > svg > path.layers):
(.timeline-overview-graph.memory > .stacked-line-chart > svg > path.page):

  • UserInterface/Views/MemoryTimelineOverviewGraph.js: Added.

(WebInspector.MemoryTimelineOverviewGraph):
(WebInspector.MemoryTimelineOverviewGraph.prototype.get height):
(WebInspector.MemoryTimelineOverviewGraph.prototype.reset):
(WebInspector.MemoryTimelineOverviewGraph.prototype.layout.timeToX):
(WebInspector.MemoryTimelineOverviewGraph.prototype.layout.sizeToY):
(WebInspector.MemoryTimelineOverviewGraph.prototype.layout.sizesToYs):
(WebInspector.MemoryTimelineOverviewGraph.prototype.layout.ysForRecord):
(WebInspector.MemoryTimelineOverviewGraph.prototype.layout):
(WebInspector.MemoryTimelineOverviewGraph.prototype._updateLegend):
(WebInspector.MemoryTimelineOverviewGraph.prototype._visibleRecords):
(WebInspector.MemoryTimelineOverviewGraph.prototype._memoryTimelineRecordAdded):

  • UserInterface/Views/MemoryTimelineView.css: Added.

(.timeline-view.memory):
(.timeline-view.memory > .content):
(.timeline-view.memory > .content > .overview):
(.timeline-view.memory > .content .title):
(.timeline-view.memory > .content .subtitle):
(.timeline-view.memory > .content > .details > .timeline-ruler):
(.timeline-view.memory > .content > .details > .subtitle):
(.timeline-view.memory > .content > .overview > .chart):
(.timeline-view.memory > .content > .overview > .chart > .subtitle):
(.timeline-view.memory > .content > .overview > .chart > .container):
(.timeline-view.memory > .content > .overview > .divider):
(.timeline-view.memory > .content > .overview .max-percentage):
(.timeline-view.memory .legend):
(.timeline-view.memory .legend > .row):
(.timeline-view.memory .legend > .row > .swatch):
(.timeline-view.memory .legend > .row > p):
(.timeline-view.memory .legend > .row > .label):
(.timeline-view.memory .legend > .row > .size):
(.timeline-view.memory .legend > .row > .swatch.javascript):
(.timeline-view.memory .legend > .row > .swatch.images):
(.timeline-view.memory .legend > .row > .swatch.layers):
(.timeline-view.memory .legend > .row > .swatch.page):
(.memory-category-view.javascript .line-chart > svg > path):
(.memory-category-view.images .line-chart > svg > path):
(.memory-category-view.layers .line-chart > svg > path):
(.memory-category-view.page .line-chart > svg > path):
(.timeline-view.memory .legend > .row > .swatch.current):
(.timeline-view.memory .circle-chart > svg > path.current):
(.timeline-view.memory .circle-chart > svg > path.remainder):

  • UserInterface/Views/MemoryTimelineView.js: Added.

(WebInspector.MemoryTimelineView):
(WebInspector.MemoryTimelineView.displayNameForCategory):
(WebInspector.MemoryTimelineView.prototype.get navigationSidebarTreeOutlineLabel):
(WebInspector.MemoryTimelineView.prototype.shown):
(WebInspector.MemoryTimelineView.prototype.hidden):
(WebInspector.MemoryTimelineView.prototype.closed):
(WebInspector.MemoryTimelineView.prototype.reset):
(WebInspector.MemoryTimelineView.prototype.treeElementPathComponentSelected):
(WebInspector.MemoryTimelineView.prototype.layout.timeToX):
(WebInspector.MemoryTimelineView.prototype.layout.sizeToY):
(WebInspector.MemoryTimelineView.prototype.layout.layoutCategoryView):
(WebInspector.MemoryTimelineView.prototype.layout):
(WebInspector.MemoryTimelineView.prototype._clearUsageLegend):
(WebInspector.MemoryTimelineView.prototype._updateUsageLegend):
(WebInspector.MemoryTimelineView.prototype._clearMaxComparisonLegend):
(WebInspector.MemoryTimelineView.prototype._updateMaxComparisonLegend):
(WebInspector.MemoryTimelineView.prototype._visibleRecords):
(WebInspector.MemoryTimelineView.prototype._initializeCategoryViews.appendLegendRow):
(WebInspector.MemoryTimelineView.prototype._initializeCategoryViews):
(WebInspector.MemoryTimelineView.prototype._memoryTimelineRecordAdded):

  • UserInterface/Views/Variables.css:

(:root):
Memory timeline view styles.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

LayoutTests:

  • inspector/memory/tracking-expected.txt: Added.
  • inspector/memory/tracking.html: Added.

Basic test for the new domain tracking commands and events.

  • platform/efl/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/win/TestExpectations:

Skip the directory on ports that have not implemented ENABLE(RESOURCE_USAGE).

5:51 PM Changeset in webkit [195998] by achristensen@apple.com
  • 4 edits in trunk/Source

Fix CMake build.

  • PlatformMac.cmake:
5:42 PM Changeset in webkit [195997] by beidson@apple.com
  • 13 edits
    2 adds in trunk/Source/WebCore

Modern IDB: Cursors (still) do not keep their opening request alive.
https://bugs.webkit.org/show_bug.cgi?id=153724

Reviewed by Alex Christensen.

No new tests (All existing tests pass without flakiness).

IDBCursors did not properly keep their JS wrappers alive.
Making them ActiveDOMObjects that keep track of how many requests might be in flight fixes this.
This also makes them actually keep their opening-request live via the opaque-root mechanism.

IDBCursorWithValue also needed to opt in to all of these mechanisms.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • Modules/indexeddb/IDBCursor.h:

(WebCore::IDBCursor::hasPendingActivity): The base IDBCursor always has no pending activity,

to maintain current behavior in LegacyIDB. This weirdness will go away when LegacyIDB does.

  • Modules/indexeddb/IDBCursor.idl:
  • Modules/indexeddb/IDBCursorWithValue.idl:

Track a count for all outstanding requests to keep the cursor alive as an ActiveDOMObject.

  • Modules/indexeddb/client/IDBCursorImpl.cpp:

(WebCore::IDBClient::IDBCursor::IDBCursor):
(WebCore::IDBClient::IDBCursor::update):
(WebCore::IDBClient::IDBCursor::uncheckedIterateCursor):
(WebCore::IDBClient::IDBCursor::deleteFunction):
(WebCore::IDBClient::IDBCursor::activeDOMObjectName):
(WebCore::IDBClient::IDBCursor::canSuspendForDocumentSuspension):
(WebCore::IDBClient::IDBCursor::hasPendingActivity):
(WebCore::IDBClient::IDBCursor::decrementOutstandingRequestCount):

  • Modules/indexeddb/client/IDBCursorImpl.h:

Rework the "delete" family of functions on the object store to allow for returning a modern IDBRequest.
A lot of this can go away when LegacyIDB does.

  • Modules/indexeddb/client/IDBObjectStoreImpl.cpp:

(WebCore::IDBClient::IDBObjectStore::deleteFunction):
(WebCore::IDBClient::IDBObjectStore::doDelete):
(WebCore::IDBClient::IDBObjectStore::modernDelete):

  • Modules/indexeddb/client/IDBObjectStoreImpl.h:
  • Modules/indexeddb/client/IDBRequestImpl.cpp:

(WebCore::IDBClient::IDBRequest::setSource): Setup a ScopeGuard to decrement the cursor's request

count whenever it makes sense to do so.

(WebCore::IDBClient::IDBRequest::dispatchEvent): Clear the ScopeGuard (if it exists) to decrement the count.
(WebCore::IDBClient::IDBRequest::willIterateCursor): Set the ScopeGuard.
(WebCore::IDBClient::IDBRequest::didOpenOrIterateCursor): Clear the ScopeGuard (if it exists) to decrement the count.

  • Modules/indexeddb/client/IDBRequestImpl.h:
  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::ScopeGuard::ScopeGuard): Deleted.
(WebCore::IDBServer::ScopeGuard::~ScopeGuard): Deleted.
(WebCore::IDBServer::ScopeGuard::enable): Deleted.
(WebCore::IDBServer::ScopeGuard::disable): Deleted.

  • bindings/js/JSIDBCursorWithValueCustom.cpp: Added.

(WebCore::JSIDBCursorWithValue::visitAdditionalChildren):

  • platform/ScopeGuard.h: Added.

(WebCore::ScopeGuard::ScopeGuard):
(WebCore::ScopeGuard::~ScopeGuard):
(WebCore::ScopeGuard::enable):
(WebCore::ScopeGuard::disable):

5:39 PM Changeset in webkit [195996] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skipping http/tests/plugins/visible_plugins.html on Yosemite during investigation.
https://bugs.webkit.org/show_bug.cgi?id=153752

Unreviewed test gardening.

  • platform/mac/TestExpectations:
5:27 PM Changeset in webkit [195995] by Matt Baker
  • 8 edits in trunk/Source/WebInspectorUI

Web Inspector: add a LayoutReason enum to the View base class
https://bugs.webkit.org/show_bug.cgi?id=153731
<rdar://problem/24430938>

Reviewed by Brian Burg.

Added a LayoutReason enum to the View base class, which can be passed as an optional
argument to needsLayout() and updateLayout(). The value is propagated to the view's
subtree during layout.

  • UserInterface/Base/Main.js:

Update top-level views with Resize layout reason when window is resized.

  • UserInterface/Views/DataGrid.js:

(WebInspector.DataGrid.prototype._positionHeaderViews):
Update header view with Resize layout reason when column is resized.

  • UserInterface/Views/OverviewTimelineView.js:

(WebInspector.OverviewTimelineView.prototype.shown):
Assume the view has been resized when shown, and update layout.
(WebInspector.OverviewTimelineView.prototype.updateLayoutForResize): Deleted.
No longer needed, handled by the View base class.

  • UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview.prototype.shown):
Assume the view has been resized when shown, and update layout.
(WebInspector.TimelineOverview.prototype.layout):
Invalidate cached scroll container width if resized.
(WebInspector.TimelineOverview.prototype.updateLayoutForResize): Deleted.
No longer needed, handled by the View base class.

  • UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView.prototype.layout): Deleted.
No longer needed, handled by the View base class.

  • UserInterface/Views/TimelineRuler.js:

(WebInspector.TimelineRuler.prototype.needsLayout):
(WebInspector.TimelineRuler.prototype.layout):
Update cached client width if resized.
(WebInspector.TimelineRuler.prototype.resize): Deleted.
Moved resize logic to layout override.

  • UserInterface/Views/View.js:

(WebInspector.View):
(WebInspector.View.prototype.updateLayout):
Set layout reason.
(WebInspector.View.prototype.needsLayout):
Set layout reason even if an animation frame has already been scheduled,
since the layout reason could have changed.
(WebInspector.View.prototype._layoutSubtree):
Propagate layout reason to subtree, and reset the value when done.
(WebInspector.View.prototype._setLayoutReason):
Helper method for updating the layout reason. Ensures that LayoutReason.Resize
has priority over the default (LayoutReason.Dirty).

5:12 PM Changeset in webkit [195994] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection-1.html as flaky on Mac debug
https://bugs.webkit.org/show_bug.cgi?id=153781

Unreviewed test gardening.

  • platform/mac/TestExpectations:
4:55 PM Changeset in webkit [195993] by jmarcell@apple.com
  • 4 edits
    1 add in trunk/Tools

Add code to parse the git branches out of the Trac RSS feed https://bugs.webkit.org/show_bug.cgi?id=153624

Reviewed by Daniel Bates.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Trac.js:

(Trac.prototype.commitsOnBranch): Update filter to check for Git branches.
(Trac.prototype._convertCommitInfoElementToObject): Parse Git branches from the Trac RSS feed. Also changed "branchName" to
"branches" and updated the code to work with an array instead of a string.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:

(MockTrac): Refactored example commits out into a constant, MockTrac.EXAMPLE_TRAC_COMMITS.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/test-fixture-git-trac-rss.xml: Added. Test

fixture that contains XML with a Git branch.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Added unit test to test parsing Git

branches from Trac RSS feed. Also updated code to work with the new MockTrac.EXAMPLE_TRAC_COMMITS constant.

4:46 PM Changeset in webkit [195992] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Free Colormap when XWindow is destroyed.
https://bugs.webkit.org/show_bug.cgi?id=153413

Patch by Sun-woo Nam <sunny.nam@samsung.com> on 2016-02-01
Reviewed by Žan Doberšek.

Colormap is needed to create XWindow and it should be freed when XWindow is destroyed.
Unless Colormap is freed before destroying XWindow, memory leak is suspected.
XFreeColormap therefore is needed on X11Helper.

  • platform/graphics/surfaces/glx/X11Helper.cpp: Added XFreeColormap.

(WebCore::X11Helper::destroyWindow):

4:45 PM Changeset in webkit [195991] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

More iOS build fix.

  • Platform/spi/ios/UIKitSPI.h:
4:41 PM Changeset in webkit [195990] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

iOS build fix.

  • Platform/IPC/mac/ConnectionMac.mm:
4:35 PM Changeset in webkit [195989] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

Copy sandbox profiles during installhdrs.

Reviewed by Anders Carlsson.

  • Configurations/SandboxProfiles.xcconfig:
4:32 PM Changeset in webkit [195988] by matthew_hanson@apple.com
  • 1 edit
    2 adds in branches/safari-601-branch/LayoutTests

Merge Layout Tests for r191331. rdar://problem/24448992

4:20 PM Changeset in webkit [195987] by matthew_hanson@apple.com
  • 3 edits
    2 adds in branches/safari-601-branch

Merge r195837. rdar://problem/24002220

4:19 PM WebKitGTK/Gardening/Calendar edited by clopez@igalia.com
(diff)
4:00 PM Changeset in webkit [195986] by clopez@igalia.com
  • 4 edits in trunk/LayoutTests

[GTK] Unreviewed GTK+ Gardening.

  • platform/efl/TestExpectations: Add fast/shadow-dom/slot-removal-crash-2.html timeout expectation.
  • platform/gtk/TestExpectations: Report and update a bunch of test expectations.
  • platform/win/TestExpectations: Add fast/shadow-dom/slot-removal-crash-2.html timeout expectation.
3:55 PM Changeset in webkit [195985] by mitz@apple.com
  • 7 edits in trunk/Source/WebKit2

[Cocoa] Remove some more has_include guards
https://bugs.webkit.org/show_bug.cgi?id=153774

Reviewed by Tim Horton.

Guard private header includes with #if USE(APPLE_INTERNAL_SDK) rather than with has_include.

  • Platform/IPC/mac/ConnectionMac.mm:
  • Platform/IPC/mac/ImportanceAssertion.h:
  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
  • Shared/cf/ArgumentCodersCF.cpp:
  • Shared/mac/ChildProcessMac.mm:
  • Shared/mac/SecItemShim.cpp:
3:40 PM Changeset in webkit [195984] by beidson@apple.com
  • 2 edits in trunk/Tools

Add command line flag to DRT to output the number of tests completed in server mode.
https://bugs.webkit.org/show_bug.cgi?id=153750

Reviewed by Darin Adler.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(initializeGlobalsFromCommandLineOptions):
(runTestingServerLoop):

3:37 PM Changeset in webkit [195983] by mitz@apple.com
  • 3 edits in trunk/Source/WebKit2

[Xcode] Let Xcode know that the WebKit XPC service products are XPC services
https://bugs.webkit.org/show_bug.cgi?id=153773

Reviewed by Tim Horton.

  • Configurations/BaseXPCService.xcconfig: Removed now-redundant definitions of MACH_O_TYPE and WRAPPER_EXTENSION.
  • WebKit2.xcodeproj/project.pbxproj: Updated product types.
3:31 PM Changeset in webkit [195982] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Crash using WKPDFView, in -[UIPDFPageView showContent]
https://bugs.webkit.org/show_bug.cgi?id=153770
<rdar://problem/20157864>

Reviewed by Anders Carlsson.

When scrolling, we throw away UIPDFPageViews, but forget to unhook their delegates.
In some cases (also because their delegate is a raw pointer, not weak), they can call
back into a deleted WKPDFView, causing a crash.

  • UIProcess/ios/WKPDFView.mm:

(detachViewForPage):
Add a helper to detach a page view, and unhook its delegates.

(-[WKPDFView _clearPages]):
(-[WKPDFView _revalidateViews]):
Make use of the new helper.

3:19 PM Changeset in webkit [195981] by benjamin@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[JSC] IRC can coalesce the frame pointer with a Tmp that is modified
https://bugs.webkit.org/show_bug.cgi?id=153694

Reviewed by Filip Pizlo.

Let's say we have:

Move(FP, Tmp1)
Add64(#1, Tmp1)

If we were to coalesce the Move, we would modify the frame pointer.
Well, that's exactly what was happening with IRC.

Since the epilogue is not know to Air before IRC, the liveness analysis
never discovers that FP is live when Tmp1 is UseDef by Add64. Adding
FP would a be a problem anyway for a bunch of reasons.

I tried two ways to prevent IRC to override IRC:
1) Add an interference edge with FP for all non-duplication Defs.
2) Let coalesce() know about FP and constraint any coalescing with a re-Def.

The two are within margin of error for performance. The second one was considerably
more complicated. This patch implements the first one.

Some extra note:
-It is very important to not increment the degree of a Tmp when making it interfere

with FP. FP is not a valid color, it is not counted in the "K" colors considered
for coloring. Increasing the degree with the edge to FP would make every stage
pessimistic since there is an extra degree that can never be removed.

-I put "interferenceEdges" and "adjacencyList" in an inconsistent state.

This is intentional, "interferenceEdges" is used to test the existence of an edge,
"adjacencyList" is used to go over all the edges. In this case, we don't want
the edge with FP to be considered when pruning the graph.

  • b3/air/AirIteratedRegisterCoalescing.cpp:

One branch could be transformed into an assertion: TmpLiveness is type specific now.

  • b3/testb3.cpp:

(JSC::B3::testOverrideFramePointer):
(JSC::B3::run):

2:13 PM Changeset in webkit [195980] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking imported/w3c/web-platform-tests/XMLHttpRequest/open-url-multi-window-4.htm as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153336

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
2:07 PM Changeset in webkit [195979] by timothy_horton@apple.com
  • 3 edits in trunk/Source/WebCore

Move some SPI declarations into the appropriate SPI header
https://bugs.webkit.org/show_bug.cgi?id=153755

Reviewed by Darin Adler.

  • platform/graphics/cocoa/IOSurface.mm:
  • platform/spi/cg/CoreGraphicsSPI.h:
1:50 PM Changeset in webkit [195978] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking http/tests/appcache/404-resource-with-slow-main-resource.php as flaky on ios-simulator-wk2
https://bugs.webkit.org/show_bug.cgi?id=153503

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
1:31 PM Changeset in webkit [195977] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking fast/replaced/preferred-widths.html as flaky on ios-simulator
https://bugs.webkit.org/show_bug.cgi?id=153311

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
1:25 PM Changeset in webkit [195976] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip fast/shadow-dom/touch-event-ios.html on ios-simulator since touch events are not supported.
https://bugs.webkit.org/show_bug.cgi?id=149592

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
12:47 PM Changeset in webkit [195975] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Snapshot surfaces are forever wired after being compressed
https://bugs.webkit.org/show_bug.cgi?id=153751
<rdar://problem/24354546>

Reviewed by Darin Adler.

  • platform/graphics/cocoa/IOSurface.mm:

(IOSurface::convertToFormat):
Allow IOSurfaceAccelerator to unwire surfaces after they're transformed.

12:40 PM Changeset in webkit [195974] by bshafiei@apple.com
  • 2 edits in tags/Safari-602.1.18.0.1/Source/WebKit2

Merged r195964. rdar://problem/24424987

12:35 PM Changeset in webkit [195973] by bshafiei@apple.com
  • 5 edits in tags/Safari-602.1.18.0.1/Source

Versioning.

12:33 PM Changeset in webkit [195972] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.18.0.1

New tag.

12:23 PM Changeset in webkit [195971] by mitz@apple.com
  • 5 edits in trunk/Source

<rdar://problem/20150072> [iOS] Remove some file upload code only needed before iOS 9
https://bugs.webkit.org/show_bug.cgi?id=153754

Reviewed by Darin Adler.

Source/WebCore:

  • English.lproj/Localizable.strings: Updated for removal of WebKit2 string.

Source/WebKit2:

  • Platform/spi/ios/UIKitSPI.h: Removed conditional forward declaration of SPI.
  • UIProcess/ios/forms/WKFileUploadPanel.mm:

(photoLibraryIcon): Removed check for HAVE_WEBKIT_DOC_PICKER_ICONS, which is always true in

iOS 9 and later.

(cameraIcon): Ditto.
(-[WKFileUploadPanel presentWithParameters:resultListener:]): Removed branch for when

UIDocumentMenuViewController doesn’t respond to
-_initIgnoringApplicationEntitlementForImportOfTypes:.

(-[WKFileUploadPanel _showMediaSourceSelectionSheet]): Deleted now-unused method.

11:45 AM Changeset in webkit [195970] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Cache the Path instead of creating it every time it is required
https://bugs.webkit.org/show_bug.cgi?id=152939

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-02-01
Reviewed by Darin Adler.

Source/WebCore:

Instead of creating the Path object every time it is required, we should
cache it in an LRU cache. TinyLRUCache returns a reference to the cached
entry so we do not have to pay the cost of copying it either.

  • platform/graphics/FloatRoundedRect.h:

(WebCore::operator!=):
Implement the inequality operator for FloatRoundedRect since it is
called by TinyLRUCache.

  • rendering/ClipPathOperation.h:

Return a reference to the path in the cache since instead of creating a
new copy.

  • rendering/style/BasicShapes.cpp:

(WebCore::SVGPathTranslatedByteStream::SVGPathTranslatedByteStream):
(WebCore::SVGPathTranslatedByteStream::operator==):
(WebCore::SVGPathTranslatedByteStream::operator!=):
(WebCore::SVGPathTranslatedByteStream::isEmpty):
(WebCore::SVGPathTranslatedByteStream::path):
This struct holds an offset and an SVGPathByteStream. It is the key of
the LRU cache for the the translated SVGPathByteStream.

(WebCore::EllipsePathPolicy::isKeyNull):
(WebCore::EllipsePathPolicy::createValueForKey):
(WebCore::RoundedRectPathPolicy::isKeyNull):
(WebCore::RoundedRectPathPolicy::createValueForKey):
(WebCore::PolygonPathPolicy::isKeyNull):
(WebCore::PolygonPathPolicy::createValueForKey):
(WebCore::TranslatedByteStreamPathPolicy::isKeyNull):
(WebCore::TranslatedByteStreamPathPolicy::createValueForKey):
Inherit from the LRU cache policy template, so have a specific name for
the desired path contents and pass this class explicitly to the LRU cache
template.

(WebCore::cachedEllipsePath):
(WebCore::cachedRoundedRectPath):
(WebCore::cachedPolygonPath):
(WebCore::cachedTranslatedByteStreamPath):
Return a cached path object for specific path contents.

(WebCore::BasicShapeCircle::path):
(WebCore::BasicShapeEllipse::path):
(WebCore::BasicShapePolygon::path):
(WebCore::BasicShapePath::path):
(WebCore::BasicShapeInset::path):
Get the Path object from the cache; create a new one if it does not exist.

  • rendering/style/BasicShapes.h:

Change the prototype of the path() function to return a reference to the
path in the cache instead of a having to copying it.

  • svg/SVGPathByteStream.h:

(WebCore::SVGPathByteStream::operator!=):
Implement the inequality operator for SVGPathByteStream because it is
called by TinyLRUCache.

Source/WTF:

If the key type of an LRU cache can't to be strongly tided to a specific
data type; e.g. FloatRect -> Path, we need to be able to pass the policy
type to the TinyLRUCache template instead of just specializing it. This
will make the code more readable and will allow different caches for the
same key type.

  • wtf/TinyLRUCache.h:

(WebCore::TinyLRUCache::get):

11:42 AM Changeset in webkit [195969] by Chris Dumez
  • 20 edits in trunk

Move properties that use custom bindings to the prototype
https://bugs.webkit.org/show_bug.cgi?id=153735

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline several W3C tests now that more checks are passing.

  • web-platform-tests/dom/interfaces-expected.txt:
  • web-platform-tests/html/dom/interfaces-expected.txt:
  • web-platform-tests/XMLHttpRequest/interfaces-expected.txt:

Source/WebCore:

Move properties that use custom bindings to the prototype. Whether a
property's bindings code is generated or custom-written should not
impact where the property is located.

No new tests, already covered by existing tests.

  • bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::getOwnPropertySlot):
Add null-check for staticPropHashTable. HTMLDocument no longer has
any property on the instance so staticPropHashTable is now null.

  • bindings/scripts/CodeGeneratorJS.pm:

LayoutTests:

Rebaseline / update existing tests now that properties using custom
bindings are on the prototype, as expected.

  • fast/mediastream/MediaStream-video-element-expected.txt:
  • fast/xmlhttprequest/xmlhttprequest-properties-prototype-expected.txt:
  • inspector/model/remote-object-get-properties-expected.txt:
  • js/dom/dom-attributes-on-mismatch-type-expected.txt:
  • js/dom/dom-attributes-on-mismatch-type.html:
  • platform/mac/inspector/model/remote-object-expected.txt:
11:05 AM Changeset in webkit [195968] by achristensen@apple.com
  • 5 edits in trunk

[Win] WTFHeaderDetection.h no longer needed
https://bugs.webkit.org/show_bug.cgi?id=153753
rdar://problem/24434627

Reviewed by Darin Adler.

.:

  • Source/cmake/WebKitFS.cmake:

Source/WTF:

  • wtf/Platform.h:
  • wtf/PlatformWin.cmake:
10:24 AM Changeset in webkit [195967] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Rendering Frames timeline draws all frame bars at minimum height
https://bugs.webkit.org/show_bug.cgi?id=153736
<rdar://problem/21946301>

Reviewed by Timothy Hatcher.

  • UserInterface/Views/TimelineRecordingContentView.js:

(WebInspector.TimelineRecordingContentView.prototype._currentContentViewDidChange):
Update the new timeline overview's height before it's shown. Showing the
overview causes the rendering frames graph to do a layout, which requires
the height of the containing view to be a valid value.

10:22 AM Changeset in webkit [195966] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: DataGridNode should support adding go-to arrow buttons to any cell
https://bugs.webkit.org/show_bug.cgi?id=153733
<rdar://problem/24431813>

Reviewed by Brian Burg.

Provide a way to add go-to arrow buttons to any grid cell from within a
DataGridNode subclass's implementation of createCellContent.

  • UserInterface/Views/DataGrid.js:

New event type, GoToArrowClicked.
(WebInspector.DataGridNode.prototype.createGoToArrowButton.buttonClicked):
(WebInspector.DataGridNode.prototype.createGoToArrowButton):
Adds a go-to arrow button to the cell's content element. Clicking the button
dispatches an event on the DataGrid, with event data containing the
DataGridNode and identifier of the cell containing the arrow button.

10:15 AM Changeset in webkit [195965] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION(r195770): Use-after-free in ResourceLoaderOptions::cachingPolicy
https://bugs.webkit.org/show_bug.cgi?id=153727
<rdar://problem/24429886>

Reviewed by Chris Dumez.

The this object may be freed after calling deleteIfPossible(). Make the early-return-if-
deleted more explicit, and only check allowsCaching() after the deleteIfPossible() return
value check.

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::removeClient):

9:56 AM Changeset in webkit [195964] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

Stop linking to PassKit
https://bugs.webkit.org/show_bug.cgi?id=153746

Reviewed by Tim Horton.

  • Configurations/WebKit.xcconfig:
9:53 AM Changeset in webkit [195963] by mitz@apple.com
  • 7 edits in trunk/Source/WebKit2

[Cocoa] Get rid of WK_ macros for initializers
https://bugs.webkit.org/show_bug.cgi?id=153744

Reviewed by Anders Carlsson.

  • Shared/API/Cocoa/WKFoundation.h: Removed definitions of WK_DESIGNATED_INITIALIZER and WK_UNAVAILABLE.
  • mac/postprocess-framework-headers.sh: Removed rules for rewriting the above macros. Also removed Foundation import that became unnecessary, and definitions that were only needed before iOS 8.

Replaced instances of the above macros with their expansions.

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/API/Cocoa/WKSecurityOrigin.h:
  • UIProcess/API/Cocoa/WKWebView.h:
  • UIProcess/API/Cocoa/WKWebsiteDataStore.h:
9:02 AM Changeset in webkit [195962] by jmarcell@apple.com
  • 4 edits in trunk/Tools

Improvements to botwatcher's dashboard unit tests.
https://bugs.webkit.org/show_bug.cgi?id=153621

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/PopoverTracker.js:

(PopoverTracker): Retain a reference to the PopoverTracker so that we can make assertions about it in the unit tests.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/MockTrac.js:

(MockTrac): Changing revision 33019 to be on a different branch so that _appendPendingRevisionCount and
_popoverLinesForCommitRange have to traverse commits from different branches.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/tests.js: Changing equal to strictEqual

in unit test for _appendPendingRevisionCount. Also added assertions for Popover in test for
_revisionContentWithPopoverForIteration.

9:01 AM Changeset in webkit [195961] by jmarcell@apple.com
  • 3 edits in trunk/Tools

Refactor to add event listeners and start periodic updates for all trac instances.
https://bugs.webkit.org/show_bug.cgi?id=153609

Reviewed by Darin Adler.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotQueueView.js:

(BuildbotQueueView): Adding event listeners for all trac instances.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js: Starting periodic updates

for all trac instances.

8:00 AM Changeset in webkit [195960] by mitz@apple.com
  • 2 edits in trunk/Source/WebCore

Tried to fix a build after r195899.

  • dom/EventContext.h: Enabled TouchEventContext type trait specialization on iOS.
4:33 AM Changeset in webkit [195959] by youenn.fablet@crf.canon.fr
  • 6 edits in trunk/LayoutTests

Unreviewed. Updating global-constructors-attributes expectations after introducing Request in r195954.

4:31 AM Changeset in webkit [195958] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

One more unreviewed speculative buildfix after r195755.

  • PlatformMac.cmake:
4:19 AM Changeset in webkit [195957] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Unreviewed speculative buildfix after r195755.

  • PlatformMac.cmake:
3:26 AM Changeset in webkit [195956] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed speculative buildfix.

  • dfg/DFGCommon.h: FTL_USES_B3 should be false if FTL JIT is disabled.
3:20 AM Changeset in webkit [195955] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebKit2

Unreviewed speculative buildfix after r195795.

  • PlatformMac.cmake: Remove Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm.
3:05 AM Changeset in webkit [195954] by youenn.fablet@crf.canon.fr
  • 23 edits
    2 copies
    36 adds in trunk

[Fetch API] Implement Fetch API Request
https://bugs.webkit.org/show_bug.cgi?id=153437

LayoutTests/imported/w3c:

Reviewed by Darin Adler.

  • web-platform-tests/fetch/api/headers/headers-basic.html:
  • web-platform-tests/fetch/api/request/request-clone.sub-expected.txt: Added.
  • web-platform-tests/fetch/api/request/request-clone.sub.html: Added.
  • web-platform-tests/fetch/api/request/request-consume-expected.txt: Added.
  • web-platform-tests/fetch/api/request/request-consume.html: Added.
  • web-platform-tests/fetch/api/request/request-disturbed-expected.txt: Added.
  • web-platform-tests/fetch/api/request/request-disturbed.html: Added.
  • web-platform-tests/fetch/api/request/request-error-expected.txt: Added.
  • web-platform-tests/fetch/api/request/request-error.html: Added.
  • web-platform-tests/fetch/api/request/request-headers-expected.txt: Added.
  • web-platform-tests/fetch/api/request/request-headers.html: Added.
  • web-platform-tests/fetch/api/request/request-idl-expected.txt: Added.
  • web-platform-tests/fetch/api/request/request-idl.html: Added.
  • web-platform-tests/fetch/api/request/request-init-001.sub-expected.txt: Added.
  • web-platform-tests/fetch/api/request/request-init-001.sub.html: Added.
  • web-platform-tests/fetch/api/request/request-init-002-expected.txt: Added.
  • web-platform-tests/fetch/api/request/request-init-002.html: Added.
  • web-platform-tests/fetch/api/request/request-init-003.sub-expected.txt: Added.
  • web-platform-tests/fetch/api/request/request-init-003.sub.html: Added.
  • web-platform-tests/fetch/api/request/request-structure-expected.txt: Added.
  • web-platform-tests/fetch/api/request/request-structure.html: Added.
  • web-platform-tests/fetch/api/resources/authentication.py: Added.

(main):

  • web-platform-tests/fetch/api/resources/clean-stash.py: Added.

(main):

  • web-platform-tests/fetch/api/resources/inspect-headers.py: Added.

(main):

  • web-platform-tests/fetch/api/resources/method.py: Added.

(main):

  • web-platform-tests/fetch/api/resources/preflight.py: Added.

(main):

  • web-platform-tests/fetch/api/resources/redirect.py: Added.

(main):

  • web-platform-tests/fetch/api/resources/top.txt: Added.
  • web-platform-tests/fetch/api/resources/trickle.py: Added.

(main):

  • web-platform-tests/fetch/api/resources/utils.js: Added.

(catch):
(dirname):
(checkRequest):
(readTextStream):

Source/WebCore:

Added support for Fetch Request and Body.
Body is sharing functionality between Request and Response.
Conversion between various body types are not implemented yet.

Added a FetchOptions class. Options in this class are partially redundant with ResourceLoaderOptions.

Fixing bug in Headers constructor.
Making error reporting in case of modifying headers compliant with the spec.

Reviewed by Darin Adler.

Tests: imported/w3c/web-platform-tests/fetch/api/request/request-clone.sub.html

imported/w3c/web-platform-tests/fetch/api/request/request-consume.html
imported/w3c/web-platform-tests/fetch/api/request/request-disturbed.html
imported/w3c/web-platform-tests/fetch/api/request/request-error.html
imported/w3c/web-platform-tests/fetch/api/request/request-headers.html
imported/w3c/web-platform-tests/fetch/api/request/request-idl.html
imported/w3c/web-platform-tests/fetch/api/request/request-init-001.sub.html
imported/w3c/web-platform-tests/fetch/api/request/request-init-002.html
imported/w3c/web-platform-tests/fetch/api/request/request-init-003.sub.html
imported/w3c/web-platform-tests/fetch/api/request/request-structure.html

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • Modules/fetch/FetchBody.cpp: Added.

(WebCore::FetchBody::initBody):
(WebCore::FetchBody::clear):
(WebCore::FetchBody::processIfEmptyOrDisturbed):
(WebCore::FetchBody::arrayBuffer):
(WebCore::FetchBody::formData):
(WebCore::FetchBody::blob):
(WebCore::FetchBody::text):
(WebCore::FetchBody::json):

  • Modules/fetch/FetchBody.h: Added.

(WebCore::FetchBody::~FetchBody):
(WebCore::FetchBody::isEmpty):
(WebCore::FetchBody::isDisturbed):
(WebCore::FetchBody::setDisturbed):
(WebCore::FetchBody::setMimeType):
(WebCore::FetchBody::mimeType):

  • Modules/fetch/FetchBody.idl: Added.
  • Modules/fetch/FetchHeaders.cpp:

(WebCore::canWriteHeader):
(WebCore::FetchHeaders::append):
(WebCore::FetchHeaders::remove):
(WebCore::FetchHeaders::set):
(WebCore::FetchHeaders::fill): Helper routine implementing https://fetch.spec.whatwg.org/#concept-headers-fill

  • Modules/fetch/FetchHeaders.h: Adding header getter/setter for FetchRequest.

(WebCore::FetchHeaders::fastGet):
(WebCore::FetchHeaders::fastSet):

  • Modules/fetch/FetchHeaders.js: Fixing bug in constructor (covered by modified headers-basc.html test).

(initializeFetchHeaders):

  • Modules/fetch/FetchOptions.h: Added.

(WebCore::FetchOptions::FetchOptions):
(WebCore::FetchOptions::type):
(WebCore::FetchOptions::destination):
(WebCore::FetchOptions::mode):
(WebCore::FetchOptions::credentials):
(WebCore::FetchOptions::cache):
(WebCore::FetchOptions::redirect):
(WebCore::FetchOptions::referrerPolicy):
(WebCore::FetchOptions::setType):
(WebCore::FetchOptions::setDestination):
(WebCore::FetchOptions::setMode):
(WebCore::FetchOptions::setCredentials):
(WebCore::FetchOptions::setCache):
(WebCore::FetchOptions::setRedirect):
(WebCore::FetchOptions::setReferrerPolicy):

  • Modules/fetch/FetchRequest.cpp: Added.

(WebCore::FetchRequest::create):
(WebCore::FetchRequest::FetchRequest):
(WebCore::FetchRequest::init):
(WebCore::FetchRequest::setReferrer):
(WebCore::FetchRequest::setReferrerPolicy):
(WebCore::FetchRequest::setMode):
(WebCore::FetchRequest::setCredentials):
(WebCore::FetchRequest::setCache):
(WebCore::FetchRequest::setRedirect):
(WebCore::FetchRequest::type):
(WebCore::FetchRequest::destination):
(WebCore::FetchRequest::referrerPolicy):
(WebCore::FetchRequest::referrer):
(WebCore::FetchRequest::mode):
(WebCore::FetchRequest::credentials):
(WebCore::FetchRequest::cache):
(WebCore::FetchRequest::redirect):
(WebCore::FetchRequest::setMethod):
(WebCore::FetchRequest::clone):

  • Modules/fetch/FetchRequest.h: Added.

(WebCore::FetchRequest::method):
(WebCore::FetchRequest::url):
(WebCore::FetchRequest::integrity):
(WebCore::FetchRequest::headers):

  • Modules/fetch/FetchRequest.idl: Added.
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/Dictionary.h:

(WebCore::Dictionary::execState):

  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue):

  • bindings/js/JSDictionary.h:

(WebCore::JSDictionary::get):

LayoutTests:

Reviewed by Darin Adler.

  • js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
  • js/dom/global-constructors-attributes-expected.txt:
  • platform/efl/js/dom/global-constructors-attributes-dedicated-worker-expected.txt:
  • platform/efl/js/dom/global-constructors-attributes-expected.txt:
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-mavericks/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/win/js/dom/global-constructors-attributes-expected.txt:

Jan 31, 2016:

10:34 PM Changeset in webkit [195953] by commit-queue@webkit.org
  • 17 edits
    4 adds in trunk

Add resize event for HTMLMediaElement
https://bugs.webkit.org/show_bug.cgi?id=125715

Patch by Jeremy Jones <jeremyj@apple.com> on 2016-01-31
Reviewed by Darin Adler.
LayoutTests/imported/w3c:

Rebaselined test after moving 'resize' from DOMWindow.idl to GlobalEventHandlers.idl
per https://html.spec.whatwg.org/multipage/webappapis.html#globaleventhandlers

  • web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Tests: http/tests/media/hls/hls-video-resize.html

media/video-resize.html

Move resize javascript event from DOMWindow.idl to GlobalEventHandlers.idl
per https://html.spec.whatwg.org/multipage/webappapis.html#globaleventhandlers

Post resize event from video element when metadata loads and when content size changes.

  • dom/GlobalEventHandlers.idl: Add onresize.
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::createEventHandlerNameMap): Add onresizeAttr.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::mediaPlayerSizeChanged):

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::scheduleResizeEvent):
(WebCore::HTMLMediaElement::scheduleResizeEventIfSizeChanged):

  • html/HTMLVideoElement.cpp:

(WebCore::HTMLVideoElement::scheduleResizeEvent): Sechedule event.
(WebCore::HTMLVideoElement::scheduleResizeEventIfSizeChanged): Schedule event if size has changed.

  • html/HTMLVideoElement.h: Add declarations.
  • page/DOMWindow.idl: Remove onresize.

Source/WebInspectorUI:

Add a display name for "resize" event.

  • UserInterface/Models/ScriptTimelineRecord.js:

(WebInspector.ScriptTimelineRecord.EventType.displayName):

LayoutTests:

Update test for change: move resize javascript event from DOMWindow.idl to GlobalEventHandlers.idl
per https://html.spec.whatwg.org/multipage/webappapis.html#globaleventhandlers

  • fast/dom/event-handler-attributes-expected.txt: Rebaselined.
  • fast/dom/event-handler-attributes.html:

Move resize from uniqueWindowEvents to eventsInGlobalEventHandlers.

  • http/tests/media/hls/hls-video-resize-expected.txt: Added.
  • http/tests/media/hls/hls-video-resize.html: Added.
  • js/dom/dom-static-property-for-in-iteration-expected.txt: Rebaselined.
  • media/video-resize-expected.txt: Added.
  • media/video-resize.html: Added.
  • media/video-test.js:

(requiredEvents): Deleted global. Value is now captured by closure.
(waitForEventsAndCall): Remove dependence on global variable, and fix event observation leak.

9:51 PM Changeset in webkit [195952] by Darin Adler
  • 2 edits in trunk/Source/WebCore

Revert accidental behavior change from previous patch.

  • platform/URL.cpp:

(WebCore::mimeTypeFromDataURL): Restore behavior where an empty MIME type would
be turned into "text/plain".

9:46 PM Changeset in webkit [195951] by Darin Adler
  • 53 edits in trunk/Source

Cut down on calls to String::lower; mostly replace with convertToASCIILowercase
https://bugs.webkit.org/show_bug.cgi?id=153732

Reviewed by Dean Jackson.

Source/WebCore:

  • Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::isTypeSupported): Added comment about mysterious call
to lower(); should probably return here and remove it.

  • Modules/navigatorcontentutils/NavigatorContentUtils.cpp:

(WebCore::initProtocolHandlerWhitelist): Deleted. Moved into isProtocolWhitelisted.
(WebCore::isProtocolWhitelisted): Changed set to be ASCIICaseInsensitiveHash and
initialized it using a lambda instead of a separate function.
(WebCore::verifyProtocolHandlerScheme): Added a FIXME about some case sensitive
checking of the protocol prefix here.

  • Modules/plugins/QuickTimePluginReplacement.mm:

(WebCore::QuickTimePluginReplacement::supportsMimeType): Changed set to be
ASCIICaseInsensitiveHash and initialized it using a lambda instead of using
an explict check for empty.
(WebCore::QuickTimePluginReplacement::supportsFileExtension): Ditto.

  • Modules/plugins/YouTubePluginReplacement.cpp:

(WebCore::queryKeysAndValues): Use convertToASCIILowercase. The keys here are
going to be all ASCII.
(WebCore::isYouTubeURL): Use equalLettersIgnoringASCIICase instead of lowercasing
the string.
(WebCore::processAndCreateYouTubeURL): Use url.protocolIsInHTTPFamily instead of
listing "http" and then "https" explicitly. Use equalLettersIgnoringASCIICase
instead of lowercasing a string.
(WebCore::YouTubePluginReplacement::youTubeURL): Ditto.

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::hostName): Use convertToASCIILowercase on host name.
(WebCore::WebSocketHandshake::host): Ditto.

  • accessibility/atk/WebKitAccessibleWrapperAtk.cpp:

(webkitAccessibleGetAttributes): Call convertToASCIILowercase instead of lower
to lowercase an element's tag name. This is a strange way to do things; typically
would be better to use some other function on Element, since tagName goes out of
its way to be capitalized, but some ATK expert can improve this later.

  • css/CSSGrammar.y.in: Use the new convertToASCIILowercaseInPlace function rather

than the old lower function. We only need to lowercase the ASCII letters, and it's
also better to have the function have a clearer name.

  • css/CSSParser.cpp:

(WebCore::convertToASCIILowercaseInPlace): Renamed from makeLower and made it deal
with only ASCII lowercasing.
(WebCore::CSSParserString::convertToASCIILowercaseInPlace): Renamed from lower.
(WebCore::isUniversalKeyword): Added. Helper for the function below that uses
equalLettersIgnoringASCIICase rather than lowercasing the string.
(WebCore::parseKeywordValue): Use isUniversalKeyword. Also clarified a comment.
(WebCore::CSSParser::parseAttr): Use convertToASCIILowercaseInPlace and delay
String creation until later in the function, using CSSParserString operations more.

  • css/CSSParserValues.cpp:

(WebCore::CSSParserSelector::parsePseudoElementSelector): Use
convertToASCIILowercaseInPlace by its new name, with its new behavior.

  • css/CSSParserValues.h: Tweaked comment and formatting a bit. Replaced the lower

function with the convertToASCIILowercaseInPlace function.

  • css/CSSSelector.cpp:

(WebCore::CSSSelector::RareData::parseNth): Rewrote this to avoid the need to
make a lowercased copy of m_argument. Use equalLettersIgnoringASCIICase, and two
calls to find. Also use String::toIntStrict so we don't have to create String
objects for substrings.

  • css/MediaQuery.cpp:

(WebCore::MediaQuery::MediaQuery): Use convertToASCIILowercase for media type name.

  • css/MediaQueryExp.cpp:

(WebCore::MediaQueryExp::serialize): Use convertToASCIILowercase for media feature name.

  • dom/Document.cpp:

(WebCore::isSeparator): Tweaked formatting and removed non-helpful comment.
(WebCore::processArguments): Changed this from a static member function to a non-member
file internal function. Use a std::function instead of a function pointer with a void*
pointer. Rewrote algorithm to simplify it and use StringView instead of String for the
keys and values.
(WebCore::Document::processViewport): Use a lambda instead of a function pointer to
call setViewportFeature, so that function's interface is no longer dictated by
the exact type of the function pointer argument to processArguments.
(WebCore::Document::processFormatDetection): Use a lambda instead of the
setParserFeature function above; use equalLettersIgnoringASCIICase for both the
key and the value, since processArguments no longer lowercases the string.
(WebCore::Document::processArguments): Deleted.

  • dom/Document.h: Removed unnecessary declaration of processArguments and

ArgumentsCallback. Both are now private to the cpp file.

  • dom/Element.cpp:

(WebCore::makeIdForStyleResolution): Use convertToASCIILowercase. When in quirks mode,
we want to match IDs in an ASCII case-insensitive way not match compatibility caseless.

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::isScriptTypeSupported): Remove the use of lower here since
the MIME type registry is now itself ASCII case-insensitive.

  • dom/ViewportArguments.cpp:

(WebCore::numericPrefix): Changed to use StringView and take a Document&, rearranged
argument order so Document& comes first.
(WebCore::findSizeValue): Ditto.
(WebCore::findScaleValue): Ditto.
(WebCore::findBooleanValue): Ditto. Also use std::abs instead of fabs, possibly
avoiding a conversion from float to double (not sure it was happening before but it's
definitely not happening now).
(WebCore::setViewportFeature): Changed to put arguments in a more logical order, to take
the ViewportArguments as a reference, not a void*, and to use StringView to avoid forcing
the caller to allocate strings. Also changed to use equalLettersIgnoringASCIICase so we
don't rely on the caller to make the key lowercase for us.
(WebCore::reportViewportWarning): Changed argument types. Added a couple comments about
mistakes in the function.

  • dom/ViewportArguments.h: Removed unnecessary declaration of reportViewportWarning,

which is now private to the cpp file. Updated for new arguments to setViewportFeature.

  • editing/EditorCommand.cpp:

(WebCore::executeFormatBlock): Use convertToASCIILowercase on the argument, which is
specifying a tag name.

  • fileapi/Blob.cpp:

(WebCore::Blob::isValidContentType): Removed unnecessary separate loops for
8-bit and 16-bit strings. Content types are short strings and this small optimization is
not worth the additional code complexity.
(WebCore::Blob::normalizedContentType): Use convertToASCIILowercase since valid
content types are guaranteed to be all ASCII.
(WebCore::Blob::isNormalizedContentType): Removed unnecessary separate loops for
8-bit and 16-bit strings. Content types are short strings and this small optimization is
not worth the additional code complexity.

  • html/parser/HTMLParserIdioms.cpp: Added now-needed include of QualifiedName.h.
  • html/parser/HTMLParserIdioms.h: Removed unneeded include of QualifiedName.h and

WTFString.h. Made sure every function is declared first, even if it's also defined
later in the header in the section for functions templates and inline functions.

  • loader/archive/ArchiveFactory.cpp:

(WebCore::ArchiveFactory::registerKnownArchiveMIMETypes): Use auto& for the type of
the set of MIME types here, since it's now using ASCIICaseInsensitiveHash.

  • platform/MIMETypeRegistry.cpp: Changed the MIME type sets to use

ASCIICaseInsensitiveHash since MIME type are not case sensitive.
(WebCore::initializeSupportedImageMIMETypes): Use a modern for loop.
(WebCore::initializeSupportedImageMIMETypesForEncoding): Updated for HashSet type change.
(WebCore::initializePDFMIMETypes): Use a modern for loop.
(WebCore::initializeSupportedNonImageMimeTypes): Use a modern for loop.
(WebCore::initializeSupportedMediaMIMETypes): Updated for HashSet type change.
(WebCore::initializeUnsupportedTextMIMETypes): Use a modern for loop.
(WebCore::initializeMIMETypeRegistry): Updated for HashSet type change.
(WebCore::MIMETypeRegistry::getSupportedImageMIMETypes): Ditto.
(WebCore::MIMETypeRegistry::getSupportedImageResourceMIMETypes): Ditto.
(WebCore::MIMETypeRegistry::getSupportedImageMIMETypesForEncoding): Ditto.
(WebCore::MIMETypeRegistry::getSupportedNonImageMIMETypes): Ditto.
(WebCore::MIMETypeRegistry::getSupportedMediaMIMETypes): Ditto.
(WebCore::MIMETypeRegistry::getPDFMIMETypes): Ditto.
(WebCore::MIMETypeRegistry::getPDFAndPostScriptMIMETypes): Ditto.
(WebCore::MIMETypeRegistry::getUnsupportedTextMIMETypes): Ditto.
(WebCore::mimeTypeAssociationMap): Use ASCIICaseInsensitiveHash.
(WebCore::MIMETypeRegistry::getNormalizedMIMEType): Use auto to make code tighter.

  • platform/MIMETypeRegistry.h: Changed return types of the getMIMETypes functions

to use ASCIICaseInsensitiveHash.

  • platform/SchemeRegistry.cpp:

(WebCore::schemesForbiddenFromDomainRelaxation): Changed type to
use ASCIICaseInsensitiveHash.

  • platform/URL.cpp:

(WebCore::mimeTypeFromDataURL): Use convertToASCIILowercase instead of lower.
Also removed some dead code that tried to handle the case where the data URL
has a comma as one of the first 5 characters: That can't happen since it's a
precondition of this function that the first five characters are "data:".

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::getSupportedTypes): Change type of argument to
a HashSet with ASCIICaseInsensitiveHash.

  • platform/graphics/MediaPlayer.h: Ditto.
  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::staticMIMETypeList):
Changed type of HashSet to use ASCIICaseInsensitiveHash.

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h: Ditto.
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::avfMIMETypes):
Changed type of HashSet to use ASCIICaseInsensitiveHash.
(WebCore::MediaPlayerPrivateAVFoundationCF::getSupportedTypes): Ditto.

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.h: Ditto.
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

Changed type of HashSet to use ASCIICaseInsensitiveHash.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithImageGenerator): Removed
an unnecessary line of code to set a local variable to 0 just before it falls
out of scope.
(WebCore::avfMIMETypes): Ditto. Also tightened up the code a bit.
(WebCore::MediaPlayerPrivateAVFoundationObjC::getSupportedTypes): Ditto.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:

Changed type of HashSet to use ASCIICaseInsensitiveHash.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::mimeTypeCache): Ditto.
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::getSupportedTypes): Ditto.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h: Ditto.
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::getSupportedTypes): Ditto.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::mimeTypeCache): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::getSupportedTypes): Ditto.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Ditto.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.h: Ditto.
  • platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::shouldRejectMIMEType): Made this non-case-sensitive by using startsWith
and the "false" argument. Later change this to startsWithIgnoringASCIICase or
startsWithLettersIgnoringASCIICase.
(WebCore::addFileTypesToCache): Use ASCIICaseInsensitiveHash. ALso rewrote to
tighten up the code a bit and use modern Objective-C for loops.
(WebCore::mimeCommonTypesCache): Use ASCIICaseInsensitiveHash.
(WebCore::mimeModernTypesCache): Ditto.
(WebCore::concatenateHashSets): Ditto.
(WebCore::MediaPlayerPrivateQTKit::getSupportedTypes): Ditto.
(WebCore::MediaPlayerPrivateQTKit::disableUnsupportedTracks): Initialied
track type set using lambda, but left it case sensitive.

  • platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:

(WebCore::mimeTypeCache): Changed type of HashSet to use ASCIICaseInsensitiveHash.
(WebCore::MediaPlayerPrivateMediaFoundation::getSupportedTypes): Ditto.

  • platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
  • platform/mock/mediasource/MockMediaPlayerMediaSource.cpp:

(WebCore::mimeTypeCache): Ditto.
(WebCore::MockMediaPlayerMediaSource::getSupportedTypes): Ditto.

  • platform/mock/mediasource/MockMediaPlayerMediaSource.h: Ditto.

Source/WebKit/mac:

  • WebView/WebHTMLRepresentation.mm:

(newArrayWithStrings): Updated to use HashSet<String, ASCIICaseInsensitiveHash>
and also to use a modern for loop.

Source/WTF:

  • wtf/text/StringView.h: Added toIntStrict. Not thrilled about the name of this

function, but generally it seems likely to be useful more often than toInt.
And it's needed for one call site in WebCore that was using String::lower.

8:44 PM Changeset in webkit [195950] by Brent Fulgham
  • 3 edits
    4 adds in trunk

Add "WebKit built-in PDF" Plugin to set of publicly visible plugins
https://bugs.webkit.org/show_bug.cgi?id=153657
<rdar://problem/24413107>

Reviewed by Darin Adler.

Source/WebCore:

Tested by http/tests/plugins/visible_plugins.html.

A number of poorly-coded sites break when WebKit reports that it understands PDF mime types,
but does not have a list of plugins that the site can iterate through.

To avoid this compatibility problem, we should also expose the "WebKit built-in PDF" plugin
to avoid this edge case.

  • plugins/PluginData.cpp:

(WebCore::shouldBePubliclyVisible): Add "WebKit built-in PDF" plugin.

LayoutTests:

  • http/tests/plugins/visible_plugins-expected.txt: Added.
  • http/tests/plugins/visible_plugins.html: Added.
  • platform/mac-wk2/http/tests/plugins: Added.
  • platform/mac-wk2/http/tests/plugins/visible_plugins-expected.txt: Added.
8:09 PM Changeset in webkit [195949] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

AX: Add a boundary value to AXTextStateChangeType
https://bugs.webkit.org/show_bug.cgi?id=153085

Patch by Doug Russell <d_russell@apple.com> on 2016-01-31
Reviewed by Darin Adler.

Post an AT notification when navigation is attempted past
an editable element's boundaries.

Source/WebCore:

Test: accessibility/mac/selection-boundary-userinfo.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::showIntent):

  • accessibility/AXTextStateChangeIntent.h:
  • accessibility/mac/AXObjectCacheMac.mm:

(platformChangeTypeForWebCoreChangeType):
(WebCore::AXObjectCache::postTextStateChangePlatformNotification):

  • editing/FrameSelection.cpp:

(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingForward):
(WebCore::FrameSelection::modifyMovingLeft):
(WebCore::FrameSelection::modifyMovingBackward):
(WebCore::textSelectionWithDirectionAndGranularity):
(WebCore::FrameSelection::modify):
(WebCore::FrameSelection::modifyExtendingBackward): Deleted.
(WebCore::FrameSelection::textSelectionIntent): Deleted.

  • editing/FrameSelection.h:
  • editing/VisiblePosition.cpp:

(WebCore::VisiblePosition::next):
(WebCore::VisiblePosition::previous):
(WebCore::VisiblePosition::left):
(WebCore::VisiblePosition::right):
(WebCore::VisiblePosition::honorEditingBoundaryAtOrBefore):
(WebCore::VisiblePosition::honorEditingBoundaryAtOrAfter):
(WebCore::VisiblePosition::leftVisuallyDistinctCandidate): Deleted.
(WebCore::VisiblePosition::rightVisuallyDistinctCandidate): Deleted.

  • editing/VisiblePosition.h:
  • editing/VisibleUnits.cpp:

(WebCore::startOfLine):
(WebCore::logicalStartOfLine):
(WebCore::endOfLine):
(WebCore::logicalEndOfLine):
(WebCore::leftBoundaryOfLine):
(WebCore::rightBoundaryOfLine):
(WebCore::inSameLogicalLine): Deleted.
(WebCore::endOfEditableContent): Deleted.
(WebCore::isEndOfEditableOrNonEditableContent): Deleted.

  • editing/VisibleUnits.h:

LayoutTests:

  • accessibility/mac/selection-boundary-userinfo-expected.txt: Added.
  • accessibility/mac/selection-boundary-userinfo.html: Added.
7:10 PM Changeset in webkit [195948] by dbates@webkit.org
  • 26 edits
    10 adds in trunk

CSP: Use the served CSP header for dedicated workers
https://bugs.webkit.org/show_bug.cgi?id=153157
<rdar://problem/24383254>
And
https://bugs.webkit.org/show_bug.cgi?id=153156
<rdar://problem/24383246>

Patch by Daniel Bates <dabates@apple.com> on 2016-01-31
Reviewed by Brent Fulgham.

Source/WebCore:

Inspired by Blink commit:
<https://src.chromium.org/viewvc/blink?revision=194143&view=revision>

Implement support for respecting Content Security Policy (CSP) HTTP headers included in the
HTTP response for a Web Worker's script as per section Workers of the CSP 2.0 spec,
<https://w3c.github.io/webappsec-csp/2/#processing-model-workers> (29 August 2015).

Currently a Web Worker always inherits the CSP of its owner document. Instead a web worker
will inherit the CSP of its owner document only if its script is incapable of defining a
content security policy (i.e. its origin is a globally unique identifier). Otherwise, the
CSP HTTP headers delivered with the script will be used to define the CSP for the worker.

Tests: fast/workers/worker-inherits-csp-blocks-eval.html

fast/workers/worker-inherits-csp-blocks-xhr.html
http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-blocks-eval.html

  • CMakeLists.txt: Add file ContentSecurityPolicyResponseHeaders.cpp.
  • WebCore.vcxproj/WebCore.vcxproj: Add files ContentSecurityPolicyResponseHeaders.{cpp, h}.
  • WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • dom/Document.cpp:

(WebCore::Document::processHttpEquiv): Update code to use enum class ContentSecurityPolicyHeaderType.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument): Extract logic to collect Content Security Policy HTTP headers
into class ContentSecurityPolicyResponseHeaders and make use of it here.

  • page/csp/ContentSecurityPolicy.cpp:

(WebCore::CSPDirectiveList::headerType): Modified to use enum class ContentSecurityPolicyHeaderType.
(WebCore::CSPDirectiveList::CSPDirectiveList): Ditto.
(WebCore::CSPDirectiveList::create): Ditto.
(WebCore::ContentSecurityPolicy::responseHeaders): Creates and returns a ContentSecurityPolicyResponseHeaders
object with the parsed CSP policy headers.
(WebCore::ContentSecurityPolicy::didReceiveHeaders): Processed the CSP policy headers represented by the
specified ContentSecurityPolicyResponseHeaders object.
(WebCore::ContentSecurityPolicy::deprecatedHeader): Deleted.
(WebCore::ContentSecurityPolicy::deprecatedHeaderType): Deleted.

  • page/csp/ContentSecurityPolicy.h: Defines a class that represents a collection of CSP policy headers.

This class has two purposes:

  • It extracts the CSP policy headers from a HTTP response (ResourceResponse object). We make use of this functionality in both FrameLoader::didBeginDocument() and Worker::didReceiveResponse().
  • It serves as a memento that externalizes the internal CSP policy details of an instance of ContentSecurityPolicy. We make use of this memento functionality to support inheriting the CSP policy of the worker's owner document in a thread-safe manner. You can create and restore a memento using ContentSecurityPolicy::responseHeaders() and ContentSecurityPolicy::didReceiveHeaders(), respectively.
  • page/csp/ContentSecurityPolicyResponseHeaders.cpp: Added.

(WebCore::ContentSecurityPolicyResponseHeaders::ContentSecurityPolicyResponseHeaders): Extracts the
CSP HTTP headers from a ResourceResponse object.
(WebCore::ContentSecurityPolicyResponseHeaders::isolatedCopy): Make a copy of this object that is
safe to pass to another thread.

  • page/csp/ContentSecurityPolicyResponseHeaders.h: Added.
  • workers/DedicatedWorkerGlobalScope.cpp:

(WebCore::DedicatedWorkerGlobalScope::create): Modified to use class ContentSecurityPolicyResponseHeaders.

  • workers/DedicatedWorkerGlobalScope.h:
  • workers/DedicatedWorkerThread.cpp:

(WebCore::DedicatedWorkerThread::create): Ditto.
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread): Ditto.
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope): Ditto.

  • workers/DedicatedWorkerThread.h:
  • workers/Worker.cpp:

(WebCore::Worker::didReceiveResponse): Create a ContentSecurityPolicyResponseHeaders if the origin of
the worker's script is capable of providing a CSP. Otherwise, we will inherit the CSP of the worker's owner
document in Worker::notifyFinished().
(WebCore::Worker::notifyFinished): Pass the appropriate CSP response headers to WorkerMessagingProxy::startWorkerGlobalScope().

  • workers/Worker.h:
  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::applyContentSecurityPolicyResponseHeaders): Renamed; formerly named applyContentSecurityPolicyFromString().
Modified to take a ContentSecurityPolicyResponseHeaders and apply it to the ContentSecurityPolicy object associated with the worker.
(WebCore::WorkerGlobalScope::applyContentSecurityPolicyFromString): Deleted.

  • workers/WorkerGlobalScope.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerGlobalScope): Pass the worker's ContentSecurityPolicyResponseHeaders object.

  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadStartupData::WorkerThreadStartupData): Added field m_contentSecurityPolicyResponseHeaders to store
the CSP response headers to be applied to the worker's ContentSecurityPolicy object.
(WebCore::WorkerThread::WorkerThread): Modified to use ContentSecurityPolicyResponseHeaders.
(WebCore::WorkerThread::workerThread): Pass the ContentSecurityPolicyResponseHeaders object from the start up data struct
to DedicatedWorkerThread::createWorkerGlobalScope().

  • workers/WorkerThread.h:

LayoutTests:

Add new tests to ensure we block eval() in blob-, file-URL workers and block XHR in a file-URL worker.

  • TestExpectations: Remove now passing tests http/tests/security/contentSecurityPolicy/worker-{multiple-csp-headers, without-own-csp}.html

and update the associated bug # for tests that fail.

  • fast/workers/resources/worker-inherits-csp-blocks-eval.js: Added.

(catch):

  • fast/workers/resources/worker-inherits-csp-blocks-xhr.js: Added.

(catch):

  • fast/workers/worker-inherits-csp-blocks-eval-expected.txt: Added.
  • fast/workers/worker-inherits-csp-blocks-eval.html: Added.
  • fast/workers/worker-inherits-csp-blocks-xhr-expected.txt: Added.
  • fast/workers/worker-inherits-csp-blocks-xhr.html: Added.
  • http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-blocks-eval-expected.txt: Added.
  • http/tests/security/contentSecurityPolicy/worker-blob-inherits-csp-blocks-eval.html: Added.
  • http/tests/security/contentSecurityPolicy/worker-multiple-csp-headers-expected.txt: Updated expected results as

the result was incorrect.

  • http/tests/security/contentSecurityPolicy/worker-without-own-csp-expected.txt: Ditto.
6:22 PM Changeset in webkit [195947] by Hunseop Jeong
  • 322 edits in trunk/LayoutTests

Unreviewed. EFL gardening: rebaseline tests after r195740. (more to follow)

  • platform/efl/css1/basic/containment-expected.txt:
  • platform/efl/css1/basic/contextual_selectors-expected.txt:
  • platform/efl/css1/basic/grouping-expected.txt:
  • platform/efl/css1/basic/id_as_selector-expected.txt:
  • platform/efl/css1/basic/inheritance-expected.txt:
  • platform/efl/css1/box_properties/border-expected.txt:
  • platform/efl/css1/box_properties/border_bottom-expected.txt:
  • platform/efl/css1/box_properties/border_bottom_inline-expected.txt:
  • platform/efl/css1/box_properties/border_bottom_width-expected.txt:
  • platform/efl/css1/box_properties/border_bottom_width_inline-expected.txt:
  • platform/efl/css1/box_properties/border_color-expected.txt:
  • platform/efl/css1/box_properties/border_color_inline-expected.txt:
  • platform/efl/css1/box_properties/border_inline-expected.txt:
  • platform/efl/css1/box_properties/border_left-expected.txt:
  • platform/efl/css1/box_properties/border_left_inline-expected.txt:
  • platform/efl/css1/box_properties/border_left_width-expected.txt:
  • platform/efl/css1/box_properties/border_left_width_inline-expected.txt:
  • platform/efl/css1/box_properties/border_right-expected.txt:
  • platform/efl/css1/box_properties/border_right_inline-expected.txt:
  • platform/efl/css1/box_properties/border_right_width-expected.txt:
  • platform/efl/css1/box_properties/border_right_width_inline-expected.txt:
  • platform/efl/css1/box_properties/border_style-expected.txt:
  • platform/efl/css1/box_properties/border_style_inline-expected.txt:
  • platform/efl/css1/box_properties/border_top-expected.txt:
  • platform/efl/css1/box_properties/border_top_inline-expected.txt:
  • platform/efl/css1/box_properties/border_top_width-expected.txt:
  • platform/efl/css1/box_properties/border_top_width_inline-expected.txt:
  • platform/efl/css1/box_properties/clear-expected.txt:
  • platform/efl/css1/box_properties/clear_float-expected.txt:
  • platform/efl/css1/box_properties/float-expected.txt:
  • platform/efl/css1/box_properties/float_elements_in_series-expected.txt:
  • platform/efl/css1/box_properties/float_margin-expected.txt:
  • platform/efl/css1/box_properties/height-expected.txt:
  • platform/efl/css1/box_properties/margin-expected.txt:
  • platform/efl/css1/box_properties/margin_bottom-expected.txt:
  • platform/efl/css1/box_properties/margin_bottom_inline-expected.txt:
  • platform/efl/css1/box_properties/margin_inline-expected.txt:
  • platform/efl/css1/box_properties/margin_left-expected.txt:
  • platform/efl/css1/box_properties/margin_left_inline-expected.txt:
  • platform/efl/css1/box_properties/margin_right-expected.txt:
  • platform/efl/css1/box_properties/margin_right_inline-expected.txt:
  • platform/efl/css1/box_properties/margin_top-expected.txt:
  • platform/efl/css1/box_properties/margin_top_inline-expected.txt:
  • platform/efl/css1/box_properties/padding-expected.txt:
  • platform/efl/css1/box_properties/padding_bottom-expected.txt:
  • platform/efl/css1/box_properties/padding_bottom_inline-expected.txt:
  • platform/efl/css1/box_properties/padding_inline-expected.txt:
  • platform/efl/css1/box_properties/padding_left-expected.txt:
  • platform/efl/css1/box_properties/padding_left_inline-expected.txt:
  • platform/efl/css1/box_properties/padding_right-expected.txt:
  • platform/efl/css1/box_properties/padding_right_inline-expected.txt:
  • platform/efl/css1/box_properties/padding_top-expected.txt:
  • platform/efl/css1/box_properties/padding_top_inline-expected.txt:
  • platform/efl/css1/box_properties/width-expected.txt:
  • platform/efl/css1/cascade/cascade_order-expected.txt:
  • platform/efl/css1/cascade/important-expected.txt:
  • platform/efl/css1/classification/display-expected.txt:
  • platform/efl/css1/classification/list_style-expected.txt:
  • platform/efl/css1/classification/list_style_image-expected.txt:
  • platform/efl/css1/classification/list_style_position-expected.txt:
  • platform/efl/css1/classification/list_style_type-expected.txt:
  • platform/efl/css1/classification/white_space-expected.txt:
  • platform/efl/css1/color_and_background/background-expected.txt:
  • platform/efl/css1/color_and_background/background_attachment-expected.txt:
  • platform/efl/css1/color_and_background/background_color-expected.txt:
  • platform/efl/css1/color_and_background/background_image-expected.txt:
  • platform/efl/css1/color_and_background/background_position-expected.txt:
  • platform/efl/css1/color_and_background/background_repeat-expected.txt:
  • platform/efl/css1/color_and_background/color-expected.txt:
  • platform/efl/css1/conformance/forward_compatible_parsing-expected.txt:
  • platform/efl/css1/font_properties/font-expected.txt:
  • platform/efl/css1/font_properties/font_family-expected.txt:
  • platform/efl/css1/font_properties/font_size-expected.txt:
  • platform/efl/css1/font_properties/font_style-expected.txt:
  • platform/efl/css1/font_properties/font_variant-expected.txt:
  • platform/efl/css1/font_properties/font_weight-expected.txt:
  • platform/efl/css1/formatting_model/canvas-expected.txt:
  • platform/efl/css1/formatting_model/height_of_lines-expected.txt:
  • platform/efl/css1/formatting_model/inline_elements-expected.txt:
  • platform/efl/css1/formatting_model/replaced_elements-expected.txt:
  • platform/efl/css1/formatting_model/vertical_formatting-expected.txt:
  • platform/efl/css1/pseudo/anchor-expected.txt:
  • platform/efl/css1/pseudo/firstletter-expected.txt:
  • platform/efl/css1/pseudo/firstline-expected.txt:
  • platform/efl/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • platform/efl/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
  • platform/efl/css1/text_properties/letter_spacing-expected.txt:
  • platform/efl/css1/text_properties/line_height-expected.txt:
  • platform/efl/css1/text_properties/text_align-expected.txt:
  • platform/efl/css1/text_properties/text_decoration-expected.txt:
  • platform/efl/css1/text_properties/text_indent-expected.txt:
  • platform/efl/css1/text_properties/text_transform-expected.txt:
  • platform/efl/css1/text_properties/vertical_align-expected.txt:
  • platform/efl/css1/text_properties/word_spacing-expected.txt:
  • platform/efl/css1/units/color_units-expected.txt:
  • platform/efl/css1/units/length_units-expected.txt:
  • platform/efl/css1/units/percentage_units-expected.txt:
  • platform/efl/css1/units/urls-expected.txt:
  • platform/efl/css2.1/20110323/border-collapse-offset-002-expected.txt:
  • platform/efl/css2.1/20110323/border-conflict-style-079-expected.txt:
  • platform/efl/css2.1/20110323/border-conflict-style-088-expected.txt:
  • platform/efl/css2.1/20110323/dynamic-top-change-002-expected.txt:
  • platform/efl/css2.1/20110323/dynamic-top-change-003-expected.txt:
  • platform/efl/css2.1/20110323/inline-table-001-expected.txt:
  • platform/efl/css2.1/20110323/inline-table-002a-expected.txt:
  • platform/efl/css2.1/20110323/inline-table-003-expected.txt:
  • platform/efl/css2.1/20110323/margin-applies-to-001-expected.txt:
  • platform/efl/css2.1/20110323/margin-applies-to-002-expected.txt:
  • platform/efl/css2.1/20110323/margin-applies-to-003-expected.txt:
  • platform/efl/css2.1/20110323/margin-applies-to-004-expected.txt:
  • platform/efl/css2.1/20110323/margin-applies-to-005-expected.txt:
  • platform/efl/css2.1/20110323/margin-applies-to-006-expected.txt:
  • platform/efl/css2.1/20110323/margin-applies-to-007-expected.txt:
  • platform/efl/css2.1/20110323/margin-applies-to-013-expected.txt:
  • platform/efl/css2.1/20110323/margin-applies-to-014-expected.txt:
  • platform/efl/css2.1/20110323/margin-applies-to-015-expected.txt:
  • platform/efl/css2.1/20110323/replaced-intrinsic-ratio-001-expected.txt:
  • platform/efl/css2.1/20110323/table-caption-001-expected.txt:
  • platform/efl/css2.1/20110323/table-caption-optional-001-expected.txt:
  • platform/efl/css2.1/20110323/table-caption-optional-002-expected.txt:
  • platform/efl/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
  • platform/efl/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt:
  • platform/efl/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt:
  • platform/efl/css2.1/t0804-c5506-padn-t-00-b-a-expected.txt:
  • platform/efl/css2.1/t0804-c5508-ipadn-b-03-b-a-expected.txt:
  • platform/efl/css2.1/t090402-c42-ibx-pad-00-d-ag-expected.txt:
  • platform/efl/css2.1/t0905-c5525-fltmult-00-d-g-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-04-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-06-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-08-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-13-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-14-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-16-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-17-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-18-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-24-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-25-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-30-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-31-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-34-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-44-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-52-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-54-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-59-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-64-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-65-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-70-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-71-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-74-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-84-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-85-d-expected.txt:
  • platform/efl/css2.1/t170602-bdr-conflct-w-94-d-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-18-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-29-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-29b-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-33-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-73-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-73b-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-77-expected.txt:
  • platform/efl/css3/selectors3/html/css3-modsel-77b-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-18-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-29-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-29b-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-33-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-73-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-73b-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-77-expected.txt:
  • platform/efl/css3/selectors3/xhtml/css3-modsel-77b-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-18-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-29-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-29b-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-33-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-73-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-73b-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-77-expected.txt:
  • platform/efl/css3/selectors3/xml/css3-modsel-77b-expected.txt:
  • platform/efl/editing/deleting/4922367-expected.txt:
  • platform/efl/editing/deleting/5126166-expected.txt:
  • platform/efl/editing/deleting/5206311-1-expected.txt:
  • platform/efl/editing/deleting/5433862-2-expected.txt:
  • platform/efl/editing/inserting/paragraph-separator-in-table-1-expected.txt:
  • platform/efl/editing/selection/3690703-2-expected.txt:
  • platform/efl/editing/selection/3690703-expected.txt:
  • platform/efl/editing/selection/3690719-expected.txt:
  • platform/efl/editing/selection/5057506-2-expected.txt:
  • platform/efl/editing/selection/5057506-expected.txt:
  • platform/efl/editing/selection/5131716-1-expected.txt:
  • platform/efl/editing/selection/5131716-2-expected.txt:
  • platform/efl/editing/selection/5131716-3-expected.txt:
  • platform/efl/editing/selection/5131716-4-expected.txt:
  • platform/efl/editing/selection/move-by-line-001-expected.txt:
  • platform/efl/editing/selection/select-all-004-expected.txt:
  • platform/efl/editing/unsupported-content/table-type-after-expected.txt:
  • platform/efl/editing/unsupported-content/table-type-before-expected.txt:
  • platform/efl/fast/block/basic/016-expected.txt:
  • platform/efl/fast/block/basic/quirk-percent-height-table-cell-expected.txt:
  • platform/efl/fast/block/float/015-expected.txt:
  • platform/efl/fast/block/margin-collapse/006-expected.txt:
  • platform/efl/fast/block/margin-collapse/010-expected.txt:
  • platform/efl/fast/block/margin-collapse/011-expected.txt:
  • platform/efl/fast/block/margin-collapse/012-expected.txt:
  • platform/efl/fast/block/margin-collapse/015-expected.txt:
  • platform/efl/fast/block/margin-collapse/016-expected.txt:
  • platform/efl/fast/block/margin-collapse/017-expected.txt:
  • platform/efl/fast/block/margin-collapse/018-expected.txt:
  • platform/efl/fast/block/margin-collapse/019-expected.txt:
  • platform/efl/fast/block/margin-collapse/020-expected.txt:
  • platform/efl/fast/block/margin-collapse/021-expected.txt:
  • platform/efl/fast/block/margin-collapse/022-expected.txt:
  • platform/efl/fast/block/margin-collapse/025-expected.txt:
  • platform/efl/fast/block/margin-collapse/032-expected.txt:
  • platform/efl/fast/block/margin-collapse/033-expected.txt:
  • platform/efl/fast/block/margin-collapse/034-expected.txt:
  • platform/efl/fast/block/margin-collapse/041-expected.txt:
  • platform/efl/fast/block/margin-collapse/042-expected.txt:
  • platform/efl/fast/block/margin-collapse/055-expected.txt:
  • platform/efl/fast/block/margin-collapse/056-expected.txt:
  • platform/efl/fast/block/margin-collapse/057-expected.txt:
  • platform/efl/fast/block/margin-collapse/058-expected.txt:
  • platform/efl/fast/block/margin-collapse/059-expected.txt:
  • platform/efl/fast/block/margin-collapse/block-inside-inline/006-expected.txt:
  • platform/efl/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
  • platform/efl/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
  • platform/efl/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
  • platform/efl/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
  • platform/efl/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
  • platform/efl/fast/block/margin-collapse/block-inside-inline/017-expected.txt:
  • platform/efl/fast/block/margin-collapse/block-inside-inline/018-expected.txt:
  • platform/efl/fast/block/margin-collapse/block-inside-inline/019-expected.txt:
  • platform/efl/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
  • platform/efl/fast/block/margin-collapse/block-inside-inline/021-expected.txt:
  • platform/efl/fast/block/margin-collapse/block-inside-inline/022-expected.txt:
  • platform/efl/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
  • platform/efl/fast/block/positioning/negative-right-pos-expected.txt:
  • platform/efl/fast/block/positioning/table-cell-static-position-expected.txt:
  • platform/efl/fast/borders/border-antialiasing-expected.txt:
  • platform/efl/fast/borders/border-radius-different-width-001-expected.txt:
  • platform/efl/fast/borders/table-borders-expected.txt:
  • platform/efl/fast/css-generated-content/first-letter-in-nested-before-expected.txt:
  • platform/efl/fast/css-generated-content/first-letter-in-nested-before-table-expected.txt:
  • platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt:
  • platform/efl/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
  • platform/efl/fast/css-generated-content/table-parts-before-and-after-expected.txt:
  • platform/efl/fast/css-generated-content/table-row-group-with-before-expected.txt:
  • platform/efl/fast/css-generated-content/table-row-with-before-expected.txt:
  • platform/efl/fast/css-generated-content/table-with-before-expected.txt:
  • platform/efl/fast/css/003-expected.txt:
  • platform/efl/fast/css/absolute-poition-in-rtl-parent-expected.txt:
  • platform/efl/fast/css/acid2-expected.txt:
  • platform/efl/fast/css/acid2-pixel-expected.txt:
  • platform/efl/fast/css/bidi-override-in-anonymous-block-expected.txt:
  • platform/efl/fast/css/box-shadow-and-border-radius-expected.txt:
  • platform/efl/fast/css/caption-width-absolute-position-expected.txt:
  • platform/efl/fast/css/caption-width-absolute-position-offset-top-expected.txt:
  • platform/efl/fast/css/caption-width-fixed-position-expected.txt:
  • platform/efl/fast/css/caption-width-fixed-position-offset-top-expected.txt:
  • platform/efl/fast/css/caption-width-relative-position-expected.txt:
  • platform/efl/fast/css/caption-width-relative-position-offset-top-expected.txt:
  • platform/efl/fast/css/css3-nth-child-expected.txt:
  • platform/efl/fast/css/focus-ring-detached-expected.txt:
  • platform/efl/fast/css/focus-ring-multiline-expected.txt:
  • platform/efl/fast/css/h1-in-section-elements-expected.txt:
  • platform/efl/fast/css/image-rendering-expected.txt:
  • platform/efl/fast/css/min-width-with-spanned-cell-expected.txt:
  • platform/efl/fast/css/percentage-non-integer-expected.txt:
  • platform/efl/fast/css/table-text-align-quirk-expected.txt:
  • platform/efl/fast/css/table-text-align-strict-expected.txt:
  • platform/efl/fast/dom/34176-expected.txt:
  • platform/efl/fast/dom/HTMLTableElement/colSpan-expected.txt:
  • platform/efl/fast/dom/HTMLTableElement/createCaption-expected.txt:
  • platform/efl/fast/dom/row-inner-text-expected.txt:
  • platform/efl/fast/dynamic/001-expected.txt:
  • platform/efl/fast/dynamic/containing-block-change-expected.txt:
  • platform/efl/fast/dynamic/float-withdrawal-expected.txt:
  • platform/efl/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
  • platform/efl/fast/dynamic/subtree-table-cell-height-expected.txt:
  • platform/efl/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/efl/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/efl/fast/forms/001-expected.txt:
  • platform/efl/fast/forms/005-expected.txt:
  • platform/efl/fast/forms/basic-buttons-expected.txt:
  • platform/efl/fast/forms/form-element-geometry-expected.txt:
  • platform/efl/fast/forms/form-hides-table-expected.txt:
  • platform/efl/fast/forms/form-in-malformed-markup-expected.txt:
  • platform/efl/fast/forms/formmove3-expected.txt:
  • platform/efl/fast/forms/input-table-expected.txt:
  • platform/efl/fast/forms/listbox-bidi-align-expected.txt:
  • platform/efl/fast/forms/preserveFormDuringResidualStyle-expected.txt:
  • platform/efl/fast/forms/select-dirty-parent-pref-widths-expected.txt:
  • platform/efl/fast/html/details-writing-mode-expected.txt:
  • platform/efl/fast/inline-block/001-expected.txt:
  • platform/efl/fast/inline-block/overflow-clip-expected.txt:
  • platform/efl/fast/invalid/012-expected.txt:
  • platform/efl/fast/invalid/018-expected.txt:
  • platform/efl/fast/lists/004-expected.txt:
  • platform/efl/fast/lists/list-marker-before-content-table-expected.txt:
  • platform/efl/fast/multicol/span/before-child-anonymous-column-block-expected.txt:
  • platform/efl/fast/overflow/002-expected.txt:
  • platform/efl/fast/overflow/overflow-rtl-expected.txt:
  • platform/efl/fast/overflow/overflow-rtl-vertical-expected.txt:
  • platform/efl/fast/overflow/table-overflow-float-expected.txt:
  • platform/efl/fast/reflections/table-cell-expected.txt:
  • platform/efl/fast/repaint/block-selection-gap-in-table-cell-expected.txt:
  • platform/efl/fast/repaint/float-overflow-expected.txt:
  • platform/efl/fast/repaint/float-overflow-right-expected.txt:
  • platform/efl/fast/repaint/subtree-root-clip-3-expected.txt:
  • platform/efl/fast/repaint/table-cell-collapsed-border-expected.txt:
  • platform/efl/fast/repaint/table-cell-collapsed-border-scroll-expected.txt:
  • platform/efl/fast/repaint/table-cell-move-expected.txt:
  • platform/efl/fast/repaint/table-cell-overflow-expected.txt:
  • platform/efl/fast/repaint/table-cell-vertical-overflow-expected.txt:
  • platform/efl/fast/repaint/table-col-background-expected.txt:
  • platform/efl/fast/repaint/table-collapsed-border-expected.txt:
  • platform/efl/fast/repaint/table-extra-bottom-grow-expected.txt:
  • platform/efl/fast/repaint/table-outer-border-expected.txt:
  • platform/efl/fast/repaint/table-row-expected.txt:
  • platform/efl/fast/repaint/table-section-overflow-expected.txt:
  • platform/efl/fast/repaint/table-section-repaint-expected.txt:
  • platform/efl/fast/repaint/table-two-pass-layout-overpaint-expected.txt:
  • platform/efl/fast/repaint/table-writing-modes-h-expected.txt:
  • platform/efl/fast/repaint/table-writing-modes-v-expected.txt:
5:50 PM Changeset in webkit [195946] by Darin Adler
  • 9 edits in trunk/Source

Get rid of most calls to String::upper; mostly replace them with convertToASCIIUppercase
https://bugs.webkit.org/show_bug.cgi?id=153715

Reviewed by Gyuyoung Kim.

Source/WebCore:

  • editing/cocoa/HTMLConverter.mm:

(HTMLConverter::computedAttributesForElement): Use convertToASCIILowercase to fold
ASCII case when searching for fonts by name.

  • platform/network/cf/ResourceResponseCFNet.cpp:

(WebCore::ResourceResponse::platformLazyInit): Use convertToASCIIUppercase to make
the HTTP version string canonical. Not sure why it's needed at all, but the letters
we might be uppercasing are "HTTP", so no need to handle non-ASCII.

  • platform/network/cocoa/ResourceResponseCocoa.mm:

(WebCore::ResourceResponse::platformLazyInit): Ditto.

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::operator<<): Use convertToASCIIUppercase when writing the spread
method type into a text stream. The method types are all ASCII.

Source/WebKit2:

  • UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:

Use convertToASCIIUppercase on language names.

Source/WTF:

  • wtf/text/AtomicString.h:

(WTF::AtomicString::upper): Deleted.

5:20 PM Changeset in webkit [195945] by jh718.park@samsung.com
  • 2 edits in trunk

[EFL] All API tests are broken on 15.10
https://bugs.webkit.org/show_bug.cgi?id=153528

Reviewed by Gyuyoung Kim.

  • CMakeLists.txt: Having include(WebKitCommon) statement follow

CMAKE_FOO_OUTPUT_DIRECTORY otherwise all the API tests gets blocked.

4:27 PM Changeset in webkit [195944] by bshafiei@apple.com
  • 5 edits in branches/safari-601-branch/Source

Versioning.

4:27 PM Changeset in webkit [195943] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source

Versioning.

4:26 PM Changeset in webkit [195942] by mitz@apple.com
  • 6 edits in trunk/Source

[Cocoa] Remove unused definition of HAVE_HEADER_DETECTION_H
https://bugs.webkit.org/show_bug.cgi?id=153729

Reviewed by Sam Weinig.

After r141700, HAVE_HEADER_DETECTION_H is no longer used.

  • Configurations/Base.xcconfig:
4:10 PM Changeset in webkit [195941] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.1.46.96

New tag.

4:10 PM Changeset in webkit [195940] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.5.14

New tag.

4:07 PM Changeset in webkit [195939] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

B3->Air lowering should use MoveFloat more
https://bugs.webkit.org/show_bug.cgi?id=153714

Reviewed by Sam Weinig.

This is a very minor and benign bug. It just means that we will use the more canonical
MoveFloat instruction when moving floats, rather than using MoveDouble.

  • b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::relaxedMoveForType):

3:05 PM Changeset in webkit [195938] by Yusuke Suzuki
  • 5 edits
    7 adds in trunk/Source/JavaScriptCore

Should not predict OtherObj for ToThis with primitive types under strict mode
https://bugs.webkit.org/show_bug.cgi?id=153544

Reviewed by Filip Pizlo.

Currently, ToThis predicates OtherObj for primitive values.
But it's not true in strict mode.
In strict mode, ToThis does nothing on primitive values.

In this patch, we

  1. fix prediction. Handles primitive types in strict mode. And we also handles StringObject.
  2. convert it to Identity if the argument should be predicted as primitive types.

This optimization is important to implement Primitive.prototype.methods[1].
Otherwise, we always got BadType OSR exits.

[1]: https://bugs.webkit.org/show_bug.cgi?id=143889

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupToThis):

  • dfg/DFGPredictionPropagationPhase.cpp:

(JSC::DFG::PredictionPropagationPhase::propagate):

  • tests/stress/to-this-boolean.js: Added.

(Boolean.prototype.negate):
(Boolean.prototype.negate2):

  • tests/stress/to-this-double.js: Added.

(Number.prototype.negate):

  • tests/stress/to-this-int32.js: Added.

(Number.prototype.negate):

  • tests/stress/to-this-int52.js: Added.

(Number.prototype.negate):

  • tests/stress/to-this-number.js: Added.

(Number.prototype.negate):

  • tests/stress/to-this-string.js: Added.

(String.prototype.prefix):
(String.prototype.first):
(String.prototype.second):

  • tests/stress/to-this-symbol.js: Added.

(Symbol.prototype.identity):
(Symbol.prototype.identity2):

3:00 PM Changeset in webkit [195937] by mitz@apple.com
  • 20 edits in trunk/Source

[Cocoa] Remove has_include guards around use of WebKitAdditions
https://bugs.webkit.org/show_bug.cgi?id=153728

Reviewed by Andy Estes.

Guard WebKitAdditions includes with #if USE(APPLE_INTERNAL_SDK) rather than with has_include.

Source/WebCore:

  • dom/EventNames.h:
  • loader/EmptyClients.cpp:

(WebCore::fillWithEmptyClients):

  • page/MainFrame.cpp:

(WebCore::MainFrame::MainFrame):

  • page/MainFrame.h:
  • page/PageConfiguration.h:
  • platform/cocoa/WebKitAdditions.mm:
  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
  • platform/ios/LegacyTileGridTile.mm:

Source/WebKit/mac:

  • WebKitAdditions.mm:
  • WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]):

Source/WebKit2:

  • Shared/Cocoa/WebKitAdditions.mm:
  • Shared/WebCoreArgumentCoders.h:
  • Shared/mac/RemoteLayerBackingStore.mm:
  • UIProcess/API/Cocoa/WKWebView.mm:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::resetState):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::m_shouldDispatchFakeMouseMoveEvents):

2:46 PM Changeset in webkit [195936] by bshafiei@apple.com
  • 5 edits in tags/Safari-602.1.18.1/Source

Versioning.

2:42 PM Changeset in webkit [195935] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.18.1

New tag.

12:59 PM Changeset in webkit [195934] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit2

Include the right WebKitAdditions files
<rdar://problem/24429804>

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetState):

12:49 PM Changeset in webkit [195933] by bshafiei@apple.com
  • 2 edits in branches/safari-601.1.46-branch/Source/WebCore

Merged r195932. rdar://problem/24430138

12:39 PM Changeset in webkit [195932] by bshafiei@apple.com
  • 2 edits in branches/safari-601-branch/Source/WebCore

Merge patch for rdar://problem/24426332 and rdar://problem/24209109.

12:27 PM Changeset in webkit [195931] by bshafiei@apple.com
  • 4 edits in branches/safari-601-branch/Source/WebCore

Roll out r195817.

11:51 AM Changeset in webkit [195930] by bshafiei@apple.com
  • 5 edits in branches/safari-601.1.46-branch/Source

Versioning.

11:51 AM Changeset in webkit [195929] by bshafiei@apple.com
  • 5 edits in branches/safari-601-branch/Source

Versioning.

11:22 AM Changeset in webkit [195928] by Darin Adler
  • 37 edits in trunk

Replace CaseFoldingHash with ASCIICaseInsensitiveHash
https://bugs.webkit.org/show_bug.cgi?id=153639

Reviewed by Filip Pizlo.

Source/WebCore:

  • Modules/webdatabase/DatabaseAuthorizer.h: Use ASCIICaseInsensitiveHash

for whitelisted functions. Function names are all ASCII.

  • accessibility/AccessibilityObject.cpp: Use ASCIICaseInsensitiveHash

for ARIA roles. ARIA roles are all ASCII.

  • crypto/CryptoAlgorithmRegistry.h: Use ASCIICaseInsensitiveHash for

crypto algorithm names. Algorithm names are all ASCII.

  • css/CSSFontSelector.cpp:

(WebCore::registerLocalFontFacesForFamily): Use ASCIICaseInsensitiveHash
for font faces. Face names should use ASCII case insensitive matching;
there is no need for non-ASCII case folding.

  • css/CSSFontSelector.h: Ditto.
  • dom/DOMImplementation.cpp: Use ASCIICaseInsensitiveHash for the

FeatureSet. The features are all ASCII.

  • dom/Document.h: Use ASCIICaseInsensitiveHash for the access key

map. Access keys are all ASCII.

  • dom/ScriptElement.cpp:

(WebCore::isLegacySupportedJavaScriptLanguage): Use ASCIICaseInsensitiveHash
for the language set. These strings are all ASCII.

  • editing/EditorCommand.cpp: Use ASCIICaseInsensitiveHash for editor

command names. These names are all ASCII.

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parametersForPlugin): Use ASCIICaseInsensitiveHash
for parameter names. These names are all ASCII.

  • html/InputType.cpp: Use ASCIICaseInsensitiveHash for the input types.

The input types are all ASCII.

  • loader/CrossOriginAccessControl.h: Use ASCIICaseInsensitiveHash for

HTTP header field names. These names are all ASCII.

  • loader/CrossOriginPreflightResultCache.h: Ditto.
  • loader/archive/ArchiveFactory.cpp: Use ASCIICaseInsensitiveHash for

MIME types. MIME types are all ASCII.

  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes): Ditto.

  • platform/SchemeRegistry.h: Use ASCIICaseInsensitiveHas for URL schemes.

URL schemes are all ASCII.

  • platform/URL.cpp: Ditto.
  • platform/graphics/FontCache.cpp:

(WebCore::FontPlatformDataCacheKey::operator==): Use ASCIICaseInsensitiveHash.
(WebCore::FontPlatformDataCacheKeyHash::hash): Use ASCIICaseInsensitiveHash.

  • platform/graphics/FontCascade.cpp:

(WebCore::keysMatch): Rename from operator== since this operation is not
equality. Changed to equalIgnoringASCIICase and did a little streamlining.
(WebCore::makeFontCascadeCacheKey): Use reserveInitialCapacity for slightly
better memory use.
(WebCore::computeFontCascadeCacheHash): Use IntegerHasher to make computing
a hash more efficient by eliminating the overhead of building a vector and
even possible heap allocation and deallocation.
(WebCore::retrieveOrAddCachedFonts): Use keysMatch instead of ==.

  • platform/graphics/cocoa/FontCacheCoreText.cpp: Use ASCIICaseInsensitiveHash

for font family names. These names should use ASCII case insensitive matching;
there is no need for non-ASCII case folding.

  • platform/network/HTTPHeaderMap.h: Use ASCIICaseInsensitiveHash for

HTTP header field names. These names are all ASCII.

  • rendering/style/RenderStyle.cpp:

(WebCore::computeFontHash): Use IntegerHasher to avoid allocating memory just
to compute a hash. Use ASCIICaseInsensitiveHash.

Source/WebKit/win:

  • WebCoreStatistics.cpp:

(WebCoreStatistics::memoryStatistics): Use ASCIICaseInsensitiveHash for field names.
These names are all ASCII.

  • WebURLResponse.cpp:

(WebURLResponse::allHeaderFields): Use ASCIICaseInsensitiveHash for HTTP header
field names. These names are all ASCII.

Source/WebKit2:

  • UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm: Use ASCIICaseInsensitiveHash

for MIME types. MIME types are all ASCII.

  • UIProcess/Plugins/PlugInAutoStartProvider.h: Use ASCIICaseInsensitiveHash for

origins. Origin strings should use ASCII case insensitive matching and should not
fold non-ASCII case.

  • WebProcess/WebPage/WebPage.h: Use ASCIICaseInsensitiveHash for MIME types.

MIME types are all ASCII.

  • WebProcess/WebProcess.cpp:

(WebKit::addCaseFoldedCharacters): Use ASCIICaseInsensitiveHash to hash plug-in
origin strings. (See rationale above.)
(WebKit::hashForPlugInOrigin): Updated comment.

Source/WTF:

  • wtf/text/StringHash.h: Renamed CaseFoldingHash to ASCIICaseInsensitiveHash.

(WTF::ASCIICaseInsensitiveHash::foldCase): Use toASCIILower.
(WTF::ASCIICaseInsensitiveHash::equal): Use equalIgnoringASCIICase.
Also added some assertions.

  • wtf/text/StringImpl.cpp: Made the latin1CaseFoldTable private to this file,

since it's no longer needed by CaseFoldingHash. Moved it up before its first use.
(WTF::equalCompatibilityCaseless): Fixed typo in the name of this function.
(WTF::equalCompatibiltyCaselessNonNull): Deleted.

  • wtf/text/StringImpl.h: Removed declarations of latin1CaseFoldTable and

equalCompatibiltyCaselessNonNull

Tools:

  • Scripts/do-webcore-rename: Use script to do this rename.
4:08 AM Changeset in webkit [195927] by Gyuyoung Kim
  • 27 edits in trunk/Source

Reduce PassRefPtr uses in dom - 5
https://bugs.webkit.org/show_bug.cgi?id=153470

Reviewed by Darin Adler.

As a step to remove PassRefPtr, this patch reduces uses of PassRefPtr in WebCore/dom.

  • dom/Document.cpp:

(WebCore::Document::adoptNode):
(WebCore::Document::implicitClose):
(WebCore::Document::enqueuePopstateEvent):
(WebCore::Document::setInputCursor):

  • dom/Document.h:
  • dom/DocumentMarker.cpp:

(WebCore::DocumentMarkerTextMatch::instanceFor):

  • dom/Event.cpp:

(WebCore::Event::setUnderlyingEvent):

  • dom/Event.h:
  • dom/EventDispatcher.h:
  • dom/GenericEventQueue.cpp:

(WebCore::GenericEventQueue::enqueueEvent):

  • dom/GenericEventQueue.h:
  • dom/MouseEvent.cpp:

(WebCore::SimulatedMouseEvent::SimulatedMouseEvent):

  • dom/Node.cpp:

(WebCore::Node::dispatchDOMActivateEvent):

  • dom/NodeIterator.h:
  • dom/PendingScript.h:
  • dom/PopStateEvent.cpp:

(WebCore::PopStateEvent::create):

  • dom/PopStateEvent.h:
  • dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::setCSSStyleSheet): Deleted. Nobody calls this function.

  • dom/ProcessingInstruction.h:
  • dom/RangeBoundaryPoint.h:

(WebCore::RangeBoundaryPoint::RangeBoundaryPoint):

  • dom/TextEvent.cpp:

(WebCore::TextEvent::createForFragmentPaste):
(WebCore::TextEvent::TextEvent):

  • dom/TextEvent.h:
  • editing/Editor.cpp:

(WebCore::Editor::pasteAsFragment):

  • editing/Editor.h:
  • editing/mac/EditorMac.mm:

(WebCore::Editor::replaceNodeFromPasteboard):

3:41 AM Changeset in webkit [195926] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

[mips] don't save to a callee saved register too early
https://bugs.webkit.org/show_bug.cgi?id=153463

If we save $gp to $s4 in pichdr, then in some cases, we were
overwriting $s4 before LLInt's pushCalleeSaves() is called (as pichdr
is at the very beginning of a function). Now we save $gp to $s4 at the
end of pushCalleeSaves().

Patch by Guillaume Emont <guijemont@igalia.com> on 2016-01-31
Reviewed by Michael Saboff.

  • offlineasm/mips.rb:
  • llint/LowLevelInterpreter.asm:

Move the saving of $gp to $s4 from pichdr to pushCalleeSaves(). Take
the opportunity to only save $s4 as we never use the other callee
saved registers.

3:41 AM Changeset in webkit [195925] by Gyuyoung Kim
  • 14 edits in trunk/Source

Use std::make_unique<> when creating an unique_ptr object.
https://bugs.webkit.org/show_bug.cgi?id=153705

Reviewed by Darin Adler.

Source/WebCore:

Some factory functions have used std::unique_ptr<> for creating an unique_ptr object.
It is wrong. We have to use std::make_unique<>.

  • Modules/mediasession/WebMediaSessionManager.cpp:

(WebCore::WebMediaSessionManager::mockPicker):

  • inspector/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::internalStart):

  • platform/cf/RunLoopObserver.cpp:

(WebCore::RunLoopObserver::create): Deleted.

  • platform/cf/RunLoopObserver.h:

(WebCore::RunLoopObserver::RunLoopObserver):

  • platform/graphics/avfoundation/WebMediaSessionManagerMac.cpp:

(WebCore::WebMediaSessionManagerMac::platformPicker):

  • platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.h:
  • platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:

(WebCore::MediaPlaybackTargetPickerMac::create): Deleted.

  • platform/graphics/ca/cocoa/LayerFlushSchedulerMac.cpp:

(WebCore::LayerFlushScheduler::LayerFlushScheduler):

  • platform/mock/MediaPlaybackTargetPickerMock.cpp:

(WebCore::MediaPlaybackTargetPickerMock::create): Deleted.

  • platform/mock/MediaPlaybackTargetPickerMock.h:
  • rendering/FloatingObjects.cpp:

(WebCore::FloatingObject::copyToNewContainer):

Source/WebKit2:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy): Use std::make_unique<> instead of RunLoopObserver::create().

1:20 AM Changeset in webkit [195924] by youenn.fablet@crf.canon.fr
  • 3 edits in trunk/LayoutTests/imported/w3c

imported/w3c/web-platform-tests/streams-api/readable-streams/garbage-collection.html asserts frequently
https://bugs.webkit.org/show_bug.cgi?id=152436

Reviewed by Darin Adler.

GCController is not available in Worker environments, explaining probably why garbage-collection-2.html is not crashing at all.
Inlining half of the tests in garbage-collection-2.html (runned in window) to compare with garbage-collection-1.html.

  • web-platform-tests/streams-api/readable-streams/garbage-collection-2-expected.txt:
  • web-platform-tests/streams-api/readable-streams/garbage-collection-2.html:

Jan 30, 2016:

9:57 PM Changeset in webkit [195923] by hyatt@apple.com
  • 2 edits in trunk/Source/WebInspectorUI

Add the break-* properties to Web Inspector's completion set
https://bugs.webkit.org/show_bug.cgi?id=153706

Reviewed by Darin Adler.

  • UserInterface/Models/CSSKeywordCompletions.js:
8:11 PM Changeset in webkit [195922] by mitz@apple.com
  • 25 edits in trunk/Source/WebKit2

[Cocoa] Get rid of many WK_ macros for nullability
https://bugs.webkit.org/show_bug.cgi?id=153718

Sam Weinig reviewed an earlier version of this change, and Simon Fraser rubber-stamped this version.

  • Shared/API/Cocoa/WKFoundation.h: Removed definitions of WK_ASSUME_NONNULL_{BEGIN, END}, WK_NULLABLE, WK_NULL_UNSPECIFIED, and WK_NULLABLE_PROPERTY. Removed the __has_feature(assume_nonnull) case.
  • mac/postprocess-framework-headers.sh: Removed rules for rewriting the above macros. Also chanegd to rewrite WK_NULLABLE_SPECIFIER to the modern _Nullable instead of nullable.

Replaced instances of the above macros with their expansions.

  • UIProcess/API/Cocoa/WKBackForwardList.h:
  • UIProcess/API/Cocoa/WKBackForwardListItem.h:
  • UIProcess/API/Cocoa/WKError.h:
  • UIProcess/API/Cocoa/WKFrameInfo.h:
  • UIProcess/API/Cocoa/WKNavigationAction.h:
  • UIProcess/API/Cocoa/WKNavigationDelegate.h:
  • UIProcess/API/Cocoa/WKNavigationResponse.h:
  • UIProcess/API/Cocoa/WKScriptMessage.h:
  • UIProcess/API/Cocoa/WKScriptMessageHandler.h:
  • UIProcess/API/Cocoa/WKSecurityOrigin.h:
  • UIProcess/API/Cocoa/WKUIDelegate.h:
  • UIProcess/API/Cocoa/WKUserContentController.h:
  • UIProcess/API/Cocoa/WKUserScript.h:
  • UIProcess/API/Cocoa/WKWebView.h:
  • UIProcess/API/Cocoa/WKWebViewConfiguration.h:
  • UIProcess/API/Cocoa/WKWebsiteDataRecord.h:
  • UIProcess/API/Cocoa/WKWebsiteDataStore.h:
  • UIProcess/API/Cocoa/WKWindowFeatures.h:
  • UIProcess/API/Cocoa/_WKContextMenuElementInfo.h:
  • UIProcess/API/Cocoa/_WKElementInfo.h:
  • UIProcess/API/Cocoa/_WKPreviewElementInfo.h:
  • UIProcess/API/Cocoa/_WKUserStyleSheet.h:
7:59 PM Changeset in webkit [195921] by fpizlo@apple.com
  • 2 edits in trunk/Websites/webkit.org

B3 documentation style shouldn't have hacks for h1
https://bugs.webkit.org/show_bug.cgi?id=153725

Reviewed by Alexey Proskuryakov.

  • docs/b3/style.css:
5:22 PM Changeset in webkit [195920] by mitz@apple.com
  • 25 edits in trunk/Source/WebKit2

Reverted r195914, because at least one of the build.webkit.org builders still uses a compiler that doesn’t understand _Nullable.

  • Shared/API/Cocoa/WKFoundation.h:
  • UIProcess/API/Cocoa/WKBackForwardList.h:
  • UIProcess/API/Cocoa/WKBackForwardListItem.h:
  • UIProcess/API/Cocoa/WKError.h:
  • UIProcess/API/Cocoa/WKFrameInfo.h:
  • UIProcess/API/Cocoa/WKNavigationAction.h:
  • UIProcess/API/Cocoa/WKNavigationDelegate.h:
  • UIProcess/API/Cocoa/WKNavigationResponse.h:
  • UIProcess/API/Cocoa/WKScriptMessage.h:
  • UIProcess/API/Cocoa/WKScriptMessageHandler.h:
  • UIProcess/API/Cocoa/WKSecurityOrigin.h:
  • UIProcess/API/Cocoa/WKUIDelegate.h:
  • UIProcess/API/Cocoa/WKUserContentController.h:
  • UIProcess/API/Cocoa/WKUserScript.h:
  • UIProcess/API/Cocoa/WKWebView.h:
  • UIProcess/API/Cocoa/WKWebViewConfiguration.h:
  • UIProcess/API/Cocoa/WKWebsiteDataRecord.h:
  • UIProcess/API/Cocoa/WKWebsiteDataStore.h:
  • UIProcess/API/Cocoa/WKWindowFeatures.h:
  • UIProcess/API/Cocoa/_WKContextMenuElementInfo.h:
  • UIProcess/API/Cocoa/_WKElementInfo.h:
  • UIProcess/API/Cocoa/_WKPreviewElementInfo.h:
  • UIProcess/API/Cocoa/_WKUserStyleSheet.h:
  • mac/postprocess-framework-headers.sh:
5:19 PM Changeset in webkit [195919] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix GTK debug build after r195899

  • dom/EventContext.h:

(isType):

5:15 PM Changeset in webkit [195918] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Add missing include to fix building debug configuration
https://bugs.webkit.org/show_bug.cgi?id=153719

Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-01-30
Reviewed by Darin Adler.

No new tests.

  • rendering/RenderObject.cpp:
4:53 PM Changeset in webkit [195917] by commit-queue@webkit.org
  • 37 edits in trunk

Unreviewed, rolling out r195911.
https://bugs.webkit.org/show_bug.cgi?id=153723

Caused frequent assertion failures on bots (Requested by ap on
#webkit).

Reverted changeset:

"Replace CaseFoldingHash with ASCIICaseInsensitiveHash"
https://bugs.webkit.org/show_bug.cgi?id=153639
http://trac.webkit.org/changeset/195911

4:41 PM Changeset in webkit [195916] by commit-queue@webkit.org
  • 64 edits in trunk

Unreviewed, rolling out r195799 and r195828.
https://bugs.webkit.org/show_bug.cgi?id=153722

Caused assertion failures, severely affecting EWS (Requested
by ap on #webkit).

Reverted changesets:

"Web Inspector: InspectorTimelineAgent doesn't need to
recompile functions because it now uses the sampling profiler"
https://bugs.webkit.org/show_bug.cgi?id=153500
http://trac.webkit.org/changeset/195799

"Attempt to fix the Windows build after r195799"
http://trac.webkit.org/changeset/195828

4:24 PM Changeset in webkit [195915] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Network panel is empty until the window is resized
https://bugs.webkit.org/show_bug.cgi?id=153701
<rdar://problem/24423739>

Reviewed by Timothy Hatcher.

NetworkGridContentView shouldn't prevent a layout from being scheduled
when the network sidebar is collapsed.

  • UserInterface/Views/NetworkGridContentView.js:

(WebInspector.NetworkGridContentView.prototype.needsLayout): Deleted.
Removed View.prototype.needsLayout override that was preventing
layouts from being scheduled as timeline records are added.

3:50 PM Changeset in webkit [195914] by mitz@apple.com
  • 25 edits in trunk/Source/WebKit2

[Cocoa] Get rid of WK_ macros for nullability
https://bugs.webkit.org/show_bug.cgi?id=153718

Reviewed by Sam Weinig.

  • Shared/API/Cocoa/WKFoundation.h: Removed definitions of WK_ASSUME_NONNULL_{BEGIN, END}, WK_NULLABLE, WK_NULL_UNSPECIFIED, WK_NULLABLE_SPECIFIER, and WK_NULLABLE_PROPERTY.
  • mac/postprocess-framework-headers.sh: Removed rules for rewriting those macros.

Replaced instances of those macros with their expansions, but using the modern _Nullable
instead of nullable:

  • UIProcess/API/Cocoa/WKBackForwardList.h:
  • UIProcess/API/Cocoa/WKBackForwardListItem.h:
  • UIProcess/API/Cocoa/WKError.h:
  • UIProcess/API/Cocoa/WKFrameInfo.h:
  • UIProcess/API/Cocoa/WKNavigationAction.h:
  • UIProcess/API/Cocoa/WKNavigationDelegate.h:
  • UIProcess/API/Cocoa/WKNavigationResponse.h:
  • UIProcess/API/Cocoa/WKScriptMessage.h:
  • UIProcess/API/Cocoa/WKScriptMessageHandler.h:
  • UIProcess/API/Cocoa/WKSecurityOrigin.h:
  • UIProcess/API/Cocoa/WKUIDelegate.h:
  • UIProcess/API/Cocoa/WKUserContentController.h:
  • UIProcess/API/Cocoa/WKUserScript.h:
  • UIProcess/API/Cocoa/WKWebView.h:
  • UIProcess/API/Cocoa/WKWebViewConfiguration.h:
  • UIProcess/API/Cocoa/WKWebsiteDataRecord.h:
  • UIProcess/API/Cocoa/WKWebsiteDataStore.h:
  • UIProcess/API/Cocoa/WKWindowFeatures.h:
  • UIProcess/API/Cocoa/_WKContextMenuElementInfo.h:
  • UIProcess/API/Cocoa/_WKElementInfo.h:
  • UIProcess/API/Cocoa/_WKPreviewElementInfo.h:
  • UIProcess/API/Cocoa/_WKUserStyleSheet.h:
2:25 PM Changeset in webkit [195913] by beidson@apple.com
  • 4 edits in trunk

Modern IDB: Some tests crash with specific odd database names.
https://bugs.webkit.org/show_bug.cgi?id=153688

Reviewed by Darin Adler.

Source/WebCore:

No new tests (2 existing tests now pass).

  • platform/FileSystem.cpp:

(WebCore::shouldEscapeUChar): Return true for some surrogate-pair situations.
(WebCore::encodeForFileName): Pass along the previous and next characters, as well,

and do a two byte escaping for some characters.

LayoutTests:

  • platform/mac-wk1/TestExpectations:
2:19 PM Changeset in webkit [195912] by eric.carlson@apple.com
  • 5 edits
    2 adds in trunk

More than one audio and/or text track sometimes selected in media controls menu
https://bugs.webkit.org/show_bug.cgi?id=153664

Source/WebCore:

Use an <img> element for the track menu item checkmark instead of a background image and
the ::before selector.

Reviewed by Jer Noble.

Test: media/controls/track-menu.html

  • Modules/mediacontrols/mediaControlsApple.css:

(audio::-webkit-media-controls-closed-captions-container li:hover):
(audio::-webkit-media-controls-closed-captions-container li .checkmark-container):
(audio::-webkit-media-controls-closed-captions-container li.selected .checkmark-container):
(audio::-webkit-media-controls-closed-captions-container li.selected:hover .checkmark-container):
(audio::-webkit-media-controls-closed-captions-container li.selected::before): Deleted.
(audio::-webkit-media-controls-closed-captions-container li.selected:hover::before): Deleted.

  • Modules/mediacontrols/mediaControlsApple.js:

(Controller.prototype.buildCaptionMenu):
(Controller.prototype.):
(Controller.prototype.getCurrentControlsStatus):

LayoutTests:

Reviewed by Jer Noble.

  • media/controls/controls-test-helpers.js:

(ControlsTest.prototype.get currentState):
(ControlsTest.prototype.get video):
(ControlsTest.prototype.stateForControlsElement):
(ControlsTest.prototype.handleEvent):
(ControlsTest.prototype.setup):
(ControlsTest.prototype.start):
(ControlsTest.prototype.isEqualTo):
(ControlsTest.prototype.isNotEqualTo):
(ControlsTest.prototype.contains):

  • media/controls/track-menu-expected.txt: Added.
  • media/controls/track-menu.html: Added.
1:53 PM Changeset in webkit [195911] by Darin Adler
  • 37 edits in trunk

Replace CaseFoldingHash with ASCIICaseInsensitiveHash
https://bugs.webkit.org/show_bug.cgi?id=153639

Reviewed by Filip Pizlo.

Source/WebCore:

  • Modules/webdatabase/DatabaseAuthorizer.h: Use ASCIICaseInsensitiveHash

for whitelisted functions. Function names are all ASCII.

  • accessibility/AccessibilityObject.cpp: Use ASCIICaseInsensitiveHash

for ARIA roles. ARIA roles are all ASCII.

  • crypto/CryptoAlgorithmRegistry.h: Use ASCIICaseInsensitiveHash for

crypto algorithm names. Algorithm names are all ASCII.

  • css/CSSFontSelector.cpp:

(WebCore::registerLocalFontFacesForFamily): Use ASCIICaseInsensitiveHash
for font faces. Face names should use ASCII case insensitive matching;
there is no need for non-ASCII case folding.

  • css/CSSFontSelector.h: Ditto.
  • dom/DOMImplementation.cpp: Use ASCIICaseInsensitiveHash for the

FeatureSet. The features are all ASCII.

  • dom/Document.h: Use ASCIICaseInsensitiveHash for the access key

map. Access keys are all ASCII.

  • dom/ScriptElement.cpp:

(WebCore::isLegacySupportedJavaScriptLanguage): Use ASCIICaseInsensitiveHash
for the language set. These strings are all ASCII.

  • editing/EditorCommand.cpp: Use ASCIICaseInsensitiveHash for editor

command names. These names are all ASCII.

  • html/HTMLObjectElement.cpp:

(WebCore::HTMLObjectElement::parametersForPlugin): Use ASCIICaseInsensitiveHash
for parameter names. These names are all ASCII.

  • html/InputType.cpp: Use ASCIICaseInsensitiveHash for the input types.

The input types are all ASCII.

  • loader/CrossOriginAccessControl.h: Use ASCIICaseInsensitiveHash for

HTTP header field names. These names are all ASCII.

  • loader/CrossOriginPreflightResultCache.h: Ditto.
  • loader/archive/ArchiveFactory.cpp: Use ASCIICaseInsensitiveHash for

MIME types. MIME types are all ASCII.

  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes): Ditto.

  • platform/SchemeRegistry.h: Use ASCIICaseInsensitiveHas for URL schemes.

URL schemes are all ASCII.

  • platform/URL.cpp: Ditto.
  • platform/graphics/FontCache.cpp: Reworked FontPlatformDataCacheKey struct:

Made it a conventional struct with non-prefixed data members names. Removed
the "==" operator since it was appropriate for hash table lookup but wasn't
a true equality operator. Tightened the implementations of the constructors.
(WebCore::FontPlatformDataCacheKeyHash::hash): Use ASCIICaseInsensitiveHash.
(WebCore::FontPlatformDataCacheKeyHash::equal): Do the equality check here,
not using the == operator. And use equalIgnoringASCIICase.
(WebCore::FontPlatformDataCacheKeyTraits::isEmptyValue): Added this entire
traits struct so we check empty values in a more efficient way.
(WebCore::FontCache::getCachedFontPlatformData): Added comments and tweaked
style in this function.

  • platform/graphics/FontCascade.cpp:

(WebCore::keysMatch): Rename from operator== since this operation is not
equality. Changed to equalIgnoringASCIICase and did a little streamlining.
(WebCore::makeFontCascadeCacheKey): Use reserveInitialCapacity for slightly
better memory use.
(WebCore::computeFontCascadeCacheHash): Use IntegerHasher to make computing
a hash more efficient by eliminating the overhead of building a vector and
even possible heap allocation and deallocation.
(WebCore::retrieveOrAddCachedFonts): Use keysMatch instead of ==.

  • platform/graphics/cocoa/FontCacheCoreText.cpp: Use ASCIICaseInsensitiveHash

for font family names. These names should use ASCII case insensitive matching;
there is no need for non-ASCII case folding.

  • platform/network/HTTPHeaderMap.h: Use ASCIICaseInsensitiveHash for

HTTP header field names. These names are all ASCII.

  • rendering/style/RenderStyle.cpp:

(WebCore::computeFontHash): Use IntegerHasher to avoid allocating memory just
to compute a hash. Use ASCIICaseInsensitiveHash.

Source/WebKit/win:

  • WebCoreStatistics.cpp:

(WebCoreStatistics::memoryStatistics): Use ASCIICaseInsensitiveHash for field names.
These names are all ASCII.

  • WebURLResponse.cpp:

(WebURLResponse::allHeaderFields): Use ASCIICaseInsensitiveHash for HTTP header
field names. These names are all ASCII.

Source/WebKit2:

  • UIProcess/Cocoa/WKWebViewContentProviderRegistry.mm: Use ASCIICaseInsensitiveHash

for MIME types. MIME types are all ASCII.

  • UIProcess/Plugins/PlugInAutoStartProvider.h: Use ASCIICaseInsensitiveHash for

origins. Origin strings should use ASCII case insensitive matching and should not
fold non-ASCII case.

  • WebProcess/WebPage/WebPage.h: Use ASCIICaseInsensitiveHash for MIME types.

MIME types are all ASCII.

  • WebProcess/WebProcess.cpp:

(WebKit::addCaseFoldedCharacters): Use ASCIICaseInsensitiveHash to hash plug-in
origin strings. (See rationale above.)
(WebKit::hashForPlugInOrigin): Updated comment.

Source/WTF:

  • wtf/text/StringHash.h: Renamed CaseFoldingHash to ASCIICaseInsensitiveHash.

(WTF::ASCIICaseInsensitiveHash::foldCase): Use toASCIILower.
(WTF::ASCIICaseInsensitiveHash::equal): Use equalIgnoringASCIICase.
Also added some assertions.

  • wtf/text/StringImpl.cpp: Made the latin1CaseFoldTable private to this file,

since it's no longer needed by CaseFoldingHash. Moved it up before its first use.
(WTF::equalCompatibilityCaseless): Fixed typo in the name of this function.
(WTF::equalCompatibiltyCaselessNonNull): Deleted.

  • wtf/text/StringImpl.h: Removed declarations of latin1CaseFoldTable and

equalCompatibiltyCaselessNonNull

Tools:

  • Scripts/do-webcore-rename: Use script to do this rename.
1:49 PM Changeset in webkit [195910] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Object tree parent items are misaligned
https://bugs.webkit.org/show_bug.cgi?id=153699
<rdar://problem/24423683>

Patch by Devin Rousso <Devin Rousso> on 2016-01-30
Reviewed by Darin Adler.

  • UserInterface/Views/ObjectTreeView.css:

(.object-tree .object-tree):
Ensure that toplevel Object preview trees are displayed properly while also
making child trees inline.

  • UserInterface/Views/TreeOutline.css:

(.tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) > .icon):
(.tree-outline:not(.hide-disclosure-buttons) .item:not(.parent) .icon): Deleted.
This would apply to all .icon elements contained within a non-parent item,
which is not the desired effect. Instead, this should only apply to only the
.icon element of that particular non-parent item.

1:39 PM Changeset in webkit [195909] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Unreviewed, rolling out r195871.

Caused several layout tests to time out

Reverted changeset:

"Tab suspension code shouldn't use page cache cacheability
logic"
https://bugs.webkit.org/show_bug.cgi?id=153680
http://trac.webkit.org/changeset/195871

1:34 PM Changeset in webkit [195908] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Unreviewed, rebaseline bindings tests after r195904.

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::JSTestCustomNamedGetter::getOwnPropertySlot):
(WebCore::jsTestCustomNamedGetterConstructor):
(WebCore::setJSTestCustomNamedGetterConstructor):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTarget::getOwnPropertySlot):
(WebCore::jsTestEventTargetConstructor):
(WebCore::setJSTestEventTargetConstructor):

  • bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::JSTestOverrideBuiltins::getOwnPropertySlot):
(WebCore::jsTestOverrideBuiltinsConstructor):
(WebCore::setJSTestOverrideBuiltinsConstructor):

1:01 PM Changeset in webkit [195907] by Chris Dumez
  • 32 edits
    4 adds in trunk

[JS Bindings] prototype.constructor should be writable
https://bugs.webkit.org/show_bug.cgi?id=149412
<rdar://problem/22545096>

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline W3C tests now that more checks are passing.

  • web-platform-tests/XMLHttpRequest/interfaces-expected.txt:
  • web-platform-tests/dom/interfaces-expected.txt:
  • web-platform-tests/fetch/api/headers/headers-idl-expected.txt:
  • web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

prototype.constructor should have the following properties:
{ Writable?: true, Enumerable?: false, Configurable?: true }

as per the Web IDL specification:
https://heycam.github.io/webidl/#interface-prototype-object

In WebKit, it is currently not writable. It is writable in Firefox.

This patch was first landed in r190085 but was rolled out for causing
crashes: <rdar://problem/22825602>. The issue was that even though we
marked constructor as writable, we failed to generate a setter for it.
This patch addresses the issue and the crash in <rdar://problem/22825602>
no longer occurs after this change. A regression test is also added for
this crash.

Tests:
fast/dom/HTMLDocument/constructor-setter-crash.html
fast/dom/prototype-constructor-setter.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributesHashTable):
(GenerateImplementation):

  • bindings/scripts/IDLAttributes.txt:
  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::setJSTestActiveDOMObjectConstructor):

  • bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:

(WebCore::setJSTestClassWithJSBuiltinConstructorConstructor):

  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::setJSTestCustomConstructorWithNoInterfaceObjectConstructor):

  • bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp:

(WebCore::setJSTestCustomNamedGetterConstructor):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::setJSTestEventConstructorConstructor):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::setJSTestEventTargetConstructor):

  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::setJSTestExceptionConstructor):

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::setJSTestGenerateIsReachableConstructor):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::setJSTestInterfaceConstructor):

  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:

(WebCore::setJSTestJSBuiltinConstructorConstructor):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::setJSTestMediaQueryListListenerConstructor):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::setJSTestNamedConstructorConstructor):

  • bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::setJSTestNodeConstructor):

  • bindings/scripts/test/JS/JSTestNondeterministic.cpp:

(WebCore::setJSTestNondeterministicConstructor):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::setJSTestObjConstructor):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::setJSTestOverloadedConstructorsConstructor):

  • bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::setJSTestOverrideBuiltinsConstructor):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::setJSTestSerializedScriptValueInterfaceConstructor):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::setJSTestTypedefsConstructor):

  • bindings/scripts/test/JS/JSattribute.cpp:

(WebCore::setJSattributeConstructor):

  • bindings/scripts/test/JS/JSreadonly.cpp:

(WebCore::setJSreadonlyConstructor):

  • page/DOMWindow.idl:

LayoutTests:

  • fast/dom/HTMLDocument/constructor-setter-crash-expected.txt: Added.
  • fast/dom/HTMLDocument/constructor-setter-crash.html: Added.

Add regression test for crash at <rdar://problem/22825602>.

  • fast/dom/prototype-constructor-setter-expected.txt: Added.
  • fast/dom/prototype-constructor-setter.html: Added.

Add new test checking that prototype.constructor is writable.

  • js/dom/constructor-attributes-expected.txt:

Rebaseline existing test now that prototype.constructor is writable.

12:57 PM Changeset in webkit [195906] by Yusuke Suzuki
  • 3 edits in trunk/Source/JavaScriptCore

[B3] JetStream/quicksort.c fails/hangs on Linux with GCC
https://bugs.webkit.org/show_bug.cgi?id=153647

Reviewed by Filip Pizlo.

In B3ComputeDivisionMagic, we accidentally perform sub, add operation onto signed integer. (In this case, int32_t)
But integer overflow is undefined behavior in C[1][2]
As a result, in GCC 4.9 release build, computeDivisionMagic(2) returns unexpected value.
divisor = 2
d = 2
signedMin = INT32_MIN = -2147483647 (-0x7fffffff)
t = signedMin
anc = t - 1 - (t % ad) Oops, we performed overflow operation!

So, anc value becomes undefined.
In this patch, we first cast all the operated values to unsigned one.
Reading the code, there are no operations that depends on signedness. (For example, we used aboveEqual like unsigned operations for comparison.)

[1]: http://blog.llvm.org/2011/05/what-every-c-programmer-should-know.html
[2]: http://dl.acm.org/citation.cfm?id=2522728

  • b3/B3ComputeDivisionMagic.h:

(JSC::B3::computeDivisionMagic):

  • b3/testb3.cpp:

(JSC::B3::testComputeDivisionMagic):
(JSC::B3::run):

12:48 PM Changeset in webkit [195905] by akling@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Shrink Heap::m_executables after cleaning it.
<https://webkit.org/b/153682>

Reviewed by Darin Adler.

The Heap::m_executables Vector was never shrunk down, despite sometimes
getting pretty huge (~500kB in my longest-running WebContent process.)

After GC has finished pruning unmarked Executables, shrink the Vector.

  • heap/Heap.cpp:

(JSC::Heap::clearUnmarkedExecutables):

12:10 PM Changeset in webkit [195904] by Chris Dumez
  • 12 edits in trunk

Move more 'constructor' properties to the prototype
https://bugs.webkit.org/show_bug.cgi?id=153667

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Rebaseline several W3C tests now that more checks are passing. A lot of
the 'constructor' attributes checks are still failing because the
attribute is not writable. This is being addressed via Bug 149412.

  • web-platform-tests/dom/collections/HTMLCollection-supported-property-names-expected.txt:
  • web-platform-tests/dom/interfaces-expected.txt:
  • web-platform-tests/dom/nodes/Element-getElementsByTagName-expected.txt:
  • web-platform-tests/html/dom/documents/dom-tree-accessors/document.forms-expected.txt:
  • web-platform-tests/html/dom/interfaces-expected.txt:

Source/WebCore:

Move more 'constructor' properties to the prototype. In particular, we
used to keep the 'constructor' on the instance for interfaces that have
an indexed / named property getter because our getOwnPropertySlot()
implementation used to be wrong for such interfaces.

However, getOwnPropertySlot() should be correct after r188590 so we
should now be able to move the 'constructor' up to the prototype for
these interfaces, as per the specification:
http://heycam.github.io/webidl/#interface-prototype-object

No new tests, already covered by existing tests.

  • bindings/js/JSPluginElementFunctions.h:

(WebCore::pluginElementCustomGetOwnPropertySlot):
Add a null check for staticPropHashTable. It is now null because this
type no longer has any property on the instance now that 'constructor'
is on the prototype.

  • bindings/scripts/CodeGeneratorJS.pm:

(ConstructorShouldBeOnInstance):

LayoutTests:

Rebaseline a couple of tests now that 'constructor' is on the prototype
for more interfaces.

  • fast/dom/htmlcollection-getownpropertynames-expected.txt:
  • storage/domstorage/localstorage/delete-defineproperty-removal-expected.txt:
12:06 PM Changeset in webkit [195903] by fpizlo@apple.com
  • 5 edits in trunk/Websites/webkit.org

Improve the style of B3 documentation
https://bugs.webkit.org/show_bug.cgi?id=153674

Reviewed by Oliver Hunt.

This makes the style of the B3 documentation look like the Wiki, which I think is
appropriate for the kind of content that we're putting into it - in particular, the font
is the perfect size for dense content. The style also doesn't require much spoonfeeding
from the HTML side so you can write nice looking documentation by just using really
basic HTML constructs.

  • docs/b3/assembly-intermediate-representation.html:
  • docs/b3/index.html:
  • docs/b3/intermediate-representation.html:
  • docs/b3/style.css:
12:01 PM Changeset in webkit [195902] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

[GTK] Use configured python executable when executing generate-inspector-gresource-manifest.py
https://bugs.webkit.org/show_bug.cgi?id=153712

Patch by Jeremy Huddleston Sequoia <jeremyhu@apple.com> on 2016-01-30
Reviewed by Michael Catanzaro.

  • PlatformGTK.cmake:
11:30 AM Changeset in webkit [195901] by adachan@apple.com
  • 10 edits in trunk/Source

Enable VIDEO_PRESENTATION_MODE only in Debug and Release builds on Mac
https://bugs.webkit.org/show_bug.cgi?id=153665

Reviewed by Dan Bernstein.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/Platform.h:

Remove this as the flag is already defined in FeatureDefines.xcconfig files.

11:22 AM Changeset in webkit [195900] by ddkilzer@apple.com
  • 2 edits in trunk/Source/WebCore

[iOS] WebKit1 apps crash in _ZN7WebCore16DiskCacheMonitorC2ERKNS_15ResourceRequestENS_9SessionIDEPK20_CFCachedURLResponse_block_invoke1
<http://webkit.org/b/153710>
<rdar://problem/23116706>

Reviewed by Darin Adler.

  • loader/cocoa/DiskCacheMonitorCocoa.mm:

(WebCore::DiskCacheMonitor::DiskCacheMonitor):

  • Fix race condition on iOS WebKit1 clients by calling the block to cancel the DiskCacheMonitor on the WebThread, which is the same thread where the CFCachedURLResponseCallBackBlock is called.
  • Removed whitespace to adhere to style.
10:38 AM Changeset in webkit [195899] by rniwa@webkit.org
  • 14 edits
    2 adds in trunk

TouchList should be retargeted
https://bugs.webkit.org/show_bug.cgi?id=149592

Reviewed by Antti Koivisto.

Source/WebCore:

Retarget touch target's using the same algorithm as the one used for related targets instead of
EventRelatedNodeResolver which is removed in this patch.

Also enable the retargeting on iOS.

Test: fast/shadow-dom/touch-event-ios.html

  • dom/EventContext.cpp:

(WebCore::TouchEventContext::TouchEventContext):
(WebCore::TouchEventContext::handleLocalEvents):
(WebCore::TouchEventContext::checkReachability):

  • dom/EventContext.h:

(WebCore::toTouchEventContext):
(WebCore::EventContext::isUnreachableNode):

  • dom/EventDispatcher.cpp:

(WebCore::EventRelatedNodeResolver): Deleted.
(WebCore::EventPath::EventPath):
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::addRelatedNodeResolversForTouchList): Deleted.
(WebCore::EventPath::updateTouchLists): Deleted.
(WebCore::EventPath::setRelatedTarget): Removed superfluous UNUSED_PARAM since the argument is always used.
(WebCore::EventPath::retargetTouch): Extracted from updateTouchLists/setRelatedTarget. Clones Touch object
with the new target for each event context just like related targets.
(WebCore::EventPath::retargetTouchLists): Renamed from updateTouchLists. Calls retargetTouch on each Touch
object in each TouchList.

  • dom/TouchEvent.h:

Tools:

Added touchDownAtPoint and liftUpAtPoint to UIScriptController so that we can test touch events with
multiple touch targets on iOS. fast/shadow-dom/touch-event-ios.html uses this new testing feature.

  • WebKitTestRunner/UIScriptContext/Bindings/UIScriptController.idl:
  • WebKitTestRunner/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::touchDownAtPoint): Added.
(WTR::UIScriptController::liftUpAtPoint): Added.

  • WebKitTestRunner/UIScriptContext/UIScriptController.h:
  • WebKitTestRunner/ios/HIDEventGenerator.h:
  • WebKitTestRunner/ios/HIDEventGenerator.mm:

(-[HIDEventGenerator touchDown:touchCount:completionBlock:]): Added. Sends touch down and waits.
(-[HIDEventGenerator liftUp:touchCount:completionBlock:]): Ditto for lift up.

  • WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::touchDownAtPoint): Added.
(WTR::UIScriptController::liftUpAtPoint): Added.

LayoutTests:

Added a regression test for retargeting touch targets on iOS.

  • fast/shadow-dom/touch-event-ios-expected.txt: Added.
  • fast/shadow-dom/touch-event-ios.html: Added.
  • platform/mac/TestExpectations: Added the failing expectation on Mac since touch support is not enabled.
10:09 AM Changeset in webkit [195898] by Yusuke Suzuki
  • 2 edits in trunk/Source/JavaScriptCore

[B3] REGRESSION(r195882): Should break early after modConstant replaceWithNewValue succeeds
https://bugs.webkit.org/show_bug.cgi?id=153711

Reviewed by Filip Pizlo.

Should break after modConstant replaceWithNewValue succeeds. m_value is already replaced with Identity
if modConstant succeeds. So it does not have any children. m_value->child(1) breaks testb3.

  • b3/B3ReduceStrength.cpp:
9:03 AM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro
(diff)
9:03 AM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro
(diff)
9:02 AM Changeset in webkit [195897] by Michael Catanzaro
  • 2 edits in trunk/LayoutTests

[GTK] Two disk cache tests are failing

Unreviewed gardening.

  • platform/gtk/TestExpectations:
8:48 AM Changeset in webkit [195896] by Michael Catanzaro
  • 2 edits in trunk/LayoutTests

[GTK] Some W3C DOM tests are failing

Unreviewed gardening.

  • platform/gtk/TestExpectations:
8:38 AM Changeset in webkit [195895] by Michael Catanzaro
  • 2 edits in trunk/LayoutTests

[GTK] IndexedDB expectations gardening

Unreviewed gardening.

  • platform/gtk/TestExpectations:
8:14 AM Changeset in webkit [195894] by Michael Catanzaro
  • 2 edits in trunk/LayoutTests

[GTK] platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html is failing

Unreviewed gardening.

  • platform/gtk/TestExpectations:
8:03 AM Changeset in webkit [195893] by Michael Catanzaro
  • 2 edits in trunk/LayoutTests

[GTK] Some organization in the test expectations file

Unreviewed.

  • platform/gtk/TestExpectations:
7:33 AM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro
(diff)
7:28 AM Changeset in webkit [195892] by hyatt@apple.com
  • 20 edits
    35 adds in trunk

Support break-after, break-before and break-inside.
https://bugs.webkit.org/show_bug.cgi?id=148814

Reviewed by Dean Jackson.

Source/WebCore:

New tests added in printing/, fast/multicol/, and fast/regions.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::convertToPageBreak):
(WebCore::convertToColumnBreak):
(WebCore::convertToRegionBreak):
For backwards compatibility, keep support for all the old properties in
computed style. This means we have to convert the break-* property values
into keywords that make sense for the legacy properties. This mainly
involves mapping "page", "column", "region" to "always" (similar rule for
the avoid-* versions as well).

(WebCore::ComputedStyleExtractor::propertyValue):
Add support for the three new break-* properties.

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
Add support for the new break properties.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::operator BreakBetween):
(WebCore::CSSPrimitiveValue::operator BreakInside):
Add converters for the new BreakBetween and BreakInside enums. Remove
the EPageBreak enum, since it is no longer used.

  • css/CSSPropertyNames.in:
  • css/CSSValueKeywords.in:

Add the new properties and the new values supported by the properties
to the keywords lists.

  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertFontSynthesis):
(WebCore::StyleBuilderConverter::convertPageBreakBetween):
(WebCore::StyleBuilderConverter::convertPageBreakInside):
(WebCore::StyleBuilderConverter::convertColumnBreakBetween):
(WebCore::StyleBuilderConverter::convertColumnBreakInside):
(WebCore::StyleBuilderConverter::convertRegionBreakBetween):
(WebCore::StyleBuilderConverter::convertRegionBreakInside):
In order to map the legacy properties into the new break-* values
we have custom converter functions.

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintChild):
(WebCore::RenderBlock::childBoxIsUnsplittableForFragmentation):
(WebCore::RenderBlock::computeRegionRangeForBoxChild):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::applyBeforeBreak):
(WebCore::RenderBlockFlow::applyAfterBreak):
Patch the block code to check the correct new break-* constants. For
avoidance, this means checking both the general avoid value and the
specific value (e.g., avoid-page). In place of "always", we check
the specific value (e.g., column) and then for page specifically, we
also treat "left", "right", "recto" and "verso" as "always break" for now.

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::changeRequiresLayout):
Make sure changes to the break properties trigger relayout.

  • rendering/style/RenderStyle.h:

Add getters and setters for the break-* properties and remove all
occurrences of the legacy page, column and region values from the RenderStyle.

  • rendering/style/RenderStyleConstants.cpp:

(WebCore::alwaysPageBreak):
We have a helper function here for mapping several constant values to "page".

  • rendering/style/RenderStyleConstants.h:

Definitions of the new BreakBetween and BreakInside enums.

  • rendering/style/StyleMultiColData.cpp:

(WebCore::StyleMultiColData::StyleMultiColData):
(WebCore::StyleMultiColData::operator==):

  • rendering/style/StyleMultiColData.h:

Remove the column-specific break data.

  • rendering/style/StyleRareNonInheritedData.cpp:

(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):

  • rendering/style/StyleRareNonInheritedData.h:

Remove the region-specific break data and replace it with generic break
data that is now used by all three pagination models.

LayoutTests:

  • TestExpectations:
  • fast/multicol/standardized-break-properties-expected.txt: Added.
  • fast/multicol/standardized-break-properties.html: Added.
  • fast/multicol/vertical-lr/standardized-break-properties-expected.txt: Added.
  • fast/multicol/vertical-lr/standardized-break-properties.html: Added.
  • fast/multicol/vertical-rl/standardized-break-properties-expected.txt: Added.
  • fast/multicol/vertical-rl/standardized-break-properties.html: Added.
  • fast/regions/text-break-properties-expected.txt: Added.
  • fast/regions/text-break-properties.html: Added.
  • printing/allowed-breaks-expected.txt: Added.
  • printing/allowed-breaks.html: Added.
  • printing/break-after-avoid-expected.txt: Added.
  • printing/break-after-avoid-page-expected.txt: Added.
  • printing/break-after-avoid-page.html: Added.
  • printing/break-after-avoid.html: Added.
  • printing/break-always-expected.txt: Added.
  • printing/break-always.html: Added.
  • printing/break-avoid-expected.txt: Added.
  • printing/break-avoid-page-expected.txt: Added.
  • printing/break-avoid-page.html: Added.
  • printing/break-avoid.html: Added.
  • printing/break-display-none-expected.txt: Added.
  • printing/break-display-none.html: Added.
  • printing/break-inside-avoid-expected.txt: Added.
  • printing/break-inside-avoid-page-expected.txt: Added.
  • printing/break-inside-avoid-page.html: Added.
  • printing/break-inside-avoid.html: Added.
  • printing/script-tests/allowed-breaks.js: Added.

(test):

  • printing/script-tests/break-after-avoid-page.js: Added.

(test):

  • printing/script-tests/break-after-avoid.js: Added.

(test):

  • printing/script-tests/break-always.js: Added.

(test):

  • printing/script-tests/break-avoid-page.js: Added.

(test):

  • printing/script-tests/break-avoid.js: Added.

(test):

  • printing/script-tests/break-display-none.js: Added.

(test):

  • printing/script-tests/break-inside-avoid-page.js: Added.

(test):

  • printing/script-tests/break-inside-avoid.js: Added.

(test):

7:25 AM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro
(diff)
7:18 AM blue1.jpg attached to SquirrelFish by smartmiltoys@gmail.com
[http://smartmiltoys.com/kidkraft-train-table/
4:53 AM Changeset in webkit [195891] by Yusuke Suzuki
  • 13 edits in trunk

Enable SamplingProfiler on POSIX environment
https://bugs.webkit.org/show_bug.cgi?id=153584

Reviewed by Michael Saboff.

.:

Add features.h header check. It will define GLIBC.

  • Source/cmake/OptionsCommon.cmake:

Source/JavaScriptCore:

In this patch, we implement suspend and resume mechanizm for POSIX threads.
And with GLIBC, we can retrieve registers from it.

We take the following strategy.

Suspend side.

  1. install sigaction to the threads.
  2. in the profiler (suspend / resume callers), emit signal with pthread_kill and wait with POSIX semaphore.
  3. in the signal handler, up the POSIX semaphore. Use sem_post because it is the async-signal-safe function in POSIX.
  4. in the signal handler, perform sigsuspend to stop the thread until being resumed.
  5. in the profiler, we can be waken up from the semaphore because (3) ups.

Resume side.

  1. in the profiler, emit signal and wait on the semaphore.
  2. in the signal handler, it is waken up from the sigsuspend.
  3. in the signal handler, up the semaphore.
  4. in the profiler, the profiler is waken up from the semaphore. It is ensured that the given thread is resumed by the signal.
  • heap/MachineStackMarker.cpp:

(pthreadSignalHandlerSuspendResume):
(JSC::MachineThreads::Thread::Thread):
(JSC::MachineThreads::Thread::~Thread):
(JSC::MachineThreads::Thread::suspend):
(JSC::MachineThreads::Thread::resume):
(JSC::MachineThreads::Thread::getRegisters):
(JSC::MachineThreads::Thread::Registers::stackPointer):
(JSC::MachineThreads::Thread::Registers::framePointer):
(JSC::MachineThreads::Thread::Registers::instructionPointer):
(JSC::MachineThreads::Thread::Registers::llintPC):
(JSC::MachineThreads::Thread::freeRegisters):

  • heap/MachineStackMarker.h:
  • runtime/SamplingProfiler.cpp:

(JSC::reportStats):

  • tests/stress/call-varargs-from-inlined-code-with-odd-number-of-arguments.js:
  • tests/stress/call-varargs-from-inlined-code.js:
  • tests/stress/v8-earley-boyer-strict.js:

Source/WTF:

Use GLIBC since mcontext_t layout depends on it.

  • wtf/Platform.h:

Tools:

  • Scripts/run-jsc-stress-tests:
Note: See TracTimeline for information about the timeline view.