Timeline



Aug 28, 2016:

11:55 PM Changeset in webkit [205111] by fred.wang@free.fr
  • 12 edits
    5 adds in trunk

Add support for non-BMP operators U+1EEF0 and U+1EEF1
https://bugs.webkit.org/show_bug.cgi?id=153984

Source/WebCore:

Patch by Frederic Wang <fwang@igalia.com> on 2016-08-25
Reviewed by Darin Adler.

Tests: mathml/presentation/non-bmp-operators-spacing.html

mathml/presentation/non-bmp-operators-stretching.html

  • mathml/MathMLOperatorDictionary.cpp: We move the definition of operator dictionary Entry

here as it is not used by external code.
We now also accept non-BMP operators and add entries for U+1EEF0 and U+1EEF1.
(WebCore::extractProperty): Helper function to convert from Entry structure to a Property
structure.
(WebCore::MathMLOperatorDictionary::search): This function now accepts a non-BMP parameter
and returns a Property structure.
(WebCore::MathMLOperatorDictionary::isVertical): This function now accepts a non-BMP parameter.

  • mathml/MathMLOperatorDictionary.h: Replace the Entry structure with a Property structure

which was used by MathMLOperatorElement. Update the signatures of search and isVertical.

  • mathml/MathMLOperatorElement.cpp:

(WebCore::MathMLOperatorElement::parseOperatorChar): Remove the special case that excludes
non-BMP operators.
(WebCore::MathMLOperatorElement::computeDictionaryProperty): Rename the property structure
to use the one moved into MathMLOperatorDictionary.h. We no longer need to convert the result
of the search call.
(WebCore::MathMLOperatorElement::dictionaryProperty): Rename the property structure.

  • mathml/MathMLOperatorElement.h: Make OperatorChar accept non-BMP operators.

MathMLOperatorElement::DictionaryProperty is now moved into MathMLOperatorDictionary
and renamed Property.

  • rendering/mathml/MathOperator.cpp: Accept non-BMP operators.
  • rendering/mathml/MathOperator.h: Ditto.
  • rendering/mathml/RenderMathMLFencedOperator.cpp:

(WebCore::RenderMathMLFencedOperator::updateOperatorContent): Adjust code to use the new
return type of MathMLOperatorDictionary::search.

  • rendering/mathml/RenderMathMLFencedOperator.h: Accept non-BMP operators.
  • rendering/mathml/RenderMathMLOperator.cpp: Ditto.
  • rendering/mathml/RenderMathMLOperator.h: Ditto.

LayoutTests:

We add two reftests to check that the non-BMP operators are properly
handled by the MathML dictionary (form, properties, direction) as well
as the rendering code (spacing, stretching). We test the new horizontal
strechy operators U+1EEF0 and U+1EEF1 as well as the letter U+1D400
which is not a real mathematical operator. We add a minimal test
font which contains a black square for U+005F, U+1EEF0, U+1EEF1, U+1D400
and the data that can be used to stretch them horizontally.

Patch by Frederic Wang <fwang@igalia.com> on 2016-08-25
Reviewed by Darin Adler.

  • mathml/presentation/non-bmp-operators-spacing-expected.html: Added.
  • mathml/presentation/non-bmp-operators-spacing.html: Added.
  • mathml/presentation/non-bmp-operators-stretching-expected.html: Added.
  • mathml/presentation/non-bmp-operators-stretching.html: Added.
  • mathml/presentation/non-bmp-operators.woff: Added.
11:49 PM Changeset in webkit [205110] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

[Fetch API] Ensure response cloning works when data is loading
https://bugs.webkit.org/show_bug.cgi?id=161137

Patch by Youenn Fablet <youenn@apple.com> on 2016-08-28
Reviewed by Darin Adler.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/response/response-clone-expected.txt:
  • web-platform-tests/fetch/api/response/response-clone.html: New tests highly inspired from Chromium similar tests.

Source/WebCore:

Test: http/tests/fetch/clone-after-load-is-finished.html and updated wpt test

FetchBody is only able to clone data when requested by Response in case the data is already there.
If data is loaded from FetchLoader, each received chunk should be given to each cloned response.
The simplest approach is to create a ReadableStream body for the cloned Response and use it for the teeing.

  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::BodyLoader::didSucceed): Postpone stream closing if there is still data to enqueue in the FetchBody.

  • Modules/fetch/FetchResponse.h:
  • Modules/fetch/FetchResponse.idl:
  • Modules/fetch/FetchResponse.js:

(clone): If response is being loaded, create a ReadableStream body so that loaded data cloning is handled by ReadableStream tee.

  • Modules/streams/ReadableStreamInternals.js: Restrict firstReadCallback to the case of a readable ReadableStream.

If stream is errored or closed, FetchResponse will already have disposed of its source.
(readFromReadableStreamDefaultReader):

  • bindings/js/WebCoreBuiltinNames.h:

LayoutTests:

  • http/tests/fetch/clone-response-body-expected.txt: Added.
  • http/tests/fetch/clone-response-body.html: Added.
10:57 PM Changeset in webkit [205109] by jiewen_tan@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, update iOS simulator WK1 flaky tests.

  • platform/ios-simulator-wk1/TestExpectations:
6:19 PM Changeset in webkit [205108] by Michael Catanzaro
  • 3 edits in trunk/LayoutTests

Remove flakiness expectations from switch to threaded compositor

This is completely hopeless, since there is a seemingly-unlimited number of tests that have
been broken. Suppressing an arbitrary subset of the failures is not helping anything. Keep
only records for tests that are really flaky.

Retain expectations for flaky timeouts and crashes.

4:31 PM Changeset in webkit [205107] by sbarati@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

Make SpeculatedType a 64-bit integer
https://bugs.webkit.org/show_bug.cgi?id=161268

Reviewed by Filip Pizlo and Benjamin Poulain.

I'm going to introduce two new types into this and we only
have room for one in 32-bits. So, this patch widens SpeculatedType
to 64 bits. This also pulls this information through the DFG where
we needed to change DFGNode to support this.

  • bytecode/SpeculatedType.h:
  • dfg/DFGNode.cpp:

(JSC::DFG::Node::convertToPutHint):
(JSC::DFG::Node::promotedLocationDescriptor):

  • dfg/DFGNode.h:

(JSC::DFG::Node::Node):
(JSC::DFG::Node::convertToCheckStructure):
(JSC::DFG::Node::constant):
(JSC::DFG::Node::convertToConstant):
(JSC::DFG::Node::convertToConstantStoragePointer):
(JSC::DFG::Node::convertToPutStack):
(JSC::DFG::Node::convertToGetStack):
(JSC::DFG::Node::convertToGetByOffset):
(JSC::DFG::Node::convertToMultiGetByOffset):
(JSC::DFG::Node::convertToPutByOffset):
(JSC::DFG::Node::convertToMultiPutByOffset):
(JSC::DFG::Node::convertToPhantomNewObject):
(JSC::DFG::Node::convertToPhantomNewFunction):
(JSC::DFG::Node::convertToPhantomNewGeneratorFunction):
(JSC::DFG::Node::convertToPhantomCreateActivation):
(JSC::DFG::Node::convertToGetLocal):
(JSC::DFG::Node::lazyJSValue):
(JSC::DFG::Node::initializationValueForActivation):
(JSC::DFG::Node::tryGetVariableAccessData):
(JSC::DFG::Node::variableAccessData):
(JSC::DFG::Node::unlinkedLocal):
(JSC::DFG::Node::unlinkedMachineLocal):
(JSC::DFG::Node::stackAccessData):
(JSC::DFG::Node::phi):
(JSC::DFG::Node::identifierNumber):
(JSC::DFG::Node::getPutInfo):
(JSC::DFG::Node::accessorAttributes):
(JSC::DFG::Node::newArrayBufferData):
(JSC::DFG::Node::indexingType):
(JSC::DFG::Node::typedArrayType):
(JSC::DFG::Node::inlineCapacity):
(JSC::DFG::Node::scopeOffset):
(JSC::DFG::Node::capturedArgumentsOffset):
(JSC::DFG::Node::variablePointer):
(JSC::DFG::Node::callVarargsData):
(JSC::DFG::Node::loadVarargsData):
(JSC::DFG::Node::targetBytecodeOffsetDuringParsing):
(JSC::DFG::Node::targetBlock):
(JSC::DFG::Node::branchData):
(JSC::DFG::Node::switchData):
(JSC::DFG::Node::getHeapPrediction):
(JSC::DFG::Node::cellOperand):
(JSC::DFG::Node::watchpointSet):
(JSC::DFG::Node::storagePointer):
(JSC::DFG::Node::uidOperand):
(JSC::DFG::Node::typeInfoOperand):
(JSC::DFG::Node::transition):
(JSC::DFG::Node::structureSet):
(JSC::DFG::Node::structure):
(JSC::DFG::Node::storageAccessData):
(JSC::DFG::Node::multiGetByOffsetData):
(JSC::DFG::Node::multiPutByOffsetData):
(JSC::DFG::Node::objectMaterializationData):
(JSC::DFG::Node::arrayMode):
(JSC::DFG::Node::arithMode):
(JSC::DFG::Node::arithRoundingMode):
(JSC::DFG::Node::setArithRoundingMode):
(JSC::DFG::Node::executionCounter):
(JSC::DFG::Node::typeLocation):
(JSC::DFG::Node::basicBlockLocation):
(JSC::DFG::Node::numberOfArgumentsToSkip):
(JSC::DFG::Node::OpInfoWrapper::OpInfoWrapper):
(JSC::DFG::Node::OpInfoWrapper::operator=):

  • dfg/DFGOpInfo.h:

(JSC::DFG::OpInfo::OpInfo):

  • dfg/DFGPromotedHeapLocation.h:

(JSC::DFG::PromotedLocationDescriptor::imm1):
(JSC::DFG::PromotedLocationDescriptor::imm2):

3:38 PM Changeset in webkit [205106] by akling@apple.com
  • 7 edits in trunk/Source

document.title setter can't throw.
<https://webkit.org/b/161302>

Reviewed by Antti Koivisto.

Source/WebCore:

Remove [SetterRaisesException] from document.title and replace
ExceptionCode propagation with ASSERT_NO_EXCEPTION.

Setting the .textContent of a SVGTitleElement or HTMLTitleElement
will never fail, so there's no exception to propagate.

  • dom/Document.cpp:

(WebCore::Document::setTitle):

  • dom/Document.h:
  • dom/Document.idl:
  • html/ImageDocument.cpp:

(WebCore::ImageDocument::finishedParsing):

Source/WebKit/mac:

  • DOM/DOMDocument.mm:

(-[DOMDocument setTitle:]):

10:36 AM Changeset in webkit [205105] by fred.wang@free.fr
  • 9 edits in trunk/Source/WebCore

MathML renderers should use struct to pass long list of LayoutUnits
https://bugs.webkit.org/show_bug.cgi?id=161084

Patch by Frederic Wang <fwang@igalia.com> on 2016-08-23
Reviewed by Darin Adler.

RenderMathMLFraction, RenderMathMLMenclose, RenderMathMLScripts and RenderMathMLUnderOver
have helper functions to retrieve a list of LayoutUnit parameters. We gather them in a single
struct instead of using a long list of LayoutUnit& parameters.

No new tests, behavior is unchanged.

  • rendering/mathml/RenderMathMLFraction.cpp:

(WebCore::RenderMathMLFraction::getFractionParameters):
(WebCore::RenderMathMLFraction::getStackParameters):
(WebCore::RenderMathMLFraction::layoutBlock):

  • rendering/mathml/RenderMathMLFraction.h:
  • rendering/mathml/RenderMathMLMenclose.cpp:

(WebCore::RenderMathMLMenclose::getSpaceAroundContent):
(WebCore::RenderMathMLMenclose::computePreferredLogicalWidths):
(WebCore::RenderMathMLMenclose::layoutBlock):

  • rendering/mathml/RenderMathMLMenclose.h:
  • rendering/mathml/RenderMathMLScripts.cpp:

(WebCore::RenderMathMLScripts::getScriptMetricsAndLayoutIfNeeded):
(WebCore::RenderMathMLScripts::layoutBlock):

  • rendering/mathml/RenderMathMLScripts.h:
  • rendering/mathml/RenderMathMLUnderOver.cpp:

(WebCore::RenderMathMLUnderOver::getVerticalParameters):
(WebCore::RenderMathMLUnderOver::layoutBlock):

  • rendering/mathml/RenderMathMLUnderOver.h:
9:54 AM Changeset in webkit [205104] by akling@apple.com
  • 17 edits in trunk/Source

Clean up some .text attribute setters that don't throw.
<https://webkit.org/b/161292>

Reviewed by Darin Adler.

Source/WebCore:

Remove [SetterRaisesException] for three .text attributes
and replace them with ASSERT_NO_EXCEPTION.

These setters behave like .textContent, which can't throw as
it's always okay to replace an Element's children with a Text.

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::setText):

  • html/HTMLAnchorElement.h:
  • html/HTMLAnchorElement.idl:
  • html/HTMLOptionElement.cpp:

(WebCore::HTMLOptionElement::setText):

  • html/HTMLOptionElement.h:
  • html/HTMLOptionElement.idl:
  • html/HTMLTitleElement.cpp:

(WebCore::HTMLTitleElement::setText):

  • html/HTMLTitleElement.h:
  • html/HTMLTitleElement.idl:

Source/WebKit/mac:

  • DOM/DOMHTMLTitleElement.mm:

(-[DOMHTMLTitleElement setText:]):

8:46 AM Changeset in webkit [205103] by hyatt@apple.com
  • 8 edits
    20 adds
    2 deletes in trunk/Source/WebCore

Initial landing of CSS Parser Tokenization (and files to support that). Not used yet.
https://bugs.webkit.org/show_bug.cgi?id=161174

This code is imported from Blink and is their CSS parser (modified to work in WebKit).
It is from commit e4bb90df7f2ed8a63975b5ed27a1b488cb9b146f, Mon Aug 22 2016.

Reviewed by Simon Fraser.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • css/CSSMarkup.cpp: Added.

(WebCore::isCSSTokenizerIdentifier):
(WebCore::serializeCharacter):
(WebCore::serializeCharacterAsCodePoint):
(WebCore::serializeIdentifier):
(WebCore::serializeString):
(WebCore::serializeURI):
(WebCore::serializeFontFamily):

  • css/CSSMarkup.h: Added.
  • css/CSSOMUtils.cpp: Removed.
  • css/CSSOMUtils.h: Removed.
  • css/CSSSelector.cpp:
  • css/parser/CSSParserFastPaths.cpp: Added.
  • css/parser/CSSParserFastPaths.h: Added.
  • css/parser/CSSParserIdioms.h: Added.

(WebCore::isCSSSpace):
(WebCore::isNameStartCodePoint):
(WebCore::isNameCodePoint):

  • css/parser/CSSParserObserver.h: Added.

(WebCore::CSSParserObserver::~CSSParserObserver):

  • css/parser/CSSParserObserverWrapper.cpp: Added.

(WebCore::CSSParserObserverWrapper::startOffset):
(WebCore::CSSParserObserverWrapper::previousTokenStartOffset):
(WebCore::CSSParserObserverWrapper::endOffset):
(WebCore::CSSParserObserverWrapper::skipCommentsBefore):
(WebCore::CSSParserObserverWrapper::yieldCommentsBefore):

  • css/parser/CSSParserObserverWrapper.h: Added.

(WebCore::CSSParserObserverWrapper::CSSParserObserverWrapper):
(WebCore::CSSParserObserverWrapper::observer):
(WebCore::CSSParserObserverWrapper::addComment):
(WebCore::CSSParserObserverWrapper::addToken):
(WebCore::CSSParserObserverWrapper::finalizeConstruction):

  • css/parser/CSSParserToken.cpp: Added.

(WebCore::cssPrimitiveValueUnitFromTrie):
(WebCore::stringToUnitType):
(WebCore::CSSParserToken::CSSParserToken):
(WebCore::CSSParserToken::convertToDimensionWithUnit):
(WebCore::CSSParserToken::convertToPercentage):
(WebCore::CSSParserToken::delimiter):
(WebCore::CSSParserToken::numericSign):
(WebCore::CSSParserToken::numericValueType):
(WebCore::CSSParserToken::numericValue):
(WebCore::CSSParserToken::parseAsUnresolvedCSSPropertyID):
(WebCore::CSSParserToken::id):
(WebCore::CSSParserToken::functionId):
(WebCore::CSSParserToken::hasStringBacking):
(WebCore::CSSParserToken::copyWithUpdatedString):
(WebCore::CSSParserToken::valueDataCharRawEqual):
(WebCore::CSSParserToken::operator==):
(WebCore::CSSParserToken::serialize):

  • css/parser/CSSParserToken.h: Added.

(WebCore::CSSParserToken::operator!=):
(WebCore::CSSParserToken::type):
(WebCore::CSSParserToken::value):
(WebCore::CSSParserToken::getHashTokenType):
(WebCore::CSSParserToken::getBlockType):
(WebCore::CSSParserToken::unitType):
(WebCore::CSSParserToken::unicodeRangeStart):
(WebCore::CSSParserToken::unicodeRangeEnd):
(WebCore::CSSParserToken::initValueFromStringView):

  • css/parser/CSSParserTokenRange.cpp: Added.

(WebCore::CSSParserTokenRange::eofToken):
(WebCore::CSSParserTokenRange::makeSubRange):
(WebCore::CSSParserTokenRange::consumeBlock):
(WebCore::CSSParserTokenRange::consumeComponentValue):
(WebCore::CSSParserTokenRange::serialize):

  • css/parser/CSSParserTokenRange.h: Added.

(WebCore::CSSParserTokenRange::CSSParserTokenRange):
(WebCore::CSSParserTokenRange::atEnd):
(WebCore::CSSParserTokenRange::end):
(WebCore::CSSParserTokenRange::peek):
(WebCore::CSSParserTokenRange::consume):
(WebCore::CSSParserTokenRange::consumeIncludingWhitespace):
(WebCore::CSSParserTokenRange::consumeWhitespace):
(WebCore::CSSParserTokenRange::begin):

  • css/parser/CSSPropertyParser.cpp: Added.

(WebCore::hasPrefix):
(WebCore::cssPropertyID):
(WebCore::cssPropertyNameIOSAliasing):
(WebCore::isAppleLegacyCssValueKeyword):
(WebCore::cssValueKeywordID):
(WebCore::unresolvedCSSPropertyID):

  • css/parser/CSSPropertyParser.h: Added.

(WebCore::CSSPropertyParser::inQuirksMode):

  • css/parser/CSSPropertyParserHelpers.cpp: Added.
  • css/parser/CSSPropertyParserHelpers.h: Added.

(WebCore::CSSPropertyParserHelpers::identMatches):
(WebCore::CSSPropertyParserHelpers::consumeIdent):
(WebCore::CSSPropertyParserHelpers::isCSSWideKeyword):

  • css/parser/CSSTokenizer.cpp: Added.

(WebCore::CSSTokenizer::Scope::Scope):
(WebCore::CSSTokenizer::Scope::tokenRange):
(WebCore::CSSTokenizer::Scope::tokenCount):
(WebCore::isNewLine):
(WebCore::twoCharsAreValidEscape):
(WebCore::CSSTokenizer::CSSTokenizer):
(WebCore::CSSTokenizer::reconsume):
(WebCore::CSSTokenizer::consume):
(WebCore::CSSTokenizer::whiteSpace):
(WebCore::CSSTokenizer::blockStart):
(WebCore::CSSTokenizer::blockEnd):
(WebCore::CSSTokenizer::leftParenthesis):
(WebCore::CSSTokenizer::rightParenthesis):
(WebCore::CSSTokenizer::leftBracket):
(WebCore::CSSTokenizer::rightBracket):
(WebCore::CSSTokenizer::leftBrace):
(WebCore::CSSTokenizer::rightBrace):
(WebCore::CSSTokenizer::plusOrFullStop):
(WebCore::CSSTokenizer::asterisk):
(WebCore::CSSTokenizer::lessThan):
(WebCore::CSSTokenizer::comma):
(WebCore::CSSTokenizer::hyphenMinus):
(WebCore::CSSTokenizer::solidus):
(WebCore::CSSTokenizer::colon):
(WebCore::CSSTokenizer::semiColon):
(WebCore::CSSTokenizer::hash):
(WebCore::CSSTokenizer::circumflexAccent):
(WebCore::CSSTokenizer::dollarSign):
(WebCore::CSSTokenizer::verticalLine):
(WebCore::CSSTokenizer::tilde):
(WebCore::CSSTokenizer::commercialAt):
(WebCore::CSSTokenizer::reverseSolidus):
(WebCore::CSSTokenizer::asciiDigit):
(WebCore::CSSTokenizer::letterU):
(WebCore::CSSTokenizer::nameStart):
(WebCore::CSSTokenizer::stringStart):
(WebCore::CSSTokenizer::endOfFile):
(WebCore::CSSTokenizer::nextToken):
(WebCore::CSSTokenizer::consumeNumber):
(WebCore::CSSTokenizer::consumeNumericToken):
(WebCore::CSSTokenizer::consumeIdentLikeToken):
(WebCore::CSSTokenizer::consumeStringTokenUntil):
(WebCore::CSSTokenizer::consumeUnicodeRange):
(WebCore::isNonPrintableCodePoint):
(WebCore::CSSTokenizer::consumeUrlToken):
(WebCore::CSSTokenizer::consumeBadUrlRemnants):
(WebCore::CSSTokenizer::consumeSingleWhitespaceIfNext):
(WebCore::CSSTokenizer::consumeUntilCommentEndFound):
(WebCore::CSSTokenizer::consumeIfNext):
(WebCore::CSSTokenizer::consumeName):
(WebCore::CSSTokenizer::consumeEscape):
(WebCore::CSSTokenizer::nextTwoCharsAreValidEscape):
(WebCore::CSSTokenizer::nextCharsAreNumber):
(WebCore::CSSTokenizer::nextCharsAreIdentifier):
(WebCore::CSSTokenizer::registerString):

  • css/parser/CSSTokenizer.h: Added.

(WebCore::CSSTokenizer::Scope::storeString):

  • css/parser/CSSTokenizerInputStream.cpp: Added.

(WebCore::CSSTokenizerInputStream::CSSTokenizerInputStream):
(WebCore::CSSTokenizerInputStream::advanceUntilNonWhitespace):
(WebCore::CSSTokenizerInputStream::getDouble):

  • css/parser/CSSTokenizerInputStream.h: Added.

(WebCore::CSSTokenizerInputStream::nextInputChar):
(WebCore::CSSTokenizerInputStream::peekWithoutReplacement):
(WebCore::CSSTokenizerInputStream::advance):
(WebCore::CSSTokenizerInputStream::pushBack):
(WebCore::CSSTokenizerInputStream::skipWhilePredicate):
(WebCore::CSSTokenizerInputStream::length):
(WebCore::CSSTokenizerInputStream::offset):
(WebCore::CSSTokenizerInputStream::rangeAt):

  • platform/Length.h:
7:45 AM Changeset in webkit [205102] by jfernandez@igalia.com
  • 4 edits
    2 adds in trunk

Should never be reached failure in WebCore::RenderFlexibleBox::alignChildren
https://bugs.webkit.org/show_bug.cgi?id=151591
<rdar://problem/27711829>

Reviewed by Darin Adler.

Source/WebCore:

The align-self and align-items CSS properties were originally defined in the
Flexbible Box specification. The new CSS Box Alignment specification tries
to generalize them so they can be used by other layout models, as it's the
case of the GridLayout spec.

Since we have implemented the Grid Layout spec behind a runtime flag, we should
do the same with the new syntax of these properties.

Test: css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html

  • css/CSSParser.cpp:

(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::alignChildren):

LayoutTests:

Test to verify that align-self and align-items CSS properties use the old
syntax when the Grid Layout feature is not enabled.

  • css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled-expected.txt: Added.
  • css3/flexbox/new-alignment-values-invalid-if-grid-not-enabled.html: Added.
2:35 AM Changeset in webkit [205101] by fred.wang@free.fr
  • 6 edits in trunk

Improve parsing of the menclose notation attribute value
https://bugs.webkit.org/show_bug.cgi?id=161045

Patch by Frederic Wang <fwang@igalia.com> on 2016-08-28
Reviewed by Darin Adler.

Source/WebCore:

We improve the way the list of menclose notations is parsed to avoid allocating a vector and
accept any whitespace as separators.

New test cases in mathml/presentation/menclose-notation-equivalence.html

  • mathml/MathMLMencloseElement.cpp: Include HTMLParserIdioms.h to use isHTMLSpace.

(WebCore::MathMLMencloseElement::addNotationFlags): Helper function to perform the relevant
addNotation calls from a notation name.
(WebCore::MathMLMencloseElement::parseNotationAttribute): Use only simple string operations
to determine the list of notations.

  • mathml/MathMLMencloseElement.h: Declare the new helper function.

LayoutTests:

We add some cases in menclose-notation-equivalence to verify that one can use any sequence of
whitespace to separate notation values. We try with 0, 1, 2 or 3 notation values.

  • mathml/presentation/menclose-notation-equivalence-expected.html:
  • mathml/presentation/menclose-notation-equivalence.html:
1:50 AM Changeset in webkit [205100] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

Make MathMLSpaceElement and MathMLTokenElement inherit from MathMLPresentationElement
https://bugs.webkit.org/show_bug.cgi?id=161232

Patch by Frederic Wang <fwang@igalia.com> on 2016-08-28
Reviewed by Darin Adler.

The mrow-like features of MathMLPresentationElement are now moved into RenderMathMLRow.
Hence we make MathMLSpaceElement and MathMLTokenElement inherit from the generic class
MathMLPresentationElement for presentation MathML elements.

No new tests, already covered by existing tests.

  • mathml/MathMLSpaceElement.cpp:

(WebCore::MathMLSpaceElement::MathMLSpaceElement): Derive from MathMLPresentationElement.
(WebCore::MathMLSpaceElement::parseAttribute): Ditto.

  • mathml/MathMLSpaceElement.h: Ditto. Override acceptsDisplayStyleAttribute as a small

optimization. isPresentationMathML is no longer needed.

  • mathml/MathMLTokenElement.cpp:

(WebCore::MathMLTokenElement::MathMLTokenElement): Derive from MathMLPresentationElement.
(WebCore::MathMLTokenElement::didAttachRenderers): Ditto.
(WebCore::MathMLTokenElement::childrenChanged): Ditto.
(WebCore::MathMLTokenElement::parseAttribute): Deleted. No need to override this function
any more since it's already implemented in MathMLPresentationElement.

  • mathml/MathMLTokenElement.h: Derive from MathMLPresentationElement. Override

acceptsDisplayStyleAttribute as a small optimization. isPresentationMathML is no longer
needed.

1:41 AM Changeset in webkit [205099] by fred.wang@free.fr
  • 3 edits in trunk/Source/WebCore

RenderMathMLRow::firstLineBaseline does not need to be overridden in RenderMathMLMenclose
https://bugs.webkit.org/show_bug.cgi?id=161127

Patch by Frederic Wang <fwang@igalia.com> on 2016-08-28
Reviewed by Darin Adler.

RenderMathMLRow::firstLineBaseline already provides the correct calculation of ascent for
non-empty menclose elements. Empty menclose elements are not used in practice so the
calculated value is irrelevant. Aligning on mrow (i.e. leaving firstLineBaseline to 0)
is fine. This change allows to get rid of the m_ascent member and helps to keep good baseline
alignment when the zoom level changes (bug 161126).

No new tests, already covered by existing tests.

  • rendering/mathml/RenderMathMLMenclose.cpp:

(WebCore::RenderMathMLMenclose::RenderMathMLMenclose): Remove initialization of m_ascent.
(WebCore::RenderMathMLMenclose::layoutBlock): No need to calculate m_ascent. The height and
content location can be determined without introducing local variables ascent or descent.
(WebCore::RenderMathMLMenclose::firstLineBaseline): Deleted. We just use the implementation
from RenderMathMLRow.

  • rendering/mathml/RenderMathMLMenclose.h: Delete m_ascent and do not override

firstLineBaseline.

1:26 AM Changeset in webkit [205098] by commit-queue@webkit.org
  • 4 edits
    2 adds in trunk

More cleanup for the mpadded implementation
https://bugs.webkit.org/show_bug.cgi?id=161136

Source/WebCore:

Patch by Frederic Wang <fwang@igalia.com> on 2016-08-28
Reviewed by Darin Adler.

We perform the following cleanup for the mpadded renderer class:
1) We do not store the ascent on the class. This may make update more reliable and will
help for general improvement of MathML ascents (bug 155879).
2) We split resolveWidth/resolveAttributes into smaller functions and improve the coding
style. This helps to calculate firstLineBaseline in 1).
3) We do not override updateFromElement and styleDidChange to perform setNeedsLayout calls.
These calls already seem unnecessary and can be removed even more safely after 1).

We add a test for style change. Change of attributes as well as metrics calcuation of empty
and non-empty mpadded elements are already covered by other tests.

Test: mathml/presentation/mpadded-style-change.html

  • rendering/mathml/RenderMathMLPadded.cpp:

(WebCore::RenderMathMLPadded::voffset): New helper function to resolve voffset.
(WebCore::RenderMathMLPadded::lspace): Ditto for lspace.
(WebCore::RenderMathMLPadded::mpaddedWidth): Ditto for width.
(WebCore::RenderMathMLPadded::mpaddedHeight): Ditto for height.
(WebCore::RenderMathMLPadded::mpaddedDepth): Ditto for detph.
(WebCore::RenderMathMLPadded::computePreferredLogicalWidths): Use mpaddedWidth().
(WebCore::RenderMathMLPadded::layoutBlock): Use the new helper functions.
(WebCore::RenderMathMLPadded::firstLineBaseline): Use voffset or mpaddedHeight for baseline
calculation instead of m_padded.
(WebCore::RenderMathMLPadded::resolveWidth): Deleted. Renamed mpaddedWidth.
(WebCore::RenderMathMLPadded::resolveAttributes): Deleted. Split into smaller functions.
(WebCore::RenderMathMLPadded::updateFromElement): Deleted. We do not need to call
setNeedsLayout.
(WebCore::RenderMathMLPadded::styleDidChange): Deleted. Ditto.

  • rendering/mathml/RenderMathMLPadded.h: Update function declaration and remove m_ascent.

LayoutTests:

We add a test for style change in mpadded.

Patch by Frederic Wang <fwang@igalia.com> on 2016-08-28
Reviewed by Darin Adler.

  • mathml/presentation/mpadded-style-change-expected.html: Added.
  • mathml/presentation/mpadded-style-change.html: Added.

Aug 27, 2016:

10:55 PM Changeset in webkit [205097] by commit-queue@webkit.org
  • 8 edits in trunk

URLParser should parse relative URLs
https://bugs.webkit.org/show_bug.cgi?id=161282

Patch by Alex Christensen <achristensen@webkit.org> on 2016-08-27
Reviewed by Darin Adler.

Source/WebCore:

Partially covered by new API tests, but once the parser is complete enough we can
use the url web platform tests to more fully test this. It's still a work in
progress only used by tests.

  • platform/URLParser.cpp:

(WebCore::URLParser::urlLengthUntilPart):
(WebCore::URLParser::copyURLPartsUntil):
Added some helper functions to reduce redundant code. When parsing relative URLs,
we often want to copy large parts of the base URL, but the stopping point differs.
(WebCore::URLParser::parse):
The parser now returns a URL instead of an Optional<URL> because a URL has a m_isValid which behaves like Optional.

  • platform/URLParser.h:

(WebCore::URLParser::parse):

Source/WTF:

  • wtf/text/StringView.h:

Use a std::reference_wrapper for the StringView& to make it reassignable so we can add an operator=.

Tools:

  • TestWebKitAPI/Tests/WTF/StringView.cpp:

(TestWebKitAPI::TEST):
Added some tests for the new operator=.
Test saving iterators, restoring iterators, and even assigning iterators to new CodePoints objects.
Using the same iterator to iterate multiple objects is bad practice, but it's possible and now tested.

  • TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::checkURL):
(TestWebKitAPI::TEST_F):
(TestWebKitAPI::checkRelativeURL):
(TestWebKitAPI::checkURLDifferences):
(TestWebKitAPI::shouldFail):
Add some relative URL tests.

10:29 PM Changeset in webkit [205096] by Chris Dumez
  • 15 edits in trunk

Update generated bindings to throw a SecurityError when denying cross-origin access to properties
https://bugs.webkit.org/show_bug.cgi?id=161270

Reviewed by Darin Adler.

Source/WebCore:

Update generated bindings to throw a SecurityError when denying cross-origin
access to properties, as per the HTML specification:

Firefox and Chrome already throw but Webkit was logging an error message and
returning undefined instead.

No new tests, updated existing tests.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::canAccessDocument):
(WebCore::BindingSecurity::shouldAllowAccessToNode):

  • bindings/js/JSDOMBinding.h:
  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

LayoutTests:

Update / rebaseline existing tests to reflect behavior change.

  • http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:
  • http/tests/security/cross-frame-access-call-expected.txt:
  • http/tests/security/cross-frame-access-call.html:
  • http/tests/security/cross-origin-window-property-access-expected.txt:
  • http/tests/security/location-cross-origin-expected.txt:
  • http/tests/security/location-cross-origin.html:
  • http/tests/security/xss-DENIED-assign-location-href-javascript-expected.txt:
  • http/tests/security/xss-DENIED-method-with-iframe-proto-expected.txt:
  • http/tests/security/xss-DENIED-method-with-iframe-proto.html:
10:24 PM Changeset in webkit [205095] by Chris Dumez
  • 3 edits in trunk/Source/WebCore

Follow-up fixes after r205030.
https://bugs.webkit.org/show_bug.cgi?id=161216

Reviewed by Darin Adler.

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::isHTMLSpaceOrDelimiter):
(WebCore::isNumberStart):
(WebCore::parseHTMLListOfOfFloatingPointNumberValues):

  • html/parser/HTMLParserIdioms.h:
6:27 PM Changeset in webkit [205094] by commit-queue@webkit.org
  • 13 edits in trunk

WTR needs an implementation of setAutomaticLinkDetectionEnabled
https://bugs.webkit.org/show_bug.cgi?id=87162

Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-27
Source/WebKit2:

Reviewed by Darin Adler

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleSetAutomaticLinkDetectionEnabled): Added WKBundleSetAutomaticLinkDetectionEnabled definition.

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h: Added WKBundleSetAutomaticLinkDetectionEnabled declaration.
  • WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setAutomaticLinkDetectionEnabled): Added setAutomaticLinkDetectionEnabled definition.

  • WebProcess/InjectedBundle/InjectedBundle.h: Added setAutomaticLinkDetectionEnabled declaration.
  • WebProcess/WebProcess.h: Declared setTextCheckerState public.

Tools:

Reviewed by Darin Adler.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: Added setAutomaticLinkDetectionEnabled binding.
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::beginTesting): Set automatic link detection to false by default.

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setAutomaticLinkDetectionEnabled): Added setAutomaticLinkDetectionEnabled definition.

  • WebKitTestRunner/InjectedBundle/TestRunner.h: Added setAutomaticLinkDetectionEnabled declaration.

LayoutTests:

Reviewed by Darin Adler.

  • platform/wk2/TestExpectations: Removed 2 now passing tests.
5:40 PM Changeset in webkit [205093] by commit-queue@webkit.org
  • 71 edits in trunk/Source/WebCore

Add final keyword to final classes and overriden methods in WebCore/css
https://bugs.webkit.org/show_bug.cgi?id=161182

Patch by Rawinder Singh <rawinder.singh-webkit@cisra.canon.com.au> on 2016-08-27
Reviewed by Darin Adler.

  • Mark classes in the WebCore/css directory final as appropriate.
  • Update WebCore/css classes so that overriden methods in final classes are marked final.
  • css/CSSAnimationTriggerScrollValue.h:
  • css/CSSAspectRatioValue.h:
  • css/CSSBasicShapes.h:
  • css/CSSBorderImageSliceValue.h:
  • css/CSSCalculationValue.cpp:

(WebCore::determineCategory):

  • css/CSSCalculationValue.h:
  • css/CSSCanvasValue.h:
  • css/CSSCharsetRule.h:
  • css/CSSComputedStyleDeclaration.h:
  • css/CSSContentDistributionValue.h:
  • css/CSSCrossfadeValue.h:
  • css/CSSCursorImageValue.h:
  • css/CSSCustomPropertyValue.h:
  • css/CSSFilterImageValue.h:
  • css/CSSFontFaceLoadEvent.h:
  • css/CSSFontFaceSrcValue.h:
  • css/CSSFontFeatureValue.h:
  • css/CSSFontSelector.h:
  • css/CSSFontValue.h:
  • css/CSSFunctionValue.h:
  • css/CSSGradientValue.h:
  • css/CSSGridAutoRepeatValue.h:
  • css/CSSGridLineNamesValue.h:
  • css/CSSGridTemplateAreasValue.h:
  • css/CSSImageSetValue.h:
  • css/CSSImageValue.h:
  • css/CSSInheritedValue.h:
  • css/CSSInitialValue.h:
  • css/CSSKeyframeRule.h:
  • css/CSSKeyframesRule.h:
  • css/CSSLineBoxContainValue.h:
  • css/CSSNamedImageValue.h:
  • css/CSSPrimitiveValue.h:
  • css/CSSReflectValue.h:
  • css/CSSRevertValue.h:
  • css/CSSRuleList.h:
  • css/CSSSegmentedFontFace.h:
  • css/CSSShadowValue.h:
  • css/CSSStyleSheet.cpp:
  • css/CSSStyleSheet.h:
  • css/CSSSupportsRule.h:
  • css/CSSTimingFunctionValue.h:
  • css/CSSUnicodeRangeValue.h:
  • css/CSSUnknownRule.h:
  • css/CSSUnsetValue.h:
  • css/CSSValue.cpp:
  • css/CSSVariableDependentValue.h:
  • css/CSSVariableValue.h:
  • css/Counter.h:
  • css/DOMCSSNamespace.h:
  • css/DashboardRegion.h:
  • css/LengthRepeat.h:
  • css/MediaList.h:
  • css/MediaQueryList.h:
  • css/MediaQueryMatcher.h:
  • css/Pair.h:
  • css/PropertySetCSSStyleDeclaration.h:
  • css/RGBColor.h:
  • css/Rect.h:
  • css/StyleMedia.h:
  • css/StyleProperties.h:
  • css/StyleRule.h:
  • css/StyleRuleImport.h:
  • css/StyleSheetContents.h:
  • css/StyleSheetList.h:
  • css/ViewportStyleResolver.h:
  • css/WebKitCSSFilterValue.h:
  • css/WebKitCSSRegionRule.h:
  • css/WebKitCSSTransformValue.h:
  • css/WebKitCSSViewportRule.h:
5:36 PM Changeset in webkit [205092] by Simon Fraser
  • 6 edits in trunk/Source

Add more Editing logging
https://bugs.webkit.org/show_bug.cgi?id=161287

Reviewed by Darin Adler.

Add logging which tracks how key events get from the UI process to the
web process, and down to form fields.

  • editing/Editor.cpp:

(WebCore::Editor::handleTextEvent):
(WebCore::Editor::appliedEditing):

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::insertTextAndNotifyAccessibility):

  • html/HTMLTextFormControlElement.cpp:

(WebCore::HTMLTextFormControlElement::didEditInnerTextValue):

  • page/EventHandler.cpp:

(WebCore::EventHandler::keyEvent):
(WebCore::EventHandler::handleTextInputEvent):

5:15 PM Changeset in webkit [205091] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

Unused cxxabi.h include in JSGlobalObjectInspectorController.cpp
https://bugs.webkit.org/show_bug.cgi?id=161120

Patch by Don Olmstead <don.olmstead@am.sony.com> on 2016-08-27
Reviewed by Darin Adler.

  • inspector/JSGlobalObjectInspectorController.cpp:
5:14 PM Changeset in webkit [205090] by pvollan@apple.com
  • 2 edits in trunk

[Win] Enable 'warning as error' compiler setting.
https://bugs.webkit.org/show_bug.cgi?id=161243

Reviewed by Darin Adler.

  • Source/cmake/OptionsWin.cmake:
5:13 PM Changeset in webkit [205089] by commit-queue@webkit.org
  • 6 edits in trunk

Web Inspector: Make localizedString.js diff and commit friendly (UTF16 -> UTF8)
https://bugs.webkit.org/show_bug.cgi?id=28685
<rdar://problem/16460975>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-27
Reviewed by Darin Adler.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:
  • WebInspectorUI.xcodeproj/project.pbxproj:

Convert the file to UTF-8. Future diffs should display as text.

Tools:

  • Scripts/extract-localizable-js-strings:
  • Scripts/update-webkit-localizable-strings:

WebInspectorUI localizedStrings.js is now UTF-8. Other clients of
this script still use UTF-16, so keep that the default.

5:12 PM Changeset in webkit [205088] by commit-queue@webkit.org
  • 16 edits
    5 deletes in trunk

Remove more custom JavaScript bindings
https://bugs.webkit.org/show_bug.cgi?id=161293

Patch by Sam Weinig <sam@webkit.org> on 2016-08-27
Reviewed by Darin Adler.

Source/WebCore:

Remove custom bindings for AudioContext, DOMFormData, MediaSession and WebKitPoint.

  • Modules/mediasession/MediaSession.cpp:

(WebCore::MediaSession::MediaSession):

  • Modules/mediasession/MediaSession.h:

Change to take Document explicitly, since that is what it
expecting.

  • Modules/webaudio/AudioContext.cpp:

(WebCore::AudioContext::create):

  • Modules/webaudio/AudioContext.h:

Remove unused ExceptionCode parameter.

  • Modules/webaudio/AudioContext.idl:
  • html/DOMFormData.idl:
  • html/HTMLFormElement.idl:
  • page/WebKitPoint.idl:

Switch to use the generated constructor.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSBindingsAllInOne.cpp:

Remove files.

  • bindings/js/JSAudioContextCustom.cpp: Removed.
  • bindings/js/JSDOMFormDataCustom.cpp: Removed.
  • bindings/js/JSMediaSessionCustom.cpp: Removed.
  • bindings/js/JSWebKitPointCustom.cpp: Removed.

Remove in favor of generated variants.

  • bindings/js/JSHTMLInputElementCustom.h: Removed.

Remove unused header.

  • page/WebKitPoint.h:

(WebCore::WebKitPoint::create):
(WebCore::WebKitPoint::WebKitPoint):
Move NaN replacement into the implementation and out of the bindings.

LayoutTests:

  • webaudio/audionode-expected.txt:
  • webaudio/audionode.html:

Update test for correct behavior of the constructor.

5:11 PM Changeset in webkit [205087] by ap@apple.com
  • 2 edits in trunk/Tools

REGRESSION (r204052): Popovers on bot watcher's dashboard are broken
https://bugs.webkit.org/show_bug.cgi?id=161254

Reviewed by Darin Adler.

Simplify the CSS. My understanding that the CSS was correct, and the root cause
is tracked in bug 160478.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Popover.css:
5:10 PM Changeset in webkit [205086] by commit-queue@webkit.org
  • 9 edits in trunk/LayoutTests

Race between creating/deleting a database in test
https://bugs.webkit.org/show_bug.cgi?id=161285

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-27
Reviewed by Darin Adler.

Because IndexedDB creation is asynchronous, we were not waiting for the
database to be completely open before sending more commands. These
could race and give unexpected results. Wait for the database to be
successfully created before interacting with it.

  • inspector/indexeddb/resources/utilities.js:

(createEmptyDatabase):
(createDatabaseWithStores):
Send a single when the database creation is completed.

  • inspector/indexeddb/clearObjectStore-expected.txt:
  • inspector/indexeddb/clearObjectStore.html:
  • inspector/indexeddb/deleteDatabaseNamesWithSpace.html:
  • inspector/indexeddb/requestData-expected.txt:
  • inspector/indexeddb/requestDatabase-expected.txt:
  • inspector/indexeddb/requestDatabase.html:
  • inspector/indexeddb/requestDatabaseNames.html:

Listen for the database created signal before proceeding
with the test.

3:13 PM Changeset in webkit [205085] by rniwa@webkit.org
  • 9 edits
    2 adds in trunk

Source/WebCore:
Add adopted callback for custom elements
https://bugs.webkit.org/show_bug.cgi?id=161284

Reviewed by Antti Koivisto.

Added the support for adoptedCallback: https://dom.spec.whatwg.org/#concept-node-adopt
For now, we only support this callback on appendChild.

Test: fast/custom-elements/adopted-callback.html

  • bindings/js/JSCustomElementInterface.cpp:

(WebCore::JSCustomElementInterface::invokeCallback): Added JSDOMGlobalObject* as an argument to the callback so that
we can invoke toJS on Document in invokeAdoptedCallback.
(WebCore::JSCustomElementInterface::setAdoptedCallback): Added.
(WebCore::JSCustomElementInterface::invokeAdoptedCallback): Added.
(WebCore::JSCustomElementInterface::setAttributeChangedCallback):

  • bindings/js/JSCustomElementInterface.h:

(WebCore::JSCustomElementInterface::hasConnectedCallback): Added.
(WebCore::JSCustomElementInterface::hasDisconnectedCallback): Added.
(WebCore::JSCustomElementInterface::hasAdoptedCallback): Added.

  • bindings/js/JSCustomElementRegistryCustom.cpp:

(WebCore::JSCustomElementRegistry::define):

  • dom/CustomElementReactionQueue.cpp:

(WebCore::CustomElementReactionQueueItem::CustomElementReactionQueueItem): Added a variant that takes two documents.
(WebCore::CustomElementReactionQueueItem::invoke):
(WebCore::CustomElementReactionQueue::enqueueConnectedCallbackIfNeeded): Fixed a bug that this function was always
enqueuing a callback even when the interface didn't have connectedCallback. Also, there is no need to check
the nullity of the interface since it should never be null.
(WebCore::CustomElementReactionQueue::enqueueDisconnectedCallbackIfNeeded): Ditto.
(WebCore::CustomElementReactionQueue::enqueueAdoptedCallbackIfNeeded): Added.
(WebCore::CustomElementReactionQueue::enqueueAttributeChangedCallbackIfNeeded): Assert that the interface is never
null instead of exiting early.

  • dom/CustomElementReactionQueue.h:
  • dom/Element.cpp:

(WebCore::Element::didMoveToNewDocument): Added a call to enqueueAdoptedCallbackIfNeeded.

LayoutTests:
adoptcallback

Add adopted callback for custom elements
https://bugs.webkit.org/show_bug.cgi?id=161284

Reviewed by Antti Koivisto.

  • fast/custom-elements/adopted-callback-expected.txt: Added.
  • fast/custom-elements/adopted-callback.html: Added.
  • fast/custom-elements/resources/document-types.js:

(const.DocumentTypes.create):

2:34 PM Changeset in webkit [205084] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Fix the !PLATFORM(WIN) && USE(CURL) build.
https://bugs.webkit.org/show_bug.cgi?id=161281

Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2016-08-27
Reviewed by Alex Christensen.

  • platform/network/curl/ResourceHandleCurl.cpp:
1:55 PM Changeset in webkit [205083] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

html/dom/interfaces.html is flaky due to WebSocket test
https://bugs.webkit.org/show_bug.cgi?id=161290

Unreviewed.

Patch by Youenn Fablet <youenn@apple.com> on 2016-08-27

  • platform/mac/TestExpectations: Making html/dom/interfaces.html expectation specific to Release.
1:47 PM Changeset in webkit [205082] by commit-queue@webkit.org
  • 8 edits in trunk

[Fetch API] Opaque responses should not have any body
https://bugs.webkit.org/show_bug.cgi?id=161130

Patch by Youenn Fablet <youenn@apple.com> on 2016-08-27
Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/cors/cors-basic.js:

(cors): Adding response body checking.

Source/WebCore:

Covered by updated test.

Added a new ThreadableLoader option to receive or not opaque response body.
By default, option is set to Receive.
FetchLoader is setting it to DoNotReceive.

  • Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::didReceiveResponse): Calling didFinishLoading just after didReceiveResponse in case of Opaque responses.

  • loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoaderOptions::ThreadableLoaderOptions):

  • loader/ThreadableLoader.h:
  • loader/WorkerThreadableLoader.cpp:

(WebCore::LoaderTaskOptions::LoaderTaskOptions):

11:43 AM Changeset in webkit [205081] by commit-queue@webkit.org
  • 6 edits in trunk

[Fetch API] opaqueredirect responses should have their URL set to the original URL
https://bugs.webkit.org/show_bug.cgi?id=161194

Patch by Youenn Fablet <youenn@apple.com> on 2016-08-27
Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/redirect/redirect-mode.html:
  • web-platform-tests/fetch/api/redirect/redirect-mode.js:

(redirectMode): Updating test to ease the computation of the absolute URL.

Source/WebCore:

Covered by updated tests.

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::didReceiveResponse):

  • loader/SubresourceLoader.cpp: Removing isNull ASSERT since we now set the response URL.

(WebCore::SubresourceLoader::willSendRequestInternal): Setting opaqueredirect response URL to the original URL.

11:07 AM Changeset in webkit [205080] by Simon Fraser
  • 7 edits in trunk

Add run-webkit-tests --print-expectations to show expectations for all or a subset of tests
https://bugs.webkit.org/show_bug.cgi?id=161217

Reviewed by Ryosuke Niwa.
Tools:

"run-webkit-tests --print-expectations" runs the same logic as running the tests, but
dumps out the lists of tests that would be run and skipped, and, for each, the entry
in TestExpectations that determines the expected outcome of the test.

This is an improved version of webkit-patch print-expectations.

See bug for sample output.

  • Scripts/webkitpy/layout_tests/controllers/manager.py:

(Manager._print_expectations_for_subset): Print out the list of tests and expected
outcome for some subset of tests.
(Manager.print_expectations): Do the same splitting by device class that running tests
does, and for each subset of tests, call _print_expectations_for_subset.

  • Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser.expectation_for_skipped_test): Set the flag
expectation_line.not_applicable_to_current_platform
(TestExpectationLine.init): Init not_applicable_to_current_platform to False
(TestExpectationLine.expected_behavior): line.expectation is PASS? by default,
even for skipped tests. This function returns a list relevant for display, taking the skipped
modifier into account.
(TestExpectationLine.create_passing_expectation): expectations is normally a list, not a set.
(TestExpectations.readable_filename_and_line_number): Return something printable for
lines with and without filenames

  • Scripts/webkitpy/layout_tests/run_webkit_tests.py:

(main): Handle options.print_expectations
(parse_args): Add support for --print-expectations
(_print_expectations):

  • Scripts/webkitpy/port/ios.py:

(IOSSimulatorPort.default_child_processes): Make this a debug log.

LayoutTests:

Explicitly skip fast/viewport

  • platform/mac/TestExpectations:
10:45 AM Changeset in webkit [205079] by akling@apple.com
  • 4 edits in trunk

script.text should behave like script.textContent on setting
<https://webkit.org/b/148852>

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/html/semantics/scripting-1/the-script-element/script-text-expected.txt:

Source/WebCore:

HTMLScriptElement.text should behave just like .textContent when setting,
so just forward setText() to setTextContent().

Test: import/w3c/web-platform-tests/html/semantics/scripting-1/the-script-element/script-text.html

  • html/HTMLScriptElement.cpp:

(WebCore::HTMLScriptElement::setText):

8:09 AM Changeset in webkit [205078] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

html/dom/interfaces.html is flaky due to WebSocket test
https://bugs.webkit.org/show_bug.cgi?id=161290

Unreviewed.

Patch by Youenn Fablet <youenn@apple.com> on 2016-08-27

  • platform/mac/TestExpectations: Marking html/dom/interfaces.html expectation from Skip to Pass|Failure.
7:31 AM Changeset in webkit [205077] by commit-queue@webkit.org
  • 94 edits
    1 move
    4 adds
    1 delete in trunk/LayoutTests

Sync web-platform-tests up to revision e827374
https://bugs.webkit.org/show_bug.cgi?id=161231

Patch by Youenn Fablet <youenn@apple.com> on 2016-08-27
Reviewed by Sam Weinig.

  • resources/ImportExpectations: Skipped some new test suites. Added 'url' test suite as Import.
  • resources/TestRepositories: Updated revision to e827374
  • resources/web-platform-tests-modules.json:
  • web-platform-tests/XMLHttpRequest/abort-during-upload-expected.txt:
  • web-platform-tests/XMLHttpRequest/abort-during-upload.htm:
  • web-platform-tests/XMLHttpRequest/abort-event-order.htm:
  • web-platform-tests/XMLHttpRequest/event-error-expected.txt:
  • web-platform-tests/XMLHttpRequest/event-error-order.sub-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/event-error-order.sub.html: Added.
  • web-platform-tests/XMLHttpRequest/event-error.html:
  • web-platform-tests/XMLHttpRequest/event-error.sub-expected.txt: Added.
  • web-platform-tests/XMLHttpRequest/event-error.sub.html: Copied from LayoutTests/imported/w3c/web-platform-tests/XMLHttpRequest/event-error.html.
  • web-platform-tests/XMLHttpRequest/event-progress.htm:
  • web-platform-tests/XMLHttpRequest/resources/trickle.py:

(main):

  • web-platform-tests/XMLHttpRequest/resources/w3c-import.log:
  • web-platform-tests/XMLHttpRequest/resources/xmlhttprequest-event-order.js: Added.

(global.prepare_xhr_for_event_order_test):
(global.assert_xhr_event_order_matches):

  • web-platform-tests/XMLHttpRequest/response-data-progress-expected.txt:
  • web-platform-tests/XMLHttpRequest/response-data-progress.htm:
  • web-platform-tests/XMLHttpRequest/response-method-expected.txt:
  • web-platform-tests/XMLHttpRequest/responsexml-document-properties-expected.txt:
  • web-platform-tests/XMLHttpRequest/security-consideration.sub.html:
  • web-platform-tests/XMLHttpRequest/send-entity-body-document-expected.txt:
  • web-platform-tests/XMLHttpRequest/send-no-response-event-order-expected.txt:
  • web-platform-tests/XMLHttpRequest/send-no-response-event-order.htm:
  • web-platform-tests/XMLHttpRequest/send-sync-response-event-order-expected.txt:
  • web-platform-tests/XMLHttpRequest/send-sync-response-event-order.htm:
  • web-platform-tests/XMLHttpRequest/w3c-import.log:
  • web-platform-tests/common/get-host-info.sub.js: Added.

(get_host_info):

  • web-platform-tests/common/w3c-import.log:
  • web-platform-tests/dom/interfaces-expected.txt:
  • web-platform-tests/dom/interfaces.html:
  • web-platform-tests/dom/nodes/attributes-expected.txt:
  • web-platform-tests/dom/nodes/attributes.html:
  • web-platform-tests/dom/traversal/TreeWalker-acceptNode-filter.html:
  • web-platform-tests/dom/traversal/TreeWalker-basic.html:
  • web-platform-tests/dom/traversal/TreeWalker-currentNode.html:
  • web-platform-tests/dom/traversal/TreeWalker-previousNodeLastChildReject.html:
  • web-platform-tests/dom/traversal/TreeWalker-previousSiblingLastChildSkip.html:
  • web-platform-tests/dom/traversal/TreeWalker-traversal-reject.html:
  • web-platform-tests/dom/traversal/TreeWalker-traversal-skip-most.html:
  • web-platform-tests/dom/traversal/TreeWalker-traversal-skip.html:
  • web-platform-tests/domparsing/w3c-import.log:
  • web-platform-tests/fetch/api/basic/scheme-about-expected.txt:
  • web-platform-tests/fetch/api/basic/scheme-about-worker-expected.txt:
  • web-platform-tests/fetch/api/basic/scheme-about.js:

(checkFetchResponse):
(checkKoUrl): Deleted.

  • web-platform-tests/fetch/api/basic/w3c-import.log:
  • web-platform-tests/fetch/api/cors/cors-cookies.js:

(corsCookies):

  • web-platform-tests/fetch/api/cors/cors-redirect.js:

(corsRedirect):

  • web-platform-tests/fetch/api/headers/headers-basic-expected.txt:
  • web-platform-tests/fetch/api/headers/headers-basic.html:
  • web-platform-tests/fetch/api/redirect/w3c-import.log:
  • web-platform-tests/fetch/api/request/request-cache-expected.txt:
  • web-platform-tests/html/browsers/history/the-location-interface/security_location_0.sub.htm:
  • web-platform-tests/html/browsers/the-window-object/security-window/window-security.sub.html:
  • web-platform-tests/html/browsers/windows/nested-browsing-contexts/frameElement.sub.html:
  • web-platform-tests/html/browsers/windows/targeting-cross-origin-nested-browsing-contexts.sub-expected.txt:
  • web-platform-tests/html/browsers/windows/targeting-cross-origin-nested-browsing-contexts.sub.html:
  • web-platform-tests/html/dom/elements-forms.js:
  • web-platform-tests/html/dom/elements-tabular.js:
  • web-platform-tests/html/dom/elements/global-attributes/dataset-expected.txt:
  • web-platform-tests/html/dom/elements/global-attributes/dataset.html:
  • web-platform-tests/html/dom/interfaces-expected.txt:
  • web-platform-tests/html/dom/interfaces.html:
  • web-platform-tests/html/dom/reflection-forms-expected.txt:
  • web-platform-tests/html/dom/reflection-tabular-expected.txt:
  • web-platform-tests/html/dom/reflection.js:

(ReflectionTests.typeMap.string_appeared_here.toString):
(ReflectionTests.typeMap.string_appeared_here.valueOf):
(ReflectionTests.typeMap.string_appeared_here.string_appeared_here):

  • web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_specified.sub.html:
  • web-platform-tests/html/semantics/document-metadata/the-link-element/document-without-browsing-context-expected.txt:
  • web-platform-tests/html/semantics/document-metadata/the-link-element/link-load-event.html:
  • web-platform-tests/html/semantics/document-metadata/the-link-element/link-style-error-01-expected.txt:
  • web-platform-tests/html/semantics/document-metadata/the-link-element/link-style-error-01.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.drawImage.canvas.sub-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.drawImage.canvas.sub.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.drawImage.image.sub-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.drawImage.image.sub.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.fillStyle.sub-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.fillStyle.sub.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.strokeStyle.sub-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.strokeStyle.sub.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.timing.sub-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.canvas.timing.sub.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.create.sub-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.create.sub.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.cross.sub-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.cross.sub.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.image.fillStyle.sub-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.image.fillStyle.sub.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.image.strokeStyle.sub-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.pattern.image.strokeStyle.sub.html:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.reset.sub-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/the-canvas-element/security.reset.sub.html:
  • web-platform-tests/html/semantics/embedded-content/the-img-element/environment-changes/viewport-change-expected.txt:
  • web-platform-tests/html/semantics/forms/constraints/form-validation-validity-tooShort.html:
  • web-platform-tests/html/semantics/interfaces-expected.txt:
  • web-platform-tests/html/semantics/interfaces.html:
  • web-platform-tests/html/semantics/interfaces.js:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/valid-invalid-expected.txt:
  • web-platform-tests/html/semantics/selectors/pseudo-classes/valid-invalid.html:
  • web-platform-tests/lint.whitelist:
  • web-platform-tests/url/w3c-import.log: Added.
3:40 AM Changeset in webkit [205076] by commit-queue@webkit.org
  • 13 edits in trunk

[Fetch API] Blob type should be set from Response/Request contentType header
https://bugs.webkit.org/show_bug.cgi?id=161228

Patch by Youenn Fablet <youenn@apple.com> on 2016-08-27
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/request/request-consume.html:
  • web-platform-tests/fetch/api/request/request-headers-expected.txt:
  • web-platform-tests/fetch/api/request/request-headers.html:
  • web-platform-tests/fetch/api/response/response-consume-expected.txt:
  • web-platform-tests/fetch/api/response/response-consume.html:
  • web-platform-tests/fetch/api/response/response-init-002-expected.txt:
  • web-platform-tests/fetch/api/response/response-init-002.html:

Source/WebCore:

Covered by updated tests.

Renaming FetchBody::m_mimeType to m_contentType since that better relates to Content-Type header.
Updated FetchRequest and FetchResponse to set m_contentType according request/response headers.
Handled the case of a Request created from JS, a Response created from JS and a Response created internally to
be used as resolve value in the fetch promise.

In case Content-Type is set but is empty, its empty value should be used for blob type.
Updated contentType checks to use isNull in lieu of isEmpty.

  • Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::updateContentType): Routine to synchronize headers with m_contentType.
(WebCore::FetchBody::FetchBody): Renamed m_mimeType to m_contentType.
(WebCore::FetchBody::blob): Ditto.

  • Modules/fetch/FetchBody.h: Ditto.

(WebCore::FetchBody::contentType):
(WebCore::FetchBody::setMimeType): Deleted.
(WebCore::FetchBody::mimeType): Deleted.

  • Modules/fetch/FetchRequest.cpp:

(WebCore::FetchRequest::setBody): set FetchBody::m_contentType according HTTP headers.

  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::initializeWith): Ditto.
(WebCore::FetchResponse::BodyLoader::didReceiveResponse): Ditto.

2:18 AM Changeset in webkit [205075] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebKit2

[GTK][Threaded Compositor] Several flaky tests
https://bugs.webkit.org/show_bug.cgi?id=161242

Reviewed by Michael Catanzaro.

We still have a lot of flaky tests since we switched to the threaded compositor. The UI process might
take the screenshot too early, before everything is actually painted. I can't reproduce the problem, so this is
actually a speculative fix or workaround. Our implementation of DrawingArea::dispatchAfterEnsuringDrawing() is
quite simple, we just dispatch the callback in the next run loop iteration, which doesn't really ensures any
drawing at all. So, we can wait for draw events before dispatching the given callback. Since we don't really
know if draw events were already processed before dispatchAfterEnsuringDrawing() is called, or if there will be
more than one damage event in a short time, this patch waits up to 1 second for draw events, and if a draw
happens it stops if there isn't another draw event in the next 100ms. This should ensure a drawing if it was
really needed.

  • UIProcess/DrawingAreaProxyImpl.cpp:

(WebKit::DrawingAreaProxyImpl::DrawingMonitor::DrawingMonitor):
(WebKit::DrawingAreaProxyImpl::DrawingMonitor::~DrawingMonitor):
(WebKit::DrawingAreaProxyImpl::DrawingMonitor::webViewDrawCallback):
(WebKit::DrawingAreaProxyImpl::DrawingMonitor::start):
(WebKit::DrawingAreaProxyImpl::DrawingMonitor::stop):
(WebKit::DrawingAreaProxyImpl::DrawingMonitor::didDraw):
(WebKit::DrawingAreaProxyImpl::dispatchAfterEnsuringDrawing):

  • UIProcess/DrawingAreaProxyImpl.h:

Aug 26, 2016:

10:47 PM Changeset in webkit [205074] by mitz@apple.com
  • 2 edits in trunk/Tools

Keep trying to fix the build after r205057.

  • MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
10:44 PM Changeset in webkit [205073] by mitz@apple.com
  • 6 edits in trunk/Tools

Keep trying to fix the build after r205057.

  • MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Don’t try to import nonexistent config.h. This file is only meant to be built with Xcode anyway.
  • MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Make this compile with Xcode 7.3 and deploy to iOS 9.0.
  • MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Ditto.
  • MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Don’t try to import config.h.
  • MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Ditto.
9:39 PM Changeset in webkit [205072] by mitz@apple.com
  • 2 edits in trunk/Tools

Start trying to fix the build after r205057.

  • MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj:
9:38 PM Changeset in webkit [205071] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.50.0.8

New tag.

8:48 PM Changeset in webkit [205070] by ap@apple.com
  • 2 edits in trunk/Tools

Remove Yosemite Leaks from the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=161253

Reviewed by Anders Carlsson.

  • TestResultServer/static-dashboards/builders.jsonp:
8:04 PM Changeset in webkit [205069] by achristensen@apple.com
  • 3 edits in trunk/Source/WebCore

Fix Windows build after r205065.

  • Modules/webaudio/BiquadFilterNode.idl:
  • Modules/webaudio/PannerNode.idl:

There's no WEB_AUDIO on Windows.

7:53 PM Changeset in webkit [205068] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

REGRESSION (r203535): Web Inspector: Inspector overlay node info has disappeared
https://bugs.webkit.org/show_bug.cgi?id=161264

Patch by Devin Rousso <Devin Rousso> on 2016-08-26
Reviewed by Joseph Pecoraro.

No new tests. Fixing JavaScript error in Inspector overlay.

  • inspector/InspectorOverlay.cpp:

(evaluateCommandInOverlay):
(WebCore::InspectorOverlay::evaluateInOverlay):
Add ASSERT to ensure that errors in the Inspector overlay will cause tests to crash.

  • inspector/InspectorOverlayPage.js:

(DOMBuilder.prototype.appendTextNode):
Move textContent value to parameter of document.createTextNode.

7:51 PM Changeset in webkit [205067] by Joseph Pecoraro
  • 2 edits in trunk/LayoutTests

Web Inspector: inspector/indexeddb/deleteDatabaseNamesWithSpace.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=161283

Reviewed by Alex Christensen.

  • inspector/indexeddb/deleteDatabaseNamesWithSpace.html:

Add a short timeout between deleting a database and requesting database names
to reduce flakey results.

7:39 PM Changeset in webkit [205066] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WTF

bitwise_cast uses inactive member of union
https://bugs.webkit.org/show_bug.cgi?id=161244

Patch by JF Bastien <jfbastien@apple.com> on 2016-08-26
Reviewed by Benjamin Poulain.

  • wtf/Compiler.h:

Add COMPILER_HAS_CLANG_FEATURE

  • wtf/StdLibExtras.h:

(WTF::bitwise_cast):
Fix C++ UB, add trivially-copyable check.

bitwise_cast stores into a union with one type and reads with
another, which is technically C++ undefined behavior because it's
accessing the wrong active member of the union. The better way to
do this is through memcpy, which compilers optimize as well
because it's known-size in known-not-to-escape storage (for small
types they'll inline and then convert stack memory access to SSA
values which may be in-register if that makes sense, which would
be a move between int/FP registers at worst).

The C++ Standard's section [basic.types] explicitly blesses memcpy:

For any trivially copyable type T, if two pointers to T point to
distinct T objects obj1 and obj2, where neither obj1 nor obj2 is a
base-class subobject, if the underlying bytes (1.7) making up obj1
are copied into obj2, 42 obj2 shall subsequently hold the same
value as obj1.

[Example:

T* t1p;
T* t2p;
provided that t2p points to an initialized object ...
std::memcpy(t1p, t2p, sizeof(T));
at this point, every subobject of trivially copyable type in *t1p contains
the same value as the corresponding subobject in *t2p

— end example ]

Whereas section [class.union] says:

In a union, at most one of the non-static data members can be
active at any time, that is, the value of at most one of the
non-static data members can be stored in a union at any time.

While we're at it, checking that sizeof(To) == sizeof(From) is
good, but we should also check that both types are trivially
copyable (can have a ctor, no dtor, and copy is defaulted as if by
memcpy for type and all subtypes). Unfortunately that trait isn't
implemented consistently in all recent compiler+stdlib
implementations, but recent clang has an equivalent builtin
(other compilers simply won't do the check, and will break on bots
with the right compilers which is better than the current silent
breakage). This builtin hack also avoids #include <type_traits>
which really doesn't save much.

7:01 PM Changeset in webkit [205065] by weinig@apple.com
  • 108 edits
    7 deletes in trunk

Remove support for ENABLE_LEGACY_WEB_AUDIO
https://bugs.webkit.org/show_bug.cgi?id=161262

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Remove ENABLE_LEGACY_WEB_AUDIO

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:

Remove ENABLE_LEGACY_WEB_AUDIO.

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::noteGrainOn): Deleted.

  • Modules/webaudio/AudioBufferSourceNode.h:
  • Modules/webaudio/AudioBufferSourceNode.idl:

(WebCore::AudioScheduledSourceNode::noteOn): Deleted.
(WebCore::AudioScheduledSourceNode::noteOff): Deleted.

  • Modules/webaudio/AudioScheduledSourceNode.h:
  • Modules/webaudio/AudioScheduledSourceNode.cpp:

Remove the looping attribute, as well as the noteOn, noteOff, and noteGrainOn functions.

  • Modules/webaudio/AudioContext.idl:

Remove the createGainNode, createDelayNode and createJavaScriptNode functions.

  • Modules/webaudio/AudioParam.idl:

Remove the setTargetValueAtTime function.

  • Modules/webaudio/BiquadDSPKernel.cpp:

(WebCore::BiquadDSPKernel::updateCoefficientsIfNecessary):

  • Modules/webaudio/BiquadFilterNode.cpp:

(WebCore::BiquadFilterNode::type):
(WebCore::BiquadFilterNode::setType):
(WebCore::BiquadFilterNode::getFrequencyResponse):

  • Modules/webaudio/BiquadFilterNode.h:
  • Modules/webaudio/BiquadFilterNode.idl:
  • Modules/webaudio/BiquadProcessor.cpp:

(WebCore::BiquadProcessor::BiquadProcessor):
(WebCore::BiquadProcessor::setType):
(WebCore::BiquadProcessor::getFrequencyResponse):

  • Modules/webaudio/BiquadProcessor.h:

(WebCore::BiquadProcessor::type):

  • bindings/js/JSBiquadFilterNodeCustom.cpp: Removed.

Rename BiquadProcessor::FilterType to BiquadFilterType and use it
directly from the IDL. Remove legacy filter constants from the IDL
and the need for a custom binding for the type attribute.

  • Modules/webaudio/OscillatorNode.cpp:

(WebCore::OscillatorNode::OscillatorNode):
(WebCore::OscillatorNode::setType):
(WebCore::OscillatorNode::setPeriodicWave):
(WebCore::OscillatorNode::type): Deleted.

  • Modules/webaudio/OscillatorNode.h:

(WebCore::OscillatorNode::type):

  • Modules/webaudio/OscillatorNode.idl:
  • Modules/webaudio/PeriodicWave.cpp:

(WebCore::PeriodicWave::createSine):
(WebCore::PeriodicWave::createSquare):
(WebCore::PeriodicWave::createSawtooth):
(WebCore::PeriodicWave::createTriangle):
(WebCore::PeriodicWave::generateBasicWaveform):

  • Modules/webaudio/PeriodicWave.h:
  • bindings/js/JSOscillatorNodeCustom.cpp: Removed.

Remove noteOn and noteOff functions and the type integer constants.
Remove the need for a custom binding for the type attribute by renaming
the type enum OscillatorNode::Type and putting the enum in the IDL.

  • Modules/webaudio/PannerNode.cpp:

(WebCore::PannerNode::PannerNode):
(WebCore::PannerNode::process):
(WebCore::PannerNode::setPanningModel):
(WebCore::PannerNode::distanceModel):
(WebCore::PannerNode::setDistanceModel):
(WebCore::PannerNode::panningModel): Deleted.

  • Modules/webaudio/PannerNode.h:

(WebCore::PannerNode::panningModel):

  • Modules/webaudio/PannerNode.idl:
  • bindings/js/JSPannerNodeCustom.cpp: Removed.
  • platform/audio/Distance.cpp:

(WebCore::DistanceEffect::DistanceEffect):
(WebCore::DistanceEffect::gain):

  • platform/audio/Distance.h:

(WebCore::DistanceEffect::model):
(WebCore::DistanceEffect::setModel):

  • platform/audio/EqualPowerPanner.cpp:

(WebCore::EqualPowerPanner::EqualPowerPanner):

  • platform/audio/HRTFPanner.cpp:

(WebCore::HRTFPanner::HRTFPanner):

  • platform/audio/Panner.cpp:

(WebCore::Panner::create):

  • platform/audio/Panner.h:

(WebCore::Panner::panningModel):
(WebCore::Panner::Panner):
Replace the panning model and distance model integer constants
with IDL enum support, removing the need for a custom binding.
Rename the supporting C++ enums to work with the bindings.

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::constructJSAudioContext):
Remove deprecated way of creating an offline context.

  • WebCore.xcodeproj/project.pbxproj:

Update files.

Source/WebKit/mac:

  • Configurations/FeatureDefines.xcconfig:

Remove ENABLE_LEGACY_WEB_AUDIO

Source/WebKit2:

  • Configurations/FeatureDefines.xcconfig:

Remove ENABLE_LEGACY_WEB_AUDIO.

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

  • webaudio/audiobuffersource-loop-points.html:
  • webaudio/audiobuffersource-multi-channels.html:
  • webaudio/audiobuffersource-playbackState-expected.txt:
  • webaudio/audiobuffersource-playbackState.html:
  • webaudio/audiobuffersource-playbackrate.html:
  • webaudio/audiochannelmerger-stereo.html:
  • webaudio/audiochannelsplitter.html:
  • webaudio/audionode-connect-order.html:
  • webaudio/audionode-expected.txt:
  • webaudio/audionode.html:
  • webaudio/audioparam-connect-audioratesignal.html:
  • webaudio/audioparam-summingjunction.html:
  • webaudio/audioprocessingevent.html:
  • webaudio/automatic-pull-node.html:
  • webaudio/biquad-allpass.html:
  • webaudio/biquad-bandpass.html:
  • webaudio/biquad-getFrequencyResponse.html:
  • webaudio/biquad-highpass.html:
  • webaudio/biquad-highshelf.html:
  • webaudio/biquad-lowpass.html:
  • webaudio/biquad-lowshelf.html:
  • webaudio/biquad-notch.html:
  • webaudio/biquad-peaking.html:
  • webaudio/biquadfilternode-basic-expected.txt:
  • webaudio/biquadfilternode-basic.html:
  • webaudio/convolution-mono-mono.html:
  • webaudio/delaynode-max-default-delay.html:
  • webaudio/delaynode-max-nondefault-delay.html:
  • webaudio/delaynode-maxdelay.html:
  • webaudio/delaynode-scheduling.html:
  • webaudio/delaynode.html:
  • webaudio/distance-exponential-expected.txt:
  • webaudio/distance-exponential.html:
  • webaudio/distance-inverse-expected.txt:
  • webaudio/distance-inverse.html:
  • webaudio/distance-linear-expected.txt:
  • webaudio/distance-linear.html:
  • webaudio/gain-basic.html:
  • webaudio/gain.html:
  • webaudio/javascriptaudionode-zero-input-channels.html:
  • webaudio/javascriptaudionode.html:
  • webaudio/mixing.html:
  • webaudio/note-grain-on-play-expected.txt: Removed.
  • webaudio/note-grain-on-play.html: Removed.
  • webaudio/note-grain-on-timing-expected.txt: Removed.
  • webaudio/note-grain-on-timing.html: Removed.
  • webaudio/oscillator-basic-expected.txt:
  • webaudio/oscillator-basic.html:
  • webaudio/oscillator-custom.html:
  • webaudio/oscillator-sawtooth.html:
  • webaudio/oscillator-sine.html:
  • webaudio/oscillator-square.html:
  • webaudio/oscillator-triangle.html:
  • webaudio/pannernode-basic-expected.txt:
  • webaudio/pannernode-basic.html:
  • webaudio/resources/audio-testing.js:
  • webaudio/resources/audioparam-testing.js:
  • webaudio/resources/biquad-testing.js:
  • webaudio/resources/distance-model-testing.js:
  • webaudio/resources/javascriptaudionode-testing.js:
  • webaudio/resources/oscillator-testing.js:
  • webaudio/resources/panner-model-testing.js:
  • webaudio/sample-accurate-scheduling.html:
  • webaudio/stereo2mono-down-mixing.html:
  • webaudio/up-mixing-mono-51.html:
  • webaudio/up-mixing-mono-stereo.html:
  • webaudio/up-mixing-stereo-51.html:
  • webaudio/waveshaper.html:

Update tests for removal of ENABLE_LEGACY_WEB_AUDIO.

5:36 PM Changeset in webkit [205064] by benjamin@webkit.org
  • 4 edits
    1 add in trunk

[JSC] Implement CompareStrictEq(String, Untyped) in FTL
https://bugs.webkit.org/show_bug.cgi?id=161229

Reviewed by Geoffrey Garen.

JSTests:

  • stress/compare-strict-eq-on-various-types.js: Added.

Source/JavaScriptCore:

Add (String, Untyped) uses to FTL CompareStrictEq.
This was the last use type not implemented, the node is fully
supported by FTL after this patch.

  • ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCompareStrictEq):
(JSC::FTL::DFG::LowerDFGToB3::compileStringToUntypedStrictEquality):

(JSC::FTL::DFG::LowerDFGToB3::nonSpeculativeCompare):
Remove the type checks when possible.

5:33 PM Changeset in webkit [205063] by bshafiei@apple.com
  • 5 edits in branches/safari-602.1.50.0-branch/Source

Versioning.

5:30 PM Changeset in webkit [205062] by commit-queue@webkit.org
  • 8 edits in trunk/Source

Web Inspector: Frontend should have access to Resource Timing information
https://bugs.webkit.org/show_bug.cgi?id=160095

Patch by Johan K. Jensen <johan_jensen@apple.com> on 2016-08-26
Reviewed by Alex Christensen.

Source/JavaScriptCore:

Rename ResourceTiming property.

  • inspector/protocol/Network.json:

Rename navigationStart to startTime so it's applicable
for all resources and not just the main resource.

Source/WebCore:

Show correct information with Resource Timing information
from ResourceLoader rather than DocumentLoader.

No new tests, frontend doesn't use the timing data yet.

  • inspector/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::buildObjectForTiming):
(WebCore::InspectorNetworkAgent::buildObjectForResourceResponse):
(WebCore::InspectorNetworkAgent::buildObjectForCachedResource):
(WebCore::InspectorNetworkAgent::willSendRequest):
(WebCore::InspectorNetworkAgent::didReceiveResponse):
(WebCore::InspectorNetworkAgent::didLoadResourceFromMemoryCache):
(WebCore::buildObjectForTiming): Deleted.
(WebCore::buildObjectForResourceResponse): Deleted.
(WebCore::buildObjectForCachedResource): Deleted.
Use ResourceLoader instead of DocumentLoader to get Resource Timing information.
Move functions to member functions to access the executionStopWatch.

(WebCore::InspectorNetworkAgent::didFinishLoading):
Use the load timing finishTime and convert to elapsed time for frontend.

  • inspector/InspectorNetworkAgent.h:
  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didFinishLoading):
Pass the web process load timing on to the inspector.

Source/WTF:

Add method to get elapsed time for any monotonic time.
Used by InspectorNetworkAgent.

  • wtf/Stopwatch.h:

(WTF::Stopwatch::elapsedTimeSinceMonotonicTime):

5:13 PM Changeset in webkit [205061] by Chris Dumez
  • 4 edits in trunk/Source/WebCore

Unreviewed, fix Windows build after r205048.

  • bindings/scripts/CodeGeneratorJS.pm:

(getConditionalForFunctionConsideringOverloads):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionSingleConditionalOverload1):
(WebCore::jsTestObjPrototypeFunctionSingleConditionalOverload2):
(WebCore::jsTestObjPrototypeFunctionSingleConditionalOverload):

  • bindings/scripts/test/TestObj.idl:
5:04 PM Changeset in webkit [205060] by rniwa@webkit.org
  • 15 edits
    3 adds in trunk

Adopted custom element's callbacks should continue to work
https://bugs.webkit.org/show_bug.cgi?id=161065

Reviewed by Andreas Kling.

Source/WebCore:

When a custom element is adopted into another document, its reaction callbacks need to continue to work.
Because a different document may have its own global object, each custom element needs to remember its
original global object or JSCustomElementInterface. This patch adds the latter to the element rare data.

Tests: fast/custom-elements/connected-callbacks.html

fast/custom-elements/disconnected-callbacks.html

  • bindings/js/JSCustomElementInterface.cpp:

(WebCore::JSCustomElementInterface::constructElement):
(WebCore::JSCustomElementInterface::upgradeElement):

  • dom/CustomElementReactionQueue.cpp:

(WebCore::findInterfaceForCustomElement): Deleted.
(WebCore::CustomElementReactionQueue::enqueueConnectedCallbackIfNeeded):
(WebCore::CustomElementReactionQueue::enqueueDisconnectedCallbackIfNeeded):
(WebCore::CustomElementReactionQueue::enqueueAttributeChangedCallbackIfNeeded):

  • dom/Element.cpp:

(WebCore::Element::insertedInto): Invoke callbacks even when the current document is not a HTML document.
(WebCore::Element::removedFrom): Ditto.
(WebCore::Element::setCustomElementIsResolved): Moved from Node. Add the element interface to the rare data.
(WebCore::Element::customElementInterface): Added.

  • dom/Element.h:
  • dom/ElementRareData.cpp:
  • dom/ElementRareData.h:

(WebCore::ElementRareData::customElementInterface): Added.
(WebCore::ElementRareData::setCustomElementInterface): Added.

  • dom/Node.h:

((WebCore::Node::setCustomElementIsResolved): Deleted.

LayoutTests:

Added test cases for adopting custom elements into various kinds of documents.

  • fast/custom-elements/connected-callbacks-expected.txt:
  • fast/custom-elements/connected-callbacks.html:
  • fast/custom-elements/defined-pseudo-class-expected.txt:
  • fast/custom-elements/defined-pseudo-class.html:
  • fast/custom-elements/disconnected-callbacks-expected.txt:
  • fast/custom-elements/disconnected-callbacks.html:
  • fast/custom-elements/resources/document-types.js: Added.
  • fast/custom-elements/resources/empty-html-document.html: Added.
4:47 PM Changeset in webkit [205059] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking webgl/max-active-contexts-webglcontextlost-prevent-default.html as flaky on mac-wk1.
https://bugs.webkit.org/show_bug.cgi?id=161205

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
4:43 PM Changeset in webkit [205058] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking http/tests/media/hls/hls-accessiblity-describes-video-menu.html as flaky on mac-wk1.
https://bugs.webkit.org/show_bug.cgi?id=161144

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
4:28 PM Changeset in webkit [205057] by jer.noble@apple.com
  • 4 edits
    26 adds in trunk

Add a test harness for running UI tests on the iOS Simulator
https://bugs.webkit.org/show_bug.cgi?id=161265

.:

Add the new MobileMiniBrowser project to the WebKit workspace.

Reviewed by Simon Fraser.

  • WebKit.xcworkspace/contents.xcworkspacedata:

Tools:

Reviewed by Simon Fraser.

Add a new iOS Simulator application which uses WKWebView to implement a basic browser, and which
can serve as a test harness for WebKit UI tests.

Also add a basic media playback test which verifies that a <video> element will begin playing in
fullscreen on an iPhone device, but will play inline on an iPad device.

  • Makefile: Add MobileMiniBrowser as a Module for iOS builds.
  • MobileMiniBrowser/Configurations/Base.xcconfig: Added.
  • MobileMiniBrowser/Configurations/DebugRelease.xcconfig: Added.
  • MobileMiniBrowser/Configurations/MobileMiniBrowser.xcconfig: Added.
  • MobileMiniBrowser/Makefile: Added.
  • MobileMiniBrowser/MobileMiniBrowser.xcodeproj/project.pbxproj: Added.
  • MobileMiniBrowser/MobileMiniBrowser/AppDelegate.h: Added.
  • MobileMiniBrowser/MobileMiniBrowser/AppDelegate.m: Added.

(-[AppDelegate application:didFinishLaunchingWithOptions:]):
(-[AppDelegate applicationWillResignActive:]):
(-[AppDelegate applicationDidEnterBackground:]):
(-[AppDelegate applicationWillEnterForeground:]):
(-[AppDelegate applicationDidBecomeActive:]):
(-[AppDelegate applicationWillTerminate:]):

  • MobileMiniBrowser/MobileMiniBrowser/Assets.xcassets/AppIcon.appiconset/Contents.json: Added.
  • MobileMiniBrowser/MobileMiniBrowser/Base.lproj/LaunchScreen.storyboard: Added.
  • MobileMiniBrowser/MobileMiniBrowser/Base.lproj/Main.storyboard: Added.
  • MobileMiniBrowser/MobileMiniBrowser/Info.plist: Added.
  • MobileMiniBrowser/MobileMiniBrowser/TabViewController.h: Added.
  • MobileMiniBrowser/MobileMiniBrowser/TabViewController.m: Added.

(-[TabViewController dealloc]):
(-[TabViewController viewDidLoad]):
(-[TabViewController observeValueForKeyPath:ofObject:change:context:]):
(-[TabViewController tableView:cellForRowAtIndexPath:]):
(-[TabViewController tableView:numberOfRowsInSection:]):
(-[TabViewController numberOfSectionsInTableView:]):
(-[TabViewController tableView:canEditRowAtIndexPath:]):
(-[TabViewController tableView:canMoveRowAtIndexPath:]):
(-[TabViewController tableView:commitEditingStyle:forRowAtIndexPath:]):
(-[TabViewController tableView:didSelectRowAtIndexPath:]):

  • MobileMiniBrowser/MobileMiniBrowser/WebViewController.h: Added.
  • MobileMiniBrowser/MobileMiniBrowser/WebViewController.m: Added.

(-[WebViewController viewDidLoad]):
(-[WebViewController didReceiveMemoryWarning]):
(-[WebViewController reload:]):
(-[WebViewController goBack:]):
(-[WebViewController goForward:]):
(-[WebViewController urlFieldEditingBegan:]):
(-[WebViewController navigateTo:]):
(-[WebViewController showTabs:]):
(-[WebViewController selectWebViewAtIndex:]):
(-[WebViewController removeWebViewAtIndex:]):
(-[WebViewController addWebView]):
(-[WebViewController createWebView]):
(-[WebViewController removeWebView:]):
(-[WebViewController setCurrentWebView:]):
(-[WebViewController webView:didFailNavigation:withError:]):
(-[WebViewController observeValueForKeyPath:ofObject:change:context:]):

  • MobileMiniBrowser/MobileMiniBrowser/main.m: Added.

(main):

  • MobileMiniBrowser/MobileMiniBrowserUITests/Info.plist: Added.
  • MobileMiniBrowser/MobileMiniBrowserUITests/MobileMiniBrowserUITests.m: Added.

(-[MobileMiniBrowserUITests setUp]):
(-[MobileMiniBrowserUITests tearDown]):
(-[MobileMiniBrowserUITests testBasicVideoPlayback]):

4:25 PM Changeset in webkit [205056] by Alan Bujtas
  • 3 edits
    2 adds in trunk

ASSERT_NOT_REACHED() is touched in WebCore::minimumValueForLength
https://bugs.webkit.org/show_bug.cgi?id=125781
<rdar://problem/27684457>

Reviewed by Simon Fraser.

Source/WebCore:

RenderTableSection::calcRowLogicalHeight misused minimumValueForLength to fallback to 0 for non-fixed values.
While this patch fixes the assertion, the table section code needs works to support calc values. See webkit.org/b/161273.

Test: fast/table/assert-on-min-max-content-values.html

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):

LayoutTests:

  • fast/table/assert-on-min-max-content-values-expected.txt: Added.
  • fast/table/assert-on-min-max-content-values.html: Added.
4:10 PM Changeset in webkit [205055] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Rebaseline fast/dom/focus-contenteditable.html for ios-simulator after r205044.

Unreviewed test gardening.

  • platform/ios-simulator-wk2/fast/dom/focus-contenteditable-expected.txt:
3:52 PM Changeset in webkit [205054] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

webkit-queues queue-status page should should list more recent statuses
https://bugs.webkit.org/show_bug.cgi?id=161220

Reviewed by Daniel Bates.

  • QueueStatusServer/handlers/queuestatus.py:

(QueueStatus._fetch_statuses): Increase the number of recent statuses from 15 to 50.

3:41 PM Changeset in webkit [205053] by akling@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r204987): fast/canvas-composite-* tests are now flaky assertion failures
<https://webkit.org/b/161259>

Reviewed by Joseph Pecoraro.

Fix a blunder where HTMLCanvasElement::memoryCost() wasn't forwarding the inquiry
to ImageBuffer but HTMLCanvasElement::externalMemoryCost() was.

This fixes flaky "externalMemorySize() <= extraMemorySize()" assertions on debug bots.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::memoryCost):

3:16 PM Changeset in webkit [205052] by andersca@apple.com
  • 3 edits in trunk/Source/WebKit2

Get rid of NetworkResourceLoader::sendAbortingOnFailure
https://bugs.webkit.org/show_bug.cgi?id=161267

Reviewed by Dan Bernstein.

NetworkResourceLoader::sendAbortingOnFailure sends an IPC message, and if IPC::Connection::send returns false,
it will abort the network resource load.

IPC::Connection::send will only return false if the connection is invalid, and when it becomes invalidated the
connection client member function "didClose" is invoked. For the network process, this will call abort on all outstanding
network loads.

Auditing all the sendAbortingOnFailure call sites, shows that none of them can be called with an invalid connection,
so replace sendAbortingOnFailure with send.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didReceiveResponse):
This is a NetworkLoadClient function which won't be called if the load has been aborted.

(WebKit::NetworkResourceLoader::didReceiveBuffer):
Ditto.

(WebKit::NetworkResourceLoader::didFinishLoading):
Ditto. Also, update a call to sendBufferMaybeAborting to sendBuffer.

(WebKit::NetworkResourceLoader::willSendRedirectedRequest):
This is another NetworkLoadClient function.

(WebKit::NetworkResourceLoader::bufferingTimerFired):
The buffering timer is stopped when abort() is called.

(WebKit::NetworkResourceLoader::sendBuffer):
Rename this from sendBufferMaybeAborting. It has three call sites:

  • didReceiveBuffer and didFinishLoading are both NetworkLoadClient functions.
  • didRetrieveCacheEntry is called from didFinishLoading (a NetworkLoadClient function) and from the completion function of retrieveCacheEntry, which has an early return for when the loader has been aborted.

(WebKit::NetworkResourceLoader::didRetrieveCacheEntry):
This is called from the retrieveCacheEntry completion function, which has an early return for when the loader has been aborted.

(WebKit::NetworkResourceLoader::dispatchWillSendRequestForCacheEntry):
Ditto.

(WebKit::NetworkResourceLoader::sendAbortingOnFailure): Deleted.

  • NetworkProcess/NetworkResourceLoader.h:
3:07 PM Changeset in webkit [205051] by jiewen_tan@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, update expectations of tests that can either crash or timeout on iOS simulator WK1

  • platform/ios-simulator-wk1/TestExpectations:
2:46 PM Changeset in webkit [205050] by akling@apple.com
  • 9 edits in trunk

The :enabled/:disabled selectors should only match elements that can be disabled.
<https://webkit.org/b/161255>

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/html/semantics/selectors/pseudo-classes/disabled-expected.txt:

Source/WebCore:

Per the HTML spec, only the following elements can be actually disabled:

button, input, select, textarea, optgroup, option, menuitem, fieldset

Since HTMLOutputElement inherits from HTMLFormControlElement, it had some
misguided ideas about being disableable. This was causing it to get matched
by :enabled and :disabled selectors.

Test: imported/w3c/web-platform-tests/html/semantics/selectors/pseudo-classes/disabled.html

  • css/SelectorChecker.cpp:

(WebCore::SelectorChecker::checkOne):

  • cssjit/SelectorCompiler.cpp:

(WebCore::SelectorCompiler::addPseudoClassType):

  • css/SelectorCheckerTestFunctions.h:

(WebCore::matchesDisabledPseudoClass):
(WebCore::matchesEnabledPseudoClass): Renamed from isEnabled/isDisabled. Now only allows
:enabled and :disabled selectors to match elements that are actually disableable.

  • html/HTMLElement.h:
  • html/HTMLElement.cpp:

(WebCore::HTMLElement::canBeActuallyDisabled):
(WebCore::HTMLElement::isActuallyDisabled): Added supporting functions for the aforementioned selectors.

  • html/HTMLFormControlElement.cpp:

(WebCore::HTMLFormControlElement::parseAttribute): Don't care about disabled state
changes in elements that are not disableable in the first place.

2:41 PM Changeset in webkit [205049] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skipping imported/w3c/web-platform-tests/html/dom/interfaces.html on Mac.
https://bugs.webkit.org/show_bug.cgi?id=161142

Unreviewed test gardening.

  • platform/mac/TestExpectations:
2:34 PM Changeset in webkit [205048] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

REGRESSION(r204028): Fix unused-but-set-variable warning in generated JSNavigator.cpp
https://bugs.webkit.org/show_bug.cgi?id=161252

Reviewed by Ryosuke Niwa.

Improve support for [Conditional] with overloaded operations in the IDL.

No new tests, updated bindings tests.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateHeader):
(GeneratePropertiesHashTable):
(getConditionalForFunctionConsideringOverloads):
(GenerateOverloadedFunctionOrConstructor):
(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestGlobalObject.cpp:

(WebCore::jsTestGlobalObjectInstanceFunctionEnabledAtRuntimeOperation): Deleted.

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjPrototypeFunctionConditionalOverload1):
(WebCore::jsTestObjPrototypeFunctionConditionalOverload2):
(WebCore::jsTestObjPrototypeFunctionConditionalOverload):
(WebCore::jsTestObjPrototypeFunctionEnabledAtRuntimeOperation): Deleted.
(WebCore::jsTestObjConstructorFunctionOverloadedMethod1): Deleted.

  • bindings/scripts/test/TestObj.idl:
2:23 PM Changeset in webkit [205047] by jiewen_tan@apple.com
  • 5 edits
    3 adds in trunk/LayoutTests

Unreviewed, rebase iOS simulator WK1 tables tests

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk1/tables/mozilla/bugs/bug30559-expected.txt:
  • platform/ios-simulator-wk1/tables/mozilla_expected_failures/bugs/bug128876-expected.txt:
  • platform/ios-simulator-wk1/tables/mozilla_expected_failures/bugs/bug3517-expected.txt: Added.
  • platform/ios-simulator-wk1/tables/mozilla_expected_failures/bugs/bug8499-expected.txt:
  • platform/ios-simulator-wk1/transitions/default-timing-function-expected.txt: Added.
2:20 PM Changeset in webkit [205046] by Joseph Pecoraro
  • 6 edits
    1 copy
    2 adds in trunk/Source/WebInspectorUI

Web Inspector: Add protocol version for iOS 10
https://bugs.webkit.org/show_bug.cgi?id=161266
<rdar://problem/28036594>

Rubber-stamped by Brian Burg.

  • Localizations/en.lproj/localizedStrings.js:

Update missing localized strings.

  • Versions/Inspector-iOS-10.0.json: Added.

Protocol for iOS 10.

  • UserInterface/Protocol/Legacy/10.0/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/7.0/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/8.0/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/9.0/InspectorBackendCommands.js:
  • UserInterface/Protocol/Legacy/9.3/InspectorBackendCommands.js:

Re-generate the legacy backend commands files.

2:14 PM Changeset in webkit [205045] by ggaren@apple.com
  • 2 edits in trunk/Source/bmalloc

2016-08-26 Geoffrey Garen <ggaren@apple.com>

Unreviewed build fix.

Fix the CMake build.

  • CMakeLists.txt:
2:11 PM Changeset in webkit [205044] by Beth Dakin
  • 4 edits
    2 adds in trunk

charactersAroundPosition can be wrong because it crosses editing boundaries
https://bugs.webkit.org/show_bug.cgi?id=161215
-and corresponding-
rdar://problem/27933564

Reviewed by Ryosuke Niwa.

Source/WebCore:

charactersAroundPosition() should not cross editing boundaries. This patch fixes
that by making nextCharacterBoundaryInDirection() take an
EditingBoundaryCrossingRule parameter to pass onto VisiblePosition::next() and
VisiblePosition::previous().

  • editing/VisibleUnits.cpp:

(WebCore::nextCharacterBoundaryInDirection):
(WebCore::positionOfNextBoundaryOfGranularity):
(WebCore::charactersAroundPosition):

LayoutTests:

New test.

  • editing/mac/spelling/accept-candidate-without-crossing-editing-boundary-expected.txt: Added.
  • editing/mac/spelling/accept-candidate-without-crossing-editing-boundary.html: Added.

This test is going back to its pre-https://trac.webkit.org/changeset/195078 state.
That change caused this test to have a different layout because it caused more
layouts to happen. Now that we don’t allow the call to charactersAroundPosition()
to cross editing boundaries, those layouts don’t happen, and we have the old
behavior back.

  • platform/mac/fast/dom/focus-contenteditable-expected.txt:
1:59 PM Changeset in webkit [205043] by Joseph Pecoraro
  • 5 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: Show IndexedDB Database/ObjectStore/Index data in a details sidebar
https://bugs.webkit.org/show_bug.cgi?id=161180
<rdar://problem/28003417>

Reviewed by Brian Burg.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Main.html:

New strings and file.

  • UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
Instantiate the global details sidebar.

  • UserInterface/Views/StorageTabContentView.js:

(WebInspector.StorageTabContentView):
Include the new details sidebar in the Storage tab.

  • UserInterface/Controllers/StorageManager.js:

(WebInspector.StorageManager.prototype._addIndexedDBDatabasesIfNeeded.processKeyPath):
Use the protocol generated types.

  • UserInterface/Views/IndexedDatabaseDetailsSidebarPanel.js: Added.

(WebInspector.IndexedDatabaseDetailsSidebarPanel):
(WebInspector.IndexedDatabaseDetailsSidebarPanel.prototype.inspect):
(WebInspector.IndexedDatabaseDetailsSidebarPanel.prototype.layout):
(WebInspector.IndexedDatabaseDetailsSidebarPanel.prototype._keyPathString):
Show the sidebar for an IndexedDatabase, ObjectStore, or Index.
Show each section if we can based on the objects we have.

1:59 PM Changeset in webkit [205042] by Joseph Pecoraro
  • 3 edits
    2 adds in trunk

Web Inspector: Test and address issues in IndexedDB.requestData
https://bugs.webkit.org/show_bug.cgi?id=161178
<rdar://problem/28002467>

Reviewed by Brian Burg.

Source/WebCore:

Test: inspector/indexeddb/requestData.html

  • inspector/InspectorIndexedDBAgent.cpp:

(idbKeyRangeFromKeyRange):
Parsing was too strict. "lower" and "upper" keys are optional.

(WebCore::DataLoader::execute):
Ensure the skip count is passed forward.

LayoutTests:

  • inspector/indexeddb/requestData-expected.txt: Added.
  • inspector/indexeddb/requestData.html: Added.
1:59 PM Changeset in webkit [205041] by Joseph Pecoraro
  • 9 edits
    2 adds in trunk

Web Inspector: Provide a way to clear an IndexedDB object store
https://bugs.webkit.org/show_bug.cgi?id=161167
<rdar://problem/27996932>

Reviewed by Brian Burg.

Source/JavaScriptCore:

  • inspector/protocol/IndexedDB.json:

Cleanup the protocol file.

Source/WebCore:

Test: inspector/indexeddb/clearObjectStore.html

  • inspector/InspectorIndexedDBAgent.cpp:

Make the transaction for clearing an object store readwrite
instead of readonly, and activate it.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:

"Clear object store".

  • UserInterface/Controllers/StorageManager.js:

(WebInspector.StorageManager.prototype.clearObjectStore):
Provide a wrapper for clearing an object store.

  • UserInterface/Views/IndexedDatabaseObjectStoreContentView.js:

(WebInspector.IndexedDatabaseObjectStoreContentView):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype.get navigationItems):
(WebInspector.IndexedDatabaseObjectStoreContentView.prototype._clearButtonClicked):
Add a navigation button on ObjectStore content views to clear the object store.

LayoutTests:

  • inspector/indexeddb/clearObjectStore-expected.txt: Added.
  • inspector/indexeddb/clearObjectStore.html: Added.
1:59 PM Changeset in webkit [205040] by Joseph Pecoraro
  • 3 edits
    4 adds in trunk/LayoutTests

Web Inspector: Test IndexedDB.requestDatabase
https://bugs.webkit.org/show_bug.cgi?id=161122

Reviewed by Brian Burg.

  • inspector/indexeddb/requestDatabase-expected.txt: Added.
  • inspector/indexeddb/requestDatabase.html: Added.

New tests.

  • inspector/indexeddb/deleteDatabaseNamesWithSpace.html:
  • inspector/indexeddb/requestDatabaseNames.html:

Share code.

  • inspector/indexeddb/resources/utilities.js: Added.

(deleteDatabaseNames):
(createEmptyDatabase):
(createDatabaseWithStores):
Helpers that can be used by each test.

1:59 PM Changeset in webkit [205039] by Joseph Pecoraro
  • 5 edits in trunk/LayoutTests

Web Inspector: Modernize inspector/indexeddb tests
https://bugs.webkit.org/show_bug.cgi?id=161113

Reviewed by Brian Burg.

  • inspector/indexeddb/deleteDatabaseNamesWithSpace-expected.txt:
  • inspector/indexeddb/deleteDatabaseNamesWithSpace.html:
  • inspector/indexeddb/requestDatabaseNames-expected.txt:
  • inspector/indexeddb/requestDatabaseNames.html:
1:54 PM Changeset in webkit [205038] by jiewen_tan@apple.com
  • 5 edits
    21 adds in trunk/LayoutTests

Unreviewed, rebase iOS simulator WK1 http tests

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk1/animations/trigger-container-scroll-simple-expected.txt: Added.
  • platform/ios-simulator-wk1/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
  • platform/ios-simulator-wk1/http/tests/dom/window-open-about-blank-and-access-document-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/dom/window-open-about-uppercase-blank-and-access-document-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/dom/window-open-about-webkit-org-and-access-document-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/security/contentSecurityPolicy/upgrade-insecure-requests/proper-open-window-upgrades-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/security/cross-origin-modal-dialog-base-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/security/insecure-geolocation-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/security/mixedContent/insecure-form-in-main-frame-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/security/mixedContent/insecure-script-in-data-iframe-in-main-frame-blocked-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/security/mixedContent/insecure-xhr-sync-in-main-frame-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/security/mixedcontent-geolocation-block-insecure-content-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/security/mixedcontent-geolocation-expected.txt: Added.
  • platform/ios-simulator-wk1/http/tests/security/window-opened-from-sandboxed-iframe-should-inherit-sandbox-expected.txt: Added.
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/TestExpectations:
1:35 PM Changeset in webkit [205037] by Chris Dumez
  • 7 edits in trunk

Calling crossOriginWindow.toString() should not be allowed
https://bugs.webkit.org/show_bug.cgi?id=161225

Reviewed by Andreas Kling.

Source/WebCore:

Calling crossOriginWindow.toString() should not be allowed:

In WebKit, we were printing a security error in the console but
returning "[object Window]" anyway.

In Firefox and Chrome, it throws an exception.

No new tests, updated existing test.

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess):

LayoutTests:

Update existing tests to reflect the behavior change.

  • http/tests/security/cross-frame-access-custom-expected.txt:
  • http/tests/security/cross-frame-access-custom.html:
  • http/tests/security/cross-frame-access-object-setPrototypeOf-expected.txt:
  • http/tests/security/cross-frame-access-object-setPrototypeOf.html:
1:33 PM Changeset in webkit [205036] by mitz@apple.com
  • 4 edits in trunk

[Cocoa] Infinite recursion calling -charValue on a WKNSNumber
https://bugs.webkit.org/show_bug.cgi?id=161258

Reviewed by Anders Carlsson.

Source/WebKit2:

  • Shared/Cocoa/WKNSNumber.mm:

(-[WKNSNumber charValue]): Override this…
(-[WKNSNumber boolValue]): …not this.

Tools:

  • TestWebKitAPI/Tests/WebKit2Cocoa/WKNSNumber.mm:

(TestWebKitAPI::TEST):

1:29 PM Changeset in webkit [205035] by commit-queue@webkit.org
  • 19 edits in trunk

Web Inspector: Some CSS selectors in the UI aren't escaped
https://bugs.webkit.org/show_bug.cgi?id=151378

Patch by Devin Rousso <Devin Rousso> on 2016-08-26
Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Change ElementData from sending a className string to using an array of
classes, allowing for proper escaping of each class value.

  • inspector/protocol/OverlayTypes.json:

Source/WebCore:

No new tests, but logic and results of existing tests updated:

  • inspector/dom/content-node-region-info.html:
  • inspector/dom/content-node-region-info-expected.txt:
  • inspector/dom/highlightNode-expected.txt:
  • inspector/dom/highlightSelector.html:
  • inspector/dom/highlightSelector-expected.txt:
  • inspector/InspectorOverlay.cpp:

(WebCore::buildObjectForElementData):

  • inspector/InspectorOverlayPage.css:

(.pseudo-type):
(.tag-name): Deleted.

  • inspector/InspectorOverlayPage.js:

(_createElementTitle):

Source/WebInspectorUI:

  • UserInterface/Base/DOMUtilities.js:

(WebInspector.displayNameForNode): Deleted.
(WebInspector.linkifyNodeReference):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

  • UserInterface/Models/DOMNode.js:

(WebInspector.DOMNode.prototype.get escapedIdSelector):
(WebInspector.DOMNode.prototype.get escapedClassSelector):
(WebInspector.DOMNode.prototype.get displayName):
(WebInspector.DOMNode.prototype.appropriateSelectorFor):
Rework escaping of ids and class names into separate public functions using CSS.escape.

  • UserInterface/Views/CSSStyleDeclarationSection.js:

(WebInspector.CSSStyleDeclarationSection.prototype.refresh):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

  • UserInterface/Views/DOMTreeDataGridNode.js:

(WebInspector.DOMTreeDataGridNode.prototype._createNameCellDocumentFragment):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

  • UserInterface/Views/DOMTreeElementPathComponent.js:

(WebInspector.DOMTreeElementPathComponent):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

  • UserInterface/Views/LayerTreeDataGridNode.js:

(WebInspector.LayerTreeDataGridNode.prototype.set layer):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

  • UserInterface/Views/VisualStyleSelectorSection.js:

(WebInspector.VisualStyleSelectorSection.prototype.update):
Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

LayoutTests:

  • inspector/dom/content-node-region-info.html:
  • inspector/dom/content-node-region-info-expected.txt:

Use DOMNode.prototype.displayName instead of WebInspector.displayNameForNode.

  • inspector/dom/highlightNode-expected.txt:
  • inspector/dom/highlightSelector.html:
  • inspector/dom/highlightSelector-expected.txt:

Changed result to replace className with new classes array.

1:22 PM Changeset in webkit [205034] by Joseph Pecoraro
  • 5 edits in trunk/Source/JavaScriptCore

Web Inspector: ScriptProfilerAgent and HeapAgent should do less work when frontend disconnects
https://bugs.webkit.org/show_bug.cgi?id=161213
<rdar://problem/28017986>

Reviewed by Brian Burg.

  • inspector/agents/InspectorHeapAgent.cpp:

(Inspector::InspectorHeapAgent::willDestroyFrontendAndBackend):
Don't take a final snapshot when disconnecting.

  • inspector/agents/InspectorScriptProfilerAgent.cpp:

(Inspector::InspectorScriptProfilerAgent::willDestroyFrontendAndBackend):
(Inspector::InspectorScriptProfilerAgent::stopSamplingWhenDisconnecting):

  • inspector/agents/InspectorScriptProfilerAgent.h:
  • runtime/SamplingProfiler.h:

Don't process samples when disconnecting.

1:22 PM Changeset in webkit [205033] by Joseph Pecoraro
  • 3 edits in trunk/Source/JavaScriptCore

Web Inspector: HeapProfiler/ScriptProfiler do not destruct safely when JSContext is destroyed
https://bugs.webkit.org/show_bug.cgi?id=161027
<rdar://problem/27871349>

Reviewed by Mark Lam.

For JSContext inspection, when a frontend connects keep the target alive.
This means ref'ing the JSGlobalObject / VM when the first frontend
connects and deref'ing when the last frontend disconnects.

  • inspector/JSGlobalObjectInspectorController.h:
  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::globalObjectDestroyed):
(Inspector::JSGlobalObjectInspectorController::disconnectAllFrontends): Deleted.
Now that frontends keep the global object alive, when the global object
is destroyed that must mean that no frontends exist. Remove the now
stale code path.

(Inspector::JSGlobalObjectInspectorController::connectFrontend):
(Inspector::JSGlobalObjectInspectorController::disconnectFrontend):
Ref the target when the first frontend connects, deref when the last disconnects.

1:18 PM Changeset in webkit [205032] by ggaren@apple.com
  • 8 edits
    3 moves in trunk

Renamed XLarge* => Large*
https://bugs.webkit.org/show_bug.cgi?id=161261

Reviewed by Andreas Kling.

XLarge is not a thing anymore: We just have Small and Large.

  • bmalloc.xcodeproj/project.pbxproj:
  • bmalloc/Heap.cpp:

(bmalloc::Heap::splitAndAllocate):
(bmalloc::Heap::tryAllocateLarge):
(bmalloc::Heap::shrinkLarge):
(bmalloc::Heap::deallocateLarge):

  • bmalloc/Heap.h:
  • bmalloc/LargeMap.cpp: Copied from Source/bmalloc/bmalloc/XLargeMap.cpp.

(bmalloc::LargeMap::remove):
(bmalloc::LargeMap::add):
(bmalloc::XLargeMap::remove): Deleted.
(bmalloc::XLargeMap::add): Deleted.

  • bmalloc/LargeMap.h: Copied from Source/bmalloc/bmalloc/XLargeMap.h.

(bmalloc::LargeMap::ranges):
(bmalloc::XLargeMap::ranges): Deleted.

  • bmalloc/LargeRange.h: Copied from Source/bmalloc/bmalloc/XLargeRange.h.

(bmalloc::LargeRange::LargeRange):
(bmalloc::LargeRange::operator<):
(bmalloc::canMerge):
(bmalloc::merge):
(bmalloc::LargeRange::split):
(bmalloc::XLargeRange::XLargeRange): Deleted.
(bmalloc::XLargeRange::operator<): Deleted.
(bmalloc::XLargeRange::split): Deleted.

  • bmalloc/VMHeap.cpp:

(bmalloc::VMHeap::tryAllocateLargeChunk):

  • bmalloc/VMHeap.h:
  • bmalloc/XLargeMap.cpp: Removed.
  • bmalloc/XLargeMap.h: Removed.
  • bmalloc/XLargeRange.h: Removed.
11:12 AM Changeset in webkit [205031] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

Crash when getting font bounding rect
https://bugs.webkit.org/show_bug.cgi?id=161202
<rdar://problem/27986981>

Reviewed by Myles C. Maxfield.

We should never store GlyphData objects for later use, because they contain raw pointers to Font elements
contained in caches, and those font caches get periodically purged.

Instead, we should hold onto the ‘key’ representing the GlyphData, and simply ask the system for the
GlyphData the next time it is needed.

Tested by existing MathML tests under ASAN and GuardMalloc.

  • rendering/mathml/RenderMathMLToken.cpp:

(WebCore::RenderMathMLToken::RenderMathMLToken): Clean up constructors.
(WebCore::RenderMathMLToken::computePreferredLogicalWidths): Use keys to get correct GlyphData when needed.
(WebCore::RenderMathMLToken::updateMathVariantGlyph): Ditto.
(WebCore::RenderMathMLToken::firstLineBaseline): Ditto.
(WebCore::RenderMathMLToken::layoutBlock): Ditto.
(WebCore::RenderMathMLToken::paint): Ditto.
(WebCore::RenderMathMLToken::paintChildren): Ditto.

  • rendering/mathml/RenderMathMLToken.h:
11:09 AM Changeset in webkit [205030] by Chris Dumez
  • 9 edits in trunk

HTMLAreaElement's coords attributes parsing does not comply with the HTML specification
https://bugs.webkit.org/show_bug.cgi?id=161216

Reviewed by Andreas Kling.

LayoutTests/imported/w3c:

Rebaseline W3C test now that all checks are passing. Chrome is also passing all the checks.

  • web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords-expected.txt:

Source/WebCore:

HTMLAreaElement's coords attributes parsing does not comply with the HTML specification:

This patch aligns our parsing of this attribute with the specification and Chrome.

No new tests, rebaselined existing test.

  • html/HTMLAreaElement.cpp:

(WebCore::HTMLAreaElement::HTMLAreaElement):
(WebCore::HTMLAreaElement::parseAttribute):
(WebCore::HTMLAreaElement::getRegion):

  • html/HTMLAreaElement.h:
  • html/parser/HTMLParserIdioms.cpp:

(WebCore::isHTMLSpaceOrDelimiter):
(WebCore::isNumberStart):
(WebCore::parseHTMLListOfOfFloatingPointNumberValuesInternal):
(WebCore::parseHTMLListOfOfFloatingPointNumberValues):
(WebCore::parseHTMLNonNegativeInteger): Deleted.

  • html/parser/HTMLParserIdioms.h:

LayoutTests:

Unskip web-platform-tests/html/semantics/embedded-content/the-area-element/area-coords.html
as it is now passing and not longer crashing in debug builds.

11:00 AM Changeset in webkit [205029] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Fix the !ENABLE(WEB_SOCKETS) build
https://bugs.webkit.org/show_bug.cgi?id=161251

Reviewed by Alex Christensen.

  • page/SocketProvider.h:
10:58 AM Changeset in webkit [205028] by Csaba Osztrogonác
  • 3 edits in trunk/Source/WebCore

Fix the !ENABLE(WEB_TIMING) build
https://bugs.webkit.org/show_bug.cgi?id=161250

Reviewed by Alex Christensen.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::didFinishLoading):

  • loader/cache/CachedResourceLoader.h:

(WebCore::CachedResourceLoader::resourceTimingInformation):

10:37 AM Changeset in webkit [205027] by Yusuke Suzuki
  • 3 edits
    1 add in trunk

[ES6] newPromiseCapabilities should check the given argument is constructor
https://bugs.webkit.org/show_bug.cgi?id=161226

Reviewed by Mark Lam.

JSTests:

The arrow function should not be a constructor. So the error should be raised.

  • stress/new-promise-capabilities-requires-constructor.js: Added.

(shouldThrow):

Source/JavaScriptCore:

Use @isConstructor.

  • builtins/PromiseOperations.js:
10:36 AM Changeset in webkit [205026] by Chris Dumez
  • 40 edits in trunk

Trying to access cross-origin Location properties should throw a SecurityError
https://bugs.webkit.org/show_bug.cgi?id=161248

Reviewed by Alex Christensen.

Source/WebCore:

Trying to access cross-origin Location properties should throw a SecurityError:

Firefox and Chrome already throw. However, WebKit was logging an error message
and returning undefined.

No new tests, updated existing tests.

  • bindings/js/JSDOMBinding.cpp:

(WebCore::throwSecurityError):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::getOwnPropertySlotDelegate):

LayoutTests:

Update existing tests to reflect behavior change.

  • http/tests/plugins/cross-frame-object-access-expected.txt:
  • http/tests/plugins/resources/cross-frame-object-access.html:
  • http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-ignore-deny-meta-tag-parent-same-origin-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
  • http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
  • http/tests/security/cross-frame-access-callback-explicit-domain-DENY-expected.txt:
  • http/tests/security/cross-frame-access-child-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-custom-expected.txt:
  • http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt:
  • http/tests/security/cross-frame-access-history-get-expected.txt:
  • http/tests/security/cross-frame-access-history-get-override-expected.txt:
  • http/tests/security/cross-frame-access-location-get-expected.txt:
  • http/tests/security/cross-frame-access-location-get-override-expected.txt:
  • http/tests/security/cross-frame-access-parent-explicit-domain-expected.txt:
  • http/tests/security/cross-frame-access-port-expected.txt:
  • http/tests/security/cross-frame-access-protocol-expected.txt:
  • http/tests/security/cross-frame-access-protocol-explicit-domain-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-expected.txt:
  • http/tests/security/dataURL/xss-DENIED-to-data-url-sub-frame-uppercase-expected.txt:
  • http/tests/security/location-cross-origin-expected.txt:
  • http/tests/security/location-cross-origin.html:
  • http/tests/security/resources/cross-frame-access.js:

(canGet):
(canGetDescriptor):
(canCall):
(toString):

  • http/tests/security/sandboxed-iframe-blocks-access-from-parent-expected.txt:
  • http/tests/security/xss-DENIED-defineProperty-expected.txt:
  • http/tests/security/xss-DENIED-defineProperty.html:
  • http/tests/security/xssAuditor/block-does-not-leak-location-expected.txt:
  • http/tests/security/xssAuditor/block-does-not-leak-location.html:
  • http/tests/security/xssAuditor/full-block-script-tag-cross-domain-expected.txt:
  • http/tests/security/xssAuditor/full-block-script-tag-cross-domain.html:
  • http/tests/security/xssAuditor/resources/utilities.js:

(checkIfFrameLocationMatchesSrcAndCallDone):

10:36 AM Changeset in webkit [205025] by pvollan@apple.com
  • 3 edits in trunk/Source/WebCore

[Win] Warning fixes.
https://bugs.webkit.org/show_bug.cgi?id=161241

Reviewed by Brent Fulgham.

MSVC warns about potential use of uninitialized variables.

  • accessibility/AXObjectCache.cpp:
  • css/parser/CSSParserValues.cpp:
10:13 AM Changeset in webkit [205024] by eric.carlson@apple.com
  • 13 edits
    4 adds in trunk

[MediaStream] Add support for OverConstrainedErrorEvent
https://bugs.webkit.org/show_bug.cgi?id=161199
<rdar://problem/28011819>

Reviewed by Jer Noble.

Source/WebCore:

Test: fast/events/constructors/overconstrained-error-event-constructor.html

  • CMakeLists.txt:
  • DerivedSources.make:
  • Modules/mediastream/OverconstrainedErrorEvent.h: Added.

(WebCore::OverconstrainedErrorEvent::~OverconstrainedErrorEvent):
(WebCore::OverconstrainedErrorEvent::create):
(WebCore::OverconstrainedErrorEvent::createForBindings):
(WebCore::OverconstrainedErrorEvent::error):
(WebCore::OverconstrainedErrorEvent::eventInterface):
(WebCore::OverconstrainedErrorEvent::OverconstrainedErrorEvent):

  • Modules/mediastream/OverconstrainedErrorEvent.idl: Added.
  • WebCore.xcodeproj/project.pbxproj: Add new files.
  • bindings/js/JSDictionary.cpp:

(WebCore::JSDictionary::convertValue): Add OverconstrainedErrorEvent converter.

  • bindings/js/JSDictionary.h:
  • dom/EventNames.in: Add OverconstrainedErrorEvent.

LayoutTests:

  • fast/events/constructors/overconstrained-error-event-constructor-expected.txt: Added.
  • fast/events/constructors/overconstrained-error-event-constructor.html: Added.
  • js/dom/global-constructors-attributes-expected.txt: Updated.
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
10:05 AM Changeset in webkit [205023] by keith_miller@apple.com
  • 10 edits in trunk

toString called on proxies returns incorrect tag
https://bugs.webkit.org/show_bug.cgi?id=161111

Reviewed by Benjamin Poulain.

This patch adds a new Method table function toStringName. This function
is used by Object.prototype.toString to create the string tag that it
inserts. Right now it only changes the stringification of proxy objects.
In future patches I plan to make it work for other classes of objects as
well.

  • runtime/ClassInfo.h:
  • runtime/JSCell.cpp:

(JSC::JSCell::toStringName):

  • runtime/JSCell.h:
  • runtime/JSObject.cpp:

(JSC::JSObject::toStringName):

  • runtime/JSObject.h:
  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString):

  • runtime/ProxyObject.cpp:

(JSC::ProxyObject::toStringName):

  • runtime/ProxyObject.h:
10:02 AM Changeset in webkit [205022] by barraclough@apple.com
  • 4 edits
    2 deletes in trunk/Source/bmalloc

bmalloc: speed up the lock slow path
https://bugs.webkit.org/show_bug.cgi?id=161058

Unreviewed rollout - this caused regressions <rdar://problem/28026089>.

  • bmalloc.xcodeproj/project.pbxproj:
  • bmalloc/ScopeExit.h: Removed.
  • bmalloc/StaticMutex.cpp:

(bmalloc::StaticMutex::lockSlowCase):

  • bmalloc/StaticMutex.h:

(bmalloc::StaticMutex::init):

  • bmalloc/ThreadSwitch.h: Removed.
9:54 AM Changeset in webkit [205021] by Csaba Osztrogonác
  • 19 edits in trunk

Fix the ENABLE(WEBASSEMBLY) build on Linux
https://bugs.webkit.org/show_bug.cgi?id=161197

Reviewed by Mark Lam.

Source/JavaScriptCore:

  • CMakeLists.txt:
  • b3/B3Common.cpp:

(JSC::B3::shouldDumpIR):

  • shell/CMakeLists.txt:
  • wasm/JSWASMModule.h:
  • wasm/WASMB3IRGenerator.cpp:

(JSC::WASM::toB3Op):

  • wasm/WASMB3IRGenerator.h:
  • wasm/WASMFormat.h:
  • wasm/WASMFunctionParser.h:
  • wasm/WASMModuleParser.cpp:

(JSC::WASM::WASMModuleParser::parseFunctionTypes):

  • wasm/WASMModuleParser.h:
  • wasm/WASMParser.h:
  • wasm/WASMPlan.cpp:
  • wasm/WASMPlan.h:
  • wasm/WASMSections.cpp:

Source/WTF:

  • wtf/Platform.h:

Tools:

  • Scripts/build-jsc:
9:50 AM Changeset in webkit [205020] by pvollan@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

[Win] Compile fix.
https://bugs.webkit.org/show_bug.cgi?id=161235

Reviewed by Brent Fulgham.

YarrPattern::errorMessage has inconsistent dll linkage.

  • yarr/YarrPattern.h:
9:50 AM Changeset in webkit [205019] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.1.50.0.7

New tag.

9:41 AM Changeset in webkit [205018] by commit-queue@webkit.org
  • 7 edits in trunk

The annotation-xml element does not need to be behave as an mrow
https://bugs.webkit.org/show_bug.cgi?id=161230

Patch by Frederic Wang <fwang@igalia.com> on 2016-08-26
Reviewed by Manuel Rego Casasnovas.

Source/WebCore:

In r204779, MathMLAnnotationElement was made a MathMLRowElement just because the
annotation-xml element is generating a RenderMathMLRow. This later point is actually not
needed since annotation-xml is just a wrapper for foreign elements and so does not need to
handle special MathML features like operator spacing or stretching. We can thus move back
MathMLAnnotationElement to a generic MathMLPresentationElement and instead make the
annotation-xml element generate a generic RenderMathMLBlock renderer.

No new tests, semantics annotations already covered by existing tests.

  • mathml/MathMLAnnotationElement.cpp: Replace RenderMathMLRow.h with RenderMathMLBlock.h

(WebCore::MathMLAnnotationElement::MathMLAnnotationElement): Inherit from
MathMLPresentationElement instead of MathMLRowElement.
(WebCore::MathMLAnnotationElement::createElementRenderer): Make annotation-xml create a
RenderMathMLBlock instead of a RenderMathMLRow.
(WebCore::MathMLAnnotationElement::attributeChanged): Inherit from MathMLPresentationElement
instead of MathMLRowElement.

  • mathml/MathMLAnnotationElement.h: Ditto.

LayoutTests:

  • platform/efl/accessibility/math-foreign-content-expected.txt: Remove the AXGroup from the

test expectation, which that was used for annotation-xml.

  • platform/gtk/accessibility/math-foreign-content-expected.txt: Ditto.
  • platform/mac/accessibility/math-foreign-content-expected.txt: Ditto.
9:36 AM Changeset in webkit [205017] by clopez@igalia.com
  • 2 edits in trunk/Tools

[GTK] run-gtk-tests should use the driver environment for checking the accessibility bus
https://bugs.webkit.org/show_bug.cgi?id=161149

Reviewed by Carlos Garcia Campos.

Add a new function for waiting for the accesibility bus. It sets
the test environment variables before starting the GLib mainloop.
And restores the previous environment after it has finished.
It also adds a timeout (5 seconds) to abort in case it has not
been able to detect the accesibility bus before the timeout expires.

  • Scripts/run-gtk-tests:

(TestRunner):
(TestRunner._wait_for_accessibility_bus):
(TestRunner._wait_for_accessibility_bus.timeout_accessibility_bus):
(TestRunner._start_accessibility_daemons):
(TestRunner._get_tests_from_google_test_suite): Run this command also with the driver test environment.

9:35 AM Changeset in webkit [205016] by pvollan@apple.com
  • 2 edits in trunk/Tools

[Win] Warning fix.
https://bugs.webkit.org/show_bug.cgi?id=161236

Reviewed by Brent Fulgham.

The & operator in the Test struct has no body.

  • TestWebKitAPI/Tests/WTF/Vector.cpp:

(TestWebKitAPI::TEST):

9:33 AM Changeset in webkit [205015] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

Typo fix after r56209
https://bugs.webkit.org/show_bug.cgi?id=161246

Reviewed by Gyuyoung Kim.

  • page/FrameView.cpp:

(WebCore::FrameView::adjustMediaTypeForPrinting):

9:32 AM Changeset in webkit [205014] by clopez@igalia.com
  • 8 edits in trunk/Tools

[GTK] run-gtk-tests should use webkitpy.port.gtk and webkitpy.port.xvfbdriver
https://bugs.webkit.org/show_bug.cgi?id=160736

Reviewed by Carlos Garcia Campos.

This plugs run-gtk-tests into the webkitpy testing infrastructure.
As a benefit of this, run-gtk-tests now can be executed over any of
the existing supported gtk test display servers (xvfb, weston-over-xvfb,
or native xorg). A new command line switch --wayland is added for
run-gtk-tests.

  • Scripts/run-gtk-tests:

(TestRunner.init): Remove the --display command line switch, its not longer useful.
Add a --wayland command line switch.
(TestRunner._start_accessibility_daemons):
(TestRunner):
(TestRunner.init):
(TestRunner._run_xvfb): Deleted.
(TestRunner._create_driver):
(TestRunner._setup_testing_environment): Delete the environment variable definitions that
are now done by driver._setup_environ_for_test().
(TestRunner._tear_down_testing_environment):

  • Scripts/webkitpy/port/driver.py:

(Driver.init): Define self._server_name in the constructor of the base class.
It is used by several functions, so it makes sense to store once the value here.
(Driver._setup_environ_for_test): Factorize setting the environment for a given test.
(Driver._start): Get the environment from self._setup_environ_for_test()

  • Scripts/webkitpy/port/driver_unittest.py:

(DriverTest):
(DriverTest.test_setup_environ_for_test): Add unittest for driver._setup_environ_for_test()

  • Scripts/webkitpy/port/gtk.py: Move the inspection of the env var USE_NATIVE_XDISPLAY to the constructor.

(GtkPort.init):
(GtkPort._driver_class):

  • Scripts/webkitpy/port/westondriver.py: Define and use self._setup_environ_for_test()

(WestonDriver._setup_environ_for_test):
(WestonDriver._start):

  • Scripts/webkitpy/port/xorgdriver.py: Define and use self._setup_environ_for_test()

(XorgDriver._setup_environ_for_test):
(XorgDriver._start):

  • Scripts/webkitpy/port/xvfbdriver.py: Define and use self._setup_environ_for_test()

(XvfbDriver._setup_environ_for_test):
(XvfbDriver._start):

9:04 AM Changeset in webkit [205013] by ap@apple.com
  • 2 edits in trunk/LayoutTests

Reinstate flakiness expectations for viewport tests, as they are still flaky.
https://bugs.webkit.org/show_bug.cgi?id=153110

  • platform/ios-simulator-wk2/TestExpectations:
7:04 AM Changeset in webkit [205012] by Csaba Osztrogonác
  • 5 edits in trunk

[EFL][GTK] REGRESSION(204877): Fix the clean build
https://bugs.webkit.org/show_bug.cgi?id=161240

Reviewed by Carlos Garcia Campos.

Source/WebKit2:

  • Scripts/generate-forwarding-headers.pl: Added back multiple include-path support. (removed by r183389)

Tools:

  • WebKitTestRunner/PlatformEfl.cmake:
  • WebKitTestRunner/PlatformGTK.cmake:
6:29 AM Changeset in webkit [205011] by pvollan@apple.com
  • 15 edits in trunk/Source/WebCore

[Win] Warning fixes.
https://bugs.webkit.org/show_bug.cgi?id=161077

Reviewed by Brent Fulgham.

  • css/CSSGrammar.y.includes:
  • css/RuleFeature.cpp:

(WebCore::makeAttributeSelectorKey):

  • editing/TextIterator.cpp:

(WebCore::SearchBuffer::SearchBuffer):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::textToFragment):

  • html/MediaElementSession.h:
  • platform/URL.cpp:
  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • platform/network/HTTPParsers.cpp:

(WebCore::parseHTTPHeader):

  • rendering/InlineIterator.h:

(WebCore::InlineIterator::clear):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::FlexBoxIterator::reset):

  • rendering/RenderText.cpp:

(WebCore::RenderText::secureText):

  • rendering/mathml/RenderMathMLToken.cpp:

(WebCore::mathVariant):

  • style/InlineTextBoxStyle.cpp:

(WebCore::visualOverflowForDecorations):

  • xml/XPathGrammar.y:
3:54 AM Changeset in webkit [205010] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

EWS should indicate which bot processed the patch
https://bugs.webkit.org/show_bug.cgi?id=161222

Reviewed by Daniel Bates.

  • QueueStatusServer/handlers/statusbubble.py:

(StatusBubble._build_bubble): Display the bot id in status bubble. Also removed "Started processing" message since
after bug fix of 161223, bots send the "Started processing patch" message and it would be displayed in Recent messages.
Also added "Started processing patch" message to progress_statuses.
I might consider displaying bot id in other statuses as well later on.

1:46 AM Changeset in webkit [205009] by Gyuyoung Kim
  • 2 edits in trunk/Source/WebKit2

Unreviewed EFL build fix since r204996.

Patch by Gyuyoung Kim <gyuyoung.kim@navercorp.com> on 2016-08-26

  • UIProcess/efl/WebPageProxyEfl.cpp:

(WebKit::WebPageProxy::editorStateChanged):
(WebKit::WebPageProxy::setThemePath):
(WebKit::WebPageProxy::confirmComposition):
(WebKit::WebPageProxy::setComposition):
(WebKit::WebPageProxy::cancelComposition):

1:04 AM Changeset in webkit [205008] by nael.ouedraogo@crf.canon.fr
  • 27 edits in trunk

Make custom constructors consistent with generated bindings code
https://bugs.webkit.org/show_bug.cgi?id=159550

Reviewed by Youenn Fablet.

Add assertion to check DOMConstructorObject* passed in ExecState is not null.
Rename throwConstructorDocumentUnavailableError to throwConstructorScriptExecutionContextUnavailableError since
ScriptExecutionContext is not necessarily a Document.
Modify error message in case of argument error to be consistent with generated binding code: replace calls to
throwVMError with calls to throwConstructorScriptExecutionContextUnavailableError and throwArgumentTypeError.

No new test required. Modify tests and tests expectations to align with new error messages.

Source/WebCore:

  • bindings/js/JSAudioContextCustom.cpp:

(WebCore::constructJSAudioContext):

  • bindings/js/JSBlobCustom.cpp:

(WebCore::constructJSBlob):

  • bindings/js/JSDOMBinding.cpp:

(WebCore::throwConstructorScriptExecutionContextUnavailableError):

  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDOMConstructor.h:

(WebCore::JSBuiltinConstructor<JSClass>::callConstructor):

  • bindings/js/JSDOMFormDataCustom.cpp:

(WebCore::constructJSDOMFormData):

  • bindings/js/JSDataCueCustom.cpp:

(WebCore::constructJSDataCue):

  • bindings/js/JSFileCustom.cpp:

(WebCore::constructJSFile):

  • bindings/js/JSHTMLElementCustom.cpp:

(WebCore::constructJSHTMLElement):

  • bindings/js/JSMediaSessionCustom.cpp:

(WebCore::constructJSMediaSession):

  • bindings/js/JSMutationObserverCustom.cpp:

(WebCore::constructJSMutationObserver):

  • bindings/js/JSReadableStreamPrivateConstructors.cpp:

(WebCore::constructJSReadableStreamDefaultReader):

  • bindings/js/JSWorkerCustom.cpp:

(WebCore::constructJSWorker):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallbackImplementation):
(NativeToJSValue):
(GenerateHashTableValueArray):
(GenerateConstructorDefinition):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::construct):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::construct):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorNamedConstructor::construct):

  • bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodeConstructor::construct):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjConstructor::construct):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::constructJSTestOverloadedConstructors1):
(WebCore::constructJSTestOverloadedConstructors2):
(WebCore::constructJSTestOverloadedConstructors3):
(WebCore::constructJSTestOverloadedConstructors4):
(WebCore::constructJSTestOverloadedConstructors5):

  • bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:

(WebCore::constructJSTestOverloadedConstructorsWithSequence1):
(WebCore::constructJSTestOverloadedConstructorsWithSequence2):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::construct):

LayoutTests:

  • fast/dom/MutationObserver/mutation-observer-constructor-expected.txt:
  • fast/files/file-constructor-expected.txt:
  • fast/files/file-constructor.html:
12:36 AM Changeset in webkit [205007] by Gyuyoung Kim
  • 2 edits in trunk/Tools

[EFL] Change homepage url to www.ewebkit.org on MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=161184

Reviewed by Carlos Garcia Campos.

  • MiniBrowser/efl/main.c: Set www.ewebkit.org.
12:34 AM Changeset in webkit [205006] by bshafiei@apple.com
  • 5 edits in tags/Safari-601.7.7.1/Source

Versioning.

12:32 AM Changeset in webkit [205005] by bshafiei@apple.com
  • 1 copy in tags/Safari-601.7.7.1

New tag.

Aug 25, 2016:

11:55 PM Changeset in webkit [205004] by Carlos Garcia Campos
  • 5 edits in trunk/Source

Unreviewed. Fix GTK+ build after r204986 and r204996.

Source/WebCore:

  • page/DOMWindow.idl:

Source/WebKit2:

  • Platform/IPC/unix/ConnectionUnix.cpp:

(IPC::Connection::willSendSyncMessage):
(IPC::Connection::didReceiveSyncReply):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::drawPagesForPrinting):

10:33 PM Changeset in webkit [205003] by aakash_jain@apple.com
  • 4 edits in trunk/Tools

ews queues should update status server when they start processing patch
https://bugs.webkit.org/show_bug.cgi?id=161223

Reviewed by Daniel Bates.

  • Scripts/webkitpy/tool/commands/queues.py:

(AbstractReviewQueue.process_work_item): Update status server that the bot started processing the patch.

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(EarlyWarningSystemTest._default_expected_logs): Updated the unit test accordingly.

  • Scripts/webkitpy/tool/commands/queues_unittest.py:

(StyleQueueTest.test_style_queue_with_style_exception): Same.
(test_style_queue_with_watch_list_exception): Same.
(test_non_valid_patch): Same.

7:16 PM Changeset in webkit [205002] by jiewen_tan@apple.com
  • 2 edits
    15 adds in trunk/LayoutTests

Unreviewed, rebase iOS simulator WK1 imported/w3c tests

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk1/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-cross-origin-expected.txt: Added.
  • platform/ios-simulator-wk1/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-navigation-samedoc-expected.txt: Added.
  • platform/ios-simulator-wk1/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/scroll-to-fragid/scroll-frag-percent-encoded-expected.txt: Added.
  • platform/ios-simulator-wk1/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/unloading-documents/001-expected.txt: Added.
  • platform/ios-simulator-wk1/imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name-expected.txt: Added.
6:53 PM Changeset in webkit [205001] by commit-queue@webkit.org
  • 2 edits
    407 adds in trunk/LayoutTests

[iOS Simulator] Rebaseline many tests under LayoutTests/svg/ for ios-simulator and enable them for testing
https://bugs.webkit.org/show_bug.cgi?id=161166

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-08-25
Reviewed by Simon Fraser.

  • platform/ios-simulator/TestExpectations:
  • platform/ios-simulator/svg/W3C-I18N: Added.
  • platform/ios-simulator/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-dirLTR-anchorEnd-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-dirLTR-anchorStart-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-dirNone-anchorEnd-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-dirNone-anchorMiddle-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-dirNone-anchorStart-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-dirRTL-anchorEnd-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-dirRTL-anchorStart-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorEnd-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorMiddle-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-inherited-dirLTR-anchorStart-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorEnd-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorMiddle-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-inherited-dirRTL-anchorStart-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-anchor-no-markup-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirNone-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-default-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirRTL-ubEmbed-in-ltr-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirRTL-ubNone-in-ltr-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-direction-ltr-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/filters-image-05-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/painting-control-04-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/painting-marker-05-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/painting-marker-06-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/struct-dom-11-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/struct-use-11-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/styling-pres-02-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/text-intro-09-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-08-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-09-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-10-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-11-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-13-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-14-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-18-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-20-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-21-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-22-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-23-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-25-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-26-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-27-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-28-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-29-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-31-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-32-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-34-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-39-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-44-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-52-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-60-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-61-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-62-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-63-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-64-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-65-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-66-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-67-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-68-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-69-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-70-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-77-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-78-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-81-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-83-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-84-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/animate-elem-85-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/color-prof-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/color-prop-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/color-prop-02-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/color-prop-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-coord-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-coord-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-trans-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-trans-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-trans-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-trans-06-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-units-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-units-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-units-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-viewattr-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-viewattr-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/coords-viewattr-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/extend-namespace-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-blend-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-color-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-composite-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-displace-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-example-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-felem-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-gauss-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-image-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-light-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-morph-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-offset-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-specular-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-tile-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-turb-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/interact-dom-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/interact-events-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/interact-order-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/interact-order-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/interact-order-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/linking-a-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/linking-a-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/linking-a-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/linking-a-04-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/linking-a-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/linking-a-07-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/linking-uri-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/linking-uri-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/linking-uri-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/masking-intro-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/masking-opacity-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/masking-path-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/masking-path-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/masking-path-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/masking-path-04-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/masking-path-05-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-fill-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-fill-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-fill-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-fill-04-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-fill-05-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-marker-01-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-render-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-stroke-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-stroke-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-stroke-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-stroke-04-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/painting-stroke-07-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-03-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-04-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-06-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-07-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-08-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-09-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-10-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-12-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-13-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-14-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/paths-data-15-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-04-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-05-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-06-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-07-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-09-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-10-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-11-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-12-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-14-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-15-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-16-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-17-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-18-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-grad-19-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/pservers-pattern-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/render-elems-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/render-elems-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/render-elems-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/script-handle-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/script-handle-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/script-handle-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/script-handle-04-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/shapes-circle-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/shapes-circle-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/shapes-ellipse-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/shapes-ellipse-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/shapes-intro-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/shapes-line-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/shapes-polygon-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/shapes-polyline-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/shapes-rect-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/shapes-rect-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-cond-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-cond-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-defs-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-dom-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-dom-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-dom-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-dom-04-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-dom-05-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-frag-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-frag-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-frag-04-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-frag-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-frag-06-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-group-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-group-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-group-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-04-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-05-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-06-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-07-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-08-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-09-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-image-10-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-symbol-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-use-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/struct-use-05-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/styling-css-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/styling-css-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/styling-css-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/styling-css-04-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/styling-css-05-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/styling-css-06-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/styling-inherit-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/styling-pres-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-align-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-align-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-align-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-align-04-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-align-05-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-align-06-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-align-08-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-deco-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-fonts-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-fonts-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-path-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-spacing-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-text-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-text-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-text-06-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-text-07-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-text-08-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-tref-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-tselect-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-tselect-02-f-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-tspan-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-ws-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/text-ws-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/W3C-SVG-1.1/types-basicDOM-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/batik: Added.
  • platform/ios-simulator/svg/batik/text: Added.
  • platform/ios-simulator/svg/batik/text/longTextOnPath-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/smallFonts-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textAnchor-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textAnchor2-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textAnchor3-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textDecoration-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textDecoration2-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textEffect-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textEffect2-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textEffect3-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textFeatures-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textGlyphOrientationHorizontal-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textLayout-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textLayout2-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textLength-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textOnPath-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textOnPath2-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textOnPath3-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textOnPathSpaces-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textPCDATA-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textPosition-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textPosition2-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textProperties-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textProperties2-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/textStyles-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/verticalText-expected.txt: Added.
  • platform/ios-simulator/svg/batik/text/verticalTextOnPath-expected.txt: Added.
  • platform/ios-simulator/svg/text/selection-background-color-expected.txt: Added.
  • platform/ios-simulator/svg/text/small-fonts-2-expected.txt: Added.
  • platform/ios-simulator/svg/text/small-fonts-3-expected.txt: Added.
  • platform/ios-simulator/svg/text/small-fonts-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-align-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-align-02-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-align-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-align-04-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-align-05-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-align-06-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-altglyph-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-deco-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-fill-opacity-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-fonts-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-fonts-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-gradient-positioning-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-hkern-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-intro-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-midpoint-split-bug-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-path-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-path-middle-align-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-spacing-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-text-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-text-03-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-text-04-t-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-text-05-t-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-text-06-t-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-text-07-t-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-text-08-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-tref-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-tselect-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-tselect-02-f-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-tspan-01-b-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-viewbox-rescale-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-vkern-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-ws-01-t-expected.txt: Added.
  • platform/ios-simulator/svg/text/text-ws-02-t-expected.txt: Added.
  • platform/ios-simulator/svg/text/tspan-dynamic-positioning-expected.txt: Added.
5:57 PM Changeset in webkit [205000] by Simon Fraser
  • 2 edits in trunk/LayoutTests

js/regress/polymorphic-put-by-id.html does not exist.

  • platform/ios-simulator-wk2/TestExpectations:
5:49 PM Changeset in webkit [204999] by jiewen_tan@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed, rebase iOS simulator WK1 imported/mozilla tests

  • platform/ios-simulator-wk1/TestExpectations:
5:28 PM Changeset in webkit [204998] by achristensen@apple.com
  • 5 edits
    1 add in trunk

CMake build fix.

Source/JavaScriptCore:

  • ForwardingHeaders/JavaScriptCore/JSObjectRefPrivate.h: Added.

This is needed for the internal Windows build.

Source/WebKit:

  • PlatformMac.cmake:

Availability was spelled wrong, resulting in a missing header.

Tools:

  • DumpRenderTree/PlatformMac.cmake:
5:14 PM Changeset in webkit [204997] by jiewen_tan@apple.com
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed, rebase iOS simulator WK1 imported/blink tests

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk1/imported/blink/fast/shapes/shape-outside-floats/shape-outside-negative-height-crash-width-expected.txt: Added.
4:09 PM Changeset in webkit [204996] by andersca@apple.com
  • 25 edits in trunk/Source/WebKit2

Replace all IPC message send flags with OptionSet
https://bugs.webkit.org/show_bug.cgi?id=161211

Reviewed by Tim Horton.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::didFailLoading):
(WebKit::NetworkResourceLoader::sendAbortingOnFailure):

  • NetworkProcess/NetworkResourceLoader.h:
  • Platform/IPC/Connection.cpp:

(IPC::WaitForMessageState::WaitForMessageState):
(IPC::Connection::sendMessage):
(IPC::Connection::sendSyncReply):
(IPC::Connection::waitForMessage):
(IPC::Connection::sendSyncMessage):
(IPC::Connection::sendSyncMessageFromSecondaryThread):
(IPC::Connection::waitForSyncReply):
(IPC::Connection::processIncomingMessage):

  • Platform/IPC/Connection.h:

(IPC::Connection::send):
(IPC::Connection::sendSync):
(IPC::Connection::waitForAndDispatchImmediately):

  • Platform/IPC/MessageSender.cpp:

(IPC::MessageSender::sendMessage):

  • Platform/IPC/MessageSender.h:

(IPC::MessageSender::send):
(IPC::MessageSender::sendSync):

  • Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::open):
(IPC::Connection::willSendSyncMessage):
(IPC::Connection::didReceiveSyncReply):

  • PluginProcess/mac/PluginControllerProxyMac.mm:

(WebKit::PluginControllerProxy::setComplexTextInputState):

  • UIProcess/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::sendMessage):
(WebKit::ChildProcessProxy::didFinishLaunching):

  • UIProcess/ChildProcessProxy.h:

(WebKit::ChildProcessProxy::send):
(WebKit::ChildProcessProxy::sendSync):

  • UIProcess/Databases/DatabaseProcessProxy.cpp:

(WebKit::DatabaseProcessProxy::getDatabaseProcessConnection):

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::getNetworkProcessConnection):

  • UIProcess/Plugins/PluginProcessProxy.cpp:

(WebKit::PluginProcessProxy::getPluginProcessConnection):

  • UIProcess/WebEditCommandProxy.cpp:

(WebKit::WebEditCommandProxy::unapply):
(WebKit::WebEditCommandProxy::reapply):

  • UIProcess/WebPageProxy.cpp:

(WebKit::printingSendOptions):
(WebKit::WebPageProxy::preferencesDidChange):
(WebKit::WebPageProxy::sendMessage):
(WebKit::WebPageProxy::beginPrinting):
(WebKit::WebPageProxy::endPrinting):
(WebKit::WebPageProxy::computePagesForPrinting):
(WebKit::WebPageProxy::drawRectToImage):
(WebKit::WebPageProxy::drawPagesToPDF):
(WebKit::WebPageProxy::drawPagesForPrinting):
(WebKit::WebPageProxy::setMinimumLayoutSize): Deleted.
(WebKit::WebPageProxy::setAutoSizingShouldExpandToViewHeight): Deleted.
(WebKit::WebPageProxy::handleAlternativeTextUIResult): Deleted.

  • UIProcess/WebPageProxy.h:
  • UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::waitForDidUpdateViewState):

  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:

(WebKit::TiledCoreAnimationDrawingAreaProxy::waitForDidUpdateViewState):

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::geometryDidChange):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::runBeforeUnloadConfirmPanel):
(WebKit::WebChromeClient::runJavaScriptAlert):
(WebKit::WebChromeClient::runJavaScriptConfirm):
(WebKit::WebChromeClient::runJavaScriptPrompt):
(WebKit::WebChromeClient::print):
(WebKit::WebChromeClient::exceededDatabaseQuota):
(WebKit::WebChromeClient::reachedApplicationCacheOriginQuota):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::createWithCoreMainFrame):
(WebKit::WebFrame::createSubframe):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::sendPostLayoutEditorStateIfNeeded):
(WebKit::WebPage::postSynchronousMessageForTesting):

  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::BackingStoreFlusher::flush):

4:02 PM Changeset in webkit [204995] by commit-queue@webkit.org
  • 11 edits in trunk

[JSC] Clean up the abstract interpreter for cos/sin/sqrt/fround/log
https://bugs.webkit.org/show_bug.cgi?id=161181

Patch by Benjamin Poulain <bpoulain@apple.com> on 2016-08-25
Reviewed by Geoffrey Garen.

JSTests:

Extend the tests to constants.
Add no-argument cases where needed.

  • stress/arith-cos-on-various-types.js:
  • stress/arith-fround-on-various-types.js:
  • stress/arith-log-on-various-types.js:
  • stress/arith-sin-on-various-types.js:
  • stress/arith-sqrt-on-various-types.js:

Source/JavaScriptCore:

All the nodes are doing the exact same thing with a single
difference: how to process constants. I made that into a separate
function called from each node.

I also generalized the constant-to-number code of DoubleRep
to make it available for all those nodes.

  • dfg/DFGAbstractInterpreter.h:
  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeDoubleUnaryOpEffects):

  • runtime/JSCJSValue.cpp:

(JSC::JSValue::toNumberFromPrimitive):

  • runtime/JSCJSValue.h:
3:55 PM Changeset in webkit [204994] by Yusuke Suzuki
  • 40 edits
    2 copies
    12 adds
    2 deletes in trunk

[DFG][FTL] Implement ES6 Generators in DFG / FTL
https://bugs.webkit.org/show_bug.cgi?id=152723

Reviewed by Filip Pizlo.

JSTests:

  • stress/generator-fib-ftl-and-array.js: Added.

(fib):

  • stress/generator-fib-ftl-and-object.js: Added.

(fib):

  • stress/generator-fib-ftl-and-string.js: Added.

(fib):

  • stress/generator-fib-ftl.js: Added.

(fib):

  • stress/generator-frame-empty.js: Added.

(shouldThrow):
(shouldThrow.fib):

  • stress/generator-reduced-save-point-put-to-scope.js: Added.

(shouldBe):
(gen):

  • stress/generator-transfer-register-beyond-mutiple-yields.js: Added.

(shouldBe):
(gen):

Source/JavaScriptCore:

This patch introduces DFG and FTL support for ES6 generators.
ES6 generator is compiled by the BytecodeGenerator. But at the last phase, BytecodeGenerator performs "generatorification" onto the unlinked code.
In BytecodeGenerator phase, we just emit op_yield for each yield point. And we don't emit any generator related switch, save, and resume sequences
here. Those are emitted by the generatorification phase.

So the graph is super simple! Before the generatorification, the graph looks like this.

op_enter -> ...... -> op_yield -> ..... -> op_yield -> ...

Roughly speaking, in the generatorification phase, we turn out which variables should be saved and resumed at each op_yield.
This is done by liveness analysis. After that, we convert op_yield to the sequence of "op_put_to_scope", "op_ret", and "op_get_from_scope".
op_put_to_scope and op_get_from_scope sequences are corresponding to the save and resume sequences. We set up the scope for the generator frame and
perform op_put_to_scope and op_get_from_scope onto it. The live registers are saved and resumed over the generator's next() calls by using this
special generator frame scope. And we also set up the global switch for the generator.

In the generatorification phase,

  1. We construct the BytecodeGraph from the unlinked instructions. This constructs the basic blocks, and it is used in the subsequent analysis.
  2. We perform the analysis onto the unlinked code. We extract the live variables at each op_yield.
  3. We insert the get_from_scope and put_to_scope at each op_yield. Which registers should be saved and resumed is offered by (2). Then, clip the op_yield themselves. And we also insert the switch_imm. The jump targets of this switch are just after this op_switch_imm and each op_yield point.

One interesting point is the try-range. We split the try-range at the op_yield point in BytecodeGenerator phase.
This drops the hacky thing that is introduced in [1].
If the try-range covers the resume sequences, the exception handler's use-registers are incorrectly transferred to the entry block.
For example,

handler uses r2

try-range

label:(entry block can jump here)

r1 = get_from_scope # resume sequence starts | use r2 is transferred to the entry block!
r2 = get_from_scope |
starts usual sequences |
... |

Handler's r2 use should be considered at the r1 = get_from_scope point.
Previously, we handle this edge case by treating op_resume specially in the liveness analysis[1].
To drop this workaround, we split the try-range not to cover this resume sequence.

handler uses r2

try-range

label:(entry block can jump here)

r1 = get_from_scope # resume sequence starts
r2 = get_from_scope
starts usual sequences try-range should start from here.
... |

OK. Let's show the detailed example.

  1. First, there is the normal bytecode sequence. Here, | represents the offsets, and [] represents the bytecodes.

bytecodes | [ ] | [ ] | [ ] | [ ] | [ ] | [ ] |
try-range <----------------------------------->

  1. When we emit the op_yield in the bytecode generator, we carefully split the try-range.

bytecodes | [ ] | [ ] | [op_yield] | [ ] | [ ] | [ ] |
try-range <-----------> <----------------->

  1. And in the generatorification phase, we insert the switch's jump target and save & resume sequences. And we also drop op_yield.

Insert save seq Insert resume seq
before op_yield. after op_yield's point.

v v

bytecodes | [ ] | [ ] | [op_yield] | [ ] | [ ] | [ ] |
try-range <-----------> <----------------->

|

Jump to here. Drop this op_yield.

  1. The final layout is the following.

bytecodes | [ ] | [ ][save seq][op_ret] | [resume seq] | [ ] | [ ] | [ ] |
try-range <-----------------------------> <---------------->


Jump to here.

The rewriting done by the BytecodeRewriter is executed in a batch manner. Since these modification changes the basic blocks and size of unlinked instructions,
BytecodeRewriter also performs the offset adjustment for UnlinkedCodeBlock. So, this rewriting is performed onto the BytecodeGraph rather than BytecodeBasicBlock.
The reason why we take this design is simple: we don't want to newly create the basic blocks and opcodes for this early phase like DFG. Instead, we perform the
modification and adjustment to the unlinked instructions and UnlinkedCodeBlock in a in-place manner.

Bytecode rewriting functionality is offered by BytecodeRewriter. BytecodeRewriter allows us to insert any bytecodes to any places
in a in-place manner. BytecodeRewriter handles the original bytecode offsets as labels. And you can insert bytecodes before and after
these labels. You can also insert any jumps to any places. When you insert jumps, you need to specify jump target with this labels.
These labels (original bytecode offsets) are automatically converted to the appropriate offsets by BytecodeRewriter.

After that phase, the data flow of the generator-saved-and-resumed-registers are explicitly represented by the get_from_scope and put_to_scope.
And the switch is inserted to represent the actual control flow for the generator. And op_yield is removed. Since we use the existing bytecodes (op_switch_imm, op_put_to_scope
op_ret, and op_get_from_scope), DFG and FTL changes are not necessary. This patch also drops data structures and implementations for the old generator,
op_resume, op_save implementations and GeneratorFrame.

Note that this patch does not leverage the recent multi entrypoints support in B3. After this patch is introduced, we will submit a new patch that leverages the multi
entrypoints for generator's resume and sees the performance gain.

Microbenchmarks related to generators show up to 2.9x improvements.

Baseline Patched

generator-fib 102.0116+-3.2880 34.9670+-0.2221 definitely 2.9174x faster
generator-sunspider-access-nsieve 5.8596+-0.0371 4.9051+-0.0720 definitely 1.1946x faster
generator-with-several-types 332.1478+-4.2425 124.6642+-2.4826 definitely 2.6643x faster

<geometric> 58.2998+-0.7758 27.7425+-0.2577 definitely 2.1015x faster

In ES6SampleBench's Basic, we can observe 41% improvement (Macbook Pro).

Baseline:

Geometric Mean Result: 133.55 ms +- 4.49 ms

Benchmark First Iteration Worst 2% Steady State
Air 54.03 ms +- 7.51 ms 29.06 ms +- 3.13 ms 2276.59 ms +- 61.17 ms
Basic 30.18 ms +- 1.86 ms 18.85 ms +- 0.45 ms 2851.16 ms +- 41.87 ms

Patched:

Geometric Mean Result: 121.78 ms +- 3.96 ms

Benchmark First Iteration Worst 2% Steady State
Air 52.09 ms +- 6.89 ms 29.59 ms +- 3.16 ms 2239.90 ms +- 54.60 ms
Basic 29.28 ms +- 1.46 ms 16.26 ms +- 0.66 ms 2025.15 ms +- 38.56 ms

[1]: https://bugs.webkit.org/show_bug.cgi?id=159281

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • builtins/GeneratorPrototype.js:

(globalPrivate.generatorResume):

  • bytecode/BytecodeBasicBlock.cpp:

(JSC::BytecodeBasicBlock::shrinkToFit):
(JSC::BytecodeBasicBlock::computeImpl):
(JSC::BytecodeBasicBlock::compute):
(JSC::isBranch): Deleted.
(JSC::isUnconditionalBranch): Deleted.
(JSC::isTerminal): Deleted.
(JSC::isThrow): Deleted.
(JSC::linkBlocks): Deleted.
(JSC::computeBytecodeBasicBlocks): Deleted.

  • bytecode/BytecodeBasicBlock.h:

(JSC::BytecodeBasicBlock::isEntryBlock):
(JSC::BytecodeBasicBlock::isExitBlock):
(JSC::BytecodeBasicBlock::leaderOffset):
(JSC::BytecodeBasicBlock::totalLength):
(JSC::BytecodeBasicBlock::offsets):
(JSC::BytecodeBasicBlock::successors):
(JSC::BytecodeBasicBlock::index):
(JSC::BytecodeBasicBlock::addSuccessor):
(JSC::BytecodeBasicBlock::BytecodeBasicBlock):
(JSC::BytecodeBasicBlock::addLength):
(JSC::BytecodeBasicBlock::leaderBytecodeOffset): Deleted.
(JSC::BytecodeBasicBlock::totalBytecodeLength): Deleted.
(JSC::BytecodeBasicBlock::bytecodeOffsets): Deleted.
(JSC::BytecodeBasicBlock::addBytecodeLength): Deleted.

  • bytecode/BytecodeGeneratorification.cpp: Added.

(JSC::BytecodeGeneratorification::BytecodeGeneratorification):
(JSC::BytecodeGeneratorification::graph):
(JSC::BytecodeGeneratorification::yields):
(JSC::BytecodeGeneratorification::enterPoint):
(JSC::BytecodeGeneratorification::storageForGeneratorLocal):
(JSC::GeneratorLivenessAnalysis::GeneratorLivenessAnalysis):
(JSC::GeneratorLivenessAnalysis::computeDefsForBytecodeOffset):
(JSC::GeneratorLivenessAnalysis::computeUsesForBytecodeOffset):
(JSC::GeneratorLivenessAnalysis::run):
(JSC::BytecodeGeneratorification::run):
(JSC::performGeneratorification):

  • bytecode/BytecodeGeneratorification.h: Copied from Source/JavaScriptCore/bytecode/BytecodeLivenessAnalysisInlines.h.
  • bytecode/BytecodeGraph.h: Added.

(JSC::BytecodeGraph::codeBlock):
(JSC::BytecodeGraph::instructions):
(JSC::BytecodeGraph::basicBlocksInReverseOrder):
(JSC::BytecodeGraph::blockContainsBytecodeOffset):
(JSC::BytecodeGraph::findBasicBlockForBytecodeOffset):
(JSC::BytecodeGraph::findBasicBlockWithLeaderOffset):
(JSC::BytecodeGraph::size):
(JSC::BytecodeGraph::at):
(JSC::BytecodeGraph::operator[]):
(JSC::BytecodeGraph::begin):
(JSC::BytecodeGraph::end):
(JSC::BytecodeGraph::first):
(JSC::BytecodeGraph::last):
(JSC::BytecodeGraph<Block>::BytecodeGraph):

  • bytecode/BytecodeList.json:
  • bytecode/BytecodeLivenessAnalysis.cpp:

(JSC::BytecodeLivenessAnalysis::BytecodeLivenessAnalysis):
(JSC::BytecodeLivenessAnalysis::computeDefsForBytecodeOffset):
(JSC::BytecodeLivenessAnalysis::computeUsesForBytecodeOffset):
(JSC::BytecodeLivenessAnalysis::getLivenessInfoAtBytecodeOffset):
(JSC::BytecodeLivenessAnalysis::computeFullLiveness):
(JSC::BytecodeLivenessAnalysis::computeKills):
(JSC::BytecodeLivenessAnalysis::dumpResults):
(JSC::BytecodeLivenessAnalysis::compute):
(JSC::isValidRegisterForLiveness): Deleted.
(JSC::getLeaderOffsetForBasicBlock): Deleted.
(JSC::findBasicBlockWithLeaderOffset): Deleted.
(JSC::blockContainsBytecodeOffset): Deleted.
(JSC::findBasicBlockForBytecodeOffset): Deleted.
(JSC::stepOverInstruction): Deleted.
(JSC::computeLocalLivenessForBytecodeOffset): Deleted.
(JSC::computeLocalLivenessForBlock): Deleted.
(JSC::BytecodeLivenessAnalysis::runLivenessFixpoint): Deleted.

  • bytecode/BytecodeLivenessAnalysis.h:
  • bytecode/BytecodeLivenessAnalysisInlines.h:

(JSC::isValidRegisterForLiveness):
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::stepOverInstruction):
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::computeLocalLivenessForBytecodeOffset):
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::computeLocalLivenessForBlock):
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::getLivenessInfoAtBytecodeOffset):
(JSC::BytecodeLivenessPropagation<DerivedAnalysis>::runLivenessFixpoint):

  • bytecode/BytecodeRewriter.cpp: Added.

(JSC::BytecodeRewriter::applyModification):
(JSC::BytecodeRewriter::execute):
(JSC::BytecodeRewriter::adjustJumpTargetsInFragment):
(JSC::BytecodeRewriter::insertImpl):
(JSC::BytecodeRewriter::adjustJumpTarget):

  • bytecode/BytecodeRewriter.h: Added.

(JSC::BytecodeRewriter::InsertionPoint::InsertionPoint):
(JSC::BytecodeRewriter::InsertionPoint::operator<):
(JSC::BytecodeRewriter::InsertionPoint::operator==):
(JSC::BytecodeRewriter::Insertion::length):
(JSC::BytecodeRewriter::Fragment::Fragment):
(JSC::BytecodeRewriter::Fragment::appendInstruction):
(JSC::BytecodeRewriter::BytecodeRewriter):
(JSC::BytecodeRewriter::insertFragmentBefore):
(JSC::BytecodeRewriter::insertFragmentAfter):
(JSC::BytecodeRewriter::removeBytecode):
(JSC::BytecodeRewriter::graph):
(JSC::BytecodeRewriter::adjustAbsoluteOffset):
(JSC::BytecodeRewriter::adjustJumpTarget):
(JSC::BytecodeRewriter::calculateDifference):

  • bytecode/BytecodeUseDef.h:

(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::handlerForIndex):
(JSC::CodeBlock::shrinkToFit):
(JSC::CodeBlock::valueProfileForBytecodeOffset):
(JSC::CodeBlock::livenessAnalysisSlow):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::isConstantRegisterIndex):
(JSC::CodeBlock::livenessAnalysis):
(JSC::CodeBlock::liveCalleeLocalsAtYield): Deleted.

  • bytecode/HandlerInfo.h:

(JSC::HandlerInfoBase::handlerForIndex):

  • bytecode/Opcode.h:

(JSC::isBranch):
(JSC::isUnconditionalBranch):
(JSC::isTerminal):
(JSC::isThrow):

  • bytecode/PreciseJumpTargets.cpp:

(JSC::getJumpTargetsForBytecodeOffset):
(JSC::computePreciseJumpTargetsInternal):
(JSC::computePreciseJumpTargets):
(JSC::recomputePreciseJumpTargets):
(JSC::findJumpTargetsForBytecodeOffset):

  • bytecode/PreciseJumpTargets.h:
  • bytecode/PreciseJumpTargetsInlines.h: Added.

(JSC::extractStoredJumpTargetsForBytecodeOffset):

  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::handlerForBytecodeOffset):
(JSC::UnlinkedCodeBlock::handlerForIndex):
(JSC::UnlinkedCodeBlock::applyModification):

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedStringJumpTable::offsetForValue):
(JSC::UnlinkedCodeBlock::numCalleeLocals):

  • bytecode/VirtualRegister.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitComplexPopScopes):
(JSC::prepareJumpTableForStringSwitch):
(JSC::BytecodeGenerator::emitYieldPoint):
(JSC::BytecodeGenerator::emitSave): Deleted.
(JSC::BytecodeGenerator::emitResume): Deleted.
(JSC::BytecodeGenerator::emitGeneratorStateLabel): Deleted.
(JSC::BytecodeGenerator::beginGenerator): Deleted.
(JSC::BytecodeGenerator::endGenerator): Deleted.

  • bytecompiler/BytecodeGenerator.h:

(JSC::BytecodeGenerator::generatorStateRegister):
(JSC::BytecodeGenerator::generatorValueRegister):
(JSC::BytecodeGenerator::generatorResumeModeRegister):
(JSC::BytecodeGenerator::generatorFrameRegister):

  • bytecompiler/NodesCodegen.cpp:

(JSC::FunctionNode::emitBytecode):

  • dfg/DFGOperations.cpp:
  • interpreter/Interpreter.cpp:

(JSC::findExceptionHandler):
(JSC::GetCatchHandlerFunctor::operator()):
(JSC::UnwindFunctor::operator()):

  • interpreter/Interpreter.h:
  • interpreter/InterpreterInlines.h: Copied from Source/JavaScriptCore/bytecode/PreciseJumpTargets.h.

(JSC::Interpreter::getOpcodeID):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):

  • jit/JIT.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_save): Deleted.
(JSC::JIT::emit_op_resume): Deleted.

  • llint/LowLevelInterpreter.asm:
  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::parseGeneratorFunctionSourceElements):
(JSC::Parser<LexerType>::createGeneratorParameters):

  • parser/Parser.h:
  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL): Deleted.

  • runtime/CommonSlowPaths.h:
  • runtime/GeneratorFrame.cpp: Removed.

(JSC::GeneratorFrame::GeneratorFrame): Deleted.
(JSC::GeneratorFrame::finishCreation): Deleted.
(JSC::GeneratorFrame::createStructure): Deleted.
(JSC::GeneratorFrame::create): Deleted.
(JSC::GeneratorFrame::save): Deleted.
(JSC::GeneratorFrame::resume): Deleted.
(JSC::GeneratorFrame::visitChildren): Deleted.

  • runtime/GeneratorFrame.h: Removed.

(JSC::GeneratorFrame::locals): Deleted.
(JSC::GeneratorFrame::localAt): Deleted.
(JSC::GeneratorFrame::offsetOfLocals): Deleted.
(JSC::GeneratorFrame::allocationSizeForLocals): Deleted.

  • runtime/JSGeneratorFunction.h:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

Source/WTF:

  • wtf/FastBitVector.h:

(WTF::FastBitVector::FastBitVector):

3:27 PM Changeset in webkit [204993] by jiewen_tan@apple.com
  • 5 edits
    13 adds in trunk/LayoutTests

Unreviewed, rebase iOS simulator WK1 fast tests

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk1/fast/attachment/attachment-select-on-click-expected.txt: Added.
  • platform/ios-simulator-wk1/fast/block/float/overhanging-tall-block-expected.txt: Added.
  • platform/ios-simulator-wk1/fast/clip/014-expected.txt: Added.
  • platform/ios-simulator-wk1/fast/encoding/utf-16-big-endian-expected.txt:
  • platform/ios-simulator-wk1/fast/encoding/utf-16-little-endian-expected.txt:
  • platform/ios-simulator-wk1/fast/events/ghostly-mousemoves-in-subframe-expected.txt: Added.
  • platform/ios-simulator-wk1/fast/forms/form-element-geometry-expected.txt:
  • platform/ios-simulator-wk1/fast/replaced/width100percent-textarea-expected.txt: Added.
  • platform/ios-simulator-wk1/fast/shadow-dom/trusted-event-scoped-flags-expected.txt: Added.
3:11 PM Changeset in webkit [204992] by commit-queue@webkit.org
  • 16 edits
    2 adds in trunk

TryGetById should have a ValueProfile so that it can predict its output type
https://bugs.webkit.org/show_bug.cgi?id=160921

Patch by JF Bastien <jfbastien@apple.com> on 2016-08-25
Reviewed by Saam Barati.

JSTests:

  • microbenchmarks/try-get-by-id-basic.js: Added.

(const.check):
(const.bench.f.const.fooPlusBar.createBuiltin):

  • microbenchmarks/try-get-by-id-polymorphic.js: Added.

(const.check):
(fooPlusBar.createBuiltin):
(bench):

Source/JavaScriptCore:

Add a ValueProfile to TryGetById, and make sure DFG picks it up.

A microbenchmark for perfectly predicted computation shows a 20%
runtime reduction with no hit if the prediction goes polymorphic.

  • bytecode/BytecodeList.json:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::finishCreation):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitTryGetById):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasHeapPrediction):

  • dfg/DFGPredictionPropagationPhase.cpp:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emit_op_try_get_by_id):

  • jit/JITPropertyAccess32_64.cpp:

(JSC::JIT::emit_op_try_get_by_id):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::LLINT_SLOW_PATH_DECL):

  • llint/LowLevelInterpreter.asm:

Source/WTF:

Add WTF_CONCAT to StdLibExtras.h

  • wtf/StdLibExtras.h:
3:11 PM Changeset in webkit [204991] by Simon Fraser
  • 2 edits
    2 adds in trunk/LayoutTests

WK1 Sierra: LayoutTests fast/html/marquee-scroll.html and fast/inline-block/003.html failing
rdar://problem/28017216

This test is sensitive to how WK1 does layouts as a result of updateScrollbars(),
giving different results in WK1 and WK1. Land Sierra results, and mark the test
as failing on earlier OS versions.

  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk1/fast/inline-block/003-expected.txt: Added.
3:02 PM Changeset in webkit [204990] by achristensen@apple.com
  • 2 edits in trunk/Tools

Fix URLParserTest with GuardMalloc
https://bugs.webkit.org/show_bug.cgi?id=161214
rdar://problem/28014390

Reviewed by Tim Horton.

The CString returned by String::utf8 was going out of scope before we were doing a string comparison on its data.
This just does the comparison of the CStrings instead to keep them in scope during the comparison.

  • TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::eq):
(TestWebKitAPI::checkURL):
(TestWebKitAPI::checkURLDifferences):
(TestWebKitAPI::s): Deleted.

3:01 PM Changeset in webkit [204989] by Wenson Hsieh
  • 6 edits in trunk

Dragging against the end of the inline media scrubber causes the media scrubber to hide
https://bugs.webkit.org/show_bug.cgi?id=161207

Reviewed by Eric Carlson.

Source/WebCore:

Previously, we would re-enable behavior restrictions when firing an ended event. However, if the ended event is
caused by the user seeking to the end of the video, the media controls would be taken away from under the user.
To prevent this, we don't add the relevant behavior restrictions upon media ended if media was seeking before
firing the event.

Tweaked an existing WebKit API test to cover this change.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::addBehaviorRestrictionsOnEndIfNecessary):

  • html/HTMLMediaElement.h:
  • html/MediaElementSession.cpp:

(WebCore::MediaElementSession::canControlControlsManager):

Tools:

Tweaks an existing WebKit API test covering this behavior change. After some discussion, rather than hide media
controls in this case, we should actually continue showing them. This is because seeking due to user gestures
similar to "scrubbing" are indistinguishable from gestures that immediately seek to the end.

  • TestWebKitAPI/Tests/WebKit2Cocoa/VideoControlsManager.mm:

(TestWebKitAPI::TEST):

2:59 PM Changeset in webkit [204988] by bshafiei@apple.com
  • 9 edits in tags/Safari-603.1.3

Merge r204986. rdar://problem/28015060

2:57 PM Changeset in webkit [204987] by akling@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION: RELEASE_ASSERT in ResourceUsageThread::platformThreadBody when ASan is enabled
<https://webkit.org/b/161203>
<rdar://problem/28011251>

Reviewed by Joseph Pecoraro.

  • page/cocoa/ResourceUsageThreadCocoa.mm:

(WebCore::ResourceUsageThread::platformThreadBody): Remove overly optimistic assertions about
"GC owned" memory never being higher than total malloc memory usage. This accounting is not
really exact and pretending otherwise will just lead to crashes.

  • html/HTMLCanvasElement.cpp:

(WebCore::HTMLCanvasElement::externalMemoryCost): Hook up HTMLCanvasElement to the ImageBuffer
helper for reporting external memory cost. This makes accounting slightly more correct.

2:48 PM Changeset in webkit [204986] by Chris Dumez
  • 9 edits in trunk

Regression(r203623): Breaks App Store application
https://bugs.webkit.org/show_bug.cgi?id=161206
<rdar://problem/28015060>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add quirks for the App Store application so that we log an error message
when passing a Document node to Window.getComputedStyle() instead of
throwing an exception.

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::getComputedStyle):

  • page/DOMWindow.h:
  • page/DOMWindow.idl:
  • platform/RuntimeApplicationChecks.h:
  • platform/RuntimeApplicationChecks.mm:

(WebCore::MacApplication::isAppStore):

LayoutTests:

Rebaseline existing test as the exception message is slightly different.

  • fast/dom/Window/getComputedStyle-missing-parameter-expected.txt:
  • fast/dom/Window/getComputedStyle-missing-parameter.html:
1:53 PM Changeset in webkit [204985] by andersca@apple.com
  • 19 edits
    1 delete in trunk/Source/WebKit2

Remove some more MessageRecorder gunk
https://bugs.webkit.org/show_bug.cgi?id=161209

Reviewed by Tim Horton.

  • DatabaseProcess/DatabaseProcess.h:
  • DatabaseProcess/DatabaseToWebProcessConnection.h:
  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkProcess.h:
  • Platform/IPC/Connection.h:
  • Platform/IPC/ProcessType.h: Removed.
  • PluginProcess/PluginProcess.h:
  • PluginProcess/WebProcessConnection.h:
  • UIProcess/Databases/DatabaseProcessProxy.h:
  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/WebProcessProxy.h:
  • WebKit2.xcodeproj/project.pbxproj:
  • WebProcess/Databases/WebToDatabaseProcessConnection.h:
  • WebProcess/Network/NetworkProcessConnection.h:
  • WebProcess/Plugins/PluginProcessConnection.h:
  • WebProcess/WebPage/WebInspector.h:
  • WebProcess/WebPage/WebInspectorUI.h:
  • WebProcess/WebProcess.h:
12:20 PM Changeset in webkit [204984] by jiewen_tan@apple.com
  • 2 edits
    3 adds in trunk/LayoutTests

Unreviewed, rebase iOS simulator WK1 fast/css tests

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk1/fast/css/layerZOrderCrash-expected.txt: Added.
  • platform/ios-simulator-wk1/fast/css/viewport-units-dynamic-expected.txt: Added.
  • platform/ios-simulator-wk1/fast/css/word-space-extra-expected.txt: Added.
12:18 PM Changeset in webkit [204983] by commit-queue@webkit.org
  • 12 edits
    2 adds in trunk

REGRESSION (r203378): [iOS] The PDF image is rendered stretched if a sub image of it is cached first
https://bugs.webkit.org/show_bug.cgi?id=160617

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2016-08-25
Reviewed by Tim Horton.

Source/WebCore:

When caching only a sub-image of the PDF ensure the source rectangle starts
at the top-left of the cached sub-image rectangle. When drawing the cached
sub-image to the destination context ensure the destination rectangle is the
sub-image rectangle so no stretching or shrinking happens.

Test: fast/images/cached-clipped-pdf.html

  • page/Settings.cpp:

(WebCore::Settings::Settings):
(WebCore::Settings::setCachedPDFImageEnabled): Deleted.

  • page/Settings.h:

(WebCore::Settings::isCachedPDFImageEnabled): Deleted.

  • page/Settings.in:

Change the boolean setting CachedPDFImageEnabled to be enum property and
rename it PDFImageCachingPolicy. Allow the "PDFImageCachingBelowMemoryLimit"
option to be available on a;; platforms. The "PDFImageCachingClipBoundsOnly"
option is added for testing purpose. If forces recaching the PDF with each
draw and it sets the cached image rectangle to the clipping rectangle.

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::PDFDocumentImage::setPdfImageCachingPolicy): Take an enum instead of boolean.
(WebCore::cachedImageRect):
(WebCore::PDFDocumentImage::decodedSizeChanged): Enable PDFImageCachingBelowMemoryLimit
on all platforms.
(WebCore::PDFDocumentImage::updateCachedImageIfNeeded): Fix the source rectangle
when caching a sub-image of the PDF.
(WebCore::PDFDocumentImage::draw): Fix the destination rectangle when drawing
a sub-image to the destination context.
(WebCore::PDFDocumentImage::setCachedPDFImageEnabled): Deleted.

  • platform/graphics/cg/PDFDocumentImage.h:
  • rendering/RenderImage.cpp:

(WebCore::RenderImage::paintIntoRect):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setPDFImageCachingPolicy):
(WebCore::InternalSettings::setCachedPDFImageEnabled): Deleted.

  • testing/InternalSettings.h:
  • testing/InternalSettings.idl:

Change the internal setting CachedPDFImageEnabled to PDFImageCachingPolicy.

LayoutTests:

  • fast/images/cached-clipped-pdf-expected.html: Added.
  • fast/images/cached-clipped-pdf.html: Added.
  • fast/images/displaced-non-cached-pdf.html:
12:02 PM Changeset in webkit [204982] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Skipping imported/w3c/web-platform-tests/url/url-setters.html because it asserts.
https://bugs.webkit.org/show_bug.cgi?id=161191

Unreviewed test gardening.

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/mac-wk1/TestExpectations:
11:45 AM Changeset in webkit [204981] by bshafiei@apple.com
  • 3 edits in tags/Safari-603.1.3/Source/WebKit/mac

Merge r204974. rdar://problem/27959937

11:41 AM Changeset in webkit [204980] by Alan Bujtas
  • 3 edits
    2 adds in trunk

Infinite recursion crash in WebCore::RenderBlockFlow::layoutBlock
https://bugs.webkit.org/show_bug.cgi?id=139474
<rdar://problem/27705190>

Reviewed by David Hyatt.

Source/WebCore:

We should just give up trying to avoid widow when the page is too small to break line.

Test: fast/multicol/assert-on-small-page-height-with-widow.html

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::clearShouldBreakAtLineToAvoidWidowIfNeeded):
(WebCore::RenderBlockFlow::adjustLinePositionForPagination):

  • rendering/RenderBlockFlow.h:

LayoutTests:

  • fast/multicol/assert-on-small-page-height-with-widow-expected.txt: Added.
  • fast/multicol/assert-on-small-page-height-with-widow.html: Added.
11:39 AM Changeset in webkit [204979] by Csaba Osztrogonác
  • 2 edits in trunk/Source/JavaScriptCore

generate-js-builtins.py should generate platform independent files
https://bugs.webkit.org/show_bug.cgi?id=161196

Reviewed by Mark Lam.

  • Scripts/generate-js-builtins.py: Files should be processed in fixed order.
11:36 AM Changeset in webkit [204978] by weinig@apple.com
  • 5 edits in trunk/Source/WebCore

Add the ability to override the implementation name of IDL enums and dictionaries
https://bugs.webkit.org/show_bug.cgi?id=161185

Reviewed by Anders Carlsson.

  • bindings/scripts/CodeGenerator.pm:

(ProcessDocument):
Build a dictionary of IDL name -> implementation name overrides
for enums and dictionaries up front based on ImplementedAs extended
attribute.

(HasEnumImplementationNameOverride):
(GetEnumImplementationNameOverride):
(HasDictionaryImplementationNameOverride):
(GetDictionaryImplementationNameOverride):
Expose predicate and getter for name overrides.

  • bindings/scripts/CodeGeneratorJS.pm:

(GetEnumerationClassName):
(GetDictionaryClassName):
Use the override names as necessary.

  • bindings/scripts/test/TestObj.idl:

Add tests for enums and dictionaries with ImplementedAs extended
attributes.

11:23 AM Changeset in webkit [204977] by achristensen@apple.com
  • 10 edits in trunk/Source

Don't store networkLoadTiming in the disk cache
https://bugs.webkit.org/show_bug.cgi?id=161161

Patch by Johan K. Jensen <johan_jensen@apple.com> on 2016-08-25
Reviewed by Antti Koivisto.

Source/WebCore:

No functionality changed. So, no new tests.

  • platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::encode):
(WebCore::ResourceResponseBase::decode):

Source/WebKit2:

  • NetworkProcess/cache/NetworkCacheStorage.h: Updated version to 10.
  • NetworkProcess/cache/NetworkCacheDecoder.h:
  • NetworkProcess/cache/NetworkCacheEncoder.h:
  • Platform/IPC/Decoder.h:
  • Platform/IPC/Encoder.h:

Added isIPCDecoder/isIPCEncoder static members.

Source/WTF:

  • wtf/Forward.h:

Remove Encode and Decode forward declarations.

11:22 AM Changeset in webkit [204976] by achristensen@apple.com
  • 21 edits
    17 adds in trunk

Update the Resource Timing implementation
https://bugs.webkit.org/show_bug.cgi?id=161068

Patch by Johan K. Jensen <johan_jensen@apple.com> on 2016-08-25
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Added W3C Web Platform Tests for Resource Timing.

  • web-platform-tests/resource-timing/OWNERS: Added.
  • web-platform-tests/resource-timing/SyntheticResponse.py: Added.

(main):

  • web-platform-tests/resource-timing/iframe-setdomain.sub.html: Added.
  • web-platform-tests/resource-timing/resource-timing.html: Added.
  • web-platform-tests/resource-timing/resource-timing.js: Added.

(testCases.test):
(test):
(runNextCase):
(assertInvariants):
(assertResourceEntryInvariants):
(canonicalize):
(createUniqueQueryArgument):
(getSyntheticUrl):
(initiateFetch):
(window.onload):

  • web-platform-tests/resource-timing/resources/resource_timing_test0.css: Added.

(div#resource_link_css):

  • web-platform-tests/resource-timing/resources/resource_timing_test0.html: Added.
  • web-platform-tests/resource-timing/resources/resource_timing_test0.js: Added.
  • web-platform-tests/resource-timing/resources/resource_timing_test0.png: Added.
  • web-platform-tests/resource-timing/resources/resource_timing_test0.xml: Added.
  • web-platform-tests/resource-timing/resources/webperftestharness.js: Added.

(wp_test):
(test_namespace):
(test_timing_order):
(test_timing_equals):
(sleep_milliseconds):
(test_true):
(test_equals):
(test_greater_than):
(test_greater_or_equals):

  • web-platform-tests/resource-timing/test_resource_timing.html: Added.
  • web-platform-tests/resource-timing/test_resource_timing.js: Added.

(setup):
(resolve):
(switch.):
(switch.case.string_appeared_here.xmlhttp.onload):
(switch.default.element.onload):
(onload):
(poll_for_stylesheet_load.inner):
(poll_for_stylesheet_load):
(resource_load):

Source/WebCore:

Tests: imported/w3c/web-platform-tests/resource-timing/resource-timing.html

imported/w3c/web-platform-tests/resource-timing/test_resource_timing.html

Update the Resource Timing implementation for better compatibility with the Resource Timing API spec.
Use LoadTiming for general timing information about a resources load timeline.
Mark timestamps for newly loaded resources as well as cached resources.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::startLoadingMainResource):
StartTime and fetchStart should be equal initially.

  • loader/LoadTiming.cpp:

(WebCore::LoadTiming::LoadTiming): Moved member initialization out. Removed constructor.

  • loader/LoadTiming.h:

(WebCore::LoadTiming::markStartTimeAndFetchStart):
Mark startTime and fetchStart simultaneously.

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::init):
Mark the start time of resources.

  • loader/ResourceLoader.h:

(WebCore::ResourceLoader::loadTiming):
Add LoadTiming info to handle a resources load timing.

  • loader/ResourceTimingInformation.cpp:

(WebCore::ResourceTimingInformation::addResourceTiming):

  • loader/ResourceTimingInformation.h:

Only pass in the URL from the ResourceRequest.
Pass LoadTiming instead of timestamps.

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequestInternal):
Mark redirects.

(WebCore::SubresourceLoader::didFinishLoading):
Mark the responseEnd timestamp.
Add the ResourceEntry to the timeline before notifyDone is called.

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadDone):
Mark timestamps for cached resources and use them instead of a cached LoadTiming.

  • loader/cache/CachedResourceLoader.h:

(WebCore::CachedResourceLoader::resourceTimingInformation):
Add ResourceTimingInformation getter so SubresourceLoader.cpp can add entries before callbacks.

  • page/Performance.cpp:

(WebCore::Performance::addResourceTiming):

  • page/Performance.h:

Update signature: URLs and LoadTiming instead of timestamps.

  • page/PerformanceResourceTiming.cpp:

(WebCore::PerformanceResourceTiming::PerformanceResourceTiming):
(WebCore::PerformanceResourceTiming::redirectStart):
(WebCore::PerformanceResourceTiming::redirectEnd):
(WebCore::PerformanceResourceTiming::fetchStart):
(WebCore::PerformanceResourceTiming::domainLookupStart):
(WebCore::PerformanceResourceTiming::domainLookupEnd):
(WebCore::PerformanceResourceTiming::connectStart):
(WebCore::PerformanceResourceTiming::connectEnd):
(WebCore::PerformanceResourceTiming::requestStart):
(WebCore::PerformanceResourceTiming::responseStart):
(WebCore::PerformanceResourceTiming::responseEnd):
(WebCore::PerformanceResourceTiming::resourceTimeToDocumentMilliseconds):

  • page/PerformanceResourceTiming.h:

Update signatures and properties to use LoadTiming.
Use LoadTiming’s redirectStart/End, fetchStart, responseStart/End.
Make sure dns and connection timestamps are in increasing order, even when cached.

  • page/PerformanceResourceTiming.idl:

Add responseStart.

LayoutTests:

Skip resource outside of resource-folder.
Mark one test as flaky (see bug 161088).

  • resources/testharnessreport.js:

(self.testRunner.add_completion_callback):
Updated completion callback to wait for any other completion callbacks
before finishing, so the Resource Timing tests can cleanup first.
Enabled the ResourceTiming runtime flag.

11:21 AM Changeset in webkit [204975] by jiewen_tan@apple.com
  • 13 edits
    1 add in trunk/LayoutTests

Unreviewed, rebase iOS simulator WK1 fast/multicol tests

  • platform/ios-simulator-wk1/fast/multicol/overflow-unsplittable-expected.txt: Added.
  • platform/ios-simulator-wk1/fast/multicol/pagination/BottomToTop-bt-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/pagination/BottomToTop-lr-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/pagination/BottomToTop-rl-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/pagination/BottomToTop-tb-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/pagination/RightToLeft-bt-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/pagination/RightToLeft-lr-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/pagination/RightToLeft-rl-dynamic-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/pagination/RightToLeft-rl-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/pagination/RightToLeft-tb-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/vertical-rl/column-rules-expected.txt:
  • platform/ios-simulator-wk1/fast/multicol/vertical-rl/float-paginate-complex-expected.txt:
11:12 AM Changeset in webkit [204974] by achristensen@apple.com
  • 3 edits in trunk/Source/WebKit/mac

Re-export DOMException NSStrings after r204717
https://bugs.webkit.org/show_bug.cgi?id=161200
<rdar://problem/27959937>

Patch by Anders Carlsson <andersca@apple.com> on 2016-08-25
Reviewed by Alex Christensen.

  • DOM/ExceptionHandlers.mm:

(raiseDOMException):

  • WebKit.exp:
10:50 AM Changeset in webkit [204973] by Simon Fraser
  • 4 edits in trunk/LayoutTests

TestExpectations cleanup

Remove references to non-existant JS tests.

  • platform/ios-simulator/TestExpectations:
  • platform/mac-wk1/TestExpectations:
  • platform/mac/TestExpectations:
10:37 AM Changeset in webkit [204972] by andersca@apple.com
  • 4 edits in trunk/Source/WebCore

Simplify createMouseEvent in DragController
https://bugs.webkit.org/show_bug.cgi?id=161168

Reviewed by Dan Bernstein.

  • page/DragController.cpp:

(WebCore::createMouseEvent):

  • platform/DragData.cpp:

(WebCore::DragData::modifierKeyState): Deleted.

  • platform/DragData.h:
10:19 AM Changeset in webkit [204971] by dbates@webkit.org
  • 2 edits in trunk/Tools

Watch more things.

  • Scripts/webkitpy/common/config/watchlist:
10:08 AM Changeset in webkit [204970] by Chris Dumez
  • 5 edits in trunk/Source/WebCore

DOMTokenList.value should be a stringifier attribute
https://bugs.webkit.org/show_bug.cgi?id=161195

Reviewed by Darin Adler.

DOMTokenList.value should be a stringifier attribute:

No new tests, this change is not observable from the Web.

  • html/DOMTokenList.h:

(WebCore::DOMTokenList::toString): Deleted.

  • html/DOMTokenList.idl:
  • html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::iconSizes): Deleted.

  • html/HTMLLinkElement.h:
9:54 AM Changeset in webkit [204969] by dbates@webkit.org
  • 2 edits in trunk/Tools

Fix test failure on GTK Linux bots after <http://trac.webkit.org/changeset/204695>
(https://bugs.webkit.org/show_bug.cgi?id=148437)

Remove use of module File::Slurp as it is not part of the standard Perl 5 distribution
and is not installed on the GTK Linux bots.

  • Scripts/webkitperl/prepare-ChangeLog_unittest/generateFunctionLists.pl:

(writeFileWithContent): Added.

9:42 AM Changeset in webkit [204968] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html for mac-wk1 after r204935

Unreviewed test gardening.

  • platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
9:18 AM Changeset in webkit [204967] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip svg/animations/animate-text-nested-transforms.html on ios-simulator

Unreviewed test gardening.

  • platform/ios-simulator-wk2/TestExpectations:
9:18 AM Changeset in webkit [204966] by pvollan@apple.com
  • 2 edits in trunk/Tools

[Win] run-api-tests is failing.
https://bugs.webkit.org/show_bug.cgi?id=161140

Reviewed by Brent Fulgham.

Since the move constructor is called 3 more times on Windows, we will have 3 more destructor calls.

  • TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:

(TestWebKitAPI::TEST):

9:00 AM Changeset in webkit [204965] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Marking imported/w3c/web-platform-tests/url/url-setters.html as failing on mac and ios-simulator wk1.
https://bugs.webkit.org/show_bug.cgi?id=161191

Unreviewed test gardening.

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/mac-wk1/TestExpectations:
8:58 AM Changeset in webkit [204964] by Csaba Osztrogonác
  • 2 edits in trunk/Source/WebCore

[Mac][cmake] Unreviewed speculative buildfix after r204852, just for fun.

  • PlatformMac.cmake:
8:46 AM Changeset in webkit [204963] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html for mac after r204935

Unreviewed test gardening.

  • platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
8:42 AM Changeset in webkit [204962] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking gamepad/gamepad-timestamp.html as flaky on mac-wk2.
https://bugs.webkit.org/show_bug.cgi?id=161148

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
8:39 AM Changeset in webkit [204961] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit2

[GTK][Threaded Compositor] Several flaky tests due to differences in scrollbars
https://bugs.webkit.org/show_bug.cgi?id=160450

Reviewed by Michael Catanzaro.

The issue is that ThreadedCompositor::didChangeVisibleRect() dispatches the setVisibleContentsRect() call that
ends up in CompositingCoordinator. Since we're compositing the scrollbars as well, this visible contents rect
needs to encompass the complete width of the view, but that's not happening.
In case of non-overlay scrollbars, the scrollbars are clipped from this rect, but that doesn't prevent the
scrollbar overlay layers to be flushed and rendered. What does happen is that during tile creation in the
backing store the tiles that would normally intersect the visible rect of the view (if it were spanning over the
whole actual visible area) are sorted by distance to the visible rect.
The top of the two tiles used for the scrollbar is closer to the visible rect, so that gets created and filled
in first. The second tile is stored as pending for creation, and does get rendered at the point of the next
layer flush.

  • WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::setVisibleContentsRect): Update the visible rect taking into account
the non-overlay scrollbars before passing it to the compositor.

2:53 AM Changeset in webkit [204960] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening.

Update test expectations on Windows for failing tests. These failures are tracked in
https://bugs.webkit.org/show_bug.cgi?id=160447.

  • platform/win/TestExpectations:
12:45 AM Changeset in webkit [204959] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Unreviewed test gardening.

Update test expectations on Windows for failing tests. These failures are tracked in
https://bugs.webkit.org/show_bug.cgi?id=160447.

  • platform/win/TestExpectations:
12:04 AM Changeset in webkit [204958] by commit-queue@webkit.org
  • 9 edits
    1 add in trunk

NewRegexp should not prevent inlining
https://bugs.webkit.org/show_bug.cgi?id=154808

Patch by Caio Lima <Caio Lima> on 2016-08-25
Reviewed by Geoffrey Garen.

JSTests:

Added test where functions with NewRegExp can be inlined right now.

  • stress/new-regex-inline.js: Added.

(assert):
(testRegexpInline):
(toInlineGlobal):
(withRegexp):
(inlineRegexpNotGlobal):
(toInlineRecursive):
(regexpContainsRecursive):

Source/JavaScriptCore:

In this patch we are changing the current mechanism used to represent
RegExp in NewRegexp nodes. We are changing the use of a index
pointing to RegExp in
CodeBlock->m_unlinkedCodeBlock->m_rareData->m_regexps as the operand of
NewRegexp node to RegExp address as the operand. To make sure that RegExp* is
pointing to a valid object, we are using m_graph.freezeStrong
mechanism.

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGCapabilities.cpp:

(JSC::DFG::capabilityLevel):

  • dfg/DFGNode.h:

(JSC::DFG::Node::hasCellOperand):
(JSC::DFG::Node::hasRegexpIndex): Deleted.
(JSC::DFG::Node::regexpIndex): Deleted.

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNewRegexp):

Aug 24, 2016:

11:51 PM Changeset in webkit [204957] by pvollan@apple.com
  • 2 edits in trunk/Tools

[Win] run-api-tests is failing.
https://bugs.webkit.org/show_bug.cgi?id=161140

Reviewed by Brent Fulgham.

The number of times the move constructor is called is different on Windows in this test. This seems
to be caused by differences in MSVC's implementation of lambdas or std functions like std::make_tuple.

  • TestWebKitAPI/Tests/WTF/CrossThreadTask.cpp:

(TestWebKitAPI::TEST):

11:31 PM Changeset in webkit [204956] by fred.wang@free.fr
  • 4 edits in trunk/Source/WebCore

Do not store layout parameters on the RenderMathMLRoot class
https://bugs.webkit.org/show_bug.cgi?id=161132

Patch by Frederic Wang <fwang@igalia.com> on 2016-08-24
Reviewed by Darin Adler.

Storing layout parameters on the RenderMathMLRoot class is not really needed since reading
the parameters from the MATH table is not too expensive and updateStyle() is currently always
called in layoutBlock() and computePreferredLogicalWidths(). Most of these parameters are
actually only used in layoutBlock(). We separate horizontal and vertical parameters since
the latter are not needed for preferred width calculations. This removes the need for calling
an updateStyle functions and may also fix update issues when zooming in or out.

No new tests, already covered by existing tests.

  • rendering/mathml/MathMLStyle.cpp:

(WebCore::MathMLStyle::updateStyleIfNeeded): No need to update layout parameters for the
RenderMathMLRoot class.

  • rendering/mathml/RenderMathMLRoot.cpp:

(WebCore::RenderMathMLRoot::styleDidChange): No need to update layout parameters.
(WebCore::RenderMathMLRoot::horizontalParameters): Move code from updateStyle to retrieve the
horizontal parameters.
(WebCore::RenderMathMLRoot::verticalParameters): Ditto for vertical parameters.
(WebCore::RenderMathMLRoot::computePreferredLogicalWidths): Call horizontalParameters() to
get the kernings of the index instead of calling updateStyle().
(WebCore::RenderMathMLRoot::layoutBlock): Call horizontalParameters() and
verticalParameters() to get the layout parameters instead of calling updateStyle().
(WebCore::RenderMathMLRoot::paint): Call horizontalParameters() and verticalParameters()
to get the layout parameters.
(WebCore::RenderMathMLRoot::updateFromElement): Deleted. No need to call updateStyle().
(WebCore::RenderMathMLRoot::updateStyle): Deleted.

  • rendering/mathml/RenderMathMLRoot.h: Do not override updateFromElement(). Replace some

layout parameters stored on the class with struct and helper functions to manipulate them.

11:25 PM Changeset in webkit [204955] by Simon Fraser
  • 2 edits in trunk/Tools

Fix iOS DRT build.

  • DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::zoomToScale):

11:07 PM Changeset in webkit [204954] by Chris Dumez
  • 6 edits in trunk

WorkerLocation.prototype.toString() should be enumerable
https://bugs.webkit.org/show_bug.cgi?id=161183

Reviewed by Ryosuke Niwa.

Source/WebCore:

WorkerLocation.prototype.toString() should be enumerable:

No new tests, updated existing test.

  • workers/WorkerLocation.h:

(WebCore::WorkerLocation::toString): Deleted.

  • workers/WorkerLocation.idl:

Also use USVString string type instead of DOMString to match the
specification. There is no behavior change because those attributes
are readonly.

LayoutTests:

Add layout test coverage.

  • fast/workers/resources/worker-location.js:
  • fast/workers/worker-location-expected.txt:
8:06 PM Changeset in webkit [204953] by Chris Dumez
  • 9 edits in trunk

Location.toString() should be enumerable
https://bugs.webkit.org/show_bug.cgi?id=161179

Reviewed by Geoffrey Garen.

Source/WebCore:

Location.toString() should be enumerable as per:

This patch stops hard-coding the toString() operation on the Location
interface and makes the 'href' attribute a stringifier attribute instead,
as per the specification. The generated toString() has the same behavior
as it used to but it is now enumerable, as it should.

No new tests, updated existing test.

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::toStringFunction): Deleted.

  • page/Location.idl:

LayoutTests:

Update existing tests and add layout test coverage.

  • fast/dom/Window/window-appendages-cleared-expected.txt:
  • fast/dom/toString_attributes-expected.txt:
  • fast/dom/toString_attributes.html:
  • js/dom/toString-dontEnum-expected.txt:
  • js/dom/toString-dontEnum.html:
7:40 PM Changeset in webkit [204952] by commit-queue@webkit.org
  • 11 edits
    2 adds in trunk

Implement CSS.escape as per CSSOM
https://bugs.webkit.org/show_bug.cgi?id=126337

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-24
Reviewed by Dean Jackson.

Source/WebCore:

Test: css3/escape-dom-api.html

  • css/CSSOMUtils.cpp:

(WebCore::serializeIdentifier):
Update serialization to match the latest version of the spec:
<https://drafts.csswg.org/cssom/#serialize-an-identifier>
New handling for 0x0, 0x7f, just "-", and "--" is now allowed.

  • css/DOMCSSNamespace.cpp:

(WebCore::DOMCSSNamespace::escape):

  • css/DOMCSSNamespace.h:
  • css/DOMCSSNamespace.idl:

New CSS.escape method.

LayoutTests:

CSS.escape is part of the CSSOM Spec:
https://drafts.csswg.org/cssom/#the-css.escape%28%29-method

Tests:
https://github.com/mathiasbynens/CSS.escape/blob/master/tests/tests.js

Change is based on the Blink change (patch by <rob.buis@samsung.com>) and follow-ups:
<https://chromium.googlesource.com/chromium/blink/+/c1a5ffdc924b089e70cd33ad2726b58cc8312abe>

  • css3/escape-dom-api-expected.txt: Added.
  • css3/escape-dom-api.html: Added.

New tests, taken from the polyfill.

  • fast/css/parsing-css-nonascii-expected.txt:
  • fast/css/parsing-css-nonascii.html:
  • fast/css/selector-text-escape.html:

Update existing tests now that 0x7f is escaped.

  • js/dom/function-removed-after-parsing-expected.txt:
  • js/dom/function-removed-after-parsing.html:

Rename use of CSS.escape here now that CSS.escape exists.

6:55 PM Changeset in webkit [204951] by Alan Bujtas
  • 4 edits
    2 adds in trunk

ASSERTION FAILED: contentSize >= 0 in WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax
https://bugs.webkit.org/show_bug.cgi?id=155700
<rdar://problem/27720727>

Reviewed by David Hyatt.

Source/WebCore:

RenderBox::m_minPreferredLogicalWidth/m_maxPreferredLogicalWidth don't need special initial value since
preferredLogicalWidthsDirty flag guards them. -1 as initial value can cause problems for renderers that don't
override RenderBox::computePreferredLogicalWidths().

Test: fast/ruby/assert-when-content-size-is-negative.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::RenderBox):
(WebCore::RenderBox::dirtyLineBoxes):
(WebCore::RenderBox::deleteLineBoxWrapper):

  • rendering/RenderBox.h:

LayoutTests:

  • fast/ruby/assert-when-content-size-is-negative-expected.txt: Added.
  • fast/ruby/assert-when-content-size-is-negative.html: Added.
6:42 PM Changeset in webkit [204950] by bshafiei@apple.com
  • 1 copy in tags/Safari-602.2.3

New tag.

6:24 PM Changeset in webkit [204949] by jiewen_tan@apple.com
  • 8 edits
    6 adds
    1 delete in trunk/LayoutTests

Unreviewed, rebase iOS simulator WK1 fast/text tests

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk1/fast/text/atsui-multiple-renderers-expected.txt:
  • platform/ios-simulator-wk1/fast/text/atsui-negative-spacing-features-expected.txt:
  • platform/ios-simulator-wk1/fast/text/atsui-spacing-features-expected.txt:
  • platform/ios-simulator-wk1/fast/text/font-weights-expected.txt: Added.
  • platform/ios-simulator-wk1/fast/text/international/khmer-selection-expected.txt: Added.
  • platform/ios-simulator-wk1/fast/text/system-font-weight-expected.txt: Added.
  • platform/ios-simulator-wk1/fast/text/tatechuyoko-expected.txt: Added.
  • platform/ios-simulator-wk1/fast/text/textIteratorNilRenderer-expected.txt:
  • platform/ios-simulator-wk1/fast/text/wbr-expected.txt:
  • platform/ios-simulator-wk1/fast/text/word-space-expected.txt: Added.
  • platform/ios-simulator-wk2/fast/text/decorations-with-text-combine-expected.txt: Removed.
  • platform/ios-simulator/fast/text/decorations-with-text-combine-expected.txt:
6:22 PM Changeset in webkit [204948] by achristensen@apple.com
  • 5 edits
    37 adds in trunk

Import w3c URL tests
https://bugs.webkit.org/show_bug.cgi?id=161177

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

  • web-platform-tests/url: Added.
  • web-platform-tests/url/OWNERS: Added.
  • web-platform-tests/url/README.md: Added.
  • web-platform-tests/url/a-element-expected.txt: Added.
  • web-platform-tests/url/a-element-xhtml-expected.txt: Added.
  • web-platform-tests/url/a-element-xhtml.xhtml: Added.
  • web-platform-tests/url/a-element.html: Added.
  • web-platform-tests/url/a-element.js: Added.

(setup.async_test.string_appeared_here.setup.step):
(setBase):
(bURL):
(runURLTests):

  • web-platform-tests/url/historical-expected.txt: Added.
  • web-platform-tests/url/historical.html: Added.
  • web-platform-tests/url/historical.worker.js: Added.

(test):

  • web-platform-tests/url/interfaces-expected.txt: Added.
  • web-platform-tests/url/interfaces.html: Added.
  • web-platform-tests/url/setters_tests.json: Added.
  • web-platform-tests/url/url-constructor-expected.txt: Added.
  • web-platform-tests/url/url-constructor.html: Added.
  • web-platform-tests/url/url-domainToUnicode-expected.txt: Added.
  • web-platform-tests/url/url-domainToUnicode.html: Added.
  • web-platform-tests/url/url-setters-expected.txt: Added.
  • web-platform-tests/url/url-setters.html: Added.
  • web-platform-tests/url/urlsearchparams-append-expected.txt: Added.
  • web-platform-tests/url/urlsearchparams-append.html: Added.
  • web-platform-tests/url/urlsearchparams-constructor-expected.txt: Added.
  • web-platform-tests/url/urlsearchparams-constructor.html: Added.
  • web-platform-tests/url/urlsearchparams-delete-expected.txt: Added.
  • web-platform-tests/url/urlsearchparams-delete.html: Added.
  • web-platform-tests/url/urlsearchparams-get-expected.txt: Added.
  • web-platform-tests/url/urlsearchparams-get.html: Added.
  • web-platform-tests/url/urlsearchparams-getall-expected.txt: Added.
  • web-platform-tests/url/urlsearchparams-getall.html: Added.
  • web-platform-tests/url/urlsearchparams-has-expected.txt: Added.
  • web-platform-tests/url/urlsearchparams-has.html: Added.
  • web-platform-tests/url/urlsearchparams-set-expected.txt: Added.
  • web-platform-tests/url/urlsearchparams-set.html: Added.
  • web-platform-tests/url/urlsearchparams-stringifier-expected.txt: Added.
  • web-platform-tests/url/urlsearchparams-stringifier.html: Added.
  • web-platform-tests/url/urltestdata.json: Added.

Source/WebCore:

Tests: imported/w3c/web-platform-tests/url/a-element-xhtml.xhtml

imported/w3c/web-platform-tests/url/a-element.html
imported/w3c/web-platform-tests/url/historical.html
imported/w3c/web-platform-tests/url/interfaces.html
imported/w3c/web-platform-tests/url/url-constructor.html
imported/w3c/web-platform-tests/url/url-domainToUnicode.html
imported/w3c/web-platform-tests/url/url-setters.html
imported/w3c/web-platform-tests/url/urlsearchparams-append.html
imported/w3c/web-platform-tests/url/urlsearchparams-constructor.html
imported/w3c/web-platform-tests/url/urlsearchparams-delete.html
imported/w3c/web-platform-tests/url/urlsearchparams-get.html
imported/w3c/web-platform-tests/url/urlsearchparams-getall.html
imported/w3c/web-platform-tests/url/urlsearchparams-has.html
imported/w3c/web-platform-tests/url/urlsearchparams-set.html
imported/w3c/web-platform-tests/url/urlsearchparams-stringifier.html

  • platform/URL.cpp:

(WebCore::URL::setQuery):

LayoutTests:

Skip asserting test.

6:21 PM Changeset in webkit [204947] by benjamin@webkit.org
  • 14 edits
    1 add in trunk

[JSC] Make FRound work with any type
https://bugs.webkit.org/show_bug.cgi?id=161129

Reviewed by Geoffrey Garen.

JSTests:

  • stress/arith-fround-on-various-types.js: Added.

Source/JavaScriptCore:

Math.fround() does nothing with arguments past the first one
(https://tc39.github.io/ecma262/#sec-math.fround).
We can unify ArithFRound with the other single-input intrinsics.

Everything else is same old: if the input type is not a number,
be pessimistic about everything and do a C call.

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleIntrinsicCall):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

  • dfg/DFGNodeType.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileArithFRound):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileArithFRound):

5:46 PM Changeset in webkit [204946] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit2

cmake build broken by MessageRecorder removal
https://bugs.webkit.org/show_bug.cgi?id=161175

Patch by JF Bastien <jfbastien@apple.com> on 2016-08-24
Reviewed by Dean Jackson.

  • PlatformMac.cmake:
4:58 PM Changeset in webkit [204945] by Simon Fraser
  • 9 edits in trunk

[iOS DRT] Hook up uiController.zoomToScale() for DRT
https://bugs.webkit.org/show_bug.cgi?id=161173

Reviewed by Tim Horton.

Tools:

Make a UIWebScrollView subclass, DumpRenderTreeWebScrollView, which has an internal delegate to get
UIScrollView delegate callbacks. Store the zoomToScaleCompletionHandler on it.

UIScriptController::zoomToScale() has to bounce the zoom to the main thread (no poking UIKit from
the WebThread!), but queue up the callback first.

  • DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
  • DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:

(-[DumpRenderTreeWebScrollView initWithFrame:]):
(-[DumpRenderTreeWebScrollView dealloc]):
(-[DumpRenderTreeWebScrollView zoomToScale:animated:completionHandler:]):
(-[DumpRenderTreeWebScrollView completedZoomToScale]):
(-[DumpRenderTreeWebScrollViewDelegate initWithScrollView:]):
(-[DumpRenderTreeWebScrollViewDelegate viewForZoomingInScrollView:]): All UIScrollView delegates need to implement this.
(-[DumpRenderTreeWebScrollViewDelegate scrollViewDidEndZooming:withView:atScale:]):

  • DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::zoomToScale):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):

  • TestRunnerShared/UIScriptContext/UIScriptController.h:

(WTR::UIScriptController::context):

LayoutTests:

The one test in fast/zooming/ios works in DRT and WTR now.

  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/TestExpectations:
4:47 PM Changeset in webkit [204944] by jiewen_tan@apple.com
  • 34 edits
    1 add in trunk/LayoutTests

Unreviewed, rebase iOS simulator WK1 fast/table tests

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk1/fast/table/003-expected.txt:
  • platform/ios-simulator-wk1/fast/table/024-expected.txt:
  • platform/ios-simulator-wk1/fast/table/031-expected.txt:
  • platform/ios-simulator-wk1/fast/table/032-expected.txt:
  • platform/ios-simulator-wk1/fast/table/border-collapsing/004-expected.txt:
  • platform/ios-simulator-wk1/fast/table/border-collapsing/004-vertical-expected.txt:
  • platform/ios-simulator-wk1/fast/table/border-collapsing/bug14274-expected.txt:
  • platform/ios-simulator-wk1/fast/table/border-collapsing/cached-cell-append-expected.txt:
  • platform/ios-simulator-wk1/fast/table/border-collapsing/cached-cell-remove-expected.txt:
  • platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-cell-border-color-expected.txt:
  • platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-cell-sl-border-color-expected.txt:
  • platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-col-border-color-expected.txt:
  • platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-col-border-width-expected.txt:
  • platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-colgroup-border-color-expected.txt:
  • platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-colgroup-border-width-expected.txt:
  • platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-row-border-color-expected.txt:
  • platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-table-border-color-expected.txt:
  • platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-table-border-width-expected.txt:
  • platform/ios-simulator-wk1/fast/table/border-collapsing/cached-change-tbody-border-color-expected.txt:
  • platform/ios-simulator-wk1/fast/table/border-collapsing/collapsed-borders-adjoining-sections-vertical-rl-expected.txt:
  • platform/ios-simulator-wk1/fast/table/border-collapsing/collapsed-borders-painted-once-on-inner-cells-expected.txt:
  • platform/ios-simulator-wk1/fast/table/colspan-with-all-percent-cells-expected.txt:
  • platform/ios-simulator-wk1/fast/table/edge-offsets-expected.txt: Added.
  • platform/ios-simulator-wk1/fast/table/overflowHidden-expected.txt:
  • platform/ios-simulator-wk1/fast/table/percent-widths-stretch-vertical-expected.txt:
  • platform/ios-simulator-wk1/fast/table/simple_paint-expected.txt:
  • platform/ios-simulator-wk1/fast/table/table-anonymous-cell-bug-expected.txt:
  • platform/ios-simulator-wk1/fast/table/table-anonymous-row-bug-expected.txt:
  • platform/ios-simulator-wk1/fast/table/table-anonymous-section-bug-expected.txt:
  • platform/ios-simulator-wk1/fast/table/table-cell-split-expected.txt:
  • platform/ios-simulator-wk1/fast/table/table-insert-before-non-anonymous-block-expected.txt:
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/TestExpectations:
4:36 PM Changeset in webkit [204943] by Ryan Haddad
  • 2 edits in trunk/Source/WebCore

Rebaseline bindings tests after r204923.

Unreviewed test gardening.

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::jsTestActiveDOMObjectExcitingAttr):
(WebCore::jsTestActiveDOMObjectPrototypeFunctionExcitingFunction):

4:27 PM Changeset in webkit [204942] by akling@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Shrink DFG::OSRExit a bit.
<https://webkit.org/b/161169>

Reviewed by Geoffrey Garen.

Rearrange the members of OSRExitBase and DFG::OSRExit to save 16 bytes per instance.

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::OSRExit):

  • dfg/DFGOSRExit.h:
  • dfg/DFGOSRExitBase.h:

(JSC::DFG::OSRExitBase::OSRExitBase):

4:26 PM Changeset in webkit [204941] by commit-queue@webkit.org
  • 4 edits in trunk/Source

FocusController multiple dereferenced NULL pointers
https://bugs.webkit.org/show_bug.cgi?id=160808

Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-24
Reviewed by Darin Adler.

Source/WebCore:

No new tests needed, fix does not change functionality.

This change fixes a number of NULL pointer dereferences which occur in FocusController.

  • page/FocusController.cpp:

(WebCore::isFocusableElementOrScopeOwner): Changed KeyboardEvent reference to pointer.
(WebCore::isNonFocusableScopeOwner): Ditto.
(WebCore::isFocusableScopeOwner): Ditto.
(WebCore::shadowAdjustedTabIndex): Ditto.

(WebCore::FocusController::findFocusableElementAcrossFocusScope): Pass pointer instead of reference to KeyboardEvent.
(WebCore::FocusController::nextFocusableElementWithinScope): Ditto.
(WebCore::FocusController::previousFocusableElementWithinScope): Ditto.
(WebCore::FocusController::findElementWithExactTabIndex): Ditto.
(WebCore::nextElementWithGreaterTabIndex): Ditto.
(WebCore::previousElementWithLowerTabIndex): Ditto.
(WebCore::FocusController::nextFocusableElementOrScopeOwner): Ditto.
(WebCore::FocusController::previousFocusableElementOrScopeOwner): Ditto.
(WebCore::relinquishesEditingFocus): Ditto.

Source/WebKit2:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setInitialFocus): Should use nullptr, not 0 to initialize NULL pointer.

4:21 PM Changeset in webkit [204940] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: unexpected cursor changes while dragging ruler handle in rendering frames timeline
https://bugs.webkit.org/show_bug.cgi?id=161101
<rdar://problem/27974117>

Reviewed by Brian Burg.

-webkit-grab(bing) cursor styles shouldn't be applied to the selection
drag element when resizing.

  • UserInterface/Views/TimelineRuler.css:

(.timeline-ruler:not(.disabled, .resizing-selection) > .selection-drag):
(.timeline-ruler:not(.disabled, .resizing-selection) > .selection-drag:active):
(.timeline-ruler:not(.disabled) > .selection-drag): Deleted.
(.timeline-ruler:not(.disabled) > .selection-drag:active): Deleted.

3:29 PM Changeset in webkit [204939] by bshafiei@apple.com
  • 2 edits in branches/safari-602.1.50.0-branch/Source/WebKit2

Roll out r204911 via r204922. rdar://problem/27896368

3:25 PM Changeset in webkit [204938] by n_wang@apple.com
  • 3 edits
    2 adds in trunk

AX: VoiceOver on iOS ignores aria-checked on menuitemradio and menuitemcheckbox
https://bugs.webkit.org/show_bug.cgi?id=161118

Reviewed by Chris Fleizach.

Source/WebCore:

Added checkboxOrRadioValue and toggle trait to menuitemradio and menuitemcheckbox.

Test: accessibility/ios-simulator/menuitem-checked.html

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityTraits]):
(-[WebAccessibilityObjectWrapper accessibilityValue]):

LayoutTests:

  • accessibility/ios-simulator/menuitem-checked-expected.txt: Added.
  • accessibility/ios-simulator/menuitem-checked.html: Added.
3:05 PM Changeset in webkit [204937] by jiewen_tan@apple.com
  • 5 edits in trunk/LayoutTests

Unreviewed, update expectations of iOS simulator WK1 css3 tests

  • TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator/TestExpectations:
2:58 PM Changeset in webkit [204936] by Chris Dumez
  • 4 edits in trunk

Assertion hit: ASSERT(!m_parserScheduler) in ~HTMLDocumentParser()
https://bugs.webkit.org/show_bug.cgi?id=161083
<rdar://problem/27986937>

Reviewed by Darin Adler.

Source/WebCore:

Call cancelParsing() right before re-creating the new parser in
Document::implicitOpen(). We would previously call removeChildren()
in between which is was an issue because it can cause JS to be
executed and therefore the parser to be re-created after we have
cancelled parsing.

No new tests, unskipped html/browsers/browsing-the-web/unloading-documents/004.html
which was consistently crashing.

  • dom/Document.cpp:

(WebCore::Document::implicitOpen):

LayoutTests:

Unskip html/browsers/browsing-the-web/unloading-documents/004.html as
it is no longer crashing.

2:55 PM Changeset in webkit [204935] by eric.carlson@apple.com
  • 11 edits
    2 adds in trunk

[MediaStream] Add support for OverConstrained Error
https://bugs.webkit.org/show_bug.cgi?id=160790
<rdar://problem/27815715>

Reviewed by Jer Noble.

Source/WebCore:

Existing tests updated.

  • DerivedSources.make:
  • Modules/mediastream/OverconstrainedError.h: Added.

(WebCore::OverconstrainedError::create):
(WebCore::OverconstrainedError::constraint):
(WebCore::OverconstrainedError::message):
(WebCore::OverconstrainedError::OverconstrainedError):

  • Modules/mediastream/OverconstrainedError.idl: Added.
  • WebCore.xcodeproj/project.pbxproj:

LayoutTests:

  • fast/dom/Window/get-set-properties-expected.txt:
  • fast/dom/Window/get-set-properties.html:
  • fast/dom/Window/resources/window-properties.js:
  • fast/dom/Window/window-property-shadowing-expected.txt:
  • fast/dom/Window/window-property-shadowing.html:
  • platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:
2:39 PM Changeset in webkit [204934] by jiewen_tan@apple.com
  • 1 edit
    7 deletes in trunk/LayoutTests

Unreviewed, rebase iOS simulator WK1 css3 tests

  • platform/ios-simulator-wk1/css3/blending/blend-mode-accelerated-with-multiple-stacking-contexts-expected.txt: Removed.
  • platform/ios-simulator-wk1/css3/blending/blend-mode-ancestor-clipping-layer-expected.txt: Removed.
  • platform/ios-simulator-wk1/css3/blending/blend-mode-blended-element-overlapping-composited-sibling-should-have-compositing-layer-expected.txt: Removed.
  • platform/ios-simulator-wk1/css3/blending/blend-mode-isolation-accelerated-overflow-hidden-expected.txt: Removed.
  • platform/ios-simulator-wk1/css3/blending/blend-mode-with-accelerated-sibling-expected.txt: Removed.
  • platform/ios-simulator-wk1/css3/blending/blend-mode-with-composited-descendant-should-have-layer-expected.txt: Removed.
  • platform/ios-simulator-wk1/css3/filters/backdrop/backdrop-filter-does-not-size-properly-border-and-padding-expected.txt: Removed.
  • platform/ios-simulator-wk1/css3/filters/filtered-compositing-descendant-expected.txt: Removed.
2:34 PM Changeset in webkit [204933] by Ryan Haddad
  • 2 edits in trunk/Tools

Attempt to fix Windows build after r204918.

Unreviewed build fix.

  • DumpRenderTree/win/ResourceLoadDelegate.cpp:

(ResourceLoadDelegate::willSendRequest):

2:17 PM Changeset in webkit [204932] by andersca@apple.com
  • 3 edits in trunk/Source/WebCore

Build the platform name dynamically for the phony WebKitLegacy framework
https://bugs.webkit.org/show_bug.cgi?id=161163

Reviewed by Dan Bernstein.

  • Configurations/WebKitLegacyStub.iOS.tbd:
  • WebCore.xcodeproj/project.pbxproj:
1:53 PM Changeset in webkit [204931] by Simon Fraser
  • 13 edits
    1 move
    2 adds
    2 deletes in trunk

[iOS DRT] Get basic viewport tests working in DRT
https://bugs.webkit.org/show_bug.cgi?id=161160

Reviewed by Tim Horton.

Tools:

Hook up enough of UIScriptController in iOS DRT to be able to read viewport
scale, and get the contentVisibleRect.

Requires exposing a bit of UIWebBrowserView SPI from UIKit, which in turn
requires typing the gWebBrowserView as a DumpRenderTreeBrowserView * everywhere.

One test has different results between DRT and WTR, but DRT behavior seems to differ
from UIWebView here, so just give it a WK1-specific result.

  • DumpRenderTree/ios/DumpRenderTreeBrowserView.h:
  • DumpRenderTree/ios/DumpRenderTreeBrowserView.mm:

(-[DumpRenderTreeBrowserView documentVisibleRect]):

  • DumpRenderTree/ios/PixelDumpSupportIOS.mm:
  • DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::zoomScale):
(WTR::UIScriptController::minimumZoomScale):
(WTR::UIScriptController::maximumZoomScale):
(WTR::UIScriptController::contentVisibleRect):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):

  • DumpRenderTree/mac/DumpRenderTreeMac.h:

LayoutTests:

Enable some fast/viewport/ios/ tests for ios-simulator-wk1 that work now.

"body-overflow-hidden" tests should pass everywhere now since the behavior of overflow:hidden
on the body was reverted.

  • fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-expected.txt:
  • fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-expected.txt:
  • fast/viewport/ios/width-is-device-width-overflowing-expected.txt:
  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk1/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-expected.txt: Renamed from LayoutTests/platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-expected.txt.
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-expected.txt: Removed.
  • platform/ios-simulator/fast/viewport/ios/width-is-device-width-overflowing-body-overflow-hidden-tall-expected.txt: Removed.
1:53 PM Changeset in webkit [204930] by Simon Fraser
  • 2 edits in trunk/Tools

Minor project rearrangement.

  • DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
1:53 PM Changeset in webkit [204929] by Simon Fraser
  • 2 edits in trunk/Tools

[iOS DRT] Make iOS DRT use the same window size as WebKitTestRunner for flexible viewport tests
https://bugs.webkit.org/show_bug.cgi?id=161124

Reviewed by Daniel Bates.

Use the main UIScreen's bounds for the size of the window in flexible viewport mode,
and remove the 'phoneBrowserAddressBarOffset' hack, so that it matches WTR.

Remove some unnecessary zero initializations of static variables.

Change _setVisibleSize to use the window size, which should not be a behavior change
because this it just used for text autosizing, which is disabled by default,
and only the width is consulted.

  • DumpRenderTree/mac/DumpRenderTree.mm:

(adjustWebDocumentForFlexibleViewport):
(adjustWebDocumentForStandardViewport):
(createWebViewAndOffscreenWindow):

1:32 PM Changeset in webkit [204928] by Ryan Haddad
  • 15 edits in trunk/Source/JavaScriptCore

Rebaseline builtins-generator-tests since r204854 was rolled out.

Unreviewed test gardening.

  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Combined.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.Promise-Separate.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Combined.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-Builtin.prototype-Separate.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Combined.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-BuiltinConstructor-Separate.js-result:
  • Scripts/tests/builtins/expected/JavaScriptCore-InternalClashingNames-Combined.js-result:
  • Scripts/tests/builtins/expected/WebCore-AnotherGuardedInternalBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-ArbitraryConditionalGuard-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-GuardedBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-GuardedInternalBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-UnguardedBuiltin-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCore-xmlCasingTest-Separate.js-result:
  • Scripts/tests/builtins/expected/WebCoreJSBuiltins.h-result:
1:32 PM Changeset in webkit [204927] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking wpt LayoutTest scroll-restoration-fragment-scrolling-samedoc.html as flaky on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=161143

Unreviewed test gardening.

  • platform/ios-simulator/TestExpectations:
1:19 PM Changeset in webkit [204926] by jiewen_tan@apple.com
  • 4 edits in trunk/LayoutTests

Unreviewed, update expectations of iOS simulator WK1 svg tests

  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-simulator/TestExpectations:
1:02 PM Changeset in webkit [204925] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Unskip inspector/codemirror tests on mac-wk1 debug.
https://bugs.webkit.org/show_bug.cgi?id=161117

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
1:00 PM Changeset in webkit [204924] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Shift-Tab should unindent selected line
https://bugs.webkit.org/show_bug.cgi?id=159316

Patch by Devin Rousso <Devin Rousso> on 2016-08-24
Reviewed by Joseph Pecoraro.

  • UserInterface/Views/CodeMirrorAdditions.js:

(CodeMirror.keyMapdefault?):
Changed "Shift-Tab" mapping to "indentLess".

12:52 PM Changeset in webkit [204923] by Chris Dumez
  • 4 edits
    2 adds in trunk

It should not be possible to access Location attributes cross origin
https://bugs.webkit.org/show_bug.cgi?id=161125
<rdar://problem/27982472>

Reviewed by Brent Fulgham.

Source/WebCore:

It should not be possible to access Location attributes cross origin:

We allow access to replace() as per the specification and consistently
with Firefox. The specification seems to indicate we should allow access
to 'href' but Firefox does not and we previously did not so I am not
allowing it in this patch.

Test: http/tests/security/location-cross-origin.html

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • page/Location.idl:

LayoutTests:

Add layout test coverage.

  • http/tests/security/location-cross-origin-expected.txt: Added.
  • http/tests/security/location-cross-origin.html: Added.
12:38 PM Changeset in webkit [204922] by bshafiei@apple.com
  • 2 edits in branches/safari-602.1.50.0-branch/Source/WebKit2

Merge r204911. rdar://problem/27896368

12:37 PM Changeset in webkit [204921] by bshafiei@apple.com
  • 5 edits in branches/safari-602.1.50.0-branch/Source

Versioning.

12:35 PM Changeset in webkit [204920] by Yusuke Suzuki
  • 26 edits
    1 copy
    2 moves in trunk/Source

[JSC] Move generic data structures out of B3
https://bugs.webkit.org/show_bug.cgi?id=161155

Reviewed by Saam Barati.

Source/JavaScriptCore:

Move B3's good generic data structures to WTF.
They can be used for the other kind of basic blocks and nodes.
For example, the generator patch[1] will make BytecodeBasicBlock usable with these structures.

[1]: https://bugs.webkit.org/show_bug.cgi?id=152723

  • JavaScriptCore.xcodeproj/project.pbxproj:
  • b3/B3BasicBlockUtils.h:
  • b3/B3BlockWorklist.h:
  • b3/B3CFG.h:
  • b3/B3DuplicateTails.cpp:
  • b3/B3FixSSA.cpp:
  • b3/B3FixSSA.h:
  • b3/B3IndexMap.h:

(JSC::B3::IndexMap::IndexMap): Deleted.
(JSC::B3::IndexMap::resize): Deleted.
(JSC::B3::IndexMap::clear): Deleted.
(JSC::B3::IndexMap::size): Deleted.
(JSC::B3::IndexMap::operator[]): Deleted.

  • b3/B3IndexSet.h:

(JSC::B3::IndexSet::IndexSet): Deleted.
(JSC::B3::IndexSet::add): Deleted.
(JSC::B3::IndexSet::addAll): Deleted.
(JSC::B3::IndexSet::remove): Deleted.
(JSC::B3::IndexSet::contains): Deleted.
(JSC::B3::IndexSet::size): Deleted.
(JSC::B3::IndexSet::isEmpty): Deleted.
(JSC::B3::IndexSet::Iterable::Iterable): Deleted.
(JSC::B3::IndexSet::Iterable::iterator::iterator): Deleted.
(JSC::B3::IndexSet::Iterable::iterator::operator*): Deleted.
(JSC::B3::IndexSet::Iterable::iterator::operator++): Deleted.
(JSC::B3::IndexSet::Iterable::iterator::operator==): Deleted.
(JSC::B3::IndexSet::Iterable::iterator::operator!=): Deleted.
(JSC::B3::IndexSet::Iterable::begin): Deleted.
(JSC::B3::IndexSet::Iterable::end): Deleted.
(JSC::B3::IndexSet::values): Deleted.
(JSC::B3::IndexSet::indices): Deleted.
(JSC::B3::IndexSet::dump): Deleted.

  • b3/B3LowerToAir.cpp:
  • b3/B3PhiChildren.h:
  • b3/B3Procedure.h:

(JSC::B3::Procedure::iterator::iterator): Deleted.
(JSC::B3::Procedure::iterator::operator*): Deleted.
(JSC::B3::Procedure::iterator::operator++): Deleted.
(JSC::B3::Procedure::iterator::operator==): Deleted.
(JSC::B3::Procedure::iterator::operator!=): Deleted.
(JSC::B3::Procedure::iterator::findNext): Deleted.

  • b3/B3ReduceDoubleToFloat.cpp:
  • b3/B3ReduceStrength.cpp:
  • b3/B3SSACalculator.h:
  • b3/B3UseCounts.h:
  • b3/air/AirCode.h:
  • b3/air/AirEliminateDeadCode.cpp:
  • b3/air/AirFixObviousSpills.cpp:
  • b3/air/AirFixPartialRegisterStalls.cpp:
  • b3/air/AirGenerate.cpp:
  • b3/air/AirGenerationContext.h:
  • b3/air/AirLiveness.h:
  • b3/air/AirSpillEverything.cpp:

Source/WTF:

Add IndexSet, IndexMap, and IndexedContainerIterator.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/IndexMap.h: Copied from Source/JavaScriptCore/b3/B3IndexMap.h.

(WTF::IndexMap::IndexMap):
(WTF::IndexMap::resize):
(WTF::IndexMap::clear):
(WTF::IndexMap::size):
(WTF::IndexMap::operator[]):

  • wtf/IndexSet.h: Renamed from Source/JavaScriptCore/b3/B3IndexSet.h.

(WTF::IndexSet::IndexSet):
(WTF::IndexSet::add):
(WTF::IndexSet::addAll):
(WTF::IndexSet::remove):
(WTF::IndexSet::contains):
(WTF::IndexSet::size):
(WTF::IndexSet::isEmpty):
(WTF::IndexSet::Iterable::Iterable):
(WTF::IndexSet::Iterable::iterator::iterator):
(WTF::IndexSet::Iterable::iterator::operator*):
(WTF::IndexSet::Iterable::iterator::operator++):
(WTF::IndexSet::Iterable::iterator::operator==):
(WTF::IndexSet::Iterable::iterator::operator!=):
(WTF::IndexSet::Iterable::begin):
(WTF::IndexSet::Iterable::end):
(WTF::IndexSet::values):
(WTF::IndexSet::indices):
(WTF::IndexSet::dump):

  • wtf/IndexedContainerIterator.h: Renamed from Source/JavaScriptCore/b3/B3IndexMap.h.

(WTF::IndexedContainerIterator::IndexedContainerIterator):
(WTF::IndexedContainerIterator::operator++):
(WTF::IndexedContainerIterator::operator==):
(WTF::IndexedContainerIterator::operator!=):
(WTF::IndexedContainerIterator::findNext):

12:29 PM Changeset in webkit [204919] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Add User Timing to the feature status page
https://bugs.webkit.org/show_bug.cgi?id=161154

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-08-24
Reviewed by Darin Adler.

  • features.json:
12:27 PM Changeset in webkit [204918] by commit-queue@webkit.org
  • 8 edits
    2 deletes in trunk

WebKit2 needs layoutTestController.setDeferMainResourceDataLoad
https://bugs.webkit.org/show_bug.cgi?id=42777

Patch by Jonathan Bedard <Jonathan Bedard> on 2016-08-24
Reviewed by Darin Adler.

The setDeferMainResourceDataLoad method was not correctly tested in DumpRenderTree and would pass even when setDeterMainResourceDataLoad was not called. Removed function and test.

Tools:

  • DumpRenderTree/TestRunner.cpp:

(setDeferMainResourceDataLoadCallback): Removed setDeferMainResourceDataLoad.

  • DumpRenderTree/TestRunner.h:

(TestRunner::deferMainResourceDataLoad): Ditto.
(TestRunner::setDeferMainResourceDataLoad): Ditto.

  • DumpRenderTree/mac/ResourceLoadDelegate.mm: Ditto.

LayoutTests:

  • fast/loader/non-deferred-substitute-load-expected.txt: Removed fast/loader/non-deferred-substitute-load.html.
  • fast/loader/non-deferred-substitute-load.html: Ditto.
  • platform/ios-simulator-wk2/TestExpectations: Ditto.
  • platform/win/TestExpectations: Ditto.
  • platform/wk2/TestExpectations: Ditto.
12:23 PM Changeset in webkit [204917] by akling@apple.com
  • 7 edits in trunk/Source

Source/bmalloc:
Add bmalloc::api::isEnabled().
<https://webkit.org/b/160534>

Reviewed by Joseph Pecoraro.

  • bmalloc/bmalloc.h:

(bmalloc::api::isEnabled):

Source/WebCore:
Leaks bot hits an assertion in ResourceUsageThread::platformThreadBody
<https://webkit.org/b/160534>

Reviewed by Joseph Pecoraro.

Use the correct malloc bucket when bmalloc is disabled (which is the case on leaks bots.)

  • page/cocoa/ResourceUsageThreadCocoa.mm:

(WebCore::ResourceUsageThread::platformThreadBody):

Source/WTF:
Add WTF::isFastMallocEnabled().
<https://webkit.org/b/160534>

Reviewed by Joseph Pecoraro.

  • wtf/FastMalloc.cpp:

(WTF::isFastMallocEnabled):

  • wtf/FastMalloc.h:
12:14 PM Changeset in webkit [204916] by andersca@apple.com
  • 9 edits
    2 adds in trunk

Add enum traits and use them in the IPC::Decoder
https://bugs.webkit.org/show_bug.cgi?id=161103

Reviewed by Sam Weinig.

Source/WebKit2:

  • Platform/IPC/Decoder.h:
  • Platform/IPC/Encoder.h:

Add new encode/decode functions.

  • Shared/mac/ArgumentCodersMac.mm:

Change NSType to be a strongly typed enum. Use encode/decode
instead of encodeEnum/decodeEnum since the latter don't have the
enum check.

Source/WTF:

Add EnumTraits.h which provides a forward declaration for WTF::EnumTraits as well as
the WTF::isValidEnum function.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/EnumTraits.h: Added.

Tools:

Add API test.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/EnumTraits.cpp: Added.

(TestWebKitAPI::TEST):

12:05 PM Changeset in webkit [204915] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed, temporarily skipping W3C tests trying to load www1.localhost.

12:02 PM Changeset in webkit [204914] by bshafiei@apple.com
  • 1 copy in tags/Safari-603.1.3

New tag.

12:01 PM Changeset in webkit [204913] by bshafiei@apple.com
  • 5 edits in trunk/Source

Versioning.

12:00 PM Changeset in webkit [204912] by fpizlo@apple.com
  • 279 edits
    1 add
    19 deletes in trunk

Unreviewed, roll out r204901, r204897, r204866, r204856, r204854.

JSTests:

  • stress/array-storage-array-unshift.js: Removed.
  • stress/contiguous-array-unshift.js: Removed.
  • stress/double-array-unshift.js: Removed.
  • stress/int32-array-unshift.js: Removed.

Source/bmalloc:

  • bmalloc/Allocator.cpp:

(bmalloc::Allocator::allocate):
(bmalloc::Allocator::tryAllocate): Deleted.
(bmalloc::Allocator::allocateImpl): Deleted.

  • bmalloc/Allocator.h:
  • bmalloc/Cache.h:

(bmalloc::Cache::tryAllocate): Deleted.

  • bmalloc/bmalloc.h:

(bmalloc::api::tryMemalign): Deleted.

Source/JavaScriptCore:

  • API/JSTypedArray.cpp:
  • API/ObjCCallbackFunction.mm:
  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Scripts/builtins/builtins_generate_combined_implementation.py:

(BuiltinsCombinedImplementationGenerator.generate_secondary_header_includes):

  • Scripts/builtins/builtins_generate_internals_wrapper_implementation.py:

(BuiltinsInternalsWrapperImplementationGenerator.generate_secondary_header_includes):

  • Scripts/builtins/builtins_generate_separate_implementation.py:

(BuiltinsSeparateImplementationGenerator.generate_secondary_header_includes):

  • assembler/AbstractMacroAssembler.h:

(JSC::AbstractMacroAssembler::JumpList::link):
(JSC::AbstractMacroAssembler::JumpList::linkTo):

  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerARM64.h:

(JSC::MacroAssemblerARM64::add32):

  • assembler/MacroAssemblerCodeRef.cpp: Removed.
  • assembler/MacroAssemblerCodeRef.h:

(JSC::MacroAssemblerCodePtr::createLLIntCodePtr):
(JSC::MacroAssemblerCodePtr::dumpWithName):
(JSC::MacroAssemblerCodePtr::dump):
(JSC::MacroAssemblerCodeRef::createLLIntCodeRef):
(JSC::MacroAssemblerCodeRef::dump):

  • b3/B3BasicBlock.cpp:

(JSC::B3::BasicBlock::appendBoolConstant): Deleted.

  • b3/B3BasicBlock.h:
  • b3/B3DuplicateTails.cpp:
  • b3/B3StackmapGenerationParams.h:
  • b3/testb3.cpp:

(JSC::B3::run):
(JSC::B3::testPatchpointTerminalReturnValue): Deleted.

  • bindings/ScriptValue.cpp:
  • bytecode/AdaptiveInferredPropertyValueWatchpointBase.cpp:
  • bytecode/BytecodeBasicBlock.cpp:
  • bytecode/BytecodeLivenessAnalysis.cpp:
  • bytecode/BytecodeUseDef.h:
  • bytecode/CallLinkInfo.cpp:

(JSC::CallLinkInfo::callTypeFor): Deleted.

  • bytecode/CallLinkInfo.h:

(JSC::CallLinkInfo::callTypeFor):

  • bytecode/CallLinkStatus.cpp:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::clearLLIntGetByIdCache): Deleted.

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::jitCodeMap):
(JSC::clearLLIntGetByIdCache):

  • bytecode/Instruction.h:
  • bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp:

(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::fireInternal):

  • bytecode/ObjectAllocationProfile.h:

(JSC::ObjectAllocationProfile::isNull):
(JSC::ObjectAllocationProfile::initialize):

  • bytecode/Opcode.h:

(JSC::padOpcodeName):

  • bytecode/PolymorphicAccess.cpp:

(JSC::AccessCase::generateImpl):
(JSC::PolymorphicAccess::regenerate):

  • bytecode/PolymorphicAccess.h:
  • bytecode/PreciseJumpTargets.cpp:
  • bytecode/StructureStubInfo.cpp:
  • bytecode/StructureStubInfo.h:
  • bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::vm):

  • bytecode/UnlinkedCodeBlock.h:
  • bytecode/UnlinkedInstructionStream.cpp:
  • bytecode/UnlinkedInstructionStream.h:
  • dfg/DFGOperations.cpp:
  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitAllocateRawObject):
(JSC::DFG::SpeculativeJIT::compileMakeRope):
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):

  • dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::emitAllocateJSCell):
(JSC::DFG::SpeculativeJIT::emitAllocateJSObject):

  • dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileAllocateNewArrayWithSize):

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::compileAllocateNewArrayWithSize):

  • dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

  • ftl/FTLAbstractHeapRepository.h:
  • ftl/FTLCompile.cpp:
  • ftl/FTLJITFinalizer.cpp:
  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileCreateDirectArguments):
(JSC::FTL::DFG::LowerDFGToB3::compileCreateRest):
(JSC::FTL::DFG::LowerDFGToB3::compileAllocateArrayWithSize):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSize):
(JSC::FTL::DFG::LowerDFGToB3::compileMakeRope):
(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeNewObject):
(JSC::FTL::DFG::LowerDFGToB3::initializeArrayElements):
(JSC::FTL::DFG::LowerDFGToB3::allocatePropertyStorageWithSizeImpl):
(JSC::FTL::DFG::LowerDFGToB3::allocateCell):
(JSC::FTL::DFG::LowerDFGToB3::allocateObject):
(JSC::FTL::DFG::LowerDFGToB3::allocateVariableSizedObject):
(JSC::FTL::DFG::LowerDFGToB3::allocateJSArray):
(JSC::FTL::DFG::LowerDFGToB3::allocateArrayWithSize): Deleted.
(JSC::FTL::DFG::LowerDFGToB3::allocateHeapCell): Deleted.
(JSC::FTL::DFG::LowerDFGToB3::allocatorForSize): Deleted.

  • ftl/FTLOutput.cpp:

(JSC::FTL::Output::constBool):
(JSC::FTL::Output::add):
(JSC::FTL::Output::shl):
(JSC::FTL::Output::aShr):
(JSC::FTL::Output::lShr):
(JSC::FTL::Output::zeroExt):
(JSC::FTL::Output::equal):
(JSC::FTL::Output::notEqual):
(JSC::FTL::Output::above):
(JSC::FTL::Output::aboveOrEqual):
(JSC::FTL::Output::below):
(JSC::FTL::Output::belowOrEqual):
(JSC::FTL::Output::greaterThan):
(JSC::FTL::Output::greaterThanOrEqual):
(JSC::FTL::Output::lessThan):
(JSC::FTL::Output::lessThanOrEqual):
(JSC::FTL::Output::select):
(JSC::FTL::Output::addIncomingToPhi):
(JSC::FTL::Output::appendSuccessor): Deleted.

  • ftl/FTLOutput.h:
  • ftl/FTLValueFromBlock.h:

(JSC::FTL::ValueFromBlock::ValueFromBlock):
(JSC::FTL::ValueFromBlock::operator bool): Deleted.

  • ftl/FTLWeightedTarget.h:

(JSC::FTL::WeightedTarget::frequentedBlock): Deleted.

  • heap/CellContainer.h: Removed.
  • heap/CellContainerInlines.h: Removed.
  • heap/ConservativeRoots.cpp:

(JSC::ConservativeRoots::ConservativeRoots):
(JSC::ConservativeRoots::~ConservativeRoots):
(JSC::ConservativeRoots::grow):
(JSC::ConservativeRoots::genericAddPointer):
(JSC::ConservativeRoots::genericAddSpan):

  • heap/ConservativeRoots.h:

(JSC::ConservativeRoots::roots):

  • heap/CopyToken.h:
  • heap/FreeList.cpp: Removed.
  • heap/FreeList.h: Removed.
  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::lastChanceToFinalize):
(JSC::Heap::finalizeUnconditionalFinalizers):
(JSC::Heap::markRoots):
(JSC::Heap::copyBackingStores):
(JSC::Heap::gatherStackRoots):
(JSC::Heap::gatherJSStackRoots):
(JSC::Heap::gatherScratchBufferRoots):
(JSC::Heap::clearLivenessData):
(JSC::Heap::visitSmallStrings):
(JSC::Heap::visitConservativeRoots):
(JSC::Heap::removeDeadCompilerWorklistEntries):
(JSC::Heap::gatherExtraHeapSnapshotData):
(JSC::Heap::removeDeadHeapSnapshotNodes):
(JSC::Heap::visitProtectedObjects):
(JSC::Heap::visitArgumentBuffers):
(JSC::Heap::visitException):
(JSC::Heap::visitStrongHandles):
(JSC::Heap::visitHandleStack):
(JSC::Heap::visitSamplingProfiler):
(JSC::Heap::traceCodeBlocksAndJITStubRoutines):
(JSC::Heap::converge):
(JSC::Heap::visitWeakHandles):
(JSC::Heap::updateObjectCounts):
(JSC::Heap::clearUnmarkedExecutables):
(JSC::Heap::deleteUnmarkedCompiledCode):
(JSC::Heap::collectAllGarbage):
(JSC::Heap::collect):
(JSC::Heap::collectImpl):
(JSC::Heap::suspendCompilerThreads):
(JSC::Heap::willStartCollection):
(JSC::Heap::flushOldStructureIDTables):
(JSC::Heap::flushWriteBarrierBuffer):
(JSC::Heap::stopAllocation):
(JSC::Heap::reapWeakHandles):
(JSC::Heap::pruneStaleEntriesFromWeakGCMaps):
(JSC::Heap::sweepArrayBuffers):
(JSC::Heap::snapshotMarkedSpace):
(JSC::Heap::deleteSourceProviderCaches):
(JSC::Heap::notifyIncrementalSweeper):
(JSC::Heap::writeBarrierCurrentlyExecutingCodeBlocks):
(JSC::Heap::resetAllocators):
(JSC::Heap::updateAllocationLimits):
(JSC::Heap::didFinishCollection):
(JSC::Heap::resumeCompilerThreads):
(JSC::Zombify::visit):
(JSC::Heap::collectWithoutAnySweep): Deleted.
(JSC::Heap::prepareForMarking): Deleted.
(JSC::Heap::forEachCodeBlockImpl): Deleted.

  • heap/Heap.h:

(JSC::Heap::allocatorForObjectWithoutDestructor):
(JSC::Heap::allocatorForObjectWithDestructor):
(JSC::Heap::storageAllocator):
(JSC::Heap::jitStubRoutines):
(JSC::Heap::codeBlockSet):
(JSC::Heap::allocatorForAuxiliaryData): Deleted.

  • heap/HeapCell.h:

(JSC::HeapCell::isZapped):

  • heap/HeapCellInlines.h: Removed.
  • heap/HeapInlines.h:

(JSC::Heap::heap):
(JSC::Heap::isLive):
(JSC::Heap::isMarked):
(JSC::Heap::testAndSetMarked):
(JSC::Heap::setMarked):
(JSC::Heap::forEachCodeBlock):
(JSC::Heap::allocateObjectOfType):
(JSC::Heap::subspaceForObjectOfType):
(JSC::Heap::allocatorForObjectOfType):
(JSC::Heap::isPointerGCObject):
(JSC::Heap::isValueGCObject):
(JSC::Heap::cellSize): Deleted.
(JSC::Heap::allocateAuxiliary): Deleted.
(JSC::Heap::tryAllocateAuxiliary): Deleted.
(JSC::Heap::tryReallocateAuxiliary): Deleted.

  • heap/HeapUtil.h: Removed.
  • heap/LargeAllocation.cpp: Removed.
  • heap/LargeAllocation.h: Removed.
  • heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::retire):
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::tryPopFreeList):
(JSC::MarkedAllocator::tryAllocate):
(JSC::MarkedAllocator::allocateSlowCase):
(JSC::MarkedAllocator::allocateBlock):
(JSC::MarkedAllocator::addBlock):
(JSC::MarkedAllocator::removeBlock):
(JSC::MarkedAllocator::reset):
(JSC::MarkedAllocator::MarkedAllocator): Deleted.
(JSC::MarkedAllocator::tryAllocateWithoutCollectingImpl): Deleted.
(JSC::MarkedAllocator::tryAllocateWithoutCollecting): Deleted.
(JSC::MarkedAllocator::tryAllocateSlowCase): Deleted.
(JSC::MarkedAllocator::allocateSlowCaseImpl): Deleted.
(JSC::blockHeaderSize): Deleted.
(JSC::MarkedAllocator::blockSizeForBytes): Deleted.
(JSC::MarkedAllocator::tryAllocateBlock): Deleted.
(JSC::MarkedAllocator::setFreeList): Deleted.

  • heap/MarkedAllocator.h:

(JSC::MarkedAllocator::offsetOfFreeListHead):
(JSC::MarkedAllocator::MarkedAllocator):
(JSC::MarkedAllocator::init):
(JSC::MarkedAllocator::allocate):
(JSC::MarkedAllocator::stopAllocating):
(JSC::MarkedAllocator::offsetOfFreeList): Deleted.
(JSC::MarkedAllocator::offsetOfCellSize): Deleted.
(JSC::MarkedAllocator::tryAllocate): Deleted.

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::create):
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::callDestructor):
(JSC::MarkedBlock::specializedSweep):
(JSC::MarkedBlock::sweep):
(JSC::MarkedBlock::sweepHelper):
(JSC::MarkedBlock::stopAllocating):
(JSC::MarkedBlock::clearMarksWithCollectionType):
(JSC::MarkedBlock::resumeAllocating):
(JSC::MarkedBlock::didRetireBlock):
(JSC::MarkedBlock::tryCreate): Deleted.
(JSC::MarkedBlock::sweepHelperSelectScribbleMode): Deleted.
(JSC::MarkedBlock::sweepHelperSelectStateAndSweepMode): Deleted.
(JSC::MarkedBlock::forEachFreeCell): Deleted.

  • heap/MarkedBlock.h:

(JSC::MarkedBlock::FreeList::FreeList):
(JSC::MarkedBlock::isEmpty):
(JSC::MarkedBlock::setHasAnyMarked): Deleted.
(JSC::MarkedBlock::hasAnyMarked): Deleted.
(JSC::MarkedBlock::clearHasAnyMarked): Deleted.
(JSC::MarkedBlock::cellAlign): Deleted.

  • heap/MarkedSpace.cpp:

(JSC::MarkedSpace::MarkedSpace):
(JSC::MarkedSpace::lastChanceToFinalize):
(JSC::MarkedSpace::sweep):
(JSC::MarkedSpace::zombifySweep):
(JSC::MarkedSpace::resetAllocators):
(JSC::MarkedSpace::visitWeakSets):
(JSC::MarkedSpace::reapWeakSets):
(JSC::MarkedSpace::forEachAllocator):
(JSC::MarkedSpace::stopAllocating):
(JSC::MarkedSpace::resumeAllocating):
(JSC::MarkedSpace::isPagedOut):
(JSC::MarkedSpace::shrink):
(JSC::MarkedSpace::clearNewlyAllocated):
(JSC::MarkedSpace::clearMarks):
(JSC::MarkedSpace::initializeSizeClassForStepSize): Deleted.
(JSC::MarkedSpace::allocate): Deleted.
(JSC::MarkedSpace::tryAllocate): Deleted.
(JSC::MarkedSpace::allocateLarge): Deleted.
(JSC::MarkedSpace::tryAllocateLarge): Deleted.
(JSC::MarkedSpace::sweepLargeAllocations): Deleted.
(JSC::MarkedSpace::prepareForMarking): Deleted.
(JSC::MarkedSpace::objectCount): Deleted.
(JSC::MarkedSpace::size): Deleted.
(JSC::MarkedSpace::capacity): Deleted.

  • heap/MarkedSpace.h:

(JSC::MarkedSpace::blocksWithNewObjects):
(JSC::MarkedSpace::forEachLiveCell):
(JSC::MarkedSpace::forEachDeadCell):
(JSC::MarkedSpace::allocatorFor):
(JSC::MarkedSpace::destructorAllocatorFor):
(JSC::MarkedSpace::auxiliaryAllocatorFor):
(JSC::MarkedSpace::allocateWithoutDestructor):
(JSC::MarkedSpace::allocateWithDestructor):
(JSC::MarkedSpace::allocateAuxiliary):
(JSC::MarkedSpace::forEachBlock):
(JSC::MarkedSpace::objectCount):
(JSC::MarkedSpace::size):
(JSC::MarkedSpace::capacity):
(JSC::MarkedSpace::sizeClassToIndex): Deleted.
(JSC::MarkedSpace::indexToSizeClass): Deleted.
(JSC::MarkedSpace::largeAllocations): Deleted.
(JSC::MarkedSpace::largeAllocationsNurseryOffset): Deleted.
(JSC::MarkedSpace::largeAllocationsOffsetForThisCollection): Deleted.
(JSC::MarkedSpace::largeAllocationsForThisCollectionBegin): Deleted.
(JSC::MarkedSpace::largeAllocationsForThisCollectionEnd): Deleted.
(JSC::MarkedSpace::largeAllocationsForThisCollectionSize): Deleted.
(JSC::MarkedSpace::tryAllocateAuxiliary): Deleted.
(JSC::MarkedSpace::forEachAllocator): Deleted.
(JSC::MarkedSpace::optimalSizeFor): Deleted.

  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::didStartMarking):
(JSC::SlotVisitor::reset):
(JSC::SlotVisitor::append):
(JSC::SlotVisitor::setMarkedAndAppendToMarkStack):
(JSC::SlotVisitor::appendToMarkStack):
(JSC::SlotVisitor::visitChildren):
(JSC::SlotVisitor::appendJSCellOrAuxiliary): Deleted.
(JSC::SlotVisitor::markAuxiliary): Deleted.
(JSC::SlotVisitor::noteLiveAuxiliaryCell): Deleted.

  • heap/SlotVisitor.h:
  • heap/WeakBlock.cpp:

(JSC::WeakBlock::create):
(JSC::WeakBlock::WeakBlock):
(JSC::WeakBlock::visit):
(JSC::WeakBlock::reap):

  • heap/WeakBlock.h:

(JSC::WeakBlock::disconnectMarkedBlock):
(JSC::WeakBlock::disconnectContainer): Deleted.

  • heap/WeakSet.cpp:

(JSC::WeakSet::sweep):
(JSC::WeakSet::addAllocator):

  • heap/WeakSet.h:

(JSC::WeakSet::WeakSet):

  • heap/WeakSetInlines.h:

(JSC::WeakSet::allocate):

  • inspector/InjectedScriptManager.cpp:
  • inspector/JSGlobalObjectInspectorController.cpp:
  • inspector/JSJavaScriptCallFrame.cpp:
  • inspector/ScriptDebugServer.cpp:
  • inspector/agents/InspectorDebuggerAgent.cpp:
  • interpreter/CachedCall.h:

(JSC::CachedCall::CachedCall):

  • interpreter/Interpreter.cpp:

(JSC::StackFrame::sourceID):
(JSC::StackFrame::sourceURL):
(JSC::StackFrame::functionName):
(JSC::loadVarargs):
(JSC::StackFrame::computeLineAndColumn):
(JSC::StackFrame::toString):

  • interpreter/Interpreter.h:

(JSC::StackFrame::isNative):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitAllocate):
(JSC::AssemblyHelpers::emitAllocateJSCell):
(JSC::AssemblyHelpers::emitAllocateJSObject):
(JSC::AssemblyHelpers::emitAllocateJSObjectWithKnownSize):
(JSC::AssemblyHelpers::emitAllocateVariableSized):
(JSC::AssemblyHelpers::emitAllocateWithNonNullAllocator): Deleted.

  • jit/GCAwareJITStubRoutine.cpp:

(JSC::GCAwareJITStubRoutine::GCAwareJITStubRoutine):

  • jit/JIT.cpp:

(JSC::JIT::compileCTINativeCall): Deleted.

  • jit/JIT.h:

(JSC::JIT::compileCTINativeCall):

  • jit/JITExceptions.cpp:

(JSC::genericUnwind): Deleted.

  • jit/JITExceptions.h:
  • jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_new_object):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this):

  • jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_new_object):
(JSC::JIT::emitSlow_op_new_object):
(JSC::JIT::emit_op_create_this):
(JSC::JIT::emitSlow_op_create_this):

  • jit/JITOperations.cpp:
  • jit/JITOperations.h:
  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitWriteBarrier):

  • jit/JITThunks.cpp:
  • jit/JITThunks.h:
  • jsc.cpp:

(functionDescribeArray):
(main):

  • llint/LLIntData.cpp:

(JSC::LLInt::Data::performAssertions):

  • llint/LLIntExceptions.cpp:
  • llint/LLIntThunks.cpp:
  • llint/LLIntThunks.h:
  • llint/LowLevelInterpreter.asm:
  • llint/LowLevelInterpreter.cpp:
  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
  • parser/ModuleAnalyzer.cpp:
  • parser/NodeConstructors.h:
  • parser/Nodes.h:
  • profiler/ProfilerBytecode.cpp:
  • profiler/ProfilerBytecode.h:
  • profiler/ProfilerBytecodeSequence.cpp:
  • runtime/ArrayConventions.h:

(JSC::indexingHeaderForArray):
(JSC::baseIndexingHeaderForArray):
(JSC::indexingHeaderForArrayStorage): Deleted.
(JSC::baseIndexingHeaderForArrayStorage): Deleted.

  • runtime/ArrayPrototype.cpp:

(JSC::arrayProtoFuncSplice):
(JSC::concatAppendOne):
(JSC::arrayProtoPrivateFuncConcatMemcpy):

  • runtime/ArrayStorage.h:

(JSC::ArrayStorage::vectorLength):
(JSC::ArrayStorage::sizeFor):
(JSC::ArrayStorage::totalSizeFor): Deleted.
(JSC::ArrayStorage::totalSize): Deleted.
(JSC::ArrayStorage::availableVectorLength): Deleted.
(JSC::ArrayStorage::optimalVectorLength): Deleted.

  • runtime/AuxiliaryBarrier.h: Removed.
  • runtime/AuxiliaryBarrierInlines.h: Removed.
  • runtime/Butterfly.h:
  • runtime/ButterflyInlines.h:

(JSC::Butterfly::createUninitialized):
(JSC::Butterfly::growArrayRight):
(JSC::Butterfly::availableContiguousVectorLength): Deleted.
(JSC::Butterfly::optimalContiguousVectorLength): Deleted.

  • runtime/ClonedArguments.cpp:

(JSC::ClonedArguments::createEmpty):

  • runtime/CommonSlowPathsExceptions.cpp:
  • runtime/CommonSlowPathsExceptions.h:
  • runtime/DataView.cpp:
  • runtime/DirectArguments.h:
  • runtime/ECMAScriptSpecInternalFunctions.cpp:
  • runtime/Error.cpp:
  • runtime/Error.h:
  • runtime/ErrorInstance.cpp:
  • runtime/ErrorInstance.h:
  • runtime/Exception.cpp:
  • runtime/Exception.h:
  • runtime/GeneratorFrame.cpp:
  • runtime/GeneratorPrototype.cpp:
  • runtime/InternalFunction.cpp:

(JSC::InternalFunction::InternalFunction):

  • runtime/IntlCollator.cpp:
  • runtime/IntlCollatorConstructor.cpp:
  • runtime/IntlCollatorPrototype.cpp:
  • runtime/IntlDateTimeFormat.cpp:
  • runtime/IntlDateTimeFormatConstructor.cpp:
  • runtime/IntlDateTimeFormatPrototype.cpp:
  • runtime/IntlNumberFormat.cpp:
  • runtime/IntlNumberFormatConstructor.cpp:
  • runtime/IntlNumberFormatPrototype.cpp:
  • runtime/IntlObject.cpp:
  • runtime/IteratorPrototype.cpp:
  • runtime/JSArray.cpp:

(JSC::JSArray::setLengthWritable):
(JSC::JSArray::unshiftCountSlowCase):
(JSC::JSArray::setLengthWithArrayStorage):
(JSC::JSArray::appendMemcpy):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::fastSlice):
(JSC::JSArray::shiftCountWithArrayStorage):
(JSC::JSArray::shiftCountWithAnyIndexingType):
(JSC::JSArray::unshiftCountWithArrayStorage):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToArguments):
(JSC::JSArray::tryCreateUninitialized): Deleted.

  • runtime/JSArray.h:

(JSC::createContiguousArrayButterfly):
(JSC::createArrayButterfly):
(JSC::JSArray::create):
(JSC::JSArray::tryCreateUninitialized):

  • runtime/JSArrayBufferView.h:
  • runtime/JSCInlines.h:
  • runtime/JSCJSValue.cpp:

(JSC::JSValue::dumpInContextAssumingStructure):

  • runtime/JSCallee.cpp:

(JSC::JSCallee::JSCallee):

  • runtime/JSCell.cpp:

(JSC::JSCell::estimatedSize):

  • runtime/JSCell.h:

(JSC::JSCell::cellStateOffset):

  • runtime/JSCellInlines.h:

(JSC::JSCell::vm):
(JSC::ExecState::vm):
(JSC::JSCell::classInfo):
(JSC::JSCell::callDestructor): Deleted.

  • runtime/JSFunction.cpp:

(JSC::JSFunction::create):
(JSC::JSFunction::allocateAndInitializeRareData):
(JSC::JSFunction::initializeRareData):
(JSC::JSFunction::getOwnPropertySlot):
(JSC::JSFunction::put):
(JSC::JSFunction::deleteProperty):
(JSC::JSFunction::defineOwnProperty):
(JSC::JSFunction::setFunctionName):
(JSC::JSFunction::reifyLength):
(JSC::JSFunction::reifyName):
(JSC::JSFunction::reifyLazyPropertyIfNeeded):
(JSC::JSFunction::reifyBoundNameIfNeeded):

  • runtime/JSFunction.h:
  • runtime/JSFunctionInlines.h:

(JSC::JSFunction::createWithInvalidatedReallocationWatchpoint):
(JSC::JSFunction::JSFunction):

  • runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::slowDownAndWasteMemory):

  • runtime/JSInternalPromise.cpp:
  • runtime/JSInternalPromiseConstructor.cpp:
  • runtime/JSInternalPromiseDeferred.cpp:
  • runtime/JSInternalPromisePrototype.cpp:
  • runtime/JSJob.cpp:
  • runtime/JSMapIterator.cpp:
  • runtime/JSModuleNamespaceObject.cpp:
  • runtime/JSModuleRecord.cpp:
  • runtime/JSObject.cpp:

(JSC::JSObject::copyButterfly):
(JSC::JSObject::visitButterfly):
(JSC::JSObject::copyBackingStore):
(JSC::JSObject::notifyPresenceOfIndexedAccessors):
(JSC::JSObject::createInitialIndexedStorage):
(JSC::JSObject::createInitialUndecided):
(JSC::JSObject::createInitialInt32):
(JSC::JSObject::createInitialDouble):
(JSC::JSObject::createInitialContiguous):
(JSC::JSObject::createArrayStorage):
(JSC::JSObject::createInitialArrayStorage):
(JSC::JSObject::convertUndecidedToInt32):
(JSC::JSObject::convertUndecidedToContiguous):
(JSC::JSObject::convertUndecidedToArrayStorage):
(JSC::JSObject::convertInt32ToDouble):
(JSC::JSObject::convertInt32ToArrayStorage):
(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):
(JSC::JSObject::putByIndexBeyondVectorLength):
(JSC::JSObject::putDirectIndexBeyondVectorLength):
(JSC::JSObject::getNewVectorLength):
(JSC::JSObject::increaseVectorLength):
(JSC::JSObject::ensureLengthSlow):
(JSC::JSObject::growOutOfLineStorage):

  • runtime/JSObject.h:

(JSC::JSObject::putDirectInternal):
(JSC::JSObject::setStructureAndReallocateStorageIfNecessary):
(JSC::JSObject::globalObject): Deleted.

  • runtime/JSObjectInlines.h:
  • runtime/JSPromise.cpp:
  • runtime/JSPromiseConstructor.cpp:
  • runtime/JSPromiseDeferred.cpp:
  • runtime/JSPromisePrototype.cpp:
  • runtime/JSPropertyNameIterator.cpp:
  • runtime/JSScope.cpp:

(JSC::JSScope::resolve):

  • runtime/JSScope.h:

(JSC::JSScope::vm):
(JSC::JSScope::globalObject): Deleted.

  • runtime/JSSetIterator.cpp:
  • runtime/JSStringIterator.cpp:
  • runtime/JSTemplateRegistryKey.cpp:
  • runtime/JSTypedArrayViewConstructor.cpp:
  • runtime/JSTypedArrayViewPrototype.cpp:
  • runtime/JSWeakMap.cpp:
  • runtime/JSWeakSet.cpp:
  • runtime/MapConstructor.cpp:
  • runtime/MapIteratorPrototype.cpp:
  • runtime/MapPrototype.cpp:
  • runtime/NativeErrorConstructor.cpp:
  • runtime/NativeStdFunctionCell.cpp:
  • runtime/Operations.h:

(JSC::scribbleFreeCells): Deleted.
(JSC::scribble): Deleted.

  • runtime/Options.h:
  • runtime/PropertyTable.cpp:
  • runtime/ProxyConstructor.cpp:
  • runtime/ProxyObject.cpp:
  • runtime/ProxyRevoke.cpp:
  • runtime/RegExp.cpp:

(JSC::RegExp::match):
(JSC::RegExp::matchConcurrently):
(JSC::RegExp::matchCompareWithInterpreter):

  • runtime/RegExp.h:
  • runtime/RegExpConstructor.h:
  • runtime/RegExpInlines.h:

(JSC::RegExp::matchInline):

  • runtime/RegExpMatchesArray.h:

(JSC::tryCreateUninitializedRegExpMatchesArray):
(JSC::createRegExpMatchesArray):

  • runtime/RegExpPrototype.cpp:

(JSC::genericSplit):

  • runtime/RuntimeType.cpp:
  • runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::processUnverifiedStackTraces):

  • runtime/SetConstructor.cpp:
  • runtime/SetIteratorPrototype.cpp:
  • runtime/SetPrototype.cpp:
  • runtime/StackFrame.cpp: Removed.
  • runtime/StackFrame.h: Removed.
  • runtime/StringConstructor.cpp:
  • runtime/StringIteratorPrototype.cpp:
  • runtime/TemplateRegistry.cpp:
  • runtime/TestRunnerUtils.cpp:

(JSC::finalizeStatsAtEndOfTesting): Deleted.

  • runtime/TestRunnerUtils.h:
  • runtime/TypeProfilerLog.cpp:
  • runtime/TypeSet.cpp:
  • runtime/VM.cpp:

(JSC::VM::ensureStackCapacityForCLoop): Deleted.
(JSC::VM::isSafeToRecurseSoftCLoop): Deleted.

  • runtime/VM.h:
  • runtime/VMEntryScope.h:
  • runtime/VMInlines.h:

(JSC::VM::ensureStackCapacityFor):
(JSC::VM::isSafeToRecurseSoft):

  • runtime/WeakMapConstructor.cpp:
  • runtime/WeakMapData.cpp:
  • runtime/WeakMapPrototype.cpp:
  • runtime/WeakSetConstructor.cpp:
  • runtime/WeakSetPrototype.cpp:
  • testRegExp.cpp:

(testOneRegExp):

  • tools/JSDollarVM.cpp:
  • tools/JSDollarVMPrototype.cpp:

(JSC::JSDollarVMPrototype::isInObjectSpace):

Source/WebCore:

  • ForwardingHeaders/heap/HeapInlines.h: Removed.
  • ForwardingHeaders/interpreter/Interpreter.h: Added.
  • ForwardingHeaders/runtime/AuxiliaryBarrierInlines.h: Removed.
  • Modules/indexeddb/IDBCursorWithValue.cpp:
  • Modules/indexeddb/client/TransactionOperation.cpp:
  • Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:
  • bindings/js/JSApplePayPaymentAuthorizedEventCustom.cpp:
  • bindings/js/JSApplePayPaymentMethodSelectedEventCustom.cpp:
  • bindings/js/JSApplePayShippingContactSelectedEventCustom.cpp:
  • bindings/js/JSApplePayShippingMethodSelectedEventCustom.cpp:
  • bindings/js/JSClientRectCustom.cpp:
  • bindings/js/JSDOMBinding.cpp:
  • bindings/js/JSDOMBinding.h:
  • bindings/js/JSDeviceMotionEventCustom.cpp:
  • bindings/js/JSDeviceOrientationEventCustom.cpp:
  • bindings/js/JSErrorEventCustom.cpp:
  • bindings/js/JSIDBCursorWithValueCustom.cpp:
  • bindings/js/JSIDBIndexCustom.cpp:
  • bindings/js/JSPopStateEventCustom.cpp:
  • bindings/js/JSWebGL2RenderingContextCustom.cpp:
  • bindings/js/JSWorkerGlobalScopeCustom.cpp:
  • bindings/js/WorkerScriptController.cpp:
  • contentextensions/ContentExtensionParser.cpp:
  • dom/ErrorEvent.cpp:
  • html/HTMLCanvasElement.cpp:
  • html/MediaDocument.cpp:
  • inspector/CommandLineAPIModule.cpp:
  • loader/EmptyClients.cpp:
  • page/CaptionUserPreferences.cpp:
  • page/Frame.cpp:
  • page/PageGroup.cpp:
  • page/UserContentController.cpp:
  • platform/mock/mediasource/MockBox.cpp:
  • testing/GCObservation.cpp:

Source/WebKit2:

  • UIProcess/ViewGestureController.cpp:
  • UIProcess/WebPageProxy.cpp:
  • UIProcess/WebProcessPool.cpp:
  • UIProcess/WebProcessProxy.cpp:
  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
  • WebProcess/Plugins/Netscape/JSNPObject.cpp:

Source/WTF:

  • wtf/FastMalloc.cpp:

(WTF::tryFastAlignedMalloc): Deleted.

  • wtf/FastMalloc.h:
  • wtf/ParkingLot.cpp:

(WTF::ParkingLot::forEach):
(WTF::ParkingLot::forEachImpl): Deleted.

  • wtf/ParkingLot.h:

(WTF::ParkingLot::parkConditionally):
(WTF::ParkingLot::unparkOne):
(WTF::ParkingLot::forEach): Deleted.

  • wtf/ScopedLambda.h:

(WTF::scopedLambdaRef): Deleted.

Tools:

  • DumpRenderTree/TestRunner.cpp:
  • DumpRenderTree/mac/DumpRenderTree.mm:

(DumpRenderTreeMain):

  • Scripts/run-jsc-stress-tests:
  • TestWebKitAPI/Tests/WTF/Vector.cpp:

(TestWebKitAPI::TEST):

LayoutTests:

11:53 AM Changeset in webkit [204911] by andersca@apple.com
  • 2 edits in trunk/Source/WebKit2

In some cases, an IPC::Connection won't know when the other end has gone away
https://bugs.webkit.org/show_bug.cgi?id=161153
rdar://problem/27896368

Reviewed by Dan Bernstein.

When being asked to invalidate a connection that isn't yet connected, make sure to release
our send and receive rights so that the other end will get a failure when trying to connect.

  • Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::platformInvalidate):

11:44 AM Changeset in webkit [204910] by Simon Fraser
  • 2 edits in trunk/Tools

Try to fix Production builds.

PRODUCTION_FRAMEWORKS_DIR was undefined here.

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
11:35 AM Changeset in webkit [204909] by mitz@apple.com
  • 5 edits
    1 add in trunk

Add a convenience function for creating a WKFrameHandleRef from a WKFrameRef without going through WKFrameInfoRef
https://bugs.webkit.org/show_bug.cgi?id=161152

Reviewed by Anders Carlsson.

Source/WebKit2:

  • UIProcess/API/C/WKFrame.cpp:

(WKFrameCreateFrameHandle): Added. Creates a handle with the frame’s frameID.

  • UIProcess/API/C/WKFrame.h:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2/FrameHandle.cpp: Added.

(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::TEST):

11:33 AM Changeset in webkit [204908] by Alan Bujtas
  • 5 edits
    2 adds in trunk

ASSERTION FAILED: childrenInline() in WebCore::RenderBlockFlow::hasLines
https://bugs.webkit.org/show_bug.cgi?id=139396
<rdar://problem/27704339>

Reviewed by David Hyatt.

Source/WebCore:

RenderBlockFlow::hasLines() should be able to handle the block-children case.

Test: fast/ruby/assert-with-block-rt-child-and-emphasis.html

  • rendering/RenderBlock.h:

(WebCore::RenderBlock::hasLines): Deleted.

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::hasLines):

  • rendering/RenderBlockFlow.h:

LayoutTests:

  • fast/ruby/assert-with-block-rt-child-and-emphasis-expected.txt: Added.
  • fast/ruby/assert-with-block-rt-child-and-emphasis.html: Added.
11:33 AM Changeset in webkit [204907] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

[Win] http server is not starting.
https://bugs.webkit.org/show_bug.cgi?id=161134

Reviewed by Alexey Proskuryakov.

Avoid setting the php ini folder twice, it is not allowed by xampp.

  • http/conf/apache2.4-httpd-win.conf:
11:12 AM Changeset in webkit [204906] by n_wang@apple.com
  • 4 edits
    2 adds in trunk

AX: Add test for line text marker range on iOS
https://bugs.webkit.org/show_bug.cgi?id=161108
<rdar://problem/27976405>

Reviewed by Chris Fleizach.

Tools:

  • DumpRenderTree/ios/AccessibilityUIElementIOS.mm:

(AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
(AccessibilityUIElement::textMarkerRangeForElement):

  • WebKitTestRunner/InjectedBundle/ios/AccessibilityUIElementIOS.mm:

(WTR::AccessibilityUIElement::lineTextMarkerRangeForTextMarker):
(WTR::AccessibilityUIElement::textMarkerRangeForElement):

LayoutTests:

Added a new test to test line text marker ranges on iOS.

  • accessibility/ios-simulator/text-marker-range-for-line-expected.txt: Added.
  • accessibility/ios-simulator/text-marker-range-for-line.html: Added.
10:54 AM Changeset in webkit [204905] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit2

[Cocoa] Can’t "po" WKObject instances
https://bugs.webkit.org/show_bug.cgi?id=161151

Reviewed by Anders Carlsson.

  • Shared/Cocoa/WKObject.mm:

(-[WKObject debugDescription]): Implement and forward to the target or print a generic

description.

10:35 AM Changeset in webkit [204904] by beidson@apple.com
  • 2 edits in trunk/LayoutTests

Changing gamepad test to try to get more info about the failure mode on the bots.

Unreviewed.

  • gamepad/gamepad-timestamp.html:
10:15 AM Changeset in webkit [204903] by Ryan Haddad
  • 1 edit
    6 adds in trunk/LayoutTests

Add ios-simulator baseline for newly imported test.
https://bugs.webkit.org/show_bug.cgi?id=161143

Unreviewed test gardening.

  • platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-samedoc-expected.txt: Added.
10:06 AM Changeset in webkit [204902] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed, temporarily mark imported/w3c/web-platform-tests/html/dom/interfaces.html as flaky.

9:55 AM Changeset in webkit [204901] by fpizlo@apple.com
  • 5 edits in trunk

js/regress/put-by-id-transition-with-indexing-header.html and svg/carto.net/window.svg fail in debug after r204854
https://bugs.webkit.org/show_bug.cgi?id=161115

Reviewed by Keith Miller.
Source/JavaScriptCore:


There were two small goofs.

  • bytecode/ObjectAllocationProfile.h:

(JSC::ObjectAllocationProfile::isNull): The new policy is that the allocator can be null. So now the way you tell if the profile is null is by checking the structure.

  • jit/JITOperations.cpp: This was using DeferGC, which is now definitely wrong. It forces the GC to happen when the structure and butterfly are mismatched. It's better for the GC to happen before we put the butterfly in the object.

LayoutTests:

9:47 AM Changeset in webkit [204900] by mark.lam@apple.com
  • 2 edits in trunk/LayoutTests

Gardening: restoring 2 test expectations removed in r204870 by mistake.
https://bugs.webkit.org/show_bug.cgi?id=161096

Not reviewed.

9:40 AM Changeset in webkit [204899] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Temporarily skip inspector/codemirror tests on mac-wk1 debug.
https://bugs.webkit.org/show_bug.cgi?id=161117

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
9:26 AM Changeset in webkit [204898] by ap@apple.com
  • 2 edits in trunk

Add svn:global-ignores to the root to ignore *.pyc files everythere in the repository.

  • .: Added property svn:global-ignores.
9:23 AM Changeset in webkit [204897] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

AssemblyHelpers::emitAllocateWithNonNullAllocator() crashes in the FTL on ARM64
https://bugs.webkit.org/show_bug.cgi?id=161138
rdar://problem/27985868

Reviewed by Saam Barati.

The FTL expects that this method can be used with scratch registers disallowed, but it
uses addPtr(Addr, Reg).

The solution is to only use addPtr(Addr, Reg) on x86.

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::emitAllocateWithNonNullAllocator):

9:22 AM Changeset in webkit [204896] by beidson@apple.com
  • 11 edits
    2 adds in trunk

Get timestamps and ids working in WK2 gamepads (and test them!)
https://bugs.webkit.org/show_bug.cgi?id=161112

Reviewed by Alex Christensen.

Source/WebKit2:

  • Shared/Gamepad/GamepadData.cpp:

(WebKit::GamepadData::GamepadData):
(WebKit::GamepadData::encode):
(WebKit::GamepadData::decode):

  • Shared/Gamepad/GamepadData.h:

(WebKit::GamepadData::id):
(WebKit::GamepadData::index): Deleted.

  • UIProcess/Gamepad/UIGamepad.cpp:

(WebKit::UIGamepad::UIGamepad):
(WebKit::UIGamepad::condensedGamepadData):
(WebKit::UIGamepad::fullGamepadData): Include the ID for initial WebGamepad creation.
(WebKit::UIGamepad::gamepadData): Deleted.

  • UIProcess/Gamepad/UIGamepad.h:
  • UIProcess/Gamepad/UIGamepadProvider.cpp:

(WebKit::UIGamepadProvider::snapshotGamepads):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::gamepadConnected):
(WebKit::WebProcessPool::setInitialConnectedGamepads):

  • WebProcess/Gamepad/WebGamepad.cpp:

(WebKit::WebGamepad::WebGamepad):
(WebKit::WebGamepad::updateValues):

LayoutTests:

  • gamepad/gamepad-polling-access-expected.txt:
  • gamepad/gamepad-polling-access.html:
  • gamepad/gamepad-timestamp-expected.txt: Added.
  • gamepad/gamepad-timestamp.html: Added.
6:35 AM Changeset in webkit [204895] by gskachkov@gmail.com
  • 9 edits in trunk

2016] Allow assignment in for-in head in not-strict mode
https://bugs.webkit.org/show_bug.cgi?id=160955

Reviewed by Saam Barati.

This patch allow make assignment in for..in head in not-strict mode,
according to the spec https://tc39.github.io/ecma262/#sec-initializers-in-forin-statement-heads

Source/JavaScriptCore:

  • bytecompiler/NodesCodegen.cpp:

(JSC::ForInNode::emitLoopHeader):
(JSC::ForInNode::emitMultiLoopBytecode):

  • parser/Nodes.h:

(JSC::ExpressionNode::isAssignResolveNode):
(JSC::AssignResolveNode::identifier):
(JSC::ExpressionNode::isResolveNode): Deleted.

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseForStatement):

JSTests:

  • stress/for-in-tests.js:

(foo):
(boo):
(catch):

LayoutTests:

  • js/parser-syntax-check-expected.txt:
  • js/script-tests/parser-syntax-check.js:
3:42 AM Changeset in webkit [204894] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebCore

Unreviewed. Fix GObject DOM bindings API break after r204624 and r204648.

prefix, namespaceURI and localName attributes were moved from Node to Attr/Element in r204624 and prefix was
also made readonly in r204648.

  • bindings/gobject/WebKitDOMDeprecated.cpp:

(webkit_dom_node_get_namespace_uri):
(webkit_dom_node_get_prefix):
(webkit_dom_node_set_prefix):
(webkit_dom_node_get_local_name):

  • bindings/gobject/WebKitDOMDeprecated.h:
  • bindings/gobject/WebKitDOMDeprecated.symbols:
  • bindings/gobject/webkitdom.symbols:
2:29 AM Changeset in webkit [204893] by Hunseop Jeong
  • 3 edits in trunk/Source/WebKit2

[EFL] Fix test_ewk2_view
https://bugs.webkit.org/show_bug.cgi?id=161131

Reviewed by Gyuyoung Kim.

ewk_view_title_changed: null is treated as the string "null" after r203487.

ewk_view_page_contents_get: aligned encoding labels after r204605.

  • UIProcess/API/efl/tests/resources/resultMHTML.mht:
  • UIProcess/API/efl/tests/test_ewk2_view.cpp:

(TEST_F):

1:59 AM Changeset in webkit [204892] by pvollan@apple.com
  • 4 edits in trunk/Tools

[Win] Warning fixes.
https://bugs.webkit.org/show_bug.cgi?id=161079

Reviewed by Brent Fulgham.

  • MiniBrowser/win/WebDownloadDelegate.cpp:
  • MiniBrowser/win/WinMain.cpp:
  • TestWebKitAPI/Tests/WTF/WTFString.cpp:

(TestWebKitAPI::TEST):

1:07 AM Changeset in webkit [204891] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk/LayoutTests

[Fetch API] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=161128

Unreviewed.

Patch by Youenn Fablet <youenn@apple.com> on 2016-08-24

  • TestExpectations:
  • platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt:
  • platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-worker-expected.txt:
  • platform/gtk/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-location-worker-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/fetch/api/redirect/redirect-method-worker-expected.txt: Added.
  • platform/mac-wk2/TestExpectations:
  • platform/win/TestExpectations:
12:55 AM Changeset in webkit [204890] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.12.4

WebKitGTK+ 2.12.4

12:52 AM Changeset in webkit [204889] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.12

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.12.4 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

  • gtk/NEWS: Add release notes for 2.12.4.
Note: See TracTimeline for information about the timeline view.