Context Navigation

← Previous Period
Next Period →

Timeline

Dec 17, 2016:

10:07 PM Changeset in webkit [209970] by jh718.park@samsung.com

4 edits in trunk

[EFL] bump EFL version to 1.18.4
https://bugs.webkit.org/show_bug.cgi?id=166004

Reviewed by Gyuyoung Kim.

Source/cmake/OptionsEfl.cmake: Use efl-1.18.4 instead of 1.18.1.

Tools:

efl/jhbuild.modules: Use efl-1.18.4 instead of 1.18.1.

12:08 PM Changeset in webkit [209969] by hyatt@apple.com

52 edits
6 moves
9 adds in trunk/Source

[CSS Values] Make separate wrapper classes for the deprecated CSS Values OM
https://bugs.webkit.org/show_bug.cgi?id=165968

Reviewed by Andreas Kling.

Source/WebCore:

This patch changes the CSS OM for values to use distinct wrapper
classes instead of cloning the existing classes. By actually wrapping
values instead of cloning, we are freed up to change our CSS value hierarchy
however we'd like (such as changing to match the new CSS Values OM that
is coming soon).

All of the CSS Values wrapper classes are prefixed with "DeprecatedCSSOM"
to reflect our desire (ultimately) to remove this API from our tree. We're
the only ones that support it, and it's not used on the Web, but it is part
of the WebKitLegacy API and might be used internally.

CMakeLists.txt:
DerivedSources.cpp:
DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/js/DOMWrapperWorld.h:
bindings/js/JSCSSStyleDeclarationCustom.cpp:

(WebCore::JSCSSStyleDeclaration::getPropertyCSSValue):

bindings/js/JSCSSValueCustom.cpp:

(WebCore::JSDeprecatedCSSOMValueOwner::isReachableFromOpaqueRoots):
(WebCore::JSDeprecatedCSSOMValueOwner::finalize):
(WebCore::toJSNewlyCreated):
(WebCore::toJS):
(WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots): Deleted.
(WebCore::JSCSSValueOwner::finalize): Deleted.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

css/CSSComputedStyleDeclaration.h:
css/CSSGridLineNamesValue.cpp:

(WebCore::CSSGridLineNamesValue::cloneForCSSOM): Deleted.

css/CSSGridLineNamesValue.h:
css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::cloneForCSSOM): Deleted.

css/CSSImageSetValue.h:
css/CSSImageValue.cpp:

(WebCore::CSSImageValue::createDeprecatedCSSOMWrapper):
(WebCore::CSSImageValue::cloneForCSSOM): Deleted.

css/CSSImageValue.h:
css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::createDeprecatedCSSOMPrimitiveWrapper):
(WebCore::CSSPrimitiveValue::cloneForCSSOM): Deleted.

css/CSSPrimitiveValue.h:
css/CSSPrimitiveValue.idl: Removed.
css/CSSStyleDeclaration.h:
css/CSSStyleDeclaration.idl:
css/CSSValue.cpp:

(WebCore::CSSValue::traverseSubresources):
(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::createDeprecatedCSSOMWrapper):
(): Deleted.
(WebCore::CSSValue::cloneForCSSOM): Deleted.

css/CSSValue.h:

(WebCore::CSSValue::CSSValue):
(WebCore::CSSValue::setCssText): Deleted.
(WebCore::CSSValue::isCSSOMSafe): Deleted.
(WebCore::CSSValue::isSubtypeExposedToCSSOM): Deleted.

css/CSSValue.idl: Removed.
css/CSSValueList.cpp:

(WebCore::CSSValueList::cloneForCSSOM): Deleted.

css/CSSValueList.h:

(WebCore::CSSValueList::separator):

css/CSSValueList.idl: Removed.
css/Counter.h:
css/Counter.idl: Removed.
css/DeprecatedCSSOMCounter.h: Added.
css/DeprecatedCSSOMCounter.idl: Copied from Source/WebCore/css/Counter.idl.
css/DeprecatedCSSOMPrimitiveValue.cpp: Added.

(WebCore::DeprecatedCSSOMPrimitiveValue::getCounterValue):
(WebCore::DeprecatedCSSOMPrimitiveValue::getRectValue):
(WebCore::DeprecatedCSSOMPrimitiveValue::getRGBColorValue):

css/DeprecatedCSSOMPrimitiveValue.h: Added.

(WebCore::DeprecatedCSSOMPrimitiveValue::create):
(WebCore::DeprecatedCSSOMPrimitiveValue::equals):
(WebCore::DeprecatedCSSOMPrimitiveValue::cssValueType):
(WebCore::DeprecatedCSSOMPrimitiveValue::cssText):
(WebCore::DeprecatedCSSOMPrimitiveValue::primitiveType):
(WebCore::DeprecatedCSSOMPrimitiveValue::setFloatValue):
(WebCore::DeprecatedCSSOMPrimitiveValue::getFloatValue):
(WebCore::DeprecatedCSSOMPrimitiveValue::setStringValue):
(WebCore::DeprecatedCSSOMPrimitiveValue::getStringValue):
(WebCore::DeprecatedCSSOMPrimitiveValue::stringValue):
(WebCore::DeprecatedCSSOMPrimitiveValue::DeprecatedCSSOMPrimitiveValue):

css/DeprecatedCSSOMPrimitiveValue.idl: Copied from Source/WebCore/css/CSSPrimitiveValue.idl.
css/DeprecatedCSSOMRGBColor.h: Added.
css/DeprecatedCSSOMRGBColor.idl: Copied from Source/WebCore/css/RGBColor.idl.
css/DeprecatedCSSOMRect.h: Added.
css/DeprecatedCSSOMRect.idl: Copied from Source/WebCore/css/Rect.idl.
css/DeprecatedCSSOMValue.cpp: Added.

(WebCore::compareCSSOMValues):
(WebCore::DeprecatedCSSOMValue::equals):
(WebCore::DeprecatedCSSOMValue::destroy):
(WebCore::DeprecatedCSSOMValue::cssValueType):
(WebCore::DeprecatedCSSOMValue::cssText):

css/DeprecatedCSSOMValue.h: Added.

(WebCore::DeprecatedCSSOMValue::deref):
(WebCore::DeprecatedCSSOMValue::setCssText):
(WebCore::DeprecatedCSSOMValue::operator==):
(WebCore::DeprecatedCSSOMValue::isComplexValue):
(WebCore::DeprecatedCSSOMValue::isPrimitiveValue):
(WebCore::DeprecatedCSSOMValue::isValueList):
(WebCore::DeprecatedCSSOMValue::classType):
(WebCore::DeprecatedCSSOMValue::DeprecatedCSSOMValue):
(WebCore::DeprecatedCSSOMValue::~DeprecatedCSSOMValue):
(WebCore::DeprecatedCSSOMComplexValue::create):
(WebCore::DeprecatedCSSOMComplexValue::equals):
(WebCore::DeprecatedCSSOMComplexValue::cssText):
(WebCore::DeprecatedCSSOMComplexValue::cssValueType):
(WebCore::DeprecatedCSSOMComplexValue::DeprecatedCSSOMComplexValue):

css/DeprecatedCSSOMValue.idl: Copied from Source/WebCore/css/CSSValue.idl.
css/DeprecatedCSSOMValueList.cpp: Added.

(WebCore::DeprecatedCSSOMValueList::equals):
(WebCore::DeprecatedCSSOMValueList::cssText):

css/DeprecatedCSSOMValueList.h: Added.

(WebCore::DeprecatedCSSOMValueList::create):
(WebCore::DeprecatedCSSOMValueList::cssValueType):
(WebCore::DeprecatedCSSOMValueList::length):
(WebCore::DeprecatedCSSOMValueList::item):
(WebCore::DeprecatedCSSOMValueList::DeprecatedCSSOMValueList):

css/DeprecatedCSSOMValueList.idl: Copied from Source/WebCore/css/CSSValueList.idl.
css/LengthRepeat.h:
css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::getPropertyCSSValue):
(WebCore::PropertySetCSSStyleDeclaration::wrapForDeprecatedCSSOM):
(WebCore::StyleRuleCSSStyleDeclaration::didMutate):
(WebCore::InlineCSSStyleDeclaration::didMutate):
(WebCore::PropertySetCSSStyleDeclaration::cloneAndCacheForCSSOM): Deleted.

css/PropertySetCSSStyleDeclaration.h:
css/RGBColor.cpp:

(WebCore::RGBColor::red): Deleted.
(WebCore::RGBColor::green): Deleted.
(WebCore::RGBColor::blue): Deleted.
(WebCore::RGBColor::alpha): Deleted.

css/RGBColor.h:
css/RGBColor.idl: Removed.
css/Rect.h:

(WebCore::RectBase::RectBase):

css/Rect.idl: Removed.
svg/SVGElement.cpp:

(WebCore::SVGElement::getPresentationAttribute):

svg/SVGElement.h:
svg/SVGElement.idl:

Source/WebKit/mac:

DOM/DOMCSS.mm:

(kitClass):

DOM/DOMCSSPrimitiveValue.mm:

(-[DOMCSSPrimitiveValue getCounterValue]):
(-[DOMCSSPrimitiveValue getRectValue]):
(kit):

DOM/DOMCSSPrimitiveValueInternal.h:
DOM/DOMCSSStyleDeclaration.mm:
DOM/DOMCSSValue.mm:

(kit):

DOM/DOMCSSValueInternal.h:
DOM/DOMCSSValueList.mm:
DOM/DOMCounter.mm:

(kit):

DOM/DOMCounterInternal.h:
DOM/DOMRGBColor.mm:

(kit):

DOM/DOMRGBColorInternal.h:
DOM/DOMRect.mm:

(kit):

DOM/DOMRectInternal.h:
DOM/DOMUtility.mm:

(createDOMWrapper):

Source/WebKit2:

WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMCSSValue.cpp:

(WebKit::kit):
(WebKit::core):
(WebKit::wrapCSSValue):
(webkit_dom_css_value_constructor):
(webkit_dom_css_value_get_css_text):
(webkit_dom_css_value_set_css_text):
(webkit_dom_css_value_get_css_value_type):

WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMCSSValuePrivate.h:

11:32 AM Changeset in webkit [209968] by Philippe Normand

9 edits
3 deletes in trunk

Unreviewed, rollout r209860 OWR player shouldn't be selected for
normal video playback

Source/WebCore:

platform/GStreamer.cmake:
platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:

(WebCore::MediaPlayerPrivateGStreamerOwr::~MediaPlayerPrivateGStreamerOwr):
(WebCore::MediaPlayerPrivateGStreamerOwr::play):
(WebCore::MediaPlayerPrivateGStreamerOwr::pause):
(WebCore::MediaPlayerPrivateGStreamerOwr::load):
(WebCore::MediaPlayerPrivateGStreamerOwr::stop):
(WebCore::MediaPlayerPrivateGStreamerOwr::trackEnded):
(WebCore::MediaPlayerPrivateGStreamerOwr::trackEnabledChanged):
(WebCore::MediaPlayerPrivateGStreamerOwr::setSize):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.h:
platform/mediastream/openwebrtc/MediaEndpointOwr.cpp:

(WebCore::MediaEndpointOwr::createMutedRemoteSource):

platform/mediastream/openwebrtc/RealtimeAudioSourceOwr.h: Removed.
platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:

(WebCore::RealtimeMediaSourceCenterOwr::mediaSourcesAvailable):

platform/mediastream/openwebrtc/RealtimeMediaSourceOwr.cpp: Removed.
platform/mediastream/openwebrtc/RealtimeMediaSourceOwr.h:
platform/mediastream/openwebrtc/RealtimeVideoSourceOwr.h: Removed.

LayoutTests:

platform/gtk/TestExpectations:

11:18 AM Changeset in webkit [209967] by Wenson Hsieh

46 edits
2 adds in trunk

Visual viewports: bottom fixed elements disappear behind the keyboard
https://bugs.webkit.org/show_bug.cgi?id=165983
<rdar://problem/29409852>

Reviewed by Simon Fraser.

Source/WebKit2:

Accounts for input view bounds in WebPageProxy::computeCustomFixedPositionRect. To do this, we introduce and
pass unobscuredContentRectRespectingInputViewBounds along with the regular unobscuredContentRect (which does not
respect the obscuring keyboard rect). This unobscuredContentRectRespectingInputViewBounds is then used when
computing the origin of the updated layout viewport rect (and also, when we are _not_ below minimum scale),

Additionally, the size is computed using the (unconstrained) unobscured rect. This is because we previously
would use the document-constrained version of the unobscured rect, which caused the layout viewport to shrink
when approaching the max scroll extents of the document while the keyboard is up, since the unobscured rect
would spill out of the document rect. However, using this unconstrained rect's size also means that if the user
rubber-bands out of the document rect, we would end up pushing the layout viewport rect out of the document,
with no way of adjusting it back in without the user scrolling to push the layout viewport into back document
bounds. To address this, we move the layout rect to be within document bounds after computing its size and
location.

Added a new layout test: fast/visual-viewport/ios/fixed-element-on-bottom-with-keyboard.html, and also tweaked
fixed-caret-position-after-scroll.html to cover these changes.

Shared/VisibleContentRectUpdateInfo.cpp:

(WebKit::operator<<):

Shared/VisibleContentRectUpdateInfo.h:

(WebKit::VisibleContentRectUpdateInfo::VisibleContentRectUpdateInfo):
(WebKit::VisibleContentRectUpdateInfo::unobscuredContentRectRespectingInputViewBounds):

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _updateContentRectsWithState:]):
(-[WKWebView _inputViewBounds]):

Returns the current bounds of the input view. For testing purposes.

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::unobscuredContentRectRespectingInputViewBounds):

UIProcess/ios/RemoteScrollingCoordinatorProxyIOS.mm:

(WebKit::RemoteScrollingCoordinatorProxy::customFixedPositionRect):

UIProcess/ios/WKContentView.h:
UIProcess/ios/WKContentView.mm:

(-[WKContentView _computeUnobscuredContentRectRespectingInputViewBounds:unobscuredContentRect:inputViewBounds:scale:]):

Helper to compute the unobscured rect, accounting for the bounds of the current input view.

(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:obscuredInset:inputViewBounds:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:enclosedInScrollableAncestorView:]):
(-[WKContentView _didCommitLayerTree:]):
(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:obscuredInset:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:enclosedInScrollableAncestorView:]): Deleted.

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::computeCustomFixedPositionRect):

UIProcess/mac/RemoteLayerTreeDrawingAreaProxy.mm:

(WebKit::RemoteLayerTreeDrawingAreaProxy::commitLayerTree):

Tools:

Add support for UIScriptController.inputViewBounds, which UI-side scripts may use to fetch the bounding rect of
the keyboard when it is up.

DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::inputViewBounds):

TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::inputViewBounds):

TestRunnerShared/UIScriptContext/UIScriptController.h:
WebKitTestRunner/ios/PlatformWebViewIOS.mm:

(WTR::viewRectForWindowRect):

Previously, we accounted for the status bar height by translating the entire web view down by the height of the
status bar. However, we did not shrink the height of the web view itself, which means that for tests which
involve scrolling past the end of the document, the bottom strip of the web view is out of bounds of the window.

(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::setWindowFrame):

WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::inputViewBounds):

LayoutTests:

Tweaked fixed-caret-position-after-scroll.html to account for the keyboard height, and also added a new layout
test, fixed-element-on-bottom-with-keyboard.html, which checks that the layout viewport does not change before
and after showing the keyboard, and that scrolling past the end of the document does not bump the layout
viewport past document bounds.

The rest of the changes here involve rebaselining existing tests to account for the height of the web view no
longer being equal to the height of the window.

editing/caret/ios/absolute-caret-position-after-scroll-expected.txt:
editing/caret/ios/absolute-caret-position-after-scroll.html:
editing/caret/ios/fixed-caret-position-after-scroll-expected.txt:
editing/caret/ios/fixed-caret-position-after-scroll.html:
editing/selection/ios/absolute-selection-after-scroll.html:
editing/selection/ios/fixed-selection-after-scroll.html:
fast/events/ios/keyboard-scrolling-distance-expected.txt:
fast/events/ios/keyboard-should-not-trigger-resize-expected.txt:
fast/events/ios/viewport-zooms-from-element-to-initial-scale-expected.txt:
fast/forms/ios/accessory-bar-navigation-expected.txt:
fast/forms/ios/focus-input-in-fixed-expected.txt:
fast/forms/ios/focus-input-in-iframe-expected.txt:
fast/forms/ios/focus-input-via-button-expected.txt:
fast/forms/ios/focus-input-via-button-no-scaling-expected.txt:
fast/forms/ios/focus-long-textarea-expected.txt:
fast/forms/ios/zoom-after-input-tap-expected.txt:
fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt:
fast/scrolling/ios/subpixel-overflow-scrolling-with-ancestor-expected.txt:
fast/viewport/ios/width-is-device-width-expected.txt:
fast/visual-viewport/ios/fixed-element-on-bottom-with-keyboard-expected.txt: Added.
fast/visual-viewport/ios/fixed-element-on-bottom-with-keyboard.html: Added.
fast/visual-viewport/ios/zoomed-focus-in-fixed-expected.txt:
platform/ios-simulator/fast/scrolling/ios/clipping-ancestor-with-accelerated-scrolling-ancestor-expected.txt:
platform/ios-simulator/fast/scrolling/ios/overflow-scrolling-ancestor-clip-expected.txt:
platform/ios-simulator/fast/scrolling/ios/overflow-scrolling-ancestor-clip-size-expected.txt:
platform/ios-simulator/fast/scrolling/ios/scrolling-content-clip-to-viewport-expected.txt:
platform/ios-simulator/fast/scrolling/ios/touch-stacking-expected.txt:
scrollingcoordinator/ios/non-stable-viewport-scroll-expected.txt:
scrollingcoordinator/ios/ui-scrolling-tree-expected.txt:

10:44 AM Changeset in webkit [209966] by sbarati@apple.com

2 edits in trunk/Source/JavaScriptCore

WebAssembly: WasmB3IRGenerator uses WarmAny as a ValueRep but expects the incoming value to be a register
https://bugs.webkit.org/show_bug.cgi?id=165989

Reviewed by Mark Lam.

The input should be constrained to a register to match what
the patchpoint code expects.

wasm/WasmB3IRGenerator.cpp:

10:13 AM Changeset in webkit [209965] by Michael Catanzaro

2 edits in trunk/Source/WebCore

warning: the compiler can assume that the address of 'thisObject' will always evaluate to 'true' [-Waddress] in WebCore::JSHTMLDocument::getOwnPropertySlot
https://bugs.webkit.org/show_bug.cgi?id=165987

Reviewed by Mark Lam.

Work around the warning by passing the JSObject pointer this function receives directly to
ASSERT_GC_OBJECT_INHERITS, instead of casting it to a reference and then taking the address
of that, to avoid the -Waddress warning.

bindings/js/JSHTMLDocumentCustom.cpp:

(WebCore::JSHTMLDocument::getOwnPropertySlot):

9:18 AM Changeset in webkit [209964] by jer.noble@apple.com

21 edits
11 adds
1 delete in trunk

Add implementation for navigator.requestMediaKeySystemAccess()
https://bugs.webkit.org/show_bug.cgi?id=165850

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/encrypted-media/mock-navigator-requestMediaKeySystemAccess.html

Add an implementation of NavigatorEME::requestMediaKeySystemAccess() as well as the CDM
object on which it depends.

Modules/encryptedmedia/CDM.cpp: Added.

(WebCore::cdmFactories):
(WebCore::createCDMPrivateForKeySystem):
(WebCore::CDM::registerCDMFactory):
(WebCore::CDM::unregisterCDMFactory):
(WebCore::CDM::supportsKeySystem):
(WebCore::CDM::create):
(WebCore::CDM::CDM):
(WebCore::CDM::getSupportedConfiguration):
(WebCore::CDM::doSupportedConfigurationStep):
(WebCore::CDM::isPersistentType):
(WebCore::CDM::getSupportedCapabilitiesForAudioVideoType):
(WebCore::CDM::getConsentStatus):

Modules/encryptedmedia/CDM.h: Added.

(WebCore::CDMFactory::~CDMFactory):
(WebCore::CDM::keySystem):
(WebCore::CDM::createWeakPtr):

Modules/encryptedmedia/CDMPrivate.h: Added.

(WebCore::CDMPrivate::~CDMPrivate):

Modules/encryptedmedia/NavigatorEME.cpp:

(WebCore::NavigatorEME::requestMediaKeySystemAccess):
(WebCore::tryNextSupportedConfiguration):

Modules/encryptedmedia/NavigatorEME.h:
Modules/encryptedmedia/NavigatorEME.idl:

To aid in testing, a new Internals object is added, MockCDMFactory, which can be
controlled by LayoutTests to change the behavior of the Mock objects it creates.

testing/Internals.cpp:

(WebCore::Internals::registerMockCDM):

testing/Internals.h:
testing/Internals.idl:
testing/MockCDMFactory.cpp: Added.

(WebCore::MockCDMFactory::MockCDMFactory):
(WebCore::MockCDMFactory::~MockCDMFactory):
(WebCore::MockCDMFactory::unregister):
(WebCore::MockCDMFactory::supportsKeySystem):
(WebCore::MockCDMFactory::createCDM):
(WebCore::MockCDM::MockCDM):
(WebCore::MockCDM::supportsInitDataType):
(WebCore::MockCDM::supportsConfiguration):
(WebCore::MockCDM::supportsConfigurationWithRestrictions):
(WebCore::MockCDM::supportsSessionTypeWithConfiguration):
(WebCore::MockCDM::supportsRobustness):
(WebCore::MockCDM::distinctiveIdentifiersRequirement):
(WebCore::MockCDM::persistentStateRequirement):
(WebCore::MockCDM::distinctiveIdentifiersAreUniquePerOriginAndClearable):

testing/MockCDMFactory.h: Added.

(WebCore::MockCDMFactory::create):
(WebCore::MockCDMFactory::supportedDataTypes):
(WebCore::MockCDMFactory::setSupportedDataTypes):
(WebCore::MockCDMFactory::supportedRobustness):
(WebCore::MockCDMFactory::setSupportedRobustness):
(WebCore::MockCDMFactory::distinctiveIdentifiersRequirement):
(WebCore::MockCDMFactory::setDistinctiveIdentifiersRequirement):
(WebCore::MockCDMFactory::persistentStateRequirement):
(WebCore::MockCDMFactory::setPersistentStateRequirement):

testing/MockCDMFactory.idl: Added.

Move the MediaKeySessionType definition out of the MediaKeys.idl file and into its own.
Move the MediaKeysRequiriment definition out of the MediaKeySystemConfiguration.idl file
and into its own. Generally fix up the .idl files so that they properly work with their
implementation files.

Modules/encryptedmedia/MediaKeySessionType.idl: Added.
Modules/encryptedmedia/MediaKeySystemAccess.cpp:

(WebCore::MediaKeySystemAccess::create):
(WebCore::MediaKeySystemAccess::MediaKeySystemAccess):
(WebCore::MediaKeySystemAccess::keySystem): Deleted.
(WebCore::MediaKeySystemAccess::getConfiguration): Deleted.

Modules/encryptedmedia/MediaKeySystemAccess.h:

(WebCore::MediaKeySystemAccess::keySystem):
(WebCore::MediaKeySystemAccess::getConfiguration):
(WebCore::MediaKeySystemAccess::create): Deleted.

Modules/encryptedmedia/MediaKeySystemAccess.idl:
Modules/encryptedmedia/MediaKeySystemConfiguration.h:
Modules/encryptedmedia/MediaKeySystemConfiguration.idl:
Modules/encryptedmedia/MediaKeySystemMediaCapability.idl:
Modules/encryptedmedia/MediaKeys.idl:
Modules/encryptedmedia/MediaKeysRequirement.idl: Added.
Modules/encryptedmedia/MediaKeysRestrictions.h: Added.
bindings/js/JSMediaKeySystemAccessCustom.cpp: Removed.

As some of these enums are referenced in the Internals project, they need to be exported
from WebCore correctly. Teach the code generator how to export the symbols generated by
enums.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateEnumerationHeaderContent):

Add new files to the project.

CMakeLists.txt:
DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:

LayoutTests:

media/encrypted-media/mock-navigator-requestMediaKeySystemAccess-expected.txt: Added.
media/encrypted-media/mock-navigator-requestMediaKeySystemAccess.html: Added.
platform/ios-simulator/TestExpectations:
platform/mac/TestExpectations:

9:14 AM Changeset in webkit [209963] by sbarati@apple.com

2 edits in trunk/Source/JavaScriptCore

WebAssembly: Change a RELEASE_ASSERT_NOT_REACHED to a jit.breakpoint() for now to allow us to run some wasm benchmarks
https://bugs.webkit.org/show_bug.cgi?id=165990

Reviewed by Mark Lam.

wasm/WasmBinding.cpp:

(JSC::Wasm::importStubGenerator):

8:42 AM Changeset in webkit [209962] by Darin Adler

4 edits
2 deletes in trunk/Source/WebCore

Remove WebCore::Dictionary, which is now unused
https://bugs.webkit.org/show_bug.cgi?id=165988

Reviewed by Andreas Kling.

CMakeLists.txt: Removed the files.
WebCore.xcodeproj/project.pbxproj: Ditto.
bindings/js/Dictionary.cpp: Removed.
bindings/js/Dictionary.h: Removed.
bindings/js/JSBindingsAllInOne.cpp: Removed include of Dictionary.cpp.

2:33 AM Changeset in webkit [209961] by commit-queue@webkit.org

3 edits
5 adds in trunk

Cloned CachedResource should not have an empty response
https://bugs.webkit.org/show_bug.cgi?id=165947

Patch by Youenn Fablet <youenn@apple.com> on 2016-12-17
Reviewed by Sam Weinig.

Source/WebCore:

Test: http/tests/loading/reusing-cached-stylesheet-from-different-domain.html

loader/cache/CachedResource.cpp:

(WebCore::CachedResource::setBodyDataFrom): Copying the response to the cloned resource.
Even though the issue is appearing for stylesheets only, it is safer to do that for all cloned ressources.

LayoutTests:

This new test is working as follow:

A first frame is loaded. As part of it, it will load an absolute URL CSS stylesheet that contains a relative URL to import a CSS stylesheet.

This second stylesheet will make the background as green.

Once done, a second frame is loaded (same HTML but from a different domain) with the same absolute URL CSS stylesheet.

The relative URL stylesheet should use the absolute URL of the CSS stylesheet as base.
If it is using the frame as base, the loaded CSS will change background to red.

http/tests/loading/resources/cached-stylesheet-from-different-domain-frame.css.php: Added.
http/tests/loading/resources/cached-stylesheet-from-different-domain-frame.html: Added.
http/tests/loading/resources/imported-stylesheet-varying-according-domain.css.php: Added.
http/tests/loading/reusing-cached-stylesheet-from-different-domain-expected.html: Added.
http/tests/loading/reusing-cached-stylesheet-from-different-domain.html: Added.

Dec 16, 2016:

11:29 PM Changeset in webkit [209960] by beidson@apple.com

3 edits in trunk/Source/WebCore

IndexedDB: Refactor SQLiteIDBCursor to prepare for cursor prefetching.
https://bugs.webkit.org/show_bug.cgi?id=165978

Reviewed by Alex Christensen.

No new tests (Refactor, no behavior change).

In preparation for cursor prefetching, we need to shift the cursor off of keeping "the current record"
and onto keeping "a deque of fetched records", the first of which is "the current record".

This patch does just that, but with no behavior change; The deque only ever holds 0 or 1 records.

Modules/indexeddb/server/SQLiteIDBCursor.cpp:

(WebCore::IDBServer::SQLiteIDBCursor::currentData):
(WebCore::IDBServer::SQLiteIDBCursor::objectStoreRecordsChanged):
(WebCore::IDBServer::SQLiteIDBCursor::resetAndRebindStatement):
(WebCore::IDBServer::SQLiteIDBCursor::prefetch):
(WebCore::IDBServer::SQLiteIDBCursor::advance):
(WebCore::IDBServer::SQLiteIDBCursor::fetch):
(WebCore::IDBServer::SQLiteIDBCursor::fetchNextRecord):
(WebCore::IDBServer::SQLiteIDBCursor::markAsErrored):
(WebCore::IDBServer::SQLiteIDBCursor::internalFetchNextRecord):
(WebCore::IDBServer::SQLiteIDBCursor::iterate):
(WebCore::IDBServer::SQLiteIDBCursor::currentKey):
(WebCore::IDBServer::SQLiteIDBCursor::currentPrimaryKey):
(WebCore::IDBServer::SQLiteIDBCursor::currentValue):
(WebCore::IDBServer::SQLiteIDBCursor::didComplete):
(WebCore::IDBServer::SQLiteIDBCursor::didError):
(WebCore::IDBServer::SQLiteIDBCursor::currentRecordRowID):
(WebCore::IDBServer::SQLiteIDBCursor::advanceUnique): Deleted.
(WebCore::IDBServer::SQLiteIDBCursor::advanceOnce): Deleted.
(WebCore::IDBServer::SQLiteIDBCursor::internalAdvanceOnce): Deleted.

Modules/indexeddb/server/SQLiteIDBCursor.h:

(WebCore::IDBServer::SQLiteIDBCursor::SQLiteCursorRecord::isTerminalRecord):
(WebCore::IDBServer::SQLiteIDBCursor::currentRecordRowID): Deleted.
(WebCore::IDBServer::SQLiteIDBCursor::currentKey): Deleted.
(WebCore::IDBServer::SQLiteIDBCursor::currentPrimaryKey): Deleted.
(WebCore::IDBServer::SQLiteIDBCursor::currentValue): Deleted.
(WebCore::IDBServer::SQLiteIDBCursor::didComplete): Deleted.
(WebCore::IDBServer::SQLiteIDBCursor::didError): Deleted.

10:42 PM Changeset in webkit [209959] by Darin Adler

21 edits
4 copies
4 deletes in trunk

Remove all custom bindings from media streams, using dictionaries instead
https://bugs.webkit.org/show_bug.cgi?id=165943

Reviewed by Sam Weinig.

Source/WebCore:

CMakeLists.txt: Added and removed files.
DerivedSources.make: Ditto.

Modules/mediastream/DoubleRange.h: Added. Moved dictionary here so it can be shared

by both MediaStreamTrack and MediaTrackSupportedConstraints.

Modules/mediastream/DoubleRange.idl: Ditto.
Modules/mediastream/LongRange.h: Ditto.
Modules/mediastream/LongRange.idl: Ditto.

Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::getSupportedConstraints): Changed to return a struct instead
of a reference counted object.

Modules/mediastream/MediaDevices.h: Updated for the above.
Modules/mediastream/MediaDevices.idl: Added a conditional on the dictionary in this

file; not needed because the conditional on the interface automatically affects the
entire fiel, but for now the style seems to be to put these on all the dictionaries.

Modules/mediastream/MediaSourceSettings.cpp: Removed.
Modules/mediastream/MediaSourceSettings.h: Removed.

Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::getSettings): Changed to return a struct instead of a
reference counted object.
(WebCore::capabilityDoubleRange): Added. Helper for getCapabilities.
(WebCore::capabilityIntRange): Ditto.
(WebCore::capabilityStringVector): Ditto.
(WebCore::capabilityBooleanVector): Ditto.
(WebCore::MediaStreamTrack::getCapabilities): Changed to return a struct instead
of a reference counted object.

Modules/mediastream/MediaStreamTrack.h: Updated for the above changes. Also

defined the structs here in the class.

Modules/mediastream/MediaStreamTrack.idl: Defined the two dictionaries here and

changed the functions to return them and not use [Custom] any more.

Modules/mediastream/MediaTrackConstraints.h: Moved DoubleRange and LongRange out

of this file and into their own headers. Also removed the currently unimplemented
latency and channelCount; there are FIXME comments in the IDL file about eventually
adding these to match the specification.

Modules/mediastream/MediaTrackConstraints.idl: Added conditionals, and removed

the unimplemented latency and channelCount.
style of marking everything consistently.

Modules/mediastream/MediaTrackSupportedConstraints.h: Replaced this class with

a struct.

Modules/mediastream/MediaTrackSupportedConstraints.idl: Replaced this interface

with a dictionary.

WebCore.xcodeproj/project.pbxproj: Added and removed files.

bindings/js/JSMediaStreamTrackCustom.cpp: Removed.
bindings/js/JSMediaTrackSupportedConstraintsCustom.cpp: Removed.

platform/mediastream/MediaStreamTrackPrivate.cpp: Removed include of the

MediaSourceSettings.h header.

platform/mediastream/MediaStreamTrackPrivate.h: Removed forward declaration of

the MediaSourceSettings class.

LayoutTests:

fast/mediastream/MediaDevices-getSupportedConstraints-expected.txt: Updated since the

properties in the dictionaries are now in alphabetical order and because of the test change.

fast/mediastream/MediaDevices-getSupportedConstraints.html: Updated to expect some true

and some false rather than some true and some missing.

fast/mediastream/MediaStreamTrack-getCapabilities-expected.txt: Updated since the

properties in the dictionaries are now in alphabetical order.

fast/mediastream/MediaStreamTrack-getSettings-expected.txt: Ditto.

9:05 PM Changeset in webkit [209958] by commit-queue@webkit.org

5 edits in trunk/Source

JSContext Inspector: Avoid some possible exceptions inspecting a JSContext
https://bugs.webkit.org/show_bug.cgi?id=165986
<rdar://problem/29551379>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-12-16
Reviewed by Matt Baker.

Source/JavaScriptCore:

inspector/InjectedScriptSource.js:

(InjectedScript.prototype.processProperties):
Prefer String.prototype.endsWith now that it is available.

(InjectedScript.prototype._describe):
Prefer Function.prototype.toString for converting functions to String.
Previously we were doing String(f) which would to Symbol.toPrimitive
conversion which seems unnecessary here.

Source/WebInspectorUI:

UserInterface/Base/Main.js:

There will not be a main frame if we are debugging a JSContext.
In those cases do not change the title.

UserInterface/Views/ResourceSidebarPanel.js:

(WebInspector.ResourceSidebarPanel.prototype._scriptWasAdded):
There may not be a parent folder in JavaScript inspection. In that case
ScriptTreeElements are added to the Top Level, not folders.

8:04 PM Changeset in webkit [209957] by rniwa@webkit.org

4 edits
2 adds in trunk

Deleting a character converted from pinyin after an image causes a Safari crash
https://bugs.webkit.org/show_bug.cgi?id=165839
Source/WebKit2:

Reviewed by Darin Adler.

The crash was caused by the payload of the IPC not being decoded correctly when the encoded attributed string
contains a NSTextAttachment but send<> would still gladly send it to the UIProcess.

Fixed it by omitting the image as done in r176412 since encoding NSFileWrapper, etc... would require
quite a bit of work, and IME doesn't really need to see the image in its attributed string.

WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::attributedSubstringForCharacterRangeAsync): Fixed the bug.

Tools:

<rdar://problem/27951933>

Reviewed by Wenson Hsieh.

Add a WebKit API test to call attributedSubstringForProposedRange on a WKWebView
while the proposed range contains an image. This should not cause a WebProcess to crash
or send an invalid message to the UIProcess.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit2/chinese-character-with-image.html: Added.
TestWebKitAPI/Tests/WebKit2/mac/AttributedSubstringForProposedRangeWithImage.mm: Added.

(TestWebKitAPI::didFinishLoadForFrame):
(TestWebKitAPI::processDidCrash):
(TestWebKitAPI::invalidMessageFunction):
(TestWebKitAPI::WebKit2.AttributedSubstringForProposedRangeWithImage):

7:32 PM Changeset in webkit [209956] by Michael Catanzaro

2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix GCC 6 build failure after r209952

Return false, not nullptr, in function returning bool.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitJumpViaFinallyIfNeeded):

7:19 PM Changeset in webkit [209955] by sbarati@apple.com

2 edits in trunk/Source/JavaScriptCore

WebAssembly: We still have some incorrect parsing productions inside unreachable code
https://bugs.webkit.org/show_bug.cgi?id=165981

Reviewed by Keith Miller.

This hardens our parsing for CallIndirect and Loop/Block/If to be exactly like their reachable variant.

It also fixes a more nefarious bug in which we were decoding an extra varuint32
for Br/BrIf inside unreachable code.

wasm/WasmFunctionParser.h:

6:41 PM Changeset in webkit [209954] by fpizlo@apple.com

6 edits in trunk/Source/JavaScriptCore

CellState should have members with accurate names
https://bugs.webkit.org/show_bug.cgi?id=165969

Reviewed by Mark Lam.

This once again renames the members in CellState. I wanted to convey the following
pieces of information in the names:

What does the state mean for Generational GC?
What does the state mean for Concurrent GC?
Does the state guarantee what it means, or is there some contingency?

The names I came up with are:

PossiblyOldOrBlack: An object in this state may be old, or may be black, depending on

other things. If the mark bit is set then the object is either black or being
blackened as we speak. It's going to survive the GC, so it will be old, but may be
new now. In between GCs, objects in this state are definitely old. If the mark bit
is not set, then the object is actually old and white.

DefinitelyNewAndWhite: The object was just allocated so it is white (not marked) and

new.

DefinitelyGrey: The object is definitely grey - it will be rescanned in the future. It

may be new or old depending on other things.

heap/CellState.h:
heap/Heap.cpp:

(JSC::Heap::addToRememberedSet):
(JSC::Heap::writeBarrierSlowPath):

heap/SlotVisitor.cpp:

(JSC::SlotVisitor::appendJSCellOrAuxiliary):
(JSC::SlotVisitor::setMarkedAndAppendToMarkStack):
(JSC::SlotVisitor::appendToMarkStack):
(JSC::SlotVisitor::visitChildren):

runtime/JSCellInlines.h:

(JSC::JSCell::JSCell):

runtime/StructureIDBlob.h:

(JSC::StructureIDBlob::StructureIDBlob):

5:07 PM Changeset in webkit [209953] by sbarati@apple.com

3 edits in trunk/Source/JavaScriptCore

B3::DoubleToFloatReduction will accidentally convince itself it converted a Phi from Double to Float and then convert uses of that Phi into a use of FloatToDouble(@Phi)
https://bugs.webkit.org/show_bug.cgi?id=165946

Reviewed by Keith Miller.

This was happening because the phase will convert some Phi nodes
from Double to Float. However, one place that did this conversion
forgot to first check if the Phi was already a Float. If it's already
a Float, a later part of the phase will be buggy if the phase claims that it has
converted it from Double->Float. The reason is that at the end of the
phase, we'll look for all uses of former Double Phi nodes and make them
be a use of ConvertFloatToDouble on the Phi, instead of a use of the Phi itself.
This is clearly wrong if the Phi were Float to begin with (and
therefore, the uses were Float uses to begin with).

b3/B3ReduceDoubleToFloat.cpp:
b3/testb3.cpp:

(JSC::B3::testReduceFloatToDoubleValidates):
(JSC::B3::run):

5:06 PM Changeset in webkit [209952] by mark.lam@apple.com

8 edits
2 adds in trunk

JSTests:
De-duplicate finally blocks.
https://bugs.webkit.org/show_bug.cgi?id=160168

Reviewed by Keith Miller.

stress/deeply-nested-finallys.js: Added.
Tests many levels of finally nesting. This causes the old code to hang (and crashes eventually) while trying to generate bytecode for the exponentially duplicated finally blocks. The new code completes this test almost instantly.

stress/test-finally.js: Added.
Tests control flow through various permutations of finally blocks.

Source/JavaScriptCore:
De-duplicate finally blocks.
https://bugs.webkit.org/show_bug.cgi?id=160168

Reviewed by Keith Miller.

JS execution can arrive at a finally block when there are abrupt completions from
its try or catch block. The abrupt completion types include Break,
Continue, Return, and Throw. The non-abrupt completion type is called Normal
(i.e. the case of a try block falling through to the finally block).

Previously, we enable each of these paths for abrupt completion (except for Throw)
to run the finally block code by duplicating the finally block code at each of
the sites that trigger those completions. This patch fixes the implementation so
that each of these abrupt completions will set a finallyActionRegister (plus a
finallyReturnValueRegister for CompletionType::Return) and then jump to the
relevant finally blocks, and continue to thread through subsequent outer finally
blocks until execution reaches the outermost finally block that the completion
type dictates. We no longer duplicate the finally block code.

The implementation details:

We allocate a pair of finallyActionRegister and finallyReturnValueRegister just before entering the outermost try-catch-finally scope.

On allocating the registers, we set them to the empty JSValue. This serves
to set the completion type to CompletionType::Normal (see (2) below).

The finallyActionRegister serves 2 purpose:
1. indicates the CompletionType that triggered entry into the finally block.

This is how we encode the completion type in the finallyActionRegister:

CompletionType::Normal
- finallyActionRegister is set to the empty JSValue.
CompletionType::Break
- finallyActionRegister is set to the int jumpID for the site of the break statement.
CompletionType::Continue
- finallyActionRegister is set to the int jumpID for the site of the continue statement.
CompletionType::Return
- finallyActionRegister is set to CompletionType::Return as an int JSValue.
- finallyReturnValueRegister is set to the value to be returned.
CompletionType::Throw
- finallyActionRegister is set to the exception object that was caught by the finally block.

Hence, if the finallyActionRegister can either be:

empty i.e. we're handling CompletionType::Normal.
an int JSValue i.e. we're handling CompletionType::Break, Continue, or Return.
an object i.e. we're handling CompletionType::Throw.

stores the exception caught in the finally block if we're handing CompletionType::Throw.

Each finally block will have 2 entries:
1. the entry via throw.
2. the normal entry.

The entry via throw is recorded in the codeBlock's exception table, and can
only be jumped to by the VM's exception handling mechanism.

The normal entry is recorded in a FinallyContext (at bytecode generation time
only) and is jumped to when we want enter the finally block due any of the
other CompletionTypes.

CompletionType::Normal ====================== We encounter this when falling through from a try or catch block to the finally block.

For the try block case, since finallyActionRegister is set to Normal by default,
there's nothing more that needs to be done.

For the catch block case, since we entered the catch block with an exception,
finallyActionRegister may be set to Throw. We'll need to set it to Normal
before jumping to the finally block's normal entry.

CompletionType::Break
=====================
When we emit bytecode for the BreakNode, we check if we have any FinallyContexts
that we need to service before jumping to the breakTarget. If we do, then:

we'll register a jumpID along with the breakTarget with the outermost FinallyContext.
we'll also increment the numberOfBreaksOrContinues count in each FinallyContext from the innermost to the outermost.
instead of emitting bytecode to jump to the breakTarget, we:
1. emit bytecode to set finallyActionRegister to the jumpID.
2. emit bytecode to jump to the normal entry of the innermost finally block.

Each finally block will take care of cascading to the next outer finally block
as needed (see (5) below).

CompletionType::Continue
========================
Since continues and breaks work the same way (i.e. with a jump), we handle this
exactly the same way as CompletionType::Break, except that we use the
continueTarget instead of the breakTarget.

CompletionType::Return
======================
When we emit bytecode for the ReturnNode, we check if we have any FinallyContexts
at all on the m_controlFlowScopeStack.

If so, then instead of emitting op_ret, we:

emit bytecode to set finallyActionRegister to the CompletionType::Return.
emit bytecode to move the return value into finallyReturnValueRegister.
emit bytecode to jump to the normal entry of the innermost finally block.

Each finally block will take care of cascading to the next outer finally block
as needed (see (5) below).

CompletionType::Throw
======================
The op_catch of a finally block will always store the caught exception object
in the finallyActionRegister. This means we're handling CompletionType::Throw
(see (2) above).

What happens in each finally block? ================================== Only the finally block's entry via throw will have an op_catch that catches the pending exception (and stores it in the finallyActionRegister). This throw entry then falls through to the normal entry.

The finally block's normal entry will restore the scope of the finally block
and proceed to execute its code.

At the end of the finally block (see emitFinallyCompletion()), the finally
block will check the finallyActionRegister for each completion type in the
following order:

CompletionType::Normal: jump to the code after the finally block as designated by a normalCompletion label.

CompletionType::Break and Continue: If the FinallyContext for this block has registered FinallyJumps, we'll check for the jumpIDs against the finallyActionRegister. If the jumpID matches, jump to the corresponding jumpTarget.

If no jumpIDs match but the FinallyContext's numberOfBreaksOrContinues is
greater than the number of registered FinallyJumps, then this means that
we have a Break or Continue that needs to be handled by an outer finally
block. In that case, jump to the outer finally block's normal entry.

CompletionType::Return: If this finally block is not the outermost and finallyActionRegister contains CompletionType::Return, then jump to the outer finally block's normal entry.

Otherwise, if this finally block is the outermost and finallyActionRegister
contains CompletionType::Return, then execute op_ret and return the value
in finallyReturnValueRegister.

CompletionType::Throw: If we're not handling any of the above cases, then just throw the finallyActionRegister which contains the exception to re-throw.

restoreScopeRegister()

Since the needed scope objects are always stored in a local, we can restore
the scope register by simply moving from that local instead of going through
op_get_parent_scope.

m_controlFlowScopeStack needs to be a SegmentedVector instead of a Vector. This makes it easier to keep a pointer to the FinallyContext on that stack, and not have to worry about the vector being realloc'ed due to resizing.

Performance appears to be neutral both on ES6SampleBench (run via cli) and the
JSC benchmarks.

Relevant spec references:
https://tc39.github.io/ecma262/#sec-completion-record-specification-type
https://tc39.github.io/ecma262/#sec-try-statement-runtime-semantics-evaluation

bytecode/HandlerInfo.h:

(JSC::HandlerInfoBase::typeName):

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitReturn):
(JSC::BytecodeGenerator::pushFinallyControlFlowScope):
(JSC::BytecodeGenerator::popFinallyControlFlowScope):
(JSC::BytecodeGenerator::allocateAndEmitScope):
(JSC::BytecodeGenerator::pushTry):
(JSC::BytecodeGenerator::popTry):
(JSC::BytecodeGenerator::emitCatch):
(JSC::BytecodeGenerator::restoreScopeRegister):
(JSC::BytecodeGenerator::labelScopeDepthToLexicalScopeIndex):
(JSC::BytecodeGenerator::labelScopeDepth):
(JSC::BytecodeGenerator::pushLocalControlFlowScope):
(JSC::BytecodeGenerator::popLocalControlFlowScope):
(JSC::BytecodeGenerator::emitEnumeration):
(JSC::BytecodeGenerator::emitIsNumber):
(JSC::BytecodeGenerator::emitYield):
(JSC::BytecodeGenerator::emitDelegateYield):
(JSC::BytecodeGenerator::emitJumpViaFinallyIfNeeded):
(JSC::BytecodeGenerator::emitReturnViaFinallyIfNeeded):
(JSC::BytecodeGenerator::emitFinallyCompletion):
(JSC::BytecodeGenerator::allocateFinallyRegisters):
(JSC::BytecodeGenerator::releaseFinallyRegisters):
(JSC::BytecodeGenerator::emitCompareFinallyActionAndJumpIf):
(JSC::BytecodeGenerator::pushIteratorCloseControlFlowScope): Deleted.
(JSC::BytecodeGenerator::popIteratorCloseControlFlowScope): Deleted.
(JSC::BytecodeGenerator::emitComplexPopScopes): Deleted.
(JSC::BytecodeGenerator::emitPopScopes): Deleted.
(JSC::BytecodeGenerator::popTryAndEmitCatch): Deleted.

bytecompiler/BytecodeGenerator.h:

(JSC::FinallyJump::FinallyJump):
(JSC::FinallyContext::FinallyContext):
(JSC::FinallyContext::outerContext):
(JSC::FinallyContext::finallyLabel):
(JSC::FinallyContext::depth):
(JSC::FinallyContext::numberOfBreaksOrContinues):
(JSC::FinallyContext::incNumberOfBreaksOrContinues):
(JSC::FinallyContext::handlesReturns):
(JSC::FinallyContext::setHandlesReturns):
(JSC::FinallyContext::registerJump):
(JSC::FinallyContext::numberOfJumps):
(JSC::FinallyContext::jumps):
(JSC::ControlFlowScope::ControlFlowScope):
(JSC::ControlFlowScope::isLabelScope):
(JSC::ControlFlowScope::isFinallyScope):
(JSC::BytecodeGenerator::currentLexicalScopeIndex):
(JSC::BytecodeGenerator::FinallyRegistersScope::FinallyRegistersScope):
(JSC::BytecodeGenerator::FinallyRegistersScope::~FinallyRegistersScope):
(JSC::BytecodeGenerator::finallyActionRegister):
(JSC::BytecodeGenerator::finallyReturnValueRegister):
(JSC::BytecodeGenerator::emitSetFinallyActionToNormalCompletion):
(JSC::BytecodeGenerator::emitSetFinallyActionToReturnCompletion):
(JSC::BytecodeGenerator::emitSetFinallyActionToJumpID):
(JSC::BytecodeGenerator::emitSetFinallyReturnValueRegister):
(JSC::BytecodeGenerator::emitJumpIfFinallyActionIsNormalCompletion):
(JSC::BytecodeGenerator::emitJumpIfFinallyActionIsNotJump):
(JSC::BytecodeGenerator::emitJumpIfFinallyActionIsReturnCompletion):
(JSC::BytecodeGenerator::emitJumpIfFinallyActionIsNotReturnCompletion):
(JSC::BytecodeGenerator::emitJumpIfFinallyActionIsNotThrowCompletion):
(JSC::BytecodeGenerator::emitJumpIfCompletionTypeIsThrow):
(JSC::BytecodeGenerator::bytecodeOffsetToJumpID):
(JSC::BytecodeGenerator::isInFinallyBlock): Deleted.

bytecompiler/NodesCodegen.cpp:

(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::TryNode::emitBytecode):

Source/WTF:
Add predecessor info to dumps from JSC_dumpBytecodeLivenessResults=true.
https://bugs.webkit.org/show_bug.cgi?id=165958

Reviewed by Keith Miller.

Added some methods to bring SegmentedVector closer to parity with Vector.

wtf/SegmentedVector.h:

(WTF::SegmentedVector::first):
(WTF::SegmentedVector::last):
(WTF::SegmentedVector::takeLast):

4:48 PM Changeset in webkit [209951] by Alan Bujtas

2 edits in trunk/Source/WebCore

Possible nullptr dereference when applying pagination to viewport
https://bugs.webkit.org/show_bug.cgi?id=165926

Reviewed by Simon Fraser.

Static analysis found a code path where a null dereference could occur.

page/FrameView.cpp:

(WebCore::FrameView::applyPaginationToViewport):

4:45 PM Changeset in webkit [209950] by jmarcell@apple.com

1 copy in tags/Safari-602.4.3

New tag.

3:59 PM Changeset in webkit [209949] by weinig@apple.com

3 edits in trunk/LayoutTests

Fix failing test.

http/tests/ssl/applepay/ApplePaySession-expected.txt:
http/tests/ssl/applepay/ApplePaySession.html:

Update results to match latest IDL.

3:51 PM Changeset in webkit [209948] by Ryan Haddad

2 edits in trunk/Source/WebCore

Fix the Windows build.

Unreviewed build fix.

platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.cpp:

3:32 PM Changeset in webkit [209947] by Ryan Haddad

2 edits in trunk/Source/WebCore

Yet another attempt to fix the Windows build after r209936.

Unreviewed build fix.

platform/graphics/avfoundation/cf/CDMSessionAVFoundationCF.h:

3:24 PM Changeset in webkit [209946] by achristensen@apple.com

4 edits in trunk/Source/WebCore

Use initEvent quirk added in r207908 for Flipboard
https://bugs.webkit.org/show_bug.cgi?id=165974
<rdar://problem/28264190>

Reviewed by Chris Dumez.

dom/Event.cpp:

(WebCore::Event::initEventForBindings):

platform/RuntimeApplicationChecks.h:
platform/RuntimeApplicationChecks.mm:

(WebCore::IOSApplication::isFlipboard):
Flipboard also has JavaScript content that calls initEvent with not enough arguments.

3:17 PM Changeset in webkit [209945] by Chris Dumez

2 edits in trunk/Source/WebCore

[iOS] Align HTML from validation popover style with Copy/Paste callout bar
https://bugs.webkit.org/show_bug.cgi?id=165973
<rdar://problem/29336638>

Reviewed by Simon Fraser.

Tweak font size and padding of the HTML from validation popover to
match the style of the Copy/Paste callout bar on iOS.

platform/ios/ValidationBubbleIOS.mm:

(WebCore::ValidationBubble::ValidationBubble):

3:12 PM Changeset in webkit [209944] by Ryan Haddad

2 edits in trunk/Source/WebCore

Another attempt to fix the Windows build after r209936.

Unreviewed build fix.

CMakeLists.txt:

3:10 PM Changeset in webkit [209943] by aestes@apple.com

22 edits
5 adds in trunk

Add a setting to suppress keyboard input during provisional navigation
https://bugs.webkit.org/show_bug.cgi?id=165830

Reviewed by Brent Fulgham.

Source/WebCore:

Added a setting that suppresses keyboard input during provisional navigation. When the
setting is enabled, DOM propogation of keyboard input events (KeyboardEvents,
CompositionEvents, InputEvents, and some TextEvents) is suppressed, and text insertion is
disabled in the editor.

Non-editing default event handling still occurs, for instance keyboard scrolling, access
keys, and focus navigation.

Test: http/tests/navigation/keyboard-events-during-provisional-navigation.html

dom/CompositionEvent.h: Added a type trait specialization.
dom/EventDispatcher.cpp:

(WebCore::shouldSuppressEventDispatchInDOM): Added. Returns true if the event is trusted,
FrameLoader::shouldSuppressKeyboardInput() returns true, and the event is a
CompositionEvent, InputEvent, KeyboardEvent, or keyboard/composition TextEvent.
(WebCore::EventDispatcher::dispatchEvent): Called stopPropogation() on the event if
shouldSuppressEventDispatchInDOM() returns true.

dom/InputEvent.h: Removed the inline no-op destructor so that DataTransfer does not need

to be a complete type in every translation unit that includes this header. Added a type
trait specialization.

dom/TextEvent.h: Added isKeyboard() to determine if m_inputType is TextEventInputKeyboard.
editing/Editor.cpp:

(WebCore::Editor::shouldInsertText): Returned false if
FrameLoader::shouldSuppressKeyboardInput() returns true and the action is
EditorInsertActionTyped.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::shouldSuppressKeyboardInput): Added. Returns true if
Settings::shouldSuppressKeyboardInputDuringProvisionalNavigation() returns true and the
state is FrameStateProvisional.

loader/FrameLoader.h: Declared shouldSuppressKeyboardInput().
page/EventHandler.h: Exported accessKeyModifiers().
page/Settings.in: Defined shouldSuppressKeyboardInputDuringProvisionalNavigation with an

initial value of false.

testing/Internals.cpp:

(WebCore::Internals::accessKeyModifiers): Added. Returns a vector of strings representing
the access key modifiers.

testing/Internals.h: Declared accessKeyModifiers().
testing/Internals.idl: Exposed accessKeyModifiers() on the internals object.

Source/WebKit2:

Shared/WebPreferencesDefinitions.h: Defined

shouldSuppressKeyboardDOMEventsDuringProvisionalNavigation.

UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetShouldSuppressKeyboardInputDuringProvisionalNavigation): Added.
(WKPreferencesGetShouldSuppressKeyboardInputDuringProvisionalNavigation): Added.

UIProcess/API/C/WKPreferencesRefPrivate.h: Declared a getter and setter for the new

preference.

UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences _shouldSuppressKeyboardInputDuringProvisionalNavigation]): Added.
(-[WKPreferences _setShouldSuppressKeyboardInputDuringProvisionalNavigation:]): Added.

UIProcess/API/Cocoa/WKPreferencesPrivate.h: Declared a property for the new preference.
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Mapped the new preference to its corresponding
WebCore::Setting.

LayoutTests:

http/tests/navigation/keyboard-events-during-provisional-navigation-expected.txt: Added.
http/tests/navigation/keyboard-events-during-provisional-navigation.html: Added.
http/tests/navigation/resources/keyboard-events-after-navigation.html: Added.
http/tests/navigation/resources/keyboard-events-test.js: Added.

(runTest.eventHandler):
(runTest):

http/tests/navigation/resources/never-respond.php: Added.
platform/ios-simulator/TestExpectations:

3:03 PM Changeset in webkit [209942] by beidson@apple.com

3 edits in trunk/Source/WebCore

More SQLiteIDBCursor refactoring.
https://bugs.webkit.org/show_bug.cgi?id=165956

Reviewed by Tim Horton.

No new tests (No behavior change).

This is a simple patch that encapsulates the current state of the cursor in one structure
which will allow for storing multiple-such states in the future (to support prefetching).

Modules/indexeddb/server/SQLiteIDBCursor.cpp:

(WebCore::IDBServer::SQLiteIDBCursor::currentData):
(WebCore::IDBServer::SQLiteIDBCursor::resetAndRebindStatement):
(WebCore::IDBServer::SQLiteIDBCursor::advance):
(WebCore::IDBServer::SQLiteIDBCursor::advanceUnique):
(WebCore::IDBServer::SQLiteIDBCursor::markAsErrored):
(WebCore::IDBServer::SQLiteIDBCursor::internalAdvanceOnce):
(WebCore::IDBServer::SQLiteIDBCursor::iterate):

Modules/indexeddb/server/SQLiteIDBCursor.h:

(WebCore::IDBServer::SQLiteIDBCursor::currentRecordRowID):
(WebCore::IDBServer::SQLiteIDBCursor::currentKey):
(WebCore::IDBServer::SQLiteIDBCursor::currentPrimaryKey):
(WebCore::IDBServer::SQLiteIDBCursor::currentValue):
(WebCore::IDBServer::SQLiteIDBCursor::didComplete):
(WebCore::IDBServer::SQLiteIDBCursor::didError):

3:00 PM Changeset in webkit [209941] by Chris Dumez

5 edits
3 adds in trunk

HTML form validation bubble should be dismissed on navigation
https://bugs.webkit.org/show_bug.cgi?id=165960
<rdar://problem/29668086>

Reviewed by Simon Fraser.

Source/WebKit/mac:

Dismiss HTML form validation bubble on top-level navigation on Mac WK1.

WebView/WebView.mm:

(-[WebView _didStartProvisionalLoadForFrame:]):

Source/WebKit2:

Dismiss HTML form validation bubble on top-level navigation on WK2.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):

LayoutTests:

Add layout test coverage.

http/tests/navigation/navigation-dismisses-validation-bubbles-expected.txt: Added.
http/tests/navigation/navigation-dismisses-validation-bubbles.html: Added.
http/tests/navigation/resources/check-validation-bubble-not-visible.html: Added.

2:33 PM Changeset in webkit [209940] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

Follow-up build fix after r209936; also rename MockCDM -> LegacyMockCDM in
CMakeLists.txt.

CMakeLists.txt:

2:29 PM Changeset in webkit [209939] by weinig@apple.com

7 edits
2 deletes in trunk/Source/WebCore

[Bindings] Remove use of Dictionary/ArrayValue in CDMSessionClearKey
https://bugs.webkit.org/show_bug.cgi?id=165961

Reviewed by Darin Adler.

CMakeLists.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSBindingsAllInOne.cpp:

Remove ArrayValue.h/cpp

bindings/js/ArrayValue.cpp: Removed.
bindings/js/ArrayValue.h: Removed.

bindings/js/Dictionary.cpp:
bindings/js/Dictionary.h:

Remove support for ArrayValue.

Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.cpp:

(WebCore::CDMSessionClearKey::update):
Replace use of Dictionary/ArrayValue with direct JSObject functions. This
should really be replaced with a JSON parser that does not require round
tripping through JavaScript objects.

2:26 PM Changeset in webkit [209938] by msaboff@apple.com

3 edits in trunk/Source/WTF

REGRESSION: HipChat and Mail sometimes hang beneath JSC::Heap::lastChanceToFinalize()
https://bugs.webkit.org/show_bug.cgi?id=165962

Reviewed by Filip Pizlo.

There is an inherent race in Condition::waitFor() where the timeout can happen just before
a notify from another thread.

Fixed this by adding a condition variable and flag to each AutomaticThread. The flag
is used to signify to a notifying thread that the thread is waiting. That flag is set
in the waiting thread before calling waitFor() and cleared by another thread when it
notifies the thread. The access to that flag happens when the lock is held.
Now the waiting thread checks if the flag after a timeout to see that it in fact should
proceed like a normal notification.

The added condition variable allows us to target a specific thread. We used to keep a list
of waiting threads, now we keep a list of all threads. To notify one thread, we look for
a waiting thread and notify it directly. If we can't find a waiting thread, we start a
sleeping thread.

We notify all threads by waking all waiting threads and starting all sleeping threads.

wtf/AutomaticThread.cpp:

(WTF::AutomaticThreadCondition::notifyOne):
(WTF::AutomaticThreadCondition::notifyAll):
(WTF::AutomaticThread::isWaiting):
(WTF::AutomaticThread::notify):
(WTF::AutomaticThread::start):

wtf/AutomaticThread.h:

2:05 PM Changeset in webkit [209937] by jer.noble@apple.com

5 edits in trunk/Source/WebKit2

Small refactor: Use HashCountedSet rather than HashMap<..., int> to store client counts in WebPlaybackSessionManager{,Proxy}.
https://bugs.webkit.org/show_bug.cgi?id=165807

Reviewed by Eric Carlson.

UIProcess/Cocoa/WebPlaybackSessionManagerProxy.h:
UIProcess/Cocoa/WebPlaybackSessionManagerProxy.mm:

(WebKit::WebPlaybackSessionManagerProxy::addClientForContext):
(WebKit::WebPlaybackSessionManagerProxy::removeClientForContext):

WebProcess/cocoa/WebPlaybackSessionManager.h:
WebProcess/cocoa/WebPlaybackSessionManager.mm:

(WebKit::WebPlaybackSessionManager::addClientForContext):
(WebKit::WebPlaybackSessionManager::removeClientForContext):

1:52 PM Changeset in webkit [209936] by jer.noble@apple.com

16 edits
12 moves in trunk/Source/WebCore

Move existing CDM* implementations into modules/encryptedmedia/legacy
https://bugs.webkit.org/show_bug.cgi?id=165823

Rubber-stamped by Sam Weinig.

Modules/encryptedmedia/legacy/LegacyCDM.cpp: Renamed from Source/WebCore/Modules/encryptedmedia/CDM.cpp.

(WebCore::CDMFactory::CDMFactory):
(WebCore::installedCDMFactories):
(WebCore::CDM::registerCDMFactory):
(WebCore::CDMFactoryForKeySystem):
(WebCore::CDM::supportsKeySystem):
(WebCore::CDM::keySystemSupportsMimeType):
(WebCore::CDM::create):
(WebCore::CDM::CDM):
(WebCore::CDM::~CDM):
(WebCore::CDM::supportsMIMEType):
(WebCore::CDM::createSession):
(WebCore::CDM::mediaPlayer):

Modules/encryptedmedia/legacy/LegacyCDM.h: Renamed from Source/WebCore/Modules/encryptedmedia/CDM.h.

(WebCore::CDMClient::~CDMClient):
(WebCore::CDM::keySystem):
(WebCore::CDM::client):
(WebCore::CDM::setClient):

Modules/encryptedmedia/legacy/LegacyCDMPrivate.h: Renamed from Source/WebCore/Modules/encryptedmedia/CDMPrivate.h.

(WebCore::CDMPrivateInterface::CDMPrivateInterface):
(WebCore::CDMPrivateInterface::~CDMPrivateInterface):

Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.cpp: Renamed from Source/WebCore/Modules/encryptedmedia/CDMPrivateClearKey.cpp.

(WebCore::CDMPrivateClearKey::supportsKeySystem):
(WebCore::CDMPrivateClearKey::supportsKeySystemAndMimeType):
(WebCore::CDMPrivateClearKey::supportsMIMEType):
(WebCore::CDMPrivateClearKey::createSession):

Modules/encryptedmedia/legacy/LegacyCDMPrivateClearKey.h: Renamed from Source/WebCore/Modules/encryptedmedia/CDMPrivateClearKey.h.

(WebCore::CDMPrivateClearKey::CDMPrivateClearKey):
(WebCore::CDMPrivateClearKey::~CDMPrivateClearKey):

Modules/encryptedmedia/legacy/LegacyCDMPrivateMediaPlayer.cpp: Renamed from Source/WebCore/Modules/encryptedmedia/CDMPrivateMediaPlayer.cpp.

(WebCore::CDMPrivateMediaPlayer::supportsKeySystem):
(WebCore::CDMPrivateMediaPlayer::supportsKeySystemAndMimeType):
(WebCore::CDMPrivateMediaPlayer::supportsMIMEType):
(WebCore::CDMPrivateMediaPlayer::createSession):

Modules/encryptedmedia/legacy/LegacyCDMPrivateMediaPlayer.h: Renamed from Source/WebCore/Modules/encryptedmedia/CDMPrivateMediaPlayer.h.

(WebCore::CDMPrivateMediaPlayer::CDMPrivateMediaPlayer):
(WebCore::CDMPrivateMediaPlayer::~CDMPrivateMediaPlayer):
(WebCore::CDMPrivateMediaPlayer::cdm):

Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.cpp: Renamed from Source/WebCore/Modules/encryptedmedia/CDMSessionClearKey.cpp.

(WebCore::clearKeyVM):
(WebCore::CDMSessionClearKey::CDMSessionClearKey):
(WebCore::CDMSessionClearKey::~CDMSessionClearKey):
(WebCore::CDMSessionClearKey::generateKeyRequest):
(WebCore::CDMSessionClearKey::releaseKeys):
(WebCore::CDMSessionClearKey::update):
(WebCore::CDMSessionClearKey::cachedKeyForKeyID):

Modules/encryptedmedia/legacy/LegacyCDMSessionClearKey.h: Renamed from Source/WebCore/Modules/encryptedmedia/CDMSessionClearKey.h.
Modules/encryptedmedia/legacy/WebKitMediaKeySession.h:
Modules/encryptedmedia/legacy/WebKitMediaKeys.h:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/LegacyCDMSession.h: Renamed from Source/WebCore/platform/graphics/CDMSession.h.

(WebCore::CDMSessionClient::~CDMSessionClient):
(WebCore::CDMSession::CDMSession):
(WebCore::CDMSession::~CDMSession):
(WebCore::CDMSession::type):
(WebCore::CDMSession::cachedKeyForKeyID):

platform/graphics/MediaPlayer.h:
platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.h:
platform/graphics/avfoundation/CDMPrivateMediaSourceAVFObjC.mm:
platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:
platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h:
platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:
platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:
platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
testing/Internals.cpp:
testing/LegacyMockCDM.cpp: Renamed from Source/WebCore/testing/MockCDM.cpp.

(WebCore::MockCDMSession::~MockCDMSession):
(WebCore::MockCDM::supportsKeySystem):
(WebCore::MockCDM::supportsKeySystemAndMimeType):
(WebCore::MockCDM::supportsMIMEType):
(WebCore::MockCDM::createSession):
(WebCore::initDataPrefix):
(WebCore::keyPrefix):
(WebCore::keyRequest):
(WebCore::generateSessionId):
(WebCore::MockCDMSession::MockCDMSession):
(WebCore::MockCDMSession::generateKeyRequest):
(WebCore::MockCDMSession::releaseKeys):
(WebCore::MockCDMSession::update):

testing/LegacyMockCDM.h: Renamed from Source/WebCore/testing/MockCDM.h.

(WebCore::MockCDM::MockCDM):
(WebCore::MockCDM::~MockCDM):

1:42 PM Changeset in webkit [209935] by Ryan Haddad

3 edits in trunk/LayoutTests

Move the skip expectation for fast/visual-viewport/ios/zoomed-focus-in-fixed.html to ios-simulator-wk2.

Unreviewed test gardening.

platform/ios-simulator-wk2/TestExpectations:
platform/ios-simulator/TestExpectations:

1:36 PM Changeset in webkit [209934] by keith_miller@apple.com

2 edits in trunk/Source/JavaScriptCore

Add missing cases to parseUnreachableExpression and cleanup FunctionParser
https://bugs.webkit.org/show_bug.cgi?id=165966

Reviewed by Saam Barati.

This patch adds a number of missing cases to the Wasm FunctionParser's unreachable
code decoder. It also, removes unneeded OpType namespaces where they were not
needed and has the unary / binary macros cover all the cases rather than
just the simple cases.

wasm/WasmFunctionParser.h:

1:20 PM Changeset in webkit [209933] by Matt Baker

2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION (r209882): Opening find banner in editor causes UI to hang
https://bugs.webkit.org/show_bug.cgi?id=165967

Reviewed by Timothy Hatcher.

UserInterface/Views/ContentBrowser.js:

(WebInspector.ContentBrowser.prototype._findBannerDidShow):
Showing the find banner should cause search results to be refreshed only
if it contains query text.

12:44 PM Changeset in webkit [209932] by akling@apple.com

5 edits in trunk

Subframes going into page cache don't need to resetScrollbars().
<https://webkit.org/b/163750>
<rdar://problem/29273020>

Reviewed by Antti Koivisto.

Source/WebCore:

The main frame is the only frame that switches its FrameView when using the page cache,
subframes just suspend their DOM and wait around to be either killed or restored.

Thus there is no reason for subframes to reset their FrameView's scrollbars when going
into page cache, since nothing affects them while cached, and their layout should end up
identical when restoring.

This was causing some flakiness with subframe scrollbars jumping between different sizes
in when restoring from page cache in macOS/WK1. This change makes the behavior consistent
in both WK1 and WK2, and removes the flakiness.

dom/Document.cpp:

(WebCore::Document::setPageCacheState):

LayoutTests:

Unskip compositing/iframes/page-cache-layer-tree.html on mac-wk1 and fix up the
result now that WK2 behaves correctly as well.

Both DRT and WTR run with scrollbars in "always on" mode, so the correct dimensions
for the 300x150 iframe layers here are 285x135.

compositing/iframes/page-cache-layer-tree-expected.txt:
platform/mac-wk1/TestExpectations:

12:24 PM Changeset in webkit [209931] by Wenson Hsieh

27 edits
10 adds in trunk

Visual viewports: carets and selection UI are incorrectly positioned when editing fixed elements
https://bugs.webkit.org/show_bug.cgi?id=165767
<rdar://problem/29602382>

Reviewed by Simon Fraser.

Source/WebCore:

When changing the layout viewport override, mark viewport-constrained objects as needing layout. If only the
width and height of the old and new layout viewports are compared, EditorState info (namely selection and caret
rects) that depends on the document location of fixed elements may be stale immediately after the layout
viewport override changes and before layout occurs.

This caused one of the tests (fixed-caret-position-after-scroll.html) to occasionally fail.

Tests: editing/caret/ios/absolute-caret-position-after-scroll.html

editing/caret/ios/fixed-caret-position-after-scroll.html
editing/selection/ios/absolute-selection-after-scroll.html
editing/selection/ios/fixed-selection-after-scroll.html

page/FrameView.cpp:

(WebCore::FrameView::setLayoutViewportOverrideRect):

Source/WebKit2:

When focusing an input, the position of the caret on iOS is determined by the overridden layout viewport rect in
the web process. However, this rect is not updated until the end the scroll gesture. Whereas this is fine for
non-fixed inputs since their document location does not change, fixed inputs effectively change their position
in the document as the user scrolls. This causes the caret to be 'left behind' in the document position it was
in at the start of the scroll. To fix this, we deactivate the selection when exiting stable state if the
assisted node is in a fixed position container, and reenable it upon receiving the next stable state EditorState
update (as indicated by postLayoutData().isStableStateUpdate). Additionally, we apply similar treatment to the
web selection assistant -- this time, we need to force the selection view to hide (analagous to deactivating
the text selection assistant) and show it again upon receiving the next selection change update when the WebPage
(in the web process) is stable.

Furthermore, adds test support for querying text caret and selection rects, as well as perform a callback after
the WebPage has indicated that it is stable, both as SPI on the WKWebView.

Covered by 4 new layout tests in fast/editing/caret/ios and fast/editing/selection/ios.

Platform/spi/ios/UIKitSPI.h:
Shared/EditorState.cpp:

(WebKit::EditorState::PostLayoutData::encode):
(WebKit::EditorState::PostLayoutData::decode):

Shared/EditorState.h:

Introduce isStableStateUpdate, which is true when the WebPage is known to be in stable state, as well as
insideFixedPosition, which is true when the current selection is inside a fixed position container.

Shared/mac/RemoteLayerTreeTransaction.h:

(WebKit::RemoteLayerTreeTransaction::isInStableState):
(WebKit::RemoteLayerTreeTransaction::setIsInStableState):

Shared/mac/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::encode):
(WebKit::RemoteLayerTreeTransaction::decode):
(WebKit::RemoteLayerTreeTransaction::description):

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:]):
(-[WKWebView _uiTextCaretRect]):

Introduced a new SPI method for fetching the current rect of the text assistant's caret view, at keyPath
"selectionView.selection.caretRect".

(-[WKWebView _uiTextSelectionRects]):

Renamed (and refactored) from _uiTextSelectionRectViews, which was previously fetching an array of UIViews. I
found this to cause character-granularity-rect.html to fail due to the array of UIViews here being empty, so I
refactored this to simply return an array of rects from the keyPath "selectionView.selection.selectionRects" for
the text selection assistant and @"selectionView.selectionRects" for the web selection assistant.

(-[WKWebView _doAfterNextStablePresentationUpdate:]):

Runs the given block after both the UI process and web processes agree that the visible content rect state is
stable. To do this, we fire presentation updates until the UI process (via RemoteLayerTreeTransactions)
discovers that the web page is in stable state. This is used solely for testing purposes.

(-[WKWebView _firePresentationUpdateForPendingStableStatePresentationCallbacks]):
(-[WKWebView _uiTextSelectionRectViews]): Deleted.

UIProcess/API/Cocoa/WKWebViewPrivate.h:
UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::inStableState):

UIProcess/ios/WKContentView.mm:

(-[WKContentView _didExitStableState]):

Deactivate the text selection if the assisted node is inside a fixed container.

(-[WKContentView didUpdateVisibleRect:unobscuredRect:unobscuredRectInScrollViewCoordinates:obscuredInset:scale:minimumScale:inStableState:isChangingObscuredInsetsInteractively:enclosedInScrollableAncestorView:]):

UIProcess/ios/WKContentViewInteraction.h:
UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView setupInteraction]):
(-[WKContentView cleanupInteraction]):
(-[WKContentView shouldHideSelectionWhenScrolling]):
(-[WKContentView _uiTextSelectionRects]):
(-[WKContentView _didEndScrollingOrZooming]):
(-[WKContentView _updateChangedSelection:]):

If the EditorState was created after a stable state update, reactivate the text selection assistant if it exists.
Additionally, if we are deferring the end scrolling selection update until after the first stable editor state
update arrives from the web process, we need to also call [_textSelectionAssistant didEndScrollingOverflow]
and [_webSelectionAssistant didEndScrollingOrZoomingPage] here instead of doing so immediately after scrolling
finishes. This ensures that selection UI (the callout and selection highlights) do not flicker from their old
position to the new position when scrolling finishes.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::willCommitLayerTree):

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformEditorState):
(WebKit::WebPage::updateVisibleContentRects):

When updating the layout viewport override rect, also recompute the caret if needed and send an updated
EditorState over to the UI process.

Tools:

Introduces two new UIScriptController methods: doAfterWebPageIsInStableState and textSelectionCaretRect. See
WebKit2 ChangeLog for more details.

DumpRenderTree/ios/UIScriptControllerIOS.mm:

(WTR::UIScriptController::doAfterNextStablePresentationUpdate):
(WTR::UIScriptController::textSelectionCaretRect):

DumpRenderTree/mac/UIScriptControllerMac.mm:

(WTR::UIScriptController::doAfterNextStablePresentationUpdate):

TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
TestRunnerShared/UIScriptContext/UIScriptController.cpp:

(WTR::UIScriptController::doAfterNextStablePresentationUpdate):
(WTR::UIScriptController::textSelectionCaretRect):

TestRunnerShared/UIScriptContext/UIScriptController.h:
WebKitTestRunner/cocoa/TestRunnerWKWebView.mm:

(-[TestRunnerWKWebView _setStableStateOverride:]):

Force the WKWebView to update its visible content rects when changing the stable state override.

WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::toNSDictionary):
(WTR::UIScriptController::doAfterNextStablePresentationUpdate):
(WTR::UIScriptController::selectionRangeViewRects):
(WTR::UIScriptController::textSelectionCaretRect):

WebKitTestRunner/mac/UIScriptControllerMac.mm:

(WTR::UIScriptController::doAfterNextStablePresentationUpdate):

LayoutTests:

Adds new layout tests verifying that scrolling selected text (non-editable) and a text caret (in editable
content) results in the selection/caret rects having the correct location relative to the document, in both
cases where the selected/focused element has fixed position or absolute position. For fixed position elements,
this means that the rects must "move" down in the document as the document is scrolled, but for absolute
elements, these rects must remain in place.

TestExpectations:
editing/caret/ios/absolute-caret-position-after-scroll-expected.txt: Added.
editing/caret/ios/absolute-caret-position-after-scroll.html: Added.
editing/caret/ios/fixed-caret-position-after-scroll-expected.txt: Added.
editing/caret/ios/fixed-caret-position-after-scroll.html: Added.
editing/selection/ios/absolute-selection-after-scroll-expected.txt: Added.
editing/selection/ios/absolute-selection-after-scroll.html: Added.
editing/selection/ios/fixed-selection-after-scroll-expected.txt: Added.
editing/selection/ios/fixed-selection-after-scroll.html: Added.

12:01 PM Changeset in webkit [209930] by jmarcell@apple.com

7 edits
2 adds in branches/safari-602-branch

Merge r209926. rdar://problem/29706846

11:28 AM Changeset in webkit [209929] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

Add predecessor info to dumps from JSC_dumpBytecodeLivenessResults=true.
https://bugs.webkit.org/show_bug.cgi?id=165958

Reviewed by Saam Barati.

Also:

refactored the code to use a common lambda function to dump FastBitVectors.
list successors by their block index instead of pointers.

bytecode/BytecodeLivenessAnalysis.cpp:

(JSC::BytecodeLivenessAnalysis::dumpResults):

11:24 AM Changeset in webkit [209928] by sbarati@apple.com

11 edits
4 copies in trunk

WebAssembly: WasmB3IRGenerator should throw exceptions instead of crash
https://bugs.webkit.org/show_bug.cgi?id=165834

Reviewed by Keith Miller.

JSTests:

wasm/function-tests/exceptions.js: Added.

(import.Builder.from.string_appeared_here.import.as.assert.from.string_appeared_here.makeInstance):

wasm/function-tests/table-basic.js:

(i.i.42.throw.new.Error):

Source/JavaScriptCore:

This patch generalizes how we throw exceptions in the Wasm::B3IRGenerator.
There are still places where we need to throw exceptions and we don't, but
this patch removes most of those places inside the IR generator. There are
still a few places we need to throw exceptions inside the IR generator, like
div/mod by 0. Those will be done in a separate patch. Also, there are
still some stubs we need to throw exceptions from; those will also be
done in a separate patch.

All exceptions thrown from Wasm share a common stub. The ABI for the stub
is to move the Wasm::ExceptionType into argGPR1 and jump to the stub.
The stub will then throw an exception with an error message tailored
to the particular Wasm::ExceptionType failure.

This patch also refactors B3::Compilation. Before, B3::Compilation(VM, Procedure)
constructor would compile a B3 function. This patch makes B3::Compilation a simple
tuple that keeps the necessary bits of B3 function alive in order to be runnable.
There is a new function that actually does the compilation for you. It is:
Compilation B3::compile(VM&, Procedure&)
The reason for this change is that I'm now using B3::Compilation(CodeRef, OpaqueByproducts)
constructor in Wasm code. It is weird to have a class both have a
constructor that instantiates the tuple, and another that performs the
compilation and then instantiates the tuple. It's more straight
forward if Compilation's job wasn't to actually do the compilation
but just to hold the necessary bits to keep a compiled B3 alive.

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
b3/B3Compilation.cpp:

(JSC::B3::Compilation::Compilation):

b3/B3Compilation.h:
b3/B3Compile.cpp: Added.

(JSC::B3::compile):

b3/B3Compile.h: Added.
b3/testb3.cpp:

(JSC::B3::compile):

jit/ThunkGenerators.cpp:

(JSC::throwExceptionFromWasmThunkGenerator):

jit/ThunkGenerators.h:
wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::emitExceptionCheck):
(JSC::Wasm::createJSToWasmWrapper):
(JSC::Wasm::parseAndCompile):

wasm/WasmExceptionType.h: Added.

(JSC::Wasm::errorMessageForExceptionType):

10:56 AM Changeset in webkit [209927] by weinig@apple.com

30 edits
14 adds
4 deletes in trunk/Source/WebCore

[ApplePay] Remove remaining custom bindings from the ApplePay code
https://bugs.webkit.org/show_bug.cgi?id=165860

Reviewed by Darin Adler.

DerivedSources.make:

Add new IDL files.

WebCore.xcodeproj/project.pbxproj:

Add/remove files.

bindings/js/JSApplePayPaymentAuthorizedEventCustom.cpp: Removed.
bindings/js/JSApplePayPaymentMethodSelectedEventCustom.cpp: Removed.
bindings/js/JSApplePayShippingContactSelectedEventCustom.cpp: Removed.
bindings/js/JSApplePayShippingMethodSelectedEventCustom.cpp: Removed.

Remove custom bindings.

Modules/applepay/ApplePayLineItem.h: Added.
Modules/applepay/ApplePayLineItem.idl: Added.
Modules/applepay/ApplePayPayment.h: Added.
Modules/applepay/ApplePayPayment.idl: Added.
Modules/applepay/ApplePayPaymentContact.h: Added.
Modules/applepay/ApplePayPaymentContact.idl: Added.
Modules/applepay/ApplePayPaymentMethod.h: Added.
Modules/applepay/ApplePayPaymentMethod.idl: Added.
Modules/applepay/ApplePayPaymentPass.h: Added.
Modules/applepay/ApplePayPaymentPass.idl: Added.
Modules/applepay/ApplePayPaymentRequest.h: Added.
Modules/applepay/ApplePayPaymentRequest.idl: Added.
Modules/applepay/ApplePayShippingMethod.h: Added.
Modules/applepay/ApplePayShippingMethod.idl: Added.

Split out dictionaries and enums into separate files where needed.

Modules/applepay/ApplePayPaymentAuthorizedEvent.cpp:

(WebCore::ApplePayPaymentAuthorizedEvent::ApplePayPaymentAuthorizedEvent):

Modules/applepay/ApplePayPaymentAuthorizedEvent.h:
Modules/applepay/ApplePayPaymentAuthorizedEvent.idl:

Convert the 'payment' property to return an ApplePayPayment dictionary, removing
the need for custom bindings.

Modules/applepay/ApplePayPaymentMethodSelectedEvent.cpp:

(WebCore::ApplePayPaymentMethodSelectedEvent::ApplePayPaymentMethodSelectedEvent):

Modules/applepay/ApplePayPaymentMethodSelectedEvent.h:
Modules/applepay/ApplePayPaymentMethodSelectedEvent.idl:

Convert the 'paymentMethod' property to return an ApplePayPaymentMethod dictionary, removing
the need for custom bindings.

Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidate):
(WebCore::ApplePaySession::create):
(WebCore::ApplePaySession::ApplePaySession):
(WebCore::ApplePaySession::completeShippingMethodSelection):
(WebCore::ApplePaySession::completeShippingContactSelection):
(WebCore::ApplePaySession::completePaymentMethodSelection):
(WebCore::ApplePaySession::didSelectShippingMethod):

Modules/applepay/ApplePaySession.h:

Update for new names, remove need for ExecState in the create function, and simplify
billingContact and shippingContact now that they are strongly typed.

Modules/applepay/ApplePaySession.idl:

Move dictionaries and enums to their own files.

Modules/applepay/ApplePayShippingContactSelectedEvent.cpp:

(WebCore::ApplePayShippingContactSelectedEvent::ApplePayShippingContactSelectedEvent):

Modules/applepay/ApplePayShippingContactSelectedEvent.h:
Modules/applepay/ApplePayShippingContactSelectedEvent.idl:

Convert the 'shippingContact' property to return an ApplePayPaymentContact dictionary, removing
the need for custom bindings.

Modules/applepay/ApplePayShippingMethodSelectedEvent.cpp:
Modules/applepay/ApplePayShippingMethodSelectedEvent.h:
Modules/applepay/ApplePayShippingMethodSelectedEvent.idl:

Convert the 'shippingMethod' property to return an ApplePayShippingMethod dictionary, removing
the need for custom bindings.

Modules/applepay/Payment.h:
Modules/applepay/PaymentContact.h:
Modules/applepay/PaymentMethod.h:
Modules/applepay/cocoa/PaymentCocoa.mm:
Modules/applepay/cocoa/PaymentContactCocoa.mm:
Modules/applepay/cocoa/PaymentMethodCocoa.mm:

Replace toJS/fromJS functions with ones that convert to/from the associated dictionary type.

bindings/generic/IDLTypes.h:

(WebCore::IDLJSON::nullValue):
(WebCore::IDLJSON::isNullValue):
(WebCore::IDLJSON::extractValueFromNullable):

bindings/js/JSDOMConvert.h:

(WebCore::Converter<IDLJSON>::convert):
(WebCore::JSConverter<IDLJSON>::convert):
Add a new custom type, JSON, which converts from a String to a JS object.

bindings/scripts/CodeGenerator.pm:
bindings/scripts/CodeGeneratorJS.pm:

Add support for the new JSON type, and improve scoped naming to allow for enums
in dictionary only IDL files.

bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp:

Update test result for improved scoped naming.

10:48 AM Changeset in webkit [209926] by Alan Bujtas

7 edits
2 adds in trunk

Defer certain accessibility callbacks until after layout is finished.
https://bugs.webkit.org/show_bug.cgi?id=165861
rdar://problem/29646301

Reviewed by Chris Fleizach.

Source/WebCore:

Currently with certain AXObjectCache callbacks, we can end up in a layout while the render tree is being mutated.
This patch ensures that such callbacks are deferred until after tree mutation/layout is finished.

Test: accessibility/accessibility-crash-with-dynamic-inline-content.html

accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::performDeferredIsIgnoredChange):
(WebCore::AXObjectCache::insertDeferredIsIgnoredChange):

accessibility/AXObjectCache.h:
page/FrameView.cpp:

(WebCore::FrameView::performPostLayoutTasks):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::deleteLines):

rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::createAndAppendRootInlineBox):

LayoutTests:

accessibility/accessibility-crash-with-dynamic-inline-content-expected.txt: Added.
accessibility/accessibility-crash-with-dynamic-inline-content.html: Added.

10:45 AM Changeset in webkit [209925] by Ryan Haddad

3 edits in trunk/Source/WebCore

Rebaseline bindings tests after r209897.

Unreviewed test gardening.

bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObj::visitChildren):

bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterface::visitChildren):

10:32 AM Changeset in webkit [209924] by Brent Fulgham

8 edits in trunk

Arguments called in wrong order
https://bugs.webkit.org/show_bug.cgi?id=165923

Reviewed by Simon Fraser.

Source/WebCore:

Correct the ordering of several function calls.

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample): The 'nearestToPresentationStartTime'
argument is being checked for validity, but 'nearestToPresentationEndTime' is being used in the
calculation. This seems like a copy/paste error.

page/PrintContext.cpp:

(WebCore::PrintContext::outputLinkedDestinations): FloatPoint::expandedTo returns a new object that
has been expanded. This code continued using the 'unexpanded' point.

platform/graphics/GraphicsContext3D.cpp:

(WebCore::GraphicsContext3D::computeImageSizeInBytes): The 'bytesPerComponent' and 'componentsPerPixel'
variables were being passed in the wrong order.

platform/network/CacheValidation.cpp: The 'last-modified' header string was being concatenated with

the following string, resulting in an incorrect 'last-modifiedproxy-authenticate' string value.

svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::firstGlyph): The ASSERT was assigning to the (by-value) input
parameter 'codePoint', rather than comparing it to the firstGlyph value's codePoint.

Tools:

The 'audioDeviceUIDs' array is being passed to the argument that expects video devices,
and the 'videoDeviceUIDs' array is being passed to the audo device argument. Fix this.

TestWebKitAPI/Tests/WebKit2/UserMedia.cpp:

(TestWebKitAPI::decidePolicyForUserMediaPermissionRequestCallBack): The
order of arguments to WKUserMediaPermissionRequestAllow are flipped.

9:53 AM Changeset in webkit [209923] by keith_miller@apple.com

6 edits in trunk

i64.eqz should use an Int64 zero
https://bugs.webkit.org/show_bug.cgi?id=165942

Reviewed by Mark Lam.

JSTests:

wasm/wasm.json:

Source/JavaScriptCore:

This patch fixes i64.eqz, which was using an Int32 zero
for the comparison previously. This patch also, adds
printing opcodes names in verbose mode.

wasm/WasmFunctionParser.h:
wasm/generateWasmOpsHeader.py:
wasm/wasm.json:

9:40 AM Changeset in webkit [209922] by bshafiei@apple.com

1 delete in tags/Safari-602.4.3

Delete tag.

8:56 AM Changeset in webkit [209921] by Matt Baker

4 edits in trunk/Source/WebInspectorUI

Web Inspector: Modernize find banner UI
https://bugs.webkit.org/show_bug.cgi?id=165939

Reviewed by Timothy Hatcher.

The find banner should have a modern appearance, matching Xcode.

UserInterface/Views/FindBanner.css:

(.find-banner > input[type="search"]):
(.find-banner > button):
Use standard border colors.
(.find-banner > button:disabled > .glyph):
Disabled previous / next glyphs should be lighter.
(.find-banner > button:active:not(:disabled)):
Update depressed button style: flat colors, no text color change.
(.find-banner > button.segmented):
(.find-banner > button.segmented.left):
(.find-banner > button:not(:active).segmented.right:before):
(.find-banner > button.segmented.left:active + button.segmented.right,):
(.find-banner > button.segmented.left:active + button.segmented.right:before):
(.find-banner > button.segmented.right):
(.find-banner.console-find-banner > input[type="search"]):
(.find-banner.console-find-banner > :matches(input[type="search"], button)):
(.find-banner > button:disabled): Deleted.
(.find-banner > button.segmented:active): Deleted.
Overlapping button borders are no longer an issue.

UserInterface/Views/FindBanner.js:

(WebInspector.FindBanner):
Insert previous / next buttons after the input field in the DOM.
(WebInspector.FindBanner.prototype.get delegate):
(WebInspector.FindBanner.prototype.set delegate):
(WebInspector.FindBanner.prototype.get inputField):
(WebInspector.FindBanner.prototype.get searchQuery):
(WebInspector.FindBanner.prototype.set searchQuery):
(WebInspector.FindBanner.prototype.get numberOfResults):
Inline simple getters and setters.

UserInterface/Views/Variables.css:

(:root):
Add button colors.

8:43 AM Changeset in webkit [209920] by Claudio Saavedra

3 edits in trunk/Source/WebKit2

[WK2] SharedMemory: include cleanups
https://bugs.webkit.org/show_bug.cgi?id=165950

Reviewed by Žan Doberšek.

The WTFString include is not needed in the header, so move to the
Unix file. Use the existing UNIX_DOMAIN_SOCKETS define. Also
include the WTFOptional header where needed.

Platform/SharedMemory.h:
Platform/unix/SharedMemoryUnix.cpp:

8:31 AM Changeset in webkit [209919] by jh718.park@samsung.com

2 edits in trunk/Source/WebKit2

[EFL] Fix build break since r209907. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=165954

UIProcess/efl/TextCheckerEfl.cpp: Change the remaining TextBreakIterator to UBreakIterator

(WebKit::nextWordOffset):
(WebKit::TextChecker::checkTextOfParagraph):

5:36 AM Changeset in webkit [209918] by Hunseop Jeong

2 edits in trunk/Tools

[EFL] Disable non-srcdir builds for failing libraries
https://bugs.webkit.org/show_bug.cgi?id=165896

Reviewed by Gyuyoung Kim.

efl/jhbuild.modules: Set non srcdir builds to no

3:51 AM Changeset in webkit [209917] by commit-queue@webkit.org

29 edits in trunk

[Fetch API] Improve resource loading console logging
https://bugs.webkit.org/show_bug.cgi?id=160546

Patch by Youenn Fablet <youenn@apple.com> on 2016-12-16
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebasing since error logging is happening for fetch API.

web-platform-tests/fetch/api/basic/mode-same-origin-expected.txt:
web-platform-tests/fetch/api/basic/scheme-about-expected.txt:
web-platform-tests/fetch/api/basic/scheme-blob-expected.txt:
web-platform-tests/fetch/api/basic/scheme-others-expected.txt:
web-platform-tests/fetch/api/cors/cors-basic-expected.txt:
web-platform-tests/fetch/api/cors/cors-cookies-expected.txt:
web-platform-tests/fetch/api/cors/cors-multiple-origins-expected.txt:
web-platform-tests/fetch/api/cors/cors-origin-expected.txt:
web-platform-tests/fetch/api/cors/cors-preflight.html:
web-platform-tests/fetch/api/cors/cors-redirect-credentials-expected.txt:
web-platform-tests/fetch/api/redirect/redirect-location-expected.txt:
web-platform-tests/fetch/api/redirect/redirect-schemes-expected.txt:
web-platform-tests/fetch/api/redirect/redirect-to-dataurl-expected.txt:

Source/WebCore:

Covered by rebased tests.

Adding support for logging of resource loading failures in ThreadableLoader.
This will allow doing consistent logging for clients such as fetch, XHR, event source...

Doing logging for Fetch API only at the moment in ThreadableLoader.
Future patches should migrate XHR to this logging system.

Logging routine is implemented in ThreadableLoader.
It is used directly by DocumentThreadableLoader before calling didFail client callback.
DocumentThreadableLoader has a new option to not log errors, in the case the client is WorkerThreadableLoader::MainBridge.
In that case, the logging is done in the worker context within WorkerThreadableLoader::MainBridge::didFail

loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadResourceSynchronously): Enable logging.
(WebCore::DocumentThreadableLoader::create): Passing logging parameter to constructor.
(WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Adding initialization of logging parameter.
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest): Making use of the new logErrorAndFail helper routine.
(WebCore::DocumentThreadableLoader::cancel): No need to log error if it is being cancelled.
(WebCore::DocumentThreadableLoader::redirectReceived): Made the reportXX routines methods of DocumentThreadableLoaders and using logErrorAndFail internally.
(WebCore::DocumentThreadableLoader::didFail): Wrapper around logErrorAndFail since cancel is not calling it anymore.
(WebCore::DocumentThreadableLoader::preflightFailure):
(WebCore::DocumentThreadableLoader::loadRequest):
(WebCore::DocumentThreadableLoader::reportRedirectionWithBadScheme):
(WebCore::DocumentThreadableLoader::reportContentSecurityPolicyError):
(WebCore::DocumentThreadableLoader::reportCrossOriginResourceSharingError):
(WebCore::DocumentThreadableLoader::logErrorAndFail):
(WebCore::reportContentSecurityPolicyError): Deleted.
(WebCore::reportCrossOriginResourceSharingError): Deleted.
(WebCore::reportRedirectionWithBadScheme): Deleted.

loader/DocumentThreadableLoader.h:
loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoader::logError):

loader/ThreadableLoader.h:
loader/ThreadableLoaderClientWrapper.h:

(WebCore::ThreadableLoaderClientWrapper::create):
(WebCore::ThreadableLoaderClientWrapper::initiator):
(WebCore::ThreadableLoaderClientWrapper::ThreadableLoaderClientWrapper):

loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::WorkerThreadableLoader):
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):

LayoutTests:

Rebasing since error logging is happening for fetch API.
Some tests are flaky due to always changing console logs, in which case DumpJSConsoleLogInStdErr is used.

TestExpectations:
http/tests/fetch/fetching-same-resource-with-diffferent-options-expected.txt:
http/tests/inspector/network/fetch-network-data-expected.txt:
platform/ios-simulator-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic-expected.txt:
platform/ios-simulator-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin-expected.txt:
platform/mac-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-basic-expected.txt:
platform/mac-wk2/imported/w3c/web-platform-tests/fetch/api/cors/cors-origin-expected.txt:

3:50 AM Changeset in webkit [209916] by eocanha@igalia.com

2 edits in trunk/Source/WebCore

[GStreamer][MSE] Fix build warning in MediaPlayerPrivateGStreamer.cpp using gcc 6.2
https://bugs.webkit.org/show_bug.cgi?id=165900

Reviewed by Žan Doberšek.

platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::supportsCodecs):
Move the variable asignation out of the if condition.

2:01 AM Changeset in webkit [209915] by commit-queue@webkit.org

6 edits in trunk

[Readable Streams API] Implement ReadableByteStreamController cancel internal method
https://bugs.webkit.org/show_bug.cgi?id=165798

Patch by Romain Bellessort <romain.bellessort@crf.canon.fr> on 2016-12-16
Reviewed by Youenn Fablet.

Source/WebCore:

Implemented cancel method of ReadableByteStreamController.
Also fixed small inconsistency in readableByteStreamControllerClose.

Added one test to check cancel behaviour. More tests may be added as the API is implemented.

Modules/streams/ReadableByteStreamInternals.js:

(privateInitializeReadableByteStreamController): Define cancel internal method.
(readableByteStreamControllerCancel): Added.
(readableByteStreamControllerClose): Fixed behaviour (no value should be dequeued).

bindings/js/WebCoreBuiltinNames.h: Removed bytesFilled (previous addition was not needed).

LayoutTests:

Added one test to check cancel behaviour. More tests may be added as the API is implemented.
Also replaced async_test by promise_test where applicable.

streams/readable-byte-stream-controller-expected.txt: Updated expectations.
streams/readable-byte-stream-controller.js: Added one test.

12:42 AM Changeset in webkit [209914] by commit-queue@webkit.org

5 edits
2 adds in trunk

svg/as-image/svg-image-with-data-uri-use-data-uri.svg is flaky after r207754
https://bugs.webkit.org/show_bug.cgi?id=163887
<rdar://problem/29266436>

Patch by Youenn Fablet <youennf@gmail.com> on 2016-12-16
Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/security/cross-origin-cached-images-with-memory-pressure.html

With the introduction of cached resource cloning, an Image may be referenced by several CachedImage.
This did not work well with Image observer system as it mandates a one-to-one relationship.

Introducing CachedImageObserver to restore the one-to-one relationship between Image and its observer.
CachedImageObserver can keep references for more than one CachedImage.

In the future, it might be better to split more clearly CachedImageObserver and its API from CachedImage.
Or remove the concept of CachedResource cloning and find new ways to provide CachedResource origin information to clients.

loader/cache/CachedImage.cpp:

(WebCore::CachedImage::load): Moved boolean image observer fields to CachedImageObserver.
(WebCore::CachedImage::setBodyDataFrom): Keeping a reference of the image observer when cloning the resource.
(WebCore::CachedImage::createImage): Creating the observer when creating the image.
(WebCore::CachedImage::CachedImageObserver::CachedImageObserver):
(WebCore::CachedImage::CachedImageObserver::decodedSizeChanged):
(WebCore::CachedImage::CachedImageObserver::didDraw):
(WebCore::CachedImage::CachedImageObserver::animationAdvanced):
(WebCore::CachedImage::CachedImageObserver::changedInRect):
(WebCore::CachedImage::clearImage):

loader/cache/CachedImage.h:
loader/cache/CachedResource.cpp:

(WebCore::CachedResource::setBodyDataFrom): Now that each cached image receives decodedSizeChanged callback, we need to set its size correctly.

LayoutTests:

http/tests/security/cross-origin-cached-images-with-memory-pressure-expected.txt: Added.
http/tests/security/cross-origin-cached-images-with-memory-pressure.html: Added.

Dec 15, 2016:

11:12 PM Changeset in webkit [209913] by mmaxfield@apple.com

2 edits in trunk/Source/WTF

Unreviewed build fix after r209910

Unreviewed.

wtf/Platform.h:

11:10 PM Changeset in webkit [209912] by jh718.park@samsung.com

3 edits in trunk/Source/WebCore

[EFL] Fix debug build break since r209873. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=165945

No new tests, no new behaviours.

Use Primitive System Data Type uint64_t instead of unsigned long long.

Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::openInternal):

Modules/indexeddb/IDBFactory.h:

10:45 PM Changeset in webkit [209911] by bshafiei@apple.com

1 copy in tags/Safari-602.4.3

New tag.

10:32 PM Changeset in webkit [209910] by Alan Bujtas

11 edits
2 adds in trunk

text-align: justify and word-spacing combine to overflow column
https://bugs.webkit.org/show_bug.cgi?id=165796
rdar://problem/29672168

Reviewed by Myles C. Maxfield.

Source/WebCore:

The value of the word-spacing property is not applied on the inline-tree boxes (normal line layout)
with kerning enabled. It causes hittest failures and selection/rendering glitches.
We normally use the pre-computed 'WordMeasurements' values to figure out the run widths. However
with kerning on, in some cases we need to re-measure a certain part of the text by calling RenderText::width().
This function omits the word-spacing value for leading whitespace, so when this text fragment starts with a whitespace,
(while it's not at the beginning of the run) we have to manually add the word-spacing value back.
r146087 added this logic with the restriction of applying it only to whitespace-only runs.

Test: fast/css/word-spacing-with-normal-layout.html

rendering/RenderBlockLineLayout.cpp:

(WebCore::setLogicalWidthForTextRun):

LayoutTests:

These are progressions.

fast/css/word-spacing-with-normal-layout-expected.html: Added.
fast/css/word-spacing-with-normal-layout.html: Added.
platform/mac/css1/text_properties/word_spacing-expected.txt:
platform/mac/fast/css/word-space-extra-expected.txt:
platform/mac/fast/text/whitespace/span-in-word-space-causes-overflow-expected.txt:
platform/mac/fast/text/word-space-expected.txt:
platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
platform/mac/svg/custom/svg-fonts-word-spacing-expected.txt:

9:54 PM Changeset in webkit [209909] by bshafiei@apple.com

5 edits in tags/Safari-603.1.16.2/Source

Versioning.

9:52 PM Changeset in webkit [209908] by bshafiei@apple.com

1 copy in tags/Safari-603.1.16.2

New tag.

9:19 PM Changeset in webkit [209907] by mmaxfield@apple.com

29 edits in trunk/Source

Stop reinterpret_casting UBreakIterators to the undefined type TextBreakIterator
https://bugs.webkit.org/show_bug.cgi?id=165931

Source/WebCore:

Reviewed by Alex Christensen.

No new tests because there is no behavior change.

dom/CharacterData.cpp:

(WebCore::CharacterData::parserAppendData):

editing/TextCheckingHelper.cpp:

(WebCore::findMisspellings):

editing/VisibleUnits.cpp:

(WebCore::wordBreakIteratorForMinOffsetBoundary):
(WebCore::wordBreakIteratorForMaxOffsetBoundary):
(WebCore::isLogicalStartOfWord):
(WebCore::islogicalEndOfWord):
(WebCore::visualWordPosition):
(WebCore::startSentenceBoundary):
(WebCore::endSentenceBoundary):
(WebCore::previousSentencePositionBoundary):
(WebCore::nextSentencePositionBoundary):

html/HTMLInputElement.cpp:
html/HTMLTextAreaElement.cpp:
html/InputType.cpp:
html/TextFieldInputType.cpp:
html/TextInputType.cpp:
platform/graphics/StringTruncator.cpp:

(WebCore::textBreakAtOrPreceding):
(WebCore::boundedTextBreakFollowing):
(WebCore::rightClipToWordBuffer):

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::ComplexTextController::offsetForPosition):

platform/text/TextBoundaries.cpp:

(WebCore::findNextWordFromIndex):
(WebCore::findWordBoundary):
(WebCore::findEndWordBoundary):

platform/text/mac/TextBoundaries.mm:

(WebCore::findNextWordFromIndex):

rendering/BreakLines.h:

(WebCore::nextBreakablePositionNonLoosely):
(WebCore::nextBreakablePositionLoosely):

rendering/RenderBlock.cpp:
rendering/RenderText.cpp:

(WebCore::makeCapitalized):
(WebCore::RenderText::previousOffset):
(WebCore::RenderText::previousOffsetForBackwardDeletion):
(WebCore::RenderText::nextOffset):

rendering/SimpleLineLayoutTextFragmentIterator.h:
rendering/line/LineBreaker.h:

Source/WebKit/ios:

Reviewed by Alex Christensen.

Misc/WebUIKitSupport.mm:

Source/WTF:

We have a class declaration for TextBreakIterator but no definition for it. When we
create an ICU UBreakIterator, we immediately reinterpret_cast it to this undefined
type, and pass it around our code inside WebCore. Then, whenever we want to actually
use this iterator, we reinterpret_cast it back to UBreakIterator. This is likely due
to some ports historically implementing breaking interators on top of other libraries
other than ICU; however, now, all ports use ICU. Because this internal type is not
helpful and just adds confusion, we should just call our breaking iterators what
they are: UBreakIterators.

This patch is a mechanical replacement of TextBreakIterator to UBreakIterator and
removes the functions we were calling which pass through directly to ubrk_*().

Reviewed by Alex Christensen.

wtf/text/LineBreakIteratorPoolICU.h:

(WTF::LineBreakIteratorPool::take):
(WTF::LineBreakIteratorPool::put):

wtf/text/StringView.cpp:

(WTF::StringView::GraphemeClusters::Iterator::Impl::computeIndexEnd):

wtf/text/TextBreakIterator.cpp:

(WTF::initializeIterator):
(WTF::initializeIteratorWithRules):
(WTF::setTextForIterator):
(WTF::setContextAwareTextForIterator):
(WTF::wordBreakIterator):
(WTF::sentenceBreakIterator):
(WTF::cursorMovementIterator):
(WTF::acquireLineBreakIterator):
(WTF::releaseLineBreakIterator):
(WTF::openLineBreakIterator):
(WTF::closeLineBreakIterator):
(WTF::getNonSharedCharacterBreakIterator):
(WTF::cacheNonSharedCharacterBreakIterator):
(WTF::isWordTextBreak):
(WTF::numGraphemeClusters):
(WTF::numCharactersInGraphemeClusters):
(WTF::textBreakFirst): Deleted.
(WTF::textBreakLast): Deleted.
(WTF::textBreakNext): Deleted.
(WTF::textBreakPrevious): Deleted.
(WTF::textBreakPreceding): Deleted.
(WTF::textBreakFollowing): Deleted.
(WTF::textBreakCurrent): Deleted.
(WTF::isTextBreak): Deleted.

wtf/text/TextBreakIterator.h:

(WTF::LazyLineBreakIterator::lastCharacter):
(WTF::LazyLineBreakIterator::secondToLastCharacter):
(WTF::LazyLineBreakIterator::setPriorContext):
(WTF::LazyLineBreakIterator::updatePriorContext):
(WTF::LazyLineBreakIterator::resetPriorContext):
(WTF::LazyLineBreakIterator::priorContextLength):
(WTF::LazyLineBreakIterator::get):
(WTF::NonSharedCharacterBreakIterator::operator UBreakIterator*):
(WTF::NonSharedCharacterBreakIterator::operator TextBreakIterator*): Deleted.

8:52 PM Changeset in webkit [209906] by Darin Adler

34 edits in trunk/Source

Use asString instead of toWTFString, toString, or getString when we already checked isString
https://bugs.webkit.org/show_bug.cgi?id=165895

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

Once we have called isString, we should always use asString and value rather than using
functions that have to deal with non-JSString objects. This leads to slightly fewer branches,
slightly less reference count churn, since the string is stored right inside the JSString,
and obviates the need for exception handling.

bindings/ScriptValue.cpp:

(Inspector::jsToInspectorValue): Use asString/value instead of getString.

dfg/DFGOperations.cpp:

(JSC::DFG::operationMapHash): Call jsMapHash with its new arguments.

inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::evaluateWithScopeExtension): Use asString/value instead
of toWTFString.

inspector/JSJavaScriptCallFrame.cpp:

(Inspector::JSJavaScriptCallFrame::evaluateWithScopeExtension): Ditto.

inspector/agents/InspectorHeapAgent.cpp:

(Inspector::InspectorHeapAgent::getPreview): Use asString/tryGetValue, instead of the
peculiar getString(nullptr) that was here before.

jsc.cpp:

(functionGetGetterSetter): Use asString/toIdentifier instead of the much less efficient
toWTFString/Identifier::fromString.
(functionIsRope): Use asString instead of jsCast<JSString*>; same thing, but we should
prefer the asString function, since it exists.
(functionFindTypeForExpression): Use asString/value instead of getString.
(functionHasBasicBlockExecuted): Ditto.
(functionBasicBlockExecutionCount): Ditto.
(functionCreateBuiltin): Use asString/value instead of toWTFString and removed
unneeded RETURN_IF_EXCEPTION.
(valueWithTypeOfWasmValue): Use asString instead of jsCast<String*>.
(box): Ditto.

runtime/DateConstructor.cpp:

(JSC::constructDate): Use asString/values instead of getString.

runtime/ExceptionHelpers.cpp:

(JSC::errorDescriptionForValue): Tweaked formatting.

runtime/HashMapImpl.h:

(JSC::jsMapHash): Changed this function to use asString/value.

runtime/JSCJSValue.cpp:

(JSC::JSValue::dumpInContextAssumingStructure): Use asString instead of
jsCast<JSString*>.
(JSC::JSValue::dumpForBacktrace): Ditto.

runtime/JSCJSValueInlines.h:

(JSC::toPreferredPrimitiveType): Ditto.

runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval): Use asString/value instead of toWTFString.

runtime/JSString.cpp:

(JSC::JSString::destroy): Streamlined by removing local variable.
(JSC::JSString::estimatedSize): Use asString instead of jsCast<JSString*>.
(JSC::JSString::visitChildren): Ditto.
(JSC::JSString::toThis): Ditto.

runtime/JSString.h:

(JSC::JSValue::toString): Ditto.
(JSC::JSValue::toStringOrNull): Ditto.

runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncValueOf): Ditto.

runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString): Ditto.

runtime/StringPrototype.cpp:

(JSC::stringProtoFuncRepeatCharacter): Ditto.
(JSC::stringProtoFuncSubstr): Ditto.
(JSC::builtinStringSubstrInternal): Simplified assertion by removing local variable.

Source/WebCore:

Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::extract): Use asString/value instead of toWTFString.

Modules/mediastream/SDPProcessor.cpp:

(WebCore::SDPProcessor::callScript): Use asString/value instead of getString.

bindings/js/ArrayValue.cpp:

(WebCore::ArrayValue::get): Use asString/value instead of toWTFString.

bindings/js/IDBBindingUtilities.cpp:

(WebCore::get): Use asString/length instead of toString/length.
(WebCore::createIDBKeyFromValue): Use asString/value instead of toWTFString.

bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::JSCryptoAlgorithmDictionary::getAlgorithmIdentifier): Ditto.

bindings/js/JSDataCueCustom.cpp:

(WebCore::constructJSDataCue): Use asString/value instead of getString.

bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::populateContextMenuItems): Use asString/value instead of toWTFString.

bindings/js/ScriptController.cpp:

(WebCore::jsValueToModuleKey): Use asString/toIdentifier instead of
jsCast<JSString*>/value/Identifier::fromString.

bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::dumpIfTerminal): Streamline by getting rid of local variable.

contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::getDomainList): Use asString instead of jsCast<JSString*>.
(WebCore::ContentExtensions::loadTrigger): Use asString/value instead of toWTFString.
(WebCore::ContentExtensions::loadAction): Ditto.

css/FontFace.cpp:

(WebCore::FontFace::create): Use asString/value instead of getString.

Source/WebKit/mac:

Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::addValueToArray): Use asString/value instead of
toWTFString.

WebView/WebView.mm:

(aeDescFromJSValue): Use asString/value instead of getString.

Source/WebKit2:

WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant): Use asString/value instead of toWTFString.

8:40 PM Changeset in webkit [209905] by bshafiei@apple.com

5 edits in tags/Safari-603.1.16.1/Source

Versioning.

8:37 PM Changeset in webkit [209904] by bshafiei@apple.com

1 copy in tags/Safari-603.1.16.1

New tag.

8:37 PM Changeset in webkit [209903] by Alan Bujtas

27 edits in trunk/Source/WebCore

Change ::computeLogicalHeight's computedValues out argument to the return value.
https://bugs.webkit.org/show_bug.cgi?id=165789

Reviewed by Simon Fraser.

No change in functionality.

html/shadow/SliderThumbElement.cpp:

(WebCore::RenderSliderContainer::computeLogicalHeight):

html/shadow/mac/ImageControlsButtonElementMac.cpp:

(WebCore::RenderImageControlsButton::computeLogicalHeight):

html/shadow/mac/ImageControlsRootElementMac.cpp:

(WebCore::RenderImageControls::computeLogicalHeight):

rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):
(WebCore::RenderBlock::estimateRegionRangeForBoxChild):

rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::checkForPaginationLogicalHeightChange):

rendering/RenderBox.cpp:

(WebCore::RenderBox::updateLogicalHeight):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::availableLogicalHeightUsing):

rendering/RenderBox.h:

(WebCore::RenderBox::ComputedMarginValues::ComputedMarginValues): Deleted.
(WebCore::RenderBox::LogicalExtentComputedValues::LogicalExtentComputedValues): Deleted.

rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::mainAxisContentExtent):

rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::computeLogicalHeight):

rendering/RenderFlowThread.h:
rendering/RenderListBox.cpp:

(WebCore::RenderListBox::computeLogicalHeight):

rendering/RenderListBox.h:
rendering/RenderMeter.cpp:

(WebCore::RenderMeter::computeLogicalHeight):

rendering/RenderMeter.h:
rendering/RenderMultiColumnFlowThread.cpp:

(WebCore::RenderMultiColumnFlowThread::computeLogicalHeight):

rendering/RenderMultiColumnFlowThread.h:
rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::computeLogicalHeight):

rendering/RenderMultiColumnSet.h:
rendering/RenderProgress.cpp:

(WebCore::RenderProgress::computeLogicalHeight):

rendering/RenderProgress.h:
rendering/RenderTextControl.cpp:

(WebCore::RenderTextControl::computeLogicalHeight):

rendering/RenderTextControl.h:
rendering/RenderView.cpp:

(WebCore::RenderView::computeLogicalHeight):

rendering/RenderView.h:
rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::computeLogicalHeight):

rendering/svg/RenderSVGForeignObject.h:

7:35 PM Changeset in webkit [209902] by dbates@webkit.org

2 edits in trunk/Tools

check-style should not complain about code in icu directories
https://bugs.webkit.org/show_bug.cgi?id=53929

Reviewed by Darin Adler.

Skip style checking of imported ICU headers to avoid a deluge of style issues
as they do not conform to the WebKit Code Style guideline. We want to preserve
the formatting of these headers so as to make it straightforward to merge
changes to them, if necessary.

Scripts/webkitpy/style/checker.py:

7:14 PM Changeset in webkit [209901] by Chris Dumez

17 edits
6 copies in trunk

Make sure HTML validation bubble's state is updated after layout
https://bugs.webkit.org/show_bug.cgi?id=165922
<rdar://problem/29694730>

Reviewed by Simon Fraser.

Source/WebCore:

Make sure HTML validation bubble's state is updated after layout.
In particular, if the validation bubble's associated element has
moved or is no longer visible, we now hide the bubble.

Tests: fast/forms/validation-bubble-disappears-when-input-detached.html

fast/forms/validation-bubble-disappears-when-input-moved.html
fast/forms/validation-bubble-disappears-when-input-no-longer-visible.html

page/FrameView.cpp:

(WebCore::FrameView::viewportContentsChanged):

page/Page.cpp:

(WebCore::Page::updateValidationBubbleStateIfNeeded):

page/Page.h:
page/ValidationMessageClient.h:

Source/WebKit/mac:

Make sure HTML validation bubble's state is updated after layout.
In particular, if the validation bubble's associated element has
moved or is no longer visible, we now hide the bubble.

WebCoreSupport/WebValidationMessageClient.h:
WebCoreSupport/WebValidationMessageClient.mm:

(WebValidationMessageClient::showValidationMessage):
(WebValidationMessageClient::hideValidationMessage):
(WebValidationMessageClient::updateValidationBubbleStateIfNeeded):

Source/WebKit2:

Make sure HTML validation bubble's state is updated after layout.
In particular, if the validation bubble's associated element has
moved or is no longer visible, we now hide the bubble.

WebProcess/WebCoreSupport/WebValidationMessageClient.cpp:

(WebKit::WebValidationMessageClient::showValidationMessage):
(WebKit::WebValidationMessageClient::hideValidationMessage):
(WebKit::WebValidationMessageClient::updateValidationBubbleStateIfNeeded):

WebProcess/WebCoreSupport/WebValidationMessageClient.h:

LayoutTests:

Add several layout tests to cover this.

fast/forms/validation-bubble-disappears-when-input-detached-expected.txt: Added.
fast/forms/validation-bubble-disappears-when-input-detached.html: Added.
fast/forms/validation-bubble-disappears-when-input-moved-expected.txt: Added.
fast/forms/validation-bubble-disappears-when-input-moved.html: Added.
fast/forms/validation-bubble-disappears-when-input-no-longer-visible-expected.txt: Added.
fast/forms/validation-bubble-disappears-when-input-no-longer-visible.html: Added.

7:01 PM Changeset in webkit [209900] by commit-queue@webkit.org

6 edits in trunk/Source/WebCore

[WebIDL] Remove use of Dictionary from JSCryptoAlgorithmDictionary
https://bugs.webkit.org/show_bug.cgi?id=165919

Patch by Sam Weinig <sam@webkit.org> on 2016-12-15
Reviewed by Darin Adler.

bindings/js/JSCryptoAlgorithmDictionary.cpp:
bindings/js/JSCryptoAlgorithmDictionary.h:
bindings/js/JSCryptoOperationData.cpp:
bindings/js/JSCryptoOperationData.h:
bindings/js/JSWebKitSubtleCryptoCustom.cpp:

Replace simplistic use of Dictionary with simplistic use of direct JSObject
functions. Also, pass the ExecState by reference.

6:38 PM Changeset in webkit [209899] by keith_miller@apple.com

4 edits
1 add in trunk

Fix validation of non-void if blocks with no else
https://bugs.webkit.org/show_bug.cgi?id=165938

Reviewed by Saam Barati.

JSTests:

Add a new failing test and a fix an existing one.

wasm/function-tests/dead-call.js:
wasm/function-tests/if-no-else-non-void.js: Added.

Source/JavaScriptCore:

We should not have been allowing non-void if-blocks that don't
have an else. Since this causes a value to be placed on the
stack that only appears under some control flow and not another.

wasm/WasmValidate.cpp:

6:25 PM Changeset in webkit [209898] by achristensen@apple.com

2 edits in trunk/Source/WebKit2

Improve NetworkSession logging
https://bugs.webkit.org/show_bug.cgi?id=165941

Reviewed by Tim Horton.

NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(-[WKNetworkSessionDelegate URLSession:task:didReceiveChallenge:completionHandler:]):
(-[WKNetworkSessionDelegate URLSession:task:didCompleteWithError:]):
(-[WKNetworkSessionDelegate URLSession:dataTask:didReceiveResponse:completionHandler:]):
One of the "didReceiveResponse completionHandler (cancel)" messages was wrong,
and other messages could have more useful information without being overwhelming.

6:16 PM Changeset in webkit [209897] by fpizlo@apple.com

118 edits
1 delete in trunk/Source

Get rid of HeapRootVisitor and make SlotVisitor less painful to use
https://bugs.webkit.org/show_bug.cgi?id=165911

Reviewed by Geoffrey Garen.
Source/JavaScriptCore:

Previously we had two ways of adding a raw pointer to the GC's mark stack:

SlotVisitor::appendUnbarrieredXYZ() methods
HeapRootVisitor::visit() methods

HeapRootVisitor existed only to prevent you from calling its non-WriteBarrier<> methods
unless you had permission. But SlotVisitor would let you do it anyway, because that was
a lot more practical.

I think that we should just have one way to do it. This removes HeapRootVisitor. It
also renames appendUnbarrieredXYZ to appendUnbarriered, and it removes the use of extra
indirection (so you now pass const WriteBarrier<>& instead of WriteBarrier<>*).

API/JSCallbackObject.h:

(JSC::JSCallbackObjectData::JSPrivatePropertyMap::visitChildren):

JavaScriptCore.xcodeproj/project.pbxproj:
Scripts/builtins/builtins_templates.py:
bytecode/CodeBlock.cpp:

(JSC::CodeBlock::visitWeakly):
(JSC::CodeBlock::visitChildren):
(JSC::CodeBlock::propagateTransitions):
(JSC::CodeBlock::determineLiveness):
(JSC::CodeBlock::visitOSRExitTargets):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::CodeBlock::stronglyVisitWeakReferences):

bytecode/DirectEvalCodeCache.cpp:

(JSC::DirectEvalCodeCache::visitAggregate):

bytecode/InternalFunctionAllocationProfile.h:

(JSC::InternalFunctionAllocationProfile::visitAggregate):

bytecode/ObjectAllocationProfile.h:

(JSC::ObjectAllocationProfile::visitAggregate):

bytecode/PolymorphicAccess.cpp:

(JSC::AccessCase::propagateTransitions):

bytecode/UnlinkedCodeBlock.cpp:

(JSC::UnlinkedCodeBlock::visitChildren):

bytecode/UnlinkedFunctionExecutable.cpp:

(JSC::UnlinkedFunctionExecutable::visitChildren):

debugger/DebuggerScope.cpp:

(JSC::DebuggerScope::visitChildren):

dfg/DFGDesiredTransitions.cpp:

(JSC::DFG::DesiredTransition::visitChildren):

dfg/DFGDesiredWeakReferences.cpp:

(JSC::DFG::DesiredWeakReferences::visitChildren):

dfg/DFGGraph.cpp:

(JSC::DFG::Graph::visitChildren):

dfg/DFGPlan.cpp:

(JSC::DFG::Plan::markCodeBlocks):
(JSC::DFG::Plan::checkLivenessAndVisitChildren):

heap/HandleSet.cpp:

(JSC::HandleSet::visitStrongHandles):

heap/HandleSet.h:
heap/HandleStack.cpp:

(JSC::HandleStack::visit):

heap/HandleStack.h:
heap/Heap.cpp:

(JSC::Heap::markToFixpoint):

heap/Heap.h:
heap/HeapRootVisitor.h: Removed.
heap/LargeAllocation.cpp:

(JSC::LargeAllocation::visitWeakSet):

heap/LargeAllocation.h:
heap/MarkedBlock.h:

(JSC::MarkedBlock::Handle::visitWeakSet):

heap/MarkedSpace.cpp:

(JSC::MarkedSpace::visitWeakSets):

heap/MarkedSpace.h:
heap/SlotVisitor.cpp:

(JSC::SlotVisitor::appendUnbarriered):

heap/SlotVisitor.h:
heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::appendUnbarriered):
(JSC::SlotVisitor::append):
(JSC::SlotVisitor::appendHidden):
(JSC::SlotVisitor::appendValues):
(JSC::SlotVisitor::appendValuesHidden):
(JSC::SlotVisitor::appendUnbarrieredPointer): Deleted.
(JSC::SlotVisitor::appendUnbarrieredReadOnlyPointer): Deleted.
(JSC::SlotVisitor::appendUnbarrieredValue): Deleted.
(JSC::SlotVisitor::appendUnbarrieredReadOnlyValue): Deleted.
(JSC::SlotVisitor::appendUnbarrieredWeak): Deleted.

heap/WeakBlock.cpp:

(JSC::WeakBlock::specializedVisit):
(JSC::WeakBlock::visit):

heap/WeakBlock.h:
heap/WeakSet.h:

(JSC::WeakSet::visit):

interpreter/ShadowChicken.cpp:

(JSC::ShadowChicken::visitChildren):

jit/GCAwareJITStubRoutine.cpp:

(JSC::MarkingGCAwareJITStubRoutine::markRequiredObjectsInternal):

jit/PolymorphicCallStubRoutine.cpp:

(JSC::PolymorphicCallStubRoutine::markRequiredObjectsInternal):

jsc.cpp:

(WTF::Element::visitChildren):
(WTF::ImpureGetter::visitChildren):
(WTF::SimpleObject::visitChildren):

runtime/AbstractModuleRecord.cpp:

(JSC::AbstractModuleRecord::visitChildren):

runtime/ArgList.cpp:

(JSC::MarkedArgumentBuffer::markLists):

runtime/ArgList.h:
runtime/ClonedArguments.cpp:

(JSC::ClonedArguments::visitChildren):

runtime/DirectArguments.cpp:

(JSC::DirectArguments::visitChildren):

runtime/EvalExecutable.cpp:

(JSC::EvalExecutable::visitChildren):

runtime/Exception.cpp:

(JSC::Exception::visitChildren):

runtime/FunctionExecutable.cpp:

(JSC::FunctionExecutable::visitChildren):

runtime/FunctionRareData.cpp:

(JSC::FunctionRareData::visitChildren):

runtime/GetterSetter.cpp:

(JSC::GetterSetter::visitChildren):

runtime/HashMapImpl.cpp:

(JSC::HashMapBucket<Data>::visitChildren):
(JSC::HashMapImpl<HashMapBucket>::visitChildren):

runtime/InferredTypeTable.cpp:

(JSC::InferredTypeTable::visitChildren):

runtime/InternalFunction.cpp:

(JSC::InternalFunction::visitChildren):

runtime/IntlCollator.cpp:

(JSC::IntlCollator::visitChildren):

runtime/IntlCollatorConstructor.cpp:

(JSC::IntlCollatorConstructor::visitChildren):

runtime/IntlDateTimeFormat.cpp:

(JSC::IntlDateTimeFormat::visitChildren):

runtime/IntlDateTimeFormatConstructor.cpp:

(JSC::IntlDateTimeFormatConstructor::visitChildren):

runtime/IntlNumberFormat.cpp:

(JSC::IntlNumberFormat::visitChildren):

runtime/IntlNumberFormatConstructor.cpp:

(JSC::IntlNumberFormatConstructor::visitChildren):

runtime/JSBoundFunction.cpp:

(JSC::JSBoundFunction::visitChildren):

runtime/JSCallee.cpp:

(JSC::JSCallee::visitChildren):

runtime/JSCellInlines.h:

(JSC::JSCell::visitChildren):

runtime/JSCustomGetterSetterFunction.cpp:

(JSC::JSCustomGetterSetterFunction::visitChildren):

runtime/JSFunction.cpp:

(JSC::JSFunction::visitChildren):

runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::visitChildren):

runtime/JSMapIterator.cpp:

(JSC::JSMapIterator::visitChildren):

runtime/JSModuleEnvironment.cpp:

(JSC::JSModuleEnvironment::visitChildren):

runtime/JSModuleNamespaceObject.cpp:

(JSC::JSModuleNamespaceObject::visitChildren):

runtime/JSModuleRecord.cpp:

(JSC::JSModuleRecord::visitChildren):

runtime/JSNativeStdFunction.cpp:

(JSC::JSNativeStdFunction::visitChildren):

runtime/JSObject.cpp:

(JSC::JSObject::visitButterflyImpl):

runtime/JSPromiseDeferred.cpp:

(JSC::JSPromiseDeferred::visitChildren):

runtime/JSPropertyNameEnumerator.cpp:

(JSC::JSPropertyNameEnumerator::visitChildren):

runtime/JSPropertyNameIterator.cpp:

(JSC::JSPropertyNameIterator::visitChildren):

runtime/JSProxy.cpp:

(JSC::JSProxy::visitChildren):

runtime/JSScope.cpp:

(JSC::JSScope::visitChildren):

runtime/JSSegmentedVariableObject.cpp:

(JSC::JSSegmentedVariableObject::visitChildren):

runtime/JSSetIterator.cpp:

(JSC::JSSetIterator::visitChildren):

runtime/JSString.cpp:

(JSC::JSRopeString::visitFibers):

runtime/JSSymbolTableObject.cpp:

(JSC::JSSymbolTableObject::visitChildren):

runtime/JSWeakMap.cpp:

(JSC::JSWeakMap::visitChildren):

runtime/JSWeakSet.cpp:

(JSC::JSWeakSet::visitChildren):

runtime/JSWithScope.cpp:

(JSC::JSWithScope::visitChildren):

runtime/JSWrapperObject.cpp:

(JSC::JSWrapperObject::visitChildren):

runtime/LazyClassStructure.cpp:

(JSC::LazyClassStructure::visit):

runtime/LazyPropertyInlines.h:

(JSC::ElementType>::visit):

runtime/MapBase.cpp:

(JSC::MapBase<HashMapBucketType>::visitChildren):

runtime/ModuleProgramExecutable.cpp:

(JSC::ModuleProgramExecutable::visitChildren):

runtime/NativeErrorConstructor.cpp:

(JSC::NativeErrorConstructor::visitChildren):

runtime/ProgramExecutable.cpp:

(JSC::ProgramExecutable::visitChildren):

runtime/ProxyObject.cpp:

(JSC::ProxyObject::visitChildren):

runtime/ProxyRevoke.cpp:

(JSC::ProxyRevoke::visitChildren):

runtime/RegExpCachedResult.cpp:

(JSC::RegExpCachedResult::visitChildren):

runtime/RegExpObject.cpp:

(JSC::RegExpObject::visitChildren):

runtime/RegExpPrototype.cpp:

(JSC::RegExpPrototype::visitChildren):

runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::visit):

runtime/ScopedArguments.cpp:

(JSC::ScopedArguments::visitChildren):

runtime/SmallStrings.cpp:

(JSC::SmallStrings::visitStrongReferences):

runtime/SparseArrayValueMap.cpp:

(JSC::SparseArrayValueMap::visitChildren):

runtime/Structure.cpp:

(JSC::Structure::visitChildren):
(JSC::Structure::markIfCheap):

runtime/StructureChain.cpp:

(JSC::StructureChain::visitChildren):

runtime/StructureRareData.cpp:

(JSC::StructureRareData::visitChildren):

runtime/SymbolTable.cpp:

(JSC::SymbolTable::visitChildren):

runtime/TypeProfilerLog.cpp:

(JSC::TypeProfilerLog::visit):

runtime/WeakMapData.cpp:

(JSC::WeakMapData::DeadKeyCleaner::visitWeakReferences):

wasm/js/JSWebAssemblyInstance.cpp:

(JSC::JSWebAssemblyInstance::visitChildren):

wasm/js/JSWebAssemblyMemory.cpp:

(JSC::JSWebAssemblyMemory::visitChildren):

wasm/js/JSWebAssemblyModule.cpp:

(JSC::JSWebAssemblyModule::visitChildren):

wasm/js/JSWebAssemblyTable.cpp:

(JSC::JSWebAssemblyTable::visitChildren):

wasm/js/WebAssemblyFunction.cpp:

(JSC::WebAssemblyFunction::visitChildren):

wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::visitChildren):

Source/WebCore:

No new tests because no new behavior.

This updates WebCore code to new JSC API.

bindings/js/JSDOMBinding.cpp:

(WebCore::DOMConstructorJSBuiltinObject::visitChildren):

bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::visitChildren):

bindings/js/JSDOMPromise.h:

(WebCore::DeferredPromise::visitAggregate):

bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::visitJSFunction):

bindings/js/JSWorkerGlobalScopeBase.cpp:

(WebCore::JSWorkerGlobalScopeBase::visitChildren):

bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

5:54 PM Changeset in webkit [209896] by mmaxfield@apple.com

14 edits in trunk/Source

Sort Xcode project files
https://bugs.webkit.org/show_bug.cgi?id=165937

Reviewed by Simon Fraser.

Source/bmalloc:

bmalloc.xcodeproj/project.pbxproj:

Source/JavaScriptCore:

JavaScriptCore.xcodeproj/project.pbxproj:

Source/ThirdParty/ANGLE:

ANGLE.xcodeproj/project.pbxproj:

Source/WebCore:

No new tests because there is no behavior change.

WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

WebKit.xcodeproj/project.pbxproj:

Source/WebKit2:

WebKit2.xcodeproj/project.pbxproj:

Source/WTF:

WTF.xcodeproj/project.pbxproj:

5:29 PM Changeset in webkit [209895] by Chris Dumez

22 edits in trunk

Move charCode / keyCode / which attributes from UIEvent to KeyboardEvent
https://bugs.webkit.org/show_bug.cgi?id=165904

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Rebaseline W3C test now that one more check is passing.

web-platform-tests/dom/events/Event-subclasses-constructors-expected.txt:

Source/WebCore:

Move 'charCode' / 'keyCode' attributes from UIEvent to KeyboardEvent and add
'which' to KeyboardEvent to match the specification:

https://w3c.github.io/uievents/#legacy-interface-KeyboardEvent

We keep a 'which' attribute on UIEvent even though the specification does
not say we should because Firefox and Chrome have 'which' on UIEvent still.

Specification:

'charCode' / 'keyCode' / 'which' on KeyboardEvent only

Firefox:

'charCode' / 'keyCode' on KeyboardEvent only
'which' on UIEvent only

Chrome:

'charCode' / 'keyCode' / 'which' on KeyboardEvent
'which' on UIEvent as well

Old WebKit behavior:

'charCode' / 'keyCode' / 'which' on UIEvent only

New WebKit behavior:

'charCode' / 'keyCode' / 'which' on KeyboardEvent
'which' on UIEvent as well

Our new behavior is identical to Chrome, much closer to the specification,
and closer to Firefox as well.

No new tests, updated / rebaselined existing tests.

dom/KeyboardEvent.cpp:

(WebCore::KeyboardEvent::KeyboardEvent):
(WebCore::KeyboardEvent::keyCode):
(WebCore::KeyboardEvent::charCode):
(WebCore::KeyboardEvent::which):

dom/KeyboardEvent.h:
dom/KeyboardEvent.idl:
dom/MouseEvent.cpp:

(WebCore::MouseEvent::which):

dom/UIEvent.cpp:
dom/UIEvent.h:
dom/UIEvent.idl:

Source/WebKit/mac:

Update ObjC bindings so they keep building.

DOM/DOMUIEvent.mm:

(-[DOMUIEvent keyCode]):
(-[DOMUIEvent charCode]):

LayoutTests:

Extend existing testing.

fast/events/arrow-keys-on-body-expected.txt:
fast/events/arrow-keys-on-body.html:
fast/events/key-events-in-input-button-expected.txt:
fast/events/key-events-in-input-button.html:
fast/events/key-events-in-input-text-expected.txt:
fast/events/key-events-in-input-text.html:

5:28 PM Changeset in webkit [209894] by ap@apple.com

3 edits in trunk/Tools

Move JSC testers from Yosemite to Sierra
https://bugs.webkit.org/show_bug.cgi?id=165925

Reviewed by Lucas Forschler.

BuildSlaveSupport/build.webkit.org-config/config.json:
BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

5:20 PM Changeset in webkit [209893] by beidson@apple.com

4 edits
1 add in trunk/Source/WebCore

IndexedDB: Add an "IDBCursorRecord" struct.
https://bugs.webkit.org/show_bug.cgi?id=165929

Reviewed by Alex Christensen.

No new tests (Refactor, no behavior change).

Modules/indexeddb/server/SQLiteIDBCursor.cpp:

(WebCore::IDBServer::SQLiteIDBCursor::currentData):
(WebCore::IDBServer::SQLiteIDBCursor::resetAndRebindStatement):
(WebCore::IDBServer::SQLiteIDBCursor::advanceUnique):
(WebCore::IDBServer::SQLiteIDBCursor::internalAdvanceOnce):
(WebCore::IDBServer::SQLiteIDBCursor::iterate):

Modules/indexeddb/server/SQLiteIDBCursor.h:

(WebCore::IDBServer::SQLiteIDBCursor::currentKey):
(WebCore::IDBServer::SQLiteIDBCursor::currentPrimaryKey):
(WebCore::IDBServer::SQLiteIDBCursor::currentValue):

Modules/indexeddb/shared/IDBCursorRecord.h: Added.

(WebCore::IDBCursorRecord::encode):
(WebCore::IDBCursorRecord::decode):

WebCore.xcodeproj/project.pbxproj:

5:14 PM Changeset in webkit [209892] by commit-queue@webkit.org

8 edits in trunk

Add coordinate space to event streams and streamline tests
https://bugs.webkit.org/show_bug.cgi?id=165119

Patch by Megan Gardner <Megan Gardner> on 2016-12-15
Reviewed by Simon Fraser.

Tools:

Update event streams to allow for both content and global coordinate space.
Update example script to more accurately show all the available options.

TestRunnerShared/UIScriptContext/Bindings/UIScriptController.idl:
WebKitTestRunner/ios/HIDEventGenerator.h:
WebKitTestRunner/ios/HIDEventGenerator.mm:
WebKitTestRunner/ios/UIScriptControllerIOS.mm:

(WTR::convertCoordinates):
(WTR::UIScriptController::sendEventStream):

LayoutTests:

Streamline tests. Make them more readable and only use one function for drags.
Update for new content coordinate space.

fast/events/touch/ios/long-press-then-drag-down-to-change-selected-text.html:
fast/events/touch/ios/long-press-then-drag-up-to-change-selected-text.html:

5:06 PM Changeset in webkit [209891] by keith_miller@apple.com

3 edits
1 add in trunk

Wasm should not create empty unlinked callsites
https://bugs.webkit.org/show_bug.cgi?id=165933

Reviewed by Mark Lam.

JSTests:

wasm/function-tests/dead-call.js: Added.

Source/JavaScriptCore:

Wasm would create holes in the unlinked callsite vector if B3 was able to
eliminate the callsite.

wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::addCall):

5:04 PM Changeset in webkit [209890] by Keith Rollin

2 edits in trunk/Source/WebCore

Refactor Document::suspend/resume
https://bugs.webkit.org/show_bug.cgi?id=165921

Reviewed by Chris Dumez.

Update Document::suspend to call Document::suspendScheduledTasks
rather than duplicating the latter's code within itself. Similar
treatment of Document::resume and Document::resumeScheduledTasks.

No new tests -- no new functionality, just refactoring existing code.

dom/Document.cpp:

(WebCore::Document::suspend):
(WebCore::Document::resume):

5:02 PM Changeset in webkit [209889] by Ryan Haddad

2 edits in trunk/LayoutTests

Marking js/dom/global-constructors-attributes.html as failing on ElCapitan WK1.
https://bugs.webkit.org/show_bug.cgi?id=165934

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

5:00 PM Changeset in webkit [209888] by Simon Fraser

2 edits in trunk/LayoutTests

fast/visual-viewport/ios/zoomed-focus-in-fixed.html always times out

Skip this test, which relies on touch events.

platform/ios-simulator/TestExpectations:

4:46 PM Changeset in webkit [209887] by Simon Fraser

3 edits in trunk/LayoutTests

Fix flakiness of fast/visual-viewport/ios/zoomed-focus-in-fixed.html
https://bugs.webkit.org/show_bug.cgi?id=165930

Reviewed by Tim Horton.

The test zooms when focussing the input, which completes after the keyboard shows,
so we need to wait for zooming to finish using the uiController.didEndZoomingCallback.

fast/visual-viewport/ios/zoomed-focus-in-fixed-expected.txt:
fast/visual-viewport/ios/zoomed-focus-in-fixed.html:

4:06 PM Changeset in webkit [209886] by bshafiei@apple.com

6 edits
1 copy in branches/safari-602-branch

Merged r204664. rdar://problem/29690089

4:04 PM Changeset in webkit [209885] by bshafiei@apple.com

7 edits
2 copies in branches/safari-602-branch

Merged r204618. rdar://problem/29690089

3:58 PM Changeset in webkit [209884] by bshafiei@apple.com

5 edits
1 delete in branches/safari-602-branch

Roll out r204664. rdar://problem/29690089

3:53 PM Changeset in webkit [209883] by achristensen@apple.com

9 edits
2 adds
1 delete in trunk

Remove flex and bison build dependencies; commit generated XPath parser
https://bugs.webkit.org/show_bug.cgi?id=165783

Reviewed by Brent Fulgham.

Source/cmake/WebKitCommon.cmake:
Source/cmake/WebKitMacros.cmake:

Source/WebCore:

flex and bison are annoying to install and use, especially on Windows.
Since only XPathGrammar uses them and that's not actively developed, let's just check in the one generated file
and make building WebKit easier forever!

CMakeLists.txt:
DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
css/makegrammar.pl: Removed.
xml/XPathGrammar.cpp: Added.

(xpathyylex):
(xpathyyerror):
(yysyntax_error):

xml/XPathGrammar.h: Added.
xml/XPathGrammar.y: Rename TEXT to TEXT_ to fix a build error on Windows. TEXT is already defined.

3:52 PM Changeset in webkit [209882] by Matt Baker

6 edits in trunk/Source/WebInspectorUI

Web Inspector: console search bar jumps, behaves poorly at narrow widths
https://bugs.webkit.org/show_bug.cgi?id=164047
<rdar://problem/29055582>

Reviewed by Timothy Hatcher.

At narrow widths the find banner behaves poorly in the split console
toolbar. It should work like the main content browser, appearing below
the toolbar when Command-F is pressed and either the split console or
quick console prompt has the focus.

UserInterface/Base/Main.js:

(WebInspector.contentLoaded):
Enable split content browser find banner.

UserInterface/Views/ContentBrowser.js:

(WebInspector.ContentBrowser.prototype.showFindBanner):
Check for custom find banner support at runtime.
(WebInspector.ContentBrowser.prototype._findBannerDidShow):
(WebInspector.ContentBrowser.prototype._findBannerDidHide):
Refresh search results when banner is shown/hidden, instead of relying
on toggling the "showing-find-banner" class name for everything.

(WebInspector.ContentBrowser.prototype.handleFindEvent): Deleted.
Renamed showFindBanner.

UserInterface/Views/ContentView.js:

(WebInspector.ContentView.prototype.get supportsCustomFindBanner):
(WebInspector.ContentView.prototype.showCustomFindBanner):
Custom find banner support (used by LogContentView).

UserInterface/Views/LogContentView.js:

(WebInspector.LogContentView):
(WebInspector.LogContentView.prototype.get supportsSearch):
(WebInspector.LogContentView.prototype.get numberOfSearchResults):
(WebInspector.LogContentView.prototype.get hasPerformedSearch):
Cleanup.
(WebInspector.LogContentView.prototype.get supportsCustomFindBanner):
Use toolbar item find banner when showing Console tab.
(WebInspector.LogContentView.prototype.findBannerRevealPreviousResult):
(WebInspector.LogContentView.prototype.findBannerRevealNextResult):
(WebInspector.LogContentView.prototype._isMessageVisible):
(WebInspector.LogContentView.prototype._visibleMessageElements):
(WebInspector.LogContentView.prototype._logCleared):
(WebInspector.LogContentView.prototype._filterMessageElements):
(WebInspector.LogContentView.prototype.findBannerPerformSearch):
(WebInspector.LogContentView.prototype.findBannerSearchCleared):
(WebInspector.LogContentView.prototype.performSearch):
Support both the standard and custom (toolbar item) find banners.
(WebInspector.LogContentView.prototype.searchCleared):
Refresh search results.
(WebInspector.LogContentView.prototype._highlightRanges):
Correct spelling: _selectedSearchMathIsValid -> _selectedSearchMatchIsValid.
(WebInspector.LogContentView.prototype.get searchInProgress): Deleted.
Override ContentView.prototype.hasPerformedSearch instead.
(WebInspector.LogContentView.prototype.handleFindEvent): Deleted.
Replaced by showCustomFindBanner.
(WebInspector.LogContentView.prototype.highlightPreviousSearchMatch): Deleted.
Absorbed by findBannerRevealPreviousResult.
(WebInspector.LogContentView.prototype.highlightNextSearchMatch): Deleted.
Absorbed by findBannerRevealNextResult.
(WebInspector.LogContentView.prototype._performSearch): Deleted.
Override ContentView.prototype.performSearch instead.

UserInterface/Views/Main.css:

(#split-content-browser > .navigation-bar :matches(.find-banner, .find-banner + .divider)):
Hide the toolbar banner and divider.

3:42 PM Changeset in webkit [209881] by beidson@apple.com

4 edits in trunk/Source/WebCore

Enhance some of the logging statements just added for IndexedDB Operation scheduling.

Rubberstamped by Tim Horton.

No new tests (No behavior change).

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::iterateCursor):
(WebCore::IDBTransaction::requestGetRecord):
(WebCore::IDBTransaction::requestIndexRecord):
(WebCore::IDBTransaction::requestPutOrAdd):

Modules/indexeddb/shared/IDBCursorInfo.cpp:

(WebCore::IDBCursorInfo::loggingString):

Modules/indexeddb/shared/IDBIterateCursorData.cpp:

(WebCore::IDBIterateCursorData::loggingString):

3:42 PM Changeset in webkit [209880] by jfbastien@apple.com

24 edits in trunk

WebAssembly: improve compilation error messages
https://bugs.webkit.org/show_bug.cgi?id=163919

Reviewed by Saam Barati.

JSTests:

Update error messages in these tests.
Use the assert.throws facility in many of them which weren't already.

wasm/js-api/element.js:

(assert.throws.new.WebAssembly.Module.builder.WebAssembly):
(assert.throws):

wasm/js-api/global-error.js:

(assert.throws.new.WebAssembly.Module.bin):
(assert.throws):
(new.Number):

wasm/js-api/table.js:

(assert.throws.new.WebAssembly.Module.builder.WebAssembly):
(assert.throws):
(assertBadTableImport):

wasm/js-api/test_Data.js:

(DataSectionWithoutMemory):

wasm/js-api/test_Start.js:

(InvalidStartFunctionIndex):

wasm/js-api/test_basic_api.js:

(const.c.in.constructorProperties.switch):

Source/JavaScriptCore:

The error handling messages were underwhelming because most
locations merely returned false on failure. This patch uses
std::expected to denote that failure isn't expected. Doing this
makes it almost impossible to mess up the code: either a function
returns a result (or a partial result for internal helpers) or an
error. We're not synchronizing the error string with the m_failed
bool anymore, and the caller will abort if they try to get a
result but the outcome was an error.

This also shortens the code significantly using macros, while also
judiciously preventing inlining of error handling code and biasing
towards success using UNLIKELY. This means that the generated code
should be more efficient (no string formatting on success, and
regalloc can avoid these unlikely paths).

The patch adds a few missing checks as well, especially related to
count limits and memory allocation failure.

As a follow-up I'd like to improve WTF::makeString further, so it
does coercions to string and understands ADL as I did in this
patch.

wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::fail):
(JSC::Wasm::parseAndCompile):

wasm/WasmB3IRGenerator.h:
wasm/WasmFormat.h:

(JSC::Wasm::isValidExternalKind):
(JSC::Wasm::makeString):

wasm/WasmFunctionParser.h:
wasm/WasmModuleParser.cpp:
wasm/WasmModuleParser.h:
wasm/WasmParser.h:

(JSC::Wasm::FailureHelper::makeString):
(JSC::Wasm::Parser::fail):
(JSC::Wasm::Parser<SuccessType>::Parser):
(JSC::Wasm::Parser<SuccessType>::consumeCharacter):
(JSC::Wasm::Parser<SuccessType>::consumeString):
(JSC::Wasm::Parser<SuccessType>::consumeUTF8String):
(JSC::Wasm::Parser<SuccessType>::parseVarUInt32):
(JSC::Wasm::Parser<SuccessType>::parseVarUInt64):
(JSC::Wasm::Parser<SuccessType>::parseVarInt32):
(JSC::Wasm::Parser<SuccessType>::parseVarInt64):
(JSC::Wasm::Parser<SuccessType>::parseUInt32):
(JSC::Wasm::Parser<SuccessType>::parseUInt64):
(JSC::Wasm::Parser<SuccessType>::parseUInt8):
(JSC::Wasm::Parser<SuccessType>::parseInt7):
(JSC::Wasm::Parser<SuccessType>::parseUInt7):
(JSC::Wasm::Parser<SuccessType>::parseVarUInt1):
(JSC::Wasm::Parser<SuccessType>::parseResultType):
(JSC::Wasm::Parser<SuccessType>::parseValueType):
(JSC::Wasm::Parser<SuccessType>::parseExternalKind):

wasm/WasmPlan.cpp:

(JSC::Wasm::Plan::run):

wasm/WasmSections.h:

(JSC::Wasm::isValidSection):
(JSC::Wasm::validateOrder):
(JSC::Wasm::makeString):

wasm/WasmValidate.cpp:

(JSC::Wasm::Validate::fail):
(JSC::Wasm::Validate::addUnreachable):
(JSC::Wasm::validateFunction):

wasm/WasmValidate.h:
wasm/generateWasmB3IRGeneratorInlinesHeader.py:
wasm/generateWasmOpsHeader.py:
wasm/generateWasmValidateInlinesHeader.py:

(loadMacro):
(storeMacro):

wasm/js/WebAssemblyInstanceConstructor.cpp:

(JSC::constructJSWebAssemblyInstance):

wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::link):

3:12 PM Changeset in webkit [209879] by bshafiei@apple.com

5 edits
1 copy in branches/safari-602-branch

Merged r204664. rdar://problem/29690089

3:06 PM Changeset in webkit [209878] by bshafiei@apple.com

2 edits in branches/safari-602-branch/Source/WebCore

Merged r209819. rdar://problem/29686479

3:05 PM Changeset in webkit [209877] by bshafiei@apple.com

2 edits in branches/safari-602-branch/Source/WebCore

Merged r209776. rdar://problem/29686479

2:48 PM Changeset in webkit [209876] by andersca@apple.com

3 edits in trunk/Source/WebKit2

Add more mach_msg logging instrumentation
https://bugs.webkit.org/show_bug.cgi?id=165914

Reviewed by Darin Adler.

Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::sendMessage):
(IPC::Connection::sendOutgoingMessage):

Platform/IPC/mac/MachMessage.h:

(IPC::MachMessage::messageName):
(IPC::MachMessage::setMessageName):

2:12 PM Changeset in webkit [209875] by mmaxfield@apple.com

16 edits
4 adds in trunk

[Cocoa] Implement font-synthesis: small-caps
https://bugs.webkit.org/show_bug.cgi?id=165892

Reviewed by David Hyatt.

Source/WebCore:

The CSS Fonts level 4 spec adds a new value to the "font-synthesis"
property which controls whether or not small-caps is allowed to be
synthesized. Luckily, we already have an implementation of this
straightforward, so the implementation is quite simple.

Tests: css3/font-synthesis-small-caps.html

fast/text/font-synthesis-parsing.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::fontSynthesisFromStyle):

css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertFontSynthesis):

css/parser/CSSPropertyParser.cpp:

(WebCore::consumeFontSynthesis):

platform/graphics/FontCache.h:

(WebCore::FontDescriptionKey::makeFlagsKey):

platform/graphics/FontDescription.cpp:

(WebCore::FontDescription::FontDescription):

platform/graphics/FontDescription.h:

(WebCore::FontCascadeDescription::initialFontSynthesis):

platform/graphics/mac/ComplexTextController.cpp:

(WebCore::shouldSynthesize):
(WebCore::ComplexTextController::collectComplexTextRuns):

LayoutTests:

fast/text/font-synthesis-parsing-expected.txt: Added.
fast/text/font-synthesis-parsing.html: Added.
css3/font-synthesis-small-caps-expected.html: Added.
css3/font-synthesis-small-caps.html: Added.
fast/css/getComputedStyle/computed-style-expected.txt:
fast/css/getComputedStyle/computed-style-font-family-expected.txt:
fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
fast/css3-text/font-synthesis-parse-expected.txt:
fast/css3-text/font-synthesis-parse.html:
svg/css/getComputedStyle-basic-expected.txt:

2:08 PM Changeset in webkit [209874] by jfbastien@apple.com

5 edits
1 add in trunk

JSTests:
WebAssembly API: improve data section errors
https://bugs.webkit.org/show_bug.cgi?id=165733

Reviewed by Keith Miller.

wasm/js-api/element-data.js: Added.

(ElementBeforeData.set const):
(ElementBeforeData): check the order of initialization, which is observable on failure

wasm/js-api/test_Data.js:

(DataSectionWithoutMemory):
(DataSectionOffTheEnd): Deleted.
(DataSectionPartlyOffTheEnd): Deleted.
(DataSectionEmptyOffTheEnd): Deleted.
(DataSectionSeenByStart): Deleted.

Source/JavaScriptCore:
WebAssembly API: improve data section errors, initialize after Element
https://bugs.webkit.org/show_bug.cgi?id=165733

Reviewed by Keith Miller.

wasm/WasmModuleParser.cpp:

(JSC::Wasm::ModuleParser::parseData): Data section without Memory section or import is a validation error

wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::dataSegmentFail):
(JSC::WebAssemblyModuleRecord::evaluate): tighten checks (though the spec isn't fully baked), and move after Element initialization

2:08 PM Changeset in webkit [209873] by beidson@apple.com

17 edits in trunk/Source/WebCore

Add a new Logging Channel for IndexedDB Operation scheduling.
https://bugs.webkit.org/show_bug.cgi?id=165912

Reviewed by Alex Christensen.

No new tests (No behavior change).

Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::transaction):

Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):

Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::internalAbort):
(WebCore::IDBTransaction::commit):
(WebCore::IDBTransaction::createObjectStore):
(WebCore::IDBTransaction::renameObjectStore):
(WebCore::IDBTransaction::createIndex):
(WebCore::IDBTransaction::renameIndex):
(WebCore::IDBTransaction::doRequestOpenCursor):
(WebCore::IDBTransaction::iterateCursor):
(WebCore::IDBTransaction::requestGetAllObjectStoreRecords):
(WebCore::IDBTransaction::requestGetAllIndexRecords):
(WebCore::IDBTransaction::requestGetRecord):
(WebCore::IDBTransaction::requestIndexRecord):
(WebCore::IDBTransaction::requestCount):
(WebCore::IDBTransaction::requestDeleteRecord):
(WebCore::IDBTransaction::requestClearObjectStore):
(WebCore::IDBTransaction::requestPutOrAdd):
(WebCore::IDBTransaction::deleteObjectStore):
(WebCore::IDBTransaction::deleteIndex):

Modules/indexeddb/shared/IDBCursorInfo.cpp:

(WebCore::IDBCursorInfo::loggingString):

Modules/indexeddb/shared/IDBCursorInfo.h:

Modules/indexeddb/shared/IDBGetAllRecordsData.cpp:

(WebCore::IDBGetAllRecordsData::loggingString):

Modules/indexeddb/shared/IDBGetAllRecordsData.h:

Modules/indexeddb/shared/IDBGetRecordData.cpp:

(WebCore::IDBGetRecordData::loggingString):

Modules/indexeddb/shared/IDBGetRecordData.h:

Modules/indexeddb/shared/IDBIndexInfo.cpp:

(WebCore::IDBIndexInfo::condensedLoggingString):

Modules/indexeddb/shared/IDBIndexInfo.h:

Modules/indexeddb/shared/IDBIterateCursorData.cpp:

(WebCore::IDBIterateCursorData::loggingString):

Modules/indexeddb/shared/IDBIterateCursorData.h:

Modules/indexeddb/shared/IDBObjectStoreInfo.cpp:

(WebCore::IDBObjectStoreInfo::condensedLoggingString):

Modules/indexeddb/shared/IDBObjectStoreInfo.h:

platform/Logging.h:

2:07 PM Changeset in webkit [209872] by keith_miller@apple.com

2 edits in trunk/Source/JavaScriptCore

Turn on WebAssembly by default
https://bugs.webkit.org/show_bug.cgi?id=165918

Reviewed by Saam Barati.

runtime/Options.h:

1:26 PM Changeset in webkit [209871] by Konstantin Tokarev

88 edits in trunk/Source

Added missing override and final specifiers
https://bugs.webkit.org/show_bug.cgi?id=165903

Reviewed by Darin Adler.

Source/JavaScriptCore:

bytecompiler/BytecodeGenerator.h:
jsc.cpp:
parser/Nodes.h:

Source/WebCore:

No new tests needed.

Modules/mediastream/OverconstrainedErrorEvent.h:
bindings/js/JSCallbackData.h:
bindings/js/JSCustomXPathNSResolver.h:
bindings/js/JSErrorHandler.h:
css/StyleRuleImport.h:
dom/SecurityPolicyViolationEvent.h:
editing/CreateLinkCommand.h:
editing/DeleteSelectionCommand.h:
editing/DictationCommand.h:
editing/Editor.cpp:
editing/FormatBlockCommand.h:
editing/IndentOutdentCommand.h:
editing/InsertLineBreakCommand.h:
editing/InsertParagraphSeparatorCommand.h:
editing/ModifySelectionListLevel.h:
editing/MoveSelectionCommand.h:
editing/RemoveFormatCommand.h:
editing/RemoveNodePreservingChildrenCommand.h:
editing/ReplaceSelectionCommand.h:
editing/SimplifyMarkupCommand.h:
editing/SplitTextNodeContainingElementCommand.h:
editing/UnlinkCommand.h:
fileapi/FileReaderLoader.h:
html/canvas/ANGLEInstancedArrays.h:
html/canvas/WebGLVertexArrayObjectBase.h:
loader/SinkDocument.h:
loader/archive/mhtml/MHTMLArchive.h:
page/animation/CSSPropertyAnimation.cpp:
platform/audio/MultiChannelResampler.cpp:
platform/audio/SincResampler.cpp:
platform/audio/gstreamer/AudioDestinationGStreamer.h:
platform/audio/gstreamer/AudioSourceProviderGStreamer.h:
platform/graphics/TextTrackRepresentation.cpp:
platform/graphics/displaylists/DisplayListItems.h:
platform/graphics/filters/FEBlend.h:
platform/graphics/filters/FEColorMatrix.h:
platform/graphics/filters/FEComponentTransfer.h:
platform/graphics/filters/FEConvolveMatrix.h:
platform/graphics/filters/FEDiffuseLighting.h:
platform/graphics/filters/FEDropShadow.h:
platform/graphics/filters/FEGaussianBlur.h:
platform/graphics/filters/FELighting.h:
platform/graphics/filters/FEMerge.h:
platform/graphics/filters/FEMorphology.h:
platform/graphics/filters/FEOffset.h:
platform/graphics/filters/FESpecularLighting.h:
platform/graphics/filters/FETile.h:
platform/graphics/filters/FETurbulence.h:
platform/graphics/filters/SourceAlpha.h:
platform/graphics/filters/SourceGraphic.h:
platform/graphics/opengl/Extensions3DOpenGL.h:
platform/graphics/opengl/Extensions3DOpenGLCommon.h:
platform/graphics/texmap/TextureMapperBackingStore.h:
platform/mediastream/openwebrtc/RealtimeMediaSourceOwr.h:
platform/mock/GeolocationClientMock.h:
platform/text/TextCodecICU.h:
platform/text/TextCodecLatin1.h:
platform/text/TextCodecUTF16.h:
platform/text/TextCodecUTF8.h:
platform/text/TextCodecUserDefined.h:
rendering/RenderFullScreen.cpp:
storage/StorageEvent.h:
svg/properties/SVGListProperty.h:
svg/properties/SVGStaticListPropertyTearOff.h:
svg/properties/SVGStaticPropertyTearOff.h:
xml/NativeXPathNSResolver.h:
xml/XMLHttpRequestProgressEvent.h:
xml/XMLHttpRequestProgressEventThrottle.h:
xml/XPathVariableReference.h:
xml/XSLImportRule.h:

Source/WebKit2:

UIProcess/API/gtk/WebKitGeolocationProvider.h:
UIProcess/WebFormSubmissionListenerProxy.h:
UIProcess/WebFramePolicyListenerProxy.h:
WebProcess/Automation/WebAutomationSessionProxy.h:
WebProcess/InjectedBundle/API/gtk/DOM/GObjectXPathNSResolver.h:
WebProcess/MediaCache/WebMediaKeyStorageManager.h:
WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
WebProcess/WebCoreSupport/WebPlugInClient.h:
WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
WebProcess/WebPage/FindController.h:

Source/WTF:

wtf/RunLoop.h:

1:08 PM Changeset in webkit [209870] by Chris Dumez

3 edits in trunk/Source/WebCore

Inline Document::existingAXObjectCache()
https://bugs.webkit.org/show_bug.cgi?id=165906

Reviewed by Darin Adler.

Inline Document::existingAXObjectCache() to avoid paying function call
cost in the common case where AX is disabled.

dom/Document.cpp:

(WebCore::Document::existingAXObjectCacheSlow):
(WebCore::Document::existingAXObjectCache): Deleted.

dom/Document.h:

(WebCore::Document::existingAXObjectCache):

12:55 PM Changeset in webkit [209869] by Chris Dumez

2 edits in trunk/Source/JavaScriptCore

Harden JSObject::getOwnPropertyDescriptor()
https://bugs.webkit.org/show_bug.cgi?id=165908

Reviewed by Geoffrey Garen.

runtime/JSObject.cpp:

(JSC::JSObject::getOwnPropertyDescriptor):

12:18 PM Changeset in webkit [209868] by Ryan Haddad

2 edits in trunk/Source/WebCore

Rebaseline bindings tests after r209864.

Unreviewed test gardening.

bindings/scripts/test/JS/JSTestStandaloneDictionary.cpp:

(WebCore::convertDictionary<DictionaryImplName>):

11:19 AM Changeset in webkit [209867] by Simon Fraser

11 edits
3 adds in trunk

[iOS WK2] Don't disable position:fixed when a form element has focus
https://bugs.webkit.org/show_bug.cgi?id=165891
rdar://problem/29271694

Reviewed by Wenson Hsieh.

Source/WebKit2:

Before visual viewports, we had to lay out position:fixed relative to the document rect (effectively
disabling position:fixed) when a form element was focused, to ensure that we could scroll to inputs
inside position:Fixed.

When visual viewports are enabled, we can do a better job of this, and keep position:fixed active.

Test: fast/visual-viewport/ios/zoomed-focus-in-fixed.html

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _zoomToFocusRect:selectionRect:insideFixed:fontSize:minimumScale:maximumScale:allowScaling:forceScroll:]): Soon this will use
insideFixed to have better scroll-into-view behavior.
(-[WKWebView _zoomToFocusRect:selectionRect:fontSize:minimumScale:maximumScale:allowScaling:forceScroll:]): Deleted.

UIProcess/API/Cocoa/WKWebViewInternal.h:
UIProcess/ios/WKContentView.h:
UIProcess/ios/WKContentView.mm:

(-[WKContentView _zoomToFocusRect:selectionRect:insideFixed:fontSize:minimumScale:maximumScale:allowScaling:forceScroll:]):
(-[WKContentView _zoomToFocusRect:selectionRect:fontSize:minimumScale:maximumScale:allowScaling:forceScroll:]): Deleted.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _displayFormNodeInputView]):

UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::computeCustomFixedPositionRect): Don't fall back to using the documentRect as the fixed
position rect if visual viewports are enabled.

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getAssistedNodeInformation): Don't reset the customtFixedPositionRect around computing element
coordinates if visual viewports are enabled.

LayoutTests:

TestExpectations:
fast/visual-viewport/ios/zoomed-focus-in-fixed-expected.txt: Added.
fast/visual-viewport/ios/zoomed-focus-in-fixed.html: Added.
platform/ios-simulator-wk2/TestExpectations:

11:17 AM Changeset in webkit [209866] by keith_miller@apple.com

5 edits
5 adds in trunk

Fix 64-bit shift family Wasm opcodes
https://bugs.webkit.org/show_bug.cgi?id=165902

Reviewed by Geoffrey Garen.

JSTests:

Add tests for shift family of instructions. Since
we can't generate i64 values to pass to wasm we only compile
the code for those functions. Attempting to generate any i64
code using these instructions would have been enough to cause
the B3 Validation error anyway.

wasm/assert.js:
wasm/function-tests/rotl.js: Added.
wasm/function-tests/rotr.js: Added.
wasm/function-tests/shl.js: Added.
wasm/function-tests/shr-s.js: Added.
wasm/function-tests/shr-u.js: Added.
wasm/wasm.json:

Source/JavaScriptCore:

The Int64 versions of the shift family B3 opcodes take an Int32
for the shift value. Wasm, however, takes an i64, so we need to
Trunc the shift value. Also, this fixes a bug where shr_u mapped
to signed shift and shr_s mapped to the unsigned shift.

wasm/wasm.json:

10:37 AM Changeset in webkit [209865] by akling@apple.com

7 edits in trunk/Source

Always clear RenderLayer backing stores when going into page cache.
<https://webkit.org/b/165901>

Reviewed by Simon Fraser.

Source/WebCore:

We were already doing this for the iOS and GTK+ ports, let's do it everywhere
for consistency, and a bit of memory usage improvement.

This patch just removes the setting and always calls FrameView::clearBackingStores()
when there is composited content going into page cache.

history/CachedFrame.cpp:

(WebCore::CachedFrame::CachedFrame):

history/PageCache.h:

(WebCore::PageCache::shouldClearBackingStores): Deleted.
(WebCore::PageCache::setShouldClearBackingStores): Deleted.

Source/WebKit/mac:

WebView/WebView.mm:

(+[WebView _setCacheModel:]):

Source/WebKit2:

WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

9:25 AM Changeset in webkit [209864] by Darin Adler

25 edits
3 adds
2 deletes in trunk

Remove custom binding for MediaDevices
https://bugs.webkit.org/show_bug.cgi?id=165894

Reviewed by Eric Carlson.

Source/WebCore:

Removes the explicit code to parse the MediaStreamConstraints and
MediaTrackConstraints. Next step could be to change the internal
code to use the structs from bindings directly so we don't need
code to convert to an internal format.

CMakeLists.txt: Added MediaTrackConstraints.idl and MediaTrackConstraints.cpp,

removed JSMediaDevicesCustom.cpp.

DerivedSources.make: Added MediaTrackConstraints.idl.

Also sorted list of IDL files and fixed use of tabs.

Modules/mediastream/MediaDevices.cpp:

(WebCore::createMediaConstraintsImpl): Added.
(WebCore::MediaDevices::getUserMedia): Changed this function to take arguments that
are generated by the bindings script, and call createMediaConstraintsImpl to convert
into the internal data structure.

Modules/mediastream/MediaDevices.h: Added StreamConstraints struct and changed

getUserMedia to take that as specified in the IDL.

Modules/mediastream/MediaDevices.idl: Added definition of the MediaStreamConstraints

dictionary. Removed [Custom] from getUserMedia.

Modules/mediastream/MediaStream.cpp:

(WebCore::MediaStream::MediaStream): Pass a reference to addObserver.
(WebCore::MediaStream::~MediaStream): Pass a rference to removeObserver.
(WebCore::MediaStream::internalAddTrack): Ditto.
(WebCore::MediaStream::internalRemoveTrack): Ditto.

Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::createMediaConstraintsImpl): Added.
(WebCore::MediaStreamTrack::applyConstraints): Changed to take an optional
MediaTrackConstraints argument and call createMediaConstraintsImpl to convert
into the internal data structure. Also merged the multiple overloads of this
all into a single function, used auto to make the code easier to read, and
moved the code that stores new constrains into the success handling, since the
specification says that's the only case where we should store it.
(WebCore::MediaStreamTrack::addObserver): Take a reference instead of a pointer.
(WebCore::MediaStreamTrack::removeObserver): Ditto.

Modules/mediastream/MediaStreamTrack.h: Removed many unneeded includes.

Changed getConstraints to return const MediaTrackConstraints&, applyConstraints
to take an optional MediaTrackConstraints, add/removeObserver to take a reference
rather than a pointer, and changed m_constraints to be a MediaTrackConstraints
instead of a RefPtr<MediaConstraints>.

Modules/mediastream/MediaStreamTrack.idl: Removed [Custom] from getConstraints

and applyConstraints.

Modules/mediastream/MediaTrackConstraints.cpp: Added.

(WebCore::set): Overloaded function to set constriaints in a
MediaTrackConstraintSetMap.
(WebCore::convertToInternalForm): Helper function that takes a
MediaTrackConstraintSet and turns it into a MediaTrackConstraintSetMap.
(WebCore::convertAdvancedToInternalForm): More of the same, but for vectors.
(WebCore::createMediaConstraintsImpl): Top level function. Calls the other
functions and then MediaConstraintsImpl::create.

Modules/mediastream/MediaTrackConstraints.h: Added. Contains all the structures

and type definitions for the dictionaries defined in the IDL file, and also the
createMediaConstraintsImpl function declaration.

Modules/mediastream/MediaTrackConstraints.idl: Added. Contains the

MediaTrackConstraints and all the other dictionaries and typedefs that are needed
to define that dictionary.

Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::start): Changed to not depend on MediaDevices::Promise.
(WebCore::UserMediaRequest::UserMediaRequest): Ditto.
(WebCore::isSecure): Rearranged to be easier to understand.
(WebCore::UserMediaRequest::start): Removed a local variable for simplicity.
(WebCore::UserMediaRequest::document): Removed a redundant null check.

Modules/mediastream/UserMediaRequest.h: Reduced includes, changed to not depend

on MediaDevices::Promise, removing the reason to include MediaDevices.h.

WebCore.xcodeproj/project.pbxproj: Updated to remove old files and add new ones.

bindings/js/JSBindingsAllInOne.cpp: Removed JSMediaDevicesCustom.cpp.

bindings/js/JSMediaDevicesCustom.cpp: Removed.
bindings/js/JSMediaDevicesCustom.h: Removed.

bindings/js/JSMediaStreamTrackCustom.cpp:

(WebCore::JSMediaStreamTrack::applyConstraints): Deleted.
(WebCore::JSMediaStreamTrack::getConstraints): Deleted.

bindings/scripts/CodeGenerator.pm:

(ProcessDocument): Updated to allow multiple standalone dictionaries, as long as
the name of one of the dictionaries matches the name of the file.

bindings/scripts/CodeGeneratorJS.pm:

(GenerateDictionary): Added "other dictionaries" argument so we can support
files with multiple dictionaries in them.
(GenerateDictionariesHeaderContent): Completed support for dictionaries that
are not named after a top level interface by added one more check for a missing
$interface in a place that otherwise would not handle it correctly.
(GenerateImplementation): Removed code that set $currentCachedAttribute and
$cacheIndex, since no was reading the value of either any longer.
(GenerateDictionaryHeader): Added "other dictionaries".
(GenerateDictionaryImplementation): Ditto.
(WriteData): Removed unnnecessarily indirect code that was using FileNamePrefix
and a local variable named $prefix instead of just writing "JS".

bindings/scripts/generate-bindings.pl: Corrected the use of the fileparse

function from the Path::Basename module; after reading the documentation for
this it is clear that there is no need to first call basename, and fileparse
should also be used instead of basename.

platform/mediastream/MediaConstraints.h: Removed unneeded includes.

(WebCore::StringConstraint::appendExact): Removed an incorrect use of clear
here that would mess up cases where there is supposed to be more than one
exact value.

platform/mediastream/MediaStreamTrackPrivate.cpp: Remvoed unneeded includes.

(WebCore::MediaStreamTrackPrivate::clone): Removed code to copy m_constraints.
(WebCore::MediaStreamTrackPrivate::constraints): Deleted.

platform/mediastream/MediaStreamTrackPrivate.h: Removed the constraints

function member and the m_constraints data member.

Source/WebKit2:

WebProcess/MediaStream/UserMediaPermissionRequestManager.cpp:

Added include of MediaConstraintsImpl.h, now needed because we
removed some unneeded includes from the WebCore headers.

LayoutTests:

fast/mediastream/MediaDevices-getUserMedia-expected.txt: Expect the exception the

generated bindings code throws, rather than the different one the hand-written binding
was throwing before.

8:53 AM Changeset in webkit [209863] by keith_miller@apple.com

3 edits in trunk/JSTests

WebAssembly: test_BuilderJSON.js is broken
https://bugs.webkit.org/show_bug.cgi?id=165893

Reviewed by Michael Saboff.

wasm/Builder.js:

(const._isValidValue):

wasm/self-test/test_BuilderJSON.js:

7:46 AM Changeset in webkit [209862] by hyatt@apple.com

5 edits in trunk/Source

[CSS Parser] Enable CSS Deferred Parsing
https://bugs.webkit.org/show_bug.cgi?id=165869

Reviewed by Sam Weinig.

Source/WebCore:

Enable CSS deferred parsing once again. It's now behind a pref,
so it's easy to flip off and on.

To address the memory regression that caused the previous rollout,
the tokenizer is no longer retained. Instead the sheet text and escaped
strings are retained by CSSDeferredParser, and then DeferredStyleProperties
and DeferredStyleGroupRuleList make copies of the tokens from the original
tokenization process. As the rules get parsed, these tokens get thrown
away.

This means that instead of the entire set of tokens staying in memory
as long as even one unparsed rule remained, now only the tokens that
still need parsing will remain alive.

Unparsed rules will consume slightly more memory than parsed rules, but
the more unparsed rules you have, the bigger the performance win as
well, so this is a tradeoff. Given that the parsing speed is going up
by anywhere from 25-40% on cold loads of pages (where all stylesheets
have to parse), this seems worth it to me.

css/parser/CSSParserMode.h:
page/Settings.in:

Source/WebKit2:

Shared/WebPreferencesDefinitions.h:

5:47 AM Changeset in webkit [209861] by commit-queue@webkit.org

139 edits
4 copies
87 adds in trunk/LayoutTests

Sync web-platform-tests up to revision a4c2b37
https://bugs.webkit.org/show_bug.cgi?id=165041

LayoutTests/imported/w3c:

Patch by Youenn Fablet <youenn@apple.com> on 2016-12-15
Reviewed by Alex Christensen.

resources/ImportExpectations:
resources/TestRepositories:
resources/resource-files.json:
web-platform-tests/IndexedDB/historical-expected.txt: Added.
web-platform-tests/IndexedDB/historical.html: Added.
web-platform-tests/IndexedDB/interfaces-expected.txt:
web-platform-tests/IndexedDB/interfaces.html:
web-platform-tests/IndexedDB/interfaces.idl:
web-platform-tests/IndexedDB/interfaces.worker-expected.txt:
web-platform-tests/IndexedDB/interfaces.worker.js:

(async_test):
(request.onload): Deleted.

web-platform-tests/IndexedDB/name-scopes-expected.txt: Added.
web-platform-tests/IndexedDB/name-scopes.html: Added.
web-platform-tests/IndexedDB/support-promises.js:

(const.databaseName):
(const.requestWatcher):
(const.migrateDatabase):
(const.migrateNamedDatabase):
(const.createDatabase):
(const.createNamedDatabase):
(const.openDatabase):
(const.openNamedDatabase):
(const.createBooksStore):
(const.checkStoreIndexes):
(const.checkStoreGenerator):
(const.checkStoreContents):
(const.checkAuthorIndexContents):
(const.checkTitleIndexContents):

web-platform-tests/IndexedDB/w3c-import.log:
web-platform-tests/README.md:
web-platform-tests/XMLHttpRequest/event-readystatechange-loaded-expected.txt:
web-platform-tests/XMLHttpRequest/event-readystatechange-loaded.htm:
web-platform-tests/check_stability.py:

(TravisFold):
(TravisFold.init):
(TravisFold.enter):
(TravisFold.exit):
(markdown_adjust):
(table):
(write_inconsistent):
(write_results):
(main):

web-platform-tests/common/dummy.xhtml: Added.
web-platform-tests/common/dummy.xml: Added.
web-platform-tests/common/w3c-import.log:
web-platform-tests/config.default.json:
web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:
web-platform-tests/dom/events/ProgressEvent-expected.txt:
web-platform-tests/dom/events/ProgressEvent.html:
web-platform-tests/dom/nodes/DOMImplementation-createDocument-expected.txt:
web-platform-tests/dom/nodes/DOMImplementation-createDocument.html:
web-platform-tests/dom/nodes/Document-createElement-expected.txt:
web-platform-tests/dom/nodes/Document-createElement.html:
web-platform-tests/dom/nodes/Document-createElementNS-expected.txt:
web-platform-tests/dom/nodes/Document-createElementNS.html:
web-platform-tests/dom/nodes/Document-createElementNS.js:
web-platform-tests/dom/nodes/Document-createEvent-expected.txt:
web-platform-tests/dom/nodes/Document-createEvent.html:
web-platform-tests/dom/nodes/Document-createEvent.js:
web-platform-tests/dom/nodes/Element-closest-expected.txt:
web-platform-tests/dom/nodes/Element-closest.html:
web-platform-tests/domparsing/OWNERS:
web-platform-tests/domparsing/createContextualFragment-expected.txt:
web-platform-tests/domparsing/createContextualFragment.html:
web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear-sources.html:
web-platform-tests/encrypted-media/content/video_512x288_h264-360k_multikey_key1_dashinit.mp4: Added.
web-platform-tests/encrypted-media/drm-mp4-playback-temporary-encrypted-clear-sources.html:
web-platform-tests/encrypted-media/scripts/playback-persistent-license-events.js:

(runTest):

web-platform-tests/encrypted-media/scripts/playback-persistent-usage-record-events.js:

(runTest):

web-platform-tests/encrypted-media/scripts/playback-temporary-events.js:

(runTest):

web-platform-tests/encrypted-media/scripts/playback-temporary-multikey-sequential.js:

(runTest):

web-platform-tests/encrypted-media/scripts/unique-origin.js:

(runTest.):

web-platform-tests/fetch/api/basic/mode-same-origin-expected.txt:
web-platform-tests/fetch/api/basic/mode-same-origin-worker-expected.txt:
web-platform-tests/fetch/api/cors/cors-redirect-credentials-expected.txt:
web-platform-tests/fetch/api/cors/cors-redirect-credentials-worker-expected.txt:
web-platform-tests/fetch/api/headers/headers-idl.html:
web-platform-tests/fetch/api/headers/headers-normalize-expected.txt:
web-platform-tests/fetch/api/headers/headers-normalize.html:
web-platform-tests/fetch/api/redirect/redirect-count.js:

(redirectCount):

web-platform-tests/fetch/api/request/request-error-expected.txt:
web-platform-tests/fetch/api/request/request-error.html:
web-platform-tests/fetch/api/request/request-idl.html:
web-platform-tests/fetch/api/resources/redirect.py:

(main):

web-platform-tests/fetch/api/response/response-consume-expected.txt:
web-platform-tests/fetch/api/response/response-consume.html:
web-platform-tests/fetch/api/response/response-idl.html:
web-platform-tests/fonts/math/mathvariant-bold-fraktur.woff: Added.
web-platform-tests/fonts/math/mathvariant-bold-italic.woff: Added.
web-platform-tests/fonts/math/mathvariant-bold-sans-serif.woff: Added.
web-platform-tests/fonts/math/mathvariant-bold-script.woff: Added.
web-platform-tests/fonts/math/mathvariant-bold.woff: Added.
web-platform-tests/fonts/math/mathvariant-double-struck.woff: Added.
web-platform-tests/fonts/math/mathvariant-fraktur.woff: Added.
web-platform-tests/fonts/math/mathvariant-initial.woff: Added.
web-platform-tests/fonts/math/mathvariant-italic.woff: Added.
web-platform-tests/fonts/math/mathvariant-looped.woff: Added.
web-platform-tests/fonts/math/mathvariant-monospace.woff: Added.
web-platform-tests/fonts/math/mathvariant-sans-serif-bold-italic.woff: Added.
web-platform-tests/fonts/math/mathvariant-sans-serif-italic.woff: Added.
web-platform-tests/fonts/math/mathvariant-sans-serif.woff: Added.
web-platform-tests/fonts/math/mathvariant-script.woff: Added.
web-platform-tests/fonts/math/mathvariant-stretched.woff: Added.
web-platform-tests/fonts/math/mathvariant-tailed.woff: Added.
web-platform-tests/fonts/math/w3c-import.log:
web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/014.html:
web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/javascript-url-return-value-handling.html:
web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-function-src.html:
web-platform-tests/html/browsers/browsing-the-web/navigating-across-documents/source/navigate-child-function.html:
web-platform-tests/html/browsers/history/the-history-interface/history_go_to_uri-1.html: Added.
web-platform-tests/html/browsers/history/the-history-interface/history_go_to_uri-expected.txt: Added.
web-platform-tests/html/browsers/history/the-history-interface/history_go_to_uri.html: Added.
web-platform-tests/html/browsers/history/the-history-interface/w3c-import.log:
web-platform-tests/html/browsers/history/the-location-interface/location_reload-iframe.html:
web-platform-tests/html/browsers/history/the-location-interface/location_reload.html:
web-platform-tests/html/browsers/the-window-object/support/noopener-target.html: Added.
web-platform-tests/html/browsers/the-window-object/support/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/resetting-a-form/w3c-import.log.
web-platform-tests/html/browsers/the-window-object/w3c-import.log:
web-platform-tests/html/browsers/the-window-object/window-open-noopener-expected.txt: Added.
web-platform-tests/html/browsers/the-window-object/window-open-noopener.html: Added.
web-platform-tests/html/browsers/windows/nested-browsing-contexts/w3c-import.log:
web-platform-tests/html/browsers/windows/support-open-cross-origin.sub.html: Added.
web-platform-tests/html/browsers/windows/targeting-multiple-cross-origin-manual.sub.html: Added.
web-platform-tests/html/browsers/windows/w3c-import.log:
web-platform-tests/html/dom/interfaces.html:
web-platform-tests/html/dom/new-harness.js:

(ReflectionHarness.test):
(ReflectionHarness.run): Deleted.
(ReflectionHarness.testException): Deleted.

web-platform-tests/html/dom/original-harness.js:

(ReflectionHarness.test):
(ReflectionHarness.assertEquals):
(ReflectionHarness.assertThrows):
(ReflectionHarness.testWrapper): Deleted.
(ReflectionHarness.run): Deleted.
(ReflectionHarness.testException): Deleted.

web-platform-tests/html/dom/reflection.js:

(ReflectionTests.reflects):
(ReflectionTests.doReflects): Deleted.

web-platform-tests/html/semantics/document-metadata/the-link-element/all: Added.
web-platform-tests/html/semantics/document-metadata/the-link-element/all.headers: Added.
web-platform-tests/html/semantics/document-metadata/the-link-element/resources/empty-href.css: Added.

(body):

web-platform-tests/html/semantics/document-metadata/the-link-element/resources/w3c-import.log:
web-platform-tests/html/semantics/document-metadata/the-link-element/stylesheet-empty-href-expected.html: Added.
web-platform-tests/html/semantics/document-metadata/the-link-element/stylesheet-empty-href.html: Added.
web-platform-tests/html/semantics/document-metadata/the-link-element/stylesheet-media-expected.html: Added.
web-platform-tests/html/semantics/document-metadata/the-link-element/stylesheet-media.html: Added.
web-platform-tests/html/semantics/document-metadata/the-link-element/w3c-import.log:
web-platform-tests/html/semantics/embedded-content/the-embed-element/historical-expected.txt: Added.
web-platform-tests/html/semantics/embedded-content/the-embed-element/historical.html: Added.
web-platform-tests/html/semantics/embedded-content/the-embed-element/w3c-import.log:
web-platform-tests/html/semantics/embedded-content/the-object-element/historical-expected.txt: Added.
web-platform-tests/html/semantics/embedded-content/the-object-element/historical.html: Added.
web-platform-tests/html/semantics/embedded-content/the-object-element/w3c-import.log:
web-platform-tests/html/semantics/forms/resetting-a-form/reset-event-expected.txt: Added.
web-platform-tests/html/semantics/forms/resetting-a-form/reset-event.html: Added.
web-platform-tests/html/semantics/forms/resetting-a-form/reset-form-expected.txt:
web-platform-tests/html/semantics/forms/resetting-a-form/reset-form.html:
web-platform-tests/html/semantics/forms/resetting-a-form/w3c-import.log:
web-platform-tests/html/semantics/forms/the-fieldset-element/HTMLFieldSetElement-expected.txt:
web-platform-tests/html/semantics/forms/the-fieldset-element/HTMLFieldSetElement.html:
web-platform-tests/html/semantics/forms/the-form-element/form-action-url-expected.txt: Added.
web-platform-tests/html/semantics/forms/the-form-element/form-action-url.html: Added.
web-platform-tests/html/semantics/forms/the-form-element/resources/form-action-url-iframe.html: Added.
web-platform-tests/html/semantics/forms/the-form-element/resources/target/form-action-url-target.html: Added.
web-platform-tests/html/semantics/forms/the-form-element/resources/target/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/resetting-a-form/w3c-import.log.
web-platform-tests/html/semantics/forms/the-form-element/resources/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/semantics/forms/resetting-a-form/w3c-import.log.
web-platform-tests/html/semantics/forms/the-form-element/w3c-import.log:
web-platform-tests/html/semantics/forms/the-input-element/radio.html:
web-platform-tests/html/semantics/forms/the-select-element/common-HTMLOptionsCollection-add-expected.txt: Added.
web-platform-tests/html/semantics/forms/the-select-element/common-HTMLOptionsCollection-add.html: Added.
web-platform-tests/html/semantics/forms/the-select-element/common-HTMLOptionsCollection-expected.txt:
web-platform-tests/html/semantics/forms/the-select-element/common-HTMLOptionsCollection.html:
web-platform-tests/html/semantics/forms/the-select-element/selected-index-expected.txt: Added.
web-platform-tests/html/semantics/forms/the-select-element/selected-index.html: Added.
web-platform-tests/html/semantics/forms/the-select-element/w3c-import.log:
web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-001-expected.html:
web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-001.html:
web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-002-expected.html:
web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-002.html:
web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-display-list-item-expected.html: Added.
web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-display-list-item.html: Added.
web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-list-owner-mixed-expected.html: Added.
web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-list-owner-mixed.html: Added.
web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-list-owner-not-dir-expected.html: Added.
web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-list-owner-not-dir.html: Added.
web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-list-owner-ol-expected.html: Added.
web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-list-owner-ol.html: Added.
web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-list-owner-parent-expected.html: Added.
web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-list-owner-parent.html: Added.
web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-list-owner-ul-expected.html: Added.
web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-list-owner-ul.html: Added.
web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-not-being-rendered-expected.html: Added.
web-platform-tests/html/semantics/grouping-content/the-li-element/grouping-li-reftest-not-being-rendered.html: Added.
web-platform-tests/html/semantics/grouping-content/the-li-element/w3c-import.log:
web-platform-tests/html/semantics/grouping-content/the-ol-element/grouping-ol-rev-reftest-001-expected.html:
web-platform-tests/html/semantics/grouping-content/the-ol-element/grouping-ol-rev-reftest-001.html:
web-platform-tests/html/semantics/grouping-content/the-ol-element/grouping-ol-start-reftest-001-expected.html:
web-platform-tests/html/semantics/grouping-content/the-ol-element/grouping-ol-start-reftest-001.html:
web-platform-tests/html/semantics/grouping-content/the-ol-element/grouping-ol-start-reftest-002-expected.html:
web-platform-tests/html/semantics/grouping-content/the-ol-element/grouping-ol-start-reftest-002.html:
web-platform-tests/html/semantics/grouping-content/the-ol-element/grouping-ol-type-reftest-001-expected.html:
web-platform-tests/html/semantics/grouping-content/the-ol-element/grouping-ol-type-reftest-001.html:
web-platform-tests/html/semantics/grouping-content/the-ol-element/grouping-ol-type-reftest-002-expected.html:
web-platform-tests/html/semantics/grouping-content/the-ol-element/grouping-ol-type-reftest-002.html:
web-platform-tests/html/semantics/grouping-content/the-ol-element/grouping-ol-type-reftest-003-expected.html:
web-platform-tests/html/semantics/grouping-content/the-ol-element/grouping-ol-type-reftest-003.html:
web-platform-tests/html/semantics/grouping-content/the-ol-element/reversed-1e-expected.html: Added.
web-platform-tests/html/semantics/grouping-content/the-ol-element/reversed-1e.html: Added.
web-platform-tests/html/semantics/grouping-content/the-ol-element/w3c-import.log:
web-platform-tests/html/semantics/scripting-1/the-template-element/template-element/node-document-changes.html:
web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt: Added.
web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https.html: Added.
web-platform-tests/html/webappapis/scripting/events/uncompiled_event_handler_with_scripting_disabled-expected.txt: Added.
web-platform-tests/html/webappapis/scripting/events/uncompiled_event_handler_with_scripting_disabled.html: Added.
web-platform-tests/html/webappapis/scripting/events/w3c-import.log:
web-platform-tests/lint.whitelist:
web-platform-tests/media-source/OWNERS:
web-platform-tests/serve.py:
web-platform-tests/shadow-dom/OWNERS:
web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.js:

(promise_test):

web-platform-tests/url/a-element-expected.txt:
web-platform-tests/url/a-element-origin-expected.txt: Added.
web-platform-tests/url/a-element-origin-xhtml-expected.txt: Added.
web-platform-tests/url/a-element-origin-xhtml.xhtml: Added.
web-platform-tests/url/a-element-origin.html: Added.
web-platform-tests/url/a-element-origin.js: Added.

(setup.async_test.string_appeared_here.setup.step):
(setBase):
(bURL):
(runURLTests):

web-platform-tests/url/a-element-xhtml-expected.txt:
web-platform-tests/url/historical-expected.txt:
web-platform-tests/url/historical.html:
web-platform-tests/url/historical.worker-expected.txt:
web-platform-tests/url/historical.worker.js:

(test):

web-platform-tests/url/interfaces-expected.txt:
web-platform-tests/url/interfaces.html:
web-platform-tests/url/setters_tests.json:
web-platform-tests/url/url-constructor-expected.txt:
web-platform-tests/url/url-origin-expected.txt: Added.
web-platform-tests/url/url-origin.html: Added.
web-platform-tests/url/urlsearchparams-foreach-expected.txt: Added.
web-platform-tests/url/urlsearchparams-foreach.html: Added.
web-platform-tests/url/urltestdata.json:
web-platform-tests/url/w3c-import.log:
web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt:
web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor.html:
web-platform-tests/webrtc/simplecall-expected.txt:
web-platform-tests/webrtc/simplecall.html:

LayoutTests:

Patch by Youenn Fablet <youennf@gmail.com> on 2016-12-15
Reviewed by Alex Christensen.

platform/ios-simulator-wk2/imported/w3c/web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt: Added.
platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/dom/reflection-embedded-expected.txt:
platform/ios-simulator-wk2/imported/w3c/web-platform-tests/html/dom/reflection-forms-expected.txt: Added.
tests-options.json:

5:15 AM Changeset in webkit [209860] by commit-queue@webkit.org

9 edits
3 copies in trunk

[OWR] Unskip fast/mediastream/MediaStream-video-element-track-stop.html
https://bugs.webkit.org/show_bug.cgi?id=165316

Patch by Alejandro G. Castro <alex@igalia.com> on 2016-12-15
Reviewed by Philippe Normand.

Source/WebCore:

Fixed the ended support of the video element in the OWR player and
fixed the videoTracks support. Now the OW player properly adds and
removes the audio and video tracks. Added the getSettings support
to the mediastream interface. Solved also the size handling in
some of the enable/muted situations.

Unskipping fast/mediastream/MediaStream-video-element-track-stop.html.

platform/GStreamer.cmake: Added the new

RealtimeMediaSourceOwr.cpp with the new code handling the
settings.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.cpp:

(WebCore::MediaPlayerPrivateGStreamerOwr::~MediaPlayerPrivateGStreamerOwr):
Release the new video and audio maps that creates a relationship
of the mediastream tracks with the mediatracks of the video element.
(WebCore::MediaPlayerPrivateGStreamerOwr::play): Set ended to
false when we start playing.
(WebCore::MediaPlayerPrivateGStreamerOwr::load): Create the media
tracks to the player so that the videoTracks API returns it, and
add an entry in the map to be able to restore it using the
mediastream track.
(WebCore::MediaPlayerPrivateGStreamerOwr::disableMediaTracks):
Move some part of the stop function to this one in order to use it
in pause method and avoid changing the video selection in that
case.
(WebCore::MediaPlayerPrivateGStreamerOwr::stop): Now we call the
function disableMediaTracks and we also change teh selected
videoTrack.
(WebCore::MediaPlayerPrivateGStreamerOwr::trackEnded): For
videoTrack reset the size and the selected element. In case there
is no media playing we Make sure we set the ended variable to true
and call the timeChange to modify the state of the player.
(WebCore::MediaPlayerPrivateGStreamerOwr::trackEnabledChanged):
Handle properly the situation when the user changed the enabled
value, we disable the media.
(WebCore::MediaPlayerPrivateGStreamerOwr::setSize): Modify the
size of the source.
(WebCore::MediaPlayerPrivateGStreamerOwr::naturalSize): Overrided
to make sure we return a size even when the sample is not ready
for gst.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerOwr.h:

Added the ended attribute and the maps.

platform/mediastream/openwebrtc/MediaEndpointOwr.cpp:

(WebCore::MediaEndpointOwr::createMutedRemoteSource): Use the new
realtime video and audio sources classes, this new classes
implement the settings of each type of media element.

platform/mediastream/openwebrtc/RealtimeMediaSourceCenterOwr.cpp:

(WebCore::RealtimeMediaSourceCenterOwr::mediaSourcesAvailable):
Use the new audio and video source classes instead of the general
one in order to handle the settings properly.

platform/mediastream/openwebrtc/RealtimeMediaSourceOwr.cpp: Added

(WebCore::RealtimeMediaSourceOwr::settings): Initialize using the
subclass and return the new currentSettings attribute.
(WebCore::RealtimeMediaSourceOwr::supportedConstraints): Call the
subclass initialization of the supportedSettings.

platform/mediastream/openwebrtc/RealtimeMediaSourceOwr.h:

(WebCore::RealtimeMediaSourceOwr::initializeSettings): Added to
initialize the settings before returning the value. Implemented in
the subclass.
(WebCore::RealtimeMediaSourceOwr::initializeSupportedConstraints):
Added to initialize the supported settings of the
media. Implemented in the subclass.
(WebCore::RealtimeMediaSourceOwr::settings): Moved to the cpp
file, implemented using the initialize functions of the subclass

platform/mediastream/openwebrtc/RealtimeVideoSourceOwr.h: Added

this new class to handle the settings of the video elements. The
class initializes the settings and the supportedSettings.

platform/mediastream/openwebrtc/RealtimeAudioSourceOwr.h: Added

this new class to handle the settings of the audio elements. The
class initializes the settings and the supportedSettings.

LayoutTests:

platform/gtk/TestExpectations: Unskipped the test and moved the

stop one, now it does not timeout because we correctly handle the
ended value but still fails, we need more features in the mock
classes for owr.

5:05 AM Changeset in webkit [209859] by Claudio Saavedra

2 edits in trunk/Tools

[GTK] Ensure gst* docs are not built with update-webkitgtk-libs
https://bugs.webkit.org/show_bug.cgi?id=165855

Reviewed by Philippe Normand.

GStreamer's autogen.sh enables gtk-doc always so we end up building
docs even if we disable them. Use the configure script instead, since
we build from packages and these include it already.

gtk/jhbuild.modules: Use shipped configure instead of autogen.sh for

upstream gstreamer packages.

2:28 AM Changeset in webkit [209858] by Yusuke Suzuki

2 edits in trunk/Source/WTF

[JSC] Optimize Kraken stringify
https://bugs.webkit.org/show_bug.cgi?id=165857

Reviewed by Darin Adler.

Kraken json-stringify-tinderbox performance heavily relies on StringBuilder::appendQuotedJSONString.
According to the result produced by Linux perf, it occupies 28% of execution time.

We tighten the hottest loop in the above function. We create the super fast path for non escaping case.
And add " and \ cases (since including " in the string is common). Then we fallback to the slow case.

It improves the performance 5.5% in Kraken json-stringify-tinderbox in MBP.

Performance result in my MBP (dandelion).

Collected 100 samples per benchmark/VM, with 100 VM invocations per benchmark. Emitted a call to gc()
between sample measurements. Used 1 benchmark iteration per VM invocation for warm-up. Used the
jsc-specific preciseTime() function to get microsecond-level timing. Reporting benchmark execution times
with 95% confidence intervals in milliseconds.

baseline patched

json-stringify-tinderbox 29.243+-0.241 ^{27.701+-0.235} definitely 1.0557x faster

<arithmetic> 29.243+-0.241 ^{27.701+-0.235} definitely 1.0557x faster

Performance result in my Linux laptop (hanayamata).

Collected 100 samples per benchmark/VM, with 100 VM invocations per benchmark. Emitted a call to gc()
between sample measurements. Used 1 benchmark iteration per VM invocation for warm-up. Used the
jsc-specific preciseTime() function to get microsecond-level timing. Reporting benchmark execution times
with 95% confidence intervals in milliseconds.

baseline patched

json-stringify-tinderbox 26.711+-0.475 ^{25.255+-0.034} definitely 1.0577x faster

<arithmetic> 26.711+-0.475 ^{25.255+-0.034} definitely 1.0577x faster

wtf/text/StringBuilder.cpp:

(WTF::appendQuotedJSONStringInternalSlow):
(WTF::appendQuotedJSONStringInternal):

12:19 AM Changeset in webkit [209857] by achristensen@apple.com

6 edits in trunk

REGRESSION (r208902) Null pointer dereference in wkIsPublicSuffix
https://bugs.webkit.org/show_bug.cgi?id=165885
<rdar://problem/29476917>

Reviewed by Darin Adler.

Source/WebCore:

wkIsPublicSuffix crashes if you give it a nil NSString*.
This was possible before IDN2008 adoption, but it's more common now
because domains like "r4---asdf.example.com" fail in uidna_nameToASCII but not in uidna_IDNToASCII.
decodeHostName can return a nil NSString. We can't use it unchecked, so instead we use an algorithm that allows
for decoding failures while still finding top privately controlled domains correctly.

Tested by new API tests which crash before this change and verify the behavior matches behavior before r208902.

platform/mac/PublicSuffixMac.mm:

(WebCore::isPublicSuffix):
(WebCore::topPrivatelyControlledDomain):

Tools:

TestWebKitAPI/Tests/WebCore/URLParser.cpp:

(TestWebKitAPI::utf16String): Deleted.

TestWebKitAPI/Tests/mac/PublicSuffix.mm:

(TestWebKitAPI::TEST_F):

TestWebKitAPI/WTFStringUtilities.h:

(utf16String):
Moved from URLParser to share with other tests.

12:17 AM Changeset in webkit [209856] by achristensen@apple.com

6 edits in trunk/Source

Fix Windows WebGL build after r209832

CMakeLists.txt:

Source/ThirdParty/ANGLE:

include/EGL/egl.h:
include/GLES2/gl2.h:

Dec 14, 2016:

9:15 PM Changeset in webkit [209855] by rniwa@webkit.org

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Jumping to the definition of a custom elements is broken
https://bugs.webkit.org/show_bug.cgi?id=165890

Reviewed by Joseph Pecoraro.

Fix the regression from https://trac.webkit.org/changeset/208304.

UserInterface/Views/DOMTreeElement.js:

(WebInspector.DOMTreeElement.prototype._showCustomElementDefinition): Use the main target
since a custom element definition can never come from a worker.

9:10 PM Changeset in webkit [209854] by Hunseop Jeong

2 edits in trunk/Source/WebCore

Unreviewed build fix after r209832

platform/graphics/PlatformDisplay.cpp:

(WebCore::PlatformDisplay::sharedDisplay): Added the guard for the clang

8:45 PM Changeset in webkit [209853] by keith_miller@apple.com

2 edits in trunk/JSTests

Unreviewed, fix test.

wasm/function-tests/i32-const.js:

8:36 PM Changeset in webkit [209852] by keith_miller@apple.com

8 edits
3 adds in trunk

Wasm should decode constants correctly
https://bugs.webkit.org/show_bug.cgi?id=165886

Reviewed by Saam Barati.

JSTests:

wasm/Builder.js:

(const._isValidValue):

wasm/Builder_WebAssemblyBinary.js:

(const.putOp):

wasm/LowLevelBinary.js:

(export.default.LowLevelBinary.prototype.float):
(export.default.LowLevelBinary.prototype.double):

wasm/function-tests/f32-const.js: Added.
wasm/function-tests/f64-const.js: Added.
wasm/function-tests/i32-const.js: Added.
wasm/wasm.json:

Source/JavaScriptCore:

This patch fixes how we decode the constant part of i32, i64, f32,
and f64.const opcodes.

wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser<Context>::parseExpression):

wasm/wasm.json:

7:48 PM Changeset in webkit [209851] by akling@apple.com

2 edits in trunk/Source/WebKit2

Only send Messages::WebPageProxy::DidSaveToPageCache once when entering page cache.
<https://webkit.org/b/165887>

Reviewed by Brady Eidson.

We were sending one of these IPC messages per frame when a page enters the page cache,
and we really only need one, so only do it for the main frame.

(This message is used to adopt the page cache on the UI process side, in case another
web process currently owns the cache. That happens in WebProcessPool::processDidCachePage().)

WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::didSaveToPageCache):

7:30 PM Changeset in webkit [209850] by sbarati@apple.com

12 edits in trunk

WebAssembly: Add various low hanging fruit that will allow us to run the LLVM torture tests in Wasm
https://bugs.webkit.org/show_bug.cgi?id=165883

Reviewed by Keith Miller.

JSTests:

wasm/Builder.js:

(export.default.Builder.prototype._registerSectionBuilders.switch.case.string_appeared_here.this.section):

wasm/Builder_WebAssemblyBinary.js:

(const.emitters.Export):

wasm/js-api/table.js:

(assertBadBinary):
(assertBadTable):
(assert.truthy):

wasm/js-api/test_memory.js:

(binaryShouldNotParse):
(test):
(test.testMemImportError):
(assert.truthy):
(assert): Deleted.

Source/JavaScriptCore:

This patch implements some low hanging fruit:

Exporting Table
Exporting Memory
Load16 with zero extension to both 32 and 64 bit values.
Fixes Unreachable to emit code that will prevent B3 from having a validation error.

wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::addUnreachable):
(JSC::Wasm::sizeOfLoadOp):
(JSC::Wasm::B3IRGenerator::emitLoadOp):

wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser<Context>::parseExpression):

wasm/WasmModuleParser.cpp:

(JSC::Wasm::ModuleParser::parseExport):

wasm/WasmValidate.cpp:

(JSC::Wasm::Validate::addUnreachable):

wasm/js/WebAssemblyInstanceConstructor.cpp:

(JSC::constructJSWebAssemblyInstance):

wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::finishCreation):
(JSC::WebAssemblyModuleRecord::link):

6:31 PM Changeset in webkit [209849] by Yusuke Suzuki

4 edits in trunk

[GTK] Support latest SubtleCrypto HMAC APIs
https://bugs.webkit.org/show_bug.cgi?id=165863

Reviewed by Sam Weinig.

Source/WebCore:

SubtleCrypto spec is updated, and new delegate implementations are required to support these interfaces.
This patch implements platformSign and platformVerify with WorkQueues for gcrypt backend.

crypto/gcrypt/CryptoAlgorithmHMACGCrypt.cpp:

(WebCore::calculateSignature):
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):

LayoutTests:

Enable HMAC tests.

platform/gtk/TestExpectations:

6:23 PM Changeset in webkit [209848] by Yusuke Suzuki

3 edits in trunk/Source/JavaScriptCore

Update ModuleLoader code by using the latest builtin primitives
https://bugs.webkit.org/show_bug.cgi?id=165851

Reviewed by Sam Weinig.

Update the module loader code,

Use @globalPrivate for the utilities, instead of setting them as the member of ModuleLoader.
Use @putByValDirect instead of @push. @push is user-observable since it uses Set() operation and it can be observed by defining indexed setters in Array.prototype.

builtins/ModuleLoaderPrototype.js:

(ensureRegistered):
(fulfillFetch):
(commitInstantiated):
(requestFetch):
(requestSatisfy):
(setStateToMax): Deleted.
(newRegistryEntry): Deleted.

runtime/ModuleLoaderPrototype.cpp:

5:41 PM Changeset in webkit [209847] by msaboff@apple.com

3 edits in trunk/Source/JavaScriptCore

The stress GC bot crashes in JavaScriptCore beneath ShadowChicken::update and Inspector::jsToInspectorValue
https://bugs.webkit.org/show_bug.cgi?id=165871

Reviewed by Mark Lam.

This fixes two issues with the VM watch dog timer firing in a worker.

The first issue has to do with bytecode ordering. Prior to this change, the first few opcodes
generated when the watch dog is enabled are:

op_enter
op_watchdog
op_get_scope

When the watchdog fires, the function will get an exception at op_watchdog. In processing that exception,
we'll try to update the ShadowChicken shadow stack. That update assumes that if there is a scope
VirtualRegister allocated, then the slot contains a valid JSScope. With the current bytecode ordering,
this is not true at op_watchdog as op_enter will put JSUndefined in the scope slot. It isn't until the
op_get_scope gets processed that we'll have a valid scope in the slot. The fix for this issue is to
ensure that op_get_scope happens before the op_watchdog.

The second issue is that ScriptFunctionCall::call() will not tell its caller that a terminated
execution exception happened. Instead call() returns an empty JSValue. InjectedScript::wrapCallFrames()
wasn't checking for an empty JSValue, but was passing it to another function. Added a short circuit
return when call returns an empty JSValue.

Added <https://bugs.webkit.org/show_bug.cgi?id=165875> to fix other callers of ScriptFunctionCall::call()
to check for an empty JSValue return value.
Also tracked with <rdar://problem/29671015>.

bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitEnter):

inspector/InjectedScript.cpp:

(Inspector::InjectedScript::wrapCallFrames):

5:25 PM Changeset in webkit [209846] by fpizlo@apple.com

9 edits
1 add in trunk

DirectTailCall implementation needs to tell the shuffler what to put into the ArgumentCount explicitly
https://bugs.webkit.org/show_bug.cgi?id=165882

Reviewed by Mark Lam.
JSTests:

stress/direct-tail-call-arity-mismatch-count-args.js: Added.

(foo):
(bar):

Source/JavaScriptCore:

The CallFrameShuffler was assuming that the ArgumentCount that it should store into the
callee frame is simply the size of the args vector.

That's not true for DirectTailCall, which will pad the args vector with undefined if we
are optimizing an arity mismatch. We need to pass the ArgumentCount explicitly in this
case.

dfg/DFGSpeculativeJIT32_64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::emitCall):

ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileDirectCallOrConstruct):
(JSC::FTL::DFG::LowerDFGToB3::compileTailCall):

jit/CallFrameShuffleData.h:
jit/CallFrameShuffler.cpp:

(JSC::CallFrameShuffler::CallFrameShuffler):
(JSC::CallFrameShuffler::prepareAny):

jit/CallFrameShuffler.h:

(JSC::CallFrameShuffler::snapshot):

jit/JITCall.cpp:

(JSC::JIT::compileOpCall):

5:06 PM Changeset in webkit [209845] by Simon Fraser

13 edits in trunk

Fix cause of viewport-related flakiness in iOS tests
https://bugs.webkit.org/show_bug.cgi?id=165878

Reviewed by Tim Horton.

Source/WebKit2:

When TestController::platformConfigureViewForTest() changes the view size for a flexible
viewport test, the page would not have updated with the new scale by the time the load event
fired, causing flakiness depending on test order.

This was caused by code added in r170325 that delayed visible content rect updates until
after the UI process has received the transaction after didCommitLoad. So fix by overriding
this mechanism if the view has been resized.

Shared/VisibleContentRectUpdateInfo.cpp:

(WebKit::VisibleContentRectUpdateInfo::encode):
(WebKit::VisibleContentRectUpdateInfo::decode):
(WebKit::operator<<):

Shared/VisibleContentRectUpdateInfo.h:

(WebKit::VisibleContentRectUpdateInfo::VisibleContentRectUpdateInfo):
(WebKit::VisibleContentRectUpdateInfo::isFirstUpdateForNewViewSize):
(WebKit::operator==):

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _frameOrBoundsChanged]):
(-[WKWebView _updateContentRectsWithState:]):

UIProcess/DrawingAreaProxy.cpp:

(WebKit::DrawingAreaProxy::setSize):

UIProcess/DrawingAreaProxy.h:
UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::WebPageProxy):

UIProcess/WebPageProxy.h:
UIProcess/ios/WKContentView.h:
UIProcess/ios/WKContentView.mm:

WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateVisibleContentRects):

LayoutTests:

Try un-flaking some viewport tests.

platform/ios-simulator-wk2/TestExpectations:

4:47 PM Changeset in webkit [209844] by Chris Dumez

2 edits in trunk/Source/WebCore

Unreviewed, rolling out r209415.

This workaround is no longer needed now that
<rdar://problem/29518605> has been fixed

Reverted changeset:

"Add HTML interactive form validation blacklist for some
WebKit-specific sites"
https://bugs.webkit.org/show_bug.cgi?id=165470
http://trac.webkit.org/changeset/209415

4:35 PM Changeset in webkit [209843] by jonlee@apple.com

1 edit
50 copies
1 delete in trunk/LayoutTests

Full Pass CSS Variables Test Suite
https://bugs.webkit.org/show_bug.cgi?id=150183

Reviewed by Simon Fraser.

The new CSS parser progresses these tests. Move them out of the failures/ sub-directory.
One of the tests needs the Ahem font, which was not available when put in the sub-directory.

fast/css/variables/test-suite/024-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/024-expected.html.
fast/css/variables/test-suite/024.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/024.html.
fast/css/variables/test-suite/025-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/025-expected.html.
fast/css/variables/test-suite/025.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/025.html.
fast/css/variables/test-suite/026-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/026-expected.html.
fast/css/variables/test-suite/026.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/026.html.
fast/css/variables/test-suite/028-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/028-expected.html.
fast/css/variables/test-suite/028.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/028.html.
fast/css/variables/test-suite/030-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/030-expected.html.
fast/css/variables/test-suite/030.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/030.html.
fast/css/variables/test-suite/054-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/054-expected.html.
fast/css/variables/test-suite/054.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/054.html.
fast/css/variables/test-suite/055-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/055-expected.html.
fast/css/variables/test-suite/055.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/055.html.
fast/css/variables/test-suite/056-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/056-expected.html.
fast/css/variables/test-suite/056.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/056.html.
fast/css/variables/test-suite/058-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/058-expected.html.
fast/css/variables/test-suite/058.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/058.html.
fast/css/variables/test-suite/071-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/071-expected.html.
fast/css/variables/test-suite/071.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/071.html.
fast/css/variables/test-suite/081-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/081-expected.html.
fast/css/variables/test-suite/081.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/081.html.
fast/css/variables/test-suite/082-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/082-expected.html.
fast/css/variables/test-suite/082.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/082.html.
fast/css/variables/test-suite/085-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/085-expected.html.
fast/css/variables/test-suite/085.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/085.html.
fast/css/variables/test-suite/086-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/086-expected.html.
fast/css/variables/test-suite/086.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/086.html.
fast/css/variables/test-suite/087-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/087-expected.html.
fast/css/variables/test-suite/087.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/087.html.
fast/css/variables/test-suite/091-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/091-expected.html.
fast/css/variables/test-suite/091.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/091.html.
fast/css/variables/test-suite/103-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/103-expected.html.
fast/css/variables/test-suite/103.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/103.html.
fast/css/variables/test-suite/111-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/111-expected.html.
fast/css/variables/test-suite/111.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/111.html.
fast/css/variables/test-suite/115-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/115-expected.html.
fast/css/variables/test-suite/115.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/115.html.
fast/css/variables/test-suite/126-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/126-expected.html.
fast/css/variables/test-suite/126.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/126.html.
fast/css/variables/test-suite/152-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/152-expected.html.
fast/css/variables/test-suite/152.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/152.html.
fast/css/variables/test-suite/159-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/159-expected.html.
fast/css/variables/test-suite/159.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/159.html.
fast/css/variables/test-suite/161-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/161-expected.html.
fast/css/variables/test-suite/161.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/161.html.
fast/css/variables/test-suite/163-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/163-expected.html.
fast/css/variables/test-suite/163.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/163.html.
fast/css/variables/test-suite/169-expected.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/169-expected.html.
fast/css/variables/test-suite/169.html: Renamed from LayoutTests/fast/css/variables/test-suite/failures/169.html.

4:12 PM Changeset in webkit [209842] by dino@apple.com

6 edits in trunk

Update prefers-reduced-motion syntax
https://bugs.webkit.org/show_bug.cgi?id=165880
<rdar://problems/29671807>

Reviewed by Sam Weinig.

Source/WebCore:

After discussion in:
https://github.com/w3c/csswg-drafts/issues/442
... the syntax of prefers-reduced-motion was changed
to accept "reduce" or "no-preference".

Updated the tests in fast/media.

css/CSSValueKeywords.in: Add no-preference keyword.
css/MediaQueryEvaluator.cpp:

(WebCore::prefersReducedMotionEvaluate):

LayoutTests:

fast/media/mq-prefers-reduced-motion-forced-value.html:
fast/media/mq-prefers-reduced-motion.html:

4:04 PM Changeset in webkit [209841] by weinig@apple.com

8 edits in trunk

Source/WebCore:
REGRESSION (204679): Google notifications never load (expecting DOMStringList rather than JS array for Location.ancestorOrigins)
<rdar://problem/29573563>
https://bugs.webkit.org/show_bug.cgi?id=165872

Reviewed by Chris Dumez.

Revert the Location.ancestorOrigins part of r204679 because google.com is relying on
it returning a DOMStringList (or at least something with a .item() function), rather
than a frozen javascript array.

Spec changes are tracked with https://github.com/whatwg/html/issues/2179.

page/Location.cpp:

(WebCore::Location::ancestorOrigins):

page/Location.h:
page/Location.idl:

Change Location.ancestorOrigins back to returning a DOMStringList.

Source/WebKit2:
[WebIDL] Add support for converting dictionaries to JS
https://bugs.webkit.org/show_bug.cgi?id=165367

Reviewed by Chris Dumez.

CMakeLists.txt:

Add missing directories to look in for headers.

LayoutTests:
REGRESSION (204679): Google notifications never load (expecting DOMStringList rather than JS array for Location.ancestorOrigins)
<rdar://problem/29573563>
https://bugs.webkit.org/show_bug.cgi?id=165872

Reviewed by Chris Dumez.

fast/dom/Window/Location/ancestor-origins-expected.txt:
fast/dom/Window/Location/ancestor-origins.html:

Change back to test that Location.ancestorOrigins returns a DOMStringList.

4:00 PM Changeset in webkit [209840] by andersca@apple.com

9 edits in trunk/Source/WebKit2

Add WKContextRefreshPlugIns
https://bugs.webkit.org/show_bug.cgi?id=165879
rdar://problem/29602414

Reviewed by Tim Horton.

UIProcess/API/C/WKContext.cpp:

(WKContextRefreshPlugIns):

UIProcess/API/C/WKContext.h:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::refreshPlugins):

UIProcess/WebProcessPool.h:
WebProcess/Plugins/WebPluginInfoProvider.h:
WebProcess/WebProcess.cpp:

(WebKit::WebProcess::refreshPlugins):

WebProcess/WebProcess.h:
WebProcess/WebProcess.messages.in:

3:42 PM Changeset in webkit [209839] by timothy_horton@apple.com

5 edits in trunk/Source/WebKit2

API Test Fullscreen.TopContentInset is asserting on Yosemite
https://bugs.webkit.org/show_bug.cgi?id=165877

Reviewed by Brady Eidson.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setTopContentInset):

WebProcess/WebPage/WebPage.cpp:
WebProcess/WebPage/WebPage.h:
WebProcess/WebPage/WebPage.messages.in:

We don't use fences on Yosemite, but this codepath still tried to.
Instead of guarding with PLATFORM(COCOA), make use of the more accurate
HAVE(COREANIMATION_FENCES) guard.

3:15 PM Changeset in webkit [209838] by hyatt@apple.com

13 edits in trunk/Source/WebCore

[CSS Parser] Rename StyleKeyframe to StyleRuleKeyframe
https://bugs.webkit.org/show_bug.cgi?id=165876

Reviewed by Simon Fraser.

css/CSSKeyframeRule.cpp:

(WebCore::StyleRuleKeyframe::StyleRuleKeyframe):
(WebCore::StyleRuleKeyframe::~StyleRuleKeyframe):
(WebCore::StyleRuleKeyframe::mutableProperties):
(WebCore::StyleRuleKeyframe::keyText):
(WebCore::StyleRuleKeyframe::setKeyText):
(WebCore::StyleRuleKeyframe::cssText):
(WebCore::CSSKeyframeRule::CSSKeyframeRule):
(WebCore::StyleKeyframe::StyleKeyframe): Deleted.
(WebCore::StyleKeyframe::~StyleKeyframe): Deleted.
(WebCore::StyleKeyframe::mutableProperties): Deleted.
(WebCore::StyleKeyframe::keyText): Deleted.
(WebCore::StyleKeyframe::setKeyText): Deleted.
(WebCore::StyleKeyframe::cssText): Deleted.

css/CSSKeyframeRule.h:
css/CSSKeyframesRule.cpp:

(WebCore::StyleRuleKeyframes::keyframes):
(WebCore::StyleRuleKeyframes::parserAppendKeyframe):
(WebCore::StyleRuleKeyframes::wrapperAppendKeyframe):
(WebCore::CSSKeyframesRule::appendRule):
(WebCore::CSSKeyframesRule::item):

css/CSSKeyframesRule.h:
css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::keyframeStylesForAnimation):

css/StyleResolver.h:
css/StyleRule.cpp:

(WebCore::StyleRuleBase::destroy):

css/StyleRule.h:
css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseKeyframeRule):

css/parser/CSSParser.h:
css/parser/CSSParserImpl.cpp:

(WebCore::CSSParserImpl::parseDeferredKeyframeList):
(WebCore::CSSParserImpl::consumeKeyframesRule):
(WebCore::CSSParserImpl::consumeKeyframeStyleRule):

css/parser/CSSParserImpl.h:

3:01 PM Changeset in webkit [209837] by Ryan Haddad

2 edits in trunk/LayoutTests

Marking streams/pipe-to.html as flaky on macOS debug.
https://bugs.webkit.org/show_bug.cgi?id=165874

Unreviewed test gardening.

platform/mac/TestExpectations:

2:48 PM Changeset in webkit [209836] by Ryan Haddad

2 edits in trunk/LayoutTests

Removing Release annotation from three tests that are also flaky on Debug.
https://bugs.webkit.org/show_bug.cgi?id=163361

Unreviewed test gardening.

platform/mac-wk1/TestExpectations:

2:34 PM Changeset in webkit [209835] by hyatt@apple.com

5 edits in trunk/Source/WebCore

[CSS Parser] Make deferred parsing retain the sheet text. Fix invalidation to avoid deferred parsing.
https://bugs.webkit.org/show_bug.cgi?id=165868

Reviewed by Simon Fraser.

With this new model of token copying, the sheet text needs to be retained. The tokenizer did this,
but we're no longer keeping it around.

StyleInvalidation is also aggressively crawling media rules, even unsupported ones, so fix it
to avoid deferred parsing.

css/StyleInvalidationAnalysis.cpp:

(WebCore::shouldDirtyAllStyle):

css/parser/CSSDeferredParser.cpp:

(WebCore::CSSDeferredParser::CSSDeferredParser):

css/parser/CSSDeferredParser.h:

(WebCore::CSSDeferredParser::create):

css/parser/CSSParserImpl.cpp:

(WebCore::CSSParserImpl::CSSParserImpl):

2:04 PM Changeset in webkit [209834] by Matt Baker

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Zooming in on the Timeline should always zoom right where the cursor is
https://bugs.webkit.org/show_bug.cgi?id=151118
<rdar://problem/23487912>

Reviewed by Timothy Hatcher.

Use correct left edge for timeline overview graph elements.

UserInterface/Views/TimelineOverview.js:

(WebInspector.TimelineOverview.prototype._handleWheelEvent):
(WebInspector.TimelineOverview._handleGestureStart):
(WebInspector.TimelineOverview.prototype._handleGestureChange):

1:57 PM Changeset in webkit [209833] by rniwa@webkit.org

8 edits
2 adds in trunk

iOS: An element with tabindex is not focusable unless there is no mouse event handler
https://bugs.webkit.org/show_bug.cgi?id=165843

Reviewed by Antti Koivisto.

Source/WebCore:

The bug was caused by ancestorRespondingToClickEvents not checking the precense of tabindex attribute.
Check that condition along with event listeners.

Test: fast/events/focusing-element-with-tabindex-by-tap-or-click.html

page/ios/FrameIOS.mm:

(WebCore::ancestorRespondingToClickEvents):

Tools:

Add testRunner.isWebKit2 which is always true in WebKitTestRunner.
Without this, it's really hard to reliably differentiate DumpRenderTree and WebKitTestRunner,
and DumpRenderTree's runUIScript would hit an assertion :(

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/TestRunner.h:

(WTR::TestRunner::isWebKit2):

LayoutTests:

Added a regression test for focusing an element with just tabindex using UIHelper.

Also fixed UIHelper to work in iOS DumpRenderTree which was hitting an assertion
by explicitly checking testRunner.isWebKit2. Prior to fixing this, it was hitting
an assertion in RunLoop::main() which was asserting that there is a runloop,
which doesn't exist in DumpRenderTree.

fast/events/focusing-element-with-tabindex-by-tap-or-click-expected.txt: Added.
fast/events/focusing-element-with-tabindex-by-tap-or-click.html: Added.
platform/ios-simulator-wk2/TestExpectations:
resources/ui-helper.js:

(window.UIHelper.isWebKit2):
(window.UIHelper.wait): Added the support for js-test.js / js-test-pre.js style tests.

1:45 PM Changeset in webkit [209832] by achristensen@apple.com

22 edits
14 adds in trunk/Source

Progress towards using ANGLE to do WebGL rendering
https://bugs.webkit.org/show_bug.cgi?id=165864

Reviewed by Dean Jackson.

Source/ThirdParty/ANGLE:

ANGLE.xcodeproj/project.pbxproj:

Compile more files, and add some more "public" headers.
ANGLE is not a public framework, so these headers just go in
WebKitBuild/Release/usr/local/include/ANGLE to be included when compiling WebCore.

ANGLE/egl.h: Added.
ANGLE/eglext.h: Added.
ANGLE/eglplatform.h: Added.
ANGLE/entry_points_gles_2_0.h: Added.
ANGLE/entry_points_gles_2_0_ext.h: Added.
ANGLE/entry_points_gles_3_0.h: Added.
ANGLE/export.h: Added.
ANGLE/gl2.h: Added.
ANGLE/gl2ext.h: Added.
ANGLE/gl2platform.h: Added.
ANGLE/gl3.h: Added.
ANGLE/gl31.h: Added.
ANGLE/gl3platform.h: Added.
ANGLE/khrplatform.h: Added.

Add more forwarding headers. There are already a few, but we need more.

CMakeLists.txt:
PlatformMac.cmake:

Make the frameworks linked to by ANGLE be private so frameworks that link with
ANGLE don't automatically link with them. This allows me to switch ANGLE from a
static library to a dynamic library to make sure WebCore isn't directly using OpenGL.

PlatformWin.cmake:

Move HLSL-specific files to only be built on Windows.

include/EGL/egl.h:
include/EGL/eglplatform.h:
include/GLES2/gl2.h:
include/GLES2/gl2platform.h:
include/GLES3/gl3.h:
include/GLES3/gl31.h:
include/GLES3/gl32.h:
include/GLES3/gl3platform.h:
src/libGLESv2/entry_points_egl.h:
src/libGLESv2/entry_points_egl_ext.h:
src/libGLESv2/entry_points_gles_2_0.h:
src/libGLESv2/entry_points_gles_2_0_ext.h:
src/libGLESv2/entry_points_gles_3_0.h:
src/libGLESv2/entry_points_gles_3_1.h:

Include ANGLE headers as #include <ANGLE/*> instead of #include <KHR/*> or #include <GLES/*>
This is needed to distinguish the ANGLE headers from any system OpenGL/OpenGLES headers.
We will eventually only include ANGLE's entry_points_*.h directly from WebCore.

Source/WebCore:

No new tests, no change in behavior.
Just compile fixes for a configuration that will soon be standard
that can be landed now without breaking anything.

platform/graphics/PlatformDisplay.cpp:

(WebCore::PlatformDisplay::sharedDisplay):
Ignore some clang warnings that will cause problems when this is compiled on Mac.

1:31 PM Changeset in webkit [209831] by andersca@apple.com

2 edits in trunk/Source/WebKit2

Add some instrumentation to try to detect a crash on the bots
https://bugs.webkit.org/show_bug.cgi?id=165866

Reviewed by Sam Weinig.

Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::sendMessage):

1:29 PM Changeset in webkit [209830] by keith_miller@apple.com

18 edits
6 adds in trunk

WebAssembly JS API: implement Global
https://bugs.webkit.org/show_bug.cgi?id=164133

Reviewed by Saam Barati.

JSTests:

wasm/Builder.js:

(export.default.Builder.prototype._registerSectionBuilders.switch.case.string_appeared_here.this.section):

wasm/Builder_WebAssemblyBinary.js:

(const.valueType.WASM.description.type.i32.type.const.putGlobalType):
(const.putOp):
(const.putInitExpr):
(const.emitters.Import):
(const.emitters.Global):
(const.emitters.Export):
(const.emitters.Code):

wasm/LowLevelBinary.js:

(export.default.LowLevelBinary.prototype.varuint32):
(export.default.LowLevelBinary.prototype.varint32):

wasm/js-api/global-error.js: Added.

(catch):
(assert.truthy):

wasm/js-api/global-external-init-from-import.js: Added.
wasm/js-api/global-internal-init-from-import.js: Added.
wasm/js-api/global-mutate.js: Added.

(createInternalGlobalModule):

wasm/js-api/globals-export.js: Added.
wasm/js-api/globals-import.js: Added.
wasm/wasm.json:

Source/JavaScriptCore:

This patch adds support for globals. It handles imports, exports
and internal globals. In the MVP only internal globals are allowed
to be mutable. This means we can store a C-array of 64-bit slots
off the instance holding them. When globals are exported to JS
they are done so as numbers. This means that i64 globals cannot be
imported or exported.

wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::getGlobal):
(JSC::Wasm::B3IRGenerator::setGlobal):
(JSC::Wasm::B3IRGenerator::addCallIndirect):
(JSC::Wasm::parseAndCompile):

wasm/WasmFormat.h:
wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser<Context>::parseExpression):

wasm/WasmModuleParser.cpp:

(JSC::Wasm::ModuleParser::parseImport):
(JSC::Wasm::ModuleParser::parseGlobal):
(JSC::Wasm::ModuleParser::parseExport):
(JSC::Wasm::ModuleParser::parseElement):
(JSC::Wasm::ModuleParser::parseInitExpr):
(JSC::Wasm::ModuleParser::parseGlobalType):
(JSC::Wasm::ModuleParser::parseData):

wasm/WasmModuleParser.h:
wasm/WasmParser.h:

(JSC::Wasm::Parser::parseVarInt32):
(JSC::Wasm::Parser::parseVarInt64):
(JSC::Wasm::Parser::parseUInt64):

wasm/WasmValidate.cpp:

(JSC::Wasm::Validate::hasMemory):
(JSC::Wasm::Validate::Validate):
(JSC::Wasm::Validate::getGlobal):
(JSC::Wasm::Validate::setGlobal):
(JSC::Wasm::validateFunction):

wasm/generateWasmOpsHeader.py:
wasm/js/JSWebAssemblyInstance.cpp:

(JSC::JSWebAssemblyInstance::create):
(JSC::JSWebAssemblyInstance::finishCreation):
(JSC::JSWebAssemblyInstance::visitChildren):

wasm/js/JSWebAssemblyInstance.h:

(JSC::JSWebAssemblyInstance::loadI32Global):
(JSC::JSWebAssemblyInstance::loadI64Global):
(JSC::JSWebAssemblyInstance::loadF32Global):
(JSC::JSWebAssemblyInstance::loadF64Global):
(JSC::JSWebAssemblyInstance::setGlobal):
(JSC::JSWebAssemblyInstance::offsetOfGlobals):

wasm/js/WebAssemblyInstanceConstructor.cpp:

(JSC::constructJSWebAssemblyInstance):

wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::finishCreation):
(JSC::WebAssemblyModuleRecord::link):

1:18 PM Changeset in webkit [209829] by bshafiei@apple.com

7 edits
4 copies in tags/Safari-603.1.16

Merged r209824. rdar://problem/29666094

1:14 PM Changeset in webkit [209828] by dino@apple.com

2 edits in trunk/Source/WebCore

[iOS] MediaDocuments have controls on the bottom of the page
https://bugs.webkit.org/show_bug.cgi?id=165865
<rdar://problem/28757268>

Reviewed by Jon Lee.

MediaDocuments on iOS are incorrectly placing the controls at
the bottom of the page. This is due to the <video> element
getting a height of 100%. It should be "auto" instead.

html/MediaDocument.cpp:

(WebCore::MediaDocumentParser::createDocumentStructure):

1:05 PM Changeset in webkit [209827] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, re-enable concurrent GC on ARM64 now that the most likely culprit of the memory
regressions is fixed. Lets see what the bots think!

runtime/Options.cpp:

(JSC::recomputeDependentOptions):

1:02 PM Changeset in webkit [209826] by hyatt@apple.com

46 edits
23 adds in trunk

[CSS Parser] Implement deferred parsing of properties, @media, @supports and @keyframes
https://bugs.webkit.org/show_bug.cgi?id=165743

Reviewed by Dean Jackson.

Source/WebCore:

Added new tests in fast/css/deferred-parsing.

This patch implements deferred parsing in CSS. By default, when parsing
author stylesheets, the parser goes into a deferred mode where it leaves
the declaration block of all style rules unparsed initially. Instead of
creating and setting an ImmutableStyleProperties object on the StyleRule,
the parser creates a DeferredStyleProperties object instead that is
capable of calling into CSSDeferredParser to parse the properties and values
only when the properties are finally asked for.

In addition, this patch defers the parsing of the interior of @media,
@supports, and @keyframes rules. @media blocks that are never matched will
never parse any of the rules inside. @supports conditions for unsupported
features will also not be parsed. For @keyframes, if the animation is never
referenced/used, then the @keyframes child rules will never be parsed.

CMakeLists.txt:
WebCore.xcodeproj/project.pbxproj:

Add CSSDeferredParser to the build.

css/CSSFontFaceSet.cpp:

(WebCore::CSSFontFaceSet::matchingFaces):
Patched to drop the StyleSheetContents* argument from parseValue, since it
is no longer needed.

css/CSSKeyframesRule.cpp:

(WebCore::StyleRuleKeyframes::StyleRuleKeyframes):
(WebCore::StyleRuleKeyframes::parseDeferredRulesIfNeeded):
(WebCore::StyleRuleKeyframes::keyframes):
(WebCore::StyleRuleKeyframes::wrapperAppendKeyframe):
(WebCore::StyleRuleKeyframes::wrapperRemoveKeyframe):
(WebCore::StyleRuleKeyframes::findKeyframeIndex):

css/CSSKeyframesRule.h:

Keyframes now hold both a keyframes Vector and a DeferredStyleGroupRuleList
object. The keyframes vector won't be populated until it is needed, and the
population is done by DeferredStyleGroupRuleList, which holds both the original
tokens of the keyframes rule interior, and a references to the
CSSDeferredParser that will do the parsing.

css/DOMCSSNamespace.cpp:

(WebCore::DOMCSSNamespace::supports):
Patched to drop the StyleSheetContents* argument from parseValue, since it
is no longer needed.

css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::collectMatchingRulesForList):
ElementRuleCollector tests to see if a rule is empty by counting properties(),
but we don't want to initiate deferred parsing just to check this. Instead we
invoke propertiesWithoutDeferredParsing, which will hand back a nullptr if
the properties haven't been parsed yet. In order to ensure this optimization
continues to work, any rules whose interiors consist of only whitespace do
not get deferred.

css/FontFace.cpp:

(WebCore::FontFace::setVariant):

css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
Patched to drop the StyleSheetContents* argument from parseValue, since it
is no longer needed.

css/StyleProperties.cpp:

(WebCore::MutableStyleProperties::MutableStyleProperties):
(WebCore::MutableStyleProperties::setProperty):
(WebCore::DeferredStyleProperties::create):
(WebCore::DeferredStyleProperties::DeferredStyleProperties):
(WebCore::DeferredStyleProperties::~DeferredStyleProperties):
(WebCore::DeferredStyleProperties::parseDeferredProperties):

css/StyleProperties.h:

(WebCore::StylePropertiesBase::type):
(WebCore::StylePropertiesBase::cssParserMode):
(WebCore::StylePropertiesBase::StylePropertiesBase):
(WebCore::StyleProperties::isMutable):
(WebCore::StyleProperties::StyleProperties):
(WebCore::StylePropertiesBase::deref):
(isType):
(WebCore::StyleProperties::cssParserMode): Deleted.
(WebCore::StyleProperties::deref): Deleted.
Right now StyleProperties has two subclasses, ImmutableStyleProperties (which
is created by the parser when not deferring), and MutableStyleProperties (used
when making changes and doing DOM Manipulations).

This patch adds a new base class called StylePropertiesBase, and StyleProperties
now derives from it. DeferredStyleProperties derives from this base. The members
of StyleProperties have been moved up into StylePropertiesBase.

The m_isMutable bit, used to determine the type for downcasting has been enhanced
to m_type (2 bits), since there are now three possible subclasses.

css/StyleRule.cpp:

(WebCore::StyleRule::StyleRule):
(WebCore::StyleRule::properties):
(WebCore::StyleRule::mutableProperties):
(WebCore::StyleRule::splitIntoMultipleRulesWithMaximumSelectorComponentCount):
Patched to ensure that when properties() are accessed, that if the current
stored StylePropertyBase in the rule is a DeferredStyleProperties, we then
parse and replace DeferredStyleProperties with ImmutableStyleProperties on the
rule. By using a common base class, we avoid increasing memory usage in
StyleRule.

(WebCore::DeferredStyleGroupRuleList::create):
(WebCore::DeferredStyleGroupRuleList::DeferredStyleGroupRuleList):
(WebCore::DeferredStyleGroupRuleList::parseDeferredRules):
(WebCore::DeferredStyleGroupRuleList::parseDeferredKeyframes):
DeferredStyleGroupList is used to handle deferred parsing of objects with
child rules. These include @media, @supports and @keyframes.

(WebCore::StyleRuleGroup::StyleRuleGroup):
(WebCore::StyleRuleGroup::childRules):
(WebCore::StyleRuleGroup::wrapperInsertRule):
(WebCore::StyleRuleGroup::wrapperRemoveRule):
(WebCore::StyleRuleGroup::parseDeferredRulesIfNeeded):
(WebCore::StyleRuleMedia::StyleRuleMedia):
(WebCore::StyleRuleSupports::StyleRuleSupports):
StyleRuleGroup now holds both a child rules Vector and a
DeferredStyleGroupRuleList. If DeferredStyleGroupRuleList is set, then
when the childRules are finally accessed, we will populate the childRules
Vector and then null out the DeferredStyleGroupRuleList.

css/StyleRule.h:

(WebCore::StyleRule::propertiesWithoutDeferredParsing):
(WebCore::StyleRuleGroup::childRulesWithoutDeferredParsing):
(WebCore::StyleRuleGroup::childRules): Deleted.
Add new accesors for fetching properties and child rules without causing
deferred parsing to happen.

css/StyleSheetContents.cpp:

(WebCore::StyleSheetContents::parseAuthorStyleSheet):
(WebCore::StyleSheetContents::parseString):
Patched to turn on deferred parsing for author sheets and for all
non-UA stylesheets parsed from a string (e.g., <style>).

(WebCore::traverseSubresourcesInRules):
The broken resource check was aggressively accessing properties(). Patch
it to call propertiesWithoutDeferredParsing() instead so that it doesn't
defeat the new optimization.

css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::setMatrixValue):
Patched to drop the StyleSheetContents* argument from parseValue, since it
is no longer needed.

css/parser/CSSDeferredParser.cpp: Added.

(WebCore::CSSDeferredParser::CSSDeferredParser):
(WebCore::CSSDeferredParser::parseDeclaration):
(WebCore::CSSDeferredParser::parseRuleList):
(WebCore::CSSDeferredParser::parseKeyframeList):

css/parser/CSSDeferredParser.h: Added.

(WebCore::CSSDeferredParser::create):
(WebCore::CSSDeferredParser::tokenizer):
(WebCore::CSSDeferredParser::mode):
(WebCore::CSSDeferredParser::context):
(WebCore::CSSDeferredParser::styleSheet):
The CSSDeferredParser. It caches the original tokenizer's' escaped strings. Because
the CSSDeferredParser is referenced by all the rules that have yet to parse,
it will stay alive until all rules in the stylesheet has been fully parsed.

The parser receives CSSParserTokenRanges from DeferredStyleProperties or
DeferredStyleGroupRuleList and feeds them to CSSParserImpl, which then
is able to do the parsing as it would have occurred originally had the
range not been deferred.

css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseSheet):
(WebCore::CSSParser::parseSupportsCondition):
(WebCore::CSSParser::parseSingleValue):
(WebCore::CSSParser::parseValue):

css/parser/CSSParser.h:
css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::parseKeywordValue):
(WebCore::CSSParserFastPaths::maybeParseValue):

css/parser/CSSParserFastPaths.h:

Drop the StyleSheetContents* argument from the methods that no longer need
them.

css/parser/CSSParserImpl.cpp:

(WebCore::CSSParserImpl::CSSParserImpl):
(WebCore::CSSParserImpl::tokenizer):
(WebCore::CSSParserImpl::parseValue):
(WebCore::CSSParserImpl::parseCustomPropertyValue):
(WebCore::CSSParserImpl::parseDeclarationList):
(WebCore::CSSParserImpl::parseInlineStyleDeclaration):
(WebCore::CSSParserImpl::parseRule):
(WebCore::CSSParserImpl::parseStyleSheet):
(WebCore::CSSParserImpl::parseDeclarationListForInspector):
(WebCore::CSSParserImpl::parseStyleSheetForInspector):
(WebCore::CSSParserImpl::consumeQualifiedRule):
(WebCore::CSSParserImpl::consumeMediaRule):
(WebCore::CSSParserImpl::consumeSupportsRule):
(WebCore::CSSParserImpl::consumeKeyframesRule):
(WebCore::CSSParserImpl::consumeStyleRule):
Drop the StyleSheetContents* argument from the methods that no longer need
them.

(WebCore::CSSParserImpl::createDeferredStyleProperties):
(WebCore::CSSParserImpl::parseDeferredDeclaration):
(WebCore::CSSParserImpl::parseDeferredRuleList):
(WebCore::CSSParserImpl::parseDeferredKeyframeList):
The methods that handle deferred parsing. They make sure to initialize
new CSSParserImpls with the original deferred parser, and then call existing
methods to do the parsing.

css/parser/CSSParserImpl.h:

Patched to remove StyleSheetContents* arguments from some methods and
to add the new deferred parsing methods.

css/parser/CSSParserTokenRange.cpp:

(WebCore::CSSParserTokenRange::consumeBlockCheckingForEditability):

css/parser/CSSParserTokenRange.h:

In order to preserve the editability optimization from r180867, when
a style rule's block is consumed, we use a special method that looks
for -webkit-user-modify tokens. If one is seen, then the editability
optimization is turned off. Because we do this at the token level,
the optimization keeps working even if properties don't get parsed.

css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::CSSPropertyParser::parseFontFaceDescriptor):
(WebCore::CSSPropertyParser::consumeFont):
(WebCore::CSSPropertyParser::parseShorthand):
Patched to remove StyleSheetContents* arguments now that the editability
check is in CSSTokenizer instead.

css/parser/CSSTokenizer.cpp:

(WebCore::CSSTokenizer::tokenRange):

css/parser/CSSTokenizer.h:

Make tokenRange() const.

html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setFont):
Patched to drop the StyleSheetContents* argument.

testing/Internals.cpp:

(WebCore::deferredStyleRulesCountForList):
(WebCore::Internals::deferredStyleRulesCount):
(WebCore::deferredGroupRulesCountForList):
(WebCore::Internals::deferredGroupRulesCount):
(WebCore::deferredKeyframesRulesCountForList):
(WebCore::Internals::deferredKeyframesRulesCount):

testing/Internals.h:
testing/Internals.idl:

Add new testing methods that can count the deferred style rules and
group child rule lists. These methods are used by the new layout tests.

Source/WebKit2:

Repurpose the newCSSParserEnabled preference for deferred parsing. Just change the name
from "new" to "deferred."

Shared/WebPreferencesDefinitions.h:
UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetDeferredCSSParserEnabled):
(WKPreferencesGetDeferredCSSParserEnabled):
(WKPreferencesSetNewCSSParserEnabled): Deleted.
(WKPreferencesGetNewCSSParserEnabled): Deleted.

UIProcess/API/C/WKPreferencesRefPrivate.h:
WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

LayoutTests:

fast/css/deferred-parsing: Added.
fast/css/deferred-parsing/dynamic-external-style-expected.txt: Added.
fast/css/deferred-parsing/dynamic-external-style.html: Added.
fast/css/deferred-parsing/dynamic-style-in-document-expected.txt: Added.
fast/css/deferred-parsing/dynamic-style-in-document.html: Added.
fast/css/deferred-parsing/hover-test-expected.txt: Added.
fast/css/deferred-parsing/hover-test.html: Added.
fast/css/deferred-parsing/keyframes-rule-expected.txt: Added.
fast/css/deferred-parsing/keyframes-rule.html: Added.
fast/css/deferred-parsing/media-print-expected.txt: Added.
fast/css/deferred-parsing/media-print.html: Added.
fast/css/deferred-parsing/nth-of-type-expected.txt: Added.
fast/css/deferred-parsing/nth-of-type.html: Added.
fast/css/deferred-parsing/resources: Added.
fast/css/deferred-parsing/resources/basic-sheet.css: Added.
fast/css/deferred-parsing/simple-external-style-expected.txt: Added.
fast/css/deferred-parsing/simple-external-style.html: Added.
fast/css/deferred-parsing/simple-style-in-document-expected.txt: Added.
fast/css/deferred-parsing/simple-style-in-document.html: Added.
fast/css/deferred-parsing/supports-rule-expected.txt: Added.
fast/css/deferred-parsing/supports-rule.html: Added.

12:57 PM Changeset in webkit [209825] by fpizlo@apple.com

4 edits in trunk/Source/JavaScriptCore

Devices with fewer cores should use a more aggressive GC schedule by default
https://bugs.webkit.org/show_bug.cgi?id=165859

Reviewed by Mark Lam.

heap/Heap.cpp:

(JSC::Heap::markToFixpoint): Log when we have an unexpected delay in wake-up.

heap/SlotVisitor.cpp:

(JSC::SlotVisitor::drainInParallelPassively): Don't drain passively if there aren't many cores.

runtime/Options.cpp:

(JSC::overrideDefaults): Change the heuristics if we have fewer cores.
(JSC::Options::initialize):

runtime/Options.h:

12:56 PM Changeset in webkit [209824] by beidson@apple.com

7 edits
4 adds in trunk

IndexedDB 2.0: Massively speedup IDBIndex.get().
https://bugs.webkit.org/show_bug.cgi?id=165802

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (No behavior change to Javascript, table upgrade change covered by API test).

This change upgrades the IndexRecords schema to include the ObjectStore record ID for the referenced record.
It also adds a SQLite Index-by-key on IndexRecords.

This speeds up PerformanceTests/IndexedDB/index-get.html by 15-20x.

Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::v3IndexRecordsTableSchema):
(WebCore::IDBServer::v3IndexRecordsTableSchemaAlternate):
(WebCore::IDBServer::v1IndexRecordsIndexSchema):
(WebCore::IDBServer::SQLiteIDBBackingStore::ensureValidIndexRecordsTable):
(WebCore::IDBServer::SQLiteIDBBackingStore::ensureValidIndexRecordsIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::getOrEstablishDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexKey):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::updateOneIndexForAddRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::updateAllIndexesForAddRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetIndexRecordForOneKey):

Modules/indexeddb/server/SQLiteIDBBackingStore.h:

Modules/indexeddb/server/SQLiteIDBCursor.cpp:

(WebCore::IDBServer::SQLiteIDBCursor::markAsErrored):
(WebCore::IDBServer::SQLiteIDBCursor::internalAdvanceOnce):

Modules/indexeddb/server/SQLiteIDBCursor.h:

(WebCore::IDBServer::SQLiteIDBCursor::currentRecordRowID):

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.html: Added.
TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm: Added.
TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.blob: Added.
TestWebKitAPI/Tests/WebKit2Cocoa/IndexUpgrade.sqlite3: Added.

12:42 PM Changeset in webkit [209823] by weinig@apple.com

2 edits in trunk/Source/WebCore

Actually set the shipping contact when validating the payment request

Reviewed by Anders Carlsson.

Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidate):
Fix typo.

12:30 PM Changeset in webkit [209822] by wilander@apple.com

2 edits in trunk/Source/WebCore

Handle key generation with empty challenge string
https://bugs.webkit.org/show_bug.cgi?id=165835
<rdar://problem/29128710>

Reviewed by Anders Carlsson.

https://bugs.webkit.org/show_bug.cgi?id=160945 didn't set the challenge length to
1 for empty challenge strings. Thus the null terminator was not included. Empty
challenge strings are allowed:
"If the element has a challenge attribute, then let challenge be that attribute's
value. Otherwise, let challenge be the empty string."
https://www.w3.org/TR/html5/forms.html#the-keygen-element (fetched 2016-12-13)

Email certificate generation at
https://www.comodo.com/home/email-security/free-email-certificate.php broke
because of https://bugs.webkit.org/show_bug.cgi?id=160945.

No new tests. The original patch did not have tests and the breakage was in the
produced key material so a test would have to validate the crypto output.

platform/mac/SSLKeyGeneratorMac.mm:

(WebCore::signedPublicKeyAndChallengeString):

Now adds 1 to the length of the challenge to account for its null terminator.
This matches the old behavior.

12:17 PM Changeset in webkit [209821] by dbates@webkit.org

4 edits
2 adds in trunk

CSP: Allow HTTPS URL to match HTTP source expression
https://bugs.webkit.org/show_bug.cgi?id=159520
<rdar://problem/27287177>

Reviewed by Brent Fulgham.

Source/WebCore:

Test: http/tests/security/contentSecurityPolicy/script-src-parsing-implicit-and-explicit-port-number.html

page/csp/ContentSecurityPolicySource.cpp:

(WebCore::ContentSecurityPolicySource::schemeMatches):
(WebCore::ContentSecurityPolicySource::portMatches):

LayoutTests:

http/tests/security/contentSecurityPolicy/script-src-parsing-implicit-and-explicit-port-number-expected.txt: Added.
http/tests/security/contentSecurityPolicy/script-src-parsing-implicit-and-explicit-port-number.html: Added.
platform/wk2/TestExpectations: Skip the test on WebKit2 because it makes use of Internals.registerDefaultPortForProtocol(),

which does not work with NetworkProcess.

11:58 AM Changeset in webkit [209820] by mark.lam@apple.com

2 edits in trunk/Source/JavaScriptCore

BytecodeBasicBlock::computeImpl() should not keep iterating blocks if all jump targets have already been found.
https://bugs.webkit.org/show_bug.cgi?id=165820

Reviewed by Saam Barati.

Currently, if an opcode is a branch type opcode, BytecodeBasicBlock::computeImpl()
will iterate over all basic blocks looking for the block containing the jump
target, and it will continue to do this even when all the jump targets have been
found. This is wasted work, and all the more so given that most branch type
opcodes only have a single jump target.

bytecode/BytecodeBasicBlock.cpp:

(JSC::BytecodeBasicBlock::computeImpl):

11:53 AM Changeset in webkit [209819] by achristensen@apple.com

2 edits in trunk/Source/WebCore

REGRESSION (r209776): [ios-simulator] LayoutTest http/tests/xmlhttprequest/on-network-timeout-error-during-preflight.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=165836

Reviewed by Brady Eidson.

loader/CrossOriginAccessControl.cpp:

(WebCore::createAccessControlPreflightRequest):
Use the platform default timeout for CORS preflight requests.

11:27 AM Changeset in webkit [209818] by Ryan Haddad

1 edit
3 adds in trunk/LayoutTests

Add mac-elcapitan baseline for js/dom/global-constructors-attributes.html.

Unreviewed test gardening.

platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt: Added.

10:54 AM Changeset in webkit [209817] by Antti Koivisto

2 edits in trunk/Source/WebCore

WebContent crash under WebCore::CachedResource::load in WebCore::FrameLoader::outgoingReferrer const
https://bugs.webkit.org/show_bug.cgi?id=165852
<rdar://problem/27297153>

Reviewed by Chris Dumez.

There appears to be some path where we get here with a null frame.
No test, don't know how exactly this happens.

loader/FrameLoader.cpp:

(WebCore::FrameLoader::outgoingReferrer):

Null check the frame.

10:44 AM Changeset in webkit [209816] by bshafiei@apple.com

5 edits in trunk/Source

Versioning.

10:39 AM Changeset in webkit [209815] by bshafiei@apple.com

1 copy in tags/Safari-603.1.16

New tag.

10:27 AM Changeset in webkit [209814] by Brent Fulgham

2 edits in trunk/Source/WebKit2

Unreviewed test fix after r209806.

Plugin-common doesn't define 'home-subpath'. Instead it has 'home-library-subpath'. Switch to the correct
function. Also, 'home-library-subpath' adds '/Library' to the path, so revise the arguments so that we
do not generate paths like '/home/username/Library/Library/Keychains'.

PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:

10:07 AM Changeset in webkit [209813] by barraclough@apple.com

2 edits in trunk/Source

Source/JavaScriptCore:
MarkedBlock::marksConveyLivenessDuringMarking should take into account collection scope
https://bugs.webkit.org/show_bug.cgi?id=165741

Unreviewed, re-landing this with fix (revert erroneous change to Options).

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
heap/CellContainer.cpp: Added.

(JSC::CellContainer::isNewlyAllocated):

heap/CellContainer.h:
heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::addBlock):
(JSC::MarkedAllocator::removeBlock):
(JSC::MarkedAllocator::dumpBits):

heap/MarkedAllocator.h:

(JSC::MarkedAllocator::forEachBitVector):
(JSC::MarkedAllocator::forEachBitVectorWithName):

heap/MarkedBlock.cpp:

(JSC::MarkedBlock::tryCreate):
(JSC::MarkedBlock::Handle::~Handle):
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::Handle::specializedSweep):
(JSC::MarkedBlock::Handle::sweepHelperSelectMarksMode):
(JSC::MarkedBlock::Handle::stopAllocating):
(JSC::MarkedBlock::Handle::resumeAllocating):
(JSC::MarkedBlock::aboutToMarkSlow):
(JSC::MarkedBlock::Handle::didConsumeFreeList):
(JSC::MarkedBlock::Handle::dumpState):

heap/MarkedBlock.h:

(JSC::MarkedBlock::markingVersion):
(JSC::MarkedBlock::isMarkedRaw):
(JSC::MarkedBlock::isMarked):

heap/MarkedBlockInlines.h:

(JSC::MarkedBlock::marksConveyLivenessDuringMarking):

heap/SlotVisitor.cpp:

(JSC::SlotVisitor::appendJSCellOrAuxiliary):

runtime/StructureIDTable.h:

(JSC::StructureIDTable::size):
(JSC::StructureIDTable::get):

Source/WTF:
Unreviewed, rolling out r209795.
https://bugs.webkit.org/show_bug.cgi?id=165853

rolled out the wrong revision (Requested by pizlo on #webkit).

Reverted changeset:

"MarkedBlock::marksConveyLivenessDuringMarking should take
into account collection scope"
https://bugs.webkit.org/show_bug.cgi?id=165741
http://trac.webkit.org/changeset/209795

Patch by Commit Queue <commit-queue@webkit.org> on 2016-12-14

9:50 AM Changeset in webkit [209812] by Chris Dumez

27 edits in trunk/Source

Unreviewed, rolling out r209766.

Regressed Dromaeo JSLib by ~50%

Reverted changeset:

"Make opaque root scanning truly constraint-based"
https://bugs.webkit.org/show_bug.cgi?id=165760
http://trac.webkit.org/changeset/209766

9:41 AM Changeset in webkit [209811] by aestes@apple.com

7 edits in trunk/Source/WebCore

EventDispatcher::dispatchEvent() should take its Node by reference
https://bugs.webkit.org/show_bug.cgi?id=165840

Reviewed by Andreas Kling.

No new tests. No change in behavior.

dom/Element.cpp:

(WebCore::Element::dispatchWheelEvent): Dereferenced |this| when calling
EventDispatcher::dispatchEvent().
(WebCore::Element::dispatchKeyEvent): Ditto.
(WebCore::Element::dispatchFocusEvent): Ditto.
(WebCore::Element::dispatchBlurEvent): Ditto.

dom/EventDispatcher.cpp:

dom/EventDispatcher.h: Changed dispatchEvent's first parameter type from Node* to Node&.
dom/Node.cpp:

(WebCore::Node::dispatchEvent): Dereferenced |this| when calling
EventDispatcher::dispatchEvent().
(WebCore::Node::dispatchTouchEvent): Ditto.
(WebCore::Node::dispatchUIRequestEvent): Ditto.

dom/ScopedEventQueue.cpp:

(WebCore::ScopedEventQueue::dispatchEvent): Dereferenced |node| when calling
EventDispatcher::dispatchEvent().

dom/SimulatedClick.cpp:

(WebCore::simulateMouseEvent): Passed |element| as a reference to
EventDispatcher::dispatchEvent().

9:37 AM Changeset in webkit [209810] by Chris Dumez

16 edits
2 adds
10 deletes in trunk

Remove Unicode case-insensitive matching for usemap=""
https://bugs.webkit.org/show_bug.cgi?id=163894

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Rebaseline W3C test now that more checks are passing.

web-platform-tests/html/semantics/embedded-content/the-img-element/usemap-casing-expected.txt:

Source/WebCore:

Remove Unicode case-insensitive matching for usemap="" as this no longer
matches the specification [1] or Firefox. Also align our parsing logic for
the usemap attribute to match the specification [2].

This simplifies the code a bit, is more efficient and the compatibility
risk should be low based on Firefox's behavior and Chome's usage data.

[1] https://github.com/whatwg/html/commit/6acdb2122298d2bb7bb839c0a61b4e1f9b0f9bc9
[2] https://html.spec.whatwg.org/#rules-for-parsing-a-hash-name-reference

Test: fast/images/image-usemap-parsing.html

dom/Document.cpp:

(WebCore::Document::addImageElementByUsemap):
(WebCore::Document::removeImageElementByUsemap):
(WebCore::Document::imageElementByUsemap):

dom/Document.h:
dom/DocumentOrderedMap.cpp:

(WebCore::DocumentOrderedMap::getElementByUsemap):

dom/DocumentOrderedMap.h:
dom/TreeScope.cpp:

(WebCore::TreeScope::getImageMap):

html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::parseAttribute):
(WebCore::HTMLImageElement::insertedInto):
(WebCore::HTMLImageElement::removedFrom):
(WebCore::HTMLImageElement::matchesUsemap):

html/HTMLImageElement.h:
html/HTMLMapElement.cpp:

(WebCore::HTMLMapElement::imageElement):
(WebCore::HTMLMapElement::parseAttribute):

html/parser/HTMLParserIdioms.cpp:

(WebCore::parseHTMLHashNameReference):

html/parser/HTMLParserIdioms.h:

LayoutTests:

fast/images/image-map-multiple.html:

Fix case of the usemap.

fast/images/image-usemap-parsing-expected.txt: Added.
fast/images/image-usemap-parsing.html: Added.

Add layout test coverage.

fast/images/imagemap-case.html: Removed.
platform/efl/fast/images/imagemap-case-expected.png: Removed.
platform/efl/fast/images/imagemap-case-expected.txt: Removed.
platform/gtk/fast/images/imagemap-case-expected.png: Removed.
platform/gtk/fast/images/imagemap-case-expected.txt: Removed.
platform/ios-simulator-wk2/fast/images/imagemap-case-expected.txt: Removed.
platform/ios-simulator/fast/images/imagemap-case-expected.txt: Removed.
platform/mac/fast/images/imagemap-case-expected.png: Removed.
platform/mac/fast/images/imagemap-case-expected.txt: Removed.
platform/win/fast/images/imagemap-case-expected.txt: Removed.

Drop outdated pixel test case. Case sensitivity is now covered by
the new fast/images/image-usemap-parsing.html test.

9:28 AM Changeset in webkit [209809] by Ryan Haddad

2 edits in trunk/Source/WebCore

Attempt to fix the Windows build after r209805.

Unreviewed build fix.

css/CSSAllInOne.cpp:

9:25 AM Changeset in webkit [209808] by commit-queue@webkit.org

21 edits
4 copies in trunk/Source

Unreviewed, rolling out r209795.
https://bugs.webkit.org/show_bug.cgi?id=165853

rolled out the wrong revision (Requested by pizlo on #webkit).

Reverted changeset:

"MarkedBlock::marksConveyLivenessDuringMarking should take
into account collection scope"
https://bugs.webkit.org/show_bug.cgi?id=165741
http://trac.webkit.org/changeset/209795

9:19 AM Changeset in webkit [209807] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, disable concurrent GC on ARM while we investigate a memory use regression.

runtime/Options.cpp:

(JSC::recomputeDependentOptions):

9:17 AM Changeset in webkit [209806] by Brent Fulgham

3 edits in trunk/Source/WebKit2

Unreviewed test fix after r209779.

The 'Keygen' element requires the ability to create new keys in '$HOME/Library/Keychains'. Remove the
WebProcess and Plugin sandbox restrictions on per-user Keychain creation to support this use.

PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
WebProcess/com.apple.WebProcess.sb.in:

8:34 AM Changeset in webkit [209805] by hyatt@apple.com

24 edits
3 deletes in trunk

[CSS Parser] Remove WebkitCSSTransformValue
https://bugs.webkit.org/show_bug.cgi?id=165844

Reviewed by Zalan Bujtas.

Source/WebCore:

Remove WebkitCSSTransformValue and just use a CSSFunctionValue instead. No other
browsers support it, and the information it provides is easily obtainable from cssText.

CMakeLists.txt:
DerivedSources.cpp:
DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSCSSValueCustom.cpp:

(WebCore::toJSNewlyCreated):

css/CSSComputedStyleDeclaration.cpp:

(WebCore::matrixTransformValue):

css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):

css/CSSValue.h:

(WebCore::CSSValue::isSpringTimingFunctionValue):
(WebCore::CSSValue::isWebKitCSSTransformValue): Deleted.

css/StyleResolver.cpp:
css/TransformFunctions.cpp:

(WebCore::transformOperationType):
(WebCore::transformsForValue):

css/TransformFunctions.h:
css/WebKitCSSTransformValue.cpp: Removed.
css/WebKitCSSTransformValue.h: Removed.
css/WebKitCSSTransformValue.idl: Removed.
css/parser/CSSParserFastPaths.cpp:

(WebCore::parseTransformTranslateArguments):
(WebCore::parseTransformNumberArguments):
(WebCore::parseSimpleTransformValue):
(WebCore::parseSimpleTransformList):

css/parser/CSSPropertyParser.cpp:

(WebCore::consumeTranslate3d):
(WebCore::consumeNumbers):
(WebCore::consumePerspective):
(WebCore::consumeTransformValue):
(WebCore::transformOperationForCSSValueID): Deleted.

LayoutTests:

fast/css/getFloatValueForUnit-expected.txt:
fast/css/getFloatValueForUnit.html:
platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:
platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
platform/mac/fast/dom/wrapper-classes-objc-expected.txt:
platform/mac/fast/dom/wrapper-classes-objc.html:
platform/mac/js/dom/global-constructors-attributes-expected.txt:
transforms/2d/transform-value-types-expected.txt:
transforms/2d/transform-value-types.html:

8:19 AM Changeset in webkit [209804] by clopez@igalia.com

2 edits in trunk/Tools

[GTK][EFL] Update the JHBuild version.
https://bugs.webkit.org/show_bug.cgi?id=165838

Reviewed by Michael Catanzaro.

jhbuild/jhbuild-wrapper: This new version fixes a bug with the

usage of the JHBUILD_MIRROR feature with git repositories.

8:16 AM Changeset in webkit [209803] by Yusuke Suzuki

2 edits in trunk/LayoutTests

Unreviewed, LayoutTest http/tests/misc/module-script-async.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=165764

Annotate it as Slow.

TestExpectations:

8:06 AM Changeset in webkit [209802] by Antti Koivisto

3 edits in trunk/Source/WebCore

Make Style::Update const in RenderTreeUpdater
https://bugs.webkit.org/show_bug.cgi?id=165845

Reviewed by Andreas Kling.

Moving style away from unique_ptrs leaves them in weird state.

style/RenderTreeUpdater.cpp:

(WebCore::findRenderingRoots):
(WebCore::RenderTreeUpdater::commit):
(WebCore::RenderTreeUpdater::updateElementRenderer):

Clone the style instead of moving it. This is not meaningfully more expensive.
Remove null checks, style is never null.

style/RenderTreeUpdater.h:

8:04 AM Changeset in webkit [209801] by Yusuke Suzuki

47 edits in trunk/Source

Use JSValue::toWTFString instead of calling toString(exec) and value(exec)
https://bugs.webkit.org/show_bug.cgi?id=165795

Reviewed by Saam Barati.

Source/JavaScriptCore:

In old days, we frequently use the idiom like, value.toString(exec)->value(exec) to
get WTFString from the given JSValue. But now, we have better function, toWTFString.
toWTFString does not create intermediate JSString objects, then reduce unnecessary
allocations.

This patch mechanically replaces value.toString(exec)->value(exec) with toWTFString(exec).

API/JSValueRef.cpp:

(JSValueToStringCopy):

bindings/ScriptValue.cpp:

(Deprecated::ScriptValue::toString):

inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::reportAPIException):

inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::evaluateWithScopeExtension):

inspector/JSJavaScriptCallFrame.cpp:

(Inspector::JSJavaScriptCallFrame::evaluateWithScopeExtension):

inspector/ScriptCallStackFactory.cpp:

(Inspector::extractSourceInformationFromException):

runtime/ConsoleObject.cpp:

(JSC::valueToStringWithUndefinedOrNullCheck):
(JSC::valueOrDefaultLabelString):

runtime/DateConstructor.cpp:

(JSC::dateParse):

runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):

runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::sanitizedToString):

runtime/ErrorPrototype.cpp:

(JSC::errorProtoFuncToString):

runtime/InspectorInstrumentationObject.cpp:

(JSC::inspectorInstrumentationObjectLog):

runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

runtime/JSModuleLoader.cpp:

(JSC::JSModuleLoader::fetch):

runtime/ModuleLoaderPrototype.cpp:

(JSC::moduleLoaderPrototypeParseModule):

runtime/RegExpConstructor.cpp:

(JSC::regExpCreate):

runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoFuncToString):

runtime/StringPrototype.cpp:

(JSC::replaceUsingRegExpSearch):
(JSC::replaceUsingStringSearch):
(JSC::stringProtoFuncSlice):
(JSC::stringProtoFuncSplitFast):
(JSC::stringProtoFuncSubstr):
(JSC::stringProtoFuncLocaleCompare):
(JSC::stringProtoFuncBig):
(JSC::stringProtoFuncSmall):
(JSC::stringProtoFuncBlink):
(JSC::stringProtoFuncBold):
(JSC::stringProtoFuncFixed):
(JSC::stringProtoFuncItalics):
(JSC::stringProtoFuncStrike):
(JSC::stringProtoFuncSub):
(JSC::stringProtoFuncSup):
(JSC::stringProtoFuncFontcolor):
(JSC::stringProtoFuncFontsize):
(JSC::stringProtoFuncAnchor):
(JSC::stringProtoFuncLink):
(JSC::trimString):
(JSC::stringProtoFuncStartsWith):
(JSC::stringProtoFuncEndsWith):
(JSC::stringProtoFuncIncludes):
(JSC::builtinStringIncludesInternal):
(JSC::stringProtoFuncNormalize):

tools/JSDollarVMPrototype.cpp:

(JSC::functionPrint):

wasm/js/JSWebAssemblyCompileError.h:

(JSC::JSWebAssemblyCompileError::create):

wasm/js/JSWebAssemblyRuntimeError.h:

(JSC::JSWebAssemblyRuntimeError::create):

Source/WebCore:

bindings/js/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue):

bindings/js/JSAudioTrackCustom.cpp:

(WebCore::JSAudioTrack::setKind):
(WebCore::JSAudioTrack::setLanguage):

bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::JSCryptoAlgorithmDictionary::getAlgorithmIdentifier):

bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::setLocation):

bindings/js/JSDeviceMotionEventCustom.cpp:

(WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):

bindings/js/JSDeviceOrientationEventCustom.cpp:

(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):

bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):

bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::namedItem):

bindings/js/JSHTMLFormControlsCollectionCustom.cpp:

(WebCore::JSHTMLFormControlsCollection::namedItem):

bindings/js/JSHTMLInputElementCustom.cpp:

(WebCore::JSHTMLInputElement::setSelectionDirection):

bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::populateContextMenuItems):

bindings/js/JSMessageEventCustom.cpp:

(WebCore::handleInitMessageEvent):

bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql):

bindings/js/JSTextTrackCustom.cpp:

(WebCore::JSTextTrack::setLanguage):

bindings/js/JSVideoTrackCustom.cpp:

(WebCore::JSVideoTrack::setKind):
(WebCore::JSVideoTrack::setLanguage):

bindings/js/JSWebKitSubtleCryptoCustom.cpp:

(WebCore::cryptoKeyFormatFromJSValue):
(WebCore::cryptoKeyUsagesFromJSValue):

bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):

bindings/js/JSXSLTProcessorCustom.cpp:

(WebCore::JSXSLTProcessor::setParameter):
(WebCore::JSXSLTProcessor::getParameter):
(WebCore::JSXSLTProcessor::removeParameter):

bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):

bridge/c/c_utility.cpp:

(JSC::Bindings::convertValueToNPVariant):

bridge/testbindings.cpp:

(main):

Source/WebKit2:

WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):

7:31 AM Changeset in webkit [209800] by jh718.park@samsung.com

2 edits in trunk/Source/WebCore

[EFL] Fix debug build break since r207192. Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=165847

No new tests, no new behaviours.

In JSDOMBinding.h, JSClass::info() returns each js class's
"static const JSC::ClassInfo s_info"'s address.
It's static variable's address, so always non-null.

bindings/js/JSDOMBinding.h:

(WebCore::BindingCaller::callPromiseOperation):
(WebCore::BindingCaller::callOperation):
(WebCore::BindingCaller::setAttribute):
(WebCore::BindingCaller::attribute):

5:41 AM Changeset in webkit [209799] by clopez@igalia.com

2 edits in trunk/Tools

[GTK] Yasm is needed for building the JHBuild after r208940
https://bugs.webkit.org/show_bug.cgi?id=165837

Reviewed by Alejandro G. Castro.

gtk/install-dependencies: Yasm is needed for building libvpx.

4:22 AM Changeset in webkit [209798] by commit-queue@webkit.org

23 edits in trunk

Test infrastructure should allow to filter out text output before doing a comparison with the baseline
https://bugs.webkit.org/show_bug.cgi?id=161310

Patch by Youenn Fablet <youenn@apple.com> on 2016-12-14
Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

web-platform-tests/fetch/api/cors/cors-preflight.html: Adding a console log line to ensure the DumpJSConsoleLogInStdErr modifier works.

Tools:

Adding --dump-jsconsolelog-in-stderr test option for DRT and WTR.
When set, WTR and DRT output JS console log in the stderr and not the test output.
This allows removing potentially flaky information while still being able to read it for investigation.

Updated webkitpy infrastructure to use this test option in case of DumpJSConsoleLogInStdErr modifier.

Changes are covered by updating a fetch test to output console log and set its option to --dump-jsconsolelog-in-stderr in TestExpectations.
This test should have this option when fetch API will start logging resource loader errors.

DumpRenderTree/DumpRenderTree.h:

(TestCommand::TestCommand): Deleted.

DumpRenderTree/DumpRenderTreeCommon.cpp:

(parseInputLine):

DumpRenderTree/TestRunner.h:

(TestRunner::setDumpJSConsoleLogInStdErr):
(TestRunner::dumpJSConsoleLogInStdErr):

DumpRenderTree/mac/DumpRenderTree.mm:

(runTest):

DumpRenderTree/mac/UIDelegate.mm:

(-[UIDelegate webView:addMessageToConsole:withSource:]):

DumpRenderTree/win/DumpRenderTree.cpp:

(runTest):

DumpRenderTree/win/UIDelegate.cpp:

(UIDelegate::webViewAddMessageToConsole):

Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser._tokenize_line):

Scripts/webkitpy/port/driver.py:

(Driver._command_from_driver_input):

WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessageToPage):
(WTR::InjectedBundle::dumpToStdErr):

WebKitTestRunner/InjectedBundle/InjectedBundle.h:

(WTR::InjectedBundle::dumpJSConsoleLogInStdErr):

WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::InjectedBundlePage::willAddMessageToConsole):

WebKitTestRunner/TestController.cpp:

(WTR::parseInputLine):
(WTR::TestController::runTest):
(WTR::TestCommand::TestCommand): Deleted.

WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::invoke):
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):

WebKitTestRunner/TestInvocation.h:

(WTR::TestInvocation::setDumpJSConsoleLogInStdErr):

LayoutTests:

TestExpectations: Adding DumpJSConsoleLogInStdErr to the fetch modified test to ensure this modifier works as expected.

3:16 AM Changeset in webkit [209797] by eocanha@igalia.com

28 edits
1 copy
1 add in trunk

REGRESSION(r207879-207891): [GStreamer] Introduced many layout test failures and crashes, bots exiting early
https://bugs.webkit.org/show_bug.cgi?id=164022

Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Covered by existing tests.

page/Settings.cpp:

Added new setting to disable GStreamer players, so the selection of
MockMediaPlayerMediaSource can be forced for some tests, just like
it's already being done for the AVFoundation player in Mac.
(WebCore::Settings::setGStreamerEnabled):

page/Settings.h:

(WebCore::Settings::isGStreamerEnabled):

platform/graphics/MediaPlayer.cpp:

(WebCore::buildMediaEnginesVector):
Don't register GStreamer players when they're disabled.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::durationMediaTime):
Use doubles instead of floats.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

Use doubles instead of floats for m_durationAtEOS.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

Don't reset m_sample on videoSink drain, it causes too many problems.
(WebCore::MediaPlayerPrivateGStreamerBase::createVideoSink):

platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:

Removed unused methods.

platform/graphics/gstreamer/VideoSinkGStreamer.cpp:

Keep releasing m_sample on drain, but don't report the event
externally via signal anymore. The base player private isn't
listening to it anymore.
(webkitVideoSinkEvent):
(webkit_video_sink_class_init):

platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::parseDemuxerSrcPadCaps):
Check if the demuxer caps correspond to a supported codec.
(WebCore::AppendPipeline::didReceiveInitializationSegment):
Empty m_track is now legal and means unsupported codec.
(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsinkFromAnyThread):
Warn about more than one stream, but "support" it by ignoring it using
a black hole probe.
(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsink):
Also report the duration when it's detected for the first time. Invalid
stream types now mean that unsupported codecs have been detected.
Complete init segment processing in that case.
(WebCore::AppendPipeline::disconnectDemuxerSrcPadFromAppsinkFromAnyThread):
Disconnect black hole probe.
(WebCore::appendPipelineDemuxerBlackHolePadProbe): Ignore buffers.
(WebCore::appendPipelineDemuxerPadRemoved): New parameter used.

platform/graphics/gstreamer/mse/AppendPipeline.h:
platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::supportsCodecs):
Check supported codecs by matching against wildcard expressions.
(WebCore::MediaPlayerPrivateGStreamerMSE::supportsType):
Check for supported codecs.

platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:

New supportsCodecs() method.

platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.cpp:

(WebCore::MediaSourceClientGStreamerMSE::resetParserState):
Implemented parser resetting by aborting the AppendPipeline.

platform/graphics/gstreamer/mse/MediaSourceClientGStreamerMSE.h:

Added resetParserState().

platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:

(WebCore::SourceBufferPrivateGStreamer::resetParserState):
Implemented it.

testing/Internals.cpp:

(WebCore::Internals::initializeMockMediaSource):
Disable the GStreamer players when initializing the mock media source,
like it's already done for the AVFoundation player to force the
selection of MockMediaPlayerMediaSource.

Source/WebKit2:

Shared/WebPreferencesDefinitions.h:

New GStreamerEnabled preference, defaults to true.

WebProcess/WebPage/WebPage.cpp: Ditto.

(WebKit::WebPage::updatePreferences):

Source/WTF:

wtf/glib/GLibUtilities.h:

Added new macros to convert gulong to/from gpointer.

Tools:

Scripts/webkitperl/FeatureList.pm: Re-enable MEDIA_SOURCE for the GTK+ port.

LayoutTests:

media/media-source/media-source-resize-expected.txt:

Expect the resize event.

media/media-source/media-source-resize.html:

The test now succeeds no matter if the dimension is reported after
processing the init-segment (GTK+ case) or after the media segment
is processed (Mac case).

platform/gtk/TestExpectations:

Reenabled all the media/media-source tests except one.

platform/gtk/media/media-source/media-source-resize-expected.txt:

Copied from LayoutTests/media/media-source/media-source-resize-expected.txt.
The right dimensions are received earlier than in Mac.

2:36 AM Changeset in webkit [209796] by eocanha@igalia.com

3 edits in trunk/Source/WebCore

[GStreamer][MSE] Fix player private selection when MSE is enabled
https://bugs.webkit.org/show_bug.cgi?id=164116

Reviewed by Philippe Normand.

Covered by existing tests.

platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::load):

platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::load):

1:35 AM Changeset in webkit [209795] by barraclough@apple.com

21 edits
4 deletes in trunk/Source

MarkedBlock::marksConveyLivenessDuringMarking should take into account collection scope
https://bugs.webkit.org/show_bug.cgi?id=165741

Unreviewed rollout due to performance regression.

Source/JavaScriptCore:

CMakeLists.txt:
JavaScriptCore.xcodeproj/project.pbxproj:
heap/CellContainer.cpp: Removed.
heap/CellContainer.h:
heap/MarkedAllocator.cpp:

(JSC::MarkedAllocator::addBlock):
(JSC::MarkedAllocator::removeBlock):
(JSC::MarkedAllocator::dumpBits):

heap/MarkedAllocator.h:

(JSC::MarkedAllocator::forEachBitVector):
(JSC::MarkedAllocator::forEachBitVectorWithName):

heap/MarkedBlock.cpp:

heap/MarkedBlock.h:

(JSC::MarkedBlock::isMarked):
(JSC::MarkedBlock::markingVersion): Deleted.
(JSC::MarkedBlock::isMarkedRaw): Deleted.

heap/MarkedBlockInlines.h:

(JSC::MarkedBlock::marksConveyLivenessDuringMarking):

heap/SlotVisitor.cpp:

(JSC::SlotVisitor::appendJSCellOrAuxiliary):

runtime/Options.h:
runtime/StructureIDTable.h:

(JSC::StructureIDTable::get):
(JSC::StructureIDTable::size): Deleted.

Source/WTF:

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/DataLog.cpp:

(WTF::initializeLogFileOnce):
(WTF::initializeLogFile):
(WTF::dataFile):

wtf/DataLog.h:
wtf/LockedPrintStream.cpp: Removed.
wtf/LockedPrintStream.h: Removed.
wtf/PrintStream.cpp:

(WTF::PrintStream::printfVariableFormat): Deleted.
(WTF::PrintStream::begin): Deleted.
(WTF::PrintStream::end): Deleted.

wtf/PrintStream.h:

(WTF::PrintStream::print):
(WTF::PrintStream::println):
(WTF::PrintStream::atomically): Deleted.
(WTF::PrintStream::printImpl): Deleted.
(): Deleted.
(WTF::>::unpack): Deleted.
(WTF::FormatImpl::FormatImpl): Deleted.
(WTF::FormatImpl::dump): Deleted.
(WTF::format): Deleted.

wtf/RecursiveLockAdapter.h: Removed.
wtf/WordLock.cpp:
wtf/WordLock.h:

12:23 AM Changeset in webkit [209794] by barraclough@apple.com

39 edits
3 deletes in trunk

Source/WebCore:
Unreviewed, rolling out r209792.
https://bugs.webkit.org/show_bug.cgi?id=165841

Cause build failures (Requested by yusukesuzuki on #webkit).

Reverted changeset:

"Use JSValue::toWTFString instead of calling toString(exec)
and value(exec)"
https://bugs.webkit.org/show_bug.cgi?id=165795
http://trac.webkit.org/changeset/209792

Patch by Commit Queue <commit-queue@webkit.org> on 2016-12-13

LayoutTests:
ASSERTION FAILED: hasParserBlockingScript() seen with js/dom/modules/module-will-fire-beforeload.html
https://bugs.webkit.org/show_bug.cgi?id=164883

Patch by Yusuke Suzuki <Yusuke Suzuki> on 2016-12-13
Reviewed by Ryosuke Niwa.

platform/mac-wk2/TestExpectations:

Dec 13, 2016:

11:20 PM Changeset in webkit [209793] by commit-queue@webkit.org

48 edits in trunk/Source

Unreviewed, rolling out r209792.
https://bugs.webkit.org/show_bug.cgi?id=165841

Cause build failures (Requested by yusukesuzuki on #webkit).

Reverted changeset:

"Use JSValue::toWTFString instead of calling toString(exec)
and value(exec)"
https://bugs.webkit.org/show_bug.cgi?id=165795
http://trac.webkit.org/changeset/209792

11:02 PM Changeset in webkit [209792] by Yusuke Suzuki

48 edits in trunk/Source

Use JSValue::toWTFString instead of calling toString(exec) and value(exec)
https://bugs.webkit.org/show_bug.cgi?id=165795

Reviewed by Saam Barati.

Source/JavaScriptCore:

This patch mechanically replaces value.toString(exec)->value(exec) with toWTFString(exec).

API/JSValueRef.cpp:

(JSValueToStringCopy):

bindings/ScriptValue.cpp:

(Deprecated::ScriptValue::toString):

inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::reportAPIException):

inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::evaluateWithScopeExtension):

inspector/JSJavaScriptCallFrame.cpp:

(Inspector::JSJavaScriptCallFrame::evaluateWithScopeExtension):

inspector/ScriptCallStackFactory.cpp:

(Inspector::extractSourceInformationFromException):

runtime/ConsoleObject.cpp:

(JSC::valueToStringWithUndefinedOrNullCheck):
(JSC::valueOrDefaultLabelString):

runtime/DateConstructor.cpp:

(JSC::dateParse):

runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):

runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::sanitizedToString):

runtime/ErrorPrototype.cpp:

(JSC::errorProtoFuncToString):

runtime/InspectorInstrumentationObject.cpp:

(JSC::inspectorInstrumentationObjectLog):

runtime/JSCJSValue.cpp:

(JSC::JSValue::toWTFStringSlowCase):

runtime/JSGlobalObjectFunctions.cpp:

(JSC::globalFuncEval):

runtime/JSModuleLoader.cpp:

(JSC::JSModuleLoader::fetch):

runtime/ModuleLoaderPrototype.cpp:

(JSC::moduleLoaderPrototypeParseModule):

runtime/RegExpConstructor.cpp:

(JSC::regExpCreate):

runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoFuncToString):

runtime/StringPrototype.cpp:

tools/JSDollarVMPrototype.cpp:

(JSC::functionPrint):

wasm/js/JSWebAssemblyCompileError.h:

(JSC::JSWebAssemblyCompileError::create):

wasm/js/JSWebAssemblyRuntimeError.h:

(JSC::JSWebAssemblyRuntimeError::create):

Source/WebCore:

bindings/js/IDBBindingUtilities.cpp:

(WebCore::createIDBKeyFromValue):
(WebCore::getNthValueOnKeyPath): Deleted.
(WebCore::internalCreateIDBKeyFromScriptValueAndKeyPath): Deleted.
(WebCore::ensureNthValueOnKeyPath): Deleted.
(WebCore::canInjectNthValueOnKeyPath): Deleted.
(WebCore::injectIDBKeyIntoScriptValue): Deleted.
(WebCore::maybeCreateIDBKeyFromScriptValueAndKeyPath): Deleted.
(WebCore::canInjectIDBKeyIntoScriptValue): Deleted.
(WebCore::deserializeIDBValueToJSValue): Deleted.
(WebCore::scriptValueToIDBKey): Deleted.
(WebCore::idbKeyDataToScriptValue): Deleted.
(WebCore::createKeyPathArray): Deleted.
(WebCore::generateIndexKeyForValue): Deleted.

bindings/js/JSAudioTrackCustom.cpp:

(WebCore::JSAudioTrack::setKind):
(WebCore::JSAudioTrack::setLanguage):

bindings/js/JSCryptoAlgorithmDictionary.cpp:

(WebCore::JSCryptoAlgorithmDictionary::getAlgorithmIdentifier):

bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::setLocation):

bindings/js/JSDeviceMotionEventCustom.cpp:

(WebCore::JSDeviceMotionEvent::initDeviceMotionEvent):

bindings/js/JSDeviceOrientationEventCustom.cpp:

(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):

bindings/js/JSEventListener.cpp:

(WebCore::JSEventListener::handleEvent):
(WebCore::JSEventListener::virtualisAttribute): Deleted.
(WebCore::JSEventListener::operator==): Deleted.
(WebCore::eventHandlerAttribute): Deleted.
(WebCore::createEventListenerForEventHandlerAttribute): Deleted.
(WebCore::setEventHandlerAttribute): Deleted.
(WebCore::windowEventHandlerAttribute): Deleted.
(WebCore::setWindowEventHandlerAttribute): Deleted.
(WebCore::documentEventHandlerAttribute): Deleted.
(WebCore::setDocumentEventHandlerAttribute): Deleted.

bindings/js/JSHTMLAllCollectionCustom.cpp:

(WebCore::callHTMLAllCollection):
(WebCore::JSHTMLAllCollection::namedItem):

bindings/js/JSHTMLFormControlsCollectionCustom.cpp:

(WebCore::JSHTMLFormControlsCollection::namedItem):

bindings/js/JSHTMLInputElementCustom.cpp:

(WebCore::JSHTMLInputElement::setSelectionDirection):
(WebCore::JSHTMLInputElement::setSelectionRange): Deleted.

bindings/js/JSInspectorFrontendHostCustom.cpp:

(WebCore::populateContextMenuItems):
(WebCore::JSInspectorFrontendHost::showContextMenu): Deleted.

bindings/js/JSMessageEventCustom.cpp:

(WebCore::handleInitMessageEvent):

bindings/js/JSSQLTransactionCustom.cpp:

(WebCore::JSSQLTransaction::executeSql):

bindings/js/JSTextTrackCustom.cpp:

(WebCore::JSTextTrack::setLanguage):

bindings/js/JSVideoTrackCustom.cpp:

(WebCore::JSVideoTrack::setKind):
(WebCore::JSVideoTrack::setLanguage):

bindings/js/JSWebKitSubtleCryptoCustom.cpp:

(WebCore::cryptoKeyFormatFromJSValue):
(WebCore::cryptoKeyUsagesFromJSValue):

bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::send):
(WebCore::JSXMLHttpRequest::responseText): Deleted.
(WebCore::JSXMLHttpRequest::retrieveResponse): Deleted.

bindings/js/JSXSLTProcessorCustom.cpp:

(WebCore::JSXSLTProcessor::setParameter):
(WebCore::JSXSLTProcessor::getParameter):
(WebCore::JSXSLTProcessor::removeParameter):

bindings/js/ScheduledAction.cpp:

(WebCore::ScheduledAction::create):

bridge/c/c_utility.cpp:

(JSC::Bindings::convertValueToNPVariant):

bridge/testbindings.cpp:

(main):

inspector/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::buildObjectForEventListener):

Source/WebKit2:

WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:

(WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):

10:22 PM Changeset in webkit [209791] by Yusuke Suzuki

4 edits in trunk

ASSERTION FAILED: hasParserBlockingScript() seen with js/dom/modules/module-will-fire-beforeload.html
https://bugs.webkit.org/show_bug.cgi?id=164883

Reviewed by Ryosuke Niwa.

Source/WebCore:

This is *attempt to fix* patch since I cannot reproduce the crash reported in this issue.
One possible scenario of this crash is the following.

There is pending deferred scripts, that is not fetched yet.
Then, we start watching on the script. And stop document parser.
The document parser is stopped/detached by calling finishJSTest in beforeload.
At this critical timing, (2)'s script is fetched, and notifyFinished is called since it is watched.

In this patch, we ignore the script execution if the document parser is stopped / detached.
Previously, it goes into the wrong path. And it causes assertion failure.

html/parser/HTMLDocumentParser.cpp:

(WebCore::HTMLDocumentParser::notifyFinished):

LayoutTests:

platform/mac-wk2/TestExpectations:

10:09 PM Changeset in webkit [209790] by dbates@webkit.org

2 edits in trunk/Source/WebCore

Memory warning logging appears to capture resident footprint, missing compress/swap.
https://bugs.webkit.org/show_bug.cgi?id=165533
<rdar://problem/29318410>

Patch by Keith Rollin <Keith Rollin> on 2016-12-13
Reviewed by Daniel Bates.

Fix GTK build by adding an explicit constructor.

platform/MemoryPressureHandler.h:

(WebCore::MemoryPressureHandler::ReliefLogger::MemoryUsage::MemoryUsage):

8:18 PM Changeset in webkit [209789] by dbates@webkit.org

3 edits
8 adds in trunk

CSP: ws: and wss: blocked with connect-src *
https://bugs.webkit.org/show_bug.cgi?id=165804
<rdar://problem/28563643>

Reviewed by David Kilzer.

Source/WebCore:

Allow * to match ws: and wss:. This will make our behavior of * more closely conform
the behavior of * in the Content Security Policy Level 3 spec.,
<https://w3c.github.io/webappsec-csp/#match-url-to-source-expression> (Editor's Draft, 2 December 2016).

Tests: http/tests/security/contentSecurityPolicy/connect-src-star-secure-websocket-allowed.html

http/tests/security/contentSecurityPolicy/connect-src-star-websocket-allowed.html
http/tests/security/contentSecurityPolicy/default-src-star-secure-websocket-allowed.html
http/tests/security/contentSecurityPolicy/default-src-star-websocket-allowed.html

page/csp/ContentSecurityPolicySourceList.cpp:

(WebCore::ContentSecurityPolicySourceList::isProtocolAllowedByStar):

LayoutTests:

Add tests to ensure that * matches ws: and wss:.

http/tests/security/contentSecurityPolicy/connect-src-star-secure-websocket-allowed-expected.txt: Added.
http/tests/security/contentSecurityPolicy/connect-src-star-secure-websocket-allowed.html: Added.
http/tests/security/contentSecurityPolicy/connect-src-star-websocket-allowed-expected.txt: Added.
http/tests/security/contentSecurityPolicy/connect-src-star-websocket-allowed.html: Added.
http/tests/security/contentSecurityPolicy/default-src-star-secure-websocket-allowed-expected.txt: Added.
http/tests/security/contentSecurityPolicy/default-src-star-secure-websocket-allowed.html: Added.
http/tests/security/contentSecurityPolicy/default-src-star-websocket-allowed-expected.txt: Added.
http/tests/security/contentSecurityPolicy/default-src-star-websocket-allowed.html: Added.

7:24 PM Changeset in webkit [209788] by hyatt@apple.com

7 edits in trunk/Source/WebCore

[CSS Parser] Make CSSFunctionValue derive from CSSValueList
https://bugs.webkit.org/show_bug.cgi?id=165832

Reviewed by Dean Jackson.

With the old parser gone, we can now shrink CSSFunctionValue a bit by
having it derive from CSSValueList instead of having an extra member
that holds a value list of arguments. This is similar to the trick
already employed by WebkitCSSTransformValue.

css/CSSComputedStyleDeclaration.cpp:

(WebCore::specifiedValueForGridTrackSize):

css/CSSFunctionValue.cpp:

(WebCore::CSSFunctionValue::customCSSText):
(WebCore::CSSFunctionValue::CSSFunctionValue): Deleted.
(WebCore::CSSFunctionValue::equals): Deleted.
(WebCore::CSSFunctionValue::append): Deleted.

css/CSSFunctionValue.h:
css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertScrollSnapPoints):
(WebCore::StyleBuilderConverter::createGridTrackSize):

css/StyleResolver.cpp:

(WebCore::StyleResolver::createFilterOperations):

css/parser/CSSPropertyParser.cpp:

(WebCore::isGridTrackFixedSized):

6:39 PM Changeset in webkit [209787] by Chris Dumez

3 edits in trunk/Source/WebCore

Make Document a FrameDestructionObserver
https://bugs.webkit.org/show_bug.cgi?id=165810
<rdar://problem/29157645>

Reviewed by Ryosuke Niwa.

Make Document a FrameDestructionObserver to make sure Document::m_frame
is properly nulled out when a Frame gets destroyed.
Document::disconnectFromFrame() is supposed to be called before the Frame
gets destroyed so this also adds an assertion to try and identify places
where we fail to call it.

No new tests, no known reproduction case.

dom/Document.cpp:

(WebCore::Document::Document):
(WebCore::Document::disconnectFromFrame):
(WebCore::Document::frameDestroyed):

dom/Document.h:

(WebCore::Document::frame): Deleted.

6:39 PM Changeset in webkit [209786] by achristensen@apple.com

4 edits in trunk

Fix CMake build.

Source/WebKit2:

PlatformMac.cmake:

Tools:

DumpRenderTree/PlatformMac.cmake:

Define NS_RETURNS_RETAINED as nothing for now.

5:31 PM Changeset in webkit [209785] by sbarati@apple.com

8 edits
2 adds in trunk

WebAssembly: implement the elements section
https://bugs.webkit.org/show_bug.cgi?id=165715

Reviewed by Keith Miller.

JSTests:

wasm/Builder.js:

(export.default.Builder.prototype._registerSectionBuilders.switch.case.string_appeared_here.this.section):
(export.default.Builder.prototype._registerSectionBuilders.switch):

wasm/Builder_WebAssemblyBinary.js:

(const.emitters.Element):

wasm/function-tests/basic-element.js: Added.
wasm/js-api/element.js: Added.

(assertBadBinary):
(assertBadBinary.badInstantiation):

Source/JavaScriptCore:

This is a straight forward implementation of the Element
section in the Wasm spec:
https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md#element-section

There are a few ambiguities I encountered when implementing this, so I've
filed bugs against the Wasm design repo, and corresponding bugzilla bugs
for us to address after they've been discussed by the various Wasm folks:

wasm/WasmFormat.h:
wasm/WasmModuleParser.cpp:

(JSC::Wasm::ModuleParser::parseElement):
(JSC::Wasm::ModuleParser::parseInitExpr):
(JSC::Wasm::ModuleParser::parseData):

wasm/WasmModuleParser.h:
wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::evaluate):

4:20 PM Changeset in webkit [209784] by commit-queue@webkit.org

6 edits
2 adds in trunk

REGRESSION(r204163): Web Inspector: Page crashes when Inspector tries to load insecure SourceMap
https://bugs.webkit.org/show_bug.cgi?id=165806
<rdar://problem/28169025>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-12-13
Reviewed by Alex Christensen.

Source/WebCore:

Test: http/tests/inspector/network/loadResource-insecure-resource.html

inspector/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::loadResource):
DocumentThreadableLoader now triggers the ThreadableLoaderClient's didFail
callback, so this didFailLoaderCreation is now redundent and incorrect.

LayoutTests:

http/tests/inspector/network/loadResource-insecure-resource-expected.txt: Added.
http/tests/inspector/network/loadResource-insecure-resource.html: Added.
http/tests/inspector/network/resource-timing.html:
http/tests/inspector/resources/inspector-test.js:

(runTestHTTPS):

4:18 PM Changeset in webkit [209783] by hyatt@apple.com

2 edits in trunk/Source/WebCore

[CSS Parser] Enhance fast path translate transforms to allow percentages
https://bugs.webkit.org/show_bug.cgi?id=165822

Reviewed by Simon Fraser.

css/parser/CSSParserFastPaths.cpp:

(WebCore::parseTransformTranslateArguments):

3:37 PM Changeset in webkit [209782] by jer.noble@apple.com

6 edits in trunk

Fullscreen in WebKit2 does not restore topContentInset upon exiting; leaves top of page not visible
https://bugs.webkit.org/show_bug.cgi?id=165697

Source/WebKit2:

Delegate the values of topContentInset() from WebViewImpl (used by WKWebView and WKView) to the
WebPageProxy, so that setting the topContentInset() on WebPageProxy is reflected in the getters
for the two view classes.

Reviewed by Tim Horton.

UIProcess/Cocoa/WebViewImpl.h:

(WebKit::WebViewImpl::topContentInset): Deleted.

UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::updateContentInsetsIfAutomatic):
(WebKit::WebViewImpl::topContentInset):
(WebKit::WebViewImpl::setTopContentInset):
(WebKit::WebViewImpl::dispatchSetTopContentInset):

UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController enterFullScreen:]):
(-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
(-[WKFullScreenWindowController _saveTopContentInset]): Deleted.
(-[WKFullScreenWindowController _restoreTopContentInset]): Deleted.

Tools:

Reviewed by Tim Horton.

TestWebKitAPI/Tests/WebKit2Cocoa/FullscreenTopContentInset.mm:

(TestWebKitAPI::TEST):

3:24 PM Changeset in webkit [209781] by Ryan Haddad

2 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html after r209777.

Unreviewed test gardening.

platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:

3:22 PM Changeset in webkit [209780] by rniwa@webkit.org

5 edits
4 adds in trunk

:hover rule causes a single tap to not activate a slotted anchor element
https://bugs.webkit.org/show_bug.cgi?id=165551

Reviewed by Antti Koivisto.

Source/WebCore:

Fixed a bug in ancestorRespondingToClickEvents that we were traversing the ancestor nodes without taking
shadow roots and slots into account. This prevented tapping on a text node assigned to a slot inside
an anchor element to activate the hyperlink on iOS.

This bug was supposed to be fixed in r206605, and it was still broken on iOS due to the bug in
ancestorRespondingToClickEvents. It is now tested by click-text-inside-linked-slot.html.

Tests: fast/shadow-dom/click-on-slotted-anchor-with-hover.html

fast/shadow-dom/click-text-inside-linked-slot.html

page/ios/FrameIOS.mm:

(WebCore::ancestorRespondingToClickEvents):
(WebCore::Frame::qualifyingNodeAtViewportLocation):

LayoutTests:

Added a test for tapping on an anchor element assigned to a slot, which has been fixed in r209065.

Also added a new helper JS wrapepr, UIHelper, defined inside LayoutTests/resources/js-helper.js
to provide an abstraction around EventSender and UIScriptController.

Fixed click-text-inside-linked-slot.html on iOS using UIHelper.

fast/shadow-dom/click-on-slotted-anchor-with-hover-expected.txt: Added.
fast/shadow-dom/click-on-slotted-anchor-with-hover.html: Added.
fast/shadow-dom/click-text-inside-linked-slot.html:
platform/ios-simulator/fast/shadow-dom/click-text-inside-linked-slot-expected.txt: Added.
resources/ui-helper.js: Added.

(window.UIHelper.isIOS):
(window.UIHelper.activateAt.return.new.Promise):
(window.UIHelper.activateAt):
(window.UIHelper.wait):
(window.UIHelper):

platform/ios-simulator-wk2/TestExpectations: Skip the test in the open source iOS's WebKit2.

2:56 PM Changeset in webkit [209779] by Brent Fulgham

4 edits in trunk/Source/WebKit2

[Mac][WK2] Tighten Keychain directory access
https://bugs.webkit.org/show_bug.cgi?id=165818
<rdar://problem/16863857>

Reviewed by Anders Carlsson.

Lock down Keychain directory access to just the file-read-data, file-read-metadata, and
file-write-data operations we actually need.

NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
WebProcess/com.apple.WebProcess.sb.in:

2:27 PM Changeset in webkit [209778] by jfbastien@apple.com

2 edits in trunk/Source/WTF

std::expected: fix rvalue forwarding issues
https://bugs.webkit.org/show_bug.cgi?id=165812

Reviewed by Mark Lam.

wtf/Expected.h:

(WTF::UnexpectedType::UnexpectedType):
(WTF::ExpectedDetail::Base::Base):
(WTF::Expected::Expected):

2:15 PM Changeset in webkit [209777] by hyatt@apple.com

51 edits
6 deletes in trunk

[CSS Parser] Eliminate SVGPaint and SVGColor
https://bugs.webkit.org/show_bug.cgi?id=165819

Reviewed by Dean Jackson.

Source/WebCore:

Remove SVGColor and SVGPaint CSS values from the tree. The new parser
already stopped making these values when parsing, so all that's left
is to make sure computed style doesn't use these values either.

We are the only browser engine to support these CSS values, they see no use
on the Web, and they're already gone at the parsing level, so it's time
to remove these interfaces from our tree.

CMakeLists.txt:
DerivedSources.make:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSCSSValueCustom.cpp:

(WebCore::toJSNewlyCreated):

css/CSSComputedStyleDeclaration.h:
css/CSSValue.cpp:

(WebCore::CSSValue::equals):
(WebCore::CSSValue::cssText):
(WebCore::CSSValue::destroy):
(WebCore::CSSValue::cloneForCSSOM):

css/CSSValue.h:

(WebCore::CSSValue::isSubtypeExposedToCSSOM):
(WebCore::CSSValue::isSVGColor): Deleted.
(WebCore::CSSValue::isSVGPaint): Deleted.

css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::adjustSVGPaintForCurrentColor):
(WebCore::ComputedStyleExtractor::svgPropertyValue):

css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertSVGColor):

css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyValueFill):
(WebCore::StyleBuilderCustom::applyValueStroke):

page/animation/CSSPropertyAnimation.cpp:

(WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):

rendering/style/RenderStyle.h:

(WebCore::RenderStyle::fillPaintType):
(WebCore::RenderStyle::setFillPaintColor):
(WebCore::RenderStyle::strokePaintType):
(WebCore::RenderStyle::setStrokePaintColor):

rendering/style/SVGRenderStyle.h:

(WebCore::SVGRenderStyle::initialFillPaintType):
(WebCore::SVGRenderStyle::initialStrokePaintType):
(WebCore::SVGRenderStyle::setFillPaint):
(WebCore::SVGRenderStyle::setStrokePaint):
(WebCore::SVGRenderStyle::fillPaintType):
(WebCore::SVGRenderStyle::strokePaintType):
(WebCore::SVGRenderStyle::visitedLinkFillPaintType):
(WebCore::SVGRenderStyle::visitedLinkStrokePaintType):
(WebCore::SVGRenderStyle::hasStroke):
(WebCore::SVGRenderStyle::hasFill):

rendering/style/SVGRenderStyleDefs.h:
rendering/svg/RenderSVGResource.cpp:

(WebCore::requestPaintingResource):

rendering/svg/SVGResources.cpp:

(WebCore::paintingResourceFromSVGPaint):

svg/SVGAllInOne.cpp:
svg/SVGAnimatedColor.cpp:

(WebCore::SVGAnimatedColorAnimator::constructFromString):
(WebCore::parseColorFromString):
(WebCore::SVGAnimatedColorAnimator::calculateDistance):

svg/SVGAnimatedType.cpp:

(WebCore::SVGAnimatedType::setValueAsString):

svg/SVGAnimatedType.h:
svg/SVGColor.cpp: Removed.
svg/SVGColor.h: Removed.
svg/SVGColor.idl: Removed.
svg/SVGFEDiffuseLightingElement.cpp:
svg/SVGFESpecularLightingElement.cpp:
svg/SVGPaint.cpp: Removed.
svg/SVGPaint.h: Removed.
svg/SVGPaint.idl: Removed.

LayoutTests:

fast/dom/Window/resources/window-properties.js:
platform/mac-yosemite/js/dom/global-constructors-attributes-expected.txt:
platform/mac/fast/dom/Window/window-lookup-precedence-expected.txt:
platform/mac/js/dom/global-constructors-attributes-expected.txt:
svg/animations/additive-type-by-animation-expected.txt:
svg/animations/animate-color-calcMode-discrete-expected.txt:
svg/animations/animate-color-fill-currentColor-expected.txt:
svg/animations/animate-color-fill-from-by-expected.txt:
svg/animations/animate-color-transparent-expected.txt:
svg/animations/animate-currentColor-expected.txt:
svg/animations/animate-dynamic-update-attributeName-expected.txt:
svg/animations/animate-elem-03-t-drt-expected.txt:
svg/animations/animate-inherit-css-property-expected.txt:
svg/animations/attributeTypes-expected.txt:
svg/animations/resources/SVGAnimationTestCase.js:

(expectColor):

svg/animations/script-tests/animate-color-fill-currentColor.js:

(sample1):
(sample2):
(sample3):

svg/animations/script-tests/animate-color-fill-from-by.js:

(sample1):
(sample2):
(sample3):

svg/css/getComputedStyle-basic-expected.txt:
svg/css/rect-system-color-expected.txt:
svg/css/rect-system-color.xhtml:
svg/custom/global-constructors-expected.txt:
svg/custom/js-svg-constructors-expected.txt:
svg/custom/js-svg-constructors.svg:
svg/custom/script-tests/global-constructors.js:

2:11 PM Changeset in webkit [209776] by achristensen@apple.com

2 edits in trunk/Source/WebCore

Restore NSURLRequest's default time interval to match behavior before NSURLSession adoption
https://bugs.webkit.org/show_bug.cgi?id=165821
<rdar://problem/28492939>

Reviewed by Brady Eidson.

Before adopting NSURLSession, iOS used CFURLConnection, not NSURLConnection.
iOS used to have a default timeout of INT_MAX and it now has a default timeout of 0, which means use the
default NSURLRequest timeout, which is 60 seconds. This is not enough for some slow mobile networks,
so we want to match behavior of our CFURLConnection code here.

platform/network/ResourceRequestBase.cpp:

Use INT_MAX as the default timeout of requests on iOS.

2:08 PM Changeset in webkit [209775] by aestes@apple.com

7 edits in trunk

[Cocoa] Implement -shouldInsertText: on WKWebProcessPlugInEditingDelegate
https://bugs.webkit.org/show_bug.cgi?id=165785
<rdar://problem/26929398>

Reviewed by Darin Adler.

Source/WebKit2:

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInEditingDelegate.h: Defined

WKEditorInsertAction and declared
-_webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:.

WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:

(toWK): Added. Mapped a WebCore::EditorInsertAction to a WKEditorInsertAction.
(-[WKWebProcessPlugInBrowserContextController _setEditingDelegate:]): Implemented
EditorClient::shouldInsertText() by calling
-_webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction: with
the text, wrapped range handle, and action. Added shouldInsertText to DelegateMethods and
initialized it according to whether the delegate responds to shouldInsertText:.

Tools:

TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegate.mm:

(-[BundleEditingDelegateRemoteObject shouldInsertText:replacingRange:givenAction:]): Added
expectations for the text, range, and action.
(TEST): Set the "EditingDelegateShouldInsertText" bundle parameter to NO so that the plug-in
will return NO in -_webProcessPlugInBrowserContextController:willInsertText:. Added a
plain-text string to the pasteboard, executed a paste action, and verified that the selected
text in the web view did not change.

TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:

(-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]): Set
_editingDelegateShouldInsertText according to the "EditingDelegateShouldInsertText" bundle
parameter.
(-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:shouldInsertText:replacingRange:givenAction:]):
Added. Called -shouldInsertText:replacingRange:givenAction: on the remote object proxy
and returned the value of _editingDelegateShouldInsertText.

TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegateProtocol.h: Declared

-shouldInsertText:replacingRange:givenAction:.

2:05 PM Changeset in webkit [209774] by Ryan Haddad

2 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html after r209760.

Unreviewed test gardening.

platform/mac/js/dom/global-constructors-attributes-expected.txt:

12:44 PM Changeset in webkit [209773] by Chris Dumez

6 edits in trunk

Unreviewed, rolling out r209544.

Looks like r209489 did not cause the performance regression
after all

Reverted changeset:

"Unreviewed, rolling out r209489."
https://bugs.webkit.org/show_bug.cgi?id=165550
http://trac.webkit.org/changeset/209544

12:41 PM Changeset in webkit [209772] by beidson@apple.com

1 edit
1 add in trunk/PerformanceTests

Add a PerfTest targeting IDBObjectStore.get().
https://bugs.webkit.org/show_bug.cgi?id=165816

Reviewed by Alex Christensen.

IndexedDB/objectstore-get.html: Added.

12:32 PM Changeset in webkit [209771] by sbarati@apple.com

27 edits
4 adds in trunk

WebAssembly: implement the table section and table import
https://bugs.webkit.org/show_bug.cgi?id=165716

Reviewed by Keith Miller.

JSTests:

wasm/Builder.js:

(const._importMemoryContinuation):
(const._importTableContinuation):
(export.default.Builder.prototype._registerSectionBuilders.switch.case.string_appeared_here.this.section):
(const._importMemoryContinuation.section): Deleted.
(const): Deleted.
(const._importMemoryContinuation.assert): Deleted.

wasm/Builder_WebAssemblyBinary.js:

(const.putResizableLimits):
(const.putTable):
(const.emitters.Import):
(const.emitters.Table):

wasm/function-tests/call-indirect-params.js:
wasm/function-tests/call-indirect.js:
wasm/function-tests/table-basic-2.js: Added.

(import.Builder.from.string_appeared_here.import.as.assert.from.string_appeared_here.makeInstance):
(func):

wasm/function-tests/table-basic.js: Added.

(import.Builder.from.string_appeared_here.import.as.assert.from.string_appeared_here.makeInstance):

wasm/js-api/call-indirect-results.js:

(const.wasmModuleWhichImportJS): Deleted.
(MonomorphicImport): Deleted.

wasm/js-api/call-indirect.js:

(const.wasmModuleWhichImportJS):
(const.makeTable):
(Polyphic2Import):
(VirtualImport):
(MonomorphicImport): Deleted.

wasm/js-api/table.js: Added.

(assertBadBinary):
(assert.truthy):
(assertBadTable):
(assertBadTableImport):
(assertBadBinary.assertBadTableInstance):
(assertBadTableInstance):
(new.WebAssembly.Table):

wasm/js-api/test_basic_api.js:

(const.c.in.constructorProperties.switch):

Source/JavaScriptCore:

This patch implements the Table space for wasm:
https://github.com/WebAssembly/design/blob/master/BinaryEncoding.md#table-section

It only implements defining and importing a table. The bulk
of this patch is implementing the various wasm Table prototype
methods and the underlying Table object:
https://github.com/WebAssembly/design/blob/master/JS.md#webassemblytable-constructor

This patch also fixes a bug in our implementation with call_indirect.
We initially implemented call_indirect as a way to call functions that
are imported or defined in the module. This was the wrong
interpretation of the spec. Instead, call_indirect can only index into
the table index space.

JavaScriptCore.xcodeproj/project.pbxproj:
wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::addCallIndirect):
(JSC::Wasm::parseAndCompile):

wasm/WasmFormat.h:

(JSC::Wasm::TableInformation::TableInformation):
(JSC::Wasm::TableInformation::operator bool):
(JSC::Wasm::TableInformation::isImport):
(JSC::Wasm::TableInformation::initial):
(JSC::Wasm::TableInformation::maximum):
(JSC::Wasm::CallableFunction::CallableFunction):

wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser<Context>::parseExpression):

wasm/WasmModuleParser.cpp:

(JSC::Wasm::ModuleParser::parseImport):
(JSC::Wasm::ModuleParser::parseResizableLimits):
(JSC::Wasm::ModuleParser::parseTableHelper):
(JSC::Wasm::ModuleParser::parseTable):
(JSC::Wasm::ModuleParser::parseMemoryHelper):
(JSC::Wasm::ModuleParser::parseExport):

wasm/WasmModuleParser.h:
wasm/js/JSWebAssemblyHelpers.h: Added.

(JSC::toNonWrappingUint32):

wasm/js/JSWebAssemblyInstance.cpp:

(JSC::JSWebAssemblyInstance::visitChildren):

wasm/js/JSWebAssemblyInstance.h:

(JSC::JSWebAssemblyInstance::table):
(JSC::JSWebAssemblyInstance::setTable):
(JSC::JSWebAssemblyInstance::offsetOfTable):

wasm/js/JSWebAssemblyTable.cpp:

(JSC::JSWebAssemblyTable::create):
(JSC::JSWebAssemblyTable::JSWebAssemblyTable):
(JSC::JSWebAssemblyTable::visitChildren):
(JSC::JSWebAssemblyTable::grow):
(JSC::JSWebAssemblyTable::clearFunction):
(JSC::JSWebAssemblyTable::setFunction):

wasm/js/JSWebAssemblyTable.h:

(JSC::JSWebAssemblyTable::maximum):
(JSC::JSWebAssemblyTable::size):
(JSC::JSWebAssemblyTable::getFunction):
(JSC::JSWebAssemblyTable::offsetOfSize):
(JSC::JSWebAssemblyTable::offsetOfFunctions):
(JSC::JSWebAssemblyTable::isValidSize):

wasm/js/WebAssemblyFunction.cpp:

(JSC::WebAssemblyFunction::call):
(JSC::WebAssemblyFunction::create):
(JSC::WebAssemblyFunction::visitChildren):
(JSC::WebAssemblyFunction::finishCreation):

wasm/js/WebAssemblyFunction.h:

(JSC::WebAssemblyFunction::signature):
(JSC::WebAssemblyFunction::wasmEntrypoint):
(JSC::WebAssemblyFunction::webAssemblyCallee): Deleted.

wasm/js/WebAssemblyInstanceConstructor.cpp:

(JSC::constructJSWebAssemblyInstance):

wasm/js/WebAssemblyMemoryConstructor.cpp:

(JSC::constructJSWebAssemblyMemory):

wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::finishCreation):
(JSC::WebAssemblyModuleRecord::link):

wasm/js/WebAssemblyTableConstructor.cpp:

(JSC::constructJSWebAssemblyTable):

wasm/js/WebAssemblyTablePrototype.cpp:

(JSC::getTable):
(JSC::webAssemblyTableProtoFuncLength):
(JSC::webAssemblyTableProtoFuncGrow):
(JSC::webAssemblyTableProtoFuncGet):
(JSC::webAssemblyTableProtoFuncSet):
(JSC::WebAssemblyTablePrototype::create):
(JSC::WebAssemblyTablePrototype::finishCreation):

wasm/js/WebAssemblyTablePrototype.h:

12:24 PM Changeset in webkit [209770] by Ryan Haddad

2 edits in trunk/LayoutTests

Remove ios-simulator-wk2 pass expectation for a directory that requires touch events.
https://bugs.webkit.org/show_bug.cgi?id=165787

Unreviewed test gardening.

platform/ios-simulator-wk2/TestExpectations:

12:23 PM Changeset in webkit [209769] by commit-queue@webkit.org

2 edits in trunk/Source/WebKit2

NSArray leaks seen in Safari, allocated under WKIconDatabaseTryCopyCGImageArrayForURL
https://bugs.webkit.org/show_bug.cgi?id=165809

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2016-12-13
Reviewed by Dan Bernstein.

UIProcess/API/C/cg/WKIconDatabaseCG.cpp:

(WKIconDatabaseTryCopyCGImageArrayForURL):
Avoid an extra retain on already newly created array.

12:18 PM Changeset in webkit [209768] by Ryan Haddad

2 edits in trunk/LayoutTests

Marking two scroll-to-fragid tests as flaky on ios-simulator.

Unreviewed test gardening.

platform/ios-simulator-wk2/TestExpectations:

12:14 PM Changeset in webkit [209767] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Add null checks to opaque root APIs.

Rubber stamped by Saam Barati.

If we got a crash report about null in the opaque root HashSet, we would probably not
celebrate how great it is that we found out about a new race - instead we would probably
be annoyed that null wasn't just silently ignored.

heap/SlotVisitor.cpp:

(JSC::SlotVisitor::addOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRoot):
(JSC::SlotVisitor::containsOpaqueRootTriState):

11:54 AM Changeset in webkit [209766] by fpizlo@apple.com

27 edits in trunk/Source

Make opaque root scanning truly constraint-based
https://bugs.webkit.org/show_bug.cgi?id=165760

Reviewed by Saam Barati.
Source/JavaScriptCore:

We have bugs when visitChildren() changes its mind about what opaque root to add, since
we don't have barriers on opaque roots. This supposedly once worked for generational GC,
and I started adding more barriers to support concurrent GC. But I think that the real
bug here is that we want the JSObject->OpaqueRoot to be evaluated as a constraint that
participates in the fixpoint. A constraint is different from the normal visiting in that
the GC will not wait for a barrier to rescan the object.

So, it's now possible for any visitChildren() method to become a constraint by calling
slotVisitor.rescanAsConstraint(). Because opaque roots are constraints, addOpaqueRoot()
does rescanAsConstraint() for you.

The constraint set is simply a HashSet<JSCell*> that accumulates with every
rescanAsConstraint() call and is only cleared at the start of full GC. This trivially
resolves most classes of GC bugs that would have arisen from opaque roots being changed
in a way that the GC did not anticipate.

Looks like this is perf-neutral.

heap/Heap.cpp:

(JSC::Heap::markToFixpoint):
(JSC::Heap::setMutatorShouldBeFenced):
(JSC::Heap::writeBarrierOpaqueRootSlow): Deleted.
(JSC::Heap::addMutatorShouldBeFencedCache): Deleted.

heap/Heap.h:
heap/HeapInlines.h:

(JSC::Heap::writeBarrierOpaqueRoot): Deleted.

heap/MarkedSpace.cpp:

(JSC::MarkedSpace::visitWeakSets):

heap/MarkedSpace.h:
heap/SlotVisitor.cpp:

(JSC::SlotVisitor::visitChildren):
(JSC::SlotVisitor::visitSubsequently):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::addOpaqueRoot):
(JSC::SlotVisitor::rescanAsConstraint):
(JSC::SlotVisitor::mergeIfNecessary):
(JSC::SlotVisitor::mergeOpaqueRootsAndConstraints):
(JSC::SlotVisitor::mergeOpaqueRootsIfNecessary): Deleted.

heap/SlotVisitor.h:
heap/SlotVisitorInlines.h:

(JSC::SlotVisitor::reportExtraMemoryVisited):
(JSC::SlotVisitor::reportExternalMemoryVisited):
(JSC::SlotVisitor::didNotRace):

heap/WeakBlock.cpp:

(JSC::WeakBlock::specializedVisit):
(JSC::WeakBlock::visit):

heap/WeakBlock.h:
heap/WeakSet.h:

(JSC::WeakSet::visit):

Source/WebCore:

No new tests yet. I think that writing tests for this is a big investigation:
https://bugs.webkit.org/show_bug.cgi?id=165808

Remove the previous advancing wavefront DOM write barrier. I don't think this will scale
very well. It's super confusing.

This change makes it so that visitChildren can become a GC constraint that executes as
part of the fixpoint. This changes all WebCore visitChildren methods that do opaque
roots into constraints.

bindings/js/CommonVM.cpp:

(WebCore::commonVMSlow):
(WebCore::writeBarrierOpaqueRootSlow): Deleted.

bindings/js/CommonVM.h:

(WebCore::writeBarrierOpaqueRoot): Deleted.

bindings/js/JSAttrCustom.cpp:

(WebCore::JSAttr::visitAdditionalChildren):

bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::visitAdditionalChildren):

bindings/js/JSIDBCursorCustom.cpp:

(WebCore::JSIDBCursor::visitAdditionalChildren):

bindings/js/JSMessageChannelCustom.cpp:

(WebCore::JSMessageChannel::visitAdditionalChildren):

bindings/js/JSMessagePortCustom.cpp:

(WebCore::JSMessagePort::visitAdditionalChildren):

bindings/js/JSNodeIteratorCustom.cpp:

(WebCore::JSNodeIterator::visitAdditionalChildren):

bindings/js/JSTextTrackCueCustom.cpp:

(WebCore::JSTextTrackCue::visitAdditionalChildren):

bindings/js/JSTreeWalkerCustom.cpp:

(WebCore::JSTreeWalker::visitAdditionalChildren):

bindings/js/JSWorkerGlobalScopeCustom.cpp:

(WebCore::JSWorkerGlobalScope::visitAdditionalChildren):

bindings/js/JSXMLHttpRequestCustom.cpp:

(WebCore::JSXMLHttpRequest::visitAdditionalChildren):

bindings/js/JSXPathResultCustom.cpp:

(WebCore::JSXPathResult::visitAdditionalChildren):

dom/ContainerNodeAlgorithms.cpp:

(WebCore::notifyChildNodeInserted):
(WebCore::notifyChildNodeRemoved):

11:44 AM Changeset in webkit [209765] by beidson@apple.com

1 edit
1 add in trunk/PerformanceTests

Add a PerfTest targeting IDBIndex.get().
https://bugs.webkit.org/show_bug.cgi?id=165803

Reviewed by Alex Christensen.

IndexedDB/index-get.html: Added.

11:38 AM Changeset in webkit [209764] by commit-queue@webkit.org

105 edits
14 deletes in trunk

Unreviewed, rolling out r209725.
https://bugs.webkit.org/show_bug.cgi?id=165811

"Broke ARMv7 builds" (Requested by msaboff on #webkit).

Reverted changeset:

"REGRESSION(r209653): speedometer crashes making virtual slow
path tailcalls"
https://bugs.webkit.org/show_bug.cgi?id=165748
http://trac.webkit.org/changeset/209725

11:28 AM Changeset in webkit [209763] by fpizlo@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, revert the collectorPermittedIdleRatio back to 0 because of 100MB
regression on membuster. Also, it didn't seem to help perf.

runtime/Options.h:

11:26 AM Changeset in webkit [209762] by Ryan Haddad

2 edits in trunk/LayoutTests

Skip fast/events/page-visibility-onvisibilitychange.html on ios-simulator.
https://bugs.webkit.org/show_bug.cgi?id=165799

Unreviewed test gardening.

platform/ios-simulator/TestExpectations:

11:15 AM Changeset in webkit [209761] by jfbastien@apple.com

6 edits in trunk/Source

[WTF] Turn tryMakeString(), makeString() into variadic templates
https://bugs.webkit.org/show_bug.cgi?id=147142

Reviewed by Mark Lam.

Source/JavaScriptCore:

runtime/JSStringBuilder.h:

(JSC::jsMakeNontrivialString): remove WTF:: prefix, it isn't needed anymore

runtime/Lookup.cpp:

(JSC::reifyStaticAccessor): remove WTF:: prefix, it isn't needed anymore

runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncToString): remove WTF:: prefix, it isn't needed anymore

Source/WTF:

I wrote this patch while improving WebAssembly's error messages,
and only found this bug afterwards. My implementation does the
bare minimum to make this code variadic without changing
behavior. I think it's better to go with this baby step first, and
improve the code later.

Notable, for my WebAssembly patch I also taught the code to handle
integers and other types (including WebAssembly types). A
follow-up could rely on ADL magic to pretty-format these other
types.

wtf/text/StringConcatenate.h:

(WTF::sumWithOverflow): This unconditionally does the sum for all
inputs, which the compiler is more likely to appreciate (because
it's the common case) compared to testing for overflow and bailing
on each addition
(WTF::are8Bit): are: the plural of is!
(WTF::makeStringAccumulator): accumulate strings
(WTF::tryMakeStringFromAdapters): a small helper which creates the string adapters
(WTF::tryMakeString): expose out of WTF, since it's part of this file's used API
(WTF::makeString): make it variadic

10:47 AM Changeset in webkit [209760] by weinig@apple.com

14 edits
3 adds
1 delete in trunk

[WebIDL] Remove use of Dictionary in ApplePaySession
https://bugs.webkit.org/show_bug.cgi?id=165787

Reviewed by Anders Carlsson.

Source/WebCore:

First take at generating the bindings for ApplePaySession and removing
all use of Dictionary.

Removes all use of Dictionary!
Removes use of logging errors to the console with improved Exception messages.
Use ExceptionOr extensively to pass exception state.

Still to do:

Reconcile / merge ApplePaySession::PaymentRequest with WebCore::PaymentRequest and all the sub-objects held within.
Remove PaymentRequestValidator entirely, merging validation into the validation we already do in ApplePaySession.cpp
Make ApplePayEvents use generated dictionary creation code.

Test: http/tests/ssl/applepay/ApplePaySession.html

Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidate):
(WebCore::canCallApplePaySessionAPIs):
(WebCore::ApplePaySession::create):
(WebCore::ApplePaySession::ApplePaySession):
(WebCore::ApplePaySession::supportsVersion):
(WebCore::ApplePaySession::canMakePayments):
(WebCore::ApplePaySession::canMakePaymentsWithActiveCard):
(WebCore::ApplePaySession::openPaymentSetup):
(WebCore::ApplePaySession::begin):
(WebCore::ApplePaySession::completeMerchantValidation):
(WebCore::ApplePaySession::completeShippingMethodSelection):
(WebCore::ApplePaySession::completeShippingContactSelection):
(WebCore::ApplePaySession::completePaymentMethodSelection):
(WebCore::ApplePaySession::didSelectShippingMethod):
(WebCore::createContactFields): Deleted.
(WebCore::toLineItemType): Deleted.
(WebCore::isValidLineItemPropertyName): Deleted.
(WebCore::createLineItem): Deleted.
(WebCore::createLineItems): Deleted.
(WebCore::createMerchantCapabilities): Deleted.
(WebCore::createSupportedNetworks): Deleted.
(WebCore::toShippingType): Deleted.
(WebCore::isValidShippingMethodPropertyName): Deleted.
(WebCore::createShippingMethod): Deleted.
(WebCore::createShippingMethods): Deleted.
(WebCore::isValidPaymentRequestPropertyName): Deleted.
(WebCore::createPaymentRequest): Deleted.

Modules/applepay/ApplePaySession.h:

Replace hand written dictionary extraction code with autogenerated code
and hand written additional validation.

Modules/applepay/ApplePaySession.idl:

Add helper dictionaries and enums.

Modules/applepay/PaymentRequestValidator.cpp:

(WebCore::PaymentRequestValidator::validate):
(WebCore::PaymentRequestValidator::validateTotal):
(WebCore::validateCountryCode):
(WebCore::validateCurrencyCode):
(WebCore::validateMerchantCapabilities):
(WebCore::validateSupportedNetworks):
(WebCore::validateShippingMethod):
(WebCore::validateShippingMethods):
(WebCore::PaymentRequestValidator::PaymentRequestValidator): Deleted.
(WebCore::PaymentRequestValidator::~PaymentRequestValidator): Deleted.
(WebCore::PaymentRequestValidator::validateCountryCode): Deleted.
(WebCore::PaymentRequestValidator::validateCurrencyCode): Deleted.
(WebCore::PaymentRequestValidator::validateMerchantCapabilities): Deleted.
(WebCore::PaymentRequestValidator::validateShippingMethod): Deleted.
(WebCore::PaymentRequestValidator::validateSupportedNetworks): Deleted.
(WebCore::PaymentRequestValidator::validateShippingMethods): Deleted.

Modules/applepay/PaymentRequestValidator.h:

Instead of reporting the validation errors to the console, pass them in the exception.
This allows us to remove the window member, and move the helpers to the implementation
file as statics.

WebCore.xcodeproj/project.pbxproj:

Remove file.

bindings/generic/IDLTypes.h:

(WebCore::IDLObject::nullValue):
(WebCore::IDLObject::isNullValue):
(WebCore::IDLObject::extractValueFromNullable):
Add nullability traits for IDLObject.

bindings/js/JSApplePaySessionCustom.cpp:

Removed.

Tools:

WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::initializeWebViewConfiguration):
(WTR::TestController::platformCreateWebView):
Enable ApplePay for the tests (where supported).

LayoutTests:

http/tests/ssl/applepay: Added.
http/tests/ssl/applepay/ApplePaySession-expected.txt: Added.
http/tests/ssl/applepay/ApplePaySession.html: Added.

Add a compressive test of the handling of the payment request to the ApplePaySession
constructor. For further testing, we will need to mock out bits of the underlying
coordinator, but this allows for testing the aspect I am changing. The applepay
directory is in the ssl directory, as all use of ApplePay requires https.

TestExpectations:
platform/ios-simulator-wk2/TestExpectations:
platform/mac-wk2/TestExpectations:

Only enable the tests on iOS 10.10 and greater, and macOS 10.12 and greater, WebKit2.

10:21 AM Changeset in webkit [209759] by dbates@webkit.org

5 edits
8 adds in trunk

CSP: Teach the preload scanner about the 'nonce' attribute
https://bugs.webkit.org/show_bug.cgi?id=161192
<rdar://problem/28010354>

Reviewed by Darin Adler.

Source/WebCore:

This patch was inspired by a similar Blink change:
<https://chromium.googlesource.com/chromium/src/+/dde5487f380cf774e4c0e96ba7f88ea68e723907>

Preload external scripts and stylesheets whose HTML script and link elements have a nonce
attribute that is listed in the Content Security Policy (CSP) of the page.

Currently the preload scanner ignores the nonce attribute on HTML script and link elements.
So, WebKit does not preload their associated subresources unless the value of the src
attribute or href attribute is whitelisted in the CSP of the page for script and link
elements, respectively. Instead the preload scanner should recognize the nonce attribute on
script and link elements and query the CSP of the page with it. If the nonce attribute is
whitelisted then the request should be preloaded.

Tests: http/tests/loading/do-not-preload-css-blocked-by-csp.html

http/tests/loading/do-not-preload-script-src-blocked-by-csp.html
http/tests/loading/preload-css-with-csp-nonce.html
http/tests/loading/preload-script-src-with-csp-nonce.html

html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::createPreloadRequest): Set the nonce on the
PreloadRequest to the nonce that we found during the scan.
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute): For script and link tag names,
save the value of the nonce attribute (if it has one).

html/parser/HTMLResourcePreloader.cpp:

(WebCore::PreloadRequest::resourceRequest): Skip CSP policy check if the nonce is listed in
the CSP of the page.

html/parser/HTMLResourcePreloader.h:

(WebCore::PreloadRequest::setNonce): Added.

LayoutTests:

Add tests to ensure that we preload <script>s and <link>s whose nonce is allowed by the
Content Security Policy of the page.

http/tests/loading/do-not-preload-css-blocked-by-csp-expected.txt: Added.
http/tests/loading/do-not-preload-css-blocked-by-csp.html: Added.
http/tests/loading/do-not-preload-script-src-blocked-by-csp-expected.txt: Added.
http/tests/loading/do-not-preload-script-src-blocked-by-csp.html: Added.
http/tests/loading/preload-css-with-csp-nonce-expected.txt: Added.
http/tests/loading/preload-css-with-csp-nonce.html: Added.
http/tests/loading/preload-script-src-with-csp-nonce-expected.txt: Added.
http/tests/loading/preload-script-src-with-csp-nonce.html: Added.

9:39 AM Changeset in webkit [209758] by hyatt@apple.com

20 edits in trunk/Source/WebCore

[CSS Parser] Rename CSSPrimitiveValue::UnitTypes to CSSPrimitiveValue::UnitType
https://bugs.webkit.org/show_bug.cgi?id=165776

Reviewed by Zalan Bujtas.

css/CSSCalculationValue.cpp:

(WebCore::unitCategory):
(WebCore::hasDoubleValue):
(WebCore::determineCategory):
(WebCore::CSSCalcExpressionNodeParser::parseValue):

css/CSSCalculationValue.h:
css/CSSPrimitiveValue.cpp:

(WebCore::isValidCSSUnitTypeForDoubleConversion):
(WebCore::isStringType):
(WebCore::CSSPrimitiveValue::unitCategory):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::computeLengthDouble):
(WebCore::CSSPrimitiveValue::computeNonCalcLengthDouble):
(WebCore::CSSPrimitiveValue::conversionToCanonicalUnitsScaleFactor):
(WebCore::CSSPrimitiveValue::getFloatValue):
(WebCore::CSSPrimitiveValue::doubleValue):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory):
(WebCore::CSSPrimitiveValue::doubleValueInternal):
(WebCore::CSSPrimitiveValue::cloneForCSSOM):

css/CSSPrimitiveValue.h:

(WebCore::CSSPrimitiveValue::isFontRelativeLength):
(WebCore::CSSPrimitiveValue::isLength):
(WebCore::CSSPrimitiveValue::isResolution):
(WebCore::CSSPrimitiveValue::createAllowingMarginQuirk):

css/CSSValue.h:
css/CSSValuePool.cpp:

(WebCore::CSSValuePool::createValue):

css/CSSValuePool.h:

(WebCore::CSSValuePool::createValue):

css/MediaQueryExp.cpp:

(WebCore::featureWithValidDensity):
(WebCore::MediaQueryExpression::MediaQueryExpression):

css/parser/CSSParserFastPaths.cpp:

(WebCore::parseSimpleLength):
(WebCore::parseSimpleLengthValue):
(WebCore::parseColorIntOrPercentage):
(WebCore::fastParseColorInternal):
(WebCore::parseTransformTranslateArguments):
(WebCore::parseTransformNumberArguments):

css/parser/CSSParserToken.cpp:

(WebCore::cssPrimitiveValueUnitFromTrie):
(WebCore::stringToUnitType):
(WebCore::CSSParserToken::CSSParserToken):
(WebCore::CSSParserToken::convertToPercentage):

css/parser/CSSParserToken.h:

(WebCore::CSSParserToken::unitType):

css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::consumeTransformOrigin):
(WebCore::consumeCounter):
(WebCore::consumeAnimationName):
(WebCore::consumePerspective):
(WebCore::consumePositionLonghand):
(WebCore::consumeCounterContent):
(WebCore::consumeReflect):
(WebCore::consumeGridBreadth):
(WebCore::CSSPropertyParser::consumeFlex):

css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::CalcParser::consumeNumber):
(WebCore::CSSPropertyParserHelpers::consumeInteger):
(WebCore::CSSPropertyParserHelpers::consumeLength):
(WebCore::CSSPropertyParserHelpers::consumePercent):
(WebCore::CSSPropertyParserHelpers::consumeAngle):
(WebCore::CSSPropertyParserHelpers::consumeTime):
(WebCore::CSSPropertyParserHelpers::consumeCustomIdent):
(WebCore::CSSPropertyParserHelpers::consumeString):
(WebCore::CSSPropertyParserHelpers::consumeUrl):
(WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradientPoint):
(WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradientColorStop):
(WebCore::CSSPropertyParserHelpers::consumeCrossFade):
(WebCore::CSSPropertyParserHelpers::consumeImageSet):
(WebCore::CSSPropertyParserHelpers::consumeFilterFunction):

css/parser/MediaQueryParser.cpp:

(WebCore::MediaQueryParser::readFeatureValue):

css/parser/SizesAttributeParser.cpp:

(WebCore::SizesAttributeParser::computeLength):

css/parser/SizesAttributeParser.h:
dom/StyledElement.cpp:

(WebCore::StyledElement::setInlineStyleProperty):
(WebCore::StyledElement::addPropertyToPresentationAttributeStyle):

dom/StyledElement.h:
svg/SVGLengthValue.cpp:

(WebCore::SVGLengthValue::toCSSPrimitiveValue):

8:59 AM Changeset in webkit [209757] by eric.carlson@apple.com

6 edits in trunk

Annotate MediaStream and WebRTC idl with EnabledAtRuntime flag
https://bugs.webkit.org/show_bug.cgi?id=165251

Reviewed by Youenn Fablet.

Source/WebCore:

No new tests, fixes an API test.

page/Settings.in: Delete mediaStreamEnabled and peerConnectionEnabled, we don't need a

setting and a runtime feature.

Source/WebKit2:

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Update the media stream and peer connection runtime
feature instead of the setting.

Tools:

TestWebKitAPI/Tests/WebKit2/EnumerateMediaDevices.cpp:

(TestWebKitAPI::TEST): Enable MediaStream, create web view from the page group upon which
the preferences have been set.

8:08 AM Changeset in webkit [209756] by Antti Koivisto

13 edits
2 adds in trunk

Source/WebCore:
REGRESSION (r198990): Cannot edit content inside <details> in wysiwyg editor
https://bugs.webkit.org/show_bug.cgi?id=165757

Reviewed by Andreas Kling.

Test: fast/html/details-edit.html

-webkit-user-modify is reset on shadow boundary so it doesn't go through <details> shadow tree.

css/StyleResolver.cpp:

(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyMatchedProperties):

dom/Node.cpp:

(WebCore::computeEditabilityFromComputedStyle):
(WebCore::Node::computeEditability):

Make -webkit-user-modify (which we would want to get rid of completely eventually) have no effect in shadow trees.
Check for contenteditable directly instead.

html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::createInnerTextStyle):

html/HTMLTextAreaElement.cpp:

(WebCore::HTMLTextAreaElement::createInnerTextStyle):

html/shadow/TextControlInnerElements.cpp:
rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::createFlowThreadStyle):

rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects):

rendering/RenderListItem.cpp:

(WebCore::RenderListItem::styleDidChange):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::createAnonymousStyleWithDisplay):
(WebCore::RenderStyle::createStyleInheritingFromPseudoStyle):
(WebCore::RenderStyle::inheritFrom):

Let -webkit-user-modify inherit through shadow boundary as normal.

rendering/style/RenderStyle.h:

LayoutTests:
REGRESSION (r198990): Safari - Cannot edit content inside <details> in wysiwyg editor
https://bugs.webkit.org/show_bug.cgi?id=165757

Reviewed by Andreas Kling.

editing/execCommand/justify-right-then-indent-with-problematic-body-expected.txt:
fast/html/details-edit-expected.txt: Added.
fast/html/details-edit.html: Added.

4:49 AM Changeset in webkit [209755] by Konstantin Tokarev