Timeline
Jun 13, 2017:
- 11:59 PM Changeset in webkit [218245] by
-
- 3 edits in trunk/Source/WTF
[GTK][WPE] Use CMAKE_THREAD_LIBS_INIT in WTF platform CMake files
https://bugs.webkit.org/show_bug.cgi?id=173310
Reviewed by Xabier Rodriguez-Calvar.
In the WTF platform CMake files for the GTK+ and WPE ports, use the
CMAKE_THREAD_LIBS_INIT variable to specify the threading library we
should be linking against. On some platforms this variable will be
empty because the given compiler will automatically handle the -pthread
compiler flag and sort out linking on its own.
The same approach is already used for the JSCOnly configuration.
- wtf/PlatformGTK.cmake:
- wtf/PlatformWPE.cmake:
- 11:31 PM Changeset in webkit [218244] by
-
- 4 edits in trunk/Source/WebKit2
Do not mix C and C++ API error constants
https://bugs.webkit.org/show_bug.cgi?id=173311
Reviewed by Alex Christensen.
In r214934 I added error constants to API::Error, but not for all errors exposed in the C API. Because of this
we are mixing both constants in WebErrors and in GTk+ WebKitPrivate.
- Shared/API/APIError.h:
- Shared/WebErrors.cpp:
(WebKit::blockedError):
(WebKit::blockedByContentBlockerError):
(WebKit::cannotShowURLError):
(WebKit::interruptedForPolicyChangeError):
(WebKit::blockedByContentFilterError):
(WebKit::cannotShowMIMETypeError):
(WebKit::pluginWillHandleLoadError):
(WebKit::internalError):
- UIProcess/API/gtk/WebKitPrivate.cpp:
(toWebKitError):
(toWebCoreError):
- 9:55 PM Changeset in webkit [218243] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Console: Message icons overlay source location
https://bugs.webkit.org/show_bug.cgi?id=173291
Reviewed by Matt Baker.
- UserInterface/Views/ConsoleMessageView.css:
(.console-message-location.call-frame):
This should be a safe change since a method name and a source link already have
max-width set to 20vw and 30vw respectively.
- 8:48 PM Changeset in webkit [218242] by
-
- 5 edits4 adds in trunk
Event handlers should not be called in frameless documents
https://bugs.webkit.org/show_bug.cgi?id=173233
Reviewed by Sam Weinig.
LayoutTests/imported/w3c:
Rebaseline W3C test now that it is passing.
- web-platform-tests/html/webappapis/scripting/events/uncompiled_event_handler_with_scripting_disabled-expected.txt:
Source/WebCore:
As per the HTML specification [1], for event handlers on elements, we should use the
element's document to check if scripting is disabled [2]. Scripting is considered to
be disabled if the document has no browsing context (i.e. a frame in WebKit terms).
In JSLazyEventListener::initializeJSFunction(), instead of using the element's
document to do the checks, we would use the script execution context. In most cases,
a node's document and its script execution context are the same so this is not an
issue. However, if the node's document is a document created via JS, its nodes'
script execution context will be the document's context document (i.e the one that
created the document, see implementation of Node::scriptExecutionContext()). In those
cases, using the wrong document is an issue because the document's context document
(aka script execution context) may allow scripting but we still do not want to call
the event handler because its document is frameless.
This impacts documents created by JS, using the following APIs:
- DOMParser.parseFromHTML
- new Document()
- DOMImplementation.createDocument / createHTMLDocument
- XHRs whose responseType is Document.
[1] https://html.spec.whatwg.org/multipage/webappapis.html#getting-the-current-value-of-the-event-handler (step 1.1.)
[2] https://html.spec.whatwg.org/multipage/webappapis.html#concept-n-noscript
Tests: fast/events/event-handler-detached-document-dispatchEvent.html
fast/events/event-handler-detached-document.html
- bindings/js/JSLazyEventListener.cpp:
(WebCore::JSLazyEventListener::initializeJSFunction):
LayoutTests:
Extend layout test coverage.
- fast/events/event-handler-detached-document-dispatchEvent-expected.txt: Added.
- fast/events/event-handler-detached-document-dispatchEvent.html: Added.
- fast/events/event-handler-detached-document-expected.txt: Added.
- fast/events/event-handler-detached-document.html: Added.
- 7:44 PM Changeset in webkit [218241] by
-
- 16 edits in trunk
Rebaseline media/modern-media-controls/placard-support
https://bugs.webkit.org/show_bug.cgi?id=173340
Reviewed by Dean Jackson.
Source/WebCore:
We make a source change to use a "placard" getter/setter to show or hide a placard, making it
more convenient to test whether a placard has been set.
- Modules/modern-media-controls/controls/inline-media-controls.js:
(InlineMediaControls.prototype.get placard):
(InlineMediaControls.prototype.set placard):
(InlineMediaControls.prototype.showPlacard): Deleted.
(InlineMediaControls.prototype.hidePlacard): Deleted.
- Modules/modern-media-controls/media/placard-support.js:
(PlacardSupport.prototype._updatePlacard):
(PlacardSupport):
LayoutTests:
We update tests to use the new "placard" property rather than "showsPlacard" which this patch removes.
- media/modern-media-controls/placard-support/placard-support-airplay-expected.txt:
- media/modern-media-controls/placard-support/placard-support-airplay.html:
- media/modern-media-controls/placard-support/placard-support-error-expected.txt:
- media/modern-media-controls/placard-support/placard-support-error-recover-expected.txt:
- media/modern-media-controls/placard-support/placard-support-error-recover.html:
- media/modern-media-controls/placard-support/placard-support-error.html:
- media/modern-media-controls/placard-support/placard-support-pip-expected.txt:
- media/modern-media-controls/placard-support/placard-support-pip.html:
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 7:39 PM Changeset in webkit [218240] by
-
- 3 edits2 moves in trunk/LayoutTests
Rebaseline media/modern-media-controls/mute-support
https://bugs.webkit.org/show_bug.cgi?id=173345
Reviewed by Dean Jackson.
- media/modern-media-controls/mute-support/mute-support-press-on-button-expected.txt: Renamed from LayoutTests/media/modern-media-controls/mute-support/mute-support-button-click-expected.txt.
- media/modern-media-controls/mute-support/mute-support-press-on-button.html: Renamed from LayoutTests/media/modern-media-controls/mute-support/mute-support-button-click.html.
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 6:30 PM Changeset in webkit [218239] by
-
- 5 edits in trunk/LayoutTests
Rebaseline media/modern-media-controls/tracks-button
https://bugs.webkit.org/show_bug.cgi?id=173220
Reviewed by Dean Jackson.
Use SVG assets.
- media/modern-media-controls/tracks-button/tracks-button-expected.txt:
- media/modern-media-controls/tracks-button/tracks-button.html:
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 6:23 PM Changeset in webkit [218238] by
-
- 5 edits2 deletes in trunk/LayoutTests
Rebaseline media/modern-media-controls/time-control
https://bugs.webkit.org/show_bug.cgi?id=173218
Reviewed by Dean Jackson.
There no longer is a Scrubber class and the useSixDigitsForTimeLabels property no longer exists.
- media/modern-media-controls/time-control/time-control-expected.txt:
- media/modern-media-controls/time-control/time-control-use-six-digits-for-time-labels-expected.txt: Removed.
- media/modern-media-controls/time-control/time-control-use-six-digits-for-time-labels.html: Removed.
- media/modern-media-controls/time-control/time-control.html:
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 6:22 PM Changeset in webkit [218237] by
-
- 5 edits2 moves2 deletes in trunk/LayoutTests
Rebaseline media/modern-media-controls/status-label
https://bugs.webkit.org/show_bug.cgi?id=173217
Reviewed by Dean Jackson.
There is no need for macOS and iOS-specific tests, they share the same styles.
- media/modern-media-controls/status-label/status-label-expected.txt:
- media/modern-media-controls/status-label/status-label-in-controls-expected.txt: Renamed from LayoutTests/media/modern-media-controls/status-label/status-label-macos-expected.txt.
- media/modern-media-controls/status-label/status-label-in-controls.html: Renamed from LayoutTests/media/modern-media-controls/status-label/status-label-macos.html.
- media/modern-media-controls/status-label/status-label-ios-expected.txt: Removed.
- media/modern-media-controls/status-label/status-label-ios.html: Removed.
- media/modern-media-controls/status-label/status-label.html:
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 6:19 PM Changeset in webkit [218236] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove media/modern-media-controls/start-button
https://bugs.webkit.org/show_bug.cgi?id=173216
Reviewed by Dean Jackson.
The StartButton class was removed.
- media/modern-media-controls/start-button/start-button-expected.txt: Removed.
- media/modern-media-controls/start-button/start-button-styles-expected.txt: Removed.
- media/modern-media-controls/start-button/start-button-styles.html: Removed.
- media/modern-media-controls/start-button/start-button.html: Removed.
- 6:18 PM Changeset in webkit [218235] by
-
- 7 edits in trunk/LayoutTests
Rebaseline media/modern-media-controls/slider
https://bugs.webkit.org/show_bug.cgi?id=173215
Reviewed by Dean Jackson.
- media/modern-media-controls/slider/slider-constructor-expected.txt:
- media/modern-media-controls/slider/slider-constructor.html:
- media/modern-media-controls/slider/slider-styles-expected.txt:
- media/modern-media-controls/slider/slider-styles.html:
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 6:16 PM Changeset in webkit [218234] by
-
- 5 edits in trunk/LayoutTests
Rebaseline media/modern-media-controls/skip-back-button
https://bugs.webkit.org/show_bug.cgi?id=173213
Reviewed by Dean Jackson.
Use SVG assets.
- media/modern-media-controls/skip-back-button/skip-back-button-expected.txt:
- media/modern-media-controls/skip-back-button/skip-back-button.html:
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 6:12 PM Changeset in webkit [218233] by
-
- 2 edits in trunk/Tools
Test persistent WKHTTPCookieStorages on iOS
https://bugs.webkit.org/show_bug.cgi?id=173284
<rdar://problem/32260156>
- TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
(TEST):
- 6:04 PM Changeset in webkit [218232] by
-
- 5 edits in trunk/LayoutTests
Rebaseline media/modern-media-controls/time-label
https://bugs.webkit.org/show_bug.cgi?id=173219
Reviewed by Dean Jackson.
We update the content of the time-label.html test to be relevant to its new API.
- media/modern-media-controls/time-label/time-label-expected.txt:
- media/modern-media-controls/time-label/time-label.html:
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 6:03 PM Changeset in webkit [218231] by
-
- 7 edits2 moves1 delete in trunk
Rebaseline media/modern-media-controls/fullscreen-support
https://bugs.webkit.org/show_bug.cgi?id=173199
Reviewed by Simon Fraser.
Source/WebCore:
Test: media/modern-media-controls/fullscreen-support/fullscreen-support-press.html
We no longer need to track the "error" event for FullscreenSupport since we don't actually
enable or disable the fullscreen button when an error happens, instead the media controls
code will simply not present it since we'll be showing a placard instead.
- Modules/modern-media-controls/media/fullscreen-support.js:
(FullscreenSupport.prototype.get mediaEvents):
LayoutTests:
We no longer need to test the "error" event for FullscreenSupport since we don't actually
enable or disable the fullscreen button when an error happens, instead the media controls
code will simply not present it since we'll be showing a placard instead.
We also remove the iPad-specific test since the fullscreen button is now accessible on an
iPhone as well, so it no longer needs a special iPad test.
- media/modern-media-controls/fullscreen-support/fullscreen-support-enabled-expected.txt:
- media/modern-media-controls/fullscreen-support/fullscreen-support-enabled.html:
- media/modern-media-controls/fullscreen-support/fullscreen-support-press-expected.txt: Renamed from LayoutTests/media/modern-media-controls/fullscreen-support/fullscreen-support-click-expected.txt.
- media/modern-media-controls/fullscreen-support/fullscreen-support-press.html: Renamed from LayoutTests/media/modern-media-controls/fullscreen-support/fullscreen-support-click.html.
- media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap-expected.txt: Removed.
- media/modern-media-controls/fullscreen-support/ipad/fullscreen-support-tap.html: Removed.
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 5:36 PM Changeset in webkit [218230] by
-
- 3 edits2 deletes in trunk/LayoutTests
[GTK] Fix linter warnings on the GTK Debug TestExpectation file and update some expectations for Debug.
Unreviewed test gardening.
- TestExpectations: Merge expectations for imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.worker.html
- platform/gtk/TestExpectations: Mark observed timeouts on Debug and fix linter warnings related to tests renamed or deleted.
- platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-expected.txt: Removed.
- platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/request-headers-worker-expected.txt: Removed.
- 5:32 PM Changeset in webkit [218229] by
-
- 15 edits in trunk
WebsitePolicies: let clients select specific autoplay quirks
https://bugs.webkit.org/show_bug.cgi?id=173343
Reviewed by Alex Christensen.
Source/WebCore:
Tests: Updated API tests accordingly to use new values.
Replace the 'allowsAutoplayQuirks' bool with an OptionSet so clients can selectively
pick auto-play quirks.
- dom/Document.cpp:
(WebCore::Document::processingUserGestureForMedia):
- html/HTMLMediaElement.cpp:
(WebCore::needsAutoplayPlayPauseEventsQuirk):
- loader/DocumentLoader.h:
(WebCore::DocumentLoader::allowedAutoplayQuirks):
(WebCore::DocumentLoader::setAllowedAutoplayQuirks):
(WebCore::DocumentLoader::allowsAutoplayQuirks): Deleted.
(WebCore::DocumentLoader::setAllowsAutoplayQuirks): Deleted.
Source/WebKit2:
Replace the 'allowsAutoplayQuirks' bool with an OptionSet so clients can selectively
pick auto-play quirks.
- Shared/WebsitePolicies.h:
(WebKit::WebsitePolicies::encode):
(WebKit::WebsitePolicies::decode):
- UIProcess/API/APIWebsitePolicies.h:
- UIProcess/API/C/WKWebsitePolicies.cpp:
(WKWebsitePoliciesSetAllowedAutoplayQuirks):
(WKWebsitePoliciesGetAllowedAutoplayQuirks):
(WKWebsitePoliciesSetAllowsAutoplayQuirks): Deleted.
(WKWebsitePoliciesGetAllowsAutoplayQuirks): Deleted.
- UIProcess/API/C/WKWebsitePolicies.h:
- UIProcess/API/Cocoa/_WKWebsitePolicies.h:
- UIProcess/API/Cocoa/_WKWebsitePolicies.mm:
(-[_WKWebsitePolicies setAllowedAutoplayQuirks:]):
(-[_WKWebsitePolicies allowedAutoplayQuirks]):
(-[_WKWebsitePolicies setAllowsAutoplayQuirks:]): Deleted.
(-[_WKWebsitePolicies allowsAutoplayQuirks]): Deleted.
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updateWebsitePolicies):
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/WebsitePolicies.mm:
(-[AutoplayPoliciesDelegate _webView:decidePolicyForNavigationAction:decisionHandler:]):
(TEST): Updated tests.
- 5:19 PM Changeset in webkit [218228] by
-
- 4 edits in trunk
Synchronous media query callbacks on nested frames could produced a detached FrameView.
https://bugs.webkit.org/show_bug.cgi?id=173330
Reviewed by Simon Fraser.
Source/WebCore:
This patch fixes the crash when the nested frame's media query callback triggers navigation on the mainframe.
webkit.org/b/173329 is to track whether we should allow synchronous callback firing from FrameView::layout().
Covered by show-modal-dialog-during-execCommand.html.
- page/FrameView.cpp:
(WebCore::FrameView::layout):
LayoutTests:
- TestExpectations: ASSERT(frame()->view() == this) still fires due to the unexpected navigation, but we clearly
manage to recover from it. Unskip it (debug) when webkit.org/b/173329 is resolved.
- 5:14 PM Changeset in webkit [218227] by
-
- 1 copy in tags/Safari-604.1.25.3.1
Tag Safari-604.1.25.3.1.
- 5:12 PM Changeset in webkit [218226] by
-
- 3 edits2 adds in trunk
AX[macOS]: Expose Inline property as an accessibility attribute
https://bugs.webkit.org/show_bug.cgi?id=173131
<rdar://problem/32667686>
Reviewed by Joanmarie Diggs.
Source/WebCore:
Expose whether a renderer is inline so that VoiceOver can make better use of that data when deciding what to output.
Test: accessibility/mac/inline-text-attribute.html
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
LayoutTests:
- accessibility/mac/inline-text-attribute.html: Added.
- accessibility/mac/inline-text-attribute-expected.txt: Added.
- 5:10 PM Changeset in webkit [218225] by
-
- 1 copy in tags/Safari-604.1.25.4.1
Tag Safari-604.1.25.4.1.
- 5:10 PM Changeset in webkit [218224] by
-
- 2 edits in trunk/Source/WebKit2
Add missing availability declarations to SPI in WKUIDelegatePrivate.h
https://bugs.webkit.org/show_bug.cgi?id=173336
Reviewed by Tim Horton.
Add missing availability macros to two recently-introduced SPI delegate methods.
No change in behavior.
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- 4:57 PM Changeset in webkit [218223] by
-
- 3 edits3 adds in trunk
Debugger has unexpected effect on program correctness
https://bugs.webkit.org/show_bug.cgi?id=172683
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-06-13
Reviewed by Saam Barati.
Source/JavaScriptCore:
- inspector/InjectedScriptSource.js:
(InjectedScript.RemoteObject.prototype._appendPropertyPreviews):
(InjectedScript.RemoteObject.prototype._isPreviewableObjectInternal):
(BasicCommandLineAPI):
Eliminate for..of use with Arrays from InjectedScriptSource as it can be observable.
We still use it for Set / Map iteration which we can eliminate when moving to builtins.
LayoutTests:
- inspector/injected-script/observable-expected.txt: Added.
- inspector/injected-script/observable.html: Added.
- 4:51 PM Changeset in webkit [218222] by
-
- 2 edits in trunk/LayoutTests
Updated test expectations for imported/w3c/web-platform-tests/dom/nodes/Document-constructor-svg.svg.
https://bugs.webkit.org/show_bug.cgi?id=173333
Unreviewed test gardening.
- 4:26 PM Changeset in webkit [218221] by
-
- 4 edits in trunk/LayoutTests
LayoutTests/imported/w3c:
Re-baselined imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https.html.
https://bugs.webkit.org/show_bug.cgi?id=173335
Unreviewed test gardening.
- web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https-expected.txt:
LayoutTests:
Re-baselined imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https.html and fixed text expectations.
https://bugs.webkit.org/show_bug.cgi?id=173335
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 4:05 PM Renames edited by
- (diff)
- 3:45 PM Changeset in webkit [218220] by
-
- 2 edits in trunk/Source/JavaScriptCore
WebAssembly: fix erroneous signature comment
https://bugs.webkit.org/show_bug.cgi?id=173334
Reviewed by Keith Miller.
- wasm/WasmSignature.h:
- 3:44 PM Changeset in webkit [218219] by
-
- 2 edits in trunk/Source/WebCore
Update Subresource Integrity status to Supported In Preview
https://bugs.webkit.org/show_bug.cgi?id=173324
Reviewed by Sam Weinig.
- features.json:
- 3:39 PM Changeset in webkit [218218] by
-
- 5 edits in trunk/Source/JavaScriptCore
Refactor AbsenceOfSetter to AbsenceOfSetEffects
https://bugs.webkit.org/show_bug.cgi?id=173322
Reviewed by Filip Pizlo.
- bytecode/ObjectPropertyCondition.h:
(JSC::ObjectPropertyCondition::absenceOfSetEffectWithoutBarrier):
(JSC::ObjectPropertyCondition::absenceOfSetEffect):
(JSC::ObjectPropertyCondition::absenceOfSetterWithoutBarrier): Deleted.
(JSC::ObjectPropertyCondition::absenceOfSetter): Deleted.
- bytecode/ObjectPropertyConditionSet.cpp:
(JSC::generateConditionsForPropertySetterMiss):
(JSC::generateConditionsForPropertySetterMissConcurrently):
- bytecode/PropertyCondition.cpp:
(JSC::PropertyCondition::dumpInContext):
(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint):
(JSC::PropertyCondition::isStillValid):
(WTF::printInternal):
- bytecode/PropertyCondition.h:
(JSC::PropertyCondition::absenceOfSetEffectWithoutBarrier):
(JSC::PropertyCondition::absenceOfSetEffect):
(JSC::PropertyCondition::hasPrototype):
(JSC::PropertyCondition::hash):
(JSC::PropertyCondition::operator==):
(JSC::PropertyCondition::absenceOfSetterWithoutBarrier): Deleted.
(JSC::PropertyCondition::absenceOfSetter): Deleted.
- 3:31 PM Changeset in webkit [218217] by
-
- 2 edits in trunk/Source/WebKit2
Add API::InjectedBundle::PageLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=173265
Reviewed by Alex Christensen.
Add missing null check that is causing crashes on iOS.
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::userAgentForURL):
- 3:31 PM Changeset in webkit [218216] by
-
- 60 edits15 adds3 deletes in trunk
WebAssembly: import updated spec tests
https://bugs.webkit.org/show_bug.cgi?id=173287
<rdar://problem/32725975>
Reviewed by Saam Barati.
Import spec tests as of 31c641cc15f2aedbec2fa45a5185f68416df578b,
with a few modifications so things work.
Fix a bunch of bugs found through this process, and punt a few tests (which I
marked as blocked by this bug).
Fixes:
Fix load / store alignment: r216908 erroneously implemented it as bit alignment
instead of byte alignment. It was also missing memory-alignment.js despite it
being in the ChangeLog, so add it too. This allows spec-test/align.wast.js to
pass.
Tables can be imported or in a section. There can be only one, but sections can
be empty. An Elements section can exist if there's no Table, as long as it is
also empty.
Memories can be imported or in a section. There can be only one, but sections
can be empty. A Data section can exist if there's no Memory, as long as it is
also empty.
Prototypes: stringify without .prototype. in the string.
WebAssembly.Table.prototype.grow was plain wrong: it takes a delta parameter,
not a final size, and throws a RangeError on failure, not a TypeError.
Fix compile / instantiate so the reject the promise if given an argument of the
wrong type (instead of failing instantly).
Fix async on neuter test.
Element section shouldn't affect any Table if any of the elements are out of
bounds. We need to process it in two passes.
Segment section shouldn't affect any Data if any of the segments are out of
bounds. We need to process it in two passes.
Empty data segments are valid, but only when there is no memory. Their index
still gets validated, and has to be zero.
Punts:
Error messages with context, the test seems overly restrictive but this is
minor.
compile/instantiate/validate property descriptors.
UTF-8 bugs.
Temporarily disable NaN tests. We need to go back and implement the following
semantics: https://github.com/WebAssembly/spec/pull/414 This doesn't matter as
much as getting all the other tests passing.
Worth noting for NaNs: f64.no_fold_mul_one (also a NaN test) as well as
no_fold_promote_demote (an interesting corner case which we get wrong). mul by
one is (assert_return (invoke \"f64.no_fold_mul_one\" (i64.const
0x7ff4000000000000)) (i64.const 0x7ff8000000000000)) which means converting sNaN
to qNaN, and promote/demote is (assert_return (invoke \"no_fold_promote_demote\"
(i32.const 0x7fa00000)) (i32.const 0x7fc00000)) which is the same. I'm not sure
why they're not allowed.
JSTests:
- wasm.yaml:
- wasm/function-tests/i32-load8-s.js:
- wasm/function-tests/memory-access-past-4gib.js:
(const.op.of.WASM.opcodes):
- wasm/function-tests/memory-alignment.js: Added.
(const.op.of.WASM.opcodes):
- wasm/function-tests/memory-section-and-import.js:
- wasm/js-api/Module-compile.js:
(async.testPromiseAPI):
- wasm/js-api/dont-mmap-zero-byte-memory.js:
(testMems):
- wasm/js-api/element.js:
(assert.throws.new.WebAssembly.Module.builder.WebAssembly):
- wasm/js-api/neutered-inputs.js:
(const.testFunction): Deleted.
(const.testConstructor): Deleted.
- wasm/js-api/table.js:
(assert.throws.new.WebAssembly.Module.builder.WebAssembly):
(new.WebAssembly.Module):
(assert.throws):
(assertBadTableImport):
(assert.throws.WebAssembly.Table.prototype.grow):
(assertBadTableInstance): Deleted.
- wasm/js-api/test_Data.js:
(DataSectionWithoutMemory):
- wasm/spec-harness/index.js:
(module):
(uniqueTest): Deleted.
(assert_invalid): Deleted.
(assert_soft_invalid): Deleted.
(register): Deleted.
(call): Deleted.
(get instance): Deleted.
(exports): Deleted.
(run): Deleted.
(assert_unlinkable): Deleted.
(assert_uninstantiable): Deleted.
(assert_trap): Deleted.
(try.f): Deleted.
(catch): Deleted.
(assert_exhaustion): Deleted.
(assert_return): Deleted.
(assert_return_nan): Deleted.
- wasm/spec-harness/testharness.css: Removed.
- wasm/spec-harness/testharness.js: Removed.
- wasm/spec-harness/testharnessreport.js: Removed.
- wasm/spec-harness/wasm-constants.js:
(assertTraps):
(assertWasmThrows):
- wasm/spec-harness/wasm-module-builder.js:
(Binary.prototype.emit_section):
(Binary):
(WasmFunctionBuilder.prototype.addBody):
(WasmFunctionBuilder.prototype.end):
(WasmFunctionBuilder):
(WasmModuleBuilder.prototype.stringToBytes):
(WasmModuleBuilder.prototype.addCustomSection):
(WasmModuleBuilder.prototype.addFunctionTableInit):
(WasmModuleBuilder.prototype.appendToTable):
(WasmModuleBuilder.prototype.toArray):
(WasmModuleBuilder.prototype.toBuffer):
(WasmModuleBuilder.prototype.instantiate):
(WasmModuleBuilder):
- wasm/spec-tests/address.wast.js:
- wasm/spec-tests/align.wast.js: Added.
- wasm/spec-tests/binary.wast.js:
- wasm/spec-tests/block.wast.js:
- wasm/spec-tests/br.wast.js:
- wasm/spec-tests/br_if.wast.js:
- wasm/spec-tests/br_table.wast.js:
- wasm/spec-tests/call.wast.js:
- wasm/spec-tests/call_indirect.wast.js:
- wasm/spec-tests/comments.wast.js:
- wasm/spec-tests/const.wast.js: Added.
- wasm/spec-tests/conversions.wast.js: Added.
- wasm/spec-tests/custom_section.wast.js:
- wasm/spec-tests/exports.wast.js:
- wasm/spec-tests/f32.wast.js: Added.
- wasm/spec-tests/f64.wast.js: Added.
- wasm/spec-tests/fac.wast.js:
- wasm/spec-tests/float_exprs.wast.js: Added.
- wasm/spec-tests/float_misc.wast.js: Added.
- wasm/spec-tests/func.wast.js:
- wasm/spec-tests/globals.wast.js:
- wasm/spec-tests/if.wast.js:
- wasm/spec-tests/imports.wast.js:
- wasm/spec-tests/inline-module.wast.js: Added.
- wasm/spec-tests/jsapi.js:
(testJSAPI.test):
(testJSAPI):
- wasm/spec-tests/labels.wast.js:
- wasm/spec-tests/loop.wast.js:
- wasm/spec-tests/memory.wast.js:
- wasm/spec-tests/memory_trap.wast.js: Added.
- wasm/spec-tests/names.wast.js:
- wasm/spec-tests/nop.wast.js:
- wasm/spec-tests/return.wast.js:
- wasm/spec-tests/stack.wast.js:
- wasm/spec-tests/token.wast.js: Added.
- wasm/spec-tests/type.wast.js: Added.
- wasm/spec-tests/typecheck.wast.js:
- wasm/spec-tests/unreachable.wast.js:
- wasm/spec-tests/unreached-invalid.wast.js:
- wasm/spec-tests/unwind.wast.js:
- wasm/spec-tests/utf8-custom-section-id.wast.js: Added.
- wasm/spec-tests/utf8-import-field.wast.js: Added.
- wasm/spec-tests/utf8-import-module.wast.js: Added.
Source/JavaScriptCore:
- wasm/WasmB3IRGenerator.cpp:
- wasm/WasmFunctionParser.h:
- wasm/WasmModuleParser.cpp:
- wasm/WasmModuleParser.h:
- wasm/WasmParser.h:
(JSC::Wasm::Parser<SuccessType>::consumeUTF8String):
- wasm/generateWasm.py:
(memoryLog2Alignment):
- wasm/js/JSWebAssemblyTable.cpp:
(JSC::JSWebAssemblyTable::grow):
- wasm/js/JSWebAssemblyTable.h:
- wasm/js/WebAssemblyCompileErrorPrototype.cpp:
- wasm/js/WebAssemblyInstancePrototype.cpp:
- wasm/js/WebAssemblyLinkErrorPrototype.cpp:
- wasm/js/WebAssemblyMemoryPrototype.cpp:
- wasm/js/WebAssemblyModulePrototype.cpp:
- wasm/js/WebAssemblyModuleRecord.cpp:
(JSC::WebAssemblyModuleRecord::evaluate):
- wasm/js/WebAssemblyPrototype.cpp:
(JSC::webAssemblyCompileFunc):
(JSC::resolve):
(JSC::instantiate):
(JSC::compileAndInstantiate):
(JSC::webAssemblyInstantiateFunc):
- wasm/js/WebAssemblyRuntimeErrorPrototype.cpp:
- wasm/js/WebAssemblyTablePrototype.cpp:
(JSC::webAssemblyTableProtoFuncGrow):
- 3:27 PM Changeset in webkit [218215] by
-
- 2 edits in trunk/LayoutTests
Marked imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https.html as failing.
https://bugs.webkit.org/show_bug.cgi?id=173335
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 3:23 PM Changeset in webkit [218214] by
-
- 7 edits in trunk/Source/WebCore
Add logging for layout tests when rAF callbacks get suspended and resumed
https://bugs.webkit.org/show_bug.cgi?id=173326
Patch by Antoine Quint <Antoine Quint> on 2017-06-13
Reviewed by Simon Fraser.
In order to help diagnose webkit.org/b/168409 we log the ScriptedAnimationController
suspend count when it changes and log the backtrace so that we may understand why it
fails to be set back to 0 when some modern-media-controls tests run.
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::suspend):
(WebCore::ScriptedAnimationController::resume):
(WebCore::ScriptedAnimationController::logSuspendCount):
- dom/ScriptedAnimationController.h:
- page/Settings.in:
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::resetToConsistentState):
(WebCore::InternalSettings::shouldLogScritedAnimationControllerSuspensionChange):
(WebCore::InternalSettings::setShouldLogScritedAnimationControllerSuspensionChange):
- testing/InternalSettings.h:
- testing/InternalSettings.idl:
- 3:21 PM Changeset in webkit [218213] by
-
- 4 edits in tags/Safari-604.1.25.0.2
Merged r218121. rdar://problem/32701257
- 3:17 PM Changeset in webkit [218212] by
-
- 7 edits in tags/Safari-604.1.25.0.2/Source
Versioning.
- 3:09 PM Changeset in webkit [218211] by
-
- 1 copy in tags/Safari-604.1.25.0.2
New tag.
- 3:08 PM Changeset in webkit [218210] by
-
- 1 delete in tags/Safari-604.1.25.0.2
Delete tag.
- 3:07 PM Changeset in webkit [218209] by
-
- 2 edits in trunk/Source/WebCore
Crash when MSE backed media element changes src/srcObject during PiP
https://bugs.webkit.org/show_bug.cgi?id=173288
Reviewed by Alex Christensen.
Tear down the MediaPlayerPrivateMediaSourceAVFObjC's layers fully whe the player
is destroyed, which includes removing the player's AVSampleBufferDisplayLayer from
the HTMLMediaElement's fullscreen layer.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::~MediaPlayerPrivateMediaSourceAVFObjC):
- 3:06 PM Changeset in webkit [218208] by
-
- 1 copy in tags/Safari-604.1.25.0.2/Safari-604.1.25.0.1
New tag.
- 3:03 PM Changeset in webkit [218207] by
-
- 2 edits in trunk/LayoutTests
Marked imported/w3c/web-platform-tests/dom/nodes/Document-constructor-svg.svg as a timeout.
https://bugs.webkit.org/show_bug.cgi?id=173333
Unreviewed test gardening.
- 2:58 PM Changeset in webkit [218206] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][macOS] Allow AppleEvents in Citrix View Plugin
https://bugs.webkit.org/show_bug.cgi?id=173280
<rdar://problem/31913624>
Reviewed by Alexey Proskuryakov.
A slightly better fix: Allow AppleEvents for non-sandboxed plugins. This should
avoid inadvertently breaking custom plugins, etc.
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::platformInitializeProcess): Switch check from a specific Citrix
test, to just allowing non-sandboxed plugins to use AppleEvents.
- 2:54 PM Changeset in webkit [218205] by
-
- 3 edits in trunk/JSTests
Unreviewed JSC test gardening.
- stress/check-string-ident.js:
- stress/new-largeish-contiguous-array-with-size.js:
- 2:52 PM Changeset in webkit [218204] by
-
- 1 copy in tags/Safari-604.1.25.0.2
New tag.
- 2:52 PM Changeset in webkit [218203] by
-
- 4 edits1 add in trunk
DFG doesn't properly handle a property that is change to read only in a prototype
https://bugs.webkit.org/show_bug.cgi?id=173321
Reviewed by Filip Pizlo.
JSTests:
- ChakraCore.yaml: Renabled fieldopts/objtypespec-newobj-invalidation.1.js.
- stress/regress-173321.js: Added new regression test.
(shouldBe):
(SimpleObject):
(test):
Source/JavaScriptCore:
We need to check for ReadOnly as well as a not being a Setter when checking
an AbsenceOfSetter.
- bytecode/PropertyCondition.cpp:
(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint):
- 2:03 PM Changeset in webkit [218202] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Don't use -webkit-user-modify CSS property
https://bugs.webkit.org/show_bug.cgi?id=173232
Reviewed by Devin Rousso.
Replace -webkit-user-modify CSS property with contentEditable HTML attribute.
- UserInterface/Views/Editing.css:
(.editing):
- UserInterface/Views/EditingSupport.js:
(cleanUpAfterEditing):
- UserInterface/Views/VisualStyleSelectorTreeItem.css:
(.item.visual-style-selector-item:not(.dom-element-icon).editable > .titles > .title):
- UserInterface/Views/VisualStyleSelectorTreeItem.js:
(WebInspector.VisualStyleSelectorTreeItem.prototype.ondeselect):
(WebInspector.VisualStyleSelectorTreeItem.prototype._handleMainTitleMouseDown):
(WebInspector.VisualStyleSelectorTreeItem.prototype._commitSelector):
- 1:58 PM Changeset in webkit [218201] by
-
- 3 edits in trunk/Source/WebKit2
Include PID in some UIProcess-side release logging that relates to a particular WebProcess
https://bugs.webkit.org/show_bug.cgi?id=173299
Reviewed by Ryosuke Niwa.
- UIProcess/BackgroundProcessResponsivenessTimer.cpp:
(WebKit::BackgroundProcessResponsivenessTimer::setResponsive):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didExceedActiveMemoryLimit):
(WebKit::WebProcessProxy::didExceedInactiveMemoryLimit):
(WebKit::WebProcessProxy::didExceedCPULimit):
- 1:37 PM Changeset in webkit [218200] by
-
- 7 edits in branches/safari-604.1.25.4-branch/Source
Versioning.
- 1:37 PM Changeset in webkit [218199] by
-
- 8 edits2 adds in branches/safari-604.1.25.4-branch
Cherry-pick r218180. rdar://problem/32440918
- 1:31 PM Changeset in webkit [218198] by
-
- 7 edits in branches/safari-604.1.25.3-branch/Source
Versioning.
- 1:27 PM Changeset in webkit [218197] by
-
- 4 edits in branches/safari-604.1.25.3-branch
Cherry-pick r218121. rdar://problem/32701257
- 1:21 PM Changeset in webkit [218196] by
-
- 31 edits3 adds in trunk
Implement W3C Secure Contexts Draft Specification
https://bugs.webkit.org/show_bug.cgi?id=158121
<rdar://problem/26012994>
Reviewed by Brent Fulgham.
Part 4
Source/JavaScriptCore:
Adds isSecureContext to the list of common identifiers as needed to support
toggling its exposure from a runtime enabled feature flag.
- runtime/CommonIdentifiers.h:
Source/WebCore:
Adds runtime enabled feature flag, isSecureContextAttributeEnabled, to toggle exposing
the global object property isSecureContext (defaults: true - expose the property).
Test: security/isSecureContext-disabled.html
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setIsSecureContextAttributeEnabled):
(WebCore::RuntimeEnabledFeatures::isSecureContextAttributeEnabled):
- page/WindowOrWorkerGlobalScope.idl:
Source/WebKit/mac:
Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
- WebView/WebPreferenceKeysPrivate.h:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences isSecureContextAttributeEnabled]):
(-[WebPreferences setIsSecureContextAttributeEnabled:]):
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit/win:
Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
- Interfaces/IWebPreferencesPrivate.idl: Bump the version.
- WebPreferenceKeysPrivate.h:
- WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
(WebPreferences::QueryInterface):
(WebPreferences::setIsSecureContextAttributeEnabled):
(WebPreferences::isSecureContextAttributeEnabled):
- WebPreferences.h:
- WebView.cpp:
(WebView::notifyPreferencesChanged):
Source/WebKit2:
Adds a preference to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetIsSecureContextAttributeEnabled):
(WKPreferencesGetIsSecureContextAttributeEnabled):
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
Expose the isSecureContext attribute by default in DumpRenderTree and WebKitTestRunner.
Teach DumpRenderTree for Mac and WebKitTestRunner to parse the test option enableIsSecureContextAttribute
to toggle the runtime enabled feature flag isSecureContextAttributeEnabled.
- DumpRenderTree/TestOptions.h:
- DumpRenderTree/TestOptions.mm:
(TestOptions::TestOptions):
- DumpRenderTree/mac/DumpRenderTree.mm:
(setWebPreferencesForTestOptions):
- DumpRenderTree/win/DumpRenderTree.cpp:
(enableExperimentalFeatures):
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):
- WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions):
LayoutTests:
Adds a test to ensure that the global object property isSecureContext is not
exposed (is undefined) when the runtime enabled feature flag isSecureContextAttributeEnabled
is disabled.
- platform/win/TestExpectations: Skip the test as DumpRenderTree on Windows does not support
parsing of test options. See <https://bugs.webkit.org/show_bug.cgi?id=173281> for more details.
- security/isSecureContext-disabled-expected.txt: Added.
- security/isSecureContext-disabled.html: Added.
- security/resources/worker-isSecureContext-disabled.js: Added.
- 1:12 PM Changeset in webkit [218195] by
-
- 2 edits in trunk/Tools
Test persistent WKHTTPCookieStorages on iOS
https://bugs.webkit.org/show_bug.cgi?id=173284
<rdar://problem/32260156>
Patch by Alex Christensen <achristensen@webkit.org> on 2017-06-13
Reviewed by Alexey Proskuryakov.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKHTTPCookieStore.mm:
(TEST):
- 12:31 PM Changeset in webkit [218194] by
-
- 1 copy in branches/safari-604.1.25.4-branch
New branch.
- 12:31 PM Changeset in webkit [218193] by
-
- 1 copy in branches/safari-604.1.25.3-branch
New branch.
- 12:28 PM Changeset in webkit [218192] by
-
- 1 delete in branches/safari-604.1.25.1-branch
Delete branch.
- 12:28 PM Changeset in webkit [218191] by
-
- 1 delete in branches/safari-604.1.25.0-branch
Delete branch.
- 12:14 PM Changeset in webkit [218190] by
-
- 2 edits in trunk/Source/WebCore
Protect lifetime of media element during HTMLMediaElement::notifyAboutPlaying()
https://bugs.webkit.org/show_bug.cgi?id=173320
<rdar://problem/32590276>
Reviewed by Brent Fulgham.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::notifyAboutPlaying):
- 12:12 PM Changeset in webkit [218189] by
-
- 1 copy in branches/safari-604.1.25.1-branch
New branch.
- 12:12 PM Changeset in webkit [218188] by
-
- 1 copy in branches/safari-604.1.25.0-branch
New branch.
- 11:39 AM Changeset in webkit [218187] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][macOS] Allow AppleEvents in Citrix View Plugin
https://bugs.webkit.org/show_bug.cgi?id=173280
<rdar://problem/31913624>
Reviewed by Alexey Proskuryakov.
Allow the Citrix Viewer plugin to issue Apple Events.
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::platformInitializeProcess): Allow AppleEvents for the Citrix Viewer plugin.
- 11:03 AM Changeset in webkit [218186] by
-
- 2 edits in trunk/Source/WebKit/win
[Win] WebKit fails to paint the bottom lines of the window at 125% scale.
https://bugs.webkit.org/show_bug.cgi?id=173318
Reviewed by Alex Christensen.
The logical frame size is currently calculated by scaling the frame size in pixels,
and rounding the coordinates to the nearest integers. The computed logical frame
size will in some cases be smaller than the scaled frame size in pixels, since it is
represented as an IntSize. In these cases, the bottom line will not be painted.
Instead of calculating the logical frame size by rounding the scaled frame in
pixels, find the enclosing rectangle of the scaled frame rectangle in pixels.
- WebView.cpp:
(WebView::sizeChanged):
- 10:55 AM Changeset in webkit [218185] by
-
- 7 edits in trunk
[GTK] Blob download doesn't work
https://bugs.webkit.org/show_bug.cgi?id=172442
Reviewed by Carlos Alberto Lopez Perez.
Source/WebKit2:
GTK+ API uses URIs for download destination paths, and passes that URIs to the WebKit internals. But WebKit
expects download destination location to be a local path. This is not a problem for normal downloads, because
the soup backend handles the cases of download destination being a URI and a path. For blob downloads
NetworkDataTaskBlob is used, and it always expects the download destination to be a local path, failing in
FileSystem::openFile() when a URI is passed. We need to keep using local files internally and convert to URIs
only when exposing those paths to the API.
- NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::download): Stop handling URIs here, we should always expect local files.
- UIProcess/API/gtk/WebKitDownload.cpp:
(webkitDownloadDecideDestinationWithSuggestedFilename): Convert destination URI to filanme before pasing it to DownloadClient.
(webkitDownloadDestinationCreated): Convert the destination path to a URI before passing it to WebKitDownload::created-destionation signal.
- UIProcess/API/gtk/WebKitDownloadClient.cpp:
- UIProcess/API/gtk/WebKitDownloadPrivate.h:
Tools:
Add a unit test to check blob downloads.
- TestWebKitAPI/Tests/WebKit2Gtk/TestDownloads.cpp:
(testBlobDownload):
(beforeAll):
- 10:50 AM Changeset in webkit [218184] by
-
- 2 edits in trunk/Tools
[GTK] Do not include WTR, DumpRendererTree and ImageDiff in tarballs
https://bugs.webkit.org/show_bug.cgi?id=173316
Reviewed by Alex Christensen.
It's not really possible to run layout tests from the tarball, so it's better not to include those files.
- gtk/manifest.txt.in:
- 10:48 AM Changeset in webkit [218183] by
-
- 3 edits in trunk/Tools
[WTR] Crash in WebGeolocationManagerProxy::~WebGeolocationManagerProxy() when running several tests
https://bugs.webkit.org/show_bug.cgi?id=173315
Reviewed by Darin Adler.
This has started to happen after r218165, but I don't think it's a regression, but that r218165 revealed the bug
somehow in WTR. The problem is that GeolocationProviderMock keeps a pointer to the WKGeolocationManagerRef
returned by WKContextGetGeolocationManager. But in TestController::generatePageConfiguration() the context is
freed before the GeolocationProviderMock. When the GeolocationProviderMock is then destroyed, it calls
WKGeolocationManagerSetProvider(m_geolocationManager, 0); but the WKGeolocationManagerRef has already been
destroyed. GeolocationProviderMock should keep a reference to the WKContext to ensure the
WKGeolocationManagerRef is not destroyed.
- WebKitTestRunner/GeolocationProviderMock.cpp:
(WTR::GeolocationProviderMock::GeolocationProviderMock):
- WebKitTestRunner/GeolocationProviderMock.h:
- 10:41 AM Changeset in webkit [218182] by
-
- 5 edits2 adds in trunk
getReceivers() should return transceivers that have only an active receiver
https://bugs.webkit.org/show_bug.cgi?id=173313
Patch by Youenn Fablet <youenn@apple.com> on 2017-06-13
Reviewed by Alex Christensen.
Source/WebCore:
Test: webrtc/video-receivers.html
Creating transceivers for receivers created from an offer.
Setting these as recvonly.
- Modules/mediastream/RTCRtpTransceiver.h:
- Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
(WebCore::LibWebRTCPeerConnectionBackend::videoReceiver):
(WebCore::LibWebRTCPeerConnectionBackend::audioReceiver):
LayoutTests:
- fast/mediastream/RTCPeerConnection-addTrack-reuse-sender-expected.txt:
- webrtc/video-receivers-expected.txt: Added.
- webrtc/video-receivers.html: Added.
- 10:31 AM Changeset in webkit [218181] by
-
- 132 edits7 copies107 adds5 deletes in trunk/LayoutTests
Refresh WPT tests up to cb7017e654fb4daddb9dee8d654c78b26e61fa9f
https://bugs.webkit.org/show_bug.cgi?id=173260
Patch by Youenn Fablet <youenn@apple.com> on 2017-06-13
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- resources/TestRepositories:
- resources/import-expectations.json:
- resources/resource-files.json:
- web-platform-tests/FileAPI/BlobURL/support/file_test2.txt: Added.
- web-platform-tests/FileAPI/FileReader/support/file_test1.txt: Added.
- web-platform-tests/IndexedDB/large-nested-cloning-expected.txt: Added.
- web-platform-tests/IndexedDB/large-nested-cloning.html: Added.
- web-platform-tests/IndexedDB/large-requests-abort-expected.txt: Added.
- web-platform-tests/IndexedDB/large-requests-abort.html: Added.
- web-platform-tests/IndexedDB/request-event-ordering-expected.txt: Added.
- web-platform-tests/IndexedDB/request-event-ordering.html: Added.
- web-platform-tests/IndexedDB/support-promises.js:
- web-platform-tests/IndexedDB/w3c-import.log:
- web-platform-tests/README.md:
- web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.worker-expected.txt:
- web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-PSS.worker-expected.txt:
- web-platform-tests/WebCryptoAPI/generateKey/test_failures.https-expected.txt:
- web-platform-tests/WebCryptoAPI/generateKey/test_failures_RSA-PSS.https-expected.txt:
- web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSA-PSS.https-expected.txt:
- web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker-expected.txt:
- web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https-expected.txt:
- web-platform-tests/WebCryptoAPI/sign_verify/rsa_pkcs.worker-expected.txt:
- web-platform-tests/WebCryptoAPI/sign_verify/rsa_pss.worker-expected.txt:
- web-platform-tests/WebCryptoAPI/sign_verify/test_rsa_pkcs.https-expected.txt:
- web-platform-tests/WebCryptoAPI/sign_verify/test_rsa_pss.https-expected.txt:
- web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/test_wrapKey_unwrapKey.https-expected.txt:
- web-platform-tests/XMLHttpRequest/anonymous-mode-unsupported-expected.txt:
- web-platform-tests/XMLHttpRequest/open-after-setrequestheader-expected.txt:
- web-platform-tests/XMLHttpRequest/open-referer-expected.txt:
- web-platform-tests/XMLHttpRequest/open-url-redirected-worker-origin-expected.txt:
- web-platform-tests/XMLHttpRequest/resources/infinite-redirects.py:
(main):
- web-platform-tests/XMLHttpRequest/responsetype-expected.txt:
- web-platform-tests/XMLHttpRequest/send-accept-language-expected.txt:
- web-platform-tests/XMLHttpRequest/send-blob-with-no-mime-type-expected.txt:
- web-platform-tests/XMLHttpRequest/setrequestheader-allow-empty-value-expected.txt:
- web-platform-tests/XMLHttpRequest/setrequestheader-allow-whitespace-in-value-expected.txt:
- web-platform-tests/XMLHttpRequest/setrequestheader-case-insensitive-expected.txt:
- web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt:
- web-platform-tests/XMLHttpRequest/setrequestheader-header-allowed-expected.txt:
- web-platform-tests/XMLHttpRequest/setrequestheader-header-forbidden-expected.txt:
- web-platform-tests/XMLHttpRequest/setrequestheader-open-setrequestheader-expected.txt:
- web-platform-tests/XMLHttpRequest/timeout-sync-expected.txt:
- web-platform-tests/check_stability.py:
(Browser.wptrunner_args):
(Chrome.wptrunner_args):
(main):
- web-platform-tests/ci_unittest.sh:
- web-platform-tests/css/css-scoping-1/css-scoping-shadow-host-namespace-expected.html: Added.
- web-platform-tests/css/css-scoping-1/css-scoping-shadow-host-namespace.html: Added.
- web-platform-tests/css/css-scoping-1/w3c-import.log:
- web-platform-tests/css/css-shapes-1/OWNERS: Added.
- web-platform-tests/css/selectors4/w3c-import.log:
- web-platform-tests/cssom/w3c-import.log:
- web-platform-tests/custom-elements/parser/parser-fallsback-to-unknown-element-expected.txt:
- web-platform-tests/dom/nodes/Document-constructor-svg-expected.txt: Added.
- web-platform-tests/dom/nodes/Document-constructor-svg.svg: Added.
- web-platform-tests/dom/nodes/Document-constructor-xml-expected.txt: Added.
- web-platform-tests/dom/nodes/Document-constructor-xml.xml: Copied from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Document-constructor.html.
- web-platform-tests/dom/nodes/Document-constructor.html:
- web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_01-expected.txt:
- web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_02-expected.txt:
- web-platform-tests/dom/nodes/Element-matches-expected.txt:
- web-platform-tests/dom/nodes/Element-webkitMatchesSelector-expected.txt:
- web-platform-tests/dom/nodes/ParentNode-querySelector-All-content.html:
- web-platform-tests/dom/nodes/ParentNode-querySelector-All-content.xht:
- web-platform-tests/dom/nodes/ParentNode-querySelector-All-expected.txt:
- web-platform-tests/dom/nodes/ParentNode-querySelector-All-xht-expected.txt:
- web-platform-tests/dom/nodes/ParentNode-querySelector-All.js:
(setupSpecialElements):
- web-platform-tests/dom/nodes/getElementsByClassName-14-expected.txt:
- web-platform-tests/dom/nodes/getElementsByClassName-14.htm:
- web-platform-tests/dom/nodes/selectors.js:
- web-platform-tests/dom/nodes/w3c-import.log:
- web-platform-tests/encrypted-media/scripts/requestmediakeysystemaccess.js:
- web-platform-tests/fetch/api/basic/request-headers.any-expected.txt:
- web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt:
- web-platform-tests/fetch/api/headers/headers-record-expected.txt:
- web-platform-tests/fetch/api/headers/headers-record.html:
- web-platform-tests/fetch/dangling-markup-mitigation.tentative-expected.txt: Added.
- web-platform-tests/fetch/dangling-markup-mitigation.tentative.html: Added.
- web-platform-tests/fetch/w3c-import.log:
- web-platform-tests/html/browsers/history/the-location-interface/location-origin-idna.sub.window.js: Added.
- web-platform-tests/html/browsers/history/the-location-interface/resources/post-your-origin.html: Added.
- web-platform-tests/html/browsers/history/the-location-interface/resources/w3c-import.log:
- web-platform-tests/html/browsers/history/the-location-interface/w3c-import.log:
- web-platform-tests/html/browsers/the-window-object/window-open-noopener-expected.txt:
- web-platform-tests/html/dom/documents/resource-metadata-management/document-lastModified-expected.txt:
- web-platform-tests/html/dom/elements-metadata.js:
- web-platform-tests/html/dom/elements-misc.js:
- web-platform-tests/html/dom/elements/elements-in-the-dom/historical-expected.txt:
- web-platform-tests/html/dom/elements/elements-in-the-dom/historical.html:
- web-platform-tests/html/dom/interfaces.worker-expected.txt:
- web-platform-tests/html/dom/reflection.js:
(ReflectionTests.reflects):
(ReflectionTests.enumExpected):
- web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/not-in-shadow-tree-expected.txt:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/HTMLElement/HTMLTrackElement/srclang-expected.txt:
- web-platform-tests/html/semantics/embedded-content/media-elements/interfaces/TextTrack/language-expected.txt:
- web-platform-tests/html/semantics/embedded-content/the-img-element/ismap/img-ismap-coordinates-iframe-after.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-img-element/ismap/img-ismap-coordinates-iframe-before.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-img-element/ismap/img-ismap-coordinates-iframe-inside.html: Added.
- web-platform-tests/html/semantics/embedded-content/the-img-element/ismap/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/resources/w3c-import.log.
- web-platform-tests/html/semantics/forms/the-input-element/valueMode-expected.txt:
- web-platform-tests/html/semantics/forms/the-input-element/valueMode.html:
- web-platform-tests/html/semantics/forms/the-option-element/option-element-constructor-expected.txt:
- web-platform-tests/html/semantics/forms/the-option-element/option-element-constructor.html:
- web-platform-tests/html/semantics/interactive-elements/contextmenu-historical-expected.txt: Added.
- web-platform-tests/html/semantics/interactive-elements/contextmenu-historical.html: Added.
- web-platform-tests/html/semantics/interactive-elements/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/w3c-import.log.
- web-platform-tests/html/semantics/interfaces.js:
- web-platform-tests/html/semantics/selectors/pseudo-classes/checked-expected.txt:
- web-platform-tests/html/semantics/selectors/pseudo-classes/checked.html:
- web-platform-tests/html/semantics/selectors/pseudo-classes/enabled-expected.txt:
- web-platform-tests/html/semantics/selectors/pseudo-classes/enabled.html:
- web-platform-tests/html/webappapis/scripting/events/event-handler-all-global-events-expected.txt: Added.
- web-platform-tests/html/webappapis/scripting/events/event-handler-all-global-events.html: Added.
- web-platform-tests/html/webappapis/scripting/events/event-handler-onauxclick-expected.txt: Removed.
- web-platform-tests/html/webappapis/scripting/events/event-handler-onauxclick.html: Removed.
- web-platform-tests/html/webappapis/scripting/events/inline-event-handler-ordering-expected.txt:
- web-platform-tests/html/webappapis/scripting/events/inline-event-handler-ordering.html:
- web-platform-tests/html/webappapis/scripting/events/invalid-uncompiled-raw-handler-compiled-late.html:
- web-platform-tests/html/webappapis/scripting/events/w3c-import.log:
- web-platform-tests/html/webappapis/scripting/processing-model-2/window-onerror-parse-error-expected.txt:
- web-platform-tests/html/webappapis/scripting/processing-model-2/window-onerror-runtime-error-expected.txt:
- web-platform-tests/html/webappapis/scripting/processing-model-2/window-onerror-runtime-error-throw-expected.txt:
- web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/NavigatorID.worker-expected.txt:
- web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-pluginarray-expected.txt: Added.
- web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/navigator-pluginarray.html: Added.
- web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/w3c-import.log:
- web-platform-tests/lint.whitelist:
- web-platform-tests/resources/OWNERS: Added.
- web-platform-tests/resources/idlharness.js:
(IdlArray.prototype.assert_type_is):
(IdlInterface.prototype.test_self):
(IdlInterface.prototype.test_member_const):
(IdlInterface.prototype.test_member_attribute):
(IdlInterface.prototype.do_member_operation_asserts):
(IdlInterface.prototype.test_member_iterable):
(IdlInterface.prototype.test_member_stringifier):
(IdlInterface.prototype.do_interface_attribute_asserts):
- web-platform-tests/resources/test/README.md: Added.
- web-platform-tests/resources/test/config.test.json: Added.
- web-platform-tests/resources/test/conftest.py: Added.
(pytest_collect_file):
(pytest_configure):
(HTMLItem):
(HTMLItem.init):
(HTMLItem.reportinfo):
(HTMLItem.repr_failure):
(HTMLItem.runtest):
(HTMLItem._assert_sequence):
(HTMLItem._scrub_stack):
(HTMLItem._expand_status):
(HTMLItem._summarize_test):
(HTMLItem._summarize_status):
- web-platform-tests/resources/test/harness.html: Added.
- web-platform-tests/resources/test/tests/add_cleanup.html: Added.
- web-platform-tests/resources/test/tests/add_cleanup_err.html: Added.
- web-platform-tests/resources/test/tests/add_cleanup_err_multi.html: Added.
- web-platform-tests/resources/test/tests/api-tests-1.html: Added.
- web-platform-tests/resources/test/tests/api-tests-2.html: Added.
- web-platform-tests/resources/test/tests/api-tests-3.html: Added.
- web-platform-tests/resources/test/tests/generate-callback.html: Added.
- web-platform-tests/resources/test/tests/iframe-callback.html: Added.
- web-platform-tests/resources/test/tests/iframe-consolidate-errors.html: Added.
- web-platform-tests/resources/test/tests/iframe-consolidate-tests.html: Added.
- web-platform-tests/resources/test/tests/iframe-msg.html: Added.
- web-platform-tests/resources/test/tests/order.html: Added.
- web-platform-tests/resources/test/tests/promise-async.html: Added.
- web-platform-tests/resources/test/tests/promise.html: Added.
- web-platform-tests/resources/test/tests/single-page-test-fail.html: Added.
- web-platform-tests/resources/test/tests/single-page-test-no-assertions.html: Added.
- web-platform-tests/resources/test/tests/single-page-test-no-body.html: Added.
- web-platform-tests/resources/test/tests/single-page-test-pass.html: Added.
- web-platform-tests/resources/test/tests/uncaught-exception-handle.html: Added.
- web-platform-tests/resources/test/tests/uncaught-exception-ignore.html: Added.
- web-platform-tests/resources/test/tests/w3c-import.log: Added.
- web-platform-tests/resources/test/tests/worker-dedicated.html: Added.
- web-platform-tests/resources/test/tests/worker-error.js: Added.
- web-platform-tests/resources/test/tests/worker-service.html: Added.
- web-platform-tests/resources/test/tests/worker-shared.html: Added.
- web-platform-tests/resources/test/tests/worker.js: Added.
(test):
(async_test):
- web-platform-tests/resources/test/tox.ini: Added.
- web-platform-tests/resources/test/w3c-import.log: Copied from LayoutTests/imported/w3c/web-platform-tests/fetch/w3c-import.log.
- web-platform-tests/resources/test/wptserver.py: Added.
(WPTServer):
(WPTServer.init):
(WPTServer.start):
(WPTServer.stop):
(WPTServer.url):
- web-platform-tests/resources/testharness.js:
- web-platform-tests/resources/w3c-import.log:
- web-platform-tests/shadow-dom/slotchange-event-expected.txt:
- web-platform-tests/shadow-dom/slotchange-event.html:
- web-platform-tests/shadow-dom/slots-expected.txt:
- web-platform-tests/shadow-dom/slots-fallback-expected.txt:
- web-platform-tests/shadow-dom/slots-fallback-in-document-expected.txt:
- web-platform-tests/shadow-dom/slots-fallback-in-document.html:
- web-platform-tests/shadow-dom/slots-fallback.html:
- web-platform-tests/shadow-dom/slots.html:
- web-platform-tests/streams/piping/general-expected.txt:
- web-platform-tests/tools/OWNERS: Added.
- web-platform-tests/tools/browserutils/browser.py:
(Firefox.install):
(Firefox.find_certutil):
(Firefox.install_webdriver):
(Chrome.install_webdriver):
(Chrome.prepare_environment):
(Edge):
(Edge.install):
(Edge.find_webdriver):
(Edge.install_webdriver):
(Edge.version):
(Servo):
(Servo.install):
(Servo.find_binary):
(Servo.find_webdriver):
(Servo.install_webdriver):
(Servo.version):
- web-platform-tests/tools/browserutils/install.py: Added.
- web-platform-tests/tools/browserutils/requirements.txt: Added.
- web-platform-tests/tools/browserutils/utils.py:
(get):
- web-platform-tests/tools/browserutils/virtualenv.py:
(Virtualenv.create):
(Virtualenv.install):
- web-platform-tests/tools/browserutils/w3c-import.log:
- web-platform-tests/tools/runner/index.html:
- web-platform-tests/tools/runner/runner.css:
(#current_test):
(#current_test a):
(#current_test .match):
- web-platform-tests/tools/runner/runner.js:
(ManifestIterator.prototype.match_location):
(ManifestIterator.prototype.matches):
(VisualOutput.prototype.on_result):
(VisualOutput.prototype.steady_status):
(this.skip_button.onclick):
(Runner):
(Runner.prototype.run_next_test):
(Runner.prototype.display_current_test):
- web-platform-tests/tools/w3c-import.log:
- web-platform-tests/tools/wptrun.py:
(args_general):
(check_environ):
(args_edge):
(setup_edge):
(args_servo):
(setup_servo):
(setup_wptrunner):
(main):
- web-platform-tests/tools/wptrunner/OWNERS: Added.
- web-platform-tests/tools/wptrunner/requirements_edge.txt: Added.
- web-platform-tests/tools/wptrunner/tox.ini:
- web-platform-tests/tools/wptrunner/w3c-import.log:
- web-platform-tests/tools/wptrunner/wptrunner/browsers/edge.py:
(browser_kwargs):
- web-platform-tests/tools/wptrunner/wptrunner/environment.py:
(TestEnvironment.ensure_started):
(TestEnvironment):
(TestEnvironment.test_servers):
- web-platform-tests/tools/wptrunner/wptrunner/executors/executorservo.py:
(ServoTestharnessExecutor.init):
- web-platform-tests/update-built-tests.sh:
- web-platform-tests/url/interfaces.any-expected.txt:
- web-platform-tests/url/interfaces.any.js:
- web-platform-tests/url/interfaces.any.worker-expected.txt:
- web-platform-tests/url/toascii.json: Added.
- web-platform-tests/url/toascii.window.js: Added.
(async_test.t.string_appeared_here.request.send.request.responseType.string_appeared_here.request.onload.t.step_func_done):
(string_appeared_here.makeURL):
(runTests):
- web-platform-tests/url/w3c-import.log:
- web-platform-tests/webrtc/OWNERS:
- web-platform-tests/webrtc/RTCCertificate-expected.txt: Added.
- web-platform-tests/webrtc/RTCCertificate.html: Added.
- web-platform-tests/webrtc/RTCPeerConnection-addTransceiver-expected.txt: Added.
- web-platform-tests/webrtc/RTCPeerConnection-addTransceiver.html: Added.
- web-platform-tests/webrtc/RTCPeerConnection-constructor-expected.txt:
- web-platform-tests/webrtc/RTCPeerConnection-constructor.html:
- web-platform-tests/webrtc/RTCPeerConnection-createAnswer-expected.txt: Added.
- web-platform-tests/webrtc/RTCPeerConnection-createAnswer.html: Added.
- web-platform-tests/webrtc/RTCPeerConnection-createDataChannel-expected.txt:
- web-platform-tests/webrtc/RTCPeerConnection-createDataChannel.html:
- web-platform-tests/webrtc/RTCPeerConnection-createOffer-expected.txt: Added.
- web-platform-tests/webrtc/RTCPeerConnection-createOffer.html: Added.
- web-platform-tests/webrtc/RTCPeerConnection-generateCertificate-expected.txt: Added.
- web-platform-tests/webrtc/RTCPeerConnection-generateCertificate.html: Added.
- web-platform-tests/webrtc/RTCPeerConnection-getTransceivers-expected.txt: Added.
- web-platform-tests/webrtc/RTCPeerConnection-getTransceivers.html: Added.
- web-platform-tests/webrtc/RTCPeerConnection-helper.js: Added.
(countLine):
(countAudioLine):
(countVideoLine):
(countApplicationLine):
(similarMediaDescriptions):
(assert_is_session_description):
(assert_session_desc_equals):
(assert_session_desc_not_equals):
(generateOffer):
- web-platform-tests/webrtc/RTCPeerConnection-onnegotiationneeded-expected.txt: Added.
- web-platform-tests/webrtc/RTCPeerConnection-onnegotiationneeded.html: Added.
- web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription-expected.txt: Added.
- web-platform-tests/webrtc/RTCPeerConnection-setLocalDescription.html: Added.
- web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-expected.txt:
- web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription.html:
- web-platform-tests/webrtc/RTCPeerConnectionIceEvent-constructor-expected.txt:
- web-platform-tests/webrtc/RTCPeerConnectionIceEvent-constructor.html:
- web-platform-tests/webrtc/RTCSctpTransport-constructor-expected.txt: Added.
- web-platform-tests/webrtc/RTCSctpTransport-constructor.html: Added.
- web-platform-tests/webrtc/w3c-import.log:
- web-platform-tests/wptrun:
LayoutTests:
- TestExpectations:
- platform/ios-simulator-wk2/TestExpectations:
- platform/mac-wk1/imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/test_wrapKey_unwrapKey.https-expected.txt: Added.
- platform/mac/imported/w3c/web-platform-tests/html/webappapis/system-state-and-capabilities/the-navigator-object/NavigatorID.worker-expected.png: Added.
- tests-options.json:
- 9:58 AM Changeset in webkit [218180] by
-
- 8 edits2 adds in trunk
Unable to paste text that was copied from a page into the universal search field
https://bugs.webkit.org/show_bug.cgi?id=173293
<rdar://problem/32440918>
Reviewed by Ryosuke Niwa.
Source/WebCore:
Vend "public.utf8-plain-text" and "public.utf16-plain-text" as additional representations on the pasteboard when
copying both rich and plain web content in PlatformPasteboardIOS.mm. This is because UITextView no longer
supports pasting "public.text" as text in iOS 11.
Tests:
UIPasteboardTests.CopyPlainTextWritesConcreteTypes
UIPasteboardTests.CopyRichTextWritesConcreteTypes
- platform/ios/PasteboardIOS.mm:
(WebCore::Pasteboard::writePlainText):
- platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::write):
Source/WebKit2:
Add boilerplate SPI on WKPreferences to enable JavaScript access to copy and paste.
- UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _setJavaScriptCanAccessClipboard:]):
(-[WKPreferences _javaScriptCanAccessClipboard]):
- UIProcess/API/Cocoa/WKPreferencesPrivate.h:
Tools:
Adds 2 new unit tests for copying plain and rich selected web content.
See WebCore and WebKit ChangeLogs for more detail.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/rich-and-plain-text.html: Added.
- TestWebKitAPI/Tests/ios/UIPasteboardTests.mm: Added.
(TestWebKitAPI::dataForPasteboardType):
(TestWebKitAPI::setUpWebViewForPasteboardTests):
(TestWebKitAPI::TEST):
- 9:47 AM Changeset in webkit [218179] by
-
- 35 edits2 moves in trunk/Source
Rename JSDOMWindowShell to JSDOMWindowProxy to match the HTML5 spec.
https://bugs.webkit.org/show_bug.cgi?id=80733
Patch by Sam Weinig <sam@webkit.org> on 2017-06-13
Reviewed by Chris Dumez.
Source/WebCore:
Goodbye dear shell.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/DOMWrapperWorld.cpp:
(WebCore::DOMWrapperWorld::~DOMWrapperWorld):
(WebCore::DOMWrapperWorld::clearWrappers):
- bindings/js/DOMWrapperWorld.h:
(WebCore::DOMWrapperWorld::didCreateWindowProxy):
(WebCore::DOMWrapperWorld::didDestroyWindowProxy):
(WebCore::DOMWrapperWorld::didCreateWindowShell): Deleted.
(WebCore::DOMWrapperWorld::didDestroyWindowShell): Deleted.
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::JSDOMWindowBase):
(WebCore::JSDOMWindowBase::finishCreation):
(WebCore::JSDOMWindowBase::willRemoveFromWindowProxy):
(WebCore::JSDOMWindowBase::proxy):
(WebCore::toJSDOMWindow):
(WebCore::JSDOMWindowBase::willRemoveFromWindowShell): Deleted.
(WebCore::JSDOMWindowBase::shell): Deleted.
- bindings/js/JSDOMWindowBase.h:
(WebCore::toJS):
(WebCore::toJSDOMWindow):
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::toWrapped):
- bindings/js/JSDOMWindowCustom.h:
- bindings/js/JSDOMWindowProperties.h:
(WebCore::JSDOMWindowProperties::JSDOMWindowProperties):
- bindings/js/JSDOMWindowProxy.cpp: Copied from WebCore/bindings/js/JSDOMWindowShell.cpp.
(WebCore::JSDOMWindowProxy::JSDOMWindowProxy):
(WebCore::JSDOMWindowProxy::finishCreation):
(WebCore::JSDOMWindowProxy::destroy):
(WebCore::JSDOMWindowProxy::setWindow):
(WebCore::JSDOMWindowProxy::wrapped):
(WebCore::JSDOMWindowProxy::toWrapped):
(WebCore::toJS):
(WebCore::toJSDOMWindowProxy):
(WebCore::JSDOMWindowShell::JSDOMWindowShell): Deleted.
(WebCore::JSDOMWindowShell::finishCreation): Deleted.
(WebCore::JSDOMWindowShell::destroy): Deleted.
(WebCore::JSDOMWindowShell::setWindow): Deleted.
(WebCore::JSDOMWindowShell::wrapped): Deleted.
(WebCore::JSDOMWindowShell::toWrapped): Deleted.
(WebCore::toJSDOMWindowShell): Deleted.
- bindings/js/JSDOMWindowProxy.h: Copied from WebCore/bindings/js/JSDOMWindowShell.h.
(WebCore::JSDOMWindowProxy::create):
(WebCore::toJSDOMWindowProxy):
(WebCore::JSDOMWindowShell::window): Deleted.
(WebCore::JSDOMWindowShell::create): Deleted.
(WebCore::JSDOMWindowShell::createStructure): Deleted.
(WebCore::JSDOMWindowShell::world): Deleted.
(WebCore::toJSDOMWindowShell): Deleted.
- bindings/js/JSDOMWindowShell.cpp: Removed.
- bindings/js/JSDOMWindowShell.h: Removed.
- bindings/js/JSEventTargetCustom.cpp:
(WebCore::JSEventTarget::toWrapped):
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::open):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
- bindings/js/ScriptCachedFrameData.cpp:
(WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
(WebCore::ScriptCachedFrameData::restore):
- bindings/js/ScriptController.cpp:
(WebCore::collectGarbageAfterWindowProxyDestruction):
(WebCore::ScriptController::~ScriptController):
(WebCore::ScriptController::destroyWindowProxy):
(WebCore::ScriptController::createWindowProxy):
(WebCore::ScriptController::evaluateInWorld):
(WebCore::ScriptController::loadModuleScriptInWorld):
(WebCore::ScriptController::linkAndEvaluateModuleScriptInWorld):
(WebCore::ScriptController::evaluateModule):
(WebCore::ScriptController::windowProxies):
(WebCore::ScriptController::clearWindowProxiesNotMatchingDOMWindow):
(WebCore::ScriptController::setDOMWindowForWindowProxy):
(WebCore::ScriptController::initScript):
(WebCore::ScriptController::setupModuleScriptHandlers):
(WebCore::ScriptController::eventHandlerPosition):
(WebCore::ScriptController::enableEval):
(WebCore::ScriptController::disableEval):
(WebCore::ScriptController::canAccessFromCurrentOrigin):
(WebCore::ScriptController::attachDebugger):
(WebCore::ScriptController::updateDocument):
(WebCore::ScriptController::cacheableBindingRootObject):
(WebCore::ScriptController::bindingRootObject):
(WebCore::ScriptController::createRootObject):
(WebCore::ScriptController::collectIsolatedContexts):
(WebCore::ScriptController::windowScriptNPObject):
(WebCore::ScriptController::jsObjectForPluginElement):
(WebCore::ScriptController::cleanupScriptObjectsForPlugin):
(WebCore::ScriptController::clearScriptObjects):
(WebCore::ScriptController::executeIfJavaScriptURL):
(WebCore::collectGarbageAfterWindowShellDestruction): Deleted.
(WebCore::ScriptController::destroyWindowShell): Deleted.
(WebCore::ScriptController::createWindowShell): Deleted.
(WebCore::ScriptController::windowShells): Deleted.
(WebCore::ScriptController::clearWindowShellsNotMatchingDOMWindow): Deleted.
(WebCore::ScriptController::setDOMWindowForWindowShell): Deleted.
- bindings/js/ScriptController.h:
(WebCore::ScriptController::windowProxy):
(WebCore::ScriptController::existingWindowProxy):
(WebCore::ScriptController::globalObject):
(WebCore::ScriptController::windowShell): Deleted.
(WebCore::ScriptController::existingWindowShell): Deleted.
- bindings/js/ScriptControllerMac.mm:
(WebCore::ScriptController::windowScriptObject):
- bindings/js/ScriptState.cpp:
(WebCore::mainWorldExecState):
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateOverloadDispatcher):
(GenerateImplementation):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionOverloadedMethodOverloadDispatcher):
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::clear):
(WebCore::FrameLoader::dispatchDidClearWindowObjectInWorld):
- page/Frame.cpp:
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::didCreateWindowProxy):
(WebCore::ContentSecurityPolicy::didCreateWindowShell): Deleted.
- page/csp/ContentSecurityPolicy.h:
Source/WebInspectorUI:
- UserInterface/Workers/HeapSnapshot/HeapSnapshot.js:
(HeapSnapshot.prototype._isNodeGlobalObject):
Source/WebKit/mac:
- DOM/DOMUtility.mm:
(createDOMWrapper):
- Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::getWindowNPObject):
- WebView/WebFrame.mm:
(-[WebFrame _attachScriptDebugger]):
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
Source/WebKit/win:
- WebFrame.cpp:
(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
Source/WebKit2:
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::windowScriptNPObject):
- 9:21 AM Changeset in webkit [218178] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix typo in variable introduced in r218108.
- page/cocoa/MemoryReleaseCocoa.mm:
(WebCore::platformReleaseMemory):
(WebCore::registerSQLiteMemoryPressureHandler):
- 5:42 AM Changeset in webkit [218177] by
-
- 9 edits2 moves2 adds in trunk
AX: [ATK] Implement missing AtkRelation types
https://bugs.webkit.org/show_bug.cgi?id=155494
Reviewed by Darin Adler.
Source/WebCore:
Add methods for getting the element(s) which reference a particular element via an
ARIA attribute. Then use those methods to identify and expose the expected reverse/
reciprocal AtkRelationType and targets. Also add ATK support for aria-owns.
Use SpaceSplitString in AccessibilityObject::elementsFromAttribute() so that unexpected
whitespace characters in an attribute's list of ids does not prevent the desired element
from being found.
Lastly, change the return type of AccessibilityObject::identifierAttribute() from a String
to a const AtomicString& for better efficiency.
Tests: accessibility/aria-owns.html
accessibility/gtk/relation-types.html
- accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::identifierAttribute):
(WebCore::AccessibilityObject::elementsFromAttribute):
(WebCore::AccessibilityObject::ariaElementsReferencedByAttribute):
(WebCore::AccessibilityObject::ariaControlsReferencingElements):
(WebCore::AccessibilityObject::ariaDescribedByReferencingElements):
(WebCore::AccessibilityObject::ariaFlowToReferencingElements):
(WebCore::AccessibilityObject::ariaLabelledByReferencingElements):
(WebCore::AccessibilityObject::ariaOwnsReferencingElements):
- accessibility/AccessibilityObject.h:
- accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(setAtkRelationSetFromCoreObject):
Tools:
Add additional methods to test ARIA properties which are exposed via
AtkRelation. Implement ATK support for ariaOwnsElementAtIndex().
- WebKitTestRunner/InjectedBundle/AccessibilityUIElement.h:
(WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
(WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
(WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
(WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
(WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
- WebKitTestRunner/InjectedBundle/Bindings/AccessibilityUIElement.idl:
- WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:
(WTR::AccessibilityUIElement::ariaOwnsElementAtIndex):
(WTR::AccessibilityUIElement::ariaOwnsReferencingElementAtIndex):
(WTR::AccessibilityUIElement::ariaFlowToReferencingElementAtIndex):
(WTR::AccessibilityUIElement::ariaControlsReferencingElementAtIndex):
(WTR::AccessibilityUIElement::ariaLabelledByElementAtIndex):
(WTR::AccessibilityUIElement::ariaLabelledByReferencingElementAtIndex):
(WTR::AccessibilityUIElement::ariaDescribedByElementAtIndex):
(WTR::AccessibilityUIElement::ariaDescribedByReferencingElementAtIndex):
LayoutTests:
- accessibility/aria-owns-expected.txt: Renamed from LayoutTests/accessibility/mac/aria-owns-expected.txt.
- accessibility/aria-owns.html: Renamed from LayoutTests/accessibility/mac/aria-owns.html.
- accessibility/gtk/relation-types-expected.txt: Added.
- accessibility/gtk/relation-types.html: Added.
- 5:39 AM Changeset in webkit [218176] by
-
- 3 edits in trunk/Source/WebKit2
Unreviewed. Remove unused code from GTK+ WebKitPrivate.
- UIProcess/API/gtk/WebKitPrivate.cpp:
(wkEventModifiersToGdkModifiers): Deleted.
(wkEventMouseButtonToWebKitMouseButton): Deleted.
- UIProcess/API/gtk/WebKitPrivate.h:
- 5:19 AM Changeset in webkit [218175] by
-
- 2 edits in trunk/LayoutTests
[WPE] Ensure that fast/url/user-visible tests are skipped
Unreviewed gardening.
Tests under this directory are currently Mac specific, so skip the
directory altogether.
- platform/wpe/TestExpectations:
- 5:00 AM Changeset in webkit [218174] by
-
- 2 edits in trunk/Source/WebKit2
Unreviewed. Fix return value of PageLoaderClient::shouldGoToBackForwardListItem after r218164.
It should return true as InjectedBundlePageLoaderClient does. This caused several timeouts in GTK+ unit tests
after r218171.
- WebProcess/InjectedBundle/API/APIInjectedBundlePageLoaderClient.h:
(API::InjectedBundle::PageLoaderClient::shouldGoToBackForwardListItem):
- 3:34 AM Changeset in webkit [218173] by
-
- 4 edits in trunk/Source/WebKit2
[GTK] Use API::GeolocationProvider in WebKitGeolocationProvider
https://bugs.webkit.org/show_bug.cgi?id=173151
Reviewed by Žan Doberšek.
Also cleanup a bit the WebKitGeolocationProvider implementation, it doesn't need to be refcounted.
- UIProcess/API/gtk/WebKitGeolocationProvider.cpp:
(WebKit::GeolocationProvider::GeolocationProvider):
(WebKit::WebKitGeolocationProvider::~WebKitGeolocationProvider):
(WebKit::WebKitGeolocationProvider::WebKitGeolocationProvider):
(toGeolocationProvider): Deleted.
(startUpdatingCallback): Deleted.
(stopUpdatingCallback): Deleted.
(WebKitGeolocationProvider::~WebKitGeolocationProvider): Deleted.
(WebKitGeolocationProvider::create): Deleted.
(WebKitGeolocationProvider::WebKitGeolocationProvider): Deleted.
(WebKitGeolocationProvider::startUpdating): Deleted.
(WebKitGeolocationProvider::stopUpdating): Deleted.
(WebKitGeolocationProvider::notifyPositionChanged): Deleted.
(WebKitGeolocationProvider::notifyErrorOccurred): Deleted.
- UIProcess/API/gtk/WebKitGeolocationProvider.h:
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextConstructed):
- 3:31 AM Changeset in webkit [218172] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Use API::IconDatabaseClient in WebKitFaviconDatabase
https://bugs.webkit.org/show_bug.cgi?id=173146
Reviewed by Žan Doberšek.
- UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
(_WebKitFaviconDatabasePrivate::~_WebKitFaviconDatabasePrivate):
(webkitFaviconDatabaseCreate):
(didChangeIconForPageURLCallback): Deleted.
(iconDataReadyForPageURLCallback): Deleted.
- 3:30 AM Changeset in webkit [218171] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Use API::InjectedBundle::PageLoaderClient in WebKitWebPage
https://bugs.webkit.org/show_bug.cgi?id=173304
Reviewed by Alex Christensen.
- WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkitWebPageCreate):
(getDocumentLoaderURL): Deleted.
(didStartProvisionalLoadForFrame): Deleted.
(didReceiveServerRedirectForProvisionalLoadForFrame): Deleted.
(didSameDocumentNavigationForFrame): Deleted.
(didCommitLoadForFrame): Deleted.
(didFinishDocumentLoadForFrame): Deleted.
(didClearWindowObjectForFrame): Deleted.
- 1:29 AM Changeset in webkit [218170] by
-
- 17 edits in trunk/Source
[GStreamerGL] Release GstVideoFrame when there is a flush event from the pipeline
https://bugs.webkit.org/show_bug.cgi?id=172427
Reviewed by Žan Doberšek.
Source/WebCore:
Without GStreamerGL MediaPlayerPrivateGStreamer copies the video frame from
the decoder's buffer to the texture to display a video. So it makes possible
to release the GstSample when it got a flush start event to free the decoder's
buffer to the decoder without side-effects.
Unlike the traditional way to render video, GStreamer GL does not copy a
texture from the decoder to the texture mapper's buffer to draw video frame.
It uses same GstMemory with the gst pipeline to manage the texture to prevent
copy operations. So without releasing a layer buffer, there is no way to
return GstMemory to the buffer pool.
This patch releases current GstSample when the player got the flush start
event. It destructs the platform layer buffer any time there is a flush start
event.
However, it is not enough to release the GstMemory. The platform layer proxy
should copy current buffer to show it to the compositor instead of a blank
frame. It prevents flickerings until getting a new frame after handling flush
events.
No new tests, there shouldn't be behavior changes
- platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBufferData::swapBuffersIfNeeded):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
(WebCore::MediaPlayerPrivateGStreamerBase::flushCurrentBuffer):
(WebCore::MediaPlayerPrivateGStreamerBase::createGLAppSink): Adds
handler for the flush event.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- platform/graphics/texmap/BitmapTextureGL.cpp:
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::BitmapTextureGL::copyFromExternalTexture): Copies
a external texture to the managed texture.
- platform/graphics/texmap/BitmapTextureGL.h:
(WebCore::BitmapTextureGL::create):
To create the managed texture with specific format, this patch adds a
optional parameter for a texture format.
- platform/graphics/texmap/TextureMapper.h:
- platform/graphics/texmap/TextureMapperGC3DPlatformLayer.cpp:
(WebCore::TextureMapperGC3DPlatformLayer::swapBuffersIfNeeded):
- platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::createTexture):
- platform/graphics/texmap/TextureMapperGL.h:
- platform/graphics/texmap/TextureMapperPlatformLayerBuffer.cpp:
(WebCore::TextureMapperPlatformLayerBuffer::TextureMapperPlatformLayerBuffer):
(WebCore::TextureMapperPlatformLayerBuffer::clone):
- platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h:
- platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:
(WebCore::TextureMapperPlatformLayerProxy::appendToUnusedBuffers): Added
to schedule releasing unused buffers in main thread.
(WebCore::TextureMapperPlatformLayerProxy::swapBuffer):
(WebCore::TextureMapperPlatformLayerProxy::dropCurrentBufferWhilePreservingTexture):
- platform/graphics/texmap/TextureMapperPlatformLayerProxy.h:
Source/WebKit2:
- Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
(WebKit::CoordinatedGraphicsScene::texmapGL):
- Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
Provides current texmapGL to platform layer proxies to create and copy
bitmap textures.
- 1:19 AM Changeset in webkit [218169] by
-
- 2 edits in trunk/Source/WebKit2
Switch off Legacy WebRTC API flag by default
https://bugs.webkit.org/show_bug.cgi?id=173241
Patch by Youenn Fablet <youenn@apple.com> on 2017-06-13
Reviewed by Sam Weinig.
- Shared/WebPreferencesDefinitions.h:
- 1:13 AM Changeset in webkit [218168] by
-
- 11 edits in trunk
Filter SDP from ICE candidates in case of local ICE candidate filtering
https://bugs.webkit.org/show_bug.cgi?id=173120
Patch by Youenn Fablet <youenn@apple.com> on 2017-06-13
Reviewed by Eric Carlson.
Source/WebCore:
Covered by updated test.
Adding filtering of local description in getters and createOffer promise.
- Modules/mediastream/MediaEndpointSessionDescription.cpp:
(WebCore::MediaEndpointSessionDescription::toRTCSessionDescription):
- Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::createOfferSucceeded):
(WebCore::filterICECandidate):
(WebCore::PeerConnectionBackend::filterSDP):
- Modules/mediastream/PeerConnectionBackend.h:
- Modules/mediastream/RTCSessionDescription.h:
(WebCore::RTCSessionDescription::setSdp):
- Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
(WebCore::LibWebRTCPeerConnectionBackend::currentLocalDescription):
(WebCore::LibWebRTCPeerConnectionBackend::pendingLocalDescription):
(WebCore::LibWebRTCPeerConnectionBackend::localDescription):
Source/WTF:
Adding split helper routine with functor parameter.
- wtf/text/WTFString.cpp:
(WTF::String::split):
- wtf/text/WTFString.h:
(WTF::String::contains):
LayoutTests:
- webrtc/datachannel/filter-ice-candidate.html: Minor clean-up and
adding assertions to ensure that ICE candidates are also filtered out.
- 1:04 AM Changeset in webkit [218167] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Remove redundant includes in config.h
https://bugs.webkit.org/show_bug.cgi?id=173294
Reviewed by Alex Christensen.
- config.h:
- 12:55 AM Changeset in webkit [218166] by
-
- 3 edits in trunk/Source/WTF
[WTF] Remove redundant includes in config.h
https://bugs.webkit.org/show_bug.cgi?id=173292
Reviewed by Alex Christensen.
- config.h:
- wtf/ExportMacros.h:
Jun 12, 2017:
- 11:59 PM Changeset in webkit [218165] by
-
- 8 edits1 copy in trunk/Source/WebKit2
Add API::GeolocationProvider
https://bugs.webkit.org/show_bug.cgi?id=173150
Reviewed by Alex Christensen.
It will be used by GTK+ port instead of the C API.
- UIProcess/API/APIGeolocationProvider.h: Added.
(API::GeolocationProvider::~GeolocationProvider):
(API::GeolocationProvider::startUpdating):
(API::GeolocationProvider::stopUpdating):
(API::GeolocationProvider::setEnableHighAccuracy):
- UIProcess/API/C/WKGeolocationManager.cpp:
(WKGeolocationManagerSetProvider):
- UIProcess/WebGeolocationManagerProxy.cpp:
(WebKit::WebGeolocationManagerProxy::WebGeolocationManagerProxy):
(WebKit::WebGeolocationManagerProxy::setProvider):
(WebKit::WebGeolocationManagerProxy::processPoolDestroyed):
(WebKit::WebGeolocationManagerProxy::startUpdating):
(WebKit::WebGeolocationManagerProxy::removeRequester):
(WebKit::WebGeolocationManagerProxy::setEnableHighAccuracy):
- UIProcess/WebGeolocationManagerProxy.h:
- UIProcess/WebGeolocationProvider.cpp:
(WebKit::WebGeolocationProvider::WebGeolocationProvider):
(WebKit::WebGeolocationProvider::startUpdating):
(WebKit::WebGeolocationProvider::stopUpdating):
(WebKit::WebGeolocationProvider::setEnableHighAccuracy):
- UIProcess/WebGeolocationProvider.h:
- WebKit2.xcodeproj/project.pbxproj:
- 11:28 PM Changeset in webkit [218164] by
-
- 10 edits1 add in trunk/Source/WebKit2
Add API::InjectedBundle::PageLoaderClient
https://bugs.webkit.org/show_bug.cgi?id=173265
Reviewed by Alex Christensen.
It will be used by the GTK+ port instead of the C API.
- WebKit2.xcodeproj/project.pbxproj:
- WebProcess/InjectedBundle/API/APIInjectedBundlePageLoaderClient.h: Added.
(API::InjectedBundle::PageLoaderClient::willLoadURLRequest):
(API::InjectedBundle::PageLoaderClient::willLoadDataRequest):
(API::InjectedBundle::PageLoaderClient::shouldGoToBackForwardListItem):
(API::InjectedBundle::PageLoaderClient::didStartProvisionalLoadForFrame):
(API::InjectedBundle::PageLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(API::InjectedBundle::PageLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(API::InjectedBundle::PageLoaderClient::didCommitLoadForFrame):
(API::InjectedBundle::PageLoaderClient::didFinishDocumentLoadForFrame):
(API::InjectedBundle::PageLoaderClient::didFinishLoadForFrame):
(API::InjectedBundle::PageLoaderClient::didFinishProgress):
(API::InjectedBundle::PageLoaderClient::didFailLoadWithErrorForFrame):
(API::InjectedBundle::PageLoaderClient::didSameDocumentNavigationForFrame):
(API::InjectedBundle::PageLoaderClient::didReceiveTitleForFrame):
(API::InjectedBundle::PageLoaderClient::didRemoveFrameFromHierarchy):
(API::InjectedBundle::PageLoaderClient::didDisplayInsecureContentForFrame):
(API::InjectedBundle::PageLoaderClient::didRunInsecureContentForFrame):
(API::InjectedBundle::PageLoaderClient::didDetectXSSForFrame):
(API::InjectedBundle::PageLoaderClient::didFirstLayoutForFrame):
(API::InjectedBundle::PageLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(API::InjectedBundle::PageLoaderClient::didLayoutForFrame):
(API::InjectedBundle::PageLoaderClient::didReachLayoutMilestone):
(API::InjectedBundle::PageLoaderClient::didClearWindowObjectForFrame):
(API::InjectedBundle::PageLoaderClient::didCancelClientRedirectForFrame):
(API::InjectedBundle::PageLoaderClient::willPerformClientRedirectForFrame):
(API::InjectedBundle::PageLoaderClient::didHandleOnloadEventsForFrame):
(API::InjectedBundle::PageLoaderClient::globalObjectIsAvailableForFrame):
(API::InjectedBundle::PageLoaderClient::willDisconnectDOMWindowExtensionFromGlobalObject):
(API::InjectedBundle::PageLoaderClient::didReconnectDOMWindowExtensionToGlobalObject):
(API::InjectedBundle::PageLoaderClient::willDestroyGlobalObjectForDOMWindowExtension):
(API::InjectedBundle::PageLoaderClient::shouldForceUniversalAccessFromLocalURL):
(API::InjectedBundle::PageLoaderClient::featuresUsedInPage):
(API::InjectedBundle::PageLoaderClient::willDestroyFrame):
(API::InjectedBundle::PageLoaderClient::userAgentForURL):
(API::InjectedBundle::PageLoaderClient::layoutMilestones):
- WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetPageLoaderClient):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::InjectedBundlePageLoaderClient):
(WebKit::InjectedBundlePageLoaderClient::willLoadURLRequest):
(WebKit::InjectedBundlePageLoaderClient::willLoadDataRequest):
(WebKit::InjectedBundlePageLoaderClient::shouldGoToBackForwardListItem):
(WebKit::InjectedBundlePageLoaderClient::didStartProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFailProvisionalLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didCommitLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishDocumentLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishLoadForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFinishProgress):
(WebKit::InjectedBundlePageLoaderClient::didFailLoadWithErrorForFrame):
(WebKit::InjectedBundlePageLoaderClient::didSameDocumentNavigationForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReceiveTitleForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRemoveFrameFromHierarchy):
(WebKit::InjectedBundlePageLoaderClient::didDisplayInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didRunInsecureContentForFrame):
(WebKit::InjectedBundlePageLoaderClient::didDetectXSSForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFirstLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didFirstVisuallyNonEmptyLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didLayoutForFrame):
(WebKit::InjectedBundlePageLoaderClient::didReachLayoutMilestone):
(WebKit::InjectedBundlePageLoaderClient::didClearWindowObjectForFrame):
(WebKit::InjectedBundlePageLoaderClient::didCancelClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::willPerformClientRedirectForFrame):
(WebKit::InjectedBundlePageLoaderClient::didHandleOnloadEventsForFrame):
(WebKit::InjectedBundlePageLoaderClient::globalObjectIsAvailableForFrame):
(WebKit::InjectedBundlePageLoaderClient::willDisconnectDOMWindowExtensionFromGlobalObject):
(WebKit::InjectedBundlePageLoaderClient::didReconnectDOMWindowExtensionToGlobalObject):
(WebKit::InjectedBundlePageLoaderClient::willDestroyGlobalObjectForDOMWindowExtension):
(WebKit::InjectedBundlePageLoaderClient::shouldForceUniversalAccessFromLocalURL):
(WebKit::InjectedBundlePageLoaderClient::featuresUsedInPage):
(WebKit::InjectedBundlePageLoaderClient::userAgentForURL):
(WebKit::InjectedBundlePageLoaderClient::layoutMilestones):
- WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
- WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::detachedFromParent2):
(WebKit::WebFrameLoaderClient::dispatchDidDispatchOnloadEvents):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidCancelClientRedirect):
(WebKit::WebFrameLoaderClient::dispatchWillPerformClientRedirect):
(WebKit::WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidPushStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidReplaceStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidPopStateWithinPage):
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidReceiveTitle):
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishDocumentLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFinishLoad):
(WebKit::WebFrameLoaderClient::dispatchDidReachLayoutMilestone):
(WebKit::WebFrameLoaderClient::dispatchDidLayout):
(WebKit::WebFrameLoaderClient::shouldGoToHistoryItem):
(WebKit::WebFrameLoaderClient::didDisplayInsecureContent):
(WebKit::WebFrameLoaderClient::didRunInsecureContent):
(WebKit::WebFrameLoaderClient::didDetectXSS):
(WebKit::WebFrameLoaderClient::dispatchDidClearWindowObjectInWorld):
(WebKit::WebFrameLoaderClient::dispatchGlobalObjectAvailable):
(WebKit::WebFrameLoaderClient::dispatchWillDisconnectDOMWindowExtensionFromGlobalObject):
(WebKit::WebFrameLoaderClient::dispatchDidReconnectDOMWindowExtensionToGlobalObject):
(WebKit::WebFrameLoaderClient::dispatchWillDestroyGlobalObjectForDOMWindowExtension):
(WebKit::WebFrameLoaderClient::shouldForceUniversalAccessFromLocalURL):
- WebProcess/WebCoreSupport/WebProgressTrackerClient.cpp:
(WebKit::WebProgressTrackerClient::progressFinished):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setInjectedBundlePageLoaderClient):
(WebKit::WebPage::close):
(WebKit::WebPage::loadRequest):
(WebKit::WebPage::loadDataImpl):
(WebKit::WebPage::userAgent):
(WebKit::WebPage::reportUsedFeatures):
(WebKit::WebPage::dispatchDidReachLayoutMilestone):
- WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::injectedBundleLoaderClient):
- 8:14 PM Changeset in webkit [218163] by
-
- 3 edits in trunk/Source/WebCore
[iOS] [macOS] Stop soft-linking Core Text function in iOS 11 and macOS High Sierra
https://bugs.webkit.org/show_bug.cgi?id=173289
Reviewed by Lucas Forschler.
No new tests because there is no behavior change.
- platform/graphics/ios/FontCacheIOS.mm:
(WebCore::platformFontWithFamilySpecialCase):
- platform/graphics/mac/FontCacheMac.mm:
(WebCore::platformFontWithFamilySpecialCase):
- 8:10 PM Changeset in webkit [218162] by
-
- 2 edits in trunk/LayoutTests
[GTK] skip fast/scrolling/scrolling-tree-includes-frame.html
https://bugs.webkit.org/show_bug.cgi?id=173258
Unreviewed gardening.
GTK doesn't appear to use the scrolling tree, only WK2 Mac and iOS do. Skip it here.
Patch by Charlie Turner <cturner@igalia.com> on 2017-06-12
- platform/gtk/TestExpectations:
- 6:35 PM Changeset in webkit [218161] by
-
- 36 edits13 adds in trunk
[Cocoa] Expand system-ui to include every item in the Core Text cascade list
https://bugs.webkit.org/show_bug.cgi?id=173043
<rdar://problem/21125708>
Reviewed by Simon Fraser.
Source/WebCore:
The concept of the system font on Cocoa platforms represents the entire Core Text cascade list.
However, previously, WebKit only represented system-ui by pulling out the first item in the Core
Text cascade list. Instead, we should make all text rendered with "system-ui" match what the
platform would natively render.
Previously, we walked through the strings in the font-family property and looked them up one by
one. However, now we want to abstract this idea of a font family to possibly hold a
CTFontDescriptorRef instead of a string. This way, we expand a font-family list of ["fontA",
"system-ui", "fontB"] to ["fontA", ... a bunch of CTFontDescriptorRefs ..., "FontB"]. We can
then modify the consumer of this object to have two codepaths: the old string-based codepath,
and a new, platform-specific codepath which simply embeds the CTFontDesriptorRefs inside a Font
object.
We don't want to simply pull out the family name from each item in the Core Text fallback list
because that is a lossy translation. There is more information in these font descriptors which
cannot be represented by CSS. Therefore, we must keep the descriptors alive and add the new
codepath for them.
We also don't want to run the CSS font matching algorithm on each member of the Core Text
fallback list because it may yield different results from Core Text's font matching algorithm.
Our goal is to draw text as closely as possible to the system APIs. If we ran it, we may find
a font which is closer to the requested traits, but it would look out of place on the system.
Tests: fast/text/system-font-fallback-emoji.html
fast/text/system-font-fallback.html
- WebCore.xcodeproj/project.pbxproj:
- page/MemoryRelease.cpp:
(WebCore::releaseNoncriticalMemory):
- platform/graphics/FontCascadeFonts.cpp:
(WebCore::realizeNextFallback): The consumer of our new data type. Now uses WTF::visit().
(WebCore::FontCascadeFonts::realizeFallbackRangesAt): Now that the number of items to test
against the current character is larger than the number of strings in the font-family list,
we need to update the existing code to use the correct value.
- platform/graphics/FontDescription.cpp: Default implementation for non-Cocoa ports.
(WebCore::FontDescription::invalidateCaches):
(WebCore::FontCascadeDescription::effectiveFamilyCount):
(WebCore::FontCascadeDescription::effectiveFamilyAt):
- platform/graphics/FontDescription.h: Our new data type is a Variant of AtomicString and a
platform-specific class. Cocoa uses a class that holds a CTFontDescriptorRef and other ports
use an empty non-constructable class.
- platform/graphics/FontFamilySpecificationNull.h: Added. The empty non-constructable
class.
(WebCore::FontFamilySpecificationNull::fontRanges):
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::platformInit): Changing the system language will change the system font
fallback list, so we need to listen to this notification. This also matters for
FontCache::systemFallbackForCharacters(), so we should build off the same callback we are
already using for font installation.
(WebCore::invalidateFontCache):
- platform/graphics/cocoa/FontDescriptionCocoa.cpp: Added. The platform-specific creation of
our CTFontDescriptorRefs. We hold them cached in a SystemFontDatabase.
(WebCore::SystemFontDatabase::CoreTextCascadeListParameters::CoreTextCascadeListParameters):
(WebCore::SystemFontDatabase::CoreTextCascadeListParameters::isHashTableDeletedValue):
(WebCore::SystemFontDatabase::CoreTextCascadeListParameters::operator==):
(WebCore::SystemFontDatabase::CoreTextCascadeListParameters::hash):
(WebCore::SystemFontDatabase::singleton):
(WebCore::SystemFontDatabase::systemFontCascadeList):
(WebCore::SystemFontDatabase::clear):
(WebCore::SystemFontDatabase::SystemFontDatabase):
(WebCore::SystemFontDatabase::applyWeightAndItalics):
(WebCore::SystemFontDatabase::removeCascadeList):
(WebCore::SystemFontDatabase::computeCascadeList):
(WebCore::SystemFontDatabase::CoreTextCascadeListParametersHash::hash):
(WebCore::SystemFontDatabase::CoreTextCascadeListParametersHash::equal):
(WebCore::isSystemFontString):
(WebCore::systemFontParameters):
(WebCore::FontDescription::invalidateCaches):
(WebCore::FontCascadeDescription::effectiveFamilyCount): We don't store the result of this
because it would probably be a bad idea to increase the size of every single FontCascade just
in case it might ask for the system font. Most fonts never mention system-ui. Because it's so
rare, we can just recalculate the result of this as necessary. This shouldn't be slow because
the results are cached.
(WebCore::FontCascadeDescription::effectiveFamilyAt):
- platform/graphics/cocoa/FontFamilySpecificationCoreText.cpp: Added.
(WebCore::FontFamilySpecificationCoreText::fontRanges): Create a FontRanges from a
CTFontDescriptorRef.
- platform/graphics/cocoa/FontFamilySpecificationCoreText.h: Added.
(WebCore::FontFamilySpecificationCoreText::FontFamilySpecificationCoreText):
- platform/graphics/ios/FontCacheIOS.mm: Delete the old handling for system-ui.
(WebCore::platformFontWithFamilySpecialCase):
(WebCore::baseSystemFontDescriptor): Deleted.
(WebCore::systemFontModificationAttributes): Deleted.
(WebCore::systemFontDescriptor): Deleted.
- platform/graphics/mac/FontCacheMac.mm: Ditto.
(WebCore::platformFontWithFamilySpecialCase):
(WebCore::toNSFontWeight): Deleted.
LayoutTests:
Rebaseline tests which use non-English text in form controls
- fast/text/system-font-fallback-emoji-expected.txt: Added.
- fast/text/system-font-fallback-emoji.html: Added.
- fast/text/system-font-fallback-expected.html: Added.
- fast/text/system-font-fallback.html: Added.
- platform/mac-elcapitan/fast/forms/listbox-bidi-align-expected.png: Added.
- platform/mac-elcapitan/fast/forms/listbox-bidi-align-expected.txt:
- platform/mac-elcapitan/fast/forms/search-rtl-expected.png: Added.
- platform/mac-elcapitan/fast/forms/search-rtl-expected.txt:
- platform/mac-elcapitan/fast/forms/searchfield-heights-expected.png: Added.
- platform/mac-elcapitan/fast/forms/searchfield-heights-expected.txt:
- platform/mac-elcapitan/fast/forms/visual-hebrew-text-field-expected.txt:
- platform/mac-elcapitan/fast/text/drawBidiText-expected.png: Added.
- platform/mac-elcapitan/fast/text/drawBidiText-expected.txt:
- platform/mac-elcapitan/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png: Added.
- platform/mac-elcapitan/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
- platform/mac/TestExpectations:
- platform/mac/fast/css/rtl-ordering-expected.png:
- platform/mac/fast/css/rtl-ordering-expected.txt:
- platform/mac/fast/forms/listbox-bidi-align-expected.png:
- platform/mac/fast/forms/listbox-bidi-align-expected.txt:
- platform/mac/fast/forms/listbox-hit-test-zoomed-expected.png:
- platform/mac/fast/forms/listbox-hit-test-zoomed-expected.txt:
- platform/mac/fast/forms/search-rtl-expected.png:
- platform/mac/fast/forms/search-rtl-expected.txt:
- platform/mac/fast/forms/searchfield-heights-expected.txt:
- platform/mac/fast/forms/select-visual-hebrew-expected.png:
- platform/mac/fast/forms/select-visual-hebrew-expected.txt:
- platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
- platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
- platform/mac/fast/text/drawBidiText-expected.png:
- platform/mac/fast/text/drawBidiText-expected.txt:
- platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
- platform/mac/fast/text/international/pop-up-button-text-alignment-and-direction-expected.txt:
- platform/mac/fast/text/updateNewFont-expected.png:
- platform/mac/fast/text/updateNewFont-expected.txt:
- 6:28 PM Changeset in webkit [218160] by
-
- 7 edits1 add in trunk/Source
Remove WebCore::unloadModule and related data types
https://bugs.webkit.org/show_bug.cgi?id=173231
Patch by Daewoong Jang <daewoong.jang@navercorp.com> on 2017-06-12
Reviewed by Darin Adler.
Source/WebCore:
- platform/FileSystem.h:
(WebCore::PlatformModuleVersion::PlatformModuleVersion): Deleted.
- platform/glib/FileSystemGlib.cpp:
(WebCore::unloadModule): Deleted.
- platform/win/FileSystemWin.cpp:
(WebCore::unloadModule): Deleted.
Source/WebKit/win:
- Plugins/PlatformModule.h: Added.
(WebCore::PlatformModuleVersion::PlatformModuleVersion):
- Plugins/PluginPackage.cpp:
(WebCore::PluginPackage::freeLibraryTimerFired):
- Plugins/PluginPackage.h:
- 5:34 PM Changeset in webkit [218159] by
-
- 6 edits1 add in trunk/Source/WebInspectorUI
Web Inspector: Add grid to images to clarify transparency and image size
https://bugs.webkit.org/show_bug.cgi?id=173184
Reviewed by Matt Baker.
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Base/Setting.js:
Add setting for controlling the image grid.
- UserInterface/Images/NavigationItemCheckers.svg: Added.
- UserInterface/Views/ImageResourceContentView.css:
(.content-view.resource.image):
(.content-view.resource.image img):
Replace the border spacing around the image with padding on the container. This is required
because a border will extend the area that is effected bybackground-image, meaning that
the checkerboard would appear in that area as well, giving misleading information as to the
size of the image.
- UserInterface/Views/ImageResourceContentView.js:
(WebInspector.ImageResourceContentView):
(WebInspector.ImageResourceContentView.prototype.get navigationItems): Added.
(WebInspector.ImageResourceContentView.prototype.contentAvailable):
(WebInspector.ImageResourceContentView.prototype.shown): Added.
(WebInspector.ImageResourceContentView.prototype._toggleImageGrid): Added.
(WebInspector.ImageResourceContentView.prototype._showGridButtonClicked): Added.
(WebInspector.ImageResourceContentView.prototype.get imageElement): Deleted.
Apply the CSS class for showing the grid when the added navigation item is activated.
- UserInterface/Views/Main.css:
(img.show-grid):
Generates a checkerboard pattern viabackground-imageusing the following process:
- four
linear-gradientsare drawn, one in each corner - each draws one half of a 20x20 square, specified by
background-size - they are then repositioned using
background-positionso that the two halfs align
+------+ \--2
|1 /\ 2| |\ |
| / \ | => | \|
|/ \| => 4--\
|\ /| => 1--/
| \ / | => | /|
|4 \/ 3| |/ |
+------+ /--3
- 5:10 PM Changeset in webkit [218158] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed build fix; fix a misspelling in CoreMediaSoftLink.{h,cpp}.
Patch by Jer Noble <jer.noble@apple.com> on 2017-06-12
- platform/cf/CoreMediaSoftLink.cpp:
- platform/cf/CoreMediaSoftLink.h:
- 5:05 PM Changeset in webkit [218157] by
-
- 4 edits3 adds in trunk
@font-face rules with invalid primary fonts never download their secondary fonts
https://bugs.webkit.org/show_bug.cgi?id=173138
<rdar://problem/32554450>
Reviewed by Simon Fraser.
Source/WebCore:
We have logic in CSSFontAccessor::font() which disallows downloading a CSSFontFace if that CSSFontFace
is already in the Succeeded state. However, it was possible for a succeeded CSSFontFace to still fail
to create a font. In this situation, we wouldn't be able to use the downloaded font, and we wouldn't
try to download the next item in the src: list because the CSSFontFace is succeeded.
This patch strengthens the meaning of the Succeeded state. Previously, it just meant that the bytes
in the file were downloaded successfully. This patch extends this to also mean that the bytes in the
file can be successfully interpreted as a font. This way, the CSSFontFace in the example above won't be
set to the Succeeded state, so we will continue follow the src: list and download the secondary fonts.
This has an added benefit that the CSS Font Loading API's promises will be called more appropriately.
The transition to the Succeeded state will trigger a resolve of the promise. Now, these promises will
only be resolved if the fonts are actually parsed and understood by our text system.
Test: fast/text/font-fallback-invalid-load.html
- css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::fontLoaded): Move to the failed state if we can't understand the font
data. This is the crux of this patch.
(WebCore::CSSFontFaceSource::font): This function should only be called if we are in the Succeeded
state, which means now we know we should always be able to understand the bytes of the file. Therefore,
we can change some if statements into ASSERT()s.
- loader/cache/CachedSVGFont.cpp:
(WebCore::CachedSVGFont::createFont): Ditto.
(WebCore::CachedSVGFont::platformDataFromCustomData): Similarly to CSSFontFaceSource::fontLoaded(), this
adds another check to our criteria for transitioning into the Succeeded state, which will guarantee that
later we will always be able to create the font object.
LayoutTests:
- fast/text/font-fallback-invalid-load-expected.html: Added.
- fast/text/font-fallback-invalid-load.html: Added.
- fast/text/resources/bogus.svg: Added.
- 5:04 PM Changeset in webkit [218156] by
-
- 1 copy in tags/Safari-604.1.25.2
Tag Safari-604.1.25.2.
- 4:55 PM Changeset in webkit [218155] by
-
- 5 edits25 adds in trunk/LayoutTests
Implement W3C Secure Contexts Draft Specification
https://bugs.webkit.org/show_bug.cgi?id=158121
<rdar://problem/26012994>
Reviewed by Ryosuke Niwa.
Part 3
LayoutTests/imported/w3c:
Import the Secure Contexts Web Platform Tests.
- resources/import-expectations.json:
- resources/resource-files.json:
- web-platform-tests/secure-contexts/basic-dedicated-worker.html: Added.
- web-platform-tests/secure-contexts/basic-dedicated-worker.https.html: Added.
- web-platform-tests/secure-contexts/basic-popup-and-iframe-tests-expected.txt: Added.
- web-platform-tests/secure-contexts/basic-popup-and-iframe-tests.html: Added.
- web-platform-tests/secure-contexts/basic-popup-and-iframe-tests.https-expected.txt: Added.
- web-platform-tests/secure-contexts/basic-popup-and-iframe-tests.https.html: Added.
- web-platform-tests/secure-contexts/basic-popup-and-iframe-tests.https.js: Added.
(LoadType):
(LoadTarget):
(LoadTarget.prototype.open):
(LoadTarget.prototype.close):
(LoadTarget.prototype.load_and_get_result_for):
(run_next_test.):
(run_next_test):
(begin):
- web-platform-tests/secure-contexts/basic-shared-worker.html: Added.
- web-platform-tests/secure-contexts/basic-shared-worker.https.html: Added.
- web-platform-tests/secure-contexts/postMessage-helper.html: Added.
- web-platform-tests/secure-contexts/postMessage-helper.https.html: Added.
- web-platform-tests/secure-contexts/server-locations.sub.js: Added.
- web-platform-tests/secure-contexts/shared-worker-insecure-first.https.html: Added.
- web-platform-tests/secure-contexts/shared-worker-secure-first.https.html: Added.
- web-platform-tests/secure-contexts/support/dedicated-worker-script.js: Added.
- web-platform-tests/secure-contexts/support/https-subframe-dedicated.html: Added.
- web-platform-tests/secure-contexts/support/https-subframe-shared.html: Added.
- web-platform-tests/secure-contexts/support/parent-dedicated-worker-script.js: Added.
(w.onmessage):
- web-platform-tests/secure-contexts/support/parent-shared-worker-script.js: Added.
(w.onmessage):
- web-platform-tests/secure-contexts/support/shared-worker-insecure-popup.html: Added.
- web-platform-tests/secure-contexts/support/shared-worker-script.js: Added.
- web-platform-tests/secure-contexts/support/w3c-import.log: Added.
- web-platform-tests/secure-contexts/w3c-import.log: Added.
LayoutTests:
Skip tests that exercise Shared Workers as WebKit does not support them. With the exception
of web-platform-tests/secure-contexts/basic-popup-and-iframe-tests.html all other tests are
skipped because they time out. The following sub-tests in web-platform-tests/secure-contexts/basic-popup-and-iframe-tests.html
are expected to fail:
- "Test Window.isSecureContext for HTTP creator"
Reason: Sub-test must be run from non-localhost server
- "Test Window.isSecureContext in an iframe loading an http"
Reason: Sub-test must be run from non-localhost server
- "Test Window.isSecureContext in a sandboxed iframe loading an http"
Reason: We do not implement the allow-secure-context flag
- "Test Window.isSecureContext in a popup loading about:blank"
Reason: Times out; further investigation needed.
We will investigate the test failures and fix them in subsequent commits.
- 4:52 PM Changeset in webkit [218154] by
-
- 2 edits in trunk/Tools
Add unit tests for SecurityOrigin::IsPotentiallyTrustworthy()
https://bugs.webkit.org/show_bug.cgi?id=173286
<rdar://problem/32726102>
Reviewed by Brent Fulgham.
- TestWebKitAPI/Tests/WebCore/SecurityOrigin.cpp:
(TestWebKitAPI::TEST_F):
- 4:39 PM Changeset in webkit [218153] by
-
- 3 edits2 adds in trunk
Add Arabic Kasra to list of blacklisted characters when puny-decoding URL
https://bugs.webkit.org/show_bug.cgi?id=173283
<rdar://problem/32725659>
Reviewed by Brent Fulgham.
Source/WebCore:
Add Arabic Kasra to list of blacklisted characters when puny-decoding URL as
it is almost invisible in the URL bar.
Test: fast/url/user-visible/arabic_kasra.html
- platform/mac/WebCoreNSURLExtras.mm:
(WebCore::isLookalikeCharacter):
LayoutTests:
Add layout test coverage.
- fast/url/user-visible/arabic_kasra-expected.txt: Added.
- fast/url/user-visible/arabic_kasra.html: Added.
- 4:29 PM Changeset in webkit [218152] by
-
- 7 edits1 add3 deletes in trunk
<rdar://problem/32683422>
Tools:
Teach copy-webkitlibraries-to-product-directory script about updated libraries.
Reviewed by Conrad Schultz.
- Scripts/copy-webkitlibraries-to-product-directory:
WebKitLibraries:
Update existing WebKitSystemInterface libraries.
Add macOS 10.13 libraries.
Remove macOS 10.10 libraries.
Remove iOS 10.9 libraries.
Reviewed by Conrad Schultz.
- libWebKitSystemInterfaceElCapitan.a:
- libWebKitSystemInterfaceIOSDevice10.a:
- libWebKitSystemInterfaceIOSDevice9.a: Removed.
- libWebKitSystemInterfaceIOSSimulator10.a:
- libWebKitSystemInterfaceIOSSimulator9.a: Removed.
- libWebKitSystemInterfaceOSX10.12.a:
- libWebKitSystemInterfaceOSX10.13.a: Added.
- libWebKitSystemInterfaceYosemite.a: Removed.
- 4:01 PM Changeset in webkit [218151] by
-
- 5 edits1 add in trunk/Source
Screen sleeps while doing WebRTC video
https://bugs.webkit.org/show_bug.cgi?id=173278
Reviewed by Eric Carlson.
Source/WebCore:
HTMLMediaElement triggers changing the sleep disabler token when the media engine
says that its rate has changed; the MediaPlayerPrivateMediaStreamAVFObjC needs to
notify its client (the HTMLMediaElement) that the rate has changed when the stream
is played or paused.
Drive-by fix: Don't set a sleep disabler token (i.e., allow the system and display
to sleep) if the stream is strictly local-capture.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::shouldDisableSleep):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::play):
(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::pause):
Source/WTF:
Drive-by fix: add some generic methods for iterating over collections.
- WTF.xcodeproj/project.pbxproj:
- wtf/Algorithms.h: Added.
(WTF::forEach):
(WTF::anyOf):
(WTF::allOf):
- 3:57 PM Changeset in webkit [218150] by
-
- 6 edits in trunk/Source/WebCore
Seeking an MSE video will begin playing audio long before rendering video
https://bugs.webkit.org/show_bug.cgi?id=173269
Reviewed by Eric Carlson.
Add a notification listener which will be messaged when a to-be-displayed sample
is decoded to signal that the 'seeked' event should fire. Consolidate all the various
flush methods to funnel into a single flushVideo().
- platform/cf/CoreMediaSoftLink.cpp:
- platform/cf/CoreMediaSoftLink.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
- platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(-[WebBufferConsumedContext initWithParent:buffer:]):
(-[WebBufferConsumedContext dealloc]):
(-[WebBufferConsumedContext parent]):
(-[WebBufferConsumedContext buffer]):
(WebCore::bufferWasConsumedCallback):
(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::~SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::flush):
(WebCore::SourceBufferPrivateAVFObjC::flushVideo):
(WebCore::SourceBufferPrivateAVFObjC::enqueueSample):
(WebCore::SourceBufferPrivateAVFObjC::bufferWasConsumed):
(WebCore::SourceBufferPrivateAVFObjC::willSeek):
- 3:48 PM Changeset in webkit [218149] by
-
- 5 edits in trunk/Source/WebKit2
[iOS WK2] Peeking on an image could result in a preview at the wrong size
https://bugs.webkit.org/show_bug.cgi?id=173274
rdar://problem/30404627
Reviewed by Tim Horton.
There were a couple of issues with the way the page scale is communicated between the web process
and the UI process.
Generally, the page scale is computed by the web process, and sent to the UI process via
layer tree commits. UI-side scale is them communicated back to the web process via visibleContentRect
updates. When receiving a new scale, WebPage has a "scale was set by the UI process" flag to handle
the case where user interaction overrides the viewport-computed page scale. However, this flag would
get set erroneously in a couple of situations.
First, during page loading, layer flushing is suspended temporarily, so web process scale changes never
make it to the UI process. In that scenario, the UI process could send an old scale back to the web process,
setting the "scale was set by the UI process" when it really wasn't.
Secondly, web -> UI layer commit messages, and UI -> web updateVisibleContentRect messages can be in flight at the
same time, again causing a stale scale to reach the web process.
Fix this by only setting the "scale was set by the UI process" when we know the UI scale should be in sync, by comparing
commit IDs of sent and received scales.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::scaleFromUIProcess):
(WebKit::WebPage::updateVisibleContentRects):
- WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
(WebKit::RemoteLayerTreeDrawingArea::lastCommittedTransactionID):
- 3:41 PM Changeset in webkit [218148] by
-
- 2 edits in trunk/Source/WebCore
[MediaStream iOS] Set audio session mode and options when capturing
https://bugs.webkit.org/show_bug.cgi?id=173276
<rdar://problem/32059254>
Reviewed by Jer Noble.
- platform/audio/ios/AudioSessionIOS.mm:
(WebCore::AudioSession::setCategory): Set mode and options so the default output is to the speaker,
and so audio will be routed to bluetooth when appropriate.
- 3:39 PM Changeset in webkit [218147] by
-
- 2 edits in trunk/Source/WebCore
Remove watchdog timer from WebVideoFullscreenInterfaceAVKit
https://bugs.webkit.org/show_bug.cgi?id=173272
rdar://problem/32260378
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-06-12
Reviewed by Jer Noble.
No new tests because no effect on DOM.
WebVideoFullscreenInterfaceAVKit's watchdog attempts to clean-up fullscreen if the page becomes unresponsive.
However, it is just calling exitfullscreen(), which initiates the animation, but leaves the fullscreen window
in place and doesn't initiate cleanup. This leaves the browser in an unusable state since all events will still
be captured by the fullscren window.
This change uses the same method of hiding fullscreen window as switching tabs does. This will
hide the fullscreen winodw and controller, leaving the browser available for interaction, and the page
can take its time to properly cleanup the fullscreen window while hidden.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::watchdogTimerFired):
- 3:37 PM Changeset in webkit [218146] by
-
- 10 edits in trunk/Source
Modernize UserScript.h
https://bugs.webkit.org/show_bug.cgi?id=173273
Reviewed by Tim Horton.
Source/WebCore:
No change in behavior. Moved encoders to UserScript.h. Use more Rvalues.
- page/UserScript.h:
(WebCore::UserScript::UserScript):
(WebCore::UserScript::encode):
(WebCore::UserScript::decode):
Source/WebKit2:
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<UserScript>::encode): Deleted.
(IPC::ArgumentCoder<UserScript>::decode): Deleted.
- Shared/WebCoreArgumentCoders.h:
- UIProcess/API/C/WKPageGroup.cpp:
(WKPageGroupAddUserScript):
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::addUserScript):
- WebProcess/InjectedBundle/InjectedBundle.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::addUserScript):
- WebProcess/WebPage/WebPage.h:
- 3:37 PM Changeset in webkit [218145] by
-
- 11 edits in trunk
AX: Video/Audio Player Controls missing group container.
https://bugs.webkit.org/show_bug.cgi?id=171790
<rdar://problem/32008994>
Patch by Aaron Chu <aaron_chu@apple.com> on 2017-06-12
Reviewed by Antoine Quint.
Source/WebCore:
Added aria-label to group controls in media controls.
- English.lproj/modern-media-controls-localized-strings.js:
- Modules/modern-media-controls/controls/controls-bar.js:
- Modules/modern-media-controls/controls/inline-media-controls.js:
(InlineMediaControls):
(InlineMediaControls.prototype.set shouldUseAudioLayout):
(InlineMediaControls.prototype._updateBottomControlsBarLabel):
LayoutTests:
Modified existing test cases to accommodate testing for controls bar aria-label.
- media/modern-media-controls/audio/audio-controls-buttons-expected.txt:
- media/modern-media-controls/audio/audio-controls-buttons.html:
- media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-constructor-expected.txt:
- media/modern-media-controls/ios-inline-media-controls/ios-inline-media-controls-constructor.html:
- media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-constructor-expected.txt:
- media/modern-media-controls/macos-inline-media-controls/macos-inline-media-controls-constructor.html:
- 3:28 PM Changeset in webkit [218144] by
-
- 7 edits1 add in trunk
[iOS] Cmd-C doesn't copy text from WKWebView
https://bugs.webkit.org/show_bug.cgi?id=173277
<rdar://problem/32396742>
Reviewed by Dan Bernstein.
- UIProcess/API/Cocoa/WKWebView.mm:
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _lookupForWebView:]):
(-[WKContentView _shareForWebView:]):
(-[WKContentView _addShortcutForWebView:]):
(-[WKContentView _promptForReplaceForWebView:]):
(-[WKContentView _transliterateChineseForWebView:]):
(-[WKContentView _reanalyzeForWebView:]):
(-[WKContentView replaceForWebView:]):
(-[WKContentView canPerformAction:withSender:]):
(-[WKContentView copyForWebView:]):
(-[WKContentView cutForWebView:]):
(-[WKContentView pasteForWebView:]):
(-[WKContentView selectForWebView:]):
(-[WKContentView selectAllForWebView:]):
(-[WKContentView toggleBoldfaceForWebView:]):
(-[WKContentView toggleItalicsForWebView:]):
(-[WKContentView toggleUnderlineForWebView:]):
(-[WKContentView _showTextStyleOptionsForWebView:]):
(-[WKContentView _defineForWebView:]):
(-[WKContentView _arrowKeyForWebView:]):
(-[WKContentView _lookup:]): Deleted.
(-[WKContentView _share:]): Deleted.
(-[WKContentView _addShortcut:]): Deleted.
(-[WKContentView _promptForReplace:]): Deleted.
(-[WKContentView _transliterateChinese:]): Deleted.
(-[WKContentView _reanalyze:]): Deleted.
(-[WKContentView replace:]): Deleted.
(-[WKContentView copy:]): Deleted.
(-[WKContentView cut:]): Deleted.
(-[WKContentView paste:]): Deleted.
(-[WKContentView select:]): Deleted.
(-[WKContentView selectAll:]): Deleted.
(-[WKContentView toggleBoldface:]): Deleted.
(-[WKContentView toggleItalics:]): Deleted.
(-[WKContentView toggleUnderline:]): Deleted.
(-[WKContentView _showTextStyleOptions:]): Deleted.
(-[WKContentView _define:]): Deleted.
(-[WKContentView _arrowKey:]): Deleted.
Similar to what r211897 did for canPerformAction, and other patches
have done for other selectors, forward methods for standard editing
commands from WKContentView up to WKWebView, and back down to WKContentView.
This is necessary because these are not treated as normal
responder-chain-respecting methods, so they do not bubble up the view tree.
In 211897, WKContentView (who is usually first responder and thus receives
the actions) stopped claiming to be able to perform these actions, depending
on this non-existent bubbling behavior to keep them working.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- Tests/WebKit2Cocoa/WKContentViewEditingActions.mm:
Add a test ensuring that -copy on WKContentView will cause text to be copied.
- 3:18 PM Changeset in webkit [218143] by
-
- 19 edits in tags/Safari-604.1.25/Source
Revert r218112 and r218115..r218120.
This effectively resets the tag to r218032.
- 3:09 PM Changeset in webkit [218142] by
-
- 3 edits1 add in trunk/Source/WebCore
[Curl] Use SynchronousLoaderClient for platformLoadResourceSynchronously on WinCairo
https://bugs.webkit.org/show_bug.cgi?id=173195
Patch by Basuke Suzuki <Basuke Suzuki> on 2017-06-12
Reviewed by Alex Christensen.
- PlatformWinCairo.cmake:
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
- platform/network/curl/SynchronousLoaderClientCurl.cpp: Added.
(WebCore::SynchronousLoaderClient::didReceiveAuthenticationChallenge):
(WebCore::SynchronousLoaderClient::platformBadResponseError):
- 3:07 PM Changeset in webkit [218141] by
-
- 2 edits in trunk/JSTests
Update test262 test expectation since r218082 makes new tests pass.
- test262.yaml:
- 2:56 PM Changeset in webkit [218140] by
-
- 13 edits in trunk/Source/WebCore
[MediaStream iOS] If a capturing tab is muted while it is in the background, it can not be unmuted
https://bugs.webkit.org/show_bug.cgi?id=173268
<rdar://problem/32259809>
Reviewed by Jer Noble.
No new tests, tested manually.
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::startProducingData): Mute the private stream if page capture is muted.
(WebCore::MediaStream::mediaState): Set new interrupted state.
- dom/Document.cpp:
(WebCore::Document::notifyMediaCaptureOfVisibilityChanged): Don't track "muted for visibility"
state, let the source center deal with it.
- dom/Document.h:
- page/MediaProducer.h: Add bits for interrupted audio and video capture.
- platform/mediastream/RealtimeMediaSource.cpp:
(WebCore::RealtimeMediaSource::RealtimeMediaSource): Drive-by fix: delete m_suppressNotifications,
it isn't used.
(WebCore::RealtimeMediaSource::setInterrupted): New. Mute capture when an interruption begins,
and unmute when it ends in an unmuted page.
(WebCore::RealtimeMediaSource::setMuted): Do not unmute if interrupted.
(WebCore::RealtimeMediaSource::settingsDidChange): Don't check m_suppressNotifications, it is
never set.
- platform/mediastream/RealtimeMediaSource.h:
- platform/mediastream/RealtimeMediaSourceCenter.cpp:
(WebCore::RealtimeMediaSourceCenter::setVideoCapturePageState): Renamed from
setVideoCaptureMutedForPageVisibility.
(WebCore::RealtimeMediaSourceCenter::setVideoCaptureMutedForPageVisibility): Deleted.
- platform/mediastream/RealtimeMediaSourceCenter.h:
- platform/mediastream/mac/AVMediaCaptureSource.h:
- platform/mediastream/mac/AVMediaCaptureSource.mm:
(WebCore::AVMediaCaptureSource::stopProducingData): Clear m_interruption because the session
has been deleted, so we will never get an "end interruption" notification.
(WebCore::AVMediaCaptureSource::captureSessionIsRunningDidChange): Don't return early if
the muted state needs to be updated.
(WebCore::AVMediaCaptureSource::captureSessionEndInterruption): Return early if the session
has been cleared.
(WebCore::AVMediaCaptureSource::interrupted): New.
- platform/mediastream/mac/AVVideoCaptureSource.mm:
(WebCore::AVVideoCaptureSourceFactory::setVideoCapturePageState): Renamed from
setVideoCaptureMutedForPageVisibility.
(WebCore::AVVideoCaptureSourceFactory::setVideoCaptureMutedForPageVisibility): Deleted.
- platform/mock/MockRealtimeVideoSource.cpp:
(WebCore::MockRealtimeVideoSourceFactory::setVideoCapturePageState): Ditto.
(WebCore::MockRealtimeVideoSourceFactory::setVideoCaptureMutedForPageVisibility): Deleted.
- 2:35 PM Changeset in webkit [218139] by
-
- 6 edits1 copy1 delete in trunk/LayoutTests
Garden tests for on-device testing
Unreviewed test gardening.
The tests gardened here have not been investigated. https://bugs.webkit.org/show_bug.cgi?id=173275
tracks the investigation of the tests marked as failing, crashing or skipped because they timeout
when running layout tests on-device in this revision.
- platform/ios-device/TestExpectations: Initial gardening of expectations for on-device testing.
- platform/ios-simulator-wk2/TestExpectations: Moved simulator specific expectations from platfrom/ios-wk2.
- platform/ios-simulator/TestExpectations: Moved simulator specific expectations from platfrom/ios.
- platform/ios-simulator/compositing: Removed.
- platform/ios-wk2/TestExpectations: Moved simulator specific expectation to platform/ios-simulator-wk2.
- platform/ios/TestExpectations: Moved simulator specific expectation to platform/ios.
- platform/ios/compositing/iframes/compositing-for-scrollable-iframe-expected.txt: Copied from
LayoutTests/platform/ios-simulator/compositing/iframes/compositing-for-scrollable-iframe-expected.txt.
- 2:31 PM Changeset in webkit [218138] by
-
- 2 edits in trunk/Source/WebKit2
Null dereference under WebProcessPool::pageRemovedFromProcess()
https://bugs.webkit.org/show_bug.cgi?id=173271
<rdar://problem/32038814>
Reviewed by Ryosuke Niwa.
Null-check networkProcess() before dereferencing it in WebProcessPool::pageRemovedFromProcess().
This is the only place in this class where we failed to null check before dereferencing
networkProcess(). To my knowledge, there is no guarantee there is a network process.
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::pageRemovedFromProcess):
- 2:01 PM Changeset in webkit [218137] by
-
- 9 edits1 add in trunk
We should not claim that SpecEmpty is filtered out of cell checks on 64 bit platforms
https://bugs.webkit.org/show_bug.cgi?id=172957
<rdar://problem/32602704>
Reviewed by Filip Pizlo.
JSTests:
- stress/spec-empty-flows-through-cell-checks.js: Added.
(A):
(B):
(i.catch):
Source/JavaScriptCore:
Consider this program:
`
block#1:
n: GetClosureVar(..., |this|) this will load empty JSValue()
SetLocal(Cell:@n, locFoo) Cell check succeeds because JSValue() looks like a cell
Branch(#2, #3)
Block#3:
x: GetLocal(locFoo)
y: CheckNotEmpty(@x)
`
If we claim that a cell check filters out the empty value, we will
incorrectly eliminate the CheckNotEmpty node @y. This patch fixes AI,
FTLLowerDFGToB3, and DFGSpeculativeJIT to no longer make this claim.
On 64 bit platforms:
- Cell use kind *now allows* the empty value to pass through.
- CellOrOther use kind *now allows* for the empty value to pass through
- NotCell use kind *no longer allows* the empty value to pass through.
- assembler/CPU.h:
(JSC::isARMv7IDIVSupported):
(JSC::isARM64):
(JSC::isX86):
(JSC::isX86_64):
(JSC::is64Bit):
(JSC::is32Bit):
(JSC::isMIPS):
Make these functions constexpr so we can use them in static variable assignment.
- bytecode/SpeculatedType.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileValueToInt32):
(JSC::DFG::SpeculativeJIT::compileDoubleRep):
(JSC::DFG::SpeculativeJIT::compileLogicalNotStringOrOther):
(JSC::DFG::SpeculativeJIT::emitStringOrOtherBranch):
(JSC::DFG::SpeculativeJIT::speculateCell):
(JSC::DFG::SpeculativeJIT::speculateCellOrOther):
(JSC::DFG::SpeculativeJIT::speculateObjectOrOther):
(JSC::DFG::SpeculativeJIT::speculateString):
(JSC::DFG::SpeculativeJIT::speculateStringOrOther):
(JSC::DFG::SpeculativeJIT::speculateSymbol):
(JSC::DFG::SpeculativeJIT::speculateNotCell):
- dfg/DFGSpeculativeJIT32_64.cpp:
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::compileObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compilePeepHoleObjectToObjectOrOtherEquality):
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):
- dfg/DFGUseKind.h:
(JSC::DFG::typeFilterFor):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileDoubleRep):
(JSC::FTL::DFG::LowerDFGToB3::numberOrNotCellToInt32):
(JSC::FTL::DFG::LowerDFGToB3::compareEqObjectOrOtherToObject):
(JSC::FTL::DFG::LowerDFGToB3::boolify):
(JSC::FTL::DFG::LowerDFGToB3::equalNullOrUndefined):
(JSC::FTL::DFG::LowerDFGToB3::lowCell):
(JSC::FTL::DFG::LowerDFGToB3::lowNotCell):
(JSC::FTL::DFG::LowerDFGToB3::isCellOrMisc):
(JSC::FTL::DFG::LowerDFGToB3::isNotCellOrMisc):
(JSC::FTL::DFG::LowerDFGToB3::isNotCell):
(JSC::FTL::DFG::LowerDFGToB3::isCell):
(JSC::FTL::DFG::LowerDFGToB3::speculateCellOrOther):
(JSC::FTL::DFG::LowerDFGToB3::speculateObjectOrOther):
(JSC::FTL::DFG::LowerDFGToB3::speculateString):
(JSC::FTL::DFG::LowerDFGToB3::speculateStringOrOther):
(JSC::FTL::DFG::LowerDFGToB3::speculateSymbol):
- 1:52 PM Changeset in webkit [218136] by
-
- 5 edits in branches/safari-604.1.25-branch/Source
Cherry-pick r218068. rdar://problem/32686871
- 1:52 PM Changeset in webkit [218135] by
-
- 2 edits in branches/safari-604.1.25-branch/Source/WebKit2
Cherry-pick r218022. rdar://problem/32598919
- 1:52 PM Changeset in webkit [218134] by
-
- 7 edits in branches/safari-604.1.25-branch/Source/WebKit2
Cherry-pick r218011. rdar://problem/32679311
- 1:52 PM Changeset in webkit [218133] by
-
- 2 edits in branches/safari-604.1.25-branch/Source/WebKit2
Cherry-pick r218006. rdar://problem/32598919
- 1:52 PM Changeset in webkit [218132] by
-
- 4 edits in branches/safari-604.1.25-branch/Source/WebKit2
Cherry-pick r218002. rdar://problem/32679311
- 1:52 PM Changeset in webkit [218131] by
-
- 4 edits in branches/safari-604.1.25-branch/Source/WebKit2
Cherry-pick r217991. rdar://problem/32594952
- 1:52 PM Changeset in webkit [218130] by
-
- 7 edits in branches/safari-604.1.25-branch/Source
Versioning.
- 1:27 PM Changeset in webkit [218129] by
-
- 18 edits in trunk
[WebCrypto] Remove experimental feature flag of SubtleCrypto
https://bugs.webkit.org/show_bug.cgi?id=173197
<rdar://problem/32688148>
Reviewed by Brent Fulgham.
Source/WebCore:
The SubtleCrypto implementation is no longer experimental and is ready for production use. We are therefore removing the runtime flag.
No tests.
- page/Crypto.idl:
- page/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::setSubtleCryptoEnabled): Deleted.
(WebCore::RuntimeEnabledFeatures::subtleCryptoEnabled): Deleted.
Source/WebKit/mac:
- WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences subtleCryptoEnabled]): Deleted.
(-[WebPreferences setSubtleCryptoEnabled:]): Deleted.
- WebView/WebPreferencesPrivate.h:
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
Source/WebKit2:
- Shared/WebPreferencesDefinitions.h:
- UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetSubtleCryptoEnabled): Deleted.
(WKPreferencesGetSubtleCryptoEnabled): Deleted.
- UIProcess/API/C/WKPreferencesRefPrivate.h:
- WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Tools:
- DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
- WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::beginTesting):
- WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setSubtleCryptoEnabled): Deleted.
- WebKitTestRunner/InjectedBundle/TestRunner.h:
- 1:05 PM Changeset in webkit [218128] by
-
- 10 edits in trunk
[iOS DnD] Allow the injected bundle to add client data when writing an image to the pasteboard
https://bugs.webkit.org/show_bug.cgi?id=173238
<rdar://problem/31943370>
Reviewed by Ryosuke Niwa and Tim Horton.
Source/WebCore:
Add clientTypes and clientData to PasteboardImage, and call out to the injected bundle using
getClientPasteboardDataForRange when writing a PasteboardImage. When generating item providers for dragging in
the UI process in PlatformPasteboard, add any available client data as representations to the initialization
list used to set the WebItemProviderPasteboard.
Test: DataInteraction.InjectedBundleImageElementData
- editing/ios/EditorIOS.mm:
(WebCore::Editor::writeImageToPasteboard):
- platform/Pasteboard.h:
- platform/ios/PlatformPasteboardIOS.mm:
(WebCore::PlatformPasteboard::writeObjectRepresentations):
Source/WebKit2:
Send PasteboardImage.clientTypes and PasteboardImage.clientData over IPC.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::encodeClientTypesAndData):
(IPC::decodeClientTypesAndData):
Factor out common logic used to encode and decode client types and data into static helpers.
(IPC::ArgumentCoder<PasteboardWebContent>::encode):
(IPC::ArgumentCoder<PasteboardWebContent>::decode):
(IPC::ArgumentCoder<PasteboardImage>::encode):
(IPC::ArgumentCoder<PasteboardImage>::decode):
Tools:
Add a new unit test to verify that data inserted by the injected bundle when beginning a drag on an image
element is plumbed across to the UI delegate. Also refactors injected bundle unit tests to use the new version
of adjustedDataInteractionItemProvidersForItemProvider: that takes representing objects and additional data.
- TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(TestWebKitAPI::TEST):
- TestWebKitAPI/ios/DataInteractionSimulator.h:
- TestWebKitAPI/ios/DataInteractionSimulator.mm:
(-[DataInteractionSimulator _webView:adjustedDataInteractionItemProvidersForItemProvider:representingObjects:additionalData:]):
(-[DataInteractionSimulator _webView:adjustedDataInteractionItemProviders:]): Deleted.
- 1:03 PM Renames edited by
- (diff)
- 1:02 PM Renames edited by
- (diff)
- 12:55 PM Renames edited by
- (diff)
- 12:54 PM Renames edited by
- (diff)
- 12:52 PM Renames edited by
- (diff)
- 12:52 PM Changeset in webkit [218127] by
-
- 3 edits3 adds in trunk/LayoutTests
Add tests for the SkipForwardButton class
https://bugs.webkit.org/show_bug.cgi?id=173214
Reviewed by Jon Lee.
- media/modern-media-controls/skip-forward-button/skip-forward-button-expected.txt: Added.
- media/modern-media-controls/skip-forward-button/skip-forward-button.html: Added.
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 12:51 PM Renames edited by
- (diff)
- 12:50 PM Changeset in webkit [218126] by
-
- 50 edits4 deletes in trunk
[WebIDL] Re-implement GetOwnPropertySlot[ByIndex] generation to more closely follow WebIDL
https://bugs.webkit.org/show_bug.cgi?id=173229
Patch by Sam Weinig <sam@webkit.org> on 2017-06-12
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
- web-platform-tests/html/semantics/forms/the-form-element/form-nameditem-expected.txt:
Update results for more passing tests.
Source/WebCore:
- WebCore.xcodeproj/project.pbxproj:
- CMakeLists.txt:
- bindings/js/JSBindingsAllInOne.cpp:
Remove JSHTMLFrameSetElementCustom.cpp which is no longer needed.
- bindings/js/JSDOMAbstractOperations.h:
(WebCore::isVisibleNamedProperty):
Add OverrideBuiltins enum as requested by a previous review (and I forgot address) and adopt it
in isVisibleNamedProperty, switch to VMInquiry as we use elsewhere and add a missing FIXME.
(WebCore::accessVisibleNamedProperty):
Add variation of isVisibleNamedProperty that takes a functor and returns either the value the
functor returns, or std::nullopt. This allows getOwnPropertySlot to avoid doing two lookups for
property, once in the named property visibility algorithm and again when it needs the value.
- bindings/js/JSDOMWindowBase.cpp:
- bindings/js/JSDOMWindowBase.h:
- bindings/js/JSDOMWindowShell.cpp:
- bindings/js/JSDOMWindowShell.h:
Standardize toJS functions to match generated code (have one that takes a reference, and does the
cast, and one that takes a pointer, does a null check and calls the one that takes a reference).
- bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::getOwnPropertySlot):.
Update to use the implementation namedItem (which is also used by the generated getOwnPropertySlotByIndex)
and match the updated bindings rules. This cannot yet be generated due to the odd case of the 'open'
property requiring custom treatment. I tried removing this, but it cause tests to fail in a way that indicated
that accessing the lexical global object in the open implementation was not working correctly.
- bindings/js/JSHTMLFrameSetElementCustom.cpp: Removed.
Now generated.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateIndexedGetter):
Add description from the spec and change to return the computed values rather than
print them to the output array. This will be useful for some clients going forward,
who only want the attributes.
(GenerateNamedGetter):
Add description from the spec and change to return the computed values rather than
print them to the output array. This will be useful for some clients going forward,
who only want the attributes. Also greatly simplifies things as [CustomNamedGetter]s
are no longer needed/supported and the exception / null value checks are performed
elsewhere.
(GenerateNamedGetterLambda):
This generates a lambda functor for use in accessVisibleNamedProperty(...). It
handles calling the named getter implementation, and transforming the result into
an one that can be reasoned about by accessVisibleNamedProperty, specifically,
converting it from using IDL's notion of nullability to std::optional.
(GenerateGetOwnPropertySlot):
(GenerateGetOwnPropertySlotByIndex):
Add spec annotations and use helper functions.
(GenerateGetOwnPropertyNames):
Add FIXME about supporting non-contiguous indices (should that ever come up)
and use JSObject explicitly, rather than base, to get the default getOwnPropertyNames
implementation.
(GeneratePut):
Use JSObject explicitly, rather than base, to get the default put implementation.
(GeneratePutByIndex):
Use JSObject explicitly, rather than base, to get the default putByIndex implementation.
(GenerateDefineOwnProperty):
Use JSObject explicitly, rather than base, to get the default getOwnPropertySlot/defineOwnProperty
implementations.
(GenerateDeletePropertyCommon):
Adopt new OverrideBuiltins enum.
(GenerateDeletePropertyDefinition):
Use JSObject explicitly, rather than base, to get the default deleteProperty implementation.
(GenerateDeletePropertyByIndexDefinition):
Use JSObject explicitly, rather than base, to get the default deletePropertyByIndex implementation.
(InstanceOverridesGetOwnPropertySlot):
Remove [CustomNamedGetter] use.
(GenerateHeader):
Remove [CustomNamedGetter] use and merge InstanceOverridesGetOwnPropertySlotByIndex into
InstanceOverridesGetOwnPropertySlot. Specifying either [CustomGetOwnPropertySlot] or
[CustomGetOwnPropertySlotByIndex] will now declare both hooks.
(GenerateImplementation):
Rename GenerateGetOwnPropertySlotBody/GenerateGetOwnPropertySlotByIndexBody to remove the 'Body',
and predicate their generation purely on InstanceOverridesGetOwnPropertySlot as noted for the
reasons above.
(GenerateGetOwnPropertySlotBody): Deleted.
(GenerateGetOwnPropertySlotBodyByIndex): Deleted.
(InstanceOverridesGetOwnPropertySlotByIndex): Deleted.
- bindings/scripts/IDLAttributes.json:
Remove [CustomNamedGetter].
- dom/ExceptionOr.h:
(WebCore::ExceptionOr<ReturnType>::returnValue):
Add a function to peek at the return value
- html/HTMLDocument.h:
- html/HTMLDocument.cpp:
(WebCore::HTMLDocument::clear):
(WebCore::HTMLDocument::captureEvents):
(WebCore::HTMLDocument::releaseEvents):
Move clear up to be with the other obsolete no-op functions. Add spec annotations
to clear up any confusion about why they are no-ops.
(WebCore::HTMLDocument::namedItem):
Add implementation of namedItem based on the one that was in JSDOMHTMLDocumentCustom.cpp.
(WebCore::HTMLDocument::supportedPropertyNames):
Add stub version of supportedPropertyNames with the algorithm we need to implement.
I don't want to change behavior in this patch, and since we have not enumerated the
properties of document in the past, I left this unimplemented for now.
- html/HTMLDocument.idl:
Remove [CustomNamedGetter] and add named getter.
- html/HTMLFrameSetElement.h:
- html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::namedItem):
Add named getter based on the implementation in JSHTMLFrameSetElementCustom.cpp.
(WebCore::HTMLFrameSetElement::supportedPropertyNames):
As noted above, I don't want to change behavior with this change, so I have left this unimplemented
for now. However, we may not want to implement it at all, as this named getter is not specified and
at least Firefox does not support it.
- html/HTMLFrameSetElement.idl:
Remove [CustomNamedGetter] and add named getter.
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
- bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:
- bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:
- bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:
- bindings/scripts/test/JS/JSTestInterface.cpp:
- bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:
- bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:
- bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:
- bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:
- bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:
- bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:
- bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:
- bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:
- bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:
- bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:
- bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp:
- bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp:
- bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp:
- bindings/scripts/test/JS/JSTestNode.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
- bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
Update test results.
- bindings/scripts/test/JS/JSTestCustomNamedGetter.cpp: Removed.
- bindings/scripts/test/JS/JSTestCustomNamedGetter.h: Removed.
- bindings/scripts/test/TestCustomNamedGetter.idl: Removed.
Remove test of [CustomNamedGetter] which no longer exists.
LayoutTests:
- fast/dom/HTMLDocument/document-special-properties-expected.txt:
Update results. Named properties on HTMLDocument no longer override own properties, they
only override properties from the prototype chain (as per the WebIDL specification for
OverrideBuiltins). These results now also match Firefox.
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-4.html:
- js/dom/dfg-prototype-chain-caching-with-impure-get-own-property-slot-traps-5.html:
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-4.html:
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5-short.html:
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5.html:
Update tests to use a property on the prototype, rather than the instance, to test
overriding the [GetOwnProperty] hook. This is needed now that HTMLDocument correctly
follows the OverrideBuiltins rules as explained above.
- 12:50 PM Renames edited by
- (diff)
- 12:49 PM Renames created by
- 12:46 PM WikiStart edited by
- (diff)
- 12:34 PM Changeset in webkit [218125] by
-
- 4 edits in trunk
WebItemProviderPasteboard should call its completion block immediately after a synchronous load
https://bugs.webkit.org/show_bug.cgi?id=173225
<rdar://problem/32713144>
Reviewed by Tim Horton.
Source/WebCore:
Ensures that a completion block passed to doAfterLoadingProvidedContentIntoFileURLs:synchronousTimeout: will be
invoked immediately, if a synchronous timeout is specified and loading finishes before the synchronous timeout
is reached. To do this, we first factor out the completion logic into a new block. If the synchronous timeout
exists and dispatch_group_wait returns 0 (indicating that the dispatch group finished without hitting the
wait timeout) we simply invoke the block and return early; otherwise, we will register the completion block
using dispatch_group_notify.
Test: DataInteractionTests.WebItemProviderPasteboardLoading
- platform/ios/WebItemProviderPasteboard.mm:
(-[WebItemProviderPasteboard doAfterLoadingProvidedContentIntoFileURLs:synchronousTimeout:]):
Tools:
Adds a new unit test to verify whether the completion block is called synchronously or asynchronously, in both
cases where the synchronous timeout is very large, and the synchronous timeout is not used (0).
- TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(TestWebKitAPI::TEST):
- 12:19 PM Changeset in webkit [218124] by
-
- 2 edits in trunk/Source/WebKit2
[iOS DnD] Introduce hooks to override targeted drag previews when lifting and cancelling
https://bugs.webkit.org/show_bug.cgi?id=173240
<rdar://problem/31943370>
Reviewed by Ryosuke Niwa and Tim Horton.
Adds two new delegate hooks: _webView:previewForLiftingItem:session: and
_webView:previewForCancellingItem:withDefault:.
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
- 12:07 PM Changeset in webkit [218123] by
-
- 2 edits in trunk/Tools
Return correct process names for iOS on-device testing
https://bugs.webkit.org/show_bug.cgi?id=173263
Reviewed by Alex Christensen.
When running tests on iOS devices, process names do not end with '.Development'
as they do on Mac and iOS simulator.
- WebKitTestRunner/TestController.cpp:
(WTR::TestController::webProcessName): Return correct process name without '.Development'
for iOS on-device testing.
(WTR::TestController::networkProcessName): Ditto.
(WTR::TestController::databaseProcessName): Ditto.
- 12:00 PM Changeset in webkit [218122] by
-
- 2 edits in trunk/LayoutTests
Unreviewed. Unmark test as flaky after fix in r217944. The test should now pass.
- platform/mac/TestExpectations:
- 11:55 AM Changeset in webkit [218121] by
-
- 4 edits in trunk
Regression(r217867): Legacy SessionHistoryEntryData format should not change
https://bugs.webkit.org/show_bug.cgi?id=173267
<rdar://problem/32701257>
Reviewed by Simon Fraser.
Source/WebKit2:
Revert changes to Legacy SessionHistoryEntryData format that were made in r217867,
as this apparently breaks compatiblity.
- UIProcess/mac/LegacySessionStateCoding.cpp:
(WebKit::encodeFrameStateNode):
(WebKit::decodeBackForwardTreeNode):
Tools:
Restrict test to stop covering saving / restore of scrollRestoration via the legacy
SessionHistoryEntryData. Maintain coverage for the default value of scrollRestoration
though as this covers the crash that r217867 was fixing.
- TestWebKitAPI/Tests/WebKit2/RestoreSessionState.cpp:
(TestWebKitAPI::createSessionStateData):
(TestWebKitAPI::TEST):
(TestWebKitAPI::createSessionStateDataContainingScrollRestoration): Deleted.
- 11:49 AM Changeset in webkit [218120] by
-
- 5 edits in tags/Safari-604.1.25/Source
Cherry-pick r218068. rdar://problem/32686871
- 11:49 AM Changeset in webkit [218119] by
-
- 2 edits in tags/Safari-604.1.25/Source/WebKit2
Cherry-pick r218022. rdar://problem/32598919
- 11:49 AM Changeset in webkit [218118] by
-
- 7 edits in tags/Safari-604.1.25/Source/WebKit2
Cherry-pick r218011. rdar://problem/32679311
- 11:49 AM Changeset in webkit [218117] by
-
- 2 edits in tags/Safari-604.1.25/Source/WebKit2
Cherry-pick r218006. rdar://problem/32598919
- 11:49 AM Changeset in webkit [218116] by
-
- 4 edits in tags/Safari-604.1.25/Source/WebKit2
Cherry-pick r218002. rdar://problem/32679311
- 11:49 AM Changeset in webkit [218115] by
-
- 4 edits in tags/Safari-604.1.25/Source/WebKit2
Cherry-pick r217991. rdar://problem/32594952
- 11:45 AM Changeset in webkit [218114] by
-
- 4 edits in trunk/Source/WebCore
WebAVPlayerController minTime and maxTime should be calculated properties to provide correct values when streaming.
https://bugs.webkit.org/show_bug.cgi?id=173193
rdar://problem/32684807
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-06-12
Reviewed by Jer Noble.
No new tests because no affect on the DOM. This only affects properties consumed to AVKit.
-minTime and -maxTime should be calculated properties so they supply the exptected values to AVKit while streaming.
- platform/ios/WebAVPlayerController.h:
- platform/ios/WebAVPlayerController.mm:
(-[WebAVPlayerController maxTime]):
(+[WebAVPlayerController keyPathsForValuesAffectingMaxTime]):
(-[WebAVPlayerController minTime]):
(+[WebAVPlayerController keyPathsForValuesAffectingMinTime]):
(-[WebAVPlayerController resetMediaState]):
- platform/ios/WebPlaybackSessionInterfaceAVKit.mm:
(WebCore::WebPlaybackSessionInterfaceAVKit::durationChanged):
- 11:42 AM Changeset in webkit [218113] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, suppress invalid register alloation validation assertion in 32 bit
https://bugs.webkit.org/show_bug.cgi?id=172421
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArrayIndexOf):
- 11:30 AM Changeset in webkit [218112] by
-
- 7 edits in tags/Safari-604.1.25/Source
Versioning.
- 11:23 AM Changeset in webkit [218111] by
-
- 9 edits in trunk
We incorrectly allow escaped characters in keyword tokens
https://bugs.webkit.org/show_bug.cgi?id=171310
Reviewed by Yusuke Suzuki.
JSTests:
- stress/destructuring-assignment-syntax.js:
- stress/error-messages-for-in-operator-should-not-crash.js:
(catch):
- stress/reserved-word-with-escape.js:
(testSyntaxError.String.raw.v):
(String.raw.SyntaxError.Cannot.use.the.keyword.string_appeared_here.as.a.name):
(testSyntaxError.String.raw.a):
- JSTests/ChakraCore/test/Basics/IdsWithEscapes.baseline-jsc:
Source/JavaScriptCore:
According spec it is not allow to use escaped characters in
keywords. https://tc39.github.io/ecma262/#sec-reserved-words
Current patch implements this requirements.
- parser/Lexer.cpp:
(JSC::Lexer<CharacterType>::parseIdentifierSlowCase):
- parser/Parser.cpp:
(JSC::Parser<LexerType>::printUnexpectedTokenText):
- parser/ParserTokens.h:
- 10:40 AM Changeset in webkit [218110] by
-
- 1 edit in trunk/LayoutTests/ChangeLog
Updated test expectations for fast/mediastream/getUserMedia-webaudio.html.
https://bugs.webkit.org/show_bug.cgi?id=170960
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 10:38 AM Changeset in webkit [218109] by
-
- 2 edits in trunk/Source/WebKit2
[WK2][macOS] Alow iokit-get-properties for additional media features
https://bugs.webkit.org/show_bug.cgi?id=173082
<rdar://problem/32597547>
Reviewed by Alex Christensen.
- WebProcess/com.apple.WebProcess.sb.in:
- 10:28 AM Changeset in webkit [218108] by
-
- 5 edits in trunk/Source/WebCore
Call _sqlite3_purgeEligiblePagerCacheMemory() on memory pressure only if sqlite is initialized
https://bugs.webkit.org/show_bug.cgi?id=173264
Reviewed by Ryosuke Niwa.
Call _sqlite3_purgeEligiblePagerCacheMemory() on memory pressure only if sqlite is initialized.
Otherwise, not only is it no needed, it is also potentially unsafe.
- page/MemoryRelease.cpp:
(WebCore::registerSQLiteMemoryPressureHandler):
- page/MemoryRelease.h:
- page/cocoa/MemoryReleaseCocoa.mm:
(WebCore::platformReleaseMemory):
(WebCore::registerSQLiteMemoryPressureHandler):
- platform/sql/SQLiteDatabase.cpp:
(WebCore::initializeSQLiteIfNecessary):
- 10:19 AM Changeset in webkit [218107] by
-
- 7 edits1 copy in trunk/Source/WebKit2
Add API::IconDatabaseClient
https://bugs.webkit.org/show_bug.cgi?id=173145
Reviewed by Alex Christensen.
It will be used by GTK+ port instead of the C API.
- UIProcess/API/APIIconDatabaseClient.h:
(API::IconDatabaseClient::~IconDatabaseClient):
(API::IconDatabaseClient::didChangeIconForPageURL):
(API::IconDatabaseClient::didRemoveAllIcons):
(API::IconDatabaseClient::iconDataReadyForPageURL):
- UIProcess/API/C/WKIconDatabase.cpp:
(WKIconDatabaseSetIconDatabaseClient):
- UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::WebIconDatabase):
(WebKit::WebIconDatabase::setClient):
(WebKit::WebIconDatabase::didChangeIconForPageURL):
(WebKit::WebIconDatabase::didRemoveAllIcons):
(WebKit::WebIconDatabase::notifyIconDataReadyForPageURL):
- UIProcess/WebIconDatabase.h:
- UIProcess/WebIconDatabaseClient.cpp:
(WebKit::WebIconDatabaseClient::WebIconDatabaseClient):
(WebKit::WebIconDatabaseClient::didChangeIconForPageURL):
(WebKit::WebIconDatabaseClient::didRemoveAllIcons):
(WebKit::WebIconDatabaseClient::iconDataReadyForPageURL):
- UIProcess/WebIconDatabaseClient.h:
- WebKit2.xcodeproj/project.pbxproj:
- 10:10 AM Changeset in webkit [218106] by
-
- 9 edits in trunk
[GTK] Stop dismissing menus attached to the web view for every injected event
https://bugs.webkit.org/show_bug.cgi?id=172708
Reviewed by Alex Christensen.
Source/WebKit2:
To actually simulate a right-click event we should also send the button release after the press, and let the page
handle the events in addition to sending the event to the context menu controller, like we do with normal
events. So, this is mostly the same as a real right-click event but without actually showing the menu.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::contextMenuAtPointInWindow):
Tools:
It's a workaround we added in r184015 that has worked so far for the context menu, but doesn't really work now
that we also attach popup menus to the web view. We really need to be able to show a popup menu, and then send
events while the menu is open.
- WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::contextClick): Use WKBundlePageCopyContextMenuAtPointInWindow() also in GTK+ port.
- WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::EventSenderProxy::dispatchEvent): Stop calling PlatformWebView::dismissAllPopupMenus().
LayoutTests:
- editing/selection/5354455-1.html: No need to click on editable area to focus it, contextClick already focuses
it, we even have another test to ensure it. Those fast clicks were causing a double click in GTK+ port which
selected the whole line. We don't need to dismiss the context menu either, because contextClick() doesn't really
show the menu.
- fast/events/context-activated-by-key-event.html: Dismiss the context menu every time we show it.
- fast/events/mouse-click-events.html: Dimiss the context menu when testing right click events.
- 10:02 AM Changeset in webkit [218105] by
-
- 2 edits in trunk/LayoutTests
Mark fast/mediastream/getUserMedia-webaudio.html as flaky on mac-wk2.
https://bugs.webkit.org/show_bug.cgi?id=170960
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 9:01 AM Changeset in webkit [218104] by
-
- 2 edits in trunk/LayoutTests
Marked imported/w3c/web-platform-tests/html/browsers/windows/browsing-context.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=172255
Unreviewed test gardening.
- platform/mac/TestExpectations:
- 8:48 AM Changeset in webkit [218103] by
-
- 2 edits in trunk/LayoutTests
transforms/hittest-translated-content-off-to-infinity-and-back.html is passing
Ureviewed gardening.
- platform/wpe/TestExpectations: This started passing lately, remove.
- 8:27 AM Changeset in webkit [218102] by
-
- 2 edits in trunk/Source/WebKit2
[CoordinatedGraphics] Behavior change of DrawingAreaImpl after r217779
https://bugs.webkit.org/show_bug.cgi?id=173153
Patch by Daewoong Jang <daewoong.jang@navercorp.com> on 2017-06-12
Reviewed by Carlos Garcia Campos.
- WebProcess/WebPage/AcceleratedDrawingArea.cpp:
(WebKit::AcceleratedDrawingArea::mainFrameContentSizeChanged):
- 8:19 AM Changeset in webkit [218101] by
-
- 4 edits in trunk/LayoutTests
[WPE][GTK] Rebaseline js/dom/global-constructors-attributes.html
Unreviewed gardening.
Needs to be updated in WPE due to enabling ENCRYPTED_MEDIA. GTK+
port was skipping this but it just needs an updated expectations.
- platform/gtk/TestExpectations: Unskip.
- platform/gtk/js/dom/global-constructors-attributes-expected.txt:
- platform/wpe/js/dom/global-constructors-attributes-expected.txt:
- 7:56 AM Changeset in webkit [218100] by
-
- 4 edits in trunk/Source/WebCore
[GCrypt] Use utility functions in CryptoKeyEC, CryptoKeyRSA
https://bugs.webkit.org/show_bug.cgi?id=173253
Reviewed by Michael Catanzaro.
Use the utility functions from the GCryptUtilities.h header instead
of writing the same code in both CryptoKeyEC and CryptoKeyRSA
implementations. The switches are straightforward, the only difference
is that the GCryptUtilities functions return a std::optional<> object,
meaning we have to address possibly invalid return value.
The mpiData() function is overloaded, making it possible to pass to it
either a gcry_sexp_t or gcry_mpi_t object. Additionally, mpiLength()
function is added, overloading again for gcry_sexp_t and gcry_mpi_t.
This function is used from mpiData() as well as in CryptoKeyRSA when
retrieving the RSA modulus length.
No new tests -- no changes in behavior.
- crypto/gcrypt/CryptoKeyECGCrypt.cpp:
(WebCore::CryptoKeyEC::platformExportRaw):
(WebCore::CryptoKeyEC::platformAddFieldElements):
(WebCore::extractMPIData): Deleted.
- crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:
(WebCore::getRSAModulusLength):
(WebCore::getRSAKeyParameter):
(WebCore::CryptoKeyRSA::exportData):
(WebCore::getParameterMPIData): Deleted.
- crypto/gcrypt/GCryptUtilities.h:
(WebCore::mpiLength):
(WebCore::mpiData):
- 6:27 AM Changeset in webkit [218099] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, add branch64(Cond, BaseIndex, RegisterID) for ARM64
https://bugs.webkit.org/show_bug.cgi?id=172421
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::branch64):
(JSC::MacroAssemblerARM64::branchPtr):
- 5:58 AM Changeset in webkit [218098] by
-
- 12 edits in trunk/Source/WebKit2
[GTK] Prefer to use private WebKitWebView API over WebKitWebViewBase
https://bugs.webkit.org/show_bug.cgi?id=173254
Reviewed by Žan Doberšek.
WebKitWebViewBase is specific to the GTK+ API, but WebKitWebView should be present in any glib-based API. Add
webkitWebViewCreatePage() and webkitWebViewGetPage() and use them when possible instead of the WebKitWebViewBase
ones.
- UIProcess/API/gtk/WebKitAutomationSession.cpp:
- UIProcess/API/gtk/WebKitContextMenuClient.cpp:
(attachContextMenuClientToView):
- UIProcess/API/gtk/WebKitFindController.cpp:
(getPage):
(webkitFindControllerDispose):
(webkitFindControllerConstructed):
(webKitFindControllerPerform):
(webkit_find_controller_search_finish):
- UIProcess/API/gtk/WebKitFormClient.cpp:
(attachFormClientToView):
- UIProcess/API/gtk/WebKitLoaderClient.cpp:
(attachLoaderClientToView):
- UIProcess/API/gtk/WebKitPolicyClient.cpp:
(attachPolicyClientToView):
- UIProcess/API/gtk/WebKitPrintOperation.cpp:
(drawPagesForPrintingCompleted):
(webkitPrintOperationPrintPagesForFrame):
(webkit_print_operation_run_dialog):
(webkit_print_operation_print):
- UIProcess/API/gtk/WebKitUIClient.cpp:
(attachUIClientToView):
- UIProcess/API/gtk/WebKitWebContext.cpp:
(webkitWebContextCreatePageForWebView):
(webkitWebContextWebViewDestroyed):
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewCreatePage):
(webkitWebViewGetPage):
- UIProcess/API/gtk/WebKitWebViewPrivate.h:
- 5:54 AM Changeset in webkit [218097] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] getPage() in WebKitWebView should return a reference instead of a pointer
https://bugs.webkit.org/show_bug.cgi?id=173251
Reviewed by Žan Doberšek.
The WebPageProxy is created on WebKitWebView construction, so getPage() can only return nullptr if it's called
during construction. And that can only happen when construct properties are set. It's better to check that the
view has been constructed only in these particular cases and make getPage() return a reference.
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewCreateJavaScriptDialog):
(allowModalDialogsChanged): Settings signals are only connected after the page has been created, so we don't
need to check page is available here.
(zoomTextOnlyChanged):
(userAgentChanged):
(webkitWebViewIsConstructed): Helper method to check if the view has been constructed.
(webkitWebViewUpdateSettings): Return early if view hasn't been constructed.
(webkitWebViewDisconnectSettingsSignalHandlers): Ditto.
(webkitWebViewConstructed):
(webkitWebViewDispose):
(webkitWebViewCreateNewPage):
(webkitWebViewSelectionDidChange):
(webkit_web_view_try_close):
(webkit_web_view_load_uri):
(webkit_web_view_load_html):
(webkit_web_view_load_alternate_html):
(webkit_web_view_load_plain_text):
(webkit_web_view_load_bytes):
(webkit_web_view_load_request):
(webkit_web_view_get_page_id):
(webkit_web_view_reload):
(webkit_web_view_reload_bypass_cache):
(webkit_web_view_stop_loading):
(webkit_web_view_is_playing_audio):
(webkit_web_view_go_back):
(webkit_web_view_can_go_back):
(webkit_web_view_go_forward):
(webkit_web_view_can_go_forward):
(webkit_web_view_get_custom_charset):
(webkit_web_view_set_custom_charset):
(webkit_web_view_get_estimated_load_progress):
(webkit_web_view_go_to_back_forward_list_item):
(webkit_web_view_set_zoom_level):
(webkit_web_view_get_zoom_level):
(webkit_web_view_can_execute_editing_command):
(webkit_web_view_execute_editing_command):
(webkit_web_view_execute_editing_command_with_argument):
(webkit_web_view_run_javascript):
(resourcesStreamReadCallback):
(webkit_web_view_get_inspector):
(webkit_web_view_can_show_mime_type):
(webkit_web_view_save):
(webkit_web_view_save_to_file):
(webkit_web_view_download_uri):
(webkit_web_view_get_tls_info):
(webkit_web_view_get_snapshot):
(webkit_web_view_set_background_color):
(webkit_web_view_get_background_color):
(webkit_web_view_is_editable):
(webkit_web_view_set_editable):
(webkit_web_view_get_editor_state):
(webkit_web_view_get_session_state):
(webkit_web_view_restore_session_state):
- 5:50 AM Changeset in webkit [218096] by
-
- 3 edits1 copy in trunk/Source
[GTK] Move WebKit GType macros to WTF
https://bugs.webkit.org/show_bug.cgi?id=173249
Reviewed by Žan Doberšek.
Source/WebKit2:
Moving to a common place where they could be shared by all ports using a glib-based API.
- UIProcess/API/gtk/WebKitPrivate.h:
Source/WTF:
They can be used by glib-based ports and eventually by JavaScriptCore glib bindings too.
- wtf/glib/WTFGType.h: Copied from Source/WebKit2/UIProcess/API/gtk/WebKitPrivate.h.
- 5:23 AM Changeset in webkit [218095] by
-
- 2 edits in trunk/LayoutTests
Mark fast/mediastream/getUserMedia-grant-persistency3.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=173257
Unreviewed gardening.
Patch by Charlie Turner <cturner@igalia.com> on 2017-06-12
- platform/gtk/TestExpectations:
- 5:17 AM Changeset in webkit [218094] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, rolling out r218093.
https://bugs.webkit.org/show_bug.cgi?id=173259
Break builds (Requested by yusukesuzuki on #webkit).
Reverted changeset:
"Unreviewed, build fix for ARM64"
https://bugs.webkit.org/show_bug.cgi?id=172421
http://trac.webkit.org/changeset/218093
- 4:51 AM Changeset in webkit [218093] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, build fix for ARM64
https://bugs.webkit.org/show_bug.cgi?id=172421
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArrayIndexOf):
- 2:40 AM Changeset in webkit [218092] by
-
- 2 edits in trunk/Tools
[GTK][WPE] Enable GStreamer GL on development builds
https://bugs.webkit.org/show_bug.cgi?id=173248
Enable GStreamer GL for GTK and WPE.
Reviewed by Carlos Garcia Campos.
- Scripts/webkitperl/FeatureList.pm:
- 1:14 AM Changeset in webkit [218091] by
-
- 2 edits in trunk/Tools
Unreviewed. Fix GTK+ test /webkit2/WebKitWebView/notification after r216641.
Notifications are no longer cleared on page navigation.
- TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitWebView.cpp:
(testWebViewNotification):
Jun 11, 2017:
- 11:54 PM Changeset in webkit [218090] by
-
- 2 edits in trunk/Tools
Unreviewed. Fix GTK+ test /webkit2/WebKitAutomationSession/request-session after r217831.
DBus interface and object path names were updated in r217831.
- TestWebKitAPI/Tests/WebKit2Gtk/TestAutomationSession.cpp:
- 11:05 PM Changeset in webkit [218089] by
-
- 7 edits1 move3 deletes in trunk/Source/WebKit2
[GTK] Remove WKInspectorClientGtk
https://bugs.webkit.org/show_bug.cgi?id=173142
Reviewed by Michael Catanzaro.
It's only used internally in GTk+ API, we can simplify it by using a C++ client instead.
- PlatformGTK.cmake:
- UIProcess/API/C/gtk/WKInspectorClientGtk.cpp: Removed.
- UIProcess/API/C/gtk/WKInspectorClientGtk.h: Removed.
- UIProcess/API/gtk/WebKitPrivate.h:
- UIProcess/API/gtk/WebKitWebInspector.cpp:
(_WebKitWebInspectorPrivate::~_WebKitWebInspectorPrivate):
(webkitWebInspectorCreate):
- UIProcess/WebInspectorProxy.cpp:
- UIProcess/WebInspectorProxy.h:
- UIProcess/gtk/WebInspectorClientGtk.cpp: Removed.
- UIProcess/gtk/WebInspectorProxyClient.h: Renamed from Source/WebKit2/UIProcess/gtk/WebInspectorClientGtk.h.
- UIProcess/gtk/WebInspectorProxyGtk.cpp:
(WebKit::WebInspectorProxy::setClient):
(WebKit::WebInspectorProxy::createInspectorWindow):
(WebKit::WebInspectorProxy::platformDidClose):
(WebKit::WebInspectorProxy::platformBringToFront):
(WebKit::WebInspectorProxy::platformInspectedURLChanged):
(WebKit::WebInspectorProxy::platformAttach):
(WebKit::WebInspectorProxy::platformDetach):
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight):
(WebKit::WebInspectorProxy::platformSetAttachedWindowWidth):
(WebKit::WebInspectorProxy::platformAttachAvailabilityChanged):
- 10:19 PM Changeset in webkit [218088] by
-
- 7 edits in tags/Safari-604.1.25.0.1/Source
Versioning.
- 10:17 PM Changeset in webkit [218087] by
-
- 1 copy in tags/Safari-604.1.25.0.1
New tag.
- 10:03 PM Changeset in webkit [218086] by
-
- 1 edit1 move in trunk/LayoutTests
[iOS 11] fast/text/international/system-language/arabic-glyph-cache-fill-combine.html hardcodes the system UI Arabic font
https://bugs.webkit.org/show_bug.cgi?id=173244
<rdar://problem/32659595>
Reviewed by Ryosuke Niwa.
iOS 11 changed this font, so we shouldn't hardcode it. Instead,
we can simply change this to an -expected-mismatch.html test to
specifically test against the ".notdef" glyph.
- fast/text/international/system-language/arabic-glyph-cache-fill-combine-expected-mismatch.html: Renamed from LayoutTests/fast/text/international/system-language/arabic-glyph-cache-fill-combine-expected.html.
- 10:02 PM Changeset in webkit [218085] by
-
- 2 edits in trunk/LayoutTests
fast/text/variations/getComputedStyle.html does not need to be asynchronous
https://bugs.webkit.org/show_bug.cgi?id=173246
<rdar://problem/31393842>
Reviewed by Sam Weinig.
I dont know why I made it asynchronous in the first place.
- fast/text/variations/getComputedStyle.html:
- 8:58 PM Changeset in webkit [218084] by
-
- 23 edits15 adds in trunk
[DFG] Add ArrayIndexOf intrinsic
https://bugs.webkit.org/show_bug.cgi?id=172421
Reviewed by Saam Barati.
JSTests:
- stress/array-indexof-array-prototype-change.js: Added.
(shouldBe):
(indexOfInt32):
- stress/array-indexof-have-a-bad-time-getter.js: Added.
(shouldBe):
(indexOfInt32):
- stress/array-indexof-have-a-bad-time.js: Added.
(shouldBe):
(indexOfInt32):
- stress/array-indexof-hole-with-prototype.js: Added.
(shouldBe):
(indexOf):
- stress/array-indexof-hole.js: Added.
(shouldBe):
(indexOf):
- stress/array-indexof-index.js: Added.
(shouldBe):
(indexOfInt32):
(indexOfDouble):
(indexOfString):
(indexOfObject):
(indexOfValue):
- stress/array-indexof-negative-index.js: Added.
(shouldBe):
(indexOfInt32):
(indexOfDouble):
(indexOfString):
(indexOfObject):
(indexOfValue):
- stress/array-indexof-non-int32-start-index.js: Added.
(shouldBe):
(indexOf):
(object.valueOf):
- stress/array-indexof-object-prototype-change.js: Added.
(shouldBe):
(indexOfInt32):
- stress/array-indexof-object.js: Added.
(shouldBe):
(indexOf):
- stress/array-indexof-original-array.js: Added.
(shouldBe):
(indexOfInt32):
- stress/array-indexof-string.js: Added.
(shouldBe):
(indexOf):
- stress/array-indexof-structure-change-convert.js: Added.
(shouldBe):
(indexOf):
- stress/array-indexof-structure-change.js: Added.
(shouldBe):
(indexOf):
- stress/array-indexof.js: Added.
(shouldBe):
(indexOf):
Source/JavaScriptCore:
This patch introduces ArrayIndexOfInstrinsic for DFG and FTL optimizations.
We emit array check and go fast path if the array is Array::Int32, Array::Double
or Array::Continugous. In addition, for Array::Int32 and Array::Double case,
we have inlined fast paths.
With updated ARES-6 Babylon,
Before
firstIteration: 45.76 +- 3.87 ms
averageWorstCase: 24.41 +- 2.17 ms
steadyState: 8.01 +- 0.22 ms
After
firstIteration: 45.64 +- 4.23 ms
averageWorstCase: 23.03 +- 3.34 ms
steadyState: 7.33 +- 0.34 ms
In SixSpeed.
baseline patched
map-set-lookup.es5 734.4701+-10.4383 102.0968+-2.6357 definitely 7.1939x faster
map-set.es5 41.1396+-1.0558 33.1916+-0.7986 definitely 1.2395x faster
map-set-object.es5 62.8317+-1.2518 45.6944+-0.8369 definitely 1.3750x faster
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGDoesGC.cpp:
(JSC::DFG::doesGC):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNode.h:
(JSC::DFG::Node::hasArrayMode):
- dfg/DFGNodeType.h:
- dfg/DFGOperations.cpp:
- dfg/DFGOperations.h:
- dfg/DFGPredictionPropagationPhase.cpp:
- dfg/DFGSafeToExecute.h:
(JSC::DFG::safeToExecute):
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileArrayIndexOf):
(JSC::DFG::SpeculativeJIT::speculateObject):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
- dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
- dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::speculateInt32):
- ftl/FTLCapabilities.cpp:
(JSC::FTL::canCompile):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compileArrayIndexOf):
- jit/JITOperations.h:
- runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::finishCreation):
- runtime/Intrinsic.cpp:
(JSC::intrinsicName):
- runtime/Intrinsic.h:
- 8:46 PM Changeset in webkit [218083] by
-
- 6 edits2 adds in trunk
didMoveToNewDocument doesn't get called on an Attr inside a shadow tree
https://bugs.webkit.org/show_bug.cgi?id=173133
Reviewed by Antti Koivisto.
Source/WebCore:
The bug was caused by moveShadowTreeToNewDocument never calling didMoveToNewDocument on Attr nodes.
Fixed the bug by using the same traversal code as moveTreeToNewScope in moveShadowTreeToNewDocument
by extracting the traversal code as a templatized traverseSubtreeToUpdateTreeScope.
Also removed the code to increment the DOM tree version in moveTreeToNewScope. This code was there
to invalidate the HTML collection caches which used to clear the cache whenever the DOM tree version
changed before r122621 (five years ago! by me). Since we now eagerly invalidate each node list and
HTML collection's caches via NodeListsNodeData::adoptTreeScope and NodeListsNodeData::adoptDocument.
Test: fast/dom/adopt-attr-with-shadow-tree.html
- dom/Node.cpp:
(WebCore::moveNodeToNewDocument): Assert that the node had been adopted to a new document.
(WebCore::traverseSubtreeToUpdateTreeScope): Extracted from moveTreeToNewScope.
(WebCore::moveShadowTreeToNewDocument): Use traverseSubtreeToUpdateTreeScope to adopt each node
to the new document.
(WebCore::Node::moveTreeToNewScope): See above.
- testing/Internals.cpp:
(WebCore::Internals::referencingNodeCount): Added. Used in the newly added regression test.
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Added a regression test for moving a shadow tree with an Attr node across a document.
The test hits an assertion in a debug build and fails in a release build without the fix.
- fast/dom/adopt-attr-with-shadow-tree-expected.txt: Added.
- fast/dom/adopt-attr-with-shadow-tree.html: Added.
- 7:40 PM Changeset in webkit [218082] by
-
- 10 edits in trunk
TypedArray constructor with string shouldn't throw
https://bugs.webkit.org/show_bug.cgi?id=173181
Reviewed by JF Bastien.
JSTests:
We should be coercing primitive arguments to numbers in the various
TypedArray constructors.
- stress/typedarray-constructor.js:
Source/JavaScriptCore:
We should be coercing primitive arguments to numbers in the various
TypedArray constructors.
- runtime/JSGenericTypedArrayViewConstructorInlines.h:
(JSC::constructGenericTypedArrayViewWithArguments):
LayoutTests:
Update tests to allow null buffers.
- fast/canvas/webgl/array-unit-tests-expected.txt:
- fast/canvas/webgl/array-unit-tests.html:
- fast/canvas/webgl/webgl-array-invalid-ranges-expected.txt:
- fast/canvas/webgl/webgl-array-invalid-ranges.html:
- webgl/1.0.2/resources/webgl_test_files/conformance/typedarrays/array-unit-tests.html:
- 6:57 PM Changeset in webkit [218081] by
-
- 2 edits in trunk/Source/WebCore
[Mac] Unaligned pointers in static CMBufferCallbacks structs defined in WebCoreDecompressionSession.mm
https://bugs.webkit.org/show_bug.cgi?id=173245
Reviewed by Sam Weinig.
- platform/graphics/cocoa/WebCoreDecompressionSession.mm:
(WebCore::WebCoreDecompressionSession::enqueueSample): Prepend 4 bytes of padding to the
structs so that the pointers are properly aligned.
- 5:47 PM Changeset in webkit [218080] by
-
- 11 edits in trunk/Source
[WTF] Make ThreadMessage portable
https://bugs.webkit.org/show_bug.cgi?id=172073
Reviewed by Keith Miller.
Source/JavaScriptCore:
- runtime/MachineContext.h:
(JSC::MachineContext::stackPointer):
- tools/CodeProfiling.cpp:
(JSC::profilingTimer):
Source/WTF:
Recently, we change ThreadMessage semantics: message handler
can be executed in the sender thread.
This allows ThreadMessage to be implemented in a portable way.
This patch implements ThreadMessage for all the platforms.
We use platform-independent Thread APIs, suspend(), resume(),
and getRegisters().
- wtf/PlatformRegisters.h:
(WTF::registersFromUContext):
- wtf/ThreadMessage.cpp:
(WTF::sendMessageScoped):
(WTF::ThreadMessageData::ThreadMessageData): Deleted.
(): Deleted.
(WTF::initializeThreadMessages): Deleted.
(WTF::sendMessageUsingSignal): Deleted.
(WTF::sendMessageUsingMach): Deleted.
(WTF::deliverMessagesUsingMach): Deleted.
- wtf/ThreadMessage.h:
- wtf/Threading.cpp:
(WTF::initializeThreading):
- wtf/Threading.h:
(WTF::Thread::threadMessages): Deleted.
- wtf/ThreadingPthreads.cpp:
(WTF::Thread::signalHandlerSuspendResume):
(WTF::threadStateMetadata):
(WTF::Thread::getRegisters):
- wtf/threads/Signals.cpp:
(WTF::handleSignalsWithMach):
- 2:54 PM Changeset in webkit [218079] by
-
- 3 edits2 deletes in trunk/LayoutTests
Rebaseline media/modern-media-controls/scrubber
https://bugs.webkit.org/show_bug.cgi?id=173212
Reviewed by Jon Lee.
Remove a media/modern-media-controls/scrubber test that is no longer relevant now that there is no standalone scrubber class.
- media/modern-media-controls/scrubber/scrubber-expected.txt: Removed.
- media/modern-media-controls/scrubber/scrubber.html: Removed.
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 2:53 PM Changeset in webkit [218078] by
-
- 3 edits in trunk/LayoutTests
Enable media/modern-media-controls/scheduler
https://bugs.webkit.org/show_bug.cgi?id=173211
Reviewed by Jon Lee.
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 2:51 PM Changeset in webkit [218077] by
-
- 5 edits in trunk/LayoutTests
Rebaseline media/modern-media-controls/rewind-button
https://bugs.webkit.org/show_bug.cgi?id=173210
Reviewed by Jon Lee.
Use SVG assets.
- media/modern-media-controls/rewind-button/rewind-button-expected.txt:
- media/modern-media-controls/rewind-button/rewind-button.html:
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 2:49 PM Changeset in webkit [218076] by
-
- 5 edits in trunk/LayoutTests
Rebaseline media/modern-media-controls/play-pause-button
https://bugs.webkit.org/show_bug.cgi?id=173209
Reviewed by Jon Lee.
Use SVG assets.
- media/modern-media-controls/play-pause-button/play-pause-button-expected.txt:
- media/modern-media-controls/play-pause-button/play-pause-button.html:
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 2:48 PM Changeset in webkit [218075] by
-
- 5 edits in trunk/LayoutTests
Rebaseline media/modern-media-controls/placard
https://bugs.webkit.org/show_bug.cgi?id=173208
Reviewed by Jon Lee.
IconButton is now simply Button.
- media/modern-media-controls/placard/placard-expected.txt:
- media/modern-media-controls/placard/placard.html:
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 2:46 PM Changeset in webkit [218074] by
-
- 3 edits in trunk/LayoutTests
Enable media/modern-media-controls/pip-placard tests
https://bugs.webkit.org/show_bug.cgi?id=173207
Reviewed by Jon Lee.
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 2:45 PM Changeset in webkit [218073] by
-
- 5 edits in trunk/LayoutTests
Rebaseline media/modern-media-controls/pip-button.
https://bugs.webkit.org/show_bug.cgi?id=173206
Reviewed by Jon Lee.
Use SVG assets.
- media/modern-media-controls/pip-button/pip-button-expected.txt:
- media/modern-media-controls/pip-button/pip-button.html:
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 2:43 PM Changeset in webkit [218072] by
-
- 5 edits in trunk/LayoutTests
Rebaseline media/modern-media-controls/mute-button
https://bugs.webkit.org/show_bug.cgi?id=173205
Reviewed by Jon Lee.
We now use SVG assets, so let the test reflect that.
- media/modern-media-controls/mute-button/mute-button-expected.txt:
- media/modern-media-controls/mute-button/mute-button.html:
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 2:40 PM Changeset in webkit [218071] by
-
- 1 edit1 delete in trunk/LayoutTests
Remove media/modern-media-controls/macos-media-controls
https://bugs.webkit.org/show_bug.cgi?id=173204
Reviewed by Jon Lee.
There no longer is a MacOSMediaControls class and this test no longer makes sense.
- media/modern-media-controls/macos-media-controls/macos-media-controls-expected.txt: Removed.
- media/modern-media-controls/macos-media-controls/macos-media-controls.html: Removed.
- 10:02 AM Changeset in webkit [218070] by
-
- 4 edits in trunk/Source/JavaScriptCore
[JSC] Shrink Structure size
https://bugs.webkit.org/show_bug.cgi?id=173239
Reviewed by Mark Lam.
We find that the size of our Structure is slightly enlarged due to paddings.
By changing the order of members, we can reduce the size from 120 to 112.
This is good because 120 and 112 are categorized into different size classes.
For 120, we allocate 128 bytes. And for 112, we allocate 112 bytes.
We now save 16 bytes per Structure for free.
- runtime/ConcurrentJSLock.h:
- runtime/Structure.cpp:
(JSC::Structure::Structure):
- runtime/Structure.h:
- 9:59 AM Changeset in webkit [218069] by
-
- 5 edits in trunk/Source/WTF
[WTF] Drop unnecessary includes in Threading.h
https://bugs.webkit.org/show_bug.cgi?id=173167
Reviewed by Darin Adler.
Threading.h includes bunch of headers. But some of them are not necessary.
This patch cleans up it a bit.
- wtf/Assertions.cpp:
- wtf/LocklessBag.h:
- wtf/Threading.h:
- wtf/ThreadingPrimitives.h:
- 9:03 AM Changeset in webkit [218068] by
-
- 5 edits in trunk/Source
REGRESSION (r217870): Null deref under PageOverlayController::uninstallPageOverlay using find in page
https://bugs.webkit.org/show_bug.cgi?id=173196
<rdar://problem/32686871>
Reviewed by Simon Fraser.
Source/WebCore:
- page/TextIndicator.cpp:
(WebCore::initializeIndicator):
- page/TextIndicator.h:
The change in r217870 had an expected but not thought-through side-effect
that you cannot create a TextIndicator for far-off-screen elements. This
is a problem for find-in-page, which uses TextIndicator to paint the yellow
highlight before scrolling it into view.
Bring back TextIndicatorOptionDoNotClipToVisibleRect and revert to it for
find in page, since it needs different behavior than something like
drag and drop, which always operates on content near the visible viewport.
Source/WebKit2:
- WebProcess/WebPage/ios/FindControllerIOS.mm:
(WebKit::FindController::updateFindIndicator):
The reason this caused a crash instead of just a missing indicator
is that FindControllerIOS would early return after uninstalling
the old overlay, before installing a new one, and leave m_isShowingFindIndicator
set to true. Instead, reset it (and m_findIndicatorOverlay, which
we would never re-use but might as well be freed immediately).
This likely already crashed in other less reproducible cases where a
TextIndicator was not created for a find match, so clean it up.
- 3:12 AM Changeset in webkit [218067] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, attempt to fix JSC tests on Win after r217771
- jsc.cpp:
(currentWorkingDirectory): buffer is not NULL-terminated
- 1:33 AM Changeset in webkit [218066] by
-
- 9 edits in trunk/Source
[WTF] Add RegisteredSymbolImpl
https://bugs.webkit.org/show_bug.cgi?id=173230
Reviewed by Mark Lam.
Source/JavaScriptCore:
- runtime/SymbolConstructor.cpp:
(JSC::symbolConstructorKeyFor):
Source/WTF:
Most symbols are not registered in SymbolRegistry. However, we currently always
allocate a pointer member to point to a SymbolRegistry, and this pointer is always null.
SymbolImpl is immutable, and it will never be registered with a SymbolRegistry
after it is created. Hence, this member is wasteful.
Instead, we add a new derived class RegisteredSymbolImpl, which will set a flag in
SymbolImpl to indicate that it is registered with a SymbolRegistry. The only way to
create a RegisteredSymbolImpl is via a factory method provided by the SymbolRegistry.
The factory method will pass the SymbolRegistry this pointer to the RegisteredSymbolImpl's
constructor for initializing the RegisteredSymbolImpl's m_symbolRegistry field.
By doing so,
- We do not need to set m_symbolRegistry after creating a Symbol. It is clean.
- We reduce the size of SymbolImpls that do not need to be registered.
- wtf/text/StringImpl.cpp:
(WTF::StringImpl::~StringImpl):
- wtf/text/StringImpl.h:
- wtf/text/SymbolImpl.cpp:
(WTF::SymbolImpl::create):
(WTF::RegisteredSymbolImpl::create):
- wtf/text/SymbolImpl.h:
(WTF::SymbolImpl::hashForSymbol):
(WTF::SymbolImpl::isRegistered):
(WTF::SymbolImpl::SymbolImpl):
(WTF::RegisteredSymbolImpl::symbolRegistry):
(WTF::RegisteredSymbolImpl::clearSymbolRegistry):
(WTF::RegisteredSymbolImpl::RegisteredSymbolImpl):
(WTF::SymbolImpl::symbolRegistry):
- wtf/text/SymbolRegistry.cpp:
(WTF::SymbolRegistry::~SymbolRegistry):
(WTF::SymbolRegistry::symbolForKey):
(WTF::SymbolRegistry::keyForSymbol):
(WTF::SymbolRegistry::remove):
- wtf/text/SymbolRegistry.h:
- 12:53 AM Changeset in webkit [218065] by
-
- 2 edits in trunk/JSTests
Unreviewed, update test results part 3
https://bugs.webkit.org/show_bug.cgi?id=173227
- microbenchmarks/regexp-prototype-search-observable-side-effects.js:
Jun 10, 2017:
- 11:30 PM Changeset in webkit [218064] by
-
- 8 edits6 deletes in trunk/Source/WebKit2
[GTK] Remove WKFullScreenClientGtk
https://bugs.webkit.org/show_bug.cgi?id=173140
Reviewed by Michael Catanzaro.
It's only used internally in the GTK+ API. Implementation is a lot simpler without using it, we can simply use
either WebKitWebView or WebKitWebViewBase from PageClient directly.
- PlatformGTK.cmake:
- UIProcess/API/C/gtk/WKFullScreenClientGtk.cpp: Removed.
- UIProcess/API/C/gtk/WKFullScreenClientGtk.h: Removed.
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::isFullScreen):
(WebKit::PageClientImpl::enterFullScreen):
(WebKit::PageClientImpl::exitFullScreen):
- UIProcess/API/gtk/WebKitFullscreenClient.cpp: Removed.
- UIProcess/API/gtk/WebKitFullscreenClient.h: Removed.
- UIProcess/API/gtk/WebKitPrivate.h:
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed):
(webkitWebViewEnterFullScreen):
(webkitWebViewExitFullScreen):
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseEnterFullScreen):
(webkitWebViewBaseExitFullScreen):
(webkitWebViewBaseIsFullScreen):
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
- UIProcess/API/gtk/WebKitWebViewPrivate.h:
- UIProcess/gtk/WebFullScreenClientGtk.cpp: Removed.
- UIProcess/gtk/WebFullScreenClientGtk.h: Removed.
- 11:28 PM Changeset in webkit [218063] by
-
- 6 edits in trunk/Source/WebKit2
[GTK] Handle page download request in WebKitWebView directly
https://bugs.webkit.org/show_bug.cgi?id=173137
Reviewed by Žan Doberšek.
We don't need to pass through WebKitWebViewBase, since the base doesn't have an implementation.
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::handleDownloadRequest):
- UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewConstructed):
(webkitWebViewHandleDownloadRequest):
- UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseSetDownloadRequestHandler): Deleted.
(webkitWebViewBaseHandleDownloadRequest): Deleted.
- UIProcess/API/gtk/WebKitWebViewBasePrivate.h:
- UIProcess/API/gtk/WebKitWebViewPrivate.h:
- 11:25 PM Changeset in webkit [218062] by
-
- 2 edits in trunk/Source/WebKit2
[GTK] Use a lambda in webkit_cookie_manager_get_accept_policy instead of toGenericCallbackFunction
https://bugs.webkit.org/show_bug.cgi?id=173134
Reviewed by Žan Doberšek.
It's simpler and easier to read.
- UIProcess/API/gtk/WebKitCookieManager.cpp:
(webkit_cookie_manager_get_accept_policy):
(webkitCookieManagerGetAcceptPolicyCallback): Deleted.
- 7:16 PM Changeset in webkit [218061] by
-
- 5 edits in trunk/LayoutTests
Rebaseline media/modern-media-controls/layout-node
https://bugs.webkit.org/show_bug.cgi?id=173203
Reviewed by Jon Lee.
The "visible" property no longer sets "display: initial" when true, but rather removes the "display" property altogether.
- media/modern-media-controls/layout-node/visible-expected.txt:
- media/modern-media-controls/layout-node/visible.html:
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 7:14 PM Changeset in webkit [218060] by
-
- 3 edits in trunk/LayoutTests
Enable media/modern-media-controls/layout-item
https://bugs.webkit.org/show_bug.cgi?id=173202
Reviewed by Jon Lee.
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 7:12 PM Changeset in webkit [218059] by
-
- 5 edits in trunk/LayoutTests
Rebaseline media/modern-media-controls/invalid-placard
https://bugs.webkit.org/show_bug.cgi?id=173201
Reviewed by Jon Lee.
The only required change was to update IconButton to Button since IconButton has been folded in its superclass Button.
- media/modern-media-controls/invalid-placard/invalid-placard-constrained-metrics-expected.txt:
- media/modern-media-controls/invalid-placard/invalid-placard-constrained-metrics.html:
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 7:10 PM Changeset in webkit [218058] by
-
- 5 edits in trunk/LayoutTests
Rebaseline media/modern-media-controls/icon-service
https://bugs.webkit.org/show_bug.cgi?id=173200
Reviewed by Jon Lee.
The method we were testing has changed name and the pause icon is no longer a good
test since it doesn't have a fullscreen variant, so we use the AirPlay icon instead.
- media/modern-media-controls/icon-service/icon-service-expected.txt:
- media/modern-media-controls/icon-service/icon-service.html:
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 6:37 PM Changeset in webkit [218057] by
-
- 31 edits in trunk
Reverted r218056 because it made the IDE reindex constantly.
PerformanceTests:
- MediaTime/Configurations/DebugRelease.xcconfig:
Source/bmalloc:
- Configurations/DebugRelease.xcconfig:
Source/JavaScriptCore:
- Configurations/DebugRelease.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/DebugRelease.xcconfig:
Source/ThirdParty/libwebrtc:
- Configurations/DebugRelease.xcconfig:
Source/WebCore:
- Configurations/DebugRelease.xcconfig:
Source/WebCore/PAL:
- Configurations/DebugRelease.xcconfig:
Source/WebInspectorUI:
- Configurations/DebugRelease.xcconfig:
Source/WebKit/mac:
- Configurations/DebugRelease.xcconfig:
Source/WebKit2:
- Configurations/DebugRelease.xcconfig:
Source/WTF:
- Configurations/DebugRelease.xcconfig:
Tools:
- ContentExtensionTester/Configurations/DebugRelease.xcconfig:
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- ImageDiff/cg/Configurations/DebugRelease.xcconfig:
- MiniBrowser/Configurations/DebugRelease.xcconfig:
- MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
- TestWebKitAPI/Configurations/DebugRelease.xcconfig:
- WebEditingTester/Configurations/DebugRelease.xcconfig:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- 1:32 PM Changeset in webkit [218056] by
-
- 31 edits in trunk
[Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
https://bugs.webkit.org/show_bug.cgi?id=173223
Reviewed by Sam Weinig.
The rebuilds were happening due to a difference in the compiler options that the IDE and
xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
xcodebuild pass that option, too, set CLANG_INDEX_STORE_ENABLE to YES if it is unset, and
specify an appropriate path in CLANG_INDEX_STORE_PATH.
PerformanceTests:
- MediaTime/Configurations/DebugRelease.xcconfig:
Source/bmalloc:
- Configurations/DebugRelease.xcconfig:
Source/JavaScriptCore:
- Configurations/DebugRelease.xcconfig:
Source/ThirdParty/ANGLE:
- Configurations/DebugRelease.xcconfig:
Source/ThirdParty/libwebrtc:
- Configurations/DebugRelease.xcconfig:
Source/WebCore:
- Configurations/DebugRelease.xcconfig:
Source/WebCore/PAL:
- Configurations/DebugRelease.xcconfig:
Source/WebInspectorUI:
- Configurations/DebugRelease.xcconfig:
Source/WebKit/mac:
- Configurations/DebugRelease.xcconfig:
Source/WebKit2:
- Configurations/DebugRelease.xcconfig:
Source/WTF:
- Configurations/DebugRelease.xcconfig:
Tools:
- ContentExtensionTester/Configurations/DebugRelease.xcconfig:
- DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
- ImageDiff/cg/Configurations/DebugRelease.xcconfig:
- MiniBrowser/Configurations/DebugRelease.xcconfig:
- MobileMiniBrowser/Configurations/DebugRelease.xcconfig:
- TestWebKitAPI/Configurations/DebugRelease.xcconfig:
- WebEditingTester/Configurations/DebugRelease.xcconfig:
- WebKitTestRunner/Configurations/DebugRelease.xcconfig:
- 12:51 PM Changeset in webkit [218055] by
-
- 6 edits in trunk/Tools
webkitpy: Reduce polling in ServerProcess
https://bugs.webkit.org/show_bug.cgi?id=173116
Reviewed by Ryosuke Niwa.
We should be smarter about polling. We do not need to poll every time a line is read from
stdout and stderr since lines are usually read from cached data. We should only poll
when extracting that cached data from stdout and stderr.
- Scripts/webkitpy/port/driver.py:
(Driver._read_block): Rely on output of the ServerProcess to detect a crash or a timeout
and on ServerProcess to poll the process if not data is available in stdout and stderr.
- Scripts/webkitpy/port/driver_unittest.py:
(DriverTest.test_read_block_crashed_process): Test that the Driver will handle a crashing
ServerProcess.
- Scripts/webkitpy/port/server_process.py:
(ServerProcess._read): Allow for data to be read from _output even if the process has
crashed. Only poll the process if data needs to be extracted from stdout or stderr.
- Scripts/webkitpy/port/server_process_mock.py:
(MockServerProcess): Add number_of_times_polled.
(MockServerProcess.poll): Increment number_of_times_polled.
(MockServerProcess.has_crashed): Poll before returning crash state.
(MockServerProcess.read_stdout_line): MockServerProcess should return None if it has crashed,
just like a ServerProcess would.
(MockServerProcess.read_stdout): Ditto.
- Scripts/webkitpy/port/server_process_unittest.py:
(TestServerProcess.test_basic): Use stdin.readline() instead of time.sleep() to prevent the
process from ending before stdout and stderr are read. This is the reason this test was flakey.
(TestServerProcess):
(TestServerProcess.test_process_crashing): Test that when a process crashes, data can be read until
the processes is polled.
(TestServerProcess.test_process_crashing_no_data): Test that when a process which has not output any
data to stdout and stderr crashes, ServerProcess._read(...) polls the process to detect the crash.
- 12:20 PM Changeset in webkit [218054] by
-
- 2 edits in trunk/JSTests
Unreviewed, update test results part 2
https://bugs.webkit.org/show_bug.cgi?id=173227
- test262.yaml:
- 11:35 AM Changeset in webkit [218053] by
-
- 3 edits in trunk/JSTests
Unreviewed, update test results
https://bugs.webkit.org/show_bug.cgi?id=173227
- microbenchmarks/string-prototype-search-observable-side-effects.js:
- test262.yaml:
- 11:33 AM Changeset in webkit [218052] by
-
- 2 edits in trunk/Source/WebCore
[macOS] REGRESSION: Link drag images blend into the background in Sierra and earlier
https://bugs.webkit.org/show_bug.cgi?id=172933
<rdar://problem/32580649>
Reviewed by Tim Horton.
- platform/mac/DragImageMac.mm:
(WebCore::createDragImageForLink): When targeting macOS Sierra and earlier, give the link
drag image a drop shadow that resembles the one that macOS High Sierra applies to drag
image layers.
- 11:01 AM Changeset in webkit [218051] by
-
- 4 edits in trunk
[JSC] Update RegExp.prototype.[@@search]] implementation according to the latest spec
https://bugs.webkit.org/show_bug.cgi?id=173227
Reviewed by Mark Lam.
JSTests:
Update the test.
- es6/Proxy_internal_get_calls_RegExp.prototype[Symbol.search].js:
Source/JavaScriptCore:
The latest spec introduces slight change to RegExp.prototype.[@@search].
This patch applies this change. Basically, this change is done in the slow path of
the RegExp.prototype[@@search].
https://tc39.github.io/ecma262/#sec-regexp.prototype-@@search
- builtins/RegExpPrototype.js:
(search):
- 12:25 AM Changeset in webkit [218050] by
-
- 4 edits in trunk
[QuickLook] PreviewLoader needs to check if its ResourceLoader has reached the terminal state before calling didReceiveResponse() and friends
https://bugs.webkit.org/show_bug.cgi?id=173190
<rdar://problem/31360659>
Reviewed by Brady Eidson.
Source/WebCore:
WebPreviewLoader's SubresourceLoader can reach a terminal state while data is loading from
QLPreviewConverter (the user can cancel, for instance). We can't call functions like
didReceiveResponse() in this state, because the loader no longer points to a CachedResource,
leading to null pointer dereferences.
Fix this in WebPreviewLoader by checking if the SubresourceLoader is in a terminal state
before calling didReceiveResponse(), didReceiveData(), didFinishLoading(), and didFail().
Fixes web process crashes in the QuickLook.CancelNavigationAfterResponse API test.
- loader/ios/PreviewLoader.mm:
(-[WebPreviewLoader _sendDidReceiveResponseIfNecessary]):
(-[WebPreviewLoader connection:didReceiveData:lengthReceived:]):
(-[WebPreviewLoader connectionDidFinishLoading:]):
(-[WebPreviewLoader connection:didFailWithError:]):
Tools:
Added a release assert that tries to create a proper test failure if the web process crashes.
- TestWebKitAPI/Tests/WebKit2Cocoa/QuickLook.mm:
(-[QuickLookDecidePolicyDelegate _webViewWebProcessDidCrash:]):
- 12:13 AM Changeset in webkit [218049] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION(r217749): Event listeners are removed even if they haven't been added
https://bugs.webkit.org/show_bug.cgi?id=173185
Reviewed by Joseph Pecoraro.
- UserInterface/Views/ResourceDetailsSidebarPanel.js:
(WebInspector.ResourceDetailsSidebarPanel):
(WebInspector.ResourceDetailsSidebarPanel.prototype.set resource):
(WebInspector.ResourceDetailsSidebarPanel.prototype._applyResourceEventListeners):
Maintain a member variable flag such that event listeners are only removed if it is true.
It is only set to true once the event listeners are added.
Jun 9, 2017:
- 10:24 PM Changeset in webkit [218048] by
-
- 13 edits in trunk/Source/WebCore
Use WTF::Function instead of std::function in indexeddb code
https://bugs.webkit.org/show_bug.cgi?id=173198
Reviewed by Sam Weinig.
Use WTF::Function instead of std::function in indexeddb code to avoid copying.
- Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::getAllDatabaseNames):
- Modules/indexeddb/IDBFactory.h:
- Modules/indexeddb/client/IDBConnectionProxy.cpp:
(WebCore::IDBClient::IDBConnectionProxy::getAllDatabaseNames):
- Modules/indexeddb/client/IDBConnectionProxy.h:
- Modules/indexeddb/client/IDBConnectionToServer.cpp:
(WebCore::IDBClient::IDBConnectionToServer::getAllDatabaseNames):
- Modules/indexeddb/client/IDBConnectionToServer.h:
- Modules/indexeddb/client/TransactionOperation.h:
(WebCore::IDBClient::TransactionOperation::doComplete):
- Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesModifiedSince):
(WebCore::IDBServer::IDBServer::closeAndDeleteDatabasesForOrigins):
- Modules/indexeddb/server/IDBServer.h:
- Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::storeCallbackOrFireError):
(WebCore::IDBServer::UniqueIDBDatabase::createObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::deleteObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::renameObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::clearObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::createIndex):
(WebCore::IDBServer::UniqueIDBDatabase::deleteIndex):
(WebCore::IDBServer::UniqueIDBDatabase::renameIndex):
(WebCore::IDBServer::UniqueIDBDatabase::putOrAdd):
(WebCore::IDBServer::UniqueIDBDatabase::getRecord):
(WebCore::IDBServer::UniqueIDBDatabase::getAllRecords):
(WebCore::IDBServer::UniqueIDBDatabase::getCount):
(WebCore::IDBServer::UniqueIDBDatabase::deleteRecord):
(WebCore::IDBServer::UniqueIDBDatabase::openCursor):
(WebCore::IDBServer::UniqueIDBDatabase::iterateCursor):
(WebCore::IDBServer::UniqueIDBDatabase::commitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::activateTransactionInBackingStore):
- Modules/indexeddb/server/UniqueIDBDatabase.h:
- 10:19 PM Changeset in webkit [218047] by
-
- 2 edits in trunk/Source/WebCore
Tried to fix the build when targrting macOS 10.12 using the macOS 10.13 developer beta SDK.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekableTimeRangesLastModifiedTime):
(WebCore::MediaPlayerPrivateAVFoundationObjC::liveUpdateInterval):
- 10:11 PM Changeset in webkit [218046] by
-
- 2 edits in trunk/Source/WebKit2
Crash inside WebKit::PluginView::getAuthenticationInfo
https://bugs.webkit.org/show_bug.cgi?id=173083
<rdar://problem/32513144>
Address Darin's review comment.
- WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::getAuthenticationInfo):
- 10:11 PM Changeset in webkit [218045] by
-
- 2 edits in trunk/Source/WebCore
[preload] Fix builds with ENABLE_VIDEO_TRACK set to false
https://bugs.webkit.org/show_bug.cgi?id=173221
Reviewed by Chris Dumez.
https://bugs.webkit.org/show_bug.cgi?id=173047 introduced a build error for builds with video track support disabled.
This fixes that build issue.
No new tests since there's no functional change.
- html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::as):
- 10:08 PM Changeset in webkit [218044] by
-
- 2 edits in trunk/Source/WebCore
IsInShadowTreeFlag does not get updated for a non-container node
https://bugs.webkit.org/show_bug.cgi?id=173084
Address Darin's review comment.
- dom/ContainerNodeAlgorithms.cpp:
(WebCore::notifyNodeInsertedIntoDocument):
(WebCore::notifyNodeInsertedIntoTree):
(WebCore::notifyNodeRemovedFromDocument):
- 9:38 PM Changeset in webkit [218043] by
-
- 2 edits in trunk/Source/WebCore
Fixed building with the macOS 10.13 Apple Internal SDK when targeting macOS 10.12.
- platform/spi/mac/AVFoundationSPI.h:
- 9:35 PM Changeset in webkit [218042] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: REGRESSION(r217258): Misspelled variable names
https://bugs.webkit.org/show_bug.cgi?id=173189
Reviewed by Joseph Pecoraro.
- UserInterface/Base/Main.js:
(WebInspector.tabContentViewClassForRepresentedObject):
- UserInterface/Views/ResourceIcons.css:
(.large :matches(.resource-icon.resource-type-stylesheet, .stylesheet-icon) .icon):
(.large .resource-icon.resource-type-stylesheet .icon): Deleted.
- 9:32 PM Changeset in webkit [218041] by
-
- 5 edits3 adds in trunk
Crash when IndexedDB's getAll is used inside a Web Worker.
https://bugs.webkit.org/show_bug.cgi?id=172434
Reviewed by Andy Estes.
Source/WebCore:
Test: storage/indexeddb/modern/worker-getall.html
- Modules/indexeddb/IDBGetAllResult.cpp:
(WebCore::IDBGetAllResult::IDBGetAllResult): Add an isolated-copying constructor.
(WebCore::IDBGetAllResult::isolatedCopy):
- Modules/indexeddb/IDBGetAllResult.h:
- Modules/indexeddb/shared/IDBResultData.cpp:
(WebCore::IDBResultData::isolatedCopy): Actually copy the IDBGetAllResult.
LayoutTests:
- storage/indexeddb/modern/resources/worker-getall.js: Added.
- storage/indexeddb/modern/worker-getall-expected.txt: Added.
- storage/indexeddb/modern/worker-getall.html: Added.
- 9:30 PM Changeset in webkit [218040] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed attempt to fix Mac build after r218039.
- loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::loadDataURL):
- platform/network/DataURLDecoder.h:
- 9:07 PM Changeset in webkit [218039] by
-
- 3 edits in trunk/Source/WebCore
Use WTF::Function instead of std::function in DataURLDecoder
https://bugs.webkit.org/show_bug.cgi?id=173194
Reviewed by Sam Weinig.
Use WTF::Function instead of std::function in DataURLDecoder to avoid copying.
- platform/network/DataURLDecoder.cpp:
(WebCore::DataURLDecoder::DecodeTask::DecodeTask):
(WebCore::DataURLDecoder::createDecodeTask):
- platform/network/DataURLDecoder.h:
- 7:51 PM Changeset in webkit [218038] by
-
- 3 edits in trunk/Source/WebCore
Image should clear its ImageObserver* when CachedImage releases the last reference to its RefCounted<ImageObserver>
https://bugs.webkit.org/show_bug.cgi?id=173077
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-06-09
Reviewed by Simon Fraser.
Before dereferencing ImageObserver, CachedImage::clearImage() should check
whether it is the only object that holds a reference to this ImageObserver.
And if this is true, m_image have to clear its raw pointer to the deleted
ImageObserver by calling m_image->setImageObserver(nullptr).
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::setBodyDataFrom):
(WebCore::CachedImage::CachedImageObserver::CachedImageObserver):
(WebCore::CachedImage::clearImage):
- loader/cache/CachedImage.h:
- 7:11 PM Changeset in webkit [218037] by
-
- 2 edits in trunk/Source/WebCore
Attempt to fix layout test failures following <https://trac.webkit.org/changeset/218028/webkit>
(https://bugs.webkit.org/show_bug.cgi?id=158121)
<rdar://problem/26012994>
For now, if we do not have a frame then consider the document a secure context. One way this can happen
is the page accesses a frame that was removed from the document as demonstrated by the test:
fast/dom/Window/property-access-on-cached-window-after-frame-removed.html. Treating a frameless
document as a secure context also matches Blink's implementation:
<https://chromium.googlesource.com/chromium/src/+/fc202b2b1174f5732f7b9e63a6c46fd01ac2be02/third_party/WebKit/Source/core/dom/Document.cpp#4079>.
- dom/Document.cpp:
(WebCore::Document::isSecureContext):
- 6:14 PM Changeset in webkit [218036] by
-
- 1 copy in tags/Safari-604.1.25.1
Tag Safari-604.1.25.1.
- 6:14 PM Changeset in webkit [218035] by
-
- 1 delete in tags/Safari-604.1.25.1
Remove tag.
- 6:12 PM Changeset in webkit [218034] by
-
- 1 copy in tags/Safari-604.1.25.1/safari-604.1.25-branch
Tag Safari-604.1.25.1.
- 6:07 PM Changeset in webkit [218033] by
-
- 1 copy in tags/Safari-604.1.25.1
Tag Safari-604.1.25.1.
- 5:56 PM Changeset in webkit [218032] by
-
- 36 edits13 deletes in tags/Safari-604.1.25
Cherry-pick r218009. rdar://problem/32677465
- 5:37 PM Changeset in webkit [218031] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, rolling out r218003.
This change caused assertion failures in existing LayoutTests.
Reverted changeset:
"Image should clear its ImageObserver* when CachedImage
releases the last reference to its RefCounted<ImageObserver>"
https://bugs.webkit.org/show_bug.cgi?id=173077
http://trac.webkit.org/changeset/218003
- 5:08 PM Changeset in webkit [218030] by
-
- 6 edits in trunk/Source/WebCore
[WebCrypto] Remove unsupported CryptoAlgorithmIdentifier
https://bugs.webkit.org/show_bug.cgi?id=173128
<rdar://problem/32666826>
Reviewed by Brent Fulgham.
This patch remove AES_CMAC, DH and CONCAT as they are not implemented and not recommended
by the spec. Hence there is no plan to support them in short term.
No change of behaviour.
- bindings/js/JSCryptoAlgorithmDictionary.cpp:
(WebCore::JSCryptoAlgorithmDictionary::createParametersForEncrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDecrypt):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForSign):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForVerify):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDigest):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForGenerateKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForDeriveBits):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForImportKey):
(WebCore::JSCryptoAlgorithmDictionary::createParametersForExportKey):
- bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::normalizeCryptoAlgorithmParameters):
(WebCore::supportExportKeyThrow):
- bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::write):
(WebCore::CloneDeserializer::read):
- crypto/CryptoAlgorithmIdentifier.h:
- crypto/keys/CryptoKeyAES.cpp:
(WebCore::CryptoKeyAES::isValidAESAlgorithm):
- 5:00 PM Changeset in webkit [218029] by
-
- 2 edits in trunk/LayoutTests
Mark fast/mediastream/getUserMedia-grant-persistency3.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=173188
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 4:56 PM Changeset in webkit [218028] by
-
- 12 edits in trunk/Source/WebCore
Implement W3C Secure Contexts Draft Specification
https://bugs.webkit.org/show_bug.cgi?id=158121
<rdar://problem/26012994>
Reviewed by Alex Christensen.
Part 2
Implements the Secure Contexts spec., <https://w3c.github.io/webappsec-secure-contexts/> (Editor's
Draft, 17 November 2016) except for the allow-secure-context sandbox flag and restrictions on window.opener
as the former is at risk of being dropped from the specification and the latter is being discussed in
<https://github.com/w3c/webappsec-secure-contexts/issues/42>. We are not making use of the Secure
Contexts functionality at the moment. We will make use of it in a subsequent commit.
- dom/Document.cpp:
(WebCore::Document::isSecureContext): Added,
- dom/Document.h:
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::isSecureContext): Deleted; moved to class SecurityContext.
- dom/SecurityContext.h:
- page/DOMWindow.cpp:
(WebCore::DOMWindow::isSecureContext): Added.
- page/DOMWindow.h:
- page/SecurityOrigin.cpp:
(WebCore::isLoopbackIPAddress): Convenience function to determine whether the host portion
of the specified URL is a valid loopback address.
(WebCore::shouldTreatAsPotentionallyTrustworthy): Implements the "Is origin potentially trustworthy?"
algorithm from the Secure Context specification.
(WebCore::SecurityOrigin::SecurityOrigin): Compute whether this origin is potentially trustworthy.
Also, use C++ brace initialization syntax in member initialization list.
- page/SecurityOrigin.h:
(WebCore::SecurityOrigin::isPotentionallyTrustworthy): Added.
- page/WindowOrWorkerGlobalScope.idl: Expose attribute isSecureContext. Fix style nit; remove
period from a comment that is not meant to be a complete sentence.
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::isSecureContext): Added.
- workers/WorkerGlobalScope.h:
- 4:38 PM Changeset in webkit [218027] by
-
- 13 edits in trunk/Source/WebCore
Implement W3C Secure Contexts Draft Specification
https://bugs.webkit.org/show_bug.cgi?id=158121
<rdar://problem/26012994>
Reviewed by Chris Dumez.
Part 1
Teach the bindings code generator to generate a runtime check for an interface, attribute or
function annotated with the extended attribute [SecureContext]. For now, the runtime check
(ScriptExecutionContext::isSecureContext()) always returns true. We will flesh out the
implementation of this runtime check in a subsequent commit.
- bindings/scripts/CodeGeneratorJS.pm:
(NeedsRuntimeCheck):
(GenerateRuntimeEnableConditionalString):
Generate a runtime check for an interface, attribute, or function that is annotated with
the extended attribute [SecureContext].
- bindings/scripts/IDLAttributes.json: Update JSON now that we support SecureContext.
- bindings/scripts/preprocess-idls.pl:
(GenerateConstructorAttributes): Add the SecureContext extended attribute to a constructor,
if applicable.
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::JSTestGenerateIsReachablePrototype::finishCreation):
(WebCore::IDLAttribute<JSTestGenerateIsReachable>::cast):
(WebCore::jsTestGenerateIsReachableASecretAttributeGetter):
(WebCore::jsTestGenerateIsReachableASecretAttribute):
- bindings/scripts/test/JS/JSTestGlobalObject.cpp:
(WebCore::JSTestGlobalObject::finishCreation):
(WebCore::jsTestGlobalObjectInstanceFunctionCalculateSecretResultBody):
(WebCore::jsTestGlobalObjectInstanceFunctionCalculateSecretResult):
(WebCore::jsTestGlobalObjectInstanceFunctionGetSecretBooleanBody):
(WebCore::jsTestGlobalObjectInstanceFunctionGetSecretBoolean):
(WebCore::jsTestGlobalObjectInstanceFunctionTestFeatureGetSecretBooleanBody):
(WebCore::jsTestGlobalObjectInstanceFunctionTestFeatureGetSecretBoolean):
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodePrototype::finishCreation):
(WebCore::jsTestNodePrototypeFunctionCalculateSecretResultBody):
(WebCore::jsTestNodePrototypeFunctionCalculateSecretResult):
(WebCore::jsTestNodePrototypeFunctionGetSecretBooleanBody):
(WebCore::jsTestNodePrototypeFunctionGetSecretBoolean):
(WebCore::jsTestNodePrototypeFunctionTestFeatureGetSecretBooleanBody):
(WebCore::jsTestNodePrototypeFunctionTestFeatureGetSecretBoolean):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjPrototype::finishCreation):
(WebCore::jsTestObjPrototypeFunctionCalculateSecretResultBody):
(WebCore::jsTestObjPrototypeFunctionCalculateSecretResult):
(WebCore::jsTestObjPrototypeFunctionGetSecretBooleanBody):
(WebCore::jsTestObjPrototypeFunctionGetSecretBoolean):
(WebCore::jsTestObjPrototypeFunctionTestFeatureGetSecretBooleanBody):
(WebCore::jsTestObjPrototypeFunctionTestFeatureGetSecretBoolean):
Update expected results.
- bindings/scripts/test/TestGenerateIsReachable.idl:
- bindings/scripts/test/TestGlobalObject.idl:
- bindings/scripts/test/TestNode.idl:
- bindings/scripts/test/TestObj.idl:
Add test cases.
- dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::isSecureContext): Added. For now, always returns true.
We will implement this function in a subsequent commit.
- 4:13 PM Changeset in webkit [218026] by
-
- 2 edits in trunk/LayoutTests
CSP: Apply img-src directive to favicon loads
https://bugs.webkit.org/show_bug.cgi?id=172733
Remove CONSOLE MESSAGE line from expected result that I inadvertently left in from an earlier iteration
of the test that did not call testRunner.queueReload(). Calling testRunner.queueReload() clears out
any emitted console messages. The dump of the resource load callbacks is sufficient to ensure that
the favicon was blocked as expected.
- http/tests/security/contentSecurityPolicy/block-favicon-expected.txt:
- 3:45 PM Changeset in webkit [218025] by
-
- 4 edits in trunk/LayoutTests
REGRESSION: LayoutTest js/intl-datetimeformat.html is failing
https://bugs.webkit.org/show_bug.cgi?id=172720
Patch by Andy VanWagoner <thetalecrafter@gmail.com> on 2017-06-09
Reviewed by Darin Adler.
Reenable DateTimeFormat tests, allowing for some variation in the
formatting of time zone names.
- js/intl-datetimeformat-expected.txt:
- js/script-tests/intl-datetimeformat.js:
- platform/mac/TestExpectations:
- 3:38 PM Changeset in webkit [218024] by
-
- 9 edits in trunk/Source/WebKit2
Use WTF::Function instead of std::function in NetworkProcess code
https://bugs.webkit.org/show_bug.cgi?id=173182
Reviewed by Alex Christensen.
Use WTF::Function instead of std::function in NetworkProcess code to avoid
unnecessary copying.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/cache/NetworkCacheIOChannel.h:
- NetworkProcess/cache/NetworkCacheIOChannelCocoa.mm:
(WebKit::NetworkCache::IOChannel::read):
(WebKit::NetworkCache::IOChannel::write):
- NetworkProcess/cache/NetworkCacheIOChannelSoup.cpp:
(WebKit::NetworkCache::IOChannel::read):
(WebKit::NetworkCache::IOChannel::readSyncInThread):
(WebKit::NetworkCache::IOChannel::write):
- NetworkProcess/cache/NetworkCacheSpeculativeLoad.h:
- NetworkProcess/cache/NetworkCacheStatistics.h:
- NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::clearNSURLCache):
(WebKit::NetworkProcess::clearDiskCache):
- NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::clearDiskCache):
- 3:35 PM Changeset in webkit [218023] by
-
- 3 edits in trunk/Source/WebKit2
REGRESSION (r213584): WeChat app can not switch to next text field
https://bugs.webkit.org/show_bug.cgi?id=173183
<rdar://problem/32323478>
Reviewed by Wenson Hsieh.
- Platform/spi/ios/UIKitSPI.h:
- UIProcess/ios/InputViewUpdateDeferrer.mm:
(WebKit::InputViewUpdateDeferrer::~InputViewUpdateDeferrer):
It turns out that _endIgnoringReloadInputViews doesn't actually perform
the update if there was one ignored. It does, however, return whether
there was a change ignored, and we can force an update.
This remains untestable without sizable additional API test infrastructure
for the same reasons as the original patch.
- 3:16 PM Changeset in webkit [218022] by
-
- 2 edits in trunk/Source/WebKit2
Make sure we protect |this| in lambdas in WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver()
https://bugs.webkit.org/show_bug.cgi?id=173174
<rdar://problem/32598919>
Reviewed by Darin Adler.
Follow-up fix to r218006, which caused a crash on the bots. We cannot WTFMove() protectedThis
here because the callback gets called several times.
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver):
- 3:09 PM Changeset in webkit [218021] by
-
- 2 edits in trunk/Source/WebKit2
Crash in -[WKWebView _initializeWithConfiguration:]
https://bugs.webkit.org/show_bug.cgi?id=173126
<rdar://problem/32664993>
Reviewed by Darin Adler.
Follow up to previous fix; when setting NSString properties, store a copy of
the string rather than the NSString itself.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration copyWithZone:]):
(-[WKWebViewConfiguration _overrideContentSecurityPolicy]):
(-[WKWebViewConfiguration _setOverrideContentSecurityPolicy:]):
(-[WKWebViewConfiguration _setMediaContentTypesRequiringHardwareSupport:]):
- 2:59 PM Changeset in webkit [218020] by
-
- 3 edits2 adds in trunk
Web Inspector: Web inspector does not show non-shadow children of an element with a shadow root (e.g. <video>)
https://bugs.webkit.org/show_bug.cgi?id=173121
<rdar://problem/30948943>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-06-09
Reviewed by Matt Baker.
Source/WebInspectorUI:
- UserInterface/Models/DOMNode.js:
(WebInspector.DOMNode):
Only populate _children when we have both the shadowRoots and
actual children payloads. Backends always send shadowRoots but
only send children when requested. So if we have shadowRoots
but expect actual children, don't populate _children until we
request the child nodes.
LayoutTests:
- inspector/dom/shadow-and-non-shadow-children-expected.txt: Added.
- inspector/dom/shadow-and-non-shadow-children.html: Added.
- 2:53 PM Changeset in webkit [218019] by
-
- 3 edits in trunk/LayoutTests
LayoutTest fast/images/animated-image-different-dest-size.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=170203
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-06-09
Reviewed by Simon Fraser.
Instead of using setTimeout(), listen to the webkitImageFrameReady event
to know relaibly when to draw the next frame of an animated image to a
canvas.
- fast/images/animated-image-different-dest-size.html:
- platform/mac-wk2/TestExpectations:
- 2:25 PM Changeset in webkit [218018] by
-
- 2 edits in trunk/LayoutTests
Skipped layout test svg/animations/svglength-element-removed-crash.svg.
https://bugs.webkit.org/show_bug.cgi?id=173178
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 2:09 PM Changeset in webkit [218017] by
-
- 3 edits in trunk/Source/WebKit2
Use WTF::Function instead of std::function in StorageManager
https://bugs.webkit.org/show_bug.cgi?id=173177
Reviewed by Brady Eidson.
Use WTF::Function instead of std::function in StorageManager. This eliminates some
potential implicit copying of captured variables, which is important here because
we pass those lambdas to other threads.
- UIProcess/Storage/StorageManager.cpp:
(WebKit::StorageManager::getSessionStorageOrigins):
(WebKit::StorageManager::deleteSessionStorageOrigins):
(WebKit::StorageManager::deleteSessionStorageEntriesForOrigins):
(WebKit::StorageManager::getLocalStorageOrigins):
(WebKit::StorageManager::getLocalStorageOriginDetails):
(WebKit::StorageManager::deleteLocalStorageOriginsModifiedSince):
(WebKit::StorageManager::deleteLocalStorageEntriesForOrigins):
- UIProcess/Storage/StorageManager.h:
- 1:55 PM Changeset in webkit [218016] by
-
- 8 edits in trunk/Source/WebCore
Media elements are allowed to continue to load media data after navigation
https://bugs.webkit.org/show_bug.cgi?id=173179
Reviewed by Eric Carlson.
Deny media sessions the ability to load media data when suspended.
- Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::isSuspended):
- Modules/webaudio/AudioContext.h:
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::isSuspended):
- html/HTMLMediaElement.h:
- platform/audio/PlatformMediaSession.cpp:
(WebCore::PlatformMediaSession::isSuspended):
- platform/audio/PlatformMediaSession.h:
(WebCore::PlatformMediaSessionClient::isSuspended):
- platform/audio/PlatformMediaSessionManager.cpp:
(WebCore::PlatformMediaSessionManager::sessionCanLoadMedia):
- 1:45 PM Changeset in webkit [218015] by
-
- 16 edits4 adds in trunk
CSP: Apply img-src directive to favicon loads
https://bugs.webkit.org/show_bug.cgi?id=172733
<rdar://problem/32082654>
Reviewed by Brady Eidson.
Source/WebCore:
Differentiate favicon requests from raw resources requests so that we can apply the Content
Security Policy to favicon requests.
Tests: http/tests/security/contentSecurityPolicy/allow-favicon.html
http/tests/security/contentSecurityPolicy/block-favicon.html
- inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::cachedResourceContent): Keep our current behavior and treat a
favicon resource analogous to a raw resource.
(WebCore::InspectorPageAgent::cachedResourceType): Ditto.
- loader/LinkLoader.cpp:
(WebCore::createLinkPreloadResourceClient): Now that we differentiate between a favicon
and a raw resource we add favicons to the list of unsupported <link as="..."> types. This
makes the list of handled request destination types more closely match the list of valid types
documented in <https://fetch.spec.whatwg.org/#concept-request-destination> (24 May 2017).
- loader/ResourceLoadInfo.cpp:
(WebCore::toResourceType): Keep our current behavior and treat a favicon resource analogous
to a raw resource.
- loader/SubresourceLoader.cpp:
(WebCore::logResourceLoaded): Ditto.
- loader/cache/CachedRawResource.cpp:
(WebCore::CachedRawResource::CachedRawResource): Update for renaming.
- loader/cache/CachedRawResource.h:
(isType): Ditto.
- loader/cache/CachedResource.cpp:
(WebCore::CachedResource::defaultPriorityForResourceType): Keep our current behavior and treat
a favicon resource analogous to a raw resource.
- loader/cache/CachedResource.h:
(WebCore::CachedResource::isMainOrMediaOrFaviconOrRawResource): Renamed; formerly named isMainOrMediaOrRawResource.
Also return true if the this resource is a favicon.
(WebCore::CachedResource::ignoreForRequestCount): Keep our current behavior and treat a
favicon resource analogous to a raw resource.
(WebCore::CachedResource::isMainOrMediaOrRawResource): Deleted; renamed to isMainOrMediaOrFaviconOrRawResource.
- loader/cache/CachedResourceLoader.cpp:
(WebCore::createResource): Keep our current behavior and treat a favicon resource analogous
to a raw resource.
(WebCore::CachedResourceLoader::requestFavicon): Added.
(WebCore::contentTypeFromResourceType): Keep our current behavior and treat a favicon
resource analogous to a raw resource.
(WebCore::CachedResourceLoader::checkInsecureContent): Ditto.
(WebCore::CachedResourceLoader::allowedByContentSecurityPolicy): Check if the favicon is
allowed by the CSP of the page.
(WebCore::CachedResourceLoader::determineRevalidationPolicy): Update for renaming.
- loader/cache/CachedResourceLoader.h:
- loader/icon/IconLoader.cpp:
(WebCore::IconLoader::startLoading): Substitute call CachedResourceLoader::requestFavicon() for CachedResourceLoader::requestRawResource()
and remove comment about ContentSecurityPolicyImposition::DoPolicyCheck being a placeholder. This is no longer the
case. This resource request option is now meaningful as we want to apply the CSP of the page with respect to the
request for the favicon.
Source/WebKit2:
Return 0 seconds for the maximum buffering time for favicons (no change in behavior).
- WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::maximumBufferingTime):
LayoutTests:
Adds tests to ensure the CSP policy is applied to favicon loads.
- http/tests/security/contentSecurityPolicy/allow-favicon-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/allow-favicon.html: Added.
- http/tests/security/contentSecurityPolicy/block-favicon-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/block-favicon.html: Added.
- platform/wk2/TestExpectations: Skip the tests until we fix <https://bugs.webkit.org/show_bug.cgi?id=115809>.
- 1:10 PM Changeset in webkit [218014] by
-
- 25 edits in trunk
[iOS DnD] Add a hook to perform two-step drops in editable content
https://bugs.webkit.org/show_bug.cgi?id=172992
<rdar://problem/32590174>
Reviewed by Tim Horton.
Source/WebCore:
Adds hooks in DragController::concludeEditDrag to give the client layer a chance to perform custom handling when
dropping in editable content.
Tests: DataInteractionTests.InjectedBundleOverridePerformTwoStepDrop
DataInteractionTests.InjectedBundleAllowPerformTwoStepDrop
- loader/EmptyClients.cpp:
- page/DragController.cpp:
(WebCore::DragController::concludeEditDrag):
- page/EditorClient.h:
Source/WebKit/ios:
Add an empty implementation of performTwoStepDrop for WebDefaultUIKitDelegate. See WebCore ChangeLogs.
- DefaultDelegates/WebDefaultUIKitDelegate.m:
(-[WebDefaultUIKitDelegate performTwoStepDrop:atDestination:isMove:]):
- WebView/WebUIKitDelegate.h:
Source/WebKit/mac:
Adds a new SPI to WebUIKitDelegate to allow WK1 clients to override default drop behavior. Returning YES from
-performTwoStepDrop:atDestination:isMove: will prevent content from being inserted on drop in WebKit; otherwise,
returning NO will continue with default WebKit behavior.
- WebCoreSupport/WebEditorClient.h:
- WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::performTwoStepDrop):
Source/WebKit/win:
Add a stub implementation for performTwoStepDrop on Windows.
- WebCoreSupport/WebEditorClient.h:
Source/WebKit2:
Add plumbing to support an injected bundle hook for overriding two-step drops. See WebCore ChangeLog.
- WebProcess/InjectedBundle/API/APIInjectedBundleEditorClient.h:
(API::InjectedBundle::EditorClient::performTwoStepDrop):
- WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInEditingDelegate.h:
- WebProcess/InjectedBundle/API/c/WKBundlePageEditorClient.h:
- WebProcess/InjectedBundle/API/mac/WKWebProcessPlugInBrowserContextController.mm:
(-[WKWebProcessPlugInBrowserContextController _setEditingDelegate:]):
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
(WebKit::InjectedBundlePageEditorClient::performTwoStepDrop):
- WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
- WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::performTwoStepDrop):
- WebProcess/WebCoreSupport/WebEditorClient.h:
Tools:
Adds 2 new API tests to cover using the injected editing bundle to override performTwoStepDrop.
Tests: DataInteractionTests.InjectedBundleOverridePerformTwoStepDrop
DataInteractionTests.InjectedBundleAllowPerformTwoStepDrop
- TestWebKitAPI/Tests/WebKit2Cocoa/BundleEditingDelegatePlugIn.mm:
(-[BundleEditingDelegatePlugIn webProcessPlugIn:didCreateBrowserContextController:]):
(-[BundleEditingDelegatePlugIn _webProcessPlugInBrowserContextController:performTwoStepDrop:atDestination:isMove:]):
Allow the BundleOverridePerformTwoStepDrop bundle parameter to determine whether or not two-step drops should
be overridden. Currently, this is overridden to just return true.
- TestWebKitAPI/Tests/ios/DataInteractionTests.mm:
(TestWebKitAPI::TEST):
- WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
- 12:47 PM Changeset in webkit [218013] by
-
- 1 edit1 add in trunk/LayoutTests
Add a result file for js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5-short.html.
https://bugs.webkit.org/show_bug.cgi?id=161156
Unreviewed test gardening.
- js/dom/prototype-chain-caching-with-impure-get-own-property-slot-traps-5-short-expected.txt: Added.
- 12:41 PM Changeset in webkit [218012] by
-
- 5 edits in trunk/Source
Update Thread::create() to take in a WTF::Function instead of a std::function
https://bugs.webkit.org/show_bug.cgi?id=173175
Reviewed by Mark Lam.
Source/JavaScriptCore:
- API/tests/CompareAndSwapTest.cpp:
(testCompareAndSwap):
Source/WTF:
Update Thread::create() to take in a WTF::Function instead of a std::function. Unlike
std::function, WTF:Function is not copyable and does not make implicit copies of captured
variables. Doing captures such as [string = string.isolatedCopy()] when passing an
std::function to another thread has lead to bugs in the past due to implicit copying of
the captured string.
- wtf/Threading.cpp:
(WTF::Thread::create):
- wtf/Threading.h:
- 12:40 PM Changeset in webkit [218011] by
-
- 7 edits in trunk/Source/WebKit2
Use Function rather than std::function for thread safety in WebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=173172
Reviewed by Chris Dumez.
<rdar://problem/32679311>
Remove a few more instances of std::function in the WebsiteDataStore, and WTFMove completion handler to
avoid unnecessary copies.
- Shared/WebsiteData/WebsiteDataType.h: Remove redundant WebsiteDataType from name.
- UIProcess/API/Cocoa/WKWebsiteDataRecordInternal.h:
(WebKit::toWebsiteDataType): Update for revised name.
(WebKit::toWKWebsiteDataTypes): Ditto.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::deleteWebsiteDataForTopPrivatelyControlledDomainsInAllPersistentDataStores): ASSERT that
this function, as well as its completion handler, are getting called from the main thread.
(WebKit::WebProcessProxy::topPrivatelyControlledDomainsWithWebiteData): Ditto.
(WebKit::WebProcessProxy::fetchWebsiteData): Move the completionHandler.
(WebKit::WebProcessProxy::deleteWebsiteData): Ditto.
(WebKit::WebProcessProxy::deleteWebsiteDataForOrigins): Ditto.
- UIProcess/WebProcessProxy.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchData): Switch to Function, and move completion handler.
(WebKit::WebsiteDataStore::fetchDataForTopPrivatelyControlledDomains): Ditto.
(WebKit::WebsiteDataStore::topPrivatelyControlledDomainsWithWebsiteData): Ditto.
(WebKit::WebsiteDataStore::removeData): Ditto.
(WebKit::WebsiteDataStore::removeDataForTopPrivatelyControlledDomains): Ditto.
- UIProcess/WebsiteData/WebsiteDataStore.h:
- 12:00 PM Changeset in webkit [218010] by
-
- 36 edits13 deletes in branches/safari-604.1.25-branch
Cherry-pick r218009. rdar://problem/32677465
- 11:56 AM Changeset in webkit [218009] by
-
- 36 edits13 deletes in trunk
Revert r217955. rdar://problem/21125708
- 11:56 AM Changeset in webkit [218008] by
-
- 7 edits in trunk/Source
Versioning.
- 11:55 AM Changeset in webkit [218007] by
-
- 3 edits in trunk/Source/JavaScriptCore
[DFG] Add verboseDFGOSRExit
https://bugs.webkit.org/show_bug.cgi?id=173156
Reviewed by Saam Barati.
This patch adds verboseDFGOSRExit which is similar to verboseFTLOSRExit.
- dfg/DFGOSRExitCompiler.cpp:
- runtime/Options.h:
- 11:52 AM Changeset in webkit [218006] by
-
- 2 edits in trunk/Source/WebKit2
Make sure we protect |this| in lambdas in WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver()
https://bugs.webkit.org/show_bug.cgi?id=173174
<rdar://problem/32598919>
Reviewed by Darin Adler.
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::registerSharedResourceLoadObserver):
- 11:46 AM Changeset in webkit [218005] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC][MIPS] Add MacroAssemblerMIPS::xor32(Address, RegisterID) implementation
https://bugs.webkit.org/show_bug.cgi?id=173170
Patch by Guillaume Emont <guijemont@igalia.com> on 2017-06-09
Reviewed by Yusuke Suzuki.
MIPS does not build since r217711 because it is missing this
implementation. This patch fixes the build.
- assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::xor32):
- 11:42 AM Changeset in webkit [218004] by
-
- 3 edits in trunk/Source/WebCore
[MediaFoundation] Volume controls of different media elements should be independent
https://bugs.webkit.org/show_bug.cgi?id=172967
Based on patch by Vitaly Slobodin <vitaliy.slobodin@gmail.com>
Reviewed by Alex Christensen.
IMFSimpleAudioVolume interface controls master volume of the
application. We should use IMFAudioStreamVolume interface instead.
No new tests needed.
- platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
(WebCore::MediaPlayerPrivateMediaFoundation::MediaPlayerPrivateMediaFoundation):
(WebCore::MediaPlayerPrivateMediaFoundation::setAllChannelVolumes):
(WebCore::MediaPlayerPrivateMediaFoundation::setVolume):
(WebCore::MediaPlayerPrivateMediaFoundation::setMuted):
- platform/graphics/win/MediaPlayerPrivateMediaFoundation.h:
- 11:38 AM Changeset in webkit [218003] by
-
- 3 edits in trunk/Source/WebCore
Image should clear its ImageObserver* when CachedImage releases the last reference to its RefCounted<ImageObserver>
https://bugs.webkit.org/show_bug.cgi?id=173077
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-06-09
Reviewed by Simon Fraser.
Before dereferencing ImageObserver, CachedImage::clearImage() should check
whether it is the only object that holds a reference to this ImageObserver.
And if this is true, m_image have to clear its raw pointer to the deleted
ImageObserver by calling m_image->setImageObserver(nullptr).
- loader/cache/CachedImage.cpp:
(WebCore::CachedImage::setBodyDataFrom):
(WebCore::CachedImage::CachedImageObserver::CachedImageObserver):
(WebCore::CachedImage::clearImage):
- loader/cache/CachedImage.h:
- 11:32 AM Changeset in webkit [218002] by
-
- 4 edits in trunk/Source/WebKit2
Avoid some ref counting churn in WebResourceLoadStatisticsStore
https://bugs.webkit.org/show_bug.cgi?id=173168
Reviewed by Brent Fulgham.
Move the protectedThis around instead of ref'ing it every time we capture it
in a lambda. Also add a missing protectedThis in WebResourceLoadStatisticsStore::removeDataRecords()
which likely fixes crashes.
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::removeDataRecords):
(WebKit::WebResourceLoadStatisticsStore::grandfatherExistingWebsiteData):
- 11:28 AM Changeset in webkit [218001] by
-
- 2 edits in trunk/LayoutTests
[ios-sim] Cleaning-up timeouts WebKit1
https://bugs.webkit.org/show_bug.cgi?id=173169
Unreviewed test gardening.
The intention of this change is to allow the iOS WK1 bots to finish their
test runs. Because these tests are being gardened based on the output of
bots, there will likely be follow-up fixes.
- platform/ios-wk1/TestExpectations: Skip tests timing out in iOS WK1.
- 10:59 AM Changeset in webkit [218000] by
-
- 8 edits in trunk
Add flag allow-popups-to-escape-sandbox to iframe sandbox
https://bugs.webkit.org/show_bug.cgi?id=158875
Patch by Frederic Wang <fwang@igalia.com> on 2017-06-09
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
Update expected results for iframe popup escaping tests.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1-expected.txt: This test passes.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2-expected.txt: This test passes.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-3-expected.txt: Remove error message from text expectation.
Source/WebCore:
This patch adds support for the iframe@allow-popups-to-escape-sandbox attribute.
This allows to pass more W3C Web Platform tests.
Tests: imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-1.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_popups_escaping-2.html
- dom/SecurityContext.cpp: Add allow-popups-to-escape-sandbox flag.
(WebCore::SecurityContext::isSupportedSandboxPolicy):
(WebCore::SecurityContext::parseSandboxPolicy):
- dom/SecurityContext.h: Ditto.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy): Do not force sandbox flags when we have allow-popups-to-escape-sandbox.
(WebCore::createWindow): Ditto.
- 10:57 AM Changeset in webkit [217999] by
-
- 14 edits2 adds in trunk
[iOS] Video occasionally mixes with other system audio instead of interrupting
https://bugs.webkit.org/show_bug.cgi?id=173127
Reviewed by Eric Carlson.
Source/WebCore:
Tests: platform/mac/audio-session-category-video-track-change.html
When an HTMLMediaElement's tracks change their enabled state, make sure to update
the PlatformMediaElement, for canProduceAudio() may have changed.
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged):
- platform/audio/cocoa/MediaSessionManagerCocoa.cpp:
(PlatformMediaSessionManager::updateSessionState):
The rest of the changes in this revision are to allow the above to be testable.
- page/Settings.cpp:
- page/Settings.h:
- platform/audio/AudioSession.h:
- platform/audio/mac/AudioSessionMac.cpp:
(WebCore::AudioSession::category):
(WebCore::AudioSession::setCategory):
- testing/InternalSettings.cpp:
(WebCore::InternalSettings::Backup::Backup):
(WebCore::InternalSettings::Backup::restoreTo):
(WebCore::InternalSettings::setShouldManageAudioSessionCategory):
- testing/InternalSettings.h:
- testing/InternalSettings.idl:
- testing/Internals.cpp:
(WebCore::Internals::audioSessionCategory):
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
- platform/mac/media/audio-session-category-video-track-change-expected.txt: Added.
- platform/mac/media/audio-session-category-video-track-change.html: Added.
- 10:54 AM Changeset in webkit [217998] by
-
- 4 edits in trunk/Source/WTF
Update WorkQueue::concurrentApply() to take a WTF::Function instead of an std::function
https://bugs.webkit.org/show_bug.cgi?id=173165
Reviewed by Saam Barati.
Update WorkQueue::concurrentApply() to take a WTF::Function instead of an std::function
as std::function has issues with regards to thread safety.
- wtf/WorkQueue.h:
- wtf/cocoa/WorkQueueCocoa.cpp:
(WTF::WorkQueue::concurrentApply):
- 10:52 AM Changeset in webkit [217997] by
-
- 8 edits2 adds in trunk
CSS transitions added while page is not visible do not start when the page becomes visible
https://bugs.webkit.org/show_bug.cgi?id=173166
<rdar://problem/32250351>
Reviewed by Darin Adler.
Source/WebCore:
CSS transitions added while page is not visible would not start when the page becomes
visible. The issue was that when CompositeAnimation::updateTransitions() was called
while the page is hidden (and animations are therefore suspended), it would not
populate m_transations with ImplicitAnimation objects. We would therefore have later
no transitions to resume when the page becomes visible later on. This patch updates
CompositeAnimation::updateTransitions() to properly populate m_transitions and instead
pause the ImplicitAnimation it creates if animations are currently suspended. This
behavior is more consistent with the one of CompositeAnimation::updateKeyframeAnimations().
I also needed to update ImplicitAnimation::animate() to not restart a paused animation
if the animation is currently paused. This is similar to what is done in
KeyframeAnimation::animate(). Without this, the paused ImplicitAnimation we add to
m_transition would incorrectly get unpaused while the page is still hidden and the
animations are still supposed to be suspended. This issue was showing when running the
test I am adding in this patch.
Test: fast/animation/css-animation-resuming-when-visible.html
- page/animation/CompositeAnimation.cpp:
(WebCore::CompositeAnimation::updateTransitions):
- page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::animate):
(WebCore::ImplicitAnimation::reset):
- page/animation/ImplicitAnimation.h:
LayoutTests:
Add layout test coverage.
- fast/animation/css-animation-resuming-when-visible-expected.txt: Added.
- fast/animation/css-animation-resuming-when-visible.html: Added.
- 10:48 AM Changeset in webkit [217996] by
-
- 3 edits in trunk/Source/WebKit2
Add SubresourceIntegrity as an experimental feature
https://bugs.webkit.org/show_bug.cgi?id=173164
Patch by Sam Weinig <sam@webkit.org> on 2017-06-09
Reviewed by Darin Adler.
- Shared/WebPreferencesDefinitions.h:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Add SubresourceIntegrity to the list of experimental features. Also, sort the experimental features
as requested by the comment above it.
- 10:44 AM Changeset in webkit [217995] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] FTL does not require dlfcn
https://bugs.webkit.org/show_bug.cgi?id=173143
Reviewed by Darin Adler.
We no longer use LLVM library. Thus, dlfcn.h is not necessary.
Also, ProcessID is not used in FTLLowerDFGToB3.cpp.
- ftl/FTLLowerDFGToB3.cpp:
- 10:01 AM Changeset in webkit [217994] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, Use FALLTHROUGH
- loader/LinkLoader.cpp:
(WebCore::createLinkPreloadResourceClient):
- 9:55 AM Changeset in webkit [217993] by
-
- 4 edits in trunk/Source/JavaScriptCore
[DFG] Add --verboseDFGFailure
https://bugs.webkit.org/show_bug.cgi?id=173155
Reviewed by Sam Weinig.
Similar to verboseFTLFailure, JSC should have verboseDFGFailure flag to show DFG failures quickly.
- dfg/DFGCapabilities.cpp:
(JSC::DFG::verboseCapabilities):
(JSC::DFG::debugFail):
- runtime/Options.cpp:
(JSC::recomputeDependentOptions):
- runtime/Options.h:
- 9:48 AM Changeset in webkit [217992] by
-
- 14 edits in branches/safari-604.1.25-branch
<rdar://problem/32621736> Seed 2: Disable WebKit features we don't want to ship after branching
- 9:38 AM Changeset in webkit [217991] by
-
- 4 edits in trunk/Source/WebKit2
Make sure |this| is protected in lambda capture in WebResourceLoadStatisticsStore::grandfatherExistingWebsiteData()
https://bugs.webkit.org/show_bug.cgi?id=173163
Reviewed by Brent Fulgham.
Make sure |this| is protected in lambda capture in WebResourceLoadStatisticsStore::grandfatherExistingWebsiteData()
or it may end up getting destroyed before the lambda executing and crash when calling m_statisticsQueue->dispatch().
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::grandfatherExistingWebsiteData):
- 9:35 AM Changeset in webkit [217990] by
-
- 7 edits in branches/safari-604.1.25-branch/Source
Versioning.
- 9:19 AM Changeset in webkit [217989] by
-
- 1 copy in branches/safari-604.1.25-branch
New branch.
- 9:19 AM Changeset in webkit [217988] by
-
- 2 edits in trunk/Source/WebKit
[Win64] Build error when compiling PaintHooks.asm.
https://bugs.webkit.org/show_bug.cgi?id=173132
Reviewed by Brent Fulgham.
There seems to be too many include paths on the command line for ml64. According to the documentation,
a maximum of 10 /I options is allowed. Create a separate static library for asm files, in order to
avoid all the include paths.
- PlatformWin.cmake:
- 9:18 AM Changeset in webkit [217987] by
-
- 1 delete in branches/safari-604.1.25-bran
Remove incorrectly named branch.
- 9:18 AM Changeset in webkit [217986] by
-
- 1 copy in branches/safari-604.1.25-bran
New branch.
- 9:14 AM Changeset in webkit [217985] by
-
- 10 edits2 adds in trunk
fast/mediastream/MediaStream-page-muted.html times out and asserts
https://bugs.webkit.org/show_bug.cgi?id=170355
<rdar://problem/31376041>
Source/WebCore:
MediaStream and MediaStreamTrack need to prevent JS wrapper collection while it is possible
to fire an event or event listeners won't be notified.
Reviewed by Chris Dumez.
Test: fast/mediastream/media-stream-wrapper-collected.html
- Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::MediaStream): Initialize ActiveDOMObject.
(WebCore::MediaStream::stop): New.
(WebCore::MediaStream::activeDOMObjectName): Ditto.
(WebCore::MediaStream::canSuspendForDocumentSuspension): Ditto.
(WebCore::MediaStream::hasPendingActivity): Ditto, prevent collection if there
are registered event listeners.
(WebCore::MediaStream::contextDestroyed): Deleted.
- Modules/mediastream/MediaStream.h:
- Modules/mediastream/MediaStream.idl:
- Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::hasPendingActivity): Prevent collection if there
are registered event listeners.
- Modules/mediastream/MediaStreamTrack.h:
- testing/Internals.cpp:
(WebCore::Internals::removeMediaStreamTrack): stream.removeTrack doesn't generate a 'removetrack'
event, so call private method that does.
- testing/Internals.h:
- testing/Internals.idl:
LayoutTests:
Reviewed by Chris Dumez.
- fast/mediastream/media-stream-wrapper-collected-expected.txt: Added.
- fast/mediastream/media-stream-wrapper-collected.html: Added.
- 9:13 AM Changeset in webkit [217984] by
-
- 2 edits in trunk/Source/WebKit2
[CoordinatedGraphics] Remove unneeded interfaces in PageClient
https://bugs.webkit.org/show_bug.cgi?id=173149
Patch by Daewoong Jang <daewoong.jang@navercorp.com> on 2017-06-09
Reviewed by Michael Catanzaro.
- UIProcess/PageClient.h:
- 9:11 AM Changeset in webkit [217983] by
-
- 2 edits in trunk/LayoutTests
[GTK] Fix test linter reported errors
https://bugs.webkit.org/show_bug.cgi?id=173160
Unreviewed gardening.
webrtc/audio-peer-connection-webaudio.html failed ambiguity checks, it typically fails
in release and times out in debug, but it could have bother outcomes in both build
configurations, so removing the first instance seems like the right approach.
See: https://bugs.webkit.org/show_bug.cgi?id=169110
https://bugs.webkit.org/show_bug.cgi?id=131218 no longer crashing
https://bugs.webkit.org/show_bug.cgi?id=131216 no longer crashing
https://bugs.webkit.org/show_bug.cgi?id=119255 no longer flaky, stablized at r195130.
Linter is now quiet, aside from non-existent path errors,
which I think is tracked by https://bugs.webkit.org/show_bug.cgi?id=172471
Patch by Charlie Turner <cturner@igalia.com> on 2017-06-09
- platform/gtk/TestExpectations:
- 8:55 AM Changeset in webkit [217982] by
-
- 1 copy in tags/Safari-604.1.25
Tag Safari-604.1.25.
- 8:00 AM Changeset in webkit [217981] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Drop OS(DARWIN) for VM_TAG_FOR_WEBASSEMBLY_MEMORY
https://bugs.webkit.org/show_bug.cgi?id=173147
Reviewed by JF Bastien.
Because this value becomes -1 in non-Darwin environments.
Thus, we do not need to use OS(DARWIN) here.
- wasm/WasmMemory.cpp:
- 5:53 AM Changeset in webkit [217980] by
-
- 1 edit1 add in trunk/LayoutTests
[GTK] Add baseline for media/media-fullscreen-inline-expected.html
Unreviewed gardening.
mediaElement.webkitSupportsPresentationMode is only present with
VIDEO_PRESENTATION_MODE enabled, and this option is only enabled
for Cocoa builds. Add a baseline without this property.
- platform/gtk/media/media-fullscreen-inline-expected.txt: Added.
- 5:18 AM Changeset in webkit [217979] by
-
- 2 edits in trunk/Source/WebKit2
Use WTF::Function instead of std::function in SpeculativeLoadManager::ExpiringEntry
https://bugs.webkit.org/show_bug.cgi?id=173125
Reviewed by Antti Koivisto.
- NetworkProcess/cache/NetworkCacheSpeculativeLoadManager.cpp:
(WebKit::NetworkCache::SpeculativeLoadManager::ExpiringEntry::ExpiringEntry):
(WebKit::NetworkCache::SpeculativeLoadManager::PreloadedEntry::PreloadedEntry):
- 4:44 AM Changeset in webkit [217978] by
-
- 2 edits in trunk/LayoutTests
[WPE] Unskip passing userscripts tests
Unreviewed gardening.
- platform/wpe/TestExpectations:
- 4:00 AM Changeset in webkit [217977] by
-
- 3 edits in trunk/Source/WebCore
[cURL] Remove a call to Windows API
https://bugs.webkit.org/show_bug.cgi?id=172079
Patch by Daewoong Jang <daewoong.jang@navercorp.com> on 2017-06-09
Reviewed by Yusuke Suzuki.
- platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownload::moveFileToDestination):
- platform/win/FileSystemWin.cpp:
(WebCore::moveFile):
- 3:52 AM Changeset in webkit [217976] by
-
- 3 edits in trunk/Source/WebCore
[GTK][WPE] Fix alpha premultiplying when using cairo to draw the video frames
https://bugs.webkit.org/show_bug.cgi?id=173097
Reviewed by Carlos Garcia Campos.
We need to premultiply alpha when creating a cairo surface from a GStreamer video frame, if the frame
has an alpha component. Currently this is wrongly done in VideoSinkGStreamer, as it assumes that every
frame is going to be rendered with cairo, which is not the case when using accelerated compositing.
The premultiply must happen inside ImageGStreamerCairo, which is where we know that the frame is
going to be rendered with cairo, and where the premultiply can be performed when gstreamer-gl is
enabled as well.
Covered by existent tests.
- platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
(ImageGStreamer::ImageGStreamer):
- platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
(webkitVideoSinkRequestRender):
- 3:39 AM Changeset in webkit [217975] by
-
- 2 edits in trunk/Source/WebKit2
Use WTF::getCurrentProcessID() instead of getpid()
https://bugs.webkit.org/show_bug.cgi?id=173130
Patch by Daewoong Jang <daewoong.jang@navercorp.com> on 2017-06-09
Reviewed by Tim Horton.
- UIProcess/API/APIProcessPoolConfiguration.h:
- 2:59 AM Changeset in webkit [217974] by
-
- 2 edits in trunk/Source/WebKit2
struct does not accept initializer-form if member has initializers in GCC 4.9
Unreviewed speculative build fix.
Remove the default initializers for DeniedRequest struct,
since it's only initialized in one place, to keep gcc 4.9
happy.
- UIProcess/UserMediaPermissionRequestManagerProxy.h:
- 2:09 AM Changeset in webkit [217973] by
-
- 10 edits48 adds in trunk
[WPE] Enable ENCRYPTED_MEDIA for build-webkit builds
https://bugs.webkit.org/show_bug.cgi?id=173103
Reviewed by Xabier Rodriguez-Calvar.
.:
- Source/cmake/OptionsWPE.cmake: Expose the ENABLE_ENCRYPTED_MEDIA
configuration option, keeping it disabled by default.
LayoutTests/imported/w3c:
- web-platform-tests/encrypted-media/idlharness-expected.txt:
Update the idlharness.html baseline. All the test cases pass.
Source/WebCore:
- Modules/encryptedmedia/CDM.cpp:
(WebCore::CDM::getSupportedCapabilitiesForAudioVideoType):
Pass the ParsedContentType's mime type string to the explicit ContentType
constructor and assign that to the MediaEngineSupportParameters' type
member.
Tools:
- Scripts/webkitperl/FeatureList.pm: Enable ENCRYPTED_MEDIA flag
when building the WPE port through build-webkit.
LayoutTests:
Enable the imported W3C tests covering Encrypted Media API for the WPE port,
but only tests that use the ClearKey key system. WPE-specific baselines for
those tests are also added, despite the test cases universally failing. This
will allow us to spot any change in behavior that's introduced.
- platform/wpe/TestExpectations: Skip tests that test PlayReady or Widevine key systems.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-check-initdata-type-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-events-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-events-session-closed-event-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-generate-request-disallowed-input-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-invalid-license-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-keystatuses-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-keystatuses-multiple-sessions-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-destroy-persistent-license-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-license-events-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-license-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-usage-record-events-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-persistent-usage-record-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-destroy-persistent-license-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-persistent-license-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-retrieve-persistent-usage-record-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-clear-encrypted-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-encrypted-clear-sources-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-events-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multikey-sequential-readyState-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multisession-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-src-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-after-update-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-immediately-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-setMediaKeys-onencrypted-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-two-videos-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-waitingforkey-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-requestmediakeysystemaccess-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-reset-src-after-setmediakeys-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-playback-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-again-after-resetting-src-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-at-same-time-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-different-mediakeys-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-multiple-times-with-the-same-mediakeys-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-setmediakeys-to-multiple-video-elements-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeys-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeysession-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-syntax-mediakeysystemaccess-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-unique-origin-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-update-disallowed-input-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-waiting-for-a-key-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-not-callable-after-createsession-expected.txt: Added.
- platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-update-non-ascii-input-expected.txt: Added.
- 1:59 AM Changeset in webkit [217972] by
-
- 12 edits in trunk/Source/WebCore
Move TreeScope::adoptIfNeeded to Node and rename it to setTreeScopeRecursively
https://bugs.webkit.org/show_bug.cgi?id=173129
Reviewed by Antti Koivisto.
Renamed TreeScope::adoptIfNeeded to setTreeScopeRecursively and moved to Node.
The old name was really confusing because due to the existence of Document::adoptNode, a DOM API,
which removes the adopted node from its parent if there was one before adopting the node.
Most confusingly, this function called TreeScope::adoptIfNeeded.
Also inlined the tree scope check to avoid calling to moveTreeToNewScope when there is nothing to do.
This patch effectively reverts r104528.
No new tests. Existing tests cover this.
- dom/Attr.cpp:
(WebCore::Attr::detachFromElementWithValue):
(WebCore::Attr::attachToElement):
- dom/ContainerNode.cpp:
(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::replaceAllChildren):
(WebCore::ContainerNode::appendChildWithoutPreInsertionValidityCheck):
(WebCore::ContainerNode::parserAppendChild):
- dom/ContainerNodeAlgorithms.cpp:
(WebCore::addChildNodesToDeletionQueue):
- dom/Document.cpp:
(WebCore::Document::adoptNode):
- dom/Element.cpp:
(WebCore::Element::ensureAttr):
- dom/Node.cpp:
(WebCore::DidMoveToNewDocumentAssertionScope): Added. The old assertion wasn't sufficient when
HTMLTemplateElement made a recursive call to setTreeScopeRecursively.
(WebCore::DidMoveToNewDocumentAssertionScope::DidMoveToNewDocumentAssertionScope):
(WebCore::DidMoveToNewDocumentAssertionScope::~DidMoveToNewDocumentAssertionScope):
(WebCore::DidMoveToNewDocumentAssertionScope::didRecieveCall):
(WebCore::moveNodeToNewDocument): Moved from TreeScope. Calls to incrementReferencingNodeCount
and decrementReferencingNodeCount to Node::didMoveToNewDocument. This function is now eliminated
in a release build.
(WebCore::moveShadowTreeToNewDocument): Moved from TreeScope.
(WebCore::Node::moveTreeToNewScope): Ditto.
(WebCore::Node::didMoveToNewDocument): See the description for moveNodeToNewDocument above.
- dom/Node.h:
(WebCore::Node::isParsingChildrenFinished): Moved to avoid having its own protected section.
(WebCore::Node::setIsParsingChildrenFinished): Ditto.
(WebCore::Node::clearIsParsingChildrenFinished): Ditto.
(WebCore::Node::setTreeScopeRecursively): Moved from TreeScope::adoptIfNeeded.
- dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::~ShadowRoot):
- dom/TreeScope.cpp:
(WebCore::TreeScope::adoptIfNeeded): Deleted.
(WebCore::TreeScope::moveTreeToNewScope): Deleted.
(WebCore::TreeScope::ensureDidMoveToNewDocumentWasCalled): Deleted.
(WebCore::TreeScope::moveNodeToNewDocument): Deleted.
(WebCore::TreeScope::moveShadowTreeToNewDocument): Deleted.
- dom/TreeScope.h:
- html/HTMLTemplateElement.cpp:
(WebCore::HTMLTemplateElement::didMoveToNewDocument):
- 1:58 AM Changeset in webkit [217971] by
-
- 19 edits1 copy1 add in trunk/Source
[GTK] Add kinetic scrolling
https://bugs.webkit.org/show_bug.cgi?id=155750
Patch by Adrien Plazas <aplazas@igalia.com> on 2017-06-09
Reviewed by Carlos Garcia Campos.
Patch by Adrien Plazas and Yusuke Suzuki.
Source/WebCore:
Add the ScrollAnimationKinetic scrolling animation allowing to perform momentum scrolling; it is based on GTK+'s
GtkKineticScrolling type.
Add the notion of phase, momentum phase and swipe velocity to PlatformWheelEvent.
Depending on whether the scrolling ended normally or triggered a swipe, the scroll animator will either compute
the swipe velocity from the previous scrolling events or use the one from the swipe gesture to initiate the
momentum scrolling.
- PlatformGTK.cmake:
- platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::setHasPreciseScrollingDeltas):
(WebCore::PlatformWheelEvent::phase):
(WebCore::PlatformWheelEvent::momentumPhase):
(WebCore::PlatformWheelEvent::isTransitioningToMomentumScroll):
- platform/ScrollAnimation.h:
(WebCore::ScrollAnimation::scroll):
(WebCore::ScrollAnimation::updateVisibleLengths):
(WebCore::ScrollAnimation::setCurrentPosition):
- platform/ScrollAnimationKinetic.cpp: Added.
(WebCore::ScrollAnimationKinetic::PerAxisData::PerAxisData):
(WebCore::ScrollAnimationKinetic::PerAxisData::animateScroll):
(WebCore::ScrollAnimationKinetic::ScrollAnimationKinetic):
(WebCore::ScrollAnimationKinetic::~ScrollAnimationKinetic):
(WebCore::ScrollAnimationKinetic::stop):
(WebCore::ScrollAnimationKinetic::start):
(WebCore::ScrollAnimationKinetic::animationTimerFired):
- platform/ScrollAnimationKinetic.h: Copied from Source/WebCore/platform/ScrollAnimation.h.
- platform/gtk/PlatformWheelEventGtk.cpp:
(WebCore::PlatformWheelEvent::PlatformWheelEvent):
(WebCore::PlatformWheelEvent::swipeVelocity):
- platform/gtk/ScrollAnimatorGtk.cpp:
(WebCore::ScrollAnimatorGtk::ScrollAnimatorGtk):
(WebCore::ScrollAnimatorGtk::ensureSmoothScrollingAnimation):
(WebCore::ScrollAnimatorGtk::scroll):
(WebCore::ScrollAnimatorGtk::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorGtk::computeVelocity):
(WebCore::ScrollAnimatorGtk::handleWheelEvent):
(WebCore::ScrollAnimatorGtk::willEndLiveResize):
(WebCore::ScrollAnimatorGtk::updatePosition):
(WebCore::ScrollAnimatorGtk::didAddVerticalScrollbar):
(WebCore::ScrollAnimatorGtk::didAddHorizontalScrollbar):
- platform/gtk/ScrollAnimatorGtk.h:
Source/WebKit2:
Add the notion of phase and momentum phase to WebWheelEvent.
Make WebWheelEvent manage the 'is_stop' attribute of GdkEventScroll to create the corresponding WebWheelEvent
with the correct phases and deltas.
Make GestureController manage swipes to create the corresponding WebWheelEvent with the correct phases and
deltas.
- Shared/NativeWebWheelEvent.h:
- Shared/WebEvent.h:
- Shared/WebEventConversion.cpp:
(WebKit::WebKit2PlatformWheelEvent::WebKit2PlatformWheelEvent):
- Shared/WebWheelEvent.cpp:
(WebKit::WebWheelEvent::WebWheelEvent):
(WebKit::WebWheelEvent::encode):
(WebKit::WebWheelEvent::decode):
- Shared/gtk/NativeWebWheelEventGtk.cpp:
(WebKit::NativeWebWheelEvent::NativeWebWheelEvent):
- Shared/gtk/WebEventFactory.cpp:
(WebKit::WebEventFactory::createWebWheelEvent):
- Shared/gtk/WebEventFactory.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handleWheelEvent):
(WebKit::WebPageProxy::shouldProcessWheelEventNow):
- UIProcess/WebPageProxy.h:
- UIProcess/gtk/GestureController.cpp:
(WebKit::GestureController::GestureController):
(WebKit::GestureController::handleEvent):
(WebKit::GestureController::isProcessingGestures):
(WebKit::createScrollEvent):
(WebKit::GestureController::DragGesture::startDrag):
(WebKit::GestureController::DragGesture::handleDrag):
(WebKit::GestureController::DragGesture::begin):
(WebKit::GestureController::DragGesture::end):
(WebKit::GestureController::SwipeGesture::startMomentumScroll):
(WebKit::GestureController::SwipeGesture::swipe):
(WebKit::GestureController::SwipeGesture::SwipeGesture):
- UIProcess/gtk/GestureController.h:
- 1:49 AM Changeset in webkit [217970] by
-
- 4 edits in trunk
[WPE] Enable MEDIA_SOURCE for build-webkit builds
https://bugs.webkit.org/show_bug.cgi?id=173136
Reviewed by Xabier Rodriguez-Calvar.
Tools:
- Scripts/webkitperl/FeatureList.pm: Enable the MEDIA_SOURCE feature for WPE.
LayoutTests:
- platform/wpe/TestExpectations: Enable the media/media-source/ layout tests
for the WPE port, adding half a dozen failure or timeout expectations for
tests that are currently failing.
- 1:47 AM Changeset in webkit [217969] by
-
- 2 edits in trunk/Source/WebCore
[GCrypt] ECDSA signing results can be smaller than the EC key size
https://bugs.webkit.org/show_bug.cgi?id=171535
Reviewed by Jiewen Tan.
The libgcrypt-based implementation of the ECDSA signing operation does not
properly address the resultingrandsintegers that do not potentially
match the EC key in terms of size.
To address that, the retrieved MPI data for both integers is handled depending
on the size of said data. Strictly requiring an amount of bytes that matches
the key data size N, we simply take the last N bytes if the MPI data is equal
or larger than N in size. If smaller, we first append enough zero bytes to the
output Vector object before attaching the MPI data in whole so that the amount
of appended bytes matches N.
No new tests -- covers an implementation detail that is not trivial to test,
but can rely sufficiently on existing tests.
- crypto/gcrypt/CryptoAlgorithmECDSAGCrypt.cpp:
(WebCore::extractECDSASignatureInteger):
(WebCore::gcryptSign):
- 1:21 AM Changeset in webkit [217968] by
-
- 8 edits in trunk/Source
Reduce compiler warnings
https://bugs.webkit.org/show_bug.cgi?id=172078
Patch by Daewoong Jang <daewoong.jang@navercorp.com> on 2017-06-09
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
- runtime/IntlDateTimeFormat.h:
Source/WebCore:
- platform/network/curl/CookieJarCurl.cpp:
(WebCore::addMatchingCurlCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostnames):
(WebCore::deleteCookiesForHostname): Deleted.
- platform/network/curl/CurlDownload.cpp:
(WebCore::CurlDownloadManager::downloadThread):
(WebCore::CurlDownload::didReceiveHeader):
- platform/network/curl/CurlDownload.h:
(WebCore::CurlDownloadListener::didReceiveDataOfLength):
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::WebCoreSynchronousLoader::didReceiveResponse):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
- platform/network/curl/SocketStreamHandleImplCurl.cpp:
(WebCore::createCopy):
(WebCore::SocketStreamHandleImpl::readData):
- 1:05 AM Changeset in webkit [217967] by
-
- 2 edits in trunk/Source/WebKit2
Crash in -[WKWebView _initializeWithConfiguration:]
https://bugs.webkit.org/show_bug.cgi?id=173126
Reviewed by Antti Koivisto.
Crash occurs when passing an autoreleased NSString into _setMediaContentTypesRequiringHardwareSupport.
The ivar should be a RetainPtr rather than a bare NSString *.
- UIProcess/API/Cocoa/WKWebViewConfiguration.mm:
(-[WKWebViewConfiguration _mediaContentTypesRequiringHardwareSupport]):
- 1:03 AM Changeset in webkit [217966] by
-
- 19 edits in trunk
[GStreamer][EME] Remove the legacy code that was not even official and is deprecated
https://bugs.webkit.org/show_bug.cgi?id=173096
Reviewed by Žan Doberšek.
.:
- Source/cmake/OptionsWPE.cmake: Remove LEGACY_ENCRYPTED_MEDIA support
Source/WebCore:
We are removing the LEGACY_ENCRYPTED_MEDIA code that we was not
official, is deprecated and we are not planning to support it
anymore in any way.
This also helps implementing current ENCRYPTED_MEDIA in a cleaner
way.
- platform/GStreamer.cmake:
- platform/graphics/gstreamer/GStreamerUtilities.cpp:
- platform/graphics/gstreamer/GStreamerUtilities.h:
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::registerWebKitGStreamerElements):
(WebCore::MediaPlayerPrivateGStreamerBase::~MediaPlayerPrivateGStreamerBase):
(WebCore::MediaPlayerPrivateGStreamerBase::handleSyncMessage):
(WebCore::extractEventsAndSystemsFromMessage): Deleted.
(WebCore::MediaPlayerPrivateGStreamerBase::needKey): Deleted.
(WebCore::MediaPlayerPrivateGStreamerBase::setCDMSession): Deleted.
(WebCore::MediaPlayerPrivateGStreamerBase::keyAdded): Deleted.
(WebCore::MediaPlayerPrivateGStreamerBase::handleProtectionEvent): Deleted.
(WebCore::MediaPlayerPrivateGStreamerBase::receivedGenerateKeyRequest): Deleted.
(WebCore::keySystemIdToUuid): Deleted.
(WebCore::MediaPlayerPrivateGStreamerBase::createSession): Deleted.
(WebCore::MediaPlayerPrivateGStreamerBase::dispatchDecryptionKey): Deleted.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
- platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:
- platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.h:
- platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
- platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.h:
- platform/graphics/gstreamer/mse/AppendPipeline.cpp:
(WebCore::AppendPipeline::AppendPipeline):
(WebCore::AppendPipeline::parseDemuxerSrcPadCaps):
(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsinkFromAnyThread):
(WebCore::AppendPipeline::disconnectDemuxerSrcPadFromAppsinkFromAnyThread):
(WebCore::appendPipelineElementMessageCallback): Deleted.
(WebCore::AppendPipeline::dispatchPendingDecryptionKey): Deleted.
(WebCore::AppendPipeline::dispatchDecryptionKey): Deleted.
(WebCore::AppendPipeline::handleElementMessage): Deleted.
- platform/graphics/gstreamer/mse/AppendPipeline.h:
- platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::dispatchDecryptionKey): Deleted.
- platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:
LayoutTests:
- platform/gtk/TestExpectations: Mark legacy tests as deprecated
- 1:02 AM Changeset in webkit [217965] by
-
- 6 edits in trunk
AX: Media Controls: Missing labels for the Time Labels.
https://bugs.webkit.org/show_bug.cgi?id=171715
<rdar://problem/32009214>
Patch by Aaron Chu <aaron_chu@apple.com> on 2017-06-09
Reviewed by Antoine Quint.
Source/WebCore:
Added aria-label to describe time labels in media controls.
- Modules/modern-media-controls/controls/slider.js:
(Slider.prototype.set inputAccessibleLabel):
(Slider.prototype._formatTime): Deleted.
- Modules/modern-media-controls/controls/time-label.js:
(TimeLabel.prototype.commitProperty):
- Modules/modern-media-controls/main.js:
(formatTimeToString):
LayoutTests:
Modified existing test case to accommodate testing for time label description.
- media/modern-media-controls/time-label/time-label.html:
