Timeline
Jul 28, 2017:
- 7:39 PM Changeset in webkit [220040] by
-
- 2 edits in trunk/Source/WebKit
[Mac][WebKit2] WebKit sandbox errors while streaming Netflix
https://bugs.webkit.org/show_bug.cgi?id=174955
<rdar://problem/33583994>
Reviewed by Alex Christensen.
Wider testing with the stricter sandboxing rules identified three more IOKit properties we need to expose:
- CEAModeID
- CEAPixelRepetition
- IOFBHDMIDongleROM
- WebProcess/com.apple.WebProcess.sb.in:
- 7:35 PM Changeset in webkit [220039] by
-
- 14 edits1 delete in trunk
[WebIDL] Remove JS builtin bindings for FetchHeaders
https://bugs.webkit.org/show_bug.cgi?id=174905
Patch by Sam Weinig <sam@webkit.org> on 2017-07-28
Reviewed by Alex Christensen.
LayoutTests/imported/w3c:
- web-platform-tests/fetch/api/headers/headers-basic-expected.txt:
- web-platform-tests/fetch/api/headers/headers-record-expected.txt:
Update results for more passing tests.
Source/WebCore:
- CMakeLists.txt:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- Modules/fetch/FetchHeaders.js: Removed.
Remove FetchHeaders.js
- Modules/fetch/FetchHeaders.cpp:
(WebCore::appendToHeaderMap):
(WebCore::FetchHeaders::create):
(WebCore::FetchHeaders::append):
- Modules/fetch/FetchHeaders.h:
(WebCore::FetchHeaders::FetchHeaders):
Add create function for generated constructor.
Add appendToHeaderMap static function which takes the functionality
from the existing append function, and makes it useable in create.
- Modules/fetch/FetchHeaders.idl:
Replace [JSBuiltinConstructor] with real constructor. Keep other builtin
attributes as they are still used by other Fetch code.
- bindings/js/JSDOMConvertRecord.h:
Fix record conversion to work with proxies by changing to use the method table
for getOwnPropertyNames, and undefined values by not excluding undefined values.
LayoutTests:
- fetch/header-constructor-is-array-expected.txt:
- fetch/header-constructor-is-array.html:
Update test to match spec. An array with out a prototype will not yield
a valid Header as it is not iterable.
- 5:57 PM Changeset in webkit [220038] by
-
- 22 edits24 copies3 moves12 adds4 deletes in trunk
Unreviewed, rolling out r219986.
https://bugs.webkit.org/show_bug.cgi?id=174962
"broke PLT on iOS (rdar://problem/33602751)" (Requested by
estes on #webkit).
Reverted changeset:
"Part 1 of: Rename DatabaseProcess to StorageProcess."
https://bugs.webkit.org/show_bug.cgi?id=174879
http://trac.webkit.org/changeset/219986
- 5:52 PM Changeset in webkit [220037] by
-
- 52 edits in trunk
Unreviewed, rolling out r219990.
https://bugs.webkit.org/show_bug.cgi?id=174961
"broke PLT on iOS (rdar://problem/33602751)" (Requested by
estes on #webkit).
Reverted changeset:
"Part 2 of: Rename DatabaseProcess to StorageProcess."
https://bugs.webkit.org/show_bug.cgi?id=174880
http://trac.webkit.org/changeset/219990
- 5:33 PM Changeset in webkit [220036] by
-
- 12 edits in trunk
Web Inspector: capture an async stack trace when web content calls addEventListener
https://bugs.webkit.org/show_bug.cgi?id=174739
<rdar://problem/33468197>
Reviewed by Brian Burg.
Source/JavaScriptCore:
Allow debugger agents to perform custom logic when asynchronous stack
trace data is cleared. For example, the PageDebuggerAgent would clear
its list of registered listeners for which call stacks have been recorded.
- inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::clearAsyncStackTraceData):
- inspector/agents/InspectorDebuggerAgent.h:
Source/WebCore:
Test: inspector/debugger/async-stack-trace.html
Add instrumentation to EventTarget to support showing asynchronous
stack traces when the debugger breaks in a script event listener.
- dom/EventTarget.cpp:
(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::fireEventListeners):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didAddEventListenerImpl):
(WebCore::InspectorInstrumentation::willRemoveEventListenerImpl):
(WebCore::InspectorInstrumentation::willHandleEventImpl):
(WebCore::InspectorInstrumentation::didHandleEventImpl):
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didAddEventListener):
(WebCore::InspectorInstrumentation::willRemoveEventListener):
(WebCore::InspectorInstrumentation::willHandleEvent):
(WebCore::InspectorInstrumentation::didHandleEvent):
- inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::didClearAsyncStackTraceData):
(WebCore::PageDebuggerAgent::didAddEventListener):
(WebCore::PageDebuggerAgent::willRemoveEventListener):
(WebCore::PageDebuggerAgent::willHandleEvent):
- inspector/PageDebuggerAgent.h:
LayoutTests:
Add test case checking that async stack traces are recorded for addEventListener.
- inspector/debugger/async-stack-trace-expected.txt:
- inspector/debugger/async-stack-trace.html:
- 5:25 PM Changeset in webkit [220035] by
-
- 4 edits2 adds in trunk
Don't add autoplay restrictions to media elements created in response to user gestures.
https://bugs.webkit.org/show_bug.cgi?id=174947
Reviewed by Eric Carlson.
Source/WebCore:
Test: media/video-create-with-user-gesture.html
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
LayoutTests:
Skip the test on iOS because "runWithKeyDown" does not work there.
Jer: "Turns out the problem with iOS is that the WKTR EventSender is basically unwritten. It
doesn't support sending mouse, key, or touch events, so our "do this during a user gesture"
helper in video-test.js doesn't work."
- media/video-create-with-user-gesture-expected.txt: Added.
- media/video-create-with-user-gesture.html: Added.
- platform/ios/TestExpectations:
- 4:21 PM Changeset in webkit [220034] by
-
- 2 edits in trunk/LayoutTests
The test imported/w3c/web-platform-tests/fetch/api/basic/accept-header.any.html is slow on Windows.
Unreviewed test gardening, mark test as slow.
- platform/win/TestExpectations:
- 4:19 PM Changeset in webkit [220033] by
-
- 5 edits in trunk
API tests that use URLSchemeHandler are failing.
https://bugs.webkit.org/show_bug.cgi?id=174950
Reviewed by Alex Christensen.
Source/WebKit:
Make sure that in all cases where we remove the last task from the page->task map...
...We also remove the map itself.
- UIProcess/WebURLSchemeHandler.cpp:
(WebKit::WebURLSchemeHandler::stopTask):
(WebKit::WebURLSchemeHandler::taskCompleted):
(WebKit::WebURLSchemeHandler::removeTaskFromPageMap):
- UIProcess/WebURLSchemeHandler.h:
Tools:
Fix the NoMIMEType test to be correct.
- TestWebKitAPI/Tests/WebKit2Cocoa/WKURLSchemeHandler-1.mm:
(-[SchemeHandler initWithData:mimeType:]):
(-[SchemeHandler webView:startURLSchemeTask:]):
(TEST):
- 3:31 PM Changeset in webkit [220032] by
-
- 2 edits in trunk/Tools
prepare-ChangeLog should not list added layout tests in PAL ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=174876
Reviewed by Alex Christensen.
Do not list added layout tests in the PAL ChangeLog as such tests are unlikely to be related
to a PAL change. Unit tests are more appropriate for PAL changes than layout tests because
they provide a more direct way to test the platform abstraction.
As a side effect of this change we no longer list added layout tests in WebCore/platform/gtk/po/ChangeLog.
- Scripts/prepare-ChangeLog:
(generateNewChangeLogs): Only list added layout tests in the WebCore ChangeLog regardless
of the current working directory.
- 3:21 PM Changeset in webkit [220031] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, rolling out r220016.
Test needs to be unskipped due to configuration change in High
Sierra.
Reverted changeset:
"Marked fast/images/pdf-as-image-with-annotations.html as
image failure."
http://trac.webkit.org/changeset/220016
- 3:20 PM Changeset in webkit [220030] by
-
- 13 edits2 adds in branches/safari-604-branch
Cherry-pick r219904. rdar://problem/33595576
- 3:20 PM Changeset in webkit [220029] by
-
- 4 edits2 adds in branches/safari-604-branch
Cherry-pick r220003. rdar://problem/33595572
- 3:20 PM Changeset in webkit [220028] by
-
- 3 edits in branches/safari-604-branch/Source/WebCore
Cherry-pick r219998. rdar://problem/33595610
- 3:20 PM Changeset in webkit [220027] by
-
- 3 edits in branches/safari-604-branch/Source/WebCore
Cherry-pick r219992. rdar://problem/33595621
- 3:19 PM Changeset in webkit [220026] by
-
- 2 edits in branches/safari-604-branch/Source/WebCore
Cherry-pick r219991. rdar://problem/33595570
- 3:19 PM Changeset in webkit [220025] by
-
- 2 edits in branches/safari-604-branch/Source/WebKit
Cherry-pick r219987. rdar://problem/33595619
- 3:19 PM Changeset in webkit [220024] by
-
- 2 edits in branches/safari-604-branch/Source/WebKit
Cherry-pick r219973. rdar://problem/33595608
- 3:19 PM Changeset in webkit [220023] by
-
- 8 edits2 adds in branches/safari-604-branch
Cherry-pick r219950. rdar://problem/33595459
- 3:19 PM Changeset in webkit [220022] by
-
- 5 edits in branches/safari-604-branch
Cherry-pick r219949. rdar://problem/33595616
- 3:19 PM Changeset in webkit [220021] by
-
- 11 edits in branches/safari-604-branch
Cherry-pick r219906. rdar://problem/33595387
- 3:19 PM Changeset in webkit [220020] by
-
- 2 edits in branches/safari-604-branch/Source/JavaScriptCore
Cherry-pick r219895. rdar://problem/33595450
- 3:19 PM Changeset in webkit [220019] by
-
- 2 edits in branches/safari-604-branch/Source/WebCore
Cherry-pick r219891. rdar://problem/33595436
- 3:19 PM Changeset in webkit [220018] by
-
- 3 edits in branches/safari-604-branch/Source/WebKit
Cherry-pick r219855. rdar://problem/33595427
- 3:04 PM Changeset in webkit [220017] by
-
- 2 edits in trunk/Tools
Using "auto <function()> -> returnType" breaks prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=174930
Unreviewed test fix.
We need to check parentheses before printing 'const' or 'volatile' in the ChangeLog.
- Scripts/prepare-ChangeLog:
(get_function_line_ranges_for_cpp):
- 2:58 PM Changeset in webkit [220016] by
-
- 2 edits in trunk/LayoutTests
Marked fast/images/pdf-as-image-with-annotations.html as image failure.
<rdar://problem/33550614>
Unreviewed test gardening.
- platform/mac-highsierra/TestExpectations:
- 2:09 PM Changeset in webkit [220015] by
-
- 2 edits in trunk/LayoutTests
Marked multiple iimported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/ as failing.
<rdar://problem/33548297>
Unreviewed test gardening.
- platform/mac-highsierra/TestExpectations:
- 2:08 PM Changeset in webkit [220014] by
-
- 2 edits in trunk/Source/WebCore
WebMediaSessionHelper calls -[UIApplication beginReceivingRemoteControlEvents] from WebThread
https://bugs.webkit.org/show_bug.cgi?id=174934
rdar://problem/33586772
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-07-28
Reviewed by Eric Carlson.
No new tests because no effect on DOM.
This dispatches a UIKit call to the main thread since it might happen on WebThread in WK1.
- platform/audio/ios/MediaSessionManagerIOS.mm:
(-[WebMediaSessionHelper initWithCallback:]):
- 1:49 PM Changeset in webkit [220013] by
-
- 3 edits in trunk/LayoutTests
Marked imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html as flaky.
<rdar://problem/33555052>
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- platform/mac-highsierra/TestExpectations:
- 1:29 PM Changeset in webkit [220012] by
-
- 4 edits1 add in trunk
ObjectToStringAdaptiveStructureWatchpoint should not fire if it's dying imminently.
https://bugs.webkit.org/show_bug.cgi?id=174948
<rdar://problem/33495680>
Reviewed by Filip Pizlo.
JSTests:
- stress/regress-174948.js: Added.
Source/JavaScriptCore:
ObjectToStringAdaptiveStructureWatchpoint is owned by StructureRareData. If its
owner StructureRareData is already known to be dead (in terms of GC liveness) but
hasn't been destructed yet (i.e. not swept by the GC yet), we should ignore all
requests to fire this watchpoint.
If the GC had the chance to sweep the StructureRareData, thereby destructing the
ObjectToStringAdaptiveStructureWatchpoint, it (the watchpoint) would have removed
itself from the WatchpointSet it was on. Hence, it would not have been fired.
But since the watchpoint hasn't been destructed yet, it still remains on the
WatchpointSet and needs to guard against being fired in this state. The fix is
to simply return early if its owner StructureRareData is not live. This has the
effect of the watchpoint fire being a no-op, which is equivalent to the watchpoint
not firing as we would expect.
This patch also removes some cargo cult copying of watchpoint code which
instantiates a StringFireDetail. In a few cases, that StringFireDetail is never
used. This patch removes these unnecessary instantiations.
- bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp:
(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::fireInternal):
- runtime/StructureRareData.cpp:
(JSC::ObjectToStringAdaptiveStructureWatchpoint::fireInternal):
(JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::handleFire):
- 1:03 PM Changeset in webkit [220011] by
-
- 15 edits in trunk/Source/WebKit
WKURLSchemeTaskImpl instances are being abandoned (except if the task is stopped).
<rdar://problem/33568276> and https://bugs.webkit.org/show_bug.cgi?id=174895
Reviewed by Alex Christensen.
There was a lot going on here:
- There was an unbroken cycle between URLSchemeHandlers and URLSchemeTasks
- WKURLSchemeTasks were not destroying their API::URLSchemeTask implementation object
- When a WKWebView was dealloc'ed, it was not cleaning up the related UIProcess tasks
- If the NetworkingProcess crashed, WebProcesses were not cleaning up their tasks (and therefore the UIProcess tasks were also not getting cleaned up)
- If a WebProcess crashed, the UIProcess was not cleaning up the related tasks
- UIProcess/API/Cocoa/WKURLSchemeTask.mm:
(-[WKURLSchemeTaskImpl dealloc]): Call API::~URLSchemeTask
- UIProcess/Cocoa/WebURLSchemeHandlerCocoa.h:
- UIProcess/Cocoa/WebURLSchemeHandlerCocoa.mm:
(WebKit::WebURLSchemeHandlerCocoa::platformTaskCompleted): Clear out the API wrapper map
so the wrapper and implementation object can both be destroyed.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::close): Call stopAllURLSchemeTasks.
(WebKit::WebPageProxy::processDidTerminate): Call stopAllURLSchemeTasks.
(WebKit::WebPageProxy::stopAllURLSchemeTasks):
- UIProcess/WebPageProxy.h:
- UIProcess/WebURLSchemeHandler.cpp:
(WebKit::WebURLSchemeHandler::startTask):
(WebKit::WebURLSchemeHandler::stopAllTasksForPage):
(WebKit::WebURLSchemeHandler::stopTask):
(WebKit::WebURLSchemeHandler::taskCompleted):
- UIProcess/WebURLSchemeHandler.h:
- UIProcess/WebURLSchemeTask.cpp:
(WebKit::WebURLSchemeTask::WebURLSchemeTask):
- UIProcess/WebURLSchemeTask.h:
(WebKit::WebURLSchemeTask::pageID): Store separate from the WebPage so messaging
is possible even after the WebPage* has been cleared.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::stopAllURLSchemeTasks):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebURLSchemeHandlerProxy.cpp:
(WebKit::WebURLSchemeHandlerProxy::stopAllTasks):
(WebKit::WebURLSchemeHandlerProxy::taskDidComplete):
(WebKit::WebURLSchemeHandlerProxy::taskDidStopLoading):
(WebKit::WebURLSchemeHandlerProxy::removeTask):
- WebProcess/WebPage/WebURLSchemeHandlerProxy.h:
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::networkProcessConnectionClosed): Call stopAllURLSchemeTasks
for each WebPage.
- 11:54 AM Changeset in webkit [220010] by
-
- 4 edits in trunk/Tools
Using "auto <function()> -> returnType" breaks prepare-ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=174930
Reviewed by Daniel Bates.
Teach prepare-ChangeLog about C++ auto arrow return, and while I'm
here also teach it about const and volatile overloads. I didn't do
reference and rvalue reference overloads because we don't really
use them, and the current parser throws away those characters and
it doesn't seem worth making it more complex.
- Scripts/prepare-ChangeLog:
(get_function_line_ranges_for_cpp):
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests-expected.txt:
- Scripts/webkitperl/prepare-ChangeLog_unittest/resources/cpp_unittests.cpp:
(Foo::Arrow::arrow):
(Foo::Arrow::otherArrow):
(Foo::Arrow::otherArrow const):
(Foo::Arrow::otherArrow volatile):
(Foo::Arrow::otherArrow const volatile):
- 11:36 AM Changeset in webkit [220009] by
-
- 7 edits4 adds in trunk
[macOS] Reeder's defaults font is Times instead of San Francisco
https://bugs.webkit.org/show_bug.cgi?id=174885
<rdar://problem/33462483>
Reviewed by Simon Fraser.
Source/WebCore:
Reeder uses explicit dot-prefixed names in its source code. Within Core Text,
dot-prefixed names cannot be matched case insensitively. The solution is to
not case-fold these family names, and to make our caches case sensitive for
these special names.
Tests: fast/text/font-lookup-dot-prefix-case-sensitive-2.html
fast/text/font-lookup-dot-prefix-case-sensitive.html
- platform/graphics/FontCache.cpp:
(WebCore::FontPlatformDataCacheKey::operator==):
(WebCore::FontPlatformDataCacheKeyHash::hash):
- platform/graphics/FontCascade.cpp:
(WebCore::keysMatch):
(WebCore::computeFontCascadeCacheHash):
- platform/graphics/FontDescription.cpp:
(WebCore::FontCascadeDescription::familyNamesAreEqual):
(WebCore::FontCascadeDescription::familyNameHash):
(WebCore::FontCascadeDescription::foldedFamilyName):
- platform/graphics/FontDescription.h:
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontDatabase::fontForPostScriptName):
LayoutTests:
- fast/text/font-lookup-dot-prefix-case-sensitive-2-expected.html: Added.
- fast/text/font-lookup-dot-prefix-case-sensitive-2.html: Added.
- fast/text/font-lookup-dot-prefix-case-sensitive-expected-mismatch.html: Added.
- fast/text/font-lookup-dot-prefix-case-sensitive.html: Added.
- 11:22 AM Changeset in webkit [220008] by
-
- 18 edits4 adds in trunk
Web Inspector: Record actions performed on CanvasRenderingContext2D
https://bugs.webkit.org/show_bug.cgi?id=174482
Reviewed by Joseph Pecoraro.
Source/WebCore:
Tests: inspector/canvas/recording-2d.html
inspector/canvas/recording.html
- html/canvas/CanvasRenderingContext2D.idl:
Add CallTracingCallback to interface to record all API calls.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::paint):
If a recording is active, mark the current frame as completed.
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateAttributeGetterBodyDefinition):
(GenerateAttributeSetterBodyDefinition):
(GenerateImplementationFunctionCall):
(GenerateCallTracerParameter):
(GenerateCallTracer):
- bindings/scripts/test/TestCallTracer.idl:
- bindings/scripts/test/JS/JSTestCallTracer.cpp:
(WebCore::setJSTestCallTracerTestAttributeInterfaceSetter):
(WebCore::setJSTestCallTracerTestAttributeSpecifiedSetter):
(WebCore::jsTestCallTracerTestAttributeWithVariantGetter):
(WebCore::jsTestCallTracerTestAttributeWithVariant):
(WebCore::setJSTestCallTracerTestAttributeWithVariantSetter):
(WebCore::setJSTestCallTracerTestAttributeWithVariant):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationInterfaceBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationSpecifiedBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithArgumentsBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithVariantArgument):
- inspector/InspectorCanvas.h:
- inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::buildAction):
Change CallTracer IDL generation to flatten any variants so that all types for the
parameters of an action are able to be listed in a single variant. This prevents possible
ambiguity when constructing the variant, as they require that exactly one type be
constructible and a sub-variant might not satisfy that condition. This was only an issue for
older mac SDKs.
- bindings/js/CallTracer.h:
- bindings/js/CallTracer.cpp:
(WebCore::CallTracer::recordCanvasAction):
- bindings/js/CallTracerTypes.h:
- inspector/InspectorCanvasAgent.h:
- inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::recordCanvasAction):
- inspector/InspectorInstrumentation.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::recordCanvasAction):
(WebCore::InspectorInstrumentation::recordCanvasActionImpl):
Rename CanvasActionParameterVariant to RecordCanvasActionVariant to match what is expected by
the IDL generator. Also remove unnecessary includes now that they are in CallTracerTypes.h.
- CMakeLists.txt:
- bindings/js/JSBindingsAllInOne.cpp:
Add CallTracer for CMake builds.
LayoutTests:
- inspector/canvas/recording-2d-expected.txt: Added.
- inspector/canvas/recording-2d.html: Added.
- inspector/canvas/recording-expected.txt: Added.
- inspector/canvas/recording.html: Added.
Take a recording of all CanvasRenderingContext2D actions and dump the recorded JSON data.
- 11:06 AM Changeset in webkit [220007] by
-
- 4 edits in trunk
[GTK] Building with ENABLE_VIDEO=OFF fails
https://bugs.webkit.org/show_bug.cgi?id=174940
Reviewed by Alex Christensen.
.:
Code guarded by ENABLE(MEDIA_STREAM) requires the definition of HTMLVideoElement to
be available, which in turn is guarded by ENABLE(VIDEO).
- Source/cmake/WebKitFeatures.cmake: Make ENABLE_MEDIA_STREAM depend on ENABLE_VIDEO.
Tools:
When GStreamer usage is completely disabled at build time, CMake does not query pkg-config for the GStreamer.
This adds missing USE(GSTREAMER) guards in order to make testing code buildable when GStreamer usage is disabled.
- TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:
(methodCallCallback): Add missing USE(GSTREAMER) guard.
- 10:29 AM Changeset in webkit [220006] by
-
- 14 edits12 adds in trunk/Source/WebCore
[WebIDL] Split-up and cleanup Fetch IDL files in preparation for removing unnecessary js builtins
https://bugs.webkit.org/show_bug.cgi?id=174915
Patch by Sam Weinig <sam@webkit.org> on 2017-07-28
Reviewed by Alex Christensen.
- Split FetchRequest enums and Init dictionary out of FetchRequest so they can be used from other files like WorkerGlobalScopeFetch and DOMWindowFetch.
- Add missing FetchResponseInit. Currently unused but will be in a subsequent patch.
- Add and update comments about missing properties and functions.
- CMakeLists.txt:
- DerivedSources.make:
- WebCore.xcodeproj/project.pbxproj:
- Modules/fetch/DOMWindowFetch.idl:
- Modules/fetch/FetchBody.idl:
- Modules/fetch/FetchBodyOwner.h:
- Modules/fetch/FetchHeaders.h:
- Modules/fetch/FetchHeaders.idl:
- Modules/fetch/FetchReferrerPolicy.h: Added.
- Modules/fetch/FetchReferrerPolicy.idl: Added.
- Modules/fetch/FetchRequest.h:
- Modules/fetch/FetchRequest.idl:
- Modules/fetch/FetchRequestCache.h: Added.
- Modules/fetch/FetchRequestCache.idl: Added.
- Modules/fetch/FetchRequestCredentials.h: Added.
- Modules/fetch/FetchRequestCredentials.idl: Added.
- Modules/fetch/FetchRequestInit.h: Added.
- Modules/fetch/FetchRequestInit.idl: Added.
- Modules/fetch/FetchRequestMode.h: Added.
- Modules/fetch/FetchRequestMode.idl: Added.
- Modules/fetch/FetchRequestRedirect.h: Added.
- Modules/fetch/FetchRequestRedirect.idl: Added.
- Modules/fetch/FetchResponse.h:
- Modules/fetch/FetchResponse.idl:
- Modules/fetch/WorkerGlobalScopeFetch.idl:
- 10:28 AM Changeset in webkit [220005] by
-
- 2 edits in trunk/LayoutTests
The test imported/w3c/web-platform-tests/cors/allow-headers.htm is slow on Windows.
Unreviewed test gardening, mark test as slow.
- platform/win/TestExpectations:
- 10:27 AM Changeset in webkit [220004] by
-
- 28 edits in trunk/Source/WebInspectorUI
Web Inspector: Cleanup unused/invalid parameters for TreeElements
https://bugs.webkit.org/show_bug.cgi?id=173987
Reviewed by Brian Burg.
- UserInterface/Views/TreeElement.js:
- UserInterface/Views/GeneralTreeElement.js:
- UserInterface/Views/ApplicationCacheFrameTreeElement.js:
- UserInterface/Views/BreakpointTreeElement.js:
- UserInterface/Views/CSSStyleSheetTreeElement.js:
- UserInterface/Views/CallFrameTreeElement.js:
- UserInterface/Views/ContentFlowTreeElement.js:
- UserInterface/Views/DOMNodeTreeElement.js:
- UserInterface/Views/DatabaseTableTreeElement.js:
- UserInterface/Views/DatabaseTreeElement.js:
- UserInterface/Views/FolderTreeElement.js:
- UserInterface/Views/FolderizedTreeElement.js:
- UserInterface/Views/FrameTreeElement.js:
- UserInterface/Views/IndexedDatabaseObjectStoreIndexTreeElement.js:
- UserInterface/Views/IndexedDatabaseObjectStoreTreeElement.js:
- UserInterface/Views/IndexedDatabaseTreeElement.js:
- UserInterface/Views/IssueTreeElement.js:
- UserInterface/Views/ObjectTreeBaseTreeElement.js:
- UserInterface/Views/ProfileNodeTreeElement.js:
- UserInterface/Views/ResourceTreeElement.js:
- UserInterface/Views/ScriptTreeElement.js:
- UserInterface/Views/SearchResultTreeElement.js:
- UserInterface/Views/SourceCodeTreeElement.js:
- UserInterface/Views/SourceMapResourceTreeElement.js:
- UserInterface/Views/StorageTreeElement.js:
- UserInterface/Views/TimelineRecordTreeElement.js:
- UserInterface/Views/TypeTreeElement.js:
- 10:06 AM Changeset in webkit [220003] by
-
- 4 edits2 adds in trunk
REGRESSION(r216944): Fallback fonts erroneously visible when the primary font is loading
https://bugs.webkit.org/show_bug.cgi?id=174772
<rdar://problem/33267643>
Reviewed by Simon Fraser.
Source/WebCore:
During a font load, we try pretty hard to find a font to use that isn't the
last resort font (which happens to be Times). We do this by iterating through
all the fonts in the font-family list, as well as through all the relevant
@font-face blocks which share the requested font family name.
Unfortunately, if we find one of these fallback fonts, we were simply using it
directly, which means that it was being drawn as visible (because the
visibility setting lives inside the Font object). Instead, we should carry the
invisibility setting from the interstitial font to this used fallback font.
This patch is an extension of r219221, which fixed the problem only for system
fallback fonts. This patch adopts the same methodology to all fallback fonts.
Test: http/tests/webfont/font-loading-system-fallback-visibility-FontRanges.html
- platform/graphics/FontCascadeFonts.cpp:
(WebCore::FontCascadeFonts::glyphDataForVariant):
(WebCore::glyphPageFromFontRanges):
- platform/graphics/FontRanges.cpp:
(WebCore::FontRanges::glyphDataForCharacter):
LayoutTests:
- http/tests/webfont/font-loading-system-fallback-visibility-FontRanges-expected.html: Added.
- http/tests/webfont/font-loading-system-fallback-visibility-FontRanges.html: Added.
- 9:52 AM Changeset in webkit [220002] by
-
- 2 edits in trunk/LayoutTests
REGRESSION(r125147): Layout Test svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg is failing
https://bugs.webkit.org/show_bug.cgi?id=93589
Unreviewed test gardening, this test is also a flaky timeout on Windows.
- platform/win/TestExpectations:
- 8:38 AM Changeset in webkit [220001] by
-
- 6 edits in trunk/Source
Fix typo in scrollPositionChangedViaDelegatedScrolling
https://bugs.webkit.org/show_bug.cgi?id=174937
Patch by Frederic Wang <fwang@igalia.cpm> on 2017-07-28
Reviewed by Wenson Hsieh.
Source/WebCore:
No new tests, fix typo in the inUserInteraction parameter.
- page/scrolling/ScrollingTree.cpp:
(WebCore::ScrollingTree::scrollPositionChangedViaDelegatedScrolling):
- page/scrolling/ScrollingTree.h:
Source/WebKit:
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.h:
- UIProcess/Scrolling/ios/ScrollingTreeOverflowScrollingNodeIOS.mm:
(WebKit::ScrollingTreeOverflowScrollingNodeIOS::scrollViewDidScroll):
- 3:27 AM Changeset in webkit [220000] by
-
- 10 edits3 adds in trunk
[WPE] Implement EventSenderProxy in WTR
https://bugs.webkit.org/show_bug.cgi?id=173419
Reviewed by Žan Doberšek.
Add the implementation of EventSenderProxy to the WTR. This
allows us to extend the coverage of the test suite in WKWPE.
.:
- Source/cmake/FindLibxkbcommon.cmake: Added.
Tools:
- WebKitTestRunner/EventSenderProxy.h:
- WebKitTestRunner/PlatformWPE.cmake: Add dependency on
libxkbcommon needed to deal with key events.
- WebKitTestRunner/wpe/EventSenderProxyWPE.cpp:
(WTR::EventSenderProxy::EventSenderProxy):
(WTR::senderButtonToWPEButton):
(WTR::EventSenderProxy::mouseDown):
(WTR::EventSenderProxy::mouseUp):
(WTR::EventSenderProxy::mouseMoveTo):
(WTR::EventSenderProxy::mouseScrollBy):
(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):
(WTR::EventSenderProxy::leapForward):
(WTR::wkEventModifiersToWPE):
(WTR::getXKBKeySymForKeyRef):
(WTR::EventSenderProxy::keyDown):
(WTR::EventSenderProxy::addTouchPoint):
(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::setTouchModifier):
(WTR::EventSenderProxy::setTouchPointRadius):
(WTR::EventSenderProxy::getUpdatedTouchEvents):
(WTR::EventSenderProxy::removeUpdatedTouchEvents):
(WTR::EventSenderProxy::prepareAndDispatchTouchEvent):
(WTR::EventSenderProxy::touchStart):
(WTR::EventSenderProxy::touchMove):
(WTR::EventSenderProxy::touchEnd):
(WTR::EventSenderProxy::touchCancel):
(WTR::EventSenderProxy::clearTouchPoints):
(WTR::EventSenderProxy::releaseTouchPoint):
(WTR::EventSenderProxy::cancelTouchPoint):
LayoutTests:
- platform/wpe/TestExpectations: Unskip fast/events tests, marking failures
that are related to features not yet implemented in WPE. Also remove other
tests that are now passing thanks to having event injection.
- platform/wpe/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt: Update.
- platform/wpe/fast/dynamic/layer-hit-test-crash-expected.txt: Update.
- platform/wpe/fast/events/clientXY-in-zoom-and-scroll-expected.txt: Added.
- platform/wpe/ietestcenter/css3/bordersbackgrounds/background-attachment-local-scrolling-expected.txt: Update.
- 12:53 AM Changeset in webkit [219999] by
-
- 2 edits in trunk
Unreviewed. Bumping the patch version for WPEWebKit library to 20170728.
- Source/cmake/OptionsWPE.cmake:
- 12:31 AM Changeset in webkit [219998] by
-
- 3 edits in trunk/Source/WebCore
[iOS DnD] [WK1] Snapshots generated using -[DOMRange renderImageForcingBlackText:] are upside down
https://bugs.webkit.org/show_bug.cgi?id=174928
<rdar://problem/33584280>
Reviewed by Tim Horton.
Pulls the implementation of createDragImageForRange out into DragImageIOS, and use TextIndicator to generate a
snapshot instead of FrameSelection's snapshotting utilities. This makes snapshotting a DOMRange behave the same
way as snapshotting a dragged selection.
No way of testing TextIndicator-based snapshotting yet.
- platform/DragImage.cpp:
Guard createDragImageForRange for !PLATFORM(IOS).
- platform/ios/DragImageIOS.mm:
(WebCore::createDragImageForSelection):
Add a FIXME to point out that having an additional context flip inside the UIGraphicsImageRenderer block results
in an upside-down drag image being returned from createDragImageFromImage. This image is being flipped elsewhere
in drag initiation code, which eventually results in the correct orientation; we'll need further investigation
to remove this extraneous flip.
(WebCore::createDragImageForRange):
- 12:25 AM Changeset in webkit [219997] by
-
- 3 edits1 add in trunk
ASSERTION FAILED: candidate->op() == PhantomCreateRest candidate->op() == PhantomDirectArguments candidate->op() == PhantomClonedArguments candidate->op() == PhantomSpread candidate->op() == PhantomNewArrayWithSpread https://bugs.webkit.org/show_bug.cgi?id=174900
Reviewed by Saam Barati.
JSTests:
- stress/arguments-elimination-candidate-listings-should-respect-pseudo-terminals.js: Added.
(sideEffect):
(args):
(test):
Source/JavaScriptCore:
In the arguments elimination phase, due to high cost of AI, we intentionally do not run AI.
Instead, we use ForceOSRExit etc. (pseudo terminals) not to look into unreachable nodes.
The problem is that even transforming phase also checks this pseudo terminals.
BB1
1: ForceOSRExit
2: CreateDirectArguments
BB2
3: GetButterfly(@2)
4: ForceOSRExit
In the above case, @2 is not converted to PhantomDirectArguments. But @3 is processed. And the assertion fires.
In this patch, we do not list candidates up after seeing pseudo terminals in basic blocks.
- dfg/DFGArgumentsEliminationPhase.cpp:
- 12:25 AM Changeset in webkit [219996] by
-
- 24 edits26 moves2 adds2 deletes in trunk/Source
Remove Web prefix from WebVideoFullscreen and WebPlaybackSession classes.
https://bugs.webkit.org/show_bug.cgi?id=174437
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-07-28
Reviewed by Darin Adler.
Source/WebCore:
No new tests because no behavior change.
Remove redundant Web- prefix from classes in WebCore namespace.
- WebCore.xcodeproj/project.pbxproj:
- html/HTMLMediaElement.cpp:
- html/HTMLVideoElement.cpp:
- platform/cocoa/PlaybackSessionInterface.h: Renamed from Source/WebCore/platform/cocoa/WebPlaybackSessionInterface.h.
(WebCore::PlaybackSessionInterface::~PlaybackSessionInterface):
- platform/cocoa/PlaybackSessionModel.h: Renamed from Source/WebCore/platform/cocoa/WebPlaybackSessionModel.h.
(WebCore::PlaybackSessionModel::~PlaybackSessionModel):
(WebCore::PlaybackSessionModelClient::~PlaybackSessionModelClient):
(WebCore::PlaybackSessionModelClient::externalPlaybackChanged):
- platform/cocoa/PlaybackSessionModelMediaElement.h: Renamed from Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.h.
- platform/cocoa/PlaybackSessionModelMediaElement.mm: Renamed from Source/WebCore/platform/cocoa/WebPlaybackSessionModelMediaElement.mm.
- platform/cocoa/VideoFullscreenChangeObserver.h: Renamed from Source/WebCore/platform/cocoa/WebVideoFullscreenChangeObserver.h.
(WebCore::VideoFullscreenChangeObserver::~VideoFullscreenChangeObserver):
- platform/cocoa/VideoFullscreenModel.h: Renamed from Source/WebCore/platform/cocoa/WebVideoFullscreenModel.h.
(WebCore::VideoFullscreenModel::~VideoFullscreenModel):
(WebCore::VideoFullscreenModelClient::~VideoFullscreenModelClient):
- platform/cocoa/VideoFullscreenModelVideoElement.h: Renamed from Source/WebCore/platform/cocoa/WebVideoFullscreenModelVideoElement.h.
(WebCore::VideoFullscreenModelVideoElement::create):
- platform/cocoa/VideoFullscreenModelVideoElement.mm: Renamed from Source/WebCore/platform/cocoa/WebVideoFullscreenModelVideoElement.mm.
- platform/ios/PlaybackSessionInterfaceAVKit.h: Renamed from Source/WebCore/platform/ios/WebPlaybackSessionInterfaceAVKit.h.
- platform/ios/PlaybackSessionInterfaceAVKit.mm: Renamed from Source/WebCore/platform/ios/WebPlaybackSessionInterfaceAVKit.mm.
- platform/ios/VideoFullscreenInterfaceAVKit.h: Renamed from Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.h.
- platform/ios/VideoFullscreenInterfaceAVKit.mm: Renamed from Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm.
- platform/ios/WebAVPlayerController.h:
- platform/ios/WebAVPlayerController.mm:
- platform/ios/WebVideoFullscreenControllerAVKit.mm:
- platform/mac/PlaybackSessionInterfaceMac.h: Renamed from Source/WebCore/platform/mac/WebPlaybackSessionInterfaceMac.h.
- platform/mac/PlaybackSessionInterfaceMac.mm: Renamed from Source/WebCore/platform/mac/WebPlaybackSessionInterfaceMac.mm.
- platform/mac/VideoFullscreenInterfaceMac.h: Renamed from Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.h.
- platform/mac/VideoFullscreenInterfaceMac.mm: Renamed from Source/WebCore/platform/mac/WebVideoFullscreenInterfaceMac.mm.
- platform/mac/WebPlaybackControlsManager.h:
- platform/mac/WebPlaybackControlsManager.mm:
Source/WebKit:
Remove redundant Web- prefix from classes in WebKit namespace.
- DerivedSources.make:
- UIProcess/API/Cocoa/WKWebView.mm:
- UIProcess/Cocoa/PlaybackSessionManagerProxy.h: Renamed from Source/WebKit/UIProcess/Cocoa/WebPlaybackSessionManagerProxy.h.
- UIProcess/Cocoa/PlaybackSessionManagerProxy.messages.in: Renamed from Source/WebKit/UIProcess/Cocoa/WebPlaybackSessionManagerProxy.messages.in.
- UIProcess/Cocoa/PlaybackSessionManagerProxy.mm: Added.
- UIProcess/Cocoa/VideoFullscreenManagerProxy.h: Renamed from Source/WebKit/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.h.
- UIProcess/Cocoa/VideoFullscreenManagerProxy.messages.in: Renamed from Source/WebKit/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.messages.in.
- UIProcess/Cocoa/VideoFullscreenManagerProxy.mm: Renamed from Source/WebKit/UIProcess/Cocoa/WebVideoFullscreenManagerProxy.mm.
- UIProcess/Cocoa/WebPlaybackSessionManagerProxy.mm: Removed.
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::updateMediaTouchBar):
- UIProcess/WebPageProxy.cpp:
(WebKit::m_weakPtrFactory):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::playbackSessionManager):
(WebKit::WebPageProxy::videoFullscreenManager):
- UIProcess/WebPageProxy.h:
- UIProcess/ios/WebPageProxyIOS.mm:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebChromeClient.cpp:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::playbackSessionManager):
(WebKit::WebPage::videoFullscreenManager):
- WebProcess/WebPage/WebPage.h:
- WebProcess/cocoa/PlaybackSessionManager.h: Renamed from Source/WebKit/WebProcess/cocoa/WebPlaybackSessionManager.h.
- WebProcess/cocoa/PlaybackSessionManager.messages.in: Renamed from Source/WebKit/WebProcess/cocoa/WebPlaybackSessionManager.messages.in.
- WebProcess/cocoa/PlaybackSessionManager.mm: Added.
- WebProcess/cocoa/VideoFullscreenManager.h: Renamed from Source/WebKit/WebProcess/cocoa/WebVideoFullscreenManager.h.
(WebKit::VideoFullscreenInterfaceContext::create):
- WebProcess/cocoa/VideoFullscreenManager.messages.in: Renamed from Source/WebKit/WebProcess/cocoa/WebVideoFullscreenManager.messages.in.
- WebProcess/cocoa/VideoFullscreenManager.mm: Renamed from Source/WebKit/WebProcess/cocoa/WebVideoFullscreenManager.mm.
- WebProcess/cocoa/WebPlaybackSessionManager.mm: Removed.
Source/WebKitLegacy/mac:
Remove redundant Web- prefix from classes in WebKit namespace.
- WebView/WebView.mm:
(-[WebView _setUpPlaybackControlsManagerForMediaElement:]):
- WebView/WebViewData.h:
- WebView/WebViewData.mm:
Jul 27, 2017:
- 10:49 PM Changeset in webkit [219995] by
-
- 2 edits in trunk/Source/WebKit
[CMake] Re-add the StorageProcess executable target
https://bugs.webkit.org/show_bug.cgi?id=174929
Reviewed by Carlos Garcia Campos.
Re-add the StorageProcess executable target that was removed in r219960.
Back then it was still named DatabaseProcess, but the name changed in
the following patches.
- CMakeLists.txt:
- 10:11 PM Changeset in webkit [219994] by
-
- 10 edits in trunk/Source/WTF
[WTF] Drop Thread initialization wait in some platforms by introducing StackBounds::newThreadStackBounds(PlatformThreadHandle&)
https://bugs.webkit.org/show_bug.cgi?id=174303
Reviewed by Mark Lam.
Currently, the caller thread of Thread::create() need to wait for completion of the initialization of the target thread.
This is because we need to initialize Thread::m_stack in the target thread. Before this patch, a target thread's
StackBounds can only be retrieved by the target thread itself. However, this potentially causes context-switching between
the caller and the target threads and hurts efficiency of creating threads.
Fortunately, in some platforms (including major platforms except for Windows), we can get StackBounds of a target
thread from a caller thread. This allows us to avoid waiting for completion of thread initialization.
In this patch, we introduce HAVE_STACK_BOUNDS_FOR_NEW_THREAD and StackBounds::newThreadStackBounds. When creating
a new thread, we will use StackBounds::newThreadStackBounds to get StackBounds if possible. As a result, we
do not need to wait for completion of thread initialization to ensure m_stack field of Thread is initialized.
While some documents claim that it is possible on Windows to get the StackBounds of another thread[1], the method relies on
undocumented Windows NT APIs (NtQueryInformationThread, NtReadVirtualMemory etc.). So in this patch, we just
use the conservative approach simply waiting for completion of thread initialization.
[1]: https://stackoverflow.com/questions/3918375/how-to-get-thread-stack-information-on-windows
- wtf/Platform.h:
- wtf/StackBounds.cpp:
(WTF::StackBounds::newThreadStackBounds):
(WTF::StackBounds::currentThreadStackBoundsInternal):
(WTF::StackBounds::initialize): Deleted.
- wtf/StackBounds.h:
(WTF::StackBounds::currentThreadStackBounds):
(WTF::StackBounds::StackBounds):
- wtf/Threading.cpp:
(WTF::Thread::NewThreadContext::NewThreadContext):
(WTF::Thread::entryPoint):
(WTF::Thread::create):
(WTF::Thread::initialize): Deleted.
- wtf/Threading.h:
- wtf/ThreadingPrimitives.h:
- wtf/ThreadingPthreads.cpp:
(WTF::Thread::initializeCurrentThreadEvenIfNonWTFCreated):
(WTF::wtfThreadEntryPoint):
(WTF::Thread::establishHandle):
(WTF::Thread::initializeCurrentThreadInternal):
(WTF::Thread::current):
- wtf/ThreadingWin.cpp:
(WTF::Thread::initializeCurrentThreadEvenIfNonWTFCreated):
(WTF::Thread::initializeCurrentThreadInternal):
(WTF::Thread::current):
- wtf/win/MainThreadWin.cpp:
(WTF::initializeMainThreadPlatform):
- 9:44 PM Changeset in webkit [219993] by
-
- 7 edits1 move4 adds4 deletes in trunk/PerformanceTests
Speedometer 2.0: Document Angular 4 build process
https://bugs.webkit.org/show_bug.cgi?id=174896
Patch by Mathias Bynens <mathias@chromium.org> on 2017-07-27
Reviewed by Ryosuke Niwa.
This patch documents the build process for the Angular 4 example, pins the dependencies (so
that builds are deterministic), and updates the generated files accordingly.
- Speedometer/resources/todomvc/architecture-examples/angular/README.md: Added.
- Speedometer/resources/todomvc/architecture-examples/angular/dist/*: Update per build instructions.
- Speedometer/resources/todomvc/architecture-examples/angular/e2e/app.e2e-spec.ts: Removed unused file.
- Speedometer/resources/todomvc/architecture-examples/angular/e2e/app.po.ts: Removed unused file.
- Speedometer/resources/todomvc/architecture-examples/angular/e2e/tsconfig.e2e.json: Removed unused file.
- Speedometer/resources/todomvc/architecture-examples/angular/package.json: Remove unneeded scripts.
- Speedometer/resources/todomvc/architecture-examples/angular/package-lock.json: Added to pin dependencies.
- Speedometer/resources/todomvc/architecture-examples/angular/src/app/app.component.ts: Updated.
- Speedometer/resources/todomvc/architecture-examples/angular/src/environments/environment.ts: Updated.
- Speedometer/resources/todomvc/architecture-examples/angular/src/index.html: Made title consistent.
- 9:41 PM Changeset in webkit [219992] by
-
- 3 edits in trunk/Source/WebCore
Don't override _allowsMediaDocumentInlinePlayback in MediaDocument with playsinlineAttr.
https://bugs.webkit.org/show_bug.cgi?id=174850
rdar://problem/33449903
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-07-27
Reviewed by Jon Lee.
This change removes playsinlineAttr from MediaDocument so that it doesn't override the setting
from _allowsMediaDocumentInlinePlayback. In its place is an update to requiresFullscreenForVideoPlayback
that implements the details of exactly which media documents are still allowed to play inlne.
Media documents always use a video element; but when there are no video tracks, it has behavior like
an audio element. See media-controller.js isAudio().
This change preserves this behavior with respect to fullscreen requirements for media document by
mirroring the isAudio() check in requiresFullscreenForVideoPlayback.
- html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):
- html/MediaElementSession.cpp:
(WebCore::MediaElementSession::requiresFullscreenForVideoPlayback):
- 9:20 PM Changeset in webkit [219991] by
-
- 2 edits in trunk/Source/WebCore
MediaDocument fullscreen pinch gesture should trigger navigate back.
https://bugs.webkit.org/show_bug.cgi?id=174914
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-07-27
Reviewed by Jon Lee.
No new tests because only effect is from interaction with platform.
For media documents, pressing the "done" button on fullscreen video navigates back
to the previous page. The same should happen for other gestures that pause playback
when returning to inline. This allows the gesture to have the same behavior as the
button.
- platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::shouldExitFullscreenWithReason):
- 8:32 PM Changeset in webkit [219990] by
-
- 52 edits in trunk
Part 2 of: Rename DatabaseProcess to StorageProcess.
https://bugs.webkit.org/show_bug.cgi?id=174880
Reviewed by Andy Estes.
Source/WebKit:
Rename some more variables, classes, etc. to reflect the change.
- NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::writeBlobsToTemporaryFiles):
- NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::grantSandboxExtensionsToStorageProcessForBlobs):
(WebKit::NetworkProcess::didgrantSandboxExtensionsToStorageProcessForBlobs):
(WebKit::NetworkProcess::grantSandboxExtensionsToDatabaseProcessForBlobs): Deleted.
(WebKit::NetworkProcess::didGrantSandboxExtensionsToDatabaseProcessForBlobs): Deleted.
- NetworkProcess/NetworkProcess.h:
- NetworkProcess/NetworkProcess.messages.in:
- Shared/ProcessExecutablePath.h:
- Shared/gtk/ProcessExecutablePathGtk.cpp:
(WebKit::executablePathOfStorageProcess):
(WebKit::executablePathOfDatabaseProcess): Deleted.
- Shared/wpe/ProcessExecutablePathWPE.cpp:
(WebKit::executablePathOfStorageProcess):
(WebKit::executablePathOfDatabaseProcess): Deleted.
- StorageProcess/IndexedDB/WebIDBConnectionToClient.cpp:
(WebKit::WebIDBConnectionToClient::putOrAdd):
- StorageProcess/StorageProcess.cpp:
(WebKit::StorageProcess::initializeWebsiteDataStore):
(WebKit::StorageProcess::postStorageTask):
(WebKit::StorageProcess::performNextStorageTask):
(WebKit::StorageProcess::createStorageToWebProcessConnection):
(WebKit::StorageProcess::fetchWebsiteData):
(WebKit::StorageProcess::postDatabaseTask): Deleted.
(WebKit::StorageProcess::performNextDatabaseTask): Deleted.
(WebKit::StorageProcess::createDatabaseToWebProcessConnection): Deleted.
- StorageProcess/StorageProcess.h:
- StorageProcess/StorageProcess.messages.in:
- StorageProcess/mac/StorageProcessMac.mm:
(WebKit::StorageProcess::initializeProcessName):
- UIProcess/API/C/WKContext.cpp:
(WKContextGetDatabaseProcessIdentifier):
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _terminateStorageProcess]):
(-[WKProcessPool _storageProcessIdentifier]):
(-[WKProcessPool _terminateDatabaseProcess]): Deleted.
(-[WKProcessPool _databaseProcessIdentifier]): Deleted.
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/Launcher/ProcessLauncher.h:
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::serviceName):
- UIProcess/Launcher/wpe/ProcessLauncherWPE.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::grantSandboxExtensionsToStorageProcessForBlobs):
(WebKit::NetworkProcessProxy::grantSandboxExtensionsToDatabaseProcessForBlobs): Deleted.
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Network/NetworkProcessProxy.messages.in:
- UIProcess/Storage/StorageProcessProxy.cpp:
(WebKit::StorageProcessProxy::getLaunchOptions):
(WebKit::StorageProcessProxy::getStorageProcessConnection):
(WebKit::StorageProcessProxy::didClose):
(WebKit::StorageProcessProxy::didCreateStorageToWebProcessConnection):
(WebKit::StorageProcessProxy::didFinishLaunching):
(WebKit::StorageProcessProxy::getDatabaseProcessConnection): Deleted.
(WebKit::StorageProcessProxy::didCreateDatabaseToWebProcessConnection): Deleted.
- UIProcess/Storage/StorageProcessProxy.h:
- UIProcess/Storage/StorageProcessProxy.messages.in:
- UIProcess/WebContextClient.cpp:
(WebKit::WebContextClient::storageProcessDidCrash):
(WebKit::WebContextClient::databaseProcessDidCrash): Deleted.
- UIProcess/WebContextClient.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureStorageProcessAndWebsiteDataStore):
(WebKit::WebProcessPool::getStorageProcessConnection):
(WebKit::WebProcessPool::storageProcessCrashed):
(WebKit::WebProcessPool::pageAddedToProcess):
(WebKit::WebProcessPool::storageProcessIdentifier):
(WebKit::WebProcessPool::terminateStorageProcess):
(WebKit::WebProcessPool::ensureDatabaseProcessAndWebsiteDataStore): Deleted.
(WebKit::WebProcessPool::getDatabaseProcessConnection): Deleted.
(WebKit::WebProcessPool::databaseProcessCrashed): Deleted.
(WebKit::WebProcessPool::databaseProcessIdentifier): Deleted.
(WebKit::WebProcessPool::terminateDatabaseProcess): Deleted.
- UIProcess/WebProcessPool.h:
(WebKit::WebProcessPool::sendToStorageProcessRelaunchingIfNecessary):
(WebKit::WebProcessPool::sendToDatabaseProcessRelaunchingIfNecessary): Deleted.
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getStorageProcessConnection):
(WebKit::WebProcessProxy::getDatabaseProcessConnection): Deleted.
- UIProcess/WebProcessProxy.h:
- UIProcess/WebProcessProxy.messages.in:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchDataAndApply):
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::storageProcessParameters):
(WebKit::WebsiteDataStore::databaseProcessParameters): Deleted.
- UIProcess/WebsiteData/WebsiteDataStore.h:
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
(WebKit::WebIDBConnectionToServer::messageSenderConnection):
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
- WebProcess/Databases/WebDatabaseProvider.cpp:
(WebKit::WebDatabaseProvider::idbConnectionToServerForSession):
- WebProcess/Storage/WebToStorageProcessConnection.cpp:
(WebKit::WebToStorageProcessConnection::WebToStorageProcessConnection):
(WebKit::WebToStorageProcessConnection::~WebToStorageProcessConnection):
(WebKit::WebToStorageProcessConnection::didReceiveMessage):
(WebKit::WebToStorageProcessConnection::didClose):
(WebKit::WebToStorageProcessConnection::didReceiveInvalidMessage):
(WebKit::WebToStorageProcessConnection::idbConnectionToServerForSession):
(WebKit::WebToDatabaseProcessConnection::WebToDatabaseProcessConnection): Deleted.
(WebKit::WebToDatabaseProcessConnection::~WebToDatabaseProcessConnection): Deleted.
(WebKit::WebToDatabaseProcessConnection::didReceiveMessage): Deleted.
(WebKit::WebToDatabaseProcessConnection::didClose): Deleted.
(WebKit::WebToDatabaseProcessConnection::didReceiveInvalidMessage): Deleted.
(WebKit::WebToDatabaseProcessConnection::idbConnectionToServerForSession): Deleted.
- WebProcess/Storage/WebToStorageProcessConnection.h:
(WebKit::WebToStorageProcessConnection::create):
(WebKit::WebToDatabaseProcessConnection::create): Deleted.
(WebKit::WebToDatabaseProcessConnection::connection): Deleted.
- WebProcess/WebProcess.cpp:
(WebKit::WebProcess::webToStorageProcessConnectionClosed):
(WebKit::WebProcess::webToStorageProcessConnection):
(WebKit::WebProcess::ensureWebToStorageProcessConnection):
(WebKit::WebProcess::webToDatabaseProcessConnectionClosed): Deleted.
(WebKit::WebProcess::webToDatabaseProcessConnection): Deleted.
(WebKit::WebProcess::ensureWebToDatabaseProcessConnection): Deleted.
- WebProcess/WebProcess.h:
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/IDBDeleteRecovery.mm:
- TestWebKitAPI/Tests/WebKit2Cocoa/IDBIndexUpgradeToV2.mm:
- TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBDatabaseProcessKill.mm:
- TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBMultiProcess.mm:
- TestWebKitAPI/Tests/WebKit2Cocoa/IndexedDBPersistence.mm:
- TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
- TestWebKitAPI/Tests/WebKit2Cocoa/WebProcessKillIDBCleanup.mm:
- TestWebKitAPI/Tests/WebKit2Cocoa/WebsiteDataStoreCustomPaths.mm:
- 7:38 PM Changeset in webkit [219989] by
-
- 6 edits1 add in trunk
[ES] Add support finally to Promise
https://bugs.webkit.org/show_bug.cgi?id=174503
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
Add support
finallymethod to Promise according
to the https://bugs.webkit.org/show_bug.cgi?id=174503
Current spec on STAGE 3
https://github.com/tc39/proposal-promise-finally
- builtins/PromisePrototype.js:
(finally):
(const.valueThunk):
(globalPrivate.getThenFinally):
(const.thrower):
(globalPrivate.getCatchFinally):
- runtime/JSPromisePrototype.cpp:
LayoutTests:
- js/Promise-types-expected.txt:
- js/script-tests/Promise-types.js:
- 7:17 PM Changeset in webkit [219988] by
-
- 5 edits in trunk/Source/WTF
Update lock benchmarks
https://bugs.webkit.org/show_bug.cgi?id=174907
Reviewed by Filip Pizlo.
- benchmarks/ConditionSpeedTest.cpp:
(main):
- benchmarks/LockFairnessTest.cpp:
- benchmarks/LockSpeedTest.cpp:
- benchmarks/ToyLocks.h:
- 4:46 PM Changeset in webkit [219987] by
-
- 2 edits in trunk/Source/WebKit
AX: A11Y: Zoom no longer follows keyboard insertion point in safari
https://bugs.webkit.org/show_bug.cgi?id=174869
Reviewed by David Kilzer.
There was a recent change by denying XPC services access by default.
In UAZoomChangeFocus we need to send message to HIServices, so let's
allow the connection to XPC services for that.
- WebProcess/com.apple.WebProcess.sb.in:
- 4:08 PM Changeset in webkit [219986] by
-
- 22 edits21 copies7 moves14 adds2 deletes in trunk
Part 1 of: Rename DatabaseProcess to StorageProcess.
https://bugs.webkit.org/show_bug.cgi?id=174879
Reviewed by Andy Estes.
.:
- Source/cmake/OptionsWPE.cmake:
- Source/cmake/gtksymbols.filter:
Source/WebKit:
This patch is all about renaming source files and renaming the process itself (touching build system files, etc etc).
Some renaming in actual code did result (Some class/struct names, method names, etc)
Part 2 (174880) will go through and update all references in code itself from "Database" to "Storage"
- CMakeLists.txt:
- Configurations/Storage-iOS.entitlements: Renamed from Source/WebKit/Configurations/Databases-iOS.entitlements.
- Configurations/StorageService.xcconfig: Renamed from Source/WebKit/Configurations/DatabaseService.xcconfig.
- Configurations/WebKit.xcconfig:
- DerivedSources.make:
- Platform/ExtraPrivateSymbolsForTAPI.h:
- PlatformGTK.cmake:
- PlatformMac.cmake:
- PlatformWPE.cmake:
- Resources/SandboxProfiles/ios/com.apple.WebKit.Storage.sb: Renamed from Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.Databases.sb.
- Shared/Storage/StorageProcessCreationParameters.cpp: Renamed from Source/WebKit/Shared/Databases/DatabaseProcessCreationParameters.cpp.
(WebKit::StorageProcessCreationParameters::StorageProcessCreationParameters):
(WebKit::StorageProcessCreationParameters::encode):
(WebKit::StorageProcessCreationParameters::decode):
- Shared/Storage/StorageProcessCreationParameters.h: Renamed from Source/WebKit/Shared/Databases/DatabaseProcessCreationParameters.h.
- StorageProcess/EntryPoint/mac/XPCService/StorageService/Info.plist: Renamed from Source/WebKit/DatabaseProcess/EntryPoint/mac/XPCService/DatabaseService/Info.plist.
- StorageProcess/EntryPoint/mac/XPCService/StorageServiceEntryPoint.mm: Renamed from Source/WebKit/DatabaseProcess/EntryPoint/mac/XPCService/DatabaseServiceEntryPoint.mm.
(StorageServiceInitializer):
- StorageProcess/EntryPoint/unix/StorageProcessMain.cpp: Renamed from Source/WebKit/DatabaseProcess/EntryPoint/unix/DatabaseProcessMain.cpp.
(main):
- StorageProcess/IndexedDB/WebIDBConnectionToClient.cpp: Renamed from Source/WebKit/DatabaseProcess/IndexedDB/WebIDBConnectionToClient.cpp.
- StorageProcess/IndexedDB/WebIDBConnectionToClient.h: Renamed from Source/WebKit/DatabaseProcess/IndexedDB/WebIDBConnectionToClient.h.
- StorageProcess/IndexedDB/WebIDBConnectionToClient.messages.in: Renamed from Source/WebKit/DatabaseProcess/IndexedDB/WebIDBConnectionToClient.messages.in.
- StorageProcess/StorageProcess.cpp: Renamed from Source/WebKit/DatabaseProcess/DatabaseProcess.cpp.
- StorageProcess/StorageProcess.h: Renamed from Source/WebKit/DatabaseProcess/DatabaseProcess.h.
- StorageProcess/StorageProcess.messages.in: Renamed from Source/WebKit/DatabaseProcess/DatabaseProcess.messages.in.
- StorageProcess/StorageToWebProcessConnection.cpp: Renamed from Source/WebKit/DatabaseProcess/DatabaseToWebProcessConnection.cpp.
- StorageProcess/StorageToWebProcessConnection.h: Renamed from Source/WebKit/DatabaseProcess/DatabaseToWebProcessConnection.h.
- StorageProcess/StorageToWebProcessConnection.messages.in: Renamed from Source/WebKit/DatabaseProcess/DatabaseToWebProcessConnection.messages.in.
- StorageProcess/gtk/StorageProcessMainGtk.cpp: Renamed from Source/WebKit/DatabaseProcess/gtk/DatabaseProcessMainGtk.cpp.
(WebKit::StorageProcessMainUnix):
- StorageProcess/ios/StorageProcessIOS.mm: Renamed from Source/WebKit/DatabaseProcess/ios/DatabaseProcessIOS.mm.
(WebKit::StorageProcess::initializeProcess):
(WebKit::StorageProcess::initializeProcessName):
(WebKit::StorageProcess::initializeSandbox):
- StorageProcess/mac/StorageProcessMac.mm: Renamed from Source/WebKit/DatabaseProcess/mac/DatabaseProcessMac.mm.
(WebKit::StorageProcess::initializeProcess):
(WebKit::StorageProcess::initializeProcessName):
(WebKit::StorageProcess::initializeSandbox):
- StorageProcess/mac/com.apple.WebKit.Databases.sb.in: Copied from Source/WebKit/DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in.
- StorageProcess/mac/com.apple.WebKit.Storage.sb.in: Renamed from Source/WebKit/DatabaseProcess/mac/com.apple.WebKit.Databases.sb.in.
- StorageProcess/unix/StorageProcessMainUnix.h: Renamed from Source/WebKit/DatabaseProcess/unix/DatabaseProcessMainUnix.h.
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::serviceName):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::grantSandboxExtensionsToDatabaseProcessForBlobs):
- UIProcess/Storage/StorageProcessProxy.cpp: Renamed from Source/WebKit/UIProcess/Databases/DatabaseProcessProxy.cpp.
- UIProcess/Storage/StorageProcessProxy.h: Renamed from Source/WebKit/UIProcess/Databases/DatabaseProcessProxy.h.
- UIProcess/Storage/StorageProcessProxy.messages.in: Renamed from Source/WebKit/UIProcess/Databases/DatabaseProcessProxy.messages.in.
- UIProcess/WebContextSupplement.h:
(WebKit::WebContextSupplement::processDidClose):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::ensureDatabaseProcessAndWebsiteDataStore):
(WebKit::WebProcessPool::databaseProcessCrashed):
(WebKit::WebProcessPool::pageAddedToProcess):
- UIProcess/WebProcessPool.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::databaseProcessParameters):
- UIProcess/WebsiteData/WebsiteDataStore.h:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
(WebKit::WebIDBConnectionToServer::WebIDBConnectionToServer):
(WebKit::WebIDBConnectionToServer::~WebIDBConnectionToServer):
- WebProcess/Databases/WebDatabaseProvider.cpp:
- WebProcess/Storage/WebToStorageProcessConnection.cpp: Renamed from Source/WebKit/WebProcess/Databases/WebToDatabaseProcessConnection.cpp.
- WebProcess/Storage/WebToStorageProcessConnection.h: Renamed from Source/WebKit/WebProcess/Databases/WebToDatabaseProcessConnection.h.
- WebProcess/WebProcess.cpp:
- 10:06 AM Changeset in webkit [219985] by
-
- 3 edits in trunk/Source/WebKit
PDF page number indicator is very flashy when scrolling
https://bugs.webkit.org/show_bug.cgi?id=174882
<rdar://problem/23760981>
Reviewed by Andy Estes.
- Platform/spi/ios/UIKitSPI.h:
- UIProcess/ios/WKPDFPageNumberIndicator.mm:
(-[WKPDFPageNumberIndicator initWithFrame:]):
Increase the backdrop rendering resolution to reduce flashiness.
It's still not perfect, but it's quite visibly better.
- 9:48 AM Changeset in webkit [219984] by
-
- 2 edits in trunk/Tools
Add ability to only run specific tests in run-javascriptcore-tests.
https://bugs.webkit.org/show_bug.cgi?id=174884
Reviewed by Saam Barati.
For example, if we only want to run testapi, we can do so as follows:
$ run-javascriptcore-tests --testapi
Previously, specifying --testapi effectively does nothing because we run all tests
by default. Only --no-testapi had the effect of disabling the test set. This
old behavior for --testapi is not very useful or meaningful. We're now changing
it to mean that we will only run that test.
With this change, we can also run more than one set of tests. For example, if we
only want to run testmasm and testair, we can do so as follows:
$ run-javascriptcore-tests --testmasm --testair
By default, if no specific test option is specified, run-javascriptcore-tests will
run all tests.
Note that the jsc stress tests (--jsc-stress) are a different set of tests than
the mozilla tests (--mozilla-tests) even though both are run via the lower level
run-jsc-stress-tests test harness. Hence, if you only specify one of the tests,
the other set will not run. For example, the following only runs the mozilla tests:
$ run-javascriptcore-tests --mozilla-tests
Note also that --jit-stress-tests is not for choosing a different set of tests.
Instead, it is used for determining whether we run JIT'ed test configurations
on the jsc stress tests and mozilla tests. As a result, specifying
--jit-stress-tests will not omit other tests. For example, the following still
runs all tests:
$ run-javascriptcore-tests --jit-stress-tests
- Scripts/run-javascriptcore-tests:
(defaultStringForTestState):
(enableTestOrNot):
(runJSCStressTests):
- 7:53 AM Changeset in webkit [219983] by
-
- 7 edits2 copies in trunk
AX: VoiceOver silent or skipping over time values on media player.
https://bugs.webkit.org/show_bug.cgi?id=174324
<rdar://problem/32021784>
Patch by Aaron Chu <aaron_chu@apple.com> on 2017-07-27
Reviewed by Antoine Quint.
Added role attribute to modern media controls time lable class so that VoiceOver can access the time label when the media is playing.
Source/WebCore:
Test Updated: media/modern-media-controls/time-label/time-label.html
Test Added: media/modern-media-controls/time-label/ios-time-label.html
- Modules/modern-media-controls/controls/time-label.js:
LayoutTests:
Updated time-label.html to test role attribute on mac.
Added ios-time-label.html to run time-label test without testing for role since accessibilityController does not expose a role property on iOS.
- media/modern-media-controls/time-label/ios-time-label-expected.txt: Copied from LayoutTests/media/modern-media-controls/time-label/time-label-expected.txt.
- media/modern-media-controls/time-label/ios-time-label.html: Copied from LayoutTests/media/modern-media-controls/time-label/time-label.html.
- media/modern-media-controls/time-label/time-label-expected.txt:
- media/modern-media-controls/time-label/time-label.html:
- platform/ios-simulator/TestExpectations:
- platform/mac/TestExpectations:
- 6:00 AM Changeset in webkit [219982] by
-
- 2 edits in trunk/Source/JavaScriptCore
Unreviewed, build fix for CLoop
https://bugs.webkit.org/show_bug.cgi?id=171637
- domjit/DOMJITGetterSetter.h:
- 5:35 AM Changeset in webkit [219981] by
-
- 109 edits2 copies4 adds in trunk
Hoist DOM binding attribute getter prologue into JavaScriptCore taking advantage of DOMJIT / CheckSubClass
https://bugs.webkit.org/show_bug.cgi?id=171637
Reviewed by Darin Adler.
JSTests:
- stress/domjit-getter-complex-with-incorrect-object.js:
(i.shouldThrow):
- stress/domjit-getter-type-check.js: Copied from JSTests/stress/domjit-getter-complex-with-incorrect-object.js.
(shouldBe):
(i.shouldThrow):
Source/JavaScriptCore:
Each DOM attribute getter has the code to perform ClassInfo check. But it is largely duplicate and causes code bloating.
In this patch, we move ClassInfo check from WebCore to JSC and reduce code size.
We introduce DOMAnnotation which has ClassInfo* and DOMJIT::GetterSetter*. If the getter is not DOMJIT getter, this
DOMJIT::GetterSetter becomes nullptr. We support such a CustomAccessorGetter in all the JIT tiers.
In IC, we drop CheckSubClass completely since IC's Structure check subsumes it. We do not enable this optimization for
op_get_by_id_with_this case yet.
In DFG and FTL, we emit CheckSubClass node. Which is typically removed by CheckStructure leading to CheckSubClass.
And we add DOMAttributeGetterSetter, which is derived class of CustomGetterSetter. It holds DOMAnnotation and perform
ClassInfo check.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- bytecode/AccessCase.cpp:
(JSC::AccessCase::generateImpl):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback):
- bytecode/GetByIdVariant.cpp:
(JSC::GetByIdVariant::GetByIdVariant):
(JSC::GetByIdVariant::operator=):
(JSC::GetByIdVariant::attemptToMerge):
(JSC::GetByIdVariant::dumpInContext):
- bytecode/GetByIdVariant.h:
(JSC::GetByIdVariant::customAccessorGetter):
(JSC::GetByIdVariant::domAttribute):
(JSC::GetByIdVariant::domJIT): Deleted.
- bytecode/GetterSetterAccessCase.cpp:
(JSC::GetterSetterAccessCase::create):
(JSC::GetterSetterAccessCase::GetterSetterAccessCase):
(JSC::GetterSetterAccessCase::emitDOMJITGetter):
- bytecode/GetterSetterAccessCase.h:
(JSC::GetterSetterAccessCase::domAttribute):
(JSC::GetterSetterAccessCase::customAccessor):
(JSC::GetterSetterAccessCase::domJIT): Deleted.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::instantiateLexicalVariables):
- create_hash_table:
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::blessCallDOMGetter):
(JSC::DFG::ByteCodeParser::handleDOMJITGetter):
(JSC::DFG::ByteCodeParser::handleGetById):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
- dfg/DFGNode.h:
- dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileCallDOMGetter):
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callCustomGetter):
- domjit/DOMJITGetterSetter.h:
(JSC::DOMJIT::GetterSetter::GetterSetter):
(JSC::DOMJIT::GetterSetter::getter):
(JSC::DOMJIT::GetterSetter::compiler):
(JSC::DOMJIT::GetterSetter::resultType):
(JSC::DOMJIT::GetterSetter::~GetterSetter): Deleted.
(JSC::DOMJIT::GetterSetter::setter): Deleted.
(JSC::DOMJIT::GetterSetter::thisClassInfo): Deleted.
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileCallDOMGetter):
- jit/Repatch.cpp:
(JSC::tryCacheGetByID):
- jsc.cpp:
(WTF::DOMJITGetter::DOMJITAttribute::DOMJITAttribute):
(WTF::DOMJITGetter::DOMJITAttribute::callDOMGetter):
(WTF::DOMJITGetter::customGetter):
(WTF::DOMJITGetter::finishCreation):
(WTF::DOMJITGetterComplex::DOMJITAttribute::DOMJITAttribute):
(WTF::DOMJITGetterComplex::DOMJITAttribute::callDOMGetter):
(WTF::DOMJITGetterComplex::customGetter):
(WTF::DOMJITGetterComplex::finishCreation):
(WTF::DOMJITGetter::DOMJITNodeDOMJIT::DOMJITNodeDOMJIT): Deleted.
(WTF::DOMJITGetter::DOMJITNodeDOMJIT::slowCall): Deleted.
(WTF::DOMJITGetter::domJITNodeGetterSetter): Deleted.
(WTF::DOMJITGetterComplex::DOMJITNodeDOMJIT::DOMJITNodeDOMJIT): Deleted.
(WTF::DOMJITGetterComplex::DOMJITNodeDOMJIT::slowCall): Deleted.
(WTF::DOMJITGetterComplex::domJITNodeGetterSetter): Deleted.
- runtime/CustomGetterSetter.h:
(JSC::CustomGetterSetter::create):
(JSC::CustomGetterSetter::setter):
(JSC::CustomGetterSetter::CustomGetterSetter):
(): Deleted.
- runtime/DOMAnnotation.h: Added.
(JSC::operator==):
(JSC::operator!=):
- runtime/DOMAttributeGetterSetter.cpp: Added.
- runtime/DOMAttributeGetterSetter.h: Copied from Source/JavaScriptCore/runtime/CustomGetterSetter.h.
(JSC::isDOMAttributeGetterSetter):
- runtime/Error.cpp:
(JSC::throwDOMAttributeGetterTypeError):
- runtime/Error.h:
(JSC::throwVMDOMAttributeGetterTypeError):
- runtime/JSCustomGetterSetterFunction.cpp:
(JSC::JSCustomGetterSetterFunction::customGetterSetterFunctionCall):
- runtime/JSObject.cpp:
(JSC::JSObject::putInlineSlow):
(JSC::JSObject::deleteProperty):
(JSC::JSObject::getOwnStaticPropertySlot):
(JSC::JSObject::reifyAllStaticProperties):
(JSC::JSObject::fillGetterPropertySlot):
(JSC::JSObject::findPropertyHashEntry): Deleted.
- runtime/JSObject.h:
(JSC::JSObject::getOwnNonIndexPropertySlot):
(JSC::JSObject::fillCustomGetterPropertySlot):
- runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
- runtime/Lookup.h:
(JSC::HashTableValue::domJIT):
(JSC::getStaticPropertySlotFromTable):
(JSC::putEntry):
(JSC::lookupPut):
(JSC::reifyStaticProperty):
(JSC::reifyStaticProperties):
Each static property table has a new field ClassInfo*. It indicates that which ClassInfo check DOMAttribute registered in
this static property table requires.
- runtime/ProgramExecutable.cpp:
(JSC::ProgramExecutable::initializeGlobalProperties):
- runtime/PropertyName.h:
- runtime/PropertySlot.cpp:
(JSC::PropertySlot::customGetter):
(JSC::PropertySlot::customAccessorGetter):
- runtime/PropertySlot.h:
(JSC::PropertySlot::domAttribute):
(JSC::PropertySlot::setCustom):
(JSC::PropertySlot::setCacheableCustom):
(JSC::PropertySlot::getValue):
(JSC::PropertySlot::domJIT): Deleted.
- runtime/VM.cpp:
(JSC::VM::VM):
- runtime/VM.h:
Source/WebCore:
We use DOMAttribute. When DOMAttribute is specified, ClassInfo check is performed by JSC side.
So, we can drop ClassInfo check from the actual function.
We also simplify DOMJIT::GetterSetter to make it smaller size.
WebCore size comparison
Before: 48443292
After: 48087800 (0.7% reduction)
Speedometer Scores show 0.8% improvement.
Before: 158.9 +- 0.46
After: 160.2 +- 0.36
Dromaeo DOM core Scores show 5.8% improvement.
Before After
Total Score: 8424.12runs/s ±1.38% 8911.60runs/s ±1.47%
DOM Attributes 12627.27runs/s ±1.87% 14023.17runs/s ±1.87%
DOM Modification 1207.82runs/s ±2.48% 1204.21runs/s ±3.05%
DOM Query 68068.82runs/s ±0.63% 74273.38runs/s ±0.69%
DOM Traversal 1240.07runs/s ±1.96% 1256.64runs/s ±1.77%
Performance improvement can be explained by the following optimizations.
- Type checks are typically eliminated in all the JIT tiers. IC / DFG / FTL can drop type checks since get_by_id operation already performs a structure check which subsumes this type check.
- Direct getter call by CallDOMGetter without creating IC in DFG and FTL.
- bindings/js/JSDOMAttribute.h:
(WebCore::IDLAttribute::get):
Add CastedThisErrorBehavior::Assert case. When this is specified, we perform casting without using jsDynamicCast.
- bindings/scripts/CodeGeneratorJS.pm:
(IsAcceleratedDOMAttribute):
(GetJSCAttributesForAttribute):
(GenerateHeader):
(GeneratePropertiesHashTable):
(GenerateImplementation):
(GenerateAttributeGetterTrampolineDefinition):
(GenerateAttributeGetterDefinition):
(GenerateCallbackImplementationContent):
(GenerateHashTableValueArray):
(GenerateHashTable):
(GenerateConstructorHelperMethods):
Update CodeGeneratorJS to emit DOMAttribute. And DOMJIT::GetterSetter becomes changed to be smaller size.
- bindings/scripts/test/JS/JSInterfaceName.cpp:
(WebCore::JSInterfaceNamePrototype::finishCreation):
- bindings/scripts/test/JS/JSMapLike.cpp:
(WebCore::JSMapLikePrototype::finishCreation):
- bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:
(WebCore::JSReadOnlyMapLikePrototype::finishCreation):
- bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:
(WebCore::JSTestActiveDOMObjectPrototype::finishCreation):
(WebCore::jsTestActiveDOMObjectExcitingAttr):
- bindings/scripts/test/JS/JSTestCEReactions.cpp:
(WebCore::JSTestCEReactionsPrototype::finishCreation):
(WebCore::jsTestCEReactionsAttributeWithCEReactions):
(WebCore::jsTestCEReactionsReflectAttributeWithCEReactions):
(WebCore::jsTestCEReactionsStringifierAttribute):
- bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
(WebCore::JSTestCEReactionsStringifierPrototype::finishCreation):
(WebCore::jsTestCEReactionsStringifierValue):
- bindings/scripts/test/JS/JSTestCallTracer.cpp:
(WebCore::JSTestCallTracerPrototype::finishCreation):
(WebCore::jsTestCallTracerTestAttributeInterface):
(WebCore::jsTestCallTracerTestAttributeSpecified):
- bindings/scripts/test/JS/JSTestCallbackInterface.cpp:
(WebCore::JSTestCallbackInterfaceConstructor::initializeProperties):
- bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:
(WebCore::JSTestClassWithJSBuiltinConstructorPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:
(WebCore::JSTestCustomConstructorWithNoInterfaceObjectPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestDOMJIT.cpp:
(WebCore::JSTestDOMJITPrototype::finishCreation):
(WebCore::TestDOMJITAnyAttrDOMJIT::TestDOMJITAnyAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITAnyAttr): Deleted.
(WebCore::TestDOMJITBooleanAttrDOMJIT::TestDOMJITBooleanAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITBooleanAttr): Deleted.
(WebCore::TestDOMJITByteAttrDOMJIT::TestDOMJITByteAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITByteAttr): Deleted.
(WebCore::TestDOMJITOctetAttrDOMJIT::TestDOMJITOctetAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITOctetAttr): Deleted.
(WebCore::TestDOMJITShortAttrDOMJIT::TestDOMJITShortAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITShortAttr): Deleted.
(WebCore::TestDOMJITUnsignedShortAttrDOMJIT::TestDOMJITUnsignedShortAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITUnsignedShortAttr): Deleted.
(WebCore::TestDOMJITLongAttrDOMJIT::TestDOMJITLongAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITLongAttr): Deleted.
(WebCore::TestDOMJITUnsignedLongAttrDOMJIT::TestDOMJITUnsignedLongAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITUnsignedLongAttr): Deleted.
(WebCore::TestDOMJITLongLongAttrDOMJIT::TestDOMJITLongLongAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITLongLongAttr): Deleted.
(WebCore::TestDOMJITUnsignedLongLongAttrDOMJIT::TestDOMJITUnsignedLongLongAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITUnsignedLongLongAttr): Deleted.
(WebCore::TestDOMJITFloatAttrDOMJIT::TestDOMJITFloatAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITFloatAttr): Deleted.
(WebCore::TestDOMJITUnrestrictedFloatAttrDOMJIT::TestDOMJITUnrestrictedFloatAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITUnrestrictedFloatAttr): Deleted.
(WebCore::TestDOMJITDoubleAttrDOMJIT::TestDOMJITDoubleAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITDoubleAttr): Deleted.
(WebCore::TestDOMJITUnrestrictedDoubleAttrDOMJIT::TestDOMJITUnrestrictedDoubleAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITUnrestrictedDoubleAttr): Deleted.
(WebCore::TestDOMJITDomStringAttrDOMJIT::TestDOMJITDomStringAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITDomStringAttr): Deleted.
(WebCore::TestDOMJITByteStringAttrDOMJIT::TestDOMJITByteStringAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITByteStringAttr): Deleted.
(WebCore::TestDOMJITUsvStringAttrDOMJIT::TestDOMJITUsvStringAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITUsvStringAttr): Deleted.
(WebCore::TestDOMJITNodeAttrDOMJIT::TestDOMJITNodeAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITNodeAttr): Deleted.
(WebCore::TestDOMJITBooleanNullableAttrDOMJIT::TestDOMJITBooleanNullableAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITBooleanNullableAttr): Deleted.
(WebCore::TestDOMJITByteNullableAttrDOMJIT::TestDOMJITByteNullableAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITByteNullableAttr): Deleted.
(WebCore::TestDOMJITOctetNullableAttrDOMJIT::TestDOMJITOctetNullableAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITOctetNullableAttr): Deleted.
(WebCore::TestDOMJITShortNullableAttrDOMJIT::TestDOMJITShortNullableAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITShortNullableAttr): Deleted.
(WebCore::TestDOMJITUnsignedShortNullableAttrDOMJIT::TestDOMJITUnsignedShortNullableAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITUnsignedShortNullableAttr): Deleted.
(WebCore::TestDOMJITLongNullableAttrDOMJIT::TestDOMJITLongNullableAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITLongNullableAttr): Deleted.
(WebCore::TestDOMJITUnsignedLongNullableAttrDOMJIT::TestDOMJITUnsignedLongNullableAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITUnsignedLongNullableAttr): Deleted.
(WebCore::TestDOMJITLongLongNullableAttrDOMJIT::TestDOMJITLongLongNullableAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITLongLongNullableAttr): Deleted.
(WebCore::TestDOMJITUnsignedLongLongNullableAttrDOMJIT::TestDOMJITUnsignedLongLongNullableAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITUnsignedLongLongNullableAttr): Deleted.
(WebCore::TestDOMJITFloatNullableAttrDOMJIT::TestDOMJITFloatNullableAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITFloatNullableAttr): Deleted.
(WebCore::TestDOMJITUnrestrictedFloatNullableAttrDOMJIT::TestDOMJITUnrestrictedFloatNullableAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITUnrestrictedFloatNullableAttr): Deleted.
(WebCore::TestDOMJITDoubleNullableAttrDOMJIT::TestDOMJITDoubleNullableAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITDoubleNullableAttr): Deleted.
(WebCore::TestDOMJITUnrestrictedDoubleNullableAttrDOMJIT::TestDOMJITUnrestrictedDoubleNullableAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITUnrestrictedDoubleNullableAttr): Deleted.
(WebCore::TestDOMJITDomStringNullableAttrDOMJIT::TestDOMJITDomStringNullableAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITDomStringNullableAttr): Deleted.
(WebCore::TestDOMJITByteStringNullableAttrDOMJIT::TestDOMJITByteStringNullableAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITByteStringNullableAttr): Deleted.
(WebCore::TestDOMJITUsvStringNullableAttrDOMJIT::TestDOMJITUsvStringNullableAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITUsvStringNullableAttr): Deleted.
(WebCore::TestDOMJITNodeNullableAttrDOMJIT::TestDOMJITNodeNullableAttrDOMJIT): Deleted.
(WebCore::domJITGetterSetterForTestDOMJITNodeNullableAttr): Deleted.
- bindings/scripts/test/JS/JSTestDOMJIT.h:
- bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorPrototype::finishCreation):
(WebCore::jsTestEventConstructorAttr1):
(WebCore::jsTestEventConstructorAttr2):
(WebCore::jsTestEventConstructorAttr3):
- bindings/scripts/test/JS/JSTestEventTarget.cpp:
(WebCore::JSTestEventTargetPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestExceptionPrototype::finishCreation):
(WebCore::jsTestExceptionName):
- bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:
(WebCore::JSTestGenerateIsReachablePrototype::finishCreation):
(WebCore::jsTestGenerateIsReachableASecretAttribute):
- bindings/scripts/test/JS/JSTestGlobalObject.cpp:
(WebCore::jsTestGlobalObjectRegularAttribute):
- bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:
(WebCore::JSTestIndexedSetterNoIdentifierPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:
(WebCore::JSTestIndexedSetterThrowingExceptionPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:
(WebCore::JSTestIndexedSetterWithIdentifierPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::initializeProperties):
(WebCore::JSTestInterfacePrototype::finishCreation):
(WebCore::jsTestInterfaceImplementsStr1):
(WebCore::jsTestInterfaceImplementsStr2):
(WebCore::jsTestInterfaceImplementsStr3):
(WebCore::jsTestInterfaceImplementsNode):
(WebCore::jsTestInterfaceSupplementalStr1):
(WebCore::jsTestInterfaceSupplementalStr2):
(WebCore::jsTestInterfaceSupplementalStr3):
(WebCore::jsTestInterfaceSupplementalNode):
- bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:
(WebCore::JSTestInterfaceLeadingUnderscorePrototype::finishCreation):
(WebCore::jsTestInterfaceLeadingUnderscoreReadonly):
- bindings/scripts/test/JS/JSTestIterable.cpp:
(WebCore::JSTestIterablePrototype::finishCreation):
- bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
(WebCore::JSTestJSBuiltinConstructorPrototype::finishCreation):
(WebCore::jsTestJSBuiltinConstructorTestAttributeCustom):
(WebCore::jsTestJSBuiltinConstructorTestAttributeRWCustom):
- bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::JSTestMediaQueryListListenerPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:
(WebCore::JSTestNamedAndIndexedSetterNoIdentifierPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:
(WebCore::JSTestNamedAndIndexedSetterThrowingExceptionPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:
(WebCore::JSTestNamedAndIndexedSetterWithIdentifierPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:
(WebCore::JSTestNamedDeleterNoIdentifierPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:
(WebCore::JSTestNamedDeleterThrowingExceptionPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:
(WebCore::JSTestNamedDeleterWithIdentifierPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:
(WebCore::JSTestNamedDeleterWithIndexedGetterPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:
(WebCore::JSTestNamedGetterCallWithPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:
(WebCore::JSTestNamedGetterNoIdentifierPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:
(WebCore::JSTestNamedGetterWithIdentifierPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:
(WebCore::JSTestNamedSetterNoIdentifierPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:
(WebCore::JSTestNamedSetterThrowingExceptionPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:
(WebCore::JSTestNamedSetterWithIdentifierPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:
(WebCore::JSTestNamedSetterWithIndexedGetterPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:
(WebCore::JSTestNamedSetterWithIndexedGetterAndSetterPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp:
(WebCore::JSTestNamedSetterWithOverrideBuiltinsPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp:
(WebCore::JSTestNamedSetterWithUnforgablePropertiesPrototype::finishCreation):
(WebCore::jsTestNamedSetterWithUnforgablePropertiesUnforgeableAttribute):
- bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp:
(WebCore::JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltinsPrototype::finishCreation):
(WebCore::jsTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltinsUnforgeableAttribute):
- bindings/scripts/test/JS/JSTestNode.cpp:
(WebCore::JSTestNodePrototype::finishCreation):
(WebCore::jsTestNodeName):
- bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::initializeProperties):
(WebCore::JSTestObjPrototype::finishCreation):
(WebCore::jsTestObjReadOnlyLongAttr):
(WebCore::jsTestObjReadOnlyStringAttr):
(WebCore::jsTestObjReadOnlyTestObjAttr):
(WebCore::jsTestObjEnumAttr):
(WebCore::jsTestObjByteAttr):
(WebCore::jsTestObjOctetAttr):
(WebCore::jsTestObjShortAttr):
(WebCore::jsTestObjClampedShortAttr):
(WebCore::jsTestObjEnforceRangeShortAttr):
(WebCore::jsTestObjUnsignedShortAttr):
(WebCore::jsTestObjLongAttr):
(WebCore::jsTestObjLongLongAttr):
(WebCore::jsTestObjUnsignedLongLongAttr):
(WebCore::jsTestObjStringAttr):
(WebCore::jsTestObjUsvstringAttr):
(WebCore::jsTestObjTestObjAttr):
(WebCore::jsTestObjTestNullableObjAttr):
(WebCore::jsTestObjUnforgeableAttr):
(WebCore::jsTestObjStringAttrTreatingNullAsEmptyString):
(WebCore::jsTestObjUsvstringAttrTreatingNullAsEmptyString):
(WebCore::jsTestObjByteStringAttrTreatingNullAsEmptyString):
(WebCore::jsTestObjStringLongRecordAttr):
(WebCore::jsTestObjUsvstringLongRecordAttr):
(WebCore::jsTestObjStringObjRecordAttr):
(WebCore::jsTestObjStringNullableObjRecordAttr):
(WebCore::jsTestObjDictionaryAttr):
(WebCore::jsTestObjNullableDictionaryAttr):
(WebCore::jsTestObjAnnotatedTypeInUnionAttr):
(WebCore::jsTestObjAnnotatedTypeInSequenceAttr):
(WebCore::jsTestObjImplementationEnumAttr):
(WebCore::jsTestObjXMLObjAttr):
(WebCore::jsTestObjCreate):
(WebCore::jsTestObjReflectedStringAttr):
(WebCore::jsTestObjReflectedUSVStringAttr):
(WebCore::jsTestObjReflectedIntegralAttr):
(WebCore::jsTestObjReflectedUnsignedIntegralAttr):
(WebCore::jsTestObjReflectedBooleanAttr):
(WebCore::jsTestObjReflectedURLAttr):
(WebCore::jsTestObjReflectedUSVURLAttr):
(WebCore::jsTestObjReflectedCustomIntegralAttr):
(WebCore::jsTestObjReflectedCustomBooleanAttr):
(WebCore::jsTestObjReflectedCustomURLAttr):
(WebCore::jsTestObjEnabledAtRuntimeAttribute):
(WebCore::jsTestObjEnabledBySettingAttribute):
(WebCore::jsTestObjTypedArrayAttr):
(WebCore::jsTestObjAttributeWithGetterException):
(WebCore::jsTestObjAttributeWithSetterException):
(WebCore::jsTestObjStringAttrWithGetterException):
(WebCore::jsTestObjStringAttrWithSetterException):
(WebCore::jsTestObjCustomAttr):
(WebCore::jsTestObjOnfoo):
(WebCore::jsTestObjOnwebkitfoo):
(WebCore::jsTestObjWithScriptStateAttribute):
(WebCore::jsTestObjWithCallWithAndSetterCallWithAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAttribute):
(WebCore::jsTestObjWithScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeRaises):
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute):
(WebCore::jsTestObjConditionalAttr1):
(WebCore::jsTestObjConditionalAttr2):
(WebCore::jsTestObjConditionalAttr3):
(WebCore::jsTestObjCachedAttribute1):
(WebCore::jsTestObjCachedAttribute2):
(WebCore::jsTestObjAnyAttribute):
(WebCore::jsTestObjObjectAttribute):
(WebCore::jsTestObjContentDocument):
(WebCore::jsTestObjMutablePoint):
(WebCore::jsTestObjStrawberry):
(WebCore::jsTestObjDescription):
(WebCore::jsTestObjId):
(WebCore::jsTestObjHash):
(WebCore::jsTestObjReplaceableAttribute):
(WebCore::jsTestObjNullableDoubleAttribute):
(WebCore::jsTestObjNullableLongAttribute):
(WebCore::jsTestObjNullableBooleanAttribute):
(WebCore::jsTestObjNullableStringAttribute):
(WebCore::jsTestObjNullableLongSettableAttribute):
(WebCore::jsTestObjNullableStringSettableAttribute):
(WebCore::jsTestObjNullableUSVStringSettableAttribute):
(WebCore::jsTestObjNullableByteStringSettableAttribute):
(WebCore::jsTestObjNullableStringValue):
(WebCore::jsTestObjAttribute):
(WebCore::jsTestObjAttributeWithReservedEnumType):
(WebCore::jsTestObjPutForwardsAttribute):
(WebCore::jsTestObjPutForwardsNullableAttribute):
(WebCore::jsTestObjStringifierAttribute):
(WebCore::jsTestObjConditionallyReadWriteAttribute):
(WebCore::jsTestObjConditionalAndConditionallyReadWriteAttribute):
- bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:
(WebCore::JSTestOverloadedConstructorsPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:
(WebCore::JSTestOverloadedConstructorsWithSequencePrototype::finishCreation):
- bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:
(WebCore::JSTestOverrideBuiltinsPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestPluginInterface.cpp:
(WebCore::JSTestPluginInterfacePrototype::finishCreation):
- bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:
(WebCore::JSTestPromiseRejectionEventPrototype::finishCreation):
(WebCore::jsTestPromiseRejectionEventReason):
- bindings/scripts/test/JS/JSTestSerialization.cpp:
(WebCore::JSTestSerializationPrototype::finishCreation):
(WebCore::jsTestSerializationFirstStringAttribute):
(WebCore::jsTestSerializationSecondLongAttribute):
(WebCore::jsTestSerializationThirdUnserializableAttribute):
(WebCore::jsTestSerializationFourthUnrestrictedDoubleAttribute):
(WebCore::jsTestSerializationFifthLongAttribute):
(WebCore::jsTestSerializationSixthTypedefAttribute):
(WebCore::jsTestSerializationSeventhDirectlySerializableAttribute):
(WebCore::jsTestSerializationEighthIndirectlyAttribute):
- bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.cpp:
(WebCore::JSTestSerializationIndirectInheritancePrototype::finishCreation):
- bindings/scripts/test/JS/JSTestSerializationInherit.cpp:
(WebCore::JSTestSerializationInheritPrototype::finishCreation):
(WebCore::jsTestSerializationInheritInheritLongAttribute):
- bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:
(WebCore::JSTestSerializationInheritFinalPrototype::finishCreation):
(WebCore::jsTestSerializationInheritFinalFinalLongAttributeFoo):
(WebCore::jsTestSerializationInheritFinalFinalLongAttributeBar):
- bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfacePrototype::finishCreation):
(WebCore::jsTestSerializedScriptValueInterfaceValue):
(WebCore::jsTestSerializedScriptValueInterfaceReadonlyValue):
(WebCore::jsTestSerializedScriptValueInterfaceCachedValue):
(WebCore::jsTestSerializedScriptValueInterfacePorts):
(WebCore::jsTestSerializedScriptValueInterfaceCachedReadonlyValue):
- bindings/scripts/test/JS/JSTestStringifier.cpp:
(WebCore::JSTestStringifierPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp:
(WebCore::JSTestStringifierAnonymousOperationPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp:
(WebCore::JSTestStringifierNamedOperationPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp:
(WebCore::JSTestStringifierOperationImplementedAsPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp:
(WebCore::JSTestStringifierOperationNamedToStringPrototype::finishCreation):
- bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp:
(WebCore::JSTestStringifierReadOnlyAttributePrototype::finishCreation):
(WebCore::jsTestStringifierReadOnlyAttributeIdentifier):
- bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:
(WebCore::JSTestStringifierReadWriteAttributePrototype::finishCreation):
(WebCore::jsTestStringifierReadWriteAttributeIdentifier):
- bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::JSTestTypedefsConstructor::initializeProperties):
(WebCore::JSTestTypedefsPrototype::finishCreation):
(WebCore::jsTestTypedefsUnsignedLongLongAttr):
(WebCore::jsTestTypedefsSerializedScriptValue):
(WebCore::jsTestTypedefsAttributeWithClamp):
(WebCore::jsTestTypedefsAttributeWithClampInTypedef):
(WebCore::jsTestTypedefsAttrWithGetterException):
(WebCore::jsTestTypedefsAttrWithSetterException):
(WebCore::jsTestTypedefsStringAttrWithGetterException):
(WebCore::jsTestTypedefsStringAttrWithSetterException):
(WebCore::jsTestTypedefsBufferSourceAttr):
(WebCore::jsTestTypedefsDomTimeStampAttr):
They are binding test rebaselines.
- domjit/DOMJITIDLTypeFilter.h:
- domjit/JSDocumentDOMJIT.cpp:
(WebCore::compileDocumentDocumentElementAttribute):
(WebCore::compileDocumentBodyAttribute):
(WebCore::DocumentDocumentElementDOMJIT::callDOMGetter): Deleted.
(WebCore::DocumentBodyDOMJIT::callDOMGetter): Deleted.
- domjit/JSNodeDOMJIT.cpp:
(WebCore::compileNodeFirstChildAttribute):
(WebCore::compileNodeLastChildAttribute):
(WebCore::compileNodeNextSiblingAttribute):
(WebCore::compileNodePreviousSiblingAttribute):
(WebCore::compileNodeParentNodeAttribute):
(WebCore::compileNodeNodeTypeAttribute):
(WebCore::compileNodeOwnerDocumentAttribute):
(WebCore::NodeFirstChildDOMJIT::callDOMGetter): Deleted.
(WebCore::NodeLastChildDOMJIT::callDOMGetter): Deleted.
(WebCore::NodeNextSiblingDOMJIT::callDOMGetter): Deleted.
(WebCore::NodePreviousSiblingDOMJIT::callDOMGetter): Deleted.
(WebCore::NodeParentNodeDOMJIT::callDOMGetter): Deleted.
(WebCore::NodeNodeTypeDOMJIT::callDOMGetter): Deleted.
(WebCore::NodeOwnerDocumentDOMJIT::callDOMGetter): Deleted.
DOMJIT::GetterSetter becomes smaller constexpr data.
LayoutTests:
- js/dom/dom-getters-type-check-expected.txt: Added.
- js/dom/dom-getters-type-check.html: Added.
- 3:39 AM Changeset in webkit [219980] by
-
- 3 edits in trunk/Source/WebCore
[GStreamer][EME] Not having a key id buffer should not always error
https://bugs.webkit.org/show_bug.cgi?id=174889
Reviewed by Žan Doberšek.
In r219946 we introduced a hard requirement for a key id buffer
that does not happen for all CDMs.
- platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:
(webKitMediaClearKeyDecryptorSetupCipher): Check for key id buffer
and error if we didn't get it.
- platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
(webkitMediaCommonEncryptionDecryptTransformInPlace): Soften the
requirement for key id buffer.
- 3:18 AM Changeset in webkit [219979] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer][EME] Fix phony debug output in player base for supported key system
https://bugs.webkit.org/show_bug.cgi?id=174888
Reviewed by Žan Doberšek.
The debug output was returning always false because that method
was not checking anything before. Now it is and should reflect it.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::supportsKeySystem):
- 1:55 AM Changeset in webkit [219978] by
-
- 3 edits3 adds in trunk/Source/WebCore
[EME][GStreamer] Add barebones CDM interface implementations for ClearKey
https://bugs.webkit.org/show_bug.cgi?id=174887
Reviewed by Xabier Rodriguez-Calvar.
Add empty ClearKey derivations of CDMFactory, CDMPrivate and CDMInstance
classes. These will be enhanced as the implementation progresses.
ClearKey is added to CDMInstance::ImplementationType, and the
CDMInstanceClearKey::implementationType() override returns that value.
Type traits specialization for the CDMInstanceClearKey class is also
added, utilizing the CDMInstance::ImplementationType::ClearKey value.
The implementation file is added to the WPE build, along with the
necessary inclusion directory.
- PlatformWPE.cmake:
- platform/encryptedmedia/CDMInstance.h:
- platform/encryptedmedia/clearkey/CDMClearKey.cpp: Added.
(WebCore::CDMFactoryClearKey::createCDM):
(WebCore::CDMFactoryClearKey::supportsKeySystem):
(WebCore::CDMPrivateClearKey::supportsInitDataType):
(WebCore::CDMPrivateClearKey::supportsConfiguration):
(WebCore::CDMPrivateClearKey::supportsConfigurationWithRestrictions):
(WebCore::CDMPrivateClearKey::supportsSessionTypeWithConfiguration):
(WebCore::CDMPrivateClearKey::supportsRobustness):
(WebCore::CDMPrivateClearKey::distinctiveIdentifiersRequirement):
(WebCore::CDMPrivateClearKey::persistentStateRequirement):
(WebCore::CDMPrivateClearKey::distinctiveIdentifiersAreUniquePerOriginAndClearable):
(WebCore::CDMPrivateClearKey::createInstance):
(WebCore::CDMPrivateClearKey::loadAndInitialize):
(WebCore::CDMPrivateClearKey::supportsServerCertificates):
(WebCore::CDMPrivateClearKey::supportsSessions):
(WebCore::CDMPrivateClearKey::supportsInitData):
(WebCore::CDMPrivateClearKey::sanitizeResponse):
(WebCore::CDMPrivateClearKey::sanitizeSessionId):
(WebCore::CDMInstanceClearKey::initializeWithConfiguration):
(WebCore::CDMInstanceClearKey::setDistinctiveIdentifiersAllowed):
(WebCore::CDMInstanceClearKey::setPersistentStateAllowed):
(WebCore::CDMInstanceClearKey::setServerCertificate):
(WebCore::CDMInstanceClearKey::requestLicense):
(WebCore::CDMInstanceClearKey::updateLicense):
(WebCore::CDMInstanceClearKey::loadSession):
(WebCore::CDMInstanceClearKey::closeSession):
(WebCore::CDMInstanceClearKey::removeSessionData):
(WebCore::CDMInstanceClearKey::storeRecordOfKeyUsage):
- platform/encryptedmedia/clearkey/CDMClearKey.h: Added.
- 1:13 AM Changeset in webkit [219977] by
-
- 3 edits in trunk/Source/WebCore
[EME] Allow CDMInstance type traits specialization
https://bugs.webkit.org/show_bug.cgi?id=174886
Reviewed by Xabier Rodriguez-Calvar.
Allow using the trait-based type casting for the CDMInstance class and its
derivatives. ImplementationType enumeration values are to be used and
returned from the new implementationType() virtual method. This method is
leveraged in the type trait specialization that enables using is<>() and
downcast<>() helpers for CDMInstance objects.
This will allow differentiating between CDMInstance implementations once
the media playback pipeline has to retrieve any key information that's
necessary for playback of encrypted content.
MockCDMInstance class overrides the implementationType() method, returning
the ImplementationType::Mock value. Type trait specializations for this
class aren't added since they're not needed anywhere at this point.
- platform/encryptedmedia/CDMInstance.h:
- testing/MockCDMFactory.h:
- 1:13 AM Changeset in webkit [219976] by
-
- 4 edits in trunk
[GCrypt] Key serialization support
https://bugs.webkit.org/show_bug.cgi?id=173883
Reviewed by Jiewen Tan.
Source/WebCore:
Implement crypto key serialization for platforms that use libgcrypt.
Despite the function names and the existing implementation for the Mac port,
we don't perform the KEK wrapping and unwrapping due to the review feedback
advising against it.
Instead the passed-in key data is simply copied and returned as the result of
the 'wrapping' operation, and similarly the passed-in serialized data is simply
copied and returned as the result of the 'unwrapping' operation.
No new tests -- related tests are now passing and are unskipped.
- crypto/gcrypt/SerializedCryptoKeyWrapGCrypt.cpp:
(WebCore::getDefaultWebCryptoMasterKey):
(WebCore::wrapSerializedCryptoKey):
(WebCore::unwrapSerializedCryptoKey):
LayoutTests:
- platform/wpe/TestExpectations: Unskip the crypto/worker/ tests that
utilize key serialization and are now passing.
Jul 26, 2017:
- 8:57 PM Changeset in webkit [219975] by
-
- 7 edits in branches/safari-604-branch/Source
Versioning.
- 7:47 PM Changeset in webkit [219974] by
-
- 2 edits in trunk/Source/WebKit
ResourceLoadStatistics API tests fail on El Capitan.
https://bugs.webkit.org/show_bug.cgi?id=174877
Reviewed by Chris Dumez.
Always install the testing callback.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback):
- 6:49 PM Changeset in webkit [219973] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION (r211160): Can't pinch to zoom unlocked encrypted PDFs in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=174881
<rdar://problem/33556312>
Reviewed by Andy Estes.
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _hidePasswordView]):
WKPasswordView saves and restores a bunch of scroll view properties, including
those relating to zoom limits. The restoration happens in -[WKPasswordView hide],
which is never called. Instead, the code added in r211160 just calls
removeFromSuperview after unlocking, never restoring the old zoom limits,
causing the then fully unlocked PDF to not be zoomable. Fix this by calling
-hide instead of -removeFromSuperview (which -hide also calls).
- 5:13 PM Changeset in webkit [219972] by
-
- 3 edits in trunk/Source/WebInspectorUI
Uncaught Exception: undefined is not an object (evaluating 'this._memoryRow.value = Number.bytesToString(this._canvas.memoryCost)')
https://bugs.webkit.org/show_bug.cgi?id=174823
Reviewed by Joseph Pecoraro.
- UserInterface/Views/CanvasDetailsSidebarPanel.js:
(WebInspector.CanvasDetailsSidebarPanel.prototype._refreshIdentitySection):
(WebInspector.CanvasDetailsSidebarPanel.prototype._refreshSourceSection):
(WebInspector.CanvasDetailsSidebarPanel.prototype._refreshAttributesSection):
(WebInspector.CanvasDetailsSidebarPanel.prototype._refreshCSSCanvasSection):
(WebInspector.CanvasDetailsSidebarPanel.prototype._formatMemoryRow):
Early return if the view has not called initialLayout, as the rows might not have been
constructed yet.
- UserInterface/Views/View.js:
(WebInspector.View.prototype.get didInitialLayout): Added.
- 5:05 PM Changeset in webkit [219971] by
-
- 1 copy in tags/Safari-604.1.34
Tag Safari-604.1.34.
- 4:53 PM Changeset in webkit [219970] by
-
- 7 edits2 adds in trunk
Implement new TextMetrics, returned by canvas measureText()
https://bugs.webkit.org/show_bug.cgi?id=82798
Source/WebCore:
<rdar://problem/11159332>
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> and Fujii Hironori <Fujii Hironori> on 2017-07-26
Reviewed by Dean Jackson.
The specification: https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-measuretext
Add new attributes to TextMetrics.
Add a new method textOffset() of CanvasRenderingContext2D by
extracting from drawTextInternal() to use the same horizontal and
vertical offsets of a text in both drawTextInternal() and
measureText().
Test: fast/canvas/canvas-measureText-2.html
- html/TextMetrics.h:
(WebCore::TextMetrics::actualBoundingBoxLeft):
(WebCore::TextMetrics::setActualBoundingBoxLeft):
(WebCore::TextMetrics::actualBoundingBoxRight):
(WebCore::TextMetrics::setActualBoundingBoxRight):
(WebCore::TextMetrics::fontBoundingBoxAscent):
(WebCore::TextMetrics::setFontBoundingBoxAscent):
(WebCore::TextMetrics::fontBoundingBoxDescent):
(WebCore::TextMetrics::setFontBoundingBoxDescent):
(WebCore::TextMetrics::actualBoundingBoxAscent):
(WebCore::TextMetrics::setActualBoundingBoxAscent):
(WebCore::TextMetrics::actualBoundingBoxDescent):
(WebCore::TextMetrics::setActualBoundingBoxDescent):
(WebCore::TextMetrics::emHeightAscent):
(WebCore::TextMetrics::setEmHeightAscent):
(WebCore::TextMetrics::emHeightDescent):
(WebCore::TextMetrics::setEmHeightDescent):
(WebCore::TextMetrics::hangingBaseline):
(WebCore::TextMetrics::setHangingBaseline):
(WebCore::TextMetrics::alphabeticBaseline):
(WebCore::TextMetrics::setAlphabeticBaseline):
(WebCore::TextMetrics::ideographicBaseline):
(WebCore::TextMetrics::setIdeographicBaseline):
Added getters and setters.
(WebCore::TextMetrics::TextMetrics): Deleted.
- html/TextMetrics.idl: Added new attributes.
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::FontProxy::fontMetrics):
Changed the return value type to a const reference of FontMetrics
not to copy it.
(WebCore::CanvasRenderingContext2D::FontProxy::width):
Added the second arguemnt of GlyphOverflow type.
(WebCore::CanvasRenderingContext2D::measureText): Calculate and
set the new attributes of TextMetrics.
(WebCore::CanvasRenderingContext2D::textOffset): Extracted from drawTextInternal.
(WebCore::CanvasRenderingContext2D::drawTextInternal): Removed the
offset calculation code and call textOffset.
- html/canvas/CanvasRenderingContext2D.h: Added the method
declaration of textOffset. Change types of fontMetrics and width
methods.
- platform/graphics/cairo/FontCairoHarfbuzzNG.cpp:
(WebCore::FontCascade::floatWidthForComplexText): Added a dummy
implementation of calculating GlyphOverflow.
LayoutTests:
Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> and Fujii Hironori <Fujii Hironori> on 2017-07-26
Reviewed by Dean Jackson.
Create a test that checks that:
- ascent + descent is greater than zero
- actualBoundingBoxLeft + actualBoundingBoxRight is somewhere quite close to width
- when baseline is top, emHeightAscent is 0 (respectively bottom/emHeightDescent)
- when baseline is hanging, hangingBaseline in 0 (respectively alphabetic and ideographic)
- order of different vertical measures (for example, emHeightAscent is always higher that alphabeticBaseline)
- fast/canvas/canvas-measureText-2-expected.txt: Added.
- fast/canvas/canvas-measureText-2.html: Added.
- 4:29 PM Changeset in webkit [219969] by
-
- 2 edits2 adds in trunk/JSTests
WebAssembly: test throwing out of the start function
https://bugs.webkit.org/show_bug.cgi?id=165714
<rdar://problem/29760251>
Reviewed by Keith Miller.
- wasm/assert.js:
- wasm/function-tests/trap-from-start.js: Added.
(StartTraps):
- wasm/function-tests/trap-from-start-async.js: Added.
(async.StartTrapsAsync):
- 3:57 PM Changeset in webkit [219968] by
-
- 2 edits in trunk/LayoutTests
Marked Multiple imported/w3c/web-platform-tests/ as failing.
<rdar://problem/33251388>
Unreviewed test gardening.
- platform/ios-11/TestExpectations:
- 3:57 PM Changeset in webkit [219967] by
-
- 2 edits in trunk/LayoutTests
Rebaselined http/tests/quicklook/top-navigation-blocked-expected.txt.
https://bugs.webkit.org/show_bug.cgi?id=174755
Unreviewed test gardening.
- platform/ios-11/http/tests/quicklook/top-navigation-blocked-expected.txt:
- 3:52 PM Changeset in webkit [219966] by
-
- 7 edits20 copies3 adds2 deletes in trunk/Source/WebKit
Rename {Web/UI}Process/Storage to {Web/UI}Process/WebStorage.
https://bugs.webkit.org/show_bug.cgi?id=174871
Reviewed by Chris Dumez.
The standard these directories help implement is the "Web Storage" standard.
"Storage" is too general of a word that we have plans to start using in other contexts soon.
- CMakeLists.txt:
- DerivedSources.make:
- PlatformGTK.cmake:
- PlatformMac.cmake:
- PlatformWPE.cmake:
- WebKit.xcodeproj/project.pbxproj:
- UIProcess/ResourceLoadStatisticsPersistentStorage.cpp: Renamed from Source/WebKit/UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.cpp.
- UIProcess/ResourceLoadStatisticsPersistentStorage.h: Renamed from Source/WebKit/UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.h.
- UIProcess/WebStorage/LocalStorageDatabase.cpp: Renamed from Source/WebKit/UIProcess/Storage/LocalStorageDatabase.cpp.
- UIProcess/WebStorage/LocalStorageDatabase.h: Renamed from Source/WebKit/UIProcess/Storage/LocalStorageDatabase.h.
- UIProcess/WebStorage/LocalStorageDatabaseTracker.cpp: Renamed from Source/WebKit/UIProcess/Storage/LocalStorageDatabaseTracker.cpp.
- UIProcess/WebStorage/LocalStorageDatabaseTracker.h: Renamed from Source/WebKit/UIProcess/Storage/LocalStorageDatabaseTracker.h.
- UIProcess/WebStorage/StorageManager.cpp: Renamed from Source/WebKit/UIProcess/Storage/StorageManager.cpp.
- UIProcess/WebStorage/StorageManager.h: Renamed from Source/WebKit/UIProcess/Storage/StorageManager.h.
- UIProcess/WebStorage/StorageManager.messages.in: Renamed from Source/WebKit/UIProcess/Storage/StorageManager.messages.in.
- UIProcess/WebStorage/ios/LocalStorageDatabaseTrackerIOS.mm: Renamed from Source/WebKit/UIProcess/Storage/ios/LocalStorageDatabaseTrackerIOS.mm.
- UIProcess/ios/ResourceLoadStatisticsPersistentStorageIOS.mm: Renamed from Source/WebKit/UIProcess/Storage/ios/ResourceLoadStatisticsPersistentStorageIOS.mm.
- WebProcess/WebStorage/StorageAreaImpl.cpp: Renamed from Source/WebKit/WebProcess/Storage/StorageAreaImpl.cpp.
- WebProcess/WebStorage/StorageAreaImpl.h: Renamed from Source/WebKit/WebProcess/Storage/StorageAreaImpl.h.
- WebProcess/WebStorage/StorageAreaMap.cpp: Renamed from Source/WebKit/WebProcess/Storage/StorageAreaMap.cpp.
- WebProcess/WebStorage/StorageAreaMap.h: Renamed from Source/WebKit/WebProcess/Storage/StorageAreaMap.h.
- WebProcess/WebStorage/StorageAreaMap.messages.in: Renamed from Source/WebKit/WebProcess/Storage/StorageAreaMap.messages.in.
- WebProcess/WebStorage/StorageNamespaceImpl.cpp: Renamed from Source/WebKit/WebProcess/Storage/StorageNamespaceImpl.cpp.
- WebProcess/WebStorage/StorageNamespaceImpl.h: Renamed from Source/WebKit/WebProcess/Storage/StorageNamespaceImpl.h.
- WebProcess/WebStorage/WebStorageNamespaceProvider.cpp: Renamed from Source/WebKit/WebProcess/Storage/WebStorageNamespaceProvider.cpp.
- WebProcess/WebStorage/WebStorageNamespaceProvider.h: Renamed from Source/WebKit/WebProcess/Storage/WebStorageNamespaceProvider.h.
- 3:15 PM Changeset in webkit [219965] by
-
- 2 edits in trunk/Tools
Make run-javascriptcore-test run testair, testb3, and testmasm.
https://bugs.webkit.org/show_bug.cgi?id=174837
<rdar://problem/33522927>
Reviewed by Saam Barati and Filip Pizlo.
- Refactors code for running testapi so that we can use it to run other tests.
- Added running of testmasm, testair, testb3.
Note: the existing testapi invocation code does not support remote invocation of
the tests (e.g. on a ARM device). Hence, the new additions of testmasm, testair,
and testb3 also do not support remote invocation. If we wish to add remote
invocation support, we should do that in a separate patch.
- Scripts/run-javascriptcore-tests:
(testPath):
(runTest):
(testapiPath): Deleted.
- 2:45 PM Changeset in webkit [219964] by
-
- 29 edits6 copies6 adds in trunk
Web Inspector: create protocol for recording Canvas contexts
https://bugs.webkit.org/show_bug.cgi?id=174481
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- inspector/protocol/Canvas.json:
- Add
requestRecordingcommand to mark the provided canvas as having requested a recording. - Add
cancelRecordingcommand to clear a previously marked canvas and flush any recorded data. - Add
recordingFinishedevent that is fired once a recording is finished.
- Add
- CMakeLists.txt:
- DerivedSources.make:
- inspector/protocol/Recording.json: Added.
- Add
Typeenum that lists the types of recordings - Add
InitialStatetype that contains information about the canvas context at the beginning of the recording. - Add
Frametype that holds a list of actions that were recorded. - Add
Recordingtype as the container object of recording data.
- Add
- inspector/scripts/codegen/generate_js_backend_commands.py:
(JSBackendCommandsGenerator.generate_domain):
Create an agent for domains with no events or commands.
- inspector/InspectorValues.h:
Make Array
getpublic so that values can be retrieved if needed.
Source/WebCore:
Currently, a recording doesn't actually "start" until an action is performed on the context.
This change adds the recording logic, but it does not use it anywhere. Additonal tests will
be added in the patches that add uses:
- <https://webkit.org/b/174482> Web Inspector: Record actions performed on CanvasRenderingContext2D
- <https://webkit.org/b/174483> Web Inspector: Record actions performed on WebGLRenderingContext
Test: inspector/model/recording.html
- bindings/scripts/IDLAttributes.json:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateAttributeGetterBodyDefinition):
(GenerateAttributeSetterBodyDefinition):
(GenerateImplementationFunctionCall):
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/CallTracer.h: Added.
- bindings/js/CallTracer.cpp: Added.
(WebCore::CallTracer::recordCanvasAction):
- bindings/js/CallTracerTypes.h: Added.
- bindings/scripts/test/TestCallTracer.idl: Added.
- bindings/scripts/test/JS/JSTestCallTracer.h: Added.
- bindings/scripts/test/JS/JSTestCallTracer.cpp: Added.
Create new IDL extended attribute called "CallTracingCallback" that will add code to call a
static function on CallTracer with the given extended attribute value as the function name,
theimplobject as the first parameter, the name of the attribute/operation as the second,
and an optional object that accepts an initializer list of all the parameters as the third.
This function will not be called, however, unless a
callTracingActivefunction on the
implobject returns true, and this is marked as UNLIKELY.
"CallTracingCallback" can be added to an Interface, in which case it will apply to all
attributes/operations of the generated class, or an individual Attribute/Operation.
- html/canvas/CanvasRenderingContext.h:
(WebCore::CanvasRenderingContext::callTracingActive):
(WebCore::CanvasRenderingContext::setCallTracingActive):
- inspector/InspectorCanvas.h:
- inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::~InspectorCanvas):
(WebCore::InspectorCanvas::resetRecordingData):
(WebCore::InspectorCanvas::hasRecordingData):
(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::releaseInitialState):
(WebCore::InspectorCanvas::releaseFrames):
(WebCore::InspectorCanvas::releaseData):
(WebCore::InspectorCanvas::markNewFrame):
(WebCore::InspectorCanvas::markCurrentFrameIncomplete):
(WebCore::InspectorCanvas::setBufferLimit):
(WebCore::InspectorCanvas::hasBufferSpace):
(WebCore::InspectorCanvas::singleFrame):
(WebCore::InspectorCanvas::setSingleFrame):
(WebCore::InspectorCanvas::indexForData):
(WebCore::buildArrayForAffineTransform):
(WebCore::buildArrayForVector):
(WebCore::InspectorCanvas::buildInitialState):
(WebCore::InspectorCanvas::buildAction):
(WebCore::InspectorCanvas::buildArrayForCanvasGradient):
(WebCore::InspectorCanvas::buildArrayForCanvasPattern):
(WebCore::InspectorCanvas::buildArrayForImageData):
Hold the recording data on the corresponding InspectorCanvas. Recording Frames are
completed when the HTMLCanvasElement paints or a 0_s timer is fired. A recording is not
considered valid until at least one action is performed on the canvas context. Once that
condition is satisfied, canceling the recording will flush the data.
- inspector/InspectorCanvasAgent.h:
- inspector/InspectorCanvasAgent.cpp:
(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::disable):
(WebCore::InspectorCanvasAgent::requestRecording):
(WebCore::InspectorCanvasAgent::cancelRecording):
(WebCore::InspectorCanvasAgent::recordCanvasAction):
(WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):
(WebCore::InspectorCanvasAgent::canvasDestroyed):
(WebCore::InspectorCanvasAgent::canvasRecordingTimerFired):
(WebCore::InspectorCanvasAgent::clearCanvasData):
- inspector/InspectorInstrumentation.h:
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::recordCanvasAction):
(WebCore::InspectorInstrumentation::recordCanvasActionImpl):
(WebCore::InspectorInstrumentation::didFinishRecordingCanvasFrameImpl):
- html/canvas/CanvasRenderingContext2D.h:
- html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::stringForWindingRule):
(WebCore::CanvasRenderingContext2D::stringForImageSmoothingQuality):
- platform/graphics/Gradient.h:
(WebCore::Gradient::stops):
- svg/SVGPathUtilities.h:
- svg/SVGPathUtilities.cpp:
(WebCore::buildStringFromPath):
Source/WebInspectorUI:
Create model objects that effectively mirror the protocol objects sent for Canvas recordings.
- .eslintrc:
- UserInterface/Main.html:
- UserInterface/Test.html:
- UserInterface/Controllers/CanvasManager.js:
(WebInspector.CanvasManager.prototype.recordingFinished):
- UserInterface/Protocol/CanvasObserver.js:
(WebInspector.CanvasObserver.prototype.recordingFinished):
- UserInterface/Models/Recording.js: Added.
(WebInspector.Recording):
(WebInspector.Recording.fromPayload):
(WebInspector.Recording.prototype.get type):
(WebInspector.Recording.prototype.get initialState):
(WebInspector.Recording.prototype.get frames):
(WebInspector.Recording.prototype.get data):
(WebInspector.Recording.prototype.toJSON):
- UserInterface/Models/RecordingAction.js: Added.
(WebInspector.RecordingAction):
(WebInspector.RecordingAction.fromPayload):
(WebInspector.RecordingAction.prototype.get name):
(WebInspector.RecordingAction.prototype.get parameters):
(WebInspector.RecordingAction.prototype.toJSON):
- UserInterface/Models/RecordingFrame.js: Added.
(WebInspector.RecordingFrame):
(WebInspector.RecordingFrame.fromPayload):
(WebInspector.RecordingFrame.prototype.get actions):
(WebInspector.RecordingFrame.prototype.get incomplete):
(WebInspector.RecordingFrame.prototype.toJSON):
LayoutTests:
- inspector/model/recording-expected.txt: Added.
- inspector/model/recording.html: Added.
- 2:38 PM Changeset in webkit [219963] by
-
- 3 edits in trunk/Tools
Remove duplicate code from Buildbot.js in dashboard
https://bugs.webkit.org/show_bug.cgi?id=174870
Reviewed by Daniel Bates.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Buildbot.js:
(Buildbot.prototype.javaScriptCoreTestFailuresURLForIteration): Remove duplicate code and reuse buildPageURLForIteration() to construct URL.
(Buildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto.
- BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/tests/resources/MockBuildbot.js:
(MockBuildbot.prototype.javaScriptCoreTestStdioUrlForIteration): Ditto for tests.
- 2:02 PM Changeset in webkit [219962] by
-
- 9 copies1 add in releases/Apple/Safari Technology Preview 36
Added a tag for Safari Technology Preview release 36.
- 1:51 PM Changeset in webkit [219961] by
-
- 30 edits17 adds in trunk
Implement document.elementsFromPoint
https://bugs.webkit.org/show_bug.cgi?id=153137
Patch by Ali Juma <ajuma@chromium.org> on 2017-07-26
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
Add tests from upstream pull request https://github.com/w3c/web-platform-tests/pull/6568.
- web-platform-tests/cssom-view/elementsFromPoint-expected.txt: Added.
- web-platform-tests/cssom-view/elementsFromPoint-iframes-expected.txt: Added.
- web-platform-tests/cssom-view/elementsFromPoint-iframes.html: Added.
- web-platform-tests/cssom-view/elementsFromPoint-invalid-cases-expected.txt: Added.
- web-platform-tests/cssom-view/elementsFromPoint-invalid-cases.html: Added.
- web-platform-tests/cssom-view/elementsFromPoint-shadowroot-expected.txt: Added.
- web-platform-tests/cssom-view/elementsFromPoint-shadowroot.html: Added.
- web-platform-tests/cssom-view/elementsFromPoint-simple-expected.txt: Added.
- web-platform-tests/cssom-view/elementsFromPoint-simple.html: Added.
- web-platform-tests/cssom-view/elementsFromPoint-svg-expected.txt: Added.
- web-platform-tests/cssom-view/elementsFromPoint-svg.html: Added.
- web-platform-tests/cssom-view/elementsFromPoint-table-expected.txt: Added.
- web-platform-tests/cssom-view/elementsFromPoint-table.html: Added.
- web-platform-tests/cssom-view/negativeMargins-expected.txt:
- web-platform-tests/cssom-view/resources/elementsFromPoint.js: Added.
(nodeToString.prototype.else):
(nodeListToString):
(assertElementsFromPoint):
(checkElementsFromPointFourCorners):
- web-platform-tests/cssom-view/resources/iframe1.html: Added.
- web-platform-tests/cssom-view/resources/iframe2.html: Added.
Source/WebCore:
This ports Blink's implementation of elementsFromPoint, from the
following patches by Philip Rogers (pdr@chromium.org):
-https://src.chromium.org/viewvc/blink?revision=190686&view=revision
-https://src.chromium.org/viewvc/blink?revision=191240&view=revision
-https://src.chromium.org/viewvc/blink?revision=199214&view=revision
Tests: imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-iframes.html
imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-invalid-cases.html
imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-shadowroot.html
imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-simple.html
imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-svg.html
imported/w3c/web-platform-tests/cssom-view/elementsFromPoint-table.html
- dom/DocumentOrShadowRoot.idl:
- dom/TreeScope.cpp:
(WebCore::absolutePointIfNotClipped):
(WebCore::TreeScope::nodeFromPoint):
(WebCore::TreeScope::elementFromPoint):
(WebCore::TreeScope::elementsFromPoint):
- dom/TreeScope.h:
- page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
- rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::nodeAtPoint):
- rendering/HitTestRequest.h:
(WebCore::HitTestRequest::HitTestRequest):
(WebCore::HitTestRequest::resultIsElementList):
(WebCore::HitTestRequest::includesAllElementsUnderPoint):
- rendering/HitTestResult.cpp:
(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):
(WebCore::HitTestResult::addNodeToListBasedTestResult):
(WebCore::HitTestResult::append):
(WebCore::HitTestResult::listBasedTestResult):
(WebCore::HitTestResult::mutableListBasedTestResult):
(WebCore::HitTestResult::addNodeToRectBasedTestResult): Deleted.
(WebCore::HitTestResult::rectBasedTestResult): Deleted.
(WebCore::HitTestResult::mutableRectBasedTestResult): Deleted.
- rendering/HitTestResult.h:
- rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint):
- rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::nodeAtPoint):
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
- rendering/RenderBox.cpp:
(WebCore::RenderBox::nodeAtPoint):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::nodeAtPoint):
- rendering/RenderInline.cpp:
(WebCore::RenderInline::hitTestCulledInline):
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestFixedLayersInNamedFlows):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestContents):
(WebCore::RenderLayer::hitTestList):
(WebCore::RenderLayer::calculateClipRects):
- rendering/RenderTable.cpp:
(WebCore::RenderTable::nodeAtPoint):
- rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::nodeAtPoint):
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::nodeAtPoint):
- rendering/SimpleLineLayoutFunctions.cpp:
(WebCore::SimpleLineLayout::hitTestFlow):
- rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::nodeAtFloatPoint):
- rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::nodeAtFloatPoint):
- rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::nodeAtPoint):
- rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::nodeAtFloatPoint):
- rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::nodeAtPoint):
- testing/Internals.cpp:
(WebCore::Internals::nodesFromRect):
LayoutTests:
- TestExpectations: Unskip a test.
- 1:11 PM Changeset in webkit [219960] by
-
- 44 edits in trunk
Remove DATABASE_PROCESS build flag.
https://bugs.webkit.org/show_bug.cgi?id=174868
Reviewed by Andy Estes.
.:
- Source/cmake/OptionsGTK.cmake:
- Source/cmake/OptionsMac.cmake:
- Source/cmake/OptionsWPE.cmake:
- Source/cmake/WebKitFeatures.cmake:
Source/WebKit:
- CMakeLists.txt:
- DatabaseProcess/DatabaseProcess.cpp:
- DatabaseProcess/DatabaseProcess.h:
- DatabaseProcess/DatabaseProcess.messages.in:
- DatabaseProcess/DatabaseToWebProcessConnection.cpp:
- DatabaseProcess/DatabaseToWebProcessConnection.h:
- DatabaseProcess/DatabaseToWebProcessConnection.messages.in:
- DatabaseProcess/IndexedDB/WebIDBConnectionToClient.messages.in:
- DatabaseProcess/gtk/DatabaseProcessMainGtk.cpp:
- DatabaseProcess/ios/DatabaseProcessIOS.mm:
- DatabaseProcess/mac/DatabaseProcessMac.mm:
- DatabaseProcess/unix/DatabaseProcessMainUnix.h:
- Shared/Databases/DatabaseProcessCreationParameters.cpp:
- Shared/Databases/DatabaseProcessCreationParameters.h:
- Shared/ProcessExecutablePath.h:
- Shared/gtk/ProcessExecutablePathGtk.cpp:
(WebKit::executablePathOfDatabaseProcess):
- Shared/wpe/ProcessExecutablePathWPE.cpp:
(WebKit::executablePathOfDatabaseProcess):
- UIProcess/ChildProcessProxy.cpp:
(WebKit::ChildProcessProxy::getLaunchOptions):
- UIProcess/Databases/DatabaseProcessProxy.cpp:
- UIProcess/Databases/DatabaseProcessProxy.h:
- UIProcess/Databases/DatabaseProcessProxy.messages.in:
- UIProcess/Launcher/ProcessLauncher.h:
- UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::serviceName):
- UIProcess/Launcher/wpe/ProcessLauncherWPE.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::grantSandboxExtensionsToDatabaseProcessForBlobs):
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::databaseProcessCrashed):
(WebKit::WebProcessPool::databaseProcessIdentifier):
(WebKit::WebProcessPool::terminateDatabaseProcess):
- UIProcess/WebProcessPool.h:
(WebKit::WebProcessPool::sendToDatabaseProcessRelaunchingIfNecessary):
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::getDatabaseProcessConnection):
- UIProcess/WebProcessProxy.h:
- UIProcess/WebProcessProxy.messages.in:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::fetchDataAndApply):
(WebKit::WebsiteDataStore::removeData):
- WebKit2Prefix.h:
- WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.messages.in:
- WebProcess/Databases/WebToDatabaseProcessConnection.cpp:
- WebProcess/Databases/WebToDatabaseProcessConnection.h:
- WebProcess/WebProcess.cpp:
- WebProcess/WebProcess.h:
- 1:08 PM Changeset in webkit [219959] by
-
- 2 edits in trunk/Source/WebCore
[GStreamer] Review WebKitWebSource after r219252.
https://bugs.webkit.org/show_bug.cgi?id=174415
Patch by Charlie Turner <cturner@igalia.com> on 2017-07-26
Reviewed by Carlos Garcia Campos.
Remove ResourceHandleStreamingClient, and flatten the StreamingClient
into CachedResourceStreamingClient (the only implemetation left). They
are no longer required after r219252.
Also remove the locking code. It's not needed now, and what existed
was heavy-handed and missed several cases it was supposed to protect
Covered by existing tests.
- platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(webkit_web_src_init):
(webKitWebSrcDispose):
(webKitWebSrcStop):
(webKitWebSrcStart):
(webKitWebSrcNeedData):
(webKitWebSrcEnoughData):
(webKitWebSrcSeek):
(webKitWebSrcSetMediaPlayer):
(CachedResourceStreamingClient::CachedResourceStreamingClient):
(CachedResourceStreamingClient::~CachedResourceStreamingClient):
(CachedResourceStreamingClient::getOrCreateReadBuffer):
(CachedResourceStreamingClient::responseReceived):
(CachedResourceStreamingClient::dataReceived):
(CachedResourceStreamingClient::loadFinished):
(ResourceHandleStreamingClient::create): Deleted.
(): Deleted.
(StreamingClient::StreamingClient): Deleted.
(StreamingClient::~StreamingClient): Deleted.
(StreamingClient::createReadBuffer): Deleted.
(StreamingClient::handleResponseReceived): Deleted.
(StreamingClient::handleDataReceived): Deleted.
(StreamingClient::handleNotifyFinished): Deleted.
(ResourceHandleStreamingClient::ResourceHandleStreamingClient): Deleted.
(ResourceHandleStreamingClient::~ResourceHandleStreamingClient): Deleted.
(ResourceHandleStreamingClient::cleanupAndStopRunLoop): Deleted.
(ResourceHandleStreamingClient::invalidate): Deleted.
(ResourceHandleStreamingClient::loadFailed): Deleted.
(ResourceHandleStreamingClient::setDefersLoading): Deleted.
(ResourceHandleStreamingClient::getOrCreateReadBuffer): Deleted.
(ResourceHandleStreamingClient::willSendRequest): Deleted.
(ResourceHandleStreamingClient::didReceiveResponse): Deleted.
(ResourceHandleStreamingClient::didReceiveData): Deleted.
(ResourceHandleStreamingClient::didReceiveBuffer): Deleted.
(ResourceHandleStreamingClient::didFinishLoading): Deleted.
(ResourceHandleStreamingClient::didFail): Deleted.
(ResourceHandleStreamingClient::wasBlocked): Deleted.
(ResourceHandleStreamingClient::cannotShowURL): Deleted.
- 1:00 PM Changeset in webkit [219958] by
-
- 6 edits in trunk
Add test to verify certain child processes are not launched as a side effect of enabling ResourceLoadStatistics.
https://bugs.webkit.org/show_bug.cgi?id=174851
Reviewed by Chris Dumez.
Source/WebKit:
- UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _databaseProcessIdentifier]):
(-[WKProcessPool _pluginProcessCount]):
- UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
- UIProcess/Plugins/PluginProcessManager.h:
(WebKit::PluginProcessManager::pluginProcesses):
Tools:
- TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm:
(TEST):
- 12:24 PM Changeset in webkit [219957] by
-
- 2 edits in branches/safari-604-branch/LayoutTests
Cherry-pick r219877. rdar://problem/33523803
- 12:24 PM Changeset in webkit [219956] by
-
- 60 edits9 adds in branches/safari-604-branch
Cherry-pick r219876. rdar://problem/33523847
- 12:24 PM Changeset in webkit [219955] by
-
- 47 edits9 deletes in branches/safari-604-branch
Cherry-pick r219620. rdar://problem/33523847
- 11:40 AM Changeset in webkit [219954] by
-
- 91 edits in trunk
Remove WEB_TIMING feature flag
https://bugs.webkit.org/show_bug.cgi?id=174795
Reviewed by Alex Christensen.
.:
- Source/cmake/OptionsWPE.cmake:
- Source/cmake/OptionsWin.cmake:
- Source/cmake/WebKitFeatures.cmake:
- Source/cmake/tools/vsprops/FeatureDefines.props:
- Source/cmake/tools/vsprops/FeatureDefinesCairo.props:
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
- bindings/js/JSPerformanceEntryCustom.cpp:
- dom/Document.cpp:
(WebCore::Document::setReadyState):
(WebCore::Document::finishedParsing):
- dom/Document.h:
(WebCore::Document::timing):
- dom/DocumentTiming.h:
- dom/EventTargetFactory.in:
- loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::finishedTimingForWorkerLoad):
(WebCore::DocumentThreadableLoader::loadRequest):
- loader/DocumentThreadableLoader.h:
- loader/ResourceTimingInformation.cpp:
- loader/ResourceTimingInformation.h:
- loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::reportResourceTiming):
- loader/SubresourceLoader.h:
- loader/ThreadableLoaderClient.h:
(WebCore::ThreadableLoaderClient::didFail):
(WebCore::ThreadableLoaderClient::didFinishTiming):
- loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishTiming):
- loader/WorkerThreadableLoader.h:
- loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::revalidateResource):
(WebCore::CachedResourceLoader::loadResource):
- loader/cache/CachedResourceLoader.h:
(WebCore::CachedResourceLoader::resourceTimingInformation):
- page/DOMWindow.cpp:
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::resetDOMWindowProperties):
(WebCore::DOMWindow::nowTimestamp):
(WebCore::DOMWindow::removeAllEventListeners):
- page/DOMWindow.h:
- page/GlobalPerformance.idl:
- page/Performance.cpp:
- page/Performance.h:
- page/Performance.idl:
- page/PerformanceEntry.cpp:
- page/PerformanceEntry.h:
- page/PerformanceEntry.idl:
- page/PerformanceMark.h:
- page/PerformanceMark.idl:
- page/PerformanceMeasure.h:
- page/PerformanceMeasure.idl:
- page/PerformanceNavigation.cpp:
- page/PerformanceNavigation.h:
- page/PerformanceNavigation.idl:
- page/PerformanceObserver.cpp:
- page/PerformanceObserver.h:
- page/PerformanceObserver.idl:
- page/PerformanceObserverCallback.h:
- page/PerformanceObserverCallback.idl:
- page/PerformanceObserverEntryList.cpp:
- page/PerformanceObserverEntryList.h:
- page/PerformanceObserverEntryList.idl:
- page/PerformanceResourceTiming.cpp:
- page/PerformanceResourceTiming.h:
- page/PerformanceResourceTiming.idl:
- page/PerformanceTiming.cpp:
- page/PerformanceTiming.h:
- page/PerformanceTiming.idl:
- page/PerformanceUserTiming.cpp:
- page/PerformanceUserTiming.h:
- platform/network/ResourceHandle.h:
- platform/network/ResourceHandleInternal.h:
- platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::start):
- platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
- platform/network/cf/SynchronousResourceHandleCFURLConnectionDelegate.cpp:
(WebCore::SynchronousResourceHandleCFURLConnectionDelegate::didReceiveResponse):
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandleInternal::didFinish):
(WebCore::ResourceHandleInternal::calculateWebTimingInformations):
(WebCore::ResourceHandleInternal::dispatchSynchronousJob):
- platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):
- platform/network/mac/WebCoreResourceHandleAsDelegate.mm:
(-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
- platform/network/mac/WebCoreResourceHandleAsOperationQueueDelegate.mm:
(-[WebCoreResourceHandleAsOperationQueueDelegate connection:didReceiveResponse:]):
- platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::restartedCallback):
(WebCore::sendRequestCallback):
(WebCore::createSoupMessageForHandleAndRequest):
(WebCore::ResourceHandle::sendPendingRequest):
- platform/network/soup/SoupNetworkSession.cpp:
(WebCore::SoupNetworkSession::SoupNetworkSession):
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::WorkerGlobalScope):
(WebCore::WorkerGlobalScope::~WorkerGlobalScope):
(WebCore::WorkerGlobalScope::removeAllEventListeners):
- workers/WorkerGlobalScope.h:
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig:
Source/WebInspectorUI:
Remove fallback for ports that lack WEB_TIMING.
- UserInterface/Base/Utilities.js:
(timestamp): Deleted.
- UserInterface/Protocol/Connection.js:
(InspectorBackend.Connection.prototype._dispatchResponse):
(InspectorBackend.Connection.prototype._dispatchEvent):
(InspectorBackend.Connection.prototype._sendCommandToBackendWithCallback):
(InspectorBackend.Connection.prototype._sendCommandToBackendExpectingPromise):
- UserInterface/Protocol/MessageDispatcher.js:
(WebInspector.dispatchNextQueuedMessageFromBackend):
Source/WebKit:
- Configurations/FeatureDefines.xcconfig:
- NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::NetworkDataTaskSoup):
(WebKit::NetworkDataTaskSoup::createRequest):
(WebKit::NetworkDataTaskSoup::didSendRequest):
(WebKit::NetworkDataTaskSoup::dispatchDidReceiveResponse):
(WebKit::NetworkDataTaskSoup::dispatchDidCompleteWithError):
(WebKit::NetworkDataTaskSoup::continueHTTPRedirection):
(WebKit::NetworkDataTaskSoup::didGetHeaders):
(WebKit::NetworkDataTaskSoup::didRestart):
- NetworkProcess/soup/NetworkDataTaskSoup.h:
Source/WebKitLegacy/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
LayoutTests:
- inspector/formatting/resources/javascript-tests/sample-normal-utilities-expected.js:
(decodeBase64ToBlob):
(timestamp): Deleted.
- inspector/formatting/resources/javascript-tests/sample-normal-utilities.js:
(decodeBase64ToBlob):
(timestamp): Deleted.
- 11:33 AM Changeset in webkit [219953] by
-
- 3 edits in trunk/LayoutTests
Rebaselined multiple fast/css/getComputedStyle.
<rdar://problem/33416054>
Unreviewed test gardening.
- platform/mac-highsierra/fast/css/getComputedStyle/computed-style-expected.txt:
- platform/mac-highsierra/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
- 11:32 AM Changeset in webkit [219952] by
-
- 2 edits in trunk/Source/WebKit
Use SandboxExtension::HandleArray when sending extensions for file uploads to the web process
https://bugs.webkit.org/show_bug.cgi?id=174828
Reviewed by Tim Horton.
In the previous change I forgot to hoist the HandleArray and message-send out of the
loop, so the code wasn't actually sending fewer messages. That's fixed now.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChooseFilesForOpenPanelWithDisplayStringAndIcon):
(WebKit::WebPageProxy::didChooseFilesForOpenPanel):
- 11:31 AM Changeset in webkit [219951] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add the ability to change sp and pc to the ARM64 JIT probe.
https://bugs.webkit.org/show_bug.cgi?id=174697
<rdar://problem/33436965>
Reviewed by JF Bastien.
This patch implements the following:
- The ARM64 probe now supports modifying the pc and sp.
However, lr is not preserved when modifying the pc because it is used as the
scratch register for the indirect jump. Hence, the probe handler function
may not modify both lr and pc in the same probe invocation.
- Fix probe tests to use bitwise comparison when comparing double register values. Otherwise, equivalent nan values will be interpreted as not equivalent.
- Change the minimum offset increment in testProbeModifiesStackPointer to be 16 bytes for ARM64. This is because the ARM64 probe now uses the ldp and stp instructions which require 16 byte alignment for their memory access.
- assembler/MacroAssemblerARM64.cpp:
(JSC::arm64ProbeError):
(JSC::MacroAssembler::probe):
(JSC::arm64ProbeTrampoline): Deleted.
- assembler/testmasm.cpp:
(JSC::isSpecialGPR):
(JSC::testProbeReadsArgumentRegisters):
(JSC::testProbeWritesArgumentRegisters):
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesStackPointerToInsideProbeContextOnStack):
(JSC::testProbeModifiesStackPointerToNBytesBelowSP):
- 10:15 AM Changeset in webkit [219950] by
-
- 8 edits2 adds in trunk
Pressing the Escape key should not be a valid user gesture to enter fullscreen
https://bugs.webkit.org/show_bug.cgi?id=174864
<rdar://problem/33009088>
Reviewed by Geoffrey Garen.
Source/WebCore:
Pressing the Escape key should not be a valid user gesture to enter fullscreen since this
is the gesture to exit fullscreen already.
Test: fullscreen/requestFullscreen-escape-key.html
- dom/Document.cpp:
(WebCore::Document::requestFullScreenForElement):
- dom/UserGestureIndicator.cpp:
(WebCore::UserGestureIndicator::UserGestureIndicator):
- dom/UserGestureIndicator.h:
(WebCore::UserGestureToken::create):
(WebCore::UserGestureToken::gestureType):
(WebCore::UserGestureToken::UserGestureToken):
- page/EventHandler.cpp:
(WebCore::EventHandler::internalKeyEvent):
Tools:
Add support for eventSender.keyDown('escape') in DRT to match the behavior of
WKTR.
- DumpRenderTree/mac/EventSendingController.mm:
(-[EventSendingController keyDown:withModifiers:withLocation:]):
LayoutTests:
Add layout test coverage.
- fullscreen/requestFullscreen-escape-key-expected.txt: Added.
- fullscreen/requestFullscreen-escape-key.html: Added.
- 9:53 AM Changeset in webkit [219949] by
-
- 5 edits in trunk
AX: Incorrect range from index and length in contenteditable with <p> tags
https://bugs.webkit.org/show_bug.cgi?id=174856
Reviewed by Chris Fleizach.
Source/WebCore:
When asking for the string inside a text control with a given range, we sometimes get
a wrong string at the line boundary due to a bad plain range to text marker conversion.
To fix this, we should use the exsisting method on text controls to avoid this issue.
Updated the test to test the problematic case.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
LayoutTests:
- accessibility/mac/range-for-contenteditable-newline-expected.txt:
- accessibility/mac/range-for-contenteditable-newline.html:
- 8:29 AM Changeset in webkit [219948] by
-
- 3 edits in trunk/Source/WebCore
[Curl] Bug fix after r219606
https://bugs.webkit.org/show_bug.cgi?id=174845
Patch by Daewoong Jang <daewoong.jang@navercorp.com> on 2017-07-26
Reviewed by Alex Christensen.
- platform/network/curl/CurlContext.h:
(WebCore::CurlSList::isEmpty):
- platform/network/curl/ResourceHandleCurl.cpp:
(WebCore::ResourceHandleInternal::didReceiveHeaderLine):
(WebCore::ResourceHandleInternal::headerCallback):
- 8:27 AM Changeset in webkit [219947] by
-
- 2 edits in trunk/LayoutTests
Remove obsolete failure annotation for bad-charset-alias.html.
https://bugs.webkit.org/show_bug.cgi?id=145048
Patch by Ms2ger <Ms2ger@igalia.com> on 2017-07-26
Reviewed by Carlos Garcia Campos.
This appears to have been fixed in r204850.
- platform/gtk/TestExpectations:
- 7:33 AM Changeset in webkit [219946] by
-
- 4 edits in trunk/Source/WebCore
[EME][GStreamer] Multi-key support in the GStreamer ClearKey decryptor
https://bugs.webkit.org/show_bug.cgi?id=174779
Reviewed by Xabier Rodriguez-Calvar.
In the CENC decryptor, the key ID value is retrieved from the info structure
on the GstProtectionMeta object. GstBuffer for that value is retrieved and
passed to the setupCipher() function.
In the ClearKey decryptor (which extends the CENC decryptor), the single
GstBuffer object on the private instance that holds the key value is replaced
with a Vector object that holds pairs of key ID and value GstBuffers. In the
handleKeyResponse() implementation that Vector is emptied and then refilled
with key ID and value pairs that are passed in through the drm-cipher-clearkey
structure that's attached to the GstEvent that signalled new key information.
In the ClearKey decryptor's setupCipher() implementation the passed-in key ID
buffer is used to find a matching key ID and value pair stored on the private
instance. If not found, an error is thrown. If found, the matching key value
is used for decryption.
- platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:
(webKitMediaClearKeyDecryptorHandleKeyResponse):
(webKitMediaClearKeyDecryptorSetupCipher):
- platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:
(webkitMediaCommonEncryptionDecryptTransformInPlace):
(webKitMediaCommonEncryptionDecryptDefaultSetupCipher):
- platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.h:
- 7:31 AM Changeset in webkit [219945] by
-
- 2 edits in trunk/Source/WebCore
[EME][GStreamer] Handle ClearKey as a supported key system
https://bugs.webkit.org/show_bug.cgi?id=174778
Reviewed by Xabier Rodriguez-Calvar.
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::supportsKeySystem):
Return true for the 'org.w3.clearkey' key system when building with
ENCRYPTED_MEDIA enabled. The underlying implementation will follow.
- 7:23 AM Changeset in webkit [219944] by
-
- 2 edits1 add in trunk/Websites/webkit.org
Unreviewed, minor adjustments to the previous demo.
Patch by Frederic Wang <fwang@igalia.com> on 2017-07-26
- demos/frames/index.html: Added. Index page for the list of demos.
- demos/frames/sandboxing/index.html: Minor fixes.
- 6:52 AM Changeset in webkit [219943] by
-
- 2 edits in trunk/Source/WebCore
[WPE] Fix a potential crash in the platform pasteboard when reading a string
https://bugs.webkit.org/show_bug.cgi?id=174859
Reviewed by Žan Doberšek.
We shouldn't assume that the wpe_pasteboard_string struct will be
filled in, so initialize it.
- platform/wpe/PlatformPasteboardWPE.cpp:
(WebCore::PlatformPasteboard::readString): Initialize the struct
before passing it to wpe and early return if it's still empty.
- 6:43 AM Changeset in webkit [219942] by
-
- 1 edit8 adds in trunk/Websites/webkit.org
Unreviewed, add demos (frame sandboxing and scrolling) for a blog post.
Patch by Frederic Wang <fwang@igalia.com> on 2017-07-26
- demos/frames/sandboxing/am-i-sandboxed.html: Added.
- demos/frames/sandboxing/framebusting-success.html: Added.
- demos/frames/sandboxing/framebusting-without-user-activation.html: Added.
- demos/frames/sandboxing/index.html: Added.
- demos/frames/scrollable-iframes.html: Added.
- demos/frames/scrollingElement.html: Added.
- 6:41 AM Changeset in webkit [219941] by
-
- 2 edits in trunk/Tools
Unreviewed, added Romain Bellessort to contributors.json.
- Scripts/webkitpy/common/config/contributors.json:
- 6:09 AM Changeset in webkit [219940] by
-
- 2 edits in trunk/Source/WebKit
Unreviewed. Fix a compiler warning that springs up when
building the WPE port with Clang.
- UIProcess/API/wpe/ScrollGestureController.h:
Let ScrollGestureController be a class, and not a struct.
This fits the usual pattern, and also matches the forward
declaration used in WPE's PageClientImpl.h.
- 3:33 AM Changeset in webkit [219939] by
-
- 2 edits in trunk/LayoutTests
Remove obsolete failure expectations for 2d.fillStyle.parse.{rgb,rgba}-eof.
https://bugs.webkit.org/show_bug.cgi?id=174857
Patch by Ms2ger <Ms2ger@igalia.com> on 2017-07-26
Reviewed by Žan Doberšek.
These tests started passing in r209666.
- platform/gtk/TestExpectations:
- 2:52 AM Changeset in webkit [219938] by
-
- 6 edits in branches/safari-604-branch
Cherry-pick r219764. rdar://problem/33523878
- 2:52 AM Changeset in webkit [219937] by
-
- 18 edits in branches/safari-604-branch/Source/WebCore
Cherry-pick r219762. rdar://problem/33523889
- 2:52 AM Changeset in webkit [219936] by
-
- 2 edits in branches/safari-604-branch/Source/WebKit
Cherry-pick r219739. rdar://problem/33523884
- 2:52 AM Changeset in webkit [219935] by
-
- 4 edits in branches/safari-604-branch/Source/WebCore
Cherry-pick r219738. rdar://problem/33523826
- 2:52 AM Changeset in webkit [219934] by
-
- 8 edits2 adds in branches/safari-604-branch
Cherry-pick r219594. rdar://problem/33523357
- 2:52 AM Changeset in webkit [219933] by
-
- 3 edits in branches/safari-604-branch/Source/WebKit
Cherry-pick r219845. rdar://problem/33523884
- 2:52 AM Changeset in webkit [219932] by
-
- 2 edits in branches/safari-604-branch/LayoutTests
Cherry-pick r219841. rdar://problem/33524930
- 2:52 AM Changeset in webkit [219931] by
-
- 2 edits in branches/safari-604-branch/LayoutTests
Cherry-pick r219837. rdar://problem/33524936
- 2:52 AM Changeset in webkit [219930] by
-
- 3 edits1 copy in branches/safari-604-branch/Tools
Cherry-pick r219836. rdar://problem/33523818
- 2:52 AM Changeset in webkit [219929] by
-
- 12 edits2 adds in branches/safari-604-branch
Cherry-pick r219829. rdar://problem/33523803
- 2:52 AM Changeset in webkit [219928] by
-
- 2 edits in branches/safari-604-branch/Source/WebKit
Cherry-pick r219765. rdar://problem/33523818
- 2:52 AM Changeset in webkit [219927] by
-
- 3 edits in branches/safari-604-branch/Source/WebCore
Cherry-pick r219761. rdar://problem/33523829
- 2:51 AM Changeset in webkit [219926] by
-
- 8 edits in branches/safari-604-branch/Source/WebCore
Cherry-pick r219756. rdar://problem/33523829
- 2:51 AM Changeset in webkit [219925] by
-
- 5 edits2 adds in branches/safari-604-branch
Cherry-pick r219755. rdar://problem/33523843
- 2:51 AM Changeset in webkit [219924] by
-
- 2 edits in branches/safari-604-branch/Source/WebKit
Cherry-pick r219754. rdar://problem/33523873
- 2:51 AM Changeset in webkit [219923] by
-
- 2 edits in branches/safari-604-branch/Source/WebCore
Cherry-pick r219752. rdar://problem/33524766
- 2:51 AM Changeset in webkit [219922] by
-
- 7 edits2 adds in branches/safari-604-branch
Cherry-pick r219751. rdar://problem/33523861
- 2:51 AM Changeset in webkit [219921] by
-
- 3 edits1 delete in branches/safari-604-branch/Source/WebKit
Cherry-pick r219750. rdar://problem/33523870
- 2:51 AM Changeset in webkit [219920] by
-
- 2 edits in branches/safari-604-branch/Source/WebCore
Cherry-pick r219742. rdar://problem/33523798
- 2:51 AM Changeset in webkit [219919] by
-
- 2 edits in branches/safari-604-branch/Source/WebCore
Cherry-pick r219737. rdar://problem/33523854
- 2:51 AM Changeset in webkit [219918] by
-
- 2 edits in branches/safari-604-branch/Source/WebCore
Cherry-pick r219736. rdar://problem/33523835
- 2:51 AM Changeset in webkit [219917] by
-
- 3 edits2 adds in branches/safari-604-branch
Cherry-pick r219638. rdar://problem/33523787
- 2:51 AM Changeset in webkit [219916] by
-
- 47 edits9 adds in branches/safari-604-branch
Cherry-pick r219610. rdar://problem/33523847
- 2:51 AM Changeset in webkit [219915] by
-
- 9 edits in branches/safari-604-branch
Revert r219342. rdar://problem/33523803
- 2:48 AM Changeset in webkit [219914] by
-
- 3 edits16 adds in trunk
InsertOrderedList command applied to table cells inserts an extra BR before the table
https://bugs.webkit.org/show_bug.cgi?id=174593
Reviewed by Darin Adler.
Source/WebCore:
Don't add BR when pruning empty blocks if it's the start of a paragraph.
The function MoveParagraph is used for several operations and editing
commands, like 'insertOrderedList'. When moving paragraphs we check out
whether we should add a 'br' element to avoid undesired block collapse.
However, we shouldn't do this when destination is the start of a
paragraph.
Tests: editing/inserting/insert-list-in-table-cell-01.html
editing/inserting/insert-list-in-table-cell-02.html
editing/inserting/insert-list-in-table-cell-03.html
editing/inserting/insert-list-in-table-cell-04.html
editing/inserting/insert-list-in-table-cell-05.html
editing/inserting/insert-list-in-table-cell-06.html
editing/inserting/insert-list-in-table-cell-07.html
editing/inserting/insert-list-in-table-cell-08.html
- editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::moveParagraphs):
LayoutTests:
Tests to verify that the insertOrderedList command works as expected when applied
in table cells.
- editing/inserting/insert-list-in-table-cell-01.html: Added.
- editing/inserting/insert-list-in-table-cell-01-expected.txt: Added.
- editing/inserting/insert-list-in-table-cell-02.html: Added.
- editing/inserting/insert-list-in-table-cell-02-expected.txt: Added.
- editing/inserting/insert-list-in-table-cell-03.html: Added.
- editing/inserting/insert-list-in-table-cell-03-expected.txt: Added.
- editing/inserting/insert-list-in-table-cell-04.html: Added.
- editing/inserting/insert-list-in-table-cell-04-expected.txt: Added.
- editing/inserting/insert-list-in-table-cell-05.html: Added.
- editing/inserting/insert-list-in-table-cell-05-expected.txt: Added.
- editing/inserting/insert-list-in-table-cell-06.html: Added.
- editing/inserting/insert-list-in-table-cell-06-expected.txt: Added.
- editing/inserting/insert-list-in-table-cell-07.html: Added.
- editing/inserting/insert-list-in-table-cell-07-expected.txt: Added.
- editing/inserting/insert-list-in-table-cell-08.html: Added.
- editing/inserting/insert-list-in-table-cell-08-expected.txt: Added.
- 2:22 AM Changeset in webkit [219913] by
-
- 6 edits1 delete in trunk/LayoutTests
Fix an incorrect check in 2d.missingargs.html.
https://bugs.webkit.org/show_bug.cgi?id=174854
Patch by Ms2ger <Ms2ger@igalia.com> on 2017-07-26
Reviewed by Carlos Garcia Campos.
The check was introduced without explanation in r168302. This change reverts
it to the previous, correct check.
- canvas/philip/tests/2d.missingargs-expected.txt:
- canvas/philip/tests/2d.missingargs.html:
- platform/gtk/TestExpectations:
- platform/ios/TestExpectations:
- platform/mac/canvas/philip/tests/2d.missingargs-expected.txt: Removed.
- platform/wpe/TestExpectations:
- 2:01 AM Changeset in webkit [219912] by
-
- 4 edits in trunk
[WPE] Enable KeyboardEvent key and code attributes
https://bugs.webkit.org/show_bug.cgi?id=174822
Reviewed by Žan Doberšek.
Source/WTF:
There is no reason for this to be disabled from what I see.
- wtf/FeatureDefines.h: Enable KeyboardEvent key and code attributes.
LayoutTests:
- platform/wpe/TestExpectations: Mark
fast/events/constructors/keyboard-event-constructor.html as passing.
- 1:31 AM Changeset in webkit [219911] by
-
- 2 edits in trunk
Unreviewed. Fix WebKit2 derived sources directory creation after r219488.
The variable is still DERIVED_SOURCES_WEBKIT2_DIR, not DERIVED_SOURCES_WEBKIT_DIR. Build was not really affected
because WebKit2 makefile creates the directory too.
- Source/cmake/WebKitFS.cmake:
- 1:26 AM Changeset in webkit [219910] by
-
- 7 edits in trunk
[WPE] WebGL2 support
https://bugs.webkit.org/show_bug.cgi?id=174249
Reviewed by Alex Christensen.
Source/WebCore:
Implement WebGL2 support in GraphicsContext3DCairo for the WPE port, but keep
the implementation specific to libepoxy (which WPE leverages by default).
In the GraphicsContext3D::create() method, we first construct the
GraphicsContext3D object that also ensures a current GL context on this thread.
Only then can we determine through libepoxy whether the underlying GL library
is able to support WebGL2.
For WebGL2, the GLES3 support is required. The initial libepoxy implementation
ensures this only in case of 'non-desktop GL' library of minimum version 3.0.
This effectively translates to the only supported configuration being the
EGL and OpenGL ES 3.0 (or higher) combination. If this cannot be ensured, we
discard the existing GraphicsContext3D object and return null.
WebGL2 can also be supported via OpenGL (i.e. 'desktop GL'), but this hasn't
been tested yet. Implementation will in the future be extended to support that
as required.
In the GraphicsContext3D constructor itself, the ANGLEWebKitBridge constructor
has to now receive the second argument, the desired shader specification that's
used when parsing the provided shaders. This should be SH_WEBGL_SPEC for WebGL1,
and SH_WEBGL2_SPEC for WebGL2.
No new tests -- a small set of existing WebGL2 tests is unskipped and passing.
- platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::create):
(WebCore::GraphicsContext3D::GraphicsContext3D):
- platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
Add WebGL2-specific methods to the build.
Tools:
- Scripts/webkitperl/FeatureList.pm:
Enable WebGL2 for WPE when building through build-webkit.
LayoutTests:
- platform/wpe/TestExpectations:
Unskip WebGL2 tests under the webgl/ directory. More tests under fast/canvas/webgl2/
will be unskipped later.
- 1:16 AM Changeset in webkit [219909] by
-
- 1 copy in releases/WebKitGTK/webkit-2.17.5
WebKitGTK+ 2.17.5
- 1:15 AM Changeset in webkit [219908] by
-
- 4 edits in trunk
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.17.5 release.
.:
- Source/cmake/OptionsGTK.cmake: Bump version numbers.
Source/WebKit:
- gtk/NEWS: Add release notes for 2.17.5.
- 1:13 AM Changeset in webkit [219907] by
-
- 4 edits in trunk
Unreviewed. Fix GTK distcheck.
Source/WebDriver:
Ensure WebDriver derived sources directory is created, WebKitFS.cmake is useless for this.
- PlatformGTK.cmake:
Tools:
- gtk/make-dist.py:
(ensure_version_if_possible): Use the right pkg-config filename, it's webkit2gtk not webkitgtk.
- 12:39 AM Changeset in webkit [219906] by
-
- 11 edits in trunk
AX: should dispatch accessibilityPerformPressAction async on MacOS
https://bugs.webkit.org/show_bug.cgi?id=174849
Reviewed by Chris Fleizach.
Source/WebCore:
If performing the accessibility press action results in a modal alert being displayed,
it can cause VoiceOver to hang. To fix it, we should dispatch the action asynchronously.
Updated tests to adapt to this change.
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityPerformPressAction]):
(-[WebAccessibilityObjectWrapper _accessibilityPerformPressAction]):
LayoutTests:
- accessibility/file-upload-button-with-axpress.html:
- accessibility/mac/html5-input-number.html:
- accessibility/mac/search-field-cancel-button.html:
- accessibility/press-target-uses-text-descendant-node.html:
- accessibility/press-targets-center-point.html:
- accessibility/press-works-on-control-types.html:
Jul 25, 2017:
- 11:19 PM Changeset in webkit [219905] by
-
- 4 edits in trunk/Source
Icon loader error on startup
https://bugs.webkit.org/show_bug.cgi?id=174787
Reviewed by Brady Eidson.
Source/WebCore:
This is a regression of the new icon loading, it happens with pages that shouldn't have a favicon, like about
pages. IconController::startLoader() did several checks before starting the load that
DocumentLoader::startIconLoading() is not doing. It checked that the frame is the main one, the document can have
an icon (document url is not empty and not about:blank) and that favicon url is in HTTP family. We should do the
same checks now before starting to load icons.
- loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::startIconLoading):
Source/WebKit:
Ignore non HTTP favicons in glib API.
- UIProcess/API/glib/WebKitIconLoadingClient.cpp:
- 10:44 PM Changeset in webkit [219904] by
-
- 13 edits2 adds in trunk
ResourceLoadStatistics grandfathering happens much too often.
<rdar://problem/32655834> and https://bugs.webkit.org/show_bug.cgi?id=174825
Reviewed by Chris Dumez.
Source/WebKit:
The ResourceLoadStatistics grandfathering procedure happens too often.
- With an empty memory store, even though an empty memory store is a perfectly valid state.
- On each launch, even if grandfathering happened on the last launch - because grandfathering data would not automatically be saved to disk.
- After clearing all website data, at which point no grandfathering can possibly be relevant because there is no data to grandfather.
This patch fixes those cases and adds API tests to verify they remain fixed.
- Shared/WebsiteData/WebsiteDataType.h:
- UIProcess/API/Cocoa/WKWebsiteDataStore.mm:
(+[WKWebsiteDataStore _allWebsiteDataTypesIncludingPrivate]): allWebsiteDataTypes, but even with the private ones.
(-[WKWebsiteDataStore _resourceLoadStatisticsClearInMemoryAndPersistentStore]): If the types being cleared cover all of
the types that ResourceLoadStatistics care about, don't grandfather afterwards.
(-[WKWebsiteDataStore _resourceLoadStatisticsClearInMemoryAndPersistentStoreModifiedSinceHours:]): Ditto.
(-[WKWebsiteDataStore _setResourceLoadStatisticsTestingCallback:]):
- UIProcess/API/Cocoa/WKWebsiteDataStorePrivate.h:
- UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.cpp:
(WebKit::ResourceLoadStatisticsPersistentStorage::populateMemoryStoreFromDisk): Don't grandfather if the store read from
disk is empty (as being empty is perfectly fine), and also log the event of "populated without grandfathering".
- UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::topPrivatelyControlledDomainsWithWebsiteData):
- UIProcess/WebResourceLoadStatisticsStore.cpp:
(WebKit::WebResourceLoadStatisticsStore::monitoredDataTypes):
(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):
(WebKit::WebResourceLoadStatisticsStore::~WebResourceLoadStatisticsStore):
(WebKit::WebResourceLoadStatisticsStore::removeDataRecords):
(WebKit::WebResourceLoadStatisticsStore::grandfatherExistingWebsiteData): Schedule a write right away so we don't re-grandfather
on next launch, and also log the grandfathering event.
(WebKit::WebResourceLoadStatisticsStore::scheduleClearInMemoryAndPersistent): Takes a ShouldGrandfather flag
to tell whether or not data should be re-grandfathered after the store is cleared.
(WebKit::WebResourceLoadStatisticsStore::logTestingEvent): Log the event to the testing client.
(WebKit::dataTypesToRemove): Deleted.
- UIProcess/WebResourceLoadStatisticsStore.h:
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled):
(WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback): Handles enabling ResourceLoadStatistics both
with and without a testing callback.
- UIProcess/WebsiteData/WebsiteDataStore.h:
Tools:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKit2Cocoa/EmptyGrandfatheredResourceLoadStatistics.plist: Added.
- TestWebKitAPI/Tests/WebKit2Cocoa/ResourceLoadStatistics.mm: Added.
(TEST):
- 9:42 PM Changeset in webkit [219903] by
-
- 4 edits9 moves3 adds1 delete in trunk/PerformanceTests
Speedometer 2.0: Document es2015-babel-webpack build process
https://bugs.webkit.org/show_bug.cgi?id=174252
Patch by Mathias Bynens <mathias@qiwi.be> on 2017-07-25
Reviewed by Ryosuke Niwa.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/README.md: Added build docs.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/dist/*: Update generated build files.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/package.json: Remove unused items.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/package-lock.json: Added lockfile.
- Speedometer/resources/todomvc/vanilla-examples/es2015-babel-webpack/src/index.html: Make title consistent.
- 9:31 PM Changeset in webkit [219902] by
-
- 7 edits1 delete in trunk/Source/WebCore
[WebIDL] Remove custom bindings for HTMLCanvasElement
https://bugs.webkit.org/show_bug.cgi?id=174847
Reviewed by Darin Adler.
- CMakeLists.txt:
- WebCore.xcodeproj/project.pbxproj:
- bindings/js/JSBindingsAllInOne.cpp:
- bindings/js/JSHTMLCanvasElementCustom.cpp: Removed.
Remove JSHTMLCanvasElementCustom.
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
(WebCore::HTMLCanvasElement::getContext2d):
(WebCore::HTMLCanvasElement::getContextWebGL):
(WebCore::HTMLCanvasElement::getContextWebGPU):
- html/HTMLCanvasElement.h:
- html/HTMLCanvasElement.idl:
Move context picking code to HTMLCanvasElement. Give more
exact types to remaining context getters.
- 7:34 PM Changeset in webkit [219901] by
-
- 20 edits in trunk/Source
Clean up ExceptionCode enumeration
https://bugs.webkit.org/show_bug.cgi?id=174812
Reviewed by Darin Adler.
Clean up ExceptionCode enumeration:
- Updated comments to reflect the latest WebIDL specification
- Drop special values given to some exception codes. Those legacy codes are already in the table inside DOMException.cpp. This also allows us to drop empty rows in the DOMException table
- Drop NoException value in the enumeration and use std::optional<ExceptionCode> when needed instead.
- Modules/indexeddb/shared/IDBError.cpp:
(WebCore::IDBError::IDBError):
(WebCore::IDBError::name):
(WebCore::IDBError::message):
- Modules/indexeddb/shared/IDBError.h:
(WebCore::IDBError::code):
(WebCore::IDBError::encode):
(WebCore::IDBError::decode):
- dom/DOMException.cpp:
- dom/ExceptionCode.h:
- fileapi/FileReaderSync.cpp:
(WebCore::errorCodeToException):
(WebCore::FileReaderSync::startLoading):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
- xml/XMLHttpRequest.h:
- 7:27 PM Changeset in webkit [219900] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Don't output "No message" for multi-value logs like console.log(x, y)
https://bugs.webkit.org/show_bug.cgi?id=174842
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-07-25
Reviewed by Matt Baker.
- Localizations/en.lproj/localizedStrings.js:
Removed "No message".
- UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._appendFormattedArguments):
Track whether or not outputting the next parameter will need a divider
in front of it or not.
- 7:23 PM Changeset in webkit [219899] by
-
- 6 edits in trunk/Source/JavaScriptCore
WebAssembly: generate smaller binaries
https://bugs.webkit.org/show_bug.cgi?id=174818
Reviewed by Filip Pizlo.
This patch reduces generated code size for WebAssembly in 2 ways:
- Use the ZR register when storing zero on ARM64.
- Synthesize wasm context lazily.
This leads to a modest size reduction on both x86-64 and ARM64 for
large WebAssembly games, without any performance loss on WasmBench
and TitzerBench.
The reason this works is that these games, using Emscripten,
generate 100k+ tiny functions, and our JIT allocation granule
rounds all allocations up to 32 bytes. There are plenty of other
simple gains to be had, I've filed a follow-up bug at
webkit.org/b/174819
We should further avoid the per-function cost of tiering, which
represents the bulk of code generated for small functions.
- assembler/MacroAssemblerARM64.h:
(JSC::MacroAssemblerARM64::storeZero64):
- assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::storeZero64):
- b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::createStore): this doesn't make sense
for x86 because it constrains register reuse and codegen in a way
that doesn't affect ARM64 because it has a dedicated zero
register.
- b3/air/AirOpcode.opcodes: add the storeZero64 opcode.
- wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::instanceValue):
(JSC::Wasm::B3IRGenerator::restoreWasmContext):
(JSC::Wasm::B3IRGenerator::B3IRGenerator):
(JSC::Wasm::B3IRGenerator::materializeWasmContext): Deleted.
- 6:58 PM Changeset in webkit [219898] by
-
- 17 edits8 adds1 delete in trunk/Source
B3 should do LICM
https://bugs.webkit.org/show_bug.cgi?id=174750
Reviewed by Keith Miller and Saam Barati.
Source/JavaScriptCore:
Added a LICM phase to B3. This phase is called hoistLoopInvariantValues, to conform to the B3 naming
convention for phases (it has to be an imperative). The phase uses NaturalLoops and BackwardsDominators,
so this adds those analyses to B3. BackwardsDominators was already available in templatized form. This
change templatizes DFG::NaturalLoops so that we can just use it.
The LICM phase itself is really simple. We are decently precise with our handling of everything except
the relationship between control dependence and side exits.
Also added a bunch of tests.
This isn't super important. It's perf-neutral on JS benchmarks. FTL already does LICM on DFG SSA IR, and
probably all current WebAssembly content has had LICM done to it. That being said, this is a cheap phase
so it doesn't hurt to have it.
I wrote it because I thought I needed it for bug 174727. It turns out that there's a better way to
handle the problem I had, so I ended up not needed it - but by then I had already written it. I think
it's good to have it because LICM is one of those core compiler phases; every compiler has it
eventually.
- CMakeLists.txt:
- JavaScriptCore.xcodeproj/project.pbxproj:
- b3/B3BackwardsCFG.h: Added.
(JSC::B3::BackwardsCFG::BackwardsCFG):
- b3/B3BackwardsDominators.h: Added.
(JSC::B3::BackwardsDominators::BackwardsDominators):
- b3/B3BasicBlock.cpp:
(JSC::B3::BasicBlock::appendNonTerminal):
- b3/B3Effects.h:
- b3/B3EnsureLoopPreHeaders.cpp: Added.
(JSC::B3::ensureLoopPreHeaders):
- b3/B3EnsureLoopPreHeaders.h: Added.
- b3/B3Generate.cpp:
(JSC::B3::generateToAir):
- b3/B3HoistLoopInvariantValues.cpp: Added.
(JSC::B3::hoistLoopInvariantValues):
- b3/B3HoistLoopInvariantValues.h: Added.
- b3/B3NaturalLoops.h: Added.
(JSC::B3::NaturalLoops::NaturalLoops):
- b3/B3Procedure.cpp:
(JSC::B3::Procedure::invalidateCFG):
(JSC::B3::Procedure::naturalLoops):
(JSC::B3::Procedure::backwardsCFG):
(JSC::B3::Procedure::backwardsDominators):
- b3/B3Procedure.h:
- b3/testb3.cpp:
(JSC::B3::generateLoop):
(JSC::B3::makeArrayForLoops):
(JSC::B3::generateLoopNotBackwardsDominant):
(JSC::B3::oneFunction):
(JSC::B3::noOpFunction):
(JSC::B3::testLICMPure):
(JSC::B3::testLICMPureSideExits):
(JSC::B3::testLICMPureWritesPinned):
(JSC::B3::testLICMPureWrites):
(JSC::B3::testLICMReadsLocalState):
(JSC::B3::testLICMReadsPinned):
(JSC::B3::testLICMReads):
(JSC::B3::testLICMPureNotBackwardsDominant):
(JSC::B3::testLICMPureFoiledByChild):
(JSC::B3::testLICMPureNotBackwardsDominantFoiledByChild):
(JSC::B3::testLICMExitsSideways):
(JSC::B3::testLICMWritesLocalState):
(JSC::B3::testLICMWrites):
(JSC::B3::testLICMFence):
(JSC::B3::testLICMWritesPinned):
(JSC::B3::testLICMControlDependent):
(JSC::B3::testLICMControlDependentNotBackwardsDominant):
(JSC::B3::testLICMControlDependentSideExits):
(JSC::B3::testLICMReadsPinnedWritesPinned):
(JSC::B3::testLICMReadsWritesDifferentHeaps):
(JSC::B3::testLICMReadsWritesOverlappingHeaps):
(JSC::B3::testLICMDefaultCall):
(JSC::B3::run):
- dfg/DFGBasicBlock.h:
- dfg/DFGCFG.h:
- dfg/DFGNaturalLoops.cpp: Removed.
- dfg/DFGNaturalLoops.h:
(JSC::DFG::NaturalLoops::NaturalLoops):
(JSC::DFG::NaturalLoop::NaturalLoop): Deleted.
(JSC::DFG::NaturalLoop::header): Deleted.
(JSC::DFG::NaturalLoop::size): Deleted.
(JSC::DFG::NaturalLoop::at): Deleted.
(JSC::DFG::NaturalLoop::operator[]): Deleted.
(JSC::DFG::NaturalLoop::contains): Deleted.
(JSC::DFG::NaturalLoop::index): Deleted.
(JSC::DFG::NaturalLoop::isOuterMostLoop): Deleted.
(JSC::DFG::NaturalLoop::addBlock): Deleted.
(JSC::DFG::NaturalLoops::numLoops): Deleted.
(JSC::DFG::NaturalLoops::loop): Deleted.
(JSC::DFG::NaturalLoops::headerOf): Deleted.
(JSC::DFG::NaturalLoops::innerMostLoopOf): Deleted.
(JSC::DFG::NaturalLoops::innerMostOuterLoop): Deleted.
(JSC::DFG::NaturalLoops::belongsTo): Deleted.
(JSC::DFG::NaturalLoops::loopDepth): Deleted.
Source/WTF:
Moved DFG::NaturalLoops to WTF. The new templatized NaturalLoops<> uses the same Graph abstraction as
Dominators<>. This allows us to add a B3::NaturalLoops for free.
Also made small tweaks to RangeSet, which the LICM uses.
- WTF.xcodeproj/project.pbxproj:
- wtf/CMakeLists.txt:
- wtf/Dominators.h:
- wtf/NaturalLoops.h: Added.
(WTF::NaturalLoop::NaturalLoop):
(WTF::NaturalLoop::graph):
(WTF::NaturalLoop::header):
(WTF::NaturalLoop::size):
(WTF::NaturalLoop::at):
(WTF::NaturalLoop::operator[]):
(WTF::NaturalLoop::contains):
(WTF::NaturalLoop::index):
(WTF::NaturalLoop::isOuterMostLoop):
(WTF::NaturalLoop::dump):
(WTF::NaturalLoop::addBlock):
(WTF::NaturalLoops::NaturalLoops):
(WTF::NaturalLoops::graph):
(WTF::NaturalLoops::numLoops):
(WTF::NaturalLoops::loop):
(WTF::NaturalLoops::headerOf):
(WTF::NaturalLoops::innerMostLoopOf):
(WTF::NaturalLoops::innerMostOuterLoop):
(WTF::NaturalLoops::belongsTo):
(WTF::NaturalLoops::loopDepth):
(WTF::NaturalLoops::loopsOf):
(WTF::NaturalLoops::dump):
- wtf/RangeSet.h:
(WTF::RangeSet::begin):
(WTF::RangeSet::end):
(WTF::RangeSet::addAll):
- 6:19 PM Changeset in webkit [219897] by
-
- 5 edits in trunk/Source/JavaScriptCore
GC should be fine with trading blocks between destructor and non-destructor blocks
https://bugs.webkit.org/show_bug.cgi?id=174811
Reviewed by Mark Lam.
Our GC has the ability to trade blocks between MarkedAllocators. A MarkedAllocator is a
size-class-within-a-Subspace. The ability to trade helps reduce memory wastage due to
fragmentation. Prior to this change, this only worked between blocks that did not have destructors.
This was partly a policy decision. But mostly, it was fallout from the way we use theemptyblock
set.
Here's howemptyused to work. If a block is empty, we don't run destructors. We say that a block
is empty if:
A) It has no live objects and its a non-destructor block, or
B) We just allocated it (so it has no destructors even if it's a destructor block), or
C) We just stole it from another allocator (so it also has no destructors), or
D) We just swept the block and ran all destructors.
Case (A) is for trading blocks. That's how a different MarkedAllocator would know that this is a
block that could be stolen.
Cases (B) and (C) need to be detected for correctness, since otherwise we might try to run
destructors in blocks that have garbage bits. In that case, the isZapped check won't detect that
cells don't need destruction, so without having theemptybit we would try to destruct garbage
and crash. Currently, we know that we have cases (B) and (C) when the block is empty.
Case (D) is necessary for detecting which blocks can be removed when weshrinkthe heap.
If we tried to enable trading of blocks between allocators without making any changes to how
emptyworks, then it just would not work. We have to set theemptybits of blocks that have no
live objects in order for those bits to be candidates for trading. But if we do that, then our
logic for cases (B-D) will think that the block has no destructible objects. That's bad, since then
our destructors won't run and we'll leak memory.
This change fixes this issue by decoupling the "do I have destructors" question from the "do I have
live objects" question by introducing a newdestructiblebitvector. The GC flags all live blocks
as being destructible at the end. We clear the destructible bit in cases (B-D). Cases (B-C) are
handled entirely by the new destrictible bit, while case (D) is detected by looking for blocks that
are (empty & ~destructible).
Then we can simply remove all destructor-oriented special-casing of theemptybit. And we can
remove destructor-oriented special-casing of block trading.
This is a perf-neutral change. We expect most free memory to be in non-destructor blocks anyway,
so this change is more about clean-up than perf. But, this could reduce memory usage in some
pathological cases.
- heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::findEmptyBlockToSteal):
(JSC::MarkedAllocator::tryAllocateWithoutCollecting):
(JSC::MarkedAllocator::endMarking):
(JSC::MarkedAllocator::shrink):
(JSC::MarkedAllocator::shouldStealEmptyBlocksFromOtherAllocators): Deleted.
- heap/MarkedAllocator.h:
- heap/MarkedBlock.cpp:
(JSC::MarkedBlock::Handle::lastChanceToFinalize):
(JSC::MarkedBlock::Handle::sweep):
- heap/MarkedBlockInlines.h:
(JSC::MarkedBlock::Handle::specializedSweep):
(JSC::MarkedBlock::Handle::finishSweepKnowingSubspace):
(JSC::MarkedBlock::Handle::emptyMode):
- 6:03 PM Changeset in webkit [219896] by
-
- 8 edits in trunk
[Apple Pay] Add "carteBancaire" as a supported payment network
https://bugs.webkit.org/show_bug.cgi?id=174841
<rdar://problem/31935596>
Reviewed by Alex Christensen.
Source/WebCore:
Tests: http/tests/ssl/applepay/ApplePaySession.html
http/tests/ssl/applepay/ApplePaySessionV3.html
- Modules/applepay/PaymentRequest.cpp:
(WebCore::PaymentRequest::isValidSupportedNetwork):
Source/WebKit:
- UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
(WebKit::toSupportedNetwork):
LayoutTests:
- http/tests/ssl/applepay/ApplePaySession-expected.txt:
- http/tests/ssl/applepay/ApplePaySession.html:
- http/tests/ssl/applepay/ApplePaySessionV3.html:
- 5:45 PM Changeset in webkit [219895] by
-
- 2 edits in trunk/Source/JavaScriptCore
Remove Broken CompareEq constant folding phase.
https://bugs.webkit.org/show_bug.cgi?id=174846
<rdar://problem/32978808>
Reviewed by Saam Barati.
This bug happened when we would get code like the following:
a: JSConst(Undefined)
b: GetLocal(SomeObjectOrUndefined)
...
c: CompareEq(Check:ObjectOrOther:b, Check:ObjectOrOther:a)
constant folding will turn this into:
a: JSConst(Undefined)
b: GetLocal(SomeObjectOrUndefined)
...
c: CompareEq(Check:ObjectOrOther:b, Other:a)
But the SpeculativeJIT/FTL lowering will fail to check b
properly which leads to an assertion failure in the AI.
I'll follow up with a more robust fix later. For now, I'll remove the
case that generates the code. Removing the code appears to be perf
neutral.
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- 5:45 PM Changeset in webkit [219894] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Fix warnings about console.assert lines without semicolons
https://bugs.webkit.org/show_bug.cgi?id=174840
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-07-25
Reviewed by Brian Burg.
- UserInterface/Views/SettingsTabContentView.js:
(WebInspector.SettingsTabContentView.prototype.set selectedSettingsView):
(WebInspector.SettingsTabContentView.prototype.setSettingsViewVisible):
Add semicolon to assert lines so they can be stripped in optimized builds.
- 4:31 PM Changeset in webkit [219893] by
-
- 5 edits in trunk/Source/WebInspectorUI
Web Inspector: Inline multiple console log values if they are simple
https://bugs.webkit.org/show_bug.cgi?id=174746
<rdar://problem/33469376>
Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-07-25
Reviewed by Matt Baker.
- UserInterface/Models/IssueMessage.js:
- UserInterface/Protocol/RemoteObject.js:
(WebInspector.RemoteObject.type): Deleted.
Remove this as it isn't as useful as directly checking the type.
- UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._appendExtraParameters):
(WebInspector.ConsoleMessageView.prototype._appendFormattedArguments):
(WebInspector.ConsoleMessageView.prototype._hasSimpleDisplay):
(WebInspector.ConsoleMessageView.prototype._isStackTrace):
For leading primitive/simple values, display them inline on the console message.
- UserInterface/Views/FormattedValue.js:
(WebInspector.FormattedValue.hasSimpleDisplay):
Provide a helper to determine if a formatted value will be simple.
- 4:06 PM Changeset in webkit [219892] by
-
- 3 edits in trunk/Source/WebCore
Make StyleResolver::isValid{Cue, Region}StyleProperty() static, inline, non-member functions
https://bugs.webkit.org/show_bug.cgi?id=174827
Reviewed by Simon Fraser.
StyleResolver::isValid{Cue, Region}StyleProperty() access neither instance nor
class data. Moreover, they are private member functions and hence cannot be
used outside of StyleResolver's implementation. So, make these static, inline,
non-member functions.
- css/StyleResolver.cpp:
(WebCore::isValidRegionStyleProperty):
(WebCore::isValidCueStyleProperty):
(WebCore::StyleResolver::CascadedProperties::addMatch):
(WebCore::StyleResolver::isValidRegionStyleProperty): Deleted.
(WebCore::StyleResolver::isValidCueStyleProperty): Deleted.
- css/StyleResolver.h:
- 3:48 PM Changeset in webkit [219891] by
-
- 2 edits in trunk/Source/WebCore
Dragged links are blurry on 1x displays.
https://bugs.webkit.org/show_bug.cgi?id=174831
<rdar://problem/33519698>
Reviewed by Simon Fraser.
When the width and height of the drag image is a multiple of 2, the drag image is not blurry
on a 1x display. This is a workaround which should be removed when <rdar://problem/33059739>
is fixed.
No new tests, since this is not straightforward to test with a layout test.
- platform/mac/DragImageMac.mm:
(WebCore::LinkImageLayout::LinkImageLayout):
- 2:49 PM Changeset in webkit [219890] by
-
- 2 edits in trunk/LayoutTests
Marked multiple fast/ tests as crashing on High Sierra WK1.
<rdar://problem/33522420>
Unreviewed test gardening.
- platform/mac-highsierra-wk1/TestExpectations:
- 2:46 PM Changeset in webkit [219889] by
-
- 9 edits in trunk/Source
Web Inspector: Refactoring: extract async stack trace logic from InspectorInstrumentation
https://bugs.webkit.org/show_bug.cgi?id=174738
Reviewed by Brian Burg.
Source/JavaScriptCore:
Move AsyncCallType enum to InspectorDebuggerAgent, which manages async
stack traces. This preserves the call type in JSC, makes the range of
possible call types explicit, and is safer than passing ints.
- inspector/agents/InspectorDebuggerAgent.cpp:
(Inspector::InspectorDebuggerAgent::asyncCallIdentifier):
(Inspector::InspectorDebuggerAgent::didScheduleAsyncCall):
(Inspector::InspectorDebuggerAgent::didCancelAsyncCall):
(Inspector::InspectorDebuggerAgent::willDispatchAsyncCall):
- inspector/agents/InspectorDebuggerAgent.h:
Source/WebCore:
Relocate AsyncCallType from InspectorInstrumentation to the debugger
agent. Plumbing forrequestAnimationFramenotifications has been added
to PageDebuggerAgent, which is responsible for managing async stack traces.
- dom/ScriptedAnimationController.cpp:
(WebCore::ScriptedAnimationController::registerCallback):
(WebCore::ScriptedAnimationController::cancelCallback):
(WebCore::ScriptedAnimationController::serviceScriptedAnimations):
- inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didInstallTimerImpl):
(WebCore::InspectorInstrumentation::didRemoveTimerImpl):
(WebCore::InspectorInstrumentation::willFireTimerImpl):
(WebCore::InspectorInstrumentation::didRequestAnimationFrameImpl):
(WebCore::InspectorInstrumentation::didCancelAnimationFrameImpl):
(WebCore::InspectorInstrumentation::willFireAnimationFrameImpl):
(): Deleted.
(WebCore::didScheduleAsyncCall): Deleted.
- inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::didRequestAnimationFrame):
(WebCore::InspectorInstrumentation::didCancelAnimationFrame):
(WebCore::InspectorInstrumentation::willFireAnimationFrame):
Replaced Frame and Document pointers with references and moved
pointer validation upstream.
- inspector/PageDebuggerAgent.cpp:
(WebCore::PageDebuggerAgent::didRequestAnimationFrame):
(WebCore::PageDebuggerAgent::willFireAnimationFrame):
(WebCore::PageDebuggerAgent::didCancelAnimationFrame):
- inspector/PageDebuggerAgent.h:
- 2:43 PM Changeset in webkit [219888] by
-
- 7 edits1 copy in trunk/Source/WebInspectorUI
Web Inspector: Styles: Add a switch for Spreadsheet model style editor to experimental settings
https://bugs.webkit.org/show_bug.cgi?id=174741
<rdar://problem/33467954>
Reviewed by Brian Burg.
Show a blank panel when Spreadsheet Style Editor is enabled.
- UserInterface/Base/Setting.js:
- UserInterface/Main.html:
- UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WebInspector.CSSStyleDetailsSidebarPanel):
(WebInspector.CSSStyleDetailsSidebarPanel.prototype.computedStyleDetailsPanelShowProperty):
- UserInterface/Views/RulesStyleSpreadsheetDetailsPanel.js: Added.
(WebInspector.RulesStyleSpreadsheetDetailsPanel):
(WebInspector.RulesStyleSpreadsheetDetailsPanel.prototype.filterDidChange):
(WebInspector.RulesStyleSpreadsheetDetailsPanel.prototype.scrollToSectionAndHighlightProperty):
- UserInterface/Views/SettingsTabContentView.css:
(.content-view.settings > .settings-view > .container.hidden):
(.content-view.settings > .settings-view > .container-centered):
(.content-view.settings > .settings-view > .container button):
- UserInterface/Views/SettingsTabContentView.js:
(WebInspector.SettingsTabContentView.prototype._createDebugSettingsView):
- UserInterface/Views/SettingsView.js:
(WebInspector.SettingsView.prototype.addCenteredContainer):
(WebInspector.SettingsView):
Show "Reload Web Inspector" button when Spreadsheet Style Editor setting is modified.
- 2:22 PM Changeset in webkit [219887] by
-
- 5 edits in trunk/Source/WebKit
Use SandboxExtension::HandleArray when sending extensions for file uploads to the web process
https://bugs.webkit.org/show_bug.cgi?id=174828
Reviewed by Tim Horton.
Send all of the sandbox extension handles in a single message, rather than
one message per extension. Update message name and parameter types to match.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didChooseFilesForOpenPanelWithDisplayStringAndIcon):
(WebKit::WebPageProxy::didChooseFilesForOpenPanel):
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::extendSandboxForFilesFromOpenPanel):
(WebKit::WebPage::extendSandboxForFileFromOpenPanel): Deleted.
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/WebPage.messages.in:
- 2:12 PM Changeset in webkit [219886] by
-
- 2 edits in trunk/LayoutTests
Marked imported/w3c/web-platform-tests/XMLHttpRequest/send-blob-with-no-mime-type.html as failing.
<rdar://problem/33251388>
Unreviewed test gardening.
- platform/mac-highsierra/TestExpectations:
- 1:56 PM Changeset in webkit [219885] by
-
- 5 edits in trunk/Source/JavaScriptCore
Fix bugs in probe code to change sp on x86, x86_64 and 32-bit ARM.
https://bugs.webkit.org/show_bug.cgi?id=174809
<rdar://problem/33504759>
Reviewed by Filip Pizlo.
- When the probe handler function changes the sp register to point to the region of stack in the middle of the ProbeContext on the stack, there is a bug where the ProbeContext's register values to be restored can be over-written before they can be restored. This is now fixed.
- Added more robust probe tests for changing the sp register.
- Made existing probe tests to ensure that probe handlers were actually called.
- Added some verification to testProbePreservesGPRS().
- Change all the probe tests to fail early on discovering an error instead of batching till the end of the test. This helps point a finger to the failing issue earlier.
This patch was tested on x86, x86_64, and ARMv7. ARM64 probe code will be fixed
next in https://bugs.webkit.org/show_bug.cgi?id=174697.
- assembler/MacroAssemblerARM.cpp:
- assembler/MacroAssemblerARMv7.cpp:
- assembler/MacroAssemblerX86Common.cpp:
- assembler/testmasm.cpp:
(JSC::testProbeReadsArgumentRegisters):
(JSC::testProbeWritesArgumentRegisters):
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesStackPointerToInsideProbeContextOnStack):
(JSC::testProbeModifiesStackPointerToNBytesBelowSP):
(JSC::testProbeModifiesProgramCounter):
(JSC::run):
- 1:55 PM Changeset in webkit [219884] by
-
- 2 edits in trunk/LayoutTests
Rebaselinged the test http/tests/quicklook/top-navigation-blocked.html
https://bugs.webkit.org/show_bug.cgi?id=174755
Unreviewed test gardening.
- http/tests/quicklook/top-navigation-blocked-expected.txt:
- 1:54 PM Changeset in webkit [219883] by
-
- 7 edits in branches/safari-604-branch/Source
Versioning.
- 1:50 PM Changeset in webkit [219882] by
-
- 2 edits in trunk/Tools
Fix autoinstaller failing on autoinstall_everything
https://bugs.webkit.org/show_bug.cgi?id=174830
Patch by Matthew Stewart <matthew_r_stewart@apple.com> on 2017-07-25
Reviewed by Joseph Pecoraro.
- Scripts/webkitpy/thirdparty/init.py:
(AutoinstallImportHook.find_module):
(AutoinstallImportHook.install_chromedriver):
(AutoinstallImportHook.install_geckodriver):
(AutoinstallImportHook._install_chromedriver): Deleted.
(AutoinstallImportHook._install_geckodriver): Deleted.
- 1:47 PM Changeset in webkit [219881] by
-
- 2 edits in trunk/Source/WebKit
Fix API tests after r219871.
https://bugs.webkit.org/show_bug.cgi?id=174807
WebKit2.OpenAndCloseWindowAsync and WebKit2.OpenAsyncWithNil API tests are fixed.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createNewPage):
createNewPageAsync or createNewPage should be called, not both.
- 1:45 PM Changeset in webkit [219880] by
-
- 1 copy in tags/Safari-604.1.33
Tag Safari-604.1.33.
- 1:20 PM Changeset in webkit [219879] by
-
- 7 edits in branches/safari-604-branch/Source
Versioning.
- 1:16 PM Changeset in webkit [219878] by
-
- 1 delete in tags/Safari-604.1.33
Delete Tag.
- 11:56 AM Changeset in webkit [219877] by
-
- 2 edits in trunk/LayoutTests
Rebaselined missed test.
https://bugs.webkit.org/show_bug.cgi?id=174734
Unreviewed test gardening.
- fast/events/touch/ios/touches-client-coords-after-zoom-expected.txt:
- 11:53 AM Changeset in webkit [219876] by
-
- 60 edits9 adds in trunk
Async image decoding for large images should be disabled after the first time a tile is painted
https://bugs.webkit.org/show_bug.cgi?id=174451
<rdar://problem/31246421>
Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-07-25
Reviewed by Simon Fraser.
Source/WebCore:
Flashing because of DOM mutation can be fixed by disabling the asynchronous
image decoding after the first time a tile was painted.
We can detect this by consulting the tile repaintCount. If it is zero, then
it is safe to use asynchronous image decoded. If the tile repaintCount is
greater than zero, we are not sure if the renderer rectangle has an image
drawn in it already or not. In this case we have to use the synchronous
image decoding to avoid causing a flash.
Tests: fast/images/async-image-background-change.html
fast/images/async-image-src-change.html
http/tests/multipart/multipart-async-image.html
- html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlTextTrackContainerElement::createTextTrackRepresentationImage):
- page/FrameView.cpp:
(WebCore::FrameView::willPaintContents):
(WebCore::FrameView::paintContentsForSnapshot):
- page/PageOverlayController.cpp:
(WebCore::PageOverlayController::paintContents):
- page/PageOverlayController.h:
- page/linux/ResourceUsageOverlayLinux.cpp:
- page/mac/ServicesOverlayController.h:
- page/mac/ServicesOverlayController.mm:
(WebCore::ServicesOverlayController::Highlight::paintContents):
- platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::draw):
- platform/graphics/BitmapImage.h:
- platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::paintGraphicsLayerContents):
- platform/graphics/GraphicsLayer.h:
- platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::paintContents):
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::LayerClient::platformCALayerPaintContents):
- platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::platformCALayerPaintContents):
- platform/graphics/ca/GraphicsLayerCA.h:
- platform/graphics/ca/PlatformCALayer.h:
- platform/graphics/ca/PlatformCALayerClient.h:
(WebCore::PlatformCALayerClient::platformCALayerRepaintCount):
- platform/graphics/ca/TileCoverageMap.cpp:
(WebCore::TileCoverageMap::platformCALayerPaintContents):
- platform/graphics/ca/TileCoverageMap.h:
- platform/graphics/ca/TileGrid.cpp:
(WebCore::TileGrid::platformCALayerPaintContents):
(WebCore::TileGrid::platformCALayerRepaintCount):
- platform/graphics/ca/TileGrid.h:
- platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
(PlatformCALayer::drawLayerContents):
- platform/graphics/ca/win/PlatformCALayerWin.cpp:
(PlatformCALayer::drawLayerContents):
- platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::displayCallback):
- platform/graphics/ca/win/WebTiledBackingLayerWin.cpp:
(WebTiledBackingLayerWin::displayCallback):
- platform/graphics/mac/WebLayer.mm:
(-[WebLayer drawInContext:]):
(-[WebSimpleLayer drawInContext:]):
- rendering/PaintPhase.h:
- rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::decodingModeForImageDraw):
- rendering/RenderElement.h:
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintForegroundForFragments):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::paintContents):
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::paintContents):
- rendering/RenderLayerCompositor.h:
- rendering/RenderWidget.cpp:
(WebCore::RenderWidget::paintContents):
- testing/Internals.cpp:
(WebCore::imageFromImageElement):
(WebCore::bitmapImageFromImageElement):
(WebCore::Internals::imageFrameIndex):
(WebCore::Internals::setImageFrameDecodingDuration):
(WebCore::Internals::resetImageAnimation):
(WebCore::Internals::isImageAnimating):
(WebCore::Internals::setClearDecoderAfterAsyncFrameRequestForTesting):
(WebCore::Internals::imageDecodeCount):
(WebCore::Internals::setLargeImageAsyncDecodingEnabledForTesting):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
- Shared/mac/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::drawInContext):
- WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
(WebKit::imageForRect):
- WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:
(WebKit::InjectedBundleRangeHandle::renderedImage):
- WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:
(WebKit::CompositingCoordinator::paintContents):
- WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
Source/WebKitLegacy/mac:
- WebView/WebFrame.mm:
(-[WebFrame _paintBehaviorForDestinationContext:]):
(-[WebFrame _drawRect:contentsOnly:]):
- WebView/WebHTMLView.mm:
(imageFromRect):
Source/WebKitLegacy/win:
- FullscreenVideoController.cpp:
(FullscreenVideoController::LayerClient::platformCALayerPaintContents):
- WebCoreSupport/AcceleratedCompositingContext.cpp:
(AcceleratedCompositingContext::paintContents):
- WebCoreSupport/AcceleratedCompositingContext.h:
LayoutTests:
To test async image decoding for large images, we have to create the <img>
element dynamically so we can listen to the load and webkitImageFrameReady
events and know reliably when to end the test. But with this patch the async
image decoding for large images will be disabled after the first paint.
That means async image decoding for large images will be disabled always
unless we force the async image decoding till the image is painted for the
first time. We use Internals::setLargeImageAsyncDecodingEnabledForTesting()
to force the async image decoding. So painting an image in this case will
require multiple paints; in all of them the async image decoding will be
enabled. But this is okay because it resembles the case where the <img> is
created from a static <img> tag in the HTML file.
For new tests, where we want to make sure that mutating the DOM will not
cause a flash, async image decoding will be forced till the image is drawn
for the first time. After that the async image decoding is enabled but not
forced.
Disable new tests for WK1 because the async image decoding is always enabled
because tiling does not necessarily exist in WK1 . But eventually the async
image decoding for large images will be always disabled for WK1.
- fast/images/async-image-background-change-expected.html: Added.
- fast/images/async-image-background-change.html: Added.
- fast/images/async-image-background-image-repeated.html:
- fast/images/async-image-background-image.html:
- fast/images/async-image-body-background-image.html:
- fast/images/async-image-multiple-clients-repaint.html:
- fast/images/async-image-src-change-expected.html: Added.
- fast/images/async-image-src-change.html: Added.
- fast/images/resources/green-400x400.png: Added.
- fast/images/resources/red-100x100.png: Added.
- fast/images/resources/red-400x400.png: Added.
- fast/images/sprite-sheet-image-draw.html:
- http/tests/multipart/multipart-async-image-expected.txt: Added.
- http/tests/multipart/multipart-async-image.html: Added.
- platform/ios-wk1/TestExpectations:
- platform/mac-wk1/TestExpectations:
- 11:28 AM Changeset in webkit [219875] by
-
- 7 edits in trunk/Tools
Replace --runtime with something for both ios-simulator and ios-device
https://bugs.webkit.org/show_bug.cgi?id=173775
<rdar://problem/32952164>
Reviewed by Aakash Jain.
Add --version flag for both iOS simulator and iOS device.
- Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args): Add --version flag and move --no-install.
- Scripts/webkitpy/port/factory.py:
(platform_options): Move --no-intall to run_webkit_tests.py.
- Scripts/webkitpy/port/ios.py:
(IOSPort):
(IOSPort._is_valid_ios_version): Check that the provided version string is legal.
(IOSPort.get_option): If accessing the iOS version, check that it is a valid version string.
- Scripts/webkitpy/port/ios_device.py:
(IOSDevicePort.ios_version): Consult --version flag before checking connected
devices for iOS version.
- Scripts/webkitpy/port/ios_device_unittest.py:
(IOSDeviceTest.make_port): Set --version option so that we can generate test
expectation paths without devices connected.
(IOSDeviceTest.test_additional_platform_directory): Deleted.
(IOSDeviceTest.test_baseline_searchpath): Deleted.
(IOSDeviceTest.test_expectations_ordering): Deleted.
- Scripts/webkitpy/port/ios_simulator.py:
(IOSSimulatorPort.simulator_runtime): If no runtime is specified, use the --version
flag to specify a runtime.
(IOSSimulatorPort.ios_version): First check the --version flag, then the --runtime
flag and then use the default runtime.
- 11:03 AM Changeset in webkit [219874] by
-
- 31 edits in trunk/Source
Web Automation: add support for uploading files
https://bugs.webkit.org/show_bug.cgi?id=174797
<rdar://problem/28485063>
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
- inspector/scripts/generate-inspector-protocol-bindings.py:
(generate_from_specification):
Start generating frontend dispatcher code if the target framework is 'WebKit'.
- inspector/scripts/codegen/generate_cpp_frontend_dispatcher_implementation.py:
(CppFrontendDispatcherImplementationGenerator.generate_output):
Use a framework include for InspectorFrontendRouter.h since this generated code
will be compiled outside of WebCore.framework.
- inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result:
- inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:
- inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result:
- inspector/scripts/tests/generic/expected/definitions-with-mac-platform.json-result:
- inspector/scripts/tests/generic/expected/domain-availability.json-result:
- inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result:
- inspector/scripts/tests/generic/expected/enum-values.json-result:
- inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result:
- inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result:
- inspector/scripts/tests/generic/expected/same-type-id-different-domain.json-result:
- inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-aliased-primitive-type.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-array-type.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-enum-type.json-result:
- inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result:
- inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result:
- inspector/scripts/tests/generic/expected/type-with-open-parameters.json-result:
- inspector/scripts/tests/generic/expected/worker-supported-domains.json-result:
- inspector/scripts/tests/ios/expected/definitions-with-mac-platform.json-result:
- inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result:
Rebaseline code generator tests.
Source/WebKit:
The general strategy is to have automation clients set the list of files they want
to select ahead of time. Then, the client simulates a click on the <input type="file"> element.
When that causes WebPageProxy to ask the UI delegate to runOpenPanel, it instead
gives WebAutomationSession a chance to select files if the page is under control of
automation. WebAutomationSession validates its file list and selects the files if valid.
- CMakeLists.txt: Add frontend dispatcher files.
- DerivedSources.make:
Add frontend dispatcher code generator scripts as dependencies of the generated code.
Add generated frontend dispatcher files to the list of output files.
- UIProcess/Automation/Automation.json:
Add a command to set the canned list of files that should be selected when prompted.
If no files are selected, then the effect is as if the user had clicked "cancel" in
the file chooser dialog.
Add an event to signal to the WebDriver service that the file selection request has
been either fulfilled or cancelled. This event is necessary because otherwise remotes
cannot distinguish whether selecting the files failed for some reason, or if the
UIProcess has not yet selected the files and sent them to the web content process.
In either case, the input element's "files" attribute would return an empty FileList.
- UIProcess/Automation/WebAutomationSession.h:
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::WebAutomationSession::WebAutomationSession):
Add the frontend dispatcher for Automation domain. This is named m_domainNotifier since
m_domainDispatcher is already being used for the backend command dispatcher.
(WebKit::WebAutomationSession::handleRunOpenPanel):
Validate that the files-to-select list has valid entries and select the files if so.
If anything goes wrong, pretend to cancel out of the file chooser. Either way, notify the
frontend with an event that the file chooser was dismissed due to selecting files or cancelling.
Automation protocol clients may implement additional strategies to further restrict
the conditions upon which local files can be uploaded.
(WebKit::WebAutomationSession::setFilesToSelectForFileUpload): Added.
Store the list of files as a vector of strings. The file list is always replaced.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runOpenPanel):
If the page is under automation, delegating the runOpenPanel is likely to hang
because WebDriver cannot interact directly with the file chooser dialog. Instead,
give WebAutomationSession a chance to select files and don't tell the delegate.
- WebKit.xcodeproj/project.pbxproj:
Add frontend dispatcher files to "Derived Sources" group.
- 11:02 AM Changeset in webkit [219873] by
-
- 20 edits1 add in trunk/Source/WebCore
[WebIDL] Add support for generating timer bindings
https://bugs.webkit.org/show_bug.cgi?id=174766
Reviewed by Darin Adler.
Adds a new non-standard type, ScheduledAction, which stands in for the
standard (DOMString or Function). It would be good to move to that in
future, but for now, this allows for forward momentum on removing custom
bindings.
- WebCore.xcodeproj/project.pbxproj:
Add JSDOMConvertScheduledAction.h.
- bindings/IDLTypes.h:
Add IDLScheduledAction.
- bindings/js/JSDOMConvertScheduledAction.h: Added.
(WebCore::Converter<IDLScheduledAction>::convert):
Add conversion from JSValue -> ScheduledAction. This is moved from the old ScheduledAction
create function.
- bindings/js/JSDOMConvertVariadic.h:
(WebCore::convertVariadicArguments):
(WebCore::Detail::VariadicConverterBase::convert): Deleted.
(WebCore::Detail::VariadicConverterBase<IDLInterface<T>>::convert): Deleted.
- bindings/js/JSDOMConvertBase.h:
- bindings/js/JSDOMConvertAny.h:
(WebCore::VariadicConverter<IDLAny>::convert):
- bindings/js/JSDOMConvertInterface.h:
(WebCore::VariadicConverter<IDLInterface<T>>::convert):
Rename VariadicConverter to VariadicConverterDetails, and remove base class. Rename
VariadicConverterBase to VariadicConverter, and move specializations to the file
containing the base converter for that IDL type
- bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::setTimeout): Deleted.
(WebCore::JSDOMWindow::setInterval): Deleted.
- bindings/js/JSWorkerGlobalScopeCustom.cpp:
(WebCore::JSWorkerGlobalScope::setTimeout): Deleted.
(WebCore::JSWorkerGlobalScope::setInterval): Deleted.
Remove custom implementations of setTimeout and setInterval.
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::create):
(WebCore::ScheduledAction::ScheduledAction):
(WebCore::ScheduledAction::~ScheduledAction):
(WebCore::ScheduledAction::addArguments):
(WebCore::ScheduledAction::executeFunctionInContext):
- bindings/js/ScheduledAction.h:
(WebCore::ScheduledAction::ScheduledAction): Deleted.
Rework ScheduledAction. Now has two create functions, one for the function
form, one for the string form. These are now called by the Converter. Also,
rather than extracting the arguments directly from the ExecState, allow the
bindings to work as designed, and have the arguments come in as variadic
arguments to setTimeout/setInterval and get added to the ScheduledAction if
needed. Also, move ContentSecurityPolicy check out of construction, and into
setTimeout/setInterval.
- bindings/scripts/CodeGenerator.pm:
(IsBuiltinType):
Add ScheduledAction to the builtin list.
- bindings/scripts/CodeGeneratorJS.pm:
(AddToIncludesForIDLType):
Add the correct include when ScheduledAction is used.
(GenerateParametersCheck):
Remove rule disallowing optional arguments before variadic arguments. That works
just fine.
(GetBaseIDLType):
Add mapping of ScheduledAction -> IDLScheduledAction.
(JSValueToNativeDOMConvertNeedsGlobalObject):
Add ScheduledAction to the list of types that need a global object
for conversion.
- page/WindowOrWorkerGlobalScope.idl:
Update interface to match spec and add FIXMEs for moving to TimerHandler.
- page/DOMWindow.cpp:
(WebCore::DOMWindow::setTimeout):
(WebCore::DOMWindow::setInterval):
- page/DOMWindow.h:
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::setTimeout):
(WebCore::WorkerGlobalScope::setInterval):
- workers/WorkerGlobalScope.h:
Update for new signatures. WorkerGlobalScope now has to return ExceptionOr<int>
even though it never throws, due to having one IDL file defining these. This is
unfortunate and something we should look at addressing the future.
- 10:42 AM Changeset in webkit [219872] by
-
- 2 edits in trunk/LayoutTests
[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=174820
Unreviewed gardening.
Patch by Charlie Turner <cturner@igalia.com> on 2017-07-25
- platform/gtk/TestExpectations:
- 10:17 AM Changeset in webkit [219871] by
-
- 22 edits in trunk/Source/WebKit
Modernize NavigationAction code
https://bugs.webkit.org/show_bug.cgi?id=174807
Reviewed by Darin Adler.
Mostly just use more move semantics.
- Platform/IPC/HandleMessage.h:
(IPC::callMemberFunctionImpl):
- Shared/API/APIURLRequest.h:
- Shared/NavigationActionData.h:
- UIProcess/API/APINavigation.cpp:
(API::Navigation::Navigation):
- UIProcess/API/APINavigation.h:
(API::Navigation::create):
- UIProcess/API/APINavigationAction.h:
- UIProcess/API/APINavigationClient.h:
(API::NavigationClient::decidePolicyForNavigationAction):
- UIProcess/API/APIPolicyClient.h:
- UIProcess/API/APIUIClient.h:
(API::UIClient::createNewPage):
(API::UIClient::createNewPageAsync):
(API::UIClient::canCreateNewPageAsync):
- UIProcess/API/C/WKPage.cpp:
(WKPageLoadURLRequest):
(WKPageLoadURLRequestWithUserData):
(WKPageSetPageUIClient):
(WKPageSetPageNavigationClient):
- UIProcess/Cocoa/NavigationState.h:
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
- UIProcess/Cocoa/UIDelegate.h:
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::UIClient::createNewPageCommon):
(WebKit::UIDelegate::UIClient::createNewPage):
(WebKit::UIDelegate::UIClient::canCreateNewPageAsync):
(WebKit::UIDelegate::UIClient::createNewPageAsync):
- UIProcess/WebInspectorProxy.cpp:
(WebKit::decidePolicyForNavigationAction):
- UIProcess/WebNavigationState.cpp:
(WebKit::WebNavigationState::createLoadRequestNavigation):
- UIProcess/WebNavigationState.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadRequest):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::createNewPage):
- UIProcess/WebPageProxy.h:
- 10:07 AM Changeset in webkit [219870] by
-
- 11 edits in trunk
Web Inspector: add context menu item for taking a screenshot of a node
https://bugs.webkit.org/show_bug.cgi?id=174754
Reviewed by Brian Burg.
Source/WebInspectorUI:
- Localizations/en.lproj/localizedStrings.js:
- UserInterface/Views/ContextMenuUtilities.js:
(WebInspector.appendContextMenuItemsForDOMNode):
Add "Capture Element Screenshot " context menu item that opens a save dialog with a picture of the node.
- UserInterface/Base/Main.js:
(WebInspector.saveDataToFile):
Allow the saveData to specify whether the contained content is base64Encoded, instead of
having to go through a Blob to save base64 data.
- UserInterface/Base/Utilities.js:
Add Number.pad to add leading zeros up to a certain width.
Drive-by: fix failing test for Number.constrain.
- UserInterface/Models/DOMNode.js:
(WebInspector.DOMNode.prototype.scrollIntoView.resolvedNode.scrollIntoView): Added.
(WebInspector.DOMNode.prototype.scrollIntoView.resolvedNode): Added.
(WebInspector.DOMNode.prototype.scrollIntoView): Added.
- UserInterface/Views/DOMTreeElement.js:
(WebInspector.DOMTreeElement.prototype._populateNodeContextMenu):
(WebInspector.DOMTreeElement.prototype._scrollIntoView.resolvedNode.scrollIntoView): Deleted.
(WebInspector.DOMTreeElement.prototype._scrollIntoView.resolvedNode): Deleted.
(WebInspector.DOMTreeElement.prototype._scrollIntoView): Deleted.
- UserInterface/Views/DOMTreeOutline.js:
(WebInspector.DOMTreeOutline.prototype.populateContextMenu):
Drive-by: move "Scroll Into View" context menu command to WebInspector.appendContextMenuItemsForDOMNode
so that it can be triggered from more places than just the DOM tree.
LayoutTests:
- inspector/unit-tests/number-utilities-expected.txt:
- inspector/unit-tests/number-utilities.html:
Add test for Number.zeroPad.
Drive-by: Change tests to use expectEqual for better output on failure.
- 9:49 AM Changeset in webkit [219869] by
-
- 16 edits in trunk/Source/WebCore
[WinCairo] Fix build with AllInOnes disabled
https://bugs.webkit.org/show_bug.cgi?id=174784
<rdar://problem/33488914>
Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2017-07-25
Reviewed by Alex Christensen.
- PlatformWin.cmake:
Add RenderThemeWin.cpp to WebCore_SOURCES
- rendering/RenderingAllInOne.cpp:
Remove #include "RenderThemeWin.cpp"
- testing/MemoryInfo.h:
Remove #include "JSDomWindow.h"
- bindings/js/JSDOMGlobalObject.cpp:
- bindings/js/JSDOMPromiseDeferred.cpp:
- bindings/js/JSDOMWrapper.cpp:
- bindings/js/JSImageDataCustom.cpp:
- bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallWith):
- dom/ScriptExecutionContext.cpp:
- inspector/InspectorController.cpp:
- inspector/InspectorTimelineAgent.cpp:
- rendering/RenderMediaControls.cpp:
- rendering/RenderMediaControls.h:
- rendering/RenderThemeWin.cpp:
- bindings/scripts/test/JS/JSTestObj.cpp:
Update test results.
- 6:22 AM Changeset in webkit [219868] by
-
- 2 edits1 add in trunk/LayoutTests
REGRESSION (r143068): fast/events/clientXY-in-zoom-and-scroll.html failing on GTK, Qt
https://bugs.webkit.org/show_bug.cgi?id=110090
Unreviewed gardening.
This test only needed the expectation to be updated.
- platform/gtk/TestExpectations: Remove test below.
- platform/gtk/fast/events/clientXY-in-zoom-and-scroll-expected.txt: Added.
- 4:43 AM Changeset in webkit [219867] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed, fix Mac CMake build after r219567
- PlatformMac.cmake:
- 4:38 AM Changeset in webkit [219866] by
-
- 2 edits in trunk/Source/WebKit
REGRESSION(r218629): [GTK] ASSERTION FAILED: m_eglDisplay == EGL_NO_DISPLAY in WebCore::PlatformDisplay::~PlatformDisplay
https://bugs.webkit.org/show_bug.cgi?id=174789
Reviewed by Žan Doberšek.
Before r218629, the wayland nested compositor display was a singleton created on demand by
AcceleratedSurfaceWayland, but now it's created unconditionally on web process creation when a valid display
name is received from the UI process. The side effect of this is that now the shared display is created after
the nested compositor display that is not a singleton anymore. The atexit used by PlatformDisplay to shutdown
egl display assumes that it will be registered by the shared display. Since we switched to on demand AC mode,
the shared display is only used in the web process when entering AC mode, that's why it only crashes when we
have entered AC at least once. We just need to ensure that the shared display is created before the nested
compositor display.
- WebProcess/gtk/WaylandCompositorDisplay.cpp:
(WebKit::WaylandCompositorDisplay::create): Check we are under wayland before creating the WaylandCompositorDisplay.
- 4:36 AM Changeset in webkit [219865] by
-
- 4 edits in trunk/Tools
[GTK] TestWebKitAPI tests are no longer built since the WebKit2 rename
https://bugs.webkit.org/show_bug.cgi?id=174815
Reviewed by Carlos Alberto Lopez Perez.
Only WebKitGTK specific tests are built, but not WebKit2, WTF nor WebCore ones. We are still checking
ENABLE_WEBKIT2 in the makefile, that was renamed to ENABLE_WEBKIT. Also, all WebKit2 test paths were updated to
use WebKit dir, while the tests are still in WebKit2 directory. This patch also removes
TestWebKitAPIInjectedBundle_PATH that is unused and now makes the configure to fail (it used to be a warning, I
think), probably because of a newer CMake version.
- CMakeLists.txt:
- TestWebKitAPI/CMakeLists.txt:
- TestWebKitAPI/PlatformGTK.cmake:
- 4:29 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 4:28 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 4:25 AM WebKitGTK/KeepingTheTreeGreen edited by
- (diff)
- 3:22 AM Changeset in webkit [219864] by
-
- 2 edits in trunk
Unreviewed. Fix GTK+ WebKit2 library soname after r219488.
The WebKit2 -> WebKit rename shouldn't affect the GTK+ library that is still called libwebkit2gtk, so keep using
WEBKIT2 as the library name in CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE, since that's also what the WebKit
makefile passes to WEBKIT_POPULATE_LIBRARY_VERSION.
- Source/cmake/OptionsGTK.cmake:
Jul 24, 2017:
- 11:49 PM Changeset in webkit [219863] by
-
- 3 edits in trunk/Source/WebKit
[GTK] ASSERTION FAILED: client in WebKit::IconDatabase::setClient
https://bugs.webkit.org/show_bug.cgi?id=174788
Patch by Michael Catanzaro <Michael Catanzaro> on 2017-07-24
Reviewed by Carlos Garcia Campos.
IconDatabase ensures that setClient is never called with nullptr, but WebKitFaviconDatabase
does exactly that. First, ensure it's safe to unset the client. Next, we can either remove
the assertions from setClient or else automatically unset the client in IconDatabase::close.
I opted to do both.
- UIProcess/API/glib/IconDatabase.cpp:
(WebKit::IconDatabase::close):
(WebKit::IconDatabase::setIconDataForIconURL):
(WebKit::IconDatabase::setIconURLForPageURL):
- UIProcess/API/glib/WebKitFaviconDatabase.cpp:
(_WebKitFaviconDatabasePrivate::~_WebKitFaviconDatabasePrivate): Deleted.
(webkitFaviconDatabaseDispose): Deleted.
- 11:45 PM Changeset in webkit [219862] by
-
- 2 edits in trunk/Source/WebKit
[GTK][WPE] Remove useless conditional in IconDatabase::setIconDataForIconURL
https://bugs.webkit.org/show_bug.cgi?id=174792
Patch by Michael Catanzaro <Michael Catanzaro> on 2017-07-24
Reviewed by Carlos Garcia Campos.
We have in IconDatabase::setIconDataForIconURL some code in a conditional to check if it's
not being executed on the icon sync thread. But at the top of the function is an assertion
to ensure the code is never executed on the icon sync thread. The condition is therefore
useless and the code should be executed unconditionally.
- UIProcess/API/glib/IconDatabase.cpp:
(WebKit::IconDatabase::setIconDataForIconURL):
- 11:39 PM Changeset in webkit [219861] by
-
- 2 edits in trunk/Source/WebKit
[GTK] Icon database error and crash
https://bugs.webkit.org/show_bug.cgi?id=174760
Reviewed by Michael Catanzaro.
The crash is a debug ASSERT that happens when the IconRecord image is created in one thread and destroyed in
another one. IconDatabase creates and destroys IconRecord objects in both database and main thread. The
IconRecord is destroyed when the icon is no longer retained, and we only release icons when we fail to get the
image data (including pages that don't have a favicon). We can prevent this crash from happening if we ensure we
never create an Image for an IconRecord when the given image data is nullptr.
- UIProcess/API/glib/IconDatabase.cpp:
(WebKit::IconDatabase::IconRecord::setImageData):
- 9:36 PM Changeset in webkit [219860] by
-
- 7 edits in trunk/Tools
Fix BenchmarkRunner to only import selenium when needed
https://bugs.webkit.org/show_bug.cgi?id=174808
Patch by Matthew Stewart <matthew_r_stewart@apple.com> on 2017-07-24
Reviewed by Stephanie Lewis.
- Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
(LinuxChromeDriver.launch_driver):
- Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
(LinuxFirefoxDriver.launch_driver):
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
(OSXChromeDriver.launch_driver):
(OSXChromeCanaryDriver.launch_driver):
(create_chrome_options):
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
(OSXFirefoxDriver.launch_driver):
(OSXFirefoxNightlyDriver.launch_driver):
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
(OSXSafariDriver.launch_driver):
- Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py:
(WebDriverBenchmarkRunner._run_one_test):
- 9:35 PM Changeset in webkit [219859] by
-
- 2 edits in branches/safari-604-branch/Source/WebKit
Cherry-pick r219852. rdar://problem/33503476
- 9:29 PM Changeset in webkit [219858] by
-
- 51 edits in trunk
More NeverDestroyed and related cleanup
https://bugs.webkit.org/show_bug.cgi?id=174745
Reviewed by Alex Christensen.
Source/WebCore:
- bindings/js/JSCustomElementInterface.cpp:
(WebCore::JSCustomElementInterface::constructElementWithFallback):
Use isNull() rather than comparing against nullAtom() since it's
slightly more efficient.
- css/MediaQueryEvaluator.cpp:
(WebCore::prefersReducedMotionEvaluate): Use a switch statement for the
three states of forcedPrefersReducedMotionAccessibilityValue. Also update
to use Theme::singleton() instead of platformTheme().
- dom/QualifiedName.h: Removed some unneeded includes, minor style tweaks,
and use isNull() rather than comparing against nullAtom() since it's
slightly more efficient.
- html/Autofill.cpp:
(WebCore::AutofillData::createFromHTMLFormControlElement): Use isNull()
rather than comparing against nullAtom() since it's slightly more efficient.
- html/HTMLDocument.cpp:
(WebCore::addLocalNameToSet): Deleted.
(WebCore::createHtmlCaseInsensitiveAttributesSet): Deleted.
(WebCore::HTMLDocument::isCaseSensitiveAttribute): Moved the case-sensitive
attribute set in here and made it use makeNeverDestroyed.
- html/HTMLNameCollection.cpp:
(WebCore::WindowNameCollection::elementMatchesIfNameAttributeMatch):
Formatted vertically and sorted so it's easier to see what it does.
(WebCore::WindowNameCollection::elementMatches): Use boolean logic instead
of multiple return statements to make this a little more straightforward.
(WebCore::isObjectElementForDocumentNameCollection): Added. Calls the new
isExposed function. The old code called this isDocNamedItem.
(WebCore::DocumentNameCollection::elementMatchesIfIdAttributeMatch):
Use isObjectElementForDocumentNameCollection to clean up logic. Also
sorted classes.
(WebCore::DocumentNameCollection::elementMatchesIfNameAttributeMatch):
Use isObjectElementForDocumentNameCollection to clean up logic. Also
sorted classes and formatted vertically.
(WebCore::DocumentNameCollection::elementMatches): Write in terms of
above functions for clarity. Efficiency is roughly the same.
- html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::HTMLObjectElement): Initialize data members
in class definition instead of here.
(WebCore::HTMLObjectElement::childrenChanged): Update for name change;
function is now called updateExposedState rather than updateDocNamedItem.
Also use m_useFallbackContent directly instead of through a function.
(WebCore::HTMLObjectElement::renderFallbackContent): Ditto.
(WebCore::preventsParentObjectFromExposure): Added. Replaces the old
isRecognizedTagName function, and does almost the same thing, but the
argument type is different and the param tag is now one of the tags
exempted here. Also broke up into two overloads so we can handle the
Element, Text, and other Node cases.
(WebCore::shouldBeExposed): Added. Helper for the updateExposedState
function that handles the logic of when the element should be exposed,
separating it from what to do when the state changes.
(WebCore::HTMLObjectElement::updateExposedState): Renamed from
updateDocNamedItem.
- html/HTMLObjectElement.h: Renamed isDocNamedItem -> isExposed,
m_docNamedItem -> m_isExposed, updateDocNamedItem -> updateExposedState,
stopped using bit fields for the two boolean data members, and
initialized those data members here in the class definition.
- platform/Theme.cpp:
(WebCore::Theme::baselinePositionAdjustment): Moved here from header.
(WebCore::Theme::controlFont): Ditto.
(WebCore::Theme::controlSize): Ditto.
(WebCore::Theme::minimumControlSize): Ditto.
(WebCore::Theme::controlRequiresPreWhiteSpace): Ditto.
(WebCore::Theme::paint): Ditto.
(WebCore::Theme::inflateControlPaintRect): Ditto.
(WebCore::Theme::userPrefersReducedMotion): Ditto.
(WebCore::Theme::controlBorder): Fixed switch statement indentation.
(WebCore::Theme::controlPadding): Ditto.
- platform/Theme.h: Removed the many unnecessary includes. The one
I was really after here was FontCascade.h. Replaced the platformTheme
function with a singleton function, following our normal style. Also
changed the return type to a reference rather than a pointer.
Removed many unused function and data members.
- platform/cocoa/ThemeCocoa.h: Tightened up implementation, removing
unnecessary members and making overrides private.
- platform/cocoa/ThemeCocoa.mm: Moved include in here.
- platform/gamepad/glib/GamepadsGlib.cpp:
(WebCore::sampleGamepads): Use NeverDestroyed instead of
DEPRECATED_DEFINE_STATIC_LOCAL.
- platform/graphics/FontCascade.cpp:
(WebCore::useBackslashAsYenSignForFamily): Build the set in a cleaner
way and use a NeverDestroyed set instead of a heap-allocated one.
(WebCore::FontCascade::FontCascade): Moved initialization of data members
to the class definition.
- platform/graphics/FontCascade.h: Initialize GlyphOverflow and
FonstCascade data members in the class definition. Remove the constructor
for GlyphOverflow entirely. Added FIXME about the peculiar != operator we
defined for GlyphOverflow.
- platform/graphics/NamedImageGeneratedImage.cpp:
(WebCore::NamedImageGeneratedImage::draw): Use Theme::singleton() instead
of platformTheme().
(WebCore::NamedImageGeneratedImage::drawPattern): Ditto.
- platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:
(WebCore::CMTimeRangeStartKey): Use CFSTR directly instead of using
DEPRECATED_DEFINE_STATIC_LOCAL.
(WebCore::CMTimeRangeDurationKey): Ditto.
(WebCore::CACFContextNeedsFlushNotification): Ditto.
- platform/graphics/ca/win/LayerChangesFlusher.cpp:
(WebCore::LayerChangesFlusher::singleton): Use NeverDestroyed instead of
DEPRECATED_DEFINE_STATIC_LOCAL.
- platform/graphics/ca/win/LayerChangesFlusher.h: Ditto.
- platform/graphics/cg/ImageSourceCGWin.cpp:
(WebCore::preferredExtensionForImageSourceType): Use HashMap constructor
instead of writing out a lot of add calls.
- platform/graphics/harfbuzz/HarfBuzzFace.cpp:
(WebCore::harfBuzzFaceCache): Use NeverDestroyed instead of
DEPRECATED_DEFINE_STATIC_LOCAL.
- platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::lastResortFallbackFont): Ditto.
- platform/ios/ThemeIOS.h: Tightened up implementation, removing
unnecessary members and making overrides private.
- platform/ios/ThemeIOS.mm:
(WebCore::Theme::singleton): Renamed from platformTheme.
- platform/mac/ThemeMac.h: Tightened up implementation, removing
unnecessary members and making overrides private. Removed unneeded
WTF_MAKE_FAST_ALLOCATED since this is never allocated on the heap.
Removed unused -[NSFont webCoreFamilyName] method.
- platform/mac/ThemeMac.mm:
(-[NSFont webCoreFamilyName]): Deleted.
(WebCore::Theme::singleton): Renamed from platformTheme.
- platform/mediastream/mac/MockRealtimeAudioSourceMac.h:
Removed unneeded include of FontCascade.h.
- platform/mediastream/mac/MockRealtimeVideoSourceMac.h:
Ditto.
- platform/mock/MockRealtimeAudioSource.h: Ditto.
- platform/network/win/DownloadBundleWin.cpp:
(WebCore::DownloadBundle::fileExtension): Use NeverDestroyed
instead of DEPRECATED_DEFINE_STATIC_LOCAL.
- platform/win/ClipboardUtilitiesWin.cpp:
(WebCore::replaceNewlinesWithWindowsStyleNewlines): Use
appendLiteral instead of DEPRECATED_DEFINE_STATIC_LOCAL.
- platform/win/FileSystemWin.cpp:
(WebCore::bundleName): Use NeverDestroyed instead of
DEPRECATED_DEFINE_STATIC_LOCAL, and used a lambda to initialize
rather than a boolean to control one-time code.
(WebCore::storageDirectory): Removed unneeded use of
DEPRECATED_DEFINE_STATIC_LOCAL for a prefix we are appending to
a String. The + operator can handle a literal just as efficiently
without first storing it in a String.
- platform/wpe/ThemeWPE.cpp:
(WebCore::Theme::singleton): Renamed from platformTheme.
- platform/wpe/ThemeWPE.h: Tightened up implementation, removing
unnecessary members and making overrides private.
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::RenderTheme): No need to initialize m_theme.
(WebCore::RenderTheme::adjustStyle): Use Theme::singleton() instead
of accessing it through m_theme.
(WebCore::RenderTheme::paint): Ditto.
(WebCore::RenderTheme::baselinePosition): Ditto.
(WebCore::RenderTheme::adjustRepaintRect): Ditto.
(WebCore::RenderTheme::setCustomFocusRingColor): Ditto.
(WebCore::RenderTheme::platformTapHighlightColor): Ditto.
- rendering/RenderTheme.h: Removed unneded m_theme and unneeded
inclusion of Theme.h.
- rendering/line/LineBreaker.h: Removed unneeded include of
FontCascade.h.
Source/WebKitLegacy/mac:
- DOM/DOMUIKitExtensions.mm: Removed a lot of unneeded "using"
for names that aren't even used in this file.
(-[DOMNode boundingBoxes]): Use @[] syntax instead of
-[NSArray arrayWithObject:].
(-[DOMNode absoluteQuads]): Ditto.
(-[DOMNode findExplodedTextNodeAtPoint:]): Use auto* instead
of writing out various types.
(-[DOMHTMLAreaElement boundingBoxesWithOwner:]): Use @[]
syntax instea of -[NSArray arrayWithObject:].
(-[DOMHTMLAreaElement absoluteQuadsWithOwner:]): Ditto.
(-[DOMHTMLImageElement dataRepresentation:]): Use auto* instead
of writing out various types.
(-[DOMHTMLImageElement mimeType]): Ditto.
Source/WebKitLegacy/win:
- Plugins/PluginDatabase.cpp:
(WebCore::persistentPluginMetadataCachePath): Use NeverDestroyed
instead of DEPRECATED_DEFINE_STATIC_LOCAL.
- Plugins/PluginMainThreadScheduler.cpp:
(WebCore::PluginMainThreadScheduler::scheduler): Ditto.
- Plugins/PluginMainThreadScheduler.h: Ditto.
- WebCoreSupport/WebPlatformStrategies.cpp:
(WebPlatformStrategies::initialize): Ditto.
- WebCoreSupport/WebPlatformStrategies.h: Ditto.
- WebHistory.cpp:
(sharedHistoryStorage): Ditto.
- WebLocalizableStrings.cpp:
(mainBundleLocStrings): Ditto.
(frameworkLocStringsMutex): Ditto.
(frameworkLocStrings): Ditto.
- WebView.cpp:
(WebView::standardUserAgentWithApplicationName): Ditto.
Also changed to keep one global string with the prefix of the user agent string
instead of keeping two globals with pieces of that prefix.
Tools:
- DumpRenderTree/JavaScriptThreading.cpp:
(javaScriptThreadsMutex): Use NeverDestroyed instead of
DEPRECATED_DEFINE_STATIC_LOCAL.
(javaScriptThreads): Ditto.
- 9:10 PM Changeset in webkit [219857] by
-
- 4 edits2 adds in trunk/Tools
Subclass Benchmark Runner script for WebDriver support
https://bugs.webkit.org/show_bug.cgi?id=174390
Patch by Matthew Stewart <matthew_r_stewart@apple.com> on 2017-07-24
Reviewed by Dewei Zhu, Stephanie Lewis.
Add WebServerBenchmarkRunner and WebDriverBenchmarkRunner subclasses.
- Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
(BenchmarkBuilder.init):
- Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner.init):
(BenchmarkRunner._find_plan_file):
(BenchmarkRunner._run_one_test.and):
(BenchmarkRunner.execute):
(BenchmarkRunner._get_result): Deleted.
- Scripts/webkitpy/benchmark_runner/run_benchmark.py:
(parse_args):
(start):
- Scripts/webkitpy/benchmark_runner/webdriver_benchmark_runner.py: Added.
(WebDriverBenchmarkRunner):
(WebDriverBenchmarkRunner._get_result):
(WebDriverBenchmarkRunner._run_one_test):
- Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py: Added.
(WebServerBenchmarkRunner):
(WebServerBenchmarkRunner.init):
(WebServerBenchmarkRunner._get_result):
(WebServerBenchmarkRunner._run_one_test):
- 8:59 PM Changeset in webkit [219856] by
-
- 184 edits in trunk/Source
ExceptionCode enumeration should use modern exception names
https://bugs.webkit.org/show_bug.cgi?id=174794
Reviewed by Geoffrey Garen.
Source/WebCore:
ExceptionCode enumeration should use modern exception names consistently.
This makes the code nicer and closer to the text of the specification.
Source/WebKitLegacy/mac:
- DOM/ExceptionHandlers.mm:
(raiseNotSupportedErrorException):
- 8:07 PM Changeset in webkit [219855] by
-
- 3 edits in trunk/Source/WebKit
[WK2][Cocoa] Allow overriding the ITP data removal internal using a default
https://bugs.webkit.org/show_bug.cgi?id=174802
<rdar://problem/33497898>
Reviewed by Sam Weinig.
Allow overriding the ITP data removal internal using a default to facilitate testing.
Can be used like so:
defaults write -g ResourceLoadStatisticsMinimumTimeBetweenDataRecordsRemoval 60
Will cause us to write every 60 seconds instead of 3600.
- Shared/WebPreferencesDefinitions.h:
- UIProcess/Cocoa/WebResourceLoadStatisticsStoreCocoa.mm:
(WebKit::WebResourceLoadStatisticsStore::registerUserDefaultsIfNeeded):
- 6:58 PM Changeset in webkit [219854] by
-
- 14 edits10 copies11 moves2 adds in trunk/Tools
Add BenchmarkRunner patches with WebDriver support for each testing plan
https://bugs.webkit.org/show_bug.cgi?id=174443
Patch by Matthew Stewart <matthew_r_stewart@apple.com> on 2017-07-24
Reviewed by Dewei Zhu, Stephanie Lewis.
- Scripts/webkitpy/benchmark_runner/benchmark_builder.py:
(BenchmarkBuilder.enter):
- Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ARES-6.patch:
- Scripts/webkitpy/benchmark_runner/data/patches/webdriver/ContentAnimation.patch:
- Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Dromaeo.patch:
- Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JSBench.patch:
- Scripts/webkitpy/benchmark_runner/data/patches/webdriver/JetStream.patch:
- Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Kraken.patch:
- Scripts/webkitpy/benchmark_runner/data/patches/webdriver/MotionMark.patch:
- Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Octane.patch:
- Scripts/webkitpy/benchmark_runner/data/patches/webdriver/Speedometer.patch:
- Scripts/webkitpy/benchmark_runner/data/patches/webdriver/SunSpider.patch:
- Scripts/webkitpy/benchmark_runner/data/patches/webserver/ARES-6.patch:
- Scripts/webkitpy/benchmark_runner/data/patches/webserver/Animometer.patch:
- Scripts/webkitpy/benchmark_runner/data/patches/webserver/ContentAnimation.patch:
- Scripts/webkitpy/benchmark_runner/data/patches/webserver/Dromaeo.patch:
- Scripts/webkitpy/benchmark_runner/data/patches/webserver/JSBench.patch:
- Scripts/webkitpy/benchmark_runner/data/patches/webserver/JetStream.patch:
- Scripts/webkitpy/benchmark_runner/data/patches/webserver/Kraken.patch:
- Scripts/webkitpy/benchmark_runner/data/patches/webserver/MotionMark.patch:
- Scripts/webkitpy/benchmark_runner/data/patches/webserver/Octane.patch:
- Scripts/webkitpy/benchmark_runner/data/patches/webserver/Speedometer.patch:
- Scripts/webkitpy/benchmark_runner/data/patches/webserver/SunSpider.patch:
- Scripts/webkitpy/benchmark_runner/data/plans/ares6.plan:
- Scripts/webkitpy/benchmark_runner/data/plans/content-animation.plan:
- Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-cssquery.plan:
- Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-dom.plan:
- Scripts/webkitpy/benchmark_runner/data/plans/dromaeo-jslib.plan:
- Scripts/webkitpy/benchmark_runner/data/plans/jetstream.plan:
- Scripts/webkitpy/benchmark_runner/data/plans/jsbench.plan:
- Scripts/webkitpy/benchmark_runner/data/plans/kraken.plan:
- Scripts/webkitpy/benchmark_runner/data/plans/motionmark.plan:
- Scripts/webkitpy/benchmark_runner/data/plans/octane.plan:
- Scripts/webkitpy/benchmark_runner/data/plans/speedometer.plan:
- Scripts/webkitpy/benchmark_runner/data/plans/sunspider.plan:
- 6:42 PM Changeset in webkit [219853] by
-
- 10 edits in trunk/Tools
Add functions to autoinstaller needed for Benchmark Runner script
https://bugs.webkit.org/show_bug.cgi?id=174331
Patch by Matthew Stewart <matthew_r_stewart@apple.com> on 2017-07-24
Reviewed by Dean Johnson, Dewei Zhu, Stephanie Lewis.
Adds autoinstaller functions to install selenium and webdriver binaries
which will be used by the browser driver part of Benchmark Runner.
- Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
(BrowserDriver.restore_env):
(BrowserDriver):
(BrowserDriver.get_webdriver_binary_path):
- Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
(LinuxChromeDriver.launch_driver):
- Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
(LinuxFirefoxDriver.launch_driver):
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
(OSXChromeDriver.launch_driver):
(OSXChromeCanaryDriver.launch_driver):
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
(OSXFirefoxDriver.launch_driver):
(OSXFirefoxNightlyDriver.launch_driver):
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
- Scripts/webkitpy/benchmark_runner/utils.py:
(get_driver_binary_path):
- Scripts/webkitpy/common/system/autoinstall.py:
(AutoInstaller._unzip):
- Scripts/webkitpy/thirdparty/init.py:
(AutoinstallImportHook.find_module):
(AutoinstallImportHook._install_selenium):
(AutoinstallImportHook):
(AutoinstallImportHook._install_chromedriver):
(AutoinstallImportHook._install_geckodriver):
(AutoinstallImportHook.get_latest_pypi_url):
(AutoinstallImportHook.install_binary):
(autoinstall_everything):
(get_driver_filename):
(get_os_info):
- 6:17 PM Changeset in webkit [219852] by
-
- 2 edits in trunk/Source/WebKit
[iOS WK2] Crash under PageOverlayController::uninstallPageOverlay when doing multiple finds
https://bugs.webkit.org/show_bug.cgi?id=174806
rdar://problem/33501664
Reviewed by Tim Horton.
Calling TextIndicator::createWithSelectionInFrame can trigger layout via VisibleSelection code,
which can re-enter FindController::updateFindIndicator which has by now removed m_findIndicatorOverlay
from pageOverlayController's map, but not deleted it. The second call to uninstallPageOverlay()
thus crashes at m_overlayGraphicsLayers.take(&overlay)->removeFromParent().
Fix by nulling out m_findIndicatorOverlay as soon as we uninstall it.
- WebProcess/WebPage/ios/FindControllerIOS.mm:
(WebKit::FindController::updateFindIndicator):
- 5:51 PM Changeset in webkit [219851] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Settings: Some controls overlay settings header
https://bugs.webkit.org/show_bug.cgi?id=174804
Patch by Nikita Vasilyev <me@elv1s.ru> on 2017-07-24
Reviewed by Matt Baker.
- UserInterface/Views/SettingsTabContentView.css:
(.content-view.settings .navigation-bar):
- 5:40 PM Changeset in webkit [219850] by
-
- 11 edits in trunk/Tools
Add WebDriver support in browser driver part of BenchmarkRunner
https://bugs.webkit.org/show_bug.cgi?id=174445
Patch by Matthew Stewart <matthew_r_stewart@apple.com> on 2017-07-24
Reviewed by Stephanie Lewis.
Adds a launch_driver function to each BrowserDriver subclass. This
function sets up the arguments for the webdriver and launches the
webdriver specific to that browser.
- Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:
(BrowserDriver.launch_webdriver):
(BrowserDriver):
- Scripts/webkitpy/benchmark_runner/browser_driver/linux_browser_driver.py:
(LinuxBrowserDriver.launch_webdriver):
- Scripts/webkitpy/benchmark_runner/browser_driver/linux_chrome_driver.py:
(LinuxChromeDriver.launch_url):
(LinuxChromeDriver):
(LinuxChromeDriver.launch_driver):
- Scripts/webkitpy/benchmark_runner/browser_driver/linux_epiphany_driver.py:
(EpiphanyBrowserDriver.launch_url):
(EpiphanyBrowserDriver):
(EpiphanyBrowserDriver.launch_driver):
- Scripts/webkitpy/benchmark_runner/browser_driver/linux_firefox_driver.py:
(LinuxFirefoxDriver):
(LinuxFirefoxDriver.launch_url):
(LinuxFirefoxDriver.launch_driver):
- Scripts/webkitpy/benchmark_runner/browser_driver/linux_minibrowsergtk_driver.py:
(GTKMiniBrowserDriver.launch_url):
(GTKMiniBrowserDriver):
(GTKMiniBrowserDriver.launch_driver):
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:
(OSXBrowserDriver._launch_webdriver):
(OSXBrowserDriver):
(OSXBrowserDriver._screen_size):
(OSXBrowserDriver._insert_url):
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:
(OSXChromeDriver):
(OSXChromeDriver.launch_url):
(OSXChromeDriver.launch_driver):
(OSXChromeCanaryDriver):
(OSXChromeCanaryDriver.launch_url):
(OSXChromeCanaryDriver.launch_driver):
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:
(OSXFirefoxDriver):
(OSXFirefoxDriver.launch_url):
(OSXFirefoxDriver.launch_driver):
(OSXFirefoxNightlyDriver):
(OSXFirefoxNightlyDriver.launch_url):
(OSXFirefoxNightlyDriver.launch_driver):
- Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:
(OSXSafariDriver.launch_driver):
- 4:54 PM Changeset in webkit [219849] by
-
- 2 edits in trunk/LayoutTests
[Win] The tests fast/text/line-height-minimumFontSize*.html are failing.
https://bugs.webkit.org/show_bug.cgi?id=174801
Unreviewed test gardening, update test expectations for failing tests.
- platform/win/TestExpectations:
- 4:52 PM Changeset in webkit [219848] by
-
- 2 edits in trunk/Source/WebCore
Consider implementing W3C Payment Request API
https://bugs.webkit.org/show_bug.cgi?id=174796
Reviewed by Daniel Bates.
Add Payment Request to features.json as "Under Consideration".
- features.json:
- 4:41 PM Changeset in webkit [219847] by
-
- 2 edits in trunk/LayoutTests
Marked tests as failures.
<rdar://problem/33437597>
Unreviewed test gardening.
- platform/mac-highsierra/TestExpectations:
- 4:12 PM Changeset in webkit [219846] by
-
- 2 edits in trunk/LayoutTests
Fixed typo in test expectations.
https://bugs.webkit.org/show_bug.cgi?id=173010
Unreviewed gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 3:50 PM Changeset in webkit [219845] by
-
- 3 edits in trunk/Source/WebKit
Fix lifetime management issue in ResourceLoadStatisticsPersistentStorage::scheduleOrWriteMemoryStore()
https://bugs.webkit.org/show_bug.cgi?id=174790
Reviewed by Brady Eidson.
Fix lifetime management issue in ResourceLoadStatisticsPersistentStorage::scheduleOrWriteMemoryStore().
WorkQueue::dispatchAfter() keeps the WorkQueue alive because its implementation keeps a strong ref to
|this|. As a result, the lambda passed to dispatchAfter(), which calls writeMemoryStoreToDisk(), can
get executed after the store is gone.
To address the issue, we now use a RunLoop::Timer to schedule the write, instead of a
WorkQueue::dispatchAfter() call. This way, we are guaranteed that the callback will not get called
after the store has been destroyed.
- UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.cpp:
(WebKit::ResourceLoadStatisticsPersistentStorage::ResourceLoadStatisticsPersistentStorage):
(WebKit::ResourceLoadStatisticsPersistentStorage::asyncWriteTimerFired):
(WebKit::ResourceLoadStatisticsPersistentStorage::scheduleOrWriteMemoryStore):
(WebKit::ResourceLoadStatisticsPersistentStorage::finishAllPendingWorkSynchronously):
(WebKit::ResourceLoadStatisticsPersistentStorage::ref):
(WebKit::ResourceLoadStatisticsPersistentStorage::deref):
- UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.h:
- 3:42 PM Changeset in webkit [219844] by
-
- 2 edits in trunk/LayoutTests
[Win] Async image tests are failing.
https://bugs.webkit.org/show_bug.cgi?id=174653
Unreviewed test gardening, update test expectations for async image tests.
- platform/win/TestExpectations:
- 3:29 PM Changeset in webkit [219843] by
-
- 2 edits in trunk/LayoutTests
Rebaseline this test. The previous result was generated using an older iOS SDK.
- fast/events/ios/no-touch-events-when-stopping-momentum-scroll-in-mainframe-expected.txt:
- 3:26 PM Changeset in webkit [219842] by
-
- 2 edits in trunk/LayoutTests
Mark Skia font test as image only failure on Windows.
Unreviewed test gardening.
- platform/win/TestExpectations:
- 2:57 PM Changeset in webkit [219841] by
-
- 2 edits in trunk/LayoutTests
LayoutTest userscripts/user-script-audio-document.html failing on High Sierra
https://bugs.webkit.org/show_bug.cgi?id=174726
rdar://problem/30059973
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-07-24
Reviewed by Alexey Proskuryakov.
Underlying issue has been resolved.
Re-enable test: userscripts/user-script-audio-document.html
- platform/mac-highsierra/TestExpectations:
- 2:57 PM Changeset in webkit [219840] by
-
- 2 edits in trunk/Source/WebCore
Unreviewed attempt to fix Mac cmake build
- PlatformMac.cmake:
- 2:53 PM Changeset in webkit [219839] by
-
- 2 edits in trunk/LayoutTests
Fix typo (Timout -> Timeout).
- platform/mac-wk2/TestExpectations:
- 2:42 PM Changeset in webkit [219838] by
-
- 3 edits in trunk/Source/WebKit
Unreviewed, rolling out r219828.
Causes debug assertions to be hit on iOS
Reverted changeset:
"Fix lifetime management issue in
ResourceLoadStatisticsPersistentStorage::scheduleOrWriteMemoryStore()"
https://bugs.webkit.org/show_bug.cgi?id=174790
http://trac.webkit.org/changeset/219828
- 2:21 PM Changeset in webkit [219837] by
-
- 2 edits in trunk/LayoutTests
5 wav media layoutTest timeouts on High Sierra
https://bugs.webkit.org/show_bug.cgi?id=174725
rdar://problem/30182218
Patch by Jeremy Jones <jeremyj@apple.com> on 2017-07-24
Reviewed by Andreas Kling.
Underlying issue is fixed. Re-enable tests on High Sierra.
media/audio-controls-timeline-in-media-document.html
media/audio-data-url.html
media/media-document-audio-controls-visible.html
media/media-document-audio-repaint.html
media/media-document-audio-size.html
- platform/mac-highsierra/TestExpectations:
- 1:58 PM Changeset in webkit [219836] by
-
- 3 edits1 copy in trunk/Tools
[Mac WK2] Add an API test to cover r219765 (null dereference in [WKWebView dealloc])
https://bugs.webkit.org/show_bug.cgi?id=174793
Reviewed by Tim Horton.
Adds a new unit test that invokes some asynchronous NSTextInputClient SPI methods as the web view is tearing
down. Without r219765, this test will dereference null and crash.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h: Added.
- TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm:
(TEST):
- 1:20 PM Changeset in webkit [219835] by
-
- 7 edits in branches/safari-604-branch/Source
Versioning.
- 1:15 PM Changeset in webkit [219834] by
-
- 1 copy in tags/Safari-604.1.33
Tag Safari-604.1.33.
- 12:16 PM Changeset in webkit [219833] by
-
- 3 edits in trunk/Source/WebDriver
WebDriver: rename m_browsingContext as m_currentBrowsingContext in Session
https://bugs.webkit.org/show_bug.cgi?id=174783
Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2017-07-24
Reviewed by Brian Burg.
We have m_toplevelBrowsingContext and m_browsingContext, which is confusing. m_browsingContext is actually the
current browsing context, and the spec also refers to it as the current browsing context, so better use
m_currentBrowsingContext.
- Session.cpp:
(WebDriver::Session::switchToTopLevelBrowsingContext):
(WebDriver::Session::switchToBrowsingContext):
(WebDriver::Session::switchToFrame):
(WebDriver::Session::switchToParentFrame):
(WebDriver::Session::computeElementLayout):
(WebDriver::Session::findElements):
(WebDriver::Session::isElementSelected):
(WebDriver::Session::getElementText):
(WebDriver::Session::getElementTagName):
(WebDriver::Session::isElementEnabled):
(WebDriver::Session::isElementDisplayed):
(WebDriver::Session::getElementAttribute):
(WebDriver::Session::waitForNavigationToComplete):
(WebDriver::Session::elementClear):
(WebDriver::Session::elementSendKeys):
(WebDriver::Session::elementSubmit):
(WebDriver::Session::executeScript):
- Session.h:
- 11:55 AM Changeset in webkit [219832] by
-
- 2 edits in trunk/Source/WebKit
[GTK][WPE] Stop using AutodrainedPool in IconDatabase
https://bugs.webkit.org/show_bug.cgi?id=174791
Reviewed by Alex Christensen.
AutodrainedPool seems to be some NS garbage collection thing that has no implementation on
other platforms. Now that IconDatabase is used only by GTK and WPE, we can stop using it.
- UIProcess/API/glib/IconDatabase.cpp:
(WebKit::IconDatabase::setIconDataForIconURL):
(WebKit::IconDatabase::setIconURLForPageURL):
(WebKit::IconDatabase::iconDatabaseSyncThread):
(WebKit::IconDatabase::performURLImport):
(WebKit::IconDatabase::readFromDatabase):
- 11:42 AM Changeset in webkit [219831] by
-
- 200 edits in trunk/Source
Make ExceptionCode a proper enumeration
https://bugs.webkit.org/show_bug.cgi?id=174771
Reviewed by Sam Weinig.
Make ExceptionCode a proper enumeration instead of a typedef to uint8_t.
Source/WebCore:
- Modules/fetch/FetchBody.h:
(WebCore::FetchBody::formData):
- Modules/indexeddb/shared/IDBError.h:
(WebCore::IDBError::encode):
(WebCore::IDBError::decode):
- bindings/js/JSSubtleCryptoCustom.cpp:
(WebCore::rejectWithException):
- dom/Exception.h:
- dom/ExceptionCode.h:
- fileapi/FileReaderSync.cpp:
(WebCore::errorCodeToExceptionCode):
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::texSubImage2D):
(WebCore::WebGLRenderingContextBase::texImage2D):
- xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):
- xml/XMLHttpRequest.h:
Source/WebKitLegacy/win:
- DOMCoreClasses.cpp:
(DOMDocument::createEvent):
- WebView.cpp:
(WebView::prepareCandidateWindow):
- 11:34 AM Changeset in webkit [219830] by
-
- 5 edits in trunk/Tools
[Win] Implement Authentication dialog in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=174662
Patch by Basuke Suzuki <Basuke Suzuki> on 2017-07-24
Reviewed by Alex Christensen.
- MiniBrowser/win/Common.cpp:
(CustomUserAgent):
(DisplayAuthDialog):
(AuthDialogProc):
- MiniBrowser/win/MiniBrowserLib.rc:
- MiniBrowser/win/MiniBrowserLibResource.h:
- MiniBrowser/win/ResourceLoadDelegate.cpp:
(ResourceLoadDelegate::didReceiveAuthenticationChallenge):
- 11:07 AM Changeset in webkit [219829] by
-
- 12 edits2 adds in trunk
Change "client" coordinates back to match scrolling coordinates
https://bugs.webkit.org/show_bug.cgi?id=174734
rdar://problem/33336930
Reviewed by Tim Horton.
Baidu.com (which uses jQuery), and various iOS apps make the assumption that getBoundingClientRect() returns a rectangle
that can be used to set or compare with the scroll position. With visual viewports, that assumption is no longer valid
when the page is zoomed, or when the keyboard has caused the visual viewport to detach from the layout viewport.
At this point the compatibility cost of shipping layout viewport-based client rects seems higher than the gain, so revert
to the shipping behavior. This reverts r216803, and will re-introduce bugs that occurred on zoomed pages on macOS,
many of which are noted in webkit.org/b/170981.
- page/FrameView.cpp:
(WebCore::FrameView::documentToClientOffset):
LayoutTests:
Revert "client" coordinates to be in scrolling coordinates
https://bugs.webkit.org/show_bug.cgi?id=174734
rdar://problem/33336930
Reviewed by Tim Horton.
Rebaseline.
- fast/events/ios/no-touch-events-when-stopping-momentum-scroll-in-mainframe-expected.txt:
- fast/visual-viewport/client-coordinates-relative-to-layout-viewport-expected.txt:
- fast/visual-viewport/client-rects-relative-to-layout-viewport-expected.txt:
- fast/visual-viewport/zoomed-fixed-expected.txt:
- fast/visual-viewport/zoomed-fixed-header-and-footer-expected.txt:
- fast/zooming/client-rect-in-fixed-zoomed-expected.txt:
- platform/ios-wk2/fast/visual-viewport/client-rects-relative-to-layout-viewport-expected.txt:
- platform/ios-wk2/imported/w3c/web-platform-tests/cssom-view/elementFromPoint-expected.txt: Added.
- platform/ios/fast/visual-viewport/zoomed-fixed-expected.txt:
- platform/ios/fast/visual-viewport/zoomed-fixed-header-and-footer-expected.txt:
- 10:43 AM Changeset in webkit [219828] by
-
- 3 edits in trunk/Source/WebKit
Fix lifetime management issue in ResourceLoadStatisticsPersistentStorage::scheduleOrWriteMemoryStore()
https://bugs.webkit.org/show_bug.cgi?id=174790
Reviewed by Brady Eidson.
Fix lifetime management issue in ResourceLoadStatisticsPersistentStorage::scheduleOrWriteMemoryStore().
WorkQueue::dispatchAfter() keeps the WorkQueue alive because its implementation keeps a strong ref to
|this|. As a result, the lambda passed to dispatchAfter(), which calls writeMemoryStoreToDisk(), can
get executed after the store is gone.
- UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.cpp:
(WebKit::ResourceLoadStatisticsPersistentStorage::ResourceLoadStatisticsPersistentStorage):
(WebKit::ResourceLoadStatisticsPersistentStorage::scheduleOrWriteMemoryStore):
- UIProcess/Storage/ResourceLoadStatisticsPersistentStorage.h:
(WebKit::ResourceLoadStatisticsPersistentStorage::createWeakPtr):
- 10:31 AM Changeset in webkit [219827] by
-
- 3 edits in trunk/Tools
Handle case where line_numbers is None instead of an array of line numbers
https://bugs.webkit.org/show_bug.cgi?id=174775
Reviewed by Aakash Jain.
Added files set line_numbers to None in process_file.
- Scripts/webkitpy/style/filereader.py:
(TextFileReader.process_file): Handle case where line_number is set to None.
- Scripts/webkitpy/style/main_unittest.py:
(ExpectationLinterInStyleCheckerTest.test_linter_added_file_with_error): Test case of an added file.
- 10:13 AM Changeset in webkit [219826] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: should only show Canvases in resource type filter if debug setting enabled
https://bugs.webkit.org/show_bug.cgi?id=174765
<rdar://problem/33479009>
Reviewed by Devin Rousso.
- UserInterface/Views/ResourceSidebarPanel.js:
(WebInspector.ResourceSidebarPanel):
- 9:41 AM Changeset in webkit [219825] by
-
- 2 edits in trunk/LayoutTests
Marked tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical.html as failure.
https://bugs.webkit.org/show_bug.cgi?id=172148
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 9:06 AM Changeset in webkit [219824] by
-
- 2 edits in trunk/LayoutTests
Remove race from one plug-in test
https://bugs.webkit.org/show_bug.cgi?id=130653
Reviewed by Antti Koivisto.
- plugins/plugin-remove-readystatechange.html: Updated test to use waitUntilDone/notifyDone
rather than racing. Added a computation of offsetLeft to trigger layout and adding a long
comment explaining why this is both needed and potentially insufficient in the long run.
- 9:01 AM Changeset in webkit [219823] by
-
- 3 edits in trunk/Source/WebCore/PAL
[CMake] libtasn1 should not be required when not enabling subtle_crypto
https://bugs.webkit.org/show_bug.cgi?id=174785
Reviewed by Žan Doberšek.
- pal/PlatformGTK.cmake:
- pal/PlatformWPE.cmake:
- 8:43 AM Changeset in webkit [219822] by
-
- 4 edits10 adds in branches/safari-604-branch
Cherry-pick r219665.
- 7:46 AM Changeset in webkit [219821] by
-
- 2 edits in trunk/Source/JavaScriptCore
Gardening: fixed C Loop build after r219790.
https://bugs.webkit.org/show_bug.cgi?id=174696
Not reviewed.
- assembler/testmasm.cpp:
- 7:27 AM Changeset in webkit [219820] by
-
- 5 edits in trunk
[WPE] Add libepoxy to the Jhbuild moduleset
https://bugs.webkit.org/show_bug.cgi?id=174711
Reviewed by Carlos Alberto Lopez Perez.
.:
libepoxy 1.3.1 that's widely available in current stable distributions (Debian stable,
Ubuntu LTS) does suffice our needs, but also contains a bug that incorrectly determines
the current EGL context and the API version of OpenGL that's bound to that context.
Focusing on experiences on Debian systems, while the current stable Debian release has
this bug patched, the package for the testing distribution of Debian removed that same
patch for whatever reason, despite using the 1.3.1 version as the package basis.
To avoid this, libepoxy 1.4.3 is now added to WPE's Jhbuild moduleset. The WPE port
also now demands at least the 1.4.0 version to be available when configuring.
We should revisit the minimum version for libepoxy in the future if the 1.3 release
branch gets updated with the proper fix.
- Source/cmake/FindLibEpoxy.cmake:
- Source/cmake/OptionsWPE.cmake:
Tools:
- wpe/jhbuild.modules: Add libepoxy 1.4.3 to WPE's Jhbuild moduleset.
- 7:24 AM Changeset in webkit [219819] by
-
- 11 edits3 adds1 delete in trunk
[WPE] libepoxy headers can use EGL_CAST, which might not be defined by eglplatform.h
https://bugs.webkit.org/show_bug.cgi?id=174780
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Newer versions of libepoxy provide EGL definitions that already use the EGL_CAST macro.
We'd like to compile on systems where the eglplatform.h header doesn't yet provide
that macro that was added only recently (e.g. it's available in Mesa 17.1, but not
before).
To address that, the EpoxyEGL.h header is added that first includes the libepoxy's EGL
header and then provides the EGL_CAST definition in case the eglplatform.h header doesn't.
This header should be included in place of <epoxy/egl.h> (which is included in this new
header).
The EpoxyEGL.h and EpoxyShims.h headers are also moved under the platform/graphics/epoxy/
directory, with the new directory added to the list of inclusion paths for WPE.
- PlatformWPE.cmake:
- platform/graphics/PlatformDisplay.cpp:
- platform/graphics/cairo/CairoUtilities.cpp:
- platform/graphics/cairo/ImageBufferCairo.cpp:
- platform/graphics/egl/GLContextEGL.cpp:
- platform/graphics/egl/GLContextEGLWPE.cpp:
- platform/graphics/epoxy/EpoxyEGL.h: Added.
- platform/graphics/epoxy/EpoxyShims.h: Renamed from Source/WebCore/platform/graphics/EpoxyShims.h.
- platform/graphics/opengl/Extensions3DOpenGLES.cpp:
- platform/graphics/wpe/PlatformDisplayWPE.cpp:
Tools:
- WebKitTestRunner/wpe/HeadlessViewBackend.cpp:
Manually define the EGL_CAST macro to the C++ version that uses static_cast<>
in case the eglplatform.h header doesn't provide that macro. This replicates
the work in WebCore's EpoxyEGL.h header, but we can't include that header here.
- 6:50 AM Changeset in webkit [219818] by
-
- 1 edit1 delete in trunk/Source/WebCore
[CoordinatedGraphics] Remove unused GLDefs.h header
https://bugs.webkit.org/show_bug.cgi?id=174712
Reviewed by Michael Catanzaro.
- platform/graphics/opengl/GLDefs.h: Remove this unused header.
As far as my recollection goes it was used in the IPC-based
CoordinatedGraphics subsystem, which has been removed already.
- 5:46 AM Changeset in webkit [219817] by
-
- 1 copy in releases/WebKitGTK/webkit-2.16.6
WebKitGTK+ 2.16.6
- 5:45 AM Changeset in webkit [219816] by
-
- 4 edits in releases/WebKitGTK/webkit-2.16
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.16.6 release.
.:
- Source/cmake/OptionsGTK.cmake:
Source/WebKit2:
- gtk/NEWS: Add release notes for 2.16.6.
- 4:57 AM WebKitGTK/2.16.x edited by
- (diff)
- 4:15 AM WebKitGTK/2.16.x edited by
- (diff)
- 4:13 AM Changeset in webkit [219815] by
-
- 2 edits in releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore
Unreviewed. Fix the build with GCC 4.9 after merge r217438.
- bytecompiler/BytecodeGenerator.h:
(JSC::StructureForInContext::addGetInst):
- 4:09 AM Changeset in webkit [219814] by
-
- 3 edits in releases/WebKitGTK/webkit-2.16/Source/ThirdParty/ANGLE
Merge r219446 - eglplatform.h does not support Wayland
https://bugs.webkit.org/show_bug.cgi?id=163482
This makes it possible to build WebKitGTK+ when the target system has only Wayland support,
but no X11 (and therefore the X11 headers are not present).
Reviewed by Alex Christensen.
- include/EGL/eglplatform.h: Add Wayland typedefs when WL_EGL_PLATFORM is defined (for example
by including wayland-egl.h before including EGL/egl.h). Also, include the X11 headers only
when ANGLE_USE_X11 is defined and, for consistency with Mesa's version of the header, when
MESA_EGL_NO_X11_HEADERS is not defined.
- 4:07 AM Changeset in webkit [219813] by
-
- 3 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore
Merge r219332, r219447 - [GTK] Spin buttons on input type number appear over the value itself for small widths
https://bugs.webkit.org/show_bug.cgi?id=173572
Reviewed by Carlos Garcia Campos.
Source/WebCore:
When drawing the spin buttons, override the width of the input
element to increment it with the width of the spin button.
This ensures that we don't end up covering the input values with
the spin buttons.
Do this also for user controlled styles, because most web authors
won't test how their site renders on WebKitGTK+, and they will
assume spin buttons in the order of 13 pixels wide (that is what
most browsers use), but the GTK+ spin button is much wider (66 pixels).
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
- rendering/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::adjustTextFieldStyle): Call the theme's adjustTextFieldStyle() also for user controlled styles.
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
REGRESSION(r219332): [GTK] 9 new failures on fast/forms spinbutton related tests
https://bugs.webkit.org/show_bug.cgi?id=174395
Reviewed by Carlos Garcia Campos.
Source/WebCore:
Before r219332 the height of the spin button widget was
calculated as the maximum value between the individual button
( the [+] or [-] ) width (33 pixels) and height (16 pixels).
And r219332 caused the height of the widget to be calculated as
the height of the button (16 pixels), which was incorrect as
each button should be first expanded vertically to fit the
preferred size of the widget.
Fix this by making the calculations about the spin button widget
on a new function spinButtonSize() that takes this into account,
and use this values both for adjusting the style of the input
field and the spin button widget itself.
- rendering/RenderThemeGtk.cpp:
(WebCore::spinButtonSize):
(WebCore::RenderThemeGtk::adjustTextFieldStyle):
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
- 3:57 AM Changeset in webkit [219812] by
-
- 3 edits1 add in releases/WebKitGTK/webkit-2.16
Merge r218819 - Crash in JSC::Lexer<unsigned char>::setCode
https://bugs.webkit.org/show_bug.cgi?id=172754
Reviewed by Mark Lam.
JSTests:
- stress/dont-reserve-huge-capacity-lexer.js: Added.
(catch):
Source/JavaScriptCore:
The lexer was asking one of its buffers to reserve initial space that
was O(text size in bytes). For large sources, this would end up causing
the vector to overflow and crash. This patch changes this code be like
the Lexer's other buffers and to only reserve a small starting buffer.
- parser/Lexer.cpp:
(JSC::Lexer<T>::setCode):
- 3:53 AM Changeset in webkit [219811] by
-
- 3 edits2 adds in releases/WebKitGTK/webkit-2.16
Merge r216813 - Elements should be inserted into a template element as its content's last child
https://bugs.webkit.org/show_bug.cgi?id=171373
<rdar://problem/31862949>
Reviewed by Ryosuke Niwa.
Source/WebCore:
Before this change, our HTML parser obeys the following premises:
1) A fostering child whose parent is a table should be inserted before its parent and under its grandparent.
2) When inserting into a template element, an element should be inserted into its content.
Let's walk through the example:
a) Before eventhandler takes place
template
table
svg <- parser
b) After eventhandler takes place
template
table
svg <- parser
c) after parsing svg
template
content
svg
(table)
table
Finally, in the example, the svg element will be inserted into the content of the template element while
having its next sibling point to the table element. However, the table element is actually under the
template element not its content.
This messy tree is constructed because the second premise is incompleted. It should be: When inserting into
a template element, an element should be inserted into its content as its last child.
Quoted from Step 3 of https://html.spec.whatwg.org/multipage/syntax.html#appropriate-place-for-inserting-a-node
A correct tree will then looks like:
template
content
svg
table
Tests: fast/dom/HTMLTemplateElement/insert-fostering-child-crash.html
fast/dom/HTMLTemplateElement/insert-fostering-child.html
- html/parser/HTMLConstructionSite.cpp:
(WebCore::insert):
By nullifying task.nextChild, it will force the parser to append the element as task.parent's last child.
LayoutTests:
- fast/dom/HTMLTemplateElement/insert-fostering-child-expected.txt: Added.
- fast/dom/HTMLTemplateElement/insert-fostering-child.html: Added.
- 3:51 AM Changeset in webkit [219810] by
-
- 3 edits1 add in releases/WebKitGTK/webkit-2.16
Merge r215351 - Should use flushDirect() when flushing the scopeRegister due to needsScopeRegister().
https://bugs.webkit.org/show_bug.cgi?id=170661
<rdar://problem/31579046>
Reviewed by Filip Pizlo.
JSTests:
- stress/regress-170661.js: Added.
Source/JavaScriptCore:
Previously, we were using flush() to flush the outermost frame's scopeRegister.
This is incorrect because flush() expects the VirtualRegister value passed to
it to be that of the top most inlined frame. In the event that we reach a
terminal condition while inside an inlined frame, flush() will end up flushing
the wrong register. The fix is simply to use flushDirect() instead.
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::flush):
- 3:49 AM Changeset in webkit [219809] by
-
- 3 edits1 add in releases/WebKitGTK/webkit-2.16
Merge r215596 - virtualThunkFor() needs to materialize its of tagMaskRegister for tail calls.
https://bugs.webkit.org/show_bug.cgi?id=171079
<rdar://problem/31684756>
Reviewed by Saam Barati.
JSTests:
- stress/regress-171079.js: Added.
Source/JavaScriptCore:
This is needed because tail calls would restore callee saved registers (and
therefore, potentially clobber the tag registers) before jumping to the thunk.
- jit/ThunkGenerators.cpp:
(JSC::virtualThunkFor):
- 3:48 AM Changeset in webkit [219808] by
-
- 4 edits in releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore
Merge r216309 - Put does not properly consult the prototype chain
https://bugs.webkit.org/show_bug.cgi?id=171754
Reviewed by Saam Barati.
We should do a follow up that cleans up the rest of put. See:
https://bugs.webkit.org/show_bug.cgi?id=171759
- runtime/JSCJSValue.cpp:
(JSC::JSValue::putToPrimitive):
- runtime/JSObject.cpp:
(JSC::JSObject::putInlineSlow):
- runtime/JSObjectInlines.h:
(JSC::JSObject::canPerformFastPutInline):
- 3:31 AM Changeset in webkit [219807] by
-
- 2 edits in releases/WebKitGTK/webkit-2.16/Source/JavaScriptCore
Unreviewed. Fix merge r217438.
See bug #174781.
- bytecompiler/BytecodeGenerator.cpp:
(JSC::StructureForInContext::finalize): Use operand instead of unsignedValue.
- 3:28 AM Changeset in webkit [219806] by
-
- 13 edits3 adds in releases/WebKitGTK/webkit-2.16
Merge r216279 - putDirectIndex does not properly do defineOwnProperty
https://bugs.webkit.org/show_bug.cgi?id=171591
<rdar://problem/31735695>
Reviewed by Geoffrey Garen.
JSTests:
- stress/array-prototype-splice-making-typed-array.js:
(test):
- stress/array-species-config-array-constructor.js:
(shouldThrow):
(test):
- stress/put-direct-index-broken-2.js: Added.
(assert):
(test):
(makeLengthWritable):
(set get restoreOldDesc):
- stress/put-direct-index-broken.js: Added.
(whatToTest):
(tryRunning):
(tryItOut):
- stress/put-indexed-getter-setter.js: Added.
(foo.X.prototype.set 7):
(foo.X.prototype.get 7):
(foo.X):
(foo):
Source/JavaScriptCore:
This patch fixes putDirectIndex and its JIT implementations to be
compatible with the ES6 spec. I think our code became out of date
when we implemented ArraySpeciesCreate since ArraySpeciesCreate may
return arbitrary objects. We perform putDirectIndex on that arbitrary
object. The behavior we want is as if we performed defineProperty({configurable:true, enumerable:true, writable:true}).
However, we weren't doing this. putDirectIndex assumed it could just splat
data into any descendent of JSObject's butterfly. For example, this means
we'd just splat into the butterfly of a typed array, even though a typed
array doesn't use its butterfly to store its indexed properties in the usual
way. Also, typed array properties are non-configurable, so this operation
should throw. This also means if we saw a ProxyObject, we'd just splat
into its butterfly, but this is obviously wrong because ProxyObject should
intercept the defineProperty operation.
This patch fixes this issue by adding a whitelist of cell types that can
go down putDirectIndex's fast path. Anything not in that whitelist will
simply call into defineOwnProperty.
- bytecode/ByValInfo.h:
(JSC::jitArrayModePermitsPutDirect):
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::refine):
- jit/JITOperations.cpp:
- runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncSplice):
- runtime/ClonedArguments.cpp:
(JSC::ClonedArguments::createStructure):
- runtime/JSGenericTypedArrayViewInlines.h:
(JSC::JSGenericTypedArrayView<Adaptor>::defineOwnProperty):
- runtime/JSObject.cpp:
(JSC::canDoFastPutDirectIndex):
(JSC::JSObject::defineOwnIndexedProperty):
(JSC::JSObject::putDirectIndexSlowOrBeyondVectorLength):
(JSC::JSObject::putDirectIndexBeyondVectorLength): Deleted.
- runtime/JSObject.h:
(JSC::JSObject::putDirectIndex):
(JSC::JSObject::canSetIndexQuicklyForPutDirect): Deleted.
- runtime/JSType.h:
- 2:54 AM Changeset in webkit [219805] by
-
- 5 edits2 adds in releases/WebKitGTK/webkit-2.16
Merge r216992 - Replace CryptoOperationData with BufferSource for WebKitSubtleCrypto
https://bugs.webkit.org/show_bug.cgi?id=172146
<rdar://problem/32122256>
Reviewed by Brent Fulgham.
Source/WebCore:
In this patch, we replaces CryptoOperationData with BufferSource for WebKitSubtleCrypto in
the custom binding codes.
Test: crypto/webkitSubtle/import-export-raw-key-leak.html
- bindings/js/JSWebKitSubtleCryptoCustom.cpp:
(WebCore::JSWebKitSubtleCrypto::encrypt):
(WebCore::JSWebKitSubtleCrypto::decrypt):
(WebCore::JSWebKitSubtleCrypto::sign):
(WebCore::JSWebKitSubtleCrypto::verify):
(WebCore::JSWebKitSubtleCrypto::digest):
(WebCore::JSWebKitSubtleCrypto::importKey):
(WebCore::JSWebKitSubtleCrypto::unwrapKey):
- crypto/WebKitSubtleCrypto.idl:
LayoutTests:
- crypto/webkitSubtle/argument-conversion-expected.txt:
- crypto/webkitSubtle/import-export-raw-key-leak-expected.txt: Added.
- crypto/webkitSubtle/import-export-raw-key-leak.html: Added.
- 2:51 AM Changeset in webkit [219804] by
-
- 2 edits in releases/WebKitGTK/webkit-2.16/JSTests
Merge r217018 - Unreviewed, address mlam's review feedback.
- stress/arguments-elimination-varargs-too-many-args-arg-count.js:
- 2:50 AM Changeset in webkit [219803] by
-
- 3 edits1 add in releases/WebKitGTK/webkit-2.16
Merge r217016 - JSC: Incorrect LoadVarargs handling in ArgumentsEliminationPhase::transform
https://bugs.webkit.org/show_bug.cgi?id=172208
Reviewed by Saam Barati.
JSTests:
- stress/arguments-elimination-varargs-too-many-args-arg-count.js: Added.
(foo):
(bar):
(baz):
Source/JavaScriptCore:
- dfg/DFGArgumentsEliminationPhase.cpp:
- 2:45 AM Changeset in webkit [219802] by
-
- 3 edits1 add in releases/WebKitGTK/webkit-2.16
Merge r215451 - JSArray::appendMemcpy() needs to handle copying from Undecided indexing type too.
https://bugs.webkit.org/show_bug.cgi?id=170896
<rdar://problem/31651319>
Reviewed by JF Bastien and Keith Miller.
JSTests:
- stress/regress-170896.js: Added.
Source/JavaScriptCore:
- runtime/JSArray.cpp:
(JSC::JSArray::appendMemcpy):
- 2:41 AM Changeset in webkit [219801] by
-
- 13 edits1 add in releases/WebKitGTK/webkit-2.16
Merge r217438 - Our for-in optimization in the bytecode generator does its static analysis incorrectly
https://bugs.webkit.org/show_bug.cgi?id=172532
<rdar://problem/32369452>
Reviewed by Mark Lam.
JSTests:
- stress/for-in-invalidation-for-any-write.js: Added.
(assert):
(test):
(test.i):
Source/JavaScriptCore:
Our static analysis for when a for-in induction variable
is written to tried to its analysis as we generate
bytecode. This has issues, since it does not account for
the dynamic execution path of the program. Let's consider
a program where our old analysis worked:
`
for (let p in o) {
o[p]; We can transform this into a fast get_direct_pname
p = 20;
o[p]; We cannot transform this since p has been changed.
}
`
However, our static analysis did not account for loops, which exist
in JavaScript. e.g, it would incorrectly compile this program as:
`
for (let p in o) {
for (let i = 0; i < 20; ++i) {
o[p]; It transforms this to use get_direct_pname even though p will be over-written if we get here from the inner loop back edge!
p = 20;
o[p]; We correctly do not transform this.
}
}
`
Because of this flaw, I've made the optimization more conservative.
We now optimistically emit code for the optimized access. However,
if a for-in context is *ever* invalidated, before we pop it off
the stack, we rewrite the program's optimized accesses to no longer
be optimized. To do this, each context keeps track of its optimized
accesses.
This patch also adds a new bytecode, op_nop, which is just a no-op.
It was helpful to add this because reverting get_direct_pname to get_by_val
will leave us with an extra instruction word because get_direct_pname is
has a length of 7 where get_by_val has a length of 6. This leaves us with
an extra slot that we fill with an op_nop.
- bytecode/BytecodeDumper.cpp:
(JSC::BytecodeDumper<Block>::dumpBytecode):
- bytecode/BytecodeList.json:
- bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
- bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetByVal):
(JSC::BytecodeGenerator::popIndexedForInScope):
(JSC::BytecodeGenerator::popStructureForInScope):
(JSC::BytecodeGenerator::invalidateForInContextForLocal):
(JSC::StructureForInContext::pop):
(JSC::IndexedForInContext::pop):
- bytecompiler/BytecodeGenerator.h:
(JSC::StructureForInContext::addGetInst):
(JSC::IndexedForInContext::addGetInst):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
- dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
- jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
- jit/JIT.h:
- jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_nop):
- llint/LowLevelInterpreter.asm:
- 2:40 AM Changeset in webkit [219800] by
-
- 2 edits in releases/WebKitGTK/webkit-2.16/Source/WebCore
Merge r216825 - AccessibilityRenderObject::textUnderElement needs to assert on unclean tree.
https://bugs.webkit.org/show_bug.cgi?id=172065
Reviewed by Simon Fraser.
r192103 changed the assert logic incorrectly. If the tree is dirty, regardless of the renderer's type,
TextIterator will end up forcing style update/layout on the render tree.
The original assert would have hit with bug 171546 prior to r216726.
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::textUnderElement):
- 2:40 AM Changeset in webkit [219799] by
-
- 7 edits2 adds in releases/WebKitGTK/webkit-2.16
Merge r216726 - AX: Defer text changes until after the tree is clean if needed.
https://bugs.webkit.org/show_bug.cgi?id=171546
<rdar://problem/31934942>
Reviewed by Simon Fraser.
Source/WebCore:
While updating an accessibility object state, we might
trigger unintentional style updates. This style update could
end up destroying renderes that are still referenced by functions
on the callstack.
To avoid that, defer such changes and let AXObjectCache operate on a clean tree.
Test: accessibility/crash-when-render-tree-is-not-clean.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::handleAttributeChanged):
(WebCore::AXObjectCache::labelChanged):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::AXObjectCache::deferRecomputeIsIgnored):
(WebCore::AXObjectCache::deferTextChangedIfNeeded):
(WebCore::AXObjectCache::recomputeDeferredIsIgnored): Deleted.
(WebCore::AXObjectCache::deferTextChanged): Deleted.
- accessibility/AXObjectCache.h: Decouple different type of changes.
(WebCore::AXObjectCache::deferRecomputeIsIgnored):
(WebCore::AXObjectCache::deferTextChangedIfNeeded):
(WebCore::AXObjectCache::recomputeDeferredIsIgnored): Deleted.
(WebCore::AXObjectCache::deferTextChanged): Deleted.
- rendering/RenderBlock.cpp:
(WebCore::RenderBlock::deleteLines):
- rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::createAndAppendRootInlineBox):
- rendering/RenderText.cpp:
(WebCore::RenderText::setText):
LayoutTests:
- accessibility/crash-when-render-tree-is-not-clean-expected.txt: Added.
- accessibility/crash-when-render-tree-is-not-clean.html: Added.
- 1:58 AM Changeset in webkit [219798] by
-
- 6 edits2 adds in releases/WebKitGTK/webkit-2.16
Merge r216096 - Defer AX cache update when text content changes until after layout is finished.
https://bugs.webkit.org/show_bug.cgi?id=171429
<rdar://problem/31885984>
Reviewed by Simon Fraser.
Source/WebCore:
When the content of the RenderText changes (even as the result of a text-transform change)
instead of updating the AX cache eagerly (and trigger layout on a half-backed render tree)
we should just defer it until after the subsequent layout is done.
Test: accessibility/crash-while-adding-text-child-with-transform.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::remove):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::AXObjectCache::recomputeDeferredIsIgnored):
(WebCore::AXObjectCache::deferTextChanged):
(WebCore::AXObjectCache::performDeferredIsIgnoredChange): Deleted.
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::deferTextChanged):
(WebCore::AXObjectCache::performDeferredCacheUpdate):
(WebCore::AXObjectCache::performDeferredIsIgnoredChange): Deleted.
- page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
- rendering/RenderText.cpp:
(WebCore::RenderText::setText):
LayoutTests:
- accessibility/crash-while-adding-text-child-with-transform-expected.txt: Added.
- accessibility/crash-while-adding-text-child-with-transform.html: Added.
- 1:33 AM Changeset in webkit [219797] by
-
- 8 edits7 adds in trunk
Add attribute allow-top-navigation-by-user-activation to iframe sandbox
https://bugs.webkit.org/show_bug.cgi?id=171327
Patch by Frederic Wang <fwang@igalia.com> on 2017-07-11
Reviewed by Chris Dumez.
LayoutTests/imported/w3c:
This commit updates the expectation for the test verifying that a sandboxed iframe without
the allow-top-navigation-by-user-activation flag set can not perform top navigation if it is
not triggered by a user gesture. The navigation is still prohibited but the parsing of the
allow-top-navigation-by-user-activation flag should not raised any error message.
A similar update is done for the test verifying that the combination of the flags
allow-top-navigation-by-user-activation and allow-top-navigation.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_top_navigation_by_user_activation_without_user_gesture-expected.txt: Remove the error message.
- web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_top_navigation-3-expected.txt: Ditto.
Source/WebCore:
Tests: http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-1.html
http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-2.html
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_top_navigation_by_user_activation_without_user_gesture-expected.txt
imported/w3c/web-platform-tests/html/semantics/embedded-content/the-iframe-element/iframe_sandbox_allow_top_navigation-3-expected.txt
- dom/Document.cpp:
(WebCore::Document::canNavigate): Case 2 of conformance verification is refined to match the
current specification: Top navigation is allowed when it is triggered by user activation and
when allow-top-navigation-by-user-activation is set. Because we have additional "security
origin" rules with respect to the specification we also add some early return to ensure that
navigation is really allowed for this new case.
- dom/SecurityContext.cpp:
(WebCore::SecurityContext::isSupportedSandboxPolicy): Add allow-top-navigation-by-user-activation flag.
(WebCore::SecurityContext::parseSandboxPolicy): Parse the new flag to allow top user
navigation by user activation. Also, make sure that allow-top-navigation allows such
navigation as defined by the specification.
- dom/SecurityContext.h: Declare new sandboxing flag.
LayoutTests:
This patch adds tests to verify that a sandboxed iframe with the flag
'allow-top-navigation-by-user-activation' or 'allow-top-navigation' can navigate the top
level page, if navigation is triggered by a user gesture. This is based on a test from the
Chromium repository.
It also verifies that navigation fails when 'allow-top-navigation-by-user-activation' is
absent, even when it is triggered by a user gesture.
- http/tests/security/frameNavigation/resources/iframe-that-performs-parent-navigation-with-user-activation.html: Added. This is similar to iframe-that-performs-parent-navigation.html but it
performs navigation of its parent using user activation.
- http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-1.html: Added.
Test top navigation for a sandboxed frame with 'allow-top-navigation-by-user-activation'
- http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-1-expected.txt: Added.
Add PASS expectation.
- http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-2.html: Added.
Test top navigation for a sandboxed frame with 'allow-top-navigation'.
- http/tests/security/frameNavigation/sandbox-ALLOWED-top-navigation-with-user-gesture-2-expected.txt: Added.
Add PASS expectation.
- http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-with-user-gesture.html: Added.
Test user-triggered navigation for a sandboxed frame without 'allow-top-navigation-by-user-activation'.
- http/tests/security/frameNavigation/sandbox-DENIED-top-navigation-with-user-gesture-expected.txt: Added.
Add reference with navigation failure.
