Timeline



Aug 11, 2017:

10:18 PM Changeset in webkit [220623] by beidson@apple.com
  • 4 edits
    22 moves
    1 add in trunk/Source/WebCore

Move files inside WebCore/workers to WebCore/workers/service.
​https://bugs.webkit.org/show_bug.cgi?id=175495

Rubberstamped by Tim Horton.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • workers/service/ServiceWorker.cpp: Renamed from Source/WebCore/workers/ServiceWorker.cpp.
  • workers/service/ServiceWorker.h: Renamed from Source/WebCore/workers/ServiceWorker.h.
  • workers/service/ServiceWorker.idl: Renamed from Source/WebCore/workers/ServiceWorker.idl.
  • workers/service/ServiceWorkerContainer.cpp: Renamed from Source/WebCore/workers/ServiceWorkerContainer.cpp.
  • workers/service/ServiceWorkerContainer.h: Renamed from Source/WebCore/workers/ServiceWorkerContainer.h.
  • workers/service/ServiceWorkerContainer.idl: Renamed from Source/WebCore/workers/ServiceWorkerContainer.idl.
  • workers/service/ServiceWorkerGlobalScope.cpp: Renamed from Source/WebCore/workers/ServiceWorkerGlobalScope.cpp.
  • workers/service/ServiceWorkerGlobalScope.h: Renamed from Source/WebCore/workers/ServiceWorkerGlobalScope.h.
  • workers/service/ServiceWorkerGlobalScope.idl: Renamed from Source/WebCore/workers/ServiceWorkerGlobalScope.idl.
  • workers/service/ServiceWorkerJob.cpp: Renamed from Source/WebCore/workers/ServiceWorkerJob.cpp.
  • workers/service/ServiceWorkerJob.h: Renamed from Source/WebCore/workers/ServiceWorkerJob.h.
  • workers/service/ServiceWorkerJobClient.h: Renamed from Source/WebCore/workers/ServiceWorkerJobClient.h.
  • workers/service/ServiceWorkerProvider.cpp: Renamed from Source/WebCore/workers/ServiceWorkerProvider.cpp.
  • workers/service/ServiceWorkerProvider.h: Renamed from Source/WebCore/workers/ServiceWorkerProvider.h.
  • workers/service/ServiceWorkerRegistration.cpp: Renamed from Source/WebCore/workers/ServiceWorkerRegistration.cpp.
  • workers/service/ServiceWorkerRegistration.h: Renamed from Source/WebCore/workers/ServiceWorkerRegistration.h.
  • workers/service/ServiceWorkerRegistration.idl: Renamed from Source/WebCore/workers/ServiceWorkerRegistration.idl.
  • workers/service/ServiceWorkerRegistrationOptions.h: Renamed from Source/WebCore/workers/ServiceWorkerRegistrationOptions.h.
  • workers/service/ServiceWorkerRegistrationParameters.cpp: Renamed from Source/WebCore/workers/ServiceWorkerRegistrationParameters.cpp.
  • workers/service/ServiceWorkerRegistrationParameters.h: Renamed from Source/WebCore/workers/ServiceWorkerRegistrationParameters.h.
  • workers/service/ServiceWorkerUpdateViaCache.h: Renamed from Source/WebCore/workers/ServiceWorkerUpdateViaCache.h.
  • workers/service/ServiceWorkerUpdateViaCache.idl: Renamed from Source/WebCore/workers/ServiceWorkerUpdateViaCache.idl.
7:51 PM Changeset in webkit [220622] by Chris Dumez
  • 37 edits
    4 adds in trunk

Implement quota limitation for keepalive Fetch requests
​https://bugs.webkit.org/show_bug.cgi?id=175482

Reviewed by Sam Weinig and Youenn Fablet.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt:
  • web-platform-tests/fetch/api/basic/scheme-about.any.worker-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-multiple-origins-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-multiple-origins-worker-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-preflight-star.any-expected.txt:
  • web-platform-tests/fetch/api/cors/cors-preflight-star.any.worker-expected.txt:
  • web-platform-tests/fetch/http-cache/cc-request-expected.txt:

Rebaseline tests now that we provide a more helpful error message when rejecting
the fetch() promise.

  • web-platform-tests/fetch/api/request/request-keepalive-quota-expected.txt:

Rebaseline test for keepalive Fetch requests quota which is now passing.

Source/WebCore:

Implement quota limitation for keepalive Fetch requests as per:

This partly works for Beacon as well, meaning that no Beacon with a body
over 64Kb can be sent. However, we don't keep track about wether or not
beacon loads are inflight or not.

Also update CachedResourceLoader::requestResource() so that the caller
can get a ResourceError when it returns null. This is useful for both
Fetch and Beacon to return better error messages.

Test: http/wpt/beacon/beacon-quota.html

  • CMakeLists.txt:
  • Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

  • Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::BlobLoader::didReceiveResponse):
(WebCore::FetchBodyOwner::BlobLoader::didFail):

  • Modules/fetch/FetchBodyOwner.h:
  • Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):
(WebCore::FetchLoader::didFail):

  • Modules/fetch/FetchLoaderClient.h:
  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::BodyLoader::didFail):

  • Modules/fetch/FetchResponse.h:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • loader/cache/CachedResource.h:

(WebCore::CachedResource::isMainOrMediaOrIconOrRawResource const):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestFont):
(WebCore::CachedResourceLoader::requestTextTrack):
(WebCore::CachedResourceLoader::requestCSSStyleSheet):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestScript):
(WebCore::CachedResourceLoader::requestXSLStyleSheet):
(WebCore::CachedResourceLoader::requestSVGDocument):
(WebCore::CachedResourceLoader::requestLinkResource):
(WebCore::CachedResourceLoader::requestMedia):
(WebCore::CachedResourceLoader::requestIcon):
(WebCore::CachedResourceLoader::requestRawResource):
(WebCore::CachedResourceLoader::requestBeaconResource):
(WebCore::CachedResourceLoader::requestMainResource):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::preload):

  • loader/cache/CachedResourceLoader.h:
  • loader/cache/KeepaliveRequestTracker.cpp: Added.

(WebCore::KeepaliveRequestTracker::~KeepaliveRequestTracker):
(WebCore::KeepaliveRequestTracker::canLoadRequest):
(WebCore::KeepaliveRequestTracker::registerRequest):
(WebCore::KeepaliveRequestTracker::responseReceived):
(WebCore::KeepaliveRequestTracker::notifyFinished):
(WebCore::KeepaliveRequestTracker::unregisterRequest):

  • loader/cache/KeepaliveRequestTracker.h: Added.
  • platform/network/FormData.cpp:

(WebCore::FormDataElement::lengthInBytes const):
(WebCore::FormData::lengthInBytes const):

  • platform/network/FormData.h:

LayoutTests:

  • fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
  • http/tests/contentextensions/async-xhr-onerror-expected.txt:
  • http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-asynchronous-in-iframe-expected.txt:
  • http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-asynchronous-in-main-frame-expected.txt:
  • http/tests/security/mixedContent/insecure-xhr-in-main-frame-expected.txt:

Rebaseline a few tests now that we provide a more helpful error message when an XHR is failing synchronously.

  • http/wpt/beacon/beacon-quota-expected.txt: Added.
  • http/wpt/beacon/beacon-quota.html: Added.

Add layout test coverage for keepalive Fetch requests quota in the context of sendBeacon().
The second part of the test is still failing because WebCore does not currently know when
ping loads (e.g. beacon loads) complete. This will be addressed via Bug 175443.

6:13 PM Changeset in webkit [220621] by don.olmstead@sony.com
  • 13 edits
    1 move in trunk/Source

[WTF] Move ValueToString into WTF
​https://bugs.webkit.org/show_bug.cgi?id=175469

Reviewed by Sam Weinig.

Source/WebCore:

No new tests. No change in behavior.

  • WebCore.xcodeproj/project.pbxproj:
  • html/HTMLMediaElement.h:

(WTF::ValueToString<WebCore::TextTrackCue::string):
(WebCore::ValueToString<TextTrackCue::string): Deleted.
(WebCore::ValueToString<MediaTime>::string): Deleted.

  • platform/LayoutUnit.h:

(WTF::ValueToString<WebCore::LayoutUnit>::string):
(WebCore::ValueToString<LayoutUnit>::string): Deleted.

  • platform/PODInterval.h:
  • platform/PODIntervalTree.h:
  • platform/PODRedBlackTree.h:
  • platform/graphics/FloatPolygon.h:

(WTF::ValueToString<WebCore::FloatPolygonEdge::string):
(WebCore::ValueToString<FloatPolygonEdge::string): Deleted.

  • rendering/FloatingObjects.h:

(WTF::ValueToString<WebCore::FloatingObject::string):
(WebCore::ValueToString<FloatingObject::string): Deleted.

  • rendering/RenderFlowThread.h:

(WTF::ValueToString<WebCore::RenderRegion::string):
(WebCore::ValueToString<RenderRegion::string): Deleted.

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/text/ValueToString.h: Renamed from Source/WebCore/platform/ValueToString.h.
5:32 PM Changeset in webkit [220620] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

[Bindings] Simplify DOMPromiseProxy now that WTF::Function can return references
​https://bugs.webkit.org/show_bug.cgi?id=175394

Patch by Sam Weinig <​sam@webkit.org> on 2017-08-11
Reviewed by Chris Dumez.

  • bindings/IDLTypes.h:

(WebCore::IDLWrapper::convertToParameterType): Deleted.

Remove no longer used convertToParameterType.

  • bindings/js/DOMPromiseProxy.h:
  • Replace Variant<Value, Exception> with ExceptionOr<Value> / ExceptionOr<void>.
  • Update ResolveCallback to have a return type of IDLType::ParameterType, rather than IDLType::ImplementationType, now that WTF::Function supports references as the return type. This is needed, since the IDLType::ParameterType for an interface T is T&.
  • css/FontFace.cpp:
  • css/FontFace.h:
  • css/FontFaceSet.cpp:
  • css/FontFaceSet.h:

Update resolve callbacks to return a reference rather than a RefPtr, matching
the new signature requirement.

5:07 PM Changeset in webkit [220619] by commit-queue@webkit.org
  • 17 edits
    11 copies
    1 move
    2 deletes in trunk/Source/WebCore

[WebIDL] Replace JSCryptoKeyCustom and JSCryptoAlgorithmBuilder with generated code
​https://bugs.webkit.org/show_bug.cgi?id=175457

Patch by Sam Weinig <​sam@webkit.org> on 2017-08-11
Reviewed by Chris Dumez.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCryptoAlgorithmBuilder.cpp: Removed.
  • bindings/js/JSCryptoAlgorithmBuilder.h: Removed.
  • bindings/js/JSCryptoKeyCustom.cpp: Removed.

Remove JSCryptoAlgorithmBuilder and JSCryptoKeyCustom, add KeyAlgorithm
IDLs and headers.

  • crypto/CryptoKey.cpp:
  • crypto/CryptoKey.h:
  • crypto/CryptoKey.idl:

Replace custom algorithm attribute with a union of the supported key algorithms.

  • crypto/keys/CryptoAesKeyAlgorithm.h: Added.
  • crypto/keys/CryptoAesKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoEcKeyAlgorithm.h: Added.
  • crypto/keys/CryptoEcKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoHmacKeyAlgorithm.h: Added.
  • crypto/keys/CryptoHmacKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoKeyAlgorithm.h: Added.
  • crypto/keys/CryptoKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoRsaHashedKeyAlgorithm.h: Added.
  • crypto/keys/CryptoRsaHashedKeyAlgorithm.idl: Added.
  • crypto/keys/CryptoRsaKeyAlgorithm.h: Added.
  • crypto/keys/CryptoRsaKeyAlgorithm.idl: Added.

Add IDLs and headers fo the supported key algorithms.

  • crypto/keys/CryptoKeyAES.h:
  • crypto/keys/CryptoKeyEC.h:
  • crypto/keys/CryptoKeyHMAC.h:
  • crypto/keys/CryptoKeyRSA.h:
  • crypto/keys/CryptoKeyRaw.h:

Give each of the existing KeyAlgorithm subclasses a dictionary() function
that returns the populated corresponding spec'd dictionary.

4:18 PM Changeset in webkit [220618] by fpizlo@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

JSLexicalEnvironment needs to be in the JSValue gigacage
​https://bugs.webkit.org/show_bug.cgi?id=174922

Reviewed by Michael Saboff.

We can sorta random access the JSLexicalEnvironment. So, we put it in the JSValue gigacage and make
the only random accesses use pointer caging.

We don't need to do anything to normal lexical environment accesses.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnScopedArguments):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):

  • runtime/JSEnvironmentRecord.h:

(JSC::JSEnvironmentRecord::subspaceFor):
(JSC::JSEnvironmentRecord::variables):

4:12 PM Changeset in webkit [220617] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Update TestExpectations for failing media/video-controls tests.
​https://bugs.webkit.org/show_bug.cgi?id=173978

Unreviewed test gardening.

  • platform/mac/TestExpectations:
3:43 PM Changeset in webkit [220616] by Simon Fraser
  • 10 edits in trunk/Source/WebCore

Some RenderSVGResource cleanup
​https://bugs.webkit.org/show_bug.cgi?id=175494

Reviewed by Zalan Bujtas.

Use more initializers. Remove spurious use of bitfields that didn't save any space at all.
0 -> nullptr.

No behavior change.

  • rendering/svg/RenderSVGResourceContainer.cpp:

(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):

  • rendering/svg/RenderSVGResourceContainer.h:
  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient):
(WebCore::RenderSVGResourceGradient::applyResource):

  • rendering/svg/RenderSVGResourceGradient.h:
  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::RenderSVGResourcePattern):

  • rendering/svg/RenderSVGResourcePattern.h:
  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::fillShape):
(WebCore::RenderSVGShape::strokeShape):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::~SVGRenderingContext):
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):

  • rendering/svg/SVGRenderingContext.h:

(WebCore::SVGRenderingContext::SVGRenderingContext):

3:35 PM Changeset in webkit [220615] by timothy_horton@apple.com
  • 5 edits in trunk/Source

Fix the build with modern Clang's -Wexpansion-to-defined
​https://bugs.webkit.org/show_bug.cgi?id=175467
<rdar://problem/33667497>

Reviewed by Simon Fraser.

Source/WebCore:

  • crypto/mac/SerializedCryptoKeyWrapMac.mm:

Source/WTF:

  • wtf/FeatureDefines.h:
  • wtf/Platform.h:

Avoid object-like macros that expand to include defined(), because this
behaves inconsistently between different compilers (though in ways
that don't matter for these particular defines, which aren't used on MSVC),
and Clang has added a warning for it.

Move ENABLE_WEBASSEMBLY to Platform.h since it depends on things that
are defined there and can't be evaluated at time-of-use because of the
aforementioned new rules. Previously, there was a cycle between
ENABLE_WEBASSEMBLY and ENABLE_B3_JIT -- break that so that it just
goes FTL_JIT->B3_JIT->WASM instead.

3:33 PM Changeset in webkit [220614] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Clicking on suggestion hint should apply it, not dismiss
​https://bugs.webkit.org/show_bug.cgi?id=175409

Reviewed by Matt Baker.

Make clicking on the suggestion hint apply the completion, and place the text caret after it.

  • UserInterface/Controllers/CodeMirrorCompletionController.js:

(WI.CodeMirrorCompletionController.prototype._createCompletionHintMarker):

3:21 PM Changeset in webkit [220613] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.0-branch/Source

Versioning.

3:20 PM Changeset in webkit [220612] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.1-branch/Source

Versioning.

2:27 PM Changeset in webkit [220611] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.1.5

Tag Safari-604.1.38.1.5.

2:25 PM Changeset in webkit [220610] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.0.5

Tag Safari-604.1.38.0.5.

2:08 PM Changeset in webkit [220609] by Nikita Vasilyev
  • 15 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: Update the filter icon to match Xcode
​https://bugs.webkit.org/show_bug.cgi?id=175458
<rdar://problem/33838660>

Reviewed by Matt Baker.

  • UserInterface/Images/FilterFieldGlyph.svg:

Half-pixel transform is necessary for a cleaner rasterisation.

  • UserInterface/Views/FilterBar.css:

(.filter-bar > input[type="search"]::-webkit-search-decoration):
(.sidebar > .panel.dom-node-details .details-section.dom-node-event-listeners > .header > .filter):
::-webkit-search-decoration is a flexbox item. Remove vertical-align: bottom,
since it didn't do anything for it.

  • UserInterface/Views/DOMNodeDetailsSidebarPanel.css:
  • UserInterface/Views/FilterBar.js:

(WI.FilterBar):

  • UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WI.CSSStyleDetailsSidebarPanel.prototype.initialLayout):

  • UserInterface/Views/DebuggerSidebarPanel.js:
  • UserInterface/Views/LogContentView.js:

(WI.LogContentView):

  • UserInterface/Views/NetworkSidebarPanel.js:

(WI.NetworkSidebarPanel):

  • UserInterface/Views/RecordingNavigationSidebarPanel.js:

(WI.RecordingNavigationSidebarPanel):

  • UserInterface/Views/ResourceSidebarPanel.js:

(WI.ResourceSidebarPanel):

  • UserInterface/Views/SearchSidebarPanel.js:

(WI.SearchSidebarPanel):

  • UserInterface/Views/StorageSidebarPanel.js:

(WI.StorageSidebarPanel):

  • UserInterface/Views/TimelineRecordingContentView.js:

(WI.TimelineRecordingContentView):

  • Localizations/en.lproj/localizedStrings.js:

Replace placeholder text for all filter fields with "Filter".

1:37 PM Changeset in webkit [220608] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Crash under ServiceWorkerJob::failedWithException.
​https://bugs.webkit.org/show_bug.cgi?id=175488

Reviewed by Tim Horton.

Covered by existing tests.

  • workers/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::failedWithException): jobDidFinish might cause the Job to be deleted, so make it last.

1:36 PM Changeset in webkit [220607] by Ryan Haddad
  • 5 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviewed test gardening. rdar://problem/33831603

  • fast/events/ios/no-touch-events-when-stopping-momentum-scroll-in-mainframe-expected.txt:
  • platform/ios-11/TestExpectations:
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-wk2/fast/dom/elementFromPoint-relative-to-viewport-expected.txt:
1:08 PM Changeset in webkit [220606] by fpizlo@apple.com
  • 7 edits in trunk/Source/JavaScriptCore

DirectArguments should be in the JSValue gigacage
​https://bugs.webkit.org/show_bug.cgi?id=174920

Reviewed by Michael Saboff.

This puts DirectArguments in a new subspace for cells that want to be in the JSValue gigacage. All
indexed accesses to DirectArguments now do caging. get_from_arguments/put_to_arguments are exempted
because they always operate on a DirectArguments that is pointed to directly from the stack, they are
required to use fixed offsets, and you can only store JSValues.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileGetByValOnDirectArguments):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitDirectArgumentsGetByVal):

  • runtime/DirectArguments.h:

(JSC::DirectArguments::subspaceFor):
(JSC::DirectArguments::storage):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
1:04 PM Changeset in webkit [220605] by Jonathan Bedard
  • 2 edits in trunk/Tools

Create mock ITP data in testing to prevent grandfathering
​https://bugs.webkit.org/show_bug.cgi?id=174720

Unreviewed follow-up fix for r220604.

  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaPlatformInitialize): Release resourceLogPlist.

10:30 AM Changeset in webkit [220604] by Jonathan Bedard
  • 5 edits in trunk/Tools

Create mock ITP data in testing to prevent grandfathering
​https://bugs.webkit.org/show_bug.cgi?id=174720
<rdar://problem/33457779>

Reviewed by Brent Fulgham.

We don't need to be triggering grandfathering when each test runner starts. On Mac,
this may launch plugins which can cause layout tests to fail later if the test
runner does not shut-down before the plugins unload.

  • WebKitTestRunner/TestController.h: Add declaration of cocoaPlatformInitialize.
  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaPlatformInitialize): Write the minimum data required to
prevent grandfathering from being triggered.

  • WebKitTestRunner/ios/TestControllerIOS.mm:

(WTR::TestController::platformInitialize): Call cocoaPlatformInitialize.

  • WebKitTestRunner/mac/TestControllerMac.mm:

(WTR::TestController::platformInitialize): Ditto.

10:26 AM Changeset in webkit [220603] by fpizlo@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, add a FIXME.

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::caged):

10:26 AM Changeset in webkit [220602] by Matt Lewis
  • 2 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviwed test gardening. <rdar://problem/33831603>

  • platform/ios-11/TestExpectations:
9:56 AM Changeset in webkit [220601] by weinig@apple.com
  • 10 edits in trunk

WTF::Function does not allow for reference / non-default constructible return types
​https://bugs.webkit.org/show_bug.cgi?id=175244
Source/JavaScriptCore:

Reviewed by Chris Dumez.

  • runtime/ArrayBuffer.cpp:

(JSC::ArrayBufferContents::transferTo):
Call reset(), rather than clear() to avoid the call to destroy() in clear(). The
destroy call needed to be a no-op anyway, since the data is being moved.

Source/WebCore:

Reviewed by Chris Dumez.

  • bindings/js/JSCustomElementInterface.h:

(WebCore::JSCustomElementInterface::invokeCallback):
Update the default value for the addArguments parameter to be an empty lambda, rather than
default initialization, which leads to a null WTF::Function. This allows us to remove support
for calling null WTF::Function. No change in behavior.

Source/WebKit:

Reviewed by Chris Dumez.

  • UIProcess/WebResourceLoadStatisticsStore.h:

Update the default value for the updateCookiePartitioningForDomainsHandler parameter to be an
empty lambda, rather than default initialization, which leads to a null WTF::Function. This allows
us to remove support for calling null WTF::Function. No change in behavior.

Source/WTF:

Reviewed by Chris Dumez.

When Function, then NoncopyableFunction, was templatized to allow non-void return values
in r201493, it maintained the behavior of being callable even if the Function was null.
To accomplish this, when null, the default construction of the return parameter was used.
This means Function can't be used with return types that are not default constructible,
such as reference types and Ref.

This behavior of returning something when null is surprising, as this is not how normal
functions behave, and not very useful. Instead, we now assert that the function is not
null when being called.

  • wtf/Function.h:

(WTF::Function operator(...)):
Instead of allowing a null callable wrapper by returning the default construction of
the return type, assert that the wrapper is there when calling a Function.

Tools:

<rdar://problem/33801582>

Reviewed by Chris Dumez.

  • TestWebKitAPI/Tests/WTF/Function.cpp:

(TestWebKitAPI::TEST):

9:54 AM Changeset in webkit [220600] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Gardening: fix CLoop build.
​https://bugs.webkit.org/show_bug.cgi?id=175446
<rdar://problem/33836545>

Not reviewed.

  • assembler/MacroAssemblerPrinter.cpp:
9:53 AM Changeset in webkit [220599] by jmarcell@apple.com
  • 6 edits
    3 adds in branches/safari-604.1.38.1-branch

Cherry-pick r220551. rdar://problem/33843387

9:53 AM Changeset in webkit [220598] by jmarcell@apple.com
  • 3 edits
    3 deletes in branches/safari-604.1.38.1-branch

Revert r220587. rdar://problem/33843387

9:53 AM Changeset in webkit [220597] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.1-branch

Revert r220588. rdar://problem/33843387

9:47 AM Changeset in webkit [220596] by fpizlo@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

DFG should do caging
​https://bugs.webkit.org/show_bug.cgi?id=174918

Reviewed by Saam Barati.

Adds the appropriate cage() calls to the DFG, including a cageTypedArrayStorage() helper that does
the conditional caging with a watchpoint.

This might be a 1% SunSpider slow-down, but it's not clear.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::cageTypedArrayStorage):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):
(JSC::DFG::SpeculativeJIT::compileCreateRest):
(JSC::DFG::SpeculativeJIT::compileSpread):
(JSC::DFG::SpeculativeJIT::compileNewArrayWithSpread):
(JSC::DFG::SpeculativeJIT::compileArraySlice):
(JSC::DFG::SpeculativeJIT::compileGetButterfly):

  • dfg/DFGSpeculativeJIT.h:
  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

9:39 AM Changeset in webkit [220595] by Konstantin Tokarev
  • 17 edits in trunk

[CMake] Fix broken use of REQUIRED with find modules
​https://bugs.webkit.org/show_bug.cgi?id=175427

Reviewed by Michael Catanzaro.

Module name passed to find_package_handle_standard_args() must exactly
match file name of CMake find module including letter case, e.g. "WebP"
must be used in FindWebP.cmake file. Otherwise find_package() arguments
(REQUIRED, QUIET, version) are not processed correctly.

To continue using old XXX_FOUND variables without case changes porting
to new find_package_handle_standard_args syntax which has FOUND_VAR
parameter. Unfortunately, variable name GTK_UNIX_PRINT_FOUND is not
allowed by find_package_handle_standard_args when package name is
GTKUnixPrint, so it's replaced to GTKUnixPrint_FOUND (default).

  • Source/cmake/FindGTKUnixPrint.cmake:
  • Source/cmake/FindGeoClue2.cmake:
  • Source/cmake/FindHyphen.cmake:
  • Source/cmake/FindLibEpoxy.cmake:
  • Source/cmake/FindLibGBM.cmake:
  • Source/cmake/FindLibsecret.cmake:
  • Source/cmake/FindLibtasn1.cmake:
  • Source/cmake/FindLibxkbcommon.cmake:
  • Source/cmake/FindOpenGL.cmake:
  • Source/cmake/FindOpenGLES2.cmake:
  • Source/cmake/FindOpenWebRTC.cmake:
  • Source/cmake/FindWPEBackend-mesa.cmake:
  • Source/cmake/FindWPEBackend.cmake:
  • Source/cmake/FindWayland.cmake:
  • Source/cmake/FindWebP.cmake:
  • Source/cmake/OptionsGTK.cmake:
9:22 AM Changeset in webkit [220594] by Antti Koivisto
  • 7 edits in trunk/Source/WebCore

Remove RenderQuote collection from RenderView
​https://bugs.webkit.org/show_bug.cgi?id=175479

Reviewed by Andreas Kling.

We can do it well enough without maintaining this pointer structure.

Global updating doesn't work well with future direction for first-letter and similar anyway.
We need to update quote immediately when updating its style.

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::insertedIntoTree):
(WebCore::RenderQuote::willBeRemovedFromTree):

Just tell the view that there are renderers to update.

(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::isOpen const):
(WebCore::RenderQuote::updateRenderer):
(WebCore::RenderQuote::updateRenderers): Deleted.

Update single renderer only. RenderTreeUpdater provides the previous renderer to compute the depth.

  • rendering/RenderQuote.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::registerQuote): Deleted.
(WebCore::RenderView::unregisterQuote): Deleted.
(WebCore::RenderView::updateSpecialRenderers): Deleted.

Remove the quote list.

  • rendering/RenderView.h:
  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::commit):

Ensure that all quotes are updated.

(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement):
(WebCore::RenderTreeUpdater::updateQuotesUpTo):

Traverse render tree to find quotes to update starting from the previous updated quote.

  • style/RenderTreeUpdater.h:
8:48 AM Changeset in webkit [220593] by Ryan Haddad
  • 2 edits
    46 adds in branches/safari-604.1.38.1-branch/LayoutTests

Cherry-pick r220555.

8:44 AM Changeset in webkit [220592] by Yusuke Suzuki
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, build fix for x86 GTK port
​https://bugs.webkit.org/show_bug.cgi?id=175446

Use pushfl/popfl instead of pushfd/popfd.

  • assembler/MacroAssemblerX86Common.cpp:
8:44 AM Changeset in webkit [220591] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebCore

[CMake] Many warning about missing “override” keywords in ANGLE with Clang
​https://bugs.webkit.org/show_bug.cgi?id=175475

Reviewed by Michael Catanzaro.

  • CMakeLists.txt: Add "-Wno-inconsistent-missing-override" to the

compiler flags using for building the ANGLE sources.

8:43 AM Changeset in webkit [220590] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.38.0-branch/Source/WebKit

Cherry-pick r220571. rdar://problem/33829964

8:41 AM Changeset in webkit [220589] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.38.1-branch/Source/WebKit

Cherry-pick r220571. rdar://problem/33829962

8:17 AM Changeset in webkit [220588] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.1-branch

Cherry-pick r220551. rdar://problem/33594320

8:16 AM Changeset in webkit [220587] by jmarcell@apple.com
  • 3 edits
    3 adds in branches/safari-604.1.38.1-branch

Cherry-pick r220463. rdar://problem/33594320

6:46 AM Changeset in webkit [220586] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebCore

[GTK][WPE] Overriden virtual function not marked “override” in ImageBufferDataCairo.h
​https://bugs.webkit.org/show_bug.cgi?id=175476

Reviewed by Carlos Garcia Campos.

  • platform/graphics/cairo/ImageBufferDataCairo.h: Add missing "override" qualifier.
6:25 AM Changeset in webkit [220585] by Adrian Perez de Castro
  • 2 edits in trunk/Source/WebKit

[WPE] Build failure with Clang 4.0.1: no matching conversion for functional-style cast from 'pointer' (aka 'unsigned short *') to 'WTF::String'
​https://bugs.webkit.org/show_bug.cgi?id=175477

Reviewed by Žan Doberšek.

  • Shared/wpe/WebEventFactory.cpp:

(WebKit::singleCharacterStringForKeyEvent): Cast to UChar* to make
compiler choose the correct WTF::String constructor.

5:28 AM Changeset in webkit [220584] by clopez@igalia.com
  • 2 edits in trunk/Source/WebDriver

Fix build warning in WebDriverService.h
​https://bugs.webkit.org/show_bug.cgi?id=166682

Unreviewed build fix.

  • WebDriverService.h: Fixes the warning: class 'Capabilities' was previously declared as a struct [-Wmismatched-tags]
3:06 AM Changeset in webkit [220583] by Carlos Garcia Campos
  • 7 edits in trunk

[Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
​https://bugs.webkit.org/show_bug.cgi?id=175378

Reviewed by Sergio Villar Senin.

Source/WebCore:

Bring back part of the code removed in r206732, to keep a reference to the SoupMessage in the
AuthenticationChallenge since it can be different to the resource message.

  • platform/network/soup/AuthenticationChallenge.h:

(WebCore::AuthenticationChallenge::AuthenticationChallenge): Deleted.
(WebCore::AuthenticationChallenge::authenticationClient const): Deleted.
(WebCore::AuthenticationChallenge::soupAuth const): Deleted.
(WebCore::AuthenticationChallenge::setProposedCredential): Deleted.

  • platform/network/soup/AuthenticationChallengeSoup.cpp:

(WebCore::AuthenticationChallenge::AuthenticationChallenge):
(WebCore::AuthenticationChallenge::platformCompare):

Source/WebKit:

In case of HTTPS resource with a proxy, libsoup uses a tunnel internally, that uses its own SoupMessage during
the proxy authentication. We were ignoring authentication requests for other messages.

  • NetworkProcess/soup/NetworkDataTaskSoup.cpp:

(WebKit::NetworkDataTaskSoup::authenticateCallback): Only return early if the message does't match and it's not
HTTPS resource over a proxy.
(WebKit::NetworkDataTaskSoup::authenticate): Use the soup message from the authentication challenge.
(WebKit::NetworkDataTaskSoup::continueAuthenticate): Ditto.

Tools:

Add two test cases to check proxy authentication.

  • TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:

(Tunnel::Tunnel):
(Tunnel::~Tunnel):
(Tunnel::connect):
(Tunnel::connected):
(serverCallback):
(ProxyAuthenticationTest::ProxyAuthenticationTest):
(ProxyAuthenticationTest::~ProxyAuthenticationTest):
(ProxyAuthenticationTest::proxyServerPortAsString):
(testWebViewAuthenticationProxy):
(testWebViewAuthenticationProxyHTTPS):
(beforeAll):

1:15 AM Changeset in webkit [220582] by calvaris@igalia.com
  • 3 edits
    6 moves
    3 adds
    5 deletes in trunk/Tools

[GStreamer][GTK][WPE] Unify GStreamer JHBuild moduleset for both GTK+ and WPE
​https://bugs.webkit.org/show_bug.cgi?id=175428

Both ports share the GStreamer code as multimedia backend and till
not so long they were using different versions. Now they do use
the same versions and it does not make any sense anymore (and
neither had sense before) to have differences in the modulesets.

In this patch I created a GStreamer moduleset and referenced it
from both GTK+'s and WPE's. GStreamer patches were also moved there.

Reviewed by Žan Doberšek.

  • gstreamer/jhbuild.modules: Added.
  • gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch.
  • gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch.
  • gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch.
  • gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
  • gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Renamed from Tools/gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch.
  • gstreamer/patches/openh264-configure.patch: Renamed from Tools/gtk/patches/openh264-configure.patch.
  • gtk/jhbuild.modules:
  • wpe/jhbuild.modules:
  • wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed.
  • wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed.
  • wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
  • wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
  • wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.

Aug 10, 2017:

11:02 PM Changeset in webkit [220581] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebKit

[Soup] Do not spawn the network process to setup cookie persistent storage
​https://bugs.webkit.org/show_bug.cgi?id=175424

Reviewed by Sergio Villar Senin.

The persistent storage configuration is saved and passed to network process as creation parameters, so we don't
need to spawn the network process to configure it, when it's created eventually it will use the configuration.

  • UIProcess/soup/WebCookieManagerProxySoup.cpp:

(WebKit::WebCookieManagerProxy::setCookiePersistentStorage): Use sendToNetworkingProcess() instead of
endToNetworkingProcessRelaunchingIfNecessary().

11:01 PM Changeset in webkit [220580] by Carlos Garcia Campos
  • 4 edits in trunk/Source/WebKit

[GTK][WPE] Assertion failure in TimerBase inside WebCore::IconRecord::setImageData
​https://bugs.webkit.org/show_bug.cgi?id=173866
<rdar://problem/33122050>

Reviewed by Michael Catanzaro.

IconDatabase creates and destroys IconRecord objects in both database and main thread. If the IconRecord has a
valid icon, its Image could be created in one thread and destroyed in another, something that is not expected to
happen, because Image has a Timer member. Since we have all the data and we are decoding it right after creating
the Image, we don't really need to keep the Image object around, we could simply take a reference of the encoded
data and the decoded native image to be returned by synchronousIconForPageURL().

  • UIProcess/API/glib/IconDatabase.cpp:

(WebKit::IconDatabase::IconRecord::image): Return NativeImagePtr now.
(WebKit::IconDatabase::IconRecord::setImageData): Create a BitmapImage to decode it and keep a reference to the
encoded data and decoded native image.
(WebKit::IconDatabase::IconRecord::snapshot const): Use m_imageData to get the encoded data.
(WebKit::IconDatabase::synchronousIconForPageURL): Return the native image and whether the icon is known or not.
(WebKit::IconDatabase::IconRecord::loadImageFromResource): Deleted.

  • UIProcess/API/glib/IconDatabase.h:
  • UIProcess/API/glib/WebKitFaviconDatabase.cpp:

(getIconSurfaceSynchronously): Use new API.

10:31 PM Changeset in webkit [220579] by mark.lam@apple.com
  • 18 edits in trunk/Source

Make the MASM_PROBE mechanism mandatory for DFG and FTL builds.
​https://bugs.webkit.org/show_bug.cgi?id=175446
<rdar://problem/33836545>

Reviewed by Saam Barati.

Source/JavaScriptCore:

  • assembler/AbstractMacroAssembler.h:
  • assembler/MacroAssembler.cpp:

(JSC::MacroAssembler::probe):

  • assembler/MacroAssembler.h:
  • assembler/MacroAssemblerARM.cpp:

(JSC::MacroAssembler::probe):

  • assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::trustedImm32FromPtr):

  • assembler/MacroAssemblerARM64.cpp:

(JSC::MacroAssembler::probe):

  • assembler/MacroAssemblerARMv7.cpp:

(JSC::MacroAssembler::probe):

  • assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::trustedImm32FromPtr):

  • assembler/MacroAssemblerPrinter.cpp:
  • assembler/MacroAssemblerPrinter.h:
  • assembler/MacroAssemblerX86Common.cpp:
  • assembler/testmasm.cpp:

(JSC::isSpecialGPR):
(JSC::testProbeModifiesProgramCounter):
(JSC::run):

  • b3/B3LowerToAir.cpp:

(JSC::B3::Air::LowerToAir::print):

  • b3/air/AirPrintSpecial.cpp:
  • b3/air/AirPrintSpecial.h:

Source/WTF:

This is needed in order to support ​https://bugs.webkit.org/show_bug.cgi?id=174645.
One consequence of this is that the DFG will now be disabled for the MIPS and
Windows ports. See:

​https://bugs.webkit.org/show_bug.cgi?id=175447
​https://bugs.webkit.org/show_bug.cgi?id=175449

Also, we should only ENABLE_SIGNAL_BASED_VM_TRAPS if the DFG is enabled. It was
never meaningful to use SIGNAL_BASED_VM_TRAPS with the baseline JIT anyway. This
is a mis-configuration error that is now fixed.

  • wtf/Platform.h:
9:47 PM Changeset in webkit [220578] by mitz@apple.com
  • 4 edits in trunk/Source

Restored svn:ignore values that went missing when the project got renamed.

Source/WebKit:

  • WebKit.xcodeproj: Added property svn:ignore.

Source/WebKitLegacy:

  • WebKitLegacy.xcodeproj: Added property svn:ignore.
9:22 PM Changeset in webkit [220577] by mitz@apple.com
  • 6 edits in trunk/Source/WebCore

Fixed building for macOS 10.12 with the macOS 10.13 SDK.

Suppressed the unguarded-availability-new warning around uses of AVSampleBufferAudioRenderer
and AVSampleBufferRenderSynchronizer. Even though the 10.13 SDK declares them as available
starting in that release, they have been available as SPI earlier.

  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setHasAvailableAudioSample):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addAudioRenderer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::removeAudioRenderer):

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(-[WebAVSampleBufferErrorListener beginObservingRenderer:]):
(-[WebAVSampleBufferErrorListener stopObservingRenderer:]):
(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::SourceBufferPrivateAVFObjC::rendererDidReceiveError):
(WebCore::SourceBufferPrivateAVFObjC::flush):

8:37 PM Changeset in webkit [220576] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.38.1-branch/Source/WebKit

Cherry-pick r220505. rdar://problem/33829962

8:06 PM Changeset in webkit [220575] by commit-queue@webkit.org
  • 1 edit
    4 adds in trunk/Source/WebInspectorUI

Web Inspector: Add three.js in preparation for layer visualization.
​https://bugs.webkit.org/show_bug.cgi?id=174798

Patch by Ross Kirsling <Ross Kirsling> on 2017-08-10
Reviewed by Brian Burg.

  • UserInterface/External/three.js/LICENSE: Added.
  • UserInterface/External/three.js/OrbitControls.js: Added.
  • UserInterface/External/three.js/three.js: Added.
7:59 PM Changeset in webkit [220574] by beidson@apple.com
  • 10 edits
    7 moves in trunk/Source

Rename the source files for the WTF persistent coders.
​https://bugs.webkit.org/show_bug.cgi?id=175441

Reviewed by Tim Horton.

Source/WebCore:

  • platform/network/NetworkLoadMetrics.h:

Source/WebKit:

  • NetworkProcess/cache/NetworkCacheCoders.h:
  • NetworkProcess/cache/NetworkCacheKey.cpp:
  • NetworkProcess/cache/NetworkCacheKey.h:
  • UIProcess/API/APIContentRuleListStore.cpp:

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/persistence/PersistentCoder.h: Renamed from Source/WTF/wtf/persistence/Coder.h.
  • wtf/persistence/PersistentCoders.cpp: Renamed from Source/WTF/wtf/persistence/Coders.cpp.
  • wtf/persistence/PersistentCoders.h: Renamed from Source/WTF/wtf/persistence/Coders.h.
  • wtf/persistence/PersistentDecoder.cpp: Renamed from Source/WTF/wtf/persistence/Decoder.cpp.
  • wtf/persistence/PersistentDecoder.h: Renamed from Source/WTF/wtf/persistence/Decoder.h.
  • wtf/persistence/PersistentEncoder.cpp: Renamed from Source/WTF/wtf/persistence/Encoder.cpp.
  • wtf/persistence/PersistentEncoder.h: Renamed from Source/WTF/wtf/persistence/Encoder.h.
7:58 PM Changeset in webkit [220573] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.38.0-branch/Source/WebKit

Cherry-pick r220505. rdar://problem/33829964

7:17 PM Changeset in webkit [220572] by don.olmstead@sony.com
  • 2 edits in trunk/Tools

Unreviewed, adding Ross Kirsling to contributors.json\n\n* Scripts/webkitpy/common/config/contributors.json:\n

6:47 PM Changeset in webkit [220571] by wilander@apple.com
  • 2 edits in trunk/Source/WebKit

Resource Load Statistics: Increase grandfathering time to 7 days
​https://bugs.webkit.org/show_bug.cgi?id=175414
<rdar://problem/33818046>

Reviewed by Brent Fulgham.

  • UIProcess/WebResourceLoadStatisticsStore.h:
6:41 PM Changeset in webkit [220570] by n_wang@apple.com
  • 2 edits in trunk/LayoutTests

Layout test accessibility/press-target-uses-text-descendant-node.html is flaky.
​https://bugs.webkit.org/show_bug.cgi?id=175272
<rdar://problem/33756962>

Since accessibilityPress is async, we shouldn't rely on the timeout.

Reviewed by Chris Fleizach.

  • accessibility/press-target-uses-text-descendant-node.html:
5:41 PM Changeset in webkit [220569] by Yusuke Suzuki
  • 3 edits in trunk/Source/WebCore

Make ThreadGlobalData RefCounted for web thread
​https://bugs.webkit.org/show_bug.cgi?id=175439

Reviewed by Mark Lam.

When the web thread is enabled, we share ThreadGlobalData between the web thread and the main thread.
The problem happens when the main thread is dying. It could start deallocating TLS and the web
thread may see the destructed ThreadGlobalData.

Even though, the current implementation is safe because the main thread do not perform TLS deallocation
in the Darwin environment. But this is not true in Windows. And we should not rely on this condition
that depends on the platforms.

In this patch, we make ThreadGlobalData ThreadSafeRefCounted. This type verbosely describes that
ThreadGlobalData could be shared between threads when the web thread enabled. And make the life time
management simple instead of relying on the platform dependent TLS implementation.

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::setWebCoreThreadData):
(WebCore::threadGlobalData):

  • platform/ThreadGlobalData.h:

(WebCore::ThreadGlobalData::cachedResourceRequestInitiators): Deleted.
(WebCore::ThreadGlobalData::eventNames): Deleted.
(WebCore::ThreadGlobalData::threadTimers): Deleted.
(WebCore::ThreadGlobalData::qualifiedNameCache): Deleted.
(WebCore::ThreadGlobalData::cachedConverterICU): Deleted.
(WebCore::ThreadGlobalData::cachedConverterTEC): Deleted.

5:41 PM Changeset in webkit [220568] by wilander@apple.com
  • 2 edits in trunk/Source/WebKit

Resource Load Statistics: Add significant figures to telemetry calls
​https://bugs.webkit.org/show_bug.cgi?id=175442
<rdar://problem/33834834>

Reviewed by Brent Fulgham.

With this change, logged values are allowed to have 3 significant figures
as opposed to today's 0 which is wrong.

  • UIProcess/WebResourceLoadStatisticsTelemetry.cpp:

(WebKit::submitTopList):
(WebKit::WebResourceLoadStatisticsTelemetry::calculateAndSubmit):

5:36 PM Changeset in webkit [220567] by Yusuke Suzuki
  • 4 edits in trunk

Unreviewed, attempt to fix build failure with VC2017

Source/WTF:

  • wtf/PriorityQueue.h:

Tools:

  • TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:

(TEST):

5:36 PM Changeset in webkit [220566] by Yusuke Suzuki
  • 3 edits in trunk/Source/WebCore

[JSC] Use @toNumber in builtins
​https://bugs.webkit.org/show_bug.cgi?id=172692

Reviewed by Sam Weinig.

Use @toNumber bytecode intrinsic. It emits op_to_number, which efficiently converts
a given argument to a number.

  • Modules/streams/ReadableByteStreamInternals.js:

(privateInitializeReadableByteStreamController):
(readableByteStreamControllerRespond):

  • Modules/streams/StreamInternals.js:

(validateAndNormalizeQueuingStrategy):
(enqueueValueWithSize):

5:29 PM Changeset in webkit [220565] by Yusuke Suzuki
  • 2 edits in trunk/Tools

Unreviewed, suppress warnings on GCC

  • TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:

(TestWebKitAPI::CheckedArithmeticTester::run):

5:23 PM Changeset in webkit [220564] by Matt Lewis
  • 2 edits in branches/safari-604.1.38.0-branch/LayoutTests

Unreviwed test gardening. <rdar://problem/33831603>

  • platform/ios-11/TestExpectations:
4:57 PM Changeset in webkit [220563] by mitz@apple.com
  • 2 edits in trunk/Tools

[Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
​https://bugs.webkit.org/show_bug.cgi?id=173223

Reviewed by Tim Horton.

The rebuilds were happening due to a difference in the compiler options that the IDE and
xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
xcodebuild pass that option, too, set INDEX_ENABLE_DATA_STORE to YES and
INDEX_DATA_STORE_DIR to the Index Datastore path specified in Xcode Locations preferences >
Advanced when a Custom Absolute path is selected.

  • Scripts/webkitdirs.pm:

(determineBaseProductDir):

4:42 PM Changeset in webkit [220562] by Yusuke Suzuki
  • 7 edits
    1 copy in trunk

Run more WTF tests
​https://bugs.webkit.org/show_bug.cgi?id=174970

Reviewed by Michael Catanzaro.

Source/WTF:

CHAR_BIT is not defined.

  • wtf/LEBDecoder.h:

Tools:

Some of WTF tests are not executed in non Apple ports while they are generic ones.
This patch adds these tests to non-Apple port TestWebKitAPI.
Currently, we do not add Signals.cpp since it depends on signal functionality.

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:

(isHigherPriority):
(TEST):

  • TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.

(TEST):

  • TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:

(TEST):

4:21 PM Changeset in webkit [220561] by Ryan Haddad
  • 3 edits
    2 copies
    3 adds in branches/safari-604.1.38.1-branch/LayoutTests

Unreviwed test gardening. rdar://problem/33789505

  • imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_empty.https-expected.txt:
  • imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_empty.https-expected.txt:
  • platform/mac-highsierra/http/tests/cookies/js-get-and-set-http-only-cookie-expected.txt: Added.
  • platform/mac-highsierra/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_empty.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_empty.https-expected.txt.
  • platform/mac-highsierra/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_empty.https-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_empty.https-expected.txt.
4:20 PM Changeset in webkit [220560] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.1-branch/Source

Versioning.

4:18 PM Changeset in webkit [220559] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.0-branch/Source

Versioning.

4:16 PM Changeset in webkit [220558] by jmarcell@apple.com
  • 7 edits in branches/safari-604-branch/Source

Versioning.

4:14 PM Changeset in webkit [220557] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.2.2

Tag Safari-604.2.2.

4:00 PM Changeset in webkit [220556] by mark.lam@apple.com
  • 15 edits in trunk/Source

Apply the UNLIKELY macro to some unlikely things.
​https://bugs.webkit.org/show_bug.cgi?id=175440
<rdar://problem/33834767>

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::jettison):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleVarargsCall):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::disassemble):

  • dfg/DFGJITFinalizer.cpp:

(JSC::DFG::JITFinalizer::finalizeCommon):

  • dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::compileOSRExit):

  • dfg/DFGPlan.cpp:

(JSC::DFG::Plan::Plan):

  • ftl/FTLJITFinalizer.cpp:

(JSC::FTL::JITFinalizer::finalizeCommon):

  • ftl/FTLLink.cpp:

(JSC::FTL::link):

  • ftl/FTLOSRExitCompiler.cpp:

(JSC::FTL::compileStub):

  • jit/JIT.cpp:

(JSC::JIT::privateCompileMainPass):
(JSC::JIT::compileWithoutLinking):
(JSC::JIT::link):

  • runtime/ScriptExecutable.cpp:

(JSC::ScriptExecutable::installCode):

  • runtime/VM.cpp:

(JSC::VM::VM):

Source/WebKit:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::getBytecodeProfile):

3:57 PM Changeset in webkit [220555] by Ryan Haddad
  • 2 edits
    46 adds in trunk/LayoutTests

Unreviewed test gardening for High Sierra.

  • platform/mac-highsierra/css1/basic/inheritance-expected.txt: Added.
  • platform/mac-highsierra/css2.1/t0602-c13-inh-underlin-00-e-expected.txt: Added.
  • platform/mac-highsierra/css2.1/t0805-c5522-brdr-02-e-expected.txt: Added.
  • platform/mac-highsierra/css3/selectors3/html/css3-modsel-18-expected.txt: Added.
  • platform/mac-highsierra/css3/selectors3/xhtml/css3-modsel-18-expected.txt: Added.
  • platform/mac-highsierra/css3/selectors3/xml/css3-modsel-18-expected.txt: Added.
  • platform/mac-highsierra/fast/block/basic/001-expected.txt: Added.
  • platform/mac-highsierra/fast/css-generated-content/initial-letter-basic-expected.txt: Added.
  • platform/mac-highsierra/fast/css-generated-content/initial-letter-border-padding-expected.txt: Added.
  • platform/mac-highsierra/fast/css-generated-content/initial-letter-raised-expected.txt: Added.
  • platform/mac-highsierra/fast/css-generated-content/initial-letter-sunken-expected.txt: Added.
  • platform/mac-highsierra/fast/css/css3-nth-child-expected.txt: Added.
  • platform/mac-highsierra/fast/css/text-overflow-input-expected.txt: Added.
  • platform/mac-highsierra/fast/dom/34176-expected.txt: Added.
  • platform/mac-highsierra/fast/dom/clone-node-dynamic-style-expected.txt: Added.
  • platform/mac-highsierra/fast/forms/basic-inputs-expected.txt: Added.
  • platform/mac-highsierra/fast/forms/input-value-expected.txt: Added.
  • platform/mac-highsierra/fast/forms/plaintext-mode-2-expected.txt: Added.
  • platform/mac-highsierra/fast/invalid/003-expected.txt: Added.
  • platform/mac-highsierra/fast/invalid/004-expected.txt: Added.
  • platform/mac-highsierra/fast/invalid/nestedh3s-expected.txt: Added.
  • platform/mac-highsierra/fast/selectors/018-expected.txt: Added.
  • platform/mac-highsierra/fast/table/frame-and-rules-expected.txt: Added.
  • platform/mac-highsierra/fast/text/atsui-multiple-renderers-expected.txt: Added.
  • platform/mac-highsierra/fast/text/bidi-embedding-pop-and-push-same-expected.txt: Added.
  • platform/mac-highsierra/fast/text/font-weights-expected.txt: Added.
  • platform/mac-highsierra/fast/text/font-weights-zh-expected.txt: Added.
  • platform/mac-highsierra/fast/text/indic-expected.txt: Added.
  • platform/mac-highsierra/fast/text/international/complex-character-based-fallback-expected.txt:
  • platform/mac-highsierra/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
  • platform/mac-highsierra/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
  • platform/mac-highsierra/svg/batik/text/textStyles-expected.txt: Added.
  • platform/mac-highsierra/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt: Added.
  • platform/mac-highsierra/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.
3:44 PM Changeset in webkit [220554] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.1.4

Tag Safari-604.1.38.1.4.

3:42 PM Changeset in webkit [220553] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Turn on support for Beacon API by default in STP
​https://bugs.webkit.org/show_bug.cgi?id=175445
<rdar://problem/33836379>

Reviewed by Youenn Fablet.

  • Shared/WebPreferencesDefinitions.h:
3:39 PM Changeset in webkit [220552] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.0.4

Tag Safari-604.1.38.0.4.

3:15 PM Changeset in webkit [220551] by n_wang@apple.com
  • 6 edits
    3 adds in trunk

AX: crash at WebCore::AccessibilityObject::supportsARIALiveRegion() const + 24
​https://bugs.webkit.org/show_bug.cgi?id=175340
<rdar://problem/33782159>

Reviewed by Chris Fleizach.

Source/WebCore:

The issue here is that we manualy set the parent object of the AccessibilitySVGRoot object
and there are chances that the parent doesn't detach it properly during the parent's destroying
process. Accessing the stale parent object will lead to a crash.
Fixed this by making the parent object a weak pointer so we don't access an invalid memory.

Test: accessibility/add-children-pseudo-element.html

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::AccessibilityRenderObject):

  • accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::createWeakPtr):

  • accessibility/AccessibilitySVGRoot.cpp:

(WebCore::AccessibilitySVGRoot::AccessibilitySVGRoot):
(WebCore::AccessibilitySVGRoot::setParent):
(WebCore::AccessibilitySVGRoot::parentObject const):

  • accessibility/AccessibilitySVGRoot.h:

LayoutTests:

  • accessibility/add-children-pseudo-element-expected.txt: Added.
  • accessibility/add-children-pseudo-element.html: Added.
  • accessibility/resources/svg-circle.svg: Added.
3:08 PM Changeset in webkit [220550] by Ryan Haddad
  • 2 edits in trunk/Source/WebKit

Fix iOS simulator build after change "[WTF] Move TextStream into WTF"
​https://bugs.webkit.org/show_bug.cgi?id=175211

Patch by Ross Kirsling <Ross Kirsling> on 2017-08-10
Reviewed by Myles C. Maxfield.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _scrollByContentOffset:]):
(-[WKWebView _navigationGestureDidBegin]):

2:51 PM Changeset in webkit [220549] by Chris Dumez
  • 19 edits
    4 adds in trunk

[Beacon] Do connect-src CSP check on redirects as well
​https://bugs.webkit.org/show_bug.cgi?id=175410
<rdar://problem/33815470>

Reviewed by Youenn Fablet.

Source/WebCore:

Pass ContentSecurityPolicy object to createPingHandle so that we can send
enough data to the NetworkProcess so do CSP checks for Ping loads such
as Beacon. For the IPC, we serialize the ContentSecurityPolicy's response
headers. Those headers are now cached in ContentSecurityPolicy for
performance reasons. CSP headers are rarely updated in practice but
sendBeacon() may get called repeatedly for a given document.

Tests: http/wpt/beacon/connect-src-beacon-redirect-allowed.sub.html

http/wpt/beacon/connect-src-beacon-redirect-blocked.sub.html

  • loader/LoaderStrategy.h:
  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::startPingLoad):

  • loader/PingLoader.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::responseHeaders const):
(WebCore::ContentSecurityPolicy::didReceiveHeader):

  • page/csp/ContentSecurityPolicy.h:
  • page/csp/ContentSecurityPolicyResponseHeaders.h:

(WebCore::ContentSecurityPolicyResponseHeaders::encode const):
(WebCore::ContentSecurityPolicyResponseHeaders::decode):

Source/WebKit:

Pass CSP Response headers to the NetworkProcess via NetworkResourceLoadParameters
when doing a PingLoad. This allows PingLoad to do CSP checks (in particular
connect-src ones) in case the ping load gets redirected. Those checks need to be
done on the NetworkProcess side at this point because there is no guarantee the
WebContent process is still around.

To do the CSP checks, PingLoad lazily reconstructs a ContentSecurityPolicy object
from the CSP response headers.

  • NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):

  • NetworkProcess/NetworkResourceLoadParameters.h:
  • NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::contentSecurityPolicy):

  • NetworkProcess/PingLoad.h:
  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::createPingHandle):

  • WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

Update createPingHandle() to take in ContentSecurityPolicy
object in but no behavior change for WK1.

  • WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::createPingHandle):

  • WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

Add layout test coverage.

  • http/wpt/beacon/connect-src-beacon-redirect-allowed.sub-expected.txt: Added.
  • http/wpt/beacon/connect-src-beacon-redirect-allowed.sub.html: Added.
  • http/wpt/beacon/connect-src-beacon-redirect-blocked.sub-expected.txt: Added.
  • http/wpt/beacon/connect-src-beacon-redirect-blocked.sub.html: Added.
2:19 PM Changeset in webkit [220548] by Yusuke Suzuki
  • 7 edits in trunk/Source

[WTF] ThreadSpecific should not introduce additional indirection
​https://bugs.webkit.org/show_bug.cgi?id=175187

Reviewed by Mark Lam.

Source/JavaScriptCore:

  • runtime/Identifier.cpp:

Source/WebCore:

We drop ThreadSpecific::replace feature which is only used by
Web thread. Instead, we use ThreadSpecific<std::unique_ptr<T>> here.

While this std::unique_ptr<T> shares one instance between main thread
and web thread, this is the same to the current implementation. It is
safe because the web thread never finishes.

And for non-web thread implementation, we just use ThreadSpecific<T>,
since it is the most efficient.

  • platform/ThreadGlobalData.cpp:

(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::setWebCoreThreadData):
(WebCore::threadGlobalData):
We also drop StringImpl::empty() call since it is not necessary now:
StringImpl::empty data is statically initialized by using constexpr.

  • platform/ThreadGlobalData.h:

We make it FAST_ALLOCATED since it is previously allocated by fast malloc
in ThreadSpecific.

Source/WTF:

ThreadSpecific sets Data* to the TLS. And Data holds T*, which
is fast allocated actual data. But ideally, we should store T
instance directly in Data instead of introducing an additional
indirection.

This patch adds storage in Data in order to embed the instance of T. The constructor
for Data will invoke the constructor for T on the embedded storage. We also drop
ThreadSpecific::replace which is only used by the web thread to set its thread specific
ThreadGlobalData to the one shared from the main thread. The existing implementation
relies on the main thread and the web thread never exiting in order for the shared
ThreadGlobalData to stay alive. We can achieve the same semantics by using a
ThreadSpecific<std::unique_ptr<T>> to hold the ThreadGlobalData instance instead.

  • wtf/ThreadSpecific.h:

(WTF::ThreadSpecific::Data::construct):
(WTF::ThreadSpecific::Data::Data):
We make it fast allocated since we previously allocated ThreadSpecific T data by fastMalloc.

(WTF::ThreadSpecific::Data::~Data):
(WTF::ThreadSpecific::Data::storagePointer const):
(WTF::canBeGCThread>::get):
We also drop RELEASE_ASSERT from ::get(). We already inserted this assert to setAndConstruct(),
so when creating the member to this TLS, we execute this release assert. So it is
not necessary to execute this assertion every time we get data from this TLS.

(WTF::canBeGCThread>::set):
(WTF::canBeGCThread>::destroy):
(WTF::canBeGCThread>::setAndConstruct):
(WTF::T):
(WTF::canBeGCThread>::replace): Deleted.

2:06 PM Changeset in webkit [220547] by jmarcell@apple.com
  • 12 edits in tags/Safari-604.2.1.1

Cherry-pick r220473. rdar://problem/33834103

2:05 PM Changeset in webkit [220546] by jmarcell@apple.com
  • 7 edits in tags/Safari-604.2.1.1/Source

Versioning.

1:50 PM Changeset in webkit [220545] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.2.1.1

Tag Safari-604.2.1.1.

1:49 PM Changeset in webkit [220544] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Remove obsolete link from webkit-queues status page
​https://bugs.webkit.org/show_bug.cgi?id=175337

Patch by obinna obike <​oobike@apple.com> on 2017-08-10
Reviewed by Aakash Jain.

  • QueueStatusServer/templates/recentstatus.html:

Removed the link to the ews-watcher server.

1:47 PM Changeset in webkit [220543] by Jonathan Bedard
  • 2 edits in trunk/LayoutTests

Mark webgl/webgl-box-shadow.html and webgl/webgl-border.html as failing for ios-device.
​https://bugs.webkit.org/show_bug.cgi?id=175437

Unreviewed test gardening.

  • platform/ios-device/TestExpectations:
1:34 PM Changeset in webkit [220542] by BJ Burg
  • 5 edits
    1 add in trunk

WKPreferences should conform to NSCopying
​https://bugs.webkit.org/show_bug.cgi?id=175303
<rdar://problem/33764939>

Reviewed by Dan Bernstein.

Source/WebKit:

  • UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Add conformance in the private header, as there is not consensus that this
needs to be API.

  • UIProcess/API/Cocoa/WKPreferences.mm:

(-[WKPreferences copyWithZone:]):
Copy the wrapped WebPreferences instance and return its wrapper.

Tools:

Add unit test to make sure a WKPreference and its copy are
not aliased to each other or affect each other's properties.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Added.

(TEST):

12:39 PM Changeset in webkit [220541] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WTF

Fix a silly typo in Compiler.h

  • wtf/Compiler.h:

Heature, indeed.

12:31 PM Changeset in webkit [220540] by Michael Catanzaro
  • 6 edits in trunk

REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
​https://bugs.webkit.org/show_bug.cgi?id=175426

Reviewed by Carlos Alberto Lopez Perez.

.:

  • Source/cmake/FindGeoClue2.cmake:

Source/WebCore:

Also stop using GEOCLUE_LIBRARIES and GEOCLUE_INCLUDE_DIRS, since they are empty. Apparently
we have not actually been using the client library at all this whole time, only the D-Bus
interface.

  • PlatformGTK.cmake:

Source/WebKit:

  • PlatformGTK.cmake:
12:28 PM Changeset in webkit [220539] by beidson@apple.com
  • 14 edits
    2 copies
    14 adds in trunk

Add ServiceWorkerJob.
​https://bugs.webkit.org/show_bug.cgi?id=175241

Reviewed by Tim Horton.

Source/WebCore:

Test: http/tests/workers/service/basic-register.html

This patch does a few things:

  • Adds the spec concept of a ServiceWorkerJob (in the WebProcess, at least)
  • Adds a ServiceWorkerProvider interface for WebKit to implement
  • Actually creates a job for service worker registration and "schedules" it, though it always immediately errors out the promise.

Actually queuing jobs and executing asynchronously is coming up soon.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::sessionID const):

  • dom/Document.h:
  • workers/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::~ServiceWorkerContainer):
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::scheduleJob):
(WebCore::ServiceWorkerContainer::jobDidFinish):

  • workers/ServiceWorkerContainer.h:
  • workers/ServiceWorkerJob.cpp: Added.

(WebCore::ServiceWorkerJob::ServiceWorkerJob):
(WebCore::ServiceWorkerJob::~ServiceWorkerJob):
(WebCore::ServiceWorkerJob::failedWithException):

  • workers/ServiceWorkerJob.h: Copied from Source/WebCore/workers/ServiceWorkerContainer.h.

(WebCore::ServiceWorkerJob::createRegisterJob):
(WebCore::ServiceWorkerJob::identifier const):

  • workers/ServiceWorkerJobClient.h: Added.

(WebCore::ServiceWorkerJobClient::~ServiceWorkerJobClient):

  • workers/ServiceWorkerProvider.cpp: Added.

(WebCore::ServiceWorkerProvider::singleton):
(WebCore::ServiceWorkerProvider::setSharedProvider):

  • workers/ServiceWorkerProvider.h: Added.
  • workers/ServiceWorkerRegistrationOptions.h: Copied from Source/WebCore/workers/ServiceWorkerContainer.h.
  • workers/ServiceWorkerRegistrationParameters.cpp: Added.
  • workers/ServiceWorkerRegistrationParameters.h: Added.

Source/WebKit:

  • CMakeLists.txt:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/Storage/WebServiceWorkerProvider.cpp: Added.

(WebKit::WebServiceWorkerProvider::singleton):
(WebKit::WebServiceWorkerProvider::WebServiceWorkerProvider):
(WebKit::WebServiceWorkerProvider::scheduleJob):

  • WebProcess/Storage/WebServiceWorkerProvider.h: Added.
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

LayoutTests:

Verifies that the "serviceWorker.register()" job we currently schedule fails as expected.

  • http/tests/workers/service/basic-register-expected.txt: Added.
  • http/tests/workers/service/basic-register.html: Added.
  • http/tests/workers/service/resources/basic-register.js: Added.
  • http/tests/workers/service/resources/empty-worker.js: Added.
  • platform/mac-wk1/TestExpectations:
  • platform/win/TestExpectations:
12:05 PM Changeset in webkit [220538] by timothy_horton@apple.com
  • 10 edits in trunk

Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
​https://bugs.webkit.org/show_bug.cgi?id=175436
<rdar://problem/33667497>

Reviewed by Simon Fraser.

Source/JavaScriptCore:

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::Interpreter):

Source/WebCore:

  • platform/audio/cocoa/MediaSessionManagerCocoa.cpp:

(PlatformMediaSessionManager::updateSessionState):

  • platform/graphics/cocoa/WebCoreDecompressionSession.mm:

(WebCore::WebCoreDecompressionSession::handleDecompressionOutput):

Source/WebKit:

  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp:

(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::topPrivatelyControlledDomainsWithWebsiteData):

Tools:

  • TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:

(TestWebKitAPI::TEST_F):

11:57 AM Changeset in webkit [220537] by Lucas Forschler
  • 2 edits in trunk/Tools

Fix duplicated code from r220534.

Unreviewed cleanup.

  • Scripts/bisect-builds:
11:47 AM Changeset in webkit [220536] by jiewen_tan@apple.com
  • 4 edits
    1 add in trunk/Tools

[WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
​https://bugs.webkit.org/show_bug.cgi?id=175344
<rdar://problem/28507240>

Reviewed by Alexey Proskuryakov.

Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
Finally enable the existing tests for iOS.

  • TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
  • TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:
11:27 AM Changeset in webkit [220535] by commit-queue@webkit.org
  • 3 edits
    3 deletes in trunk

Unreviewed, rolling out r220463.
​https://bugs.webkit.org/show_bug.cgi?id=175435

unaccepted fix (Requested by n_wang on #webkit).

Reverted changeset:

"AX: crash at
WebCore::AccessibilityObject::supportsARIALiveRegion() const +
24"
​https://bugs.webkit.org/show_bug.cgi?id=175340
​http://trac.webkit.org/changeset/220463

11:22 AM Changeset in webkit [220534] by Lucas Forschler
  • 1 edit
    1 add in trunk/Tools

Write a tool to bisect WebKit builds
​https://bugs.webkit.org/show_bug.cgi?id=174596

Reviewed by Dean Johnson and Kocsen Chung.

  • Scripts/bisect-builds: Added.

(bisect_builds): main bisection algorithm
(download_archive):download an archive from S3 using existing tools
(extract_archive):extract an archive using existing tools
(find_le):Find rightmost value less than or equal to x
(find_ge):Find leftmost item greater than or equal to x
(get_api_url):generate url for the rest api/database
(get_indices_from_revisions):convert revisions to list indexes for bisection
(get_sorted_revisions):retrieve sorted revision list
(get_s3_location_for_revision):calculate the S3 archive storage location
(parse_args):parse command line arguments
(pick_next_build):compute the next build to bisect
(prompt_did_reproduce):prompt user for direction for bisection
(set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
(test_archive):Platform specific logic to test downloaded archive
(minified_platforms):return a list of minified platforms in the database
(unminified_platforms):return a list of full platforms in the database
(is_supported_platform):check if platform is supported
(validate_options):validate command line options
(main):

11:17 AM Changeset in webkit [220533] by Lucas Forschler
  • 1 edit
    1 delete in trunk/Tools

Remove bisect-builds script.
​https://bugs.webkit.org/show_bug.cgi?id=175433

Reviewed by Aakash Jain.

  • Scripts/bisect-builds: Removed.
10:04 AM Changeset in webkit [220532] by Michael Catanzaro
  • 21 edits
    5 deletes in trunk

Remove ENABLE_GAMEPAD_DEPRECATED
​https://bugs.webkit.org/show_bug.cgi?id=175361

Reviewed by Carlos Garcia Campos.

.:

  • Source/cmake/FindGUdev.cmake: Removed.
  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • PlatformGTK.cmake:
  • PlatformWPE.cmake:
  • platform/Linux.cmake: Removed.
  • platform/gamepad/deprecated/Gamepads.h: Removed.
  • platform/gamepad/glib/GamepadsGlib.cpp: Removed.
  • platform/gamepad/linux/GamepadDeviceLinux.cpp: Removed.
  • platform/gamepad/linux/GamepadDeviceLinux.h: Removed.

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
9:59 AM Changeset in webkit [220531] by mmaxfield@apple.com
  • 3 edits in trunk/Source/WebCore

Addressing post-review comments after r219173.
​https://bugs.webkit.org/show_bug.cgi?id=174149

Unreviewed.

  • css/CSSFontStyleValue.h:
  • editing/EditingStyle.cpp:

(WebCore::identifierForStyleProperty):

9:53 AM Changeset in webkit [220530] by Ryan Haddad
  • 4 edits in trunk/LayoutTests

Update TestExpectations for imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors.html.
​https://bugs.webkit.org/show_bug.cgi?id=170698

Unreviewed test gardening.

  • TestExpectations: Skip test on debug because it times out on every run.
  • platform/ios/TestExpectations: Mark as flaky on Release.
  • platform/mac/TestExpectations: Ditto.
9:33 AM Changeset in webkit [220529] by clopez@igalia.com
  • 4 edits in trunk

REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
​https://bugs.webkit.org/show_bug.cgi?id=175426

Reviewed by Carlos Garcia Campos.

.:

Fix the pkg-config file name.
We really require geoclue-2.0 and not libgeoclue-2.0.

  • Source/cmake/FindGeoClue2.cmake:

Tools:

  • gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.
8:44 AM Changeset in webkit [220528] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Try to fix windows build.

  • style/StyleUpdate.h:

(WebCore::Style::TextUpdate::TextUpdate):

5:25 AM Changeset in webkit [220527] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebKit

[GTK] Don't use --whole-archive linking flags for the WebKit2 target libraries
​https://bugs.webkit.org/show_bug.cgi?id=175416

Reviewed by Carlos Garcia Campos.

  • PlatformGTK.cmake: Drop the ADD_WHOLE_ARCHIVE_TO_LIBRARIES instruction

for the WebKit2 target. This unnecessarily bundles complete archive
files both into the main .so library as well as single executables that
are linked against the WebKit2 target.

5:01 AM Changeset in webkit [220526] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Add Ms2ger as contributor.
​https://bugs.webkit.org/show_bug.cgi?id=175325

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-10
Reviewed by Carlos Alberto Lopez Perez.

  • Scripts/webkitpy/common/config/contributors.json:
4:02 AM Changeset in webkit [220525] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[GTK] Crashes in WebCore::PasteboardHelper::fillSelectionData when source file of drag is unavailable
​https://bugs.webkit.org/show_bug.cgi?id=174161

Reviewed by Xabier Rodriguez-Calvar.

In r219385 we changed the early return in fillSelectionData() to check the selection data length instead of the
data pointer. However, the gtk_selection_data_get_length() can return -1, so we need to check also if the value
less than 0. The case of setting an empty string could be valid depending on the target type, so it's better to
return early only when data lenght is less than 0 and handle the 0 length case in each target.

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::PasteboardHelper::fillSelectionData):

3:44 AM Changeset in webkit [220524] by magomez@igalia.com
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Update expectations of several tests failing at r220516.

  • platform/gtk/TestExpectations:
3:20 AM Changeset in webkit [220523] by Antti Koivisto
  • 9 edits in trunk/Source/WebCore

Text renderer updates should be done by RenderTreeUpdater
​https://bugs.webkit.org/show_bug.cgi?id=175417

Reviewed by Andreas Kling.

All render tree mutations should be done by RenderTreeUpdater. Currently
Text::updateRendererAfterContentChange calls RenderText::setTextWithOffset directly.

  • dom/Document.cpp:

(WebCore::Document::updateTextRenderer):

Add range argument.

  • dom/Document.h:
  • dom/Text.cpp:

(WebCore::Text::updateRendererAfterContentChange):

Remove call to setTextWithOffset and pass the range to updateTextRenderer

  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::updateTextRenderer):

Call setTextWithOffset here.

  • style/RenderTreeUpdater.h:
  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveComposedTree):

  • style/StyleUpdate.cpp:

(WebCore::Style::Update::textUpdate const):
(WebCore::Style::Update::addText):

Add TextUpdate struct similar to ElementUpdate to pass the range to the RenderTreeUpdater.

  • style/StyleUpdate.h:
1:37 AM Changeset in webkit [220522] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed GTK+ build fix for ENABLE_GLES2=ON.

  • platform/graphics/texmap/TextureMapperGLHeaders.h:

Define various GL constants that are not provided in GLES2 headers
but are only leveraged in OpenGL calls if at runtime the underlying
OpenGL is GLES2-capable.

12:39 AM Changeset in webkit [220521] by zandobersek@gmail.com
  • 4 edits in trunk/Source/WebCore

[TexMap] Remove GraphicsContext3D usage from BitmapTexturePool
​https://bugs.webkit.org/show_bug.cgi?id=175319

Reviewed by Carlos Garcia Campos.

Drop the GraphicsContext3D reference in BitmapTexturePool now
that the BitmapTextureGL doesn't require it anymore.

No new tests -- no change in behavior.

  • platform/graphics/texmap/BitmapTexturePool.cpp:

(WebCore::BitmapTexturePool::BitmapTexturePool):

  • platform/graphics/texmap/BitmapTexturePool.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::TextureMapperGL):

12:30 AM Changeset in webkit [220520] by jmarcell@apple.com
  • 21 edits in branches/safari-604-branch

Cherry-pick r220459. rdar://problem/33820790

12:20 AM Changeset in webkit [220519] by zandobersek@gmail.com
  • 6 edits in trunk/Source/WebCore

[TexMap] Drop GraphicsContext3D usage from BitmapTextureGL
​https://bugs.webkit.org/show_bug.cgi?id=175317

Reviewed by Carlos Garcia Campos.

Have BitmapTextureGL use direct OpenGL API entrypoints and constants
instead of leveraging the GraphicsContext3D class. Any GraphicsContext3D
object passed to BitmapTextureGL would assume rendering to the GL context
that's current on that thread, translating method invocations to the
OpenGL API. We can do this by ourselves and benefit by avoiding allocating
GraphicsContext3D resources like the ANGLE compiler that are by most useful
for WebGL.

BitmapTextureGL::create() call sites are adjusted to stop passing a
GraphicsContext3D reference. BitmapTextureGL::bindAsSurface() doesn't need
a replacement for the passed-in GraphicsContext3D object since that object
originated from the TextureMapperGL instance, whose GraphicsContext3D is by
default of the render-to-current-context nature. Other changes are direct
translations of GraphicsContext3D methods to OpenGL API calls, or of
GraphicsContext3D values to OpenGL API constants.

No new tests -- no change in behavior.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):

  • platform/graphics/texmap/BitmapTextureGL.cpp:

Also remove an unnecessary GraphicsContext.h header inclusion.
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContentsNoSwizzle):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::initializeStencil):
(WebCore::BitmapTextureGL::initializeDepthBuffer):
(WebCore::BitmapTextureGL::clearIfNeeded):
(WebCore::BitmapTextureGL::createFboIfNeeded):
(WebCore::BitmapTextureGL::bindAsSurface):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::BitmapTextureGL::copyFromExternalTexture):

  • platform/graphics/texmap/BitmapTextureGL.h:

(WebCore::BitmapTextureGL::create):
(WebCore::BitmapTextureGL::textureTarget const):
(WebCore::BitmapTextureGL::internalFormat const):

  • platform/graphics/texmap/BitmapTexturePool.cpp:

(WebCore::BitmapTexturePool::createTexture):

  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapperGL::createTexture):

Aug 9, 2017:

11:52 PM Changeset in webkit [220518] by jmarcell@apple.com
  • 21 edits in branches/safari-604.1.38.1-branch

Cherry-pick r220459. rdar://problem/33820786

11:13 PM Changeset in webkit [220517] by jmarcell@apple.com
  • 21 edits in branches/safari-604.1.38.0-branch

Cherry-pick r220459. rdar://problem/33820787

11:01 PM Changeset in webkit [220516] by Dewei Zhu
  • 2 edits in trunk/Tools

Fix run-benchmark after r220483.
​https://bugs.webkit.org/show_bug.cgi?id=175415
<rdar://problem/33803003>

Reviewed by Ryosuke Niwa.

Update run-benchmark script to adapt new Timeout implementation introduced in r220483.

  • Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:

(WebServerBenchmarkRunner._run_one_test):

10:58 PM Changeset in webkit [220515] by Michael Catanzaro
  • 5 edits
    1 move
    2 deletes in trunk

[GTK] Remove support for geoclue1
​https://bugs.webkit.org/show_bug.cgi?id=164205

Reviewed by Carlos Garcia Campos.

.:

  • Source/cmake/FindGeoClue.cmake: Removed.
  • Source/cmake/OptionsGTK.cmake:

Source/WebCore:

  • PlatformGTK.cmake:
  • platform/geoclue/GeolocationProviderGeoclue.h:
  • platform/geoclue/GeolocationProviderGeoclue1.cpp: Removed.
  • platform/geoclue/GeolocationProviderGeoclue2.cpp: Removed.
9:31 PM Changeset in webkit [220514] by jmarcell@apple.com
  • 12 edits in branches/safari-604-branch

Cherry-pick r220473. rdar://problem/33810961

9:31 PM Changeset in webkit [220513] by jmarcell@apple.com
  • 3 edits
    4 adds in branches/safari-604-branch

Cherry-pick r220456. rdar://problem/33810950

9:31 PM Changeset in webkit [220512] by jmarcell@apple.com
  • 3 edits in branches/safari-604-branch/Source/WebKitLegacy/mac

Cherry-pick r220429. rdar://problem/33810973

9:31 PM Changeset in webkit [220511] by jmarcell@apple.com
  • 3 edits in branches/safari-604-branch/Source/JavaScriptCore

Cherry-pick r220346. rdar://problem/33810976

9:31 PM Changeset in webkit [220510] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r220333. rdar://problem/33810934

9:31 PM Changeset in webkit [220509] by jmarcell@apple.com
  • 3 edits in branches/safari-604-branch

Cherry-pick r220289. rdar://problem/33810941

9:31 PM Changeset in webkit [220508] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebKitLegacy

Cherry-pick r220205. rdar://problem/33810980

9:19 PM Changeset in webkit [220507] by Chris Dumez
  • 16 edits
    2 copies
    8 adds in trunk

Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
​https://bugs.webkit.org/show_bug.cgi?id=175401

Reviewed by Brady Eidson.

Source/WebKit:

  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetBeaconAPIEnabled):
(WKPreferencesGetBeaconAPIEnabled):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

  • config.h:

Source/WebKitLegacy/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences beaconAPIEnabled]): Deleted.
(-[WebPreferences setBeaconAPIEnabled:]): Deleted.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):

LayoutTests:

  • platform/mac-elcapitan-wk2/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt.
  • platform/mac-elcapitan-wk2/imported/w3c/web-platform-tests/url/failure-expected.txt: Added.
  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/mac-wk1/imported/w3c/web-platform-tests/url/failure-expected.txt: Added.
  • platform/mac-wk2/TestExpectations:
  • platform/win/TestExpectations:
  • platform/win/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt.
  • platform/win/imported/w3c/web-platform-tests/url/failure-expected.txt: Added.
9:13 PM Changeset in webkit [220506] by commit-queue@webkit.org
  • 139 edits
    30 copies
    2 adds
    2 deletes in trunk

[PAL] Move spi/cocoa and spi/cg directories into PAL
​https://bugs.webkit.org/show_bug.cgi?id=175175

Patch by Yoshiaki Jitsukawa <​Yoshiaki.Jitsukawa@sony.com> on 2017-08-09
Reviewed by Myles C. Maxfield.

Source/WebCore:

  • Modules/applepay/cocoa/PaymentCocoa.mm:
  • Modules/applepay/cocoa/PaymentContactCocoa.mm:
  • Modules/applepay/cocoa/PaymentMerchantSessionCocoa.mm:
  • Modules/applepay/cocoa/PaymentMethodCocoa.mm:
  • PlatformAppleWin.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • editing/cocoa/EditorCocoa.mm:
  • editing/cocoa/HTMLConverter.mm:
  • editing/ios/EditorIOS.mm:
  • page/cocoa/ResourceUsageThreadCocoa.mm:
  • page/mac/TextIndicatorWindow.mm:
  • platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:
  • platform/cocoa/DataDetectorsCoreSoftLink.h:
  • platform/cocoa/MIMETypeRegistryCocoa.mm:
  • platform/cocoa/NetworkExtensionContentFilter.mm:
  • platform/cocoa/ParentalControlsContentFilter.mm:
  • platform/cocoa/SleepDisablerCocoa.cpp:
  • platform/graphics/Font.cpp:
  • platform/graphics/Font.h:
  • platform/graphics/avfoundation/objc/AVAssetTrackUtilities.mm:
  • platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
  • platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm:
  • platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.mm:
  • platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:
  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
  • platform/graphics/cg/ColorCG.cpp:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/ImageBufferCG.cpp:
  • platform/graphics/cg/ImageBufferDataCG.cpp:
  • platform/graphics/cg/ImageDecoderCG.cpp:
  • platform/graphics/cg/NativeImageCG.cpp:
  • platform/graphics/cocoa/FontCacheCoreText.cpp:
  • platform/graphics/cocoa/FontCascadeCocoa.mm:
  • platform/graphics/cocoa/FontCocoa.mm:
  • platform/graphics/cocoa/FontDescriptionCocoa.cpp:
  • platform/graphics/cocoa/FontPlatformDataCocoa.mm:
  • platform/graphics/cocoa/IOSurface.mm:
  • platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:
  • platform/graphics/cocoa/WebActionDisablingCALayerDelegate.h:
  • platform/graphics/ios/FontAntialiasingStateSaver.h:
  • platform/graphics/ios/FontCacheIOS.mm:
  • platform/graphics/mac/ComplexTextControllerCoreText.mm:
  • platform/graphics/mac/FontCacheMac.mm:
  • platform/graphics/mac/GlyphPageMac.cpp:
  • platform/graphics/win/FontCacheWin.cpp:
  • platform/ios/LegacyTileCache.mm:
  • platform/ios/LegacyTileGrid.mm:
  • platform/ios/LegacyTileGridTile.mm:
  • platform/ios/PlaybackSessionInterfaceAVKit.mm:
  • platform/ios/QuickLook.mm:
  • platform/ios/VideoFullscreenInterfaceAVKit.mm:
  • platform/ios/WebAVPlayerController.h:
  • platform/ios/WebAVPlayerController.mm:
  • platform/ios/WebVideoFullscreenControllerAVKit.mm:
  • platform/ios/wak/WKGraphics.mm:
  • platform/mac/DragImageMac.mm:
  • platform/mac/PlatformScreenMac.mm:
  • platform/mac/PlaybackSessionInterfaceMac.mm:
  • platform/mac/ThemeMac.mm:
  • platform/mac/VideoFullscreenInterfaceMac.mm:
  • platform/mac/WebPlaybackControlsManager.h:
  • platform/mac/WebVideoFullscreenHUDWindowController.mm:
  • platform/network/cocoa/CookieStorageObserver.mm:
  • platform/network/cocoa/NetworkLoadMetrics.mm:
  • platform/network/mac/AuthenticationMac.mm:
  • platform/network/mac/ResourceHandleMac.mm:
  • platform/spi/ios/DataDetectorsUISPI.h:
  • platform/spi/mac/DataDetectorsSPI.h:
  • platform/spi/mac/NSViewSPI.h:
  • rendering/RenderThemeCocoa.mm:
  • rendering/RenderThemeIOS.mm:
  • rendering/RenderThemeMac.mm:

Source/WebCore/PAL:

  • PAL.xcodeproj/project.pbxproj:
  • pal/PlatformAppleWin.cmake:
  • pal/spi/cg/CoreGraphicsSPI.h: Renamed from Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h.

(CGFloatMin):

  • pal/spi/cg/ImageIOSPI.h: Renamed from Source/WebCore/platform/spi/cg/ImageIOSPI.h.
  • pal/spi/cocoa/AVKitSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/AVKitSPI.h.

(-[AVTouchBarPlaybackControlsControlling NS_ENUM]):

  • pal/spi/cocoa/CFNSURLConnectionSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/CFNSURLConnectionSPI.h.
  • pal/spi/cocoa/CoreTextSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/CoreTextSPI.h.
  • pal/spi/cocoa/DataDetectorsCoreSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/DataDetectorsCoreSPI.h.
  • pal/spi/cocoa/IOPMLibSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOPMLibSPI.h.
  • pal/spi/cocoa/IOPSLibSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOPSLibSPI.h.
  • pal/spi/cocoa/IOReturnSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOReturnSPI.h.
  • pal/spi/cocoa/IOSurfaceSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOSurfaceSPI.h.
  • pal/spi/cocoa/IOTypesSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOTypesSPI.h.
  • pal/spi/cocoa/LinkPresentationSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/LinkPresentationSPI.h.
  • pal/spi/cocoa/MachVMSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/MachVMSPI.h.
  • pal/spi/cocoa/NEFilterSourceSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NEFilterSourceSPI.h.
  • pal/spi/cocoa/NSAttributedStringSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSAttributedStringSPI.h.
  • pal/spi/cocoa/NSButtonCellSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSButtonCellSPI.h.
  • pal/spi/cocoa/NSCalendarDateSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSCalendarDateSPI.h.
  • pal/spi/cocoa/NSColorSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSColorSPI.h.
  • pal/spi/cocoa/NSExtensionSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSExtensionSPI.h.
  • pal/spi/cocoa/NSFileManagerSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSFileManagerSPI.h.
  • pal/spi/cocoa/NSStringSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSStringSPI.h.
  • pal/spi/cocoa/NSTouchBarSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSTouchBarSPI.h.
  • pal/spi/cocoa/NSURLConnectionSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSURLConnectionSPI.h.
  • pal/spi/cocoa/NSURLDownloadSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSURLDownloadSPI.h.
  • pal/spi/cocoa/NSURLFileTypeMappingsSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSURLFileTypeMappingsSPI.h.
  • pal/spi/cocoa/PassKitSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/PassKitSPI.h.

(NS_ERROR_ENUM):

  • pal/spi/cocoa/QuartzCoreSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h.
  • pal/spi/cocoa/ServersSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/ServersSPI.h.
  • pal/spi/cocoa/WebFilterEvaluatorSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/WebFilterEvaluatorSPI.h.
  • pal/spi/cocoa/pthreadSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/pthreadSPI.h.

Source/WebKit:

  • NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm:
  • NetworkProcess/Downloads/mac/DownloadMac.mm:
  • Platform/cocoa/SharedMemoryCocoa.cpp:
  • Platform/mac/LayerHostingContext.mm:
  • Shared/Cocoa/DataDetectionResult.mm:
  • Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
  • Shared/cf/CookieStorageUtilsCF.mm:
  • Shared/ios/InteractionInformationAtPosition.mm:
  • Shared/mac/HangDetectionDisablerMac.mm:
  • Shared/mac/RemoteLayerBackingStore.mm:
  • Shared/mac/RemoteLayerTreePropertyApplier.mm:
  • UIProcess/API/Cocoa/WKWebView.mm:
  • UIProcess/API/mac/WKView.mm:
  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:
  • UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
  • UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:
  • UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:
  • UIProcess/ios/ViewGestureControllerIOS.mm:
  • UIProcess/ios/WKContentView.mm:
  • UIProcess/ios/WKContentViewInteraction.mm:
  • UIProcess/ios/WKPDFPageNumberIndicator.mm:
  • UIProcess/ios/WKScrollView.mm:
  • UIProcess/mac/RemoteLayerTreeHost.mm:
  • UIProcess/mac/ServicesController.mm:
  • UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
  • UIProcess/mac/ViewGestureControllerMac.mm:
  • UIProcess/mac/ViewSnapshotStore.mm:
  • UIProcess/mac/WKViewLayoutStrategy.mm:
  • WebProcess/Plugins/PDF/PDFPlugin.mm:
  • WebProcess/WebPage/WebPage.cpp:
  • WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:
  • WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
  • WebProcess/cocoa/WebProcessCocoa.mm:

Source/WebKitLegacy/ios:

  • Misc/WebNSStringExtrasIOS.m:
  • WebCoreSupport/WebFixedPositionContent.mm:

Source/WebKitLegacy/mac:

  • History/WebHistory.mm:
  • Misc/WebDownload.mm:
  • Misc/WebKitNSStringExtras.mm:
  • Plugins/Hosted/NetscapePluginHostManager.mm:
  • Plugins/WebPluginDatabase.mm:
  • WebCoreSupport/WebFrameLoaderClient.mm:
  • WebInspector/WebNodeHighlight.mm:
  • WebView/WebHTMLView.mm:
  • WebView/WebIndicateLayer.mm:
  • WebView/WebView.mm:
  • WebView/WebViewData.h:

Tools:

  • DumpRenderTree/ios/PixelDumpSupportIOS.mm:
  • DumpRenderTree/mac/DumpRenderTree.mm:
  • TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:
  • WebKitTestRunner/ios/PlatformWebViewIOS.mm:
  • Scripts/webkitpy/style/checker.py:
  • Scripts/webkitpy/style/checker_unittest.py:

(GlobalVariablesTest.test_path_rules_specifier):

Add path rules specifiers for PassKitSPI.h and DataDetectorsCoreSPI.h

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_braces):

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_braces.CF_OPTIONS):
(WebKitStyleTest.test_braces):

Prevent CF_OPTIONS() from being handled as funtion definition.

8:21 PM Changeset in webkit [220505] by wilander@apple.com
  • 2 edits in trunk/Source/WebKit

Resource Load Statistics: Increase grandfathering time to 3 days
​https://bugs.webkit.org/show_bug.cgi?id=175414
<rdar://problem/33818046>

Reviewed by Brent Fulgham.

  • UIProcess/WebResourceLoadStatisticsStore.h:
7:11 PM Changeset in webkit [220504] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebKit

Invalidate PlaybackSessionManager in same fashion as VideoFullscreenManager.
​https://bugs.webkit.org/show_bug.cgi?id=175399
rdar://problem/33663344

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-08-09
Reviewed by Eric Carlson.

Invalidate PlaybackSessionManager when WebPage is destructed.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::~WebPage):

  • WebProcess/cocoa/PlaybackSessionManager.h:
  • WebProcess/cocoa/PlaybackSessionManager.mm:

(WebKit::PlaybackSessionManager::~PlaybackSessionManager):
(WebKit::PlaybackSessionManager::invalidate):

6:15 PM Changeset in webkit [220503] by don.olmstead@sony.com
  • 258 edits
    2 moves in trunk

[WTF] Move TextStream into WTF
​https://bugs.webkit.org/show_bug.cgi?id=175211

Reviewed by Myles C. Maxfield.

Source/WebCore:

No new tests. No change in behavior.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/ComposedTreeIterator.cpp:
  • dom/Position.cpp:
  • dom/Position.h:
  • dom/Range.cpp:

(WebCore::operator<<):

  • dom/Range.h:
  • dom/ViewportArguments.cpp:
  • dom/ViewportArguments.h:
  • editing/VisiblePosition.cpp:
  • editing/VisiblePosition.h:
  • editing/VisibleSelection.cpp:
  • editing/VisibleSelection.h:
  • html/HTMLVideoElement.cpp:
  • html/canvas/CanvasRenderingContext2D.cpp:
  • page/FrameView.cpp:
  • page/ViewportConfiguration.cpp:
  • page/ViewportConfiguration.h:
  • page/WheelEventDeltaFilter.cpp:
  • page/animation/CSSPropertyAnimation.cpp:
  • page/scrolling/AsyncScrollingCoordinator.cpp:
  • page/scrolling/ScrollingConstraints.cpp:
  • page/scrolling/ScrollingConstraints.h:
  • page/scrolling/ScrollingCoordinator.cpp:
  • page/scrolling/ScrollingCoordinator.h:
  • page/scrolling/ScrollingStateFixedNode.cpp:
  • page/scrolling/ScrollingStateFixedNode.h:
  • page/scrolling/ScrollingStateFrameScrollingNode.cpp:
  • page/scrolling/ScrollingStateFrameScrollingNode.h:
  • page/scrolling/ScrollingStateNode.cpp:
  • page/scrolling/ScrollingStateNode.h:
  • page/scrolling/ScrollingStateOverflowScrollingNode.cpp:
  • page/scrolling/ScrollingStateOverflowScrollingNode.h:
  • page/scrolling/ScrollingStateScrollingNode.cpp:
  • page/scrolling/ScrollingStateScrollingNode.h:
  • page/scrolling/ScrollingStateStickyNode.cpp:
  • page/scrolling/ScrollingStateStickyNode.h:
  • page/scrolling/ScrollingTree.cpp:
  • page/scrolling/ScrollingTreeFrameScrollingNode.cpp:
  • page/scrolling/ScrollingTreeFrameScrollingNode.h:
  • page/scrolling/ScrollingTreeNode.cpp:
  • page/scrolling/ScrollingTreeNode.h:
  • page/scrolling/ScrollingTreeScrollingNode.cpp:
  • page/scrolling/ScrollingTreeScrollingNode.h:
  • page/scrolling/mac/ScrollingTreeFixedNode.h:
  • page/scrolling/mac/ScrollingTreeFixedNode.mm:
  • page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
  • page/scrolling/mac/ScrollingTreeStickyNode.h:
  • page/scrolling/mac/ScrollingTreeStickyNode.mm:
  • platform/CalculationValue.cpp:
  • platform/CalculationValue.h:
  • platform/LayoutUnit.cpp:
  • platform/LayoutUnit.h:
  • platform/Length.cpp:
  • platform/Length.h:
  • platform/LengthBox.cpp:
  • platform/LengthBox.h:
  • platform/LengthPoint.cpp:
  • platform/LengthPoint.h:
  • platform/LengthSize.cpp:
  • platform/LengthSize.h:
  • platform/LogMacros.h:
  • platform/ScrollView.cpp:
  • platform/ScrollableArea.cpp:
  • platform/animation/TimingFunction.cpp:
  • platform/animation/TimingFunction.h:
  • platform/graphics/BitmapImage.cpp:
  • platform/graphics/BitmapImage.h:
  • platform/graphics/Color.cpp:
  • platform/graphics/Color.h:
  • platform/graphics/CrossfadeGeneratedImage.cpp:
  • platform/graphics/CrossfadeGeneratedImage.h:
  • platform/graphics/FloatPoint.cpp:
  • platform/graphics/FloatPoint.h:
  • platform/graphics/FloatPoint3D.cpp:
  • platform/graphics/FloatPoint3D.h:
  • platform/graphics/FloatRect.cpp:
  • platform/graphics/FloatRect.h:
  • platform/graphics/FloatRoundedRect.cpp:
  • platform/graphics/FloatRoundedRect.h:
  • platform/graphics/FloatSize.cpp:
  • platform/graphics/FloatSize.h:
  • platform/graphics/FontTaggedSettings.cpp:
  • platform/graphics/FontTaggedSettings.h:
  • platform/graphics/GradientImage.cpp:

(WebCore::GradientImage::dump const):

  • platform/graphics/GradientImage.h:
  • platform/graphics/GraphicsContext.cpp:
  • platform/graphics/GraphicsContext.h:
  • platform/graphics/GraphicsLayer.cpp:
  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::dumpAdditionalProperties const):

  • platform/graphics/GraphicsTypes.cpp:
  • platform/graphics/GraphicsTypes.h:
  • platform/graphics/Image.cpp:
  • platform/graphics/Image.h:
  • platform/graphics/ImageSource.h:
  • platform/graphics/IntPoint.cpp:
  • platform/graphics/IntPoint.h:
  • platform/graphics/IntRect.cpp:
  • platform/graphics/IntRect.h:
  • platform/graphics/IntSize.cpp:
  • platform/graphics/IntSize.h:
  • platform/graphics/LayoutPoint.cpp:
  • platform/graphics/LayoutPoint.h:
  • platform/graphics/LayoutRect.cpp:
  • platform/graphics/LayoutRect.h:
  • platform/graphics/LayoutSize.cpp:
  • platform/graphics/LayoutSize.h:
  • platform/graphics/NamedImageGeneratedImage.cpp:
  • platform/graphics/NamedImageGeneratedImage.h:
  • platform/graphics/Path.cpp:
  • platform/graphics/Path.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:
  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/PlatformCAAnimation.cpp:
  • platform/graphics/ca/PlatformCAAnimation.h:
  • platform/graphics/ca/PlatformCALayer.cpp:
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/TileController.cpp:
  • platform/graphics/ca/TileGrid.cpp:
  • platform/graphics/cg/GraphicsContextCG.cpp:
  • platform/graphics/cg/PDFDocumentImage.cpp:
  • platform/graphics/cg/PDFDocumentImage.h:
  • platform/graphics/cocoa/IOSurface.h:
  • platform/graphics/cocoa/IOSurface.mm:
  • platform/graphics/displaylists/DisplayList.cpp:

(WebCore::DisplayList::DisplayList::description const):

  • platform/graphics/displaylists/DisplayList.h:
  • platform/graphics/displaylists/DisplayListItems.cpp:
  • platform/graphics/displaylists/DisplayListItems.h:
  • platform/graphics/displaylists/DisplayListRecorder.cpp:
  • platform/graphics/displaylists/DisplayListReplayer.cpp:
  • platform/graphics/filters/DistantLightSource.cpp:
  • platform/graphics/filters/DistantLightSource.h:
  • platform/graphics/filters/FEBlend.cpp:
  • platform/graphics/filters/FEBlend.h:
  • platform/graphics/filters/FEColorMatrix.cpp:
  • platform/graphics/filters/FEColorMatrix.h:
  • platform/graphics/filters/FEComponentTransfer.cpp:
  • platform/graphics/filters/FEComponentTransfer.h:
  • platform/graphics/filters/FEComposite.cpp:
  • platform/graphics/filters/FEComposite.h:
  • platform/graphics/filters/FEConvolveMatrix.cpp:
  • platform/graphics/filters/FEConvolveMatrix.h:
  • platform/graphics/filters/FEDiffuseLighting.cpp:
  • platform/graphics/filters/FEDiffuseLighting.h:
  • platform/graphics/filters/FEDisplacementMap.cpp:
  • platform/graphics/filters/FEDisplacementMap.h:
  • platform/graphics/filters/FEDropShadow.cpp:
  • platform/graphics/filters/FEDropShadow.h:
  • platform/graphics/filters/FEFlood.cpp:
  • platform/graphics/filters/FEFlood.h:
  • platform/graphics/filters/FEGaussianBlur.cpp:
  • platform/graphics/filters/FEGaussianBlur.h:
  • platform/graphics/filters/FEMerge.cpp:
  • platform/graphics/filters/FEMerge.h:
  • platform/graphics/filters/FEMorphology.cpp:
  • platform/graphics/filters/FEMorphology.h:
  • platform/graphics/filters/FEOffset.cpp:
  • platform/graphics/filters/FEOffset.h:
  • platform/graphics/filters/FESpecularLighting.cpp:
  • platform/graphics/filters/FESpecularLighting.h:
  • platform/graphics/filters/FETile.cpp:
  • platform/graphics/filters/FETile.h:
  • platform/graphics/filters/FETurbulence.cpp:
  • platform/graphics/filters/FETurbulence.h:
  • platform/graphics/filters/FilterEffect.cpp:
  • platform/graphics/filters/FilterEffect.h:
  • platform/graphics/filters/FilterOperation.cpp:
  • platform/graphics/filters/FilterOperation.h:
  • platform/graphics/filters/FilterOperations.cpp:
  • platform/graphics/filters/FilterOperations.h:
  • platform/graphics/filters/LightSource.h:
  • platform/graphics/filters/PointLightSource.cpp:
  • platform/graphics/filters/PointLightSource.h:
  • platform/graphics/filters/SourceAlpha.cpp:
  • platform/graphics/filters/SourceAlpha.h:
  • platform/graphics/filters/SourceGraphic.cpp:
  • platform/graphics/filters/SourceGraphic.h:
  • platform/graphics/filters/SpotLightSource.cpp:
  • platform/graphics/filters/SpotLightSource.h:
  • platform/graphics/transforms/AffineTransform.cpp:
  • platform/graphics/transforms/AffineTransform.h:
  • platform/graphics/transforms/IdentityTransformOperation.h:
  • platform/graphics/transforms/Matrix3DTransformOperation.cpp:
  • platform/graphics/transforms/Matrix3DTransformOperation.h:
  • platform/graphics/transforms/MatrixTransformOperation.cpp:
  • platform/graphics/transforms/MatrixTransformOperation.h:
  • platform/graphics/transforms/PerspectiveTransformOperation.cpp:
  • platform/graphics/transforms/PerspectiveTransformOperation.h:
  • platform/graphics/transforms/RotateTransformOperation.cpp:
  • platform/graphics/transforms/RotateTransformOperation.h:
  • platform/graphics/transforms/ScaleTransformOperation.cpp:
  • platform/graphics/transforms/ScaleTransformOperation.h:
  • platform/graphics/transforms/SkewTransformOperation.cpp:
  • platform/graphics/transforms/SkewTransformOperation.h:
  • platform/graphics/transforms/TransformOperation.cpp:
  • platform/graphics/transforms/TransformOperation.h:
  • platform/graphics/transforms/TransformOperations.cpp:
  • platform/graphics/transforms/TransformOperations.h:
  • platform/graphics/transforms/TransformationMatrix.cpp:
  • platform/graphics/transforms/TransformationMatrix.h:
  • platform/graphics/transforms/TranslateTransformOperation.cpp:
  • platform/graphics/transforms/TranslateTransformOperation.h:
  • platform/ios/SelectionRect.cpp:

(WebCore::operator<<):

  • platform/ios/SelectionRect.h:
  • platform/mac/ScrollAnimatorMac.mm:
  • platform/text/TextAllInOne.cpp:
  • rendering/InlineBox.cpp:
  • rendering/InlineBox.h:
  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::outputLineTreeAndMark const):

  • rendering/InlineFlowBox.h:
  • rendering/InlineTextBox.cpp:
  • rendering/InlineTextBox.h:
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::outputLineTreeAndMark const):

  • rendering/RenderBlockFlow.h:
  • rendering/RenderLayer.cpp:
  • rendering/RenderLayerCompositor.cpp:
  • rendering/RenderObject.cpp:
  • rendering/RenderObject.h:
  • rendering/RenderTreeAsText.cpp:
  • rendering/RenderTreeAsText.h:
  • rendering/ScrollAlignment.cpp:
  • rendering/ScrollAlignment.h:
  • rendering/SimpleLineLayoutCoverage.cpp:
  • rendering/SimpleLineLayoutFunctions.cpp:
  • rendering/SimpleLineLayoutFunctions.h:
  • rendering/style/FillLayer.cpp:
  • rendering/style/FillLayer.h:
  • rendering/style/NinePieceImage.cpp:
  • rendering/style/NinePieceImage.h:
  • rendering/style/RenderStyleConstants.cpp:
  • rendering/style/RenderStyleConstants.h:
  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::operator<<):

  • rendering/svg/SVGRenderTreeAsText.h:

(WebCore::operator<<):

  • svg/SVGLengthValue.cpp:
  • svg/SVGLengthValue.h:
  • svg/graphics/SVGImage.cpp:
  • svg/graphics/SVGImage.h:
  • svg/graphics/filters/SVGFEImage.cpp:
  • svg/graphics/filters/SVGFEImage.h:

Source/WebKit:

  • Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
  • Shared/VisibleContentRectUpdateInfo.cpp:
  • Shared/VisibleContentRectUpdateInfo.h:
  • Shared/mac/RemoteLayerTreeTransaction.mm:
  • UIProcess/API/Cocoa/WKWebView.mm:
  • UIProcess/ios/WKContentView.mm:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(WebKit::operator<<):

  • UIProcess/ios/WebPageProxyIOS.mm:
  • WebProcess/WebPage/ios/WebPageIOS.mm:
  • WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:
  • WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:

Source/WTF:

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/text/TextStream.cpp: Renamed from Source/WebCore/platform/text/TextStream.cpp.

(WTF::TextStream::writeIndent):

  • wtf/text/TextStream.h: Renamed from Source/WebCore/platform/text/TextStream.h.

(WTF::TextStream::FormatNumberRespectingIntegers::FormatNumberRespectingIntegers):

Tools:

  • TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:
6:12 PM Changeset in webkit [220502] by mmaxfield@apple.com
  • 2 edits in trunk/PerformanceTests

font-fallback-font-family.html is failing on perf bots
​https://bugs.webkit.org/show_bug.cgi?id=174989

Unreviewed.

  • Layout/resources/font-fallback-font-family.html:
6:07 PM Changeset in webkit [220501] by aestes@apple.com
  • 7 edits in trunk

Part 3 of: Rename DatabaseProcess to StorageProcess
​https://bugs.webkit.org/show_bug.cgi?id=175034

Reviewed by Brady Eidson.

Source/WebKit:

We tried renaming com.apple.WebKit.Databases to com.apple.WebKit.Storage in r219986, but
this prevented trunk WebKit from running on iOS 11 devices. This is because launchd keeps a
codesigned cache of XPC services, and refuses to launch services that aren't in the cache.

It's not possibe for us to rebuild the cache with the new service name (only Apple's
production build system can do this), and disabling the cache or opting WebKit's XPC
services out of the cache might have a negative impact on our performance testing.

For now we'll retain the name "com.apple.WebKit.Databases" on iOS 11 devices to work around
this issue. If we find a way to allow the new service to run without impacting performance,
we can revert this change.

We will rename the service to "com.apple.WebKit.Storage" on macOS and iOS Simulator, and in
a follow-up patch we'll use the new service name on post-iOS 11 device builds.

  • Configurations/BaseTarget.xcconfig: Defined WK_STORAGE_SERVICE_PRODUCT_NAME to be

com.apple.WebKit.Databases by default, and overrode it to com.apple.WebKit.Storage on macOS
and iOS Simulator.

  • Configurations/StorageService.xcconfig: Changed PRODUCT_NAME to $(WK_STORAGE_SERVICE_PRODUCT_NAME).
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::serviceName): Changed to return "com.apple.WebKit.Storage" on macOS and
iOS Simulator platforms.

  • WebKit.xcodeproj/project.pbxproj: Updated the "Copy XPC services for engineering builds"

build phase to use WK_STORAGE_SERVICE_PRODUCT_NAME.

Tools:

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::databaseProcessName): Updated to return
"com.apple.WebKit.Storage.Development" on macOS and iOS Simulator.

5:42 PM Changeset in webkit [220500] by Caio Lima
  • 4 edits in trunk/Source/JavaScriptCore

[JSC] Create JSSet constructor that accepts it's size as parameter
​https://bugs.webkit.org/show_bug.cgi?id=173297

Reviewed by Saam Barati.

This patch is adding a new constructor to JSSet that gives its
expected initial size. It is important to avoid re-hashing and mutiple
allocations when we know the final size of JSSet, such as in
CodeBlock::setConstantIdentifierSetRegisters.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::setConstantIdentifierSetRegisters):

  • runtime/HashMapImpl.h:

(JSC::HashMapImpl::HashMapImpl):

  • runtime/JSSet.h:
5:35 PM Changeset in webkit [220499] by Ryan Haddad
  • 10 edits in trunk

Unreviewed, rolling out r220466, r220477, and r220487.
​https://bugs.webkit.org/show_bug.cgi?id=175411

This change broke existing API tests and follow up fixes did
not resolve all the issues. (Requested by ryanhaddad on
#webkit).

Reverted changesets:

​https://bugs.webkit.org/show_bug.cgi?id=175244
​http://trac.webkit.org/changeset/220466

"WTF::Function does not allow for reference / non-default
constructible return types"
​https://bugs.webkit.org/show_bug.cgi?id=175244
​http://trac.webkit.org/changeset/220477

​https://bugs.webkit.org/show_bug.cgi?id=175244
​http://trac.webkit.org/changeset/220487

Patch by Commit Queue <​commit-queue@webkit.org> on 2017-08-09

4:32 PM Changeset in webkit [220498] by Michael Catanzaro
  • 1 edit
    6 deletes in trunk

[CMake] Remove unused find modules
​https://bugs.webkit.org/show_bug.cgi?id=175363

Reviewed by Carlos Alberto Lopez Perez.

  • Source/cmake/FindCFLite.cmake: Removed.
  • Source/cmake/FindClang.cmake: Removed.
  • Source/cmake/FindDBus.cmake: Removed.
  • Source/cmake/FindDirectX.cmake: Removed.
  • Source/cmake/FindEspeak.cmake: Removed.
  • Source/cmake/FindQuickTimeSDK.cmake: Removed.
4:23 PM Changeset in webkit [220497] by Chris Dumez
  • 14 edits
    3 copies
    4 adds in trunk

[Beacon][NetworkSession] Support CORS-preflighting on redirects
​https://bugs.webkit.org/show_bug.cgi?id=175386
<rdar://problem/33801370>

Reviewed by Youenn Fablet.

Source/WebCore:

Export a couple of WebCore symbols so I can use them in WebKit2.

Tests: http/wpt/beacon/cors/cors-preflight-redirect-failure.html

http/wpt/beacon/cors/cors-preflight-redirect-from-crossorigin-to-sameorigin.html
http/wpt/beacon/cors/cors-preflight-redirect-success.html

  • loader/CrossOriginAccessControl.h:
  • page/SecurityOrigin.h:

Source/WebKit:

Add support to Beacon for doing CORS-preflighting upon redirect to a different
domain.

  • NetworkProcess/NetworkCORSPreflightChecker.h:
  • NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::~PingLoad):
(WebKit::PingLoad::loadRequest):
(WebKit::PingLoad::securityOrigin const):
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::didReceiveResponseNetworkSession):
(WebKit::PingLoad::needsCORSPreflight const):
(WebKit::PingLoad::doCORSPreflight):

  • NetworkProcess/PingLoad.h:

LayoutTests:

Add layout test coverage.

  • http/wpt/beacon/cors/cors-preflight-redirect-failure-expected.txt: Added.
  • http/wpt/beacon/cors/cors-preflight-redirect-failure.html: Added.
  • http/wpt/beacon/cors/cors-preflight-redirect-from-crossorigin-to-sameorigin-expected.txt: Added.
  • http/wpt/beacon/cors/cors-preflight-redirect-from-crossorigin-to-sameorigin.html: Added.
  • http/wpt/beacon/cors/cors-preflight-redirect-success-expected.txt: Added.
  • http/wpt/beacon/cors/cors-preflight-redirect-success.html: Added.
  • http/wpt/beacon/resources/beacon-preflight.py:

(main):

  • http/wpt/beacon/resources/redirect.py: Added.

(main):

4:18 PM Changeset in webkit [220496] by commit-queue@webkit.org
  • 6 edits in trunk/Source

Use MPAVRoutingController instead of deprecated versions.
​https://bugs.webkit.org/show_bug.cgi?id=175063
Source/WebCore:

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-08-09
Reviewed by Tim Horton.

No new tests because no behavior change. This uses a different platform class to present
an interface.

Remove deprecated MPAudioVideoRoutingPopoverController and MPAVRoutingSheet
Add MPMediaControlsViewController.

  • platform/spi/ios/MediaPlayerSPI.h:

Source/WebKit:

rdar://problem/33301230

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-08-09
Reviewed by Tim Horton.

Remove dependence on deprecated classes MPAVRoutingSheet and MPAudioVideoRoutingPopoverController.

  • UIProcess/ios/forms/WKAirPlayRoutePicker.h:
  • UIProcess/ios/forms/WKAirPlayRoutePicker.mm:

(-[WKAirPlayRoutePicker dealloc]):
(-[WKAirPlayRoutePicker show:fromRect:]):
(-[WKAirPlayRoutePicker popoverControllerDidDismissPopover:]): Deleted.
(-[WKAirPlayRoutePicker _presentAirPlayPopoverAnimated:fromRect:]): Deleted.
(-[WKAirPlayRoutePicker _windowWillRotate:]): Deleted.
(-[WKAirPlayRoutePicker _windowDidRotate:]): Deleted.
(-[WKAirPlayRoutePicker _dismissAirPlayRoutePickerIPad]): Deleted.
(-[WKAirPlayRoutePicker showAirPlayPickerIPad:fromRect:]): Deleted.
(-[WKAirPlayRoutePicker showAirPlayPickerIPhone:]): Deleted.

4:03 PM Changeset in webkit [220495] by Chris Dumez
  • 2 edits in trunk/LayoutTests

Unreviewed, deflake http/wpt/beacon/keepalive-after-navigation.html

Temporarily restore previous timeout on this test to address flakiness on the
bots until I can rewrite it.

  • http/wpt/beacon/keepalive-after-navigation.html:
4:01 PM Changeset in webkit [220494] by Chris Dumez
  • 4 edits
    1 delete in trunk/LayoutTests

Import beacon/headers/header-content-type.html from upstream WPT
​https://bugs.webkit.org/show_bug.cgi?id=175395

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

  • web-platform-tests/beacon/headers/header-content-type-expected.txt:
  • web-platform-tests/beacon/headers/header-content-type.html:

LayoutTests:

Drop local test that has been upstreamed to WPT.

  • http/wpt/beacon/headers/header-content-type-same-origin-expected.txt: Removed.
  • http/wpt/beacon/headers/header-content-type-same-origin.html: Removed.
3:59 PM Changeset in webkit [220493] by msaboff@apple.com
  • 1 edit
    2 adds in trunk/PerformanceTests

Unreviewed build fix.

Added missing files.

  • RexBench/Octane2/benchmark.js: Added.

(Octane2RegExpBenchmark):
(Octane2RegExpBenchmark.prototype.setup.):
(Octane2RegExpBenchmark.prototype.setup.Math.random):
(Octane2RegExpBenchmark.prototype.setup):
(Octane2RegExpBenchmark.prototype.runOnce):
(Octane2RegExpBenchmark.prototype.tearDown):

  • RexBench/SunSpider/benchmark.js: Added.

(RegexDNABenchmark):
(RegexDNABenchmark.prototype.runOnce):
(RegexDNABenchmark.prototype.validate):

3:50 PM Changeset in webkit [220492] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.1-branch/Source

Versioning.

3:47 PM Changeset in webkit [220491] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.0-branch/Source

Versioning.

3:45 PM Changeset in webkit [220490] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.1.3

Tag Safari-604.1.38.1.3.

3:44 PM Changeset in webkit [220489] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.0.3

Tag Safari-604.1.38.0.3.

3:42 PM Changeset in webkit [220488] by mmaxfield@apple.com
  • 2 edits in trunk/Source/WebCore

Mark font-display as in development
​https://bugs.webkit.org/show_bug.cgi?id=175387

Unreviewed.

  • features.json:
3:40 PM Changeset in webkit [220487] by weinig@apple.com
  • 2 edits in trunk/Tools

Update for ​https://bugs.webkit.org/show_bug.cgi?id=175244.

Remove one addition of null Function test.

3:36 PM Changeset in webkit [220486] by n_wang@apple.com
  • 2 edits in trunk/LayoutTests

LayoutTest accessibility/presentation-role-iframe.html is a flaky failure
​https://bugs.webkit.org/show_bug.cgi?id=175194

Reviewed by Chris Fleizach.

In the test we have no way to control which iframe will be loaded first.
Output the logs at the end of the test so that they are in order.

  • accessibility/presentation-role-iframe.html:
3:33 PM Changeset in webkit [220485] by msaboff@apple.com
  • 11 edits
    1 add
    1 delete in trunk/PerformanceTests

Rex Bench doesn't work from the command line
​https://bugs.webkit.org/show_bug.cgi?id=175349

Reviewed by Saam Barati.

Fixed cli.js to have the same set of benchmarks and .js files as the web
page driver.

Refactored the way benchmarks are run using a new Benchmark base class. That
class will run the benchmark as well. Eliminated the various runBenchmark()
functions that were used for individual tests. This refactoring was threaded
into the web page driver as well. Changed the iteration counts on many of the
individual benchmarks. Also changed the inner loop count for the flight
planner test.

Eliminated Octane2/base.js as it isn't needed to run Octane2/RegExp with the
new test harness. Eliminated other dead code in Octane2/regexp.js.

  • RexBench/Basic/benchmark.js:

(BasicBenchmark):
(BasicBenchmark.prototype.runIteration): Deleted.
(runBenchmark): Deleted.

  • RexBench/FlightPlanner/benchmark.js:

(FlightPlannerBenchmark):
(FlightPlannerBenchmark.prototype.runOnce):
(this.performance.performance.now.currentTime): Deleted.
(else.this.preciseTime.currentTime): Deleted.
(else.currentTime): Deleted.
(FlightPlannerBenchmark.prototype.runIteration): Deleted.
(FlightPlannerBenchmark.prototype.checkResults): Deleted.
(runBenchmark): Deleted.

  • RexBench/Octane2/base.js: Removed.
  • RexBench/Octane2/regexp.js:
  • RexBench/basic_benchmark.js:
  • RexBench/benchmark.js: Added.

(this.performance.performance.now.currentTime):
(else.this.preciseTime.currentTime):
(else.currentTime):
(Benchmark):
(Benchmark.prototype.runIterations):
(Benchmark.prototype.setup):
(Benchmark.prototype.runOnce):
(Benchmark.prototype.validate):
(Benchmark.prototype.tearDown):

  • RexBench/cli.js:
  • RexBench/flightplan_benchmark.js:
  • RexBench/flightplan_unicode_benchmark.js:
  • RexBench/octane2_benchmark.js:
  • RexBench/stats.js:

(Stats.prototype.toString.return.span.0.span.span):

  • RexBench/sunspider_benchmark.js:
3:08 PM Changeset in webkit [220484] by commit-queue@webkit.org
  • 3 edits
    2 deletes in trunk

Unreviewed, rolling out r219334.
​https://bugs.webkit.org/show_bug.cgi?id=175398

Caused bug 175023 (Requested by ap on #webkit).

Reverted changeset:

"[SVG] Leak in SVGAnimatedListPropertyTearOff"
​https://bugs.webkit.org/show_bug.cgi?id=172545
​http://trac.webkit.org/changeset/219334

2:58 PM Changeset in webkit [220483] by Jonathan Bedard
  • 5 edits
    2 adds in trunk/Tools

Allow nested timeouts in webkitpy
​https://bugs.webkit.org/show_bug.cgi?id=175390
<rdar://problem/33803003>

Reviewed by David Kilzer.

We need to be able to nest timeouts in webkitpy. In particular, we have a few cases where functions
which use timeouts also call the executive. For on-device testing, we need to have timeouts inside
the executive to detect and recover from any issues connecting with devices.

  • Scripts/webkitpy/benchmark_runner/utils.py:

(TimeoutError): Deleted.
(timeout): Deleted.

  • Scripts/webkitpy/common/timeout_context.py: Added.

(Timeout): A timeout context designed to be nested.
(Timeout.TimeoutData): The data required to construct an alarm for a given timeout.
(Timeout.TimeoutData.init):
(Timeout.default_handler): Timeout handler used if none is specified.
(Timeout.current): Access data about the most urgent timeout.
(Timeout.init): Construct a Timeout object with seconds and an optional handler.
(Timeout._bind_timeout_data_to_alarm): Given data about a timeout, initialize an alarm for that timeout.
(Timeout.enter): Un-bind all alarms. Add data for this timeout to the ordered list and bind the most
urgent timeout data.
(Timeout.exit): Un-bind all alarms. Remove data for this timeout from the ordered list and bind the
most urgent timeout data, if such data exists.

  • Scripts/webkitpy/common/timeout_context_unittest.py: Added.

(TimeoutContextTests):
(TimeoutContextTests.test_current_timeout): Test that accessing the nearest timeout works as expected.
(TimeoutContextTests.test_invalid_timeout): Test a timeout of 0.
(TimeoutContextTests.test_timeout_data): Confirm that timeouts are constructed correctly.
(TimeoutContextTests.test_nested_inner_precedence): Check that a more urgent inner timeout takes precedence
over a less urgent outer timeout.
(TimeoutContextTests.test_nested_outer_precedence): Check that a more urgent outer timeout takes precedence
over a less urgent inner timeout.
(TimeoutContextTests.test_no_timeout): Test a block of code without a timeout.
(TimeoutContextTests.test_basic_timeout): Test a block of code expected to timeout.
(TimeoutContextTests.test_exception_constructor_timeout): Test a timeout where the handler is an exception.
(TimeoutContextTests.test_nested_inner_timeout): Confirm that a more urgent inner timeout is triggered.
(TimeoutContextTests.test_nested_outer_timeout): Confirm that a more urgent outer timeout is triggered.

  • Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess._start): Use Timeout class.

  • Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDevice.launch_app._log_debug_error): Use Timeout class.
(SimulatedDevice.launch_app): Ditto.
(SimulatedDevice.launch_app._install_timeout): Deleted.

  • Scripts/webkitpy/xcode/simulator.py:

(Simulator.wait_until_device_is_booted):Use Timeout class.
(Simulator.wait_until_device_is_in_state): Ditto.

2:57 PM Changeset in webkit [220482] by Ryan Haddad
  • 7 edits in branches/safari-604.1.38.1-branch/LayoutTests

Unreviwed test gardening. rdar://problem/33789505

2:34 PM Changeset in webkit [220481] by caitp@igalia.com
  • 6 edits in trunk

Early error on ANY operator before new.target
​https://bugs.webkit.org/show_bug.cgi?id=157970

Reviewed by Saam Barati.

Instead of throwing if any unary operator precedes new.target, only
throw if the unary operator updates the reference.

The following become legal in JSC:

`
!new.target
~new.target
typeof new.target
delete new.target
void new.target
`

All of which are legal in v8 and SpiderMonkey in strict and sloppy mode

JSTests:

  • stress/new-target-syntax-errors.js:
  • stress/new-target.js:

Source/JavaScriptCore:

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseUnaryExpression):

2:03 PM Changeset in webkit [220480] by mitz@apple.com
  • 9 copies
    1 add in releases/Apple/Safari Technology Preview 37

Added a tag for Safari Technology Preview release 37.

2:03 PM Changeset in webkit [220479] by hyatt@apple.com
  • 6 edits in trunk/Source/WebCore

[Repaint from Layout Removal] Move layer repaint rects into a map
​https://bugs.webkit.org/show_bug.cgi?id=175393

Reviewed by Zalan Bujtas.

Move the two repaint rects held by RenderLayer into a RenderLayerModelObject -> RepaintLayoutRects hash map.
RepaintLayoutRects is a new struct that holds both rects.

Eventually more objects than just self painting layers will be caching repaint rects, so this takes a first
step towards having a common cache for these repaint rects. In addition this change saves memory, since
layers that aren't self-painting no longer have empty repaint rects taking up space in RenderLayer.

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::layoutRunsAndFloats):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::repaintRectIncludingNonCompositingDescendants):
(WebCore::RenderLayer::computeRepaintRects):
(WebCore::RenderLayer::clearRepaintRects):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
(WebCore::RenderLayer::scrollTo):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerModelObject.cpp:

(WebCore::RepaintLayoutRects::RepaintLayoutRects):
(WebCore::RenderLayerModelObject::willBeDestroyed):
(WebCore::RenderLayerModelObject::destroyLayer):
(WebCore::RenderLayerModelObject::styleDidChange):
(WebCore::RenderLayerModelObject::hasRepaintLayoutRects):
(WebCore::RenderLayerModelObject::setRepaintLayoutRects):
(WebCore::RenderLayerModelObject::clearRepaintLayoutRects):
(WebCore::RenderLayerModelObject::repaintLayoutRects):
(WebCore::RenderLayerModelObject::computeRepaintLayoutRects):

  • rendering/RenderLayerModelObject.h:

(WebCore::RepaintLayoutRects::RepaintLayoutRects):

2:02 PM Changeset in webkit [220478] by weinig@apple.com
  • 4 edits in trunk/Source

Update reviewer

1:57 PM Changeset in webkit [220477] by commit-queue@webkit.org
  • 8 edits in trunk/Source

WTF::Function does not allow for reference / non-default constructible return types
​https://bugs.webkit.org/show_bug.cgi?id=175244

Patch by Sam Weinig <​sam@webkit.org> on 2017-08-09
Reviewed by Sam Weinig.

Source/JavaScriptCore:

  • runtime/ArrayBuffer.cpp:

(JSC::ArrayBufferContents::transferTo):
Call reset(), rather than clear() to avoid the call to destroy() in clear(). The
destroy call needed to be a no-op anyway, since the data is being moved.

Source/WebCore:

  • bindings/js/JSCustomElementInterface.h:

(WebCore::JSCustomElementInterface::invokeCallback):
Update the default value for the addArguments parameter to be an empty lambda, rather than
default initialization, which leads to a null WTF::Function. This allows us to remove support
for calling null WTF::Function. No change in behavior.

Source/WebKit:

  • UIProcess/WebResourceLoadStatisticsStore.h:

Update the default value for the updateCookiePartitioningForDomainsHandler parameter to be an
empty lambda, rather than default initialization, which leads to a null WTF::Function. This allows
us to remove support for calling null WTF::Function. No change in behavior.

Source/WTF:

When Function, then NoncopyableFunction, was templatized to allow non-void return values
in r201493, it maintained the behavior of being callable even if the Function was null.
To accomplish this, when null, the default construction of the return parameter was used.
This means Function can't be used with return types that are not default constructible,
such as reference types and Ref.

This behavior of returning something when null is surprising, as this is not how normal
functions behave, and not very useful. Instead, we now assert that the function is not
null when being called.

  • wtf/Function.h:

(WTF::Function operator(...)):
Instead of allowing a null callable wrapper by returning the default construction of
the return type, assert that the wrapper is there when calling a Function.

1:28 PM Changeset in webkit [220476] by dbates@webkit.org
  • 6 edits
    570 adds in trunk/LayoutTests

Import CSS-UI-3 Web Platform Tests
​https://bugs.webkit.org/show_bug.cgi?id=175294

Reviewed by Zalan Bujtas.

LayoutTests/imported/w3c:

  • resources/import-expectations.json:
  • resources/resource-files.json:
  • web-platform-tests/css/css-ui-3/OWNERS: Added.
  • web-platform-tests/css/css-ui-3/box-sizing-001-expected.html: Added.
  • web-platform-tests/css/css-ui-3/box-sizing-001.html: Added.
  • web-platform-tests/css/css-ui-3/box-sizing-003-expected.html: Added.
  • web-platform-tests/css/css-ui-3/box-sizing-003.html: Added.
  • web-platform-tests/css/css-ui-3/box-sizing-005-expected.html: Added.
  • web-platform-tests/css/css-ui-3/box-sizing-005.html: Added.
  • web-platform-tests/css/css-ui-3/box-sizing-007-expected.html: Added.
  • web-platform-tests/css/css-ui-3/box-sizing-007.html: Added.

[truncated]

LayoutTests:

Mark tests that we currently failure.

1:25 PM Changeset in webkit [220475] by beidson@apple.com
  • 18 edits in trunk/Source/WebCore

Teach ScriptExecutionContexts about their SessionID.
​https://bugs.webkit.org/show_bug.cgi?id=175391

Reviewed by Andy Estes.

No new tests (No current change in behavior).

Turns out that Workers need to know their SessionID for future feature development.
So let's teach it to them.

  • dom/ScriptExecutionContext.h: Expose a pure virtual SessionID accessor.
  • dom/Document.cpp:

(WebCore::Document::sessionID const):

  • dom/Document.h:
  • page/SessionID.cpp:

(WebCore::SessionID::isolatedCopy const):

  • page/SessionID.h:
  • workers/DedicatedWorkerGlobalScope.cpp:

(WebCore::DedicatedWorkerGlobalScope::create):
(WebCore::DedicatedWorkerGlobalScope::DedicatedWorkerGlobalScope):

  • workers/DedicatedWorkerGlobalScope.h:
  • workers/DedicatedWorkerThread.cpp:

(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope):

  • workers/DedicatedWorkerThread.h:
  • workers/Worker.cpp:

(WebCore::Worker::notifyFinished):

  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope):

  • workers/WorkerGlobalScope.h:
  • workers/WorkerGlobalScopeProxy.h:
  • workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):

  • workers/WorkerMessagingProxy.h:
  • workers/WorkerThread.cpp:

(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::workerThread):

  • workers/WorkerThread.h:
1:08 PM Changeset in webkit [220474] by Matt Lewis
  • 3 edits in trunk/LayoutTests

Marked http/tests/media/video-buffered-range-contains-currentTime.html as flaky on High Sierra
<rdar://problem/33555759>

Unreviewed test gardening.

  • platform/mac-highsierra-wk2/TestExpectations:
  • platform/mac/TestExpectations:
12:15 PM Changeset in webkit [220473] by Wenson Hsieh
  • 12 edits in trunk

[iOS DnD] ENABLE_DRAG_SUPPORT should be turned off for iOS 10 and enabled by default
​https://bugs.webkit.org/show_bug.cgi?id=175392
<rdar://problem/33783207>

Reviewed by Tim Horton and Megan Gardner.

Tweak FeatureDefines to enable drag and drop by default, and disable only on unsupported platforms (i.e. iOS 10).
Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No change in behavior.

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
12:13 PM Changeset in webkit [220472] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk

Old subtitle track is not deleted on 'src' attribute change event
​https://bugs.webkit.org/show_bug.cgi?id=175031

Patch by Kirill Ovchinnikov <​kirill.ovchinnikov@lge.com> on 2017-08-09
Reviewed by Eric Carlson.

Source/WebCore:

Test: media/track/text-track-src-change.html

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::textTrackReadyStateChanged):

  • html/HTMLTrackElement.cpp:

(WebCore::HTMLTrackElement::loadTimerFired):

  • html/shadow/MediaControls.cpp:

(WebCore::MediaControls::clearTextDisplayContainer):

  • html/shadow/MediaControls.h:

LayoutTests:

  • media/track/text-track-src-change-expected.txt: Added.
  • media/track/text-track-src-change.html: Added.
11:31 AM Changeset in webkit [220471] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Make JSC_validateExceptionChecks=1 succeed on JSTests/stress/v8-deltablue-strict.js.
​https://bugs.webkit.org/show_bug.cgi?id=175358

Patch by Robin Morisset <​rmorisset@apple.com> on 2017-08-09
Reviewed by Mark Lam.

  • jit/JITOperations.cpp:
  • runtime/JSObjectInlines.h:

(JSC::JSObject::putInlineForJSObject):

11:24 AM Changeset in webkit [220470] by jmarcell@apple.com
  • 3 edits in branches/safari-604.1.38.1-branch/Source/JavaScriptCore

Cherry-pick r220346. rdar://problem/33805219

11:14 AM Changeset in webkit [220469] by jmarcell@apple.com
  • 3 edits
    4 adds in branches/safari-604.1.38.0-branch

Cherry-pick r220456. rdar://problem/33805190

11:14 AM Changeset in webkit [220468] by jmarcell@apple.com
  • 3 edits in branches/safari-604.1.38.0-branch/Source/JavaScriptCore

Cherry-pick r220346. rdar://problem/33805223

11:05 AM Changeset in webkit [220467] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit

ServiceWorker experimental feature should not be on by default (definitely not ready).
​https://bugs.webkit.org/show_bug.cgi?id=175389

Rubberstamped by Andy Estes.

  • Shared/WebPreferencesDefinitions.h: false, not DEFAULT_EXPERIMENTAL_FEATURES_ENABLED
11:03 AM Changeset in webkit [220466] by weinig@apple.com
  • 2 edits in trunk/Tools

Update for ​https://bugs.webkit.org/show_bug.cgi?id=175244.

  • TestWebKitAPI/Tests/WTF/Function.cpp:

Remove tests of null Functions, as they are no longer supported.

10:58 AM Changeset in webkit [220465] by Ryan Haddad
  • 8 edits in trunk/Source

Unreviewed, rolling out r220457.

This change introduced API test failures.

Reverted changeset:

"WTF::Function does not allow for reference / non-default
constructible return types"
​https://bugs.webkit.org/show_bug.cgi?id=175244
​http://trac.webkit.org/changeset/220457

10:53 AM Changeset in webkit [220464] by don.olmstead@sony.com
  • 2 edits in trunk/Source/WebCore

[WinCairo] Fix build after rev 220399
​https://bugs.webkit.org/show_bug.cgi?id=175360

Reviewed by Žan Doberšek.

No new tests. No change in behavior.

  • platform/graphics/texmap/TextureMapperGLHeaders.h:
10:52 AM Changeset in webkit [220463] by n_wang@apple.com
  • 3 edits
    3 adds in trunk

AX: crash at WebCore::AccessibilityObject::supportsARIALiveRegion() const + 24
​https://bugs.webkit.org/show_bug.cgi?id=175340
<rdar://problem/33782159>

Reviewed by Chris Fleizach.

Source/WebCore:

When adding a psuedo element child to a RenderBlockFlow element, there might be a chance where
the element has already been layed out but we are still holding onto its stale children. Fixed it
by notifying AX correctly when inserting/removing children during layout.

Test: accessibility/add-children-pseudo-element.html

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::insertFloatingObject):
(WebCore::RenderBlockFlow::removeFloatingObject):

LayoutTests:

  • accessibility/add-children-pseudo-element-expected.txt: Added.
  • accessibility/add-children-pseudo-element.html: Added.
  • accessibility/resources/svg-circle.svg: Added.
10:46 AM Changeset in webkit [220462] by Nikita Vasilyev
  • 3 edits
    1 add in trunk/Source/WebInspectorUI

Web Inspector: Styles: Add pre-populated data to spreadsheet-style view
​https://bugs.webkit.org/show_bug.cgi?id=174838
<rdar://problem/33523220>

Reviewed by Matt Baker.

This patch adds static content to the experimental RulesStyleSpreadsheetDetailsPanel.
The static content will be replaced with actual data in the follow up patches.

  • UserInterface/Main.html:
  • UserInterface/Views/RulesStyleSpreadsheetDetailsPanel.css: Added.

(.style-spreadsheet .style-rule):
(.style-spreadsheet .selector-line):
(.style-spreadsheet .selector):
(.style-spreadsheet :matches(.selector .matched, .selector:focus)):
(.style-spreadsheet .name):
(.style-spreadsheet .value):
(.style-spreadsheet :matches(.selector, .name, .value)):
(.style-spreadsheet :matches(.selector, .name, .value):focus):
(.style-spreadsheet .selector-inline):
(.style-spreadsheet .property):
(.style-spreadsheet .property-disabled,):
(.style-spreadsheet .property-disabled :matches(.name, .value)):
(.style-spreadsheet .styles-source):
(.style-spreadsheet :matches(a, .node-link)):
(.style-spreadsheet :matches(a, .node-link):hover):
(.style-spreadsheet .inherited):
(.style-spreadsheet .declarations):
(.style-spreadsheet input[type="checkbox"]):
(.style-spreadsheet input[type="checkbox"]:not(:checked)):
(.style-spreadsheet .declarations:hover input[type="checkbox"]):

  • UserInterface/Views/RulesStyleSpreadsheetDetailsPanel.js:
10:23 AM Changeset in webkit [220461] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GStreamer][MSE] Add missing lock around getStreamByTrackId
​https://bugs.webkit.org/show_bug.cgi?id=175323

Patch by Charlie Turner <​cturner@igalia.com> on 2017-08-09
Reviewed by Xabier Rodriguez-Calvar.

Covered by existing tests.

  • platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:

(WebCore::PlaybackPipeline::enqueueSample): Ensure the media source
lock is taken before modifiying the track queues indirectly via the
iterator use in getTrackId.

9:41 AM Changeset in webkit [220460] by commit-queue@webkit.org
  • 5 edits
    2 adds
    1 delete in trunk/LayoutTests

WPE-focused test gardening.
​https://bugs.webkit.org/show_bug.cgi?id=175385

Unreviewed test gardening.

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-09

  • platform/wpe/TestExpectations: Marked failing tests.
  • platform/wpe/fast/events/touch/basic-single-touch-events-expected.txt: Added platform-specific expectation.
  • platform/wpe/js/date-timeClip-large-values-expected.txt: Removed (the platform-neutral expectation is fine).
  • platform/wpe/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Updated for Cache enabling.
  • transitions/clip-path-path-transitions-expected.txt: Updated for test change in r219243.
  • transitions/resources/transition-test-helpers.js:

(parseClipPath): Updated to support the quotes in clip-path-path-transitions.html

9:30 AM Changeset in webkit [220459] by dbates@webkit.org
  • 21 edits in trunk

REGRESSION (r219013): OAuth flows are broken when redirecting back to application after authentication
​https://bugs.webkit.org/show_bug.cgi?id=175247
<rdar://problem/33679804>

Reviewed by Brady Eidson.

Source/WebCore:

Add SPI so that Safari can differentiate between a form submission and a redirected form submission
and have PolicyCheck notify the frame loader client if the navigation was in response to receiving a
redirect response. This is the WebKit portion to fix an issue when a native app makes use of an OAuth
OAuth flow that bounces to Safari for user login and then bounce back to the app. Microsoft Graph's
OAuth flow is one example.

Safari was differentiating between a form submission and a redirected form submission based on the
nullity of WKNavigationAction.sourceFrame because in both cases the navigation type was WKNavigationTypeFormSubmitted.
The navigation type is the same for both navigations because WebKit always used the navigation
action from the original request for the redirect request when the original request redirected.
Prior to r219013, WKNavigationAction.sourceFrame would be nil for a form submission that redirects.
Following r219013, WKNavigationAction.sourceFrame is non-nil unless the navigation was initiated by
API. In particular, WKNavigationAction.sourceFrame is non-nil for the redirect navigation corresponding
to a form submission that redirects.

  • loader/EmptyClients.cpp:

(WebCore::EmptyFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

  • loader/FrameLoaderClient.h:

Have dispatchDecidePolicyForNavigationAction() take a boolean as to whether the navigation was in
response to receiving a redirect response.

  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::checkNavigationPolicy): Notify the frame loader client whether the navigation
is in response to receiving a redirect response.

Source/WebKit:

Add SPI WKNavigationAction._isRedirect to query whether the navigation was in response to receiving
a redirect response. The majority of the WebKit change is plumbing this knowledge through to connect
it with the SPI.

  • Shared/NavigationActionData.cpp:

(WebKit::NavigationActionData::encode const):
(WebKit::NavigationActionData::decode):
Encode and decode the boolean NavigationActionData::isRedirect.

  • Shared/NavigationActionData.h:
  • UIProcess/API/APINavigationAction.h:
  • UIProcess/API/Cocoa/WKNavigationAction.mm:

(-[WKNavigationAction _isRedirect]): Added.

  • UIProcess/API/Cocoa/WKNavigationActionPrivate.h:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction): Set NavigationActionData::isRedirect
depending on whether the navigation is in response to receiving a redirect response.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKitLegacy/mac:

Plumb knowledge of whether a navigation was in response to receiving a redirect response.
We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
clients that need to make use of this information at this time. If such a needs comes up
then we can expose API/SPI similar to what we do for WebKit.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Source/WebKitLegacy/win:

Plumb knowledge of whether a navigation was in response to receiving a redirect response.
We do not actually make use of this knowledge in WebKitLegacy because we do not know of any
clients that need to make use of this information at this time. If such a needs comes up
then we can expose API/SPI similar to what we do for WebKit.

  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

  • WebCoreSupport/WebFrameLoaderClient.h:

Tools:

Add tests for redirects.

  • TestWebKitAPI/Tests/WebKit2Cocoa/DecidePolicyForNavigationAction.mm:

(TEST):

  • TestWebKitAPI/cocoa/TestProtocol.mm:

(createRedirectURL):
(-[TestProtocol startLoading]):

9:02 AM Changeset in webkit [220458] by Ryan Haddad
  • 3 edits in trunk/JSTests

Skip failing JSC tests stress/regress-169783.js and wasm.yaml/wasm/stress/oom.js.
​https://bugs.webkit.org/show_bug.cgi?id=175255

Unreviewed test gardening.

  • stress/regress-169783.js:
  • wasm/stress/oom.js:
8:59 AM Changeset in webkit [220457] by commit-queue@webkit.org
  • 8 edits in trunk/Source

WTF::Function does not allow for reference / non-default constructible return types
​https://bugs.webkit.org/show_bug.cgi?id=175244

Patch by Sam Weinig <​sam@webkit.org> on 2017-08-09
Reviewed by Chris Dumez.

Source/JavaScriptCore:

  • runtime/ArrayBuffer.cpp:

(JSC::ArrayBufferContents::transferTo):
Call reset(), rather than clear() to avoid the call to destroy() in clear(). The
destroy call needed to be a no-op anyway, since the data is being moved.

Source/WebCore:

  • bindings/js/JSCustomElementInterface.h:

(WebCore::JSCustomElementInterface::invokeCallback):
Update the default value for the addArguments parameter to be an empty lambda, rather than
default initialization, which leads to a null WTF::Function. This allows us to remove support
for calling null WTF::Function. No change in behavior.

Source/WebKit:

  • UIProcess/WebResourceLoadStatisticsStore.h:

Update the default value for the updateCookiePartitioningForDomainsHandler parameter to be an
empty lambda, rather than default initialization, which leads to a null WTF::Function. This allows
us to remove support for calling null WTF::Function. No change in behavior.

Source/WTF:

When Function, then NoncopyableFunction, was templatized to allow non-void return values
in r201493, it maintained the behavior of being callable even if the Function was null.
To accomplish this, when null, the default construction of the return parameter was used.
This means Function can't be used with return types that are not default constructible,
such as reference types and Ref.

This behavior of returning something when null is surprising, as this is not how normal
functions behave, and not very useful. Instead, we now assert that the function is not
null when being called.

  • wtf/Function.h:

(WTF::Function operator(...)):
Instead of allowing a null callable wrapper by returning the default construction of
the return type, assert that the wrapper is there when calling a Function.

8:52 AM Changeset in webkit [220456] by aestes@apple.com
  • 3 edits
    4 adds in trunk

[QuickLook] Use case-insensitive comparison of preview MIME types
​https://bugs.webkit.org/show_bug.cgi?id=175350
<rdar://problem/33761159>

Reviewed by Brady Eidson.

Source/WebCore:

MIME types are case-insensitive, but PreviewLoader was using a case-sensitive comparison to
determine if a MIME type was supported by QLPreviewConverter. As a result we would fail to
preview Excel macro-enabled workbooks, since CFNetwork would sniff a MIME type of
"application/vnd.ms-excel.sheet.macroEnabled.12" but QuickLook contained
"application/vnd.ms-excel.sheet.macroenabled.12" in its set of supported MIME type strings.

Fix this by copying the QuickLook supported MIME type set into a HashSet using
ASCIICaseInsensitiveHash and using that HashSet for MIME type checks.

Test: quicklook/excel-macro-enabled.html

  • loader/ios/PreviewLoader.mm:

(WebCore::PreviewLoader::shouldCreateForMIMEType):

LayoutTests:

  • platform/ios-11/quicklook/excel-macro-enabled-expected.txt: Added.
  • quicklook/excel-macro-enabled-expected.txt: Added.
  • quicklook/excel-macro-enabled.html: Added.
  • quicklook/resources/excel-macro-enabled.xlsm: Added.
7:35 AM WebKitGTK/StableRelease edited by Adrian Perez de Castro
Added 2.18.x (diff)
6:25 AM Changeset in webkit [220455] by zandobersek@gmail.com
  • 2 edits in trunk/LayoutTests

Unreviewed WPE gardening.

  • platform/wpe/TestExpectations: Stop skipping the whole fast/

directory and then unskipping specific subdirectories since
that overrides any expectations coming from the generic WK2
TestExpectations file. Specific subdirectories that we haven't
yet generated results for are now skipped instead.

6:06 AM Changeset in webkit [220454] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Remove unnecessary copies of PlatformMediaSessionManager::m_sessions
​https://bugs.webkit.org/show_bug.cgi?id=175375

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-09
Reviewed by Sam Weinig.

Remove unnecessary copies of PlatformMediaSessionManager::m_sessions.

These should have been removed in r207688.

No new tests: no behavior change.

  • platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::applicationWillBecomeInactive const):
(WebCore::PlatformMediaSessionManager::applicationDidBecomeActive const):
(WebCore::PlatformMediaSessionManager::applicationDidEnterBackground const):
(WebCore::PlatformMediaSessionManager::applicationWillEnterForeground const):

6:04 AM Changeset in webkit [220453] by Chris Dumez
  • 11 edits in trunk

Reinstate active flag for iterators
​https://bugs.webkit.org/show_bug.cgi?id=175312

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

Resync WPT tests from upstream to gain test coverage.

  • web-platform-tests/dom/traversal/NodeIterator-expected.txt:
  • web-platform-tests/dom/traversal/NodeIterator.html:
  • web-platform-tests/dom/traversal/TreeWalker-expected.txt:
  • web-platform-tests/dom/traversal/TreeWalker.html:

Source/WebCore:

NodeIterator / TreeWalker should no longer allow recursive filters
after the following change to the DOM specification:

This patch aligns our behavior with the latest specification.

No new tests, updated existing tests.

  • dom/NodeIterator.cpp:

(WebCore::NodeIterator::nextNode):
(WebCore::NodeIterator::previousNode):
Note that we now also call m_candidateNode.clear() before returning an
exception. This was a pre-existing bug that we failed to do so in the
exception case but it became more obvious after this change now that
we throw. This was causing traversal/moz-bug559526.html to fail
otherwise (the filter was called one too many times). The test case
is passing in Firefox (The filter is called 4 times and they throw
each time).

  • dom/Traversal.cpp:

(WebCore::NodeIteratorBase::NodeIteratorBase):
(WebCore::NodeIteratorBase::acceptNode):

  • dom/Traversal.h:
  • dom/TreeWalker.cpp:
3:48 AM Changeset in webkit [220452] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.17.90

WebKitGTK+ 2.17.90

3:48 AM Changeset in webkit [220451] by Carlos Garcia Campos
  • 4 edits in releases/WebKitGTK/webkit-2.18

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.17.90 release.

.:

  • Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

  • gtk/NEWS: Add release notes for 2.17.90.
2:22 AM Changeset in webkit [220450] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

[GTK] [WPE] Update expectations for global-constructors-attributes.html.
​https://bugs.webkit.org/show_bug.cgi?id=175373

Unreviewed test gardening.

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-09

  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
  • platform/wpe/js/dom/global-constructors-attributes-expected.txt:
2:17 AM Changeset in webkit [220449] by gskachkov@gmail.com
  • 5 edits in trunk

REGRESSION: 2 test262/test/language/statements/async-function failures
​https://bugs.webkit.org/show_bug.cgi?id=175334

Reviewed by Yusuke Suzuki.

JSTests:

Add @skip parameters to tests, and remove test for async iterator from
async await syntax test because it is already covered by async-iterator-syntax.js

  • stress/async-await-syntax.js:
  • stress/async-iteration-syntax.js:

Source/JavaScriptCore:

Switch off useAsyncIterator by default

  • runtime/Options.h:
2:11 AM WebKitGTK/2.18.x created by Carlos Garcia Campos
1:22 AM WebKitGTK/2.16.x edited by tpopela@redhat.com
(diff)
1:14 AM WebKitGTK/2.16.x edited by tpopela@redhat.com
(diff)
12:46 AM Changeset in webkit [220448] by Carlos Garcia Campos
  • 1 copy in releases/WebKitGTK/webkit-2.18

Branch WebKitGTK+ for 2.18

12:36 AM Changeset in webkit [220447] by Antti Koivisto
  • 10 edits in trunk/Source/WebCore

RenderQuote should not mutate render tree
​https://bugs.webkit.org/show_bug.cgi?id=175328

Reviewed by Zalan Bujtas.

RenderQuote text renderers are currently created and deleted in a quirky fashion using a linked list.
This patch moves to a simpler model that guarantees the mutations are always done in controlled fashion
during render tree update.

  • dom/Document.cpp:

(WebCore::Document::updateTextRenderer):

Move text renderer updating to Document so we can set the inRenderTreeUpdate bit for it too.

  • dom/Document.h:
  • dom/Text.cpp:

(WebCore::Text::updateRendererAfterContentChange):

  • rendering/RenderDescendantIterator.h:

(WebCore::RenderDescendantIteratorAdapter<T>::at):
(WebCore::RenderDescendantConstIteratorAdapter<T>::at const):

Add at() function for starting iteration from a specified renderer.

  • rendering/RenderQuote.cpp:

(WebCore::RenderQuote::insertedIntoTree):
(WebCore::RenderQuote::willBeRemovedFromTree):

Register and unregister quotes to RenderView.
Don't do any mutations.

(WebCore::RenderQuote::styleDidChange):

Invalidate the text renderer but don't mutate it.

(WebCore::RenderQuote::updateTextRenderer):
(WebCore::RenderQuote::computeText const):
(WebCore::RenderQuote::updateRenderers):

Compute depth of all render quotes and update the text renderer as needed.

(WebCore::RenderQuote::willBeDestroyed): Deleted.
(WebCore::RenderQuote::attachQuote): Deleted.
(WebCore::RenderQuote::detachQuote): Deleted.
(WebCore::RenderQuote::updateDepth): Deleted.

Get rid of the linked list.

  • rendering/RenderQuote.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::registerQuote):
(WebCore::RenderView::unregisterQuote):

Maintain a render tree order ListHashSet of RenderQuotes.

(WebCore::RenderView::updateSpecialRenderers):

Add a function for making additional render tree mutations at the end of a render tree update.
Currently this just invokes RenderQuote::updateRenderers.

  • rendering/RenderView.h:
  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::commit):

Call RenderView::updateSpecialRenderers after committing all other changes.

12:16 AM Changeset in webkit [220446] by zandobersek@gmail.com
  • 2 edits in trunk

[WPE] Enable SUBTLE_CRYPTO in release builds
​https://bugs.webkit.org/show_bug.cgi?id=175371

Reviewed by Carlos Garcia Campos.

  • Source/cmake/OptionsWPE.cmake:

Use ON as the default port value for ENABLE_SUBTLE_CRYPTO in WPE.

12:13 AM Changeset in webkit [220445] by Carlos Garcia Campos
  • 2 edits in trunk

[GTK] Enable SUBTLE_CRYPTO in GTK+ releases
​https://bugs.webkit.org/show_bug.cgi?id=172758

Reviewed by Žan Doberšek.

Add ENABLE_WEB_CRYPTO public option and make ENABLE_SUBTLE_CRYPTO depend on it.

  • Source/cmake/OptionsGTK.cmake:
12:00 AM Changeset in webkit [220444] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

[Soup] Incorrect conversion in msToSoupDate()
​https://bugs.webkit.org/show_bug.cgi?id=175320

Reviewed by Carlos Garcia Campos.

Original patch by VaL Doroshchuk.

  • platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::msToSoupDate): monthFromDayInYear() returns a value in the [0,11] range,
while soup_date_new() expects a month value in the [1,12] range. The return value
must be thus incremented by one to match that expectation.

Aug 8, 2017:

10:36 PM Changeset in webkit [220443] by Wenson Hsieh
  • 29 edits
    4 deletes in trunk

Unreviewed, rolling out r220393.

This patch regresses the performance of WebPage::editorState.

Reverted changeset:

"[iOS WK2] WKWebView schedules nonstop layout after pressing
cmb+b,i,u inside a contenteditable div"
​https://bugs.webkit.org/show_bug.cgi?id=175116
​http://trac.webkit.org/changeset/220393

10:15 PM Changeset in webkit [220442] by Chris Dumez
  • 28 edits
    17 adds in trunk

[Beacon] Add support for CORS-preflighting for WK2 / NETWORK_SESSION
​https://bugs.webkit.org/show_bug.cgi?id=175264
<rdar://problem/33547793>

Reviewed by Youenn Fablet.

Source/WebCore:

Pass additional information when creating a PingHandle so that the PingLoad
can deal with CORS-preflighting on Network process side.

Tests: http/wpt/beacon/cors/cors-preflight-arraybufferview-failure.html

http/wpt/beacon/cors/cors-preflight-arraybufferview-success.html
http/wpt/beacon/cors/cors-preflight-blob-failure.html
http/wpt/beacon/cors/cors-preflight-blob-success.html
http/wpt/beacon/cors/cors-preflight-cookie.html

  • WebCore.xcodeproj/project.pbxproj:
  • loader/CrossOriginAccessControl.cpp:

(WebCore::validatePreflightResponse):

  • loader/CrossOriginAccessControl.h:
  • loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::validatePreflightResponse):

  • loader/CrossOriginPreflightResultCache.h:
  • loader/LoaderStrategy.h:
  • loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::startPingLoad):

  • loader/PingLoader.h:
  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • page/SecurityOrigin.h:

Source/WebKit:

Implement CORS-preflighting for beacons with a payload that has a non
safelisted MIME type, as per:

CORS-preflighting is completely handled on Network Process side because
a beacon request can outlive its page and therefore its WebContent
process. This requires us to pass a little more information to the
Network process, in particular the source origin and the corsMode.

The current implementation does not currently deal with CORS preflights
needed upon a redirect. This will be added in a follow-up.

  • CMakeLists.txt:
  • NetworkProcess/NetworkCORSPreflightChecker.cpp: Added.

(WebKit::NetworkCORSPreflightChecker::NetworkCORSPreflightChecker):
(WebKit::NetworkCORSPreflightChecker::~NetworkCORSPreflightChecker):
(WebKit::NetworkCORSPreflightChecker::startPreflight):
(WebKit::NetworkCORSPreflightChecker::willPerformHTTPRedirection):
(WebKit::NetworkCORSPreflightChecker::didReceiveChallenge):
(WebKit::NetworkCORSPreflightChecker::didReceiveResponseNetworkSession):
(WebKit::NetworkCORSPreflightChecker::didReceiveData):
(WebKit::NetworkCORSPreflightChecker::didCompleteWithError):
(WebKit::NetworkCORSPreflightChecker::didSendData):
(WebKit::NetworkCORSPreflightChecker::wasBlocked):
(WebKit::NetworkCORSPreflightChecker::cannotShowURL):

  • NetworkProcess/NetworkCORSPreflightChecker.h: Added.
  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::loadPing):

  • NetworkProcess/NetworkConnectionToWebProcess.h:
  • NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):

  • NetworkProcess/NetworkResourceLoadParameters.h:
  • NetworkProcess/PingLoad.cpp: Added.

(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::~PingLoad):
(WebKit::PingLoad::startNetworkLoad):
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::didReceiveChallenge):
(WebKit::PingLoad::didReceiveResponseNetworkSession):
(WebKit::PingLoad::didReceiveData):
(WebKit::PingLoad::didCompleteWithError):
(WebKit::PingLoad::didSendData):
(WebKit::PingLoad::wasBlocked):
(WebKit::PingLoad::cannotShowURL):
(WebKit::PingLoad::timeoutTimerFired):
(WebKit::PingLoad::needsCORSPreflight const):
(WebKit::PingLoad::doCORSPreflight):

  • NetworkProcess/PingLoad.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::createPingHandle):

  • WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

createPingHandle() now takes new parameters but there is currently no behavior
change on WebKit1.

  • WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::createPingHandle):

  • WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

Add layout test coverage.

  • http/wpt/beacon/cors/cors-preflight-arraybufferview-failure-expected.txt: Added.
  • http/wpt/beacon/cors/cors-preflight-arraybufferview-failure.html: Added.
  • http/wpt/beacon/cors/cors-preflight-arraybufferview-success-expected.txt: Added.
  • http/wpt/beacon/cors/cors-preflight-arraybufferview-success.html: Added.
  • http/wpt/beacon/cors/cors-preflight-blob-failure-expected.txt: Added.
  • http/wpt/beacon/cors/cors-preflight-blob-failure.html: Added.
  • http/wpt/beacon/cors/cors-preflight-blob-success-expected.txt: Added.
  • http/wpt/beacon/cors/cors-preflight-blob-success.html: Added.
  • http/wpt/beacon/cors/cors-preflight-cookie-expected.txt: Added.
  • http/wpt/beacon/cors/cors-preflight-cookie.html: Added.
  • http/wpt/beacon/resources/beacon-preflight.py: Added.

(respondToCORSPreflight):
(main):

  • http/wpt/beacon/resources/set-cookie.py: Added.

(main):

  • platform/mac-wk1/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/win/TestExpectations:
8:48 PM Changeset in webkit [220441] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

ICs should do caging
​https://bugs.webkit.org/show_bug.cgi?id=175295

Reviewed by Saam Barati.

Adds the appropriate cage() calls in our inline caches.

  • bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl):

  • bytecode/InlineAccess.cpp:

(JSC::InlineAccess::dumpCacheSizesAndCrash):
(JSC::InlineAccess::generateSelfPropertyAccess):
(JSC::InlineAccess::generateSelfPropertyReplace):
(JSC::InlineAccess::generateArrayLength):

8:24 PM Changeset in webkit [220440] by weinig@apple.com
  • 4 edits in trunk/Source/WebCore

Address review feedback from ​https://bugs.webkit.org/show_bug.cgi?id=175246.

  • bindings/js/DOMPromiseProxy.h:
  • css/FontFaceSet.cpp:
  • css/FontFaceSet.h:
8:18 PM Changeset in webkit [220439] by jmarcell@apple.com
  • 3 edits in branches/safari-604.1.38.1-branch/Source/WebKitLegacy/mac

Cherry-pick r220429. rdar://problem/33789343

8:18 PM Changeset in webkit [220438] by jmarcell@apple.com
  • 3 edits in branches/safari-604.1.38.1-branch

Cherry-pick r220289. rdar://problem/33789082

8:09 PM Changeset in webkit [220437] by jmarcell@apple.com
  • 3 edits in branches/safari-604.1.38.0-branch

Cherry-pick r220289. rdar://problem/33789085

6:55 PM Changeset in webkit [220436] by Devin Rousso
  • 12 edits
    2 adds in trunk

Web Inspector: Canvas: support editing WebGL shaders
​https://bugs.webkit.org/show_bug.cgi?id=124211
<rdar://problem/15448958>

Reviewed by Matt Baker.

Source/JavaScriptCore:

  • inspector/protocol/Canvas.json:

Add updateShader command that will change the given shader's source to the provided string,
recompile, and relink it to its associated program.
Drive-by: add description to requestShaderSource command.

Source/WebCore:

Test: inspector/canvas/updateShader.html

  • inspector/InspectorCanvasAgent.h:
  • inspector/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::updateShader):

  • html/canvas/WebGLRenderingContextBase.h:
  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::linkProgram):
(WebCore::WebGLRenderingContextBase::linkProgramWithoutInvalidatingAttribLocations):
Normally, when a program is linked, it invalidates any WebGLUniformLocation associated with
the program by incrementing its linkCount. In order to allow live editing of shaders, we
need to be able to compile and link a shader without invalidating these locations. This
patch moves the shader linking logic to its own function that is called by linkProgram so
that InspectorCanvasAgent can compile and link without invalidation.

Source/WebInspectorUI:

  • UserInterface/Models/ShaderProgram.js:

(WI.ShaderProgram.prototype.updateVertexShader):
(WI.ShaderProgram.prototype.updateFragmentShader):
(WI.ShaderProgram.prototype._updateShader):

  • UserInterface/Views/ShaderProgramContentView.js:

(WI.ShaderProgramContentView):
(WI.ShaderProgramContentView.prototype._contentDidChange):

LayoutTests:

  • inspector/canvas/updateShader-expected.txt: Added.
  • inspector/canvas/updateShader.html: Added.
  • platform/win/TestExpectations:
6:39 PM Changeset in webkit [220435] by Megan Gardner
  • 3 edits in trunk/Source/WebKit

Remove old and unused pointIsInAssistedNode definition
​https://bugs.webkit.org/show_bug.cgi?id=175335

Stage removal here to allow removal from UIKit.
Replaced by textInteractionGesture:shouldBeginAtPoint:

Reviewed by Tim Horton.

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView pointIsInAssistedNode:]): Deleted.

6:24 PM Changeset in webkit [220434] by commit-queue@webkit.org
  • 6 edits in trunk/Tools

Created Individual EWS Pages
​https://bugs.webkit.org/show_bug.cgi?id=174477

Patch by obinna obike <​oobike@apple.com> on 2017-08-08
Reviewed by Aakash Jain.

Created individual pages for each EWS. Changed the link within each status bubble
to go directly to the individual EWS page. Also added a link to original status page showing all EWSes.

  • QueueStatusServer/handlers/patch.py:

(Patch.get): Handles the case for individual ews queue as well as for all EWS queues.

  • QueueStatusServer/handlers/statusbubble.py:

(StatusBubble._build_bubble): Updated url for specific EWS.

  • QueueStatusServer/main.py: Added a link to the individual ews in the routes dictionary.
  • QueueStatusServer/templates/patch.html: Added a link to go directly to the page with

all ews queues.

  • QueueStatusServer/templates/statusbubble.html: If you click on a statusbubble it

takes you directly to the individual ews page.

6:01 PM Changeset in webkit [220433] by weinig@apple.com
  • 33 edits
    1 add
    5 deletes in trunk/Source/WebCore

[WebIDL] Add support for Promise<> attributes
​https://bugs.webkit.org/show_bug.cgi?id=175246

Reviewed by Yusuke Suzuki.

Introduces and adopts DOMPromiseProxy, a new class for binding promises in a more
straightforward and safe (from a wrapper world perspective) way.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSFontFaceCustom.cpp: Removed.
  • bindings/js/JSFontFaceSetCustom.cpp: Removed.
  • bindings/js/JSMediaKeySessionCustom.cpp: Removed.
  • bindings/js/JSServiceWorkerContainerCustom.cpp: Removed.
  • bindings/js/JSWebGPUCommandBufferCustom.cpp: Removed.

Remove custom bindings only needed for promise attributes. Add DOMPromiseProxy.h

  • Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::sessionClosed):
(WebCore::MediaKeySession::registerClosedPromise): Deleted.

  • Modules/encryptedmedia/MediaKeySession.h:
  • Modules/encryptedmedia/MediaKeySession.idl:

Replace custom promise code using the registerPromise idiom with DOMPromiseProxy.

  • bindings/IDLTypes.h:

Add StorageType type alias to allow specifying a specific form for storage. This allows
use to use Ref<> for interfaces in DOMPromiseProxy.

(WebCore::IDLWrapper::convertToParameterType):

Also add convertToParameterType, an annoying hack to workaround the fact WTF::Function
can't return references / no

  • bindings/js/DOMPromiseProxy.h: Added.

(WebCore::DOMPromiseProxy<IDLType>):

DOMPromiseProxy is a new class (set of classes) to represent promises that works with the
standard toJS<> / JSDOMConvert infrastructure used by the bindings generator. From the
implementation perspective, it is similar to DOMPromiseDeferred, but instead of receiving
one as a parameter, you can initialize it directly in your constructor and start using it.

From the bindings perspective, a DOMPromiseProxy can be converted into a JS Promise by calling
its promise function, which will either create a new promise, or return a cached one.

To make this work, DOMPromiseProxy maintains a Vector of DeferredPromises that hold onto those
actualized promises. The reason it has a Vector, is that we need one DeferredPromises per
DOMWrapperWorld, just like we need one wrapper for an interface per DOMWrapperWorld in the
wrapper cache. In most cases, only the normal world will be in play, so the Vector has an inline
capacity of one.


In addition, DOMPromiseProxy maintains a Variant of either an Exception or the result value type.
This allows the DOMPromiseProxy to be resolved or rejected at anytime. Then, when the bindings
request the promise, the stored result / exception can be resolved / rejected into the promise.

(WebCore::DOMPromiseProxy<IDLVoid>):

For void promises, we need slightly different semantics (resolve takes no parameters, Value is
a bit indicating resolved state), so it is specialized.

(WebCore::DOMPromiseProxyWithResolveCallback<IDLType>):

In addition to the void specialization, we have DOMPromiseProxyWithResolveCallback. Instead of
storing the value of the resolution directly, this specialization allows the owner to specify
callback to be called when the resolved value is needed. This is needed to avoid reference
cycles when the resolved value is the owner such as is the case with FontFace and FontFaceSet.

  • bindings/js/JSDOMConvertPromise.h:

(WebCore::JSConverter<IDLPromise<T>>::convert):
Add converter that calls through to the DOMPromiseProxy function promise.

  • bindings/js/JSDOMPromiseDeferred.cpp:

(WebCore::DeferredPromise::callFunction):
(WebCore::DeferredPromise::reject):

  • bindings/js/JSDOMPromiseDeferred.h:

(WebCore::DeferredPromise::create):
(WebCore::DeferredPromise::DeferredPromise):

Add a new create function for DeferredPromise that creates the JSPromiseDeferred for you.
Also adds a mode to DeferredPromise to allow keeping the promise after resolution. Maintain
the old behavior as the default.

Change reject to take an Exception as sink rather than an r-value, to allow DOMPromiseProxy
to copy a Exception into multiple DeferredPromises. For callers already moving into reject,
this should be no change.

  • bindings/scripts/CodeGeneratorJS.pm:

(AddToIncludesForIDLType):
(GenerateParametersCheck):
(GenerateImplementationFunctionCall):
(NativeToJSValueDOMConvertNeedsState):
(NativeToJSValueDOMConvertNeedsGlobalObject):

Add support DOMPromiseProxy. For now, this means a new extended attribute, [PromiseProxy],
but once I convert all the existing promises over to using DOMPromiseProxy, it will be removed.


Also specify the right #includes for promises and necessary parameters for conversion.

  • bindings/scripts/IDLAttributes.json:


Add [PromiseProxy], a temporary extended attribute for using DOMPromiseProxy.

  • css/FontFace.cpp:
  • css/FontFace.h:
  • css/FontFace.idl:
  • css/FontFaceSet.cpp:
  • css/FontFaceSet.h:
  • css/FontFaceSet.idl:

Replace custom promise code using the registerPromise idiom with DOMPromiseProxyWithResolveCallback.
The callback is necessary for these two classes since the value the resolve is themselves, and using
a normal resolve would create a cycle.

  • html/canvas/WebGPUCommandBuffer.cpp:
  • html/canvas/WebGPUCommandBuffer.h:
  • html/canvas/WebGPUCommandBuffer.idl:
  • platform/graphics/cocoa/GPUCommandBufferMetal.mm:
  • platform/graphics/gpu/GPUCommandBuffer.cpp:
  • platform/graphics/gpu/GPUCommandBuffer.h:

Replace custom promise code using the registerPromise idiom with DOMPromiseProxy.

  • page/NavigatorBase.cpp:

(WebCore::NavigatorBase::NavigatorBase):

  • page/NavigatorBase.h:

Forward declare ServiceWorkerContainer and add an explicit constructor to allow
removing #include of ServiceWorkerContainer.h in the header, avoiding an #include cycle.

  • workers/ServiceWorkerContainer.cpp:
  • workers/ServiceWorkerContainer.h:
  • workers/ServiceWorkerContainer.idl:

Replace custom promise code using the registerPromise idiom with DOMPromiseProxy.

  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:
  • bindings/scripts/test/TestObj.idl:

Add / update tests.

5:26 PM Changeset in webkit [220432] by commit-queue@webkit.org
  • 4 edits in trunk/Source/JavaScriptCore

Make JSC_validateExceptionChecks=1 succeed on JSTests/slowMicrobenchmarks/spread-small-array.js.
​https://bugs.webkit.org/show_bug.cgi?id=175347

Patch by Robin Morisset <​rmorisset@apple.com> on 2017-08-08
Reviewed by Saam Barati.

This is done by making finishCreation explicitely check for exceptions after setConstantRegister and setConstantIdentifiersSetRegisters.
I chose to have this check replace the boolean returned previously by these functions for readability. The performance impact should be
negligible considering how much more finishCreation does.
This fix then caused another issue to appear as it was now clear that finishCreation can throw. And since it is called by ProgramCodeBlock::create(),
FunctionCodeBlock::create() and friends, that are in turn called by ScriptExecutable::newCodeBlockFor, this last function also required a few tweaks.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::setConstantIdentifierSetRegisters):
(JSC::CodeBlock::setConstantRegisters):

  • bytecode/CodeBlock.h:
  • runtime/ScriptExecutable.cpp:

(JSC::ScriptExecutable::newCodeBlockFor):

5:18 PM Changeset in webkit [220431] by commit-queue@webkit.org
  • 2 edits
    1 add in trunk/Tools

Separate jsc stress test script writer from run-jsc-stress-tests
​https://bugs.webkit.org/show_bug.cgi?id=175216

Patch by Stephan Szabo <​stephan.szabo@sony.com> on 2017-08-08
Reviewed by Mark Lam.

  • Scripts/run-jsc-stress-tests:
  • Scripts/webkitruby/jsc-stress-test-writer-default.rb: Added.
5:03 PM Changeset in webkit [220430] by wilander@apple.com
  • 2 edits in trunk/Source/WebCore

Resource Load Statistics: Merge of dataRecordsRemoved should use std::max()
​https://bugs.webkit.org/show_bug.cgi?id=175348
<rdar://problem/33785695>

Reviewed by Chris Dumez.

No new tests. Online change of a statistic that doesn't affect logic flow.

  • loader/ResourceLoadStatistics.cpp:

(WebCore::ResourceLoadStatistics::merge):

Now uses std::max() instead of addition.

4:53 PM Changeset in webkit [220429] by beidson@apple.com
  • 3 edits in trunk/Source/WebKitLegacy/mac

Don't enable default icon loading in WK1 for apps linked against old SDKs.
<rdar://problem/33724060> and ​https://bugs.webkit.org/show_bug.cgi?id=175342

Reviewed by Andy Estes.

  • Misc/WebKitVersionChecks.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::getLoadDecisionForIcons): Don't do any icon loading unless

the app is linked against new WebKit with the new behavior.

4:36 PM Changeset in webkit [220428] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark media/modern-media-controls/css/webkit-cursor-visibility-auto-hide.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=175195

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
4:27 PM Changeset in webkit [220427] by Brent Fulgham
  • 4 edits
    3 adds in trunk

Sandbox flags do not support document.domain control
​https://bugs.webkit.org/show_bug.cgi?id=175281
<rdar://problem/33778936>

Reviewed by Chris Dumez.

Source/WebCore:

Update the 'setDomain' logic to honor the sandbox properties as defined in the current
HTML5 specification. This brings us in line with how Chrome and other browsers have
worked for some time.

Test: fast/frames/sandboxed-iframe-domain.html

  • dom/Document.cpp:

(WebCore::Document::setDomain): Add check for sandbox flag (with appropriate error message)

  • dom/SecurityContext.h:

LayoutTests:

  • fast/frames/resources/sandboxed-iframe-set-domain.html: Added.
  • fast/frames/sandboxed-iframe-domain.html: Added.
  • fast/frames/sandboxed-iframe-domain-expected.txt: Added.
4:24 PM Changeset in webkit [220426] by Matt Lewis
  • 3 edits in trunk/LayoutTests

Skipping imported/w3c/IndexedDB-private-browsing/idbfactory_open12.html
<rdar://problem/33555052>

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/mac-highsierra/TestExpectations:
4:03 PM Changeset in webkit [220425] by Michael Catanzaro
  • 9 edits in trunk

Unreviewed, fix Ubuntu LTS build
​https://bugs.webkit.org/show_bug.cgi?id=174490

Source/JavaScriptCore:

  • inspector/remote/glib/RemoteInspectorGlib.cpp:
  • inspector/remote/glib/RemoteInspectorServer.cpp:

Source/WebDriver:

  • glib/SessionHostGlib.cpp:

Source/WebKit:

  • UIProcess/glib/RemoteInspectorClient.cpp:

(WebKit::RemoteInspectorClient::RemoteInspectorClient):

Tools:

  • TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
3:53 PM Changeset in webkit [220424] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.0-branch/Source

Versioning.

3:50 PM Changeset in webkit [220423] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.1-branch/Source

Versioning.

3:46 PM Changeset in webkit [220422] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.1.2

Tag Safari-604.1.38.1.2.

3:45 PM Changeset in webkit [220421] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.0.2

Tag Safari-604.1.38.0.2.

2:38 PM WebKitGTK/Gardening/Calendar edited by cturner@igalia.com
(diff)
2:06 PM Changeset in webkit [220420] by Wenson Hsieh
  • 2 edits in trunk/Source/WebKit

Unreviewed, fix the Mac debug build after r220418.

  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::prepareForMoveToWindow):

1:55 PM Changeset in webkit [220419] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip plugins/crash-restoring-plugin-page-from-page-cache.html on macOS debug.
​https://bugs.webkit.org/show_bug.cgi?id=175270

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
1:53 PM WebKitGTK/Gardening/Calendar edited by cturner@igalia.com
(diff)
1:52 PM WebKitGTK/Gardening/Calendar edited by cturner@igalia.com
(diff)
1:45 PM Changeset in webkit [220418] by Wenson Hsieh
  • 6 edits
    2 moves in trunk

[Mac WK2] WebViewImpl should hold a weak pointer to its WKWebView or WKView
​https://bugs.webkit.org/show_bug.cgi?id=175302
<rdar://problem/33762116>

Reviewed by Tim Horton.

Source/WebKit:

Refactor WebViewImpl's m_view from a raw pointer to a WeakObjCPtr to ensure that it is automatically cleared out
when the WKWebView or WKView are destroyed, and also changes several places where we implicitly block capture
the WebViewImpl to only capture a WeakPtr to the WebViewImpl. Most of the changes here are boilerplate
adjustments for how m_view is now a weak pointer.

Test: WKWebViewMacEditingTests.DoNotCrashWhenInterpretingKeyEventWhileDeallocatingView.

  • Shared/mac/WeakObjCPtr.h:

(WebKit::WeakObjCPtr::operator ValueType * const):

  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::updateTouchBar):
(WebKit::WebViewImpl::updateMediaTouchBar):
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::~WebViewImpl):
(WebKit::WebViewImpl::window):
(WebKit::WebViewImpl::resignFirstResponder):
(WebKit::WebViewImpl::isFocused const):
(WebKit::WebViewImpl::renewGState):
(WebKit::WebViewImpl::setFrameAndScrollBy):
(WebKit::WebViewImpl::updateWindowAndViewFrames):
(WebKit::WebViewImpl::updateLayer):
(WebKit::WebViewImpl::printOperationWithPrintInfo):
(WebKit::WebViewImpl::updateContentInsetsIfAutomatic):
(WebKit::WebViewImpl::setLayoutMode):
(WebKit::WebViewImpl::intrinsicDeviceScaleFactor const):
(WebKit::WebViewImpl::windowDidBecomeKey):
(WebKit::WebViewImpl::windowDidResignKey):
(WebKit::WebViewImpl::windowDidChangeScreen):
(WebKit::WebViewImpl::mightBeginDragWhileInactive):
(WebKit::WebViewImpl::acceptsFirstMouse):
(WebKit::WebViewImpl::shouldDelayWindowOrderingForEvent):
(WebKit::WebViewImpl::windowResizeMouseLocationIsInVisibleScrollerThumb):
(WebKit::WebViewImpl::viewWillMoveToWindow):
(WebKit::WebViewImpl::viewDidMoveToWindow):
(WebKit::WebViewImpl::viewDidChangeBackingProperties):
(WebKit::WebViewImpl::hitTest):
(WebKit::WebViewImpl::postFakeMouseMovedEventForFlagsChangedEvent):
(WebKit::WebViewImpl::colorSpace):
(WebKit::WebViewImpl::prepareForMoveToWindow):
(WebKit::WebViewImpl::notifyInputContextAboutDiscardedComposition):
(WebKit::WebViewImpl::pressureChangeWithEvent):
(WebKit::WebViewImpl::fullScreenWindowController):
(WebKit::WebViewImpl::executeSavedCommandBySelector):
(WebKit::WebViewImpl::validRequestorForSendAndReturnTypes):
(WebKit::WebViewImpl::handleRequestedCandidates):
(WebKit::WebViewImpl::preferencesDidChange):
(WebKit::WebViewImpl::setTextIndicator):
(WebKit::WebViewImpl::dismissContentRelativeChildWindowsFromViewOnly):
(WebKit::WebViewImpl::accessibilityRegisterUIProcessTokens):
(WebKit::WebViewImpl::sendToolTipMouseExited):
(WebKit::WebViewImpl::sendToolTipMouseEntered):
(WebKit::WebViewImpl::toolTipChanged):
(WebKit::WebViewImpl::setAcceleratedCompositingRootLayer):
(WebKit::WebViewImpl::updateThumbnailViewLayer):
(WebKit::WebViewImpl::setInspectorAttachmentView):
(WebKit::WebViewImpl::inspectorAttachmentView):
(WebKit::WebViewImpl::draggedImage):
(WebKit::WebViewImpl::draggingEntered):
(WebKit::WebViewImpl::draggingUpdated):
(WebKit::WebViewImpl::draggingExited):
(WebKit::WebViewImpl::performDragOperation):
(WebKit::WebViewImpl::hitTestForDragTypes):
(WebKit::WebViewImpl::startWindowDrag):
(WebKit::WebViewImpl::dragImageForView):
(WebKit::WebViewImpl::setPromisedDataForImage):
(WebKit::WebViewImpl::setPromisedDataForAttachment):
(WebKit::WebViewImpl::takeViewSnapshot):
(WebKit::WebViewImpl::scrollWheel):
(WebKit::WebViewImpl::magnifyWithEvent):
(WebKit::WebViewImpl::rotateWithEvent):
(WebKit::WebViewImpl::doneWithKeyEvent):
(WebKit::WebViewImpl::interpretKeyEvent):
(WebKit::WebViewImpl::firstRectForCharacterRange):
(WebKit::WebViewImpl::characterIndexForPoint):
(WebKit::WebViewImpl::performKeyEquivalent):
(WebKit::WebViewImpl::keyUp):
(WebKit::WebViewImpl::keyDown):
(WebKit::WebViewImpl::mouseMoved):
(WebKit::WebViewImpl::windowIsFrontWindowUnderMouse):
(WebKit::WebViewImpl::userInterfaceLayoutDirection):

Tools:

Adds a new unit test checking that delayed event processing in text input context does not cause unwanted behaviors.
See WebKit ChangeLog for more details.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/TestWebKitAPI/mac/AppKitSPI.h: Renamed from Tools/TestWebKitAPI/Tests/TestWebKitAPI/mac/NSTextInputClientSPI.h.
  • TestWebKitAPI/Tests/mac/WKWebViewMacEditingTests.mm: Renamed from Tools/TestWebKitAPI/Tests/mac/WKWebViewSelectionTests.mm.

(-[SlowTextInputContext handleEventByInputMethod:completionHandler:]):
(-[SlowTextInputContext handleEvent:completionHandler:]):
(-[SlowInputWebView inputContext]):
(-[SlowInputWebView _web_superInputContext]):
(TEST):

1:42 PM WebKitGTK/Gardening/Calendar edited by cturner@igalia.com
(diff)
12:58 PM Changeset in webkit [220417] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark fast/images/async-image-body-background-image.html as flaky on macOS.
​https://bugs.webkit.org/show_bug.cgi?id=175193

Unreviewed test gardening.

  • platform/mac/TestExpectations:
12:44 PM Changeset in webkit [220416] by fpizlo@apple.com
  • 14 edits in trunk/Source

Baseline JIT should do caging
​https://bugs.webkit.org/show_bug.cgi?id=175037

Reviewed by Mark Lam.
Source/bmalloc:


This centralizes the notion of permanently enabling the primitive gigacage, which we only do in jsc
and WebProcess.

This saves the baseline JIT from emitting some code. Otherwise it would always have to emit enabled
checks on each typed array access.

  • bmalloc/Gigacage.cpp:

(Gigacage::primitiveGigacageDisabled):
(Gigacage::disableDisablingPrimitiveGigacageIfShouldBeEnabled):
(Gigacage::isDisablingPrimitiveGigacageDisabled):

  • bmalloc/Gigacage.h:

(Gigacage::isPrimitiveGigacagePermanentlyEnabled):
(Gigacage::canPrimitiveGigacageBeDisabled):

Source/JavaScriptCore:


Adds a AssemblyHelpers::cage and cageConditionally. Uses it in the baseline JIT.

Also modifies FTL caging to be more defensive when caging is disabled.

Relanded with fixed AssemblyHelpers::cageConditionally().

  • bytecode/AccessCase.cpp:

(JSC::AccessCase::generateImpl):

  • bytecode/InlineAccess.cpp:

(JSC::InlineAccess::dumpCacheSizesAndCrash):
(JSC::InlineAccess::generateSelfPropertyAccess):
(JSC::InlineAccess::generateSelfPropertyReplace):
(JSC::InlineAccess::generateArrayLength):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::caged):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::cage):
(JSC::AssemblyHelpers::cageConditionally):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitDoubleLoad):
(JSC::JIT::emitContiguousLoad):
(JSC::JIT::emitArrayStorageLoad):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emitArrayStoragePutByVal):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitIntTypedArrayGetByVal):
(JSC::JIT::emitFloatTypedArrayGetByVal):
(JSC::JIT::emitIntTypedArrayPutByVal):
(JSC::JIT::emitFloatTypedArrayPutByVal):

  • jsc.cpp:

(jscmain):
(primitiveGigacageDisabled): Deleted.

Source/WebKit:


Use a better API to disable disabling the primitive gigacage.

  • WebProcess/WebProcess.cpp:

(WebKit::m_webSQLiteDatabaseTracker):
(WebKit::primitiveGigacageDisabled): Deleted.

Source/WTF:

  • wtf/Gigacage.h:

(Gigacage::disableDisablingPrimitiveGigacageIfShouldBeEnabled):
(Gigacage::isDisablingPrimitiveGigacageDisabled):
(Gigacage::isPrimitiveGigacagePermanentlyEnabled):
(Gigacage::canPrimitiveGigacageBeDisabled):
(Gigacage::basePtr):

12:16 PM Changeset in webkit [220415] by Yusuke Suzuki
  • 2 edits in trunk/JSTests

Unreviewed, gardening test262 for Promise resolve / reject function length
​https://bugs.webkit.org/show_bug.cgi?id=175333

  • test262.yaml:
12:03 PM Changeset in webkit [220414] by commit-queue@webkit.org
  • 7 edits in trunk

Change fast seek logic to prevent ping-ponging.
​https://bugs.webkit.org/show_bug.cgi?id=175167
rdar://problem/32936116

Patch by Jeremy Jones <​jeremyj@apple.com> on 2017-08-08
Reviewed by Jer Noble.

Source/WebCore:

Updated test: media/video-fast-seek.html

Changed fast seek behavior to always seek early than seek time; and after current time when seeking forward.
This prevents ping-ponging, where a fast seek overshoots the target looking for a keyframe.
A subsequent seek will suddenly be on the other side of current time and
will search in the opposite direction for a key frame; repeat.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::fastSeek):

LayoutTests:

Test now requires forward fast seek result to be between current time and the target time,
and a backward seek to be before the seek time.

  • media/video-fast-seek.html:
  • media/media-source/media-source-fastseek.html:
11:20 AM WebKitGTK/Gardening/Calendar edited by cturner@igalia.com
(diff)
11:17 AM WebKitGTK/Gardening/Calendar edited by cturner@igalia.com
(diff)
10:22 AM Changeset in webkit [220413] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Remove obsolete failure expectations for event_loadedmetadata.html.
​https://bugs.webkit.org/show_bug.cgi?id=175027

Unreviewed test gardening.

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-08

10:18 AM Changeset in webkit [220412] by wilander@apple.com
  • 20 edits
    2 adds in trunk

Resource Load Statistics: Clear web processes' state on history removal
​https://bugs.webkit.org/show_bug.cgi?id=175271
<rdar://problem/33756560>

Reviewed by Chris Dumez.

Source/WebKit:

​https://bugs.webkit.org/show_bug.cgi?id=175090 introduced state
in the web process and that state needs to be cleared when the
UI process' statistics are cleared as part of history removal.

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::clearResourceLoadStatistics):

  • UIProcess/WebProcessPool.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::removeData):
(WebKit::WebsiteDataStore::clearResourceLoadStatisticsInWebProcesses):

  • UIProcess/WebsiteData/WebsiteDataStore.h:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::clearResourceLoadStatistics):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

Tools:

Test infrastructure for asynchronous tests of website data
removal for _WKWebsiteDataTypeResourceLoadStatistics.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:

(WTR::InjectedBundle::didReceiveMessageToPage):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::statisticsClearThroughWebsiteDataRemoval):
(WTR::TestRunner::statisticsCallClearThroughWebsiteDataRemovalCallback):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::statisticsClearThroughWebsiteDataRemoval):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):
(WTR::TestInvocation::didClearStatisticsThroughWebsiteDataRemoval):

  • WebKitTestRunner/TestInvocation.h:
  • WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::statisticsClearThroughWebsiteDataRemoval):

LayoutTests:

  • http/tests/loading/resourceLoadStatistics/user-interaction-reported-after-website-data-removal-expected.txt: Added.
  • http/tests/loading/resourceLoadStatistics/user-interaction-reported-after-website-data-removal.html: Added.
  • platform/mac-wk2/TestExpectations:

user-interaction-reported-after-website-data-removal.html marked as [ Pass ].

10:15 AM Changeset in webkit [220411] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed. Correct the function name in a debug message.
​https://bugs.webkit.org/show_bug.cgi?id=175262

No new tests: debug logs are not tested.

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-08

  • platform/audio/PlatformMediaSessionManager.cpp:

(WebCore::PlatformMediaSessionManager::applicationDidBecomeActive const):

10:14 AM Changeset in webkit [220410] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Fix baseline for http/tests/security/set-domain-remove-subdomain-for-ip-address.html.

Unreviewed test gardening.

  • http/tests/security/set-domain-remove-subdomain-for-ip-address-expected.txt:
10:00 AM Changeset in webkit [220409] by Matt Lewis
  • 1 edit
    1 move in trunk/LayoutTests

Fixed rebaselined expectations for js/dom/global-constructors-attributes.html.
​https://bugs.webkit.org/show_bug.cgi?id=175201

Unreviewed test gardening.

  • platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-expected.txt: Renamed from LayoutTests/platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-dedicated-worker-expected.txt.
9:49 AM Changeset in webkit [220408] by Adrian Perez de Castro
  • 4 edits
    1 move in trunk/Source/WebKit

[WPE] Implement WebsiteDataStore::defaultApplicationCacheDirectory() and friends
​https://bugs.webkit.org/show_bug.cgi?id=175322

Reviewed by Carlos Garcia Campos.

This makes WPE use the same implementation as the GTK+ port, with a preprocessor switch to choose the name of
the base directory inside the user XDG cache directory.

  • PlatformGTK.cmake: Add APIWebsiteDataStoreGLib.cpp to the build sources and remove APIWebsiteDataStoreGtk.cpp.
  • PlatformWPE.cmake: Add APIWebsiteDataStoreGLib.cpp to the built sources.
  • UIProcess/API/APIWebsiteDataStore.cpp: Remove now dead code.
  • UIProcess/API/glib/APIWebsiteDataStoreGLib.cpp: Renamed from Source/WebKit/UIProcess/API/gtk/APIWebsiteDataStoreGtk.cpp.

(API::WebsiteDataStore::defaultApplicationCacheDirectory):
(API::WebsiteDataStore::defaultIndexedDBDatabaseDirectory):
(API::WebsiteDataStore::defaultLocalStorageDirectory):
(API::WebsiteDataStore::defaultMediaKeysStorageDirectory):
(API::WebsiteDataStore::defaultWebSQLDatabaseDirectory):
(API::WebsiteDataStore::defaultResourceLoadStatisticsDirectory):

9:41 AM Changeset in webkit [220407] by Michael Catanzaro
  • 2 edits in trunk/Tools

Add Alicia Boya García as contributor
​https://bugs.webkit.org/show_bug.cgi?id=175326

Patch by Alicia Boya García <​aboya@igalia.com> on 2017-08-08
Reviewed by Michael Catanzaro.

  • Scripts/webkitpy/common/config/contributors.json:
9:24 AM Changeset in webkit [220406] by Brent Fulgham
  • 5 edits in trunk/LayoutTests

Unreviewed test results fix after r220376.

Rebaseline for new SecurityException message text.

  • fast/dom/Document/invalid-domain-change-throws-exception-expected.txt:
  • http/tests/dom/document-attributes-null-handling-expected.txt:
  • http/tests/security/set-domain-remove-subdomain-for-ip-address-expected.txt:
  • http/tests/security/xss-DENIED-invalid-domain-change-expected.txt:
9:13 AM Changeset in webkit [220405] by Brent Fulgham
  • 2 edits in trunk/Source/WebCore

Unreviewed build fix after r220376.

Don't attempt to use isPublicSuffix when building without that
feature enabled.

  • dom/Document.cpp:

(WebCore::Document::domainIsRegisterable const):

9:00 AM Changeset in webkit [220404] by Ryan Haddad
  • 14 edits in trunk/Source

Unreviewed, rolling out r220368.

This change caused WK1 tests to exit early with crashes.

Reverted changeset:

"Baseline JIT should do caging"
​https://bugs.webkit.org/show_bug.cgi?id=175037
​http://trac.webkit.org/changeset/220368

8:03 AM Changeset in webkit [220403] by Michael Catanzaro
  • 46 edits
    1 add in trunk

[CMake] Properly test if compiler supports compiler flags
​https://bugs.webkit.org/show_bug.cgi?id=174490

Reviewed by Konstantin Tokarev.

.:

This turned out to be a massive pain. I didn't want to merely check options before using
them: I also wanted to organize the code to avoid setting similar flags in different places.
Right now we set a bunch of global flags in OptionsCommon.cmake, and a bunch more flags in
WEBKIT_SET_EXTRA_COMPILER_FLAGS on a per-target basis.

Setting flags per-target seems better in general, e.g. because it makes it very easy to
disable warnings for particular ThirdParty targets. But it turns out that all the flags set
on a per-target basis get passed to both the C compiler and the C++ compiler, so it's
impossible to pass C++-only flags there. That's terrible. It's possible to make the flags
language-conditional using generator expressions, but that doesn't work for the Visual
Studio backend, so we would have to drop support for that (not going to happen). The CMake
documentation suggests that C and C++ files ought to be built in separate targets to avoid
this. It's a mess, basically.

So I've wound up removing WEBKIT_SET_EXTRA_COMPILER_FLAGS and adding most of those flags to
CMAKE_C_FLAGS and CMAKE_CXX_FLAGS instead. Really the only disadvantage of this is we now
have to suppress individual warnings when building ANGLESupport in WebCore. That's not the
end of the world. The only remaining useful feature of WEBKIT_SET_EXTRA_COMPILER_FLAGS was
to add -fPIC to static library targets, but turns out CMake does that for us if we just set
the variable CMAKE_POSITION_INDEPENDENT_CODE, so we can get rid of it completely.

Of course there are also macros for setting target-specific compiler flags, which we
frequently need in order to suppress specific warnings, particularly warnings coming from
third-party libraries like ANGLE and gtest. But remember the footgun: these macros will test
the flag against only one compiler, but must work with both C and C++ compilers unless the
build target exclusively contains targets built with just one of those compilers. Yuck.

  • CMakeLists.txt:
  • Source/CMakeLists.txt:
  • Source/PlatformGTK.cmake:
  • Source/cmake/OptionsCommon.cmake:
  • Source/cmake/WebKitCommon.cmake:
  • Source/cmake/WebKitCompilerFlags.cmake: Added.
  • Source/cmake/WebKitMacros.cmake:

Source/JavaScriptCore:

  • API/tests/PingPongStackOverflowTest.cpp:

(testPingPongStackOverflow):

  • API/tests/testapi.c:
  • b3/testb3.cpp:

(JSC::B3::testPatchpointLotsOfLateAnys):

Source/ThirdParty:

  • brotli/CMakeLists.txt:
  • gtest/CMakeLists.txt:
  • woff2/CMakeLists.txt:
  • xdgmime/CMakeLists.txt:

Source/WebCore:

  • CMakeLists.txt:
  • PlatformGTK.cmake:
  • PlatformWPE.cmake:

Source/WebDriver:

  • WebDriverService.cpp:

(WebDriver::WebDriverService::run):

  • glib/SessionHostGlib.cpp:

Source/WebKit:

  • CMakeLists.txt:
  • PlatformGTK.cmake:

Source/WTF:

  • wtf/Compiler.h:

Tools:

  • DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:
  • MiniBrowser/gtk/CMakeLists.txt:
  • TestRunnerShared/Bindings/JSWrapper.cpp:

(WTR::JSWrapper::initialize):

  • TestWebKitAPI/CMakeLists.txt:
  • TestWebKitAPI/PlatformGTK.cmake:
  • TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:

(TestWebKitAPI::CheckedArithmeticTester::run):

  • TestWebKitAPI/Tests/WebKitGLib/TestAutomationSession.cpp:
  • TestWebKitAPI/Tests/WebKitGLib/TestWebExtensions.cpp:
  • TestWebKitAPI/Tests/WebKitGLib/WebExtensionTest.cpp:

(formControlsAssociatedCallback):

  • TestWebKitAPI/glib/CMakeLists.txt:
  • TestWebKitAPI/glib/WebKitGLib/TestMain.h:

(Test::getResourcesDir):

  • WebKitTestRunner/CMakeLists.txt:
  • WebKitTestRunner/InjectedBundle/EventSendingController.cpp:

(WTR::menuItemClickCallback):
(WTR::staticConvertMenuItemToType):

  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setUseDashboardCompatibilityMode):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:

(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::helpText const):
(WTR::AccessibilityUIElement::attributedStringForRange):

  • WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::EventSenderProxy::updateTouchPoint):
(WTR::EventSenderProxy::releaseTouchPoint):

6:29 AM Changeset in webkit [220402] by zandobersek@gmail.com
  • 3 edits in trunk/Source/WebCore

[GStreamer] Don't use GraphicsContext3D in VideoTextureCoperGStreamer
​https://bugs.webkit.org/show_bug.cgi?id=174774

Reviewed by Carlos Garcia Campos.

VideoTextureCoperGStreamer class creates a new GraphicsContext3D internally
that's used to render to whichever OpenGL context is current. Such usage
doesn't add anything to the user since there's no underlying offscreen-based
OpenGL context created, and instead all GraphicsContext3D calls are directly
translated to usual OpenGL API calls. We should avoid using GraphicsContext3D
in such cases and instead use direct OpenGL API calls.

This patch achieves that for the VideoTextureCoperGStreamer class. A
GraphicsContext3D object is still created because it's needed to construct an
instance of the TextureMapperShaderProgram class, but this will be removed as
soon as TextureMapperShaderProgram drops the GraphicsContext3D dependence.

No new tests -- no change in behavior.

  • platform/graphics/gstreamer/VideoTextureCopierGStreamer.cpp:

(WebCore::VideoTextureCopierGStreamer::VideoTextureCopierGStreamer):
(WebCore::VideoTextureCopierGStreamer::~VideoTextureCopierGStreamer):
(WebCore::VideoTextureCopierGStreamer::copyVideoTextureToPlatformTexture):

  • platform/graphics/gstreamer/VideoTextureCopierGStreamer.h:

(WebCore::VideoTextureCopierGStreamer::resultTexture):

6:11 AM Changeset in webkit [220401] by Yusuke Suzuki
  • 2 edits in trunk/Source/JavaScriptCore

[Linux] Clear WasmMemory with madvice instead of memset
​https://bugs.webkit.org/show_bug.cgi?id=175150

Reviewed by Filip Pizlo.

In Linux, zeroing pages with memset populates backing store.
Instead, we should use madvise with MADV_DONTNEED. It discards
pages. And if you access these pages, on-demand-zero-pages will
be shown.

We also commit grown pages in all OSes.

  • wasm/WasmMemory.cpp:

(JSC::Wasm::commitZeroPages):
(JSC::Wasm::Memory::create):
(JSC::Wasm::Memory::grow):

6:05 AM Changeset in webkit [220400] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

[TexMap] Drop GC3D* type usage from TextureMapperPlatformLayer{Buffer,Proxy}
​https://bugs.webkit.org/show_bug.cgi?id=175314

Reviewed by Carlos Garcia Campos.

Switch to using OpenGL types in the TextureMapperPlatformLayerBuffer and
TextureMapperPlatformLayerProxy classes, instead of the equivalent GC3D*
types provided in the GraphicsTypes3D.h header.

No new tests -- no change in behavior.

  • platform/graphics/texmap/TextureMapperPlatformLayerBuffer.cpp:

(WebCore::TextureMapperPlatformLayerBuffer::TextureMapperPlatformLayerBuffer):
(WebCore::TextureMapperPlatformLayerBuffer::canReuseWithoutReset):

  • platform/graphics/texmap/TextureMapperPlatformLayerBuffer.h:
  • platform/graphics/texmap/TextureMapperPlatformLayerProxy.cpp:

(WebCore::TextureMapperPlatformLayerProxy::getAvailableBuffer):

  • platform/graphics/texmap/TextureMapperPlatformLayerProxy.h:
6:04 AM Changeset in webkit [220399] by zandobersek@gmail.com
  • 5 edits in trunk/Source/WebCore

[TexMap] Don't use GraphicsContext3D in ClipStack
​https://bugs.webkit.org/show_bug.cgi?id=174776

Reviewed by Carlos Garcia Campos.

Any GraphicsContext3D object that's passed to ClipStack methods is of the
render-to-current-context nature, meaning there's no internally owned GL
context that has to be properly handled and all calls are simply passed to
OpenGL APIs. We should drop such (non-)usage of GraphicsContext3D in favor
of direct OpenGL API invocations.

This patch covers TextureMapper's ClipStack. Call sites to the apply() and
applyIfNeeded() are modified to not pass a reference to any
GraphicsContext3D object. Internally, OpenGL API entrypoints and constants
are used instead of GraphicsContext3D invocations.

No new tests -- no change in behavior.

  • platform/graphics/texmap/BitmapTextureGL.cpp:

(WebCore::BitmapTextureGL::clearIfNeeded):
(WebCore::BitmapTextureGL::bindAsSurface):

  • platform/graphics/texmap/ClipStack.cpp:

(WebCore::ClipStack::apply):
(WebCore::ClipStack::applyIfNeeded):

  • platform/graphics/texmap/ClipStack.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::bindDefaultSurface):
(WebCore::TextureMapperGL::beginScissorClip):
(WebCore::TextureMapperGL::beginClip):
(WebCore::TextureMapperGL::endClip):

5:22 AM Changeset in webkit [220398] by jfernandez@igalia.com
  • 3 edits
    16 adds in trunk

Not possible to remove the 'li' element inside the table cell
​https://bugs.webkit.org/show_bug.cgi?id=173148

Reviewed by Ryosuke Niwa.

Source/WebCore:

We need to add a new case for breaking out empty list items when they are
at the start of an editable area. Since list items can be also inside
table cells, we need to consider this kind of elements as well.

Tests: editing/deleting/delete-list-items-in-table-cell-1.html

editing/deleting/delete-list-items-in-table-cell-2.html
editing/deleting/delete-list-items-in-table-cell-3.html
editing/deleting/delete-list-items-in-table-cell-4.html
editing/deleting/delete-list-items-in-table-cell-5.html
editing/deleting/delete-list-items-in-table-cell-6.html
editing/deleting/delete-list-items-in-table-cell-7.html
editing/deleting/delete-list-items-in-table-cell-8.html

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::deleteKeyPressed):

LayoutTests:

Regression tests for different scenarios of list items removal.

  • editing/deleting/delete-list-items-in-table-cell-1-expected.txt: Added.
  • editing/deleting/delete-list-items-in-table-cell-1.html: Added.
  • editing/deleting/delete-list-items-in-table-cell-2-expected.txt: Added.
  • editing/deleting/delete-list-items-in-table-cell-2.html: Added.
  • editing/deleting/delete-list-items-in-table-cell-3-expected.txt: Added.
  • editing/deleting/delete-list-items-in-table-cell-3.html: Added.
  • editing/deleting/delete-list-items-in-table-cell-4-expected.txt: Added.
  • editing/deleting/delete-list-items-in-table-cell-4.html: Added.
  • editing/deleting/delete-list-items-in-table-cell-5-expected.txt: Added.
  • editing/deleting/delete-list-items-in-table-cell-5.html: Added.
  • editing/deleting/delete-list-items-in-table-cell-6-expected.txt: Added.
  • editing/deleting/delete-list-items-in-table-cell-6.html: Added.
  • editing/deleting/delete-list-items-in-table-cell-7-expected.txt: Added.
  • editing/deleting/delete-list-items-in-table-cell-7.html: Added.
  • editing/deleting/delete-list-items-in-table-cell-8-expected.txt: Added.
  • editing/deleting/delete-list-items-in-table-cell-8.html: Added.
3:27 AM Changeset in webkit [220397] by zandobersek@gmail.com
  • 9 edits
    1 add in trunk/Source/WebCore

[TexMap] Isolate the TextureMapperPlatformLayerProxyProvider class
​https://bugs.webkit.org/show_bug.cgi?id=175316

Reviewed by Carlos Garcia Campos.

Move the TextureMapperPlatformLayerProxyProvider class (which is the type
aliased to PlatformLayer for threaded CoordGraphics) into its own header
file. This prevents including the TextureMapperPlatformLayerProxy.h header
file in MediaPlayerPrivateGStreamerBase.h, avoiding spilling OpenGL types
and function declarations before the GStreamer GL headers include them
later in the MediaPlayerPrivateGStreamerBase implementation file.

In the MediaPlayerPrivateGStreamerBase.h header file, only the new header
is included, and a forward declaration of the TextureMapperPlatformLayerProxy
class is used. proxy() and swapBuffersIfNeeded() methods are moved into
the implementation file to avoid requiring the full definition of the
TextureMapperPlatformLayerProxy class.

Similar is done for the TextureMapperGC3DPlatformLayer class and the
Cairo-specific implementation of the ImageBufferData class. The
CoordinatedGraphicsLayer implementation file also gains an include of the
TextureMapperPlatformLayerProxyProvider.h header since it requires the full
definition of that class.

No new tests -- no change in behavior.

  • platform/graphics/cairo/ImageBufferCairo.cpp:

(WebCore::ImageBufferData::proxy const):

  • platform/graphics/cairo/ImageBufferDataCairo.h:
  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::updateTexture):
(WebCore::MediaPlayerPrivateGStreamerBase::proxy const):
(WebCore::MediaPlayerPrivateGStreamerBase::swapBuffersIfNeeded):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
  • platform/graphics/texmap/TextureMapperGC3DPlatformLayer.cpp:
  • platform/graphics/texmap/TextureMapperGC3DPlatformLayer.h:
  • platform/graphics/texmap/TextureMapperPlatformLayerProxy.h:
  • platform/graphics/texmap/TextureMapperPlatformLayerProxyProvider.h: Added.
  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
3:02 AM WebKitGTK/2.16.x edited by cturner@igalia.com
(diff)
2:45 AM WebKitGTK/2.16.x edited by magomez@igalia.com
(diff)
2:03 AM Changeset in webkit [220396] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Unreviewed. Follow-up to r220392 that fixes build on configurations
that disable USE(GSTREAMER_GL).

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
When creating the BitmapTextureGL object, also provide an initialized
TextureMapperContextAttributes object.

1:36 AM Changeset in webkit [220395] by zandobersek@gmail.com
  • 2 edits
    1 add in trunk/Source/WebCore

[TexMap] Group GL header file inclusions in a single header file
​https://bugs.webkit.org/show_bug.cgi?id=175313

Reviewed by Carlos Garcia Campos.

Add a helper header file to the TextureMapper subsystem that includes
the OpenGL headers, properly addressing the build configuration to
include headers as provided by either libepoxy, the OpenGL ES library,
or the OpenGL library.

TextureMapperContextAttributes implementation file is the only one
that can leverage the header at the moment, but more will follow.

  • platform/graphics/texmap/TextureMapperContextAttributes.cpp:
  • platform/graphics/texmap/TextureMapperGLHeaders.h: Copied from Source/WebCore/platform/graphics/texmap/TextureMapperContextAttributes.cpp.
1:29 AM Changeset in webkit [220394] by Carlos Garcia Campos
  • 11 edits in trunk/Source

Web Automation: setUserInputForCurrentJavaScriptPrompt should fail if current dialog is not a prompt
​https://bugs.webkit.org/show_bug.cgi?id=175261

Reviewed by Brian Burg.

Source/WebDriver:

  • CommandResult.cpp:

(WebDriver::CommandResult::CommandResult): Handle ElementNotInteractable protocol error.

Source/WebKit:

According to the spec, send alert text command should fail if the current dialog is not a prompt. This patch
adds JavaScriptDialogType enum to API::AutomationSessionClient and a new virtual method to ask the client about
the type of the current dialog. WebAutomationSession::setUserInputForCurrentJavaScriptPrompt() uses the new
client method to check the type of the current dialog and fail in case it's not a prompt. Cocoa needs an
implementation, for now it always returns Prompt as the type to keep compatibility.

18.4 Send Alert Text.
​https://w3c.github.io/webdriver/webdriver-spec.html#send-alert-text

This fixes selenium test testSettingTheValueOfAnAlertThrows.

  • UIProcess/API/APIAutomationSessionClient.h:

(API::AutomationSessionClient::typeOfCurrentJavaScriptDialogOnPage):

  • UIProcess/API/glib/WebKitAutomationSession.cpp:
  • UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewGetCurrentScriptDialogType):

  • UIProcess/API/glib/WebKitWebViewPrivate.h:
  • UIProcess/Automation/Automation.json:
  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::setUserInputForCurrentJavaScriptPrompt):

  • UIProcess/Cocoa/AutomationSessionClient.h:
  • UIProcess/Cocoa/AutomationSessionClient.mm:

(WebKit::AutomationSessionClient::typeOfCurrentJavaScriptDialogOnPage):

1:10 AM Changeset in webkit [220393] by Wenson Hsieh
  • 29 edits
    4 adds in trunk

[iOS WK2] WKWebView schedules nonstop layout after pressing cmb+b,i,u inside a contenteditable div
​https://bugs.webkit.org/show_bug.cgi?id=175116
<rdar://problem/28279301>

Reviewed by Darin Adler and Ryosuke Niwa.

Source/WebCore:

WebCore support for WebPage::editorState refactoring. See WebKit ChangeLogs for more detail.

Tests: EditorStateTests.TypingAttributesBold

EditorStateTests.TypingAttributesItalic
EditorStateTests.TypingAttributesUnderline
EditorStateTests.TypingAttributesTextAlignmentAbsoluteAlignmentOptions
EditorStateTests.TypingAttributesTextAlignmentStartEnd
EditorStateTests.TypingAttributesTextAlignmentDirectionalText
EditorStateTests.TypingAttributesTextColor
EditorStateTests.TypingAttributesMixedStyles
EditorStateTests.TypingAttributesLinkColor

  • css/StyleProperties.cpp:

(WebCore::StyleProperties::propertyAsColor const):
(WebCore::StyleProperties::propertyAsValueID const):

Introduces some helper functions in StyleProperties to convert CSS property values to Color or a CSSValueID.

  • css/StyleProperties.h:
  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::hasStyle):

Pull out logic in selectionStartHasStyle that asks for a style TriState into EditingStyle::hasStyle. This is
because WebPage::editorState will now query for multiple styles at the selection start, but
selectionStartHasStyle currently recomputes styleAtSelectionStart every time it is called. To prevent extra work
from being done, we can just call selectionStartHasStyle once and use ask for EditingStyle::hasStyle on the
computed EditingStyle at selection start.

  • editing/EditingStyle.h:
  • editing/Editor.cpp:

(WebCore::Editor::selectionStartHasStyle const):

Source/WebKit:

Refactors WebPage::editorState to only use the StyleProperties derived from EditingStyle, instead of inserting
and removing a temporary node to figure out the style. Also adds hooks to notify the UI delegate of EditorState
changes.

  • UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
  • UIProcess/API/Cocoa/WKWebView.mm:

(nsTextAlignment):
(dictionaryRepresentationForEditorState):
(-[WKWebView _didChangeEditorState]):

Alerts the private UI delegate of UI-side EditorState updates.

(-[WKWebView _web_editorStateDidChange]):
(-[WKWebView _executeEditCommand:argument:completion:]):

  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/API/mac/WKView.mm:

(-[WKView _web_editorStateDidChange]):

  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::selectionDidChange):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::executeEditCommand):

Change executeEditCommand(name, callback) to executeEditCommand(name, argument, callback) and lift out of iOS
platform code and into WebPage.cpp.

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView executeEditCommandWithCallback:]):
(-[WKContentView _selectionChanged]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::executeEditCommand): Deleted.

Move the iOS-specific implementation of executeEditCommand that invokes a callback when the web process responds
out of WebPageProxyIOS, and into cross-platform WebPageProxy code. Additionally, add a parameter for the edit
command's argument.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::editorState const):

Use EditingStyle::styleAtSelectionStart instead of Editor::styleForSelectionStart when computing an EditorState.
Tweak bold, italic and underline to use EditingStyle TriStates.

(WebKit::shouldEnsureEditorStateUpdateAfterExecutingCommand):
(WebKit::WebPage::executeEditCommandWithCallback):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::executeEditCommandWithCallback): Deleted.

Tools:

Introduces new testing infrastructure and API tests to test EditorState updates in the UI process. The new
EditorStateTests run on both iOS and Mac.

  • TestWebKitAPI/EditingTestHarness.h: Added.
  • TestWebKitAPI/EditingTestHarness.mm: Added.

EditingTestHarness is a helper object that API tests may use to apply editing commands and store EditorState
history. This test harness adds sugaring around various editing commands, and simplifies the process of checking
the state of the latest observed EditorState.

(-[EditingTestHarness initWithWebView:]):
(-[EditingTestHarness dealloc]):
(-[EditingTestHarness webView]):
(-[EditingTestHarness latestEditorState]):
(-[EditingTestHarness editorStateHistory]):
(-[EditingTestHarness insertText:andExpectEditorStateWith:]):
(-[EditingTestHarness insertHTML:andExpectEditorStateWith:]):
(-[EditingTestHarness selectAllAndExpectEditorStateWith:]):
(-[EditingTestHarness moveBackwardAndExpectEditorStateWith:]):
(-[EditingTestHarness moveWordBackwardAndExpectEditorStateWith:]):
(-[EditingTestHarness toggleBold]):
(-[EditingTestHarness toggleItalic]):
(-[EditingTestHarness toggleUnderline]):
(-[EditingTestHarness setForegroundColor:]):
(-[EditingTestHarness alignJustifiedAndExpectEditorStateWith:]):
(-[EditingTestHarness alignLeftAndExpectEditorStateWith:]):
(-[EditingTestHarness alignCenterAndExpectEditorStateWith:]):
(-[EditingTestHarness alignRightAndExpectEditorStateWith:]):
(-[EditingTestHarness insertParagraphAndExpectEditorStateWith:]):
(-[EditingTestHarness deleteBackwardAndExpectEditorStateWith:]):
(-[EditingTestHarness _execCommand:argument:expectEntries:]):

Dispatches an editing command to the web process, and blocks until a response is received. If an expected
entries dictionary is given, this will additionally verify that the latest EditorState contains all the expected
keys and values.

(-[EditingTestHarness latestEditorStateContains:]):
(-[EditingTestHarness _webView:editorStateDidChange:]):

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/EditorStateTests.mm: Added.

(TestWebKitAPI::setUpEditorStateTestHarness):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebKit2Cocoa/editor-state-test-harness.html: Added.

LayoutTests:

Rebaseline some iOS WK2 LayoutTest expectations. These tests currently expect an empty anonymous RenderBlock to
be inserted into the render tree, but this is only a result of us adding and removing a temporary <span> when
computing a RenderStyle in WebPage::editorState -- this patch removes these empty RenderBlocks, making these
expectations' RenderTrees consistent with WebKit1.

  • platform/ios-wk2/editing/inserting/insert-div-024-expected.txt:
  • platform/ios-wk2/editing/inserting/insert-div-026-expected.txt:
  • platform/ios-wk2/editing/style/5084241-expected.txt:
  • platform/ios-wk2/editing/style/unbold-in-bold-expected.txt:
12:46 AM Changeset in webkit [220392] by zandobersek@gmail.com
  • 8 edits
    2 adds in trunk/Source/WebCore

[TexMap] Add TextureMapperContextAttributes
​https://bugs.webkit.org/show_bug.cgi?id=175311

Reviewed by Carlos Garcia Campos.

Add and use TextureMapperContextAttributes, a slim struct that holds
information about the type and extensions supported by the OpenGL
context that's being used for one specific TextureMapperGL instance.

This struct is initialized in the TextureMapperGL constructor for the
OpenGL context that's been made current on that thread, and that will
be used for that TextureMapperGL instance through its lifetime. The
struct is then also copied into any BitmapTextureGL objects that have
been created through this TextureMapperGL (or its texture pool).

The struct is initialized with information about GLES2 support (which
is at this point done through the USE_OPENGL_ES_2 macro) and about
specific OpenGL extensions that are supported. These are then used in
TextureMapperGL (NPOT textures) and BitmapTextureGL (BGRA support,
sub-image unpacking) to deploy specific optimizations or workarounds.

This ultimately serves as a replacement for clunky static functions
that need to operate on GraphicsContext3D objects to retrieve this
information.

No new tests -- no change in behavior.

  • platform/TextureMapper.cmake:
  • platform/graphics/texmap/BitmapTextureGL.cpp:

(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::BitmapTextureGL::updateContentsNoSwizzle):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::driverSupportsSubImage): Deleted.

  • platform/graphics/texmap/BitmapTextureGL.h:

(WebCore::BitmapTextureGL::create):

  • platform/graphics/texmap/BitmapTexturePool.cpp:

(WebCore::BitmapTexturePool::BitmapTexturePool):
(WebCore::BitmapTexturePool::createTexture):

  • platform/graphics/texmap/BitmapTexturePool.h:
  • platform/graphics/texmap/TextureMapperContextAttributes.cpp: Added.

(WebCore::TextureMapperContextAttributes::initialize):

  • platform/graphics/texmap/TextureMapperContextAttributes.h: Added.
  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::TextureMapperGL):
(WebCore::TextureMapperGL::drawTexture):
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram):
(WebCore::TextureMapperGL::createTexture):
(WebCore::driverSupportsNPOTTextures): Deleted.

  • platform/graphics/texmap/TextureMapperGL.h:
12:44 AM Changeset in webkit [220391] by zandobersek@gmail.com
  • 6 edits in trunk/Source

[TexMap] Don't expose GraphicsContext3D object
​https://bugs.webkit.org/show_bug.cgi?id=175310

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Remove the GraphicsContext3D getter from the TextureMapperGL class. Instead,
the clearColor() method is added that's to be used by the CoordinatedGraphicsScene
class which was accessing the GraphicsContext3D object for this purpose.

  • platform/graphics/texmap/TextureMapper.h:
  • platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::clearColor):

  • platform/graphics/texmap/TextureMapperGL.h:

(WebCore::TextureMapperGL::graphicsContext3D const): Deleted.

Source/WebKit:

  • Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::paintToCurrentGLContext):
Stop using GraphicsContext3D directly and instead use the
TextureMapper::clearColor() method to achieve the same result.

12:29 AM Changeset in webkit [220390] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r220248. rdar://problem/33754458

12:29 AM Changeset in webkit [220389] by jmarcell@apple.com
  • 4 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r220247. rdar://problem/33754443

Aug 7, 2017:

11:43 PM Changeset in webkit [220388] by Carlos Garcia Campos
  • 7 edits in trunk/Source/WebDriver

WebDriver: implement unhandled prompt behavior
​https://bugs.webkit.org/show_bug.cgi?id=175184

Reviewed by Brian Burg.

Handle user prompts before running some of the commands according to the specification.

  • Capabilities.h: Add UnhandledPromptBehavior capability.
  • CommandResult.cpp:

(WebDriver::CommandResult::httpStatusCode const): Add UnexpectedAlertOpen error.
(WebDriver::CommandResult::errorString const): Ditto.

  • CommandResult.h:

(WebDriver::CommandResult::setAdditonalErrorData): New method to set an additional data object that will be sent
as part of the result error message.
(WebDriver::CommandResult::additionalErrorData const): Return the additional data object.

  • Session.cpp:

(WebDriver::Session::handleUserPrompts): Check if there's an active JavaScript dialog and deal with it depeding
on the unhandled prompt behavior.
(WebDriver::Session::reportUnexpectedAlertOpen): Generate an error message with UnexpectedAlertOpen error and
including the alert text as additional error data.
(WebDriver::Session::go): Handle user prompts before running the command.
(WebDriver::Session::getCurrentURL): Ditto.
(WebDriver::Session::back): Ditto.
(WebDriver::Session::forward): Ditto.
(WebDriver::Session::refresh): Ditto.
(WebDriver::Session::getTitle): Ditto.
(WebDriver::Session::closeWindow): Ditto.
(WebDriver::Session::switchToFrame): Ditto.
(WebDriver::Session::switchToParentFrame): Ditto.
(WebDriver::Session::isElementSelected): Ditto.
(WebDriver::Session::getElementText): Ditto.
(WebDriver::Session::getElementTagName): Ditto.
(WebDriver::Session::getElementRect): Ditto.
(WebDriver::Session::isElementEnabled): Ditto.
(WebDriver::Session::isElementDisplayed): Ditto.
(WebDriver::Session::getElementAttribute): Ditto.
(WebDriver::Session::elementSendKeys): Ditto.
(WebDriver::Session::elementSubmit): Ditto.
(WebDriver::Session::executeScript): Ditto.

  • Session.h:
  • WebDriverService.cpp:

(WebDriver::WebDriverService::sendResponse const): Send data object as part of the result error message if present.
(WebDriver::deserializeUnhandledPromptBehavior):
(WebDriver::WebDriverService::parseCapabilities const):
(WebDriver::WebDriverService::validatedCapabilities const):
(WebDriver::WebDriverService::newSession):

11:25 PM Changeset in webkit [220387] by Carlos Garcia Campos
  • 12 edits
    1 copy
    1 add in trunk/Source

[GTK] Implement JavaScript dialog methods of API::AutomationSessionClient
​https://bugs.webkit.org/show_bug.cgi?id=175259

Reviewed by Michael Catanzaro.

Source/WebCore/platform/gtk/po:

  • POTFILES.in: Add WebKitScriptDialogGtk.cpp.

Source/WebKit:

Move the default implementation of WebKitScriptDialog from WebKitWebView platform specific files to their own
files. Implement all JavaScript dialog methods of API::AutomationSessionClient in WebKitAutomationSession. For
now it only works when the user doesn't override WebKitWebView::script-dialog signal and default implementation
is used.

  • PlatformGTK.cmake: Add new files to compilation.
  • PlatformWPE.cmake: Ditto.
  • UIProcess/API/glib/WebKitAutomationSession.cpp:

(webkitAutomationSessionCreate): Pass the WebKitWebContext to the constructor and keep a pointer to it in session.

  • UIProcess/API/glib/WebKitAutomationSessionPrivate.h:
  • UIProcess/API/glib/WebKitScriptDialogPrivate.h:
  • UIProcess/API/glib/WebKitWebContext.cpp:
  • UIProcess/API/glib/WebKitWebView.cpp:

(webkitWebViewRunJavaScriptAlert): Set the currently script dialog for the scope of the function.
(webkitWebViewRunJavaScriptConfirm): Ditto.
(webkitWebViewRunJavaScriptPrompt): Ditto.
(webkitWebViewRunJavaScriptBeforeUnloadConfirm): Ditto.
(webkitWebViewIsShowingScriptDialog): Ask current dialog if there's one.
(webkitWebViewGetCurrentScriptDialogMessage): Ditto.
(webkitWebViewSetCurrentScriptDialogUserInput): Ditto.
(webkitWebViewAcceptCurrentScriptDialog): Ditto.
(webkitWebViewDismissCurrentScriptDialog): Ditto.

  • UIProcess/API/glib/WebKitWebViewPrivate.h:
  • UIProcess/API/gtk/WebKitScriptDialogGtk.cpp: Added.

(webkitWebViewCreateJavaScriptDialog): Moved from WebKitWebViewGtk.cpp.
(webkitScriptDialogRun): Run the dialog, this code is moved from WebKitWebViewGtk.cpp.
(webkitScriptDialogIsRunning): Return true if the script dialog has a native dialog running.
(webkitScriptDialogAccept): Send Ok or Close response to the native dialog depending on the dialog type.
(webkitScriptDialogDismiss): Send Close response to the native dialog.
(webkitScriptDialogSetUserInput): Set the given text on the prompt dialog entry.

  • UIProcess/API/gtk/WebKitWebViewGtk.cpp:

(webkitWebViewScriptDialog): Simply call webkitScriptDialogRun() now.

  • UIProcess/API/wpe/WebKitScriptDialogWPE.cpp: Copied from Source/WebKit/UIProcess/API/glib/WebKitAutomationSessionPrivate.h.

(webkitScriptDialogRun):
(webkitScriptDialogIsRunning):
(webkitScriptDialogAccept):
(webkitScriptDialogDismiss):
(webkitScriptDialogSetUserInput):

11:22 PM Changeset in webkit [220386] by Carlos Garcia Campos
  • 7 edits in trunk/Source/WebDriver

WebDriver: implement user prompt commands
​https://bugs.webkit.org/show_bug.cgi?id=174614

Reviewed by Brian Burg.

  • CommandResult.cpp:

(WebDriver::CommandResult::CommandResult): Handle NoJavaScriptDialog protocol error.
(WebDriver::CommandResult::httpStatusCode const): Add NoSuchAlert.
(WebDriver::CommandResult::errorString const): Ditto.

  • CommandResult.h:
  • Session.cpp:

(WebDriver::Session::dismissAlert):
(WebDriver::Session::acceptAlert):
(WebDriver::Session::getAlertText):
(WebDriver::Session::sendAlertText):

  • Session.h:
  • WebDriverService.cpp:

(WebDriver::WebDriverService::dismissAlert):
(WebDriver::WebDriverService::acceptAlert):
(WebDriver::WebDriverService::getAlertText):
(WebDriver::WebDriverService::sendAlertText):

  • WebDriverService.h:
10:48 PM Changeset in webkit [220385] by jmarcell@apple.com
  • 2 edits in branches/safari-604.1.38.1-branch/Source/WebCore

Cherry-pick r220333. rdar://problem/33601173

8:20 PM Changeset in webkit [220384] by msaboff@apple.com
  • 2 edits in trunk/PerformanceTests

Use more accurate Russian keywords for RexBench/FlightPlanner Unicode mode
​https://bugs.webkit.org/show_bug.cgi?id=175298

Reviewed by Saam Barati.

With the help of Alexey Proskuryakov updated the Russian keywords.

  • RexBench/FlightPlanner/use_unicode.js:
7:52 PM Changeset in webkit [220383] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

RenderStyle:diff() was inadvertently doing deep compares of StyleRareNonInheritedData etc
​https://bugs.webkit.org/show_bug.cgi?id=175304

Reviewed by Tim Horton.

r210758 changed DataRef::get() from returning a pointer to a reference. This caused all the places
in RenderStyle::diff() and related functions, where we intended to do a quick pointer comparison,
to doing deep compares via operator!=. This made the code slightly slower.

Fix by exposing ptr() on DataRef and using it wherever we wish to do pointer comparison.

  • rendering/style/DataRef.h:

(WebCore::DataRef::ptr const):

  • rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::inheritedDataShared const):
(WebCore::RenderStyle::changeAffectsVisualOverflow const):
(WebCore::RenderStyle::changeRequiresLayout const):
(WebCore::RenderStyle::changeRequiresRecompositeLayer const):
(WebCore::RenderStyle::listStyleImage const): Expand the function onto multiple lines.

7:52 PM Changeset in webkit [220382] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Add a fast path for rotate() and rotateZ() transform parsing
​https://bugs.webkit.org/show_bug.cgi?id=175308

Reviewed by Zalan Bujtas.

Fast paths only existed for translate-related functions, matrix3d() and scale3d(). Add
rotate() and rotateX(), which gives a small boost to one of the MotionMark tests.

  • css/parser/CSSParserFastPaths.cpp:

(WebCore::parseSimpleAngle):
(WebCore::parseTransformAngleArgument):
(WebCore::parseSimpleTransformValue):
(WebCore::transformCanLikelyUseFastPath):

7:52 PM Changeset in webkit [220381] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Re-order the tests in RenderLayerCompositor::requiresCompositingLayer() for performance
​https://bugs.webkit.org/show_bug.cgi?id=175306

Reviewed by Tim Horton.

Re-order the tests for compositing reasons so that reasons more likely to happen are higher in the list.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::requiresCompositingLayer const):
(WebCore::RenderLayerCompositor::requiresOwnBackingStore const):

7:52 PM Changeset in webkit [220380] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Avoid a hash lookup in FilterInfo::remove()
​https://bugs.webkit.org/show_bug.cgi?id=175301

Reviewed by Sam Weinig.

FilterInfo::remove() always called map().remove(&layer)), even when layer.m_hasFilterInfo
was false (and even asserted that layer.m_hasFilterInfo == map().contains(&layer)).

So we can early return if layer.m_hasFilterInfo is false.

  • rendering/RenderLayerFilterInfo.cpp:

(WebCore::RenderLayer::FilterInfo::getIfExists):
(WebCore::RenderLayer::FilterInfo::remove):

7:46 PM Changeset in webkit [220379] by Simon Fraser
  • 14 edits in trunk/Source/WebCore

Make TransformOperation::type() non-virtual
​https://bugs.webkit.org/show_bug.cgi?id=175297

Reviewed by Sam Weinig.

Store the OperationType in the base class so that type() and isSameType() can
be non-virtual.

Small perf win on some benchmarks.

  • platform/graphics/transforms/IdentityTransformOperation.h:
  • platform/graphics/transforms/Matrix3DTransformOperation.h:
  • platform/graphics/transforms/MatrixTransformOperation.h:
  • platform/graphics/transforms/PerspectiveTransformOperation.h:
  • platform/graphics/transforms/RotateTransformOperation.cpp:

(WebCore::RotateTransformOperation::blend):

  • platform/graphics/transforms/RotateTransformOperation.h:
  • platform/graphics/transforms/ScaleTransformOperation.cpp:

(WebCore::ScaleTransformOperation::blend):

  • platform/graphics/transforms/ScaleTransformOperation.h:
  • platform/graphics/transforms/SkewTransformOperation.cpp:

(WebCore::SkewTransformOperation::blend):

  • platform/graphics/transforms/SkewTransformOperation.h:
  • platform/graphics/transforms/TransformOperation.h:

(WebCore::TransformOperation::TransformOperation):
(WebCore::TransformOperation::type const):
(WebCore::TransformOperation::isSameType const):

  • platform/graphics/transforms/TranslateTransformOperation.cpp:

(WebCore::TranslateTransformOperation::blend):

  • platform/graphics/transforms/TranslateTransformOperation.h:
7:46 PM Changeset in webkit [220378] by Simon Fraser
  • 4 edits in trunk/Source/WebCore

Inline ~Color and Color::isExtended()
​https://bugs.webkit.org/show_bug.cgi?id=175293

Reviewed by Zalan Bujtas.

The Color destructor and Color::isExtended() show up on profiles, so inline them.
Before r207265 the destructor was inlined.

Also make sure that LengthSize::operator== is inlined, which it was not (according
to profiles).

  • platform/LengthSize.h:

(WebCore::operator==):

  • platform/graphics/Color.cpp:

(WebCore::Color::~Color): Deleted.
(WebCore::Color::isExtended const): Deleted.

  • platform/graphics/Color.h:

(WebCore::Color::~Color):
(WebCore::Color::isExtended const):

7:29 PM Changeset in webkit [220377] by commit-queue@webkit.org
  • 3 edits
    1 add in trunk

GetOwnProperty of TypedArray indexed fields is wrongly configurable
​https://bugs.webkit.org/show_bug.cgi?id=175307

Patch by Robin Morisset <​rmorisset@apple.com> on 2017-08-07
Reviewed by Saam Barati.

JSTests:

  • stress/typedarray-getownproperty-not-configurable.js: Added.

(assert):
(foo):

Source/JavaScriptCore:

`
let a = new Uint8Array(10);
let b = Object.getOwnPropertyDescriptor(a, 0);
assert(b.configurable === false);
`
should not fail: by section 9.4.5.1 (​https://tc39.github.io/ecma262/#sec-integer-indexed-exotic-objects-getownproperty-p)
that applies to integer indexed exotic objects, and section 22.2.7 (​https://tc39.github.io/ecma262/#sec-properties-of-typedarray-instances)
that says that typed arrays are integer indexed exotic objects.

  • runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::getOwnPropertySlotByIndex):

7:28 PM Changeset in webkit [220376] by Brent Fulgham
  • 5 edits in trunk

Source/WebCore:
Implement the HTML5 same-origin restriction specification
​https://bugs.webkit.org/show_bug.cgi?id=175226
<rdar://problem/11079948>

Reviewed by Chris Dumez.

Follow the algorithms defined in the HTML5 specification for relaxing
the same-origin restriction. We were missing a few steps related to
checking for public suffix and presence of a browsing context.

Tested by new TestWebKitAPI tests.

  • dom/Document.cpp:

(WebCore::Document::domainIsRegisterable): Added helper function.
(WebCore::Document::setDomain):

Tools:
Prevent domain from being set to a TLD
​https://bugs.webkit.org/show_bug.cgi?id=175226
<rdar://problem/11079948>

Reviewed by Chris Dumez.

Extend the public suffix tests to include cases used by the
Public Domain 'Public Suffix List'.

  • TestWebKitAPI/Tests/mac/PublicSuffix.cpp:

(TestWebKitAPI::TEST):

6:05 PM Changeset in webkit [220375] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked media/modern-media-controls/fullscreen-support/fullscreen-support-press.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=173946

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
5:53 PM Changeset in webkit [220374] by Matt Lewis
  • 1 edit
    3 adds in trunk/LayoutTests

Rebaselined js/dom/global-constructors-attributes.html on El Capitan.
​https://bugs.webkit.org/show_bug.cgi?id=175201

Unreviewed test gardening.

  • platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-dedicated-worker-expected.txt: Added.
5:47 PM Changeset in webkit [220373] by commit-queue@webkit.org
  • 11 edits
    10 adds
    2 deletes in trunk/PerformanceTests

Speedometer: Update to modern production Ember version
​https://bugs.webkit.org/show_bug.cgi?id=175278

Patch by Mathias Bynens <​mathias@qiwi.be> on 2017-08-07
Reviewed by Ryosuke Niwa.

  • Speedometer/resources/todomvc/architecture-examples/emberjs/README.md: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/index.html: Made title consistent.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/README.md: Documented build process.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/components/.gitkeep: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/index.html: Made title consistent.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/instance-initializers/global.js: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/models/.gitkeep: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/router.js: Update to latest version.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/routes/.gitkeep: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/services/repo.js: Update to latest version
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/styles/app.css: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/app/templates/components/.gitkeep: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/bower.json: Update to latest version.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/config/environment.js: Update to latest version.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/dist/*: Added generated files per build instructions.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/package-lock.json: Pinned dependencies.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/package.json: Update to latest version.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/.jshintrc: Removed.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/helpers/module-for-acceptance.js: Updated to latest version.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/helpers/start-app.js: Updated to latest version.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/index.html: Updated to latest version.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/integration/.gitkeep: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/tests/unit/.gitkeep: Added.
  • Speedometer/resources/todomvc/architecture-examples/emberjs/source/vendor/.gitkeep: Added.
5:25 PM Changeset in webkit [220372] by commit-queue@webkit.org
  • 8 edits
    1 add in trunk/Tools

[XCode] webkit-patch should run sort-Xcode-project-file
​https://bugs.webkit.org/show_bug.cgi?id=174036
<rdar://problem/33732709>

Patch by Stephan Szabo <​stephan.szabo@sony.com> on 2017-08-07
Reviewed by Simon Fraser.

  • Scripts/webkitpy/common/config/ports.py:
  • Scripts/webkitpy/tool/commands/download.py:
  • Scripts/webkitpy/tool/commands/download_unittest.py:
  • Scripts/webkitpy/tool/commands/upload.py:
  • Scripts/webkitpy/tool/commands/upload_unittest.py:
  • Scripts/webkitpy/tool/steps/init.py:
  • Scripts/webkitpy/tool/steps/options.py:
  • Scripts/webkitpy/tool/steps/sortxcodeprojectfiles.py: Added.
4:56 PM Changeset in webkit [220371] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Changed expectations for webrtc/video-rotation.html.
​https://bugs.webkit.org/show_bug.cgi?id=175305

Unreviewed test gardening.

4:55 PM Changeset in webkit [220370] by Devin Rousso
  • 36 edits
    8 adds in trunk

Web Inspector: Preview Canvas path when viewing a recording
​https://bugs.webkit.org/show_bug.cgi?id=174967

Reviewed by Brian Burg.

Source/WebCore:

Tests: fast/canvas/2d.currentPoint.html

fast/canvas/2d.getPath.modification.html
fast/canvas/2d.getPath.newobject.html
fast/canvas/2d.setPath.html

  • html/canvas/CanvasPath.idl:
  • html/canvas/CanvasPath.h:
  • html/canvas/CanvasPath.cpp:

(WebCore::CanvasPath::currentX const):
(WebCore::CanvasPath::currentY const):

  • html/canvas/CanvasRenderingContext2D.idl:
  • html/canvas/CanvasRenderingContext2D.h:
  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::setPath):
(WebCore::CanvasRenderingContext2D::getPath const):

  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setInspectorAdditionsEnabled):
(WebCore::RuntimeEnabledFeatures::inspectorAdditionsEnabled const):
Add runtime flag for added IDL items above so that they are only usable within the inspector
process. The runtime flag is not enabled from anywhere else as of now.

  • inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::buildInitialState):
Send current path as part of the InitialState.
Drive-by: deduplicate more string values.

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Base/Setting.js:
  • UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView):
(WI.RecordingContentView.supportsCanvasPathDebugging):
(WI.RecordingContentView.prototype.get navigationItems):
(WI.RecordingContentView.prototype.shown):
(WI.RecordingContentView.prototype._generateContentCanvas2D):
(WI.RecordingContentView.prototype._actionModifiesPath):
(WI.RecordingContentView.prototype._updateCanvasPath):
(WI.RecordingContentView.prototype._showPathButtonClicked):
Show each segment of the current path as an overlay when the setting is enabled.
Drive-by: fix forgotten function rename.

  • UserInterface/Views/RecordingContentView.css:

(.content-view:not(.tab).recording canvas.path):

  • UserInterface/Views/RecordingStateDetailsSidebarPanel.js:

(WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D):
Show the currentX/currentY in the current state.

  • UserInterface/Models/RecordingAction.js:

(WI.RecordingAction.isFunctionForType):
(WI.RecordingAction.prototype.swizzle):
Use Sets for better performance.

Source/WebKit:

  • Shared/WebPreferencesDefinitions.h:
  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetInspectorAdditionsEnabled):
(WKPreferencesGetInspectorAdditionsEnabled):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):
Add plumbing for new InspectorAdditions runtime flag.

  • WebProcess/WebPage/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::WebInspectorUI):
Enable InspectorAdditions by default in the WebInspector page.

Source/WebKitLegacy/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences inspectorAdditionsEnabled]):
(-[WebPreferences setInspectorAdditionsEnabled:]):

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):
Add plumbing for new InspectorAdditions runtime flag.

Tools:

  • DumpRenderTree/TestOptions.h:
  • DumpRenderTree/TestOptions.mm:

(TestOptions::TestOptions):

  • DumpRenderTree/mac/DumpRenderTree.mm:

(setWebPreferencesForTestOptions):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):

  • WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):
Add plumbing for new InspectorAdditions runtime flag.

LayoutTests:

  • fast/canvas/2d.currentPoint-expected.txt: Added.
  • fast/canvas/2d.currentPoint.html: Added.
  • fast/canvas/2d.getPath.modification-expected.txt: Added.
  • fast/canvas/2d.getPath.modification.html: Added.
  • fast/canvas/2d.getPath.newobject-expected.txt: Added.
  • fast/canvas/2d.getPath.newobject.html: Added.
  • fast/canvas/2d.setPath-expected.txt: Added.
  • fast/canvas/2d.setPath.html: Added.
  • inspector/canvas/recording-2d-expected.txt:
  • inspector/canvas/recording-2d.html:

Updated for additional deduplication in InitialState.

4:33 PM Changeset in webkit [220369] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

Sorted EWS Queues on Patch page
​https://bugs.webkit.org/show_bug.cgi?id=173667

Patch by obinna obike <​oobike@apple.com> on 2017-08-07
Reviewed by Aakash Jain.

  • QueueStatusServer/handlers/patch.py:

(Patch.get): Sorted queue_status.

  • QueueStatusServer/templates/patch.html:

Changed queue_status.items to queue_status because it's a list.

4:30 PM Changeset in webkit [220368] by fpizlo@apple.com
  • 14 edits in trunk/Source

Baseline JIT should do caging
​https://bugs.webkit.org/show_bug.cgi?id=175037

Reviewed by Mark Lam.
Source/bmalloc:


This centralizes the notion of permanently enabling the primitive gigacage, which we only do in jsc
and WebProcess.

This saves the baseline JIT from emitting some code. Otherwise it would always have to emit enabled
checks on each typed array access.

  • bmalloc/Gigacage.cpp:

(Gigacage::primitiveGigacageDisabled):
(Gigacage::disableDisablingPrimitiveGigacageIfShouldBeEnabled):
(Gigacage::isDisablingPrimitiveGigacageDisabled):

  • bmalloc/Gigacage.h:

(Gigacage::isPrimitiveGigacagePermanentlyEnabled):
(Gigacage::canPrimitiveGigacageBeDisabled):

Source/JavaScriptCore:


Adds a AssemblyHelpers::cage and cageConditionally. Uses it in the baseline JIT.

Also modifies FTL caging to be more defensive when caging is disabled.

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::caged):

  • jit/AssemblyHelpers.h:

(JSC::AssemblyHelpers::cage):
(JSC::AssemblyHelpers::cageConditionally):

  • jit/JITPropertyAccess.cpp:

(JSC::JIT::emitDoubleLoad):
(JSC::JIT::emitContiguousLoad):
(JSC::JIT::emitArrayStorageLoad):
(JSC::JIT::emitGenericContiguousPutByVal):
(JSC::JIT::emitArrayStoragePutByVal):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitIntTypedArrayGetByVal):
(JSC::JIT::emitFloatTypedArrayGetByVal):
(JSC::JIT::emitIntTypedArrayPutByVal):
(JSC::JIT::emitFloatTypedArrayPutByVal):

  • jsc.cpp:

(jscmain):
(primitiveGigacageDisabled): Deleted.

Source/WebKit:


Use a better API to disable disabling the primitive gigacage.

  • WebProcess/WebProcess.cpp:

(WebKit::m_webSQLiteDatabaseTracker):
(WebKit::primitiveGigacageDisabled): Deleted.

Source/WTF:

  • wtf/Gigacage.h:

(Gigacage::disableDisablingPrimitiveGigacageIfShouldBeEnabled):
(Gigacage::isDisablingPrimitiveGigacageDisabled):
(Gigacage::isPrimitiveGigacagePermanentlyEnabled):
(Gigacage::canPrimitiveGigacageBeDisabled):

4:25 PM Changeset in webkit [220367] by commit-queue@webkit.org
  • 3 edits in trunk/Tools

check-webkit-style: NS_ERROR_ENUM and NS_OPTIONS should not be handled as function definitions.
​https://bugs.webkit.org/show_bug.cgi?id=175286

Patch by Yoshiaki Jitsukawa <​Yoshiaki.Jitsukawa@sony.com> on 2017-08-07
Reviewed by Myles C. Maxfield.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_braces):

  • Scripts/webkitpy/style/checkers/cpp_unittest.py:

(WebKitStyleTest.test_braces.NS_ERROR_ENUM):
(WebKitStyleTest.test_braces):
(WebKitStyleTest.test_braces.NS_OPTIONS):

4:22 PM Changeset in webkit [220366] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Update sendBeacon() to rely on FetchBody instead of the whole FetchRequest
​https://bugs.webkit.org/show_bug.cgi?id=175280

Reviewed by Youenn Fablet.

Update sendBeacon() to rely on FetchBody instead of the whole FetchRequest. FetchBody
for data extraction is really the only thing we need at the moment.
The new code also properly sets the CORS mode, which will be needed for Bug 175264.

  • Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

4:18 PM Changeset in webkit [220365] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.0-branch/Source

Versioning.

4:16 PM Changeset in webkit [220364] by jmarcell@apple.com
  • 7 edits in branches/safari-604.1.38.1-branch/Source

Versioning.

4:12 PM Changeset in webkit [220363] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.0.1

Tag Safari-604.1.38.0.1.

4:10 PM Changeset in webkit [220362] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.1.38.1.1

Tag Safari-604.1.38.1.1.

3:43 PM Changeset in webkit [220361] by msaboff@apple.com
  • 2 edits in trunk/PerformanceTests

REGRESSION(r220307): Perf bot failure trying to run RexBench tests
​https://bugs.webkit.org/show_bug.cgi?id=175289

Reviewed by Filip Pizlo.

Add RexBench to the list of benchmarks we skip on the perf bots.

  • Skipped:
3:31 PM Changeset in webkit [220360] by Jon Davis
  • 2 edits in trunk/Websites/webkit.org

Fixed superscript rendering for blog posts
​https://bugs.webkit.org/show_bug.cgi?id=175285

Reviewed by Filip Pizlo.

  • wp-content/themes/webkit/style.css:

(sup): Added.

3:26 PM Changeset in webkit [220359] by matthew_hanson@apple.com
  • 7 edits in branches/safari-604.1.38.1-branch/Source

Versioning.

3:24 PM Changeset in webkit [220358] by matthew_hanson@apple.com
  • 1 copy in branches/safari-604.1.38.1-branch

New branch.

3:22 PM Changeset in webkit [220357] by matthew_hanson@apple.com
  • 2 edits in branches/safari-604.1.38.0-branch/Source/WebKit

Cherry-pick r220273. rdar://problem/33732757

3:20 PM Changeset in webkit [220356] by matthew_hanson@apple.com
  • 7 edits in branches/safari-604.1.38.0-branch/Source

Versioning.

3:09 PM Changeset in webkit [220355] by matthew_hanson@apple.com
  • 1 copy in branches/safari-604.1.38.0-branch

New branch.

3:01 PM Changeset in webkit [220354] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore

-Wimplicit-fallthrough warning in ComputedStyleExtractor::propertyValue
​https://bugs.webkit.org/show_bug.cgi?id=174469
<rdar://problem/33311638>

Reviewed by Simon Fraser.

Add a RELEASE_ASSERT_NOT_REACHED to silence this warning.

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::propertyValue):

2:53 PM Changeset in webkit [220353] by fpizlo@apple.com
  • 3 edits in trunk/Source/WTF

Unreviewed, try to fix Windows build.

  • wtf/Gigacage.cpp:
  • wtf/Gigacage.h:
2:31 PM Changeset in webkit [220352] by fpizlo@apple.com
  • 54 edits
    1 move
    1 add in trunk/Source

Primitive auxiliaries and JSValue auxiliaries should have separate gigacages
​https://bugs.webkit.org/show_bug.cgi?id=174919

Reviewed by Keith Miller.
Source/bmalloc:


This introduces two kinds of Gigacage, Primitive and JSValue. This translates to two kinds of
HeapKind, PrimitiveGigacage and JSValueGigacage.

The new support functionality required turning Inline.h into BInline.h, and INLINE into BINLINE, and
NO_INLINE into BNO_INLINE.

  • bmalloc.xcodeproj/project.pbxproj:
  • bmalloc/Allocator.cpp:

(bmalloc::Allocator::refillAllocatorSlowCase):
(bmalloc::Allocator::refillAllocator):
(bmalloc::Allocator::allocateLarge):
(bmalloc::Allocator::allocateLogSizeClass):

  • bmalloc/AsyncTask.h:
  • bmalloc/BInline.h: Copied from Source/bmalloc/bmalloc/Inline.h.
  • bmalloc/Cache.cpp:

(bmalloc::Cache::tryAllocateSlowCaseNullCache):
(bmalloc::Cache::allocateSlowCaseNullCache):
(bmalloc::Cache::deallocateSlowCaseNullCache):
(bmalloc::Cache::reallocateSlowCaseNullCache):

  • bmalloc/Deallocator.cpp:
  • bmalloc/Gigacage.cpp:

(Gigacage::PrimitiveDisableCallbacks::PrimitiveDisableCallbacks):
(Gigacage::ensureGigacage):
(Gigacage::disablePrimitiveGigacage):
(Gigacage::addPrimitiveDisableCallback):
(Gigacage::removePrimitiveDisableCallback):
(Gigacage::Callbacks::Callbacks): Deleted.
(Gigacage::disableGigacage): Deleted.
(Gigacage::addDisableCallback): Deleted.
(Gigacage::removeDisableCallback): Deleted.

  • bmalloc/Gigacage.h:

(Gigacage::name):
(Gigacage::basePtr):
(Gigacage::forEachKind):
(Gigacage::caged):
(Gigacage::isCaged):

  • bmalloc/Heap.cpp:

(bmalloc::Heap::Heap):
(bmalloc::Heap::usingGigacage):
(bmalloc::Heap::gigacageBasePtr):

  • bmalloc/Heap.h:
  • bmalloc/HeapKind.h:

(bmalloc::isGigacage):
(bmalloc::gigacageKind):
(bmalloc::heapKind):

  • bmalloc/Inline.h: Removed.
  • bmalloc/Map.h:
  • bmalloc/PerProcess.h:

(bmalloc::PerProcess<T>::getFastCase):
(bmalloc::PerProcess<T>::get):
(bmalloc::PerProcess<T>::getSlowCase):

  • bmalloc/PerThread.h:

(bmalloc::PerThread<T>::getFastCase):

  • bmalloc/Vector.h:

(bmalloc::Vector<T>::push):
(bmalloc::Vector<T>::shrinkCapacity):
(bmalloc::Vector<T>::growCapacity):

Source/JavaScriptCore:


This adapts JSC to there being two gigacages.

To make matters simpler, this turns AlignedMemoryAllocators into per-VM instances rather than
singletons. I don't think we were gaining anything by making them be singletons.

This makes it easy to teach GigacageAlignedMemoryAllocator that there are multiple kinds of
gigacages. We'll have one of those allocators per cage.

From there, this change teaches everyone who previously knew about cages that there are two cages.
This means having to specify either Gigacage::Primitive or Gigacage::JSValue. In most places, this is
easy: typed arrays are Primitive and butterflies are JSValue. But there are a few places where it's
not so obvious, so this change introduces some helpers to make it easy to define what cage you want
to use in one place and refer to it abstractly. We do this in DirectArguments and GenericArguments.h

A lot of the magic of this change is due to CagedBarrierPtr, which combines AuxiliaryBarrier and
CagedPtr. This removes one layer of "get()" calls from a bunch of places.

(JSC::AccessCase::generateImpl):

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::emitAllocateRawObject):
(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileNewTypedArray):
(JSC::DFG::SpeculativeJIT::emitAllocateButterfly):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileGetButterfly):
(JSC::FTL::DFG::LowerDFGToB3::compileGetIndexedPropertyStorage):
(JSC::FTL::DFG::LowerDFGToB3::compileNewTypedArray):
(JSC::FTL::DFG::LowerDFGToB3::compileGetDirectPname):
(JSC::FTL::DFG::LowerDFGToB3::compileMaterializeNewObject):
(JSC::FTL::DFG::LowerDFGToB3::allocatePropertyStorageWithSizeImpl):
(JSC::FTL::DFG::LowerDFGToB3::allocateJSArray):
(JSC::FTL::DFG::LowerDFGToB3::caged):

  • heap/FastMallocAlignedMemoryAllocator.cpp:

(JSC::FastMallocAlignedMemoryAllocator::instance): Deleted.

  • heap/FastMallocAlignedMemoryAllocator.h:
  • heap/GigacageAlignedMemoryAllocator.cpp:

(JSC::GigacageAlignedMemoryAllocator::GigacageAlignedMemoryAllocator):
(JSC::GigacageAlignedMemoryAllocator::tryAllocateAlignedMemory):
(JSC::GigacageAlignedMemoryAllocator::freeAlignedMemory):
(JSC::GigacageAlignedMemoryAllocator::dump const):
(JSC::GigacageAlignedMemoryAllocator::instance): Deleted.

  • heap/GigacageAlignedMemoryAllocator.h:
  • jsc.cpp:

(primitiveGigacageDisabled):
(jscmain):
(gigacageDisabled): Deleted.

  • llint/LowLevelInterpreter64.asm:
  • runtime/ArrayBuffer.cpp:

(JSC::ArrayBufferContents::tryAllocate):
(JSC::ArrayBuffer::createAdopted):
(JSC::ArrayBuffer::createFromBytes):

  • runtime/AuxiliaryBarrier.h:
  • runtime/ButterflyInlines.h:

(JSC::Butterfly::createUninitialized):
(JSC::Butterfly::tryCreate):
(JSC::Butterfly::growArrayRight):

  • runtime/CagedBarrierPtr.h: Added.

(JSC::CagedBarrierPtr::CagedBarrierPtr):
(JSC::CagedBarrierPtr::clear):
(JSC::CagedBarrierPtr::set):
(JSC::CagedBarrierPtr::get const):
(JSC::CagedBarrierPtr::getMayBeNull const):
(JSC::CagedBarrierPtr::operator== const):
(JSC::CagedBarrierPtr::operator!= const):
(JSC::CagedBarrierPtr::operator bool const):
(JSC::CagedBarrierPtr::setWithoutBarrier):
(JSC::CagedBarrierPtr::operator* const):
(JSC::CagedBarrierPtr::operator-> const):
(JSC::CagedBarrierPtr::operator[] const):

  • runtime/DirectArguments.cpp:

(JSC::DirectArguments::overrideThings):
(JSC::DirectArguments::unmapArgument):

  • runtime/DirectArguments.h:

(JSC::DirectArguments::isMappedArgument const):

  • runtime/GenericArguments.h:
  • runtime/GenericArgumentsInlines.h:

(JSC::GenericArguments<Type>::initModifiedArgumentsDescriptor):
(JSC::GenericArguments<Type>::setModifiedArgumentDescriptor):
(JSC::GenericArguments<Type>::isModifiedArgumentDescriptor):

  • runtime/HashMapImpl.cpp:

(JSC::HashMapImpl<HashMapBucket>::visitChildren):

  • runtime/HashMapImpl.h:

(JSC::HashMapBuffer::create):
(JSC::HashMapImpl::buffer const):
(JSC::HashMapImpl::rehash):

  • runtime/JSArray.cpp:

(JSC::JSArray::tryCreateUninitializedRestricted):
(JSC::JSArray::unshiftCountSlowCase):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::fastSlice):
(JSC::JSArray::shiftCountWithArrayStorage):
(JSC::JSArray::shiftCountWithAnyIndexingType):
(JSC::JSArray::unshiftCountWithAnyIndexingType):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToArguments):

  • runtime/JSArray.h:

(JSC::JSArray::tryCreate):

  • runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::ConstructionContext::ConstructionContext):
(JSC::JSArrayBufferView::finalize):

  • runtime/JSLock.cpp:

(JSC::JSLock::didAcquireLock):

  • runtime/JSObject.cpp:

(JSC::JSObject::heapSnapshot):
(JSC::JSObject::getOwnPropertySlotByIndex):
(JSC::JSObject::putByIndex):
(JSC::JSObject::enterDictionaryIndexingMode):
(JSC::JSObject::createInitialIndexedStorage):
(JSC::JSObject::createArrayStorage):
(JSC::JSObject::convertUndecidedToInt32):
(JSC::JSObject::convertUndecidedToDouble):
(JSC::JSObject::convertUndecidedToContiguous):
(JSC::JSObject::constructConvertedArrayStorageWithoutCopyingElements):
(JSC::JSObject::convertUndecidedToArrayStorage):
(JSC::JSObject::convertInt32ToDouble):
(JSC::JSObject::convertInt32ToContiguous):
(JSC::JSObject::convertInt32ToArrayStorage):
(JSC::JSObject::convertDoubleToContiguous):
(JSC::JSObject::convertDoubleToArrayStorage):
(JSC::JSObject::convertContiguousToArrayStorage):
(JSC::JSObject::setIndexQuicklyToUndecided):
(JSC::JSObject::ensureArrayStorageExistsAndEnterDictionaryIndexingMode):
(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::getOwnPropertyNames):
(JSC::JSObject::putIndexedDescriptor):
(JSC::JSObject::defineOwnIndexedProperty):
(JSC::JSObject::putByIndexBeyondVectorLengthWithoutAttributes):
(JSC::JSObject::putDirectIndexSlowOrBeyondVectorLength):
(JSC::JSObject::getNewVectorLength):
(JSC::JSObject::ensureLengthSlow):
(JSC::JSObject::reallocateAndShrinkButterfly):
(JSC::JSObject::allocateMoreOutOfLineStorage):
(JSC::JSObject::getEnumerableLength):

  • runtime/JSObject.h:

(JSC::JSObject::getArrayLength const):
(JSC::JSObject::getVectorLength):
(JSC::JSObject::putDirectIndex):
(JSC::JSObject::canGetIndexQuickly):
(JSC::JSObject::getIndexQuickly):
(JSC::JSObject::tryGetIndexQuickly const):
(JSC::JSObject::canSetIndexQuickly):
(JSC::JSObject::setIndexQuickly):
(JSC::JSObject::initializeIndex):
(JSC::JSObject::initializeIndexWithoutBarrier):
(JSC::JSObject::hasSparseMap):
(JSC::JSObject::inSparseIndexingMode):
(JSC::JSObject::butterfly const):
(JSC::JSObject::butterfly):
(JSC::JSObject::outOfLineStorage const):
(JSC::JSObject::outOfLineStorage):
(JSC::JSObject::ensureInt32):
(JSC::JSObject::ensureDouble):
(JSC::JSObject::ensureContiguous):
(JSC::JSObject::ensureArrayStorage):
(JSC::JSObject::arrayStorage):
(JSC::JSObject::arrayStorageOrNull):
(JSC::JSObject::ensureLength):

  • runtime/RegExpMatchesArray.h:

(JSC::tryCreateUninitializedRegExpMatchesArray):

  • runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::~VM):
(JSC::VM::primitiveGigacageDisabledCallback):
(JSC::VM::primitiveGigacageDisabled):
(JSC::VM::gigacageDisabledCallback): Deleted.
(JSC::VM::gigacageDisabled): Deleted.

  • runtime/VM.h:

(JSC::VM::gigacageAuxiliarySpace):
(JSC::VM::firePrimitiveGigacageEnabledIfNecessary):
(JSC::VM::primitiveGigacageEnabled):
(JSC::VM::fireGigacageEnabledIfNecessary): Deleted.
(JSC::VM::gigacageEnabled): Deleted.

  • wasm/WasmMemory.cpp:

(JSC::Wasm::Memory::create):
(JSC::Wasm::Memory::~Memory):
(JSC::Wasm::Memory::grow):

Source/WebCore:

No new tests because no change in behavior.

Adapting to API changes - we now specify the AlignedMemoryAllocator differently and we need to be
specific about which Gigacage we're using.

  • bindings/js/WebCoreJSClientData.cpp:

(WebCore::JSVMClientData::JSVMClientData):

  • platform/graphics/cocoa/GPUBufferMetal.mm:

(WebCore::GPUBuffer::GPUBuffer):

Source/WebKit:


The disable callback is all about the primitive gigacage.

  • WebProcess/WebProcess.cpp:

(WebKit::primitiveGigacageDisabled):
(WebKit::m_webSQLiteDatabaseTracker):
(WebKit::gigacageDisabled): Deleted.

Source/WTF:


This mirrors the changes from bmalloc/Gigacage.h.

Also it teaches CagedPtr how to reason about multiple gigacages.

  • wtf/CagedPtr.h:

(WTF::CagedPtr::get const):
(WTF::CagedPtr::operator[] const):

  • wtf/Gigacage.cpp:

(Gigacage::tryMalloc):
(Gigacage::tryAllocateVirtualPages):
(Gigacage::freeVirtualPages):
(Gigacage::tryAlignedMalloc):
(Gigacage::alignedFree):
(Gigacage::free):

  • wtf/Gigacage.h:

(Gigacage::disablePrimitiveGigacage):
(Gigacage::addPrimitiveDisableCallback):
(Gigacage::removePrimitiveDisableCallback):
(Gigacage::name):
(Gigacage::basePtr):
(Gigacage::caged):
(Gigacage::isCaged):
(Gigacage::tryAlignedMalloc):
(Gigacage::alignedFree):
(Gigacage::free):
(Gigacage::disableGigacage): Deleted.
(Gigacage::addDisableCallback): Deleted.
(Gigacage::removeDisableCallback): Deleted.

1:58 PM Changeset in webkit [220351] by commit-queue@webkit.org
  • 4 edits
    1 add in trunk/Source/WebCore

[Curl] Add abstraction layer of cookie jar implementation for Curl port
​https://bugs.webkit.org/show_bug.cgi?id=174943

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-08-07
Reviewed by Brent Fulgham.

  • platform/network/curl/CookieJarCurl.cpp:

(WebCore::CookieJarCurlFileSystem::setCookiesFromDOM):
(WebCore::CookieJarCurlFileSystem::cookiesForDOM):
(WebCore::CookieJarCurlFileSystem::cookieRequestHeaderFieldValue):
(WebCore::CookieJarCurlFileSystem::cookiesEnabled):
(WebCore::CookieJarCurlFileSystem::getRawCookies):
(WebCore::CookieJarCurlFileSystem::deleteCookie):
(WebCore::CookieJarCurlFileSystem::getHostnamesWithCookies):
(WebCore::CookieJarCurlFileSystem::deleteCookiesForHostnames):
(WebCore::CookieJarCurlFileSystem::deleteAllCookies):
(WebCore::CookieJarCurlFileSystem::deleteAllCookiesModifiedSince):
(WebCore::cookiesForDOM):
(WebCore::setCookiesFromDOM):
(WebCore::cookieRequestHeaderFieldValue):
(WebCore::cookiesEnabled):
(WebCore::getRawCookies):
(WebCore::deleteCookie):
(WebCore::getHostnamesWithCookies):
(WebCore::deleteCookiesForHostnames):
(WebCore::deleteAllCookies):
(WebCore::deleteAllCookiesModifiedSince):

  • platform/network/curl/CookieJarCurl.h: Added.
  • platform/network/curl/CurlContext.cpp:
  • platform/network/curl/CurlContext.h:

(WebCore::CurlContext::cookieJar):

1:30 PM Changeset in webkit [220350] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip workers/wasm-hashset-many.html and workers/wasm-hashset-many-2.html on El Capitan.
​https://bugs.webkit.org/show_bug.cgi?id=175102

Unreviewed test gardening.

  • platform/mac/TestExpectations:
11:58 AM Changeset in webkit [220349] by matthew_hanson@apple.com
  • 2 edits in branches/safari-604.1-branch/Source/WebCore

Cherry-pick r220248. rdar://problem/33754446

11:55 AM Changeset in webkit [220348] by matthew_hanson@apple.com
  • 2 edits in branches/safari-604.1-branch/Source/WebKit

Cherry-pick r220273. rdar://problem/33732754

11:55 AM Changeset in webkit [220347] by matthew_hanson@apple.com
  • 4 edits in branches/safari-604.1-branch/Source/WebCore

Cherry-pick r220247. rdar://problem/33754440

11:42 AM Changeset in webkit [220346] by commit-queue@webkit.org
  • 3 edits in trunk/Source/JavaScriptCore

Unreviewed, rolling out r220144.
​https://bugs.webkit.org/show_bug.cgi?id=175276

"It did not actually speed things up in the way I expected"
(Requested by saamyjoon on #webkit).

Reverted changeset:

"On memory-constrained iOS devices, reduce the rate at which
the JS heap grows before a GC to try to keep more memory
available for the system"
​https://bugs.webkit.org/show_bug.cgi?id=175041
​http://trac.webkit.org/changeset/220144

11:25 AM Changeset in webkit [220345] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Marking imported/w3c/web-platform-tests/html/browsers/windows/noreferrer-window-name.html as failing on iOS.
​https://bugs.webkit.org/show_bug.cgi?id=175273

Unreviewed test gardening.

  • platform/ios/TestExpectations:
11:22 AM Changeset in webkit [220344] by beidson@apple.com
  • 62 edits
    4 copies in trunk

Implement most of ServiceWorkerContainer::addRegistration.
​https://bugs.webkit.org/show_bug.cgi?id=175237

Reviewed by Andy Estes.

LayoutTests/imported/w3c:

  • web-platform-tests/FileAPI/historical.https-expected.txt:
  • web-platform-tests/background-fetch/interfaces-worker.https-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-no-referrer-service-worker.https-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-origin-service-worker.https-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https-expected.txt:
  • web-platform-tests/fetch/api/policies/referrer-unsafe-url-service-worker.https-expected.txt:
  • web-platform-tests/html/webappapis/scripting/events/messageevent-constructor.https-expected.txt:
  • web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/canblock-serviceworker.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-add.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-delete.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-keys.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-matchAll.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-put.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-keys.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-match.https-expected.txt:
  • web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage.https-expected.txt:
  • web-platform-tests/streams/byte-length-queuing-strategy.serviceworker.https-expected.txt:
  • web-platform-tests/streams/count-queuing-strategy.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/close-propagation-backward.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/close-propagation-forward.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/error-propagation-backward.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/error-propagation-forward.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/flow-control.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/general.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/multiple-propagation.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/pipe-through.serviceworker.https-expected.txt:
  • web-platform-tests/streams/piping/transform-streams.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-byte-streams/general.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/bad-strategies.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/bad-underlying-sources.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/brand-checks.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/cancel.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/default-reader.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/floating-point-total-queue-size.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/garbage-collection.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/general.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/pipe-through.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/readable-stream-reader.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/tee.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/templated.serviceworker.https-expected.txt:

Source/WebCore:

No new tests (Covered by changes to existing tests).

There's still so much supporting infrastructure to add with these early patches
that I'm still moving them in baby steps for now, hence not implementing
register() all in one shot.

Things will start moving very quickly once we no longer need to add lots of new
primitives in each change.

  • CMakeLists.txt:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::navigator const):

  • page/Navigator.cpp:

(WebCore::Navigator::Navigator): Make the constructor take a ScriptExecutionContext for

creation of objects where its import (e.g. ServiceWorkerContainer).

  • page/Navigator.h:
  • page/WorkerNavigator.cpp:

(WebCore::WorkerNavigator::WorkerNavigator): Ditto.

  • page/WorkerNavigator.h:
  • page/NavigatorBase.cpp:

(WebCore::NavigatorBase::NavigatorBase): Create the ServiceWorkerContainer upfront with

the passed-in ScriptExecutionContext.

(WebCore::NavigatorBase::serviceWorker):

  • page/NavigatorBase.h:

Make ServiceWorkerContainer into an ActiveDOMObject. This will eventually be necessary for
Document suspension reasons, but is also necessary because it also needs to be a
ContextDestructionObserver (which ActiveDOMObject is):

  • workers/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::ServiceWorkerContainer):
(WebCore::ServiceWorkerContainer::ready):
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::getRegistration):
(WebCore::ServiceWorkerContainer::getRegistrations):
(WebCore::ServiceWorkerContainer::activeDOMObjectName const):
(WebCore::ServiceWorkerContainer::canSuspendForDocumentSuspension const):
(WebCore::rejectLater): Deleted.
(WebCore::ServiceWorkerContainer::eventTargetInterface const): Deleted.
(WebCore::ServiceWorkerContainer::scriptExecutionContext const): Deleted.

  • workers/ServiceWorkerContainer.h:
  • workers/ServiceWorkerContainer.idl:

Add updateViaCache, etc:

  • workers/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::updateViaCache const):
(WebCore::ServiceWorkerRegistration::update):
(WebCore::ServiceWorkerRegistration::unregister):

  • workers/ServiceWorkerRegistration.h:
  • workers/ServiceWorkerRegistration.idl:
  • workers/ServiceWorkerUpdateViaCache.h: Copied from Source/WebCore/workers/ServiceWorkerRegistration.idl.
  • workers/ServiceWorkerUpdateViaCache.idl: Copied from Source/WebCore/workers/ServiceWorkerRegistration.idl.
  • workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::navigator):
(WebCore::WorkerGlobalScope::navigator const): Deleted.

  • workers/WorkerGlobalScope.h:
  • workers/WorkerType.h: Copied from Source/WebCore/workers/ServiceWorkerRegistration.idl.
  • workers/WorkerType.idl: Copied from Source/WebCore/workers/ServiceWorkerRegistration.idl.
10:06 AM Changeset in webkit [220343] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html.

Unreviewed test gardening.

  • platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
  • platform/mac/js/dom/global-constructors-attributes-expected.txt:
9:44 AM Changeset in webkit [220342] by Ryan Haddad
  • 12 edits
    1 delete in trunk

Unreviewed, rolling out r220299.

This change caused LayoutTest inspector/dom-debugger/dom-
breakpoints.html to fail.

Reverted changeset:

"Web Inspector: capture async stack trace when workers/main
context posts a message"
​https://bugs.webkit.org/show_bug.cgi?id=167084
​http://trac.webkit.org/changeset/220299

9:42 AM Changeset in webkit [220341] by matthew_hanson@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r220273. rdar://problem/33732762

9:42 AM Changeset in webkit [220340] by matthew_hanson@apple.com
  • 6 edits in branches/safari-604-branch

Cherry-pick r220185. rdar://problem/33713534

9:42 AM Changeset in webkit [220339] by matthew_hanson@apple.com
  • 4 edits
    3 adds in branches/safari-604-branch

Cherry-pick r220163. rdar://problem/33711032

9:42 AM Changeset in webkit [220338] by matthew_hanson@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r220153. rdar://problem/33711047

9:32 AM Changeset in webkit [220337] by BJ Burg
  • 6 edits in trunk/Source/WebCore

Cleanup: simplify WebSockets code for RuntimeEnabledFeatures
​https://bugs.webkit.org/show_bug.cgi?id=175190

Reviewed by Sam Weinig.

This runtime enabled flag is not used by anything. It was added
for V8 in <​https://bugs.webkit.org/show_bug.cgi?id=29896>.

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::setIsAvailable): Deleted.
(WebCore::WebSocket::isAvailable): Deleted.

  • Modules/websockets/WebSocket.h:
  • Modules/websockets/WebSocket.idl:
  • page/RuntimeEnabledFeatures.cpp:

(WebCore::RuntimeEnabledFeatures::webSocketEnabled const): Deleted.

  • page/RuntimeEnabledFeatures.h:
9:29 AM Changeset in webkit [220336] by BJ Burg
  • 24 edits in trunk

Remove CANVAS_PATH compilation guard
​https://bugs.webkit.org/show_bug.cgi?id=175207

Reviewed by Sam Weinig.

.:

  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsMac.cmake:
  • Source/cmake/OptionsWin.cmake:
  • Source/cmake/WebKitFeatures.cmake:
  • Source/cmake/tools/vsprops/FeatureDefines.props:
  • Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

  • Configurations/FeatureDefines.xcconfig:

Source/WebCore:

  • Configurations/FeatureDefines.xcconfig:
  • html/canvas/DOMPath.h:
  • html/canvas/DOMPath.idl:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:

Source/WTF:

  • wtf/FeatureDefines.h:

Tools:

  • Scripts/webkitperl/FeatureList.pm:
  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
9:22 AM Changeset in webkit [220335] by pvollan@apple.com
  • 2 edits in trunk/Tools

[Win] Use Visual Studio 2017 if installed.
​https://bugs.webkit.org/show_bug.cgi?id=175188

Reviewed by Sam Weinig.

If installed, use VS2017 to build WebKit. If not, fall back to VS2015.

  • Scripts/webkitdirs.pm:

(visualStudioInstallDir):
(msBuildInstallDir):

8:44 AM Changeset in webkit [220334] by clopez@igalia.com
  • 4 edits in trunk/Source

[WPE][CMake] Only pass pkg-config CFLAGS from (E)GL when not using libepoxy.
​https://bugs.webkit.org/show_bug.cgi?id=175125

Reviewed by Michael Catanzaro.

Source/WebCore:

No change of behavior, covered by existing tests.

  • CMakeLists.txt: Instead of negating 3 times the use of libepoxy

move the logic for (E)GL detection inside an else() block.

Source/WebKit:

  • CMakeLists.txt: When using libepoxy avoid passing the CFLAGS from (E)GL,

and instead pass the libepoxy ones.

6:14 AM Changeset in webkit [220333] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

REGRESSION (r219121): Airmail 3 prints header part only.
​https://bugs.webkit.org/show_bug.cgi?id=175258
<rdar://problem/33601173>

Reviewed by Andreas Kling.

When a WK1 WebViw is printed via AppKit view hierarchy it won't explictly set the page width
but uses the existing width. r219121 assumes that all printing code paths set the page width.

No test, there appears to be no good way to test AppKit printing behaviors without adding complicated
new testing infrastructure.

  • rendering/RenderView.cpp:

(WebCore::RenderView::layout):

If we are in printing layout and don't have page width set yet then use the current view width.
This matches the behavior prior r219121.

6:08 AM Changeset in webkit [220332] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

Remove obsolete failure expectations for wpt browsers tests.
​https://bugs.webkit.org/show_bug.cgi?id=175073

Unreviewed test gardening.

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-07

3:03 AM WebKitGTK/2.16.x edited by clopez@igalia.com
(diff)
2:53 AM Changeset in webkit [220331] by clopez@igalia.com
  • 2 edits in trunk/Source/WebKit

[GTK][WPE] CFLAGS from pkg-config for (E)GL are not passed to WebKit
​https://bugs.webkit.org/show_bug.cgi?id=175125

Unreviewed follow-up fix after r220326.

  • CMakeLists.txt: Move the block appending to WebKit2_LIBRARIES

below where the list itself is created.

12:03 AM Changeset in webkit [220330] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION: wasm.yaml/wasm/js-api/dont-mmap-zero-byte-memory.js failing on JSC Debug bots
​https://bugs.webkit.org/show_bug.cgi?id=175256

Reviewed by Saam Barati.

The check in createFromBytes just needed to check that the buffer was not null before
calling isCaged.

  • runtime/ArrayBuffer.cpp:

(JSC::ArrayBuffer::createFromBytes):

Note: See TracTimeline for information about the timeline view.