Timeline

View changes from
going back days
by author

Repository changesets Wiki changes

Aug 19, 2017:

7:11 PM Changeset in webkit [220955] by aestes@apple.com

• 30 edits
  36 adds in trunk

[Payment Request] Add interface stubs
​https://bugs.webkit.org/show_bug.cgi?id=175730

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/payment-request/allowpaymentrequest/active-document-cross-origin.https.sub-expected.txt:
• web-platform-tests/payment-request/allowpaymentrequest/active-document-same-origin.https-expected.txt:
• web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-same-origin-bc-containers.https-expected.txt:
• web-platform-tests/payment-request/allowpaymentrequest/basic.https-expected.txt:
• web-platform-tests/payment-request/allowpaymentrequest/no-attribute-same-origin-bc-containers.https-expected.txt:
• web-platform-tests/payment-request/historical.https-expected.txt:
• web-platform-tests/payment-request/interfaces.https-expected.txt:
• web-platform-tests/payment-request/payment-request-abort-method.https-expected.txt:
• web-platform-tests/payment-request/payment-request-constructor-crash.https-expected.txt:
• web-platform-tests/payment-request/payment-request-constructor.https-expected.txt:
• web-platform-tests/payment-request/payment-request-id.https-expected.txt:
• web-platform-tests/payment-request/payment-request-in-iframe-expected.txt:
• web-platform-tests/payment-request/payment-request-onshippingaddresschange-attribute.https-expected.txt:
• web-platform-tests/payment-request/payment-request-onshippingoptionchange-attribute.https-expected.txt:
• web-platform-tests/payment-request/payment-request-show-method.https-expected.txt:
• web-platform-tests/payment-request/payment-request-update-event-constructor.http-expected.txt:
• web-platform-tests/payment-request/payment-request-update-event-constructor.https-expected.txt:

Source/JavaScriptCore:

• runtime/CommonIdentifiers.h:

Source/WebCore:

• DerivedSources.make:
• Modules/paymentrequest/PaymentAddress.h: Added.
• Modules/paymentrequest/PaymentAddress.idl: Added.
• Modules/paymentrequest/PaymentComplete.h: Added.
• Modules/paymentrequest/PaymentComplete.idl: Added.
• Modules/paymentrequest/PaymentCurrencyAmount.h: Added.
• Modules/paymentrequest/PaymentCurrencyAmount.idl: Added.
• Modules/paymentrequest/PaymentDetailsBase.h: Added.
• Modules/paymentrequest/PaymentDetailsBase.idl: Added.
• Modules/paymentrequest/PaymentDetailsInit.h: Added.
• Modules/paymentrequest/PaymentDetailsInit.idl: Added.
• Modules/paymentrequest/PaymentDetailsModifier.h: Added.
• Modules/paymentrequest/PaymentDetailsModifier.idl: Added.
• Modules/paymentrequest/PaymentDetailsUpdate.h: Added.
• Modules/paymentrequest/PaymentDetailsUpdate.idl: Added.
• Modules/paymentrequest/PaymentItem.h: Added.
• Modules/paymentrequest/PaymentItem.idl: Added.
• Modules/paymentrequest/PaymentMethodData.h: Added.
• Modules/paymentrequest/PaymentMethodData.idl: Added.
• Modules/paymentrequest/PaymentOptions.h: Added.
• Modules/paymentrequest/PaymentOptions.idl: Added.
• Modules/paymentrequest/PaymentRequest.cpp: Added.

(WebCore::PaymentRequest::create):
(WebCore::PaymentRequest::PaymentRequest):
(WebCore::PaymentRequest::~PaymentRequest):
(WebCore::PaymentRequest::show):
(WebCore::PaymentRequest::abort):
(WebCore::PaymentRequest::canMakePayment):

• Modules/paymentrequest/PaymentRequest.h: Added.
• Modules/paymentrequest/PaymentRequest.idl: Added.
• Modules/paymentrequest/PaymentRequestUpdateEvent.cpp: Added.

(WebCore::PaymentRequestUpdateEvent::~PaymentRequestUpdateEvent):
(WebCore::PaymentRequestUpdateEvent::updateWith):

• Modules/paymentrequest/PaymentRequestUpdateEvent.h: Added.
• Modules/paymentrequest/PaymentRequestUpdateEvent.idl: Added.
• Modules/paymentrequest/PaymentRequestUpdateEventInit.h: Added.
• Modules/paymentrequest/PaymentRequestUpdateEventInit.idl: Added.
• Modules/paymentrequest/PaymentResponse.cpp: Added.

(WebCore::PaymentResponse::complete):

• Modules/paymentrequest/PaymentResponse.h: Added.
• Modules/paymentrequest/PaymentResponse.idl: Added.
• Modules/paymentrequest/PaymentShippingOption.h: Added.
• Modules/paymentrequest/PaymentShippingOption.idl: Added.
• Modules/paymentrequest/PaymentShippingType.h: Added.
• Modules/paymentrequest/PaymentShippingType.idl: Added.
• WebCore.xcodeproj/project.pbxproj:
• dom/EventNames.h:
• dom/EventNames.in:
• dom/EventTargetFactory.in:

LayoutTests:

• TestExpectations: Skipped payment-request tests.
• platform/ios-wk2/TestExpectations: Enabled payment-request tests on ios-wk2.
• platform/mac-wk2/TestExpectations: Ditto for mac-wk2.

10:28 AM Changeset in webkit [220954] by commit-queue@webkit.org

• 15 edits in trunk/Source/WebCore

[WebCrypto] Remove the KeyAlgorithm type hierarchy
​https://bugs.webkit.org/show_bug.cgi?id=175750

Patch by Sam Weinig <​sam@webkit.org> on 2017-08-19
Reviewed by Chris Dumez.

Removes the unnecessary indirection that existed to generate a
KeyAlgorithm dictionary (or rather, one of its derived dictionaries)
for a CryptoKey. We were calling the virtual buildAlgorithm(), which
return a std::unique_ptr<KeyAlgorithm>, which we then casted to the
correct derived class and called dictionary() on. This can now be
simplified by making each CryptoKey derived class override a function
that returns the KeyAlgorithm variant.

• crypto/CryptoKey.cpp:

(WebCore::CryptoKey::algorithm const): Deleted.

• crypto/CryptoKey.h:

(WebCore::CryptoKey::extractable const):
(WebCore::KeyAlgorithm::~KeyAlgorithm): Deleted.
(WebCore::KeyAlgorithm::name const): Deleted.
(WebCore::KeyAlgorithm::KeyAlgorithm): Deleted.

• crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:

(WebCore::CryptoKeyRSA::algorithm const):
(WebCore::CryptoKeyRSA::buildAlgorithm const): Deleted.

• crypto/keys/CryptoKeyAES.cpp:

(WebCore::CryptoKeyAES::algorithm const):
(WebCore::AesKeyAlgorithm::dictionary const): Deleted.
(WebCore::CryptoKeyAES::buildAlgorithm const): Deleted.

• crypto/keys/CryptoKeyAES.h:
• crypto/keys/CryptoKeyEC.cpp:

(WebCore::CryptoKeyEC::algorithm const):
(WebCore::EcKeyAlgorithm::dictionary const): Deleted.
(WebCore::CryptoKeyEC::buildAlgorithm const): Deleted.

• crypto/keys/CryptoKeyEC.h:

(WebCore::EcKeyAlgorithm::EcKeyAlgorithm): Deleted.
(WebCore::EcKeyAlgorithm::namedCurve const): Deleted.

• crypto/keys/CryptoKeyHMAC.cpp:

(WebCore::CryptoKeyHMAC::algorithm const):
(WebCore::HmacKeyAlgorithm::dictionary const): Deleted.
(WebCore::CryptoKeyHMAC::buildAlgorithm const): Deleted.

• crypto/keys/CryptoKeyHMAC.h:
• crypto/keys/CryptoKeyRSA.cpp:

(WebCore::RsaKeyAlgorithm::dictionary const): Deleted.
(WebCore::RsaHashedKeyAlgorithm::dictionary const): Deleted.

• crypto/keys/CryptoKeyRSA.h:

(WebCore::RsaKeyAlgorithm::RsaKeyAlgorithm): Deleted.
(WebCore::RsaKeyAlgorithm::modulusLength const): Deleted.
(WebCore::RsaKeyAlgorithm::publicExponent const): Deleted.

• crypto/keys/CryptoKeyRaw.cpp:

(WebCore::CryptoKeyRaw::algorithm const):
(WebCore::RawKeyAlgorithm::dictionary const): Deleted.
(WebCore::CryptoKeyRaw::buildAlgorithm const): Deleted.

• crypto/keys/CryptoKeyRaw.h:

(WebCore::RawKeyAlgorithm::RawKeyAlgorithm): Deleted.

• crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::CryptoKeyRSA::algorithm const):
(WebCore::CryptoKeyRSA::buildAlgorithm const): Deleted.

9:41 AM Changeset in webkit [220953] by commit-queue@webkit.org

• 7 edits in trunk/Source/WebCore

[Mac] Change uint8_t* to Vector<uint8_t> type in all crypto algorithm implementation
​https://bugs.webkit.org/show_bug.cgi?id=164939

Patch by Sam Weinig <​sam@webkit.org> on 2017-08-19
Reviewed by Chris Dumez.

Address FIXMEs, replacing uint8_t*/size_t parameters with Vector<uint8_t>&.

• crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:

(WebCore::transformAES_CBC):
(WebCore::CryptoAlgorithmAES_CBC::platformEncrypt):
(WebCore::CryptoAlgorithmAES_CBC::platformDecrypt):

• crypto/mac/CryptoAlgorithmAES_KWMac.cpp:

(WebCore::wrapKeyAES_KW):
(WebCore::unwrapKeyAES_KW):
(WebCore::CryptoAlgorithmAES_KW::platformWrapKey):
(WebCore::CryptoAlgorithmAES_KW::platformUnwrapKey):

• crypto/mac/CryptoAlgorithmHMACMac.cpp:

(WebCore::calculateSignature):
(WebCore::CryptoAlgorithmHMAC::platformSign):
(WebCore::CryptoAlgorithmHMAC::platformVerify):

• crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp:

(WebCore::encryptRSAES_PKCS1_v1_5):
(WebCore::decryptRSAES_PKCS1_v1_5):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformDecrypt):

• crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:

(WebCore::signRSASSA_PKCS1_v1_5):
(WebCore::verifyRSASSA_PKCS1_v1_5):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformVerify):

• crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp:

(WebCore::encryptRSA_OAEP):
(WebCore::decryptRSA_OAEP):
(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformDecrypt):

1:46 AM Changeset in webkit [220952] by Wenson Hsieh

• 2 edits in trunk/Tools

[iOS WK2] Add a version of DataInteractionTests.ExternalSourceAttributedStringToContentEditable that doesn't hit a debug assertion
​https://bugs.webkit.org/show_bug.cgi?id=175509
<rdar://problem/33728169>

Reviewed by Ryosuke Niwa.

Removes ExternalSourceAttributedStringToContentEditable and adds
ExternalSourceColoredAttributedStringToContentEditable, which tests dropping an attributed string with colored
text instead of a bold attributed string of system font. Due to a recent change in behavior in UIKit, the
original test (which this patch renames to ExternalSourceBoldSystemAttributedStringToContentEditable) hits a
debug assertion when dropping text of system bold font. Since the original intent of this test was to verify
that the attributed string UTI can be accepted in richly contenteditable areas, it suffices to check that some
other style attribute, such as color, carries over from the NSAttributedString to the DOM.

Also marks ExternalSourceBoldSystemAttributedStringToContentEditable as disabled for the time being.

• TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(TestWebKitAPI::TEST):

Aug 18, 2017:

11:40 PM Changeset in webkit [220951] by rniwa@webkit.org

• 4 edits in trunk/Source/WebCore

Forbid setDragImage after dragstart
​https://bugs.webkit.org/show_bug.cgi?id=175751

Reviewed by Wenson Hsieh.

Removed the code to allow setting the drag mage after dragstart had happened.

The feature was apparently used in Mac WebKit1 port but using it today causes the drag image
to disapepar while the user is moving the mouse cursor and being drawn once it's stopped
and results in the contionus flickering of the drag image.

The feaure was never supported in WebKit2 and doesn't match the HTML5 specification:
​https://html.spec.whatwg.org/multipage/dnd.html#concept-dnd-rw
​https://html.spec.whatwg.org/multipage/dnd.html#dom-datatransfer-setdragimage
or the behaviors of other browsers such as Chrome and Firefox.

No new tests. This patch simply removes code.

• dom/DataTransfer.cpp:

(WebCore::DataTransfer::setDragImage):
(WebCore::DataTransfer::canSetDragImage const): Deleted.

• dom/DataTransfer.h:

(WebCore::DataTransfer::makeDragImageWritable): Deleted.

• page/EventHandler.cpp:

(WebCore::EventHandler::handleDrag):

8:05 PM Changeset in webkit [220950] by rniwa@webkit.org

• 4 edits in trunk

REGRESSION(r219640): Speedometer no longer runs on Safari 7
​https://bugs.webkit.org/show_bug.cgi?id=175749

Reviewed by Joseph Pecoraro.

PerformanceTests:

Use regular string instead of template literal to make the script compatible with older versions of Safari.

• Speedometer/resources/benchmark-runner.js:

(BenchmarkRunner.prototype._runTest):

Websites/browserbench.org:

Fix the bug on browserbench.org.

• Speedometer/resources/benchmark-runner.js:

(BenchmarkRunner.prototype._runTest):

6:40 PM Changeset in webkit [220949] by weinig@apple.com

• 24 edits
  2 moves
  3 deletes in trunk/Source/WebCore

[WebCrypto] Get rid of CryptoKeyData class and all its subclasses
​https://bugs.webkit.org/show_bug.cgi?id=169806

Reviewed by Chris Dumez.

• Replaces the CryptoKeyData type hierarchy

CryptoKeyData

• CryptoKeyDataOctetSequence
• CryptoKeyDataRSAComponents

with the renamed CryptoKeyRSAComponents.

• Removes pure virtual exportData function on CryptoKey, and all the implementations except the one on CryptoKeyRSA, which now is non-virtual, and returns a CryptoKeyRSAComponents. Update the one external caller, SerializedScriptValue, to handle this.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/SerializedScriptValue.cpp:
• crypto/CryptoAlgorithm.h:
• crypto/CryptoKey.h:
• crypto/CryptoKeyData.h: Removed.
• crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
• crypto/algorithms/CryptoAlgorithmAES_KW.cpp:
• crypto/algorithms/CryptoAlgorithmHMAC.cpp:
• crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:
• crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
• crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:
• crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:

(WebCore::CryptoKeyRSA::create):
(WebCore::CryptoKeyRSA::exportData const):

• crypto/keys/CryptoKeyAES.cpp:

(WebCore::CryptoKeyAES::exportData const): Deleted.

• crypto/keys/CryptoKeyAES.h:
• crypto/keys/CryptoKeyDataOctetSequence.cpp: Removed.
• crypto/keys/CryptoKeyDataOctetSequence.h: Removed.
• crypto/keys/CryptoKeyDataRSAComponents.cpp: Removed.
• crypto/keys/CryptoKeyDataRSAComponents.h: Removed.
• crypto/keys/CryptoKeyEC.cpp:

(WebCore::CryptoKeyEC::exportData const): Deleted.

• crypto/keys/CryptoKeyEC.h:
• crypto/keys/CryptoKeyHMAC.cpp:

(WebCore::CryptoKeyHMAC::exportData const): Deleted.

• crypto/keys/CryptoKeyHMAC.h:
• crypto/keys/CryptoKeyRSA.cpp:

(WebCore::CryptoKeyRSA::importJwk):
(WebCore::CryptoKeyRSA::exportJwk const):

• crypto/keys/CryptoKeyRSA.h:
• crypto/keys/CryptoKeyRSAComponents.cpp: Copied from crypto/keys/CryptoKeyDataRSAComponents.cpp.

(WebCore::CryptoKeyRSAComponents::CryptoKeyRSAComponents):
(WebCore::CryptoKeyRSAComponents::~CryptoKeyRSAComponents):
(WebCore::CryptoKeyDataRSAComponents::CryptoKeyDataRSAComponents): Deleted.
(WebCore::CryptoKeyDataRSAComponents::~CryptoKeyDataRSAComponents): Deleted.

• crypto/keys/CryptoKeyRSAComponents.h: Copied from crypto/keys/CryptoKeyDataRSAComponents.h.

(WebCore::CryptoKeyRSAComponents::createPublic):
(WebCore::CryptoKeyRSAComponents::createPrivate):
(WebCore::CryptoKeyRSAComponents::createPrivateWithAdditionalData):

• crypto/keys/CryptoKeyRaw.cpp:

(WebCore::CryptoKeyRaw::exportData const): Deleted.

• crypto/keys/CryptoKeyRaw.h:
• crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::getPrivateKeyComponents):
(WebCore::CryptoKeyRSA::create):
(WebCore::CryptoKeyRSA::exportData const):

6:29 PM Changeset in webkit [220948] by commit-queue@webkit.org

• 11 edits in trunk

[Cache API] Add support for being loaded responses
​https://bugs.webkit.org/show_bug.cgi?id=175732

Patch by Youenn Fablet <​youenn@apple.com> on 2017-08-18
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/cache-storage/common.https-expected.txt:

Source/WebCore:

Covered by existing and rebased tests.

Introducing a callback-based method to consume the body when the load is finished.
Using that new method in Cache::put and calling batchPutOperation when the load is finished.

Fixing the case of a fetch response being cloned, in which case its body should be marked as ReadableStream.

• Modules/cache/Cache.cpp:

(WebCore::Cache::put): Changing order of checks to reduce test flakiness risks as there is not yet support for putting responses with ReadableStream.
(WebCore::toConnectionRecord):
(WebCore::Cache::batchPutOperation):

• Modules/cache/Cache.h:
• Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::readableStreamBody): Deleted.

• Modules/fetch/FetchBody.h:

(WebCore::FetchBody::loadingBody):
(WebCore::FetchBody::setAsReadableStream):

• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::BodyLoader::didSucceed):
(WebCore::FetchResponse::BodyLoader::didFail):
(WebCore::FetchResponse::consumeBody):
(WebCore::FetchResponse::consumeBodyWhenLoaded):

• Modules/fetch/FetchResponse.h:

LayoutTests:

• TestExpectations: Removing some flaky test expectations.

5:30 PM Changeset in webkit [220947] by Ryan Haddad

• 7 edits
  1 delete in trunk

Unreviewed, rolling out r220938.

The API tests added with this change are failing.

Reverted changeset:

"Add WTFLogChannel level to allow runtime log filtering"
​https://bugs.webkit.org/show_bug.cgi?id=175731
​http://trac.webkit.org/changeset/220938

5:27 PM Changeset in webkit [220946] by Chris Dumez

• 24 edits
  2 adds in trunk

[Beacon] Improve error reporting
​https://bugs.webkit.org/show_bug.cgi?id=175723

Reviewed by Darin Adler.

Source/WebCore:

Have Ping loads such as beacons report errors via their completion handler.
The Beacon API is using this error to log a console message when beacon loads
fail, provided that the page is still alive.

Test: http/wpt/beacon/beacon-async-error-logging.html

• Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::NavigatorBeacon):
(WebCore::NavigatorBeacon::~NavigatorBeacon):
(WebCore::NavigatorBeacon::from):
(WebCore::NavigatorBeacon::supplementName):
(WebCore::NavigatorBeacon::notifyFinished):
(WebCore::NavigatorBeacon::logError):
(WebCore::NavigatorBeacon::sendBeacon):

• Modules/beacon/NavigatorBeacon.h:
• loader/LoaderStrategy.h:
• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestBeaconResource):

• loader/cache/CachedResourceLoader.h:
• platform/network/PingHandle.h:

Source/WebKit:

Have Ping loads such as beacons report errors via their completion handler.
The Beacon API is using this error to log a console message when beacon loads
fail, provided that the page is still alive.

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::loadPing):
(WebKit::NetworkConnectionToWebProcess::didFinishPingLoad):

• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::~PingLoad):
(WebKit::PingLoad::didFinish):
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::didReceiveChallenge):
(WebKit::PingLoad::didReceiveResponseNetworkSession):
(WebKit::PingLoad::didCompleteWithError):
(WebKit::PingLoad::wasBlocked):
(WebKit::PingLoad::cannotShowURL):
(WebKit::PingLoad::timeoutTimerFired):
(WebKit::PingLoad::currentRequest const):
(WebKit::PingLoad::makeCrossOriginAccessRequestWithPreflight):

• NetworkProcess/PingLoad.h:
• WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didFinishPingLoad):

• WebProcess/Network/NetworkProcessConnection.h:
• WebProcess/Network/NetworkProcessConnection.messages.in:
• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::networkProcessCrashed):
(WebKit::WebLoaderStrategy::startPingLoad):
(WebKit::WebLoaderStrategy::didFinishPingLoad):

• WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

Have Ping loads such as beacons report errors via their completion handler.
The Beacon API is using this error to log a console message when beacon loads
fail, provided that the page is still alive.

• WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::startPingLoad):

• WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

Add layout test coverage.

• http/wpt/beacon/beacon-async-error-logging-expected.txt: Added.
• http/wpt/beacon/beacon-async-error-logging.html: Added.

5:27 PM Changeset in webkit [220945] by webkit@devinrousso.com

• 2 edits in trunk/Tools

Unreviewed, change my email.

• Scripts/webkitpy/common/config/contributors.json:

5:20 PM Changeset in webkit [220944] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked fast/scrolling/arrow-key-scroll-in-rtl-document.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=173779

Unreviewed Test gardening.

• platform/mac-wk2/TestExpectations:

5:03 PM Changeset in webkit [220943] by Ryan Haddad

• 2 edits in trunk/JSTests

Skip flaky JSC test microbenchmarks/generator-with-several-types.js.
​https://bugs.webkit.org/show_bug.cgi?id=172543

Unreviewed test gardening.

• microbenchmarks/generator-with-several-types.js:

4:26 PM Changeset in webkit [220942] by Jonathan Bedard

• 3 edits in trunk/Tools

Fix leak-checking for iOS Simulators
​https://bugs.webkit.org/show_bug.cgi?id=175735

Reviewed by Darin Adler.

If the leak checking currently occurs in ServerProcess, we can’t check leaks on an iOS
Simulator (or device) because the process will have already been killed by the time we
check for leaks. Duplicate leak-checking code and share code waiting on a process to stop.

• Scripts/webkitpy/port/server_process.py:

(ServerProcess.stop): Move code waiting for the process to close to _wait_for_stop(...).
(ServerProcess._wait_for_stop): Share code shutting down a process between ServerProcess
and SimulatorProcess.

• Scripts/webkitpy/port/simulator_process.py:

(SimulatorProcess.stop): Before closing the process, check for leaks.

4:24 PM Changeset in webkit [220941] by weinig@apple.com

• 51 edits
  23 deletes in trunk

Remove the deprecated WebKitSubtleCrypto interface
​https://bugs.webkit.org/show_bug.cgi?id=164938
<rdar://problem/29894563>

Reviewed by Chris Dumez.

Source/WebCore:

Remove WebKitSubtleCrypto and all of its helper classes / functionality.

• CMakeLists.txt:
• DerivedSources.cpp:
• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSCryptoAlgorithmDictionary.cpp: Removed.
• bindings/js/JSCryptoAlgorithmDictionary.h: Removed.
• bindings/js/JSCryptoKeySerializationJWK.cpp: Removed.
• bindings/js/JSCryptoKeySerializationJWK.h: Removed.
• bindings/js/JSCryptoOperationData.cpp: Removed.
• bindings/js/JSCryptoOperationData.h: Removed.
• bindings/js/JSWebKitSubtleCryptoCustom.cpp: Removed.
• crypto/CryptoAlgorithm.cpp:

(WebCore::CryptoAlgorithm::deriveKey): Deleted.
(WebCore::CryptoAlgorithm::encryptForWrapKey): Deleted.
(WebCore::CryptoAlgorithm::decryptForUnwrapKey): Deleted.

• crypto/CryptoAlgorithm.h:
• crypto/CryptoAlgorithmParametersDeprecated.h: Removed.
• crypto/CryptoKeySerialization.h: Removed.
• crypto/WebKitSubtleCrypto.cpp: Removed.
• crypto/WebKitSubtleCrypto.h: Removed.
• crypto/WebKitSubtleCrypto.idl: Removed.
• crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:

(WebCore::CryptoAlgorithmAES_CBC::keyAlgorithmMatches const): Deleted.

• crypto/algorithms/CryptoAlgorithmAES_CBC.h:
• crypto/algorithms/CryptoAlgorithmAES_KW.cpp:

(WebCore::CryptoAlgorithmAES_KW::encryptForWrapKey): Deleted.
(WebCore::CryptoAlgorithmAES_KW::decryptForUnwrapKey): Deleted.

• crypto/algorithms/CryptoAlgorithmAES_KW.h:
• crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::keyAlgorithmMatches const): Deleted.

• crypto/algorithms/CryptoAlgorithmHMAC.h:
• crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:
• crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
• crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:

(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::keyAlgorithmMatches const): Deleted.

• crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
• crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:

(WebCore::CryptoAlgorithmRSA_OAEP::keyAlgorithmMatches const): Deleted.

• crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
• crypto/algorithms/CryptoAlgorithmSHA1.cpp:
• crypto/algorithms/CryptoAlgorithmSHA1.h:
• crypto/algorithms/CryptoAlgorithmSHA224.cpp:
• crypto/algorithms/CryptoAlgorithmSHA224.h:
• crypto/algorithms/CryptoAlgorithmSHA256.cpp:
• crypto/algorithms/CryptoAlgorithmSHA256.h:
• crypto/algorithms/CryptoAlgorithmSHA384.cpp:
• crypto/algorithms/CryptoAlgorithmSHA384.h:
• crypto/algorithms/CryptoAlgorithmSHA512.cpp:
• crypto/algorithms/CryptoAlgorithmSHA512.h:
• crypto/gcrypt/CryptoAlgorithmAES_CBCGCrypt.cpp:
• crypto/gcrypt/CryptoAlgorithmAES_KWGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_KW::platformEncrypt): Deleted.
(WebCore::CryptoAlgorithmAES_KW::platformDecrypt): Deleted.

• crypto/gcrypt/CryptoAlgorithmHMACGCrypt.cpp:
• crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:
• crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:
• crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:
• crypto/keys/CryptoKeySerializationRaw.cpp: Removed.
• crypto/keys/CryptoKeySerializationRaw.h: Removed.
• crypto/mac/CryptoAlgorithmAES_CBCMac.cpp:
• crypto/mac/CryptoAlgorithmAES_KWMac.cpp:

(WebCore::CryptoAlgorithmAES_KW::platformEncrypt): Deleted.
(WebCore::CryptoAlgorithmAES_KW::platformDecrypt): Deleted.

• crypto/mac/CryptoAlgorithmHMACMac.cpp:
• crypto/mac/CryptoAlgorithmRSAES_PKCS1_v1_5Mac.cpp:
• crypto/mac/CryptoAlgorithmRSASSA_PKCS1_v1_5Mac.cpp:
• crypto/mac/CryptoAlgorithmRSA_OAEPMac.cpp:
• crypto/parameters/CryptoAlgorithmAesCbcParamsDeprecated.h: Removed.
• crypto/parameters/CryptoAlgorithmAesKeyGenParamsDeprecated.h: Removed.
• crypto/parameters/CryptoAlgorithmHmacKeyParamsDeprecated.h: Removed.
• crypto/parameters/CryptoAlgorithmHmacParamsDeprecated.h: Removed.
• crypto/parameters/CryptoAlgorithmRsaKeyGenParamsDeprecated.h: Removed.
• crypto/parameters/CryptoAlgorithmRsaKeyParamsWithHashDeprecated.h: Removed.
• crypto/parameters/CryptoAlgorithmRsaOaepParamsDeprecated.h: Removed.
• crypto/parameters/CryptoAlgorithmRsaSsaParamsDeprecated.h: Removed.
• features.json:
• page/Crypto.cpp:
• page/Crypto.h:
• page/Crypto.idl:

LayoutTests:

• crypto/webkitSubtle: Removed.
• crypto/webkitSubtle/aes-cbc-192-encrypt-decrypt-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-192-encrypt-decrypt.html: Removed.
• crypto/webkitSubtle/aes-cbc-256-encrypt-decrypt-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-256-encrypt-decrypt.html: Removed.
• crypto/webkitSubtle/aes-cbc-encrypt-decrypt-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-encrypt-decrypt-with-padding-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-encrypt-decrypt-with-padding.html: Removed.
• crypto/webkitSubtle/aes-cbc-encrypt-decrypt.html: Removed.
• crypto/webkitSubtle/aes-cbc-generate-key-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-generate-key.html: Removed.
• crypto/webkitSubtle/aes-cbc-import-jwk-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-import-jwk.html: Removed.
• crypto/webkitSubtle/aes-cbc-invalid-length-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-invalid-length.html: Removed.
• crypto/webkitSubtle/aes-cbc-unwrap-failure-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-unwrap-failure.html: Removed.
• crypto/webkitSubtle/aes-cbc-unwrap-rsa-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-unwrap-rsa.html: Removed.
• crypto/webkitSubtle/aes-cbc-wrap-rsa-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-wrap-rsa-non-extractable-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-wrap-rsa-non-extractable.html: Removed.
• crypto/webkitSubtle/aes-cbc-wrap-rsa.html: Removed.
• crypto/webkitSubtle/aes-cbc-wrong-key-class-expected.txt: Removed.
• crypto/webkitSubtle/aes-cbc-wrong-key-class.html: Removed.
• crypto/webkitSubtle/aes-export-key-expected.txt: Removed.
• crypto/webkitSubtle/aes-export-key.html: Removed.
• crypto/webkitSubtle/aes-kw-key-manipulation-expected.txt: Removed.
• crypto/webkitSubtle/aes-kw-key-manipulation.html: Removed.
• crypto/webkitSubtle/aes-kw-wrap-unwrap-aes-expected.txt: Removed.
• crypto/webkitSubtle/aes-kw-wrap-unwrap-aes.html: Removed.
• crypto/webkitSubtle/aes-postMessage-expected.txt: Removed.
• crypto/webkitSubtle/aes-postMessage.html: Removed.
• crypto/webkitSubtle/argument-conversion-expected.txt: Removed.
• crypto/webkitSubtle/argument-conversion.html: Removed.
• crypto/webkitSubtle/array-buffer-view-offset-expected.txt: Removed.
• crypto/webkitSubtle/array-buffer-view-offset.html: Removed.
• crypto/webkitSubtle/disallowed-in-worker-expected.txt: Removed.
• crypto/webkitSubtle/disallowed-in-worker.html: Removed.
• crypto/webkitSubtle/gc-2-expected.txt: Removed.
• crypto/webkitSubtle/gc-2.html: Removed.
• crypto/webkitSubtle/gc-3-expected.txt: Removed.
• crypto/webkitSubtle/gc-3.html: Removed.
• crypto/webkitSubtle/gc-expected.txt: Removed.
• crypto/webkitSubtle/gc.html: Removed.
• crypto/webkitSubtle/hmac-check-algorithm-expected.txt: Removed.
• crypto/webkitSubtle/hmac-check-algorithm.html: Removed.
• crypto/webkitSubtle/hmac-export-key-expected.txt: Removed.
• crypto/webkitSubtle/hmac-export-key.html: Removed.
• crypto/webkitSubtle/hmac-generate-key-expected.txt: Removed.
• crypto/webkitSubtle/hmac-generate-key.html: Removed.
• crypto/webkitSubtle/hmac-import-jwk-expected.txt: Removed.
• crypto/webkitSubtle/hmac-import-jwk.html: Removed.
• crypto/webkitSubtle/hmac-postMessage-expected.txt: Removed.
• crypto/webkitSubtle/hmac-postMessage.html: Removed.
• crypto/webkitSubtle/hmac-sign-verify-empty-key-expected.txt: Removed.
• crypto/webkitSubtle/hmac-sign-verify-empty-key.html: Removed.
• crypto/webkitSubtle/hmac-sign-verify-expected.txt: Removed.
• crypto/webkitSubtle/hmac-sign-verify.html: Removed.
• crypto/webkitSubtle/import-export-raw-key-leak-expected.txt: Removed.
• crypto/webkitSubtle/import-export-raw-key-leak.html: Removed.
• crypto/webkitSubtle/import-jwk-expected.txt: Removed.
• crypto/webkitSubtle/import-jwk.html: Removed.
• crypto/webkitSubtle/jwk-export-use-values-expected.txt: Removed.
• crypto/webkitSubtle/jwk-export-use-values.html: Removed.
• crypto/webkitSubtle/jwk-import-use-values-expected.txt: Removed.
• crypto/webkitSubtle/jwk-import-use-values.html: Removed.
• crypto/webkitSubtle/resources: Removed.
• crypto/webkitSubtle/resources/disallowed-in-worker.js: Removed.
• crypto/webkitSubtle/resources/rsa-indexeddb-non-exportable.js: Removed.
• crypto/webkitSubtle/resources/rsa-indexeddb.js: Removed.
• crypto/webkitSubtle/rsa-export-generated-keys-expected.txt: Removed.
• crypto/webkitSubtle/rsa-export-generated-keys.html: Removed.
• crypto/webkitSubtle/rsa-export-key-expected.txt: Removed.
• crypto/webkitSubtle/rsa-export-key.html: Removed.
• crypto/webkitSubtle/rsa-export-private-key-expected.txt: Removed.
• crypto/webkitSubtle/rsa-export-private-key.html: Removed.
• crypto/webkitSubtle/rsa-indexeddb-expected.txt: Removed.
• crypto/webkitSubtle/rsa-indexeddb-non-exportable-expected.txt: Removed.
• crypto/webkitSubtle/rsa-indexeddb-non-exportable-private-expected.txt: Removed.
• crypto/webkitSubtle/rsa-indexeddb-non-exportable-private.html: Removed.
• crypto/webkitSubtle/rsa-indexeddb-non-exportable.html: Removed.
• crypto/webkitSubtle/rsa-indexeddb-private-expected.txt: Removed.
• crypto/webkitSubtle/rsa-indexeddb-private.html: Removed.
• crypto/webkitSubtle/rsa-indexeddb.html: Removed.
• crypto/webkitSubtle/rsa-oaep-generate-non-extractable-key-expected.txt: Removed.
• crypto/webkitSubtle/rsa-oaep-generate-non-extractable-key.html: Removed.
• crypto/webkitSubtle/rsa-oaep-key-manipulation-expected.txt: Removed.
• crypto/webkitSubtle/rsa-oaep-key-manipulation.html: Removed.
• crypto/webkitSubtle/rsa-oaep-plaintext-length-expected.txt: Removed.
• crypto/webkitSubtle/rsa-oaep-plaintext-length.html: Removed.
• crypto/webkitSubtle/rsa-oaep-wrap-unwrap-aes-expected.txt: Removed.
• crypto/webkitSubtle/rsa-oaep-wrap-unwrap-aes.html: Removed.
• crypto/webkitSubtle/rsa-postMessage-expected.txt: Removed.
• crypto/webkitSubtle/rsa-postMessage.html: Removed.
• crypto/webkitSubtle/rsaes-pkcs1-v1_5-decrypt-expected.txt: Removed.
• crypto/webkitSubtle/rsaes-pkcs1-v1_5-decrypt.html: Removed.
• crypto/webkitSubtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes-expected.txt: Removed.
• crypto/webkitSubtle/rsaes-pkcs1-v1_5-wrap-unwrap-aes.html: Removed.
• crypto/webkitSubtle/rsassa-pkcs1-v1_5-generate-key-expected.txt: Removed.
• crypto/webkitSubtle/rsassa-pkcs1-v1_5-generate-key-with-leading-zeroes-in-exponent-expected.txt: Removed.
• crypto/webkitSubtle/rsassa-pkcs1-v1_5-generate-key-with-leading-zeroes-in-exponent.html: Removed.
• crypto/webkitSubtle/rsassa-pkcs1-v1_5-generate-key.html: Removed.
• crypto/webkitSubtle/rsassa-pkcs1-v1_5-import-jwk-expected.txt: Removed.
• crypto/webkitSubtle/rsassa-pkcs1-v1_5-import-jwk-small-key-expected.txt: Removed.
• crypto/webkitSubtle/rsassa-pkcs1-v1_5-import-jwk-small-key.html: Removed.
• crypto/webkitSubtle/rsassa-pkcs1-v1_5-import-jwk.html: Removed.
• crypto/webkitSubtle/rsassa-pkcs1-v1_5-sign-verify-expected.txt: Removed.
• crypto/webkitSubtle/rsassa-pkcs1-v1_5-sign-verify.html: Removed.
• crypto/webkitSubtle/sha-1-expected.txt: Removed.
• crypto/webkitSubtle/sha-1.html: Removed.
• crypto/webkitSubtle/sha-224-expected.txt: Removed.
• crypto/webkitSubtle/sha-224.html: Removed.
• crypto/webkitSubtle/sha-256-expected.txt: Removed.
• crypto/webkitSubtle/sha-256.html: Removed.
• crypto/webkitSubtle/sha-384-expected.txt: Removed.
• crypto/webkitSubtle/sha-384.html: Removed.
• crypto/webkitSubtle/sha-512-expected.txt: Removed.
• crypto/webkitSubtle/sha-512.html: Removed.
• crypto/webkitSubtle/unimplemented-unwrap-crash-expected.txt: Removed.
• crypto/webkitSubtle/unimplemented-unwrap-crash.html: Removed.
• crypto/webkitSubtle/unwrapKey-check-usage-expected.txt: Removed.
• crypto/webkitSubtle/unwrapKey-check-usage.html: Removed.
• crypto/webkitSubtle/wrapKey-check-usage-expected.txt: Removed.
• crypto/webkitSubtle/wrapKey-check-usage.html: Removed.

Remove webkitSubtleCrypto tests.

• fast/dom/Window/property-access-on-cached-window-after-frame-removed-expected.txt:

Remove webkitSubtleCrypto deprecation warning that no longer happens.

• platform/ios-wk1/TestExpectations:
• platform/win/TestExpectations:
• platform/wpe/TestExpectations:

Remove webkitSubtle tests from expectations files.

4:15 PM Changeset in webkit [220940] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

Remove classic mode screen scale clamping
​https://bugs.webkit.org/show_bug.cgi?id=175739
<rdar://problem/33894531>

Reviewed by Andy Estes.

• platform/ios/PlatformScreenIOS.mm:

(WebCore::screenScaleFactor):
This code is no longer needed.

4:02 PM Changeset in webkit [220939] by commit-queue@webkit.org

• 10 edits
  1 copy
  1 add in trunk/Source/WebCore

[Curl] Improve multi-threaded networking
​https://bugs.webkit.org/show_bug.cgi?id=175713

Patch by Daewoong Jang <​daewoong.jang@navercorp.com> on 2017-08-18
Reviewed by Alex Christensen.

• platform/Curl.cmake:
• platform/network/ResourceHandleInternal.h:

(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(WebCore::ResourceHandleInternal::m_failureTimer): Deleted.

• platform/network/curl/CurlCacheManager.cpp:

(WebCore::CurlCacheManager::didReceiveResponse):

• platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownload::init):
(WebCore::CurlDownload::start):
(WebCore::CurlDownload::cancel):
(WebCore::CurlDownload::retain):
(WebCore::CurlDownload::release):
(WebCore::CurlDownload::setupRequest):
(WebCore::CurlDownload::notifyFinish):
(WebCore::CurlDownload::notifyFail):

• platform/network/curl/CurlDownload.h:
• platform/network/curl/CurlJobManager.cpp:

(WebCore::CurlJobList::isEmpty const):
(WebCore::CurlJobList::startJobs):
(WebCore::CurlJobList::finishJobs):
(WebCore::CurlJobList::notifyResult):
(WebCore::CurlJobManager::add):
(WebCore::CurlJobManager::cancel):
(WebCore::CurlJobManager::callOnJobThread):
(WebCore::CurlJobManager::startThreadIfNeeded):
(WebCore::CurlJobManager::updateJobList):
(WebCore::CurlJobManager::workerThread):
(WebCore::CurlJobList::append): Deleted.
(WebCore::CurlJobList::cancel): Deleted.
(WebCore::CurlJobList::complete): Deleted.
(WebCore::CurlJobList::withJob): Deleted.
(WebCore::CurlJobList::withCurlHandle): Deleted.
(WebCore::CurlJob::invoke): Deleted.
(WebCore::CurlJobManager::updateJobs): Deleted.

• platform/network/curl/CurlJobManager.h:

(WebCore::CurlJob::CurlJob): Deleted.
(WebCore::CurlJob::~CurlJob): Deleted.
(WebCore::CurlJob::operator=): Deleted.
(WebCore::CurlJob::curlHandle const): Deleted.
(WebCore::CurlJob::ticket const): Deleted.
(WebCore::CurlJob::finished): Deleted.
(WebCore::CurlJob::error): Deleted.
(WebCore::CurlJob::cancel): Deleted.
(WebCore::CurlJobManager::isActiveJob const): Deleted.

• platform/network/curl/MultipartHandle.cpp:

(WebCore::MultipartHandle::didReceiveData):

• platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::cancel):
(WebCore::ResourceHandle::platformSetDefersLoading):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::receivedCredential):
(WebCore::ResourceHandle::receivedRequestToContinueWithoutCredential):
(WebCore::ResourceHandle::platformLoadResourceSynchronously):
(WebCore::ResourceHandleInternal::initialize): Deleted.
(WebCore::ResourceHandleInternal::applyAuthentication): Deleted.
(WebCore::getFormElementsCount): Deleted.
(WebCore::ResourceHandleInternal::setupPUT): Deleted.
(WebCore::ResourceHandleInternal::setupPOST): Deleted.
(WebCore::ResourceHandleInternal::setupFormData): Deleted.
(WebCore::ResourceHandleInternal::didFinish): Deleted.
(WebCore::ResourceHandleInternal::didFail): Deleted.
(WebCore::ResourceHandleInternal::calculateWebTimingInformations): Deleted.
(WebCore::ResourceHandleInternal::handleLocalReceiveResponse): Deleted.
(WebCore::isHttpInfo): Deleted.
(WebCore::isHttpRedirect): Deleted.
(WebCore::isHttpAuthentication): Deleted.
(WebCore::isHttpNotModified): Deleted.
(WebCore::isAppendableHeader): Deleted.
(WebCore::removeLeadingAndTrailingQuotes): Deleted.
(WebCore::getProtectionSpace): Deleted.
(WebCore::ResourceHandleInternal::willPrepareSendData): Deleted.
(WebCore::ResourceHandleInternal::didReceiveHeaderLine): Deleted.
(WebCore::ResourceHandleInternal::didReceiveAllHeaders): Deleted.
(WebCore::ResourceHandleInternal::didReceiveContentData): Deleted.
(WebCore::ResourceHandleInternal::readCallback): Deleted.
(WebCore::ResourceHandleInternal::headerCallback): Deleted.
(WebCore::ResourceHandleInternal::writeCallback): Deleted.
(WebCore::ResourceHandleInternal::dispatchSynchronousJob): Deleted.
(WebCore::ResourceHandleInternal::handleDataURL): Deleted.

• platform/network/curl/ResourceHandleCurlDelegate.cpp: Added.

(WebCore::ResourceHandleCurlDelegate::ResourceHandleCurlDelegate):
(WebCore::ResourceHandleCurlDelegate::~ResourceHandleCurlDelegate):
(WebCore::ResourceHandleCurlDelegate::hasHandle const):
(WebCore::ResourceHandleCurlDelegate::releaseHandle):
(WebCore::ResourceHandleCurlDelegate::start):
(WebCore::ResourceHandleCurlDelegate::cancel):
(WebCore::ResourceHandleCurlDelegate::setDefersLoading):
(WebCore::ResourceHandleCurlDelegate::setAuthentication):
(WebCore::ResourceHandleCurlDelegate::dispatchSynchronousJob):
(WebCore::ResourceHandleCurlDelegate::retain):
(WebCore::ResourceHandleCurlDelegate::release):
(WebCore::ResourceHandleCurlDelegate::setupRequest):
(WebCore::ResourceHandleCurlDelegate::notifyFinish):
(WebCore::ResourceHandleCurlDelegate::notifyFail):
(WebCore::ResourceHandleCurlDelegate::response):
(WebCore::ResourceHandleCurlDelegate::setupAuthentication):
(WebCore::removeLeadingAndTrailingQuotes):
(WebCore::ResourceHandleCurlDelegate::getProtectionSpace):
(WebCore::isHttpInfo):
(WebCore::isHttpRedirect):
(WebCore::isHttpAuthentication):
(WebCore::isHttpNotModified):
(WebCore::isAppendableHeader):
(WebCore::ResourceHandleCurlDelegate::didReceiveHeaderLine):
(WebCore::ResourceHandleCurlDelegate::didReceiveAllHeaders):
(WebCore::ResourceHandleCurlDelegate::didReceiveContentData):
(WebCore::ResourceHandleCurlDelegate::handleLocalReceiveResponse):
(WebCore::ResourceHandleCurlDelegate::prepareSendData):
(WebCore::ResourceHandleCurlDelegate::didFinish):
(WebCore::ResourceHandleCurlDelegate::didFail):
(WebCore::ResourceHandleCurlDelegate::handleDataURL):
(WebCore::ResourceHandleCurlDelegate::setupPOST):
(WebCore::ResourceHandleCurlDelegate::setupPUT):
(WebCore::ResourceHandleCurlDelegate::getFormElementsCount):
(WebCore::ResourceHandleCurlDelegate::setupFormData):
(WebCore::ResourceHandleCurlDelegate::applyAuthentication):
(WebCore::ResourceHandleCurlDelegate::setWebTimings):
(WebCore::ResourceHandleCurlDelegate::didReceiveHeader):
(WebCore::ResourceHandleCurlDelegate::didReceiveData):
(WebCore::ResourceHandleCurlDelegate::willSendData):
(WebCore::ResourceHandleCurlDelegate::didReceiveHeaderCallback):
(WebCore::ResourceHandleCurlDelegate::didReceiveDataCallback):
(WebCore::ResourceHandleCurlDelegate::willSendDataCallback):

• platform/network/curl/ResourceHandleCurlDelegate.h: Added.

3:46 PM Changeset in webkit [220938] by eric.carlson@apple.com

• 7 edits
  1 add in trunk

Add WTFLogChannel level to allow runtime log filtering
​https://bugs.webkit.org/show_bug.cgi?id=175731
<rdar://problem/33967234>

Reviewed by Jer Noble.
Source/WTF:

Add WTFLog*, LOG, and RELEASE_LOG variants that take a "log level" parameter so code
can include logging statements that are only conditionally emitted.

• wtf/Assertions.cpp:
• wtf/Assertions.h:
• wtf/MemoryPressureHandler.cpp:
• wtf/RefCountedLeakCounter.cpp:

Tools:

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/WebCore/Logging.cpp: Added.

(TestWebKitAPI::LoggingTest::output):
(TestWebKitAPI::TEST_F):

3:34 PM Changeset in webkit [220937] by rniwa@webkit.org

• 2 edits in trunk/Source/WebCore

iOS 10 debug build fix.

• dom/DataTransfer.cpp:

(WebCore::DataTransfer::DataTransfer):

3:15 PM Changeset in webkit [220936] by Jonathan Bedard

• 2 edits in trunk/LayoutTests

Marking canvas/webgl tests as failing
​https://bugs.webkit.org/show_bug.cgi?id=175736

Unreviewed test gardening.

• platform/ios-device/TestExpectations:

2:53 PM Changeset in webkit [220935] by rniwa@webkit.org

• 8 edits
  1 delete in trunk/Source/WebCore

Rename DataTransferAccessPolicy to match spec and refactor related node
​https://bugs.webkit.org/show_bug.cgi?id=175704

Reviewed by Wenson Hsieh.

Renamed DataTransferAccessPolicy to DataTransfer::StoreMode to match the drag data store mode concept
in the HTML5 specification:
​https://html.spec.whatwg.org/multipage/dnd.html#drag-data-store-mode

DataTransfer in addition to those states can be disassociated from the drag data store when it becomes
no longer valid. We also support a special mode which allows only updating the drag image.
These two states, Invalid and DragImageWritable, are added in addition to the three states in the spec.

Also split DragAndDrop type of DataTransfer into DragAndDropData and DragAndDropFiles, and refactored
the related code.

No new tests since there should be no behavioral change.

• WebCore.xcodeproj/project.pbxproj:
• dom/DataTransfer.cpp:

(WebCore::DataTransfer::DataTransfer): No longer takes forFileDrag boolean since it's folded into type.
(WebCore::DataTransfer::createForCopyAndPaste):
(WebCore::DataTransfer::~DataTransfer):
(WebCore::DataTransfer::setAccessPolicy): Deleted.
(WebCore::DataTransfer::canReadTypes const):
(WebCore::DataTransfer::canReadData const):
(WebCore::DataTransfer::canWriteData const):
(WebCore::DataTransfer::createForInputEvent):
(WebCore::DataTransfer::createForDrag):
(WebCore::DataTransfer::createForDrop):
(WebCore::DataTransfer::canSetDragImage const):

• dom/DataTransfer.h:

(WebCore::DataTransfer::makeInvalidForSecurity): Added.
(WebCore::DataTransfer::makeDragImageWritable): Added.

• dom/DataTransferAccessPolicy.h: Removed.
• editing/Editor.cpp:

(WebCore::dispatchClipboardEvent): Moved and renamed from dispatchCPPEvent. Now computes the store mode
inside the function to match the spec: ​https://w3c.github.io/clipboard-apis/#fire-a-clipboard-event
(WebCore::Editor::canDHTMLCut):
(WebCore::Editor::canDHTMLCopy):
(WebCore::Editor::canDHTMLPaste):
(WebCore::Editor::tryDHTMLCopy):
(WebCore::Editor::tryDHTMLCut):
(WebCore::Editor::tryDHTMLPaste):
(WebCore::Editor::dispatchCPPEvent): Deleted.

• editing/Editor.h:
• page/DragController.cpp:

(WebCore::createDataTransferToUpdateDrag): Extracted to share code.
(WebCore::DragController::dragExited):
(WebCore::DragController::performDragOperation):
(WebCore::DragController::tryDHTMLDrag):

• page/EventHandler.cpp:

(WebCore::EventHandler::invalidateDataTransfer):
(WebCore::EventHandler::handleDrag):

2:40 PM Changeset in webkit [220934] by commit-queue@webkit.org

• 8 edits in trunk/Source/WebCore

Followup (r220289): RenderImageResourceStyleImage code clean up
​https://bugs.webkit.org/show_bug.cgi?id=175444

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-08-18
Reviewed by Darin Adler.

RenderImageResourceStyleImage may be created with a StyleImage of type
StyleGeneratedImage. It may also be associated with a CachedImage which
is loaded through a source URL. In this case, adding and removing m_renderer
as a client of the CachedImage will be done through
RenderImageResource::setCachedImage().

RenderImageResource::setCachedImage() is already called from
ImageLoader::updateRenderer() when the CachedImage finishes loading. This
call adds m_renderer to the clients of the CachedImage.
RenderImageResource::setCachedImage() will also be called from
RenderImageResourceStyleImage::shutdown() via RenderImageResource::shutdown()
to remove m_renderer from the clients of CachedImage by passing a null pointer.

• rendering/RenderImage.cpp:

(WebCore::RenderImage::styleWillChange):

• rendering/RenderImageResource.cpp:

(WebCore::RenderImageResource::initialize):
(WebCore::RenderImageResource::shutdown):
(WebCore::RenderImageResource::setCachedImage):
(WebCore::RenderImageResource::resetAnimation):
(WebCore::RenderImageResource::image const):
(WebCore::RenderImageResource::setContainerSizeForRenderer):
(WebCore::RenderImageResource::imageSize const):
(WebCore::RenderImageResource::~RenderImageResource): Deleted.
(WebCore::RenderImageResource::errorOccurred const): Deleted.
(WebCore::RenderImageResource::imageHasRelativeWidth const): Deleted.
(WebCore::RenderImageResource::imageHasRelativeHeight const): Deleted.
(WebCore::RenderImageResource::intrinsicSize const): Deleted.
(WebCore::RenderImageResource::getImageSize const): Deleted.

• rendering/RenderImageResource.h:

(WebCore::RenderImageResource::initialize):
(WebCore::RenderImageResource::renderer const):
(WebCore::RenderImageResource::errorOccurred const):
(WebCore::RenderImageResource::imageHasRelativeWidth const):
(WebCore::RenderImageResource::imageHasRelativeHeight const):
(WebCore::RenderImageResource::imageSize const):
(WebCore::RenderImageResource::intrinsicSize const):
(WebCore::RenderImageResource::imagePtr const):

• rendering/RenderImageResourceStyleImage.cpp:

(WebCore::RenderImageResourceStyleImage::initialize):
(WebCore::RenderImageResourceStyleImage::shutdown):
(WebCore::RenderImageResourceStyleImage::image const):
(WebCore::RenderImageResourceStyleImage::setContainerSizeForRenderer):
(WebCore::RenderImageResourceStyleImage::~RenderImageResourceStyleImage): Deleted.

• rendering/RenderImageResourceStyleImage.h:
• rendering/RenderSnapshottedPlugIn.cpp:

(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn):

• rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::RenderSVGImage):

2:30 PM Changeset in webkit [220933] by jiewen_tan@apple.com

• 8 edits
  2 adds in trunk

[WebCrypto][Mac] Replace CCECCryptorGetKeyComponents with CCECCryptorExportKey for exporting ECC JWKs
​https://bugs.webkit.org/show_bug.cgi?id=175657
<rdar://problem/33797150>

Reviewed by Brent Fulgham.

Source/WebCore:

CCECCryptorGetKeyComponents returns components in unpadded formats. In some minor cases, the ECC components
do need padding. Therefore, we occasionally see some corrupted outputs in JWKs. To overcome that, this patch
replaces CCECCryptorGetKeyComponents with CCECCryptorExportKey which does padding all the time.

In the meantime, this patch also makes export* methods return OperationError if any error occur in the
underlying operations though very unlikely.

Test: crypto/subtle/ecdsa-generate-export-import-jwk-sign-verify.html

• crypto/algorithms/CryptoAlgorithmECDH.cpp:

(WebCore::CryptoAlgorithmECDH::exportKey):

• crypto/algorithms/CryptoAlgorithmECDSA.cpp:

(WebCore::CryptoAlgorithmECDSA::exportKey):

• crypto/gcrypt/CryptoKeyECGCrypt.cpp:

(WebCore::CryptoKeyEC::platformAddFieldElements const):

• crypto/keys/CryptoKeyEC.cpp:

(WebCore::CryptoKeyEC::exportRaw const):
(WebCore::CryptoKeyEC::exportJwk const):
(WebCore::CryptoKeyEC::exportSpki const):
(WebCore::CryptoKeyEC::exportPkcs8 const):

• crypto/keys/CryptoKeyEC.h:
• crypto/mac/CryptoKeyECMac.cpp:

(WebCore::CryptoKeyEC::platformExportRaw const):
(WebCore::CryptoKeyEC::platformAddFieldElements const):
(WebCore::CryptoKeyEC::platformExportSpki const):
(WebCore::CryptoKeyEC::platformExportPkcs8 const):

LayoutTests:

• crypto/subtle/ecdsa-generate-export-import-jwk-sign-verify-expected.txt: Added.
• crypto/subtle/ecdsa-generate-export-import-jwk-sign-verify.html: Added.

2:07 PM Changeset in webkit [220932] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/IndexedDB/open-request-queue.html as flaky timeout.
​https://bugs.webkit.org/show_bug.cgi?id=172044

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

1:53 PM Changeset in webkit [220931] by Chris Dumez

• 3 edits in trunk/Source/WebKit

REGRESSION (r220601): Crash when closing google doc after switching the order of tabs in safari
​https://bugs.webkit.org/show_bug.cgi?id=175721
<rdar://problem/33928369>

Reviewed by Geoffrey Garen.

Make sure WebProcess::markAllLayersVolatile() does not call WTFMove() multiple times
on the same completion handler. Use a RefCounter to hold on to the completion handler
and make sure the handler gets called when the RefCounter's value becomes 0.

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::cancelPrepareToSuspend):
(WebKit::WebProcess::markAllLayersVolatile):
(WebKit::WebProcess::cancelMarkAllLayersVolatile):

• WebProcess/WebProcess.h:

1:50 PM Changeset in webkit [220930] by pvollan@apple.com

• 4 edits in trunk/Source

[Win] accessibility/heading-crash-after-hidden.html is a flaky crash.
​https://bugs.webkit.org/show_bug.cgi?id=173536

Reviewed by Brent Fulgham.

If the tree state is dirty, accessible objects are deleted while iterating over children
under AccessibilityNodeObject::textUnderElement when the style is updated. Make sure the
style is updated before this method is called.

Source/WebCore:

No new tests, covered by existing tests.

• accessibility/win/AccessibilityObjectWrapperWin.cpp:

(WebCore::AccessibilityObjectWrapper::accessibilityAttributeValue):

Source/WebKitLegacy/win:

• AccessibleBase.cpp:

(AccessibleBase::getAccessibilityObjectForChild):

1:16 PM Changeset in webkit [220929] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked js/slow-stress/Int32Array-alloc-huge.html as flaky on mac.
​https://bugs.webkit.org/show_bug.cgi?id=173010

Unreviewed test gardening.

• platform/mac/TestExpectations:

12:32 PM Changeset in webkit [220928] by commit-queue@webkit.org

• 20 edits in trunk

[Cache API] Add response body storage
​https://bugs.webkit.org/show_bug.cgi?id=175658

Patch by Youenn Fablet <​youenn@apple.com> on 2017-08-18
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/cache-storage/window/cache-match.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-match.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-put.https-expected.txt:

Source/WebCore:

Covered by rebased tests.
Tests are still flaky until waiting for end of fetch load is implemented.

Adding a response body within CacheStorageConnection::Record.
Adding ability to pass this body from/to the main thread.

Adding response body consumption into a CacheStorageConnection::Record.
Adding response body setting from a CacheStorageConnection::Record.

• Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

• Modules/cache/Cache.cpp:

(WebCore::Cache::put):
(WebCore::toConnectionRecord):
(WebCore::Cache::updateRecords):

• Modules/cache/CacheStorageConnection.cpp:

(WebCore::CacheStorageConnection::copyResponseBody):
(WebCore::CacheStorageConnection::isolatedResponseBody):
(WebCore::CacheStorageConnection::Record::copy const):

• Modules/cache/CacheStorageConnection.h:
• Modules/cache/WorkerCacheStorageConnection.cpp:

(WebCore::toCrossThreadRecordData):
(WebCore::fromCrossThreadRecordData):

• Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::bodyAsFormData const):
(WebCore::FetchBody::take):
(WebCore::FetchBody::bodyForInternalRequest const): Deleted.

• Modules/fetch/FetchBody.h:

(WebCore::FetchBody::setAsFormData):

• Modules/fetch/FetchBodyConsumer.h:

(WebCore::FetchBodyConsumer::setData):

• Modules/fetch/FetchRequest.cpp:

(WebCore::FetchRequest::resourceRequest const):

• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::consumeBody):
(WebCore::FetchResponse::setBodyData):

• Modules/fetch/FetchResponse.h:

Source/WebKit:

Added IPC serialization of Record response body.
Updated CacheStorageEngine implementation as Record has no longer a copy constructor.

• NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorageEngine::retrieveRecords):
(WebKit::CacheStorageEngine::deleteMatchingRecords):

• Shared/WebCoreArgumentCoders.cpp:

(IPC::encodeSharedBuffer):
(IPC::decodeSharedBuffer):
(IPC::ArgumentCoder<CacheStorageConnection::Record>::encode):
(IPC::ArgumentCoder<CacheStorageConnection::Record>::decode):

12:32 PM Changeset in webkit [220927] by commit-queue@webkit.org

• 5 edits in trunk/Source/WebCore

[Fetch API] Add support for a callback-based fetch
​https://bugs.webkit.org/show_bug.cgi?id=175710

Patch by Youenn Fablet <​youenn@apple.com> on 2017-08-18
Reviewed by Alex Christensen.

No change of behavior.

Moving from a DOMPromise to a Callback taking an ExceptionOr<FetchResponse&>.
Updating window and worker call sites.

• Modules/fetch/DOMWindowFetch.cpp:

(WebCore::DOMWindowFetch::fetch):

• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::fetch):
(WebCore::FetchResponse::BodyLoader::didFail):
(WebCore::FetchResponse::BodyLoader::BodyLoader):
(WebCore::FetchResponse::BodyLoader::didReceiveResponse):
(WebCore::FetchResponse::BodyLoader::stop):

• Modules/fetch/FetchResponse.h:
• Modules/fetch/WorkerGlobalScopeFetch.cpp:

(WebCore::WorkerGlobalScopeFetch::fetch):

12:20 PM Changeset in webkit [220926] by pvollan@apple.com

• 7 edits in trunk/Source

Implement 32-bit MacroAssembler::probe support for Windows.
​https://bugs.webkit.org/show_bug.cgi?id=175449

Reviewed by Mark Lam.

Source/JavaScriptCore:

This is needed to enable the DFG.

• assembler/MacroAssemblerX86Common.cpp:
• assembler/testmasm.cpp:

(JSC::run):
(dllLauncherEntryPoint):

• shell/CMakeLists.txt:
• shell/PlatformWin.cmake:

Source/WTF:

Enable the DFG on Win32.

• wtf/Platform.h:

11:56 AM Changeset in webkit [220925] by ap@apple.com

• 2 edits in trunk/Tools

Add Dean Johnson to contributors.json for Bugzilla autocomplete.

• Scripts/webkitpy/common/config/contributors.json:

11:52 AM Changeset in webkit [220924] by beidson@apple.com

• 66 edits
  7 copies
  3 adds in trunk

Bounce ServiceWorker jobs to the Storage Process.
​https://bugs.webkit.org/show_bug.cgi?id=175650

Reviewed by Andy Estes.

LayoutTests/imported/w3c:

Now that the serviceWorker.register() call is asynchronous, update a whole bunch of test results.

• web-platform-tests/FileAPI/historical.https-expected.txt:
• web-platform-tests/background-fetch/interfaces-worker.https-expected.txt:
• web-platform-tests/fetch/api/policies/referrer-no-referrer-service-worker.https-expected.txt:
• web-platform-tests/fetch/api/policies/referrer-origin-service-worker.https-expected.txt:
• web-platform-tests/fetch/api/policies/referrer-origin-when-cross-origin-service-worker.https-expected.txt:
• web-platform-tests/fetch/api/policies/referrer-unsafe-url-service-worker.https-expected.txt:
• web-platform-tests/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/canblock-serviceworker.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-add.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-delete.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-keys.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-match.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-matchAll.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-put.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-keys.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage-match.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/serviceworker/cache-storage.https-expected.txt:
• web-platform-tests/streams/byte-length-queuing-strategy.serviceworker.https-expected.txt:
• web-platform-tests/streams/count-queuing-strategy.serviceworker.https-expected.txt:
• web-platform-tests/streams/piping/close-propagation-backward.serviceworker.https-expected.txt:
• web-platform-tests/streams/piping/close-propagation-forward.serviceworker.https-expected.txt:
• web-platform-tests/streams/piping/error-propagation-backward.serviceworker.https-expected.txt:
• web-platform-tests/streams/piping/error-propagation-forward.serviceworker.https-expected.txt:
• web-platform-tests/streams/piping/flow-control.serviceworker.https-expected.txt:
• web-platform-tests/streams/piping/general.serviceworker.https-expected.txt:
• web-platform-tests/streams/piping/multiple-propagation.serviceworker.https-expected.txt:
• web-platform-tests/streams/piping/pipe-through.serviceworker.https-expected.txt:
• web-platform-tests/streams/piping/transform-streams.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-byte-streams/general.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/bad-strategies.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/bad-underlying-sources.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/brand-checks.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/cancel.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/count-queuing-strategy-integration.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/default-reader.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/floating-point-total-queue-size.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/garbage-collection.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/general.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/pipe-through.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/readable-stream-reader.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/tee.serviceworker.https-expected.txt:
• web-platform-tests/streams/readable-streams/templated.serviceworker.https-expected.txt:

Source/WebCore:

No new tests (Covered by both changes and consistencies in existing tests)

This lays the groundwork for the SW job queue being in the StorageProcess by actually
setting up some objects for IPC communication and actually sending things over the wire.

The main point of IPC is the WebCore abstract base class "SWServer::Connection"

A collection of them will soon be managed by the SWServer itself in the StorageProcess.

That object will be the stand-in for IPC on both the WebProcess and StorageProcess side.

Currently, any job that we try to schedule still immediately rejects (though now it does
so asynchronously instead of synchronously).

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:

• dom/ExceptionData.h: Copied from Source/WebCore/workers/service/ServiceWorkerProvider.h.

(WebCore::ExceptionData::toException const):
(WebCore::ExceptionData::encode const):
(WebCore::ExceptionData::decode):

• workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::scheduleJob):

• workers/service/ServiceWorkerContainer.h:

• workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::failedWithException):
(WebCore::ServiceWorkerJob::data const):

• workers/service/ServiceWorkerJob.h:

• workers/service/ServiceWorkerJobData.h: Copied from Source/WebCore/workers/service/ServiceWorkerProvider.h.

(WebCore::ServiceWorkerJobData::encode const):
(WebCore::ServiceWorkerJobData::decode):

• workers/service/ServiceWorkerJobType.h: Copied from Source/WebCore/workers/service/ServiceWorkerProvider.h.

• workers/service/ServiceWorkerProvider.h:

• workers/service/ServiceWorkerRegistrationParameters.h:

• workers/service/server/SWServer.cpp: Copied from Source/WebKit/WebProcess/Storage/WebServiceWorkerProvider.cpp.

(WebCore::SWServer::Connection::scheduleJob):
(WebCore::SWServer::Connection::jobRejected):

• workers/service/server/SWServer.h: Copied from Source/WebCore/workers/service/ServiceWorkerProvider.h.

(WebCore::SWServer::Connection::~Connection):

Source/WebKit:

• CMakeLists.txt:
• DerivedSources.make:
• WebKit.xcodeproj/project.pbxproj:

• Platform/Logging.h:

• StorageProcess/StorageToWebProcessConnection.cpp:

(WebKit::StorageToWebProcessConnection::didReceiveMessage):
(WebKit::StorageToWebProcessConnection::didClose):
(WebKit::StorageToWebProcessConnection::establishSWServerConnection):
(WebKit::StorageToWebProcessConnection::removeSWServerConnection):
(WebKit::StorageToWebProcessConnection::establishIDBConnectionToServer):

• StorageProcess/StorageToWebProcessConnection.h:
• StorageProcess/StorageToWebProcessConnection.messages.in:

• WebProcess/Storage/WebSWServerConnection.cpp: Added.

(WebKit::WebSWServerConnection::WebSWServerConnection):
(WebKit::WebSWServerConnection::~WebSWServerConnection):
(WebKit::WebSWServerConnection::disconnectedFromWebProcess):
(WebKit::WebSWServerConnection::scheduleJob):
(WebKit::WebSWServerConnection::scheduleStorageJob):

• WebProcess/Storage/WebSWServerConnection.h: Copied from Source/WebCore/workers/service/ServiceWorkerJob.h.

(WebKit::WebSWServerConnection::create):
(WebKit::WebSWServerConnection::identifier const):

• WebProcess/Storage/WebSWServerConnection.messages.in: Copied from Source/WebKit/StorageProcess/StorageToWebProcessConnection.messages.in.

• WebProcess/Storage/WebServiceWorkerProvider.cpp:

(WebKit::WebServiceWorkerProvider::serviceWorkerConnectionForSession):
(WebKit::WebServiceWorkerProvider::scheduleJob): Deleted.

• WebProcess/Storage/WebServiceWorkerProvider.h:

• WebProcess/Storage/WebToStorageProcessConnection.cpp:

(WebKit::WebToStorageProcessConnection::didReceiveMessage):
(WebKit::WebToStorageProcessConnection::serviceWorkerConnectionForSession):

• WebProcess/Storage/WebToStorageProcessConnection.h:

LayoutTests:

Service worker tests will always be dumpAsText and always be asynchronous.

• http/tests/workers/service/basic-register.html:
• http/tests/workers/service/resources/basic-register.js:
• http/tests/workers/service/resources/sw-test-pre.js: Added.

10:58 AM Changeset in webkit [220923] by Ryan Haddad

• 2 edits in branches/safari-604.1.38.1-branch/LayoutTests

Unreviewed, update TestExpectations.

• platform/mac-highsierra/TestExpectations:

10:58 AM Changeset in webkit [220922] by Chris Dumez

• 21 edits in trunk

[Beacon] Add support for quota limitation
​https://bugs.webkit.org/show_bug.cgi?id=175443
<rdar://problem/33729002>

Reviewed by Youenn Fablet.

Source/WebCore:

LoaderStrategy::startPingLoad() now takes a completion handler parameter, allowing CachedResource::load()
to know when a Beacon load is complete. This was needed in order for the fetch in-flight keepalive request
quota limit to work properly for beacon loads as well. We need to know when the beacon load completes in
order to know if the beacon is in-flight or not and only free up its allocated quota once it is no longer
in-flight.

No new tests, updated existing test.

• loader/LoaderStrategy.h:
• loader/PingLoader.cpp:

(WebCore::PingLoader::startPingLoad):

• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

• platform/network/PingHandle.h:

Source/WebKit:

WebLoaderStrategy now generates an identifier for ping loads and keep
the completion handler in a local HashMap. Once the ping load is done,
the network process sends an IPC message back to the WebContent process
so that WebLoaderStrategy can look up the completion handler for the
ping load and call it.

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::loadPing):
(WebKit::NetworkConnectionToWebProcess::didFinishPingLoad):

• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::~PingLoad):

• NetworkProcess/PingLoad.h:
• WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didFinishPingLoad):

• WebProcess/Network/NetworkProcessConnection.h:
• WebProcess/Network/NetworkProcessConnection.messages.in:
• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::generatePingLoadIdentifier):
(WebKit::WebLoaderStrategy::startPingLoad):
(WebKit::WebLoaderStrategy::didFinishPingLoad):

• WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

• WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::startPingLoad):

• WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

Extend layout test coverage and rebaseline test.

• http/wpt/beacon/beacon-quota-expected.txt:
• http/wpt/beacon/beacon-quota.html:

10:54 AM Changeset in webkit [220921] by mark.lam@apple.com

• 14 edits in trunk/Source/JavaScriptCore

Rename ProbeContext and ProbeFunction to Probe::State and Probe::Function.
​https://bugs.webkit.org/show_bug.cgi?id=175725
<rdar://problem/33965477>

Rubber-stamped by JF Bastien.

This is purely a refactoring patch (in preparation for the introduction of a
Probe::Context data structure in ​https://bugs.webkit.org/show_bug.cgi?id=175688
later). This patch does not change any semantics / behavior.

• assembler/AbstractMacroAssembler.h:
• assembler/MacroAssembler.cpp:

(JSC::stdFunctionCallback):
(JSC::MacroAssembler::probe):

• assembler/MacroAssembler.h:

(JSC::ProbeContext::gpr): Deleted.
(JSC::ProbeContext::spr): Deleted.
(JSC::ProbeContext::fpr): Deleted.
(JSC::ProbeContext::gprName): Deleted.
(JSC::ProbeContext::sprName): Deleted.
(JSC::ProbeContext::fprName): Deleted.
(JSC::ProbeContext::pc): Deleted.
(JSC::ProbeContext::fp): Deleted.
(JSC::ProbeContext::sp): Deleted.

• assembler/MacroAssemblerARM.cpp:

(JSC::MacroAssembler::probe):

• assembler/MacroAssemblerARM.h:

(JSC::MacroAssemblerARM::trustedImm32FromPtr):

• assembler/MacroAssemblerARM64.cpp:

(JSC::arm64ProbeError):
(JSC::MacroAssembler::probe):

• assembler/MacroAssemblerARMv7.cpp:

(JSC::MacroAssembler::probe):

• assembler/MacroAssemblerARMv7.h:

(JSC::MacroAssemblerARMv7::trustedImm32FromPtr):

• assembler/MacroAssemblerPrinter.cpp:

(JSC::Printer::printCallback):

• assembler/MacroAssemblerPrinter.h:
• assembler/MacroAssemblerX86Common.cpp:

(JSC::MacroAssembler::probe):

• assembler/Printer.h:

(JSC::Printer::Context::Context):

• assembler/testmasm.cpp:

(JSC::testProbeReadsArgumentRegisters):
(JSC::testProbeWritesArgumentRegisters):
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesStackPointerToInsideProbeStateOnStack):
(JSC::testProbeModifiesStackPointerToNBytesBelowSP):
(JSC::testProbeModifiesProgramCounter):
(JSC::fillStack):
(JSC::testProbeModifiesStackWithCallback):
(JSC::run):
(JSC::testProbeModifiesStackPointerToInsideProbeContextOnStack): Deleted.

10:49 AM Changeset in webkit [220920] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Unreviewed, land TestExpectations for rdar://problem/33850189.

• platform/mac-highsierra/TestExpectations:

10:42 AM Changeset in webkit [220919] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html for El Capitan WK2.

Unreviewed test gardening.

• platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-expected.txt:

9:08 AM Changeset in webkit [220918] by commit-queue@webkit.org

• 1 edit
  1 add in trunk/Tools

[Tools] Add script to download a GitHub release
​https://bugs.webkit.org/show_bug.cgi?id=175279

Patch by Ross Kirsling <Ross Kirsling> on 2017-08-18
Reviewed by Brent Fulgham.

• Scripts/download-latest-github-release.py: Added.

8:51 AM Changeset in webkit [220917] by commit-queue@webkit.org

• 35 edits
  2 copies
  7 adds in trunk

[Cache API] Add a WK2 implementation of CacheStorageConnection
​https://bugs.webkit.org/show_bug.cgi?id=175640

Patch by Youenn Fablet <​youenn@apple.com> on 2017-08-18
Reviewed by Alex Christensen & Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/cache-storage/window/cache-add.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/cache-delete.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/cache-keys.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/cache-match.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/cache-matchAll.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/cache-put.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/cache-storage-keys.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/cache-storage.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/sandboxed-iframes.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-add.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-delete.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-keys.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-match.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-matchAll.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-put.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-storage-keys.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-storage.https-expected.txt:

Source/WebCore:

• Modules/cache/CacheStorageConnection.cpp: Adding Internal error.
• Modules/cache/CacheStorageConnection.h: Ditto.
• WebCore.xcodeproj/project.pbxproj: Exporting CacheQueryOptions.h header.

Source/WebKit:

Adding WebCacheStorageConnection as an implementation of CacheStorageConnection.
Making WebCacheStorageProvider instantiates such class.
One WebCacheStorageConnection is created for each session of a given WebProcess.

WebCacheStorageConnection is sending IPC calls to the network process.
Main implementation of the cache API is done in the network process by CacheStorageEngineConnection and CacheStorageEngine.
There is one WebCacheStorageConnection per session.
WebCacheStorageConnection is passing the session ID for each call to the network process to ensure the right cache storage engine is used.

CacheStorageEngineConnection mirrors WebCacheStorageConnection on the network process.
There is one CacheStorageEngine per session and CacheStorageEngineConnection will select the right CacheStorageEngine using the given session ID.

CacheStorageEngine is responsible of storing and matching cache API records.
Current implementation only keeps in memory the cached objects.

CacheStorageEngine is keeping (for each different origin) caches and records as a Vector as the order of insertion is important as per spec.
It also keeps a list of removed caches. These caches should remain functional until the last web page having access to these is gone.
The mechanism to fully remove these caches is not implemented yet.

Adding IPC encodings for WTF::Expected, CacheQueryOptions, FetchOptions, CacheStorageConnection Record and CacheInfo.

• CMakeLists.txt:
• DerivedSources.make:
• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::didReceiveMessage):
(WebKit::generateCacheStorageConnectionIdentifier):
(WebKit::NetworkConnectionToWebProcess::createCacheStorageConnection):
(WebKit::NetworkConnectionToWebProcess::closeCacheStorageConnection):

• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/NetworkConnectionToWebProcess.messages.in:
• NetworkProcess/cache/CacheStorageEngine.cpp: Added.

(WebKit::defaultCacheStorageEngine):
(WebKit::globalEngineMap):
(WebKit::CacheStorageEngine::from):
(WebKit::CacheStorageEngine::destroyEngine):
(WebKit::CacheStorageEngine::defaultEngine):
(WebKit::CacheStorageEngine::open):
(WebKit::CacheStorageEngine::remove):
(WebKit::CacheStorageEngine::retrieveCaches):
(WebKit::CacheStorageEngine::retrieveRecords):
(WebKit::CacheStorageEngine::putRecords):
(WebKit::CacheStorageEngine::deleteMatchingRecords):
(WebKit::CacheStorageEngine::writeCachesToDisk):
(WebKit::CacheStorageEngine::readCachesFromDisk):
(WebKit::CacheStorageEngine::readCache):
(WebKit::CacheStorageEngine::writeCacheRecords):
(WebKit::CacheStorageEngine::removeCacheRecords):
(WebKit::CacheStorageEngine::cache):
(WebKit::CacheStorageEngine::caches const):
(WebKit::CacheStorageEngine::records):
(WebKit::CacheStorageEngine::queryCache):

• NetworkProcess/cache/CacheStorageEngine.h: Added.
• NetworkProcess/cache/CacheStorageEngineConnection.cpp: Added.

(WebKit::CacheStorageEngineConnection::CacheStorageEngineConnection):
(WebKit::CacheStorageEngineConnection::open):
(WebKit::CacheStorageEngineConnection::remove):
(WebKit::CacheStorageEngineConnection::caches):
(WebKit::CacheStorageEngineConnection::records):
(WebKit::CacheStorageEngineConnection::deleteMatchingRecords):
(WebKit::CacheStorageEngineConnection::putRecords):

• NetworkProcess/cache/CacheStorageEngineConnection.h: Added.

(WebKit::CacheStorageEngineConnection::create):

• NetworkProcess/cache/CacheStorageEngineConnection.messages.in: Added.
• Platform/IPC/ArgumentCoders.h:
• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<CacheQueryOptions>::encode):
(IPC::ArgumentCoder<CacheQueryOptions>::decode):
(IPC::ArgumentCoder<FetchOptions>::encode):
(IPC::ArgumentCoder<FetchOptions>::decode):
(IPC::ArgumentCoder<CacheStorageConnection::CacheInfo>::encode):
(IPC::ArgumentCoder<CacheStorageConnection::CacheInfo>::decode):
(IPC::ArgumentCoder<CacheStorageConnection::Record>::encode):
(IPC::ArgumentCoder<CacheStorageConnection::Record>::decode):

• Shared/WebCoreArgumentCoders.h:
• WebKit.xcodeproj/project.pbxproj:
• WebProcess/Cache/WebCacheStorageConnection.cpp: Added.

(WebKit::WebCacheStorageConnection::WebCacheStorageConnection):
(WebKit::WebCacheStorageConnection::~WebCacheStorageConnection):
(WebKit::WebCacheStorageConnection::messageSenderConnection):
(WebKit::WebCacheStorageConnection::doOpen):
(WebKit::WebCacheStorageConnection::doRemove):
(WebKit::WebCacheStorageConnection::doRetrieveCaches):
(WebKit::WebCacheStorageConnection::doRetrieveRecords):
(WebKit::WebCacheStorageConnection::doBatchDeleteOperation):
(WebKit::WebCacheStorageConnection::doBatchPutOperation):
(WebKit::WebCacheStorageConnection::openCompleted):
(WebKit::WebCacheStorageConnection::removeCompleted):
(WebKit::WebCacheStorageConnection::updateCaches):
(WebKit::WebCacheStorageConnection::updateRecords):
(WebKit::WebCacheStorageConnection::deleteRecordsCompleted):
(WebKit::WebCacheStorageConnection::putRecordsCompleted):

• WebProcess/Cache/WebCacheStorageConnection.h: Added.
• WebProcess/Cache/WebCacheStorageConnection.messages.in: Added.
• WebProcess/Cache/WebCacheStorageProvider.cpp: Copied from Source/WebKit/WebProcess/Cache/WebCacheStorageProvider.h.

(WebKit::WebCacheStorageProvider::createCacheStorageConnection):

• WebProcess/Cache/WebCacheStorageProvider.h:
• WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didReceiveMessage):

LayoutTests:

• TestExpectations: Marking some tests as flaky until being loaded resources can be cached.

7:52 AM Changeset in webkit [220916] by Antti Koivisto

• 9 edits
  2 adds in trunk/Source/WebCore

Factor render tree mutation code from RenderListItem to RenderTreeUpdater
​https://bugs.webkit.org/show_bug.cgi?id=175718

Reviewed by Andreas Kling.

We already stopped doing layout time mutations. We can now move the code out too.

• WebCore.xcodeproj/project.pbxproj:
• rendering/RenderListItem.cpp:

(WebCore::isHTMLListElement):
(WebCore::getParentOfFirstLineBox): Deleted.
(WebCore::firstNonMarkerChild): Deleted.
(WebCore::RenderListItem::updateMarkerRenderer): Deleted.

Moved to RenderTreeUpdater::ListItem.

• rendering/RenderListItem.h:
• rendering/RenderListMarker.cpp:

(WebCore::RenderListMarker::willBeDestroyed):

• rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::adjustTextNodeSizes):

• style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::pushParent):
(WebCore::RenderTreeUpdater::popParent):
(WebCore::RenderTreeUpdater::updateBeforeDescendants):
(WebCore::RenderTreeUpdater::updateAfterDescendants):

Factor pre/post update into functions.

(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement):

• style/RenderTreeUpdater.h:
• style/RenderTreeUpdaterListItem.cpp: Added.

Mutation functions move here.

(WebCore::getParentOfFirstLineBox):
(WebCore::firstNonMarkerChild):
(WebCore::RenderTreeUpdater::ListItem::updateMarker):

• style/RenderTreeUpdaterListItem.h: Added.

6:41 AM Changeset in webkit [220915] by commit-queue@webkit.org

• 3 edits in trunk/LayoutTests

[GTK] Layout Test media/video-controls-no-scripting.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=141835

Unreviewed test gardening.

The output appears to be consistent based on local testing.

Rebaseline video-controls-no-scripting.html.

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-18

• platform/gtk/TestExpectations:
• platform/gtk/media/video-controls-no-scripting-expected.txt:

4:06 AM Changeset in webkit [220914] by Carlos Garcia Campos

• 1 copy in releases/WebKitGTK/webkit-2.17.91

WebKitGTK+ 2.17.91

4:04 AM Changeset in webkit [220913] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18

Unreviewed. Update OptionsGTK.cmake and NEWS for 2.17.91 release.

.:

• Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit:

• gtk/NEWS: Add release notes for 2.17.91.

2:24 AM Changeset in webkit [220912] by commit-queue@webkit.org

• 7 edits in trunk/LayoutTests

Update track-datacue.html test to the current code.
​https://bugs.webkit.org/show_bug.cgi?id=175624

Patch by Ms2ger <​Ms2ger@igalia.com> on 2017-08-18
Reviewed by Eric Carlson.

• media/track/track-datacue-expected.txt: rebaselined.
• media/track/track-datacue.html: updated for IDL, exception changes, addition of a new constructor.
• platform/gtk/TestExpectations: removed failure expectation.
• platform/ios/TestExpectations: enable.
• platform/mac/TestExpectations: enable.
• platform/win/TestExpectations: enable.

2:12 AM Changeset in webkit [220911] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

[GTK] Remove some obsolete expected failures.
​https://bugs.webkit.org/show_bug.cgi?id=175674

Unreviewed test gardening.

Patch by Ms2ger <​Ms2ger@gmail.com> on 2017-08-18

• platform/gtk/TestExpectations:
  • imported/w3c/web-platform-tests/IndexedDB/keyorder.htm: passing since r204279.
  • imported/w3c/web-platform-tests/resource-timing/rt-cors.html: passing since r212944 and r212993.
  • imported/w3c/web-platform-tests/resource-timing/rt-cors.worker.html: passing since r212944 and r212993.
  • imported/w3c/web-platform-tests/webrtc/getstats.html: passing since test update and rebaseline in r217225.
  • mathml/opentype/large-operators-displaystyle-dynamic.html: used to be flaky, seems to be passing consistently now.
  • media/media-fullscreen-return-to-inline.html: likely passing since r218270.
  • media/video-fast-seek.html: passing since r207879-r207894.
  • platform/gtk/scrollbars/main-frame-scrollbar-horizontal-wheel-scroll.html: passing since r205075.
  • security/contentSecurityPolicy/video-with-data-url-allowed-by-media-src-star.html: flaky.
  • storage/indexeddb/cursor-key-order.html: likely passing since r209135.
  • svg/dom/SVGScriptElement/script-change-externalResourcesRequired-while-loading.svg: flaky.
  • svg/repaint/add-outline-property-on-root.html: passing since r211277
  • svg/repaint/remove-outline-property-on-root.html: passing since r211277

1:58 AM Changeset in webkit [220910] by commit-queue@webkit.org

• 4 edits in trunk

[GTK] Show controls if a video element isn't allowed to play inline.
​https://bugs.webkit.org/show_bug.cgi?id=141705

Patch by Ms2ger <​Ms2ger@gmail.com> on 2017-08-18
Reviewed by Xabier Rodriguez-Calvar.

Source/WebCore:

Test: covered by media/video-fullscreeen-only-controls.html [sic].

• Modules/mediacontrols/mediaControlsGtk.js:

(ControllerGtk.prototype.shouldHaveControls):

LayoutTests:

• platform/gtk/TestExpectations: enable test for this case.

12:53 AM WebKitGTK/2.18.x edited by Carlos Garcia Campos

(diff)

12:53 AM Changeset in webkit [220909] by Carlos Garcia Campos

• 2 edits
  1 add
  1 delete in releases/WebKitGTK/webkit-2.18/Tools

Merge r220902 - [GTK] Make TestContextMenu work on Fedora
​https://bugs.webkit.org/show_bug.cgi?id=175708

Reviewed by Carlos Garcia Campos.

TestContextMenu has been broken for as long as I remember, but not on the bots, only for me
and my student last summer who was trying to work on a context menu API. It's trying to load
an MPEG-2 video file and confirm that right-clicking on it shows media element context menu
entries. Doesn't work on Fedora. Dunno why, since Fedora actually can play MPEG-2, but I
don't care to investigate. Let's switch it to WebM so I can move on.

• TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:

(prepareContextMenuTestView):

• TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Removed.
• TestWebKitAPI/Tests/WebKitGLib/resources/silence.webm: Added.

12:50 AM Changeset in webkit [220908] by Carlos Garcia Campos

• 4 edits
  3 adds in releases/WebKitGTK/webkit-2.18

Merge r220894 - WebAssembly: const in unreachable code decoded incorrectly, erroneously rejects binary as invalid
​https://bugs.webkit.org/show_bug.cgi?id=175693
<rdar://problem/33952443>

Reviewed by Saam Barati.

JSTests:

Add a regression directory for WebAssembly tests.

• wasm.yaml:
• wasm/regress/175693.js: Added.

(else.else):
(instance.new.WebAssembly.Instance.new.WebAssembly.Module):
(catch):

• wasm/regress/175693.wasm: Added.

Source/JavaScriptCore:

64-bit constants in an unreachable context were being decoded as
32-bit constants. This is pretty benign because unreachable code
shouldn't occur often. The effect is that 64-bit constants which
can't be encoded as 32-bit constants would cause the binary to be
rejected.

At the same time, 32-bit integer constants should be decoded as signed.

• wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser<Context>::parseUnreachableExpression):

12:48 AM Changeset in webkit [220907] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18/Source

Merge r220860 - [WPE][GTK] Ensure proper casting of data in gvariants
​https://bugs.webkit.org/show_bug.cgi?id=175667

Patch by Jacobo Aragunde Pérez <​jaragunde@igalia.com> on 2017-08-17
Reviewed by Michael Catanzaro.

Source/JavaScriptCore:

g_variant_new requires data to have the correct width for their types, using
casting if necessary. Some data of type unsigned were being saved to guint64
types without explicit casting, leading to undefined behavior in some platforms.

• inspector/remote/glib/RemoteInspectorGlib.cpp:

(Inspector::RemoteInspector::listingForInspectionTarget const):
(Inspector::RemoteInspector::listingForAutomationTarget const):
(Inspector::RemoteInspector::sendMessageToRemote):

Source/WebKit:

g_variant_builder_add requires data to have the correct width for their types, using
casting if necessary. Corrected a call where a single precision float was being put
into a double precision parameter without a cast.

• UIProcess/API/glib/WebKitWebViewSessionState.cpp:

(encodeFrameState):

12:47 AM Changeset in webkit [220906] by Carlos Garcia Campos

• 11 edits in releases/WebKitGTK/webkit-2.18

Merge r220858 - RenderListItem - Avoid render tree mutation during layout
​https://bugs.webkit.org/show_bug.cgi?id=175666

Reviewed by Andreas Kling.

Source/WebCore:

Mutations should be done by RenderTreeUpdater only.

• rendering/RenderListItem.cpp:

(WebCore::RenderListItem::updateMarkerRenderer):

This is now called by RenderTreeUpdater only.
Remove code dealing with this being called at layout time.
Merged marker construction code from styleDidChange here and renamed for clarity.

(WebCore::RenderListItem::layout):
(WebCore::RenderListItem::computePreferredLogicalWidths):

Remove mutating calls.

(WebCore::RenderListItem::styleDidChange): Deleted.
(WebCore::RenderListItem::insertOrMoveMarkerRendererIfNeeded): Deleted.

• rendering/RenderListItem.h:
• rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::adjustTextNodeSizes):

Call updateMarkerRenderer.

• style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::popParent):
(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement):

Call updateMarkerRenderer.

LayoutTests:

Changes in render tree dumps that don't affect rendering.

• platform/ios/fast/doctypes/002-expected.txt:
• platform/ios/fast/lists/marker-before-empty-inline-expected.txt:
• platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
• platform/mac/fast/doctypes/002-expected.txt:
• platform/mac/fast/lists/marker-before-empty-inline-expected.txt:

12:45 AM Changeset in webkit [220905] by zandobersek@gmail.com

• 7 edits
  1 add in trunk/Source/WebCore

[EME] MediaKeySession has to initiate playback resume on HTMLMediaElement
​https://bugs.webkit.org/show_bug.cgi?id=175671

Reviewed by Xabier Rodriguez-Calvar.

In MediaKeySession::updateKeyStatuses(), HTMLMediaElement objects that are
associated with the MediaKeys instance that created this session have to
be notified in order to run the 'Attempt to Resume Playback If Necessary'
algorithm.

MediaKeys object now tracks the sessions that were created through it.
MediaKeySession object is passed a MediaKeys reference, and has that
reference invalidated if/when the MediaKeys object is destroyed.

In MediaKeySession::updateKeyStatuses(), a task is now queued, notifying
the MediaKeys object, if any, that the associated HTMLMediaElement
instances have to run the mentioned algorithm. The associated media
elements are stored through CDMClient pointers, with HTMLMediaElement
class inheriting from the newly-introduced CDMClient interface.

HTMLMediaElement::cdmClientAttemptToResumePlaybackIfNecessary() is left
unimplemented for now. The object will attach itself to and detach from
the associated MediaKeys object in setMediaKeys() and the destructor,
enabling the MediaKeys object to properly dispatch the playback resume
requests for the attached clients.

• Modules/encryptedmedia/CDMClient.h: Copied from Source/WebCore/Modules/encryptedmedia/MediaKeys.h.

(WebCore::CDMClient::~CDMClient):

• Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::create):
(WebCore::MediaKeySession::MediaKeySession):
(WebCore::MediaKeySession::detachKeys):
(WebCore::MediaKeySession::updateKeyStatuses):

• Modules/encryptedmedia/MediaKeySession.h:
• Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::~MediaKeys):
(WebCore::MediaKeys::createSession):
(WebCore::MediaKeys::attachCDMClient):
(WebCore::MediaKeys::detachCDMClient):
(WebCore::MediaKeys::attemptToResumePlaybackOnClients):

• Modules/encryptedmedia/MediaKeys.h:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::cdmClientAttemptToResumePlaybackIfNecessary):

• html/HTMLMediaElement.h:

12:27 AM Changeset in webkit [220904] by Carlos Garcia Campos

• 17 edits in releases/WebKitGTK/webkit-2.18

Merge r220903 - Unreviewed, rolling out r220854.
​https://bugs.webkit.org/show_bug.cgi?id=175716

I'm not sure we really need this (Requested by KaL on

Reverted changeset:

"[GTK][WPE] Add NTLM authentication enabled API"
​https://bugs.webkit.org/show_bug.cgi?id=122952
​http://trac.webkit.org/changeset/220854

12:22 AM Changeset in webkit [220903] by commit-queue@webkit.org

• 17 edits in trunk

Unreviewed, rolling out r220854.
​https://bugs.webkit.org/show_bug.cgi?id=175716

I'm not sure we really need this (Requested by KaL on
#webkit).

Reverted changeset:

"[GTK][WPE] Add NTLM authentication enabled API"
​https://bugs.webkit.org/show_bug.cgi?id=122952
​http://trac.webkit.org/changeset/220854

Aug 17, 2017:

11:27 PM Changeset in webkit [220902] by Michael Catanzaro

• 2 edits
  1 add
  1 delete in trunk/Tools

[GTK] Make TestContextMenu work on Fedora
​https://bugs.webkit.org/show_bug.cgi?id=175708

Reviewed by Carlos Garcia Campos.

TestContextMenu has been broken for as long as I remember, but not on the bots, only for me
and my student last summer who was trying to work on a context menu API. It's trying to load
an MPEG-2 video file and confirm that right-clicking on it shows media element context menu
entries. Doesn't work on Fedora. Dunno why, since Fedora actually can play MPEG-2, but I
don't care to investigate. Let's switch it to WebM so I can move on.

• TestWebKitAPI/Tests/WebKit2Gtk/TestContextMenu.cpp:

(prepareContextMenuTestView):

• TestWebKitAPI/Tests/WebKitGLib/resources/silence.mpg: Removed.
• TestWebKitAPI/Tests/WebKitGLib/resources/silence.webm: Added.

9:13 PM Changeset in webkit [220901] by Wenson Hsieh

• 5 edits in trunk

[Input Events] Rename inputType "formatForeColor" to "formatFontColor"
​https://bugs.webkit.org/show_bug.cgi?id=175703

Reviewed by Ryosuke Niwa.

Source/WebCore:

Renames an inputType value to match the spec. There is no other change in behavior.
Rebaselines fast/events/input-events-selection-forecolor-data.html and fast/events/input-events-forecolor-data.html.

• editing/EditCommand.cpp:

(WebCore::inputTypeNameForEditingAction):

LayoutTests:

Rebaselines two LayoutTests that check for the "formatForeColor" inputType.

• fast/events/input-events-forecolor-data-expected.txt:
• fast/events/input-events-selection-forecolor-data.html:

9:03 PM Changeset in webkit [220900] by commit-queue@webkit.org

• 6 edits
  9 adds
  4 deletes in trunk/PerformanceTests

Speedometer: Update to modern Vue.js version
​https://bugs.webkit.org/show_bug.cgi?id=175660

Patch by Mathias Bynens <​mathias@qiwi.be> on 2017-08-17
Reviewed by Ryosuke Niwa.

• Speedometer/resources/todomvc/architecture-examples/vuejs-cli/README.md: Documented build process.
• Speedometer/resources/todomvc/architecture-examples/vuejs-cli/config/index.js: Forced relative URLs to avoid breaking the interactive runner.
• Speedometer/resources/todomvc/architecture-examples/vuejs-cli/dist/*: Updated per build steps.
• Speedometer/resources/todomvc/architecture-examples/vuejs-cli/package-lock.json: Added to pin dependencies and make builds deterministic.
• Speedometer/resources/todomvc/architecture-examples/vuejs-cli/package.json: Update to modern Vue.js version.
• Speedometer/resources/todomvc/architecture-examples/vuejs-cli/src/components/Todos.vue: Fix markup error.

8:51 PM Changeset in webkit [220899] by commit-queue@webkit.org

• 5 edits
  5 adds
  2 deletes in trunk/PerformanceTests

Speedometer: Update to modern React/Redux version
​https://bugs.webkit.org/show_bug.cgi?id=175669

Patch by Mathias Bynens <​mathias@qiwi.be> on 2017-08-17
Reviewed by Ryosuke Niwa.

• Speedometer/resources/todomvc/architecture-examples/react-redux/README.md: Documented build steps.
• Speedometer/resources/todomvc/architecture-examples/react-redux/dist/*: Updated per build instructions.
• Speedometer/resources/todomvc/architecture-examples/react-redux/package-lock.json: Pinned dependencies to make builds deterministic.
• Speedometer/resources/todomvc/architecture-examples/react-redux/package.json: Fixed build command.
• Speedometer/resources/todomvc/architecture-examples/react-redux/public/index.html: Made title consistent.

8:13 PM Changeset in webkit [220898] by Matt Baker

• 2 edits
  1 add in trunk/Source/WebInspectorUI

Web Inspector: create better icon for Canvas Path navigation item
​https://bugs.webkit.org/show_bug.cgi?id=175274

Reviewed by Joseph Pecoraro.

• UserInterface/Images/Path.svg: Added.
• UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView):

7:17 PM Changeset in webkit [220897] by commit-queue@webkit.org

• 9 edits in trunk/Source/WebCore

[Curl] Improve multi-threaded networking
​https://bugs.webkit.org/show_bug.cgi?id=175253

Patch by Daewoong Jang <​daewoong.jang@navercorp.com> on 2017-08-17
Reviewed by Alex Christensen.

• platform/network/curl/CurlContext.cpp:

(WebCore::CurlMultiHandle::CurlMultiHandle):
(WebCore::CurlHandle::CurlHandle):
(WebCore::CurlHandle::initialize):
(WebCore::CurlHandle::setSslKeyPassword):
(WebCore::CurlHandle::setSslErrors):
(WebCore::CurlHandle::getSslErrors):

• platform/network/curl/CurlContext.h:
• platform/network/curl/CurlDownload.cpp:

(WebCore::CurlDownload::init):
(WebCore::CurlDownload::getResponse const):
(WebCore::CurlDownload::setupRequest):
(WebCore::CurlDownload::didReceiveHeader):
(WebCore::CurlDownload::didReceiveData):
(WebCore::CurlDownload::headerCallback):
(WebCore::CurlDownload::getTempPath const): Deleted.
(WebCore::CurlDownload::getUrl const): Deleted.
(WebCore::CurlDownload::downloadFinishedCallback): Deleted.
(WebCore::CurlDownload::downloadFailedCallback): Deleted.
(WebCore::CurlDownload::receivedDataCallback): Deleted.
(WebCore::CurlDownload::receivedResponseCallback): Deleted.

• platform/network/curl/CurlDownload.h:
• platform/network/curl/ResourceError.h:

(WebCore::ResourceError::ResourceError):
(WebCore::ResourceError::sslErrors const):
(WebCore::ResourceError::setSSLErrors): Deleted.

• platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandleInternal::initialize):
(WebCore::ResourceHandleInternal::didFail):
(WebCore::ResourceHandleInternal::dispatchSynchronousJob):

• platform/network/curl/SSLHandle.cpp:

(WebCore::allowedClientHosts):
(WebCore::addAllowedClientCertificate):
(WebCore::getSSLClientCertificate):
(WebCore::certVerifyCallback):
(WebCore::setSSLVerifyOptions):
(WebCore::setSSLClientCertificate): Deleted.

• platform/network/curl/SSLHandle.h:

7:17 PM Changeset in webkit [220896] by commit-queue@webkit.org

• 3 edits in trunk/Tools

check-webkit-style shouldn't check spacing in #elif preprocessor lines
​https://bugs.webkit.org/show_bug.cgi?id=175652

Patch by Yoshiaki Jitsukawa <​Yoshiaki.Jitsukawa@sony.com> on 2017-08-17
Reviewed by Alex Christensen.

• Scripts/webkitpy/style/checkers/cpp.py:

(check_spacing):

• Scripts/webkitpy/style/checkers/cpp_unittest.py:

(CppStyleTest.test_spacing_for_binary_ops):

6:34 PM Changeset in webkit [220895] by Megan Gardner

• 3 edits in trunk/Source/WebKit

Update to changeSelectionWithTouchAt:baseIsStart:withFlags:
​https://bugs.webkit.org/show_bug.cgi?id=175615

Update calls to use the flag versions, as they are used for passing state.
Leave old calls, but set them up to be removed next cycle.

Reviewed by Tim Horton.

• Platform/spi/ios/UIKitSPI.h:
• UIProcess/ios/WKContentViewInteraction.mm:

(selectionChangedWithTouch):
(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:]):
(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:withFlags:]):
(-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:]):
(-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:withFlags:]):

6:04 PM Changeset in webkit [220894] by jfbastien@apple.com

• 4 edits
  3 adds in trunk

WebAssembly: const in unreachable code decoded incorrectly, erroneously rejects binary as invalid
​https://bugs.webkit.org/show_bug.cgi?id=175693
<rdar://problem/33952443>

Reviewed by Saam Barati.

JSTests:

Add a regression directory for WebAssembly tests.

• wasm.yaml:
• wasm/regress/175693.js: Added.

(else.else):
(instance.new.WebAssembly.Instance.new.WebAssembly.Module):
(catch):

• wasm/regress/175693.wasm: Added.

Source/JavaScriptCore:

64-bit constants in an unreachable context were being decoded as
32-bit constants. This is pretty benign because unreachable code
shouldn't occur often. The effect is that 64-bit constants which
can't be encoded as 32-bit constants would cause the binary to be
rejected.

At the same time, 32-bit integer constants should be decoded as signed.

• wasm/WasmFunctionParser.h:

(JSC::Wasm::FunctionParser<Context>::parseUnreachableExpression):

5:56 PM Changeset in webkit [220893] by msaboff@apple.com

• 5 edits
  5 adds in trunk/PerformanceTests

Add a Unicode test to RexBench that matches non-BMP characters
​https://bugs.webkit.org/show_bug.cgi?id=175697

Reviewed by JF Bastien.

Added a new sub test that simulates 5 card stud poker. This test uses the Unicode playing
cards code points, U+1F0A1..U+1F0DE, as the card representation. The scoring of hands is
done using three regular expressions, one to check for a flush, one to check for straights
and one to check for pairs, three of a kind and four of a kind.

• RexBench/UniPoker: Added.
• RexBench/UniPoker/benchmark.js: Added.

(UniPokerBenchmark):
(UniPokerBenchmark.prototype.setup.):
(UniPokerBenchmark.prototype.setup.Math.random):
(UniPokerBenchmark.prototype.setup):
(UniPokerBenchmark.prototype.runOnce):
(UniPokerBenchmark.prototype.validate):

• RexBench/UniPoker/expected.js: Added.

(PlayerExpectation):
(PlayerExpectation.prototype.validate):

• RexBench/UniPoker/poker.js: Added.

(CardDeck):
(CardDeck.prototype.newDeck):
(CardDeck.prototype.shuffle):
(CardDeck.prototype.dealOneCard):
(CardDeck.cardRank):
(CardDeck.cardName):
(Hand):
(Hand.prototype.clear):
(Hand.prototype.takeCard):
(Hand.prototype.score):
(Hand.prototype.get rank):
(Hand.prototype.toString):
(Player):
(Player.prototype.scoreHand):
(Player.prototype.wonHand):
(Player.prototype.get name):
(Player.prototype.get hand):
(Player.prototype.get wins):
(Player.prototype.get handTypeCounts):
(playHands):

• RexBench/about.html:
• RexBench/cli.js:
• RexBench/glue.js:

(driver.reportResult):

• RexBench/index.html:
• RexBench/unipoker_benchmark.js: Added.

5:54 PM Changeset in webkit [220892] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark media/video-controls-rendering.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=175700

Unreviewed test gardening.

• platform/mac/TestExpectations:

5:46 PM Changeset in webkit [220891] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Useedate TestExpectations for media/video-controls-show-on-kb-or-ax-event.html.
​https://bugs.webkit.org/show_bug.cgi?id=158889

Unreviewed test gardening.

• platform/mac/TestExpectations:

5:19 PM Changeset in webkit [220890] by commit-queue@webkit.org

• 7 edits in trunk/Source/JavaScriptCore

Teach DFGFixupPhase.cpp that the current scope is always a cell
​https://bugs.webkit.org/show_bug.cgi?id=175610

Patch by Robin Morisset <​rmorisset@apple.com> on 2017-08-17
Reviewed by Keith Miller.

Also teach it that the argument to with can usually be speculated to be an object,
since toObject() is called on it.

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePushWithScope):

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::callOperation):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compilePushWithScope):

• jit/JITOperations.cpp:
• jit/JITOperations.h:

4:32 PM Changeset in webkit [220889] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked accessibility/mac/select-element-selection-with-optgroups.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=175341

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

3:56 PM Changeset in webkit [220888] by Chris Dumez

• 20 edits in trunk/Source

Regression(r220817): We should only copy the original request headers for Ping loads
​https://bugs.webkit.org/show_bug.cgi?id=175679

Reviewed by Youenn Fablet.

Source/WebCore:

For performance reason, we should only copy the original request headers for Ping loads
(Beacon at the moment), not for all CachedResourceRequests.

• loader/LoaderStrategy.h:
• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::load):

• loader/cache/CachedResource.h:

(WebCore::CachedResource::shouldUsePingLoad):
(WebCore::CachedResource::setOriginalRequestHeaders):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::requestResource):

• loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::CachedResourceRequest):

• loader/cache/CachedResourceRequest.h:

(WebCore::CachedResourceRequest::releaseResourceRequest):
(WebCore::CachedResourceRequest::releaseOriginalRequestHeaders): Deleted.

Source/WebKit:

For performance reason, we should only copy the original request headers for Ping loads
(Beacon at the moment), not for all CachedResourceRequests.

• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::loadPing):

• NetworkProcess/NetworkConnectionToWebProcess.h:
• NetworkProcess/NetworkConnectionToWebProcess.messages.in:
• NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):

• NetworkProcess/NetworkResourceLoadParameters.h:
• NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::makeCrossOriginAccessRequest):
(WebKit::PingLoad::makeSimpleCrossOriginAccessRequest):
(WebKit::PingLoad::originalRequestHeaders const): Deleted.

• NetworkProcess/PingLoad.h:
• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::createPingHandle):

• WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

• WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::createPingHandle):

• WebCoreSupport/WebResourceLoadScheduler.h:

3:48 PM Changeset in webkit [220887] by don.olmstead@sony.com

• 81 edits
  2 copies
  1 delete in trunk/Source

[PAL] Relocate SessionID to root
​https://bugs.webkit.org/show_bug.cgi?id=175684

Reviewed by Alex Christensen.

Source/WebCore:

No new tests. No change in functionality.

• dom/Document.h:
• html/HTMLMediaElement.cpp:
• loader/cache/CachedResource.h:
• loader/cache/CachedResourceLoader.cpp:
• loader/cache/MemoryCache.h:
• loader/cocoa/DiskCacheMonitorCocoa.h:
• page/CacheStorageProvider.h:
• page/Page.h:
• page/PlugInClient.h:
• page/SocketProvider.h:
• platform/CookiesStrategy.h:
• platform/WebCoreCrossThreadCopier.cpp:
• platform/network/CacheValidation.h:
• platform/network/NetworkStorageSession.cpp:
• platform/network/NetworkStorageSession.h:
• platform/network/cf/SocketStreamHandleImpl.h:
• platform/network/curl/SocketStreamHandleImpl.h:
• platform/network/soup/SocketStreamHandleImpl.h:
• workers/WorkerGlobalScope.h:
• workers/service/ServiceWorkerContainer.h:
• workers/service/ServiceWorkerRegistrationParameters.h:

Source/WebCore/PAL:

• PAL.xcodeproj/project.pbxproj:
• pal/CMakeLists.txt:
• pal/SessionID.cpp: Renamed from Source/WebCore/PAL/pal/identifier/SessionID.cpp.
• pal/SessionID.h: Renamed from Source/WebCore/PAL/pal/identifier/SessionID.h.

Source/WebKit:

• NetworkProcess/Downloads/Download.h:
• NetworkProcess/Downloads/DownloadManager.cpp:
• NetworkProcess/NetworkCORSPreflightChecker.h:
• NetworkProcess/NetworkConnectionToWebProcess.cpp:
• NetworkProcess/NetworkLoad.cpp:
• NetworkProcess/NetworkLoadParameters.h:
• NetworkProcess/NetworkProcess.cpp:
• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkResourceLoadParameters.h:
• NetworkProcess/NetworkSession.h:
• NetworkProcess/NetworkSocketStream.h:
• NetworkProcess/RemoteNetworkingContext.h:
• NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:
• Scripts/webkit/messages.py:

(forward_declarations_and_headers.templates): Deleted.
(class_template_headers.template): Deleted.

• Shared/ChildProcess.cpp:
• Shared/SessionTracker.h:
• Shared/Storage/StorageProcessCreationParameters.h:
• Shared/WebCoreArgumentCoders.cpp:
• Shared/WebPageCreationParameters.h:
• Shared/WebProcessCreationParameters.h:
• Shared/WebsiteDataStoreParameters.h:
• Shared/mac/CookieStorageShim.mm:
• StorageProcess/IndexedDB/WebIDBConnectionToClient.h:
• StorageProcess/StorageProcess.cpp:
• StorageProcess/StorageProcess.h:
• StorageProcess/StorageToWebProcessConnection.h:
• UIProcess/API/APIPageConfiguration.h:
• UIProcess/API/APIWebsiteDataStore.h:
• UIProcess/API/glib/WebKitCookieManager.cpp:
• UIProcess/Plugins/PlugInAutoStartProvider.h:
• UIProcess/WebCookieManagerProxy.h:
• UIProcess/WebProcessPool.cpp:
• UIProcess/WebProcessPool.h:
• UIProcess/WebProcessProxy.h:
• UIProcess/WebsiteData/WebsiteDataStore.h:
• WebProcess/Cookies/WebCookieManager.h:
• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
• WebProcess/Databases/WebDatabaseProvider.cpp:
• WebProcess/InjectedBundle/InjectedBundle.cpp:
• WebProcess/Network/NetworkProcessConnection.cpp:
• WebProcess/Network/WebLoaderStrategy.cpp:
• WebProcess/Network/WebSocketStream.cpp:
• WebProcess/Network/WebSocketStream.h:
• WebProcess/Storage/WebToStorageProcessConnection.h:
• WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
• WebProcess/WebCoreSupport/WebPlugInClient.h:
• WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
• WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:
• WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
• WebProcess/WebPage/WebPage.cpp:
• WebProcess/WebProcess.h:

Source/WebKitLegacy:

• Storage/WebDatabaseProvider.cpp:

Source/WebKitLegacy/mac:

• WebCoreSupport/WebFrameNetworkingContext.mm:

3:47 PM Changeset in webkit [220886] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html for Sierra.

Unreviewed test gardening.

• platform/mac/js/dom/global-constructors-attributes-expected.txt:

3:41 PM Changeset in webkit [220885] by Ryan Haddad

• 3 edits in trunk/LayoutTests

Rebaseline two tests after r220870.

Unreviewed test gardening.

• inspector/dom/content-node-region-info-expected.txt:
• platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:

3:41 PM Changeset in webkit [220884] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark inspector/canvas/context-attributes.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=173931

Unreviewed test gardening.

• platform/mac/TestExpectations:

3:20 PM Changeset in webkit [220883] by Wenson Hsieh

• 4 edits in trunk

Fix the build on other platforms after r220865
​https://bugs.webkit.org/show_bug.cgi?id=175683

Reviewed by Tim Horton.

Source/WebCore:

Instead of special casing iOS 10 behavior with IPHONE_OS_VERSION_MAX_ALLOWED < 110000, revert to special
casing iOS 11 behavior with IPHONE_OS_VERSION_MAX_ALLOWED >= 110000. This is because other targets that are
neither iOS 10 nor 11 will fail the "before iOS 11" compile-time check, and subsequently assume that item
providers exist. To fix this, flip the compiler-time checks and the order of codeblocks in the
PlatformPasteboard::write methods.

There is no change in behavior.

• platform/ios/PlatformPasteboardIOS.mm:

(WebCore::registerItemToPasteboard):
(WebCore::PlatformPasteboard::write):

Tools:

Check IPHONE_OS_VERSION_MAX_ALLOWED instead of IPHONE_OS_VERSION_MIN_REQUIRED in an SPI header. SPI
availability is determined by SDK version rather than deployment version.

• TestWebKitAPI/ios/UIKitSPI.h:

3:03 PM Changeset in webkit [220882] by rniwa@webkit.org

• 2 edits in trunk/Websites/perf.webkit.org

Number each section in ReadMe.md and add more clarifications
​https://bugs.webkit.org/show_bug.cgi?id=175687

Rubber-stamped by Joseph Pecoraro.

Numbered each section and added more clarifications per issues Aakash encountered.

• ReadMe.md:

2:58 PM Changeset in webkit [220881] by jmarcell@apple.com

• 7 edits in branches/safari-604-branch/Source

Versioning.

2:58 PM Changeset in webkit [220880] by jmarcell@apple.com

• 1 copy in tags/Safari-604.2.4

Tag Safari-604.2.4.

2:50 PM Changeset in webkit [220879] by Matt Lewis

• 2 edits in trunk/LayoutTests

Marked fast/hidpi/hidpi-long-page-with-inset-element.html as a flaky ImageOnlyFailure.
​https://bugs.webkit.org/show_bug.cgi?id=172384

Unreviewed test gardening.

• platform/ios-simulator-wk2/TestExpectations:

2:40 PM Changeset in webkit [220878] by Chris Dumez

• 2 edits in trunk/Source/WebKit

REGRESSION (r220601): Crash under ProcessAssertion::markAsInvalidated()
​https://bugs.webkit.org/show_bug.cgi?id=175685
<rdar://problem/33868623>

Reviewed by Sam Weinig.

After r220601, it is no longer safe to call a default-initialized WTF::Function.

• UIProcess/ios/ProcessAssertionIOS.mm:

(WebKit::ProcessAssertion::markAsInvalidated):

2:23 PM Changeset in webkit [220877] by rniwa@webkit.org

• 2 edits in trunk/Websites/perf.webkit.org

Build fix. Make the test work with the latest versions of node modules.

• server-tests/privileged-api-upload-file-tests.js:

2:17 PM Changeset in webkit [220876] by Michael Catanzaro

• 3 edits in trunk/Source/WebCore

-Wreturn-type warnings in CryptoKey.cpp and SubtleCrypto.cpp
​https://bugs.webkit.org/show_bug.cgi?id=175675

Reviewed by Jiewen Tan.

• crypto/CryptoKey.cpp:

(WebCore::CryptoKey::algorithm const):

• crypto/SubtleCrypto.cpp:

(WebCore::toCryptoKeyUsageBitmap):
(WebCore::toKeyData):

1:54 PM Changeset in webkit [220875] by Nikita Vasilyev

• 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: replace "Enter Class Name" with "Add New Class"
​https://bugs.webkit.org/show_bug.cgi?id=175686

Reviewed by Matt Baker.

"Enter Class Name" isn't very descriptive. It doesn't suggest what's going to happen after you enter a class name.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Views/CSSStyleDetailsSidebarPanel.js:

(WI.CSSStyleDetailsSidebarPanel.prototype.initialLayout):

1:50 PM WebKitGTK/2.18.x edited by Michael Catanzaro

Propose r220860 (diff)

1:38 PM Changeset in webkit [220874] by Matt Lewis

• 2 edits in trunk/LayoutTests

Changed expectations to include release for memory/memory-pressure-simulation.html.
​https://bugs.webkit.org/show_bug.cgi?id=170629

Unreviewed test gardening.

• platform/mac-wk2/TestExpectations:

1:30 PM Changeset in webkit [220873] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Ensure three.js gets minified properly for production builds.
​https://bugs.webkit.org/show_bug.cgi?id=175452

Patch by Ross Kirsling <Ross Kirsling> on 2017-08-17
Reviewed by Brian Burg.

• Scripts/copy-user-interface-resources.pl:

1:25 PM Changeset in webkit [220872] by Matt Baker

• 2 edits in trunk/Source/JavaScriptCore

Web Inspector: remove unused private struct from InspectorScriptProfilerAgent
​https://bugs.webkit.org/show_bug.cgi?id=175644

Reviewed by Brian Burg.

• inspector/agents/InspectorScriptProfilerAgent.h:

12:57 PM Changeset in webkit [220871] by mark.lam@apple.com

• 7 edits in trunk/Source

Only use 16 VFP registers if !CPU(ARM_NEON).
​https://bugs.webkit.org/show_bug.cgi?id=175514

Reviewed by JF Bastien.

Source/JavaScriptCore:

Deleted q16-q31 FPQuadRegisterID enums in ARMv7Assembler.h. The NEON spec
says that there are only 16 128-bit NEON registers. This change is merely to
correct the code documentation of these registers. The FPQuadRegisterID are
currently unused.

• assembler/ARMAssembler.h:

(JSC::ARMAssembler::lastFPRegister):
(JSC::ARMAssembler::fprName):

• assembler/ARMv7Assembler.h:

(JSC::ARMv7Assembler::lastFPRegister):
(JSC::ARMv7Assembler::fprName):

• assembler/MacroAssemblerARM.cpp:
• assembler/MacroAssemblerARMv7.cpp:

Source/WTF:

If CPU(ARM_NEON) is not enabled, we'll conservatively assume only VFP2 support is
available. Hence, we'll only the first 16 FPDoubleRegisterIDs are available.

For reference, see:
NEON registers: ​http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0473c/CJACABEJ.html
VFP2 and VFP3 registers: ​http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0473c/CIHDIBDG.html
NEON to VFP register mapping: ​http://infocenter.arm.com/help/index.jsp?topic=/com.arm.doc.dui0473c/CJAIJHFC.html

This is mostly for GTK toolchains which may target older ARM CPUs which only have
VFP2 support.

• wtf/Platform.h:

12:18 PM Changeset in webkit [220870] by akling@apple.com

• 31 edits in trunk

Disable CSS regions at compile time
​https://bugs.webkit.org/show_bug.cgi?id=175630

Reviewed by Antti Koivisto.

.:

• Source/cmake/OptionsGTK.cmake:
• Source/cmake/OptionsMac.cmake:
• Source/cmake/OptionsWPE.cmake:
• Source/cmake/OptionsWin.cmake:
• Source/cmake/tools/vsprops/FeatureDefines.props:
• Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Tools:

• Scripts/webkitperl/FeatureList.pm:
• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

Skip tests that are entirely about regions, and tweak logic
and/or expectations for tests that test regions in addition to
other things.

• TestExpectations:
• fast/css/will-change/resources/will-change-stacking-helper.js:
• fast/dom/collection-iterators-expected.txt:
• fast/dom/collection-iterators.html:
• js/dom/dom-static-property-for-in-iteration-expected.txt:
• platform/gtk/js/dom/dom-static-property-for-in-iteration-expected.txt:
• platform/ios/fast/dom/collection-iterators-expected.txt:
• platform/mac-wk2/TestExpectations:
• platform/win/js/dom/dom-static-property-for-in-iteration-expected.txt:
• platform/wpe/js/dom/dom-static-property-for-in-iteration-expected.txt:

12:01 PM Changeset in webkit [220869] by Wenson Hsieh

• 2 edits in trunk/Tools

Unreviewed, try to fix the internal iOS 10 build after r220865.

• TestWebKitAPI/ios/UIKitSPI.h:

On the iOS 10 SDK, UIApplication_Private.h cannot be imported in the simulator. Simply fall back to using the
extern declaration when building for pre-iOS 11; once the bots stop building for iOS 10, we can safely remove
this compiler guard.

11:51 AM Changeset in webkit [220868] by jmarcell@apple.com

• 2 edits in tags/Safari-605.1.3/Source/JavaScriptCore

Cherry-pick r220822. rdar://problem/20163327

11:43 AM Changeset in webkit [220867] by jmarcell@apple.com

• 7 edits in tags/Safari-605.1.3/Source/WebCore

Revert r220620. rdar://problem/33928369

11:43 AM Changeset in webkit [220866] by jmarcell@apple.com

• 10 edits in tags/Safari-605.1.3

Revert r220601. rdar://problem/33928369

11:34 AM Changeset in webkit [220865] by Wenson Hsieh

• 17 edits
  1 copy in trunk

[iOS] Respect type fidelities when copying image elements to the pasteboard
​https://bugs.webkit.org/show_bug.cgi?id=175638
<rdar://problem/26556043>

Reviewed by Ryosuke Niwa.

Source/WebCore:

Ensures that we respect type fidelities when copying on iOS, by unifying pasteboard writing codepaths across
dragging and copying. When dragging and copying, we now generate and set UIItemProviders on the UIPasteboard.

Tests: ActionSheetTests.CopyImageElementWithHREF

ActionSheetTests.CopyImageElementWithoutHREF

• platform/PlatformPasteboard.h:

Remove all variants of the writeObjectRepresentations helper method. Now that both paths for writing to the
pasteboard are unified, it's no longer useful to separate out item-provider-based pasteboard logic.

• platform/ios/AbstractPasteboard.h:
• platform/ios/PlatformPasteboardIOS.mm:

Replaces -setItemsUsingRegistrationInfoLists: with -setRegistrationInfoLists:. Rather than have a helper that
both sets up item providers and item registration lists, split this functionality out into two setters. This is
because UIPasteboard does not need to know about the registration info lists used to set up the item providers
in the first place, but internal drag-and-drop clients require this information immediately when starting a drag
in order to construct custom drag previews.

(WebCore::richTextRepresentationsForPasteboardWebContent):
(WebCore::registerItemToPasteboard):

Add a new helper to register item providers to the pasteboard, given an WebItemProviderRegistrationInfoList.

(WebCore::PlatformPasteboard::write):
(WebCore::PlatformPasteboard::writeObjectRepresentations): Deleted.

Refactors PlatformPasteboard::write to always generate and set item providers, unless we're building for an SDK
prior to iOS 11. For images, strings and URLs, we can simply transition to using the new item-provider-based
codepaths used for drag and drop. For web content, we add two additional UTIs that were present when copying,
but not when dragging: flat RTFD and a string constant used to indicate to UIKit that the pasteboard contains
rich text.

• platform/ios/WebItemProviderPasteboard.h:
• platform/ios/WebItemProviderPasteboard.mm:

(-[WebItemProviderRegistrationInfoList init]):
(-[WebItemProviderRegistrationInfoList addData:forType:]):
(-[WebItemProviderRegistrationInfoList addRepresentingObject:]):
(-[WebItemProviderRegistrationInfoList numberOfItems]):
(-[WebItemProviderRegistrationInfoList itemAtIndex:]):
(-[WebItemProviderRegistrationInfoList itemProvider]):
(-[WebItemProviderRegistrationInfoList description]):

Make some small tweaks in WebItemProviderPasteboard (and related classes):

1. Transition to preferredPresentationSize from estimatedDisplayedSize, which is now deprecated.
2. Remove calls to -initWithItemProviderData:typeIdentifier:error:, which is deprecated.
3. Rename _items to _representations to better reflect the role of WebItemProviderRegistrationInfo.
4. Implement -description for WebItemProviderRegistrationInfoList for debugging purposes.

(-[WebItemProviderPasteboard valuesForPasteboardType:inItemSet:]):
(-[WebItemProviderPasteboard setRegistrationInfoLists:]):
(-[WebItemProviderPasteboard setItemsUsingRegistrationInfoLists:]): Deleted.

Source/WebCore/PAL:

Replace -estimatedDisplayedSize with its non-deprecated counterpart, -preferredPresentationSize.

• pal/spi/ios/UIKitSPI.h:

Source/WebKit:

Currently, we treat the case when copying an image enclosed by a link by only writing a URL to the pasteboard.
This patch tweaks logic in WebPage::performActionOnElement to write both an image and a link to the pasteboard
if the hit-tested image element is enclosed by an anchor.

• Platform/spi/ios/UIKitSPI.h:
• WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::containingLinkElement):

Tweak this helper to be more restrictive when finding an enclosing 'link' -- only return an element if isLink()
is true, and it is an HTMLAnchorElement. Currently, the isLink() also matches HTMLLinkElements, but this isn't
the intention here.

(WebKit::WebPage::performActionOnElement):

Tools:

Add API tests that simulate copying an image element using the action sheet, and verifying that the pasteboard
contains UTIs in order of fidelity (image type before URL). Also pulls out UIKit SPI (UIApplicationInitialize)
used in UIPasteboardTests and ActionSheetTests into a common UIKitSPI header.

• TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
• TestWebKitAPI/Tests/ios/ActionSheetTests.mm:

(-[ActionSheetObserver _webView:actionsForElement:defaultActions:]):
(TestWebKitAPI::TEST):
(TestWebKitAPI::presentActionSheetAndChooseAction):
(-[ActionSheetObserver waitForActionSheetAfterBlock:]): Deleted.

• TestWebKitAPI/Tests/ios/DataInteractionTests.mm:

(checkEstimatedSize):
(checkSuggestedNameAndEstimatedSize):

Replace -estimatedDisplayedSize with its non-deprecated counterpart, -preferredPresentationSize.

• TestWebKitAPI/Tests/ios/UIPasteboardTests.mm:

(TestWebKitAPI::TEST):

• TestWebKitAPI/ios/DataInteractionSimulator.h:
• TestWebKitAPI/ios/UIKitSPI.h: Added.

11:21 AM Changeset in webkit [220864] by Jonathan Bedard

• 2 edits in trunk/Tools

Recursively create resource load statistics folder for testing
​https://bugs.webkit.org/show_bug.cgi?id=175676

Reviewed by Brady Eidson.

• WebKitTestRunner/cocoa/TestControllerCocoa.mm:

(WTR::TestController::cocoaPlatformInitialize): Recursively create resourceLoadStatisticsFolder.

11:07 AM Changeset in webkit [220863] by commit-queue@webkit.org

• 7 edits in trunk/Source/WebCore

Add a DOMPromiseDeferred method to handle ExceptionOr<> results
​https://bugs.webkit.org/show_bug.cgi?id=175603

Patch by Youenn Fablet <​youenn@apple.com> on 2017-08-17
Reviewed by Darin Adler.

No change of behavior.

Introduce DOMPromiseDeferred::settle to reject/resolve a promise with an ExceptionOr<>.
Making batchPutOperation/batchDeleteOperation take a Function with an ExceptionOr<>.
Using DOMPromiseDeferred::settle in Cache put/remove.
Updated CacheStorageConnection to create ExceptionOr<> from CacheStorageConnection::Error.

• Modules/cache/Cache.cpp:

(WebCore::Cache::put):
(WebCore::Cache::remove):
(WebCore::Cache::batchDeleteOperation):
(WebCore::Cache::batchPutOperation):

• Modules/cache/Cache.h:
• Modules/cache/CacheStorage.cpp:

(WebCore::CacheStorage::open):
(WebCore::CacheStorage::remove):

• Modules/cache/CacheStorageConnection.cpp:

(WebCore::CacheStorageConnection::errorToException):

• Modules/cache/CacheStorageConnection.h:

(WebCore::CacheStorageConnection::errorToException):
(WebCore::CacheStorageConnection::exceptionOrResult):

• bindings/js/JSDOMPromiseDeferred.h:

(WebCore::DOMPromiseDeferred::settle):
(WebCore::DOMPromiseDeferred<void>::settle):

9:40 AM Changeset in webkit [220862] by zandobersek@gmail.com

• 3 edits in trunk/Source/WebCore

[GStreamer] AppendPipeline: support dispatch of decryption-specific GstStructure into the pipeline
​https://bugs.webkit.org/show_bug.cgi?id=175668

Reviewed by Xabier Rodriguez-Calvar.

Add the AppendPipeline::dispatchDecryptionStructure() method. Callers can
pass in a GstStructure object that contains all the information the
decryption elements in the pipeline will require to properly decrypt the
content. In case the decryptor element isn't available yet, the
GstStructure is stored and dispatched when that element becomes available.

The dispatch itself simply creates a new custom GstEvent that adopts the
given GstStructure object, sends that into the pipeline element, and
shifts the state to 'ongoing'.

• platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsinkFromAnyThread):
(WebCore::AppendPipeline::dispatchPendingDecryptionStructure):
(WebCore::AppendPipeline::dispatchDecryptionStructure):

• platform/graphics/gstreamer/mse/AppendPipeline.h: Remove a redundant private: label.

9:37 AM Changeset in webkit [220861] by zandobersek@gmail.com

• 2 edits in trunk/Source/WebCore

[GStreamer] GstStructure shouldn't be handled through GRefPtr
​https://bugs.webkit.org/show_bug.cgi?id=175673

Reviewed by Xabier Rodriguez-Calvar.

• platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:

(webkitMediaCommonEncryptionDecryptTransformCaps): GstStructure isn't
ref-counted, so it should be handled through the GUniquePtr<GstStructure>
smart pointer.

9:17 AM Changeset in webkit [220860] by commit-queue@webkit.org

• 4 edits in trunk/Source

[WPE][GTK] Ensure proper casting of data in gvariants
​https://bugs.webkit.org/show_bug.cgi?id=175667

Patch by Jacobo Aragunde Pérez <​jaragunde@igalia.com> on 2017-08-17
Reviewed by Michael Catanzaro.

Source/JavaScriptCore:

g_variant_new requires data to have the correct width for their types, using
casting if necessary. Some data of type unsigned were being saved to guint64
types without explicit casting, leading to undefined behavior in some platforms.

• inspector/remote/glib/RemoteInspectorGlib.cpp:

(Inspector::RemoteInspector::listingForInspectionTarget const):
(Inspector::RemoteInspector::listingForAutomationTarget const):
(Inspector::RemoteInspector::sendMessageToRemote):

Source/WebKit:

g_variant_builder_add requires data to have the correct width for their types, using
casting if necessary. Corrected a call where a single precision float was being put
into a double precision parameter without a cast.

• UIProcess/API/glib/WebKitWebViewSessionState.cpp:

(encodeFrameState):

9:11 AM Changeset in webkit [220859] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebCore

[Mac/iOS] Increase the audio buffer size when audio capture is on but web audio is not used
​https://bugs.webkit.org/show_bug.cgi?id=175631

Patch by Youenn Fablet <​youenn@apple.com> on 2017-08-17
Reviewed by Eric Carlson.

• platform/audio/cocoa/MediaSessionManagerCocoa.cpp:

(PlatformMediaSessionManager::updateSessionState): Change value from 128 to the equivalent of 20ms when audio capture happens but not web audio.

8:19 AM Changeset in webkit [220858] by Antti Koivisto

• 11 edits in trunk

RenderListItem - Avoid render tree mutation during layout
​https://bugs.webkit.org/show_bug.cgi?id=175666

Reviewed by Andreas Kling.

Source/WebCore:

Mutations should be done by RenderTreeUpdater only.

• rendering/RenderListItem.cpp:

(WebCore::RenderListItem::updateMarkerRenderer):

This is now called by RenderTreeUpdater only.
Remove code dealing with this being called at layout time.
Merged marker construction code from styleDidChange here and renamed for clarity.

(WebCore::RenderListItem::layout):
(WebCore::RenderListItem::computePreferredLogicalWidths):

Remove mutating calls.

(WebCore::RenderListItem::styleDidChange): Deleted.
(WebCore::RenderListItem::insertOrMoveMarkerRendererIfNeeded): Deleted.

• rendering/RenderListItem.h:
• rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::adjustTextNodeSizes):

Call updateMarkerRenderer.

• style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::popParent):
(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement):

Call updateMarkerRenderer.

LayoutTests:

Changes in render tree dumps that don't affect rendering.

• platform/ios/fast/doctypes/002-expected.txt:
• platform/ios/fast/lists/marker-before-empty-inline-expected.txt:
• platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
• platform/mac/fast/doctypes/002-expected.txt:
• platform/mac/fast/lists/marker-before-empty-inline-expected.txt:

8:17 AM Changeset in webkit [220857] by don.olmstead@sony.com

• 198 edits
  2 moves
  1 add in trunk/Source

[PAL] Move SessionID into PAL
​https://bugs.webkit.org/show_bug.cgi?id=174192

Reviewed by Antti Koivisto.

Source/WebCore:

No new tests. No change in behavior.

• CMakeLists.txt:
• Modules/websockets/WebSocketChannel.cpp:

(WebCore::WebSocketChannel::connect):

• WebCore.xcodeproj/project.pbxproj:
• dom/Document.cpp:

(WebCore::Document::sessionID const):

• dom/Document.h:
• dom/ScriptExecutionContext.h:
• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::elementWithID):
(WebCore::HTMLMediaElement::finishParsingChildren):
(WebCore::HTMLMediaElement::scheduleEvent):
(WebCore::HTMLMediaElement::canPlayType const):
(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::loadResource):
(WebCore::HTMLMediaElement::textTracksAreReady const):
(WebCore::HTMLMediaElement::textTrackModeChanged):
(WebCore::HTMLMediaElement::noneSupported):
(WebCore::HTMLMediaElement::mediaLoadingFailedFatally):
(WebCore::HTMLMediaElement::mediaLoadingFailed):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::addPlayedRange):
(WebCore::HTMLMediaElement::seekTask):
(WebCore::HTMLMediaElement::refreshCachedTime const):
(WebCore::HTMLMediaElement::currentMediaTime const):
(WebCore::HTMLMediaElement::setWebkitPreservesPitch):
(WebCore::HTMLMediaElement::ended const):
(WebCore::HTMLMediaElement::playInternal):
(WebCore::HTMLMediaElement::pause):
(WebCore::HTMLMediaElement::togglePlayState):
(WebCore::HTMLMediaElement::beginScrubbing):
(WebCore::HTMLMediaElement::playbackProgressTimerFired):
(WebCore::HTMLMediaElement::mediaPlayerDidAddTextTrack):
(WebCore::HTMLMediaElement::didAddTextTrack):
(WebCore::HTMLMediaElement::didRemoveTextTrack):
(WebCore::controllerJSValue):
(WebCore::HTMLMediaElement::configureTextTracks):
(WebCore::HTMLMediaElement::selectNextSourceChild):
(WebCore::HTMLMediaElement::sourceWasAdded):
(WebCore::HTMLMediaElement::sourceWasRemoved):
(WebCore::HTMLMediaElement::mediaPlayerTimeChanged):
(WebCore::HTMLMediaElement::mediaPlayerCharacteristicChanged):
(WebCore::HTMLMediaElement::potentiallyPlaying const):
(WebCore::HTMLMediaElement::endedPlayback const):
(WebCore::HTMLMediaElement::stoppedDueToErrors const):
(WebCore::HTMLMediaElement::updatePlayState):
(WebCore::HTMLMediaElement::userCancelledLoad):
(WebCore::HTMLMediaElement::canSuspendForDocumentSuspension const):
(WebCore::HTMLMediaElement::addEventListener):
(WebCore::HTMLMediaElement::isFullscreen const):
(WebCore::HTMLMediaElement::toggleStandardFullscreenState):
(WebCore::HTMLMediaElement::waitForPreparedForInlineThen):
(WebCore::HTMLMediaElement::setVideoFullscreenLayer):
(WebCore::HTMLMediaElement::updateTextTrackDisplay):
(WebCore::HTMLMediaElement::mediaControls const):
(WebCore::HTMLMediaElement::configureTextTrackDisplay):
(WebCore::HTMLMediaElement::setMediaGroup):
(WebCore::HTMLMediaElement::setControllerForBindings):
(WebCore::HTMLMediaElement::isBlockedOnMediaController const):
(WebCore::HTMLMediaElement::prepareMediaFragmentURI):
(WebCore::HTMLMediaElement::didAddUserAgentShadowRoot):
(WebCore::HTMLMediaElement::fileSize const):
(WebCore::HTMLMediaElement::mediaSessionTitle const):
(WebCore::needsSeekingSupportQuirk):
(WebCore::HTMLMediaElement::supportsSeeking const):
(WebCore::HTMLMediaElement::doesHaveAttribute const):
(WebCore::HTMLMediaElement::isVideoTooSmallForInlinePlayback):

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::continueAfterContentPolicy):

• loader/EmptyClients.cpp:
• loader/FrameLoaderClient.h:
• loader/cache/CachedCSSStyleSheet.cpp:

(WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):

• loader/cache/CachedCSSStyleSheet.h:
• loader/cache/CachedFont.cpp:

(WebCore::CachedFont::CachedFont):

• loader/cache/CachedFont.h:
• loader/cache/CachedImage.cpp:

(WebCore::CachedImage::CachedImage):

• loader/cache/CachedImage.h:
• loader/cache/CachedRawResource.cpp:

(WebCore::CachedRawResource::CachedRawResource):

• loader/cache/CachedRawResource.h:
• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):

• loader/cache/CachedResource.h:

(WebCore::CachedResource::sessionID const):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::sessionID const):

• loader/cache/CachedResourceLoader.h:
• loader/cache/CachedSVGDocument.cpp:

(WebCore::CachedSVGDocument::CachedSVGDocument):

• loader/cache/CachedSVGDocument.h:
• loader/cache/CachedSVGFont.cpp:

(WebCore::CachedSVGFont::CachedSVGFont):

• loader/cache/CachedSVGFont.h:
• loader/cache/CachedScript.cpp:

(WebCore::CachedScript::CachedScript):

• loader/cache/CachedScript.h:
• loader/cache/CachedTextTrack.cpp:

(WebCore::CachedTextTrack::CachedTextTrack):

• loader/cache/CachedTextTrack.h:
• loader/cache/CachedXSLStyleSheet.cpp:

(WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):

• loader/cache/CachedXSLStyleSheet.h:
• loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::sessionResourceMap const):
(WebCore::MemoryCache::ensureSessionResourceMap):
(WebCore::MemoryCache::resourceForRequest):
(WebCore::MemoryCache::addImageToCache):
(WebCore::MemoryCache::removeImageFromCache):
(WebCore::MemoryCache::forEachSessionResource):
(WebCore::MemoryCache::removeResourcesWithOrigins):
(WebCore::MemoryCache::originsWithCache const):
(WebCore::MemoryCache::evictResources):

• loader/cache/MemoryCache.h:
• loader/cocoa/DiskCacheMonitorCocoa.h:

(WebCore::DiskCacheMonitor::sessionID const):

• loader/cocoa/DiskCacheMonitorCocoa.mm:

(WebCore::DiskCacheMonitor::monitorFileBackingStoreCreation):
(WebCore::DiskCacheMonitor::DiskCacheMonitor):

• page/CacheStorageProvider.h:
• page/DatabaseProvider.h:
• page/Page.cpp:

(WebCore::Page::Page):
(WebCore::Page::enableLegacyPrivateBrowsing):
(WebCore::Page::sessionID const):
(WebCore::Page::setSessionID):

• page/Page.h:
• page/PlugInClient.h:
• page/SocketProvider.cpp:

(WebCore::SocketProvider::createSocketStreamHandle):

• page/SocketProvider.h:
• platform/CookiesStrategy.h:
• platform/WebCoreCrossThreadCopier.cpp:

(WTF::PAL::SessionID>::copy):
(WTF::WebCore::SessionID>::copy): Deleted.

• platform/WebCoreCrossThreadCopier.h:
• platform/network/CacheValidation.cpp:

(WebCore::headerValueForVary):
(WebCore::collectVaryingRequestHeaders):
(WebCore::verifyVaryingRequestHeaders):

• platform/network/CacheValidation.h:
• platform/network/NetworkStorageSession.cpp:

(WebCore::NetworkStorageSession::globalSessionMap):
(WebCore::NetworkStorageSession::storageSession):
(WebCore::NetworkStorageSession::destroySession):

• platform/network/NetworkStorageSession.h:

(WebCore::NetworkStorageSession::sessionID const):

• platform/network/NetworkStorageSessionStub.cpp:

(WebCore::NetworkStorageSession::NetworkStorageSession):
(WebCore::NetworkStorageSession::ensurePrivateBrowsingSession):
(WebCore::NetworkStorageSession::ensureSession):
(WebCore::NetworkStorageSession::defaultStorageSession):

• platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::NetworkStorageSession):
(WebCore::NetworkStorageSession::switchToNewTestingSession):
(WebCore::NetworkStorageSession::defaultStorageSession):
(WebCore::NetworkStorageSession::ensurePrivateBrowsingSession):
(WebCore::NetworkStorageSession::ensureSession):

• platform/network/cf/SocketStreamHandleImpl.h:

(WebCore::SocketStreamHandleImpl::create):

• platform/network/cf/SocketStreamHandleImplCFNet.cpp:

(WebCore::SocketStreamHandleImpl::SocketStreamHandleImpl):

• platform/network/curl/SocketStreamHandleImpl.h:

(WebCore::SocketStreamHandleImpl::create):

• platform/network/soup/NetworkStorageSessionSoup.cpp:

(WebCore::NetworkStorageSession::NetworkStorageSession):
(WebCore::NetworkStorageSession::defaultStorageSession):
(WebCore::NetworkStorageSession::ensurePrivateBrowsingSession):
(WebCore::NetworkStorageSession::ensureSession):
(WebCore::NetworkStorageSession::switchToNewTestingSession):

• platform/network/soup/SocketStreamHandleImpl.h:
• platform/network/soup/SocketStreamHandleImplSoup.cpp:

(WebCore::SocketStreamHandleImpl::create):

• workers/DedicatedWorkerGlobalScope.cpp:

(WebCore::DedicatedWorkerGlobalScope::create):
(WebCore::DedicatedWorkerGlobalScope::DedicatedWorkerGlobalScope):

• workers/DedicatedWorkerGlobalScope.h:
• workers/DedicatedWorkerThread.cpp:

(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
(WebCore::DedicatedWorkerThread::createWorkerGlobalScope):

• workers/DedicatedWorkerThread.h:
• workers/Worker.cpp:

(WebCore::Worker::notifyFinished):

• workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::WorkerGlobalScope):

• workers/WorkerGlobalScope.h:
• workers/WorkerGlobalScopeProxy.h:
• workers/WorkerMessagingProxy.cpp:

(WebCore::WorkerMessagingProxy::startWorkerGlobalScope):

• workers/WorkerMessagingProxy.h:
• workers/WorkerThread.cpp:

(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):

• workers/WorkerThread.h:
• workers/service/ServiceWorkerContainer.h:
• workers/service/ServiceWorkerRegistrationParameters.h:

Source/WebCore/PAL:

• PAL.xcodeproj/project.pbxproj:
• pal/CMakeLists.txt:
• pal/identifier/SessionID.cpp: Renamed from Source/WebCore/page/SessionID.cpp.
• pal/identifier/SessionID.h: Renamed from Source/WebCore/page/SessionID.h.

(WTF::SessionIDHash::hash):
(WTF::SessionIDHash::equal):
(WTF::HashTraits<PAL::SessionID>::emptyValue):
(WTF::HashTraits<PAL::SessionID>::constructDeletedValue):
(WTF::HashTraits<PAL::SessionID>::isDeletedValue):

Source/WebKit:

• NetworkProcess/Downloads/Download.cpp:

(WebKit::Download::Download):

• NetworkProcess/Downloads/Download.h:

(WebKit::Download::Download):

• NetworkProcess/Downloads/DownloadManager.cpp:

(WebKit::DownloadManager::startDownload):
(WebKit::DownloadManager::resumeDownload):

• NetworkProcess/Downloads/DownloadManager.h:

(WebKit::DownloadManager::startDownload):

• NetworkProcess/NetworkCORSPreflightChecker.h:
• NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::createSocketStream):
(WebKit::storageSession):
(WebKit::NetworkConnectionToWebProcess::startDownload):
(WebKit::NetworkConnectionToWebProcess::convertMainResourceLoadToDownload):
(WebKit::NetworkConnectionToWebProcess::cookiesForDOM):
(WebKit::NetworkConnectionToWebProcess::setCookiesFromDOM):
(WebKit::NetworkConnectionToWebProcess::cookiesEnabled):
(WebKit::NetworkConnectionToWebProcess::cookieRequestHeaderFieldValue):
(WebKit::NetworkConnectionToWebProcess::getRawCookies):
(WebKit::NetworkConnectionToWebProcess::deleteCookie):
(WebKit::NetworkConnectionToWebProcess::ensureLegacyPrivateBrowsingSession):

• NetworkProcess/NetworkConnectionToWebProcess.h:

(WebKit::NetworkConnectionToWebProcess::startDownload):

• NetworkProcess/NetworkConnectionToWebProcess.messages.in:
• NetworkProcess/NetworkLoad.cpp:
• NetworkProcess/NetworkLoadParameters.h:
• NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::destroySession):
(WebKit::fetchDiskCacheEntries):
(WebKit::NetworkProcess::fetchWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteData):
(WebKit::NetworkProcess::deleteWebsiteDataForOrigins):
(WebKit::NetworkProcess::downloadRequest):
(WebKit::NetworkProcess::resumeDownload):

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• NetworkProcess/NetworkResourceLoadParameters.h:
• NetworkProcess/NetworkResourceLoader.h:
• NetworkProcess/NetworkSession.cpp:

(WebKit::NetworkSession::create):
(WebKit::NetworkSession::defaultSession):
(WebKit::NetworkSession::NetworkSession):

• NetworkProcess/NetworkSession.h:

(WebKit::NetworkSession::sessionID const):

• NetworkProcess/NetworkSocketStream.cpp:

(WebKit::NetworkSocketStream::create):
(WebKit::NetworkSocketStream::NetworkSocketStream):

• NetworkProcess/NetworkSocketStream.h:
• NetworkProcess/RemoteNetworkingContext.h:
• NetworkProcess/cache/NetworkCacheSpeculativeLoad.cpp:

(WebKit::NetworkCache::SpeculativeLoad::SpeculativeLoad):

• NetworkProcess/cocoa/NetworkSessionCocoa.h:
• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::configurationForSessionID):
(WebKit::NetworkSessionCocoa::create):
(WebKit::NetworkSessionCocoa::defaultSession):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

• NetworkProcess/soup/NetworkSessionSoup.cpp:

(WebKit::NetworkSessionSoup::NetworkSessionSoup):

• NetworkProcess/soup/NetworkSessionSoup.h:
• Scripts/webkit/messages.py:

(forward_declarations_and_headers.templates): Deleted.
(class_template_headers.template): Deleted.

• Shared/ChildProcess.cpp:

(WebKit::ChildProcess::initialize):

• Shared/SessionTracker.cpp:

(WebKit::staticSessionMap):
(WebKit::SessionTracker::networkSession):
(WebKit::SessionTracker::setSession):
(WebKit::SessionTracker::destroySession):

• Shared/SessionTracker.h:
• Shared/Storage/StorageProcessCreationParameters.h:
• Shared/WebCoreArgumentCoders.cpp:
• Shared/WebCoreArgumentCoders.h:
• Shared/WebPageCreationParameters.h:
• Shared/WebProcessCreationParameters.h:
• Shared/WebsiteDataStoreParameters.h:
• Shared/mac/CookieStorageShim.mm:

(WebKit::webKitCookieStorageCopyRequestHeaderFieldsForURL):

• StorageProcess/IndexedDB/WebIDBConnectionToClient.cpp:

(WebKit::WebIDBConnectionToClient::create):
(WebKit::WebIDBConnectionToClient::WebIDBConnectionToClient):

• StorageProcess/IndexedDB/WebIDBConnectionToClient.h:
• StorageProcess/StorageProcess.cpp:

(WebKit::StorageProcess::idbServer):
(WebKit::StorageProcess::fetchWebsiteData):
(WebKit::StorageProcess::deleteWebsiteData):
(WebKit::StorageProcess::deleteWebsiteDataForOrigins):

• StorageProcess/StorageProcess.h:
• StorageProcess/StorageProcess.messages.in:
• StorageProcess/StorageToWebProcessConnection.cpp:

(WebKit::StorageToWebProcessConnection::establishIDBConnectionToServer):

• StorageProcess/StorageToWebProcessConnection.h:
• StorageProcess/StorageToWebProcessConnection.messages.in:
• UIProcess/API/APIPageConfiguration.cpp:

(API::PageConfiguration::setWebsiteDataStore):
(API::PageConfiguration::sessionID):
(API::PageConfiguration::setSessionID):

• UIProcess/API/APIPageConfiguration.h:
• UIProcess/API/APIWebsiteDataStore.cpp:

(API::WebsiteDataStore::defaultDataStore):
(API::WebsiteDataStore::createLegacy):
(API::WebsiteDataStore::WebsiteDataStore):

• UIProcess/API/APIWebsiteDataStore.h:
• UIProcess/API/C/WKCookieManager.cpp:

(WKCookieManagerGetHostnamesWithCookies):
(WKCookieManagerDeleteCookiesForHostname):
(WKCookieManagerDeleteAllCookies):
(WKCookieManagerDeleteAllCookiesModifiedAfterDate):
(WKCookieManagerSetHTTPCookieAcceptPolicy):
(WKCookieManagerGetHTTPCookieAcceptPolicy):
(WKCookieManagerStartObservingCookieChanges):
(WKCookieManagerStopObservingCookieChanges):

• UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _setCookieAcceptPolicy:]):

• UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _initWithConfiguration:]):

• UIProcess/API/glib/WebKitCookieManager.cpp:

(webkit_cookie_manager_set_accept_policy):
(webkit_cookie_manager_get_accept_policy):

• UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::fetchWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteDataForOrigins):

• UIProcess/Network/NetworkProcessProxy.h:
• UIProcess/Plugins/PlugInAutoStartProvider.cpp:

(WebKit::PlugInAutoStartProvider::PlugInAutoStartProvider):
(WebKit::PlugInAutoStartProvider::addAutoStartOriginHash):
(WebKit::PlugInAutoStartProvider::autoStartOriginsTableCopy const):
(WebKit::PlugInAutoStartProvider::setAutoStartOriginsTableWithItemsPassingTest):
(WebKit::PlugInAutoStartProvider::didReceiveUserInteraction):

• UIProcess/Plugins/PlugInAutoStartProvider.h:
• UIProcess/Storage/StorageProcessProxy.cpp:

(WebKit::StorageProcessProxy::fetchWebsiteData):
(WebKit::StorageProcessProxy::deleteWebsiteData):
(WebKit::StorageProcessProxy::deleteWebsiteDataForOrigins):

• UIProcess/Storage/StorageProcessProxy.h:
• UIProcess/WebCookieManagerProxy.cpp:

(WebKit::WebCookieManagerProxy::getHostnamesWithCookies):
(WebKit::WebCookieManagerProxy::deleteCookiesForHostname):
(WebKit::WebCookieManagerProxy::deleteAllCookies):
(WebKit::WebCookieManagerProxy::deleteCookie):
(WebKit::WebCookieManagerProxy::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManagerProxy::setCookie):
(WebKit::WebCookieManagerProxy::setCookies):
(WebKit::WebCookieManagerProxy::getAllCookies):
(WebKit::WebCookieManagerProxy::getCookies):
(WebKit::WebCookieManagerProxy::startObservingCookieChanges):
(WebKit::WebCookieManagerProxy::stopObservingCookieChanges):
(WebKit::WebCookieManagerProxy::setCookieObserverCallback):
(WebKit::WebCookieManagerProxy::registerObserver):
(WebKit::WebCookieManagerProxy::unregisterObserver):
(WebKit::WebCookieManagerProxy::cookiesDidChange):
(WebKit::WebCookieManagerProxy::setHTTPCookieAcceptPolicy):
(WebKit::WebCookieManagerProxy::getHTTPCookieAcceptPolicy):

• UIProcess/WebCookieManagerProxy.h:
• UIProcess/WebCookieManagerProxy.messages.in:
• UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::sessionID const):

• UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebProcessPool::createNewWebProcess):
(WebKit::WebProcessPool::createWebPage):
(WebKit::WebProcessPool::pageAddedToProcess):
(WebKit::WebProcessPool::pageRemovedFromProcess):
(WebKit::WebProcessPool::download):
(WebKit::WebProcessPool::resumeDownload):
(WebKit::WebProcessPool::addPlugInAutoStartOriginHash):
(WebKit::WebProcessPool::plugInDidReceiveUserInteraction):

• UIProcess/WebProcessPool.h:
• UIProcess/WebProcessPool.messages.in:
• UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::deleteWebsiteDataForTopPrivatelyControlledDomainsInAllPersistentDataStores):
(WebKit::WebProcessProxy::topPrivatelyControlledDomainsWithWebsiteData):
(WebKit::WebProcessProxy::fetchWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteDataForOrigins):

• UIProcess/WebProcessProxy.h:
• UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::createNonPersistent):
(WebKit::WebsiteDataStore::create):
(WebKit::WebsiteDataStore::WebsiteDataStore):
(WebKit::WebsiteDataStore::~WebsiteDataStore):

• UIProcess/WebsiteData/WebsiteDataStore.h:

(WebKit::WebsiteDataStore::sessionID const):

• WebProcess/Cookies/WebCookieManager.cpp:

(WebKit::WebCookieManager::getHostnamesWithCookies):
(WebKit::WebCookieManager::deleteCookiesForHostname):
(WebKit::WebCookieManager::deleteAllCookies):
(WebKit::WebCookieManager::deleteCookie):
(WebKit::WebCookieManager::deleteAllCookiesModifiedSince):
(WebKit::WebCookieManager::getAllCookies):
(WebKit::WebCookieManager::getCookies):
(WebKit::WebCookieManager::setCookie):
(WebKit::WebCookieManager::setCookies):
(WebKit::WebCookieManager::notifyCookiesDidChange):
(WebKit::WebCookieManager::startObservingCookieChanges):
(WebKit::WebCookieManager::stopObservingCookieChanges):

• WebProcess/Cookies/WebCookieManager.h:
• WebProcess/Cookies/WebCookieManager.messages.in:
• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:

(WebKit::WebIDBConnectionToServer::create):
(WebKit::WebIDBConnectionToServer::WebIDBConnectionToServer):

• WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
• WebProcess/Databases/WebDatabaseProvider.cpp:

(WebKit::WebDatabaseProvider::idbConnectionToServerForSession):

• WebProcess/Databases/WebDatabaseProvider.h:
• WebProcess/InjectedBundle/InjectedBundle.cpp:

(WebKit::InjectedBundle::setPrivateBrowsingEnabled):

• WebProcess/Network/NetworkProcessConnection.cpp:

(WebKit::NetworkProcessConnection::didCacheResource):

• WebProcess/Network/NetworkProcessConnection.h:
• WebProcess/Network/NetworkProcessConnection.messages.in:
• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoad):
(WebKit::WebLoaderStrategy::loadResourceSynchronously):
(WebKit::WebLoaderStrategy::createPingHandle):

• WebProcess/Network/WebSocketProvider.cpp:

(WebKit::WebSocketProvider::createSocketStreamHandle):

• WebProcess/Network/WebSocketProvider.h:
• WebProcess/Network/WebSocketStream.cpp:

(WebKit::WebSocketStream::create):
(WebKit::WebSocketStream::WebSocketStream):

• WebProcess/Network/WebSocketStream.h:
• WebProcess/Storage/WebToStorageProcessConnection.cpp:

(WebKit::WebToStorageProcessConnection::idbConnectionToServerForSession):

• WebProcess/Storage/WebToStorageProcessConnection.h:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::convertMainResourceLoadToDownload):

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
• WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::cookieRequestHeaderFieldValue):

• WebProcess/WebCoreSupport/WebPlatformStrategies.h:
• WebProcess/WebCoreSupport/WebPlugInClient.cpp:

(WebKit::WebPlugInClient::didStartFromOrigin):

• WebProcess/WebCoreSupport/WebPlugInClient.h:
• WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
• WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:

(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):

• WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.cpp:

(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession):

• WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
• WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::startDownload):
(WebKit::WebFrame::convertMainResourceLoadToDownload):

• WebProcess/WebPage/WebFrame.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::setSessionID):
(WebKit::WebPage::updatePreferences):

• WebProcess/WebPage/WebPage.h:

(WebKit::WebPage::sessionID const):

• WebProcess/WebProcess.cpp:

(WebKit::m_webSQLiteDatabaseTracker):
(WebKit::WebProcess::ensurePrivateBrowsingSession):
(WebKit::WebProcess::destroySession):
(WebKit::WebProcess::isPlugInAutoStartOriginHash):
(WebKit::WebProcess::plugInDidStartFromOrigin):
(WebKit::WebProcess::didAddPlugInAutoStartOriginHash):
(WebKit::WebProcess::resetPlugInAutoStartOriginDefaultHashes):
(WebKit::WebProcess::resetPlugInAutoStartOriginHashes):
(WebKit::WebProcess::plugInDidReceiveUserInteraction):
(WebKit::WebProcess::fetchWebsiteData):
(WebKit::WebProcess::deleteWebsiteData):
(WebKit::WebProcess::deleteWebsiteDataForOrigins):

• WebProcess/WebProcess.h:
• WebProcess/WebProcess.messages.in:

Source/WebKitLegacy:

• Storage/WebDatabaseProvider.cpp:

(WebDatabaseProvider::idbConnectionToServerForSession):

• Storage/WebDatabaseProvider.h:

Source/WebKitLegacy/mac:

• Misc/WebCache.mm:

(+[WebCache imageForURL:]):

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::convertMainResourceLoadToDownload):

• WebCoreSupport/WebFrameNetworkingContext.mm:

(WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebFrameNetworkingContext::storageSession const):

• WebCoreSupport/WebPlatformStrategies.h:
• WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::cookieRequestHeaderFieldValue):

• WebKitPrefix.h:

Source/WebKitLegacy/win:

• WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::convertMainResourceLoadToDownload):

• WebCoreSupport/WebFrameLoaderClient.h:
• WebCoreSupport/WebFrameNetworkingContext.cpp:

(WebFrameNetworkingContext::setCookieAcceptPolicyForAllContexts):
(WebFrameNetworkingContext::ensurePrivateBrowsingSession):
(WebFrameNetworkingContext::destroyPrivateBrowsingSession):
(WebFrameNetworkingContext::storageSession const):

• WebCoreSupport/WebPlatformStrategies.cpp:

(WebPlatformStrategies::cookieRequestHeaderFieldValue):

• WebCoreSupport/WebPlatformStrategies.h:

7:58 AM Changeset in webkit [220856] by commit-queue@webkit.org

• 2 edits in trunk/Source/WebKit

Fix typo: setUpInectedBundleClient
​https://bugs.webkit.org/show_bug.cgi?id=175655

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-08-17
Reviewed by Andreas Kling.

• UIProcess/API/Cocoa/WKProcessGroup.mm:

(setUpInjectedBundleClient):
(-[WKProcessGroup initWithInjectedBundleURL:]):

6:20 AM Changeset in webkit [220855] by Carlos Garcia Campos

• 17 edits in releases/WebKitGTK/webkit-2.18

Merge r220854 - [GTK][WPE] Add NTLM authentication enabled API
​https://bugs.webkit.org/show_bug.cgi?id=122952

Reviewed by Michael Catanzaro.

Source/WebCore:

Add/remove NTLM feature to/from soup session depending on whether the feature is enabled or disabled.

• platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::SoupNetworkSession):
(WebCore::SoupNetworkSession::setInitialNTLMAuthenticationEnabled):
(WebCore::SoupNetworkSession::setNTLMAuthenticationEnabled):

• platform/network/soup/SoupNetworkSession.h:

Source/WebKit:

Add API to WebKitWebContext to enable/disable NTLM authentication.

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

• NetworkProcess/NetworkProcessCreationParameters.h:
• NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformInitializeNetworkProcess):
(WebKit::NetworkProcess::setNTLMAuthenticationEnabled):

• UIProcess/API/glib/WebKitWebContext.cpp:

(webkit_web_context_get_ntlm_authentication_enabled):
(webkit_web_context_set_ntlm_authentication_enabled):

• UIProcess/API/gtk/WebKitWebContext.h:
• UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
• UIProcess/API/wpe/WebKitWebContext.h:
• UIProcess/WebProcessPool.h:
• UIProcess/soup/WebProcessPoolSoup.cpp:

(WebKit::WebProcessPool::setNTLMAuthenticationEnabled):

Tools:

Add a test case to check we can enable/disable NTLM.

• TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:

(testWebViewAuthenticationNTLM):
(beforeAll):

6:13 AM Changeset in webkit [220854] by Carlos Garcia Campos

• 17 edits in trunk

[GTK][WPE] Add NTLM authentication enabled API
​https://bugs.webkit.org/show_bug.cgi?id=122952

Reviewed by Michael Catanzaro.

Source/WebCore:

Add/remove NTLM feature to/from soup session depending on whether the feature is enabled or disabled.

• platform/network/soup/SoupNetworkSession.cpp:

(WebCore::SoupNetworkSession::SoupNetworkSession):
(WebCore::SoupNetworkSession::setInitialNTLMAuthenticationEnabled):
(WebCore::SoupNetworkSession::setNTLMAuthenticationEnabled):

• platform/network/soup/SoupNetworkSession.h:

Source/WebKit:

Add API to WebKitWebContext to enable/disable NTLM authentication.

• NetworkProcess/NetworkProcess.h:
• NetworkProcess/NetworkProcess.messages.in:
• NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

• NetworkProcess/NetworkProcessCreationParameters.h:
• NetworkProcess/soup/NetworkProcessSoup.cpp:

(WebKit::NetworkProcess::platformInitializeNetworkProcess):
(WebKit::NetworkProcess::setNTLMAuthenticationEnabled):

• UIProcess/API/glib/WebKitWebContext.cpp:

(webkit_web_context_get_ntlm_authentication_enabled):
(webkit_web_context_set_ntlm_authentication_enabled):

• UIProcess/API/gtk/WebKitWebContext.h:
• UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
• UIProcess/API/wpe/WebKitWebContext.h:
• UIProcess/WebProcessPool.h:
• UIProcess/soup/WebProcessPoolSoup.cpp:

(WebKit::WebProcessPool::setNTLMAuthenticationEnabled):

Tools:

Add a test case to check we can enable/disable NTLM.

• TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:

(testWebViewAuthenticationNTLM):
(beforeAll):

5:41 AM Changeset in webkit [220853] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests

REGRESSION(r220751): [GTK] Layout Test imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any.html is failing
​https://bugs.webkit.org/show_bug.cgi?id=175641

Unreviewed test gardening.

Correct the error message in scheme-about.any-expected.txt.

Patch by Ms2ger <​Ms2ger@gmail.com> on 2017-08-17

• platform/gtk/imported/w3c/web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt:

5:15 AM Changeset in webkit [220852] by Yusuke Suzuki

• 6 edits in trunk/Source/JavaScriptCore

[JSC] Avoid code bloating for iteration if block does not have "break"
​https://bugs.webkit.org/show_bug.cgi?id=173228

Reviewed by Keith Miller.

Currently, we always emit code for breaked path when emitting for-of iteration.
But we can know that this breaked path can be used when emitting the bytecode.

This patch adds LabelScope::breakTargetMayBeBound(), which returns true if
the break label may be bound. We emit a breaked path only when it returns
true. This reduces bytecode bloating when using for-of iteration.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::Label::setLocation):
(JSC::BytecodeGenerator::newLabel):
(JSC::BytecodeGenerator::emitLabel):
(JSC::BytecodeGenerator::pushFinallyControlFlowScope):
(JSC::BytecodeGenerator::breakTarget):
(JSC::BytecodeGenerator::continueTarget):
(JSC::BytecodeGenerator::emitEnumeration):

• bytecompiler/BytecodeGenerator.h:
• bytecompiler/Label.h:

(JSC::Label::bind const):
(JSC::Label::hasOneRef const):
(JSC::Label::isBound const):
(JSC::Label::Label): Deleted.

• bytecompiler/LabelScope.h:

(JSC::LabelScope::hasOneRef const):
(JSC::LabelScope::breakTargetMayBeBound const):

• bytecompiler/NodesCodegen.cpp:

(JSC::ContinueNode::trivialTarget):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::trivialTarget):
(JSC::BreakNode::emitBytecode):

3:02 AM Changeset in webkit [220851] by commit-queue@webkit.org

• 4 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening
​https://bugs.webkit.org/show_bug.cgi?id=175664

Unreviewed test gardening.

Patch by Ms2ger <​Ms2ger@gmail.com> on 2017-08-17

• platform/gtk/TestExpectations: update.
• platform/gtk/crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt: rebaseline for change in r220811.
• platform/wpe/crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt: rebaseline for change in r220811.

2:15 AM WebKitGTK/2.16.x edited by tpopela@redhat.com

(diff)

1:45 AM Changeset in webkit [220850] by Csaba Osztrogonác

• 2 edits in trunk/Source/JavaScriptCore

ARM build fix after r220807 and r220834.
​https://bugs.webkit.org/show_bug.cgi?id=175617

Unreviewed typo fix.

• assembler/MacroAssemblerARM.cpp:

1:03 AM Changeset in webkit [220849] by Carlos Garcia Campos

• 9 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220806 - Make RenderLayer and RenderLayerBacking TextStream-loggable, and clean up compositing logging
​https://bugs.webkit.org/show_bug.cgi?id=175634

Reviewed by Zalan Bujtas.

Add operator<<(TextStream&) for RenderLayer and RenderLayer backing, and use them for compositing logging.

Convert CompositingUpdateType to an enum class.

• page/FrameView.cpp:

(WebCore::FrameView::updateCompositingLayersAfterLayout):
(WebCore::FrameView::updateCompositingLayersAfterScrolling):

• page/ios/FrameIOS.mm:

(WebCore::Frame::viewportOffsetChanged):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositionsAfterLayout):
(WebCore::RenderLayer::updateCompositingLayersAfterScroll):
(WebCore::RenderLayer::calculateClipRects const):

• rendering/RenderLayer.h:
• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterLayout):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::operator<<):

• rendering/RenderLayerBacking.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::didRecalcStyleWithNoPendingLayout):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::layerTreeAsText):
(WebCore::operator<<):

• rendering/RenderLayerCompositor.h:

1:01 AM Changeset in webkit [220848] by Carlos Garcia Campos

• 3 edits
  2 adds in releases/WebKitGTK/webkit-2.18

Merge r220797 - [HarfBuzz] Decomposed Vietnamese characters are rendered incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=174418

Patch by Fujii Hironori <Fujii Hironori> on 2017-08-16
Reviewed by Michael Catanzaro.

Source/WebCore:

HarfBuzzShaper should normalize the input text before collecting
HarfBuzzRuns. Actually, HarfBuzzShaper::setNormalizedBuffer does
the task. But, this function hasn't been called from anywhere
since Bug 90951.

Test: fast/text/international/vietnamese-nfd.html

imported/blink/fast/text/international/text-shaping-arabic-diffs.html

• platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::HarfBuzzShaper):
Call setNormalizedBuffer instead of normalizeCharacters.
(WebCore::normalizeCharacters): Deleted.
(WebCore::normalizeSpacesAndMirrorChars) Use
FontCascade::treatAsZeroWidthSpaceInComplexScript instead of
FontCascade::treatAsZeroWidthSpace to preserve ZWJ and ZWNJ.

LayoutTests:

• fast/text/international/vietnamese-nfd-expected.html: Added.
• fast/text/international/vietnamese-nfd.html: Added.

1:00 AM Changeset in webkit [220847] by Carlos Garcia Campos

• 3 edits
  2 deletes in releases/WebKitGTK/webkit-2.18

Merge r220746 - Unreviewed, rolling out r219504.
​https://bugs.webkit.org/show_bug.cgi?id=175580

Broke Arabic text shaping (Requested by mcatanzaro on

Reverted changeset:

"[HarfBuzz] Decomposed Vietnamese characters are rendered
incorrectly"
​https://bugs.webkit.org/show_bug.cgi?id=174418
​http://trac.webkit.org/changeset/219504

12:57 AM Changeset in webkit [220846] by Carlos Garcia Campos

• 13 edits
  2 adds in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220795 - Move first-letter renderer mutation code out of RenderBlock and into RenderTreeUpdater
​https://bugs.webkit.org/show_bug.cgi?id=175627

Reviewed by Andreas Kling.

Render tree should not mutate itself. We already fixed this for first-letter, supporting code
can now move to RenderTreeUpdater too.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• rendering/RenderBlock.cpp:

(WebCore::styleForFirstLetter): Deleted.
(WebCore::isPunctuationForFirstLetter): Deleted.
(WebCore::shouldSkipForFirstLetter): Deleted.
(WebCore::RenderBlock::updateFirstLetterStyle): Deleted.
(WebCore::RenderBlock::createFirstLetterRenderer): Deleted.
(WebCore::RenderBlock::updateFirstLetter): Deleted.

• rendering/RenderBlock.h:
• rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::updateFirstLetter): Deleted.

• rendering/RenderRubyRun.h:
• rendering/RenderTable.cpp:

(WebCore::RenderTable::updateFirstLetter): Deleted.

• rendering/RenderTable.h:

Virtual overrides just disabled first letter for some RenderBlock subclasses. This is now achieved via
supportsFirstLetter test in the first letter updater.

• rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::adjustTextNodeSizes):

• rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::updateFirstLetter): Deleted.

• rendering/svg/RenderSVGText.h:
• style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::popParent):

• style/RenderTreeUpdater.h:
• style/RenderTreeUpdaterFirstLetter.cpp: Added.

(WebCore::styleForFirstLetter):
(WebCore::isPunctuationForFirstLetter):
(WebCore::shouldSkipForFirstLetter):
(WebCore::updateFirstLetterStyle):
(WebCore::createFirstLetterRenderer):
(WebCore::supportsFirstLetter):
(WebCore::RenderTreeUpdater::FirstLetter::update):

• style/RenderTreeUpdaterFirstLetter.h: Added.

12:50 AM Changeset in webkit [220845] by Carlos Garcia Campos

• 8 edits in releases/WebKitGTK/webkit-2.18/Source/WebDriver

Merge r220794 - WebDriver: fix return value of close window command
​https://bugs.webkit.org/show_bug.cgi?id=174861

Reviewed by Brian Burg.

We are currently returning null, but we should return the list of window handles, and try to close the session
if there aren't more window handles.

10.2 Close Window
​https://w3c.github.io/webdriver/webdriver-spec.html#close-window

3. If there are no more open top-level browsing contexts, then try to close the session.
4. Return the result of running the remote end steps for the Get Window Handles command.

• Session.cpp:

(WebDriver::Session::closeAllToplevelBrowsingContexts): Helper function to close the given toplevel browsing
context and the next one if there are more.
(WebDriver::Session::close): Call closeAllToplevelBrowsingContexts() to delete all toplevel browsing contexts of
the session.
(WebDriver::Session::closeTopLevelBrowsingContext): Close the given toplevel browsing context and call
getWindowHandles() when done.
(WebDriver::Session::closeWindow): Call closeTopLevelBrowsingContext() passing the current toplevel browsing context.
(WebDriver::Session::getWindowHandles): Remove the early return, this command doesn't depend on a current
toplevel browsing context.

• Session.h:
• SessionHost.h:
• WebDriverService.cpp:

(WebDriver::WebDriverService::run): Disconnect the server when main loop quits.
(WebDriver::WebDriverService::deleteSession): Do not fail if the given session is not active.
(WebDriver::WebDriverService::closeWindow): Remove the session if the closed window was the last one.

• WebDriverService.h: Remove unused quit() method.
• glib/SessionHostGlib.cpp:

(WebDriver::SessionHost::isConnected): Return whether host is connected to a browser instance.
(WebDriver::SessionHost::dbusConnectionClosedCallback): Delete m_browser.

12:50 AM Changeset in webkit [220844] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220793 - [GTK] Crash of WebProcess with on-demand AC
​https://bugs.webkit.org/show_bug.cgi?id=171161

Reviewed by Carlos Garcia Campos.

Set the viewOverlayRootLayer to the previous layerTreeHost if it exists. This avoids a
crash when reusing the previous layerTreeHost, because it would keep a reference to an
already destroyed viewOverlayRootLayer.

• WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::attachViewOverlayGraphicsLayer):

12:49 AM Changeset in webkit [220843] by Carlos Garcia Campos

• 10 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220792 - [CoordGraphics] Simplify CoordinatedGraphicsScene state updates
​https://bugs.webkit.org/show_bug.cgi?id=175528
<rdar://problem/33876795>

Reviewed by Carlos Garcia Campos.

Hold the information about state updates in ThreadedCompositor, in the
m_attributes struct. This way we don't need to store the updates in
functors and accumulate them in the CoordinatedGraphicsScene class, but
instead just apply any pending state update or atlas removal before the
scene is rendered.

This removes the need to update the CoordinatedGraphicsScene object from
the main thread with data that ultimately has to be handled on the
composition thread. Similarly, when updating CoordinatedGraphicsScene, we
only need to synchronize on the m_attributes lock object once in order to
retrieve the scene update information, instead of having each functor do
that repeatedly.

Outside of CoordinatedGraphicsScene and ThreadedCompositor classes, the
CompositingCoordinator class now passes the atlases-to-remove Vector by
a const lvalue reference down to ThreadedCompositor, and then manually
clears the Vector. Before the Vector was passed as an rvalue reference,
depending on the ThreadedCompositor code to clear out the original Vector
object by moving its resources into the functor object. This doesn't occur
anymore because the Vector object is now appended to another Vector.

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::applyStateChanges):
(WebKit::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebKit::CoordinatedGraphicsScene::detach):
(WebKit::CoordinatedGraphicsScene::setActive):
(WebKit::CoordinatedGraphicsScene::syncRemoteContent): Deleted.
(WebKit::CoordinatedGraphicsScene::appendUpdate): Deleted.

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::renderLayerTree):
(WebKit::ThreadedCompositor::updateSceneState):
(WebKit::ThreadedCompositor::releaseUpdateAtlases):

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::flushPendingLayerChanges):
(WebKit::CompositingCoordinator::releaseAtlases):
(WebKit::CompositingCoordinator::clearUpdateAtlases):

• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
• WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::releaseUpdateAtlases):

• WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:

12:49 AM Changeset in webkit [220842] by Carlos Garcia Campos

• 6 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220672 - [ThreadedCompositor] Improve composition and update state handling
​https://bugs.webkit.org/show_bug.cgi?id=172448

Reviewed by Carlos Garcia Campos.

In the ThreadedCompositor and related classes, we now track composition
and scene update states separately. This enables properly piping in the
DisplayRefreshMonitor object, leveraging it for both display refresh
notifications and signalling to the client that the scene update is
completed.

In CompositingRunLoop, two separate states are now used, one for
compositing and the other for scene update. Access to both should be done
while the related Lock object is held. The pending update state is also
tracked in order to schedule any required updates as soon as the current
state update is completed.

In ThreadedCompositor, the information about client notification and
update completion coordination is now also kept under a Lock object,
moving away from atomics. DisplayRefreshMonitor can now utilize just
two methods in order to either schedule an update or report that update
as finished.

• Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.cpp:

(WebKit::CompositingRunLoop::CompositingRunLoop):
(WebKit::CompositingRunLoop::scheduleUpdate):
(WebKit::CompositingRunLoop::stopUpdates):
(WebKit::CompositingRunLoop::compositionCompleted):
(WebKit::CompositingRunLoop::updateCompleted):
(WebKit::CompositingRunLoop::updateTimerFired):
(WebKit::CompositingRunLoop::isActive): Deleted.

• Shared/CoordinatedGraphics/threadedcompositor/CompositingRunLoop.h:

(WebKit::CompositingRunLoop::stateLock):

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::m_displayRefreshMonitor):
(WebKit::ThreadedCompositor::sceneUpdateFinished):
(WebKit::ThreadedCompositor::updateSceneState):
(WebKit::ThreadedCompositor::requestDisplayRefreshMonitorUpdate):
(WebKit::ThreadedCompositor::handleDisplayRefreshMonitorUpdate):
(WebKit::ThreadedCompositor::renderNextFrameIfNeeded): Deleted.
(WebKit::ThreadedCompositor::completeCoordinatedUpdateIfNeeded): Deleted.
(WebKit::ThreadedCompositor::coordinateUpdateCompletionWithClient): Deleted.

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
• Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:

(WebKit::ThreadedDisplayRefreshMonitor::requestRefreshCallback):
(WebKit::ThreadedDisplayRefreshMonitor::displayRefreshCallback):

12:47 AM Changeset in webkit [220841] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/JavaScriptCore

Merge r220791 - Fix JSCOnly ARM buildbots after r220047 and r220184
​https://bugs.webkit.org/show_bug.cgi?id=174993

Reviewed by Carlos Alberto Lopez Perez.

• CMakeLists.txt: Generate only one backend on Linux to save build time.

12:45 AM Changeset in webkit [220840] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220786 - [GTK][WPE] WebKitAutomationSession should set session client to nullptr on dispose
​https://bugs.webkit.org/show_bug.cgi?id=175564

Reviewed by Carlos Alberto Lopez Perez.

WebAutomationSession expects its client to be nullptr in the destructor.

• UIProcess/API/glib/WebKitAutomationSession.cpp:

(webkitAutomationSessionDispose):

12:43 AM Changeset in webkit [220839] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.18/Source/JavaScriptCore

Merge r220777 - Make VM::scratchBufferForSize thread safe
​https://bugs.webkit.org/show_bug.cgi?id=175604

Reviewed by Geoffrey Garen and Mark Lam.

I want to use the VM::scratchBufferForSize in another patch I'm writing.
The use case for my other patch is to call it from the compiler thread.
When reading the code, I saw that this API was not thread safe. This patch
makes it thread safe. It actually turns out we were calling this API from
the compiler thread already when we created FTL::State for an FTL OSR entry
compilation, and from FTLLowerDFGToB3. That code was racy and wrong, but
is now correct with this patch.

• runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::~VM):
(JSC::VM::gatherConservativeRoots):
(JSC::VM::scratchBufferForSize):

• runtime/VM.h:

(JSC::VM::scratchBufferForSize): Deleted.

12:19 AM Changeset in webkit [220838] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18

Merge r220750 - REGRESSION(r220052): http/tests/appcache/deferred-events-delete-while-raising-timer.html is crashing.
​https://bugs.webkit.org/show_bug.cgi?id=175107

Reviewed by Alexey Proskuryakov.

Source/WebCore:

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadComplete): Moved the assertion to after the null page check.

LayoutTests:

• TestExpectations: Removed the flakiness expectation for this test.

12:18 AM Changeset in webkit [220837] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18/LayoutTests

Merge r220747 - Unreviewed GTK test gardening

• TestExpectations:
• platform/gtk/TestExpectations:
• platform/gtk/fast/events/input-events-paste-rich-datatransfer-expected.txt:
• platform/gtk/imported/w3c/web-platform-tests/eventsource/format-field-id-2-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/eventsource/format-field-id-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/eventsource/format-mime-bogus-expected.txt: Added.
• platform/ios/TestExpectations:
• platform/mac/TestExpectations:

12:07 AM Changeset in webkit [220836] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18/Source/WebKit

Merge r220741 - WebDriver: timeout when JavaScript alert is shown in onload handler
​https://bugs.webkit.org/show_bug.cgi?id=175315
<rdar://problem/33788294>

Reviewed by Brian Burg.

When a JavaScript alert is shown in an onload handler, the alert prevents the load from finishing in case of
normal page load strategy, so navigation commands or any other command for which we wait for navigation to
complete end up timing out. There are two selenium tests covering this that are currently timing out:
testShouldHandleAlertOnPageLoad and testShouldHandleAlertOnPageLoadUsingGet. The spec says that in case of page
load timeout we should only fail with timeout error when there isn't an active alert dialog. If the next command
expects an alert it will just work, otherwise it will fail with UnexpectedAlertOpen error when trying to handle
user prompts.

9 Navigation.
​https://w3c.github.io/webdriver/webdriver-spec.html#dfn-wait-for-navigation-to-complete

• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::waitForNavigationToComplete): Do not wait for the timeout when the page is
loading and there's an active alert in case of normal page load strategy.
(WebKit::WebAutomationSession::respondToPendingPageNavigationCallbacksWithTimeout): Respond with timeout unless
the page is showing a JavaScript dialog.
(WebKit::WebAutomationSession::respondToPendingFrameNavigationCallbacksWithTimeout): Ditto.
(WebKit::WebAutomationSession::loadTimerFired): Use respondToPendingPageNavigationCallbacksWithTimeout() and
respondToPendingFrameNavigationCallbacksWithTimeout().
(WebKit::WebAutomationSession::willShowJavaScriptDialog): The page is about to show a JavaScript dialog, so
we wait until the next run loop iteration to give time for the client to show the dialog, then check if page is
loading and the dialog is still present. If that's the case we finish all normal strategy pending navigations.

• UIProcess/Automation/WebAutomationSession.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runJavaScriptAlert): If controlled by automation, notify the session.
(WebKit::WebPageProxy::runJavaScriptConfirm): Ditto.
(WebKit::WebPageProxy::runJavaScriptPrompt): Ditto.
(WebKit::WebPageProxy::runBeforeUnloadConfirmPanel): Ditto.

12:06 AM Changeset in webkit [220835] by Carlos Garcia Campos

• 16 edits in releases/WebKitGTK/webkit-2.18/Source

Merge r220740 - WebDriver: handle click events on option elements
​https://bugs.webkit.org/show_bug.cgi?id=174710
<rdar://problem/33459305>

Reviewed by Brian Burg.

Source/WebCore:

Export WebCore symbols required by WebKit layer.

• html/HTMLOptGroupElement.h:
• html/HTMLOptionElement.h:

Source/WebDriver:

Option elements are considered as a special case by the specification. When clicking an option element, we
should get its container and use it when scrolling into view and calculating in-view center point instead of the
option element itself. Then, we should not emulate a click, but change the selected status of the option element
like if it were done by a user action, firing the corresponding events. Now we check whether the element is an
option to call selectOptionElement() or performMouseInteraction().

This fixes more than 20 selenium tests.

• CommandResult.cpp:

(WebDriver::CommandResult::CommandResult): Handle ElementNotSelectable protocol error.
(WebDriver::CommandResult::httpStatusCode const): Add ElementNotSelectable.
(WebDriver::CommandResult::errorString const): Ditto.

• CommandResult.h:
• Session.cpp:

(WebDriver::Session::selectOptionElement): Ask automation to select the given option element.
(WebDriver::Session::elementClick): Call selectOptionElement() or performMouseInteraction() depending on whether
the element is an option or not.

• Session.h:

Source/WebKit:

Add selectOptionElement method to automation to select an option element according to the WebDriver
specification.

14.1 Element Click.
​https://w3c.github.io/webdriver/webdriver-spec.html#element-click

• UIProcess/Automation/Automation.json: Add selectOptionElement method and ElementNotSelectable error.
• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::selectOptionElement):Send SelectOptionElement message to the web process.
(WebKit::WebAutomationSession::didSelectOptionElement): Notify the driver.

• UIProcess/Automation/WebAutomationSession.h:
• UIProcess/Automation/WebAutomationSession.messages.in: Add DidSelectOptionElement message.
• WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::elementContainer): Helper to get the container of an element according to the spec.
(WebKit::WebAutomationSessionProxy::computeElementLayout): Use the container element to scroll the view and
compute the in-view center point.
(WebKit::WebAutomationSessionProxy::selectOptionElement): Use HTMLSelectElement::optionSelectedByUser().

• WebProcess/Automation/WebAutomationSessionProxy.h:
• WebProcess/Automation/WebAutomationSessionProxy.messages.in: Add SelectOptionElement message.

12:04 AM Changeset in webkit [220834] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Gardening: build fix for ARM_TRADITIONAL after r220807.
​https://bugs.webkit.org/show_bug.cgi?id=175617

Not reviewed.

• assembler/MacroAssemblerARM.cpp:

12:02 AM Changeset in webkit [220833] by Carlos Garcia Campos

• 26 edits
  2 copies in releases/WebKitGTK/webkit-2.18

Merge r220731 - XHR should only fire an abort event if the cancellation was requested by the client
​https://bugs.webkit.org/show_bug.cgi?id=175546

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline several WPT tests now that a different error is sometimes used and that
more checks are passing.

• web-platform-tests/XMLHttpRequest/open-url-multi-window-4-expected.txt:
• web-platform-tests/XMLHttpRequest/send-network-error-sync-events.sub-expected.txt:
• web-platform-tests/cors/allow-headers-expected.txt:
• web-platform-tests/cors/origin-expected.txt:
• web-platform-tests/cors/request-headers-expected.txt:
• web-platform-tests/cors/response-headers-expected.txt:
• web-platform-tests/resource-timing/resource_TAO_match_origin-expected.txt:
• web-platform-tests/resource-timing/resource_TAO_match_wildcard-expected.txt:
• web-platform-tests/resource-timing/resource_TAO_multi-expected.txt:
• web-platform-tests/resource-timing/resource_TAO_null-expected.txt:
• web-platform-tests/resource-timing/resource_TAO_origin-expected.txt:
• web-platform-tests/resource-timing/resource_TAO_origin_uppercase-expected.txt:
• web-platform-tests/resource-timing/resource_TAO_space-expected.txt:
• web-platform-tests/resource-timing/resource_TAO_wildcard-expected.txt:
• web-platform-tests/resource-timing/resource_TAO_zero-expected.txt:

Source/WebCore:

XHR should only fire an abort event if the cancellation was requested by the client, otherwise it should fire an error event.
Blink and Gecko already match the specification.

Specification:

• ​https://xhr.spec.whatwg.org/#handle-errors
• ​https://xhr.spec.whatwg.org/#the-abort()-method

Test: http/tests/navigation/page-cache-xhr-in-pagehide.html

• xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::open):
(WebCore::XMLHttpRequest::abort):
(WebCore::XMLHttpRequest::abortError):
(WebCore::XMLHttpRequest::didFail):

• xml/XMLHttpRequest.h:

LayoutTests:

• http/tests/navigation/page-cache-xhr-expected.txt:
• http/tests/navigation/page-cache-xhr-in-pagehide-expected.txt: Copied from LayoutTests/http/tests/navigation/page-cache-xhr-expected.txt.
• http/tests/navigation/page-cache-xhr-in-pagehide.html: Copied from LayoutTests/http/tests/navigation/page-cache-xhr.html.
• http/tests/navigation/page-cache-xhr.html:

When an XHR is pending and navigating away, we would send an abort event before the navigation and an error event after
restoring from PageCache. This bug was not seen before because the test only checked for error events, not abort ones.
The expected behavior is now that we fire an error event before navigating away, similar to the non-PageCache case.
The only case where the error event should be fired after restoring from PageCache is when an XHR is done in the pagehide
event handler, because it is too late to send the error event to the page before navigating in this case. I added test
coverage for this case.

• http/tests/xmlhttprequest/navigation-should-abort-expected.txt:
• http/tests/xmlhttprequest/navigation-should-abort.html:

This test was expecting an abort event on navigation which is against spec. This test was failing in Blink too.
Update the test to expect an error event instead.

Aug 16, 2017:

11:58 PM Changeset in webkit [220832] by Carlos Garcia Campos

• 33 edits
  35 deletes in releases/WebKitGTK/webkit-2.18

Merge r220734 - Remove Proximity Events and related code
​https://bugs.webkit.org/show_bug.cgi?id=175545

Reviewed by Daniel Bates.

No platform enables Proximity Events, so remove code inside ENABLE(PROXIMITY_EVENTS)
and other related code.

.:

• Source/cmake/OptionsMac.cmake:
• Source/cmake/OptionsWin.cmake:
• Source/cmake/WebKitFeatures.cmake:
• Source/cmake/tools/vsprops/FeatureDefines.props:
• Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

• CMakeLists.txt:
• Configurations/FeatureDefines.xcconfig:
• DerivedSources.cpp:
• Modules/proximity/DeviceProximityClient.h: Removed.
• Modules/proximity/DeviceProximityController.cpp: Removed.
• Modules/proximity/DeviceProximityController.h: Removed.
• Modules/proximity/DeviceProximityEvent.cpp: Removed.
• Modules/proximity/DeviceProximityEvent.h: Removed.
• Modules/proximity/DeviceProximityEvent.idl: Removed.
• dom/EventNames.h:
• dom/EventNames.in:
• history/PageCache.cpp:

(WebCore::canCachePage):

• page/DOMWindow.cpp:

(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::removeEventListener):
(WebCore::DOMWindow::removeAllEventListeners):

• page/DOMWindow.idl:
• page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::deviceProximityKey): Deleted.

• page/DiagnosticLoggingKeys.h:
• testing/Internals.cpp:

(WebCore::Internals::setDeviceProximity): Deleted.

• testing/Internals.h:
• testing/Internals.idl:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebInspectorUI:

• UserInterface/Models/ScriptTimelineRecord.js:

(WI.ScriptTimelineRecord.EventType.displayName):

Source/WebKit:

• CMakeLists.txt:
• Configurations/FeatureDefines.xcconfig:
• WebProcess/WebCoreSupport/WebDeviceProximityClient.cpp: Removed.
• WebProcess/WebCoreSupport/WebDeviceProximityClient.h: Removed.
• WebProcess/WebPage/WebPage.cpp:

(WebKit::m_cpuLimit):

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

• wtf/FeatureDefines.h:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

• fast/events/constructors/device-proximity-event-constructor-expected.txt: Removed.
• fast/events/constructors/device-proximity-event-constructor.html: Removed.
• platform/gtk/TestExpectations:
• platform/ios/TestExpectations:
• platform/mac/TestExpectations:
• platform/win/TestExpectations:
• proximity/add-listener-from-callback-expected.txt: Removed.
• proximity/add-listener-from-callback.html: Removed.
• proximity/basic-operation-expected.txt: Removed.
• proximity/basic-operation.html: Removed.
• proximity/check-event-deviceproximity-expected.txt: Removed.
• proximity/check-event-deviceproximity.html: Removed.
• proximity/create-event-deviceproximity-expected.txt: Removed.
• proximity/create-event-deviceproximity.html: Removed.
• proximity/create-event-expected.txt: Removed.
• proximity/create-event.html: Removed.
• proximity/event-after-navigation-expected.txt: Removed.
• proximity/event-after-navigation.html: Removed.
• proximity/multiple-frames-expected.txt: Removed.
• proximity/multiple-frames.html: Removed.
• proximity/no-page-cache-expected.txt: Removed.
• proximity/no-page-cache.html: Removed.
• proximity/optional-event-properties-expected.txt: Removed.
• proximity/optional-event-properties.html: Removed.
• proximity/resources/cached-page-1.html: Removed.
• proximity/resources/cached-page-2.html: Removed.
• proximity/resources/event-after-navigation-new.html: Removed.
• proximity/updates-expected.txt: Removed.
• proximity/updates.html: Removed.
• proximity/window-property-expected.txt: Removed.
• proximity/window-property.html: Removed.

11:58 PM Changeset in webkit [220831] by Carlos Garcia Campos

• 21 edits
  6 deletes in releases/WebKitGTK/webkit-2.18

Merge r220732 - Remove ENABLE(REQUEST_AUTOCOMPLETE) code, which was disabled everywhere
​https://bugs.webkit.org/show_bug.cgi?id=175504

Reviewed by Sam Weinig.
Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

REQUEST_AUTOCOMPLETE was added in r133396 then removed in r148731, but brought back in r173596,
however no further work was done, and it was left disabled. So remove the code.

• Configurations/FeatureDefines.xcconfig:
• DerivedSources.make:
• WebCore.xcodeproj/project.pbxproj:
• dom/AutocompleteErrorEvent.h: Removed.
• dom/AutocompleteErrorEvent.idl: Removed.
• dom/EventNames.in:
• dom/GlobalEventHandlers.idl:
• html/HTMLFormElement.cpp:

(WebCore::HTMLFormElement::HTMLFormElement):
(WebCore::HTMLFormElement::requestAutocomplete): Deleted.
(WebCore::HTMLFormElement::finishRequestAutocomplete): Deleted.
(WebCore::HTMLFormElement::requestAutocompleteTimerFired): Deleted.

• html/HTMLFormElement.h:
• html/HTMLFormElement.idl:
• loader/EmptyClients.cpp:
• loader/FrameLoaderClient.h:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:
• WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::didRequestAutocomplete): Deleted.

• WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:
• DOM/DOMHTMLFormElement.mm:

(-[DOMHTMLFormElement requestAutocomplete]): Deleted.

• WebCoreSupport/WebFrameLoaderClient.h:

Source/WTF:

• wtf/FeatureDefines.h:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

11:57 PM Changeset in webkit [220830] by Carlos Garcia Campos

• 29 edits
  12 deletes in releases/WebKitGTK/webkit-2.18

Merge r220730 - Remove ENABLE_VIEW_MODE_CSS_MEDIA and related code
​https://bugs.webkit.org/show_bug.cgi?id=175557

Reviewed by Jon Lee.
.:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

• Source/cmake/OptionsMac.cmake:
• Source/cmake/OptionsWPE.cmake:
• Source/cmake/OptionsWin.cmake:
• Source/cmake/WebKitFeatures.cmake:
• Source/cmake/tools/vsprops/FeatureDefines.props:
• Source/cmake/tools/vsprops/FeatureDefinesCairo.props:

Source/JavaScriptCore:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

• Configurations/FeatureDefines.xcconfig:
• css/CSSValueKeywords.in:
• css/MediaFeatureNames.h:
• css/MediaQueryEvaluator.cpp:

(WebCore::viewModeEvaluate): Deleted.

• css/MediaQueryExpression.cpp:

(WebCore::featureWithValidIdent):
(WebCore::isFeatureValidWithoutValue):

• page/Page.cpp:

(WebCore::Page::stringToViewMode): Deleted.
(WebCore::Page::setViewMode): Deleted.

• page/Page.h:

(WebCore::Page::viewMode const): Deleted.

Source/WebCore/PAL:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

• Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

• wtf/FeatureDefines.h:

Tools:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

• DumpRenderTree/TestRunner.cpp:

(TestRunner::staticFunctions):
(setViewModeMediaFeatureCallback): Deleted.

• DumpRenderTree/TestRunner.h:
• DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setViewModeMediaFeature): Deleted.

• DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setViewModeMediaFeature): Deleted.

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

LayoutTests:

No port cares about the ENABLE(VIEW_MODE_CSS_MEDIA) feature, so remove it.

• fast/media/media-query-list-02-expected.txt: Removed.
• fast/media/media-query-list-02.html: Removed.
• fast/media/media-query-list-03-expected.txt: Removed.
• fast/media/media-query-list-03.html: Removed.
• fast/media/media-query-list-04-expected.txt: Removed.
• fast/media/media-query-list-04.html: Removed.
• fast/media/media-query-list-05-expected.txt: Removed.
• fast/media/media-query-list-05.html: Removed.
• fast/media/media-query-list-06-expected.txt: Removed.
• fast/media/media-query-list-06.html: Removed.
• fast/media/view-mode-media-feature-expected.html: Removed.
• fast/media/view-mode-media-feature.html: Removed.
• platform/gtk/TestExpectations:
• platform/ios-wk2/TestExpectations:
• platform/ios/TestExpectations:
• platform/mac/TestExpectations:
• platform/win/TestExpectations:

11:17 PM Changeset in webkit [220829] by rniwa@webkit.org

• 9 edits
  2 adds in trunk

Add the support for mutating clipboard data via DataTransferItemList
​https://bugs.webkit.org/show_bug.cgi?id=175639

Reviewed by Wenson Hsieh.

Source/WebCore:

Added the support for adding plaintext data via dataTransfer.items.add, clearing data via clear,
and removing an entry via remove. When DataTransferItem is removed from DataTransferItemList,
we must put into the disabled mode.

To support the removal of DataTransferItem, this patch replaces a reference to DataTransfer by
a WeakPtr to DataTransferItemList, and stops forwarding ref from DataTransferItem to DataTransfer.
This means that DataTransfer can now be GC'ed before DataTransferItem is GC'ed.

Because the identify and the order of DataTransferItems need to be preserved, we can't simply
re-popluate m_itemList in DataTransferItemList. Instead, whenever the clipboard content is mutated,
we make the parallel modifications to m_itemList. This includes changes made via DataTransfer
methods such as setData and clearData.

Test: editing/pasteboard/datatransfer-items-copy-plaintext.html

• dom/DataTransfer.cpp:

(WebCore::DataTransfer::clearData): Invoke didClearStringData when m_itemList exists.
(WebCore::DataTransfer::setData): Ditto.
(WebCore::DataTransfer::createForInputEvent):
(WebCore::DataTransfer::createForDrag):
(WebCore::DataTransfer::createForDrop):

• dom/DataTransferItem.cpp:

(WebCore::DataTransferItem::create):
(WebCore::DataTransferItem::DataTransferItem):
(WebCore::DataTransferItem::clearListAndPutIntoDisabledMode): Added.
(WebCore::DataTransferItem::type const): Moved from the header.
(WebCore::DataTransferItem::getAsString const):
(WebCore::DataTransferItem::getAsFile const):

• dom/DataTransferItem.h:

(WebCore::DataTransferItem::ref): Deleted.
(WebCore::DataTransferItem::deref): Deleted.
(WebCore::DataTransferItem::isFile const): Added.
(WebCore::DataTransferItem::type const): Move to the cpp file.

• dom/DataTransferItemList.cpp:

(WebCore::isSupportedType): Moved.
(WebCore::DataTransferItemList::DataTransferItemList): Moved from the header.
(WebCore::DataTransferItemList::~DataTransferItemList): Added.
(WebCore::DataTransferItemList::item):
(WebCore::DataTransferItemList::add): Implemented the variant to add string data.
(WebCore::DataTransferItemList::remove): Implemented. For now, we don't have to deal with removing
a file since a writable dataTransfer never contains a File object.
(WebCore::DataTransferItemList::clear): Implemented.
(WebCore::DataTransferItemList::ensureItems const):
(WebCore::removeStringItemOfLowercasedType): Added.
(WebCore::DataTransferItemList::didClearStringData): Called when dataTransfer.clear is called.
(WebCore::DataTransferItemList::didSetStringData): Ditto for

• dom/DataTransferItemList.h:

(WebCore::DataTransferItemList): Added a WeakPtrFactory. Also use a vector of Ref<DataTransferItem>
instead of unique_ptr<DataTransferItem> since DataTransferItem can outlive DataTransferItemList.
(WebCore::DataTransferItemList::dataTransfer): Added.

• dom/DataTransferItemList.idl:

LayoutTests:

Rebaselined the IDL test which now passes all test cases, and added a regression test for mutating clipboard data
via dataTransfer.items and methods on dataTransfer for plaintext.

• editing/pasteboard/datatransfer-idl-expected.txt:
• editing/pasteboard/datatransfer-items-copy-plaintext-expected.txt: Added.
• editing/pasteboard/datatransfer-items-copy-plaintext.html: Added.

11:11 PM Changeset in webkit [220828] by Carlos Garcia Campos

• 4 edits
  2 adds in releases/WebKitGTK/webkit-2.18

Merge r220717 - The none smooth stroke applied to an SVG shape breaks its hit testing
​https://bugs.webkit.org/show_bug.cgi?id=175506

Patch by Said Abou-Hallawa <​sabouhallawa@apple.com> on 2017-08-14
Reviewed by Simon Fraser.

Source/WebCore:

Clear RenderSVGShape::m_path when calling RenderSVGRect::updateShapeFromElement().
The m_path will be recalculated when RenderSVGShape::updateShapeFromElement()
is called from RenderSVGRect::shapeDependentStrokeContains().

Test: svg/stroke/stroke-linejoin-click.html

• rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::updateShapeFromElement):

• rendering/svg/RenderSVGShape.h:

(WebCore::RenderSVGShape::clearPath):

LayoutTests:

• svg/stroke/stroke-linejoin-click-expected.html: Added.
• svg/stroke/stroke-linejoin-click.html: Added.

11:08 PM Changeset in webkit [220827] by Carlos Garcia Campos

• 2 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220522 - Unreviewed GTK+ build fix for ENABLE_GLES2=ON.

• platform/graphics/texmap/TextureMapperGLHeaders.h:

Define various GL constants that are not provided in GLES2 headers
but are only leveraged in OpenGL calls if at runtime the underlying
OpenGL is GLES2-capable.

11:08 PM Changeset in webkit [220826] by Carlos Garcia Campos

• 4 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220521 - [TexMap] Remove GraphicsContext3D usage from BitmapTexturePool
​https://bugs.webkit.org/show_bug.cgi?id=175319

Reviewed by Carlos Garcia Campos.

Drop the GraphicsContext3D reference in BitmapTexturePool now
that the BitmapTextureGL doesn't require it anymore.

No new tests -- no change in behavior.

• platform/graphics/texmap/BitmapTexturePool.cpp:

(WebCore::BitmapTexturePool::BitmapTexturePool):

• platform/graphics/texmap/BitmapTexturePool.h:
• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::TextureMapperGL):

11:08 PM Changeset in webkit [220825] by Carlos Garcia Campos

• 3 edits in releases/WebKitGTK/webkit-2.18

Merge r220699 - REGRESSION(r220517-r220521) [GTK] Various compositing tests fail
​https://bugs.webkit.org/show_bug.cgi?id=175478

Reviewed by Sergio Villar Senin.

Source/WebCore:

Fix a regression introduced in r220519. Move a framebuffer binding in TextureMapperGL
away from GraphicsContext3D and onto the OpenGL API to work around the framebuffer
binding state that's kept in the GraphicsContext3D class. This mismatch in how the
framebuffer was bound was causing a couple of test failures in compositing tests.

No new tests -- regressed tests have their failure expectations removed.

• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::bindDefaultSurface): Don't use GraphicsContext3D for the
glBindFramebuffer() call. This would be done in subsequent patches that would move
TextureMapperGL off the GraphicsContext3D usage, but this specific use case clashes
with the framebuffer binding that's done in BitmapTextureGL and was causing test
failures.

LayoutTests:

• platform/gtk/TestExpectations: Remove failure and flakiness expectations.

11:08 PM Changeset in webkit [220824] by Carlos Garcia Campos

• 6 edits in releases/WebKitGTK/webkit-2.18/Source/WebCore

Merge r220519 - [TexMap] Drop GraphicsContext3D usage from BitmapTextureGL
​https://bugs.webkit.org/show_bug.cgi?id=175317

Reviewed by Carlos Garcia Campos.

Have BitmapTextureGL use direct OpenGL API entrypoints and constants
instead of leveraging the GraphicsContext3D class. Any GraphicsContext3D
object passed to BitmapTextureGL would assume rendering to the GL context
that's current on that thread, translating method invocations to the
OpenGL API. We can do this by ourselves and benefit by avoiding allocating
GraphicsContext3D resources like the ANGLE compiler that are by most useful
for WebGL.

BitmapTextureGL::create() call sites are adjusted to stop passing a
GraphicsContext3D reference. BitmapTextureGL::bindAsSurface() doesn't need
a replacement for the passed-in GraphicsContext3D object since that object
originated from the TextureMapperGL instance, whose GraphicsContext3D is by
default of the render-to-current-context nature. Other changes are direct
translations of GraphicsContext3D methods to OpenGL API calls, or of
GraphicsContext3D values to OpenGL API constants.

No new tests -- no change in behavior.

• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):

• platform/graphics/texmap/BitmapTextureGL.cpp:

Also remove an unnecessary GraphicsContext.h header inclusion.
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContentsNoSwizzle):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::initializeStencil):
(WebCore::BitmapTextureGL::initializeDepthBuffer):
(WebCore::BitmapTextureGL::clearIfNeeded):
(WebCore::BitmapTextureGL::createFboIfNeeded):
(WebCore::BitmapTextureGL::bindAsSurface):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::BitmapTextureGL::copyFromExternalTexture):

• platform/graphics/texmap/BitmapTextureGL.h:

(WebCore::BitmapTextureGL::create):
(WebCore::BitmapTextureGL::textureTarget const):
(WebCore::BitmapTextureGL::internalFormat const):

• platform/graphics/texmap/BitmapTexturePool.cpp:

(WebCore::BitmapTexturePool::createTexture):

• platform/graphics/texmap/TextureMapperGL.cpp:

(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapperGL::createTexture):

10:09 PM Changeset in webkit [220823] by mark.lam@apple.com

• 16 edits in trunk/Source

Add back the ability to disable MASM_PROBE from the build.
​https://bugs.webkit.org/show_bug.cgi?id=175656
<rdar://problem/33933720>

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

This is needed for ports that the existing MASM_PROBE implementation doesn't work
well with e.g. GTK with ARM_THUMB2. Note that if the DFG_JIT will be disabled by
default if !ENABLE(MASM_PROBE).

• assembler/AbstractMacroAssembler.h:
• assembler/MacroAssembler.cpp:
• assembler/MacroAssembler.h:
• assembler/MacroAssemblerARM.cpp:
• assembler/MacroAssemblerARM64.cpp:
• assembler/MacroAssemblerARMv7.cpp:
• assembler/MacroAssemblerPrinter.cpp:
• assembler/MacroAssemblerPrinter.h:
• assembler/MacroAssemblerX86Common.cpp:
• assembler/testmasm.cpp:

(JSC::run):

• b3/B3LowerToAir.cpp:
• b3/air/AirPrintSpecial.cpp:
• b3/air/AirPrintSpecial.h:

Source/WTF:

• wtf/Platform.h:

8:32 PM Changeset in webkit [220822] by mitz@apple.com

• 2 edits in trunk/Source/JavaScriptCore

[Cocoa] Older-iOS install name symbols are being exported on other platforms
​https://bugs.webkit.org/show_bug.cgi?id=175654

Reviewed by Tim Horton.

• API/JSBase.cpp: Define the symbols only when targeting iOS.

6:24 PM Changeset in webkit [220821] by aestes@apple.com

• 33 edits
  2 moves in trunk/Source

[Apple Pay] Rename PaymentRequest to ApplePaySessionPaymentRequest
​https://bugs.webkit.org/show_bug.cgi?id=175648

Reviewed by Tim Horton.

Source/WebCore:

The W3C Payment Request API defines an interface called PaymentRequest, which conflicts with
an existing Apple Pay class. This patch renames PaymentRequest to
ApplePaySessionPaymentRequest so that a follow-on patch can introduce PaymentRequest for the
W3C API.

• Modules/applepay/ApplePayError.h:
• Modules/applepay/ApplePayLineItem.h:
• Modules/applepay/ApplePayPaymentRequest.h:
• Modules/applepay/ApplePaySession.cpp:

(WebCore::convertAndValidateTotal):
(WebCore::convertAndValidate):
(WebCore::ApplePaySession::ApplePaySession):
(WebCore::ApplePaySession::didSelectShippingMethod):

• Modules/applepay/ApplePaySession.h:
• Modules/applepay/ApplePaySessionPaymentRequest.cpp: Renamed from Source/WebCore/Modules/applepay/PaymentRequest.cpp.

(WebCore::ApplePaySessionPaymentRequest::ApplePaySessionPaymentRequest):
(WebCore::ApplePaySessionPaymentRequest::~ApplePaySessionPaymentRequest):
(WebCore::ApplePaySessionPaymentRequest::isValidSupportedNetwork):

• Modules/applepay/ApplePaySessionPaymentRequest.h: Renamed from Source/WebCore/Modules/applepay/PaymentRequest.h.
• Modules/applepay/ApplePayShippingMethodSelectedEvent.cpp:

(WebCore::convert):
(WebCore::ApplePayShippingMethodSelectedEvent::ApplePayShippingMethodSelectedEvent):

• Modules/applepay/ApplePayShippingMethodSelectedEvent.h:
• Modules/applepay/PaymentCoordinator.cpp:

(WebCore::PaymentCoordinator::beginPaymentSession):
(WebCore::PaymentCoordinator::didSelectShippingMethod):

• Modules/applepay/PaymentCoordinator.h:
• Modules/applepay/PaymentCoordinatorClient.h:
• Modules/applepay/PaymentHeaders.h:
• Modules/applepay/PaymentRequestValidator.cpp:

(WebCore::PaymentRequestValidator::validate):
(WebCore::PaymentRequestValidator::validateTotal):
(WebCore::validateMerchantCapabilities):
(WebCore::validateShippingMethod):
(WebCore::validateShippingMethods):

• Modules/applepay/PaymentRequestValidator.h:
• WebCore.xcodeproj/project.pbxproj:
• loader/EmptyClients.cpp:

Source/WebKit:

• Scripts/webkit/messages.py:

(headers_for_type):

• Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<ApplePaySessionPaymentRequest>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::ContactFields>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::ContactFields>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::LineItem>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::LineItem>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::MerchantCapabilities>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::MerchantCapabilities>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::ShippingMethod>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::ShippingMethod>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::TotalAndLineItems>::encode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::TotalAndLineItems>::decode):
(IPC::ArgumentCoder<PaymentRequest>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest>::decode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::ContactFields>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::ContactFields>::decode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::LineItem>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::LineItem>::decode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::MerchantCapabilities>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::MerchantCapabilities>::decode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::ShippingMethod>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::ShippingMethod>::decode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::TotalAndLineItems>::encode): Deleted.
(IPC::ArgumentCoder<PaymentRequest::TotalAndLineItems>::decode): Deleted.

• Shared/WebCoreArgumentCoders.h:
• UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp:

(WebKit::WebPaymentCoordinatorProxy::showPaymentUI):
(WebKit::WebPaymentCoordinatorProxy::didSelectShippingMethod):

• UIProcess/ApplePay/WebPaymentCoordinatorProxy.h:
• UIProcess/ApplePay/WebPaymentCoordinatorProxy.messages.in:
• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:
• UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(toShippingMethod):
(WebKit::toPKContactFields):
(WebKit::toPKAddressField):
(WebKit::toPKPaymentSummaryItemType):
(WebKit::toPKPaymentSummaryItem):
(WebKit::toPKPaymentSummaryItems):
(WebKit::toPKMerchantCapabilities):
(WebKit::toPKShippingType):
(WebKit::toPKShippingMethod):
(WebKit::toPKPaymentRequest):

• UIProcess/ApplePay/ios/WebPaymentCoordinatorProxyIOS.mm:

(WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI):

• UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:

(WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI):

• WebProcess/ApplePay/WebPaymentCoordinator.cpp:

(WebKit::WebPaymentCoordinator::showPaymentUI):
(WebKit::WebPaymentCoordinator::didSelectShippingMethod):

• WebProcess/ApplePay/WebPaymentCoordinator.h:
• WebProcess/ApplePay/WebPaymentCoordinator.messages.in:

Source/WebKitLegacy/mac:

• WebCoreSupport/WebPaymentCoordinatorClient.h:
• WebCoreSupport/WebPaymentCoordinatorClient.mm:

(WebPaymentCoordinatorClient::showPaymentUI):

5:45 PM Changeset in webkit [220820] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark fullscreen/full-screen-iframe-legacy.html as flaky on Sierra WK1.
​https://bugs.webkit.org/show_bug.cgi?id=175554

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

5:43 PM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro

(diff)

5:40 PM Changeset in webkit [220819] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Correct a typo in a test name.

Unreviewed test gardening.

• platform/mac/TestExpectations:

5:33 PM Changeset in webkit [220818] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Rebaseline crypto/subtle/rsa-generate-key-malformed-parameters.html after r220811.

Unreviewed test gardening.

• platform/ios-11/crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt:

5:28 PM Changeset in webkit [220817] by Chris Dumez

• 31 edits
  1 move
  1 add
  3 deletes in trunk

Cross origin Beacon requests with a ArrayBuffer / ArrayBufferView payload should not do a CORS preflight
​https://bugs.webkit.org/show_bug.cgi?id=175628
<rdar://problem/33919278>

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

Rebaseline a few web-platform-tests due to revert of r220779.

• web-platform-tests/beacon/headers/header-content-type-expected.txt:
• web-platform-tests/fetch/api/basic/request-headers.any-expected.txt:
• web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt:

Source/WebCore:

Cross origin Beacon requests with a ArrayBuffer / ArrayBufferView payload should not do a CORS preflight.
To achieve this, the following changes were made:

1. Revert r220779 which caused us to use a non CORS-safelisted Content-Type header for such payload
2. Teach PingLoad how to deal with "simple" cross origin requests (i.e. Don't assume we need a CORS preflight merely because the fetch mode is set to "cors").

Test: http/wpt/beacon/cors/crossorigin-arraybufferview-no-preflight.html

• Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::extract):

• loader/CrossOriginAccessControl.h:
• loader/LoaderStrategy.h:
• loader/PingLoader.cpp:

(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::startPingLoad):

• loader/PingLoader.h:
• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::load):

• loader/cache/CachedResource.h:
• loader/cache/CachedResourceRequest.cpp:

(WebCore::CachedResourceRequest::CachedResourceRequest):

• loader/cache/CachedResourceRequest.h:

(WebCore::CachedResourceRequest::releaseOriginalRequestHeaders):

• platform/network/HTTPHeaderValues.cpp:
• platform/network/HTTPHeaderValues.h:

Source/WebKit:

Cross origin Beacon requests with a ArrayBuffer / ArrayBufferView payload should not do a CORS preflight.
To achieve this, the following changes were made:

1. Revert r220779 which caused us to use a non CORS-safelisted Content-Type header for such payload
2. Teach PingLoad how to deal with "simple" cross origin requests (i.e. Don't assume we need a CORS preflight merely because the fetch mode is set to "cors").

• NetworkProcess/NetworkCORSPreflightChecker.cpp:

(WebKit::NetworkCORSPreflightChecker::startPreflight):

• NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):

• NetworkProcess/NetworkResourceLoadParameters.h:
• NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::loadRequest):
(WebKit::PingLoad::originalRequestHeaders const):
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::isAllowedRedirect const):
(WebKit::PingLoad::makeCrossOriginAccessRequest):
(WebKit::PingLoad::makeSimpleCrossOriginAccessRequest):
(WebKit::PingLoad::makeCrossOriginAccessRequestWithPreflight):
(WebKit::PingLoad::preflightSuccess):

• NetworkProcess/PingLoad.h:
• WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::createPingHandle):

• WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

• WebCoreSupport/WebResourceLoadScheduler.cpp:

(WebResourceLoadScheduler::createPingHandle):

• WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

• http/tests/blink/sendbeacon/beacon-same-origin-expected.txt:
• http/wpt/fetch/fetch-request-arraybuffer-content-type-expected.txt:
• http/wpt/fetch/fetch-request-arraybuffer-content-type.html:

Rebaseline test due to revert of r220779.

• http/wpt/beacon/cors/cors-preflight-arraybufferview-failure-expected.txt: Removed.
• http/wpt/beacon/cors/cors-preflight-arraybufferview-failure.html: Removed.

Drop outdated test. CORS preflight failure is still covered by the corresponding Blob payload test.

• http/wpt/beacon/cors/cors-preflight-arraybufferview-success-expected.txt: Removed.
• http/wpt/beacon/cors/cors-preflight-arraybufferview-success.html: Removed.
• http/wpt/beacon/cors/crossorigin-arraybufferview-no-preflight-expected.txt: Added.
• http/wpt/beacon/cors/crossorigin-arraybufferview-no-preflight.html: Added.

Rename and update test so that it checks that we no longer do a CORS preflight for cross origin
beacons that have an ArrayBuffer payload.

4:29 PM Changeset in webkit [220816] by mark.lam@apple.com

• 2 edits in trunk/Source/WTF

Gardening: fix GTK ARM_THUMB2 build.
​https://bugs.webkit.org/show_bug.cgi?id=175446

Not reviewed.

Disable the use of the DFG for GTK ARM_THUMB2 builds until
​https://bugs.webkit.org/show_bug.cgi?id=175514 is fixed.

• wtf/Platform.h:

4:15 PM Changeset in webkit [220815] by Matt Baker

• 12 edits
  1 add in trunk

Web Inspector: capture async stack trace when workers/main context posts a message
​https://bugs.webkit.org/show_bug.cgi?id=167084
<rdar://problem/30033673>

Reviewed by Brian Burg.

Source/JavaScriptCore:

• inspector/agents/InspectorDebuggerAgent.h:

Add PostMessage async call type.

Source/WebCore:

Add instrumentation to DOMWindow to support showing asynchronous
stack traces when the debugger pauses in a MessageEvent handler.

Test: inspector/debugger/async-stack-trace.html

• inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didPostMessageImpl):
(WebCore::InspectorInstrumentation::didFailPostMessageImpl):
(WebCore::InspectorInstrumentation::willDispatchPostMessageImpl):
(WebCore::InspectorInstrumentation::didDispatchPostMessageImpl):

• inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didPostMessage):
(WebCore::InspectorInstrumentation::didFailPostMessage):
(WebCore::InspectorInstrumentation::willDispatchPostMessage):
(WebCore::InspectorInstrumentation::didDispatchPostMessage):

• inspector/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::didClearAsyncStackTraceData):
(WebCore::PageDebuggerAgent::didPostMessage):
(WebCore::PageDebuggerAgent::didFailPostMessage):
(WebCore::PageDebuggerAgent::willDispatchPostMessage):
(WebCore::PageDebuggerAgent::didDispatchPostMessage):

• inspector/PageDebuggerAgent.h:

• page/DOMWindow.cpp:

(WebCore::DOMWindow::postMessage):
(WebCore::DOMWindow::postMessageTimerFired):

LayoutTests:

Add a test to check for asynchronous stack trace data when the debugger
pauses inside a MessageEvent handler.

• inspector/debugger/async-stack-trace-expected.txt:
• inspector/debugger/async-stack-trace.html:
• inspector/debugger/resources/postMessage-echo.html: Added.

4:00 PM Changeset in webkit [220814] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebCore

Try to fix the build

• platform/ios/PlatformPasteboardIOS.mm:

3:58 PM Changeset in webkit [220813] by Simon Fraser

• 2 edits in trunk/Source/WebCore

Build fix after r220812

Fix builds where LOG_DISABLED is defined.

• css/MediaQueryEvaluator.cpp:

3:12 PM Changeset in webkit [220812] by Simon Fraser

• 20 edits in trunk/Source/WebCore

Add a log channel for media queries
​https://bugs.webkit.org/show_bug.cgi?id=175591

Reviewed by Zalan Bujtas.

Add a "MediaQueries" log channel which logs data about media query evaluation.

• css/MediaList.cpp:

(WebCore::MediaQuerySet::MediaQuerySet):
(WebCore::operator<<):

• css/MediaList.h:
• css/MediaQuery.cpp:

(WebCore::operator<<):

• css/MediaQuery.h:
• css/MediaQueryEvaluator.cpp:

(WebCore::operator<<):
(WebCore::MediaQueryEvaluator::evaluate const):
(WebCore::aspectRatioValueAsString):
(WebCore::orientationEvaluate):
(WebCore::aspectRatioEvaluate):
(WebCore::deviceAspectRatioEvaluate):
(WebCore::evaluateResolution):
(WebCore::deviceHeightEvaluate):
(WebCore::deviceWidthEvaluate):
(WebCore::heightEvaluate):
(WebCore::widthEvaluate):

• css/MediaQueryExpression.cpp:

(WebCore::operator<<):

• css/MediaQueryExpression.h:
• css/MediaQueryMatcher.cpp:

(WebCore::MediaQueryMatcher::styleResolverChanged):

• css/StyleResolver.cpp:

(WebCore::StyleResolver::hasMediaQueriesAffectedByViewportChange const):
(WebCore::StyleResolver::hasMediaQueriesAffectedByAccessibilitySettingsChange const):

• dom/InlineStyleSheetOwner.cpp:

(WebCore::InlineStyleSheetOwner::createSheet):

• html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::bestFitSourceFromPictureElement):

• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::selectNextSourceChild):

• html/HTMLPictureElement.cpp:

(WebCore::HTMLPictureElement::viewportChangeAffectedPicture const):

• html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):

• page/FrameView.cpp:

(WebCore::FrameView::layout):

• platform/Logging.cpp:

(WebCore::initializeLogChannelsIfNecessary):

• platform/Logging.h:
• platform/URL.cpp:

(WebCore::isSchemeFirstChar):
(WebCore::operator<<):

• platform/URL.h:

3:11 PM Changeset in webkit [220811] by commit-queue@webkit.org

• 62 edits
  1 copy
  1 delete in trunk

[WebIDL] Remove the need for JSSubtleCryptoCustom.cpp
​https://bugs.webkit.org/show_bug.cgi?id=175526

Patch by Sam Weinig <​sam@webkit.org> on 2017-08-16
Reviewed by Chris Dumez.

Source/WebCore:

• Generates bindings for all of SubtleCrypto except AlgorithmIdentifier normalization, which is defined in the WebCrypto spec to happen after normal IDL operations.
• Adds initial support for IDL object types in unions (some, unneeded at the moment, edge cases remain).

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• bindings/js/JSSubtleCryptoCustom.cpp: Removed.

Remove JSSubtleCryptoCustom.cpp, added CryptoKeyFormat.h

• bindings/js/JSDOMConvertObject.h:

Add needed, when included in generated code, #include of StrongInlines.h

• bindings/js/JSDOMConvertUnion.h:

Add initial support for object (needed for AlgorithmIdentifier which is
(object or DOMString)). Remaining support will be handled by ​https://webkit.org/b/175616

Also add remaining spec comments while in the area.

• bindings/js/JSDOMPromiseDeferred.cpp:

(WebCore::DeferredPromise::reject):

Add support for the special ExistingExceptionError error code. Capturing
the current exception and using it as the rejection value.

• crypto/SubtleCrypto.cpp:

(WebCore::SubtleCrypto::~SubtleCrypto):
(WebCore::toHashIdentifier):
(WebCore::normalizeCryptoAlgorithmParameters):
(WebCore::toCryptoKeyUsageBitmap):
(WebCore::rejectWithException):
(WebCore::normalizeJsonWebKey):
(WebCore::toKeyData):
(WebCore::copyToVector):
(WebCore::isSupportedExportKey):
(WebCore::SubtleCrypto::encrypt):
(WebCore::SubtleCrypto::decrypt):
(WebCore::SubtleCrypto::sign):
(WebCore::SubtleCrypto::verify):
(WebCore::SubtleCrypto::digest):
(WebCore::SubtleCrypto::generateKey):
(WebCore::SubtleCrypto::deriveKey):
(WebCore::SubtleCrypto::deriveBits):
(WebCore::SubtleCrypto::importKey):
(WebCore::SubtleCrypto::exportKey):
(WebCore::SubtleCrypto::wrapKey):
(WebCore::SubtleCrypto::unwrapKey):

• crypto/SubtleCrypto.h:
• crypto/SubtleCrypto.idl:

Moves implementation from JSSubtleCryptoCustom.cpp -> here. Important changes that come
with that are:

• All parameters are now converted / type checked for us.
• Rather than throwing exceptions and expecting the bindings layer to convert them to promise rejections, all rejections are now explicitly made.
• Algorithms are no longer checked for being supported twice, once in normalizeCryptoAlgorithmParameters and then again in the operation. We instead rely on normalizeCryptoAlgorithmParameters to return an Exception if its not supported.
• Shaves 251 lines off the file.

• crypto/CryptoKeyFormat.h: Added.

Add new header for unified key format enum. (For bindings purposes, SubtleCrypto
re aliases it to SubtleCrypto::KeyFormat).

• bindings/js/JSWebKitSubtleCryptoCustom.cpp:
• crypto/CryptoAlgorithm.cpp:
• crypto/CryptoAlgorithm.h:
• crypto/algorithms/CryptoAlgorithmAES_CBC.cpp:
• crypto/algorithms/CryptoAlgorithmAES_CBC.h:
• crypto/algorithms/CryptoAlgorithmAES_CFB.cpp:
• crypto/algorithms/CryptoAlgorithmAES_CFB.h:
• crypto/algorithms/CryptoAlgorithmAES_CTR.cpp:
• crypto/algorithms/CryptoAlgorithmAES_CTR.h:
• crypto/algorithms/CryptoAlgorithmAES_GCM.cpp:
• crypto/algorithms/CryptoAlgorithmAES_GCM.h:
• crypto/algorithms/CryptoAlgorithmAES_KW.cpp:
• crypto/algorithms/CryptoAlgorithmAES_KW.h:
• crypto/algorithms/CryptoAlgorithmECDH.cpp:
• crypto/algorithms/CryptoAlgorithmECDH.h:
• crypto/algorithms/CryptoAlgorithmECDSA.cpp:
• crypto/algorithms/CryptoAlgorithmECDSA.h:
• crypto/algorithms/CryptoAlgorithmHKDF.cpp:
• crypto/algorithms/CryptoAlgorithmHKDF.h:
• crypto/algorithms/CryptoAlgorithmHMAC.cpp:
• crypto/algorithms/CryptoAlgorithmHMAC.h:
• crypto/algorithms/CryptoAlgorithmPBKDF2.cpp:
• crypto/algorithms/CryptoAlgorithmPBKDF2.h:
• crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.cpp:
• crypto/algorithms/CryptoAlgorithmRSAES_PKCS1_v1_5.h:
• crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.cpp:
• crypto/algorithms/CryptoAlgorithmRSASSA_PKCS1_v1_5.h:
• crypto/algorithms/CryptoAlgorithmRSA_OAEP.cpp:
• crypto/algorithms/CryptoAlgorithmRSA_OAEP.h:
• crypto/algorithms/CryptoAlgorithmRSA_PSS.cpp:
• crypto/algorithms/CryptoAlgorithmRSA_PSS.h:

Use CryptoKeyFormat enum directly, rather than SubtleCrypto::KeyFormat,
to allow not including SubtleCrypto.h.

• crypto/parameters/CryptoAlgorithmEcdsaParams.h:
• crypto/parameters/CryptoAlgorithmHkdfParams.h:
• crypto/parameters/CryptoAlgorithmHmacKeyParams.h:
• crypto/parameters/CryptoAlgorithmPbkdf2Params.h:
• crypto/parameters/CryptoAlgorithmRsaHashedImportParams.h:
• crypto/parameters/CryptoAlgorithmRsaHashedKeyGenParams.h:
• crypto/parameters/EcdsaParams.idl:
• crypto/parameters/HkdfParams.idl:
• crypto/parameters/HmacKeyParams.idl:
• crypto/parameters/Pbkdf2Params.idl:
• crypto/parameters/RsaHashedImportParams.idl:
• crypto/parameters/RsaHashedKeyGenParams.idl:

Update IDLs and implementations to use the correct definition of HashAlgorithmIdentifier,
which is (object or DOMString), now that it is supported.

LayoutTests:

• crypto/subtle/encrypt-malformed-parameters-expected.txt:
• crypto/subtle/export-key-malformed-parameters-expected.txt:
• crypto/subtle/generate-key-malformed-parameters-expected.txt:
• crypto/subtle/hkdf-derive-bits-malformed-parametrs-expected.txt:
• crypto/subtle/hmac-generate-key-malformed-parameters-expected.txt:
• crypto/subtle/import-key-malformed-parameters-expected.txt:
• crypto/subtle/pbkdf2-derive-bits-malformed-parametrs-expected.txt:
• crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt:
• platform/mac-highsierra/crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt:

Update expectations with improved error messages.

3:09 PM Changeset in webkit [220810] by commit-queue@webkit.org

• 10 edits
  1 copy
  1 add in trunk/Source/WebCore

[Cache API] Implement Worker connection to the Cache storage engine
​https://bugs.webkit.org/show_bug.cgi?id=175599

Patch by Youenn Fablet <​youenn@apple.com> on 2017-08-16
Reviewed by Chris Dumez.

Covered by existing tests.

Adding a WorkerCacheStorageConnection to connect workers Cache/CacheStorage
to the cache storage engine.
WorkerCacheStorageConnection does this by hopping to the main thread to call the document cache storage connection to do the actual job.
Doing some CacheStorageConnection refactoring to share code with WK2 implementation of the cache storage connection.

• Modules/cache/CacheQueryOptions.h:

(WebCore::CacheQueryOptions::isolatedCopy const):

• Modules/cache/CacheStorageConnection.cpp:

(WebCore::CacheStorageConnection::open):
(WebCore::CacheStorageConnection::remove):
(WebCore::CacheStorageConnection::retrieveCaches):
(WebCore::CacheStorageConnection::retrieveRecords):
(WebCore::CacheStorageConnection::batchDeleteOperation):
(WebCore::CacheStorageConnection::batchPutOperation):
(WebCore::CacheStorageConnection::openOrRemoveCompleted):
(WebCore::CacheStorageConnection::updateCaches):
(WebCore::CacheStorageConnection::updateRecords):
(WebCore::CacheStorageConnection::removeRecordsCompleted):
(WebCore::CacheStorageConnection::putRecordsCompleted):

• Modules/cache/CacheStorageConnection.h:

(WebCore::CacheStorageConnection::openCompleted):
(WebCore::CacheStorageConnection::removeCompleted):
(WebCore::CacheStorageConnection::doOpen):
(WebCore::CacheStorageConnection::doRemove):
(WebCore::CacheStorageConnection::doRetrieveCaches):
(WebCore::CacheStorageConnection::doRetrieveRecords):
(WebCore::CacheStorageConnection::doBatchDeleteOperation):
(WebCore::CacheStorageConnection::doBatchPutOperation):

• Modules/cache/WorkerCacheStorageConnection.cpp: Added.

(WebCore::toCrossThreadRecordData):
(WebCore::fromCrossThreadRecordData):
(WebCore::WorkerCacheStorageConnection::create):
(WebCore::WorkerCacheStorageConnection::WorkerCacheStorageConnection):
(WebCore::WorkerCacheStorageConnection::doOpen):
(WebCore::WorkerCacheStorageConnection::doRemove):
(WebCore::WorkerCacheStorageConnection::doRetrieveCaches):
(WebCore::WorkerCacheStorageConnection::doRetrieveRecords):
(WebCore::WorkerCacheStorageConnection::doBatchDeleteOperation):
(WebCore::WorkerCacheStorageConnection::doBatchPutOperation):

• Modules/cache/WorkerCacheStorageConnection.h: Added.
• Modules/cache/WorkerGlobalScopeCaches.cpp:

(WebCore::WorkerGlobalScopeCaches::caches const):

• WebCore.xcodeproj/project.pbxproj:
• loader/FetchOptions.h:

(WebCore::FetchOptions::isolatedCopy const):

• workers/WorkerGlobalScope.cpp:

(WebCore::WorkerGlobalScope::cacheStorageConnection):

• workers/WorkerGlobalScope.h:

2:42 PM Changeset in webkit [220809] by commit-queue@webkit.org

• 43 edits
  11 copies
  2 adds
  2 deletes in trunk

[PAL] Move spi/ios and spi/win directories into PAL
​https://bugs.webkit.org/show_bug.cgi?id=175171

Patch by Yoshiaki Jitsukawa <​Yoshiaki.Jitsukawa@sony.com> on 2017-08-16
Reviewed by Antti Koivisto.

Source/WebCore:

• PlatformWin.cmake:
• WebCore.xcodeproj/project.pbxproj:
• editing/cocoa/DataDetection.mm:
• loader/ios/PreviewLoader.mm:
• page/CaptionUserPreferencesMediaAF.cpp:
• page/cocoa/MemoryReleaseCocoa.mm:
• page/cocoa/SettingsCocoa.mm:
• page/ios/UserAgentIOS.mm:
• platform/audio/ios/MediaSessionManagerIOS.mm:
• platform/graphics/ca/PlatformCALayer.cpp:
• platform/graphics/cocoa/FontCascadeCocoa.mm:
• platform/graphics/cocoa/GraphicsContext3DCocoa.mm:
• platform/graphics/opentype/OpenTypeCG.h:
• platform/graphics/win/SimpleFontDataCGWin.cpp:
• platform/graphics/win/SimpleFontDataDirect2D.cpp:
• platform/ios/Device.h:
• platform/ios/PlatformPasteboardIOS.mm:
• platform/ios/PlatformScreenIOS.mm:
• platform/ios/QuickLookSoftLink.h:
• platform/ios/QuickLookSoftLink.mm:
• platform/ios/ValidationBubbleIOS.mm:
• platform/ios/WebItemProviderPasteboard.mm:
• platform/network/ios/PreviewConverter.mm:
• platform/sql/SQLiteFileSystem.cpp:
• rendering/RenderThemeIOS.mm:

Source/WebCore/PAL:

• PAL.xcodeproj/project.pbxproj:
• pal/spi/ios/CoreUISPI.h: Renamed from Source/WebCore/platform/spi/ios/CoreUISPI.h.
• pal/spi/ios/DataDetectorsUISPI.h: Renamed from Source/WebCore/platform/spi/ios/DataDetectorsUISPI.h.
• pal/spi/ios/GraphicsServicesSPI.h: Renamed from Source/WebCore/platform/spi/ios/GraphicsServicesSPI.h.
• pal/spi/ios/LaunchServicesSPI.h: Renamed from Source/WebCore/platform/spi/ios/LaunchServicesSPI.h.
• pal/spi/ios/MediaPlayerSPI.h: Renamed from Source/WebCore/platform/spi/ios/MediaPlayerSPI.h.
• pal/spi/ios/MobileGestaltSPI.h: Renamed from Source/WebCore/platform/spi/ios/MobileGestaltSPI.h.
• pal/spi/ios/OpenGLESSPI.h: Renamed from Source/WebCore/platform/spi/ios/OpenGLESSPI.h.
• pal/spi/ios/QuickLookSPI.h: Renamed from Source/WebCore/platform/spi/ios/QuickLookSPI.h.
• pal/spi/ios/SQLite3SPI.h: Renamed from Source/WebCore/platform/spi/ios/SQLite3SPI.h.
• pal/spi/ios/UIKitSPI.h: Renamed from Source/WebCore/platform/spi/ios/UIKitSPI.h.
• pal/spi/win/CoreTextSPIWin.h: Renamed from Source/WebCore/platform/spi/win/CoreTextSPIWin.h.

Source/WebKit:

• UIProcess/Cocoa/NavigationState.mm:
• UIProcess/ios/WKActionSheetAssistant.h:
• UIProcess/ios/WKActionSheetAssistant.mm:
• UIProcess/ios/WKContentViewInteraction.mm:
• UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
• WebProcess/EntryPoint/mac/XPCService/WebContentServiceEntryPoint.mm:
• WebProcess/cocoa/WebProcessCocoa.mm:

Source/WebKitLegacy:

• Storage/StorageTracker.cpp:

Source/WebKitLegacy/mac:

• WebCoreSupport/WebFrameLoaderClient.mm:
• WebView/WebView.mm:

Tools:

• DumpRenderTree/mac/EventSendingController.mm:

1:49 PM Changeset in webkit [220808] by timothy_horton@apple.com

• 16 edits in trunk/Source/WebCore

2-3% of main thread time under UTTypeCreatePreferredIdentifierForTag on wunderground map
​https://bugs.webkit.org/show_bug.cgi?id=175618

Reviewed by Simon Fraser.

No new tests, just a perf win.

UTTypeCreatePreferredIdentifierForTag is fairly expensive, and is called
under every toDataURL, which the Wunderground wundermap does a /lot/.

Keep a 16-item LRU cache of MIMEType->UTI mappings.

Also, make other callers of UTTypeCreatePreferredIdentifierForTag use
the UTIUtilities version so they can share in the caching.

Also, as a drive-by, add and make other callers use mimeTypeFromUTI too,
and make the UTIUtilities operate on Strings for a slightly more WebCore-y feel.

• editing/ios/EditorIOS.mm:

(WebCore::Editor::WebContentReader::readImage):

• platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):

• platform/graphics/mac/MediaPlayerPrivateQTKit.mm:

(WebCore::createFileTypesSet):

• platform/graphics/cg/ImageSourceCGMac.mm:

(WebCore::MIMETypeForImageSourceType):
Adopt newly-added MIMETypeFromUTI().

• platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::utiFromImageBufferMIMEType):
(WebCore::ImageBuffer::toCFData const):
(WebCore::cfData):
(WebCore::utiFromMIMEType): Deleted.
Adopt UTIFromMIMEType, and rename the local helper that does something
different (a small static map) on iOS and Windows to not have an overlapping name.

• platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::resourceMIMEType):
(WebCore::utiTypeFromCocoaType):
Adopt UTIFromMIMEType().

• platform/ios/PlatformPasteboardIOS.mm:

(WebCore::PlatformPasteboard::writeObjectRepresentations):

• platform/mac/PasteboardMac.mm:

(WebCore::cocoaTypeFromHTMLClipboardType):
Adopt isDeclaredUTI and UTIFromMIMEType().

• platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::WebCoreAVFResourceLoader::responseReceived):

• platform/network/ios/WebCoreURLResponseIOS.mm:

(WebCore::adjustMIMETypeIfNecessary):

• platform/network/mac/WebCoreURLResponse.mm:

(WebCore::adjustMIMETypeIfNecessary):

• rendering/RenderThemeIOS.mm:

(WebCore::iconForAttachment):

• rendering/RenderThemeMac.mm:

(WebCore::iconForAttachment):
Deal with the fact that UTI utilities deal in Strings now.

• platform/network/mac/UTIUtilities.h:
• platform/network/mac/UTIUtilities.mm:

(WebCore::MIMETypeFromUTI):
Added. This doesn't crawl up the UTI tree if the first conversion fails,
which is what most of the existing code does. It's possible we want to
use MIMETypeFromUTITree's logic everywhere, but I didn't want to change
that in this patch.

(WebCore::MIMETypeFromUTITree):
(WebCore::isDeclaredUTI):
Take and return strings.

(WebCore::UTIFromMIMETypeCachePolicy::createValueForKey):
(WebCore::UTIFromMIMEType):
Add the aforementioned cache.

1:38 PM Changeset in webkit [220807] by mark.lam@apple.com

• 7 edits in trunk/Source/JavaScriptCore

Enhance MacroAssembler::probe() to support an initializeStackFunction callback.
​https://bugs.webkit.org/show_bug.cgi?id=175617
<rdar://problem/33912104>

Reviewed by JF Bastien.

This patch adds a new feature to MacroAssembler::probe() where the probe function
can provide a ProbeFunction callback to fill in stack values after the stack
pointer has been adjusted. The probe function can use this feature as follows:

1. Set the new sp value in the ProbeContext's CPUState.

2. Set the ProbeContext's initializeStackFunction to a ProbeFunction callback which will do the work of filling in the stack values after the probe trampoline has adjusted the machine stack pointer.

3. Set the ProbeContext's initializeStackArgs to any value that the client wants to pass to the initializeStackFunction callback.

4. Return from the probe function.

Upon returning from the probe function, the probe trampoline will adjust the
the stack pointer based on the sp value in CPUState. If initializeStackFunction
is not set, the probe trampoline will restore registers and return to its caller.

If initializeStackFunction is set, the trampoline will move the ProbeContext
beyond the range of the stack pointer i.e. it will place the new ProbeContext at
an address lower than where CPUState.sp() points. This ensures that the
ProbeContext will not be trashed by the initializeStackFunction when it writes to
the stack. Then, the trampoline will call back to the initializeStackFunction
ProbeFunction to let it fill in the stack values as desired. The
initializeStackFunction ProbeFunction will be passed the moved ProbeContext at
the new location.

initializeStackFunction may now write to the stack at addresses greater or
equal to CPUState.sp(), but not below that. initializeStackFunction is also
not allowed to change CPUState.sp(). If the initializeStackFunction does not
abide by these rules, then behavior is undefined, and bad things may happen.

For future reference, some implementation details that this patch needed to
be mindful of:

1. When the probe trampoline allocates stack space for the ProbeContext, it should include OUT_SIZE as well. This ensures that it doesn't have to move the ProbeContext on exit if the probe function didn't change the sp.

2. If the trampoline has to move the ProbeContext, it needs to point the machine sp to new ProbeContext first before copying over the ProbeContext data. This protects the new ProbeContext from possibly being trashed by interrupts.

3. When computing the new address of ProbeContext to move to, we need to make sure that it is properly aligned in accordance with stack ABI requirements (just like we did when we allocated the ProbeContext on entry to the probe trampoline).

4. When copying the ProbeContext to its new location, the trampoline should always copy words from low addresses to high addresses. This is because if we're moving the ProbeContext, we'll always be moving it to a lower address.

• assembler/MacroAssembler.h:
• assembler/MacroAssemblerARM.cpp:
• assembler/MacroAssemblerARM64.cpp:
• assembler/MacroAssemblerARMv7.cpp:
• assembler/MacroAssemblerX86Common.cpp:
• assembler/testmasm.cpp:

(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::fillStack):
(JSC::testProbeModifiesStackWithCallback):
(JSC::run):

1:30 PM Changeset in webkit [220806] by Simon Fraser

• 9 edits in trunk/Source/WebCore

Make RenderLayer and RenderLayerBacking TextStream-loggable, and clean up compositing logging
​https://bugs.webkit.org/show_bug.cgi?id=175634

Reviewed by Zalan Bujtas.

Add operator<<(TextStream&) for RenderLayer and RenderLayer backing, and use them for compositing logging.

Convert CompositingUpdateType to an enum class.

• page/FrameView.cpp:

(WebCore::FrameView::updateCompositingLayersAfterLayout):
(WebCore::FrameView::updateCompositingLayersAfterScrolling):

• page/ios/FrameIOS.mm:

(WebCore::Frame::viewportOffsetChanged):

• rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositionsAfterLayout):
(WebCore::RenderLayer::updateCompositingLayersAfterScroll):
(WebCore::RenderLayer::calculateClipRects const):

• rendering/RenderLayer.h:
• rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateAfterLayout):
(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::operator<<):

• rendering/RenderLayerBacking.h:
• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::didRecalcStyleWithNoPendingLayout):
(WebCore::RenderLayerCompositor::flushPendingLayerChanges):
(WebCore::RenderLayerCompositor::updateCompositingLayersTimerFired):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::layerTreeAsText):
(WebCore::operator<<):

• rendering/RenderLayerCompositor.h:

1:20 PM Changeset in webkit [220805] by eric.carlson@apple.com

• 5 edits
  4 adds in trunk

Consider allow gUM to be called from localhost without https
​https://bugs.webkit.org/show_bug.cgi?id=173457
<rdar://problem/33900527>

Reviewed by Youenn Fablet.

Source/WebCore:

Tests: http/tests/media/media-stream/get-user-media-localhost.html

http/tests/media/media-stream/get-user-media-loopback-ip.html

• Modules/mediastream/UserMediaRequest.cpp:

(WebCore::isSecure): Call SchemeRegistry::shouldTreatURLSchemeAsSecure instead of looking for
the string 'https'.
(WebCore::canCallGetUserMedia): Allow localhost or loopback address.

• page/SecurityOrigin.cpp:

(WebCore::isLoopbackIPAddress): Add a comment.
(WebCore::shouldTreatAsPotentionallyTrustworthy): Move tests for localhost and loopback address
to isLocalHostOrLoopbackIPAddress, call it.
(WebCore::SecurityOrigin::isLocalHostOrLoopbackIPAddress):

• page/SecurityOrigin.h:

LayoutTests:

• http/tests/media/media-stream/get-user-media-localhost-expected.txt: Added.
• http/tests/media/media-stream/get-user-media-localhost.html: Added.
• http/tests/media/media-stream/get-user-media-loopback-ip-expected.txt: Added.
• http/tests/media/media-stream/get-user-media-loopback-ip.html: Added.

1:19 PM Changeset in webkit [220804] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Skip workers/wasm-hashset-many.html and workers/wasm-hashset-many-2.html
​https://bugs.webkit.org/show_bug.cgi?id=175102

Unreviewed test gardening.

• platform/mac/TestExpectations:

12:53 PM WebKitGTK/2.18.x edited by Michael Catanzaro

Propose r220797 (diff)

12:42 PM Changeset in webkit [220803] by jmarcell@apple.com

• 7 edits in trunk/Source

Versioning.

12:36 PM Changeset in webkit [220802] by jmarcell@apple.com

• 1 copy in tags/Safari-605.1.3

Tag Safari-605.1.3.

12:17 PM Changeset in webkit [220801] by commit-queue@webkit.org

• 9 edits
  7 adds in trunk/PerformanceTests

Speedometer: Update Angular 1 TodoMVC example to v1.6.5
​https://bugs.webkit.org/show_bug.cgi?id=175623

Patch by Mathias Bynens <​mathias@qiwi.be> on 2017-08-16
Reviewed by Ryosuke Niwa.

• Speedometer/resources/todomvc/architecture-examples/angularjs/index.html: Made title consistent.
• Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular-resource/angular-resource.min.js: Added.
• Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular-resource/angular-resource.min.js.map: Added.
• Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular-route/angular-route.min.js: Added.
• Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular-route/angular-route.min.js.map: Added.
• Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular/angular.min.js: Added.
• Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/angular/angular.min.js.map: Added.
• Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-app-css/package.json: Updated per build steps.
• Speedometer/resources/todomvc/architecture-examples/angularjs/node_modules/todomvc-common/package.json: Updated per build steps.
• Speedometer/resources/todomvc/architecture-examples/angularjs/package-lock.json: Added to pin dependencies.
• Speedometer/resources/todomvc/architecture-examples/angularjs/package.json: Updated per build steps.
• Speedometer/resources/todomvc/architecture-examples/angularjs/readme.md: Document the build process.

11:59 AM Changeset in webkit [220800] by commit-queue@webkit.org

• 5 edits
  7 adds in trunk/PerformanceTests

Speedometer: Document Backbone example
​https://bugs.webkit.org/show_bug.cgi?id=175626

Patch by Mathias Bynens <​mathias@qiwi.be> on 2017-08-16
Reviewed by Ryosuke Niwa.

• Speedometer/resources/todomvc/architecture-examples/backbone/index.html: Made title consistent.
• Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/backbone/backbone-min.js: Added.
• Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/backbone/backbone-min.map: Added.
• Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/jquery/dist/jquery.js: Updated per build steps.
• Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/jquery/dist/jquery.min.js: Added.
• Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/jquery/dist/jquery.min.map: Added.
• Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/todomvc-app-css/index.css: Updated per build steps.
• Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/underscore/underscore-min.js: Added.
• Speedometer/resources/todomvc/architecture-examples/backbone/node_modules/underscore/underscore-min.map: Added.
• Speedometer/resources/todomvc/architecture-examples/backbone/package-lock.json: Added.
• Speedometer/resources/todomvc/architecture-examples/backbone/readme.md: Documented build steps.

10:30 AM Changeset in webkit [220799] by Chris Dumez

• 5 edits
  2 adds in trunk

EventSource: ignore IDs with U+0000
​https://bugs.webkit.org/show_bug.cgi?id=175178

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

Import WPT test coverage from:

• ​https://github.com/w3c/web-platform-tests/pull/6584

• web-platform-tests/eventsource/format-field-id-null-expected.txt: Added.
• web-platform-tests/eventsource/format-field-id-null.htm: Added.
• web-platform-tests/eventsource/resources/last-event-id.py:

(main):

• web-platform-tests/eventsource/w3c-import.log:

Source/WebCore:

EventSource: ignore IDs with U+0000 as per:
​https://github.com/whatwg/html/pull/2849

Test: imported/w3c/web-platform-tests/eventsource/format-field-id-null.htm

• page/EventSource.cpp:

(WebCore::EventSource::parseEventStreamLine):

9:46 AM Changeset in webkit [220798] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Rebaseline js/dom/global-constructors-attributes.html.

Unreviewed test gardening.

• platform/mac-wk1/js/dom/global-constructors-attributes-expected.txt:

9:36 AM Changeset in webkit [220797] by commit-queue@webkit.org

• 3 edits
  2 adds in trunk

[HarfBuzz] Decomposed Vietnamese characters are rendered incorrectly
​https://bugs.webkit.org/show_bug.cgi?id=174418

Patch by Fujii Hironori <Fujii Hironori> on 2017-08-16
Reviewed by Michael Catanzaro.

Source/WebCore:

HarfBuzzShaper should normalize the input text before collecting
HarfBuzzRuns. Actually, HarfBuzzShaper::setNormalizedBuffer does
the task. But, this function hasn't been called from anywhere
since Bug 90951.

Test: fast/text/international/vietnamese-nfd.html

imported/blink/fast/text/international/text-shaping-arabic-diffs.html

• platform/graphics/harfbuzz/HarfBuzzShaper.cpp:

(WebCore::HarfBuzzShaper::HarfBuzzShaper):
Call setNormalizedBuffer instead of normalizeCharacters.
(WebCore::normalizeCharacters): Deleted.
(WebCore::normalizeSpacesAndMirrorChars) Use
FontCascade::treatAsZeroWidthSpaceInComplexScript instead of
FontCascade::treatAsZeroWidthSpace to preserve ZWJ and ZWNJ.

LayoutTests:

• fast/text/international/vietnamese-nfd-expected.html: Added.
• fast/text/international/vietnamese-nfd.html: Added.

9:08 AM WebKitGTK/2.18.x edited by Michael Catanzaro

Propose r220746 (diff)

8:43 AM Changeset in webkit [220796] by Chris Dumez

• 4 edits in trunk/LayoutTests

Unreviewed, rebaseline a few tests after r220779.

• http/tests/blink/sendbeacon/beacon-same-origin-expected.txt:
• http/wpt/beacon/cors/cors-preflight-arraybufferview-failure.html:
• http/wpt/beacon/cors/cors-preflight-arraybufferview-success.html:

6:15 AM Changeset in webkit [220795] by Antti Koivisto

• 14 edits
  2 adds in trunk/Source/WebCore

Move first-letter renderer mutation code out of RenderBlock and into RenderTreeUpdater
​https://bugs.webkit.org/show_bug.cgi?id=175627

Reviewed by Andreas Kling.

Render tree should not mutate itself. We already fixed this for first-letter, supporting code
can now move to RenderTreeUpdater too.

• CMakeLists.txt:
• WebCore.xcodeproj/project.pbxproj:
• rendering/RenderBlock.cpp:

(WebCore::styleForFirstLetter): Deleted.
(WebCore::isPunctuationForFirstLetter): Deleted.
(WebCore::shouldSkipForFirstLetter): Deleted.
(WebCore::RenderBlock::updateFirstLetterStyle): Deleted.
(WebCore::RenderBlock::createFirstLetterRenderer): Deleted.
(WebCore::RenderBlock::updateFirstLetter): Deleted.

• rendering/RenderBlock.h:
• rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::updateFirstLetter): Deleted.

• rendering/RenderRubyRun.h:
• rendering/RenderTable.cpp:

(WebCore::RenderTable::updateFirstLetter): Deleted.

• rendering/RenderTable.h:

Virtual overrides just disabled first letter for some RenderBlock subclasses. This is now achieved via
supportsFirstLetter test in the first letter updater.

• rendering/TextAutoSizing.cpp:

(WebCore::TextAutoSizingValue::adjustTextNodeSizes):

• rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::updateFirstLetter): Deleted.

• rendering/svg/RenderSVGText.h:
• style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::popParent):

• style/RenderTreeUpdater.h:
• style/RenderTreeUpdaterFirstLetter.cpp: Added.

(WebCore::styleForFirstLetter):
(WebCore::isPunctuationForFirstLetter):
(WebCore::shouldSkipForFirstLetter):
(WebCore::updateFirstLetterStyle):
(WebCore::createFirstLetterRenderer):
(WebCore::supportsFirstLetter):
(WebCore::RenderTreeUpdater::FirstLetter::update):

• style/RenderTreeUpdaterFirstLetter.h: Added.

4:38 AM Changeset in webkit [220794] by Carlos Garcia Campos

• 8 edits in trunk/Source/WebDriver

WebDriver: fix return value of close window command
​https://bugs.webkit.org/show_bug.cgi?id=174861

Reviewed by Brian Burg.

We are currently returning null, but we should return the list of window handles, and try to close the session
if there aren't more window handles.

10.2 Close Window
​https://w3c.github.io/webdriver/webdriver-spec.html#close-window

3. If there are no more open top-level browsing contexts, then try to close the session.
4. Return the result of running the remote end steps for the Get Window Handles command.

• Session.cpp:

(WebDriver::Session::closeAllToplevelBrowsingContexts): Helper function to close the given toplevel browsing
context and the next one if there are more.
(WebDriver::Session::close): Call closeAllToplevelBrowsingContexts() to delete all toplevel browsing contexts of
the session.
(WebDriver::Session::closeTopLevelBrowsingContext): Close the given toplevel browsing context and call
getWindowHandles() when done.
(WebDriver::Session::closeWindow): Call closeTopLevelBrowsingContext() passing the current toplevel browsing context.
(WebDriver::Session::getWindowHandles): Remove the early return, this command doesn't depend on a current
toplevel browsing context.

• Session.h:
• SessionHost.h:
• WebDriverService.cpp:

(WebDriver::WebDriverService::run): Disconnect the server when main loop quits.
(WebDriver::WebDriverService::deleteSession): Do not fail if the given session is not active.
(WebDriver::WebDriverService::closeWindow): Remove the session if the closed window was the last one.

• WebDriverService.h: Remove unused quit() method.
• glib/SessionHostGlib.cpp:

(WebDriver::SessionHost::isConnected): Return whether host is connected to a browser instance.
(WebDriver::SessionHost::dbusConnectionClosedCallback): Delete m_browser.

4:26 AM Changeset in webkit [220793] by magomez@igalia.com

• 2 edits in trunk/Source/WebKit

[GTK] Crash of WebProcess with on-demand AC
​https://bugs.webkit.org/show_bug.cgi?id=171161

Reviewed by Carlos Garcia Campos.

Set the viewOverlayRootLayer to the previous layerTreeHost if it exists. This avoids a
crash when reusing the previous layerTreeHost, because it would keep a reference to an
already destroyed viewOverlayRootLayer.

• WebProcess/WebPage/AcceleratedDrawingArea.cpp:

(WebKit::AcceleratedDrawingArea::attachViewOverlayGraphicsLayer):

4:21 AM Changeset in webkit [220792] by zandobersek@gmail.com

• 10 edits in trunk/Source/WebKit

[CoordGraphics] Simplify CoordinatedGraphicsScene state updates
​https://bugs.webkit.org/show_bug.cgi?id=175528
<rdar://problem/33876795>

Reviewed by Carlos Garcia Campos.

Hold the information about state updates in ThreadedCompositor, in the
m_attributes struct. This way we don't need to store the updates in
functors and accumulate them in the CoordinatedGraphicsScene class, but
instead just apply any pending state update or atlas removal before the
scene is rendered.

This removes the need to update the CoordinatedGraphicsScene object from
the main thread with data that ultimately has to be handled on the
composition thread. Similarly, when updating CoordinatedGraphicsScene, we
only need to synchronize on the m_attributes lock object once in order to
retrieve the scene update information, instead of having each functor do
that repeatedly.

Outside of CoordinatedGraphicsScene and ThreadedCompositor classes, the
CompositingCoordinator class now passes the atlases-to-remove Vector by
a const lvalue reference down to ThreadedCompositor, and then manually
clears the Vector. Before the Vector was passed as an rvalue reference,
depending on the ThreadedCompositor code to clear out the original Vector
object by moving its resources into the functor object. This doesn't occur
anymore because the Vector object is now appended to another Vector.

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:

(WebKit::CoordinatedGraphicsScene::applyStateChanges):
(WebKit::CoordinatedGraphicsScene::paintToCurrentGLContext):
(WebKit::CoordinatedGraphicsScene::detach):
(WebKit::CoordinatedGraphicsScene::setActive):
(WebKit::CoordinatedGraphicsScene::syncRemoteContent): Deleted.
(WebKit::CoordinatedGraphicsScene::appendUpdate): Deleted.

• Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:

(WebKit::ThreadedCompositor::renderLayerTree):
(WebKit::ThreadedCompositor::updateSceneState):
(WebKit::ThreadedCompositor::releaseUpdateAtlases):

• Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::flushPendingLayerChanges):
(WebKit::CompositingCoordinator::releaseAtlases):
(WebKit::CompositingCoordinator::clearUpdateAtlases):

• WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
• WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
• WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:

(WebKit::ThreadedCoordinatedLayerTreeHost::releaseUpdateAtlases):

• WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:

3:06 AM Changeset in webkit [220791] by Csaba Osztrogonác

• 2 edits in trunk/Source/JavaScriptCore

Fix JSCOnly ARM buildbots after r220047 and r220184
​https://bugs.webkit.org/show_bug.cgi?id=174993

Reviewed by Carlos Alberto Lopez Perez.

• CMakeLists.txt: Generate only one backend on Linux to save build time.

1:25 AM Changeset in webkit [220790] by calvaris@igalia.com

• 5 edits
  2 adds in trunk/Source/WebCore

[GStreamer][EME] Rework handling key systems and UUIDs
​https://bugs.webkit.org/show_bug.cgi?id=175567

Reviewed by Žan Doberšek.

The UUIDs and key system strings were moved to the
GStreamerEMEUtilities class because so far they were managed by
the decryptors and that was ugly.

• platform/GStreamer.cmake:
• platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::supportsKeySystem):

• platform/graphics/gstreamer/eme/GStreamerEMEUtilities.cpp: Added.
• platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h: Added.

(WebCore::GStreamerEMEUtilities::isClearKeyKeySystem):
(WebCore::GStreamerEMEUtilities::keySystemToUuid):

• platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.cpp:

(webkit_media_clear_key_decrypt_class_init):

• platform/graphics/gstreamer/eme/WebKitClearKeyDecryptorGStreamer.h:

12:49 AM Changeset in webkit [220789] by jmarcell@apple.com

• 3 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r220723. rdar://problem/33901127

12:49 AM Changeset in webkit [220788] by jmarcell@apple.com

• 12 edits in branches/safari-604-branch/Source/WebKit

Cherry-pick r220286. rdar://problem/33904738

12:34 AM Changeset in webkit [220787] by aestes@apple.com

• 20 edits in trunk

[Payment Request] Add an ENABLE flag and an experimental feature preference
​https://bugs.webkit.org/show_bug.cgi?id=175622

Reviewed by Tim Horton.

Source/JavaScriptCore:

• Configurations/FeatureDefines.xcconfig:

Source/WebCore:

• Configurations/FeatureDefines.xcconfig:
• page/Settings.in:

Source/WebCore/PAL:

• Configurations/FeatureDefines.xcconfig:

Source/WebKit:

• Configurations/FeatureDefines.xcconfig:
• Shared/WebPreferencesDefinitions.h:
• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetPaymentRequestEnabled):
(WKPreferencesGetPaymentRequestEnabled):

• UIProcess/API/C/WKPreferencesRefPrivate.h:
• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences):

Source/WebKitLegacy/mac:

• Configurations/FeatureDefines.xcconfig:

Source/WTF:

• wtf/FeatureDefines.h:

Tools:

• TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
• WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):

Aug 15, 2017:

11:09 PM Changeset in webkit [220786] by Carlos Garcia Campos

• 2 edits in trunk/Source/WebKit

[GTK][WPE] WebKitAutomationSession should set session client to nullptr on dispose
​https://bugs.webkit.org/show_bug.cgi?id=175564

Reviewed by Carlos Alberto Lopez Perez.

WebAutomationSession expects its client to be nullptr in the destructor.

• UIProcess/API/glib/WebKitAutomationSession.cpp:

(webkitAutomationSessionDispose):

8:52 PM Changeset in webkit [220785] by aestes@apple.com

• 5 edits
  53 adds in trunk/LayoutTests

[Payment Request] Import test suite from web-platform-tests
​https://bugs.webkit.org/show_bug.cgi?id=175612
<rdar://problem/33906070>

Reviewed by Tim Horton.

LayoutTests/imported/w3c:

Imported the payment-request test suite using import-w3c-tests. Generated failing expected
results for each test and skipped 5 tests that currently time out.

• resources/import-expectations.json:
• resources/resource-files.json:
• web-platform-tests/payment-request/OWNERS: Added.
• web-platform-tests/payment-request/allowpaymentrequest/active-document-cross-origin.https.sub-expected.txt: Added.
• web-platform-tests/payment-request/allowpaymentrequest/active-document-cross-origin.https.sub.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/active-document-same-origin.https-expected.txt: Added.
• web-platform-tests/payment-request/allowpaymentrequest/active-document-same-origin.https.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-cross-origin-bc-containers.https-expected.txt: Added.
• web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-cross-origin-bc-containers.https.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-same-origin-bc-containers.https-expected.txt: Added.
• web-platform-tests/payment-request/allowpaymentrequest/allowpaymentrequest-attribute-same-origin-bc-containers.https.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/basic.https-expected.txt: Added.
• web-platform-tests/payment-request/allowpaymentrequest/basic.https.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/common.sub.js: Added.

(window.onmessage):
(string_appeared_here.forEach):

• web-platform-tests/payment-request/allowpaymentrequest/echo-PaymentRequest.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/no-attribute-cross-origin-bc-containers.https-expected.txt: Added.
• web-platform-tests/payment-request/allowpaymentrequest/no-attribute-cross-origin-bc-containers.https.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/no-attribute-same-origin-bc-containers.https-expected.txt: Added.
• web-platform-tests/payment-request/allowpaymentrequest/no-attribute-same-origin-bc-containers.https.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/removing-allowpaymentrequest.https.sub-expected.txt: Added.
• web-platform-tests/payment-request/allowpaymentrequest/removing-allowpaymentrequest.https.sub.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub-expected.txt: Added.
• web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest-timing.https.sub.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest.https.sub-expected.txt: Added.
• web-platform-tests/payment-request/allowpaymentrequest/setting-allowpaymentrequest.https.sub.html: Added.
• web-platform-tests/payment-request/allowpaymentrequest/w3c-import.log: Added.
• web-platform-tests/payment-request/historical.https-expected.txt: Added.
• web-platform-tests/payment-request/historical.https.html: Added.
• web-platform-tests/payment-request/interfaces.https-expected.txt: Added.
• web-platform-tests/payment-request/interfaces.https.html: Added.
• web-platform-tests/payment-request/payment-request-abort-method.https-expected.txt: Added.
• web-platform-tests/payment-request/payment-request-abort-method.https.html: Added.
• web-platform-tests/payment-request/payment-request-canmakepayment-method.https.http: Added.
• web-platform-tests/payment-request/payment-request-constructor-crash.https-expected.txt: Added.
• web-platform-tests/payment-request/payment-request-constructor-crash.https.html: Added.
• web-platform-tests/payment-request/payment-request-constructor.https-expected.txt: Added.
• web-platform-tests/payment-request/payment-request-constructor.https.html: Added.
• web-platform-tests/payment-request/payment-request-id.https-expected.txt: Added.
• web-platform-tests/payment-request/payment-request-id.https.html: Added.
• web-platform-tests/payment-request/payment-request-in-iframe-expected.txt: Added.
• web-platform-tests/payment-request/payment-request-in-iframe.html: Added.
• web-platform-tests/payment-request/payment-request-onshippingaddresschange-attribute.https-expected.txt: Added.
• web-platform-tests/payment-request/payment-request-onshippingaddresschange-attribute.https.html: Added.
• web-platform-tests/payment-request/payment-request-onshippingoptionchange-attribute.https-expected.txt: Added.
• web-platform-tests/payment-request/payment-request-onshippingoptionchange-attribute.https.html: Added.
• web-platform-tests/payment-request/payment-request-response-id.html: Added.
• web-platform-tests/payment-request/payment-request-show-method.https-expected.txt: Added.
• web-platform-tests/payment-request/payment-request-show-method.https.html: Added.
• web-platform-tests/payment-request/payment-request-update-event-constructor.http-expected.txt: Added.
• web-platform-tests/payment-request/payment-request-update-event-constructor.http.html: Added.
• web-platform-tests/payment-request/payment-request-update-event-constructor.https-expected.txt: Added.
• web-platform-tests/payment-request/payment-request-update-event-constructor.https.html: Added.
• web-platform-tests/payment-request/w3c-import.log: Added.

LayoutTests:

• TestExpectations: Skipped payment-request tests that currently time out.

8:06 PM Changeset in webkit [220784] by timothy_horton@apple.com

• 2 edits in trunk/Source/WebKit

WKSnapshotConfiguration is missing from the WebKit umbrella header
​https://bugs.webkit.org/show_bug.cgi?id=175614
<rdar://problem/33812691>

Reviewed by Dan Bernstein.

• Shared/API/Cocoa/WebKit.h:

Add WKSnapshotConfiguration, which is a public header.

7:49 PM Changeset in webkit [220783] by commit-queue@webkit.org

• 4 edits in trunk/Source/JavaScriptCore

We are too conservative about the effects of PushWithScope
​https://bugs.webkit.org/show_bug.cgi?id=175584

Patch by Robin Morisset <​rmorisset@apple.com> on 2017-08-15
Reviewed by Saam Barati.

PushWithScope converts its argument to an object (this can throw a type error,
but has no other observable effect), and allocates a new scope, that it then
makes the new current scope. We were a bit too
conservative in saying that it clobbers the world.

• dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

• dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

• dfg/DFGDoesGC.cpp:

(JSC::DFG::doesGC):

7:23 PM Changeset in webkit [220782] by rniwa@webkit.org

• 22 edits
  5 adds in trunk

Make DataTransferItemList work with plain text entries
​https://bugs.webkit.org/show_bug.cgi?id=175596

Reviewed by Wenson Hsieh.

Source/JavaScriptCore:

Added DataTransferItem as a common identifier since it's a runtime enabled feature.

• runtime/CommonIdentifiers.h:

Source/WebCore:

Added the basic machinery to get the list of plain text items to DataTransferItemList and DataTransferItem.

Each DataTransferItem now depends on DataTransfer so it does ref-forwarding like DataTransferItemList to make
DataTransfer alive as long as any DataTransferItem is alive.

Specifications: ​https://html.spec.whatwg.org/multipage/dnd.html#the-datatransferitem-interface

​https://html.spec.whatwg.org/multipage/dnd.html#the-datatransferitemlist-interface

Tests: editing/pasteboard/datatransfer-items-drop-plaintext-file.html

editing/pasteboard/datatransfer-items-paste-plaintext.html

• dom/DataTransferItem.cpp:

(WebCore::DataTransferItem::DataTransferItem): Added two variants one for plain text and another one for a file.
(WebCore::DataTransferItem::kind const): Rewritten.
(WebCore::DataTransferItem::getAsString const): Implemented.
(WebCore::DataTransferItem::getAsFile const): Implemented.

• dom/DataTransferItem.h:

(WebCore::DataTransferItem::ref): Added.
(WebCore::DataTransferItem::deref): Added.
(WebCore::DataTransferItem::type const): Returns String instead of AtomicString.
(WebCore::DataTransferItem::kind const): Moved to cpp.

• dom/DataTransferItem.idl: Removed NoInterfaceObject since the interface object should exist on DOMWindow.
• dom/DataTransferItemList.cpp:

(WebCore::DataTransferItemList::length): Implemented.
(WebCore::DataTransferItemList::item): Ditto.
(WebCore::isSupportedType): Added. For now, we only support text/plain.
(WebCore::DataTransferItemList::ensureItems): Added. Constructs the list of DataTransferItems.

• dom/DataTransferItemList.h:

(DataTransferItemList): Added m_items. The list is filled lazily by ensureItems.

• dom/DataTransferItemList.idl: Removed NoInterfaceObject since the interface object should exist on DOMWindow.

LayoutTests:

Rebaselined the tests and added two regression tests for pasting plain text and dropping a plain text file.

Unfortunately, dropping a file is only supported by DumpRenderTree on Mac :( so it's disabled elsewhere.

• editing/pasteboard/datatransfer-idl-expected.txt: Rebaselined now that NoInterfaceObject has been dropped from

DataTransferItem.idl and DataTransferItemList.idl as expected.

• editing/pasteboard/datatransfer-idl.html: Fixed the bug that it wasn't testing IDL for DataTransferItem.
• editing/pasteboard/datatransfer-items-drop-plaintext-file-expected.txt: Added.
• editing/pasteboard/datatransfer-items-drop-plaintext-file.html: Added.
• editing/pasteboard/datatransfer-items-paste-plaintext-expected.txt: Added.
• editing/pasteboard/datatransfer-items-paste-plaintext.html: Added.
• editing/resources/text-pasteboard-data.txt: Added.
• platform/gtk/js/dom/global-constructors-attributes-expected.txt:
• platform/ios/TestExpectations:
• platform/mac-elcapitan-wk2/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-elcapitan/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-highsierra-wk1/js/dom/global-constructors-attributes-expected.txt:
• platform/mac-highsierra/js/dom/global-constructors-attributes-expected.txt:
• platform/mac/js/dom/global-constructors-attributes-expected.txt:
• platform/win/TestExpectations:
• platform/wk2/TestExpectations:
• platform/wpe/js/dom/global-constructors-attributes-expected.txt:

7:05 PM Changeset in webkit [220781] by Simon Fraser

• 4 edits in trunk/Source/WebCore

Remove ScrollView::clipsRepaints() which was only used by Chromium
​https://bugs.webkit.org/show_bug.cgi?id=175594

Reviewed by Tim Horton.

clipsRepaints() was added in r74568 but was only used by Chromium. It's always
true for other platforms, so remove conditionals that test for it and assume true.

• page/FrameView.cpp:

(WebCore::FrameView::scrollContentsFastPath):

• platform/ScrollView.cpp:

(WebCore::ScrollView::repaintContentRectangle):
(WebCore::ScrollView::setClipsRepaints): Deleted.

• platform/ScrollView.h:

(WebCore::ScrollView::clipsRepaints const): Deleted.

6:37 PM Changeset in webkit [220780] by Simon Fraser

• 8 edits in trunk/Source

Allow WebCore logging channels to be set from the UI process
​https://bugs.webkit.org/show_bug.cgi?id=175608

Reviewed by Tim Horton.

Source/WebCore:

Change initializeLogChannelsIfNecessary() to take an optional String, which can
be a list of log channels passed from the UI process.

• platform/LogInitialization.h:
• platform/Logging.cpp:

(WebCore::initializeLogChannelsIfNecessary):

Source/WebKit:

The UI process can now read the "WebCoreLogging" default, and pass it to the web process
via WebProcessCreationParameters, where WebProcess::platformInitializeWebProcess() uses
it to set up WebCore logging channels. Note that these will override channels read from
the web process user defaults domain (but those are hard to set anyway).

• Shared/WebProcessCreationParameters.cpp:

(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):

• Shared/WebProcessCreationParameters.h:
• UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeWebProcess):

• WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::platformInitializeWebProcess):

6:23 PM Changeset in webkit [220779] by Chris Dumez

• 11 edits
  2 adds in trunk

Fetch / Beacon: Use "application/octet-stream" Content-Type for payloads of type ArrayBuffer / ArrayBufferView
​https://bugs.webkit.org/show_bug.cgi?id=175600

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/beacon/headers/header-content-type-expected.txt:
• web-platform-tests/fetch/api/basic/request-headers.any-expected.txt:
• web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt:

Source/WebCore:

Use "application/octet-stream" Content-Type for payloads of type ArrayBuffer / ArrayBufferView in Fetch & Beacon.
If we don't set a Content-Type header, our underlying network stack is going to add a "application/x-www-form-urlencoded"
Content-Type header, which is worse.

Chrome is already using "application/octet-stream" Content-Type in Beacon, but use no Content-Type in Fetch.
The Fetch/Beacon specification says we should have no Content-Type header in this case but this is unfortunately
not something we can support at the moment. Using "application/octet-stream" Content-Type for now seems like the
lesser evil.

Test: http/wpt/fetch/fetch-request-arraybuffer-content-type.html

• Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::extract):

• platform/network/HTTPHeaderValues.cpp:

(WebCore::HTTPHeaderValues::octetStreamContentType):

• platform/network/HTTPHeaderValues.h:

LayoutTests:

• http/wpt/fetch/fetch-request-arraybuffer-content-type-expected.txt: Added.
• http/wpt/fetch/fetch-request-arraybuffer-content-type.html: Added.
• platform/mac-highsierra/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any-expected.txt:
• platform/mac-highsierra/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt:

6:10 PM Changeset in webkit [220778] by commit-queue@webkit.org

• 18 edits in trunk

JSTests:
Support the 'with' keyword in FTL.
​https://bugs.webkit.org/show_bug.cgi?id=175585

Patch by Robin Morisset <​rmorisset@apple.com> on 2017-08-15
Reviewed by Saam Barati.

Also improve the JSTest/stress/with.js file to test
what happens when non-objects are passed to with.

• stress/with.js:

(foo):
(i.catch):
(i.with): Deleted.

Source/JavaScriptCore:
Support the 'with' keyword in FTL
​https://bugs.webkit.org/show_bug.cgi?id=175585

Patch by Robin Morisset <​rmorisset@apple.com> on 2017-08-15
Reviewed by Saam Barati.

Also makes sure that the order of arguments of PushWithScope, op_push_with_scope, JSWithScope::create()
and so on is consistent (always parentScope first, the new scopeObject second). We used to go from one
to the other at different step which was quite confusing. I picked this order for consistency with CreateActivation
that takes its parentScope argument first.

• bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitPushWithScope):

• debugger/DebuggerCallFrame.cpp:

(JSC::DebuggerCallFrame::evaluateWithScopeExtension):

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• dfg/DFGFixupPhase.cpp:

(JSC::DFG::FixupPhase::fixupNode):

• dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compilePushWithScope):

• ftl/FTLCapabilities.cpp:

(JSC::FTL::canCompile):

• ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileNode):
(JSC::FTL::DFG::LowerDFGToB3::compilePushWithScope):

• jit/JITOperations.cpp:
• runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

• runtime/Completion.cpp:

(JSC::evaluateWithScopeExtension):

• runtime/JSWithScope.cpp:

(JSC::JSWithScope::create):

• runtime/JSWithScope.h:

Source/WebCore:
Change the order of arguments of JSWithScope::create() for consistency
​https://bugs.webkit.org/show_bug.cgi?id=175585

Patch by Robin Morisset <​rmorisset@apple.com> on 2017-08-15
Reviewed by Saam Barati.

No change of behavior.

• bindings/js/JSHTMLElementCustom.cpp:

(WebCore::JSHTMLElement::pushEventHandlerScope const):

5:03 PM Changeset in webkit [220777] by sbarati@apple.com

• 3 edits in trunk/Source/JavaScriptCore

Make VM::scratchBufferForSize thread safe
​https://bugs.webkit.org/show_bug.cgi?id=175604

Reviewed by Geoffrey Garen and Mark Lam.

I want to use the VM::scratchBufferForSize in another patch I'm writing.
The use case for my other patch is to call it from the compiler thread.
When reading the code, I saw that this API was not thread safe. This patch
makes it thread safe. It actually turns out we were calling this API from
the compiler thread already when we created FTL::State for an FTL OSR entry
compilation, and from FTLLowerDFGToB3. That code was racy and wrong, but
is now correct with this patch.

• runtime/VM.cpp:

(JSC::VM::VM):
(JSC::VM::~VM):
(JSC::VM::gatherConservativeRoots):
(JSC::VM::scratchBufferForSize):

• runtime/VM.h:

(JSC::VM::scratchBufferForSize): Deleted.

5:02 PM Changeset in webkit [220776] by Matt Lewis

• 2 edits in trunk/LayoutTests

Skipped media/modern-media-controls/time-labels-support/elapsed-time.html.
<rdar://problem/33731086>

Unreviewed test gardening.

• platform/mac-highsierra/TestExpectations:

4:56 PM Changeset in webkit [220775] by jmarcell@apple.com

• 7 edits in branches/safari-604.1.38.1-branch/Source

Versioning.

4:54 PM Changeset in webkit [220774] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.38.1.6

Tag Safari-604.1.38.1.6.

4:48 PM Changeset in webkit [220773] by jfbastien@apple.com

• 2 edits
  6 adds in trunk/LayoutTests

LayoutTests: test that an XMLHttpRequest with Content-Encoding: gzip is properly decompressed
​https://bugs.webkit.org/show_bug.cgi?id=175579

Also test that without Content-Encoding proper sniffing takes place, and gzip
decoding occurs. This test is disabled and tracked by #175597.

Reviewed by Daniel Bates.

• TestExpectations:
• http/tests/xmlhttprequest/gzip-content-type-expected.txt: Added.
• http/tests/xmlhttprequest/gzip-content-type-no-content-encoding-expected.txt: Added.
• http/tests/xmlhttprequest/gzip-content-type-no-content-encoding.html: Added.
• http/tests/xmlhttprequest/gzip-content-type.html: Added.
• http/tests/xmlhttprequest/resources/gzip-lorem-no-content-encoding.php: Added.
• http/tests/xmlhttprequest/resources/gzip-lorem.php: Added.

4:23 PM Changeset in webkit [220772] by Chris Dumez

• 32 edits
  1 copy
  30 adds
  4 deletes in trunk/LayoutTests

Re-sync DOM Web-Platform-Tests from upstream
​https://bugs.webkit.org/show_bug.cgi?id=175588

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Re-sync DOM Web-Platform-Tests from upstream b5129e92ce.

• web-platform-tests/dom/abort/event.any-expected.txt: Added.
• web-platform-tests/dom/abort/event.any.html: Added.
• web-platform-tests/dom/abort/event.any.js: Added.
• web-platform-tests/dom/abort/event.any.worker-expected.txt: Added.
• web-platform-tests/dom/abort/event.any.worker.html: Added.
• web-platform-tests/dom/abort/w3c-import.log: Added.
• web-platform-tests/dom/events/Event-dispatch-click-expected.txt:
• web-platform-tests/dom/events/Event-dispatch-click.html:
• web-platform-tests/dom/events/Event-timestamp-high-resolution-expected.txt: Added.
• web-platform-tests/dom/events/Event-timestamp-high-resolution.html: Added.
• web-platform-tests/dom/events/Event-timestamp-safe-resolution-expected.txt: Added.
• web-platform-tests/dom/events/Event-timestamp-safe-resolution.html: Added.
• web-platform-tests/dom/events/EventTarget-constructible.any-expected.txt: Added.
• web-platform-tests/dom/events/EventTarget-constructible.any.html: Added.
• web-platform-tests/dom/events/EventTarget-constructible.any.js: Added.

(test.listener):
(test):
(test.prototype.on):
(test.prototype.off):
(test.prototype.dispatch):

• web-platform-tests/dom/events/EventTarget-constructible.any.worker-expected.txt: Added.
• web-platform-tests/dom/events/EventTarget-constructible.any.worker.html: Added.
• web-platform-tests/dom/events/EventTarget-dispatchEvent-expected.txt:
• web-platform-tests/dom/events/w3c-import.log:
• web-platform-tests/dom/interface-objects-expected.txt:
• web-platform-tests/dom/interface-objects.html:
• web-platform-tests/dom/interfaces-expected.txt:
• web-platform-tests/dom/interfaces.html:
• web-platform-tests/dom/nodes/Document-constructor-svg.svg: Removed.
• web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_01-expected.txt: Removed.
• web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_01.html: Removed.
• web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_02-expected.txt:
• web-platform-tests/dom/nodes/Document-contentType/contentType/contenttype_datauri_02.html:
• web-platform-tests/dom/nodes/Document-contentType/contentType/w3c-import.log:
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.html: Added.
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.svg: Added.
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xhtml: Added.
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/empty.xml: Added.
• web-platform-tests/dom/nodes/Document-createElement-namespace-tests/w3c-import.log:
• web-platform-tests/dom/nodes/Document-createEvent-expected.txt:
• web-platform-tests/dom/nodes/Document-createEvent.html:
• web-platform-tests/dom/nodes/Document-createEvent.js:
• web-platform-tests/dom/nodes/Element-classlist-expected.txt:
• web-platform-tests/dom/nodes/Element-classlist.html:
• web-platform-tests/dom/nodes/Element-matches-init.js: Copied from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Element-matches.html.

(init):

• web-platform-tests/dom/nodes/Element-matches.html:
• web-platform-tests/dom/nodes/Element-webkitMatchesSelector.html:
• web-platform-tests/dom/nodes/Node-cloneNode-expected.txt:
• web-platform-tests/dom/nodes/Node-cloneNode.html:
• web-platform-tests/dom/nodes/w3c-import.log:
• web-platform-tests/interfaces/OWNERS: Added.
• web-platform-tests/interfaces/clipboard.idl: Added.
• web-platform-tests/interfaces/cssom.idl: Added.
• web-platform-tests/interfaces/dedicated-workers.idl: Added.
• web-platform-tests/interfaces/dom.idl: Added.
• web-platform-tests/interfaces/fullscreen.idl: Added.
• web-platform-tests/interfaces/geometry.idl: Added.
• web-platform-tests/interfaces/html.idl: Added.
• web-platform-tests/interfaces/mediacapture-main.idl: Added.
• web-platform-tests/interfaces/remoteplayback.idl: Added.
• web-platform-tests/interfaces/touchevents.idl: Added.
• web-platform-tests/interfaces/uievents.idl: Added.
• web-platform-tests/interfaces/web-share.idl: Added.
• web-platform-tests/interfaces/webrtc-pc.idl: Added.
• web-platform-tests/interfaces/webusb.idl: Added.

LayoutTests:

• platform/mac/TestExpectations:

3:58 PM Changeset in webkit [220771] by aakash_jain@apple.com

• 3 edits in trunk/Tools

undefined URL in PopoverTracker for failed step
​https://bugs.webkit.org/show_bug.cgi?id=175593
<rdar://problem/33898769>

Reviewed by Daniel Bates.

This fix is a workaround for Buildbot 0.9 bug <​https://github.com/buildbot/buildbot/issues/3529> where it
does not provide a URL to stdio for a build step. Buildbot 0.8 always included a URL to the stdio of the step.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:

(BuildbotIteration.prototype._parseData): Pass the URL while instantiating BuildbotTestResults.
(BuildbotIteration.prototype._urlForStep): Method to get the URL for a step.

• BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotTestResults.js:

(BuildbotTestResults): Accept URL in constructor.

3:54 PM Changeset in webkit [220770] by keith_miller@apple.com

• 4 edits in trunk/Source/JavaScriptCore

JSC named bytecode offsets should use references rather than pointers
​https://bugs.webkit.org/show_bug.cgi?id=175601

Reviewed by Saam Barati.

• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_overrides_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof_custom):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_overrides_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof_custom):

3:50 PM Changeset in webkit [220769] by jmarcell@apple.com

• 7 edits in branches/safari-604-branch/Source

Versioning.

3:48 PM Changeset in webkit [220768] by jmarcell@apple.com

• 1 copy in tags/Safari-604.2.3

Tag Safari-604.2.3.

3:43 PM Changeset in webkit [220767] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark http/tests/loading/resourceLoadStatistics/clear-in-memory-and-persistent-store.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=175263

Unreviewed test gardening.

• platform/wk2/TestExpectations:

3:43 PM Changeset in webkit [220766] by jmarcell@apple.com

• 7 edits in branches/safari-604.1.38.0-branch/Source

Versioning.

3:41 PM Changeset in webkit [220765] by jmarcell@apple.com

• 1 copy in tags/Safari-604.1.38.0.6

Tag Safari-604.1.38.0.6.

3:38 PM Changeset in webkit [220764] by commit-queue@webkit.org

• 3 edits in trunk/Source/WebCore

[Cache API] Ensure ResourceResponse is not null when redirected/tainting/type fields are set
​https://bugs.webkit.org/show_bug.cgi?id=175538

Patch by Youenn Fablet <​youenn@apple.com> on 2017-08-15
Reviewed by Chris Dumez.

No change of behavior.
This change ensures that response type is preserved when encoding/decoding ResourceResponse, in particular the error type.
This will allow Cache API to preserve responses when reading them from a different process.

• platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::setType):

• platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::setType):

3:34 PM Changeset in webkit [220763] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark fast/images/animated-gif-scrolling-crash.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=175345.

Unreviewed test gardening.

• platform/mac-wk1/TestExpectations:

3:06 PM Changeset in webkit [220762] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark fast/mediacapturefromelement/CanvasCaptureMediaStream-webgl-events.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=175592

Unreviewed test gardening.

• platform/mac/TestExpectations:

2:44 PM Changeset in webkit [220761] by Ryan Haddad

• 2 edits in trunk/LayoutTests

Mark http/tests/appcache/deferred-events-delete-while-raising-timer.html as flaky.
​https://bugs.webkit.org/show_bug.cgi?id=87633

Unreviewed test gardening.

• TestExpectations: Add expectation that was removed with r220750.

2:15 PM Changeset in webkit [220760] by Chris Dumez

• 28 edits in trunk/Source/WebCore

Update CachedResourceLoader::requestResource() to return a WTF::Expected
​https://bugs.webkit.org/show_bug.cgi?id=175505

Reviewed by Youenn Fablet.

Update CachedResourceLoader::requestResource() to return a WTF::Expected
type instead of using an out parameter for the ResourceError in case of
synchronous failure.

• Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

• bindings/js/CachedScriptFetcher.cpp:

(WebCore::CachedScriptFetcher::requestScriptWithCache const):

• css/CSSFontFaceSrcValue.cpp:

(WebCore::CSSFontFaceSrcValue::cachedFont):

• css/CSSImageSetValue.cpp:

(WebCore::CSSImageSetValue::loadBestFitImage):

• css/CSSImageValue.cpp:

(WebCore::CSSImageValue::loadImage):

• css/StyleRuleImport.cpp:

(WebCore::StyleRuleImport::requestStyleSheet):

• dom/ProcessingInstruction.cpp:

(WebCore::ProcessingInstruction::checkStyleSheet):

• html/HTMLLinkElement.cpp:

(WebCore::HTMLLinkElement::process):

• loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::startPreflight):

• loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::startLoadingMainResource):

• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadedResourceFromMemoryCache):

• loader/FrameLoader.h:
• loader/ImageLoader.cpp:

(WebCore::ImageLoader::updateFromElement):

• loader/LinkLoader.cpp:

(WebCore::LinkLoader::preloadIfNeeded):

• loader/MediaResourceLoader.cpp:

(WebCore::MediaResourceLoader::requestResource):

• loader/TextTrackLoader.cpp:

(WebCore::TextTrackLoader::load):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::castCachedResourceTo):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestFont):
(WebCore::CachedResourceLoader::requestTextTrack):
(WebCore::CachedResourceLoader::requestCSSStyleSheet):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestScript):
(WebCore::CachedResourceLoader::requestXSLStyleSheet):
(WebCore::CachedResourceLoader::requestSVGDocument):
(WebCore::CachedResourceLoader::requestLinkResource):
(WebCore::CachedResourceLoader::requestMedia):
(WebCore::CachedResourceLoader::requestIcon):
(WebCore::CachedResourceLoader::requestRawResource):
(WebCore::CachedResourceLoader::requestBeaconResource):
(WebCore::CachedResourceLoader::requestMainResource):
(WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::preload):

• loader/cache/CachedResourceLoader.h:
• loader/cache/CachedSVGDocumentReference.cpp:

(WebCore::CachedSVGDocumentReference::load):

• loader/icon/IconLoader.cpp:

(WebCore::IconLoader::startLoading):

• platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:

(WebCore::WebCoreAVFResourceLoader::startLoading):

• svg/SVGFEImageElement.cpp:

(WebCore::SVGFEImageElement::requestImageResource):

• svg/SVGFontFaceUriElement.cpp:

(WebCore::SVGFontFaceUriElement::loadFont):

• svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::updateExternalDocument):

• xml/XSLImportRule.cpp:

(WebCore::XSLImportRule::loadSheet):

2:08 PM Changeset in webkit [220759] by don.olmstead@sony.com

• 19 edits
  8 moves
  1 add in trunk/Source

[PAL] Move Sleep classes into PAL
​https://bugs.webkit.org/show_bug.cgi?id=175456

Reviewed by Ryosuke Niwa.

Source/WebCore:

No new tests. No change in behavior.

• CMakeLists.txt:
• PlatformMac.cmake:
• WebCore.xcodeproj/project.pbxproj:
• html/HTMLMediaElement.cpp:
• html/HTMLMediaElement.h:
• platform/audio/PlatformMediaSessionManager.cpp:
• platform/audio/PlatformMediaSessionManager.h:
• platform/mac/WebVideoFullscreenController.h:
• platform/mac/WebVideoFullscreenController.mm:

Source/WebCore/PAL:

• PAL.xcodeproj/project.pbxproj:
• pal/CMakeLists.txt:
• pal/PlatformMac.cmake:
• pal/system/SleepDisabler.cpp: Renamed from Source/WebCore/platform/SleepDisabler.cpp.
• pal/system/SleepDisabler.h: Renamed from Source/WebCore/platform/SleepDisabler.h.
• pal/system/SystemSleepListener.cpp: Renamed from Source/WebCore/platform/SystemSleepListener.cpp.
• pal/system/SystemSleepListener.h: Renamed from Source/WebCore/platform/SystemSleepListener.h.
• pal/system/cocoa/SleepDisablerCocoa.cpp: Renamed from Source/WebCore/platform/cocoa/SleepDisablerCocoa.cpp.
• pal/system/cocoa/SleepDisablerCocoa.h: Renamed from Source/WebCore/platform/cocoa/SleepDisablerCocoa.h.
• pal/system/mac/SystemSleepListenerMac.h: Renamed from Source/WebCore/platform/mac/SystemSleepListenerMac.h.
• pal/system/mac/SystemSleepListenerMac.mm: Renamed from Source/WebCore/platform/mac/SystemSleepListenerMac.mm.

Source/WebKit:

• UIProcess/mac/WKFullScreenWindowController.h:
• UIProcess/mac/WKFullScreenWindowController.mm:

Source/WebKitLegacy/mac:

• WebView/WebFullScreenController.h:

2:04 PM Changeset in webkit [220758] by commit-queue@webkit.org

• 58 edits
  3 copies
  3 adds in trunk

[Cache API] Adding generic support for CacheStorage and Cache methods
​https://bugs.webkit.org/show_bug.cgi?id=175455

Patch by Youenn Fablet <​youenn@apple.com> on 2017-08-15
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

• web-platform-tests/service-workers/cache-storage/serviceworker/credentials.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/cache-storage-match.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/window/cache-storage.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-storage-match.https-expected.txt:
• web-platform-tests/service-workers/cache-storage/worker/cache-storage.https-expected.txt:

Source/WebCore:

Covered by existing tests.

Adding a CacheStorageProvider abstraction that creates a CacheStorageConnection.
The CacheStorageProvider is accessed from the page for Document calls.
The CacheStorageConnection is responsible to implement the read/write operations on the cache database.
At the moment, it does nothing but return not implemented errors.

Implementing CacheStorage APIs and Cache APIs based on the CacheStorageConnection except for Cache add and addAll which will be implemented later on.
CacheStoragConnection is responsible to read/write CacheStorage list of caches and each individual cache.
The CacheStorageConnection is a generic connection and not tied to any document/context.
CacheStorage objects are manipulated by providing to the connection the origin of the context.
CacheStorage are global to all contexts with the same origin.
Cache objects are manipulated by an ID that is given initially by the CacheStorageEngine when opening the Cache object.

Adding various accessors and constructors for Fetch constructs as needed by the Cache API implementation.

• Modules/cache/Cache.cpp:

(WebCore::Cache::Cache):
(WebCore::Cache::~Cache):
The CacheStorageConnection is a generic connection and not tied to any document/context.
(WebCore::Cache::match): Implementation of ​https://www.w3.org/TR/service-workers-1/#cache-match.
Redirect to matchAll as per spec.
(WebCore::Cache::matchAll): Implementation of ​https://www.w3.org/TR/service-workers-1/#cache-matchAll.
Checks for request as per spec. Then either refresh the request to response map and return all responses.
Or call the query cache algorithm and return copies of the responses (using clone).
(WebCore::Cache::put):
Check the request and response as per spec.
Add temporary rejection cases (being loaded responses, responses with ReadableStream) as there is no support for them right now.
Call the batch put operation.
(WebCore::Cache::remove):
Check the request and response as per spec.
Call the batch delete operation.
(WebCore::Cache::keys):
Refresh the request to response map and return corresponding requests.
Making sure to reuse the same request objects as per spec.
As per spec, the request to response map is ordered. We implement it as a Vector.
(WebCore::Cache::refreshRequestToResponseMap):
Use the cache storage connection to get an up-to-date list of cached records.
(WebCore::Cache::queryCacheMatch):
Implements the match algorithm defined in ​https://www.w3.org/TR/service-workers-1/#query-cache-algorithm.
This is split for queryCache as cache storage engine will need to use it when implementing the delete operation.
(WebCore::Cache::queryCache):
Full implementation of ​https://www.w3.org/TR/service-workers-1/#query-cache-algorithm with no targetStorage argument.
(WebCore::Cache::queryCacheWithTargetStorage):
Full implementation of ​https://www.w3.org/TR/service-workers-1/#query-cache-algorithm with a provided targetStorage argument.
(WebCore::Cache::batchDeleteOperation):
Implementation of ​https://www.w3.org/TR/service-workers-1/#batch-cache-operations-algorithm but dedicated to a delete operation.
Delete operation are always done one at a time.
(WebCore::Cache::batchPutOperation):
Implementation of ​https://www.w3.org/TR/service-workers-1/#batch-cache-operations-algorithm dedicated to a put operation.
Put operation takes one record for put but can take several records in the case of addAll, hence the current design.
(WebCore::Cache::updateRequestToResponseMap):
Update the cache request to response map based on the records retrieved from the cache storage connection.

• Modules/cache/Cache.h:

(WebCore::Cache::create):
(WebCore::Cache::name const):

• Modules/cache/Cache.idl:
• Modules/cache/CacheStorage.cpp:

(WebCore::CacheStorage::origin const):
Computing the cache origin that is passed to the CacheStorageConnection.
(WebCore::CacheStorage::has):
Implementation of ​https://www.w3.org/TR/service-workers-1/#cache-storage-has.
Call the cache storage connection to refresh its cache map.
Then use it to check whether a cache exists.
(WebCore::CacheStorage::refreshCacheMap):
Use the cache storage connection to get the list of existing caches.
(WebCore::CacheStorage::open):
Implementation of ​https://www.w3.org/TR/service-workers-1/#cache-storage-open.
Refreshing the cache map so as to return a pre-existing cache if any.
(WebCore::CacheStorage::remove):
Implementation of ​https://www.w3.org/TR/service-workers-1/#cache-storage-delete-method.
Refreshing the cache map so as to do nothing if there is no cache to remove.
(WebCore::CacheStorage::keys):
Implementation of ​https://www.w3.org/TR/service-workers-1/#cache-storage-keys-method.
Refreshing the cache map and returnin its keys.
As per spec, the cache map is ordered. We implement it as a Vector.
(WebCore::CacheStorage::cacheMap):
Get the list of cache objects, used as a private accessor for JS built-ins.

• Modules/cache/CacheStorage.h:

(WebCore::CacheStorage::create):
(WebCore::CacheStorage::CacheStorage):

• Modules/cache/CacheStorageConnection.cpp: Added.

(WebCore::CacheStorageConnection::exceptionFromError):

• Modules/cache/CacheStorageConnection.h: Added.

Makes the link between Web facing Cache API and the cache storage engine.
Envisioned implementation are:

• One main thread connection used by all documents in the given process.
• One connection per worker that forwards the calls to the main thread and use the main thread connection afterwards.

(WebCore::CacheStorageConnection::create):
(WebCore::CacheStorageConnection::open):
(WebCore::CacheStorageConnection::remove):
(WebCore::CacheStorageConnection::refreshCacheMap):
(WebCore::CacheStorageConnection::refreshRequestToResponseMap):
(WebCore::CacheStorageConnection::batchDeleteOperation):
(WebCore::CacheStorageConnection::batchPutOperation):

• Modules/cache/CacheStorageRecord.h: Added. A fetch record from the Web facing cache API perspective.
• Modules/cache/DOMWindowCaches.cpp:

(WebCore::DOMWindowCaches::caches const):

• Modules/cache/WorkerGlobalScopeCaches.cpp:

(WebCore::WorkerGlobalScopeCaches::from):
(WebCore::WorkerGlobalScopeCaches::caches const):

• Modules/cache/WorkerGlobalScopeCaches.h:

(WebCore::WorkerGlobalScopeCaches::WorkerGlobalScopeCaches):

• Modules/fetch/FetchBodyOwner.h:

(WebCore::FetchBodyOwner::isReadableStreamBody const): Added getter as it is used by cache API.

• Modules/fetch/FetchHeaders.h:

(WebCore::FetchHeaders::create): Add another create as used by the cache API.
(WebCore::FetchHeaders::guard const): Added getter and IPC serializer as this is something that will be stored by the cache engine.

• Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):

• Modules/fetch/FetchRequest.cpp:

(WebCore::buildOptions): In case FetchRequest::create is called from C++, there is no need to set init.window to a null value.
Add a check so that no value at all is the same as a null/undefined value.
(WebCore::FetchRequest::resourceRequest const):

• Modules/fetch/FetchRequest.h:
• Modules/fetch/FetchResponse.h:
• WebCore.xcodeproj/project.pbxproj:
• inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::overlayPage):

• page/CacheStorageProvider.h: Added.

Interface to create main thread cache storage connection for the given page.
There will be one provider for each process.
Passing a sessionID so that we will create a connection per session.

• page/Page.cpp:

(WebCore::Page::Page):

• page/Page.h:

(WebCore::Page::cacheStorageProvider):

• page/PageConfiguration.cpp:

(WebCore::PageConfiguration::PageConfiguration):

• page/PageConfiguration.h:
• svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::dataChanged):

Source/WebKit:

• WebKit.xcodeproj/project.pbxproj:
• WebProcess/Cache/WebCacheStorageProvider.h: Added.
• WebProcess/WebPage/WebPage.cpp:

(WebKit::m_cpuLimit):

• WebProcess/WebProcess.cpp:

(WebKit::WebProcess::WebProcess):

• WebProcess/WebProcess.h:

(WebKit::WebProcess::cacheStorageProvider):

Source/WebKitLegacy/mac:

• WebView/WebView.mm:

(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKitLegacy/win:

• WebView.cpp:

(WebView::initWithFrame):

LayoutTests:

• TestExpectations: Skipping a test that would timeout otherwise due to the current implementation limitations.

1:45 PM Changeset in webkit [220757] by jmarcell@apple.com

• 3 edits in branches/safari-604.1.38.1-branch/Source/WebCore

Cherry-pick r220723. rdar://problem/33901117

1:41 PM Changeset in webkit [220756] by jmarcell@apple.com

• 6 edits
  2 adds in branches/safari-604-branch

Cherry-pick r217197. rdar://problem/33890650

1:36 PM Changeset in webkit [220755] by jmarcell@apple.com

• 6 edits
  2 adds in branches/safari-604.1.38.0-branch

Cherry-pick r217197. rdar://problem/33890636

1:21 PM Changeset in webkit [220754] by commit-queue@webkit.org

• 2 edits in trunk/LayoutTests/imported/w3c

WPT harness errors on leaks bot
​https://bugs.webkit.org/show_bug.cgi?id=175269

Patch by Youenn Fablet <​youenn@apple.com> on 2017-08-15
Reviewed by Alexey Proskuryakov.

To try debugging these errors, let's check whether the WPT server is
sending back resources of the expected size.

• web-platform-tests/tools/wptserve/wptserve/response.py:

(Response.write_content):
(ResponseWriter.write_content):
(ResponseWriter.write):
(ResponseWriter.write_content_file):

1:13 PM Changeset in webkit [220753] by keith_miller@apple.com

• 13 edits in trunk/Source/JavaScriptCore

Enable named offsets into JSC bytecodes
​https://bugs.webkit.org/show_bug.cgi?id=175561

Reviewed by Mark Lam.

This patch adds the ability to add named offsets into JSC's
bytecodes. In the bytecode json file, instead of listing a
length, you can now list a set of names and their types. Each
opcode with an offsets property will have a struct named after the
opcode by in our C++ naming style. For example,
op_overrides_has_instance would become OpOverridesHasInstance. The
struct has the same memory layout as the instruction list has but
comes with handy named accessors.

As a first cut I converted the various instanceof bytecodes to use
named offsets.

As an example op_overrides_has_instance produces the following struct:

struct OpOverridesHasInstance {
public:

Opcode& opcode() { return *reinterpret_cast<Opcode*>(&m_opcode); }
const Opcode& opcode() const { return *reinterpret_cast<const Opcode*>(&m_opcode); }
int& dst() { return *reinterpret_cast<int*>(&m_dst); }
const int& dst() const { return *reinterpret_cast<const int*>(&m_dst); }
int& constructor() { return *reinterpret_cast<int*>(&m_constructor); }
const int& constructor() const { return *reinterpret_cast<const int*>(&m_constructor); }
int& hasInstanceValue() { return *reinterpret_cast<int*>(&m_hasInstanceValue); }
const int& hasInstanceValue() const { return *reinterpret_cast<const int*>(&m_hasInstanceValue); }

private:

friend class LLIntOffsetsExtractor;
std::aligned_storage<sizeof(Opcode), sizeof(Instruction)>::type m_opcode;
std::aligned_storage<sizeof(int), sizeof(Instruction)>::type m_dst;
std::aligned_storage<sizeof(int), sizeof(Instruction)>::type m_constructor;
std::aligned_storage<sizeof(int), sizeof(Instruction)>::type m_hasInstanceValue;

};

• CMakeLists.txt:
• DerivedSources.make:
• JavaScriptCore.xcodeproj/project.pbxproj:
• bytecode/BytecodeList.json:
• dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

• generate-bytecode-files:
• jit/JITOpcodes.cpp:

(JSC::JIT::emit_op_overrides_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof_custom):

• jit/JITOpcodes32_64.cpp:

(JSC::JIT::emit_op_overrides_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof):
(JSC::JIT::emitSlow_op_instanceof_custom):

• llint/LLIntOffsetsExtractor.cpp:
• llint/LowLevelInterpreter.asm:
• llint/LowLevelInterpreter32_64.asm:
• llint/LowLevelInterpreter64.asm:

1:11 PM Changeset in webkit [220752] by msaboff@apple.com

• 5 edits
  19 adds in trunk/PerformanceTests

Add Offline Assembler parsing test to RexBench
​https://bugs.webkit.org/show_bug.cgi?id=175581

Reviewed by Saam Barati.

This is a port of the JavaScriptCore offline assmebler's lexer, parser, AST and
supporting code from Ruby to JavaScript turned into a benchmark. The benchmark
timing includes parsing through AST. The validation processing time is not
part of the benchmark measurement.

The input data is the current tip of tree LLInt .asm source files. Those file
were converted to JavaScript using the python script, convert_asm_to_js.py.
There is also a new JavaScript file, generate_expected.js, to create the
expected output JavaScript file.

• RexBench/OfflineAssembler: Added.
• RexBench/OfflineAssembler/ast.js: Added.
• RexBench/OfflineAssembler/instructions.js: Added.
• RexBench/OfflineAssembler/parser.js: Added.
• RexBench/OfflineAssembler/registers.js: Added.

These are JavaScript translation of the Ruby Offline Assembler. Code not
needed for the benchmark was not translated and therefore missing.

• RexBench/OfflineAssembler/InitBytecodes.asm: Added.
• RexBench/OfflineAssembler/InitBytecodes.js: Added.
• RexBench/OfflineAssembler/LowLevelInterpreter.asm: Added.
• RexBench/OfflineAssembler/LowLevelInterpreter.js: Added.
• RexBench/OfflineAssembler/LowLevelInterpreter32_64.asm: Added.
• RexBench/OfflineAssembler/LowLevelInterpreter32_64.js: Added.
• RexBench/OfflineAssembler/LowLevelInterpreter64.asm: Added.
• RexBench/OfflineAssembler/LowLevelInterpreter64.js: Added.

Copies of the current LLInt source and conversion to JavaScript.

• RexBench/OfflineAssembler/file.js: Added.

(File):
(File.open):
(File.prototype.read):
Mock File class used to simulate filesystem access.

• RexBench/OfflineAssembler/expected.js: Added.

Expected output of the AST dumped and split into individual lines.

• RexBench/OfflineAssembler/benchmark.js: Added.

(OfflineAssemblerBenchmark):
(OfflineAssemblerBenchmark.prototype.runOnce):
(OfflineAssemblerBenchmark.prototype.validate):
Benchmark sub class for this test.

• RexBench/OfflineAssembler/convert_asm_to_js.py: Added.

(convertFile):
Converts .asm into .js files compatible to the benchmark.

• RexBench/OfflineAssembler/generate_expected.js: Added.

Converts AST output into the expected file format.

• RexBench/about.html: Added description of this sub-benchmark test.

• RexBench/cli.js:
• RexBench/glue.js:
• RexBench/index.html:
• RexBench/offline_assembler_benchmark.js: Added.

Updates to add this sub-benchmark.

12:35 PM Changeset in webkit [220751] by Chris Dumez

• 38 edits
  4 adds in trunk

Implement quota limitation for keepalive Fetch requests
​https://bugs.webkit.org/show_bug.cgi?id=175482

Reviewed by Sam Weinig and Youenn Fablet.

LayoutTests/imported/w3c:

• web-platform-tests/fetch/api/basic/scheme-about.any-expected.txt:
• web-platform-tests/fetch/api/basic/scheme-about.any.worker-expected.txt:
• web-platform-tests/fetch/api/cors/cors-multiple-origins-expected.txt:
• web-platform-tests/fetch/api/cors/cors-multiple-origins-worker-expected.txt:
• web-platform-tests/fetch/api/cors/cors-preflight-star.any-expected.txt:
• web-platform-tests/fetch/api/cors/cors-preflight-star.any.worker-expected.txt:
• web-platform-tests/fetch/http-cache/cc-request-expected.txt:

Rebaseline tests now that we provide a more helpful error message when rejecting
the fetch() promise.

• web-platform-tests/fetch/api/request/request-keepalive-quota-expected.txt:

Rebaseline test for keepalive Fetch requests quota which is now passing.

Source/WebCore:

Implement quota limitation for keepalive Fetch requests as per:

• ​https://fetch.spec.whatwg.org/#http-network-or-cache-fetch (Step 9)

This partly works for Beacon as well, meaning that no Beacon with a body
over 64Kb can be sent. However, we don't keep track about wether or not
beacon loads are inflight or not.

Also update CachedResourceLoader::requestResource() so that the caller
can get a ResourceError when it returns null. This is useful for both
Fetch and Beacon to return better error messages.

Test: http/wpt/beacon/beacon-quota.html

• CMakeLists.txt:
• Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::sendBeacon):

• Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::BlobLoader::didReceiveResponse):
(WebCore::FetchBodyOwner::BlobLoader::didFail):

• Modules/fetch/FetchBodyOwner.h:
• Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::start):
(WebCore::FetchLoader::didFail):

• Modules/fetch/FetchLoaderClient.h:
• Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::BodyLoader::didFail):

• Modules/fetch/FetchResponse.h:
• WebCore.xcodeproj/project.pbxproj:
• loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::loadRequest):

• loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

• loader/cache/CachedResource.h:

(WebCore::CachedResource::isMainOrMediaOrIconOrRawResource const):

• loader/cache/CachedResourceLoader.cpp:

(WebCore::createResource):
(WebCore::CachedResourceLoader::requestImage):
(WebCore::CachedResourceLoader::requestFont):
(WebCore::CachedResourceLoader::requestTextTrack):
(WebCore::CachedResourceLoader::requestCSSStyleSheet):
(WebCore::CachedResourceLoader::requestUserCSSStyleSheet):
(WebCore::CachedResourceLoader::requestScript):
(WebCore::CachedResourceLoader::requestXSLStyleSheet):
(WebCore::CachedResourceLoader::requestSVGDocument):
(WebCore::CachedResourceLoader::requestLinkResource):
(WebCore::CachedResourceLoader::requestMedia):
(WebCore::CachedResourceLoader::requestIcon):
(WebCore::CachedResourceLoader::requestRawResource):
(WebCore::CachedResourceLoader::requestBeaconResource):
(WebCore::CachedResourceLoader::requestMainResource):
(WebCore::CachedResourceLoader::requestResource):
(WebCore::CachedResourceLoader::preload):

• loader/cache/CachedResourceLoader.h:
• loader/cache/KeepaliveRequestTracker.cpp: Added.

(WebCore::KeepaliveRequestTracker::~KeepaliveRequestTracker):
(WebCore::KeepaliveRequestTracker::canLoadRequest):
(WebCore::KeepaliveRequestTracker::registerRequest):
(WebCore::KeepaliveRequestTracker::responseReceived):
(WebCore::KeepaliveRequestTracker::notifyFinished):
(WebCore::KeepaliveRequestTracker::unregisterRequest):

• loader/cache/KeepaliveRequestTracker.h: Added.
• platform/network/FormData.cpp:

(WebCore::FormDataElement::lengthInBytes const):
(WebCore::FormData::lengthInBytes const):

• platform/network/FormData.h:

LayoutTests:

• fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
• http/tests/contentextensions/async-xhr-onerror-expected.txt:
• http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-asynchronous-in-iframe-expected.txt:
• http/tests/security/contentSecurityPolicy/block-all-mixed-content/insecure-xhr-asynchronous-in-main-frame-expected.txt:
• http/tests/security/mixedContent/insecure-xhr-in-main-frame-expected.txt:

Rebaseline a few tests now that we provide a more helpful error message when an XHR is failing synchronously.

• http/wpt/beacon/beacon-quota-expected.txt: Added.
• http/wpt/beacon/beacon-quota.html: Added.

Add layout test coverage for keepalive Fetch requests quota in the context of sendBeacon().
The second part of the test is still failing because WebCore does not currently know when
ping loads (e.g. beacon loads) complete. This will be addressed via Bug 175443.

11:13 AM Changeset in webkit [220750] by Darin Adler

• 4 edits in trunk

REGRESSION(r220052): http/tests/appcache/deferred-events-delete-while-raising-timer.html is crashing.
​https://bugs.webkit.org/show_bug.cgi?id=175107

Reviewed by Alexey Proskuryakov.

Source/WebCore:

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadComplete): Moved the assertion to after the null page check.

LayoutTests:

• TestExpectations: Removed the flakiness expectation for this test.

10:57 AM Changeset in webkit [220749] by matthew_hanson@apple.com

• 6 edits
  1 copy
  1 add in branches/safari-604-branch

Cherry-pick r220722. rdar://problem/33890577

10:55 AM WebKitGTK/Gardening/Calendar edited by Michael Catanzaro

(diff)

10:50 AM Changeset in webkit [220748] by matthew_hanson@apple.com

• 6 edits
  1 copy
  1 add in branches/safari-604.1.38.0-branch

Cherry-pick r220722. rdar://problem/33890575

10:47 AM Changeset in webkit [220747] by Michael Catanzaro

• 6 edits
  4 adds in trunk/LayoutTests

Unreviewed GTK test gardening

• TestExpectations:
• platform/gtk/TestExpectations:
• platform/gtk/fast/events/input-events-paste-rich-datatransfer-expected.txt:
• platform/gtk/imported/w3c/web-platform-tests/eventsource/format-field-id-2-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/eventsource/format-field-id-expected.txt: Added.
• platform/gtk/imported/w3c/web-platform-tests/eventsource/format-mime-bogus-expected.txt: Added.
• platform/ios/TestExpectations:
• platform/mac/TestExpectations:

10:15 AM Changeset in webkit [220746] by commit-queue@webkit.org

• 3 edits
  2 deletes in trunk

Unreviewed, rolling out r219504.
​https://bugs.webkit.org/show_bug.cgi?id=175580

Broke Arabic text shaping (Requested by mcatanzaro on
#webkit).

Reverted changeset:

"[HarfBuzz] Decomposed Vietnamese characters are rendered
incorrectly"
​https://bugs.webkit.org/show_bug.cgi?id=174418
​http://trac.webkit.org/changeset/219504

10:05 AM Changeset in webkit [220745] by Ryan Haddad

• 2 edits in branches/safari-604.1.38.0-branch/LayoutTests

Cherry-pick r219572.

9:42 AM Changeset in webkit [220744] by mark.lam@apple.com

• 2 edits in trunk/Source/JavaScriptCore

Update testmasm to use new CPUState APIs.
​https://bugs.webkit.org/show_bug.cgi?id=175573

Reviewed by Keith Miller.

1. Applied convenience CPUState accessors to minimize casting.
2. Converted the CHECK macro to CHECK_EQ to get more friendly failure debugging messages.
3. Removed the CHECK_DOUBLE_BITWISE_EQ macro. We can just use CHECK_EQ now since casting is (mostly) no longer an issue.
4. Replaced the use of testDoubleWord(id) with bitwise_cast<double>(testWord64(id)) to make it clear that we're comparing against the bit values of testWord64(id).
5. Added a "Completed N tests" message at the end of running all tests. This makes it easy to tell at a glance that testmasm completed successfully versus when it crashed midway in a test. The number of tests also serves as a quick checksum to confirm that we ran the number of tests we expected.

• assembler/testmasm.cpp:

(WTF::printInternal):
(JSC::testSimple):
(JSC::testProbeReadsArgumentRegisters):
(JSC::testProbeWritesArgumentRegisters):
(JSC::testProbePreservesGPRS):
(JSC::testProbeModifiesStackPointer):
(JSC::testProbeModifiesProgramCounter):
(JSC::run):

8:31 AM Changeset in webkit [220743] by Ryan Haddad

• 2 edits in branches/safari-604.1.38.1-branch/LayoutTests

Cherry-pick r219697.

7:16 AM Changeset in webkit [220742] by Michael Catanzaro

• 5 edits in trunk/Source/WebKit

Unreviewed, rolling out r220700.

Broke debug bot

Reverted changeset:

"[CoordGraphics] Simplify CoordinatedGraphicsScene state
updates"
​https://bugs.webkit.org/show_bug.cgi?id=175528
​http://trac.webkit.org/changeset/220700

12:17 AM Changeset in webkit [220741] by Carlos Garcia Campos

• 4 edits in trunk/Source/WebKit

WebDriver: timeout when JavaScript alert is shown in onload handler
​https://bugs.webkit.org/show_bug.cgi?id=175315
<rdar://problem/33788294>

Reviewed by Brian Burg.

When a JavaScript alert is shown in an onload handler, the alert prevents the load from finishing in case of
normal page load strategy, so navigation commands or any other command for which we wait for navigation to
complete end up timing out. There are two selenium tests covering this that are currently timing out:
testShouldHandleAlertOnPageLoad and testShouldHandleAlertOnPageLoadUsingGet. The spec says that in case of page
load timeout we should only fail with timeout error when there isn't an active alert dialog. If the next command
expects an alert it will just work, otherwise it will fail with UnexpectedAlertOpen error when trying to handle
user prompts.

9 Navigation.
​https://w3c.github.io/webdriver/webdriver-spec.html#dfn-wait-for-navigation-to-complete

• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::waitForNavigationToComplete): Do not wait for the timeout when the page is
loading and there's an active alert in case of normal page load strategy.
(WebKit::WebAutomationSession::respondToPendingPageNavigationCallbacksWithTimeout): Respond with timeout unless
the page is showing a JavaScript dialog.
(WebKit::WebAutomationSession::respondToPendingFrameNavigationCallbacksWithTimeout): Ditto.
(WebKit::WebAutomationSession::loadTimerFired): Use respondToPendingPageNavigationCallbacksWithTimeout() and
respondToPendingFrameNavigationCallbacksWithTimeout().
(WebKit::WebAutomationSession::willShowJavaScriptDialog): The page is about to show a JavaScript dialog, so
we wait until the next run loop iteration to give time for the client to show the dialog, then check if page is
loading and the dialog is still present. If that's the case we finish all normal strategy pending navigations.

• UIProcess/Automation/WebAutomationSession.h:
• UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::runJavaScriptAlert): If controlled by automation, notify the session.
(WebKit::WebPageProxy::runJavaScriptConfirm): Ditto.
(WebKit::WebPageProxy::runJavaScriptPrompt): Ditto.
(WebKit::WebPageProxy::runBeforeUnloadConfirmPanel): Ditto.

12:03 AM Changeset in webkit [220740] by Carlos Garcia Campos

• 16 edits in trunk/Source

WebDriver: handle click events on option elements
​https://bugs.webkit.org/show_bug.cgi?id=174710
<rdar://problem/33459305>

Reviewed by Brian Burg.

Source/WebCore:

Export WebCore symbols required by WebKit layer.

• html/HTMLOptGroupElement.h:
• html/HTMLOptionElement.h:

Source/WebDriver:

Option elements are considered as a special case by the specification. When clicking an option element, we
should get its container and use it when scrolling into view and calculating in-view center point instead of the
option element itself. Then, we should not emulate a click, but change the selected status of the option element
like if it were done by a user action, firing the corresponding events. Now we check whether the element is an
option to call selectOptionElement() or performMouseInteraction().

This fixes more than 20 selenium tests.

• CommandResult.cpp:

(WebDriver::CommandResult::CommandResult): Handle ElementNotSelectable protocol error.
(WebDriver::CommandResult::httpStatusCode const): Add ElementNotSelectable.
(WebDriver::CommandResult::errorString const): Ditto.

• CommandResult.h:
• Session.cpp:

(WebDriver::Session::selectOptionElement): Ask automation to select the given option element.
(WebDriver::Session::elementClick): Call selectOptionElement() or performMouseInteraction() depending on whether
the element is an option or not.

• Session.h:

Source/WebKit:

Add selectOptionElement method to automation to select an option element according to the WebDriver
specification.

14.1 Element Click.
​https://w3c.github.io/webdriver/webdriver-spec.html#element-click

• UIProcess/Automation/Automation.json: Add selectOptionElement method and ElementNotSelectable error.
• UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::selectOptionElement):Send SelectOptionElement message to the web process.
(WebKit::WebAutomationSession::didSelectOptionElement): Notify the driver.

• UIProcess/Automation/WebAutomationSession.h:
• UIProcess/Automation/WebAutomationSession.messages.in: Add DidSelectOptionElement message.
• WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::elementContainer): Helper to get the container of an element according to the spec.
(WebKit::WebAutomationSessionProxy::computeElementLayout): Use the container element to scroll the view and
compute the in-view center point.
(WebKit::WebAutomationSessionProxy::selectOptionElement): Use HTMLSelectElement::optionSelectedByUser().

• WebProcess/Automation/WebAutomationSessionProxy.h:
• WebProcess/Automation/WebAutomationSessionProxy.messages.in: Add SelectOptionElement message.