Timeline



Sep 23, 2017:

11:22 PM Changeset in webkit [222431] by achristensen@apple.com
  • 14 edits
    1 add in branches/safari-604-branch

REGRESSION(r214201): WebProcess hangs during policy decisions
https://bugs.webkit.org/show_bug.cgi?id=177411
<rdar://problem/33362929>

Reviewed by Geoffrey Garen.

Source/WebKit:

decidePolicyForNavigationAction and decidePolicyForNavigationResponse used to have
a shortcut path for if you called the decisionHandler synchronously and a different path
for asynchronous decisionHandler calling. r214201 made it so there is one path but the
WebProcess hangs, which prevents us from executing JavaScript in the WebProcess where we
could before. This patch effectively reverts r214201 on the branch and pipes the WebsitePolicies
through the asynchronous decisionHandler path to be used only for decidePolicyForNavigationAction,
which is the only such callback that can set the WebsitePolicies.

This patch is for the safari-604-branch branch. I'll fix this problem on trunk by making all
policy messages async and using different message types for each policy check, and then I'll
get this same API test working on trunk.

  • UIProcess/API/C/WKPage.cpp:

(WKPageSetPageNavigationClient):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForResponseSync):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebPageProxy.messages.in:
  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::applyToDocumentLoader):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchWillSubmitForm):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::setUpPolicyListener):
(WebKit::WebFrame::invalidatePolicyListener):
(WebKit::WebFrame::didReceivePolicyDecision):

  • WebProcess/WebPage/WebFrame.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didReceivePolicyDecision):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/WebPage.messages.in:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit2Cocoa/JavaScriptDuringNavigation.mm: Added.

(-[JSNavigationDelegate webView:didFinishNavigation:]):
(-[JSNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):
(-[JSNavigationDelegate webView:decidePolicyForNavigationResponse:decisionHandler:]):
(-[JSNavigationDelegate webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST):

8:53 PM Changeset in webkit [222430] by commit-queue@webkit.org
  • 37 edits
    3 adds
    1 delete in trunk/Source/ThirdParty/libwebrtc

Export libwebrtc symbols through an export file
https://bugs.webkit.org/show_bug.cgi?id=177344

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-23
Reviewed by Darin Adler.

Removing export changes made to libwebrtc.
Exporting based on libwebrtc.exp file.

  • Configurations/Base.xcconfig:
  • Configurations/libwebrtc.exp: Added.
  • Configurations/libwebrtc.xcconfig:
  • Source/webrtc/api/jsep.h:

(): Deleted.

  • Source/webrtc/api/mediatypes.h:
  • Source/webrtc/api/peerconnectioninterface.h:
  • Source/webrtc/api/rtcerror.h:
  • Source/webrtc/api/stats/rtcstats.h:
  • Source/webrtc/api/stats/rtcstatsreport.h:

(): Deleted.

  • Source/webrtc/api/video/i420_buffer.h:
  • Source/webrtc/api/video/video_frame.h:

(): Deleted.

  • Source/webrtc/api/video/video_frame_buffer.h:
  • Source/webrtc/base/asyncpacketsocket.h:
  • Source/webrtc/base/asyncresolverinterface.h:

(): Deleted.

  • Source/webrtc/base/checks.h:

(): Deleted.

  • Source/webrtc/base/copyonwritebuffer.h:

(): Deleted.

  • Source/webrtc/base/event.h:

(): Deleted.

  • Source/webrtc/base/export.h: Removed.
  • Source/webrtc/base/helpers.h:
  • Source/webrtc/base/ipaddress.h:
  • Source/webrtc/base/location.h:

(): Deleted.

  • Source/webrtc/base/logging.h:
  • Source/webrtc/base/messagehandler.h:
  • Source/webrtc/base/network.h:
  • Source/webrtc/base/proxyinfo.h:
  • Source/webrtc/base/socketaddress.h:

(): Deleted.

  • Source/webrtc/base/thread.h:
  • Source/webrtc/common_video/include/i420_buffer_pool.h:

(): Deleted.

  • Source/webrtc/common_video/include/video_frame_buffer.h:

(): Deleted.

  • Source/webrtc/common_video/libyuv/include/webrtc_libyuv.h:
  • Source/webrtc/media/engine/webrtcvideoencoderfactory.h:

(): Deleted.

  • Source/webrtc/p2p/base/basicpacketsocketfactory.h:

(): Deleted.

  • Source/webrtc/p2p/client/basicportallocator.h:
  • Source/webrtc/pc/mediastream.h:
  • Source/webrtc/sdk/objc/Framework/Classes/Video/corevideo_frame_buffer.h:

(): Deleted.

  • Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/encoder.h:

(): Deleted.

  • Source/webrtc/sdk/objc/Framework/Classes/VideoToolbox/videocodecfactory.h:

(): Deleted.

  • libwebrtc.xcodeproj/project.pbxproj:
7:38 PM Changeset in webkit [222429] by commit-queue@webkit.org
  • 68 edits in trunk/Source/WebCore

Remove SetterMayThrowException
https://bugs.webkit.org/show_bug.cgi?id=177408

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-23
Reviewed by Sam Weinig.

No change of behavior.

Updating IDLs to remove SetterMayThrowException as it is no longer needed.
Updating AttributeSetter to compute the return type using Functor.

  • Modules/indexeddb/IDBIndex.idl:
  • Modules/indexeddb/IDBObjectStore.idl:
  • Modules/mediasource/MediaSource.idl:
  • Modules/mediasource/SourceBuffer.idl:
  • Modules/mediastream/RTCDataChannel.idl:
  • Modules/webaudio/AnalyserNode.idl:
  • Modules/webaudio/AudioNode.idl:
  • Modules/webaudio/ConvolverNode.idl:
  • Modules/webaudio/OscillatorNode.idl:
  • Modules/websockets/WebSocket.idl:
  • bindings/js/JSDOMAttribute.h:

(WebCore::AttributeSetter::call):
(WebCore::AttributeSetter<ExceptionOr<void>>::call): Deleted.
(WebCore::AttributeSetter<void>::call): Deleted.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributeSetterBodyDefinition):

  • bindings/scripts/IDLAttributes.json:
  • bindings/scripts/test/JS/JSTestCEReactions.cpp:
  • bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
  • bindings/scripts/test/JS/JSTestCallTracer.cpp:
  • bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:
  • bindings/scripts/test/JS/JSTestGlobalObject.cpp:
  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestNode.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestSerialization.cpp:
  • bindings/scripts/test/JS/JSTestSerializationInherit.cpp:
  • bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:
  • bindings/scripts/test/JS/JSTestTypedefs.cpp:
  • bindings/scripts/test/TestObj.idl:
  • bindings/scripts/test/TestTypedefs.idl:
  • css/CSSRule.idl:
  • css/CSSStyleDeclaration.idl:
  • css/DeprecatedCSSOMValue.idl:
  • css/FontFace.idl:
  • css/MediaList.idl:
  • dom/Document.idl:
  • dom/Element.idl:
  • dom/Node.idl:
  • dom/ShadowRoot.idl:
  • html/DOMURL.idl:
  • html/HTMLElement.idl:
  • html/HTMLInputElement.idl:
  • html/HTMLMarqueeElement.idl:
  • html/HTMLMediaElement.idl:
  • html/HTMLOptionsCollection.idl:
  • html/HTMLSelectElement.idl:
  • html/HTMLTableElement.idl:
  • html/HTMLTextAreaElement.idl:
  • html/MediaController.idl:
  • html/track/VTTCue.idl:
  • html/track/VTTRegion.idl:
  • page/History.idl:
  • page/Location.idl:
  • svg/SVGAltGlyphElement.idl:
  • svg/SVGAngle.idl:
  • svg/SVGAnimatedBoolean.idl:
  • svg/SVGAnimatedEnumeration.idl:
  • svg/SVGAnimatedInteger.idl:
  • svg/SVGAnimatedNumber.idl:
  • svg/SVGAnimatedString.idl:
  • svg/SVGLength.idl:
  • svg/SVGMatrix.idl:
  • svg/SVGNumber.idl:
  • svg/SVGPoint.idl:
  • svg/SVGPreserveAspectRatio.idl:
  • svg/SVGRect.idl:
  • svg/SVGViewSpec.idl:
  • xml/XMLHttpRequest.idl:
5:46 PM Changeset in webkit [222428] by keith_miller@apple.com
  • 3 edits in trunk/JSTests

Fix infinite looping test262 test
https://bugs.webkit.org/show_bug.cgi?id=177412

Reviewed by Yusuke Suzuki.

This test was poorly designed since failing it would cause the vm
to inifinite loop. I've fixed it locally and will fix it on github pending
the results of next weeks tc39 meeting.

  • test262.yaml:
  • test262/test/language/statements/for-of/iterator-next-reference.js:
2:05 PM Changeset in webkit [222427] by commit-queue@webkit.org
  • 5 edits in trunk/Source

Images may render partial frames even after loading all the encoded data
https://bugs.webkit.org/show_bug.cgi?id=177406

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2017-09-23
Reviewed by Simon Fraser.

Source/WebCore:

Because we do not want to block the main thread waiting for the image decoding
thread to terminate, we let the decoding thread finish its work even it will
be thrown away. If a new decoding thread is created and the SynchronizedFixedQueue
is reopened, the terminating decoding thread might have the chance to process
a new frame request. After it finishes decoding it, it realize that it is
terminating so it will drop the decoded frame to the floor. So the new request
was not processed by the new thread and because it was processed by the
terminating thread, nothing will be reported to the BitmapImage object and
the renderer will not be repainted.

The fix is to create a new SynchronizedFixedQueue every time a decoding
thread is created. This will guarantee that the terminating thread won't
have access to the new frame request and will shut down after being notified
by the old SynchronizedFixedQueue that it has been closed.

  • platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::frameRequestQueue):
(WebCore::ImageFrameCache::startAsyncDecodingQueue):
(WebCore::ImageFrameCache::requestFrameAsyncDecodingAtIndex):
(WebCore::ImageFrameCache::stopAsyncDecodingQueue):

  • platform/graphics/ImageFrameCache.h:

Source/WTF:

Make it possible to create a RefPtr<SynchronizedFixedQueue>.

  • wtf/SynchronizedFixedQueue.h:

(WTF::SynchronizedFixedQueue::create):
(WTF::SynchronizedFixedQueue::enqueue):
(WTF::SynchronizedFixedQueue::dequeue):

12:17 PM Changeset in webkit [222426] by Michael Catanzaro
  • 2 edits in trunk/Tools

Unreviewed Mac CMake build fixup after r222194

  • DumpRenderTree/PlatformMac.cmake:
8:05 AM Changeset in webkit [222425] by gskachkov@gmail.com
  • 6 edits in trunk/Source/JavaScriptCore

[ESNext] Async iteration - Implement Async Generator - optimization
https://bugs.webkit.org/show_bug.cgi?id=175891

Reviewed by Yusuke Suzuki.

Add small optimization for async generators:

  1. merging async generator queue to async generator itself

generator.@first / generator.@last is enough, by doing so,

we remove one unnecessary object alloc.

  1. merging request with queue.
  • builtins/AsyncGeneratorPrototype.js:

(globalPrivate.asyncGeneratorQueueIsEmpty):
(globalPrivate.asyncGeneratorQueueCreateItem):
(globalPrivate.asyncGeneratorQueueEnqueue):
(globalPrivate.asyncGeneratorQueueDequeue):
(globalPrivate.asyncGeneratorDequeue):
(globalPrivate.isSuspendYieldState):
(globalPrivate.asyncGeneratorEnqueue):

  • builtins/BuiltinNames.h:
  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitPutAsyncGeneratorFields):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::FunctionNode::emitBytecode):

4:01 AM Changeset in webkit [222424] by commit-queue@webkit.org
  • 4 edits in trunk

test262: $.agent became $262.agent in test262 update
https://bugs.webkit.org/show_bug.cgi?id=177407

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-23
Reviewed by Yusuke Suzuki.

JSTests:

  • test262.yaml:

~320 tests pass now that we correctly make $262 available.

Source/JavaScriptCore:

  • jsc.cpp:

(GlobalObject::finishCreation):
Alias $ and $262 for now.

Sep 22, 2017:

11:57 PM Changeset in webkit [222423] by Antti Koivisto
  • 14 edits
    8 deletes in trunk/LayoutTests

Remove tests for CSS Regions
https://bugs.webkit.org/show_bug.cgi?id=177348

Reviewed by Sam Weinig.

  • TestExpectations:
  • compositing/regions: Removed.
  • compositing/regions/abs-in-named-flow-from-fixed-in-named-flow-expected.txt: Removed.
  • compositing/regions/abs-in-named-flow-from-fixed-in-named-flow.html: Removed.
  • compositing/regions/abs-transformed-dynamic-update-expected.html: Removed.
  • compositing/regions/abs-transformed-dynamic-update.html: Removed.
  • compositing/regions/composited-content-fixed-region-scrolled-expected.txt: Removed.
  • compositing/regions/composited-content-fixed-region-scrolled.html: Removed.
  • compositing/regions/crash-transform-inside-region-expected.html: Removed.
  • compositing/regions/crash-transform-inside-region.html: Removed.
  • compositing/regions/fixed-empty-region-scrolled-expected.txt: Removed.
  • compositing/regions/fixed-empty-region-scrolled.html: Removed.
  • compositing/regions/fixed-in-diff-named-flows-zIndex-expected.html: Removed.
  • compositing/regions/fixed-in-diff-named-flows-zIndex.html: Removed.
  • compositing/regions/fixed-in-named-flow-clip-descendant-expected.txt: Removed.
  • compositing/regions/fixed-in-named-flow-clip-descendant.html: Removed.
  • compositing/regions/fixed-in-named-flow-expected.txt: Removed.
  • compositing/regions/fixed-in-named-flow-from-abs-in-named-flow-expected.txt: Removed.
  • compositing/regions/fixed-in-named-flow-from-abs-in-named-flow.html: Removed.
  • compositing/regions/fixed-in-named-flow-from-outflow-expected.txt: Removed.
  • compositing/regions/fixed-in-named-flow-from-outflow.html: Removed.
  • compositing/regions/fixed-in-named-flow-got-transformed-parent-expected.txt: Removed.
  • compositing/regions/fixed-in-named-flow-got-transformed-parent.html: Removed.
  • compositing/regions/fixed-in-named-flow-lost-transformed-parent-expected.txt: Removed.
  • compositing/regions/fixed-in-named-flow-lost-transformed-parent.html: Removed.
  • compositing/regions/fixed-in-named-flow-overlap-composited-expected.txt: Removed.
  • compositing/regions/fixed-in-named-flow-overlap-composited.html: Removed.
  • compositing/regions/fixed-in-named-flow-position-changed-expected.html: Removed.
  • compositing/regions/fixed-in-named-flow-position-changed.html: Removed.
  • compositing/regions/fixed-in-named-flow-transformed-parent-expected.txt: Removed.
  • compositing/regions/fixed-in-named-flow-transformed-parent.html: Removed.
  • compositing/regions/fixed-in-named-flow-zIndex-expected.html: Removed.
  • compositing/regions/fixed-in-named-flow-zIndex.html: Removed.
  • compositing/regions/fixed-in-named-flow.html: Removed.
  • compositing/regions/fixed-transformed-in-named-flow-expected.txt: Removed.
  • compositing/regions/fixed-transformed-in-named-flow.html: Removed.
  • compositing/regions/floated-region-with-transformed-child-expected.html: Removed.
  • compositing/regions/floated-region-with-transformed-child.html: Removed.
  • compositing/regions/inline-replaced-transformed-in-region-expected.html: Removed.
  • compositing/regions/inline-replaced-transformed-in-region.html: Removed.
  • compositing/regions/move-layer-from-one-region-to-another-expected.html: Removed.
  • compositing/regions/move-layer-from-one-region-to-another.html: Removed.
  • compositing/regions/paint-inside-composited-region-overflow-hidden-versus-div-expected.html: Removed.
  • compositing/regions/paint-inside-composited-region-overflow-hidden-versus-div.html: Removed.
  • compositing/regions/paint-inside-composited-region-overflow-hidden-versus-region-expected.html: Removed.
  • compositing/regions/paint-inside-composited-region-overflow-hidden-versus-region.html: Removed.
  • compositing/regions/position-layer-inside-overflow-hidden-expected.html: Removed.
  • compositing/regions/position-layer-inside-overflow-hidden.html: Removed.
  • compositing/regions/position-layer-inside-region-overflow-hidden-expected.html: Removed.
  • compositing/regions/position-layer-inside-region-overflow-hidden.html: Removed.
  • compositing/regions/position-layers-inside-region-overflow-hidden-expected.html: Removed.
  • compositing/regions/position-layers-inside-region-overflow-hidden.html: Removed.
  • compositing/regions/position-layers-inside-regions-overflow-hidden-expected.html: Removed.
  • compositing/regions/position-layers-inside-regions-overflow-hidden.html: Removed.
  • compositing/regions/propagate-region-box-shadow-border-padding-expected.html: Removed.
  • compositing/regions/propagate-region-box-shadow-border-padding-for-video-expected.html: Removed.
  • compositing/regions/propagate-region-box-shadow-border-padding-for-video.html: Removed.
  • compositing/regions/propagate-region-box-shadow-border-padding.html: Removed.
  • compositing/regions/region-as-layer-in-another-flowthread-expected.html: Removed.
  • compositing/regions/region-as-layer-in-another-flowthread.html: Removed.
  • compositing/regions/transform-transparent-positioned-video-inside-region-expected.html: Removed.
  • compositing/regions/transform-transparent-positioned-video-inside-region.html: Removed.
  • compositing/regions/transformed-layer-inside-transformed-layer-expected.html: Removed.
  • compositing/regions/transformed-layer-inside-transformed-layer.html: Removed.
  • compositing/regions/video-in-overflow-region-expected.txt: Removed.
  • compositing/regions/video-in-overflow-region.html: Removed.
  • compositing/regions/webkit-flow-renderer-layer-compositing-expected.html: Removed.
  • compositing/regions/webkit-flow-renderer-layer-compositing.html: Removed.
  • compositing/regions/z-index-expected.html: Removed.
  • compositing/regions/z-index-update-expected.html: Removed.
  • compositing/regions/z-index-update.html: Removed.
  • compositing/regions/z-index.html: Removed.
  • fast/regions: Removed.
  • fast/regions/absolute-in-relative-overflow-expected.html: Removed.
  • fast/regions/absolute-in-relative-overflow.html: Removed.
  • fast/regions/absolute-pos-elem-in-named-flow-expected.txt: Removed.
  • fast/regions/absolute-pos-elem-in-named-flow.html: Removed.
  • fast/regions/absolute-pos-elem-in-region-expected.html: Removed.
  • fast/regions/absolute-pos-elem-in-region.html: Removed.
  • fast/regions/animated-image-in-region-expected.txt: Removed.
  • fast/regions/animated-image-in-region.html: Removed.
  • fast/regions/animation-element-in-region-flowed-to-other-thread-expected.html: Removed.
  • fast/regions/animation-element-in-region-flowed-to-other-thread.html: Removed.
  • fast/regions/assert-flow-thread-compositing-expected.txt: Removed.
  • fast/regions/assert-flow-thread-compositing.html: Removed.
  • fast/regions/assert-hit-test-image-expected.txt: Removed.
  • fast/regions/assert-hit-test-image.html: Removed.
  • fast/regions/assert-hit-test-multicol-in-region-expected.txt: Removed.
  • fast/regions/assert-hit-test-multicol-in-region.html: Removed.
  • fast/regions/auto-size: Removed.
  • fast/regions/auto-size/abspos-autoheight-nested-region-expected.txt: Removed.
  • fast/regions/auto-size/abspos-autoheight-nested-region.html: Removed.
  • fast/regions/auto-size/autoheight-abspos-bottom-align-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-abspos-bottom-align.html: Removed.
  • fast/regions/auto-size/autoheight-abspos-region-expected.html: Removed.
  • fast/regions/auto-size/autoheight-abspos-region.html: Removed.
  • fast/regions/auto-size/autoheight-allregions-expected.html: Removed.
  • fast/regions/auto-size/autoheight-allregions-nobreaks-expected.html: Removed.
  • fast/regions/auto-size/autoheight-allregions-nobreaks.html: Removed.
  • fast/regions/auto-size/autoheight-allregions.html: Removed.
  • fast/regions/auto-size/autoheight-break-after-expected.html: Removed.
  • fast/regions/auto-size/autoheight-break-after.html: Removed.
  • fast/regions/auto-size/autoheight-breakafteralways-maxheight-expected.html: Removed.
  • fast/regions/auto-size/autoheight-breakafteralways-maxheight.html: Removed.
  • fast/regions/auto-size/autoheight-breakbefore-wrongheight-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-breakbefore-wrongheight.html: Removed.
  • fast/regions/auto-size/autoheight-breakbeforealways-expected.html: Removed.
  • fast/regions/auto-size/autoheight-breakbeforealways.html: Removed.
  • fast/regions/auto-size/autoheight-correct-region-for-lines-2-expected.html: Removed.
  • fast/regions/auto-size/autoheight-correct-region-for-lines-2.html: Removed.
  • fast/regions/auto-size/autoheight-correct-region-for-lines-expected.html: Removed.
  • fast/regions/auto-size/autoheight-correct-region-for-lines.html: Removed.
  • fast/regions/auto-size/autoheight-definedheight-changenotdetected-expected.html: Removed.
  • fast/regions/auto-size/autoheight-definedheight-changenotdetected.html: Removed.
  • fast/regions/auto-size/autoheight-dynamic-update-expected.html: Removed.
  • fast/regions/auto-size/autoheight-dynamic-update.html: Removed.
  • fast/regions/auto-size/autoheight-firstregion-breakalways-expected.html: Removed.
  • fast/regions/auto-size/autoheight-firstregion-breakalways.html: Removed.
  • fast/regions/auto-size/autoheight-flexbox-expected.html: Removed.
  • fast/regions/auto-size/autoheight-flexbox.html: Removed.
  • fast/regions/auto-size/autoheight-floatright-region-expected.html: Removed.
  • fast/regions/auto-size/autoheight-floatright-region.html: Removed.
  • fast/regions/auto-size/autoheight-horizontal-bt-expected.html: Removed.
  • fast/regions/auto-size/autoheight-horizontal-bt.html: Removed.
  • fast/regions/auto-size/autoheight-inlineblock-normalflow-region-expected.html: Removed.
  • fast/regions/auto-size/autoheight-inlineblock-normalflow-region.html: Removed.
  • fast/regions/auto-size/autoheight-lastregion-overflowauto-breaksignored-expected.html: Removed.
  • fast/regions/auto-size/autoheight-lastregion-overflowauto-breaksignored.html: Removed.
  • fast/regions/auto-size/autoheight-lastregion-overflowauto-expected.html: Removed.
  • fast/regions/auto-size/autoheight-lastregion-overflowauto.html: Removed.
  • fast/regions/auto-size/autoheight-maxheight-mixed-break-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-maxheight-mixed-break.html: Removed.
  • fast/regions/auto-size/autoheight-maxheight-region-expected.html: Removed.
  • fast/regions/auto-size/autoheight-maxheight-region.html: Removed.
  • fast/regions/auto-size/autoheight-maxheight-simple-break-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-maxheight-simple-break.html: Removed.
  • fast/regions/auto-size/autoheight-maxheight-simple-nobreak-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-maxheight-simple-nobreak.html: Removed.
  • fast/regions/auto-size/autoheight-middleregion-expected.html: Removed.
  • fast/regions/auto-size/autoheight-middleregion.html: Removed.
  • fast/regions/auto-size/autoheight-minheight-region-expected.html: Removed.
  • fast/regions/auto-size/autoheight-minheight-region.html: Removed.
  • fast/regions/auto-size/autoheight-minmaxheight-mixed-break-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-minmaxheight-mixed-break-hbt-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-minmaxheight-mixed-break-hbt.html: Removed.
  • fast/regions/auto-size/autoheight-minmaxheight-mixed-break-vlr-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-minmaxheight-mixed-break-vlr.html: Removed.
  • fast/regions/auto-size/autoheight-minmaxheight-mixed-break-vrl-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-minmaxheight-mixed-break-vrl.html: Removed.
  • fast/regions/auto-size/autoheight-minmaxheight-mixed-break.html: Removed.
  • fast/regions/auto-size/autoheight-minmaxheight-simple-break-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-minmaxheight-simple-break.html: Removed.
  • fast/regions/auto-size/autoheight-minmaxheight-simple-nobreak-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-minmaxheight-simple-nobreak.html: Removed.
  • fast/regions/auto-size/autoheight-mixed-nested-complex-regions-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-mixed-nested-complex-regions.html: Removed.
  • fast/regions/auto-size/autoheight-mixed-nested-regions-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-mixed-nested-regions.html: Removed.
  • fast/regions/auto-size/autoheight-mixed-parallel-regions-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-mixed-parallel-regions.html: Removed.
  • fast/regions/auto-size/autoheight-nested-regions-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-nested-regions.html: Removed.
  • fast/regions/auto-size/autoheight-normalflow-region-expected.html: Removed.
  • fast/regions/auto-size/autoheight-normalflow-region.html: Removed.
  • fast/regions/auto-size/autoheight-region-decrease-maxheight-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-region-decrease-maxheight.html: Removed.
  • fast/regions/auto-size/autoheight-region-decrease-minheight-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-region-decrease-minheight.html: Removed.
  • fast/regions/auto-size/autoheight-region-decrease-width-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-region-decrease-width.html: Removed.
  • fast/regions/auto-size/autoheight-region-increase-maxheight-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-region-increase-maxheight.html: Removed.
  • fast/regions/auto-size/autoheight-region-increase-minheight-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-region-increase-minheight.html: Removed.
  • fast/regions/auto-size/autoheight-region-increase-width-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-region-increase-width.html: Removed.
  • fast/regions/auto-size/autoheight-region-new-maxheight-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-region-new-maxheight-vrl-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-region-new-maxheight-vrl.html: Removed.
  • fast/regions/auto-size/autoheight-region-new-maxheight.html: Removed.
  • fast/regions/auto-size/autoheight-region-new-minheight-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-region-new-minheight-vlr-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-region-new-minheight-vlr.html: Removed.
  • fast/regions/auto-size/autoheight-region-new-minheight.html: Removed.
  • fast/regions/auto-size/autoheight-region-remove-maxheight-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-region-remove-maxheight.html: Removed.
  • fast/regions/auto-size/autoheight-region-remove-minheight-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-region-remove-minheight.html: Removed.
  • fast/regions/auto-size/autoheight-region-valid-from-invalid-expected.html: Removed.
  • fast/regions/auto-size/autoheight-region-valid-from-invalid.html: Removed.
  • fast/regions/auto-size/autoheight-regions-mark.html: Removed.
  • fast/regions/auto-size/autoheight-secondregion-breakoutside-expected.html: Removed.
  • fast/regions/auto-size/autoheight-secondregion-breakoutside.html: Removed.
  • fast/regions/auto-size/autoheight-secondregion-expected.html: Removed.
  • fast/regions/auto-size/autoheight-secondregion.html: Removed.
  • fast/regions/auto-size/autoheight-singleregion-breakafteralways-expected.html: Removed.
  • fast/regions/auto-size/autoheight-singleregion-breakafteralways-maxheight-expected.html: Removed.
  • fast/regions/auto-size/autoheight-singleregion-breakafteralways-maxheight.html: Removed.
  • fast/regions/auto-size/autoheight-singleregion-breakafteralways.html: Removed.
  • fast/regions/auto-size/autoheight-singleregion-breakaftermargin-expected.html: Removed.
  • fast/regions/auto-size/autoheight-singleregion-breakaftermargin.html: Removed.
  • fast/regions/auto-size/autoheight-singleregion-breakbeforealways-expected.html: Removed.
  • fast/regions/auto-size/autoheight-singleregion-breakbeforealways-minheight-expected.html: Removed.
  • fast/regions/auto-size/autoheight-singleregion-breakbeforealways-minheight.html: Removed.
  • fast/regions/auto-size/autoheight-singleregion-breakbeforealways.html: Removed.
  • fast/regions/auto-size/autoheight-singleregion-multiplebreaks-expected.html: Removed.
  • fast/regions/auto-size/autoheight-singleregion-multiplebreaks.html: Removed.
  • fast/regions/auto-size/autoheight-singleregion-overflowauto-breaksignored-expected.html: Removed.
  • fast/regions/auto-size/autoheight-singleregion-overflowauto-breaksignored.html: Removed.
  • fast/regions/auto-size/autoheight-singleregion-overflowauto-expected.html: Removed.
  • fast/regions/auto-size/autoheight-singleregion-overflowauto.html: Removed.
  • fast/regions/auto-size/autoheight-two-pass-layout-complex-001-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-two-pass-layout-complex-001.html: Removed.
  • fast/regions/auto-size/autoheight-two-pass-layout-complex-002-expected.txt: Removed.
  • fast/regions/auto-size/autoheight-two-pass-layout-complex-002.html: Removed.
  • fast/regions/auto-size/autoheight-vertical-lr-expected.html: Removed.
  • fast/regions/auto-size/autoheight-vertical-lr.html: Removed.
  • fast/regions/auto-size/autoheight-vertical-rl-expected.html: Removed.
  • fast/regions/auto-size/autoheight-vertical-rl.html: Removed.
  • fast/regions/auto-size/autosize-abspos-anchoredregion-expected.txt: Removed.
  • fast/regions/auto-size/autosize-abspos-anchoredregion-vertlr-expected.txt: Removed.
  • fast/regions/auto-size/autosize-abspos-anchoredregion-vertlr.html: Removed.
  • fast/regions/auto-size/autosize-abspos-anchoredregion.html: Removed.
  • fast/regions/auto-size/autosize-region-container-resize-expected.html: Removed.
  • fast/regions/auto-size/autosize-region-container-resize.html: Removed.
  • fast/regions/auto-size/autosize-region-window-resize-expected.html: Removed.
  • fast/regions/auto-size/autosize-region-window-resize.html: Removed.
  • fast/regions/auto-size/autowidth-abspos-expected.html: Removed.
  • fast/regions/auto-size/autowidth-abspos-regionchain-expected.html: Removed.
  • fast/regions/auto-size/autowidth-abspos-regionchain.html: Removed.
  • fast/regions/auto-size/autowidth-abspos.html: Removed.
  • fast/regions/auto-size/autowidth-attachedinvalidregion-expected.txt: Removed.
  • fast/regions/auto-size/autowidth-attachedinvalidregion.html: Removed.
  • fast/regions/auto-size/autowidth-float-expected.html: Removed.
  • fast/regions/auto-size/autowidth-float.html: Removed.
  • fast/regions/auto-size/autowidth-inlineblock-expected.html: Removed.
  • fast/regions/auto-size/autowidth-inlineblock.html: Removed.
  • fast/regions/auto-size/autowidth-nonreplaced-abspos-expected.html: Removed.
  • fast/regions/auto-size/autowidth-nonreplaced-abspos.html: Removed.
  • fast/regions/auto-size/autowidth-nonreplacedblock-normalflow-expected.html: Removed.
  • fast/regions/auto-size/autowidth-nonreplacedblock-normalflow.html: Removed.
  • fast/regions/auto-size/autowidth-normalflow-expected.html: Removed.
  • fast/regions/auto-size/autowidth-normalflow-maxwidth-expected.html: Removed.
  • fast/regions/auto-size/autowidth-normalflow-maxwidth.html: Removed.
  • fast/regions/auto-size/autowidth-normalflow-minmaxwidth-expected.html: Removed.
  • fast/regions/auto-size/autowidth-normalflow-minmaxwidth.html: Removed.
  • fast/regions/auto-size/autowidth-normalflow-minwidth-expected.html: Removed.
  • fast/regions/auto-size/autowidth-normalflow-minwidth.html: Removed.
  • fast/regions/auto-size/autowidth-normalflow-vertrl-expected.html: Removed.
  • fast/regions/auto-size/autowidth-normalflow-vertrl.html: Removed.
  • fast/regions/auto-size/autowidth-normalflow.html: Removed.
  • fast/regions/auto-size/region-height-auto-to-defined-expected.txt: Removed.
  • fast/regions/auto-size/region-height-auto-to-defined.html: Removed.
  • fast/regions/auto-size/region-height-defined-to-auto-expected.txt: Removed.
  • fast/regions/auto-size/region-height-defined-to-auto.html: Removed.
  • fast/regions/auto-size/region-same-height-as-div-with-inline-child-expected.txt: Removed.
  • fast/regions/auto-size/region-same-height-as-div-with-inline-child.html: Removed.
  • fast/regions/bottom-overflow-out-of-first-region-absolute-expected.html: Removed.
  • fast/regions/bottom-overflow-out-of-first-region-absolute.html: Removed.
  • fast/regions/bottom-overflow-out-of-first-region-expected.html: Removed.
  • fast/regions/bottom-overflow-out-of-first-region.html: Removed.
  • fast/regions/box-decorations-over-region-padding-expected.html: Removed.
  • fast/regions/box-decorations-over-region-padding-fragmented-expected.html: Removed.
  • fast/regions/box-decorations-over-region-padding-fragmented.html: Removed.
  • fast/regions/box-decorations-over-region-padding-horiz-bt-expected.html: Removed.
  • fast/regions/box-decorations-over-region-padding-horiz-bt.html: Removed.
  • fast/regions/box-decorations-over-region-padding-vert-lr-expected.html: Removed.
  • fast/regions/box-decorations-over-region-padding-vert-lr.html: Removed.
  • fast/regions/box-decorations-over-region-padding-vert-rl-expected.html: Removed.
  • fast/regions/box-decorations-over-region-padding-vert-rl.html: Removed.
  • fast/regions/box-decorations-over-region-padding.html: Removed.
  • fast/regions/br-content-node-crash-expected.txt: Removed.
  • fast/regions/br-content-node-crash.xhtml: Removed.
  • fast/regions/clip-to-padding-box-expected.html: Removed.
  • fast/regions/clip-to-padding-box-margins-expected.html: Removed.
  • fast/regions/clip-to-padding-box-margins.html: Removed.
  • fast/regions/clip-to-padding-box-vertical-lr-expected.html: Removed.
  • fast/regions/clip-to-padding-box-vertical-lr.html: Removed.
  • fast/regions/clip-to-padding-box.html: Removed.
  • fast/regions/collapse-anonymous-region-expected.html: Removed.
  • fast/regions/collapse-anonymous-region.html: Removed.
  • fast/regions/collect-html-in-named-flow-expected.txt: Removed.
  • fast/regions/collect-html-in-named-flow.html: Removed.
  • fast/regions/content-flowed-into-pseudo-regions-expected.html: Removed.
  • fast/regions/content-flowed-into-pseudo-regions.html: Removed.
  • fast/regions/content-flowed-into-regions-dynamically-added-expected.html: Removed.
  • fast/regions/content-flowed-into-regions-dynamically-added.html: Removed.
  • fast/regions/content-flowed-into-regions-dynamically-inserted-expected.html: Removed.
  • fast/regions/content-flowed-into-regions-dynamically-inserted.html: Removed.
  • fast/regions/content-flowed-into-regions-dynamically-removed-expected.html: Removed.
  • fast/regions/content-flowed-into-regions-dynamically-removed.html: Removed.
  • fast/regions/content-flowed-into-regions-expected.html: Removed.
  • fast/regions/content-flowed-into-regions-no-scroll-expected.txt: Removed.
  • fast/regions/content-flowed-into-regions-no-scroll.html: Removed.
  • fast/regions/content-flowed-into-regions.html: Removed.
  • fast/regions/content-relative-next-tile-expected.html: Removed.
  • fast/regions/content-relative-next-tile.html: Removed.
  • fast/regions/counters: Removed.
  • fast/regions/counters/extract-list-items-001-expected.html: Removed.
  • fast/regions/counters/extract-list-items-001.html: Removed.
  • fast/regions/counters/extract-list-items-002-expected.html: Removed.
  • fast/regions/counters/extract-list-items-002.html: Removed.
  • fast/regions/counters/extract-list-items-003-expected.html: Removed.
  • fast/regions/counters/extract-list-items-003.html: Removed.
  • fast/regions/counters/extract-list-items-004-expected.html: Removed.
  • fast/regions/counters/extract-list-items-004.html: Removed.
  • fast/regions/counters/extract-list-items-005-expected.html: Removed.
  • fast/regions/counters/extract-list-items-005.html: Removed.
  • fast/regions/counters/extract-list-items-006-expected.html: Removed.
  • fast/regions/counters/extract-list-items-006.html: Removed.
  • fast/regions/counters/extract-list-items-007-expected.html: Removed.
  • fast/regions/counters/extract-list-items-007.html: Removed.
  • fast/regions/counters/extract-list-items-008-expected.html: Removed.
  • fast/regions/counters/extract-list-items-008.html: Removed.
  • fast/regions/counters/extract-list-items-009-expected.html: Removed.
  • fast/regions/counters/extract-list-items-009.html: Removed.
  • fast/regions/counters/extract-list-items-010-expected.html: Removed.
  • fast/regions/counters/extract-list-items-010.html: Removed.
  • fast/regions/counters/extract-list-items-011-expected.html: Removed.
  • fast/regions/counters/extract-list-items-011.html: Removed.
  • fast/regions/counters/extract-list-items-012-expected.html: Removed.
  • fast/regions/counters/extract-list-items-012.html: Removed.
  • fast/regions/counters/extract-list-items-013-expected.html: Removed.
  • fast/regions/counters/extract-list-items-013.html: Removed.
  • fast/regions/counters/extract-list-items-014-expected.html: Removed.
  • fast/regions/counters/extract-list-items-014.html: Removed.
  • fast/regions/counters/extract-list-items-015-expected.html: Removed.
  • fast/regions/counters/extract-list-items-015.html: Removed.
  • fast/regions/counters/extract-numbered-paragraphs-divs-001-expected.html: Removed.
  • fast/regions/counters/extract-numbered-paragraphs-divs-001.html: Removed.
  • fast/regions/counters/extract-numbered-paragraphs-divs-002-expected.html: Removed.
  • fast/regions/counters/extract-numbered-paragraphs-divs-002.html: Removed.
  • fast/regions/counters/extract-numbered-paragraphs-expected.html: Removed.
  • fast/regions/counters/extract-numbered-paragraphs.html: Removed.
  • fast/regions/counters/extract-numbered-spans-display-only-some-expected.html: Removed.
  • fast/regions/counters/extract-numbered-spans-display-only-some.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-001-expected.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-001.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-002-expected.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-002.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-003-expected.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-003.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001-expected.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-001.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002-expected.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-002.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003-expected.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-003.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004-expected.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-004.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005-expected.html: Removed.
  • fast/regions/counters/extract-ordered-lists-in-regions-explicit-counters-005.html: Removed.
  • fast/regions/counters/extract-unordered-lists-in-regions-expected.html: Removed.
  • fast/regions/counters/extract-unordered-lists-in-regions.html: Removed.
  • fast/regions/crash-div-outside-body-vertical-rl-expected.html: Removed.
  • fast/regions/crash-div-outside-body-vertical-rl.html: Removed.
  • fast/regions/crash-reflow-inline-content-in-variable-width-regions-expected.txt: Removed.
  • fast/regions/crash-reflow-inline-content-in-variable-width-regions.html: Removed.
  • fast/regions/crash-when-renderer-is-in-multiple-selection-subtrees-expected.txt: Removed.
  • fast/regions/crash-when-renderer-is-in-multiple-selection-subtrees.html: Removed.
  • fast/regions/crash-when-renderer-is-in-multiple-selection-subtrees2-expected.txt: Removed.
  • fast/regions/crash-when-renderer-is-in-multiple-selection-subtrees2.html: Removed.
  • fast/regions/cssom: Removed.
  • fast/regions/cssom/client-rects-fixed-content-expected.txt: Removed.
  • fast/regions/cssom/client-rects-fixed-content.html: Removed.
  • fast/regions/cssom/client-rects-forced-breaks-expected.txt: Removed.
  • fast/regions/cssom/client-rects-forced-breaks.html: Removed.
  • fast/regions/cssom/client-rects-inline-complex-expected.txt: Removed.
  • fast/regions/cssom/client-rects-inline-complex.html: Removed.
  • fast/regions/cssom/client-rects-inline-expected.txt: Removed.
  • fast/regions/cssom/client-rects-inline.html: Removed.
  • fast/regions/cssom/client-rects-nested-regions-expected.txt: Removed.
  • fast/regions/cssom/client-rects-nested-regions.html: Removed.
  • fast/regions/cssom/client-rects-positioned-expected.txt: Removed.
  • fast/regions/cssom/client-rects-positioned.html: Removed.
  • fast/regions/cssom/client-rects-relative-position-expected.txt: Removed.
  • fast/regions/cssom/client-rects-relative-position.html: Removed.
  • fast/regions/cssom/client-rects-simple-block-expected.txt: Removed.
  • fast/regions/cssom/client-rects-simple-block.html: Removed.
  • fast/regions/cssom/client-rects-transforms-expected.txt: Removed.
  • fast/regions/cssom/client-rects-transforms.html: Removed.
  • fast/regions/cssom/client-rects-unsplittable-float-expected.txt: Removed.
  • fast/regions/cssom/client-rects-unsplittable-float.html: Removed.
  • fast/regions/cssom/element-region-overset-state-expected.txt: Removed.
  • fast/regions/cssom/element-region-overset-state-negative-letter-spacing-expected.txt: Removed.
  • fast/regions/cssom/element-region-overset-state-negative-letter-spacing.html: Removed.
  • fast/regions/cssom/element-region-overset-state-vertical-rl-expected.txt: Removed.
  • fast/regions/cssom/element-region-overset-state-vertical-rl-negative-letter-spacing-expected.txt: Removed.
  • fast/regions/cssom/element-region-overset-state-vertical-rl-negative-letter-spacing.html: Removed.
  • fast/regions/cssom/element-region-overset-state-vertical-rl.html: Removed.
  • fast/regions/cssom/element-region-overset-state.html: Removed.
  • fast/regions/cssom/flowed-content-bounding-client-rect-expected.txt: Removed.
  • fast/regions/cssom/flowed-content-bounding-client-rect-horizontal-bt-expected.txt: Removed.
  • fast/regions/cssom/flowed-content-bounding-client-rect-horizontal-bt.html: Removed.
  • fast/regions/cssom/flowed-content-bounding-client-rect-vertical-expected.txt: Removed.
  • fast/regions/cssom/flowed-content-bounding-client-rect-vertical-rl-expected.txt: Removed.
  • fast/regions/cssom/flowed-content-bounding-client-rect-vertical-rl.html: Removed.
  • fast/regions/cssom/flowed-content-bounding-client-rect-vertical.html: Removed.
  • fast/regions/cssom/flowed-content-bounding-client-rect.html: Removed.
  • fast/regions/cssom/flowed-content-transform-bounding-client-rect-expected.txt: Removed.
  • fast/regions/cssom/flowed-content-transform-bounding-client-rect.html: Removed.
  • fast/regions/cssom/flowed-inline-content-bounding-client-rect-expected.txt: Removed.
  • fast/regions/cssom/flowed-inline-content-bounding-client-rect.html: Removed.
  • fast/regions/cssom/get-region-flow-ranges-absolute-pos-expected.txt: Removed.
  • fast/regions/cssom/get-region-flow-ranges-absolute-pos.html: Removed.
  • fast/regions/cssom/get-region-flow-ranges-content-nodes-expected.txt: Removed.
  • fast/regions/cssom/get-region-flow-ranges-content-nodes.html: Removed.
  • fast/regions/cssom/get-region-flow-ranges-display-none-expected.txt: Removed.
  • fast/regions/cssom/get-region-flow-ranges-display-none.html: Removed.
  • fast/regions/cssom/get-region-flow-ranges-empty-regions-expected.txt: Removed.
  • fast/regions/cssom/get-region-flow-ranges-empty-regions.html: Removed.
  • fast/regions/cssom/get-region-flow-ranges-expected.txt: Removed.
  • fast/regions/cssom/get-region-flow-ranges-fixed-pos-expected.txt: Removed.
  • fast/regions/cssom/get-region-flow-ranges-fixed-pos.html: Removed.
  • fast/regions/cssom/get-region-flow-ranges-horiz-bt-expected.txt: Removed.
  • fast/regions/cssom/get-region-flow-ranges-horiz-bt.html: Removed.
  • fast/regions/cssom/get-region-flow-ranges-inline-only-expected.txt: Removed.
  • fast/regions/cssom/get-region-flow-ranges-inline-only.html: Removed.
  • fast/regions/cssom/get-region-flow-ranges-inline-svg-expected.txt: Removed.
  • fast/regions/cssom/get-region-flow-ranges-inline-svg.html: Removed.
  • fast/regions/cssom/get-region-flow-ranges-text-expected.txt: Removed.
  • fast/regions/cssom/get-region-flow-ranges-text-vert-lr-expected.txt: Removed.
  • fast/regions/cssom/get-region-flow-ranges-text-vert-lr.html: Removed.
  • fast/regions/cssom/get-region-flow-ranges-text.html: Removed.
  • fast/regions/cssom/get-region-flow-ranges-vert-lr-expected.txt: Removed.
  • fast/regions/cssom/get-region-flow-ranges-vert-lr.html: Removed.
  • fast/regions/cssom/get-region-flow-ranges-vert-rl-expected.txt: Removed.
  • fast/regions/cssom/get-region-flow-ranges-vert-rl.html: Removed.
  • fast/regions/cssom/get-region-flow-ranges-writing-modes-rl-rb-lr-expected.txt: Removed.
  • fast/regions/cssom/get-region-flow-ranges-writing-modes-rl-rb-lr.html: Removed.
  • fast/regions/cssom/get-region-flow-ranges-writing-modes-tb-rl-lr-expected.txt: Removed.
  • fast/regions/cssom/get-region-flow-ranges-writing-modes-tb-rl-lr.html: Removed.
  • fast/regions/cssom/get-region-flow-ranges.html: Removed.
  • fast/regions/cssom/get-regions-by-content-expected.txt: Removed.
  • fast/regions/cssom/get-regions-by-content-horiz-bt-expected.txt: Removed.
  • fast/regions/cssom/get-regions-by-content-horiz-bt.html: Removed.
  • fast/regions/cssom/get-regions-by-content-horiz-tb-expected.txt: Removed.
  • fast/regions/cssom/get-regions-by-content-horiz-tb.html: Removed.
  • fast/regions/cssom/get-regions-by-content-pseudo-expected.txt: Removed.
  • fast/regions/cssom/get-regions-by-content-pseudo.html: Removed.
  • fast/regions/cssom/get-regions-by-content-vert-lr-expected.txt: Removed.
  • fast/regions/cssom/get-regions-by-content-vert-lr.html: Removed.
  • fast/regions/cssom/get-regions-by-content-vert-rl-expected.txt: Removed.
  • fast/regions/cssom/get-regions-by-content-vert-rl.html: Removed.
  • fast/regions/cssom/get-regions-by-content.html: Removed.
  • fast/regions/cssom/get-regions-by-content2-expected.txt: Removed.
  • fast/regions/cssom/get-regions-by-content2.html: Removed.
  • fast/regions/cssom/offsetLeft-offsetTop-in-multiple-regions-expected.txt: Removed.
  • fast/regions/cssom/offsetLeft-offsetTop-in-multiple-regions.html: Removed.
  • fast/regions/cssom/offsetLeft-offsetTop-in-region-absolute-sticky-fixed-expected.txt: Removed.
  • fast/regions/cssom/offsetLeft-offsetTop-in-region-absolute-sticky-fixed.html: Removed.
  • fast/regions/cssom/offsetLeft-offsetTop-in-region-float-expected.txt: Removed.
  • fast/regions/cssom/offsetLeft-offsetTop-in-region-float-vert-rl-expected.txt: Removed.
  • fast/regions/cssom/offsetLeft-offsetTop-in-region-float-vert-rl.html: Removed.
  • fast/regions/cssom/offsetLeft-offsetTop-in-region-float.html: Removed.
  • fast/regions/cssom/offsetLeft-offsetTop-inlines-region-in-element-expected.txt: Removed.
  • fast/regions/cssom/offsetLeft-offsetTop-inlines-region-in-element.html: Removed.
  • fast/regions/cssom/offsetParent-body-in-flow-thread-expected.txt: Removed.
  • fast/regions/cssom/offsetParent-body-in-flow-thread.html: Removed.
  • fast/regions/cssom/offsetParent-in-flow-thread-expected.txt: Removed.
  • fast/regions/cssom/offsetParent-in-flow-thread.html: Removed.
  • fast/regions/cssom/overset-break-expected.txt: Removed.
  • fast/regions/cssom/overset-break-nested-expected.txt: Removed.
  • fast/regions/cssom/overset-break-nested.html: Removed.
  • fast/regions/cssom/overset-break-with-sibling-expected.txt: Removed.
  • fast/regions/cssom/overset-break-with-sibling.html: Removed.
  • fast/regions/cssom/overset-break.html: Removed.
  • fast/regions/cssom/region-range-for-box-crash-expected.txt: Removed.
  • fast/regions/cssom/region-range-for-box-crash.html: Removed.
  • fast/regions/cssom/webkit-named-flow-collection-crash-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-collection-crash.html: Removed.
  • fast/regions/cssom/webkit-named-flow-collection-empty-getters-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-collection-empty-getters.html: Removed.
  • fast/regions/cssom/webkit-named-flow-collection-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-collection.html: Removed.
  • fast/regions/cssom/webkit-named-flow-event-add-to-flow-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-event-add-to-flow.html: Removed.
  • fast/regions/cssom/webkit-named-flow-event-auto-height-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-event-auto-height.html: Removed.
  • fast/regions/cssom/webkit-named-flow-event-crash-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-event-crash.html: Removed.
  • fast/regions/cssom/webkit-named-flow-event-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-event-no-regions-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-event-no-regions.html: Removed.
  • fast/regions/cssom/webkit-named-flow-event-region-in-flexbox-no-overset-change-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-event-region-in-flexbox-no-overset-change.html: Removed.
  • fast/regions/cssom/webkit-named-flow-event-region-in-flexbox-overset-change-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-event-region-in-flexbox-overset-change.html: Removed.
  • fast/regions/cssom/webkit-named-flow-event-remove-from-dom-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-event-remove-from-dom.html: Removed.
  • fast/regions/cssom/webkit-named-flow-event-remove-from-flow-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-event-remove-from-flow.html: Removed.
  • fast/regions/cssom/webkit-named-flow-event-target-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-event-target.html: Removed.
  • fast/regions/cssom/webkit-named-flow-event-to-null-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-event-to-null.html: Removed.
  • fast/regions/cssom/webkit-named-flow-event.html: Removed.
  • fast/regions/cssom/webkit-named-flow-existing-flow-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-existing-flow.html: Removed.
  • fast/regions/cssom/webkit-named-flow-first-empty-region-index-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-first-empty-region-index.html: Removed.
  • fast/regions/cssom/webkit-named-flow-flow-added-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-flow-added.html: Removed.
  • fast/regions/cssom/webkit-named-flow-get-content-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-get-content.html: Removed.
  • fast/regions/cssom/webkit-named-flow-get-regions-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-get-regions-pseudo-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-get-regions-pseudo.html: Removed.
  • fast/regions/cssom/webkit-named-flow-get-regions.html: Removed.
  • fast/regions/cssom/webkit-named-flow-invalid-name-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-invalid-name.html: Removed.
  • fast/regions/cssom/webkit-named-flow-modified-flow-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-modified-flow.html: Removed.
  • fast/regions/cssom/webkit-named-flow-name-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-name.html: Removed.
  • fast/regions/cssom/webkit-named-flow-non-existing-flow-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-non-existing-flow.html: Removed.
  • fast/regions/cssom/webkit-named-flow-overset-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-overset.html: Removed.
  • fast/regions/cssom/webkit-named-flow-removed-flow-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-removed-flow.html: Removed.
  • fast/regions/cssom/webkit-named-flow-same-object-expected.txt: Removed.
  • fast/regions/cssom/webkit-named-flow-same-object.html: Removed.
  • fast/regions/detaching-regions-with-anonymous-blocks-expected.txt: Removed.
  • fast/regions/detaching-regions-with-anonymous-blocks.html: Removed.
  • fast/regions/drag-scrollbars-of-content-expected.html: Removed.
  • fast/regions/drag-scrollbars-of-content.html: Removed.
  • fast/regions/flexbox-in-region-crash-expected.txt: Removed.
  • fast/regions/flexbox-in-region-crash.html: Removed.
  • fast/regions/float-pushed-width-change-2-expected.html: Removed.
  • fast/regions/float-pushed-width-change-2.html: Removed.
  • fast/regions/float-pushed-width-change-expected.html: Removed.
  • fast/regions/float-pushed-width-change.html: Removed.
  • fast/regions/float-slicing-on-forced-break-expected.html: Removed.
  • fast/regions/float-slicing-on-forced-break.html: Removed.
  • fast/regions/floats-basic-in-variable-width-regions-expected.html: Removed.
  • fast/regions/floats-basic-in-variable-width-regions.html: Removed.
  • fast/regions/flow-anonymous-children-expected.txt: Removed.
  • fast/regions/flow-anonymous-children.html: Removed.
  • fast/regions/flow-body-in-html-expected.txt: Removed.
  • fast/regions/flow-body-in-html.html: Removed.
  • fast/regions/flow-content-basic-expected.html: Removed.
  • fast/regions/flow-content-basic-vertical-expected.html: Removed.
  • fast/regions/flow-content-basic-vertical-rl-expected.html: Removed.
  • fast/regions/flow-content-basic-vertical-rl.html: Removed.
  • fast/regions/flow-content-basic-vertical.html: Removed.
  • fast/regions/flow-content-basic.html: Removed.
  • fast/regions/flow-fixed-element-transformed-parent-expected.txt: Removed.
  • fast/regions/flow-fixed-element-transformed-parent.html: Removed.
  • fast/regions/flow-fragment-as-anonymous-block-crash-expected.txt: Removed.
  • fast/regions/flow-fragment-as-anonymous-block-crash.html: Removed.
  • fast/regions/flow-region-into-itself-crash-expected.txt: Removed.
  • fast/regions/flow-region-into-itself-crash.html: Removed.
  • fast/regions/flows-dependency-dynamic-remove.html: Removed.
  • fast/regions/flows-dependency-same-flow.html: Removed.
  • fast/regions/flowthread-getranges-box-cast-expected.txt: Removed.
  • fast/regions/flowthread-getranges-box-cast.html: Removed.
  • fast/regions/forced-break-inside-avoid-break-expected.txt: Removed.
  • fast/regions/forced-break-inside-avoid-break.html: Removed.
  • fast/regions/fragmentation-after-float-overflow-single-region-expected.html: Removed.
  • fast/regions/fragmentation-after-float-overflow-single-region.html: Removed.
  • fast/regions/fragmentation-after-monolithic-overflow-expected.html: Removed.
  • fast/regions/fragmentation-after-monolithic-overflow-self-collapsed-expected.html: Removed.
  • fast/regions/fragmentation-after-monolithic-overflow-self-collapsed.html: Removed.
  • fast/regions/fragmentation-after-monolithic-overflow-single-region-expected.html: Removed.
  • fast/regions/fragmentation-after-monolithic-overflow-single-region.html: Removed.
  • fast/regions/fragmentation-after-monolithic-overflow.html: Removed.
  • fast/regions/frame-view-overflow-scroll-expected.html: Removed.
  • fast/regions/frame-view-overflow-scroll.html: Removed.
  • fast/regions/fullscreen: Removed.
  • fast/regions/fullscreen/full-screen-video-from-region-expected.txt: Removed.
  • fast/regions/fullscreen/full-screen-video-from-region.html: Removed.
  • fast/regions/fullscreen/full-screen-video-in-region-crash-expected.txt: Removed.
  • fast/regions/fullscreen/full-screen-video-in-region-crash.html: Removed.
  • fast/regions/generated-content: Removed.
  • fast/regions/generated-content/firstletter-inside-flowthread-expected.html: Removed.
  • fast/regions/generated-content/firstletter-inside-flowthread.html: Removed.
  • fast/regions/generated-content/pseudo-after-content-node-expected.txt: Removed.
  • fast/regions/generated-content/pseudo-after-content-node.html: Removed.
  • fast/regions/generated-content/pseudo-before-content-node-expected.txt: Removed.
  • fast/regions/generated-content/pseudo-before-content-node.html: Removed.
  • fast/regions/generated-content/pseudo-first-letter-content-node-expected.txt: Removed.
  • fast/regions/generated-content/pseudo-first-letter-content-node.html: Removed.
  • fast/regions/generated-content/pseudo-first-line-content-node-expected.txt: Removed.
  • fast/regions/generated-content/pseudo-first-line-content-node.html: Removed.
  • fast/regions/hidpi-region-with-auto-margin-on-subpixel-position-expected.html: Removed.
  • fast/regions/hidpi-region-with-auto-margin-on-subpixel-position.html: Removed.
  • fast/regions/hit-test-abspos-overflow-region-expected.txt: Removed.
  • fast/regions/hit-test-abspos-overflow-region.html: Removed.
  • fast/regions/hit-test-box-non-containing-region-expected.txt: Removed.
  • fast/regions/hit-test-box-non-containing-region.html: Removed.
  • fast/regions/hit-test-float-expected.txt: Removed.
  • fast/regions/hit-test-float.html: Removed.
  • fast/regions/hit-test-region-expected.txt: Removed.
  • fast/regions/hit-test-region-preserve3d-container-expected.txt: Removed.
  • fast/regions/hit-test-region-preserve3d-container.html: Removed.
  • fast/regions/hit-test-region.html: Removed.
  • fast/regions/hover-and-js-in-visual-overflow-expected.html: Removed.
  • fast/regions/hover-and-js-in-visual-overflow-hidden-expected.html: Removed.
  • fast/regions/hover-and-js-in-visual-overflow-hidden.html: Removed.
  • fast/regions/hover-and-js-in-visual-overflow.html: Removed.
  • fast/regions/hover-content-inside-iframe-in-region-expected.html: Removed.
  • fast/regions/hover-content-inside-iframe-in-region.html: Removed.
  • fast/regions/hover-element-flowed-second-region-expected.html: Removed.
  • fast/regions/hover-element-flowed-second-region.html: Removed.
  • fast/regions/hover-in-region-grandparent-expected.txt: Removed.
  • fast/regions/hover-in-region-grandparent.html: Removed.
  • fast/regions/hover-in-region-parent-skip-inlines-anonymous-expected.txt: Removed.
  • fast/regions/hover-in-region-parent-skip-inlines-anonymous.html: Removed.
  • fast/regions/hover-in-second-region-expected.html: Removed.
  • fast/regions/hover-in-second-region.html: Removed.
  • fast/regions/hover-on-child-in-region-expected.txt: Removed.
  • fast/regions/hover-on-child-in-region-in-region-expected.txt: Removed.
  • fast/regions/hover-on-child-in-region-in-region.html: Removed.
  • fast/regions/hover-on-child-in-region.html: Removed.
  • fast/regions/hover-on-child-parent-different-regions-expected.txt: Removed.
  • fast/regions/hover-on-child-parent-different-regions.html: Removed.
  • fast/regions/hover-overflow-hidden-expected.html: Removed.
  • fast/regions/hover-overflow-hidden.html: Removed.
  • fast/regions/hover-single-flow-from-none-expected.html: Removed.
  • fast/regions/hover-single-flow-from-none-overflow-expected.html: Removed.
  • fast/regions/hover-single-flow-from-none-overflow-top-expected.html: Removed.
  • fast/regions/hover-single-flow-from-none-overflow-top.html: Removed.
  • fast/regions/hover-single-flow-from-none-overflow.html: Removed.
  • fast/regions/hover-single-flow-from-none.html: Removed.
  • fast/regions/hover-single-flow-from-other-expected.html: Removed.
  • fast/regions/hover-single-flow-from-other.html: Removed.
  • fast/regions/hover-single-flow-into-none-expected.html: Removed.
  • fast/regions/hover-single-flow-into-none.html: Removed.
  • fast/regions/hover-single-flow-into-other-expected.html: Removed.
  • fast/regions/hover-single-flow-into-other.html: Removed.
  • fast/regions/iframe-html-collected.html: Removed.
  • fast/regions/imbricated-flow-threads-crash-expected.txt: Removed.
  • fast/regions/imbricated-flow-threads-crash.html: Removed.
  • fast/regions/inline-block-flowed-in-regions-expected.html: Removed.
  • fast/regions/inline-block-flowed-in-regions.html: Removed.
  • fast/regions/inline-block-inline-children-flowed-in-regions-expected.html: Removed.
  • fast/regions/inline-block-inline-children-flowed-in-regions.html: Removed.
  • fast/regions/inline-block-inside-anonymous-overflow-expected.html: Removed.
  • fast/regions/inline-block-inside-anonymous-overflow-with-covered-controls-expected.html: Removed.
  • fast/regions/inline-block-inside-anonymous-overflow-with-covered-controls.html: Removed.
  • fast/regions/inline-block-inside-anonymous-overflow.html: Removed.
  • fast/regions/inline-block-overflow-expected.html: Removed.
  • fast/regions/inline-block-overflow.html: Removed.
  • fast/regions/inline-block-shifted-region-expected.txt: Removed.
  • fast/regions/inline-block-shifted-region.html: Removed.
  • fast/regions/inline-blocks-dyn-enlarged-regions-expected.html: Removed.
  • fast/regions/inline-blocks-dyn-enlarged-regions.html: Removed.
  • fast/regions/inline-blocks-dyn-shrunk-regions-expected.html: Removed.
  • fast/regions/inline-blocks-dyn-shrunk-regions.html: Removed.
  • fast/regions/inline-blocks-in-two-regions-expected.html: Removed.
  • fast/regions/inline-blocks-in-two-regions.html: Removed.
  • fast/regions/inline-strike-through-expected.txt: Removed.
  • fast/regions/inline-strike-through.html: Removed.
  • fast/regions/inlineblock-child-inlineblock-contentnode-in-region-expected.html: Removed.
  • fast/regions/inlineblock-child-inlineblock-contentnode-in-region.html: Removed.
  • fast/regions/input-box-with-region-assert-expected.txt: Removed.
  • fast/regions/input-box-with-region-assert.html: Removed.
  • fast/regions/intrinsic-sized-regions-expected.txt: Removed.
  • fast/regions/intrinsic-sized-regions.html: Removed.
  • fast/regions/last-region-border-radius-expected.html: Removed.
  • fast/regions/last-region-border-radius.html: Removed.
  • fast/regions/layers: Removed.
  • fast/regions/layers/float-region-promoted-to-layer-expected.html: Removed.
  • fast/regions/layers/float-region-promoted-to-layer.html: Removed.
  • fast/regions/layers/region-normalflow-stacking-context-expected.html: Removed.
  • fast/regions/layers/region-normalflow-stacking-context.html: Removed.
  • fast/regions/layers/region-removed-during-animation-expected.html: Removed.
  • fast/regions/layers/region-removed-during-animation.html: Removed.
  • fast/regions/layers/region-zIndex-computedStyle-expected.txt: Removed.
  • fast/regions/layers/region-zIndex-computedStyle.html: Removed.
  • fast/regions/layers/stacking-context-paint-order-expected.html: Removed.
  • fast/regions/layers/stacking-context-paint-order.html: Removed.
  • fast/regions/line-containing-region-crash-expected.txt: Removed.
  • fast/regions/line-containing-region-crash.html: Removed.
  • fast/regions/list-item-as-region-expected.html: Removed.
  • fast/regions/list-item-as-region.html: Removed.
  • fast/regions/listmarker-inside-flowthread-expected.html: Removed.
  • fast/regions/listmarker-inside-flowthread.html: Removed.
  • fast/regions/mathml-crash-expected.txt: Removed.
  • fast/regions/mathml-crash.html: Removed.
  • fast/regions/move-anonymous-block-inside-named-flow-crash-expected.txt: Removed.
  • fast/regions/move-anonymous-block-inside-named-flow-crash.html: Removed.
  • fast/regions/moved-content-node-crash-expected.txt: Removed.
  • fast/regions/moved-content-node-crash.html: Removed.
  • fast/regions/multicol: Removed.
  • fast/regions/multicol/multicol-as-region-prevented-expected.html: Removed.
  • fast/regions/multicol/multicol-as-region-prevented.html: Removed.
  • fast/regions/multicol/nested-multicol-into-region-dynamic-expected.txt: Removed.
  • fast/regions/multicol/nested-multicol-into-region-dynamic.html: Removed.
  • fast/regions/multicol/regions-in-multicol-bt-expected.html: Removed.
  • fast/regions/multicol/regions-in-multicol-bt.html: Removed.
  • fast/regions/multicol/regions-in-multicol-expected.html: Removed.
  • fast/regions/multicol/regions-in-multicol-hover-expected.html: Removed.
  • fast/regions/multicol/regions-in-multicol-hover-overflow-expected.html: Removed.
  • fast/regions/multicol/regions-in-multicol-hover-overflow.html: Removed.
  • fast/regions/multicol/regions-in-multicol-hover.html: Removed.
  • fast/regions/multicol/regions-in-multicol-lr-expected.html: Removed.
  • fast/regions/multicol/regions-in-multicol-lr.html: Removed.
  • fast/regions/multicol/regions-in-multicol-rl-expected.html: Removed.
  • fast/regions/multicol/regions-in-multicol-rl.html: Removed.
  • fast/regions/multicol/regions-in-multicol.html: Removed.
  • fast/regions/multiple-directionality-changes-in-variable-width-regions.html: Removed.
  • fast/regions/named-flow-content-order-1-expected.html: Removed.
  • fast/regions/named-flow-content-order-1.html: Removed.
  • fast/regions/named-flow-content-order-2-expected.html: Removed.
  • fast/regions/named-flow-content-order-2.html: Removed.
  • fast/regions/named-flow-content-order-3-expected.html: Removed.
  • fast/regions/named-flow-content-order-3.html: Removed.
  • fast/regions/nested-floated-region-expected.html: Removed.
  • fast/regions/nested-floated-region.html: Removed.
  • fast/regions/no-split-line-box-expected.txt: Removed.
  • fast/regions/no-split-line-box.html: Removed.
  • fast/regions/outline-sides-in-region-expected.html: Removed.
  • fast/regions/outline-sides-in-region.html: Removed.
  • fast/regions/overflow: Removed.
  • fast/regions/overflow/overflow-3dtransformed-region-expected.txt: Removed.
  • fast/regions/overflow/overflow-3dtransformed-region.html: Removed.
  • fast/regions/overflow/overflow-auto-after-float-expected.html: Removed.
  • fast/regions/overflow/overflow-auto-after-float.html: Removed.
  • fast/regions/overflow/overflow-content-transform-rotate-expected.html: Removed.
  • fast/regions/overflow/overflow-content-transform-rotate.html: Removed.
  • fast/regions/overflow/overflow-content-zero-height-region-expected.html: Removed.
  • fast/regions/overflow/overflow-content-zero-height-region.html: Removed.
  • fast/regions/overflow/overflow-first-and-last-regions-expected.html: Removed.
  • fast/regions/overflow/overflow-first-and-last-regions-in-container-hidden-expected.html: Removed.
  • fast/regions/overflow/overflow-first-and-last-regions-in-container-hidden.html: Removed.
  • fast/regions/overflow/overflow-first-and-last-regions.html: Removed.
  • fast/regions/overflow/overflow-in-uniform-regions-dynamic-expected.html: Removed.
  • fast/regions/overflow/overflow-in-uniform-regions-dynamic.html: Removed.
  • fast/regions/overflow/overflow-in-uniform-regions-expected.html: Removed.
  • fast/regions/overflow/overflow-in-uniform-regions.html: Removed.
  • fast/regions/overflow/overflow-in-variable-width-regions-expected.html: Removed.
  • fast/regions/overflow/overflow-in-variable-width-regions-inline-bt-expected.html: Removed.
  • fast/regions/overflow/overflow-in-variable-width-regions-inline-bt.html: Removed.
  • fast/regions/overflow/overflow-in-variable-width-regions-inline-continuation-expected.html: Removed.
  • fast/regions/overflow/overflow-in-variable-width-regions-inline-continuation.html: Removed.
  • fast/regions/overflow/overflow-in-variable-width-regions-inline-expected.html: Removed.
  • fast/regions/overflow/overflow-in-variable-width-regions-inline-lr-expected.html: Removed.
  • fast/regions/overflow/overflow-in-variable-width-regions-inline-lr.html: Removed.
  • fast/regions/overflow/overflow-in-variable-width-regions-inline-rl-expected.html: Removed.
  • fast/regions/overflow/overflow-in-variable-width-regions-inline-rl.html: Removed.
  • fast/regions/overflow/overflow-in-variable-width-regions-inline.html: Removed.
  • fast/regions/overflow/overflow-in-variable-width-regions.html: Removed.
  • fast/regions/overflow/overflow-last-region-horiz-bt-expected.html: Removed.
  • fast/regions/overflow/overflow-last-region-horiz-bt.html: Removed.
  • fast/regions/overflow/overflow-last-region-vert-lr-expected.html: Removed.
  • fast/regions/overflow/overflow-last-region-vert-lr.html: Removed.
  • fast/regions/overflow/overflow-last-region-vert-rl-expected.html: Removed.
  • fast/regions/overflow/overflow-last-region-vert-rl.html: Removed.
  • fast/regions/overflow/overflow-moving-below-floats-in-variable-width-regions-expected.html: Removed.
  • fast/regions/overflow/overflow-moving-below-floats-in-variable-width-regions.html: Removed.
  • fast/regions/overflow/overflow-nested-regions-expected.html: Removed.
  • fast/regions/overflow/overflow-nested-regions.html: Removed.
  • fast/regions/overflow/overflow-not-moving-below-floats-in-variable-width-regions-expected.html: Removed.
  • fast/regions/overflow/overflow-not-moving-below-floats-in-variable-width-regions.html: Removed.
  • fast/regions/overflow/overflow-region-float-expected.html: Removed.
  • fast/regions/overflow/overflow-region-float.html: Removed.
  • fast/regions/overflow/overflow-region-inline-expected.html: Removed.
  • fast/regions/overflow/overflow-region-inline.html: Removed.
  • fast/regions/overflow/overflow-region-transform-expected.html: Removed.
  • fast/regions/overflow/overflow-region-transform.html: Removed.
  • fast/regions/overflow/overflow-rtl-in-variable-width-regions-expected.html: Removed.
  • fast/regions/overflow/overflow-rtl-in-variable-width-regions.html: Removed.
  • fast/regions/overflow/overflow-scrollable-1-expected.html: Removed.
  • fast/regions/overflow/overflow-scrollable-1.html: Removed.
  • fast/regions/overflow/overflow-scrollable-2-expected.html: Removed.
  • fast/regions/overflow/overflow-scrollable-2.html: Removed.
  • fast/regions/overflow/overflow-scrollable-3-expected.html: Removed.
  • fast/regions/overflow/overflow-scrollable-3.html: Removed.
  • fast/regions/overflow/overflow-scrollable-fit-complex-expected.html: Removed.
  • fast/regions/overflow/overflow-scrollable-fit-complex.html: Removed.
  • fast/regions/overflow/overflow-scrollable-fit-expected.html: Removed.
  • fast/regions/overflow/overflow-scrollable-fit.html: Removed.
  • fast/regions/overflow/overflow-scrollable-nested-expected.txt: Removed.
  • fast/regions/overflow/overflow-scrollable-nested.html: Removed.
  • fast/regions/overflow/overflow-scrollable-rel-pos-fragment-expected.html: Removed.
  • fast/regions/overflow/overflow-scrollable-rel-pos-fragment.html: Removed.
  • fast/regions/overflow/overflow-scrollable-rotated-fragment-expected.html: Removed.
  • fast/regions/overflow/overflow-scrollable-rotated-fragment.html: Removed.
  • fast/regions/overflow/overflow-scrollable-unsplittable-fragment-expected.html: Removed.
  • fast/regions/overflow/overflow-scrollable-unsplittable-fragment.html: Removed.
  • fast/regions/overflow/overflow-scrollable-varying-width-1-expected.html: Removed.
  • fast/regions/overflow/overflow-scrollable-varying-width-1.html: Removed.
  • fast/regions/overflow/overflow-scrollable-varying-width-2-expected.html: Removed.
  • fast/regions/overflow/overflow-scrollable-varying-width-2.html: Removed.
  • fast/regions/overflow/overflow-size-change-in-variable-width-regions-expected.html: Removed.
  • fast/regions/overflow/overflow-size-change-in-variable-width-regions.html: Removed.
  • fast/regions/overflow/overflow-size-change-with-stacking-context-expected.html: Removed.
  • fast/regions/overflow/overflow-size-change-with-stacking-context-rtl-expected.html: Removed.
  • fast/regions/overflow/overflow-size-change-with-stacking-context-rtl.html: Removed.
  • fast/regions/overflow/overflow-size-change-with-stacking-context.html: Removed.
  • fast/regions/parsing: Removed.
  • fast/regions/parsing/webkit-flow-from-parsing-expected.txt: Removed.
  • fast/regions/parsing/webkit-flow-from-parsing.html: Removed.
  • fast/regions/parsing/webkit-flow-into-parsing-expected.txt: Removed.
  • fast/regions/parsing/webkit-flow-into-parsing.html: Removed.
  • fast/regions/parsing/webkit-region-fragment-parsing-expected.txt: Removed.
  • fast/regions/parsing/webkit-region-fragment-parsing.html: Removed.
  • fast/regions/percentage-margins-mixed-ltr-dominant-regions-expected.html: Removed.
  • fast/regions/percentage-margins-mixed-ltr-dominant-regions.html: Removed.
  • fast/regions/percentage-margins-mixed-rtl-dominant-regions-expected.html: Removed.
  • fast/regions/percentage-margins-mixed-rtl-dominant-regions.html: Removed.
  • fast/regions/percentage-margins-rtl-variable-width-regions-expected.html: Removed.
  • fast/regions/percentage-margins-rtl-variable-width-regions.html: Removed.
  • fast/regions/percentage-margins-variable-width-regions-expected.html: Removed.
  • fast/regions/percentage-margins-variable-width-regions.html: Removed.
  • fast/regions/position-writing-modes-in-variable-width-regions-expected.html: Removed.
  • fast/regions/position-writing-modes-in-variable-width-regions.html: Removed.
  • fast/regions/positioning: Removed.
  • fast/regions/positioning/fixed-element-transformed-parent-expected.txt: Removed.
  • fast/regions/positioning/fixed-element-transformed-parent.html: Removed.
  • fast/regions/positioning/fixed-in-named-flow-position-changed-expected.html: Removed.
  • fast/regions/positioning/fixed-in-named-flow-position-changed.html: Removed.
  • fast/regions/positioning/fixed-inside-fixed-in-named-flow-expected.html: Removed.
  • fast/regions/positioning/fixed-inside-fixed-in-named-flow.html: Removed.
  • fast/regions/positioning/fixed-inside-named-flow-zIndex-expected.html: Removed.
  • fast/regions/positioning/fixed-inside-named-flow-zIndex.html: Removed.
  • fast/regions/positioning/fixed-pos-content-fragmented-expected.html: Removed.
  • fast/regions/positioning/fixed-pos-content-fragmented.html: Removed.
  • fast/regions/positioning/fixed-pos-elem-in-named-flow-expected.txt: Removed.
  • fast/regions/positioning/fixed-pos-elem-in-named-flow.html: Removed.
  • fast/regions/positioning/fixed-pos-elem-in-named-flow2-expected.txt: Removed.
  • fast/regions/positioning/fixed-pos-elem-in-named-flow2.html: Removed.
  • fast/regions/positioning/fixed-pos-elem-in-namedflow-noregions-expected.html: Removed.
  • fast/regions/positioning/fixed-pos-elem-in-namedflow-noregions.html: Removed.
  • fast/regions/positioning/fixed-pos-elem-in-region-expected.html: Removed.
  • fast/regions/positioning/fixed-pos-elem-in-region.html: Removed.
  • fast/regions/positioning/fixed-pos-region-in-nested-flow-expected.html: Removed.
  • fast/regions/positioning/fixed-pos-region-in-nested-flow.html: Removed.
  • fast/regions/positioning/fixed-pos-region-overflow-content-expected.html: Removed.
  • fast/regions/positioning/fixed-pos-region-overflow-content.html: Removed.
  • fast/regions/positioning/positioned-fragmented-content-expected.html: Removed.
  • fast/regions/positioning/positioned-fragmented-content.html: Removed.
  • fast/regions/positioning/positioned-object-inline-cb-crash-expected.txt: Removed.
  • fast/regions/positioning/positioned-object-inline-cb-crash.html: Removed.
  • fast/regions/positioning/positioned-objects-block-static-in-regions-expected.html: Removed.
  • fast/regions/positioning/positioned-objects-block-static-in-regions.html: Removed.
  • fast/regions/positioning/positioned-objects-block-static-in-rtl-regions-expected.html: Removed.
  • fast/regions/positioning/positioned-objects-block-static-in-rtl-regions.html: Removed.
  • fast/regions/positioning/positioned-objects-block-static-spanning-regions-expected.html: Removed.
  • fast/regions/positioning/positioned-objects-block-static-spanning-regions-rtl-expected.html: Removed.
  • fast/regions/positioning/positioned-objects-block-static-spanning-regions-rtl.html: Removed.
  • fast/regions/positioning/positioned-objects-block-static-spanning-regions.html: Removed.
  • fast/regions/positioning/positioned-objects-clipped-spanning-regions-expected.html: Removed.
  • fast/regions/positioning/positioned-objects-clipped-spanning-regions.html: Removed.
  • fast/regions/positioning/positioned-objects-in-regions-expected.html: Removed.
  • fast/regions/positioning/positioned-objects-in-regions.html: Removed.
  • fast/regions/positioning/positioned-objects-in-rtl-regions-expected.html: Removed.
  • fast/regions/positioning/positioned-objects-in-rtl-regions.html: Removed.
  • fast/regions/positioning/positioned-objects-inline-static-in-regions-expected.html: Removed.
  • fast/regions/positioning/positioned-objects-inline-static-in-regions.html: Removed.
  • fast/regions/positioning/positioned-objects-inline-static-in-rtl-regions-expected.html: Removed.
  • fast/regions/positioning/positioned-objects-inline-static-in-rtl-regions.html: Removed.
  • fast/regions/positioning/positioned-objects-inline-static-spanning-regions-expected.html: Removed.
  • fast/regions/positioning/positioned-objects-inline-static-spanning-regions-rtl-expected.html: Removed.
  • fast/regions/positioning/positioned-objects-inline-static-spanning-regions-rtl.html: Removed.
  • fast/regions/positioning/positioned-objects-inline-static-spanning-regions.html: Removed.
  • fast/regions/positioning/positioned-objects-perpendicular-flows-in-regions-expected.html: Removed.
  • fast/regions/positioning/positioned-objects-perpendicular-flows-in-regions.html: Removed.
  • fast/regions/positioning/positioned-objects-spanning-regions-expected.html: Removed.
  • fast/regions/positioning/positioned-objects-spanning-regions.html: Removed.
  • fast/regions/positioning/positioned-slider-in-regions-expected.html: Removed.
  • fast/regions/positioning/positioned-slider-in-regions.html: Removed.
  • fast/regions/positioning/positioned-vrl-in-named-flow-expected.txt: Removed.
  • fast/regions/positioning/positioned-vrl-in-named-flow.html: Removed.
  • fast/regions/positioning/positioned-vrl-in-parent-named-flow-expected.txt: Removed.
  • fast/regions/positioning/positioned-vrl-in-parent-named-flow.html: Removed.
  • fast/regions/positioning/positioned-with-vrl-parent-in-named-flow-expected.txt: Removed.
  • fast/regions/positioning/positioned-with-vrl-parent-in-named-flow.html: Removed.
  • fast/regions/region-as-bfc-avoids-float-expected.html: Removed.
  • fast/regions/region-as-bfc-avoids-float.html: Removed.
  • fast/regions/region-attached-wrong-flow-crash-expected.txt: Removed.
  • fast/regions/region-attached-wrong-flow-crash.html: Removed.
  • fast/regions/region-border-radius-overflow-clip-expected.html: Removed.
  • fast/regions/region-border-radius-overflow-clip.html: Removed.
  • fast/regions/region-child-not-flowed-expected.html: Removed.
  • fast/regions/region-child-not-flowed.html: Removed.
  • fast/regions/region-clipping-expected.html: Removed.
  • fast/regions/region-clipping.html: Removed.
  • fast/regions/region-content-flown-into-region-expected.html: Removed.
  • fast/regions/region-content-flown-into-region.html: Removed.
  • fast/regions/region-content-node-child-clone-crash-expected.txt: Removed.
  • fast/regions/region-content-node-child-clone-crash.html: Removed.
  • fast/regions/region-dynamic-after-before.html: Removed.
  • fast/regions/region-element-display-change-expected.txt: Removed.
  • fast/regions/region-element-display-change.html: Removed.
  • fast/regions/region-element-display-restriction-expected.txt: Removed.
  • fast/regions/region-element-display-restriction.html: Removed.
  • fast/regions/region-element-dynamic-attach-flow-expected.txt: Removed.
  • fast/regions/region-element-dynamic-attach-flow.html: Removed.
  • fast/regions/region-element-dynamic-detach-flow-expected.txt: Removed.
  • fast/regions/region-element-dynamic-detach-flow.html: Removed.
  • fast/regions/region-flow-reattach-crash-expected.txt: Removed.
  • fast/regions/region-flow-reattach-crash.html: Removed.
  • fast/regions/region-generated-content-before-after.html: Removed.
  • fast/regions/region-min-max-width-support-expected.txt: Removed.
  • fast/regions/region-min-max-width-support.html: Removed.
  • fast/regions/region-overflow-auto-overflow-hidden-expected.html: Removed.
  • fast/regions/region-overflow-auto-overflow-hidden.html: Removed.
  • fast/regions/region-overflow-auto-overflow-visible-expected.html: Removed.
  • fast/regions/region-overflow-auto-overflow-visible.html: Removed.
  • fast/regions/region-overflow-break-expected.html: Removed.
  • fast/regions/region-overflow-break.html: Removed.
  • fast/regions/region-padding-overflow-hidden-expected.html: Removed.
  • fast/regions/region-padding-overflow-hidden.html: Removed.
  • fast/regions/region-sibling-paint-order-expected.html: Removed.
  • fast/regions/region-sibling-paint-order.html: Removed.
  • fast/regions/region-styling: Removed.
  • fast/regions/region-styling/parse-incomplete-region-rule-expected.txt: Removed.
  • fast/regions/region-styling/parse-incomplete-region-rule.html: Removed.
  • fast/regions/region-styling/parsing-region-style-rule-expected.txt: Removed.
  • fast/regions/region-styling/parsing-region-style-rule.html: Removed.
  • fast/regions/region-styling/region-rule-nested-region-rule-expected.html: Removed.
  • fast/regions/region-styling/region-rule-nested-region-rule.html: Removed.
  • fast/regions/region-styling/region-style-block-background-color-expected.html: Removed.
  • fast/regions/region-styling/region-style-block-background-color.html: Removed.
  • fast/regions/region-styling/region-style-block-background-color2-expected.html: Removed.
  • fast/regions/region-styling/region-style-block-background-color2.html: Removed.
  • fast/regions/region-styling/region-style-color-expected.html: Removed.
  • fast/regions/region-styling/region-style-color.html: Removed.
  • fast/regions/region-styling/region-style-image-background-color-expected.html: Removed.
  • fast/regions/region-styling/region-style-image-background-color.html: Removed.
  • fast/regions/region-styling/region-style-in-columns-expected.html: Removed.
  • fast/regions/region-styling/region-style-in-columns.html: Removed.
  • fast/regions/region-styling/region-style-inline-background-color-expected.html: Removed.
  • fast/regions/region-styling/region-style-inline-background-color.html: Removed.
  • fast/regions/region-styling/region-style-not-supported-properties-expected.html: Removed.
  • fast/regions/region-styling/region-style-not-supported-properties.html: Removed.
  • fast/regions/region-styling/region-style-rule-position-expected.html: Removed.
  • fast/regions/region-styling/region-style-rule-position.html: Removed.
  • fast/regions/region-styling/region-style-rule-specificity-expected.html: Removed.
  • fast/regions/region-styling/region-style-rule-specificity.html: Removed.
  • fast/regions/region-styling/region-styling-mediaquery-expected.html: Removed.
  • fast/regions/region-styling/region-styling-mediaquery.html: Removed.
  • fast/regions/region-styling/region-withstyling-valid-from-invalid-expected.html: Removed.
  • fast/regions/region-styling/region-withstyling-valid-from-invalid.html: Removed.
  • fast/regions/region-styling/remove-leftover-anon-block-crash-expected.txt: Removed.
  • fast/regions/region-styling/remove-leftover-anon-block-crash.html: Removed.
  • fast/regions/region-styling/removed-element-style-in-region-crash-expected.txt: Removed.
  • fast/regions/region-styling/removed-element-style-in-region-crash.html: Removed.
  • fast/regions/region-styling/render-region-custom-style-mark-expected.html: Removed.
  • fast/regions/region-styling/render-region-custom-style-mark.html: Removed.
  • fast/regions/region-styling/set-box-style-in-region-crash-expected.txt: Removed.
  • fast/regions/region-styling/set-box-style-in-region-crash.html: Removed.
  • fast/regions/region-styling/webkit-region-rule-expected.txt: Removed.
  • fast/regions/region-styling/webkit-region-rule.html: Removed.
  • fast/regions/region-visual-overflow-transform-expected.html: Removed.
  • fast/regions/region-visual-overflow-transform.html: Removed.
  • fast/regions/region-width-change-relayout-1-expected.html: Removed.
  • fast/regions/region-width-change-relayout-1.html: Removed.
  • fast/regions/region-width-change-relayout-2-expected.html: Removed.
  • fast/regions/region-width-change-relayout-2.html: Removed.
  • fast/regions/region-width-change-relayout-3-expected.html: Removed.
  • fast/regions/region-width-change-relayout-3.html: Removed.
  • fast/regions/region-with-float-parent-expected.txt: Removed.
  • fast/regions/region-with-float-parent.html: Removed.
  • fast/regions/region-with-multicolumn-embedded-crash-expected.txt: Removed.
  • fast/regions/region-with-multicolumn-embedded-crash.html: Removed.
  • fast/regions/regions-overflow-tile-expected.html: Removed.
  • fast/regions/regions-overflow-tile.html: Removed.
  • fast/regions/regions-widows-and-orphans-expected.txt: Removed.
  • fast/regions/regions-widows-and-orphans.html: Removed.
  • fast/regions/regions-widows-float-top-aligned-expected.html: Removed.
  • fast/regions/regions-widows-float-top-aligned.html: Removed.
  • fast/regions/regions-widows-stack-overflow-expected.html: Removed.
  • fast/regions/regions-widows-stack-overflow.html: Removed.
  • fast/regions/relative-borders-overflow-expected.html: Removed.
  • fast/regions/relative-borders-overflow.html: Removed.
  • fast/regions/relative-in-absolute-borders-overflow-expected.html: Removed.
  • fast/regions/relative-in-absolute-borders-overflow.html: Removed.
  • fast/regions/remove-box-info-assert-expected.txt: Removed.
  • fast/regions/remove-box-info-assert.html: Removed.
  • fast/regions/remove-flow-thread-crash-expected.txt: Removed.
  • fast/regions/remove-flow-thread-crash.html: Removed.
  • fast/regions/render-region-renderer-expected.html: Removed.
  • fast/regions/render-region-renderer.html: Removed.
  • fast/regions/repaint: Removed.
  • fast/regions/repaint/element-in-named-flow-absolute-from-fixed-expected.txt: Removed.
  • fast/regions/repaint/element-in-named-flow-absolute-from-fixed.html: Removed.
  • fast/regions/repaint/element-in-named-flow-fixed-from-absolute-expected.txt: Removed.
  • fast/regions/repaint/element-in-named-flow-fixed-from-absolute.html: Removed.
  • fast/regions/repaint/element-inflow-fixed-from-outflow-static-expected.txt: Removed.
  • fast/regions/repaint/element-inflow-fixed-from-outflow-static.html: Removed.
  • fast/regions/repaint/element-outflow-static-from-inflow-fixed-expected.txt: Removed.
  • fast/regions/repaint/element-outflow-static-from-inflow-fixed.html: Removed.
  • fast/regions/repaint/fixed-in-named-flow-cb-changed-expected.html: Removed.
  • fast/regions/repaint/fixed-in-named-flow-cb-changed.html: Removed.
  • fast/regions/repaint/fixed-in-named-flow-cb-changed2-expected.html: Removed.
  • fast/regions/repaint/fixed-in-named-flow-cb-changed2.html: Removed.
  • fast/regions/repaint/fixed-in-named-flow-scroll-expected.txt: Removed.
  • fast/regions/repaint/fixed-in-named-flow-scroll.html: Removed.
  • fast/regions/repaint/hover-border-radius-expected.txt: Removed.
  • fast/regions/repaint/hover-border-radius.html: Removed.
  • fast/regions/repaint/invalid-region-repaint-crash-expected.txt: Removed.
  • fast/regions/repaint/invalid-region-repaint-crash.html: Removed.
  • fast/regions/repaint/japanese-rl-selection-repaint-in-regions.html: Removed.
  • fast/regions/repaint/line-flow-with-floats-in-regions.html: Removed.
  • fast/regions/repaint/overflow-flipped-writing-mode-block-in-regions.html: Removed.
  • fast/regions/repaint/region-painting-composited-element-expected.html: Removed.
  • fast/regions/repaint/region-painting-composited-element.html: Removed.
  • fast/regions/repaint/region-painting-in-composited-view-expected.html: Removed.
  • fast/regions/repaint/region-painting-in-composited-view.html: Removed.
  • fast/regions/repaint/region-painting-invalidation.html: Removed.
  • fast/regions/repaint/region-painting-via-layout.html: Removed.
  • fast/regions/repaint/repaint-absolute-pushed-to-next-region-expected.txt: Removed.
  • fast/regions/repaint/repaint-absolute-pushed-to-next-region.html: Removed.
  • fast/regions/repaint/repaint-element-inside-relative-region-expected.txt: Removed.
  • fast/regions/repaint/repaint-element-inside-relative-region.html: Removed.
  • fast/regions/repaint/repaint-regions-overflow-expected.txt: Removed.
  • fast/regions/repaint/repaint-regions-overflow.html: Removed.
  • fast/regions/resources: Removed.
  • fast/regions/resources/helper.js: Removed.
  • fast/regions/resources/iframe-in-region-source.html: Removed.
  • fast/regions/resources/ipad.jpg: Removed.
  • fast/regions/resources/region-style.css: Removed.
  • fast/regions/resources/transparent.png: Removed.
  • fast/regions/script-tests: Removed.
  • fast/regions/script-tests/css-regions-disabled.js: Removed.
  • fast/regions/script-tests/webkit-flow-from-parsing.js: Removed.
  • fast/regions/script-tests/webkit-flow-into-parsing.js: Removed.
  • fast/regions/script-tests/webkit-region-fragment-parsing.js: Removed.
  • fast/regions/scrolling: Removed.
  • fast/regions/scrolling/scroll-into-view-expected.html: Removed.
  • fast/regions/scrolling/scroll-into-view-relative-expected.html: Removed.
  • fast/regions/scrolling/scroll-into-view-relative.html: Removed.
  • fast/regions/scrolling/scroll-into-view.html: Removed.
  • fast/regions/scrolling/scrollable-first-region-expected.html: Removed.
  • fast/regions/scrolling/scrollable-first-region.html: Removed.
  • fast/regions/scrolling/scrollable-last-region-expected.html: Removed.
  • fast/regions/scrolling/scrollable-last-region.html: Removed.
  • fast/regions/scrolling/scrollable-paragraph-unsplittable-expected.html: Removed.
  • fast/regions/scrolling/scrollable-paragraph-unsplittable.html: Removed.
  • fast/regions/scrolling/scrollable-region-content-size-expected.html: Removed.
  • fast/regions/scrolling/scrollable-region-content-size-horiz-bt-expected.html: Removed.
  • fast/regions/scrolling/scrollable-region-content-size-horiz-bt.html: Removed.
  • fast/regions/scrolling/scrollable-region-content-size-no-overflow-expected.html: Removed.
  • fast/regions/scrolling/scrollable-region-content-size-no-overflow-horiz-bt-expected.html: Removed.
  • fast/regions/scrolling/scrollable-region-content-size-no-overflow-horiz-bt.html: Removed.
  • fast/regions/scrolling/scrollable-region-content-size-no-overflow-vert-rl-expected.html: Removed.
  • fast/regions/scrolling/scrollable-region-content-size-no-overflow-vert-rl.html: Removed.
  • fast/regions/scrolling/scrollable-region-content-size-no-overflow.html: Removed.
  • fast/regions/scrolling/scrollable-region-content-size-relative-expected.html: Removed.
  • fast/regions/scrolling/scrollable-region-content-size-relative.html: Removed.
  • fast/regions/scrolling/scrollable-region-content-size-vert-rl-expected.html: Removed.
  • fast/regions/scrolling/scrollable-region-content-size-vert-rl.html: Removed.
  • fast/regions/scrolling/scrollable-region-content-size-vertical-lr-expected.html: Removed.
  • fast/regions/scrolling/scrollable-region-content-size-vertical-lr.html: Removed.
  • fast/regions/scrolling/scrollable-region-content-size.html: Removed.
  • fast/regions/scrolling/scrollable-region-scrollable-absolute-content-background-expected.html: Removed.
  • fast/regions/scrolling/scrollable-region-scrollable-absolute-content-background.html: Removed.
  • fast/regions/scrolling/scrollable-region-scrollable-content-background-expected.html: Removed.
  • fast/regions/scrolling/scrollable-region-scrollable-content-background.html: Removed.
  • fast/regions/scrolling/scrollable-region-scrollable-content-expected.html: Removed.
  • fast/regions/scrolling/scrollable-region-scrollable-content.html: Removed.
  • fast/regions/scrolling/scrollable-regions-hit-testing-inside-expected.html: Removed.
  • fast/regions/scrolling/scrollable-regions-hit-testing-inside.html: Removed.
  • fast/regions/scrolling/scrollable-single-region-bt-expected.html: Removed.
  • fast/regions/scrolling/scrollable-single-region-bt.html: Removed.
  • fast/regions/scrolling/scrollable-single-region-expected.html: Removed.
  • fast/regions/scrolling/scrollable-single-region-lr-expected.html: Removed.
  • fast/regions/scrolling/scrollable-single-region-lr.html: Removed.
  • fast/regions/scrolling/scrollable-single-region-relative-element-expected.html: Removed.
  • fast/regions/scrolling/scrollable-single-region-relative-element.html: Removed.
  • fast/regions/scrolling/scrollable-single-region-rl-expected.html: Removed.
  • fast/regions/scrolling/scrollable-single-region-rl.html: Removed.
  • fast/regions/scrolling/scrollable-single-region.html: Removed.
  • fast/regions/scrolling/wheel-scroll-abspos-expected.html: Removed.
  • fast/regions/scrolling/wheel-scroll-abspos.html: Removed.
  • fast/regions/scrolling/wheel-scroll-expected.html: Removed.
  • fast/regions/scrolling/wheel-scroll.html: Removed.
  • fast/regions/scrolling/wheel-scrollable-single-region-expected.html: Removed.
  • fast/regions/scrolling/wheel-scrollable-single-region.html: Removed.
  • fast/regions/select-in-region-crash-expected.txt: Removed.
  • fast/regions/select-in-region-crash.html: Removed.
  • fast/regions/select-multiple-in-region-expected.txt: Removed.
  • fast/regions/select-multiple-in-region.html: Removed.
  • fast/regions/selection: Removed.
  • fast/regions/selection/crash-deselect-expected.txt: Removed.
  • fast/regions/selection/crash-deselect.html: Removed.
  • fast/regions/selection/crash-select-all-expected.txt: Removed.
  • fast/regions/selection/crash-select-all.html: Removed.
  • fast/regions/selection/crash-when-element-is-inside-column-and-the-containing-block-is-inside-flow-expected.txt: Removed.
  • fast/regions/selection/crash-when-element-is-inside-column-and-the-containing-block-is-inside-flow.html: Removed.
  • fast/regions/selection/invalid-region-selection-crash-expected.txt: Removed.
  • fast/regions/selection/invalid-region-selection-crash.html: Removed.
  • fast/regions/selection/position-for-point-1-expected.txt: Removed.
  • fast/regions/selection/position-for-point-1-vert-lr-expected.txt: Removed.
  • fast/regions/selection/position-for-point-1-vert-lr.html: Removed.
  • fast/regions/selection/position-for-point-1-vert-rl-expected.txt: Removed.
  • fast/regions/selection/position-for-point-1-vert-rl.html: Removed.
  • fast/regions/selection/position-for-point-1.html: Removed.
  • fast/regions/selection/position-for-point-expected.txt: Removed.
  • fast/regions/selection/position-for-point-inline-content-node-expected.txt: Removed.
  • fast/regions/selection/position-for-point-inline-content-node.html: Removed.
  • fast/regions/selection/position-for-point-vert-lr-expected.txt: Removed.
  • fast/regions/selection/position-for-point-vert-lr.html: Removed.
  • fast/regions/selection/position-for-point-vert-rl-expected.txt: Removed.
  • fast/regions/selection/position-for-point-vert-rl.html: Removed.
  • fast/regions/selection/position-for-point.html: Removed.
  • fast/regions/selection/select-all-without-regions-expected.txt: Removed.
  • fast/regions/selection/select-all-without-regions.html: Removed.
  • fast/regions/selection/selecting-text-ignoring-region-expected.html: Removed.
  • fast/regions/selection/selecting-text-ignoring-region-horiz-bt-expected.html: Removed.
  • fast/regions/selection/selecting-text-ignoring-region-horiz-bt.html: Removed.
  • fast/regions/selection/selecting-text-ignoring-region-vert-lr-expected.html: Removed.
  • fast/regions/selection/selecting-text-ignoring-region-vert-lr.html: Removed.
  • fast/regions/selection/selecting-text-ignoring-region-vert-rl-expected.html: Removed.
  • fast/regions/selection/selecting-text-ignoring-region-vert-rl.html: Removed.
  • fast/regions/selection/selecting-text-ignoring-region.html: Removed.
  • fast/regions/selection/selecting-text-in-2-regions-expected.html: Removed.
  • fast/regions/selection/selecting-text-in-2-regions-horiz-bt-expected.html: Removed.
  • fast/regions/selection/selecting-text-in-2-regions-horiz-bt.html: Removed.
  • fast/regions/selection/selecting-text-in-2-regions-vert-lr-expected.html: Removed.
  • fast/regions/selection/selecting-text-in-2-regions-vert-lr.html: Removed.
  • fast/regions/selection/selecting-text-in-2-regions-vert-rl-expected.html: Removed.
  • fast/regions/selection/selecting-text-in-2-regions-vert-rl.html: Removed.
  • fast/regions/selection/selecting-text-in-2-regions.html: Removed.
  • fast/regions/selection/selecting-text-in-empty-region-expected.txt: Removed.
  • fast/regions/selection/selecting-text-in-empty-region.html: Removed.
  • fast/regions/selection/selecting-text-including-region-expected.html: Removed.
  • fast/regions/selection/selecting-text-including-region.html: Removed.
  • fast/regions/selection/selecting-text-through-different-region-flows-2-expected.html: Removed.
  • fast/regions/selection/selecting-text-through-different-region-flows-2.html: Removed.
  • fast/regions/selection/selecting-text-through-different-region-flows-expected.html: Removed.
  • fast/regions/selection/selecting-text-through-different-region-flows.html: Removed.
  • fast/regions/selection/selection-direction-expected.html: Removed.
  • fast/regions/selection/selection-direction.html: Removed.
  • fast/regions/selection/selection-ended-in-empty-region-expected.txt: Removed.
  • fast/regions/selection/selection-ended-in-empty-region.html: Removed.
  • fast/regions/selection/selection-gaps-paint-crash-expected.txt: Removed.
  • fast/regions/selection/selection-gaps-paint-crash.html: Removed.
  • fast/regions/selection/selection-in-overflow-expected.html: Removed.
  • fast/regions/selection/selection-in-overflow-hit-testing-expected.html: Removed.
  • fast/regions/selection/selection-in-overflow-hit-testing.html: Removed.
  • fast/regions/selection/selection-in-overflow.html: Removed.
  • fast/regions/selection/selection-in-text-after-overflow-hit-testing-expected.html: Removed.
  • fast/regions/selection/selection-in-text-after-overflow-hit-testing.html: Removed.
  • fast/regions/shape-outside-floats: Removed.
  • fast/regions/shape-outside-floats/regions-shape-outside-content-flows-multiple-regions-expected.html: Removed.
  • fast/regions/shape-outside-floats/regions-shape-outside-content-flows-multiple-regions.html: Removed.
  • fast/regions/shape-outside-floats/regions-shape-outside-floats-inset-expected.html: Removed.
  • fast/regions/shape-outside-floats/regions-shape-outside-floats-inset.html: Removed.
  • fast/regions/shape-outside-floats/regions-shape-outside-region-polygon-floats-expected.html: Removed.
  • fast/regions/shape-outside-floats/regions-shape-outside-region-polygon-floats.html: Removed.
  • fast/regions/simplified-layout-no-regions-expected.txt: Removed.
  • fast/regions/simplified-layout-no-regions.html: Removed.
  • fast/regions/static-in-relative-overflow-expected.html: Removed.
  • fast/regions/static-in-relative-overflow.html: Removed.
  • fast/regions/sticky-border-overflow-expected.html: Removed.
  • fast/regions/sticky-border-overflow.html: Removed.
  • fast/regions/subtree-with-horiz-bt-expected.html: Removed.
  • fast/regions/subtree-with-horiz-bt.html: Removed.
  • fast/regions/subtree-with-horiz-tb-expected.html: Removed.
  • fast/regions/subtree-with-horiz-tb.html: Removed.
  • fast/regions/subtree-with-vert-lr-expected.html: Removed.
  • fast/regions/subtree-with-vert-lr.html: Removed.
  • fast/regions/subtree-with-vert-rl-expected.html: Removed.
  • fast/regions/subtree-with-vert-rl.html: Removed.
  • fast/regions/svg: Removed.
  • fast/regions/svg/svg-doc-fragment-not-collected-expected.html: Removed.
  • fast/regions/svg/svg-doc-fragment-not-collected.html: Removed.
  • fast/regions/svg/svg-element-not-collected-expected.html: Removed.
  • fast/regions/svg/svg-element-not-collected.html: Removed.
  • fast/regions/svg/svg-root-element-collected-expected.txt: Removed.
  • fast/regions/svg/svg-root-element-collected.html: Removed.
  • fast/regions/svg/symbol-in-named-flow-crash-expected.txt: Removed.
  • fast/regions/svg/symbol-in-named-flow-crash.svg: Removed.
  • fast/regions/table-caption-as-region-expected.html: Removed.
  • fast/regions/table-caption-as-region.html: Removed.
  • fast/regions/table-cell-as-region-expected.html: Removed.
  • fast/regions/table-cell-as-region.html: Removed.
  • fast/regions/text-break-properties-expected.txt: Removed.
  • fast/regions/text-break-properties.html: Removed.
  • fast/regions/text-region-breaks-expected.txt: Removed.
  • fast/regions/text-region-breaks.html: Removed.
  • fast/regions/text-region-split-after-resize-expected.txt: Removed.
  • fast/regions/text-region-split-after-resize.html: Removed.
  • fast/regions/text-region-split-expected.txt: Removed.
  • fast/regions/text-region-split-horizontal-bt-expected.txt: Removed.
  • fast/regions/text-region-split-horizontal-bt.html: Removed.
  • fast/regions/text-region-split-small-pagination.html: Removed.
  • fast/regions/text-region-split-vertical-expected.txt: Removed.
  • fast/regions/text-region-split-vertical-rl-expected.txt: Removed.
  • fast/regions/text-region-split-vertical-rl.html: Removed.
  • fast/regions/text-region-split-vertical.html: Removed.
  • fast/regions/text-region-split.html: Removed.
  • fast/regions/top-overflow-out-of-second-region-expected.html: Removed.
  • fast/regions/top-overflow-out-of-second-region.html: Removed.
  • fast/regions/universal-selector-children-to-the-same-region-expected.txt: Removed.
  • fast/regions/universal-selector-children-to-the-same-region.html: Removed.
  • fast/regions/unsplittable-nested-region-expected.html: Removed.
  • fast/regions/unsplittable-nested-region.html: Removed.
  • fast/regions/visibility-hidden-expected.html: Removed.
  • fast/regions/visibility-hidden.html: Removed.
  • fast/regions/webkit-background-clip-text-expected.html: Removed.
  • fast/regions/webkit-background-clip-text.html: Removed.
  • fast/regions/webkit-flow-double-pagination-float-push-expected.html: Removed.
  • fast/regions/webkit-flow-double-pagination-float-push.html: Removed.
  • fast/regions/webkit-flow-float-pushed-to-last-region-expected.html: Removed.
  • fast/regions/webkit-flow-float-pushed-to-last-region.html: Removed.
  • fast/regions/webkit-flow-float-unable-to-push-expected.html: Removed.
  • fast/regions/webkit-flow-float-unable-to-push.html: Removed.
  • fast/regions/webkit-flow-floats-inside-regions-bounds-expected.html: Removed.
  • fast/regions/webkit-flow-floats-inside-regions-bounds.html: Removed.
  • fast/regions/webkit-flow-inlines-dynamic-expected.html: Removed.
  • fast/regions/webkit-flow-inlines-dynamic.html: Removed.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-expected.html: Removed.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-expected.html: Removed.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl-expected.html: Removed.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical-rl.html: Removed.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds-vertical.html: Removed.
  • fast/regions/webkit-flow-inlines-inside-regions-bounds.html: Removed.
  • fast/regions/webkit-flow-renderer-expected.html: Removed.
  • fast/regions/webkit-flow-renderer-layer-expected.html: Removed.
  • fast/regions/webkit-flow-renderer-layer.html: Removed.
  • fast/regions/webkit-flow-renderer-nested-expected.html: Removed.
  • fast/regions/webkit-flow-renderer-nested.html: Removed.
  • fast/regions/webkit-flow-renderer.html: Removed.
  • fast/regions/webkit-region-syntax-space-expected.txt: Removed.
  • fast/regions/webkit-region-syntax-space.html: Removed.
  • fast/regions/writing-mode: Removed.
  • fast/regions/writing-mode/changing-writing-mode-2-expected.html: Removed.
  • fast/regions/writing-mode/changing-writing-mode-2.html: Removed.
  • fast/regions/writing-mode/changing-writing-mode-3-expected.html: Removed.
  • fast/regions/writing-mode/changing-writing-mode-3.html: Removed.
  • fast/regions/writing-mode/changing-writing-mode-4-expected.html: Removed.
  • fast/regions/writing-mode/changing-writing-mode-4.html: Removed.
  • fast/regions/writing-mode/changing-writing-mode-5-expected.html: Removed.
  • fast/regions/writing-mode/changing-writing-mode-5.html: Removed.
  • fast/regions/writing-mode/changing-writing-mode-expected.html: Removed.
  • fast/regions/writing-mode/changing-writing-mode.html: Removed.
  • fast/regions/writing-mode/invalid-first-region-with-writing-mode-2-expected.html: Removed.
  • fast/regions/writing-mode/invalid-first-region-with-writing-mode-2.html: Removed.
  • fast/regions/writing-mode/invalid-first-region-with-writing-mode-expected.html: Removed.
  • fast/regions/writing-mode/invalid-first-region-with-writing-mode.html: Removed.
  • fast/ruby/ruby-rt-with-region-crash-expected.txt: Removed.
  • fast/ruby/ruby-rt-with-region-crash.html: Removed.
  • fast/shapes/shape-outside-floats/shape-outside-floats-layout-after-initial-layout-pass-expected.html: Removed.
  • fast/shapes/shape-outside-floats/shape-outside-floats-layout-after-initial-layout-pass.html: Removed.
  • platform/gtk-wayland/TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/ios-device/TestExpectations:
  • platform/ios-simulator-wk1/TestExpectations:
  • platform/ios-simulator-wk2/TestExpectations:
  • platform/ios-wk1/TestExpectations:
  • platform/ios-wk2/TestExpectations:
  • platform/ios/TestExpectations:
  • platform/mac-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wpe/TestExpectations:
9:38 PM Changeset in webkit [222422] by Alan Bujtas
  • 103 edits in trunk

WeakPtrFactory should populate m_ref lazily.
https://bugs.webkit.org/show_bug.cgi?id=177375

Reviewed by Geoffrey Garen.

Source/WebCore:

  • Modules/encryptedmedia/CDM.cpp:

(WebCore::CDM::CDM):

  • Modules/encryptedmedia/CDM.h:

(WebCore::CDM::createWeakPtr):

  • Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::MediaKeySession):
(WebCore::MediaKeySession::generateRequest):
(WebCore::MediaKeySession::load):
(WebCore::MediaKeySession::update):
(WebCore::MediaKeySession::close):
(WebCore::MediaKeySession::remove):

  • Modules/encryptedmedia/MediaKeys.cpp:

(WebCore::MediaKeys::MediaKeys):
(WebCore::MediaKeys::createSession):

  • Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::MediaDevices):

  • Modules/mediastream/MediaDevices.h:

(WebCore::MediaDevices::createWeakPtr):

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::MediaStreamTrack):

  • Modules/mediastream/MediaStreamTrack.h:

(WebCore::MediaStreamTrack::createWeakPtr):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::AccessibilityRenderObject):

  • accessibility/AccessibilityRenderObject.h:

(WebCore::AccessibilityRenderObject::createWeakPtr):

  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::WebAnimation):

  • animation/WebAnimation.h:
  • css/FontFace.cpp:

(WebCore::FontFace::FontFace):
(WebCore::FontFace::createWeakPtr):
(WebCore::FontFace::createWeakPtr const): Deleted.

  • css/FontFace.h:
  • css/StyleSheetContents.h:
  • dom/DataTransferItemList.cpp:

(WebCore::DataTransferItemList::DataTransferItemList):
(WebCore::DataTransferItemList::add):
(WebCore::DataTransferItemList::ensureItems const):
(WebCore::DataTransferItemList::didSetStringData):

  • dom/Document.cpp:

(WebCore::Document::postTask):

  • dom/Document.h:

(WebCore::Document::createWeakPtr):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::HTMLMediaElement):

  • html/HTMLMediaElement.h:

(WebCore::HTMLMediaElement::createWeakPtr):

  • html/HTMLPictureElement.h:
  • html/parser/HTMLResourcePreloader.h:

(WebCore::HTMLResourcePreloader::HTMLResourcePreloader):
(WebCore::HTMLResourcePreloader::createWeakPtr):

  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::LinkLoader):

  • loader/LinkLoader.h:

(WebCore::LinkLoader::createWeakPtr):

  • loader/MediaResourceLoader.cpp:

(WebCore::MediaResourceLoader::MediaResourceLoader):

  • loader/MediaResourceLoader.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::DOMWindow):

  • page/DOMWindow.h:
  • platform/GenericTaskQueue.cpp:

(WebCore::TaskDispatcher<Timer>::TaskDispatcher):
(WebCore::TaskDispatcher<Timer>::postTask):

  • platform/GenericTaskQueue.h:

(WebCore::GenericTaskQueue::GenericTaskQueue):
(WebCore::GenericTaskQueue::enqueueTask):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::createWeakPtr):

  • platform/Scrollbar.cpp:

(WebCore::Scrollbar::Scrollbar):

  • platform/Scrollbar.h:

(WebCore::Scrollbar::createWeakPtr):

  • platform/Widget.h:

(WebCore::Widget::createWeakPtr):

  • platform/audio/mac/AudioHardwareListenerMac.cpp:

(WebCore::AudioHardwareListenerMac::AudioHardwareListenerMac):

  • platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::FontCascade):

  • platform/graphics/FontCascade.h:

(WebCore::FontCascade::createWeakPtr const):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:

(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):

  • platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:

(WebCore::MediaPlayerPrivateAVFoundation::createWeakPtr):

  • platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.h:

(WebCore::CDMSessionAVFoundationObjC::createWeakPtr):

  • platform/graphics/avfoundation/objc/CDMSessionAVFoundationObjC.mm:

(WebCore::CDMSessionAVFoundationObjC::CDMSessionAVFoundationObjC):

  • platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:

(WebCore::CDMSessionAVStreamSession::CDMSessionAVStreamSession):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:

(WebCore::MediaPlayerPrivateAVFoundationObjC::createWeakPtr):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::MediaPlayerPrivateAVFoundationObjC):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::createWeakPtr):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::sizeWillChangeAtTime):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::MediaPlayerPrivateMediaStreamAVFObjC):

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::SourceBufferPrivateAVFObjC):
(WebCore::SourceBufferPrivateAVFObjC::append):
(WebCore::SourceBufferPrivateAVFObjC::abort):

  • platform/graphics/cv/TextureCacheCV.mm:

(WebCore::TextureCacheCV::TextureCacheCV):
(WebCore::TextureCacheCV::textureFromImage):

  • platform/graphics/mac/DisplayRefreshMonitorMac.cpp:

(WebCore::DisplayRefreshMonitorMac::DisplayRefreshMonitorMac):
(WebCore::DisplayRefreshMonitorMac::displayLinkFired):

  • platform/ios/RemoteCommandListenerIOS.h:

(WebCore::RemoteCommandListenerIOS::createWeakPtr):

  • platform/ios/RemoteCommandListenerIOS.mm:

(WebCore::RemoteCommandListenerIOS::RemoteCommandListenerIOS):

  • platform/mac/RemoteCommandListenerMac.h:

(WebCore::RemoteCommandListenerMac::createWeakPtr):

  • platform/mediastream/MediaStreamPrivate.cpp:

(WebCore::MediaStreamPrivate::MediaStreamPrivate):

  • platform/mediastream/MediaStreamPrivate.h:

(WebCore::MediaStreamPrivate::createWeakPtr):

  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::RealtimeMediaSource):

  • platform/mediastream/RealtimeMediaSource.h:
  • platform/mock/MockMediaEndpoint.cpp:

(WebCore::MockMediaEndpoint::MockMediaEndpoint):
(WebCore::MockMediaEndpoint::generateDtlsInfo):

  • rendering/RenderMultiColumnSpannerPlaceholder.cpp:

(WebCore::RenderMultiColumnSpannerPlaceholder::RenderMultiColumnSpannerPlaceholder):

  • rendering/RenderMultiColumnSpannerPlaceholder.h:
  • rendering/RenderView.cpp:

(WebCore::RenderView::RenderView):

  • rendering/RenderView.h:
  • rendering/RenderWidget.cpp:

(WebCore::RenderWidget::RenderWidget):

  • rendering/RenderWidget.h:

(WebCore::RenderWidget::createWeakPtr):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::createWeakPtr):

  • svg/SVGPathElement.cpp:

(WebCore::SVGPathElement::SVGPathElement):

  • svg/SVGPathElement.h:
  • svg/properties/SVGMatrixTearOff.h:
  • testing/MockCDMFactory.cpp:

(WebCore::MockCDMFactory::MockCDMFactory):
(WebCore::MockCDMFactory::createCDM):
(WebCore::MockCDM::MockCDM):
(WebCore::MockCDM::createInstance):
(WebCore::m_weakPtrFactory): Deleted.

Source/WebCore/PAL:

  • pal/system/mac/SystemSleepListenerMac.mm:

(PAL::SystemSleepListenerMac::SystemSleepListenerMac):

Source/WebKit:

  • UIProcess/ApplePay/WebPaymentCoordinatorProxy.cpp:

(WebKit::WebPaymentCoordinatorProxy::WebPaymentCoordinatorProxy):
(WebKit::WebPaymentCoordinatorProxy::canMakePaymentsWithActiveCard):
(WebKit::WebPaymentCoordinatorProxy::openPaymentSetup):

  • UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:

(WebKit::WebPaymentCoordinatorProxy::platformShowPaymentUI):

  • UIProcess/ApplicationStateTracker.mm:

(WebKit::ApplicationStateTracker::ApplicationStateTracker):

  • UIProcess/Cocoa/WebViewImpl.h:

(WebKit::WebViewImpl::createWeakPtr):

  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::WebViewImpl):

  • UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::ProcessLauncher::ProcessLauncher):

  • UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::ProcessLauncher::launchProcess):

  • UIProcess/ProcessAssertion.h:

(WebKit::ProcessAssertion::createWeakPtr):

  • UIProcess/WebPageProxy.cpp:

(WebKit::m_configurationPreferenceValues):
(WebKit::m_weakPtrFactory): Deleted.

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::createWeakPtr const):

  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:

(WebKit::RemoteLayerTreeDrawingArea::createWeakPtr):

  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebEditorClient.mm:

(WebEditorClient::WebEditorClient):
(WebEditorClient::requestCandidatesForSelection):

Source/WTF:

This helps us with the overhead of initializing WeakPtrFactory for
objects that rarely end up creating the weak reference.
-This is in preparation for introducing WeakPtr to RenderObject.

All credit to Geoffrey Garen.

  • wtf/WeakPtr.h:

(WTF::WeakReference::get const):
(WTF::WeakReference::clear):
(WTF::WeakReference::WeakReference):
(WTF::WeakPtrFactory::~WeakPtrFactory):
(WTF::WeakPtrFactory::createWeakPtr const):
(WTF::WeakPtrFactory::revokeAll):
(WTF::WeakPtrFactory::WeakPtrFactory): Deleted.

Tools:

  • TestWebKitAPI/Tests/WTF/WeakPtr.cpp:

(TestWebKitAPI::TEST):

7:08 PM Changeset in webkit [222421] by keith_miller@apple.com
  • 15 edits in trunk

Speculatively change iteration protocall to use the same next function
https://bugs.webkit.org/show_bug.cgi?id=175653

Reviewed by Saam Barati.

JSTests:

Change test to match the new iteration behavior.

  • stress/spread-optimized-properly.js:

Source/JavaScriptCore:

This patch speculatively makes a change to the iteration protocall to fetch the next
property immediately after calling the Symbol.iterator function. This is, in theory,
a breaking change, so we will see if this breaks things (most likely it won't as this
is a relatively subtle point).

See: https://github.com/tc39/ecma262/issues/976

  • builtins/IteratorHelpers.js:

(performIteration):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitEnumeration):
(JSC::BytecodeGenerator::emitIteratorNext):
(JSC::BytecodeGenerator::emitIteratorNextWithValue):
(JSC::BytecodeGenerator::emitDelegateYield):

  • bytecompiler/BytecodeGenerator.h:
  • bytecompiler/NodesCodegen.cpp:

(JSC::ArrayPatternNode::bindValue const):

  • inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::iteratorEntries):

  • runtime/IteratorOperations.cpp:

(JSC::iteratorNext):
(JSC::iteratorStep):
(JSC::iteratorClose):
(JSC::iteratorForIterable):

  • runtime/IteratorOperations.h:

(JSC::forEachInIterable):

  • runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::constructGenericTypedArrayViewFromIterator):
(JSC::constructGenericTypedArrayViewWithArguments):

LayoutTests:

Change test to match the new iteration behavior.

  • js/sequence-iterator-protocol-2-expected.txt:
  • js/sequence-iterator-protocol-2.html:
5:55 PM Changeset in webkit [222420] by Matt Baker
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Remove SidebarPanel show/hide and added/removed
https://bugs.webkit.org/show_bug.cgi?id=177387

Reviewed by Devin Rousso.

  • UserInterface/Views/DebuggerTabContentView.js:

(WI.DebuggerTabContentView.prototype.showDetailsSidebarPanels):

  • UserInterface/Views/SearchSidebarPanel.js:

(WI.SearchSidebarPanel.prototype.focusSearchField):

  • UserInterface/Views/Sidebar.js:

(WI.Sidebar.prototype.insertSidebarPanel):
(WI.Sidebar.prototype.removeSidebarPanel):

  • UserInterface/Views/SidebarPanel.js:

(WI.SidebarPanel.prototype.show): Deleted.
(WI.SidebarPanel.prototype.hide): Deleted.
(WI.SidebarPanel.prototype.added): Deleted.
(WI.SidebarPanel.prototype.removed): Deleted.

5:55 PM Changeset in webkit [222419] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

WebRTC test gardening for iOS.

Unreviewed test gardening.

  • platform/ios/TestExpectations:
5:40 PM Changeset in webkit [222418] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Move flaky expectation for imported/w3c/web-platform-tests/payment-request/payment-request-show-method.https.html.
https://bugs.webkit.org/show_bug.cgi?id=177391

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
  • platform/ios/TestExpectations:
5:27 PM Changeset in webkit [222417] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[Win64] Crashes in Yarr JIT compiled code
https://bugs.webkit.org/show_bug.cgi?id=177293

Patch by Fujii Hironori <Fujii Hironori> on 2017-09-22
Reviewed by Yusuke Suzuki.

In x64 Windows, rcx register is used for the address of allocated
space for the return value. But, rcx is used for regT1 since
r221052. Save rcx in the stack.

  • yarr/YarrJIT.cpp:

(JSC::Yarr::YarrGenerator::generateEnter): Push ecx.
(JSC::Yarr::YarrGenerator::generateReturn): Pop ecx.

5:27 PM Changeset in webkit [222416] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: View should automatically layout when it becomes attached to the DOM
https://bugs.webkit.org/show_bug.cgi?id=177189

Reviewed by Devin Rousso.

This guarantees that a layout is always scheduled as soon as a view is
attached to the DOM. Now that nearly all views are created lazily, it
is safe to make this change even without having a visibility concept in
the View class that would prevent layouts for background views.

  • UserInterface/Views/View.js:

(WI.View):
Remove this._needsLayoutWhenAttachedToRoot flag, which is now implicit.
This was set if a layout was requested before the view had been attached
to the DOM.

(WI.View.prototype.get element):
(WI.View.prototype.get layoutPending):
(WI.View.prototype.get parentView):
(WI.View.prototype.get subviews):
(WI.View.prototype.get isAttached):
(WI.View.prototype.insertSubviewBefore):
(WI.View.prototype.removeSubview):
(WI.View.prototype.removeAllSubviews):
(WI.View.prototype.attached):
(WI.View.prototype.detached):
Hooks for subclasses to define behavior added or removed from the DOM.
(WI.View.prototype._didMoveToParent):
(WI.View.prototype._didMoveToWindow):
(WI.View._scheduleLayoutForView):
(WI.View.prototype.didMoveToWindow): Deleted.
(WI.View.prototype.didMoveToParent): Deleted.
These were only used by View, and have been made private.

5:08 PM Changeset in webkit [222415] by jmarcell@apple.com
  • 2 edits in tags/Safari-605.1.7.1/Source/WebKit

Cherry-pick r222414. rdar://problem/34412846

4:37 PM Changeset in webkit [222414] by wilander@apple.com
  • 2 edits in trunk/Source/WebKit

Re-enable configuration.HTTPCookieStorage on session without credentials
https://bugs.webkit.org/show_bug.cgi?id=177393

This patch rolls back the crucial change to the network session
without credentials that landed in r221632:
<http://trac.webkit.org/changeset/221632>

Reviewed by Brent Fulgham.

  • NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

Commented out the disabled cookie jar and added a FIXME
referring to https://bugs.webkit.org/show_bug.cgi?id=177394.

4:27 PM Changeset in webkit [222413] by fpizlo@apple.com
  • 31 edits
    1 add in trunk/Tools

WSL should report an error if you try to create an operator overload that will never be called
https://bugs.webkit.org/show_bug.cgi?id=177092

Reviewed by JF Bastien.

This adds all kinds of checks to ensure that your operator overloads make sense. This adds all
kinds of tests for those checks.

In the process of writing those tests, I hit an awesome bug: function instantiation was
instantiating all types, which meant that if that instantiated function needed to resolve calls
to protocol functions, we'd fail because we would have cloned top-level struct types. We need
to preserve the uninstantiated argument types, type arguments, and return type (for casts) in
order to be able to resolve protocol calls. But we also need the instantiated version of the
type arguments for execution. So, this adds some more stuff to the CallExpression class.

  • WebGPUShadingLanguageRI/All.js:
  • WebGPUShadingLanguageRI/ArrayRefType.js:

(ArrayRefType.prototype.unifyImpl):

  • WebGPUShadingLanguageRI/ArrayType.js:

(ArrayType.prototype.get isArray):

  • WebGPUShadingLanguageRI/CallExpression.js:

(CallExpression.resolve):
(CallExpression.prototype.resolve):
(CallExpression.prototype.resolveToOverload):

  • WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype._checkOperatorOverload):
(Checker.prototype.visitFuncDef):
(Checker.prototype.visitProtocolDecl):
(Checker.prototype.visitMakeArrayRefExpression):

  • WebGPUShadingLanguageRI/EBufferBuilder.js:

(EBufferBuilder.prototype._createEPtr):

  • WebGPUShadingLanguageRI/EPtr.js:

(EPtr):

  • WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype._snapshot):
(Evaluator.prototype._runBody):
(Evaluator.prototype.visitFunctionLikeBlock):
(Evaluator.prototype.visitCallExpression):
(Evaluator):
(Evaluator.prototype.runFunc): Deleted.

  • WebGPUShadingLanguageRI/ExternalOrigin.js: Added.
  • WebGPUShadingLanguageRI/Func.js:

(Func.prototype.toDeclString):

  • WebGPUShadingLanguageRI/FuncInstantiator.js:

(FuncInstantiator.prototype.getUnique.InstantiationSubstitution.prototype.visitCallExpression):
(FuncInstantiator.prototype.getUnique.InstantiationSubstitution):
(FuncInstantiator.prototype.getUnique.InstantiationInstantiateImmediates.prototype.visitCallExpression):
(FuncInstantiator.prototype.getUnique.InstantiationInstantiateImmediates):
(FuncInstantiator.prototype.getUnique.Instantiate.prototype.visitFuncDef):

  • WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics):

  • WebGPUShadingLanguageRI/LateChecker.js:

(LateChecker.prototype.visitReferenceType):
(LateChecker.prototype._checkShaderType):

  • WebGPUShadingLanguageRI/Lexer.js:

(Lexer._textIsIdentifierImpl):
(Lexer.textIsIdentifier):
(Lexer.prototype.next):
(Lexer):

  • WebGPUShadingLanguageRI/NameResolver.js:

(NameResolver.prototype.visitProtocolDecl):

  • WebGPUShadingLanguageRI/Parse.js:

(parseType.getAddressSpace):
(parseType):

  • WebGPUShadingLanguageRI/Prepare.js:

(let.prepare):

  • WebGPUShadingLanguageRI/PtrType.js:

(PtrType.prototype.unifyImpl):

  • WebGPUShadingLanguageRI/ReferenceType.js:

(ReferenceType):

  • WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitReferenceType):
(Rewriter.prototype.processDerivedCallData):

  • WebGPUShadingLanguageRI/StandardLibrary.js:

(intToString):

  • WebGPUShadingLanguageRI/StatementCloner.js:

(StatementCloner.prototype.visitFuncDef):

  • WebGPUShadingLanguageRI/StructLayoutBuilder.js:

(StructLayoutBuilder.prototype.visitCallExpression):
(StructLayoutBuilder):

  • WebGPUShadingLanguageRI/Substitution.js:

(Substitution.prototype.visitTypeRef):

  • WebGPUShadingLanguageRI/Test.html:
  • WebGPUShadingLanguageRI/Test.js:

(checkNumber):
(set target):
(tests.literalBool):
(tests.identityBool):
(tests.intSimpleMath):
(tests.uintSimpleMath):
(tests.uint8SimpleMath):
(tests.equality):
(tests.logicalNegation):
(tests.notEquality):
(tests.equalityTypeFailure):
(tests.generalNegation):
(tests.add1):
(tests.simpleGeneric):
(tests.nameResolutionFailure):
(tests.simpleVariable):
(tests.simpleAssignment):
(tests.simpleDefault):
(tests.simpleDereference):
(tests.dereferenceStore):
(tests.simpleMakePtr):
(tests.threadArrayLoad):
(tests.threadArrayLoadIntLiteral):
(tests.deviceArrayLoad):
(tests.threadArrayStore):
(tests.deviceArrayStore):
(tests.deviceArrayStoreIntLiteral):
(tests.simpleProtocol):
(tests.typeMismatchReturn):
(tests.typeMismatchVariableDecl):
(tests.typeMismatchAssignment):
(tests.typeMismatchReturnParam):
(tests.badAdd):
(tests.lexerKeyword):
(tests.simpleNoReturn):
(tests.simpleUnreachableCode):
(tests.simpleStruct):
(tests.genericStructInstance):
(tests.doubleGenericCallsDoubleGeneric):
(tests.doubleGenericCallsSingleGeneric):
(tests.loadNull):
(tests.storeNull):
(tests.returnNull):
(tests.dereferenceDefaultNull):
(tests.defaultInitializedNull):
(tests.passNullToPtrMonomorphic):
(tests.passNullToPtrPolymorphic):
(tests.passNullToPolymorphic):
(tests.loadNullArrayRef):
(tests.storeNullArrayRef):
(tests.returnNullArrayRef):
(tests.dereferenceDefaultNullArrayRef):
(tests.defaultInitializedNullArrayRef):
(tests.defaultInitializedNullArrayRefIntLiteral):
(tests.passNullToPtrMonomorphicArrayRef):
(tests.passNullToPtrPolymorphicArrayRef):
(tests.returnIntLiteralUint):
(tests.returnIntLiteralDouble):
(tests.badIntLiteralForInt):
(tests.badIntLiteralForUint):
(tests.badIntLiteralForDouble):
(tests.passNullAndNotNull):
(tests.passNullAndNotNullFullPoly):
(tests.passNullAndNotNullFullPolyReverse):
(tests.nullTypeVariableUnify):
(tests.doubleNot):
(tests.simpleRecursion):
(tests.protocolMonoSigPolyDef):
(tests.protocolPolySigPolyDef):
(tests.protocolDoublePolySigDoublePolyDef):
(tests.protocolDoublePolySigDoublePolyDefExplicit):
(tests.variableShadowing):
(tests.ifStatement):
(tests.ifElseStatement):
(tests.ifElseIfStatement):
(tests.ifElseIfElseStatement):
(tests.returnIf):
(tests.simpleWhile):
(tests.protocolMonoPolySigDoublePolyDefExplicit):
(tests.ambiguousOverloadSimple):
(tests.ambiguousOverloadOverlapping):
(tests.ambiguousOverloadTieBreak):
(tests.intOverloadResolution):
(tests.intOverloadResolutionReverseOrder):
(tests.intOverloadResolutionGeneric):
(tests.intLiteralGeneric):
(tests.intLiteralGenericWithProtocols):
(tests.uintLiteralGeneric):
(tests.uintLiteralGenericWithProtocols):
(tests.intLiteralGenericSpecific):
(tests.simpleConstexpr):
(tests.break):
(tests.continue):
(tests.doWhile):
(tests.forLoop):
(tests.chainConstexpr):
(tests.chainGeneric):
(tests.chainStruct):
(tests.chainStructNewlyValid):
(tests.chainStructDevice):
(tests.paramChainStructDevice):
(tests.simpleProtocolExtends):
(tests.protocolExtendsTwo):
(tests.prefixPlusPlus):
(tests.prefixPlusPlusResult):
(tests.postfixPlusPlus):
(tests.postfixPlusPlusResult):
(tests.prefixMinusMinus):
(tests.prefixMinusMinusResult):
(tests.postfixMinusMinus):
(tests.postfixMinusMinusResult):
(tests.plusEquals):
(tests.plusEqualsResult):
(tests.minusEquals):
(tests.minusEqualsResult):
(tests.timesEquals):
(tests.timesEqualsResult):
(tests.divideEquals):
(tests.divideEqualsResult):
(tests.twoIntLiterals):
(tests.unifyDifferentLiterals):
(tests.unifyDifferentLiteralsBackwards):
(tests.unifyVeryDifferentLiterals):
(tests.unifyVeryDifferentLiteralsBackwards):
(tests.assignUintToInt):
(tests.buildArrayThenSumIt):
(tests.buildArrayThenSumItUsingArrayReference):
(tests.overrideSubscriptStruct):
(tests.overrideSubscriptStructAndDoStores):
(tests.overrideSubscriptStructAndUsePointers):
(tests.overrideSubscriptStructAndUsePointersIncorrectly):
(tests.makeArrayRefFromLocal):
(tests.makeArrayRefFromPointer):
(tests.makeArrayRefFromArrayRef):
(tests.simpleLength):
(tests.nonArrayRefArrayLengthSucceed):
(tests.nonArrayRefArrayLengthFail):
(tests.constexprIsNotLValuePtr):
(tests.constexprIsNotLValueAssign):
(tests.constexprIsNotLValueRMW):
(tests.assignLength):
(tests.assignLengthHelper):
(tests.simpleGetter):
(tests.simpleSetter):
(tests.genericAccessors):
(tests.bitSubscriptAccessor):
(tests.nestedSubscriptLValueEmulationSimple):
(tests.nestedSubscriptLValueEmulationGeneric):
(tests.boolBitAnd):
(tests.boolBitOr):
(tests.boolBitXor):
(tests.boolBitNot):
(tests.intBitAnd):
(tests.intBitOr):
(tests.intBitXor):
(tests.intBitNot):
(tests.intLShift):
(tests.intRShift):
(tests.uintBitAnd):
(tests.uintBitOr):
(tests.uintBitXor):
(tests.uintBitNot):
(tests.uintLShift):
(tests.uintRShift):
(tests.uint8BitAnd):
(tests.uint8BitOr):
(tests.uint8BitXor):
(tests.uint8BitNot):
(tests.uint8LShift):
(tests.uint8RShift):
(tests.floatMath):
(tests.genericCastInfer):
(tests.booleanMath):
(tests.typedefArray):
(tests.shaderTypes):
(tests.builtinVectors):
(tests.instantiateStructInStruct):
(tests.instantiateStructInStructWithInt2):
(tests.simpleEnum):
(tests.enumWithManualValues):
(tests.enumWithoutZero):
(tests.enumDuplicates):
(tests.enumWithSomeManualValues):
(tests.enumConstexprGenericFunction):
(tests.enumConstexprGenericStruct):
(tests.trap):
(tests.swizzle):
(tests.enumWithExplicitIntBase):
(tests.enumWithUintBase):
(tests.enumFloatBase):
(tests.enumPtrBase):
(tests.enumArrayRefBase):
(tests.emptyStruct):
(tests.enumStructBase):
(tests.enumNoMembers):
(tests.simpleSwitch):
(tests.exhaustiveUint8Switch):
(tests.notQuiteExhaustiveUint8Switch):
(tests.notQuiteExhaustiveUint8SwitchWithDefault):
(tests.switchFallThrough):
(tests.switchBreak):
(tests.enumSwitchBreakExhaustive):
(tests.enumSwitchBreakNotQuiteExhaustive):
(tests.enumSwitchBreakNotQuiteExhaustiveWithDefault):
(tests.simpleRecursiveStruct):
(tests.mutuallyRecursiveStruct):
(tests.mutuallyRecursiveStructWithPointersBroken):
(tests.mutuallyRecursiveStructWithPointers):
(tests.linkedList):
(tests.pointerToPointer):
(tests.arrayRefToArrayRef):
(tests.pointerGetter):
(tests.loneSetter):
(tests.setterWithMismatchedType):
(tests.setterWithMatchedType):
(tests.operatorWithUninferrableTypeVariable):
(tests.operatorWithoutUninferrableTypeVariable):
(tests.operatorCastWithUninferrableTypeVariable):
(tests.operatorCastWithTypeVariableInferredFromReturnType):
(tests.incWrongArgumentLength):
(tests.decWrongArgumentLength):
(tests.incWrongTypes):
(tests.decWrongTypes):
(tests.plusWrongArgumentLength):
(tests.minusWrongArgumentLength):
(tests.timesWrongArgumentLength):
(tests.divideWrongArgumentLength):
(tests.moduloWrongArgumentLength):
(tests.bitAndWrongArgumentLength):
(tests.bitOrWrongArgumentLength):
(tests.bitXorWrongArgumentLength):
(tests.lShiftWrongArgumentLength):
(tests.rShiftWrongArgumentLength):
(tests.bitNotWrongArgumentLength):
(tests.equalsWrongArgumentLength):
(tests.lessThanWrongArgumentLength):
(tests.lessEqualWrongArgumentLength):
(tests.greaterWrongArgumentLength):
(tests.greaterEqualWrongArgumentLength):
(tests.equalsWrongReturnType):
(tests.notEqualsOverload):
(tests.lessThanWrongReturnType):
(tests.lessEqualWrongReturnType):
(tests.greaterThanWrongReturnType):
(tests.greaterEqualWrongReturnType):
(tests.dotOperatorWrongArgumentLength):
(tests.dotOperatorSetterWrongArgumentLength):
(tests.loneSetterPointer):
(tests.setterWithNoGetterOverload):
(tests.setterWithNoGetterOverloadFixed):
(tests.anderWithNothingWrong):
(tests.anderWithWrongNumberOfArguments):
(tests.anderDoesntReturnPointer):
(tests.anderDoesntTakeReference):
(tests.anderWithArrayRef):
(tests.pointerIndexGetter):
(tests.loneIndexSetter):
(tests.notLoneIndexSetter):
(tests.indexSetterWithMismatchedType):
(tests.indexOperatorWrongArgumentLength):
(tests.indexOperatorSetterWrongArgumentLength):
(tests.loneIndexSetterPointer):
(tests.indexSetterWithNoGetterOverload):
(tests.indexSetterWithNoGetterOverloadFixed):
(tests.indexAnderWithNothingWrong):
(tests.indexAnderWithWrongNumberOfArguments):
(tests.indexAnderDoesntReturnPointer):
(tests.indexAnderDoesntTakeReference):
(tests.indexAnderWithArrayRef):
(tests.devicePtrPtr):
(tests.threadgroupPtrPtr):
(tests.constantPtrPtr):
(tests.pointerIndexGetterInProtocol):
(tests.loneIndexSetterInProtocol):
(tests.notLoneIndexSetterInProtocol):
(tests.indexSetterWithMismatchedTypeInProtocol):
(tests.indexOperatorWrongArgumentLengthInProtocol):
(tests.indexOperatorSetterWrongArgumentLengthInProtocol):
(tests.loneIndexSetterPointerInProtocol):
(tests.indexSetterWithNoGetterOverloadInProtocol):
(tests.indexSetterWithNoGetterOverloadFixedInProtocol):
(tests.indexAnderWithNothingWrongInProtocol):
(tests.indexAnderWithWrongNumberOfArgumentsInProtocol):
(tests.indexAnderDoesntReturnPointerInProtocol):
(tests.indexAnderDoesntTakeReferenceInProtocol):
(tests.indexAnderWithArrayRefInProtocol):
(doTest):
(this.window.let._.of.doTest):
(TEST_literalBool): Deleted.
(TEST_identityBool): Deleted.
(TEST_intSimpleMath): Deleted.
(TEST_uintSimpleMath): Deleted.
(TEST_uint8SimpleMath): Deleted.
(TEST_equality): Deleted.
(TEST_logicalNegation): Deleted.
(TEST_notEquality): Deleted.
(TEST_equalityTypeFailure): Deleted.
(): Deleted.
(TEST_add1): Deleted.
(TEST_simpleGeneric): Deleted.
(TEST_nameResolutionFailure): Deleted.
(TEST_simpleAssignment): Deleted.
(TEST_simpleDefault): Deleted.
(TEST_simpleDereference): Deleted.
(TEST_dereferenceStore): Deleted.
(TEST_simpleMakePtr): Deleted.
(TEST_threadArrayLoad): Deleted.
(TEST_threadArrayLoadIntLiteral): Deleted.
(TEST_deviceArrayLoad): Deleted.
(TEST_threadArrayStore): Deleted.
(TEST_deviceArrayStore): Deleted.
(TEST_deviceArrayStoreIntLiteral): Deleted.
(TEST_simpleProtocol): Deleted.
(TEST_typeMismatchReturn): Deleted.
(TEST_simpleNoReturn): Deleted.
(TEST_genericStructInstance): Deleted.
(TEST_doubleGenericCallsDoubleGeneric): Deleted.
(TEST_doubleGenericCallsSingleGeneric): Deleted.
(TEST_dereferenceDefaultNull): Deleted.
(TEST_dereferenceDefaultNullArrayRef): Deleted.
(TEST_returnIntLiteralDouble): Deleted.
(TEST_badIntLiteralForInt): Deleted.
(TEST_passNullAndNotNullFullPoly): Deleted.
(TEST_passNullAndNotNullFullPolyReverse): Deleted.
(TEST_nullTypeVariableUnify.recurse): Deleted.
(TEST_nullTypeVariableUnify.everyOrder): Deleted.
(TEST_nullTypeVariableUnify.everyPair): Deleted.
(TEST_nullTypeVariableUnify): Deleted.
(TEST_simpleRecursion): Deleted.
(TEST_protocolPolySigPolyDef): Deleted.
(TEST_protocolDoublePolySigDoublePolyDef): Deleted.
(TEST_protocolDoublePolySigDoublePolyDefExplicit): Deleted.
(TEST_variableShadowing): Deleted.
(TEST_ifStatement): Deleted.
(TEST_ifElseStatement): Deleted.
(TEST_ifElseIfStatement): Deleted.
(TEST_ifElseIfElseStatement): Deleted.
(TEST_returnIf): Deleted.
(TEST_simpleWhile): Deleted.
(TEST_protocolMonoPolySigDoublePolyDefExplicit): Deleted.
(TEST_intOverloadResolution): Deleted.
(TEST_intOverloadResolutionReverseOrder): Deleted.
(TEST_intOverloadResolutionGeneric): Deleted.
(TEST_intLiteralGeneric): Deleted.
(TEST_intLiteralGenericWithProtocols): Deleted.
(TEST_uintLiteralGeneric): Deleted.
(TEST_uintLiteralGenericWithProtocols): Deleted.
(TEST_intLiteralGenericSpecific): Deleted.
(TEST_simpleConstexpr): Deleted.
(TEST_break): Deleted.
(TEST_forLoop): Deleted.
(TEST_chainConstexpr): Deleted.
(TEST_chainGeneric): Deleted.
(TEST_chainStruct): Deleted.
(TEST_chainStructNewlyValid): Deleted.
(TEST_chainStructDevice): Deleted.
(TEST_paramChainStructDevice): Deleted.
(TEST_simpleProtocolExtends): Deleted.
(TEST_protocolExtendsTwo): Deleted.
(TEST_prefixPlusPlus): Deleted.
(TEST_prefixPlusPlusResult): Deleted.
(TEST_postfixPlusPlus): Deleted.
(TEST_postfixPlusPlusResult): Deleted.
(TEST_prefixMinusMinus): Deleted.
(TEST_prefixMinusMinusResult): Deleted.
(TEST_postfixMinusMinus): Deleted.
(TEST_postfixMinusMinusResult): Deleted.
(TEST_plusEquals): Deleted.
(TEST_plusEqualsResult): Deleted.
(TEST_minusEquals): Deleted.
(TEST_minusEqualsResult): Deleted.
(TEST_timesEquals): Deleted.
(TEST_timesEqualsResult): Deleted.
(TEST_divideEquals): Deleted.
(TEST_divideEqualsResult): Deleted.
(TEST_twoIntLiterals): Deleted.
(TEST_unifyDifferentLiterals): Deleted.
(TEST_buildArrayThenSumItUsingArrayReference): Deleted.
(TEST_overrideSubscriptStruct): Deleted.
(TEST_overrideSubscriptStructAndDoStores): Deleted.
(TEST_overrideSubscriptStructAndUsePointers): Deleted.
(TEST_overrideSubscriptStructAndUsePointersIncorrectly): Deleted.
(TEST_makeArrayRefFromPointer): Deleted.
(TEST_makeArrayRefFromArrayRef): Deleted.
(TEST_nonArrayRefArrayLengthSucceed): Deleted.
(TEST_nonArrayRefArrayLengthFail): Deleted.
(TEST_simpleSetter): Deleted.
(TEST_genericAccessors): Deleted.
(TEST_bitSubscriptAccessor): Deleted.
(TEST_nestedSubscriptLValueEmulationSimple): Deleted.
(TEST_nestedSubscriptLValueEmulationGeneric): Deleted.
(TEST_boolBitAnd): Deleted.
(TEST_boolBitOr): Deleted.
(TEST_boolBitXor): Deleted.
(TEST_boolBitNot): Deleted.
(TEST_intBitAnd): Deleted.
(TEST_intBitOr): Deleted.
(TEST_intBitXor): Deleted.
(TEST_intBitNot): Deleted.
(TEST_intLShift): Deleted.
(TEST_intRShift): Deleted.
(TEST_uintBitAnd): Deleted.
(TEST_uintBitOr): Deleted.
(TEST_uintBitXor): Deleted.
(TEST_uintBitNot): Deleted.
(TEST_uintLShift): Deleted.
(TEST_uintRShift): Deleted.
(TEST_uint8BitAnd): Deleted.
(TEST_uint8BitOr): Deleted.
(TEST_uint8BitXor): Deleted.
(TEST_uint8BitNot): Deleted.
(TEST_uint8LShift): Deleted.
(TEST_uint8RShift): Deleted.
(TEST_floatMath): Deleted.
(TEST_booleanMath): Deleted.
(TEST_typedefArray): Deleted.
(TEST_shaderTypes): Deleted.
(TEST_instantiateStructInStruct): Deleted.
(TEST_instantiateStructInStructWithInt2): Deleted.
(TEST_simpleEnum): Deleted.
(TEST_enumWithManualValues): Deleted.
(TEST_enumWithoutZero): Deleted.
(TEST_enumConstexprGenericFunction): Deleted.
(TEST_enumConstexprGenericStruct): Deleted.
(TEST_trap): Deleted.
(TEST_enumWithExplicitIntBase): Deleted.
(TEST_enumWithUintBase): Deleted.
(TEST_enumFloatBase): Deleted.
(TEST_enumStructBase): Deleted.
(TEST_simpleSwitch): Deleted.
(TEST_exhaustiveUint8Switch): Deleted.
(TEST_notQuiteExhaustiveUint8Switch): Deleted.
(TEST_switchFallThrough): Deleted.
(TEST_switchBreak): Deleted.
(TEST_enumSwitchBreakExhaustive): Deleted.
(TEST_enumSwitchBreakNotQuiteExhaustive): Deleted.
(TEST_simpleRecursiveStruct): Deleted.
(TEST_linkedList): Deleted.

  • WebGPUShadingLanguageRI/Type.js:

(Type.prototype.get isArray):

  • WebGPUShadingLanguageRI/TypeRef.js:

(TypeRef.wrap):

  • WebGPUShadingLanguageRI/TypeVariableTracker.js:

(TypeVariableTracker.prototype.set get return):
(TypeVariableTracker.prototype.visitVariableRef):
(TypeVariableTracker):

  • WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitProtocolDecl):

  • WebGPUShadingLanguageRI/index.html:
4:16 PM Changeset in webkit [222412] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Enable File and Directory Entries API at runtime
https://bugs.webkit.org/show_bug.cgi?id=176616
<rdar://problem/34330942>

Reviewed by Geoffrey Garen.

Enable File and Directory Entries API at runtime on Mac/WebKit2,
now that DataTransfer.items is enabled there.

  • Shared/WebPreferencesDefinitions.h:
4:13 PM Changeset in webkit [222411] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark fast/mediastream/RTCPeerConnection-overloaded-operations.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=177395

Unreviewed test gardening.

  • platform/ios/TestExpectations:
3:31 PM Changeset in webkit [222410] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/payment-request/payment-request-show-method.https.html as flaky on iOS.
https://bugs.webkit.org/show_bug.cgi?id=177391

Unreviewed test gardening.

  • platform/ios/TestExpectations:
2:47 PM Changeset in webkit [222409] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/css/css-ui-3/text-overflow-022.html as an image failure.

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
2:37 PM Changeset in webkit [222408] by Nikita Vasilyev
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles Redesign: support toggling properties
https://bugs.webkit.org/show_bug.cgi?id=176643

Reviewed by Joseph Pecoraro.

Add a primitive UI to make CSS property names and values editable. Autocomplete, syntax highlighting,
and proper keyboard navigation will be added later.

Display !important when it's specified. Before this patch !important wasn't shown in the redesigned
styles sidebar.

  • UserInterface/Models/CSSProperty.js:

(WI.CSSProperty.prototype.update):
(WI.CSSProperty.prototype.get name):
(WI.CSSProperty.prototype.set name):
(WI.CSSProperty.prototype.get value):
(WI.CSSProperty.prototype.get rawValue):
(WI.CSSProperty.prototype.set rawValue):
CSSProperty.prototype.value returns the same value as before. !important remains stripped.
CSSProperty.prototype.rawValue returns a raw value from the payload. It may include !important.

(WI.CSSProperty.prototype._updateStyle):
(WI.CSSProperty.prototype._updateOwnerStyleText):
(WI.CSSProperty):

  • UserInterface/Models/DOMNodeStyles.js:

(WI.DOMNodeStyles.prototype._parseStylePropertyPayload):

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.spreadsheet-style-declaration-editor :matches(.name, .value):focus):

  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetStyleProperty.prototype._update):
(WI.SpreadsheetStyleProperty.prototype._handleNameChange):
(WI.SpreadsheetStyleProperty.prototype._handleValueChange):
(WI.SpreadsheetStyleProperty):

2:29 PM Changeset in webkit [222407] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark fast/forms/listbox-typeahead-greek.html as failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=177385

Unreviewed test gardening.

  • platform/win/TestExpectations:
2:24 PM Changeset in webkit [222406] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark fast/forms/listbox-typeahead-cyrillic.html as failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=177378

Unreviewed test gardening.

  • platform/win/TestExpectations:
2:08 PM Changeset in webkit [222405] by Matt Baker
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: NavigationBar should coalesce consecutive dividers when items are hidden
https://bugs.webkit.org/show_bug.cgi?id=177379

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/NavigationBar.js:

(WI.NavigationBar.prototype.layout):

2:07 PM Changeset in webkit [222404] by jmarcell@apple.com
  • 2 edits in tags/Safari-605.1.7.1

Cherry-pick r222401. rdar://problem/34595468

2:07 PM Changeset in webkit [222403] by jmarcell@apple.com
  • 19 edits in tags/Safari-605.1.7.1

Cherry-pick r222396. rdar://problem/34578257

1:15 PM Changeset in webkit [222402] by timothy_horton@apple.com
  • 10 edits
    10 adds in trunk

Add env() as an alias of constant()
https://bugs.webkit.org/show_bug.cgi?id=177371

Reviewed by Simon Fraser.

Source/WebCore:

  • css/CSSValueKeywords.in:
  • css/CSSVariableData.cpp:

(WebCore::CSSVariableData::checkVariablesForCyclesWithRange const):
(WebCore::CSSVariableData::resolveTokenRange const):

  • css/parser/CSSVariableParser.cpp:

(WebCore::classifyBlock):
Add env() as an alias of constant() everywhere it is mentioned.

Source/WebInspectorUI:

  • UserInterface/Models/CSSKeywordCompletions.js:

(WI.CSSKeywordCompletions.forProperty):
(WI.CSSKeywordCompletions.forFunction):
Add autocomplete support for env().

LayoutTests:

Duplicated constant() tests with env() instead.

12:57 PM Changeset in webkit [222401] by pvollan@apple.com
  • 2 edits in trunk

[Win] WebKit is built as a static library, and not as a dll.
https://bugs.webkit.org/show_bug.cgi?id=177365

Reviewed by Brent Fulgham.

Set target type for WebKitLegacy target.

  • Source/cmake/OptionsWin.cmake:
12:56 PM Changeset in webkit [222400] by Matt Lewis
  • 12 edits in trunk

Unreviewed, rolling out r222394.

This broke the Windows Debug Build.

Reverted changeset:

"Remove build-webkit's notion of feature flags having a
default value"
https://bugs.webkit.org/show_bug.cgi?id=177338
http://trac.webkit.org/changeset/222394

12:31 PM Changeset in webkit [222399] by Ryan Haddad
  • 3 edits
    1 delete in trunk/LayoutTests

Unreviewed test gardening for iOS.

  • platform/ios-simulator/TestExpectations:
  • platform/ios-wk2/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https-expected.txt: Removed.
  • platform/ios/TestExpectations:
12:18 PM Changeset in webkit [222398] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Usage of ErrorInstance::m_stackTrace on the mutator is racy with the collector
https://bugs.webkit.org/show_bug.cgi?id=177368

Reviewed by Keith Miller.

  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::finishCreation):
(JSC::ErrorInstance::materializeErrorInfoIfNeeded):
(JSC::ErrorInstance::visitChildren):

12:01 PM Changeset in webkit [222397] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[Curl] Use didReceiveBuffer instead of didReceiveData
https://bugs.webkit.org/show_bug.cgi?id=177260

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-09-22
Reviewed by Alex Christensen.

  • platform/network/curl/CurlCacheEntry.cpp:

(WebCore::CurlCacheEntry::readCachedData):

  • platform/network/curl/MultipartHandle.cpp:

(WebCore::MultipartHandle::didReceiveData):

  • platform/network/curl/ResourceHandleCurlDelegate.cpp:

(WebCore::ResourceHandleCurlDelegate::didReceiveContentData):
(WebCore::ResourceHandleCurlDelegate::handleDataURL):
(WebCore::ResourceHandleCurlDelegate::didReceiveData):
(WebCore::ResourceHandleCurlDelegate::didReceiveDataCallback):

  • platform/network/curl/ResourceHandleCurlDelegate.h:
11:53 AM Changeset in webkit [222396] by wilander@apple.com
  • 19 edits in trunk

Non-prevalent resources should be allowed access to existing cookies in a third-party context
https://bugs.webkit.org/show_bug.cgi?id=177336
<rdar://problem/34578257>

Reviewed by Brent Fulgham.

Source/WebCore:

No new tests. I will update existing tests and add at least
one new test in a follow-up patch,
see https://bugs.webkit.org/show_bug.cgi?id=177337. Need to
land this to meet submission deadline and fix the regression.

This patch restructures what is communicated to the network process,
from two vectors - with user interaction and without user interaction -
to three vectors - to partition, to block, to neither partition nor block.
The previous two vectors did not allow proper categorization into which
domains should be partitioned, blocked, or left alone. That was the cause
of the regression where non-prevalent third-party domains erroneously had
their cookies blocked when they should fall back to the old behavior of
access but no new cookies allowed to be set.

  • loader/ResourceLoadStatistics.cpp:

(WebCore::ResourceLoadStatistics::toString const):
(WebCore::ResourceLoadStatistics::merge):

  • loader/ResourceLoadStatistics.h:
  • platform/network/NetworkStorageSession.h:
  • platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::shouldPartitionCookies const):
(WebCore::NetworkStorageSession::shouldBlockThirdPartyCookies const):
(WebCore::NetworkStorageSession::shouldBlockCookies const):
(WebCore::NetworkStorageSession::setPrevalentDomainsToPartitionOrBlockCookies):
(WebCore::NetworkStorageSession::removePrevalentDomains):
(WebCore::NetworkStorageSession::shouldAllowThirdPartyCookies const): Deleted.
(WebCore::NetworkStorageSession::setPrevalentDomainsWithAndWithoutInteraction): Deleted.

  • platform/network/mac/CookieJarMac.mm:

(WebCore::cookiesInBlockedForURL):
(WebCore::cookiesForURL):

Source/WebKit:

This patch restructures what is communicated to the network process,
from two vectors - with user interaction and without user interaction -
to three vectors - to partition, to block, to neither partition nor block.
The previous two vectors did not allow proper categorization into which
domains should be partitioned, blocked, or left alone. That was the cause
of the regression where non-prevalent third-party domains erroneously had
their cookies blocked when they should fall back to the old behavior of
access but no new cookies allowed to be set.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::updatePrevalentDomainsToPartitionOrBlockCookies):
(WebKit::NetworkProcess::updatePrevalentDomainsWithAndWithoutInteraction): Deleted.

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • UIProcess/API/Cocoa/WKWebsiteDataStore.mm:

(-[WKWebsiteDataStore _resourceLoadStatisticsSetShouldPartitionCookies:forHost:]):

  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::WebResourceLoadStatisticsStore):
(WebKit::WebResourceLoadStatisticsStore::logUserInteraction):
(WebKit::WebResourceLoadStatisticsStore::scheduleCookiePartitioningUpdateForDomains):
(WebKit::WebResourceLoadStatisticsStore::clearInMemory):
(WebKit::WebResourceLoadStatisticsStore::shouldPartitionCookies const):
(WebKit::WebResourceLoadStatisticsStore::shouldBlockCookies const):
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioning):
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains):
(WebKit::WebResourceLoadStatisticsStore::clearPartitioningStateForDomains):
(WebKit::WebResourceLoadStatisticsStore::resetCookiePartitioningState):

  • UIProcess/WebResourceLoadStatisticsStore.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::updatePrevalentDomainsToPartitionOrBlockCookies):
(WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback):
(WebKit::WebsiteDataStore::updatePrevalentDomainsWithAndWithoutInteraction): Deleted.

  • UIProcess/WebsiteData/WebsiteDataStore.h:

LayoutTests:

This patch restructures what is communicated to the network process,
from two vectors - with user interaction and without user interaction -
to three vectors - to partition, to block, to neither partition nor block.
The previous two vectors did not allow proper categorization into which
domains should be partitioned, blocked, or left alone. That was the cause
of the regression where non-prevalent third-party domains erroneously had
their cookies blocked when they should fall back to the old behavior of
access but no new cookies allowed to be set.

See follow-up bug to assess these tests:
https://bugs.webkit.org/show_bug.cgi?id=177337

  • http/tests/loading/resourceLoadStatistics/partitioned-and-unpartitioned-cookie-with-network-process-crash.html:
  • http/tests/loading/resourceLoadStatistics/third-party-cookie-with-and-without-user-interaction.html:
  • platform/mac-wk2/TestExpectations:

Marked two new failures since the need to be reworked in:
https://bugs.webkit.org/show_bug.cgi?id=177337

11:44 AM Changeset in webkit [222395] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[CMake][Win] EventTargetInterfaces.h are generated twice
https://bugs.webkit.org/show_bug.cgi?id=177286

Patch by Fujii Hironori <Fujii Hironori> on 2017-09-22
Reviewed by Brent Fulgham.

EventTargetInterfaces.h are generated twice in both
WebCoreDerivedSources.vcxproj and WebCore.vcxproj. This causes
unnecessary recompilation in CMake VisualStudio build.

WebCore target already has a dependency to WebCoreDerivedSources
target by calling add_dependencies. WebCore target doesn't need to
generate it.

  • CMakeLists.txt: Don't ADD_SOURCE_WEBCORE_DERIVED_DEPENDENCIES with EventTargetInterfaces.h.
11:11 AM Changeset in webkit [222394] by Michael Catanzaro
  • 12 edits in trunk

Remove build-webkit's notion of feature flags having a default value
https://bugs.webkit.org/show_bug.cgi?id=177338

Reviewed by Alex Christensen.

.:

Add an ENABLE_EXPERIMENTAL_FEATURES flag and use it to enable certain features.

  • Source/cmake/OptionsGTK.cmake:
  • Source/cmake/OptionsWPE.cmake:
  • Source/cmake/WebKitFeatures.cmake:

Source/WebKit:

Use ENABLE_EXPERIMENTAL_FEATURES instead of ENABLE_DEVELOPER_MODE to enable runtime
experimental features.

  • Shared/WebPreferencesDefinitions.h:

Tools:

Delegate feature flag default values to the build system.
(FeatureDefines.xcconfig for Xcode, WebKitFeatures.cmake and Options*.cmake for CMake, and FeatureDefines.h for everyone)

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/master.cfg:

(Factory.init):
Update GTK and WPE buildbot configuration to use --no-experimental-features on old stable
bots instead of --default-cmake-features.

  • Scripts/build-webkit:

(cMakeArgsFromFeatures):
Default feature values to 'undef'.
Remove the --default-cmake-features argument; it is now the default.
Add --no-experimental-features to replace it.
Stop printing the default feature flag value in the help.
Avoid propagating undefined values to the build system;
only mention flags that are overridden on the command line.

This has the nice side effect of using the default CMake features
for CMake builds, but still allowing toggling of them using the
prettier --FEATURE and --no-FEATURE arguments.

  • Scripts/webkitdirs.pm:

(generateBuildSystemFromCMakeProject):
No longer need to suppress CMake warnings about unused arguments.

  • Scripts/webkitperl/FeatureList.pm:

Remove the default values from the feature list.

10:45 AM Changeset in webkit [222393] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

Add asserts against layout time render tree mutations
https://bugs.webkit.org/show_bug.cgi?id=177361

Reviewed by Zalan Bujtas.

We don't have any mutations left. Add asserts.

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::insertChildInternal):
(WebCore::RenderElement::removeChildInternal):

10:13 AM Changeset in webkit [222392] by Chris Dumez
  • 79 edits
    1 copy in trunk

Use high resolution timestamp for event time
https://bugs.webkit.org/show_bug.cgi?id=154246
<rdar://problem/34333304>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

Rebaseline WPT test now that more checks are passing.

  • web-platform-tests/dom/events/Event-timestamp-high-resolution-expected.txt:

Source/WebCore:

Have event.timeStamp return a DOMHighResTimeStamp instead of a DOMResTimeStamp. It now
has better precision, is monotonic and is relative to PerformanceTiming.navigationStart.

This is as per:

Chrome, Firefox and Edge all already ship this so the compatibility risk should be low.

Also use WallTime / MonotonicTime instead of double type for clarity.

Test: imported/w3c/web-platform-tests/dom/events/Event-timestamp-high-resolution.html

  • WebCore.xcodeproj/project.pbxproj:
  • dom/DOMHighResTimeStamp.h: Copied from Source/WebKit/Shared/WebTouchEvent.cpp.
  • dom/Element.cpp:

(WebCore::Element::dispatchMouseForceWillBegin):

  • dom/Event.cpp:

(WebCore::Event::Event):
(WebCore::Event::timeStampForBindings const):

  • dom/Event.h:

(WebCore::Event::timeStamp const):

  • dom/Event.idl:
  • dom/KeyboardEvent.cpp:

(WebCore::KeyboardEvent::KeyboardEvent):

  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):

  • dom/MouseEvent.h:
  • dom/MouseRelatedEvent.cpp:

(WebCore::MouseRelatedEvent::MouseRelatedEvent):

  • dom/MouseRelatedEvent.h:
  • dom/SimulatedClick.cpp:
  • dom/TouchEvent.cpp:

(WebCore::TouchEvent::TouchEvent):

  • dom/UIEvent.cpp:

(WebCore::UIEvent::UIEvent):

  • dom/UIEvent.h:
  • dom/UIEventWithKeyState.h:

(WebCore::UIEventWithKeyState::UIEventWithKeyState):

  • dom/WheelEvent.cpp:

(WebCore::WheelEvent::WheelEvent):

  • html/TypeAhead.cpp:

(WebCore::TypeAhead::TypeAhead):
(WebCore::TypeAhead::handleEvent):

  • html/TypeAhead.h:
  • page/AutoscrollController.cpp:

(WebCore::AutoscrollController::AutoscrollController):
(WebCore::AutoscrollController::updateDragAndDrop):
(WebCore::AutoscrollController::autoscrollTimerFired):

  • page/AutoscrollController.h:
  • page/ContextMenuController.cpp:

(WebCore::ContextMenuController::showContextMenuAt):

  • page/DragController.cpp:

(WebCore::createMouseEvent):

  • page/EventHandler.cpp:

(WebCore::EventHandler::dispatchDragEvent):
(WebCore::EventHandler::sendContextMenuEventForKey):
(WebCore::EventHandler::fakeMouseMoveEventTimerFired):

  • page/EventHandler.h:
  • page/Performance.cpp:

(WebCore::Performance::now const):
(WebCore::Performance::relativeTimeFromTimeOriginInReducedResolution const):

  • page/Performance.h:
  • page/ios/EventHandlerIOS.mm:

(WebCore::EventHandler::tryToBeginDataInteractionAtPoint):

  • page/win/EventHandlerWin.cpp:
  • platform/PlatformEvent.h:

(WebCore::PlatformEvent::timestamp const):
(WebCore::PlatformEvent::PlatformEvent):

  • platform/PlatformKeyboardEvent.h:

(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):

  • platform/PlatformMouseEvent.h:

(WebCore::PlatformMouseEvent::PlatformMouseEvent):

  • platform/PlatformWheelEvent.h:

(WebCore::PlatformWheelEvent::PlatformWheelEvent):

  • platform/cocoa/ScrollController.mm:

(WebCore::ScrollController::handleWheelEvent):

  • platform/glib/EventHandlerGLib.cpp:
  • platform/gtk/ScrollAnimatorGtk.cpp:

(WebCore::ScrollAnimatorGtk::computeVelocity):
(WebCore::ScrollAnimatorGtk::handleWheelEvent):

  • platform/ios/PlatformEventFactoryIOS.mm:

(WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):
(WebCore::PlatformWheelEventBuilder::PlatformWheelEventBuilder):
(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
(WebCore::PlatformTouchEventBuilder::PlatformTouchEventBuilder):

  • platform/mac/PlatformEventFactoryMac.h:
  • platform/mac/PlatformEventFactoryMac.mm:

(WebCore::eventTimeStampSince1970):

Source/WebKit:

Use WallTime / MonotonicTime instead of double type for clarity.

  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<WallTime>::encode):
(IPC::ArgumentCoder<WallTime>::decode):

  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebEvent.cpp:

(WebKit::WebEvent::WebEvent):

  • Shared/WebEvent.h:

(WebKit::WebEvent::timestamp const):
(WebKit::WebTouchEvent::WebTouchEvent):

  • Shared/WebKeyboardEvent.cpp:

(WebKit::WebKeyboardEvent::WebKeyboardEvent):

  • Shared/WebMouseEvent.cpp:

(WebKit::WebMouseEvent::WebMouseEvent):

  • Shared/WebTouchEvent.cpp:

(WebKit::WebTouchEvent::WebTouchEvent):

  • Shared/WebWheelEvent.cpp:

(WebKit::WebWheelEvent::WebWheelEvent):

  • Shared/gtk/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):
(WebKit::WebEventFactory::createWebTouchEvent):

  • Shared/ios/NativeWebTouchEventIOS.mm:

(WebKit::NativeWebTouchEvent::NativeWebTouchEvent):

  • Shared/ios/WebIOSEventFactory.mm:

(WebIOSEventFactory::createWebKeyboardEvent):

  • Shared/mac/NativeWebGestureEventMac.mm:

(WebKit::NativeWebGestureEvent::NativeWebGestureEvent):

  • Shared/mac/WebEventFactory.mm:

(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebKeyboardEvent):

  • Shared/mac/WebGestureEvent.h:

(WebKit::WebGestureEvent::WebGestureEvent):

  • Shared/wpe/WebEventFactory.cpp:

(WebKit::WebEventFactory::createWebKeyboardEvent):
(WebKit::WebEventFactory::createWebMouseEvent):
(WebKit::WebEventFactory::createWebWheelEvent):
(WebKit::WebEventFactory::createWebTouchEvent):

  • WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:

(WKBundlePageSimulateMouseDown):
(WKBundlePageSimulateMouseUp):
(WKBundlePageSimulateMouseMotion):

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::showContextMenuAtPoint):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::createWebEvent const):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::navigateToPDFLinkWithSimulatedClick):
(WebKit::WebPage::contextMenuAtPointInWindow):
(WebKit::WebPage::dragEnded):
(WebKit::WebPage::simulateMouseDown):
(WebKit::WebPage::simulateMouseUp):
(WebKit::WebPage::simulateMouseMotion):

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::handleSyntheticClick):
(WebKit::WebPage::completeSyntheticClick):
(WebKit::WebPage::requestAdditionalItemsForDragSession):
(WebKit::WebPage::inspectorNodeSearchMovedToPosition):

Source/WebKitLegacy/ios:

Use WallTime / MonotonicTime instead of double type for clarity.

  • WebView/WebPDFViewPlaceholder.mm:

(-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):

Source/WebKitLegacy/mac:

Use WallTime / MonotonicTime instead of double type for clarity.

  • DOM/DOMEvent.mm:

(-[DOMEvent timeStamp]):

  • WebView/WebFrame.mm:

(-[WebFrame _dragSourceEndedAt:operation:]):

  • WebView/WebPDFView.mm:

(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

9:33 AM Changeset in webkit [222391] by timothy_horton@apple.com
  • 5 edits in trunk/Websites/webkit.org

Update some links in demos

  • demos/safe-area-insets/1-default.html:
  • demos/safe-area-insets/2-viewport-fit.html:
  • demos/safe-area-insets/3-safe-area-constants.html:
  • demos/safe-area-insets/4-min-max.html:
9:23 AM Changeset in webkit [222390] by Ryan Haddad
  • 8 edits
    47 copies
    22 adds
    1 delete in trunk/LayoutTests

Move test expectations from 'ios-11' to 'ios' directory.
https://bugs.webkit.org/show_bug.cgi?id=177167

Unreviewed test gardening.

  • platform/ios-11/TestExpectations: Removed.
  • platform/ios-11/fast/text/emoji-expected.txt: Removed.
  • platform/ios-11/fast/text/international/system-language/system-font-punctuation-expected.txt: Removed.
  • platform/ios-11/http/tests/security/contentSecurityPolicy/audio-redirect-blocked-expected.txt: Removed.
  • platform/ios-11/http/tests/security/contentSecurityPolicy/video-redirect-blocked-expected.txt: Removed.
  • platform/ios-11/mathml/presentation/mo-stretch-expected.txt: Removed.
  • platform/ios-11/mathml/presentation/roots-expected.txt: Removed.
  • platform/ios-11/mathml/radical-fallback-expected.txt: Removed.
  • platform/ios/TestExpectations:
  • platform/ios/crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt: Renamed from LayoutTests/platform/ios-11/crypto/subtle/rsa-generate-key-malformed-parameters-expected.txt.
  • platform/ios/crypto/subtle/rsa-import-key-malformed-parameters-expected.txt: Renamed from LayoutTests/platform/ios-11/crypto/subtle/rsa-import-key-malformed-parameters-expected.txt.
  • platform/ios/fast/css/getComputedStyle/computed-style-font-family-expected.txt: Renamed from LayoutTests/platform/ios-11/fast/css/getComputedStyle/computed-style-font-family-expected.txt.
  • platform/ios/fast/text/font-selection-font-face-parse-expected.txt: Renamed from LayoutTests/platform/ios-11/fast/text/font-selection-font-face-parse-expected.txt.
  • platform/ios/fast/text/font-selection-font-loading-api-parse-expected.txt: Renamed from LayoutTests/platform/ios-11/fast/text/font-selection-font-loading-api-parse-expected.txt.
  • platform/ios/fast/text/font-stretch-parse-expected.txt: Renamed from LayoutTests/platform/ios-11/fast/text/font-stretch-parse-expected.txt.
  • platform/ios/fast/text/font-style-parse-expected.txt: Renamed from LayoutTests/platform/ios-11/fast/text/font-style-parse-expected.txt.
  • platform/ios/fast/text/font-weight-parse-expected.txt: Renamed from LayoutTests/platform/ios-11/fast/text/font-weight-parse-expected.txt.
  • platform/ios/fast/text/international/system-language/system-font-punctuation-expected.txt:
  • platform/ios/http/tests/quicklook/at-import-stylesheet-blocked-expected.txt: Renamed from LayoutTests/platform/ios-11/http/tests/quicklook/at-import-stylesheet-blocked-expected.txt.
  • platform/ios/http/tests/quicklook/base-url-blocked-expected.txt: Renamed from LayoutTests/platform/ios-11/http/tests/quicklook/base-url-blocked-expected.txt.
  • platform/ios/http/tests/quicklook/cross-origin-iframe-blocked-expected.txt: Renamed from LayoutTests/platform/ios-11/http/tests/quicklook/cross-origin-iframe-blocked-expected.txt.
  • platform/ios/http/tests/quicklook/csp-header-ignored-expected.txt: Renamed from LayoutTests/platform/ios-11/http/tests/quicklook/csp-header-ignored-expected.txt.
  • platform/ios/http/tests/quicklook/document-domain-is-empty-string-expected.txt: Renamed from LayoutTests/platform/ios-11/http/tests/quicklook/document-domain-is-empty-string-expected.txt.
  • platform/ios/http/tests/quicklook/external-stylesheet-blocked-expected.txt: Renamed from LayoutTests/platform/ios-11/http/tests/quicklook/external-stylesheet-blocked-expected.txt.
  • platform/ios/http/tests/quicklook/hide-referer-on-navigation-expected.txt: Renamed from LayoutTests/platform/ios-11/http/tests/quicklook/hide-referer-on-navigation-expected.txt.
  • platform/ios/http/tests/quicklook/submit-form-blocked-expected.txt: Renamed from LayoutTests/platform/ios-11/http/tests/quicklook/submit-form-blocked-expected.txt.
  • platform/ios/http/tests/quicklook/top-navigation-blocked-expected.txt: Renamed from LayoutTests/platform/ios-11/http/tests/quicklook/top-navigation-blocked-expected.txt.
  • platform/ios/http/tests/security/contentSecurityPolicy/audio-redirect-blocked-expected.txt:
  • platform/ios/http/tests/security/contentSecurityPolicy/video-redirect-blocked-expected.txt:
  • platform/ios/http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt: Renamed from LayoutTests/platform/ios-11/http/tests/websocket/tests/hybi/secure-cookie-secure-connection-expected.txt.
  • platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.worker-expected.txt: Renamed from LayoutTests/platform/ios-11/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.worker-expected.txt.
  • platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_empty.https-expected.txt: Renamed from LayoutTests/platform/ios-11/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_long_empty.https-expected.txt.
  • platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_empty.https-expected.txt: Renamed from LayoutTests/platform/ios-11/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/test_pbkdf2_short_empty.https-expected.txt.
  • platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.worker-expected.txt: Renamed from LayoutTests/platform/ios-11/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/failures_RSA-PSS.worker-expected.txt.
  • platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-PSS.worker-expected.txt: Renamed from LayoutTests/platform/ios-11/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSA-PSS.worker-expected.txt.
  • platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_failures.https-expected.txt: Renamed from LayoutTests/platform/ios-11/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_failures.https-expected.txt.
  • platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_failures_RSA-PSS.https-expected.txt: Renamed from LayoutTests/platform/ios-11/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_failures_RSA-PSS.https-expected.txt.
  • platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSA-PSS.https-expected.txt: Renamed from LayoutTests/platform/ios-11/imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/test_successes_RSA-PSS.https-expected.txt.
  • platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker-expected.txt: Renamed from LayoutTests/platform/ios-11/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/rsa_importKey.worker-expected.txt.
  • platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https-expected.txt: Renamed from LayoutTests/platform/ios-11/imported/w3c/web-platform-tests/WebCryptoAPI/import_export/test_rsa_importKey.https-expected.txt.
  • platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/rsa_pkcs.worker-expected.txt: Renamed from LayoutTests/platform/ios-11/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/rsa_pkcs.worker-expected.txt.
  • platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/rsa_pss.worker-expected.txt: Renamed from LayoutTests/platform/ios-11/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/rsa_pss.worker-expected.txt.
  • platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/test_rsa_pkcs.https-expected.txt: Renamed from LayoutTests/platform/ios-11/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/test_rsa_pkcs.https-expected.txt.
  • platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/test_rsa_pss.https-expected.txt: Renamed from LayoutTests/platform/ios-11/imported/w3c/web-platform-tests/WebCryptoAPI/sign_verify/test_rsa_pss.https-expected.txt.
  • platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/test_wrapKey_unwrapKey.https-expected.txt: Renamed from LayoutTests/platform/ios-11/imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/test_wrapKey_unwrapKey.https-expected.txt.
  • platform/ios/imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/wrapKey_unwrapKey.worker-expected.txt: Renamed from LayoutTests/platform/ios-11/imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/wrapKey_unwrapKey.worker-expected.txt.
  • platform/ios/imported/w3c/web-platform-tests/XMLHttpRequest/send-blob-with-no-mime-type-expected.txt: Renamed from LayoutTests/platform/ios-11/imported/w3c/web-platform-tests/XMLHttpRequest/send-blob-with-no-mime-type-expected.txt.
  • platform/ios/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any-expected.txt: Renamed from LayoutTests/platform/ios-11/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any-expected.txt.
  • platform/ios/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt: Renamed from LayoutTests/platform/ios-11/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt.
  • platform/ios/mathml/presentation/mo-stretch-expected.txt:
  • platform/ios/mathml/presentation/roots-expected.txt:
  • platform/ios/mathml/radical-fallback-expected.txt:
  • platform/ios/platform/ios/ios/fast/text/opticalFont-expected.txt: Renamed from LayoutTests/platform/ios-11/platform/ios/ios/fast/text/opticalFont-expected.txt.
  • platform/ios/platform/ios/ios/fast/text/opticalFontWithTextStyle-expected.txt: Renamed from LayoutTests/platform/ios-11/platform/ios/ios/fast/text/opticalFontWithTextStyle-expected.txt.
  • platform/ios/platform/ios/ios/fast/text/opticalFontWithWeight-expected.txt: Renamed from LayoutTests/platform/ios-11/platform/ios/ios/fast/text/opticalFontWithWeight-expected.txt.
  • platform/ios/quicklook/excel-expected.txt: Renamed from LayoutTests/platform/ios-11/quicklook/excel-expected.txt.
  • platform/ios/quicklook/excel-legacy-expected.txt: Renamed from LayoutTests/platform/ios-11/quicklook/excel-legacy-expected.txt.
  • platform/ios/quicklook/excel-macro-enabled-expected.txt: Renamed from LayoutTests/platform/ios-11/quicklook/excel-macro-enabled-expected.txt.
  • platform/ios/quicklook/powerpoint-expected.txt: Renamed from LayoutTests/platform/ios-11/quicklook/powerpoint-expected.txt.
  • platform/ios/quicklook/powerpoint-legacy-expected.txt: Renamed from LayoutTests/platform/ios-11/quicklook/powerpoint-legacy-expected.txt.
  • platform/ios/quicklook/word-expected.txt: Renamed from LayoutTests/platform/ios-11/quicklook/word-expected.txt.
  • platform/ios/quicklook/word-legacy-expected.txt: Renamed from LayoutTests/platform/ios-11/quicklook/word-legacy-expected.txt.
9:02 AM Changeset in webkit [222389] by jmarcell@apple.com
  • 2 edits in tags/Safari-605.1.7.1/Source/WebCore

Cherry-pick r222372. rdar://problem/34575544

8:43 AM Changeset in webkit [222388] by nael.ouedraogo@crf.canon.fr
  • 9 edits in trunk

[GTK] HTMLMediaElement resize event not fired when video size changes
https://bugs.webkit.org/show_bug.cgi?id=174582

Reviewed by Xabier Rodriguez-Calvar.

Modify AppendPipeline to notify MediaPlayerPrivateGStreamerMSE that a track is detected
not only for the initial track detection but also for subsequent in particular when the
video size has changed.

Update test expectation for new passing tests.

Source/WebCore:

  • platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::appsinkCapsChanged):
(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsink):

  • platform/graphics/gstreamer/mse/AppendPipeline.h:
  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::trackDetected):

  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.h:
  • platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:

(WebCore::PlaybackPipeline::reattachTrack):

  • platform/graphics/gstreamer/mse/PlaybackPipeline.h:

LayoutTests:

  • platform/gtk/TestExpectations:
7:45 AM Changeset in webkit [222387] by Ms2ger@igalia.com
  • 4 edits in trunk

[GTK] Couple of pasteboard related tests are failing after r222228
https://bugs.webkit.org/show_bug.cgi?id=177295

Reviewed by Michael Catanzaro.

Source/WebCore:

Call writeToClipboard() from Pasteboard::writeString() on GTK.

When writePasteboard was replaced by commitToPasteboard in r222228,
the call to writeToClipboard() did not make it into the
platform-neutral code. This attempts to find another place in the
GTK-specific code to make the call.

Tests: editing/pasteboard/copy-without-selection.html

editing/pasteboard/pasting-empty-html-falls-back-to-text.html

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::writeString):

LayoutTests:

  • platform/gtk/TestExpectations: mark the tests as passing again.
7:39 AM Changeset in webkit [222386] by zandobersek@gmail.com
  • 4 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Adding failure expectations for failure tests
that mostly originate from recent font code changes and WPT updates.
Updating baselines for two tests that aren't failing otherwise.

  • platform/gtk/TestExpectations:
  • platform/gtk/imported/w3c/web-platform-tests/media-source/interfaces-expected.txt:
  • platform/gtk/js/dom/global-constructors-attributes-expected.txt:
7:30 AM Changeset in webkit [222385] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit

[GTK] Web Inspector: Can't load three.js
https://bugs.webkit.org/show_bug.cgi?id=177340

Patch by Fujii Hironori <Fujii Hironori> on 2017-09-22
Reviewed by Carlos Garcia Campos.

  • PlatformGTK.cmake: Add JS files of three.js to InspectorFiles variable.
  • PlatformWPE.cmake: Ditto.
5:19 AM Changeset in webkit [222384] by Yusuke Suzuki
  • 14 edits
    1 add in trunk

[DFG][FTL] Profile array vector length for array allocation
https://bugs.webkit.org/show_bug.cgi?id=177051

Reviewed by Saam Barati.

JSTests:

  • microbenchmarks/new-array-buffer-vector-profile.js: Added.

(target):

Source/JavaScriptCore:

Currently, NewArrayBuffer allocation is penalized by JSC: While empty array gets 25 vector size (BASE_CONTIGUOUS_VECTOR_LEN),
new_array_buffer case gets 3 vector size (BASE_CONTIGUOUS_VECTOR_LEN). Surely, new_array_buffer can get larger vector size
if the number of its constant elements is larger than 3. But these created array may be grown by push() operation after
the allocation. In this case, new_array_buffer is penalized compared to empty array allocation.

empty array allocation,

var array = [];
array.push(0);
array.push(1);
array.push(2);
array.push(3);
array.push(4);

v.s. new_array_buffer case,

var array = [0];
array.push(1);
array.push(2);
array.push(3);
array.push(4);

In this case, the latter becomes slow. While we have a chance to reduce memory usage if new_array_buffer is not grown (and a bit likely),
we should allocate 3 to 25 vector size if it is likely grown. So we should get profile on the resulted array.

We select 25 to make it fit to one of size classes.

In this patch, we extend ArrayAllocationProfile to record vector length. And use this information when allocating array for new_array_buffer.
If the number of new_array_buffer constants is <= 25, array vector size would become 3 to 25 based on profiling. If the number of its constants
is larger than 25, we just use it for allocation as before.

Added microbenchmark and SixSpeed spread-literal.es5 shows improvement.

new-array-buffer-vector-profile 67.4706+-3.7625 28.4249+-1.9025 definitely 2.3736x faster
spread-literal.es5 133.1443+-9.2253 95.2667+-0.5740 definitely 1.3976x faster

  • bytecode/ArrayAllocationProfile.cpp:

(JSC::ArrayAllocationProfile::updateProfile):
(JSC::ArrayAllocationProfile::updateIndexingType): Deleted.

  • bytecode/ArrayAllocationProfile.h:

(JSC::ArrayAllocationProfile::selectIndexingType):
(JSC::ArrayAllocationProfile::vectorLengthHint):
(JSC::ArrayAllocationProfile::ArrayAllocationProfile): Deleted.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::updateAllArrayPredictions):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGNode.h:

(JSC::DFG::Node::vectorLengthHint):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileArraySlice):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayBuffer):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSize):
(JSC::FTL::DFG::LowerDFGToB3::allocateJSArray):
(JSC::FTL::DFG::LowerDFGToB3::allocateUninitializedContiguousJSArrayInternal):
(JSC::FTL::DFG::LowerDFGToB3::allocateUninitializedContiguousJSArray):

  • runtime/ArrayConventions.h:
  • runtime/JSArray.h:

(JSC::JSArray::tryCreate):

4:53 AM Changeset in webkit [222383] by zandobersek@gmail.com
  • 1 edit
    2 adds in trunk/LayoutTests

Unreviewed GTK+ and WPE gardening. Adding baselines for the
imported W3C WebCryptoAPI pbkdf2.worker.html where the
libgcrypt-based implementation is exhibiting somewhat different
behavior than what's expected in the generic baseline.

  • platform/gtk/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.worker-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/WebCryptoAPI/derive_bits_keys/pbkdf2.worker-expected.txt: Added.
3:25 AM Changeset in webkit [222382] by Yusuke Suzuki
  • 14 edits
    1 delete in trunk

Unreviewed, rolling out r222380.
https://bugs.webkit.org/show_bug.cgi?id=177352

Octane/box2d shows 8% regression (Requested by yusukesuzuki on
#webkit).

Reverted changeset:

"[DFG][FTL] Profile array vector length for array allocation"
https://bugs.webkit.org/show_bug.cgi?id=177051
http://trac.webkit.org/changeset/222380

Patch by Commit Queue <commit-queue@webkit.org> on 2017-09-22

2:51 AM Changeset in webkit [222381] by zandobersek@gmail.com
  • 7 edits
    1 add in trunk/LayoutTests

LayoutTests/imported/w3c:
Unreviewed WPE gardening. Updating the WPT EME idlharness.html
baseline -- it's not port-specific since there should be no
differences in the Web-exposed APIs for this feature across
ports.

  • web-platform-tests/encrypted-media/idlharness-expected.txt:

LayoutTests:
Unreviewed WPE gardening. Updating a couple of css2.1 baselines,
adding a missing baseline for a new imported WPT test.

  • platform/wpe/css2.1/t100801-c548-ln-ht-02-b-ag-expected.txt:
  • platform/wpe/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
  • platform/wpe/css2.1/t1601-c547-indent-00-b-a-expected.txt:
  • platform/wpe/css2.1/t1604-c542-letter-sp-00-b-a-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/encrypted-media-default-feature-policy.https.sub-expected.txt: Added.
1:22 AM Changeset in webkit [222380] by Yusuke Suzuki
  • 14 edits
    1 add in trunk

[DFG][FTL] Profile array vector length for array allocation
https://bugs.webkit.org/show_bug.cgi?id=177051

Reviewed by Saam Barati.

JSTests:

  • microbenchmarks/new-array-buffer-vector-profile.js: Added.

(target):

Source/JavaScriptCore:

Currently, NewArrayBuffer allocation is penalized by JSC: While empty array gets 25 vector size (BASE_CONTIGUOUS_VECTOR_LEN),
new_array_buffer case gets 3 vector size (BASE_CONTIGUOUS_VECTOR_LEN). Surely, new_array_buffer can get larger vector size
if the number of its constant elements is larger than 3. But these created array may be grown by push() operation after
the allocation. In this case, new_array_buffer is penalized compared to empty array allocation.

empty array allocation,

var array = [];
array.push(0);
array.push(1);
array.push(2);
array.push(3);
array.push(4);

v.s. new_array_buffer case,

var array = [0];
array.push(1);
array.push(2);
array.push(3);
array.push(4);

In this case, the latter becomes slow. While we have a chance to reduce memory usage if new_array_buffer is not grown (and a bit likely),
we should allocate 3 to 25 vector size if it is likely grown. So we should get profile on the resulted array.

We select 25 to make it fit to one of size classes.

In this patch, we extend ArrayAllocationProfile to record vector length. And use this information when allocating array for new_array_buffer.
If the number of new_array_buffer constants is <= 25, array vector size would become 3 to 25 based on profiling. If the number of its constants
is larger than 25, we just use it for allocation as before.

Added microbenchmark and SixSpeed spread-literal.es5 shows improvement.

new-array-buffer-vector-profile 67.4706+-3.7625 28.4249+-1.9025 definitely 2.3736x faster
spread-literal.es5 133.1443+-9.2253 95.2667+-0.5740 definitely 1.3976x faster

  • bytecode/ArrayAllocationProfile.cpp:

(JSC::ArrayAllocationProfile::updateProfile):
(JSC::ArrayAllocationProfile::updateIndexingType): Deleted.

  • bytecode/ArrayAllocationProfile.h:

(JSC::ArrayAllocationProfile::selectIndexingType):
(JSC::ArrayAllocationProfile::vectorLengthHint):
(JSC::ArrayAllocationProfile::ArrayAllocationProfile): Deleted.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::updateAllArrayPredictions):

  • dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::dump):

  • dfg/DFGNode.h:

(JSC::DFG::Node::vectorLengthHint):

  • dfg/DFGOperations.cpp:
  • dfg/DFGOperations.h:
  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

  • ftl/FTLLowerDFGToB3.cpp:

(JSC::FTL::DFG::LowerDFGToB3::compileArraySlice):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayBuffer):
(JSC::FTL::DFG::LowerDFGToB3::compileNewArrayWithSize):
(JSC::FTL::DFG::LowerDFGToB3::allocateJSArray):
(JSC::FTL::DFG::LowerDFGToB3::allocateUninitializedContiguousJSArrayInternal):
(JSC::FTL::DFG::LowerDFGToB3::allocateUninitializedContiguousJSArray):

  • runtime/ArrayConventions.h:
  • runtime/JSArray.h:

(JSC::JSArray::tryCreate):

12:21 AM WebDriverStatus edited by Carlos Garcia Campos
window rect is done (diff)

Sep 21, 2017:

11:36 PM Changeset in webkit [222379] by jmarcell@apple.com
  • 7 edits in tags/Safari-605.1.7.1/Source

Versioning.

11:34 PM Changeset in webkit [222378] by jmarcell@apple.com
  • 9 edits in tags/Safari-605.1.7.1

Cherry-pick r222374. rdar://problem/34288629

11:32 PM Changeset in webkit [222377] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.1.7.1

New tag.

6:51 PM Changeset in webkit [222376] by rniwa@webkit.org
  • 4 edits in trunk/Source

Enable dataTransfer.items on macOS and iOS
https://bugs.webkit.org/show_bug.cgi?id=177335

Reviewed by Sam Weinig.

Source/WebKit:

  • Shared/WebPreferencesDefinitions.h:

Source/WebKitLegacy/mac:

  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):

6:08 PM Changeset in webkit [222375] by timothy_horton@apple.com
  • 1 edit
    7 adds in trunk/Websites/webkit.org

Add some blog post resources
https://bugs.webkit.org/show_bug.cgi?id=177333

Reviewed by Sam Weinig.

  • demos/safe-area-insets/1-default.html: Added.
  • demos/safe-area-insets/2-viewport-fit.html: Added.
  • demos/safe-area-insets/3-safe-area-constants.html: Added.
  • demos/safe-area-insets/4-min-max.html: Added.
  • demos/safe-area-insets/safe-areas.html: Added.
  • demos/safe-area-insets/style.css: Added.
5:42 PM Changeset in webkit [222374] by Brent Fulgham
  • 9 edits in trunk

REGRESSION (r221017): iCloud mail logs me out after looking at a few messages
https://bugs.webkit.org/show_bug.cgi?id=177328

Reviewed by Daniel Bates.
<rdar://problem/34288629>

Reviewed by Dan Bates.

Source/WebCore:

This site was triggering a log-out because the page was loading insecure images. We don't treat that as a security
issue for deciding to display mixed content since it can only affect pixels on screen, not trigger a change in
program logic or persistent storage.

Consequently, we can correct thsi compatibility problem without relaxing the security fix by not blocking Secure cookies
when we have merely displayed mixed content (i.e., encountered 'Inactive' mixed content), as opposed to executing mixed
content (i.e., loaded 'Active' mixed content).

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::shouldBlockGeolocationRequests): Revise for new API.

  • dom/SecurityContext.h:

(WebCore::SecurityContext::foundMixedContent const): Change to return an OptionSet of
mixed content types.
(WebCore::SecurityContext::setFoundMixedContent): Accept an enum stating the type of mixed content found.

  • loader/CookieJar.cpp:

(WebCore::cookies): Only block Secure cookies for Active mixed content.
(WebCore::cookieRequestHeaderFieldValue): Ditto.

  • loader/MixedContentChecker.cpp:

(WebCore::MixedContentChecker::canDisplayInsecureContent const): Mark the context as having found 'Inactive'
mixed content.
(WebCore::MixedContentChecker::canRunInsecureContent const): Mark the context as having found 'Active'
mixed content.

LayoutTests:

Rebaseline tests for revised behavior.

  • http/tests/security/mixedContent/insecure-image-with-securecookie-block-expected.txt:
  • http/tests/security/mixedContent/insecure-image-with-securecookie-block.html:
  • http/tests/security/mixedContent/redirect-https-to-http-image-secure-cookies-block-expected.txt:
5:40 PM Changeset in webkit [222373] by Simon Fraser
  • 5 edits in trunk/Source/WebCore

Clean up RenderLayer z-order traversal code
https://bugs.webkit.org/show_bug.cgi?id=177325

Reviewed by Zalan Bujtas.

Remove isStackingContainer() checks before accessing posZOrderList() or negZOrderList();
we already have assertions in place to ensure that only stacking containers have non-null lists.

Use more auto.

No behavior change.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::update3DTransformedDescendantStatus):
(WebCore::RenderLayer::calculateClipRects const):

  • rendering/RenderLayerBacking.cpp:

(WebCore::traverseVisibleNonCompositedDescendantLayers):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::addToOverlapMapRecursive):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::updateLayerTreeGeometry):
(WebCore::RenderLayerCompositor::updateCompositingDescendantGeometry):
(WebCore::RenderLayerCompositor::recursiveRepaintLayer):
(WebCore::RenderLayerCompositor::layerHas3DContent const):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

5:33 PM Changeset in webkit [222372] by pvollan@apple.com
  • 2 edits in trunk/Source/WebCore

Unreviewed Windows build fix after r222360.

  • PlatformWin.cmake:
5:19 PM Changeset in webkit [222371] by Joseph Pecoraro
  • 2 edits in trunk/Tools

Unreviewed, add the ability to skip a test262 test.

  • Scripts/run-jsc-stress-tests:

Other handlers have :skip but a few didn't.

5:16 PM Changeset in webkit [222370] by Ryan Haddad
  • 2 edits in trunk/Tools

Change architecture for ios-ews queue to arm64.
https://bugs.webkit.org/show_bug.cgi?id=177332

Reviewed by Alexey Proskuryakov.

  • Scripts/webkitpy/common/config/ews.json:
4:56 PM Changeset in webkit [222369] by mitz@apple.com
  • 8 copies
    1 add in releases/Apple/iOS 11.0

Added a tag for iOS 11.0.

4:56 PM Changeset in webkit [222368] by mitz@apple.com
  • 9 copies
    1 add in releases/Apple/Safari 11.0

Added a tag for Safari 11.0.

4:52 PM Changeset in webkit [222367] by jmarcell@apple.com
  • 2 edits in tags/Safari-605.1.7/Source/WebCore

Cherry-pick r222360. rdar://problem/34575544

4:51 PM Changeset in webkit [222366] by jmarcell@apple.com
  • 2 edits in tags/Safari-605.1.7/Source/WebKitLegacy

Cherry-pick r222358. rdar://problem/34575958

4:37 PM Changeset in webkit [222365] by commit-queue@webkit.org
  • 18 edits in trunk/Source/WebCore

Remove the need for SetterMayThrowException
https://bugs.webkit.org/show_bug.cgi?id=177099

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-21
Reviewed by Sam Weinig.

No change of behavior.
Introducing AttributeSetter to handle exception raising attribute setters,
based on the C++ class method instead of SetterMayThrowException.
A follow-up patch should remove SetterMayThrowException from the IDLs

  • bindings/js/JSDOMAttribute.h:

(WebCore::AttributeSetter<ExceptionOr<void>>::call):
(WebCore::AttributeSetter<void>::call):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateAttributeSetterBodyDefinition):

  • bindings/scripts/test/JS/JSTestCEReactions.cpp:
  • bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:
  • bindings/scripts/test/JS/JSTestCallTracer.cpp:
  • bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:
  • bindings/scripts/test/JS/JSTestGlobalObject.cpp:
  • bindings/scripts/test/JS/JSTestInterface.cpp:
  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:
  • bindings/scripts/test/JS/JSTestNode.cpp:
  • bindings/scripts/test/JS/JSTestObj.cpp:
  • bindings/scripts/test/JS/JSTestSerialization.cpp:
  • bindings/scripts/test/JS/JSTestSerializationInherit.cpp:
  • bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:
  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
  • bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:
  • bindings/scripts/test/JS/JSTestTypedefs.cpp:
4:30 PM Changeset in webkit [222364] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Use 'ninja' from the SDK if it exists
https://bugs.webkit.org/show_bug.cgi?id=177330

Reviewed by Alex Christensen.

  • Scripts/webkitdirs.pm:

(canUseNinja):
Check for ninja with xcrun in addition to commandExists() for Cocoa platforms.

(generateBuildSystemFromCMakeProject):
(canUseNinjaGenerator): Deleted.
Remove canUseNinjaGenerator; as noted in bug 177057, the Ninja generator
is available in all versions of CMake supported by WebKit.

4:10 PM Changeset in webkit [222363] by rniwa@webkit.org
  • 4 edits
    4 adds in trunk

DataTransfer.items should contain text/html and text/uri-list
https://bugs.webkit.org/show_bug.cgi?id=176772
<rdar://problem/34386899>

Reviewed by Darin Adler.

Source/WebCore:

Expose text/html and text/uri-list in dataTransfer.items.

Tests: editing/pasteboard/datatransfer-items-copy-html.html

editing/pasteboard/datatransfer-items-copy-url.html

  • dom/DataTransferItemList.cpp:

(WebCore::isSupportedType): Added both MIME types.
(WebCore::DataTransferItemList::add): Fixed the bug that new data transfer item was using
the original type string instead of the lowercased one.

LayoutTests:

Added tests for copying text/html and text/uri-list, and updated the existing test for
coping & pasting plain text to explicitly set only text/plain now that
the data transfer item list can contain HTML markup.

  • editing/pasteboard/datatransfer-items-copy-html-expected.txt: Added.
  • editing/pasteboard/datatransfer-items-copy-html.html: Added.
  • editing/pasteboard/datatransfer-items-copy-url-expected.txt: Added.
  • editing/pasteboard/datatransfer-items-copy-url.html: Added.
  • editing/pasteboard/datatransfer-items-paste-plaintext.html:
4:07 PM Changeset in webkit [222362] by Ryan Haddad
  • 1 edit
    1 add in trunk/LayoutTests/imported/w3c

Add missing expectation file.
https://bugs.webkit.org/show_bug.cgi?id=170713

Unreviewed test gardening.

  • web-platform-tests/IndexedDB/nested-cloning-large-multiple-expected.txt: Added.
4:06 PM Changeset in webkit [222361] by commit-queue@webkit.org
  • 2 edits in trunk/LayoutTests

LayoutTest platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=173741

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-21
Reviewed by Alex Christensen.

Making the test more robust by getting the reference canvas to compare with each time a new comparison is done.
Previously, this was done at the start of the comparison.
Also increasing the threshold since we are going from 0 to 255 or vice-versa.

  • platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html:
4:06 PM Changeset in webkit [222360] by pvollan@apple.com
  • 2 edits in trunk/Source/WebCore

[Win] Compile error, PALHeaderDetection.h not found.
https://bugs.webkit.org/show_bug.cgi?id=177309

Reviewed by Brent Fulgham.

Copy PAL header files to WebCore forwarding headers folder.

  • PlatformWin.cmake:
4:05 PM Changeset in webkit [222359] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Add autocompletion suggestions for CSS functions (constant(), linear-gradient(), etc)
https://bugs.webkit.org/show_bug.cgi?id=177264

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-21
Reviewed by Matt Baker.

  • UserInterface/Controllers/CodeMirrorCompletionController.js:

(WI.CodeMirrorCompletionController.prototype._generateCSSCompletions):
Detect when we are inside of functions and provide completion suggestions
for the relevant function.

  • UserInterface/Models/CSSCompletions.js:

Syntax highlight "constant()" like we do for "var()".

  • UserInterface/Models/CSSKeywordCompletions.js:

(WI.CSSKeywordCompletions.forProperty):
Always suggest "constant()" everywhere, like we do for "var()".

(WI.CSSKeywordCompletions.forFunction):
Provide suggestions for some CSS functions.

4:03 PM Changeset in webkit [222358] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKitLegacy

[Win] Compile error, generate-webkitversion.pl script not found.
https://bugs.webkit.org/show_bug.cgi?id=177310

Reviewed by Brent Fulgham.

The script is located using the WebKitLegacy folder cmake variable, which needs
to be set in the project file.

  • WebKitLegacy.vcxproj/WebKitLegacy.proj:
3:43 PM Changeset in webkit [222357] by mitz@apple.com
  • 2 edits in trunk/Source/WebKit

Try to fix Apple internal builds with the iOS 11.0 SDK.

  • Configurations/WebKit.xcconfig: Disable framework header postprocessing for iOS 11.0.
3:32 PM Changeset in webkit [222356] by commit-queue@webkit.org
  • 26 edits
    16 deletes in trunk

Web Inspector: Remove support for CSS Regions
https://bugs.webkit.org/show_bug.cgi?id=177287

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-21
Reviewed by Matt Baker.

Source/JavaScriptCore:

  • inspector/protocol/CSS.json:
  • inspector/protocol/OverlayTypes.json:

Source/WebCore:

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getNamedFlowCollection): Deleted.

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorOverlay.cpp:

(WebCore::buildRendererHighlight):
(WebCore::buildNodeHighlight):
(WebCore::InspectorOverlay::getHighlight const):
(WebCore::buildArrayForRendererFragments):
(WebCore::buildQuadObjectForCSSRegionContentClip): Deleted.

  • inspector/InspectorOverlayPage.js:

(_createElementTitle):
(_drawElementTitle):
(_drawFragmentHighlight):
(drawNodeHighlight):
(_drawRegionNumber): Deleted.
(_quadMidPoint): Deleted.
(_drawRegionLink): Deleted.
(_drawRegionsHighlight): Deleted.

Source/WebInspectorUI:

  • UserInterface/Protocol/CSSObserver.js:

(WI.CSSObserver.prototype.namedFlowCreated):
(WI.CSSObserver.prototype.namedFlowRemoved):
(WI.CSSObserver.prototype.regionLayoutUpdated):
(WI.CSSObserver.prototype.regionOversetChanged):
(WI.CSSObserver.prototype.registeredNamedFlowContentElement):
(WI.CSSObserver.prototype.unregisteredNamedFlowContentElement):
Leave observer functions in for older backends that will send
these messages, but we just ignore them.

  • UserInterface/Base/Main.js:
  • UserInterface/Controllers/DOMTreeManager.js:

(WI.DOMTreeManager):
(WI.DOMTreeManager.prototype._unbind):
(WI.DOMTreeManager._flowPayloadHashKey): Deleted.
(WI.DOMTreeManager.prototype._createContentFlowFromPayload): Deleted.
(WI.DOMTreeManager.prototype._updateContentFlowFromPayload): Deleted.
(WI.DOMTreeManager.prototype.getNamedFlowCollection.onNamedFlowCollectionAvailable): Deleted.
(WI.DOMTreeManager.prototype.getNamedFlowCollection): Deleted.
(WI.DOMTreeManager.prototype.namedFlowCreated): Deleted.
(WI.DOMTreeManager.prototype.namedFlowRemoved): Deleted.
(WI.DOMTreeManager.prototype._sendNamedFlowUpdateEvents): Deleted.
(WI.DOMTreeManager.prototype.regionOversetChanged): Deleted.
(WI.DOMTreeManager.prototype.registeredNamedFlowContentElement): Deleted.
(WI.DOMTreeManager.prototype._removeContentNodeFromFlowIfNeeded): Deleted.
(WI.DOMTreeManager.prototype.unregisteredNamedFlowContentElement): Deleted.
(WI.DOMTreeManager.prototype._coerceRemoteArrayOfDOMNodes.nodeRequested): Deleted.
(WI.DOMTreeManager.prototype._coerceRemoteArrayOfDOMNodes): Deleted.
(WI.DOMTreeManager.prototype.getNodeContentFlowInfo.regionNodesAvailable): Deleted.
(WI.DOMTreeManager.prototype.getNodeContentFlowInfo.remoteObjectPropertiesAvailable): Deleted.
(WI.DOMTreeManager.prototype.getNodeContentFlowInfo.inspectedPage_node_getFlowInfo.getComputedProperty): Deleted.
(WI.DOMTreeManager.prototype.getNodeContentFlowInfo.inspectedPage_node_getFlowInfo.getContentFlowName): Deleted.
(WI.DOMTreeManager.prototype.getNodeContentFlowInfo): Deleted.

  • UserInterface/Images/ContentFlow.svg: Removed.
  • UserInterface/Images/gtk/ContentFlow.svg: Removed.
  • UserInterface/Main.html:
  • UserInterface/Models/Collection.js:
  • UserInterface/Models/ContentFlow.js: Removed.
  • UserInterface/Models/DOMTree.js:

(WI.DOMTree):
(WI.DOMTree.prototype.get frame):
(WI.DOMTree.prototype._framePageExecutionContextChanged):
(WI.DOMTree.prototype.get contentFlowCollection): Deleted.
(WI.DOMTree.prototype.requestContentFlowList): Deleted.
(WI.DOMTree.prototype._isContentFlowInCurrentDocument): Deleted.
(WI.DOMTree.prototype._contentFlowListWasUpdated): Deleted.
(WI.DOMTree.prototype._contentFlowWasAdded): Deleted.
(WI.DOMTree.prototype._contentFlowWasRemoved): Deleted.

  • UserInterface/Test.html:
  • UserInterface/Views/CollectionContentView.js:

(WI.CollectionContentView):

  • UserInterface/Views/ComputedStyleDetailsPanel.css:

(.details-section > .content > .group > .row.simple.content-flow-link > .value > span > .icon): Deleted.

  • UserInterface/Views/ComputedStyleDetailsPanel.js:

(WI.ComputedStyleDetailsPanel.prototype.refresh):
(WI.ComputedStyleDetailsPanel.prototype.initialLayout):
(WI.ComputedStyleDetailsPanel.prototype._handleVariablesSectionCollapsedStateChanged):
(WI.ComputedStyleDetailsPanel):
(WI.ComputedStyleDetailsPanel.prototype.get regionFlow): Deleted.
(WI.ComputedStyleDetailsPanel.prototype.set regionFlow): Deleted.
(WI.ComputedStyleDetailsPanel.prototype.get contentFlow): Deleted.
(WI.ComputedStyleDetailsPanel.prototype.set contentFlow): Deleted.
(WI.ComputedStyleDetailsPanel.prototype.get containerRegions): Deleted.
(WI.ComputedStyleDetailsPanel.prototype.set containerRegions): Deleted.
(WI.ComputedStyleDetailsPanel.prototype.sizeDidChange): Deleted.
(WI.ComputedStyleDetailsPanel.prototype._updateFlowNamesSectionVisibility): Deleted.
(WI.ComputedStyleDetailsPanel.prototype._resetFlowDetails): Deleted.
(WI.ComputedStyleDetailsPanel.prototype._refreshFlowDetails.contentFlowInfoReady): Deleted.
(WI.ComputedStyleDetailsPanel.prototype._refreshFlowDetails): Deleted.
(WI.ComputedStyleDetailsPanel.prototype._goToRegionFlowArrowWasClicked): Deleted.
(WI.ComputedStyleDetailsPanel.prototype._goToContentFlowArrowWasClicked): Deleted.

  • UserInterface/Views/ContentFlowDOMTreeContentView.js: Removed.
  • UserInterface/Views/ContentFlowIcon.css: Removed.
  • UserInterface/Views/ContentFlowTreeElement.js: Removed.
  • UserInterface/Views/ContentView.js:

(WI.ContentView.createFromRepresentedObject):
(WI.ContentView.isViewable):

  • UserInterface/Views/FrameTreeElement.js:

(WI.FrameTreeElement.prototype.onpopulate):
(WI.FrameTreeElement.prototype.onexpand):
(WI.FrameTreeElement.prototype._childContentFlowWasAdded): Deleted.
(WI.FrameTreeElement.prototype._childContentFlowWasRemoved): Deleted.
(WI.FrameTreeElement.prototype._rootDOMNodeInvalidated): Deleted.

  • UserInterface/Views/ResourceSidebarPanel.js:

(WI.ResourceSidebarPanel.prototype._treeSelectionDidChange):

  • UserInterface/Views/ResourcesTabContentView.js:

(WI.ResourcesTabContentView):
(WI.ResourcesTabContentView.prototype.canShowRepresentedObject):

LayoutTests:

  • inspector/dom/content-flow-content-nodes-expected.txt: Removed.
  • inspector/dom/content-flow-content-nodes.html: Removed.
  • inspector/dom/content-flow-content-removal-expected.txt: Removed.
  • inspector/dom/content-flow-content-removal.html: Removed.
  • inspector/dom/content-flow-list-expected.txt: Removed.
  • inspector/dom/content-flow-list.html: Removed.
  • inspector/dom/content-node-region-info-expected.txt: Removed.
  • inspector/dom/content-node-region-info.html: Removed.
  • inspector/dom/highlight-flow-with-no-region-expected.txt: Removed.
  • inspector/dom/highlight-flow-with-no-region.html: Removed.
3:08 PM Changeset in webkit [222355] by Chris Dumez
  • 4 edits in trunk

Regression(r222308): new API tests are failing for !NETWORK_SESSION
https://bugs.webkit.org/show_bug.cgi?id=177321

Reviewed by Alex Christensen.

Source/WebKit:

When a load is redirected and then converted into a download, CFNetwork
seems to call [NSURLDownloadDelegate willSendRequest:] on the download
with a non-nil redirectResponse, which was unexpected.

To address the issue, we now ignore the willSendRequest call if the
new request's URL is the same as the redirectResponse one.

  • NetworkProcess/Downloads/mac/DownloadMac.mm:

(-[WKDownloadAsDelegate download:willSendRequest:redirectResponse:]):

Tools:

Unskip API tests now that they pass everywhere.

  • TestWebKitAPI/Tests/WebKitCocoa/Download.mm:

(TEST):

2:58 PM Changeset in webkit [222354] by Joseph Pecoraro
  • 2 edits in trunk/JSTests

Skip new hanging test262 tests.
https://bugs.webkit.org/show_bug.cgi?id=177326

Unreviewed test gardening.

  • test262.yaml:
2:45 PM Changeset in webkit [222353] by fpizlo@apple.com
  • 3 edits in trunk/Tools

Unreviewed, fix ability to run tests in browser.

  • WebGPUShadingLanguageRI/Test.html:
  • WebGPUShadingLanguageRI/index.html:
2:37 PM Changeset in webkit [222352] by Jonathan Bedard
  • 2 edits in trunk/Tools

webkitpy: Ignore failure to get updated selenium version
https://bugs.webkit.org/show_bug.cgi?id=177205
<rdar://problem/34531669>

Reviewed by Lucas Forschler.

Sometime asking PyPI for the latest version of Selenium fails. We should try and
fallback to, at a minimum, version 3.5.0 or a newer installed version.

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook.greater_than_equal_to_version): Return true if the second
version string is greater than or equal to the first version string.
(AutoinstallImportHook._install_selenium): If we can't get the latest PyPI url,
fallback to version 3.5.0 or a newer installed version.

2:35 PM Changeset in webkit [222351] by fpizlo@apple.com
  • 18 edits
    1 add in trunk/Tools

WSL should have some post-instantiation type checking
https://bugs.webkit.org/show_bug.cgi?id=177303

Reviewed by Keith Miller.

This patch removes the Primitive protocol! Yay!

The Primitive protocol was an attempt to handle the fact that Metal wouldn't allow us to point a
non-thread pointer at data structures that have pointers. This type checking rule interacts badly with
generics. I was able to get it to mostly work by making Primitive into a dynamic protocol - a type
belongs to it if it happens to be isPrimitive.

But that was a mistake, since it makes it hard to create pointers that are generic over address space.
Also, it's not an appropriate rule for targeting SPIR-V logical mode. That rule will be different, and
possibly more complicated.

All of these kinds of rules are easier to implement of we run them after instantiation, since then they
don't get in the way of generics. That's what this patch does.

This means that we get all of the same type checking power as before, and we still can catch the errors
that Metal requires us to check for. It's easier to do those checks now.

Finally, this removes the shader type checker's incomplete reimplementation of isPrimitive (which was
called NonNumericSearcher). The shader type checker calls isPrimitive now.

  • WebGPUShadingLanguageRI/AddressSpace.js:

(needsPrimitiveProtocol): Deleted.
(protocolSuffix): Deleted.

  • WebGPUShadingLanguageRI/All.js:
  • WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype._checkShaderType):
(Checker.prototype._checkShaderType.NonNumericSearcher): Deleted.
(Checker.prototype._checkShaderType.NonNumericSearcher.prototype.visitArrayRefType): Deleted.
(Checker.prototype._checkShaderType.NonNumericSearcher.prototype.visitPtrType): Deleted.
(Checker.prototype.visitReferenceType): Deleted.

  • WebGPUShadingLanguageRI/FuncInstantiator.js:

(FuncInstantiator.prototype.getUnique.Instantiate.prototype.visitFuncDef):

  • WebGPUShadingLanguageRI/Inline.js:

(_inlineFunction):

  • WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics):

  • WebGPUShadingLanguageRI/LateChecker.js: Added.

(LateChecker):
(LateChecker.prototype.visitReferenceType):
(LateChecker.prototype._checkShaderType):
(LateChecker.prototype.visitFuncDef):

  • WebGPUShadingLanguageRI/LexerToken.js:

(LexerToken.prototype.get isInternal): Deleted.

  • WebGPUShadingLanguageRI/NativeType.js:

(NativeType):
(NativeType.prototype.get name):
(NativeType.prototype.get isPrimitive):
(NativeType.prototype.set isPrimitive):
(NativeType.prototype.toString):

  • WebGPUShadingLanguageRI/Parse.js:

(parseNative):

  • WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js:

(programWithUnnecessaryThingsRemoved):

  • WebGPUShadingLanguageRI/ProtocolDecl.js:
  • WebGPUShadingLanguageRI/ReferenceType.js:

(ReferenceType.prototype.get elementType):
(ReferenceType.prototype.get isPrimitive): Deleted.

  • WebGPUShadingLanguageRI/StandardLibrary.js:
  • WebGPUShadingLanguageRI/StatementCloner.js:

(StatementCloner.prototype.visitNativeType):

  • WebGPUShadingLanguageRI/SynthesizeStructAccessors.js:

(synthesizeStructAccessors):

  • WebGPUShadingLanguageRI/Test.js:

(TEST_passNullAndNotNullFullPoly):
(TEST_passNullAndNotNullFullPolyReverse):
(TEST_nullTypeVariableUnify):
(TEST_chainStructNewlyValid):
(TEST_chainStructDevice):
(TEST_chainStructInvalid): Deleted.

  • WebGPUShadingLanguageRI/Type.js:

(Type.prototype.get isPrimitive):

2:11 PM Changeset in webkit [222350] by Antti Koivisto
  • 3 edits in trunk/Source/WebCore

Remove some more code from RenderFlowThread
https://bugs.webkit.org/show_bug.cgi?id=177320

Reviewed by David Hyatt.

More dead code related to named flows.

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::invalidateRegions):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::logicalWidthChangedInRegionsForBlock):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):
(WebCore::RenderFlowThread::offsetFromLogicalTopOfFirstRegion const):
(WebCore::RenderFlowThread::hasCachedOffsetFromLogicalTopOfFirstRegion const): Deleted.
(WebCore::RenderFlowThread::cachedOffsetFromLogicalTopOfFirstRegion const): Deleted.
(WebCore::RenderFlowThread::setOffsetFromLogicalTopOfFirstRegion): Deleted.
(WebCore::RenderFlowThread::clearOffsetFromLogicalTopOfFirstRegion): Deleted.
(WebCore::RenderFlowThread::currentActiveRenderBox const): Deleted.
(WebCore::RenderFlowThread::pushFlowThreadLayoutState): Deleted.
(WebCore::RenderFlowThread::popFlowThreadLayoutState): Deleted.

  • rendering/RenderFlowThread.h:
1:58 PM Changeset in webkit [222349] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Unreviewed, drop assertion added in r222308.

The assertion is hit by a couple of tests still but there is no bad effect
to the vector not being empty at this point since we clear it right after.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad):

1:46 PM Changeset in webkit [222348] by Chris Dumez
  • 3 edits
    2 adds in trunk

eventInitDict parameter to GamepadEvent constructor should be optional
https://bugs.webkit.org/show_bug.cgi?id=177308

Reviewed by Sam Weinig.

Source/WebCore:

eventInitDict parameter to GamepadEvent constructor should be optional to match Firefox
and Chrome. Having such dictionary parameter is also not valid Web IDL:
"""
If the type of an argument is a dictionary type (or a union type that has a dictionary as one
of its flattened member types), and that dictionary type and its ancestors have no required
members, and the argument is either the final argument or is followed only by optional arguments,
then the argument must be specified as optional. Such arguments are always considered to have a
default value of an empty dictionary, unless otherwise specified.
"""

Test: gamepad/gamepad-event.html

  • Modules/gamepad/GamepadEvent.idl:

LayoutTests:

Add layout test coverage.

  • gamepad/gamepad-event-expected.txt: Added.
  • gamepad/gamepad-event.html: Added.
1:45 PM Changeset in webkit [222347] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/FileAPI/historical.https.html as flaky on El Capitan Debug WK2.
https://bugs.webkit.org/show_bug.cgi?id=177214

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
1:44 PM Changeset in webkit [222346] by achristensen@apple.com
  • 2 edits in trunk/Source/WTF

Make StringBuilder movable
https://bugs.webkit.org/show_bug.cgi?id=177311

Reviewed by Chris Dumez.

  • wtf/text/StringBuilder.h:

(WTF::StringBuilder::StringBuilder):

1:40 PM Changeset in webkit [222345] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark webrtc/peer-connection-audio-mute.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=172649

Unreviewed test gardening.

1:26 PM Changeset in webkit [222344] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/fetch/security/embedded-credentials.tentative.sub.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=177323

Unreviewed test gardening.

  • platform/mac/TestExpectations:
1:19 PM Changeset in webkit [222343] by Chris Dumez
  • 2 edits in trunk/Tools

Unreviewed, temporarily disable new API tests introduced in r222308 until they pass on El Capitan

  • TestWebKitAPI/Tests/WebKitCocoa/Download.mm:

(TEST):

1:18 PM Changeset in webkit [222342] by commit-queue@webkit.org
  • 7 edits
    3 adds in trunk/Source/WebInspectorUI

Web Inspector: Add details sidebar to Layers tab.
https://bugs.webkit.org/show_bug.cgi?id=177115

Patch by Ross Kirsling <Ross Kirsling> on 2017-09-21
Reviewed by Devin Rousso.

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Main.html:
  • UserInterface/Views/LayerDetailsSidebarPanel.css: Added.
  • UserInterface/Views/LayerDetailsSidebarPanel.js: Added.

New files and strings for sidebar.

  • UserInterface/Base/Utilities.js:

Add global identifier for "×" character.

  • UserInterface/Models/Layer.js: Added.

Add a model class for layers so that we can instanceof-check them.

  • UserInterface/Controllers/LayerTreeManager.js:

(WI.LayerTreeManager.prototype.layersForNode):
Utilize model class WI.Layer.

  • UserInterface/Views/Layers3DContentView.js:

(WI.Layers3DContentView):
(WI.Layers3DContentView.prototype.get supplementalRepresentedObjects):
(WI.Layers3DContentView.prototype.layout):
(WI.Layers3DContentView.prototype._addLayer):
Pass layer data to sidebar and utilize model class WI.Layer.

  • UserInterface/Views/LayersTabContentView.js:

(WI.LayersTabContentView):
Attach details sidebar.

1:16 PM Changeset in webkit [222341] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/html/semantics/document-metadata/the-meta-element/pragma-directives/attr-meta-http-equiv-refresh/parsing.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=177322

Unreviewed test gardening.

  • platform/mac/TestExpectations:
12:49 PM Changeset in webkit [222340] by Ryan Haddad
  • 3 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/html/semantics/forms/the-form-element/form-elements-filter.html as failing.
https://bugs.webkit.org/show_bug.cgi?id=177319

Unreviewed test gardening.

  • platform/mac-wk1/TestExpectations:
  • platform/mac/TestExpectations:
12:17 PM Changeset in webkit [222339] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Unreviewed, rolling out r222272.
https://bugs.webkit.org/show_bug.cgi?id=177316

This patch broke builds on some Win EWS bots. (Requested by
perarne on #webkit).

Reverted changeset:

"[Win] Cygwin 64-bit EWS process cannot find Visual Studio
installation."
https://bugs.webkit.org/show_bug.cgi?id=177244
http://trac.webkit.org/changeset/222272

12:04 PM Changeset in webkit [222338] by BJ Burg
  • 9 edits in trunk/Source

Web Inspector: keyboard shortcut for "Reload page from origin" doesn't match Safari, and doesn't work
https://bugs.webkit.org/show_bug.cgi?id=177010
<rdar://problem/33134548>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

Use "reload from origin" nomenclature instead of "reload ignoring cache".

  • inspector/protocol/Page.json: Improve the comment, but don't change the

parameter name since this would be a divergence from legacy protocols.

Source/WebCore:

Use "reload from origin" nomenclature instead of "reload ignoring cache".

  • inspector/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::reload):

  • inspector/InspectorPageAgent.h:

Source/WebInspectorUI:

I seem to have broken reload from origin via Web Inspector in a previous
patch, because the parameter is 'ignoreCache' instead of 'shouldIgnoreCache'.

  • Localizations/en.lproj/localizedStrings.js:

Modernize tooltip text.

  • UserInterface/Base/Main.js:

(WI.contentLoaded):
Disambiguate two locals with the same name. Modernize the tooltip.
Make the shortcut Cmd-Opt-R to match Safari. Fix wrong parameter usage.

  • UserInterface/Test/FrontendTestHarness.js:

(FrontendTestHarness.prototype.reloadPage):
Fix wrong parameter.

11:48 AM Changeset in webkit [222337] by Megan Gardner
  • 2 edits
    2 adds in trunk/LayoutTests

Add long press and drag test
https://bugs.webkit.org/show_bug.cgi?id=177289

Reviewed by Simon Fraser and Tim Horton.

Adding a test to test the long press and then drag functionality of selection.
Also add additional helper functions to basic gestures, and clarified the existing function
names, as to be more clear in what behavior to expect from them.

  • fast/events/touch/ios/long-press-then-drag-to-select-text-expected.txt: Added.
  • fast/events/touch/ios/long-press-then-drag-to-select-text.html: Added.
  • fast/events/touch/ios/resources/basic-gestures.js:

(touchAndDragFromPointToPoint):

11:43 AM Changeset in webkit [222336] by Joseph Pecoraro
  • 2 edits in trunk/Source/JavaScriptCore

test262: test262/test/annexB/built-ins/RegExp/prototype/flags/order-after-compile.js ASSERTs
https://bugs.webkit.org/show_bug.cgi?id=177307

Reviewed by Michael Saboff.

  • runtime/RegExpPrototype.cpp:

In r221160 we added support for the new RegExp flag (dotAll).
We needed to make space for it in FlagsString.

11:29 AM Changeset in webkit [222335] by Antti Koivisto
  • 32 edits
    2 deletes in trunk/Source/WebCore

Remove RenderNamedFlowFragment
https://bugs.webkit.org/show_bug.cgi?id=177299

Reviewed by David Hyatt.

Remove the remaining named flow rendering code.

The feature is already disabled, no functional changes.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paint):
(WebCore::RenderBlock::selectionGaps):
(WebCore::RenderBlock::nodeAtPoint):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::insertedIntoTree):
(WebCore::RenderBlockFlow::willBeDestroyed):
(WebCore::RenderBlockFlow::layoutBlock):
(WebCore::RenderBlockFlow::styleDidChange):
(WebCore::RenderBlockFlow::updateLogicalHeight):
(WebCore::RenderBlockFlow::positionForPoint):
(WebCore::RenderBlockFlow::createRenderNamedFlowFragmentIfNeeded): Deleted.
(WebCore::RenderBlockFlow::canHaveChildren const): Deleted.
(WebCore::RenderBlockFlow::canHaveGeneratedChildren const): Deleted.
(WebCore::RenderBlockFlow::namedFlowFragmentNeedsUpdate const): Deleted.
(WebCore::RenderBlockFlow::setRenderNamedFlowFragment): Deleted.

  • rendering/RenderBlockFlow.h:

(WebCore::RenderBlockFlow::RenderBlockFlowRareData::RenderBlockFlowRareData):
(WebCore::RenderBlockFlow::renderNamedFlowFragment const): Deleted.
(WebCore::RenderElement::isRenderNamedFlowFragmentContainer const): Deleted.

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::nodeAtPoint):
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::pushContentsClip):
(WebCore::RenderBox::mapLocalToContainer const):
(WebCore::RenderBox::isUnsplittableForPagination const):
(WebCore::RenderBox::overflowRectForPaintRejection const):

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/RenderBoxModelObject.h:
  • rendering/RenderElement.h:

(WebCore::RenderElement::generatingElement const):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::invalidateRegions):
(WebCore::RenderFlowThread::validateRegions):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::adjustedPositionRelativeToOffsetParent const):
(WebCore::RenderFlowThread::clearRenderBoxRegionInfoAndCustomStyle):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::addForcedRegionBreak):
(WebCore::RenderFlowThread::hasCompositingRegionDescendant const): Deleted.
(WebCore::RenderFlowThread::getLayerListForRegion const): Deleted.
(WebCore::RenderFlowThread::regionForCompositedLayer const): Deleted.
(WebCore::RenderFlowThread::cachedRegionForCompositedLayer const): Deleted.
(WebCore::RenderFlowThread::updateLayerToRegionMappings): Deleted.
(WebCore::RenderFlowThread::updateAllLayerToRegionMappings): Deleted.
(WebCore::RenderFlowThread::collectsGraphicsLayersUnderRegions const): Deleted.
(WebCore::RenderFlowThread::isAutoLogicalHeightRegionsCountConsistent const): Deleted.
(WebCore::RenderFlowThread::initializeRegionsComputedAutoHeight): Deleted.
(WebCore::RenderFlowThread::markAutoLogicalHeightRegionsForLayout): Deleted.
(WebCore::RenderFlowThread::incrementAutoLogicalHeightRegions): Deleted.
(WebCore::RenderFlowThread::decrementAutoLogicalHeightRegions): Deleted.

  • rendering/RenderFlowThread.h:
  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):
(WebCore::expandClipRectForDescendantsAndReflection):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintList):
(WebCore::isHitCandidate):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::hitTestList):
(WebCore::RenderLayer::calculateClipRects const):
(WebCore::expandClipRectForRegionAndReflection): Deleted.
(WebCore::RenderLayer::isFlowThreadCollectingGraphicsLayersUnderRegions const): Deleted.
(WebCore::RenderLayer::mapLayerClipRectsToFragmentationLayer const): Deleted.

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::shouldClipCompositedBounds const):
(WebCore::RenderLayerBacking::computeParentGraphicsLayerRect const):
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer const):
(WebCore::RenderLayerBacking::adjustAncestorCompositingBoundsForFlowThread const): Deleted.

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::requiresCompositingForIndirectReason const):
(WebCore::RenderLayerCompositor::styleChangeMayAffectIndirectCompositingReasons):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition const):
(WebCore::RenderLayerCompositor::computeRegionCompositingRequirements): Deleted.
(WebCore::RenderLayerCompositor::rebuildRegionCompositingLayerTree): Deleted.

  • rendering/RenderLayerCompositor.h:
  • rendering/RenderNamedFlowFragment.cpp: Removed.
  • rendering/RenderNamedFlowFragment.h: Removed.
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::containerForRepaint const):
(WebCore::RenderObject::fixedPositionedWithNamedFlowContainingBlock const): Deleted.
(WebCore::hasFixedPosInNamedFlowContainingBlock): Deleted.
(WebCore::RenderObject::currentRenderNamedFlowFragment const): Deleted.

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderRegion const):
(WebCore::RenderObject::isAnonymousBlock const):
(WebCore::RenderObject::isRenderNamedFlowFragment const): Deleted.

  • rendering/RenderRegion.cpp:
  • rendering/RenderRegion.h:

(WebCore::RenderRegion::hasAutoLogicalHeight const): Deleted.

  • rendering/RenderReplaced.cpp:

(WebCore::RenderReplaced::shouldPaint):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::overflowClipRect):
(WebCore::RenderTable::nodeAtPoint):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::nodeAtPoint):

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):

  • rendering/RenderView.cpp:

(WebCore::RenderView::layout):
(WebCore::RenderView::pushLayoutState):
(WebCore::RenderView::pushLayoutStateForPaginationIfNeeded):
(WebCore::RenderView::layoutContentInAutoLogicalHeightRegions): Deleted.
(WebCore::RenderView::checkTwoPassLayoutForAutoHeightRegions const): Deleted.
(WebCore::RenderView::pushLayoutStateForCurrentFlowThread): Deleted.
(WebCore::RenderView::popLayoutStateForCurrentFlowThread): Deleted.

  • rendering/RenderView.h:
  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::paint):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::paintReplaced):

11:20 AM Changeset in webkit [222334] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

[WK2] Add API to get the redirect chain of a WKDownload
https://bugs.webkit.org/show_bug.cgi?id=176628
<rdar://problem/34338279>

Reviewed by Alex Christensen.

Re-enable assertion initially added in r222308 and later disabled in
r222320. The assertion was hit because we failed to clear the redirect
chain in WebFrameProxy::didFailProvisionalLoad().

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad):
(WebKit::WebFrameProxy::didFailProvisionalLoad):

11:16 AM Changeset in webkit [222333] by Ryan Haddad
  • 2 edits in trunk/JSTests

Mark 6 test262 tests as passing.
https://bugs.webkit.org/show_bug.cgi?id=177307

Unreviewed test gardening.

  • test262.yaml:
11:02 AM Changeset in webkit [222332] by Ryan Haddad
  • 2 edits
    1 add in trunk/LayoutTests

Rebaseline some tests for macOS.

Unreviewed test gardening.

  • platform/mac-wk1/compositing/repaint/iframes/composited-iframe-with-fixed-background-doc-repaint-expected.txt: Added.
  • platform/mac-wk2/js/dom/global-constructors-attributes-expected.txt:
10:51 AM Changeset in webkit [222331] by fpizlo@apple.com
  • 3 edits in trunk/Tools

Unreviewed, fix a bug in the interactive app that was introduced by bad merging.

  • WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js:

(FlattenedStructOffsetGatherer.prototype.visitTypeRef):
(FlattenedStructOffsetGatherer):

  • WebGPUShadingLanguageRI/index.html:
10:47 AM Changeset in webkit [222330] by fpizlo@apple.com
  • 20 edits
    2 adds in trunk/Tools

WSL should support switch
https://bugs.webkit.org/show_bug.cgi?id=176978

Reviewed by Keith Miller.

This adds fairly complete support for switch statements. This includes things like verifying
whether or not a default statement is needed. This even works when the programmer lists all of
the values of an integer type.

To test that last part, this patch adds uint8 support. It's easy add it, but of course it
meant adding a lot of tests.

This also fixes enum bugs, since switch does things to enums that we previously didn't test.

  • WebGPUShadingLanguageRI/All.js:
  • WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype.visitSwitchStatement):

  • WebGPUShadingLanguageRI/EnumLiteral.js:

(EnumLiteral.prototype.get valueForSelectedType):

  • WebGPUShadingLanguageRI/EnumType.js:

(EnumType.prototype.allValues):
(EnumType.prototype.valuesEqual):

  • WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitSwitchStatement):

  • WebGPUShadingLanguageRI/Inliner.js:

(Inliner.prototype.visitCallExpression):
(Inliner):
(Inliner.prototype.visitCastExpression): Deleted.

  • WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics.):
(Intrinsics):

  • WebGPUShadingLanguageRI/LoopChecker.js:

(LoopChecker):
(LoopChecker.prototype.visitFuncDef):
(LoopChecker.prototype.visitWhileLoop):
(LoopChecker.prototype.visitDoWhileLoop):
(LoopChecker.prototype.visitForLoop):
(LoopChecker.prototype.visitSwitchStatement):
(LoopChecker.prototype.visitBreak):
(LoopChecker.prototype.visitContinue):

  • WebGPUShadingLanguageRI/Node.js:

(Node.prototype.commit):

  • WebGPUShadingLanguageRI/Parse.js:

(parseSwitchCase):
(parseSwitchStatement):
(parseStatement):
(parseBlockBody):
(parseBlock):

  • WebGPUShadingLanguageRI/Prepare.js:

(let.prepare):

  • WebGPUShadingLanguageRI/ReturnChecker.js:

(ReturnChecker.prototype._mergeReturnStyle):
(ReturnChecker.prototype.visitIfStatement):
(ReturnChecker.prototype.visitWhileLoop):
(ReturnChecker.prototype.visitDoWhileLoop):
(ReturnChecker.prototype.visitForLoop):
(ReturnChecker.prototype.visitSwitchStatement):
(ReturnChecker.prototype.visitContinue):
(ReturnChecker):

  • WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitSwitchStatement):
(Rewriter.prototype.visitSwitchCase):

  • WebGPUShadingLanguageRI/StandardLibrary.js:

(uint8.operator):
(bool.operator):
(_generateSwizzle):

  • WebGPUShadingLanguageRI/SwitchCase.js: Added.

(SwitchCase):
(SwitchCase.prototype.get origin):
(SwitchCase.prototype.get isDefault):
(SwitchCase.prototype.get value):
(SwitchCase.prototype.get body):
(SwitchCase.prototype.toString):

  • WebGPUShadingLanguageRI/SwitchStatement.js: Added.

(SwitchStatement):
(SwitchStatement.prototype.get origin):
(SwitchStatement.prototype.get value):
(SwitchStatement.prototype.add):
(SwitchStatement.prototype.get switchCases):
(SwitchStatement.prototype.toString):

  • WebGPUShadingLanguageRI/Test.html:
  • WebGPUShadingLanguageRI/Test.js:

(makeUint8):
(makeEnum):
(checkUint8):
(TEST_uint8SimpleMath):
(TEST_equality):
(TEST_notEquality):
(TEST_uint8BitAnd):
(TEST_uint8BitOr):
(TEST_uint8BitXor):
(TEST_uint8BitNot):
(TEST_uint8LShift):
(TEST_uint8RShift):
(TEST_enumWithExplicitIntBase):
(TEST_enumWithUintBase):
(TEST_enumFloatBase):
(TEST_enumStructBase):
(TEST_simpleSwitch):
(TEST_exhaustiveUint8Switch):
(TEST_notQuiteExhaustiveUint8Switch):
(TEST_switchFallThrough):
(TEST_switchBreak):
(TEST_enumSwitchBreakExhaustive):
(TEST_enumSwitchBreakNotQuiteExhaustive):
(doTest):

  • WebGPUShadingLanguageRI/UnificationContext.js:

(UnificationContext):
(UnificationContext.prototype.addExtraNode):
(UnificationContext.prototype.get nodes):

  • WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitProtocolDecl):

  • WebGPUShadingLanguageRI/index.html:
10:43 AM Changeset in webkit [222329] by achristensen@apple.com
  • 2 edits in trunk/Source/WebCore

Fix all builds after r222325

  • loader/DocumentLoader.h:

WebKit needs this, too.

10:41 AM Changeset in webkit [222328] by fpizlo@apple.com
  • 14 edits
    2 adds in trunk/Tools

WSL needs a way to verify that structs are not cyclic
https://bugs.webkit.org/show_bug.cgi?id=177044

Reviewed by Myles Maxfield.

This adds a recursive type checking phase. Even before adding this phase, the compiler would
successfully detect recursive types - but at the cost of also rejecting programs that had
recursive types indirectly through pointers. To make both things work, I had to change Visitor
to no longer visit TypeRef.type by default. This resulted in some other changes in a few other
parts of the code that previously relied on that behavior.

  • WebGPUShadingLanguageRI/All.js:
  • WebGPUShadingLanguageRI/CheckRecursiveTypes.js: Added.

(checkRecursiveTypes):

  • WebGPUShadingLanguageRI/Checker.js:

(Checker.prototype._checkShaderType.NonNumericSearcher.prototype.visitArrayRefType):
(Checker.prototype._checkShaderType.NonNumericSearcher.prototype.visitPtrType):
(Checker.prototype._checkShaderType.NonNumericSearcher.prototype.visitTypeRef):
(Checker.prototype._checkShaderType.NonNumericSearcher):
(Checker.prototype._checkShaderType):
(Checker.prototype.visitTypeRef):

  • WebGPUShadingLanguageRI/NameResolver.js:

(NameResolver.prototype.visitProtocolDecl):

  • WebGPUShadingLanguageRI/Prepare.js:

(let.prepare):

  • WebGPUShadingLanguageRI/RecursiveTypeChecker.js: Added.

(RecursiveTypeChecker):
(RecursiveTypeChecker.prototype.visitFuncDef):
(RecursiveTypeChecker.prototype.visitNativeFunc):
(RecursiveTypeChecker.prototype.visitStructType):
(RecursiveTypeChecker.prototype.visitReferenceType):
(RecursiveTypeChecker.prototype.visitTypeRef):

  • WebGPUShadingLanguageRI/StructLayoutBuilder.js:

(StructLayoutBuilder.prototype.visitTypeRef):
(StructLayoutBuilder):

  • WebGPUShadingLanguageRI/Test.html:
  • WebGPUShadingLanguageRI/Test.js:

(TEST_simpleRecursiveStruct):

  • WebGPUShadingLanguageRI/TypeDefResolver.js:

(TypeDefResolver.prototype.visitTypeRef):
(TypeDefResolver):

  • WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitProtocolDecl):

  • WebGPUShadingLanguageRI/index.html:
10:35 AM Changeset in webkit [222327] by keith_miller@apple.com
  • 11 edits
    2 adds in trunk

JSC should use unified sources for platform specific files.
https://bugs.webkit.org/show_bug.cgi?id=177290

Reviewed by Michael Saboff.

.:

Change WEBKIT_COMPUTE_SOURCES CMake macro to look for platform
specific unified source lists. This is done in the same way that
we look for port specific configuration files. For example, if I
were building for the Mac port WEBKIT_COMPUTE_SOURCES would add
the Sources.txt and SourcesMac.txt source lists to the list of
unified sources.

  • Source/cmake/WebKitMacros.cmake:

Source/JavaScriptCore:

Add a list of platform specific source files and update the
Generate Unified Sources phase of the Xcode build. I skipped WPE
since that seems to have failed for some reason that I didn't
fully understand. See:
https://webkit-queues.webkit.org/results/4611260

Also, fix duplicate symbols in Glib remote inspector files.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • PlatformGTK.cmake:
  • PlatformMac.cmake:
  • SourcesGTK.txt: Added.
  • SourcesMac.txt: Added.
  • inspector/remote/glib/RemoteInspectorServer.cpp:

(Inspector::RemoteInspectorServer::interfaceInfo):
(Inspector::RemoteInspectorServer::setTargetList):
(Inspector::RemoteInspectorServer::setupInspectorClient):
(Inspector::RemoteInspectorServer::setup):
(Inspector::RemoteInspectorServer::close):
(Inspector::RemoteInspectorServer::connectionClosed):
(Inspector::RemoteInspectorServer::sendMessageToBackend):
(Inspector::RemoteInspectorServer::sendMessageToFrontend):
(Inspector::dbusConnectionCallAsyncReadyCallback): Deleted.

Source/WTF:

The unified source bundler script can now handle more than one
list of sources. Sources will not be bundled across source file
lists. We want to ensure that changing one platform's sources
doesn't break another platform's build, as much as
possible. Additionally, it means that there won't be weird
performance changes when files are added to an unrelated platform.

Remove stale reference to generate-unified-source-bundles.rb script
from Xcode.

  • Scripts/generate-unified-source-bundles.rb:
  • WTF.xcodeproj/project.pbxproj:
10:33 AM Changeset in webkit [222326] by commit-queue@webkit.org
  • 30 edits
    2 moves
    4 adds in trunk/Source/WebCore

[PAL] Move MediaTimeAVFoundation into PAL
https://bugs.webkit.org/show_bug.cgi?id=177222

Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2017-09-21
Reviewed by Myles C. Maxfield.

Source/WebCore:

No new tests. No change in behavior..

  • Configurations/WebCore.unexp:
  • PlatformAppleWin.cmake:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/audio/mac/AudioSampleDataSource.mm:

(WebCore::AudioSampleDataSource::pushSamples):

  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::process):

  • platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:

(WebCore::InbandTextTrackPrivateAVF::readNativeSampleBuffer):

  • platform/graphics/avfoundation/MediaSampleAVFObjC.h:
  • platform/graphics/avfoundation/cf/InbandTextTrackPrivateAVCF.cpp:
  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::MediaPlayerPrivateAVFoundationCF::platformDuration const):
(WebCore::MediaPlayerPrivateAVFoundationCF::currentMediaTime const):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformBufferedTimeRanges const):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMinTimeSeekable const):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeSeekable const):
(WebCore::MediaPlayerPrivateAVFoundationCF::platformMaxTimeLoaded const):
(WebCore::AVFWrapper::seekToTime):
(WebCore::AVFWrapper::legibleOutputCallback):
(WebCore::AVFWrapper::createImageForTimeInRect):

  • platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm:

(WebCore::ImageDecoderAVFObjC::readSampleMetadata):
(WebCore::ImageDecoderAVFObjC::storeSampleBuffer):
(WebCore::ImageDecoderAVFObjC::createFrameImageAtIndex):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::platformDuration const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::currentMediaTime const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformBufferedTimeRanges const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMinTimeSeekable const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMaxTimeSeekable const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::platformMaxTimeLoaded const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::metadataDidArrive):
(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):
(-[WebCoreAVFMovieObserver legibleOutput:didOutputAttributedStrings:nativeSampleBuffers:forItemTime:]):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::currentMediaTime const):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::durationChanged):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::sizeWillChangeAtTime):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::calculateTimelineOffset):

  • platform/graphics/avfoundation/objc/MediaSampleAVFObjC.mm:

(WebCore::MediaSampleAVFObjC::presentationTime const):
(WebCore::MediaSampleAVFObjC::outputPresentationTime const):
(WebCore::MediaSampleAVFObjC::decodeTime const):
(WebCore::MediaSampleAVFObjC::duration const):
(WebCore::MediaSampleAVFObjC::outputDuration const):
(WebCore::MediaSampleAVFObjC::offsetTimestampsBy):
(WebCore::MediaSampleAVFObjC::setTimestamps):
(WebCore::MediaSampleAVFObjC::divide):

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::didParseStreamDataAsAsset):

  • platform/graphics/cocoa/WebCoreDecompressionSession.mm:

(WebCore::WebCoreDecompressionSession::handleDecompressionOutput):
(WebCore::WebCoreDecompressionSession::automaticDequeue):
(WebCore::WebCoreDecompressionSession::enqueueDecodedSample):
(WebCore::WebCoreDecompressionSession::imageForTime):

  • platform/mac/PlatformClockCM.mm:

(PlatformClockCM::setCurrentMediaTime):
(PlatformClockCM::currentMediaTime const):

  • platform/mac/PlaybackSessionInterfaceMac.mm:

(WebCore::timeRangesToArray):

  • platform/mac/VideoFullscreenInterfaceMac.mm:
  • platform/mediastream/mac/CoreAudioCaptureSource.cpp:
  • platform/mediastream/mac/MockRealtimeAudioSourceMac.mm:

(WebCore::MockRealtimeAudioSourceMac::emitSampleBuffers):

  • platform/mediastream/mac/RealtimeIncomingAudioSource.cpp:

(WebCore::RealtimeIncomingAudioSource::OnData):

  • platform/mediastream/mac/WebAudioSourceProviderAVFObjC.mm:

Source/WebCore/PAL:

  • config.h:

Include PALHeaderDetection.h.
Define AVFOUNDATION-releavant definitions.

  • pal/PlatformWin.cmake:

Add PAL dereived sources directory to include paths.

  • PAL.xcodeproj/project.pbxproj:
  • pal/CMakeLists.txt:
  • pal/PlatformAppleWin.cmake:
  • pal/avfoundation/MediaTimeAVFoundation.cpp: Renamed from Source/WebCore/platform/graphics/avfoundation/MediaTimeAVFoundation.cpp.
  • pal/avfoundation/MediaTimeAVFoundation.h: Renamed from Source/WebCore/platform/graphics/avfoundation/MediaTimeAVFoundation.h.
  • pal/cf/CoreMediaSoftLink.cpp: Added.
  • pal/cf/CoreMediaSoftLink.h: Added.
10:12 AM Changeset in webkit [222325] by achristensen@apple.com
  • 3 edits in trunk/Source/WebCore

Fix ASAN build after r222306
https://bugs.webkit.org/show_bug.cgi?id=177255

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::setCustomHeaderFields):

  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::setCustomHeaderFields): Deleted.
Moving a Vector of a type requires more than just a forward declaration of the type, but only in ASAN builds. Weird.

9:56 AM Changeset in webkit [222324] by jmarcell@apple.com
  • 4 edits in tags/Safari-605.1.7

Cherry-pick r222322. rdar://problem/34351988

9:47 AM Changeset in webkit [222323] by Ryan Haddad
  • 2 edits in trunk/Tools

Update TestResultsServer for iOS 11 queues.
https://bugs.webkit.org/show_bug.cgi?id=177285

Reviewed by Alexey Proskuryakov.

  • TestResultServer/static-dashboards/builders.jsonp:
9:41 AM Changeset in webkit [222322] by achristensen@apple.com
  • 4 edits in trunk

REGRESSION(r221465) WKWebViews without WebGL delegate callbacks crash when WebGL contexts are created
https://bugs.webkit.org/show_bug.cgi?id=177306
<rdar://problem/34351988>

Reviewed by Chris Dumez.

Source/WebKit:

  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::webGLLoadPolicy const):
(WebKit::NavigationState::NavigationClient::resolveWebGLLoadPolicy const):
I forgot to early return after calling the default completion handler if there's no delegate selector.

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/WebGLPolicy.mm:

(-[WebGLTestDelegate webView:startURLSchemeTask:]):
(-[DelegateWithoutWebGL webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]):
(TEST):

9:28 AM Changeset in webkit [222321] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

In regular block layout, the width of a child's margin box should always be equal to that of its containing block
Merge from Blink https://bugs.chromium.org/p/chromium/issues/detail?id=708751
https://bugs.webkit.org/show_bug.cgi?id=176620

Patch by Zhifei FANG <facetothefate@gmail.com> on 2017-09-21
Reviewed by Zalan Bujtas.

Source/WebCore:

Test: fast/block/over-constrained-auto-margin.html

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalWidthInRegion const):

LayoutTests:

  • fast/block/over-constrained-auto-margin-expected.txt: Added.
  • fast/block/over-constrained-auto-margin.html: Added.
9:03 AM Changeset in webkit [222320] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Unreviewed, temporarily disable assertion added in r222308 while I investigate.

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad):

8:19 AM WebKitGTK/2.18.x edited by Michael Catanzaro
(diff)
7:55 AM Changeset in webkit [222319] by Ms2ger@igalia.com
  • 2 edits in trunk/LayoutTests

[WPE] Mark wrapKey_unwrapKey.worker.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=177301

Unreviewed test gardening.

  • platform/wpe/TestExpectations:
7:32 AM Changeset in webkit [222318] by jmarcell@apple.com
  • 2 edits in tags/Safari-605.1.7/Source/WebCore

Cherry-pick r222314. rdar://problem/34559968

7:18 AM WebKitGTK/Gardening/Calendar edited by Ms2ger@igalia.com
(diff)
7:17 AM WebKitGTK/Gardening/Calendar edited by Ms2ger@igalia.com
(diff)
6:43 AM Changeset in webkit [222317] by jfernandez@igalia.com
  • 5 edits
    25 adds in trunk

Unpredictable selection when dragging out of float elements children of in-flow block-level box
https://bugs.webkit.org/show_bug.cgi?id=176096

Reviewed by David Hyatt.

Source/WebCore:

In order to improve Selection across float elements we need to
consider them as HitTest candidates. Additionally, since
out-of-flow elements must not affect how in-flow elements are
rendered we have to deal with some special cases when implementing
the positionForPoint logic.

This patch addresses the issues caused by the fact that an in-flow
box's logicalBottom does not consider the out-of-flow children, as
they don't affect its height. Hence, we should add the lowest float
logical bottom to figure out the box the point is actually hitting.

Tests: editing/selection/select-out-of-floated-non-editable-01.html

editing/selection/select-out-of-floated-non-editable-02.html
editing/selection/select-out-of-floated-non-editable-03.html
editing/selection/select-out-of-floated-non-editable-04.html
editing/selection/select-out-of-floated-non-editable-05.html
editing/selection/select-out-of-floated-non-editable-06.html
editing/selection/select-out-of-floated-non-editable-07.html
editing/selection/select-out-of-floated-non-editable-08.html
editing/selection/select-out-of-floated-non-editable-09.html
editing/selection/select-out-of-floated-non-editable-10.html
editing/selection/select-out-of-floated-non-editable-11.html
editing/selection/select-out-of-floated-non-editable-12.html

  • rendering/RenderBlock.cpp:

(WebCore::isChildHitTestCandidate):
(WebCore::RenderBlock::positionForPoint):

LayoutTests:

Tests defining several cases of selection with floats, children of
a block-level box, so they behave as regular HitTest candidates
and don't mess the selection boundaries.

  • editing/selection/resources/select-out-of-floated-non-editable.js: Added.

(clearLog):
(log):
(else.window.onmouseup):
(runTest):
(checkSelection):

  • editing/selection/select-out-of-floated-non-editable-01-expected.txt: Added.
  • editing/selection/select-out-of-floated-non-editable-01.html: Added.
  • editing/selection/select-out-of-floated-non-editable-02-expected.txt: Added.
  • editing/selection/select-out-of-floated-non-editable-02.html: Added.
  • editing/selection/select-out-of-floated-non-editable-03-expected.txt: Added.
  • editing/selection/select-out-of-floated-non-editable-03.html: Added.
  • editing/selection/select-out-of-floated-non-editable-04-expected.txt: Added.
  • editing/selection/select-out-of-floated-non-editable-04.html: Added.
  • editing/selection/select-out-of-floated-non-editable-05-expected.txt: Added.
  • editing/selection/select-out-of-floated-non-editable-05.html: Added.
  • editing/selection/select-out-of-floated-non-editable-06-expected.txt: Added.
  • editing/selection/select-out-of-floated-non-editable-06.html: Added.
  • editing/selection/select-out-of-floated-non-editable-07-expected.txt: Added.
  • editing/selection/select-out-of-floated-non-editable-07.html: Added.
  • editing/selection/select-out-of-floated-non-editable-08-expected.txt: Added.
  • editing/selection/select-out-of-floated-non-editable-08.html: Added.
  • editing/selection/select-out-of-floated-non-editable-09-expected.txt: Added.
  • editing/selection/select-out-of-floated-non-editable-09.html: Added.
  • editing/selection/select-out-of-floated-non-editable-10-expected.txt: Added.
  • editing/selection/select-out-of-floated-non-editable-10.html: Added.
  • editing/selection/select-out-of-floated-non-editable-11-expected.txt: Added.
  • editing/selection/select-out-of-floated-non-editable-11.html: Added.
  • editing/selection/select-out-of-floated-non-editable-12-expected.txt: Added.
  • editing/selection/select-out-of-floated-non-editable-12.html: Added.
2:51 AM Changeset in webkit [222316] by zandobersek@gmail.com
  • 6 edits in trunk/Source/WebCore

[WebCrypto] Support Elliptic Curve P-521
https://bugs.webkit.org/show_bug.cgi?id=169231
<rdar://problem/30881703>

Reviewed by Jiewen Tan.

Add support for the P-521 elliptic curve to the CryptoKeyEC class, but
allow the underlying platform-specific implementations to opt out of
supporting this feature.

This is achieved with the platformSupportedCurve() static function that
each platform has to implement, returning true if the passed-in curve
type is supported. The function is called at each CryptoKeyEC entrypoint,
that is in each static function that could generate a new CryptoKeyEC
object. These functions return a NotSupportedError exception in case the
platformSupportedCurve() call returns false.

While the libgcrypt-based implementation will support P-521 curves in
the near future, the CommonCrypto-based implementation might not. The use
of platformSupportedCurve() ensures that the implementations that don't
support EC P-521 continue to return the NotSupportedError exception at
these entrypoints, instead of the OperationError exception that's returned
when the platform-specific extensions of these entrypoints fail due to the
specified elliptic curve not being supported.

Both libgcrypt-based and CommonCrypto-based implementations mark P-256 and
P-384 curves as supported. Switch statements handling NamedCurve values
must now also handle the NamedCurve::P521 value, but both implementations
treat that as an unreachable case since support is not indicated in
platformSupportedCurve(), and all CryptoKeyEC operations should have
returned with an NotSupportedError exception before entering
platform-specific code. The common CryptoKeyEC constructor similarly asserts
that the specified curve is supported by the underlying implementation.

CryptoAlgorithmECDSA is modified to now also support 'ES512' as the algorithm
identifier, matching it against the 'P-521' curve value.

No new tests -- tests covering EC P-521 already exist, but no platform
runs them yet due to missing implementations.

  • crypto/algorithms/CryptoAlgorithmECDSA.cpp:

(WebCore::CryptoAlgorithmECDSA::importKey):

  • crypto/gcrypt/CryptoKeyECGCrypt.cpp:

(WebCore::curveName):
(WebCore::curveIdentifier):
(WebCore::curveSize):
(WebCore::curveUncompressedFieldElementSize):
(WebCore::CryptoKeyEC::platformSupportedCurve):

  • crypto/keys/CryptoKeyEC.cpp:

(WebCore::toNamedCurve):
(WebCore::CryptoKeyEC::CryptoKeyEC):
(WebCore::CryptoKeyEC::generatePair):
(WebCore::CryptoKeyEC::importRaw):
(WebCore::CryptoKeyEC::importJwk):
(WebCore::CryptoKeyEC::importSpki):
(WebCore::CryptoKeyEC::importPkcs8):
(WebCore::CryptoKeyEC::exportJwk const):
(WebCore::CryptoKeyEC::namedCurveString const):
(WebCore::CryptoKeyEC::algorithm const):

  • crypto/keys/CryptoKeyEC.h:
  • crypto/mac/CryptoKeyECMac.cpp:

(WebCore::doesUncompressedPointMatchNamedCurve):
(WebCore::doesFieldElementMatchNamedCurve):
(WebCore::getKeySizeFromNamedCurve):
(WebCore::CryptoKeyEC::platformSupportedCurve):
(WebCore::getOID):

2:33 AM Changeset in webkit [222315] by magomez@igalia.com
  • 5 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Update expectations and rebaseline several tests failing at r222312.

  • platform/gtk/TestExpectations:
  • platform/gtk/fast/text/atsui-rtl-override-selection-expected.txt:
  • platform/gtk/fast/text/hyphenate-limit-lines-expected.txt:
  • platform/gtk/fast/text/selection-in-initial-advance-region-expected.txt:

Sep 20, 2017:

11:49 PM Changeset in webkit [222314] by Antti Koivisto
  • 2 edits in trunk/Source/WebCore

inspector/dom/content-node-region-info.html and inspector/dom/content-flow tests crashing
https://bugs.webkit.org/show_bug.cgi?id=177249
<rdar://problem/34559968>

Unreviewed.

  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::getNamedFlowCollection):

Fix crashing by adding a few lines of removed code back.

10:45 PM Changeset in webkit [222313] by jmarcell@apple.com
  • 5 edits in tags/Safari-605.1.7/Source

Cherry-pick r222287. rdar://problem/34458622

8:36 PM Changeset in webkit [222312] by Joseph Pecoraro
  • 26 edits in trunk/JSTests

Unreviewed follow-up to r222311.

  • test262/harness/sta.js:
  • test262/test/built-ins/Array/from/calling-from-valid-1-noStrict.js:
  • test262/test/built-ins/Array/from/calling-from-valid-1-onlyStrict.js:
  • test262/test/built-ins/Array/from/calling-from-valid-2.js:
  • test262/test/built-ins/Array/from/elements-added-after.js:
  • test262/test/built-ins/Array/from/elements-deleted-after.js:
  • test262/test/built-ins/Array/from/elements-updated-after.js:
  • test262/test/built-ins/Array/from/from-array.js:
  • test262/test/built-ins/Array/from/mapfn-is-not-callable-typeerror.js:
  • test262/test/built-ins/Array/from/mapfn-throws-exception.js:
  • test262/test/built-ins/Array/from/source-array-boundary.js:
  • test262/test/built-ins/Array/from/source-object-constructor.js:
  • test262/test/built-ins/Array/from/source-object-iterator-1.js:
  • test262/test/built-ins/Array/from/source-object-iterator-2.js:
  • test262/test/built-ins/Array/from/source-object-length.js:
  • test262/test/built-ins/Array/from/source-object-missing.js:
  • test262/test/built-ins/Array/from/source-object-without.js:
  • test262/test/built-ins/Array/from/this-null.js:
  • test262/test/built-ins/Function/prototype/toString/line-terminator-normalisation-CR.js:
  • test262/test/language/line-terminators/S7.3_A3.2_T1.js:
  • test262/test/language/literals/numeric/7.8.3-1gs.js:
  • test262/test/language/literals/numeric/7.8.3-2gs.js:
  • test262/test/language/literals/numeric/7.8.3-3gs.js:
  • test262/test/language/literals/regexp/7.8.5-1gs.js:
  • test262/test/language/literals/string/7.8.4-1gs.js:

Fix some files that I failed to update when I applied my patch.

8:23 PM Changeset in webkit [222311] by Joseph Pecoraro
  • 7086 edits
    21 moves
    6689 adds
    932 deletes in trunk

Update test262 tests
https://bugs.webkit.org/show_bug.cgi?id=177220

Reviewed by Saam Barati and Yusuke Suzuki.

JSTests:

  • test262.yaml:
  • test262/test262-Revision.txt:

New rebaselined expectations for all tests.

  • test262/*:

Updated.

Tools:

  • Scripts/import-test262-tests:
  • better detect upstream git repository url from import location
  • update JSTest test262 resources when importing from repository
  • take seconds instead of 20+ minutes to write yaml with --failures
  • update "negative" command to only include just the exception type
8:05 PM Changeset in webkit [222310] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Remove redundant SelectionSubtreeData functions.
https://bugs.webkit.org/show_bug.cgi?id=177288

Reviewed by Simon Fraser.

No change in functionality.

  • rendering/SelectionSubtreeRoot.h:

(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::SelectionSubtreeData):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionEndPos const):
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::selectionClear const): Deleted.
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::setSelectionStart): Deleted.
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::setSelectionStartPos): Deleted.
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::setSelectionEnd): Deleted.
(WebCore::SelectionSubtreeRoot::SelectionSubtreeData::setSelectionEndPos): Deleted.
(): Deleted.

7:55 PM Changeset in webkit [222309] by commit-queue@webkit.org
  • 25 edits in trunk/Source

[Win] WTF: Add alias for process id to use in place of direct uses of pid_t
https://bugs.webkit.org/show_bug.cgi?id=177017

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2017-09-20
Reviewed by Alex Christensen.

Source/JavaScriptCore:

  • API/JSRemoteInspector.cpp:

(JSRemoteInspectorSetParentProcessInformation):

  • API/JSRemoteInspector.h:
  • inspector/remote/RemoteInspector.h:

Source/WebKit:

  • NetworkProcess/NetworkProcessCreationParameters.h:
  • Shared/WebProcessCreationParameters.h:
  • UIProcess/API/APIProcessPoolConfiguration.h:
  • UIProcess/API/C/WKContext.cpp:

(WKContextGetNetworkProcessIdentifier):
(WKContextGetDatabaseProcessIdentifier):

  • UIProcess/API/C/WKContextPrivate.h:
  • UIProcess/API/C/WKPage.cpp:

(WKPageGetProcessIdentifier):

  • UIProcess/API/C/WKPagePrivate.h:
  • UIProcess/ChildProcessProxy.h:

(WebKit::ChildProcessProxy::processIdentifier const):

  • UIProcess/Launcher/ProcessLauncher.cpp:

(WebKit::ProcessLauncher::didFinishLaunchingProcess):

  • UIProcess/Launcher/ProcessLauncher.h:

(WebKit::ProcessLauncher::processIdentifier const):

  • UIProcess/ProcessAssertion.cpp:

(WebKit::ProcessAssertion::ProcessAssertion):
(WebKit::ProcessAndUIAssertion::ProcessAndUIAssertion):

  • UIProcess/ProcessAssertion.h:

(WebKit::ProcessAssertion::ProcessAssertion):

  • UIProcess/ProcessThrottler.cpp:

(WebKit::ProcessThrottler::didConnectToProcess):

  • UIProcess/ProcessThrottler.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::processIdentifier const):

  • UIProcess/WebPageProxy.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::networkProcessIdentifier):
(WebKit::WebProcessPool::storageProcessIdentifier):

  • UIProcess/WebProcessPool.h:

Source/WTF:

  • wtf/ProcessID.h:

(WTF::getCurrentProcessID):

7:48 PM Changeset in webkit [222308] by Chris Dumez
  • 12 edits in trunk

[WK2] Add API to get the redirect chain of a WKDownload
https://bugs.webkit.org/show_bug.cgi?id=176628
<rdar://problem/34338279>

Reviewed by Alex Christensen.

Source/WebKit:

Add API to get the redirect chain of a WKDwnload. The redirect chain includes redirects
that happened during initial load, before the load was converted into a download.

  • UIProcess/API/C/WKDownload.cpp:

(WKDownloadCopyRedirectChain):

  • UIProcess/API/C/WKDownload.h:
  • UIProcess/API/Cocoa/_WKDownload.h:
  • UIProcess/API/Cocoa/_WKDownload.mm:

(-[_WKDownload originatingWebView]):
(-[_WKDownload redirectChain]):

  • UIProcess/Downloads/DownloadProxy.cpp:

(WebKit::DownloadProxy::willSendRequest):

  • UIProcess/Downloads/DownloadProxy.h:

(WebKit::DownloadProxy::setRedirectChain):
(WebKit::DownloadProxy::redirectChain const):

  • UIProcess/WebFrameProxy.cpp:

(WebKit::WebFrameProxy::didStartProvisionalLoad):
(WebKit::WebFrameProxy::didReceiveServerRedirectForProvisionalLoad):

  • UIProcess/WebFrameProxy.h:

(WebKit::WebFrameProxy::redirectChain const):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):

Tools:

Add API test coverage for the 2 cases:

  1. Download started as a download and is redirected while downloading.
  2. Download started as a load and was redirected during the initial load.
  • TestWebKitAPI/Tests/WebKitCocoa/Download.mm:

(-[RedirectedDownloadDelegate _download:didReceiveServerRedirectToURL:]):
(-[RedirectedDownloadDelegate _downloadDidFinish:]):
(TEST):

6:34 PM Changeset in webkit [222307] by commit-queue@webkit.org
  • 590 edits
    3 copies
    2 moves
    930 adds
    172 deletes in trunk/LayoutTests

Refresh WPT tests up to f65af411d63ec13ee8fe208b4effd730a4a8b7fe
https://bugs.webkit.org/show_bug.cgi?id=170713

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-20
Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • resources/TestRepositories:
  • resources/import-expectations.json:
  • resources/resource-files.json:
  • web-platform-tests: Refreshed by importer.

LayoutTests:

Rebasing tests and marking some tests as failing.

  • TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/ios-wk2/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/mac/imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/test_wrapKey_unwrapKey.https-expected.txt:
  • platform/mac/imported/w3c/web-platform-tests/WebCryptoAPI/wrapKey_unwrapKey/wrapKey_unwrapKey.worker-expected.txt:
  • platform/mac/imported/w3c/web-platform-tests/XMLHttpRequest/send-blob-with-no-mime-type-expected.txt:
  • platform/mac/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any-expected.txt:
  • platform/mac/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt:
  • platform/mac/imported/w3c/web-platform-tests/html/browsers/history/the-location-interface/location_hash-expected.txt:
  • platform/mac/imported/w3c/web-platform-tests/media-source/interfaces-expected.txt:
  • tests-options.json:
6:15 PM Changeset in webkit [222306] by achristensen@apple.com
  • 16 edits
    3 adds in trunk

Add infrastructure for adding custom headers to requests per website
https://bugs.webkit.org/show_bug.cgi?id=177255

Reviewed by Geoffrey Garen.

Source/WebCore:

Covered by API tests.

  • CMakeLists.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • loader/DocumentLoader.cpp:
  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::setCustomHeaderFields):

  • loader/HTTPHeaderField.cpp: Added.

(WebCore::RFC7230::isTokenCharacter):
(WebCore::RFC7230::isDelimiter):
(WebCore::RFC7230::isVisibleCharacter):
(WebCore::RFC7230::isWhitespace):
(WebCore::RFC7230::isInRange):
(WebCore::RFC7230::isOBSText):
(WebCore::RFC7230::isQuotedTextCharacter):
(WebCore::RFC7230::isQuotedPairSecondOctet):
(WebCore::RFC7230::isCommentText):
(WebCore::RFC7230::isValidName):
(WebCore::RFC7230::isValidValue):
(WebCore::HTTPHeaderField::HTTPHeaderField):

  • loader/HTTPHeaderField.h: Added.

(WebCore::HTTPHeaderField::encode const):
(WebCore::HTTPHeaderField::decode):

Source/WebKit:

  • Shared/WebsitePolicies.cpp: Added.
  • Shared/WebsitePolicies.h:

(WebKit::WebsitePolicies::encode const):
(WebKit::WebsitePolicies::decode):

  • UIProcess/API/APIWebsitePolicies.h:
  • UIProcess/API/C/WKWebsitePolicies.cpp:

(WKWebsitePoliciesCopyCustomHeaderFields):
(WKWebsitePoliciesSetCustomHeaderFields):

  • UIProcess/API/C/WKWebsitePolicies.h:
  • UIProcess/API/Cocoa/_WKWebsitePolicies.h:
  • UIProcess/API/Cocoa/_WKWebsitePolicies.mm:

(-[_WKWebsitePolicies customHeaderFields]):
(-[_WKWebsitePolicies setCustomHeaderFields:]):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/HTTPHeaderField.cpp: Added.

(shouldRemainUnchanged):
(shouldBeInvalid):
(shouldBecome):
(TEST):

  • TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:

(TEST):

6:10 PM Changeset in webkit [222305] by keith_miller@apple.com
  • 3 edits
    1 move in trunk/Source/JavaScriptCore

Rename source list file to Sources.txt
https://bugs.webkit.org/show_bug.cgi?id=177283

Reviewed by Saam Barati.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • Sources.txt: Renamed from Source/JavaScriptCore/sources.txt.
5:35 PM Changeset in webkit [222304] by Said Abou-Hallawa
  • 5 edits
    2 adds in trunk

REGRESSION(r191731): SVGPatternElement can only reference another SVGPatternElement in the same SVG document
https://bugs.webkit.org/show_bug.cgi?id=176221

Reviewed by Tim Horton.

Source/WebCore:

According to the specs:

https://www.w3.org/TR/SVG11/filters.html#FilterElementHrefAttribute
https://www.w3.org/TR/SVG11/pservers.html#LinearGradientElementHrefAttribute
https://www.w3.org/TR/SVG11/pservers.html#RadialGradientElementHrefAttribute
https://www.w3.org/TR/SVG11/pservers.html#PatternElementHrefAttribute

The xlink:href attribute of the SVG filter, gradient and pattern elements
must reference another element within the current SVG of the same type.

In r191731, the code of SVGPatternElement::collectPatternAttributes() was
removed and replaced by RenderSVGResourcePattern::collectPatternAttributes()
to avoid cyclic reference in the pattern element. The problem is the old
code used to check whether the referenced element is<SVGPatternElement>
before casting it. This code was not copied to the new function. So we
now allow the SVGPatternElement to reference any SVG resource element.

To fix this issue, we need to prevent SVGResources from chaining an incorrect
type of element to the SVG filter, gradient and pattern elements.

We also need to use the SVGResources for getting the referenced element
when collecting the attributes for the gradient elements. SVGResources solves
the cyclic referencing issue so there is no need to repeat the same code
in many places. Also, from now on the SVGResources will have valid linked
resource only. So casting the referenced element should always be valid.

Tests: svg/custom/pattern-invalid-content-inheritance.svg

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::collectPatternAttributes const): Asserts
the linkedResource is of type RenderSVGResourcePattern.

  • rendering/svg/SVGResources.cpp:

(WebCore::SVGResources::SVGResources):
(WebCore::isChainableResource): Ensure that an SVG resource can reference
only an SVG resource with the valid type.
(WebCore::SVGResources::buildCachedResources):

  • rendering/svg/SVGResources.h:

LayoutTests:

  • svg/custom/pattern-invalid-content-inheritance-expected.svg: Added.
  • svg/custom/pattern-invalid-content-inheritance.svg: Added.
5:30 PM Changeset in webkit [222303] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark transitions/transition-display-property.html as flaky on Windows.
https://bugs.webkit.org/show_bug.cgi?id=177284

Unreviewed test gardening.

  • platform/win/TestExpectations:
5:21 PM Changeset in webkit [222302] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark http/wpt/resource-timing/rt-resource-errors.html as flaky on Windows.
https://bugs.webkit.org/show_bug.cgi?id=177282

Unreviewed test gardening.

  • platform/win/TestExpectations:
5:11 PM Changeset in webkit [222301] by keith_miller@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Unreviewed, fix string capitalization

5:09 PM Changeset in webkit [222300] by jmarcell@apple.com
  • 7 edits in branches/safari-604-branch/Source

Versioning.

4:19 PM Changeset in webkit [222299] by jmarcell@apple.com
  • 11 edits
    2 adds in branches/safari-604-branch

Cherry-pick r222097. rdar://problem/34508516

4:13 PM Changeset in webkit [222298] by dbates@webkit.org
  • 7 edits
    3 adds in trunk

Spelling and grammar dots should not overlap
https://bugs.webkit.org/show_bug.cgi?id=177265
<rdar://problem/34556424>

Reviewed by David Hyatt.

Source/WebCore:

A line may contain both spelling and grammar errors such that these errors overlap.
For example, "to mooof or not to mooof.". It is more pleasing aesthetically to
paint spelling and grammar dots such that they do not overlap. This also matches
AppKit's behavior.

A side benefit of this change is that it adds support infrastructure towards
implementing the CSS Pseudo-Elements Module Level 4 pseudo elements ::spelling-error
and ::grammar-error (see <https://bugs.webkit.org/show_bug.cgi?id=175784>).
It will also make it straightforward to add ::inactive-selection and allow us
to make ::selection conform to CSS Pseudo-Elements Module Level 4.

  • CMakeLists.txt: Add file MarkerSubrange.cpp.
  • WebCore.xcodeproj/project.pbxproj: Add files MarkerSubrange.{cpp, h}.
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintDocumentMarker): Modified to take a const MarkerSubrange&
instead of a RenderedDocumentMarker&.
(WebCore::InlineTextBox::paintTextMatchMarker): Modified to take a const MarkerSubrange&
instead of a RenderedDocumentMarker& and take a boolean as to whether the text match is active.
(WebCore::InlineTextBox::paintDocumentMarkers): Collect the subranges that need to be
painted, subdivide them preserving only the frontmost subrange when two or more subranges
overlap and paint the resulting subranges.
(WebCore::lineStyleForMarkerType): Deleted; converted to a lambda function inlined
in paintDocumentMarker() as this is the only place we made use of this function.

  • rendering/InlineTextBox.h:
  • rendering/MarkerSubrange.cpp: Added.

(WebCore::subdivide): Subdivides the specified list of subranges and returns a list of non-overlapping
subranges in paint order. The implementation of subdivide() is derived from an algorithm that
Said Abou-Hallawa came up with.

  • rendering/MarkerSubrange.h: Added.

(WebCore::MarkerSubrange::MarkerSubrange):

Tools:

Add unit tests for the subdivision algorithm.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/MarkerSubrange.cpp: Added.

(WebCore::operator<<):
(WebCore::operator==):
(TestWebKitAPI::TEST):

4:08 PM Changeset in webkit [222297] by keith_miller@apple.com
  • 8 edits
    1 move
    2 adds in trunk

JSC Xcode build should use unified sources for platform independent files
https://bugs.webkit.org/show_bug.cgi?id=177190

Reviewed by Saam Barati.

.:

Add a macro for collecting the set of "header" source files and adding the bundle
files to the "sources" list.

  • Source/cmake/WebKitMacros.cmake:

Source/JavaScriptCore:

This patch changes the Xcode build to use unified sources. The
main difference from a development perspective is that instead of
added source files to Xcode they need to be added to the shared
sources.txt. For now, platform specific files are still added
to the JavaScriptCore target.

Because Xcode needs to know about all the files before we generate
them all the unified source files need to be added to the
JavaScriptCore framework target. As a result, if we run out of
bundle files more will need to be added to the project. Currently,
there are no spare files. If adding more bundle files becomes
problematic we can change this.

LowLevelInterpreter.cpp can't be added to the unified source list yet
due to a clang bug.

  • CMakeLists.txt:
  • JavaScriptCore.xcodeproj/project.pbxproj:
  • sources.txt: Added.

Source/WTF:

Add a new directory for build scripts that are forwarded to subsequent framework builds.

  • Scripts/generate-unified-source-bundles.rb: Renamed from Source/WTF/generate-unified-source-bundles.rb.
  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
4:05 PM Changeset in webkit [222296] by Michael Catanzaro
  • 4 edits in trunk

REGRESSION(r222194) [WPE] Library and executable output names broken
https://bugs.webkit.org/show_bug.cgi?id=177273

Reviewed by Carlos Alberto Lopez Perez.

.:

Move the WebKit2 output name variables from here to Source/WebKit.

  • Source/cmake/OptionsWPE.cmake:

Source/WebKit:

Move the WebKit2 output name variables to here from Source/cmake, since this is a better
place and where they are set on all other ports. Update them for the changes in r222194.

  • PlatformWPE.cmake:
3:41 PM Changeset in webkit [222295] by fpizlo@apple.com
  • 12 edits
    3 adds in trunk/Tools

WSL should not type-check functions in the standard library that it does not use
https://bugs.webkit.org/show_bug.cgi?id=177269

Reviewed by JS Bastien.

Once we added all of the swizzling operators, the size of the standard library ballooned to the point
where it's just not practical to compile anything anymore. If you want to compile
"int foo(int x) { return x}" then it will take some ridiculous amount of time (many seconds) because WSL
will have to type check all of those swizzling operators.

This change makes it so that after parsing the whole program, we remove the things that we aren't using.
We can make a really good estimate of what we need even before doing any name resolution. In practice,
this change removes almost all of the things from Program before we get to the hard work of type
checking. That's true because the standard library contains _many_ things and you'd have to try very
hard to use all of them.

This is a 13x speed-up for Test.js. It went from 155 seconds to 12 seconds on my machine.

  • WebGPUShadingLanguageRI/All.js:
  • WebGPUShadingLanguageRI/ConstexprTypeParameter.js:

(ConstexprTypeParameter.prototype.get origin):

  • WebGPUShadingLanguageRI/Intrinsics.js:
  • WebGPUShadingLanguageRI/Lexer.js:

(Lexer):
(Lexer.prototype.get originKind):

  • WebGPUShadingLanguageRI/LexerToken.js:

(LexerToken.prototype.get lexer):
(LexerToken.prototype.get origin):
(LexerToken.prototype.get originKind):
(LexerToken.prototype.get isInternal):

  • WebGPUShadingLanguageRI/NameContext.js:

(isWildcardKind):
(NameContext.prototype.add):
(NameContext.prototype.get let):
(NameContext.prototype.mapFor): Deleted.

  • WebGPUShadingLanguageRI/NameFinder.js: Added.

(NameFinder):
(NameFinder.get worklist):

  • WebGPUShadingLanguageRI/NameResolver.js:

(NameResolver.prototype.visitProtocolDecl):

  • WebGPUShadingLanguageRI/OriginKind.js: Added.

(isOriginKind):

  • WebGPUShadingLanguageRI/Prepare.js:

(let.prepare):

  • WebGPUShadingLanguageRI/ProgramWithUnnecessaryThingsRemoved.js: Added.

(programWithUnnecessaryThingsRemoved):

  • WebGPUShadingLanguageRI/Test.html:
  • WebGPUShadingLanguageRI/Test.js:

(doTest):

  • WebGPUShadingLanguageRI/index.html:
3:27 PM Changeset in webkit [222294] by achristensen@apple.com
  • 12 edits in trunk

Remove ActionType::CSSDisplayNoneStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=177275

Reviewed by Andy Estes.

Source/WebCore:

It not a real action type anyways. It was a fake action type
that stored a String indicating which ContentRuleLists had not triggered
an ignore-previous-rules action, so we should apply the default stylesheet,
which is the css-display-none selectors that match everything.

No change in behaviour. Covered by existing tests.

  • contentextensions/ContentExtensionActions.h:
  • contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::serializeActions):

  • contentextensions/ContentExtensionRule.cpp:

(WebCore::ContentExtensions::Action::deserialize):
(WebCore::ContentExtensions::Action::deserializeType):
(WebCore::ContentExtensions::Action::serializedLength):

  • contentextensions/ContentExtensionRule.h:

(WebCore::ContentExtensions::Action::Action):

  • contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad const):
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad):
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForPingLoad):

  • contentextensions/ContentExtensionsBackend.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::open):

  • page/UserContentProvider.cpp:

(WebCore::UserContentProvider::actionsForResourceLoad):

  • page/UserContentProvider.h:

Tools:

  • TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(WebCore::ContentExtensions::operator<<):
(TestWebKitAPI::testRequest):
(TestWebKitAPI::TEST_F):

3:08 PM Changeset in webkit [222293] by Jonathan Bedard
  • 3 edits in trunk/Tools

Device iOS 11 builds fail with FileProvider linker errors
https://bugs.webkit.org/show_bug.cgi?id=177272
<rdar://problem/34557680>

Reviewed by David Kilzer.

For iOS device and simulator, the SYSTEM_LIBRARY_DIR should never
be on the framework search path as neither platform should ever link
with Mac frameworks.

  • DumpRenderTree/mac/Configurations/Base.xcconfig:
  • WebKitTestRunner/Configurations/Base.xcconfig:
3:03 PM Changeset in webkit [222292] by Alan Bujtas
  • 7 edits in trunk/Source/WebCore

FloatingObject should not hold a raw pointer to RootInlineBox.
https://bugs.webkit.org/show_bug.cgi?id=177266

Reviewed by Simon Fraser.

FloatingObject and RootInlineBox objects' lifetimes are very much independent from each other.

Not testable.

  • rendering/FloatingObjects.cpp:

(WebCore::FloatingObjects::clearLineBoxTreePointers):

  • rendering/FloatingObjects.h:

(WebCore::FloatingObject::originatingLine const):
(WebCore::FloatingObject::clearOriginatingLine):
(WebCore::FloatingObject::setOriginatingLine):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::removeFloatingObject):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::appendFloatingObjectToLastLine):
(WebCore::RenderBlockFlow::reattachCleanLineFloats):
(WebCore::RenderBlockFlow::determineStartPosition):

  • rendering/RootInlineBox.cpp:

(WebCore::RootInlineBox::RootInlineBox):

  • rendering/RootInlineBox.h:

(WebCore::RootInlineBox::createWeakPtr):

2:59 PM Changeset in webkit [222291] by Chris Dumez
  • 9 edits
    3 deletes in trunk/Source/WebCore

Drop legacy DOMError type
https://bugs.webkit.org/show_bug.cgi?id=177207

Reviewed by Eric Carlson.

Drop legacy DOMError type. It has been removed from the Web standards,
is no longer used by our implementation and was not exposed to the
Web in WebKit (i.e. marked as [NoInterfaceObject]).

  • CMakeLists.txt:
  • DerivedSources.cpp:
  • DerivedSources.make:
  • Modules/mediastream/MediaEndpointSessionDescription.h:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMPromiseDeferred.cpp:
  • dom/DOMAllInOne.cpp:
  • dom/DOMError.cpp: Removed.
  • dom/DOMError.h: Removed.
  • dom/DOMError.idl: Removed.
  • platform/mock/RTCNotifiersMock.cpp:
2:47 PM Changeset in webkit [222290] by jmarcell@apple.com
  • 1 copy in tags/Safari-604.3.2

Tag Safari-604.3.2.

2:28 PM Changeset in webkit [222289] by jmarcell@apple.com
  • 7 edits in trunk/Source

Versioning.

2:17 PM Changeset in webkit [222288] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.1.7

Tag Safari-605.1.7.

2:09 PM Changeset in webkit [222287] by pvollan@apple.com
  • 5 edits in trunk/Source

[Win] Cannot find script to generate unified sources.
https://bugs.webkit.org/show_bug.cgi?id=177014

Reviewed by Keith Miller.

Source/JavaScriptCore:

The ruby script can now be found in WTF/Scripts in the forwarding headers folder.

Source/WTF:

Copy the ruby script to WTF/Scripts in the forwarding headers folder.

  • wtf/CMakeLists.txt:
2:01 PM Changeset in webkit [222286] by mitz@apple.com
  • 9 copies
    1 add in releases/Apple/Safari Technology Preview 40

Added a tag for Safari Technology Preview release 40.

2:00 PM Changeset in webkit [222285] by commit-queue@webkit.org
  • 10 edits in trunk

Unreviewed, rolling out r222254.
https://bugs.webkit.org/show_bug.cgi?id=177267

Caused fast/images/animated-gif-webkit-transform.html to time
out, and possible perf regression (Requested by smfr on
#webkit).

Reverted changeset:

"Simplify compositing layer updating"
https://bugs.webkit.org/show_bug.cgi?id=176196
http://trac.webkit.org/changeset/222254

1:54 PM Changeset in webkit [222284] by commit-queue@webkit.org
  • 1 edit
    365 adds in trunk/Source/ThirdParty/libwebrtc

Upstream googletest framework
https://bugs.webkit.org/show_bug.cgi?id=177252

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-20
Reviewed by Alex Christensen.

This is used by libwebrtc.

  • Source/third_party/googletest: Added.
1:46 PM Changeset in webkit [222283] by achristensen@apple.com
  • 8 edits in trunk

Remove ActionType::InvalidAction
https://bugs.webkit.org/show_bug.cgi?id=177262

Reviewed by Tim Horton.

Source/WebCore:

This was needed before r213322 because we needed to have a default constructor.
With all these cool new C++14/17 types, we don't need this any more.

No change in behaviour.

  • contentextensions/ContentExtensionActions.h:
  • contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::serializeActions):

  • contentextensions/ContentExtensionRule.cpp:

(WebCore::ContentExtensions::Action::deserialize):
(WebCore::ContentExtensions::Action::deserializeType):
(WebCore::ContentExtensions::Action::serializedLength):

  • contentextensions/ContentExtensionRule.h:
  • contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad):
(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForPingLoad):

Tools:

  • TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(WebCore::ContentExtensions::operator<<):

1:38 PM Changeset in webkit [222282] by dbates@webkit.org
  • 4 edits in trunk/Source/WebCore

RenderedDocumentMarker.h should include DocumentMarker.h
https://bugs.webkit.org/show_bug.cgi?id=177263

Reviewed by Andy Estes.

RenderedDocumentMarker extends DocumentMarker. RenderedDocumentMarker.h should
include DocumentMarker.h. Otherwise, both DocumentMarker.h and RenderedDocumentMarker.h
must be explicitly included.

  • dom/RenderedDocumentMarker.h:
  • rendering/RenderText.cpp:
  • testing/Internals.cpp:
1:09 PM Changeset in webkit [222281] by Ryan Haddad
  • 2 edits
    1 add in trunk/LayoutTests

Unreviewed, rolling out r222278.

This needs more work before it can be landed.

Reverted changeset:

"Work towards: Move test expectations from 'ios-11' to 'ios'
directory"
https://bugs.webkit.org/show_bug.cgi?id=177167
http://trac.webkit.org/changeset/222278

1:07 PM Changeset in webkit [222280] by mmaxfield@apple.com
  • 7 edits
    1 copy
    1 add in trunk/Tools

Make a playground where people can try WSL
https://bugs.webkit.org/show_bug.cgi?id=177125

Reviewed by Filip Pizlo.

This patch creates a webpage, index.html, which lets users type in a WSL program and
run it, and see the results.

  • WebGPUShadingLanguageRI/All.js:
  • WebGPUShadingLanguageRI/CallFunction.js:

(callFunction):

  • WebGPUShadingLanguageRI/Checker.js:

(Checker):
(Checker.prototype._checkShaderType.NonNumericSearcher):
(Checker.prototype._checkShaderType.NonNumericSearcher.prototype.visitArrayRefType):
(Checker.prototype._checkShaderType.NonNumericSearcher.prototype.visitPtrType):
(Checker.prototype._checkShaderType):
(Checker.prototype.visitFuncDef):
(Checker.prototype._requireBool):

  • WebGPUShadingLanguageRI/FlattenedStructOffsetGatherer.js: Copied from Tools/WebGPUShadingLanguageRI/CallFunction.js.

(FlattenedStructOffsetGatherer):
(FlattenedStructOffsetGatherer.prototype.get result):
(FlattenedStructOffsetGatherer.prototype.visitReferenceType):
(FlattenedStructOffsetGatherer.prototype.visitField):
(FlattenedStructOffsetGatherer.prototype.visitNativeType):

  • WebGPUShadingLanguageRI/Func.js:

(Func.prototype.toDeclString):

  • WebGPUShadingLanguageRI/Inline.js:

(resolveInlinedFunction):

  • WebGPUShadingLanguageRI/NameContext.js:

(NameContext.prototype.get let):

  • WebGPUShadingLanguageRI/ResolveOverloadImpl.js:

(resolveOverloadImpl):

  • WebGPUShadingLanguageRI/StandardLibrary.js:
  • WebGPUShadingLanguageRI/Test.html:
  • WebGPUShadingLanguageRI/Test.js:

(TEST_shaderTypes):

  • WebGPUShadingLanguageRI/index.html: Added.
1:03 PM Changeset in webkit [222279] by mmaxfield@apple.com
  • 4 edits in trunk/Tools

[WSL] Restrict vertex and fragment entry points according to WSL.md
https://bugs.webkit.org/show_bug.cgi?id=177253

Reviewed by Filip Pizlo.

Entry points can't have template arguments, and their argument/return types need to be restricted.

  • WebGPUShadingLanguageRI/Checker.js:

(Checker):
(Checker.prototype._checkShaderType.NonNumericSearcher):
(Checker.prototype._checkShaderType.NonNumericSearcher.prototype.visitArrayRefType):
(Checker.prototype._checkShaderType.NonNumericSearcher.prototype.visitPtrType):
(Checker.prototype._checkShaderType):
(Checker.prototype.visitFuncDef):
(Checker.prototype._requireBool):

  • WebGPUShadingLanguageRI/Func.js:

(Func.prototype.toDeclString):

  • WebGPUShadingLanguageRI/Test.js:

(TEST_shaderTypes):

12:38 PM Changeset in webkit [222278] by Ryan Haddad
  • 2 edits
    1 delete in trunk/LayoutTests

Work towards: Move test expectations from 'ios-11' to 'ios' directory
https://bugs.webkit.org/show_bug.cgi?id=177167

Unreviewed test gardening.

  • platform/ios-11/TestExpectations: Removed.
  • platform/ios/TestExpectations:
12:37 PM Changeset in webkit [222277] by achristensen@apple.com
  • 5 edits in trunk/Source/WebCore

Clean up content extensions code in preparation for more actions with string arguments
https://bugs.webkit.org/show_bug.cgi?id=177258

Reviewed by Tim Horton.

No change in behaviour. Covered by existing tests.

  • contentextensions/ContentExtensionCompiler.cpp:

(WebCore::ContentExtensions::serializeString):
(WebCore::ContentExtensions::resolvePendingDisplayNoneActions):
(WebCore::ContentExtensions::serializeActions):
(WebCore::ContentExtensions::serializeSelector): Deleted.

  • contentextensions/ContentExtensionParser.cpp:

(WebCore::ContentExtensions::loadAction):
(WebCore::ContentExtensions::loadRule):

  • contentextensions/ContentExtensionRule.cpp:

(WebCore::ContentExtensions::deserializeString):
(WebCore::ContentExtensions::Action::deserialize):
(WebCore::ContentExtensions::Action::deserializeType):
(WebCore::ContentExtensions::Action::serializedLength):

  • contentextensions/ContentExtensionRule.h:

(WebCore::ContentExtensions::Action::Action):

12:30 PM Changeset in webkit [222276] by jdiggs@igalia.com
  • 4 edits
    1 add in trunk

[ATK] atk_table_get_n_rows() and atk_table_get_n_columns() should return values of aria-rowcount and aria-colcount, if present
https://bugs.webkit.org/show_bug.cgi?id=171172

Reviewed by Chris Fleizach.

Source/WebCore:

Modify webKitAccessibleTableGetNColumns() and webkitAccessibleTableGetNRows()
to prefer the ARIA value over the DOM-based value.

No new tests needed: We already have coverage through aria-table-attributes.html.
Platform expectations for this test were updated.

  • accessibility/atk/WebKitAccessibleInterfaceTable.cpp:

(webkitAccessibleTableGetNColumns):
(webkitAccessibleTableGetNRows):

LayoutTests:

Generated platform-specific expectations to reflect the new behavior.

  • accessibility/aria-table-attributes.html: Modified to handle platform differences.
  • platform/gtk/accessibility/aria-table-attributes-expected.txt: Added.
12:07 PM WebKitGTK/2.18.x edited by berto@igalia.com
(diff)
12:04 PM Changeset in webkit [222275] by berto@igalia.com
  • 6 edits in trunk

Fix HPPA and Alpha builds
https://bugs.webkit.org/show_bug.cgi?id=177224

Reviewed by Alex Christensen.

.:

  • CMakeLists.txt:

Source/JavaScriptCore:

  • CMakeLists.txt:

Source/WTF:

  • wtf/Platform.h:
12:04 PM Changeset in webkit [222274] by commit-queue@webkit.org
  • 10 edits
    3 moves in trunk/Source/WebCore

Rename CacheStorage to DOMCacheStorage
https://bugs.webkit.org/show_bug.cgi?id=177025

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-20
Reviewed by Chris Dumez.

No change of behavior, just renaming CacheStorage class and files to DOMCacheStorage.

  • CMakeLists.txt:
  • DerivedSources.make:
  • Modules/cache/DOMCacheStorage.cpp: Renamed from Source/WebCore/Modules/cache/CacheStorage.cpp.

(WebCore::DOMCacheStorage::DOMCacheStorage):
(WebCore::DOMCacheStorage::origin const):
(WebCore::doSequentialMatch):
(WebCore::startSequentialMatch):
(WebCore::copyCaches):
(WebCore::DOMCacheStorage::match):
(WebCore::DOMCacheStorage::has):
(WebCore::DOMCacheStorage::retrieveCaches):
(WebCore::logConsolePersistencyError):
(WebCore::DOMCacheStorage::open):
(WebCore::DOMCacheStorage::remove):
(WebCore::DOMCacheStorage::keys):
(WebCore::DOMCacheStorage::stop):
(WebCore::DOMCacheStorage::activeDOMObjectName const):
(WebCore::DOMCacheStorage::canSuspendForDocumentSuspension const):

  • Modules/cache/DOMCacheStorage.h: Renamed from Source/WebCore/Modules/cache/CacheStorage.h.

(WebCore::DOMCacheStorage::create):

  • Modules/cache/DOMCacheStorage.idl: Renamed from Source/WebCore/Modules/cache/CacheStorage.idl.
  • Modules/cache/DOMWindowCaches.cpp:

(WebCore::DOMWindowCaches::caches):
(WebCore::DOMWindowCaches::caches const):

  • Modules/cache/DOMWindowCaches.h:
  • Modules/cache/DOMWindowCaches.idl:
  • Modules/cache/WorkerGlobalScopeCaches.cpp:

(WebCore::WorkerGlobalScopeCaches::caches):
(WebCore::WorkerGlobalScopeCaches::caches const):

  • Modules/cache/WorkerGlobalScopeCaches.h:
  • Modules/cache/WorkerGlobalScopeCaches.idl:
  • WebCore.xcodeproj/project.pbxproj:
11:10 AM Changeset in webkit [222273] by commit-queue@webkit.org
  • 8 edits in trunk/LayoutTests

Make webrtc replace track tests less flaky
https://bugs.webkit.org/show_bug.cgi?id=172645
<rdar://problem/34118218>

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-20
Reviewed by Eric Carlson.

Improving stability of tests by retrying tests every 50 ms instead of once.
Doing some refactoring to put more helper routines in routine.js
Relaxing black pixel check as compression may introduce some uncertainty.
It is now considered black if RGB < (30, 30, 30).

  • TestExpectations: Marking video-mute.html as Pass/Fail instead of Fail.
  • webrtc/routines.js:
  • webrtc/video-mute.html:
  • webrtc/video-replace-muted-track.html:
  • webrtc/video-replace-track-expected.txt:
  • webrtc/video-replace-track-to-null.html:
  • webrtc/video-replace-track.html:
11:04 AM Changeset in webkit [222272] by pvollan@apple.com
  • 2 edits in trunk/Tools

[Win] Cygwin 64-bit EWS process cannot find Visual Studio installation.
https://bugs.webkit.org/show_bug.cgi?id=177244

Reviewed by Alex Christensen.

The 64-bit EWS shell process should try to find Visual Studio in the 32-bit program files folder.

  • EWSTools/start-queue-win.sh:
10:55 AM Changeset in webkit [222271] by eric.carlson@apple.com
  • 11 edits in trunk/Source/WebCore

Switch PeerConnection to release logging
https://bugs.webkit.org/show_bug.cgi?id=177193
<rdar://problem/34529014>

Reviewed by Youenn Fablet.

  • Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::PeerConnectionBackend):
(WebCore::PeerConnectionBackend::createOfferSucceeded):
(WebCore::PeerConnectionBackend::createOfferFailed):
(WebCore::PeerConnectionBackend::createAnswerSucceeded):
(WebCore::PeerConnectionBackend::createAnswerFailed):
(WebCore::PeerConnectionBackend::setLocalDescriptionSucceeded):
(WebCore::PeerConnectionBackend::setLocalDescriptionFailed):
(WebCore::PeerConnectionBackend::setRemoteDescriptionSucceeded):
(WebCore::PeerConnectionBackend::setRemoteDescriptionFailed):
(WebCore::PeerConnectionBackend::addIceCandidateSucceeded):
(WebCore::PeerConnectionBackend::addIceCandidateFailed):
(WebCore::PeerConnectionBackend::newICECandidate):
(WebCore::PeerConnectionBackend::doneGatheringCandidates):
(WebCore::PeerConnectionBackend::logChannel const):

  • Modules/mediastream/PeerConnectionBackend.h:

(WebCore::PeerConnectionBackend::PeerConnectionBackend): Deleted.

  • Modules/mediastream/RTCPeerConnection.cpp:

(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::~RTCPeerConnection):
(WebCore::RTCPeerConnection::addTrack):
(WebCore::RTCPeerConnection::removeTrack):
(WebCore::RTCPeerConnection::addTransceiver):
(WebCore::RTCPeerConnection::queuedCreateOffer):
(WebCore::RTCPeerConnection::queuedCreateAnswer):
(WebCore::RTCPeerConnection::queuedSetLocalDescription):
(WebCore::RTCPeerConnection::queuedSetRemoteDescription):
(WebCore::RTCPeerConnection::queuedAddIceCandidate):
(WebCore::RTCPeerConnection::initializeConfiguration):
(WebCore::RTCPeerConnection::setConfiguration):
(WebCore::RTCPeerConnection::createDataChannel):
(WebCore::RTCPeerConnection::setSignalingState):
(WebCore::RTCPeerConnection::updateIceGatheringState):
(WebCore::RTCPeerConnection::updateIceConnectionState):
(WebCore::RTCPeerConnection::updateConnectionState):
(WebCore::RTCPeerConnection::replaceTrack):
(WebCore::RTCPeerConnection::dispatchEvent):
(WebCore::RTCPeerConnection::logChannel const):
(WebCore::rtcIceGatheringStateToString): Deleted.
(WebCore::rtcIceConnectionStateToString): Deleted.

  • Modules/mediastream/RTCPeerConnection.h:
  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::LibWebRTCMediaEndpoint):
(WebCore::LibWebRTCMediaEndpoint::OnStatsDelivered):
(WebCore::LibWebRTCMediaEndpoint::startLoggingStats):
(WebCore::LibWebRTCMediaEndpoint::logChannel const):
(WebCore::LibWebRTCMediaEndpoint::statsLogInterval const):

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.h:

(PAL::LogArgument<webrtc::RTCStats>::toString):

  • platform/mediastream/RTCIceConnectionState.h:

(PAL::LogArgument<WebCore::RTCIceConnectionState>::toString):

  • platform/mediastream/RTCIceGatheringState.h:

(PAL::LogArgument<WebCore::RTCIceGatheringState>::toString):

  • platform/mediastream/RTCPeerConnectionState.h:

(PAL::LogArgument<WebCore::RTCPeerConnectionState>::toString):

  • platform/mediastream/RTCSignalingState.h:

(PAL::LogArgument<WebCore::RTCSignalingState>::toString):

10:38 AM Changeset in webkit [222270] by Chris Dumez
  • 12 edits in trunk

Video errors should be instances of Error
https://bugs.webkit.org/show_bug.cgi?id=174573
<rdar://problem/34445494>

Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

Rebaseline tests now that output has changed slightly.

  • web-platform-tests/html/semantics/embedded-content/media-elements/event_pause_noautoplay-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/event_play_noautoplay-expected.txt:
  • web-platform-tests/html/semantics/embedded-content/media-elements/paused_true_during_pause-expected.txt:

Source/WebCore:

Video errors should be instances of DOMException and Error as per:

No new tests, extended existing test.

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::rejectPendingPlayPromises):
(WebCore::HTMLMediaElement::noneSupported):
(WebCore::HTMLMediaElement::cancelPendingEventsAndCallbacks):
(WebCore::HTMLMediaElement::pauseInternal):

  • html/HTMLMediaElement.h:

LayoutTests:

  • http/tests/security/video-cross-origin-caching-expected.txt:

Rebaseline test now that output has changed slightly.

  • media/media-play-promise-reject-load-abort-expected.txt:
  • media/media-play-promise-reject-load-abort.html:

Extend test coverage.

10:31 AM Changeset in webkit [222269] by commit-queue@webkit.org
  • 5 edits in trunk/Source/WebCore

[Curl] improve the implementation of FormDataStream
https://bugs.webkit.org/show_bug.cgi?id=177111

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-09-20
Reviewed by Alex Christensen.

  • platform/network/curl/FormDataStreamCurl.cpp:

(WebCore::FormDataStream::read):
(WebCore::FormDataStream::hasMoreElements const):

  • platform/network/curl/FormDataStreamCurl.h:

(WebCore::FormDataStream::setHTTPBody):
(WebCore::FormDataStream::FormDataStream): Deleted.

  • platform/network/curl/ResourceHandleCurlDelegate.cpp:

(WebCore::ResourceHandleCurlDelegate::ResourceHandleCurlDelegate):
(WebCore::ResourceHandleCurlDelegate::prepareSendData):
(WebCore::ResourceHandleCurlDelegate::didFinish):
(WebCore::ResourceHandleCurlDelegate::didFail):
(WebCore::ResourceHandleCurlDelegate::setupFormData):

  • platform/network/curl/ResourceHandleCurlDelegate.h:
10:21 AM Changeset in webkit [222268] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Skip inspector tests that crash after r222259.
https://bugs.webkit.org/show_bug.cgi?id=177249

Unreviewed test gardening.

  • platform/mac/TestExpectations:
9:44 AM Changeset in webkit [222267] by mmaxfield@apple.com
  • 4 edits in trunk/Tools

Create vector swizzle operators in WSL's standard library
https://bugs.webkit.org/show_bug.cgi?id=177116

Reviewed by Filip Pizlo.

Because there are 481 possible swizzling operators, StandardLibrary.js generates them
instead of including them by hand.

Adding so many functions slows down the compiler quite a bit.

  • WebGPUShadingLanguageRI/Prepare.js:

(prepare):

  • WebGPUShadingLanguageRI/StandardLibrary.js:

(intToString):
(_generateSwizzle):

9:35 AM WebKitGTK/2.18.x edited by Michael Catanzaro
(diff)
9:19 AM Changeset in webkit [222266] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKitLegacy/mac

Web Inspector: WebView indication highlights sticks around for WebKitLegacy views
https://bugs.webkit.org/show_bug.cgi?id=177101
<rdar://problem/34500648>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-20
Reviewed by Brian Burg.

  • WebInspector/WebNodeHighlight.mm:

Ensure we close the window that we have just removed.

9:16 AM Changeset in webkit [222265] by Jonathan Bedard
  • 2 edits in trunk/Source/WebKit

Removed nullable from UIDragItem property
https://bugs.webkit.org/show_bug.cgi?id=176264
<rdar://problem/31144674>

Unreviewed build fix

When a nullable annotation is used in a header file,
the Objective-C compiler forces annotations on the entire
file. Remove an unneeded annotation in UIKitSPI.h so that
we can build in iOS 11.

  • Platform/spi/ios/UIKitSPI.h:
9:02 AM Changeset in webkit [222264] by magomez@igalia.com
  • 2 edits in trunk/Source/WebCore

[GTK] Completely garbled display in GMail
https://bugs.webkit.org/show_bug.cgi?id=168964

Reviewed by Carlos Garcia Campos.

Do not try to decode images that are bigger than 32768 pixels, as cairo won't be able to render them,
and they will break the rendering of the rest of the page.

Covered by existent tests.

  • platform/graphics/ImageBackingStore.h:

(WebCore::ImageBackingStore::isOverSize):

9:00 AM WebKitGTK/Gardening/Calendar edited by Ms2ger@igalia.com
(diff)
8:37 AM Changeset in webkit [222263] by Antti Koivisto
  • 27 edits
    4 deletes in trunk/Source/WebCore

Remove RenderNamedFlowThread and FlowThreadController
https://bugs.webkit.org/show_bug.cgi?id=177229

Reviewed by Andreas Kling.

Get rid of some parts of the rendering code for CSS Regions.

The feature is disabled, no functional changes.

  • WebCore.xcodeproj/project.pbxproj:
  • rendering/FlowThreadController.cpp: Removed.
  • rendering/FlowThreadController.h: Removed.
  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::paintObject):
(WebCore::canComputeRegionRangeForBox):
(WebCore::RenderBlock::childBoxIsUnsplittableForFragmentation const):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::determineLogicalLeftPositionForChild):
(WebCore::RenderBlockFlow::applyBeforeBreak):
(WebCore::RenderBlockFlow::applyAfterBreak):
(WebCore::RenderBlockFlow::logicalHeightForChildForFragmentation const):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::layoutRunsAndFloatsInRange):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::borderBoxRectInRegion const):
(WebCore::RenderBox::scroll):
(WebCore::RenderBox::renderBoxRegionInfo const):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing const):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned const):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned const):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::adjustedPositionRelativeToOffsetParent const):

  • rendering/RenderElement.cpp:

(WebCore::RenderElement::willBeDestroyed):
(WebCore::RenderElement::hoverAncestor const):

  • rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::adjustedPositionRelativeToOffsetParent const):
(WebCore::RenderFlowThread::incrementAutoLogicalHeightRegions):
(WebCore::RenderFlowThread::decrementAutoLogicalHeightRegions):
(WebCore::RenderFlowThread::addRegionsOverflowFromChild):

  • rendering/RenderInline.cpp:

(WebCore::RenderInline::updateAlwaysCreateLineBoxes):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::calculateClipRects const):
(WebCore::RenderLayer::paintFixedLayersInNamedFlows): Deleted.
(WebCore::RenderLayer::hitTestFixedLayersInNamedFlows): Deleted.

  • rendering/RenderLayer.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::computeCompositingRequirements):
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTree):
(WebCore::RenderLayerCompositor::computeCompositingRequirementsForNamedFlowFixed): Deleted.
(WebCore::RenderLayerCompositor::rebuildCompositingLayerTreeForNamedFlowFixed): Deleted.

  • rendering/RenderLayerCompositor.h:
  • rendering/RenderNamedFlowFragment.cpp:

(WebCore::RenderNamedFlowFragment::checkRegionStyle):
(WebCore::RenderNamedFlowFragment::namedFlowThread const): Deleted.

  • rendering/RenderNamedFlowFragment.h:
  • rendering/RenderNamedFlowThread.cpp: Removed.
  • rendering/RenderNamedFlowThread.h: Removed.
  • rendering/RenderObject.cpp:

(WebCore::RenderObject::selectionRoot const):
(WebCore::RenderObject::offsetParent const):
(WebCore::RenderObject::currentRenderNamedFlowFragment const):

  • rendering/RenderObject.h:

(WebCore::RenderObject::isRenderGrid const):
(WebCore::RenderObject::isRenderNamedFlowThread const): Deleted.

  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::attachRegion):

  • rendering/RenderRegion.h:

(WebCore::RenderRegion::parentNamedFlowThread const): Deleted.

  • rendering/RenderTreeAsText.cpp:

(WebCore::writeLayers):
(WebCore::writeRenderRegionList): Deleted.
(WebCore::writeRenderNamedFlowThreads): Deleted.

  • rendering/RenderView.cpp:

(WebCore::RenderView::layoutContent):
(WebCore::RenderView::layoutContentInAutoLogicalHeightRegions):
(WebCore::RenderView::layout):
(WebCore::RenderView::selectionBounds const):
(WebCore::RenderView::repaintSelection const):
(WebCore::RenderView::setSelection):
(WebCore::RenderView::updateSelectionForSubtrees):
(WebCore::RenderView::styleDidChange):
(WebCore::RenderView::checkTwoPassLayoutForAutoHeightRegions const):
(WebCore::RenderView::pushLayoutStateForCurrentFlowThread):
(WebCore::RenderView::popLayoutStateForCurrentFlowThread):
(WebCore::RenderView::layoutContentToComputeOverflowInRegions): Deleted.
(WebCore::RenderView::splitSelectionBetweenSubtrees): Deleted.
(WebCore::RenderView::hasRenderNamedFlowThreads const): Deleted.
(WebCore::RenderView::flowThreadController): Deleted.

  • rendering/RenderView.h:
  • rendering/SelectionSubtreeRoot.cpp:

(WebCore::SelectionSubtreeRoot::adjustForVisibleSelection): Deleted.

  • rendering/SelectionSubtreeRoot.h:

(WebCore::SelectionSubtreeRoot::setSelectionData):

8:30 AM Changeset in webkit [222262] by Ms2ger@igalia.com
  • 3 edits in trunk/LayoutTests

[WPE] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=177233

Unreviewed test gardening.

7:55 AM Changeset in webkit [222261] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Skip failing resource timing tests on Windows.
https://bugs.webkit.org/show_bug.cgi?id=177234

Unreviewed test gardening.

  • platform/win/TestExpectations:
7:38 AM Changeset in webkit [222260] by Ms2ger@igalia.com
  • 2 edits
    1 delete in trunk/Tools

[WPE] Update fontconfig to 2.12.4.
https://bugs.webkit.org/show_bug.cgi?id=177228

Reviewed by Carlos Garcia Campos.

  • wpe/jhbuild.modules:
  • wpe/patches/fontconfig-avoid-conflicts-with-integer-width-macros-from-TS-18.patch: Removed.
5:58 AM Changeset in webkit [222259] by Antti Koivisto
  • 77 edits
    12 deletes in trunk

Remove DOM and styling support for CSS Regions
https://bugs.webkit.org/show_bug.cgi?id=177221

Reviewed by Andreas Kling.

Source/WebCore:

This patch removes all CSS Regions (aka "named flow") related code excluding rendering.

The feature is already disabled so no functional changes.

  • CMakeLists.txt:
  • Configurations/FeatureDefines.xcconfig:
  • DerivedSources.make:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSCSSRuleCustom.cpp:

(WebCore::toJSNewlyCreated):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::contentToCSSValue):
(WebCore::ComputedStyleExtractor::propertyValue):
(WebCore::convertToRegionBreak): Deleted.

  • css/CSSPrimitiveValueMappings.h:

(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator BreakBetween const):

  • css/CSSProperties.json:
  • css/CSSRule.cpp:
  • css/CSSRule.h:
  • css/CSSRule.idl:
  • css/ElementRuleCollector.cpp:

(WebCore::ElementRuleCollector::matchAuthorRules):
(WebCore::ElementRuleCollector::matchUserRules):
(WebCore::ElementRuleCollector::collectMatchingRulesForRegion): Deleted.

  • css/ElementRuleCollector.h:

(WebCore::ElementRuleCollector::setSameOriginOnly):
(WebCore::ElementRuleCollector::setRegionForStyling): Deleted.

  • css/InspectorCSSOMWrappers.cpp:

(WebCore::InspectorCSSOMWrappers::collect):

  • css/RuleSet.cpp:

(WebCore::determinePropertyWhitelistType):
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::addChildRules):
(WebCore::RuleSet::shrinkToFit):
(WebCore::RuleSet::addRegionRule): Deleted.

  • css/RuleSet.h:

(WebCore::RuleSet:: const):
(WebCore::RuleSet::regionSelectorsAndRuleSets const): Deleted.

  • css/StyleBuilderConverter.h:

(WebCore::StyleBuilderConverter::convertRegionBreakBetween): Deleted.
(WebCore::StyleBuilderConverter::convertRegionBreakInside): Deleted.

  • css/StyleProperties.cpp:
  • css/StyleResolver.cpp:

(WebCore::StyleResolver::State::clear):
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::CascadedProperties::addMatch):
(WebCore::StyleResolver::checkRegionStyle): Deleted.
(WebCore::isValidRegionStyleProperty): Deleted.

  • css/StyleResolver.h:

(WebCore::StyleResolver::State::regionForStyling const): Deleted.
(WebCore::checkRegionSelector): Deleted.

  • css/StyleRule.cpp:

(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy const):
(WebCore::StyleRuleBase::createCSSOMWrapper const):
(WebCore::StyleRuleRegion::StyleRuleRegion): Deleted.

  • css/StyleRule.h:

(WebCore::StyleRuleBase::isStyleRule const):
(WebCore::StyleRuleBase::isRegionRule const): Deleted.

  • css/StyleSheetContents.cpp:

(WebCore::traverseSubresourcesInRules):

  • css/WebKitCSSRegionRule.cpp: Removed.
  • css/WebKitCSSRegionRule.h: Removed.
  • css/WebKitCSSRegionRule.idl: Removed.
  • css/parser/CSSAtRuleID.cpp:

(WebCore::cssAtRuleID):

  • css/parser/CSSAtRuleID.h:
  • css/parser/CSSParserFastPaths.cpp:

(WebCore::CSSParserFastPaths::isValidKeywordPropertyAndValue):
(WebCore::CSSParserFastPaths::isKeywordPropertyID):

  • css/parser/CSSParserImpl.cpp:

(WebCore::CSSParserImpl::consumeAtRule):
(WebCore::CSSParserImpl::consumeRegionRule): Deleted.

  • css/parser/CSSParserImpl.h:
  • css/parser/CSSPropertyParser.cpp:

(WebCore::isLegacyBreakProperty):
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::mapFromLegacyBreakProperty):
(WebCore::CSSPropertyParser::consumeLegacyBreakProperty):
(WebCore::consumeFlowProperty): Deleted.
(WebCore::mapFromRegionBreakBetween): Deleted.

  • dom/ContainerNode.cpp:

(WebCore::destroyRenderTreeIfNeeded):

  • dom/DOMNamedFlowCollection.cpp: Removed.
  • dom/DOMNamedFlowCollection.h: Removed.
  • dom/DOMNamedFlowCollection.idl: Removed.
  • dom/Document.cpp:

(WebCore::Document::updateLayoutIfDimensionsOutOfDate):
(WebCore::Document::webkitGetNamedFlows): Deleted.
(WebCore::Document::namedFlows): Deleted.

  • dom/Document.h:
  • dom/Document.idl:
  • dom/Element.cpp:

(WebCore::Element::~Element):
(WebCore::Element::clearStyleDerivedDataBeforeDetachingRenderer):
(WebCore::Element::unregisterNamedFlowContentElement): Deleted.
(WebCore::Element::setIsNamedFlowContentElement): Deleted.
(WebCore::Element::clearIsNamedFlowContentElement): Deleted.
(WebCore::Element::rareDataIsNamedFlowContentElement const): Deleted.
(WebCore::Element::setRegionOversetState): Deleted.
(WebCore::Element::regionOversetState const): Deleted.
(WebCore::Element::renderNamedFlowFragment const): Deleted.
(WebCore::Element::shouldMoveToFlowThread const): Deleted.
(WebCore::Element::webkitRegionOverset const): Deleted.
(WebCore::Element::webkitGetRegionFlowRanges const): Deleted.

  • dom/Element.h:

(WebCore::Element::isNamedFlowContentElement const): Deleted.

  • dom/Element.idl:
  • dom/ElementRareData.cpp:
  • dom/ElementRareData.h:

(WebCore::ElementRareData::ElementRareData):
(WebCore::ElementRareData::regionOversetState const): Deleted.
(WebCore::ElementRareData::setRegionOversetState): Deleted.
(WebCore::ElementRareData::isNamedFlowContentElement const): Deleted.
(WebCore::ElementRareData::setIsNamedFlowContentElement): Deleted.

  • dom/EventTargetFactory.in:
  • dom/NamedFlowCollection.cpp: Removed.
  • dom/NamedFlowCollection.h: Removed.
  • dom/PseudoElement.h:
  • dom/WebKitNamedFlow.cpp: Removed.
  • dom/WebKitNamedFlow.h: Removed.
  • dom/WebKitNamedFlow.idl: Removed.
  • inspector/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::resetNonPersistentData):
(WebCore::ChangeRegionOversetTask::ChangeRegionOversetTask): Deleted.
(WebCore::ChangeRegionOversetTask::scheduleFor): Deleted.
(WebCore::ChangeRegionOversetTask::unschedule): Deleted.
(WebCore::ChangeRegionOversetTask::reset): Deleted.
(WebCore::ChangeRegionOversetTask::timerFired): Deleted.
(WebCore::InspectorCSSAgent::didCreateNamedFlow): Deleted.
(WebCore::InspectorCSSAgent::willRemoveNamedFlow): Deleted.
(WebCore::InspectorCSSAgent::didChangeRegionOverset): Deleted.
(WebCore::InspectorCSSAgent::regionOversetChanged): Deleted.
(WebCore::InspectorCSSAgent::didRegisterNamedFlowContentElement): Deleted.
(WebCore::InspectorCSSAgent::didUnregisterNamedFlowContentElement): Deleted.
(WebCore::InspectorCSSAgent::getNamedFlowCollection): Deleted.
(WebCore::InspectorCSSAgent::documentNodeWithRequestedFlowsId): Deleted.
(WebCore::InspectorCSSAgent::buildArrayForRegions): Deleted.
(WebCore::InspectorCSSAgent::buildObjectForNamedFlow): Deleted.

  • inspector/InspectorCSSAgent.h:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didCreateNamedFlowImpl): Deleted.
(WebCore::InspectorInstrumentation::willRemoveNamedFlowImpl): Deleted.
(WebCore::InspectorInstrumentation::didChangeRegionOversetImpl): Deleted.
(WebCore::InspectorInstrumentation::didRegisterNamedFlowContentElementImpl): Deleted.
(WebCore::InspectorInstrumentation::didUnregisterNamedFlowContentElementImpl): Deleted.

  • inspector/InspectorOverlay.cpp:

(WebCore::buildRendererHighlight):
(WebCore::buildObjectForElementData):
(WebCore::buildObjectForRegion): Deleted.
(WebCore::buildObjectForFlowRegions): Deleted.

  • page/EventHandler.cpp:

(WebCore::handleWheelEventInAppropriateEnclosingBox):

  • rendering/FlowThreadController.cpp:

(WebCore::FlowThreadController::ensureRenderFlowThreadWithName): Deleted.

  • rendering/FlowThreadController.h:
  • rendering/RegionOversetState.h: Removed.
  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::applyBeforeBreak):
(WebCore::RenderBlockFlow::applyAfterBreak):

  • rendering/RenderNamedFlowFragment.cpp:

(WebCore::RenderNamedFlowFragment::getRanges const):
(WebCore::RenderNamedFlowFragment::layoutBlock):
(WebCore::RenderNamedFlowFragment::checkRegionStyle):
(WebCore::RenderNamedFlowFragment::computeStyleInRegion const):
(WebCore::RenderNamedFlowFragment::setRegionObjectsRegionStyle):
(WebCore::RenderNamedFlowFragment::setRegionOversetState): Deleted.
(WebCore::RenderNamedFlowFragment::regionOversetState const): Deleted.
(WebCore::RenderNamedFlowFragment::updateOversetState): Deleted.

  • rendering/RenderNamedFlowFragment.h:
  • rendering/RenderNamedFlowThread.cpp:

(WebCore::RenderNamedFlowThread::RenderNamedFlowThread):
(WebCore::RenderNamedFlowThread::clearContentElements):
(WebCore::RenderNamedFlowThread::registerNamedFlowContentElement):
(WebCore::RenderNamedFlowThread::unregisterNamedFlowContentElement):
(WebCore::RenderNamedFlowThread::hasContentElement const):
(WebCore::RenderNamedFlowThread::flowThreadName const):
(WebCore::RenderNamedFlowThread::dispatchRegionOversetChangeEventIfNeeded):
(WebCore::RenderNamedFlowThread::regionOversetChangeEventTimerFired):
(WebCore::RenderNamedFlowThread::setMarkForDestruction):
(WebCore::RenderNamedFlowThread::resetMarkForDestruction):
(WebCore::RenderNamedFlowThread::isMarkedForDestruction const):
(WebCore::nextNodeInsideContentElement):

  • rendering/RenderNamedFlowThread.h:
  • rendering/RenderRegion.cpp:

(WebCore::RenderRegion::installFlowThread):

  • rendering/style/RenderStyleConstants.h:
  • rendering/style/WillChangeData.cpp:

(WebCore::WillChangeData::propertyCreatesStackingContext):

  • style/RenderTreePosition.cpp:

(WebCore::RenderTreePosition::previousSiblingRenderer const):
(WebCore::RenderTreePosition::nextSiblingRenderer const):
(WebCore::RenderTreePosition::insertionPositionForFlowThread): Deleted.
(WebCore::RenderTreePosition::isRendererReparented): Deleted.

  • style/RenderTreePosition.h:

(WebCore::RenderTreePosition::RenderTreePosition):

  • style/RenderTreeUpdater.cpp:

(WebCore::RenderTreeUpdater::updateElementRenderer):
(WebCore::RenderTreeUpdater::createRenderer):
(WebCore::RenderTreeUpdater::invalidateWhitespaceOnlyTextSiblingsAfterAttachIfNeeded):
(WebCore::registerElementForFlowThreadIfNeeded): Deleted.

  • style/RenderTreeUpdaterGeneratedContent.cpp:

(WebCore::createContentRenderers):

  • style/StyleChange.cpp:

(WebCore::Style::determineChange):

  • style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::styleForElement):
(WebCore::Style::affectsRenderedSubtree):

  • svg/SVGElement.cpp:

(WebCore::SVGElement::shouldMoveToFlowThread const): Deleted.

  • svg/SVGElement.h:

Source/WebCore/PAL:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKit:

  • Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

  • Configurations/FeatureDefines.xcconfig:
  • DOM/DOMCSS.mm:

(kitClass):

  • DOM/DOMElement.mm:

(-[DOMElement webkitRegionOverset]): Deleted.

5:36 AM Changeset in webkit [222258] by Ms2ger@igalia.com
  • 4 edits in trunk/Source/WebCore

Add bindings for optional arguments to some WebGL2 methods.
https://bugs.webkit.org/show_bug.cgi?id=177067

Reviewed by Antti Koivisto.

Add bindings for optional arguments to some WebGL2 methods.

No new tests: not much point in adding tests now; these methods don't
do anything anyway.

  • html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::uniform1uiv):
(WebCore::WebGL2RenderingContext::uniform2uiv):
(WebCore::WebGL2RenderingContext::uniform3uiv):
(WebCore::WebGL2RenderingContext::uniform4uiv):
(WebCore::WebGL2RenderingContext::uniformMatrix2x3fv):
(WebCore::WebGL2RenderingContext::uniformMatrix3x2fv):
(WebCore::WebGL2RenderingContext::uniformMatrix2x4fv):
(WebCore::WebGL2RenderingContext::uniformMatrix4x2fv):
(WebCore::WebGL2RenderingContext::uniformMatrix3x4fv):
(WebCore::WebGL2RenderingContext::uniformMatrix4x3fv):
(WebCore::WebGL2RenderingContext::clearBufferiv):
(WebCore::WebGL2RenderingContext::clearBufferuiv):
(WebCore::WebGL2RenderingContext::clearBufferfv):

  • html/canvas/WebGL2RenderingContext.h:
  • html/canvas/WebGL2RenderingContext.idl:

Sep 19, 2017:

11:40 PM Changeset in webkit [222257] by rniwa@webkit.org
  • 5 edits
    2 adds in trunk

On Mac, dataTransfer claims to contain URL list when dropping files
https://bugs.webkit.org/show_bug.cgi?id=177219

Reviewed by Wenson Hsieh.

Source/WebCore:

Fixed the bug by removing code which was specifically adding local filenames as URLs in "text/uri-list"
when pasting or dropping files. Neither Chrome nor Firefox exhibit this behavior, and exposing local
filenames reveal sensitive information such as username.

Test: editing/pasteboard/datatransfer-types-dropping-text-file.html

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::readString):
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::absoluteURLsFromPasteboard): Deleted.

LayoutTests:

Added a regression test. For now, it only runs on Mac WK1.

  • editing/pasteboard/datatransfer-types-dropping-text-file-expected.txt: Added.
  • editing/pasteboard/datatransfer-types-dropping-text-file.html: Added.
  • platform/ios/TestExpectations:
  • platform/wk2/TestExpectations:
11:32 PM Changeset in webkit [222256] by Carlos Garcia Campos
  • 5 edits in trunk/Source/WebDriver

WebDriver: Implement commands to get and set the window rect
https://bugs.webkit.org/show_bug.cgi?id=177134

Reviewed by Brian Burg.

We are currently implementing the selenium legacy ones, we should implement the w3c ones instead.

https://w3c.github.io/webdriver/webdriver-spec.html#resizing-and-positioning-windows

  • Session.cpp:

(WebDriver::Session::getToplevelBrowsingContextRect): Helper to get the window rect. This is used by both get
and set window rect commands.
(WebDriver::Session::moveToplevelBrowsingContextwindow): Helper to ask automation to move the window.
(WebDriver::Session::resizeToplevelBrowsingContextwindow): Helper to ask automation to resize the window.
(WebDriver::Session::getWindowRect): Handle prompts and then call getToplevelBrowsingContextRect().
(WebDriver::Session::setWindowRect): Handle prompts and then move and resize the window according to the given
parameters and finish the operation calling getToplevelBrowsingContextRect().

  • Session.h:
  • WebDriverService.cpp:

(WebDriver::WebDriverService::getWindowRect): Ask the session to get the window rect.
(WebDriver::valueAsNumberInRange): Helper to check a value is a valid number in the given range.
(WebDriver::WebDriverService::setWindowRect): Get and check size and position from parameters and then ask the
session to set the window rect.

  • WebDriverService.h:
11:29 PM Changeset in webkit [222255] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebDriver

WebDriver: wrong response in case of errors
https://bugs.webkit.org/show_bug.cgi?id=177127

Reviewed by Brian Burg.

I misunderstood the spec when I implemented this, so we either return a "value" key with the result in case of
success or the error object as the body in case of error. We should always add a "value" key to the body and set
it with either the result or the error object.

https://w3c.github.io/webdriver/webdriver-spec.html#dfn-send-an-error

  • WebDriverService.cpp:

(WebDriver::WebDriverService::sendResponse const):

11:16 PM Changeset in webkit [222254] by Simon Fraser
  • 10 edits in trunk

Simplify compositing layer updating
https://bugs.webkit.org/show_bug.cgi?id=176196

Reviewed by Zalan Bujtas.

Source/WebCore:

Remove compositing layer updating from the updateLayerPositions() code path, which
was problematic because it wasn't pre-order. Instead, just rely on post-layout
compositing updates, which now need to do geometry updates. Micro benchmarking shows
this to be no slower.

We can remove the 'OnHitTest' update type, since we always ensure that layout is updated
before hit testing now.

Also remove a code path that could trigger updateGeometry() during a style change, and
in response to images loads, which were bad because layout may not be up-to-date at this time.

Tested by existing compositing tests. Rebaselined two tests after confirming they are progressions.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::hitTestLayer):
(WebCore::RenderLayer::calculateClipRects const):

  • rendering/RenderLayer.h:
  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::updateGeometry):
(WebCore::RenderLayerBacking::contentChanged):
(WebCore::RenderLayerBacking::updateAfterLayout): Deleted.

  • rendering/RenderLayerBacking.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateCompositingLayers):
(WebCore::RenderLayerCompositor::layerStyleChanged):
(WebCore::operator<<):

  • rendering/RenderLayerCompositor.h:

LayoutTests:

New baselines.

  • scrollingcoordinator/ios/sync-layer-positions-after-scroll-expected.txt:
  • tiled-drawing/background-transparency-toggle-expected.txt:
11:13 PM Changeset in webkit [222253] by Simon Fraser
  • 48 edits in trunk/Source

Do more math in terms of FloatSizes and FloatPoints
https://bugs.webkit.org/show_bug.cgi?id=177217

Reviewed by Zalan Bujtas.
Source/WebCore:

Add operator/(const FloatSize&, const FloatSize&), GraphicsContext::translate(const FloatPoint&),
FloatRect.scale(FloatSize) and AffineTransform::translate(const FloatSize&)
and use them in lots of places to do math in terms of points and sizes.

  • html/canvas/CanvasRenderingContext2D.cpp:

(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::fullCanvasCompositedDrawImage):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

  • page/mac/TextIndicatorWindow.mm:

(-[WebTextIndicatorView initWithFrame:textIndicator:margin:offset:]):

  • platform/Theme.cpp:

(WebCore::Theme::drawNamedImage const):

  • platform/graphics/CrossfadeGeneratedImage.cpp:

(WebCore::drawCrossfadeSubimage):
(WebCore::CrossfadeGeneratedImage::draw):

  • platform/graphics/FloatRect.h:

(WebCore::FloatRect::center const):
(WebCore::FloatRect::scale):

  • platform/graphics/FloatSize.h:

(WebCore::operator/):

  • platform/graphics/GradientImage.cpp:

(WebCore::GradientImage::draw):

  • platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::scaleFactorForDrawing const):

  • platform/graphics/GraphicsContext.h:

(WebCore::GraphicsContext::translate):

  • platform/graphics/Image.cpp:

(WebCore::Image::drawTiled):

  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::clampedSize):
(WebCore::ImageBuffer::createCompatibleBuffer):

  • platform/graphics/LayoutSize.h:
  • platform/graphics/NamedImageGeneratedImage.cpp:

(WebCore::NamedImageGeneratedImage::draw):

  • platform/graphics/Path.cpp:

(WebCore::Path::addRoundedRect):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::createCompatibleBuffer):

  • platform/graphics/cg/PDFDocumentImage.cpp:

(WebCore::transformContextForPainting):
(WebCore::applyRotationForPainting):
(WebCore::PDFDocumentImage::drawPDFPage):

  • platform/graphics/filters/FETile.cpp:

(WebCore::FETile::platformApplySoftware):

  • platform/graphics/transforms/AffineTransform.cpp:

(WebCore::AffineTransform::translate):
(WebCore::makeMapBetweenRects):

  • platform/graphics/transforms/AffineTransform.h:
  • platform/mac/ScrollbarThemeMac.mm:

(WebCore::ScrollbarThemeMac::paint):

  • platform/mac/ThemeMac.mm:

(WebCore::paintToggleButton):
(WebCore::paintButton):
(WebCore::paintStepper):

  • rendering/FilterEffectRenderer.cpp:

(WebCore::FilterEffectRendererHelper::beginFilterEffect):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintMaskForTextFillBox):
(WebCore::RenderBoxModelObject::paintBoxShadow):

  • rendering/RenderEmbeddedObject.cpp:

(WebCore::RenderEmbeddedObject::getReplacementTextGeometry const):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::calculateClipRects const):

  • rendering/RenderLayerBacking.cpp:

(WebCore::RenderLayerBacking::paintContents):

  • rendering/RenderLayerCompositor.cpp:

(WebCore::paintScrollbar):
(WebCore::RenderLayerCompositor::paintContents):

  • rendering/RenderMediaControls.cpp:

(WebCore::getUnzoomedRectAndAdjustCurrentContext):

  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintMenuList):
(WebCore::RenderThemeMac::paintSliderThumb):
(WebCore::RenderThemeMac::paintSearchField):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::paintSearchFieldResultsButton):
(WebCore::RenderThemeMac::paintImageControlsButton):

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::RenderSVGForeignObject):
(WebCore::RenderSVGForeignObject::localToParentTransform const):

  • rendering/svg/RenderSVGForeignObject.h:
  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::pathOnlyClipping):
(WebCore::RenderSVGResourceClipper::drawContentIntoMaskImage):
(WebCore::RenderSVGResourceClipper::hitTestClipContent):
(WebCore::RenderSVGResourceClipper::resourceBoundingBox):

  • rendering/svg/RenderSVGResourceGradient.cpp:

(WebCore::clipToTextMask):
(WebCore::RenderSVGResourceGradient::applyResource):

  • rendering/svg/RenderSVGResourceMarker.cpp:

(WebCore::RenderSVGResourceMarker::markerTransformation const):
(WebCore::RenderSVGResourceMarker::markerContentTransformation const):

  • rendering/svg/RenderSVGResourceMasker.cpp:

(WebCore::RenderSVGResourceMasker::drawContentIntoMaskImage):
(WebCore::RenderSVGResourceMasker::resourceBoundingBox):

  • rendering/svg/RenderSVGResourcePattern.cpp:

(WebCore::RenderSVGResourcePattern::buildPattern):
(WebCore::RenderSVGResourcePattern::createTileImage const):

  • rendering/svg/RenderSVGTransformableContainer.cpp:

(WebCore::RenderSVGTransformableContainer::calculateLocalTransform):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::createImageBuffer):
(WebCore::SVGRenderingContext::bufferForeground):

  • svg/SVGAnimateMotionElement.cpp:

(WebCore::SVGAnimateMotionElement::buildTransformForProgress):

  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::localCoordinateSpaceTransform const):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::draw):

Source/WebKit:

Add operator/(const FloatSize&, const FloatSize&), GraphicsContext::translate(const FloatPoint&),
FloatRect.scale(FloatSize) and AffineTransform::translate(const FloatSize&)
and use them in lots of places to do math in terms of points and sizes.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _didCommitLayerTree:]):

  • UIProcess/ios/DragDropInteractionState.mm:

(WebKit::createTargetedDragPreview):

  • WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:

(WebKit::imageForRect):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::renderedImage):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::paintSnapshotAtSize):
(WebKit::WebPage::snapshotNode):

10:36 PM Changeset in webkit [222252] by mmaxfield@apple.com
  • 12 edits
    1 copy in trunk/Tools

WSL should be able to trap when something fatal happens
https://bugs.webkit.org/show_bug.cgi?id=177110

Reviewed by Filip Pizlo.

WSL programs can include a statement "trap;" which causes the entry
point to immediately return the default value of its return type.
This is implemented by throw/catch and populateDefaultValue().

  • WebGPUShadingLanguageRI/All.js:
  • WebGPUShadingLanguageRI/EvaluationCommon.js:
  • WebGPUShadingLanguageRI/Evaluator.js:

(Evaluator.prototype.visitTrapStatement):

  • WebGPUShadingLanguageRI/Parse.js:

(parseStatement):

  • WebGPUShadingLanguageRI/ReturnChecker.js:

(ReturnChecker.prototype.visitTrapStatement):

  • WebGPUShadingLanguageRI/Rewriter.js:

(Rewriter.prototype.visitTrapStatement):

  • WebGPUShadingLanguageRI/StandardLibrary.js:
  • WebGPUShadingLanguageRI/Test.html:
  • WebGPUShadingLanguageRI/Test.js:
  • WebGPUShadingLanguageRI/TrapStatement.js: Copied from Tools/WebGPUShadingLanguageRI/EvaluationCommon.js.

(TrapStatement):
(TrapStatement.prototype.get origin):
(TrapStatement.prototype.toString):

  • WebGPUShadingLanguageRI/Visitor.js:

(Visitor.prototype.visitProtocolDecl):

10:25 PM Changeset in webkit [222251] by Ryan Haddad
  • 2 edits in trunk/Tools

Unreviewed follow-up to r222229, remove invalid triggers.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
10:20 PM Changeset in webkit [222250] by Chris Dumez
  • 16 edits in trunk

IDBRequest and IDBTransaction error properties should be DOMExceptions
https://bugs.webkit.org/show_bug.cgi?id=177201

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

Rebaseline WPT now that it is passing.

  • web-platform-tests/IndexedDB/error-attributes-expected.txt:

Source/WebCore:

IDBRequest and IDBTransaction error properties should be DOMExceptions:

Previously, we used a DOMError type, which is obsolete.

No new tests, rebaselined existing test.

  • Modules/indexeddb/IDBOpenDBRequest.cpp:

(WebCore::IDBOpenDBRequest::onError):
(WebCore::IDBOpenDBRequest::fireErrorAfterVersionChangeCompletion):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore:: const):
(WebCore::IDBRequest::uncaughtExceptionInEventHandler):
(WebCore::IDBRequest::onError):

  • Modules/indexeddb/IDBRequest.h:
  • Modules/indexeddb/IDBRequest.idl:
  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::error const):
(WebCore::IDBTransaction::abortDueToFailedRequest):
(WebCore::IDBTransaction::didCreateIndexOnServer):
(WebCore::IDBTransaction::connectionClosedFromServer):

  • Modules/indexeddb/IDBTransaction.h:
  • Modules/indexeddb/IDBTransaction.idl:
  • Modules/indexeddb/shared/IDBError.cpp:

(WebCore::IDBError::toDOMException const):

  • Modules/indexeddb/shared/IDBError.h:
9:41 PM Changeset in webkit [222249] by commit-queue@webkit.org
  • 7 edits
    60 moves
    7 adds
    1 delete in trunk/LayoutTests

Move non-upstreamed Resource Timing tests out of web-platform-tests
https://bugs.webkit.org/show_bug.cgi?id=177197

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-19
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

  • web-platform-tests/resource-timing/rt-*:

These are not upstream, move them out to http/wpt.

LayoutTests:

  • TestExpectations:
  • platform/gtk/TestExpectations:
  • platform/mac-wk1/TestExpectations:
  • platform/mac/TestExpectations:
  • platform/win/TestExpectations:

Update expectations for path changes.

  • http/wpt/resource-timing/resources/data.json: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/resources/data.json.
  • http/wpt/resource-timing/resources/resource.css: Added.
  • http/wpt/resource-timing/resources/resource.html: Added.
  • http/wpt/resource-timing/resources/resource.js: Added.
  • http/wpt/resource-timing/resources/resource.png: Added.
  • http/wpt/resource-timing/resources/rt-iframe-1.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/resources/rt-iframe-1.html.
  • http/wpt/resource-timing/resources/rt-iframe-2.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/resources/rt-iframe-2.html.
  • http/wpt/resource-timing/resources/rt-module.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/resources/rt-module.js.
  • http/wpt/resource-timing/resources/rt-revalidation-response.py: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/resources/rt-revalidation-response.py.
  • http/wpt/resource-timing/resources/rt-sub-module.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/resources/rt-sub-module.js.
  • http/wpt/resource-timing/resources/rt-utilities.sub.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/resources/rt-utilities.sub.js.
  • http/wpt/resource-timing/resources/rt-worker-resources.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/resources/rt-worker-resources.js.
  • http/wpt/resource-timing/rt-cors-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-cors-expected.txt.
  • http/wpt/resource-timing/rt-cors.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-cors.html.
  • http/wpt/resource-timing/rt-cors.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-cors.js.
  • http/wpt/resource-timing/rt-cors.worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-cors.worker-expected.txt.
  • http/wpt/resource-timing/rt-cors.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-cors.worker.html.
  • http/wpt/resource-timing/rt-cors.worker.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-cors.worker.js.
  • http/wpt/resource-timing/rt-initiatorType-css-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-initiatorType-css-expected.txt.
  • http/wpt/resource-timing/rt-initiatorType-css.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-initiatorType-css.html.
  • http/wpt/resource-timing/rt-initiatorType-element-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-initiatorType-element-expected.txt.
  • http/wpt/resource-timing/rt-initiatorType-element.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-initiatorType-element.html.
  • http/wpt/resource-timing/rt-initiatorType-fetch-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-initiatorType-fetch-expected.txt.
  • http/wpt/resource-timing/rt-initiatorType-fetch.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-initiatorType-fetch.html.
  • http/wpt/resource-timing/rt-initiatorType-fetch.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-initiatorType-fetch.js.
  • http/wpt/resource-timing/rt-initiatorType-media-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-initiatorType-media-expected.txt.
  • http/wpt/resource-timing/rt-initiatorType-media.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-initiatorType-media.html.
  • http/wpt/resource-timing/rt-initiatorType-other-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-initiatorType-other-expected.txt.
  • http/wpt/resource-timing/rt-initiatorType-other.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-initiatorType-other.html.
  • http/wpt/resource-timing/rt-initiatorType-script-module-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-initiatorType-script-module-expected.txt.
  • http/wpt/resource-timing/rt-initiatorType-script-module.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-initiatorType-script-module.html.
  • http/wpt/resource-timing/rt-initiatorType-xmlhttprequest-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-initiatorType-xmlhttprequest-expected.txt.
  • http/wpt/resource-timing/rt-initiatorType-xmlhttprequest.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-initiatorType-xmlhttprequest.html.
  • http/wpt/resource-timing/rt-initiatorType-xmlhttprequest.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-initiatorType-xmlhttprequest.js.
  • http/wpt/resource-timing/rt-initiatorType.worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-initiatorType.worker-expected.txt.
  • http/wpt/resource-timing/rt-initiatorType.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-initiatorType.worker.html.
  • http/wpt/resource-timing/rt-initiatorType.worker.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-initiatorType.worker.js.
  • http/wpt/resource-timing/rt-nextHopProtocol-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-nextHopProtocol-expected.txt.
  • http/wpt/resource-timing/rt-nextHopProtocol.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-nextHopProtocol.html.
  • http/wpt/resource-timing/rt-nextHopProtocol.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-nextHopProtocol.js.
  • http/wpt/resource-timing/rt-nextHopProtocol.worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-nextHopProtocol.worker-expected.txt.
  • http/wpt/resource-timing/rt-nextHopProtocol.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-nextHopProtocol.worker.html.
  • http/wpt/resource-timing/rt-nextHopProtocol.worker.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-nextHopProtocol.worker.js.
  • http/wpt/resource-timing/rt-performance-extensions-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-performance-extensions-expected.txt.
  • http/wpt/resource-timing/rt-performance-extensions.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-performance-extensions.html.
  • http/wpt/resource-timing/rt-performance-extensions.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-performance-extensions.js.
  • http/wpt/resource-timing/rt-performance-extensions.worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-performance-extensions.worker-expected.txt.
  • http/wpt/resource-timing/rt-performance-extensions.worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-performance-extensions.worker.html.
  • http/wpt/resource-timing/rt-performance-extensions.worker.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-performance-extensions.worker.js.
  • http/wpt/resource-timing/rt-resource-errors-expected.txt: Added.
  • http/wpt/resource-timing/rt-resource-errors.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-resource-errors.html.
  • http/wpt/resource-timing/rt-resource-ignored-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-resource-ignored-expected.txt.
  • http/wpt/resource-timing/rt-resource-ignored.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-resource-ignored.html.
  • http/wpt/resource-timing/rt-resources-per-frame-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-resources-per-frame-expected.txt.
  • http/wpt/resource-timing/rt-resources-per-frame.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-resources-per-frame.html.
  • http/wpt/resource-timing/rt-resources-per-worker-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-resources-per-worker-expected.txt.
  • http/wpt/resource-timing/rt-resources-per-worker.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-resources-per-worker.html.
  • http/wpt/resource-timing/rt-revalidate-requests-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-revalidate-requests-expected.txt.
  • http/wpt/resource-timing/rt-revalidate-requests.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-revalidate-requests.html.
  • http/wpt/resource-timing/rt-serialization-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-serialization-expected.txt.
  • http/wpt/resource-timing/rt-serialization.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-serialization.html.
  • http/wpt/resource-timing/rt-shared-resource-in-frames-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-shared-resource-in-frames-expected.txt.
  • http/wpt/resource-timing/rt-shared-resource-in-frames.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-shared-resource-in-frames.html.
  • http/wpt/resource-timing/rt-shared-resource-in-workers-expected.txt: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-shared-resource-in-workers-expected.txt.
  • http/wpt/resource-timing/rt-shared-resource-in-workers.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/resource-timing/rt-shared-resource-in-workers.html.

Move tests and make small modifications to ensure we load "/WebKit/resource-timing"
test resources instead of "/resource-timing" resources (web-platform-tests ones).

9:25 PM Changeset in webkit [222248] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[Curl] Fix r222147
https://bugs.webkit.org/show_bug.cgi?id=177128

Patch by Daewoong Jang <daewoong.jang@naverlabs.com> on 2017-09-19
Reviewed by Alex Christensen.

  • platform/network/curl/CurlSSLHandle.h:
  • platform/network/curl/CurlSSLVerifier.cpp:

(WebCore::CurlSSLVerifier::certVerifyCallback):

  • platform/network/curl/CurlSSLVerifier.h:
9:21 PM WebKitGTK/2.18.x edited by Michael Catanzaro
(diff)
8:46 PM Changeset in webkit [222247] by Simon Fraser
  • 5 edits in trunk

tiled-drawing/tiled-backing-in-window.html fails on Retina displays
https://bugs.webkit.org/show_bug.cgi?id=177113

Reviewed by Tim Horton.

Source/WebKit:

Make m_customDeviceScaleFactor a std::optional<> instead of having the weird "0 is unset"
behavior.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::deviceScaleFactor const):
(WebKit::WebPageProxy::setCustomDeviceScaleFactor):

  • UIProcess/WebPageProxy.h:

Tools:

This test removes the view from the window, and then dumps the layer tree, at which point
some layers would report a contentsScale of 2 on Retina displays.

This occurs because WebKitTestRunner overrides the default device scale factor on NSWindow,
but windowless views fall back to [NSScreen mainScreen].backingScaleFactor (in WebViewImpl::intrinsicDeviceScaleFactor()).

Fix by having PlatformWebView::changeWindowScaleIfNeeded() call -_setOverrideDeviceScaleFactor: on the view.

  • WebKitTestRunner/mac/PlatformWebViewMac.mm:

(WTR::PlatformWebView::changeWindowScaleIfNeeded):

7:40 PM Changeset in webkit [222246] by Simon Fraser
  • 6 edits in trunk/Source/WebCore

Image subclasses should support is<> and downcast<>
https://bugs.webkit.org/show_bug.cgi?id=177209

Reviewed by Tim Horton.

Add SPECIALIZE_TYPE_TRAITS_IMAGE() for Image subclasses.

Also use #pragma once in these headers.

  • platform/graphics/CrossfadeGeneratedImage.h:
  • platform/graphics/GeneratedImage.h:
  • platform/graphics/GradientImage.h:
  • platform/graphics/Image.h:
  • platform/graphics/NamedImageGeneratedImage.h:
7:20 PM Changeset in webkit [222245] by Wenson Hsieh
  • 6 edits
    1 add in trunk

REGRESSION (r215613): Incorrect corners clipping with border-radius
https://bugs.webkit.org/show_bug.cgi?id=176498
<rdar://problem/34112607>

Reviewed by Tim Horton.

Source/WebCore:

http://trac.webkit.org/r215613 introduced an optimization to bail out of repainting borders if the invalidated
rect to paint is fully contained within the inner rounded rect of the border. However, due to issues with
coordinate and intersection math in RoundedRect::contains() and ellipseContainsPoint(), this causes
RenderBoxModelObject::paintBorder to return early even in circumstances where the border requires a repaint.
This patch fixes the contains() helper in RoundedRect and adds a new API test suite for RoundedRect that covers
these changes.

Test: WebCore.RoundedRectContainsRect

  • platform/graphics/GeometryUtilities.cpp:

(WebCore::ellipseContainsPoint):

This function attempts to return early if the Manhattan distance of the transformed point is less than the
radius of the circle that results from applying the same transformation to the ellipse. However, this bails and
returns true if x + y <= R, but this means that if x and y are negative, we'll always end up returning true.
We fix this by adding the absolute values instead, so the check becomes: |x| + |y| <= R.

  • platform/graphics/RoundedRect.cpp:

(WebCore::RoundedRect::contains const):

Before this patch, otherRect's upper left location was being used to hit-test against the ellipses formed from
each of the 4 corners of the rounded rect. Instead, this should use (x, y), (maxX, y), (x, maxY), (maxX, maxY)
for the top left, top right, bottom left, and bottom right corners, respectively.

Additionally, the checks for the bottom left and bottom right to determine whether the rect corner should be
checked for intersection against the ellipse's corner are incorrect. In the bottom left corner, the check for
otherRect.maxX() >= center.x() should instead be otherRect.x() <= center.x(), and the check for
otherRect.x() <= center.x() should instead be otherRect.maxX() >= center.x().

  • platform/graphics/RoundedRect.h:

Tools:

Add WebCore API tests for RoundedRect::contains().

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/RoundedRectTests.cpp: Added.

(TestWebKitAPI::layoutRect):
(TestWebKitAPI::TEST):

7:12 PM Changeset in webkit [222244] by jmarcell@apple.com
  • 4 edits
    2 adds in branches/safari-604-branch

Cherry-pick r222226. rdar://problem/34534758

6:56 PM Changeset in webkit [222243] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Skip fast/images/animated-image-mp4.html on Windows.
https://bugs.webkit.org/show_bug.cgi?id=177216

Unreviewed test gardening.

  • platform/win/TestExpectations:
6:30 PM Changeset in webkit [222242] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Mark accessibility/crash-table-recursive-layout.html as a failure on Windows.
https://bugs.webkit.org/show_bug.cgi?id=177212

Unreviewed test gardening.

  • platform/win/TestExpectations:
6:21 PM Changeset in webkit [222241] by jmarcell@apple.com
  • 4 edits
    2 adds in branches/safari-604-branch

Cherry-pick r222220. rdar://problem/34534766

6:21 PM Changeset in webkit [222240] by jmarcell@apple.com
  • 9 edits
    2 adds in branches/safari-604-branch

Cherry-pick r222214. rdar://problem/34534751

6:20 PM Changeset in webkit [222239] by ap@apple.com
  • 10 edits
    4 adds in trunk/Source

Layering violation in Editor::createFragment
https://bugs.webkit.org/show_bug.cgi?id=176123

Reviewed by Darin Adler.

Source/WebCore:

  • WebCore.xcodeproj/project.pbxproj:
  • editing/cocoa/WebArchiveResourceFromNSAttributedString.h: Added.
  • editing/cocoa/WebArchiveResourceFromNSAttributedString.mm: Added.

Added a wrapper class for ArchiveResource, suitable for use as a WebResourceHandler.

  • editing/cocoa/WebArchiveResourceWebResourceHandler.h: Added.
  • editing/cocoa/WebArchiveResourceWebResourceHandler.mm: Added.

Objects of this class can be passed as "WebResourceHandler", and created instances
of the above class.

  • editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::attributesForAttributedStringConversion):
(WebCore::createFragment):
On newer OS versions, don't use WebKitLegacy to convert NSAttributedString to a
document fragment. We now only use system frameworks to convert the attributed
string to HTML source, and parse HTML into a fragment directly in WebCore.

  • platform/URL.h: Exported fakeURLWithRelativePart.

Source/WebKitLegacy/mac:

  • Misc/WebNSURLExtras.h:
  • Misc/WebNSURLExtras.mm:
  • WebView/WebFrame.mm:
  • WebView/WebHTMLView.mm:

Removed multiple copies of webkit-fake-url creation code, switching to URL::fakeURLWithRelativePart().

  • WebCoreSupport/WebEditorClient.mm:

(_WebCreateFragment): Added a stub implementation for older OSes. This is needed
because WebKitLegacy.exp is not passed through preprocessor, so there is no sane
way to avoid exporting the symbol just on newer OSes.

5:57 PM Changeset in webkit [222238] by commit-queue@webkit.org
  • 7 edits in trunk

Allow WTF::map to use any class that is iterable and has a size getter
https://bugs.webkit.org/show_bug.cgi?id=177026

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-19
Reviewed by Darin Adler.

Source/WebCore:

No change of behavior.
Using WTF::map to go from maps to vectors.

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::resourceList):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::dispatchAllPendingUnloadEvents):

Source/WTF:

Computing the Item type given to the lambda using the iterator instead of ValueType which is specific to Vector.
Adding the possibility to pass a non const container reference and a lambda taking non const references as well.

  • wtf/Vector.h:

(WTF::MapFunctionInspector::acceptsReference):
(WTF::Mapper::map):
(WTF::map):

Tools:

  • TestWebKitAPI/Tests/WTF/Vector.cpp:

(TestWebKitAPI::TEST):

5:37 PM Changeset in webkit [222237] by Alan Bujtas
  • 2 edits in trunk/LayoutTests

Add missing text after r222226.

  • accessibility/crash-table-recursive-layout.html:
5:15 PM Changeset in webkit [222236] by jmarcell@apple.com
  • 6 edits
    3 adds in branches/safari-604-branch

Cherry-pick r221978. rdar://problem/34508522

5:03 PM Changeset in webkit [222235] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-mainframe-vertical-then-horizontal.html as flaky on macOS Debug.
https://bugs.webkit.org/show_bug.cgi?id=171839

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
4:28 PM Changeset in webkit [222234] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Quiet media player private logging
https://bugs.webkit.org/show_bug.cgi?id=177199

Reviewed by Jer Noble.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(-[WebCoreAVFMovieObserver observeValueForKeyPath:ofObject:change:context:]):

4:17 PM Changeset in webkit [222233] by achristensen@apple.com
  • 66 edits in trunk/Source

Allow modern decoding of Vectors
https://bugs.webkit.org/show_bug.cgi?id=177102

Reviewed by Andy Estes.

Source/WebCore:

  • Modules/cache/DOMCacheEngine.h:

(WebCore::DOMCacheEngine::CacheInfos::decode):
(WebCore::DOMCacheEngine::CacheIdentifierOperationResult::decode):

  • Modules/indexeddb/IDBDatabaseIdentifier.cpp:

(WebCore::IDBDatabaseIdentifier::IDBDatabaseIdentifier):

  • Modules/indexeddb/IDBDatabaseIdentifier.h:

(WebCore::IDBDatabaseIdentifier::decode):

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):

  • Modules/indexeddb/IDBGetAllResult.h:

(WebCore::IDBGetAllResult::decode):

  • Modules/indexeddb/IDBGetResult.h:

(WebCore::IDBGetResult::decode):

  • Modules/indexeddb/IDBKeyData.h:

(WebCore::IDBKeyData::decode):

  • Modules/indexeddb/IDBKeyRangeData.h:

(WebCore::IDBKeyRangeData::decode):

  • Modules/indexeddb/IDBValue.h:

(WebCore::IDBValue::decode):

  • Modules/indexeddb/shared/IDBError.h:
  • Modules/indexeddb/shared/IDBIterateCursorData.h:

(WebCore::IDBIterateCursorData::decode):

  • Modules/indexeddb/shared/IDBRequestData.h:

(WebCore::IDBRequestData::decode):

  • Modules/indexeddb/shared/IDBResultData.h:

(WebCore::IDBResultData::decode):

  • page/SecurityOriginData.h:

(WebCore::SecurityOriginData::decode):

  • platform/Cookie.h:

(WebCore::Cookie::decode):

  • platform/mediastream/MediaConstraints.h:

(WebCore::MediaTrackConstraintSetMap::decode):

  • platform/network/FormData.h:

(WebCore::FormDataElement::decode):

  • workers/service/ServiceWorkerJobData.h:

(WebCore::ServiceWorkerJobData::decode):

  • workers/service/ServiceWorkerRegistrationData.h:

(WebCore::ServiceWorkerRegistrationData::decode):

  • workers/service/ServiceWorkerRegistrationKey.h:

(WebCore::ServiceWorkerRegistrationKey::decode):

Source/WebKit:

Rather than allow modern decoding of Vectors of types that only allow legacy decoding,
I just made modern decoders for all types that we need to decode in Vectors.

  • NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::decode):

  • Platform/IPC/ArgumentCoders.cpp:

(IPC::ArgumentCoder<std::chrono::system_clock::time_point>::decode):

  • Platform/IPC/ArgumentCoders.h:
  • Shared/AssistedNodeInformation.cpp:

(WebKit::OptionItem::decode):

  • Shared/AssistedNodeInformation.h:
  • Shared/CallbackID.h:

(WebKit::CallbackID::decode):

  • Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:

(IPC::ArgumentCoder<WebCore::PaymentError>::decode):
(IPC::ArgumentCoder<WebCore::PaymentMethodUpdate>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::LineItem>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::ShippingMethod>::decode):
(IPC::ArgumentCoder<ApplePaySessionPaymentRequest::TotalAndLineItems>::decode):
(IPC::ArgumentCoder<WebCore::ShippingContactUpdate>::decode):
(IPC::ArgumentCoder<WebCore::ShippingMethodUpdate>::decode):

  • Shared/Databases/IndexedDB/WebIDBResult.cpp:

(WebKit::WebIDBResult::decode):

  • Shared/FrameInfoData.cpp:

(WebKit::FrameInfoData::decode):

  • Shared/Gamepad/GamepadData.cpp:

(WebKit::GamepadData::decode):

  • Shared/Gamepad/GamepadData.h:
  • Shared/PlatformPopupMenuData.cpp:

(WebKit::PlatformPopupMenuData::decode):

  • Shared/PlatformPopupMenuData.h:
  • Shared/Plugins/NPIdentifierData.cpp:

(WebKit::NPIdentifierData::decode):

  • Shared/Plugins/NPIdentifierData.h:
  • Shared/Plugins/NPVariantData.cpp:

(WebKit::NPVariantData::decode):

  • Shared/Plugins/NPVariantData.h:
  • Shared/RTCNetwork.cpp:

(WebKit::RTCNetwork::IPAddress::decode):
(WebKit::RTCNetwork::SocketAddress::decode):
(WebKit::RTCNetwork::decode):

  • Shared/RTCNetwork.h:
  • Shared/RemoteLayerTree/RemoteLayerTreeTransaction.h:
  • Shared/RemoteLayerTree/RemoteLayerTreeTransaction.mm:

(WebKit::RemoteLayerTreeTransaction::LayerCreationProperties::decode):
(WebKit::RemoteLayerTreeTransaction::decode):

  • Shared/SessionState.cpp:

(WebKit::HTTPBody::Element::decode):
(WebKit::FrameState::decode):
(WebKit::PageState::decode):
(WebKit::BackForwardListItemState::decode):
(WebKit::BackForwardListState::decode):

  • Shared/SessionState.h:
  • Shared/WebCompiledContentRuleListData.cpp:

(WebKit::WebCompiledContentRuleListData::decode):

  • Shared/WebCompiledContentRuleListData.h:
  • Shared/WebContextMenuItemData.cpp:

(WebKit::WebContextMenuItemData::decode):

  • Shared/WebContextMenuItemData.h:
  • Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<DOMCacheEngine::CacheInfo>::decode):
(IPC::ArgumentCoder<DOMCacheEngine::Record>::decode):
(IPC::ArgumentCoder<FloatRect>::decode):
(IPC::ArgumentCoder<FloatQuad>::decode):
(IPC::ArgumentCoder<IntRect>::decode):
(IPC::ArgumentCoder<RecentSearch>::decode):
(IPC::ArgumentCoder<Region::Span>::decode):
(IPC::ArgumentCoder<MimeClassInfo>::decode):
(IPC::ArgumentCoder<PluginInfo>::decode):
(IPC::ArgumentCoder<SelectionRect>::decode):
(IPC::ArgumentCoder<CompositionUnderline>::decode):
(IPC::ArgumentCoder<DictationAlternative>::decode):
(IPC::ArgumentCoder<GrammarDetail>::decode):
(IPC::ArgumentCoder<TextCheckingResult>::decode):
(IPC::ArgumentCoder<BlobPart>::decode):
(IPC::ArgumentCoder<ResourceLoadStatistics>::decode):
(IPC::ArgumentCoder<MediaConstraints>::decode):
(IPC::ArgumentCoder<CaptureDevice>::decode):
(IPC::ArgumentCoder<ScrollOffsetRange<float>>::decode):
(IPC::ArgumentCoder<MediaSelectionOption>::decode):

  • Shared/WebCoreArgumentCoders.h:
  • Shared/WebEvent.h:
  • Shared/WebPageCreationParameters.cpp:

(WebKit::WebPageCreationParameters::decode):

  • Shared/WebPlatformTouchPoint.cpp:

(WebKit::WebPlatformTouchPoint::decode):

  • Shared/WebPopupItem.cpp:

(WebKit::WebPopupItem::decode):

  • Shared/WebPopupItem.h:
  • Shared/WebUserContentControllerDataTypes.cpp:

(WebKit::WebUserScriptData::decode):
(WebKit::WebUserStyleSheetData::decode):
(WebKit::WebScriptMessageHandlerData::decode):

  • Shared/WebUserContentControllerDataTypes.h:
  • Shared/WebsiteData/WebsiteData.cpp:

(WebKit::WebsiteData::Entry::decode):

  • Shared/WebsiteData/WebsiteData.h:
  • Shared/WebsiteDataStoreParameters.cpp:

(WebKit::WebsiteDataStoreParameters::decode):

  • Shared/ios/WebPlatformTouchPointIOS.cpp:

(WebKit::WebPlatformTouchPoint::decode):

  • Shared/mac/WebCoreArgumentCodersMac.mm:

(IPC::ArgumentCoder<KeypressCommand>::decode):

  • UIProcess/LegacySessionStateCodingNone.cpp:

(WebKit::decodeLegacySessionState):

  • WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.h:
  • WebProcess/WebPage/RemoteLayerTree/PlatformCAAnimationRemote.mm:

(WebKit::PlatformCAAnimationRemote::KeyframeValue::decode):
(WebKit::PlatformCAAnimationRemote::Properties::decode):

4:03 PM October 2017 Meeting edited by Jon Davis
(diff)
3:58 PM October 2017 Meeting edited by Jon Davis
(diff)
3:55 PM October 2017 Meeting edited by Jon Davis
(diff)
3:54 PM October 2017 Meeting edited by Jon Davis
(diff)
3:25 PM Changeset in webkit [222232] by jmarcell@apple.com
  • 4 edits
    2 adds in branches/safari-604-branch

Cherry-pick r222167. rdar://problem/34508525

3:25 PM Changeset in webkit [222231] by jmarcell@apple.com
  • 2 edits in branches/safari-604-branch/Source/WebCore

Cherry-pick r222163. rdar://problem/34508516

3:25 PM Changeset in webkit [222230] by jmarcell@apple.com
  • 8 edits
    2 adds in branches/safari-604-branch

Cherry-pick r222114. rdar://problem/34508510

3:17 PM Changeset in webkit [222229] by Ryan Haddad
  • 9 edits in trunk/Tools

Update bot configuration for iOS 11.
https://bugs.webkit.org/show_bug.cgi?id=177165

Reviewed by Alexey Proskuryakov.

  • BuildSlaveSupport/build.webkit.org-config/config.json:
  • BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:

(BubbleQueueServer):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(table.queue-grid tr.platform.ios-simulator-10 img.logo): Deleted.
(table.queue-grid tr.platform.ios-10 img.logo): Deleted.

  • BuildSlaveSupport/build.webkit.org-config/wkbuild.py:

(_should_file_trigger_build):

  • BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py:

(ShouldBuildTest):
(ShouldBuildTest.test_should_build):

2:50 PM Changeset in webkit [222228] by rniwa@webkit.org
  • 20 edits
    4 adds in trunk

On iOS, getData can't get text set by setData during copy event
https://bugs.webkit.org/show_bug.cgi?id=176980
<rdar://problem/34453915>

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by iOS port not implementing Pasteboard::createPrivate(). Rather than implementing this in iOS,
replace its use for copy & paste events by StaticPasteboard Wenson added for input events. This makes read-write
pasteboard platform agnostic and paves the way to make writing to pasteboard in a single IPC in WebKit2.

Also fixed a bug that iOS port's Pasteboard::types returned the list of all supported types instead of ones
actually present in the pasteboard.

This patch also adds a vector of types to StaticPasteboard to maintain the type order.

Tests: editing/pasteboard/dataTransfer-types-is-initially-empty-on-copy.html

editing/pasteboard/dataTransfer-types-pasting-plaintext.html

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::createForCopyAndPaste): Make StaticPasteboard instead of a private pasteboard.
(WebCore::DataTransfer::createForInputEvent):

  • editing/Editor.cpp:

(WebCore::dispatchClipboardEvent): Call newly added commitToPasteboard on StaticPasteboard.

  • platform/Pasteboard.h:

(WebCore::Pasteboard::isStatic const):

  • platform/PasteboardStrategy.h:
  • platform/StaticPasteboard.cpp:

(WebCore::StaticPasteboard::create): Deleted.
(WebCore::StaticPasteboard::StaticPasteboard):
(WebCore::StaticPasteboard::hasData):
(WebCore::StaticPasteboard::types): Deleted. Now simply returns m_type.
(WebCore::StaticPasteboard::readString): Added.
(WebCore::StaticPasteboard::writeString): Added.
(WebCore::StaticPasteboard::clear): Added.
(WebCore::StaticPasteboard::commitToPasteboard): Added.
(isType): Added.

  • platform/StaticPasteboard.h:

(WebCore::Pasteboard::isStatic const): Added.

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::createPrivate): Deleted.
(WebCore::Pasteboard::writePasteboard): Deleted.

  • platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::createPrivate): Deleted.
(WebCore::Pasteboard::writePasteboard): Deleted.
(WebCore::addHTMLClipboardTypesForCocoaType):
(WebCore::Pasteboard::types): Return the actual list of types in the pasteboard.

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::createPrivate): Deleted.
(WebCore::Pasteboard::writePasteboard): Deleted.

  • platform/win/PasteboardWin.cpp:

(WebCore::Pasteboard::createPrivate): Deleted.
(WebCore::Pasteboard::writePasteboard): Deleted.

  • platform/wpe/PasteboardWPE.cpp:

(WebCore::Pasteboard::createPrivate): Deleted.
(WebCore::Pasteboard::writePasteboard): Deleted.

Source/WebKit:

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::copy): Deleted.

  • WebProcess/WebCoreSupport/WebPlatformStrategies.h:

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebPlatformStrategies.h:
  • WebCoreSupport/WebPlatformStrategies.mm:

(WebPlatformStrategies::copy): Deleted.

LayoutTests:

Added regression tests to make sure dataTransfer.types returns an empty list when writing to a pasteboard (copy),
and doesn't contain image types when pasting plain text. Unfortunately, pasting image does result in plain text
content being present in the pasteboard in the form of URL so we can't test that scenario.

Also removed failing expectations from a number of tests that are now passing on iOS.

  • editing/pasteboard/dataTransfer-types-is-initially-empty-on-copy-expected.txt: Added.
  • editing/pasteboard/dataTransfer-types-is-initially-empty-on-copy.html: Added.
  • editing/pasteboard/dataTransfer-types-pasting-plaintext-expected.txt: Added.
  • editing/pasteboard/dataTransfer-types-pasting-plaintext.html: Added.
  • platform/ios/TestExpectations:
2:47 PM Changeset in webkit [222227] by Dewei Zhu
  • 13 edits
    1 move in trunk/Websites/perf.webkit.org

Use 'owned commit' instead of 'sub commit' whenever refers to a commit owned by another commit.
https://bugs.webkit.org/show_bug.cgi?id=177178

Reviewed by Ryosuke Niwa.

We use both 'owned commit' and 'sub commit' to refer to a commit owned by an another commit. We should use one term instead of two.
Renaming 'subCommit' to 'ownedCommit', 'ownsSubCommit' to 'ownsCommit' and 'sub-commit' to 'owned-commit'.

  • browser-tests/commit-log-viewer-tests.js:
  • public/api/commits.php:
  • public/api/report-commits.php:
  • public/include/commit-log-fetcher.php:
  • public/v3/components/commit-log-viewer.js:

(CommitLogViewer.prototype._renderCommitList):

  • public/v3/components/owned-commit-viewer.js: Renamed from Websites/perf.webkit.org/public/v3/components/sub-commit-viewer.js.

(OwnedCommitViewer):
(OwnedCommitViewer.prototype.didConstructShadowTree):
(OwnedCommitViewer.prototype._toggleVisibility):
(OwnedCommitViewer.prototype.render):
(OwnedCommitViewer.prototype._renderOwnedCommitTable):
(OwnedCommitViewer.htmlTemplate):
(OwnedCommitViewer.cssTemplate):

  • public/v3/index.html:
  • public/v3/models/commit-log.js:

(CommitLog):
(CommitLog.prototype.updateSingleton):
(CommitLog.prototype.ownsCommits):
(CommitLog.prototype.fetchOwnedCommits):
(CommitLog.prototype._buildOwnedCommitMap):
(CommitLog.diffOwnedCommits):
(CommitLog.prototype.ownsSubCommits): Deleted.
(CommitLog.prototype.fetchSubCommits): Deleted.
(CommitLog.prototype._buildSubCommitMap): Deleted.
(CommitLog.diffSubCommits): Deleted.

  • server-tests/api-commits-tests.js:
  • server-tests/api-report-commits-tests.js:
  • server-tests/tools-os-build-fetcher-tests.js:

(return.waitForInvocationPromise.then):
(string_appeared_here.return.waitForInvocationPromise.then):

  • tools/js/os-build-fetcher.js:

(prototype._fetchAvailableBuilds):
(prototype._addOwnedCommitsForBuild):
(prototype._addSubCommitsForBuild): Deleted.

  • unit-tests/commit-log-tests.js:

(return.commit.fetchOwnedCommits.then):
(return.fetchingPromise.then):
(return.commit.fetchSubCommits.then): Deleted.

2:23 PM Changeset in webkit [222226] by Alan Bujtas
  • 4 edits
    2 adds in trunk

AXObjectCache::performDeferredCacheUpdate is called recursively through FrameView::layout.
https://bugs.webkit.org/show_bug.cgi?id=176218
<rdar://problem/34205612>

Reviewed by Simon Fraser.

Source/WebCore:

There are certain cases when we might re-enter performDeferredCacheUpdate through recursive
layout calls (see webkit.org/b/177176) and mutate m_deferredTextChangedList multiple times.

Test: accessibility/crash-table-recursive-layout.html

  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::performDeferredCacheUpdate):

  • accessibility/AXObjectCache.h:

LayoutTests:

  • accessibility/crash-table-recursive-layout-expected.txt: Added.
  • accessibility/crash-table-recursive-layout.html: Added.
2:15 PM Changeset in webkit [222225] by jer.noble@apple.com
  • 23 edits
    5 adds in trunk

[Cocoa] Add an ImageDecoder subclass backed by AVFoundation
https://bugs.webkit.org/show_bug.cgi?id=176825

Reviewed by Eric Carlson.

Source/WebCore:

Add a new concrete subclass of ImageDecoder which uses AVFoundation to parse and decode
image data.

AVFoundation APIs require prior knowledge of the media data's mime type to determine whether
the media data is decodable, so the mime type information must be passed through from the
CachedResource -> CachedImage -> ImageFrameCache -> ImageSource so as to be available when
creating the ImageDecoder:

(Drive-by fix: the createFrameImageAtIndex() method will mutate internal state, so make it
non-const.)

  • loader/cache/CachedImage.h:
  • loader/cache/CachedResource.h:

(WebCore::CachedResource::mimeType const):

  • platform/cf/CoreMediaSoftLink.cpp:
  • platform/cf/CoreMediaSoftLink.h:
  • platform/cocoa/VideoToolboxSoftLink.cpp:
  • platform/cocoa/VideoToolboxSoftLink.h:
  • platform/graphics/Image.cpp:

(WebCore::Image::mimeType const):
(WebCore::Image::expectedContentSize const):

  • platform/graphics/Image.h:
  • platform/graphics/ImageDecoder.cpp:

(WebCore::ImageDecoder::create):

  • platform/graphics/ImageDecoder.h:

(WebCore::ImageDecoder::setExpectedContentSize):

  • platform/graphics/ImageFrameCache.cpp:

(WebCore::ImageFrameCache::mimeType const):

  • platform/graphics/ImageFrameCache.h:
  • platform/graphics/ImageObserver.h:
  • platform/graphics/ImageSource.cpp:

(WebCore::ImageSource::ensureDecoderAvailable):

  • platform/graphics/cg/ImageDecoderCG.cpp:

(WebCore::ImageDecoderCG::createFrameImageAtIndex):

  • platform/graphics/cg/ImageDecoderCG.h:

Add the new class, ImageDecoderAVFObjC:

AVFoundation expects to load all the media data for an AVURLAsset itself. To map between the
provided SharedData and AVURLAsset's requirements, create a delegate object
WebCoreSharedBufferResourceLoaderDelegate, which responds to requests from the AVURLAsset by
extracting data from the SharedData object. Ensure AVURLAsset doesn't load any data outside
this delegate by passing the AVURLAssetReferenceRestrictionsKey /
AVAssetReferenceRestrictionForbidAll key and value in the AVURLAsset creation options.

  • platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.h: Added.

(WebCore::ImageDecoderAVFObjC::create):
(WebCore::ImageDecoderAVFObjC::mimeType const):
(WebCore::ImageDecoderAVFObjC::RotationProperties::isIdentity const):

  • platform/graphics/avfoundation/objc/ImageDecoderAVFObjC.mm: Added.

(SOFT_LINK_CONSTANT):
(-[WebCoreSharedBufferResourceLoaderDelegate initWithParent:]):
(-[WebCoreSharedBufferResourceLoaderDelegate setExpectedContentSize:]):
(-[WebCoreSharedBufferResourceLoaderDelegate updateData:complete:]):
(-[WebCoreSharedBufferResourceLoaderDelegate canFulfillRequest:]):
(-[WebCoreSharedBufferResourceLoaderDelegate enqueueRequest:]):
(-[WebCoreSharedBufferResourceLoaderDelegate fulfillPendingRequests]):
(-[WebCoreSharedBufferResourceLoaderDelegate fulfillRequest:]):
(-[WebCoreSharedBufferResourceLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]):
(-[WebCoreSharedBufferResourceLoaderDelegate resourceLoader:didCancelLoadingRequest:]):
(WebCore::customSchemeURL):
(WebCore::imageDecoderAssetOptions):
(WebCore::transformToRotationProperties):
(WebCore::ImageDecoderAVFObjC::ImageDecoderAVFObjC):
(WebCore::ImageDecoderAVFObjC::canDecodeType):
(WebCore::ImageDecoderAVFObjC::firstEnabledTrack):
(WebCore::ImageDecoderAVFObjC::readSampleMetadata): Parses the media data using AVSampleCursor to walk

the media sample table, extracting frame presentation time, decode time, and duration.

(WebCore::ImageDecoderAVFObjC::readTrackMetadata): Reads the affine transform and size information from

the AVAssetTrack, and transforms the transform into a rotation value.

(WebCore::ImageDecoderAVFObjC::storeSampleBuffer): Decompress the incoming sample data, optionally rotate

the output, and store the results in the sample data vector.

(WebCore::ImageDecoderAVFObjC::advanceCursor): Wrap around the end of the sample table.
(WebCore::ImageDecoderAVFObjC::setTrack): Reset all sample and track metadata.
(WebCore::ImageDecoderAVFObjC::encodedDataStatus const): Retrieve from sample data.
(WebCore::ImageDecoderAVFObjC::frameCount const): Ditto.
(WebCore::ImageDecoderAVFObjC::repetitionCount const): Ditto.
(WebCore::ImageDecoderAVFObjC::uti const): Ditto.
(WebCore::ImageDecoderAVFObjC::filenameExtension const): Ditto.
(WebCore::ImageDecoderAVFObjC::frameSizeAtIndex const): Ditto.
(WebCore::ImageDecoderAVFObjC::frameIsCompleteAtIndex const): Ditto.
(WebCore::ImageDecoderAVFObjC::frameOrientationAtIndex const): Ditto.
(WebCore::ImageDecoderAVFObjC::frameDurationAtIndex const): Ditto.
(WebCore::ImageDecoderAVFObjC::frameHasAlphaAtIndex const): Ditto.
(WebCore::ImageDecoderAVFObjC::frameAllowSubsamplingAtIndex const): Ditto.
(WebCore::ImageDecoderAVFObjC::frameBytesAtIndex const): Ditto.
(WebCore::ImageDecoderAVFObjC::createFrameImageAtIndex): If the sample data has already been

decompressed, return it. Otherwise, walk through the sample table decompressing frames
until the desired frame is decoded.

(WebCore::ImageDecoderAVFObjC::setData):
(WebCore::ImageDecoderAVFObjC::clearFrameBufferCache):

Modify WebCoreDecompressionSession so that it can emit frames which have been converted from
YUV -> RGB as part of the decode operation. Also, add a synchronous decoding operation
method, for use in ImageDecoderAVFObjC.

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::ensureDecompressionSession):

  • platform/graphics/cocoa/WebCoreDecompressionSession.h:

(WebCore::WebCoreDecompressionSession::createOpenGL):
(WebCore::WebCoreDecompressionSession::createRGB):

  • platform/graphics/cocoa/WebCoreDecompressionSession.mm:

(WebCore::WebCoreDecompressionSession::WebCoreDecompressionSession):
(WebCore::WebCoreDecompressionSession::ensureDecompressionSessionForSample):
(WebCore::WebCoreDecompressionSession::decodeSample):
(WebCore::WebCoreDecompressionSession::decodeSampleSync):

Other changes:

  • WebCore.xcodeproj/project.pbxproj: Add new files to project.
  • platform/cocoa/VideoToolboxSoftLink.cpp: Add newly referenced methods.
  • platform/cocoa/VideoToolboxSoftLink.h: Ditto.

Source/WTF:

  • wtf/Platform.h:

LayoutTests:

  • fast/images/animated-image-mp4-expected.txt: Added.
  • fast/images/animated-image-mp4.html: Added.
  • fast/images/resources/animated-red-green-blue.mp4: Added.
  • platform/ios/TestExpectations:
2:11 PM Changeset in webkit [222224] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked imported/w3c/web-platform-tests/background-fetch/interfaces-worker.https.html as flaky on El Capitan Debug.
https://bugs.webkit.org/show_bug.cgi?id=176486

Unreviewed test gardening.

  • platform/mac-wk2/TestExpectations:
1:45 PM Changeset in webkit [222223] by commit-queue@webkit.org
  • 5 edits
    1 add in trunk/Source/WebCore

[Curl] Move Authentication related tasks into AuthenticationChallenge class
https://bugs.webkit.org/show_bug.cgi?id=177105

Currently those codes are in ResourceHandle or related companion. It will
be reused with NetworkLoadTask so that it should be separated from them.

Patch by Basuke Suzuki <Basuke Suzuki> on 2017-09-19
Reviewed by Alex Christensen.

  • platform/Curl.cmake:
  • platform/network/curl/AuthenticationChallenge.h:

(WebCore::AuthenticationChallenge::AuthenticationChallenge): Deleted.
(WebCore::AuthenticationChallenge::authenticationClient const): Deleted.
(WebCore::AuthenticationChallenge::setAuthenticationClient): Deleted.

  • platform/network/curl/AuthenticationChallengeCurl.cpp: Added.

(WebCore::AuthenticationChallenge::AuthenticationChallenge):
(WebCore::AuthenticationChallenge::protectionSpaceServerTypeFromURI):
(WebCore::AuthenticationChallenge::protectionSpaceFromHandle):
(WebCore::AuthenticationChallenge::removeLeadingAndTrailingQuotes):

  • platform/network/curl/ResourceHandleCurlDelegate.cpp:

(WebCore::ResourceHandleCurlDelegate::didReceiveAllHeaders):
(WebCore::ResourceHandleCurlDelegate::didReceiveHeader):
(WebCore::removeLeadingAndTrailingQuotes): Deleted.
(WebCore::ResourceHandleCurlDelegate::getProtectionSpace): Deleted.

  • platform/network/curl/ResourceHandleCurlDelegate.h:
1:42 PM Changeset in webkit [222222] by clopez@igalia.com
  • 4 edits in trunk

[CMake] Add ENABLE_WEB_CRYPTO option and make ENABLE_SUBTLE_CRYPTO depend on it.
https://bugs.webkit.org/show_bug.cgi?id=177180

Reviewed by Michael Catanzaro.

This adds a ENABLE_WEB_CRYPTO flag and makes ENABLE_SUBTLE_CRYPTO depend on it.
The GTK and WPE ports enable them and set ENABLE_WEB_CRYPTO to public.

  • Source/cmake/OptionsGTK.cmake: Set both features to ON and ENABLE_WEB_CRYPTO to public. No change in behaviour for GTK.
  • Source/cmake/OptionsWPE.cmake: Do like on the GTK port. The public flag is now ENABLE_WEB_CRYPTO.
  • Source/cmake/WebKitFeatures.cmake: Add the definition of ENABLE_WEB_CRYPTO and make ENABLE_SUBTLE_CRYPTO depend on it.
1:28 PM Changeset in webkit [222221] by Alan Bujtas
  • 10 edits
    2 adds in trunk

Do not mutate RenderText content during layout.
https://bugs.webkit.org/show_bug.cgi?id=176219
<rdar://problem/34205724>

Reviewed by David Hyatt.

Source/WebCore:

Update combined text when the style/content change as opposed to lazily, during layout.
-content mutation during layout might make the inline tree go out of sync.

Test: fast/text/international/dynamic-text-combine-crash.html

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const):

  • rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):
(WebCore::RenderCombineText::setRenderedText):
(WebCore::RenderCombineText::combineTextIfNeeded):
(WebCore::RenderCombineText::combineText): Deleted.

  • rendering/RenderCombineText.h:
  • rendering/RenderText.h:
  • rendering/line/BreakingContext.h:

(WebCore::BreakingContext::handleText):

  • rendering/line/LineBreaker.cpp:

(WebCore::LineBreaker::skipLeadingWhitespace):

LayoutTests:

  • fast/text/international/dynamic-text-combine-crash.html: Added.
  • fast/text/text-combine-crash-expected.txt:
1:25 PM Changeset in webkit [222220] by Wenson Hsieh
  • 4 edits
    2 adds in trunk

createMarkupInternal should protect its pointer to the Range's common ancestor
https://bugs.webkit.org/show_bug.cgi?id=177033
<rdar://problem/34265390>

Reviewed by Tim Horton.

Source/WebCore:

Adds basic safeguarding to codepaths hit while executing an outdent command.

Test: editing/execCommand/outdent-with-media-query-listener-in-iframe.html

  • editing/IndentOutdentCommand.cpp:

(WebCore::IndentOutdentCommand::outdentRegion):

Avoid an infinite loop if endOfCurrentParagraph is a null position.

  • editing/markup.cpp:

(WebCore::createMarkupInternal):

Protect the raw pointer to the Range's common ancestor node.

LayoutTests:

Adds a test that removes the common ancestor node of a range in the middle of executing an outdent.

  • editing/execCommand/outdent-with-media-query-listener-in-iframe-expected.txt: Added.
  • editing/execCommand/outdent-with-media-query-listener-in-iframe.html: Added.
1:14 PM Changeset in webkit [222219] by Dewei Zhu
  • 15 edits
    1 add in trunk/Websites/perf.webkit.org

Performance Dashboard backend should support A/B testing for owned components.
https://bugs.webkit.org/show_bug.cgi?id=175978

Reviewed by Ryosuke Niwa.

Add backend change for Performance Dashboard to support A/B testing for owned components.
Added 'commitset_commit_owner' and 'commitset_requires_build' columns to 'commit_set_items' table.
'commitset_commit_owner' referrs to determine a commit with owner.
'commitset_requires_build' indicates whether a root build is required.
This will be set true whenever commit_set_item specifies a patch file,
or commit_set_item is commit with owner commit,
or any other commit from same repository and in same build-request group requires build.
SQL for updating existing database:

'BEGIN;

ALTER TABLE commit_set_items ADD COLUMN commitset_commit_owner integer REFERENCES commits DEFAULT NULL, ADD COLUMN commitset_requires_build boolean DEFAULT FALSE;
UPDATE commit_set_items SET commitset_requires_build = TRUE WHERE commitset_patch_file IS NOT NULL;
UPDATE commit_set_items SET commitset_requires_build = TRUE WHERE commitset_set IN (SELECT requests1.request_commit_set FROM build_requests as requests1 JOIN build_requests as requests2 ON requests1.request_group = requests2.request_group JOIN commit_set_items as item ON item.commitset_set = requests2.request_commit_set WHERE item.commitset_patch_file IS NOT NULL);
ALTER TABLE commit_set_items ADD CONSTRAINT commitset_item_with_patch_must_requires_build CHECK (commitset_patch_file IS NULL OR commitset_requires_build = TRUE),

ADD CONSTRAINT commitset_item_with_owned_commit_must_requires_build CHECK (commitset_commit_owner IS NULL OR commitset_requires_build = TRUE);

END;'

  • init-database.sql: Updated 'commit_set_items' table.
  • public/admin/triggerables.php: Only top level repository should show on triggerables page.
  • public/include/build-requests-fetcher.php: Added 'commitOwner' and 'requireBuild' to 'revision_items'. Added 'commitOwner' field to a commit.
  • public/include/db.php: Should be able to insert boolean value to database without explicted convert to 't' or 'f'.
  • public/privileged-api/create-test-group.php:

Added logic to process 'commitOwner' and 'requireBuild' in 'commit_set_items'.
Removed a 'FIXME' that has been addressed before this commit.

  • public/v3/models/build-request.js:

(BuildRequest.constructBuildRequestsFromData): Set 'commitOwner' field for a commit set item.

  • public/v3/models/commit-set.js:

(CommitSet): Added maps for repository to commit owner and whether a repository requires builds.
(CommitSet.prototype.updateSingleton):
(CommitSet.prototype._updateFromObject):
(CommitSet.prototype.ownerRevisionForRepository): Returns owner revision for a given repository in current commit set.
(CommitSet.prototype.requiresBuildForRepository): Returns whether a repository need to build.
(CommitSet.prototype.equals): Equality check should include 2 new maps.
(CustomCommitSet): CustomCommitSet should be able to store commit with an owner commit.
(CustomCommitSet.prototype.setRevisionForRepository): Added each revision list entry should have 'ownerRevision'(null by default).
(CustomCommitSet.prototype.equals): Equality check should also check the equality of 'ownerRevision'.
(CustomCommitSet.prototype.ownerRevisionForRepository): Returns a owner revision for a given repository.

  • public/v3/models/repository.js:

(Repository.prototype.findOwnedRepositoryByName): Return an repository owned by current repository with a given name.

  • public/v3/models/test-group.js: Added 'ownerRevision' field in each entry of revisionSet.
  • server-tests/api-build-requests-tests.js: Added tests.
  • server-tests/privileged-api-create-test-group-tests.js: Added tests.
  • server-tests/privileged-api-upload-file-tests.js: Fix unit tests by setting'requires_build' field to be true when updating commit_set_item which has a patch..
  • server-tests/resources/mock-data.js: Added mock build requests with commit sets contain owned commits.

(MockData.jscRepositoryId): Returns id for JavaScriptsCore repository.
(MockData.addMockConfiguration): Added mock JavaScriptCore and owned JavaScriptCore repositories and commits associated with them.
(MockData.ownedJSCRepositoryId): Added a JavaScriptCore repository with WebKit as owner.
(MockData.addMockConfiguration): Added mock data for test cases those require a commit with a owner commit.
(MockData.addTestGroupWithOwnedCommits): Added mock data for analysis tasks, the build requires of which contains owned commits.
(MockData.set addAnotherTriggerable): Added another triggerable which has mac, webkit and javascript core repositories as triggerable repository group.
(MockData.set addAnotherMockTestGroup): Added another mock test group.

  • tools/js/v3-models.js: Import CustomCommitSet.
  • unit-tests/resources/mock-v3-models.js: Added an owned webkit repository.
  • unit-tests/commit-set-tests.js: Added unit tests CustomCommitSet.
1:09 PM Changeset in webkit [222218] by Ryan Haddad
  • 10 edits
    2 deletes in trunk

Unreviewed, rolling out r222217 and r222214.
This change introduced two LayoutTest failures.
https://bugs.webkit.org/show_bug.cgi?id=177026

Source/WebCore:

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const):

  • rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):
(WebCore::RenderCombineText::setRenderedText):
(WebCore::RenderCombineText::combineText):
(WebCore::RenderCombineText::combineTextIfNeeded): Deleted.

  • rendering/RenderCombineText.h:
  • rendering/RenderText.cpp:
  • rendering/RenderText.h:
  • rendering/line/BreakingContext.h:

(WebCore::BreakingContext::handleText):

  • rendering/line/LineBreaker.cpp:

(WebCore::LineBreaker::skipLeadingWhitespace):

LayoutTests:

  • fast/text/international/dynamic-text-combine-crash-expected.txt: Removed.
  • fast/text/international/dynamic-text-combine-crash.html: Removed.
  • fast/text/text-combine-crash-expected.txt:
12:32 PM Changeset in webkit [222217] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

Attempt to fix Linux build.

  • rendering/RenderText.cpp:
11:46 AM Changeset in webkit [222216] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Adopt named groups in complex regexes
https://bugs.webkit.org/show_bug.cgi?id=177117

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-19
Reviewed by Matt Baker.

  • UserInterface/Base/URLUtilities.js:

(parseSecurityOrigin):
(parseDataURL):
(parseURL):

  • UserInterface/Models/Color.js:

(WI.Color.fromString):

11:28 AM Changeset in webkit [222215] by fpizlo@apple.com
  • 7 edits in trunk/Tools

Primitive protocol should have capital name
https://bugs.webkit.org/show_bug.cgi?id=177097

Reviewed by JF Bastien.

As soon as I started programming in WSL, I found that I preferred to capitalize protocol names. So, my
early decision to call the primitive protocol "primitive" instead of "Primitive" seems absurd now. This
change reverses that decision.

Aesthetically, this is a slight improvement. For example:

struct Bar<T:Primitive> {

Foo<device T> f;

}

This makes more sense since all of the non-keyword type identifiers are capital.

The one place where this is an aesthetic regression is native primitive typedefs, which now look like:

native Primitive typedef bool;


I'm happy with that tradeoff, since native typedefs are only in the standard library. Users don't see
this.

  • WebGPUShadingLanguageRI/AddressSpace.js:

(protocolSuffix):

  • WebGPUShadingLanguageRI/Intrinsics.js:

(Intrinsics):

  • WebGPUShadingLanguageRI/NativeType.js:

(NativeType.prototype.toString):
(NativeType):

  • WebGPUShadingLanguageRI/Parse.js:

(parseNative):

  • WebGPUShadingLanguageRI/StandardLibrary.js:
  • WebGPUShadingLanguageRI/Test.js:

(TEST_passNullAndNotNullFullPoly):
(TEST_passNullAndNotNullFullPolyReverse):

11:07 AM Changeset in webkit [222214] by Alan Bujtas
  • 9 edits
    2 adds in trunk

Do not mutate RenderText content during layout.
https://bugs.webkit.org/show_bug.cgi?id=176219
<rdar://problem/34205724>

Reviewed by David Hyatt.

Source/WebCore:

Update combined text when the style/content change as opposed to lazily, during layout.
-content mutation during layout might make the inline tree go out of sync.

Test: fast/text/international/dynamic-text-combine-crash.html

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::computeInlinePreferredLogicalWidths const):

  • rendering/RenderCombineText.cpp:

(WebCore::RenderCombineText::styleDidChange):
(WebCore::RenderCombineText::setRenderedText):
(WebCore::RenderCombineText::combineTextIfNeeded):
(WebCore::RenderCombineText::combineText): Deleted.

  • rendering/RenderCombineText.h:
  • rendering/RenderText.h:
  • rendering/line/BreakingContext.h:

(WebCore::BreakingContext::handleText):

  • rendering/line/LineBreaker.cpp:

(WebCore::LineBreaker::skipLeadingWhitespace):

LayoutTests:

  • fast/text/international/dynamic-text-combine-crash.html: Added.
  • fast/text/text-combine-crash-expected.txt:
10:56 AM Changeset in webkit [222213] by Matt Lewis
  • 2 edits in trunk/LayoutTests

Marked http/tests/websocket/tests/hybi/handshake-ok-with-legacy-websocket-response-headers.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=176240

Unreviewed test gardening.

  • platform/ios-wk2/TestExpectations:
10:45 AM Changeset in webkit [222212] by achristensen@apple.com
  • 3 edits in trunk/Source/WebKit

Expose WKPageRef as a private property on WKWebView on Mac
https://bugs.webkit.org/show_bug.cgi?id=177022
<rdar://problem/34342762>

Reviewed by Andy Estes.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _pageRefForTransitionToWKWebView]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
10:41 AM Changeset in webkit [222211] by achristensen@apple.com
  • 4 edits in trunk/Source/WebKit

Make _WKProcessPoolConfiguration.allowsCellularAccess actually work on iOS
https://bugs.webkit.org/show_bug.cgi?id=177124

Reviewed by Andy Estes.

The boolean added in r213747 was getting lost in two places:

  1. The API::ProcessPoolConfiguration gets copied before it's used, so we need to set the bool on the copy.
  2. The bool was not getting copied from that ProcessPoolConfiguration to the NetworkProcessCreationParameters

to be sent to the NetworkProcess to be given to the NSURLSessionConfiguration in NetworkSessionCocoa.mm.

These two problems were fixed and verified manually with a customized iOS app on my phone.
Unfortunately, this cannot be tested well with our current test infrastructure.

  • UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):

9:38 AM Changeset in webkit [222210] by fpizlo@apple.com
  • 5 edits in trunk/Tools

Cannot put typedefs of templated structs inside structs
https://bugs.webkit.org/show_bug.cgi?id=177123

Reviewed by Michael Saboff.

Ever since I wrote the generic type instantiation code in WSL, it had a bizarre stink to it. I
did not know what it was, until I met this test case:

struct Foo { int2 x; }


The problem was that Type has a getter called instantiatedType, which invoked
InstantiateImmediates. That's great. Where we went wrong was that TypeRef overrode
instantiatedType, and then InstantiateImmediates called TypeRef.instantiatedType from its
visitTypeRef. What a mess. None of that was necessary for anything, and it was just wrong. This
patch fixes it so that:

  • Type has an instantiatedType getter, which does InstantiateImmediates. I didn't change this. This was the only part of the status quo that really made sense.


  • TypeRef no longer overrides instantiatedType.


  • InstantianteImmediates.prototype.visitTypeRef now does what TypeRef's instantiatedType would have done.


And voila! This test case passes and so do all of the other test cases.

The reason why that specific test case did not work was that the use of a TypeDef (int2) for
a generic type instantiation (vec2<int>) caused there to be two TypeRef's in a row, sorta like
this, if we could use wrap() to denote a TypeRef that just wrapped another type:

wrap(vec2<int>)


We would call instantiatedType on this monstrosity. Since TypeRef overrode instantiatedType,
we would stop there because that TypeRef has no type arguments - it's just a wrapper. Well,
actually, we'd do something a bit stranger than stopping there - there's more to the story -
but the effect was the same. Now we do InstantiateImmediates, which recursively builds a new
type. This chews through the wrapper and then instantiates the wrapped type, as we want it to.
Also, this approach no longer has the stink. instantiatedType isn't overriden by anyone
anymore!

  • WebGPUShadingLanguageRI/Checker.js:
  • WebGPUShadingLanguageRI/InstantiateImmediates.js:

(InstantiateImmediates.prototype.visitTypeRef):
(InstantiateImmediates.prototype.visitReferenceType): Deleted.

  • WebGPUShadingLanguageRI/Test.js:

(TEST_instantiateStructInStructWithInt2):

  • WebGPUShadingLanguageRI/TypeRef.js:

(TypeRef.wrap):
(TypeRef.prototype.setTypeAndArguments):
(TypeRef.prototype.toString):
(TypeRef):
(TypeRef.prototype.get instantiatedType): Deleted.

9:03 AM Changeset in webkit [222209] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

REGRESSION(r214494): Web Inspector: Ignore cache button does not work in Network tab
https://bugs.webkit.org/show_bug.cgi?id=177114
<rdar://problem/34505265>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2017-09-19
Reviewed by Brian Burg.

  • UserInterface/Base/Main.js:

(WI.loaded):
We need to register the settings change handler regardless of what the
initial value of the setting is.

8:53 AM Changeset in webkit [222208] by commit-queue@webkit.org
  • 4 edits in trunk/LayoutTests

webrtc/video-rotation.html is failing and now occasionally times out.
https://bugs.webkit.org/show_bug.cgi?id=175305

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-19
Reviewed by Alex Christensen.

  • TestExpectations: Marking test as passing.
  • webrtc/video-rotation-expected.txt:
  • webrtc/video-rotation.html: Removing unneded subtest. Purpose of the test is checking that rotation change video size.
8:51 AM Changeset in webkit [222207] by commit-queue@webkit.org
  • 3 edits in trunk/LayoutTests

LayoutTest webrtc/video-getParameters.html is failing
https://bugs.webkit.org/show_bug.cgi?id=170148

Patch by Youenn Fablet <youenn@apple.com> on 2017-09-19
Reviewed by Alex Christensen.

  • TestExpectations: Marking test as passing.
  • webrtc/video-getParameters.html: Further sanitizing parameters against changes.
8:00 AM Changeset in webkit [222206] by pvollan@apple.com
  • 2 edits in trunk/Tools

[Win] WebKit fails to build with 64-bit Perl.
https://bugs.webkit.org/show_bug.cgi?id=177106

Reviewed by Brent Fulgham.

Visual Studio is installed in the 32-bit program files folder.

  • Scripts/webkitdirs.pm:

(programFilesPathX86):
(visualStudioInstallDir):
(msBuildInstallDir):

2:00 AM Changeset in webkit [222205] by nael.ouedraogo@crf.canon.fr
  • 6 edits
    1 add in trunk

[GTK] The binding code of Media Source Extension of AudioTrack, VideoTrack and TextTrack is not generated
https://bugs.webkit.org/show_bug.cgi?id=174620

Reviewed by Michael Catanzaro.

LayoutTests/imported/w3c:

Fix WPT test that checks MSE interfaces. This test failed since webm is not supported for MSE in GTK port.
Already merged in WPT repository (https://github.com/w3c/web-platform-tests/pull/6531).

  • web-platform-tests/media-source/interfaces.html:

Source/WebCore:

Add AudioTrackMediaSource, VideoTrackMediaSource and TextTrackMediaSource IDL files in CMakeLists. Fix WPT test
that checks MSE interfaces. This test failed since webm is not supported for MSE in GTK port. PR already merged
in WPT repository.

Remove skipped test that is now passing in TestExpectation. Modify expected file for GTK (same as mac).

  • CMakeLists.txt:

LayoutTests:

Add AudioTrackMediaSource, VideoTrackMediaSource and TextTrackMediaSource IDL files in CMakeLists. Fix WPT test
that checks MSE interfaces. This test failed since webm is not supported for MSE in GTK port. PR already merged
in WPT repository.

Remove skipped test that is now passing in TestExpectation. Modify expected file for GTK (same as mac).

  • platform/gtk/TestExpectations:
  • platform/gtk/imported/w3c/web-platform-tests/media-source/interfaces-expected.txt: Added.
Note: See TracTimeline for information about the timeline view.