Timeline



May 14, 2018:

10:35 PM Changeset in webkit [231789] by youenn@apple.com
  • 13 edits in trunk

readableStreamDefaultControllerError should return early if stream is not readable
https://bugs.webkit.org/show_bug.cgi?id=185602

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/streams/readable-streams/bad-underlying-sources-expected.txt:
  • web-platform-tests/streams/readable-streams/bad-underlying-sources.dedicatedworker-expected.txt:
  • web-platform-tests/streams/readable-streams/bad-underlying-sources.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/garbage-collection-expected.txt:
  • web-platform-tests/streams/readable-streams/garbage-collection.dedicatedworker-expected.txt:
  • web-platform-tests/streams/readable-streams/garbage-collection.serviceworker.https-expected.txt:
  • web-platform-tests/streams/readable-streams/tee-expected.txt:

Source/WebCore:

Return early if stream is not readable in @readableStreamDefaultControllerError.
Update call sites to no longer check for ReadableStream state.
Covered by unflaked and rebased tests.

  • Modules/streams/ReadableStreamDefaultController.js:

(error):

  • Modules/streams/ReadableStreamInternals.js:

(readableStreamDefaultControllerError):
(readableStreamDefaultControllerCallPullIfNeeded):

LayoutTests:

10:31 PM Changeset in webkit [231788] by youenn@apple.com
  • 4 edits in trunk/LayoutTests

imported/w3c/web-platform-tests/fetch/api/response/response-stream-disturbed-6.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=185549

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Catch any potential rejected promise.

  • web-platform-tests/fetch/api/response/response-stream-disturbed-6.html:

LayoutTests:

10:27 PM Changeset in webkit [231787] by keith_miller@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Remove butterflyMask from DFGAbstractHeap
https://bugs.webkit.org/show_bug.cgi?id=185640

Reviewed by Saam Barati.

We don't have a butterfly indexing mask anymore so we don't need
the abstract heap information for it anymore.

  • dfg/DFGAbstractHeap.h:
  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

10:23 PM Changeset in webkit [231786] by Alan Bujtas
  • 7 edits in trunk/Source/WebCore

[LFC] Implement width computation for non-replaced block level inflow elements.
https://bugs.webkit.org/show_bug.cgi?id=185641

Reviewed by Sam Weinig.

Block level inflow elements participate in block formatting context.

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeWidth const):

  • layout/FormattingContext.h:
  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeInFlowWidth const):

  • layout/blockformatting/BlockFormattingContext.h:
  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeInFlowWidth const):

  • layout/inlineformatting/InlineFormattingContext.h:
8:09 PM Changeset in webkit [231785] by beidson@apple.com
  • 8 edits
    2 adds in trunk

Add an API test to guard against regressions while re-entering setDefersLoading:.
<rdar://problem/37033737> and https://bugs.webkit.org/show_bug.cgi?id=185630

Reviewed by Chris Dumez.

Source/WebKit:

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setDefersLoadingForTesting:]):

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::setDefersLoadingForTesting):

  • UIProcess/WebPageProxy.h:
  • WebProcess/WebPage/WebPage.messages.in:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoading.mm: Added.

(-[DoubleDefersNavigationDelegate _webView:navigation:didSameDocumentNavigation:]):
(-[DoubleDefersNavigationDelegate webView:didFinishNavigation:]):
(-[DefersScheme initWithBytes:]):
(-[DefersScheme webView:startURLSchemeTask:]):
(-[DefersScheme webView:stopURLSchemeTask:]):

  • TestWebKitAPI/Tests/WebKitCocoa/DoubleDefersLoadingPlugin.mm: Added.

(-[DoubleDefersLoadingPlugIn webProcessPlugIn:didCreateBrowserContextController:]):
(-[DoubleDefersLoadingPlugIn webProcessPlugInBrowserContextController:didSameDocumentNavigation:forFrame:]):
(-[DoubleDefersLoadingPlugIn dealloc]):

8:00 PM Changeset in webkit [231784] by Wenson Hsieh
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix the iOS build after r231779

Also address a minor in-person review comment by returning "extrazoom" instead of the empty string.

  • page/DisabledAdaptations.cpp:

(WebCore::extraZoomModeAdaptationName):

7:24 PM Changeset in webkit [231783] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

Use the system font by default in extra zoom mode
https://bugs.webkit.org/show_bug.cgi?id=185638
<rdar://problem/40230277>

Reviewed by Wenson Hsieh.

  • Shared/WebPreferencesDefaultValues.h:
6:52 PM Changeset in webkit [231782] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas: Remove unused --value-visual-highlight CSS variable
https://bugs.webkit.org/show_bug.cgi?id=185636

Reviewed by Matt Baker.

  • UserInterface/Views/Variables.css:

(:root):

6:44 PM Changeset in webkit [231781] by Michael Catanzaro
  • 2 edits in trunk/Source/WebKit

Unreviewed, rolling out r231755.

Change is not correct

Reverted changeset:

"-Wmemset-elt-size warning in LibWebRTCSocket constructor"
https://bugs.webkit.org/show_bug.cgi?id=185555
https://trac.webkit.org/changeset/231755

6:31 PM Changeset in webkit [231780] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC] FormattingContext:computeOutOfFlowNonReplacedHeight/Width should use the computed margins/paddings/borders
https://bugs.webkit.org/show_bug.cgi?id=185633

Reviewed by Sam Weinig.

By the time we start computing height and width, DisplayBox should already have the computed values for margin/padding/border.

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowNonReplacedHeight const):
(WebCore::Layout::FormattingContext::computeOutOfFlowNonReplacedWidth const):

  • layout/displaytree/DisplayBox.h:

(WebCore::Display::Box::paddingTop const):
(WebCore::Display::Box::paddingLeft const):
(WebCore::Display::Box::paddingBottom const):
(WebCore::Display::Box::paddingRight const):
(WebCore::Display::Box::borderTop const):
(WebCore::Display::Box::borderLeft const):
(WebCore::Display::Box::borderBottom const):
(WebCore::Display::Box::borderRight const):

6:07 PM Changeset in webkit [231779] by Wenson Hsieh
  • 33 edits
    2 copies
    1 add
    1 delete in trunk

[Extra zoom mode] Google search results are excessively zoomed in
https://bugs.webkit.org/show_bug.cgi?id=185347
<rdar://problem/39999778>

Reviewed by Tim Horton.

Source/WebCore:

It turns out that basing minimum layout size and shrink-to-fit behaviors off of the shrink-to-fit viewport
argument poses compatibility risks with web pages that already specify shrink-to-fit to opt out of default
viewport shrinking behaviors in 1/3 multitasking mode on iPad.

One way to resolve this is to introduce a new viewport meta content attribute to disable viewport heuristics in
extra zoom mode. However, combined shrink-to-fit and minimum device width behaviors are difficult to describe
using a single backwards-compatible viewport meta content attribute, and the need to suppress the default
behavior of shrink-to-fit=no if such an attribute is not disabled further muddles our viewport story.

After some internal deliberation, we’ve decided to experiment with a new meta tag named "disabled-adaptations".
The content of this meta tag is a comma-separated list of adaptation names; if an adaptation name matches a
known adaptation type (for instance, extra zoom mode), we disable the class of behaviors used to adapt web
content. The first and only known adaptation type is extra zoom mode, which affects shrink-to-fit and layout
size adjustments.

See per-method changes below for more details.

Test: fast/viewport/extrazoom/viewport-disable-extra-zoom-adaptations.html

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • dom/Document.cpp:

(WebCore::Document::processDisabledAdaptations):

  • dom/Document.h:

(WebCore::Document::disabledAdaptations const):

Add disabled adaptations to Document. Changes to disabled adaptations are not propagated if the parsed disabled
adaptation types don't change; upon changing adaptation types, notify the client to adjust for the new disabled
adaptations (currently, this only affects the viewport configuration).

  • dom/ViewportArguments.h:
  • html/HTMLMetaElement.cpp:

(WebCore::HTMLMetaElement::process):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::StartTagScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::commitProvisionalLoad):

Restore the set of disabled adaptations when restoring a page from the cache.

  • page/Chrome.cpp:

(WebCore::Chrome::dispatchDisabledAdaptationsDidChange const):

  • page/Chrome.h:
  • page/ChromeClient.h:

Add plumbing for changes to the set of disabled adaptations.

  • page/DisabledAdaptations.cpp: Added.

(WebCore::extraZoomModeAdaptationName):

  • page/DisabledAdaptations.h: Added.

Introduce a header containing a new enum for the extra zoom mode adaptation, as well as a helper function to
return the extra zoom mode adaptation name.

  • page/Page.cpp:

(WebCore::Page::disabledAdaptations const):

Returns the mainframe's set of adaptations to disable.

  • page/Page.h:
  • page/RemoteFrame.h:
  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setDisabledAdaptationsMetaTagEnabled):
(WebCore::RuntimeEnabledFeatures::disabledAdaptationsMetaTagEnabled const):

Add a new runtime feature to gate handling the "disabled-adaptations" meta tag.

  • page/ViewportConfiguration.cpp:

(WebCore::shouldOverrideShrinkToFitArgument):
(WebCore::needsUpdateAfterChangingDisabledAdaptations):
(WebCore::ViewportConfiguration::setDisabledAdaptations):
(WebCore::ViewportConfiguration::shouldOverrideDeviceWidthAndShrinkToFit const):

Consult whether or not extra zoom mode adaptations are disabled, instead of the shrink-to-fit attribute value.

(WebCore::ViewportConfiguration::updateConfiguration):

  • page/ViewportConfiguration.h:

Add an OptionSet of disabled adaptation types to ViewportConfiguration. Updates to the adaptation type are
propagated to the ViewportConfiguration from Document, through the ChromeClient and the client layer (refer to
changes in WebKit). Once the OptionSet is changed, we recompute the viewport configuration only if needed by the
platform.

(WebCore::ViewportConfiguration::viewLayoutSize const):
(WebCore::ViewportConfiguration::disabledAdaptations const):

  • page/WindowFeatures.cpp:

(WebCore::parseDisabledAdaptations):

  • page/WindowFeatures.h:

Add a new helper to parse the meta content of a "disabled-adaptations" tag as an OptionSet of disabled
adaptation types. The string is parsed by first splitting on the comma character, and then iterating over lower
case, whitespace-stripped tokens to look for known adaptation names. So far, only extra zoom mode is supported.

  • testing/Internals.cpp:

(WebCore::Internals::extraZoomModeAdaptationName const):

  • testing/Internals.h:
  • testing/Internals.idl:

Expose the extra zoom mode adaptation name to the DOM, only when running layout tests.

Source/WebKit:

Adds a new experimental feature for the "disabled-adaptations" meta tag, and adds plumbing in WebKit to
propagate disabled adaptation changes to the ViewportConfiguration. The experimental feature is on by default in
extra zoom mode.

  • Shared/WebPreferences.yaml:
  • Shared/WebPreferencesDefaultValues.h:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::dispatchDisabledAdaptationsDidChange const):

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::disabledAdaptationsDidChange):

  • WebProcess/WebPage/WebPage.h:

Source/WebKitLegacy/ios:

Adds a WebKitLegacy method stub for disabled adaptation plumbing.

  • WebCoreSupport/WebChromeClientIOS.h:
  • WebCoreSupport/WebChromeClientIOS.mm:

(WebChromeClientIOS::dispatchDisabledAdaptationsDidChange const):

LayoutTests:

Refactor an existing layout test to exercise disabled adaptations in extra zoom mode.

  • fast/viewport/extrazoom/viewport-change-min-device-width.html: Removed.
  • fast/viewport/extrazoom/viewport-disable-extra-zoom-adaptations.html: Added.
5:32 PM Changeset in webkit [231778] by jdiggs@igalia.com
  • 10 edits
    2 adds in trunk

AX: Listbox and Combobox roles embedded in labels should participate in name calculation
https://bugs.webkit.org/show_bug.cgi?id=185521

Reviewed by Chris Fleizach.

Source/WebCore:

Take selected children into account when computing the name in accessibleNameForNode.
Add ListBox to the roles for which accessibleNameDerivesFromContent returns false so
that native select elements with size > 1 are treated the same way as ARIA listbox.
Also add ListBox to the roles which are treated as controls when used in ARIA. Finally,
prevent labels which contain unrelated controls from being used as an AXTitleUIElement.
This causes us to build a string from the label and its descendants, ensuring the latter
participate in the name calculation.

Test: accessibility/text-alternative-calculation-from-listbox.html

  • accessibility/AccessibilityLabel.cpp:

(WebCore::childrenContainUnrelatedControls):
(WebCore::AccessibilityLabel::containsUnrelatedControls const):

  • accessibility/AccessibilityLabel.h:
  • accessibility/AccessibilityNodeObject.cpp:

(WebCore::accessibleNameForNode):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::accessibleNameDerivesFromContent const):
(WebCore::AccessibilityObject::isARIAControl):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::exposesTitleUIElement const):
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored const):

LayoutTests:

  • accessibility/label-with-pseudo-elements-expected.txt: Updated for new behavior.
  • accessibility/text-alternative-calculation-from-listbox-expected.txt: Added.
  • accessibility/text-alternative-calculation-from-listbox.html: Added.
  • platform/mac/accessibility/label-with-pseudo-elements-expected.txt: Updated for new behavior.
  • platform/win/accessibility/label-with-pseudo-elements-expected.txt: Updated for new behavior.
4:34 PM Changeset in webkit [231777] by dbates@webkit.org
  • 2 edits in trunk/Source/WebKitLegacy/mac

Fix the Apple Internal build

See <rdar://problem/40237873> for more details.

  • WebView/WebFullScreenController.mm:

(-[WebFullScreenController enterFullScreen:]):
(-[WebFullScreenController finishedEnterFullScreenAnimation:]):
(-[WebFullScreenController exitFullScreen]):
(-[WebFullScreenController finishedExitFullScreenAnimation:]):
(-[WebFullScreenController _startEnterFullScreenAnimationWithDuration:]):
(-[WebFullScreenController _startExitFullScreenAnimationWithDuration:]):

4:19 PM Changeset in webkit [231776] by dbates@webkit.org
  • 2 edits
    2 adds in trunk/Tools

[iOS] Add a test to ensure that setTimeout() does not fire more than expected when using UIWebView
https://bugs.webkit.org/show_bug.cgi?id=185599
<rdar://problem/22493890>

Reviewed by Simon Fraser.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/ios/SetTimeoutFunction.mm: Added.

(-[SetTimeoutFunctionWebViewDelegate webViewDidFinishLoad:]):
(-[SetTimeoutFunctionWebViewDelegate webView:didFailLoadWithError:]):
(-[SetTimeoutFunctionWebViewDelegate webView:shouldStartLoadWithRequest:navigationType:]):
(TestWebKitAPI::TEST):

  • TestWebKitAPI/ios/set-timeout-function.html: Added.
4:18 PM Changeset in webkit [231775] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

test262/Runner.pm: small bugs in CLI and error codes
https://bugs.webkit.org/show_bug.cgi?id=185629

Patch by Valerie R Young <valerie@bocoup.com> on 2018-05-14
Reviewed by Michael Saboff.

Fix two commandline args with use '-f', correct
error code of failures.

  • Scripts/test262/Runner.pm:

(processCLI):
(main):

4:16 PM Changeset in webkit [231774] by Ryan Haddad
  • 5 edits in trunk/Tools

Disable API tests that time out after pointer poisioning was disabled.
https://bugs.webkit.org/show_bug.cgi?id=185586

Unreviewed test gardening.

  • TestWebKitAPI/Tests/WTF/Poisoned.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/PoisonedUniquePtr.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForNonTriviallyDestructibleArrays.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/PoisonedUniquePtrForTriviallyDestructibleArrays.cpp:

(TestWebKitAPI::TEST):

4:01 PM Changeset in webkit [231773] by webkit@devinrousso.com
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas tab: don't automatically select a recording when viewing a canvas
https://bugs.webkit.org/show_bug.cgi?id=182950

Reviewed by Matt Baker.

  • UserInterface/Views/CanvasSidebarPanel.js:

(WI.CanvasSidebarPanel):
(WI.CanvasSidebarPanel.prototype._currentRepresentedObjectsDidChange):
(WI.CanvasSidebarPanel.prototype._treeOutlineSelectionDidChange):
(WI.CanvasSidebarPanel.prototype._canvasChanged):
(WI.CanvasSidebarPanel.prototype._recordingChanged):
(WI.CanvasSidebarPanel.prototype._updateRecordingScopeBar):
Add a "dummy" ScopeBarItem to the recording ScopeBar that is selected whenever a TreeElement
that doesn't correspond to a Recording is selected. This way, the Recording ScopeBar will
become deselected, and the list of actions will disappear. Clicking on the Recording ScopeBar
will show the previously selected Recording.

3:38 PM Changeset in webkit [231772] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[INTL] Handle error in defineProperty for supported locales length
https://bugs.webkit.org/show_bug.cgi?id=185623

Patch by Andy VanWagoner <andy@vanwagoner.family> on 2018-05-14
Reviewed by Saam Barati.

Adds the missing RETURN_IF_EXCEPTION after defineOwnProperty for the
length of the supported locales array.

  • runtime/IntlObject.cpp:

(JSC::supportedLocales):

3:31 PM Changeset in webkit [231771] by Chris Dumez
  • 14 edits
    1 delete in trunk/Source/WebKit

Overly aggressive timer throttling in service workers
https://bugs.webkit.org/show_bug.cgi?id=185575
<rdar://problem/40219038>

Reviewed by Geoff Garen.

After ~30 seconds, the system would put the service worker process in "App Nap",
causing its timers to get aggressively throttled. This happens because the
service worker processes are WebProcesses that have no visible WebPages.

To address the issue, we now disable process suppression for all service worker
processes. This causes those processes to construct a UserActivity which prevents
App Nap.

This patch also refactors the code a bit to avoid duplication. The ProcessSuppression
suppression logic in now all on ChildProcessProxy / ChildProcess.

  • NetworkProcess/NetworkProcess.messages.in:
  • PluginProcess/PluginProcess.messages.in:
  • Shared/ChildProcess.messages.in:
  • UIProcess/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::setProcessSuppressionEnabled):

  • UIProcess/ChildProcessProxy.h:
  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Network/mac/NetworkProcessProxyMac.mm: Removed.
  • UIProcess/Plugins/PluginProcessProxy.h:
  • UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
  • UIProcess/ServiceWorkerProcessProxy.cpp:

(WebKit::ServiceWorkerProcessProxy::didFinishLaunching):

  • UIProcess/ServiceWorkerProcessProxy.h:
  • UIProcess/WebProcessProxy.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/WebProcess.messages.in:
3:14 PM Changeset in webkit [231770] by aestes@apple.com
  • 9 edits in trunk/Source/WebKit

[Wi-Fi Assertions] Allow clients to specify a context identifier
https://bugs.webkit.org/show_bug.cgi?id=185620
<rdar://problem/39915196>

Reviewed by Brady Eidson.

Added an SPI on _WKProcessPoolConfiguration that allows clients to specify a
context identifier.

  • NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

  • NetworkProcess/NetworkProcessCreationParameters.h:
  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

  • UIProcess/API/APIProcessPoolConfiguration.cpp:

(API::ProcessPoolConfiguration::copy):

  • UIProcess/API/APIProcessPoolConfiguration.h:
  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration wirelessContextIdentifier]):
(-[_WKProcessPoolConfiguration setWirelessContextIdentifier:]):

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::platformInitializeNetworkProcess):

2:26 PM Changeset in webkit [231769] by BJ Burg
  • 2 edits in trunk/Source/WebKit

Web Automation: Automation.getBrowsingContext returns window origin that differs from window.screenX/Y
https://bugs.webkit.org/show_bug.cgi?id=185571
<rdar://problem/40180785>

Reviewed by Timothy Hatcher.

This code path was refactored to use completion handlers. It seems that the window.screenX/Y
code path converts back to user coordinates but the WebDriver code path does not. Make them
consistent since that is how it is spec'd and tested.

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::getWindowFrameWithCallback):
Convert the window frame to user coordinate space so it's the same as window.screenY.

2:19 PM Changeset in webkit [231768] by commit-queue@webkit.org
  • 3 edits in trunk

Test262-Runner: Fix RegExp for capturing tests metadata"
https://bugs.webkit.org/show_bug.cgi?id=185622

Patch by Leo Balter <leonardo.balter@gmail.com> on 2018-05-14
Reviewed by Michael Saboff.

This patch fixes the RegExp used to capture each test metadata regarding their EOL characters for
both LF and CRLF forms.

The fix also allows the runner to capture the proper results from two specific files using CR and
CRLF line terminators. They are updated in the expectations file.

  • Scripts/test262/Runner.pm:

(parseData):

12:09 PM Changeset in webkit [231767] by BJ Burg
  • 5 edits in trunk/Source/WebKit

WebDriver: W3C test case actions/key.py::test_lone_keyup_sends_no_events is failing
https://bugs.webkit.org/show_bug.cgi?id=185577
<rdar://problem/40185478>

Reviewed by Timothy Hatcher.

This test is failing because it expects Release Actions to not emit any
events if nothing has changed from the initial state. Because the two code paths
for creating empty states don't actually produce the same empty state, a difference
in location was detected between the two empty states. This generates a mousemove.

To fix this, unify the code that creates an empty state. For mouse input sources, always
initialize the location to (0, 0) so that the mouse input source always has
a location that is valid to click at.

  • UIProcess/Automation/SimulatedInputDispatcher.h:

Extract the type enum out of the class to avoid circular definitions of
SimulatedInputSource and SimulatedInputSourceState.

  • UIProcess/Automation/SimulatedInputDispatcher.cpp:

(WebKit::SimulatedInputSourceState::emptyStateForSourceType):
Take the input source type when generating an empty state. We always want location
set for a mouse input source, but not set it for other input sources like keys.

(WebKit::SimulatedInputKeyFrame::keyFrameToResetInputSources):
(WebKit::SimulatedInputDispatcher::transitionInputSourceToState):
(WebKit::SimulatedInputSource::create):
(WebKit::SimulatedInputSource::SimulatedInputSource):
(WebKit::SimulatedInputSourceState::emptyState): Deleted.

  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::WebAutomationSession):
(WebKit::WebAutomationSession::inputSourceForType const):
(WebKit::simulatedInputSourceTypeFromProtocolSourceType):
(WebKit::WebAutomationSession::performInteractionSequence):

  • UIProcess/Automation/WebAutomationSession.h:
11:19 AM Changeset in webkit [231766] by graouts@webkit.org
  • 14 edits in trunk

[Web Animations] Tests using the new animation engine may crash under WebCore::FrameView::didDestroyRenderTree when using internals methods
https://bugs.webkit.org/show_bug.cgi?id=185612
<rdar://problem/39579344>

Reviewed by Dean Jackson.

Source/WebCore:

Add a new internals.pseudoElement() method to obtain a pseudo element matching a given pseudo-id. This is necessary to be able to move off
internals.pauseTransitionAtTimeOnPseudoElement() and internals.pauseAnimationAtTimeOnPseudoElement() for Web Animations testing.

  • testing/Internals.cpp:

(WebCore::Internals::pseudoElement):

  • testing/Internals.h:
  • testing/Internals.idl:

LayoutTests:

Some tests that were opting into the new animation engine were using internals methods (pauseAnimationAtTimeOnElement, pauseTransitionAtTimeOnElement, etc.)
that enforce the creation of animations in the old animation engine. Meanwhile, the code that toggles the animation engine used based on HTML comments is run
prior to teardown of the previous test and so a test running with the new engine would run with the legacy engine during teardown. These two factors would
cause ASSERT(!frame().animation().hasAnimations()) to fail under FrameView::didDestroyRenderTree().

We update tests that use these internals method to use the Web Animations API instead and opt into the new animation engine if they didn't already do that.

  • animations/animation-hit-test-transform.html:
  • animations/keyframes-dynamic-expected.txt:
  • animations/keyframes-dynamic.html:
  • animations/missing-from-to-expected.txt:
  • animations/missing-from-to-transforms-expected.txt:
  • animations/missing-from-to-transforms.html:
  • animations/missing-from-to.html:
  • fast/css-generated-content/pseudo-animation.html:
  • transitions/transition-hit-test-transform.html:
11:15 AM Changeset in webkit [231765] by graouts@webkit.org
  • 4 edits
    2 adds in trunk

REGRESSION (r230574): Interrupted hardware transitions don't behave correctly
https://bugs.webkit.org/show_bug.cgi?id=185299
<rdar://problem/39630230>

Reviewed by Simon Fraser.

Source/WebCore:

In r230574, the fix for webkit.org/b/184518, we changed the processing order in GraphicsLayerCA::updateAnimations() to first
process m_uncomittedAnimations and then m_animationsToProcess, so we are guaranteed animations exist before we attempt to pause
or seek them. This broke interrupting and resuming hardware animations (such as an interrupted CSS Transition or an animation
running in a non-visible tab) since a pause operation recorded _before_ an animation was added would be paused anyway since
the animation was now first added, and then paused. The fix is simply to clear any pending AnimationProcessingAction for a
newly-uncommitted animation.

Test: transitions/interrupted-transition-hardware.html

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::createAnimationFromKeyframes):
(WebCore::GraphicsLayerCA::appendToUncommittedAnimations):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):

  • platform/graphics/ca/GraphicsLayerCA.h:

(WebCore::GraphicsLayerCA::LayerPropertyAnimation::LayerPropertyAnimation):

LayoutTests:

Add a new test where we interrupt a transition and check that upon returning to the original value,
an animated value is still used and not the initial value. This test fails prior to this patch.

  • transitions/interrupted-transition-hardware-expected.html: Added.
  • transitions/interrupted-transition-hardware.html: Added.
10:39 AM Changeset in webkit [231764] by commit-queue@webkit.org
  • 2 edits in trunk/JSTests

Fix a legacy CRLF eol from Test262
https://bugs.webkit.org/show_bug.cgi?id=185565

Patch by Leo Balter <leonardo.balter@gmail.com> on 2018-05-14
Reviewed by Yusuke Suzuki.

  • test262/config.yaml:
  • test262/test/built-ins/Math/cbrt/prop-desc.js:
10:26 AM Changeset in webkit [231763] by commit-queue@webkit.org
  • 3 edits
    2 adds in trunk

NSEvent event trackers don't work from WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=185383
rdar://problem/40025045

Patch by Jeremy Jones <jeremyj@apple.com> on 2018-05-14
Reviewed by Simon Fraser.

Tools:

Post simulated wheel events to _sendEventToObservers: so they can be handled by NSEvent observers.
NSEvent swipe tracking is used for webkit swipe navigation.

  • WebKitTestRunner/mac/EventSenderProxy.mm:

(WTR::EventSenderProxy::mouseScrollByWithWheelAndMomentumPhases):

LayoutTests:

This test initiates back navigation with wheel events.

  • swipe/wheel-event-initiated-back-navigation-expected.txt: Added.
  • swipe/wheel-event-initiated-back-navigation.html: Added.
10:18 AM Changeset in webkit [231762] by Yusuke Suzuki
  • 6 edits
    1 add in trunk

[JSC] timeClip(-0) should produce +0
https://bugs.webkit.org/show_bug.cgi?id=185589

Reviewed by Saam Barati.

JSTests:

Fix several test262 failures.

  • stress/date-negative-zero.js: Added.

(shouldBe):

  • test262/expectations.yaml:

Source/WTF:

According to the spec[1], timeClip(-0) should produce +0.
We achieve this by adding 0.0 to the result of trunc(t).

[1]: https://tc39.github.io/ecma262/#sec-timeclip

  • wtf/DateMath.cpp:

(WTF::timeClip):

LayoutTests:

  • sputnik/Implementation_Diagnostics/S15.9.1.14_D1-expected.txt:
9:47 AM Changeset in webkit [231761] by Yusuke Suzuki
  • 5 edits in trunk/Source/JavaScriptCore

[JSC] Tweak LiteralParser to improve lexing performance
https://bugs.webkit.org/show_bug.cgi?id=185541

Reviewed by Saam Barati.

This patch attemps to improve LiteralParser performance.

This patch improves Kraken/json-parse-financial by roughly ~10%.

baseline patched

json-parse-financial 65.810+-1.591 59.943+-1.784 definitely 1.0979x faster

  • parser/Lexer.cpp:

(JSC::Lexer<T>::Lexer):

  • runtime/ArgList.h:

(JSC::MarkedArgumentBuffer::takeLast):
Add takeLast() for idiomatic last() + removeLast() calls.

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser<CharType>::Lexer::lex):
Do not have mode in its template parameter. While lex function is large, this mode is not used in a critical path.
We should not include this mode in its template parameter to reduce the code size.
And we do not use template parameter for a terminator since duplicating ' and " code for lexString is not good.
Also, we construct TokenType table to remove bunch of unnecessary switch cases.

(JSC::LiteralParser<CharType>::Lexer::next):
(JSC::isSafeStringCharacter):
Take mode in its template parameter. But do not take terminator character in its template parameter.

(JSC::LiteralParser<CharType>::Lexer::lexString):
(JSC::LiteralParser<CharType>::Lexer::lexStringSlow):
Duplicate while statements manually since this is a critical path.

(JSC::LiteralParser<CharType>::parse):
Use takeLast().

  • runtime/LiteralParser.h:
9:45 AM Changeset in webkit [231760] by ggaren@apple.com
  • 2 edits in trunk/Source/WTF

Simplified Mach exception handling
https://bugs.webkit.org/show_bug.cgi?id=185595

Reviewed by Keith Miller.

  • wtf/threads/Signals.cpp:

(WTF::startMachExceptionHandlerThread): Use mach_msg_server_once instead
of duplicating its functionality. Separate error handling logic from
program logic to help program logic stand out. Use
DISPATCH_TARGET_QUEUE_* instead of explicitly fetching a queue.

Also, we don't need the high priority queue. The kernel donates a
priority voucher from the exception thread to the receiver thread, and
mach_msg_server_once takes care to forward that voucher.

9:18 AM Changeset in webkit [231759] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GStreamer] Fix style issue in MediaPlayerPrivateGStreamerBase
https://bugs.webkit.org/show_bug.cgi?id=185510

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-05-14
Reviewed by Philippe Normand.

ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:629: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:684: More than one command on the same line [whitespace/newline] [4]
ERROR: Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:807: More than one command on the same line [whitespace/newline] [4]

Indentation and style issue fixed only.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::volumeChangedCallback):
(WebCore::MediaPlayerPrivateGStreamerBase::muteChangedCallback):
(WebCore::MediaPlayerPrivateGStreamerBase::triggerRepaint):

8:59 AM Changeset in webkit [231758] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC] Implement height computation for non-replaced out of flow elements.
https://bugs.webkit.org/show_bug.cgi?id=185585

Reviewed by Antti Koivisto.

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeHeight const):
(WebCore::Layout::FormattingContext::computeOutOfFlowHeight const):
(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
(WebCore::Layout::FormattingContext::computeOutOfFlowNonReplacedHeight const):
(WebCore::Layout::FormattingContext::computeHeightForBlockFormattingContextRootWithAutoHeight const):

  • layout/FormattingContext.h:
  • layout/blockformatting/BlockFormattingContext.h:
  • layout/displaytree/DisplayBox.h:
8:20 AM Changeset in webkit [231757] by Manuel Rego Casasnovas
  • 17 edits in trunk/Source/WebCore

Renaming of overrides in LayoutBox
https://bugs.webkit.org/show_bug.cgi?id=185609

Reviewed by Javier Fernandez.

The names of the methods for the overrides were not consistent,
this patch fixes it by using the same structure in all the cases.

No new tests, no change of behavior.

  • rendering/GridLayoutFunctions.cpp:

(WebCore::GridLayoutFunctions::hasOverrideContainingBlockContentSizeForChild):

  • rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrackSizingAlgorithmStrategy::logicalHeightForChild const):

  • rendering/RenderBlock.cpp:

(WebCore::RenderBlock::computeChildPreferredLogicalWidths const):
(WebCore::RenderBlock::availableLogicalHeightForPercentageComputation const):

  • rendering/RenderBlockFlow.cpp:

(WebCore::RenderBlockFlow::fitBorderToLinesIfNeeded):

  • rendering/RenderBlockLineLayout.cpp:

(WebCore::RenderBlockFlow::updateRubyForJustifiedText):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::willBeDestroyed):
(WebCore::RenderBox::hasOverrideContentLogicalHeight const):
(WebCore::RenderBox::hasOverrideContentLogicalWidth const):
(WebCore::RenderBox::setOverrideContentLogicalHeight):
(WebCore::RenderBox::setOverrideContentLogicalWidth):
(WebCore::RenderBox::clearOverrideContentLogicalHeight):
(WebCore::RenderBox::clearOverrideContentLogicalWidth):
(WebCore::RenderBox::clearOverrideContentSize):
(WebCore::RenderBox::overrideContentLogicalWidth const):
(WebCore::RenderBox::overrideContentLogicalHeight const):
(WebCore::RenderBox::overrideContainingBlockContentLogicalWidth const):
(WebCore::RenderBox::overrideContainingBlockContentLogicalHeight const):
(WebCore::RenderBox::hasOverrideContainingBlockContentLogicalWidth const):
(WebCore::RenderBox::hasOverrideContainingBlockContentLogicalHeight const):
(WebCore::RenderBox::setOverrideContainingBlockContentLogicalWidth):
(WebCore::RenderBox::setOverrideContainingBlockContentLogicalHeight):
(WebCore::RenderBox::clearOverrideContainingBlockContentSize):
(WebCore::RenderBox::clearOverrideContainingBlockContentLogicalHeight):
(WebCore::RenderBox::containingBlockLogicalWidthForContent const):
(WebCore::RenderBox::containingBlockLogicalHeightForContent const):
(WebCore::RenderBox::perpendicularContainingBlockLogicalHeight const):
(WebCore::RenderBox::computeLogicalWidthInFragment const):
(WebCore::RenderBox::computeLogicalHeight const):
(WebCore::RenderBox::computePercentageLogicalHeight const):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing const):
(WebCore::RenderBox::availableLogicalHeightUsing const):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned const):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned const):

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::hasAutoHeightOrContainingBlockWithAutoHeight const):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::contentWidthForChild):
(WebCore::contentHeightForChild):
(WebCore::gatherFlexChildrenInfo):
(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):
(WebCore::RenderDeprecatedFlexibleBox::layoutVerticalBox):
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
(WebCore::RenderDeprecatedFlexibleBox::clearLineClamp):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::computeInnerFlexBaseSizeForChild):
(WebCore::RenderFlexibleBox::crossSizeForPercentageResolution):
(WebCore::RenderFlexibleBox::mainSizeForPercentageResolution):
(WebCore::RenderFlexibleBox::constructFlexItem):
(WebCore::RenderFlexibleBox::setOverrideMainAxisContentSizeForChild):
(WebCore::RenderFlexibleBox::applyStretchAlignmentToChild):

  • rendering/RenderFullScreen.cpp:

(WebCore::RenderFullScreen::unwrapRenderer):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::layoutBlock):
(WebCore::RenderGrid::layoutGridItems):
(WebCore::RenderGrid::applyStretchAlignmentToChildIfNeeded):

  • rendering/RenderRubyBase.cpp:

(WebCore::RenderRubyBase::adjustInlineDirectionLineBounds const):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::setOverrideContentLogicalHeightFromRowHeight):

  • rendering/RenderTableCell.h:
  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::calcRowLogicalHeight):
(WebCore::RenderTableSection::relayoutCellIfFlexed):

7:52 AM Changeset in webkit [231756] by Alan Bujtas
  • 5 edits in trunk/Source/WebCore

[LFC] Implement width computation for non-replaced out of flow elements.
https://bugs.webkit.org/show_bug.cgi?id=185598

Reviewed by Antti Koivisto.

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeWidth const):
(WebCore::Layout::FormattingContext::computeOutOfFlowWidth const):
(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
(WebCore::Layout::FormattingContext::computeOutOfFlowNonReplacedWidth const):
(WebCore::Layout::FormattingContext::shrinkToFitWidth const):

  • layout/FormattingContext.h:
  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layout const):

  • layout/displaytree/DisplayBox.h:
7:39 AM Changeset in webkit [231755] by Michael Catanzaro
  • 2 edits in trunk/Source/WebKit

-Wmemset-elt-size warning in LibWebRTCSocket constructor
https://bugs.webkit.org/show_bug.cgi?id=185555

Reviewed by Youenn Fablet.

Add missing multiplication.

  • WebProcess/Network/webrtc/LibWebRTCSocket.cpp:

(WebKit::LibWebRTCSocket::LibWebRTCSocket):

5:57 AM Changeset in webkit [231754] by zandobersek@gmail.com
  • 2 edits in trunk/Source/WebCore

Drop the m_compositorTexture member variable in TextureMapperGC3DPlatformLayer.
It's not used at all inside the class or outside it.

Rubber-stamped by Michael Catanzaro.

  • platform/graphics/texmap/TextureMapperGC3DPlatformLayer.h:
5:52 AM Changeset in webkit [231753] by zandobersek@gmail.com
  • 18 edits in trunk

[GTK] REGRESSION(r231170) Build broken with Clang 5.0
https://bugs.webkit.org/show_bug.cgi?id=185198

Reviewed by Michael Catanzaro.

.:

  • Source/cmake/WebKitCompilerFlags.cmake: Fall back to the -std=c++1z

compiler flag if -std=c++17 is not supported. If that flag is not
supported either, bail with an error message.

Source/WebCore:

Avoid gperf files using the register keyword which has been made
reserved and as such unusable in C++17.

  • css/makeSelectorPseudoClassAndCompatibilityElementMap.py:
  • css/makeSelectorPseudoElementsMap.py:
  • css/makeprop.pl:
  • css/makevalues.pl:
  • platform/ColorData.gperf:
  • platform/ReferrerPolicy.h: With std::optional forward declaration

gone, explicitly include the WTF Optional.h header.

  • platform/Theme.h: Ditto.
  • platform/network/create-http-header-name-table:

Source/WebKit:

  • Shared/RTCNetwork.h: With std::optional forward declaration gone,

explicitly include the WTF Optional.h header.

Source/WTF:

  • wtf/Compiler.h:
  • wtf/Forward.h: Delete the std::optional forward declaration that is

potentially incompatible with definition provided by the standard library.

  • wtf/Hasher.h:
  • wtf/StdLibExtras.h: In addition to the remaining C++14 configurations,

also use custom std::in_place_t implementation when compiling with
libstdc++ 6.x, which doesn't provide its own.

3:41 AM Changeset in webkit [231752] by youenn@apple.com
  • 4 edits in trunk/LayoutTests

Enable service-worker/navigation-redirect-body.https.html and service-worker/postmessage.https.html
https://bugs.webkit.org/show_bug.cgi?id=185605

Unreviewed.

LayoutTests/imported/w3c:

  • web-platform-tests/service-workers/service-worker/postmessage.https-expected.txt:

LayoutTests:

3:20 AM Changeset in webkit [231751] by commit-queue@webkit.org
  • 2 edits in trunk/Source/JavaScriptCore

[MIPS] Use btpz to compare against 0 instead of bpeq
https://bugs.webkit.org/show_bug.cgi?id=185607

Patch by Dominik Infuehr <dinfuehr@igalia.com> on 2018-05-14
Reviewed by Yusuke Suzuki.

Fixes build on MIPS since MIPS doesn't have an instruction to
compare a register against an immediate. Since the immediate is just 0
in this case the simplest solution is just to use btpz instead of bpeq
to compare to 0.

  • llint/LowLevelInterpreter.asm:
1:32 AM Changeset in webkit [231750] by youenn@apple.com
  • 2 edits in trunk/LayoutTests

Mark imported/w3c/web-platform-tests/service-workers/service-worker/redirected-response.https.html as slow in debug
https://bugs.webkit.org/show_bug.cgi?id=185604

Unreviewed.

12:33 AM Changeset in webkit [231749] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r219515.
https://bugs.webkit.org/show_bug.cgi?id=185603

It sometimes makes AudioUnitInitialize call to fail in
CoreAudioCaptureSource (Requested by youenn on #webkit).

Reverted changeset:

"Remove CoreAudioCaptureSource speaker configuration"
https://bugs.webkit.org/show_bug.cgi?id=174512
https://trac.webkit.org/changeset/219515

May 13, 2018:

9:36 PM Changeset in webkit [231748] by bshafiei@apple.com
  • 7 edits in branches/safari-606.1.17-branch/Source

Versioning.

6:12 PM Changeset in webkit [231747] by bshafiei@apple.com
  • 1 copy in tags/Safari-606.1.17.5

Tag Safari-606.1.17.5.

5:15 PM Changeset in webkit [231746] by bshafiei@apple.com
  • 3 edits in branches/safari-606.1.17-branch/Source/WebKit

Cherry-pick r231744. rdar://problem/40196581

WebKit2_Sim-7606.1.17.4 introduced dep cycle
https://bugs.webkit.org/show_bug.cgi?id=185588
<rdar://problem/40196581>

Reviewed by Tim Horton.

Soft link AssetViewer.framework to avoid a dependency cycle.

  • Configurations/WebKit.xcconfig:
  • UIProcess/ios/WKSystemPreviewView.mm: (-[WKSystemPreviewView web_setContentProviderData:suggestedFilename:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4:39 PM Changeset in webkit [231745] by bshafiei@apple.com
  • 7 edits in branches/safari-606.1.17-branch/Source

Versioning.

12:29 PM Changeset in webkit [231744] by dino@apple.com
  • 3 edits in trunk/Source/WebKit

WebKit2_Sim-7606.1.17.4 introduced dep cycle
https://bugs.webkit.org/show_bug.cgi?id=185588
<rdar://problem/40196581>

Reviewed by Tim Horton.

Soft link AssetViewer.framework to avoid a dependency cycle.

  • Configurations/WebKit.xcconfig:
  • UIProcess/ios/WKSystemPreviewView.mm:

(-[WKSystemPreviewView web_setContentProviderData:suggestedFilename:]):

11:57 AM Changeset in webkit [231743] by fpizlo@apple.com
  • 2 edits in trunk/Source/WTF

Disable pointer poisoning
https://bugs.webkit.org/show_bug.cgi?id=185586

Reviewed by Yusuke Suzuki.

This seems like a 0.3% speed-up on microbenchmarks. It seems like it may be a small speed-up on
other tests, too.

  • wtf/Platform.h:
11:16 AM Changeset in webkit [231742] by Caio Lima
  • 2 edits in trunk/JSTests

[BigInt] stress/big-int-spec-to-primitive.js test is failing
https://bugs.webkit.org/show_bug.cgi?id=185582

Reviewed by Yusuke Suzuki.

This patch is removing the use of numberOfDFGCompiles from
stress/big-int-spec-to-primitive.js because it makes this est fail
sometimes.

  • stress/big-int-spec-to-primitive.js:
9:54 AM Changeset in webkit [231741] by fpizlo@apple.com
  • 9 edits
    1 add in trunk/Source/JavaScriptCore

CachedCall::call() should be faster
https://bugs.webkit.org/show_bug.cgi?id=185583

Reviewed by Yusuke Suzuki.

CachedCall is an optimization for String.prototype.replace(r, f) where f is a function.
Unfortunately, because of a combination of abstraction and assertions, this code path had a
lot of overhead. This patch reduces this overhead by:

  • Turning off some assertions. These assertions don't look to have security value; they're mostly for sanity. I turned off stack alignment checks and VM state checks having to do with whether the JSLock is held. The JSLock checks are not relevant when doing a cached call, considering that the caller would have already been strongly assuming that the JSLock is held.


  • Making more things inlineable.


This looks like a small (4% ish) speed-up on SunSpider/string-unpack-code.

(JSC::CachedCall::call):

  • interpreter/Interpreter.cpp:

(JSC::checkedReturn): Deleted.

  • interpreter/Interpreter.h:

(JSC::Interpreter::checkedReturn):

  • interpreter/InterpreterInlines.h:

(JSC::Interpreter::execute):

  • jit/JITCode.cpp:

(JSC::JITCode::execute): Deleted.

  • jit/JITCodeInlines.h: Added.

(JSC::JITCode::execute):

  • llint/LowLevelInterpreter.asm:
  • runtime/StringPrototype.cpp:
7:28 AM Changeset in webkit [231740] by commit-queue@webkit.org
  • 22 edits in trunk

[INTL] Improve spec & test262 compliance for Intl APIs
https://bugs.webkit.org/show_bug.cgi?id=185578

Patch by Andy VanWagoner <andy@vanwagoner.family> on 2018-05-13
Reviewed by Yusuke Suzuki.

JSTests:

Remove intl402 failures that have been fixed.

  • test262/expectations.yaml:
  • stress/regress-178385.js: toStringTag is configurable, but not writable.

Source/JavaScriptCore:

Use putDirectIndex over push for lists to arrays.
Update default options to construct with a null prototype.
Define constructor and toStringTag on prototypes.
Add proper time clipping.
Remove some outdated comment spec text, use url instead.

  • runtime/IntlCollator.cpp:

(JSC::IntlCollator::initializeCollator):

  • runtime/IntlCollatorConstructor.cpp:

(JSC::IntlCollatorConstructor::finishCreation):

  • runtime/IntlCollatorPrototype.cpp:

(JSC::IntlCollatorPrototype::finishCreation):

  • runtime/IntlDateTimeFormatConstructor.cpp:

(JSC::IntlDateTimeFormatConstructor::finishCreation):

  • runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototype::finishCreation):
(JSC::IntlDateTimeFormatFuncFormatDateTime):
(JSC::IntlDateTimeFormatPrototypeFuncFormatToParts):

  • runtime/IntlNumberFormat.cpp:

(JSC::IntlNumberFormat::initializeNumberFormat):

  • runtime/IntlNumberFormatConstructor.cpp:

(JSC::IntlNumberFormatConstructor::finishCreation):

  • runtime/IntlNumberFormatPrototype.cpp:

(JSC::IntlNumberFormatPrototype::finishCreation):

  • runtime/IntlObject.cpp:

(JSC::lookupSupportedLocales):
(JSC::supportedLocales):
(JSC::intlObjectFuncGetCanonicalLocales):

  • runtime/IntlPluralRules.cpp:

(JSC::IntlPluralRules::resolvedOptions):

  • runtime/IntlPluralRulesConstructor.cpp:

(JSC::IntlPluralRulesConstructor::finishCreation):

LayoutTests:

Update Intl tests for prototype changes.

  • js/intl-collator-expected.txt:
  • js/intl-datetimeformat-expected.txt:
  • js/intl-numberformat-expected.txt:
  • js/script-tests/intl-collator.js:
  • js/script-tests/intl-datetimeformat.js:
  • js/script-tests/intl-numberformat.js:
2:25 AM Changeset in webkit [231739] by krit@webkit.org
  • 13 edits
    4 adds in trunk

Implement SVGGeometryElement's isPointInFill and isPointInStroke
https://bugs.webkit.org/show_bug.cgi?id=185580

Reviewed by Antti Koivisto.

Implement isPointInFill and isPointInStroke methods for
SVGGeometryElement interface from SVG2.

https://svgwg.org/svg2-draft/types.html#InterfaceSVGGeometryElement

Source/WebCore:

Tests: svg/dom/SVGGeometry-isPointInFill.xhtml

svg/dom/SVGGeometry-isPointInStroke.xhtml

  • rendering/svg/RenderSVGEllipse.cpp:

(WebCore::RenderSVGEllipse::shapeDependentStrokeContains): Flag

to switch between local and "global" coordinate space for hit testing.

  • rendering/svg/RenderSVGEllipse.h:
  • rendering/svg/RenderSVGPath.cpp:

(WebCore::RenderSVGPath::shapeDependentStrokeContains): Flag

to switch between local and "global" coordinate space for hit testing.

  • rendering/svg/RenderSVGPath.h:
  • rendering/svg/RenderSVGRect.cpp:

(WebCore::RenderSVGRect::shapeDependentStrokeContains): Flag

to switch between local and "global" coordinate space for hit testing.

  • rendering/svg/RenderSVGRect.h:
  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::shapeDependentStrokeContains): Flag

to switch between local and "global" coordinate space for hit testing.

(WebCore::RenderSVGShape::isPointInFill): Take the winding rule given by

fill-rule to test if a given point is in the fill area of a path.

(WebCore::RenderSVGShape::isPointInStroke): Take stroke properties into

account to check if a point is on top of the stroke area.

  • rendering/svg/RenderSVGShape.h:
  • svg/SVGGeometryElement.cpp:

(WebCore::SVGGeometryElement::isPointInFill):
(WebCore::SVGGeometryElement::isPointInStroke):
(WebCore::SVGGeometryElement::createElementRenderer): Deleted. This is getting implemented

by inheriting classes. No need to create RenderSVGPath here.

  • svg/SVGGeometryElement.h:
  • svg/SVGGeometryElement.idl:

LayoutTests:

  • svg/dom/SVGGeometry-isPointInFill-expected.txt: Added.
  • svg/dom/SVGGeometry-isPointInFill.xhtml: Added.
  • svg/dom/SVGGeometry-isPointInStroke-expected.txt: Added.
  • svg/dom/SVGGeometry-isPointInStroke.xhtml: Added.

May 12, 2018:

6:00 PM Changeset in webkit [231738] by bshafiei@apple.com
  • 1 copy in tags/Safari-606.1.17.4

Tag Safari-606.1.17.4.

5:03 PM Changeset in webkit [231737] by Wenson Hsieh
  • 2 edits in trunk/LayoutTests

Unreviewed, rebaseline a layout test after r231717

  • fast/events/extrazoom/change-focus-during-change-event-expected.txt:
4:55 PM Changeset in webkit [231736] by bshafiei@apple.com
  • 7 edits in branches/safari-606.1.17-branch/Source

Versioning.

10:10 AM Changeset in webkit [231735] by Alan Bujtas
  • 5 edits in trunk/Source/WebCore

Use WeakPtr for m_enclosingPaginationLayer in RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=185566
<rdar://problem/36486052>

Reviewed by Simon Fraser.

Since RenderLayer does not own the enclosing pagination layout, it should
construct a weak pointer instead of holding on to a raw pointer.

Unable to create a reliably reproducible test case.

  • page/mac/EventHandlerMac.mm:

(WebCore::scrollableAreaForEventTarget):
(WebCore::scrollableAreaForContainerNode):
(WebCore::EventHandler::platformPrepareForWheelEvents):

  • platform/ScrollableArea.h:

(WebCore::ScrollableArea::weakPtrFactory const):
(WebCore::ScrollableArea::createWeakPtr): Deleted.

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updatePagination):

  • rendering/RenderLayer.h:

May 11, 2018:

9:36 PM Changeset in webkit [231734] by bshafiei@apple.com
  • 1 copy in tags/Safari-606.1.17.3

Tag Safari-606.1.17.3.

9:32 PM Changeset in webkit [231733] by Caio Lima
  • 11 edits
    7 adds in trunk

[ESNext][BigInt] Implement support for "*" operation
https://bugs.webkit.org/show_bug.cgi?id=183721

Reviewed by Yusuke Suzuki.

JSTests:

  • bigIntTests.yaml:
  • stress/big-int-mul-jit.js: Added.
  • stress/big-int-mul-to-primitive-precedence.js: Added.
  • stress/big-int-mul-to-primitive.js: Added.
  • stress/big-int-mul-type-error.js: Added.
  • stress/big-int-mul-wrapped-value.js: Added.
  • stress/big-int-multiplication.js: Added.
  • stress/big-int-multiply-memory-stress.js: Added.

Source/JavaScriptCore:

Added BigInt support into times binary operator into LLInt and on
JITOperations profiledMul and unprofiledMul. We are also replacing all
uses of int to unsigned when there is no negative values for
variables.

  • dfg/DFGConstantFoldingPhase.cpp:

(JSC::DFG::ConstantFoldingPhase::foldConstants):

  • jit/JITOperations.cpp:
  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/JSBigInt.cpp:

(JSC::JSBigInt::JSBigInt):
(JSC::JSBigInt::allocationSize):
(JSC::JSBigInt::createWithLength):
(JSC::JSBigInt::toString):
(JSC::JSBigInt::multiply):
(JSC::JSBigInt::digitDiv):
(JSC::JSBigInt::internalMultiplyAdd):
(JSC::JSBigInt::multiplyAccumulate):
(JSC::JSBigInt::equals):
(JSC::JSBigInt::absoluteDivSmall):
(JSC::JSBigInt::calculateMaximumCharactersRequired):
(JSC::JSBigInt::toStringGeneric):
(JSC::JSBigInt::rightTrim):
(JSC::JSBigInt::allocateFor):
(JSC::JSBigInt::parseInt):
(JSC::JSBigInt::digit):
(JSC::JSBigInt::setDigit):

  • runtime/JSBigInt.h:
  • runtime/JSCJSValue.h:
  • runtime/JSCJSValueInlines.h:

(JSC::JSValue::toNumeric const):

  • runtime/Operations.h:

(JSC::jsMul):

9:25 PM Changeset in webkit [231732] by bshafiei@apple.com
  • 3 edits in branches/safari-606.1.17-branch/Source/WebCore/PAL

Cherry-pick r231731. rdar://problem/39806412

Follow-up build fix to r231721.

  • pal/cf/CoreMediaSoftLink.cpp:
  • pal/cf/CoreMediaSoftLink.h: Unify the conditions between the header and the implementation files, and have watchOS and tvOS keyed off iOS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9:19 PM Changeset in webkit [231731] by mitz@apple.com
  • 3 edits in trunk/Source/WebCore/PAL

Follow-up build fix to r231721.

  • pal/cf/CoreMediaSoftLink.cpp:
  • pal/cf/CoreMediaSoftLink.h: Unify the conditions between the header and the implementation files, and have watchOS and tvOS keyed off iOS.
9:11 PM Changeset in webkit [231730] by dbates@webkit.org
  • 8 edits
    8 adds
    1 delete in trunk

X-Frame-Options: SAMEORIGIN needs to check all ancestor frames
https://bugs.webkit.org/show_bug.cgi?id=185567
<rdar://problem/40175008>

Reviewed by Brent Fulgham.

Source/WebCore:

Change the behavior of "X-Frame-Options: SAMEORIGIN" to ensure that all ancestors frames
are same-origin with the document that delivered this header. This prevents an intermediary
malicious frame from clickjacking a child frame whose document is same-origin with the top-
level frame. It also makes the behavior of X-Frame-Options in WebKit more closely match
the behavior of X-Frame-Options in other browsers, including Chrome and Firefox.

Currently a document delivered with "X-Frame-Options: SAMEORIGIN" must only be same-origin
with the top-level frame's document in order to be displayed. This prevents clickjacking by
a malicious page that embeds a page delivered with "X-Frame-Options: SAMEORIGIN". However,
it does not protect against clickjacking of the "X-Frame-Options: SAMEORIGIN" page (victim)
if embedded by an intermediate malicious iframe, say a "rogue ad", that was embedded in a
document same origin with the victim page. We should protect against such attacks.

Tests: http/tests/security/XFrameOptions/x-frame-options-ancestors-same-origin-allow.html

http/tests/security/XFrameOptions/x-frame-options-ancestors-same-origin-deny.html

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):

Source/WebKit:

Change the behavior of "X-Frame-Options: SAMEORIGIN" to ensure that all ancestors frames
are same-origin with the document that delivered this header. This prevents an intermediary
malicious frame from clickjacking a child frame whose document is same-origin with the top-
level frame. It also makes the behavior of X-Frame-Options in WebKit more closely match
the behavior of X-Frame-Options in other browsers, including Chrome and Firefox.

Currently a document delivered with "X-Frame-Options: SAMEORIGIN" must only be same-origin
with the top-level frame's document in order to be displayed. This prevents clickjacking by
a malicious page that embeds a page delivered with "X-Frame-Options: SAMEORIGIN". However,
it does not protect against clickjacking of the "X-Frame-Options: SAMEORIGIN" page (victim)
if embedded by an intermediate malicious iframe, say a "rogue ad", that was embedded in a
document same origin with the victim page. We should protect against such attacks.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::shouldInterruptLoadForXFrameOptions):

LayoutTests:

Add tests to ensure that "X-Frame-Options: SAMEORIGIN" checks ancestor frames.

  • http/tests/cookies/same-site/fetch-after-navigating-iframe-in-cross-origin-page.html:
  • http/tests/cookies/same-site/fetch-after-top-level-navigation-initiated-from-iframe-in-cross-origin-page.html:
  • http/tests/cookies/same-site/fetch-in-cross-origin-iframe.html:
  • http/tests/resources/echo-iframe-src.php: Copied from LayoutTests/http/tests/cookies/same-site/resources/echo-iframe-src.php.
  • http/tests/security/XFrameOptions/resources/x-frame-options-ancestors-same-origin-deny.html: Added.
  • http/tests/security/XFrameOptions/resources/x-frame-options-frame-ancestors-same-origin-allow.cgi: Added.
  • http/tests/security/XFrameOptions/resources/x-frame-options-frame-ancestors-same-origin-deny.cgi: Added.
  • http/tests/security/XFrameOptions/x-frame-options-ancestors-same-origin-allow-expected.txt: Added.
  • http/tests/security/XFrameOptions/x-frame-options-ancestors-same-origin-allow.html: Added.
  • http/tests/security/XFrameOptions/x-frame-options-ancestors-same-origin-deny-expected.txt: Added.
  • http/tests/security/XFrameOptions/x-frame-options-ancestors-same-origin-deny.html: Renamed from LayoutTests/http/tests/cookies/same-site/resources/echo-iframe-src.php.
7:11 PM Changeset in webkit [231729] by dino@apple.com
  • 6 edits in trunk/Source/WebKit

WKWebViewContentProvider should know what MIME type it was created to handle
https://bugs.webkit.org/show_bug.cgi?id=185574
<rdar://problem/40183049>

Reviewed by Tim Horton.

Pass the MIME type of the downloaded asset into the WKWebViewContentProvider's
init method, so it can choose to do something based on that information. The
PDF and LegacyPDF views don't care because they, clearly, only handle PDF. But
a WKSystemPreviewView can handle multiple types.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _setHasCustomContentView:loadedMIMEType:]): Send the MIME type on
to the WKWebViewContentProvider.

  • UIProcess/Cocoa/WKWebViewContentProvider.h: Add a new parameter to web_initWithFrame.
  • UIProcess/ios/WKLegacyPDFView.mm:

(-[WKLegacyPDFView web_initWithFrame:webView:mimeType:]):
(-[WKLegacyPDFView web_initWithFrame:webView:]): Deleted.

  • UIProcess/ios/WKPDFView.mm:

(-[WKPDFView web_initWithFrame:webView:mimeType:]):
(-[WKPDFView web_initWithFrame:webView:]): Deleted.

  • UIProcess/ios/WKSystemPreviewView.mm:

(-[WKSystemPreviewView web_initWithFrame:webView:mimeType:]):
(-[WKSystemPreviewView web_setContentProviderData:suggestedFilename:]): Actually use
the MIME type to tell QuickLook what it will be getting, rather than basing it on
the file extension.
(-[WKSystemPreviewView web_initWithFrame:webView:]): Deleted.

5:39 PM Changeset in webkit [231728] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

Allow the WebContent process to read global ViewBridge preferences
https://bugs.webkit.org/show_bug.cgi?id=185569
<rdar://problem/40164339>

Reviewed by Eric Carlson.

Allow reads of the global /Library/Preferences/com.apple.ViewBridge.plist preference file.

  • WebProcess/com.apple.WebProcess.sb.in:
4:03 PM Changeset in webkit [231727] by BJ Burg
  • 34 edits
    1 copy
    117 adds in trunk/WebDriverTests

Unreviewed. Update W3C WebDriver imported tests.

This includes upstream PR #10968, which has a fix for XSSAuditor
blocking scripts loaded via inline.py. Test expectations for
webkitgtkdriver may need to be updated with progressions and new tests.

  • imported/w3c/importer.json:
  • imported/w3c/tools/webdriver/webdriver/client.py:
  • imported/w3c/tools/wptrunner/requirements_chrome.txt:
  • imported/w3c/tools/wptrunner/requirements_chrome_android.txt: Copied from WebDriverTests/imported/w3c/tools/wptrunner/requirements_opera.txt.
  • imported/w3c/tools/wptrunner/requirements_edge.txt:
  • imported/w3c/tools/wptrunner/requirements_firefox.txt:
  • imported/w3c/tools/wptrunner/requirements_ie.txt:
  • imported/w3c/tools/wptrunner/requirements_opera.txt:
  • imported/w3c/tools/wptrunner/requirements_safari.txt:
  • imported/w3c/tools/wptrunner/requirements_sauce.txt:
  • imported/w3c/tools/wptrunner/wptrunner/browsers/firefox.py:
  • imported/w3c/tools/wptrunner/wptrunner/browsers/sauce.py:
  • imported/w3c/tools/wptrunner/wptrunner/environment.py:
  • imported/w3c/tools/wptrunner/wptrunner/executors/base.py:
  • imported/w3c/tools/wptrunner/wptrunner/executors/executormarionette.py:
  • imported/w3c/tools/wptrunner/wptrunner/formatters.py:
  • imported/w3c/tools/wptrunner/wptrunner/reduce.py:
  • imported/w3c/tools/wptrunner/wptrunner/testrunner.py:
  • imported/w3c/tools/wptrunner/wptrunner/tests/browsers/test_sauce.py: Added.
  • imported/w3c/tools/wptrunner/wptrunner/tests/test_products.py:
  • imported/w3c/tools/wptrunner/wptrunner/wptcommandline.py:
  • imported/w3c/tools/wptrunner/wptrunner/wptrunner.py:
  • imported/w3c/tools/wptrunner/wptrunner/wpttest.py:
  • imported/w3c/webdriver/tests/accept_alert/init.py: Added.
  • imported/w3c/webdriver/tests/accept_alert/accept.py: Added.
  • imported/w3c/webdriver/tests/add_cookie/init.py: Added.
  • imported/w3c/webdriver/tests/add_cookie/add.py: Added.
  • imported/w3c/webdriver/tests/close_window/init.py: Added.
  • imported/w3c/webdriver/tests/close_window/close.py: Added.
  • imported/w3c/webdriver/tests/close_window/user_prompts.py: Added.
  • imported/w3c/webdriver/tests/delete_cookie/init.py: Added.
  • imported/w3c/webdriver/tests/delete_cookie/delete.py: Added.
  • imported/w3c/webdriver/tests/delete_cookie/user_prompts.py: Added.
  • imported/w3c/webdriver/tests/dismiss_alert/init.py: Added.
  • imported/w3c/webdriver/tests/dismiss_alert/dismiss.py: Added.
  • imported/w3c/webdriver/tests/element_clear/init.py: Added.
  • imported/w3c/webdriver/tests/element_clear/clear.py: Added.
  • imported/w3c/webdriver/tests/element_click/bubbling.py:
  • imported/w3c/webdriver/tests/element_click/stale.py:
  • imported/w3c/webdriver/tests/element_send_keys/content_editable.py: Added.
  • imported/w3c/webdriver/tests/element_send_keys/form_controls.py:
  • imported/w3c/webdriver/tests/element_send_keys/interactability.py:
  • imported/w3c/webdriver/tests/element_send_keys/scroll_into_view.py:
  • imported/w3c/webdriver/tests/execute_async_script/collections.py:
  • imported/w3c/webdriver/tests/execute_async_script/user_prompts.py:
  • imported/w3c/webdriver/tests/execute_script/collections.py:
  • imported/w3c/webdriver/tests/execute_script/cyclic.py:
  • imported/w3c/webdriver/tests/execute_script/json_serialize_windowproxy.py: Added.
  • imported/w3c/webdriver/tests/execute_script/user_prompts.py:
  • imported/w3c/webdriver/tests/find_element/init.py: Added.
  • imported/w3c/webdriver/tests/find_element/find.py: Added.
  • imported/w3c/webdriver/tests/find_element_from_element/init.py: Added.
  • imported/w3c/webdriver/tests/find_element_from_element/find.py: Added.
  • imported/w3c/webdriver/tests/find_elements/init.py: Added.
  • imported/w3c/webdriver/tests/find_elements/find.py: Added.
  • imported/w3c/webdriver/tests/find_elements_from_element/init.py: Added.
  • imported/w3c/webdriver/tests/find_elements_from_element/find.py: Added.
  • imported/w3c/webdriver/tests/fullscreen_window/init.py: Added.
  • imported/w3c/webdriver/tests/fullscreen_window/fullscreen.py: Added.
  • imported/w3c/webdriver/tests/fullscreen_window/user_prompts.py: Added.
  • imported/w3c/webdriver/tests/get_active_element/init.py: Added.
  • imported/w3c/webdriver/tests/get_active_element/get.py: Added.
  • imported/w3c/webdriver/tests/get_alert_text/init.py: Added.
  • imported/w3c/webdriver/tests/get_alert_text/get.py: Added.
  • imported/w3c/webdriver/tests/get_current_url/init.py: Added.
  • imported/w3c/webdriver/tests/get_current_url/get.py: Added.
  • imported/w3c/webdriver/tests/get_current_url/user_prompts.py: Added.
  • imported/w3c/webdriver/tests/get_element_attribute/get.py: Added.
  • imported/w3c/webdriver/tests/get_element_property/init.py: Added.
  • imported/w3c/webdriver/tests/get_element_property/get.py: Added.
  • imported/w3c/webdriver/tests/get_element_property/user_prompts.py: Added.
  • imported/w3c/webdriver/tests/get_element_tag_name/init.py: Added.
  • imported/w3c/webdriver/tests/get_element_tag_name/get.py: Added.
  • imported/w3c/webdriver/tests/get_element_tag_name/user_prompts.py: Added.
  • imported/w3c/webdriver/tests/get_element_text/init.py: Added.
  • imported/w3c/webdriver/tests/get_element_text/get.py: Added.
  • imported/w3c/webdriver/tests/get_named_cookie/init.py: Added.
  • imported/w3c/webdriver/tests/get_named_cookie/get.py: Added.
  • imported/w3c/webdriver/tests/get_timeouts/init.py: Added.
  • imported/w3c/webdriver/tests/get_timeouts/get.py: Added.
  • imported/w3c/webdriver/tests/get_title/init.py: Added.
  • imported/w3c/webdriver/tests/get_title/get.py: Added.
  • imported/w3c/webdriver/tests/get_title/user_prompts.py: Added.
  • imported/w3c/webdriver/tests/get_window_rect/init.py: Added.
  • imported/w3c/webdriver/tests/get_window_rect/get.py: Added.
  • imported/w3c/webdriver/tests/get_window_rect/user_prompts.py: Added.
  • imported/w3c/webdriver/tests/is_element_selected/init.py: Added.
  • imported/w3c/webdriver/tests/is_element_selected/selected.py: Added.
  • imported/w3c/webdriver/tests/is_element_selected/user_prompts.py: Added.
  • imported/w3c/webdriver/tests/maximize_window/init.py: Added.
  • imported/w3c/webdriver/tests/maximize_window/maximize.py: Added.
  • imported/w3c/webdriver/tests/maximize_window/user_prompts.py: Added.
  • imported/w3c/webdriver/tests/minimize_window/init.py: Added.
  • imported/w3c/webdriver/tests/minimize_window/minimize.py: Added.
  • imported/w3c/webdriver/tests/minimize_window/user_prompts.py: Added.
  • imported/w3c/webdriver/tests/new_session/init.py: Added.
  • imported/w3c/webdriver/tests/new_session/conftest.py: Added.
  • imported/w3c/webdriver/tests/new_session/create_alwaysMatch.py: Added.
  • imported/w3c/webdriver/tests/new_session/create_firstMatch.py: Added.
  • imported/w3c/webdriver/tests/new_session/default_values.py: Added.
  • imported/w3c/webdriver/tests/new_session/invalid_capabilities.py: Added.
  • imported/w3c/webdriver/tests/new_session/merge.py: Added.
  • imported/w3c/webdriver/tests/new_session/response.py: Added.
  • imported/w3c/webdriver/tests/new_session/support/init.py: Added.
  • imported/w3c/webdriver/tests/new_session/support/create.py: Added.
  • imported/w3c/webdriver/tests/page_source/init.py: Added.
  • imported/w3c/webdriver/tests/page_source/source.py: Added.
  • imported/w3c/webdriver/tests/send_alert_text/init.py: Added.
  • imported/w3c/webdriver/tests/send_alert_text/send.py: Added.
  • imported/w3c/webdriver/tests/set_window_rect/init.py: Added.
  • imported/w3c/webdriver/tests/set_window_rect/resizing_and_positioning.py: Added.
  • imported/w3c/webdriver/tests/set_window_rect/set.py: Added.
  • imported/w3c/webdriver/tests/set_window_rect/user_prompts.py: Added.
  • imported/w3c/webdriver/tests/status/init.py: Added.
  • imported/w3c/webdriver/tests/status/status.py: Added.
  • imported/w3c/webdriver/tests/support/fixtures.py:
  • imported/w3c/webdriver/tests/support/inline.py:
  • imported/w3c/webdriver/tests/switch_to_parent_frame/init.py: Added.
  • imported/w3c/webdriver/tests/switch_to_parent_frame/switch.py: Added.
4:03 PM Changeset in webkit [231726] by Megan Gardner
  • 2 edits in trunk/Source/WebKit

Cleanup canPerformActionForWebView in relation to the webSelectionAssistant being removed
https://bugs.webkit.org/show_bug.cgi?id=185536

Reviewed by Tim Horton.

The _webSelectionAssistant is now always nil, therefor many of these checks are unnecessary.
Remove the check for a webSelection and clean up the logic surrounding those checks.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView canPerformActionForWebView:withSender:]):

4:01 PM Changeset in webkit [231725] by dbates@webkit.org
  • 2 edits in trunk/Source/WebCore

[iOS] Text decoration of dragged content does not paint with opacity
https://bugs.webkit.org/show_bug.cgi?id=185551
<rdar://problem/40166867>

Reviewed by Wenson Hsieh.

Respect alpha when painting the text decoration for dragged content.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::MarkedTextStyle::areDecorationMarkedTextStylesEqual): Consider alpha when
comparing decoration styles for equality so that we do not coalesce styles with differing alpha.
(WebCore::InlineTextBox::paintMarkedTextDecoration): Respect alpha when painting dragged content.

3:47 PM Changeset in webkit [231724] by jmarcell@apple.com
  • 2 edits in branches/safari-606.1.17-branch/Source/WebCore/PAL

Cherry-pick r231721. rdar://problem/39806412

Add CF_NOESCAPE decorators for tvOS and watchOS
https://bugs.webkit.org/show_bug.cgi?id=185560

Reviewed by Dan Bernstein.

  • pal/cf/CoreMediaSoftLink.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

3:30 PM Changeset in webkit [231723] by beidson@apple.com
  • 2 edits in trunk/Source/WebKit

Followup to: Make sure history navigations reuse the existing process when necessary.
https://bugs.webkit.org/show_bug.cgi?id=185532

Reviewed by Andy Estes.

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::processForNavigationInternal): When re-using the same process,

don't change the policy action.

3:19 PM Changeset in webkit [231722] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Test262 Runner should search for the Debug JSC by default
https://bugs.webkit.org/show_bug.cgi?id=185562

Patch by Leo Balter <leonardo.balter@gmail.com> on 2018-05-11
Reviewed by Michael Saboff.

The Test262 Runner is now searching for the Debug build of JSC by
default, not the Release build.

This fix allows a similar call from the previous runner, making
it compatible with the current build bot configuration parameters.

This patch also adds some minor improvements the verbose mode output.

  • Scripts/test262/Runner.pm:

(processCLI):
(main):
(getBuildPath):
(processResult):

3:03 PM Changeset in webkit [231721] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore/PAL

Add CF_NOESCAPE decorators for tvOS and watchOS
https://bugs.webkit.org/show_bug.cgi?id=185560

Reviewed by Dan Bernstein.

  • pal/cf/CoreMediaSoftLink.h:
2:58 PM Changeset in webkit [231720] by n_wang@apple.com
  • 3 edits
    2 adds in trunk

AX: In role=dialog elements with aria-modal=true VoiceOver iOS/macOS can't manually focus or read dialog paragraph description text inside the modal.
https://bugs.webkit.org/show_bug.cgi?id=185219
<rdar://problem/39920009>

Reviewed by Chris Fleizach.

Source/WebCore:

The text node descendants of a modal dialog are ignored. Fixed it by using AccessibilityObject's
node() to determine if it's the descendant of the modal dialog node.

Test: accessibility/aria-modal-text-descendants.html

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::isModalDescendant const):

LayoutTests:

  • accessibility/aria-modal-text-descendants-expected.txt: Added.
  • accessibility/aria-modal-text-descendants.html: Added.
2:16 PM Changeset in webkit [231719] by commit-queue@webkit.org
  • 18 edits
    2 adds in trunk/Source/JavaScriptCore

Unreviewed, rolling out r231316 and r231332.
https://bugs.webkit.org/show_bug.cgi?id=185564

Appears to be a Speedometer2/MotionMark regression (Requested
by keith_miller on #webkit).

Reverted changesets:

"Remove the prototype caching for get_by_id in the LLInt"
https://bugs.webkit.org/show_bug.cgi?id=185226
https://trac.webkit.org/changeset/231316

"Unreviewed, fix 32-bit profile offset for change in bytecode"
https://trac.webkit.org/changeset/231332

1:59 PM Changeset in webkit [231718] by timothy@apple.com
  • 2 edits in trunk/Source/WebKitLegacy/mac

WebHTMLView is not setting aside subviews when drawing.

https://bugs.webkit.org/show_bug.cgi?id=185561
rdar://problem/40172894

Reviewed by Simon Fraser.

Use the new method signature for _recursive:displayRectIgnoringOpacity:shouldChangeFontReferenceColor:.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:shouldChangeFontReferenceColor:stopAtLayerBackedViews:]): Added.

1:39 PM Changeset in webkit [231717] by rniwa@webkit.org
  • 56 edits
    4 adds in trunk

Tapping after CSS-based table casues an infinite loop in wordRangeFromPosition
https://bugs.webkit.org/show_bug.cgi?id=185465
<rdar://problem/35263057>

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Rebaselined the tests. h2

  • web-platform-tests/dom/nodes/getElementsByClassName-30-expected.txt: table is generating a new line as expected.
  • web-platform-tests/html/syntax/parsing/html5lib_menuitem-element-expected.txt: h2 is generating an extra line

to emulate its margin as expected.

  • web-platform-tests/html/syntax/parsing/html5lib_tests11-expected.txt: Ditto.
  • web-platform-tests/html/syntax/parsing/html5lib_tests21-expected.txt: Ditto.
  • web-platform-tests/html/syntax/parsing/html5lib_tests25-expected.txt: Ditto.
  • web-platform-tests/html/syntax/parsing/html5lib_webkit02-expected.txt: Ditto.

Source/WebCore:

The bug was caused by TextIterator not emitting a line break when exiting a CSS-based table when an element
with display: table-row has an invisible text node. Specifically, TextIterator::exitNode is never called on
an element with table-cell: row when m_node is a text node with whitespaces which appears after an element
with display: table-cell.

For example, for a tree structure like:
table-row (R)

table-cell (C)

"text" (1)

" " (2)

Getting out of (C) would result in moving onto (2) without generating a line break for (R).

When this happens in nextBoundary as it tries to find the end of the last word in the table cell, we end up
finding the end of the document as the end of the word. As a result, nextWordBoundaryInDirection, the caller
of nextBoundary, ends up infinite looping between the positon at the end of the document and the position
immediately before the last word in the last table cell when it traverses words backwards.

This patch fixes the hang by addressing this root cause in TextIterator. Namely, TextIterator now generates
a line break when exiting a block while walking up ancestors in TextIterator::advance().

Tests: editing/selection/tapping-in-table-at-end-of-document.html

editing/text-iterator/table-at-end-of-document.html

  • editing/TextIterator.cpp:

(WebCore::TextIterator::advance): Fixed the bug.
(WebCore::shouldEmitNewlineAfterNode): Do generate a new line at the end of a document when we're trying to
generate every visible poitions even there are no renderers beyond this point. e.g. a position inside the
last cell of a table at the end of a document hits this condition.
(WebCore::shouldEmitExtraNewlineForNode): Don't emit a line break when the render box's height is 0px
to avoid generating many empty lines for empty paragraph and header elements (this function is used to generate
a blank line between p's and h1/h2/...'s).
(WebCore::TextIterator::exitNode):

LayoutTests:

Rebaselined the tests. Most of these are due to new extra line breaks being generated after table and
header elements as expected. See inline comments for some newly discovered bugs and rebaselines due to
other non-obvious reasons.

  • accessibility/internal-link-anchors2-expected.txt: This test now demonstrates a bug that WebKit doesn't

generate an extra line break before h3 when it has a large margin-top since an extra line break is only
generated after a node at the moment.

  • accessibility/mac/mathml-elements-expected.txt:
  • accessibility/table-headers-expected.txt:
  • compositing/layer-creation/overlap-transformed-preserved-3d-expected.txt:
  • css3/flexbox/box-orient-button-expected.txt:
  • css3/flexbox/flexitem-expected.txt:
  • editing/execCommand/19087-expected.txt: The second blockquote which has the height of 0px no longer

generates an extra new line.

  • editing/inserting/insert-list-in-table-cell-08-expected.txt: Selection is now being restored properly

using TextIterator in InsertListCommand.

  • editing/selection/tapping-in-table-at-end-of-document-expected.txt: Added.
  • editing/selection/tapping-in-table-at-end-of-document.html: Added.
  • editing/text-iterator/table-at-end-of-document-expected.txt: Added.
  • editing/text-iterator/table-at-end-of-document.html: Added.
  • fast/block/positioning/insert-positioned-in-anonymous-crash-expected.txt:
  • fast/css/css3-ch-unit-expected.txt: Line breaks are generated between block & inline-block elements

as expected.

  • fast/css/percent-min-width-img-src-change-expected.txt:
  • fast/css/percent-width-img-src-change-expected.txt:
  • fast/css/pseudo-empty-display-none-expected.txt:
  • fast/dom/HTMLAnchorElement/anchor-in-noscroll-iframe-crash-expected.txt:
  • fast/dom/HTMLDivElement/align/getset-expected.txt:
  • fast/dom/HTMLSelectElement/listbox-select-reset-expected.txt:
  • fast/dom/HTMLTableElement/table-with-invalid-border-expected.txt:
  • fast/forms/option-mouseevents-expected.txt:
  • fast/history/multiple-classes-visited-expected.txt:
  • fast/history/self-is-visited-expected.txt:
  • fast/html/marquee-reparent-check-expected.txt:
  • fast/inline-block/anonymous-block-crash-expected.txt: This test now demonstrates a bug that we're not

generating an empty line before a block in some cases.

  • fast/inline/inline-position-top-align-expected.txt:
  • fast/invalid/test-case-tr-th-td-should-not-close-dl-list-expected.txt:
  • fast/overflow/scrollbar-click-retains-focus-expected.txt:
  • fast/parser/comments-expected.txt:
  • fast/parser/fragment-parser-doctype-expected.txt:
  • fast/ruby/ruby-base-merge-block-children-crash-2-expected.txt:
  • fast/spatial-navigation/snav-radio-group-expected.txt: A line break is generated after a nested table.
  • fast/sub-pixel/table-cells-have-stable-width-expected.txt:
  • fast/table/table-row-oveflow-crash-expected.txt: A line break is generated after a table as expected,

which is followed by a BR which creates a blank line.

  • fast/table/table-with-borderattr-null-expected.txt:
  • fast/table/table-with-borderattr-set-to-null-expected.txt:
  • fast/text/international/dynamic-text-combine-crash-expected.txt:
  • fast/xsl/mozilla-tests-expected.txt:
  • http/tests/misc/large-js-program-expected.txt:
  • imported/blink/plugins/empty-per-context-data-expected.txt:
  • inspector/console/js-isLikelyStackTrace-expected.txt:
  • inspector/console/js-source-locations-expected.txt:
  • mathml/out-of-flow-in-token-crash-expected.txt:
  • mathml/presentation/stretchy-depth-height-expected.txt:
  • platform/mac/accessibility/table-cells-roles-expected.txt: Line breaks are generated after a block

followed by two two consecutive BRs.

  • platform/mac/accessibility/table-roles-hierarchy-expected.txt: Ditto.
  • svg/foreignObject/fO-fixed-position-crash-expected.txt:
  • tiled-drawing/scrolling/non-fast-region/wheel-handler-region-basic-expected.txt:
  • transforms/3d/hit-testing/coplanar-with-camera-expected.txt:
1:18 PM Changeset in webkit [231716] by dino@apple.com
  • 2 edits in trunk/Source/WebCore

System preview badge doesn't show on <picture> elements
https://bugs.webkit.org/show_bug.cgi?id=185559
<rdar://problem/40150066>

Reviewed by Tim Horton.

We should also identify <img>s that are the child of a <picture>
contained inside the appropriate <a> element.

Tested internally, since the badge is platform specific.

  • html/HTMLImageElement.cpp:

(WebCore::HTMLImageElement::isSystemPreviewImage const): Add logic
to look for <picture> parents.

1:15 PM Changeset in webkit [231715] by Dewei Zhu
  • 3 edits in trunk/Websites/perf.webkit.org

CommitLogViewer._preceedingCommit should not always be null
https://bugs.webkit.org/show_bug.cgi?id=185540

Reviewed by Ryosuke Niwa.

Fix the bug introduced in r227746 that CommitLogViewer._preceedingCommit is always null.

  • browser-tests/index.html: Fix expected measurement-set url.
  • public/v3/components/commit-log-viewer.js:

(CommitLogViewer.prototype._fetchCommitLogs): CommitLogViewer._preceedingCommit should be set
when fetching for preceeding revision succeeds.

12:22 PM Changeset in webkit [231714] by Chris Dumez
  • 13 edits
    2 adds in trunk

REGRESSION (async policy delegate): Revoking an object URL immediately after triggering download breaks file download
https://bugs.webkit.org/show_bug.cgi?id=185531
<rdar://problem/39909589>

Reviewed by Geoffrey Garen.

Source/WebCore:

Whenever we start an asynchronous navigation policy decision for a blob URL, create a temporary
blob URL pointing to the same data, and update the request's URL. This way, if the page's JS revokes
the URL during the policy decision, the load will still succeed.

Test: fast/dom/HTMLAnchorElement/anchor-file-blob-download-then-revoke.html

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::willSendRequest):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadPostRequest):

  • loader/PolicyChecker.cpp:

(WebCore::PolicyChecker::extendBlobURLLifetimeIfNecessary const):
(WebCore::PolicyChecker::checkNavigationPolicy):
(WebCore::PolicyChecker::checkNewWindowPolicy):

  • loader/PolicyChecker.h:

Source/WTF:

Add a default constructor for CompletionHandlerCallingScope, for convenience.

  • wtf/CompletionHandler.h:

LayoutTests:

  • fast/dom/HTMLAnchorElement/anchor-file-blob-download-then-revoke-expected.txt: Added.
  • fast/dom/HTMLAnchorElement/anchor-file-blob-download-then-revoke.html: Added.

Add layout test coverage.

  • platform/ios-wk1/TestExpectations:
  • platform/ios-wk2/TestExpectations:
  • platform/mac-wk1/TestExpectations:
  • platform/win/TestExpectations:
  • platform/wincairo/TestExpectations:

Skip new test on platforms that do not support the download attribute.

12:05 PM Changeset in webkit [231713] by Antti Koivisto
  • 3 edits
    2 adds in trunk

LinkLoader fails to remove CachedResourceClient in some cases
https://bugs.webkit.org/show_bug.cgi?id=185553
<rdar://problem/36879656>

Reviewed by Geoffrey Garen.

Source/WebCore:

Test: http/tests/preload/link-preload-client-remove.html

  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::loadLink):

If there is a link preload already in progress, we fail to clear the client for the ongoing load.
This may leave the CachedResource client map in a bad state.

LayoutTests:

  • http/tests/preload/link-preload-client-remove-expected.txt: Added.
  • http/tests/preload/link-preload-client-remove.html: Added.
11:59 AM Changeset in webkit [231712] by jmarcell@apple.com
  • 2 edits in branches/safari-606.1.17-branch/Source/WebKit

Cherry-pick r231689. rdar://problem/40131741

Fix the build after r231393
https://bugs.webkit.org/show_bug.cgi?id=185519
<rdar://problem/40131741>

  • Configurations/WebKit.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:59 AM Changeset in webkit [231711] by jmarcell@apple.com
  • 4 edits in branches/safari-606.1.17-branch/Source

Cherry-pick r231651. rdar://problem/40131741

Fix the build after r231393
https://bugs.webkit.org/show_bug.cgi?id=185519
<rdar://problem/40131741>

Reviewed by Simon Fraser.

Source/WebCore:

  • Configurations/WebCore.xcconfig:

Source/WTF:

  • wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:39 AM Changeset in webkit [231710] by msaboff@apple.com
  • 3 edits
    1 add in trunk

[DFG] Compiler uses incorrect output register for NumberIsInteger operation
https://bugs.webkit.org/show_bug.cgi?id=185328

Reviewed by Keith Miller.

JSTests:

New regression test.

  • stress/isInteger-doesnt-overwrite-argument.js: Added.

(testIsInteger):

Source/JavaScriptCore:

Fixed a typo from when this code was added in r228968 where resultGPR
was assigned the input register instead of the result.gpr().

  • dfg/DFGSpeculativeJIT64.cpp:

(JSC::DFG::SpeculativeJIT::compile):

11:33 AM Changeset in webkit [231709] by commit-queue@webkit.org
  • 33 edits
    9 adds in trunk

Runtime feature flag for Server-Timing
https://bugs.webkit.org/show_bug.cgi?id=184758

Patch by Charles Vazac <cvazac@gmail.com> on 2018-05-11
Reviewed by Youenn Fablet.

Source/WebCore:

  • Source/WebCore/CMakeLists.txt: Added reference to PerformanceServerTiming.idl.
  • Source/WebCore/DerivedSources.make: Added reference to PerformanceServerTiming.idl.
  • Source/WebCore/Sources.txt: Added reference to PerformanceServerTiming.cpp and JSPerformanceServerTiming.cpp.
  • Source/WebCore/WebCore.xcodeproj/project.pbxproj: Added references to PerformanceServerTiming.cpp, PerformanceServerTiming.h, and PerformanceServerTiming.idl.
  • Source/WebCore/bindings/js/WebCoreBuiltinNames.h: Added PerformanceServerTiming.
  • Source/WebCore/page/PerformanceResourceTiming.h: Added serverTiming member.
  • Source/WebCore/page/PerformanceResourceTiming.idl: Added serverTiming attribute.
  • Source/WebCore/page/PerformanceServerTiming.cpp: Added.
  • Source/WebCore/page/PerformanceServerTiming.h: Added.
  • Source/WebCore/page/PerformanceServerTiming.idl: Added.

Source/WebKit:

  • Shared/WebPreferences.yaml: Added ServerTimingEnabled.
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesGetServerTimingEnabled):

  • UIProcess/API/C/WKPreferencesRefPrivate.h: WK_EXPORT for WKPreferencesSetServerTimingEnabled.
  • WebProcess/Storage/WebSWContextManagerConnection.cpp: Call setServerTimingEnabled.

Source/WebKitLegacy:

  • mac/WebView/WebPreferenceKeysPrivate.h: Added server-timing preference.
  • mac/WebView/WebPreferences.mm:

(WebKit::WebPreferences::serverTimingEnabled):
(WebKit::WebPreferences::setServerTimingEnabled):

  • mac/WebView/WebPreferencesPrivate.h:

(WebKit::WebPreferences::setServerTimingEnabled):
(WebKit::WebPreferences::serverTimingEnabled):

  • mac/WebView/WebView.mm: Set runtime enabled feature based on preference.
  • win/Interfaces/IWebPreferencesPrivate.idl: define serverTimingEnabled and setServerTimingEnabled.
  • win/WebPreferenceKeysPrivate.h: Added server-timing preference.
  • win/WebPreferences.cpp: Initialize server-timing as false and define setter and getter.

(WebKit::WebPreferences::serverTimingEnabled):
(WebKit::WebPreferences::setServerTimingEnabled):

  • win/WebPreferences.h: Define serverTimingEnabled and setServerTimingEnabled.
  • win/WebView.cpp: Set runtime enabled feature based on preference.

Tools:

  • TestWebKitAPI/Configurations/FeatureDefines.xcconfig: added ENABLE_SERVER_TIMING.
  • DumpRenderTree/win/DumpRenderTree.cpp: enable Server Timing

LayoutTests:

  • imported/w3c/resources/import-expectations.json: Import server-timing tests.
  • imported/w3c/web-platform-tests/server-timing/resource_timing_idl.html: Added.
  • imported/w3c/web-platform-tests/server-timing/resource_timing_idl-expected.txt: Added.
  • platform/ios-wk1/TestExpectations: Skip service-worker test.
  • platform/mac-wk1/TestExpectations: Skip service-worker test.
  • platform/win/TestExpectations: Skip service-worker test.
11:11 AM Changeset in webkit [231708] by Antti Koivisto
  • 2 edits in trunk/Source/WebKit

Network process should not stat() all cache files on startup to find their sizes
https://bugs.webkit.org/show_bug.cgi?id=185542
<rdar://problem/40092953>

Reviewed by Chris Dumez.

This is done to compute how much disk space a cache is using. While the operation happens
in a background priority thread it is still quite a bit of work.

Large bodies are saved in separate blob files so record file sizes are capped. We can avoid work by
estimating their size instead of counting it exactly.

  • NetworkProcess/cache/NetworkCacheStorage.cpp:

(WebKit::NetworkCache::estimateRecordsSize):
(WebKit::NetworkCache::Storage::synchronize):

Use size estimation if blob storage is in use.
Remove the code that would delete empty files. Normal cache shrinking handles this.

(WebKit::NetworkCache::Storage::shouldStoreBodyAsBlob):

10:37 AM Changeset in webkit [231707] by Fujii Hironori
  • 5 edits
    1 add in trunk/Tools

[Win][MiniBrowser] Move WK1 related code into MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=185418

Reviewed by Alex Christensen.

All WK1 related code should be moved into MiniBrowser for the preparation
of Bug 184770.

This change moves the initilization code of MiniBrowse into MiniBrowser::init().

  • MiniBrowser/win/Common.cpp:

(getAppDataFolder): Removed static keyword to be called from MiniBrowser.cpp.
(setCacheFolder): This is only for WK1. Moved into MiniBrowser.cpp.

  • MiniBrowser/win/Common.h: Added.
  • MiniBrowser/win/MiniBrowser.cpp:

(MiniBrowser::init): Moved the initilization code from wWinMain.
(MiniBrowser::setCacheFolder): Moved from Common.cpp and made it a method.

  • MiniBrowser/win/MiniBrowser.h:

(MiniBrowser::setCacheFolder): Changed to a private method.
(MiniBrowser::subclassForLayeredWindow): Changed to a private method.

  • MiniBrowser/win/WinMain.cpp:

(wWinMain): Moved MiniBrowse initilization code into MiniBrowser.cpp.

10:29 AM Changeset in webkit [231706] by youenn@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test webrtc/addICECandidate-closed.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=185384
<rdar://problem/40035167>

Reviewed by Eric Carlson.

  • webrtc/addICECandidate-closed.html: Move more pc calls inside the try/catch.

This ensures that the test will be consistent as the pc might be closed sooner for some runs.

10:16 AM Changeset in webkit [231705] by jmarcell@apple.com
  • 7 edits in branches/safari-606.1.17-branch/Source

Versioning.

9:12 AM Changeset in webkit [231704] by beidson@apple.com
  • 17 edits in trunk

Make sure history navigations reuse the existing process when necessary.
<rdar://problem/39746516> and https://bugs.webkit.org/show_bug.cgi?id=185532

Reviewed by Ryosuke Niwa.

Source/WebCore:

Covered by new API tests.

In WebCore-land, make sure *all* NavigationActions to a back/forward item are tagged with
the item identifier.

  • history/HistoryItem.cpp:

(WebCore::HistoryItem::HistoryItem):
(WebCore::HistoryItem::logString const):

  • history/HistoryItem.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadDifferentDocumentItem):

  • loader/NavigationAction.cpp:

(WebCore::NavigationAction::setTargetBackForwardItem):

  • loader/NavigationAction.h:

(WebCore::NavigationAction::targetBackForwardItemIdentifier const):

Source/WebKit:

If a view navigates to either a data: or blob: URL, it reuses the existing process.

In such cases we need to also ensure that history navigations back will also reuse the existing process.

  • Shared/NavigationActionData.cpp:

(WebKit::NavigationActionData::encode const):
(WebKit::NavigationActionData::decode):

  • Shared/NavigationActionData.h:
  • UIProcess/API/APINavigation.h:

(API::Navigation::setTargetItem):

  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.h:
  • UIProcess/API/Cocoa/_WKProcessPoolConfiguration.mm:

(-[_WKProcessPoolConfiguration pageCacheEnabled]):
(-[_WKProcessPoolConfiguration setPageCacheEnabled:]):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::processForNavigationInternal): If the current and target back/forward items both

came from the same process, then reuse the existing process.

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
9:08 AM Changeset in webkit [231703] by sbarati@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Don't use inferred types when the JIT is disabled
https://bugs.webkit.org/show_bug.cgi?id=185539

Reviewed by Yusuke Suzuki.

There are many JSC API clients that run with the JIT disabled. They were
all allocating and tracking inferred types for no benefit. Inferred types
only benefit programs when they make it to the DFG/FTL. I was seeing cases
where the inferred type machinery used ~0.5MB. This patch makes is so we
don't allocate that machinery when the JIT is disabled.

  • runtime/Structure.cpp:

(JSC::Structure::willStoreValueSlow):

  • runtime/Structure.h:
9:01 AM Changeset in webkit [231702] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

REGRESSION(r231057): Encrypted media content playback failures
https://bugs.webkit.org/show_bug.cgi?id=185537
<rdar://problem/40038478>

Reviewed by Eric Carlson.

Put access to the SecurityServer back in the sandbox so we can validate the
signatures of media encoder/decoders.

  • WebProcess/com.apple.WebProcess.sb.in:
6:09 AM Changeset in webkit [231701] by Claudio Saavedra
  • 2 edits in trunk/LayoutTests

[GTK][a11y] Newly added accessibility/scroll-to-make-visible-iframe-offscreen.html fails

Unreviewed gardening. Added the failure.

  • platform/gtk/TestExpectations:
4:38 AM Changeset in webkit [231700] by Claudio Saavedra
  • 2 edits in trunk/LayoutTests

[GTK] media/video-playbackrate.html intermittently crashing
https://bugs.webkit.org/show_bug.cgi?id=185546

Mark thet test, unreviewed gardening.

  • platform/gtk/TestExpectations:
3:50 AM Changeset in webkit [231699] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[EME][GStreamer] Handle the protection event in MediaPlayerPrivate
https://bugs.webkit.org/show_bug.cgi?id=185535

Patch by Yacine Bandou <yacine.bandou_ext@softathome.com> on 2018-05-11
Reviewed by Xabier Rodriguez-Calvar.

This patch is based on this calvaris's commit
https://github.com/WebPlatformForEmbedded/WPEWebKit/commit/d966168b0d2b65f9ca9415426e26d3752c78b03e

It adds a handler for the protection event in MediaPalyerPrivateGStreamerBase, it extracts the InitData from the event
and sends the encrypted event to JS via HTMLMediaElement.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::initializationDataEncountered):
(WebCore::MediaPlayerPrivateGStreamerBase::handleProtectionEvent):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
  • platform/graphics/gstreamer/eme/GStreamerEMEUtilities.h: Add a new type InitData.
3:15 AM Changeset in webkit [231698] by youenn@apple.com
  • 12 edits in trunk/LayoutTests

Rebase some fetch API tests
https://bugs.webkit.org/show_bug.cgi?id=185544

Unreviewed.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/basic/integrity-expected.txt:
  • web-platform-tests/fetch/api/redirect/redirect-count-expected.txt:
  • web-platform-tests/fetch/api/redirect/redirect-count-worker-expected.txt:
  • web-platform-tests/fetch/api/redirect/redirect-location-expected.txt:
  • web-platform-tests/fetch/api/redirect/redirect-location-worker-expected.txt:
  • web-platform-tests/fetch/api/request/request-cache-only-if-cached-expected.txt:
  • web-platform-tests/fetch/http-cache/partial-expected.txt:

LayoutTests:

  • http/tests/fetch/fetching-same-resource-with-different-options-expected.txt:
  • platform/mac/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any-expected.txt:
  • platform/mac/imported/w3c/web-platform-tests/fetch/api/basic/request-headers.any.worker-expected.txt:
1:55 AM Changeset in webkit [231697] by youenn@apple.com
  • 2 edits in trunk/LayoutTests

Skip http/tests/appcache/load-from-appcache-defer-resume-crash.html for iOS sim WK2
https://bugs.webkit.org/show_bug.cgi?id=185430
<rdar://problem/40065118>

Unreviewed.

  • platform/ios-wk2/TestExpectations: Precising the WK1 testRunner API used by the test.
1:31 AM Changeset in webkit [231696] by commit-queue@webkit.org
  • 7 edits in trunk/Source/WebCore

[Curl] Make the cipher suites, the signing algorithms and the curve lists configurable.
https://bugs.webkit.org/show_bug.cgi?id=185139

Add interface to configure the cipher suites, the signing algorithms and the curve lists
used by OpenSSL and libcurl to exchange, to sign or to verify keys.

Patch by Basuke Suzuki <Basuke Suzuki> on 2018-05-11
Reviewed by Youenn Fablet.

No new tests in public. Have tested internally.

  • platform/network/curl/CurlContext.cpp:

(WebCore::CurlHandle::setSslCipherList):

  • platform/network/curl/CurlContext.h:
  • platform/network/curl/CurlRequest.cpp:

(WebCore::CurlRequest::setupTransfer):
(WebCore::CurlRequest::willSetupSslCtx):

  • platform/network/curl/CurlSSLHandle.cpp:

(WebCore::CurlSSLHandle::getCACertPathEnv):

  • platform/network/curl/CurlSSLHandle.h:

(WebCore::CurlSSLHandle::getCipherList const):
(WebCore::CurlSSLHandle::getSignatureAlgorithmsList const):
(WebCore::CurlSSLHandle::getCurvesList const):
(WebCore::CurlSSLHandle::setCipherList):
(WebCore::CurlSSLHandle::setSignatureAlgorithmsList):
(WebCore::CurlSSLHandle::setCurvesList):
(WebCore::CurlSSLHandle::getCACertPath const):
(WebCore::CurlSSLHandle::setCACertPath):

  • platform/network/curl/CurlSSLVerifier.cpp:

(WebCore::CurlSSLVerifier::CurlSSLVerifier):

12:57 AM Changeset in webkit [231695] by sbarati@apple.com
  • 10 edits in trunk/Source

Don't allocate value profiles when the JIT is disabled
https://bugs.webkit.org/show_bug.cgi?id=185525

Reviewed by Michael Saboff.

Source/JavaScriptCore:

There are many JSC API clients that run with the JIT disabled. We were
still allocating a ton of value profiles in this use case even though
these clients get no benefit from doing value profiling. This patch makes
it so that we don't allocate value profiles or argument value profiles
when we're not using the JIT. We now just make all value profiles in
the instruction stream point to a global value profile that the VM owns.
And we make the argument value profile array have zero length and teach
the LLInt how to handle that. Heap clears the global value profile on each GC.

In an app that I'm testing this against, this saves ~1MB of memory.

  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::setNumParameters):

  • bytecode/CodeBlock.h:

(JSC::CodeBlock::numberOfArgumentValueProfiles):
(JSC::CodeBlock::valueProfileForArgument):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitProfiledOpcode):

  • heap/Heap.cpp:

(JSC::Heap::runEndPhase):

  • llint/LowLevelInterpreter.asm:
  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:

Source/WTF:

  • wtf/RefCountedArray.h:

(WTF::RefCountedArray::RefCountedArray):

12:22 AM Changeset in webkit [231694] by youenn@apple.com
  • 2 edits in trunk/Source/WebKit

NetworkCORSPreflightChecker should proceed when having a ProtectionSpaceAuthenticationSchemeServerTrustEvaluationRequested challenge
https://bugs.webkit.org/show_bug.cgi?id=185522
<rdar://problem/39987152>

Reviewed by Brent Fulgham.

In case of such challenge, refuse to proceed with authentication since preflight is not using credentials.
Previously, we were failing right away which is not right in case preflight is the request triggering the connection.

Manually tested.

  • NetworkProcess/NetworkCORSPreflightChecker.cpp:

(WebKit::NetworkCORSPreflightChecker::didReceiveChallenge):

May 10, 2018:

11:56 PM Changeset in webkit [231693] by Carlos Garcia Campos
  • 8 edits in trunk

[JSC][GLIB] Add introspectable alternatives to functions using vargars
https://bugs.webkit.org/show_bug.cgi?id=185508

Reviewed by Michael Catanzaro.

Source/JavaScriptCore:

  • API/glib/JSCClass.cpp:

(jscClassCreateConstructor):
(jsc_class_add_constructor):
(jsc_class_add_constructorv):
(jscClassAddMethod):
(jsc_class_add_method):
(jsc_class_add_methodv):

  • API/glib/JSCClass.h:
  • API/glib/JSCValue.cpp:

(jsObjectCall):
(jscValueCallFunction):
(jsc_value_object_invoke_methodv):
(jscValueFunctionCreate):
(jsc_value_new_function):
(jsc_value_new_functionv):
(jsc_value_function_callv):
(jsc_value_constructor_callv):

  • API/glib/JSCValue.h:
  • API/glib/docs/jsc-glib-4.0-sections.txt:

Tools:

Add test cases for the new API.

  • TestWebKitAPI/Tests/JavaScriptCore/glib/TestJSC.cpp:

(testJSCFunction):
(testJSCObject):

10:34 PM Changeset in webkit [231692] by dbates@webkit.org
  • 12 edits in trunk/Source

Use PlatformStrategies to switch between WebKit and WebKitLegacy checking of CSP frame-ancestors and X-Frame-Options
https://bugs.webkit.org/show_bug.cgi?id=185412

Reviewed by Ryosuke Niwa.

Source/WebCore:

Consolidate the knowledge on how to determine whether security checks were performed on a ResourceResponse
into LoaderStrategy::havePerformedSecurityChecks() (default implementation returns false) and query it
to determine whether CSP frame-ancestors and X-Frame-Options need to be checked for a ResourceResponse.

Additionally, rename LoaderStrategy::isDoingLoadingSecurityChecks() to shouldPerformSecurityChecks()
for consistency with havePerformedSecurityChecks(). Querying shouldPerformSecurityChecks() answers the
question of whether the loader strategy is responsible for performing security checks when building up
a ResourceRequest to have the loader strategy load. And LoaderStrategy::havePerformedSecurityChecks()
is used to determine whether the loader strategy performed these security checks for a given ResourceResponse.

  • inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::didReceiveResponse):
(WebCore::InspectorNetworkAgent::didFinishLoading):
(WebCore::isResponseProbablyComingFromNetworkProcess): Deleted.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::responseReceived):

  • loader/DocumentThreadableLoader.cpp:

(WebCore::shouldPerformSecurityChecks):
(WebCore::DocumentThreadableLoader::shouldSetHTTPHeadersToKeep const):
(WebCore::DocumentThreadableLoader::makeCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::makeSimpleCrossOriginAccessRequest):
(WebCore::DocumentThreadableLoader::redirectReceived):
(WebCore::DocumentThreadableLoader::didFail):
(WebCore::DocumentThreadableLoader::loadRequest):
(WebCore::isDoingSecurityChecksInNetworkProcess): Deleted.
(WebCore::isResponseComingFromNetworkProcess): Deleted.

  • loader/LoaderStrategy.cpp:
  • loader/LoaderStrategy.h:
  • page/Settings.yaml: Remove setting networkProcessCSPFrameAncestorsCheckingEnabled as we now make

use of the loader strategy to determine whether to perform CSP frame-ancestors and X-Frame-Options
checking in DocumentLoader.

  • platform/network/ResourceResponseBase.h:

(WebCore::ResourceResponseBase::setSource): Added an ASSERT to catch the programming error of setting
source to ResourceResponse::Source::Unknown. This source type represents an uninitialized ResourceResponse.

Source/WebKit:

Update code for renaming and write in terms of WebLoaderStrategy::shouldPerformSecurityChecks()
instead of explicitly querying RuntimeEnabledFeatures::sharedFeatures().restrictedHTTPResponseAccess().

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::loadResourceSynchronously):
(WebKit::WebLoaderStrategy::startPingLoad):
(WebKit::WebLoaderStrategy::preconnectTo):
(WebKit::WebLoaderStrategy::shouldPerformSecurityChecks const):
(WebKit::WebLoaderStrategy::havePerformedSecurityChecks const):
(WebKit::WebLoaderStrategy::isDoingLoadingSecurityChecks const): Deleted.

  • WebProcess/Network/WebLoaderStrategy.h:
  • WebProcess/WebPage/WebPage.cpp:
10:30 PM Changeset in webkit [231691] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebCore

Lookup sometimes shows a second yellow highlight on top of WebKit's TextIndicator
https://bugs.webkit.org/show_bug.cgi?id=185538
<rdar://problem/38817825>

Reviewed by Sam Weinig.

  • editing/mac/DictionaryLookup.mm:

(WebCore::showPopupOrCreateAnimationController):
Options can be nil, in which case we can't mutableCopy it and add
LUTermOptionDisableSearchTermIndicator. Instead, create a new dictionary,
and add the items from options, if it's not nil.

10:00 PM Changeset in webkit [231690] by rniwa@webkit.org
  • 2 edits in trunk/LayoutTests

REGRESSION(r227983): fast/dom/adopt-node-crash-2.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=182589

Reviewed by Wenson Hsieh.

This is a speculative fix for the test since I can't reproduce the flakiness locally. Because r227983 makes
the layout update async, I suspect the focus change which occurs to the keygen having autofocus attribute
isn't updating the layout in time for notifyDone call. Manually update the layout before/after the test.

Also wait for the load event to figure before starting the test since layout, etc... may not be updated
immediately after DOMContentLoaded.

  • fast/dom/adopt-node-crash-2.html:
9:41 PM Changeset in webkit [231689] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

Fix the build after r231393
https://bugs.webkit.org/show_bug.cgi?id=185519
<rdar://problem/40131741>

  • Configurations/WebKit.xcconfig:
9:38 PM Changeset in webkit [231688] by Yusuke Suzuki
  • 4 edits in trunk/Source/JavaScriptCore

[JSC] Make return types of construction functions tight
https://bugs.webkit.org/show_bug.cgi?id=185509

Reviewed by Saam Barati.

Array and Object construction functions should return strict types instead of returning JSObject*/JSValue.

  • runtime/ArrayConstructor.cpp:

(JSC::constructArrayWithSizeQuirk):

  • runtime/ArrayConstructor.h:
  • runtime/ObjectConstructor.h:

(JSC::constructEmptyObject):

8:38 PM Changeset in webkit [231687] by Yusuke Suzuki
  • 8 edits
    1 add in trunk

[JSC] Object.assign for final objects should be faster
https://bugs.webkit.org/show_bug.cgi?id=185348

Reviewed by Saam Barati.

JSTests:

  • stress/object-assign-fast-path.js: Added.

(shouldBe):
(checkProperty):

Source/JavaScriptCore:

Object.assign is so heavily used to clone an object. For example, speedometer react-redux can be significantly
improved if Object.assign becomes fast. It is worth adding a complex fast path to accelerate the major use cases.

If enumerating properties of source objects and putting properties to target object are non observable,
we can avoid hash table looking up of source object properties. We can enumerate object property entries,
and put them to target object. This patch adds this fast path to Object.assign implementation.

When enumerating properties, we need to ensure that the given |source| object does not include "proto"
property since we cannot perform fast Put? for the |target| object. We add a new flag
"HasUnderscoreProtoPropertyExcludingOriginalProto" to Structure to track this state.

This improves object-assign.es6 by 1.85x.

baseline patched

object-assign.es6 368.6132+-8.3508 198.8775+-4.9042 definitely 1.8535x faster

And Speedometer2.0 React-Redux-TodoMVC's total time is improved from 490ms to 431ms.

  • runtime/JSObject.h:
  • runtime/JSObjectInlines.h:

(JSC::JSObject::canPerformFastPutInlineExcludingProto):
(JSC::JSObject::canPerformFastPutInline):

  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorAssign):

  • runtime/Structure.cpp:

(JSC::Structure::Structure):

  • runtime/Structure.h:
  • runtime/StructureInlines.h:

(JSC::Structure::forEachProperty):
(JSC::Structure::add):

7:07 PM Changeset in webkit [231686] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[Build Bot] Restore configuration options to the Test262 Runner

During the switch from the previous Test262 runner to the new one,
a call for an extra configurations options got removed.

This call is important to inform the script to find the debug or
release build of JSC. It's being restored in this patch.

https://bugs.webkit.org/show_bug.cgi?id=185513

Patch by Leo Balter <leonardo.balter@gmail.com> on 2018-05-10
Reviewed by Yusuke Suzuki.

  • BuildSlaveSupport/build.webkit.org-config/steps.py:

(RunTest262Tests):

7:00 PM Changeset in webkit [231685] by Michael Catanzaro
  • 1 copy in releases/WPE WebKit/webkit-2.19.93

WPE WebKit 2.19.93

6:59 PM Changeset in webkit [231684] by wilander@apple.com
  • 4 edits in trunk/Source/WebKit

Storage Access API: Extend lifetime of cookies on successful user approval
https://bugs.webkit.org/show_bug.cgi?id=185534
<rdar://problem/40064547>

Reviewed by Brent Fulgham.

  • UIProcess/Cocoa/WebResourceLoadStatisticsStoreCocoa.mm:

(WebKit::WebResourceLoadStatisticsStore::registerUserDefaultsIfNeeded):

Picks up the experimental feature flag.

  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::grantStorageAccessInternal):

Now updates the domain's user interaction timestamp if the user was
prompted for this access.

  • UIProcess/WebResourceLoadStatisticsStore.h:
6:59 PM Changeset in webkit [231683] by Michael Catanzaro
  • 4 edits in releases/WebKitGTK/webkit-2.20

Unreviewed. Update OptionsWPE.cmake and NEWS for 2.19.93 release.

6:58 PM Changeset in webkit [231682] by Michael Catanzaro
  • 5 edits in releases/WebKitGTK/webkit-2.20

Merge r231661 - Fix some -Wstring-op-truncation warnings
https://bugs.webkit.org/show_bug.cgi?id=185496

Reviewed by Alex Christensen.

Source/ThirdParty:

Disable this warning when building gtest.

  • gtest/CMakeLists.txt:

Tools:

We have an off-by-one in the use of strncpy. The strings would not be null-terminated if
the input was too long. Ensure the buffers are zero-initialized so we don't need to manually
set the last bucket to NUL.

  • TestWebKitAPI/Tests/WTF/AtomicString.cpp:

(TestWebKitAPI::testAtomicStringNumber):

  • TestWebKitAPI/Tests/WTF/WTFString.cpp:

(TestWebKitAPI::testStringNumberFixedPrecision):
(TestWebKitAPI::testStringNumberFixedWidth):
(TestWebKitAPI::testStringNumber):

5:58 PM Changeset in webkit [231681] by jmarcell@apple.com
  • 7 edits in tags/Safari-605.3.1.1/Source

Versioning.

5:45 PM Changeset in webkit [231680] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.3.1.1

New tag.

5:42 PM Changeset in webkit [231679] by Jonathan Bedard
  • 5 edits in trunk/Tools

REGRESSION (r230998): Cannot stream API test output
https://bugs.webkit.org/show_bug.cgi?id=185090

Reviewed by Ryosuke Niwa.

Change run-api-tests so that the stdout and stderr of a test will be printed
before it's result. If -v is passed, the output of single test runs will be
streamed.

  • Scripts/webkitpy/api_tests/run_api_tests.py:

(run): Use print_timestamps flag.
(parse_args): Add timestamps option to print timestamps in the log.

  • Scripts/webkitpy/api_tests/runner.py:

(Runner): Add running status.
(Runner.init): Add number of workers and a flag to detect if a newline
is needed at the beginning of a log line.
(Runner.run): Turn off most logging coming from server process since it is
not constructive for API tests.
(Runner.handle): Add new log message to stream stdout and stderr instead of
caching values until the test run finished.
(_Worker._run_single_test): Log stdout and stderr in real time.
(_Worker._run_shard_with_binary): Log stderr and stdout buffer before ending
the test.
(_Worker.post): Provide a post with explicitly enumerated argument names.

  • Scripts/webkitpy/layout_tests/views/metered_stream.py:

(MeteredStream.init): Differentiate verbose logging and logging with timestamps.
(MeteredStream.write): Allow for verbose logging without timestamps.

  • Scripts/webkitpy/layout_tests/views/metered_stream_unittest.py:

(RegularTest): Add print_timestamps flag.
(RegularTest.setUp):
(RegularTest.test_logging_not_included):
(VerboseTest.test_log_args):
(VerboseWithOutTimestamp):
(VerboseWithOutTimestamp.test_basic): Add test for verbose logging without timestamps.

5:23 PM Changeset in webkit [231678] by jmarcell@apple.com
  • 1 copy in tags/Safari-606.1.17.2

Tag Safari-606.1.17.2.

5:06 PM Changeset in webkit [231677] by rniwa@webkit.org
  • 2 edits in trunk/Tools

build-webkit can erroneously warn about Xcode being too old
https://bugs.webkit.org/show_bug.cgi?id=185533

Reviewed by Dan Bernstein.

Don't assume the version number is always a single digit.

  • Scripts/webkitdirs.pm:

(determineXcodeVersion):

4:35 PM Changeset in webkit [231676] by Chris Dumez
  • 4 edits in trunk/Source/WebKit

[iOS] Release page load process assertion if the screen is locked
https://bugs.webkit.org/show_bug.cgi?id=185333

Reviewed by Geoff Garen.

We normally take a background process assertion during page loads to allow them to complete
even if the tab / app is backgrounded. We should however avoid doing so when the backgrounding
is caused by the screen locking. Keeping the process assertion in this case would prevent the
whole device from sleeping longer than it should, thus negatively impacting power.

  • UIProcess/Cocoa/NavigationState.h:
  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationState):
(WebKit::NavigationState::releaseNetworkActivityToken):
(WebKit::NavigationState::didChangeIsLoading):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::applicationDidEnterBackground):

4:18 PM Changeset in webkit [231675] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.3.1

Tag Safari-605.3.1.

4:16 PM Changeset in webkit [231674] by jmarcell@apple.com
  • 1 delete in tags/Safari-605.3.1

Delete tag

4:14 PM Changeset in webkit [231673] by Ross Kirsling
  • 3 edits in trunk/Tools

[WinCairo][Buildbot] Test bots need to acquire WinCairoRequirements.
https://bugs.webkit.org/show_bug.cgi?id=185528

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/build.webkit.org-config/factories.py:

(TestFactory.init):

  • BuildSlaveSupport/build.webkit.org-config/steps.py:

(InstallWinCairoDependencies):

4:14 PM Changeset in webkit [231672] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.3.1

Tag Safari-605.3.1.

4:11 PM Changeset in webkit [231671] by jmarcell@apple.com
  • 1 delete in tags/Safari-605.3.1

Delete tag

4:10 PM Changeset in webkit [231670] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.3.1

Tag Safari-605.3.1.

4:10 PM Changeset in webkit [231669] by jmarcell@apple.com
  • 1 delete in tags/Safari-605.3.1

Delete tag

4:07 PM Changeset in webkit [231668] by jmarcell@apple.com
  • 7 edits in branches/safari-605-branch/Source

Versioning.

4:05 PM Changeset in webkit [231667] by jmarcell@apple.com
  • 1 copy in tags/Safari-605.3.1

Tag Safari-605.3.1.

3:29 PM Changeset in webkit [231666] by commit-queue@webkit.org
  • 147 edits
    35 copies
    14 moves
    198 adds
    9 deletes in trunk/JSTests

Update Test262 tests through the new import script - 20180509
https://bugs.webkit.org/show_bug.cgi?id=185482

Patch by Leo Balter <leonardo.balter@gmail.com> on 2018-05-10
Reviewed by Michael Saboff.

Also update the test262/expecatations.yaml with the recent imported files.

  • test262/expectations.yaml:
  • test262/harness/compareIterator.js: Added.

(assert.compareIterator):

  • test262/harness/nativeFunctionMatcher.js:

(const.assertToStringOrNativeFunction):
(const.assertNativeFunction):

  • test262/harness/regExpUtils.js:
  • test262/harness/testIntl.js:

(getInvalidLanguageTags):

  • test262/harness/testTypedArray.js:
  • test262/harness/wellKnownIntrinsicObjects.js: Added.

(WellKnownIntrinsicObjects.forEach.wkio.catch):

  • test262/latest-changes-summary.txt: Added.
  • test262/test/annexB/language/eval-code/direct/block-decl-nostrict.js: Copied from JSTests/test262/test/language/eval-code/direct/block-decl-strict-caller.js.

(catch):

  • test262/test/annexB/language/eval-code/direct/switch-case-decl-nostrict.js: Copied from JSTests/test262/test/language/eval-code/direct/switch-case-decl-strict-source.js.

(catch):

  • test262/test/annexB/language/eval-code/direct/switch-dflt-decl-nostrict.js: Copied from JSTests/test262/test/language/eval-code/direct/switch-dflt-decl-strict-caller.js.

(catch):

  • test262/test/annexB/language/function-code/block-decl-nested-blocks-with-fun-decl.js: Added.

(g.f):
(g):

  • test262/test/annexB/language/function-code/block-decl-nostrict.js: Copied from JSTests/test262/test/language/function-code/block-decl-strict.js.

(catch):
(f):

  • test262/test/annexB/language/function-code/switch-case-decl-nostrict.js: Copied from JSTests/test262/test/language/function-code/switch-case-decl-strict.js.

(catch):
(switch.case.1):
(switch):

  • test262/test/annexB/language/function-code/switch-dflt-decl-nostrict.js: Copied from JSTests/test262/test/language/function-code/switch-dflt-decl-strict.js.

(catch):
(switch.default):
(switch):

  • test262/test/built-ins/Array/prototype/filter/target-array-with-non-writable-property.js: Added.

(a.Symbol.species):
(r.a.filter):

  • test262/test/built-ins/Array/prototype/indexOf/calls-only-has-on-prototype-after-length-zeroed.js: Added.

(allowProxyTraps.has):
(fromIndex.valueOf):

  • test262/test/built-ins/Array/prototype/lastIndexOf/calls-only-has-on-prototype-after-length-zeroed.js: Added.

(allowProxyTraps.has):
(fromIndex.valueOf):

  • test262/test/built-ins/Array/prototype/map/target-array-with-non-writable-property.js: Added.

(a.Symbol.species):
(r.a.map):

  • test262/test/built-ins/Array/prototype/slice/target-array-with-non-writable-property.js: Added.

(a.Symbol.species):

  • test262/test/built-ins/Array/prototype/splice/property-traps-order-with-species.js: Added.

(a.Symbol.species):

  • test262/test/built-ins/Array/prototype/splice/target-array-with-non-writable-property.js: Added.

(a.Symbol.species):

  • test262/test/built-ins/Atomics/Symbol.toStringTag.js:
  • test262/test/built-ins/Atomics/add/bad-range.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/add/good-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/add/non-views.js:
  • test262/test/built-ins/Atomics/add/nonshared-int-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/add/shared-nonint-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/and/bad-range.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/and/good-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/and/non-views.js:
  • test262/test/built-ins/Atomics/and/nonshared-int-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/and/shared-nonint-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/compareExchange/bad-range.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/compareExchange/good-views.js:

(testWithTypedArrayConstructors):
(view): Deleted.

  • test262/test/built-ins/Atomics/compareExchange/non-views.js:
  • test262/test/built-ins/Atomics/compareExchange/nonshared-int-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/compareExchange/shared-nonint-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/exchange/bad-range.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/exchange/good-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/exchange/non-views.js:
  • test262/test/built-ins/Atomics/exchange/nonshared-int-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/exchange/shared-nonint-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/isLockFree/corner-cases.js:

(hide):

  • test262/test/built-ins/Atomics/isLockFree/value.js:

(testIsLockFree): Deleted.

  • test262/test/built-ins/Atomics/load/bad-range.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/load/good-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/load/non-views.js:
  • test262/test/built-ins/Atomics/load/nonshared-int-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/load/shared-nonint-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/or/bad-range.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/or/good-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/or/non-views.js:
  • test262/test/built-ins/Atomics/or/nonshared-int-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/or/shared-nonint-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/prop-desc.js:
  • test262/test/built-ins/Atomics/proto.js:
  • test262/test/built-ins/Atomics/store/bad-range.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/store/good-views.js:

(testWithTypedArrayConstructors):
(ToInteger):

  • test262/test/built-ins/Atomics/store/non-views.js:
  • test262/test/built-ins/Atomics/store/nonshared-int-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/store/shared-nonint-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/sub/bad-range.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/sub/good-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/sub/non-views.js:
  • test262/test/built-ins/Atomics/sub/nonshared-int-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/sub/shared-nonint-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/wait/bad-range.js: Copied from JSTests/test262/test/built-ins/Atomics/wake/bad-range.js.

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/wait/cannot-suspend-throws.js:
  • test262/test/built-ins/Atomics/wait/did-timeout.js:

(getReport):

  • test262/test/built-ins/Atomics/wait/false-for-timeout-agent.js: Copied from JSTests/test262/test/built-ins/Atomics/wait/false-for-timeout.js.

(getReport):
(262.agent.start.valueOf.valueOf):
(toPrimitive.Symbol.toPrimitive):
(262.agent.receiveBroadcast):

  • test262/test/built-ins/Atomics/wait/false-for-timeout.js:

(valueOf.valueOf):
(toPrimitive.Symbol.toPrimitive):
(getReport): Deleted.
(262.agent.start.262.agent.receiveBroadcast): Deleted.

  • test262/test/built-ins/Atomics/wait/good-views.js:

(r.getReport):
(getReport):

  • test262/test/built-ins/Atomics/wait/nan-for-timeout.js:

(getReport):

  • test262/test/built-ins/Atomics/wait/negative-index-throws.js:
  • test262/test/built-ins/Atomics/wait/negative-timeout-agent.js: Copied from JSTests/test262/test/built-ins/Atomics/wait/negative-timeout.js.

(getReport):
(262.agent.start.262.agent.receiveBroadcast):

  • test262/test/built-ins/Atomics/wait/negative-timeout.js:

(262.agent.start.262.agent.receiveBroadcast): Deleted.
(getReport): Deleted.

  • test262/test/built-ins/Atomics/wait/no-spurious-wakeup.js:

(getReport):

  • test262/test/built-ins/Atomics/wait/non-int32-typedarray-throws.js:
  • test262/test/built-ins/Atomics/wait/non-shared-bufferdata-throws.js: Copied from JSTests/test262/test/built-ins/Atomics/wait/nonshared-bufferdata-throws.js.
  • test262/test/built-ins/Atomics/wait/not-a-typedarray-throws.js:
  • test262/test/built-ins/Atomics/wait/not-an-object-throws.js:
  • test262/test/built-ins/Atomics/wait/null-bufferdata-throws.js:
  • test262/test/built-ins/Atomics/wait/null-for-timeout-agent.js: Copied from JSTests/test262/test/built-ins/Atomics/wait/false-for-timeout.js.

(getReport):
(262.agent.start.valueOf.valueOf):
(toPrimitive.Symbol.toPrimitive):
(262.agent.receiveBroadcast):

  • test262/test/built-ins/Atomics/wait/null-for-timeout.js:

(valueOf.valueOf):
(toPrimitive.Symbol.toPrimitive):
(getReport): Deleted.
(262.agent.start.262.agent.receiveBroadcast): Deleted.

  • test262/test/built-ins/Atomics/wait/object-for-timeout-agent.js: Copied from JSTests/test262/test/built-ins/Atomics/wait/false-for-timeout.js.

(getReport):
(262.agent.start.valueOf.valueOf):
(toString.toString):
(toPrimitive.Symbol.toPrimitive):
(262.agent.receiveBroadcast):

  • test262/test/built-ins/Atomics/wait/object-for-timeout.js:

(valueOf.valueOf):
(toString.toString):
(toPrimitive.Symbol.toPrimitive):
(getReport): Deleted.
(262.agent.start.262.agent.receiveBroadcast): Deleted.

  • test262/test/built-ins/Atomics/wait/out-of-range-index-throws.js:
  • test262/test/built-ins/Atomics/wait/poisoned-object-for-timeout-throws-agent.js: Added.

(getReport):
(262.agent.start.poisonedValueOf.valueOf):
(poisonedToPrimitive.Symbol.toPrimitive):
(262.agent.receiveBroadcast):

  • test262/test/built-ins/Atomics/wait/poisoned-object-for-timeout-throws.js:

(poisonedValueOf.valueOf):
(poisonedToPrimitive.Symbol.toPrimitive):
(getReport): Deleted.
(262.agent.start.262.agent.receiveBroadcast): Deleted.

  • test262/test/built-ins/Atomics/wait/symbol-for-index-throws-agent.js: Added.

(getReport):
(262.agent.start.poisonedValueOf.valueOf):
(poisonedToPrimitive.Symbol.toPrimitive):
(262.agent.receiveBroadcast):

  • test262/test/built-ins/Atomics/wait/symbol-for-index-throws.js:

(poisonedToPrimitive.Symbol.toPrimitive):
(poisoned.valueOf): Deleted.
(poisonedWithString.get valueOf): Deleted.
(poisonedToPrimitive.get Symbol): Deleted.

  • test262/test/built-ins/Atomics/wait/symbol-for-timeout-throws-agent.js: Added.

(getReport):
(262.agent.start.262.agent.receiveBroadcast):

  • test262/test/built-ins/Atomics/wait/symbol-for-timeout-throws.js:

(poisonedValueOf.valueOf):
(poisonedToPrimitive.Symbol.toPrimitive):
(getReport): Deleted.
(262.agent.start.262.agent.receiveBroadcast): Deleted.

  • test262/test/built-ins/Atomics/wait/symbol-for-value-throws-agent.js: Added.

(getReport):
(262.agent.start.poisonedValueOf.valueOf):
(poisonedToPrimitive.Symbol.toPrimitive):
(262.agent.receiveBroadcast):

  • test262/test/built-ins/Atomics/wait/symbol-for-value-throws.js: Added.

(poisonedValueOf.valueOf):
(poisonedToPrimitive.Symbol.toPrimitive):

  • test262/test/built-ins/Atomics/wait/true-for-timeout-agent.js: Copied from JSTests/test262/test/built-ins/Atomics/wait/null-for-timeout.js.

(getReport):
(262.agent.start.valueOf.valueOf):
(toPrimitive.Symbol.toPrimitive):
(262.agent.receiveBroadcast):

  • test262/test/built-ins/Atomics/wait/true-for-timeout.js:

(valueOf.valueOf):
(toPrimitive.Symbol.toPrimitive):
(getReport): Deleted.
(262.agent.start.262.agent.receiveBroadcast): Deleted.

  • test262/test/built-ins/Atomics/wait/undefined-for-timeout.js:

(getReport):

  • test262/test/built-ins/Atomics/wait/undefined-index-defaults-to-zero.js:

(262.agent.start.262.agent.receiveBroadcast):
(getReport):

  • test262/test/built-ins/Atomics/wait/value-not-equal.js: Copied from JSTests/test262/test/built-ins/Atomics/wait/wait-index-value-not-equal.js.

(getReport):
(262.agent.start.262.agent.receiveBroadcast):

  • test262/test/built-ins/Atomics/wait/wait-index-value-not-equal.js:

(262.agent.start.262.agent.receiveBroadcast):

  • test262/test/built-ins/Atomics/wait/waiterlist-block-indexedposition-wake.js: Added.

(getReport):
(262.agent.start.262.agent.receiveBroadcast):

  • test262/test/built-ins/Atomics/wait/waiterlist-order-of-operations-is-fifo.js: Added.

(getReport):
(262.agent.start.262.agent.receiveBroadcast):

  • test262/test/built-ins/Atomics/wait/was-woken-before-timeout.js:

(getReport):
(262.agent.start.262.agent.receiveBroadcast):

  • test262/test/built-ins/Atomics/wait/was-woken.js:

(getReport):
(262.agent.start.262.agent.receiveBroadcast):

  • test262/test/built-ins/Atomics/wake/bad-range.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/wake/count-boundary-cases.js: Renamed from JSTests/test262/test/built-ins/Atomics/wake/counts.js.
  • test262/test/built-ins/Atomics/wake/count-defaults-to-infinity-missing.js: Added.

(getReport):
(262.agent.start.262.agent.receiveBroadcast):

  • test262/test/built-ins/Atomics/wake/count-defaults-to-infinity-undefined.js: Added.

(getReport):
(262.agent.start.262.agent.receiveBroadcast):

  • test262/test/built-ins/Atomics/wake/count-from-nans.js: Added.
  • test262/test/built-ins/Atomics/wake/count-symbol-throws.js: Added.
  • test262/test/built-ins/Atomics/wake/count-tointeger-throws-then-wake-throws.js: Added.

(poisoned.valueOf):

  • test262/test/built-ins/Atomics/wake/good-views.js:
  • test262/test/built-ins/Atomics/wake/negative-count.js: Renamed from JSTests/test262/test/built-ins/Atomics/wake/wake-negative.js.
  • test262/test/built-ins/Atomics/wake/negative-index-throws.js: Copied from JSTests/test262/test/built-ins/Atomics/wait/negative-index-throws.js.

(poisoned.valueOf):

  • test262/test/built-ins/Atomics/wake/non-int32-typedarray-throws.js: Copied from JSTests/test262/test/built-ins/Atomics/wait/non-int32-typedarray-throws.js.

(poisoned.valueOf):

  • test262/test/built-ins/Atomics/wake/non-shared-bufferdata-throws.js: Renamed from JSTests/test262/test/built-ins/Atomics/wait/nonshared-bufferdata-throws.js.

(poisoned.valueOf):

  • test262/test/built-ins/Atomics/wake/non-views.js:
  • test262/test/built-ins/Atomics/wake/nonshared-int-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/wake/not-a-typedarray-throws.js: Copied from JSTests/test262/test/built-ins/Atomics/wait/not-a-typedarray-throws.js.

(poisoned.valueOf):

  • test262/test/built-ins/Atomics/wake/not-an-object-throws.js: Added.

(poisoned.valueOf):

  • test262/test/built-ins/Atomics/wake/null-bufferdata-throws.js: Copied from JSTests/test262/test/built-ins/Atomics/wait/null-bufferdata-throws.js.

(poisoned.valueOf):

  • test262/test/built-ins/Atomics/wake/out-of-range-index-throws.js: Copied from JSTests/test262/test/built-ins/Atomics/wait/out-of-range-index-throws.js.

(poisoned.valueOf):

  • test262/test/built-ins/Atomics/wake/shared-nonint-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/wake/symbol-for-index-throws.js: Added.

(poisonedValueOf.valueOf):
(poisonedToPrimitive.Symbol.toPrimitive):

  • test262/test/built-ins/Atomics/wake/undefined-index-defaults-to-zero.js: Copied from JSTests/test262/test/built-ins/Atomics/wait/undefined-index-defaults-to-zero.js.

(262.agent.start.262.agent.receiveBroadcast):
(getReport):

  • test262/test/built-ins/Atomics/wake/wake-all-on-loc.js:

(262.agent.start.262.agent.receiveBroadcast):
(getReport):
(waitUntil):

  • test262/test/built-ins/Atomics/wake/wake-all.js:

(262.agent.start.262.agent.receiveBroadcast):
(getReport):
(waitUntil):

  • test262/test/built-ins/Atomics/wake/wake-in-order.js:

(getReport):
(waitUntil):

  • test262/test/built-ins/Atomics/wake/wake-nan.js:

(getReport):

  • test262/test/built-ins/Atomics/wake/wake-one.js:

(getReport):
(waitUntil):

  • test262/test/built-ins/Atomics/wake/wake-rewake-noop.js: Added.

(getReport):
(waitUntil):
(262.agent.start.262.agent.receiveBroadcast):

  • test262/test/built-ins/Atomics/wake/wake-two.js:

(getReport):

  • test262/test/built-ins/Atomics/wake/wake-with-no-agents-waiting.js: Added.

(262.agent.start.262.agent.receiveBroadcast):
(waitUntil):

  • test262/test/built-ins/Atomics/wake/wake-with-no-matching-agents-waiting.js: Added.

(262.agent.start.262.agent.receiveBroadcast):
(waitUntil):

  • test262/test/built-ins/Atomics/wake/wake-zero.js:

(i.262.agent.start.262.agent.receiveBroadcast):
(getReport):
(waitUntil):

  • test262/test/built-ins/Atomics/xor/bad-range.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/xor/good-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/xor/non-views.js:
  • test262/test/built-ins/Atomics/xor/nonshared-int-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/Atomics/xor/shared-nonint-views.js:

(testWithTypedArrayConstructors):

  • test262/test/built-ins/BigInt/asIntN/bigint-tobigint-errors.js:
  • test262/test/built-ins/BigInt/asIntN/bigint-tobigint-toprimitive.js:
  • test262/test/built-ins/BigInt/asIntN/bigint-tobigint-wrapped-values.js:
  • test262/test/built-ins/BigInt/asIntN/bits-toindex-errors.js:
  • test262/test/built-ins/BigInt/asIntN/bits-toindex-toprimitive.js:
  • test262/test/built-ins/BigInt/asIntN/bits-toindex-wrapped-values.js:
  • test262/test/built-ins/BigInt/asUintN/bigint-tobigint-errors.js:
  • test262/test/built-ins/BigInt/asUintN/bigint-tobigint-toprimitive.js:
  • test262/test/built-ins/BigInt/asUintN/bigint-tobigint-wrapped-values.js:
  • test262/test/built-ins/BigInt/asUintN/bits-toindex-errors.js:
  • test262/test/built-ins/BigInt/asUintN/bits-toindex-toprimitive.js:
  • test262/test/built-ins/BigInt/asUintN/bits-toindex-wrapped-values.js:
  • test262/test/built-ins/BigInt/constructor-empty-string.js:
  • test262/test/built-ins/BigInt/constructor-from-binary-string.js:
  • test262/test/built-ins/BigInt/constructor-from-decimal-string.js:
  • test262/test/built-ins/BigInt/constructor-from-hex-string.js:
  • test262/test/built-ins/BigInt/constructor-from-octal-string.js:
  • test262/test/built-ins/BigInt/constructor-from-string-syntax-errors.js:
  • test262/test/built-ins/BigInt/constructor-integer.js: Added.
  • test262/test/built-ins/BigInt/constructor-trailing-leading-spaces.js:
  • test262/test/built-ins/BigInt/issafeinteger-true.js: Removed.
  • test262/test/built-ins/BigInt/out-of-bounds-integer-rangeerror.js: Removed.
  • test262/test/built-ins/BigInt/prototype/Symbol.toStringTag.js:
  • test262/test/built-ins/BigInt/prototype/toString/default-radix.js: Added.
  • test262/test/built-ins/BigInt/prototype/toString/thisbigintvalue-not-valid-throws.js:
  • test262/test/built-ins/BigInt/prototype/valueOf/cross-realm.js: Added.
  • test262/test/built-ins/BigInt/tostring-throws.js: Copied from JSTests/test262/test/built-ins/BigInt/value-of-throws.js.
  • test262/test/built-ins/BigInt/valueof-throws.js: Renamed from JSTests/test262/test/built-ins/BigInt/value-of-throws.js.

(BigInt.valueOf):

  • test262/test/built-ins/DataView/prototype/setBigInt64/set-values-return-undefined.js:

(values.forEach):

  • test262/test/built-ins/Function/prototype/bind/length-exceeds-int32.js: Added.

(f):

  • test262/test/built-ins/Function/prototype/toString/anonymous-intrinsics.js: Removed.
  • test262/test/built-ins/Function/prototype/toString/bound-function.js:

(assertNativeFunction):
(let.f): Deleted.

  • test262/test/built-ins/Function/prototype/toString/built-in-function-object.js: Added.
  • test262/test/built-ins/Function/prototype/toString/intrinsics.js: Removed.
  • test262/test/built-ins/Function/prototype/toString/proxy-arrow-function.js: Added.

(assertNativeFunction.new.Proxy):

  • test262/test/built-ins/Function/prototype/toString/proxy-async-function.js: Added.

(assertNativeFunction.new.Proxy.async):

  • test262/test/built-ins/Function/prototype/toString/proxy-async-generator-function.js: Added.

(assertNativeFunction.new.Proxy.async):

  • test262/test/built-ins/Function/prototype/toString/proxy-async-generator-method-definition.js: Added.

(assertNativeFunction.new.Proxy.async.method):
(apply):

  • test262/test/built-ins/Function/prototype/toString/proxy-async-method-definition.js: Added.

(assertNativeFunction.new.Proxy.async.method):
(apply):

  • test262/test/built-ins/Function/prototype/toString/proxy-bound-function.js: Added.

(assertNativeFunction.new.Proxy):
(bind):

  • test262/test/built-ins/Function/prototype/toString/proxy-class.js: Added.

(assertNativeFunction):

  • test262/test/built-ins/Function/prototype/toString/proxy-function-expression.js: Added.

(assertNativeFunction.new.Proxy):

  • test262/test/built-ins/Function/prototype/toString/proxy-generator-function.js: Added.

(assertNativeFunction.new.Proxy):

  • test262/test/built-ins/Function/prototype/toString/proxy-method-definition.js: Added.

(assertNativeFunction.new.Proxy.method):
(apply):

  • test262/test/built-ins/Function/prototype/toString/proxy-non-callable-throws.js: Added.
  • test262/test/built-ins/Function/prototype/toString/proxy.js: Removed.
  • test262/test/built-ins/Function/prototype/toString/well-known-intrinsic-object-functions.js: Added.

(WellKnownIntrinsicObjects.forEach):

  • test262/test/built-ins/JSON/prop-desc.js: Added.
  • test262/test/built-ins/Math/acosh/nan-returns.js:
  • test262/test/built-ins/Math/asinh/asinh-specialVals.js:
  • test262/test/built-ins/Math/atanh/atanh-specialVals.js:
  • test262/test/built-ins/Math/cbrt/cbrt-specialValues.js:
  • test262/test/built-ins/Math/cbrt/prop-desc.js:
  • test262/test/built-ins/Math/cosh/cosh-specialVals.js:
  • test262/test/built-ins/Math/expm1/expm1-specialVals.js:
  • test262/test/built-ins/Math/log10/Log10-specialVals.js:
  • test262/test/built-ins/Math/log2/log2-basicTests.js:
  • test262/test/built-ins/Math/prop-desc.js:
  • test262/test/built-ins/Math/sign/sign-specialVals.js:
  • test262/test/built-ins/Math/sinh/sinh-specialVals.js:
  • test262/test/built-ins/Math/tanh/tanh-specialVals.js:
  • test262/test/built-ins/Math/trunc/trunc-sampleTests.js:
  • test262/test/built-ins/Math/trunc/trunc-specialVals.js:
  • test262/test/built-ins/Object/assign/strings-and-symbol-order.js: Added.
  • test262/test/built-ins/Object/keys/property-traps-order-with-proxied-array.js: Added.

(get t):

  • test262/test/built-ins/Reflect/Reflect.js: Removed.
  • test262/test/built-ins/Reflect/prop-desc.js: Added.
  • test262/test/built-ins/Reflect/properties.js: Removed.
  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/internal-regexp-lastindex-not-zero.js: Added.
  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/isregexp-internal-regexp-is-false.js: Added.
  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/isregexp-internal-regexp-throws.js: Added.
  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/isregexp-this-throws.js: Added.

(obj.get Symbol):

  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/length.js: Added.
  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/name.js: Added.
  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/prop-desc.js: Added.
  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/regexpcreate-this-throws.js: Added.

(obj.toString):

  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/species-constructor-get-constructor-throws.js: Added.
  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/species-constructor-get-species-throws.js: Added.

(regexp.get Symbol):

  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/species-constructor-is-not-object-throws.js: Added.
  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/species-constructor-is-undefined.js: Added.
  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/species-constructor-species-is-not-constructor.js: Added.

(callMatchAll):

  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/species-constructor-species-is-null-or-undefined.js: Added.

(TestWithConstructor):

  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/species-constructor-species-throws.js: Added.

(regexp.Symbol.species):

  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/species-constructor.js: Added.

(regexp.Symbol.species):

  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/species-regexp-get-global-throws.js: Added.

(regexp.Symbol.species):
(get assert):

  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/species-regexp-get-unicode-throws.js: Added.

(regexp.Symbol.species):
(get assert):

  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/string-tostring-throws.js: Added.

(obj.valueOf):
(obj.toString):

  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/string-tostring.js: Added.

(obj.toString):

  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/this-get-flags-throws.js: Added.
  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/this-get-flags.js: Added.
  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/this-lastindex-cached.js: Added.

(regexp.lastIndex.valueOf):

  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/this-not-object-throws.js: Added.

(callMatchAll):

  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/this-tolength-lastindex-throws.js: Added.

(regexp.lastIndex.valueOf):

  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/this-tostring-flags-throws.js: Added.

(value.valueOf):
(value.toString):

  • test262/test/built-ins/RegExp/prototype/Symbol.matchAll/this-tostring-flags.js: Added.

(value.toString):

  • test262/test/built-ins/RegExpStringIteratorPrototype/Symbol.toStringTag.js: Added.
  • test262/test/built-ins/RegExpStringIteratorPrototype/ancestry.js: Added.
  • test262/test/built-ins/RegExpStringIteratorPrototype/next/custom-regexpexec-call-throws.js: Added.

(RegExp.prototype.exec):

  • test262/test/built-ins/RegExpStringIteratorPrototype/next/custom-regexpexec-get-throws.js: Added.
  • test262/test/built-ins/RegExpStringIteratorPrototype/next/custom-regexpexec-match-get-0-throws.js: Added.

(return.get string_appeared_here):
(RegExp.prototype.exec):

  • test262/test/built-ins/RegExpStringIteratorPrototype/next/custom-regexpexec-match-get-0-tostring-throws.js: Added.

(return.toString):
(RegExp.prototype.exec):

  • test262/test/built-ins/RegExpStringIteratorPrototype/next/custom-regexpexec-match-get-0-tostring.js: Added.

(execResult.get string_appeared_here):
(RegExp.prototype.exec):

  • test262/test/built-ins/RegExpStringIteratorPrototype/next/custom-regexpexec-not-callable.js: Added.

(TestWithRegExpExec):

  • test262/test/built-ins/RegExpStringIteratorPrototype/next/custom-regexpexec.js: Added.

(callNextWithExecReturnValue.RegExp.prototype.exec):
(callNextWithExecReturnValue):

  • test262/test/built-ins/RegExpStringIteratorPrototype/next/length.js: Added.
  • test262/test/built-ins/RegExpStringIteratorPrototype/next/name.js: Added.
  • test262/test/built-ins/RegExpStringIteratorPrototype/next/next-iteration-global.js: Added.
  • test262/test/built-ins/RegExpStringIteratorPrototype/next/next-iteration.js: Added.
  • test262/test/built-ins/RegExpStringIteratorPrototype/next/next-missing-internal-slots.js: Added.
  • test262/test/built-ins/RegExpStringIteratorPrototype/next/prop-desc.js: Added.
  • test262/test/built-ins/RegExpStringIteratorPrototype/next/regexp-tolength-lastindex-throws.js: Added.

(RegExp.prototype.exec):

  • test262/test/built-ins/RegExpStringIteratorPrototype/next/this-is-not-object-throws.js: Added.

(callNext):

  • test262/test/built-ins/String/prototype/matchAll/length.js: Added.
  • test262/test/built-ins/String/prototype/matchAll/name.js: Added.
  • test262/test/built-ins/String/prototype/matchAll/prop-desc.js: Added.
  • test262/test/built-ins/String/prototype/matchAll/regexp-get-matchAll-throws.js: Added.
  • test262/test/built-ins/String/prototype/matchAll/regexp-is-null.js: Added.
  • test262/test/built-ins/String/prototype/matchAll/regexp-is-undefined.js: Added.
  • test262/test/built-ins/String/prototype/matchAll/regexp-matchAll-invocation.js: Added.

(obj.Symbol.matchAll):

  • test262/test/built-ins/String/prototype/matchAll/regexp-matchAll-throws.js: Added.

(regexp.Symbol.matchAll):

  • test262/test/built-ins/String/prototype/matchAll/regexp-prototype-get-matchAll-throws.js: Added.
  • test262/test/built-ins/String/prototype/matchAll/regexp-prototype-has-no-matchAll.js: Added.
  • test262/test/built-ins/String/prototype/matchAll/regexp-prototype-matchAll-invocation.js: Added.

(RegExp.prototype.Symbol.matchAll):

  • test262/test/built-ins/String/prototype/matchAll/regexp-prototype-matchAll-throws.js: Added.

(RegExp.prototype.Symbol.matchAll):

  • test262/test/built-ins/String/prototype/matchAll/this-val-non-obj-coercible.js: Added.
  • test262/test/built-ins/Symbol/matchAll/cross-realm.js: Added.
  • test262/test/built-ins/Symbol/matchAll/prop-desc.js: Added.
  • test262/test/harness/testTypedArray.js:
  • test262/test/intl402/Array/prototype/toLocaleString/calls-toLocaleString-number-elements.js: Added.
  • test262/test/intl402/Intl/getCanonicalLocales/invalid-tags.js:
  • test262/test/intl402/Locale/constructor-newtarget-undefined.js: Added.
  • test262/test/intl402/Locale/constructor-options-calendar-invalid.js: Added.

(const.invalidCalendarOption.of.invalidCalendarOptions.new.Intl.Locale):

  • test262/test/intl402/Locale/constructor-options-calendar-valid.js: Added.
  • test262/test/intl402/Locale/constructor-options-language-invalid.js: Added.

(const.invalidLanguageOption.of.invalidLanguageOptions.new.Intl.Locale):

  • test262/test/intl402/Locale/constructor-options-language-valid.js: Added.

(toString):

  • test262/test/intl402/Locale/constructor-options-region-invalid.js: Added.

(const.invalidRegionOption.of.invalidRegionOptions.new.Intl.Locale):

  • test262/test/intl402/Locale/constructor-options-region-valid.js: Added.
  • test262/test/intl402/Locale/constructor-options-script-invalid.js: Added.

(const.invalidScriptOption.of.invalidScriptOptions.new.Intl.Locale):

  • test262/test/intl402/Locale/constructor-options-script-valid.js: Added.

(toString):

  • test262/test/intl402/Locale/function-prototype.js: Added.
  • test262/test/intl402/Locale/instance-extensibility.js: Added.
  • test262/test/intl402/Locale/instance.js: Added.
  • test262/test/intl402/Locale/invalid-tag-throws-boolean.js: Added.
  • test262/test/intl402/Locale/invalid-tag-throws-null.js: Added.
  • test262/test/intl402/Locale/invalid-tag-throws-number.js: Added.
  • test262/test/intl402/Locale/invalid-tag-throws-symbol.js: Added.
  • test262/test/intl402/Locale/invalid-tag-throws-undefined.js: Added.
  • test262/test/intl402/Locale/invalid-tag-throws.js: Added.

(const.invalidTag.of.getInvalidLanguageTags):

  • test262/test/intl402/Locale/length.js: Added.
  • test262/test/intl402/Locale/name.js: Added.
  • test262/test/intl402/Locale/prop-desc.js: Added.
  • test262/test/intl402/Locale/prototype/constructor.js: Added.
  • test262/test/intl402/Locale/prototype/maximize/length.js: Added.
  • test262/test/intl402/Locale/prototype/maximize/name.js: Added.
  • test262/test/intl402/Locale/prototype/maximize/prop-desc.js: Added.
  • test262/test/intl402/Locale/prototype/prop-desc.js: Added.
  • test262/test/intl402/Locale/prototype/toStringTag.js: Added.
  • test262/test/intl402/TypedArray/prototype/toLocaleString/calls-toLocaleString-number-elements.js: Added.

(testWithTypedArrayConstructors):

  • test262/test/language/asi/S7.9_A11_T8.js:

(else.x.1): Deleted.

  • test262/test/language/asi/S7.9_A4.js:

(catch):

  • test262/test/language/asi/S7.9_A5.1_T1.js:
  • test262/test/language/asi/S7.9_A5.3_T1.js:
  • test262/test/language/block-scope/syntax/redeclaration/function-declaration-attempt-to-redeclare-with-var-declaration-nested-in-function.js: Added.

(g.f):
(g):

  • test262/test/language/destructuring/binding/initialization-requires-object-coercible-null.js:
  • test262/test/language/destructuring/binding/initialization-requires-object-coercible-undefined.js:
  • test262/test/language/destructuring/binding/initialization-returns-normal-completion-for-empty-objects.js:
  • test262/test/language/destructuring/binding/syntax/array-elements-with-initializer.js:
  • test262/test/language/destructuring/binding/syntax/array-elements-with-object-patterns.js:
  • test262/test/language/destructuring/binding/syntax/array-elements-without-initializer.js:
  • test262/test/language/destructuring/binding/syntax/array-pattern-with-elisions.js:
  • test262/test/language/destructuring/binding/syntax/array-pattern-with-no-elements.js:
  • test262/test/language/destructuring/binding/syntax/array-rest-elements.js:
  • test262/test/language/destructuring/binding/syntax/object-pattern-with-no-property-list.js:
  • test262/test/language/destructuring/binding/syntax/property-list-bindings-elements.js:
  • test262/test/language/destructuring/binding/syntax/property-list-followed-by-a-single-comma.js:
  • test262/test/language/destructuring/binding/syntax/property-list-single-name-bindings.js:
  • test262/test/language/destructuring/binding/syntax/property-list-with-property-list.js:
  • test262/test/language/destructuring/binding/syntax/recursive-array-and-object-patterns.js:
  • test262/test/language/eval-code/direct/block-decl-eval-source-is-strict-nostrict.js: Copied from JSTests/test262/test/language/eval-code/direct/block-decl-strict-source.js.
  • test262/test/language/eval-code/direct/block-decl-eval-source-is-strict-onlystrict.js: Renamed from JSTests/test262/test/language/eval-code/direct/block-decl-strict-source.js.

(catch):

  • test262/test/language/eval-code/direct/block-decl-onlystrict.js: Renamed from JSTests/test262/test/language/eval-code/direct/block-decl-strict-caller.js.
  • test262/test/language/eval-code/direct/switch-case-decl-eval-source-is-strict-nostrict.js: Renamed from JSTests/test262/test/language/eval-code/direct/switch-case-decl-strict-source.js.
  • test262/test/language/eval-code/direct/switch-case-decl-eval-source-is-strict-onlystrict.js: Copied from JSTests/test262/test/language/eval-code/direct/switch-case-decl-strict-caller.js.

(catch):

  • test262/test/language/eval-code/direct/switch-case-decl-onlystrict.js: Renamed from JSTests/test262/test/language/eval-code/direct/switch-case-decl-strict-caller.js.
  • test262/test/language/eval-code/direct/switch-dflt-decl-eval-source-is-strict-nostrict.js: Renamed from JSTests/test262/test/language/eval-code/direct/switch-dflt-decl-strict-source.js.
  • test262/test/language/eval-code/direct/switch-dflt-decl-eval-source-is-strict-onlystrict.js: Copied from JSTests/test262/test/language/eval-code/direct/switch-dflt-decl-strict-caller.js.

(catch):

  • test262/test/language/eval-code/direct/switch-dflt-decl-onlystrict.js: Renamed from JSTests/test262/test/language/eval-code/direct/switch-dflt-decl-strict-caller.js.
  • test262/test/language/expressions/async-arrow-function/await-as-param-ident-nested-arrow-parameter-position.js: Added.

(async):

  • test262/test/language/expressions/async-arrow-function/await-as-param-nested-arrow-body-position.js: Added.

(async):

  • test262/test/language/expressions/async-arrow-function/await-as-param-nested-arrow-parameter-position.js: Added.

(async.a):

  • test262/test/language/expressions/async-arrow-function/await-as-param-rest-nested-arrow-parameter-position.js: Added.

(async.a):

  • test262/test/language/expressions/async-arrow-function/escaped-async-line-terminator.js: Added.
  • test262/test/language/expressions/async-generator/generator-created-after-decl-inst.js: Added.

(g.async.a):

  • test262/test/language/expressions/class/class-name-ident-await-escaped-module.js: Added.

(C):

  • test262/test/language/expressions/class/class-name-ident-await-escaped.js: Added.

(C):

  • test262/test/language/expressions/class/class-name-ident-await-module.js: Added.

(C):

  • test262/test/language/expressions/class/class-name-ident-await.js: Added.

(C):

  • test262/test/language/expressions/class/class-name-ident-let-escaped.js: Added.

(C):

  • test262/test/language/expressions/class/class-name-ident-let.js: Added.

(C):

  • test262/test/language/expressions/class/class-name-ident-static-escaped.js: Added.

(C):

  • test262/test/language/expressions/class/class-name-ident-static.js: Added.
  • test262/test/language/expressions/class/class-name-ident-yield-escaped.js: Added.

(C):

  • test262/test/language/expressions/class/class-name-ident-yield.js: Added.

(C):

  • test262/test/language/expressions/class/constructor-this-tdz-during-initializers.js: Added.

(Base):
(C):

  • test262/test/language/expressions/class/fields-run-once-on-double-super.js: Added.

(Base):
(C):

  • test262/test/language/expressions/generators/generator-created-after-decl-inst.js: Added.

(g):

  • test262/test/language/expressions/greater-than-or-equal/bigint-and-incomparable-string.js: Added.
  • test262/test/language/expressions/greater-than-or-equal/bigint-and-string.js: Added.
  • test262/test/language/expressions/greater-than/bigint-and-boolean.js: Added.
  • test262/test/language/expressions/greater-than/bigint-and-incomparable-string.js: Added.
  • test262/test/language/expressions/greater-than/bigint-and-string.js: Added.
  • test262/test/language/expressions/less-than-or-equal/bigint-and-incomparable-string.js: Added.
  • test262/test/language/expressions/less-than-or-equal/bigint-and-string.js: Added.
  • test262/test/language/expressions/less-than/bigint-and-boolean.js: Added.
  • test262/test/language/expressions/less-than/bigint-and-incomparable-string.js: Added.
  • test262/test/language/expressions/less-than/bigint-and-string.js: Added.
  • test262/test/language/expressions/object/method-definition/generator-super-prop-param.js:
  • test262/test/language/function-code/block-decl-onlystrict.js: Renamed from JSTests/test262/test/language/function-code/block-decl-strict.js.
  • test262/test/language/function-code/switch-case-decl-onlystrict.js: Renamed from JSTests/test262/test/language/function-code/switch-case-decl-strict.js.
  • test262/test/language/function-code/switch-dflt-decl-onlystrict.js: Renamed from JSTests/test262/test/language/function-code/switch-dflt-decl-strict.js.
  • test262/test/language/line-terminators/S7.3_A2.3.js: Removed.
  • test262/test/language/line-terminators/S7.3_A2.4.js: Removed.
  • test262/test/language/literals/regexp/invalid-optional-lookbehind.js: Copied from JSTests/test262/test/language/literals/regexp/u-invalid-quantifiable-assertion.js.
  • test262/test/language/literals/regexp/invalid-optional-negative-lookbehind.js: Copied from JSTests/test262/test/language/literals/regexp/u-invalid-quantifiable-assertion.js.
  • test262/test/language/literals/regexp/invalid-range-lookbehind.js: Copied from JSTests/test262/test/language/literals/regexp/u-invalid-quantifiable-assertion.js.
  • test262/test/language/literals/regexp/invalid-range-negative-lookbehind.js: Copied from JSTests/test262/test/language/literals/regexp/u-invalid-quantifiable-assertion.js.
  • test262/test/language/literals/regexp/u-invalid-optional-lookahead.js: Copied from JSTests/test262/test/language/literals/regexp/u-invalid-quantifiable-assertion.js.
  • test262/test/language/literals/regexp/u-invalid-optional-lookbehind.js: Copied from JSTests/test262/test/language/literals/regexp/u-invalid-quantifiable-assertion.js.
  • test262/test/language/literals/regexp/u-invalid-optional-negative-lookahead.js: Copied from JSTests/test262/test/language/literals/regexp/u-invalid-quantifiable-assertion.js.
  • test262/test/language/literals/regexp/u-invalid-optional-negative-lookbehind.js: Copied from JSTests/test262/test/language/literals/regexp/u-invalid-quantifiable-assertion.js.
  • test262/test/language/literals/regexp/u-invalid-range-lookahead.js: Copied from JSTests/test262/test/language/literals/regexp/u-invalid-quantifiable-assertion.js.
  • test262/test/language/literals/regexp/u-invalid-range-lookbehind.js: Copied from JSTests/test262/test/language/literals/regexp/u-invalid-quantifiable-assertion.js.
  • test262/test/language/literals/regexp/u-invalid-range-negative-lookahead.js: Copied from JSTests/test262/test/language/literals/regexp/u-invalid-quantifiable-assertion.js.
  • test262/test/language/literals/regexp/u-invalid-range-negative-lookbehind.js: Renamed from JSTests/test262/test/language/literals/regexp/u-invalid-quantifiable-assertion.js.
  • test262/test/language/literals/string/line-separator-eval.js: Added.
  • test262/test/language/literals/string/line-separator.js: Added.
  • test262/test/language/literals/string/paragraph-separator-eval.js: Added.
  • test262/test/language/literals/string/paragraph-separator.js: Added.
  • test262/test/language/module-code/early-strict-mode.js:
  • test262/test/language/statements/async-generator/generator-created-after-decl-inst.js: Added.

(async.g):

  • test262/test/language/statements/break/S12.8_A8_T1.js:

(catch):

  • test262/test/language/statements/break/S12.8_A8_T2.js:

(catch):

  • test262/test/language/statements/class/class-name-ident-await-escaped-module.js: Added.

(aw):

  • test262/test/language/statements/class/class-name-ident-await-escaped.js: Added.

(aw):

  • test262/test/language/statements/class/class-name-ident-await-module.js: Added.

(await):

  • test262/test/language/statements/class/class-name-ident-await.js: Added.

(await):

  • test262/test/language/statements/class/class-name-ident-let-escaped.js: Added.

(l):

  • test262/test/language/statements/class/class-name-ident-let.js: Added.

(let):

  • test262/test/language/statements/class/class-name-ident-static-escaped.js: Added.

(st):

  • test262/test/language/statements/class/class-name-ident-static.js: Added.
  • test262/test/language/statements/class/class-name-ident-yield-escaped.js: Added.

(yi):

  • test262/test/language/statements/class/class-name-ident-yield.js: Added.

(yield):

  • test262/test/language/statements/continue/S12.7_A8_T1.js:

(catch):

  • test262/test/language/statements/continue/S12.7_A8_T2.js:

(catch):

  • test262/test/language/statements/generators/generator-created-after-decl-inst.js: Added.

(g):

  • test262/test/language/statements/try/early-catch-duplicates.js:
  • test262/test/language/statements/try/early-catch-function.js: Added.

(f.catch.e):
(f):

  • test262/test/language/statements/try/early-catch-lex.js:
  • test262/test/language/statements/try/early-catch-var.js:
  • test262/test262-Revision.txt:
3:23 PM Changeset in webkit [231665] by fpizlo@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

DFG CFA should pick the right time to inject OSR entry data
https://bugs.webkit.org/show_bug.cgi?id=185530

Reviewed by Saam Barati.

Previously, we would do a bonus run of CFA to inject OSR entry data. This patch makes us inject
OSR entry data as part of the normal flow of CFA, which reduces the total number of CFA
reexecutions while minimizing the likelihood that we have CFA execute constants in paths that
would eventually LUB to non-constant.

This looks like almost a 1% speed-up on SunSpider-CompileTime. All of the logic for preventing
execution over constants is for V8Spider-CompileTime/regexp, which would otherwise do a lot of
useless regexp/string execution in the compiler.

  • dfg/DFGBlockSet.h:

(JSC::DFG::BlockSet::remove):

  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::run):
(JSC::DFG::CFAPhase::injectOSR):
(JSC::DFG::CFAPhase::performBlockCFA):

3:06 PM Changeset in webkit [231664] by Megan Gardner
  • 5 edits in trunk/Source/WebKit

Remove Unused Chinese/Japanese Reanalyze code
https://bugs.webkit.org/show_bug.cgi?id=185529

Reviewed by Wenson Hsieh.

The code for this has actually been completely removed from UIKit. This is unreachable
dead code that should be removed if just for cleanliness.

  • Platform/spi/ios/UIKitSPI.h:
  • UIProcess/API/Cocoa/WKWebViewInternal.h:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView _reanalyzeForWebView:]): Deleted.

3:02 PM Changeset in webkit [231663] by Chris Dumez
  • 3 edits in trunk

[iOS] Apps that are not visible may not get suspended if they trigger page loads while in the background
https://bugs.webkit.org/show_bug.cgi?id=185318

Reviewed by Geoffrey Garen.

Whenever there is a page load going on, we take a background process assertion to delay process
suspension until this load completes. However, there is also a 3 seconds grace period after
a load is complete to allow the app to trigger a new load shortly after. This grace period was
introduced to support use cases where a visible app does loads in an offscreen view. However,
it can be abused by apps running in the background as they could trigger new page loads while
in the background to delay process suspension. This patch tightens the policy so that only
apps that are currently visible get to use this grace period. Apps that are in the background
get to finish their current load and will then get suspended.

  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::didChangeIsLoading):

2:56 PM Changeset in webkit [231662] by Wenson Hsieh
  • 5 edits in trunk/LayoutTests

[Extra zoom mode] fast/visual-viewport/extrazoom/layout-viewport-after-scrolling-and-resizing.html sometimes fails
https://bugs.webkit.org/show_bug.cgi?id=185517
<rdar://problem/40112983>

Reviewed by Tim Horton.

Adjusts some existing layout tests — see below for more detail.

  • fast/css/extrazoom/viewport-units-shrink-to-fit.html:

Remove calls to wait for the next presentation update which are no longer necessary after r231606.

  • fast/viewport/extrazoom/viewport-change-min-device-width.html:

Wait for the next visible content rect update, when the unobscured content rect is guaranteed to be up to date.

  • fast/visual-viewport/extrazoom/layout-viewport-after-scrolling-and-resizing.html:

Wait for the next visible content rect update rather than the next presentation update (i.e. remote layer tree
commit). This is because the layout viewport's custom fixed position rect is propagated in the visible content
rect update flow, and ensuring a presentation update is insufficient to guarantee that the layout viewport is up
to date.

  • resources/ui-helper.js:

(window.UIHelper.ensureVisibleContentRectUpdate):

Add a new test helper to wait for the next presentation update.

2:46 PM Changeset in webkit [231661] by Michael Catanzaro
  • 5 edits in trunk

Fix some -Wstring-op-truncation warnings
https://bugs.webkit.org/show_bug.cgi?id=185496

Reviewed by Alex Christensen.

Source/ThirdParty:

Disable this warning when building gtest.

  • gtest/CMakeLists.txt:

Tools:

We have an off-by-one in the use of strncpy. The strings would not be null-terminated if
the input was too long. Ensure the buffers are zero-initialized so we don't need to manually
set the last bucket to NUL.

  • TestWebKitAPI/Tests/WTF/AtomicString.cpp:

(TestWebKitAPI::testAtomicStringNumber):

  • TestWebKitAPI/Tests/WTF/WTFString.cpp:

(TestWebKitAPI::testStringNumberFixedPrecision):
(TestWebKitAPI::testStringNumberFixedWidth):
(TestWebKitAPI::testStringNumber):

2:31 PM Changeset in webkit [231660] by fpizlo@apple.com
  • 6 edits in trunk/Source/JavaScriptCore

InPlaceAbstractState::beginBasicBlock shouldn't copy all m_variables every time
https://bugs.webkit.org/show_bug.cgi?id=185452

Reviewed by Michael Saboff.

We were spending a lot of time in beginBasicBlock() just copying the state of all variables
from the block head to InPlaceAbstractState::m_variables. It is necessary for
InPlaceAbstractState to have its own copy since we need to mutate it separately from
block->valuesAtHead. But most variables are untouched by most basic blocks, so this was a lot
of superfluous work.

This change adds a bitvector called m_activeVariables that tracks which variables have been
copied. We lazily copy the variables on first use. Variables that were never copied also have
a simplified merging path, which just needs to consider if the variable got clobbered between
head and tail.

This is a 1.5% speed-up on SunSpider-CompileTime and a 1.7% speed-up on V8Spider-CompileTime.

  • bytecode/Operands.h:

(JSC::Operands::argumentIndex const):
(JSC::Operands::localIndex const):
(JSC::Operands::argument):
(JSC::Operands::argument const):
(JSC::Operands::local):
(JSC::Operands::local const):
(JSC::Operands::operandIndex const):

  • dfg/DFGAbstractValue.h:

(JSC::DFG::AbstractValue::fastForwardFromTo):

  • dfg/DFGCFAPhase.cpp:

(JSC::DFG::CFAPhase::performForwardCFA):

  • dfg/DFGInPlaceAbstractState.cpp:

(JSC::DFG::InPlaceAbstractState::beginBasicBlock):
(JSC::DFG::InPlaceAbstractState::variablesForDebugging):
(JSC::DFG::InPlaceAbstractState::activateAllVariables):
(JSC::DFG::InPlaceAbstractState::endBasicBlock):
(JSC::DFG::InPlaceAbstractState::activateVariable):
(JSC::DFG::InPlaceAbstractState::mergeStateAtTail): Deleted.

  • dfg/DFGInPlaceAbstractState.h:

(JSC::DFG::InPlaceAbstractState::variableAt):
(JSC::DFG::InPlaceAbstractState::operand):
(JSC::DFG::InPlaceAbstractState::local):
(JSC::DFG::InPlaceAbstractState::argument):
(JSC::DFG::InPlaceAbstractState::activateVariableIfNecessary):
(JSC::DFG::InPlaceAbstractState::variablesForDebugging): Deleted.

1:59 PM Changeset in webkit [231659] by Matt Baker
  • 9 edits in trunk

Web Inspector: ASSERT_NOT_REACHED in PageDebuggerAgent::didAddEventListener when page adds attribute event listener
https://bugs.webkit.org/show_bug.cgi?id=181580
<rdar://problem/36461309>

Reviewed by Brian Burg.

Source/WebCore:

EventTarget should pass newly added EventListeners to InspectorInstrumentation,
instead of PageDebuggerAgent assuming the last item in the EventListenerVector
is the most recently added listener. This assumption does not hold when
the new listener replaces an existing listener.

  • dom/EventTarget.cpp:

(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::setAttributeEventListener):

  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::didAddEventListenerImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::didAddEventListener):

  • inspector/agents/page/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::didAddEventListener):

  • inspector/agents/page/PageDebuggerAgent.h:

LayoutTests:

Add new test covering the case where adding an attribute event listener
causes an existing attribute event listener to be replaced.

  • inspector/debugger/async-stack-trace-expected.txt:
  • inspector/debugger/async-stack-trace.html:
1:54 PM Changeset in webkit [231658] by Fujii Hironori
  • 5 edits in trunk/Tools

[Win][MiniBrowser] Add a separate WndProc for the layered window
https://bugs.webkit.org/show_bug.cgi?id=185460

Reviewed by Brent Fulgham.

All WK1 related code should be moved into MiniBrowser for the
preparation of Bug 184770.

The layered window was using WndProc of the main window. The
layered window is specific only for WK1. the main window will be
shared among WK1 and WK2.

This change add a new WndProc for the layer window.

  • MiniBrowser/win/Common.cpp:

(WndProc): Removed code for the layered windows.
(subclassForLayeredWindow): Moved into MiniBrowser.cpp.

  • MiniBrowser/win/MiniBrowser.cpp:

(MiniBrowser::prepareViews): Removed the fourth argument viewHwnd.
(viewWndProc): New WndProc for the layered windows.
(MiniBrowser::subclassForLayeredWindow): Moved from Common.cpp.

  • MiniBrowser/win/MiniBrowser.h:

(MiniBrowser::hwnd):

  • MiniBrowser/win/WinMain.cpp:

(wWinMain): Added m_viewWnd.

1:43 PM Changeset in webkit [231657] by jmarcell@apple.com
  • 3 edits in branches/safari-606.1.17-branch/Source/WebKitLegacy/win

Cherry-pick r231635. rdar://problem/39664620

REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
https://bugs.webkit.org/show_bug.cgi?id=185505

Unreviewed serious crash fix

Windows port crashes soon since Bug 184996.

  • WebPreferences.cpp: (WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.
  • WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:43 PM Changeset in webkit [231656] by jmarcell@apple.com
  • 2 edits in branches/safari-606.1.17-branch/Tools

Cherry-pick r231625. rdar://problem/39664620

Unreviewed Windows build fix after r231622.

  • DumpRenderTree/win/DumpRenderTree.cpp: (enableExperimentalFeatures):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:43 PM Changeset in webkit [231655] by jmarcell@apple.com
  • 37 edits
    13 adds in branches/safari-606.1.17-branch

Cherry-pick r231622. rdar://problem/39664620

Add initial support for 'Cross-Origin-Options' HTTP response header
https://bugs.webkit.org/show_bug.cgi?id=184996
<rdar://problem/39664620>

Reviewed by Geoff Garen.

Source/WebCore:

Add initial support for 'Cross-Origin-Options' HTTP response header behind an experimental
feature flag, on by default. When the HTTP server services this HTTP response header for a
main resource, we'll set these options on the corresponding Document. This will impact the
behavior of the Document's associated Window API when cross-origin.

The HTTP header has 3 possible values:

  • allow: This is the default. Regular cross-origin Window API is available.
  • allow-postmessage: Only postMessage() is available on a cross-origin window, trying to access anything else will throw a SecurityError.
  • deny: Trying to do anything with a cross-origin window will throw a SecurityError.

The header has no effect when accessing same origin windows.

Note that on cross-origin access from Window A to Window B, we check the cross-origin
options for both Window A and Window B and use the lowest common denominator as effective
cross-origin options for the access. So if Window A has 'Cross-Origin-Options: deny' and
tries to call postMessage() on Window B which has 'Cross-Origin-Options: allow-postmessage',
we will throw a SecurityError. This is because Window A's more restrictive options (deny)
apply.

Tests: http/wpt/cross-origin-options/allow-postmessage-from-deny.html

http/wpt/cross-origin-options/allow-postmessage.html
http/wpt/cross-origin-options/cross-origin-options-header.html

  • bindings/js/JSDOMBindingSecurity.cpp: (WebCore::BindingSecurity::shouldAllowAccessToDOMWindowGivenMinimumCrossOriginOptions):
  • bindings/js/JSDOMBindingSecurity.h:
  • bindings/js/JSDOMWindowCustom.cpp: (WebCore::effectiveCrossOriginOptionsForAccess): (WebCore::jsDOMWindowGetOwnPropertySlotRestrictedAccess): (WebCore::JSDOMWindow::getOwnPropertySlot): (WebCore::JSDOMWindow::getOwnPropertySlotByIndex): (WebCore::addCrossOriginWindowPropertyNames): (WebCore::addScopedChildrenIndexes): (WebCore::addCrossOriginWindowOwnPropertyNames): (WebCore::JSDOMWindow::getOwnPropertyNames):
  • bindings/js/JSDOMWindowCustom.h:
  • bindings/js/JSRemoteDOMWindowCustom.cpp: (WebCore::JSRemoteDOMWindow::getOwnPropertySlot): (WebCore::JSRemoteDOMWindow::getOwnPropertySlotByIndex): (WebCore::JSRemoteDOMWindow::getOwnPropertyNames):
  • bindings/scripts/CodeGeneratorJS.pm: (GenerateAttributeGetterBodyDefinition): (GetCrossOriginsOptionsFromExtendedAttributeValue): (GenerateAttributeSetterBodyDefinition): (GenerateOperationBodyDefinition):
  • bindings/scripts/IDLAttributes.json:
  • dom/Document.cpp: (WebCore::Document::setCrossOriginOptions):
  • dom/Document.h: (WebCore::Document::crossOriginOptions const):
  • loader/FrameLoader.cpp: (WebCore::FrameLoader::didBeginDocument):
  • page/AbstractDOMWindow.cpp: (WebCore::AbstractDOMWindow::AbstractDOMWindow):
  • page/AbstractDOMWindow.h: (WebCore::AbstractDOMWindow::crossOriginOptions): (WebCore::AbstractDOMWindow::setCrossOriginOptions):
  • page/DOMWindow.cpp: (WebCore::DOMWindow::DOMWindow): (WebCore::DOMWindow::didSecureTransitionTo):
  • page/DOMWindow.idl:
  • page/Frame.h:
  • page/RemoteDOMWindow.cpp: (WebCore::RemoteDOMWindow::RemoteDOMWindow):
  • page/RemoteDOMWindow.h:
  • page/Settings.yaml:
  • platform/network/HTTPHeaderNames.in:
  • platform/network/HTTPParsers.cpp: (WebCore::parseCrossOriginOptionsHeader):
  • platform/network/HTTPParsers.h:

Source/WebKit:

  • Shared/WebPreferences.yaml: Add this as an experimental feature, on by default.
  • WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::frameBecameRemote): Make sure we pass the cross-origin options from the local Window to the remote one when transitioning.

LayoutTests:

Add layout test coverage.

  • http/wpt/cross-origin-options/allow-postmessage-expected.txt: Added.
  • http/wpt/cross-origin-options/allow-postmessage-from-deny-expected.txt: Added.
  • http/wpt/cross-origin-options/allow-postmessage-from-deny.html: Added.
  • http/wpt/cross-origin-options/allow-postmessage-from-deny.html.headers: Added.
  • http/wpt/cross-origin-options/allow-postmessage.html: Added.
  • http/wpt/cross-origin-options/cross-origin-options-header-expected.txt: Added.
  • http/wpt/cross-origin-options/cross-origin-options-header.html: Added.
  • http/wpt/cross-origin-options/resources/cross-origin-options-allow-postmessage-pong.html: Added.
  • http/wpt/cross-origin-options/resources/cross-origin-options-allow-postmessage-pong.html.headers: Added.
  • http/wpt/cross-origin-options/resources/serve-cross-origin-options-header.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@231622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:42 PM Changeset in webkit [231654] by Chris Dumez
  • 15 edits in trunk

'Cross-Origin-Options header implementation follow-up
https://bugs.webkit.org/show_bug.cgi?id=185520

Reviewed by Ryosuke Niwa.

Source/WebCore:

  • dom/Document.cpp:
  • dom/Document.h:
  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::didBeginDocument):
Using isNull() check is sufficient here as the header parsing
function will do the right thing when passed the empty string.
Also set the options directly on the window instead of the
document. The window is guaranteed to have been constructed
by then because didBeginDocument() is called DocumentWriter::begin()
which calls Document::createDOMWindow() or Document::takeDOMWindowFrom().

  • page/AbstractDOMWindow.cpp:

(WebCore::AbstractDOMWindow::AbstractDOMWindow):

  • page/AbstractDOMWindow.h:
  • page/DOMWindow.cpp:

(WebCore::DOMWindow::DOMWindow):
(WebCore::DOMWindow::didSecureTransitionTo):

  • page/RemoteDOMWindow.cpp:

(WebCore::RemoteDOMWindow::RemoteDOMWindow):

  • page/RemoteDOMWindow.h:

CrossOriginOptions are now stored only on the Window, not the Document.

  • platform/network/HTTPParsers.cpp:

(WebCore::parseCrossOriginOptionsHeader):
Drop strippedHeader local variable as it is not strictly needed.

Source/WebKit:

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::frameBecameRemote):

LayoutTests:

Extend layout testing to cover mixed case, multiple values and no value.

  • http/wpt/cross-origin-options/cross-origin-options-header-expected.txt:
  • http/wpt/cross-origin-options/cross-origin-options-header.html:
12:38 PM Changeset in webkit [231653] by pvollan@apple.com
  • 2 edits in trunk/Source/WebKit

Drop-down Control borders missing.
https://bugs.webkit.org/show_bug.cgi?id=185500
<rdar://problem/40093461>

Reviewed by Brent Fulgham.

Open sandbox for reading of some files in temp folder.

  • WebProcess/com.apple.WebProcess.sb.in:
12:11 PM Changeset in webkit [231652] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

Support --verbose in run-javascriptcore-tests
https://bugs.webkit.org/show_bug.cgi?id=185492

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2018-05-10
Reviewed by Daniel Bates.

  • Scripts/run-javascriptcore-tests:

(runJSCStressTests):

11:54 AM Changeset in webkit [231651] by timothy_horton@apple.com
  • 4 edits in trunk/Source

Fix the build after r231393
https://bugs.webkit.org/show_bug.cgi?id=185519
<rdar://problem/40131741>

Reviewed by Simon Fraser.

Source/WebCore:

  • Configurations/WebCore.xcconfig:

Source/WTF:

  • wtf/Platform.h:
11:48 AM Changeset in webkit [231650] by Michael Catanzaro
  • 14 edits in releases/WebKitGTK/webkit-2.20

[WPE][Stable] Remove unusable JavaScript APIs

There is no JSC API provided with WPE 2.20. We don't want to expose the old C API, because
that is going to be obsolete in 2.22. And backporting the new GObject API to this branch
would be inappropriate.

This means that we need to remove WebKitJavascriptResult.

Reviewed by Carlos Alberto Lopez Perez.

11:36 AM Changeset in webkit [231649] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebKit

[MediaStream, iOS] Don't check authorizationStatusForMediaType when using mock capture devices
https://bugs.webkit.org/show_bug.cgi?id=185516
<rdar://problem/36328191>

Reviewed by Youenn Fablet.

  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest): Don't check
+[AVCaptureDevice authorizationStatusForMediaType:] when using mock capture devices.

11:31 AM Changeset in webkit [231648] by Brent Fulgham
  • 4 edits in trunk/Source/WebKit

REGRESSION(r230323): UIProcess needs to notify WebContent process of Accessibility setting changes
https://bugs.webkit.org/show_bug.cgi?id=185515
<rdar://problem/39627764>

Reviewed by Chris Fleizach.

The UIProcess needs to register for relevant Accessibility preference updates so that it can notify the
WebContent processes that screen properties have changed.

This is represented by NSWorkspaceAccessibilityDisplayOptionsDidChangeNotification.

Tested manually with the Accessibility preferences pane.

  • UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::registerNotificationObservers): Add notification observer. When the notification
is received, call 'screenPropertiesStateChanged' to message the information to the WebContent processes.
(WebKit::WebProcessPool::unregisterNotificationObservers): Clean up observer.

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::screenPropertiesStateChanged): Added helper function.

  • UIProcess/WebProcessPool.h:
10:58 AM Changeset in webkit [231647] by Ross Kirsling
  • 3 edits in trunk/LayoutTests

[WinCairo] Unreviewed gardening.

  • platform/wincairo/TestExpectations:
  • platform/wincairo/editing/deleting/delete-emoji-expected.txt:
10:43 AM Changeset in webkit [231646] by jmarcell@apple.com
  • 6 edits in branches/safari-605-branch

Cherry-pick r226610. rdar://problem/39987479

Add WKNavigationDelegate SPI exposing WebProcess crash reason
https://bugs.webkit.org/show_bug.cgi?id=181410
<rdar://problem/36167199>

Reviewed by Wenson Hsieh.

Source/WebKit:

We exposed it in the C SPI.

  • UIProcess/API/Cocoa/WKNavigationDelegatePrivate.h:
  • UIProcess/Cocoa/NavigationState.h:
  • UIProcess/Cocoa/NavigationState.mm: (WebKit::NavigationState::setNavigationDelegate): (WebKit::toWKProcessTerminationReason): (WebKit::NavigationState::NavigationClient::processDidTerminate):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/Navigation.mm: (-[CrashReasonDelegate _webView:webContentProcessDidTerminateWithReason:]): (TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@226610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:43 AM Changeset in webkit [231645] by jmarcell@apple.com
  • 11 edits
    1 add in branches/safari-605-branch

Apply patch. rdar://problem/39987479

Load hangs if the WebProcess fails to launch https://bugs.webkit.org/show_bug.cgi?id=185225 <rdar://problem/38249058>

Reviewed by Geoff Garen.

Source/WebKit:

When a process fails to launch, ChildProcessProxy::didFinishLaunching() gets called with an
invalid connection identifier. While NetworkProcessProxy::didFinishLaunching() properly deals with
this situation, WebProcessProxy::didFinishLaunching() does not. As a result, we do not attempt to
relaunch the process, we do not notify the client and WebPageProxy::m_isValid stays true.

This patch thus updates WebProcessProxy::didFinishLaunching() to check if the connection identifier
is valid and treats it as a crash. As a result, the WebPageProxies properly reset their state and
the client gets notified of the crash so that it can attempt to reload.

  • UIProcess/API/Cocoa/WKProcessPool.mm: (-[WKProcessPool _makeNextWebProcessLaunchFailForTesting]):
  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/Launcher/ProcessLauncher.h:
  • UIProcess/Launcher/mac/ProcessLauncherMac.mm: (WebKit::ProcessLauncher::launchProcess): Add SPI to make the next WebProcess launch fail, for the purpose of API testing.
  • UIProcess/WebProcessPool.h:
  • UIProcess/WebProcessProxy.cpp: (WebKit::WebProcessProxy::getLaunchOptions): (WebKit::WebProcessProxy::didClose): (WebKit::WebProcessProxy::processDidTerminateOrFailedToLaunch): (WebKit::WebProcessProxy::didFinishLaunching):
  • UIProcess/WebProcessProxy.h:

Tools:

Add API test coverage.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKitCocoa/WebContentProcessDidTerminate.mm: Added. (-[CrashOnStartNavigationDelegate _webView:webContentProcessDidTerminateWithReason:]): (-[CrashOnStartNavigationDelegate webView:didFinishNavigation:]): (-[CrashRecoveryScriptMessageHandler userContentController:didReceiveScriptMessage:]): (TEST):

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@231321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10:37 AM Changeset in webkit [231644] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

test262/Runner.pm: --failing-files uses results file not expectations
https://bugs.webkit.org/show_bug.cgi?id=185395

Patch by Valerie R Young <valerie@bocoup.com> on 2018-05-10
Reviewed by Michael Saboff.

--failing-files arg now uses results file to find failing tests
to rerun. It will look in the test262-results directory from whereever
the script is run, or a results.yaml file can be supplied via command
line argument.
--expectations arg added for suppling expectation file.

  • Scripts/test262/Runner.pm:

(processCLI):
(main):
(loadImportFile):
(findAllFailing):

10:02 AM Changeset in webkit [231643] by eric.carlson@apple.com
  • 2 edits in trunk/Source/WebCore

Log missing cues correctly
https://bugs.webkit.org/show_bug.cgi?id=185499
<rdar://problem/40113821>

Reviewed by Daniel Bates.

No new tests, tested manually.

  • html/track/InbandGenericTextTrack.cpp:

(WebCore::InbandGenericTextTrack::removeGenericCue): Log the cue we searched for, not
the NULL cue.

9:46 AM Changeset in webkit [231642] by Alan Bujtas
  • 11 edits in trunk/Source/WebCore

[LFC] Implement height computation for non-replaced inflow elements.
https://bugs.webkit.org/show_bug.cgi?id=185474

Reviewed by Antti Koivisto.

Initial implementation. Does not cover all the cases.

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeHeight const):

  • layout/FormattingContext.h:
  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layout const):
(WebCore::Layout::BlockFormattingContext::computeInFlowHeight const):
(WebCore::Layout::BlockFormattingContext::computeInFlowNonReplacedHeight const):

  • layout/blockformatting/BlockFormattingContext.h:
  • layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::collapsedMarginBottomFromLastChild):
(WebCore::Layout::BlockMarginCollapse::isMarginBottomCollapsedWithParent):
(WebCore::Layout::BlockMarginCollapse::isMarginTopCollapsedWithParentMarginBottom):
(WebCore::Layout::isMarginBottomCollapsedWithParent): Deleted.

  • layout/blockformatting/BlockMarginCollapse.h:
  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::computeInFlowHeight const):

  • layout/inlineformatting/InlineFormattingContext.h:
  • layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::isReplaced const):

  • layout/layouttree/LayoutBox.h:
9:16 AM Changeset in webkit [231641] by jmarcell@apple.com
  • 2 edits in branches/safari-606.1.17-branch/Source/WebKit

Apply patch. rdar://problem/40093461

8:21 AM Changeset in webkit [231640] by Michael Catanzaro
  • 2 edits in releases/WebKitGTK/webkit-2.20/Source/WebKit

Unreviewed, install WebKitHitTestResult.h

Not sure what I was thinking yesterday, but I removed this required
header. I did not notice because I validated the release using dyz,
which does not use our headers at all.

8:21 AM Changeset in webkit [231639] by Michael Catanzaro
  • 6 edits in releases/WebKitGTK/webkit-2.20/Source

Unreviewed, silence a couple more build warnings on the stable branch

7:50 AM Changeset in webkit [231638] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

[GTK] Implement ImageBuffer::toBGRAData
https://bugs.webkit.org/show_bug.cgi?id=185511

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-05-10
Reviewed by Michael Catanzaro.

This was never implemented but will be required for the MediaStream API
tests.

  • platform/graphics/ImageBuffer.cpp:

(WebCore::ImageBuffer::toBGRAData const):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::toBGRAData const):

  • platform/graphics/gtk/ImageBufferGtk.cpp:

(WebCore::ImageBuffer::toBGRAData const):

1:37 AM Changeset in webkit [231637] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

[GTK] Add support for settings cookies policy and storage type in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=185506

Reviewed by Philippe Normand.

Useful for testing and debugging.

  • MiniBrowser/gtk/main.c:

(main):

12:41 AM Changeset in webkit [231636] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[EME][GStreamer] Add a handler for GStreamer protection event
https://bugs.webkit.org/show_bug.cgi?id=185245

Patch by Yacine Bandou <yacine.bandou_ext@softathome.com> on 2018-05-10
Reviewed by Xabier Rodriguez-Calvar.

Qtdemux sends the protection event when encountered a new PSSH box (encrypted content).

The Decryptor is moved from AppendPipeline to PlaybackPipeline (see https://bugs.webkit.org/show_bug.cgi?id=181855),
thus the protection event is no longer handled because the Decryptor is not in the same pipeline as qtdemux.

AppendPipeline: httpsrc-->qtdemux-->appsink
PlaybackPipeline: appsrc-->parser--> decryptor-->decoder-->sink

This patch attaches a probe to the sink pad of the appsink in the appendPipeline in order to
catch and manage the protection event.

  • platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::AppendPipeline):
(WebCore::AppendPipeline::~AppendPipeline):
(WebCore::appendPipelineAppsinkPadEventProbe):

  • platform/graphics/gstreamer/mse/AppendPipeline.h:

(WebCore::AppendPipeline::playerPrivate):

12:15 AM Changeset in webkit [231635] by Fujii Hironori
  • 3 edits in trunk/Source/WebKitLegacy/win

REGRESSION(r231622) [Win] Crashes for null dereference of prefsPrivate in WebView::notifyPreferencesChanged
https://bugs.webkit.org/show_bug.cgi?id=185505

Unreviewed serious crash fix

Windows port crashes soon since Bug 184996.

  • WebPreferences.cpp:

(WebPreferences::QueryInterface): Added IID_IWebPreferencesPrivate7.

  • WebPreferences.h: Inherit IWebPreferencesPrivate7 instead of IWebPreferencesPrivate6.
12:11 AM Changeset in webkit [231634] by calvaris@igalia.com
  • 3 edits in trunk/LayoutTests

[wpe] update the TestExpectations for encrypted-media after some fixes
https://bugs.webkit.org/show_bug.cgi?id=185277

Patch by Yacine Bandou <yacine.bandou_ext@softathome.com> on 2018-05-10
Reviewed by Xabier Rodriguez-Calvar.

Once the decryptor moved from AppendPipeline to Playbackpipeline and the patches 185242, 185244
are fixed, the encrypted-media WPT LayoutTests will no longer crash and some one will pass.

  • platform/wpe/TestExpectations:
  • platform/wpe/imported/w3c/web-platform-tests/encrypted-media/clearkey-mp4-playback-temporary-multisession.https-expected.txt:
12:11 AM Changeset in webkit [231633] by calvaris@igalia.com
  • 6 edits in trunk/Source/WebCore

[EME][GStreamer] Move the decryptor from AppendPipeline to PlaybackPipeline.
https://bugs.webkit.org/show_bug.cgi?id=181855

Patch by Yacine Bandou <yacine.bandou_ext@softathome.com> on 2018-05-10
Reviewed by Xabier Rodriguez-Calvar.

The goal of this move is to handle the limitation of SVP (Secure Video Path) memory size.

When the decryptor is in the AppendPipeline and we use SVP, we buffer in MediaSource queue
the decrypted GstBuffers that are in SVP memory.
This behavior cause an out-of-memory error, because we are limited in SVP memory size.

By moving the decryptor in PlaybackPipeline, we avoid to buffer the decrypted GstBuffers
which use the SVP memory and we buffer the encrypted GstBuffers that are in system memory.

This new architecture also allows to start the buffering before obtaining the DRM license
and it makes easier to manage dynamic change of the license or Key.

The decryptor is auto plugged by GStreamer playbin in PlaybackPipeline.

SVP: Secure Video Path also named trusted or protected video path, it is a memory which is
protected by a hardware access control engine, it is not accessible to other unauthorised
software or hardware components.

Tests:

media/encrypted-media/clearKey/clearKey-cenc-audio-playback-mse.html
media/encrypted-media/clearKey/clearKey-cenc-video-playback-mse.html

  • platform/graphics/gstreamer/eme/WebKitCommonEncryptionDecryptorGStreamer.cpp:

(webkitMediaCommonEncryptionDecryptSinkEventHandler):

  • platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::dumpAppendState):
(WebCore::AppendPipeline::AppendPipeline):
(WebCore::AppendPipeline::handleNeedContextSyncMessage):
(WebCore::AppendPipeline::handleAppsrcNeedDataReceived):
(WebCore::AppendPipeline::setAppendState):
(WebCore::AppendPipeline::parseDemuxerSrcPadCaps):
(WebCore::AppendPipeline::appsinkNewSample):
(WebCore::AppendPipeline::connectDemuxerSrcPadToAppsinkFromAnyThread):
(WebCore::AppendPipeline::disconnectDemuxerSrcPadFromAppsinkFromAnyThread):
(WebCore::appendPipelineElementMessageCallback): Deleted.
(WebCore::AppendPipeline::handleElementMessage): Deleted.
(WebCore::AppendPipeline::dispatchPendingDecryptionStructure): Deleted.
(WebCore::AppendPipeline::dispatchDecryptionStructure): Deleted.

  • platform/graphics/gstreamer/mse/AppendPipeline.h:
  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::attemptToDecryptWithInstance):

  • platform/graphics/gstreamer/mse/PlaybackPipeline.cpp:
Note: See TracTimeline for information about the timeline view.