Timeline



Jun 27, 2018:

11:55 PM Fuchsia edited by abarth@webkit.org
(diff)
9:46 PM Fuchsia edited by abarth@webkit.org
(diff)
9:45 PM Fuchsia created by abarth@webkit.org
9:25 PM Changeset in webkit [233300] by timothy@apple.com
  • 5 edits in trunk/Source

Don't expose new semantic -apple-system color keywords on iOS.
https://bugs.webkit.org/show_bug.cgi?id=187080
rdar://problem/41505699

Reviewed by Tim Horton.

  • DerivedSources.make: Use gnu++14, since gnu++17 is giving errors on macOS 10.12.

Source/WebCore:

  • css/CSSValueKeywords.in: Define new semantic colors only on macOS.
9:19 PM Changeset in webkit [233299] by dbates@webkit.org
  • 6 edits
    11 adds in trunk/Tools

Add some tests for lldb_webkit.py
https://bugs.webkit.org/show_bug.cgi?id=183744

Reviewed by Alexey Proskuryakov.

Adds some tests to ensure we do not regress LLDB pretty-printing of WTF::StringImpl
and WTF::String objects.

The tests make use of the LLDB Python API (lldb.py) and a simple debug-built test
program, lldbWebKitTester, to run. For now, we only support building lldbWebKitTester
on Mac.

  • Makefile: Build the simple test tool lldbWebKitTester on Mac.
  • Scripts/build-lldbwebkittester: Added.

(buildProjectOrDie):

  • Scripts/dump-class-layout: Extract logic to compute the path to the LLDB Python module

from here to Scripts/webkitpy/common/system/systemhost.py so that it can used by both
this script and lldb/lldb_webkit_unittest.py. Also import the lldb module at the top of
the file and take advantage of Python's default error semantics to throw an exception
if the import fails instead of handling it ourself. This has the side effect that we
now always import the LLDB Python module even if this script is invoked with --help.
If this turns out to be a significant annoyance then we can look to dynamically import
the module as we did before this change.
(webkit_build_dir):
(main):
(developer_dir): Deleted.
(import_lldb): Deleted.

  • Scripts/webkitpy/common/checkout/scm/scm_unittest.py: Update FIXME comment to reflect

that fact that test-webkitpy does not support class and module fixtures. This is because
test-webkitpy currently implements parallelism by breaking down existing test classes
into individual test methods itself and having each worker run exactly one test method (via
unittest.TestLoader.loadTestsFromName()) at a time. As a result of this reorganization,
setUpModule()/setUpClass() are called for each test method as opposed to once per test
class/test module.
(remove_dir): Ditto.

  • Scripts/webkitpy/common/system/systemhost.py:

(SystemHost):
(SystemHost.path_to_lldb_python_directory): Added.

  • Scripts/webkitpy/test/main.py:

(_find_lldb_webkit_tester): Returns whether there exists a Debug or Release-built lldbWebKitTester.
(_build_lldb_webkit_tester): Builds lldbWebKitTester. For now, we only support building
lldbWebKitTester on Mac.
(main): Add Tools/lldb to the test search path if the platform has lldb.py.
(Tester.run): Pass a boolean as to whether we will run the lldb_webkit unit tests.
(Tester._run_tests): Modified to take a boolean as to whether to run the lldb_webkit unit tests.
If we will run these tests then build lldbWebKitTester if it has not already been built as the
unit tests depend on this program.

  • lldb/lldbWebKitTester/Configurations/Base.xcconfig: Added.
  • lldb/lldbWebKitTester/Configurations/DebugRelease.xcconfig: Added.
  • lldb/lldbWebKitTester/Configurations/lldbWebKitTester.xcconfig: Added.
  • lldb/lldbWebKitTester/Makefile: Added.
  • lldb/lldbWebKitTester/lldbWebKitTester.xcodeproj/project.pbxproj: Added.
  • lldb/lldbWebKitTester/main.cpp: Added.

(breakForTestingSummaryProviders):
(utf16String):
(testSummaryProviders):
(main):

  • lldb/lldb_webkit_unittest.py: Added.

(destroy_cached_debug_session):
(LLDBDebugSession):
(LLDBDebugSession.setup):
(LLDBDebugSession.tearDown):
(TestSummaryProviders):
(TestSummaryProviders.setUpClass):
(TestSummaryProviders._sbFrame):
(TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_null_string):
(TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_empty_string):
(TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_8bit_string):
(TestSummaryProviders.serial_test_WTFStringImpl_SummaryProvider_16bit_string):
(TestSummaryProviders.serial_test_WTFString_SummaryProvider_null_string):
(TestSummaryProviders.serial_test_WTFString_SummaryProvider_empty_string):
(TestSummaryProviders.serial_test_WTFString_SummaryProvider_8bit_string):
(TestSummaryProviders.serial_test_WTFString_SummaryProvider_16bit_string):

8:05 PM Changeset in webkit [233298] by Alan Bujtas
  • 7 edits in trunk/Source/WebCore

[LFC] Compute both the collapsed and the non-collapsed margin values.
https://bugs.webkit.org/show_bug.cgi?id=187129

Reviewed by Antti Koivisto.

For validation purposes only at this point.

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeFloatingHeightAndMargin const):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):

  • layout/FormattingContext.h:
  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeInFlowHeightAndMargin const):

  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

  • layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::isMarginTopCollapsedWithParent):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedMarginTopFromFirstChild):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginTop):

6:57 PM Changeset in webkit [233297] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC] Align inFlowNonReplacedHeightAndMargin() style with the rest of the compute functions.
https://bugs.webkit.org/show_bug.cgi?id=187126

Reviewed by Antti Koivisto.

  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

6:29 PM Changeset in webkit [233296] by Megan Gardner
  • 7 edits in trunk/Source/WebKit

Fix IBeam issues with iPad apps on Mac
https://bugs.webkit.org/show_bug.cgi?id=186900

Reviewed by Wenson Hsieh.

  • Shared/ios/InteractionInformationAtPosition.h:
  • Shared/ios/InteractionInformationAtPosition.mm:

(WebKit::InteractionInformationAtPosition::encode const):
(WebKit::InteractionInformationAtPosition::decode):

Add functionality to determine what a caret rect should be, but as it is
expensive, it should only be done for this platform.

  • Shared/ios/InteractionInformationRequest.cpp:

(WebKit::InteractionInformationRequest::isApproximateForRequest):

  • Shared/ios/InteractionInformationRequest.h:

As there is no way to premptively request information on hover, we need to use
the last cached information, but only if it is close to the point we are about
to request information for. So having a way to determine if a point is very close
to a previous point is a good idea.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _currentPositionInformationIsApproximateForRequest:]):
(-[WKContentView closestPositionToPoint:]):

UIKit is using this function to determine if we should show an Ibeam or not.
So we need to implement it, at least for this platform.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::getPositionInformation):

Pass up the calculated caret rect, but only for iPad apps on Mac.

6:10 PM Changeset in webkit [233295] by Yusuke Suzuki
  • 4 edits in trunk/Source

[GTK][WPE] Use LazyNeverDestroyed<XErrorTrapper> to remove static initializers
https://bugs.webkit.org/show_bug.cgi?id=187089

Reviewed by Michael Catanzaro.

Source/WebCore:

Do not allow copying since XErrorTrapper's logic relies on the address of XErrorTrapper.

  • platform/graphics/x11/XErrorTrapper.h:

Source/WebKit:

Use LazyNeverDestroyed<XErrorTrapper> instead of global std::unique_ptr<XErrorTrapper>.
Since this variable's exit time destructor is not important in this code, using
LazyNeverDestroyed<XErrorTrapper> is fine. This removes the last static initializer
of libwebkit2gtk.so.

  • PluginProcess/unix/PluginProcessMainUnix.cpp:
6:04 PM Changeset in webkit [233294] by abarth@webkit.org
  • 4 edits
    1 add in trunk

Add Fuchsia support to build-jsc
https://bugs.webkit.org/show_bug.cgi?id=187086

Reviewed by Yusuke Suzuki.

.:

Add Fuchsia port to cmake build system. After this patch, the build
errors out due to a missing sysroot.

  • CMakeLists.txt:
  • Source/cmake/OptionsFuchsia.cmake: Added.

Tools:

Add Fuchsia port to webkitdirs.pm. This patch is sufficient to make
build-jsc kick off a cmake for Fuchsia.

  • Scripts/webkitdirs.pm:

(determineSourceDir):
(argumentsForConfiguration):
(determineXcodeSDK):
(findMatchingArguments):
(determinePortName):
(isFuchsia):
(setupAppleWinEnv):
(wrapperPrefixIfNeeded):
(relaunchIOSSimulator):
(debugMiniBrowser):

5:32 PM Changeset in webkit [233293] by Kocsen Chung
  • 2 edits in tags/Safari-606.1.23/Source/WebCore

Cherry-pick r233279. rdar://problem/41539197

Crash under SWServer::unregisterServiceWorkerClient()
https://bugs.webkit.org/show_bug.cgi?id=187115
<rdar://problem/41539197>

Reviewed by Youenn Fablet.

Connections are usually destroyed before their SWServer. However, as per crash traces, it is possible
for SWServers to get destroyed while they still have connections. When this happens, the connections
(which are owned by the SWServer) get destroyed with other SWServer data members. In turn, the
connection destructor tries to unregister its clients from the server that is currently being destroyed.

To address the issue, the SWServer destructor now destroys remaining connections early, before SWServer's
other data members get destroyed.

  • workers/service/server/SWServer.cpp: (WebCore::SWServer::~SWServer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

5:25 PM Changeset in webkit [233292] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Mark imported/blink/storage/indexeddb/blob-delete-objectstore-db.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=172864

Unreviewed test gardening.

5:18 PM Changeset in webkit [233291] by sbarati@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add some more register state information when we crash in repatchPutById
https://bugs.webkit.org/show_bug.cgi?id=187112

Reviewed by Mark Lam.

This will help us gather info when we end up seeing a ObjectPropertyConditionSet
with an offset that is different than what the put tells us.

  • jit/Repatch.cpp:

(JSC::tryCachePutByID):

5:15 PM Changeset in webkit [233290] by youenn@apple.com
  • 2 edits in trunk/LayoutTests

Rebase LayoutTests/http/tests/contentextensions/subresource-redirect-blocked-expected.txt after r233269
https://bugs.webkit.org/show_bug.cgi?id=187125

Unreviewed.

  • http/tests/contentextensions/subresource-redirect-blocked-expected.txt:
4:46 PM Changeset in webkit [233289] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[LFC] Align inFlowNonReplacedWidthAndMargin() style with the rest of the compute functions.
https://bugs.webkit.org/show_bug.cgi?id=187124

Reviewed by Antti Koivisto.

  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):

4:43 PM Changeset in webkit [233288] by dbates@webkit.org
  • 4 edits in trunk/Tools

style-queue "AttributeError: 'NoneType' object has no attribute 'is_obsolete'" when processing security patch
https://bugs.webkit.org/show_bug.cgi?id=187120

Reviewed by David Kilzer.

Teach the style queue how to refetch a patch from the status server as we did for non-Style
EWS queues.

  • Scripts/webkitpy/tool/bot/stylequeuetask.py:

(StyleQueueTask.validate): Similar to change made to EarlyWarningSystemTask.validate() in r233107,
only check if the bug associated with the patch we are processing is closed if the attachment has a
non-None Bug object.

  • Scripts/webkitpy/tool/commands/earlywarningsystem.py:

(AbstractEarlyWarningSystem.refetch_patch): Extract logic to refetch a patch from here...

  • Scripts/webkitpy/tool/commands/queues.py:

(PatchProcessingQueue._refetch_patch): ... to here.
(StyleQueue.refetch_patch): Turn around and call PatchProcessingQueue._refetch_patch().

4:28 PM Changeset in webkit [233287] by krit@webkit.org
  • 5 edits
    2 adds in trunk

-webkit-clip-path wrong offset for clipPath references
https://bugs.webkit.org/show_bug.cgi?id=129246

Reviewed by Simon Fraser.

Source/WebCore:

Compute the correct offset for reference clip-paths by reusing
some of the logic from basic shapes.
Makes reference based clip-path interoperable and follows the
spec.

Test: css3/masking/clip-path-reference-2.html

  • rendering/RenderLayer.cpp:

(WebCore::computeReferenceBox):
(WebCore::RenderLayer::computeClipPath const):
(WebCore::RenderLayer::setupClipPath):

LayoutTests:

Add test for reference clip-path offset. Correct a broken test.
All tests in the repo for references are interoperable between Gecko, Blink
and WebKit now.

  • css3/masking/clip-path-reference-2-expected.html: Added.
  • css3/masking/clip-path-reference-2.html: Added.
  • css3/masking/clip-path-reference-userSpaceOnUse-expected.html:
  • css3/masking/clip-path-reference-userSpaceOnUse.html:
4:22 PM Changeset in webkit [233286] by Tadeu Zagallo
  • 2 edits in trunk/Tools

Unreviewed, add myself as a WebKit committer.

  • Scripts/webkitpy/common/config/contributors.json:
4:13 PM Changeset in webkit [233285] by mark.lam@apple.com
  • 4 edits in trunk/Source/JavaScriptCore

Fix a bug in $vm.callFrame() and apply previously requested renaming of $vm.println to print.
https://bugs.webkit.org/show_bug.cgi?id=187119

Reviewed by Keith Miller.

$vm.callFrame()'s JSDollarVMCallFrame::finishCreation()
should be checking for codeBlock instead of !codeBlock
before using the codeBlock.

I also renamed some other "print" functions to use "dump" instead
to match their underlying C++ code that they will call e.g.
CodeBlock::dumpSource().

  • tools/JSDollarVM.cpp:

(WTF::JSDollarVMCallFrame::finishCreation):
(JSC::functionDumpSourceFor):
(JSC::functionDumpBytecodeFor):
(JSC::doPrint):
(JSC::functionDataLog):
(JSC::functionPrint):
(JSC::functionDumpCallFrame):
(JSC::functionDumpStack):
(JSC::JSDollarVM::finishCreation):
(JSC::functionPrintSourceFor): Deleted.
(JSC::functionPrintBytecodeFor): Deleted.
(JSC::doPrintln): Deleted.
(JSC::functionPrintln): Deleted.
(JSC::functionPrintCallFrame): Deleted.
(JSC::functionPrintStack): Deleted.

  • tools/VMInspector.cpp:

(JSC::DumpFrameFunctor::DumpFrameFunctor):
(JSC::DumpFrameFunctor::operator() const):
(JSC::VMInspector::dumpCallFrame):
(JSC::VMInspector::dumpStack):
(JSC::VMInspector::dumpValue):
(JSC::PrintFrameFunctor::PrintFrameFunctor): Deleted.
(JSC::PrintFrameFunctor::operator() const): Deleted.
(JSC::VMInspector::printCallFrame): Deleted.
(JSC::VMInspector::printStack): Deleted.
(JSC::VMInspector::printValue): Deleted.

  • tools/VMInspector.h:
3:53 PM Changeset in webkit [233284] by youenn@apple.com
  • 2 edits
    8 adds in trunk/Source/WebKit

Add a sandbox profile for some additional bank plugins
https://bugs.webkit.org/show_bug.cgi?id=187105

Reviewed by Brent Fulgham.

  • Resources/PlugInSandboxProfiles/cfca.com.npCryptoKit.CGB.MAC.sb: Added.
  • Resources/PlugInSandboxProfiles/cfca.com.npP11CertEnroll.MAC.CGB.sb: Added.
  • Resources/PlugInSandboxProfiles/com.apple.BocomSubmitCtrl.sb: Added.
  • Resources/PlugInSandboxProfiles/com.apple.NPSafeInput.sb: Added.
  • Resources/PlugInSandboxProfiles/com.apple.NPSafeSubmit.sb: Added.
  • Resources/PlugInSandboxProfiles/com.cfca.npSecEditCtl.MAC.BOC.plugin.sb: Added.
  • Resources/PlugInSandboxProfiles/com.cmbchina.CMBSecurity.sb: Added.
  • Resources/PlugInSandboxProfiles/com.ftsafe.NPAPI-Core-Safe-SoftKeybaord.plugin.rfc1034identifier.sb: Added.
  • WebKit.xcodeproj/project.pbxproj:
3:49 PM Changeset in webkit [233283] by Jonathan Bedard
  • 3 edits in trunk/Source/WebCore/PAL

Build fix after r233266
https://bugs.webkit.org/show_bug.cgi?id=187024
<rdar://problem/39759057>

Unreviewed build fix.

  • pal/cf/CoreMediaSoftLink.cpp: Do not soft-link CMSampleBufferCallForEachSample for

iOS 12 and up on iPhone device and simulator.

  • pal/cf/CoreMediaSoftLink.h: Ditto.
3:43 PM Changeset in webkit [233282] by bshafiei@apple.com
  • 7 edits in trunk/Source

Versioning.

3:25 PM Changeset in webkit [233281] by Antti Koivisto
  • 6 edits
    2 adds in trunk

Don't invoke post resolution callbacks when resolving computed style
https://bugs.webkit.org/show_bug.cgi?id=187113
<rdar://problem/41365766>

Reviewed by Geoff Garen.

Source/WebCore:

Post-resolution callbacks should only be invoked when we resolve the full document style,
not when resolving computed style for a single element.

Tests: fast/dom/object-computed-style-event.html

  • dom/Document.cpp:

(WebCore::Document::styleForElementIgnoringPendingStylesheets):

  • dom/Element.cpp:

(WebCore::Element::resolveComputedStyle):

Also ref the ancestor stack to be safe.

  • style/StyleTreeResolver.cpp:

(WebCore::Style::PostResolutionCallbackDisabler::PostResolutionCallbackDisabler):
(WebCore::Style::PostResolutionCallbackDisabler::~PostResolutionCallbackDisabler):

Add an option to not drain the callback queue on destruction. In this mode we
just block network loads.

  • style/StyleTreeResolver.h:

LayoutTests:

  • fast/dom/object-computed-style-event-expected.txt: Added.
  • fast/dom/object-computed-style-event.html: Added.
3:14 PM Changeset in webkit [233280] by timothy@apple.com
  • 13 edits in trunk

Find on page selection color isn't adapted for dark mode.
https://bugs.webkit.org/show_bug.cgi?id=187072
rdar://problem/40354841

Reviewed by Tim Horton.

Source/WebCore:

  • page/mac/TextIndicatorWindow.mm:

(-[WebTextIndicatorView initWithFrame:textIndicator:margin:offset:]): Use [NSColor findHighlightColor].

  • platform/mac/LocalDefaultSystemAppearance.h:

(WebCore::LocalDefaultSystemAppearance::usingDarkAppearance const): Added.

  • platform/mac/LocalDefaultSystemAppearance.mm:

(WebCore::LocalDefaultSystemAppearance::LocalDefaultSystemAppearance): Set m_usingDarkAppearance.

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintPlatformDocumentMarkers): Use TextPaintPhase::Decoration since this
matches step three of InlineTextBox::paint ("Paint fancy decorations"). This allows TextMatch to
paint a forground and not end up painting during this "fancy decorations" phase.
(WebCore::InlineTextBox::resolveStyleForMarkedText): Set the fillColor for TextMarker to force a
dark text color which will draw over the yellow highlight.
(WebCore::InlineTextBox::collectMarkedTextsForDocumentMarkers): Added support for TextPaintPhase::Decoration.
Seperate DocumentMarker::TelephoneNumber and DocumentMarker::TextMatch. Have DocumentMarker::TextMatch
support Forground and Background phases.

  • rendering/RenderTheme.cpp:

(WebCore::RenderTheme::platformColorsDidChange):
(WebCore::RenderTheme::activeTextSearchHighlightColor const): Added. Call the platfrom version.
(WebCore::RenderTheme::inactiveTextSearchHighlightColor const): Added. Ditto.
(WebCore::RenderTheme::platformActiveTextSearchHighlightColor const): Added StyleColor::Options.
(WebCore::RenderTheme::platformInactiveTextSearchHighlightColor const): Ditto.

  • rendering/RenderTheme.h:
  • rendering/RenderThemeMac.h:
  • rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::platformActiveTextSearchHighlightColor const): Added.
(WebCore::RenderThemeMac::platformInactiveTextSearchHighlightColor const): Added.
(WebCore::RenderThemeMac::platformColorsDidChange): Clear new color caches.
(WebCore::RenderThemeMac::systemColor const): Cache system colors by light and dark mode.

LayoutTests:

  • fast/css/apple-system-control-colors-expected.txt: Updated.
  • fast/text/mark-matches-broken-line-rendering-expected.html: Ditto.
  • fast/text/mark-matches-rendering-expected.html: Ditto.
2:43 PM Changeset in webkit [233279] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Crash under SWServer::unregisterServiceWorkerClient()
https://bugs.webkit.org/show_bug.cgi?id=187115
<rdar://problem/41539197>

Reviewed by Youenn Fablet.

Connections are usually destroyed before their SWServer. However, as per crash traces, it is possible
for SWServers to get destroyed while they still have connections. When this happens, the connections
(which are owned by the SWServer) get destroyed with other SWServer data members. In turn, the
connection destructor tries to unregister its clients from the server that is currently being destroyed.

To address the issue, the SWServer destructor now destroys remaining connections early, before SWServer's
other data members get destroyed.

  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::~SWServer):

2:26 PM Changeset in webkit [233278] by keith_miller@apple.com
  • 3 edits in trunk/Source/JavaScriptCore

Add logging to try to diagnose where we get a null structure.
https://bugs.webkit.org/show_bug.cgi?id=187106

Reviewed by Mark Lam.

Add a logging to JSObject::toPrimitive to help diagnose a nullptr
structure crash.

This code should be removed when we fix <rdar://problem/33451840>

  • runtime/JSObject.cpp:

(JSC::callToPrimitiveFunction):

  • runtime/JSObject.h:

(JSC::JSObject::getPropertySlot):

2:15 PM Changeset in webkit [233277] by youenn@apple.com
  • 9 edits in trunk/Source

NetworkLoadChecker should not need to hard ref NetworkConnectionToWebProcess
https://bugs.webkit.org/show_bug.cgi?id=186551

Reviewed by Daniel Bates.

Source/WebCore:

No change of behavior.
Add a way to set the client receiving any CSP warning/error notification.

  • page/csp/ContentSecurityPolicy.h:

(WebCore::ContentSecurityPolicy::setClient):

Source/WebKit:

Removed the need for NetworkLoadChecker to reference a NetworkConnectionToWebProcess.
Instead a CSP client is given to NetworkLoadChecker when needed.

  • NetworkProcess/NetworkConnectionToWebProcess.cpp:

(WebKit::NetworkConnectionToWebProcess::loadPing):

  • NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::NetworkLoadChecker):
(WebKit::NetworkLoadChecker::check):
(WebKit::NetworkLoadChecker::checkRedirection):
(WebKit::NetworkLoadChecker::checkRequest):
(WebKit::NetworkLoadChecker::contentSecurityPolicy):
(WebKit::NetworkLoadChecker::addConsoleMessage): Deleted.
(WebKit::NetworkLoadChecker::sendCSPViolationReport): Deleted.
(WebKit::NetworkLoadChecker::enqueueSecurityPolicyViolationEvent): Deleted.

  • NetworkProcess/NetworkLoadChecker.h:
  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::start):
(WebKit::NetworkResourceLoader::willSendRedirectedRequest):

  • NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::willPerformHTTPRedirection):

  • NetworkProcess/PingLoad.h:
2:10 PM Changeset in webkit [233276] by dbates@webkit.org
  • 3 edits in trunk/Tools

webkit-patch should ignore non-ASCII characters in the status server API key
https://bugs.webkit.org/show_bug.cgi?id=187107

Reviewed by Lucas Forschler.

The API key should only consists of ASCII characters. If it contains any
non-ASCII characters then log a warning and ignore them.

  • Scripts/webkitpy/common/net/statusserver.py:

(StatusServer.set_api_key): Force conversion to ASCII.

  • Scripts/webkitpy/tool/main.py:

(WebKitPatch._status_server_api_key): Convert to ASCII, ignoring non-ASCII
characters and logging a warning.

1:10 PM Changeset in webkit [233275] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC] Do not collapse margin with the parent when element has border/padding.
https://bugs.webkit.org/show_bug.cgi?id=187114

Reviewed by Antti Koivisto.

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layout const):

  • layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::isMarginTopCollapsedWithParent):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::collapsedMarginTopFromFirstChild):
(WebCore::Layout::BlockFormattingContext::MarginCollapse::marginTop):

1:01 PM Changeset in webkit [233274] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

Fix Windows build after r233268.

  • platform/graphics/ca/win/PlatformCALayerWin.cpp:

(PlatformCALayerWin::hasContents const):

  • platform/graphics/ca/win/PlatformCALayerWin.h:
12:59 PM Changeset in webkit [233273] by youenn@apple.com
  • 1 edit
    1 move
    6 adds in trunk/LayoutTests/imported/w3c

Add Cross-Origin-Resource-Policy tests for workers and service workers
https://bugs.webkit.org/show_bug.cgi?id=187030

Reviewed by Chris Dumez.

  • web-platform-tests/fetch/cross-origin-resource-policy/fetch-in-service-worker-expected.txt: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/fetch-in-service-worker.html: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/fetch.any-expected.txt: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/fetch.any.html: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/fetch.any.js: Renamed from LayoutTests/imported/w3c/web-platform-tests/fetch/cross-origin-resource-policy/fetch.html.
  • web-platform-tests/fetch/cross-origin-resource-policy/fetch.any.worker-expected.txt: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/fetch.any.worker.html: Added.
12:23 PM Changeset in webkit [233272] by Alan Bujtas
  • 7 edits in trunk/Source/WebCore

[LFC] Out-of-flow positioned element's height depends on its containing block's height.
https://bugs.webkit.org/show_bug.cgi?id=187082

Reviewed by Antti Koivisto.

We can't really compute the final height of an out-of-flow element until after its containing block's height is computed.

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):

  • layout/FormattingContext.h:
  • layout/LayoutContext.cpp:

(WebCore::Layout::LayoutContext::updateLayout):
(WebCore::Layout::LayoutContext::layoutFormattingContextSubtree):

  • layout/LayoutContext.h:
  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layout const):

  • layout/layouttree/LayoutContainer.h:

(WebCore::Layout::Container::outOfFlowDescendants const):
(WebCore::Layout::Container::outOfFlowDescendants): Deleted.

12:19 PM Changeset in webkit [233271] by commit-queue@webkit.org
  • 9 edits in trunk/Source/WebKit

[Wincairo] Add support for context menus to non-legacy minibrowser
https://bugs.webkit.org/show_bug.cgi?id=186815.

Patch by Stephan Szabo <stephan.szabo@sony.com> on 2018-06-27
Reviewed by Ryosuke Niwa.

  • UIProcess/WebPageProxy.h:
  • UIProcess/win/PageClientImpl.cpp:

(WebKit::PageClientImpl::viewWidget):

  • UIProcess/win/PageClientImpl.h:
  • UIProcess/win/WebContextMenuProxyWin.cpp:

(WebKit::WebContextMenuProxyWin::show):
(WebKit::createMenu):
(WebKit::createMenuItem):
(WebKit::populate):
(WebKit::WebContextMenuProxyWin::showContextMenuWithItems):
(WebKit::WebContextMenuProxyWin::WebContextMenuProxyWin):
(WebKit::WebContextMenuProxyWin::~WebContextMenuProxyWin):

  • UIProcess/win/WebContextMenuProxyWin.h:
  • UIProcess/win/WebPageProxyWin.cpp:

(WebKit::WebPageProxy::viewWidget):

  • UIProcess/win/WebView.cpp:

(WebKit::WebView::wndProc):
(WebKit::WebView::onMenuCommand):

  • UIProcess/win/WebView.h:
11:34 AM Changeset in webkit [233270] by Kocsen Chung
  • 1 copy in tags/Safari-606.1.23

Tag Safari-606.1.23.

11:23 AM Changeset in webkit [233269] by youenn@apple.com
  • 9 edits
    3 adds in trunk

Disable content blockers in NetworkLoadChecker except for ping loads
https://bugs.webkit.org/show_bug.cgi?id=187083
<rdar://problem/41440083>

Reviewed by Chris Dumez.

Source/WebCore:

Add internals API to reload a frame without content extensions.

Test: http/tests/contentextensions/reload-without-contentextensions.html

  • testing/Internals.cpp:

(WebCore::Internals::reloadWithoutContentExtensions):

  • testing/Internals.h:
  • testing/Internals.idl:

Source/WebKit:

  • NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::processContentExtensionRulesForLoad):

  • NetworkProcess/NetworkLoadChecker.h:

(WebKit::NetworkLoadChecker::enableContentExtensionsCheck):

  • NetworkProcess/PingLoad.cpp:

LayoutTests:

  • http/tests/contentextensions/reload-without-contentextensions-expected.txt: Added.
  • http/tests/contentextensions/reload-without-contentextensions.html: Added.
  • http/tests/contentextensions/reload-without-contentextensions.html.json: Added.
11:22 AM Changeset in webkit [233268] by Simon Fraser
  • 18 edits
    3 adds in trunk

https://hackernoon.com/ uses lots of layer backing store
https://bugs.webkit.org/show_bug.cgi?id=186909
rdar://problem/40257540

Reviewed by Tim Horton.

Source/bmalloc:

Drive-by typo fix.

  • bmalloc/Scavenger.cpp:

(bmalloc::dumpStats):

Source/WebCore:

The existing "backing store detached" logic, which was used to eliminate backing store
for compositing layers outside the viewport, had a number of bugs that allowed layers
to have backing store when they should not.

Specifically, any code path that ended up in setNeedsDisplay{InRect}() in PlatformCALayer
could trigger backing store creation on layers that should have never had any.

Rather than monkeypatch all the GraphicsLayerCA call sites that call setNeedsDisplay{InRect}(),
just bail early from the PlatformCALayer* methods that trigger repaints.

Tests didn't catch this because they just dumped the state of the backingStoreAttached flag. To fix this,
create backingStoreAttachedForTesting() which also tests whether the layer has contents.

Test: compositing/backing/backing-store-attachment-outside-viewport.html

  • platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::dumpProperties const):
(showGraphicsLayerTree):

  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::backingStoreAttachedForTesting const):

  • platform/graphics/GraphicsLayerClient.h:
  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::backingStoreAttachedForTesting const):
(WebCore::GraphicsLayerCA::setNeedsDisplay):

  • platform/graphics/ca/GraphicsLayerCA.h:
  • platform/graphics/ca/PlatformCALayer.h:
  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.h:
  • platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:

(PlatformCALayerCocoa::setNeedsDisplay):
(PlatformCALayerCocoa::setNeedsDisplayInRect):
(PlatformCALayerCocoa::hasContents const):

Source/WebKit:

PlatformCALayerRemote was actually holding onto backing stores for layers with
backing store detached, which could increase memory use. When told that backing stores
are not attached, explicitly throw away the backing, and re-create it (via setNeedsDisplay)
when attached. This is now similar to what PlatformLayerCACocoa does.

  • WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.cpp:

(WebKit::PlatformCALayerRemote::setNeedsDisplayInRect):
(WebKit::PlatformCALayerRemote::setNeedsDisplay):
(WebKit::PlatformCALayerRemote::hasContents const):

  • WebProcess/WebPage/RemoteLayerTree/PlatformCALayerRemote.h:

LayoutTests:

New test.

  • compositing/backing/backing-store-attachment-outside-viewport-expected.txt: Added.
  • compositing/backing/backing-store-attachment-outside-viewport.html: Added.
11:07 AM Changeset in webkit [233267] by ddkilzer@apple.com
  • 10 edits in trunk/Source/WebCore

Fix clang static analyzer warnings: Branch condition evaluates to a garbage value
<https://webkit.org/b/186968>

Reviewed by Zalan Bujtas.

This patch changes two stack-allocated bool variables into
std::optional<bool> since the functions that set the variable
may return early without setting it. It also changes one
stack-allocated pointer to be initialized to nullptr.

  • animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::updateCSSTransitionsForElement):
Update for change to CSSPropertyAnimation::getPropertyAtIndex()
argument type.

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::writeImageToPasteboard): Initialize
cachedImage stack pointer to nullptr since getImage() has an
early return that doesn't set cachedImage.

  • editing/mac/EditorMac.mm:

(WebCore::Editor::writeImageToPasteboard): Ditto.

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::CSSPropertyAnimation::getPropertyAtIndex):

  • page/animation/CSSPropertyAnimation.h:

(WebCore::CSSPropertyAnimation::getPropertyAtIndex):

  • Change method to take std::optional<bool> instead of bool as second argument since the method may return early without setting isShorthand.
  • page/animation/CompositeAnimation.cpp:

(WebCore::CompositeAnimation::updateTransitions): Update for
change to CSSPropertyAnimation::getPropertyAtIndex() argument
type.

  • rendering/InlineFlowBox.cpp:

(WebCore::InlineFlowBox::placeBoxesInBlockDirection): Also
rename local emphasisMarkIsOver to emphasisMarkIsAbove to
match other call sites.
(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::computeOverAnnotationAdjustment const):
(WebCore::InlineFlowBox::computeUnderAnnotationAdjustment const):

  • Update for change to InlineTextBox::emphasisMarkExistsAndIsAbove() argument type.
  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::emphasisMarkExistsAndIsAbove const):

  • Change method to take std::optional<bool> instead of bool as second argument since the method may return early without setting above.

(WebCore::InlineTextBox::paintMarkedTextForeground):

  • Update for change to InlineTextBox::emphasisMarkExistsAndIsAbove() argument type.
  • rendering/InlineTextBox.h:

(WebCore::InlineTextBox::emphasisMarkExistsAndIsAbove const):

  • Change method to take std::optional<bool> instead of bool.
11:02 AM Changeset in webkit [233266] by Jonathan Bedard
  • 17 edits
    1 copy
    19 adds in trunk

Enable WebKit iOS 12 build
https://bugs.webkit.org/show_bug.cgi?id=187024
<rdar://problem/39759057>

Reviewed by David Kilzer.

Source/WebCore/PAL:

  • pal/cf/CoreMediaSoftLink.cpp: Condition some CoreMedia functions on version.
  • pal/cf/CoreMediaSoftLink.h: Ditto.
  • pal/spi/cocoa/NSXPCConnectionSPI.h: Use XPCSPI.h instead of xpc.h.
  • pal/spi/ios/QuickLookSPI.h: QLItem adopts QLPreviewItem.
  • pal/spi/ios/SystemPreviewSPI.h: Fix compiler errors.

Source/WebKit:

  • Platform/spi/ios/PDFKitSPI.h: Added PDFKit SPI.
  • Platform/spi/ios/UIKitSPI.h: Add new UIKit SPI and UICompositingMode enumeration.
  • UIProcess/ios/WKPDFView.mm: Use PDFKitSPI header.
  • UIProcess/ios/WKSystemPreviewView.mm: Use CoreGraphicsSPI.h.
  • UIProcess/ios/fullscreen/WKFullscreenStackView.mm: Use QuartzCoreSPI.h.

Source/WTF:

  • wtf/spi/darwin/XPCSPI.h: Add endpoint and connection declarations.

Tools:

  • Scripts/configure-xcode-for-ios-development:

(copyMissingHeadersFromSDKToSDKIfNeeded): Copy launch.h into embedded SDKs.

WebKitLibraries:

  • WebKitPrivateFrameworkStubs/iOS/12: Added.
10:59 AM Changeset in webkit [233265] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

CSS Animation Triggers is not an experimental feature, should be globally off by default

Reviewed by Dean Jackson.

  • Shared/WebPreferences.yaml:
10:41 AM Changeset in webkit [233264] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

Promote the Secure Context API feature from experimental-yet-on-by-default to always-on

Reviewed by Dan Bates.

  • Shared/WebPreferences.yaml:

Secure Context API is on by default, it's not experimental anymore.

10:38 AM Changeset in webkit [233263] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

Make Link Preload an on-by-default feature
https://bugs.webkit.org/show_bug.cgi?id=187104

Reviewed by Ryosuke Niwa.

  • Shared/WebPreferences.yaml:

This should be on, not experimental. It already shipped on in the past.

10:01 AM Changeset in webkit [233262] by rmorisset@apple.com
  • 2 edits in trunk/Tools

[WSL] Add a control-flow stack to the execution rules in WSL.ott
https://bugs.webkit.org/show_bug.cgi?id=186310

Rubberstamped by Filip Pizlo.

The goal of this is to enable (future) rules about uniform control flow for barriers.
It required adding two new special construct: Join(s) and JoinExpr(e) whose only role is to pop the last element of the stack.

9:36 AM Changeset in webkit [233261] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Regression(r233208): Completion handler does not get called on GTK port
https://bugs.webkit.org/show_bug.cgi?id=187099

Reviewed by Antti Koivisto.

Make sure UpdatePrevalentDomainsToPartitionOrBlockCookiesHandler's completion handler
gets called on non-COCOA ports.

  • UIProcess/WebResourceLoadStatisticsStore.h:
9:18 AM Changeset in webkit [233260] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC] Move formatting context root layout logic to a dedicated function.
https://bugs.webkit.org/show_bug.cgi?id=187097

Reviewed by Antti Koivisto.

  • layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layout const):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):

  • layout/blockformatting/BlockFormattingContext.h:
9:13 AM Changeset in webkit [233259] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC] Compute static position for out-of-flow elements only when required.
https://bugs.webkit.org/show_bug.cgi?id=187096

Reviewed by Antti Koivisto.

Computing static position for out-of-flow elements could be somewhat expensive, so let's not do it unless we actually need it.

  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::staticVerticalPositionForOutOfFlowPositioned):
(WebCore::Layout::staticHorizontalPositionForOutOfFlowPositioned):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):

  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::staticPositionForOutOfFlowPositioned): Deleted.

9:13 AM Changeset in webkit [233258] by Ms2ger@igalia.com
  • 2 edits in trunk/WebDriverTests

[GTK][WPE] Update expectations for WebDriver tests.
https://bugs.webkit.org/show_bug.cgi?id=187098

Unreviewed gardening.

9:10 AM Changeset in webkit [233257] by n_wang@apple.com
  • 3 edits
    2 adds
    2 deletes in trunk

AX: [iOS] Remove the ability to set keyboard focus when VoiceOver takes focus
https://bugs.webkit.org/show_bug.cgi?id=187076

Reviewed by Chris Fleizach.

Source/WebCore:

We shouldn't set keyboard focus when assistive technology takes focus since
this is causing website incompatibility issues by causing focus to be lost.

Test: accessibility/ios-simulator/accessibility-focus-do-not-set-focus.html

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper accessibilityElementDidBecomeFocused]):

LayoutTests:

  • accessibility/ios-simulator/accessibility-focus-do-not-set-focus-expected.txt: Added.
  • accessibility/ios-simulator/accessibility-focus-do-not-set-focus.html: Added.
  • accessibility/ios-simulator/dom-focus-fires-on-correct-element-expected.txt: Removed.
  • accessibility/ios-simulator/dom-focus-fires-on-correct-element.html: Removed.
8:14 AM Changeset in webkit [233256] by rmorisset@apple.com
  • 2 edits in trunk/Tools

[WSL] Fix minor formatting issues in the grammar section
https://bugs.webkit.org/show_bug.cgi?id=186310

Rubberstamped by Filip Pizlo.

8:07 AM Changeset in webkit [233255] by Michael Catanzaro
  • 4 edits in trunk/Source/ThirdParty

MIME type subclass check should guard against small strings
https://bugs.webkit.org/show_bug.cgi?id=186977

Reviewed by Carlos Garcia Campos.

Sadly, this code is duplicated between two different files because it is not good.

  • xdgmime/README.webkit:
  • xdgmime/src/xdgmime.c:

(ends_with):
(xdg_mime_is_super_type):

  • xdgmime/src/xdgmimecache.c:

(ends_with):
(is_super_type):

8:04 AM Changeset in webkit [233254] by rmorisset@apple.com
  • 3 edits in trunk/Tools

[WSL] Put the full grammar in the Sphinx document
https://bugs.webkit.org/show_bug.cgi?id=186310

Rubberstamped by Filip Pizlo.

Put the grammar's production rules in the Sphinx document, along with a few comments and the rules for desugaring.
Also includes a bit of clean-up of the antlr rules.

4:19 AM Changeset in webkit [233253] by mark.lam@apple.com
  • 3 edits
    1 add in trunk

DFG's compileReallocatePropertyStorage() and compileAllocatePropertyStorage() slow paths should also clear unused properties.
https://bugs.webkit.org/show_bug.cgi?id=187091
<rdar://problem/41395624>

Reviewed by Yusuke Suzuki.

JSTests:

  • stress/regress-187091.js: Added.

Source/JavaScriptCore:

Previously, when compileReallocatePropertyStorage() and compileAllocatePropertyStorage()
take their slow paths, the slow path would jump back to the fast path right after
the emitted code which clears the unused property values. As a result, the
unused properties are not initialized. We've fixed this by adding the slow path
generators before we emit the code to clear the unused properties.

  • dfg/DFGSpeculativeJIT.cpp:

(JSC::DFG::SpeculativeJIT::compileAllocatePropertyStorage):
(JSC::DFG::SpeculativeJIT::compileReallocatePropertyStorage):

3:05 AM Changeset in webkit [233252] by Yusuke Suzuki
  • 3 edits
    1 add in trunk

[JSC] ArrayPatternNode::emitDirectBinding does not return assignment target value if dst is nullptr
https://bugs.webkit.org/show_bug.cgi?id=185943

Reviewed by Mark Lam.

JSTests:

  • stress/direct-binding-return-result.js: Added.

(shouldBe):
(test):

Source/JavaScriptCore:

ArrayPatternNode::emitDirectBinding should return a register with an assignment target instead of filling
the result with undefined if dst is nullptr. While dst == ignoredResult() means we do not require
the result, dst == nullptr just means "dst is required, but a register for dst is not allocated.".
This patch fixes emitDirectBinding to return an appropriate value with an allocated register for dst.

ArrayPatternNode::emitDirectBinding() should be removed later since it does not follow array spreading protocol,
but it should be done in a separate patch since it would be performance sensitive.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ArrayPatternNode::emitDirectBinding):

2:34 AM Changeset in webkit [233251] by emilio
  • 2 edits in trunk/Source/WebCore

Move clearChildNeedsStyleRecalc into resetStyleForNonRenderedDescendants.
https://bugs.webkit.org/show_bug.cgi?id=186881

Reviewed by Antti Koivisto.

Every caller does this already.

No new tests, no change in behavior.

  • style/StyleTreeResolver.cpp:

(WebCore::Style::resetStyleForNonRenderedDescendants):
(WebCore::Style::TreeResolver::resolveComposedTree):

1:27 AM Changeset in webkit [233250] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

When trying to print a very long email on iOS, the print preview is blank
https://bugs.webkit.org/show_bug.cgi?id=187077
<rdar://problem/41107013>

Reviewed by Timothy Hatcher.

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::computePagesForPrintingAndDrawToPDF):
ChildProcessProxy::sendSync has a (surprising) default timeout of 1 second,
(as opposed to Connection::sendSync's default timeout of ∞ seconds).
The printing path already waits ∞ seconds for the final PDF, but currently
uses the default 1 second timeout for page count computation. If page
count computation takes more than 1 second, the preview will be blank.
Since the print preview is generated asynchronously, we really want
to wait until it's done, and not give up after 1 second.

1:19 AM Changeset in webkit [233249] by Yusuke Suzuki
  • 2 edits in trunk/Source/ThirdParty/libwebrtc

[GTK][WPE] Remove gflags from libwebrtc build
https://bugs.webkit.org/show_bug.cgi?id=187078

Reviewed by Alejandro G. Castro.

gflags is used only in libyuv unit tests. So the Apple ports do not build & link it.
GTK and WPE can do the same thing: not building gflags. By doing so, we can achieve
the following results.

  1. Remove static initializers defined for gflags.
  2. Reduce binary size.
  • CMakeLists.txt:
1:16 AM Changeset in webkit [233248] by tpopela@redhat.com
  • 4 edits in trunk/Source/WebCore

[GStreamer] Coverity scan issues
https://bugs.webkit.org/show_bug.cgi?id=187087

Reviewed by Xabier Rodriguez-Calvar.

Fix uninitialized members.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
  • platform/graphics/gstreamer/VideoSinkGStreamer.cpp:
  • platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:
1:13 AM Changeset in webkit [233247] by zandobersek@gmail.com
  • 3 edits
    1 add in trunk/Source/WebCore

[GCrypt] Move definitions of GCryptUtilities helpers into a separate source file
https://bugs.webkit.org/show_bug.cgi?id=187033

Reviewed by Michael Catanzaro.

Move the GCryptUtilities helpers that operate on libgcrypt values and
constants into a separate source file. This limits a bit the amount of
inlining the compiler might feel compelled to do, and the resulting
shared library is 8kB smaller in size.

  • crypto/gcrypt/GCryptUtilities.cpp: Copied from Source/WebCore/crypto/gcrypt/GCryptUtilities.h.

(WebCore::hmacAlgorithm):
(WebCore::digestAlgorithm):
(WebCore::hashCryptoDigestAlgorithm):
(WebCore::mpiLength):
(WebCore::mpiData):
(WebCore::mpiZeroPrefixedData):
(WebCore::mpiSignedData):

  • crypto/gcrypt/GCryptUtilities.h:

(WebCore::hmacAlgorithm): Deleted.
(WebCore::digestAlgorithm): Deleted.
(WebCore::hashCryptoDigestAlgorithm): Deleted.
(WebCore::mpiLength): Deleted.
(WebCore::mpiData): Deleted.
(WebCore::mpiZeroPrefixedData): Deleted.
(WebCore::mpiSignedData): Deleted.

  • platform/SourcesGCrypt.txt:

Jun 26, 2018:

10:06 PM Changeset in webkit [233246] by wenson_hsieh@apple.com
  • 4 edits in trunk/Source

[iPad apps on macOS] Unable to interact with video elements that have started playing
https://bugs.webkit.org/show_bug.cgi?id=187073
<rdar://problem/40591107>

Reviewed by Tim Horton.

Source/WebCore/PAL:

Define an SPI method on CALayer. See WebKit ChangeLog for more detail.

  • pal/spi/cocoa/QuartzCoreSPI.h:

Source/WebKit:

On iOS, we currently force remote hosting contexts to be non-interactive by passing in kCAContextIgnoresHitTest
when creating the CAContext. However, this flag is not respected by CoreAnimation when running iOS apps on macOS.
This means all HID events dispatched over a video that has been played (which causes WebKit to insert a
CALayerHost-backed WKRemoteView in the view hierarchy) will be routed to the context ID of the video's CAContext
rather than the context ID of the key window containing the WKWebView.

This subsequently causes all gesture recognizers (hover, touch, tap, long press) to fail recognition when
running iOS apps on macOS. To address this, we set a flag on WKRemoteView's CALayerHost to prevent hit-testing
to the remote layer. This allows us to avoid routing HID events to the wrong context, and instead target the
main UIWindow.

Manually verified that click, touch, and mouseenter/mouseleave events are dispatched when interacting over a
video element.

  • UIProcess/RemoteLayerTree/ios/RemoteLayerTreeHostIOS.mm:

(-[WKRemoteView initWithFrame:contextID:]):

10:01 PM Changeset in webkit [233245] by Yusuke Suzuki
  • 37 edits in trunk/Source

[JSC] Pass VM& to functions more
https://bugs.webkit.org/show_bug.cgi?id=186241

Reviewed by Mark Lam.

Source/JavaScriptCore:

This patch threads VM& to functions requiring VM& more.

  • API/JSObjectRef.cpp:

(JSObjectIsConstructor):

  • bytecode/AdaptiveInferredPropertyValueWatchpointBase.cpp:

(JSC::AdaptiveInferredPropertyValueWatchpointBase::install):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::fire):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::StructureWatchpoint::fireInternal):
(JSC::AdaptiveInferredPropertyValueWatchpointBase::PropertyWatchpoint::fireInternal):

  • bytecode/AdaptiveInferredPropertyValueWatchpointBase.h:
  • bytecode/CodeBlockJettisoningWatchpoint.cpp:

(JSC::CodeBlockJettisoningWatchpoint::fireInternal):

  • bytecode/CodeBlockJettisoningWatchpoint.h:
  • bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.cpp:

(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::install):
(JSC::LLIntPrototypeLoadAdaptiveStructureWatchpoint::fireInternal):

  • bytecode/LLIntPrototypeLoadAdaptiveStructureWatchpoint.h:
  • bytecode/StructureStubClearingWatchpoint.cpp:

(JSC::StructureStubClearingWatchpoint::fireInternal):

  • bytecode/StructureStubClearingWatchpoint.h:
  • bytecode/Watchpoint.cpp:

(JSC::Watchpoint::fire):
(JSC::WatchpointSet::fireAllWatchpoints):

  • bytecode/Watchpoint.h:
  • dfg/DFGAdaptiveInferredPropertyValueWatchpoint.cpp:

(JSC::DFG::AdaptiveInferredPropertyValueWatchpoint::handleFire):

  • dfg/DFGAdaptiveInferredPropertyValueWatchpoint.h:
  • dfg/DFGAdaptiveStructureWatchpoint.cpp:

(JSC::DFG::AdaptiveStructureWatchpoint::install):
(JSC::DFG::AdaptiveStructureWatchpoint::fireInternal):

  • dfg/DFGAdaptiveStructureWatchpoint.h:
  • dfg/DFGDesiredWatchpoints.cpp:

(JSC::DFG::AdaptiveStructureWatchpointAdaptor::add):

  • llint/LLIntSlowPaths.cpp:

(JSC::LLInt::setupGetByIdPrototypeCache):

  • runtime/ArrayPrototype.cpp:

(JSC::ArrayPrototype::tryInitializeSpeciesWatchpoint):
(JSC::ArrayPrototypeAdaptiveInferredPropertyWatchpoint::handleFire):

  • runtime/ECMAScriptSpecInternalFunctions.cpp:

(JSC::esSpecIsConstructor):

  • runtime/FunctionRareData.cpp:

(JSC::FunctionRareData::AllocationProfileClearingWatchpoint::fireInternal):

  • runtime/FunctionRareData.h:
  • runtime/InferredStructureWatchpoint.cpp:

(JSC::InferredStructureWatchpoint::fireInternal):

  • runtime/InferredStructureWatchpoint.h:
  • runtime/InternalFunction.cpp:

(JSC::InternalFunction::createSubclassStructureSlow):

  • runtime/InternalFunction.h:

(JSC::InternalFunction::createSubclassStructure):

  • runtime/JSCJSValue.h:
  • runtime/JSCJSValueInlines.h:

(JSC::JSValue::isConstructor const):

  • runtime/JSCell.h:
  • runtime/JSCellInlines.h:

(JSC::JSCell::isConstructor):
(JSC::JSCell::methodTable const):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/ObjectPropertyChangeAdaptiveWatchpoint.h:

(JSC::ObjectPropertyChangeAdaptiveWatchpoint::ObjectPropertyChangeAdaptiveWatchpoint):

  • runtime/ProxyObject.cpp:

(JSC::ProxyObject::finishCreation):

  • runtime/ReflectObject.cpp:

(JSC::reflectObjectConstruct):

  • runtime/StructureRareData.cpp:

(JSC::StructureRareData::setObjectToStringValue):
(JSC::ObjectToStringAdaptiveStructureWatchpoint::install):
(JSC::ObjectToStringAdaptiveStructureWatchpoint::fireInternal):
(JSC::ObjectToStringAdaptiveInferredPropertyValueWatchpoint::handleFire):

Source/WebCore:

  • bindings/js/JSCustomElementRegistryCustom.cpp:

(WebCore::JSCustomElementRegistry::define):

9:45 PM Changeset in webkit [233244] by commit-queue@webkit.org
  • 6 edits in trunk/Source/WebKit

Unreviewed, rolling out r233232.
https://bugs.webkit.org/show_bug.cgi?id=187081

"This is breaking launching some plugins" (Requested by youenn
on #webkit).

Reverted changeset:

"Remove quarantine for Webex plugin"
https://bugs.webkit.org/show_bug.cgi?id=187050
https://trac.webkit.org/changeset/233232

9:36 PM Changeset in webkit [233243] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

Rearrange some WebPreferences; move two experimental prefs into the experimental section

  • Shared/WebPreferences.yaml:
8:10 PM Changeset in webkit [233242] by mark.lam@apple.com
  • 3 edits
    1 add in trunk

eval() is wrong about the LiteralParser never throwing any exceptions.
https://bugs.webkit.org/show_bug.cgi?id=187074
<rdar://problem/41461099>

Reviewed by Saam Barati.

JSTests:

  • stress/regress-187074.js: Added.

Source/JavaScriptCore:

Added the missing exception check, and removed an erroneous assertion.

  • interpreter/Interpreter.cpp:

(JSC::eval):

8:03 PM Changeset in webkit [233241] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

CSSGradientValue's color stops vector wastes 12KB on theverge.com
https://bugs.webkit.org/show_bug.cgi?id=186988

Reviewed by Sam Weinig.

Shrink the color stops vector when we're done parsing the stops.

  • css/CSSGradientValue.h:

(WebCore::CSSGradientValue::doneAddingStops):

  • css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::consumeDeprecatedGradient):
(WebCore::CSSPropertyParserHelpers::consumeGradientColorStops):
(WebCore::CSSPropertyParserHelpers::consumeAngularGradientColorStops):

7:10 PM Changeset in webkit [233240] by Chris Dumez
  • 9 edits in trunk

Deal better with the network process crashing on startup
https://bugs.webkit.org/show_bug.cgi?id=187065
<rdar://problem/41451622>

Reviewed by Geoffrey Garen.

Source/WebKit:

When a network process crashes on startup, we would not attempt to relaunch it. If there were web
processes waiting for a connection to this network process, we would send them an invalid connection
identifier which would cause them to forcefully crash.

Instead, we now apply the same policy whether a network process crashes on startup or later:

  • We attempt to relaunch the network process
  • If there were pending connections from WebContent processes, we ask the new Network process instead.

As a result, WebContent processes no longer crash in this case. Instead, they wait for a valid
connection to the network process.

  • UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _makeNextNetworkProcessLaunchFailForTesting]):

  • UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::getLaunchOptions):
(WebKit::NetworkProcessProxy::didFinishLaunching):

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::networkProcessCrashed):

  • UIProcess/WebProcessPool.h:

Tools:

Add layout test coverage.

  • TestWebKitAPI/Tests/WebKit/NetworkProcessCrashWithPendingConnection.mm:

(-[MonitorWebContentCrashNavigationDelegate _webView:webContentProcessDidTerminateWithReason:]):
(-[MonitorWebContentCrashNavigationDelegate webView:didFinishNavigation:]):
(TestWebKitAPI::TEST):

6:58 PM Changeset in webkit [233239] by Yusuke Suzuki
  • 11 edits
    1 delete in trunk

Remove static initializers more
https://bugs.webkit.org/show_bug.cgi?id=186969

Reviewed by Michael Catanzaro.

Source/WebCore:

This patch removes static initializers more. They typically exists in GTK port.

No behavior change.

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • page/ResourceUsageData.cpp: Removed.
  • page/ResourceUsageData.h:

Remove ResourceUsageData constructors since default constructors are enough.

(WebCore::MemoryCategoryInfo::MemoryCategoryInfo):

  • platform/gtk/PasteboardHelper.cpp:

(WebCore::markupPrefix):
(WebCore::removeMarkupPrefix):
(WebCore::PasteboardHelper::fillSelectionData):
Use NeverDestroyed<> and static functions.

  • platform/mediastream/gstreamer/GStreamerAudioCaptureSource.cpp:

(WebCore::defaultVolumeCapability):
(WebCore::GStreamerAudioCaptureSource::capabilities const):
CapabilityValueOrRange's constructor is not constexpr.

  • platform/network/soup/SoupNetworkSession.cpp:

(WebCore::initialAcceptLanguages):
(WebCore::proxySettings):
(WebCore::SoupNetworkSession::SoupNetworkSession):
(WebCore::SoupNetworkSession::setupProxy):
(WebCore::SoupNetworkSession::setProxySettings):
(WebCore::SoupNetworkSession::setInitialAcceptLanguages):
Use NeverDestroyed<> and static functions.

Tools:

  • WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:

(WTR::assignedUrlsCache):
(WTR::dumpResourceURL):
(WTR::InjectedBundlePage::resetAfterTest):
(WTR::InjectedBundlePage::didInitiateLoadForResource):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityNotificationHandlerAtk.cpp:

(WTR::AccessibilityNotificationHandler::setNotificationFunctionCallback):
(WTR::AccessibilityNotificationHandler::removeAccessibilityNotificationHandler):
(WTR::AccessibilityNotificationHandler::connectAccessibilityCallbacks):
(WTR::AccessibilityNotificationHandler::disconnectAccessibilityCallbacks):

  • WebKitTestRunner/InjectedBundle/atk/AccessibilityUIElementAtk.cpp:

(WTR::AccessibilityUIElement::stringAttributeValue):
Use NeverDestroyed<> and static functions.

6:29 PM Changeset in webkit [233238] by youenn@apple.com
  • 6 edits
    32 adds in trunk/LayoutTests

Import wpt CORP tests
https://bugs.webkit.org/show_bug.cgi?id=187027

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/common/get-host-info.sub.js:
  • web-platform-tests/fetch/cross-origin-resource-policy/fetch-expected.txt: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/fetch-in-iframe-expected.txt: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/fetch-in-iframe.html: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/fetch.html: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/iframe-loads-expected.txt: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/iframe-loads.html: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/image-loads-expected.txt: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/image-loads.html: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/resources/green.png: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/resources/hello.py: Added.

(main):

  • web-platform-tests/fetch/cross-origin-resource-policy/resources/iframe.py: Added.

(main):

  • web-platform-tests/fetch/cross-origin-resource-policy/resources/iframeFetch.html: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/resources/image.py: Added.

(main):

  • web-platform-tests/fetch/cross-origin-resource-policy/resources/redirect.py: Added.

(main):

  • web-platform-tests/fetch/cross-origin-resource-policy/resources/script.py: Added.

(main):

  • web-platform-tests/fetch/cross-origin-resource-policy/resources/w3c-import.log: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.any-expected.txt: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.any.html: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.any.js: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.any.worker-expected.txt: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.any.worker.html: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/scheme-restriction.https.window.js: Added.

(promise_test.t.return.new.Promise):
(promise_test.t.finally):

  • web-platform-tests/fetch/cross-origin-resource-policy/script-loads-expected.txt: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/script-loads.html: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/syntax.any-expected.txt: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/syntax.any.html: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/syntax.any.js: Added.

(string_appeared_here.forEach.incorrectHeaderValue.promise_test.t.return.fetch.crossOriginURL.encodeURIComponent):

  • web-platform-tests/fetch/cross-origin-resource-policy/syntax.any.worker-expected.txt: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/syntax.any.worker.html: Added.
  • web-platform-tests/fetch/cross-origin-resource-policy/w3c-import.log: Added.

LayoutTests:

Skipping tests for WK1.

  • platform/ios-wk1/TestExpectations:
  • platform/mac-wk1/TestExpectations:
  • platform/win/TestExpectations:
6:23 PM Changeset in webkit [233237] by dbates@webkit.org
  • 9 edits
    3 adds in trunk

REGRESSION (r231479): Unable to buy Odeon cinema tickets in STP (bogus 'X-Frame-Options' to 'SAMEORIGIN')
https://bugs.webkit.org/show_bug.cgi?id=186090
<rdar://problem/40692595>

Reviewed by Andy Estes.

Source/WebCore:

Fix up Content Security Policy logic for checking the frame ancestors now that we
exclude the frame that initiated the load request.

Test: http/tests/security/XFrameOptions/cross-origin-iframe-post-form-to-parent-same-origin-x-frame-options-page-allow.html

  • page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::allowFrameAncestors const):

  • page/csp/ContentSecurityPolicyDirectiveList.cpp:

(WebCore::checkFrameAncestors):

Source/WebKit:

Fixes an issue where a page P delivered with "X-Frame-Options: SAMEORIGIN" loaded in a sub-
frame would be blocked if we were redirected to it in response to the cross-origin POST
request regardless of whether P is same-origin with its parent document.

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::shouldInterruptLoadForXFrameOptions): Compare the origin
of the top frame's document as opposed to the source origin. The latter represents the
origin of the document that initiated the navigation, which can be cross-origin, and
should not be considered when applying "X-Frame-Options: SAMEORIGIN". This check exists
as a performance optimization to avoid traversing over all frame ancestors only to find
out that the innermost frame (the one that made this request) is cross-origin with the
top-most frame.

  • NetworkProcess/NetworkResourceLoader.h:
  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess): Exclude the origin of the
frame that is making the load request from the list of ancestor origins. This makes the
X-Frame-Options algorithm in WebKit2 match the logic we do in FrameLoader::shouldInterruptLoadForXFrameOptions().

LayoutTests:

Add a test to ensure that we allow a same-origin page with "X-Frame-Options: SAMEORIGIN" to
load as a result of a redirected cross-origin POST request.

  • http/tests/security/XFrameOptions/cross-origin-iframe-post-form-to-parent-same-origin-x-frame-options-page-allow-expected.txt: Added.
  • http/tests/security/XFrameOptions/cross-origin-iframe-post-form-to-parent-same-origin-x-frame-options-page-allow.html: Added.
  • http/tests/security/XFrameOptions/resources/post-form-to-x-frame-options-parent-same-origin-allow.html: Added.
  • http/tests/security/XFrameOptions/resources/x-frame-options-parent-same-origin-allow.cgi:
6:08 PM Changeset in webkit [233236] by sbarati@apple.com
  • 25 edits in trunk

JSImmutableButterfly can't be allocated from a subspace with HeapCell::Kind::Auxiliary
https://bugs.webkit.org/show_bug.cgi?id=186878
<rdar://problem/40568659>

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This patch fixes a bug in our JSImmutableButterfly implementation uncovered by
our stress GC bots. Before this patch, JSImmutableButterfly was allocated
with HeapCell::Kind::Auxiliary. This is wrong. Things that are JSCells can't
be allocated from HeapCell::Kind::Auxiliary. This patch adds a new HeapCell::Kind
called JSCellWithInteriorPointers. It behaves like JSCell in all ways, except
conservative scan knows to treat it like a butterfly in when we we may be
pointing into the middle of it.

The way we were crashing on the stress GC bots is that our conservative marking
won't do cell visiting for things that are Auxiliary. This meant that if the
stack were the only thing pointing to a JSImmutableButterfly when a GC took place,
that JSImmutableButterfly would not be visited. This is now fixed.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ArrayNode::emitBytecode):

  • debugger/Debugger.cpp:
  • heap/ConservativeRoots.cpp:

(JSC::ConservativeRoots::genericAddPointer):

  • heap/Heap.cpp:

(JSC::GatherHeapSnapshotData::operator() const):
(JSC::RemoveDeadHeapSnapshotNodes::operator() const):
(JSC::Heap::globalObjectCount):
(JSC::Heap::objectTypeCounts):
(JSC::Heap::deleteAllCodeBlocks):

  • heap/HeapCell.cpp:

(WTF::printInternal):

  • heap/HeapCell.h:

(JSC::isJSCellKind):
(JSC::hasInteriorPointers):

  • heap/HeapUtil.h:

(JSC::HeapUtil::findGCObjectPointersForMarking):
(JSC::HeapUtil::isPointerGCObjectJSCell):

  • heap/MarkedBlock.cpp:

(JSC::MarkedBlock::Handle::didAddToDirectory):

  • heap/SlotVisitor.cpp:

(JSC::SlotVisitor::appendJSCellOrAuxiliary):

  • runtime/JSGlobalObject.cpp:
  • runtime/JSImmutableButterfly.h:

(JSC::JSImmutableButterfly::subspaceFor):

  • runtime/VM.cpp:

(JSC::VM::VM):

  • runtime/VM.h:
  • tools/CellProfile.h:

(JSC::CellProfile::CellProfile):
(JSC::CellProfile::isJSCell const):

  • tools/HeapVerifier.cpp:

(JSC::HeapVerifier::validateCell):

LayoutTests:

Make these test not susceptible to conservative scan leaks by ensuring at least
one object gets collected when we allocate many of them. Before, these were just
testing that a fixed number of objects were collected.

  • editing/selection/navigation-clears-editor-state-expected.txt:
  • editing/selection/navigation-clears-editor-state.html:
  • fast/dom/reference-cycle-leaks.html:
  • fast/misc/resources/test-observegc.js:
  • fast/misc/test-observegc-expected.txt:
  • platform/mac-wk2/plugins/refcount-leaks-expected.txt:
  • plugins/refcount-leaks-expected.txt:
  • plugins/refcount-leaks.html:
6:07 PM Changeset in webkit [233235] by aakash_jain@apple.com
  • 7 edits in trunk/Tools

[ews-build] Add support for compiling WebKit
https://bugs.webkit.org/show_bug.cgi?id=187019

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-build/steps.py:

(CompileWebKit): Added, class to compile WebKit.
(CleanBuild): Added, class to clean up the build.
(KillOldProcesses): Added, class to kill old processes.

  • BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
  • BuildSlaveSupport/ews-build/config.json: Renamed ios-11-simulator to ios-simulator-11, to match with build.webkit.org code.

Added configuration, architecture which is required for compiling. Renamed Release to release as the tools expect lower-case release.

  • BuildSlaveSupport/ews-build/factories.py: Added BuildFactory.
  • BuildSlaveSupport/ews-build/loadConfig.py: Renamed configuraton value to lower-case as tools expect lower-case values.
  • BuildSlaveSupport/ews-build/loadConfig_unittest.py: Ditto.
5:43 PM Changeset in webkit [233234] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Skip some unnecessary work in Interpreter::getStackTrace().
https://bugs.webkit.org/show_bug.cgi?id=187070

Reviewed by Michael Saboff.

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::getStackTrace):

5:41 PM Changeset in webkit [233233] by commit-queue@webkit.org
  • 2 edits
    2 adds in trunk/LayoutTests

[iOS] Rebaseline two webanimations tests after r233164
https://bugs.webkit.org/show_bug.cgi?id=187071

Unreviewed gardening

Patch by Truitt Savell <Truitt Savell> on 2018-06-26

  • platform/ios/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
  • platform/ios/webanimations/opacity-animation-yields-compositing-span-expected.txt: Added.
5:31 PM Changeset in webkit [233232] by youenn@apple.com
  • 6 edits in trunk/Source/WebKit

Remove quarantine for Webex plugin
https://bugs.webkit.org/show_bug.cgi?id=187050
rdar://problem/41478189

Reviewed by Brent Fulgham.

Update the Plugin Info.plist to not do quarantine of downloaded files by default.
Update PluginProcess implementation to reenable quarantine for all plug-ins except cisco webex plug-in.

  • PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
  • PluginProcess/PluginProcess.h:
  • PluginProcess/mac/PluginProcessMac.mm:

(WebKit::PluginProcess::shouldOverrideQuarantine):

  • Shared/ChildProcess.h:

(WebKit::ChildProcess::shouldOverrideQuarantine):

  • Shared/mac/ChildProcessMac.mm:

(WebKit::ChildProcess::initializeSandbox):

5:25 PM Changeset in webkit [233231] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Ensure element fullscreen animation is always visible.
https://bugs.webkit.org/show_bug.cgi?id=187068
rdar://problem/36187369

Patch by Jeremy Jones <jeremyj@apple.com> on 2018-06-26
Reviewed by Eric Carlson.

The fullscreen animation is important for communicating to users that they are no longer in inline mode.
If fullscreen animation's inline rect is not visible, animate from a point in the middle of the screen.

  • UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:

(WebKit::safeInlineRect):
(-[WKFullScreenWindowController beganEnterFullScreenWithInitialFrame:finalFrame:]):
(-[WKFullScreenWindowController beganExitFullScreenWithInitialFrame:finalFrame:]):

5:22 PM Changeset in webkit [233230] by youenn@apple.com
  • 2 edits
    1 add in trunk/Source/WebKit

Add a sandbox profile for com.google.o1dbrowserplugin plugin
https://bugs.webkit.org/show_bug.cgi?id=187067

Reviewed by Brent Fulgham.

  • Resources/PlugInSandboxProfiles/com.google.o1dbrowserplugin.sb: Added.
  • WebKit.xcodeproj/project.pbxproj:
5:16 PM Changeset in webkit [233229] by aakash_jain@apple.com
  • 5 edits in trunk/Tools

[ews-build] Add support for WebKitPerl-Tests-EWS
https://bugs.webkit.org/show_bug.cgi?id=187023

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-build/config.json: Added WebKitPerl-tests-EWS.
  • BuildSlaveSupport/ews-build/factories.py: Added WebKitPerlFactory.
  • BuildSlaveSupport/ews-build/steps.py: Added build step RunWebKitPerlTests.
  • BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
5:10 PM Changeset in webkit [233228] by aakash_jain@apple.com
  • 2 edits in trunk/Tools

[build.webkit.org] Rename badly named variable kls to schedulerType
https://bugs.webkit.org/show_bug.cgi?id=186926

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/build.webkit.org-config/loadConfig.py:

(loadBuilderConfig): Renamed kls to schedulerType.

4:22 PM Changeset in webkit [233227] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

Promote two more experimental features to traditional features
https://bugs.webkit.org/show_bug.cgi?id=187063

Reviewed by Dean Jackson.

  • Shared/WebPreferences.yaml:

Promote some shipped/default-on features to non-experimental.

3:28 PM Changeset in webkit [233226] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

Rollout macOS sandbox change in r232276
https://bugs.webkit.org/show_bug.cgi?id=186904
<rdar://problem/41350969>

Patch by Jiewen Tan <jiewen_tan@apple.com> on 2018-06-26
Reviewed by Brent Fulgham.

  • NetworkProcess/mac/com.apple.WebKit.NetworkProcess.sb.in:
3:20 PM Changeset in webkit [233225] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebKit

Tap highlight displayed when tapping a field that is already focussed
https://bugs.webkit.org/show_bug.cgi?id=187004
<rdar://problem/41428008>
Patch by Aditya Keerthi <Aditya Keerthi> on 2018-06-26
Reviewed by Tim Horton.

In the case where fast-clicking is enabled, _singleTapCommited: could be invoked
before the tap highlight request, causing _potentialTapInProgress to be set to NO.
This results in the early return for preventing multiple tap highlights on an
assisted node to be skipped. Since a tap highlight should never be shown for an
input field that is already focussed, _potentialTapInProgress can be removed from
the early return condition.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]):

3:18 PM Changeset in webkit [233224] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

REGRESSION (r232314): Flaky Test: imported/w3c/web-platform-tests/streams/piping/error-propagation-forward.html
https://bugs.webkit.org/show_bug.cgi?id=186161

Unreviewed gardening.

Patch by Truitt Savell <Truitt Savell> on 2018-06-26

2:45 PM Changeset in webkit [233223] by Kocsen Chung
  • 1 copy in tags/Safari-606.1.22.2

Tag Safari-606.1.22.2.

2:42 PM Changeset in webkit [233222] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Simplify NetworkStorageSession::getAllStorageAccessEntries()
https://bugs.webkit.org/show_bug.cgi?id=187016

Reviewed by Youenn Fablet.

Iterate over the HashMaps' values instead of iterating over their keys and then looking them
up in the HashMap.

  • platform/network/cf/NetworkStorageSessionCFNet.cpp:

(WebCore::NetworkStorageSession::getAllStorageAccessEntries const):

2:15 PM Changeset in webkit [233221] by Kocsen Chung
  • 7 edits in branches/safari-606.1.22-branch/Source

Versioning.

2:13 PM Changeset in webkit [233220] by dbates@webkit.org
  • 3 edits in trunk/Tools

EWS should pass --status-host-uses-http when invoking webkit-patch, if needed
https://bugs.webkit.org/show_bug.cgi?id=187061

Reviewed by Per Arne Vollan.

When EWS invokes webkit-patch to perform an operation (e.g. apply an attachment)
it should pass the command line option --status-host-uses-http, if EWS was
started with this command line option, so that we query the status server over
HTTP in child "webkit-patch" processes as we do in the main EWS process.

  • Scripts/webkitpy/common/net/statusserver_mock.py:

(MockStatusServer.init):

  • Scripts/webkitpy/tool/commands/queues.py:

(AbstractQueue.run_webkit_patch):

1:54 PM Changeset in webkit [233219] by dbates@webkit.org
  • 4 edits in trunk/Tools

webkit-patch: Make attachment commands work with status-server hosted attachments
https://bugs.webkit.org/show_bug.cgi?id=187056

Reviewed by Per Arne Vollan.

Allow the EWS bots to apply, build, test, check-style, and (in the future) land
attachments hosted on the status server. We only download an attachment from the
status server if we do not have sufficient permission to download it from Bugzilla
(e.g. security-sensitive patches).

A valid status server API key is required to run these commands by hand. Otherwise,
the status server will not provide attachment data.

  • Scripts/webkitpy/common/net/statusserver_mock.py:

(MockStatusServer.fetch_attachment): Log a message for testing purposes.

  • Scripts/webkitpy/tool/commands/download.py:

(ProcessAttachmentsMixin._fetch_list_of_patches_to_process): Fetch the attachment
from the status server if we do not have permission to fetch it from Bugzilla.

  • Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:

(EarlyWarningSystemTest._default_expected_logs): Update expected result when
using a custom work item and when fetching an attachment from the status server.
(_test_ews): Modified to take use_security_sensitive_patch (defaults to False) as
to whether to use a security-sensitive patch when testing.
(test_ewses_with_security_sensitive_patch): Added.

1:38 PM Changeset in webkit [233218] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

Rearrange some WebPreferences; move two non-experimental prefs out of the experimental section

  • Shared/WebPreferences.yaml:
1:37 PM Changeset in webkit [233217] by mark.lam@apple.com
  • 3 edits
    1 add in trunk

ASSERTION FAILED: length > butterfly->vectorLength() in JSObject::ensureLengthSlow().
https://bugs.webkit.org/show_bug.cgi?id=187060
<rdar://problem/41452767>

Reviewed by Keith Miller.

JSTests:

  • stress/regress-187060.js: Added.

Source/JavaScriptCore:

JSObject::ensureLengthSlow() may be called only because it needs to do a copy on
write conversion. Hence, we can return early after the conversion if the vector
length is already sufficient to cover the requested length.

  • runtime/JSObject.cpp:

(JSC::JSObject::ensureLengthSlow):

12:39 PM Changeset in webkit [233216] by sbarati@apple.com
  • 2 edits in trunk/Source/bmalloc

Unreviewed followup. Fix the watchos build after r233192.

This patch also correct the changelog entry below to have the correct
bug and title info.

  • bmalloc/ProcessCheck.mm:
12:27 PM Changeset in webkit [233215] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

Promote some experimental features to traditional features
https://bugs.webkit.org/show_bug.cgi?id=187047

Reviewed by Simon Fraser.

  • Shared/WebPreferences.yaml:

Reindent.
Promote some shipped/default-on features to non-experimental.

12:14 PM Changeset in webkit [233214] by eric.carlson@apple.com
  • 13 edits in trunk/Source

[Mac] AirPlay picker uses incorrect theme in Dark mode
https://bugs.webkit.org/show_bug.cgi?id=187054
<rdar://problem/41291093>

Reviewed by Timothy Hatcher.

Source/WebCore:

  • Modules/mediasession/WebMediaSessionManager.cpp:

(WebCore::WebMediaSessionManager::showPlaybackTargetPicker): Add useDefaultAppearance parameter.

  • Modules/mediasession/WebMediaSessionManager.h:
  • platform/graphics/MediaPlaybackTargetPicker.cpp:

(WebCore::MediaPlaybackTargetPicker::showPlaybackTargetPicker): Ditto.

  • platform/graphics/MediaPlaybackTargetPicker.h:
  • platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.h:
  • platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:

(WebCore::MediaPlaybackTargetPickerMac::showPlaybackTargetPicker): Choose theme based on
useDefaultAppearance parameter.

  • platform/mock/MediaPlaybackTargetPickerMock.cpp:

(WebCore::MediaPlaybackTargetPickerMock::showPlaybackTargetPicker): Log parameter.

  • platform/mock/MediaPlaybackTargetPickerMock.h:

Source/WebKit:

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::showPlaybackTargetPicker): Pass m_defaultAppearance.

Source/WebKitLegacy/mac:

  • WebView/WebMediaPlaybackTargetPicker.mm:

(WebMediaPlaybackTargetPicker::showPlaybackTargetPicker): Pass page->defaultAppearance().

12:14 PM Changeset in webkit [233213] by commit-queue@webkit.org
  • 13 edits in trunk

Unreviewed, rolling out r233184.
https://bugs.webkit.org/show_bug.cgi?id=187059

"It regressed JetStream between 5-8%" (Requested by saamyjoon
on #webkit).

Reverted changeset:

"JSImmutableButterfly can't be allocated from a subspace with
HeapCell::Kind::Auxiliary"
https://bugs.webkit.org/show_bug.cgi?id=186878
https://trac.webkit.org/changeset/233184

12:13 PM Changeset in webkit [233212] by cturner@igalia.com
  • 2 edits in trunk/LayoutTests

[GTK] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=187048

Unreviewed gardening.

  • platform/gtk/TestExpectations:
11:45 AM Changeset in webkit [233211] by dbates@webkit.org
  • 2 edits in trunk/Tools

contributors.json fails to parse after r233209

Removing trailing ',' that caused this file to be malformed. Also ran
"validate-committer-lists -c" to canonicalize the style of this file.

  • Scripts/webkitpy/common/config/contributors.json:
11:40 AM Changeset in webkit [233210] by Kocsen Chung
  • 7 edits in trunk/Source

Versioning.

11:28 AM Changeset in webkit [233209] by timothy_horton@apple.com
  • 2 edits in trunk/Tools

Add Aditya to contributors.json as a contributor

  • Scripts/webkitpy/common/config/contributors.json:
11:26 AM Changeset in webkit [233208] by Chris Dumez
  • 2 edits in trunk/Source/WebKit

Resource Load Statistics: Make WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains() wait for the network process before calling its callback
https://bugs.webkit.org/show_bug.cgi?id=186903
<rdar://problem/41350182>

Reviewed by Brady Eidson.

Follow-up fix after r233180 to address an API test crash. We need to keep the
NetworkProcessProxy alive during the async updatePrevalentDomainsToPartitionOrBlockCookies
request to make sure it completes.

  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::updatePrevalentDomainsToPartitionOrBlockCookies):

11:16 AM Changeset in webkit [233207] by Brent Fulgham
  • 9 edits
    3 copies
    1 add in trunk

Provide a way for Injected Bundles to indicate classes approved for NSSecureCoding
https://bugs.webkit.org/show_bug.cgi?id=186788
<rdar://problem/41094167>

Reviewed by Chris Dumez.

Source/WebKit:

InjectedBundles support a mechanism to serialize data between the UIProcess and the
WebContent process hosting the bundle. In some cases, we want to be able to serialize
a custom data object that is not part of WebKit's native data types.

After switching to strict NSSecureCoding, WebKit clients attempting to serialize these
custom objects trigger a failure.

This patch makes it possible for the InjectedBundle author to specify one (or more) data
classes that are allowed to be serialized between the two processes.

  • WebProcess/InjectedBundle/API/c/WKBundle.cpp:

(WKBundleExtendClassesForParameterCoder): Added.

  • WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.h:
  • WebProcess/InjectedBundle/API/mac/WKWebProcessPlugIn.mm:

(createWKArray): Added.
(-[WKWebProcessPlugInController extendClassesForParameterCoder:]): Added.

  • WebProcess/InjectedBundle/InjectedBundle.h:
  • WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:

(WebKit::InjectedBundle::extendClassesForParameterCoder): Added.
(WebKit::InjectedBundle::classesForCoder): New helper function.
(WebKit::InjectedBundle::setBundleParameter): Modified to use the new set of valid
classes for NSSecureCoding.

Tools:

Add a new test case to exercise the class check during NSSecureCoding.

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebKit/mac/CustomBundleObject.h: Added.
  • TestWebKitAPI/Tests/WebKit/mac/CustomBundleObject.mm: Added.

(-[CustomBundleObject initWithValue:]):
(+[CustomBundleObject supportsSecureCoding]):
(-[CustomBundleObject copyWithZone:]):
(-[CustomBundleObject initWithCoder:]):
(-[CustomBundleObject encodeWithCoder:]):

  • TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter.mm: Added.

(TestWebKitAPI::didReceiveMessageFromInjectedBundle):
(TestWebKitAPI::didFinishLoadForFrame):

  • TestWebKitAPI/Tests/WebKit/mac/CustomBundleParameter_Bundle.mm: Added.

(TestWebKitAPI::CustomBundleParameterTest::CustomBundleParameterTest):
(TestWebKitAPI::CustomBundleParameterTest::didCreatePage):

11:00 AM Changeset in webkit [233206] by clopez@igalia.com
  • 2 edits in trunk/Source/JavaScriptCore

REGRESSION(r233065): Build broken with clang-3.8 and libstdc++-5
https://bugs.webkit.org/show_bug.cgi?id=187051

Reviewed by Mark Lam.

Revert r233065 changes over UnlinkedCodeBlock.h to allow
clang-3.8 to be able to compile this back (with libstdc++5)

  • bytecode/UnlinkedCodeBlock.h:

(JSC::UnlinkedCodeBlock::decompressArrayAllocationProfile):

10:50 AM Changeset in webkit [233205] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

Layout Test http/tests/resourceLoadStatistics/prevalent-resource-without-user-interaction.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=187053

Unreviewed test gardening.

Patch by Truitt Savell <Truitt Savell> on 2018-06-26

  • platform/wk2/TestExpectations:
10:38 AM Changeset in webkit [233204] by Ryan Haddad
  • 2 edits in trunk/Source/JavaScriptCore

Fix testapi build when DFG_JIT is disabled
https://bugs.webkit.org/show_bug.cgi?id=187038

Patch by Tadeu Zagallo <Tadeu Zagallo> on 2018-06-26
Reviewed by Mark Lam.

r233158 added a new API and tests for configuring the number of JIT threads, but
the API is only available when DFG_JIT is enabled and so should the tests.

  • API/tests/testapi.mm:

(runJITThreadLimitTests):

10:06 AM Changeset in webkit [233203] by eric.carlson@apple.com
  • 5 edits in trunk

Enable mock capture devices on the iOS simulator
https://bugs.webkit.org/show_bug.cgi?id=186846
<rdar://problem/41289134>

Reviewed by Youenn Fablet.

Source/WebKit:

  • Shared/WebPreferences.yaml: Use DEFAULT_MOCK_CAPTURE_DEVICES_ENABLED.
  • Shared/WebPreferencesDefaultValues.h: Define DEFAULT_MOCK_CAPTURE_DEVICES_ENABLED, set to

true in the iOS simulator only.

LayoutTests:

  • platform/ios/TestExpectations: Unskip fast/mediastream/getUserMedia-default.html.
9:58 AM Changeset in webkit [233202] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[GStreamer] Do not forget to set stream on track switching
https://bugs.webkit.org/show_bug.cgi?id=187049

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-06-26
Reviewed by Philippe Normand.

This was an overlooked issue introduced in Bug #186678

This is already tested, but we currently run only tests against playbin2

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::enableTrack):

9:45 AM Changeset in webkit [233201] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC] Fixed positioning is a subcategory of absolute positioning.
https://bugs.webkit.org/show_bug.cgi?id=187043

Reviewed by Antti Koivisto.

https://www.w3.org/TR/CSS22/visuren.html#absolute-positioning
References in this specification to an absolutely positioned element (or its box) imply that the element's 'position'
property has the value 'absolute' or 'fixed'.

  • layout/layouttree/LayoutBox.cpp:

(WebCore::Layout::Box::isAbsolutelyPositioned const):

  • layout/layouttree/LayoutBox.h:

(WebCore::Layout::Box::isOutOfFlowPositioned const):

8:39 AM WebKitGTK/2.20.x edited by Michael Catanzaro
(diff)
8:27 AM Changeset in webkit [233200] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Unreviewed, rolling out r233143.
https://bugs.webkit.org/show_bug.cgi?id=187046

broke media/video-ended-event-negative-playback.html
(Requested by philn on #webkit).

Reverted changeset:

"[GStreamer] Remove useless workaround"
https://bugs.webkit.org/show_bug.cgi?id=186921
https://trac.webkit.org/changeset/233143

7:23 AM Changeset in webkit [233199] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test imported/mozilla/css-animations/test_animation-pausing.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=187041

Unreviewed test gardening.

  • platform/win/TestExpectations:
6:36 AM Changeset in webkit [233198] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC] Computed height for in-flow non-replaced should not include padding and border.
https://bugs.webkit.org/show_bug.cgi?id=187031

Reviewed by Antti Koivisto.

In certain cases the height of a non-replaced in-flow box is computed using the bottom position of its last in-flow child.
The in-flow child's bottom position is in the coordinate system of the containing block's border box (border box's top left is 0, 0) ->
it includes both the (top) border and the padding of the containing block.

  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

6:01 AM Changeset in webkit [233197] by fred.wang@free.fr
  • 5 edits
    196 adds in trunk/LayoutTests

Import WPT tests for webmessaging
https://bugs.webkit.org/show_bug.cgi?id=187001

Patch by Frederic Wang <fwang@igalia.com> on 2018-06-26
Reviewed by Javier Fernandez.

LayoutTests/imported/w3c:

  • resources/import-expectations.json:
  • resources/resource-files.json:
  • web-platform-tests/webmessaging/Channel_postMessage_Blob-expected.txt: Added.
  • web-platform-tests/webmessaging/Channel_postMessage_Blob.htm: Added.
  • web-platform-tests/webmessaging/Channel_postMessage_DataCloneErr-expected.txt: Added.
  • web-platform-tests/webmessaging/Channel_postMessage_DataCloneErr.htm: Added.
  • web-platform-tests/webmessaging/Channel_postMessage_clone_port-expected.txt: Added.
  • web-platform-tests/webmessaging/Channel_postMessage_clone_port.htm: Added.
  • web-platform-tests/webmessaging/Channel_postMessage_clone_port_error-expected.txt: Added.
  • web-platform-tests/webmessaging/Channel_postMessage_clone_port_error.htm: Added.
  • web-platform-tests/webmessaging/Channel_postMessage_event_properties-expected.txt: Added.
  • web-platform-tests/webmessaging/Channel_postMessage_event_properties.htm: Added.
  • web-platform-tests/webmessaging/Channel_postMessage_ports_readonly_array-expected.txt: Added.
  • web-platform-tests/webmessaging/Channel_postMessage_ports_readonly_array.htm: Added.
  • web-platform-tests/webmessaging/Channel_postMessage_target_source-expected.txt: Added.
  • web-platform-tests/webmessaging/Channel_postMessage_target_source.htm: Added.
  • web-platform-tests/webmessaging/META.yml: Added.
  • web-platform-tests/webmessaging/MessageEvent-expected.txt: Added.
  • web-platform-tests/webmessaging/MessageEvent-trusted-expected.txt: Added.
  • web-platform-tests/webmessaging/MessageEvent-trusted-worker.js: Added.
  • web-platform-tests/webmessaging/MessageEvent-trusted.html: Added.
  • web-platform-tests/webmessaging/MessageEvent.html: Added.
  • web-platform-tests/webmessaging/MessageEvent_onmessage_postMessage_infinite_loop.html: Added.
  • web-platform-tests/webmessaging/MessageEvent_properties.htm: Added.
  • web-platform-tests/webmessaging/MessagePort_initial_disabled-expected.txt: Added.
  • web-platform-tests/webmessaging/MessagePort_initial_disabled.htm: Added.
  • web-platform-tests/webmessaging/MessagePort_onmessage_start-expected.txt: Added.
  • web-platform-tests/webmessaging/MessagePort_onmessage_start.htm: Added.
  • web-platform-tests/webmessaging/README.md: Added.
  • web-platform-tests/webmessaging/Transferred_objects_unusable.sub.htm: Added.
  • web-platform-tests/webmessaging/broadcastchannel/basics-expected.txt: Added.
  • web-platform-tests/webmessaging/broadcastchannel/basics.html: Added.
  • web-platform-tests/webmessaging/broadcastchannel/blobs-expected.txt: Added.
  • web-platform-tests/webmessaging/broadcastchannel/blobs.html: Added.
  • web-platform-tests/webmessaging/broadcastchannel/interface-expected.txt: Added.
  • web-platform-tests/webmessaging/broadcastchannel/interface.html: Added.
  • web-platform-tests/webmessaging/broadcastchannel/origin.window.js: Added.
  • web-platform-tests/webmessaging/broadcastchannel/resources/origin.html: Added.
  • web-platform-tests/webmessaging/broadcastchannel/resources/sandboxed.html: Added.
  • web-platform-tests/webmessaging/broadcastchannel/resources/w3c-import.log: Added.
  • web-platform-tests/webmessaging/broadcastchannel/resources/worker.js: Added.

(handler):

  • web-platform-tests/webmessaging/broadcastchannel/sandbox-expected.txt: Added.
  • web-platform-tests/webmessaging/broadcastchannel/sandbox.html: Added.
  • web-platform-tests/webmessaging/broadcastchannel/w3c-import.log: Added.
  • web-platform-tests/webmessaging/broadcastchannel/workers.html: Added.
  • web-platform-tests/webmessaging/event.data.sub.htm: Added.
  • web-platform-tests/webmessaging/event.origin.sub.htm: Added.
  • web-platform-tests/webmessaging/event.ports.sub.htm: Added.
  • web-platform-tests/webmessaging/event.source.htm: Added.
  • web-platform-tests/webmessaging/event.source.xorigin.sub.htm: Added.
  • web-platform-tests/webmessaging/message-channels/001-expected.txt: Added.
  • web-platform-tests/webmessaging/message-channels/001.html: Added.
  • web-platform-tests/webmessaging/message-channels/002-expected.txt: Added.
  • web-platform-tests/webmessaging/message-channels/002.html: Added.
  • web-platform-tests/webmessaging/message-channels/003-expected.txt: Added.
  • web-platform-tests/webmessaging/message-channels/003.html: Added.
  • web-platform-tests/webmessaging/message-channels/004-1.html: Added.
  • web-platform-tests/webmessaging/message-channels/004-2.html: Added.
  • web-platform-tests/webmessaging/message-channels/004-expected.txt: Added.
  • web-platform-tests/webmessaging/message-channels/004.html: Added.
  • web-platform-tests/webmessaging/message-channels/close-expected.txt: Added.
  • web-platform-tests/webmessaging/message-channels/close.html: Added.
  • web-platform-tests/webmessaging/message-channels/w3c-import.log: Added.
  • web-platform-tests/webmessaging/message-channels/worker-expected.txt: Added.
  • web-platform-tests/webmessaging/message-channels/worker.html: Added.
  • web-platform-tests/webmessaging/messageerror-expected.txt: Added.
  • web-platform-tests/webmessaging/messageerror.html: Added.
  • web-platform-tests/webmessaging/postMessage_ArrayBuffer.sub.htm: Added.
  • web-platform-tests/webmessaging/postMessage_Date.sub.htm: Added.
  • web-platform-tests/webmessaging/postMessage_Document-expected.txt: Added.
  • web-platform-tests/webmessaging/postMessage_Document.htm: Added.
  • web-platform-tests/webmessaging/postMessage_Function-expected.txt: Added.
  • web-platform-tests/webmessaging/postMessage_Function.htm: Added.
  • web-platform-tests/webmessaging/postMessage_MessagePorts_sorigin.htm: Added.
  • web-platform-tests/webmessaging/postMessage_MessagePorts_xorigin.sub.htm: Added.
  • web-platform-tests/webmessaging/postMessage_arrays.sub.htm: Added.
  • web-platform-tests/webmessaging/postMessage_asterisk_xorigin.sub.htm: Added.
  • web-platform-tests/webmessaging/postMessage_dup_transfer_objects-expected.txt: Added.
  • web-platform-tests/webmessaging/postMessage_dup_transfer_objects.htm: Added.
  • web-platform-tests/webmessaging/postMessage_invalid_targetOrigin-expected.txt: Added.
  • web-platform-tests/webmessaging/postMessage_invalid_targetOrigin.htm: Added.
  • web-platform-tests/webmessaging/postMessage_objects.sub.htm: Added.
  • web-platform-tests/webmessaging/postMessage_origin_mismatch.sub.htm: Added.
  • web-platform-tests/webmessaging/postMessage_origin_mismatch_xorigin.sub.htm: Added.
  • web-platform-tests/webmessaging/postMessage_solidus_sorigin.htm: Added.
  • web-platform-tests/webmessaging/postMessage_solidus_xorigin.sub.htm: Added.
  • web-platform-tests/webmessaging/w3c-import.log: Added.
  • web-platform-tests/webmessaging/with-ports/001-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/001.html: Added.
  • web-platform-tests/webmessaging/with-ports/002-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/002.html: Added.
  • web-platform-tests/webmessaging/with-ports/003-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/003.html: Added.
  • web-platform-tests/webmessaging/with-ports/004-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/004.html: Added.
  • web-platform-tests/webmessaging/with-ports/005-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/005.html: Added.
  • web-platform-tests/webmessaging/with-ports/006-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/006.html: Added.
  • web-platform-tests/webmessaging/with-ports/007-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/007.html: Added.
  • web-platform-tests/webmessaging/with-ports/010-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/010.html: Added.
  • web-platform-tests/webmessaging/with-ports/011-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/011.html: Added.
  • web-platform-tests/webmessaging/with-ports/012-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/012.html: Added.
  • web-platform-tests/webmessaging/with-ports/013-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/013.html: Added.
  • web-platform-tests/webmessaging/with-ports/014-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/014.html: Added.
  • web-platform-tests/webmessaging/with-ports/015-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/015.html: Added.
  • web-platform-tests/webmessaging/with-ports/016-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/016.html: Added.
  • web-platform-tests/webmessaging/with-ports/017-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/017.html: Added.
  • web-platform-tests/webmessaging/with-ports/018-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/018.html: Added.
  • web-platform-tests/webmessaging/with-ports/019-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/019.html: Added.
  • web-platform-tests/webmessaging/with-ports/020.html: Added.
  • web-platform-tests/webmessaging/with-ports/021.html: Added.
  • web-platform-tests/webmessaging/with-ports/023-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/023.html: Added.
  • web-platform-tests/webmessaging/with-ports/024-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/024.html: Added.
  • web-platform-tests/webmessaging/with-ports/025-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/025.html: Added.
  • web-platform-tests/webmessaging/with-ports/026-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/026.html: Added.
  • web-platform-tests/webmessaging/with-ports/027-expected.txt: Added.
  • web-platform-tests/webmessaging/with-ports/027.html: Added.
  • web-platform-tests/webmessaging/with-ports/w3c-import.log: Added.
  • web-platform-tests/webmessaging/without-ports/001-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/001.html: Added.
  • web-platform-tests/webmessaging/without-ports/002-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/002.html: Added.
  • web-platform-tests/webmessaging/without-ports/003-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/003.html: Added.
  • web-platform-tests/webmessaging/without-ports/004-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/004.html: Added.
  • web-platform-tests/webmessaging/without-ports/005-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/005.html: Added.
  • web-platform-tests/webmessaging/without-ports/006-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/006.html: Added.
  • web-platform-tests/webmessaging/without-ports/007-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/007.html: Added.
  • web-platform-tests/webmessaging/without-ports/008-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/008.html: Added.
  • web-platform-tests/webmessaging/without-ports/009-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/009.html: Added.
  • web-platform-tests/webmessaging/without-ports/010-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/010.html: Added.
  • web-platform-tests/webmessaging/without-ports/011-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/011.html: Added.
  • web-platform-tests/webmessaging/without-ports/012-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/012.html: Added.
  • web-platform-tests/webmessaging/without-ports/013-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/013.html: Added.
  • web-platform-tests/webmessaging/without-ports/014-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/014.html: Added.
  • web-platform-tests/webmessaging/without-ports/015-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/015.html: Added.
  • web-platform-tests/webmessaging/without-ports/016-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/016.html: Added.
  • web-platform-tests/webmessaging/without-ports/017-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/017.html: Added.
  • web-platform-tests/webmessaging/without-ports/018-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/018.html: Added.
  • web-platform-tests/webmessaging/without-ports/019-1.html: Added.
  • web-platform-tests/webmessaging/without-ports/019-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/019.html: Added.
  • web-platform-tests/webmessaging/without-ports/020-1.html: Added.
  • web-platform-tests/webmessaging/without-ports/020.html: Added.
  • web-platform-tests/webmessaging/without-ports/021.html: Added.
  • web-platform-tests/webmessaging/without-ports/023-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/023.html: Added.
  • web-platform-tests/webmessaging/without-ports/024-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/024.html: Added.
  • web-platform-tests/webmessaging/without-ports/025-1.js: Added.

(test):

  • web-platform-tests/webmessaging/without-ports/025-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/025.html: Added.
  • web-platform-tests/webmessaging/without-ports/026-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/026.html: Added.
  • web-platform-tests/webmessaging/without-ports/027-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/027.html: Added.
  • web-platform-tests/webmessaging/without-ports/028-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/028.html: Added.
  • web-platform-tests/webmessaging/without-ports/029-expected.txt: Added.
  • web-platform-tests/webmessaging/without-ports/029.html: Added.
  • web-platform-tests/webmessaging/without-ports/w3c-import.log: Added.

LayoutTests:

Skip some webmessaging tests timing out.

5:30 AM Changeset in webkit [233196] by zandobersek@gmail.com
  • 4 edits in trunk

Crash in WebAnimation::runPendingPlayTask
https://bugs.webkit.org/show_bug.cgi?id=186189

Reviewed by Carlos Garcia Campos.

Source/WebCore:

Avoid crashes on nullopt std::optional dereference in the
runPendingPlayTask() and runPendingPauseTask() methods of the
WebAnimation class by defaulting to a Seconds(0) value.

In both cases the std::optional value is the current time retrieved from
the associated DocumentTimeline object. But there's no guarantee that
the timeline is active and the resulting time value is resolved (i.e.
not nullopt). Dereferencing the nullopt Seconds value doesn't cause a
problem on configurations still building as C++14 and the fallback
std::optional implementation provided by WTF -- no signal is raised, and
a 0 value is returned. Configurations building as C++17 on the other
hand use the stdlib-provided std::optional that does raise a signal on
invalid access, leading to crashes.

The default-to-Seconds(0) solution avoids crashes on configurations
that build with C++17 support enabled, and thus match configurations
that are still using WTF's std::optional. This still doesn't address the
underlying problem of retrieving current time from an inactive document
timeline and using it as ready time for the pending play/pause task
execution.

runPendingPlayTask() change addresses crashes in the following tests:

  • fast/animation/css-animation-resuming-when-visible.html
  • fast/animation/css-animation-resuming-when-visible-with-style-change.html
  • imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/animate-no-browsing-context.html
  • imported/w3c/web-platform-tests/web-animations/interfaces/Animatable/getAnimations.html

runPendingPauseTask() change addresses crashes in the following tests:

  • animations/multiple-animations-timing-function.html
  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::runPendingPlayTask):
(WebCore::WebAnimation::runPendingPauseTask):

LayoutTests:

  • platform/wpe/TestExpectations: Remove crashing expectations for fixed tests.
2:50 AM Changeset in webkit [233195] by Fujii Hironori
  • 2 edits in trunk/Source/WebKit

[Win] 'deref': is not a member of 'WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains::<lambda_9d761a6dc12d95db7fa2d6f3f5aa26fa>'
https://bugs.webkit.org/show_bug.cgi?id=187035

Unreviewed build fix.

MSVC can't compile the code using this in a generalized lambda
capture in another lambda.

In this case, there is no need to copy protectedThis for the
inner lambda. Move protectedThis of the outer lambda to the
inner as well as completionHandler.

  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioning):
Moved protectedThis from the outer lambda to the inner.
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains):
Ditto.

2:44 AM Changeset in webkit [233194] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

[Web Animations] Show the feature as "Supported in Preview"
https://bugs.webkit.org/show_bug.cgi?id=187037

Patch by Antoine Quint <Antoine Quint> on 2018-06-26
Reviewed by Dean Jackson.

Web Animations are enabled by default in STP.

  • features.json:
2:12 AM Changeset in webkit [233193] by magomez@igalia.com
  • 6 edits in trunk/Source

[GTK] Many webpages can crash the browser in WebCore::CoordinatedGraphicsLayer::transformedVisibleRect
https://bugs.webkit.org/show_bug.cgi?id=179304

Reviewed by Michael Catanzaro.

Source/WebCore:

When adding new CoordinatedGraphicsLayers to the tree, check that they have the appropriate
CompositingCoordinator. If that's not the case, set the appropriate one to the layer and its
children and set the state of those layers so they are rendered properly.

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::addChild):
(WebCore::CoordinatedGraphicsLayer::addChildAtIndex):
(WebCore::CoordinatedGraphicsLayer::addChildAbove):
(WebCore::CoordinatedGraphicsLayer::addChildBelow):
(WebCore::CoordinatedGraphicsLayer::replaceChild):
(WebCore::CoordinatedGraphicsLayer::setCoordinatorIncludingSubLayersIfNeeded):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:

Source/WebKit:

Add a way to attach to the CompositingCoordinator layers that were not created by it.

  • WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.cpp:

(WebKit::CompositingCoordinator::attachLayer):

  • WebProcess/WebPage/CoordinatedGraphics/CompositingCoordinator.h:
12:38 AM Changeset in webkit [233192] by sbarati@apple.com
  • 5 edits in trunk/Source/bmalloc

Wasm: Any function argument of type Void should be a validation error
https://bugs.webkit.org/show_bug.cgi?id=186794
<rdar://problem/41140257>

Reviewed by Keith Miller.

We have evidence showing that processes with small heaps using the
JS API are more space efficient when using system malloc. Our main
hypothesis as to why this is, is that when dealing with small heaps,
one malloc can be more efficient at optimizing memory usage than
two mallocs.

  • bmalloc/BPlatform.h:
  • bmalloc/Environment.cpp:

(bmalloc::isNanoMallocEnabled):
(bmalloc::Environment::computeIsDebugHeapEnabled):

  • bmalloc/ProcessCheck.h:

(bmalloc::shouldProcessUnconditionallyUseBmalloc):

  • bmalloc/ProcessCheck.mm:

(bmalloc::shouldProcessUnconditionallyUseBmalloc):

Jun 25, 2018:

10:47 PM Changeset in webkit [233191] by youenn@apple.com
  • 6 edits
    25 adds in trunk/LayoutTests

Import WPT fetch destination tests
https://bugs.webkit.org/show_bug.cgi?id=186984

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/fetch/api/request/destination/fetch-destination-iframe.https-expected.txt: Added.
  • web-platform-tests/fetch/api/request/destination/fetch-destination-iframe.https.html: Added.
  • web-platform-tests/fetch/api/request/destination/fetch-destination-no-load-event.https.html: Added.
  • web-platform-tests/fetch/api/request/destination/fetch-destination-worker.https-expected.txt: Added.
  • web-platform-tests/fetch/api/request/destination/fetch-destination-worker.https.html: Added.
  • web-platform-tests/fetch/api/request/destination/fetch-destination.https.html: Added.
  • web-platform-tests/fetch/api/request/destination/resources/dummy: Added.
  • web-platform-tests/fetch/api/request/destination/resources/dummy.es: Added.
  • web-platform-tests/fetch/api/request/destination/resources/dummy.es.headers: Added.
  • web-platform-tests/fetch/api/request/destination/resources/dummy.html: Added.
  • web-platform-tests/fetch/api/request/destination/resources/dummy.png: Added.
  • web-platform-tests/fetch/api/request/destination/resources/dummy.ttf: Added.
  • web-platform-tests/fetch/api/request/destination/resources/dummy_audio.mp3: Added.
  • web-platform-tests/fetch/api/request/destination/resources/dummy_audio.oga: Added.
  • web-platform-tests/fetch/api/request/destination/resources/dummy_video.mp4: Added.
  • web-platform-tests/fetch/api/request/destination/resources/dummy_video.ogv: Added.
  • web-platform-tests/fetch/api/request/destination/resources/empty.https.html: Added.
  • web-platform-tests/fetch/api/request/destination/resources/fetch-destination-worker-iframe.js: Added.

(event.request.url.includes.):
(event.request.url.includes):

  • web-platform-tests/fetch/api/request/destination/resources/fetch-destination-worker-no-load-event.js: Added.

(event.request.url.includes):

  • web-platform-tests/fetch/api/request/destination/resources/fetch-destination-worker.js: Added.

(event.request.url.includes):

  • web-platform-tests/fetch/api/request/destination/resources/importer.js: Added.
  • web-platform-tests/fetch/api/request/destination/resources/w3c-import.log: Added.
  • web-platform-tests/fetch/api/request/destination/w3c-import.log: Added.

LayoutTests:

Skipping tests for WK1 since they use service worker.

  • TestExpectations: Skipping timing out tests.
  • platform/ios-wk1/TestExpectations:
  • platform/mac-wk1/TestExpectations:
  • platform/win/TestExpectations:
9:58 PM Changeset in webkit [233190] by dbates@webkit.org
  • 2 edits in trunk/Tools

Log a message when fetching attachment data from the status server
https://bugs.webkit.org/show_bug.cgi?id=187032

Reviewed by Zalan Bujtas.

Currently we silently fetch from the status server an attachment when fetching
the attachment from Bugzilla fails due to an access denied error. Instead we
should emit a message when fetching data from the status server to indicate
that webkit-patch/EWS is still processing the command/trying to obtain the
patch.

  • Scripts/webkitpy/common/net/statusserver.py:

(StatusServer._fetch_attachment_page):

7:05 PM Changeset in webkit [233189] by Keith Rollin
  • 18 edits in trunk/Source/WebCore

Adjust WEBCORE_EXPORT annotations for LTO
https://bugs.webkit.org/show_bug.cgi?id=186944
<rdar://problem/41384880>

Reviewed by David Kilzer.

Adjust a number of places that result in WebKit's
'check-for-weak-vtables-and-externals' script reporting weak external
symbols:

ERROR: WebCore has a weak external symbol in it (/Volumes/Data/dev/webkit/OpenSource/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore)
ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library.
ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file.
...

These cases are caused by inline methods being marked with WTF_EXPORT
(or related macro) or with an inline function being in a class marked
as such, and when enabling LTO builds.

For the most part, address these by removing the WEBCORE_EXPORT
annotation from inline methods. In some cases, move the implementation
out-of-line because it's the class that has the WEBCORE_EXPORT on it
and removing the annotation from the class would be too disruptive.
Finally, in other cases, move the implementation out-of-line because
check-for-weak-vtables-and-externals still complains when keeping the
implementation inline and removing the annotation; this seems to
typically (but not always) happen with destructors.

No new tests. There is no changed functionality. Only the annotation
and treatment of inline methods are altered.

  • animation/AnimationTimeline.h:

(WebCore::AnimationTimeline::pause):

  • page/CacheStorageProvider.h:

(): Deleted.

  • page/scrolling/ScrollingTree.h:

(WebCore::ScrollingTree::reportSynchronousScrollingReasonsChanged):
(WebCore::ScrollingTree::reportExposedUnfilledArea):

  • platform/audio/PlatformMediaSessionManager.h:

(WebCore::PlatformMediaSessionManager::hasActiveNowPlayingSession const):
(WebCore::PlatformMediaSessionManager::lastUpdatedNowPlayingTitle const):
(WebCore::PlatformMediaSessionManager::lastUpdatedNowPlayingDuration const):
(WebCore::PlatformMediaSessionManager::lastUpdatedNowPlayingElapsedTime const):
(WebCore::PlatformMediaSessionManager::lastUpdatedNowPlayingInfoUniqueIdentifier const):
(WebCore::PlatformMediaSessionManager::registeredAsNowPlayingApplication const):

  • platform/audio/mac/CARingBuffer.cpp:

(WebCore::CARingBuffer::~CARingBuffer):

  • platform/audio/mac/CARingBuffer.h:

(WebCore::CARingBuffer::~CARingBuffer): Deleted.

  • platform/cocoa/VideoFullscreenModelVideoElement.h:
  • platform/gamepad/GamepadProvider.h:
  • platform/graphics/GraphicsLayer.h:

(WebCore::GraphicsLayer::displayListAsText const):
(WebCore::GraphicsLayer::setIsTrackingDisplayListReplay):
(WebCore::GraphicsLayer::isTrackingDisplayListReplay const):
(WebCore::GraphicsLayer::replayDisplayListAsText const):

  • platform/mac/PlaybackSessionInterfaceMac.h:
  • platform/mediastream/RealtimeMediaSourceCenter.h:

(WebCore::RealtimeMediaSourceCenter::setAudioFactory):
(WebCore::RealtimeMediaSourceCenter::unsetAudioFactory):

  • platform/mediastream/libwebrtc/LibWebRTCProvider.cpp:

(WebCore::LibWebRTCProvider::setActive):
(WebCore::LibWebRTCProvider::createDecoderFactory):
(WebCore::LibWebRTCProvider::createEncoderFactory):
(WebCore::LibWebRTCProvider::disableEnumeratingAllNetworkInterfaces):
(WebCore::LibWebRTCProvider::enableEnumeratingAllNetworkInterfaces):

  • platform/mediastream/libwebrtc/LibWebRTCProvider.h:
  • platform/network/ResourceHandleClient.h:

(WebCore::ResourceHandleClient::willCacheResponseAsync):

  • testing/MockGamepadProvider.h:
  • workers/service/server/SWServer.h:

(WebCore::SWServer::Connection::~Connection):

6:22 PM Changeset in webkit [233188] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC] Adjust static position for out-of-flow positioned boxes.
https://bugs.webkit.org/show_bug.cgi?id=187000

Reviewed by Antti Koivisto.

The static position of an out-of-flow positioned box is the the position where box would go
if it was in-flow positioned. This position needs to the resolved in the containing block's coordinate system.

  • layout/blockformatting/BlockFormattingContext.h:
  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::staticPositionForOutOfFlowPositioned):
(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):

5:43 PM Changeset in webkit [233187] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: Box Model section should have dark background
https://bugs.webkit.org/show_bug.cgi?id=186976

Reviewed by Brian Burg.

Replace all instances of black text on white background with the default text and background colors.

  • UserInterface/Views/BoxModelDetailsSectionRow.css:

(@media (prefers-dark-interface)):
(.details-section .row.box-model):
(.details-section .row.box-model .label):
(.details-section .row.box-model :matches(.position, .margin, .border, .padding, .content)):
(.details-section .row.box-model:not(.hovered) :matches(.margin, .border, .padding, .content),):
(.details-section .row.box-model .margin):
(.details-section .row.box-model .border):

5:40 PM Changeset in webkit [233186] by david_fenton@apple.com
  • 5 edits
    3 copies
    1 move
    2 adds
    1 delete in trunk/Source/WTF

Unreviewed, rolling out r233120.

caused regression in ios API tests

Reverted changeset:

"[Cocoa] reduce unnecessary use of .mm source files in WTF,
spruce up some implementation details"
https://bugs.webkit.org/show_bug.cgi?id=186924
https://trac.webkit.org/changeset/233120

5:38 PM Changeset in webkit [233185] by david_fenton@apple.com
  • 2 edits in trunk/LayoutTests

LayoutTest imported/w3c/web-platform-tests/WebCryptoAPI/generateKey/successes_RSASSA-PKCS1-v1_5.https.any.worker.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=187025

Unreviewed test gardening, update Test Expectations to [Pass Failure Slow]

4:56 PM Changeset in webkit [233184] by sbarati@apple.com
  • 13 edits in trunk

JSImmutableButterfly can't be allocated from a subspace with HeapCell::Kind::Auxiliary
https://bugs.webkit.org/show_bug.cgi?id=186878
<rdar://problem/40568659>

Reviewed by Mark Lam.

Source/JavaScriptCore:

This patch fixes a bug in our JSImmutableButterfly implementation uncovered by
our stress GC bots. Before this patch, JSImmutableButterfly was allocated
with HeapCell::Kind::Auxiliary. This is wrong. Things that are JSCells must be
allocated from HeapCell::Kind::JSCell. The way this broke on the stress GC
bots is that our conservative marking won't do cell marking for things that
are Auxiliary. This means that if the stack is the only thing pointing to a
JSImmutableButterfly when a GC took place, that JSImmutableButterfly would
not be visited. This patch fixes this bug. This patch also extends our conservative
marking to understand that there may be interior pointers to things that are HeapCell::Kind::JSCell.

  • bytecompiler/NodesCodegen.cpp:

(JSC::ArrayNode::emitBytecode):

  • heap/HeapUtil.h:

(JSC::HeapUtil::findGCObjectPointersForMarking):

  • runtime/JSImmutableButterfly.h:

(JSC::JSImmutableButterfly::subspaceFor):

LayoutTests:

Make these test not susceptible to conservative scan leaks by ensuring at least
one object gets collected when we allocate many of them. Before, these were just
testing that a fixed number of objects were collected.

  • editing/selection/navigation-clears-editor-state-expected.txt:
  • editing/selection/navigation-clears-editor-state.html:
  • fast/dom/reference-cycle-leaks.html:
  • fast/misc/resources/test-observegc.js:
  • fast/misc/test-observegc-expected.txt:
  • platform/mac-wk2/plugins/refcount-leaks-expected.txt:
  • plugins/refcount-leaks-expected.txt:
  • plugins/refcount-leaks.html:
4:56 PM Changeset in webkit [233183] by beidson@apple.com
  • 2 edits in trunk/Source/WebCore

Remove RELEASE_ASSERT added in r230875.
<rdar://problem/40860061> and https://bugs.webkit.org/show_bug.cgi?id=187022

Reviewed by Brent Fulgham.

There's actually more than one way for a network session to be destroyed, and that can happen
asynchronously and unpredictably.

And the request to start up a WebSocket and do its handshake is also asynchronous and unpredictable

It's an expected race.

If the NetworkStorageSession cannot be found then the WebSocket handshake should just fail.

  • platform/network/SocketStreamHandleImpl.cpp:

(WebCore::cookieDataForHandshake): If the NetworkStorageSession cannot be found, return std::nullopt.
(WebCore::SocketStreamHandleImpl::platformSendHandshake): If the cookieData is null, fail the handshake.

4:54 PM Changeset in webkit [233182] by wenson_hsieh@apple.com
  • 4 edits in trunk/Source/WebCore

[iPad apps on macOS] Web process crashes when attempting to play embedded YouTube video in News
https://bugs.webkit.org/show_bug.cgi?id=187011
<rdar://problem/40906808>

Reviewed by Tim Horton.

Disable remote media commands when running iOS WebKit on macOS. The iOS flavor of RemoteCommandListener
currently throws an exception when attempting to soft-link the MediaPlayer framework, which prevents video from
being played altogether. For a followup tracking touch bar integration in iOS WebKit on macOS, see:
<rdar://problem/39164732>.

Manually tested by playing a YouTube video in News.

  • platform/RemoteCommandListener.cpp:
  • platform/ios/RemoteCommandListenerIOS.h:
  • platform/ios/RemoteCommandListenerIOS.mm:
4:40 PM Changeset in webkit [233181] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

WKThumbnailView fallback background is blindingly bright in Dark Mode
https://bugs.webkit.org/show_bug.cgi?id=187017
<rdar://problem/41036209>

Reviewed by Simon Fraser.

  • UIProcess/API/Cocoa/_WKThumbnailView.mm:

(-[_WKThumbnailView initWithFrame:]):
(-[_WKThumbnailView wantsUpdateLayer]):
(-[_WKThumbnailView updateLayer]):
Use a semantic color for the WKThumbnailView background color
instead of flat white.

4:37 PM Changeset in webkit [233180] by wilander@apple.com
  • 14 edits in trunk

Resource Load Statistics: Make WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains() wait for the network process before calling its callback
https://bugs.webkit.org/show_bug.cgi?id=186903
<rdar://problem/41350182>

Reviewed by Chris Dumez.

Source/WebKit:

This patch stores the callback sent to
WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains(),
sets up a context ID, and sends that ID to the network process when
asking it to update cookie partitioning and blocking. The network
process then tells the UI process when it's done, at which point the
callback is called.

This change is meant to address layout test flakiness.

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::updatePrevalentDomainsToPartitionOrBlockCookies):

  • NetworkProcess/NetworkProcess.h:
  • NetworkProcess/NetworkProcess.messages.in:
  • UIProcess/Network/NetworkProcessProxy.cpp:

(WebKit::NetworkProcessProxy::updatePrevalentDomainsToPartitionOrBlockCookies):
(WebKit::NetworkProcessProxy::didUpdatePartitionOrBlockCookies):

  • UIProcess/Network/NetworkProcessProxy.h:
  • UIProcess/Network/NetworkProcessProxy.messages.in:
  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioning):
(WebKit::WebResourceLoadStatisticsStore::updateCookiePartitioningForDomains):

  • UIProcess/WebResourceLoadStatisticsStore.h:
  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::updatePrevalentDomainsToPartitionOrBlockCookies):
(WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback):

  • UIProcess/WebsiteData/WebsiteDataStore.h:

LayoutTests:

  • http/tests/storageAccess/grant-storage-access-under-opener-expected.txt:
  • http/tests/storageAccess/grant-storage-access-under-opener.html:

Moved the code block to the page's body instead of its head.
Added an initial console log statement. The reason for these
changes is that we're seeing flaky timeouts with no output.

4:07 PM Changeset in webkit [233179] by Brent Fulgham
  • 2 edits in trunk/Source/WebKit

Allow access to APTDevice in iOS WebContent process
https://bugs.webkit.org/show_bug.cgi?id=187021
<rdar://problem/41339769>

Reviewed by Youenn Fablet.

  • Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
3:34 PM Changeset in webkit [233178] by Keith Rollin
  • 8 edits in trunk/Source

Unreviewed, rolling out r233087.

Causes 5% Mac PLT regression.

Reverted changeset:

"Recalc styles every time defaultAppearance changes."
https://bugs.webkit.org/show_bug.cgi?id=186866
https://trac.webkit.org/changeset/233087

3:29 PM Changeset in webkit [233177] by youenn@apple.com
  • 2 edits
    1 add in trunk/Source/WebKit

Add a sandbox profile to Hangout plug-in
https://bugs.webkit.org/show_bug.cgi?id=187005
<rdar://problem/41428391>

Reviewed by Brent Fulgham.

Add a sandbox profile so that this plug-in can be run when UIProcess is sandboxed.

  • Resources/PlugInSandboxProfiles/com.google.googletalkbrowserplugin.sb: Added.
  • WebKit.xcodeproj/project.pbxproj:
2:29 PM Changeset in webkit [233176] by Brent Fulgham
  • 3 edits in trunk/Source/WebCore

REGRESSION(r229722): WebKitLegacy clients can crash when loading alternate page
https://bugs.webkit.org/show_bug.cgi?id=187008

Reviewed by Chris Dumez.

The new call to 'clearProvisionalLoadForPolicyCheck' added in r229722 broke loading
behavior in WebKitLegacy.

  1. We can now enter 'cancelPolicyCheckIfNeeded' without a Frame loader, in what appears to be a recursive call during the load cancellation (the 'm_waitingForContentPolicy' and 'm_waitingForNavigationPolicy' have already been nulled). It seems like we should return early here, or perhaps just move the RELEASE_ASSERT inside the case where we have an active policy check happening.
  1. We also enter FrameLoader::checkContentPolicy without an active document loader. We should recognize this case and handle it, rather than trying to dereference a nullptr document loader.
  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::cancelPolicyCheckIfNeeded): Move the RELEASE_ASSERT inside the
conditional where the frameLoader is actually used.

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkContentPolicy): Recognize that the activeDocumentLoader may
be nullptr at this point, and take appropriate action (rather than crashing).

2:28 PM Changeset in webkit [233175] by aakash_jain@apple.com
  • 4 edits in trunk/Tools

[ews-build] Add support for Bindings-tests-EWS
https://bugs.webkit.org/show_bug.cgi?id=187014

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-build/factories.py:

(BindingsFactory): Added RunBindingsTests build step to BindingsFactory.

  • BuildSlaveSupport/ews-build/steps.py:

(RunBindingsTests): Added build-step for running Bindings tests.

  • BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
2:27 PM Changeset in webkit [233174] by Chris Dumez
  • 2 edits in trunk/LayoutTests

performance-api/performance-observer-no-document-leak.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=186938
<rdar://problem/41379336>

Unreviewed, skip test again as it is apparently still flaky.

2:15 PM Changeset in webkit [233173] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

MatchedPropertiesCacheItem wastes 388KB of vector capacity on nytimes.com
https://bugs.webkit.org/show_bug.cgi?id=186990

Reviewed by Antti Koivisto.

MatchedPropertiesCacheItem.matchedProperties was appended to, so it allocated capacity
in 16-size chunks. Instead, assign to it so it only allocates as much capacity as is needed.
Copy-constructing is more wasteful, since it copies the 64-chunk size from the right-hand side.

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::addToMatchedPropertiesCache):

  • css/StyleResolver.h:

(WebCore::StyleResolver::MatchedPropertiesCacheItem::MatchedPropertiesCacheItem):

2:14 PM Changeset in webkit [233172] by youenn@apple.com
  • 3 edits
    3 adds in trunk

NetworkLoadChecker should not check CORS for 304 responses triggered by WebProcess revalidation
https://bugs.webkit.org/show_bug.cgi?id=186939
<rdar://problem/40941725>

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

  • web-platform-tests/cors/resources/cache-304.py: Added.
  • web-platform-tests/cors/script-304-expected.txt: Added.
  • web-platform-tests/cors/script-304.html: Added.

Source/WebKit:

  • NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::validateResponse):

2:04 PM Changeset in webkit [233171] by Chris Dumez
  • 2 edits in trunk/Source/WebCore

Null dereference crash un ApplicationCacheGroup::startLoadingEntry()
https://bugs.webkit.org/show_bug.cgi?id=187012
<rdar://problem/40793716>

Reviewed by Youenn Fablet.

m_entryLoader can be null because ApplicationCacheResourceLoader::create() return null when
CachedResourceLoader::requestRawResource() fails synchronously. In such case, the completion
handler gets called with a ApplicationCacheResourceLoader::Error::CannotRequestResource error.

To address the issue, we capture the request's URL in the lambda and use it instead of trying
to get the URL from the loader's resource.

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::startLoadingEntry):

1:31 PM Changeset in webkit [233170] by Ross Kirsling
  • 2 edits in trunk/Source/WebCore

REGRESSION (r233140): Windows build failure due to incomplete FrameView and RenderBox types
https://bugs.webkit.org/show_bug.cgi?id=186997

  • animation/KeyframeEffectReadOnly.cpp:
1:30 PM Changeset in webkit [233169] by Chris Dumez
  • 3 edits in trunk/LayoutTests

performance-api/performance-observer-no-document-leak.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=186938
<rdar://problem/41379336>

Unreviewed, move the call to gc() inside the setInterval() so we keep
trying to gc() until the frame / document are destroyed (instead of
only doing a single garbage collection).

1:16 PM Changeset in webkit [233168] by Keith Rollin
  • 2 edits in trunk/Source/WebKit

Adjust UNEXPORTED_SYMBOL_LDFLAGS for LTO
https://bugs.webkit.org/show_bug.cgi?id=186949
<rdar://problem/41386438>

Reviewed by David Kilzer.

When building with LTO, WebKit's
'check-for-weak-vtables-and-externals' script reports weak external
symbols:

ERROR: WebKit has a weak external symbol in it (.../OpenSource/WebKitBuild/Release/WebKit.framework/Versions/A/WebKit)
ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library.
ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file.
ERROR: symbol ZTCNSt3118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE0_NS_13basic_istreamIcS2_EE
ERROR: symbol ZTCNSt3118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE0_NS_14basic_iostreamIcS2_EE
ERROR: symbol ZTCNSt3118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE16_NS_13basic_ostreamIcS2_EE
ERROR: symbol ZTTNSt3118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE
ERROR: symbol ZTVNSt3115basic_stringbufIcNS_11char_traitsIcEENS_9allocatorIcEEEE
ERROR: symbol ZTVNSt3118basic_stringstreamIcNS_11char_traitsIcEENS_9allocatorIcEEEE
Command /bin/sh failed with exit code 1

Address these by adding those symbols to UNEXPORTED_SYMBOL_LDFLAGS in
WebKit.xcconfig.

  • Configurations/WebKit.xcconfig:
1:12 PM Changeset in webkit [233167] by mark.lam@apple.com
  • 3 edits
    1 add in trunk

constructArray() should set m_numValuesInVector to the specified length.
https://bugs.webkit.org/show_bug.cgi?id=187010
<rdar://problem/41392167>

Reviewed by Filip Pizlo.

JSTests:

  • stress/regress-187010.js: Added.

Source/JavaScriptCore:

Its client will fill in the storage vector with some values using initializeIndex()
and expects m_numValuesInVector to be set to the length i.e. the number of values
to be initialized.

  • runtime/JSArray.cpp:

(JSC::constructArray):

1:00 PM Changeset in webkit [233166] by aakash_jain@apple.com
  • 3 edits
    3 adds in trunk/Tools

[ews-build] Add support for Style-EWS
https://bugs.webkit.org/show_bug.cgi?id=186955

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-build/factories.py:

(Factory): Base class for all the factory.

  • BuildSlaveSupport/ews-build/loadConfig.py: Initialize factory with required parameters.
  • BuildSlaveSupport/ews-build/runUnittests.py: Added, script to run all the unit tests.
  • BuildSlaveSupport/ews-build/steps.py: Added.
  • BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
12:54 PM Changeset in webkit [233165] by Chris Dumez
  • 6 edits in trunk/Source/WebKit

Make sure API::IconLoadingClient::getLoadDecisionForIcon()'s completion handler gets called
https://bugs.webkit.org/show_bug.cgi?id=187007
<rdar://problem/41293989>

Reviewed by Brady Eidson.

Make sure API::IconLoadingClient::getLoadDecisionForIcon()'s completion handler gets called by
switching its type to WTF::CompletionHandler instead of WTF::Function. This also has the benefit
of destroying our captured objects when the completion handler gets called by the client on the
main thread instead of whatever thread the ObjC block gets released on.

  • UIProcess/API/APIIconLoadingClient.h:

(API::IconLoadingClient::getLoadDecisionForIcon):

  • UIProcess/API/glib/WebKitIconLoadingClient.cpp:
  • UIProcess/API/mac/WKView.mm:

(-[WKView maybeInstallIconLoadingClient]):

  • UIProcess/Cocoa/IconLoadingDelegate.h:
  • UIProcess/Cocoa/IconLoadingDelegate.mm:

(WebKit::IconLoadingDelegate::IconLoadingClient::getLoadDecisionForIcon):

12:24 PM Changeset in webkit [233164] by graouts@webkit.org
  • 7 edits
    1 copy
    1 add in trunk

REGRESSION: hardware-accelerated animation fails on inline element
https://bugs.webkit.org/show_bug.cgi?id=186981
<rdar://problem/41418697>

Reviewed by Dean Jackson.

Source/WebCore:

Ensure we only queue accelerated actions when we have a renderer so we don't attempt
to start an accelerated animation too soon.

Test: webanimations/opacity-animation-yields-compositing-span.html

  • animation/KeyframeEffectReadOnly.cpp:

(WebCore::KeyframeEffectReadOnly::updateAcceleratedAnimationState):

LayoutTests:

  • platform/mac/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
  • platform/mac-sierra/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt:
  • webanimations/opacity-animation-yields-compositing-expected.txt:
  • webanimations/opacity-animation-yields-compositing-span-expected.txt:
  • webanimations/opacity-animation-yields-compositing-span.html: Added.
  • webanimations/opacity-animation-yields-compositing.html:
12:23 PM Changeset in webkit [233163] by ddkilzer@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION (r233140): v2: Windows build failure due to incomplete DocumentAnimationScheduler type
<https://webkit.org/b/186997>

  • dom/Document.cpp:

(WebCore::Document::prepareForDestruction):
(WebCore::Document::windowScreenDidChange):

  • dom/Document.h:
  • DocumentAnimationScheduler is behind the USE(REQUEST_ANIMATION_FRAME_DISPLAY_MONITOR) macro, which is disabled on Windows.
  • This also reverts my fix in r233144 since it didn't work.
12:19 PM Changeset in webkit [233162] by youenn@apple.com
  • 29 edits
    1 copy
    4 adds in trunk

Add API to control mock media devices
https://bugs.webkit.org/show_bug.cgi?id=186958

Reviewed by Eric Carlson.

Source/WebCore:

Refactor code to introduce a MockDevice structure that can be used in multiple processes.
Update mock sources and center to use MockDevice.
Add API to update mock media devices.

Make MediaDevices an ActiveDOMObject so that it does not get collected when ondevicechange is set.

Test: fast/mediastream/device-change-event-2.html

  • Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::MediaDevices):
(WebCore::MediaDevices::stop):
(WebCore::MediaDevices::scheduledEventTimerFired):
(WebCore::MediaDevices::hasPendingActivity const):
(WebCore::MediaDevices::activeDOMObjectName const):
(WebCore::MediaDevices::canSuspendForDocumentSuspension const):

  • Modules/mediastream/MediaDevices.h:
  • Modules/mediastream/MediaDevices.idl:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/mediastream/RealtimeMediaSourceCenter.h:
  • platform/mock/MockMediaDevice.h: Added.

(WebCore::MockMicrophoneProperties::encode const):
(WebCore::MockMicrophoneProperties::decode):
(WebCore::MockCameraProperties::encode const):
(WebCore::MockCameraProperties::decode):
(WebCore::MockDisplayProperties::encode const):
(WebCore::MockDisplayProperties::decode):
(WebCore::MockMediaDevice::isMicrophone const):
(WebCore::MockMediaDevice::isCamera const):
(WebCore::MockMediaDevice::isDisplay const):
(WebCore::MockMediaDevice::type const):
(WebCore::MockMediaDevice::encode const):
(WebCore::MockMediaDevice::decodeMockMediaDevice):
(WebCore::MockMediaDevice::decode):

  • platform/mock/MockRealtimeAudioSource.cpp:

(WebCore::MockRealtimeAudioSource::startProducingData):

  • platform/mock/MockRealtimeMediaSource.cpp:

(WebCore::defaultDevices):
(WebCore::devices):
(WebCore::deviceMap):
(WebCore::deviceListForDevice):
(WebCore::MockRealtimeMediaSource::createCaptureDevice):
(WebCore::MockRealtimeMediaSource::resetDevices):
(WebCore::MockRealtimeMediaSource::setDevices):
(WebCore::MockRealtimeMediaSource::addDevice):
(WebCore::MockRealtimeMediaSource::removeDevice):
(WebCore::MockRealtimeMediaSource::captureDeviceWithPersistentID):
(WebCore::MockRealtimeMediaSource::audioDevices):
(WebCore::MockRealtimeMediaSource::videoDevices):
(WebCore::MockRealtimeMediaSource::displayDevices):
(WebCore::MockRealtimeMediaSource::MockRealtimeMediaSource):
(WebCore::MockRealtimeMediaSource::initializeCapabilities):
(WebCore::MockRealtimeMediaSource::initializeSettings):
(WebCore::MockRealtimeMediaSource::settings const):
(WebCore::MockRealtimeMediaSource::supportedConstraints):

  • platform/mock/MockRealtimeMediaSource.h:

(WebCore::MockRealtimeMediaSource::device const):

  • platform/mock/MockRealtimeMediaSourceCenter.cpp:

(WebCore::MockRealtimeMediaSourceCenter::singleton):
(WebCore::MockRealtimeMediaSourceCenter::setMockRealtimeMediaSourceCenterEnabled):
(WebCore::MockRealtimeMediaSourceCenter::setDevices):
(WebCore::MockRealtimeMediaSourceCenter::addDevice):
(WebCore::MockRealtimeMediaSourceCenter::removeDevice):

  • platform/mock/MockRealtimeMediaSourceCenter.h:
  • platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::MockRealtimeVideoSource):
(WebCore::MockRealtimeVideoSource::initializeCapabilities):
(WebCore::MockRealtimeVideoSource::drawText):
(WebCore::MockRealtimeVideoSource::generateFrame):

  • platform/mock/MockRealtimeVideoSource.h:

(WebCore::MockRealtimeVideoSource::mockCamera const):
(WebCore::MockRealtimeVideoSource::mockScreen const):

Source/WebKit:

Add API to clear, set, remove and reset mock media devices.
The mock media center of UIProcess and all WebProcesses are updated.

  • CMakeLists.txt:
  • UIProcess/API/C/WKMockMediaDevice.cpp: Added.

(typeFromString):
(WKAddMockMediaDevice):
(WKClearMockMediaDevices):
(WKRemoveMockMediaDevice):
(WKResetMockMediaDevices):

  • UIProcess/API/C/WKMockMediaDevice.h: Added.
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::addMockMediaDevice):
(WebKit::WebProcessPool::clearMockMediaDevices):
(WebKit::WebProcessPool::removeMockMediaDevice):
(WebKit::WebProcessPool::resetMockMediaDevices):

  • UIProcess/WebProcessPool.h:
  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::addMockMediaDevice):
(WebKit::WebProcess::clearMockMediaDevices):
(WebKit::WebProcess::removeMockMediaDevice):
(WebKit::WebProcess::resetMockMediaDevices):

  • WebProcess/WebProcess.h:
  • WebProcess/WebProcess.messages.in:

Tools:

Add test runner API to clear/add/remove/reset mock media devices.

  • WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
  • WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::addMockMediaDevice):
(WTR::TestRunner::addMockCameraDevice):
(WTR::TestRunner::addMockMicrophoneDevice):
(WTR::TestRunner::addMockScreenDevice):
(WTR::TestRunner::clearMockMediaDevices):
(WTR::TestRunner::removeMockMediaDevice):
(WTR::TestRunner::resetMockMediaDevices):

  • WebKitTestRunner/InjectedBundle/TestRunner.h:
  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::addMockMediaDevice):
(WTR::TestController::clearMockMediaDevices):
(WTR::TestController::removeMockMediaDevice):
(WTR::TestController::resetMockMediaDevices):

  • WebKitTestRunner/TestController.h:
  • WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

  • fast/mediastream/device-change-event-2-expected.txt: Added.
  • fast/mediastream/device-change-event-2.html: Added.
11:53 AM Changeset in webkit [233161] by mark.lam@apple.com
  • 3 edits
    1 add in trunk

Add missing exception check in RegExpObjectInlines.h's collectMatches.
https://bugs.webkit.org/show_bug.cgi?id=187006
<rdar://problem/41418412>

Reviewed by Keith Miller.

JSTests:

  • stress/regress-187006.js: Added.

Source/JavaScriptCore:

  • runtime/RegExpObjectInlines.h:

(JSC::collectMatches):

11:52 AM Changeset in webkit [233160] by aakash_jain@apple.com
  • 3 edits in trunk/Tools

[ews-build] Add support for try Buildbot try schedulers
https://bugs.webkit.org/show_bug.cgi?id=186948

Reviewed by Lucas Forschler.

  • BuildSlaveSupport/ews-build/config.json: Use Try_Userpass scheduler.
  • BuildSlaveSupport/ews-build/loadConfig.py: Updated to use try scheduler.
11:43 AM Changeset in webkit [233159] by wenson_hsieh@apple.com
  • 2 edits in trunk/Source/WebKit

[iPad apps on macOS] Click events are broken in WKWebView
https://bugs.webkit.org/show_bug.cgi?id=186964
<rdar://problem/41369145>

Reviewed by Tim Horton.

Tapping in WKWebView currently does not dispatch click events to the page. This is because the long press loupe
gesture (in the text interaction assistant) has a delay of 0 when running iOS apps on macOS, but on iOS, it's
0.5. The zero delay on macOS means that the loupe gesture will be recognized before the synthetic click gesture;
this, in turn, causes the synthetic click gesture to be excluded by the loupe gesture. To address this, we
simply allow the click and loupe gesture to recognize simultaneously.

Additionally, a new hover gesture was added recently to handle macOS cursor types when hovering over selectable
text. This patch also allows other gestures to recognize alongside hover gestures, which matches macOS behavior.

We don't have the capacity to write automated tests for this yet; I manually tested text selection, editing in
some text form controls, as well as clicking on links, buttons, and other elements with click event handlers.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView gestureRecognizer:shouldRecognizeSimultaneouslyWithGestureRecognizer:]):

11:30 AM Changeset in webkit [233158] by commit-queue@webkit.org
  • 6 edits in trunk/Source/JavaScriptCore

Add API for configuring the number of threads used by DFG and FTL
https://bugs.webkit.org/show_bug.cgi?id=186859
<rdar://problem/41093519>

Patch by Tadeu Zagallo <Tadeu Zagallo> on 2018-06-25
Reviewed by Filip Pizlo.

Add new private APIs for limiting the number of threads to be used by
the DFG and FTL compilers. It was already possible to configure the
limit through JSC Options, but now it can be changed at runtime, even
in the case when the VM is already running.

Add a test for both cases: when trying to configure the limit before
and after the Worklist has been created, but in order to simulate the
first scenario, we must guarantee that the test runs at the very
beginning, so I also added a check for that.

  • API/JSVirtualMachine.mm:

(+[JSVirtualMachine setNumberOfDFGCompilerThreads:]):
(+[JSVirtualMachine setNumberOfFTLCompilerThreads:]):

  • API/JSVirtualMachinePrivate.h:
  • API/tests/testapi.mm:

(runJITThreadLimitTests):
(testObjectiveCAPIMain):

  • dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::finishCreation):
(JSC::DFG::Worklist::createNewThread):
(JSC::DFG::Worklist::setNumberOfThreads):

  • dfg/DFGWorklist.h:
10:58 AM Changeset in webkit [233157] by aboya@igalia.com
  • 3 edits in trunk/Source/WTF

Fix ASAN_ENABLED in GCC
https://bugs.webkit.org/show_bug.cgi?id=186957

Reviewed by Michael Catanzaro.

ASAN_ENABLED used to rely on Clang-specific features for detection.
This patch enables ASAN_ENABLED to work on GCC too.

It also fixes compilation errors and warnings that were triggered when
compiling code guarded by ASAN_ENABLED in gcc.

  • wtf/Compiler.h:
  • wtf/Vector.h:

(WTF::VectorBuffer::endOfBuffer):

10:42 AM Changeset in webkit [233156] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: color outline is too dark
https://bugs.webkit.org/show_bug.cgi?id=186975

Reviewed by Brian Burg.

Make the outline lighter than the background.

  • UserInterface/Views/DarkMode.css:

(@media (prefers-dark-interface)):
(.hover-menu > svg > :matches(path, rect)):

10:39 AM Changeset in webkit [233155] by Keith Rollin
  • 2 edits in trunk/Source/ThirdParty/libwebrtc

Adjust webrtc library for LTO
https://bugs.webkit.org/show_bug.cgi?id=186952
<rdar://problem/41387815>

Reviewed by Youenn Fablet.

There are a number of files in webrtc that have main() functions (in
particular, rtpcat.cc and click_annotate.cc). When compiling with LTO,
these symbols are exposed to each other, leading to the following
build failure:

Ld libwebrtc.dylib
duplicate symbol _main in:
ld: 1 duplicate symbol for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
BUILD FAILED

Address this by removing the indicated files from the build.

  • libwebrtc.xcodeproj/project.pbxproj:
10:38 AM Changeset in webkit [233154] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: Media query names are unreadable
https://bugs.webkit.org/show_bug.cgi?id=186974

Reviewed by Brian Burg.

Change media query names from dark blue to light blue.

  • UserInterface/Views/DarkMode.css:

(@media (prefers-dark-interface)):
(.CodeMirror .CodeMirror-lines .CodeMirror-matchingbracket):
(.cm-s-default .cm-attribute):

10:35 AM Changeset in webkit [233153] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: Network headers colors are too dim
https://bugs.webkit.org/show_bug.cgi?id=186985

Reviewed by Brian Burg.

Increasing the luminance of network header colors by increasing lightness and brightness.

  • UserInterface/Views/DarkMode.css:

(@media (prefers-dark-interface)):
(:root):

10:34 AM Changeset in webkit [233152] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: Font guideline colors are too bright
https://bugs.webkit.org/show_bug.cgi?id=186986

Reviewed by Brian Burg.

Make the guidelines less distractive from the font glyphs.

  • UserInterface/Views/DarkMode.css:

(@media (prefers-dark-interface)):
(.content-view.resource.font .preview > .line):
(.content-view.resource.font .metric.top):
(.content-view.resource.font .metric.baseline):
(.content-view.resource.font .metric.middle):
(.content-view.resource.font .metric.xheight):
(.content-view.resource.font .metric.bottom):

9:48 AM Changeset in webkit [233151] by Ross Kirsling
  • 2 edits in trunk/Tools

[WinCairo] Unreviewed build fix for r233088.

  • BuildSlaveSupport/built-product-archive:

(extractBuiltProduct):
"move" throws instead of overwriting, so just use "copy" instead.

9:31 AM Changeset in webkit [233150] by commit-queue@webkit.org
  • 2 edits in trunk/Tools

[test262-runner] Sort the list of failing files in the HTML report
https://bugs.webkit.org/show_bug.cgi?id=186998

Patch by Leo Balter <leonardo.balter@gmail.com> on 2018-06-25
Reviewed by Michael Saboff.

  • Scripts/test262/Runner.pm:

(printHTMLResults): The current list of failing files it not ordered and it's hard to read.
This small patch will sort the list.

9:22 AM Changeset in webkit [233149] by Brian Burg
  • 2 edits in trunk/Source/WebKit

[Mac] Web Automation: include correct key code with synthesized NSEvents used for keystrokes
https://bugs.webkit.org/show_bug.cgi?id=186937

Reviewed by Timothy Hatcher.

In some cases, a missing keyCode for an ASCII letter/number can cause synthesized
NSEvents to not be converted into a key equivalent action like copy: or paste:.

  • UIProcess/Automation/mac/WebAutomationSessionMac.mm:

Drive by, always initialize keyCode.

(WebKit::WebAutomationSession::platformSimulateKeyboardInteraction):
(WebKit::keyCodeForCharKey): Compute the keyCode as defined by HLTB headers.
This only needs to be computed for characters with physical keys, excluding the
number pad and some traditional virtual keys that do not usually have glyphs.

8:57 AM Changeset in webkit [233148] by Simon Fraser
  • 3 edits in trunk/Source/WebCore

AutoTableLayout wastes 52KB of Vector capacity on nytimes.com
https://bugs.webkit.org/show_bug.cgi?id=186710

Reviewed by Zalan Bujtas.

Call resizeToFit() to only allocate enough capacity for the number of columns.

  • rendering/AutoTableLayout.cpp:

(WebCore::AutoTableLayout::fullRecalc):
(WebCore::AutoTableLayout::insertSpanCell): Whitespace fix.

  • rendering/AutoTableLayout.h:
8:38 AM Changeset in webkit [233147] by jonlee@apple.com
  • 10 edits in trunk/PerformanceTests

[MotionMark] Add support for version numbers
https://bugs.webkit.org/show_bug.cgi?id=186479

Reviewed by Said Abou-Hallawa.

Add support for displaying the version number as well as including it in the JSON results.

When loading the front page, script replaces any element with classname version with the
version number of the benchmark, which is stored in Strings.version.

The JSON structure for the results includes a new version property:

{

"version": "1.0",
"options": { ... },
"data": [ ... ]

}

When dragging a results file, the version listed will come from the JSON file. Older
results will not have had the version property, in which case it will default to "1.0".

  • MotionMark/index.html: Update title to some other default. Script will update it.

Include the version number in the logo title.

  • MotionMark/developer.html: Ditto.
  • MotionMark/about.html: Ditto.
  • MotionMark/resources/runner/motionmark.js:

(ResultsDashboard): Update constructor to include version. This is used when serializing
results out to JSON, and displaying the results panel in developer mode.
(ResultsDashboard._processData): When running the benchmark, include benchmark version string
in the results object.
(ResultsDashboard.version):
(window.benchmarkRunnerClient.willStartFirstIteration): When running the benchmark, pass the
benchmark version string to the dashboard, which holds the results.
(window.sectionsManager.setSectionVersion): Helper function to update the element in the
section with the class name version.
(window.benchmarkController.initialize): Populate all DOM elements with class name "version"
with the version string. Update the page title.
(window.benchmarkController.showResults): When showing results, update the version string
based on what is included in the JSON results, which would be the same as the benchmark version.

  • MotionMark/resources/runner/motionmark.css: Include missing copyright. Wrap the SVG logo

in a div and include the version string.

  • MotionMark/resources/strings.js: Add strings for the page title template, and the version.
  • MotionMark/resources/debug-runner/motionmark.css:
  • MotionMark/resources/debug-runner/motionmark.js:

(window.benchmarkRunnerClient.willStartFirstIteration): When running the benchmark, pass the
benchmark version string to the dashboard, which holds the results.
(window.benchmarkController.initialize): Populate all DOM elements with class name "version"
with the version string. Update the page title. When dragging in JSON results, look for
version to pass to the dashboard. If it doesn't exist, default to "1.0".
(window.benchmarkController.showResults): When showing results, update the version string
based on what is included in the JSON results, instead of the current benchmark version.

  • MotionMark/resources/debug-runner/tests.js: Update page title template.
8:15 AM Changeset in webkit [233146] by rmorisset@apple.com
  • 5 edits in trunk/Tools

[WSL] Start writing the Sphinx document
https://bugs.webkit.org/show_bug.cgi?id=186310

Rubberstamped by Filip Pizlo.

Very early work, just has the lexer and a few fragments of the parser so far.
Also fixing some minor mistake in the formal rules.

8:01 AM Changeset in webkit [233145] by Alan Bujtas
  • 4 edits in trunk/Source/WebCore

[LFC] Adjust static position with containing block's content box top/left
https://bugs.webkit.org/show_bug.cgi?id=186999

Reviewed by Antti Koivisto.

  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):

  • layout/displaytree/DisplayBox.cpp:

(WebCore::Display::Box::contentBox const):

  • layout/displaytree/DisplayBox.h:

(WebCore::Display::Box::contentBoxTop const):
(WebCore::Display::Box::contentBoxLeft const):

5:43 AM Changeset in webkit [233144] by ddkilzer@apple.com
  • 3 edits in trunk/Source/WebCore

REGRESSION (r233140): Windows build failure due to incomplete DocumentAnimationScheduler type
<https://webkit.org/b/186997>

  • dom/Document.cpp:
  • dom/Document.h:
  • Attempt to fix Windows build failure by moving include of DocumentAnimationScheduler.h from Document.cpp to Document.h.
3:58 AM Changeset in webkit [233143] by Philippe Normand
  • 2 edits in trunk/Source/WebCore

[GStreamer] Remove useless workaround
https://bugs.webkit.org/show_bug.cgi?id=186921

Reviewed by Xabier Rodriguez-Calvar.

In bug 67407 a workaround was added for GStreamer 0.10. With 1.x
the media/video-reverse-play-duration.html test passes without any
workaround needed. The other test mentioned in that bug was
removed, it seems.

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::currentMediaTime const):

3:22 AM Changeset in webkit [233142] by tpopela@redhat.com
  • 2 edits in trunk/Source/WebCore

Unreviewed, address Darin's comment
https://bugs.webkit.org/show_bug.cgi?id=186757

  • page/linux/ResourceUsageThreadLinux.cpp:

(WebCore::cpuPeriod):

3:00 AM Changeset in webkit [233141] by graouts@webkit.org
  • 7 edits in trunk

[Web Animations] Make imported/mozilla/css-animations/test_animation-pausing.html pass reliably
https://bugs.webkit.org/show_bug.cgi?id=183826
<rdar://problem/40997412>

Reviewed by Dean Jackson.

LayoutTests/imported/mozilla:

Mark progressions in the Mozilla CSS Animations tests.

  • css-animations/test_animation-pausing-expected.txt:

Source/WebCore:

The CSS Animations Level 2 specification defines that calling pause() on a CSSAnimation object is "sticky"
until a call to play() is made, meaning that any changes to the running state via the CSS animation-play-state
property is overridden by the stickiness of the pause() call. In this patch we add an m_stickyPaused flag which
is set in API calls to pause() and play(). While this flag is true, changes to the animation-play-state property
to the "running" value are ignored.

  • animation/CSSAnimation.cpp:

(WebCore::CSSAnimation::syncPropertiesWithBackingAnimation):
(WebCore::CSSAnimation::bindingsPlay):
(WebCore::CSSAnimation::bindingsPause):

  • animation/CSSAnimation.h:

LayoutTests:

This test now passes reliably.

2:54 AM Changeset in webkit [233140] by graouts@webkit.org
  • 12 edits
    2 adds in trunk

[Web Animations] Ensure animations are updated prior to requestAnimationFrame callbacks
https://bugs.webkit.org/show_bug.cgi?id=186997
<rdar://problem/41419414>

Reviewed by Dean Jackson.

LayoutTests/imported/mozilla:

Mark progressions in the Mozilla CSS Animations tests.

  • css-animations/test_animation-pausing-expected.txt:

Source/WebCore:

Some sub-tests of imported/mozilla/css-animations/test_animation-pausing.html clearly expect that animations
would be resolved prior to firing a requestAnimationFrame() callback, as the HTML5 event loop mandates. But until
now, both DocumentTimeline and ScriptedAnimationController would make calls to DisplayRefreshMonitorManager::scheduleAnimation()
that were not coordinated and so the order in which the DocumentTimeline and ScriptedAnimationController callbacks
were performed was not guaranteed.

In this patch we add a new DocumentAnimationScheduler class which is created by a Document to manage this specific
situation. Now DocumentTimeline and ScriptedAnimationController use this supporting object instead of being their
own DisplayRefreshMonitorClient and call scheduleWebAnimationsResolution() and scheduleScriptedAnimationResolution()
respectively to indicate the need to schedule an animation through the DisplayRefreshMonitorManager to serve the specific
needs of either, or both, classes. Then DocumentAnimationScheduler ensures that Web Animations resolution happens
prior to requestAnimationFrame callbacks when both are scheduled.

In the future we should be able to move more code from DocumentTimeline and ScriptedAnimationController over to
DocumentAnimationScheduler, such as support for throttling and using a timer-based fallback, but this patch provides
the minimal functionality required to provide a sounder foundation.

  • Modules/webvr/VRDisplay.cpp:

(WebCore::VRDisplay::requestAnimationFrame):

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • animation/DocumentAnimationScheduler.cpp: Added.

(WebCore::DocumentAnimationScheduler::create):
(WebCore::DocumentAnimationScheduler::DocumentAnimationScheduler):
(WebCore::DocumentAnimationScheduler::detachFromDocument):
(WebCore::DocumentAnimationScheduler::scheduleWebAnimationsResolution):
(WebCore::DocumentAnimationScheduler::scheduleScriptedAnimationResolution):
(WebCore::DocumentAnimationScheduler::displayRefreshFired):
(WebCore::DocumentAnimationScheduler::windowScreenDidChange):
(WebCore::DocumentAnimationScheduler::createDisplayRefreshMonitor const):

  • animation/DocumentAnimationScheduler.h: Copied from Source/WebCore/animation/CSSAnimation.h.
  • animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::create):
(WebCore::DocumentTimeline::DocumentTimeline):
(WebCore::DocumentTimeline::scheduleAnimationResolution):
(WebCore::DocumentTimeline::windowScreenDidChange): Deleted.
(WebCore::DocumentTimeline::createDisplayRefreshMonitor const): Deleted.

  • animation/DocumentTimeline.h:
  • dom/Document.cpp:

(WebCore::Document::prepareForDestruction):
(WebCore::Document::windowScreenDidChange):
(WebCore::Document::requestAnimationFrame):
(WebCore::Document::animationScheduler):
(WebCore::Document::timeline):

  • dom/Document.h:
  • dom/ScriptedAnimationController.cpp:

(WebCore::ScriptedAnimationController::ScriptedAnimationController):
(WebCore::ScriptedAnimationController::scheduleAnimation):
(WebCore::ScriptedAnimationController::documentAnimationSchedulerDidFire):
(WebCore::ScriptedAnimationController::windowScreenDidChange): Deleted.
(WebCore::ScriptedAnimationController::displayRefreshFired): Deleted.
(WebCore::ScriptedAnimationController::createDisplayRefreshMonitor const): Deleted.

  • dom/ScriptedAnimationController.h:

(WebCore::ScriptedAnimationController::create):

2:26 AM Changeset in webkit [233139] by Yusuke Suzuki
  • 3 edits in trunk/Source/JavaScriptCore

[JSC] Remove unnecessary PLATFORM guards
https://bugs.webkit.org/show_bug.cgi?id=186995

Reviewed by Mark Lam.

  • assembler/AssemblerCommon.h:

(JSC::isIOS):
Add constexpr.

  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::appendAPIBacktrace):
StackFrame works in all the platforms. If StackFrame::demangle failed,
it just returns std::nullopt. And it is correctly handled in this code.

12:05 AM Changeset in webkit [233138] by zandobersek@gmail.com
  • 10 edits in trunk

Source/WebCore:
[GCrypt] Zero-prefix (if necessary) output of RSA-based encryption and signing operations
https://bugs.webkit.org/show_bug.cgi?id=186967

Reviewed by Michael Catanzaro.

Output for RSA-based encryption and signing operations should match the
length of the RSA key. The way we retrieve the MPI data means libgcrypt
can ignore the high-bit zero values and leave us with a valid result
that's shorter in length compared to the RSA key. For instance, if the
output MPI fits into 2040 bits while a 2048-bit key was used we'll end
up with MPI data that will be fitted into a 255-byte Vector, one byte
short of the expected output length.

To avoid this, mpiZeroPrefixedData() is now used when retrieving output
of these RSA operations, and the value of the key size in bytes is
passed to it. This efficiently prepares the output Vector and then
copies the MPI data into it, respecting the MPI data length as well as
the desired length of the output.

No new tests -- relevant tests are now stable (i.e. not sporadically
failing anymore), associated expectations are removed.

  • crypto/gcrypt/CryptoAlgorithmECDHGCrypt.cpp:

(WebCore::gcryptDerive): Also use mpiZeroPrefixedData().

  • crypto/gcrypt/CryptoAlgorithmRSAES_PKCS1_v1_5GCrypt.cpp:

(WebCore::gcryptEncrypt):
(WebCore::CryptoAlgorithmRSAES_PKCS1_v1_5::platformEncrypt):

  • crypto/gcrypt/CryptoAlgorithmRSASSA_PKCS1_v1_5GCrypt.cpp:

(WebCore::gcryptSign):
(WebCore::CryptoAlgorithmRSASSA_PKCS1_v1_5::platformSign):

  • crypto/gcrypt/CryptoAlgorithmRSA_OAEPGCrypt.cpp:

(WebCore::gcryptEncrypt):
(WebCore::CryptoAlgorithmRSA_OAEP::platformEncrypt):

  • crypto/gcrypt/CryptoAlgorithmRSA_PSSGCrypt.cpp:

(WebCore::gcryptSign):
(WebCore::CryptoAlgorithmRSA_PSS::platformSign):

  • crypto/gcrypt/GCryptUtilities.h:

(WebCore::mpiZeroPrefixedData):

LayoutTests:
[GCrypt] Zero-prefix (if necessary) RSA-OAEP encryption, RSA-PSS signing output
https://bugs.webkit.org/show_bug.cgi?id=186967

Reviewed by Michael Catanzaro.

  • platform/gtk/TestExpectations: Remove flaky failures for RSA-OAEP and RSA-PSS tests.
  • platform/wpe/TestExpectations: Ditto.

Jun 24, 2018:

11:31 PM Changeset in webkit [233137] by Carlos Garcia Campos
  • 3 edits in trunk/Source/WebDriver

Unreviewed. Fix WebDriver tests after r233077.

WebDriver process is crashing because GVariant doesn't allow to pass a nullptr array when using @ modifier.

  • SessionHost.h:
  • glib/SessionHostGlib.cpp:

(WebDriver::SessionHost::buildSessionCapabilities const): Receive a GVariantBuilder and return true if there are
session capabilities.
(WebDriver::SessionHost::startAutomationSession): Remove the @ modifier and use a GVariantBuilder instead, or
nullptr if there aren't session capabilities.

9:40 PM Changeset in webkit [233136] by Simon Fraser
  • 2 edits in trunk/Source/WebCore

Fix the DUMP_NODE_STATISTICS code so that it compiles
https://bugs.webkit.org/show_bug.cgi?id=186982

Reviewed by Anders Carlsson.

The DUMP_NODE_STATISTICS code had bitrotted. ENTITY_NODE no longer exists.
liveNodeSet needs to be a static function with a NeverDestroyed<>.

  • dom/Node.cpp:

(WebCore::Node::dumpStatistics):
(WebCore::Node::trackForDebugging):
(WebCore::Node::~Node):

6:52 PM Changeset in webkit [233135] by Simon Fraser
  • 3 edits
    2 adds in trunk

Fix the composition underline to be transformed by -apple-color-filter
https://bugs.webkit.org/show_bug.cgi?id=186983
rdar://problem/40515558

Reviewed by Zalan Bujtas.

Source/WebCore:

Transform the composition underline color with the color filter.

Test: css3/color-filters/color-filter-composition-underline-color.html

  • rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintCompositionUnderline const):

LayoutTests:

  • css3/color-filters/color-filter-composition-underline-color-expected.html: Added.
  • css3/color-filters/color-filter-composition-underline-color.html: Added.
12:01 PM Changeset in webkit [233134] by Yusuke Suzuki
  • 2 edits in trunk/Source/bmalloc

[bmalloc][Linux] Remove static initializers for PerProcess<>::s_object
https://bugs.webkit.org/show_bug.cgi?id=186966

Reviewed by Anders Carlsson.

chrome/tools/linux/dump-static-initializers.py can dump static initializers
in the binary and we found that PerProcess<>::s_object initialization is done
by static initializers in GCC + Linux environments. The example is the following.

Scavenger.cpp (initializer offset 0x38c210 size 0x3e)

_GLOBALsub_I_Scavenger.cpp+0x1e
_GLOBAL
sub_I_Scavenger.cpp+0x2d
_GLOBALsub_I_Scavenger.cpp+0x3c
_GLOBAL
sub_I_Scavenger.cpp+0xf
guard variable for bmalloc::PerProcess<bmalloc::AllIsoHeaps>::s_object@@Base-0x3f0d8
guard variable for bmalloc::PerProcess<bmalloc::Environment>::s_object@@Base-0x3f0e8
guard variable for bmalloc::PerProcess<bmalloc::PerHeapKind<bmalloc::Heap> >::s_object@@Base-0x3c600
guard variable for bmalloc::PerProcess<bmalloc::Scavenger>::s_object@@Base-0x38ce8

We can remove this by initializing nullptr, which leads to constexpr initialization.
After this change, Linux JSCOnly libJavaScriptCore.so has no static initializers.

  • bmalloc/PerProcess.h:
9:59 AM Changeset in webkit [233133] by Michael Catanzaro
  • 2 edits in trunk/Source/WebKit

Unreviewed, fix GTK debug build after r233131
https://bugs.webkit.org/show_bug.cgi?id=186899
<rdar://problem/38222248>

This assertion was intended to be removed.

  • UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:

(WebKit::WebAutomationSession::platformSimulateKeyboardInteraction):

Jun 23, 2018:

2:07 PM Changeset in webkit [233132] by Alan Bujtas
  • 6 edits
    2 adds in trunk

[Mail] Use the Mail Viewer width as the base for resolving horizontal viewport units
https://bugs.webkit.org/show_bug.cgi?id=186585
<rdar://problem/30685325>

Reviewed by Tim Horton.

Source/WebCore:

Use the existing "override viewport size for viewport units" mechanism to compute the preferred
viewport unit values for the Mail Viewer html content.

Test: fast/dynamic/mail-autosize-viewport-unit.html

  • page/FrameView.cpp:

(WebCore::FrameView::FrameView):
(WebCore::FrameView::enableAutoSizeMode):
(WebCore::FrameView::clearViewportSizeOverrideForCSSViewportUnits):
(WebCore::FrameView::setViewportSizeForCSSViewportUnits):
(WebCore::FrameView::overrideViewportSizeForCSSViewportUnits):
(WebCore::FrameView::viewportSizeForCSSViewportUnits const):

  • page/FrameView.h:

LayoutTests:

  • fast/dynamic/mail-autosize-viewport-unit-expected.txt: Added.
  • fast/dynamic/mail-autosize-viewport-unit.html: Added.
12:17 PM Changeset in webkit [233131] by Brian Burg
  • 11 edits in trunk/Source

Web Automation: key actions should support multiple pressed virtual keys
https://bugs.webkit.org/show_bug.cgi?id=186899
<rdar://problem/38222248>

Reviewed by Timothy Hatcher.

Source/WebDriver:

Adopt new protocol command argument types.

  • Session.cpp:

(WebDriver::Session::performActions):

Source/WebKit:

This patch changes the protocol to allow multiple virtual keys per input source state.
Chords like Cmd-Shift-A and Shift-F12 must be represented this way as they are encoded
in the VirtualKey enum rather than as an ASCII char.

  • UIProcess/Automation/Automation.json:
  • UIProcess/Automation/SimulatedInputDispatcher.h:
  • UIProcess/Automation/SimulatedInputDispatcher.cpp:

(WebKit::SimulatedInputDispatcher::transitionInputSourceToState):

  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::simulateKeyboardInteraction):
(WebKit::WebAutomationSession::performKeyboardInteractions):
(WebKit::WebAutomationSession::performInteractionSequence):

  • UIProcess/Automation/WebAutomationSession.h:
  • UIProcess/Automation/gtk/WebAutomationSessionGtk.cpp:

(WebKit::WebAutomationSession::platformSimulateKeyboardInteraction):

  • UIProcess/Automation/ios/WebAutomationSessionIOS.mm:

(WebKit::WebAutomationSession::platformSimulateKeyboardInteraction):

  • UIProcess/Automation/mac/WebAutomationSessionMac.mm:

(WebKit::WebAutomationSession::platformSimulateKeyboardInteraction):
Also clean up the signature of WebAutomationSession::platformSimulateKeyboardInteraction
to use a variant instead of mutually exclusive optional values with different types.

8:51 AM Changeset in webkit [233130] by pvollan@apple.com
  • 2 edits in trunk/LayoutTests

Layout Test imported/mozilla/css-animations/test_animation-ready.html is failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=186807

Unreviewed test gardening.

  • platform/win/TestExpectations:
8:48 AM Changeset in webkit [233129] by mark.lam@apple.com
  • 2 edits in trunk/Source/JavaScriptCore

Add more debugging features to $vm.
https://bugs.webkit.org/show_bug.cgi?id=186947

Reviewed by Keith Miller.

Adding the following features:

We now have println in addition to print.
println automatically adds a '\n' at the end.
$vm.println("Hello");

We can now capture some info about a stack frame.
var currentFrame = $vm.callFrame();
Same as $vm.callFrame(0);
var callerCallerFrame = $vm.callFrame(2);

We can inspect the following values associated with the frame:
if (currentFrame.valid) {

$vm.println("name is ", currentFrame.name));

Note: For a WASM frame, all of these will be undefined.
$vm.println("callee is ", $vm.value(currentFrame.callee));
$vm.println("codeBlock is ", currentFrame.codeBlock);
$vm.println("unlinkedCodeBlock is ", currentFrame.unlinkedCodeBlock);
$vm.println("executable is ", currentFrame.executable);

}

Note that callee is a JSObject. I printed its $vm.value() because I wanted
to dataLog its JSValue instead of its toString() result.

Note that $vm.println() (and $vm.print()) can now print internal JSCells
(and Symbols) as JSValue dumps. It won't just fail on trying to do a
toString on a non-object.

Does what it says about enabling/disabling debugger mode.
$vm.enableDebuggerModeWhenIdle();
$vm.disableDebuggerModeWhenIdle();

  • tools/JSDollarVM.cpp:

(WTF::JSDollarVMCallFrame::JSDollarVMCallFrame):
(WTF::JSDollarVMCallFrame::createStructure):
(WTF::JSDollarVMCallFrame::create):
(WTF::JSDollarVMCallFrame::finishCreation):
(WTF::JSDollarVMCallFrame::addProperty):
(JSC::functionCallFrame):
(JSC::functionCodeBlockForFrame):
(JSC::codeBlockFromArg):
(JSC::doPrintln):
(JSC::functionPrint):
(JSC::functionPrintln):
(JSC::changeDebuggerModeWhenIdle):
(JSC::functionEnableDebuggerModeWhenIdle):
(JSC::functionDisableDebuggerModeWhenIdle):
(JSC::JSDollarVM::finishCreation):

8:30 AM Changeset in webkit [233128] by Darin Adler
  • 4 edits in trunk/Source/WTF

[Cocoa] Convert the small bit of Objective-C++ code in WTF to ARC
https://bugs.webkit.org/show_bug.cgi?id=186961

Reviewed by Anders Carlsson.

  • Configurations/Base.xcconfig: Turn on ARC.
  • wtf/cocoa/MemoryPressureHandlerCocoa.mm:

(WTF::MemoryPressureHandler::uninstall): Remove calls to dispatch_release.
(WTF::MemoryPressureHandler::holdOff): Ditto.

  • wtf/mac/MainThreadMac.mm:

(WTF::initializeMainThreadPlatform): Remove call to retain.
(WTF::initializeWebThreadPlatform): Ditto.

8:30 AM Changeset in webkit [233127] by mitz@apple.com
  • 9 copies
    1 add in releases/Apple/Safari Technology Preview 59

Added a tag for Safari Technology Preview release 59.

7:39 AM Changeset in webkit [233126] by Alan Bujtas
  • 3 edits in trunk/Source/WebCore

[LFC] Relatively positioned renderer needs offsetting for validation
https://bugs.webkit.org/show_bug.cgi?id=186959

Reviewed by Antti Koivisto.

  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):

  • layout/Verification.cpp:

(WebCore::Layout::outputMismatchingBoxInformationIfNeeded):

7:38 AM Changeset in webkit [233125] by Alan Bujtas
  • 5 edits in trunk/Source/WebCore

[LFC] Miscellaneous fixes to fix simple absolute positioning.
https://bugs.webkit.org/show_bug.cgi?id=186962

Reviewed by Antti Koivisto.

  1. Collect out-of-flow formatting root descendants.
  2. Remove invalid and redundant ASSERTs invalid because the assertion is missing border, padding etc. redundant becasue we assert on geometry correctness in validateGeometryConstraintsAfterLayout.
  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):

  • layout/layouttree/LayoutContainer.cpp:

(WebCore::Layout::Container::addOutOfFlowDescendant):
(WebCore::Layout::Container::setOutOfFlowDescendants): Deleted.

  • layout/layouttree/LayoutContainer.h:
  • layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createSubTree):

3:47 AM Changeset in webkit [233124] by keith_miller@apple.com
  • 5 edits in trunk/Source/JavaScriptCore

We need to have a getDirectConcurrently for use in the compilers
https://bugs.webkit.org/show_bug.cgi?id=186954

Reviewed by Mark Lam.

It used to be that the propertyStorage of an object never shrunk
so if you called getDirect with some offset it would never be an
OOB read. However, this property storage can shrink when calling
flattenDictionaryStructure. Fortunately, flattenDictionaryStructure
holds the Structure's ConcurrentJSLock while shrinking. This patch,
adds a getDirectConcurrently that will safely try to load from the
butterfly.

  • bytecode/ObjectPropertyConditionSet.cpp:
  • bytecode/PropertyCondition.cpp:

(JSC::PropertyCondition::isStillValidAssumingImpurePropertyWatchpoint const):
(JSC::PropertyCondition::attemptToMakeEquivalenceWithoutBarrier const):

  • dfg/DFGGraph.cpp:

(JSC::DFG::Graph::tryGetConstantProperty):

  • runtime/JSObject.h:

(JSC::JSObject::getDirectConcurrently const):

2:59 AM Changeset in webkit [233123] by Yusuke Suzuki
  • 19 edits in trunk/Source

[WTF] Use Ref<> for the result type of non-failing factory functions
https://bugs.webkit.org/show_bug.cgi?id=186920

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • dfg/DFGWorklist.cpp:

(JSC::DFG::Worklist::ThreadBody::ThreadBody):
(JSC::DFG::Worklist::finishCreation):

  • dfg/DFGWorklist.h:
  • heap/Heap.cpp:

(JSC::Heap::Thread::Thread):

  • heap/Heap.h:
  • jit/JITWorklist.cpp:

(JSC::JITWorklist::Thread::Thread):

  • jit/JITWorklist.h:
  • runtime/VMTraps.cpp:
  • runtime/VMTraps.h:
  • wasm/WasmWorklist.cpp:
  • wasm/WasmWorklist.h:

Source/WTF:

Use Ref<> instead of RefPtr<> if the create function do not return nullptr.

  • wtf/AutomaticThread.cpp:

(WTF::AutomaticThreadCondition::create):
(WTF::AutomaticThread::AutomaticThread):

  • wtf/AutomaticThread.h:
  • wtf/ParallelHelperPool.cpp:

(WTF::ParallelHelperPool::Thread::Thread):

  • wtf/ParallelHelperPool.h:
  • wtf/WorkerPool.cpp:

(WTF::WorkerPool::WorkerPool):

  • wtf/WorkerPool.h:
  • wtf/win/WorkQueueWin.cpp:

(WTF::TimerContext::create):
(WTF::WorkQueue::dispatchAfter):

1:39 AM Changeset in webkit [233122] by Yusuke Suzuki
  • 711 edits
    2 copies in trunk

[WTF] Add user-defined literal for ASCIILiteral
https://bugs.webkit.org/show_bug.cgi?id=186839

Reviewed by Darin Adler.

Source/JavaScriptCore:

  • API/JSCallbackObjectFunctions.h:

(JSC::JSCallbackObject<Parent>::staticFunctionGetter):
(JSC::JSCallbackObject<Parent>::callbackGetter):

  • API/JSObjectRef.cpp:

(JSObjectMakeFunctionWithCallback):

  • API/JSTypedArray.cpp:

(JSObjectGetArrayBufferBytesPtr):

  • API/JSValue.mm:

(valueToArray):
(valueToDictionary):

  • API/ObjCCallbackFunction.mm:

(JSC::objCCallbackFunctionCallAsFunction):
(JSC::objCCallbackFunctionCallAsConstructor):
(JSC::ObjCCallbackFunctionImpl::call):

  • API/glib/JSCCallbackFunction.cpp:

(JSC::JSCCallbackFunction::call):
(JSC::JSCCallbackFunction::construct):

  • API/glib/JSCContext.cpp:

(jscContextJSValueToGValue):

  • API/glib/JSCValue.cpp:

(jsc_value_object_define_property_accessor):
(jscValueFunctionCreate):

  • builtins/BuiltinUtils.h:
  • bytecode/CodeBlock.cpp:

(JSC::CodeBlock::nameForRegister):

  • bytecompiler/BytecodeGenerator.cpp:

(JSC::BytecodeGenerator::emitEnumeration):
(JSC::BytecodeGenerator::emitIteratorNext):
(JSC::BytecodeGenerator::emitIteratorClose):
(JSC::BytecodeGenerator::emitDelegateYield):

  • bytecompiler/NodesCodegen.cpp:

(JSC::FunctionCallValueNode::emitBytecode):
(JSC::PostfixNode::emitBytecode):
(JSC::PrefixNode::emitBytecode):
(JSC::AssignErrorNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ForOfNode::emitBytecode):
(JSC::ClassExprNode::emitBytecode):
(JSC::ObjectPatternNode::bindValue const):

  • dfg/DFGDriver.cpp:

(JSC::DFG::compileImpl):

  • dfg/DFGOperations.cpp:

(JSC::DFG::newTypedArrayWithSize):

  • dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

  • inspector/ConsoleMessage.cpp:

(Inspector::ConsoleMessage::addToFrontend):
(Inspector::ConsoleMessage::clear):

  • inspector/ContentSearchUtilities.cpp:

(Inspector::ContentSearchUtilities::findStylesheetSourceMapURL):

  • inspector/InjectedScript.cpp:

(Inspector::InjectedScript::InjectedScript):
(Inspector::InjectedScript::evaluate):
(Inspector::InjectedScript::callFunctionOn):
(Inspector::InjectedScript::evaluateOnCallFrame):
(Inspector::InjectedScript::getFunctionDetails):
(Inspector::InjectedScript::functionDetails):
(Inspector::InjectedScript::getPreview):
(Inspector::InjectedScript::getProperties):
(Inspector::InjectedScript::getDisplayableProperties):
(Inspector::InjectedScript::getInternalProperties):
(Inspector::InjectedScript::getCollectionEntries):
(Inspector::InjectedScript::saveResult):
(Inspector::InjectedScript::wrapCallFrames const):
(Inspector::InjectedScript::wrapObject const):
(Inspector::InjectedScript::wrapJSONString const):
(Inspector::InjectedScript::wrapTable const):
(Inspector::InjectedScript::previewValue const):
(Inspector::InjectedScript::setExceptionValue):
(Inspector::InjectedScript::clearExceptionValue):
(Inspector::InjectedScript::findObjectById const):
(Inspector::InjectedScript::inspectObject):
(Inspector::InjectedScript::releaseObject):
(Inspector::InjectedScript::releaseObjectGroup):

  • inspector/InjectedScriptBase.cpp:

(Inspector::InjectedScriptBase::makeEvalCall):

  • inspector/InjectedScriptManager.cpp:

(Inspector::InjectedScriptManager::injectedScriptForObjectId):

  • inspector/InjectedScriptModule.cpp:

(Inspector::InjectedScriptModule::ensureInjected):

  • inspector/InspectorBackendDispatcher.cpp:

(Inspector::BackendDispatcher::dispatch):
(Inspector::BackendDispatcher::sendResponse):
(Inspector::BackendDispatcher::sendPendingErrors):

  • inspector/JSGlobalObjectConsoleClient.cpp:

(Inspector::JSGlobalObjectConsoleClient::profile):
(Inspector::JSGlobalObjectConsoleClient::profileEnd):
(Inspector::JSGlobalObjectConsoleClient::timeStamp):

  • inspector/JSGlobalObjectInspectorController.cpp:

(Inspector::JSGlobalObjectInspectorController::appendAPIBacktrace):

  • inspector/JSInjectedScriptHost.cpp:

(Inspector::JSInjectedScriptHost::evaluateWithScopeExtension):
(Inspector::JSInjectedScriptHost::subtype):
(Inspector::JSInjectedScriptHost::getInternalProperties):

  • inspector/JSJavaScriptCallFrame.cpp:

(Inspector::JSJavaScriptCallFrame::evaluateWithScopeExtension):
(Inspector::JSJavaScriptCallFrame::type const):

  • inspector/ScriptArguments.cpp:

(Inspector::ScriptArguments::getFirstArgumentAsString):

  • inspector/ScriptCallStackFactory.cpp:

(Inspector::extractSourceInformationFromException):

  • inspector/agents/InspectorAgent.cpp:

(Inspector::InspectorAgent::InspectorAgent):

  • inspector/agents/InspectorConsoleAgent.cpp:

(Inspector::InspectorConsoleAgent::InspectorConsoleAgent):
(Inspector::InspectorConsoleAgent::clearMessages):
(Inspector::InspectorConsoleAgent::count):
(Inspector::InspectorConsoleAgent::setLoggingChannelLevel):

  • inspector/agents/InspectorDebuggerAgent.cpp:

(Inspector::InspectorDebuggerAgent::InspectorDebuggerAgent):
(Inspector::InspectorDebuggerAgent::setAsyncStackTraceDepth):
(Inspector::buildObjectForBreakpointCookie):
(Inspector::InspectorDebuggerAgent::breakpointActionsFromProtocol):
(Inspector::parseLocation):
(Inspector::InspectorDebuggerAgent::setBreakpointByUrl):
(Inspector::InspectorDebuggerAgent::setBreakpoint):
(Inspector::InspectorDebuggerAgent::continueToLocation):
(Inspector::InspectorDebuggerAgent::searchInContent):
(Inspector::InspectorDebuggerAgent::getScriptSource):
(Inspector::InspectorDebuggerAgent::getFunctionDetails):
(Inspector::InspectorDebuggerAgent::resume):
(Inspector::InspectorDebuggerAgent::setPauseOnExceptions):
(Inspector::InspectorDebuggerAgent::evaluateOnCallFrame):
(Inspector::InspectorDebuggerAgent::didParseSource):
(Inspector::InspectorDebuggerAgent::assertPaused):

  • inspector/agents/InspectorHeapAgent.cpp:

(Inspector::InspectorHeapAgent::InspectorHeapAgent):
(Inspector::InspectorHeapAgent::nodeForHeapObjectIdentifier):
(Inspector::InspectorHeapAgent::getPreview):
(Inspector::InspectorHeapAgent::getRemoteObject):

  • inspector/agents/InspectorRuntimeAgent.cpp:

(Inspector::InspectorRuntimeAgent::InspectorRuntimeAgent):
(Inspector::InspectorRuntimeAgent::callFunctionOn):
(Inspector::InspectorRuntimeAgent::getPreview):
(Inspector::InspectorRuntimeAgent::getProperties):
(Inspector::InspectorRuntimeAgent::getDisplayableProperties):
(Inspector::InspectorRuntimeAgent::getCollectionEntries):
(Inspector::InspectorRuntimeAgent::saveResult):
(Inspector::InspectorRuntimeAgent::getRuntimeTypesForVariablesAtOffsets):
(Inspector::InspectorRuntimeAgent::getBasicBlocks):

  • inspector/agents/InspectorScriptProfilerAgent.cpp:

(Inspector::InspectorScriptProfilerAgent::InspectorScriptProfilerAgent):

  • inspector/agents/JSGlobalObjectDebuggerAgent.cpp:

(Inspector::JSGlobalObjectDebuggerAgent::injectedScriptForEval):

  • inspector/agents/JSGlobalObjectRuntimeAgent.cpp:

(Inspector::JSGlobalObjectRuntimeAgent::injectedScriptForEval):

  • inspector/scripts/codegen/cpp_generator_templates.py:
  • inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:

(CppBackendDispatcherImplementationGenerator._generate_async_dispatcher_class_for_domain):
(CppBackendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_command):

  • inspector/scripts/codegen/generate_cpp_frontend_dispatcher_implementation.py:

(CppFrontendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_event):

  • inspector/scripts/codegen/generate_cpp_protocol_types_header.py:
  • inspector/scripts/codegen/generate_cpp_protocol_types_implementation.py:

(CppProtocolTypesImplementationGenerator):

  • inspector/scripts/codegen/generate_objc_backend_dispatcher_implementation.py:

(ObjCBackendDispatcherImplementationGenerator._generate_success_block_for_command):
(ObjCBackendDispatcherImplementationGenerator._generate_conversions_for_command):

  • inspector/scripts/codegen/generate_objc_frontend_dispatcher_implementation.py:

(ObjCFrontendDispatcherImplementationGenerator._generate_event):
(ObjCFrontendDispatcherImplementationGenerator._generate_event_out_parameters):

  • inspector/scripts/codegen/generate_objc_protocol_type_conversions_header.py:

(ObjCProtocolTypeConversionsHeaderGenerator._generate_enum_objc_to_protocol_string):

  • inspector/scripts/codegen/objc_generator_templates.py:
  • inspector/scripts/tests/all/expected/definitions-with-mac-platform.json-result:
  • inspector/scripts/tests/generic/expected/commands-with-async-attribute.json-result:
  • inspector/scripts/tests/generic/expected/commands-with-optional-call-return-parameters.json-result:
  • inspector/scripts/tests/generic/expected/definitions-with-mac-platform.json-result:
  • inspector/scripts/tests/generic/expected/domain-availability.json-result:
  • inspector/scripts/tests/generic/expected/domains-with-varying-command-sizes.json-result:
  • inspector/scripts/tests/generic/expected/enum-values.json-result:
  • inspector/scripts/tests/generic/expected/events-with-optional-parameters.json-result:
  • inspector/scripts/tests/generic/expected/generate-domains-with-feature-guards.json-result:
  • inspector/scripts/tests/generic/expected/same-type-id-different-domain.json-result:
  • inspector/scripts/tests/generic/expected/shadowed-optional-type-setters.json-result:
  • inspector/scripts/tests/generic/expected/type-declaration-aliased-primitive-type.json-result:
  • inspector/scripts/tests/generic/expected/type-declaration-array-type.json-result:
  • inspector/scripts/tests/generic/expected/type-declaration-enum-type.json-result:
  • inspector/scripts/tests/generic/expected/type-declaration-object-type.json-result:
  • inspector/scripts/tests/generic/expected/type-requiring-runtime-casts.json-result:
  • inspector/scripts/tests/generic/expected/type-with-open-parameters.json-result:
  • inspector/scripts/tests/generic/expected/worker-supported-domains.json-result:
  • inspector/scripts/tests/ios/expected/definitions-with-mac-platform.json-result:
  • inspector/scripts/tests/mac/expected/definitions-with-mac-platform.json-result:
  • interpreter/CallFrame.cpp:

(JSC::CallFrame::friendlyFunctionName):

  • interpreter/Interpreter.cpp:

(JSC::Interpreter::execute):

  • interpreter/StackVisitor.cpp:

(JSC::StackVisitor::Frame::functionName const):
(JSC::StackVisitor::Frame::sourceURL const):

  • jit/JIT.cpp:

(JSC::JIT::doMainThreadPreparationBeforeCompile):

  • jit/JITOperations.cpp:
  • jsc.cpp:

(resolvePath):
(GlobalObject::moduleLoaderImportModule):
(GlobalObject::moduleLoaderResolve):
(functionDescribeArray):
(functionRun):
(functionLoad):
(functionCheckSyntax):
(functionDollarEvalScript):
(functionDollarAgentStart):
(functionDollarAgentReceiveBroadcast):
(functionDollarAgentBroadcast):
(functionTransferArrayBuffer):
(functionLoadModule):
(functionSamplingProfilerStackTraces):
(functionAsyncTestStart):
(functionWebAssemblyMemoryMode):
(runWithOptions):

  • parser/Lexer.cpp:

(JSC::Lexer<T>::invalidCharacterMessage const):
(JSC::Lexer<T>::parseString):
(JSC::Lexer<T>::parseComplexEscape):
(JSC::Lexer<T>::parseStringSlowCase):
(JSC::Lexer<T>::parseTemplateLiteral):
(JSC::Lexer<T>::lex):

  • parser/Parser.cpp:

(JSC::Parser<LexerType>::parseInner):

  • parser/Parser.h:

(JSC::Parser::setErrorMessage):

  • runtime/AbstractModuleRecord.cpp:

(JSC::AbstractModuleRecord::finishCreation):

  • runtime/ArrayBuffer.cpp:

(JSC::errorMesasgeForTransfer):

  • runtime/ArrayBufferSharingMode.h:

(JSC::arrayBufferSharingModeName):

  • runtime/ArrayConstructor.cpp:

(JSC::constructArrayWithSizeQuirk):
(JSC::isArraySlowInline):

  • runtime/ArrayPrototype.cpp:

(JSC::setLength):
(JSC::shift):
(JSC::unshift):
(JSC::arrayProtoFuncPop):
(JSC::arrayProtoFuncReverse):
(JSC::arrayProtoFuncUnShift):

  • runtime/AtomicsObject.cpp:

(JSC::atomicsFuncWait):
(JSC::atomicsFuncWake):

  • runtime/BigIntConstructor.cpp:

(JSC::BigIntConstructor::finishCreation):
(JSC::toBigInt):
(JSC::callBigIntConstructor):

  • runtime/BigIntObject.cpp:

(JSC::BigIntObject::toStringName):

  • runtime/BigIntPrototype.cpp:

(JSC::bigIntProtoFuncToString):
(JSC::bigIntProtoFuncValueOf):

  • runtime/CommonSlowPaths.cpp:

(JSC::SLOW_PATH_DECL):

  • runtime/ConsoleClient.cpp:

(JSC::ConsoleClient::printConsoleMessageWithArguments):

  • runtime/ConsoleObject.cpp:

(JSC::valueOrDefaultLabelString):
(JSC::consoleProtoFuncTime):
(JSC::consoleProtoFuncTimeEnd):

  • runtime/DatePrototype.cpp:

(JSC::formatLocaleDate):
(JSC::formateDateInstance):
(JSC::DatePrototype::finishCreation):
(JSC::dateProtoFuncToISOString):
(JSC::dateProtoFuncToJSON):

  • runtime/Error.cpp:

(JSC::createNotEnoughArgumentsError):
(JSC::throwSyntaxError):
(JSC::createTypeError):
(JSC::createOutOfMemoryError):

  • runtime/Error.h:

(JSC::throwVMError):

  • runtime/ErrorConstructor.cpp:

(JSC::ErrorConstructor::finishCreation):

  • runtime/ErrorInstance.cpp:

(JSC::ErrorInstance::sanitizedToString):

  • runtime/ErrorPrototype.cpp:

(JSC::ErrorPrototype::finishCreation):
(JSC::errorProtoFuncToString):

  • runtime/ExceptionFuzz.cpp:

(JSC::doExceptionFuzzing):

  • runtime/ExceptionHelpers.cpp:

(JSC::TerminatedExecutionError::defaultValue):
(JSC::createStackOverflowError):
(JSC::createNotAConstructorError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):

  • runtime/GetterSetter.cpp:

(JSC::callSetter):

  • runtime/IntlCollator.cpp:

(JSC::sortLocaleData):
(JSC::searchLocaleData):
(JSC::IntlCollator::initializeCollator):
(JSC::IntlCollator::compareStrings):
(JSC::IntlCollator::usageString):
(JSC::IntlCollator::sensitivityString):
(JSC::IntlCollator::caseFirstString):
(JSC::IntlCollator::resolvedOptions):

  • runtime/IntlCollator.h:
  • runtime/IntlCollatorConstructor.cpp:

(JSC::IntlCollatorConstructor::finishCreation):

  • runtime/IntlCollatorPrototype.cpp:

(JSC::IntlCollatorPrototypeGetterCompare):
(JSC::IntlCollatorPrototypeFuncResolvedOptions):

  • runtime/IntlDateTimeFormat.cpp:

(JSC::defaultTimeZone):
(JSC::canonicalizeTimeZoneName):
(JSC::IntlDTFInternal::localeData):
(JSC::IntlDTFInternal::toDateTimeOptionsAnyDate):
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
(JSC::IntlDateTimeFormat::weekdayString):
(JSC::IntlDateTimeFormat::eraString):
(JSC::IntlDateTimeFormat::yearString):
(JSC::IntlDateTimeFormat::monthString):
(JSC::IntlDateTimeFormat::dayString):
(JSC::IntlDateTimeFormat::hourString):
(JSC::IntlDateTimeFormat::minuteString):
(JSC::IntlDateTimeFormat::secondString):
(JSC::IntlDateTimeFormat::timeZoneNameString):
(JSC::IntlDateTimeFormat::resolvedOptions):
(JSC::IntlDateTimeFormat::format):
(JSC::IntlDateTimeFormat::partTypeString):
(JSC::IntlDateTimeFormat::formatToParts):

  • runtime/IntlDateTimeFormat.h:
  • runtime/IntlDateTimeFormatConstructor.cpp:

(JSC::IntlDateTimeFormatConstructor::finishCreation):

  • runtime/IntlDateTimeFormatPrototype.cpp:

(JSC::IntlDateTimeFormatPrototypeGetterFormat):
(JSC::IntlDateTimeFormatPrototypeFuncFormatToParts):
(JSC::IntlDateTimeFormatPrototypeFuncResolvedOptions):

  • runtime/IntlNumberFormat.cpp:

(JSC::IntlNumberFormat::initializeNumberFormat):
(JSC::IntlNumberFormat::formatNumber):
(JSC::IntlNumberFormat::styleString):
(JSC::IntlNumberFormat::currencyDisplayString):
(JSC::IntlNumberFormat::resolvedOptions):
(JSC::IntlNumberFormat::partTypeString):
(JSC::IntlNumberFormat::formatToParts):

  • runtime/IntlNumberFormat.h:
  • runtime/IntlNumberFormatConstructor.cpp:

(JSC::IntlNumberFormatConstructor::finishCreation):

  • runtime/IntlNumberFormatPrototype.cpp:

(JSC::IntlNumberFormatPrototypeGetterFormat):
(JSC::IntlNumberFormatPrototypeFuncFormatToParts):
(JSC::IntlNumberFormatPrototypeFuncResolvedOptions):

  • runtime/IntlObject.cpp:

(JSC::grandfatheredLangTag):
(JSC::canonicalizeLocaleList):
(JSC::resolveLocale):
(JSC::supportedLocales):

  • runtime/IntlPluralRules.cpp:

(JSC::IntlPluralRules::initializePluralRules):
(JSC::IntlPluralRules::resolvedOptions):
(JSC::IntlPluralRules::select):

  • runtime/IntlPluralRulesConstructor.cpp:

(JSC::IntlPluralRulesConstructor::finishCreation):

  • runtime/IntlPluralRulesPrototype.cpp:

(JSC::IntlPluralRulesPrototypeFuncSelect):
(JSC::IntlPluralRulesPrototypeFuncResolvedOptions):

  • runtime/IteratorOperations.cpp:

(JSC::iteratorNext):
(JSC::iteratorClose):
(JSC::hasIteratorMethod):
(JSC::iteratorMethod):

  • runtime/JSArray.cpp:

(JSC::JSArray::tryCreateUninitializedRestricted):
(JSC::JSArray::defineOwnProperty):
(JSC::JSArray::put):
(JSC::JSArray::setLengthWithArrayStorage):
(JSC::JSArray::appendMemcpy):
(JSC::JSArray::pop):

  • runtime/JSArray.h:
  • runtime/JSArrayBufferConstructor.cpp:

(JSC::JSArrayBufferConstructor::finishCreation):

  • runtime/JSArrayBufferPrototype.cpp:

(JSC::arrayBufferProtoFuncSlice):
(JSC::arrayBufferProtoGetterFuncByteLength):
(JSC::sharedArrayBufferProtoGetterFuncByteLength):

  • runtime/JSArrayBufferView.cpp:

(JSC::JSArrayBufferView::toStringName):

  • runtime/JSArrayInlines.h:

(JSC::JSArray::pushInline):

  • runtime/JSBigInt.cpp:

(JSC::JSBigInt::divide):
(JSC::JSBigInt::remainder):
(JSC::JSBigInt::toNumber const):

  • runtime/JSCJSValue.cpp:

(JSC::JSValue::putToPrimitive):
(JSC::JSValue::putToPrimitiveByIndex):
(JSC::JSValue::toStringSlowCase const):

  • runtime/JSCJSValueInlines.h:

(JSC::toPreferredPrimitiveType):

  • runtime/JSDataView.cpp:

(JSC::JSDataView::create):
(JSC::JSDataView::put):
(JSC::JSDataView::defineOwnProperty):

  • runtime/JSDataViewPrototype.cpp:

(JSC::getData):
(JSC::setData):

  • runtime/JSFunction.cpp:

(JSC::JSFunction::callerGetter):
(JSC::JSFunction::put):
(JSC::JSFunction::defineOwnProperty):

  • runtime/JSGenericTypedArrayView.h:
  • runtime/JSGenericTypedArrayViewConstructorInlines.h:

(JSC::constructGenericTypedArrayViewWithArguments):
(JSC::constructGenericTypedArrayView):

  • runtime/JSGenericTypedArrayViewInlines.h:

(JSC::JSGenericTypedArrayView<Adaptor>::deleteProperty):

  • runtime/JSGenericTypedArrayViewPrototypeFunctions.h:

(JSC::speciesConstruct):
(JSC::genericTypedArrayViewProtoFuncSet):
(JSC::genericTypedArrayViewProtoFuncIndexOf):
(JSC::genericTypedArrayViewProtoFuncLastIndexOf):
(JSC::genericTypedArrayViewPrivateFuncSubarrayCreate):

  • runtime/JSGlobalObject.cpp:

(JSC::JSGlobalObject::init):

  • runtime/JSGlobalObjectDebuggable.cpp:

(JSC::JSGlobalObjectDebuggable::name const):

  • runtime/JSGlobalObjectFunctions.cpp:

(JSC::encode):
(JSC::decode):
(JSC::globalFuncProtoSetter):

  • runtime/JSGlobalObjectFunctions.h:
  • runtime/JSMap.cpp:

(JSC::JSMap::toStringName):

  • runtime/JSModuleEnvironment.cpp:

(JSC::JSModuleEnvironment::put):

  • runtime/JSModuleNamespaceObject.cpp:

(JSC::JSModuleNamespaceObject::put):
(JSC::JSModuleNamespaceObject::putByIndex):
(JSC::JSModuleNamespaceObject::defineOwnProperty):

  • runtime/JSONObject.cpp:

(JSC::Stringifier::appendStringifiedValue):
(JSC::JSONProtoFuncParse):
(JSC::JSONProtoFuncStringify):

  • runtime/JSObject.cpp:

(JSC::getClassPropertyNames):
(JSC::JSObject::calculatedClassName):
(JSC::ordinarySetSlow):
(JSC::JSObject::putInlineSlow):
(JSC::JSObject::setPrototypeWithCycleCheck):
(JSC::callToPrimitiveFunction):
(JSC::JSObject::ordinaryToPrimitive const):
(JSC::JSObject::defaultHasInstance):
(JSC::JSObject::defineOwnIndexedProperty):
(JSC::JSObject::putByIndexBeyondVectorLengthWithArrayStorage):
(JSC::JSObject::putDirectIndexBeyondVectorLengthWithArrayStorage):
(JSC::validateAndApplyPropertyDescriptor):

  • runtime/JSObject.h:
  • runtime/JSObjectInlines.h:

(JSC::JSObject::putInlineForJSObject):

  • runtime/JSPromiseConstructor.cpp:

(JSC::JSPromiseConstructor::finishCreation):

  • runtime/JSSet.cpp:

(JSC::JSSet::toStringName):

  • runtime/JSSymbolTableObject.h:

(JSC::symbolTablePut):

  • runtime/JSTypedArrayViewConstructor.cpp:

(JSC::constructTypedArrayView):

  • runtime/JSTypedArrayViewPrototype.cpp:

(JSC::typedArrayViewPrivateFuncLength):
(JSC::typedArrayViewProtoFuncSet):
(JSC::typedArrayViewProtoFuncCopyWithin):
(JSC::typedArrayViewProtoFuncLastIndexOf):
(JSC::typedArrayViewProtoFuncIndexOf):
(JSC::typedArrayViewProtoFuncJoin):
(JSC::typedArrayViewProtoGetterFuncBuffer):
(JSC::typedArrayViewProtoGetterFuncLength):
(JSC::typedArrayViewProtoGetterFuncByteLength):
(JSC::typedArrayViewProtoGetterFuncByteOffset):
(JSC::typedArrayViewProtoFuncReverse):
(JSC::typedArrayViewPrivateFuncSubarrayCreate):
(JSC::typedArrayViewProtoFuncSlice):
(JSC::JSTypedArrayViewPrototype::finishCreation):

  • runtime/JSWeakMap.cpp:

(JSC::JSWeakMap::toStringName):

  • runtime/JSWeakSet.cpp:

(JSC::JSWeakSet::toStringName):

  • runtime/LiteralParser.cpp:

(JSC::LiteralParser<CharType>::Lexer::lex):
(JSC::LiteralParser<CharType>::Lexer::lexStringSlow):
(JSC::LiteralParser<CharType>::Lexer::lexNumber):
(JSC::LiteralParser<CharType>::parse):

  • runtime/LiteralParser.h:

(JSC::LiteralParser::getErrorMessage):

  • runtime/Lookup.cpp:

(JSC::reifyStaticAccessor):

  • runtime/Lookup.h:

(JSC::putEntry):

  • runtime/MapPrototype.cpp:

(JSC::getMap):

  • runtime/NullSetterFunction.cpp:

(JSC::NullSetterFunctionInternal::callReturnUndefined):

  • runtime/NumberPrototype.cpp:

(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::extractToStringRadixArgument):

  • runtime/ObjectConstructor.cpp:

(JSC::objectConstructorSetPrototypeOf):
(JSC::objectConstructorAssign):
(JSC::objectConstructorValues):
(JSC::toPropertyDescriptor):
(JSC::objectConstructorDefineProperty):
(JSC::objectConstructorDefineProperties):
(JSC::objectConstructorCreate):
(JSC::objectConstructorSeal):
(JSC::objectConstructorFreeze):

  • runtime/ObjectPrototype.cpp:

(JSC::objectProtoFuncDefineGetter):
(JSC::objectProtoFuncDefineSetter):

  • runtime/Operations.cpp:

(JSC::jsAddSlowCase):

  • runtime/Operations.h:

(JSC::jsSub):
(JSC::jsMul):

  • runtime/ProgramExecutable.cpp:

(JSC::ProgramExecutable::initializeGlobalProperties):

  • runtime/ProxyConstructor.cpp:

(JSC::makeRevocableProxy):
(JSC::proxyRevocableConstructorThrowError):
(JSC::ProxyConstructor::finishCreation):
(JSC::constructProxyObject):

  • runtime/ProxyObject.cpp:

(JSC::ProxyObject::toStringName):
(JSC::ProxyObject::finishCreation):
(JSC::performProxyGet):
(JSC::ProxyObject::performInternalMethodGetOwnProperty):
(JSC::ProxyObject::performHasProperty):
(JSC::ProxyObject::performPut):
(JSC::performProxyCall):
(JSC::performProxyConstruct):
(JSC::ProxyObject::performDelete):
(JSC::ProxyObject::performPreventExtensions):
(JSC::ProxyObject::performIsExtensible):
(JSC::ProxyObject::performDefineOwnProperty):
(JSC::ProxyObject::performGetOwnPropertyNames):
(JSC::ProxyObject::performSetPrototype):
(JSC::ProxyObject::performGetPrototype):

  • runtime/ReflectObject.cpp:

(JSC::reflectObjectConstruct):
(JSC::reflectObjectDefineProperty):
(JSC::reflectObjectGet):
(JSC::reflectObjectGetOwnPropertyDescriptor):
(JSC::reflectObjectGetPrototypeOf):
(JSC::reflectObjectIsExtensible):
(JSC::reflectObjectOwnKeys):
(JSC::reflectObjectPreventExtensions):
(JSC::reflectObjectSet):
(JSC::reflectObjectSetPrototypeOf):

  • runtime/RegExpConstructor.cpp:

(JSC::RegExpConstructor::finishCreation):
(JSC::toFlags):

  • runtime/RegExpObject.cpp:

(JSC::RegExpObject::defineOwnProperty):

  • runtime/RegExpObject.h:
  • runtime/RegExpPrototype.cpp:

(JSC::regExpProtoFuncCompile):
(JSC::regExpProtoGetterGlobal):
(JSC::regExpProtoGetterIgnoreCase):
(JSC::regExpProtoGetterMultiline):
(JSC::regExpProtoGetterDotAll):
(JSC::regExpProtoGetterSticky):
(JSC::regExpProtoGetterUnicode):
(JSC::regExpProtoGetterFlags):
(JSC::regExpProtoGetterSourceInternal):
(JSC::regExpProtoGetterSource):

  • runtime/RuntimeType.cpp:

(JSC::runtimeTypeAsString):

  • runtime/SamplingProfiler.cpp:

(JSC::SamplingProfiler::StackFrame::displayName):
(JSC::SamplingProfiler::StackFrame::displayNameForJSONTests):

  • runtime/ScriptExecutable.cpp:

(JSC::ScriptExecutable::prepareForExecutionImpl):

  • runtime/SetPrototype.cpp:

(JSC::getSet):

  • runtime/SparseArrayValueMap.cpp:

(JSC::SparseArrayValueMap::putEntry):
(JSC::SparseArrayValueMap::putDirect):
(JSC::SparseArrayEntry::put):

  • runtime/StackFrame.cpp:

(JSC::StackFrame::sourceURL const):
(JSC::StackFrame::functionName const):

  • runtime/StringConstructor.cpp:

(JSC::stringFromCodePoint):

  • runtime/StringObject.cpp:

(JSC::StringObject::put):
(JSC::StringObject::putByIndex):

  • runtime/StringPrototype.cpp:

(JSC::StringPrototype::finishCreation):
(JSC::toLocaleCase):
(JSC::stringProtoFuncNormalize):

  • runtime/Symbol.cpp:

(JSC::Symbol::toNumber const):

  • runtime/SymbolConstructor.cpp:

(JSC::symbolConstructorKeyFor):

  • runtime/SymbolObject.cpp:

(JSC::SymbolObject::toStringName):

  • runtime/SymbolPrototype.cpp:

(JSC::SymbolPrototype::finishCreation):

  • runtime/TypeSet.cpp:

(JSC::TypeSet::dumpTypes const):
(JSC::TypeSet::displayName const):
(JSC::StructureShape::leastCommonAncestor):

  • runtime/TypeSet.h:

(JSC::StructureShape::setConstructorName):

  • runtime/VM.cpp:

(JSC::VM::dumpTypeProfilerData):

  • runtime/WeakMapPrototype.cpp:

(JSC::getWeakMap):
(JSC::protoFuncWeakMapSet):

  • runtime/WeakSetPrototype.cpp:

(JSC::getWeakSet):
(JSC::protoFuncWeakSetAdd):

  • tools/JSDollarVM.cpp:

(WTF::DOMJITGetterComplex::DOMJITAttribute::slowCall):
(WTF::DOMJITGetterComplex::customGetter):
(JSC::functionSetImpureGetterDelegate):
(JSC::functionCreateElement):
(JSC::functionGetHiddenValue):
(JSC::functionSetHiddenValue):
(JSC::functionFindTypeForExpression):
(JSC::functionReturnTypeFor):
(JSC::functionLoadGetterFromGetterSetter):

  • wasm/WasmB3IRGenerator.cpp:

(JSC::Wasm::B3IRGenerator::fail const):

  • wasm/WasmIndexOrName.cpp:

(JSC::Wasm::makeString):

  • wasm/WasmParser.h:

(JSC::Wasm::FailureHelper::makeString):
(JSC::Wasm::Parser::fail const):

  • wasm/WasmPlan.cpp:

(JSC::Wasm::Plan::tryRemoveContextAndCancelIfLast):

  • wasm/WasmValidate.cpp:

(JSC::Wasm::Validate::fail const):

  • wasm/js/JSWebAssemblyCodeBlock.cpp:

(JSC::JSWebAssemblyCodeBlock::JSWebAssemblyCodeBlock):

  • wasm/js/JSWebAssemblyHelpers.h:

(JSC::toNonWrappingUint32):
(JSC::getWasmBufferFromValue):

  • wasm/js/JSWebAssemblyInstance.cpp:

(JSC::JSWebAssemblyInstance::create):

  • wasm/js/JSWebAssemblyMemory.cpp:

(JSC::JSWebAssemblyMemory::grow):

  • wasm/js/WasmToJS.cpp:

(JSC::Wasm::handleBadI64Use):

  • wasm/js/WebAssemblyCompileErrorConstructor.cpp:

(JSC::WebAssemblyCompileErrorConstructor::finishCreation):

  • wasm/js/WebAssemblyInstanceConstructor.cpp:

(JSC::constructJSWebAssemblyInstance):
(JSC::WebAssemblyInstanceConstructor::finishCreation):

  • wasm/js/WebAssemblyInstancePrototype.cpp:

(JSC::getInstance):

  • wasm/js/WebAssemblyLinkErrorConstructor.cpp:

(JSC::WebAssemblyLinkErrorConstructor::finishCreation):

  • wasm/js/WebAssemblyMemoryConstructor.cpp:

(JSC::constructJSWebAssemblyMemory):
(JSC::WebAssemblyMemoryConstructor::finishCreation):

  • wasm/js/WebAssemblyMemoryPrototype.cpp:

(JSC::getMemory):

  • wasm/js/WebAssemblyModuleConstructor.cpp:

(JSC::webAssemblyModuleCustomSections):
(JSC::webAssemblyModuleImports):
(JSC::webAssemblyModuleExports):
(JSC::WebAssemblyModuleConstructor::finishCreation):

  • wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::link):
(JSC::dataSegmentFail):
(JSC::WebAssemblyModuleRecord::evaluate):

  • wasm/js/WebAssemblyPrototype.cpp:

(JSC::resolve):
(JSC::webAssemblyInstantiateFunc):
(JSC::webAssemblyInstantiateStreamingInternal):

  • wasm/js/WebAssemblyRuntimeErrorConstructor.cpp:

(JSC::WebAssemblyRuntimeErrorConstructor::finishCreation):

  • wasm/js/WebAssemblyTableConstructor.cpp:

(JSC::constructJSWebAssemblyTable):
(JSC::WebAssemblyTableConstructor::finishCreation):

  • wasm/js/WebAssemblyTablePrototype.cpp:

(JSC::getTable):
(JSC::webAssemblyTableProtoFuncGrow):
(JSC::webAssemblyTableProtoFuncGet):
(JSC::webAssemblyTableProtoFuncSet):

Source/WebCore:

No behavior change.

  • Modules/applicationmanifest/ApplicationManifestParser.cpp:

(WebCore::ApplicationManifestParser::parseManifest):
(WebCore::ApplicationManifestParser::logManifestPropertyNotAString):
(WebCore::ApplicationManifestParser::logManifestPropertyInvalidURL):
(WebCore::ApplicationManifestParser::logDeveloperWarning):
(WebCore::ApplicationManifestParser::parseStartURL):
(WebCore::ApplicationManifestParser::parseDisplay):
(WebCore::ApplicationManifestParser::parseName):
(WebCore::ApplicationManifestParser::parseDescription):
(WebCore::ApplicationManifestParser::parseShortName):
(WebCore::ApplicationManifestParser::parseScope):

  • Modules/beacon/NavigatorBeacon.cpp:

(WebCore::NavigatorBeacon::logError):
(WebCore::NavigatorBeacon::sendBeacon):

  • Modules/cache/DOMCache.cpp:

(WebCore::DOMCache::requestFromInfo):
(WebCore::DOMCache::addAll):
(WebCore::DOMCache::put):

  • Modules/cache/DOMCacheEngine.cpp:

(WebCore::DOMCacheEngine::errorToException):

  • Modules/credentialmanagement/BasicCredential.cpp:

(WebCore::BasicCredential::type const):

  • Modules/credentialmanagement/CredentialsContainer.cpp:

(WebCore::CredentialsContainer::get):
(WebCore::CredentialsContainer::store):
(WebCore::CredentialsContainer::isCreate):
(WebCore::CredentialsContainer::preventSilentAccess const):

  • Modules/entriesapi/DOMFileSystem.cpp:

(WebCore::DOMFileSystem::root):
(WebCore::validatePathIsExpectedType):
(WebCore::resolveRelativeVirtualPath):
(WebCore::DOMFileSystem::getEntry):

  • Modules/entriesapi/FileSystemDirectoryEntry.cpp:

(WebCore::FileSystemDirectoryEntry::getEntry):

  • Modules/entriesapi/FileSystemDirectoryReader.cpp:

(WebCore::FileSystemDirectoryReader::readEntries):

  • Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::consumeAsStream):

  • Modules/fetch/FetchBodyConsumer.cpp:

(WebCore::FetchBodyConsumer::loadingFailed):

  • Modules/fetch/FetchBodyOwner.cpp:

(WebCore::FetchBodyOwner::arrayBuffer):
(WebCore::FetchBodyOwner::blob):
(WebCore::FetchBodyOwner::consumeOnceLoadingFinished):
(WebCore::FetchBodyOwner::formData):
(WebCore::FetchBodyOwner::json):
(WebCore::FetchBodyOwner::text):
(WebCore::FetchBodyOwner::blobLoadingFailed):
(WebCore::FetchBodyOwner::consumeBodyAsStream):

  • Modules/fetch/FetchHeaders.cpp:

(WebCore::canWriteHeader):

  • Modules/fetch/FetchLoader.cpp:

(WebCore::FetchLoader::startLoadingBlobURL):
(WebCore::FetchLoader::start):

  • Modules/fetch/FetchRequest.cpp:

(WebCore::setMethod):
(WebCore::computeReferrer):
(WebCore::buildOptions):
(WebCore::FetchRequest::initializeOptions):
(WebCore::FetchRequest::initializeWith):
(WebCore::FetchRequest::setBody):
(WebCore::FetchRequest::referrer const):
(WebCore::FetchRequest::clone):

  • Modules/fetch/FetchResponse.cpp:

(WebCore::FetchResponse::create):
(WebCore::FetchResponse::redirect):
(WebCore::FetchResponse::clone):
(WebCore::FetchResponse::BodyLoader::didFail):

  • Modules/fetch/FetchResponse.h:
  • Modules/geolocation/GeoNotifier.cpp:

(WebCore::GeoNotifier::timerFired):

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::startRequest):
(WebCore::Geolocation::requestUsesCachedPosition):
(WebCore::Geolocation::makeCachedPositionCallbacks):
(WebCore::Geolocation::setIsAllowed):
(WebCore::Geolocation::cancelRequests):
(WebCore::Geolocation::handlePendingPermissionNotifiers):

  • Modules/indexeddb/IDBCursor.cpp:

(WebCore::IDBCursor::update):
(WebCore::IDBCursor::advance):
(WebCore::IDBCursor::continuePrimaryKey):
(WebCore::IDBCursor::continueFunction):
(WebCore::IDBCursor::deleteFunction):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::transaction):
(WebCore::IDBDatabase::deleteObjectStore):

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::open):
(WebCore::IDBFactory::openInternal):
(WebCore::IDBFactory::deleteDatabase):
(WebCore::IDBFactory::cmp):

  • Modules/indexeddb/IDBIndex.cpp:

(WebCore::IDBIndex::setName):
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::count):
(WebCore::IDBIndex::doCount):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::doGet):
(WebCore::IDBIndex::getKey):
(WebCore::IDBIndex::doGetKey):
(WebCore::IDBIndex::getAll):
(WebCore::IDBIndex::getAllKeys):

  • Modules/indexeddb/IDBKeyData.cpp:

(WebCore::IDBKeyData::loggingString const):

  • Modules/indexeddb/IDBKeyRangeData.cpp:

(WebCore::IDBKeyRangeData::loggingString const):

  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::setName):
(WebCore::IDBObjectStore::openCursor):
(WebCore::IDBObjectStore::openKeyCursor):
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::getKey):
(WebCore::IDBObjectStore::putOrAdd):
(WebCore::IDBObjectStore::doDelete):
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::index):
(WebCore::IDBObjectStore::deleteIndex):
(WebCore::IDBObjectStore::count):
(WebCore::IDBObjectStore::doCount):
(WebCore::IDBObjectStore::getAll):
(WebCore::IDBObjectStore::getAllKeys):

  • Modules/indexeddb/IDBRequest.cpp:

(WebCore::IDBRequest::result const):
(WebCore:: const):
(WebCore::IDBRequest::uncaughtExceptionInEventHandler):

  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::objectStore):
(WebCore::IDBTransaction::abort):
(WebCore::IDBTransaction::putOrAddOnServer):

  • Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::performGetAllDatabaseNames):

  • Modules/indexeddb/server/MemoryIDBBackingStore.cpp:

(WebCore::IDBServer::MemoryIDBBackingStore::deleteRange):
(WebCore::IDBServer::MemoryIDBBackingStore::addRecord):
(WebCore::IDBServer::MemoryIDBBackingStore::getRecord):
(WebCore::IDBServer::MemoryIDBBackingStore::getAllRecords):
(WebCore::IDBServer::MemoryIDBBackingStore::getIndexRecord):
(WebCore::IDBServer::MemoryIDBBackingStore::getCount):
(WebCore::IDBServer::MemoryIDBBackingStore::openCursor):
(WebCore::IDBServer::MemoryIDBBackingStore::iterateCursor):

  • Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::createAndPopulateInitialDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::extractExistingDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::databaseNameFromEncodedFilename):
(WebCore::IDBServer::SQLiteIDBBackingStore::getOrEstablishDatabaseInfo):
(WebCore::IDBServer::SQLiteIDBBackingStore::beginTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::abortTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::commitTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::renameObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::clearObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedHasIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::renameIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::keyExistsInObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteUnusedBlobFileRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteRange):
(WebCore::IDBServer::SQLiteIDBBackingStore::updateAllIndexesForAddRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getBlobRecordsForObjectStoreRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::getAllObjectStoreRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::getAllIndexRecords):
(WebCore::IDBServer::SQLiteIDBBackingStore::getIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetIndexRecordForOneKey):
(WebCore::IDBServer::SQLiteIDBBackingStore::getCount):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedGetKeyGeneratorValue):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedSetKeyGeneratorValue):
(WebCore::IDBServer::SQLiteIDBBackingStore::generateKeyNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::revertGeneratedKeyNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::maybeUpdateKeyGeneratorNumber):
(WebCore::IDBServer::SQLiteIDBBackingStore::openCursor):
(WebCore::IDBServer::SQLiteIDBBackingStore::iterateCursor):
(WebCore::IDBServer::SQLiteIDBBackingStore::deleteBackingStore):

  • Modules/indexeddb/server/SQLiteIDBTransaction.cpp:

(WebCore::IDBServer::SQLiteIDBTransaction::begin):
(WebCore::IDBServer::SQLiteIDBTransaction::commit):
(WebCore::IDBServer::SQLiteIDBTransaction::abort):

  • Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::deleteObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::renameObjectStore):
(WebCore::IDBServer::UniqueIDBDatabase::deleteIndex):
(WebCore::IDBServer::UniqueIDBDatabase::renameIndex):
(WebCore::IDBServer::UniqueIDBDatabase::performPutOrAdd):
(WebCore::IDBServer::UniqueIDBDatabase::commitTransaction):
(WebCore::IDBServer::UniqueIDBDatabase::abortTransaction):

  • Modules/indexeddb/shared/IDBError.h:

(WebCore::IDBError::userDeleteError):

  • Modules/indexeddb/shared/IDBTransactionInfo.cpp:

(WebCore::IDBTransactionInfo::loggingString const):

  • Modules/mediastream/CanvasCaptureMediaStreamTrack.cpp:

(WebCore::CanvasCaptureMediaStreamTrack::Source::canvasChanged):

  • Modules/mediastream/PeerConnectionBackend.cpp:

(WebCore::PeerConnectionBackend::addIceCandidate):

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::deny):

  • Modules/mediastream/libwebrtc/LibWebRTCMediaEndpoint.cpp:

(WebCore::LibWebRTCMediaEndpoint::doSetLocalDescription):

  • Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:

(WebCore::LibWebRTCPeerConnectionBackend::doAddIceCandidate):

  • Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::checkAndCanonicalizeTotal):
(WebCore::PaymentRequest::create):

  • Modules/quota/DOMWindowQuota.cpp:

(WebCore::DOMWindowQuota::webkitStorageInfo const):

  • Modules/webaudio/AudioBufferSourceNode.cpp:

(WebCore::AudioBufferSourceNode::looping):
(WebCore::AudioBufferSourceNode::setLooping):

  • Modules/webaudio/AudioNode.cpp:

(WebCore::AudioNode::channelCountMode):
(WebCore::AudioNode::channelInterpretation):

  • Modules/webaudio/MediaStreamAudioSource.cpp:

(WebCore::MediaStreamAudioSource::MediaStreamAudioSource):

  • Modules/webauthn/AuthenticatorManager.cpp:

(WebCore::AuthenticatorManagerInternal::produceClientDataJson):
(WebCore::AuthenticatorManagerInternal::initTimeoutTimer):
(WebCore::AuthenticatorManager::create const):
(WebCore::AuthenticatorManager::discoverFromExternalSource const):
(WebCore::AuthenticatorManager::isUserVerifyingPlatformAuthenticatorAvailable const):

  • Modules/webauthn/cocoa/LocalAuthenticator.mm:

(WebCore::LocalAuthenticator::makeCredential):
(WebCore::LocalAuthenticator::getAssertion):

  • Modules/webdatabase/DatabaseTracker.cpp:

(WebCore::DatabaseTracker::usage):

  • Modules/websockets/WebSocket.cpp:

(WebCore::WebSocket::connect):
(WebCore::WebSocket::close):
(WebCore::WebSocket::binaryType const):

  • Modules/websockets/WebSocketHandshake.cpp:

(WebCore::WebSocketHandshake::readStatusLine):
(WebCore::WebSocketHandshake::readHTTPHeaders):
(WebCore::WebSocketHandshake::checkResponseHeaders):

  • Modules/webvr/VRDisplay.cpp:

(WebCore::VRDisplay::requestPresent):
(WebCore::VRDisplay::exitPresent):

  • accessibility/AccessibilityObject.cpp:

(WebCore::AccessibilityObject::defaultLiveRegionStatusForRole):
(WebCore::AccessibilityObject::invalidStatus const):

  • accessibility/AccessibilityRenderObject.cpp:

(WebCore::AccessibilityRenderObject::textUnderElement const):

  • bindings/js/JSCustomElementInterface.cpp:

(WebCore::constructCustomElementSynchronously):

  • bindings/js/JSCustomElementRegistryCustom.cpp:

(WebCore::getCustomElementCallback):
(WebCore::validateCustomElementNameAndThrowIfNeeded):
(WebCore::JSCustomElementRegistry::define):

  • bindings/js/JSCustomXPathNSResolver.cpp:

(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):

  • bindings/js/JSDOMConstructorBase.cpp:

(WebCore::callThrowTypeError):

  • bindings/js/JSDOMConstructorBase.h:

(WebCore::JSDOMConstructorBase::className):

  • bindings/js/JSDOMConstructorNotConstructable.h:

(WebCore::JSDOMConstructorNotConstructable::callThrowTypeError):

  • bindings/js/JSDOMExceptionHandling.cpp:

(WebCore::createDOMException):
(WebCore::throwSequenceTypeError):
(WebCore::throwNonFiniteTypeError):

  • bindings/js/JSDOMIterator.h:

(WebCore::iteratorForEach):
(WebCore::IteratorTraits>::next):

  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::isResponseCorrect):
(WebCore::handleResponseOnStreamingAction):
(WebCore::JSDOMWindowBase::compileStreaming):
(WebCore::JSDOMWindowBase::instantiateStreaming):

  • bindings/js/JSDOMWindowCustom.cpp:

(WebCore::JSDOMWindow::preventExtensions):
(WebCore::JSDOMWindow::toStringName):

  • bindings/js/JSHTMLElementCustom.cpp:

(WebCore::constructJSHTMLElement):

  • bindings/js/JSLocationCustom.cpp:

(WebCore::JSLocation::preventExtensions):
(WebCore::JSLocation::toStringName):

  • bindings/js/JSReadableStreamPrivateConstructors.cpp:

(WebCore::constructJSReadableStreamDefaultController):
(WebCore::constructJSReadableByteStreamController):
(WebCore::constructJSReadableStreamBYOBRequest):

  • bindings/js/JSRemoteDOMWindowCustom.cpp:

(WebCore::JSRemoteDOMWindow::preventExtensions):
(WebCore::JSRemoteDOMWindow::toStringName):

  • bindings/js/ReadableStreamDefaultController.cpp:

(WebCore::ReadableStreamDefaultController::invoke):

  • bindings/js/ScriptModuleLoader.cpp:

(WebCore::resolveModuleSpecifier):
(WebCore::ScriptModuleLoader::resolve):
(WebCore::ScriptModuleLoader::fetch):
(WebCore::ScriptModuleLoader::evaluate):
(WebCore::ScriptModuleLoader::importModule):
(WebCore::ScriptModuleLoader::notifyFinished):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::maybeThrowExceptionIfSerializationFailed):

  • bindings/js/WorkerScriptController.cpp:

(WebCore::WorkerScriptController::evaluate):

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateDefaultValue):
(GenerateConstructorHelperMethods):
(GenerateCallTracer):

  • bindings/scripts/test/JS/JSInterfaceName.cpp:

(WebCore::JSInterfaceNameConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSMapLike.cpp:

(WebCore::JSMapLikeConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSReadOnlyMapLike.cpp:

(WebCore::JSReadOnlyMapLikeConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestActiveDOMObject.cpp:

(WebCore::JSTestActiveDOMObjectConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestCEReactions.cpp:

(WebCore::JSTestCEReactionsConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestCEReactionsStringifier.cpp:

(WebCore::JSTestCEReactionsStringifierConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestCallTracer.cpp:

(WebCore::JSTestCallTracerConstructor::initializeProperties):
(WebCore::jsTestCallTracerTestAttributeInterfaceGetter):
(WebCore::setJSTestCallTracerTestAttributeInterfaceSetter):
(WebCore::jsTestCallTracerTestAttributeSpecifiedGetter):
(WebCore::setJSTestCallTracerTestAttributeSpecifiedSetter):
(WebCore::jsTestCallTracerTestAttributeWithVariantGetter):
(WebCore::setJSTestCallTracerTestAttributeWithVariantSetter):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationInterfaceBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationSpecifiedBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithArgumentsBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithNullableVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithOptionalVariantArgumentBody):
(WebCore::jsTestCallTracerPrototypeFunctionTestOperationWithDefaultVariantArgumentBody):

  • bindings/scripts/test/JS/JSTestCallbackInterface.cpp:

(WebCore::JSTestCallbackInterfaceConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestClassWithJSBuiltinConstructor.cpp:

(WebCore::JSTestClassWithJSBuiltinConstructorConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestCustomConstructorWithNoInterfaceObject.cpp:

(WebCore::JSTestCustomConstructorWithNoInterfaceObjectConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestDOMJIT.cpp:

(WebCore::JSTestDOMJITConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:

(WebCore::JSTestEnabledBySettingConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestEventConstructor.cpp:

(WebCore::JSTestEventConstructorConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestEventTarget.cpp:

(WebCore::JSTestEventTargetConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestException.cpp:

(WebCore::JSTestExceptionConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachableConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestGlobalObject.cpp:

(WebCore::JSTestGlobalObjectConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestIndexedSetterNoIdentifier.cpp:

(WebCore::JSTestIndexedSetterNoIdentifierConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestIndexedSetterThrowingException.cpp:

(WebCore::JSTestIndexedSetterThrowingExceptionConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestIndexedSetterWithIdentifier.cpp:

(WebCore::JSTestIndexedSetterWithIdentifierConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestInterface.cpp:

(WebCore::JSTestInterfaceConstructor::construct):
(WebCore::JSTestInterfaceConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestInterfaceLeadingUnderscore.cpp:

(WebCore::JSTestInterfaceLeadingUnderscoreConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestIterable.cpp:

(WebCore::JSTestIterableConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestJSBuiltinConstructor.cpp:

(WebCore::JSTestJSBuiltinConstructorConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:

(WebCore::JSTestMediaQueryListListenerConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterNoIdentifier.cpp:

(WebCore::JSTestNamedAndIndexedSetterNoIdentifierConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterThrowingException.cpp:

(WebCore::JSTestNamedAndIndexedSetterThrowingExceptionConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestNamedAndIndexedSetterWithIdentifier.cpp:

(WebCore::JSTestNamedAndIndexedSetterWithIdentifierConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestNamedConstructor.cpp:

(WebCore::JSTestNamedConstructorConstructor::initializeProperties):
(WebCore::JSTestNamedConstructorNamedConstructor::construct):
(WebCore::JSTestNamedConstructorNamedConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestNamedDeleterNoIdentifier.cpp:

(WebCore::JSTestNamedDeleterNoIdentifierConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestNamedDeleterThrowingException.cpp:

(WebCore::JSTestNamedDeleterThrowingExceptionConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestNamedDeleterWithIdentifier.cpp:

(WebCore::JSTestNamedDeleterWithIdentifierConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestNamedDeleterWithIndexedGetter.cpp:

(WebCore::JSTestNamedDeleterWithIndexedGetterConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestNamedGetterCallWith.cpp:

(WebCore::JSTestNamedGetterCallWithConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestNamedGetterNoIdentifier.cpp:

(WebCore::JSTestNamedGetterNoIdentifierConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestNamedGetterWithIdentifier.cpp:

(WebCore::JSTestNamedGetterWithIdentifierConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestNamedSetterNoIdentifier.cpp:

(WebCore::JSTestNamedSetterNoIdentifierConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestNamedSetterThrowingException.cpp:

(WebCore::JSTestNamedSetterThrowingExceptionConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestNamedSetterWithIdentifier.cpp:

(WebCore::JSTestNamedSetterWithIdentifierConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetter.cpp:

(WebCore::JSTestNamedSetterWithIndexedGetterConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestNamedSetterWithIndexedGetterAndSetter.cpp:

(WebCore::JSTestNamedSetterWithIndexedGetterAndSetterConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestNamedSetterWithOverrideBuiltins.cpp:

(WebCore::JSTestNamedSetterWithOverrideBuiltinsConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestNamedSetterWithUnforgableProperties.cpp:

(WebCore::JSTestNamedSetterWithUnforgablePropertiesConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltins.cpp:

(WebCore::JSTestNamedSetterWithUnforgablePropertiesAndOverrideBuiltinsConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodeConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::convertDictionary<TestObj::Dictionary>):
(WebCore::JSTestObjConstructor::initializeProperties):
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringAndDefaultValueBody):

  • bindings/scripts/test/JS/JSTestOverloadedConstructors.cpp:

(WebCore::JSTestOverloadedConstructorsConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestOverloadedConstructorsWithSequence.cpp:

(WebCore::JSTestOverloadedConstructorsWithSequenceConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestOverrideBuiltins.cpp:

(WebCore::JSTestOverrideBuiltinsConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestPluginInterface.cpp:

(WebCore::JSTestPluginInterfaceConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestPromiseRejectionEvent.cpp:

(WebCore::JSTestPromiseRejectionEventConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestSerialization.cpp:

(WebCore::JSTestSerializationConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestSerializationIndirectInheritance.cpp:

(WebCore::JSTestSerializationIndirectInheritanceConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestSerializationInherit.cpp:

(WebCore::JSTestSerializationInheritConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestSerializationInheritFinal.cpp:

(WebCore::JSTestSerializationInheritFinalConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

(WebCore::JSTestSerializedScriptValueInterfaceConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestStringifier.cpp:

(WebCore::JSTestStringifierConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestStringifierAnonymousOperation.cpp:

(WebCore::JSTestStringifierAnonymousOperationConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestStringifierNamedOperation.cpp:

(WebCore::JSTestStringifierNamedOperationConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestStringifierOperationImplementedAs.cpp:

(WebCore::JSTestStringifierOperationImplementedAsConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestStringifierOperationNamedToString.cpp:

(WebCore::JSTestStringifierOperationNamedToStringConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestStringifierReadOnlyAttribute.cpp:

(WebCore::JSTestStringifierReadOnlyAttributeConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestStringifierReadWriteAttribute.cpp:

(WebCore::JSTestStringifierReadWriteAttributeConstructor::initializeProperties):

  • bindings/scripts/test/JS/JSTestTypedefs.cpp:

(WebCore::JSTestTypedefsConstructor::initializeProperties):

  • bridge/c/c_instance.cpp:

(JSC::Bindings::CInstance::invokeMethod):
(JSC::Bindings::CInstance::invokeDefaultMethod):
(JSC::Bindings::CInstance::invokeConstruct):
(JSC::Bindings::CInstance::stringValue const):
(JSC::Bindings::CInstance::toJSPrimitive const):

  • bridge/objc/objc_instance.mm:

(ObjcInstance::invokeMethod):

  • bridge/objc/objc_runtime.mm:

(JSC::Bindings::ObjcArray::setValueAt const):

  • contentextensions/ContentExtensionsBackend.cpp:

(WebCore::ContentExtensions::ContentExtensionsBackend::processContentExtensionRulesForLoad):

  • crypto/SubtleCrypto.cpp:

(WebCore::rejectWithException):
(WebCore::SubtleCrypto::encrypt):
(WebCore::SubtleCrypto::decrypt):
(WebCore::SubtleCrypto::sign):
(WebCore::SubtleCrypto::verify):
(WebCore::SubtleCrypto::deriveKey):
(WebCore::SubtleCrypto::deriveBits):
(WebCore::SubtleCrypto::exportKey):
(WebCore::SubtleCrypto::wrapKey):
(WebCore::SubtleCrypto::unwrapKey):

  • crypto/keys/CryptoKeyEC.cpp:

(WebCore::CryptoKeyEC::algorithm const):

  • css/CSSInheritedValue.cpp:

(WebCore::CSSInheritedValue::customCSSText const):

  • css/CSSInitialValue.cpp:

(WebCore::CSSInitialValue::customCSSText const):

  • css/CSSKeyframesRule.cpp:

(WebCore::CSSKeyframesRule::insertRule):

  • css/CSSRevertValue.cpp:

(WebCore::CSSRevertValue::customCSSText const):

  • css/CSSStyleSheet.h:
  • css/CSSUnsetValue.cpp:

(WebCore::CSSUnsetValue::customCSSText const):

  • css/CSSValueList.cpp:

(WebCore::CSSValueList::customCSSText const):

  • css/DOMMatrixReadOnly.cpp:

(WebCore::DOMMatrixReadOnly::validateAndFixup):
(WebCore::DOMMatrixReadOnly::toFloat32Array const):
(WebCore::DOMMatrixReadOnly::toFloat64Array const):
(WebCore::DOMMatrixReadOnly::toString const):

  • css/DeprecatedCSSOMValueList.cpp:

(WebCore::DeprecatedCSSOMValueList::cssText const):

  • css/FontFace.cpp:

(WebCore::FontFace::create):
(WebCore::FontFace::unicodeRange const):
(WebCore::FontFace::featureSettings const):

  • css/MediaQuery.cpp:

(WebCore::MediaQuery::serialize const):

  • css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::getPropertyPriority):

  • css/WebKitCSSMatrix.cpp:

(WebCore::WebKitCSSMatrix::toString const):

  • css/parser/MediaQueryParser.cpp:

(WebCore::MediaQueryParser::commitMediaQuery):

  • dom/CDATASection.cpp:

(WebCore::CDATASection::nodeName const):

  • dom/Comment.cpp:

(WebCore::Comment::nodeName const):

  • dom/DOMException.cpp:

(WebCore::DOMException::description const):
(WebCore::DOMException::create):

  • dom/DOMException.h:

(WebCore::DOMException::name):
(WebCore::DOMException::message):

  • dom/DOMImplementation.cpp:

(WebCore::DOMImplementation::createHTMLDocument):

  • dom/DataTransfer.cpp:

(WebCore::DataTransfer::DataTransfer):
(WebCore::DataTransfer::types const):
(WebCore::DataTransfer::createForInputEvent):
(WebCore::DataTransfer::dropEffect const):
(WebCore::DataTransfer::effectAllowed const):

  • dom/DataTransferItem.cpp:

(WebCore::DataTransferItem::kind const):

  • dom/Document.cpp:

(WebCore::Document::suggestedMIMEType const):
(WebCore::Document::contentType const):
(WebCore::Document::nodeName const):
(WebCore::Document::writeln):
(WebCore::Document::canNavigate):
(WebCore::Document::designMode const):
(WebCore::Document::requestFullScreenForElement):

  • dom/DocumentFragment.cpp:

(WebCore::DocumentFragment::nodeName const):

  • dom/InlineStyleSheetOwner.cpp:

(WebCore::InlineStyleSheetOwner::createSheet):

  • dom/MouseEvent.cpp:

(WebCore::MouseEvent::initMouseEventQuirk):

  • dom/ScriptElement.cpp:

(WebCore::ScriptElement::requestModuleScript):

  • dom/ScriptElementCachedScriptFetcher.cpp:

(WebCore::ScriptElementCachedScriptFetcher::requestModuleScript const):

  • dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::dispatchErrorEvent):

  • dom/ScriptedAnimationController.cpp:

(WebCore::throttlingReasonsToString):

  • dom/Text.cpp:

(WebCore::Text::nodeName const):

  • dom/TextEncoder.cpp:

(WebCore::TextEncoder::encoding const):

  • dom/Traversal.cpp:

(WebCore::NodeIteratorBase::acceptNode):

  • editing/EditCommand.cpp:

(WebCore::inputTypeNameForEditingAction):

  • editing/Editing.cpp:

(WebCore::createTabSpanElement):

  • editing/Editor.cpp:

(WebCore::createDataTransferForClipboardEvent):

  • editing/EditorCommand.cpp:

(WebCore::executeInsertBacktab):
(WebCore::executeInsertLineBreak):
(WebCore::executeInsertNewline):
(WebCore::executeInsertTab):
(WebCore::executeJustifyCenter):
(WebCore::executeJustifyFull):
(WebCore::executeJustifyLeft):
(WebCore::executeJustifyRight):
(WebCore::executeStrikethrough):
(WebCore::executeSubscript):
(WebCore::executeSuperscript):
(WebCore::executeToggleBold):
(WebCore::executeToggleItalic):
(WebCore::executeUnderline):
(WebCore::executeUnscript):
(WebCore::stateBold):
(WebCore::stateItalic):
(WebCore::stateStrikethrough):
(WebCore::stateSubscript):
(WebCore::stateSuperscript):
(WebCore::stateUnderline):
(WebCore::stateJustifyCenter):
(WebCore::stateJustifyFull):
(WebCore::stateJustifyLeft):
(WebCore::stateJustifyRight):
(WebCore::Editor::Command::value const):

  • editing/SmartReplace.cpp:

(WebCore::getSmartSet):

  • fileapi/FileCocoa.mm:

(WebCore::File::computeNameAndContentTypeForReplacedFile):

  • html/BaseCheckableInputType.cpp:

(WebCore::BaseCheckableInputType::saveFormControlState const):

  • html/BaseChooserOnlyDateAndTimeInputType.cpp:

(WebCore::BaseChooserOnlyDateAndTimeInputType::updateInnerTextValue):

  • html/ColorInputType.cpp:

(WebCore::ColorInputType::fallbackValue const):

  • html/DOMFormData.cpp:

(WebCore::DOMFormData::createFileEntry):

  • html/FTPDirectoryDocument.cpp:

(WebCore::processFilesizeString):
(WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):

  • html/HTMLAnchorElement.cpp:

(WebCore::HTMLAnchorElement::relList const):
(WebCore::HTMLAnchorElement::isSystemPreviewLink const):

  • html/HTMLAppletElement.cpp:

(WebCore::HTMLAppletElement::HTMLAppletElement):
(WebCore::HTMLAppletElement::updateWidget):

  • html/HTMLCanvasElement.cpp:

(WebCore::toEncodingMimeType):
(WebCore::HTMLCanvasElement::toDataURL):
(WebCore::HTMLCanvasElement::captureStream):

  • html/HTMLElement.cpp:

(WebCore::HTMLElement::contentEditable const):

  • html/HTMLFormControlElement.cpp:

(WebCore::shouldAutofocus):

  • html/HTMLHtmlElement.cpp:

(WebCore::HTMLHtmlElement::insertedByParser):

  • html/HTMLKeygenElement.cpp:

(WebCore::HTMLKeygenElement::keytype const):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::canPlayType const):
(WebCore::stringForNetworkState):
(WebCore::HTMLMediaElement::preload const):
(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):

  • html/HTMLObjectElement.cpp:

(WebCore::mapDataParamToSrc):

  • html/HTMLPlugInElement.cpp:

(WebCore::HTMLPlugInElement::setReplacement):

  • html/ImageData.cpp:

(WebCore::ImageData::create):

  • html/ImageDocument.cpp:

(WebCore::ImageDocument::createDocumentStructure):

  • html/ImageInputType.cpp:

(WebCore::ImageInputType::appendFormData const):

  • html/PluginDocument.cpp:

(WebCore::PluginDocumentParser::createDocumentStructure):

  • html/canvas/WebGL2RenderingContext.cpp:

(WebCore::WebGL2RenderingContext::getExtension):
(WebCore::WebGL2RenderingContext::getSupportedExtensions):
(WebCore::WebGL2RenderingContext::getParameter):

  • html/canvas/WebGLCompressedTextureASTC.cpp:

(WebCore::WebGLCompressedTextureASTC::WebGLCompressedTextureASTC):
(WebCore::WebGLCompressedTextureASTC::getSupportedProfiles):
(WebCore::WebGLCompressedTextureASTC::supported):
(WebCore::m_isLDRSupported): Deleted.

  • html/canvas/WebGLRenderingContext.cpp:

(WebCore::WebGLRenderingContext::getExtension):
(WebCore::WebGLRenderingContext::getSupportedExtensions):
(WebCore::WebGLRenderingContext::getParameter):

  • html/canvas/WebGLRenderingContextBase.cpp:

(WebCore::WebGLRenderingContextBase::create):
(WebCore::WebGLRenderingContextBase::enableSupportedExtension):

  • html/canvas/WebGLRenderingContextBase.h:
  • html/canvas/WebGPUEnums.cpp:

(WebCore::web3DCompareFunctionName):

  • html/parser/HTMLParserIdioms.cpp:

(WebCore::parseCORSSettingsAttribute):

  • html/parser/HTMLPreloadScanner.cpp:

(WebCore::TokenPreloadScanner::initiatorFor):

  • html/parser/HTMLResourcePreloader.cpp:

(WebCore::PreloadRequest::resourceRequest):

  • html/parser/HTMLTreeBuilder.cpp:

(WebCore::HTMLTreeBuilder::insertPhoneNumberLink):

  • html/track/DataCue.cpp:

(WebCore::DataCue::toJSONString const):

  • html/track/InbandGenericTextTrack.cpp:

(WebCore::InbandGenericTextTrack::updateCueFromCueData):

  • html/track/TextTrackCue.cpp:

(WebCore::TextTrackCue::toJSON const):

  • html/track/TextTrackCueGeneric.cpp:

(WebCore::TextTrackCueGeneric::toJSONString const):

  • html/track/TrackBase.cpp:

(WebCore::TrackBase::setLanguage):

  • html/track/VTTCue.cpp:

(WebCore::VTTCue::toJSON const):

  • inspector/CommandLineAPIModule.cpp:

(WebCore::CommandLineAPIModule::CommandLineAPIModule):

  • inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::getCanvasContentAsDataURL):
(WebCore::InspectorCanvas::indexForData):
(WebCore::InspectorCanvas::buildInitialState):
(WebCore::InspectorCanvas::buildArrayForCanvasGradient):
(WebCore::InspectorCanvas::buildArrayForCanvasPattern):

  • inspector/InspectorFrontendClient.h:

(WebCore::InspectorFrontendClient::debuggableType):

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::openInNewTab):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::InspectorFrontendHost::userInterfaceLayoutDirection):
(WebCore::InspectorFrontendHost::platform):
(WebCore::InspectorFrontendHost::port):

  • inspector/InspectorOverlay.cpp:

(WebCore::InspectorOverlay::setIndicating):
(WebCore::InspectorOverlay::drawPaintRects):
(WebCore::InspectorOverlay::drawRulers):
(WebCore::appendPathSegment):

  • inspector/InspectorStyleSheet.h:

(WebCore::InspectorCSSId::InspectorCSSId):

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createGenericRecord):
(WebCore::TimelineRecordFactory::createFunctionCallData):
(WebCore::TimelineRecordFactory::createConsoleProfileData):
(WebCore::TimelineRecordFactory::createProbeSampleData):
(WebCore::TimelineRecordFactory::createEventDispatchData):
(WebCore::TimelineRecordFactory::createGenericTimerData):
(WebCore::TimelineRecordFactory::createTimerInstallData):
(WebCore::TimelineRecordFactory::createEvaluateScriptData):
(WebCore::TimelineRecordFactory::createTimeStampData):
(WebCore::TimelineRecordFactory::createAnimationFrameData):
(WebCore::TimelineRecordFactory::createPaintData):
(WebCore::TimelineRecordFactory::appendLayoutRoot):

  • inspector/WebInjectedScriptHost.cpp:

(WebCore::WebInjectedScriptHost::subtype):
(WebCore::jsStringForPaymentRequestState):
(WebCore::WebInjectedScriptHost::getInternalProperties):

  • inspector/agents/InspectorApplicationCacheAgent.cpp:

(WebCore::InspectorApplicationCacheAgent::InspectorApplicationCacheAgent):

  • inspector/agents/InspectorCSSAgent.cpp:

(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::getMatchedStylesForNode):
(WebCore::InspectorCSSAgent::createStyleSheet):
(WebCore::InspectorCSSAgent::addRule):
(WebCore::InspectorCSSAgent::elementForId):
(WebCore::InspectorCSSAgent::assertStyleSheetForId):

  • inspector/agents/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::InspectorCanvasAgent):
(WebCore::InspectorCanvasAgent::requestNode):
(WebCore::InspectorCanvasAgent::requestContent):
(WebCore::InspectorCanvasAgent::resolveCanvasContext):
(WebCore::InspectorCanvasAgent::startRecording):
(WebCore::InspectorCanvasAgent::stopRecording):
(WebCore::InspectorCanvasAgent::requestShaderSource):
(WebCore::InspectorCanvasAgent::updateShader):
(WebCore::InspectorCanvasAgent::setShaderProgramDisabled):
(WebCore::InspectorCanvasAgent::setShaderProgramHighlighted):
(WebCore::InspectorCanvasAgent::assertInspectorCanvas):
(WebCore::InspectorCanvasAgent::assertInspectorProgram):

  • inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::assertNode):
(WebCore::InspectorDOMAgent::assertDocument):
(WebCore::InspectorDOMAgent::assertElement):
(WebCore::InspectorDOMAgent::assertEditableNode):
(WebCore::InspectorDOMAgent::assertEditableElement):
(WebCore::InspectorDOMAgent::getDocument):
(WebCore::InspectorDOMAgent::pushNodeToFrontend):
(WebCore::InspectorDOMAgent::requestChildNodes):
(WebCore::InspectorDOMAgent::querySelector):
(WebCore::InspectorDOMAgent::querySelectorAll):
(WebCore::InspectorDOMAgent::releaseBackendNodeIds):
(WebCore::InspectorDOMAgent::setAttributesAsText):
(WebCore::InspectorDOMAgent::removeNode):
(WebCore::InspectorDOMAgent::setOuterHTML):
(WebCore::InspectorDOMAgent::insertAdjacentHTML):
(WebCore::InspectorDOMAgent::setNodeValue):
(WebCore::InspectorDOMAgent::setEventListenerDisabled):
(WebCore::InspectorDOMAgent::performSearch):
(WebCore::InspectorDOMAgent::getSearchResults):
(WebCore::InspectorDOMAgent::highlightConfigFromInspectorObject):
(WebCore::InspectorDOMAgent::highlightQuad):
(WebCore::InspectorDOMAgent::highlightSelector):
(WebCore::InspectorDOMAgent::highlightNode):
(WebCore::InspectorDOMAgent::highlightNodeList):
(WebCore::InspectorDOMAgent::moveTo):
(WebCore::InspectorDOMAgent::focus):
(WebCore::InspectorDOMAgent::setInspectedNode):
(WebCore::InspectorDOMAgent::resolveNode):
(WebCore::InspectorDOMAgent::pushNodeByPathToFrontend):
(WebCore::InspectorDOMAgent::pushNodeByBackendIdToFrontend):

  • inspector/agents/InspectorDOMDebuggerAgent.cpp:

(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
(WebCore::InspectorDOMDebuggerAgent::setBreakpoint):
(WebCore::InspectorDOMDebuggerAgent::removeBreakpoint):
(WebCore::domTypeName):
(WebCore::InspectorDOMDebuggerAgent::pauseOnNativeEventIfNeeded):

  • inspector/agents/InspectorDOMStorageAgent.cpp:

(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::findStorageArea):

  • inspector/agents/InspectorDatabaseAgent.cpp:

(WebCore::InspectorDatabaseAgent::InspectorDatabaseAgent):
(WebCore::InspectorDatabaseAgent::getDatabaseTableNames):

  • inspector/agents/InspectorIndexedDBAgent.cpp:

(WebCore::Inspector::idbKeyRangeFromKeyRange):
(WebCore::InspectorIndexedDBAgent::InspectorIndexedDBAgent):
(WebCore::InspectorIndexedDBAgent::requestData):

  • inspector/agents/InspectorLayerTreeAgent.cpp:

(WebCore::InspectorLayerTreeAgent::InspectorLayerTreeAgent):
(WebCore::InspectorLayerTreeAgent::layersForNode):
(WebCore::InspectorLayerTreeAgent::reasonsForCompositingLayer):

  • inspector/agents/InspectorMemoryAgent.cpp:

(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):

  • inspector/agents/InspectorNetworkAgent.cpp:

(WebCore::InspectorNetworkAgent::InspectorNetworkAgent):
(WebCore::InspectorNetworkAgent::getResponseBody):
(WebCore::InspectorNetworkAgent::loadResource):
(WebCore::InspectorNetworkAgent::resolveWebSocket):
(WebCore::InspectorNetworkAgent::createTextDecoder):
(WebCore::InspectorNetworkAgent::searchInRequest):

  • inspector/agents/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::resourceContent):
(WebCore::InspectorPageAgent::InspectorPageAgent):
(WebCore::InspectorPageAgent::navigate):
(WebCore::InspectorPageAgent::assertFrame):
(WebCore::InspectorPageAgent::assertDocumentLoader):
(WebCore::InspectorPageAgent::snapshotNode):
(WebCore::InspectorPageAgent::snapshotRect):
(WebCore::InspectorPageAgent::archive):

  • inspector/agents/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
(WebCore::InspectorTimelineAgent::setInstruments):
(WebCore::InspectorTimelineAgent::startFromConsole):
(WebCore::InspectorTimelineAgent::stopFromConsole):
(WebCore::InspectorTimelineAgent::didCompleteRecordEntry):

  • inspector/agents/InspectorWorkerAgent.cpp:

(WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
(WebCore::InspectorWorkerAgent::initialized):
(WebCore::InspectorWorkerAgent::sendMessageToWorker):

  • inspector/agents/WebConsoleAgent.cpp:

(WebCore::WebConsoleAgent::setLoggingChannelLevel):

  • inspector/agents/page/PageDebuggerAgent.cpp:

(WebCore::PageDebuggerAgent::injectedScriptForEval):

  • inspector/agents/page/PageNetworkAgent.cpp:

(WebCore::PageNetworkAgent::scriptExecutionContext):

  • inspector/agents/page/PageRuntimeAgent.cpp:

(WebCore::PageRuntimeAgent::injectedScriptForEval):

  • inspector/agents/worker/ServiceWorkerAgent.cpp:

(WebCore::ServiceWorkerAgent::ServiceWorkerAgent):

  • inspector/agents/worker/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::injectedScriptForEval):

  • inspector/agents/worker/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::injectedScriptForEval):

  • loader/ContentFilter.cpp:

(WebCore::ContentFilter::handleProvisionalLoadFailure):

  • loader/CrossOriginAccessControl.cpp:

(WebCore::passesAccessControlCheck):
(WebCore::validatePreflightResponse):

  • loader/CrossOriginPreflightChecker.cpp:

(WebCore::CrossOriginPreflightChecker::notifyFinished):
(WebCore::CrossOriginPreflightChecker::doPreflight):

  • loader/DocumentLoader.cpp:

(WebCore::isRemoteWebArchive):
(WebCore::DocumentLoader::startIconLoading):

  • loader/DocumentThreadableLoader.cpp:

(WebCore::DocumentThreadableLoader::reportRedirectionWithBadScheme):
(WebCore::DocumentThreadableLoader::reportContentSecurityPolicyError):
(WebCore::DocumentThreadableLoader::reportCrossOriginResourceSharingError):
(WebCore::DocumentThreadableLoader::reportIntegrityMetadataError):

  • loader/FormSubmission.cpp:

(WebCore::FormSubmission::Attributes::parseEncodingType):

  • loader/FormSubmission.h:

(WebCore::FormSubmission::Attributes::methodString):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::initForSynthesizedDocument):
(WebCore::FrameLoader::loadURLIntoChildFrame):
(WebCore::FrameLoader::defaultSubstituteDataForURL):
(WebCore::FrameLoader::addHTTPUpgradeInsecureRequestsIfNeeded):
(WebCore::FrameLoader::dispatchBeforeUnloadEvent):

  • loader/LinkLoader.cpp:

(WebCore::LinkLoader::preconnectIfNeeded):

  • loader/NavigationScheduler.cpp:

(WebCore::NavigationScheduler::scheduleLocationChange):

  • loader/PingLoader.cpp:

(WebCore::PingLoader::sendViolationReport):

  • loader/ResourceLoadStatistics.cpp:

(WebCore::ResourceLoadStatistics::primaryDomain):
(WebCore::ResourceLoadStatistics::areDomainsAssociated):

  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::loadDataURL):
(WebCore::ResourceLoader::didBlockAuthenticationChallenge):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequestInternal):
(WebCore::SubresourceLoader::checkRedirectionCrossOriginAccessControl):

  • loader/ThreadableLoader.cpp:

(WebCore::ThreadableLoader::logError):

  • loader/appcache/ApplicationCacheGroup.cpp:

(WebCore::ApplicationCacheGroup::abort):
(WebCore::ApplicationCacheGroup::didFinishLoadingEntry):
(WebCore::ApplicationCacheGroup::didFinishLoadingManifest):
(WebCore::ApplicationCacheGroup::checkIfLoadIsComplete):

  • loader/appcache/ApplicationCacheHost.cpp:

(WebCore::ApplicationCacheHost::createFileURL):

  • loader/appcache/ManifestParser.cpp:

(WebCore::parseManifest):

  • loader/archive/ArchiveFactory.cpp:

(WebCore::createArchiveMIMETypesMap):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

  • loader/cache/CachedResourceLoader.cpp:

(WebCore::CachedResourceLoader::canRequest):
(WebCore::CachedResourceLoader::requestResource):

  • loader/cache/CachedResourceRequest.cpp:

(WebCore::acceptHeaderValueFromType):
(WebCore::CachedResourceRequest::updateAcceptEncodingHeader):

  • loader/cache/CachedScript.cpp:

(WebCore::CachedScript::CachedScript):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::getOriginsWithCache):

  • loader/soup/ResourceLoaderSoup.cpp:

(WebCore::ResourceLoader::loadGResource):

  • page/DOMSelection.cpp:

(WebCore::DOMSelection::type const):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::close):
(WebCore::DOMWindow::addEventListener):
(WebCore::DOMWindow::createWindow):

  • page/DebugPageOverlays.cpp:

(WebCore::touchEventRegionColors):

  • page/DiagnosticLoggingKeys.cpp:

(WebCore::DiagnosticLoggingKeys::mediaLoadedKey):
(WebCore::DiagnosticLoggingKeys::mediaLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::memoryCacheEntryDecisionKey):
(WebCore::DiagnosticLoggingKeys::memoryCacheUsageKey):
(WebCore::DiagnosticLoggingKeys::missingValidatorFieldsKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadedKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::postPageBackgroundingCPUUsageKey):
(WebCore::DiagnosticLoggingKeys::postPageBackgroundingMemoryUsageKey):
(WebCore::DiagnosticLoggingKeys::pageHandlesWebGLContextLossKey):
(WebCore::DiagnosticLoggingKeys::postPageLoadCPUUsageKey):
(WebCore::DiagnosticLoggingKeys::postPageLoadMemoryUsageKey):
(WebCore::DiagnosticLoggingKeys::provisionalLoadKey):
(WebCore::DiagnosticLoggingKeys::pageContainsPluginKey):
(WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOnePluginKey):
(WebCore::DiagnosticLoggingKeys::pageContainsMediaEngineKey):
(WebCore::DiagnosticLoggingKeys::pageContainsAtLeastOneMediaEngineKey):
(WebCore::DiagnosticLoggingKeys::pageLoadedKey):
(WebCore::DiagnosticLoggingKeys::playedKey):
(WebCore::DiagnosticLoggingKeys::engineFailedToLoadKey):
(WebCore::DiagnosticLoggingKeys::entryRightlyNotWarmedUpKey):
(WebCore::DiagnosticLoggingKeys::entryWronglyNotWarmedUpKey):
(WebCore::DiagnosticLoggingKeys::navigationKey):
(WebCore::DiagnosticLoggingKeys::needsRevalidationKey):
(WebCore::DiagnosticLoggingKeys::networkCacheKey):
(WebCore::DiagnosticLoggingKeys::networkCacheFailureReasonKey):
(WebCore::DiagnosticLoggingKeys::networkCacheUnusedReasonKey):
(WebCore::DiagnosticLoggingKeys::networkCacheReuseFailureKey):
(WebCore::DiagnosticLoggingKeys::networkKey):
(WebCore::DiagnosticLoggingKeys::networkProcessCrashedKey):
(WebCore::DiagnosticLoggingKeys::neverSeenBeforeKey):
(WebCore::DiagnosticLoggingKeys::noKey):
(WebCore::DiagnosticLoggingKeys::noCacheKey):
(WebCore::DiagnosticLoggingKeys::noStoreKey):
(WebCore::DiagnosticLoggingKeys::nonVisibleStateKey):
(WebCore::DiagnosticLoggingKeys::notInMemoryCacheKey):
(WebCore::DiagnosticLoggingKeys::pageCacheKey):
(WebCore::DiagnosticLoggingKeys::pageCacheFailureKey):
(WebCore::DiagnosticLoggingKeys::noDocumentLoaderKey):
(WebCore::DiagnosticLoggingKeys::noLongerInCacheKey):
(WebCore::DiagnosticLoggingKeys::otherKey):
(WebCore::DiagnosticLoggingKeys::mainDocumentErrorKey):
(WebCore::DiagnosticLoggingKeys::mainResourceKey):
(WebCore::DiagnosticLoggingKeys::isErrorPageKey):
(WebCore::DiagnosticLoggingKeys::isExpiredKey):
(WebCore::DiagnosticLoggingKeys::isReloadIgnoringCacheDataKey):
(WebCore::DiagnosticLoggingKeys::loadingKey):
(WebCore::DiagnosticLoggingKeys::hasPluginsKey):
(WebCore::DiagnosticLoggingKeys::httpsNoStoreKey):
(WebCore::DiagnosticLoggingKeys::imageKey):
(WebCore::DiagnosticLoggingKeys::inMemoryCacheKey):
(WebCore::DiagnosticLoggingKeys::inactiveKey):
(WebCore::DiagnosticLoggingKeys::internalErrorKey):
(WebCore::DiagnosticLoggingKeys::invalidSessionIDKey):
(WebCore::DiagnosticLoggingKeys::isAttachmentKey):
(WebCore::DiagnosticLoggingKeys::isConditionalRequestKey):
(WebCore::DiagnosticLoggingKeys::isDisabledKey):
(WebCore::DiagnosticLoggingKeys::noCurrentHistoryItemKey):
(WebCore::DiagnosticLoggingKeys::quirkRedirectComingKey):
(WebCore::DiagnosticLoggingKeys::rawKey):
(WebCore::DiagnosticLoggingKeys::redirectKey):
(WebCore::DiagnosticLoggingKeys::isLoadingKey):
(WebCore::DiagnosticLoggingKeys::documentLoaderStoppingKey):
(WebCore::DiagnosticLoggingKeys::domainCausingCrashKey):
(WebCore::DiagnosticLoggingKeys::domainCausingEnergyDrainKey):
(WebCore::DiagnosticLoggingKeys::domainCausingJetsamKey):
(WebCore::DiagnosticLoggingKeys::simulatedPageCrashKey):
(WebCore::DiagnosticLoggingKeys::exceededActiveMemoryLimitKey):
(WebCore::DiagnosticLoggingKeys::exceededInactiveMemoryLimitKey):
(WebCore::DiagnosticLoggingKeys::exceededBackgroundCPULimitKey):
(WebCore::DiagnosticLoggingKeys::domainVisitedKey):
(WebCore::DiagnosticLoggingKeys::cannotSuspendActiveDOMObjectsKey):
(WebCore::DiagnosticLoggingKeys::cpuUsageKey):
(WebCore::DiagnosticLoggingKeys::createSharedBufferFailedKey):
(WebCore::DiagnosticLoggingKeys::activeInForegroundTabKey):
(WebCore::DiagnosticLoggingKeys::activeInBackgroundTabOnlyKey):
(WebCore::DiagnosticLoggingKeys::applicationCacheKey):
(WebCore::DiagnosticLoggingKeys::applicationManifestKey):
(WebCore::DiagnosticLoggingKeys::audioKey):
(WebCore::DiagnosticLoggingKeys::backNavigationDeltaKey):
(WebCore::DiagnosticLoggingKeys::canCacheKey):
(WebCore::DiagnosticLoggingKeys::cacheControlNoStoreKey):
(WebCore::DiagnosticLoggingKeys::cachedResourceRevalidationKey):
(WebCore::DiagnosticLoggingKeys::cachedResourceRevalidationReasonKey):
(WebCore::DiagnosticLoggingKeys::deniedByClientKey):
(WebCore::DiagnosticLoggingKeys::deviceMotionKey):
(WebCore::DiagnosticLoggingKeys::deviceOrientationKey):
(WebCore::DiagnosticLoggingKeys::diskCacheKey):
(WebCore::DiagnosticLoggingKeys::diskCacheAfterValidationKey):
(WebCore::DiagnosticLoggingKeys::reloadKey):
(WebCore::DiagnosticLoggingKeys::replaceKey):
(WebCore::DiagnosticLoggingKeys::retrievalRequestKey):
(WebCore::DiagnosticLoggingKeys::resourceLoadedKey):
(WebCore::DiagnosticLoggingKeys::resourceResponseSourceKey):
(WebCore::DiagnosticLoggingKeys::retrievalKey):
(WebCore::DiagnosticLoggingKeys::revalidatingKey):
(WebCore::DiagnosticLoggingKeys::reloadFromOriginKey):
(WebCore::DiagnosticLoggingKeys::reloadRevalidatingExpiredKey):
(WebCore::DiagnosticLoggingKeys::sameLoadKey):
(WebCore::DiagnosticLoggingKeys::scriptKey):
(WebCore::DiagnosticLoggingKeys::serviceWorkerKey):
(WebCore::DiagnosticLoggingKeys::streamingMedia):
(WebCore::DiagnosticLoggingKeys::styleSheetKey):
(WebCore::DiagnosticLoggingKeys::successfulSpeculativeWarmupWithRevalidationKey):
(WebCore::DiagnosticLoggingKeys::successfulSpeculativeWarmupWithoutRevalidationKey):
(WebCore::DiagnosticLoggingKeys::svgDocumentKey):
(WebCore::DiagnosticLoggingKeys::synchronousMessageFailedKey):
(WebCore::DiagnosticLoggingKeys::telemetryPageLoadKey):
(WebCore::DiagnosticLoggingKeys::timedOutKey):
(WebCore::DiagnosticLoggingKeys::canceledLessThan2SecondsKey):
(WebCore::DiagnosticLoggingKeys::canceledLessThan5SecondsKey):
(WebCore::DiagnosticLoggingKeys::canceledLessThan20SecondsKey):
(WebCore::DiagnosticLoggingKeys::canceledMoreThan20SecondsKey):
(WebCore::DiagnosticLoggingKeys::failedLessThan2SecondsKey):
(WebCore::DiagnosticLoggingKeys::failedLessThan5SecondsKey):
(WebCore::DiagnosticLoggingKeys::failedLessThan20SecondsKey):
(WebCore::DiagnosticLoggingKeys::failedMoreThan20SecondsKey):
(WebCore::DiagnosticLoggingKeys::occurredKey):
(WebCore::DiagnosticLoggingKeys::succeededLessThan2SecondsKey):
(WebCore::DiagnosticLoggingKeys::succeededLessThan5SecondsKey):
(WebCore::DiagnosticLoggingKeys::succeededLessThan20SecondsKey):
(WebCore::DiagnosticLoggingKeys::succeededMoreThan20SecondsKey):
(WebCore::DiagnosticLoggingKeys::uncacheableStatusCodeKey):
(WebCore::DiagnosticLoggingKeys::underMemoryPressureKey):
(WebCore::DiagnosticLoggingKeys::unknownEntryRequestKey):
(WebCore::DiagnosticLoggingKeys::unlikelyToReuseKey):
(WebCore::DiagnosticLoggingKeys::unsupportedHTTPMethodKey):
(WebCore::DiagnosticLoggingKeys::unsuspendableDOMObjectKey):
(WebCore::DiagnosticLoggingKeys::unusedKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonCredentialSettingsKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonErrorKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonMustRevalidateNoValidatorKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonNoStoreKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonRedirectChainKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonReloadKey):
(WebCore::DiagnosticLoggingKeys::unusedReasonTypeMismatchKey):
(WebCore::DiagnosticLoggingKeys::usedKey):
(WebCore::DiagnosticLoggingKeys::userZoomActionKey):
(WebCore::DiagnosticLoggingKeys::varyingHeaderMismatchKey):
(WebCore::DiagnosticLoggingKeys::videoKey):
(WebCore::DiagnosticLoggingKeys::visibleNonActiveStateKey):
(WebCore::DiagnosticLoggingKeys::visibleAndActiveStateKey):
(WebCore::DiagnosticLoggingKeys::wastedSpeculativeWarmupWithRevalidationKey):
(WebCore::DiagnosticLoggingKeys::wastedSpeculativeWarmupWithoutRevalidationKey):
(WebCore::DiagnosticLoggingKeys::webViewKey):
(WebCore::DiagnosticLoggingKeys::yesKey):
(WebCore::DiagnosticLoggingKeys::expiredKey):
(WebCore::DiagnosticLoggingKeys::fontKey):
(WebCore::DiagnosticLoggingKeys::prunedDueToMemoryPressureKey):
(WebCore::DiagnosticLoggingKeys::prunedDueToMaxSizeReached):
(WebCore::DiagnosticLoggingKeys::prunedDueToProcessSuspended):
(WebCore::WebCore::DiagnosticLoggingKeys::notHTTPFamilyKey):
(WebCore::WebCore::DiagnosticLoggingKeys::webGLStateKey):
(WebCore::DiagnosticLoggingKeys::memoryUsageToDiagnosticLoggingKey):
(WebCore::DiagnosticLoggingKeys::foregroundCPUUsageToDiagnosticLoggingKey):
(WebCore::DiagnosticLoggingKeys::backgroundCPUUsageToDiagnosticLoggingKey):
(WebCore::DiagnosticLoggingKeys::resourceLoadStatisticsTelemetryKey):

  • page/DisabledAdaptations.cpp:

(WebCore::watchAdaptationName):

  • page/EventHandler.cpp:

(WebCore::EventHandler::handlePasteGlobalSelection):
(WebCore::convertDragOperationToDropZoneOperation):

  • page/EventSource.cpp:

(WebCore::EventSource::EventSource):

  • page/History.cpp:

(WebCore::History::stateObjectAdded):

  • page/NavigatorBase.cpp:

(WebCore::NavigatorBase::appName):
(WebCore::NavigatorBase::appCodeName):

  • page/Page.cpp:

(WebCore::Page::logNavigation):

  • page/PageDebuggable.cpp:

(WebCore::PageDebuggable::url const):

  • page/PageSerializer.cpp:

(WebCore::PageSerializer::serializeCSSStyleSheet):

  • page/PerformanceMark.h:
  • page/PerformanceMeasure.h:
  • page/PerformanceObserver.cpp:

(WebCore::PerformanceObserver::observe):

  • page/PerformanceResourceTiming.cpp:

(WebCore::PerformanceResourceTiming::PerformanceResourceTiming):

  • page/PerformanceUserTiming.cpp:

(WebCore::restrictedMarkFunction):

  • page/PointerLockController.cpp:

(WebCore::PointerLockController::requestPointerLock):

  • page/PrintContext.cpp:

(WebCore::PrintContext::pageProperty):

  • page/SecurityOrigin.cpp:

(WebCore::SecurityOrigin::toString const):

  • page/SecurityOriginData.cpp:

(WebCore::SecurityOriginData::toString const):
(WebCore::SecurityOriginData::databaseIdentifier const):

  • page/cocoa/ResourceUsageOverlayCocoa.mm:

(WebCore::gcTimerString):

  • page/csp/ContentSecurityPolicy.cpp:

(WebCore::ContentSecurityPolicy::reportViolation const):
(WebCore::ContentSecurityPolicy::reportUnsupportedDirective const):

  • page/linux/ResourceUsageOverlayLinux.cpp:

(WebCore::cpuUsageString):
(WebCore::gcTimerString):

  • platform/ContentType.cpp:

(WebCore::ContentType::codecsParameter):
(WebCore::ContentType::profilesParameter):

  • platform/Decimal.cpp:

(WebCore::Decimal::toString const):

  • platform/MIMETypeRegistry.cpp:

(WebCore::initializeSupportedImageMIMETypes):
(WebCore::typesForCommonExtension):
(WebCore::initializeUnsupportedTextMIMETypes):
(WebCore::MIMETypeRegistry::getNormalizedMIMEType):

  • platform/SchemeRegistry.cpp:

(WebCore::SchemeRegistry::canServiceWorkersHandleURLScheme):

  • platform/URL.cpp:

(WebCore::mimeTypeFromDataURL):

  • platform/UserAgentQuirks.cpp:

(WebCore::UserAgentQuirks::stringForQuirk):

  • platform/cocoa/KeyEventCocoa.mm:

(WebCore::keyForCharCode):

  • platform/cocoa/NetworkExtensionContentFilter.mm:

(WebCore::NetworkExtensionContentFilter::unblockHandler const):

  • platform/cocoa/ParentalControlsContentFilter.mm:

(WebCore::ParentalControlsContentFilter::unblockHandler const):

  • platform/cocoa/PasteboardCocoa.mm:

(WebCore::Pasteboard::fileContentState):

  • platform/cocoa/RuntimeApplicationChecksCocoa.mm:

(WebCore::MacApplication::isSafari):
(WebCore::MacApplication::isAppleMail):
(WebCore::MacApplication::isIBooks):
(WebCore::MacApplication::isITunes):
(WebCore::MacApplication::isMicrosoftMessenger):
(WebCore::MacApplication::isAdobeInstaller):
(WebCore::MacApplication::isAOLInstantMessenger):
(WebCore::MacApplication::isMicrosoftMyDay):
(WebCore::MacApplication::isMicrosoftOutlook):
(WebCore::MacApplication::isQuickenEssentials):
(WebCore::MacApplication::isAperture):
(WebCore::MacApplication::isVersions):
(WebCore::MacApplication::isHRBlock):
(WebCore::MacApplication::isIAdProducer):
(WebCore::MacApplication::isSolidStateNetworksDownloader):
(WebCore::IOSApplication::isMobileMail):
(WebCore::IOSApplication::isMobileSafari):
(WebCore::IOSApplication::isWebBookmarksD):
(WebCore::IOSApplication::isDumpRenderTree):
(WebCore::IOSApplication::isMobileStore):
(WebCore::IOSApplication::isSpringBoard):
(WebCore::IOSApplication::isWebApp):
(WebCore::IOSApplication::isIBooks):
(WebCore::IOSApplication::isIBooksStorytime):
(WebCore::IOSApplication::isTheSecretSocietyHiddenMystery):
(WebCore::IOSApplication::isCardiogram):
(WebCore::IOSApplication::isNike):

  • platform/cocoa/UserAgentCocoa.mm:

(WebCore::userAgentBundleVersion):

  • platform/gamepad/cocoa/GameControllerGamepad.mm:

(WebCore::GameControllerGamepad::setupAsExtendedGamepad):
(WebCore::GameControllerGamepad::setupAsGamepad):

  • platform/graphics/InbandTextTrackPrivateClient.h:

(WebCore::GenericCueData::toJSONString const):

  • platform/graphics/avfoundation/CDMFairPlayStreaming.cpp:

(WebCore::CDMFactoryFairPlayStreaming::supportsKeySystem):

  • platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(WebCore::isEqual):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::keySystem const):

  • platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm:

(WebCore::CDMSessionAVContentKeySession::generateKeyRequest):

  • platform/graphics/avfoundation/objc/CDMSessionAVStreamSession.mm:

(WebCore::CDMSessionAVStreamSession::generateKeyRequest):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::propertyIdToString):

  • platform/graphics/ca/TileController.cpp:

(WebCore::TileController::tileGridContainerLayerName):
(WebCore::TileController::zoomedOutTileGridContainerLayerName):

  • platform/graphics/cg/ImageBufferCG.cpp:

(WebCore::ImageBuffer::toDataURL const):
(WebCore::dataURL):

  • platform/graphics/cv/VideoTextureCopierCV.cpp:

(WebCore::VideoTextureCopierCV::initializeContextObjects):
(WebCore::VideoTextureCopierCV::initializeUVContextObjects):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::handleSyncMessage):
(WebCore::MediaPlayerPrivateGStreamerBase::initializationDataEncountered):

  • platform/graphics/iso/ISOVTTCue.cpp:

(WebCore::ISOWebVTTCue::toJSONString const):

  • platform/graphics/nicosia/NicosiaPaintingEngineThreaded.cpp:

(Nicosia::PaintingEngineThreaded::PaintingEngineThreaded):

  • platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:

(WebCore::Extensions3DOpenGLCommon::initializeAvailableExtensions):

  • platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:

(WebCore::GraphicsContext3D::getUnmangledInfoLog):

  • platform/graphics/texmap/TextureMapperContextAttributes.cpp:

(WebCore::TextureMapperContextAttributes::get):

  • platform/graphics/win/ImageBufferDirect2D.cpp:

(WebCore::ImageBuffer::toDataURL const):
(WebCore::ImageDataToDataURL):

  • platform/gtk/PasteboardGtk.cpp:

(WebCore::Pasteboard::typesForLegacyUnsafeBindings):

  • platform/gtk/PasteboardHelper.cpp:
  • platform/gtk/PlatformKeyboardEventGtk.cpp:

(WebCore::PlatformKeyboardEvent::keyValueForGdkKeyCode):
(WebCore::PlatformKeyboardEvent::keyCodeForHardwareKeyCode):

  • platform/image-decoders/bmp/BMPImageDecoder.h:
  • platform/image-decoders/gif/GIFImageDecoder.h:
  • platform/image-decoders/ico/ICOImageDecoder.h:
  • platform/image-decoders/jpeg/JPEGImageDecoder.h:
  • platform/image-decoders/png/PNGImageDecoder.h:
  • platform/image-decoders/webp/WEBPImageDecoder.h:
  • platform/ios/Device.cpp:

(WebCore::deviceName):

  • platform/ios/PasteboardIOS.mm:

(WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType):

  • platform/ios/PlatformEventFactoryIOS.mm:

(WebCore::keyForKeyEvent):
(WebCore::codeForKeyEvent):

  • platform/ios/PlatformPasteboardIOS.mm:

(WebCore::safeTypeForDOMToReadAndWriteForPlatformType):

  • platform/mac/PasteboardMac.mm:

(WebCore::Pasteboard::read):
(WebCore::Pasteboard::addHTMLClipboardTypesForCocoaType):

  • platform/mac/PlatformEventFactoryMac.mm:

(WebCore::keyForKeyEvent):
(WebCore::codeForKeyEvent):

  • platform/mac/PlatformPasteboardMac.mm:

(WebCore::safeTypeForDOMToReadAndWriteForPlatformType):

  • platform/mediastream/MediaConstraints.cpp:

(WebCore::addDefaultVideoConstraints):

  • platform/mediastream/PeerMediaDescription.h:
  • platform/mediastream/RealtimeMediaSource.cpp:

(WebCore::RealtimeMediaSource::applyConstraints):

  • platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp:

(WebCore::DisplayCaptureManagerCocoa::screenCaptureDeviceWithPersistentID):

  • platform/mock/MockRealtimeMediaSource.cpp:

(WebCore::deviceMap):
(WebCore::MockRealtimeMediaSource::audioDevices):
(WebCore::MockRealtimeMediaSource::videoDevices):
(WebCore::MockRealtimeMediaSource::displayDevices):

  • platform/mock/MockRealtimeVideoSource.cpp:

(WebCore::MockRealtimeVideoSource::drawText):

  • platform/network/BlobRegistryImpl.cpp:

(WebCore::BlobRegistryImpl::writeBlobsToTemporaryFiles):

  • platform/network/DataURLDecoder.cpp:

(WebCore::DataURLDecoder::parseMediaType):

  • platform/network/FormData.cpp:

(WebCore::FormData::appendMultiPartFileValue):

  • platform/network/HTTPParsers.cpp:

(WebCore::parseHTTPRequestLine):
(WebCore::parseHTTPHeader):
(WebCore::normalizeHTTPMethod):

  • platform/network/ResourceRequestBase.cpp:

(WebCore::ResourceRequestBase::redirectedRequest const):

  • platform/network/ResourceRequestBase.h:

(WebCore::ResourceRequestBase::ResourceRequestBase):

  • platform/network/curl/ResourceHandleCurl.cpp:

(WebCore::ResourceHandle::handleDataURL):

  • platform/network/curl/SynchronousLoaderClientCurl.cpp:

(WebCore::SynchronousLoaderClient::platformBadResponseError):

  • platform/network/win/DownloadBundleWin.cpp:

(WebCore::DownloadBundle::fileExtension):

  • platform/sql/SQLiteDatabase.cpp:

(WebCore::SQLiteDatabase::open):
(WebCore::SQLiteDatabase::setFullsync):
(WebCore::SQLiteDatabase::maximumSize):
(WebCore::SQLiteDatabase::pageSize):
(WebCore::SQLiteDatabase::freeSpaceSize):
(WebCore::SQLiteDatabase::totalSize):
(WebCore::SQLiteDatabase::clearAllTables):
(WebCore::SQLiteDatabase::runVacuumCommand):
(WebCore::SQLiteDatabase::runIncrementalVacuumCommand):
(WebCore::SQLiteDatabase::turnOnIncrementalAutoVacuum):

  • platform/sql/SQLiteFileSystem.cpp:

(WebCore::SQLiteFileSystem::deleteDatabaseFile):

  • platform/text/LocaleICU.cpp:

(WebCore::LocaleICU::dateFormat):
(WebCore::getFormatForSkeleton):

  • platform/text/LocaleNone.cpp:

(WebCore::LocaleNone::dateFormat):
(WebCore::LocaleNone::monthFormat):
(WebCore::LocaleNone::shortMonthFormat):
(WebCore::LocaleNone::timeFormat):
(WebCore::LocaleNone::shortTimeFormat):
(WebCore::LocaleNone::dateTimeFormatWithSeconds):
(WebCore::LocaleNone::dateTimeFormatWithoutSeconds):

  • platform/text/LocaleToScriptMappingDefault.cpp:

(WebCore::scriptNameToCode):
(WebCore::localeToScriptCodeForFontSelection):

  • platform/text/TextEncodingRegistry.cpp:

(WebCore::defaultTextEncodingNameForSystemLanguage):

  • platform/win/FileSystemWin.cpp:

(WebCore::FileSystem::bundleName):

  • platform/wpe/RenderThemeWPE.cpp:

(WebCore::RenderThemeWPE::mediaControlsStyleSheet):

  • rendering/RenderMenuList.cpp:

(RenderMenuList::setText):

  • rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::extraDefaultStyleSheet):

  • svg/SVGComponentTransferFunctionElement.h:

(WebCore::SVGPropertyTraits<ComponentTransferType>::toString):

  • svg/SVGFEColorMatrixElement.h:

(WebCore::SVGPropertyTraits<ColorMatrixType>::toString):

  • svg/SVGFECompositeElement.h:

(WebCore::SVGPropertyTraits<CompositeOperationType>::toString):

  • svg/SVGFEConvolveMatrixElement.h:

(WebCore::SVGPropertyTraits<EdgeModeType>::toString):

  • svg/SVGFEDisplacementMapElement.h:

(WebCore::SVGPropertyTraits<ChannelSelectorType>::toString):

  • svg/SVGFEMorphologyElement.h:

(WebCore::SVGPropertyTraits<MorphologyOperatorType>::toString):

  • svg/SVGFETurbulenceElement.h:

(WebCore::SVGPropertyTraits<SVGStitchOptions>::toString):
(WebCore::SVGPropertyTraits<TurbulenceType>::toString):

  • svg/SVGGradientElement.h:

(WebCore::SVGPropertyTraits<SVGSpreadMethodType>::toString):

  • svg/SVGLocatable.cpp:

(WebCore::SVGLocatable::getTransformToElement):

  • svg/SVGMarkerTypes.h:

(WebCore::SVGPropertyTraits<SVGMarkerUnitsType>::toString):

  • svg/SVGMatrixValue.h:
  • svg/SVGSVGElement.cpp:

(WebCore::SVGSVGElement::SVGSVGElement):
(WebCore::SVGSVGElement::parseAttribute):

  • svg/SVGTextContentElement.h:

(WebCore::SVGPropertyTraits<SVGLengthAdjustType>::toString):

  • svg/SVGTextPathElement.h:

(WebCore::SVGPropertyTraits<SVGTextPathMethodType>::toString):
(WebCore::SVGPropertyTraits<SVGTextPathSpacingType>::toString):

  • svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::appendCFFTable):

  • svg/SVGUnitTypes.h:

(WebCore::SVGPropertyTraits<SVGUnitTypes::SVGUnitType>::toString):

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::toClipPath):

  • svg/graphics/SVGImage.cpp:

(WebCore::SVGImage::filenameExtension const):

  • testing/InternalSettings.cpp:

(WebCore::InternalSettings::userInterfaceDirectionPolicy):
(WebCore::InternalSettings::systemLayoutDirection):

  • testing/Internals.cpp:

(WebCore::Internals::areSVGAnimationsPaused const):
(WebCore::Internals::accessKeyModifiers const):
(WebCore::Internals::setMediaDeviceState):
(WebCore::Internals::audioSessionCategory const):
(WebCore::Internals::systemPreviewRelType):

  • testing/MockCDMFactory.cpp:

(WebCore::MockCDM::sanitizeResponse const):
(WebCore::MockCDMInstance::updateLicense):

  • testing/MockContentFilter.cpp:

(WebCore::MockContentFilter::unblockRequestDeniedScript const):

  • testing/MockCredentialsMessenger.cpp:

(WebCore::MockCredentialsMessenger::~MockCredentialsMessenger):
(WebCore::MockCredentialsMessenger::makeCredential):
(WebCore::MockCredentialsMessenger::getAssertion):

  • testing/MockPaymentCoordinator.cpp:

(WebCore::MockPaymentCoordinator::showPaymentUI):

  • workers/WorkerRunLoop.cpp:

(WebCore::WorkerRunLoop::debuggerMode):

  • workers/WorkerScriptLoader.cpp:

(WebCore::WorkerScriptLoader::loadSynchronously):
(WebCore::WorkerScriptLoader::createResourceRequest):
(WebCore::WorkerScriptLoader::didReceiveData):

  • workers/service/ExtendableEvent.cpp:

(WebCore::ExtendableEvent::waitUntil):

  • workers/service/FetchEvent.cpp:

(WebCore::FetchEvent::~FetchEvent):
(WebCore::FetchEvent::respondWith):
(WebCore::FetchEvent::promiseIsSettled):

  • workers/service/SWClientConnection.cpp:

(WebCore::SWClientConnection::clearPendingJobs):

  • workers/service/ServiceWorker.cpp:

(WebCore::ServiceWorker::postMessage):

  • workers/service/ServiceWorkerClients.cpp:

(WebCore::ServiceWorkerClients::openWindow):
(WebCore::ServiceWorkerClients::claim):

  • workers/service/ServiceWorkerContainer.cpp:

(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::getRegistration):
(WebCore::ServiceWorkerContainer::startScriptFetchForJob):

  • workers/service/ServiceWorkerJob.cpp:

(WebCore::ServiceWorkerJob::fetchScriptWithContext):
(WebCore::ServiceWorkerJob::didReceiveResponse):

  • workers/service/ServiceWorkerRegistration.cpp:

(WebCore::ServiceWorkerRegistration::update):

  • workers/service/ServiceWorkerWindowClient.cpp:

(WebCore::ServiceWorkerWindowClient::focus):
(WebCore::ServiceWorkerWindowClient::navigate):

  • workers/service/context/ServiceWorkerDebuggable.h:
  • workers/service/context/ServiceWorkerFetch.cpp:

(WebCore::ServiceWorkerFetch::dispatchFetchEvent):

  • workers/service/server/RegistrationDatabase.cpp:

(WebCore::RegistrationDatabase::doPushChanges):
(WebCore::RegistrationDatabase::importRecords):

  • workers/service/server/SWServerJobQueue.cpp:

(WebCore::SWServerJobQueue::runRegisterJob):
(WebCore::SWServerJobQueue::runUnregisterJob):
(WebCore::SWServerJobQueue::runUpdateJob):

  • xml/XMLErrors.cpp:

(WebCore::createXHTMLParserErrorHeader):
(WebCore::XMLErrors::insertErrorMessageBlock):

  • xml/XMLHttpRequest.cpp:

(WebCore::XMLHttpRequest::send):
(WebCore::XMLHttpRequest::responseMIMEType const):

  • xml/XMLTreeViewer.cpp:

(WebCore::XMLTreeViewer::transformDocumentToTreeView):

  • xml/XPathPredicate.cpp:

(WebCore::XPath::evaluatePredicate):

  • xml/XPathValue.cpp:

(WebCore::XPath::Value::toString const):

  • xml/parser/CharacterReferenceParserInlines.h:

(WebCore::consumeCharacterReference):

Source/WebCore/PAL:

  • pal/unix/LoggingUnix.cpp:

(PAL::logLevelString):

Source/WebDriver:

  • CommandResult.cpp:

(WebDriver::CommandResult::errorString const):

  • Session.cpp:

(WebDriver::Session::webElementIdentifier):
(WebDriver::Session::getTimeouts):
(WebDriver::Session::createTopLevelBrowsingContext):
(WebDriver::Session::handleUserPrompts):
(WebDriver::Session::reportUnexpectedAlertOpen):
(WebDriver::Session::go):
(WebDriver::Session::getCurrentURL):
(WebDriver::Session::back):
(WebDriver::Session::forward):
(WebDriver::Session::refresh):
(WebDriver::Session::getTitle):
(WebDriver::Session::getWindowHandle):
(WebDriver::Session::closeTopLevelBrowsingContext):
(WebDriver::Session::switchToWindow):
(WebDriver::Session::getWindowHandles):
(WebDriver::Session::switchToFrame):
(WebDriver::Session::switchToParentFrame):
(WebDriver::Session::getToplevelBrowsingContextRect):
(WebDriver::Session::setWindowRect):
(WebDriver::Session::maximizeWindow):
(WebDriver::Session::minimizeWindow):
(WebDriver::Session::fullscreenWindow):
(WebDriver::Session::computeElementLayout):
(WebDriver::Session::findElements):
(WebDriver::Session::getActiveElement):
(WebDriver::Session::isElementSelected):
(WebDriver::Session::getElementText):
(WebDriver::Session::getElementTagName):
(WebDriver::Session::getElementRect):
(WebDriver::Session::isElementEnabled):
(WebDriver::Session::isElementDisplayed):
(WebDriver::Session::getElementAttribute):
(WebDriver::Session::getElementProperty):
(WebDriver::Session::getElementCSSValue):
(WebDriver::Session::waitForNavigationToComplete):
(WebDriver::Session::selectOptionElement):
(WebDriver::Session::elementClear):
(WebDriver::Session::virtualKeyForKeySequence):
(WebDriver::Session::elementSendKeys):
(WebDriver::Session::executeScript):
(WebDriver::mouseButtonForAutomation):
(WebDriver::Session::performMouseInteraction):
(WebDriver::Session::performKeyboardInteractions):
(WebDriver::parseAutomationCookie):
(WebDriver::builtAutomationCookie):
(WebDriver::serializeCookie):
(WebDriver::Session::getAllCookies):
(WebDriver::Session::getNamedCookie):
(WebDriver::Session::addCookie):
(WebDriver::Session::deleteCookie):
(WebDriver::Session::deleteAllCookies):
(WebDriver::Session::performActions):
(WebDriver::Session::releaseActions):
(WebDriver::Session::dismissAlert):
(WebDriver::Session::acceptAlert):
(WebDriver::Session::getAlertText):
(WebDriver::Session::sendAlertText):
(WebDriver::Session::takeScreenshot):

  • SessionHost.cpp:

(WebDriver::SessionHost::dispatchMessage):

  • WebDriverService.cpp:

(WebDriver::WebDriverService::sendResponse const):
(WebDriver::WebDriverService::parseCapabilities const):
(WebDriver::WebDriverService::findSessionOrCompleteWithError):
(WebDriver::WebDriverService::matchCapabilities const):
(WebDriver::WebDriverService::processCapabilities const):
(WebDriver::WebDriverService::createSession):
(WebDriver::WebDriverService::deleteSession):
(WebDriver::WebDriverService::status):
(WebDriver::WebDriverService::go):
(WebDriver::WebDriverService::setWindowRect):
(WebDriver::WebDriverService::switchToWindow):
(WebDriver::WebDriverService::switchToFrame):
(WebDriver::findElementOrCompleteWithError):
(WebDriver::findStrategyAndSelectorOrCompleteWithError):
(WebDriver::WebDriverService::getElementAttribute):
(WebDriver::WebDriverService::getElementProperty):
(WebDriver::WebDriverService::getElementCSSValue):
(WebDriver::WebDriverService::elementSendKeys):
(WebDriver::findScriptAndArgumentsOrCompleteWithError):
(WebDriver::WebDriverService::getNamedCookie):
(WebDriver::deserializeCookie):
(WebDriver::WebDriverService::addCookie):
(WebDriver::WebDriverService::deleteCookie):
(WebDriver::processPauseAction):
(WebDriver::processNullAction):
(WebDriver::processKeyAction):
(WebDriver::processPointerAction):
(WebDriver::processPointerParameters):
(WebDriver::processInputActionSequence):
(WebDriver::WebDriverService::performActions):
(WebDriver::WebDriverService::sendAlertText):
(WebDriver::WebDriverService::takeElementScreenshot):

  • glib/SessionHostGlib.cpp:

(WebDriver::SessionHost::sendMessageToBackend):

  • gtk/WebDriverServiceGtk.cpp:

(WebDriver::WebDriverService::platformValidateCapability const):
(WebDriver::WebDriverService::platformParseCapabilities const):

  • wpe/WebDriverServiceWPE.cpp:

(WebDriver::WebDriverService::platformValidateCapability const):
(WebDriver::WebDriverService::platformParseCapabilities const):

Source/WebKit:

  • NetworkProcess/NetworkCORSPreflightChecker.cpp:

(WebKit::NetworkCORSPreflightChecker::willPerformHTTPRedirection):
(WebKit::NetworkCORSPreflightChecker::didReceiveChallenge):
(WebKit::NetworkCORSPreflightChecker::wasBlocked):
(WebKit::NetworkCORSPreflightChecker::cannotShowURL):

  • NetworkProcess/NetworkDataTaskBlob.cpp:

(WebKit::NetworkDataTaskBlob::suggestedFilename const):

  • NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::checkRedirection):
(WebKit::NetworkLoadChecker::checkRequest):

  • NetworkProcess/NetworkResourceLoader.cpp:

(WebKit::NetworkResourceLoader::continueWillSendRequest):

  • NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::didReceiveChallenge):
(WebKit::PingLoad::timeoutTimerFired):

  • NetworkProcess/PreconnectTask.cpp:

(WebKit::PreconnectTask::PreconnectTask):

  • NetworkProcess/cache/CacheStorageEngine.cpp:

(WebKit::CacheStorage::Engine::initialize):

  • NetworkProcess/cache/CacheStorageEngineCache.cpp:

(WebKit::CacheStorage::Cache::toRecordInformation):

  • NetworkProcess/cache/CacheStorageEngineCaches.cpp:

(WebKit::CacheStorage::cachesListFilename):
(WebKit::CacheStorage::cachesOriginFilename):

  • NetworkProcess/cache/NetworkCacheStatistics.cpp:

(WebKit::NetworkCache::Statistics::initialize):
(WebKit::NetworkCache::Statistics::bootstrapFromNetworkCache):
(WebKit::NetworkCache::Statistics::queryWasEverRequested):
(WebKit::NetworkCache::Statistics::clear):
(WebKit::NetworkCache::Statistics::addHashesToDatabase):
(WebKit::NetworkCache::Statistics::addStoreDecisionsToDatabase):

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:

(WebKit::XPCServiceInitializer):

  • Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceInitializerDelegate::getExtraInitializationData):

  • Shared/Plugins/Netscape/PluginInformation.cpp:

(WebKit::pluginInformationBundleIdentifierKey):
(WebKit::pluginInformationBundleVersionKey):
(WebKit::pluginInformationBundleShortVersionKey):
(WebKit::pluginInformationPathKey):
(WebKit::pluginInformationDisplayNameKey):
(WebKit::pluginInformationDefaultLoadPolicyKey):
(WebKit::pluginInformationUpdatePastLastBlockedVersionIsKnownAvailableKey):
(WebKit::pluginInformationHasSandboxProfileKey):
(WebKit::pluginInformationFrameURLKey):
(WebKit::pluginInformationMIMETypeKey):
(WebKit::pluginInformationPageURLKey):
(WebKit::pluginInformationPluginspageAttributeURLKey):
(WebKit::pluginInformationPluginURLKey):
(WebKit::plugInInformationReplacementObscuredKey):

  • Shared/ios/WebIOSEventFactory.mm:

(WebIOSEventFactory::createWebKeyboardEvent):

  • Shared/linux/WebMemorySamplerLinux.cpp:

(WebKit::WebMemorySampler::sampleWebKit const):

  • UIProcess/API/Cocoa/_WKRemoteWebInspectorViewController.mm:

(debuggableTypeString):

  • UIProcess/API/glib/WebKitWebContext.cpp:

(webkit_web_context_set_preferred_languages):

  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::setWindowFrameOfBrowsingContext):
(WebKit::WebAutomationSession::addSingleCookie):
(WebKit::WebAutomationSession::setSessionPermissions):
(WebKit::WebAutomationSession::performMouseInteraction):
(WebKit::WebAutomationSession::performKeyboardInteractions):
(WebKit::WebAutomationSession::performInteractionSequence):

  • UIProcess/Automation/WebAutomationSession.h:
  • UIProcess/ChildProcessProxy.cpp:

(WebKit::ChildProcessProxy::getLaunchOptions):

  • UIProcess/Cocoa/DownloadClient.mm:

(WebKit::DownloadClient::didStart):

  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::selectorExceptionMap):

  • UIProcess/CredentialManagement/WebCredentialsMessengerProxy.cpp:

(WebKit::WebCredentialsMessengerProxy::makeCredential):
(WebKit::WebCredentialsMessengerProxy::getAssertion):

  • UIProcess/Plugins/mac/PluginInfoStoreMac.mm:

(WebKit::PluginInfoStore::pluginsDirectories):

  • UIProcess/ResourceLoadStatisticsPersistentStorage.cpp:

(WebKit::ResourceLoadStatisticsPersistentStorage::populateMemoryStoreFromDisk):

  • UIProcess/ServiceWorkerProcessProxy.cpp:

(WebKit::ServiceWorkerProcessProxy::getLaunchOptions):
(WebKit::ServiceWorkerProcessProxy::didReceiveAuthenticationChallenge):

  • UIProcess/UserMediaProcessManager.cpp:

(WebKit::UserMediaProcessManager::willCreateMediaStream):
(WebKit::UserMediaProcessManager::endedCaptureSession):

  • UIProcess/WebBackForwardList.cpp:

(WebKit::WebBackForwardList::goToItem):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadHTMLString):
(WebKit::WebPageProxy::loadPlainTextString):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::savePDFToFileInDownloadsFolder):

  • UIProcess/WebProcessProxy.cpp:

(WebKit::WebProcessProxy::getLaunchOptions):

  • UIProcess/WebResourceLoadStatisticsStore.cpp:

(WebKit::WebResourceLoadStatisticsStore::grandfatherExistingWebsiteData):

  • UIProcess/WebResourceLoadStatisticsTelemetry.cpp:

(WebKit::notifyPages):
(WebKit::WebResourceLoadStatisticsTelemetry::calculateAndSubmit):

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView copyForWebView:]):
(-[WKContentView cutForWebView:]):
(-[WKContentView pasteForWebView:]):
(-[WKContentView selectAllForWebView:]):
(-[WKContentView deleteBackward]):
(-[WKContentView _interpretKeyEvent:isCharEvent:]):

  • UIProcess/ios/WKLegacyPDFView.mm:

(-[WKLegacyPDFView _URLForLinkAnnotation:]):

  • WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::elementForNodeHandle):
(WebKit::WebAutomationSessionProxy::didClearWindowObjectForFrame):
(WebKit::WebAutomationSessionProxy::evaluateJavaScriptFunction):

  • WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:

(WebKit::WebIDBConnectionToServer::connectionToServerLost):

  • WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDocumentGtk.cpp:

(webkit_dom_document_get_ready_state):

  • WebProcess/InjectedBundle/InjectedBundleScriptWorld.cpp:

(WebKit::uniqueWorldName):

  • WebProcess/MediaCache/WebMediaKeyStorageManager.cpp:

(WebKit::WebMediaKeyStorageManager::getMediaKeyOrigins):

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::pluginInfo):

  • WebProcess/Storage/ServiceWorkerClientFetch.cpp:

(WebKit::ServiceWorkerClientFetch::validateResponse):
(WebKit::ServiceWorkerClientFetch::didReceiveResponse):

  • WebProcess/WebCoreSupport/WebContextMenuClient.cpp:

(WebKit::WebContextMenuClient::searchWithGoogle):

  • WebProcess/WebCoreSupport/WebInspectorClient.cpp:

(WebKit::WebInspectorClient::showPaintRect):

  • WebProcess/WebPage/RemoteWebInspectorUI.cpp:

(WebKit::RemoteWebInspectorUI::initialize):
(WebKit::RemoteWebInspectorUI::didSave):
(WebKit::RemoteWebInspectorUI::didAppend):
(WebKit::RemoteWebInspectorUI::frontendLoaded):

  • WebProcess/WebPage/WebInspector.cpp:

(WebKit::WebInspector::openInNewTab):

  • WebProcess/WebPage/WebInspectorUI.cpp:

(WebKit::WebInspectorUI::setDockSide):
(WebKit::WebInspectorUI::setDockingUnavailable):
(WebKit::WebInspectorUI::setIsVisible):
(WebKit::WebInspectorUI::showConsole):
(WebKit::WebInspectorUI::showResources):
(WebKit::WebInspectorUI::showTimelines):
(WebKit::WebInspectorUI::showMainResourceForFrame):
(WebKit::WebInspectorUI::startPageProfiling):
(WebKit::WebInspectorUI::stopPageProfiling):
(WebKit::WebInspectorUI::startElementSelection):
(WebKit::WebInspectorUI::stopElementSelection):
(WebKit::WebInspectorUI::didSave):
(WebKit::WebInspectorUI::didAppend):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::loadStringImpl):
(WebKit::WebPage::loadAlternateHTMLString):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::computeAutocorrectionContext):

  • WebProcess/WebProcess.cpp:

(WebKit::getWebCoreMemoryCacheStatistics):
(WebKit::WebProcess::getWebCoreStatistics):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::initializeProcessName):

Source/WebKitLegacy:

  • Storage/StorageTracker.cpp:

(WebKit::StorageTracker::syncFileSystemAndTrackerDatabase):

  • WebCoreSupport/PingHandle.h:

Source/WebKitLegacy/mac:

  • DOM/ExceptionHandlers.mm:

(raiseDOMErrorException):

  • Plugins/Hosted/ProxyInstance.mm:

(WebKit::ProxyInstance::invokeMethod):

  • Storage/WebDatabaseProvider.mm:

(WebDatabaseProvider::indexedDatabaseDirectoryPath):

Source/WebKitLegacy/win:

  • Plugins/PluginStream.cpp:

(WebCore::PluginStream::startStream):

  • WebCoreSupport/WebContextMenuClient.cpp:

(WebContextMenuClient::searchWithGoogle):

Source/WTF:

This patch adds user-defined literal for ASCIILiteral. We can create ASCIILiteral in the form of "Hello World"_s.
And we remove public ASCIILiteral constructor. This change ensures that ASCIILiteral is created from literal.

  • WTF.xcodeproj/project.pbxproj:
  • wtf/CMakeLists.txt:
  • wtf/Indenter.h:

(WTF::Indenter::Indenter):

  • wtf/Logger.h:

(WTF::LogArgument::toString):

  • wtf/MediaTime.cpp:

(WTF::toJSONStringInternal):
(WTF::MediaTimeRange::toJSONString const):

  • wtf/linux/MemoryFootprintLinux.cpp:

(WTF::memoryFootprint):

  • wtf/text/ASCIILiteral.cpp: Copied from Source/WebCore/css/CSSUnsetValue.cpp.

(WTF::ASCIILiteral::dump const):

  • wtf/text/ASCIILiteral.h: Copied from Source/WTF/wtf/Indenter.h.

(WTF::ASCIILiteral::operator const char* const):
(WTF::ASCIILiteral::fromLiteralUnsafe):
(WTF::ASCIILiteral::null):
(WTF::ASCIILiteral::characters const):
(WTF::ASCIILiteral::ASCIILiteral):
(WTF::StringLiterals::operator _s):

  • wtf/text/WTFString.cpp:

(asciiDebug):

  • wtf/text/WTFString.h:

(WTF::operator==):
(WTF::operator!=):
(WTF::ASCIILiteral::ASCIILiteral): Deleted.
(WTF::ASCIILiteral::operator const char*): Deleted.

  • wtf/unix/LanguageUnix.cpp:

(WTF::platformLanguage):

Tools:

  • TestWebKitAPI/Tests/WTF/StringOperators.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/WTFString.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WTF/WorkerPool.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebCore/ApplicationManifestParser.cpp:

(TEST_F):

  • TestWebKitAPI/Tests/WebCore/ContentExtensions.cpp:

(TestWebKitAPI::TEST_F):

  • TestWebKitAPI/Tests/WebCore/URL.cpp:

(TestWebKitAPI::TEST_F):

  • TestWebKitAPI/Tests/WebCore/ios/PreviewLoader.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm:

(TestWebKitAPI::TEST_F):

  • TestWebKitAPI/Tests/WebCore/mac/GPUTest.h:
  • TestWebKitAPI/Tests/WebKitCocoa/ContentFilteringPlugIn.mm:

(-[MockContentFilterEnabler initWithCoder:]):

  • TestWebKitAPI/Tests/mac/ContentFiltering.mm:

(TestWebKitAPI::loadAlternateTest):

Note: See TracTimeline for information about the timeline view.