Timeline
Jul 26, 2018:
- 11:02 PM Changeset in webkit [234308] by
-
- 6 edits2 adds in branches/safari-606-branch
Cherry-pick r234291. rdar://problem/42650439
[Fullscreen] Do not create composited layers for renderers unless they are part of the fullscreen subtree.
https://bugs.webkit.org/show_bug.cgi?id=188087
<rdar://problem/42632124>
Reviewed by Simon Fraser.
Source/WebCore:
Sibling composited layers prevent battery lifetime optimizations when in fullscreen.
Test: compositing/no-compositing-when-fulll-screen-is-present.html
- rendering/RenderLayer.cpp: (WebCore::RenderLayer::isDescendantOf const):
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp: (WebCore::isDescendantOfFullScreenLayer): (WebCore::RenderLayerCompositor::requiresCompositingForWillChange const): (WebCore::RenderLayerCompositor::requiresCompositingForPosition const):
LayoutTests:
- compositing/no-compositing-when-fulll-screen-is-present-expected.txt: Added.
- compositing/no-compositing-when-fulll-screen-is-present.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:02 PM Changeset in webkit [234307] by
-
- 4 edits2 adds in branches/safari-606-branch
Cherry-pick r234275. rdar://problem/42650440
AX: nothing returned for various previous text marker APIs from one div/p node to another
https://bugs.webkit.org/show_bug.cgi?id=188071
Reviewed by Chris Fleizach.
Source/WebCore:
TextIterator is emitting an extra '\n' at the end of the <p> node and there's no
corresponding text node in the DOM tree, so we are not able to handle that for
text markers. Fixed it by ignoring the extra '\n' and anchor the text marker to
the previous child text node.
Test: accessibility/mac/text-marker-p-tags.html
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::traverseToOffsetInRange):
LayoutTests:
- accessibility/mac/text-marker-p-tags-expected.txt: Added.
- accessibility/mac/text-marker-p-tags.html: Added.
- accessibility/mac/text-marker-string-for-document-range-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234275 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:02 PM Changeset in webkit [234306] by
-
- 3 edits1 add in branches/safari-606-branch
Cherry-pick r234269. rdar://problem/42650430
arrayProtoPrivateFuncConcatMemcpy() should handle copying from an Undecided type array.
https://bugs.webkit.org/show_bug.cgi?id=188065
<rdar://problem/42515726>
Reviewed by Saam Barati.
JSTests:
- stress/regress-188065.js: Added.
Source/JavaScriptCore:
- runtime/ArrayPrototype.cpp: (JSC::clearElement): (JSC::copyElements): (JSC::arrayProtoPrivateFuncConcatMemcpy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:02 PM Changeset in webkit [234305] by
-
- 3 edits in branches/safari-606-branch/Source/WebCore
Cherry-pick r234264. rdar://problem/42650373
Switching tabs should not close PiP window
https://bugs.webkit.org/show_bug.cgi?id=188054
<rdar://problem/41212379>
Reviewed by Jon Lee.
No new tests, fixes an existing test.
Prior to r233926, calling VideoFullscreenInterfaceMac::requestHideAndExitFullscreen was a noop.
In r233926 it was updated to close the PiP window and was called from the PIPViewControllerDelegate
selectors to close the PiP window. requestHideAndExitFullscreen is also called from
WebPageProxy::viewDidLeaveWindow when the web view is removed from it window, so switching
tabs also closed the PiP window. Revert the changes to requestHideAndExitFullscreen, and add
a new method that is only used by the delegate to exit PiP.
- platform/mac/VideoFullscreenInterfaceMac.h: (WebCore::VideoFullscreenInterfaceMac::requestHideAndExitFullscreen): Make this an empty, do-nothing method.
- platform/mac/VideoFullscreenInterfaceMac.mm: (-[WebVideoFullscreenInterfaceMacObjC pipShouldClose:]): Call requestHideAndExitPiP. (-[WebVideoFullscreenInterfaceMacObjC pipActionStop:]): Ditto. (WebCore::VideoFullscreenInterfaceMac::requestHideAndExitPiP): Renamed from requestHideAndExitFullscreen. (WebCore::VideoFullscreenInterfaceMac::requestHideAndExitFullscreen): Deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234264 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:02 PM Changeset in webkit [234304] by
-
- 2 edits in branches/safari-606-branch/Source/WebKit
Cherry-pick r234262. rdar://problem/42650389
Disable Dark Mode in the Plugin process to avoid rendering issues
https://bugs.webkit.org/show_bug.cgi?id=188059
<rdar://problem/42369281>
Reviewed by Tim Horton.
Plugins generally do not support dark mode and this causes rendering issues so
disable dark mode in the plugin process.
- PluginProcess/mac/PluginProcessMac.mm: (WebKit::PluginProcess::platformInitializePluginProcess):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234262 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:02 PM Changeset in webkit [234303] by
-
- 2 edits in branches/safari-606-branch/Source/WebKit
Cherry-pick r234223. rdar://problem/42650367
[macOS] Update sandboxes for revised OpenCL calls and streaming media
https://bugs.webkit.org/show_bug.cgi?id=188013
<rdar://problem/42594262>
Reviewed by Eric Carlson.
Testing logs from recent Mojave builds shows that OpenCL is checking more CPU-specific values as part of WebKit
painting operations. We need to allow these checks in the sandbox to support these more optimized drawing operations.
I also corrected some sandbox violations I found while investigating streaming media issues.
- WebProcess/com.apple.WebProcess.sb.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234223 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:02 PM Changeset in webkit [234302] by
-
- 2 edits in branches/safari-606-branch/Source/WebKit
Cherry-pick r234081. rdar://problem/42490080
REGRESSION(r233925): Can't go into PiP twice
https://bugs.webkit.org/show_bug.cgi?id=187876
<rdar://problem/42444520>
Reviewed by Jon Lee.
We fail to enter PiP the second time because the video fullscreen interface no longer has a
model, and so gives a contentSize of 0x0. This happens because we disassociate the
interface from the model in didCleanupFullscreen. However, the interface and model can still
be re-used if they're kept alive by another client. We should delay disassociating the model
from the interface until just before the model is destroyed in removeClientForContext.
- UIProcess/Cocoa/VideoFullscreenManagerProxy.mm: (WebKit::VideoFullscreenManagerProxy::removeClientForContext): (WebKit::VideoFullscreenManagerProxy::didCleanupFullscreen):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234081 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:02 PM Changeset in webkit [234301] by
-
- 2 edits in branches/safari-606-branch/Source/WebCore
Cherry-pick r234078. rdar://problem/42490088
REGRESSION (r233974): Cannot close pip'd video; pops back into PiP.
https://bugs.webkit.org/show_bug.cgi?id=187873
Reviewed by Jon Lee.
When the PIP machinery on Mac wants to close the PIP window (due to the close button being clicked), it does
not consult our -shouldClosePiP handler; it just tells us that we're going to close. So we never setup the
necessary state on the WebProcess side and still think that our "targetIsFullscreen". When we get the "stop"
action, just request exit fullscreen, but set up the _pipState to think we're already exiting (because we are).
- platform/mac/VideoFullscreenInterfaceMac.mm: (-[WebVideoFullscreenInterfaceMacObjC pipActionStop:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234078 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:02 PM Changeset in webkit [234300] by
-
- 3 edits in branches/safari-606-branch/Source/WebCore
Cherry-pick r234051. rdar://problem/42451584
First Auto-PiP from Fullscreen too small & animation blocks
https://bugs.webkit.org/show_bug.cgi?id=187745
<rdar://problem/42316583>
Reviewed by Jon Lee.
1) When Auto-PiPing, we don't have the luxury of setting up the fullscreen state
ahead of time; we get notified that PiP has already started. The area of the code
which does this just-in-time setup needs to set the video layer's frame so that the
transform within the PiP window is correct.
2) We generate a placeholder image when going into fullscreen, but we need to do
so synchronously. Create the AVPlayerItemVideoOutput up front at AVPlayerItem creation
time wherever AVPIVO is available.
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem):
- platform/ios/VideoFullscreenInterfaceAVKit.mm: (VideoFullscreenInterfaceAVKit::doSetup):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:02 PM Changeset in webkit [234299] by
-
- 2 edits in branches/safari-606-branch/Source/WebCore
Cherry-pick r234044. rdar://problem/42433225
REGRESSION(r233969): ASSERT in -[WebAVPlayerLayer setVideoGravity:]
https://bugs.webkit.org/show_bug.cgi?id=187814
<rdar://problem/42391869>
Reviewed by Eric Carlson.
After r233969 caused models to disassociate themselves from interfaces, it is now possible that an
VideoFullscreenInterfaceAVKit can have a nil model. We should null-check, not ASSERT, now that the
assertion no longer holds true.
- platform/ios/VideoFullscreenInterfaceAVKit.mm: (-[WebAVPlayerLayer layoutSublayers]): (-[WebAVPlayerLayer resolveBounds]): (-[WebAVPlayerLayer setVideoGravity:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234044 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:02 PM Changeset in webkit [234298] by
-
- 2 edits in branches/safari-606-branch/Source/WebCore
Cherry-pick r233936. rdar://problem/42354941
Unreviewed API Test fix; restored a line inadventantly removed in r233926.
- platform/mac/VideoFullscreenInterfaceMac.mm: (-[WebVideoFullscreenInterfaceMacObjC pipDidClose:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233936 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:02 PM Changeset in webkit [234297] by
-
- 2 edits in branches/safari-606-branch/Source/WebCore
Cherry-pick r233930. rdar://problem/42354941
Unreviewed build fix after r233926; BOOL !== bool.
- platform/ios/VideoFullscreenInterfaceAVKit.mm: (VideoFullscreenInterfaceAVKit::pictureInPictureWasStartedWhenEnteringBackground const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233930 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:01 PM Changeset in webkit [234296] by
-
- 25 edits2 adds4 deletes in branches/safari-606-branch
Cherry-pick r233926. rdar://problem/42354941
PiP from Element Fullscreen should match AVKit's behavior
https://bugs.webkit.org/show_bug.cgi?id=187623
Source/WebCore:
Reviewed by Jon Lee.
PiP behavior should be defined at the WebKit2 level, and not in HTMLMediaElement:
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::enterFullscreen):
Add an accessor for pictureInPictureWasStartedWhenEnteringBackground():
- platform/cocoa/VideoFullscreenModelVideoElement.mm: (VideoFullscreenInterfaceAVKit::pictureInPictureWasStartedWhenEnteringBackground const):
Add VideoFullscreenModelClient virutal methods for PiP change notifications:
- platform/cocoa/VideoFullscreenModel.h: (WebCore::VideoFullscreenModelClient::hasVideoChanged): (WebCore::VideoFullscreenModelClient::videoDimensionsChanged): (WebCore::VideoFullscreenModelClient::willEnterPictureInPicture): (WebCore::VideoFullscreenModelClient::didEnterPictureInPicture): (WebCore::VideoFullscreenModelClient::failedToEnterPictureInPicture): (WebCore::VideoFullscreenModelClient::willExitPictureInPicture): (WebCore::VideoFullscreenModelClient::didExitPictureInPicture): (WebCore::VideoFullscreenModelClient::failedToExitPictureInPicture):
- platform/cocoa/VideoFullscreenModelVideoElement.h:
- platform/cocoa/VideoFullscreenModelVideoElement.mm: (VideoFullscreenModelVideoElement::willEnterPictureInPicture): (VideoFullscreenModelVideoElement::didEnterPictureInPicture): (VideoFullscreenModelVideoElement::failedToEnterPictureInPicture): (VideoFullscreenModelVideoElement::willExitPictureInPicture): (VideoFullscreenModelVideoElement::didExitPictureInPicture): (VideoFullscreenModelVideoElement::failedToExitPictureInPicture):
- platform/ios/VideoFullscreenInterfaceAVKit.h:
- platform/ios/VideoFullscreenInterfaceAVKit.mm: (-[WebAVPlayerLayer layoutSublayers]): (-[WebAVPlayerLayer resolveBounds]): (-[WebAVPlayerLayer setVideoGravity:]): (VideoFullscreenInterfaceAVKit::setupFullscreen): (VideoFullscreenInterfaceAVKit::presentingViewController): (VideoFullscreenInterfaceAVKit::willStartPictureInPicture): (VideoFullscreenInterfaceAVKit::didStartPictureInPicture): (VideoFullscreenInterfaceAVKit::failedToStartPictureInPicture): (VideoFullscreenInterfaceAVKit::willStopPictureInPicture): (VideoFullscreenInterfaceAVKit::didStopPictureInPicture): (VideoFullscreenInterfaceAVKit::shouldExitFullscreenWithReason): (VideoFullscreenInterfaceAVKit::doSetup):
- platform/ios/WebVideoFullscreenControllerAVKit.mm: (VideoFullscreenControllerContext::willEnterPictureInPicture): (VideoFullscreenControllerContext::didEnterPictureInPicture): (VideoFullscreenControllerContext::failedToEnterPictureInPicture): (VideoFullscreenControllerContext::willExitPictureInPicture): (VideoFullscreenControllerContext::didExitPictureInPicture): (VideoFullscreenControllerContext::failedToExitPictureInPicture):
- platform/mac/VideoFullscreenInterfaceMac.h: (WebCore::VideoFullscreenInterfaceMac::requestHideAndExitFullscreen): Deleted.
- platform/mac/VideoFullscreenInterfaceMac.mm: (-[WebVideoFullscreenInterfaceMacObjC invalidateFullscreenState]): (-[WebVideoFullscreenInterfaceMacObjC exitPIP]): (-[WebVideoFullscreenInterfaceMacObjC exitPIPAnimatingToRect:inWindow:]): (-[WebVideoFullscreenInterfaceMacObjC pipShouldClose:]): (-[WebVideoFullscreenInterfaceMacObjC pipDidClose:]): (WebCore::VideoFullscreenInterfaceMac::enterFullscreen): (WebCore::VideoFullscreenInterfaceMac::exitFullscreen): (WebCore::VideoFullscreenInterfaceMac::exitFullscreenWithoutAnimationToMode): (WebCore::VideoFullscreenInterfaceMac::requestHideAndExitFullscreen):
Source/WebCore/PAL:
Reviewed by Jon Lee.
- pal/spi/mac/PIPSPI.h:
Source/WebKit:
Reviewed by Jon Lee.
- UIProcess/Cocoa/PlaybackSessionManagerProxy.h: (WebKit::PlaybackSessionManagerProxy::controlsManagerContextId const):
- UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
- UIProcess/Cocoa/VideoFullscreenManagerProxy.mm: (WebKit::VideoFullscreenModelContext::willEnterPictureInPicture): (WebKit::VideoFullscreenModelContext::didEnterPictureInPicture): (WebKit::VideoFullscreenModelContext::failedToEnterPictureInPicture): (WebKit::VideoFullscreenModelContext::willExitPictureInPicture): (WebKit::VideoFullscreenModelContext::didExitPictureInPicture): (WebKit::VideoFullscreenModelContext::failedToExitPictureInPicture): (WebKit::VideoFullscreenManagerProxy::controlsManagerInterface):
- UIProcess/ios/fullscreen/WKFullScreenViewController.mm: (WKFullScreenViewControllerVideoFullscreenModelClient::setParent): (WKFullScreenViewControllerVideoFullscreenModelClient::setInterface): (WKFullScreenViewControllerVideoFullscreenModelClient::interface const): (-[WKFullScreenViewController initWithWebView:]): (-[WKFullScreenViewController dealloc]): (-[WKFullScreenViewController videoControlsManagerDidChange]): (-[WKFullScreenViewController ensurePiPAnimator]): (-[WKFullScreenViewController willEnterPictureInPicture]): (-[WKFullScreenViewController didEnterPictureInPicture]): (-[WKFullScreenViewController failedToEnterPictureInPicture]): (-[WKFullScreenViewController loadView]): (-[WKFullScreenViewController viewWillAppear:]):
- UIProcess/Cocoa/WebViewImpl.mm: (WebKit::WebViewImpl::videoControlsManagerDidChange):
- UIProcess/mac/WKFullScreenWindowController.h:
- UIProcess/mac/WKFullScreenWindowController.mm: (WebKit::WKFullScreenWindowControllerVideoFullscreenModelClient::setParent): (WebKit::WKFullScreenWindowControllerVideoFullscreenModelClient::setInterface): (WebKit::WKFullScreenWindowControllerVideoFullscreenModelClient::interface const): (-[WKFullScreenWindowController initWithWindow:webView:page:]): (-[WKFullScreenWindowController dealloc]): (-[WKFullScreenWindowController videoControlsManagerDidChange]): (-[WKFullScreenWindowController willEnterPictureInPicture]):
Tools:
<rdar://problem/41212379>
Reviewed by Jon Lee.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.html: Added.
- TestWebKitAPI/Tests/WebKitCocoa/ExitFullscreenOnEnterPiP.mm: Added. (-[ExitFullscreenOnEnterPiPUIDelegate _webView:hasVideoInPictureInPictureDidChange:]): (-[ExitFullscreenOnEnterPiPUIDelegate _webViewDidEnterFullscreen:]): (-[ExitFullscreenOnEnterPiPUIDelegate _webViewDidExitFullscreen:]): (TestWebKitAPI::TEST):
LayoutTests:
Reviewed by Jon Lee.
- TestExpectations:
- media/fullscreen-video-going-into-pip-expected.txt: Removed.
- media/fullscreen-video-going-into-pip.html: Removed.
- media/video-contained-in-fullscreen-element-going-into-pip-expected.txt: Removed.
- media/video-contained-in-fullscreen-element-going-into-pip.html: Removed.
- platform/mac-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233926 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 11:01 PM Changeset in webkit [234295] by
-
- 2 edits in branches/safari-606-branch/Source/WebKit
Cherry-pick r233925. rdar://problem/42354959
Dissociate the VideoFullscreenInterface from its VideoFullscreenModel before removing it from the manager
https://bugs.webkit.org/show_bug.cgi?id=187775
<rdar://problem/42343229>
Reviewed by Jon Lee.
- UIProcess/Cocoa/VideoFullscreenManagerProxy.mm: (WebKit::VideoFullscreenManagerProxy::didCleanupFullscreen):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233925 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:25 PM Changeset in webkit [234294] by
-
- 7 edits in branches/safari-606-branch/Source
Versioning.
- 10:06 PM Changeset in webkit [234293] by
-
- 23 edits in trunk
[INTL] Remove INTL sub-feature compile flags
https://bugs.webkit.org/show_bug.cgi?id=188081
Patch by Andy VanWagoner <andy@vanwagoner.family> on 2018-07-26
Reviewed by Michael Catanzaro.
.:
- Source/cmake/OptionsJSCOnly.cmake:
- Source/cmake/WebKitFeatures.cmake:
PerformanceTests:
Removed old and unused i18n flag.
- StitchMarker/wtf/FeatureDefines.h:
Source/JavaScriptCore:
Removed ENABLE_INTL_NUMBER_FORMAT_TO_PARTS and ENABLE_INTL_PLURAL_RULES flags.
The runtime flags are still present, and should be relied on instead.
The defines for ICU features have also been updated to match HAVE() style.
- Configurations/FeatureDefines.xcconfig:
- runtime/IntlPluralRules.cpp:
(JSC::IntlPluralRules::resolvedOptions):
(JSC::IntlPluralRules::select):
- runtime/IntlPluralRules.h:
- runtime/Options.h:
Source/WebCore:
Compile time feature flags for INTL sub features were removed, and are covered by existing tests.
- Configurations/FeatureDefines.xcconfig:
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit:
- Configurations/FeatureDefines.xcconfig:
Source/WebKitLegacy/mac:
- Configurations/FeatureDefines.xcconfig:
Source/WTF:
Removed INTL sub-feature compile flags, and an old unused i18n flag.
- wtf/FeatureDefines.h:
Tools:
- Scripts/webkitperl/FeatureList.pm:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
- 9:13 PM Changeset in webkit [234292] by
-
- 2 edits in trunk/LayoutTests
[Curl] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=188090
Unreviewed test gardening.
Rearrange http test section.
- platform/wincairo/TestExpectations:
- 9:02 PM Changeset in webkit [234291] by
-
- 6 edits2 adds in trunk
[Fullscreen] Do not create composited layers for renderers unless they are part of the fullscreen subtree.
https://bugs.webkit.org/show_bug.cgi?id=188087
<rdar://problem/42632124>
Reviewed by Simon Fraser.
Source/WebCore:
Sibling composited layers prevent battery lifetime optimizations when in fullscreen.
Test: compositing/no-compositing-when-fulll-screen-is-present.html
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::isDescendantOf const):
- rendering/RenderLayer.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::isDescendantOfFullScreenLayer):
(WebCore::RenderLayerCompositor::requiresCompositingForWillChange const):
(WebCore::RenderLayerCompositor::requiresCompositingForPosition const):
LayoutTests:
- compositing/no-compositing-when-fulll-screen-is-present-expected.txt: Added.
- compositing/no-compositing-when-fulll-screen-is-present.html: Added.
- 6:50 PM Changeset in webkit [234290] by
-
- 4 edits1 add in trunk
Loading a file URL and then issuing a reload right away causes the load to fail due to sandboxing
https://bugs.webkit.org/show_bug.cgi?id=188078
<rdar://problem/42562493>
Reviewed by Geoff Garen.
Source/WebKit:
When WebPageProxy::loadFile() is called, we create a SandboxExtension::Handle for the resource path provided
by the caller and pass it to the WebProcess. WebPage::loadRequest() then calls SandboxExtensionTracker::beginLoad()
to store this handle in m_provisionalSandboxExtension for later consumption.
If a reload is issued before this sandbox extension has been consumed, then the following happens:
- WebPageProxy::reload() does NOT create a SandboxExtension::Handle because it has already issued one earlier. maybeInitializeSandboxExtensionHandle() returns early due to m_process->hasAssumedReadAccessToURL(url) check.
- WebPage::reload() then calls SandboxExtensionTracker::beginLoad() with a null handle, which overwrites the previous m_provisionalSandboxExtension its needs.
- The load fails because the WebContent process is missing the sandbox extension.
To address the issue, SandboxExtensionTracker::beginLoad() is updated to only overwrite m_provisionalSandboxExtension
if the new handle is not null. This avoids inadvertently clearing a valid sandbox extension we may need for the load,
since the UIProcess sends us a null handle if it previously sent us a sandbox extension for the path in question.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::SandboxExtensionTracker::beginLoad):
Tools:
Add API test coverage. It exercises the right code path but unfortunately is not yet a regression
test because TestWebKitAPI does not appear to be sandboxed (rdar://problem/42638129).
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/LoadFileThenReload.mm: Added.
(-[LoadFileThenReloadDelegate webView:didFinishNavigation:]):
(-[LoadFileThenReloadDelegate webView:didFailProvisionalNavigation:withError:]):
(-[LoadFileThenReloadDelegate webView:didFailNavigation:withError:]):
(TEST):
- 6:37 PM Changeset in webkit [234289] by
-
- 22 edits7 deletes in trunk
Unreviewed, rolling out r234281.
Broke internal builds.
Reverted changeset:
"[Datalist] Add button to TextFieldInputs with a datalist"
https://bugs.webkit.org/show_bug.cgi?id=187741
https://trac.webkit.org/changeset/234281
- 6:24 PM Changeset in webkit [234288] by
-
- 6 edits in trunk/Source
It should be possible to use WTF::CallbackAggregator from a background thread
https://bugs.webkit.org/show_bug.cgi?id=188084
Reviewed by Alex Christensen.
Source/WebKit:
This code was passing CallbackAggregator objects for background thread and not being
careful on which thread the CallbackAggregator gets destroyed. This patch fixes this
since the CallbackAggregator destructor no longer takes care of dispatching to the
main thread.
- NetworkProcess/cache/CacheStorageEngine.cpp:
(WebKit::CacheStorage::Engine::clearAllCaches):
(WebKit::CacheStorage::Engine::clearCachesForOrigin):
Source/WTF:
Make WTF::CallbackAggregator usable on background threads by updating its destructor to call the
completion handler on whatever thread it is destroyed on, instead of always dispatching to the
main thread before calling the completion handler.
Existing CallbackAggregator users that deal with threads have been updated to make sure they
destroy the CallbackAggregator on the expected thread.
This will allow us to use CallbackAggregator in the ResourceLoadStatisticsMemoryStore, which lives
on a background WorkQueue.
- wtf/CallbackAggregator.h:
(WTF::CallbackAggregator::~CallbackAggregator):
(WTF::CallbackAggregator::CallbackAggregator):
- 6:11 PM Changeset in webkit [234287] by
-
- 1 copy in tags/Safari-606.1.32
Tag Safari-606.1.32.
- 6:11 PM Changeset in webkit [234286] by
-
- 1 delete in tags/Safari-606.1.32
Delete tag
- 6:02 PM Changeset in webkit [234285] by
-
- 14 edits in branches/safari-606-branch
Cherry-pick r234272. rdar://problem/42645434
Unreviewed, rolling out r234181 and r234189.
https://bugs.webkit.org/show_bug.cgi?id=188075
These are not needed right now (Requested by thorton on
#webkit).
Reverted changesets:
"Enable Web Content Filtering on watchOS"
https://bugs.webkit.org/show_bug.cgi?id=187979
https://trac.webkit.org/changeset/234181
"HAVE(PARENTAL_CONTROLS) should be true on watchOS"
https://bugs.webkit.org/show_bug.cgi?id=187985
https://trac.webkit.org/changeset/234189
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234272 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 5:42 PM Changeset in webkit [234284] by
-
- 2 edits in trunk/Source/JavaScriptCore
[JSC] Dump IndexingMode in Structure
https://bugs.webkit.org/show_bug.cgi?id=188085
Reviewed by Keith Miller.
Dump IndexingMode instead of IndexingType.
- runtime/Structure.cpp:
(JSC::Structure::dump const):
- 4:30 PM Changeset in webkit [234283] by
-
- 1 copy in tags/Safari-606.1.32
Tag Safari-606.1.32.
- 4:19 PM Changeset in webkit [234282] by
-
- 2 edits in trunk/Tools
Add Aaron Chu as a committer to contributors.json
https://bugs.webkit.org/show_bug.cgi?id=188066
Unreviwed. Added myself as committer.
- Scripts/webkitpy/common/config/contributors.json:
- 4:12 PM Changeset in webkit [234281] by
-
- 22 edits1 copy10 adds in trunk
[Datalist] Add button to TextFieldInputs with a datalist
https://bugs.webkit.org/show_bug.cgi?id=187741
Patch by Aditya Keerthi <Aditya Keerthi> on 2018-07-26
Reviewed by Tim Horton.
Source/WebCore:
TextFieldInputs that have an associated datalist element should be drawn as
combo boxes. However, we cannot use NSComboBox for this control, as NSComboBox
is not height-resizable. Furthermore, the input should also be able to contain
additional elements, such as the stepper for type=number and the cancel button
for type=search. For these reasons, we draw a button at the end of the input,
mimicking appearance of a combo box.
The list-button -webkit-appearance value was added to display the new button.
Tests: fast/forms/datalist/datalist-searchinput-appearance.html
fast/forms/datalist/datalist-textinput-appearance.html
- Resources/ListButtonArrow.png: Added.
- Resources/ListButtonArrow@2x.png: Added.
- WebCore.xcodeproj/project.pbxproj:
- css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
- css/CSSProperties.json:
- css/CSSValueKeywords.in:
- css/html.css:
(input::-webkit-list-button):
- html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::dataListButtonElement const):
(WebCore::HTMLInputElement::isShowingList const):
- html/HTMLInputElement.h:
- html/InputType.h:
(WebCore::InputType::dataListButtonElement const):
(WebCore::InputType::isShowingList const):
- html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::needsContainer const):
(WebCore::TextFieldInputType::createShadowSubtree):
(WebCore::TextFieldInputType::destroyShadowSubtree):
(WebCore::TextFieldInputType::listAttributeTargetChanged):
(WebCore::TextFieldInputType::dataListButtonElement const):
(WebCore::TextFieldInputType::dataListButtonElementWasClicked):
(WebCore::TextFieldInputType::didCloseSuggestions):
(WebCore::TextFieldInputType::isShowingList const):
- html/TextFieldInputType.h:
- html/shadow/DataListButtonElement.cpp: Added.
(WebCore::DataListButtonElement::create):
(WebCore::DataListButtonElement::DataListButtonElement):
(WebCore::DataListButtonElement::~DataListButtonElement):
(WebCore::DataListButtonElement::defaultEventHandler):
- html/shadow/DataListButtonElement.h: Added.
- platform/ThemeTypes.h:
- rendering/RenderTheme.cpp:
(WebCore::RenderTheme::adjustStyle):
(WebCore::RenderTheme::adjustListButtonStyle const):
- rendering/RenderTheme.h:
- rendering/RenderThemeMac.h:
- rendering/RenderThemeMac.mm:
(-[WebListButtonCell drawWithFrame:inView:]):
(WebCore::RenderThemeMac::paintListButtonForInput):
(WebCore::RenderThemeMac::adjustListButtonStyle const):
(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::paintSearchField):
(WebCore::RenderThemeMac::paintSearchFieldCancelButton):
(WebCore::RenderThemeMac::listButton const):
Source/WebCore/PAL:
- pal/spi/cocoa/NSColorSPI.h: Added NSColorGetUserAccentColor().
Source/WebInspectorUI:
Add keyword completion for 'list-button'.
- UserInterface/External/CodeMirror/css.js:
- UserInterface/Models/CSSKeywordCompletions.js:
LayoutTests:
Added tests to verify appearance of TextFieldInputs with a datalist.
- fast/forms/datalist/datalist-searchinput-appearance.html: Added.
- fast/forms/datalist/datalist-textinput-appearance.html: Added.
- platform/mac/fast/forms/datalist/datalist-searchinput-appearance-expected.png: Added.
- platform/mac/fast/forms/datalist/datalist-searchinput-appearance-expected.txt: Added.
- platform/mac/fast/forms/datalist/datalist-textinput-appearance-expected.png: Added.
- platform/mac/fast/forms/datalist/datalist-textinput-appearance-expected.txt: Added.
- 3:51 PM Changeset in webkit [234280] by
-
- 3 edits in trunk/Tools
[ews-build] Add build step to run API Tests
https://bugs.webkit.org/show_bug.cgi?id=188079
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-build/steps.py:
(TestWithFailureCount): Common class for various tests with failure count.
(TestWithFailureCount.start): Configure Buildbot's logobserver.
(TestWithFailureCount.commandComplete): Updates the failure count.
(TestWithFailureCount.evaluateCommand): Set the step status appropriately.
(TestWithFailureCount.getResultSummary): Set the step summary appropriately.
(RunAPITests): Build step to run API tests.
(RunAPITests.countFailures): Count the failures by parsing the output.
- BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
- 3:16 PM Changeset in webkit [234279] by
-
- 4 edits2 adds in trunk
[Web Animations] Accelerated animations don't respect a positive delay value
https://bugs.webkit.org/show_bug.cgi?id=186930
<rdar://problem/41393393>
Reviewed by Dean Jackson.
Source/WebCore:
Test: webanimations/accelerated-animation-with-delay.html
We would mistakenly clear the list of pending accelerated actions in KeyframeEffectReadOnly::applyPendingAcceleratedActions()
even if we failed to proceed because of the target element's renderer not being composited yet. Now, we clear the list after
we've established we can apply them, and if we can't we inform the animation with a call to acceleratedStateDidChange() which
will in turn call into the document timeline so that we may consider these animations on the next tick.
For this to work correctly we must make a change to DocumentTimeline::applyPendingAcceleratedAnimations() which only cleared
its list of pending accelerated animations _after_ iterating through them, which would be problematic since we would now add
animations to this list. That list is now copied and cleared prior to iterating through its members.
We also fix the naming of the m_pendingAcceleratedActions copy in KeyframeEffectReadOnly::applyPendingAcceleratedActions()
to have a more similar name.
- animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::applyPendingAcceleratedAnimations):
- animation/KeyframeEffectReadOnly.cpp:
(WebCore::KeyframeEffectReadOnly::applyPendingAcceleratedActions):
LayoutTests:
Creating a new test that runs an accelerated animation on a non-positioned element with a small
positive delay. Prior to this patch, the element would move slightly when the delay elapses but
wouldn't animate towards the target value. With this patch, it animatea correctly. To check
that it does animate, we add a cache over the element except for the first 25px which is the area
within which it might have moved prior to this patch. This way the test only passes if the element
is fully hidden by the cache.
- webanimations/accelerated-animation-with-delay-expected.html: Added.
- webanimations/accelerated-animation-with-delay.html: Added.
- 3:00 PM Changeset in webkit [234278] by
-
- 68 edits in trunk
String(View) should have a splitAllowingEmptyEntries function instead of a flag parameter
https://bugs.webkit.org/show_bug.cgi?id=187963
Reviewed by Alex Christensen.
Source/JavaScriptCore:
- inspector/InspectorBackendDispatcher.cpp:
(Inspector::BackendDispatcher::dispatch):
- jsc.cpp:
(ModuleName::ModuleName):
(resolvePath):
- runtime/IntlObject.cpp:
(JSC::canonicalizeLanguageTag):
(JSC::removeUnicodeLocaleExtension):
Update split/splitAllowingEmptyEntries usage.
Source/WebCore:
- Modules/applepay/cocoa/PaymentContactCocoa.mm:
(WebCore::convert):
- Modules/cache/DOMCache.cpp:
(WebCore::hasResponseVaryStarHeaderValue):
- Modules/cache/DOMCacheEngine.cpp:
(WebCore::DOMCacheEngine::queryCacheMatch):
- Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::filterICECandidate):
(WebCore::PeerConnectionBackend::filterSDP const):
- Modules/websockets/WebSocketHandshake.cpp:
(WebCore::WebSocketHandshake::checkResponseHeaders):
- accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::determineARIADropEffects):
- accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::determineARIADropEffects):
- accessibility/AccessibilityRenderObject.h:
- accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
- editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::shouldCancelDefaultAction):
- editing/markup.cpp:
(WebCore::fillContainerFromString):
(WebCore::createFragmentFromText):
- html/EmailInputType.cpp:
(WebCore::EmailInputType::typeMismatchFor const):
(WebCore::EmailInputType::sanitizeValue const):
- html/HTMLInputElement.cpp:
(WebCore::parseAcceptAttribute):
- html/ValidationMessage.cpp:
(WebCore::ValidationMessage::setMessageDOMAndStartTimer):
- html/canvas/WebGLRenderingContextBase.cpp:
(WebCore::WebGLRenderingContextBase::compileShader):
- inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::nodeForPath):
- loader/FormSubmission.cpp:
(WebCore::encodingFromAcceptCharset):
- loader/ResourceTiming.cpp:
(WebCore::passesTimingAllowCheck):
- page/WindowFeatures.cpp:
(WebCore::parseDisabledAdaptations):
(WebCore::parseDialogFeaturesMap):
- platform/URL.cpp:
(WebCore::isIPv4Address):
(WebCore::isIPv6Address):
- platform/graphics/GLContext.cpp:
(WebCore::GLContext::version):
- platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::patternToFamilies):
- platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::extractGStreamerOptionsFromCommandLine):
- platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::Extensions3DOpenGLCommon):
(WebCore::Extensions3DOpenGLCommon::initializeAvailableExtensions):
- platform/gtk/PasteboardHelper.cpp:
(WebCore::PasteboardHelper::fillSelectionData):
- platform/gtk/SelectionData.cpp:
(WebCore::SelectionData::setURIList):
- platform/network/CacheValidation.cpp:
(WebCore::collectVaryingRequestHeaders):
- platform/network/HTTPParsers.cpp:
(WebCore::filenameFromHTTPContentDisposition):
(WebCore::parseXFrameOptionsHeader):
(WebCore::parseAccessControlExposeHeadersAllowList):
- platform/network/curl/CookieUtil.cpp:
(WebCore::CookieUtil::parseCookieHeader):
- platform/network/curl/CurlCacheEntry.cpp:
(WebCore::CurlCacheEntry::loadResponseHeaders):
- platform/network/curl/CurlCacheManager.cpp:
(WebCore::CurlCacheManager::loadIndex):
- platform/network/soup/CookieJarSoup.cpp:
(WebCore::setCookiesFromDOM):
- svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::parseAttribute):
- svg/SVGToOTFFontConversion.cpp:
(WebCore::SVGToOTFFontConverter::appendOS2Table):
- svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::parseBeginOrEnd):
- testing/MockCDMFactory.cpp:
(WebCore::MockCDM::sanitizeResponse const):
(WebCore::MockCDMInstance::updateLicense):
Update split/splitAllowingEmptyEntries usage.
Source/WebDriver:
- WebDriverService.cpp:
(WebDriver::WebDriverService::findCommand):
- glib/WebDriverServiceGLib.cpp:
(WebDriver::parseVersion):
Update split/splitAllowingEmptyEntries usage.
Source/WebKit:
- NetworkProcess/cache/CacheStorageEngineCache.cpp:
(WebKit::CacheStorage::updateVaryInformation):
- NetworkProcess/capture/NetworkCaptureManager.cpp:
(WebKit::NetworkCapture::Manager::fuzzyMatchURLs):
- Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getPluginInfoFromPropertyLists):
(WebKit::PluginVersion::parse):
- Shared/Plugins/Netscape/unix/NetscapePluginModuleUnix.cpp:
(WebKit::NetscapePluginModule::parseMIMEDescription):
- Shared/Plugins/unix/PluginSearchPath.cpp:
(WebKit::pluginsDirectories):
- Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::initializeSandbox):
- UIProcess/API/gtk/WebKitRemoteInspectorProtocolHandler.cpp:
- UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::fileCanBeAcceptedForUpload):
- UIProcess/Launcher/glib/ProcessLauncherGLib.cpp:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
- UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::scanPlugin):
- WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::isTransparentSilverlightBackgroundValue):
Update split/splitAllowingEmptyEntries usage.
Source/WebKitLegacy/win:
- Plugins/PluginPackageWin.cpp:
(WebCore::PluginPackage::fetchInfo):
Update split/splitAllowingEmptyEntries usage.
Source/WTF:
- wtf/Assertions.cpp:
Update split/splitAllowingEmptyEntries usage.
- wtf/text/StringView.h:
(WTF::StringView::splitAllowingEmptyEntries const):
- wtf/text/WTFString.cpp:
(WTF::String::splitInternal const):
(WTF::String::split const):
(WTF::String::splitAllowingEmptyEntries const):
- wtf/text/WTFString.h:
(WTF::String::split const):
Introduce splitAllowingEmptyEntries instead of boolean or enum parameter.
Tools:
- TestWebKitAPI/Tests/WTF/WTFString.cpp:
Add tests for String::split and String::splitAllowingEmptyEntries.
- TestWebKitAPI/Tests/WTF/StringView.cpp:
- WebKitTestRunner/TestController.cpp:
(WTR::updateTestOptionsFromTestHeader):
Update split/splitAllowingEmptyEntries usage.
- 2:50 PM Changeset in webkit [234277] by
-
- 2 edits in trunk/LayoutTests
[Curl] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=188076
Unreviewed test gardening.
Mark diskcache test "Failure" for upcoming fix:
- platform/wincairo/TestExpectations:
- http/tests/cache/disk-cache/disk-cache-302-status-code.html [ Failure ]
- 2:44 PM Changeset in webkit [234276] by
-
- 2 edits in trunk/Source/WebKit
Fix assertions introduced in r234210
https://bugs.webkit.org/show_bug.cgi?id=188074
Reviewed by Chris Dumez.
There is a client that uses WKFramePolicyListenerUseWithPolicies to send website policies as
a response to the WKPageNavigationClient's decidePolicyForNavigationResponse. That is wasting
effort to generate policies that don't change anything. Once that client adopts WKWebView
they won't be able to do this any more, so temporarily remove the assertion.
Also, make the assertion about process swapping a release assert to prevent that client
from adopting WKFramePolicyListenerUseInNewProcessWithPolicies for navigation responses.
It should only be used for navigation actions.
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
- 2:34 PM Changeset in webkit [234275] by
-
- 4 edits2 adds in trunk
AX: nothing returned for various previous text marker APIs from one div/p node to another
https://bugs.webkit.org/show_bug.cgi?id=188071
Reviewed by Chris Fleizach.
Source/WebCore:
TextIterator is emitting an extra '\n' at the end of the <p> node and there's no
corresponding text node in the DOM tree, so we are not able to handle that for
text markers. Fixed it by ignoring the extra '\n' and anchor the text marker to
the previous child text node.
Test: accessibility/mac/text-marker-p-tags.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::traverseToOffsetInRange):
LayoutTests:
- accessibility/mac/text-marker-p-tags-expected.txt: Added.
- accessibility/mac/text-marker-p-tags.html: Added.
- accessibility/mac/text-marker-string-for-document-range-expected.txt:
- 2:32 PM Changeset in webkit [234274] by
-
- 2 edits in trunk/Source/WTF
Remove unused/undefined String::appendInternal
https://bugs.webkit.org/show_bug.cgi?id=188063
Patch by Sam Weinig <sam@webkit.org> on 2018-07-26
Reviewed by Daniel Bates.
- wtf/text/WTFString.h:
String::appendInternal is declared in WTFString.h, but is never used
and and never even defined. Remove it.
- 2:14 PM Changeset in webkit [234273] by
-
- 7 edits in tags/Safari-606.1.28.1/Source
Versioning.
- 2:11 PM Changeset in webkit [234272] by
-
- 14 edits in trunk
Unreviewed, rolling out r234181 and r234189.
https://bugs.webkit.org/show_bug.cgi?id=188075
These are not needed right now (Requested by thorton on
#webkit).
Reverted changesets:
"Enable Web Content Filtering on watchOS"
https://bugs.webkit.org/show_bug.cgi?id=187979
https://trac.webkit.org/changeset/234181
"HAVE(PARENTAL_CONTROLS) should be true on watchOS"
https://bugs.webkit.org/show_bug.cgi?id=187985
https://trac.webkit.org/changeset/234189
- 2:05 PM Changeset in webkit [234271] by
-
- 1 copy in tags/Safari-606.1.28.1
New tag.
- 1:30 PM Changeset in webkit [234270] by
-
- 4 edits in trunk/Source
Use the Page's appearance when converting pasteboard attributed strings.
https://bugs.webkit.org/show_bug.cgi?id=188067
rdar://problem/42632246
Reviewed by Wenson Hsieh.
Source/WebCore:
- editing/cocoa/WebContentReaderCocoa.mm:
(WebCore::createFragment): Create a LocalDefaultSystemAppearance based on the Page.
Source/WebKitLegacy/mac:
- WebCoreSupport/WebEditorClient.mm:
(_WebCreateFragment): Create a LocalDefaultSystemAppearance based on the Page.
- 12:49 PM Changeset in webkit [234269] by
-
- 3 edits1 add in trunk
arrayProtoPrivateFuncConcatMemcpy() should handle copying from an Undecided type array.
https://bugs.webkit.org/show_bug.cgi?id=188065
<rdar://problem/42515726>
Reviewed by Saam Barati.
JSTests:
- stress/regress-188065.js: Added.
Source/JavaScriptCore:
- runtime/ArrayPrototype.cpp:
(JSC::clearElement):
(JSC::copyElements):
(JSC::arrayProtoPrivateFuncConcatMemcpy):
- 12:49 PM Changeset in webkit [234268] by
-
- 8 edits in trunk/Source/WebKit
ERROR: Unhandled web process message 'WebPage:SetUseDarkAppearance' when browsing in dark mode
https://bugs.webkit.org/show_bug.cgi?id=188028
Reviewed by Wenson Hsieh.
The issue was that the WebViewImpl constructor was calling setUseDarkAppearance() *before* calling
initializeWebPage(), which would cause us to send IPC the WebContent process for a pageID that does
not exist on WebProcess side yet.
To address the issue, the WebViewImpl constructor no longer calls setUseDarkAppearance() and WebPageProxy
no longer holds a flag indicates is dark appearance is used. Instead, the WebPageProxy asks the WebView
for the value whenever it needs to, via the PageClient.
- UIProcess/Cocoa/WebViewImpl.h:
- UIProcess/Cocoa/WebViewImpl.mm:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::effectiveAppearanceDidChange):
(WebKit::WebViewImpl::setUseDarkAppearance): Deleted.
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::creationParameters):
(WebKit::WebPageProxy::useDarkAppearance const):
(WebKit::WebPageProxy::effectiveAppearanceDidChange):
(WebKit::WebPageProxy::showPlaybackTargetPicker):
(WebKit::WebPageProxy::setUseDarkAppearance): Deleted.
- UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::useDarkAppearance const): Deleted.
- UIProcess/mac/PageClientImplMac.h:
- UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::effectiveAppearanceIsDark const):
- 10:50 AM Changeset in webkit [234267] by
-
- 2 edits in trunk/LayoutTests
Layout Test webgl/2.0.0/conformance2/glsl3/compound-assignment-type-combination.html is timing out on mac Debug
https://bugs.webkit.org/show_bug.cgi?id=188061
Unreviewed test gardening.
Marked test as [ Slow ].
- platform/mac/TestExpectations:
- 10:09 AM Changeset in webkit [234266] by
-
- 2 edits in branches/safari-606-branch/LayoutTests
Cherry-pick r234263. rdar://problem/42387347
Unreviewed, update TestExpectations for macOS WK1.
- platform/mac-wk1/TestExpectations:
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@234263 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:04 AM Changeset in webkit [234265] by
-
- 2 edits in trunk/Source/WebKit
Remove a forward protocol declaration of '_WKWebViewPrintProvider'
https://bugs.webkit.org/show_bug.cgi?id=188012
<rdar://problem/42309526>
Reviewed by Darin Adler.
@procotol() expressions emit invalid protocol metadata when used with forward @protocol declarations.
Clang is going to make it an error for using a forward-declared protocol in a @protocol expression, so
we need to stop doing this.
- UIProcess/API/Cocoa/WKWebViewInternal.h:
- 10:03 AM Changeset in webkit [234264] by
-
- 3 edits in trunk/Source/WebCore
Switching tabs should not close PiP window
https://bugs.webkit.org/show_bug.cgi?id=188054
<rdar://problem/41212379>
Reviewed by Jon Lee.
No new tests, fixes an existing test.
Prior to r233926, calling VideoFullscreenInterfaceMac::requestHideAndExitFullscreen was a noop.
In r233926 it was updated to close the PiP window and was called from the PIPViewControllerDelegate
selectors to close the PiP window. requestHideAndExitFullscreen is also called from
WebPageProxy::viewDidLeaveWindow when the web view is removed from it window, so switching
tabs also closed the PiP window. Revert the changes to requestHideAndExitFullscreen, and add
a new method that is only used by the delegate to exit PiP.
- platform/mac/VideoFullscreenInterfaceMac.h:
(WebCore::VideoFullscreenInterfaceMac::requestHideAndExitFullscreen): Make this an empty,
do-nothing method.
- platform/mac/VideoFullscreenInterfaceMac.mm:
(-[WebVideoFullscreenInterfaceMacObjC pipShouldClose:]): Call requestHideAndExitPiP.
(-[WebVideoFullscreenInterfaceMacObjC pipActionStop:]): Ditto.
(WebCore::VideoFullscreenInterfaceMac::requestHideAndExitPiP): Renamed from requestHideAndExitFullscreen.
(WebCore::VideoFullscreenInterfaceMac::requestHideAndExitFullscreen): Deleted.
- 10:02 AM Changeset in webkit [234263] by
-
- 2 edits in trunk/LayoutTests
Unreviewed, update TestExpectations for macOS WK1.
- platform/mac-wk1/TestExpectations:
- 9:59 AM Changeset in webkit [234262] by
-
- 2 edits in trunk/Source/WebKit
Disable Dark Mode in the Plugin process to avoid rendering issues
https://bugs.webkit.org/show_bug.cgi?id=188059
<rdar://problem/42369281>
Reviewed by Tim Horton.
Plugins generally do not support dark mode and this causes rendering issues so
disable dark mode in the plugin process.
- PluginProcess/mac/PluginProcessMac.mm:
(WebKit::PluginProcess::platformInitializePluginProcess):
- 9:15 AM Changeset in webkit [234261] by
-
- 9 edits in trunk/Source/WebKit
WebSiteData-related methods should take in CompletionHandlers instead of Functions
https://bugs.webkit.org/show_bug.cgi?id=188027
Reviewed by Alex Christensen.
WebSiteData-related methods should take in CompletionHandlers instead of Functions since
they are need to be called and are only called once.
- UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::fetchWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteDataForOrigins):
- UIProcess/Network/NetworkProcessProxy.h:
- UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::fetchWebsiteData):
(WebKit::PluginProcessProxy::deleteWebsiteData):
(WebKit::PluginProcessProxy::deleteWebsiteDataForHostNames):
- UIProcess/Plugins/PluginProcessProxy.h:
- UIProcess/Storage/StorageProcessProxy.cpp:
(WebKit::StorageProcessProxy::fetchWebsiteData):
(WebKit::StorageProcessProxy::deleteWebsiteData):
(WebKit::StorageProcessProxy::deleteWebsiteDataForOrigins):
- UIProcess/Storage/StorageProcessProxy.h:
- UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::deleteWebsiteDataForTopPrivatelyControlledDomainsInAllPersistentDataStores):
(WebKit::WebProcessProxy::topPrivatelyControlledDomainsWithWebsiteData):
(WebKit::WebProcessProxy::fetchWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteDataForOrigins):
- UIProcess/WebProcessProxy.h:
- 9:01 AM Changeset in webkit [234260] by
-
- 6 edits2 adds2 deletes in trunk
JSC: Intl API should ignore encoding when parsing BCP 47 language tag from ISO 15897 locale string (passed via LANG)
https://bugs.webkit.org/show_bug.cgi?id=167991
Patch by Andy VanWagoner <andy@vanwagoner.family> on 2018-07-26
Reviewed by Michael Catanzaro.
Source/JavaScriptCore:
Improved the conversion of ICU locales to BCP47 tags, using their preferred method.
Checked locale.isEmpty() before returning it from defaultLocale, so there should be
no more cases where you might have an invalid locale come back from resolveLocale.
- runtime/IntlObject.cpp:
(JSC::convertICULocaleToBCP47LanguageTag):
(JSC::defaultLocale):
(JSC::lookupMatcher):
- runtime/IntlObject.h:
- runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::intlCollatorAvailableLocales):
(JSC::JSGlobalObject::intlDateTimeFormatAvailableLocales):
(JSC::JSGlobalObject::intlNumberFormatAvailableLocales):
(JSC::JSGlobalObject::intlPluralRulesAvailableLocales):
LayoutTests:
Replaced expecting throwing a runtime error to avoid a crash, with testing for good default locale fallback behavior.
- js/intl-default-locale-expected.txt: Added.
- js/intl-default-locale.html: Added.
- js/intl-invalid-locale-crash-expected.txt: Removed.
- js/intl-invalid-locale-crash.html: Removed.
- platform/win/TestExpectations:
- 8:44 AM Changeset in webkit [234259] by
-
- 9 edits in trunk/Source/WebKit
[GTK][WPE] Improve the way request displayRefresh notifications
https://bugs.webkit.org/show_bug.cgi?id=188005
Reviewed by Žan Doberšek.
Add a new interface ThreadedDisplayRefreshMonitor::Client and use it to pipe the the
requestDisplayRefreshMonitorUpdate and handleDisplayRefreshMonitorUpdate to the
ThreadedCoordinatedLayerTreeHost.
In response to requestDisplayRefreshMonitorUpdate, the LayerTreeHost will force a layer
flush that in the end causes a repaint, which generates the requested display refresh
event.
In response to handleDisplayRefreshMonitorUpdate, the call to renderNextFrame will happen,
and if the DisplayRefreshMonitor has been rescheduled, renderNextFrame will also force
a new layer flush, causing the repaint that will generate the display refreh event.
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.cpp:
(WebKit::ThreadedCompositor::create):
(WebKit::ThreadedCompositor::ThreadedCompositor):
(WebKit::m_displayRefreshMonitor):
(WebKit::ThreadedCompositor::handleDisplayRefreshMonitorUpdate):
(WebKit::ThreadedCompositor::requestDisplayRefreshMonitorUpdate): Deleted.
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedCompositor.h:
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.cpp:
(WebKit::ThreadedDisplayRefreshMonitor::ThreadedDisplayRefreshMonitor):
(WebKit::ThreadedDisplayRefreshMonitor::requestRefreshCallback):
(WebKit::ThreadedDisplayRefreshMonitor::dispatchDisplayRefreshCallback):
(WebKit::ThreadedDisplayRefreshMonitor::invalidate):
(WebKit::ThreadedDisplayRefreshMonitor::displayRefreshCallback):
- Shared/CoordinatedGraphics/threadedcompositor/ThreadedDisplayRefreshMonitor.h:
(WebKit::ThreadedDisplayRefreshMonitor::create):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::renderNextFrame):
(WebKit::CoordinatedLayerTreeHost::flushLayersAndForceRepaint):
- WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
- WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.cpp:
(WebKit::ThreadedCoordinatedLayerTreeHost::ThreadedCoordinatedLayerTreeHost):
(WebKit::ThreadedCoordinatedLayerTreeHost::requestDisplayRefreshMonitorUpdate):
(WebKit::ThreadedCoordinatedLayerTreeHost::handleDisplayRefreshMonitorUpdate):
- WebProcess/WebPage/CoordinatedGraphics/ThreadedCoordinatedLayerTreeHost.h:
- 8:42 AM Changeset in webkit [234258] by
-
- 108 edits2 copies17 moves3 adds4 deletes in trunk
Improve WebGPU implementation, including using Metal Objective-C protocols more simply and correctly
https://bugs.webkit.org/show_bug.cgi?id=187333
Reviewed by Sam Weinig.
Source/WebCore:
- Used a new OBJC_PROTOCOL macro to handle things in the Metal API that are protocols. The code previously had used OBJC_CLASS, but that created unrelated classes. Fixing this allows removing many typecasts that were in the existing code, makes it ARC-compatible, and also allowed the compiler to detect a couple mistakes where we were calling methods that don't exist.
- Eliminated use of separate heap-allocated, reference-counted objects to hold pointers to Metal objects.
- Reduced the use of the WebGPU wrappers to pass around arguments inside the code. They are now used only as part of the DOM binding; the inner GPU objects are used whenever possible. This cuts down the number of separate functions needed a bit, since we don't always need accessors for the things inside the wrappers.
- Used references rather than pointers in many cases.
- Took out three kinds of null checks: 1) Unneeded ones since Objective-C has the "do nothing and return 0" behavior for methods without return values and that return integer scalars. 2) Checks that aren't needed because the code has clear, invariant guarantees that the pointer won't be null. 3) The simplest variant of (2), checks that can be obviated by using reference types instead of pointer types.
- For Metal-specific functions and data members, used the function name metal() and the data member name m_metal rather than longer wordier names with the word "platform" in them. We could use "platform" if these objects were platform-specific objects used in a cross-platform way that needed a common name. But in this case it's clearer to call them "metal" since we are dropping down to the metal with Metal API, and shared platform-independent code will not be accessing these.
- Fixed the common mistake of using "unsigned long" in our C++ code to match IDL. The "unsigned long" type in IDL correponds to the "unsigned" type in WebKit code.
- Used "const" more in the GPU functions that are wrappers around Metal objects to reflect the fact that these have semantics of smart pointers; most operations can be done without changing which object is pointed to. This allows us to use const references to pass things around without reference count churn.
- Reduced includes.
- Added "explicit" keywords where appropriate.
- Removed unused functions. In particular, removed non-Metal stub versions of the functions in the GPU classes: the right way to start a new port is to clone the Metal-specific files and turn the into stubs if needed, it does not make it significantly more convenient to have stubs in the platform independent files, especially ones that are not compiled for any platform.
- Removed most the WEBCORE_EXPORT in the GPU headers; left only what's needed to support testing with TestWebKitAPI.
- Fixed two storage leaks in GPUDevice by adding missing adoptNS.
- PlatformMac.cmake: Moved files from platform/graphics/cocoa to platform/graphics/metal.
- SourcesCocoa.txt: Ditto.
- WebCore.xcodeproj/project.pbxproj: Ditto. Fixed paths on some files and groups/directories.
Made the platform files that abstract GPU all be "project" visible, not "private", since
they don't need to be visible outside WebCore. Removed reference to FontSelectionKeywordValues.h,
which does not seem to be a source file, a derived source file, or mentioned in any change log.
- bindings/js/JSWebGPURenderPassAttachmentDescriptorCustom.cpp:
(WebCore::toJSNewlyCreated): Create the correct wrapper for a
WebGPURenderPassDepthAttachmentDescriptor. The old code would instead
create a WebGPURenderPassAttachmentDescriptor wrapper, which can't be
used to access the clearDepth attribute.
- html/canvas/WebGPUBuffer.cpp:
(WebCore::WebGPUBuffer::create): Use more references rather than pointers for things
that are never null. Added comment about possibly returning null on failure in future.
(WebCore::WebGPUBuffer::WebGPUBuffer): Updated to store the GPUBuffer inside the class
instead of in a separate reference counted object.
- html/canvas/WebGPUBuffer.h: Ditto.
- html/canvas/WebGPUCommandBuffer.cpp:
(WebCore::WebGPUCommandBuffer::create): Use references and lower level types.
(WebCore::WebGPUCommandBuffer::WebGPUCommandBuffer): Store the GPUCommandBuffer
inside the class.
(WebCore::WebGPUCommandBuffer::commit): Removed unneeded null checks.
(WebCore::WebGPUCommandBuffer::presentDrawable): Ditto.
(WebCore::WebGPUCommandBuffer::createRenderCommandEncoderWithDescriptor):
Removed unneeded local variable.
(WebCore::WebGPUCommandBuffer::createComputeCommandEncoder): Ditto.
(WebCore::WebGPUCommandBuffer::completed): Store the DOMPromiseProxy in this
class, not in GPUCommandBuffer.
- html/canvas/WebGPUCommandBuffer.h: Ditto.
- html/canvas/WebGPUCommandQueue.cpp:
(WebCore::WebGPUCommandQueue::create): Use references and lower level types.
(WebCore::WebGPUCommandQueue::WebGPUCommandQueue): Store the GPUCommandQueue
inside the class.
(WebCore::WebGPUCommandQueue::createCommandBuffer): Ditto.
- html/canvas/WebGPUCommandQueue.h: Ditto.
- html/canvas/WebGPUCommandQueue.idl: The return value of createCommandBuffer
is no longer nullable.
- html/canvas/WebGPUComputeCommandEncoder.cpp:
(WebCore::WebGPUComputeCommandEncoder::create): More of the same.
(WebCore::WebGPUComputeCommandEncoder::WebGPUComputeCommandEncoder): Ditto.
(WebCore::WebGPUComputeCommandEncoder::setComputePipelineState): Ditto.
(WebCore::WebGPUComputeCommandEncoder::setBuffer): Ditto.
(WebCore::WebGPUComputeCommandEncoder::dispatch): Ditto.
(WebCore::WebGPUComputeCommandEncoder::endEncoding): Ditto.
- html/canvas/WebGPUComputeCommandEncoder.h: Ditto.
- html/canvas/WebGPUComputePipelineState.cpp:
(WebCore::WebGPUComputePipelineState::create): More of the same.
(WebCore::WebGPUComputePipelineState::WebGPUComputePipelineState): Ditto.
- html/canvas/WebGPUComputePipelineState.h: Ditto.
- html/canvas/WebGPUDepthStencilDescriptor.cpp:
(WebCore::WebGPUDepthStencilDescriptor::create): More of the same.
(WebCore::WebGPUDepthStencilDescriptor::depthWriteEnabled const): Ditto.
(WebCore::WebGPUDepthStencilDescriptor::setDepthWriteEnabled): Ditto.
(WebCore::WebGPUDepthStencilDescriptor::depthCompareFunction const): Ditto.
(WebCore::WebGPUDepthStencilDescriptor::setDepthCompareFunction): Ditto.
- html/canvas/WebGPUDepthStencilDescriptor.h: Ditto. Also fixed a bug
where m_depthCompareFunction was uninitialized in newly created objects.
- html/canvas/WebGPUDepthStencilState.cpp:
(WebCore::WebGPUDepthStencilState::create): More of the same.
(WebCore::WebGPUDepthStencilState::WebGPUDepthStencilState): Ditto.
(WebCore::WebGPUDepthStencilState::label const): Ditto.
(WebCore::WebGPUDepthStencilState::setLabel): Ditto.
- html/canvas/WebGPUDepthStencilState.h: Ditto.
- html/canvas/WebGPUDrawable.cpp:
(WebCore::WebGPUDrawable::create): More of the same.
(WebCore::WebGPUDrawable::WebGPUDrawable): Ditto.
- html/canvas/WebGPUDrawable.h: Ditto.
- html/canvas/WebGPUEnums.cpp: Removed some stray const.
- html/canvas/WebGPUEnums.h: Ditto.
- html/canvas/WebGPUFunction.cpp:
(WebCore::WebGPUFunction::create): More of the same.
(WebCore::WebGPUFunction::WebGPUFunction): Ditto.
- html/canvas/WebGPUFunction.h: Ditto.
- html/canvas/WebGPULibrary.cpp:
(WebCore::WebGPULibrary::create): More of the same.
(WebCore::WebGPULibrary::WebGPULibrary): Ditto.
(WebCore::WebGPULibrary::functionNames const): Ditto.
(WebCore::WebGPULibrary::functionWithName const): Ditto.
- html/canvas/WebGPULibrary.h: Ditto.
- html/canvas/WebGPUObject.cpp:
(WebCore::WebGPUObject::WebGPUObject):
(WebCore::WebGPUObject::deleteObject): Deleted this unused function.
We can bring it back later if we find we need it the way we did with the
WebGL implementation, but currently it's a never-called stub. Also
deleted the isDeleted and m_deleted for the same reason.
- html/canvas/WebGPUObject.h: Ditto.
- html/canvas/WebGPURenderCommandEncoder.cpp:
(WebCore::WebGPURenderCommandEncoder::create): More of the same.
(WebCore::WebGPURenderCommandEncoder::WebGPURenderCommandEncoder): Ditto.
(WebCore::WebGPURenderCommandEncoder::setRenderPipelineState): Ditto.
(WebCore::WebGPURenderCommandEncoder::setDepthStencilState): Ditto.
(WebCore::WebGPURenderCommandEncoder::setVertexBuffer): Ditto.
(WebCore::WebGPURenderCommandEncoder::setFragmentBuffer): Ditto.
(WebCore::WebGPURenderCommandEncoder::drawPrimitives): Ditto.
(WebCore::WebGPURenderCommandEncoder::endEncoding): Ditto.
- html/canvas/WebGPURenderCommandEncoder.h: Ditto.
- html/canvas/WebGPURenderPassAttachmentDescriptor.cpp:
(WebCore::WebGPURenderPassAttachmentDescriptor::WebGPURenderPassAttachmentDescriptor):
More of the same.
(WebCore::WebGPURenderPassAttachmentDescriptor::loadAction const): Ditto.
(WebCore::WebGPURenderPassAttachmentDescriptor::setLoadAction): Ditto.
(WebCore::WebGPURenderPassAttachmentDescriptor::storeAction const): Ditto.
(WebCore::WebGPURenderPassAttachmentDescriptor::setStoreAction): Ditto.
(WebCore::WebGPURenderPassAttachmentDescriptor::texture const): Ditto.
(WebCore::WebGPURenderPassAttachmentDescriptor::setTexture): Ditto.
- html/canvas/WebGPURenderPassAttachmentDescriptor.h: Ditto.
- html/canvas/WebGPURenderPassColorAttachmentDescriptor.cpp:
(WebCore::WebGPURenderPassColorAttachmentDescriptor::create): More of the same.
(WebCore::WebGPURenderPassColorAttachmentDescriptor::WebGPURenderPassColorAttachmentDescriptor): Ditto.
(WebCore::WebGPURenderPassColorAttachmentDescriptor::descriptor const): Ditto.
(WebCore::WebGPURenderPassColorAttachmentDescriptor::clearColor const): Ditto.
(WebCore::WebGPURenderPassColorAttachmentDescriptor::setClearColor): Ditto.
- html/canvas/WebGPURenderPassColorAttachmentDescriptor.h: Ditto.
- html/canvas/WebGPURenderPassDepthAttachmentDescriptor.cpp:
(WebCore::WebGPURenderPassDepthAttachmentDescriptor::create): More of the same.
(WebCore::WebGPURenderPassDepthAttachmentDescriptor::WebGPURenderPassDepthAttachmentDescriptor): Ditto.
(WebCore::WebGPURenderPassDepthAttachmentDescriptor::clearDepth const): Ditto.
(WebCore::WebGPURenderPassDepthAttachmentDescriptor::setClearDepth): Ditto.
(WebCore::WebGPURenderPassDepthAttachmentDescriptor::descriptor const): Ditto.
- html/canvas/WebGPURenderPassDepthAttachmentDescriptor.h: Ditto.
- html/canvas/WebGPURenderPassDescriptor.cpp:
(WebCore::WebGPURenderPassDescriptor::create): More of the same.
(WebCore::WebGPURenderPassDescriptor::depthAttachment): Ditto.
(WebCore::WebGPURenderPassDescriptor::colorAttachments): Ditto.
- html/canvas/WebGPURenderPassDescriptor.h: Ditto.
- html/canvas/WebGPURenderPipelineColorAttachmentDescriptor.cpp:
(WebCore::WebGPURenderPipelineColorAttachmentDescriptor::create): More of the same.
(WebCore::WebGPURenderPipelineColorAttachmentDescriptor::WebGPURenderPipelineColorAttachmentDescriptor): Ditto.
(WebCore::WebGPURenderPipelineColorAttachmentDescriptor::pixelFormat const): Ditto.
(WebCore::WebGPURenderPipelineColorAttachmentDescriptor::setPixelFormat): Ditto.
- html/canvas/WebGPURenderPipelineColorAttachmentDescriptor.h: Ditto.
- html/canvas/WebGPURenderPipelineDescriptor.cpp:
(WebCore::WebGPURenderPipelineDescriptor::create): More of the same.
(WebCore::WebGPURenderPipelineDescriptor::vertexFunction const): Ditto.
(WebCore::WebGPURenderPipelineDescriptor::setVertexFunction): Ditto.
(WebCore::WebGPURenderPipelineDescriptor::fragmentFunction const): Ditto.
(WebCore::WebGPURenderPipelineDescriptor::setFragmentFunction): Ditto.
(WebCore::WebGPURenderPipelineDescriptor::colorAttachments): Ditto.
(WebCore::WebGPURenderPipelineDescriptor::depthAttachmentPixelFormat const): Ditto.
(WebCore::WebGPURenderPipelineDescriptor::setDepthAttachmentPixelFormat): Ditto.
(WebCore::WebGPURenderPipelineDescriptor::reset): Ditto.
- html/canvas/WebGPURenderPipelineDescriptor.h: Ditto.
- html/canvas/WebGPURenderPipelineState.cpp:
(WebCore::WebGPURenderPipelineState::create): More of the same.
(WebCore::WebGPURenderPipelineState::WebGPURenderPipelineState): Ditto.
(WebCore::WebGPURenderPipelineState::label const): Ditto.
(WebCore::WebGPURenderPipelineState::setLabel): Ditto.
- html/canvas/WebGPURenderPipelineState.h: Ditto.
- html/canvas/WebGPURenderingContext.cpp:
(WebCore::WebGPURenderingContext::create): More of the same.
(WebCore::WebGPURenderingContext::WebGPURenderingContext): Ditto.
(WebCore::WebGPURenderingContext::initializeNewContext): Ditto.
(WebCore::WebGPURenderingContext::platformLayer const): Ditto.
(WebCore::WebGPURenderingContext::markLayerComposited): Ditto.
(WebCore::WebGPURenderingContext::reshape): Ditto.
(WebCore::WebGPURenderingContext::createLibrary): Ditto.
(WebCore::WebGPURenderingContext::createRenderPipelineState): Ditto.
(WebCore::WebGPURenderingContext::createDepthStencilState): Ditto.
(WebCore::WebGPURenderingContext::createComputePipelineState): Ditto.
(WebCore::WebGPURenderingContext::createCommandQueue): Ditto.
(WebCore::WebGPURenderingContext::nextDrawable): Ditto.
(WebCore::WebGPURenderingContext::createBuffer): Ditto.
(WebCore::WebGPURenderingContext::createTexture): Ditto.
- html/canvas/WebGPURenderingContext.h: Made many functions final and
private.
- html/canvas/WebGPURenderingContext.idl: The return value of most of
the create functions are no longer nullable.
- html/canvas/WebGPUSize.h: Use "unsigned" instead of "unsigned long".
- html/canvas/WebGPUTexture.cpp:
(WebCore::WebGPUTexture::createFromDrawableTexture): More of the same.
(WebCore::WebGPUTexture::create): Ditto.
(WebCore::WebGPUTexture::WebGPUTexture): Ditto.
- html/canvas/WebGPUTexture.h: Ditto.
- html/canvas/WebGPUTextureDescriptor.cpp:
(WebCore::WebGPUTextureDescriptor::create): More of the same.
(WebCore::WebGPUTextureDescriptor::WebGPUTextureDescriptor): Ditto.
(WebCore::WebGPUTextureDescriptor::width const): Ditto.
(WebCore::WebGPUTextureDescriptor::setWidth): Ditto.
(WebCore::WebGPUTextureDescriptor::height const): Ditto.
(WebCore::WebGPUTextureDescriptor::setHeight): Ditto.
(WebCore::WebGPUTextureDescriptor::sampleCount const): Ditto.
(WebCore::WebGPUTextureDescriptor::setSampleCount): Ditto.
(WebCore::WebGPUTextureDescriptor::textureType const): Ditto.
(WebCore::WebGPUTextureDescriptor::setTextureType): Ditto.
(WebCore::WebGPUTextureDescriptor::storageMode const): Ditto.
(WebCore::WebGPUTextureDescriptor::setStorageMode): Ditto.
(WebCore::WebGPUTextureDescriptor::usage const): Ditto.
(WebCore::WebGPUTextureDescriptor::setUsage): Ditto.
- html/canvas/WebGPUTextureDescriptor.h: Ditto.
- platform/graphics/metal/GPUBufferMetal.mm: Moved from "cocoa" directory.
(WebCore::GPUBuffer::GPUBuffer): Simplify code using references and the
"metal" naming.
- platform/graphics/metal/GPUCommandBufferMetal.mm:
(WebCore::GPUCommandBuffer::GPUCommandBuffer): Take a function to be called as the
completed handler and set it up.
(WebCore::GPUCommandBuffer::presentDrawable const): Ditto.
(WebCore::GPUCommandBuffer::commit const): Ditto.
(WebCore::GPUCommandBuffer::addCompletedHandler): Deleted.
- platform/graphics/metal/GPUCommandQueueMetal.mm:
(WebCore::GPUCommandQueue::GPUCommandQueue): Ditto. Also rewrote label handling a bit.
(WebCore::GPUCommandQueue::label const): Ditto.
(WebCore::GPUCommandQueue::setLabel const): Ditto.
- platform/graphics/metal/GPUComputeCommandEncoderMetal.mm:
(WebCore::GPUComputeCommandEncoder::GPUComputeCommandEncoder): Ditto.
(WebCore::GPUComputeCommandEncoder::setComputePipelineState const): Ditto.
(WebCore::GPUComputeCommandEncoder::setBuffer const): Ditto.
(WebCore::GPUComputeCommandEncoder::dispatch const): Ditto.
(WebCore::GPUComputeCommandEncoder::endEncoding const): Ditto.
- platform/graphics/metal/GPUComputePipelineStateMetal.mm:
(WebCore::GPUComputePipelineState::GPUComputePipelineState): Ditto.
- platform/graphics/metal/GPUDepthStencilDescriptorMetal.mm:
(WebCore::GPUDepthStencilDescriptor::GPUDepthStencilDescriptor): Ditto.
(WebCore::GPUDepthStencilDescriptor::depthWriteEnabled const): Ditto.
(WebCore::GPUDepthStencilDescriptor::setDepthWriteEnabled const): Ditto.
(WebCore::GPUDepthStencilDescriptor::depthCompareFunction const): Ditto.
(WebCore::GPUDepthStencilDescriptor::setDepthCompareFunction const): Ditto.
- platform/graphics/metal/GPUDepthStencilStateMetal.mm:
(WebCore::GPUDepthStencilState::GPUDepthStencilState): Ditto.
(WebCore::GPUDepthStencilState::label const): Ditto.
(WebCore::GPUDepthStencilState::setLabel const): Ditto. This is one of the
functions that was calling a method that does not exist. Added a comment.
- platform/graphics/metal/GPUDeviceMetal.mm:
(WebCore::GPUDevice::GPUDevice): Ditto. Also fixed two storage leaks where
we neglected to do adoptNS on the result of MTLCreateSystemDefaultDevice and
on the result of -[[WebGPULayer alloc] initWithGPUDevice:].
(WebCore::GPUDevice::reshape const): Ditto.
(WebCore::GPUDevice::platformLayer const): Ditto.
(WebCore::GPUDevice::operator! const): Ditto.
- platform/graphics/metal/GPUDrawableMetal.mm:
(WebCore::GPUDrawable::GPUDrawable): Ditto.
(WebCore::GPUDrawable::release): Ditto.
(WebCore::GPUDrawable::metal const): Ditto.
(WebCore::GPUDrawable::texture const): Ditto.
- platform/graphics/metal/GPUFunctionMetal.mm:
(WebCore::GPUFunction::GPUFunction): Ditto.
(WebCore::GPUFunction::name const): Ditto.
(WebCore::GPUFunction::metal const): Ditto.
(WebCore::GPUFunction::operator! const): Ditto.
- platform/graphics/metal/GPULibraryMetal.mm:
(WebCore::GPULibrary::GPULibrary): Ditto.
(WebCore::GPULibrary::label const): Ditto.
(WebCore::GPULibrary::setLabel const): Ditto.
(WebCore::GPULibrary::functionNames const): Ditto.
(WebCore::GPULibrary::metal const): Ditto.
- platform/graphics/metal/GPURenderCommandEncoderMetal.mm:
(WebCore::GPURenderCommandEncoder::GPURenderCommandEncoder): Ditto.
(WebCore::GPURenderCommandEncoder::setRenderPipelineState const): Ditto.
(WebCore::GPURenderCommandEncoder::setDepthStencilState const): Ditto.
(WebCore::GPURenderCommandEncoder::setVertexBuffer const): Ditto.
(WebCore::GPURenderCommandEncoder::setFragmentBuffer const): Ditto.
(WebCore::GPURenderCommandEncoder::drawPrimitives const): Ditto.
(WebCore::GPURenderCommandEncoder::endEncoding const): Ditto.
- platform/graphics/metal/GPURenderPassAttachmentDescriptorMetal.mm:
(WebCore::GPURenderPassAttachmentDescriptor::GPURenderPassAttachmentDescriptor): Ditto.
(WebCore::GPURenderPassAttachmentDescriptor::loadAction const): Ditto.
(WebCore::GPURenderPassAttachmentDescriptor::setLoadAction const): Ditto.
(WebCore::GPURenderPassAttachmentDescriptor::storeAction const): Ditto.
(WebCore::GPURenderPassAttachmentDescriptor::setStoreAction const): Ditto.
(WebCore::GPURenderPassAttachmentDescriptor::setTexture const): Ditto.
- platform/graphics/metal/GPURenderPassColorAttachmentDescriptorMetal.mm:
(WebCore::GPURenderPassColorAttachmentDescriptor::GPURenderPassColorAttachmentDescriptor): Ditto.
(WebCore::GPURenderPassColorAttachmentDescriptor::clearColor const): Ditto.
(WebCore::GPURenderPassColorAttachmentDescriptor::setClearColor const): Ditto.
(WebCore::GPURenderPassColorAttachmentDescriptor::metal const): Ditto.
- platform/graphics/metal/GPURenderPassDepthAttachmentDescriptorMetal.mm:
(WebCore::GPURenderPassDepthAttachmentDescriptor::GPURenderPassDepthAttachmentDescriptor): Ditto.
(WebCore::GPURenderPassDepthAttachmentDescriptor::clearDepth const): Ditto.
(WebCore::GPURenderPassDepthAttachmentDescriptor::setClearDepth const): Ditto.
(WebCore::GPURenderPassDepthAttachmentDescriptor::metal const): Ditto.
- platform/graphics/metal/GPURenderPassDescriptorMetal.mm:
(WebCore::GPURenderPassDescriptor::GPURenderPassDescriptor): Ditto.
(WebCore::GPURenderPassDescriptor::colorAttachments const): Ditto.
(WebCore::GPURenderPassDescriptor::depthAttachment const): Ditto.
(WebCore::GPURenderPassDescriptor::metal const): Ditto.
- platform/graphics/metal/GPURenderPipelineColorAttachmentDescriptorMetal.mm:
(WebCore::GPURenderPipelineColorAttachmentDescriptor::GPURenderPipelineColorAttachmentDescriptor): Ditto.
(WebCore::GPURenderPipelineColorAttachmentDescriptor::pixelFormat const): Ditto.
(WebCore::GPURenderPipelineColorAttachmentDescriptor::setPixelFormat const): Ditto.
(WebCore::GPURenderPipelineColorAttachmentDescriptor::metal const): Ditto.
- platform/graphics/metal/GPURenderPipelineDescriptorMetal.mm:
(WebCore::GPURenderPipelineDescriptor::GPURenderPipelineDescriptor): Ditto.
(WebCore::GPURenderPipelineDescriptor::depthAttachmentPixelFormat const): Ditto.
(WebCore::GPURenderPipelineDescriptor::setDepthAttachmentPixelFormat const): Ditto.
(WebCore::GPURenderPipelineDescriptor::setVertexFunction const): Ditto.
(WebCore::GPURenderPipelineDescriptor::setFragmentFunction const): Ditto.
(WebCore::GPURenderPipelineDescriptor::colorAttachments const): Ditto.
(WebCore::GPURenderPipelineDescriptor::reset const): Ditto.
(WebCore::GPURenderPipelineDescriptor::metal const): Ditto.
- platform/graphics/metal/GPURenderPipelineStateMetal.mm:
(WebCore::GPURenderPipelineState::GPURenderPipelineState): Ditto.
(WebCore::GPURenderPipelineState::label const): Ditto.
(WebCore::GPURenderPipelineState::setLabel const): Ditto. This is one of the
functions that was calling a method that does not exist. Added a comment.
(WebCore::GPURenderPipelineState::metal const): Ditto.
- platform/graphics/metal/GPUTextureDescriptorMetal.mm:
(WebCore::GPUTextureDescriptor::GPUTextureDescriptor): Ditto.
(WebCore::GPUTextureDescriptor::width const): Ditto.
(WebCore::GPUTextureDescriptor::setWidth const): Ditto.
(WebCore::GPUTextureDescriptor::height const): Ditto.
(WebCore::GPUTextureDescriptor::setHeight const): Ditto.
(WebCore::GPUTextureDescriptor::sampleCount const): Ditto.
(WebCore::GPUTextureDescriptor::setSampleCount const): Ditto.
(WebCore::GPUTextureDescriptor::textureType const): Ditto.
(WebCore::GPUTextureDescriptor::setTextureType const): Ditto.
(WebCore::GPUTextureDescriptor::storageMode const): Ditto.
(WebCore::GPUTextureDescriptor::setStorageMode const): Ditto.
(WebCore::GPUTextureDescriptor::usage const): Ditto.
(WebCore::GPUTextureDescriptor::setUsage const): Ditto.
(WebCore::GPUTextureDescriptor::metal const): Ditto.
- platform/graphics/metal/GPUTextureMetal.mm:
(WebCore::GPUTexture::GPUTexture): Ditto.
(WebCore::GPUTexture::width const): Ditto.
(WebCore::GPUTexture::height const): Ditto.
(WebCore::GPUTexture::metal const): Ditto.
- platform/graphics/gpu/GPUBuffer.cpp: Removed unused stubs.
(WebCore::GPUBuffer::length const): Moved this function here since it has
a useful platform-independent implementation.
- platform/graphics/gpu/GPUBuffer.h: Use OBJC_PROTOCOL for MTLBuffer.
Did the other thigs mentioned above: USE(METAL), remove WEBCORE_EXPORT,
no longer be RefCounted, etc.
- platform/graphics/gpu/GPUCommandBuffer.cpp: Ditto.
- platform/graphics/gpu/GPUCommandBuffer.h: Ditto. Use OBJC_PROTOCOL
for MTLCommandBuffer.
- platform/graphics/gpu/GPUCommandQueue.cpp: Ditto.
- platform/graphics/gpu/GPUCommandQueue.h: Ditto. Use OBJC_PROTOCOL for
MTLCommandQueue.
- platform/graphics/gpu/GPUComputeCommandEncoder.cpp: Ditto.
- platform/graphics/gpu/GPUComputeCommandEncoder.h: Ditto. Use OBJC_PROTOCOL for
MTLComputeCommandEncoder.
- platform/graphics/gpu/GPUComputePipelineState.cpp: Ditto.
- platform/graphics/gpu/GPUComputePipelineState.h: Ditto. Use OBJC_PROTOCOL for
MTLComputePipelineState.
- platform/graphics/gpu/GPUDepthStencilDescriptor.cpp: Ditto.
- platform/graphics/gpu/GPUDepthStencilDescriptor.h: Ditto.
- platform/graphics/gpu/GPUDepthStencilState.cpp: Ditto.
- platform/graphics/gpu/GPUDepthStencilState.h: Ditto. Use OBJC_PROTOCOL for
MTLDepthStencilState.
- platform/graphics/gpu/GPUDevice.cpp: Ditto.
- platform/graphics/gpu/GPUDevice.h: Ditto. Use OBJC_PROTOCOL for MTLDevice.
- platform/graphics/gpu/GPUDrawable.cpp: Ditto.
- platform/graphics/gpu/GPUDrawable.h: Ditto. Use OBJC_PROTOCOL for
MTLDrawable and MTLTexture.
- platform/graphics/gpu/GPUEnums.h: Tweaked formatting.
- platform/graphics/gpu/GPUFunction.cpp: Ditto.
- platform/graphics/gpu/GPUFunction.h: Ditto. Use OBJC_PROTOCOL for
MTLFunction.
- platform/graphics/gpu/GPULibrary.cpp: Ditto.
- platform/graphics/gpu/GPULibrary.h: Ditto. Use OBJC_PROTOCOL for
MTLLibrary.
- platform/graphics/gpu/GPURenderCommandEncoder.cpp: Ditto.
- platform/graphics/gpu/GPURenderCommandEncoder.h: Ditto.
Use OBJC_PROTOCOL for MTLRenderCommandEncoder.
- platform/graphics/gpu/GPURenderPassAttachmentDescriptor.cpp: Ditto.
- platform/graphics/gpu/GPURenderPassAttachmentDescriptor.h: Ditto.
- platform/graphics/gpu/GPURenderPassColorAttachmentDescriptor.cpp: Ditto.
- platform/graphics/gpu/GPURenderPassColorAttachmentDescriptor.h: Ditto.
- platform/graphics/gpu/GPURenderPassDepthAttachmentDescriptor.cpp: Ditto.
- platform/graphics/gpu/GPURenderPassDepthAttachmentDescriptor.h: Ditto.
- platform/graphics/gpu/GPURenderPassDescriptor.cpp: Ditto.
- platform/graphics/gpu/GPURenderPassDescriptor.h: Ditto.
- platform/graphics/gpu/GPURenderPipelineColorAttachmentDescriptor.cpp: Ditto.
- platform/graphics/gpu/GPURenderPipelineColorAttachmentDescriptor.h: Ditto.
- platform/graphics/gpu/GPURenderPipelineDescriptor.cpp: Ditto.
- platform/graphics/gpu/GPURenderPipelineDescriptor.h: Ditto.
- platform/graphics/gpu/GPURenderPipelineState.cpp: Ditto.
- platform/graphics/gpu/GPURenderPipelineState.h: Ditto. Use OBJC_PROTOCOL
for MTLRenderPipelineState.
- platform/graphics/gpu/GPUSize.h: Use "unsigned" instead of "unsigned long".
- platform/graphics/gpu/GPUTexture.cpp: Ditto.
- platform/graphics/gpu/GPUTexture.h: Ditto. Use OBJC_PROTOCOL for
MTLTexture.
- platform/graphics/gpu/GPUTextureDescriptor.cpp: Ditto.
- platform/graphics/gpu/GPUTextureDescriptor.h: Ditto.
Source/WTF:
- wtf/Compiler.h: Added OBJC_PROTOCOL, a macro for convieniently treating an
Objective-C protocol in a way that lets it be mentioned in a C++ source file.
This is the rough equivalent of OBJC_CLASS, but for protocols.
- wtf/Platform.h: Added USE(METAL), alongside USE(OPENGL) and the like.
Now used in the WebGPU platform layer to guard the Metal-specific code.
Tools:
- TestWebKitAPI/Tests/WebCore/mac/GPUBuffer.mm: Updated.
- TestWebKitAPI/Tests/WebCore/mac/GPUCommandQueue.mm: Updated.
- TestWebKitAPI/Tests/WebCore/mac/GPUDevice.mm: Updated.
- TestWebKitAPI/Tests/WebCore/mac/GPUFunction.mm: Updated.
- TestWebKitAPI/Tests/WebCore/mac/GPULibrary.mm: Updated.
- 8:23 AM WebKitGTK/Gardening/Calendar/2018Logs edited by
- (diff)
- 8:16 AM Changeset in webkit [234257] by
-
- 5 edits in trunk/LayoutTests
Unreviewed GTK+ and WPE gardening after r234252.
- platform/gtk/TestExpectations:
- platform/gtk/fast/overflow/line-clamp-expected.png:
- platform/gtk/fast/overflow/line-clamp-expected.txt:
- platform/wpe/TestExpectations:
- 7:30 AM Changeset in webkit [234256] by
-
- 13 edits in trunk/Source/WebCore
[LFC][Floating] Add skeleton for basic positioning.
https://bugs.webkit.org/show_bug.cgi?id=187974
Reviewed by Antti Koivisto.
Add floating boxes to an empty floating context.
- layout/FloatingContext.cpp:
(WebCore::Layout::FloatingContext::FloatingContext):
(WebCore::Layout::FloatingContext::computePosition):
- layout/FloatingContext.h:
(WebCore::Layout::FloatingContext::floatingState const):
(WebCore::Layout::FloatingContext::layoutContext const):
- layout/FloatingState.cpp:
(WebCore::Layout::FloatingState::FloatingState):
(WebCore::Layout::FloatingState::append):
- layout/FloatingState.h:
(WebCore::Layout::FloatingState::create):
(WebCore::Layout::FloatingState::isEmpty const):
(WebCore::Layout::FloatingState::layoutContext const):
- layout/FormattingState.h:
- layout/LayoutContext.cpp:
(WebCore::Layout::LayoutContext::establishedFormattingState):
- layout/LayoutContext.h:
- layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::layout const):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::BlockFormattingContext::computeFloatingPosition const):
- layout/blockformatting/BlockFormattingContext.h:
- layout/blockformatting/BlockInvalidation.cpp:
(WebCore::Layout::invalidationStopsAtFormattingContextBoundary):
- layout/layouttree/LayoutBox.cpp:
(WebCore::Layout::Box::isLeftFloatingPositioned const):
(WebCore::Layout::Box::isRightFloatingPositioned const):
- layout/layouttree/LayoutBox.h:
- 7:25 AM Changeset in webkit [234255] by
-
- 2 edits in trunk/Source/WebCore
[LFC][BFC] Do not try to access containing block's height during descendant height computation
https://bugs.webkit.org/show_bug.cgi?id=187970
Reviewed by Antti Koivisto.
Mostly becasue in BFC, we compute the descendents' height first so the containing block's height is probably not computed yet.
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):
- 7:07 AM Changeset in webkit [234254] by
-
- 3 edits in trunk/Source/WebCore
Unreviewed, add bug references into FIXME comments for CSSOM View API
Patch by Frederic Wang <fwang@igalia.com> on 2018-07-26
- dom/Element.idl:
- page/ScrollToOptions.idl:
- 6:45 AM Changeset in webkit [234253] by
-
- 2 edits in trunk/Source/WebCore
[LFC][BFC] assert-not-implemented-yet on inflow non-replaced height when style is not fixed/auto.
https://bugs.webkit.org/show_bug.cgi?id=187969
Reviewed by Antti Koivisto.
Assert on unsupported height types when computing inflow non-replaced height.
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
- 2:30 AM Changeset in webkit [234252] by
-
- 2 edits in trunk/Source/JavaScriptCore
REGRESSION(r234248) [Win] testapi.c: nonstandard extension used: non-constant aggregate initializer
https://bugs.webkit.org/show_bug.cgi?id=188040
Unreviewed build fix for AppleWin port.
- API/tests/testapi.c: Disabled warning C4204.
(testMarkingConstraintsAndHeapFinalizers): Added an explicit void* cast for weakRefs.
- 2:00 AM Changeset in webkit [234251] by
-
- 4 edits in trunk/Source/WTF
[WTF] Coverity scan issues
https://bugs.webkit.org/show_bug.cgi?id=186800
Reviewed by Brent Fulgham.
- wtf/CheckedArithmetic.h: Swap the operands to multiply().
- wtf/ThreadSpecific.h: Initialize the m_key variable.
- wtf/dtoa.cpp: Initialize the next variable.
- 1:33 AM Changeset in webkit [234250] by
-
- 6 edits4 adds in trunk
[Web Animations] REGRESSION: transition added immediately after element creation doesn't work
https://bugs.webkit.org/show_bug.cgi?id=187942
Reviewed by Dean Jackson.
Source/WebCore:
Tests: webanimations/accelerated-transition-by-removing-property.html
webanimations/partly-accelerated-transition-by-removing-property.html
The Style::TreeResolver::createAnimatedElementUpdate() function expected a flag to be set that indicates that
running animations on an element should yield a change in composited state for that element's layer. We did not
have code accounting for this flag in the Web Animations engine. We now have a resolveAnimationsForElement()
method on DocumentTimeline which looks at all animations resolved on the element and see if all of them are
running accelerated and whether at least one of them is pending. In that case, we set the shouldRecompositeLayer
flag in createAnimatedElementUpdate() to true which guarantees the element's layer will have a backing when
we attempt to start the animation in KeyframeEffectReadOnly::applyPendingAcceleratedActions() where we would
have previously failed to have layer-backed renderer to perform an accelerated animation on (under certain
circumstances, see test).
- animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::resolveAnimationsForElement):
- animation/DocumentTimeline.h:
- animation/KeyframeEffectReadOnly.h:
(WebCore::KeyframeEffectReadOnly::hasPendingAcceleratedAction const):
- style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::createAnimatedElementUpdate):
LayoutTests:
Creating a new test that runs a transition based on an explicit value being removed in favor
of the implicit value of a property that can be accelerated. To check that we indeed run the
animation, we have a cache that covers the entire range of interpolated values except for the
start and end values and wait 100ms after creating the transition to end the test. Prior to this
patch, the element would be at its start value and a 1px red line would show to the right of the
cache. With this patch, the red line is hidden by the cache as it's animated.
We also add a test that checks that we do not create a composited layer when several transitions,
with only one being potentially accelerated, target the same element.
- webanimations/accelerated-transition-by-removing-property-expected.html: Added.
- webanimations/accelerated-transition-by-removing-property.html: Added.
- webanimations/partly-accelerated-transition-by-removing-property-expected.txt: Added.
- webanimations/partly-accelerated-transition-by-removing-property.html: Added.
- 1:04 AM Changeset in webkit [234249] by
-
- 2 edits2 adds in trunk/LayoutTests
[Curl] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=188034
Unreviewed WinCairo gardening.
Add expected file.
- http/tests/xmlhttprequest/resources/print-referer.php: Added.
- http/tests/xmlhttprequest/simple-sync-expected.txt: Added.
- http/tests/xmlhttprequest/simple-sync.html:
- 12:38 AM Changeset in webkit [234248] by
-
- 3 edits in trunk/Source/JavaScriptCore
[JSC API] We should support the symbol type in our C/Obj-C API
https://bugs.webkit.org/show_bug.cgi?id=175836
Unreviewed build fix for Windows port.
r234227 introduced a compilation error unresolved external symbol
"int cdecl testCAPIViaCpp(void)" in testapi for Windows ports.
Windows ports are compiling testapi.c as C++ by using /TP switch.
- API/tests/testapi.c:
(main): Removed
::prefix of ::SetErrorMode Windows API.
(dllLauncherEntryPoint): Converted into C style.
- shell/PlatformWin.cmake: Do not use /TP switch for testapi.c
- 12:15 AM Changeset in webkit [234247] by
-
- 2 edits in branches/safari-606-branch/Source/WebCore
Cherry-pick r234222. rdar://problem/42612113
Build fix after r234215. Unreviewed.
- rendering/RenderTheme.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234222 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:15 AM Changeset in webkit [234246] by
-
- 2 edits in branches/safari-606-branch/Source/WebKit
Cherry-pick r234216. rdar://problem/42604537
Mask AVBackgroundView to the corner radius.
https://bugs.webkit.org/show_bug.cgi?id=187976
rdar://problem/41810866
Patch by Jeremy Jones <jeremyj@apple.com> on 2018-07-25
Reviewed by Jon Lee.
This changes sets the appropriate mask to the layer so the corners look correct.
- UIProcess/ios/fullscreen/WKFullscreenStackView.mm: (-[WKFullscreenStackView init]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234216 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:15 AM Changeset in webkit [234245] by
-
- 30 edits2 adds15 deletes in branches/safari-606-branch
Cherry-pick r234215. rdar://problem/42604541
REGRESSION(r227577) Text on TV & Movies page doesn't wrap properly in iTunes
https://bugs.webkit.org/show_bug.cgi?id=188018
<rdar://problem/42517520>
Reviewed by Dean Jackson.
Source/WebCore:
Manual rollout of r227577.
Test: fast/overflow/line-clamp-with-text-shadow.html
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
- css/CSSProperties.json:
- css/StyleBuilderCustom.h: (WebCore::StyleBuilderCustom::applyValueWebkitLinesClamp): Deleted.
- css/parser/CSSParserContext.cpp: (WebCore::CSSParserContext::CSSParserContext):
- css/parser/CSSParserContext.h: (WebCore::CSSParserContextHash::hash):
- css/parser/CSSPropertyParser.cpp: (WebCore::CSSPropertyParser::parseSingleValue): (WebCore::consumeLinesClamp): Deleted.
- page/Settings.yaml:
- rendering/RenderBlockFlow.cpp: (WebCore::RenderBlockFlow::willCreateColumns const): (WebCore::getHeightForLineCount): (WebCore::RenderBlockFlow::heightForLineCount): (WebCore::RenderBlockFlow::layoutExcludedChildren): (WebCore::RenderBlockFlow::logicalHeightForLineCount): Deleted. (WebCore::RenderBlockFlow::logicalHeightExcludingLineCount): Deleted.
- rendering/RenderBlockFlow.h:
- rendering/RenderDeprecatedFlexibleBox.cpp: (WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
- rendering/RenderFragmentContainer.cpp: (WebCore::RenderFragmentContainer::pageLogicalHeightForOffset const): Deleted.
- rendering/RenderFragmentContainer.h:
- rendering/RenderFragmentedFlow.cpp: (WebCore::RenderFragmentedFlow::validateFragments): (WebCore::RenderFragmentedFlow::pageLogicalHeightForOffset const): (WebCore::RenderFragmentedFlow::pageRemainingLogicalHeightForOffset const):
- rendering/RenderFragmentedFlow.h:
- rendering/RenderLinesClampFlow.cpp: Removed.
- rendering/RenderLinesClampFlow.h: Removed.
- rendering/RenderLinesClampSet.cpp: Removed.
- rendering/RenderLinesClampSet.h: Removed.
- rendering/RenderMultiColumnFlow.cpp: (WebCore::RenderMultiColumnFlow::isColumnSpanningDescendant const): Deleted. (WebCore::RenderMultiColumnFlow::createMultiColumnSet): Deleted.
- rendering/RenderMultiColumnFlow.h: (WebCore::RenderMultiColumnFlow::multiColumnBlockFlow const): Deleted. (WebCore::RenderMultiColumnFlow::hasColumnSpanner const): Deleted. (WebCore::RenderMultiColumnFlow::findColumnSpannerPlaceholder const): Deleted. (WebCore::RenderMultiColumnFlow::columnCount const): Deleted. (WebCore::RenderMultiColumnFlow::columnWidth const): Deleted. (WebCore::RenderMultiColumnFlow::columnHeightAvailable const): Deleted. (WebCore::RenderMultiColumnFlow::setColumnHeightAvailable): Deleted. (WebCore::RenderMultiColumnFlow::inBalancingPass const): Deleted. (WebCore::RenderMultiColumnFlow::setInBalancingPass): Deleted. (WebCore::RenderMultiColumnFlow::needsHeightsRecalculation const): Deleted. (WebCore::RenderMultiColumnFlow::setNeedsHeightsRecalculation): Deleted. (WebCore::RenderMultiColumnFlow::shouldRelayoutForPagination const): Deleted. (WebCore::RenderMultiColumnFlow::setColumnCountAndWidth): Deleted. (WebCore::RenderMultiColumnFlow::progressionIsInline const): Deleted. (WebCore::RenderMultiColumnFlow::setProgressionIsInline): Deleted. (WebCore::RenderMultiColumnFlow::progressionIsReversed const): Deleted. (WebCore::RenderMultiColumnFlow::setProgressionIsReversed): Deleted. (WebCore::RenderMultiColumnFlow::spannerMap): Deleted.
- rendering/RenderMultiColumnSet.cpp: (WebCore::RenderMultiColumnSet::collectLayerFragments): (WebCore::RenderMultiColumnSet::columnTranslationForOffset const):
- rendering/RenderMultiColumnSet.h: (WebCore::RenderMultiColumnSet::multiColumnBlockFlow const): Deleted. (WebCore::RenderMultiColumnSet::multiColumnFlow const): Deleted. (WebCore::RenderMultiColumnSet::logicalTopInFragmentedFlow const): Deleted. (WebCore::RenderMultiColumnSet::logicalBottomInFragmentedFlow const): Deleted. (WebCore::RenderMultiColumnSet::logicalHeightInFragmentedFlow const): Deleted. (WebCore::RenderMultiColumnSet::computedColumnCount const): Deleted. (WebCore::RenderMultiColumnSet::computedColumnWidth const): Deleted. (WebCore::RenderMultiColumnSet::computedColumnHeight const): Deleted. (WebCore::RenderMultiColumnSet::columnHeightComputed const): Deleted. (WebCore::RenderMultiColumnSet::setComputedColumnWidthAndCount): Deleted. (WebCore::RenderMultiColumnSet::updateMinimumColumnHeight): Deleted. (WebCore::RenderMultiColumnSet::minimumColumnHeight const): Deleted. (WebCore::RenderMultiColumnSet::forcedBreaksCount const): Deleted. (WebCore::RenderMultiColumnSet::hasBeenFlowed const): Deleted. (WebCore::RenderMultiColumnSet::skipLayerFragmentCollectionForColumn const): Deleted. (WebCore::RenderMultiColumnSet::customBlockProgressionAdjustmentForColumn const): Deleted. (WebCore::RenderMultiColumnSet::ContentRun::ContentRun): Deleted. (WebCore::RenderMultiColumnSet::ContentRun::assumedImplicitBreaks const): Deleted. (WebCore::RenderMultiColumnSet::ContentRun::assumeAnotherImplicitBreak): Deleted. (WebCore::RenderMultiColumnSet::ContentRun::breakOffset const): Deleted. (WebCore::RenderMultiColumnSet::ContentRun::columnLogicalHeight const): Deleted.
- rendering/RenderObject.h: (WebCore::RenderObject::isRenderLinesClampFlow const): Deleted. (WebCore::RenderObject::isRenderLinesClampSet const): Deleted.
- rendering/style/LineClampValue.h: (WebCore::LinesClampValue::LinesClampValue): Deleted. (WebCore::LinesClampValue::isNone const): Deleted. (WebCore::LinesClampValue::operator== const): Deleted. (WebCore::LinesClampValue::operator!= const): Deleted. (WebCore::LinesClampValue::start const): Deleted. (WebCore::LinesClampValue::end const): Deleted. (WebCore::LinesClampValue::center const): Deleted.
- rendering/style/RenderStyle.h: (WebCore::RenderStyle::lineClamp const): (WebCore::RenderStyle::setLineClamp): (WebCore::RenderStyle::initialLineClamp): (WebCore::RenderStyle::hasInlineColumnAxis const): (WebCore::RenderStyle::linesClamp const): Deleted. (WebCore::RenderStyle::hasLinesClamp const): Deleted. (WebCore::RenderStyle::setLinesClamp): Deleted. (WebCore::RenderStyle::initialLinesClamp): Deleted.
- rendering/style/StyleRareNonInheritedData.cpp: (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData): (WebCore::StyleRareNonInheritedData::operator== const):
- rendering/style/StyleRareNonInheritedData.h:
- rendering/updating/RenderTreeBuilderMultiColumn.cpp: (WebCore::isValidColumnSpanner): (WebCore::RenderTreeBuilder::MultiColumn::createFragmentedFlow): (WebCore::RenderTreeBuilder::MultiColumn::processPossibleSpannerDescendant):
Source/WebKit:
- WebProcess/WebPage/WebPage.cpp: (WebKit::m_credentialsMessenger):
LayoutTests:
- fast/block/lines-clamp-advanced-expected.html: Removed.
- fast/block/lines-clamp-advanced-rl-expected.html: Removed.
- fast/block/lines-clamp-advanced-rl.html: Removed.
- fast/block/lines-clamp-advanced.html: Removed.
- fast/block/lines-clamp-basic-expected.html: Removed.
- fast/block/lines-clamp-basic-rl-expected.html: Removed.
- fast/block/lines-clamp-basic-rl.html: Removed.
- fast/block/lines-clamp-basic.html: Removed.
- fast/css/lines-clamp-parsing-expected.txt: Removed.
- fast/css/lines-clamp-parsing.html: Removed.
- fast/overflow/line-clamp-with-text-shadow-expected.html: Added.
- fast/overflow/line-clamp-with-text-shadow.html: Added.
- platform/ios-simulator-wk2/fast/overflow/line-clamp-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234215 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:15 AM Changeset in webkit [234244] by
-
- 4 edits2 moves in branches/safari-606-branch/Source/WebKit
Cherry-pick r234195. rdar://problem/42604534
[macOS] PluginProcess needs TCC entitlements for media capture
https://bugs.webkit.org/show_bug.cgi?id=187981
<rdar://problem/42433634>
Reviewed by Chris Dumez.
The changes needed in Bug 185526 are also needed for the plugin process, or else the UIProcess
(e.g., Safari) is not able to pass the user's camera/microphone access permission to the plugin process.
This patch has the following changes:
- Rename "WebContent-OSX-restricted.entitlements" to "WebContent-or-Plugin-OSX-restricted.entitlements"
- Rename "process-webcontent-entitlements.sh" to "process-webcontent-or-plugin-entitlements.sh"
- Add a run-script step to the Plugin.64 and Plugin.32 builds to add the relevant entitlements.
- Silence some Flash plugin sandbox exceptions triggered after activating the camera.
- Configurations/WebContent-or-Plugin-OSX-restricted.entitlements: Renamed from Source/WebKit/Configurations/WebContent-OSX-restricted.entitlements.
- Resources/PlugInSandboxProfiles/com.macromedia.Flash Player ESR.plugin.sb: Address sandbox violations needed by camera use.
- Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb: Ditto.
- Scripts/process-webcontent-or-plugin-entitlements.sh: Renamed from Source/WebKit/Scripts/process-webcontent-entitlements.sh.
- WebKit.xcodeproj/project.pbxproj: Update for renaming, and perform entitlement steps on Plugin process.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234195 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:15 AM Changeset in webkit [234243] by
-
- 2 edits in branches/safari-606-branch/Source/WTF
Cherry-pick r234189. rdar://problem/42604524
HAVE(PARENTAL_CONTROLS) should be true on watchOS
https://bugs.webkit.org/show_bug.cgi?id=187985
<rdar://problem/42559346>
Reviewed by Andy Estes.
- wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234189 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:15 AM Changeset in webkit [234242] by
-
- 12 edits in branches/safari-606-branch
Cherry-pick r234181. rdar://problem/42604524
Enable Web Content Filtering on watchOS
https://bugs.webkit.org/show_bug.cgi?id=187979
<rdar://problem/42559346>
Reviewed by Wenson Hsieh.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit:
- Configurations/FeatureDefines.xcconfig:
Source/WebKitLegacy/mac:
- Configurations/FeatureDefines.xcconfig:
Tools:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234181 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:15 AM Changeset in webkit [234241] by
-
- 11 edits7 adds in branches/safari-606-branch
Cherry-pick r234149. rdar://problem/42604679
Cannot view PDF's on my.gov.au: "Refused to load https://my.gov.au/attachment/viewAttachment because it
appears in neither the object-src directive nor the default-src directive of the Content Security Policy"
https://bugs.webkit.org/show_bug.cgi?id=187870
<rdar://problem/41190880>
Reviewed by Dean Jackson.
Source/WebCore:
Fixes an issue where opening attachments on my.gov.au would show a "Blocked Plug-in" message.
Opening an attachment on my.gov.au opens a same-origin plugin document in a child window. Currently
same-origin plugin documents inherit their CSP policy from their opener. If the opener's CSP policy
disallows embedding plugins then the plugin document would be blocked from loading a plugin. For now
we relax the inheritance model such that we only inherit the plugin-types and report-uri directives
from the opener.
Developers that want to block plugin content from being loaded in a same-origin child window must now
serve such plugin content with a CSP policy that includes "object-src 'none'". This matches the behavior
described in the second Note in section object-src of the CSP 3 spec: <https://w3c.github.io/webappsec-csp/#directive-object-src>
(Editor's Draft, 10 July 2018). It also makes the behavior in WebKit more closely aligned with the
behavior of Chrome and Firefox.
Tests: http/tests/security/contentSecurityPolicy/same-origin-plugin-document-allowed-in-child-window.html
http/tests/security/contentSecurityPolicy/same-origin-plugin-document-blocked-in-child-window-report.php
http/tests/security/contentSecurityPolicy/same-origin-plugin-document-with-csp-blocked-in-child-window.html
- dom/Document.cpp: (WebCore::Document::initContentSecurityPolicy): For plugin documents that have an opener call ContentSecurityPolicy::createPolicyForPluginDocumentFrom() to only inherit the plugin-types and report-uri directives from its opener's CSP policy. Otherwise, call ContentSecurityPolicy::copyStateFrom() to inherit all directives from the owner frame as we do now.
- page/csp/ContentSecurityPolicy.cpp: (WebCore::ContentSecurityPolicy::createPolicyForPluginDocumentFrom): Create a new policy from the specified policy inheriting only the plugin-types and report-uri directives.
- page/csp/ContentSecurityPolicy.h: Define a new PolicyFrom enumerator, InheritedForPluginDocument, for plugin documents loaded in a child window.
- page/csp/ContentSecurityPolicyDirectiveList.cpp: (WebCore::ContentSecurityPolicyDirectiveList::parse): When policyFrom is InheritedForPluginDocument then only recognize the plugin-types and report-uri directives when parsing the policy.
LayoutTests:
Add new tests and fix up the existing test http/tests/security/contentSecurityPolicy/same-origin-plugin-document-blocked-in-child-window.html
so that still tests a scenario where a same-origin plugin document loaded in a child window is blocked from
loading its plugin now that that "object-src: 'none'" is no longer inherited by the plugin document.
- http/tests/plugins/resources/plugin-document-alert-and-notify-done.pl:
- http/tests/security/contentSecurityPolicy/resources/checkDidSameOriginChildWindowLoad.js: Added. (checkDidSameOriginChildWindowLoadAndNotifyDone): (checkDidLoad):
- http/tests/security/contentSecurityPolicy/same-origin-plugin-document-allowed-in-child-window-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/same-origin-plugin-document-allowed-in-child-window.html: Added.
- http/tests/security/contentSecurityPolicy/same-origin-plugin-document-blocked-in-child-window-expected.txt:
- http/tests/security/contentSecurityPolicy/same-origin-plugin-document-blocked-in-child-window-report-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/same-origin-plugin-document-blocked-in-child-window-report.php: Added.
- http/tests/security/contentSecurityPolicy/same-origin-plugin-document-blocked-in-child-window.html:
- http/tests/security/contentSecurityPolicy/same-origin-plugin-document-with-csp-blocked-in-child-window-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/same-origin-plugin-document-with-csp-blocked-in-child-window.html: Added.
- platform/ios/TestExpectations: Skip the included tests as we do not support plugins on iOS.
- platform/win/TestExpectations: Skip the included tests as plugins do not seem to work on Windows. We currently skip many (if not all) plugin tests on Windows despite <rdar://problem/5074411> being marked as Closed (why?).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234149 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:14 AM Changeset in webkit [234240] by
-
- 2 edits in branches/safari-606-branch/Source/WebCore
Cherry-pick r234140. rdar://problem/42606763
REGRESSION(r234055): inverted return values in MediaPlayer::wouldTaintOrigin()
https://bugs.webkit.org/show_bug.cgi?id=187944
Reviewed by Carlos Garcia Campos.
The MediaPlayer::wouldTaintOrigin(), as introduced in r234055, should
return false when the URL protocol isdata:, and should return true
when the given SecurityOrigin cannot access the media URL.
This matches behavior of CanvasRenderingContext::wouldTaintOrigin()
which the new method falls back to when the MediaPlayerPrivate
implementation doesn't or can't determine the would-taint result.
This fixes a bunch of failing and timing-out WebGL test cases on ports
using GStreamer (on which the MediaPlayerPrivate derivate doesn't
implement the wouldTaintOrigin() method).
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::wouldTaintOrigin const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234140 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:14 AM Changeset in webkit [234239] by
-
- 3 edits in branches/safari-606-branch/Source/WebKit
Cherry-pick r234124. rdar://problem/42604550
Crash when loadViewIfRequired called while WKFullScreenViewController is being deallocated.
https://bugs.webkit.org/show_bug.cgi?id=187920
rdar://problem/41324023
Patch by Jeremy Jones <jeremyj@apple.com> on 2018-07-23
Reviewed by Eric Carlson.
Clear dangling weak-ref.
Prevent async playback state calls from instantiating the interface.
Release WKFullScreenViewController when it is no longer needed.
- UIProcess/ios/fullscreen/WKFullScreenViewController.mm: (-[WKFullScreenViewController dealloc]): (-[WKFullScreenViewController setPlaying:]): (-[WKFullScreenViewController setAnimating:]):
- UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm: (-[WKFullScreenWindowController _completedExitFullScreen]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234124 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:14 AM Changeset in webkit [234238] by
-
- 2 edits in branches/safari-606-branch/Source/WebCore
Cherry-pick r234113. rdar://problem/42604546
WebCore::primaryScreenDisplayID() always return 0
https://bugs.webkit.org/show_bug.cgi?id=187922
<rdar://problem/42286933>
Reviewed by Geoffrey Garen.
This function should return a valid display ID.
No new tests. Testing this requires a dual monitor setup.
- platform/mac/PlatformScreenMac.mm: (WebCore::primaryScreenDisplayID):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234113 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:14 AM Changeset in webkit [234237] by
-
- 4 edits2 adds in branches/safari-606-branch
Cherry-pick r234112. rdar://problem/42604514
AX: Press tab to highlight items on a webpage is not working with voiceover enabled
https://bugs.webkit.org/show_bug.cgi?id=187824
Reviewed by Zalan Bujtas.
Source/WebCore:
We are deferring posting focused element change notification when the document needs a
style recalculation. However, we only perform the cache update after a layout is completed.
Added a timer to perform the cache update in the next runloop when non-layout type of mutation
happens.
Test: accessibility/mac/tab-focus-post-notification.html
- accessibility/AXObjectCache.cpp: (WebCore::AXObjectCache::AXObjectCache): (WebCore::AXObjectCache::~AXObjectCache): (WebCore::AXObjectCache::deferFocusedUIElementChangeIfNeeded): (WebCore::AXObjectCache::performCacheUpdateTimerFired):
- accessibility/AXObjectCache.h: (WebCore::AXObjectCache::AXObjectCache): (WebCore::AXObjectCache::performCacheUpdateTimerFired):
LayoutTests:
- accessibility/mac/tab-focus-post-notification-expected.txt: Added.
- accessibility/mac/tab-focus-post-notification.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234112 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:14 AM Changeset in webkit [234236] by
-
- 12 edits1 add in branches/safari-606-branch
Cherry-pick r234111. rdar://problem/42604691
WebResourceLoadStatisticsStore fails to unregister itself as a MessageReceiver in its destructor
https://bugs.webkit.org/show_bug.cgi?id=187910
<rdar://problem/42356526>
Reviewed by Brent Fulgham.
Source/WebCore:
Add internals API that causes the ResourceLoadObserver to notify its observer, and avoid waiting
for the 5 second delay.
- testing/Internals.cpp: (WebCore::Internals::notifyResourceLoadObserver):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
The WebResourceLoadStatisticsStore was only removing itself as a MessageReceiver from the WebProcessProxy
and that WebProcessProxy's connection was getting closed. However, it is possible for the
WebResourceLoadStatisticsStore to get destroyed before this happens. This would lead to crashes such as
the one in <rdar://problem/42356526>.
To address the issue, we let the WebsiteDataStore take care of registering / unregistering the
WebResourceLoadStatisticsStore as a MessageReceiver with the WebProcessProxy. This is more reliable since
the WebsiteDataStore is the one that subclasses WebProcessLifetimeObserver. Make sure the
WebResourceLoadStatisticsStore is removed as a MessageReceiver whenever the WebsiteDataStore is destroyed
or WebsiteDataStore::m_resourceLoadStatistics gets cleared.
- UIProcess/WebResourceLoadStatisticsStore.cpp:
- UIProcess/WebResourceLoadStatisticsStore.h: Drop logic to add / remove the WebResourceLoadStatisticsStore as a receiver now that the WebsiteDataStore takes care of it.
- UIProcess/WebsiteData/WebsiteDataStore.cpp: (WebKit::WebsiteDataStore::~WebsiteDataStore): Make sure the WebResourceLoadStatisticsStore gets unregistered as a MessageReceiver from all associated WebProcessProxy objects when the WebsiteDataStore gets destroyed.
(WebKit::WebsiteDataStore::webProcessWillOpenConnection):
(WebKit::WebsiteDataStore::webProcessDidCloseConnection):
Register / Unregister the WebResourceLoadStatisticsStore as a MessageReceiver with the WebProcessProxy.
(WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled):
Make sure we unregister the WebResourceLoadStatisticsStore as a MessageReceiver with all associated
WebProcessProxy objects before we clear m_resourceLoadStatistics as this will causes the
WebResourceLoadStatisticsStore to get destroyed.
(WebKit::WebsiteDataStore::unregisterWebResourceLoadStatisticsStoreAsMessageReceiver):
(WebKit::WebsiteDataStore::registerWebResourceLoadStatisticsStoreAsMessageReceiver):
Add utility functions to register / unregister WebResourceLoadStatisticsStore as a MessageReceiver with
all associated WebProcessProxy objects.
(WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback):
Register the new WebResourceLoadStatisticsStore as a MessageReceiver with all associated WebProcessProxy
objects in case setResourceLoadStatisticsEnabled(true) gets called *after* we've already started
WebProcesses.
- UIProcess/WebsiteData/WebsiteDataStore.h:
Tools:
Add API test coverage.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm: (-[DisableITPDuringNavigationDelegate webView:didCommitNavigation:]): (-[DisableITPDuringNavigationDelegate webView:didFinishNavigation:]): (TEST):
- TestWebKitAPI/Tests/WebKitCocoa/notify-resourceLoadObserver.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234111 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:14 AM Changeset in webkit [234235] by
-
- 6 edits2 adds in branches/safari-606-branch
Cherry-pick r234098. rdar://problem/42507862
fullscreen env() variables should have initial values
https://bugs.webkit.org/show_bug.cgi?id=187897
<rdar://problem/42485682>
Reviewed by Sam Weinig.
Source/WebCore:
The env() values for fullscreen properties need to be
initialized, rather than wait for values to be set from WebKit.
Without this, feature detection doesn't work, and properties
won't parse correctly.
Test: fullscreen/fullscreen-env-initial.html
- dom/ConstantPropertyMap.cpp: (WebCore::ConstantPropertyMap::buildValues): Initialize the fullscreen values. (WebCore::ConstantPropertyMap::updateConstantsForFullscreen): Renamed function, because it also updates the duration value. (WebCore::ConstantPropertyMap::didChangeFullscreenInsets): Call new name. (WebCore::ConstantPropertyMap::updateConstantsForFullscreenInsets): Deleted.
- dom/ConstantPropertyMap.h:
- page/Page.cpp: (WebCore::Page::setFullscreenAutoHideDuration): Don't change the value if it doesn't need it.
- page/Page.h: Add accessor for fullscreenAutoHideDuration. Also add a member variable. (WebCore::Page::fullscreenAutoHideDuration const):
LayoutTests:
- fullscreen/fullscreen-env-initial-expected.html: Added.
- fullscreen/fullscreen-env-initial.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:14 AM Changeset in webkit [234234] by
-
- 3 edits in branches/safari-606-branch/Source/WebKit
Cherry-pick r234067. rdar://problem/42451597
Occasional crash under -[WKFormInputSession setSuggestions:]
https://bugs.webkit.org/show_bug.cgi?id=187869
<rdar://problem/41357063>
Reviewed by Dean Jackson.
- UIProcess/ios/WKContentViewInteraction.h:
- UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView inputDelegate]): Make inputDelegate weak.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234067 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:14 AM Changeset in webkit [234233] by
-
- 21 edits4 copies2 moves5 adds in branches/safari-606-branch
Cherry-pick r234064. rdar://problem/42451634
Picking a color from the color panel for typing attributes needs to inverse transform through color-filter
https://bugs.webkit.org/show_bug.cgi?id=187846
Patch by Ryosuke Niwa <rniwa@apple.com> on 2018-07-20
Reviewed by Simon Fraser.
Source/WebCore:
This patch refines the color inversion for editing introduced in r234005 so that font panels and WebKit embedders
can get and set inverted colors using attributed strings for a selected text in an editable region.
More specifically, when font panels or WebKit embedders set a font color or a background color via WebView's
_applyStyleToSelection and _applyEditingStyleToSelection, WebKit would automatically invert the color before inserting
into DOM so that the color visible to the user matches that's given to WebKit. Conversely,
[WebView attributedSubstringFromRange:nsRange] now return the color visible to the user, i.e. the color after
the color filter had been applied, so that some WebKit embedders can present the visually identical color to the user.
Because DOM never sees the color filter's effect in the computed style, etc... this patch reverts the change made to
StyleChange in r234005 to avoid inverting the color passed to execCommand. This makes editing apps which is unaware
of the dark mode or -apple-color-filter continue to function (because the color picker implemented in DOM will be
applied of the same color filter before being presented to the user).
Finally, this patch introduces a testing hook in applyCommandToFrame so that executing foreColor or backColor with
the soruce of CommandFromMenuOrKeyBinding would trigger the same code path as the one taken by Objective-C
Tests: editing/execCommand/set-backColor-with-color-filter-from-scripts.html
editing/execCommand/set-foreColor-with-color-filter-from-scripts.html
editing/mac/attributed-string/attribute-string-for-copy-with-color-filter.html
editing/style/set-backColor-with-color-filter.html
editing/style/set-foreColor-with-color-filter.html
- editing/EditingStyle.cpp: (WebCore::EditingStyle::inverseTransformColorIfNeeded): Added. (WebCore::StyleChange::StyleChange): Revert the change made in r234005 since this code is also used by execCommand which is not desirable, and won't work for background color. (WebCore::StyleChange::extractTextStyles): Ditto.
- editing/EditingStyle.h:
- editing/Editor.cpp: (WebCore::Editor::applyStyle): (WebCore::Editor::applyStyleToSelection): Call EditingStyle::inverseTransformColorIfNeeded when ColorFilterMode is set to InvertColor.
- editing/Editor.h:
- editing/EditorCommand.cpp: (WebCore::applyCommandToFrame): Added the aforementioned testing hook.
- editing/cocoa/HTMLConverter.mm: (WebCore::editingAttributedStringFromRange): Take the color filtr into account. Some WebKit embedders use this function to compute the font color in the selected text. Note that this function is mostly used for input methods so the color doesn't really matter, and its implementation is distinct from that of HTMLConverter.
Source/WebKitLegacy/mac:
Invert the filtered font and background colors when using font panels, font pasteboard, and other Objective-C APIs.
- WebView/WebHTMLView.mm: (-[WebHTMLView _applyStyleToSelection:withUndoAction:]): Share code with _applyEditingStyleToSelection. (-[WebHTMLView _applyEditingStyleToSelection:withUndoAction:]):
Tools:
Fixed the bug that testRunner.execCommand was using the second argument as the value.
The second argument, aShowDefaultUI, should always be ignored in testRunner.execCommand,
and the third argument should be used as the value. DumpRenderTree's implementation does this already.
- WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
- WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::execCommand):
- WebKitTestRunner/InjectedBundle/TestRunner.h:
LayoutTests:
Added tests to make sure foreground or background colors specified in execCommand don't get inverted.
Fixed the test which was asserting that textInputController.attributedSubstringFromRange doesn't invert the color
since that's exactly what WebKit embedders uses to compute the style for color pickers.
Added new tests for copy & paste case using textInputController.legacyAttributedString.
- editing/execCommand/set-backColor-with-color-filter-from-scripts-expected.txt: Added.
- editing/execCommand/set-backColor-with-color-filter-from-scripts.html: Added.
- editing/execCommand/set-foreColor-with-color-filter-from-scripts-expected.txt: Added.
- editing/execCommand/set-foreColor-with-color-filter-from-scripts.html: Added.
- editing/mac/attributed-string/attrib-string-range-with-color-filter-expected.txt:
- editing/mac/attributed-string/attrib-string-range-with-color-filter.html: This test uses attributedSubstringFromRange, which implemented using editingAttributedStringFromRange in WebCore. Since this is exactly what WebKit embedders uses to compute the current style of the selected text, we need to invert the color here. This API's main clinet is input methods so this shouldn't affect other editing operations, in particular, copy and paste, which uses HTMLConverter.
- editing/mac/attributed-string/attribute-string-for-copy-with-color-filter-expected.txt: Added.
- editing/mac/attributed-string/attribute-string-for-copy-with-color-filter.html: Added. Make sure the attributed string generated for copy & paste does not invert foreground or background colors via textInputController.legacyAttributedString. This is testing HTMLConverter, not editingAttributedStringFromRange, used by WebKit embedders and input methods.
- editing/mac/attributed-string/attributed-string-for-typing-with-color-filter-expected.txt:
- editing/mac/attributed-string/attributed-string-for-typing-with-color-filter.html: Added background color in the test.
- editing/style/set-backColor-with-color-filter-expected.txt: Added.
- editing/style/set-backColor-with-color-filter.html: Added.
- editing/style/set-foreColor-with-color-filter-expected.txt: Renamed from exec-command-foreColor-with-color-filter-expected.txt.
- editing/style/set-foreColor-with-color-filter.html: Renamed from exec-command-foreColor-with-color-filter.html. Updated the test to use testRunner.execCommand which uses CommandFromMenuOrKeyBinding in applyCommandToFrame since we're trying to test the code path taken by WebKit embedders and font panel here.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234064 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:14 AM Changeset in webkit [234232] by
-
- 14 edits3 adds in branches/safari-606-branch
Cherry-pick r234055. rdar://problem/42451567
HLS resources with remote subresources will not taint canvasses.
https://bugs.webkit.org/show_bug.cgi?id=187731
<rdar://problem/42290703>
Reviewed by Brady Eidson.
Source/WebCore:
Test: http/tests/security/canvas-remote-read-remote-video-hls.html
Most media sources are single-resource; they are accessed from a single origin. HLS manifests can contain many
subresources from arbitrary origins, and canvases should be tainted when painted from media elements whose
subresources were retrieved from tainting origins.
Add a new method to HTMLMediaElement, wouldTaintOrigin(), taking a SecurityOrigin, and returning whether the
media element would taint that origin. This gets piped all the way down to MediaPlayerPrivateAVFoundationObjC
which uses WebCoreNSURLSession to track all the origins of all the responses which resulted from the media
element's load.
Drive-by fix: also fix this issue for media elements which render to an AudioContext.
Drive-by fix #2: CanvasRenderingContext2DBase::createPattern() needs to check the return value of
ImageBuffer::create() before using it.
- Modules/webaudio/MediaElementAudioSourceNode.cpp: (WebCore::MediaElementAudioSourceNode::wouldTaintOrigin):
- html/HTMLMediaElement.cpp: (WebCore::HTMLMediaElement::didAttachRenderers): (WebCore::HTMLMediaElement::didDetachRenderers): (WebCore::HTMLMediaElement::scheduleUpdateShouldAutoplay):
- html/HTMLMediaElement.h: (WebCore::HTMLMediaElement::wouldTaintOrigin const):
- html/canvas/CanvasRenderingContext.cpp: (WebCore::CanvasRenderingContext::wouldTaintOrigin):
- html/canvas/CanvasRenderingContext2DBase.cpp: (WebCore::CanvasRenderingContext2DBase::createPattern):
- platform/graphics/MediaPlayer.cpp: (WebCore::MediaPlayer::wouldTaintOrigin const):
- platform/graphics/MediaPlayer.h:
- platform/graphics/MediaPlayerPrivate.h: (WebCore::MediaPlayerPrivateInterface::hasSingleSecurityOrigin const): (WebCore::MediaPlayerPrivateInterface::wouldTaintOrigin const):
- platform/graphics/avfoundation/objc/CDMSessionAVContentKeySession.mm: (WebCore::CDMSessionAVContentKeySession::update):
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
- platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm: (WebCore::MediaPlayerPrivateAVFoundationObjC::wouldTaintOrigin const):
- platform/network/cocoa/WebCoreNSURLSession.h:
- platform/network/cocoa/WebCoreNSURLSession.mm: (-[WebCoreNSURLSession task:didReceiveResponseFromOrigin:]): (-[WebCoreNSURLSession wouldTaintOrigin:]): (-[WebCoreNSURLSessionDataTask resource:receivedResponse:]):
LayoutTests:
- http/tests/media/resources/hls/test-vod-localhost.m3u8: Added.
- http/tests/security/canvas-remote-read-remote-video-hls-expected.txt: Added.
- http/tests/security/canvas-remote-read-remote-video-hls.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234055 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:14 AM Changeset in webkit [234231] by
-
- 2 edits in branches/safari-606-branch/Source/WebKit
Cherry-pick r234054. rdar://problem/42451625
[macOS] Relax WebKit sandbox to permit proper App Store behavior
https://bugs.webkit.org/show_bug.cgi?id=187831
<rdar://problem/42047455>
Reviewed by Alexey Proskuryakov.
The Mac App Store is unable to perform some gift card redemption tasks on macOS due to missing sandbox permissions.
This patch adds those permissions.
- PluginProcess/mac/com.apple.WebKit.plugin-common.sb.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234054 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:14 AM Changeset in webkit [234230] by
-
- 2 edits in branches/safari-606-branch/Source/WebCore
Cherry-pick r234053. rdar://problem/42451651
Update FrameView::paintContents to use release logging.
https://bugs.webkit.org/show_bug.cgi?id=187854
<rdar://problem/42432371>
Reviewed by Simon Fraser.
Adding release logging helps identifying blank content cases.
- page/FrameView.cpp: (WebCore::FrameView::paintContents):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234053 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:14 AM Changeset in webkit [234229] by
-
- 2 edits in branches/safari-606-branch/Source/WebKit
Cherry-pick r234023. rdar://problem/42451655
Null pointer dereference under WebPage::autofillLoginCredentials()
https://bugs.webkit.org/show_bug.cgi?id=187823
<rdar://problem/37152195>
Reviewed by David Kilzer.
Deal with m_assistedNode being null under WebPage::autofillLoginCredentials().
- WebProcess/WebPage/ios/WebPageIOS.mm: (WebKit::WebPage::autofillLoginCredentials):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234023 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Jul 25, 2018:
- 8:34 PM Changeset in webkit [234228] by
-
- 2 edits1 add in trunk/LayoutTests
[Curl] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=188034
Unreviewed WinCairo gardening.
- httpxmlhttprequest/simple-sync.html: Added.
- platform/wincairo/TestExpectations:
- 7:32 PM Changeset in webkit [234227] by
-
- 34 edits1 add in trunk/Source/JavaScriptCore
[JSC API] We should support the symbol type in our C/Obj-C API
https://bugs.webkit.org/show_bug.cgi?id=175836
Reviewed by Filip Pizlo.
This patch makes the following API additions:
1) Test if a JSValue/JSValueRef is a symbol via any of the methods API are able to test for the types of other JSValues.
2) Create a symbol on both APIs.
3) Get/Set/Delete/Define property now take ids in the Obj-C API.
4) Add Get/Set/Delete in the C API.
We can do 3 because it is both binary and source compatable with
the existing API. I added (4) because the current property access
APIs only have the ability to get Strings. It was possible to
merge symbols into JSStringRef but that felt confusing and exposes
implementation details of our engine. The new functions match the
same meaning that they have in JS, thus should be forward
compatible with any future language extensions.
Lastly, this patch adds the same availability preproccessing phase
in WebCore to JavaScriptCore, which enables TBA features for
testing on previous releases.
- API/APICast.h:
- API/JSBasePrivate.h:
- API/JSContext.h:
- API/JSContextPrivate.h:
- API/JSContextRef.h:
- API/JSContextRefInternal.h:
- API/JSContextRefPrivate.h:
- API/JSManagedValue.h:
- API/JSObjectRef.cpp:
(JSObjectHasPropertyKey):
(JSObjectGetPropertyKey):
(JSObjectSetPropertyKey):
(JSObjectDeletePropertyKey):
- API/JSObjectRef.h:
- API/JSRemoteInspector.h:
- API/JSTypedArray.h:
- API/JSValue.h:
- API/JSValue.mm:
(+[JSValue valueWithNewSymbolFromDescription:inContext:]):
(performPropertyOperation):
(-[JSValue valueForProperty:valueForProperty:]):
(-[JSValue setValue:forProperty:setValue:forProperty:]):
(-[JSValue deleteProperty:deleteProperty:]):
(-[JSValue hasProperty:hasProperty:]):
(-[JSValue defineProperty:descriptor:defineProperty:descriptor:]):
(-[JSValue isSymbol]):
(-[JSValue objectForKeyedSubscript:]):
(-[JSValue setObject:forKeyedSubscript:]):
(-[JSValue valueForProperty:]): Deleted.
(-[JSValue setValue:forProperty:]): Deleted.
(-[JSValue deleteProperty:]): Deleted.
(-[JSValue hasProperty:]): Deleted.
(-[JSValue defineProperty:descriptor:]): Deleted.
- API/JSValueRef.cpp:
(JSValueGetType):
(JSValueIsSymbol):
(JSValueMakeSymbol):
- API/JSValueRef.h:
- API/WebKitAvailability.h:
- API/tests/CurrentThisInsideBlockGetterTest.mm:
- API/tests/CustomGlobalObjectClassTest.c:
- API/tests/DateTests.mm:
- API/tests/JSExportTests.mm:
- API/tests/JSNode.c:
- API/tests/JSNodeList.c:
- API/tests/Node.c:
- API/tests/NodeList.c:
- API/tests/minidom.c:
- API/tests/testapi.c:
(main):
- API/tests/testapi.cpp: Added.
(APIString::APIString):
(APIString::~APIString):
(APIString::operator JSStringRef):
(APIContext::APIContext):
(APIContext::~APIContext):
(APIContext::operator JSGlobalContextRef):
(APIVector::APIVector):
(APIVector::~APIVector):
(APIVector::append):
(testCAPIViaCpp):
(TestAPI::evaluateScript):
(TestAPI::callFunction):
(TestAPI::functionReturnsTrue):
(TestAPI::check):
(TestAPI::checkJSAndAPIMatch):
(TestAPI::interestingObjects):
(TestAPI::interestingKeys):
(TestAPI::run):
- API/tests/testapi.mm:
(testObjectiveCAPIMain):
- JavaScriptCore.xcodeproj/project.pbxproj:
- config.h:
- postprocess-headers.sh:
- shell/CMakeLists.txt:
- testmem/testmem.mm:
- 6:29 PM Changeset in webkit [234226] by
-
- 3 edits in trunk/Source/WebCore
Allow ActiveDOMObject's canSuspend / suspend / resume overrides to destroy ActiveDOMObjects
https://bugs.webkit.org/show_bug.cgi?id=188025
Reviewed by Alex Christensen.
Apply the same logic as in ScriptExecutionContext::stopActiveDOMObjects() to support destruction of
ActiveDOMObjects while we're calling ActiveDOMObject's canSuspend / suspend / resume overrides.
We copy m_activeDOMObjects into a Vector and iterate over the copy instead of m_activeDOMObjects.
Since ActiveDOMObject is not RefCounted or CanMakeWeakPtr, we verify that the raw pointer is still
valid by checking if m_activeDOMObjects still contains it, as we iterate. This is safe as the
ActiveDOMObject destructor removes the object from ScriptExecutionContext::m_activeDOMObjects.
New ActiveDOMObjects with the same pointer value cannot be created while we iterate as we already
prevent the construction of new ActiveDOMObjects while we iterate via RELEASE_ASSERT().
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjectsForDocumentSuspension):
(WebCore::ScriptExecutionContext::forEachActiveDOMObject const):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::stopActiveDOMObjects):
(WebCore::ScriptExecutionContext::willDestroyActiveDOMObject):
- dom/ScriptExecutionContext.h:
- 6:08 PM Changeset in webkit [234225] by
-
- 1 copy in tags/Safari-606.1.31
Tag Safari-606.1.31.
- 5:34 PM Changeset in webkit [234224] by
-
- 2 edits in trunk/Source/WebCore
Systems with no NSScreens hitting assertion in rendererIDForDisplay when creating WebGL context
https://bugs.webkit.org/show_bug.cgi?id=188023
<rdar://problem/42476622>
Patch by Justin Fan <Justin Fan> on 2018-07-25
Reviewed by Simon Fraser.
On systems with no NSScreens, PlatformScreenMac's screenData map is not populated; rendererIDForDisplay
will thus hit an assertion rather than returning 0. Removing the assertion for now.
Covered by existing tests.
- platform/mac/PlatformScreenMac.mm:
(WebCore::rendererIDForDisplay):
- 5:29 PM Changeset in webkit [234223] by
-
- 2 edits in trunk/Source/WebKit
[macOS] Update sandboxes for revised OpenCL calls and streaming media
https://bugs.webkit.org/show_bug.cgi?id=188013
<rdar://problem/42594262>
Reviewed by Eric Carlson.
Testing logs from recent Mojave builds shows that OpenCL is checking more CPU-specific values as part of WebKit
painting operations. We need to allow these checks in the sandbox to support these more optimized drawing operations.
I also corrected some sandbox violations I found while investigating streaming media issues.
- WebProcess/com.apple.WebProcess.sb.in:
- 5:29 PM Changeset in webkit [234222] by
-
- 2 edits in trunk/Source/WebCore
Build fix after r234215. Unreviewed.
- rendering/RenderTheme.cpp:
- 5:27 PM Changeset in webkit [234221] by
-
- 7 edits in branches/safari-606-branch/Source
Versioning.
- 5:22 PM Changeset in webkit [234220] by
-
- 3 edits in trunk/Tools
[ews-build] Add build steps DownloadBuiltProduct and ExtractBuiltProduct
https://bugs.webkit.org/show_bug.cgi?id=188031
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-build/steps.py:
(DownloadBuiltProduct): Added build step DownloadBuiltProduct.
(ExtractBuiltProduct): Added build step ExtractBuiltProduct.
- BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
- 5:19 PM Changeset in webkit [234219] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Dark Mode: Breakpoint editor in JS debugger has inconsistent background
https://bugs.webkit.org/show_bug.cgi?id=188026
Reviewed by Matt Baker.
- UserInterface/Views/DarkMode.css:
(@media (prefers-dark-interface)):
(.edit-breakpoint-popover-condition):
(.breakpoint-action-eval-editor):
- 4:15 PM Changeset in webkit [234218] by
-
- 3 edits in trunk/Tools
[ews-build] Add build step UploadBuiltProduct
https://bugs.webkit.org/show_bug.cgi?id=188016
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-build/steps.py:
(UploadBuiltProduct): Added build step UploadBuiltProduct.
- BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-test.
- 4:03 PM Changeset in webkit [234217] by
-
- 3 edits in trunk/Tools
[ews-build] Add build step ArchiveBuiltProduct
https://bugs.webkit.org/show_bug.cgi?id=188014
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-build/steps.py:
(ArchiveBuiltProduct): Added build step ArchiveBuiltProduct.
- BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.
- 3:51 PM Changeset in webkit [234216] by
-
- 2 edits in trunk/Source/WebKit
Mask AVBackgroundView to the corner radius.
https://bugs.webkit.org/show_bug.cgi?id=187976
rdar://problem/41810866
Patch by Jeremy Jones <jeremyj@apple.com> on 2018-07-25
Reviewed by Jon Lee.
This changes sets the appropriate mask to the layer so the corners look correct.
- UIProcess/ios/fullscreen/WKFullscreenStackView.mm:
(-[WKFullscreenStackView init]):
- 3:44 PM Changeset in webkit [234215] by
-
- 30 edits2 adds15 deletes in trunk
REGRESSION(r227577) Text on TV & Movies page doesn't wrap properly in iTunes
https://bugs.webkit.org/show_bug.cgi?id=188018
<rdar://problem/42517520>
Reviewed by Dean Jackson.
Source/WebCore:
Manual rollout of r227577.
Test: fast/overflow/line-clamp-with-text-shadow.html
- Sources.txt:
- WebCore.xcodeproj/project.pbxproj:
- css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::valueForPropertyinStyle):
- css/CSSProperties.json:
- css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyValueWebkitLinesClamp): Deleted.
- css/parser/CSSParserContext.cpp:
(WebCore::CSSParserContext::CSSParserContext):
- css/parser/CSSParserContext.h:
(WebCore::CSSParserContextHash::hash):
- css/parser/CSSPropertyParser.cpp:
(WebCore::CSSPropertyParser::parseSingleValue):
(WebCore::consumeLinesClamp): Deleted.
- page/Settings.yaml:
- rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::willCreateColumns const):
(WebCore::getHeightForLineCount):
(WebCore::RenderBlockFlow::heightForLineCount):
(WebCore::RenderBlockFlow::layoutExcludedChildren):
(WebCore::RenderBlockFlow::logicalHeightForLineCount): Deleted.
(WebCore::RenderBlockFlow::logicalHeightExcludingLineCount): Deleted.
- rendering/RenderBlockFlow.h:
- rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::applyLineClamp):
- rendering/RenderFragmentContainer.cpp:
(WebCore::RenderFragmentContainer::pageLogicalHeightForOffset const): Deleted.
- rendering/RenderFragmentContainer.h:
- rendering/RenderFragmentedFlow.cpp:
(WebCore::RenderFragmentedFlow::validateFragments):
(WebCore::RenderFragmentedFlow::pageLogicalHeightForOffset const):
(WebCore::RenderFragmentedFlow::pageRemainingLogicalHeightForOffset const):
- rendering/RenderFragmentedFlow.h:
- rendering/RenderLinesClampFlow.cpp: Removed.
- rendering/RenderLinesClampFlow.h: Removed.
- rendering/RenderLinesClampSet.cpp: Removed.
- rendering/RenderLinesClampSet.h: Removed.
- rendering/RenderMultiColumnFlow.cpp:
(WebCore::RenderMultiColumnFlow::isColumnSpanningDescendant const): Deleted.
(WebCore::RenderMultiColumnFlow::createMultiColumnSet): Deleted.
- rendering/RenderMultiColumnFlow.h:
(WebCore::RenderMultiColumnFlow::multiColumnBlockFlow const): Deleted.
(WebCore::RenderMultiColumnFlow::hasColumnSpanner const): Deleted.
(WebCore::RenderMultiColumnFlow::findColumnSpannerPlaceholder const): Deleted.
(WebCore::RenderMultiColumnFlow::columnCount const): Deleted.
(WebCore::RenderMultiColumnFlow::columnWidth const): Deleted.
(WebCore::RenderMultiColumnFlow::columnHeightAvailable const): Deleted.
(WebCore::RenderMultiColumnFlow::setColumnHeightAvailable): Deleted.
(WebCore::RenderMultiColumnFlow::inBalancingPass const): Deleted.
(WebCore::RenderMultiColumnFlow::setInBalancingPass): Deleted.
(WebCore::RenderMultiColumnFlow::needsHeightsRecalculation const): Deleted.
(WebCore::RenderMultiColumnFlow::setNeedsHeightsRecalculation): Deleted.
(WebCore::RenderMultiColumnFlow::shouldRelayoutForPagination const): Deleted.
(WebCore::RenderMultiColumnFlow::setColumnCountAndWidth): Deleted.
(WebCore::RenderMultiColumnFlow::progressionIsInline const): Deleted.
(WebCore::RenderMultiColumnFlow::setProgressionIsInline): Deleted.
(WebCore::RenderMultiColumnFlow::progressionIsReversed const): Deleted.
(WebCore::RenderMultiColumnFlow::setProgressionIsReversed): Deleted.
(WebCore::RenderMultiColumnFlow::spannerMap): Deleted.
- rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::collectLayerFragments):
(WebCore::RenderMultiColumnSet::columnTranslationForOffset const):
- rendering/RenderMultiColumnSet.h:
(WebCore::RenderMultiColumnSet::multiColumnBlockFlow const): Deleted.
(WebCore::RenderMultiColumnSet::multiColumnFlow const): Deleted.
(WebCore::RenderMultiColumnSet::logicalTopInFragmentedFlow const): Deleted.
(WebCore::RenderMultiColumnSet::logicalBottomInFragmentedFlow const): Deleted.
(WebCore::RenderMultiColumnSet::logicalHeightInFragmentedFlow const): Deleted.
(WebCore::RenderMultiColumnSet::computedColumnCount const): Deleted.
(WebCore::RenderMultiColumnSet::computedColumnWidth const): Deleted.
(WebCore::RenderMultiColumnSet::computedColumnHeight const): Deleted.
(WebCore::RenderMultiColumnSet::columnHeightComputed const): Deleted.
(WebCore::RenderMultiColumnSet::setComputedColumnWidthAndCount): Deleted.
(WebCore::RenderMultiColumnSet::updateMinimumColumnHeight): Deleted.
(WebCore::RenderMultiColumnSet::minimumColumnHeight const): Deleted.
(WebCore::RenderMultiColumnSet::forcedBreaksCount const): Deleted.
(WebCore::RenderMultiColumnSet::hasBeenFlowed const): Deleted.
(WebCore::RenderMultiColumnSet::skipLayerFragmentCollectionForColumn const): Deleted.
(WebCore::RenderMultiColumnSet::customBlockProgressionAdjustmentForColumn const): Deleted.
(WebCore::RenderMultiColumnSet::ContentRun::ContentRun): Deleted.
(WebCore::RenderMultiColumnSet::ContentRun::assumedImplicitBreaks const): Deleted.
(WebCore::RenderMultiColumnSet::ContentRun::assumeAnotherImplicitBreak): Deleted.
(WebCore::RenderMultiColumnSet::ContentRun::breakOffset const): Deleted.
(WebCore::RenderMultiColumnSet::ContentRun::columnLogicalHeight const): Deleted.
- rendering/RenderObject.h:
(WebCore::RenderObject::isRenderLinesClampFlow const): Deleted.
(WebCore::RenderObject::isRenderLinesClampSet const): Deleted.
- rendering/style/LineClampValue.h:
(WebCore::LinesClampValue::LinesClampValue): Deleted.
(WebCore::LinesClampValue::isNone const): Deleted.
(WebCore::LinesClampValue::operator== const): Deleted.
(WebCore::LinesClampValue::operator!= const): Deleted.
(WebCore::LinesClampValue::start const): Deleted.
(WebCore::LinesClampValue::end const): Deleted.
(WebCore::LinesClampValue::center const): Deleted.
- rendering/style/RenderStyle.h:
(WebCore::RenderStyle::lineClamp const):
(WebCore::RenderStyle::setLineClamp):
(WebCore::RenderStyle::initialLineClamp):
(WebCore::RenderStyle::hasInlineColumnAxis const):
(WebCore::RenderStyle::linesClamp const): Deleted.
(WebCore::RenderStyle::hasLinesClamp const): Deleted.
(WebCore::RenderStyle::setLinesClamp): Deleted.
(WebCore::RenderStyle::initialLinesClamp): Deleted.
- rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator== const):
- rendering/style/StyleRareNonInheritedData.h:
- rendering/updating/RenderTreeBuilderMultiColumn.cpp:
(WebCore::isValidColumnSpanner):
(WebCore::RenderTreeBuilder::MultiColumn::createFragmentedFlow):
(WebCore::RenderTreeBuilder::MultiColumn::processPossibleSpannerDescendant):
Source/WebKit:
- WebProcess/WebPage/WebPage.cpp:
(WebKit::m_credentialsMessenger):
LayoutTests:
- fast/block/lines-clamp-advanced-expected.html: Removed.
- fast/block/lines-clamp-advanced-rl-expected.html: Removed.
- fast/block/lines-clamp-advanced-rl.html: Removed.
- fast/block/lines-clamp-advanced.html: Removed.
- fast/block/lines-clamp-basic-expected.html: Removed.
- fast/block/lines-clamp-basic-rl-expected.html: Removed.
- fast/block/lines-clamp-basic-rl.html: Removed.
- fast/block/lines-clamp-basic.html: Removed.
- fast/css/lines-clamp-parsing-expected.txt: Removed.
- fast/css/lines-clamp-parsing.html: Removed.
- fast/overflow/line-clamp-with-text-shadow-expected.html: Added.
- fast/overflow/line-clamp-with-text-shadow.html: Added.
- platform/ios-simulator-wk2/fast/overflow/line-clamp-expected.txt: Removed.
- 2:38 PM Changeset in webkit [234214] by
-
- 2 edits in trunk/Source/WebKit
Fix the build.
- UIProcess/mac/ServicesController.mm:
(WebKit::hasCompatibleServicesForItems):
I can't even.
- 1:56 PM Changeset in webkit [234213] by
-
- 2 edits in trunk/Source/WebKit
Crashing on some builds that don't have async NSSharingService API
https://bugs.webkit.org/show_bug.cgi?id=188015
<rdar://problem/42593935>
Reviewed by Eric Carlson.
- UIProcess/mac/ServicesController.mm:
(WebKit::hasCompatibleServicesForItems):
- 1:46 PM Changeset in webkit [234212] by
-
- 2 edits in trunk/LayoutTests
Layout Test media/audio-concurrent-supported.html is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=188017
Unreviewed test gardening.
- platform/ios-simulator-wk2/TestExpectations:
- 1:33 PM Changeset in webkit [234211] by
-
- 13 edits1 add in trunk
navigator.userAgent may return outdated value after webView.customUserAgent is set
https://bugs.webkit.org/show_bug.cgi?id=188009
<rdar://problem/42566456>
Reviewed by Alex Christensen.
Source/WebCore:
Invalidate the navigator.userAgent cache whenever the user agent gets changed to avoid exposing
outdated values to JavaScript.
- page/Navigator.cpp:
(WebCore::Navigator::userAgentChanged):
- page/Navigator.h:
- page/NavigatorID.idl:
- page/Page.cpp:
(WebCore::Page::userAgentChanged):
- page/Page.h:
Source/WebKit:
Let the page know when the user agent changes.
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setUserAgent):
Source/WebKitLegacy/mac:
Let the page know when the user agent changes.
- WebView/WebView.mm:
(-[WebView _preferencesChanged:]):
(-[WebView setApplicationNameForUserAgent:]):
(-[WebView _invalidateUserAgentCache]):
(-[WebView setCustomUserAgent:]):
- WebView/WebViewInternal.h:
Tools:
Add API test coverage.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/CustomUserAgent.mm: Added.
(TEST):
- 11:32 AM Changeset in webkit [234210] by
-
- 7 edits in trunk/Source/WebKit
Use CompletionHandler for policy decisions
https://bugs.webkit.org/show_bug.cgi?id=187975
Reviewed by Chris Dumez.
- UIProcess/WebFramePolicyListenerProxy.cpp:
(WebKit::WebFramePolicyListenerProxy::WebFramePolicyListenerProxy):
(WebKit::WebFramePolicyListenerProxy::use):
(WebKit::WebFramePolicyListenerProxy::download):
(WebKit::WebFramePolicyListenerProxy::ignore):
(WebKit::WebFramePolicyListenerProxy::receivedPolicyDecision): Deleted.
(WebKit::WebFramePolicyListenerProxy::setNavigation): Deleted.
- UIProcess/WebFramePolicyListenerProxy.h:
(WebKit::WebFramePolicyListenerProxy::create):
(WebKit::WebFramePolicyListenerProxy::policyListenerType const): Deleted.
(WebKit::WebFramePolicyListenerProxy::listenerID const): Deleted.
(): Deleted.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::setUpPolicyListenerProxy):
(WebKit::WebFrameProxy::receivedPolicyDecision): Deleted.
(WebKit::WebFrameProxy::activePolicyListenerProxy): Deleted.
(WebKit::WebFrameProxy::changeWebsiteDataStore): Deleted.
- UIProcess/WebFrameProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
- UIProcess/WebPageProxy.h:
- 11:04 AM Changeset in webkit [234209] by
-
- 7 edits in trunk/Source/WebKit
Unreviewed, rolling out r234196.
https://bugs.webkit.org/show_bug.cgi?id=188011
broke API tests (Requested by alexchristensen on #webkit).
Reverted changeset:
"Use CompletionHandler for policy decisions"
https://bugs.webkit.org/show_bug.cgi?id=187975
https://trac.webkit.org/changeset/234196
- 11:04 AM Changeset in webkit [234208] by
-
- 1 copy in tags/Safari-607.1.1
Tag Safari-607.1.1.
- 10:54 AM Changeset in webkit [234207] by
-
- 4 edits in trunk
[INTL] Call Typed Array elements toLocaleString with locale and options
https://bugs.webkit.org/show_bug.cgi?id=185796
Patch by Andy VanWagoner <andy@vanwagoner.family> on 2018-07-25
Reviewed by Keith Miller.
JSTests:
Remove now passing TypedArray toLocaleString expectation.
- test262/expectations.yaml:
Source/JavaScriptCore:
Improve ECMA 402 compliance of typed array toLocaleString, passing along
the locale and options to element toLocaleString calls.
- builtins/TypedArrayPrototype.js:
(toLocaleString):
- 10:36 AM Changeset in webkit [234206] by
-
- 1 edit in releases/WebKitGTK/webkit-2.20/LayoutTests/platform/gtk/TestExpectations
Unreviewed, fix merge conflict from previous patch
I failed to address a merge conflict in the TestExpectations.
- 10:33 AM Changeset in webkit [234205] by
-
- 7 edits in releases/WebKitGTK/webkit-2.20
Merge r233080 - REGRESSION(r230950): [GTK] WebKit::CoordinatedBackingStoreTile::setBackBuffer(): WebKitWebProcess killed by SIGSEGV (ASSERTION FAILED: it != m_tiles.end())
https://bugs.webkit.org/show_bug.cgi?id=186206
Source/WebCore:
Unreviewed manual rollout of r230950
- platform/graphics/texmap/TextureMapperLayer.h:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::shouldHaveBackingStore const):
Source/WebKit:
Unreviewed manual rollout of r230950
- Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
(WebKit::layerShouldHaveBackingStore):
LayoutTests:
Unreviewed, remove crash expectations for crashes introduced by r230950.
- platform/gtk/TestExpectations:
- 10:33 AM Changeset in webkit [234204] by
-
- 8 edits in releases/WebKitGTK/webkit-2.20/Source/JavaScriptCore
Merge r232883 - Unreviewed, rolling out r232816.
Suggested by Caitlin:
"this patch clearly does get some things wrong, and it's not
easy to find what those things are"
Reverted changeset:
"[LLInt] use loadp consistently for
get_from_scope/put_to_scope"
https://bugs.webkit.org/show_bug.cgi?id=132333
https://trac.webkit.org/changeset/232816
- 10:10 AM Changeset in webkit [234203] by
-
- 8 edits2 deletes in trunk
Unreviewed, rolling out r234187.
the layout test added with this change is flaky on the bots
Reverted changeset:
"Animation stops with object-fit:contain on an animated 2d
canvas"
https://bugs.webkit.org/show_bug.cgi?id=187840
https://trac.webkit.org/changeset/234187
- 10:02 AM WebKitGTK/2.20.x edited by
- Managed the rollouts (diff)
- 10:02 AM Changeset in webkit [234202] by
-
- 11 edits in trunk
[INTL] Intl constructor lengths should be configurable
https://bugs.webkit.org/show_bug.cgi?id=187960
Patch by Andy VanWagoner <andy@vanwagoner.family> on 2018-07-25
Reviewed by Saam Barati.
JSTests:
Removed fixed length expectations, and updated Intl.Locale expectations
that error differently since r234127.
- test262/expectations.yaml:
Source/JavaScriptCore:
Removed DontDelete from Intl constructor lengths.
Fixed DateTimeFormat formatToParts length.
- runtime/IntlCollatorConstructor.cpp:
(JSC::IntlCollatorConstructor::finishCreation):
- runtime/IntlDateTimeFormatConstructor.cpp:
(JSC::IntlDateTimeFormatConstructor::finishCreation):
- runtime/IntlDateTimeFormatPrototype.cpp:
(JSC::IntlDateTimeFormatPrototype::finishCreation):
- runtime/IntlNumberFormatConstructor.cpp:
(JSC::IntlNumberFormatConstructor::finishCreation):
- runtime/IntlPluralRulesConstructor.cpp:
(JSC::IntlPluralRulesConstructor::finishCreation):
LayoutTests:
Expect DateTimeFormat formatToParts length to be 1.
- js/intl-datetimeformat-expected.txt:
- js/script-tests/intl-datetimeformat.js:
- 10:00 AM Changeset in webkit [234201] by
-
- 2 edits in branches/safari-606-branch/Source/bmalloc
Cherry-pick r234185. rdar://problem/42586981
Revert back to using phys_footprint to calculate isUnderMemoryPressure()
https://bugs.webkit.org/show_bug.cgi?id=187919
<rdar://problem/42552888>
Reviewed by Simon Fraser.
Currently on iOS, bmalloc will run the scavenger more frequently when it detects
that the process is under memory pressure. However, it only uses bmalloc's
own footprint as a percentage of the HW available memory to determine if
the process is under memory pressure. This is a change I recently made
in an effort to run the scavenger less when bmalloc wasn't contributing
to the dirty footprint in the process. However, this fails to run the
scavenger eagerly when the process in question has a heap split
between a lot of dirty bmalloc memory as well as a lot of dirty memory
from elsewhere. We also have evidence that we may have increased jetsams
in the Web Content process. Since my original change was not a measurable
speedup, this patch reverts isUnderMemoryPressure() to its previous
behavior of using phys_footprint to determine if 75% of the available
HW memory is being used.
- bmalloc/AvailableMemory.cpp: (bmalloc::memoryStatus):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234185 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:00 AM Changeset in webkit [234200] by
-
- 25 edits2 deletes in branches/safari-606-branch
Cherry-pick r234177. rdar://problem/42586717
Likely cause of <rdar://problem/42160890> and
<rdar://problem/42329658> as ActiveDOMObjects can now be
constructed / destroyed while we are iterating over them.
Reverted changesets:
"Nullptr crash accessing Document in
GenericEventQueue::dispatchOneEvent()"
https://bugs.webkit.org/show_bug.cgi?id=187284
https://trac.webkit.org/changeset/233496
"REGRESSION(r233496): macOS Sierra hits debug assertions in
TrackListBase::suspend"
https://bugs.webkit.org/show_bug.cgi?id=187378
https://trac.webkit.org/changeset/233571
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234177 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 9:59 AM Changeset in webkit [234199] by
-
- 2 edits in trunk/Tools
[Flatpak] Pass more environment variables to sandbox
https://bugs.webkit.org/show_bug.cgi?id=188002
Reviewed by Michael Catanzaro.
- flatpak/flatpakutils.py:
(WebkitFlatpak.run_in_sandbox):
- 9:43 AM Changeset in webkit [234198] by
-
- 2 edits in releases/WebKitGTK/webkit-2.20/Source/JavaScriptCore
[GTK][STABLE] Non-deterministic build failure (missing JavaScriptCore/JSContextRef.h)
- 9:12 AM Changeset in webkit [234197] by
-
- 3 edits in trunk/Source/WebCore
Turn assertion preventing removal of ActiveDOMObjects while we iterate over them into a RELEASE_ASSERT
https://bugs.webkit.org/show_bug.cgi?id=187978
Reviewed by Eric Carlson.
Turn assertion preventing removal of ActiveDOMObjects while we iterate over them into a RELEASE_ASSERT.
If code does this, this leads to hard to investigate crashes such as rdar://problem/42160890. With a
release assertion, we would find the culprits right away. The assertion guarding against addition of
ActiveDOMObjects while we iterate is already a RELEASE_ASSERT.
- dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::canSuspendActiveDOMObjectsForDocumentSuspension):
(WebCore::ScriptExecutionContext::suspendActiveDOMObjects):
(WebCore::ScriptExecutionContext::resumeActiveDOMObjects):
(WebCore::ScriptExecutionContext::willDestroyActiveDOMObject):
- dom/ScriptExecutionContext.h:
- 9:07 AM Changeset in webkit [234196] by
-
- 7 edits in trunk/Source/WebKit
Use CompletionHandler for policy decisions
https://bugs.webkit.org/show_bug.cgi?id=187975
Patch by Alex Christensen <achristensen@webkit.org> on 2018-07-25
Reviewed by Chris Dumez.
- UIProcess/WebFramePolicyListenerProxy.cpp:
(WebKit::WebFramePolicyListenerProxy::WebFramePolicyListenerProxy):
(WebKit::WebFramePolicyListenerProxy::use):
(WebKit::WebFramePolicyListenerProxy::download):
(WebKit::WebFramePolicyListenerProxy::ignore):
(WebKit::WebFramePolicyListenerProxy::receivedPolicyDecision): Deleted.
(WebKit::WebFramePolicyListenerProxy::setNavigation): Deleted.
- UIProcess/WebFramePolicyListenerProxy.h:
(WebKit::WebFramePolicyListenerProxy::create):
(WebKit::WebFramePolicyListenerProxy::policyListenerType const): Deleted.
(WebKit::WebFramePolicyListenerProxy::listenerID const): Deleted.
(): Deleted.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::setUpPolicyListenerProxy):
(WebKit::WebFrameProxy::receivedPolicyDecision): Deleted.
(WebKit::WebFrameProxy::activePolicyListenerProxy): Deleted.
(WebKit::WebFrameProxy::changeWebsiteDataStore): Deleted.
- UIProcess/WebFrameProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
(WebKit::WebPageProxy::decidePolicyForNewWindowAction):
(WebKit::WebPageProxy::decidePolicyForResponse):
- UIProcess/WebPageProxy.h:
- 9:01 AM WebKitGTK/2.20.x edited by
- r229282 is overkill, I'll handle this manually (diff)
- 8:47 AM Changeset in webkit [234195] by
-
- 4 edits2 moves in trunk/Source/WebKit
[macOS] PluginProcess needs TCC entitlements for media capture
https://bugs.webkit.org/show_bug.cgi?id=187981
<rdar://problem/42433634>
Reviewed by Chris Dumez.
The changes needed in Bug 185526 are also needed for the plugin process, or else the UIProcess
(e.g., Safari) is not able to pass the user's camera/microphone access permission to the plugin process.
This patch has the following changes:
- Rename "WebContent-OSX-restricted.entitlements" to "WebContent-or-Plugin-OSX-restricted.entitlements"
- Rename "process-webcontent-entitlements.sh" to "process-webcontent-or-plugin-entitlements.sh"
- Add a run-script step to the Plugin.64 and Plugin.32 builds to add the relevant entitlements.
- Silence some Flash plugin sandbox exceptions triggered after activating the camera.
- Configurations/WebContent-or-Plugin-OSX-restricted.entitlements: Renamed from Source/WebKit/Configurations/WebContent-OSX-restricted.entitlements.
- Resources/PlugInSandboxProfiles/com.macromedia.Flash Player ESR.plugin.sb: Address sandbox violations needed by camera use.
- Resources/PlugInSandboxProfiles/com.macromedia.Flash Player.plugin.sb: Ditto.
- Scripts/process-webcontent-or-plugin-entitlements.sh: Renamed from Source/WebKit/Scripts/process-webcontent-entitlements.sh.
- WebKit.xcodeproj/project.pbxproj: Update for renaming, and perform entitlement steps on Plugin process.
- 8:43 AM Changeset in webkit [234194] by
-
- 3 edits in trunk/LayoutTests
[GTK][WPE] Unreviewed test gardening
https://bugs.webkit.org/show_bug.cgi?id=188003
Unreviewed test gardening.
- platform/gtk/TestExpectations:
- webgl/2.0.0/conformance2/glsl3/: skip while we disable WebGL2 support
- media/video-restricted-invisible-autoplay-allowed-when-visible.html: mark as flaky
- compositing/backing/backing-store-attachment-fill-forwards-animation.html: mark as failing
- http/tests/security/canvas-remote-read-remote-video-hls.html: mark as failing
- platform/wpe/imported/w3c/web-platform-tests/web-animations/animation-model/animation-types/addition-per-property-expected.txt: Update for r233935.
- 6:26 AM Changeset in webkit [234193] by
-
- 9 edits in trunk/Tools
[WPE] Switch ViewBackend to using wpe_view_backend_exportable_fdo_egl APIs
https://bugs.webkit.org/show_bug.cgi?id=187997
Reviewed by Carlos Garcia Campos.
Instead of the raw wpe_view_backend_exportable_fdo API, switch to using
the EGL-oriented API that simply serves EGLImageKHR objects instead of
raw buffer resources. This allows us not to wrangle with creating and
managing lifetime of the same EGLImageKHR by ourselves.
ViewBackend now defines a wpe_view_backend_exportable_fdo_egl_client
struct and uses wpe_view_backend_exportable_fdo_egl_create() to create
the exportable object. This means that for each frame we're served an
EGLImageKHR object that is passed on to the displayBuffer()
implementation.
HeadlessViewBackend now just manages the pending and committed image
objects. Width and height values used during pixel data retrieval are
gathered from the ViewBackend's size that was specified when
constructed.
WindowViewBackend similarly only manages the committed image object,
not having to create an equivalent EGLImageKHR object from the raw
buffer resource anymore.
Unused EGL entrypoints in both HeadlessViewBackend and WindowViewBackend
classes are removed, and destructors for both classes are made virtual.
The WPEBackend-fdo version is bumped in order to have the EGL-specific
export API available.
- flatpak/org.webkit.WPE.yaml:
- wpe/backends/HeadlessViewBackend.cpp:
(WPEToolingBackends::HeadlessViewBackend::HeadlessViewBackend):
(WPEToolingBackends::HeadlessViewBackend::~HeadlessViewBackend):
(WPEToolingBackends::HeadlessViewBackend::createSnapshot):
(WPEToolingBackends::HeadlessViewBackend::performUpdate):
(WPEToolingBackends::HeadlessViewBackend::displayBuffer):
- wpe/backends/HeadlessViewBackend.h:
- wpe/backends/ViewBackend.cpp:
(WPEToolingBackends::ViewBackend::initialize):
- wpe/backends/ViewBackend.h:
- wpe/backends/WindowViewBackend.cpp:
(WPEToolingBackends::WindowViewBackend::WindowViewBackend):
(WPEToolingBackends::WindowViewBackend::~WindowViewBackend):
(WPEToolingBackends::WindowViewBackend::displayBuffer):
- wpe/backends/WindowViewBackend.h:
- wpe/jhbuild.modules:
- 12:11 AM Changeset in webkit [234192] by
-
- 2 edits in trunk/Source/WTF
Correctly close the variable argument list
https://bugs.webkit.org/show_bug.cgi?id=186758
Reviewed by Michael Catanzaro.
The argcCopy is not ended when we early return. Also don't call
va_end() on args because it's closed in caller.
- wtf/text/WTFString.cpp:
(WTF::createWithFormatAndArguments):
Jul 24, 2018:
- 11:02 PM Changeset in webkit [234191] by
-
- 7 edits in branches/safari-606-branch/Source
Versioning.
- 10:29 PM Changeset in webkit [234190] by
-
- 2 edits in trunk/Source/JavaScriptCore
runJITThreadLimitTests is failing
https://bugs.webkit.org/show_bug.cgi?id=187886
<rdar://problem/42561966>
Unreviewed build fix for MSVC.
MSVC doen't support ternary operator without second operand.
- dfg/DFGWorklist.cpp:
(JSC::DFG::getNumberOfDFGCompilerThreads):
(JSC::DFG::getNumberOfFTLCompilerThreads):
- 10:16 PM Changeset in webkit [234189] by
-
- 2 edits in trunk/Source/WTF
HAVE(PARENTAL_CONTROLS) should be true on watchOS
https://bugs.webkit.org/show_bug.cgi?id=187985
<rdar://problem/42559346>
Reviewed by Andy Estes.
- wtf/Platform.h:
- 9:47 PM Changeset in webkit [234188] by
-
- 3 edits4 adds in trunk
REGRESSION (r219757): Accessing response getter of XHR instance from IFRAME sets constructor to Object from the IFRAME
https://bugs.webkit.org/show_bug.cgi?id=187411
<rdar://problem/41920593>
Reviewed by Sam Weinig.
Source/WebCore:
Update JSXMLHttpRequest::response() to use the XMLHttpRequest's global object exec when constructing a JSONObject
for the response instead of the caller's exec.
Test: http/tests/xmlhttprequest/xhr-response-constructor-subframe.html
- bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequest::response const):
LayoutTests:
Add layout test coverage. I have verified locally that it passes in Chromium as well.
- http/tests/xmlhttprequest/resources/data.json: Added.
- http/tests/xmlhttprequest/resources/xhr-response-constructor-iframe.html: Added.
- http/tests/xmlhttprequest/xhr-response-constructor-subframe-expected.txt: Added.
- http/tests/xmlhttprequest/xhr-response-constructor-subframe.html: Added.
- 9:09 PM Changeset in webkit [234187] by
-
- 8 edits2 adds in trunk
Animation stops with object-fit:contain on an animated 2d canvas
https://bugs.webkit.org/show_bug.cgi?id=187840
Reviewed by Zalan Bujtas.
Source/WebCore:
If a canvas has object-fit: cover or contain, repaints need to mapped through
the rect that is used to position the canvas in the element bounds, which is replacedContentRect().
Add a version of replacedContentRect() that doesn't require passing the intrinsicSize() since
all but RenderVideo just pass the RenderReplaced's intrinsicSize.
Test: fast/repaint/canvas-object-fit.html
- html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::didDraw):
- rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::paintReplaced):
- rendering/RenderImage.cpp:
(WebCore::RenderImage::updateInnerContentRect):
(WebCore::RenderImage::paintReplaced):
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::contentsBox const):
- rendering/RenderReplaced.h:
(WebCore::RenderReplaced::replacedContentRect const):
- rendering/shapes/ShapeOutsideInfo.cpp:
(WebCore::ShapeOutsideInfo::createShapeForImage const):
LayoutTests:
- fast/repaint/canvas-object-fit-expected.txt: Added.
- fast/repaint/canvas-object-fit.html: Added.
- 8:31 PM Changeset in webkit [234186] by
-
- 7 edits in trunk
[Curl] Add support for wss:// websockets
https://bugs.webkit.org/show_bug.cgi?id=172630
Reviewed by Fujii Hironori.
Source/WebCore:
To support secure WebSocket connection, it is almost rewritten by using existing
backend for CurlHandle to handle TLS connection and proxy support.
Test: http/tests/websocket/tests/hybi/simple-wss.html
- platform/network/curl/CurlContext.cpp:
(WebCore::CurlSocketHandle::CurlSocketHandle):
(WebCore::CurlSocketHandle::connect):
(WebCore::CurlSocketHandle::send):
(WebCore::CurlSocketHandle::receive):
(WebCore::CurlSocketHandle::wait):
- platform/network/curl/CurlContext.h:
- platform/network/curl/SocketStreamHandleImpl.h:
(WebCore::SocketStreamHandleImpl::SocketData::SocketData): Deleted.
- platform/network/curl/SocketStreamHandleImplCurl.cpp:
(WebCore::SocketStreamHandleImpl::SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::~SocketStreamHandleImpl):
(WebCore::SocketStreamHandleImpl::platformSendInternal):
(WebCore::SocketStreamHandleImpl::platformClose):
(WebCore::SocketStreamHandleImpl::threadEntryPoint):
(WebCore::SocketStreamHandleImpl::handleError):
(WebCore::SocketStreamHandleImpl::stopThread):
(WebCore::createCopy): Deleted.
(WebCore::SocketStreamHandleImpl::readData): Deleted.
(WebCore::SocketStreamHandleImpl::sendData): Deleted.
(WebCore::SocketStreamHandleImpl::waitForAvailableData): Deleted.
(WebCore::SocketStreamHandleImpl::startThread): Deleted.
(WebCore::SocketStreamHandleImpl::didReceiveData): Deleted.
(WebCore::SocketStreamHandleImpl::didOpenSocket): Deleted.
LayoutTests:
Pass simple-wss.html.
- platform/wincairo/TestExpectations:
- 7:09 PM Changeset in webkit [234185] by
-
- 2 edits in trunk/Source/bmalloc
Revert back to using phys_footprint to calculate isUnderMemoryPressure()
https://bugs.webkit.org/show_bug.cgi?id=187919
<rdar://problem/42552888>
Reviewed by Simon Fraser.
Currently on iOS, bmalloc will run the scavenger more frequently when it detects
that the process is under memory pressure. However, it only uses bmalloc's
own footprint as a percentage of the HW available memory to determine if
the process is under memory pressure. This is a change I recently made
in an effort to run the scavenger less when bmalloc wasn't contributing
to the dirty footprint in the process. However, this fails to run the
scavenger eagerly when the process in question has a heap split
between a lot of dirty bmalloc memory as well as a lot of dirty memory
from elsewhere. We also have evidence that we may have increased jetsams
in the Web Content process. Since my original change was not a measurable
speedup, this patch reverts isUnderMemoryPressure() to its previous
behavior of using phys_footprint to determine if 75% of the available
HW memory is being used.
- bmalloc/AvailableMemory.cpp:
(bmalloc::memoryStatus):
- 6:53 PM Changeset in webkit [234184] by
-
- 12 edits1 delete in trunk
Unreviewed, rolling out r234183.
https://bugs.webkit.org/show_bug.cgi?id=187983
cause regression in Kraken gaussian blur and desaturate
(Requested by yusukesuzuki on #webkit).
Reverted changeset:
"[JSC] Record CoW status in ArrayProfile"
https://bugs.webkit.org/show_bug.cgi?id=187949
https://trac.webkit.org/changeset/234183
- 5:41 PM Changeset in webkit [234183] by
-
- 12 edits1 add in trunk
[JSC] Record CoW status in ArrayProfile
https://bugs.webkit.org/show_bug.cgi?id=187949
Reviewed by Saam Barati.
JSTests:
- stress/array-profile-should-record-copy-on-write.js: Added.
(shouldBe):
(test1):
(test2):
(test3):
Source/JavaScriptCore:
Once CoW array is converted to non-CoW array, subsequent operations are done for this non-CoW array.
Even though these operations are performed onto both CoW and non-CoW arrays in the code, array profiles
in these code typically record only non-CoW arrays since array profiles hold only one StructureID recently
seen. This results emitting CheckStructure for non-CoW arrays in DFG, and it soon causes OSR exits due to
CoW arrays.
In this patch, we record CoW status in ArrayProfile separately to construct more appropriate DFG::ArrayMode
speculation. To do so efficiently, we store union of seen IndexingMode in ArrayProfile.
This patch removes one of Kraken/stanford-crypto-aes's OSR exit reason, and improves the performance by 6-7%.
baseline patched
stanford-crypto-aes 60.893+-1.346 57.412+-1.298 definitely 1.0606x faster
stanford-crypto-ccm 62.124+-1.992 58.921+-1.844 might be 1.0544x faster
- bytecode/ArrayProfile.cpp:
(JSC::ArrayProfile::briefDescriptionWithoutUpdating):
- bytecode/ArrayProfile.h:
(JSC::asArrayModes):
We simplify asArrayModes instead of giving up Int8ArrayMode - Float64ArrayMode contiguous sequence.
(JSC::ArrayProfile::ArrayProfile):
(JSC::ArrayProfile::addressOfObservedIndexingModes):
(JSC::ArrayProfile::observedIndexingModes const):
Currently, our macro assembler and offlineasm only supportor32/orioperation onto addresses.
So storing the union of seen IndexingMode inunsignedinstead.
- dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::fromObserved):
- dfg/DFGArrayMode.h:
(JSC::DFG::ArrayMode::withProfile const):
- jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
- jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
- jit/JITInlines.h:
(JSC::JIT::emitArrayProfilingSiteWithCell):
- llint/LowLevelInterpreter.asm:
- llint/LowLevelInterpreter32_64.asm:
- llint/LowLevelInterpreter64.asm:
- 5:21 PM Changeset in webkit [234182] by
-
- 10 edits2 deletes in trunk/Tools
Remove support for the double type from WHLSL
https://bugs.webkit.org/show_bug.cgi?id=187977
Patch by Thomas Denney <tdenney@apple.com> on 2018-07-24
Reviewed by Myles C. Maxfield.
- WebGPUShadingLanguageRI/All.js: Removed DoubleLiteral.js and DoubleLiteralType.js include.
- WebGPUShadingLanguageRI/DoubleLiteral.js: Removed.
- WebGPUShadingLanguageRI/DoubleLiteralType.js: Removed.
- WebGPUShadingLanguageRI/Intrinsics.js: Removed double arithmetic functions.
- WebGPUShadingLanguageRI/Parse.js:
(parseTerm): Removed parsing of double literals.
- WebGPUShadingLanguageRI/SPIRV.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
- WebGPUShadingLanguageRI/SPIRVCodegen.js: Removed double type logic.
- WebGPUShadingLanguageRI/StandardLibrary.js: Removed double type declarations.
- WebGPUShadingLanguageRI/Test.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
- WebGPUShadingLanguageRI/Test.js: Removed tests that test doubles or ported them to use floats.
- WebGPUShadingLanguageRI/index.html: Removed DoubleLiteral.js and DoubleLiteralType.js include.
- 5:18 PM Changeset in webkit [234181] by
-
- 12 edits in trunk
Enable Web Content Filtering on watchOS
https://bugs.webkit.org/show_bug.cgi?id=187979
<rdar://problem/42559346>
Reviewed by Wenson Hsieh.
Source/JavaScriptCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore:
- Configurations/FeatureDefines.xcconfig:
Source/WebCore/PAL:
- Configurations/FeatureDefines.xcconfig:
Source/WebKit:
- Configurations/FeatureDefines.xcconfig:
Source/WebKitLegacy/mac:
- Configurations/FeatureDefines.xcconfig:
Tools:
- TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
- 4:42 PM Changeset in webkit [234180] by
-
- 5 edits in trunk/Source/JavaScriptCore
Don't modify Options when setting JIT thread limits
https://bugs.webkit.org/show_bug.cgi?id=187886
Reviewed by Filip Pizlo.
Previously, when setting the JIT thread limit prior to the worklist
initialization, it'd be set via Options, which didn't work if Options
hadn't been initialized yet. Change it to use a static variable in the
Worklist instead.
- API/JSVirtualMachine.mm:
(+[JSVirtualMachine setNumberOfDFGCompilerThreads:]):
(+[JSVirtualMachine setNumberOfFTLCompilerThreads:]):
- API/tests/testapi.mm:
(testObjectiveCAPIMain):
- dfg/DFGWorklist.cpp:
(JSC::DFG::getNumberOfDFGCompilerThreads):
(JSC::DFG::getNumberOfFTLCompilerThreads):
(JSC::DFG::setNumberOfDFGCompilerThreads):
(JSC::DFG::setNumberOfFTLCompilerThreads):
(JSC::DFG::ensureGlobalDFGWorklist):
(JSC::DFG::ensureGlobalFTLWorklist):
- dfg/DFGWorklist.h:
- 4:29 PM Changeset in webkit [234179] by
-
- 6 edits2 adds in trunk
Move-constructing NeverDestroyed should move construct underlying object instead of copy constructing it
https://bugs.webkit.org/show_bug.cgi?id=187971
Reviewed by Saam Barati.
Source/WTF:
Fixes an issue where move constructing a NeverDestroyed<T> would always copy construct T into
the destination storage buffer regardless of whether T is move constructable. For example:
{
static NeverDestroyed<T> x;
static NeverDestroyed<T> y { WTFMove(x) }; currently makes a copy of x's T even if T is move constructable
}
Currently the NeverDestroyed<T> instantiates T into the destination storage buffer by WTFMove()ing
the NeverDestroyed<T> into it, implicitly converting it to const T& by way of const T& conversion
operator. As a result the compiler picks the copy constructor for T to invoke instead of evaluating
whether T can be move constructed. Instead we should explicitly WTFMove() the underlying T so that
the compiler can choose to either move-construct T or copy construct it.
A side benefit of this change it is now possible to invoke makeNeverDestroyed() with the result
of a function that returns a move-only type (e.g. RenderStyle):
static auto sharedStyle = makeNeverDestroyed([] {
auto style = RenderStyle::create();
...
return style;
}());
- wtf/NeverDestroyed.h:
(WTF::NeverDestroyed::NeverDestroyed):
Tools:
Add unit tests to cover move constructing a NeverDestroyed with a non-const and const data type
as well as invoking makeNeverDestroyed() with the result of a function that returns a move-only
data type.
- TestWebKitAPI/CMakeLists.txt:
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WTF/MoveOnlyLifecycleLogger.cpp: Added.
(TestWebKitAPI::MoveOnlyLifecycleLogger::MoveOnlyLifecycleLogger):
(TestWebKitAPI::MoveOnlyLifecycleLogger::~MoveOnlyLifecycleLogger):
(TestWebKitAPI::MoveOnlyLifecycleLogger::operator=):
(TestWebKitAPI::MoveOnlyLifecycleLogger::setName):
(TestWebKitAPI::TEST):
- TestWebKitAPI/Tests/WTF/MoveOnlyLifecycleLogger.h: Added.
- TestWebKitAPI/Tests/WTF/NeverDestroyed.cpp:
(TestWebKitAPI::TEST):
- 4:14 PM Changeset in webkit [234178] by
-
- 40 edits in trunk/Source/JavaScriptCore
Refactoring: make DFG::Plan a class.
https://bugs.webkit.org/show_bug.cgi?id=187968
Reviewed by Saam Barati.
This patch makes all the DFG::Plan fields private, and provide accessor methods
for them. This makes it easier to reason about how these fields are used and
modified.
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleVarargsCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::handleIntrinsicCall):
(JSC::DFG::ByteCodeParser::handleDOMJITGetter):
(JSC::DFG::ByteCodeParser::handleModuleNamespaceLoad):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
- dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::run):
(JSC::DFG::CFAPhase::injectOSR):
- dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
- dfg/DFGCommonData.cpp:
(JSC::DFG::CommonData::notifyCompilingStructureTransition):
- dfg/DFGCommonData.h:
- dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
- dfg/DFGDriver.cpp:
(JSC::DFG::compileImpl):
- dfg/DFGFinalizer.h:
- dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
(JSC::DFG::FixupPhase::fixupCompareStrictEqAndSameValue):
- dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::watchCondition):
(JSC::DFG::Graph::inferredTypeFor):
(JSC::DFG::Graph::requiredRegisterCountForExit):
(JSC::DFG::Graph::registerFrozenValues):
(JSC::DFG::Graph::registerStructure):
(JSC::DFG::Graph::registerAndWatchStructureTransition):
(JSC::DFG::Graph::assertIsRegistered):
- dfg/DFGGraph.h:
(JSC::DFG::Graph::compilation):
(JSC::DFG::Graph::identifiers):
(JSC::DFG::Graph::watchpoints):
- dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
(JSC::DFG::JITCompiler::disassemble):
- dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addWeakReference):
- dfg/DFGJITFinalizer.cpp:
(JSC::DFG::JITFinalizer::finalize):
(JSC::DFG::JITFinalizer::finalizeFunction):
(JSC::DFG::JITFinalizer::finalizeCommon):
- dfg/DFGOSREntrypointCreationPhase.cpp:
(JSC::DFG::OSREntrypointCreationPhase::run):
- dfg/DFGPhase.cpp:
(JSC::DFG::Phase::beginPhase):
- dfg/DFGPhase.h:
(JSC::DFG::runAndLog):
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::Plan):
(JSC::DFG::Plan::computeCompileTimes const):
(JSC::DFG::Plan::reportCompileTimes const):
(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):
(JSC::DFG::Plan::isStillValid):
(JSC::DFG::Plan::reallyAdd):
(JSC::DFG::Plan::notifyCompiling):
(JSC::DFG::Plan::notifyReady):
(JSC::DFG::Plan::finalizeWithoutNotifyingCallback):
(JSC::DFG::Plan::finalizeAndNotifyCallback):
(JSC::DFG::Plan::key):
(JSC::DFG::Plan::checkLivenessAndVisitChildren):
(JSC::DFG::Plan::finalizeInGC):
(JSC::DFG::Plan::isKnownToBeLiveDuringGC):
(JSC::DFG::Plan::cancel):
(JSC::DFG::Plan::cleanMustHandleValuesIfNecessary):
- dfg/DFGPlan.h:
(JSC::DFG::Plan::canTierUpAndOSREnter const):
(JSC::DFG::Plan::vm const):
(JSC::DFG::Plan::codeBlock):
(JSC::DFG::Plan::mode const):
(JSC::DFG::Plan::osrEntryBytecodeIndex const):
(JSC::DFG::Plan::mustHandleValues const):
(JSC::DFG::Plan::threadData const):
(JSC::DFG::Plan::compilation const):
(JSC::DFG::Plan::finalizer const):
(JSC::DFG::Plan::setFinalizer):
(JSC::DFG::Plan::inlineCallFrames const):
(JSC::DFG::Plan::watchpoints):
(JSC::DFG::Plan::identifiers):
(JSC::DFG::Plan::weakReferences):
(JSC::DFG::Plan::transitions):
(JSC::DFG::Plan::recordedStatuses):
(JSC::DFG::Plan::willTryToTierUp const):
(JSC::DFG::Plan::setWillTryToTierUp):
(JSC::DFG::Plan::tierUpInLoopHierarchy):
(JSC::DFG::Plan::tierUpAndOSREnterBytecodes):
(JSC::DFG::Plan::stage const):
(JSC::DFG::Plan::callback const):
(JSC::DFG::Plan::setCallback):
- dfg/DFGPlanInlines.h:
(JSC::DFG::Plan::iterateCodeBlocksForGC):
- dfg/DFGPreciseLocalClobberize.h:
(JSC::DFG::PreciseLocalClobberizeAdaptor::readTop):
- dfg/DFGPredictionInjectionPhase.cpp:
(JSC::DFG::PredictionInjectionPhase::run):
- dfg/DFGSafepoint.cpp:
(JSC::DFG::Safepoint::Safepoint):
(JSC::DFG::Safepoint::~Safepoint):
(JSC::DFG::Safepoint::begin):
- dfg/DFGSafepoint.h:
- dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::TrustedImmPtr::weakPointer):
(JSC::DFG::SpeculativeJIT::TrustedImmPtr::weakPoisonedPointer):
- dfg/DFGStackLayoutPhase.cpp:
(JSC::DFG::StackLayoutPhase::run):
- dfg/DFGStrengthReductionPhase.cpp:
(JSC::DFG::StrengthReductionPhase::handleNode):
- dfg/DFGTierUpCheckInjectionPhase.cpp:
(JSC::DFG::TierUpCheckInjectionPhase::run):
- dfg/DFGTypeCheckHoistingPhase.cpp:
(JSC::DFG::TypeCheckHoistingPhase::disableHoistingAcrossOSREntries):
- dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::isActiveForVM const):
(JSC::DFG::Worklist::compilationState):
(JSC::DFG::Worklist::waitUntilAllPlansForVMAreReady):
(JSC::DFG::Worklist::removeAllReadyPlansForVM):
(JSC::DFG::Worklist::completeAllReadyPlansForVM):
(JSC::DFG::Worklist::visitWeakReferences):
(JSC::DFG::Worklist::removeDeadPlans):
(JSC::DFG::Worklist::removeNonCompilingPlansForVM):
- dfg/DFGWorklistInlines.h:
(JSC::DFG::Worklist::iterateCodeBlocksForGC):
- ftl/FTLCompile.cpp:
(JSC::FTL::compile):
- ftl/FTLFail.cpp:
(JSC::FTL::fail):
- ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalizeCommon):
- ftl/FTLLink.cpp:
(JSC::FTL::link):
- ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileMultiPutByOffset):
(JSC::FTL::DFG::LowerDFGToB3::buildExitArguments):
(JSC::FTL::DFG::LowerDFGToB3::addWeakReference):
- ftl/FTLState.cpp:
(JSC::FTL::State::State):
- 4:13 PM Changeset in webkit [234177] by
-
- 25 edits2 deletes in trunk
Unreviewed, rolling out r233496 and r233571.
Likely cause of <rdar://problem/42160890> and
<rdar://problem/42329658> as ActiveDOMObjects can now be
constructed / destroyed while we are iterating over them.
Reverted changesets:
"Nullptr crash accessing Document in
GenericEventQueue::dispatchOneEvent()"
https://bugs.webkit.org/show_bug.cgi?id=187284
https://trac.webkit.org/changeset/233496
"REGRESSION(r233496): macOS Sierra hits debug assertions in
TrackListBase::suspend"
https://bugs.webkit.org/show_bug.cgi?id=187378
https://trac.webkit.org/changeset/233571
- 4:12 PM Changeset in webkit [234176] by
-
- 1 copy in tags/Safari-606.1.30
Tag Safari-606.1.30.
- 4:08 PM Changeset in webkit [234175] by
-
- 18 edits1 add in trunk/Tools
Minor changes to the WHLSL interpreter to support the new compiler
https://bugs.webkit.org/show_bug.cgi?id=187728
Patch by Thomas Denney <tdenney@apple.com> on 2018-07-24
Reviewed by Myles C. Maxfield.
This bug contains small changes that are make minor changes to the
behaviour of the existing interpreter (the tests are unaffected and all
still pass).
- WebGPUShadingLanguageRI/EnumType.js:
(EnumType.prototype.get isEnum): Property added to EnumType and Type
- WebGPUShadingLanguageRI/Evaluator.js: Correct typo
- WebGPUShadingLanguageRI/Func.js:
(Func.prototype.get isEntryPoint): Add boolean property
- WebGPUShadingLanguageRI/FuncInstantiator.js:
(FuncInstantiator.prototype.get instances): Public accessor for existing
private field
- WebGPUShadingLanguageRI/FunctionLikeBlock.js: Refactored the class so
that it directly wraps a Func instance (therefore the only interface
change is to the constructor and the addition of the func accessor).
This change allows the de-inlining of functions.
(FunctionLikeBlock):
(FunctionLikeBlock.prototype.get func):
(FunctionLikeBlock.prototype.get returnType):
(FunctionLikeBlock.prototype.get parameters):
(FunctionLikeBlock.prototype.get body):
- WebGPUShadingLanguageRI/Inliner.js: Use the new FunctionLikeBlock
constructor
(Inliner.prototype.visitCallExpression):
(Inliner):
- WebGPUShadingLanguageRI/Intrinsics.js: Migrate the swizzle operators
to native functions (with additional support in StandardLibrary.js).
This reduces first-time compile-time from around 4s to around 0.1s.
(Intrinsics):
- WebGPUShadingLanguageRI/Lexer.js: Ensure that the parsing of multiline
comments completes correctly
(Lexer.prototype.next):
(Lexer):
- WebGPUShadingLanguageRI/MakeArrayRefExpression.js: Addition of type
property, which is based on the type of the lValue and the semantics of
the language (the @ operator yields an array reference with the thread
scope).
(MakeArrayRefExpression):
(MakeArrayRefExpression.prototype.get type):
- WebGPUShadingLanguageRI/NativeFunc.js: Add setter/getter for
implementationData to support swizzle operator change
(NativeFunc.prototype.get implementationData):
(NativeFunc.prototype.set implementationData):
- WebGPUShadingLanguageRI/Rewriter.js: Use new FunctionLikeBlock
constructor
(Rewriter.prototype.visitFunctionLikeBlock):
- WebGPUShadingLanguageRI/StandardLibrary.js:
(_generateSwizzle): Deleted.
- WebGPUShadingLanguageRI/SwizzleOp.js: Introduces a new class for
carrying metadata about swizzle operators so that they are implemented
as native functions rather than generated at compile time.
(SwizzleOp):
(SwizzleOp.prototype.get outSize):
(SwizzleOp.prototype.get components):
(SwizzleOp.prototype.get inSize):
(SwizzleOp.prototype.toString):
(SwizzleOp.allSwizzleOperators.):
(SwizzleOp.allSwizzleOperators):
- WebGPUShadingLanguageRI/StandardLibrary.js: + (SwizzleOp):
(SwizzleOp.prototype.get outSize):
(SwizzleOp.prototype.get components):
(SwizzleOp.prototype.get inSize):
(SwizzleOp.prototype.toString):
(generateSwizzles):
(_generateSwizzle): Deleted.
- WebGPUShadingLanguageRI/Type.js: Addition of isEnum property, as
above.
(Type.prototype.get isEnum):
- 3:20 PM Changeset in webkit [234174] by
-
- 2 edits in branches/safari-606-branch/Tools
Cherry-pick r234115. rdar://problem/42557644
DRT relies on [webView display] to call -viewWillDraw on the WebHTMLView
https://bugs.webkit.org/show_bug.cgi?id=187924
<rdar://problem/41745884>
Reviewed by Simon Fraser.
WebKit relies on -viewWillDraw getting called on WebHTMLView, even though that view has not been marked as needing display.
- DumpRenderTree/mac/PixelDumpSupportMac.mm: (createBitmapContextFromWebView):
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@234115 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 2:50 PM Changeset in webkit [234173] by
-
- 3 edits in trunk/LayoutTests
Unreviewed WPE/GTK gardening.
Disabled newly added webrtc tests that depend on implementing WebAudioSourceProviderGStreamer.
Namely:
webrtc/peer-connection-createMediaStreamDestination.html
- platform/gtk/TestExpectations:
- platform/wpe/TestExpectations:
- 2:46 PM Changeset in webkit [234172] by
-
- 21 edits2 adds in trunk/Source
[Datalist][macOS] Display suggestions for input[type=color]
https://bugs.webkit.org/show_bug.cgi?id=187794
Patch by Aditya Keerthi <Aditya Keerthi> on 2018-07-24
Reviewed by Tim Horton.
Source/WebCore:
- html/ColorInputType.cpp:
(WebCore::ColorInputType::shouldRespectListAttribute):
Source/WebCore/PAL:
Added methods to enable customization of NSPopoverColorWell.
- PAL.xcodeproj/project.pbxproj:
- pal/spi/mac/NSColorWellSPI.h: Added.
- pal/spi/mac/NSPopoverColorWellSPI.h: Added.
- pal/spi/mac/NSPopoverSPI.h:
Source/WebKit:
An input[type=color] element that has an associated datalist element should
display the color values provided. We now support 1-12 suggested colors, that
will be displayed at the top of the color selection popover. If no suggestions
are specified we keep the existing default colors.
Created an NSPopoverColorWell subclass that allows custom colors to be specified
in the form of an NSColorList.
Also fixed a bug where an additional color well was displayed when clicking on
the input element.
- Shared/WebCoreArgumentCoders.cpp:
(IPC::ArgumentCoder<Color>::decode):
- Shared/WebCoreArgumentCoders.h:
- UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::createColorPicker):
- UIProcess/API/gtk/PageClientImpl.h:
- UIProcess/PageClient.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::showColorPicker):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::createColorPicker):
- UIProcess/mac/PageClientImplMac.h:
- UIProcess/mac/PageClientImplMac.mm:
(WebKit::PageClientImpl::createColorPicker):
- UIProcess/mac/WebColorPickerMac.h:
- UIProcess/mac/WebColorPickerMac.mm:
(WebKit::WebColorPickerMac::create):
(WebKit::WebColorPickerMac::WebColorPickerMac):
(WebKit::WebColorPickerMac::showColorPicker):
(+[WKPopoverColorWell _colorPopoverCreateIfNecessary:]):
(-[WKPopoverColorWell _showPopover]):
(-[WKPopoverColorWell setSuggestedColors:]):
(-[WKColorPopoverMac initWithFrame:inView:]):
(-[WKColorPopoverMac setAndShowPicker:withColor:suggestions:]):
(-[WKColorPanelMac setAndShowPicker:withColor:suggestions:]):
- WebProcess/WebCoreSupport/WebColorChooser.cpp:
(WebKit::WebColorChooser::WebColorChooser):
(WebKit::WebColorChooser::reattachColorChooser):
- 2:42 PM Changeset in webkit [234171] by
-
- 4 edits in trunk/Source/JavaScriptCore
Make VM::canUseJIT an inlined function
https://bugs.webkit.org/show_bug.cgi?id=187583
Reviewed by Mark Lam.
We know the answer to this query in initializeThreading after initializing
the executable allocator. This patch makes it so that we just hold this value
in a static variable and have an inlined function that just returns the value
of that static variable.
- runtime/InitializeThreading.cpp:
(JSC::initializeThreading):
- runtime/VM.cpp:
(JSC::VM::computeCanUseJIT):
(JSC::VM::canUseJIT): Deleted.
- runtime/VM.h:
(JSC::VM::canUseJIT):
- 1:29 PM Changeset in webkit [234170] by
-
- 3 edits in trunk/LayoutTests
Mark http/tests/workers/service/serviceworkerclients-matchAll.https.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=183705
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 1:14 PM Changeset in webkit [234169] by
-
- 2 edits in trunk/Source/WebKit
Modernize NavigationState
https://bugs.webkit.org/show_bug.cgi?id=187966
Reviewed by Andy Estes.
Don't ignore switch warnings any more.
Use BlockPtr.
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationResponse):
- 1:11 PM Changeset in webkit [234168] by
-
- 9 edits in trunk/Source/WebKit
Remove WebFramePolicyListenerProxy::changeWebsiteDataStore
https://bugs.webkit.org/show_bug.cgi?id=187967
Reviewed by Andy Estes.
We need to call WebFrameProxy::changeWebsiteDataStore if the _WKWebsitePolicies has a WKWebsiteDataStore.
We're doing that in a weird way that is not in the right layer. Inside the call to WebFramePolicyListenerProxy::use
we can inform the frame if there's a new WebsiteDataStore.
No change in behavior, as verified by the WebKit.WebsitePoliciesDataStore API test.
This is a step towards using lambdas in WebFramePolicyListenerProxy.
- UIProcess/API/APINavigationClient.h:
(API::NavigationClient::decidePolicyForNavigationAction):
(API::NavigationClient::decidePolicyForNavigationResponse):
- UIProcess/API/APIPolicyClient.h:
(API::PolicyClient::decidePolicyForNavigationAction):
(API::PolicyClient::decidePolicyForNewWindowAction):
(API::PolicyClient::decidePolicyForResponse):
- UIProcess/API/C/WKFramePolicyListener.cpp:
(WKFramePolicyListenerUse):
(WKFramePolicyListenerUseInNewProcess):
(useWithPolicies):
- UIProcess/API/C/WKPage.cpp:
(WKPageSetPagePolicyClient):
(WKPageSetPageNavigationClient):
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationResponse):
- UIProcess/WebFramePolicyListenerProxy.cpp:
(WebKit::WebFramePolicyListenerProxy::use):
(WebKit::WebFramePolicyListenerProxy::changeWebsiteDataStore): Deleted.
- UIProcess/WebFramePolicyListenerProxy.h:
- UIProcess/WebPageProxy.cpp:
- UIProcess/mac/PageClientImplMac.mm:
- 12:57 PM Changeset in webkit [234167] by
-
- 24 edits6 deletes in trunk
Unreviewed, rolling out r234121.
Caused perf test failures.
Reverted changeset:
"We should cache the compiled sandbox profile in a data vault"
https://bugs.webkit.org/show_bug.cgi?id=184991
https://trac.webkit.org/changeset/234121
- 12:35 PM Changeset in webkit [234166] by
-
- 2 edits in trunk/Source/WebCore
[Web Animations] Add an ASSERT() to check the contract that a CSSTransition has a valid effect in setTimingProperties()
https://bugs.webkit.org/show_bug.cgi?id=187954
Reviewed by Dean Jackson.
- animation/CSSTransition.cpp:
(WebCore::CSSTransition::setTimingProperties):
- 12:32 PM Changeset in webkit [234165] by
-
- 3 edits2 adds in trunk
[Web Animations] Crash when setting an animation style on an existing animation that had its effect set to null
https://bugs.webkit.org/show_bug.cgi?id=187953
Reviewed by Dean Jackson.
Source/WebCore:
Test: webanimations/setting-css-animation-timing-property-via-style-after-clearing-effect.html
Ensure that we have a valid effect before proceeding to update its timing.
- animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::syncPropertiesWithBackingAnimation):
LayoutTests:
Add a new test that sets an animation property via style after setting the initial animation's effect to null.
- webanimations/setting-css-animation-timing-property-via-style-after-clearing-effect-expected.txt: Added.
- webanimations/setting-css-animation-timing-property-via-style-after-clearing-effect.html: Added.
- 12:31 PM Changeset in webkit [234164] by
-
- 2 edits in trunk/Source/WebCore
[MediaStream] Restructure getDisplayMedia classes
https://bugs.webkit.org/show_bug.cgi?id=187905
<rdar://problem/42500215>
Unreviewed build fix.
- platform/mediastream/mac/DisplayCaptureSourceCocoa.cpp:
- 12:30 PM Changeset in webkit [234163] by
-
- 3 edits2 adds in trunk
[Web Animations] Crash when setting "animation: none" after clearing an animation's effect
https://bugs.webkit.org/show_bug.cgi?id=187952
Reviewed by Dean Jackson.
Source/WebCore:
Test: webanimations/setting-css-animation-none-after-clearing-effect.html
We need to ensure that the animation we're trying to remove has not had its effect cleared via the
Web Animations API since its creation before trying to check its phase.
- animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::cancelOrRemoveDeclarativeAnimation):
LayoutTests:
Add a new test that checks that setting "animation: none" on an element that previously had a valid
CSS animation and for which the effect was set to null does not crash.
- webanimations/setting-css-animation-none-after-clearing-effect-expected.txt: Added.
- webanimations/setting-css-animation-none-after-clearing-effect.html: Added.
- 12:29 PM Changeset in webkit [234162] by
-
- 3 edits in branches/safari-606-branch/Source/WebCore
Cherry-pick r234158. rdar://problem/42551556
[Cocoa] Stop crashing in lastResortFallbackFont()
https://bugs.webkit.org/show_bug.cgi?id=187936
Reviewed by Jon Lee.
CoreText can get into a state where both Times and Lucida Grande are inaccessible.
Instead of crashing, we should use the real LastResort, which is backed by a section
in the .rodata of the CoreText dylib, and as such should always exist.
- platform/graphics/FontCache.cpp: (WebCore::FontCache::fontForFamily):
- platform/graphics/cocoa/FontCacheCoreText.cpp: (WebCore::FontCache::lastResortFallbackFont):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234158 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:28 PM Changeset in webkit [234161] by
-
- 3 edits2 adds in trunk
[Web Animations] Crash accessing CSSAnimation::bindingsCurrentTime when effect has been set to null
https://bugs.webkit.org/show_bug.cgi?id=187950
<rdar://problem/42515747>
Reviewed by Dean Jackson.
Source/WebCore:
Test: webanimations/accessing-current-time-after-clearing-css-animation-effect.html
While a CSSAnimation has an effect created for it by the implementation, the developer may yet manipulate
its effect via the Web Animations API and set it to null. As such, we must not assume it's always non-null.
- animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::bindingsCurrentTime const):
LayoutTests:
Add a new test where we check that the current time of a CSSAnimation can be accessed after setting its effect to null.
- webanimations/accessing-current-time-after-clearing-css-animation-effect-expected.txt: Added.
- webanimations/accessing-current-time-after-clearing-css-animation-effect.html: Added.
- 12:02 PM Changeset in webkit [234160] by
-
- 2 edits in trunk/Source/JavaScriptCore
Placate exception check verification after recent changes.
https://bugs.webkit.org/show_bug.cgi?id=187961
<rdar://problem/42545394>
Reviewed by Saam Barati.
- runtime/IntlObject.cpp:
(JSC::intlNumberOption):
- 11:48 AM Changeset in webkit [234159] by
-
- 2 edits in trunk/Source/WebCore
[LFC][IFC] BlockContainer::establishesInlineFormattingContext should only check the first inflow child.
https://bugs.webkit.org/show_bug.cgi?id=187965
Reviewed by Antti Koivisto.
- layout/layouttree/LayoutBlockContainer.cpp:
(WebCore::Layout::BlockContainer::establishesInlineFormattingContext const):
- 11:34 AM Changeset in webkit [234158] by
-
- 3 edits in trunk/Source/WebCore
[Cocoa] Stop crashing in lastResortFallbackFont()
https://bugs.webkit.org/show_bug.cgi?id=187936
Reviewed by Jon Lee.
CoreText can get into a state where both Times and Lucida Grande are inaccessible.
Instead of crashing, we should use the real LastResort, which is backed by a section
in the .rodata of the CoreText dylib, and as such should always exist.
- platform/graphics/FontCache.cpp:
(WebCore::FontCache::fontForFamily):
- platform/graphics/cocoa/FontCacheCoreText.cpp:
(WebCore::FontCache::lastResortFallbackFont):
- 10:47 AM Changeset in webkit [234157] by
-
- 4 edits in trunk/Source/WebKit
WKUIDelegate needs an alternate decideDatabaseQuotaForSecurityOrigin method that provides the database name and display name
https://bugs.webkit.org/show_bug.cgi?id=187567
Reviewed by Alex Christensen.
- UIProcess/API/Cocoa/WKUIDelegatePrivate.h:
Declare alternate decideDatabaseQuotaForSecurityOrigin method, copying the existing FIXME comment
from the old method.
- UIProcess/Cocoa/UIDelegate.h:
Add flag for new delegate method.
- UIProcess/Cocoa/UIDelegate.mm:
(WebKit::UIDelegate::setDelegate):
Initialize new flag.
(WebKit::UIDelegate::UIClient::exceededDatabaseQuota):
Prefer the new UIDelegate method that takes the database name and display name, falling back to the
existing method if the client doesn't implement it.
- 10:40 AM Changeset in webkit [234156] by
-
- 4 edits in trunk/Source/WebKit
[WinCairo] Add support to WebView for setting tooltips
https://bugs.webkit.org/show_bug.cgi?id=187930
Reviewed by Fujii Hironori.
- UIProcess/win/PageClientImpl.cpp:
(WebKit::PageClientImpl::toolTipChanged): Set tooltip on WebView
- UIProcess/win/WebView.cpp:
(WebKit::WebView::setToolTip): Add support for updating the
tooltip text in Windows.
- UIProcess/win/WebView.h:
- 10:31 AM Changeset in webkit [234155] by
-
- 2 edits in trunk/Websites/webkit.org
Disable some vestibular trigger animations when prefers-reduced-motion is active.
https://bugs.webkit.org/show_bug.cgi?id=186529
Reviewed by Dean Jackson.
- wp-content/themes/webkit/style.css:
(@media (prefers-reduced-motion)): Added to honor reduced motion settings.
(article,): Added to only use fade-in animation and prevent motion.
- 10:27 AM Changeset in webkit [234154] by
-
- 11 edits in trunk/Source/WebKit
Reduce getters/setters in WebFramePolicyListenerProxy
https://bugs.webkit.org/show_bug.cgi?id=187830
Reviewed by Dean Jackson.
This is a step towards making it a lambda, which has no getters or setters.
No change in behavior.
setApplyPolicyInNewProcessIfPossible can be replaced by passing another parameter.
This bit was just piggy-backing on the WebFramePolicyListenerProxy.
isMainFrame was only used in an assert, which has a corresponding ObjC exception in
NavigationState::NavigationClient::decidePolicyForNavigationAction for the one relevant client.
- UIProcess/API/C/WKFramePolicyListener.cpp:
(WKFramePolicyListenerUseInNewProcess):
(useWithPolicies):
(WKFramePolicyListenerUseWithPolicies):
(WKFramePolicyListenerUseInNewProcessWithPolicies):
- UIProcess/Cocoa/NavigationState.mm:
(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):
- UIProcess/WebFramePolicyListenerProxy.cpp:
(WebKit::WebFramePolicyListenerProxy::receivedPolicyDecision):
(WebKit::WebFramePolicyListenerProxy::use):
(WebKit::WebFramePolicyListenerProxy::download):
(WebKit::WebFramePolicyListenerProxy::ignore):
(WebKit::WebFramePolicyListenerProxy::isMainFrame const): Deleted.
- UIProcess/WebFramePolicyListenerProxy.h:
(WebKit::WebFramePolicyListenerProxy::setApplyPolicyInNewProcessIfPossible): Deleted.
(WebKit::WebFramePolicyListenerProxy::applyPolicyInNewProcessIfPossible const): Deleted.
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::receivedPolicyDecision):
- UIProcess/WebFrameProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):
- UIProcess/WebPageProxy.h:
- UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigation):
(WebKit::WebProcessPool::processForNavigationInternal):
- UIProcess/WebProcessPool.h:
- 10:25 AM Changeset in webkit [234153] by
-
- 4 edits in trunk/Source/WebKit
Remove WebFramePolicyListenerProxy::invalidate
https://bugs.webkit.org/show_bug.cgi?id=187833
Reviewed by Dean Jackson.
When we're invalidating the listener, calling ignore instead will at worst cause
an ignored message to be sent. The load will be cancelled either way.
Removing the invalidate method gets it closer to being a lambda.
- UIProcess/WebFramePolicyListenerProxy.cpp:
(WebKit::WebFramePolicyListenerProxy::invalidate): Deleted.
- UIProcess/WebFramePolicyListenerProxy.h:
- UIProcess/WebFrameProxy.cpp:
(WebKit::WebFrameProxy::webProcessWillShutDown):
(WebKit::WebFrameProxy::setUpPolicyListenerProxy):
- 10:23 AM Changeset in webkit [234152] by
-
- 3 edits in branches/safari-606-branch/Source/JavaScriptCore
Cherry-pick r234106. rdar://problem/42545682
Add some asserts to help diagnose a crash.
https://bugs.webkit.org/show_bug.cgi?id=187915
<rdar://problem/42508166>
Reviewed by Michael Saboff.
Add some asserts to verify that an CodeBlock alternative should always have a
non-null jitCode. Also change a RELEASE_ASSERT_NOT_REACHED() in
CodeBlock::setOptimizationThresholdBasedOnCompilationResult() to a RELEASE_ASSERT()
so that we'll retain the state of the variables that failed the assertion (again
to help with diagnosis).
- bytecode/CodeBlock.cpp: (JSC::CodeBlock::setAlternative): (JSC::CodeBlock::setOptimizationThresholdBasedOnCompilationResult):
- dfg/DFGPlan.cpp: (JSC::DFG::Plan::Plan):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234106 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 10:16 AM Changeset in webkit [234151] by
-
- 7 edits in branches/safari-606-branch/Source
Versioning.
- 9:43 AM Changeset in webkit [234150] by
-
- 2 edits in trunk/Tools
[Flatpak] Add openh264 as needed by WebRTC
https://bugs.webkit.org/show_bug.cgi?id=187956
Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-24
Reviewed by Philippe Normand.
- flatpak/org.webkit.WebKit.yaml:
- 9:29 AM Changeset in webkit [234149] by
-
- 11 edits7 adds in trunk
Cannot view PDF's on my.gov.au: "Refused to load https://my.gov.au/attachment/viewAttachment because it
appears in neither the object-src directive nor the default-src directive of the Content Security Policy"
https://bugs.webkit.org/show_bug.cgi?id=187870
<rdar://problem/41190880>
Reviewed by Dean Jackson.
Source/WebCore:
Fixes an issue where opening attachments on my.gov.au would show a "Blocked Plug-in" message.
Opening an attachment on my.gov.au opens a same-origin plugin document in a child window. Currently
same-origin plugin documents inherit their CSP policy from their opener. If the opener's CSP policy
disallows embedding plugins then the plugin document would be blocked from loading a plugin. For now
we relax the inheritance model such that we only inherit the plugin-types and report-uri directives
from the opener.
Developers that want to block plugin content from being loaded in a same-origin child window must now
serve such plugin content with a CSP policy that includes "object-src 'none'". This matches the behavior
described in the second Note in section object-src of the CSP 3 spec: <https://w3c.github.io/webappsec-csp/#directive-object-src>
(Editor's Draft, 10 July 2018). It also makes the behavior in WebKit more closely aligned with the
behavior of Chrome and Firefox.
Tests: http/tests/security/contentSecurityPolicy/same-origin-plugin-document-allowed-in-child-window.html
http/tests/security/contentSecurityPolicy/same-origin-plugin-document-blocked-in-child-window-report.php
http/tests/security/contentSecurityPolicy/same-origin-plugin-document-with-csp-blocked-in-child-window.html
- dom/Document.cpp:
(WebCore::Document::initContentSecurityPolicy): For plugin documents that have an opener call ContentSecurityPolicy::createPolicyForPluginDocumentFrom()
to only inherit the plugin-types and report-uri directives from its opener's CSP policy. Otherwise, call ContentSecurityPolicy::copyStateFrom()
to inherit all directives from the owner frame as we do now.
- page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::createPolicyForPluginDocumentFrom): Create a new policy from the specified policy
inheriting only the plugin-types and report-uri directives.
- page/csp/ContentSecurityPolicy.h: Define a new PolicyFrom enumerator, InheritedForPluginDocument, for plugin documents
loaded in a child window.
- page/csp/ContentSecurityPolicyDirectiveList.cpp:
(WebCore::ContentSecurityPolicyDirectiveList::parse): When policyFrom is InheritedForPluginDocument then only
recognize the plugin-types and report-uri directives when parsing the policy.
LayoutTests:
Add new tests and fix up the existing test http/tests/security/contentSecurityPolicy/same-origin-plugin-document-blocked-in-child-window.html
so that still tests a scenario where a same-origin plugin document loaded in a child window is blocked from
loading its plugin now that that "object-src: 'none'" is no longer inherited by the plugin document.
- http/tests/plugins/resources/plugin-document-alert-and-notify-done.pl:
- http/tests/security/contentSecurityPolicy/resources/checkDidSameOriginChildWindowLoad.js: Added.
(checkDidSameOriginChildWindowLoadAndNotifyDone):
(checkDidLoad):
- http/tests/security/contentSecurityPolicy/same-origin-plugin-document-allowed-in-child-window-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/same-origin-plugin-document-allowed-in-child-window.html: Added.
- http/tests/security/contentSecurityPolicy/same-origin-plugin-document-blocked-in-child-window-expected.txt:
- http/tests/security/contentSecurityPolicy/same-origin-plugin-document-blocked-in-child-window-report-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/same-origin-plugin-document-blocked-in-child-window-report.php: Added.
- http/tests/security/contentSecurityPolicy/same-origin-plugin-document-blocked-in-child-window.html:
- http/tests/security/contentSecurityPolicy/same-origin-plugin-document-with-csp-blocked-in-child-window-expected.txt: Added.
- http/tests/security/contentSecurityPolicy/same-origin-plugin-document-with-csp-blocked-in-child-window.html: Added.
- platform/ios/TestExpectations: Skip the included tests as we do not support plugins on iOS.
- platform/win/TestExpectations: Skip the included tests as plugins do not seem to work on Windows. We currently skip many
(if not all) plugin tests on Windows despite <rdar://problem/5074411> being marked as Closed (why?).
- 9:27 AM Changeset in webkit [234148] by
-
- 5 edits in trunk/Source/WebCore
Rename Document::firstPartyForSameSiteCookies() to siteForCookies()
https://bugs.webkit.org/show_bug.cgi?id=187892
Reviewed by Dean Jackson.
Standardize on the spec. language "site for cookies" for the names of the setter and getter
on Document. The latest description of Same-Site cookies is in <https://httpwg.org/http-extensions/rfc6265bis.html>.
No functionality changed. So, no new tests.
- dom/Document.h:
(WebCore::Document::siteForCookies const):
(WebCore::Document::setSiteForCookies):
(WebCore::Document::firstPartyForSameSiteCookies const): Deleted.
(WebCore::Document::setFirstPartyForSameSiteCookies): Deleted.
- loader/FrameLoader.cpp:
(WebCore::FrameLoader::setFirstPartyForCookies):
(WebCore::FrameLoader::addSameSiteInfoToRequestIfNeeded):
- workers/service/context/ServiceWorkerThreadProxy.cpp:
(WebCore::createPageForServiceWorker):
- xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::createDocumentFromSource):
- 8:15 AM Changeset in webkit [234147] by
-
- 4 edits in trunk
WebCore::URL::hostIsIPAddress needs a Windows implementation
https://bugs.webkit.org/show_bug.cgi?id=187859
Reviewed by Fujii Hironori.
Source/WebCore:
- platform/URL.cpp:
(WebCore::isIPv4Address): Added.
(WebCore::isIPv6Address): Added.
(WebCore::URL::hostIsIPAddress):
Turn this stub into a platform-agnostic default implementation.
Tools:
- TestWebKitAPI/Tests/WebCore/URL.cpp:
Check for a few other ways an IP address could be invalid.
- 8:04 AM Changeset in webkit [234146] by
-
- 10 edits in trunk/Source/WebCore
[MediaStream] Restructure getDisplayMedia classes
https://bugs.webkit.org/show_bug.cgi?id=187905
Reviewed by Dean Jackson.
No new tests, no functional changes.
- platform/mediastream/CaptureDeviceManager.h:
(WebCore::CaptureDeviceManager::refreshCaptureDevices): Deleted, no need for it to be a
virtual method.
- platform/mediastream/mac/AVCaptureDeviceManager.h:
- platform/mediastream/gstreamer/GStreamerCaptureDeviceManager.h: refreshCaptureDevices is
no longer virtual.
- platform/mediastream/mac/DisplayCaptureManagerCocoa.cpp:
(WebCore::DisplayCaptureManagerCocoa::captureDevices):
(WebCore::DisplayCaptureManagerCocoa::updateDisplayCaptureDevices): Moved functionality
to ScreenDisplayCaptureSourceMac.
(WebCore::DisplayCaptureManagerCocoa::screenCaptureDeviceWithPersistentID): Ditto.
(WebCore::displayReconfigurationCallBack): Deleted, moved to ScreenDisplayCaptureSourceMac.
(WebCore::DisplayCaptureManagerCocoa::~DisplayCaptureManagerCocoa): Deleted.
(WebCore::DisplayCaptureManagerCocoa::refreshCaptureDevices): Deleted.
- platform/mediastream/mac/DisplayCaptureManagerCocoa.h:
- platform/mediastream/mac/DisplayCaptureSourceCocoa.cpp:
(WebCore::roundUpToMacroblockMultiple): Moved from ScreenDisplayCaptureSourceMac.
(WebCore::DisplayCaptureSourceCocoa::applySize): Ditto.
(WebCore::DisplayCaptureSourceCocoa::sampleBufferFromPixelBuffer): Ditto.
(WebCore::DisplayCaptureSourceCocoa::pixelBufferFromIOSurface): Ditto.
- platform/mediastream/mac/DisplayCaptureSourceCocoa.h:
- platform/mediastream/mac/ScreenDisplayCaptureSourceMac.h:
- platform/mediastream/mac/ScreenDisplayCaptureSourceMac.mm:
(WebCore::updateDisplayID):
(WebCore::ScreenDisplayCaptureSourceMac::createDisplayStream): Fix log message.
(WebCore::ScreenDisplayCaptureSourceMac::startDisplayStream): Ditto.
(WebCore::ScreenDisplayCaptureSourceMac::applySize): Update for base class changes.
(WebCore::ScreenDisplayCaptureSourceMac::applyFrameRate): Ditto.
(WebCore::ScreenDisplayCaptureSourceMac::frameAvailable): Ditto.
(WebCore::ScreenDisplayCaptureSourceMac::screenCaptureDeviceWithPersistentID): Moved from
DisplayCaptureManagerCocoa.
(WebCore::ScreenDisplayCaptureSourceMac::screenCaptureDevices): Ditto.
(WebCore::roundUpToMacroblockMultiple): Moved to DisplayCaptureSourceCocoa.
(WebCore::ScreenDisplayCaptureSourceMac::updateDisplayID): Ditto.
(WebCore::ScreenDisplayCaptureSourceMac::sampleBufferFromPixelBuffer): Ditto.
(WebCore::ScreenDisplayCaptureSourceMac::pixelBufferFromIOSurface): Ditto.
- 7:47 AM Changeset in webkit [234145] by
-
- 7 edits1 add in trunk/Source/WebCore
[LFC] Move geometry data structures to a dedicated file
https://bugs.webkit.org/show_bug.cgi?id=187939
Reviewed by Antti Koivisto.
- WebCore.xcodeproj/project.pbxproj:
- layout/FormattingContext.h:
(WebCore::Layout::FormattingContext::Geometry::Position::operator LayoutPoint const): Deleted.
- layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::computedBorder):
(WebCore::Layout::FormattingContext::Geometry::computedPadding):
(WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedHorizontalMarginValue):
(WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedVerticalMarginValue):
- layout/blockformatting/BlockFormattingContext.h:
- layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowPositionedPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowWidthAndMargin):
- layout/displaytree/DisplayBox.h:
(WebCore::Display::Box::setHorizontalMargin):
(WebCore::Display::Box::setVerticalMargin):
(WebCore::Display::Box::setVerticalNonCollapsedMargin):
(WebCore::Display::Box::setBorder):
(WebCore::Display::Box::setPadding):
- 7:40 AM Changeset in webkit [234144] by
-
- 2 edits in trunk/Tools
[Flatpak] Avoid consuming unknown arguments in flatpak wrapper
https://bugs.webkit.org/show_bug.cgi?id=187951
When running run-webkit-tests --wpe --debug, it was observed that
both self.platform != 'wpe' and self.debug != True. This turned
out to be because of the "args" argument consuming the remainder
of future arguments that came after it. Since the first argument
to load_from_args was the test script to run, it would end up
never processing the other arguments supplied to the wrapper
script.
Tested this by rebuilding GTK in debug mode, running the
minibrowser with various extra options, and running some tests
with various extra options.
Reviewed by Michael Catanzaro.
- flatpak/flatpakutils.py:
(WebkitFlatpak.load_from_args):
- 7:16 AM WebKitGTK/2.20.x edited by
- Propose r229282 (resolves bug #183788) (diff)
- 6:22 AM Changeset in webkit [234143] by
-
- 5 edits in trunk/Source/WebKit
WebFullScreenManagerProxy does not need to be ref counted
https://bugs.webkit.org/show_bug.cgi?id=187928
Reviewed by Eric Carlson.
WebFullScreenManagerProxy does not need to be ref counted, it is owned by WebPageProxy.
It is also error-prone because WebFullScreenManagerProxy has a raw pointer to its WebPageProxy
and anybody could extend the lifetime of the WebFullScreenManagerProxy by refing it, which
would make the WebPageProxy pointer stale.
- UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::WebFullScreenManagerProxy):
(WebKit::WebFullScreenManagerProxy::willEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::didEnterFullScreen):
(WebKit::WebFullScreenManagerProxy::willExitFullScreen):
(WebKit::WebFullScreenManagerProxy::didExitFullScreen):
(WebKit::WebFullScreenManagerProxy::setAnimatingFullScreen):
(WebKit::WebFullScreenManagerProxy::requestExitFullScreen):
(WebKit::WebFullScreenManagerProxy::saveScrollPosition):
(WebKit::WebFullScreenManagerProxy::restoreScrollPosition):
(WebKit::WebFullScreenManagerProxy::setFullscreenInsets):
(WebKit::WebFullScreenManagerProxy::setFullscreenAutoHideDuration):
(WebKit::WebFullScreenManagerProxy::setFullscreenControlsHidden):
(WebKit::WebFullScreenManagerProxy::invalidate):
- UIProcess/WebFullScreenManagerProxy.h:
- UIProcess/WebPageProxy.cpp:
(WebKit::m_resetRecentCrashCountTimer):
(WebKit::WebPageProxy::reattachToWebProcess):
- UIProcess/WebPageProxy.h:
- 3:50 AM Changeset in webkit [234142] by
-
- 1 edit32 adds in trunk/LayoutTests
Unreviewed WPE gardening.
Adding WPE-specific baselines for WebGL2 conformance tests that are
already passing on this port.
- platform/wpe/webgl: Added.
- platform/wpe/webgl/2.0.0: Added.
- platform/wpe/webgl/2.0.0/conformance2: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/array-as-return-value-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/array-assign-constructor-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/array-assign-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/array-complex-indexing-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/array-element-increment-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/array-equality-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/array-in-complex-expression-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/bool-type-cast-bug-uint-ivec-uvec-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/compare-structs-containing-arrays-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/compound-assignment-type-combination-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/const-array-init-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/forbidden-operators-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/frag-depth-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/invalid-default-precision-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/invalid-invariant-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/loops-with-side-effects-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/misplaced-version-directive-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/sampler-no-precision-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/sequence-operator-returns-non-constant-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/shader-linking-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/short-circuiting-in-loop-condition-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/texture-offset-uniform-texture-coordinate-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/tricky-loop-conditions-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/uniform-block-layout-match-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/uniform-block-layouts-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/valid-invariant-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/vector-dynamic-indexing-expected.txt: Added.
- platform/wpe/webgl/2.0.0/conformance2/glsl3/vector-dynamic-indexing-nv-driver-bug-expected.txt: Added.
- 2:08 AM Changeset in webkit [234141] by
-
- 5 edits in trunk/Source
[GStreamer] Implement bitrate modulation support in GStreamer based libwebrtc Encoders
https://bugs.webkit.org/show_bug.cgi?id=187643
Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-24
Reviewed by Philippe Normand.
Source/WebCore:
Problem being that we do not have a proper unified encoder API in GStreamer, some work
started at https://bugzilla.gnome.org/show_bug.cgi?id=796716 but it is quite controversial
and meanwhile we should just move forward working around that limitation.
Source/WebCore:
- platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
(WebCore::GStreamerVideoEncoder::GStreamerVideoEncoder):
(WebCore::GStreamerVideoEncoder::InitEncode):
(WebCore::GStreamerVideoEncoder::getBitrateSetter):
(WebCore::GStreamerVideoEncoder::createEncoder):
(WebCore::GStreamerVideoEncoder::AddCodecIfSupported):
(WebCore::GStreamerVideoEncoder::SetRestrictionCaps):
(WebCore::GStreamerVideoEncoder::CreateEncoder): Deleted.
Source/WTF:
Added support for GRegex in GRefPtr.
Source/WTF:
- wtf/glib/GRefPtr.cpp:
(WTF::refGPtr):
(WTF::derefGPtr):
- wtf/glib/GRefPtr.h:
- 1:55 AM Changeset in webkit [234140] by
-
- 2 edits in trunk/Source/WebCore
REGRESSION(r234055): inverted return values in MediaPlayer::wouldTaintOrigin()
https://bugs.webkit.org/show_bug.cgi?id=187944
Reviewed by Carlos Garcia Campos.
The MediaPlayer::wouldTaintOrigin(), as introduced in r234055, should
return false when the URL protocol isdata:, and should return true
when the given SecurityOrigin cannot access the media URL.
This matches behavior of CanvasRenderingContext::wouldTaintOrigin()
which the new method falls back to when the MediaPlayerPrivate
implementation doesn't or can't determine the would-taint result.
This fixes a bunch of failing and timing-out WebGL test cases on ports
using GStreamer (on which the MediaPlayerPrivate derivate doesn't
implement the wouldTaintOrigin() method).
- platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::wouldTaintOrigin const):
- 1:54 AM Changeset in webkit [234139] by
-
- 10 edits in trunk/Source
[TextureMapper] Separate repaint counter state from debug visuals
https://bugs.webkit.org/show_bug.cgi?id=187946
Reviewed by Carlos Garcia Campos.
Instead of managing the repaint counter visibility along with the
debug border visuals, do that together with the repaint count value.
Source/WebCore:
TextureMapperLayer::setRepaintCount() is renamed to setRepaintCounter()
and now also sets the repaint counter visibility state instead of the
setDebugVisuals() method.
GraphicsLayerTextureMapper implementation is adjusted appropriately.
The unused setRepaintCount() method is also removed.
CoordinatedGraphicsLayerState now holds repaint counter state (both
visibility and count value) in a struct that's separate from debug
border state. CoordinatedGraphicsLayer implementation now updates
that state accordingly.
No new tests -- no change in behavior.
- platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setShowRepaintCounter):
(WebCore::GraphicsLayerTextureMapper::commitLayerChanges):
(WebCore::GraphicsLayerTextureMapper::setRepaintCount): Deleted.
- platform/graphics/texmap/GraphicsLayerTextureMapper.h:
- platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::setDebugVisuals):
(WebCore::TextureMapperLayer::setRepaintCounter):
(WebCore::TextureMapperLayer::setRepaintCount): Deleted.
- platform/graphics/texmap/TextureMapperLayer.h:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::didUpdateTileBuffers):
(WebCore::CoordinatedGraphicsLayer::setShowRepaintCounter):
(WebCore::CoordinatedGraphicsLayer::syncLayerState):
- platform/graphics/texmap/coordinated/CoordinatedGraphicsState.h:
(WebCore::CoordinatedGraphicsLayerState::CoordinatedGraphicsLayerState):
(WebCore::DebugVisuals::DebugVisuals): Deleted.
Source/WebKit:
In the CoordinatedGraphicsScene class, remove the helper
setLayerRepaintCountIfNeeded() method that's only been called in one
place, and instead set the repaint count information on the
TextureMapperLayer object directly from setLayerState(). The repaint
counter visiblity and count value are gathered from the new struct
that's kept on the CoordinatedGraphicsLayerState object.
- Shared/CoordinatedGraphics/CoordinatedGraphicsScene.cpp:
(WebKit::CoordinatedGraphicsScene::setLayerState):
(WebKit::CoordinatedGraphicsScene::setLayerRepaintCountIfNeeded): Deleted.
- Shared/CoordinatedGraphics/CoordinatedGraphicsScene.h:
- 1:24 AM Changeset in webkit [234138] by
-
- 26 edits6 adds in trunk
.:
[WPE][GTK] Implement PeerConnection API on top of libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=186932
Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-24
Reviewed by Philippe Normand.
- Source/cmake/FindGStreamer.cmake: Look for gstreamer-codecparser as it needed for GStreamerVideoDecoder
Source/ThirdParty/libwebrtc:
[WPE][GTK] Implement PeerConnection API on top of libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=186932
Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-24
Reviewed by Philippe Normand.
- CMakeLists.txt: Properly set our build as
WEBRTC_WEBKIT_BUILD
Source/WebCore:
[WPE][GTK] Implement PeerConnection API on top of libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=186932
Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-24
Reviewed by Philippe Normand.
Enabled many webrtc tests.
- platform/GStreamer.cmake: Build new files
- platform/graphics/gstreamer/GStreamerCommon.cpp: Fix minor style issues
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: Add a way to give precise name to pipelines
and give useful names to pipelines with sources comming from a PeerConnection
- platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h: Ditto.
- platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.cpp: Added. Implement a subclass of webrtc::VideoFrame
to represent a kNative GStreamer video frame.
- platform/mediastream/gstreamer/GStreamerVideoFrameLibWebRTC.h: Added. Ditto.
- platform/mediastream/gstreamer/RealtimeIncomingAudioSourceLibWebRTC.cpp: Handle incoming audio samples from libwebrtc.
- platform/mediastream/gstreamer/RealtimeIncomingAudioSourceLibWebRTC.h: Ditto.
- platform/mediastream/gstreamer/RealtimeIncomingVideoSourceLibWebRTC.cpp: Handle incoming video frames from libwebrtc.
- platform/mediastream/gstreamer/RealtimeIncomingVideoSourceLibWebRTC.h: Ditto.
- platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.cpp: Handle passing locally captured audio sample to libwebrtc.
- platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.h: Ditto.
- platform/mediastream/gstreamer/RealtimeOutgoingVideoSourceLibWebRTC.cpp: Handle passing locally captured vidoe frames to libwebrtc.
- platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp: Added. Implement a video decoder factory and LibWebRTC Video decoders based on GStreamer.
- platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.h: Added. Ditto.
- platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp: Added. Implement a video encoder factory and LibWebRTC H264/VP8 Video encoders based on GStreamer.
- platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.h: Added. Ditto.
- platform/mediastream/libwebrtc/LibWebRTCAudioFormat.h: Add information about signness of the LibWebRTC audio format.
- platform/mediastream/libwebrtc/LibWebRTCProviderGlib.cpp: Add support for newly added Encoder/Decoder factories.
- platform/mediastream/libwebrtc/LibWebRTCProviderGlib.h: Ditto.
Source/WebKit:
[WPE][GTK] Implement WebRTC based on libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=186932
Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-24
Reviewed by Philippe Normand.
- WebProcess/Network/webrtc/LibWebRTCProvider.h: Use LibWebRTCProviderGlib when building WPE or GTK ports.
LayoutTests:
[WPE][GTK] Implement PeerConnection API on top of libwebrtc
https://bugs.webkit.org/show_bug.cgi?id=186932
Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-24
Reviewed by Philippe Normand.
- platform/gtk/TestExpectations: Enable webrtc tests.
- 1:15 AM Changeset in webkit [234137] by
-
- 2 edits in trunk/Tools
[Flatpak] Remove now unnecessary 'hacks' for running tests
https://bugs.webkit.org/show_bug.cgi?id=187608
Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-07-24
Reviewed by Philippe Normand.
We used to need to not share X11 with the sandbox when running tests
but it is not needed anymore as we do not mount/tmpon/tmpin the
sandbox (we mount it on/run/host/tmpnow).
This has the advantage of making running the MiniBrowser to display test
results working again.
- flatpak/flatpakutils.py:
(WebkitFlatpak.clean_args):
(WebkitFlatpak.run_in_sandbox):
(WebkitFlatpak._cleanup_faltpak_args_for_tests_if_needed): Deleted.
- 1:14 AM Changeset in webkit [234136] by
-
- 3 edits2 adds in trunk
[css-masking] Black backdrop on -webkit-clip-path on SVG root
https://bugs.webkit.org/show_bug.cgi?id=187880
Source/WebCore:
Reviewed by Simon Fraser.
For SVG document root elements, we currently clip twice:
In RenderLayer and SVGRenderSupport.
Avoid clipping in RenderLayer which currently clips before we established a
backdrop for an SVG document.
Tests: svg/clip-path/clip-path-on-svg-005-expected.svg
svg/clip-path/clip-path-on-svg-005.svg
- rendering/RenderLayer.cpp:
(WebCore::RenderLayer::setupClipPath): Skip actual clipping.
LayoutTests:
Avoid duplicated clip in RenderLayer.
Reviewed by Simon Fraser.
- svg/clip-path/clip-path-on-svg-005-expected.svg: Added.
- svg/clip-path/clip-path-on-svg-005.svg: Added.
- 12:34 AM Changeset in webkit [234135] by
-
- 3 edits in trunk/Source/WebCore
[Nicosia] Add TextureMapperAnimations member to CompositingLayer::LayerState
https://bugs.webkit.org/show_bug.cgi?id=187941
Reviewed by Carlos Garcia Campos.
Nicosia::CompositingLayer::LayerState gains a TextureMapperAnimations
member that will be assigned a list of all active animations during each
layer flush. Despite the name, TextureMapperAnimations doesn't depend on
any other TextureMapper class. It might be renamed and moved in the
future, but for now it's used as-is.
In CoordinatedGraphicsLayer, the syncAnimations() method now flips on
the animationsChanged flag in the LayerState::Delta struct. This causes
all the active animations to be copied over into the layer state in
flushCompositingStateForThisLayerOnly().
- platform/graphics/nicosia/NicosiaPlatformLayer.h:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::syncAnimations):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
- 12:28 AM Changeset in webkit [234134] by
-
- 3 edits in trunk/Source/WebCore
[Nicosia] Add FilterOperations member to CompositionLayer::LayerState
https://bugs.webkit.org/show_bug.cgi?id=187901
Reviewed by Carlos Garcia Campos.
Nicosia::CompositionLayer::LayerState gains a FilterOperations member
that can be assigned the list of filter operations for a given layer.
The corresponding filtersChanged boolean is added to LayerState::Delta.
CoordinatedGraphicsLayer::syncFilters() flips on that delta member,
which in turn causes the FilterOperations value to be updated during
the layer flush, in flushCompositingStateForThisLayerOnly().
- platform/graphics/nicosia/NicosiaPlatformLayer.h:
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::syncFilters):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
- 12:27 AM Changeset in webkit [234133] by
-
- 2 edits in trunk/Source/WebCore
[CoordGraphics] Use adjusted position, anchor point, size values for Nicosia::CompositionLayer state
https://bugs.webkit.org/show_bug.cgi?id=187899
Reviewed by Carlos Garcia Campos.
As is done for the CoordinatedGraphicsLayerState, the scale-adjusted
position, anchor point and size values should be used when updating the
corresponding Nicosia::CompositionLayer::LayerState members.
- platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
Jul 23, 2018:
- 11:44 PM Changeset in webkit [234132] by
-
- 2 edits in trunk/LayoutTests
The test webanimations/accessing-current-time-after-finished-css-animation-target-removal.html is failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=187943
Unreviewed test gardening.
- platform/win/TestExpectations:
- 9:50 PM Changeset in webkit [234131] by
-
- 6 edits4 adds in trunk
[css-grid] Add support for calc() in gutter properties
https://bugs.webkit.org/show_bug.cgi?id=187902
Reviewed by Simon Fraser.
LayoutTests/imported/w3c:
Two new WPT tests are imported to verify the expected behavior.
- web-platform-tests/css/css-grid/abspos/grid-positioned-items-gaps-002-expected.txt: Added.
- web-platform-tests/css/css-grid/abspos/grid-positioned-items-gaps-002-rtl-expected.txt: Added.
- web-platform-tests/css/css-grid/abspos/grid-positioned-items-gaps-002-rtl.html: Added.
- web-platform-tests/css/css-grid/abspos/grid-positioned-items-gaps-002.html: Added.
- web-platform-tests/css/css-grid/abspos/w3c-import.log:
Source/WebCore:
The parsing was already accepting calc() in grid row and column gaps,
however the code was not taking that into account properly.
If the calc() had a percentage it was ignored and that's wrong.
The fix is just a change in the ceck at RenderGrid::availableSpaceForGutters().
Tests: imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-gaps-002-rtl.html
imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-gaps-002.html
imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-011.html
imported/w3c/web-platform-tests/css/css-grid/alignment/grid-gutters-012.html
- rendering/RenderGrid.cpp:
(WebCore::RenderGrid::availableSpaceForGutters const):
LayoutTests:
Two tests are now passing thanks to this change.
- 7:18 PM Changeset in webkit [234130] by
-
- 2 edits in trunk/Tools
webkitpy.port.server_process_unittest.TestServerProcess.test_basic failed on Windows Python
https://bugs.webkit.org/show_bug.cgi?id=187581
Reviewed by Daniel Bates.
There are two failures in this test case:
- proc.poll() doesn't return 0.
- stderr is not output.
For failure #1, this is expected. the process should not exit at
the time. proc.poll() should return None because the process is
still alive.
This change added a new test to check proc.poll() becomes 0 after
the process successfully exits.
For failure #2, stderr is not flushed even though stdout is
flushed. This change uses '-u' command switch to force stdin,
stdout and stderr to be totally unbuffered.
- Scripts/webkitpy/port/server_process_unittest.py:
(TestServerProcess.test_basic): Added -u command switch. Do not
flush stdout. Removed the special condition for Windows. Add a new
test to check proc.poll() returns 0.
(TestServerProcess.test_process_crashing): Added -u command
switch. Do not flush stdout.
- 6:35 PM Changeset in webkit [234129] by
-
- 4 edits in trunk/Source/WebKit
[WinCairo] Add implementation for setting cursors
https://bugs.webkit.org/show_bug.cgi?id=187868
Reviewed by Fujii Hironori.
- UIProcess/win/PageClientImpl.cpp:
(WebKit::PageClientImpl::setCursor): Set cursor on the webview
- UIProcess/win/WebView.cpp:
(WebKit::WebView::setCursor): Add implementation to set the
web cursor to update the Windows cursor
- UIProcess/win/WebView.h:
- 6:32 PM Changeset in webkit [234128] by
-
- 3 edits1 add in trunk
need to didFoldClobberWorld when we constant fold GetByVal
https://bugs.webkit.org/show_bug.cgi?id=187917
<rdar://problem/42505095>
Reviewed by Yusuke Suzuki.
JSTests:
- stress/get-by-val-fold-did-clobber-world.js: Added.
(f_443):
Source/JavaScriptCore:
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- 6:05 PM Changeset in webkit [234127] by
-
- 18 edits2 adds in trunk
[INTL] Language tags are not canonicalized
https://bugs.webkit.org/show_bug.cgi?id=185836
Patch by Andy VanWagoner <andy@vanwagoner.family> on 2018-07-23
Reviewed by Keith Miller.
JSTests:
Remove expected failures that have been fixed.
- test262/expectations.yaml:
Source/JavaScriptCore:
Canonicalize language tags, replacing deprecated tag parts with the
preferred values. Remove broken support for algorithmic numbering systems,
that can cause an error in icu, and are not supported in other engines.
Generate the lookup functions from the language-subtag-registry.
Also initialize the UNumberFormat in initializeNumberFormat so any
failures are thrown immediately instead of failing to format later.
- CMakeLists.txt:
- DerivedSources.make:
- JavaScriptCore.xcodeproj/project.pbxproj:
- Scripts/generateIntlCanonicalizeLanguage.py: Added.
- runtime/IntlDateTimeFormat.cpp:
(JSC::IntlDateTimeFormat::initializeDateTimeFormat):
- runtime/IntlNumberFormat.cpp:
(JSC::IntlNumberFormat::initializeNumberFormat):
(JSC::IntlNumberFormat::formatNumber):
(JSC::IntlNumberFormat::formatToParts):
(JSC::IntlNumberFormat::createNumberFormat): Deleted.
- runtime/IntlNumberFormat.h:
- runtime/IntlObject.cpp:
(JSC::intlNumberOption):
(JSC::intlDefaultNumberOption):
(JSC::preferredLanguage):
(JSC::preferredRegion):
(JSC::canonicalLangTag):
(JSC::canonicalizeLanguageTag):
(JSC::defaultLocale):
(JSC::removeUnicodeLocaleExtension):
(JSC::numberingSystemsForLocale):
(JSC::grandfatheredLangTag): Deleted.
- runtime/IntlObject.h:
- runtime/IntlPluralRules.cpp:
(JSC::IntlPluralRules::initializePluralRules):
- runtime/JSGlobalObject.cpp:
(JSC::addMissingScriptLocales):
(JSC::JSGlobalObject::intlCollatorAvailableLocales):
(JSC::JSGlobalObject::intlDateTimeFormatAvailableLocales):
(JSC::JSGlobalObject::intlNumberFormatAvailableLocales):
(JSC::JSGlobalObject::intlPluralRulesAvailableLocales):
- ucd/language-subtag-registry.txt: Added.
LayoutTests:
Use gregory instead of gregorian, matching test262/intl402 and other engines.
Remove tests for algorithmic numbering systems. Add NumberFormat numbering system tests.
- js/intl-datetimeformat-expected.txt:
- js/intl-numberformat-expected.txt:
- js/script-tests/intl-datetimeformat.js:
- js/script-tests/intl-numberformat.js:
(string_appeared_here):
- 5:42 PM Changeset in webkit [234126] by
-
- 2 edits in trunk/Source/WebCore
Remove extraneous #endif in html.css
https://bugs.webkit.org/show_bug.cgi?id=187934
Patch by Aditya Keerthi <Aditya Keerthi> on 2018-07-23
Reviewed by Tim Horton.
- css/html.css: Remove extraneous #endif.
- 5:35 PM Changeset in webkit [234125] by
-
- 9 edits in trunk
CrashTracer: com.apple.WebKit.Storage at WebCore: WebCore::encodeKey
https://bugs.webkit.org/show_bug.cgi?id=187927
LayoutTests/imported/w3c:
<rdar://problem/42516426>
Reviewed by Chris Dumez.
- web-platform-tests/IndexedDB/key-conversion-exceptions-expected.txt:
Source/WebCore:
Reviewed by Chris Dumez.
IDBKeyData is valid only when each key of it is valid.
Test: LayoutTests/storage/indexeddb/index-multientry.html
- Modules/indexeddb/IDBKeyData.cpp:
(WebCore::IDBKeyData::isValid const):
- Modules/indexeddb/IDBKeyData.h:
(WebCore::IDBKeyData::isValid const): Deleted.
LayoutTests:
<rdar://problem/42516426>
Reviewed by Chris Dumez.
Add a new test case in existing test file to cover the crash case and update the expecation accordingly.
- storage/indexeddb/index-multientry-expected.txt:
- storage/indexeddb/index-multientry-private-expected.txt:
- storage/indexeddb/resources/index-multientry.js:
(addData):
- 5:27 PM Changeset in webkit [234124] by
-
- 3 edits in trunk/Source/WebKit
Crash when loadViewIfRequired called while WKFullScreenViewController is being deallocated.
https://bugs.webkit.org/show_bug.cgi?id=187920
rdar://problem/41324023
Patch by Jeremy Jones <jeremyj@apple.com> on 2018-07-23
Reviewed by Eric Carlson.
Clear dangling weak-ref.
Prevent async playback state calls from instantiating the interface.
Release WKFullScreenViewController when it is no longer needed.
- UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController dealloc]):
(-[WKFullScreenViewController setPlaying:]):
(-[WKFullScreenViewController setAnimating:]):
- UIProcess/ios/fullscreen/WKFullScreenWindowControllerIOS.mm:
(-[WKFullScreenWindowController _completedExitFullScreen]):
- 5:09 PM Changeset in webkit [234123] by
-
- 3 edits in trunk/Source
Try to fix the build.
- UIProcess/mac/ServicesController.mm:
(WebKit::hasCompatibleServicesForItems):
- 5:01 PM Changeset in webkit [234122] by
-
- 5 edits in trunk
WTF::StringView::split should have an allowEmptyEntries flag
https://bugs.webkit.org/show_bug.cgi?id=187864
Reviewed by Konstantin Tokarev.
Source/WTF:
- wtf/text/StringView.cpp:
(WTF::StringView::SplitResult::Iterator::findNextSubstring):
(WTF::StringView::SplitResult::Iterator::operator++):
- wtf/text/StringView.h:
(WTF::StringView::split const):
(WTF::StringView::SplitResult::SplitResult):
(WTF::StringView::SplitResult::Iterator::operator== const):
We can't mimic String::split completely, because this one's iterator-based --
achieve desired behavior by adding m_allowEmptyEntries to SplitResult and m_isDone to its Iterator.
(The latter keeps us from hitting begin() == end() prematurely on a final empty entry.)
Tools:
- TestWebKitAPI/Tests/WTF/StringView.cpp: Add test.
- 4:44 PM Changeset in webkit [234121] by
-
- 24 edits6 adds in trunk
We should cache the compiled sandbox profile in a data vault
https://bugs.webkit.org/show_bug.cgi?id=184991
Patch by Ben Richards <benton_richards@apple.com> on 2018-07-23
Reviewed by Ryosuke Niwa.
Source/WebCore:
Added functionality to FileHandle so that it can lock a file while open.
Added a function to FileSystem to delete non empty directories.
- platform/FileHandle.cpp:
(WebCore::FileHandle::FileHandle):
(WebCore::FileHandle::open):
(WebCore::FileHandle::close):
- platform/FileHandle.h:
- platform/FileSystem.h:
- platform/cocoa/FileSystemCocoa.mm:
(WebCore::FileSystem::deleteNonEmptyDirectory):
Source/WebKit:
This patch changes a few things (note: data vaults and sandbox entitlements are only used in internal builds):
(1) Instead of compiling a sandbox every time a process is launched, processes now look for a cached sandbox
in a process specific data vault on macOS platforms. (ChildProcessMac.mm)
(2) If a valid cached sandbox is not found, a process will create the data vault (or ensure that it exists),
compile a sandbox, and cache it.
(3) In order to create process specific data vaults, each process now has their own <process name>-OSX-sandbox.entitlements
file which contains an entitlement with a process specific "storage class" which ensures that each process
can only ever access its own data vault. (See the article on confluence "Data Vaults and Restricted Files" for more info)
(4) The sandbox entitlements file for the Network, WebContent and Plugin services are loaded dynamically
through Scripts/<process name>-process-entitlements.sh which is triggered in a new build phase for each service.
The Storage process sandbox entitlements are loaded directly in Configurations/StorageService.xcconfig.
The reason that the sandbox entitlements are applied dynamically is so that these sandbox entitlements
are only applied when WK_USE_RESTRICTED_ENTITLEMENTS is YES. This means that open source builds will still work.
- Configurations/Network-OSX-sandbox.entitlements: Added.
- Configurations/Plugin-OSX-sandbox.entitlements: Added.
- Configurations/Storage-OSX-sandbox.entitlements: Added.
- Configurations/StorageService.xcconfig:
- Configurations/WebContent-OSX-sandbox.entitlements: Added.
- Configurations/WebKit.xcconfig:
- NetworkProcess/NetworkProcess.h:
- PluginProcess/PluginProcess.h:
- Scripts/process-network-entitlements.sh: Added.
- Scripts/process-plugin-entitlements.sh: Added.
- Scripts/process-webcontent-entitlements.sh:
- Shared/ChildProcess.h:
- Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializer):
- Shared/SandboxInitializationParameters.h:
(WebKit::SandboxInitializationParameters::setOverrideSandboxProfilePath):
(WebKit::SandboxInitializationParameters::overrideSandboxProfilePath const):
(WebKit::SandboxInitializationParameters::setSandboxProfile):
(WebKit::SandboxInitializationParameters::sandboxProfile const):
(): Deleted.
- Shared/mac/ChildProcessMac.mm:
(WebKit::SandboxProfileDeleter::operator()):
(WebKit::SandboxParametersDeleter::operator()):
(WebKit::SandboxInfo::SandboxInfo):
(WebKit::fileContents):
(WebKit::processStorageClass):
(WebKit::setAndSerializeSandboxParameters):
(WebKit::getUserCacheDirectory):
(WebKit::sandboxDataVaultParentDirectory):
(WebKit::sandboxDirectory):
(WebKit::sandboxFilePath):
(WebKit::ensureSandboxCacheDirectory):
(WebKit::writeSandboxDataToCacheFile):
(WebKit::compileAndCacheSandboxProfile):
(WebKit::tryApplyCachedSandbox):
(WebKit::webKit2Bundle):
(WebKit::sandboxProfilePath):
(WebKit::compileAndApplySandboxSlowCase):
(WebKit::applySandbox):
(WebKit::initializeSandboxParameters):
(WebKit::ChildProcess::initializeSandbox):
- Shared/mac/SandboxInitialiationParametersMac.mm:
(WebKit::SandboxInitializationParameters::SandboxInitializationParameters):
- StorageProcess/StorageProcess.h:
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebProcess.h:
Source/WTF:
Added trace points for sandbox initialization and exposed functions needed for sandbox caching
- wtf/SystemTracing.h:
- wtf/spi/darwin/SandboxSPI.h:
Tools:
Added trace points for sandbox initialization
- Tracing/SystemTracePoints.plist:
- 4:27 PM Changeset in webkit [234120] by
-
- 5 edits in trunk/Source
Creating and loading content in a WKWebView triggers Main Thread Checker warnings under ServicesController
https://bugs.webkit.org/show_bug.cgi?id=186963
<rdar://problem/41393682>
Reviewed by Timothy Hatcher.
Source/WebCore/PAL:
- pal/spi/mac/NSSharingServiceSPI.h:
Add the new SPI.
Source/WebKit:
- UIProcess/mac/ServicesController.h:
- UIProcess/mac/ServicesController.mm:
(WebKit::hasCompatibleServicesForItems):
(WebKit::ServicesController::refreshExistingServices):
Adopt async ShareKit SPI that is actually thread-safe instead of the not-quite-safe
synchronous API. Request all three sets of services immediately, and dispatch
to the Web Content processes when all three have returned.
- 4:25 PM Changeset in webkit [234119] by
-
- 2 edits in trunk/LayoutTests
[Curl] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=187932
Unreviewed test gardening.
Enable Secure WebSocket tests.
- platform/wincairo/TestExpectations:
- 4:20 PM Changeset in webkit [234118] by
-
- 39 edits in trunk/LayoutTests
Enable WebGL2 glsl3 tests with expected FAIL results
https://bugs.webkit.org/show_bug.cgi?id=187929
<rdar://problem/42516498>
Patch by Justin Fan <Justin Fan> on 2018-07-23
Reviewed by Dean Jackson.
Before enabling glsl ES 3 for WebGL2 work, enable corresponding webgl2 conformance tests.
- TestExpectations:
- webgl/2.0.0/conformance2/glsl3/array-as-return-value-expected.txt:
- webgl/2.0.0/conformance2/glsl3/array-assign-constructor-expected.txt:
- webgl/2.0.0/conformance2/glsl3/array-assign-expected.txt:
- webgl/2.0.0/conformance2/glsl3/array-complex-indexing-expected.txt:
- webgl/2.0.0/conformance2/glsl3/array-element-increment-expected.txt:
- webgl/2.0.0/conformance2/glsl3/array-equality-expected.txt:
- webgl/2.0.0/conformance2/glsl3/array-in-complex-expression-expected.txt:
- webgl/2.0.0/conformance2/glsl3/attrib-location-length-limits-expected.txt:
- webgl/2.0.0/conformance2/glsl3/bool-type-cast-bug-uint-ivec-uvec-expected.txt:
- webgl/2.0.0/conformance2/glsl3/compare-structs-containing-arrays-expected.txt:
- webgl/2.0.0/conformance2/glsl3/compound-assignment-type-combination-expected.txt:
- webgl/2.0.0/conformance2/glsl3/const-array-init-expected.txt:
- webgl/2.0.0/conformance2/glsl3/forbidden-operators-expected.txt:
- webgl/2.0.0/conformance2/glsl3/frag-depth-expected.txt:
- webgl/2.0.0/conformance2/glsl3/invalid-default-precision-expected.txt:
- webgl/2.0.0/conformance2/glsl3/invalid-invariant-expected.txt:
- webgl/2.0.0/conformance2/glsl3/loops-with-side-effects-expected.txt:
- webgl/2.0.0/conformance2/glsl3/misplaced-version-directive-expected.txt:
- webgl/2.0.0/conformance2/glsl3/no-attribute-vertex-shader-expected.txt:
- webgl/2.0.0/conformance2/glsl3/sampler-no-precision-expected.txt:
- webgl/2.0.0/conformance2/glsl3/sequence-operator-returns-non-constant-expected.txt:
- webgl/2.0.0/conformance2/glsl3/shader-linking-expected.txt:
- webgl/2.0.0/conformance2/glsl3/shader-with-1024-character-define-expected.txt:
- webgl/2.0.0/conformance2/glsl3/shader-with-1024-character-identifier.frag-expected.txt:
- webgl/2.0.0/conformance2/glsl3/shader-with-invalid-characters-expected.txt:
- webgl/2.0.0/conformance2/glsl3/shader-with-mis-matching-uniform-block-expected.txt:
- webgl/2.0.0/conformance2/glsl3/short-circuiting-in-loop-condition-expected.txt:
- webgl/2.0.0/conformance2/glsl3/texture-offset-out-of-range-expected.txt:
- webgl/2.0.0/conformance2/glsl3/texture-offset-uniform-texture-coordinate-expected.txt:
- webgl/2.0.0/conformance2/glsl3/tricky-loop-conditions-expected.txt:
- webgl/2.0.0/conformance2/glsl3/unary-minus-operator-in-dynamic-loop-expected.txt:
- webgl/2.0.0/conformance2/glsl3/uniform-block-layout-match-expected.txt:
- webgl/2.0.0/conformance2/glsl3/uniform-block-layouts-expected.txt:
- webgl/2.0.0/conformance2/glsl3/uniform-location-length-limits-expected.txt:
- webgl/2.0.0/conformance2/glsl3/valid-invariant-expected.txt:
- webgl/2.0.0/conformance2/glsl3/vector-dynamic-indexing-expected.txt:
- webgl/2.0.0/conformance2/glsl3/vector-dynamic-indexing-nv-driver-bug-expected.txt:
- 4:20 PM Changeset in webkit [234117] by
-
- 2 edits in trunk/Source/WebCore
[macOS] Ensure that WebGL contexts are always set to an accelerated virtual screen
https://bugs.webkit.org/show_bug.cgi?id=187923
Patch by Justin Fan <Justin Fan> on 2018-07-23
Reviewed by Dean Jackson.
On eGPU displays, it is possible that CGL does not match the preferred renderer.
In this case, and when the web process is blocked from accessing the window server,
3D contexts *may* default to the software renderer. Ensure that even if this occurs,
we set the context to use a hardware-accelerated renderer/virtual screen.
No new tests. Existing behavior covered by existing tests.
Requires multiple screens, at least one attached to an eGPU, to stress.
- platform/graphics/cocoa/GraphicsContext3DCocoa.mm:
(WebCore::identifyAndSetCurrentGPU):
- 4:07 PM Changeset in webkit [234116] by
-
- 7 edits in trunk/Source/WebCore
Convert some obvious never-null pointers to references in the editing code
https://bugs.webkit.org/show_bug.cgi?id=187914
Patch by Sam Weinig <sam@webkit.org> on 2018-07-23
Reviewed by Dean Jackson.
Fixup trivial cases of never-null pointers that really should be references.
- editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::shouldApplyInlineStyleToRun):
(WebCore::ApplyStyleCommand::removeInlineStyleFromElement):
(WebCore::ApplyStyleCommand::removeImplicitlyStyledElement):
(WebCore::ApplyStyleCommand::removeCSSStyle):
(WebCore::ApplyStyleCommand::applyInlineStyleToPushDown):
(WebCore::ApplyStyleCommand::applyInlineStyleChange):
- editing/EditingStyle.cpp:
(WebCore::EditingStyle::overrideWithStyle):
(WebCore::EditingStyle::conflictsWithInlineStyleOfElement const):
(WebCore::EditingStyle::conflictsWithImplicitStyleOfElement const):
(WebCore::EditingStyle::conflictsWithImplicitStyleOfAttributes const):
(WebCore::EditingStyle::extractConflictingImplicitStyleOfAttributes const):
(WebCore::EditingStyle::styleIsPresentInComputedStyleOfNode const):
(WebCore::EditingStyle::elementIsStyledSpanOrHTMLEquivalent):
(WebCore::EditingStyle::mergeInlineStyleOfElement):
(WebCore::EditingStyle::wrappingStyleForSerialization):
(WebCore::EditingStyle::legacyFontSize const):
(WebCore::StyleChange::StyleChange):
(WebCore::StyleChange::extractTextStyles):
(WebCore::legacyFontSizeFromCSSValue):
- editing/EditingStyle.h:
(WebCore::EditingStyle::conflictsWithInlineStyleOfElement const):
- editing/Editor.cpp:
(WebCore::Editor::selectionStartCSSPropertyValue):
- editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::isInlineNodeWithStyle):
- editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendElement):
(WebCore::StyledMarkupAccumulator::serializeNodes):
- 4:00 PM Changeset in webkit [234115] by
-
- 2 edits in trunk/Tools
DRT relies on [webView display] to call -viewWillDraw on the WebHTMLView
https://bugs.webkit.org/show_bug.cgi?id=187924
<rdar://problem/41745884>
Reviewed by Simon Fraser.
WebKit relies on -viewWillDraw getting called on WebHTMLView, even though that view has not been marked as needing display.
- DumpRenderTree/mac/PixelDumpSupportMac.mm:
(createBitmapContextFromWebView):
- 3:53 PM Changeset in webkit [234114] by
-
- 1 copy in tags/Safari-606.1.29
Tag Safari-606.1.29.
- 3:16 PM Changeset in webkit [234113] by
-
- 2 edits in trunk/Source/WebCore
WebCore::primaryScreenDisplayID() always return 0
https://bugs.webkit.org/show_bug.cgi?id=187922
<rdar://problem/42286933>
Reviewed by Geoffrey Garen.
This function should return a valid display ID.
No new tests. Testing this requires a dual monitor setup.
- platform/mac/PlatformScreenMac.mm:
(WebCore::primaryScreenDisplayID):
- 2:24 PM Changeset in webkit [234112] by
-
- 4 edits2 adds in trunk
AX: Press tab to highlight items on a webpage is not working with voiceover enabled
https://bugs.webkit.org/show_bug.cgi?id=187824
Reviewed by Zalan Bujtas.
Source/WebCore:
We are deferring posting focused element change notification when the document needs a
style recalculation. However, we only perform the cache update after a layout is completed.
Added a timer to perform the cache update in the next runloop when non-layout type of mutation
happens.
Test: accessibility/mac/tab-focus-post-notification.html
- accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::~AXObjectCache):
(WebCore::AXObjectCache::deferFocusedUIElementChangeIfNeeded):
(WebCore::AXObjectCache::performCacheUpdateTimerFired):
- accessibility/AXObjectCache.h:
(WebCore::AXObjectCache::AXObjectCache):
(WebCore::AXObjectCache::performCacheUpdateTimerFired):
LayoutTests:
- accessibility/mac/tab-focus-post-notification-expected.txt: Added.
- accessibility/mac/tab-focus-post-notification.html: Added.
- 1:59 PM Changeset in webkit [234111] by
-
- 12 edits1 add in trunk
WebResourceLoadStatisticsStore fails to unregister itself as a MessageReceiver in its destructor
https://bugs.webkit.org/show_bug.cgi?id=187910
<rdar://problem/42356526>
Reviewed by Brent Fulgham.
Source/WebCore:
Add internals API that causes the ResourceLoadObserver to notify its observer, and avoid waiting
for the 5 second delay.
- testing/Internals.cpp:
(WebCore::Internals::notifyResourceLoadObserver):
- testing/Internals.h:
- testing/Internals.idl:
Source/WebKit:
The WebResourceLoadStatisticsStore was only removing itself as a MessageReceiver from the WebProcessProxy
and that WebProcessProxy's connection was getting closed. However, it is possible for the
WebResourceLoadStatisticsStore to get destroyed before this happens. This would lead to crashes such as
the one in <rdar://problem/42356526>.
To address the issue, we let the WebsiteDataStore take care of registering / unregistering the
WebResourceLoadStatisticsStore as a MessageReceiver with the WebProcessProxy. This is more reliable since
the WebsiteDataStore is the one that subclasses WebProcessLifetimeObserver. Make sure the
WebResourceLoadStatisticsStore is removed as a MessageReceiver whenever the WebsiteDataStore is destroyed
or WebsiteDataStore::m_resourceLoadStatistics gets cleared.
- UIProcess/WebResourceLoadStatisticsStore.cpp:
- UIProcess/WebResourceLoadStatisticsStore.h:
Drop logic to add / remove the WebResourceLoadStatisticsStore as a receiver now that the
WebsiteDataStore takes care of it.
- UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::~WebsiteDataStore):
Make sure the WebResourceLoadStatisticsStore gets unregistered as a MessageReceiver from all associated
WebProcessProxy objects when the WebsiteDataStore gets destroyed.
(WebKit::WebsiteDataStore::webProcessWillOpenConnection):
(WebKit::WebsiteDataStore::webProcessDidCloseConnection):
Register / Unregister the WebResourceLoadStatisticsStore as a MessageReceiver with the WebProcessProxy.
(WebKit::WebsiteDataStore::setResourceLoadStatisticsEnabled):
Make sure we unregister the WebResourceLoadStatisticsStore as a MessageReceiver with all associated
WebProcessProxy objects before we clear m_resourceLoadStatistics as this will causes the
WebResourceLoadStatisticsStore to get destroyed.
(WebKit::WebsiteDataStore::unregisterWebResourceLoadStatisticsStoreAsMessageReceiver):
(WebKit::WebsiteDataStore::registerWebResourceLoadStatisticsStoreAsMessageReceiver):
Add utility functions to register / unregister WebResourceLoadStatisticsStore as a MessageReceiver with
all associated WebProcessProxy objects.
(WebKit::WebsiteDataStore::enableResourceLoadStatisticsAndSetTestingCallback):
Register the new WebResourceLoadStatisticsStore as a MessageReceiver with all associated WebProcessProxy
objects in case setResourceLoadStatisticsEnabled(true) gets called *after* we've already started
WebProcesses.
- UIProcess/WebsiteData/WebsiteDataStore.h:
Tools:
Add API test coverage.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/ResourceLoadStatistics.mm:
(-[DisableITPDuringNavigationDelegate webView:didCommitNavigation:]):
(-[DisableITPDuringNavigationDelegate webView:didFinishNavigation:]):
(TEST):
- TestWebKitAPI/Tests/WebKitCocoa/notify-resourceLoadObserver.html: Added.
- 1:30 PM Changeset in webkit [234110] by
-
- 6 edits in trunk/Source/WebCore
[LCF][IFC] Add support for hyphenation.
https://bugs.webkit.org/show_bug.cgi?id=187913
Reviewed by Antti Koivisto.
Move the hyphenation logic over from SimpleLineLayout::TextFragmentIterator.
- layout/inlineformatting/textlayout/Runs.h:
(WebCore::Layout::TextRun::hasHyphen const):
(WebCore::Layout::LayoutRun::setHasHyphen):
(WebCore::Layout::LayoutRun::hasHyphen const):
(WebCore::Layout::LayoutRun::LayoutRun):
(WebCore::Layout::TextRun::createNonWhitespaceRunWithHyphen):
(WebCore::Layout::TextRun::TextRun):
- layout/inlineformatting/textlayout/TextContentProvider.cpp:
(WebCore::Layout::TextContentProvider::findTextItemSlow const):
(WebCore::Layout::TextContentProvider::width const):
(WebCore::Layout::TextContentProvider::hyphenPositionBefore const):
- layout/inlineformatting/textlayout/TextContentProvider.h:
- layout/inlineformatting/textlayout/simple/SimpleLineBreaker.cpp:
(WebCore::Layout::SimpleLineBreaker::Line::setTextAlign):
(WebCore::Layout::SimpleLineBreaker::Line::justifyRuns):
(WebCore::Layout::SimpleLineBreaker::Line::adjustRunsForTextAlign):
(WebCore::Layout::SimpleLineBreaker::Line::collectExpansionOpportunities):
(WebCore::Layout::SimpleLineBreaker::Line::closeLastRun):
(WebCore::Layout::SimpleLineBreaker::Line::append):
(WebCore::Layout::SimpleLineBreaker::Line::reset):
(WebCore::Layout::SimpleLineBreaker::Style::Style):
(WebCore::Layout::SimpleLineBreaker::handleLineEnd):
(WebCore::Layout::SimpleLineBreaker::createRunsForLine):
(WebCore::Layout::SimpleLineBreaker::hyphenPositionBefore const):
(WebCore::Layout::SimpleLineBreaker::adjustSplitPositionWithHyphenation const):
(WebCore::Layout::SimpleLineBreaker::split const):
- layout/inlineformatting/textlayout/simple/SimpleLineBreaker.h:
- 1:23 PM Changeset in webkit [234109] by
-
- 9 edits2 adds in trunk
[Web Animations] Querying the current time of a finished CSSAnimation after removing its target leads to a crash
https://bugs.webkit.org/show_bug.cgi?id=187906
Reviewed by Dean Jackson.
Source/WebCore:
Test: webanimations/accessing-current-time-after-finished-css-animation-target-removal.html
Because we carelessly look at a CSSAnimation's effect's timing in DeclarativeAnimation::bindingsCurrentTime
without checking that the effect is non-null, we can crash in the case where the animation is finished and
its target element has been removed, which caused the effect to be set to null.
We do not actually fix the lack of a null check, which will be the scope of a different patch, but instead
ensure that we do _not_ set the animation's effect to null when its target is removed, which used to be
performed via a call to WebAnimation::remove(). Instead, we introduce AnimationTimeline::elementWasRemoved()
which notifies the timeline of an element being removed such that we may stop referencing any animation
targeting this element from the various data structures holding strong references to the animation in question,
and we then cancel the animation silently, which is a new option that ensures promises aren't resolved or
rejected as a result.
Finally, the WebAnimation and AnimationEffectReadOnly classes established a ref-cycle as WebAnimation has
RefPtr<AnimationEffectReadOnly> m_effectand AnimationEffectReadOnly hasRefPtr<WebAnimation> m_animation.
While it is correct that WebAnimation owns its effect, which is established by the DOM API, the
reverse is not correct since we only hold the reverse internally for the benefit of our implementation.
As such, we change AnimationEffectReadOnly's m_animation to be a WeakPtr<WebAnimation>. This means not
calling WebAnimation::remove() and simply removing the animation from the animation maps on the timeline
is sufficient to guarantee that the document timeline will not leak (and with it the document).
- animation/AnimationEffectReadOnly.h:
(WebCore::AnimationEffectReadOnly::setAnimation):
- animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::elementWasRemoved):
- animation/AnimationTimeline.h:
- animation/WebAnimation.cpp:
(WebCore::WebAnimation::cancel):
(WebCore::WebAnimation::resetPendingTasks):
- animation/WebAnimation.h:
- dom/Element.cpp:
(WebCore::Element::removedFromAncestor):
- rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::tearDownRenderers):
LayoutTests:
Add a new test that checks the behavior of a CSSAnimation instance after its completion and removal of its target.
- webanimations/accessing-current-time-after-finished-css-animation-target-removal-expected.txt: Added.
- webanimations/accessing-current-time-after-finished-css-animation-target-removal.html: Added.
- 1:17 PM Changeset in webkit [234108] by
-
- 2 edits in trunk/Source/WebKit
Resource Load Statistics: Add logging of Storage Access API use in experimental debug mode
https://bugs.webkit.org/show_bug.cgi?id=187918
<rdar://problem/42509062>
Reviewed by Jiewen Tan.
Tested manually by looking at log output.
- UIProcess/ResourceLoadStatisticsMemoryStore.cpp:
(WebKit::ResourceLoadStatisticsMemoryStore::removeDataRecords):
This is just a clean-up change.
(WebKit::ResourceLoadStatisticsMemoryStore::requestStorageAccess):
(WebKit::ResourceLoadStatisticsMemoryStore::requestStorageAccessUnderOpener):
Both these now log proper info in debug mode.
- 12:33 PM Changeset in webkit [234107] by
-
- 4 edits in trunk/LayoutTests
REGRESSION(PSON?): [ WK2 ] http/tests/workers/service/client-*-page-cache.html LayoutTests are flaky
https://bugs.webkit.org/show_bug.cgi?id=183705
<rdar://problem/42440606>
Unreviewed, attempting a better fix for http/tests/workers/service/serviceworkerclients-matchAll.https.html.
If it fixes the flakiness I'll do the same for the 2 page cache tests.
- http/tests/workers/service/serviceworkerclients-matchAll-worker.js:
(waitFor):
(matchAllPromise2):
(async.doTestAfterMessage):
(matchAllPromise1): Deleted.
(then): Deleted.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 12:32 PM Changeset in webkit [234106] by
-
- 3 edits in trunk/Source/JavaScriptCore
Add some asserts to help diagnose a crash.
https://bugs.webkit.org/show_bug.cgi?id=187915
<rdar://problem/42508166>
Reviewed by Michael Saboff.
Add some asserts to verify that an CodeBlock alternative should always have a
non-null jitCode. Also change a RELEASE_ASSERT_NOT_REACHED() in
CodeBlock::setOptimizationThresholdBasedOnCompilationResult() to a RELEASE_ASSERT()
so that we'll retain the state of the variables that failed the assertion (again
to help with diagnosis).
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::setAlternative):
(JSC::CodeBlock::setOptimizationThresholdBasedOnCompilationResult):
- dfg/DFGPlan.cpp:
(JSC::DFG::Plan::Plan):
- 12:13 PM Changeset in webkit [234105] by
-
- 14 edits4 adds in trunk/Source
[iOS] Add support for input[type=color]
https://bugs.webkit.org/show_bug.cgi?id=187871
Patch by Aditya Keerthi <Aditya Keerthi> on 2018-07-23
Reviewed by Tim Horton.
Source/WebCore:
- css/html.css: Remove unwanted styling for color inputs with a list attribute.
- html/ColorInputType.cpp: Make the element focusable.
(WebCore::ColorInputType::isMouseFocusable const):
(WebCore::ColorInputType::isKeyboardFocusable const):
- html/ColorInputType.h:
- html/HTMLInputElement.h: Expose isColorControl() to WebKit.
- page/Chrome.cpp:
(WebCore::Chrome::createColorChooser):
Source/WebKit:
Created WKFormColorControl to display a color picker once a color input gains
focus. The control is presented as an inputView on iPhone and as a popover on
iPad. The picker itself consists of two color matrices. The first is a set of 12
default colors, displayed on the top row of the picker. In a subsequent patch,
this top row will be made customizable through the use of the datalist element.
The second matrix is a grid of 120 colors, provided by the system. Colors can be
selected from either matrix by tapping or with a pan gesture.
WKColorMatrixView represents a single color matrix and is comprised of
WKColorButtons that represent each color in the matrix.
- Shared/AssistedNodeInformation.h:
- UIProcess/API/Cocoa/_WKFocusedElementInfo.h:
- UIProcess/ios/PageClientImplIOS.h:
- UIProcess/ios/PageClientImplIOS.mm:
(WebKit::PageClientImpl::createColorPicker):
- UIProcess/ios/WKContentViewInteraction.mm:
(-[WKFocusedElementInfo initWithAssistedNodeInformation:isUserInitiated:userObject:]):
(-[WKContentView _requiresKeyboardWhenFirstResponder]):
(-[WKContentView inputView]):
(-[WKContentView requiresAccessoryView]):
(isAssistableInputType):
(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
(-[WKContentView actionNameForFocusedFormControlView:]):
- UIProcess/ios/forms/WKFormColorControl.h: Added.
- UIProcess/ios/forms/WKFormColorControl.mm: Added.
(-[WKColorPopover initWithView:]):
(-[WKColorPopover controlView]):
(-[WKColorPopover controlBeginEditing]):
(-[WKColorPopover controlEndEditing]):
(-[WKFormColorControl initWithView:]):
(-[WKFormColorControl assistantView]):
(-[WKFormColorControl beginEditing]):
(-[WKFormColorControl endEditing]):
- UIProcess/ios/forms/WKFormColorPicker.h: Added.
- UIProcess/ios/forms/WKFormColorPicker.mm: Added.
(+[WKColorButton colorButtonWithColor:]):
(-[WKColorMatrixView initWithFrame:]):
(-[WKColorMatrixView initWithFrame:colorMatrix:]):
(-[WKColorMatrixView layoutSubviews]):
(-[WKColorMatrixView colorButtonTapped:]):
(+[WKColorPicker defaultTopColorMatrix]):
(-[WKColorPicker initWithView:]):
(-[WKColorPicker setControlValueFromUIColor:]):
(-[WKColorPicker controlView]):
(-[WKColorPicker controlBeginEditing]):
(-[WKColorPicker controlEndEditing]):
(-[WKColorPicker colorMatrixView:didTapColorButton:]):
(-[WKColorPicker didPanColors:]):
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::isAssistableElement):
(WebKit::WebPage::getAssistedNodeInformation):
- 10:56 AM Changeset in webkit [234104] by
-
- 2 edits in trunk/LayoutTests
Layout test webanimations/empty-keyframes-crash.html is failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=187912
Unreviewed test gardening.
- platform/win/TestExpectations:
- 10:52 AM Changeset in webkit [234103] by
-
- 2 edits in trunk/Source/WebKit
[WinCairo] Fix detection of held modifier keys for key events
https://bugs.webkit.org/show_bug.cgi?id=187862
Reviewed by Fujii Hironori.
- Shared/win/WebEventFactory.cpp:
(WebKit::IsKeyInDownState): Use requested modifier not VK_MENU
- 10:49 AM Changeset in webkit [234102] by
-
- 2 edits in trunk/LayoutTests
Skip crypto tests on Windows.
https://bugs.webkit.org/show_bug.cgi?id=165090
Unreviewed test gardening.
- platform/win/TestExpectations:
- 10:40 AM Changeset in webkit [234101] by
-
- 2 edits in trunk/LayoutTests
Mark http/tests/security/bypassing-cors-checks-for-extension-urls.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=187658
Unreviewed test gardening.
- platform/mac-wk2/TestExpectations:
- 10:40 AM Changeset in webkit [234100] by
-
- 3 edits in trunk/LayoutTests
Mark three service worker clients tests as flaky.
https://bugs.webkit.org/show_bug.cgi?id=183705
Unreviewed test gardening.
- platform/ios-wk2/TestExpectations:
- platform/mac-wk2/TestExpectations:
- 10:02 AM Changeset in webkit [234099] by
-
- 3 edits in trunk/Tools
test-webkitpy should take configuration command line options
https://bugs.webkit.org/show_bug.cgi?id=187872
Reviewed by David Kilzer.
Add --debug and --release optional command line options and teach the test bots to invoke test-webkitpy
with the appropriate configuration. At the moment these options are only meaningful on Mac since they
effect the configuration lldbWebKitTester is built with and we only build lldbWebKitTester on Mac.
- BuildSlaveSupport/build.webkit.org-config/steps.py:
(RunPythonTests): Pass the configuration to test-webkitpy. On Mac this will effect
how lldbWebKitTester is built. All other ports do not make use of the specified configuration.
- Scripts/webkitpy/test/main.py:
(_build_lldb_webkit_tester): Modified to take the configuration to build lldbWebKitTester. If
the specified configuration is None then we fall back to using the default configuration (as set
by script set-webkit-configuration).
(Tester._parse_args): Add command line options --debug and --release to build lldbWebKitTester
with a Debug configuration and a Release configuration, respectively
(Tester._run_tests): Pass the configuration to build lldbWebKitTester that we parsed from
the command line options. It may be None if neither --debug nor --release were passed.
- 9:53 AM Changeset in webkit [234098] by
-
- 6 edits2 adds in trunk
fullscreen env() variables should have initial values
https://bugs.webkit.org/show_bug.cgi?id=187897
<rdar://problem/42485682>
Reviewed by Sam Weinig.
Source/WebCore:
The env() values for fullscreen properties need to be
initialized, rather than wait for values to be set from WebKit.
Without this, feature detection doesn't work, and properties
won't parse correctly.
Test: fullscreen/fullscreen-env-initial.html
- dom/ConstantPropertyMap.cpp:
(WebCore::ConstantPropertyMap::buildValues): Initialize the fullscreen values.
(WebCore::ConstantPropertyMap::updateConstantsForFullscreen): Renamed function, because it
also updates the duration value.
(WebCore::ConstantPropertyMap::didChangeFullscreenInsets): Call new name.
(WebCore::ConstantPropertyMap::updateConstantsForFullscreenInsets): Deleted.
- dom/ConstantPropertyMap.h:
- page/Page.cpp:
(WebCore::Page::setFullscreenAutoHideDuration): Don't change the value if it doesn't need it.
- page/Page.h: Add accessor for fullscreenAutoHideDuration. Also add a member variable.
(WebCore::Page::fullscreenAutoHideDuration const):
LayoutTests:
- fullscreen/fullscreen-env-initial-expected.html: Added.
- fullscreen/fullscreen-env-initial.html: Added.
- 9:13 AM Changeset in webkit [234097] by
-
- 6 edits in trunk/Source/JavaScriptCore
Unreviewed, fix no-JIT build.
- bytecode/CallLinkStatus.cpp:
(JSC::CallLinkStatus::computeFor):
- bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finalizeUnconditionally):
- bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeFor):
(JSC::GetByIdStatus::computeForStubInfoWithoutExitSiteFeedback):
- bytecode/InByIdStatus.cpp:
- bytecode/PutByIdStatus.cpp:
(JSC::PutByIdStatus::computeForStubInfo):
- 7:12 AM Changeset in webkit [234096] by
-
- 4 edits in trunk/Tools
Unreviewed, rolling out r233030.
https://bugs.webkit.org/show_bug.cgi?id=187904
Broke tarball builds (Requested by mcatanzaro on #webkit).
Reverted changeset:
"run-gtk-tests (glib/common.py) cannot determine build
directory when webKitBranchBuild=true"
https://bugs.webkit.org/show_bug.cgi?id=185643
https://trac.webkit.org/changeset/233030
- 12:09 AM Changeset in webkit [234095] by
-
- 3 edits2 adds in branches/safari-606-branch
Cherry-pick r234075. rdar://problem/42451525
DFG AbstractInterpreter: CheckArray filters array modes for DirectArguments/ScopedArguments using only NonArray
https://bugs.webkit.org/show_bug.cgi?id=187827
rdar://problem/42146858
Reviewed by Saam Barati.
JSTests:
New regression tests.
- stress/direct-arguments-check-array.js: Added. (setup.f2): (setup): (forOfArray): (forOfArgs): (callEveryOnArgs):
- stress/scoped-arguments-check-array.js: Added. (setup.foo): (setup.f2): (setup): (forOfArray): (forOfArgs): (callEveryOnArgs):
Source/JavaScriptCore:
When filtering array modes for DirectArguments or ScopedArguments, we need to allow for the possibility
that they can either be NonArray or NonArrayWithArrayStorage (aka ArrayStorageShape).
We can't end up with other shapes, Int32, Double, etc because GenericArguments sets
InterceptsGetOwnPropertySlotByIndexEvenWhenLengthIsNotZero which will cause us to go down a
putByIndex() path that doesn't change the shape.
- dfg/DFGArrayMode.h: (JSC::DFG::ArrayMode::arrayModesThatPassFiltering const):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234075 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:09 AM Changeset in webkit [234094] by
-
- 8 edits3 adds in branches/safari-606-branch
Cherry-pick r234073. rdar://problem/42451644
Remove completed animations from GraphicsLayer, thus avoiding excessive backing store allocation
https://bugs.webkit.org/show_bug.cgi?id=187844
rdar://problem/40387294
Reviewed by Dean Jackson.
Source/WebCore:
A keyframe animation which animates 3D transforms, and is fill-forwards, currently
leaves the GraphicsLayer in a state where it has a "running" animation. However, the
logic that computes animation extent in RenderLayerBacking::updateGeometry() only does
so for running or paused animations. GraphicsLayer then thinks that it has an active
transform animation with unknown extent, and refuses to detach its backing store.
This triggers excessive layer creation on some sites (e.g. https://www.kqed.org).
Fix by always removing animations from the GraphicsLayer when they finish, whether
or not they fill forwards. This is done by having KeyframeAnimation::onAnimationEnd()
always call endAnimation().
This change only fixes the non-Web Animation code path. webkit.org/b/187845 exists
to fix the other code path.
Also improve some logging that would have revealed this problem sooner.
Test: compositing/backing/backing-store-attachment-fill-forwards-animation.html
- page/animation/AnimationBase.h: (WebCore::AnimationBase::endAnimation):
- page/animation/ImplicitAnimation.cpp: (WebCore::ImplicitAnimation::endAnimation):
- page/animation/ImplicitAnimation.h:
- page/animation/KeyframeAnimation.cpp: (WebCore::KeyframeAnimation::endAnimation): (WebCore::KeyframeAnimation::onAnimationEnd):
- page/animation/KeyframeAnimation.h:
- platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::addAnimation): (WebCore::GraphicsLayerCA::updateCoverage):
LayoutTests:
- compositing/backing/backing-store-attachment-fill-forwards-animation-expected.txt: Added.
- compositing/backing/backing-store-attachment-fill-forwards-animation.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@234073 268f45cc-cd09-0410-ab3c-d52691b4dbfc
- 12:07 AM Changeset in webkit [234093] by
-
- 7 edits in branches/safari-606-branch/Source
Versioning.
Jul 22, 2018:
- 5:40 PM Changeset in webkit [234092] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Dark Mode: remove odd-looking top border
https://bugs.webkit.org/show_bug.cgi?id=187885
Reviewed by Matt Baker.
This border doesn't exist in the light mode, and it shouldn't be in the dark mode either.
- UserInterface/Views/DarkMode.css:
(@media (prefers-dark-interface)):
(body .toolbar):
- 12:48 PM Changeset in webkit [234091] by
-
- 4 edits in trunk/Source/WebCore
[LFC][IFC] Add center/right/justify line alignment support.
https://bugs.webkit.org/show_bug.cgi?id=187890
Reviewed by Antti Koivisto.
Move over some more code from simple line layout.
(though text-align: justify is more preformant as now expansion opportunities are added as we process the text runs
-as opposed to iterting through the runs again when we reach the end of the line.)
- layout/inlineformatting/textlayout/Runs.h:
(WebCore::Layout::LayoutRun::setLeft):
(WebCore::Layout::LayoutRun::setExpansion):
- layout/inlineformatting/textlayout/simple/SimpleLineBreaker.cpp:
(WebCore::Layout::SimpleLineBreaker::Line::Line):
(WebCore::Layout::SimpleLineBreaker::Line::setTextAlign):
(WebCore::Layout::SimpleLineBreaker::Line::adjustedLeftForTextAlign const):
(WebCore::Layout::SimpleLineBreaker::Line::justifyRuns):
(WebCore::Layout::SimpleLineBreaker::Line::adjustRunsForTextAlign):
(WebCore::Layout::expansionOpportunity):
(WebCore::Layout::expansionBehavior):
(WebCore::Layout::SimpleLineBreaker::Line::collectExpansionOpportunities):
(WebCore::Layout::SimpleLineBreaker::Line::closeLastRun):
(WebCore::Layout::SimpleLineBreaker::Line::append):
(WebCore::Layout::SimpleLineBreaker::Line::collapseTrailingWhitespace):
(WebCore::Layout::SimpleLineBreaker::Line::reset):
(WebCore::Layout::SimpleLineBreaker::Style::Style):
(WebCore::Layout::SimpleLineBreaker::handleLineEnd):
(WebCore::Layout::SimpleLineBreaker::handleLineStart):
(WebCore::Layout::isTextAlignRight):
(WebCore::Layout::SimpleLineBreaker::createRunsForLine):
- layout/inlineformatting/textlayout/simple/SimpleLineBreaker.h:
(WebCore::Layout::SimpleLineBreaker::Line::setAvailableWidth):
(WebCore::Layout::SimpleLineBreaker::Line::setCollapseWhitespace):
- 12:24 PM Changeset in webkit [234090] by
-
- 4 edits2 adds in trunk
[JSC] GetByIdVariant and InByIdVariant do not need slot base if they are not "hit" variants
https://bugs.webkit.org/show_bug.cgi?id=187891
Reviewed by Saam Barati.
JSTests:
- stress/in-miss-variant-merge.js: Added.
(shouldBe):
(test):
- stress/miss-variant-merge.js: Added.
(shouldBe):
(test):
Source/JavaScriptCore:
When merging GetByIdVariant and InByIdVariant, we accidentally make merging failed if
two variants are mergeable but they have "Miss" status. We make merging failed if
the merged OPCSet says hasOneSlotBaseCondition() is false. But it is only reasonable
if the variant has "Hit" status. This bug is revealed when we introduce CreateThis in FTL,
which patch have more chances to merge variants.
This patch fixes this issue by checking
!isPropertyUnset()/isHit(). PutByIdVariant
is not related since it does not use this check in Transition case.
- bytecode/GetByIdVariant.cpp:
(JSC::GetByIdVariant::attemptToMerge):
- bytecode/InByIdVariant.cpp:
(JSC::InByIdVariant::attemptToMerge):
- 9:54 AM Changeset in webkit [234089] by
-
- 8 edits3 adds in trunk
[DFG] Fold GetByVal if the indexed value is non configurable and non writable
https://bugs.webkit.org/show_bug.cgi?id=186462
Reviewed by Saam Barati.
JSTests:
- stress/folding-get-by-val-with-read-only-dont-delete-object.js: Added.
(shouldBe):
(test1):
(test2):
(test3):
(test4):
(test5):
- stress/folding-get-by-val-with-read-only-dont-delete-runtime-array.js: Added.
(shouldBe):
(test1):
(test2):
(test5):
- stress/folding-get-by-val-with-read-only-dont-delete.js: Added.
(shouldBe):
(test1):
(test2):
(test3):
(test4):
(test5):
Source/JavaScriptCore:
Non-special DontDelete | ReadOnly properties mean that it won't be changed. If DFG AI can retrieve this
property, AI can fold it into a constant. This type of property can be seen when we use ES6 tagged templates.
Tagged templates' callsite includes indexed properties whose attributes are DontDelete | ReadOnly.
This patch attempts to fold such properties into constant in DFG AI. The challenge is that DFG AI runs
concurrently with the mutator thread. In this patch, we insert WTF::storeStoreFence between value setting
and attributes setting. The attributes must be set after the corresponding value is set. If the loaded
attributes (with WTF::loadLoadFence) include DontDelete | ReadOnly, it means the given value won't be
changed and we can safely use it. We arrange our existing code to use this protocol.
Since GetByVal folding requires the correct Structure & Butterfly pairs, it is only enabled in x86 architecture
since it is TSO. So, our WTF::storeStoreFence in SparseArrayValueMap is also emitted only in x86.
This patch improves SixSpeed/template_string_tag.es6.
baseline patched
template_string_tag.es6 237.0301+-4.8374 9.8779+-0.3628 definitely 23.9960x faster
- dfg/DFGAbstractInterpreterInlines.h:
(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):
- runtime/JSArray.cpp:
(JSC::JSArray::setLengthWithArrayStorage):
- runtime/JSObject.cpp:
(JSC::JSObject::enterDictionaryIndexingModeWhenArrayStorageAlreadyExists):
(JSC::JSObject::deletePropertyByIndex):
(JSC::JSObject::getOwnPropertyNames):
(JSC::putIndexedDescriptor):
(JSC::JSObject::defineOwnIndexedProperty):
(JSC::JSObject::attemptToInterceptPutByIndexOnHoleForPrototype):
(JSC::JSObject::putIndexedDescriptor): Deleted.
- runtime/JSObject.h:
- runtime/SparseArrayValueMap.cpp:
(JSC::SparseArrayValueMap::SparseArrayValueMap):
(JSC::SparseArrayValueMap::add):
(JSC::SparseArrayValueMap::putDirect):
(JSC::SparseArrayValueMap::getConcurrently):
(JSC::SparseArrayEntry::get const):
(JSC::SparseArrayEntry::getConcurrently const):
(JSC::SparseArrayEntry::put):
(JSC::SparseArrayEntry::getNonSparseMode const):
(JSC::SparseArrayValueMap::visitChildren):
(JSC::SparseArrayValueMap::~SparseArrayValueMap): Deleted.
- runtime/SparseArrayValueMap.h:
(JSC::SparseArrayEntry::SparseArrayEntry):
(JSC::SparseArrayEntry::attributes const):
(JSC::SparseArrayEntry::forceSet):
(JSC::SparseArrayEntry::asValue):
