Context Navigation

← Previous Period
Next Period →

Timeline

Nov 3, 2018:

4:24 PM Changeset in webkit [237777] by Devin Rousso

19 edits in trunk

Web Inspector: Canvas: capture changes to <canvas> that would affect the recorded context
https://bugs.webkit.org/show_bug.cgi?id=190854

Reviewed by Matt Baker.

Source/WebCore:

Updated existing tests: inspector/canvas/recording-2d.html

inspector/canvas/recording-bitmaprenderer.html
inspector/canvas/recording-webgl.html

html/HTMLCanvasElement.idl:

Apply CallTracingCallback=recordCanvasAction to the width and height attributes so
that they are recorded through the same path as CanvasRenderingContext.

html/CanvasBase.h:
html/CanvasBase.cpp:

(WebCore::CanvasBase::callTracingActive const): Added.

bindings/js/CallTracer.h:
bindings/js/CallTracer.cpp:

(WebCore::CallTracer::recordCanvasAction):

Source/WebInspectorUI:

UserInterface/Models/RecordingAction.js:

(WI.RecordingAction):
(WI.RecordingAction.isFunctionForType):
(WI.RecordingAction.constantNameForParameter):
(WI.RecordingAction.prototype.get contextReplacer): Added.
(WI.RecordingAction.prototype.async.swizzle):
(WI.RecordingAction.prototype.apply):
Create a constant list of actions for each recording type that need to replace the context
with a different value before being applied (e.g. width should be applied to the
context's canvas instead of directly to the context).

UserInterface/Views/RecordingContentView.js:

(WI.RecordingContentView.prototype._generateContentCanvas2D.actionModifiesPath): Added.
(WI.RecordingContentView.prototype._generateContentCanvas2D):
(WI.RecordingContentView._actionModifiesPath): Deleted.
Generate the path context after the actions are applied to the preview context so that the
final width/height are known and can be used. This is needed because changing the
width/height causes the content to be erased.

UserInterface/Views/RecordingActionTreeElement.js:

(WI.RecordingActionTreeElement._generateDOM):
(WI.RecordingActionTreeElement._classNameForAction):

UserInterface/Views/RecordingActionTreeElement.css:

(.tree-outline:focus .item.action.selected:not(.invalid, .initial-state, .has-context-replacer) > .icon): Added.
(.item.action > .titles .context-replacer::after): Added.
(.item.action.has-context-replacer > .icon): Added.
(@media (prefers-dark-interface) .item.action:not(.invalid, .initial-state, .has-context-replacer) > .icon): Added.
(.tree-outline:focus .item.action.selected:not(.initial-state, .invalid) > .icon): Deleted.
(@media (prefers-dark-interface) .item.action:not(.initial-state) > .icon): Deleted.
(@media (prefers-dark-interface) .tree-outline:not(.hide-disclosure-buttons) .item.action:not(.initial-state, .parent) > .icon): Deleted.
Add the context replacer text to the beginning of the action's name if it exists.

UserInterface/Views/CanvasContentView.js:

(WI.CanvasContentView.prototype._refreshPixelSize):
(WI.CanvasContentView.prototype._updatePixelSize): Deleted.
Update preview image when the canvas' size changes.

LayoutTests:

inspector/canvas/recording-2d-expected.txt:
inspector/canvas/recording-2d.html:
inspector/canvas/recording-bitmaprenderer-expected.txt:
inspector/canvas/recording-bitmaprenderer.html:
inspector/canvas/recording-webgl-expected.txt:
inspector/canvas/recording-webgl.html:

11:45 AM Changeset in webkit [237776] by aestes@apple.com

5 edits in trunk

[Payment Request] PaymentResponse.retry()'s errorFields should be optional
https://bugs.webkit.org/show_bug.cgi?id=191212

Reviewed by Youenn Fablet.

Source/WebCore:

Per WebIDL, the errorFields argument to PaymentResponse.retry() should be optional. See
<https://github.com/w3c/payment-request/issues/804> for details.

Added test case to http/tests/paymentrequest/payment-response-retry-method.https.html.

Modules/paymentrequest/PaymentResponse.idl:

LayoutTests:

http/tests/paymentrequest/payment-response-retry-method.https-expected.txt:
http/tests/paymentrequest/payment-response-retry-method.https.html:

10:57 AM Changeset in webkit [237775] by Alan Bujtas

6 edits
2 adds in trunk

[LFC][BFC] Resolve percentage height values.
https://bugs.webkit.org/show_bug.cgi?id=191224

Reviewed by Antti Koivisto.

Source/WebCore:

10.5 Content height: the 'height' property
The percentage is calculated with respect to the height of the generated box's containing block.
If the height of the containing block is not specified explicitly (i.e., it depends on content height),
and this element is not absolutely positioned, the used height is calculated as if 'auto' was specified.

https://www.w3.org/TR/CSS22/visudet.html#propdef-height

Test: fast/block/basic/height-percentage-simple.html

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::isHeightAuto):
(WebCore::Layout::computedHeightValue):
(WebCore::Layout::contentHeightForFormattingContextRoot):
(WebCore::Layout::FormattingContext::Geometry::computedMaxHeight):
(WebCore::Layout::FormattingContext::Geometry::computedMinHeight):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):

Tools:

LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

fast/block/basic/height-percentage-simple-expected.txt: Added.
fast/block/basic/height-percentage-simple.html: Added.
platform/ios/TestExpectations:

8:22 AM Changeset in webkit [237774] by achristensen@apple.com

9 edits
2 adds in trunk

Mac production builds should sign the network process xpc service with entitlements
https://bugs.webkit.org/show_bug.cgi?id=191209
<rdar://problem/45377609>

Reviewed by Geoff Garen.

Source/WebKit:

Configurations/Network-OSX.entitlements: Copied from Configurations/Network-OSX-sandbox.entitlements.
Configurations/NetworkService.xcconfig:

Set CODE_SIGN_ENTITLEMENTS_COCOA_TOUCH_NO like we do for the web process,
except with the corresponoding network process entitlements file.

UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _networkProcessHasEntitlementForTesting:]):

UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::networkProcessHasEntitlementForTesting):

UIProcess/WebProcessPool.h:
WebKit.xcodeproj/project.pbxproj:

Add infrastructure to test that the network process actually has an entitlement.

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.

(TEST):

7:57 AM Changeset in webkit [237773] by youenn@apple.com

88 edits
2 copies
4 moves
43 adds
3 deletes in trunk/LayoutTests

Refresh WPT webrtc tests
https://bugs.webkit.org/show_bug.cgi?id=191133

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

web-platform-tests/webrtc/: Refreshed.
web-platform-tests/webrtc/w3c-import.log:

LayoutTests:

TestExpectations:

7:29 AM Changeset in webkit [237772] by Philippe Normand

2 edits in trunk/Source/WebKit

[WPE] Add the WebKitVersion.h header
https://bugs.webkit.org/show_bug.cgi?id=191015
<rdar://problem/45647211>

Reviewed by Michael Catanzaro.

PlatformWPE.cmake: Install the generated header as well.

7:04 AM Changeset in webkit [237771] by Michael Catanzaro

2 edits in trunk/WebDriverTests

Unreviewed, fix WebDriver expectations syntax after previous commit

TestExpectations.json:

6:30 AM Changeset in webkit [237770] by eric.carlson@apple.com

9 edits
3 adds in trunk

[MediaStream] enumerateDevices should not expose devices that are not available to getUserMedia
https://bugs.webkit.org/show_bug.cgi?id=191177
<rdar://problem/45747873>

Reviewed by Jer Noble.

Source/WebCore:

Test: http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute.html

Modules/mediastream/MediaDevicesRequest.cpp:

(WebCore::MediaDevicesRequest::start): Only expose devices that are available to gUM.

Modules/mediastream/UserMediaController.cpp:

(WebCore::isSecure): Moved from UserMediaRequest.cpp.
(WebCore::isAllowedToUse): Ditto.
(WebCore::UserMediaController::canCallGetUserMedia): Modified from UserMediaRequest.cpp.
(WebCore::UserMediaController::logGetUserMediaDenial): Log reason for denial.

Modules/mediastream/UserMediaController.h:

Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::start): Use UserMediaController::canCallGetUserMedia.
(WebCore::isSecure): Deleted.
(WebCore::isAllowedToUse): Deleted.
(WebCore::canCallGetUserMedia): Deleted.

LayoutTests:

http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute-expected.txt: Added.
http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute.html: Added.
http/tests/media/media-stream/resources/enumerate-devices-iframe.html: Added.
http/tests/ssl/media-stream/get-user-media-different-host-expected.txt: Rebased for updated logging.
http/tests/ssl/media-stream/get-user-media-nested-expected.txt: Ditto.

Nov 2, 2018:

11:25 PM Changeset in webkit [237769] by achristensen@apple.com

8 edits
1 delete in trunk

Unreviewed, rolling out r237761.

Makes most API tests timeout and WK2 tests crash

Reverted changeset:

"Mac production builds should sign the network process xpc
service with entitlements"
https://bugs.webkit.org/show_bug.cgi?id=191209
https://trac.webkit.org/changeset/237761

10:53 PM Changeset in webkit [237768] by Michael Catanzaro

2 edits in trunk/WebDriverTests

Unreviewed WebDriver expectations gardening

There are still a few more flaky tests, but this should improve things significantly.

TestExpectations.json:

10:27 PM Changeset in webkit [237767] by Michael Catanzaro

2 edits in trunk/Tools

Unreviewed API test gardening

TestWebKitAPI/glib/TestExpectations.json:

9:01 PM Changeset in webkit [237766] by Justin Michaud

30 edits
5 copies
3 moves
15 adds
2 deletes in trunk

Add new global object and preliminary Worklets support for CSS painting api
https://bugs.webkit.org/show_bug.cgi?id=190979

Reviewed by Chris Dumez.

Source/WebCore:

Test: fast/css-custom-paint/worklet.html

Add a new ScriptExecutionContext and global object to run worklets in. This is mostly copy+paste
from Workers, but without any of the threading. Worklet.addModule does not yet support loading scripts
or doing cross origin checking. There are quite a few parts of the ScriptExecutionContext api that are
left as ASSERT_NOT_REACHED().

CMakeLists.txt:
DerivedSources.make:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::scriptExecutionContext const):

bindings/js/JSPaintWorkletGlobalScopeCustom.cpp: Renamed from Source/WebCore/bindings/js/JSCSSPaintWorkletGlobalScopeCustom.cpp.

(WebCore::JSPaintWorkletGlobalScope::visitAdditionalChildren):
(WebCore::JSPaintWorkletGlobalScope::registerPaint):

bindings/js/JSWorkletGlobalScopeBase.cpp: Added.

(WebCore::JSWorkletGlobalScopeBase::JSWorkletGlobalScopeBase):
(WebCore::JSWorkletGlobalScopeBase::finishCreation):
(WebCore::JSWorkletGlobalScopeBase::clearDOMGuardedObjects):
(WebCore::JSWorkletGlobalScopeBase::visitChildren):
(WebCore::JSWorkletGlobalScopeBase::destroy):
(WebCore::JSWorkletGlobalScopeBase::scriptExecutionContext const):
(WebCore::JSWorkletGlobalScopeBase::supportsRichSourceInfo):
(WebCore::JSWorkletGlobalScopeBase::shouldInterruptScript):
(WebCore::JSWorkletGlobalScopeBase::shouldInterruptScriptBeforeTimeout):
(WebCore::JSWorkletGlobalScopeBase::javaScriptRuntimeFlags):
(WebCore::toJS):
(WebCore::toJSWorkletGlobalScope):

bindings/js/JSWorkletGlobalScopeBase.h: Added.

(WebCore::JSWorkletGlobalScopeBase::wrapped const):
(WebCore::JSWorkletGlobalScopeBase::proxy const):
(WebCore::JSWorkletGlobalScopeBase::createStructure):
(WebCore::toJS):

bindings/js/ScriptState.cpp:

(WebCore::execStateFromWorkerGlobalScope):
(WebCore::execStateFromWorkletGlobalScope):

bindings/js/ScriptState.h:
bindings/js/WebCoreBuiltinNames.h:
bindings/scripts/CodeGeneratorJS.pm:

(IsDOMGlobalObject):
(ShouldUseGlobalObjectPrototype):
(GenerateHeader):
(GenerateRuntimeEnableConditionalStringForExposed):
(GenerateImplementation):

bindings/scripts/preprocess-idls.pl:
css/CSSPaintImageValue.cpp:

(WebCore::CSSPaintImageValue::image):

css/DOMCSSPaintWorklet.cpp:

(WebCore::DOMCSSPaintWorklet::ensurePaintWorklet):
(WebCore::DOMCSSPaintWorklet::ensurePaintWorkletGlobalScope): Deleted.

css/DOMCSSPaintWorklet.h:
css/DOMCSSPaintWorklet.idl:
dom/Document.cpp:

(WebCore::Document::ensureCSSPaintWorklet):
(WebCore::Document::setCSSPaintWorkletGlobalScope):
(WebCore::Document::ensureCSSPaintWorkletGlobalScope): Deleted.

dom/Document.h:

(WebCore::Document::getCSSPaintWorkletGlobalScope):

dom/EventTargetFactory.in:
dom/ScriptExecutionContext.cpp:

(WebCore::ScriptExecutionContext::vm):
(WebCore::ScriptExecutionContext::execState):

dom/ScriptExecutionContext.h:

(WebCore::ScriptExecutionContext::isWorkletGlobalScope const):

inspector/agents/worker/WorkerDebuggerAgent.cpp:

(WebCore::WorkerDebuggerAgent::injectedScriptForEval):

inspector/agents/worker/WorkerRuntimeAgent.cpp:

(WebCore::WorkerRuntimeAgent::injectedScriptForEval):

platform/graphics/CustomPaintImage.cpp:

(WebCore::CustomPaintImage::CustomPaintImage):
(WebCore::CustomPaintImage::doCustomPaint):

platform/graphics/CustomPaintImage.h:
worklets/PaintWorkletGlobalScope.cpp: Copied from Source/WebCore/css/CSSPaintWorkletGlobalScope.cpp.

(WebCore::PaintWorkletGlobalScope::create):
(WebCore::PaintWorkletGlobalScope::PaintWorkletGlobalScope):
(WebCore::PaintWorkletGlobalScope::devicePixelRatio):
(WebCore::PaintWorkletGlobalScope::addRegisteredPaint):

worklets/PaintWorkletGlobalScope.h: Renamed from Source/WebCore/css/CSSPaintWorkletGlobalScope.h.
worklets/PaintWorkletGlobalScope.idl: Copied from Source/WebCore/css/CSSPaintWorkletGlobalScope.idl.
worklets/Worklet.cpp: Copied from Source/WebCore/css/CSSPaintWorkletGlobalScope.cpp.

(WebCore::Worklet::create):
(WebCore::Worklet::Worklet):
(WebCore::Worklet::addModule):

worklets/Worklet.h: Renamed from Source/WebCore/css/CSSPaintWorkletGlobalScope.cpp.
worklets/Worklet.idl: Copied from Source/WebCore/css/CSSPaintWorkletGlobalScope.idl.
worklets/WorkletConsoleClient.cpp: Copied from Source/WebCore/inspector/agents/worker/WorkerDebuggerAgent.cpp.

(WebCore::WorkletConsoleClient::WorkletConsoleClient):
(WebCore::WorkletConsoleClient::messageWithTypeAndLevel):
(WebCore::WorkletConsoleClient::count):
(WebCore::WorkletConsoleClient::time):
(WebCore::WorkletConsoleClient::timeEnd):
(WebCore::WorkletConsoleClient::profile):
(WebCore::WorkletConsoleClient::profileEnd):
(WebCore::WorkletConsoleClient::takeHeapSnapshot):
(WebCore::WorkletConsoleClient::timeStamp):
(WebCore::WorkletConsoleClient::record):
(WebCore::WorkletConsoleClient::recordEnd):

worklets/WorkletConsoleClient.h: Added.
worklets/WorkletGlobalScope.cpp: Added.

(WebCore::WorkletGlobalScope::WorkletGlobalScope):
(WebCore::WorkletGlobalScope::~WorkletGlobalScope):
(WebCore::WorkletGlobalScope::evaluate):
(WebCore::WorkletGlobalScope::isJSExecutionForbidden const):
(WebCore::WorkletGlobalScope::disableEval):
(WebCore::WorkletGlobalScope::disableWebAssembly):
(WebCore::WorkletGlobalScope::completeURL const):
(WebCore::WorkletGlobalScope::logExceptionToConsole):
(WebCore::WorkletGlobalScope::addConsoleMessage):
(WebCore::WorkletGlobalScope::addMessage):

worklets/WorkletGlobalScope.h: Added.

(WebCore::WorkletGlobalScope::isPaintWorkletGlobalScope const):
(WebCore::WorkletGlobalScope::identifier const):
(WebCore::WorkletGlobalScope::script):
(WebCore::WorkletGlobalScope::jsRuntimeFlags const):
(isType):

worklets/WorkletGlobalScope.idl: Renamed from Source/WebCore/css/CSSPaintWorkletGlobalScope.idl.
worklets/WorkletScriptController.cpp: Added.

(WebCore::WorkletScriptController::WorkletScriptController):
(WebCore::WorkletScriptController::~WorkletScriptController):
(WebCore::WorkletScriptController::forbidExecution):
(WebCore::WorkletScriptController::isExecutionForbidden const):
(WebCore::WorkletScriptController::disableEval):
(WebCore::WorkletScriptController::disableWebAssembly):
(WebCore::WorkletScriptController::initScriptWithSubclass):
(WebCore::WorkletScriptController::initScript):
(WebCore::WorkletScriptController::evaluate):
(WebCore::WorkletScriptController::setException):

worklets/WorkletScriptController.h: Added.

(WebCore::WorkletScriptController::workletGlobalScopeWrapper):
(WebCore::WorkletScriptController::vm):
(WebCore::WorkletScriptController::initScriptIfNeeded):

Tools:

Scripts/webkitpy/bindings/main.py:

(BindingsTests.generate_supplemental_dependency):
(BindingsTests.main):

LayoutTests:

Add a new test harness for worklet tests, since they do not have access to the dom.

fast/css-custom-paint/basic-expected.txt:
fast/css-custom-paint/basic.html:
fast/css-custom-paint/registerPaintBindings-expected.html: Added.
fast/css-custom-paint/registerPaintBindings-expected.txt: Removed.
fast/css-custom-paint/registerPaintBindings.html:
fast/css-custom-paint/resources/testharness-worklet.js: Added.

(format_value):

fast/css-custom-paint/resources/testharness.js: Added.

(async.importWorklet):

fast/css-custom-paint/worklet-expected.html: Added.
fast/css-custom-paint/worklet.html: Added.

7:36 PM Changeset in webkit [237765] by mmaxfield@apple.com

27 edits in trunk/Source/WebCore

Clean up drawLineForDocumentMarker()
https://bugs.webkit.org/show_bug.cgi?id=191215

Reviewed by Zalan Bujtas.

In preparation for https://bugs.webkit.org/show_bug.cgi?id=190764, I need to do a little bit of refactoring.
This patch has no behavior change; it just does the following:

Renames drawLineForDocumentMarker() to drawDotsForDocumentMarker(), because 2 of the 3 implementations draw dots
Moves our implementation back into GraphicsContext, because it's simpler and GraphicsContext is already platform-

specific.

The signature used to accept a location and a width, but without a height, it's difficult to know what the bounding

box is. In particular, knowing the bounding box must be possible without a GraphicsContext. So, I've modified
the signature to accept a rectangle instead. The GraphicsContext draws only within this rectangle.

No new tests because there is no behavior change.

platform/graphics/GraphicsContext.h:
platform/graphics/GraphicsContextImpl.h:
platform/graphics/cairo/CairoOperations.cpp:

(WebCore::Cairo::drawDotsForDocumentMarker):
(WebCore::Cairo::drawLineForDocumentMarker): Deleted.

platform/graphics/cairo/CairoOperations.h:
platform/graphics/cairo/GraphicsContextCairo.cpp:

(WebCore::GraphicsContext::drawDotsForDocumentMarker):
(WebCore::GraphicsContext::drawLineForDocumentMarker): Deleted.

platform/graphics/cairo/GraphicsContextImplCairo.cpp:

(WebCore::GraphicsContextImplCairo::drawDotsForDocumentMarker):
(WebCore::GraphicsContextImplCairo::drawLineForDocumentMarker): Deleted.

platform/graphics/cairo/GraphicsContextImplCairo.h:
platform/graphics/cocoa/FontCascadeCocoa.mm:
platform/graphics/cocoa/GraphicsContextCocoa.mm:

(WebCore::colorForMarkerLineStyle):
(WebCore::GraphicsContext::drawDotsForDocumentMarker):
(WebCore::GraphicsContext::drawLineForDocumentMarker): Deleted.

platform/graphics/displaylists/DisplayListItems.cpp:

(WebCore::DisplayList::Item::sizeInBytes):
(WebCore::DisplayList::DrawDotsForDocumentMarker::apply const):
(WebCore::DisplayList::DrawDotsForDocumentMarker::localBounds const):
(WebCore::DisplayList::operator<<):
(WebCore::DisplayList::DrawLineForDocumentMarker::apply const): Deleted.
(WebCore::DisplayList::DrawLineForDocumentMarker::localBounds const): Deleted.

platform/graphics/displaylists/DisplayListItems.h:

(WebCore::DisplayList::DrawDotsForDocumentMarker::create):
(WebCore::DisplayList::DrawDotsForDocumentMarker::rect const):
(WebCore::DisplayList::DrawDotsForDocumentMarker::DrawDotsForDocumentMarker):
(WebCore::DisplayList::DrawLineForDocumentMarker::create): Deleted.
(WebCore::DisplayList::DrawLineForDocumentMarker::point const): Deleted.
(WebCore::DisplayList::DrawLineForDocumentMarker::width const): Deleted.
(WebCore::DisplayList::DrawLineForDocumentMarker::DrawLineForDocumentMarker): Deleted.

platform/graphics/displaylists/DisplayListRecorder.cpp:

(WebCore::DisplayList::Recorder::drawDotsForDocumentMarker):
(WebCore::DisplayList::Recorder::drawLineForDocumentMarker): Deleted.

platform/graphics/displaylists/DisplayListRecorder.h:
platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:

(Nicosia::CairoOperationRecorder::drawDotsForDocumentMarker):
(Nicosia::CairoOperationRecorder::drawLineForDocumentMarker): Deleted.

platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h:
platform/graphics/win/GraphicsContextCGWin.cpp:

(WebCore::GraphicsContext::drawDotsForDocumentMarker):
(WebCore::GraphicsContext::drawLineForDocumentMarker): Deleted.

platform/graphics/win/GraphicsContextDirect2D.cpp:

(WebCore::GraphicsContext::drawDotsForDocumentMarker):
(WebCore::GraphicsContext::drawLineForDocumentMarker): Deleted.

rendering/InlineTextBox.cpp:

(WebCore::InlineTextBox::paintPlatformDocumentMarker):

rendering/RenderTheme.cpp:

(WebCore::RenderTheme::drawLineForDocumentMarker): Deleted.

rendering/RenderTheme.h:
rendering/RenderThemeCocoa.h:
rendering/RenderThemeCocoa.mm:

(WebCore::RenderThemeCocoa::drawLineForDocumentMarker): Deleted.

rendering/RenderThemeIOS.h:
rendering/RenderThemeIOS.mm:

(WebCore::RenderThemeIOS::colorForMarkerLineStyle): Deleted.

rendering/RenderThemeMac.h:
rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::colorForMarkerLineStyle): Deleted.

6:52 PM Changeset in webkit [237764] by keith_miller@apple.com

2 edits in trunk/Source/JavaScriptCore

Assert JSValues can fit into a pointer when API casting
https://bugs.webkit.org/show_bug.cgi?id=191220

Reviewed by Michael Saboff.

API/APICast.h:

(toJS):
(toJSForGC):
(toRef):

6:27 PM Changeset in webkit [237763] by msaboff@apple.com

7 edits
1 add in trunk

Rolling in r237753 with unreviewed build fix.

Fixed issues with DECLARE_THROW_SCOPE placement.

5:49 PM Changeset in webkit [237762] by Ryan Haddad

2 edits in trunk/Source/WebKit

Unreviewed, attempt to fix the build with recent SDKs.

Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:

(WebKit::XPCServiceExit):

5:33 PM Changeset in webkit [237761] by achristensen@apple.com

8 edits
1 add in trunk

Mac production builds should sign the network process xpc service with entitlements
https://bugs.webkit.org/show_bug.cgi?id=191209
<rdar://problem/45377609>

Reviewed by Geoff Garen.

Source/WebKit:

Configurations/NetworkService.xcconfig:

Set CODE_SIGN_ENTITLEMENTS_COCOA_TOUCH_NO like we do for the web process,
except with the corresponoding network process entitlements file.

UIProcess/API/Cocoa/WKProcessPool.mm:

(-[WKProcessPool _networkProcessHasEntitlementForTesting:]):

UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
UIProcess/Cocoa/WebProcessPoolCocoa.mm:

(WebKit::WebProcessPool::networkProcessHasEntitlementForTesting):

UIProcess/WebProcessPool.h:

Add infrastructure to test that the network process actually has an entitlement.

Tools:

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.

(TEST):

5:06 PM Changeset in webkit [237760] by Chris Dumez

3 edits in trunk/LayoutTests

REGRESSION (r237699): Layout Test http/tests/security/anchor-download-block-crossorigin.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=191199

Reviewed by Dewei Zhu.

Navigate the subframe instead of the main frame, to make sure that the console message is consistently logged.

http/tests/security/anchor-download-block-crossorigin-expected.txt:
http/tests/security/anchor-download-block-crossorigin.html:

4:33 PM Changeset in webkit [237759] by Kocsen Chung

24 edits in tags/Safari-607.1.12.1

Apply patch. rdar://problem/45749094
https://bugs.webkit.org/show_bug.cgi?id=191201

4:20 PM Changeset in webkit [237758] by Jon Davis

2 edits in trunk/Websites/webkit.org

Follow-up fix for the webkit.org blog index page
https://bugs.webkit.org/show_bug.cgi?id=191216

Reviewed by Timothy Hatcher.

wp-content/themes/webkit/index.php:

3:47 PM Changeset in webkit [237757] by Ryan Haddad

7 edits
1 delete in trunk

Unreviewed, rolling out r237753.

Introduced JSC test failures

Reverted changeset:

"Running out of stack space not properly handled in
RegExp::compile() and its callers"
https://bugs.webkit.org/show_bug.cgi?id=191206
https://trac.webkit.org/changeset/237753

3:46 PM Changeset in webkit [237756] by pvollan@apple.com

2 edits in trunk/LayoutTests

[Win] Layout Test fast/block/basic/inline-content-with-floating-image.html is failing
https://bugs.webkit.org/show_bug.cgi?id=191194

Unreviewed test gardening.

platform/win/TestExpectations:

3:35 PM Changeset in webkit [237755] by Lucas Forschler

2 edits in trunk/Tools

Add Windows 10 archive bots
https://bugs.webkit.org/show_bug.cgi?id=190964

This Change updates the Apple Windows Buildbot configuration.

Add Windows 10 specific builders and testers for release and debug.
Refactor Windows -> Windows 7.
Remove Windows 7 Debug.

Reviewed by Aakash Jain.

BuildSlaveSupport/build.webkit.org-config/config.json:

3:07 PM Changeset in webkit [237754] by ajuma@chromium.org

3 edits in trunk/Source/WebCore

requestAnimationFrame causes bad location of position:fixed inside overflow:auto and iframe
https://bugs.webkit.org/show_bug.cgi?id=176243

Reviewed by Simon Fraser.

When a new layer tree is committed to the UIProcess, the positions of layers for fixed
or sticky nodes in the newly-committed tree can be stale, because of scrolling that has
happened in the UIProcess since the tree was updated in the WebProcess. To handle this,
RemoteLayerTreeDrawingAreaProxy::commitLayerTree updates the positions of these layers
by calling RemoteScrollingCoordinatorProxy::viewportChangedViaDelegatedScrolling, which
leads to a recursive traversal of the ScrollingTree to update each such layer. However,
since ScrollingTreeFrameScrollingNodeIOS didn't implement updateLayersAfterAncestorChange,
this traversal never descended into scrolling nodes within an iframe, so the layers for
these nodes were left with stale positions.

Implement ScrollingTreeFrameScrollingNodeIOS::updateLayersAfterAncestorChange so that
fixed and sticky layers within an iframe do get their positions updated when a new layer
tree is committed.

page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.h:
page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm:

(WebCore::ScrollingTreeFrameScrollingNodeIOS::updateLayersAfterAncestorChange):

3:05 PM Changeset in webkit [237753] by msaboff@apple.com

7 edits
1 add in trunk

Running out of stack space not properly handled in RegExp::compile() and its callers
https://bugs.webkit.org/show_bug.cgi?id=191206

Reviewed by Filip Pizlo.

JSTests:

New regression test.

stress/regexp-compile-oom.js: Added.

(recurseAndTest):

Source/JavaScriptCore:

Eliminated two RELEASE_ASSERT_NOT_REACHED() for errors returned by Yarr parsing code. Bubbled those errors
up to where they are turned into the appropriate exceptions in matchInline(). If the errors are not due
to syntax, we reset the RegExp state in case the parsing is tried with a smaller stack.

runtime/RegExp.cpp:

(JSC::RegExp::compile):
(JSC::RegExp::compileMatchOnly):

runtime/RegExp.h:
runtime/RegExpInlines.h:

(JSC::RegExp::compileIfNecessary):
(JSC::RegExp::matchInline):
(JSC::RegExp::compileIfNecessaryMatchOnly):

runtime/RegExpObjectInlines.h:

(JSC::RegExpObject::execInline):

yarr/YarrErrorCode.h:

(JSC::Yarr::hasHardError):

2:43 PM Changeset in webkit [237752] by Jon Davis

9 edits in trunk/Websites/webkit.org

Improved the SVG icons to use SVG symbols
https://bugs.webkit.org/show_bug.cgi?id=191205

Reviewed by Timothy Hatcher.

This change makes it far easier to add new SVG icons to the
icons.svg sprite and provides better positioning control
over the icons within the blog post tile frame.

wp-content/themes/webkit/front-page.php:
wp-content/themes/webkit/functions.php:
wp-content/themes/webkit/header.php:
wp-content/themes/webkit/images/icons.svg:
wp-content/themes/webkit/index.php:
wp-content/themes/webkit/loop.php:
wp-content/themes/webkit/style.css:

(@supports ( -webkit-backdrop-filter: blur(10px) )):
(footer):
(#icons):
(.tile .background-image):
(.tile .background-image svg):
(.tile.category-web-inspector svg):
(.tile.category-performance svg):
(.tile.category-javascript svg):
(.tile.category-css svg):
(.tile.category-standards svg):
(.tile.category-contributing svg):
(.tile.category-storage svg):
(.tile.category-layout svg):
(.tile.category-safari-technology-preview svg):
(.tile.category-accessibility svg):
(.tile.category-security svg):
(.tile.category-privacy svg):
(header .menu-item-has-children .label-toggle::after):
(@media only screen and (max-width: 920px)):
(.main-menu.label-toggle):
(header .menu):
(@media only screen and (max-width: 690px)):
(@media only screen and (max-width: 415px)):
(@media only screen and (max-height: 415px)):
(.tile.category-web-inspector .background-image): Deleted.
(.tile.category-performance .background-image): Deleted.
(.tile.category-javascript .background-image): Deleted.
(.tile.category-css .background-image): Deleted.
(.tile.category-standards .background-image): Deleted.
(.tile.category-contributing .background-image): Deleted.
(.tile.category-storage .background-image): Deleted.
(.tile.category-layout .background-image): Deleted.
(.tile.category-safari-technology-preview .background-image): Deleted.
(.tile.category-accessibility .background-image): Deleted.
(.tile.tag-console .background-image,): Deleted.
(.tile.tag-console .background-image): Deleted.
(.tile.tag-debugger .background-image): Deleted.
(.tile.tag-shortcuts .background-image): Deleted.
(.tile.tag-timeline .background-image): Deleted.

wp-content/themes/webkit/widgets/post.php:

1:38 PM Changeset in webkit [237751] by bshafiei@apple.com

2 edits in tags/Safari-607.1.12.1/Source/JavaScriptCore

Cherry-pick r237745. rdar://problem/45765887

API should use wrapper object if address is 32-bit
https://bugs.webkit.org/show_bug.cgi?id=191203

Reviewed by Filip Pizlo.

API/APICast.h: (toJS): (toJSForGC): (toRef):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

1:33 PM Changeset in webkit [237750] by bshafiei@apple.com

125 edits
4 adds
29 deletes in tags/Safari-607.1.12.1

Revert r237547. rdar://problem/45767917

1:33 PM Changeset in webkit [237749] by bshafiei@apple.com

3 edits
1 delete in tags/Safari-607.1.12.1

Revert r237553. rdar://problem/45768563

1:33 PM Changeset in webkit [237748] by bshafiei@apple.com

2 edits in tags/Safari-607.1.12.1/Source/JavaScriptCore

Revert r237576. rdar://problem/45767917

1:33 PM Changeset in webkit [237747] by bshafiei@apple.com

6 edits in tags/Safari-607.1.12.1/Source/JavaScriptCore

Revert r237627. rdar://problem/45771226

12:39 PM Changeset in webkit [237746] by Matt Baker

4 edits in trunk/Source/WebInspectorUI

Web Inspector: support multiple selection/deletion of cookie records
https://bugs.webkit.org/show_bug.cgi?id=66381
<rdar://problem/19281525>

Reviewed by Devin Rousso.

Localizations/en.lproj/localizedStrings.js:

UserInterface/Views/CookieStorageContentView.js:

(WI.CookieStorageContentView):
(WI.CookieStorageContentView.prototype.get scrollableElements):
(WI.CookieStorageContentView.prototype.tableNumberOfRows):
(WI.CookieStorageContentView.prototype.tableSortChanged):
(WI.CookieStorageContentView.prototype.tableCellContextMenuClicked):
(WI.CookieStorageContentView.prototype.tableDidRemoveRows):
(WI.CookieStorageContentView.prototype.tablePopulateCell):
(WI.CookieStorageContentView.prototype.initialLayout):
(WI.CookieStorageContentView.prototype._generateSortComparator):
(WI.CookieStorageContentView.prototype._refreshButtonClicked):
(WI.CookieStorageContentView.prototype._reloadCookies):
(WI.CookieStorageContentView.prototype._updateSort):
(WI.CookieStorageContentView.prototype._handleTableKeyDown):
(WI.CookieStorageContentView.prototype.update): Deleted.
(WI.CookieStorageContentView.prototype._rebuildTable): Deleted.
(WI.CookieStorageContentView.prototype._sortDataGrid.localeCompare): Deleted.
(WI.CookieStorageContentView.prototype._sortDataGrid.numberCompare): Deleted.
(WI.CookieStorageContentView.prototype._sortDataGrid.expiresCompare): Deleted.
(WI.CookieStorageContentView.prototype._sortDataGrid): Deleted.
(WI.CookieStorageContentView.prototype._deleteCallback): Deleted.
Replace DataGrid with Table. The content view serves as the table
delegate and data source, and handles delete and backspace key events
to allow deleting the selected cookies. Cookies may also be deleted from
the table context menu and a new button in the navigation bar.

UserInterface/Views/Table.js:

(WI.Table.prototype.isRowSelected):
(WI.Table.prototype.selectRow):
(WI.Table.prototype.deselectRow):
(WI.Table.prototype.removeRow):
(WI.Table.prototype._getOrCreateRow):
(WI.Table.prototype._handleMouseDown):
(WI.Table.prototype._removeRows):
(WI.Table.prototype._isRowSelected): Deleted.
Make isSelectedRow public. It is more convenient and efficient than
calling Table.prototype.selectedRows.includes(rowIndex).

12:03 PM Changeset in webkit [237745] by keith_miller@apple.com

2 edits in trunk/Source/JavaScriptCore

API should use wrapper object if address is 32-bit
https://bugs.webkit.org/show_bug.cgi?id=191203

Reviewed by Filip Pizlo.

API/APICast.h:

(toJS):
(toJSForGC):
(toRef):

11:31 AM Changeset in webkit [237744] by Alan Coon

11 edits
1 delete in tags/Safari-607.1.12.1/Source

Cherry-pick r237721. rdar://problem/45722391

Replace CommonRandom SPI with API
https://bugs.webkit.org/show_bug.cgi?id=191178
<rdar://problem/45722391>

Reviewed by Brent Fulgham.

Source/bmalloc:

bmalloc/CryptoRandom.cpp: (bmalloc::ARC4RandomNumberGenerator::stir):

Source/WebCore:

The API is available since macOS 10.10 and iOS 10, and therefore it is safe to replace
all SPI usages with API.

No change of behaviors.

crypto/CommonCryptoUtilities.h:
crypto/mac/CryptoKeyMac.cpp: (WebCore::CryptoKey::randomData):
crypto/mac/SerializedCryptoKeyWrapMac.mm: (WebCore::createAndStoreMasterKey): (WebCore::wrapSerializedCryptoKey):
page/Crypto.cpp: (WebCore::Crypto::getRandomValues):

Source/WTF:

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/RandomDevice.cpp: (WTF::RandomDevice::cryptographicallyRandomValues):
wtf/spi/darwin/CommonCryptoSPI.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11:10 AM Changeset in webkit [237743] by Wenson Hsieh

7 edits
2 adds in trunk

[iOS] Changing view scale sometimes does not zoom the page to the new initial scale, when the page is at initial scale
https://bugs.webkit.org/show_bug.cgi?id=191180
<rdar://problem/45744786>

Reviewed by Simon Fraser.

Source/WebCore:

When computing the minimum scale in ViewportConfiguration::minimumScale, if our content width or height is
shorter than the view width or height, then we recompute the minimum scale such that the content dimensions will
fill the bounds of the view by setting the minimum scale to the view width or height divided by the content
width or height.

Suppose the minimum scale is equal to some value s; additionally, let w_c denote the content width and w_v
denote the view width (as integers). If w_v / s is not an integral value, the computed content width w_c may
be rounded, such that w_v / w_c is not precisely equal to s. In the case that w_v / w_c is ever so
slightly larger than s, we will end up overriding the minimum scale s with w_v / w_c.

As a result, specifying a viewport with a decimal minimum-scale will sometimes cause the computed minimum
scale of the viewport (and platform view) to be very slightly different from the minimum scale. The new layout
test below exercises this scenario, specifying a viewport with minimum and initial scales of 0.94 that results
in ViewportConfiguration::minimumScale returning 0.94158.

With the WebPage::setViewportConfigurationViewLayoutSize check added in r237127, this means setting
_viewScale: when the page is at initial scale sometimes doesn't zoom the page to the new initial scale when it
should, since the page scale factor and the initial scale are different enough such that
areEssentiallyEqualAsFloat returns false.

This patch addresses these issues by snapping to the minimum scale if the computed scale that fits content
dimensions to view dimensions results in a minimum scale that is close enough to the configuration's minimum
scale, such that the difference can be attributed to rounding error when computing content or view dimensions.

Test: fast/viewport/ios/viewport-minimum-and-initial-scale.html

page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::minimumScale const):

LayoutTests:

Add a layout test, and make some adjustments to UIHelper.

fast/viewport/ios/constant-width-viewport-after-changing-view-scale.html:
fast/viewport/ios/device-width-viewport-after-changing-view-scale.html:
fast/viewport/ios/viewport-minimum-and-initial-scale-expected.txt: Added.
fast/viewport/ios/viewport-minimum-and-initial-scale.html: Added.

Add a new layout test that contains a viewport meta tag with minimum and initial scales set to 0.94, and checks
that the resulting minimum and initial scales are 0.94 instead of 0.94158.

fast/viewport/watchos/viewport-disable-extra-zoom-adaptations.html:
resources/ui-helper.js:

Make UIHelper.zoomScale return a number rather than a string, and adjust a few call sites.

(window.UIHelper.zoomScale):
(window.UIHelper.minimumZoomScale):
(window.UIHelper):

10:45 AM Changeset in webkit [237742] by Philippe Normand

2 edits in trunk/Source/WebCore

[GTK][WPE] Unreviewed, another --no-video --no-web-audio build fix following r237677

inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::addEventListenersToNode):

10:42 AM Changeset in webkit [237741] by Philippe Normand

3 edits in trunk/Tools

[GTK][WPE] Enable GST_DEBUG_NO_COLOR environment variable pass-through

Rubber-stamped by Michael Catanzaro.

This variable is useful to get rid of shell color escapes in tests stderr files.

Scripts/webkitpy/port/gtk.py:

(GtkPort.setup_environ_for_server):

Scripts/webkitpy/port/wpe.py:

(WPEPort.setup_environ_for_server):

10:35 AM Changeset in webkit [237740] by aakash_jain@apple.com

1 edit
20 adds in trunk/Tools

Add Basic Django web app for OpenSource EWS
https://bugs.webkit.org/show_bug.cgi?id=191091

Reviewed by Lucas Forschler.

BuildSlaveSupport/EWS_app/manage.py: Added, auto-generated by Django.
BuildSlaveSupport/EWS_app/EWS_app/init.py: Added, auto-generated by Django.
BuildSlaveSupport/EWS_app/EWS_app/settings.py: Added, auto-generated by Django.
BuildSlaveSupport/EWS_app/EWS_app/urls.py: Added, auto-generated by Django.
BuildSlaveSupport/EWS_app/EWS_app/wsgi.py: Added, auto-generated by Django.
BuildSlaveSupport/EWS_app/ews/init.py: Added.
BuildSlaveSupport/EWS_app/ews/admin.py: Added, auto-generated by Django.
BuildSlaveSupport/EWS_app/ews/apps.py: Added, auto-generated by Django.
BuildSlaveSupport/EWS_app/ews/migrations/init.py: Added.
BuildSlaveSupport/EWS_app/ews/tests.py: Added, auto-generated by Django.
BuildSlaveSupport/EWS_app/ews/models/init.py: Added.
BuildSlaveSupport/EWS_app/ews/models/patch.py: Added.
BuildSlaveSupport/EWS_app/ews/views/init.py: Added.
BuildSlaveSupport/EWS_app/ews/views/patch.py: Added.

10:20 AM Changeset in webkit [237739] by dbates@webkit.org

4 edits in trunk/Source/WebCore

[iOS] Normalize character string based on key code
https://bugs.webkit.org/show_bug.cgi?id=191120

Reviewed by Tim Horton.

Source/WebCore:

Following r236417 (https://bugs.webkit.org/show_bug.cgi?id=189604) we always have a valid key code
for a special key (e.g. page up) and can simplify the character string normalization code.

No functionality changed. So, no new tests.

platform/ios/WebEvent.mm:

(normalizedStringWithAppKitCompatibilityMapping): Modified to take a key code and wrote algorithm
in terms of it.

(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:keyCode:isTabKey:characterSet:]):
(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:withInputManagerHint:keyCode:isTabKey:]):
Pass the key code for the event to normalizedStringWithAppKitCompatibilityMapping().

Source/WebCore/PAL:

Remove forward declarations that are no longer needed now that we check key code.

pal/spi/ios/UIKitSPI.h:

10:17 AM Changeset in webkit [237738] by dbates@webkit.org

16 edits in trunk

[iOS] WebKit should dispatch DOM events when a modifier key is pressed
https://bugs.webkit.org/show_bug.cgi?id=190487

Reviewed by Tim Horton.

Source/WebCore:

Add support for modifier flags change events.

platform/ios/PlatformEventFactoryIOS.mm:

(WebCore::modifiersForEvent): Modifier keys do not have an associated character and do not
participate in key repeat.
(WebCore::keyIdentifierForKeyEvent): Identify modifier keys, returning "Unidentified" if
the modifier key is unidentified. This matches the behavior on Mac.
(WebCore::keyForKeyEvent): Identify modifier keys, returning the empty string if the modifier
key is unidentified. This matches the behavior on Mac.
(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):

platform/ios/WebEvent.h:

platform/ios/WebEvent.mm:

(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:keyCode:isTabKey:characterSet:]):
(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:withInputManagerHint:keyCode:isTabKey:]):
Modifier keys do not have an associated character and do not participate in key repeat.

(-[WebEvent _eventDescription]): Modified to print a description for a keydown or keyup event
that represents a modifier flags change.
(-[WebEvent characters]): Modifier keys do not have an associated character. Assert this
invariant as it is a programming error. On Mac, the same operation would result in a
NSInternalInconsistencyException exception being raised.
(-[WebEvent charactersIgnoringModifiers]): Ditto.

Source/WebKit:

Add support for modifier flags change events dispatched by UIKit.

Shared/ios/WebIOSEventFactory.mm:

(modifiersForEvent): Update for renamed enumerations.
(WebIOSEventFactory::createWebKeyboardEvent): Modifier keys do not have an associated
character and do not participate in key repeat.

UIProcess/Automation/ios/WebAutomationSessionIOS.mm:

(WebKit::WebAutomationSession::platformSimulateKeyboardInteraction): Update for renamed enumerations.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _interpretKeyEvent:isCharEvent:]): Return NO if the event represents a
modifier flags change to allow the default handling.

UIProcess/ios/WKKeyboardScrollingAnimator.mm:

(-[WKKeyboardScrollingAnimator keyboardScrollForEvent:]): Update for renamed enumerations.

Source/WebKitLegacy/mac:

Having Legacy WebKit return NO if the editing event represents a modifier flags change to
allow the default handling.

WebView/WebHTMLView.mm:

(-[WebHTMLView _handleEditingKeyEvent:]):

Tools:

Update the code for renamed enumerations. For WebKitTestRunner, removed comment that does not
match my observations when using the simulator to simulate iOS 12 and add support for testing
right-hand side modifiers.

DumpRenderTree/mac/EventSendingController.mm:

(modifierFlags):
(-[EventSendingController keyDown:withModifiers:withLocation:]):
(-[EventSendingController setTouchModifier:value:]):

WebKitTestRunner/ios/HIDEventGenerator.mm:

(hidUsageCodeForCharacter):

LayoutTests:

Update expected results of an existing test now that we identify modifier keys.

fast/events/ios/keydown-keyup-special-keys-in-non-editable-element-expected.txt:

9:55 AM Changeset in webkit [237737] by ajuma@chromium.org

17 edits
2 copies
7 adds in trunk

Allow cross-document intersection observing
https://bugs.webkit.org/show_bug.cgi?id=165746

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Update expectations for tests that now pass.

web-platform-tests/intersection-observer/client-rect-expected.txt:
web-platform-tests/intersection-observer/cross-origin-iframe-expected.txt:
web-platform-tests/intersection-observer/iframe-no-root-expected.txt:
web-platform-tests/intersection-observer/timestamp-expected.txt:

Source/WebCore:

Add logic to compute the intersection between the viewport and an element in a
subframe.

Add a FloatRect version of ScrollView::rootViewToContents, and FloatRect versions
of the methods it calls.

Test: http/tests/intersection-observer/intermediate-frame-changes.html
Also covered by rebased tests in imported/w3c/web-platform-tests/intersection-observer.

dom/Document.cpp:

(WebCore::computeClippedRectInRootContentsSpace):
(WebCore::computeIntersectionState):
(WebCore::Document::updateIntersectionObservations):

page/FrameView.cpp:

(WebCore::FrameView::viewportContentsChanged):
(WebCore::FrameView::convertFromContainingViewToRenderer const):
(WebCore::FrameView::convertFromContainingView const):

page/FrameView.h:
platform/ScrollView.cpp:

(WebCore::ScrollView::viewToContents const):
(WebCore::ScrollView::contentsToView const):
(WebCore::ScrollView::rootViewToContents const):

platform/ScrollView.h:
platform/Widget.cpp:

(WebCore::Widget::convertFromRootView const):
(WebCore::Widget::convertFromContainingView const):

platform/Widget.h:

LayoutTests:

Add a test that cross-document intersection observations are triggered when an intermediate frame
scrolls. Skip the test on WK1 platforms where IntersectionObserver is not supported.

Add platform-specific baselines for tests involving iframe scrolling, which isn't supported on iOS.

http/tests/intersection-observer/intermediate-frame-changes-expected.txt: Added.
http/tests/intersection-observer/intermediate-frame-changes.html: Added.
http/tests/intersection-observer/resources/intermediate-frame.html: Added.
http/tests/intersection-observer/resources/nested-frame.html: Added.
platform/ios/imported/w3c/web-platform-tests/intersection-observer/cross-origin-iframe-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/intersection-observer/cross-origin-iframe-expected.txt.
platform/ios/imported/w3c/web-platform-tests/intersection-observer/iframe-no-root-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/intersection-observer/iframe-no-root-expected.txt.
platform/mac-wk1/TestExpectations:
platform/win/TestExpectations:
platform/wincairo/TestExpectations:

9:49 AM Changeset in webkit [237736] by Kocsen Chung

2 edits in tags/Safari-607.1.12.1/Source/JavaScriptCore

Cherry-pick r237707. rdar://problem/45749094

Unreviewed, JavaScriptCore should only guarantee to produce a
modulemap if we are building for iOSMac.

Configurations/JavaScriptCore.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8:59 AM Changeset in webkit [237735] by Chris Dumez

6 edits in trunk

[PSON] Reuse SuspendedPages' process when possible, for performance
https://bugs.webkit.org/show_bug.cgi?id=191166

Reviewed by Geoffrey Garen.

Source/WebKit:

When process-swapping check if there is an existing SuspendedPage for the domain we're going to.
If there is, use this SuspendedPage's process for the navigation instead of a fresh new process.
This change should be beneficial for performance as it:

Avoids spinning up a new process (CPU & memory cost)
Likely better leverages caches since this process already loaded this domain in the past

Due to current limitations, using a SuspendedPage's proxy may consume the SuspendedPage, which
means that it can no longer be used for PageCache on history navigations. We need to do this when
the SuspendedPageProxy in question was created for the current WebPageProxy because:

This SuspendedPageProxy's process already has a suspended WebPage with this WebPageProxy's pageID

and

We do not currently support having more than one WebPage with a given pageID within a single WebProcess.

UIProcess/SuspendedPageProxy.cpp:

(WebKit::SuspendedPageProxy::SuspendedPageProxy):

UIProcess/SuspendedPageProxy.h:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::processForNavigationInternal):

Tools:

Add API test coverage.

TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

8:46 AM Changeset in webkit [237734] by Tadeu Zagallo

4 edits in trunk/Source/JavaScriptCore

Metadata should not be copyable
https://bugs.webkit.org/show_bug.cgi?id=191193

Reviewed by Keith Miller.

We should only ever hold references to the entry in the metadata table.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finalizeLLIntInlineCaches):

dfg/DFGByteCodeParser.cpp:

(JSC::DFG::ByteCodeParser::parseBlock):

generator/Metadata.rb:

8:41 AM Changeset in webkit [237733] by pvollan@apple.com

2 edits in trunk/LayoutTests

[Win] Layout Test fast/block/basic/inline-content-with-floating-image.html is failing
https://bugs.webkit.org/show_bug.cgi?id=191194

Unreviewed test gardening.

platform/win/TestExpectations:

8:39 AM Changeset in webkit [237732] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

Remove ENABLE_OPENCL fully
https://bugs.webkit.org/show_bug.cgi?id=191172

Patch by Rob Buis <rbuis@igalia.com> on 2018-11-02
Reviewed by Yusuke Suzuki.

No new tests since no change in functionality.

platform/graphics/filters/FilterEffect.h:

(WebCore::FilterEffect::hasResult const):
(WebCore::FilterEffect::applyAll):
(WebCore::FilterEffect::openCLImage): Deleted.
(WebCore::FilterEffect::setOpenCLImage): Deleted.

7:23 AM Changeset in webkit [237731] by Alan Bujtas

7 edits
2 adds in trunk

[LFC][IFC] Add support for intrinsic width calculation
https://bugs.webkit.org/show_bug.cgi?id=191144

Reviewed by Antti Koivisto.

Source/WebCore:

This is the inline formatting version of the shrink-to-fit computation. It generates inline runs
and uses InlineLineBreaker to compute min/max width. This is very similar to ::layout.

Test: fast/inline/simple-shrink-to-fit-inline-block.html

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layout const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndMargin const):
(WebCore::Layout::InlineFormattingContext::computeHeightAndMargin const):
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForReplacedInlineBox const):
(WebCore::Layout::InlineFormattingContext::collectInlineContent const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForInlineBox const): Deleted.

layout/inlineformatting/InlineFormattingContext.h:

Tools:

LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

fast/inline/simple-shrink-to-fit-inline-block-expected.txt: Added.
fast/inline/simple-shrink-to-fit-inline-block.html: Added.
platform/ios/TestExpectations:

7:21 AM Changeset in webkit [237730] by Alan Bujtas

2 edits in trunk/Source/WebCore

[LFC][BFC] BlockFormattingContext::instrinsicWidthConstraints logic should look similar to ::layout
https://bugs.webkit.org/show_bug.cgi?id=191181

Reviewed by Antti Koivisto.

layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const):

6:41 AM Changeset in webkit [237729] by Alan Bujtas

9 edits in trunk/Source/WebCore

[LFC] Align shrink-to-fit width computation with the layout implementation.
https://bugs.webkit.org/show_bug.cgi?id=191179

Reviewed by Antti Koivisto.

There are many similarities between layout and shrink-to-fit.
They both operate on formatting roots only (shrink-to-fit -> float, out-of-flow, inline-block) and in both cases
the algoritm depends on what type of formatting context the element establishes.

This patch is in preparation for transforming the "shrink-to-fit" width computation to make it behave more like layout.
With this change the instrinsicWidthConstraints() computation happens in the formatting context that the element establishes (similar to layout).

layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):

layout/FormattingContext.h:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):

layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const):

layout/blockformatting/BlockFormattingContext.h:
layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):

layout/inlineformatting/InlineFormattingContext.h:
layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockWidthAndMargin):

3:46 AM Changeset in webkit [237728] by Tadeu Zagallo

3 edits in trunk/Source/JavaScriptCore

REGRESSION(r237547): Exception handlers should be aware of wide opcodes when JIT is disabled
https://bugs.webkit.org/show_bug.cgi?id=191175

Reviewed by Keith Miller.

https://bugs.webkit.org/show_bug.cgi?id=191108 did not handle the case where JIT is not enabled

jit/JITExceptions.cpp:

(JSC::genericUnwind):

llint/LLIntData.h:

(JSC::LLInt::getWideCodePtr):

3:04 AM Changeset in webkit [237727] by Philippe Normand

5 edits in trunk

[Apache] Self-signed SSL certificate RSA key is considered too weak
https://bugs.webkit.org/show_bug.cgi?id=191156

Reviewed by Michael Catanzaro.

Tools:

Scripts/webkitpy/common/system/pemfile.py:

LayoutTests:

Regenerate the self-signed SSL certificate with a 2048 bits RSA key.

http/conf/webkit-httpd.pem:

12:54 AM Changeset in webkit [237726] by graouts@webkit.org

17 edits in trunk

[Web Animations] Make document.getAnimations() return declarative animations in the correct order
https://bugs.webkit.org/show_bug.cgi?id=191153

Reviewed by Dean Jackson.

LayoutTests/imported/mozilla:

Mark progressions for the document.getAnimations() tests covering CSS Animations and CSS Transitions.
These tests are now in WPT and will be updated as part of a general WPT update for all of Web Animations
shortly. We will upstream the minor changes made at that point. Those changes were necessary because we
don't support the PseudoElement interface and instead we check which animation names and CSS properties
are applied to pseudo-elements rather than the pseudo-element's type.

css-animations/test_document-get-animations-expected.txt:
css-animations/test_document-get-animations.html:
css-animations/test_event-dispatch.html: Remove a comment that was added by mistake in a previous patch.
css-transitions/test_document-get-animations-expected.txt:
css-transitions/test_document-get-animations.html:

Source/WebCore:

The Web Animations spec has the notion of "composite order" which determines the order in which animations should
be returned when document.getAnimations() is called. The CSS Transitions and CSS Animations specifications also
determine the composite order of their respective animation classes, as well as the notion of "owning element",
the element that was the animation target when specified through style, prior to any manipulation via the Web
Animations API. We implement these two notions so that we can pass the document.getAnimations() tests for
declarative animations.

It is important that we have the notion of an "owning element" since when a CSS Transition or CSS Animation is
modified via the Web Animations API in a way that an animation created through CSS we must consider no longer
as a declarative animation but as a regular Web Animation. In this patch, we remove the DeclarativeAnimation's
target(), which returned a reference, to owningElement(), which returns a pointer and return nullptr once the
declarative animation has been modified.

In order to also keep a correct count of declarative animations applied to elements, we correctly add transitions
that have completed to a list of completed transitions, as specified by the CSS Transitions spec. We have had this
list declared in AnimationTimeline.h for a while but never actually did the work to add items to it. Thanks to that,
AnimationTimeline::updateCSSTransitionsForElement() now correctly accounts for completed transitions so that they
may be canceled if overridden with a new animation, correctly removing their "owning element".

Finally, now that we have saner lists of animations per classes, we can apply the right sorting routines to match
the composite order for CSS Transitions, CSS Animations and Web Animations, keeping a list of all animations created
in order as the final criterion for sorting.

animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::animationTimingDidChange): Make sure this animation is tracked on the list of all animations
created for this timeline in the order in which they were created, which is needed to sort animations correctly when
document.getAnimations() is called.
(WebCore::AnimationTimeline::animationWasAddedToElement): We've removed the relevantMapForAnimation() method which we used
to determine which map we should add an animation to based on its class and instead have code that accounts for not just
the animation's class, but also whether it has an owning element since a valid owning element is required to qualify as
a CSS Transition or CSS Animation, regardless of the animation's original class.
(WebCore::removeAnimationFromMapForElement): Adding this helper to remove an animation from the provided animation map so
that animationWasRemovedFromElement() can call this with all of the various animation maps.
(WebCore::AnimationTimeline::animationWasRemovedFromElement): Check all of the various animation maps to see which may
contain the animation we're trying to remove as the owning element might have been cleared by the time this function is
called and looking at the animation's class would not be sufficient to determine which animation map the animation was in.
(WebCore::AnimationTimeline::removeDeclarativeAnimationFromListsForOwningElement): New function in which the logic from
animationWasRemovedFromElement() that dealt with removing animations from the list of running CSS Animations/Transitions as
well as completed CSS Transitions was factored out. This allowed us to also call this function from
DeclarativeAnimation::disassociateFromOwningElement().
(WebCore::AnimationTimeline::elementWasRemoved): We no longer need to remove an animation as canceling it will remove it
correctly when DocumentTimeline::updateAnimationsAndSendEvents() is called.
(WebCore::AnimationTimeline::updateCSSAnimationsForElement): Call cancelDeclarativeAnimation() instead of the removed
cancelOrRemoveDeclarativeAnimation() when a CSS Animation should be canceled.
(WebCore::AnimationTimeline::ensureRunningTransitionsByProperty): Now that we correctly remove transitions from the list
of running transitions once they've completed or have been canceled, we need a helper to always get a valid map of running
transitions for a given element as that map can be cleared while updateCSSTransitionsForElement() is running.
(WebCore::AnimationTimeline::updateCSSTransitionsForElement): Call cancelDeclarativeAnimation() instead of the removed
cancelOrRemoveDeclarativeAnimation() when a CSS Transition should be canceled. Additionally we always get the list of running
transitions for a given element as it can be cleared by a prior cancelation.
(WebCore::AnimationTimeline::cancelDeclarativeAnimation): New function replacing cancelOrRemoveDeclarativeAnimation() in which
we call the new DeclarativeAnimation::cancelFromStyle() function on the provided animation and then remove the animation from
all known lists, including the new list of all animations. We do this final part so that the animation gets re-added as if it
were a new animation since canceling a declarative animation via a style change removes its declarative-ness. This guarantees
that a declarative animation that is canceled through style but then resumed through the Web Animations API sorts after any
declarative animation with an owning element.
(WebCore::AnimationTimeline::relevantMapForAnimation): Deleted.
(WebCore::AnimationTimeline::cancelOrRemoveDeclarativeAnimation): Deleted.

animation/AnimationTimeline.h:

(WebCore::AnimationTimeline::timingModelDidChange): Deleted. This was left over in the patch where we implemented the "update
animations and send events" procedure.
(WebCore::AnimationTimeline::animations const): Deleted.

animation/CSSAnimation.cpp:

(WebCore::CSSAnimation::create): Some refactoring to make the handling of a declarative animation's owning element part of the
DeclarativeAnimation constructor.

animation/CSSTransition.cpp:

(WebCore::CSSTransition::create): Some refactoring to make the handling of a declarative animation's owning element part of the
DeclarativeAnimation constructor.

animation/DeclarativeAnimation.cpp:

(WebCore::DeclarativeAnimation::DeclarativeAnimation):
(WebCore::DeclarativeAnimation::tick): Make sure we disassociate from the animation's owning element once we transition from a
relevant state to an idle state. This will catch any changes made via the Web Animations API to a declarative animation when the
"update animations and send events" procedure is run.
(WebCore::DeclarativeAnimation::disassociateFromOwningElement): Remove this animation from the list of declarative animations on
the associated timeline and make owningElement() nullptr so that document.getAnimations() will know to sort this animation with other
Web Animations created via the Web Animations API.
(WebCore::DeclarativeAnimation::initialize):
(WebCore::DeclarativeAnimation::cancelFromStyle): New method called from AnimationTimeline::cancelDeclarativeAnimation() which
cancels the animation but also disassociates it from its owning element.
(WebCore::DeclarativeAnimation::invalidateDOMEvents):
(WebCore::DeclarativeAnimation::enqueueDOMEvent):

animation/DeclarativeAnimation.h:

(WebCore::DeclarativeAnimation::owningElement const):
(WebCore::DeclarativeAnimation::target const): Deleted.

animation/DocumentTimeline.cpp:

(WebCore::compareDeclarativeAnimationOwningElementPositionsInDocumentTreeOrder): Adding a new utility used when sorting both
CSS Transitions and CSS Animations by tree order when their owning element differ, with special logic for pseudo-elements.
(WebCore::DocumentTimeline::getAnimations const): Filter and sort animations according to their composite order.
(WebCore::DocumentTimeline::updateAnimationsAndSendEvents): Compile a list of transitions that move to a finished state to
the list of completed transitions so that they may be canceled correctly in AnimationTimeline::updateCSSTransitionsForElement().
(WebCore::DocumentTimeline::transitionDidComplete):

animation/DocumentTimeline.h:

LayoutTests:

Mark that the two document.getAnimations() tests for declarative animations are no longer flaky.

TestExpectations:

12:15 AM Changeset in webkit [237725] by zandobersek@gmail.com

2 edits in trunk/Source/WebCore

PNGImageDecoder: report no repetition for non-animated images
https://bugs.webkit.org/show_bug.cgi?id=191068

Reviewed by Michael Catanzaro.

When building with APNG support enabled, the
PNGImageDecoder::repetitionCount() method until now reported infinite
repetition count for all PNG images, even the ones that were not
animated. This is now changed so that no repetition is reported for
non-animated images.

platform/image-decoders/png/PNGImageDecoder.cpp:

(WebCore::PNGImageDecoder::repetitionCount const):

12:11 AM Changeset in webkit [237724] by zandobersek@gmail.com

2 edits in trunk/Source/WebDriver

[WPE] WebDriver: support validating and parsing the 'certificates' capability
https://bugs.webkit.org/show_bug.cgi?id=191014

Reviewed by Michael Catanzaro.

Adopt the same approach as in the GTK's WebDriverService implementation
for validating and parsing the 'certificates' WebDriver capability.

wpe/WebDriverServiceWPE.cpp:

(WebDriver::WebDriverService::platformValidateCapability const):
(WebDriver::WebDriverService::platformParseCapabilities const):

12:09 AM Changeset in webkit [237723] by Justin Fan

21 edits
9 copies
2 moves
5 adds in trunk

[WebGPU] Experimental prototype for MSL shaders
https://bugs.webkit.org/show_bug.cgi?id=191084

Reviewed by Dean Jackson.

Source/WebCore:

Begin implementation for WebGPUDevice and WebGPUShaderModule and associated descriptor objects.

Test: webgpu/webgpu-basics.html
Test: webgpu/shader-modules.html

CMakeLists.txt:
DerivedSources.make:
Modules/webgpu/GPUDevice.cpp:

(WebCore::GPUDevice::createShaderModule const):

Modules/webgpu/GPUDevice.h:

(WebCore::GPUDevice::platformDevice const):

Modules/webgpu/GPUShaderModule.h:

(WebCore::GPUShaderModule::platformShaderModule const):

Modules/webgpu/GPUShaderModuleDescriptor.h:
Modules/webgpu/WebGPU.cpp:

(WebCore::WebGPU::requestAdapter const):

Modules/webgpu/WebGPUAdapter.cpp:

(WebCore::WebGPUAdapter::create):
(WebCore::WebGPUAdapter::createDevice):

Modules/webgpu/WebGPUAdapter.h:
Modules/webgpu/WebGPUAdapter.idl:
Modules/webgpu/WebGPUDevice.cpp:

(WebCore::WebGPUDevice::create):
(WebCore::WebGPUDevice::WebGPUDevice):
(WebCore::WebGPUDevice::createShaderModule const):

Modules/webgpu/WebGPUDevice.h:
Modules/webgpu/WebGPUDevice.idl:
Modules/webgpu/WebGPUShaderModule.cpp:

(WebCore::WebGPUShaderModule::create):
(WebCore::WebGPUShaderModule::WebGPUShaderModule):

Modules/webgpu/WebGPUShaderModule.h:
Modules/webgpu/WebGPUShaderModule.idl:
Modules/webgpu/WebGPUShaderModuleDescriptor.h:
Modules/webgpu/WebGPUShaderModuleDescriptor.idl:
Modules/webgpu/WebGPUSwapChain.cpp:

(WebCore::WebGPUSwapChain::configure):

Modules/webgpu/WebGPUSwapChain.h:
Modules/webgpu/WebGPUSwapChain.idl:
Modules/webgpu/cocoa/GPUDeviceMetal.mm:

(WebCore::GPUDevice::create):
(WebCore::GPUDevice::GPUDevice):

Modules/webgpu/cocoa/GPUShaderModuleMetal.mm:

(WebCore::GPUShaderModule::create):
(WebCore::GPUShaderModule::GPUShaderModule):

Sources.txt:
SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
bindings/js/WebCoreBuiltinNames.h:
platform/Logging.h:

Source/WTF:

Disabling WebGPU on non-Cocoa platforms and iOS Simulator.

wtf/Platform.h:

LayoutTests:

webgpu/shader-modules.html: Added.
webgpu/shader-modules-expected.html: Added.
webgpu/webgpu-basics.html: Added.
webgpu/webgpu-basics-expected.html: Added.

12:04 AM Changeset in webkit [237722] by zandobersek@gmail.com

2 edits in trunk/Tools

Unreviewed follow-up to r237678.

wpe/jhbuild.modules: The patch element apparently has to be a child

of the branch in order for Jhbuild to properly detect and apply the
patch file.

Nov 1, 2018:

11:35 PM Changeset in webkit [237721] by jiewen_tan@apple.com

11 edits
1 delete in trunk/Source

Replace CommonRandom SPI with API
https://bugs.webkit.org/show_bug.cgi?id=191178
<rdar://problem/45722391>

Reviewed by Brent Fulgham.

Source/bmalloc:

bmalloc/CryptoRandom.cpp:

(bmalloc::ARC4RandomNumberGenerator::stir):

Source/WebCore:

The API is available since macOS 10.10 and iOS 10, and therefore it is safe to replace
all SPI usages with API.

No change of behaviors.

crypto/CommonCryptoUtilities.h:
crypto/mac/CryptoKeyMac.cpp:

(WebCore::CryptoKey::randomData):

crypto/mac/SerializedCryptoKeyWrapMac.mm:

(WebCore::createAndStoreMasterKey):
(WebCore::wrapSerializedCryptoKey):

page/Crypto.cpp:

(WebCore::Crypto::getRandomValues):

Source/WTF:

WTF.xcodeproj/project.pbxproj:
wtf/CMakeLists.txt:
wtf/RandomDevice.cpp:

(WTF::RandomDevice::cryptographicallyRandomValues):

wtf/spi/darwin/CommonCryptoSPI.h: Removed.

9:11 PM Changeset in webkit [237720] by Devin Rousso

5 edits in trunk

Web Inspector: View: introduce a didLayoutSubtree
https://bugs.webkit.org/show_bug.cgi?id=191176

Reviewed by Matt Baker.

Source/WebInspectorUI:

Introduce logic to allow subclasses of WI.View to perform logic after every WI.View in
their subtree has finished layout.

UserInterface/Views/View.js:

(WI.View.prototype.didLayoutSubtree): Added.
(WI.View.prototype._layoutSubtree):

UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype.layout):
(WI.NetworkTableContentView.prototype.didLayoutSubtree): Added.

LayoutTests:

inspector/view/resources/test-view.js:

(TestPage.registerInitializer.WI.TestView.prototype.layout):
(TestPage.registerInitializer.WI.TestView.prototype.didLayoutSubtree): Added.

8:50 PM Changeset in webkit [237719] by bshafiei@apple.com

7 edits in tags/Safari-607.1.12.1/Source

Versioning.

8:48 PM Changeset in webkit [237718] by bshafiei@apple.com

1 copy in tags/Safari-607.1.12.1

Tag Safari-607.1.12.1.

8:35 PM Changeset in webkit [237717] by Chris Dumez

34 edits in trunk/Source/WebCore

[WebIDL] Rename CallWith=ScriptState to CallWith=ExecState
https://bugs.webkit.org/show_bug.cgi?id=191162

Reviewed by Alex Christensen.

Rename CallWith=ScriptState to CallWith=ExecState in our Web IDL as ScriptState is no longer a thing
in modern WebKit. The implementation is actually passed an ExecState nowadays.

Modules/applepay/ApplePaySession.idl:
Modules/encryptedmedia/MediaKeyStatusMap.idl:
Modules/fetch/FetchBody.idl:
Modules/indexeddb/IDBCursor.idl:
Modules/indexeddb/IDBFactory.idl:
Modules/indexeddb/IDBIndex.idl:
Modules/indexeddb/IDBKeyRange.idl:
Modules/indexeddb/IDBObjectStore.idl:
Modules/mediastream/RTCPeerConnection.idl:
animation/Animatable.idl:
animation/KeyframeEffect.idl:
animation/KeyframeEffectReadOnly.idl:
bindings/scripts/CodeGeneratorJS.pm:

(GenerateCallWith):
(GenerateConstructorDefinition):

bindings/scripts/IDLAttributes.json:
bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::jsTestObjWithExecStateAttributeGetter):
(WebCore::jsTestObjWithExecStateAttribute):
(WebCore::setJSTestObjWithExecStateAttributeSetter):
(WebCore::setJSTestObjWithExecStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateAttributeGetter):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateAttributeSetter):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateWithSpacesAttributeGetter):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateWithSpacesAttributeSetter):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateWithSpacesAttribute):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoidBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoid):
(WebCore::jsTestObjPrototypeFunctionWithExecStateObjBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateObj):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoidExceptionBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoidException):
(WebCore::jsTestObjPrototypeFunctionWithExecStateObjExceptionBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateBody):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecState):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateObjExceptionBody):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateWithSpacesBody):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateWithSpaces):
(WebCore::jsTestObjWithScriptStateAttributeGetter): Deleted.
(WebCore::jsTestObjWithScriptStateAttribute): Deleted.
(WebCore::setJSTestObjWithScriptStateAttributeSetter): Deleted.
(WebCore::setJSTestObjWithScriptStateAttribute): Deleted.
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeGetter): Deleted.
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttribute): Deleted.
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeSetter): Deleted.
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute): Deleted.
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttributeGetter): Deleted.
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute): Deleted.
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttributeSetter): Deleted.
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoid): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObj): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidExceptionBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjExceptionBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptState): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateObjExceptionBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateObjException): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateWithSpacesBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateWithSpaces): Deleted.

bindings/scripts/test/TestObj.idl:
bindings/scripts/test/TestPromiseRejectionEvent.idl:
crypto/SubtleCrypto.idl:
dom/Element.idl:
dom/ErrorEvent.idl:
dom/MessagePort.idl:
dom/MouseEvent.idl:
html/HTMLCanvasElement.idl:
html/HTMLFrameElement.idl:
html/OffscreenCanvas.idl:
html/track/DataCue.idl:
inspector/CommandLineAPIHost.idl:
page/DOMWindow.idl:
page/RemoteDOMWindow.idl:
page/WindowOrWorkerGlobalScope.idl:
testing/Internals.idl:
workers/DedicatedWorkerGlobalScope.idl:
workers/Worker.idl:

7:04 PM Changeset in webkit [237716] by Ross Kirsling

2 edits in trunk/Tools

build-jsc --wincairo should update WinCairo libraries
https://bugs.webkit.org/show_bug.cgi?id=191170

Reviewed by Fujii Hironori.

Scripts/build-jsc:

6:24 PM Changeset in webkit [237715] by Alan Coon

1 copy in tags/Safari-606.3.4.0.1

Tag Safari-606.3.4.0.1.

6:13 PM Changeset in webkit [237714] by Fujii Hironori

18 edits
2 moves in trunk/Source

Rename <wtf/unicode/UTF8.h> to <wtf/unicode/UTF8Conversion.h> in order to avoid conflicting with ICU's unicode/utf8.h
https://bugs.webkit.org/show_bug.cgi?id=189693

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

API/JSClassRef.cpp: Replaced <wtf/unicode/UTF8.h> with <wtf/unicode/UTF8Conversion.h>.
API/JSStringRef.cpp: Ditto.
runtime/JSGlobalObjectFunctions.cpp: Ditto.
wasm/WasmParser.h: Ditto.

Source/WebCore:

No new tests because there's no behaviro changes.

platform/SharedBuffer.cpp: Replaced <wtf/unicode/UTF8.h> with <wtf/unicode/UTF8Conversion.h>.
xml/XSLTProcessorLibxslt.cpp: Ditto.
xml/parser/XMLDocumentParserLibxml2.cpp: Ditto.

Source/WebKit:

Shared/API/APIString.h: Replaced <wtf/unicode/UTF8.h> with <wtf/unicode/UTF8Conversion.h>.

Source/WTF:

WTF.xcodeproj/project.pbxproj: Replaced unicode/UTF8.{cpp,h} with unicode/UTF8Conversion.{cpp,h}.
wtf/CMakeLists.txt: Ditto.
wtf/text/AtomicStringImpl.cpp: Replaced <wtf/unicode/UTF8.h> with <wtf/unicode/UTF8Conversion.h>.
wtf/text/StringImpl.cpp: Ditto.
wtf/text/StringView.cpp: Ditto.
wtf/text/WTFString.cpp: Ditto.
wtf/unicode/UTF8Conversion.cpp: Renamed from Source/WTF/wtf/unicode/UTF8.cpp.
wtf/unicode/UTF8Conversion.h: Renamed from Source/WTF/wtf/unicode/UTF8.h.

5:58 PM Changeset in webkit [237713] by Alan Coon

2 edits in tags/Safari-607.1.10.8/Source/JavaScriptCore

Revert r237582. rdar://problem/45747609

5:58 PM Changeset in webkit [237712] by Alan Coon

3 edits
1 delete in tags/Safari-607.1.10.8/Source/JavaScriptCore

Revert r237583. rdar://problem/45747609

5:51 PM Changeset in webkit [237711] by wilander@apple.com

4 edits
1 add in trunk

In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
https://bugs.webkit.org/show_bug.cgi?id=191119
<rdar://problem/44176965>

Reviewed by Chris Dumez.

Source/WebCore:

New API test added.

loader/ResourceLoadObserver.cpp:

(WebCore::ResourceLoadObserver::logSubresourceLoading):
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):

Tools:

This is an API test for a WebKitLegacy WebView that is first closed and then
JavaScript is handed a keyboard event.

TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added.

(-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]):
(-[KeyboardEventListener handleEvent:]):
(TestWebKitAPI::TEST):

5:46 PM Changeset in webkit [237710] by Alan Coon

7 edits in tags/Safari-607.1.10.8/Source

Versioning.

5:44 PM Changeset in webkit [237709] by Alan Coon

1 copy in tags/Safari-607.1.10.8

New tag.

5:27 PM Changeset in webkit [237708] by Devin Rousso

7 edits in trunk/Source

Web Inspector: Network: remove unnecessary media event tracking
https://bugs.webkit.org/show_bug.cgi?id=191174

Reviewed by Joseph Pecoraro.

Source/WebCore:

No new tests, as this simply removes some event listeners for the WebInspector frontend.

inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::addEventListenersToNode):

Source/WebInspectorUI:

Renames "Group by Node" to "Group Media Requests" for clarity.

UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype.reset):
(WI.NetworkTableContentView.prototype.showRepresentedObject):
(WI.NetworkTableContentView.prototype.networkDetailViewClose):
(WI.NetworkTableContentView.prototype._populateNameCell):
(WI.NetworkTableContentView.prototype._populateWaterfallGraph.createDOMEventLine):
(WI.NetworkTableContentView.prototype._populateWaterfallGraph):
(WI.NetworkTableContentView.prototype.layout):
(WI.NetworkTableContentView.prototype._entryForDOMNode):
(WI.NetworkTableContentView.prototype._handleGroupByDOMNodeCheckedDidChange):
(WI.NetworkTableContentView.prototype._restoreSelectedRow):
(WI.NetworkTableContentView.prototype._handleResourceEntryMousedownWaterfall):
(WI.NetworkTableContentView.prototype._handleNodeEntryMousedownWaterfall):
(WI.NetworkTableContentView.prototype._handleMousedownWaterfall):

UserInterface/Views/NetworkTableContentView.css:

(.network-table .data-container .cell.name .range): Added.
(.network-table .data-container .cell.name .range::before): Added.
(.network-table:focus .data-container li.selected .cell.name .range): Added.
(@media (prefers-dark-interface) .network-table .data-container .cell.name .range): Added.
Always display the "Byte Range" title as a "subtitle", regardless of the media requests
setting being toggled.
Drive-by: update the position of the waterfall popover whenever the time range changes.
Drive-by: close the details view if a node is selected and the media requests setting is
turned off.

UserInterface/Views/Popover.js:

(WI.Popover.prototype.resize): Added.
(WI.Popover.prototype.handleEvent):

Localizations/en.lproj/localizedStrings.js:

5:02 PM Changeset in webkit [237707] by keith_miller@apple.com

2 edits in trunk/Source/JavaScriptCore

Unreviewed, JavaScriptCore should only guarantee to produce a
modulemap if we are building for iOSMac.

Configurations/JavaScriptCore.xcconfig:

4:49 PM Changeset in webkit [237706] by Devin Rousso

2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'mouseBlock.addEventListener')
https://bugs.webkit.org/show_bug.cgi?id=191020

Reviewed by Joseph Pecoraro.

UserInterface/Views/TimelineRuler.js:

(WI.TimelineRuler):
Since undefined is not a number, it isn't less than 0, which caused us to divide by
undefined (equivalent to dividing by 0), resulting in NaN.

4:24 PM Changeset in webkit [237705] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

Uncaught Exception: TypeError: undefined is not an object (evaluating 'WI.modifierKeys.metaKey') (at ScopeBarItem.js:87:67)
https://bugs.webkit.org/show_bug.cgi?id=191173

Reviewed by Devin Rousso.

WI.modifierKeys was accessed before it was initialized. Move it from WI.contentLoaded to WI.loaded,
which happens before WI.contentLoaded.

UserInterface/Base/Main.js:

(WI.loaded):
(WI.contentLoaded):

4:22 PM Changeset in webkit [237704] by dbates@webkit.org

2 edits in trunk/Source/WebKit

Cleanup: Extraneous platform guarding of -_setUpSQLiteDatabaseTrackerClient
https://bugs.webkit.org/show_bug.cgi?id=191124

Reviewed by Tim Horton.

Remove the platform guard around the call to -_setUpSQLiteDatabaseTrackerClient as the
implementation of that message is already guarded.

UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _initializeWithConfiguration:]):

4:19 PM Changeset in webkit [237703] by Ryan Haddad

2 edits in trunk/Source/WebKit

Unreviewed, attempt to fix the build with recent SDKs.

Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:

(WebKit::XPCServiceInitializer):

2:40 PM Changeset in webkit [237702] by Chris Dumez

13 edits in trunk

Location object sans browsing context
https://bugs.webkit.org/show_bug.cgi?id=191060

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window-expected.txt:

Rebase WPT test now that all checks are passing.

web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window.js:

Fix bug in WPT test (https://github.com/web-platform-tests/wpt/pull/13854)

web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window-expected.txt:

Source/WebCore:

As per https://github.com/whatwg/html/pull/4076, a Location object's URL should be "about:blank" when
it does not have a browsing context (Frame), not "".

No new tests, rebaselined existing tests.

page/Location.cpp:

(WebCore::Location::url const):
(WebCore::Location::href const):
(WebCore::Location::protocol const):
(WebCore::Location::host const):
(WebCore::Location::hostname const):
(WebCore::Location::port const):
(WebCore::Location::pathname const):
(WebCore::Location::search const):
(WebCore::Location::origin const):
(WebCore::Location::hash const):

LayoutTests:

Update existing tests to reflect behavior change.

http/tests/dom/same-origin-detached-window-properties-expected.txt:
http/tests/dom/same-origin-detached-window-properties.html:
http/tests/security/xss-DENIED-script-inject-into-inactive-window.html:
http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html:
http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html:
http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html:

2:19 PM Changeset in webkit [237701] by Ross Kirsling

3 edits in trunk/LayoutTests

[WinCairo] Unreviewed layout test gardening.

(Also remove one outdated global test failure.)

TestExpectations:
platform/wincairo/TestExpectations:

2:11 PM Changeset in webkit [237700] by sihui_liu@apple.com

48 edits
3 adds in trunk

Add a storage limit for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=190598
<rdar://problem/44654715>

Reviewed by Chris Dumez.

Source/WebCore:

Set a storage limit in IndexedDB for each pair of mainFrameOrigin and openingOrigin.
IndexedDB will return a QuotaExceededError if limit is reached.

If the size of free disk space is over 1 GB, the default limit is 500 MB; otherwise it is
half the free disk space.

Test: storage/indexeddb/storage-limit.html

Modules/indexeddb/server/IDBBackingStore.h:
Modules/indexeddb/server/IDBServer.cpp:

(WebCore::IDBServer::IDBServer::createBackingStore):
(WebCore::IDBServer::IDBServer::setPerOriginQuota):

Modules/indexeddb/server/IDBServer.h:

(WebCore::IDBServer::IDBServer::perOriginQuota const):

Modules/indexeddb/server/MemoryIDBBackingStore.h:
Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:

(WebCore::IDBServer::SQLiteIDBBackingStore::SQLiteIDBBackingStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::quotaForOrigin const):
(WebCore::IDBServer::SQLiteIDBBackingStore::maximumSize const):
(WebCore::IDBServer::SQLiteIDBBackingStore::beginTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::renameObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::renameIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedSetKeyGeneratorValue):

Modules/indexeddb/server/SQLiteIDBBackingStore.h:
Modules/indexeddb/server/UniqueIDBDatabase.cpp:

(WebCore::IDBServer::UniqueIDBDatabase::setQuota):

Modules/indexeddb/server/UniqueIDBDatabase.h:

Source/WebKit:

Add SPI for testing.

NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::idbServer):
(WebKit::NetworkProcess::setIDBPerOriginQuota):

NetworkProcess/NetworkProcess.h:
NetworkProcess/NetworkProcess.messages.in:
UIProcess/API/C/WKContext.cpp:

(WKContextSetIDBPerOriginQuota):

UIProcess/API/C/WKContextPrivate.h:
UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::setIDBPerOriginQuota):

UIProcess/WebProcessPool.h:

Source/WebKitLegacy:

Storage/WebDatabaseProvider.cpp:

(WebDatabaseProvider::idbConnectionToServerForSession):
(WebDatabaseProvider::setIDBPerOriginQuota):

Storage/WebDatabaseProvider.h:

Source/WebKitLegacy/mac:

Storage/WebDatabaseManager.mm:

(-[WebDatabaseManager setIDBPerOriginQuota:]):

Storage/WebDatabaseManagerPrivate.h:

Source/WebKitLegacy/win:

Interfaces/IWebDatabaseManager.idl:
WebDatabaseManager.cpp:

(WebDatabaseManager::setIDBPerOriginQuota):

WebDatabaseManager.h:

Tools:

Add API for testing.

DumpRenderTree/TestRunner.cpp:

(setIDBPerOriginQuotaCallback):
(TestRunner::staticFunctions):

DumpRenderTree/TestRunner.h:
DumpRenderTree/mac/TestRunnerMac.mm:

(TestRunner::setIDBPerOriginQuota):

DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setIDBPerOriginQuota):

WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
WebKitTestRunner/InjectedBundle/TestRunner.cpp:

(WTR::TestRunner::setIDBPerOriginQuota):

WebKitTestRunner/InjectedBundle/TestRunner.h:
WebKitTestRunner/TestController.cpp:

(WTR::TestController::setIDBPerOriginQuota):

WebKitTestRunner/TestController.h:
WebKitTestRunner/TestInvocation.cpp:

(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

Some tests will fail after adding storage limit to IndexedDB, so we need to reduce their
size and rebase their expectations.

storage/indexeddb/key-type-array-expected.txt:
storage/indexeddb/key-type-array-private-expected.txt:
storage/indexeddb/modern/idbkey-array-equality-expected.txt:
storage/indexeddb/modern/idbkey-array-equality-private-expected.txt:
storage/indexeddb/modern/resources/idbkey-array-equality.js:

(request.onsuccess):
(request.onerror):
(doAdd):

storage/indexeddb/prefetch-invalidation-expected.txt:
storage/indexeddb/prefetch-invalidation-private-expected.txt:
storage/indexeddb/resources/key-type-array.js:

(testValidArrayKeys.getreq.onsuccess):
(testValidArrayKeys.putreq.onsuccess):
(testValidArrayKeys.testArrayPutGet):

storage/indexeddb/resources/prefetch-invalidation.js:

(cursorRequest.onsuccess):
(continue50Times):
(continue100Times): Deleted.

storage/indexeddb/resources/storage-limit.js: Added.

(prepareDatabase):
(onOpenSuccess.request.onerror):
(onOpenSuccess.request.onsuccess):
(onOpenSuccess):

storage/indexeddb/storage-limit-expected.txt: Added.
storage/indexeddb/storage-limit.html: Added.

1:53 PM Changeset in webkit [237699] by Chris Dumez

6 edits in trunk

[PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
https://bugs.webkit.org/show_bug.cgi?id=191076

Reviewed by Geoffrey Garen.

Source/WebKit:

WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping.
The client can request a new load synchronously after answering the policy decision, in which case we'd end up loading
the wrong URL.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::receivedNavigationPolicyDecision):

UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::processForNavigation):
(WebKit::WebProcessPool::processForNavigationInternal):

UIProcess/WebProcessPool.h:

Tools:

Add API test coverage.

TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

(-[PSONNavigationDelegate init]):
(-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):

1:46 PM Changeset in webkit [237698] by Chris Dumez

2 edits in trunk/LayoutTests

Unreviewed, mark a couple of newly imported WPT tests as flaky on Mac WK1.

platform/mac-wk1/TestExpectations:

1:35 PM Changeset in webkit [237697] by Justin Michaud

34 edits
6 adds in trunk

CSS Custom Properties API Should Support syntax="*" and "<length>", and handle cycles properly
https://bugs.webkit.org/show_bug.cgi?id=191042

Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

web-platform-tests/css/css-properties-values-api/register-property-syntax-parsing-expected.txt:
web-platform-tests/css/css-properties-values-api/registered-properties-inheritance-expected.txt:
web-platform-tests/css/css-properties-values-api/registered-property-cssom-expected.txt:
web-platform-tests/css/css-properties-values-api/typedom.tentative-expected.txt:
web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-cycles-expected.txt:
web-platform-tests/css/css-properties-values-api/var-reference-registered-properties-expected.txt:

Source/WebCore:

Refactor code so that:

All properties applied in StyleResolver::applyMatchedProperties are only applied once.
Custom properties are only resolved once, in StyleResolver, when they are applied to the RenderStyle. They were previously resolved every time they were referenced, and again in RenderStyle.
The font-size property is applied after its variable references, but before custom properties that depend on it.
Cycles are detected at the same time as resolution.
MutableStyleProperties' custom properties cannot be set from Javascript or WebKitLegacy if they do not parse for the property's type. If they contain var(--...) references, however, then they can be set because we cannot check if the references are valid from setProperty. This behaviour matches chrome, but is not documented in the spec.
Custom property values have more explicit resolved/unresolved state.
RenderStyle only ever holds resolved custom properties, and StyleResolver::CascadedProperties only holds unresolved properties.

Tests: css-custom-properties-api/crash.html

css-custom-properties-api/cycles.html
css-custom-properties-api/inline.html

css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::customPropertyValue):

css/CSSCustomPropertyValue.cpp:

(WebCore::CSSCustomPropertyValue::equals const):
(WebCore::CSSCustomPropertyValue::customCSSText const):
(WebCore::CSSCustomPropertyValue::tokens const):
(WebCore::CSSCustomPropertyValue::checkVariablesForCycles const): Deleted.
(WebCore::CSSCustomPropertyValue::resolveVariableReferences const): Deleted.
(WebCore::CSSCustomPropertyValue::setResolvedTypedValue): Deleted.

css/CSSCustomPropertyValue.h:
css/CSSRegisteredCustomProperty.cpp:

(WebCore::CSSRegisteredCustomProperty::CSSRegisteredCustomProperty):

css/CSSRegisteredCustomProperty.h:
css/CSSVariableData.cpp:

(WebCore::CSSVariableData::CSSVariableData):
(WebCore::CSSVariableData::consumeAndUpdateTokens): Deleted.
(WebCore::CSSVariableData::checkVariablesForCycles const): Deleted.
(WebCore::CSSVariableData::checkVariablesForCyclesWithRange const): Deleted.
(WebCore::CSSVariableData::resolveVariableFallback const): Deleted.
(WebCore::CSSVariableData::resolveVariableReference const): Deleted.
(WebCore::CSSVariableData::resolveVariableReferences const): Deleted.
(WebCore::CSSVariableData::resolveTokenRange const): Deleted.

css/CSSVariableData.h:

(WebCore::CSSVariableData::create):
(WebCore::CSSVariableData::createResolved): Deleted.
(WebCore::CSSVariableData::needsVariableResolution const): Deleted.
(WebCore::CSSVariableData::CSSVariableData): Deleted.

css/CSSVariableReferenceValue.cpp:

(WebCore::resolveVariableFallback):
(WebCore::resolveVariableReference):
(WebCore::resolveTokenRange):
(WebCore::CSSVariableReferenceValue::resolveVariableReferences const):
(WebCore::CSSVariableReferenceValue::checkVariablesForCycles const): Deleted.

css/CSSVariableReferenceValue.h:

(WebCore::CSSVariableReferenceValue::create):
(WebCore::CSSVariableReferenceValue::equals const):
(WebCore::CSSVariableReferenceValue::variableDataValue const): Deleted.

css/DOMCSSRegisterCustomProperty.cpp:

(WebCore::DOMCSSRegisterCustomProperty::registerProperty):

css/PropertySetCSSStyleDeclaration.cpp:

(WebCore::PropertySetCSSStyleDeclaration::setProperty):

css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyInitialCustomProperty):
(WebCore::StyleBuilderCustom::applyValueCustomProperty):

css/StyleProperties.cpp:

(WebCore::MutableStyleProperties::setCustomProperty):

css/StyleProperties.h:
css/StyleResolver.cpp:

(WebCore::StyleResolver::State::setStyle):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::applyPropertyToCurrentStyle):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::resolvedVariableValue const):
(WebCore::StyleResolver::CascadedProperties::applyDeferredProperties):
(WebCore::StyleResolver::CascadedProperties::Property::apply):
(WebCore::StyleResolver::applyCascadedCustomProperty):
(WebCore::StyleResolver::applyCascadedProperties):

css/StyleResolver.h:
css/parser/CSSParser.cpp:

(WebCore::CSSParser::parseValueWithVariableReferences):

css/parser/CSSParser.h:
css/parser/CSSPropertyParser.cpp:

(WebCore::CSSPropertyParser::CSSPropertyParser):
(WebCore::CSSPropertyParser::canParseTypedCustomPropertyValue):
(WebCore::CSSPropertyParser::parseTypedCustomPropertyValue):
(WebCore::CSSPropertyParser::collectParsedCustomPropertyValueDependencies):
(WebCore::CSSPropertyParser::parseValueStart):
(WebCore::CSSPropertyParser::parseSingleValue):

css/parser/CSSPropertyParser.h:
css/parser/CSSVariableParser.cpp:

(WebCore::CSSVariableParser::parseDeclarationValue):

dom/ConstantPropertyMap.cpp:

(WebCore::ConstantPropertyMap::setValueForProperty):
(WebCore::variableDataForPositivePixelLength):
(WebCore::variableDataForPositiveDuration):

rendering/style/RenderStyle.cpp:

(WebCore::RenderStyle::checkVariablesInCustomProperties): Deleted.

rendering/style/RenderStyle.h:

(WebCore::RenderStyle::setInheritedCustomPropertyValue):
(WebCore::RenderStyle::setNonInheritedCustomPropertyValue):

rendering/style/StyleCustomPropertyData.h:

(WebCore::StyleCustomPropertyData::operator== const):
(WebCore::StyleCustomPropertyData::setCustomPropertyValue):
(WebCore::StyleCustomPropertyData::StyleCustomPropertyData):
(): Deleted.

LayoutTests:

css-custom-properties-api/crash-expected.txt: Added.
css-custom-properties-api/crash.html: Added.
css-custom-properties-api/cycles-expected.txt: Added.
css-custom-properties-api/cycles.html: Added.
css-custom-properties-api/inline-expected.txt: Added.
css-custom-properties-api/inline.html: Added.

12:49 PM Changeset in webkit [237696] by guijemont@igalia.com

28 edits in trunk

Skip tests on arm/mips that time out now we're running on CLoop

Unreviewed gardening.

Since the JIT is temporarily disabled on 32-bit platforms, these tests
time out on the bots and need to be disabled. There's more tests
disabled on arm because the timeout is longer on the mips bot (as the
device is slower to start with), so many of the tests don't time out
there.

JSTests:

microbenchmarks/getter-richards.js: disable on arm and mips.
stress/op_add.js: disable on arm.
stress/op_bitand.js: disable on arm.
stress/op_bitor.js: disable on arm.
stress/op_bitxor.js: disable on arm.
stress/op_lshift-ConstVar.js: disable on arm.
stress/op_lshift-VarConst.js: disable on arm.
stress/op_lshift-VarVar.js: disable on arm.
stress/op_mod-ConstVar.js: disable on arm.
stress/op_mod-VarConst.js: disable on arm.
stress/op_mod-VarVar.js: disable on arm.
stress/op_mul-ConstVar.js: disable on arm.
stress/op_mul-VarConst.js: disable on arm.
stress/op_mul-VarVar.js: disable on arm.
stress/op_rshift-ConstVar.js: disable on arm.
stress/op_rshift-VarConst.js: disable on arm.
stress/op_rshift-VarVar.js: disable on arm.
stress/op_sub-ConstVar.js: disable on arm.
stress/op_sub-VarConst.js: disable on arm.
stress/op_sub-VarVar.js: disable on arm.
stress/op_urshift-ConstVar.js: disable on arm.
stress/op_urshift-VarConst.js: disable on arm.
stress/op_urshift-VarVar.js: disable on arm.
stress/spread-forward-call-varargs-stack-overflow.js: disable on arm.
stress/value-to-boolean.js: disable on arm and mips.

LayoutTests:

js/script-tests/regress-139548.js: disable on arm and mips.

12:13 PM Changeset in webkit [237695] by Nikita Vasilyev

2 edits in trunk/Source/WebInspectorUI

REGRESSION(r237652): Web Inspector: dumpInspectorProtocolMessages is always enabled
https://bugs.webkit.org/show_bug.cgi?id=191161

Reviewed by Joseph Pecoraro.

UserInterface/Protocol/InspectorBackend.js:

(InspectorBackendClass.prototype.get dumpInspectorProtocolMessages):

12:12 PM Changeset in webkit [237694] by Devin Rousso

4 edits in trunk/LayoutTests

Web Inspector: fix debug WK1 test failures for WI.ObjectStore
https://bugs.webkit.org/show_bug.cgi?id=191158

Reviewed by Joseph Pecoraro.

inspector/unit-tests/objectStore/delete.html:
inspector/unit-tests/objectStore/deleteObject.html:
inspector/unit-tests/objectStore/resources/objectStore-utilities.js:

(TestPage.registerInitializer):

11:58 AM Changeset in webkit [237693] by Chris Dumez

5 edits
18 adds
3 deletes in trunk/LayoutTests

Resync html/browsers/history/the-location-interface web platform tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=191139

Reviewed by Alex Christensen.

Resync html/browsers/history/the-location-interface web platform tests from upstream 8295368c82.

web-platform-tests/html/browsers/history/the-location-interface/assign_after_load-expected.txt: Added.
web-platform-tests/html/browsers/history/the-location-interface/assign_after_load.html: Added.
web-platform-tests/html/browsers/history/the-location-interface/assign_before_load-expected.txt: Added.
web-platform-tests/html/browsers/history/the-location-interface/assign_before_load.html: Added.
web-platform-tests/html/browsers/history/the-location-interface/location-origin-idna.sub.window-expected.txt: Added.
web-platform-tests/html/browsers/history/the-location-interface/location-origin-idna.sub.window.html: Added.
web-platform-tests/html/browsers/history/the-location-interface/location_assign-expected.txt: Added.
web-platform-tests/html/browsers/history/the-location-interface/location_assign.html: Added.
web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window-expected.txt: Added.
web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window.html: Added.
web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window.js: Added.

(test):
(bcLessLocation):
(forEach.testSetup.testSetup.values.forEach.value.test):
(string_appeared_here.forEach.method.string_appeared_here.forEach.value.test):

web-platform-tests/html/browsers/history/the-location-interface/non-automated/w3c-import.log:
web-platform-tests/html/browsers/history/the-location-interface/per-global.window-expected.txt: Added.
web-platform-tests/html/browsers/history/the-location-interface/per-global.window.html: Added.
web-platform-tests/html/browsers/history/the-location-interface/reload_post_1-1.html: Removed.
web-platform-tests/html/browsers/history/the-location-interface/reload_post_1-expected.txt: Removed.
web-platform-tests/html/browsers/history/the-location-interface/reload_post_1.html: Removed.
web-platform-tests/html/browsers/history/the-location-interface/resources/reload_post_1-1.py: Added.

(main):

web-platform-tests/html/browsers/history/the-location-interface/resources/w3c-import.log:
web-platform-tests/html/browsers/history/the-location-interface/w3c-import.log:

11:57 AM Changeset in webkit [237692] by Nikita Vasilyev

3 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: Toggle selected properties by pressing Space or Command+/
https://bugs.webkit.org/show_bug.cgi?id=181145
<rdar://problem/36203388>

Reviewed by Brian Burg.

Pressing Space key or Command-/ toggles (comments out or uncomments) selected properties.

This patch only works with "Enable Selection of Multiple Properties" checked. It shouldn't introduce any
changes when this setting is unchecked.

UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.get selectionRange):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.selectProperties):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyCopy):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._handleKeyDown):

UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty):
(WI.SpreadsheetStyleProperty.prototype.update): Renamed from _update.
(WI.SpreadsheetStyleProperty.prototype.updateStatus):
(WI.SpreadsheetStyleProperty.prototype.applyFilter):
(WI.SpreadsheetStyleProperty.prototype.handleCopyEvent):
Make update method public. No other changes were made.

11:49 AM Changeset in webkit [237691] by commit-queue@webkit.org

6 edits in trunk

[CG] Adopt CG SPI for non-even cornered rounded rects
https://bugs.webkit.org/show_bug.cgi?id=190155

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2018-11-01
Reviewed by Simon Fraser.

Source/WebCore:

Instead of creating bezier curves for the non-even corners of the rounded
rects, we should use the optimized SPI provided by CG.

platform/graphics/cg/PathCG.cpp:

(WebCore::Path::platformAddPathForRoundedRect):

Source/WebCore/PAL:

pal/spi/cg/CoreGraphicsSPI.h:

LayoutTests:

This test fails on iOS simulator because of just one pixel difference
between drawing a shadow of the element and drawing a copy of the element.
This failure happens on iOS and does not happen on macOS because we don't
use accelerated drawing for macOS testing but we use it for iOS testing.

platform/ios/TestExpectations:

11:33 AM WebKitGTK/2.22.x edited by Adrian Perez de Castro

(diff)

11:32 AM Changeset in webkit [237690] by Adrian Perez de Castro

2 edits in releases/WebKitGTK/webkit-2.22/Tools

Merged r237680 - Fix build with VIDEO and WEB_AUDIO disabled
https://bugs.webkit.org/show_bug.cgi?id=191147
<rdar://problem/45726710>

Unreviewed build fix.

This adds the missing compilation guards in the WPE MiniBrowser.

MiniBrowser/wpe/main.cpp:

(main): Condition GST includes and calls.

11:32 AM Changeset in webkit [237689] by Adrian Perez de Castro

8 edits in releases/WebKitGTK/webkit-2.22

Merged r237677 - Fix build with VIDEO and WEB_AUDIO disabled
https://bugs.webkit.org/show_bug.cgi?id=191147

Reviewed by Philippe Normand.

Source/WebCore:

Supported or not, there were a few build fixes needed
to be able to build WebKit with media disabled. Mostly
low-hanging fruits.

Modules/mediasource/VideoPlaybackQuality.cpp:
Modules/mediasource/VideoPlaybackQuality.h:
Modules/mediasource/VideoPlaybackQuality.idl:
dom/Document.cpp:

(WebCore::Document::dispatchFullScreenChangeOrErrorEvent):

inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):

inspector/agents/InspectorDOMAgent.h:
rendering/RenderThemeGtk.cpp:

Tools:

MiniBrowser/gtk/main.c:

(main): Condition GST includes and calls

11:18 AM Changeset in webkit [237688] by youenn@apple.com

4 edits in trunk

RTCTrackEvent.streams should be SameObject
https://bugs.webkit.org/show_bug.cgi?id=191130

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

web-platform-tests/webrtc/RTCTrackEvent-constructor-expected.txt:

Source/WebCore:

Mimick SameObject using CachedAttribute.
Covered by rebased test.

Modules/mediastream/RTCTrackEvent.idl:

11:02 AM Changeset in webkit [237687] by Jon Davis

2 edits in trunk/Websites/webkit.org

Prevent homepage animation for users that prefer reduced motion
https://bugs.webkit.org/show_bug.cgi?id=188211

Reviewed by Timothy Hatcher.

wp-content/themes/webkit/front-header.php:

10:35 AM Changeset in webkit [237686] by Alan Coon

7 edits in branches/safari-606.3.4.2-branch/Source

Versioning.

10:33 AM Changeset in webkit [237685] by Alan Coon

7 edits in branches/safari-606.3.4.1-branch/Source

Versioning.

10:30 AM Changeset in webkit [237684] by Alan Coon

7 edits in branches/safari-606.3.4.0-branch/Source

Versioning.

10:09 AM Changeset in webkit [237683] by Chris Dumez

5 edits
3 adds in trunk

[PSON] Unable to submit a file in FormData cross-site
https://bugs.webkit.org/show_bug.cgi?id=191138

Reviewed by Alex Christensen.

Source/WebKit:

When PSON is enabled, we are unable to submit a file in FormData cross-site. Although we encode the
request body over IPC since r237639, we're missing the right sandbox extensions for its to work for
files.

Update FormDataReference encoder to pass along the necessary sandbox extensions for files in the
FormData, and have its decoder consume those extensions so that the recipient has access to those
files. Also update LoadParameters's IPC encoder / decoder to encoder an IPC::FormDataReference
(which encodes both FormData and sandbox extensions) instead of a FormData.

Platform/IPC/FormDataReference.h:

(IPC::FormDataReference::encode const):
(IPC::FormDataReference::decode):

Shared/LoadParameters.cpp:

(WebKit::LoadParameters::encode const):
(WebKit::LoadParameters::decode):

LayoutTests:

Add layout test coverage.

http/tests/misc/form-submit-file-cross-site-expected.txt:
http/tests/misc/form-submit-file-cross-site.html:

9:40 AM Changeset in webkit [237682] by Claudio Saavedra

2 edits in trunk/Source/WebKit

ERROR: ResourceLoadStatisticsPersistentStorage: Unable to delete statistics file
https://bugs.webkit.org/show_bug.cgi?id=191152

Reviewed by Chris Dumez.

The statistics file is not created unconditionally, so
make sure it exists before logging an error.

UIProcess/ResourceLoadStatisticsPersistentStorage.cpp:

(WebKit::ResourceLoadStatisticsPersistentStorage::clear):
Check that the file exists before logging an error.

9:11 AM Changeset in webkit [237681] by Devin Rousso

3 edits in trunk/LayoutTests

Unreviewed test fix after r237670.

inspector/canvas/setRecordingAutoCaptureFrameCount-expected.txt:
inspector/canvas/setRecordingAutoCaptureFrameCount.html:

8:21 AM WebKitGTK/2.22.x edited by Adrian Perez de Castro

(diff)

8:19 AM Changeset in webkit [237680] by Adrian Perez de Castro

2 edits in trunk/Tools

Fix build with VIDEO and WEB_AUDIO disabled
https://bugs.webkit.org/show_bug.cgi?id=191147
<rdar://problem/45726710>

Unreviewed build fix.

This adds the missing compilation guards in the WPE MiniBrowser.

MiniBrowser/wpe/main.cpp:

(main): Condition GST includes and calls.

7:20 AM Changeset in webkit [237679] by Alan Bujtas

12 edits
2 adds in trunk

[LFC][IFC] Add support for inline-block elements.
https://bugs.webkit.org/show_bug.cgi?id=191143

Reviewed by Antti Koivisto.

Source/WebCore:

This patch add support for laying out non-shrink-to-width inline-block elements.

Test: fast/inline/simple-inline-block.html

layout/FormattingContext.h:

(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::contentHeightForFormattingContextRoot):
(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):

layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):

layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockHeightAndMargin):

layout/layouttree/LayoutInlineContainer.cpp:

(WebCore::Layout::InlineContainer::establishesInlineFormattingContext const):

layout/layouttree/LayoutInlineContainer.h:
layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::TreeBuilder::createSubTree):

Tools:

LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

fast/inline/simple-inline-block-expected.txt: Added.
fast/inline/simple-inline-block.html: Added.
platform/ios/TestExpectations:

6:35 AM Changeset in webkit [237678] by Claudio Saavedra

2 edits
1 add in trunk/Tools

[WPE] Add missing libsoup patch to jhbuild
https://bugs.webkit.org/show_bug.cgi?id=191149

Reviewed by Žan Doberšek.

wpe/jhbuild.modules:
wpe/patches/libsoup-soup-socket-fix-critical-warning-when-the-peer-certi.patch: Added.

5:14 AM WebKitGTK/2.22.x edited by Adrian Perez de Castro

(diff)

4:29 AM WebKitGTK/2.22.x edited by Claudio Saavedra

(diff)

4:27 AM Changeset in webkit [237677] by Claudio Saavedra

10 edits in trunk

Fix build with VIDEO and WEB_AUDIO disabled
https://bugs.webkit.org/show_bug.cgi?id=191147

Reviewed by Philippe Normand.

Source/WebCore:

Supported or not, there were a few build fixes needed
to be able to build WebKit with media disabled. Mostly
low-hanging fruits.

Modules/mediasource/VideoPlaybackQuality.cpp:
Modules/mediasource/VideoPlaybackQuality.h:
Modules/mediasource/VideoPlaybackQuality.idl:
dom/Document.cpp:

(WebCore::Document::dispatchFullScreenChangeOrErrorEvent):

inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::didCreateFrontendAndBackend):

inspector/agents/InspectorDOMAgent.h:
rendering/RenderThemeGtk.cpp:

Tools:

MiniBrowser/gtk/main.c:

(main): Condition GST includes and calls

3:03 AM Changeset in webkit [237676] by Claudio Saavedra

2 edits in trunk/Source/WebKit

[GLIB] Silent a build warning when not using Wayland

Unreviewed.

UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

2:27 AM Changeset in webkit [237675] by commit-queue@webkit.org

2 edits in trunk/LayoutTests

MediaRecorder should fire dataavailable event when all tracks are ended and stop() is called
https://bugs.webkit.org/show_bug.cgi?id=190778
<rdar://problem/45703574>

Patch by YUHAN WU <yuhan_wu@apple.com> on 2018-11-01
Reviewed by Youenn Fablet.

Remove share FileReader object between three asynchronous tests which might cause flaky failure.
We will need to fix all the falky failures in this test after we implement timeslice.

http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html:

1:51 AM Changeset in webkit [237674] by fred.wang@free.fr

2 edits in trunk/Source/WebKit

[WebAuthN] Make AuthenticatorManager
https://bugs.webkit.org/show_bug.cgi?id=189279

Unreviewed build fix.

Patch by Frederic Wang <fwang@igalia.com> on 2018-11-01

UIProcess/WebAuthentication/Cocoa/LocalConnection.h: Add missing headers.

Oct 31, 2018:

9:30 PM Changeset in webkit [237673] by bshafiei@apple.com

1 copy in branches/safari-606.3.4.2-branch

New branch.

9:30 PM Changeset in webkit [237672] by bshafiei@apple.com

1 copy in branches/safari-606.3.4.1-branch

New branch.

9:18 PM Changeset in webkit [237671] by bshafiei@apple.com

1 copy in branches/safari-606.3.4.0-branch

New branch.

9:13 PM Changeset in webkit [237670] by Devin Rousso

25 edits
2 adds in trunk

Web Inspector: Canvas: create a setting for auto-recording newly created contexts
https://bugs.webkit.org/show_bug.cgi?id=190856

Reviewed by Brian Burg.

Source/JavaScriptCore:

inspector/protocol/Canvas.json:

Add setRecordingAutoCaptureFrameCount command for setting the number of frames to record
immediately after a context is created.

inspector/protocol/Recording.json:

Add creation value for Initiator enum.

Source/WebCore:

Test: inspector/canvas/setRecordingAutoCaptureFrameCount.html

inspector/agents/InspectorCanvasAgent.h:

(WebCore::InspectorCanvasAgent::RecordingOptions): Added.

inspector/agents/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::enable):
(WebCore::InspectorCanvasAgent::disable):
(WebCore::InspectorCanvasAgent::setRecordingAutoCaptureFrameCount): Added.
(WebCore::InspectorCanvasAgent::startRecording):
(WebCore::InspectorCanvasAgent::didCreateCanvasRenderingContext):
(WebCore::InspectorCanvasAgent::didFinishRecordingCanvasFrame):
(WebCore::InspectorCanvasAgent::consoleStartRecordingCanvas):
(WebCore::InspectorCanvasAgent::startRecording): Added.
Unify the different functions that are able to start a recording to use a single path.

inspector/InspectorCanvas.h:
inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::resetRecordingData):
(WebCore::InspectorCanvas::recordAction):
(WebCore::InspectorCanvas::setFrameCount): Added.
(WebCore::InspectorCanvas::overFrameCount const): Added.

Source/WebInspectorUI:

UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager.supportsRecordingAutoCapture): Added.
(WI.CanvasManager.prototype.setRecordingAutoCaptureFrameCount): Added.

UserInterface/Models/Canvas.js:

(WI.Canvas.prototype.startRecording):
(WI.Canvas.prototype.recordingStarted):
(WI.Canvas.prototype.recordingFinished):

UserInterface/Models/Recording.js:

UserInterface/Views/CanvasOverviewContentView.js:

(WI.CanvasOverviewContentView):
(WI.CanvasOverviewContentView.prototype.get navigationItems):
(WI.CanvasOverviewContentView.prototype.initialLayout): Added.
(WI.CanvasOverviewContentView.prototype.attached):
(WI.CanvasOverviewContentView.prototype.detached):
(WI.CanvasOverviewContentView.prototype._setRecordingAutoCaptureFrameCount): Added.
(WI.CanvasOverviewContentView.prototype._updateRecordingAutoCaptureInputElementSize): Added.
(WI.CanvasOverviewContentView.prototype._handleRecordingAutoCaptureInput): Added.
(WI.CanvasOverviewContentView.prototype._handleRecordingAutoCaptureCheckedDidChange): Added.
(WI.CanvasOverviewContentView.prototype._handleCanvasRecordingAutoCaptureEnabledChanged): Added.
(WI.CanvasOverviewContentView.prototype._handleCanvasRecordingAutoCaptureFrameCountChanged): Added.

UserInterface/Views/CanvasOverviewContentView.css:

(.navigation-bar > .item.canvas-recording-auto-capture > label): Added.
(.navigation-bar > .item.canvas-recording-auto-capture > label > input): Added.
(.navigation-bar > .item.canvas-recording-auto-capture > label > input::-webkit-inner-spin-button): Added.
(.popover-content > .tree-outline .item.recording > .icon): Deleted.
(.popover-content > .tree-outline .item.recording:hover): Deleted.
(.popover-content > .tree-outline .item.recording:hover > .icon): Deleted.
Drive-by: removed unused CSS rules.

UserInterface/Views/CanvasContentView.js:

(WI.CanvasContentView.prototype.initialLayout):
(WI.CanvasContentView.prototype._updateProgressView):
(WI.CanvasContentView.prototype._updateViewRelatedItems):

UserInterface/Views/CanvasTabContentView.js:

(WI.CanvasTabContentView.prototype._recordingImportedOrStopped):

UserInterface/Views/CheckboxNavigationItem.js:

(WI.CheckboxNavigationItem):
(WI.CheckboxNavigationItem.prototype._handleLabelClick): Added.

UserInterface/Base/Setting.js:

Localizations/en.lproj/localizedStrings.js:

LayoutTests:

inspector/canvas/resources/recording-utilities.js:

(TestPage.registerInitializer.window.startRecording):
(TestPage.registerInitializer.handleRecordingProgress):

inspector/canvas/recording-2d.html:
inspector/canvas/recording-bitmaprenderer.html:
inspector/canvas/recording-webgl-snapshots.html:
inspector/canvas/recording-webgl.html:

inspector/canvas/setRecordingAutoCaptureFrameCount-expected.txt: Added.
inspector/canvas/setRecordingAutoCaptureFrameCount.html: Added.

9:12 PM Changeset in webkit [237669] by Devin Rousso

15 edits in trunk/Source

Web Inspector: display low-power enter/exit events in Timelines and Network node waterfalls
https://bugs.webkit.org/show_bug.cgi?id=190641
<rdar://problem/45319049>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

inspector/protocol/DOM.json:

Add videoLowPowerChanged event that is fired when InspectorDOMAgent is able to determine
whether a video element's low power state has changed.

Source/WebCore:

No new tests, as low power mode is indeterminate. Should not affect functionality.

inspector/agents/InspectorDOMAgent.h:
inspector/agents/InspectorDOMAgent.cpp:

(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::addEventListenersToNode):
(WebCore::InspectorDOMAgent::mediaMetricsTimerFired): Added.

Source/WebInspectorUI:

UserInterface/Protocol/DOMObserver.js:

(WI.DOMObserver.prototype.videoLowPowerChanged): Added.

UserInterface/Controllers/DOMManager.js:

(WI.DOMManager.prototype.videoLowPowerChanged): Added.

UserInterface/Models/DOMNode.js:

(WI.DOMNode):
(WI.DOMNode.prototype.get lowPowerRanges): Added.
(WI.DOMNode.prototype.videoLowPowerChanged): Added.
(WI.DOMNode.prototype.canEnterLowPowerMode): Added.

UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype._populateDomainCell):
(WI.NetworkTableContentView.prototype._tryLinkResourceToDOMNode):
(WI.NetworkTableContentView.prototype._handleNodeLowPowerChanged): Added.

UserInterface/Views/NetworkTableContentView.css:

(.network-table :not(.header) .cell.waterfall .waterfall-container > .area):
(.network-table :not(.header) .cell.waterfall .waterfall-container > .area.dom-fullscreen): Added.
(.network-table :not(.header) .cell.waterfall .waterfall-container > .area.low-power): Added.
(.network-table :not(.header) .cell.waterfall .waterfall-container > .dom-fullscreen): Deleted.

UserInterface/Views/DOMNodeEventsContentView.js:

(WI.DOMNodeEventsContentView):
(WI.DOMNodeEventsContentView.prototype.initialLayout):
(WI.DOMNodeEventsContentView.prototype.closed): Deleted.
(WI.DOMNodeEventsContentView.prototype._handleDOMNodeDidFireEvent): Deleted.

UserInterface/Views/DOMEventsBreakdownView.js:

(WI.DOMEventsBreakdownView):
(WI.DOMEventsBreakdownView.prototype.initialLayout):
(WI.DOMEventsBreakdownView.prototype.layout): Added.
(WI.DOMEventsBreakdownView.prototype._handleDOMNodeDidFireEvent): Added.
(WI.DOMEventsBreakdownView.prototype._handleDOMNodeLowPowerChanged): Added.
(WI.DOMEventsBreakdownView.prototype.addEvent): Deleted.
(WI.DOMEventsBreakdownView.prototype._populateTable.percentOfTotalTime): Deleted.
(WI.DOMEventsBreakdownView.prototype._populateTable): Deleted.

UserInterface/Views/DOMEventsBreakdownView.css:

(.dom-events-breakdown .graph > .area): Added.
(.dom-events-breakdown .graph > .area.fullscreen):
(.dom-events-breakdown .graph > .area.low-power): Added.

Localizations/en.lproj/localizedStrings.js:

9:08 PM Changeset in webkit [237668] by Justin Michaud

2 edits in trunk/Tools

Add Justin Michaud to the list of WebKit Committers
https://bugs.webkit.org/show_bug.cgi?id=191142

Scripts/webkitpy/common/config/contributors.json:

7:11 PM Changeset in webkit [237667] by Wenson Hsieh

2 edits in trunk/Source/WebKit

API test WKAttachmentTests.CopyAndPasteBetweenWebViews fails on macOS 10.13
https://bugs.webkit.org/show_bug.cgi?id=191114
<rdar://problem/45700410>

Reviewed by Dean Jackson.

Followup to r237648: also make sure that we insecurely unarchive NSFileWrapper on platforms that don't support
secure archiving of file wrappers.

UIProcess/API/Cocoa/APIAttachmentCocoa.mm:

(API::Attachment::updateFromSerializedRepresentation):

6:18 PM Changeset in webkit [237666] by Fujii Hironori

2 edits in trunk/Source/WebKitLegacy/win

[Win][WKL] DOMHTMLDocument::setNodeValue does infinite recursion
https://bugs.webkit.org/show_bug.cgi?id=191105

Reviewed by Brent Fulgham.

DOMHTMLClasses.h:

(DOMHTMLDocument::setNodeValue): Call DOMDocument::setNodeValue
instead of own setNodeValue.

6:18 PM Changeset in webkit [237665] by Devin Rousso

8 edits
14 adds in trunk

Web Inspector: Audit: save imported audits across WebInspector sessions
https://bugs.webkit.org/show_bug.cgi?id=190858
<rdar://problem/45527625>

Reviewed by Brian Burg.

Source/WebInspectorUI:

UserInterface/Base/ObjectStore.js: Added.

(WI.ObjectStore):
(WI.ObjectStore.supported):
(WI.ObjectStore._open):
(WI.ObjectStore.get _databaseName):
(WI.ObjectStore.prototype.associateObject):
(WI.ObjectStore.prototype.async getAll):
(WI.ObjectStore.prototype.async add):
(WI.ObjectStore.prototype.async addObject):
(WI.ObjectStore.prototype.async delete):
(WI.ObjectStore.prototype.async deleteObject):
(WI.ObjectStore.prototype._resolveKeyPath):
(WI.ObjectStore.prototype.async _operation.listener):
(WI.ObjectStore.prototype.async _operation):
Wrapper for a global IndexedDB instance for all of WebInspector (per level). Instances of
WI.ObjectStore are able to control a given IDBObjectStore using a promise-based API.

*NOTE*: due to the constraint that IDBObjectStores are only able to be created when the
owner IndexedDB is "upgrade"d, all WI.ObjectStore must be declared before the database
is opened for the first time. Additionally, any time a new WI.ObjectStore is added, the
version needs to be incremented to ensure that the "upgrade" event fires.

To use any of the *Object functions, one must implement a toJSON on the object provided.
This is so that WI.ObjectStore is able to add the resulting identifier value to the owner
object while storing its toJSON value in the IndexedDB (e.g. for objects that have cycles).

UserInterface/Controllers/AuditManager.js:

(WI.AuditManager.prototype.import):
(WI.AuditManager.prototype.loadStoredTests): Added.
(WI.AuditManager.prototype.removeTest): Added.
(WI.AuditManager.prototype._addTest):

UserInterface/Views/AuditTabContentView.js:

(WI.AuditTabContentView.prototype.initialLayout): Added.
Attempt to load stored audits when the Audit tab is first shown (lazy-load).

UserInterface/Views/AuditNavigationSidebarPanel.js:

(WI.AuditNavigationSidebarPanel.prototype.initialLayout):
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestRemoved): Added.

UserInterface/Views/AuditTreeElement.js:

(WI.AuditTreeElement.prototype.ondelete):
Only allow top-level audits to be deleted, as that is what matches the WI.ObjectStore.

UserInterface/Main.html:
UserInterface/Test.html:

LayoutTests:

inspector/unit-tests/objectStore/add-expected.txt: Added.
inspector/unit-tests/objectStore/add.html: Added.
inspector/unit-tests/objectStore/addObject-expected.txt: Added.
inspector/unit-tests/objectStore/addObject.html: Added.
inspector/unit-tests/objectStore/basic-expected.txt: Added.
inspector/unit-tests/objectStore/basic.html: Added.
inspector/unit-tests/objectStore/delete-expected.txt: Added.
inspector/unit-tests/objectStore/delete.html: Added.
inspector/unit-tests/objectStore/deleteObject-expected.txt: Added.
inspector/unit-tests/objectStore/deleteObject.html: Added.
inspector/unit-tests/objectStore/resources/objectStore-utilities.js: Added.

(TestPage.registerInitializer.InspectorTest.ObjectStore.TestObject):
(TestPage.registerInitializer.InspectorTest.ObjectStore.TestObject.prototype.toJSON):
(TestPage.registerInitializer.InspectorTest.ObjectStore.createSuite):
(TestPage.registerInitializer.InspectorTest.ObjectStore.createObjectStore):
(TestPage.registerInitializer.InspectorTest.ObjectStore.add):
(TestPage.registerInitializer.InspectorTest.ObjectStore.addObject):
(TestPage.registerInitializer.InspectorTest.ObjectStore.delete):
(TestPage.registerInitializer.InspectorTest.ObjectStore.deleteObject):
(TestPage.registerInitializer.InspectorTest.ObjectStore.logValues):
(TestPage.registerInitializer.InspectorTest.ObjectStore.wrapTest):

6:03 PM Changeset in webkit [237664] by dino@apple.com

2 edits in trunk/Source/WebKit

Forward original fragment identifier into System Preview
https://bugs.webkit.org/show_bug.cgi?id=191141
<rdar://problem/45717542>

Reviewed by Wenson Hsieh.

If the URL used by the page includes a fragment identifier, use
it when telling QuickLook to open a local file.

UIProcess/Cocoa/DownloadClient.mm:

(WebKit::DownloadClient::didFinish): Append original fragment identifier
to the destination URL.

5:39 PM Changeset in webkit [237663] by Kocsen Chung

1 copy in tags/Safari-607.1.12

Tag Safari-607.1.12.

5:39 PM Changeset in webkit [237662] by Kocsen Chung

7 edits in trunk/Source

Versioning.

5:37 PM Changeset in webkit [237661] by commit-queue@webkit.org

16 edits in trunk/Source/WebInspectorUI

Web Inspector: Move a few remaining global WI settings to WI.settings
https://bugs.webkit.org/show_bug.cgi?id=191137

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-10-31
Reviewed by Brian Burg.

Move and better name some of the WI.settings created in Main.js
to WI.settings, alongside other global settings.

UserInterface/Base/Main.js:

(WI.loaded):
Move settings, and register for settings changes in contentLoaded.

UserInterface/Base/Setting.js:

New settings, and sort values.

UserInterface/Test/Test.js:

(WI.loaded):
Update setting values for tests.

UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager.prototype.initializeTarget):

UserInterface/Controllers/RuntimeManager.js:

(WI.RuntimeManager.prototype.initializeTarget):

UserInterface/Models/DOMNode.js:

(WI.DOMNode.prototype.get children):
(WI.DOMNode.prototype.get nextSibling):
(WI.DOMNode.prototype.get previousSibling):
(WI.DOMNode.prototype.get childNodeCount):

UserInterface/Protocol/Target.js:

(WI.Target.prototype.initialize):

UserInterface/Views/DOMTreeContentView.js:

(WI.DOMTreeContentView):
(WI.DOMTreeContentView.prototype.closed):
(WI.DOMTreeContentView.prototype._togglePaintFlashing):
(WI.DOMTreeContentView.prototype._showPaintRectsSettingChanged):
(WI.DOMTreeContentView.prototype._showShadowDOMSettingChanged):
(WI.DOMTreeContentView.prototype._toggleShowsShadowDOMSetting):

UserInterface/Views/DOMTreeOutline.js:

(WI.DOMTreeOutline):
(WI.DOMTreeOutline.prototype.close):
(WI.DOMTreeOutline.prototype._revealAndSelectNode):

UserInterface/Views/LayerTreeDetailsSidebarPanel.js:

(WI.LayerTreeDetailsSidebarPanel.prototype.initialLayout):
(WI.LayerTreeDetailsSidebarPanel.prototype._updateDisplayWithLayers):

UserInterface/Views/Layers3DContentView.js:

(WI.Layers3DContentView):
(WI.Layers3DContentView.prototype.closed):
(WI.Layers3DContentView.prototype._showPaintRectsSettingChanged):
(WI.Layers3DContentView.prototype._togglePaintFlashing):

UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype.closed):
(WI.NetworkTableContentView.prototype._resourceCachingDisabledSettingChanged):
(WI.NetworkTableContentView.prototype._toggleDisableResourceCache):

UserInterface/Views/ScriptContentView.js:

(WI.ScriptContentView):
(WI.ScriptContentView.prototype.closed):
(WI.ScriptContentView.prototype._contentDidPopulate):
(WI.ScriptContentView.prototype._enableControlFlowProfilerSettingChanged):
(WI.ScriptContentView.prototype._showJavaScriptTypeInformationSettingChanged):

UserInterface/Views/SourceCodeTextEditor.js:

(WI.SourceCodeTextEditor.prototype.shown):
(WI.SourceCodeTextEditor.prototype._proceedPopulateWithContent):
(WI.SourceCodeTextEditor.prototype._setTypeTokenAnnotatorEnabledState):
(WI.SourceCodeTextEditor.prototype.set _basicBlockAnnotatorEnabled):

UserInterface/Views/TextResourceContentView.js:

(WI.TextResourceContentView):
(WI.TextResourceContentView.prototype.closed):
(WI.TextResourceContentView.prototype._contentDidPopulate):
(WI.TextResourceContentView.prototype._enableControlFlowProfilerSettingChanged):
(WI.TextResourceContentView.prototype._showJavaScriptTypeInformationSettingChanged):
Renamed setting.

4:57 PM Changeset in webkit [237660] by Devin Rousso

4 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: missing contextmenu items for links
https://bugs.webkit.org/show_bug.cgi?id=191021

Reviewed by Joseph Pecoraro.

UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._renderValue):
(WI.SpreadsheetStyleProperty.prototype._handleLinkContextMenu): Added.
If the token is subtype of "link", add contextmenu items to the wrapper element.

UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForURL.showResourceWithOptions):
(WI.appendContextMenuItemsForURL):
Drive-by: don't assume that options will be provided.

Localizations/en.lproj/localizedStrings.js:

3:52 PM Changeset in webkit [237659] by Nikita Vasilyev

7 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: implement copying and deletion of multiple properties
https://bugs.webkit.org/show_bug.cgi?id=191037
<rdar://problem/45650078>

Reviewed by Brian Burg.

This patch should only work with "Enable Selection of Multiple Properties" checked. It shouldn't introduce any
changes when this setting is unchecked.

Mousedown on a property (1) and moving the mouse cursor to another property (2) should select properties 1, 2, and
all properties between them until mouseup is fired.

Once selected:

Pressing Command-C should copy the selected properties.
Pressing Delete should remove the properties.

UserInterface/Models/CSSProperty.js:

(WI.CSSProperty.prototype.get formattedText):

UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:

(.spreadsheet-style-declaration-editor):
(.multiple-properties-selection .spreadsheet-style-declaration-editor .property):
(.multiple-properties-selection .spreadsheet-style-declaration-editor :matches(.name, .value):not(.editing)):
(.multiple-properties-selection .spreadsheet-style-declaration-editor .property.selected):
(.multiple-properties-selection .spreadsheet-style-declaration-editor .property.selected:focus):
(@media (prefers-dark-interface)):

UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.initialLayout):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.selectProperties):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.deselectProperties):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyBlur):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyMouseEnter):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyMouseLeave):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyCopy):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._handleKeyDown):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype._hasSelectedProperties):
Property selection is defined as two numbers: anchorIndex and focusIndex.
The property with focusIndex is actually focused. The focus outline is replaced by a more subtle left blue border.

UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:

(.spreadsheet-css-declaration.selecting,):

UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:

(WI.SpreadsheetCSSStyleDeclarationSection):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetCSSStyleDeclarationEditorPropertyBlur):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetCSSStyleDeclarationEditorPropertyMouseEnter):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.spreadsheetCSSStyleDeclarationEditorPropertyMouseLeave):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleMouseDown):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleWindowMouseUp):
(WI.SpreadsheetCSSStyleDeclarationSection.prototype._handleClick):

UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty):
Implement copying the same way it's done for DataGrid: by adding copyHandler property to the focused element.
Add tabIndex=-1 so the property element can be focused.

(WI.SpreadsheetStyleProperty.prototype.get property):
(WI.SpreadsheetStyleProperty.prototype.get selected):
(WI.SpreadsheetStyleProperty.prototype.set selected):
(WI.SpreadsheetStyleProperty.prototype.remove):
(WI.SpreadsheetStyleProperty.prototype.updateStatus):
(WI.SpreadsheetStyleProperty.prototype.handleCopyEvent):
(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidCommit):
(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidBlur):
(WI.SpreadsheetStyleProperty.prototype._handleNamePaste):

3:44 PM Changeset in webkit [237658] by Alan Bujtas

2 edits in trunk/Source/WebKit

[iOS] Do not paint tap highlight unless it is above a certain threshold
https://bugs.webkit.org/show_bug.cgi?id=191134
<rdar://problem/43615142>

Flashing a large portion of the screen on every tap looks unpleasant.
This patch impoves the existing heuristic by adding area check and a % threshold.

Reviewed by Tim Horton.

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _showTapHighlight]):
(highlightedQuadsAreSmallerThanRect): Deleted.

3:05 PM Changeset in webkit [237657] by aboya@igalia.com

3 edits
2 adds in trunk

[MSE] Use tolerance when growing the coded frame group
https://bugs.webkit.org/show_bug.cgi?id=190085

Reviewed by Jer Noble.

Source/WebCore:

Test: media/media-source/media-source-append-acb-tolerance.html

This patch introduces a millisecond tolerance in the range of
potential frames that should be erased frame from the track buffer
when the coded frame group is growing.

This is necessary because some files have imprecise overlapping
timestamps (especially WebM files).

This fixes a stall when seeking back and forth in YouTube with WebM
video.

A test case simulating the problem with video/mock using timestamps
similar to those of a typical 30 fps WebM video is also added.

Modules/mediasource/SourceBuffer.cpp:

(WebCore::SourceBuffer::sourceBufferPrivateDidReceiveSample):

LayoutTests:

A test simulating unordered appends with imprecise timestamps,
overlapping <1ms (replicating a typical WebM 30fps video file) is
added.

media/media-source/media-source-append-acb-tolerance.html: Added.

3:00 PM Changeset in webkit [237656] by Devin Rousso

11 edits in trunk

Web Inspector: Audit: attempt to re-link DOM nodes for imported results
https://bugs.webkit.org/show_bug.cgi?id=191044
<rdar://problem/45687364>

Reviewed by Brian Burg.

Source/WebInspectorUI:

When importing a WI.AuditTestCaseResult, attempt to querySelector for each item in
data.domNodes. If a node is found, replace it with that node and show a tree instead.

UserInterface/Models/AuditTestCase.js:

(WI.AuditTestCase.async fromPayload): Added.
(WI.AuditTestCase.fromPayload): Deleted.

UserInterface/Models/AuditTestGroup.js:

(WI.AuditTestGroup.async fromPayload): Added.
(WI.AuditTestGroup.fromPayload): Deleted.

UserInterface/Models/AuditTestCaseResult.js:

(WI.AuditTestCaseResult.async fromPayload): Added.
(WI.AuditTestCaseResult.fromPayload): Deleted.

UserInterface/Models/AuditTestGroupResult.js:

(WI.AuditTestGroupResult.async fromPayload): Added.
(WI.AuditTestGroupResult.fromPayload): Deleted.

UserInterface/Controllers/AuditManager.js:

(WI.AuditManager.prototype.import):

LayoutTests:

inspector/model/auditTestCase.html:
inspector/model/auditTestCaseResult.html:
inspector/model/auditTestGroup.html:
inspector/model/auditTestGroupResult.html:

2:52 PM Changeset in webkit [237655] by jer.noble@apple.com

3 edits
2 adds in trunk

MediaSource.isTypeSupported('video/mp4; codecs="hvc1.1.6.L60.B0') is inproperly rejected
https://bugs.webkit.org/show_bug.cgi?id=191129

Reviewed by Eric Carlson.

Source/WebCore:

Test: media/media-source/media-source-istypesupported-case-sensitive.html

According to RFC 2045: "All media type values, subtype values, and parameter names as
defined are case-insensitive. However, parameter values are case-sensitive unless otherwise
specified for the specific parameter." So rather than fold the entire ContentType into lower-
case, leave the original string intact and require clients to enforce case-insensitivity.

Modules/mediasource/MediaSource.cpp:

(WebCore::MediaSource::isTypeSupported):

LayoutTests:

media/media-source/media-source-istypesupported-case-sensitive-expected.txt: Added.
media/media-source/media-source-istypesupported-case-sensitive.html: Added.

2:51 PM Changeset in webkit [237654] by jer.noble@apple.com

2 edits in trunk/Source/WebCore

Unreivewed build fix; fix the non-HAVE_AVCONTENTKEYSESSION builds by adding guards around
access of m_cdmInstance.

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::attemptToDecryptWithInstance):

2:48 PM Changeset in webkit [237653] by Joseph Pecoraro

2 edits in trunk/Source/WebInspectorUI

Follow-up review comment to r237652.

Reviewed by Brian Burg.

UserInterface/Controllers/DebuggerManager.js:

(WI.DebuggerManager):

2:19 PM Changeset in webkit [237652] by Joseph Pecoraro

24 edits in trunk/Source/WebInspectorUI

Web Inspector: Separate target initialization from frontend initialization
https://bugs.webkit.org/show_bug.cgi?id=191052
<rdar://problem/45658384>

Reviewed by Brian Burg.

UserInterface/Base/Main.js:

(WI.loaded):
(WI.performOneTimeFrontendInitializationsUsingTarget):
Create the targets after the rest of frontend initialization. This is a step
toward a frontend opening and being told about multiple targets instead of
knowing in advance a single target it is connected to. All backend
messages during frontend initialization now happen with an explicit target.

UserInterface/Controllers/ApplicationCacheManager.js:

(WI.ApplicationCacheManager):
(WI.ApplicationCacheManager.prototype.initializeTarget):
(WI.ApplicationCacheManager.prototype.initialize):

UserInterface/Controllers/CSSManager.js:

(WI.CSSManager):
(WI.CSSManager.prototype.initializeTarget):

UserInterface/Controllers/CanvasManager.js:

(WI.CanvasManager):
(WI.CanvasManager.prototype.initializeTarget):

UserInterface/Controllers/ConsoleManager.js:

(WI.ConsoleManager):
(WI.ConsoleManager.prototype.initializeLogChannels):

UserInterface/Controllers/DOMManager.js:

(WI.DOMManager):
(WI.DOMManager.prototype.initializeTarget):

UserInterface/Controllers/DOMStorageManager.js:

(WI.DOMStorageManager):
(WI.DOMStorageManager.prototype.initializeTarget):

UserInterface/Controllers/DatabaseManager.js:

(WI.DatabaseManager):
(WI.DatabaseManager.prototype.initializeTarget):

UserInterface/Controllers/DebuggerManager.js:

(WI.DebuggerManager):
(WI.DebuggerManager.prototype.initializeTarget):
(WI.DebuggerManager.restoreBreakpointsSoon): Deleted.

UserInterface/Controllers/HeapManager.js:

(WI.HeapManager.prototype.initializeTarget):

UserInterface/Controllers/IndexedDBManager.js:

(WI.IndexedDBManager):
(WI.IndexedDBManager.prototype.initializeTarget):

UserInterface/Controllers/LayerTreeManager.js:

(WI.LayerTreeManager.prototype.initializeTarget):

UserInterface/Controllers/MemoryManager.js:

(WI.MemoryManager.prototype.initializeTarget):

UserInterface/Controllers/NetworkManager.js:

(WI.NetworkManager):
(WI.NetworkManager.prototype.initializeTarget):

UserInterface/Controllers/RuntimeManager.js:

(WI.RuntimeManager):
(WI.RuntimeManager.prototype.initializeTarget):

UserInterface/Controllers/TargetManager.js:

(WI.TargetManager):
(WI.TargetManager.prototype.initializeTargetsWithMainTarget):

UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager):
(WI.TimelineManager.prototype.initializeTarget):
(WI.TimelineManager.prototype.set enabledTimelineTypes):
(WI.TimelineManager.prototype._updateAutoCaptureInstruments):

UserInterface/Controllers/WorkerManager.js:

(WI.WorkerManager):
(WI.WorkerManager.prototype.initializeTarget):
Move Target initialization out of the constructor into a top level
initializeTarget function. This will be expected to be called
by any target that the frontend connects to.

(WI.DebuggerManager.prototype._pauseForInternalScriptsDidChange):
Drive-by fix. Update all targets if the setting changes.

(WI.WorkerManager.prototype.workerCreated):
Call initialize on the new target.

UserInterface/Models/CSSCompletions.js:

(WI.CSSCompletions.initializeCSSCompletions):
(WI.CSSCompletions.requestCSSCompletions): Deleted.
Rename requestCSSCompletions to initializeCSSCompletions to try
and standardize on "initialize" being used for most frontend one
time initialization tasks. This being one such operation that
only needs to be performed once on a target that supports it.

UserInterface/Protocol/Target.js:

(WI.Target):
(WI.Target.prototype.initialize):
Perform explicit target initialization, such as initializing
the state of all backend domains / agents. This is done by asking
each of the managers to do initialization work for this target.

(WI.Target.prototype.get ApplicationCacheAgent):
(WI.Target.prototype.get CSSAgent):
(WI.Target.prototype.get CanvasAgent):
(WI.Target.prototype.get ConsoleAgent):
(WI.Target.prototype.get DOMAgent):
(WI.Target.prototype.get DOMDebuggerAgent):
(WI.Target.prototype.get DOMStorageAgent):
(WI.Target.prototype.get DatabaseAgent):
(WI.Target.prototype.get DebuggerAgent):
(WI.Target.prototype.get HeapAgent):
(WI.Target.prototype.get IndexedDBAgent):
(WI.Target.prototype.get InspectorAgent):
(WI.Target.prototype.get LayerTreeAgent):
(WI.Target.prototype.get MemoryAgent):
(WI.Target.prototype.get NetworkAgent):
(WI.Target.prototype.get PageAgent):
(WI.Target.prototype.get RecordingAgent):
(WI.Target.prototype.get RuntimeAgent):
(WI.Target.prototype.get ScriptProfilerAgent):
(WI.Target.prototype.get ServiceWorkerAgent):
(WI.Target.prototype.get TargetAgent):
(WI.Target.prototype.get TimelineAgent):
(WI.Target.prototype.get WorkerAgent):
Accessors for all of the agents on a Target.

UserInterface/Protocol/WorkerTarget.js:

(WI.WorkerTarget):
This is now automatically done in the base class.

UserInterface/Test/Test.js:

(WI.loaded):
(WI.performOneTimeFrontendInitializationsUsingTarget):
New necessary top level hooks, and initialize more like Main.js.

2:04 PM Changeset in webkit [237651] by aboya@igalia.com

45 edits in trunk/LayoutTests

[MSE] WebKit tests: Use fixed point in makeASample()
https://bugs.webkit.org/show_bug.cgi?id=191128

Reviewed by Jer Noble.

This patch modifies the utility function makeASample() so as to accept
time values in arbitrary time scales.

Previously makeASample() accepted optionally a time scale, but still
required to receive all time values as seconds, therefore requiring a
division at call time in order to use the function, which could cause
rounding errors (see https://bugs.webkit.org/show_bug.cgi?id=190085#c20).

media/media-source/media-source-append-acb-no-frame-lost-expected.txt:
media/media-source/media-source-append-acb-no-frame-lost.html:
media/media-source/media-source-append-buffer-with-append-window.html:
media/media-source/media-source-append-media-segment-without-init.html:
media/media-source/media-source-append-nonsync-sample-after-abort.html:
media/media-source/media-source-append-out-of-order.html:
media/media-source/media-source-append-overlapping-dts-expected.txt:
media/media-source/media-source-append-overlapping-dts.html:
media/media-source/media-source-canplaythrough.html:
media/media-source/media-source-duplicate-seeked.html:
media/media-source/media-source-duration-after-append.html:
media/media-source/media-source-end-of-stream-buffered.html:
media/media-source/media-source-end-of-stream-readyState.html:
media/media-source/media-source-fastseek.html:
media/media-source/media-source-fudge-factor.html:
media/media-source/media-source-monitor-source-buffers.html:
media/media-source/media-source-overlapping-append-buffered.html:
media/media-source/media-source-overlapping-append-expected.txt:
media/media-source/media-source-overlapping-append.html:
media/media-source/media-source-overlapping-decodetime-expected.txt:
media/media-source/media-source-overlapping-decodetime.html:
media/media-source/media-source-play.html:
media/media-source/media-source-range-end-frame-not-removed-expected.txt:
media/media-source/media-source-range-end-frame-not-removed.html:
media/media-source/media-source-range-start-frame-replaced-expected.txt:
media/media-source/media-source-range-start-frame-replaced.html:
media/media-source/media-source-remove-decodeorder-crash.html:
media/media-source/media-source-remove-too-much.html:
media/media-source/media-source-remove.html:
media/media-source/media-source-restrictions.html:
media/media-source/media-source-sample-wrong-track-id.html:
media/media-source/media-source-seek-back-expected.txt:
media/media-source/media-source-seek-back.html:
media/media-source/media-source-seek-complete.html:
media/media-source/media-source-sequence-timestamps-expected.txt:
media/media-source/media-source-sequence-timestamps.html:
media/media-source/media-source-small-gap.html:
media/media-source/media-source-timeoffset-expected.txt:
media/media-source/media-source-timeoffset.html:
media/media-source/media-source-timestampoffset-rounding-error.html:
media/media-source/media-source-timestampoffset-then-zero-expected.txt:
media/media-source/media-source-timestampoffset-then-zero.html:
media/media-source/media-source-video-playback-quality.html:
media/media-source/mock-media-source.js:

(makeASample):

1:26 PM Changeset in webkit [237650] by commit-queue@webkit.org

5 edits in trunk

MediaRecorder should fire dataavailable event when all tracks are ended and stop() is called
https://bugs.webkit.org/show_bug.cgi?id=190778
<rdar://problem/45703574>

Patch by YUHAN WU <yuhan_wu@apple.com> on 2018-10-31
Reviewed by Youenn Fablet.

Source/WebCore:

Add a include to fix the unified build error.

No tests since no new functionality.

Modules/webgpu/WebGPUDevice.cpp:

LayoutTests:

Increase the timer of recording to 2 seconds until we support timeslice in order to reduce flakiness.

http/wpt/mediarecorder/MediaRecorder-dataavailable.html:
http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html:

1:23 PM Changeset in webkit [237649] by jer.noble@apple.com

14 edits in trunk/Source/WebCore

[EME][Cocoa] Cannot play unmuxed video and audio fMP4 streams encrypted with different keys via MSE
https://bugs.webkit.org/show_bug.cgi?id=190946

Reviewed by Eric Carlson.

Use separate AVContentKeySessions per CDMInstanceSession (rather than one AVContentKeySession per
CDMInstance).

Add a mechanism for sending a message out from platform/CDMInstance to MediaKeySession without requiring MediaKeySession to send a callback first.

Move all the AVContentKeySession delegate methods from CDMInstanceFairPlayStreamingAVFObjC to CDMInstanceSessionFairPlayStreamingAVFObjC.

Add a mechanism for requesting the correct CDMInstanceSession for a given KeyID.

Support key renewal through a "renew" message.

Remember the keyID in SourceBufferPrivateAVFObjC::didProvideContentKeyRequestInitializationDataForTrackID() and ask for the correct CDMInstanceSession for that keyID in attemptToDecrypt().

Pass the CDMInstance down from MediaPlayerPrivateMediaSourceAVFObjC -> SourceBufferPrivateAVFObjC.

Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::sendMessage):

Modules/encryptedmedia/MediaKeySession.h:
platform/encryptedmedia/CDMInstanceSession.h:
platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.h:
platform/graphics/avfoundation/objc/CDMInstanceFairPlayStreamingAVFObjC.mm:

(-[WebCoreFPSContentKeySessionDelegate initWithParent:]):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::initializeWithConfiguration):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::createSession):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):
(WebCore::CDMInstanceFairPlayStreamingAVFObjC::sessionForKeyIDs const):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::CDMInstanceSessionFairPlayStreamingAVFObjC):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::~CDMInstanceSessionFairPlayStreamingAVFObjC):
(WebCore::keyIDsForRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyIDs):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::requestLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::updateLicense):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::closeSession):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::removeSessionData):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didProvideRenewingRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::didFailToProvideRequest):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::requestDidSucceed):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::nextRequest):
(WebCore::requestStatusToCDMStatus):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::keyStatuses const):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):
(WebCore::CDMInstanceSessionFairPlayStreamingAVFObjC::ensureSession):

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cdmInstanceAttached):
(WebCore::MediaPlayerPrivateAVFoundationObjC::cdmInstanceDetached):
(WebCore::MediaPlayerPrivateAVFoundationObjC::attemptToDecryptWithInstance):

platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cdmInstanceAttached):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::cdmInstanceDetached):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::attemptToDecryptWithInstance):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::waitingForKey const):

platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:

(WebCore::MediaSourcePrivateAVFObjC::addSourceBuffer):
(WebCore::MediaSourcePrivateAVFObjC::cdmInstanceAttached):
(WebCore::MediaSourcePrivateAVFObjC::cdmInstanceDetached):
(WebCore::MediaSourcePrivateAVFObjC::attemptToDecryptWithInstance):
(WebCore::MediaSourcePrivateAVFObjC::waitingForKey const):
(WebCore::MediaSourcePrivateAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):

platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::didProvideContentKeyRequestInitializationDataForTrackID):
(WebCore::SourceBufferPrivateAVFObjC::destroyParser):
(WebCore::SourceBufferPrivateAVFObjC::setCDMInstance):
(WebCore::SourceBufferPrivateAVFObjC::attemptToDecrypt):
(WebCore::SourceBufferPrivateAVFObjC::outputObscuredDueToInsufficientExternalProtectionChanged):

1:16 PM Changeset in webkit [237648] by Wenson Hsieh

2 edits in trunk/Source/WebKit

API test WKAttachmentTests.CopyAndPasteBetweenWebViews fails on macOS 10.13
https://bugs.webkit.org/show_bug.cgi?id=191114
<rdar://problem/45700410>

Reviewed by Dean Jackson.

On macOS 10.12, we don't attempt secure archival at all because SECURE_ARCHIVER_API is turned off, and on macOS
10.14, NSFileWrapper supports secure coding. However, on macOS 10.13, SECURE_ARCHIVER_API is on despite
NSFileWrapper not being securely codable, so we're unable to serialize attachment data.

To fix this, we only use the secure archiver on ≥ macOS 10.14 and ≥ iOS 12.

UIProcess/API/Cocoa/APIAttachmentCocoa.mm:

(API::Attachment::createSerializedRepresentation const):

1:08 PM Changeset in webkit [237647] by commit-queue@webkit.org

18 edits
6 adds in trunk

Add credit card autofill button
https://bugs.webkit.org/show_bug.cgi?id=191051
<rdar://problem/45657011>

Patch by Zach Li <zacharyli323@gmail.com> on 2018-10-31
Reviewed by Wenson Hsieh.

Source/WebCore:

Test: fast/forms/auto-fill-button/input-credit-card-auto-fill-button.html

accessibility/mac/WebAccessibilityObjectWrapperMac.mm:

(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):

css/html.css:

(input::-webkit-credit-card-auto-fill-button):
Add credit card autofill button.
(input::-webkit-credit-card-auto-fill-button:hover):
(input::-webkit-credit-card-auto-fill-button:active):

html/HTMLTextFormControlElement.h:
html/TextFieldInputType.cpp:

(WebCore::autoFillButtonTypeToAccessibilityLabel):
(WebCore::autoFillButtonTypeToAutoFillButtonText):
(WebCore::autoFillButtonTypeToAutoFillButtonPseudoClassName):
(WebCore::isAutoFillButtonTypeChanged):

platform/LocalizedStrings.cpp:

(WebCore::AXAutoFillCreditCardLabel):

platform/LocalizedStrings.h:
testing/Internals.cpp:

(WebCore::toAutoFillButtonType):
(WebCore::toInternalsAutoFillButtonType):

testing/Internals.h:
testing/Internals.idl:

Source/WebKit:

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandle.mm:

(toAutoFillButtonType):
(toWKAutoFillButtonType):

WebProcess/InjectedBundle/API/Cocoa/WKWebProcessPlugInNodeHandlePrivate.h:

Introduce a new button type for credit card autofill.

WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:

(toAutoFillButtonType):
(toWKAutoFillButtonType):

WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:

LayoutTests:

fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.txt: Added.
fast/forms/auto-fill-button/input-credit-card-auto-fill-button.html: Added.
fast/forms/auto-fill-button/last-auto-fill-button-type-expected.txt:
fast/forms/auto-fill-button/last-auto-fill-button-type.html:
platform/ios-simulator/fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.txt: Added.
platform/mac/fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.png: Added.
platform/win/fast/forms/auto-fill-button/input-credit-card-auto-fill-button-expected.txt: Added.

1:05 PM Changeset in webkit [237646] by Chris Dumez

8 edits
6 adds in trunk/LayoutTests/imported/w3c

Resync XHR Web Platform Tests from upstream 44dd29fb0d
https://bugs.webkit.org/show_bug.cgi?id=191116

Reviewed by Youenn Fablet.

web-platform-tests/xhr/getallresponseheaders-expected.txt:
web-platform-tests/xhr/getallresponseheaders.htm:
web-platform-tests/xhr/getresponseheader.any-expected.txt:
web-platform-tests/xhr/getresponseheader.any.js:

(forEach.testValues.async_test.t.client.onload.t.step_func_done):
(async_test.t.client.onload.t.step_func_done): Deleted.

web-platform-tests/xhr/getresponseheader.any.worker-expected.txt:
web-platform-tests/xhr/resources/header-content-length-twice.asis: Added.
web-platform-tests/xhr/resources/headers-double-empty.asis: Added.
web-platform-tests/xhr/resources/headers-some-are-empty.asis: Added.
web-platform-tests/xhr/resources/w3c-import.log:
web-platform-tests/xhr/setrequestheader-combining.window-expected.txt: Added.
web-platform-tests/xhr/setrequestheader-combining.window.html: Added.
web-platform-tests/xhr/setrequestheader-combining.window.js: Added.

(test):

web-platform-tests/xhr/w3c-import.log:

11:44 AM Changeset in webkit [237645] by Tadeu Zagallo

2 edits in trunk/Source/JavaScriptCore

Adjust inlining threshold for new bytecode format
https://bugs.webkit.org/show_bug.cgi?id=191115

Reviewed by Saam Barati.

The new format reduced the number of operands for many opcodes, which
changed inlining decisions and impacted performance negatively.

runtime/Options.h:

11:25 AM Changeset in webkit [237644] by Devin Rousso

15 edits in trunk

Web Inspector: Audit: show metadata for results
https://bugs.webkit.org/show_bug.cgi?id=190853
<rdar://problem/45527623>

Reviewed by Brian Burg.

Source/WebInspectorUI:

UserInterface/Models/AuditTestCase.js:

(WI.AuditTestCase.prototype.async run):
Capture timestamps around the RunetimeAgent.evaluate call, as well as the URL of the page.

UserInterface/Models/AuditTestCaseResult.js:

(WI.AuditTestCaseResult):
(WI.AuditTestCaseResult.fromPayload):
(WI.AuditTestCaseResult.prototype.get metadata): Added.
(WI.AuditTestCaseResult.prototype.toJSON):

UserInterface/Views/AuditTestCaseContentView.js:

(WI.AuditTestCaseContentView.prototype.initialLayout):
(WI.AuditTestCaseContentView.prototype.layout):

UserInterface/Views/AuditTestCaseContentView.css:

(.content-view.audit-test-case > header h1): Added.
(.content-view.audit-test-case > header h1 > img): Added.
(.content-view.audit-test-case > header > .metadata): Added.
(.content-view.audit-test-case > header > .metadata > .source > time): Added.
(.content-view.audit-test-case > header > .metadata > .source > a): Added.
(.content-view.audit-test-case > header > .metadata > .duration): Added.
(.content-view.audit-test-case > header > h1): Deleted.
(.content-view.audit-test-case > header > h1 > img): Deleted.
Display any metadata information where the WI.ScopeBar is for WI.AuditTestGroupContentViews.

UserInterface/Views/AuditTestContentView.css:

(.content-view.audit-test > header):
(.content-view.audit-test > header > .information): Added.

UserInterface/Views/AuditTestGroupContentView.css:

(.content-view.audit-test-group > header):
(.content-view.audit-test-group > header > .percentage-pass):
(.content-view.audit-test-group > header > .information): Deleted.
Move common CSS rules to common parent class.

UserInterface/Base/Utilities.js:

LayoutTests:

inspector/model/auditTestCaseResult-expected.txt:
inspector/model/auditTestCaseResult.html:
inspector/model/auditTestGroupResult-expected.txt:
inspector/model/auditTestGroupResult.html:
inspector/unit-tests/string-utilities-expected.txt:
inspector/unit-tests/string-utilities.html:

10:26 AM Changeset in webkit [237643] by eric.carlson@apple.com

7 edits in trunk

[MediaStream] Don't reveal device IDs until the user has granted permission to capture
https://bugs.webkit.org/show_bug.cgi?id=191112
<rdar://problem/45699932>

Reviewed by Youenn Fablet.

Source/WebCore:

No new tests, existing tests updated.

Modules/mediastream/MediaDevicesRequest.cpp:

(WebCore::MediaDevicesRequest::start): Don't reveal device ID or group ID until the user
has granted permssion to capture.

LayoutTests:

TestExpectations: Skip http/tests/media/media-stream/enumerate-devices-source-id-persistent.html

and http/tests/media/media-stream/enumerate-devices-source-id.html for now, they don't make sense
with these changes and will be updated to pass in a future patch.

fast/mediastream/MediaStreamTrack-getCapabilities.html:
fast/mediastream/get-user-media-device-id-expected.txt:
fast/mediastream/get-user-media-device-id.html:

10:19 AM Changeset in webkit [237642] by commit-queue@webkit.org

17 edits
4 copies
10 adds in trunk

MediaRecorder should fire dataavailable event when all tracks are ended and stop() is called
https://bugs.webkit.org/show_bug.cgi?id=190778

Patch by YUHAN WU <yuhan_wu@apple.com> on 2018-10-31
Reviewed by Youenn Fablet.

LayoutTests/imported/w3c:

web-platform-tests/mediacapture-record/BlobEvent-constructor-expected.txt:
web-platform-tests/mediacapture-record/MediaRecorder-destroy-script-execution-expected.txt: Added.
web-platform-tests/mediacapture-record/MediaRecorder-destroy-script-execution.html: Added.
web-platform-tests/mediacapture-record/MediaRecorder-stop-expected.txt:
web-platform-tests/mediacapture-record/MediaRecorder-stop.html:
web-platform-tests/mediacapture-record/support/MediaRecorder-iframe.html: Added.

Source/WebCore:

Implement JavaScript dispatch event dataavailable and JavaScript exposed method stop().
Implement a mock string as the output buffer of MediaRecorder.
Remove the declaration of timecode in BlobEvent since it has not been implemented in MediaRecorder and MediaRecorderPrivate.

Tests: http/wpt/mediarecorder/MediaRecorder-dataavailable.html

http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html
imported/w3c/web-platform-tests/mediacapture-record/MediaRecorder-destroy-script-execution.html
imported/w3c/web-platform-tests/mediacapture-record/support/MediaRecorder-iframe.html

CMakeLists.txt:
Modules/mediarecorder/BlobEvent.cpp: Added.

(WebCore::BlobEvent::create):
(WebCore::BlobEvent::BlobEvent):
(WebCore::BlobEvent::eventInterface const):

Modules/mediarecorder/BlobEvent.h:
Modules/mediarecorder/BlobEvent.idl:
Modules/mediarecorder/MediaRecorder.cpp:

(WebCore::MediaRecorder::MediaRecorder):
(WebCore::MediaRecorder::~MediaRecorder):
(WebCore::MediaRecorder::stop):
(WebCore::MediaRecorder::startRecording):
(WebCore::MediaRecorder::stopRecording):
(WebCore::MediaRecorder::stopRecordingInternal):
(WebCore::MediaRecorder::didAddOrRemoveTrack):
(WebCore::MediaRecorder::trackEnded):
(WebCore::MediaRecorder::sampleBufferUpdated):
(WebCore::MediaRecorder::audioSamplesAvailable):
(WebCore::MediaRecorder::scheduleDeferredTask):

Modules/mediarecorder/MediaRecorder.h:
Modules/mediarecorder/MediaRecorder.idl:
Sources.txt:
WebCore.xcodeproj/project.pbxproj:
dom/EventNames.h:
dom/EventNames.in:
platform/mediarecorder/MediaRecorderPrivate.h: Added.
platform/mediarecorder/MediaRecorderPrivateMock.cpp: Added.

(WebCore::MediaRecorderPrivateMock::sampleBufferUpdated):
(WebCore::MediaRecorderPrivateMock::audioSamplesAvailable):
(WebCore::MediaRecorderPrivateMock::generateMockString):
(WebCore::MediaRecorderPrivateMock::fetchData):

platform/mediarecorder/MediaRecorderPrivateMock.h: Added.

LayoutTests:

These tests are used to check if MediaRecorder can generate both video and audio buffers through mock source.

http/wpt/mediarecorder/MediaRecorder-dataavailable-expected.txt: Added.
http/wpt/mediarecorder/MediaRecorder-dataavailable.html: Added.
http/wpt/mediarecorder/MediaRecorder-mock-dataavailable-expected.txt: Added.
http/wpt/mediarecorder/MediaRecorder-mock-dataavailable.html: Added.
platform/win/TestExpectations:

9:39 AM Changeset in webkit [237641] by Tadeu Zagallo

3 edits
1 add in trunk

REGRESSION(r237547): Exception handlers should be aware of wide opcodes
https://bugs.webkit.org/show_bug.cgi?id=191108
<rdar://problem/45690700>

Reviewed by Saam Barati.

JSTests:

stress/wide-op_catch.js: Added.

(catch):

Source/JavaScriptCore:

When linking the handler, we need to check whether the target op_catch is
wide or narrow in order to chose the right code pointer for the handler.

bytecode/CodeBlock.cpp:

(JSC::CodeBlock::finishCreation):

9:33 AM Changeset in webkit [237640] by guijemont@igalia.com

2 edits in trunk/Tools

Don't run JIT tests on 32-bit platforms
https://bugs.webkit.org/show_bug.cgi?id=191074

Reviewed by Michael Catanzaro.

Scripts/run-jsc-stress-tests:

9:23 AM Changeset in webkit [237639] by Chris Dumez

8 edits
2 adds in trunk

[PSON] When process-swapping for a POST request the HTTP body gets dropped
https://bugs.webkit.org/show_bug.cgi?id=191046
<rdar://problem/45229732>

Reviewed by Alex Christensen.

Source/WebKit:

For performance reasons, the ResourceRequest IPC encoder does not encode the request's HTTP body (aka form data).
When we decide to process-swap for a POST request in WebPageProxy::decidePolicyForNavigationAction(), the request
we pass the new WebProcess thus no longer has a HTTP body and the load will likely fail in the new process.

To address the issue, we now pass the request body along with the request when sending the DecidePolicyForNavigationActionAsync
/ DecidePolicyForNavigationActionSync IPC from the WebProcess to the UIProcess. No action is needed for the
LoadRequest IPC to the new WebProcess since the LoadParameters' IPC encoder takes care of encoding the request's
body already.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::decidePolicyForNavigationActionAsync):
(WebKit::WebPageProxy::decidePolicyForNavigationActionSync):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):

LayoutTests:

Add layout test coverage.

http/tests/misc/form-post-textplain-cross-site-expected.txt: Added.
http/tests/misc/form-post-textplain-cross-site.html: Added.

9:09 AM Changeset in webkit [237638] by dinfuehr@igalia.com

6 edits in trunk/Source/JavaScriptCore

Align entries in metadata table
https://bugs.webkit.org/show_bug.cgi?id=191062

Reviewed by Filip Pizlo.

Entries in the metadata table need to be aligned on some 32-bit
architectures.

bytecode/MetadataTable.h:

(JSC::MetadataTable::forEach):

bytecode/Opcode.cpp:

(JSC::metadataAlignment):

bytecode/Opcode.h:
bytecode/UnlinkedMetadataTableInlines.h:

(JSC::UnlinkedMetadataTable::finalize):

generator/Section.rb:

8:19 AM Changeset in webkit [237637] by Claudio Saavedra

2 edits in trunk/Source/WebCore

[GTK][WPE] Remaining topPrivatelyControlledDomain() fixes
https://bugs.webkit.org/show_bug.cgi?id=191110

Reviewed by Michael Catanzaro.

Covered by existing tests.

Turns out that this method is expected to reject domains that
are not registrable. Also sync with the Mac implementation in
that given domains that are not all ASCII should be returned
back as is. This fixes the remaining Public Suffix API tests.

platform/soup/PublicSuffixSoup.cpp:

(WebCore::topPrivatelyControlledDomain):

8:08 AM Changeset in webkit [237636] by Antti Koivisto

11 edits
4 deletes in trunk/Source

Remove LayerFlushScheduler
https://bugs.webkit.org/show_bug.cgi?id=191103

Reviewed by Anders Carlsson.

Source/WebCore:

It is only used in WK1.

SourcesCocoa.txt:
WebCore.xcodeproj/project.pbxproj:
platform/graphics/ca/LayerFlushScheduler.cpp: Removed.
platform/graphics/ca/LayerFlushScheduler.h: Removed.
platform/graphics/ca/LayerFlushSchedulerClient.h: Removed.
platform/graphics/ca/cocoa/LayerFlushSchedulerMac.cpp: Removed.

Source/WebKitLegacy/mac:

Add a RunLoopObserver directly into WebViewLayerFlushScheduler and remove
all the virtual cruft.

WebView/WebViewData.h:

(WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler): Deleted.
(): Deleted.

WebView/WebViewData.mm:

(currentRunLoop):
(WebViewLayerFlushScheduler::WebViewLayerFlushScheduler):
(WebViewLayerFlushScheduler::~WebViewLayerFlushScheduler):
(WebViewLayerFlushScheduler::schedule):
(WebViewLayerFlushScheduler::invalidate):
(WebViewLayerFlushScheduler::layerFlushCallback):

7:21 AM Changeset in webkit [237635] by Alan Bujtas

2 edits in trunk/Source/WebCore

Missing from r237634

layout/inlineformatting/InlineFormattingState.cpp:

(WebCore::Layout::InlineFormattingState::formattingContext):

6:51 AM Changeset in webkit [237634] by Alan Bujtas

9 edits in trunk/Source/WebCore

[LFC] Do not pass LayoutState& to compute* and layout* functions
https://bugs.webkit.org/show_bug.cgi?id=191100

Reviewed by Antti Koivisto.

Reduce noise by removing LayoutState& parameter where possible.

layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
(WebCore::Layout::FormattingContext::computeOutOfFlowVerticalGeometry const):
(WebCore::Layout::FormattingContext::computeBorderAndPadding const):
(WebCore::Layout::FormattingContext::placeInFlowPositionedChildren const):
(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):
(WebCore::Layout::FormattingContext::validateGeometryConstraintsAfterLayout const):

layout/FormattingContext.h:
layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):

layout/LayoutFormattingState.cpp:

(WebCore::Layout::LayoutState::layoutFormattingContextSubtree):

layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layout const):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::BlockFormattingContext::computeStaticPosition const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTop const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTopForAncestors const):
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForFormattingRootIfNeeded const):
(WebCore::Layout::BlockFormattingContext::computeFloatingPosition const):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats const):
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear const):
(WebCore::Layout::BlockFormattingContext::computeInFlowPositionedPosition const):
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):
(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const):

layout/blockformatting/BlockFormattingContext.h:
layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layout const):
(WebCore::Layout::InlineFormattingContext::initializeNewLine const):
(WebCore::Layout::InlineFormattingContext::layoutInlineContent const):
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForInlineBox const):
(WebCore::Layout::InlineFormattingContext::computeFloatPosition const):
(WebCore::Layout::InlineFormattingContext::computeStaticPosition const):
(WebCore::Layout::InlineFormattingContext::computeInFlowPositionedPosition const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):

layout/inlineformatting/InlineFormattingContext.h:

6:50 AM Changeset in webkit [237633] by Alan Bujtas

14 edits in trunk/Source/WebCore

[LFC] FormattingContext class should take FormattingState&
https://bugs.webkit.org/show_bug.cgi?id=191099

Reviewed by Antti Koivisto.

This is in preparation for not passing LayoutState& into every layout functions.
FormattingContext has FormattingState now and LayoutState can be acquired through FormattingState.
LayoutState <- FormattingState <- FormattingContext

layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::FormattingContext):
(WebCore::Layout::FormattingContext::formattingState const):
(WebCore::Layout::FormattingContext::layoutState const):

layout/FormattingContext.h:
layout/FormattingState.cpp:

(WebCore::Layout::FormattingState::FormattingState):

layout/FormattingState.h:

(WebCore::Layout::FormattingState::layoutState const):

layout/LayoutFormattingState.h:
layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::BlockFormattingContext):

layout/blockformatting/BlockFormattingContext.h:
layout/blockformatting/BlockFormattingState.cpp:

(WebCore::Layout::BlockFormattingState::BlockFormattingState):
(WebCore::Layout::BlockFormattingState::formattingContext):
(WebCore::Layout::BlockFormattingState::formattingContext const): Deleted.

layout/blockformatting/BlockFormattingState.h:
layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::InlineFormattingContext):

layout/inlineformatting/InlineFormattingContext.h:
layout/inlineformatting/InlineFormattingState.cpp:

(WebCore::Layout::InlineFormattingState::InlineFormattingState):
(WebCore::Layout::InlineFormattingState::formattingContext):
(WebCore::Layout::InlineFormattingState::formattingContext const): Deleted.

layout/inlineformatting/InlineFormattingState.h:

6:43 AM Changeset in webkit [237632] by Alan Bujtas

11 edits in trunk/Source/WebCore

[LFC] The *FormattingState class should provide the *FormattingContext.
https://bugs.webkit.org/show_bug.cgi?id=191089

Reviewed by Antti Koivisto.

BlockFormattingState provides the BlockFormattingContext object, while InlineFormattingState provides the InlineFormattingContext.

layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::layoutOutOfFlowDescendants const):

layout/FormattingState.h:
layout/LayoutFormattingState.cpp:

(WebCore::Layout::LayoutState::layoutFormattingContextSubtree):
(WebCore::Layout::LayoutState::formattingContext const): Deleted.

layout/LayoutFormattingState.h:
layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const):

layout/blockformatting/BlockFormattingState.cpp:

(WebCore::Layout::BlockFormattingState::formattingContext const):

layout/blockformatting/BlockFormattingState.h:
layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):

layout/inlineformatting/InlineFormattingState.cpp:

(WebCore::Layout::InlineFormattingState::formattingContext const):

layout/inlineformatting/InlineFormattingState.h:

6:37 AM Changeset in webkit [237631] by Alan Bujtas

38 edits
2 moves in trunk/Source/WebCore

[LFC] Rename LayoutContext to LayoutState
https://bugs.webkit.org/show_bug.cgi?id=191080

Reviewed by Antti Koivisto.

LayoutContext naming was a bit misleading since none of the other *FormattingContext classes (BlockFormattingContext etc) hold states.
(LayoutContext.cpp -> LayoutFormattingState.cpp because LayoutState.cpp name is already taken.)

Now the current state is as follows:

LayoutState has

Layout tree
State content for each formatting subtrees
Display tree

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/FormattingContext.cpp:

layout/FormattingContext.h:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):

layout/FormattingContextGeometry.cpp:

(WebCore::Layout::contentHeightForFormattingContextRoot):
(WebCore::Layout::FormattingContext::Geometry::computedMaxHeight):
(WebCore::Layout::FormattingContext::Geometry::computedMinHeight):
(WebCore::Layout::staticVerticalPositionForOutOfFlowPositioned):
(WebCore::Layout::staticHorizontalPositionForOutOfFlowPositioned):
(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::computedBorder):
(WebCore::Layout::FormattingContext::Geometry::computedPadding):
(WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedHorizontalMarginValue):
(WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedVerticalMarginValue):

layout/FormattingState.cpp:

(WebCore::Layout::FormattingState::FormattingState):

layout/FormattingState.h:

(WebCore::Layout::FormattingState::setInstrinsicWidthConstraints):
(WebCore::Layout::FormattingState::instrinsicWidthConstraints const):

layout/LayoutFormattingState.cpp: Renamed from Source/WebCore/layout/LayoutContext.cpp.

(WebCore::Layout::LayoutState::LayoutState):
(WebCore::Layout::LayoutState::initializeRoot):
(WebCore::Layout::LayoutState::updateLayout):
(WebCore::Layout::LayoutState::layoutFormattingContextSubtree):
(WebCore::Layout::LayoutState::displayBoxForLayoutBox const):
(WebCore::Layout::LayoutState::styleChanged):
(WebCore::Layout::LayoutState::markNeedsUpdate):
(WebCore::Layout::LayoutState::formattingStateForBox const):
(WebCore::Layout::LayoutState::establishedFormattingState const):
(WebCore::Layout::LayoutState::createFormattingStateForFormattingRootIfNeeded):
(WebCore::Layout::LayoutState::formattingContext const):

layout/LayoutFormattingState.h: Renamed from Source/WebCore/layout/LayoutContext.h.

(WebCore::Layout::LayoutState::setInQuirksMode):
(WebCore::Layout::LayoutState::hasDisplayBox const):
(WebCore::Layout::LayoutState::inQuirksMode const):

layout/Verification.cpp:

(WebCore::Layout::outputMismatchingSimpleLineInformationIfNeeded):
(WebCore::Layout::outputMismatchingComplexLineInformationIfNeeded):
(WebCore::Layout::outputMismatchingBlockBoxInformationIfNeeded):
(WebCore::Layout::verifyAndOutputSubtree):
(WebCore::Layout::LayoutState::verifyAndOutputMismatchingLayoutTree const):
(WebCore::Layout::LayoutContext::verifyAndOutputMismatchingLayoutTree const): Deleted.

layout/blockformatting/BlockFormattingContext.cpp:

(WebCore::Layout::BlockFormattingContext::layout const):
(WebCore::Layout::BlockFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::BlockFormattingContext::computeStaticPosition const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTop const):
(WebCore::Layout::BlockFormattingContext::computeEstimatedMarginTopForAncestors const):
(WebCore::Layout::BlockFormattingContext::precomputeVerticalPositionForFormattingRootIfNeeded const):
(WebCore::Layout::hasPrecomputedMarginTop):
(WebCore::Layout::BlockFormattingContext::computeFloatingPosition const):
(WebCore::Layout::BlockFormattingContext::computePositionToAvoidFloats const):
(WebCore::Layout::BlockFormattingContext::computeVerticalPositionForFloatClear const):
(WebCore::Layout::BlockFormattingContext::computeInFlowPositionedPosition const):
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::computeHeightAndMargin const):
(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const):

layout/blockformatting/BlockFormattingContext.h:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):

layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::isStretchedToInitialContainingBlock):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::staticPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowPositionedPosition):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::instrinsicWidthConstraints):
(WebCore::Layout::BlockFormattingContext::Geometry::estimatedMarginTop):

layout/blockformatting/BlockFormattingState.cpp:

(WebCore::Layout::BlockFormattingState::BlockFormattingState):

layout/blockformatting/BlockFormattingState.h:
layout/blockformatting/BlockInvalidation.cpp:

(WebCore::Layout::computeUpdateType):
(WebCore::Layout::computeUpdateTypeForAncestor):
(WebCore::Layout::BlockInvalidation::invalidate):

layout/blockformatting/BlockInvalidation.h:
layout/blockformatting/BlockMarginCollapse.cpp:

(WebCore::Layout::isMarginTopCollapsedWithParent):
(WebCore::Layout::isMarginBottomCollapsedThrough):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::collapsedMarginTopFromFirstChild):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::nonCollapsedMarginTop):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::computedNonCollapsedMarginTop):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::computedNonCollapsedMarginBottom):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginTop):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::marginBottom):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::isMarginBottomCollapsedWithParent):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::collapsedMarginBottomFromLastChild):
(WebCore::Layout::BlockFormattingContext::Geometry::MarginCollapse::nonCollapsedMarginBottom):

layout/displaytree/DisplayBox.h:
layout/floats/FloatAvoider.cpp:

(WebCore::Layout::FloatAvoider::FloatAvoider):

layout/floats/FloatAvoider.h:
layout/floats/FloatBox.cpp:

(WebCore::Layout::FloatBox::FloatBox):

layout/floats/FloatBox.h:
layout/floats/FloatingContext.cpp:

(WebCore::Layout::FloatingContext::positionForFloat const):
(WebCore::Layout::FloatingContext::positionForFloatAvoiding const):
(WebCore::Layout::FloatingContext::verticalPositionWithClearance const):

layout/floats/FloatingContext.h:

(WebCore::Layout::FloatingContext::layoutState const):
(WebCore::Layout::FloatingContext::layoutContext const): Deleted.

layout/floats/FloatingState.cpp:

(WebCore::Layout::FloatingState::FloatItem::FloatItem):
(WebCore::Layout::FloatingState::FloatingState):
(WebCore::Layout::FloatingState::constraints const):

layout/floats/FloatingState.h:

(WebCore::Layout::FloatingState::create):
(WebCore::Layout::FloatingState::layoutState const):
(WebCore::Layout::FloatingState::layoutContext const): Deleted.

layout/inlineformatting/InlineFormattingContext.cpp:

layout/inlineformatting/InlineFormattingContext.h:
layout/inlineformatting/InlineFormattingContextGeometry.cpp:

(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockHeightAndMargin):

layout/inlineformatting/InlineFormattingState.cpp:

(WebCore::Layout::InlineFormattingState::InlineFormattingState):

layout/inlineformatting/InlineFormattingState.h:
layout/inlineformatting/InlineInvalidation.cpp:

(WebCore::Layout::InlineInvalidation::invalidate):

layout/inlineformatting/InlineInvalidation.h:
layout/inlineformatting/InlineLineBreaker.cpp:

(WebCore::Layout::InlineLineBreaker::InlineLineBreaker):
(WebCore::Layout::InlineLineBreaker::runWidth const):

layout/inlineformatting/InlineLineBreaker.h:
layout/layouttree/LayoutTreeBuilder.cpp:

(WebCore::Layout::outputInlineRuns):
(WebCore::Layout::outputLayoutTree):
(WebCore::Layout::showLayoutTree):

layout/layouttree/LayoutTreeBuilder.h:
page/FrameViewLayoutContext.cpp:

(WebCore::layoutUsingFormattingContext):

3:10 AM Changeset in webkit [237630] by commit-queue@webkit.org

2 edits in trunk/Source/JavaScriptCore

Static global 'fastHandlerInstalled' conditionally declared in WasmFaultSignalHandler.cpp
https://bugs.webkit.org/show_bug.cgi?id=191063

Patch by Jim Mason <jmason@ibinx.com> on 2018-10-31
Reviewed by Yusuke Suzuki.

wasm/WasmFaultSignalHandler.cpp:

2:56 AM Changeset in webkit [237629] by Antti Koivisto

3 edits in trunk/Source/WebKit

Stop using LayerFlushScheduler in WK2
https://bugs.webkit.org/show_bug.cgi?id=191065

Reviewed by Tim Horton.

Code gets more understandable when TiledCoreAnimationDrawingArea simply uses RunLoopObserver
directly for flush scheduling. LayerFlushScheduler can be later moved to WK1.

WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::~TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::setLayerTreeStateIsFrozen):
(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerFlush):
(WebKit::TiledCoreAnimationDrawingArea::dispatchAfterEnsuringUpdatedScrollPosition):
(WebKit::TiledCoreAnimationDrawingArea::layerFlushRunLoopCallback):
(WebKit::TiledCoreAnimationDrawingArea::invalidateLayerFlushRunLoopObserver):
(WebKit::TiledCoreAnimationDrawingArea::scheduleLayerFlushRunLoopObserver):

12:29 AM Changeset in webkit [237628] by Claudio Saavedra

4 edits in trunk/Source/WebKit

[WPE][GTK] Certificates loaded from the cache don't include the certificate chain
https://bugs.webkit.org/show_bug.cgi?id=190956

Reviewed by Youenn Fablet.

Similarly to what was done for the IPC coders, serialize
the entire certificate chain in the cache coder. Bump
the cache version due to the caching format changes.

NetworkProcess/cache/NetworkCacheCoders.h: Add GRefPtr<GByteArray> coders.
NetworkProcess/cache/NetworkCacheCodersSoup.cpp:

(WTF::Persistence::certificatesDataListFromCertificateInfo):
(WTF::Persistence::certificateFromCertificatesDataList): Helpers.
(WTF::Persistence::Coder<WebCore::CertificateInfo>::encode):
(WTF::Persistence::Coder<WebCore::CertificateInfo>::decode):
(WTF::Persistence::Coder<GRefPtr<GByteArray>>::encode):
(WTF::Persistence::Coder<GRefPtr<GByteArray>>::decode):

NetworkProcess/cache/NetworkCacheStorage.h: Bump the cache version.

Oct 30, 2018:

11:14 PM Changeset in webkit [237627] by yusukesuzuki@slowstart.org

6 edits in trunk/Source/JavaScriptCore

[JSC][LLInt] Compact LLInt ASM code by removing unnecessary instructions
https://bugs.webkit.org/show_bug.cgi?id=191092

Reviewed by Saam Barati.

Looking through LLIntAssembly.h, we can find several inefficiencies. This patch fixes the
following things to tighten LLInt ASM code.

Remove unnecessary load instructions. Use jmp with BaseIndex directly.
Introduce strength reduction for mul instructions in offlineasm layer. This is now critical

since mul instruction is executed in metadata operation in LLInt. If the given immediate is
a power of two, we convert it to lshift instruction.

llint/LowLevelInterpreter32_64.asm:
llint/LowLevelInterpreter64.asm:
offlineasm/arm64.rb:
offlineasm/instructions.rb:
offlineasm/x86.rb:

10:45 PM Changeset in webkit [237626] by bshafiei@apple.com

7 edits in tags/Safari-607.1.10.7/Source

Versioning.

10:41 PM Changeset in webkit [237625] by bshafiei@apple.com

1 copy in tags/Safari-607.1.10.7

New tag.

10:29 PM Changeset in webkit [237624] by Wenson Hsieh

25 edits
1 copy in trunk

[Cocoa] Attachment dropped from one web view to another is missing its file wrapper
https://bugs.webkit.org/show_bug.cgi?id=190530
<rdar://problem/45232149>

Reviewed by Tim Horton.

Source/WebCore:

Add support for copying and pasting attachment elements across web views by encoding and adding file wrapper
data as subresources in the web archive when writing selected web content to the pasteboard, and then decoding
and creating NSFileWrappers upon reading web content.

Test: WKAttachmentTests.CopyAndPasteBetweenWebViews

WebCore.xcodeproj/project.pbxproj:
editing/Editor.cpp:

(WebCore::Editor::registerAttachments):

editing/Editor.h:

Add registerAttachments(), which registers _WKAttachments in the UI process given a list of
SerializedAttachmentData. This behaves similarly to registerAttachmentIdentifiers(), but differs in that (1) it
sends serialized file wrapper data, and (2) it sends a list of serialized attachments, rather than information
about just a single attachment.

editing/SerializedAttachmentData.h:

Introduce SerializedAttachmentData, a struct containing information needed to serialize and deserialize an
attachment. These are used both when writing attachment data to the pasteboard, and when consuming attachment
data upon paste.

editing/cocoa/WebContentReaderCocoa.mm:

(WebCore::replaceRichContentWithAttachments):

Add a step when pasting rich content with attachments, to collect and send serialized attachments to the client.
Also, drive-by fix: don't WTFMove() the Ref here if it's still going to be used below.

html/HTMLAttachmentElement.cpp:

(WebCore::HTMLAttachmentElement::archiveResourceURL):

html/HTMLAttachmentElement.h:

Add a static helper function to compute a URL that represents the data for the given attachment identifier, for
use in a web archive resource.

loader/archive/cf/LegacyWebArchive.cpp:

(WebCore::addSubresourcesForAttachmentElementsIfNecessary):

Add a helper function to create and append ArchiveResources representing attachment element data when writing
attachments to the pasteboard via web archive data.

(WebCore::LegacyWebArchive::create):

page/EditorClient.h:

(WebCore::EditorClient::registerAttachments):
(WebCore::EditorClient::serializedAttachmentDataForIdentifiers):

Source/WebKit:

See WebCore ChangeLog for more details.

Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<SerializedAttachmentData>::encode):
(IPC::ArgumentCoder<SerializedAttachmentData>::decode):

Shared/WebCoreArgumentCoders.h:

Add IPC encoding/decoding support for SerializedAttachmentData.

UIProcess/API/APIAttachment.cpp:

(API::Attachment::createSerializedRepresentation const):
(API::Attachment::updateFromSerializedRepresentation):

UIProcess/API/APIAttachment.h:
UIProcess/API/Cocoa/APIAttachmentCocoa.mm:

(API::Attachment::createSerializedRepresentation const):

Add a method to serialize and return attachment info as a blob of data.

(API::Attachment::updateFromSerializedRepresentation):

Add a method to update the attachment, given a serialized blob of data. On Cocoa platforms, this fails
gracefully if the serialized data cannot be decoded.

UIProcess/Cocoa/PageClientImplCocoa.h:
UIProcess/Cocoa/PageClientImplCocoa.mm:

(WebKit::PageClientImplCocoa::allocFileWrapperInstance const):
(WebKit::PageClientImplCocoa::serializableFileWrapperClasses const):
(WebKit::PageClientImplCocoa::allocFileWrapperInstance): Deleted.

Add an additional hook to return the list of NSFileWrapper subclasses suitable for deserialization. This
array contains (at minimum) NSFileWrapper, but may additionally include a custom NSFileWrapper subclass, if
configured.

UIProcess/PageClient.h:

(WebKit::PageClient::allocFileWrapperInstance const):
(WebKit::PageClient::serializableFileWrapperClasses const):
(WebKit::PageClient::allocFileWrapperInstance): Deleted.

UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::registerAttachmentsFromSerializedData):

Registers the given serialized attachment data, creating new _WKAttachment instances if necessary. Currently,
this does not update the file wrappers of existing _WKAttachments; we should revisit this in the future to see
if we can additionally update file wrappers for existing attachments, without breaking the case where the user
copies and pastes or drags and drops attachments within a single web view and the client expects _WKAttachment
instances to be reused.

(WebKit::WebPageProxy::serializedAttachmentDataForIdentifiers):

UIProcess/WebPageProxy.h:
UIProcess/WebPageProxy.messages.in:
WebProcess/WebCoreSupport/WebEditorClient.cpp:

(WebKit::WebEditorClient::registerAttachments):
(WebKit::WebEditorClient::serializedAttachmentDataForIdentifiers):

Implement a new IPC hook to fetch an array of serialized attachment data blobs, given a list of attachment
identifiers.

WebProcess/WebCoreSupport/WebEditorClient.h:

Tools:

Add a test to verify that copying different types of attachments and pasting in a new web view inserts
attachments in the second web view that are backed by _WKAttachment objects, whose NSFileWrappers hold data that
is equivalent to the original file wrappers used to insert attachments in the first web view.

Existing API tests verify that when copying and pasting within a single web view, the pasted attachment element
is still backed by the same NSFileWrapper instance.

TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:

(TestWebKitAPI::TEST):

10:05 PM Changeset in webkit [237623] by Fujii Hironori

2 edits in trunk/Tools

[Win] Remove obsolete code for Visual Studio Express in webkitdirs.pm
https://bugs.webkit.org/show_bug.cgi?id=190949

Reviewed by Alex Christensen.

Visual Studio 2017 Community is the alternative.

Scripts/webkitdirs.pm: Remove $willUseVCExpressWhenBuilding variable.

(setupCygwinEnv): Remove obsolete code for Visual Studio Express.
(buildVisualStudioProject): Ditto.
(dieIfWindowsPlatformSDKNotInstalled): Deleted.
(usingVisualStudioExpress): Deleted.

9:48 PM Changeset in webkit [237622] by Fujii Hironori

2 edits in trunk/Tools

[Win][Direct2D] Support building DumpRenderTree for Direct2D
https://bugs.webkit.org/show_bug.cgi?id=191093
<rdar://problem/45685706>

Unreviewed build fix.

error C2065: 'renderTarget': undeclared identifier

DumpRenderTree/win/PixelDumpSupportWin.cpp:

(createBitmapContextFromWebView): Restored the previous implementation.

9:00 PM Changeset in webkit [237621] by don.olmstead@sony.com

9 edits
5 adds in trunk

[PlayStation] Enable JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=191072

Reviewed by Brent Fulgham.

Add support for building the PlayStation port through JavaScriptCore.

CMakeLists.txt:
Source/cmake/OptionsPlayStation.cmake: Added.

Source/JavaScriptCore:

Add platform files for the PlayStation port.

PlatformPlayStation.cmake: Added.

Source/ThirdParty:

Add platform files for the PlayStation port.

gtest/PlatformPlayStation.cmake: Added.

Source/WTF:

Add platform files for the PlayStation port.

wtf/PlatformPlayStation.cmake: Added.

Tools:

Add platform scripts for building the PlayStation port.
perl Tools/Scripts/build-webkit --playstation

Scripts/build-webkit:
Scripts/build-webkittestrunner:
Scripts/webkitdirs.pm:

(argumentsForConfiguration):
(determineConfigurationProductDir):
(isPlayStation): Added.
(getMSBuildPlatformArgument): Added.
(buildVisualStudioProject):
(wrapperPrefixIfNeeded):
(generateBuildSystemFromCMakeProject):

TestWebKitAPI/PlatformPlayStation.cmake: Added.

8:36 PM Changeset in webkit [237620] by ddkilzer@apple.com

7 edits
2 adds in trunk

XSLTProcessor should limit max transform depth
<https://webkit.org/b/191075>
<rdar://problem/45531453>

Reviewed by Alex Christensen.

Source/WebCore:

Test: fast/xsl/xslt-max-depth.html

xml/SoftLinkLibxslt.cpp: Add macro for xsltMaxDepth global.
xml/SoftLinkLibxslt.h: Ditto.
xml/XSLTProcessorLibxslt.cpp:

(WebCore::XSLTProcessor::transformToString): Set xsltMaxDepth
to 1000. Default in libxslt.dylib is 3000.

Source/WTF:

wtf/cocoa/SoftLinking.h:

(SOFT_LINK_VARIABLE_FOR_HEADER):
(SOFT_LINK_VARIABLE_FOR_SOURCE):

Add macros for non-constant global variables.

LayoutTests:

fast/xsl/xslt-max-depth-expected.txt: Added.
fast/xsl/xslt-max-depth.html: Added.

8:31 PM Changeset in webkit [237619] by Brent Fulgham

1 edit in trunk/Tools/DumpRenderTree/PlatformWin.cmake

Unreviewed build fix

7:30 PM Changeset in webkit [237618] by Chris Dumez

44 edits
14 adds in trunk/LayoutTests/imported/w3c

Resync XHR Web Platform Tests from upstream
https://bugs.webkit.org/show_bug.cgi?id=191085

Reviewed by Alex Christensen.

Resync XHR Web Platform Tests from upstream 75b0f336c5.

web-platform-tests/xhr/abort-after-stop.htm:
web-platform-tests/xhr/getallresponseheaders-expected.txt:
web-platform-tests/xhr/getallresponseheaders.htm:
web-platform-tests/xhr/getresponseheader.any-expected.txt: Added.
web-platform-tests/xhr/getresponseheader.any.html: Added.
web-platform-tests/xhr/getresponseheader.any.js: Added.

(async_test.t.client.onload.t.step_func_done):

web-platform-tests/xhr/getresponseheader.any.worker-expected.txt: Added.
web-platform-tests/xhr/getresponseheader.any.worker.html: Added.
web-platform-tests/xhr/headers-normalize-response-expected.txt:
web-platform-tests/xhr/headers-normalize-response.htm:
web-platform-tests/xhr/open-after-abort.htm:
web-platform-tests/xhr/open-after-stop.window-expected.txt: Added.
web-platform-tests/xhr/open-after-stop.window.html: Added.
web-platform-tests/xhr/open-after-stop.window.js: Added.

(onload):

web-platform-tests/xhr/overridemimetype-edge-cases.window-expected.txt:
web-platform-tests/xhr/overridemimetype-edge-cases.window.js:

(async_test.t.client.onload.t.step_func_done):
(async_test.t.client.onload.t.step_func):

web-platform-tests/xhr/resources/headers-www-authenticate.asis: Added.
web-platform-tests/xhr/resources/inspect-headers.py:

(get_response):

web-platform-tests/xhr/resources/responseXML-unavailable-in-worker.js:

(test):

web-platform-tests/xhr/resources/w3c-import.log:
web-platform-tests/xhr/resources/xmlhttprequest-timeout-aborted.js:
web-platform-tests/xhr/resources/xmlhttprequest-timeout-abortedonmain.js:
web-platform-tests/xhr/resources/xmlhttprequest-timeout-overrides.js:
web-platform-tests/xhr/resources/xmlhttprequest-timeout-overridesexpires.js:
web-platform-tests/xhr/resources/xmlhttprequest-timeout-simple.js:
web-platform-tests/xhr/resources/xmlhttprequest-timeout-synconmain.js:
web-platform-tests/xhr/resources/xmlhttprequest-timeout-synconworker.js:
web-platform-tests/xhr/resources/xmlhttprequest-timeout-twice.js:
web-platform-tests/xhr/resources/xmlhttprequest-timeout.js:

(AbortedRequest):
(SyncRequestSettingTimeoutAfterOpen.this.startXHR):
(SyncRequestSettingTimeoutAfterOpen):
(SyncRequestSettingTimeoutBeforeOpen.this.startXHR):
(SyncRequestSettingTimeoutBeforeOpen):
(runTestRequests):

web-platform-tests/xhr/send-content-type-charset-expected.txt:
web-platform-tests/xhr/send-content-type-charset.htm:
web-platform-tests/xhr/send-data-readablestream.any-expected.txt: Added.
web-platform-tests/xhr/send-data-readablestream.any.html: Added.
web-platform-tests/xhr/send-data-readablestream.any.js: Added.

(assert_xhr):
(test):
(promise_test.async):

web-platform-tests/xhr/send-data-readablestream.any.worker-expected.txt: Added.
web-platform-tests/xhr/send-data-readablestream.any.worker.html: Added.
web-platform-tests/xhr/setrequestheader-allow-empty-value-expected.txt:
web-platform-tests/xhr/setrequestheader-allow-whitespace-in-value-expected.txt:
web-platform-tests/xhr/setrequestheader-header-allowed-expected.txt:
web-platform-tests/xhr/setrequestheader-header-allowed.htm:
web-platform-tests/xhr/timeout-multiple-fetches.html:
web-platform-tests/xhr/w3c-import.log:
web-platform-tests/xhr/xmlhttprequest-timeout-aborted.html:
web-platform-tests/xhr/xmlhttprequest-timeout-abortedonmain.html:
web-platform-tests/xhr/xmlhttprequest-timeout-overrides.html:
web-platform-tests/xhr/xmlhttprequest-timeout-overridesexpires.html:
web-platform-tests/xhr/xmlhttprequest-timeout-simple.html:
web-platform-tests/xhr/xmlhttprequest-timeout-synconmain-expected.txt:
web-platform-tests/xhr/xmlhttprequest-timeout-synconmain.html:
web-platform-tests/xhr/xmlhttprequest-timeout-twice.html:
web-platform-tests/xhr/xmlhttprequest-timeout-worker-aborted.html:
web-platform-tests/xhr/xmlhttprequest-timeout-worker-overrides.html:
web-platform-tests/xhr/xmlhttprequest-timeout-worker-overridesexpires.html:
web-platform-tests/xhr/xmlhttprequest-timeout-worker-simple.html:
web-platform-tests/xhr/xmlhttprequest-timeout-worker-synconworker.html:
web-platform-tests/xhr/xmlhttprequest-timeout-worker-twice.html:

7:29 PM Changeset in webkit [237617] by commit-queue@webkit.org

2 edits in trunk/Source/WebCore

[GTK] Scrollbars not following gtk-primary-button-warps-slider setting
https://bugs.webkit.org/show_bug.cgi?id=191067

Patch by Jim Mason <jmason@ibinx.com> on 2018-10-30
Reviewed by Michael Catanzaro.

platform/gtk/ScrollbarThemeGtk.cpp:

(WebCore::ScrollbarThemeGtk::handleMousePressEvent):

7:29 PM Changeset in webkit [237616] by Brent Fulgham

5 edits
2 adds in trunk/Tools

[Win][Direct2D] Support building DumpRenderTree for Direct2D
https://bugs.webkit.org/show_bug.cgi?id=191093
<rdar://problem/45685706>

Reviewed by Alex Christensen.

DumpRenderTree/PixelDumpSupport.cpp: Update for Direct2D use.
DumpRenderTree/PlatformWin.cmake: Add support for Direct2D build.
DumpRenderTree/win/PixelDumpSupportDirect2D.cpp: Added.

(pixelDumpSystemFactory): Added.
(printPNG): Create stub.
(computeMD5HashStringForBitmapContext): Ditto.
(dumpBitmap): Ditto.

DumpRenderTree/win/PixelDumpSupportDirect2D.h: Added.

(BitmapContext::createByAdoptingBitmapAndContext):
(BitmapContext::~BitmapContext):
(BitmapContext::platformContext const):
(BitmapContext::BitmapContext):

DumpRenderTree/win/PixelDumpSupportWin.cpp:

(createBitmapContextFromWebView): Update to support Direct2D.

MiniBrowser/win/MiniBrowserReplace.h: Drive-by fix: The old WebKit

logo is no longer available at this location. Switch to the new logo.

7:27 PM Changeset in webkit [237615] by Chris Dumez

4 edits in trunk/Source/WebKit

[PSON] View gesture snapshot gets taken down early when process-swapping
https://bugs.webkit.org/show_bug.cgi?id=191083
<rdar://problem/45058738>

Reviewed by Alex Christensen.

When process-swapping, we would call WebViewImpl::processDidExit(), which would destroy
the ViewGestureController and thus take down the swipe navigation snapshot before it
should. We now call WebViewImpl::processDidSwap() instead, which does the same thing,
except for destroying the ViewGestureController. As a result, the view snapshot stays
visible as long as it is needed, even in case of process swap.

UIProcess/Cocoa/WebViewImpl.h:
UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::handleProcessSwapOrExit):
(WebKit::WebViewImpl::processWillSwap):
(WebKit::WebViewImpl::processDidExit):

UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::processWillSwap):

7:27 PM Changeset in webkit [237614] by Chris Dumez

2 edits in trunk/Source/WebKit

[PSON] WebView renders with incorrect dimensions after back or forward
https://bugs.webkit.org/show_bug.cgi?id=191071
<rdar://problem/45058950>

Reviewed by Alex Christensen.

Make sure WebPage::reinitializeWebPage() updates the page's dimensions if needed using the
WebPageCreationParameters it is provided.

WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::reinitializeWebPage):

6:11 PM Changeset in webkit [237613] by Devin Rousso

19 edits
2 moves
46 adds
10 deletes in trunk

Web Inspector: Audit: create Audit Tab
https://bugs.webkit.org/show_bug.cgi?id=190754

Reviewed by Matt Baker.

Source/WebInspectorUI:

Create an Audit tab for running audits on the inspected page. Leverage Runtime.evaluate
for running the audit tests (arbitrary JavaScript), and use the returned value to generate
a preview UI of the results. All tests/results can be exported/imported to formatted JSON:

AuditTestCase JSON:

{

"type": "test-case",
"name": <string>,
<optional> "description": <string>,
"test": <stringified JavaScript function>,

}

AuditTestGroup JSON:

{

"type": "test-group",
"name": <string>,
<optional> "description": <string>,
"tests": [...<AuditTestCase, AuditTestGroup>],

}

AuditTestCaseResult JSON:

{

"type": "test-case-result",
"name": <string>,
<optional> "description": <string>,
"level": <"pass", "warn", "fail", "error", "unsupported">,
"data": {

"domNodes": [...<stringified CSS path>],
"domAttributes": [...<string>],
"errors": [...<string>],

},

}

AuditTestGroupResult JSON:

{

"type": "test-group-result",
"name": <string>,
<optional> "description": <string>,
"results": [...<AuditTestCaseResult, AuditTestGroupResult>],

}

More keys may be added in the future (especially for AuditTestCaseResult.data).

UserInterface/Controllers/AuditManager.js:

(WI.AuditManager):
(WI.AuditManager.synthesizeError): Added.
(WI.AuditManager.prototype.get tests): Added.
(WI.AuditManager.prototype.get results): Added.
(WI.AuditManager.prototype.get runningState): Added.
(WI.AuditManager.prototype.start): Added.
(WI.AuditManager.prototype.stop): Added.
(WI.AuditManager.prototype.import): Added.
(WI.AuditManager.prototype.export): Added.
(WI.AuditManager.prototype._addTest): Added.
(WI.AuditManager.prototype._addResult): Added.
(WI.AuditManager.prototype.get testSuites): Deleted.
(WI.AuditManager.prototype.get reports): Deleted.
(WI.AuditManager.prototype.async runAuditTestByRepresentedObject): Deleted.
(WI.AuditManager.prototype.reportForId): Deleted.
(WI.AuditManager.prototype.removeAllReports): Deleted.
(WI.AuditManager.prototype.async _runTestCase): Deleted.

UserInterface/Models/AuditTestBase.js: Added.

(WI.AuditTestBases):
(WI.AuditTestBases.prototype.get name):
(WI.AuditTestBases.prototype.get description):
(WI.AuditTestBases.prototype.get runningState):
(WI.AuditTestBases.prototype.get result):
(WI.AuditTestBases.prototype.async start):
(WI.AuditTestBases.prototype.stop):
(WI.AuditTestBases.prototype.clearResult):
(WI.AuditTestBases.prototype.saveIdentityToCookie):
(WI.AuditTestBases.prototype.toJSON):
(WI.AuditTestBases.prototype.async run):

UserInterface/Models/AuditTestCase.js:

(WI.AuditTestCase):
(WI.AuditTestCase.fromPayload): Added.
(WI.AuditTestCase.prototype.toJSON): Added.
(WI.AuditTestCase.prototype.async run): Added.
(WI.AuditTestCase.prototype.async run.setLevel): Added.
(WI.AuditTestCase.prototype.async run.addError): Added.
(WI.AuditTestCase.prototype.async run.checkResultProperty.addErrorForValueType): Added.
(WI.AuditTestCase.prototype.async run.checkResultProperty): Added.
(WI.AuditTestCase.prototype.async run.async resultArrayForEach): Added.
(WI.AuditTestCase.prototype.get id): Deleted.
(WI.AuditTestCase.prototype.get name): Deleted.
(WI.AuditTestCase.prototype.get suite): Deleted.
(WI.AuditTestCase.prototype.get setup): Deleted.
(WI.AuditTestCase.prototype.get tearDown): Deleted.
(WI.AuditTestCase.prototype.get errorDetails): Deleted.

UserInterface/Models/AuditTestGroup.js: Added.

(WI.AuditTestGroup):
(WI.AuditTestGroup.fromPayload):
(WI.AuditTestGroup.prototype.get tests):
(WI.AuditTestGroup.prototype.stop):
(WI.AuditTestGroup.prototype.clearResult):
(WI.AuditTestGroup.prototype.async run):
(WI.AuditTestGroup.prototype.toJSON):
(WI.AuditTestGroup.prototype._updateResult):
(WI.AuditTestGroup.prototype._handleTestCompleted):
(WI.AuditTestGroup.prototype._handleTestProgress):

UserInterface/Models/AuditTestResultBase.js: Added.

(WI.AuditTestResultBase):
(WI.AuditTestResultBase.prototype.get name):
(WI.AuditTestResultBase.prototype.get description):
(WI.AuditTestResultBase.prototype.get result):
(WI.AuditTestResultBase.prototype.get didPass):
(WI.AuditTestResultBase.prototype.get didWarn):
(WI.AuditTestResultBase.prototype.get didFail):
(WI.AuditTestResultBase.prototype.get didError):
(WI.AuditTestResultBase.prototype.get unsupported):
(WI.AuditTestResultBase.prototype.saveIdentityToCookie):
(WI.AuditTestResultBase.prototype.toJSON):

UserInterface/Models/AuditTestCaseResult.js: Added.

(WI.AuditTestCaseResult):
(WI.AuditTestCaseResult.fromPayload.checkArray):
(WI.AuditTestCaseResult.fromPayload):
(WI.AuditTestCaseResult.prototype.get level):
(WI.AuditTestCaseResult.prototype.get data):
(WI.AuditTestCaseResult.prototype.get didPass):
(WI.AuditTestCaseResult.prototype.get didWarn):
(WI.AuditTestCaseResult.prototype.get didFail):
(WI.AuditTestCaseResult.prototype.get didError):
(WI.AuditTestCaseResult.prototype.get unsupported):
(WI.AuditTestCaseResult.prototype.toJSON):

UserInterface/Models/AuditTestGroupResult.js: Added.

(WI.AuditTestGroupResult):
(WI.AuditTestGroupResult.fromPayload):
(WI.AuditTestGroupResult.prototype.get results):
(WI.AuditTestGroupResult.prototype.get levelCounts):
(WI.AuditTestGroupResult.prototype.get didPass):
(WI.AuditTestGroupResult.prototype.get didWarn):
(WI.AuditTestGroupResult.prototype.get didFail):
(WI.AuditTestGroupResult.prototype.get didError):
(WI.AuditTestGroupResult.prototype.get unsupported):
(WI.AuditTestGroupResult.prototype.toJSON):

UserInterface/Views/AuditTabContentView.js: Added.

(WI.AuditTabContentView):
(WI.AuditTabContentView.tabInfo):
(WI.AuditTabContentView.isTabAllowed):
(WI.AuditTabContentView.prototype.get type):
(WI.AuditTabContentView.prototype.get supportsSplitContentBrowser):
(WI.AuditTabContentView.prototype.canShowRepresentedObject):
(WI.AuditTabContentView.prototype.shown):
(WI.AuditTabContentView.prototype.hidden):
(WI.AuditTabContentView.prototype._handleSpace):

UserInterface/Views/AuditNavigationSidebarPanel.js: Added.

(WI.AuditNavigationSidebarPanel):
(WI.AuditNavigationSidebarPanel.prototype.showDefaultContentView):
(WI.AuditNavigationSidebarPanel.prototype.initialLayout):
(WI.AuditNavigationSidebarPanel.prototype.closed):
(WI.AuditNavigationSidebarPanel.prototype._addTest):
(WI.AuditNavigationSidebarPanel.prototype._addResult):
(WI.AuditNavigationSidebarPanel.prototype._updateStartStopButtonNavigationItemState):
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestAdded):
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestCompleted):
(WI.AuditNavigationSidebarPanel.prototype._handleAuditTestScheduled):
(WI.AuditNavigationSidebarPanel.prototype._treeSelectionDidChange):
(WI.AuditNavigationSidebarPanel.prototype._handleStartStopButtonNavigationItemClicked):
(WI.AuditNavigationSidebarPanel.prototype._handleImportButtonNavigationItemClicked):

UserInterface/Views/AuditNavigationSidebarPanel.css: Added.

(.sidebar > .panel.navigation.audit > .content):

UserInterface/Views/AuditTreeElement.js: Added.

(WI.AuditTreeElement):
(WI.AuditTreeElement.prototype.get result):
(WI.AuditTreeElement.prototype.onattach):
(WI.AuditTreeElement.prototype.ondetach):
(WI.AuditTreeElement.prototype.onpopulate):
(WI.AuditTreeElement.prototype.populateContextMenu):
(WI.AuditTreeElement.prototype._start):
(WI.AuditTreeElement.prototype._updateLevel):
(WI.AuditTreeElement.prototype._showRunningSpinner):
(WI.AuditTreeElement.prototype._showRunningProgress):
(WI.AuditTreeElement.prototype._handleTestCaseCompleted):
(WI.AuditTreeElement.prototype._handleTestResultCleared):
(WI.AuditTreeElement.prototype._handleTestCaseScheduled):
(WI.AuditTreeElement.prototype._handleTestGroupCompleted):
(WI.AuditTreeElement.prototype._handleTestGroupProgress):
(WI.AuditTreeElement.prototype._handleTestGroupScheduled):
(WI.AuditTreeElement.prototype._handleStatusClick):

UserInterface/Views/AuditTreeElement.css: Added.

(.tree-outline .item.audit > .status):
(.tree-outline .item.audit > .status > img):
(.tree-outline .item.audit:matches(.test-case, .test-group) > .status:hover > img):
(.tree-outline .item.audit > .status:not(:hover) > img.show-on-hover, .tree-outline .item.audit.test-group.expanded > .status:not(:hover)):
(.tree-outline .item.audit.test-group.expanded > .status:hover > :not(img), .tree-outline .item.audit.test-group-result.expanded > .status):
(.tree-outline .item.audit > .status > img.pass):
(.tree-outline .item.audit > .status > img.warn):
(.tree-outline .item.audit > .status > img.fail):
(.tree-outline .item.audit > .status > img.error):
(.tree-outline .item.audit > .status > img.unsupported):
(.audit.test-case .icon):
(.audit.test-group .icon):
(.audit.test-case-result .icon):
(.audit.test-group-result .icon):

UserInterface/Views/AuditTestContentView.js: Added.

(WI.AuditTestContentView):
(WI.AuditTestContentView.prototype.get navigationItems):
(WI.AuditTestContentView.prototype.get headerView):
(WI.AuditTestContentView.prototype.get contentView):
(WI.AuditTestContentView.prototype.get supportsSave):
(WI.AuditTestContentView.prototype.get saveData):
(WI.AuditTestContentView.prototype.initialLayout):
(WI.AuditTestContentView.prototype.layout):
(WI.AuditTestContentView.prototype.shown):
(WI.AuditTestContentView.prototype.hidden):
(WI.AuditTestContentView.prototype.get placeholderElement):
(WI.AuditTestContentView.prototype.set placeholderElement):
(WI.AuditTestContentView.prototype.showRunningPlaceholder):
(WI.AuditTestContentView.prototype.showStoppingPlaceholder):
(WI.AuditTestContentView.prototype.showNoResultPlaceholder):
(WI.AuditTestContentView.prototype.showNoResultDataPlaceholder):
(WI.AuditTestContentView.prototype.showFilteredPlaceholder):
(WI.AuditTestContentView.prototype.hidePlaceholder):
(WI.AuditTestContentView.prototype.applyFilter):
(WI.AuditTestContentView.prototype.resetFilter):
(WI.AuditTestContentView.prototype._exportAudit):
(WI.AuditTestContentView.prototype._updateExportButtonNavigationItemState):
(WI.AuditTestContentView.prototype._showPlaceholder):
(WI.AuditTestContentView.prototype._handleExportButtonNavigationItemClicked):
(WI.AuditTestContentView.prototype._handleTestChanged):

UserInterface/Views/AuditTestContentView.css: Added.

(.content-view-container > .content-view.audit-test):
(.content-view-container > .content-view.audit-test > header):
(.content-view-container > .content-view.audit-test > header h1):
(.content-view-container > .content-view.audit-test > header p):
(.content-view.audit-test):
(.content-view.audit-test h1):
(.content-view.audit-test > header):
(.content-view.audit-test > header p):
(.content-view.audit-test .audit-test.filtered, .content-view.audit-test .audit-test .message-text-view):
(.content-view.audit-test > section):
(.content-view.audit-test > section > .message-text-view):
(.content-view.audit-test.showing-placeholder):
(.content-view.audit-test.showing-placeholder > section):
(.content-view.audit-test.showing-placeholder > section > :not(.message-text-view)):
(@media (prefers-dark-interface) .content-view.audit-test):

UserInterface/Views/AuditTestCaseContentView.js: Added.

(WI.AuditTestCaseContentView):
(WI.AuditTestCaseContentView.prototype.initialLayout):
(WI.AuditTestCaseContentView.prototype.layout):
(WI.AuditTestCaseContentView.prototype.showRunningPlaceholder):

UserInterface/Views/AuditTestCaseContentView.css: Added.

(.content-view-container > .content-view.audit-test-case > header):
(.content-view-container > .content-view.audit-test-case > section > :not(.message-text-view):first-child):
(.content-view.audit-test-case > header > h1):
(.content-view.audit-test-case > header > h1 > img):
(.content-view.audit-test-case > section > :not(.message-text-view)):
(.content-view.audit-test-case > section > :not(.message-text-view):last-child):
(.content-view.audit-test-case > section > :not(.message-text-view) + :not(.message-text-view)):
(.content-view.audit-test-case > section h1):
(.content-view.audit-test-case > section table):
(.content-view.audit-test-case > section table > tr + tr > td):
(.content-view.audit-test-case > section table > tr > td > :not(.tree-outline)):
(.content-view.audit-test-case > section table > tr > td:first-child):
(.content-view.audit-test-case > section > .dom-nodes > table > tr > td:first-child):
(.content-view.audit-test-case > section code):
(.content-view.audit-test-case > section mark):

UserInterface/Views/AuditTestGroupContentView.js: Added.

(WI.AuditTestGroupContentView):
(WI.AuditTestGroupContentView.prototype.initialLayout):
(WI.AuditTestGroupContentView.prototype.layout):
(WI.AuditTestGroupContentView.prototype.shown):
(WI.AuditTestGroupContentView.prototype.hidden):
(WI.AuditTestGroupContentView.prototype.applyFilter):
(WI.AuditTestGroupContentView.prototype.resetFilter):
(WI.AuditTestGroupContentView.prototype.showRunningPlaceholder):
(WI.AuditTestGroupContentView.prototype._subobjects):
(WI.AuditTestGroupContentView.prototype._updateLevelScopeBar):
(WI.AuditTestGroupContentView.prototype._handleTestGroupCompleted):
(WI.AuditTestGroupContentView.prototype._handleTestGroupProgress):
(WI.AuditTestGroupContentView.prototype._handleTestGroupScheduled):
(WI.AuditTestGroupContentView.prototype._handleLevelScopeBarSelectionChanged):

UserInterface/Views/AuditTestGroupContentView.css: Added.

(.content-view-container > .content-view.audit-test-group > header):
(.content-view.audit-test-group > header):
(.content-view.audit-test-group.no-matches + .audit-test-group > header):
(.content-view.audit-test-group > header, .content-view.audit-test-group:not(.filtered):last-child > header):
(.content-view.audit-test-group.contains-test-case > header):
(.content-view.audit-test-group.contains-test-case + .audit-test-group.contains-test-case):
(.content-view.audit-test-group.contains-test-case:not(.contains-test-group) > section, .content-view.audit-test-group.contains-test-case.contains-test-group > section > .audit-test-case):
(.content-view.audit-test-group > header > .information):
(.content-view.audit-test-group > header > .information > p):
(.content-view.audit-test-group > header > nav):
(.content-view.audit-test-group > header > nav:empty):
(.content-view.audit-test-group > header > nav:not(:empty):before):
(.content-view.audit-test-group > header > nav > .scope-bar > li):
(.content-view.audit-test-group > header > nav > .scope-bar > li:not(:hover, .selected)):
(.content-view.audit-test-group > header > nav > .scope-bar > li:last-child):
(.content-view.audit-test-group > header > nav > .scope-bar > li::before):
(.content-view.audit-test-group > header > nav > .scope-bar > li.pass::before):
(.content-view.audit-test-group > header > nav > .scope-bar > li.warn::before):
(.content-view.audit-test-group > header > nav > .scope-bar > li.fail::before):
(.content-view.audit-test-group > header > nav > .scope-bar > li.error::before):
(.content-view.audit-test-group > header > nav > .scope-bar > li.unsupported::before):
(.content-view.audit-test-group > header > .percentage-pass):
(.content-view.audit-test-group > header > .percentage-pass:not(:empty)::after):
(.content-view.audit-test-group > section > .audit-test-case:first-child, .content-view.audit-test-group > section > .audit-test-group + .audit-test-case, .content-view.audit-test-group > section > .audit-test-case + .audit-test-group):
(.content-view.audit-test-group > section > .audit-test-case:last-child):

UserInterface/Views/ScopeBarItem.js:

(WI.ScopeBarItem):
(WI.ScopeBarItem.prototype.set selected):

UserInterface/Views/MultipleScopeBarItem.js:

(WI.MultipleScopeBarItem.prototype.set selectedScopeBarItem):
Add an independent option that prevents selection changes from deselecting other
WI.ScopeBarItems in the same WI.ScopeBar (exclusive takes precedence).

UserInterface/Views/DOMTreeElement.js:

(WI.DOMTreeElement):
(WI.DOMTreeElement.prototype.highlightAttribute):
(WI.DOMTreeElement.prototype._buildAttributeDOM):

UserInterface/Views/DOMTreeOutline.css:

(.tree-outline.dom li .highlight):

UserInterface/Views/ToggleButtonNavigationItem.js:

(WI.ToggleButtonNavigationItem.prototype.set toggled):
Also change the label if the ButtonStyle has text.

UserInterface/Base/Setting.js:
UserInterface/Views/SettingsTabContentView.js:

(WI.SettingsTabContentView.prototype._createExperimentalSettingsView):

UserInterface/Views/DividerNavigationItem.css:

(.navigation-bar .item.divider):

UserInterface/Base/Utilities.js:

(Promise.chain): Added.

UserInterface/Views/ContentView.js:

(WI.ContentView.createFromRepresentedObject):
(WI.ContentView.isViewable):

UserInterface/Main.html:
UserInterface/Base/Main.js:

(WI.loaded):
(WI.contentLoaded):

UserInterface/Test.html:
UserInterface/Base/Test.js:

(WI.loaded):

UserInterface/Images/Audit.svg: Added.
UserInterface/Images/AuditStart.svg: Added.
UserInterface/Images/AuditStop.svg: Added.
UserInterface/Images/AuditTestCase.svg: Added.
UserInterface/Images/AuditTestCaseResult.svg: Added.
UserInterface/Images/AuditTestError.svg: Added.
UserInterface/Images/AuditTestFail.svg: Added.
UserInterface/Images/AuditTestGroup.svg: Added.
UserInterface/Images/AuditTestGroupResult.svg: Added.
UserInterface/Images/AuditTestNoResult.svg: Added.
UserInterface/Images/AuditTestPass.svg: Added.
UserInterface/Images/AuditTestUnsupported.svg: Added.
UserInterface/Images/AuditTestWarn.svg: Added.

Localizations/en.lproj/localizedStrings.js:

LayoutTests:

inspector/audit/resources/audit-utilities.js: Added.
inspector/audit/basic-expected.txt: Added.
inspector/audit/basic.html: Added.
inspector/audit/data-domAttributes-expected.txt: Added.
inspector/audit/data-domAttributes.html: Added.
inspector/audit/data-domNodes-expected.txt: Added.
inspector/audit/data-domNodes.html: Added.
inspector/audit/data-errors-expected.txt: Added.
inspector/audit/data-errors.html: Added.
inspector/model/auditTestCase-expected.txt: Added.
inspector/model/auditTestCase.html: Added.
inspector/model/auditTestCaseResult-expected.txt: Added.
inspector/model/auditTestCaseResult.html: Added.
inspector/model/auditTestGroup-expected.txt: Added.
inspector/model/auditTestGroup.html: Added.
inspector/model/auditTestGroupResult-expected.txt: Added.
inspector/model/auditTestGroupResult.html: Added.
inspector/unit-tests/promise-utilities-expected.txt: Added.
inspector/unit-tests/promise-utilities.html: Added.

inspector/audit/audit-manager-expected.txt: Removed.
inspector/audit/audit-manager.html: Removed.
inspector/audit/audit-report-expected.txt: Removed.
inspector/audit/audit-report.html: Removed.
inspector/audit/audit-test-case-expected.txt: Removed.
inspector/audit/audit-test-case.html: Removed.
inspector/audit/audit-test-suite-expected.txt: Removed.
inspector/audit/audit-test-suite.html: Removed.
inspector/audit/resources/audit-test-fixtures.js: Removed.

5:44 PM Changeset in webkit [237612] by Jonathan Bedard

3 edits in trunk/Tools

webkitpy: Support alternate simctl list outputs
https://bugs.webkit.org/show_bug.cgi?id=191090
<rdar://problem/45684255>

Rubber-stamped by Aakash Jain.

Scripts/webkitpy/xcode/simulated_device.py:

(SimulatedDeviceManager._create_runtimes): Support alternative availability format.
(SimulatedDeviceManager._create_device_with_runtime): Ditto.

Scripts/webkitpy/xcode/simulated_device_unittest.py:

(test_available_devices): Add iOS 12 with alternative availability format.

5:38 PM Changeset in webkit [237611] by Dewei Zhu

2 edits in trunk/Source/WebKit

Move 'ProcessSwapOnCrossSiteNavigationEnabled' to 'experimental' category.
https://bugs.webkit.org/show_bug.cgi?id=191049

Reviewed by Dean Jackson.

Move the feature flag to experimental feature section.

Shared/WebPreferences.yaml:

5:15 PM Changeset in webkit [237610] by ap@apple.com

9 edits
1 add in trunk/Source

Enable InstallAPI for iOS unconditionally
https://bugs.webkit.org/show_bug.cgi?id=191043
rdar://problem/32728423

Reviewed by Dan Bernstein.

Source/WebKit:

Configurations/Base.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an

excluded header - WebKit doesn't export NSURLDownload, so the definition
shouldn't be processed by InstallAPI.

Source/WebKitLegacy:

WebKitLegacy.xcodeproj/project.pbxproj: Added NSURLDownloadSPI.h.

Source/WebKitLegacy/mac:

Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an

excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
shouldn't be processed by InstallAPI.

MigrateHeaders.make: Removed an obsolete workaround.
Misc/NSURLDownloadSPI.h: Added.
Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.

4:45 PM Changeset in webkit [237609] by realdawei@apple.com

2 edits in trunk/LayoutTests

WebGL conformance: Failures and Timeouts in suite 2.0.0/conformance
https://bugs.webkit.org/show_bug.cgi?id=189641

Unreviewed.

Patch by Dawei Fenton <realdawei@apple.com> on 2018-10-30

platform/ios-wk2/TestExpectations: Mark test as [ Slow ]

4:06 PM Changeset in webkit [237608] by Devin Rousso

4 edits in trunk

Web Inspector: provide options to WI.cssPath for more verbosity
https://bugs.webkit.org/show_bug.cgi?id=190987

Reviewed by Brian Burg.

Source/WebInspectorUI:

UserInterface/Base/DOMUtilities.js:

(WI.cssPath):
(WI.cssPathComponent):
When the option full is true, print every attribute along with every node in the hierarchy
until the root is reached. This partially duplicates the effect of an XPath, but instead
uses CSS selectors, making it much more human readable and recognizable.

LayoutTests:

inspector/dom/domutilities-csspath.html:

3:45 PM Changeset in webkit [237607] by ap@apple.com

32 edits
1 delete in trunk

Clean up some obsolete MAX_ALLOWED macros
https://bugs.webkit.org/show_bug.cgi?id=190916

Reviewed by Tim Horton.

Source/JavaScriptCore:

API/JSManagedValue.mm:
API/JSVirtualMachine.mm:
API/JSWrapperMap.mm:

Source/ThirdParty/libwebrtc:

Source/webrtc/sdk/WebKit/VideoProcessingSoftLink.h:

Source/WebCore:

platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::exernalDeviceDisplayNameForPlayer):

platform/mac/PlatformEventFactoryMac.mm:

(WebCore::globalPointForEvent):
(WebCore::pointForEvent):
(WebCore::mouseButtonForEvent):
(WebCore::PlatformMouseEventBuilder::PlatformMouseEventBuilder):

Source/WebCore/PAL:

pal/cf/CoreMediaSoftLink.cpp:
pal/cf/CoreMediaSoftLink.h:

Behavior change here. The check didn't really make sense, pretty sure we would
just crash when hitting this code path on iOS.

pal/spi/cf/CFNetworkSPI.h:
pal/spi/cocoa/PassKitSPI.h:
pal/spi/mac/AVFoundationSPI.h:

Source/WebKit:

NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:

(WebKit::NetworkDataTaskCocoa::applySniffingPoliciesAndBindRequestToInferfaceIfNeeded):

Platform/spi/Cocoa/DeviceIdentitySPI.h:
Platform/spi/ios/UIKitSPI.h:
Shared/WebPreferencesDefaultValues.cpp:

(defaultCustomPasteboardDataEnabled):

UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:

(WebKit::toPKPaymentRequest):

UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView changeSelectionWithTouchAt:withSelectionTouch:baseIsStart:]): Deleted.

Source/WebKitLegacy/mac:

WebView/WebHTMLView.mm:

(-[WebHTMLView pressureChangeWithEvent:]):

WebView/WebPDFView.h:

Source/WTF:

WTF.xcodeproj/project.pbxproj:
wtf/PlatformMac.cmake:
wtf/spi/cocoa/NSMapTableSPI.h: Removed. This was only needed for old SDKs.

Tools:

TestWebKitAPI/Tests/WTF/darwin/WeakLinking.cpp:
TestWebKitAPI/Tests/WebKitCocoa/WKHTTPCookieStore.mm:
TestWebKitAPI/Tests/ios/DragAndDropTestsIOS.mm:

3:35 PM Changeset in webkit [237606] by commit-queue@webkit.org

9 edits
1 delete in trunk/Source

Unreviewed, rolling out r237600 and r237604.
https://bugs.webkit.org/show_bug.cgi?id=191086

Breaks internal iOS builds (Requested by ryanhadd_ on
#webkit).

Reverted changesets:

"Enable InstallAPI for iOS unconditionally"
https://bugs.webkit.org/show_bug.cgi?id=191043
https://trac.webkit.org/changeset/237600

"Build fix attempt after enabling InstallAPI for iOS."
https://bugs.webkit.org/show_bug.cgi?id=191043
https://trac.webkit.org/changeset/237604

3:15 PM Changeset in webkit [237605] by Devin Rousso

6 edits
1 copy in trunk/Source/WebInspectorUI

Web Inspector: change WI.ColorWheel to use conic-gradient()
https://bugs.webkit.org/show_bug.cgi?id=189485

Reviewed by Brian Burg.

Use the ("new") HSL WI.ColorPicker if conic-gradient is supported. Otherwise, use the
("old") RGB WI.LegacyColorPicker.

UserInterface/Views/ColorWheel.js:

(WI.ColorWheel):
(WI.ColorWheel.prototype.set dimension):
(WI.ColorWheel.prototype.set brightness):
(WI.ColorWheel.prototype.get tintedColor):
(WI.ColorWheel.prototype.set tintedColor):
(WI.ColorWheel.prototype.get rawColor):
(WI.ColorWheel.prototype.get _hue): Added.
(WI.ColorWheel.prototype.get _saturation): Added.
(WI.ColorWheel.prototype._updateColorForMouseEvent):
(WI.ColorWheel.prototype._setCrosshairPosition):
(WI.ColorWheel.prototype._updateGradient): Added.
(WI.ColorWheel.prototype._pointInCircleForEvent.distance): Deleted.
(WI.ColorWheel.prototype._pointInCircleForEvent.angleFromCenterToPoint): Deleted.
(WI.ColorWheel.prototype._pointInCircleForEvent.pointOnCircumference): Deleted.
(WI.ColorWheel.prototype._pointInCircleForEvent): Deleted.
(WI.ColorWheel.prototype._tintedColorToPointAndBrightness): Deleted.
(WI.ColorWheel.prototype._drawRawCanvas): Deleted.
(WI.ColorWheel.prototype._colorAtPointWithBrightness): Deleted.
(WI.ColorWheel.prototype._drawTintedCanvas): Deleted.
(WI.ColorWheel.prototype._draw): Deleted.

UserInterface/Views/ColorWheel.css:

(.color-wheel > .gradient): Added.
(.color-wheel > .crosshair): Added.

UserInterface/Views/LegacyColorWheel.js: Copied from Source/WebInspectorUI/UserInterface/Views/ColorWheel.js.

UserInterface/Views/ColorPicker.js:

(WI.ColorPicker):
(WI.ColorPicker.supportsConicGradient): Added.
(WI.ColorPicker.prototype._updateSliders):

UserInterface/Models/Geometry.js:

(WI.Point.prototype.distance):

UserInterface/Main.html:

3:10 PM Changeset in webkit [237604] by ap@apple.com

2 edits in trunk/Source/WebKit

Build fix attempt after enabling InstallAPI for iOS.
https://bugs.webkit.org/show_bug.cgi?id=191043
rdar://problem/32728423

Configurations/WebKit.xcconfig: Skip NSURLDownloadSPI.h here too.

2:49 PM Changeset in webkit [237603] by mitz@apple.com

7 copies
1 add in releases/Apple/watchOS 5.1

Added a tag for watchOS 5.1.

2:49 PM Changeset in webkit [237602] by mitz@apple.com

8 copies
1 add in releases/Apple/iOS 12.1

Added a tag for iOS 12.1.

2:49 PM Changeset in webkit [237601] by mitz@apple.com

9 copies
1 add in releases/Apple/Safari 12.0.1

Added a tag for Safari 12.0.1.

1:41 PM Changeset in webkit [237600] by ap@apple.com

8 edits
1 add in trunk/Source

Enable InstallAPI for iOS unconditionally
https://bugs.webkit.org/show_bug.cgi?id=191043
rdar://problem/32728423

Reviewed by Dan Bernstein.

Source/WebKit:

Configurations/Base.xcconfig: Enabled it.

Source/WebKitLegacy:

WebKitLegacy.xcodeproj/project.pbxproj: Added NSURLDownloadSPI.h.

Source/WebKitLegacy/mac:

Configurations/WebKitLegacy.xcconfig: Enabled it. Added NSURLDownloadSPI.h as an

excluded header - WebKitLegacy doesn't export NSURLDownload, so the definition
shouldn't be processed by InstallAPI.

MigrateHeaders.make: Removed an obsolete workaround.
Misc/NSURLDownloadSPI.h: Added.
Misc/WebDownload.h: Use NSURLDownloadSPI.h instead of defining SPI inline.

1:23 PM Changeset in webkit [237599] by Devin Rousso

3 edits in trunk/Source/WebInspectorUI

Web Inspector: make the layers sidebar in the Elements tab always visible
https://bugs.webkit.org/show_bug.cgi?id=190158

Reviewed by Brian Burg.

UserInterface/Views/ElementsTabContentView.js:

(WI.ElementsTabContentView):

UserInterface/Views/SearchTabContentView.js:

(WI.SearchTabContentView):

12:58 PM Changeset in webkit [237598] by ajuma@chromium.org

3 edits
2 adds in trunk

Calling window.open("", "_self") allows working around restrictions on window.close()
https://bugs.webkit.org/show_bug.cgi?id=191073

Reviewed by Chris Dumez.

Source/WebCore:

Do not treat a re-used frame in DOMWindow::createWindow as having been opened by DOM.

Test: fast/dom/Window/window-open-self-disallow-close.html

page/DOMWindow.cpp:

(WebCore::DOMWindow::createWindow):

LayoutTests:

fast/dom/Window/window-open-self-disallow-close-expected.txt: Added.
fast/dom/Window/window-open-self-disallow-close.html: Added.

12:07 PM Changeset in webkit [237597] by aestes@apple.com

24 edits
4 adds in trunk

[Payment Request] Implement PaymentResponse.retry()
https://bugs.webkit.org/show_bug.cgi?id=190985

Source/WebCore:

Reviewed by Daniel Bates.

Implemented the retry() method on PaymentResponse as specified in the Payment Request API
W3C Editor's Draft of 24 October 2018.

See https://w3c.github.io/payment-request/#retry-method for details.

Tests: http/tests/paymentrequest/payment-response-rejects-if-not-active.https.html

http/tests/paymentrequest/payment-response-retry-method.https.html

Modules/applepay/PaymentCoordinator.h:

(WebCore::PaymentCoordinator::client): Added. Returns m_client.

Modules/applepay/PaymentCoordinatorClient.h:

(WebCore::PaymentCoordinatorClient::isMockPaymentCoordinator const): Added. Used to downcast
a PaymentCoordinatorClient to a MockPaymentCoordinator.

Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::ApplePayPaymentHandler::computeTotalAndLineItems const): Made const.
(WebCore::ApplePayPaymentHandler::computeErrors const): Broke this function into
computeAddressErrors, computePayerErrors, and computePaymentMethodErrors, then modified this
function to call those functions. Exceptions thrown by computePaymentMethodErrors are ignored.
(WebCore::ApplePayPaymentHandler::computeAddressErrors const): Added.
(WebCore::ApplePayPaymentHandler::computePayerErrors const): Added.
(WebCore::ApplePayPaymentHandler::computePaymentMethodErrors const): Added.
(WebCore::ApplePayPaymentHandler::complete): Added ASSERTs to verify whether result is a
final result.
(WebCore::ApplePayPaymentHandler::retry): Computed PaymentErrors from PaymentValidationErrors,
ensured the PaymentAuthorizationResult was non-final by adding an unknown error if necessary,
and called PaymentCoordinator::completePaymentSession.

Modules/applepay/paymentrequest/ApplePayPaymentHandler.h:
Modules/paymentrequest/PaymentHandler.h:
Modules/paymentrequest/PaymentRequest.cpp:

(WebCore::PaymentRequest::show): Changed to call settleShowPromise.
(WebCore::PaymentRequest::abortWithException): Changed to abort PaymentResponse's retry
promise, if present, instead of PaymentResponse's show promise.
(WebCore::PaymentRequest::settleShowPromise): Added. Settles m_showPromise then sets it to
std::nullopt.
(WebCore::PaymentRequest::closeActivePaymentHandler): Added. Hides the active payment
handler then sets it to std::nullopt.
(WebCore::PaymentRequest::stop): Stopped calling abortWithException, since that function
might settle PaymentResponse's retry promise. PaymentResponse is now an ActiveDOMObject and
will settle its own promise in its implementation of stop.
(WebCore::PaymentRequest::abort): Changed to throw an InvalidStateError if there is a
pending retry promise and to call abortWithException instead of stop.
(WebCore::PaymentRequest::completeMerchantValidation): Changed to call abortWithException
instead of stop.
(WebCore::PaymentRequest::settleDetailsPromise): Ditto.
(WebCore::PaymentRequest::accept): Updated the existing PaymentResponse, if present, rather
than creating a new one. Settled the existing PaymentResponse's retry promise, if present,
rather than the show promise.
(WebCore::PaymentRequest::complete): Changed to throw an AbortError if there is no longer an
active payment handler.
(WebCore::PaymentRequest::retry): Changed to throw an AbortError if there is no longer an
active payment handler, and to call PaymentHandler::retry if there is.
(WebCore::PaymentRequest::cancel): Changed to call abortWithException instead of stop.

Modules/paymentrequest/PaymentRequest.h:
Modules/paymentrequest/PaymentRequest.idl:
Modules/paymentrequest/PaymentResponse.cpp:

(WebCore::PaymentResponse::PaymentResponse):
(WebCore::PaymentResponse::finishConstruction): Pending activities create strong references
to |this|, so they cannot be created in constructors without relaxing adoption requirements.
Added this function so that the pending activity can be created after the PaymentResponse is
created and adopted.
(WebCore::PaymentResponse::~PaymentResponse):
(WebCore::PaymentResponse::complete): Updated to throw an AbortError or InvalidStateError
when necessary.
(WebCore::PaymentResponse::retry): Implemented. Throws an AbortError or InvalidStateError
when necessary, otherwise calls PaymentRequest::retry and stores the retry promise in
m_retryPromise.
(WebCore::PaymentResponse::abortWithException): Added. Rejects the retry promise with
|exception|, clears the pending activity, and sets m_state to Completed.
(WebCore::PaymentResponse::settleRetryPromise): Added. Settles the retry promise and sets it
to std::nullopt.
(WebCore::PaymentResponse::canSuspendForDocumentSuspension const): Added. Returns true if
there is no pending activity.
(WebCore::PaymentResponse::stop): Added. Rejects the retry promise with AbortError, clears
the pending activity, and sets m_state to Stopped.

Modules/paymentrequest/PaymentResponse.h: Changed create to call finishConstruction and

made PaymentResponse an ActiveDOMObject instead of a ContextDestructionObserver.

testing/Internals.cpp:

(WebCore::Internals::Internals): Changed to only create a MockPaymentCoordinator for main frames.
(WebCore::Internals::mockPaymentCoordinator): Changed to get the MockPaymentCoordinator by
downcasting the page's payment coordinator client.

testing/Internals.h:
testing/Internals.idl:
testing/MockPaymentCoordinator.cpp:

(WebCore::MockPaymentCoordinator::completePaymentSession): Changed to only increment
hideCount for final results.

testing/MockPaymentCoordinator.h:

(isType): Added so that PaymentCoordinatorClients can be downcasted to MockPaymentCoordinators.

LayoutTests:

Reviewed by Daniel Bates

http/tests/paymentrequest/payment-address-attributes-and-toJSON-method.https.html:
http/tests/paymentrequest/payment-response-complete-method.https.html:
http/tests/paymentrequest/payment-response-methodName-attribute.https.html:
http/tests/paymentrequest/payment-response-payerEmail-attribute.https.html:
http/tests/paymentrequest/payment-response-payerName-attribute.https.html:
http/tests/paymentrequest/payment-response-payerPhone-attribute.https.html:
http/tests/paymentrequest/payment-response-rejects-if-not-active.https-expected.txt: Added.
http/tests/paymentrequest/payment-response-rejects-if-not-active.https.html: Copied from

imported/w3c/web-platform-tests/payment-request/payment-response/rejects_if_not_active-manual.https.html
and automated using internals.mockPaymentCoordinator.

http/tests/paymentrequest/payment-response-retry-method.https-expected.txt: Added.
http/tests/paymentrequest/payment-response-retry-method.https.html: Copied from

imported/w3c/web-platform-tests/payment-request/payment-response/retry-method-manual.https.html
and automated using internals.mockPaymentCoordinator.

http/tests/paymentrequest/resources/helpers.js:

(setUpAndSmokeTest):

11:33 AM Changeset in webkit [237596] by Alan Bujtas

2 edits in trunk/Source/WebCore

[iOS] Use the mainframe view size to compute window.outerWidth/height.
https://bugs.webkit.org/show_bug.cgi?id=191070
<rdar://problem/42368377>

Reviewed by Tim Horton.

Use a more reasonable value for window.outerWidth and height.
(WKWebView's frame rect -> drawing area sizing -> WebPage's view size -> FrameView size)

page/DOMWindow.cpp:

(WebCore::DOMWindow::outerHeight const):
(WebCore::DOMWindow::outerWidth const):

11:32 AM Changeset in webkit [237595] by Ross Kirsling

3 edits in trunk/Source/JavaScriptCore

useProbeOSRExit causes failures for Win64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=190656

Reviewed by Keith Miller.

assembler/ProbeContext.cpp:

(JSC::Probe::executeProbe):
If lowWatermark is expected to equal lowWatermarkFromVisitingDirtyPages *regardless* of the input param,
then let's just call lowWatermarkFromVisitingDirtyPages instead.

dfg/DFGOSRExit.cpp:

(JSC::DFG::OSRExit::executeOSRExit):
The result of VariableEventStream::reconstruct appears to be inappropriate for direct use as a stack pointer offset;
mimic the non-probe case and use requiredRegisterCountForExit from DFGCommonData instead.
(Also, stop redundantly setting the stack pointer twice in a row.)

11:12 AM Changeset in webkit [237594] by aestes@apple.com

8 edits in trunk

[Apple Pay] PaymentRequest.canMakePayment() should resolve to true whenever Apple Pay is available
https://bugs.webkit.org/show_bug.cgi?id=191039

Reviewed by Megan Gardner.

Source/WebCore:

During a recent Web Payments WG F2F, we decided that canMakePayment() should return true
whenever the user agent supports one or more of the specified payment methods, even if those
payment methods do not have active instruments.

Change WebKit's implementation of canMakePayment() for Apple Pay to resolve with the value
of ApplePaySession.canMakePayments() rather than ApplePaySession.canMakePaymentsWithActiveCard().

Added a test case to http/tests/paymentrequest/payment-request-canmakepayment-method.https.html.

Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::ApplePayPaymentHandler::canMakePayment):
(WebCore::shouldDiscloseApplePayCapability): Deleted.

testing/MockPaymentCoordinator.cpp:

(WebCore::MockPaymentCoordinator::canMakePayments):
(WebCore::MockPaymentCoordinator::canMakePaymentsWithActiveCard):

testing/MockPaymentCoordinator.h:
testing/MockPaymentCoordinator.idl:

LayoutTests:

http/tests/paymentrequest/payment-request-canmakepayment-method.https-expected.txt:
http/tests/paymentrequest/payment-request-canmakepayment-method.https.html:

10:48 AM Changeset in webkit [237593] by Devin Rousso

9 edits in trunk/Source/WebInspectorUI

Web Inspector: refactor WI.ScopeBarItem for better extensibility
https://bugs.webkit.org/show_bug.cgi?id=190986

Reviewed by Brian Burg.

Renames withModifier to extendSelection for clarity of usage, and to allow the changes
in <https://webkit.org/b/190754> (adding an option to allow WI.ScopeBarItems to be
selected without deselcting any other WI.ScopeBarItems) to use the same variable.

UserInterface/Views/ScopeBarItem.js:

(WI.ScopeBarItem):
(WI.ScopeBarItem.prototype.set selected):
(WI.ScopeBarItem.prototype._handleMouseDown):
(WI.ScopeBarItem.prototype.setSelected): Deleted.

UserInterface/Views/ScopeBar.js:

(WI.ScopeBar):
(WI.ScopeBar.prototype._populate):
(WI.ScopeBar.prototype._itemSelectionDidChange):

UserInterface/Views/MultipleScopeBarItem.js:

(WI.MultipleScopeBarItem.prototype.set selectedScopeBarItem):

UserInterface/Views/CanvasSidebarPanel.js:

(WI.CanvasSidebarPanel.prototype._updateRecordingScopeBar):

UserInterface/Views/LogContentView.js:

(WI.LogContentView):

UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView):

UserInterface/Views/ResourceSidebarPanel.js:

(WI.ResourceSidebarPanel):

UserInterface/Views/StorageSidebarPanel.js:

(WI.StorageSidebarPanel):

10:45 AM Changeset in webkit [237592] by realdawei@apple.com

2 edits in trunk/LayoutTests

[ Mojave Debug ] Layout Test http/tests/workers/service/self_registration.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=190828

Unreviewed.

Patch by Dawei Fenton <realdawei@apple.com> on 2018-10-30

platform/mac-wk2/TestExpectations: Mark test as flay.

10:32 AM Changeset in webkit [237591] by sihui_liu@apple.com

54 edits in trunk

Add a deprecation warning to console for Web SQL
https://bugs.webkit.org/show_bug.cgi?id=190936

Reviewed by Ryosuke Niwa.

Source/WebCore:

No new tests. Just adding a console message.

Modules/webdatabase/DOMWindowWebDatabase.cpp:

(WebCore::DOMWindowWebDatabase::openDatabase):

LayoutTests:

Rebaseline the tests that are affected by the added console message.

fast/dom/MutationObserver/database-callback-delivery-expected.txt:
fast/frames/sandboxed-iframe-storage-expected.txt:
fast/history/page-cache-webdatabase-no-transaction-db-expected.txt:
http/tests/security/cross-origin-websql-allowed-expected.txt:
http/tests/security/cross-origin-websql-expected.txt:
http/tests/security/same-origin-websql-blocked-expected.txt:
http/tests/security/storage-blocking-loosened-websql-expected.txt:
http/tests/security/storage-blocking-strengthened-websql-expected.txt:
http/tests/storage/callbacks-are-called-in-correct-context-expected.txt:
inspector/runtime/CommandLineAPI-inspect-expected.txt:
js/dom/callback-function-with-handle-event-expected.txt:
js/dom/exceptions-thrown-in-callbacks-expected.txt:
storage/websql/alter-to-info-table-expected.txt:
storage/websql/change-version-expected.txt:
storage/websql/change-version-handle-reuse-expected.txt:
storage/websql/change-version-no-crash-on-preflight-failure-expected.txt:
storage/websql/close-during-stress-test-expected.txt:
storage/websql/database-lock-after-reload-expected.txt:
storage/websql/empty-statement-expected.txt:
storage/websql/execute-sql-args-expected.txt:
storage/websql/execute-sql-rowsAffected-expected.txt:
storage/websql/executesql-accepts-only-one-statement-expected.txt:
storage/websql/hash-change-with-xhr-expected.txt:
storage/websql/multiple-databases-garbage-collection-expected.txt:
storage/websql/multiple-transactions-expected.txt:
storage/websql/multiple-transactions-on-different-handles-expected.txt:
storage/websql/null-callbacks-expected.txt:
storage/websql/open-database-creation-callback-expected.txt:
storage/websql/open-database-creation-callback-isolated-world-expected.txt:
storage/websql/open-database-empty-version-expected.txt:
storage/websql/open-database-expand-quota-expected.txt:
storage/websql/open-database-over-quota-expected.txt:
storage/websql/open-database-set-empty-version-expected.txt:
storage/websql/open-database-while-transaction-in-progress-expected.txt:
storage/websql/private-browsing-noread-nowrite-expected.txt:
storage/websql/read-and-write-transactions-dont-run-together-expected.txt:
storage/websql/read-transactions-running-concurrently-expected.txt:
storage/websql/sql-data-types-expected.txt:
storage/websql/statement-error-callback-expected.txt:
storage/websql/statement-error-callback-isolated-world-expected.txt:
storage/websql/statement-success-callback-isolated-world-expected.txt:
storage/websql/success-callback-expected.txt:
storage/websql/success-callback-when-page-defers-loading-expected.txt:
storage/websql/test-authorizer-expected.txt:
storage/websql/transaction-callback-exception-crash-expected.txt:
storage/websql/transaction-callback-isolated-world-expected.txt:
storage/websql/transaction-database-expand-quota-expected.txt:
storage/websql/transaction-error-callback-expected.txt:
storage/websql/transaction-error-callback-isolated-world-expected.txt:
storage/websql/transaction-prototype-expected.txt:
storage/websql/transaction-success-callback-isolated-world-expected.txt:

10:11 AM Changeset in webkit [237590] by sihui_liu@apple.com

6 edits
3 adds in trunk

IndexedDB: iteration of cursors skip records if updated or deleted
https://bugs.webkit.org/show_bug.cgi?id=190917
<rdar://problem/35250410>

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

Rebaseline the expectation for test that passes.

web-platform-tests/IndexedDB/idbcursor-iterating-update-expected.txt:

Source/WebCore:

When object store has changes, we cleared cached records and reset the SQLite statement,
updating the boundary to the next key in cursor's direction. Therefore, the cursor could
jump to the next key after update or deletion.
We should cache those records before changing the statement.

Test: storage/indexeddb/cursor-update-while-iterating.html

Modules/indexeddb/server/SQLiteIDBCursor.cpp:

(WebCore::IDBServer::SQLiteIDBCursor::objectStoreRecordsChanged):
(WebCore::IDBServer::SQLiteIDBCursor::fetch):

Modules/indexeddb/server/SQLiteIDBCursor.h:

LayoutTests:

storage/indexeddb/cursor-update-while-iterating-expected.txt: Added.
storage/indexeddb/cursor-update-while-iterating.html: Added.
storage/indexeddb/resources/cursor-update-while-iterating.js: Added.

(prepareDatabase):
(onOpenSuccess.request.onsuccess):
(onOpenSuccess):

7:54 AM Changeset in webkit [237589] by zandobersek@gmail.com

2 edits in trunk/Source/WebKit

[CoordGraphics] CoordinatedLayerTreeHost::flushLayersAndForceRepaint() should schedule the flush
https://bugs.webkit.org/show_bug.cgi?id=191066

Reviewed by Michael Catanzaro.

WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:

(WebKit::CoordinatedLayerTreeHost::flushLayersAndForceRepaint):
Only schedule the layer flush in this call, don't perform it on the
spot. This avoids re-entry of the layer flushing process in cases when
the associated display refresh monitor is requested a callback during
the layout phase that's executed under the initial layer flush.

7:29 AM Changeset in webkit [237588] by Alan Bujtas

5 edits
1 add in trunk/Source/WebCore

[LFC][IFC] Introduce InlineFormattingContextGeometry class
https://bugs.webkit.org/show_bug.cgi?id=191054

Reviewed by Antti Koivisto.

This is in preparation for inline-block support.

Move float and inline-block elements layout to layoutFormattingContextRoot().
computeWidthAndHeightForInlineBox takes care of replaced elements.

Sources.txt:
WebCore.xcodeproj/project.pbxproj:
layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::layout const):
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForInlineBox const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeight const): Deleted.

layout/inlineformatting/InlineFormattingContext.h:
layout/inlineformatting/InlineFormattingContextGeometry.cpp: Added.

(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockWidthAndMargin):
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockHeightAndMargin):

3:23 AM WebKitGTK edited by Adrian Perez de Castro

Update link to WebKitGTK/StableRelease (diff)

2:30 AM Changeset in webkit [237587] by graouts@webkit.org

23 edits in trunk

[Web Animations] Implement the update animations and send events procedure
https://bugs.webkit.org/show_bug.cgi?id=191013
<rdar://problem/45620495>

Reviewed by Dean Jackson.

LayoutTests/imported/mozilla:

Progression in a couple of getAnimations() tests for CSS Animations.

css-animations/test_document-get-animations-expected.txt:

LayoutTests/imported/w3c:

Progressions in a couple of Web Animations Web Platform Tests.

web-platform-tests/web-animations/timing-model/animations/current-time-expected.txt:
web-platform-tests/web-animations/timing-model/animations/updating-the-finished-state-expected.txt:

Source/WebCore:

While we implemented the various parts of what the Web Animations specification refers to as the "update animations and send events"
procedure, we did not implement it as one function and in the correct order, specifically updating animations and sending events in
two separate tasks. We now have a single method on DocumentTimeline which runs as the DisplayRefreshMonitor fires to update each
"relevant" animation with the current time, perform a microtask checkpoint and dispatch events.

Implementing this procedure allowed us to make several enhancements:

We introduce the concept of a "relevant" animation, which is essentially an animation that is either pending or playing. All animations

in a different state are no longer owned by the DocumentTimeline and can thus be destroyed if the developer doesn't hold references in JS.
Maintaining such a list guarantees that we're only updating animations that would have changed state since the last time the "update animations
and send events" procedure was run. Note that DeclarativeAnimation instances are also considered to be relevant if they have queued DOM events
to dispatch as they could otherwise be destroyed before they can fully dispatch them.

We no longer conflate the timing model and effects. Until now the way we would update animations was to go through all elements for which

we had a registered animation, invalidate their style and finally forcing a style update on the document. We had a separate data structure where
we help animations without targets so we update these as well in a separate pass, in order to make sure that promises and events would fire for
them as expected. We now let the "update animations and send events" procedure update the timing of all relevant animations and let individual
animation effects invalidate their style as needed, the document style invalidation happening naturally without DocumentTimeline forcing it.

We use a single step to schedule the update of animations, which is to register for a display refresh monitor update provided a "relevant"

animation is known since the previous update. Until now we first had an "timing model invalidation" task scheduled upon any change of an animation's
timing model, which would then create a timer to the earliest moment any listed animation would require an update, finally registering a display
refresh monitor update, which used at least GenericTaskQueue<Timer> and potentially two, whereas we use none right now.

We allow for a display refresh monitor update to be canceled should the number of "relevant" animations since the last update goes back to 0.

To facilitate all of this, we have changed the m_animations ListHashSet to contain only the "relevant" animations, and no longer every animation created
that has this DocumentTimeline set as their "timeline" property. To keep this list current, every single change that changes a given animation's timing
ends up calling AnimationTimeline::animationTimingDidChange() passing the animation as the sole parameter and adding this animation to m_animations. We
immediately schedule a display refresh monitor update if one wasn't already scheduled. Then, when running the "update animations and send events"
procedure, we call a new WebAnimation::tick() method on each of those animations, which updates this animation's effect and relevance, using the newly
computed relevance to identify whether this animation should be kept in the m_animations ListHashSet.

This is only the first step towards a more efficient update and ownership model of animations by the document timeline since animations created as CSS
Animations and CSS Transitions are committed through CSS have dedicated data structures that are not updated in this particular patch, but this will be
addressed in a followup to keep this already significant patch smaller. Another issue that will be addressed later is the ability to not schedule display
refresh monitor udpates when only accelerated animations are running.

animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::animationTimingDidChange): Called by animations when any aspect of their timing model changes. The provided animation is then
added to the m_animations list unless its timeline is no longer this timeline.
(WebCore::AnimationTimeline::removeAnimation): Remove the provided animation from m_animations and remove any animation registered on the element-specific
animation lists if this animation has an effect with a target.
(WebCore::AnimationTimeline::animationWasAddedToElement): We no longer need to worry about the m_animationsWithoutTarget data structure since we removed it.
(WebCore::removeCSSTransitionFromMap): Fix a bug where we would remove any CSSTransition in the provided map that had a matching transition-property instead
of checking the CSSTransition registered for this transition-property was indeed the provided CSSTransition. The other code changes in this patch made this
code now cause regressions in the Web Platform Tests.
(WebCore::AnimationTimeline::animationWasRemovedFromElement): Stop updating m_animationsWithoutTarget since it no longer exists.
(WebCore::AnimationTimeline::elementWasRemoved):
(WebCore::AnimationTimeline::updateCSSAnimationsForElement): Fix a small error that caused a regression in the Web Platform Tests where we could attempt to
call setBackingAnimation() on a nullptr instead of a valid CSSAnimation.
(WebCore::AnimationTimeline::cancelOrRemoveDeclarativeAnimation):
(WebCore::AnimationTimeline::addAnimation): Deleted.

animation/AnimationTimeline.h:

(WebCore::AnimationTimeline::hasElementAnimations const): Deleted.
(WebCore::AnimationTimeline:: const): Deleted.
(WebCore::AnimationTimeline::elementToAnimationsMap): Deleted.
(WebCore::AnimationTimeline::elementToCSSAnimationsMap): Deleted.
(WebCore::AnimationTimeline::elementToCSSTransitionsMap): Deleted.

animation/CSSTransition.cpp:

(WebCore::CSSTransition::canBeListed const): Deleted.

animation/CSSTransition.h:
animation/DeclarativeAnimation.cpp:

(WebCore::DeclarativeAnimation::tick): Call the superclass's method and queue any necessary DOM events reflecting the timing model changes.
(WebCore::DeclarativeAnimation::needsTick const): Call the superclass's method and return true also if we have pending events since otherwise this animation
could be removed from m_animations on its AnimationTimeline and potentially destroyed before the GenericEventQueue had a chance to dispatch all events.
(WebCore::DeclarativeAnimation::startTime const): We removed the custom binding for this IDL property and renamed the method from bindingsStartTime to startTime.
(WebCore::DeclarativeAnimation::setStartTime): We removed the custom binding for this IDL property and renamed the method from setBindingsStartTime to setStartTime.
(WebCore::DeclarativeAnimation::bindingsStartTime const): Deleted.
(WebCore::DeclarativeAnimation::setBindingsStartTime): Deleted.

animation/DeclarativeAnimation.h:
animation/DocumentAnimationScheduler.cpp:

(WebCore::DocumentAnimationScheduler::unscheduleWebAnimationsResolution): Add a method to mark that we no longer need a display refresh monitor update for this
document's animation timeline. This is called when m_animations becomes empty.

animation/DocumentAnimationScheduler.h:
animation/DocumentTimeline.cpp:

(WebCore::DocumentTimeline::DocumentTimeline):
(WebCore::DocumentTimeline::detachFromDocument): Stop clearing two task queues and a timer that no longer exist and instead only clear the task queue to clear
the cached current time, which we queue any time we generate a new one (see DocumentTimeline::currentTime).
(WebCore::DocumentTimeline::getAnimations const): Use isRelevant() instead of canBeListed().
(WebCore::DocumentTimeline::updateThrottlingState):
(WebCore::DocumentTimeline::suspendAnimations):
(WebCore::DocumentTimeline::resumeAnimations):
(WebCore::DocumentTimeline::numberOfActiveAnimationsForTesting const):
(WebCore::DocumentTimeline::currentTime): Queue a task in the new m_currentTimeClearingTaskQueue task queue to clear the current time that we've generated and cached
in the next run loop (provided all pending JS execution has also completed).
(WebCore::DocumentTimeline::maybeClearCachedCurrentTime):
(WebCore::DocumentTimeline::scheduleAnimationResolutionIfNeeded): Schedule a display refresh monitor update if we are not suspended and have "relevant" animations.
(WebCore::DocumentTimeline::animationTimingDidChange): Call scheduleAnimationResolutionIfNeeded() after calling the superclass's implementation.
(WebCore::DocumentTimeline::removeAnimation): Call unscheduleAnimationResolution() if the list of "relevant" animations is now empty.
(WebCore::DocumentTimeline::unscheduleAnimationResolution): Unschedule a pending display refresh monitor update.
(WebCore::DocumentTimeline::animationResolutionTimerFired):
(WebCore::DocumentTimeline::updateAnimationsAndSendEvents): Implement the "update animations and send events" procedure as specified by the Web Animations spec.
During this procedure, we call tick() on all animations listed in m_animations and create a list of animations to remove from that list if this animation is no
longer relevant following the call to tick().
(WebCore::DocumentTimeline::enqueueAnimationPlaybackEvent):
(WebCore::DocumentTimeline::timingModelDidChange): Deleted.
(WebCore::DocumentTimeline::scheduleInvalidationTaskIfNeeded): Deleted.
(WebCore::DocumentTimeline::performInvalidationTask): Deleted.
(WebCore::DocumentTimeline::updateAnimationSchedule): Deleted.
(WebCore::DocumentTimeline::animationScheduleTimerFired): Deleted.
(WebCore::DocumentTimeline::updateAnimations): Deleted.
(WebCore::compareAnimationPlaybackEvents): Deleted.
(WebCore::DocumentTimeline::performEventDispatchTask): Deleted.

animation/DocumentTimeline.h:
animation/WebAnimation.cpp: The majority of the changes to this class is that we call the new timingDidChange() method when any code that modifies the timing model

is run. We also remove methods to set the pending play and pause tasks as well as the animation's start time and hold time since any time we're changing these instance
variables, we later already have a call to update the timing model and we were doing more work than needed. As a result we no longer need an internal method to set the
start time and can stop requiring a custom IDL binding for the "startTime" property.
(WebCore::WebAnimation::effectTimingPropertiesDidChange):
(WebCore::WebAnimation::setEffect):
(WebCore::WebAnimation::setEffectInternal):
(WebCore::WebAnimation::setTimeline):
(WebCore::WebAnimation::setTimelineInternal):
(WebCore::WebAnimation::startTime const):
(WebCore::WebAnimation::setStartTime):
(WebCore::WebAnimation::silentlySetCurrentTime):
(WebCore::WebAnimation::setCurrentTime):
(WebCore::WebAnimation::setPlaybackRate):
(WebCore::WebAnimation::cancel):
(WebCore::WebAnimation::resetPendingTasks):
(WebCore::WebAnimation::finish):
(WebCore::WebAnimation::timingDidChange): New method called any time a timing property changed where we run the "update the finished state" procedure and notify the
animation's timeline that its timing changed so that it can be considered the next time the "update animations and send events" procedure runs.
(WebCore::WebAnimation::invalidateEffect):
(WebCore::WebAnimation::updateFinishedState): Update the animation's relevance after running the procedure as specified.
(WebCore::WebAnimation::play):
(WebCore::WebAnimation::runPendingPlayTask):
(WebCore::WebAnimation::pause):
(WebCore::WebAnimation::runPendingPauseTask):
(WebCore::WebAnimation::needsTick const):
(WebCore::WebAnimation::tick): New method called during the "update animations and send events" procedure where we run the "update the finished state" procedure and run
the pending play and pause tasks.
(WebCore::WebAnimation::resolve):
(WebCore::WebAnimation::updateRelevance):
(WebCore::WebAnimation::computeRelevance):
(WebCore::WebAnimation::timingModelDidChange): Deleted.
(WebCore::WebAnimation::setHoldTime): Deleted.
(WebCore::WebAnimation::bindingsStartTime const): Deleted.
(WebCore::WebAnimation::setBindingsStartTime): Deleted.
(WebCore::WebAnimation::setTimeToRunPendingPlayTask): Deleted.
(WebCore::WebAnimation::setTimeToRunPendingPauseTask): Deleted.
(WebCore::WebAnimation::updatePendingTasks): Deleted.
(WebCore::WebAnimation::timeToNextRequiredTick const): Deleted.
(WebCore::WebAnimation::runPendingTasks): Deleted.
(WebCore::WebAnimation::canBeListed const): Deleted.

animation/WebAnimation.h:

(WebCore::WebAnimation::isRelevant const):
(WebCore::WebAnimation::hasPendingPlayTask const):
(WebCore::WebAnimation::isEffectInvalidationSuspended):

animation/WebAnimation.idl:
dom/Element.cpp:

(WebCore::Element::getAnimations): Use isRelevant() instead of canBeListed().

LayoutTests:

Several tests that broke when turning Web Animations CSS Integration on by default are now passing. In the case of one test, we had to ensure
that the final animation frame had been committed before terminating the test or there would be a tiny image reference issue.

TestExpectations:
fast/layers/no-clipping-overflow-hidden-added-after-transform.html:

2:00 AM Changeset in webkit [237586] by yusukesuzuki@slowstart.org

3 edits in trunk/Source/JavaScriptCore

"Unreviewed, partial rolling in r237254"
https://bugs.webkit.org/show_bug.cgi?id=190340

This only adds Parser.{cpp,h}. And it is not used in this patch.
It examines that the regression is related to exact Parser changes.

parser/Parser.cpp:

(JSC::Parser<LexerType>::parseInner):
(JSC::Parser<LexerType>::parseSingleFunction):
(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseAsyncFunctionDeclaration):

parser/Parser.h:

(JSC::Parser<LexerType>::parse):
(JSC::parse):
(JSC::parseFunctionForFunctionConstructor):

1:59 AM Changeset in webkit [237585] by youenn@apple.com

5 edits in trunk

LibWebRTCRtpReceiverBackend::getSynchronizationSources should use Vector::append
https://bugs.webkit.org/show_bug.cgi?id=191026

Reviewed by Eric Carlson.

Source/WebCore:

Covered by updated test.

Modules/mediastream/libwebrtc/LibWebRTCRtpReceiverBackend.cpp:

(WebCore::LibWebRTCRtpReceiverBackend::getSynchronizationSources const):

LayoutTests:

webrtc/video-addTransceiver-expected.txt:
webrtc/video-addTransceiver.html:

1:26 AM Changeset in webkit [237584] by Claudio Saavedra

4 edits in trunk

[GTK][WPE] Fixes to the PublicSuffix implementation
https://bugs.webkit.org/show_bug.cgi?id=191031

Reviewed by Michael Catanzaro.

Source/WebCore:

Covered by existing tests.

Downcase hostnames before passing it on to the underlying
libsoup API. Special case localhost and fix a mixed-up
libsoup GError checks. This fixes most of the failures.

platform/soup/PublicSuffixSoup.cpp:

(WebCore::isPublicSuffix):
(WebCore::topPrivatelyControlledDomain):

Tools:

TestWebKitAPI/Tests/WebCore/PublicSuffix.cpp:

(TestWebKitAPI::TEST_F): Remove a test for a domain
that is not registrable and shouldn't be tested there.

Note: See TracTimeline for information about the timeline view.

Download in other formats:

RSS Feed