Timeline



Dec 23, 2018:

9:07 PM Changeset in webkit [239547] by wenson_hsieh@apple.com
  • 5 edits in trunk/Source/WebKit

[iOS] Remove some unnecessary editing SPI after <rdar://problem/46047546>
https://bugs.webkit.org/show_bug.cgi?id=193019

Reviewed by Dan Bernstein.

Remove these SPI method declarations, as well as method forwarding in WKContentView. Mail was the only adoptee
of these methods; after <rdar://problem/46047546>, they have moved to the underscore-prefixed versions, so we
we have no need for these erroneously-named SPI methods anymore. There is no change in behavior; verified this
through existing API tests (WKWebViewEditActions), as well as building iOS Mail against WebKit with these
changes to WKWebViewPrivate.h.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView canPerformAction:withSender:]):
(-[WKWebView targetForAction:withSender:]):
(-[WKWebView _setFont:sender:]):
(-[WKWebView _setFontSize:sender:]):
(-[WKWebView _setTextColor:sender:]):
(-[WKWebView setFont:sender:]): Deleted.
(-[WKWebView setTextColor:sender:]): Deleted.
(-[WKWebView setFontSize:sender:]): Deleted.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView setFontForWebView:sender:]): Deleted.
(-[WKContentView setFontSizeForWebView:sender:]): Deleted.
(-[WKContentView setTextColorForWebView:sender:]): Deleted.

3:51 PM Changeset in webkit [239546] by wenson_hsieh@apple.com
  • 2 edits in trunk/Source/WebKit

Fix fast/ruby/ruby-base-merge-block-children-crash-2.html after r239543
https://bugs.webkit.org/show_bug.cgi?id=193015
<rdar://problem/46583527>

Reviewed by Tim Horton.

Fix the crash by gracefully handling integer overflow when computing the area of a very large editable element.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
(-[WKContentView _updateChangedSelection:]):

2:46 AM Changeset in webkit [239545] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline fast/text/zero-font-size.html after r239539.

  • platform/gtk/fast/text/zero-font-size-expected.txt:
2:09 AM Changeset in webkit [239544] by yusukesuzuki@slowstart.org
  • 6 edits
    2 adds in trunk

[BigInt] Support BigInt in JSON.stringify
https://bugs.webkit.org/show_bug.cgi?id=192624

Reviewed by Saam Barati.

JSTests:

  • stress/big-int-json-stringify-to-json.js: Added.

(shouldBe):
(shouldThrow):
(BigInt.prototype.toJSON):
(shouldBe.JSON.stringify):

  • stress/big-int-json-stringify.js: Added.

(shouldBe):
(shouldThrow):

Source/JavaScriptCore:

This patch adds BigInt support to JSON.stringify, specified in [1].

[1]: https://tc39.github.io/proposal-bigint/#sec-serializejsonproperty

  • runtime/JSONObject.cpp:

(JSC::unwrapBoxedPrimitive):
(JSC::Stringifier::toJSON):
(JSC::Stringifier::toJSONImpl):
(JSC::Stringifier::appendStringifiedValue):

LayoutTests:

The test is wrong according to the spec[1]. valueOf of Boolean object won't be called.

[1]: https://tc39.github.io/ecma262/#sec-serializejsonproperty

  • js/resources/JSON-stringify.js:
  • js/resources/json2-es5-compat.js:

(str):

Dec 22, 2018:

10:38 PM Changeset in webkit [239543] by wenson_hsieh@apple.com
  • 11 edits
    2 adds in trunk

[iOS] Suppress native selection behaviors when focusing a very small editable element
https://bugs.webkit.org/show_bug.cgi?id=193005
<rdar://problem/46583527>

Reviewed by Tim Horton.

Source/WebKit:

In r238146, I added a mechanism to detect when the selection is hidden within transparent editable elements, and
used this to suppress native selection on iOS (such as selection handles, highlight, callout bar, etc.) to avoid
conflicts between the page's editing UI and the platform.

However, one additional technique observed on some websites involves hiding the selection by moving it into a
tiny (1x1) editable element. Here, we currently still present a callout bar with editing actions, as well as
show a selection caret or handles on iOS. To fix this, we extend the mechanism added in r238146 by also
suppressing the selection assistant in the case where the editable element's area is beneath a tiny minimum
threshold.

Test: editing/selection/ios/hide-selection-in-tiny-contenteditable.html

  • Shared/EditorState.cpp:

(WebKit::EditorState::PostLayoutData::encode const):
(WebKit::EditorState::PostLayoutData::decode):
(WebKit::operator<<):

  • Shared/EditorState.h:

Rename selectionClipRect to focusedElementRect. We currently propagate the bounds of the focused element to the
UI process through EditorState updates, but only for the purpose of returning it in the computed selection clip
rect; instead, rename this member to something more general-purpose, so we can also use it when determining
whether to suppress the selection assistant.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _candidateRect]):

  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::handleRequestedCandidates):

  • UIProcess/ios/WKContentViewInteraction.h:

Add a new SuppressSelectionAssistantReason that corresponds to focusing tiny editable elements.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _zoomToRevealFocusedElement]):
(-[WKContentView _selectionClipRect]):
(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
(-[WKContentView _updateChangedSelection:]):

Check the size of the focused element, and begin or stop suppressing the selection assistant accordingly.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformEditorState const):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformEditorState const):

LayoutTests:

Add a new layout test to verify that native selection UI is suppressed when focusing a tiny (1px by 1px)
editable element.

  • editing/selection/ios/hide-selection-in-tiny-contenteditable-expected.txt: Added.
  • editing/selection/ios/hide-selection-in-tiny-contenteditable.html: Added.
  • resources/ui-helper.js:

(window.UIHelper.zoomToScale):

5:09 PM Changeset in webkit [239542] by Michael Catanzaro
  • 7 edits
    2 adds in releases/WebKitGTK/webkit-2.22

Merge r219121 - Synchronous media query evaluation could destroy current Frame/FrameView.
https://bugs.webkit.org/show_bug.cgi?id=192781
<rdar://problem/34416793>

Reviewed by Chris Dumez.

Source/WebCore:

Protect Frame and FrameView when coming back from printing and check if the current Frame/FrameView/FrameLoader objects are still valid.

Test: printing/print-with-media-query-destory.html

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::finishedLoading):

  • page/Frame.cpp:

(WebCore::Frame::setPrinting):

  • page/FrameView.cpp:

(WebCore::FrameView::forceLayoutForPagination):

  • page/PrintContext.cpp:

(WebCore::PrintContext::PrintContext):
(WebCore::PrintContext::computePageRects):
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
(WebCore::PrintContext::begin):
(WebCore::PrintContext::computeAutomaticScaleFactor):
(WebCore::PrintContext::spoolPage):
(WebCore::PrintContext::spoolRect):
(WebCore::PrintContext::end):

  • page/PrintContext.h:

(WebCore::PrintContext::frame const): Deleted.

LayoutTests:

  • printing/print-with-media-query-destory-expected.txt: Added.
  • printing/print-with-media-query-destory.html: Added.
2:54 PM Changeset in webkit [239541] by mitz@apple.com
  • 2 edits in trunk/Source/ThirdParty/libwebrtc

Fixed Apple production builds.

  • Configurations/Base.xcconfig: Exclude the Source/third_party/boringssl/src/util subdirectory, which contains binaries, from installsrc. Its contents are not used for building any of the targets in the project.
4:37 AM Changeset in webkit [239540] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

WebDriver: warn about non existing tests when parsing expectations
https://bugs.webkit.org/show_bug.cgi?id=192979

Reviewed by Michael Catanzaro.

It's common to update web driver tests and forget updating the test expectations in case of tests removed or
renamed.

  • Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:

(WebDriverTestRunner.init):

4:33 AM Changeset in webkit [239539] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[HarfBuzz] Width not correctly reported as 0 for zero font size
https://bugs.webkit.org/show_bug.cgi?id=192986

Reviewed by Michael Catanzaro.

Fixes test fast/text/font-size-zero.html

  • platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Use empty advances for glyphs when the font
size is zero.

Dec 21, 2018:

11:53 PM Changeset in webkit [239538] by mitz@apple.com
  • 2 edits in trunk/Source/WTF

Fixed building for macOS 10.13 using the macOS 10.14 SDK.

  • wtf/Platform.h: Changed HAVE_AUTHORIZATION_STATUS_FOR_MEDIA_TYPE to depend on the deployment target, not the SDK.
10:41 PM Changeset in webkit [239537] by yusukesuzuki@slowstart.org
  • 8 edits
    1 add in trunk

[JSC] Implement "well-formed JSON.stringify" proposal
https://bugs.webkit.org/show_bug.cgi?id=191677

Reviewed by Darin Adler.

JSTests:

  • stress/json-surrogate-pair.js: Added.

(shouldBe):

  • test262/expectations.yaml:

Source/WTF:

This patch implements "well-formed JSON.stringify" proposal[1], which is now stage 3.
JSON.stringify appended surrogate pair codes even if it is not paired appropriately.
The proposal requires that broken surrogate pairs are unicode-escaped.

[1]: https://github.com/tc39/proposal-well-formed-stringify

  • wtf/text/StringBuilderJSON.cpp:

(WTF::appendQuotedJSONStringInternal):

LayoutTests:

  • css3/escape-dom-api-expected.txt:
  • js/dom/webidl-type-mapping-expected.txt:
  • js/resources/json2-es5-compat.js:

(isHighSurrogate):
(isLowSurrogate):
(isSurrogate):
(quote):

10:39 PM Changeset in webkit [239536] by yusukesuzuki@slowstart.org
  • 2 edits in trunk/Source/JavaScriptCore

[JSC] Use appendUnbarriered for cached own keys
https://bugs.webkit.org/show_bug.cgi?id=192981

Reviewed by Saam Barati.

m_cachedOwnKeys would be changed to sentinel after checking thisObject->m_cachedOwnKeys.unvalidatedGet() != cachedOwnKeysSentinel()
and before executing visitor.append(thisObject->m_cachedOwnKeys). We never do this now, but might in the future.
To make the code safe, we should use appendUnbarriered to mark non sentinel cell.

  • runtime/StructureRareData.cpp:

(JSC::StructureRareData::visitChildren):

10:37 PM Changeset in webkit [239535] by yusukesuzuki@slowstart.org
  • 285 edits in trunk/Source

Use Ref<> as much as possible
https://bugs.webkit.org/show_bug.cgi?id=192808

Reviewed by Alex Christensen.

Source/JavaScriptCore:

  • API/JSTypedArray.cpp:

(JSObjectMakeTypedArrayWithBytesNoCopy):

  • API/JSWeakObjectMapRefPrivate.cpp:
  • bytecompiler/StaticPropertyAnalyzer.h:

(JSC::StaticPropertyAnalyzer::newObject):

  • dfg/DFGDesiredWatchpoints.cpp:

(JSC::DFG::ArrayBufferViewWatchpointAdaptor::add):

  • heap/Heap.cpp:

(JSC::Heap::Heap):
(JSC::Heap::sweeper):

  • heap/Heap.h:
  • heap/IsoCellSet.cpp:

(JSC::IsoCellSet::parallelNotEmptyMarkedBlockSource):

  • heap/IsoCellSet.h:
  • heap/IsoCellSetInlines.h:

(JSC::IsoCellSet::forEachMarkedCellInParallel):

  • heap/Subspace.cpp:

(JSC::Subspace::parallelDirectorySource):
(JSC::Subspace::parallelNotEmptyMarkedBlockSource):

  • heap/Subspace.h:
  • heap/SubspaceInlines.h:

(JSC::Subspace::forEachMarkedCellInParallel):

  • jsc.cpp:

(functionDollarAgentReceiveBroadcast):

  • runtime/ArrayBuffer.cpp:

(JSC::ArrayBuffer::slice const):
(JSC::ArrayBuffer::sliceImpl const):

  • runtime/ArrayBuffer.h:
  • runtime/ArrayBufferNeuteringWatchpoint.cpp:

(JSC::ArrayBufferNeuteringWatchpoint::ArrayBufferNeuteringWatchpoint):
(JSC::ArrayBufferNeuteringWatchpoint::fireAll):

  • runtime/ArrayBufferNeuteringWatchpoint.h:
  • runtime/JSArrayBufferPrototype.cpp:

(JSC::arrayBufferProtoFuncSlice):

Source/WebCore:

  • Modules/encryptedmedia/NavigatorEME.cpp:

(WebCore::NavigatorEME::requestMediaKeySystemAccess):

  • Modules/fetch/FetchBody.cpp:

(WebCore::FetchBody::bodyAsFormData const):

  • Modules/geolocation/Geolocation.cpp:

(WebCore::Geolocation::getCurrentPosition):
(WebCore::Geolocation::watchPosition):

  • Modules/indexeddb/IDBDatabase.cpp:

(WebCore::IDBDatabase::objectStoreNames const):

  • Modules/indexeddb/IDBDatabase.h:
  • Modules/indexeddb/IDBObjectStore.cpp:

(WebCore::IDBObjectStore::indexNames const):

  • Modules/indexeddb/IDBObjectStore.h:
  • Modules/indexeddb/IDBTransaction.cpp:

(WebCore::IDBTransaction::scheduleOperation):

  • Modules/indexeddb/IDBTransaction.h:
  • Modules/indexeddb/client/TransactionOperation.h:

(WebCore::IDBClient::createTransactionOperation):

  • Modules/mediastream/MediaDevices.cpp:

(WebCore::MediaDevices::getUserMedia const):
(WebCore::MediaDevices::getDisplayMedia const):

  • Modules/mediastream/UserMediaRequest.cpp:

(WebCore::UserMediaRequest::create):

  • Modules/mediastream/UserMediaRequest.h:
  • Modules/webaudio/AudioParam.cpp:

(WebCore::AudioParam::calculateFinalValues):

  • Modules/webaudio/ScriptProcessorNode.cpp:

(WebCore::ScriptProcessorNode::initialize):

  • Modules/webdatabase/SQLStatement.cpp:

(WebCore::SQLStatement::execute):

  • Modules/webgpu/WebGPU.cpp:

(WebCore::WebGPU::requestAdapter const):

  • Modules/webgpu/WebGPUAdapter.cpp:

(WebCore::WebGPUAdapter::create):

  • Modules/webgpu/WebGPUAdapter.h:
  • Modules/webgpu/WebGPUBuffer.cpp:

(WebCore::WebGPUBuffer::create):

  • Modules/webgpu/WebGPUBuffer.h:
  • Modules/webgpu/WebGPUCommandBuffer.cpp:

(WebCore::WebGPUCommandBuffer::create):
(WebCore::WebGPUCommandBuffer::beginRenderPass):

  • Modules/webgpu/WebGPUCommandBuffer.h:
  • Modules/webgpu/WebGPUDevice.cpp:

(WebCore::WebGPUDevice::create):
(WebCore::WebGPUDevice::createBuffer const):
(WebCore::WebGPUDevice::createShaderModule const):
(WebCore::WebGPUDevice::createRenderPipeline const):
(WebCore::WebGPUDevice::createCommandBuffer const):

  • Modules/webgpu/WebGPURenderPassEncoder.cpp:

(WebCore::WebGPURenderPassEncoder::create):

  • Modules/webgpu/WebGPURenderPassEncoder.h:
  • Modules/webgpu/WebGPURenderPipeline.cpp:

(WebCore::WebGPURenderPipeline::create):

  • Modules/webgpu/WebGPURenderPipeline.h:
  • Modules/webgpu/WebGPUShaderModule.cpp:

(WebCore::WebGPUShaderModule::create):

  • Modules/webgpu/WebGPUShaderModule.h:
  • Modules/webgpu/WebGPUTexture.cpp:

(WebCore::WebGPUTexture::createDefaultTextureView):

  • Modules/webgpu/WebGPUTextureView.cpp:

(WebCore::WebGPUTextureView::create):

  • Modules/webgpu/WebGPUTextureView.h:
  • accessibility/AXObjectCache.cpp:

(WebCore::AXObjectCache::rangeMatchesTextNearRange):

  • accessibility/atk/AXObjectCacheAtk.cpp:

(WebCore::AXObjectCache::nodeTextChangePlatformNotification):

  • accessibility/atk/WebKitAccessibleHyperlink.cpp:

(webkitAccessibleHyperlinkGetStartIndex):
(webkitAccessibleHyperlinkGetEndIndex):

  • accessibility/atk/WebKitAccessibleInterfaceText.cpp:

(getSelectionOffsetsForObject):

  • accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:

(-[WebAccessibilityObjectWrapper _convertToNSRange:]):

  • bindings/js/JSDOMGlobalObjectTask.cpp:
  • bindings/js/JSDOMWindowBase.cpp:

(WebCore::JSDOMWindowBase::queueTaskToEventLoop):

  • bindings/js/JSWorkerGlobalScopeBase.cpp:

(WebCore::JSWorkerGlobalScopeBase::queueTaskToEventLoop):

  • bindings/js/ScriptControllerMac.mm:

(WebCore::ScriptController::createScriptInstanceForWidget):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneDeserializer::readTerminal):
(WebCore::SerializedScriptValue::create):

  • bridge/objc/objc_instance.h:
  • bridge/objc/objc_instance.mm:

(ObjcInstance::create):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::ComputedStyleExtractor::currentColorOrValidColor const):
(WebCore::ComputedStyleExtractor::getCSSPropertyValuesForShorthandProperties):
(WebCore::ComputedStyleExtractor::getCSSPropertyValuesForGridShorthand):
(WebCore::ComputedStyleExtractor::getBackgroundShorthandValue):

  • css/CSSComputedStyleDeclaration.h:
  • css/CSSFontFaceSource.cpp:

(WebCore::CSSFontFaceSource::load):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::rules):

  • css/FontFace.cpp:

(WebCore::FontFace::unicodeRange const):
(WebCore::FontFace::featureSettings const):

  • css/InspectorCSSOMWrappers.cpp:

(WebCore::InspectorCSSOMWrappers::collectFromStyleSheetContents):

  • css/SVGCSSComputedStyleDeclaration.cpp:

(WebCore::strokeDashArrayToCSSValueList):
(WebCore::ComputedStyleExtractor::adjustSVGPaintForCurrentColor const):

  • css/StyleResolver.cpp:

(WebCore::StyleResolver::createFilterOperations):

  • css/StyleRule.cpp:

(WebCore::StyleRuleBase::createCSSOMWrapper const):

  • css/StyleRule.h:
  • dom/ChildListMutationScope.cpp:

(WebCore::ChildListMutationAccumulator::getOrCreate):

  • dom/ChildListMutationScope.h:
  • dom/DocumentMarkerController.cpp:

(WebCore::updateRenderedRectsForMarker):

  • dom/InlineStyleSheetOwner.cpp:

(WebCore::InlineStyleSheetOwner::createSheet):

  • dom/PointerEvent.h:
  • dom/UserGestureIndicator.h:

(WebCore::UserGestureToken::create):

  • editing/AlternativeTextController.cpp:

(WebCore::AlternativeTextController::applyAlternativeTextToRange):
(WebCore::AlternativeTextController::respondToUnappliedSpellCorrection):
(WebCore::AlternativeTextController::respondToUnappliedEditing):
(WebCore::AlternativeTextController::markPrecedingWhitespaceForDeletedAutocorrectionAfterCommand):
(WebCore::AlternativeTextController::respondToMarkerAtEndOfWord):

  • editing/ApplyStyleCommand.cpp:

(WebCore::ApplyStyleCommand::applyBlockStyle):
(WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode):

  • editing/CompositeEditCommand.cpp:

(WebCore::CompositeEditCommand::targetRanges const):
(WebCore::CompositeEditCommand::replaceTextInNodePreservingMarkers):
(WebCore::CompositeEditCommand::moveParagraphs):

  • editing/DeleteSelectionCommand.cpp:

(WebCore::DeleteSelectionCommand::mergeParagraphs):

  • editing/Editing.cpp:

(WebCore::visiblePositionForIndexUsingCharacterIterator):

  • editing/EditingStyle.cpp:

(WebCore::EditingStyle::removeStyleConflictingWithStyleOfNode):
(WebCore::EditingStyle::conflictsWithInlineStyleOfElement const):
(WebCore::EditingStyle::prepareToApplyAt):
(WebCore::EditingStyle::mergeInlineAndImplicitStyleOfElement):
(WebCore::EditingStyle::mergeStyleFromRulesForSerialization):
(WebCore::EditingStyle::removeStyleFromRulesAndContext):
(WebCore::extractPropertiesNotIn):

  • editing/Editor.cpp:

(WebCore::Editor::setBaseWritingDirection):
(WebCore::Editor::setComposition):

  • editing/EditorCommand.cpp:

(WebCore::executeApplyParagraphStyle):
(WebCore::executeMakeTextWritingDirectionLeftToRight):
(WebCore::executeMakeTextWritingDirectionNatural):
(WebCore::executeMakeTextWritingDirectionRightToLeft):

  • editing/FormatBlockCommand.cpp:

(WebCore::FormatBlockCommand::formatRange):

  • editing/RemoveFormatCommand.cpp:

(WebCore::RemoveFormatCommand::doApply):

  • editing/ReplaceRangeWithTextCommand.cpp:

(WebCore::ReplaceRangeWithTextCommand::targetRanges const):

  • editing/ReplaceSelectionCommand.cpp:

(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
(WebCore::handleStyleSpansBeforeInsertion):
(WebCore::ReplaceSelectionCommand::handleStyleSpans):

  • editing/SpellingCorrectionCommand.cpp:

(WebCore::SpellingCorrectionCommand::targetRanges const):

  • editing/TextCheckingHelper.cpp:

(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):

  • editing/TypingCommand.cpp:

(WebCore::TypingCommand::insertText):
(WebCore::TypingCommand::willAddTypingToOpenCommand):

  • editing/VisibleUnits.cpp:

(WebCore::distanceBetweenPositions):

  • editing/cocoa/EditorCocoa.mm:

(WebCore::Editor::selectionInWebArchiveFormat):

  • editing/ios/DictationCommandIOS.cpp:

(WebCore::DictationCommandIOS::doApply):

  • editing/ios/EditorIOS.mm:

(WebCore::Editor::setTextAlignmentForChangedBaseWritingDirection):
(WebCore::Editor::removeUnchangeableStyles):
(WebCore::Editor::writeImageToPasteboard):

  • editing/mac/EditorMac.mm:

(WebCore::Editor::replaceNodeFromPasteboard):
(WebCore::Editor::imageInWebArchiveFormat):

  • editing/markup.cpp:

(WebCore::styleFromMatchedRulesAndInlineDecl):
(WebCore::createFragmentForTransformToFragment):

  • fileapi/FileReaderLoader.cpp:

(WebCore::FileReaderLoader::didFinishLoading):

  • html/FTPDirectoryDocument.cpp:

(WebCore::createTemplateDocumentData):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::scheduleEvent):
(WebCore::HTMLMediaElement::createMediaControls):

  • html/HTMLTableElement.cpp:

(WebCore::HTMLTableElement::createSharedCellStyle):

  • html/HTMLTableElement.h:
  • html/URLUtils.h:

(WebCore::URLUtils<T>::origin const):

  • html/parser/HTMLConstructionSite.cpp:

(WebCore::HTMLConstructionSite::createHTMLElementOrFindCustomElementInterface):

  • html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerElement::resolveCustomStyle):

  • html/track/WebVTTParser.cpp:

(WebCore::WebVTTParser::createNewCue):

  • inspector/DOMPatchSupport.cpp:
  • inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::buildInitialState):
(WebCore::InspectorCanvas::buildAction):

  • inspector/InspectorFrontendClientLocal.cpp:

(WebCore::InspectorFrontendClientLocal::openInNewTab):

  • inspector/InspectorStyleSheet.cpp:

(WebCore::asCSSRuleList):
(WebCore::InspectorStyle::styleWithProperties const):
(WebCore::InspectorStyleSheet::ensureSourceData):

  • inspector/agents/InspectorCanvasAgent.cpp:

(WebCore::InspectorCanvasAgent::didCreateCanvasRenderingContext):

  • inspector/agents/InspectorIndexedDBAgent.cpp:

(WebCore::Inspector::keyPathFromIDBKeyPath):

  • inspector/agents/InspectorPageAgent.cpp:

(WebCore::InspectorPageAgent::archive):

  • loader/EmptyClients.cpp:

(WebCore::EmptyStorageNamespaceProvider::createSessionStorageNamespace):
(WebCore::EmptyStorageNamespaceProvider::createLocalStorageNamespace):
(WebCore::EmptyStorageNamespaceProvider::createEphemeralLocalStorageNamespace):
(WebCore::EmptyStorageNamespaceProvider::createTransientLocalStorageNamespace):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
(WebCore::FrameLoader::loadDifferentDocumentItem):

  • loader/WorkerThreadableLoader.cpp:

(WebCore::WorkerThreadableLoader::loadResourceSynchronously):

  • loader/archive/mhtml/MHTMLParser.cpp:

(WebCore::MHTMLParser::addResourceToArchive):
(WebCore::MHTMLParser::parseNextPart):

  • loader/cache/MemoryCache.cpp:

(WebCore::MemoryCache::addImageToCache):
(WebCore::MemoryCache::removeResourcesWithOrigin):

  • page/DOMWindow.cpp:

(WebCore::DOMWindow::getMatchedCSSRules const):
(WebCore::DOMWindow::createWindow):

  • page/EventHandler.cpp:

(WebCore::textDistance):

  • page/Page.cpp:

(WebCore::Page::userStyleSheet const):

  • page/animation/CSSPropertyAnimation.cpp:

(WebCore::blendFilterOperations):

  • page/ios/FrameIOS.mm:

(WebCore::Frame::initWithSimpleHTMLDocument):
(WebCore::Frame::interpretationsForCurrentRoot const):

  • page/mac/ServicesOverlayController.mm:

(WebCore::ServicesOverlayController::Highlight::fadeIn):
(WebCore::ServicesOverlayController::Highlight::fadeOut):

  • platform/SharedBuffer.cpp:

(WebCore::SharedBuffer::tryCreateArrayBuffer const):

  • platform/audio/HRTFElevation.cpp:

(WebCore::HRTFElevation::calculateKernelsForAzimuthElevation):

  • platform/audio/SincResampler.cpp:

(WebCore::SincResampler::consumeSource):

  • platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:

(WebCore::AudioFileReader::createBus):

  • platform/audio/mac/AudioFileReaderMac.cpp:

(WebCore::AudioFileReader::createBus):

  • platform/graphics/Icon.h:

(WebCore::Icon::create):

  • platform/graphics/InbandTextTrackPrivate.h:

(WebCore::InbandTextTrackPrivate::create):

  • platform/graphics/avfoundation/cf/MediaPlayerPrivateAVFoundationCF.cpp:

(WebCore::AVFWrapper::shouldWaitForLoadingOfResource):

  • platform/graphics/avfoundation/objc/AudioTrackPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::fulfillRequestWithKeyData):
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):

  • platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaSourcePrivateAVFObjC.mm:

(WebCore::MediaSourcePrivateAVFObjC::create):
(WebCore::MediaSourcePrivateAVFObjC::addSourceBuffer):

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::create):
(WebCore::SourceBufferPrivateAVFObjC::didParseStreamDataAsAsset):

  • platform/graphics/avfoundation/objc/VideoTrackPrivateMediaSourceAVFObjC.h:
  • platform/graphics/ca/TileController.cpp:

(WebCore::TileController::createTileLayer):

  • platform/graphics/ca/TileController.h:
  • platform/graphics/ca/win/CACFLayerTreeHost.cpp:

(WebCore::CACFLayerTreeHost::acceleratedCompositingAvailable):
(WebCore::CACFLayerTreeHost::create):

  • platform/graphics/gpu/cocoa/GPUBufferMetal.mm:

(WebCore::GPUBuffer::create):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:

(WebCore::MediaPlayerPrivateGStreamer::updateTracks):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfVideo):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfAudio):
(WebCore::MediaPlayerPrivateGStreamer::notifyPlayerOfText):
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):
(WebCore::MediaPlayerPrivateGStreamer::processMpegTsSection):
(WebCore::MediaPlayerPrivateGStreamer::loadNextLocation):

  • platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:

(WebCore::MediaPlayerPrivateGStreamerBase::paint):

  • platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::appsinkNewSample):

  • platform/graphics/iso/ISOProtectionSystemSpecificHeaderBox.cpp:

(WebCore::ISOProtectionSystemSpecificHeaderBox::parse):

  • platform/graphics/iso/ISOTrackEncryptionBox.cpp:

(WebCore::ISOTrackEncryptionBox::parse):

  • platform/graphics/texmap/TextureMapperAnimation.cpp:

(WebCore::applyFilterAnimation):

  • platform/graphics/texmap/TextureMapperPlatformLayerBuffer.cpp:

(WebCore::TextureMapperPlatformLayerBuffer::clone):

  • platform/graphics/transforms/TransformOperations.cpp:

(WebCore::TransformOperations::blendByMatchingOperations const):

  • platform/image-decoders/ico/ICOImageDecoder.cpp:

(WebCore::ICOImageDecoder::setDataForPNGDecoderAtIndex):

  • platform/mock/mediasource/MockBox.cpp:

(WebCore::MockInitializationBox::MockInitializationBox):

  • platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockSourceBufferPrivate::create):
(WebCore::MockSourceBufferPrivate::append):

  • platform/mock/mediasource/MockSourceBufferPrivate.h:
  • platform/mock/mediasource/MockTracks.h:

(WebCore::MockTextTrackPrivate::create):
(WebCore::MockVideoTrackPrivate::create):

  • platform/network/FormData.h:

(WebCore::FormData::decode):

  • platform/network/cocoa/CookieStorageObserver.h:
  • platform/network/cocoa/CookieStorageObserver.mm:

(WebCore::CookieStorageObserver::create):

  • platform/network/soup/ResourceRequestSoup.cpp:

(WebCore::appendEncodedBlobItemToSoupMessageBody):
(WebCore::ResourceRequest::updateSoupMessageBody const):

  • platform/text/hyphen/HyphenationLibHyphen.cpp:

(WebCore::HyphenationDictionary::createNull):
(WebCore::HyphenationDictionary::create):

  • platform/win/SearchPopupMenuWin.cpp:

(WebCore::SearchPopupMenuWin::SearchPopupMenuWin):
(WebCore::SearchPopupMenuWin::popupMenu):

  • platform/win/SearchPopupMenuWin.h:
  • rendering/RenderThemeIOS.mm:

(WebCore::applyCommonButtonPaddingToStyle):
(WebCore::RenderThemeIOS::paintProgressBar):
(WebCore::RenderThemeIOS::adjustButtonStyle const):
(WebCore::paintAttachmentIcon):

  • rendering/svg/SVGRenderTreeAsText.cpp:

(WebCore::writeSVGResourceContainer):

  • storage/Storage.cpp:

(WebCore::Storage::create):
(WebCore::Storage::Storage):

  • storage/Storage.h:

(WebCore::Storage::area const):

  • storage/StorageNamespace.h:
  • storage/StorageNamespaceProvider.cpp:

(WebCore::StorageNamespaceProvider::localStorageArea):

  • storage/StorageNamespaceProvider.h:
  • svg/SVGElement.cpp:

(WebCore::SVGElement::getPresentationAttribute):

  • svg/SVGFEBlendElement.cpp:

(WebCore::SVGFEBlendElement::build):

  • svg/SVGFEColorMatrixElement.cpp:

(WebCore::SVGFEColorMatrixElement::build):

  • svg/SVGFEComponentTransferElement.cpp:

(WebCore::SVGFEComponentTransferElement::build):

  • svg/SVGFECompositeElement.cpp:

(WebCore::SVGFECompositeElement::build):

  • svg/SVGFEDiffuseLightingElement.cpp:

(WebCore::SVGFEDiffuseLightingElement::build):

  • svg/SVGFEDisplacementMapElement.cpp:

(WebCore::SVGFEDisplacementMapElement::build):

  • svg/SVGFEDropShadowElement.cpp:

(WebCore::SVGFEDropShadowElement::build):

  • svg/SVGFEGaussianBlurElement.cpp:

(WebCore::SVGFEGaussianBlurElement::build):

  • svg/SVGFEMergeElement.cpp:

(WebCore::SVGFEMergeElement::build):

  • svg/SVGFEMorphologyElement.cpp:

(WebCore::SVGFEMorphologyElement::build):

  • svg/SVGFEOffsetElement.cpp:

(WebCore::SVGFEOffsetElement::build):

  • svg/SVGFESpecularLightingElement.cpp:

(WebCore::SVGFESpecularLightingElement::build):

  • svg/SVGFETileElement.cpp:

(WebCore::SVGFETileElement::build):

  • testing/GCObservation.h:
  • xml/XSLTProcessor.cpp:

(WebCore::XSLTProcessor::createDocumentFromSource):

  • xml/parser/XMLDocumentParser.cpp:

(WebCore::XMLDocumentParser::parseDocumentFragment):

Source/WebKit:

  • PluginProcess/WebProcessConnection.cpp:

(WebKit::WebProcessConnection::create):

  • PluginProcess/WebProcessConnection.h:
  • UIProcess/API/Cocoa/WKConnection.mm:

(-[WKConnection sendMessageWithName:body:]):

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView takeSnapshotWithConfiguration:completionHandler:]):
(-[WKWebView _takeViewSnapshot]):
(-[WKWebView _snapshotRect:intoImageOfWidth:completionHandler:]):

  • UIProcess/API/glib/WebKitGeolocationProvider.cpp:

(WebKit::WebKitGeolocationProvider::notifyPositionChanged):

  • UIProcess/API/glib/WebKitWebContext.cpp:

(webkit_web_context_allow_tls_certificate_for_host):

  • UIProcess/Automation/cairo/WebAutomationSessionCairo.cpp:

(WebKit::WebAutomationSession::platformGetBase64EncodedPNGData):

  • UIProcess/Automation/cocoa/WebAutomationSessionCocoa.mm:

(WebKit::WebAutomationSession::platformGetBase64EncodedPNGData):

  • UIProcess/BackingStore.cpp:

(WebKit::BackingStore::incorporateUpdate):

  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::createErrorWithRecoveryAttempter):

  • UIProcess/Cocoa/PlaybackSessionManagerProxy.h:
  • UIProcess/Cocoa/PlaybackSessionManagerProxy.mm:

(WebKit::PlaybackSessionManagerProxy::create):

  • UIProcess/Cocoa/VideoFullscreenManagerProxy.h:
  • UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:

(WebKit::VideoFullscreenManagerProxy::create):

  • UIProcess/Cocoa/WebPasteboardProxyCocoa.mm:

(WebKit::WebPasteboardProxy::setPasteboardBufferForType):

  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::takeViewSnapshot):

  • UIProcess/Downloads/DownloadProxyMap.cpp:

(WebKit::DownloadProxyMap::createDownloadProxy):

  • UIProcess/Notifications/WebNotificationManagerProxy.cpp:

(WebKit::WebNotificationManagerProxy::show):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didCreateSubframe):

  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::getStatistics):
(WebKit::WebProcessPool::requestWebContentStatistics):
(WebKit::WebProcessPool::requestNetworkingStatistics):

  • UIProcess/WebProcessPool.h:
  • UIProcess/gstreamer/WebPageProxyGStreamer.cpp:

(WebKit::WebPageProxy::requestInstallMissingMediaPlugins):

  • UIProcess/gtk/RemoteWebInspectorProxyGtk.cpp:

(WebKit::RemoteWebInspectorProxy::platformCreateFrontendPageAndWindow):

  • UIProcess/gtk/WebInspectorProxyGtk.cpp:

(WebKit::WebInspectorProxy::platformCreateFrontendPage):

  • UIProcess/ios/WKGeolocationProviderIOS.mm:

(-[WKGeolocationProviderIOS geolocationAuthorizationGranted]):

  • UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::setPromisedDataForImage):

  • UIProcess/win/WebInspectorProxyWin.cpp:

(WebKit::WebInspectorProxy::platformCreateFrontendPage):

  • WebProcess/InjectedBundle/API/mac/WKDOMRange.mm:

(-[WKDOMRange initWithDocument:]):

  • WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:

(WebKit::InjectedBundleRangeHandle::renderedImage):

  • WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:

(WebKit::InjectedBundlePageEditorClient::getPasteboardDataForRange):

  • WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:

(WebKit::InjectedBundlePageUIClient::mouseDidMoveOverElement):

  • WebProcess/Plugins/Netscape/NetscapePlugin.cpp:

(WebKit::NetscapePlugin::snapshot):

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::addArchiveResource):
(WebKit::PDFPlugin::snapshot):
(WebKit::PDFPlugin::writeItemsToPasteboard):

  • WebProcess/Plugins/PluginProcessConnectionManager.cpp:

(WebKit::PluginProcessConnectionManager::getPluginProcessConnection):

  • WebProcess/Plugins/PluginProxy.cpp:

(WebKit::PluginProxy::snapshot):

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::performURLRequest):

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::exceededDatabaseQuota):
(WebKit::WebChromeClient::reachedApplicationCacheOriginQuota):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):

  • WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:

(WebKit::WebPlatformStrategies::getPathnamesForType):

  • WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp:

(WebKit::convertCairoSurfaceToShareableBitmap):

  • WebProcess/WebCoreSupport/mac/WebDragClientMac.mm:

(WebKit::WebDragClient::declareAndWriteDragImage):

  • WebProcess/WebPage/Cocoa/WebPageCocoa.mm:

(WebKit::WebPage::dictionaryPopupInfoForRange):

  • WebProcess/WebPage/DrawingAreaImpl.cpp:

(WebKit::DrawingAreaImpl::display):

  • WebProcess/WebPage/FindController.cpp:

(WebKit::FindController::updateFindIndicator):

  • WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:

(WebKit::RemoteLayerTreeDrawingArea::flushLayers):

  • WebProcess/WebPage/WebFrame.cpp:

(WebKit::WebFrame::webArchiveData):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::navigateToPDFLinkWithSimulatedClick):
(WebKit::WebPage::performDragControllerAction):

  • WebProcess/WebPage/ios/FindControllerIOS.mm:

(WebKit::FindController::updateFindIndicator):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::replaceDictatedText):
(WebKit::WebPage::getPositionInformation):

  • WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:

(WebKit::TiledCoreAnimationDrawingArea::commitTransientZoom):

  • WebProcess/WebStorage/StorageNamespaceImpl.cpp:

(WebKit::StorageNamespaceImpl::createSessionStorageNamespace):
(WebKit::StorageNamespaceImpl::createEphemeralLocalStorageNamespace):
(WebKit::StorageNamespaceImpl::createLocalStorageNamespace):
(WebKit::StorageNamespaceImpl::createTransientLocalStorageNamespace):
(WebKit::StorageNamespaceImpl::storageArea):
(WebKit::StorageNamespaceImpl::ephemeralLocalStorageArea):
(WebKit::StorageNamespaceImpl::copy):

  • WebProcess/WebStorage/StorageNamespaceImpl.h:
  • WebProcess/WebStorage/WebStorageNamespaceProvider.cpp:

(WebKit::WebStorageNamespaceProvider::getOrCreate):
(WebKit::WebStorageNamespaceProvider::createSessionStorageNamespace):
(WebKit::WebStorageNamespaceProvider::createEphemeralLocalStorageNamespace):
(WebKit::WebStorageNamespaceProvider::createLocalStorageNamespace):
(WebKit::WebStorageNamespaceProvider::createTransientLocalStorageNamespace):

  • WebProcess/WebStorage/WebStorageNamespaceProvider.h:
  • WebProcess/cocoa/PlaybackSessionManager.mm:

(WebKit::PlaybackSessionManager::createModelAndInterface):

  • WebProcess/cocoa/VideoFullscreenManager.mm:

(WebKit::VideoFullscreenManager::createModelAndInterface):

Source/WebKitLegacy:

  • Storage/StorageNamespaceImpl.cpp:

(WebKit::StorageNamespaceImpl::copy):
(WebKit::StorageNamespaceImpl::storageArea):

  • Storage/StorageNamespaceImpl.h:
  • Storage/WebStorageNamespaceProvider.cpp:

(WebKit::WebStorageNamespaceProvider::create):
(WebKit::WebStorageNamespaceProvider::createSessionStorageNamespace):
(WebKit::WebStorageNamespaceProvider::createEphemeralLocalStorageNamespace):
(WebKit::WebStorageNamespaceProvider::createLocalStorageNamespace):
(WebKit::WebStorageNamespaceProvider::createTransientLocalStorageNamespace):

  • Storage/WebStorageNamespaceProvider.h:
  • WebCoreSupport/WebViewGroup.cpp:

(WebViewGroup::getOrCreate):

  • WebCoreSupport/WebViewGroup.h:

Source/WebKitLegacy/ios:

  • WebCoreSupport/SearchPopupMenuIOS.cpp:

(SearchPopupMenuIOS::SearchPopupMenuIOS):
(SearchPopupMenuIOS::popupMenu):

  • WebCoreSupport/SearchPopupMenuIOS.h:
  • WebCoreSupport/WebVisiblePosition.mm:

(-[WebVisiblePosition enclosingRangeWithDictationPhraseAlternatives:]):
(-[WebVisiblePosition enclosingRangeWithCorrectionIndicator]):

  • WebView/WebPDFViewPlaceholder.mm:

(-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):

Source/WebKitLegacy/mac:

  • DOM/DOM.mm:

(-[DOMNode getPreviewSnapshotImage:andRects:]):

  • Plugins/Hosted/NetscapePluginHostManager.mm:

(WebKit::NetscapePluginHostManager::instantiatePlugin):

  • Plugins/Hosted/NetscapePluginInstanceProxy.mm:

(WebKit::NetscapePluginInstanceProxy::evaluateJavaScript):
(WebKit::NetscapePluginInstanceProxy::loadRequest):

  • Plugins/WebNetscapePluginView.mm:

(-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
(-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

  • WebCoreSupport/WebContextMenuClient.mm:

(WebContextMenuClient::imageForCurrentSharingServicePickerItem):

  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::transitionToCommittedForNewPage):

  • WebView/WebFrame.mm:

(-[WebFrame getDictationResultRanges:andMetadatas:]):

  • WebView/WebHTMLView.mm:

(-[WebHTMLView _writeSelectionWithPasteboardTypes:toPasteboard:cachedAttributedString:]):

  • WebView/WebView.mm:

(+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:injectedFrames:]):
(+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:injectedFrames:]):

Source/WebKitLegacy/win:

  • Plugins/PluginDatabase.cpp:

(WebCore::PluginDatabase::refresh):

  • Plugins/PluginView.cpp:

(WebCore::PluginView::mediaCanStart):
(WebCore::PluginView::performRequest):
(WebCore::PluginView::bindingInstance):

  • Plugins/PluginView.h:
  • WebCoreSupport/WebFrameLoaderClient.cpp:

(WebFrameLoaderClient::dispatchDidFailToStartPlugin const):
(WebFrameLoaderClient::createPlugin):
(WebFrameLoaderClient::createJavaAppletWidget):

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebFrame.cpp:

(WebFrame::loadData):
(WebFrame::loadPlainTextString):
(WebFrame::loadHTMLString):

  • WebFrame.h:
  • WebKitQuartzCoreAdditions/CAView.cpp:

(WKQCA::CAView::create):

  • WebKitQuartzCoreAdditions/CAView.h:
  • WebKitQuartzCoreAdditions/CVDisplayLink.cpp:

(WKQCA::CVDisplayLink::create):

  • WebKitQuartzCoreAdditions/CVDisplayLink.h:
  • WebKitQuartzCoreAdditions/ImageConversion.cpp:

(WKQCA::getImageCopy):

  • WebView.cpp:

(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):

7:23 PM Changeset in webkit [239534] by Chris Dumez
  • 22 edits in trunk

navigator.userAgent in service workers does not reflect customUserAgent set by client
https://bugs.webkit.org/show_bug.cgi?id=192951

Reviewed by Youenn Fablet.

Source/WebCore:

Whenever a service worker client registers itself, also pass its effective user agent.
In the network process, for each origin, we store the latest client's user agent and
use it when starting the service worker.

  • dom/Document.cpp:

(WebCore::Document::setServiceWorkerConnection):

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::registerTemporaryServiceWorkerClient):

  • workers/service/SWClientConnection.h:
  • workers/service/server/SWServer.cpp:

(WebCore::SWServer::serviceWorkerClientUserAgent const):
(WebCore::SWServer::installContextData):
(WebCore::SWServer::runServiceWorker):
(WebCore::SWServer::registerServiceWorkerClient):

  • workers/service/server/SWServer.h:
  • workers/service/server/SWServerToContextConnection.h:
  • workers/service/server/SWServerWorker.cpp:

(WebCore::SWServerWorker::userAgent const):

  • workers/service/server/SWServerWorker.h:

Source/WebKit:

  • NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:

(WebKit::WebSWServerConnection::registerServiceWorkerClient):

  • NetworkProcess/ServiceWorker/WebSWServerConnection.h:
  • NetworkProcess/ServiceWorker/WebSWServerConnection.messages.in:
  • NetworkProcess/ServiceWorker/WebSWServerToContextConnection.cpp:

(WebKit::WebSWServerToContextConnection::installServiceWorkerContext):

  • NetworkProcess/ServiceWorker/WebSWServerToContextConnection.h:
  • WebProcess/Storage/WebSWClientConnection.cpp:

(WebKit::WebSWClientConnection::registerServiceWorkerClient):

  • WebProcess/Storage/WebSWClientConnection.h:
  • WebProcess/Storage/WebSWContextManagerConnection.cpp:

(WebKit::WebSWContextManagerConnection::installServiceWorker):

  • WebProcess/Storage/WebSWContextManagerConnection.h:
  • WebProcess/Storage/WebSWContextManagerConnection.messages.in:

Tools:

Extend API test coverage.

  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

(-[SWCustomUserAgentDelegate initWithUserAgent:]):
(-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
(-[SWUserAgentMessageHandler initWithExpectedMessage:]):
(-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):

6:19 PM Changeset in webkit [239533] by commit-queue@webkit.org
  • 524 edits
    11 copies
    1 move
    282 adds
    185 deletes in trunk/Source/ThirdParty/libwebrtc

Resync BoringSSL to M72
https://bugs.webkit.org/show_bug.cgi?id=192860

Patch by Youenn Fablet <youenn@apple.com> and Alejandro G. Castro <alex@igalia.com> on 2018-12-21
Reviewed by Eric Carlson.

  • Source/third_party/boringssl: Resynced to Chrome M72 branch.
6:14 PM Changeset in webkit [239532] by youenn@apple.com
  • 4 edits in trunk

RTCRtpSender.setParameters() does set active parameter
https://bugs.webkit.org/show_bug.cgi?id=192848

Reviewed by Eric Carlson.

Source/WebCore:

Covered by updated test.

  • Modules/mediastream/libwebrtc/LibWebRTCUtils.cpp:

(WebCore::updateRTCRtpSendParameters):
The routine was updating the local value, not the out parameter.

LayoutTests:

  • webrtc/video.html:

Add a check for active value.
Test video freezing through canvas instead of stats.

5:37 PM Changeset in webkit [239531] by eric.carlson@apple.com
  • 9 edits in trunk/Source/WebCore

'ended' Event doesn't fire on MediaStreamTrack when a USB camera is unplugged
https://bugs.webkit.org/show_bug.cgi?id=187896
<rdar://problem/42681445>

Reviewed by Jer Noble.

Source/WebCore:

No new tests, tested manually.

  • platform/mediastream/mac/AVVideoCaptureSource.h:
  • platform/mediastream/mac/AVVideoCaptureSource.mm:

(WebCore::AVVideoCaptureSource::deviceDisconnected):
(-[WebCoreAVVideoCaptureSourceObserver addNotificationObservers]):
(-[WebCoreAVVideoCaptureSourceObserver removeNotificationObservers]):
(-[WebCoreAVVideoCaptureSourceObserver deviceConnectedDidChange:]):

  • platform/mediastream/mac/CoreAudioCaptureDeviceManager.cpp:

(WebCore::deviceHasInputStreams):
(WebCore::isValidCaptureDevice):
(WebCore::CoreAudioCaptureDeviceManager::coreAudioCaptureDevices):
(WebCore::CoreAudioCaptureDeviceManager::refreshAudioCaptureDevices):
(WebCore::CoreAudioCaptureDeviceManager::devicesChanged): Deleted.

  • platform/mediastream/mac/CoreAudioCaptureDeviceManager.h:
  • platform/mediastream/mac/CoreAudioCaptureSource.cpp:

(WebCore::CoreAudioSharedUnit::setCaptureDevice):
(WebCore::CoreAudioSharedUnit::devicesChanged):
(WebCore::CoreAudioSharedUnit::startProducingData):
(WebCore::CoreAudioSharedUnit::startInternal):
(WebCore::CoreAudioSharedUnit::verifyIsCapturing):
(WebCore::CoreAudioSharedUnit::captureFailed):
(WebCore::CoreAudioCaptureSourceFactory::devicesChanged):
(WebCore::CoreAudioCaptureSource::CoreAudioCaptureSource):
(WebCore::CoreAudioSharedUnit::setCaptureDeviceID): Deleted.

  • platform/mediastream/mac/CoreAudioCaptureSource.h:

Source/WebCore/PAL:

  • pal/spi/cf/CoreAudioSPI.h:
4:39 PM Changeset in webkit [239530] by Devin Rousso
  • 4 edits
    4 deletes in trunk/Source/WebInspectorUI

Web Inspector: Styles Redesign: remove unused CSS style icons
https://bugs.webkit.org/show_bug.cgi?id=192999
<rdar://problem/46912094>

Reviewed by Matt Baker.

  • UserInterface/Main.html:
  • UserInterface/Views/StyleRuleIcons.css: Removed.
  • UserInterface/Images/StyleRule.svg: Removed.
  • UserInterface/Images/StyleRuleInheritedElement.svg: Removed.
  • UserInterface/Images/StyleRulePseudoElement.svg: Removed.
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
4:28 PM Changeset in webkit [239529] by rniwa@webkit.org
  • 5 edits in trunk/Source/WebCore

REGRESSION(r239353): iOS WK1 Assertion failure in notifyChildNodeRemoved while running
TestWebKitAPI.QuickLook.LegacyQuickLookContent
https://bugs.webkit.org/show_bug.cgi?id=192859
<rdar://problem/46887237>

Reviewed by Antti Koivisto.

After r239353, ScriptDisallowedScope::InMainThread::isScriptAllowed() may return false when the web thread
is inside a delegate callback even when there is a ScriptDisallowedScope defined.

Replace the existign debug assertions which assert !ScriptDisallowedScope::InMainThread::isScriptAllowed()
by a newly added ScriptDisallowedScope::InMainThread::hasDisallowedScope to avoid hitting this assertion.

Tests: TestWebKitAPI.QuickLook.LegacyQuickLookContent

  • dom/ContainerNodeAlgorithms.cpp:

(WebCore::notifyChildNodeInserted):
(WebCore::notifyChildNodeRemoved):

  • dom/Document.cpp:

(WebCore::Document::nodeChildrenWillBeRemoved):
(WebCore::Document::nodeWillBeRemoved):

  • dom/ScriptDisallowedScope.h:

(WebCore::ScriptDisallowedScope::InMainThread::hasDisallowedScope):

  • html/HTMLFormElement.cpp:

(WebCore:: const):

4:26 PM Changeset in webkit [239528] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Update status of some WebCore features in features.json
https://bugs.webkit.org/show_bug.cgi?id=192998

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-12-21
Reviewed by Tim Horton.

  • features.json:
  • Variation Fonts: Supported
  • Conic Gradients: Supported in Preview
  • Web Share: Supported in Preview
  • <datalist>: Supported in Preview
  • Intersection Observers: Supported in Preview
4:16 PM Changeset in webkit [239527] by Nikita Vasilyev
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: editing focus lost when inspector is blurred
https://bugs.webkit.org/show_bug.cgi?id=192123
<rdar://problem/46800966>

Reviewed by Devin Rousso.

  • UserInterface/Views/SpreadsheetSelectorField.js:

(WI.SpreadsheetSelectorField.prototype._handleBlur):

  • UserInterface/Views/SpreadsheetTextField.js:

(WI.SpreadsheetTextField.prototype._handleBlur):

4:02 PM Changeset in webkit [239526] by Alan Bujtas
  • 2 edits in trunk/Source/WebCore

[iOS] Using file upload can trigger a crash under RenderThemeIOS::paintFileUploadIconDecorations()
https://bugs.webkit.org/show_bug.cgi?id=192357
<rdar://problem/42852260>

Reviewed by Simon Fraser.

Do not try to paint the file picker when painting is disabled.

  • rendering/RenderFileUploadControl.cpp:

(WebCore::RenderFileUploadControl::paintObject):

3:49 PM Changeset in webkit [239525] by Joseph Pecoraro
  • 2 edits in trunk/Source/JavaScriptCore

Web Inspector: Crashes seen under Inspector::ScriptCallFrame::~ScriptCallFrame
https://bugs.webkit.org/show_bug.cgi?id=180373
<rdar://problem/33894170>

Rubber-stamped by Devin Rousso.

  • inspector/AsyncStackTrace.cpp:

(Inspector::AsyncStackTrace::truncate):
The lastUnlockedAncestor->remove() may release the only reference to it's
parent which we intend to use later but don't hold a RefPtr to. Keep the
parent alive explicitly by protecting it.

3:40 PM Changeset in webkit [239524] by achristensen@apple.com
  • 8 edits in trunk/Source

Expand use of sourceApplicationAuditData
https://bugs.webkit.org/show_bug.cgi?id=192995
<rdar://problem/46627875>

Reviewed by Brady Eidson.

Source/WebKit:

sourceApplicationAuditData has been used for a long time on iOS, but it's needed on more platforms.
I also made it return an Optional instead of a bool and returning by reference. Ahhh. So much nicer.

  • NetworkProcess/cocoa/NetworkProcessCocoa.mm:

(WebKit::NetworkProcess::sourceApplicationAuditData const):

  • Platform/IPC/Connection.h:
  • Platform/IPC/mac/ConnectionMac.mm:

(IPC::Connection::getAuditToken):

  • WebProcess/WebProcess.cpp:

(WebKit::WebProcess::initializeWebProcess):

  • WebProcess/cocoa/WebProcessCocoa.mm:

(WebKit::WebProcess::sourceApplicationAuditData const):

Source/WTF:

  • wtf/Platform.h:
3:27 PM Changeset in webkit [239523] by jiewen_tan@apple.com
  • 4 edits in trunk

[WebAuthN] userPresence should always be true
https://bugs.webkit.org/show_bug.cgi?id=192835
<rdar://problem/46538788>

Reviewed by Brent Fulgham.

Source/WebCore:

In the current spec as of 7 August 2018, userPresence is suggested to set to the inverse of userVerification.
This doesn't comply with the CTAP spec. Details in: https://github.com/w3c/webauthn/issues/1123.
After discussing with other members of the working group, we decided to make userPresence always default to true.

Covered by exisiting tests.

  • Modules/webauthn/fido/DeviceRequestConverter.cpp:

(fido::encodeGetAssertionRequestAsCBOR):

Tools:

  • TestWebKitAPI/Tests/WebCore/CtapRequestTest.cpp:

(TestWebKitAPI::TEST):

3:26 PM Changeset in webkit [239522] by Simon Fraser
  • 17 edits in trunk/Tools

Add support to run-benchmark to use non-default copies of the browser apps
https://bugs.webkit.org/show_bug.cgi?id=192905
rdar://problem/46845840

Reviewed by Dewei Zhu.

Add support for a --browser-path argument to run-benchmark, which allows you to use
a custom app bundle for a given browser (only implemented for Safari at present).

  • Scripts/webkitpy/benchmark_runner/benchmark_runner.py:

(BenchmarkRunner.init):

  • Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver.py:

(BrowserDriver.init):

  • Scripts/webkitpy/benchmark_runner/browser_driver/browser_driver_factory.py:

(BrowserDriverFactory.create):

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_browser_driver.py:

(OSXBrowserDriver._launch_process):
(OSXBrowserDriver._launch_process_with_caffeinate): Fix spelling.
(OSXBrowserDriver._launch_process_with_caffinate): Deleted.

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_chrome_driver.py:

(OSXChromeCanaryDriver.launch_url):

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_firefox_driver.py:

(OSXFirefoxNightlyDriver.launch_url):

  • Scripts/webkitpy/benchmark_runner/browser_driver/osx_safari_driver.py:

(OSXSafariDriver.init):
(OSXSafariDriver.launch_url):

  • Scripts/webkitpy/benchmark_runner/run_benchmark.py:

(parse_args):
(run_benchmark_plan):

  • Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:

(WebServerBenchmarkRunner.init):

  • Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:

(FakeBenchmarkRunner.init):

3:10 PM Changeset in webkit [239521] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Settings: experimental setting editors are misaligned in other locales
https://bugs.webkit.org/show_bug.cgi?id=192971
<rdar://problem/46718451>

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/SettingsTabContentView.css:

(.content-view.settings > .settings-view > .container):
(.content-view.settings > .settings-view > .container > .title):

3:06 PM Changeset in webkit [239520] by jiewen_tan@apple.com
  • 5 edits
    6 adds in trunk

[WebAuthN] Import an APDU coder from Chromium
https://bugs.webkit.org/show_bug.cgi?id=192949
<rdar://problem/46879933>

Reviewed by Brent Fulgham.

Source/WebCore:

This patch imports an APDU coder from Chromium. Here is the documentation:
https://fidoalliance.org/specs/fido-u2f-v1.2-ps-20170411/fido-u2f-raw-message-formats-v1.2-ps-20170411.html#u2f-message-framing
APDU is a binary format to frame any U2F requests/responses into binaries. It is equivalent to CBOR in CTAP2.

Here is a list of files that are imported from Chromium:
https://cs.chromium.org/chromium/src/components/apdu/apdu_command.cc?rcl=a2f290c10d132f53518e7f99d5635ee814ff8090
https://cs.chromium.org/chromium/src/components/apdu/apdu_command.h?rcl=867b103481f6f4ccc79a69bba16c11eefac3cdb6
https://cs.chromium.org/chromium/src/components/apdu/apdu_response.cc?rcl=867b103481f6f4ccc79a69bba16c11eefac3cdb6
https://cs.chromium.org/chromium/src/components/apdu/apdu_response.h?rcl=867b103481f6f4ccc79a69bba16c11eefac3cdb6
https://cs.chromium.org/chromium/src/components/apdu/apdu_unittest.cc?rcl=867b103481f6f4ccc79a69bba16c11eefac3cdb6

Covered by API tests.

  • Modules/webauthn/apdu/ApduCommand.cpp: Added.

(apdu::ApduCommand::createFromMessage):
(apdu::ApduCommand::ApduCommand):
(apdu::ApduCommand::getEncodedCommand const):

  • Modules/webauthn/apdu/ApduCommand.h: Added.
  • Modules/webauthn/apdu/ApduResponse.cpp: Added.

(apdu::ApduResponse::createFromMessage):
(apdu::ApduResponse::ApduResponse):
(apdu::ApduResponse::getEncodedResponse const):

  • Modules/webauthn/apdu/ApduResponse.h: Added.
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/Tests/WebCore/ApduTest.cpp: Added.

(TestWebKitAPI::TEST):

3:00 PM Changeset in webkit [239519] by jer.noble@apple.com
  • 6 edits in trunk/Source/WebCore

Convert raw CDMSessionMediaSourceAVFObjC pointer in MediaPlayerPrivateMediaSourceAVFObjC
https://bugs.webkit.org/show_bug.cgi?id=192985
<rdar://problem/46750743>

Reviewed by Eric Carlson.

Make m_session a RefPtr; drive-by fix: make m_mediaElement in WebKitMediaKeys a WeakPtr.

  • Modules/encryptedmedia/legacy/WebKitMediaKeys.cpp:

(WebCore::WebKitMediaKeys::setMediaElement):

  • Modules/encryptedmedia/legacy/WebKitMediaKeys.h:
  • platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::MediaPlayerPrivateMediaSourceAVFObjC):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setCDMSession):

2:39 PM Changeset in webkit [239518] by jiewen_tan@apple.com
  • 2 edits in trunk/Source/WebKit

[Mac] Layout Test http/wpt/webauthn/public-key-credential-create-success-hid.https.html and http/wpt/webauthn/public-key-credential-get-success-hid.https.html are flaky
https://bugs.webkit.org/show_bug.cgi?id=192061

Reviewed by Dewei Zhu.

Part 5.

Add some additional temporary logging info to determine if the time out value passed to the timer is respected.
Once the bug is determined and fixed, we should remove all logging added in this patch.

Reviewed by Dewei Zhu.

  • UIProcess/WebAuthentication/AuthenticatorManager.cpp:

(WebKit::AuthenticatorManager::initTimeOutTimer):
(WebKit::AuthenticatorManager::timeOutTimerFired):

2:27 PM Changeset in webkit [239517] by Devin Rousso
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: update scroll position when revealing a virtualized WI.DataGridNode
https://bugs.webkit.org/show_bug.cgi?id=192992
<rdar://problem/46886427>

Reviewed by Joseph Pecoraro.

When revealing a WI.DataGridNode, if it is not currently in the DOM tree (e.g. it's been
virtualized by it's owner WI.DataGrid), we need to scroll to it's position so that it gets
added to the DOM tree before it can be revealed/selected.

  • UserInterface/Views/DataGrid.js:

(WI.DataGrid.prototype.layout):
(WI.DataGrid.prototype.updateVisibleRows):
(WI.DataGrid.prototype._updateVisibleRows): Deleted.

  • UserInterface/Views/DataGridNode.js:

(WI.DataGridNode.prototype.reveal):

1:33 PM Changeset in webkit [239516] by justin_michaud@apple.com
  • 3 edits
    2 adds in trunk

CSS variables don't work for colors in "border" property
https://bugs.webkit.org/show_bug.cgi?id=192922

Reviewed by Simon Fraser.

Source/WebCore:

ParseColorFunction no longer consumes anything if the color was not valid.

Test: css-custom-properties-api/border-variable-parsing.html

  • css/parser/CSSPropertyParserHelpers.cpp:

(WebCore::CSSPropertyParserHelpers::parseColorFunction):

LayoutTests:

  • css-custom-properties-api/border-variable-parsing-expected.html: Added.
  • css-custom-properties-api/border-variable-parsing.html: Added.
12:46 PM Changeset in webkit [239515] by Justin Fan
  • 10 edits
    1 delete in trunk/Source/WebCore

[WebGPU] GPUBindGroupLayout refactoring: no HashMap, and failure logging
https://bugs.webkit.org/show_bug.cgi?id=192990

Reviewed by Myles C. Maxfield.

Refactor away the unnecessary HashMaps when creating MTLArgumentEncoders in GPUBindGroupLayout creation.
Also update GPUBindGroupLayout::create -> tryCreate, in order to better handle Objective-C exceptions.

No new tests; no change in behavior.

  • Modules/webgpu/WebGPUBindGroupLayout.cpp:

(WebCore::WebGPUBindGroupLayout::create):
(WebCore::WebGPUBindGroupLayout::WebGPUBindGroupLayout):

  • Modules/webgpu/WebGPUBindGroupLayout.h:

(WebCore::WebGPUBindGroupLayout::bindGroupLayout const):

  • Modules/webgpu/WebGPUDevice.cpp:

(WebCore::WebGPUDevice::createBindGroupLayout const):

  • platform/graphics/gpu/GPUBindGroupLayout.h:
  • platform/graphics/gpu/GPUDevice.cpp:

(WebCore::GPUDevice::tryCreateBindGroupLayout const): Renamed from ::create*. Now returning a RefPtr.
(WebCore::GPUDevice::createBindGroupLayout const): Deleted.

  • platform/graphics/gpu/GPUDevice.h:
  • platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm:

(WebCore::appendArgumentToArray):
(WebCore::newEncoder):
(WebCore::GPUBindGroupLayout::tryCreate): Renamed from ::create. Now returning a RefPtr.
(WebCore::GPUBindGroupLayout::GPUBindGroupLayout):
(WebCore::appendArgumentToArrayInMap): Deleted.
(WebCore::GPUBindGroupLayout::create): Deleted.

Deleted unneeded GPUBindGroupLayout.cpp:

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • platform/graphics/gpu/GPUBindGroupLayout.cpp: Removed.
12:25 PM Changeset in webkit [239514] by Keith Rollin
  • 2 edits in trunk/Source/WebKit

Crash in com.apple.WebKit: WebKit::WebResourceLoader::willSendRequest + 223
https://bugs.webkit.org/show_bug.cgi?id=192989

Reviewed by Chris Dumez.

willSendRequest is calling maybeLoadFallbackForRedirect, which can
delete “this”. After that, some new logging code tries to access
“this” and causes the crash. Fix this by adjusting the scope of a
"protectedThis".

  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::willSendRequest):

12:00 PM Changeset in webkit [239513] by commit-queue@webkit.org
  • 25 edits
    1 copy
    1 add in trunk/Source

[GTK][WPE] Add DeviceIdHashSaltStorage disk persistence
https://bugs.webkit.org/show_bug.cgi?id=190466

Patch by Alejandro G. Castro <alex@igalia.com> on 2018-12-21
Reviewed by Youenn Fablet.

Source/WebCore:

Added persistency to the DeviceIdHashSaltStorage.

  • platform/glib/FileSystemGlib.cpp:

(WebCore::FileSystem::getFileSize): Implemented this function to
allow sharing code with the statistics storage class.

  • platform/glib/KeyedDecoderGlib.cpp:

(WebCore::KeyedDecoderGlib::dictionaryFromGVariant): Added a
condition to control situations where the key is empty, it can
happen if the user modifies the file in the disk.

  • Modules/indexeddb/shared/IDBResourceIdentifier.cpp: Add include

to make work compilation with debug, unified builds.

Source/WebKit:

Added persistency to the DeviceIdHashSaltStorage. Implemented a
decoder and an encoder for the HashSaltForOrigin struct to store
it in a file, this allows us to save the lastTimeUsed, the origin
and the hash salt. It uses a new directory where it creates a file
per hash salt, the name of the file is the hash salt to avoid
leaking information in the system. The last time used and the
origin are stored inside the file, it also adds a version
directory used to change the structure of the file in the future,
if we need to do it. In the DeviceIdHashSaltStorage class the disk
operations happen in a WorkQueue, but all interactions go in the
main thread. We added code to handle the operations when the load
still did not finish.

  • Platform/Logging.h:

Added channel DiskPersistency..

  • Sources.txt: Added new files.
  • UIProcess/API/APIProcessPoolConfiguration.cpp: Added code to set

the directory for the deviceIdHashSalts. That way we can use the
configuration when creating the DeviceIdHashSaltStorage.
(API::ProcessPoolConfiguration::createWithWebsiteDataStoreConfiguration):
(API::ProcessPoolConfiguration::ProcessPoolConfiguration):
(API::ProcessPoolConfiguration::copy):

  • UIProcess/API/APIProcessPoolConfiguration.h:
  • UIProcess/API/APIWebsiteDataStore.cpp:

(API::WebsiteDataStore::legacyDefaultDataStoreConfiguration):
Added code to set the directory in the disk used to store the
information.

  • UIProcess/API/APIWebsiteDataStore.h: Ditto.
  • UIProcess/API/Cocoa/APIWebsiteDataStoreCocoa.mm: Added dummy

implementation to get the directory in cocoa.
(API::WebsiteDataStore::defaultDeviceIdHashSaltsStorageDirectory):
(API::WebsiteDataStore::legacyDefaultDeviceIdHashSaltsStorageDirectory):

  • UIProcess/API/glib/APIWebsiteDataStoreGLib.cpp: Defined the

default directories used to store the information in the disk.
(API::WebsiteDataStore::defaultDeviceIdHashSaltsStorageDirectory):
(API::WebsiteDataStore::legacyDefaultDeviceIdHashSaltsStorageDirectory):
(API::WebsiteDataStore::defaultDataStoreConfiguration):

  • UIProcess/API/glib/WebKitWebsiteDataManager.cpp:

(webkitWebsiteDataManagerGetDataStore): Added the directory used
to store the information.
(webkit_website_data_manager_remove): Modified the way we use to
make sure when we remove the cookies we also remove the hash salts.

  • UIProcess/API/win/APIWebsiteDataStoreWin.cpp: Added dummy

implementations to get the directory in windows platform.
(API::WebsiteDataStore::defaultDeviceIdHashSaltsStorageDirectory):
(API::WebsiteDataStore::legacyDefaultDeviceIdHashSaltsStorageDirectory):

  • UIProcess/API/C/WKBackForwardListItemRef.cpp: Add namespace, it

seems some unified build compilation issue.

  • UIProcess/DeviceIdHashSaltStorage.cpp:

(WebKit::DeviceIdHashSaltStorage::create): Added a create method
used to pass the directory and the persistency status of the websitedatastore.
(WebKit::DeviceIdHashSaltStorage::completeHandler): Added to share
the code copying the origins to complete the get handler.
(WebKit::DeviceIdHashSaltStorage::completeDeviceIdHashSaltForOriginCall):
Added to share the code when completing the task of getting a new
hash salt.
(WebKit::DeviceIdHashSaltStorage::DeviceIdHashSaltStorage): Added
a new constructor for the create method.
(WebKit::getSecurityOriginData): Added to get the
SecurityOriginData from a field in the decoder and do all the
checks.
(WebKit::DeviceIdHashSaltStorage::loadStorageFromDisk): Open the
directory and restore all the hash salts from disk to the memory
structure.
(WebKit::DeviceIdHashSaltStorage::createEncoderFromData const):
Creates the decoder to store the HashSaltForOrigin structure.
(WebKit::DeviceIdHashSaltStorage::storeHashSaltToDisk): Write to
disk a decoder object created from a HashSaltForOrigin
structure. It uses the writeEncoderToDisk function.
(WebKit::DeviceIdHashSaltStorage::deviceIdHashSaltForOrigin): Make
sure we store in disk a new hash salt when it is generated and the
WebsiteDataStore is persistent. Add a completionHandler to return
the value found or generated, this way we can control if the
HashMap is already loaded from disk.
(WebKit::DeviceIdHashSaltStorage::getDeviceIdHashSaltOrigins):
Make sure we run the get in a queue now that we store information
in disk.
(WebKit::DeviceIdHashSaltStorage::deleteHashSaltFromDiskIfNeeded):
Added code to make sure we remove the files in disk.
(WebKit::DeviceIdHashSaltStorage::deleteDeviceIdHashSaltForOrigins):
Added code to use the deleteHashSaltFromDiskIfNeeded and remove the files in disk.
(WebKit::DeviceIdHashSaltStorage::deleteDeviceIdHashSaltOriginsModifiedSince):
Added code to use the deleteHashSaltFromDiskIfNeeded and remove the files in disk.

  • UIProcess/DeviceIdHashSaltStorage.h: Ditto.
  • UIProcess/PersistencyUtils.cpp: Added file to share the

persistency code with the ResourceLoadStatisticsPersistentStorage class.
(WebKit::createDecoderForFile): Ditto.
(WebKit::writeEncoderToDisk): Ditto.

  • UIProcess/PersistencyUtils.h: Ditto.
  • UIProcess/ResourceLoadStatisticsPersistentStorage.cpp: Use the

new PersistencyUtils functions shared with the
DeviceIdHashSaltStorage class.
(WebKit::ResourceLoadStatisticsPersistentStorage::refreshMemoryStoreFromDisk):
(WebKit::ResourceLoadStatisticsPersistentStorage::populateMemoryStoreFromDisk):
(WebKit::ResourceLoadStatisticsPersistentStorage::writeMemoryStoreToDisk):

  • UIProcess/UserMediaPermissionRequestManagerProxy.cpp: After

changing the API of the deviceIdHashSaltForOrigin we now use a
completionHandler because it could happen the HashMap is not still
loaded and we would have to wait for it. We refactored the calls
to the method to use this new completionHandler.
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasGranted):
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
(WebKit::UserMediaPermissionRequestManagerProxy::enumerateMediaDevicesForFrame):

  • UIProcess/WebsiteData/WebsiteDataStore.cpp:

(WebKit::WebsiteDataStore::WebsiteDataStore): Create the
DeviceIdHashSaltStorage class with the persistency information.
(WebKit::WebsiteDataStore::resolveDirectoriesIfNecessary): Make
sure we have the directory to store the information.

  • UIProcess/WebsiteData/WebsiteDataStoreConfiguration.h: Add get

and set functions for the deviceHashSaltStorageDirectory.

  • WebKit.xcodeproj/project.pbxproj: Added PersistencyUtils file to

the xcode compilation.

11:57 AM Changeset in webkit [239512] by Alan Bujtas
  • 7 edits
    2 adds in trunk

Synchronous media query evaluation could destroy current Frame/FrameView.
https://bugs.webkit.org/show_bug.cgi?id=192781
<rdar://problem/34416793>

Reviewed by Chris Dumez.

Source/WebCore:

Protect Frame and FrameView when coming back from printing and check if the current Frame/FrameView/FrameLoader objects are still valid.

Test: printing/print-with-media-query-destory.html

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::finishedLoading):

  • page/Frame.cpp:

(WebCore::Frame::setPrinting):

  • page/FrameView.cpp:

(WebCore::FrameView::forceLayoutForPagination):

  • page/PrintContext.cpp:

(WebCore::PrintContext::PrintContext):
(WebCore::PrintContext::computePageRects):
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
(WebCore::PrintContext::begin):
(WebCore::PrintContext::computeAutomaticScaleFactor):
(WebCore::PrintContext::spoolPage):
(WebCore::PrintContext::spoolRect):
(WebCore::PrintContext::end):

  • page/PrintContext.h:

(WebCore::PrintContext::frame const): Deleted.

LayoutTests:

  • printing/print-with-media-query-destory-expected.txt: Added.
  • printing/print-with-media-query-destory.html: Added.
11:40 AM Changeset in webkit [239511] by wenson_hsieh@apple.com
  • 4 edits in trunk

Setting the file wrapper and content type of an attachment to a PDF should update its image
https://bugs.webkit.org/show_bug.cgi?id=192984
<rdar://problem/46798028>

Reviewed by Tim Horton.

Source/WebCore:

Allow PDF data to be used to update enclosing image elements when setting the file wrapper for an attachment.
Covered by a new API test: WKAttachmentTests.SetFileWrapperForPDFImageAttachment.

  • html/HTMLAttachmentElement.cpp:

(WebCore::mimeTypeIsSuitableForInlineImageAttachment):
(WebCore::HTMLAttachmentElement::updateEnclosingImageWithData):

Tools:

Add an API test to verify that setting the file wrapper for a _WKAttachment with an enclosing image element with
PDF data correctly updates the image element.

  • TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
11:37 AM Changeset in webkit [239510] by youenn@apple.com
  • 163 edits
    6 copies
    38 adds
    6 deletes in trunk/Source/ThirdParty/libwebrtc

Resync opus to M72
https://bugs.webkit.org/show_bug.cgi?id=192867

Reviewed by Alex Christensen.

  • Configurations/opus.xcconfig: Updated compilation flag.
  • Source/third_party/opus: Resynced to Chrome M72 branch.
11:28 AM Changeset in webkit [239509] by youenn@apple.com
  • 66 edits
    1 copy
    1 add
    7 deletes in trunk/Source/ThirdParty/libwebrtc

Resync libsrtp to M72
https://bugs.webkit.org/show_bug.cgi?id=192861

Reviewed by Eric Carlson.

  • Source/third_party/libsrtp/: Resynced to Chrome M72 branch.
11:22 AM Changeset in webkit [239508] by youenn@apple.com
  • 2 edits in trunk/Source/ThirdParty/libwebrtc

Use kVTCompressionPropertyKey_Usage instead of kVTVideoEncoderSpecification_Usage
https://bugs.webkit.org/show_bug.cgi?id=192885

Reviewed by Eric Carlson.

When VCP is enabled, use kVTCompressionPropertyKey_Usage as this is
kVTVideoEncoderSpecification_Usage no longer works to activate VCP on iOS.
Tested manually.

  • Source/webrtc/sdk/objc/components/video_codec/RTCVideoEncoderH264.mm:

(-[RTCSingleVideoEncoderH264 resetCompressionSessionWithPixelFormat:]):
(-[RTCSingleVideoEncoderH264 configureCompressionSession]):

9:57 AM Changeset in webkit [239507] by Michael Catanzaro
  • 5 edits
    2 adds in trunk/Tools

Add JSCOnly to bot dashboard
https://bugs.webkit.org/show_bug.cgi?id=192964

Reviewed by Alexey Proskuryakov.

Apparently we have five JSCOnly test bots and multiple developers working on keeping them in
good shape. Sadly, they are hidden bots not exposed in the dashboard. They would be more
useful if they were not so secret, so add them.

There appear to be no build-only bots, so the first column is blank. And of course there are
no WebKit1 or WebKit2 bots, because this is JSCOnly, so the second and third columns are
blank too. That's OK. This will be the last bot on the dashboard, so it won't look too bad,
and there's plenty of room in the final column for all the bots.

I had a hard time picking a logo to use, because the JavaScript language does not have an
official logo. But I believe I've found one that will be satisfactory.

I will sneak in one bonus change: WPE's EWS queue was missing, and has been added.

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Images/SquirrelFish@2x.png: Added.
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BubbleQueueServer.js:

(BubbleQueueServer):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Dashboard.js:
  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:

(WebKitBuildbot):

  • BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:

(table.queue-grid tr.platform.linux-jsconly img.logo):

9:52 AM Changeset in webkit [239506] by achristensen@apple.com
  • 5 edits in trunk

Revert r239503.
https://bugs.webkit.org/show_bug.cgi?id=192944

Source/WTF:

  • wtf/cocoa/NSURLExtras.mm:

(WTF::isLookalikeCharacter):

LayoutTests:

  • fast/url/host-expected.txt:
  • fast/url/host.html:
9:40 AM Changeset in webkit [239505] by Truitt Savell
  • 2 edits in trunk/LayoutTests

Skipping webgpu/ tests after https://trac.webkit.org/changeset/239495/webkit disabled webgpu on 10.12
https://bugs.webkit.org/show_bug.cgi?id=192956

Unreviewed Test Gardening.

  • platform/mac/TestExpectations:
9:33 AM Changeset in webkit [239504] by justin_michaud@apple.com
  • 5 edits
    2 adds in trunk

Repeated background images with zero size should display the background color
https://bugs.webkit.org/show_bug.cgi?id=192962

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/backgrounds/background-repeat-with-zero-size.html

  • platform/LengthSize.h:

(WebCore::LengthSize::isEmpty const):

  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::paintFillLayerExtended):

  • rendering/style/FillLayer.h:

(WebCore::FillLayer::isEmpty const):

LayoutTests:

Fix a rendering bug exposed by the CSS Variable wpt tests where repeated backgrounds with zero size
not draw the background colour underneath.

  • fast/backgrounds/background-repeat-with-zero-size-expected.html: Added.
  • fast/backgrounds/background-repeat-with-zero-size.html: Added.
8:20 AM Changeset in webkit [239503] by Brent Fulgham
  • 5 edits in trunk

Show punycode if URL contains Latin small letter dotless i
https://bugs.webkit.org/show_bug.cgi?id=192944
<rdar://problem/46103047>

Reviewed by Andy Estes.

Source/WTF:

Revise our "lookalike character" logic to include the small Latin
dotless i character.

Test: fast/url/host.html

  • wtf/cocoa/NSURLExtras.mm:

(WTF::isLookalikeCharacter):

LayoutTests:

  • fast/url/host-expected.txt:
  • fast/url/host.html:
4:29 AM Changeset in webkit [239502] by Manuel Rego Casasnovas
  • 7 edits in trunk

[css-grid] Fix percentages in relative offsets for grid items
https://bugs.webkit.org/show_bug.cgi?id=190492

Reviewed by Sergio Villar Senin.

LayoutTests/imported/w3c:

  • web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-002-expected.txt: Update expected file as we're now passing this test.

Source/WebCore:

The method RenderBoxModelObject::relativePositionOffset() was not considering the case of grid items,
where the containing block is the grid area.
The patch modifies the method so the new code uses overrideContainingBlockContentWidth|Height when required.

Test: imported/w3c/web-platform-tests/css/css-grid/grid-items/grid-items-relative-offsets-002.html

  • rendering/RenderBox.cpp: Implement the physical versions of the already existent methods.

(WebCore::RenderBox::overrideContainingBlockContentWidth const):
(WebCore::RenderBox::overrideContainingBlockContentHeight const):
(WebCore::RenderBox::hasOverrideContainingBlockContentWidth const):
(WebCore::RenderBox::hasOverrideContainingBlockContentHeight const):

  • rendering/RenderBox.h:
  • rendering/RenderBoxModelObject.cpp:

(WebCore::RenderBoxModelObject::relativePositionOffset const): Modified method
to take into account overrideContainingBlockContentWidth|Height for grid items.

  • rendering/RenderBoxModelObject.h: Added new headers for physical virtual methods

that will be overridden in RenderBox.
(WebCore::RenderBoxModelObject::overrideContainingBlockContentWidth const):
(WebCore::RenderBoxModelObject::overrideContainingBlockContentHeight const):
(WebCore::RenderBoxModelObject::hasOverrideContainingBlockContentWidth const):
(WebCore::RenderBoxModelObject::hasOverrideContainingBlockContentHeight const):

3:47 AM Changeset in webkit [239501] by Carlos Garcia Campos
  • 1 edit
    7 deletes in trunk/LayoutTests

Unreviewed GTK+ gardening. Remove platform specific files that are exactly the same as the generic expectation.

  • platform/gtk/fast/text/selection-in-initial-advance-region-expected.txt: Removed.
  • platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt: Removed.
  • platform/gtk/legacy-animation-engine/animations/lineheight-animation-expected.txt: Removed.
  • platform/gtk/legacy-animation-engine/animations/simultaneous-start-transform-expected.txt: Removed.
  • platform/gtk/legacy-animation-engine/animations/width-using-ems-expected.txt: Removed.
  • platform/gtk/security/block-test-expected.txt: Removed.
  • platform/gtk/webaudio/codec-tests/wav/24bit-22khz-resample-expected.wav: Removed.
3:44 AM Changeset in webkit [239500] by Carlos Garcia Campos
  • 9 edits
    9 adds in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline several tests.

  • platform/gtk/css2.1/t051201-c23-first-line-00-b-expected.png:
  • platform/gtk/css2.1/t051201-c23-first-line-00-b-expected.txt:
  • platform/gtk/css2.1/t1508-c527-font-04-b-expected.png:
  • platform/gtk/css2.1/t1508-c527-font-04-b-expected.txt:
  • platform/gtk/css2.1/t1508-c527-font-05-b-expected.png:
  • platform/gtk/css2.1/t1508-c527-font-05-b-expected.txt:
  • platform/gtk/css2.1/t1508-c527-font-07-b-expected.png:
  • platform/gtk/css2.1/t1508-c527-font-07-b-expected.txt:
  • platform/gtk/fast/css/getComputedStyle/computed-style-expected.txt: Added.
  • platform/gtk/fast/css/getComputedStyle/computed-style-font-family-expected.txt: Added.
  • platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt: Added.
  • platform/gtk/fast/text/font-selection-font-loading-api-parse-expected.txt: Added.
  • platform/gtk/fast/text/font-stretch-parse-expected.txt: Added.
  • platform/gtk/fast/text/font-style-parse-expected.txt: Added.
  • platform/gtk/fast/text/font-weight-parse-expected.txt: Added.
  • platform/gtk/svg/css/getComputedStyle-basic-expected.txt: Added.
2:53 AM Changeset in webkit [239499] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebDriver

[GLIB] WebDriver: dbusConnectionClosedCallback can be called after SessionHost has been deleted
https://bugs.webkit.org/show_bug.cgi?id=192976

Reviewed by Alejandro G. Castro.

Disconnect DBus connection signals using SessionHost as user data in SessionHost destructor.

  • glib/SessionHostGlib.cpp:

(WebDriver::SessionHost::~SessionHost):

2:34 AM Changeset in webkit [239498] by Carlos Garcia Campos
  • 2 edits in trunk/WebDriverTests

Unreviewed gardening. Skip imported/w3c/webdriver/tests/permissions/set.py.

Permissions command is not implemented yet.

2:28 AM Changeset in webkit [239497] by Carlos Garcia Campos
  • 2 edits
    3 deletes in trunk/WebDriverTests

Unreviewed. WebDriver: remove deleted tests after r238881.

Deleted files were not removed from the repository in r238881. Also update the test names in the test
expectations file.

  • TestExpectations.json:
  • imported/w3c/webdriver/tests/actions/init.py: Removed.
  • imported/w3c/webdriver/tests/actions/conftest.py: Removed.
  • imported/w3c/webdriver/tests/actions/control_click.py: Removed.
  • imported/w3c/webdriver/tests/actions/key.py: Removed.
  • imported/w3c/webdriver/tests/actions/key_shortcuts.py: Removed.
  • imported/w3c/webdriver/tests/actions/modifier_click.py: Removed.
  • imported/w3c/webdriver/tests/actions/mouse.py: Removed.
  • imported/w3c/webdriver/tests/actions/mouse_dblclick.py: Removed.
  • imported/w3c/webdriver/tests/actions/mouse_pause_dblclick.py: Removed.
  • imported/w3c/webdriver/tests/actions/pointer_origin.py: Removed.
  • imported/w3c/webdriver/tests/actions/sequence.py: Removed.
  • imported/w3c/webdriver/tests/actions/special_keys.py: Removed.
  • imported/w3c/webdriver/tests/actions/support/init.py: Removed.
  • imported/w3c/webdriver/tests/actions/support/keys.py: Removed.
  • imported/w3c/webdriver/tests/actions/support/mouse.py: Removed.
  • imported/w3c/webdriver/tests/actions/support/refine.py: Removed.
  • imported/w3c/webdriver/tests/actions/support/test_actions_wdspec.html: Removed.
  • imported/w3c/webdriver/tests/page_source/init.py: Removed.
  • imported/w3c/webdriver/tests/page_source/source.py: Removed.
  • imported/w3c/webdriver/tests/support/wait.py: Removed.
12:37 AM Changeset in webkit [239496] by benjamin@webkit.org
  • 8 edits in trunk

<rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
https://bugs.webkit.org/show_bug.cgi?id=192821

Reviewed by Chris Dumez.

Source/WebKitLegacy/mac:

When a window becomes occluded, the window server informs the application.
This should be used to suspend any work that is not visible by the user.

WebKit2 handles it just fine, but WebKit1 did not handle the notification.
In some cases, that lead to performance impact (see radar).

This patch adds an observer for the occlusion notification. I tried to stick
with the same names used by WebKit2.

  • WebView/WebView.mm:

(-[WebView _isViewVisible]):
(-[WebView addWindowObserversForWindow:]):
(-[WebView removeWindowObservers]):
(-[WebView _windowDidChangeOcclusionState:]):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):

  • TestWebKitAPI/mac/WebKitAgnosticTest.mm:

Dec 20, 2018:

7:04 PM Changeset in webkit [239495] by Justin Fan
  • 12 edits
    1 add in trunk

[WebGPU] Convert WebGPUBindGroups into MTLArgumentEncoders
https://bugs.webkit.org/show_bug.cgi?id=192956

Reviewed by Myles Maxfield.

No testable behavior change. Existing tests cover possible crashing.

Add GPUBindGroupLayoutMetal.mm:

  • SourcesCocoa.txt:
  • WebCore.xcodeproj/project.pbxproj:

Flesh out GPUBindGroupLayout::create:

  • platform/graphics/gpu/GPUBindGroupLayout.cpp:
  • platform/graphics/gpu/GPUBindGroupLayout.h:
  • platform/graphics/gpu/GPUDevice.cpp:

(WebCore::GPUDevice::createBindGroupLayout const):

  • platform/graphics/gpu/cocoa/GPUBindGroupLayoutMetal.mm: Added.

(WebCore::appendArgumentToArrayInMap): Added.
(WebCore::GPUBindGroupLayout::create):
(WebCore::GPUBindGroupLayout::GPUBindGroupLayout):
(WebCore::MTLDataTypeForBindingType): Added.

6:57 PM Changeset in webkit [239494] by Kocsen Chung
  • 7 edits in branches/safari-606.4.5.0-branch/Source

Versioning.

6:46 PM Changeset in webkit [239493] by Kocsen Chung
  • 1 copy in branches/safari-606.4.5.0-branch

New branch.

6:46 PM Changeset in webkit [239492] by Kocsen Chung
  • 7 edits in branches/safari-606.4.5.1-branch/Source

Versioning.

6:33 PM Changeset in webkit [239491] by Kocsen Chung
  • 1 copy in branches/safari-606.4.5.1-branch

New branch.

6:31 PM Changeset in webkit [239490] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore

Unreviewed, remove stray #pragma once added to .cpp file

  • svg/properties/SVGAttributeOwnerProxy.cpp:
6:29 PM Changeset in webkit [239489] by Michael Catanzaro
  • 3 edits
    2 adds in releases/WebKitGTK/webkit-2.22

Merge r239392 - JSPropertyNameEnumerator should cache the iterated object's structure only after getting its property names.
https://bugs.webkit.org/show_bug.cgi?id=192464
<rdar://problem/46519455>

Reviewed by Saam Barati.

JSTests:

This patch is about a 10% speed up on the new for-in-on-object-with-lazily-materialized-properties.js
microbenchmark.

  • microbenchmarks/for-in-on-object-with-lazily-materialized-properties.js: Added.
  • stress/property-name-enumerator-should-cache-structure-after-getting-property-names.js: Added.

Source/JavaScriptCore:

This is because the process of getting its property names may cause some lazy
properties to be reified, and the structure will change. This is needed in order
for get_direct_pname to work correctly.

  • runtime/JSPropertyNameEnumerator.h:

(JSC::propertyNameEnumerator):

6:24 PM Changeset in webkit [239488] by Michael Catanzaro
  • 12 edits
    2 copies
    2 adds in releases/WebKitGTK/webkit-2.22

Merge r239070 - SVGViewSpec objects should mark relevant SVG elements
https://bugs.webkit.org/show_bug.cgi?id=192567
<rdar://problem/46491325>

Reviewed by Ryosuke Niwa.

Source/WebCore:

SVGViewSpec elements reflect the state of an underlying SVGElement. Teach the mark algorithm to
recognize the relevant SVGElement as active as long as the SVGViewSpec is active.

Update SVGElement so that it can vend WeakPtrs. I also noticed that SVGAttributeOwner used a bare
pointer to the SVGElement, so switched to a WeakPtr.

Test: svg/animations/view-dependency-crash.html

  • Sources.txt: Add new files.
  • WebCore.xcodeproj/project.pbxproj: Ditto.
  • bindings/js/JSSVGViewSpecCustom.cpp: Added.

(WebCore::JSSVGViewSpec::visitAdditionalChildren):

  • svg/SVGElement.h:
  • svg/SVGPathElement.h:
  • svg/SVGViewSpec.cpp:

(WebCore::SVGViewSpec::SVGViewSpec): Hold a weak pointer (rather than a bare pointer) to the underlying element.

  • svg/SVGViewSpec.h:
  • svg/SVGViewSpec.idl:
  • svg/properties/SVGAttributeOwnerProxy.cpp: Added.

(WebCore::SVGAttributeOwnerProxy::SVGAttributeOwnerProxy): Hold a weak pointer (rather than a bare pointer) to
the underling SVGElement.
(WebCore::SVGAttributeOwnerProxy::element const): Ditto.

  • svg/properties/SVGAttributeOwnerProxy.h:

(WebCore::SVGAttributeOwnerProxy::SVGAttributeOwnerProxy): Move implementation to cpp file.
(WebCore::SVGAttributeOwnerProxy::element const): Ditto.

  • svg/properties/SVGAttributeOwnerProxyImpl.h: Update for WeakPtr use.

LayoutTests:

  • svg/animations/view-dependency-crash-expected.txt: Added.
  • svg/animations/view-dependency-crash.html: Added.
6:21 PM Changeset in webkit [239487] by Fujii Hironori
  • 10 edits in trunk/Tools

[Win][Clang] Fix compilation warnings of DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=192924

Reviewed by Alex Christensen.

  • DumpRenderTree/AccessibilityController.h: Added member variable initializations in the class definition.
  • DumpRenderTree/win/AccessibilityControllerWin.cpp:

(AccessibilityController::AccessibilityController): Moved member variable initializations to the class definition.

  • DumpRenderTree/win/DumpRenderTree.cpp:

(dumpHistoryItem): String literals can't be converted non-const type. Use auto for them.
(resetWebPreferencesToConsistentValues): Pass a temporal _bstr_t
object to the argument of setDefaultTextEncodingName instead of a
const string literal.
(createWebViewAndOffscreenWindow): Use %lx for HRESULT (aka 'long').
(main): Exit if _dup2 fails. Use %lu for'DWORD'(aka 'unsigned long').
(setCacheFolder): Deleted.

  • DumpRenderTree/win/DumpRenderTreeWin.h: Fix class/struct mismatch of FrameLoadDelegate and PolicyDelegate declarations.
  • DumpRenderTree/win/EditingDelegate.cpp:

(dump): Use %d for int.

  • DumpRenderTree/win/FrameLoadDelegate.cpp: Removed unused variable g_delegateWaitingOnTimer.
  • DumpRenderTree/win/ResourceLoadDelegate.cpp:

(BSTRFromString): Deleted unused function.

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::setDatabaseQuota): Pass a temporal _bstr_t object to
the arguemnt of setQuota instead of const string literal.

  • DumpRenderTree/win/WorkQueueItemWin.cpp:

(jsStringRefToWString): Deleted unused function.

6:17 PM Changeset in webkit [239486] by achristensen@apple.com
  • 5 edits in trunk/Source/WebKit

Remove unused NetworkProcessCreationParameters
https://bugs.webkit.org/show_bug.cgi?id=192961

Reviewed by Andy Estes.

loadThrottleLatency isn't used since I replaced it with NetworkSessionCreationParameters.loadThrottleLatency in r238654
presentingApplicationPID has no effect because that value is only used in the WebProcess in NetworkExtensionContentFilter::initialize

  • NetworkProcess/NetworkProcess.cpp:

(WebKit::NetworkProcess::initializeNetworkProcess):

  • NetworkProcess/NetworkProcessCreationParameters.cpp:

(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):

  • NetworkProcess/NetworkProcessCreationParameters.h:
  • UIProcess/WebProcessPool.cpp:

(WebKit::WebProcessPool::ensureNetworkProcess):

6:05 PM Changeset in webkit [239485] by Dewei Zhu
  • 12 edits
    1 add in trunk/Websites/perf.webkit.org

Extend commits table to contain testability information.
https://bugs.webkit.org/show_bug.cgi?id=191557

Reviewed by Ryosuke Niwa.

Added the ability to store testability message in commits table.
Refactored '/api/report-commits' to support update commit only.
Updated os version syncing script to be able to update testability information.

  • init-database.sql: Added 'commit_testability' field to 'commits' table.
  • public/api/report-commits.php: Refactor this api to allow only update existing commits.
  • public/include/commit-log-fetcher.php: Expose testability warning information in this API.
  • public/include/commit-updater.php: Added 'CommitUpdater' to manage commit insert and update.
  • public/v3/models/commit-log.js: CommitLog object should expose testability warning information.

(CommitLog.prototype.updateSingleton):
(CommitLog.prototype.testability):

  • public/v3/models/commit-set.js: Added 'commitsWithTestability' and 'commits' to CommitSet and

IntermediateCommitSet instances.
(CommitSet.prototype.commitsWithTestability):
(CommitSet.prototype.commits):
(IntermediateCommitSet.prototype.commitsWithTestability):
(IntermediateCommitSet.prototype.commits):

  • server-tests/api-report-commits-tests.js: Added unit tests for '/api/report-commits' when insert=false.
  • server-tests/tools-os-build-fetcher-tests.js: Added and updated unit tests.
  • tools/js/os-build-fetcher.js: Added the ability to update commit testability warnings.

(async.fetchReportAndUpdateCommits):
(prototype.async.fetchReportAndUpdateBuilds):
(prototype.async._fetchAvailableBuilds):
(prototype.async._commitsForAvailableBuilds):
(prototype._commitsWithinRange):
(prototype.async._reportCommits):
(fetchAndReportAllInOrder): Deleted.
(prototype.fetchAndReportNewBuilds): Deleted.
(prototype._fetchAvailableBuilds): Deleted.
(prototype._commitsForAvailableBuilds): Deleted.
(prototype._submitCommits): Deleted.

  • tools/sync-os-versions.js:
  • unit-tests/commit-log-tests.js: Added a unit test for 'testability'.
  • unit-tests/commit-set-tests.js: Added unit tests for 'commitsWithTestability'.
5:44 PM Changeset in webkit [239484] by Nikita Vasilyev
  • 5 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: Type profiler popovers have black text on dark background
https://bugs.webkit.org/show_bug.cgi?id=192916
<rdar://problem/46863518>

Reviewed by Devin Rousso.

  • UserInterface/Views/SourceCodeTextEditor.css:

(.popover .debugger-popover-content > .body):

  • UserInterface/Views/TypeTreeElement.css:

(.item.type-tree-element.prototype):
(.item.type-tree-element.prototype:hover,):

  • UserInterface/Views/TypeTreeView.css:

(.type-tree):

  • UserInterface/Views/Variables.css:

(:root):

5:33 PM Changeset in webkit [239483] by justin_michaud@apple.com
  • 6 edits in trunk/Source/WebCore

Adding runtime-enabled attribute to Element prevents inlining property access
https://bugs.webkit.org/show_bug.cgi?id=192901

Add a call to flattenDictionaryObject after disabling runtime-enabled attributes.

Reviewed by Ryosuke Niwa.

  • bindings/scripts/CodeGeneratorJS.pm:

(GenerateImplementation):

  • bindings/scripts/test/JS/JSTestEnabledBySetting.cpp:

(WebCore::JSTestEnabledBySettingPrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestGenerateIsReachable.cpp:

(WebCore::JSTestGenerateIsReachablePrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestNode.cpp:

(WebCore::JSTestNodePrototype::finishCreation):

  • bindings/scripts/test/JS/JSTestObj.cpp:

(WebCore::JSTestObjPrototype::finishCreation):

5:32 PM Changeset in webkit [239482] by wenson_hsieh@apple.com
  • 4 edits in trunk/LayoutTests

[iOS] Some layout tests are failing after r239441
https://bugs.webkit.org/show_bug.cgi?id=192957
<rdar://problem/46781759>

Reviewed by Simon Fraser.

Fix several failing layout tests after r239441.

  • fast/events/ios/click-event-while-editing-node.html:

This test started failing after r239441 because it taps the bottom of the editable element, and then expects
WebKit to scroll the web view up to reveal the touched location. This was exactly the bug that r239441 fixed, so
we should just make this test no longer depend on the broken behavior.

  • fast/forms/ios/focus-long-textarea-expected.txt:
  • fast/forms/ios/zoom-after-input-tap-wide-input-expected.txt:

Rebaseline a couple of test expectations to account for the change in margin around the selection rect, in
-[WKWebView _zoomToFocusRect:…:].

5:29 PM Changeset in webkit [239481] by Nikita Vasilyev
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: Pressing Esc when editing name/value should select entire property
https://bugs.webkit.org/show_bug.cgi?id=192919

Reviewed by Devin Rousso.

  • Esc still hides the completion popover.
  • Esc still discards changes.
  • When there's no completion popover, Esc selects outer scope. I.e., it goes from editing name/value to selecting the entire property.
  • Pressing Esc for newly added properties discards those properties.
  • UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:

(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyRemoved):
(WI.SpreadsheetCSSStyleDeclarationEditor.prototype.spreadsheetStylePropertyDidPressEsc):

  • UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype.spreadsheetTextFieldDidPressEsc):

  • UserInterface/Views/SpreadsheetTextField.js:

(WI.SpreadsheetTextField.prototype._discardChange):
(WI.SpreadsheetTextField.prototype._handleKeyDown):

5:25 PM Changeset in webkit [239480] by Chris Dumez
  • 2 edits in trunk/Tools

Add API test coverage for customUserAgent client setting and service workers
https://bugs.webkit.org/show_bug.cgi?id=192952

Reviewed by Alex Christensen.

  • TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm:

(-[SWMessageHandler userContentController:didReceiveScriptMessage:]):
(-[SWSchemes webView:startURLSchemeTask:]):
(-[SWCustomUserAgentDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
(-[SWUserAgentMessageHandler userContentController:didReceiveScriptMessage:]):

5:15 PM Changeset in webkit [239479] by Alan Coon
  • 2 edits in branches/safari-606-branch/Source/WebKit

Apply patch. rdar://problem/46881088

4:58 PM Changeset in webkit [239478] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Charles Proxy errors opening har files exported from Safari (invalid startedDateTime)
https://bugs.webkit.org/show_bug.cgi?id=192959
<rdar://problem/46863411>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-12-20
Reviewed by Brian Burg.

  • UserInterface/Views/NetworkTableContentView.js:

(WI.NetworkTableContentView.prototype.tableCellContextMenuClicked):
(WI.NetworkTableContentView.prototype._updateExportButton):
(WI.NetworkTableContentView.prototype._canExportHAR):
Disallow HAR export if we don't have load data, such as the requestSentDate for
the main resource or sub-resources.

(WI.NetworkTableContentView.prototype._HARResources):
Only export resources that have load data.

4:40 PM Changeset in webkit [239477] by Chris Dumez
  • 23 edits in trunk

Use Optional::hasValue() instead of Optional::has_value()
https://bugs.webkit.org/show_bug.cgi?id=192948

Reviewed by Tim Horton.

Source/JavaScriptCore:

  • inspector/scripts/codegen/generate_cpp_backend_dispatcher_implementation.py:

(CppBackendDispatcherImplementationGenerator._generate_async_dispatcher_class_for_domain):
(CppBackendDispatcherImplementationGenerator._generate_dispatcher_implementation_for_command):

Source/WebCore:

  • bindings/js/DOMPromiseProxy.h:

(WebCore::DOMPromiseProxy<IDLType>::isFulfilled const):
(WebCore::DOMPromiseProxy<IDLVoid>::isFulfilled const):
(WebCore::DOMPromiseProxyWithResolveCallback<IDLType>::isFulfilled const):

  • dom/DataTransferItemList.h:

(WebCore::DataTransferItemList::hasItems const):

  • dom/EventTarget.cpp:

(WebCore::EventTarget::addEventListener):

  • html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::captionDisplayMode):

  • platform/graphics/MediaPlayer.cpp:

(WebCore::MediaPlayer::wouldTaintOrigin const):

  • platform/graphics/gstreamer/mse/AppendPipeline.cpp:

(WebCore::AppendPipeline::parseDemuxerSrcPadCaps):

  • platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:

(WebCore::MediaPlayerPrivateGStreamerMSE::trackDetected):

  • platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:

(webKitMediaSrcUpdatePresentationSize):

  • platform/mac/NSScrollerImpDetails.mm:

(WebCore::ScrollerStyle::recommendedScrollerStyle):

  • rendering/RenderListItem.cpp:

(WebCore::RenderListItem::setExplicitValue):

Source/WebKit:

  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::AutomationCommandError::toProtocolString):
(WebKit::WebAutomationSession::willClosePage):

  • WebProcess/Automation/WebAutomationSessionProxy.cpp:

(WebKit::WebAutomationSessionProxy::computeElementLayout):

Source/WTF:

  • wtf/Hasher.h:

(WTF::add):

  • wtf/Optional.h:

Tools:

  • TestWebKitAPI/Tests/WebCore/CBORReaderTest.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebCore/CBORWriterTest.cpp:

(TestWebKitAPI::TEST):

  • TestWebKitAPI/Tests/WebCore/FileSystem.cpp:

(TestWebKitAPI::TEST_F):

4:38 PM Changeset in webkit [239476] by Chris Dumez
  • 3 edits in trunk/Tools

Add style script rule to check for uses of std::optional<>
https://bugs.webkit.org/show_bug.cgi?id=192931

Reviewed by Tim Horton.

  • Scripts/webkitpy/style/checkers/cpp.py:

(check_wtf_optional):
(check_style):

4:27 PM Changeset in webkit [239475] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit

Flicker when exiting element fullscreen.
https://bugs.webkit.org/show_bug.cgi?id=192774
rdar://problem/33088878

Patch by Jeremy Jones <jeremyj@apple.com> on 2018-12-20
Reviewed by Jer Noble.

Fixes an issue where the web page would flicker upon exiting element fullscreen.

Replace WebView with a snapshot while the WebView is restyled and resized for inline.

  • UIProcess/mac/WKFullScreenWindowController.h:
  • UIProcess/mac/WKFullScreenWindowController.mm:

(-[WKFullScreenWindowController initWithWindow:webView:page:]):
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
(-[WKFullScreenWindowController completeFinishExitFullScreenAnimationAfterRepaint]):

4:20 PM Changeset in webkit [239474] by Chris Dumez
  • 16 edits
    2 adds in trunk/Source

Move HTTPS_UPGRADE code behind a runtime flag, off by default
https://bugs.webkit.org/show_bug.cgi?id=192937

Reviewed by Youenn Fablet.

Move HTTPS_UPGRADE code behind a runtime flag, off by default and drop the build time flag.

Source/WebCore:

  • page/Settings.yaml:

Source/WebKit:

  • Configurations/WebKit.xcconfig:
  • DerivedSources.make:
  • NetworkProcess/NetworkHTTPSUpgradeChecker.cpp:
  • NetworkProcess/NetworkHTTPSUpgradeChecker.h:
  • NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::NetworkLoadChecker):
(WebKit::NetworkLoadChecker::applyHTTPSUpgradeIfNeeded const):
(WebKit::NetworkLoadChecker::checkRequest):

  • NetworkProcess/NetworkLoadChecker.h:
  • NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::networkHTTPSUpgradeChecker):

  • NetworkProcess/NetworkResourceLoadParameters.cpp:

(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):

  • NetworkProcess/NetworkResourceLoadParameters.h:
  • NetworkProcess/NetworkResourceLoader.cpp:
  • NetworkProcess/PingLoad.cpp:

(WebKit::PingLoad::PingLoad):

  • Shared/WebPreferences.yaml:
  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):

  • config.h:
4:17 PM Changeset in webkit [239473] by Kocsen Chung
  • 7 edits in branches/safari-606-branch/Source

Versioning.

4:03 PM Changeset in webkit [239472] by youenn@apple.com
  • 20 edits
    2 deletes in trunk/Source/WebCore

Remove custom constructors of ReadableStreamDefaultReader and ReadableStreamBYOBReader
https://bugs.webkit.org/show_bug.cgi?id=192838

Reviewed by Chris Dumez.

Generate constructor code in case of a Private but not Public constructor.
Make sure this is correctly exposed in global objects.
Add JS built-in constructor implementations for those two objects.

Also add JS built-in constructors for controller and byob request.
To keep existing behavior, JS built-ins calling these constructors need to pass
an additional parameter that allows making the difference between a JS builtin caller or a JS caller.
In the latter case, the constructor will throw.

Covered by existing tests, no observable change of behavior.

  • Modules/streams/ReadableByteStreamController.idl:
  • Modules/streams/ReadableByteStreamController.js:

(initializeReadableByteStreamController):
(getter.byobRequest):

  • Modules/streams/ReadableByteStreamInternals.js:

(privateInitializeReadableByteStreamController): Deleted.
(privateInitializeReadableStreamBYOBRequest): Deleted.

  • Modules/streams/ReadableStream.js:

(initializeReadableStream):

  • Modules/streams/ReadableStreamBYOBReader.js:

(initializeReadableStreamBYOBReader):

  • Modules/streams/ReadableStreamBYOBRequest.idl:
  • Modules/streams/ReadableStreamBYOBRequest.js:

(initializeReadableStreamBYOBRequest):

  • Modules/streams/ReadableStreamDefaultController.idl:
  • Modules/streams/ReadableStreamDefaultController.js:

(initializeReadableStreamDefaultController):
(enqueue):

  • Modules/streams/ReadableStreamDefaultReader.js:

(initializeReadableStreamDefaultReader):

  • Modules/streams/ReadableStreamInternals.js:

(readableStreamDefaultControllerError): Deleted.

  • Sources.txt:
  • UnifiedSources-input.xcfilelist:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/JSDOMBuiltinConstructor.h:
  • bindings/js/JSDOMGlobalObject.cpp:

(WebCore::JSDOMGlobalObject::addBuiltinGlobals):

  • bindings/js/JSReadableStreamPrivateConstructors.cpp: Removed.
  • bindings/js/JSReadableStreamPrivateConstructors.h: Removed.
  • bindings/scripts/CodeGeneratorJS.pm:

(GeneratePropertiesHashTable):

  • bindings/scripts/preprocess-idls.pl:

(shouldExposeInterface):

3:55 PM Changeset in webkit [239471] by jiewen_tan@apple.com
  • 7 edits in trunk

[WebAuthN] Remove hash from Client Data
https://bugs.webkit.org/show_bug.cgi?id=192727
<rdar://problem/46746673>

Reviewed by Brent Fulgham.

Source/WebCore:

The hash algorithm for hashing the client data is enforced to SHA_256 in the latest spec:
https://www.w3.org/TR/webauthn/#sec-client-data. Therefore, we should remove it.

Covered by existing tests.

  • Modules/webauthn/AuthenticatorCoordinator.cpp:

(WebCore::AuthenticatorCoordinatorInternal::produceClientDataJson):

LayoutTests:

  • http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
  • http/wpt/webauthn/public-key-credential-create-success-local.https.html:
  • http/wpt/webauthn/public-key-credential-get-success-hid.https.html:
  • http/wpt/webauthn/public-key-credential-get-success-local.https.html:
3:54 PM Changeset in webkit [239470] by jiewen_tan@apple.com
  • 21 edits in trunk

[WebAuthN] Add a runtime flag for local authenticator
https://bugs.webkit.org/show_bug.cgi?id=192792
<rdar://problem/46798738>

Reviewed by Brent Fulgham.

Source/WebCore:

No tests.

This patch adds a runtime flag for local authenticator and removes ways to
set the runtime flag for web authentication in LegacyWebKit.

  • page/RuntimeEnabledFeatures.h:

(WebCore::RuntimeEnabledFeatures::setWebAuthenticationLocalAuthenticatorEnabled):
(WebCore::RuntimeEnabledFeatures::webAuthenticationLocalAuthenticatorEnabled const):

Source/WebKit:

  • Shared/WebPreferences.yaml:
  • UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetWebAuthenticationLocalAuthenticatorEnabled):
(WKPreferencesGetWebAuthenticationLocalAuthenticatorEnabled):

  • UIProcess/API/C/WKPreferencesRefPrivate.h:
  • UIProcess/WebAuthentication/Cocoa/LocalService.mm:

(WebKit::LocalService::isAvailable):

Source/WebKitLegacy/mac:

  • WebView/WebPreferenceKeysPrivate.h:
  • WebView/WebPreferences.mm:

(+[WebPreferences initialize]):
(-[WebPreferences webAuthenticationEnabled]): Deleted.
(-[WebPreferences setWebAuthenticationEnabled:]): Deleted.

  • WebView/WebPreferencesPrivate.h:
  • WebView/WebView.mm:

(-[WebView _preferencesChanged:]):

Tools:

  • DumpRenderTree/TestOptions.cpp:

(TestOptions::TestOptions):

  • DumpRenderTree/TestOptions.h:
  • DumpRenderTree/mac/DumpRenderTree.mm:

(enableExperimentalFeatures):
(setWebPreferencesForTestOptions):

  • WebKitTestRunner/TestController.cpp:

(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):

  • WebKitTestRunner/TestOptions.h:

(WTR::TestOptions::hasSameInitializationOptions const):

LayoutTests:

  • platform/mac-highsierra-wk1/fast/dom/navigator-detached-no-crash-expected.txt:
  • platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt:
3:46 PM Changeset in webkit [239469] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

Pointer lock causes abandoned documents
https://bugs.webkit.org/show_bug.cgi?id=188727
rdar://problem/44248197

Patch by Jeremy Jones <jeremyj@apple.com> on 2018-12-20
Reviewed by Simon Fraser.

Fixes --world-leaks in these tests:

pointer-lock/locked-element-removed-from-dom.html
pointer-lock/mouse-event-delivery.html
fast/shadow-dom/pointerlockelement-in-slot.html

PointerLockController now uses WeakPtr instead of RefPtr because it has no need to extend the lifetime of a document.

  • page/PointerLockController.cpp:

(WebCore::PointerLockController::elementRemoved):
(WebCore::PointerLockController::documentDetached):
(WebCore::PointerLockController::didAcquirePointerLock):

  • page/PointerLockController.h:
3:18 PM Changeset in webkit [239468] by Joseph Pecoraro
  • 2 edits
    1 delete in trunk/Websites/webkit.org

Ensure new styles are served on webkit.org.
https://bugs.webkit.org/show_bug.cgi?id=192953

Patch by Jon Davis <Jon Davis> on 2018-12-20
Rubber-stamped by Devin Rousso.

  • tabicon.svg: Removed as vector icons are no longer preferred.
  • wp-content/themes/webkit/header.php: Updated stylesheet datestamp.
3:15 PM Changeset in webkit [239467] by Joseph Pecoraro
  • 5 edits in trunk

Web Inspector: Autoformat doesn't work on icloud.com (javascript-packed.js)
https://bugs.webkit.org/show_bug.cgi?id=192946
<rdar://problem/42546126>

Rubber-stamped by Devin Rousso.

Source/WebInspectorUI:

  • UserInterface/Base/Utilities.js:

(whitespaceRatio):
(isTextLikelyMinified):
Check the first 2500 and the last 2500 characters whitespace ratio.
If either is below 20% then treat as minified.

LayoutTests:

  • inspector/formatting/is-text-likely-minified-expected.txt:
  • inspector/formatting/is-text-likely-minified.html:

Add a test for a long header doc at the start but minified content at the end.

2:42 PM Changeset in webkit [239466] by Alan Coon
  • 1 copy in tags/Safari-606.4.5

Tag Safari-606.4.5.

1:45 PM Changeset in webkit [239465] by Jonathan Bedard
  • 2 edits in trunk/Tools

webkitpy: Autoinstall package URLs have changed
https://bugs.webkit.org/show_bug.cgi?id=192909
<rdar://problem/46860359>

Rubber-stamped by Alexey Proskuryakov.

PyPi urls have been moved around, we need to update our auto-installed packages.

We should check for Selenium before asking PyPi for the latest version.

  • Scripts/webkitpy/thirdparty/init.py:

(AutoinstallImportHook._install_mechanize): Update with new pypi url.
(AutoinstallImportHook._install_keyring): Ditto.
(AutoinstallImportHook._install_pep8): Ditto.
(AutoinstallImportHook._install_mozlog): Ditto.
(AutoinstallImportHook._install_mozprocess): Ditto.
(AutoinstallImportHook._install_pytest_timeout): Ditto.
(AutoinstallImportHook._install_pytest): Ditto.
(AutoinstallImportHook._install_pylint): Ditto.
(AutoinstallImportHook._install_buildbot): Ditto.
(AutoinstallImportHook._install_coverage): Ditto.
(AutoinstallImportHook._install_twisted_15_5_0): Ditto.
(AutoinstallImportHook._install_selenium): Update with new pypi url, only check
for new Selenium if the installed version isn't sufficient.
(AutoinstallImportHook.get_latest_pypi_url): Update with new pypi url.

1:39 PM Changeset in webkit [239464] by keith_miller@apple.com
  • 4 edits
    2 adds in trunk

Add support for globalThis
https://bugs.webkit.org/show_bug.cgi?id=165171

Reviewed by Mark Lam.

JSTests:

  • test262/config.yaml:

Source/JavaScriptCore:

This patch adds support for the globalThis property on the global
object. The globalThis property spec is in stage three and is
quite simple. For reference: http://tc39.github.io/proposal-global/

  • runtime/JSGlobalObject.cpp:
1:18 PM Changeset in webkit [239463] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

[ iOS WK2 ] Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/windowclient-navigate.https.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=191704

Unreviewed test gardening.

  • platform/ios/TestExpectations: Mark test as flaky.
1:13 PM Changeset in webkit [239462] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

[Mac] Update apache httpd.conf
https://bugs.webkit.org/show_bug.cgi?id=192942

Reviewed by Alexey Proskuryakov.

  • http/conf/apache2.4-php7-httpd.conf:
12:23 PM Changeset in webkit [239461] by Chris Dumez
  • 151 edits in trunk

Use Optional::valueOr() instead of Optional::value_or()
https://bugs.webkit.org/show_bug.cgi?id=192933

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

  • inspector/remote/cocoa/RemoteConnectionToTargetCocoa.mm:

(Inspector::RemoteConnectionToTarget::setup):

  • inspector/remote/glib/RemoteConnectionToTargetGlib.cpp:

(Inspector::RemoteConnectionToTarget::setup):

  • parser/SourceCodeKey.h:

(JSC::SourceCodeKey::SourceCodeKey):

  • wasm/js/WebAssemblyModuleRecord.cpp:

(JSC::WebAssemblyModuleRecord::link):

Source/WebCore:

  • Modules/applepay/paymentrequest/ApplePayPaymentHandler.cpp:

(WebCore::convert):
(WebCore::ApplePayPaymentHandler::didAuthorizePayment):

  • Modules/encryptedmedia/MediaKeySession.cpp:

(WebCore::MediaKeySession::load):

  • Modules/indexeddb/IDBDatabaseIdentifier.h:

(WebCore::IDBDatabaseIdentifier::hash const):

  • Modules/indexeddb/IDBFactory.cpp:

(WebCore::IDBFactory::open):

  • Modules/mediastream/MediaStreamTrack.cpp:

(WebCore::MediaStreamTrack::applyConstraints):

  • Modules/mediastream/RTCDTMFSender.cpp:

(WebCore::RTCDTMFSender::insertDTMF):

  • Modules/webdatabase/SQLTransaction.cpp:

(WebCore::SQLTransaction::executeSql):

  • Modules/webvr/VRFrameData.cpp:

(WebCore::VRFrameData::update):

  • animation/AnimationTimeline.cpp:

(WebCore::AnimationTimeline::updateCSSTransitionsForElement):

  • animation/DeclarativeAnimation.cpp:

(WebCore::DeclarativeAnimation::cancel):
(WebCore::DeclarativeAnimation::invalidateDOMEvents):

  • animation/KeyframeEffect.cpp:

(WebCore::computeMissingKeyframeOffsets):
(WebCore::KeyframeEffect::applyPendingAcceleratedActions):

  • animation/WebAnimation.cpp:

(WebCore::WebAnimation::runPendingPlayTask):
(WebCore::WebAnimation::runPendingPauseTask):

  • bindings/js/SerializedScriptValue.cpp:

(WebCore::CloneSerializer::write):

  • crypto/algorithms/CryptoAlgorithmHMAC.cpp:

(WebCore::CryptoAlgorithmHMAC::generateKey):
(WebCore::CryptoAlgorithmHMAC::importKey):

  • crypto/gcrypt/CryptoAlgorithmAES_GCMGCrypt.cpp:

(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):

  • crypto/gcrypt/CryptoKeyRSAGCrypt.cpp:

(WebCore::CryptoKeyRSA::importSpki):
(WebCore::CryptoKeyRSA::importPkcs8):

  • crypto/keys/CryptoKeyRSA.cpp:

(WebCore::CryptoKeyRSA::importJwk):

  • crypto/mac/CryptoAlgorithmAES_GCMMac.cpp:

(WebCore::CryptoAlgorithmAES_GCM::platformEncrypt):
(WebCore::CryptoAlgorithmAES_GCM::platformDecrypt):

  • crypto/mac/CryptoKeyRSAMac.cpp:

(WebCore::CryptoKeyRSA::importSpki):
(WebCore::CryptoKeyRSA::importPkcs8):

  • css/CSSComputedStyleDeclaration.cpp:

(WebCore::counterToCSSValue):

  • css/CSSFontFace.cpp:

(WebCore::calculateItalicRange):

  • css/CSSPrimitiveValue.cpp:

(WebCore::CSSPrimitiveValue::doubleValue const):

  • css/CSSStyleSheet.cpp:

(WebCore::CSSStyleSheet::addRule):

  • css/DOMMatrix.cpp:

(WebCore::DOMMatrix::rotateSelf):

  • css/DOMMatrixReadOnly.cpp:

(WebCore::DOMMatrixReadOnly::validateAndFixup):

  • css/StyleBuilderCustom.h:

(WebCore::StyleBuilderCustom::applyValueCounter):

  • css/parser/MediaQueryParser.cpp:

(WebCore::MediaQueryParser::commitMediaQuery):

  • dom/Document.h:

(WebCore::Document::referrerPolicy const):

  • dom/Element.cpp:

(WebCore::toScrollAlignment):

  • dom/EventTarget.cpp:

(WebCore::EventTarget::addEventListener):

  • dom/MutationObserver.cpp:

(WebCore::MutationObserver::observe):

  • editing/cocoa/FontAttributeChangesCocoa.mm:

(WebCore::FontChanges::platformFontFamilyNameForCSS const):

  • fileapi/File.cpp:

(WebCore::File::File):

  • html/DOMTokenList.cpp:

(WebCore::DOMTokenList::toggle):

  • html/HTMLOListElement.h:
  • html/ImageBitmap.cpp:

(WebCore::croppedSourceRectangleWithFormatting):

  • html/canvas/CanvasPattern.cpp:

(WebCore::CanvasPattern::setTransform):

  • html/canvas/CanvasRenderingContext2DBase.cpp:

(WebCore::CanvasRenderingContext2DBase::setTransform):
(WebCore::CanvasRenderingContext2DBase::isPointInPathInternal):
(WebCore::CanvasRenderingContext2DBase::isPointInStrokeInternal):

  • html/canvas/Path2D.cpp:

(WebCore::Path2D::addPath):

  • inspector/InspectorCanvas.cpp:

(WebCore::InspectorCanvas::buildAction):

  • inspector/InspectorFrontendHost.cpp:

(WebCore::populateContextMenu):

  • layout/FormattingContext.cpp:

(WebCore::Layout::FormattingContext::validateGeometryConstraintsAfterLayout const):

  • layout/FormattingContextGeometry.cpp:

(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inFlowPositionedPositionOffset):
(WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedHorizontalMarginValue):
(WebCore::Layout::FormattingContext::Geometry::computedNonCollapsedVerticalMarginValue):

  • layout/FormattingContextQuirks.cpp:

(WebCore::Layout::FormattingContext::Quirks::heightValueOfNearestContainingBlockWithFixedHeight):

  • layout/MarginTypes.h:

(WebCore::Layout::VerticalMargin::usedValues const):

  • layout/blockformatting/BlockFormattingContextGeometry.cpp:

(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedWidthAndMargin):
(WebCore::Layout::BlockFormattingContext::Geometry::instrinsicWidthConstraints):

  • layout/blockformatting/BlockFormattingContextQuirks.cpp:

(WebCore::Layout::BlockFormattingContext::Quirks::stretchedHeight):

  • layout/displaytree/DisplayBox.h:

(WebCore::Display::Box::width const):
(WebCore::Display::Box::height const):
(WebCore::Display::Box::contentBoxTop const):
(WebCore::Display::Box::contentBoxLeft const):

  • layout/floats/FloatingContext.cpp:

(WebCore::Layout::Iterator::set):

  • layout/inlineformatting/InlineFormattingContext.cpp:

(WebCore::Layout::InlineFormattingContext::appendContentToLine const):
(WebCore::Layout::InlineFormattingContext::placeInFlowPositionedChildren const):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::urlSelected):

  • loader/NavigationAction.cpp:
  • page/FrameView.cpp:

(WebCore::FrameView::setLayoutViewportOverrideRect):
(WebCore::FrameView::documentToAbsoluteScaleFactor const):
(WebCore::FrameView::viewportSizeForCSSViewportUnits const):

  • page/Page.cpp:

(WebCore::Page::setLowPowerModeEnabledOverrideForTesting):

  • page/SecurityOriginData.cpp:

(WebCore::SecurityOriginData::databaseIdentifier const):

  • page/SecurityOriginData.h:

(WebCore::SecurityOriginDataHash::hash):

  • page/SecurityOriginHash.h:

(WebCore::SecurityOriginHash::hash):

  • page/ViewportConfiguration.cpp:

(WebCore::ViewportConfiguration::setViewLayoutSize):

  • page/WindowFeatures.cpp:

(WebCore::parseDialogFeatures):

  • page/animation/AnimationBase.cpp:

(WebCore::AnimationBase::updateStateMachine):
(WebCore::AnimationBase::fireAnimationEventsIfNeeded):
(WebCore::AnimationBase::getTimeToNextEvent const):
(WebCore::AnimationBase::freezeAtTime):
(WebCore::AnimationBase::getElapsedTime const):

  • page/animation/CSSAnimationController.cpp:

(WebCore::CSSAnimationControllerPrivate::updateAnimationTimer):

  • page/cocoa/ResourceUsageThreadCocoa.mm:

(WebCore::ResourceUsageThread::platformThreadBody):

  • page/linux/ResourceUsageThreadLinux.cpp:

(WebCore::ResourceUsageThread::platformThreadBody):

  • platform/graphics/ComplexTextController.cpp:

(WebCore::ComplexTextController::offsetForPosition):

  • platform/graphics/FontCache.h:

(WebCore::FontDescriptionKey::computeHash const):

  • platform/graphics/FontCascade.cpp:

(WebCore::FontCascade::drawText const):
(WebCore::FontCascade::drawEmphasisMarks const):
(WebCore::FontCascade::displayListForTextRun const):
(WebCore::FontCascade::adjustSelectionRectForText const):
(WebCore::FontCascade::codePath const):

  • platform/graphics/FontSelectionAlgorithm.cpp:

(WebCore::FontSelectionAlgorithm::styleDistance const):

  • platform/graphics/FontSelectionAlgorithm.h:

(WebCore::operator<<):
(WebCore::FontSelectionSpecifiedCapabilities::computeWeight const):
(WebCore::FontSelectionSpecifiedCapabilities::computeWidth const):
(WebCore::FontSelectionSpecifiedCapabilities::computeSlope const):

  • platform/graphics/ShadowBlur.cpp:

(WebCore::ShadowBlur::calculateLayerBoundingRect):

  • platform/graphics/avfoundation/cf/WebCoreAVCFResourceLoader.cpp:

(WebCore::WebCoreAVCFResourceLoader::startLoading):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:

(WebCore::MediaPlayerPrivateAVFoundationObjC::paintWithVideoOutput):

  • platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::paintCurrentFrameInContext):

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::naturalSize):

  • platform/graphics/ca/GraphicsLayerCA.cpp:

(WebCore::GraphicsLayerCA::setVisibleAndCoverageRects):

  • platform/graphics/cocoa/FontCacheCoreText.cpp:

(WebCore::preparePlatformFont):

  • platform/graphics/filters/FETurbulence.cpp:

(WebCore::FETurbulence::fillRegion const):

  • platform/graphics/gstreamer/GStreamerCommon.cpp:

(WebCore::initializeGStreamer):

  • platform/graphics/texmap/TextureMapperLayer.cpp:

(WebCore::TextureMapperLayer::paintSelfAndChildrenWithReplica):
(WebCore::TextureMapperLayer::replicaTransform):
(WebCore::TextureMapperLayer::syncAnimations):

  • platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:

(WebCore::CoordinatedGraphicsLayer::transformedVisibleRect):
(WebCore::CoordinatedGraphicsLayer::computeTransformedVisibleRect):

  • platform/graphics/transforms/TransformState.cpp:

(WebCore::TransformState::mappedPoint const):
(WebCore::TransformState::mapQuad const):
(WebCore::TransformState::flattenWithTransform):

  • platform/network/CacheValidation.cpp:

(WebCore::computeCurrentAge):
(WebCore::computeFreshnessLifetimeForHTTPFamily):

  • platform/network/NetworkStateNotifier.cpp:

(WebCore::NetworkStateNotifier::onLine):

  • rendering/FloatingObjects.cpp:

(WebCore::FindNextFloatLogicalBottomAdapter::nextLogicalBottom const):
(WebCore::FindNextFloatLogicalBottomAdapter::nextShapeLogicalBottom const):

  • rendering/GridBaselineAlignment.cpp:

(WebCore::GridBaselineAlignment::ascentForChild const):

  • rendering/GridTrackSizingAlgorithm.cpp:

(WebCore::GridTrack::setGrowthLimit):
(WebCore::GridTrackSizingAlgorithm::initialBaseSize const):
(WebCore::GridTrackSizingAlgorithm::initialGrowthLimit const):
(WebCore::GridTrackSizingAlgorithm::sizeTrackToFitNonSpanningItem):
(WebCore::sortByGridTrackGrowthPotential):
(WebCore::GridTrackSizingAlgorithm::estimatedGridAreaBreadthForChild const):
(WebCore::GridTrackSizingAlgorithmStrategy::minSizeForChild const):
(WebCore::GridTrackSizingAlgorithm::initializeTrackSizes):

  • rendering/PaintInfo.h:

(WebCore::PaintInfo::applyTransform):

  • rendering/RenderBox.cpp:

(WebCore::RenderBox::computeLogicalHeight const):

  • rendering/RenderCounter.cpp:

(WebCore::planCounter):

  • rendering/RenderDeprecatedFlexibleBox.cpp:

(WebCore::RenderDeprecatedFlexibleBox::layoutHorizontalBox):

  • rendering/RenderFlexibleBox.cpp:

(WebCore::RenderFlexibleBox::baselinePosition const):
(WebCore::RenderFlexibleBox::marginBoxAscentForChild):
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):

  • rendering/RenderGrid.cpp:

(WebCore::RenderGrid::gridGap const):
(WebCore::RenderGrid::baselinePosition const):

  • rendering/RenderLayer.cpp:

(WebCore::RenderLayer::paintLayerByApplyingTransform):

  • rendering/RenderListBox.cpp:

(WebCore::RenderListBox::paintItem):
(WebCore::RenderListBox::listIndexIsVisible):

  • rendering/RenderMultiColumnSet.cpp:

(WebCore::RenderMultiColumnSet::calculateMaxColumnHeight const):

  • rendering/RenderTable.cpp:

(WebCore::RenderTable::convertStyleLogicalHeightToComputedHeight):

  • rendering/RenderTableCell.cpp:

(WebCore::RenderTableCell::cellBaselinePosition const):

  • rendering/RenderTableSection.cpp:

(WebCore::RenderTableSection::firstLineBaseline const):

  • rendering/RenderText.cpp:

(WebCore::RenderText::computePreferredLogicalWidths):
(WebCore::RenderText::previousOffset const):
(WebCore::RenderText::previousOffsetForBackwardDeletion const):
(WebCore::RenderText::nextOffset const):
(WebCore::RenderText::stringView const):

  • rendering/RenderView.cpp:

(WebCore::RenderView::layout):

  • rendering/mathml/RenderMathMLBlock.cpp:

(WebCore::RenderMathMLBlock::baselinePosition const):

  • rendering/mathml/RenderMathMLBlock.h:

(WebCore::RenderMathMLBlock::ascentForChild):

  • rendering/style/GridPosition.cpp:

(WebCore::GridPosition::max):

  • rendering/style/TextUnderlineOffset.h:

(WebCore::TextUnderlineOffset::lengthOr const):

  • rendering/svg/RenderSVGContainer.cpp:

(WebCore::RenderSVGContainer::nodeAtFloatPoint):

  • rendering/svg/RenderSVGForeignObject.cpp:

(WebCore::RenderSVGForeignObject::nodeAtFloatPoint):

  • rendering/svg/RenderSVGImage.cpp:

(WebCore::RenderSVGImage::nodeAtFloatPoint):

  • rendering/svg/RenderSVGResourceClipper.cpp:

(WebCore::RenderSVGResourceClipper::hitTestClipContent):

  • rendering/svg/RenderSVGResourceFilter.cpp:

(WebCore::RenderSVGResourceFilter::postApplyResource):

  • rendering/svg/RenderSVGRoot.cpp:

(WebCore::RenderSVGRoot::nodeAtPoint):

  • rendering/svg/RenderSVGShape.cpp:

(WebCore::RenderSVGShape::nodeAtFloatPoint):

  • rendering/svg/RenderSVGText.cpp:

(WebCore::RenderSVGText::nodeAtFloatPoint):

  • rendering/svg/SVGRenderingContext.cpp:

(WebCore::SVGRenderingContext::clipToImageBuffer):

  • svg/SVGToOTFFontConversion.cpp:

(WebCore::SVGToOTFFontConverter::processGlyphElement):
(WebCore::SVGToOTFFontConverter::SVGToOTFFontConverter):

Source/WebDriver:

  • Session.cpp:

(WebDriver::Session::handleUnexpectedAlertOpen):
(WebDriver::Session::computeElementLayout):
(WebDriver::Session::selectOptionElement):
(WebDriver::builtAutomationCookie):
(WebDriver::Session::takeScreenshot):

  • WebDriverService.cpp:

(WebDriver::WebDriverService::sendResponse const):
(WebDriver::WebDriverService::createSession):

Source/WebKit:

  • Shared/API/c/WKSecurityOriginRef.cpp:

(WKSecurityOriginGetPort):

  • UIProcess/API/APIProcessPoolConfiguration.h:
  • UIProcess/API/Cocoa/WKSecurityOrigin.mm:

(-[WKSecurityOrigin port]):

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(-[WKWebViewConfiguration _cpuLimit]):

  • UIProcess/API/glib/WebKitSecurityOrigin.cpp:

(webkit_security_origin_get_port):

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseHandleWheelEvent):

  • UIProcess/Automation/SimulatedInputDispatcher.cpp:

(WebKit::SimulatedInputKeyFrame::maximumDuration const):
(WebKit::SimulatedInputDispatcher::transitionInputSourceToState):

  • UIProcess/Automation/WebAutomationSession.cpp:

(WebKit::WebAutomationSession::setWindowFrameOfBrowsingContext):
(WebKit::WebAutomationSession::performInteractionSequence):

  • UIProcess/Automation/WebAutomationSessionMacros.h:
  • UIProcess/ServiceWorkerProcessProxy.cpp:

(WebKit::ServiceWorkerProcessProxy::start):

  • UIProcess/WebAuthentication/AuthenticatorManager.cpp:

(WebKit::AuthenticatorManager::initTimeOutTimer):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::deviceScaleFactor const):

  • UIProcess/WebPageProxy.h:

(WebKit::WebPageProxy::viewportSizeForCSSViewportUnits const):

  • UIProcess/gtk/WebPopupMenuProxyGtk.cpp:

(WebKit::WebPopupMenuProxyGtk::activateItem):

  • UIProcess/mac/LegacySessionStateCoding.cpp:

(WebKit::encodeFormDataElement):

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoad):

  • WebProcess/Plugins/PDF/PDFPlugin.mm:

(WebKit::PDFPlugin::convertFromPDFViewToRootView const):
(WebKit::PDFPlugin::boundsOnScreen const):
(WebKit::PDFPlugin::geometryDidChange):

  • WebProcess/WebCoreSupport/SessionStateConversion.cpp:

(WebKit::toFormData):

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::updateVisibleContentRects):

  • WebProcess/WebPage/wpe/CompositingManager.cpp:

(WebKit::CompositingManager::releaseConnectionFd):

Source/WebKitLegacy/mac:

  • WebCoreSupport/WebSecurityOrigin.mm:

(-[WebSecurityOrigin port]):

Source/WebKitLegacy/win:

  • WebSecurityOrigin.cpp:

(WebSecurityOrigin::port):

Source/WTF:

  • wtf/Optional.h:

(WTF::Optional<T::valueOr const):

Tools:

  • TestWebKitAPI/Tests/WTF/URLParser.cpp:

(TestWebKitAPI::checkURL):
(TestWebKitAPI::checkRelativeURL):
(TestWebKitAPI::checkURLDifferences):
(TestWebKitAPI::checkRelativeURLDifferences):

  • TestWebKitAPI/Tests/WebCore/URLParserTextEncoding.cpp:

(TestWebKitAPI::checkURL):

12:08 PM Changeset in webkit [239460] by commit-queue@webkit.org
  • 8 edits in trunk/Source

ITMLKit Inspector: Elements tab does not show DOM Tree
https://bugs.webkit.org/show_bug.cgi?id=192910
<rdar://problem/46680585>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-12-20
Reviewed by Brian Burg.

Source/JavaScriptCore:

  • inspector/agents/InspectorAgent.h:
  • inspector/agents/InspectorAgent.cpp:

(Inspector::InspectorAgent::enable):
(Inspector::InspectorAgent::activateExtraDomain):
(Inspector::InspectorAgent::activateExtraDomains):
Send extra domains immediately instead of waiting until
the Inspector domain is enabled. This will ensure the frontend
hears about extra augmented domains before augmenting agents
get a chance to send any messages.

Source/WebInspectorUI:

  • UserInterface/Protocol/Connection.js:

(InspectorBackend.Connection.prototype._dispatchEvent):
Better logging for errors.

  • UserInterface/Base/Main.js:
  • UserInterface/Controllers/AppController.js:

(WI.AppController.prototype.activateExtraDomains):
Let Targets get a chance to activate extra domains.
Perform a little more work in these cases.

  • UserInterface/Protocol/Target.js:

(WI.Target):
(WI.Target.prototype.activateExtraDomain):
Expose agents for domains that are active.
Expose agents for extra domains when they are activated.

12:05 PM Changeset in webkit [239459] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebInspectorUI

ITMLKit Inspector: Computed Style Box Model section throws exceptions
https://bugs.webkit.org/show_bug.cgi?id=192911
<rdar://problem/46861112>

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2018-12-20
Reviewed by Matt Baker.

  • UserInterface/Views/BoxModelDetailsSectionRow.js:

(WI.BoxModelDetailsSectionRow.prototype._updateMetrics.createBoxPartElement):
(WI.BoxModelDetailsSectionRow.prototype._updateMetrics.createContentAreaElement):
(WI.BoxModelDetailsSectionRow.prototype._updateMetrics):
ITMLKit doesn't always provide a display/position/width/height etc properties.
Protect against this, and just show an empty message in the box model section
if those properties do not exist.

11:48 AM Changeset in webkit [239458] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r239419): heap-use-after-free in AudioSourceProviderAVFObjC::finalizeCallback()
https://bugs.webkit.org/show_bug.cgi?id=192941
<rdar://problem/46874096>

Reviewed by Brent Fulgham.

Don't delete the locked lock before unlocking the lock.

  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::finalizeCallback):

11:23 AM Changeset in webkit [239457] by Keith Rollin
  • 13 edits in trunk/Source

Improve release-level page-load logging
https://bugs.webkit.org/show_bug.cgi?id=192872
<rdar://problem/46850309>

Reviewed by Chris Dumez.

There are a number of reported bugs that are difficult or impossible
to track down with our current level of logging. Additionally, some
software groups lower in the page-loading stack have requested logging
sufficient for tracking a user-visible error message down to the
requested resource that caused the message. Add more-comprehensive
logging to address these issues/requests.

Source/WebCore:

No new tests -- no changed functionality.

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::setMainDocumentError):
(WebCore::DocumentLoader::mainReceivedError):
(WebCore::DocumentLoader::stopLoading):
(WebCore::DocumentLoader::notifyFinished):
(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::continueAfterContentPolicy):
(WebCore::DocumentLoader::startLoadingMainResource):
(WebCore::DocumentLoader::loadMainResource):
(WebCore::DocumentLoader::cancelMainResourceLoad):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::urlSelected):
(WebCore::FrameLoader::loadURLIntoChildFrame):
(WebCore::FrameLoader::loadArchive):
(WebCore::FrameLoader::loadInSameDocument):
(WebCore::FrameLoader::loadFrameRequest):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::loadWithNavigationAction):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::reloadWithOverrideEncoding):
(WebCore::FrameLoader::reload):
(WebCore::FrameLoader::setState):
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
(WebCore::FrameLoader::loadPostRequest):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::loadDifferentDocumentItem):

  • loader/ProgressTracker.cpp:

(WebCore::ProgressItem::ProgressItem):
(WebCore::ProgressTracker::reset):
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::progressCompleted):
(WebCore::ProgressTracker::finalProgressComplete):
(WebCore::ProgressTracker::incrementProgress):
(WebCore::ProgressTracker::completeProgress):
(WebCore::ProgressTracker::isAlwaysOnLoggingAllowed const):

  • loader/ProgressTracker.h:
  • loader/ResourceLoader.cpp:

(WebCore::ResourceLoader::loadDataURL):
(WebCore::ResourceLoader::willSendRequestInternal):
(WebCore::ResourceLoader::didFinishLoading):
(WebCore::ResourceLoader::didFail):
(WebCore::ResourceLoader::willSendRequestAsync):
(WebCore::ResourceLoader::wasBlocked):
(WebCore::ResourceLoader::cannotShowURL):

  • loader/SubresourceLoader.cpp:

(WebCore::SubresourceLoader::willSendRequestInternal):
(WebCore::=):
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::willCancel):

  • loader/cache/CachedResource.cpp:

(WebCore::CachedResource::load):

Source/WebKit:

  • UIProcess/WebPageProxy.cpp:

(WebKit::m_editableImageController):
(WebKit::WebPageProxy::~WebPageProxy):
(WebKit::WebPageProxy::reattachToWebProcess):
(WebKit::WebPageProxy::swapToWebProcess):
(WebKit::WebPageProxy::reattachToWebProcessForReload):
(WebKit::WebPageProxy::reattachToWebProcessWithItem):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::tryClose):
(WebKit::WebPageProxy::loadRequest):
(WebKit::WebPageProxy::loadRequestWithNavigation):
(WebKit::WebPageProxy::loadFile):
(WebKit::WebPageProxy::loadData):
(WebKit::WebPageProxy::loadDataWithNavigation):
(WebKit::WebPageProxy::loadAlternateHTML):
(WebKit::WebPageProxy::loadWebArchiveData):
(WebKit::WebPageProxy::navigateToPDFLinkWithSimulatedClick):
(WebKit::WebPageProxy::stopLoading):
(WebKit::WebPageProxy::reload):
(WebKit::WebPageProxy::goToBackForwardItem):
(WebKit::WebPageProxy::tryRestoreScrollPosition):
(WebKit::WebPageProxy::updateThrottleState):
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
(WebKit::WebPageProxy::continueNavigationInNewProcess):
(WebKit::WebPageProxy::restoreFromSessionState):
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):
(WebKit::WebPageProxy::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::WebPageProxy::willPerformClientRedirectForFrame):
(WebKit::WebPageProxy::didCancelClientRedirectForFrame):
(WebKit::WebPageProxy::didFailProvisionalLoadForFrame):
(WebKit::WebPageProxy::didCommitLoadForFrame):
(WebKit::WebPageProxy::didFinishDocumentLoadForFrame):
(WebKit::WebPageProxy::didFinishLoadForFrame):
(WebKit::WebPageProxy::didFailLoadForFrame):
(WebKit::WebPageProxy::didSameDocumentNavigationForFrame):
(WebKit::WebPageProxy::didNavigateWithNavigationData):
(WebKit::WebPageProxy::didPerformClientRedirect):
(WebKit::WebPageProxy::didPerformServerRedirect):
(WebKit::WebPageProxy::processDidBecomeUnresponsive):
(WebKit::WebPageProxy::processDidBecomeResponsive):
(WebKit::WebPageProxy::processDidTerminate):
(WebKit::WebPageProxy::dispatchProcessDidTerminate):
(WebKit::WebPageProxy::tryReloadAfterProcessTermination):
(WebKit::WebPageProxy::didExceedInactiveMemoryLimitWhileActive):
(WebKit::WebPageProxy::didExceedBackgroundCPULimitWhileInForeground):

  • WebProcess/Network/WebLoaderStrategy.cpp:

(WebKit::WebLoaderStrategy::scheduleLoad):
(WebKit::WebLoaderStrategy::scheduleLoadFromNetworkProcess):
(WebKit::WebLoaderStrategy::loadResourceSynchronously):

  • WebProcess/Network/WebResourceLoader.cpp:

(WebKit::WebResourceLoader::willSendRequest):
(WebKit::WebResourceLoader::didReceiveResponse):

  • WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:

(WebKit::WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebKit::WebFrameLoaderClient::dispatchDidFailLoad):

11:18 AM Changeset in webkit [239456] by keith_miller@apple.com
  • 3 edits in trunk/JSTests

Update test262 configuration to not run tests dependent on ICU version.
https://bugs.webkit.org/show_bug.cgi?id=192920

Reviewed by Saam Barati.

  • test262/expectations.yaml:
10:51 AM Changeset in webkit [239455] by mark.lam@apple.com
  • 4 edits
    1 add in trunk

Fix a typo in slow_path_construct_arityCheck and operationConstructArityCheck.
https://bugs.webkit.org/show_bug.cgi?id=192939
<rdar://problem/46869516>

Reviewed by Keith Miller.

JSTests:

  • stress/stack-overflow-frame-for-construct-arityCheck-should-use-construct-codeBlock.js: Added.

Source/JavaScriptCore:

  • jit/JITOperations.cpp:
  • runtime/CommonSlowPaths.cpp:
10:42 AM Changeset in webkit [239454] by wenson_hsieh@apple.com
  • 30 edits
    2 moves in trunk/Source/WebKit

[iOS] Replace "node assistance" terminology in WebKit with "focused element"
https://bugs.webkit.org/show_bug.cgi?id=192936

Reviewed by Tim Horton.

Renames a few methods and data structures in WebKit, to refer to "focused elements" rather than "assisted nodes";
see below for more details. No new tests, because there should be no change in behavior.

  • Shared/FocusedElementInformation.cpp: Renamed from Source/WebKit/Shared/AssistedNodeInformation.cpp.

(WebKit::OptionItem::encode const):
(WebKit::OptionItem::decode):
(WebKit::FocusedElementInformation::encode const):
(WebKit::FocusedElementInformation::decode):

  • Shared/FocusedElementInformation.h: Renamed from Source/WebKit/Shared/AssistedNodeInformation.h.

Rename AssistedNodeInformation to FocusedElementInformation. Additionally, introduce a named type for the
focusedElementIdentifier (which is currently just a uint64_t).

(WebKit::OptionItem::OptionItem):

  • Shared/ios/InteractionInformationAtPosition.h:
  • Shared/ios/InteractionInformationAtPosition.mm:

(WebKit::InteractionInformationAtPosition::encode const):
(WebKit::InteractionInformationAtPosition::decode):

  • SourcesCocoa.txt:
  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _shouldUpdateKeyboardWithInfo:]):

  • UIProcess/PageClient.h:
  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::resetStateAfterProcessExited):

  • UIProcess/WebPageProxy.h:

Rename NodeAssistanceArguments to ElementDidFocusArguments (and also add a FIXME for removing this mechanism
eventually).

(WebKit::WebPageProxy::focusNextFocusedElement):
(WebKit::WebPageProxy::focusNextAssistedNode): Deleted.

  • UIProcess/WebPageProxy.messages.in:

Rename StartAssistingNode to ElementDidFocus, and StopAssistingNode to ElementDidBlur.

  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/ios/PageClientImplIOS.mm:

(WebKit::PageClientImpl::elementDidFocus):
(WebKit::PageClientImpl::isFocusingElement):
(WebKit::PageClientImpl::elementDidBlur):
(WebKit::PageClientImpl::startAssistingNode): Deleted.
(WebKit::PageClientImpl::isAssistingNode): Deleted.
(WebKit::PageClientImpl::stopAssistingNode): Deleted.

  • UIProcess/ios/WKContentView.h:
  • UIProcess/ios/WKContentView.mm:

(-[WKContentView isFocusingElement]):
(-[WKContentView _didCommitLoadForMainFrame]):
(-[WKContentView isAssistingNode]): Deleted.

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKFocusedElementInfo initWithFocusedElementInformation:isUserInitiated:userObject:]):
(hasFocusedElement):
(-[WKContentView cleanupInteraction]):
(-[WKContentView shouldHideSelectionWhenScrolling]):
(-[WKContentView resignFirstResponderForWebView]):
(-[WKContentView _didGetTapHighlightForRequest:color:quads:topLeftRadius:topRightRadius:bottomLeftRadius:bottomRightRadius:]):
(-[WKContentView _requiresKeyboardWhenFirstResponder]):
(-[WKContentView _zoomToRevealFocusedElement]):
(-[WKContentView inputView]):
(-[WKContentView _selectionClipRect]):
(-[WKContentView gestureRecognizerShouldBegin:]):
(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):
(-[WKContentView clearSelection]):
(-[WKContentView requiresAccessoryView]):
(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView _isInteractingWithFocusedElement]):
(-[WKContentView changeSelectionWithGestureAt:withGesture:withState:withFlags:]):
(-[WKContentView selectPositionAtPoint:completionHandler:]):
(-[WKContentView selectPositionAtBoundary:inDirection:fromPoint:completionHandler:]):
(-[WKContentView selectTextWithGranularity:atPoint:completionHandler:]):
(-[WKContentView updateSelectionWithExtentPoint:completionHandler:]):
(-[WKContentView updateSelectionWithExtentPoint:withBoundary:completionHandler:]):
(-[WKContentView accessoryTab:]):
(-[WKContentView _becomeFirstResponderWithSelectionMovingForward:completionHandler:]):
(-[WKContentView accessoryClear]):
(-[WKContentView _updateAccessory]):
(-[WKContentView insertTextSuggestion:]):
(-[WKContentView setSelectedTextRange:]):
(-[WKContentView textInputTraits]):
(-[WKContentView isScrollableForKeyboardScrollViewAnimator:]):
(-[WKContentView focusedElementInformation]):
(-[WKContentView focusedSelectElementOptions]):
(rectToRevealWhenZoomingToFocusedElement):
(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
(-[WKContentView _elementDidBlur]):
(-[WKContentView _didReceiveEditorStateUpdateAfterFocus]):
(-[WKContentView updateCurrentFocusedElementInformation:]):
(-[WKContentView presentViewControllerForCurrentFocusedElement]):
(-[WKContentView focusedFormControlViewDidSubmit:]):
(-[WKContentView focusedFormControlViewDidCancel:]):
(-[WKContentView focusedFormControlViewDidBeginEditing:]):
(-[WKContentView rectForFocusedFormControlView:]):
(-[WKContentView nextRectForFocusedFormControlView:]):
(-[WKContentView previousRectForFocusedFormControlView:]):
(-[WKContentView actionNameForFocusedFormControlView:]):
(-[WKContentView focusedFormControlViewDidRequestNextNode:]):
(-[WKContentView focusedFormControlViewDidRequestPreviousNode:]):
(-[WKContentView hasNextNodeForFocusedFormControlView:]):
(-[WKContentView hasPreviousNodeForFocusedFormControlView:]):
(-[WKContentView selectMenu:didSelectItemAtIndex:]):
(-[WKContentView numberOfItemsInSelectMenu:]):
(-[WKContentView selectMenu:displayTextForItemAtIndex:]):
(-[WKContentView selectMenu:didCheckItemAtIndex:checked:]):
(-[WKContentView selectMenuUsesMultipleSelection:]):
(-[WKContentView selectMenu:hasSelectedOptionAtIndex:]):
(-[WKContentView _updateChangedSelection:]):
(-[WKContentView _autofillContext]):
(-[WKContentView dismissQuickboardViewControllerAndRevealFocusedFormOverlayIfNecessary:]):
(-[WKContentView allowsLanguageSelectionMenuForListViewController:]):
(-[WKContentView inputLabelTextForViewController:]):
(-[WKContentView initialValueForViewController:]):
(-[WKContentView shouldDisplayInputContextViewForListViewController:]):
(-[WKContentView numericInputModeForListViewController:]):
(-[WKContentView textContentTypeForListViewController:]):
(-[WKContentView allowsDictationInputForListViewController:]):
(-[WKFocusedElementInfo initWithAssistedNodeInformation:isUserInitiated:userObject:]): Deleted.
(hasAssistedNode): Deleted.

Replaced with hasFocusedElement.

(-[WKContentView _isInteractingWithAssistedNode]): Deleted.
(-[WKContentView assistedNodeInformation]): Deleted.
(-[WKContentView assistedNodeSelectOptions]): Deleted.
(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]): Deleted.
(-[WKContentView _stopAssistingNode]): Deleted.
(-[WKContentView updateCurrentAssistedNodeInformation:]): Deleted.
(-[WKContentView presentViewControllerForCurrentAssistedNode]): Deleted.

  • UIProcess/ios/WebDataListSuggestionsDropdownIOS.mm:

(-[WKDataListSuggestionsControl textAlignment]):

  • UIProcess/ios/WebPageProxyIOS.mm:

(WebKit::WebPageProxy::focusedElementInformationCallback):
(WebKit::WebPageProxy::requestFocusedElementInformation):
(WebKit::WebPageProxy::computeCustomFixedPositionRect const):
(WebKit::WebPageProxy::didCommitLayerTree):
(WebKit::WebPageProxy::selectWithGesture):
(WebKit::WebPageProxy::selectTextWithGranularityAtPoint):
(WebKit::WebPageProxy::selectPositionAtBoundaryWithDirection):
(WebKit::WebPageProxy::selectPositionAtPoint):
(WebKit::WebPageProxy::updateSelectionWithExtentPoint):
(WebKit::WebPageProxy::updateSelectionWithExtentPointAndBoundary):
(WebKit::WebPageProxy::blurFocusedElement):
(WebKit::WebPageProxy::elementDidFocus):
(WebKit::WebPageProxy::elementDidBlur):
(WebKit::WebPageProxy::focusNextFocusedElement):
(WebKit::WebPageProxy::setFocusedElementValue):
(WebKit::WebPageProxy::setFocusedElementValueAsNumber):
(WebKit::WebPageProxy::setFocusedElementSelectedIndex):
(WebKit::WebPageProxy::assistedNodeInformationCallback): Deleted.
(WebKit::WebPageProxy::requestAssistedNodeInformation): Deleted.
(WebKit::WebPageProxy::blurAssistedNode): Deleted.
(WebKit::WebPageProxy::startAssistingNode): Deleted.
(WebKit::WebPageProxy::stopAssistingNode): Deleted.
(WebKit::WebPageProxy::focusNextAssistedNode): Deleted.
(WebKit::WebPageProxy::setAssistedNodeValue): Deleted.
(WebKit::WebPageProxy::setAssistedNodeValueAsNumber): Deleted.
(WebKit::WebPageProxy::setAssistedNodeSelectedIndex): Deleted.

  • UIProcess/ios/forms/WKFormColorPicker.mm:

(-[WKColorPicker initWithView:]):
(-[WKColorPicker setControlValueFromUIColor:]):

  • UIProcess/ios/forms/WKFormInputControl.mm:

(-[WKDateTimePicker initWithView:datePickerMode:]):
(-[WKDateTimePicker shouldPresentGregorianCalendar:]):
(-[WKDateTimePicker _dateChangedSetAsNumber]):
(-[WKDateTimePicker _dateChangedSetAsString]):
(-[WKDateTimePicker controlBeginEditing]):
(-[WKFormInputControl initWithView:]):
(-[WKDateTimePopover clear:]):
(-[WKDateTimePopover initWithView:datePickerMode:]):

  • UIProcess/ios/forms/WKFormPopover.mm:

(-[WKRotatingPopover presentPopoverAnimated:]):

  • UIProcess/ios/forms/WKFormSelectControl.h:
  • UIProcess/ios/forms/WKFormSelectControl.mm:

(-[WKFormSelectControl initWithView:]):

  • UIProcess/ios/forms/WKFormSelectPicker.mm:

(-[WKMultipleSelectPicker initWithView:]):
(-[WKMultipleSelectPicker pickerView:viewForRow:forComponent:reusingView:]):
(-[WKMultipleSelectPicker pickerView:numberOfRowsInComponent:]):
(-[WKMultipleSelectPicker findItemIndexAt:]):
(-[WKMultipleSelectPicker pickerView:row:column:checked:]):
(-[WKSelectSinglePicker initWithView:]):
(-[WKSelectSinglePicker controlEndEditing]):
(-[WKSelectSinglePicker pickerView:numberOfRowsInComponent:]):
(-[WKSelectSinglePicker pickerView:attributedTitleForRow:forComponent:]):
(-[WKSelectSinglePicker pickerView:didSelectRow:inComponent:]):

  • UIProcess/ios/forms/WKFormSelectPopover.mm:

(-[WKSelectTableViewController initWithView:hasGroups:]):
(-[WKSelectTableViewController tableView:numberOfRowsInSection:]):
(-[WKSelectTableViewController tableView:titleForHeaderInSection:]):
(-[WKSelectTableViewController findItemIndexAt:]):
(-[WKSelectTableViewController findItemAt:]):
(-[WKSelectTableViewController tableView:cellForRowAtIndexPath:]):
(-[WKSelectTableViewController tableView:didSelectRowAtIndexPath:]):
(-[WKSelectPopover initWithView:hasGroups:]):

  • WebKit.xcodeproj/project.pbxproj:
  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::elementDidFocus):
(WebKit::WebChromeClient::elementDidRefocus):
(WebKit::WebChromeClient::elementDidBlur):

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::didStartPageTransition):
(WebKit::WebPage::setTextAsync):
(WebKit::WebPage::resetFocusedElementForFrame):
(WebKit::WebPage::elementDidRefocus):
(WebKit::WebPage::elementDidFocus):
(WebKit::WebPage::elementDidBlur):
(WebKit::WebPage::didCommitLoad):
(WebKit::WebPage::resetAssistedNodeForFrame): Deleted.

  • WebProcess/WebPage/WebPage.h:

Refactor elementDid{Refocus|Focus|Blur} to take Element& rather than Node*.

  • WebProcess/WebPage/WebPage.messages.in:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

Replace m_assistedNode (a RefPtr<Node>) with m_focusedElement (a RefPtr<Element>).

(WebKit::WebPage::platformEditorState const):
(WebKit::WebPage::completeSyntheticClick):
(WebKit::WebPage::requestFocusedElementInformation):
(WebKit::WebPage::blurFocusedElement):
(WebKit::WebPage::setFocusedElementValue):
(WebKit::WebPage::setFocusedElementValueAsNumber):
(WebKit::WebPage::setFocusedElementSelectedIndex):
(WebKit::innerFrameQuad):
(WebKit::constrainPoint):
(WebKit::WebPage::selectWithGesture):
(WebKit::WebPage::startAutoscrollAtPosition):
(WebKit::WebPage::visiblePositionInFocusedNodeForPoint):
(WebKit::WebPage::selectPositionAtPoint):
(WebKit::WebPage::selectPositionAtBoundaryWithDirection):
(WebKit::WebPage::rangeForGranularityAtPoint):
(WebKit::WebPage::selectTextWithGranularityAtPoint):
(WebKit::WebPage::updateSelectionWithExtentPointAndBoundary):
(WebKit::WebPage::updateSelectionWithExtentPoint):
(WebKit::WebPage::getPositionInformation):
(WebKit::WebPage::focusNextFocusedElement):
(WebKit::WebPage::getFocusedElementInformation):
(WebKit::WebPage::autofillLoginCredentials):
(WebKit::WebPage::requestAssistedNodeInformation): Deleted.
(WebKit::WebPage::blurAssistedNode): Deleted.
(WebKit::WebPage::setAssistedNodeValue): Deleted.
(WebKit::WebPage::setAssistedNodeValueAsNumber): Deleted.
(WebKit::WebPage::setAssistedNodeSelectedIndex): Deleted.
(WebKit::WebPage::focusNextAssistedNode): Deleted.
(WebKit::WebPage::getAssistedNodeInformation): Deleted.

10:32 AM Changeset in webkit [239453] by Ryan Haddad
  • 7 edits in trunk

Unreviewed, rolling out r239417.

Introduced two API test failures on macOS.

Reverted changeset:

"<rdar://problem/46194315> macOS: WebKit1 does not handle
occlusion changes"
https://bugs.webkit.org/show_bug.cgi?id=192821
https://trac.webkit.org/changeset/239417

10:29 AM Changeset in webkit [239452] by Devin Rousso
  • 7 edits in trunk

Web Inspector: UIString should take an optional key and description to aid localization
https://bugs.webkit.org/show_bug.cgi?id=153962
<rdar://problem/24542505>

Reviewed by Brian Burg.

Source/WebInspectorUI:

  • UserInterface/Base/LoadLocalizedStrings.js:

(WI.UIString):

  • UserInterface/Test/Test.js:

(WI.UIString):

  • UserInterface/Views/AuditTestGroupContentView.js:

(WI.AuditTestGroupContentView.prototype.initialLayout):

Tools:

  • Scripts/extract-localizable-js-strings:
10:27 AM Changeset in webkit [239451] by Brent Fulgham
  • 4 edits in trunk/Source

WKWebView default UA doesn't freeze the build number
https://bugs.webkit.org/show_bug.cgi?id=192809
<rdar://problem/44687185>

Reviewed by Andy Estes.

Always reports the frozen build number.

Source/WebKit:

  • UIProcess/API/Cocoa/WKWebViewConfiguration.mm:

(defaultApplicationNameForUserAgent): Do not expose the actual build number through this API.

Source/WebKitLegacy/mac:

  • WebView/WebView.mm:

(-[WebView _setBrowserUserAgentProductVersion:buildVersion:bundleVersion:]): Do not report the
actual build number through this method call.
(-[WebView _setUIWebViewUserAgentWithBuildVersion:]): Ditto.

10:25 AM Changeset in webkit [239450] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

[iOS] Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/update-registration-with-type.https.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=192938

Unreviewed test gardening.

  • platform/ios/TestExpectations: Mark test as flaky.
10:15 AM Changeset in webkit [239449] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Audits: don't cache default audits
https://bugs.webkit.org/show_bug.cgi?id=192918
<rdar://problem/46626543>

Reviewed by Brian Burg.

Instead of adding the default audits to the "audits" WI.ObjectStore, which preserves them
across WebInspector sessions, load them every time WebInspector is opened (unless there are
existing audits) so that the localized strings are able to respond to locale changes.

  • UserInterface/Controllers/AuditManager.js:

(WI.AuditManager.prototype.removeTest):
(WI.AuditManager.prototype.addDefaultTestsIfNeeded):

10:14 AM Changeset in webkit [239448] by Jon Davis
  • 13 edits
    4 adds in trunk/Websites/webkit.org

Added a dark mode color scheme.
https://bugs.webkit.org/show_bug.cgi?id=192930

Reviewed by Timothy Hatcher.

  • .htaccess: Added convenience redirects for /features and /css-features
  • wp-content/themes/webkit/build-archives.php: Customized dark color styles for the page.
  • wp-content/themes/webkit/css-status.php: Implemented new design and dark styles support.
  • wp-content/themes/webkit/front-header.php: Added dark color styles.
  • wp-content/themes/webkit/functions.php: Added new feature status navigation menu.
  • wp-content/themes/webkit/header.php: Specify support for light and dark color schemes.
  • wp-content/themes/webkit/images/chevron-dark.svg: Added.
  • wp-content/themes/webkit/images/chevron.svg: Switch to HSL color.
  • wp-content/themes/webkit/images/filter.svg: Added.
  • wp-content/themes/webkit/images/icons.svg: Use currentColor for dark mode.
  • wp-content/themes/webkit/images/invert-lightness.svg: Added.
  • wp-content/themes/webkit/images/search.svg: Added.
  • wp-content/themes/webkit/sitemap.php: Customized dark color styles for the page.
  • wp-content/themes/webkit/status.php: Updated design and dark styles support.
  • wp-content/themes/webkit/style.css: Added dark style rules and switched to custom properties.

(:root):
(@media(prefers-color-scheme:dark)):
(body):
(a):
(a,):
(hr):
(code):
(main):
(a[name]):
(p > a[name]::before):
(a[name]:hover):
(a[name]:hover::before):
(p:hover > a[name]::before):
(input[type=text]):
(input[type=submit]):
(.screen-reader-text:focus):
(.pagination .page-numbers,):
(.pagination .menu-item a):
(.pagination .page-numbers:not(.current, .dots):hover):
(.pagination .dots,):
(.connected.pagination .menu-item):
(.connected.pagination .menu-item:hover a):
(.connected.pagination .menu-item:first-child a):
(.connected.pagination .menu-item:last-child a):
(.connected.pagination .menu-item.current-menu-item a,):
(.menu-feature-pages-container):
(.nextrouter):
(.nextrouter.previous):
(.nextrouter:hover,):
(.nextrouter a):
(.nextrouter-copy):
(.nextrouter .label):
(.nextrouter .link):
(.tiles):
(.tile):
(.tile .background-image):
(.tile .background-image svg):
(.tile.category-web-inspector svg):
(.tile.category-performance svg):
(.tile.category-javascript svg):
(.tile.category-css svg):
(.tile.category-standards svg):
(.tile.category-contributing svg):
(.tile.category-storage svg):
(.tile.category-layout svg):
(.tile.category-safari-technology-preview svg):
(.tile.category-accessibility svg):
(.tile.category-security svg):
(.tile.category-privacy svg):
(.tile .background-image.loaded):
(.tile:not(.has-post-thumbnail) .background-image,):
(.featured-tile .tile-content):
(.background-vignette):
(.tag-window .background-image):
(.tag-window .background-vignette):
(.featured-tile.tag-dark .background-vignette):
(.featured-tile.tag-dark .tile-content):
(.featured-tile.tag-dark .tile-content a):
(.icon-tile .icon):
(.icon-tile,):
(.gray-tile):
(.gray-tile a):
(.amber-tile):
(.blue-tile):
(.twitter-tile):
(.icon.twitter-icon):
(pre):
(code .keyword,):
(code .keyword.builtin,):
(code .keyword.type):
(code .preprocessor):
(code .comment):
(code .comment .doc):
(code .identifier):
(code .string,):
(code .escaped):
(code .number,):
(code .regex,):
(code .attribute.value):
(code .operator):
(code .keyword.operator):
(code .whitespace):
(code .error):
(code .doctype):
(code .property):
(code.xml .comment,):
(code.xml .preprocessor .keyword):
(code.xml .meta,):
(code.cpp .preprocessor .identifier):
(pre::-moz-selection,):
(pre::selection, pre span::selection):
(code.css .attribute,):
(code.css .keyword):
(code.css .number):
(article h1,):
(article .byline p):
(article thead, article tfoot):
(article tr):
(article blockquote):
(.post .bodycopy > p:last-child:after):
(article div.note):
(article .foreword):
(article .cliptop):
(article .clipbottom):
(article .clipright):
(article .clipleft):
(article .mattewhite):
(article .mattewhite:not(.widescreen)):
(figure.table):
(article figcaption):
(article figcaption::before):
(.table-of-contents):
(.site-logo):
(.feature-header:after,):
(header nav a,):
(header nav a:hover,):
(.sub-menu-layer):
(.sub-menu-layer:after):
(.sub-menu-layer:before):
(@media only screen and (max-width: 920px)):
(header .menu):
(header nav a):
(header .menu > .menu-item > .sub-menu):
(@media only screen and (max-width: 690px)):
(article .scrollable):
(@media only screen and (max-width: 600px)):
(.table-of-contents label:after):
(@media only screen and (max-width: 415px)):
(article .invert-brightness,):
(.preserve-color, video):
(.preserve-color:hover,):
(.nextrouter .link,):
(.search-input):
(.filters-toggle-button):
(a > code): Deleted.
(.pagination .page-numbers): Deleted.
(.nextrouter:hover): Deleted.
(.nextrouter.previous:hover): Deleted.
(.icon-tile, .icon-tile a): Deleted.
(.gray-tile, .gray-tile a): Deleted.
(code .string, code .char): Deleted.
(code .number, code .tag): Deleted.
(code .regex, code .attribute): Deleted.
(code.xml .meta, code.xml .meta .keyword): Deleted.
(code::-moz-selection, code span::-moz-selection): Deleted.
(code::selection, code span::selection): Deleted.
(article h1 a): Deleted.
(.feature-header:after): Deleted.
(.feature.opened .feature-header:after): Deleted.

  • wp-content/themes/webkit/team.php: Customized dark color styles for the page.
10:11 AM Changeset in webkit [239447] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebCore

Switch tabs before retuning PiP video to inline.
https://bugs.webkit.org/show_bug.cgi?id=192767
rdar://problem/46006046

Patch by Jeremy Jones <jeremyj@apple.com> on 2018-12-20
Reviewed by Jer Noble.

No new tests because this code path only happens with a user action on system UI.

When exiting PiP, notify the fullscreen change observer so it can restore client UI state before exiting.

  • platform/mac/VideoFullscreenInterfaceMac.mm:

(-[WebVideoFullscreenInterfaceMacObjC pipShouldClose:]):

10:08 AM Changeset in webkit [239446] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebKit

Enable MediaCapabilities by default.
https://bugs.webkit.org/show_bug.cgi?id=192340
<rdar://problem/46435149>

Reviewed by Dean Jackson.

  • Shared/WebPreferences.yaml:
9:45 AM Changeset in webkit [239445] by commit-queue@webkit.org
  • 2 edits in trunk/Source/WebDriver

WebDriver: Session::findElements should handle user prompts
https://bugs.webkit.org/show_bug.cgi?id=192928

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2018-12-20
Reviewed by Michael Catanzaro.

All user prompt tests for commands using Session::findElements are failing because of this.

  • Session.cpp:

(WebDriver::Session::findElements):

9:44 AM Changeset in webkit [239444] by commit-queue@webkit.org
  • 4 edits in trunk/Source

[GTK] WebDriver: tests in imported/w3c/webdriver/tests/element_clear/user_prompts.py are failing
https://bugs.webkit.org/show_bug.cgi?id=192927

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2018-12-20
Reviewed by Michael Catanzaro.

Source/WebDriver:

Handle user prompts in element clear command.

  • Session.cpp:

(WebDriver::Session::elementClear):

Source/WebKit:

Give the focus back to the web view when a dialog is dismissed.

  • UIProcess/API/gtk/WebKitWebViewBase.cpp:

(webkitWebViewBaseContainerRemove):

9:37 AM Changeset in webkit [239443] by Devin Rousso
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: unreadable background color for tables containing object previews
https://bugs.webkit.org/show_bug.cgi?id=192887
<rdar://problem/46855270>

Reviewed by Brian Burg.

  • UserInterface/Views/LogContentView.css:

(.console-messages:focus .console-item .data-grid tr.selected td:not(:last-child)): Added.
(@media (prefers-dark-interface) .console-item .data-grid tr.selected): Added.
(@media (prefers-dark-interface) .console-messages:focus .console-item.selected .data-grid tr.selected): Added.
(@media (prefers-dark-interface) .console-messages:focus .console-item .data-grid tr.selected td:not(:last-child)): Added.

  • UserInterface/Views/IndexedDatabaseObjectStoreContentView.css:

(.content-view.indexed-database-object-store > .data-grid tr.selected):
(.content-view.indexed-database-object-store > .data-grid:focus tr.selected): Added.
(@media (prefers-dark-interface) .content-view.indexed-database-object-store > .data-grid tr.selected): Added.
(@media (prefers-dark-interface) .content-view.indexed-database-object-store > .data-grid:focus tr.selected): Added.
(@media (prefers-dark-interface) .content-view.indexed-database-object-store > .data-grid:focus tr.selected td:not(:last-child)): Added.

9:35 AM Changeset in webkit [239442] by timothy_horton@apple.com
  • 4 edits
    1 add in trunk

Unparented WKWebView can't retrieve main resource data for a main frame plugin
https://bugs.webkit.org/show_bug.cgi?id=192923
<rdar://problem/46859068>

Reviewed by Wenson Hsieh.

Source/WebKit:

  • WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::liveResourceData const):
If the WKWebView is unparented, we may not immediately initialize the plugin.
In that case, PluginView holds on to the backing data until the plugin
is initialized. If a WKWebView API client asks for the backing data
for the plugin during this time, we should return it, instead of bailing.

Tools:

  • TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
  • TestWebKitAPI/WebKitCocoa/GetResourceData.mm:

Add a test ensuring that both parented and unparented WKWebViews can
retrieve main resource data when loading a PDF.

8:28 AM Changeset in webkit [239441] by wenson_hsieh@apple.com
  • 13 edits
    2 adds in trunk

[iOS] Focusing an editable element should scroll to reveal the selection
https://bugs.webkit.org/show_bug.cgi?id=192802
<rdar://problem/46781759>

Reviewed by Tim Horton.

Source/WebKit:

Currently, when tapping on an editable element, logic in -[WKWebView _zoomToFocusRect:…:] attempts to adjust the
visible viewport such that the rect containing the selection is visible. However, AssistedNodeInformation's
selectionRect is used here, which (as the FIXME in WebPage::getAssistedNodeInformation notes) is either the last
touch location, or the top left of the element if the touch location is outside of the element's bounding rect.
This leads to confusing and undesirable behavior when tapping near the bottom of a large contenteditable element
to focus it, since the actual selection will end up near the top of the element, yet we'll try to scroll to
reveal the bottom of the element, which causes the visible selection to scroll offscreen. Notably, this affects
scenarios involving editable web views embedded in apps, such as Mail compose.

Right now, we use the last touch location as an approximation for the selection rect because the selection may
have not yet been updated at the moment when focus moves into an editable element. To fix this, we defer the
process of zooming to the focused element rect until after the selection changes and the UI process is updated
with information about the new selection rects.

Test: editing/selection/ios/selection-is-visible-after-focusing-editable-area.html

  • Shared/AssistedNodeInformation.cpp:

(WebKit::AssistedNodeInformation::encode const):
(WebKit::AssistedNodeInformation::decode):

  • Shared/AssistedNodeInformation.h:

Rename selectionRect to elementInteractionLocation, to more accurately reflect its value and purpose. This isn't
strictly always the last touch location, since we may default to the focused element location instead if the
last touch location is outside of the element rect.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _zoomToFocusRect:selectionRect:insideFixed:fontSize:minimumScale:maximumScale:allowScaling:forceScroll:]):

Tweak a constant that determines the minimum amount of margin to leave between the selection rect and the edge
of the window when scrolling to reveal the focused element. Previously, this was larger than necessary to
accomodate for the fact that the "selection rect" used when zooming to the focused element did not take the
actual selection into account at all, and was simply a 1 by 1 rect; this meant that the margin needed to be
large enough to exceed the usual height of a text caret in editable content. Since we now use the real selection
rect, we can be much less generous with this margin.

  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView cleanupInteraction]):
(-[WKContentView observeValueForKeyPath:ofObject:change:context:]):

Don't additionally update the selection in the middle of triggering zooming to the focused element; on
particular versions of iOS, this now attempts to scroll the selection rect on-screen, which then conflicts with
zooming to reveal the focused element.

(-[WKContentView _zoomToRevealFocusedElement]):

Renamed from _displayFormNodeInputView to _zoomToRevealFocusedElement, to make the purpose of this function more
clear. Additionally, pull logic to update the accessory view out of this method, so that it's strictly concerned
with zooming to the focused element.

(-[WKContentView inputView]):

Add a FIXME describing the implications of zooming to the focused element in the implementation of -inputView.
See also: <https://bugs.webkit.org/show_bug.cgi?id=192878>.

(-[WKContentView accessoryTab:]):

Fix a subtle issue when keeping track of _didAccessoryTabInitiateFocus. Currently, this is set to YES in
-accessoryTab: and unset in _displayFormNodeInputView, but since _displayFormNodeInputView may be invoked
multiple times for the same focused element (see: -inputView), we might end up zooming to the focused element
with _didAccessoryTabInitiateFocus set to NO, even though we initiated focus with the previous/next buttons.

Instead, temporarily set a different ivar, _isChangingFocusUsingAccessoryTab, to YES in -accessoryTab:, and
unset it in the completion handler after the focused element has changed. Then, when we _startAssistingNode:,
set _didAccessoryTabInitiateFocus to _isChangingFocusUsingAccessoryTab. This ensures that the correctness of
_didAccessoryTabInitiateFocus isn't tied to the number of times -[WKContentView inputView] is invoked when
focusing an element.

(shouldZoomToRevealSelectionRect):
(rectToRevealWhenZoomingToFocusedElement):

Add a helper method to determine the selection rect to use when zooming to reveal the focused element. ASSERTs
that we have post-layout data in the EditorState.

(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):

When "assisting" a focused element, immediately zoom to it if we don't need selection information to compute the
rect to zoom to; otherwise, defer zooming until we receive the first editor state update in the UI process that
contains information about our selection rects.

(-[WKContentView _stopAssistingNode]):
(-[WKContentView _didReceiveEditorStateUpdateAfterFocus]):

If necessary, reveal the focused element by zooming.

(-[WKContentView _updateInitialWritingDirectionIfNecessary]):

Pull this initial writing direction update logic out into a separate helper method.

(-[WKContentView _displayFormNodeInputView]): Deleted.

Replaced by _zoomToRevealFocusedElement.

  • WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::elementDidRefocus):

This currently calls WebChromeClient::elementDidFocus; instead, call the new WebPage::elementDidRefocus;
additionally, make this available on all PLATFORM(COCOA), rather than just IOS_FAMILY.

  • WebProcess/WebCoreSupport/WebChromeClient.h:
  • WebProcess/WebCoreSupport/ios/WebChromeClientIOS.mm:

(WebKit::WebChromeClient::elementDidRefocus): Deleted.

Replaced by the PLATFORM(COCOA) version.

  • WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::elementDidRefocus):

When refocusing an element, ensure that post-layout editor state data is sent to the UI process by including a
full EditorState in the next layer tree transaction.

  • WebProcess/WebPage/WebPage.h:
  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::completeSyntheticClick):

Call elementDidRefocus instead of elementDidFocus, in the case where the existing focused element is clicked.

(WebKit::WebPage::getAssistedNodeInformation):

Adjust for the change from selectionRect to elementInteractionLocation.

LayoutTests:

Adds a new layout test to verify that tapping near the bottom of a tall editable element to focus it doesn't
cause the page to scroll up (and, as a result, leave the selection caret obscured).

  • editing/selection/ios/selection-is-visible-after-focusing-editable-area-expected.txt: Added.
  • editing/selection/ios/selection-is-visible-after-focusing-editable-area.html: Added.
8:18 AM Changeset in webkit [239440] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebKit

[GTK][WPE] Grant the sandbox read access to XDG_DATA_HOME/prgname
https://bugs.webkit.org/show_bug.cgi?id=192929

Patch by Patrick Griffis <Patrick Griffis> on 2018-12-20
Reviewed by Michael Catanzaro.

  • UIProcess/API/glib/WebKitWebContext.cpp:
  • UIProcess/Launcher/glib/BubblewrapLauncher.cpp:

(WebKit::bubblewrapSpawn):

8:06 AM Changeset in webkit [239439] by Tadeu Zagallo
  • 6 edits
    1 add in trunk

JSTests:
WTF::String and StringImpl overflow MaxLength
https://bugs.webkit.org/show_bug.cgi?id=192853
<rdar://problem/45726906>

Reviewed by Mark Lam.

  • stress/string-16bit-repeat-overflow.js: Added.

(catch):

Source/WTF:
Consistently use MaxLength for all WTF strings
https://bugs.webkit.org/show_bug.cgi?id=192853
<rdar://problem/45726906>

Reviewed by Mark Lam.

MaxLength was introduced to be INT_MAX for WTF::String and StringImpl,
but all the assertions were still done using UINT_MAX. Change it to
use MaxLength for all checks.

  • wtf/text/StringImpl.cpp:

(WTF::StringImpl::createUninitializedInternalNonEmpty):
(WTF::StringImpl::reallocateInternal):
(WTF::StringImpl::create):
(WTF::StringImpl::convertToLowercaseWithoutLocale):
(WTF::StringImpl::convertToUppercaseWithoutLocale):
(WTF::StringImpl::convertToLowercaseWithLocale):
(WTF::StringImpl::convertToUppercaseWithLocale):
(WTF::StringImpl::foldCase):
(WTF::StringImpl::find):
(WTF::StringImpl::replace):
(WTF::StringImpl::utf8ForCharacters):
(WTF::StringImpl::tryGetUtf8ForRange const):

  • wtf/text/StringImpl.h:

(WTF::lengthOfNullTerminatedString):
(WTF::StringImpl::tryCreateUninitialized):
(WTF::StringImpl::adopt):
(WTF::StringImpl::maxInternalLength):

  • wtf/text/WTFString.cpp:

(WTF::String::append):
(WTF::String::insert):
(WTF::String::fromUTF8):

  • wtf/text/WTFString.h:

(WTF::String::reverseFind const):

3:59 AM Changeset in webkit [239438] by Caio Lima
  • 5 edits
    3 adds in trunk

[BigInt] We should enable CSE into arithmetic operations that speculate BigIntUse
https://bugs.webkit.org/show_bug.cgi?id=192723

Reviewed by Yusuke Suzuki.

PerformanceTests:

  • BigIntBench/big-int-cse.js: Added.
  • BigIntBench/big-int-global-cse.js: Added.
  • BigIntBench/big-int-licm.js: Added.

Source/JavaScriptCore:

This patch is adjusting clobberize rules into ValueOp nodes to enable
more optimizations when we speculate BigIntUse. In such case, DFG now
is able to apply CSE, LICM and commutativity on nodes like
ValueAdd(BigInt, BigInt), ValueSub(BigInt, BigInt), etc.

Here are the numbers we can observe with some microbenchmarks:

baseline changes

big-int-cse 108.2733+-0.8445 80.9897+-4.9781 definitely 1.3369x faster
big-int-licm 75.6641+-0.3477 57.8144+-1.6043 definitely 1.3087x faster
big-int-global-cse 145.3557+-1.0552 86.5866+-0.3025 definitely 1.6787x faster

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

1:12 AM Changeset in webkit [239437] by Chris Dumez
  • 3 edits in trunk/Source/WebKit

[PSON] SuspendedPageProxy fails to release its process assertion if the WebPage fails to enter PageCache
https://bugs.webkit.org/show_bug.cgi?id=192873

Reviewed by Antti Koivisto.

SuspendedPageProxy fails to release its process assertion if the WebPage fails to enter PageCache, preventing
the process from suspending on iOS.

  • UIProcess/SuspendedPageProxy.cpp:

(WebKit::SuspendedPageProxy::didProcessRequestToSuspend):
(WebKit::SuspendedPageProxy::didReceiveMessage):
(WebKit::SuspendedPageProxy::didSuspend): Deleted.
(WebKit::SuspendedPageProxy::didFailToSuspend): Deleted.

  • UIProcess/SuspendedPageProxy.h:
12:45 AM Changeset in webkit [239436] by commit-queue@webkit.org
  • 4 edits in trunk/Tools

[GTK][WPE] Bump webkitgtk-test-fonts to 0.0.8
https://bugs.webkit.org/show_bug.cgi?id=192852

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2018-12-20
Reviewed by Michael Catanzaro.

EmojiOne font was replaced by Noto Color Emoji.

  • WebKitTestRunner/gtk/fonts/fonts.conf: Use Noto Color Emoji when Apple Color Emoji font family is used in tests.
  • gtk/jhbuild.modules:
  • wpe/jhbuild.modules:

Dec 19, 2018:

11:36 PM Changeset in webkit [239435] by commit-queue@webkit.org
  • 5 edits
    3 deletes in trunk

Unreviewed, rolling out r239377.
https://bugs.webkit.org/show_bug.cgi?id=192921

broke 32-bit JSC tests (Requested by keith_miller on #webkit).

Reverted changeset:

"[BigInt] We should enable CSE into arithmetic operations that
speculate BigIntUse"
https://bugs.webkit.org/show_bug.cgi?id=192723
https://trac.webkit.org/changeset/239377

11:01 PM Changeset in webkit [239434] by mitz@apple.com
  • 9 copies
    1 add in releases/Apple/Safari Technology Preview 72

Added a tag for Safari Technology Preview release 72.

10:48 PM Changeset in webkit [239433] by Devin Rousso
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Audit: fix descriptions for default tests
https://bugs.webkit.org/show_bug.cgi?id=192764
<rdar://problem/46729437>

Reviewed by Matt Baker.

  • UserInterface/Controllers/AuditManager.js:

(WI.AuditManager.prototype.addDefaultTestsIfNeeded):

  • Localizations/en.lproj/localizedStrings.js:
10:39 PM Changeset in webkit [239432] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: "E" icon on debugger dashboard is too close to current function name
https://bugs.webkit.org/show_bug.cgi?id=192915

Reviewed by Matt Baker.

  • UserInterface/Views/DebuggerDashboardView.css:

(.dashboard.debugger > .location):
(body[dir=ltr] .dashboard.debugger > .location :matches(.function-icon, .event-listener-icon)):
(body[dir=rtl] .dashboard.debugger > .location :matches(.function-icon, .event-listener-icon)):
(.dashboard.debugger > .location .function-icon): Deleted.
(body[dir=ltr] .dashboard.debugger > .location .function-icon): Deleted.
(body[dir=rtl] .dashboard.debugger > .location .function-icon): Deleted.

10:24 PM Changeset in webkit [239431] by Ross Kirsling
  • 2 edits in trunk/JSTests

Unreviewed follow-up to r192914.

  • test262/expectations.yaml:

Add the last 20 missing expectations.

10:21 PM Changeset in webkit [239430] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: ThreadTreeElement status icon is hard to see when hovered
https://bugs.webkit.org/show_bug.cgi?id=192097
<rdar://problem/46318421>

Reviewed by Matt Baker.

  • UserInterface/Views/ThreadTreeElement.css:

(.tree-outline > .item.thread .status-button.resume):
(.tree-outline > .item.thread .status-button.resume:active):

9:00 PM Changeset in webkit [239429] by keith_miller@apple.com
  • 2 edits in trunk/JSTests

Fix test262 expectations
https://bugs.webkit.org/show_bug.cgi?id=192914

Unreviewed, when I imported the latest round of test262 tests I must have failed to update the test expectations.

  • test262/expectations.yaml:
8:46 PM Changeset in webkit [239428] by Michael Catanzaro
  • 2 edits in trunk/Source/WebCore

Unreviewed, fix GTK build after r239410

It added a new file to the build, breaking the unified sources magic that obscured a bug in
URLSoup.h. It forward-declares URL, but this never worked unless the URL.h header was
included via another source file in the unified source bundle.

  • platform/network/soup/URLSoup.h:
8:41 PM Changeset in webkit [239427] by Chris Dumez
  • 1745 edits in trunk

wtf/Optional.h: move-constructor and move-assignment operator should disengage the value being moved from
https://bugs.webkit.org/show_bug.cgi?id=192728
<rdar://problem/46746779>

Reviewed by Geoff Garen.

Source/JavaScriptCore:

  • API/*:
  • Scripts/*:
  • assembler/*:
  • b3/*:
  • bytecode/*:
  • bytecompiler/*:
  • debugger/*:
  • dfg/*:
  • ftl/*:
  • heap/*:
  • inspector/*:
  • jit/*:
  • llint/*:
  • parser/*:
  • runtime/*:
  • tools/*:
  • wasm/*:
  • yarr/*:

Source/WebCore:

  • Modules/*:
  • animation/*:
  • bindings/*:
  • crypto/*:
  • css/*:
  • dom/*:
  • editing/*:
  • fileapi/*:
  • html/*:
  • inspector/*:
  • layout/*:
  • loader/*:
  • mathml/*:
  • page/*:
  • platform/*:
  • plugins/*:
  • rendering/*:
  • testing/*:
  • workers/*:
  • xml/*:

Source/WebCore/PAL:

  • pal/*:

Source/WebDriver:

  • :

Source/WebKit:

  • NetworkProcess/*:
  • Platform/*:
  • Scripts/*:
  • Shared/*:
  • UIProcess/*:
  • WebProcess/*:

Source/WebKitLegacy/mac:

  • DOM/*:
  • Plugins/*:
  • WebCoreSupport/*:
  • WebView/*:

Source/WebKitLegacy/win:

  • Plugins/*:
  • WebCoreSupport/*:

Source/WTF:

Update optional's move-constructor and move-assignment operator to disengage the value being moved from.
Rename to optional to Optional, make_optional() to makeOptional(), and move class from std to WTF namespace.

Based on patch by David Kilzer.

  • wtf/*:

Tools:

  • DumpRenderTree/*:
  • MiniBrowser/*:
  • TestRunnerShared/*:
  • TestWebKitAPI/*:
  • WebGPUAPIStructure/*:
  • WebKitTestRunner/*:
8:26 PM Changeset in webkit [239426] by Michael Catanzaro
  • 2 edits in trunk/Source/WebKit

Unreviewed, silence -Wpragmas warning

  • WebProcess/WebCoreSupport/WebAlternativeTextClient.h:
8:17 PM Changeset in webkit [239425] by keith_miller@apple.com
  • 3391 edits
    5249 adds in trunk/JSTests

Update test262 tests.
https://bugs.webkit.org/show_bug.cgi?id=192907

Rubber stamped by Mark Lam.

  • test262/*: Omitted because prepare-changelog crashes.
8:11 PM Changeset in webkit [239424] by Ross Kirsling
  • 2 edits in trunk/LayoutTests

[WinCairo] Unreviewed test gardening.

  • platform/wincairo/TestExpectations:
8:04 PM Changeset in webkit [239423] by commit-queue@webkit.org
  • 6 edits
    2 adds in trunk/Source/WebKit

HTTPS Upgrade: Use full sqlite upgrade list
https://bugs.webkit.org/show_bug.cgi?id=192736
<rdar://problem/45851427>

Patch by Vivek Seth <v_seth@apple.com> on 2018-12-19
Reviewed by Chris Dumez.

  • NetworkProcess/NetworkHTTPSUpgradeChecker.cpp: Added.

(WebKit::NetworkHTTPSUpgradeCheckerDatabasePath):
(WebKit::NetworkHTTPSUpgradeChecker::NetworkHTTPSUpgradeChecker):
(WebKit::NetworkHTTPSUpgradeChecker::~NetworkHTTPSUpgradeChecker):
(WebKit::NetworkHTTPSUpgradeChecker::query):
(WebKit::NetworkHTTPSUpgradeChecker::isAlwaysOnLoggingAllowed const):

  • NetworkProcess/NetworkHTTPSUpgradeChecker.h: Added.

(WebKit::NetworkHTTPSUpgradeChecker::didSetupCompleteSuccessfully const):

  • NetworkProcess/NetworkLoadChecker.cpp:

(WebKit::NetworkLoadChecker::applyHTTPSUpgradeIfNeeded const):
(WebKit::NetworkLoadChecker::checkRequest):

  • NetworkProcess/NetworkLoadChecker.h:
  • NetworkProcess/NetworkProcess.h:

(WebKit::NetworkProcess::networkHTTPSUpgradeChecker):

  • Sources.txt:
  • WebKit.xcodeproj/project.pbxproj:
8:00 PM Changeset in webkit [239422] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'effectiveDOMNode.enabledPseudoClasses')
https://bugs.webkit.org/show_bug.cgi?id=192783

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/GeneralStyleDetailsSidebarPanel.js:

(WI.GeneralStyleDetailsSidebarPanel.prototype._forcedPseudoClassCheckboxChanged):
(WI.GeneralStyleDetailsSidebarPanel.prototype._updatePseudoClassCheckboxes):

7:57 PM Changeset in webkit [239421] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: REGRESSION (r237195): Timelines: selecting a rendering frame row moves the time selection
https://bugs.webkit.org/show_bug.cgi?id=192773
<rdar://problem/46782446>

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/TimelineOverview.js:

(WI.TimelineOverview.prototype._recordSelected):
The Frames timeline uses frameIndex instead of startTime/endTime, so when trying to
ensure that the selected record is within the filtered range, use frameIndex instead.
The associated WI.TimelineRuler will already be using an index-based approach for
selection, so this will match.

7:56 PM Changeset in webkit [239420] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Canvas: the recording auto-capture input shouldn't start focused
https://bugs.webkit.org/show_bug.cgi?id=192454

Reviewed by Joseph Pecoraro.

  • UserInterface/Views/CanvasOverviewContentView.js:

(WI.CanvasOverviewContentView.prototype._updateRecordingAutoCaptureCheckboxLabel):
(WI.CanvasOverviewContentView.prototype._handleCanvasRecordingAutoCaptureFrameCountChanged):

7:24 PM Changeset in webkit [239419] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Leak of MTAudioProcessingTap (304 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
https://bugs.webkit.org/show_bug.cgi?id=192896
<rdar://46732186>

Reviewed by Eric Carlson.

  • platform/graphics/avfoundation/AudioSourceProviderAVFObjC.mm:

(WebCore::AudioSourceProviderAVFObjC::initCallback):

5:45 PM Changeset in webkit [239418] by youenn@apple.com
  • 100 edits
    35 deletes in trunk/Source/ThirdParty/libwebrtc

Refresh usrsctplib to M72
https://bugs.webkit.org/show_bug.cgi?id=192863

Reviewed by Alex Christensen.

  • Source/third_party/usrsctp/: Resynced to Chrome M72 branch.
5:41 PM Changeset in webkit [239417] by benjamin@webkit.org
  • 7 edits in trunk

<rdar://problem/46194315> macOS: WebKit1 does not handle occlusion changes
https://bugs.webkit.org/show_bug.cgi?id=192821

Reviewed by Chris Dumez.

Source/WebKitLegacy/mac:

When a window becomes occluded, the window server informs the application.
This should be used to suspend any work that is not visible by the user.

WebKit2 handles it just fine, but WebKit1 did not handle the notification.
In some cases, that lead to performance impact (see radar).

This patch adds an observer for the occlusion notification. I tried to stick
with the same names used by WebKit2.

  • WebView/WebView.mm:

(-[WebView _isViewVisible]):
(-[WebView addWindowObserversForWindow:]):
(-[WebView removeWindowObservers]):
(-[WebView _windowDidChangeOcclusionState:]):

Tools:

  • DumpRenderTree/mac/DumpRenderTree.mm:

(createWebViewAndOffscreenWindow):

5:40 PM Changeset in webkit [239416] by aboya@igalia.com
  • 18 edits
    5 copies
    3 adds
    2 deletes in trunk/LayoutTests

[GTK][WPE] Unreviewed test gardening.
https://bugs.webkit.org/show_bug.cgi?id=192904

  • platform/gtk/TestExpectations:
  • platform/gtk/animations/lineheight-animation-expected.txt: Copied from LayoutTests/platform/wpe/legacy-animation-engine/animations/lineheight-animation-expected.txt.
  • platform/gtk/animations/simultaneous-start-transform-expected.txt: Copied from LayoutTests/platform/wpe/legacy-animation-engine/animations/simultaneous-start-transform-expected.txt.
  • platform/gtk/animations/width-using-ems-expected.txt: Copied from LayoutTests/platform/wpe/legacy-animation-engine/animations/width-using-ems-expected.txt.
  • platform/gtk/css1/font_properties/font-expected.txt:
  • platform/gtk/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • platform/gtk/css2.1/t1508-c527-font-00-b-expected.txt:
  • platform/gtk/css2.1/t1508-c527-font-06-b-expected.txt:
  • platform/gtk/css2.1/t1508-c527-font-10-c-expected.txt:
  • platform/gtk/fast/inline/inline-content-with-image-simple-expected.txt: Added.
  • platform/gtk/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt:
  • platform/gtk/imported/w3c/web-platform-tests/eventsource/format-mime-bogus-expected.txt: Removed.
  • platform/gtk/legacy-animation-engine/animations/lineheight-animation-expected.txt: Added.
  • platform/gtk/legacy-animation-engine/animations/simultaneous-start-transform-expected.txt: Copied from LayoutTests/platform/wpe/legacy-animation-engine/animations/simultaneous-start-transform-expected.txt.
  • platform/gtk/legacy-animation-engine/animations/width-using-ems-expected.txt: Copied from LayoutTests/platform/wpe/legacy-animation-engine/animations/width-using-ems-expected.txt.
  • platform/wpe/TestExpectations:
  • platform/wpe/css1/font_properties/font-expected.txt:
  • platform/wpe/css1/pseudo/multiple_pseudo_elements-expected.txt:
  • platform/wpe/css2.1/t1508-c527-font-00-b-expected.txt:
  • platform/wpe/css2.1/t1508-c527-font-06-b-expected.txt:
  • platform/wpe/css2.1/t1508-c527-font-10-c-expected.txt:
  • platform/wpe/fast/inline/inline-content-with-image-simple-expected.txt: Added.
  • platform/wpe/imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-invalid-args-expected.txt:
  • platform/wpe/imported/w3c/web-platform-tests/eventsource/format-mime-bogus-expected.txt: Removed.
  • platform/wpe/legacy-animation-engine/animations/lineheight-animation-expected.txt:
  • platform/wpe/legacy-animation-engine/animations/simultaneous-start-transform-expected.txt:
  • platform/wpe/legacy-animation-engine/animations/width-using-ems-expected.txt:
5:37 PM Changeset in webkit [239415] by youenn@apple.com
  • 63 edits
    1 move
    9 adds
    7 deletes in trunk/Source/ThirdParty/libwebrtc

Refresh libyuv to M72
https://bugs.webkit.org/show_bug.cgi?id=192864

Reviewed by Alex Christensen.

  • Source/third_party/libyuv: Resynced.
5:28 PM Changeset in webkit [239414] by timothy@apple.com
  • 2 edits in trunk/Source/WebCore

REGRESSION (r232991): Switching to dark mode in Mail does not update the message view to be transparent
https://bugs.webkit.org/show_bug.cgi?id=188891
rdar://problem/42344352

Reviewed by Simon Fraser.

  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::rootBackgroundColorOrTransparencyChanged):
Don't return early when m_layerForOverhangAreas is null to avoid skipping
setRootLayerConfigurationNeedsUpdate() and scheduleCompositingLayerUpdate().

5:22 PM Changeset in webkit [239413] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Styles: shift-clicking a color-swatch to change formats starts editing the color
https://bugs.webkit.org/show_bug.cgi?id=192784
<rdar://problem/46801028>

Reviewed by Devin Rousso.

  • UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype._createInlineSwatch):

5:22 PM Changeset in webkit [239412] by Alan Coon
  • 1 edit in branches/safari-606-branch/Source/WebKit/UIProcess/ResourceLoadStatisticsMemoryStore.cpp

Apply patch. rdar://problem/46848447

5:09 PM Changeset in webkit [239411] by timothy_horton@apple.com
  • 2 edits in trunk/Source/WebKit

Use delegate instead of drawingDelegate in WKDrawingView
https://bugs.webkit.org/show_bug.cgi?id=192899
<rdar://problem/46733339>

Reviewed by Wenson Hsieh.

  • UIProcess/ios/WKDrawingView.mm:

(-[WKDrawingView initWithEmbeddedViewID:webPageProxy:]):
Do the dance.

4:59 PM Changeset in webkit [239410] by Justin Fan
  • 17 edits
    8 copies
    1 move
    1 add
    1 delete in trunk

[WebGPU] Add stubs for WebGPUPipelineLayout/Descriptor and device::createPipelineLayout
https://bugs.webkit.org/show_bug.cgi?id=192843
<rdar://problem/46820395>

Reviewed by Myles Maxfield.

Source/WebCore:

Test: webgpu/pipeline-layouts.html

Implement the emtpy WebGPUPipelineLayout interface, and enable creation via WebGPUDevice::createPipelineLayout:

  • Modules/webgpu/WebGPUBindGroupLayout.cpp:

(WebCore::WebGPUBindGroupLayout::WebGPUBindGroupLayout):

  • Modules/webgpu/WebGPUBindGroupLayout.h:

(WebCore::WebGPUBindGroupLayout::bindGroupLayout const): Added getter.

  • Modules/webgpu/WebGPUDevice.cpp:

(WebCore::WebGPUDevice::createPipelineLayout const): Added.

  • Modules/webgpu/WebGPUDevice.h:
  • Modules/webgpu/WebGPUDevice.idl: Enable createPipelineLayout.
  • Modules/webgpu/WebGPUPipelineLayout.cpp: Added.

(WebCore::WebGPUPipelineLayout::create):
(WebCore::WebGPUPipelineLayout::WebGPUPipelineLayout):

  • Modules/webgpu/WebGPUPipelineLayout.h: Added.
  • Modules/webgpu/WebGPUPipelineLayout.idl: Added.
  • Modules/webgpu/WebGPUPipelineLayoutDescriptor.h: Added.
  • Modules/webgpu/WebGPUPipelineLayoutDescriptor.idl: Added.
  • platform/graphics/gpu/GPUDevice.cpp:

(WebCore::GPUDevice::createPipelineLayout const): Added.

  • platform/graphics/gpu/GPUDevice.h:
  • platform/graphics/gpu/GPUPipelineLayout.cpp: Added.

(WebCore::GPUPipelineLayout::create):
(WebCore::GPUPipelineLayout::GPUPipelineLayout):

  • platform/graphics/gpu/GPUPipelineLayout.h: Added.
  • platform/graphics/gpu/GPUPipelineLayoutDescriptor.h: Added.

Add files and symbols to project:

  • CMakeLists.txt:
  • DerivedSources.make:
  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
  • bindings/js/WebCoreBuiltinNames.h:

Add missing include:

  • Modules/webgpu/WebGPUQueue.h:

LayoutTests:

Update bind-group-layouts and rename to match new PipelineLayout functionality.

  • webgpu/bind-group-layouts-expected.txt: Removed.
  • webgpu/pipeline-layouts-expected.txt: Added.
  • webgpu/pipeline-layouts.html: Renamed from LayoutTests/webgpu/bind-group-layouts.html.
4:58 PM Changeset in webkit [239409] by Alan Coon
  • 18 edits in branches/safari-606-branch/Source

Apply patch. rdar://problem/46848447

4:55 PM Changeset in webkit [239408] by achristensen@apple.com
  • 19 edits in trunk

Navigations away from the SafeBrowsing interstitial show a flash of old content
https://bugs.webkit.org/show_bug.cgi?id=192676

Reviewed by Chris Dumez.

Source/WebKit:

When a user clicks through a safe browsing warning, do not remove the warning until content is drawn for the destination.
Otherwise, the user will confusingly see the page before the warning while the navigation happens.
We can only do this for warnings caused by main frame navigations, though. Other warnings (such as those caused by iframes)
need to be cleared immediately, and we still need to clear the warning immediately if the user has said to go back.

This change is reflected in an updated API test.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _showSafeBrowsingWarning:completionHandler:]):

  • UIProcess/Cocoa/SafeBrowsingWarningCocoa.mm:

(WebKit::SafeBrowsingWarning::SafeBrowsingWarning):

  • UIProcess/Cocoa/WKSafeBrowsingWarning.h:
  • UIProcess/Cocoa/WKSafeBrowsingWarning.mm:

(-[WKSafeBrowsingWarning forMainFrameNavigation]):

  • UIProcess/Cocoa/WebPageProxyCocoa.mm:

(WebKit::WebPageProxy::beginSafeBrowsingCheck):

  • UIProcess/Cocoa/WebViewImpl.h:
  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::showSafeBrowsingWarning):
(WebKit::WebViewImpl::clearSafeBrowsingWarningIfForMainFrameNavigation):

  • UIProcess/PageClient.h:

(WebKit::PageClient::clearSafeBrowsingWarningIfForMainFrameNavigation):

  • UIProcess/SafeBrowsingWarning.h:

(WebKit::SafeBrowsingWarning::create):
(WebKit::SafeBrowsingWarning::forMainFrameNavigation const):

  • UIProcess/WebPageProxy.cpp:

(WebKit::WebPageProxy::didReachLayoutMilestone):
(WebKit::WebPageProxy::beginSafeBrowsingCheck):
(WebKit::WebPageProxy::decidePolicyForNavigationAction):

  • UIProcess/WebPageProxy.h:
  • UIProcess/ios/PageClientImplIOS.h:
  • UIProcess/mac/PageClientImplMac.h:
  • UIProcess/mac/PageClientImplMac.mm:

(WebKit::PageClientImpl::clearSafeBrowsingWarningIfForMainFrameNavigation):

Tools:

  • TestWebKitAPI/Tests/WebKitCocoa/SafeBrowsing.mm:

(safeBrowsingView):
(TEST):
(-[SafeBrowsingHelper webView:runJavaScriptAlertPanelWithMessage:initiatedByFrame:completionHandler:]): Deleted.

4:54 PM Changeset in webkit [239407] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

REGRESSION: [ iOS Sim ] Layout Test imported/w3c/web-platform-tests/service-workers/service-worker/update-missing-import-scripts.https.html is failing
https://bugs.webkit.org/show_bug.cgi?id=192250

Unreviewed test gardening.

  • platform/ios/TestExpectations: Mark test as flaky.
4:54 PM Changeset in webkit [239406] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

REGRESSION: imported/w3c/web-platform-tests/service-workers/service-worker/register-closed-window.https.html is very flaky on iOS
https://bugs.webkit.org/show_bug.cgi?id=192279

Unreviewed test gardening.

  • platform/ios/TestExpectations: Mark test as flaky.
4:46 PM Changeset in webkit [239405] by Matt Baker
  • 3 edits in trunk/Source/WebInspectorUI

Web Inspector: Elements tab: arrow key after undoing a DOM node delete selects the wrong element
https://bugs.webkit.org/show_bug.cgi?id=192871
<rdar://problem/46849060>

Reviewed by Devin Rousso.

Undoing a DOM node removal reinserts the node into the DOMTreeOutline.
When the reinserted node precedes the selected node in the tree, the
SelectionController should update _lastSelectedIndex.

  • UserInterface/Controllers/SelectionController.js:

(WI.SelectionController.prototype.didInsertItem):

4:31 PM Changeset in webkit [239404] by Devin Rousso
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Audit: provide localization support for % pass display
https://bugs.webkit.org/show_bug.cgi?id=192870
<rdar://problem/46779245>

Reviewed by Brian Burg.

  • UserInterface/Views/AuditTestGroupContentView.js:

(WI.AuditTestGroupContentView.prototype.initialLayout):
(WI.AuditTestGroupContentView.prototype.layout):

  • UserInterface/Views/AuditTestGroupContentView.css:

(.content-view.audit-test-group > header > .percentage-pass):
(.content-view.audit-test-group > header > .percentage-pass > span): Added.
(@media (prefers-dark-interface) .content-view.audit-test-group > header > .percentage-pass): Added.
(@media (prefers-dark-interface) .content-view.audit-test-group > header > .percentage-pass > span): Added.
(.content-view.audit-test-group > header > .percentage-pass:not(:empty)::after): Deleted.

  • Localizations/en.lproj/localizedStrings.js:
4:07 PM Changeset in webkit [239403] by Alan Coon
  • 16 edits
    2 adds in branches/safari-606-branch

Apply patch. rdar://problem/46848447

3:51 PM Changeset in webkit [239402] by rniwa@webkit.org
  • 2 edits in trunk/Source/WebCore

SVGUseElement::findTarget should return nullptr when there is a cycle
https://bugs.webkit.org/show_bug.cgi?id=192840

Reviewed by Tim Horton.

r233366 added an early return to updateShadowTree() when there is a cycle between an use element and its target.
Consolidate this cycle detection code with the one in SVGUseElement::findTarget which detected cycles when
the SVG use element itself had a corresponding element.

No new tests since there should be no behavioral change.

  • svg/SVGUseElement.cpp:

(WebCore::SVGUseElement::updateShadowTree):
(WebCore::SVGUseElement::findTarget const):

3:44 PM Changeset in webkit [239401] by Adrian Perez de Castro
  • 3 edits in trunk/Tools

[GTK][WPE] Unify TestController::platformRunUntil() and honor condition flag
https://bugs.webkit.org/show_bug.cgi?id=192855

Reviewed by Michael Catanzaro.

  • WebKitTestRunner/gtk/TestControllerGtk.cpp:

(WTR::TestController::notifyDone): Use the WPE implementation.
(WTR::TestController::platformRunUntil): Use the WPE implementation.

  • WebKitTestRunner/wpe/TestControllerWPE.cpp:

(WTR::TestController::platformRunUntil): Honor the condition flag.

3:37 PM Changeset in webkit [239400] by timothy_horton@apple.com
  • 7 edits
    2 moves
    2 adds in trunk

UI process crash when focusing an editable image
https://bugs.webkit.org/show_bug.cgi?id=192839
<rdar://problem/46786670>

Reviewed by Wenson Hsieh.

Source/WebKit:

  • SourcesCocoa.txt:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _requiresKeyboardWhenFirstResponder]):
(-[WKContentView inputView]):
(-[WKContentView requiresAccessoryView]):
(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
(-[WKContentView _stopAssistingNode]):
(-[WKContentView _installInkPickerForDrawingViewWithID:]):
(-[WKContentView _uninstallInkPicker]):

  • UIProcess/ios/WKInkPickerView.h: Renamed from Source/WebKit/UIProcess/ios/WKInkPickerControl.h.
  • UIProcess/ios/WKInkPickerView.mm: Renamed from Source/WebKit/UIProcess/ios/WKInkPickerControl.mm.

(-[WKInkPickerView initWithDrawingView:]):
(-[WKInkPickerView didPickInk]):
(-[WKInkPickerView inlineInkPickerDidToggleRuler:]):
(-[WKInkPickerView inlineInkPicker:didSelectTool:]):
(-[WKInkPickerView inlineInkPicker:didSelectColor:]):
(-[WKInkPickerView inkPickerSize]):
(-[WKInkPickerView layoutSubviews]):
(-[WKInkPickerView sizeThatFits:]):
(-[WKInkPickerView viewControllerForPopoverPresentationFromInlineInkPicker:]):

  • WebKit.xcodeproj/project.pbxproj:

Make WKInkPickerView a WKWebView subview instead of an inputView.
Also, don't force the keyboard to be visible when an editable image is focused.

LayoutTests:

  • editing/images/basic-editable-image-with-gesture.html: Added.
  • editing/images/basic-editable-image-with-gesture-expected.txt: Added.
  • resources/ui-helper.js:

(window.UIHelper.stylusTapAt.return.new.Promise):
(window.UIHelper.stylusTapAt):
Add a test that ensures that adding an editable image from a gesture
doesn't crash, and can be drawn on.

3:28 PM Changeset in webkit [239399] by Nikita Vasilyev
  • 4 edits in trunk/Source/WebInspectorUI

Web Inspector: Computed: make UI more usable when the panel is narrow
https://bugs.webkit.org/show_bug.cgi?id=192578
<rdar://problem/46615753>

Reviewed by Devin Rousso.

  • UserInterface/Views/ComputedStyleSection.css:

(.computed-style-section .computed-property-item .property-traces):
(.computed-style-section .computed-property-item.expanded .disclosure-button):
(.computed-style-section .computed-property-item .property-trace-item):
(.computed-style-section .computed-property-item .property-trace-item::before):
(.computed-style-section .computed-property-item .property):
(.computed-style-section .computed-property-item .property-trace-item .selector):
Allow CSS property values and selectors to take more than one line.

(.computed-style-section .property-trace-item .property .name,):

  • UserInterface/Views/ComputedStyleSection.js:

(WI.ComputedStyleSection.prototype._createTrace):

  • UserInterface/Views/SpreadsheetStyleProperty.js:

(WI.SpreadsheetStyleProperty.prototype.update):

3:27 PM Changeset in webkit [239398] by mmaxfield@apple.com
  • 3 edits
    3 adds in trunk/Source/WebCore

[WHLSL] Add a handwritten lexer
https://bugs.webkit.org/show_bug.cgi?id=192294

Reviewed by Jon Lee.

This is infrastructure necessary for https://bugs.webkit.org/show_bug.cgi?id=192355. The
implementation matches the lexing rules in the spec (specifically, the rules that start
with an uppercase letter). The spec is at
https://github.com/gpuweb/WHLSL/blob/master/Spec/WHLSL.g4.

This patch also modifies the lexer according to https://github.com/gpuweb/WHLSL/pull/283.

No new tests because the lexer isn't hooked up yet; there are tests in the parser,
once that gets committed.

  • Modules/webgpu/WHLSL/WHLSLLexer.cpp: Added.

(WebCore::WHLSL::Lexer::Token::typeName):
(WebCore::WHLSL::Lexer::recognizeKeyword):
(WebCore::WHLSL::Lexer::consumeTokenFromStream):
(WebCore::WHLSL::Lexer::skipWhitespaceAndComments):
(WebCore::WHLSL::isWhitespace):
(WebCore::WHLSL::isNewline):
(WebCore::WHLSL::Lexer::skipWhitespace):
(WebCore::WHLSL::Lexer::skipLineComment):
(WebCore::WHLSL::Lexer::skipLongComment):
(WebCore::WHLSL::Lexer::coreDecimalIntLiteral const):
(WebCore::WHLSL::Lexer::decimalIntLiteral const):
(WebCore::WHLSL::Lexer::decimalUintLiteral const):
(WebCore::WHLSL::isHexadecimalCharacter):
(WebCore::WHLSL::Lexer::coreHexadecimalIntLiteral const):
(WebCore::WHLSL::Lexer::hexadecimalIntLiteral const):
(WebCore::WHLSL::Lexer::hexadecimalUintLiteral const):
(WebCore::WHLSL::Lexer::intLiteral const):
(WebCore::WHLSL::Lexer::uintLiteral const):
(WebCore::WHLSL::Lexer::digit const):
(WebCore::WHLSL::Lexer::digitStar const):
(WebCore::WHLSL::Lexer::character const):
(WebCore::WHLSL::Lexer::coreFloatLiteralType1 const):
(WebCore::WHLSL::Lexer::coreFloatLiteral const):
(WebCore::WHLSL::Lexer::floatLiteral const):
(WebCore::WHLSL::Lexer::validIdentifier const):
(WebCore::WHLSL::Lexer::identifier const):
(WebCore::WHLSL::Lexer::operatorName const):

  • Modules/webgpu/WHLSL/WHLSLLexer.h: Added.

(WebCore::WHLSL::Lexer::Lexer):
(WebCore::WHLSL::Lexer::consumeToken):
(WebCore::WHLSL::Lexer::unconsumeToken):
(WebCore::WHLSL::Lexer::state const):
(WebCore::WHLSL::Lexer::setState):
(WebCore::WHLSL::Lexer::isFullyConsumed const):
(WebCore::WHLSL::Lexer::errorString):
(WebCore::WHLSL::Lexer::string const):
(WebCore::WHLSL::Lexer::anyCharacter const):

  • Sources.txt:
  • WebCore.xcodeproj/project.pbxproj:
3:17 PM Changeset in webkit [239397] by Simon Fraser
  • 18 edits in trunk/Source

Web Inspector: Timelines: correctly label Intersection Observer callbacks
https://bugs.webkit.org/show_bug.cgi?id=192669
<rdar://problem/46702490>

Reviewed by Joseph Pecoraro.

Add InspectorInstrumentation::willFireObserverCallback() and use it to wrap calls
to Intersection Observer, Performance Observer and Mutation Observer callbacks so
that they get correctly labeled in the Inspector timeline.

Source/JavaScriptCore:

  • inspector/protocol/Timeline.json:

Source/WebCore:

  • dom/MutationObserver.cpp:

(WebCore::MutationObserver::deliver):

  • en.lproj/Localizable.strings:
  • inspector/InspectorInstrumentation.cpp:

(WebCore::InspectorInstrumentation::willFireObserverCallbackImpl):
(WebCore::InspectorInstrumentation::didFireObserverCallbackImpl):

  • inspector/InspectorInstrumentation.h:

(WebCore::InspectorInstrumentation::willFireObserverCallback):
(WebCore::InspectorInstrumentation::didFireObserverCallback):

  • inspector/TimelineRecordFactory.cpp:

(WebCore::TimelineRecordFactory::createObserverCallbackData):

  • inspector/TimelineRecordFactory.h:
  • inspector/agents/InspectorTimelineAgent.cpp:

(WebCore::InspectorTimelineAgent::willFireObserverCallback):
(WebCore::InspectorTimelineAgent::didFireObserverCallback):
(WebCore::toProtocol):

  • inspector/agents/InspectorTimelineAgent.h:
  • page/IntersectionObserver.cpp:

(WebCore::IntersectionObserver::notify):

  • page/PerformanceObserver.cpp:

(WebCore::PerformanceObserver::deliver):

Source/WebInspectorUI:

  • Localizations/en.lproj/localizedStrings.js:
  • UserInterface/Controllers/TimelineManager.js:

(WI.TimelineManager.prototype._processRecord):

  • UserInterface/Models/ScriptTimelineRecord.js:

(WI.ScriptTimelineRecord.EventType.displayName):

  • UserInterface/Views/TimelineTabContentView.js:

(WI.TimelineTabContentView.iconClassNameForRecord):

2:45 PM Changeset in webkit [239396] by youenn@apple.com
  • 38 edits in trunk/Source/ThirdParty/libwebrtc

Resync libwebrtc with M72 branch
https://bugs.webkit.org/show_bug.cgi?id=192858

Reviewed by Eric Carlson.

Merge changes made upstream.
Some of these changes improve support of unified plan and backward compatiblity.

  • Source/webrtc/api/candidate.cc:
  • Source/webrtc/api/candidate.h:
  • Source/webrtc/api/rtpreceiverinterface.h:
  • Source/webrtc/api/umametrics.h:
  • Source/webrtc/media/engine/webrtcvideoengine.cc:
  • Source/webrtc/media/engine/webrtcvideoengine_unittest.cc:
  • Source/webrtc/modules/audio_processing/agc2/agc2_common.h:
  • Source/webrtc/modules/desktop_capture/desktop_and_cursor_composer.cc:
  • Source/webrtc/modules/video_coding/BUILD.gn:
  • Source/webrtc/modules/video_coding/codecs/vp9/svc_config.cc:
  • Source/webrtc/modules/video_coding/codecs/vp9/svc_rate_allocator.cc:
  • Source/webrtc/modules/video_coding/codecs/vp9/svc_rate_allocator.h:
  • Source/webrtc/modules/video_coding/codecs/vp9/svc_rate_allocator_unittest.cc:
  • Source/webrtc/modules/video_coding/codecs/vp9/test/vp9_impl_unittest.cc:
  • Source/webrtc/modules/video_coding/codecs/vp9/vp9.cc:
  • Source/webrtc/modules/video_coding/video_codec_initializer.cc:
  • Source/webrtc/modules/video_coding/video_codec_initializer_unittest.cc:
  • Source/webrtc/p2p/base/p2ptransportchannel_unittest.cc:
  • Source/webrtc/p2p/base/port.cc:
  • Source/webrtc/p2p/base/port.h:
  • Source/webrtc/p2p/base/portallocator.cc:
  • Source/webrtc/p2p/client/basicportallocator.cc:
  • Source/webrtc/p2p/client/basicportallocator_unittest.cc:
  • Source/webrtc/pc/peerconnection.cc:
  • Source/webrtc/pc/peerconnection.h:
  • Source/webrtc/pc/peerconnection_integrationtest.cc:
  • Source/webrtc/pc/peerconnectioninternal.h:
  • Source/webrtc/pc/statscollector.cc:
  • Source/webrtc/pc/statscollector.h:
  • Source/webrtc/pc/test/fakepeerconnectionbase.h:
  • Source/webrtc/pc/test/fakepeerconnectionforstats.h:
  • Source/webrtc/pc/test/mockpeerconnectionobservers.h:

(webrtc::MockStatsObserver::OnComplete):
(webrtc::MockStatsObserver::TrackIds const):

  • Source/webrtc/pc/webrtcsdp_unittest.cc:
  • Source/webrtc/rtc_base/fake_mdns_responder.h:

(webrtc::FakeMdnsResponder::GetMappedAddressForName const):

  • Source/webrtc/rtc_base/fakenetwork.h:

(rtc::FakeNetworkManager::CreateMdnsResponder):
(rtc::FakeNetworkManager::GetMdnsResponderForTesting const):

  • Source/webrtc/video/video_send_stream_impl.cc:
  • Source/webrtc/video/video_stream_encoder.cc:
2:24 PM Changeset in webkit [239395] by Claudio Saavedra
  • 2 edits in trunk/Source/WebCore

ContentExtensions: DFANode.cpp:66:44: error: narrowing conversion of '-1' from 'int' to 'char' inside { }
https://bugs.webkit.org/show_bug.cgi?id=192854

Reviewed by Alex Christensen.

  • contentextensions/DFANode.h: Define CharRange's chars as signed
2:09 PM Changeset in webkit [239394] by Devin Rousso
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Audit: "Clear Filters" button gets clipped when window is vertically small
https://bugs.webkit.org/show_bug.cgi?id=192868
<rdar://problem/46780400>

Reviewed by Matt Baker.

  • UserInterface/Views/Main.css:

(.message-text-view):

2:05 PM Changeset in webkit [239393] by Kocsen Chung
  • 11 edits
    2 adds in branches/safari-606-branch

Apply patch. rdar://problem/46848447

2:00 PM Changeset in webkit [239392] by mark.lam@apple.com
  • 3 edits
    2 adds in trunk

JSPropertyNameEnumerator should cache the iterated object's structure only after getting its property names.
https://bugs.webkit.org/show_bug.cgi?id=192464
<rdar://problem/46519455>

Reviewed by Saam Barati.

JSTests:

This patch is about a 10% speed up on the new for-in-on-object-with-lazily-materialized-properties.js
microbenchmark.

  • microbenchmarks/for-in-on-object-with-lazily-materialized-properties.js: Added.
  • stress/property-name-enumerator-should-cache-structure-after-getting-property-names.js: Added.

Source/JavaScriptCore:

This is because the process of getting its property names may cause some lazy
properties to be reified, and the structure will change. This is needed in order
for get_direct_pname to work correctly.

  • runtime/JSPropertyNameEnumerator.h:

(JSC::propertyNameEnumerator):

2:00 PM Changeset in webkit [239391] by youenn@apple.com
  • 4 edits in trunk

Remove RTCRtpTransceiver.setDirection
https://bugs.webkit.org/show_bug.cgi?id=192869

Reviewed by Alex Christensen.

LayoutTests/imported/w3c:

  • web-platform-tests/webrtc/historical-expected.txt:

Source/WebCore:

Covered by rebased test.

  • Modules/mediastream/RTCRtpTransceiver.idl:
2:00 PM Changeset in webkit [239390] by youenn@apple.com
  • 2 edits in trunk/LayoutTests

[ MacOS iOS ] Layout Test webrtc/no-port-zero-in-upd-candidates.html is flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=192866

Reviewed by Alex Christensen.

  • webrtc/no-port-zero-in-upd-candidates.html:

Add some more logging in the test in case of time out.

1:25 PM Changeset in webkit [239389] by eric.carlson@apple.com
  • 4 edits in trunk/Source

[MediaStream] Force system camera/microphone TCC prompt if necessary
https://bugs.webkit.org/show_bug.cgi?id=192820
<rdar://problem/42680098>

Reviewed by Jer Noble.

Source/WebKit:

  • UIProcess/Cocoa/UIDelegate.mm:

(WebKit::UIDelegate::UIClient::decidePolicyForUserMediaPermissionRequest): Enable TCC check
and prompt on Mojave.

Source/WTF:

  • wtf/Platform.h: Define HAVE_AUTHORIZATION_STATUS_FOR_MEDIA_TYPE.
1:24 PM Changeset in webkit [239388] by Kocsen Chung
  • 7 edits in branches/safari-606-branch/Source

Versioning.

1:11 PM Changeset in webkit [239387] by jer.noble@apple.com
  • 2 edits in trunk/Source/WebCore

Force synchronous decode in WebCoreDecompressionSession::decodeSampleSync()
https://bugs.webkit.org/show_bug.cgi?id=192856
<rdar://problem/46843245>

Reviewed by Alex Christensen.

Some decoders exposed through VideoToolbox will decode asynchronously even when
kVTDecodeInfo_Asynchronous is not set. Force synchronous behavior with a Semaphore.

  • platform/graphics/cocoa/WebCoreDecompressionSession.mm:

(WebCore::WebCoreDecompressionSession::decodeSampleSync):

1:09 PM Changeset in webkit [239386] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: Dark Mode: selected text is too light when Inspector window is inactive
https://bugs.webkit.org/show_bug.cgi?id=190542
<rdar://problem/45238712>

Reviewed by Devin Rousso.

  • UserInterface/Views/CodeMirrorOverrides.css:

(.CodeMirror .CodeMirror-selected):

1:08 PM Changeset in webkit [239385] by Nikita Vasilyev
  • 2 edits in trunk/Source/WebInspectorUI

Web Inspector: column sort controls in Layers tab sidebar don't render correctly in dark mode
https://bugs.webkit.org/show_bug.cgi?id=192845

Reviewed by Devin Rousso.

  • UserInterface/Views/DataGrid.css:

(@media (prefers-dark-interface)):
(.data-grid th.sortable:active):
Drive-by: replace obnoxiously light background of the pressed header with a more subtle gray.

(.data-grid th.sort-ascending > div:first-child::after, .data-grid th.sort-descending > div:first-child::after):
Invert colors of the arrow glyph.

12:21 PM Changeset in webkit [239384] by Megan Gardner
  • 19 edits in trunk

Allow clients to set the navigator platform
https://bugs.webkit.org/show_bug.cgi?id=192735

Reviewed by Tim Horton.

Source/WebCore:

Expanded TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm.

Lots of piping to allow the setting of a custom navigator platform.

  • loader/DocumentLoader.h:

(WebCore::DocumentLoader::setCustomNavigatorPlatform):
(WebCore::DocumentLoader::customNavigatorPlatform const):

  • loader/FrameLoader.cpp:

(WebCore::FrameLoader::navigatorPlatform const):

  • loader/FrameLoader.h:
  • page/Navigator.cpp:

(WebCore::Navigator::platform const):

  • page/Navigator.h:
  • page/NavigatorBase.cpp:

(WebCore::NavigatorBase::platform const):
(WebCore::NavigatorBase::platform): Deleted.

  • page/NavigatorBase.h:

Source/WebKit:

Add private API to allow clients to override the default navigator
platform. Some websites check for the platform, which
interfears with our request desktop site feature. This should
help more sites function as expected.

  • Shared/WebsitePoliciesData.cpp:

(WebKit::WebsitePoliciesData::encode const):
(WebKit::WebsitePoliciesData::decode):
(WebKit::WebsitePoliciesData::applyToDocumentLoader):

  • Shared/WebsitePoliciesData.h:
  • UIProcess/API/APIWebsitePolicies.cpp:

(API::WebsitePolicies::data):

  • UIProcess/API/APIWebsitePolicies.h:
  • UIProcess/API/Cocoa/_WKWebsitePolicies.h:
  • UIProcess/API/Cocoa/_WKWebsitePolicies.mm:

(-[_WKWebsitePolicies setCustomNavigatorPlatform:]):
(-[_WKWebsitePolicies customNavigatorPlatform]):

  • UIProcess/Cocoa/NavigationState.mm:

(WebKit::NavigationState::NavigationClient::decidePolicyForNavigationAction):

Source/WebKitLegacy/mac:

Add stubs to fill out the added functionality in FrameLoaderClient.

  • WebCoreSupport/WebFrameLoaderClient.h:
  • WebCoreSupport/WebFrameLoaderClient.mm:

(WebFrameLoaderClient::navigatorPlatform):

Tools:

Add a test for setting a custom navigator platform.

  • TestWebKitAPI/Tests/WebKitCocoa/WebsitePolicies.mm:

(-[CustomNavigatorPlatformDelegate _webView:decidePolicyForNavigationAction:userInfo:decisionHandler:]):
(-[CustomNavigatorPlatformDelegate webView:didFinishNavigation:]):

11:58 AM Changeset in webkit [239383] by Adrian Perez de Castro
  • 2 edits in trunk

[GTK] Cannot build with CMake <3.7
https://bugs.webkit.org/show_bug.cgi?id=192865

Reviewed by Michael Catanzaro.

  • Source/cmake/OptionsGTK.cmake: Convert usage of VERSION_GREATER_EQUAL to a

combination of VERSION_GREATER + STREQUAL.

11:26 AM Changeset in webkit [239382] by Ryan Haddad
  • 2 edits in trunk/LayoutTests

REGRESSION (r234940): [ MacOS ] Layout Test imported/w3c/web-platform-tests/media-source/mediasource-changetype-play.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=190976

Unreviewed test gardening.

  • platform/mac/TestExpectations: Mark test as flaky.
11:11 AM Changeset in webkit [239381] by Ryan Haddad
  • 5 edits
    2 deletes in trunk

Unreviewed, rolling out r239347.

Caused the leaks bot to hit an exception and the new test
crashes on certain configurations.

Reverted changeset:

"Synchronous media query evaluation could destroy current
Frame/FrameView."
https://bugs.webkit.org/show_bug.cgi?id=192781
https://trac.webkit.org/changeset/239347

10:57 AM Changeset in webkit [239380] by Truitt Savell
  • 11 edits in trunk

Unreviewed, rolling out r239358.

Revision caused imported/w3c/web-platform-tests/IndexedDB/ to
crash on Debug bots

Reverted changeset:

"Clean up IndexedDB files between tests"
https://bugs.webkit.org/show_bug.cgi?id=192796
https://trac.webkit.org/changeset/239358

10:23 AM Changeset in webkit [239379] by don.olmstead@sony.com
  • 3 edits in trunk/Source/WebCore

Sync some include directories in WebCore
https://bugs.webkit.org/show_bug.cgi?id=192819

Reviewed by Michael Catanzaro.

Added missing include directories around features that have only been enabled on
Apple ports. Removes obsolete directories from list and moves harfbuzz directories
into the freetype cmake file.

  • CMakeLists.txt:
  • platform/FreeType.cmake:
7:37 AM Changeset in webkit [239378] by commit-queue@webkit.org
  • 2 edits in trunk

Fix build on 64bit ARM with arm64 SYSTEM_PROCESSOR
https://bugs.webkit.org/show_bug.cgi?id=192497

Patch by Lucas Stach <l.stach@pengutronix.de> on 2018-12-19
Reviewed by Philippe Normand.

Android and some embedded Linux build systems use arm64 instead of
aarch64 as the CMAKE_HOST_PROCESSOR. Fix the JIT build for this scenario.

  • CMakeLists.txt:
4:12 AM Changeset in webkit [239377] by Caio Lima
  • 5 edits
    3 adds in trunk

[BigInt] We should enable CSE into arithmetic operations that speculate BigIntUse
https://bugs.webkit.org/show_bug.cgi?id=192723

Reviewed by Saam Barati.

PerformanceTests:

  • BigIntBench/big-int-cse.js: Added.
  • BigIntBench/big-int-global-cse.js: Added.
  • BigIntBench/big-int-licm.js: Added.

Source/JavaScriptCore:

This patch is adjusting clobberize rules into ValueOp nodes to enable
more optimizations when we speculate BigIntUse. In such case, DFG now
is able to apply CSE, LICM and commutativity on nodes like
ValueAdd(BigInt, BigInt), ValueSub(BigInt, BigInt), etc.

Here are the numbers we can observe with some microbenchmarks:

baseline changes

big-int-cse 108.2733+-0.8445 80.9897+-4.9781 definitely 1.3369x faster
big-int-licm 75.6641+-0.3477 57.8144+-1.6043 definitely 1.3087x faster
big-int-global-cse 145.3557+-1.0552 86.5866+-0.3025 definitely 1.6787x faster

  • dfg/DFGAbstractInterpreterInlines.h:

(JSC::DFG::AbstractInterpreter<AbstractStateType>::executeEffects):

  • dfg/DFGClobberize.h:

(JSC::DFG::clobberize):

  • dfg/DFGStrengthReductionPhase.cpp:

(JSC::DFG::StrengthReductionPhase::handleNode):

3:37 AM Changeset in webkit [239376] by aboya@igalia.com
  • 4 edits in trunk/Source/WebCore

[MSE] Remove unused method: stopAskingForMoreSamples()
https://bugs.webkit.org/show_bug.cgi?id=192754

Reviewed by Xabier Rodriguez-Calvar.

The stopAskingForMoreSamples() method from SourceBufferPrivate is not
being used by anyone. SourceBuffer is not calling it and no
SourceBufferPrivate is implementing it. Let's remove that noise.

  • platform/graphics/SourceBufferPrivate.h:

(WebCore::SourceBufferPrivate::setActive):
(WebCore::SourceBufferPrivate::stopAskingForMoreSamples): Deleted.

  • platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.cpp:

(WebCore::SourceBufferPrivateGStreamer::stopAskingForMoreSamples): Deleted.

  • platform/graphics/gstreamer/mse/SourceBufferPrivateGStreamer.h:
3:33 AM Changeset in webkit [239375] by Tadeu Zagallo
  • 3 edits
    1 add in trunk

String overflow in JSC::createError results in ASSERT in WTF::makeString
https://bugs.webkit.org/show_bug.cgi?id=192833
<rdar://problem/45706868>

Reviewed by Mark Lam.

JSTests:

  • stress/string-overflow-createError.js: Added.

Source/JavaScriptCore:

JSC::createError was calling WTF::makeString which would result in an
assertion failure when the string was too big. Change it to call
WTF::tryMakeString instead and return an OutOfMemory error if we fail
to create the error string.

  • runtime/ExceptionHelpers.cpp:

(JSC::createError):

3:20 AM Changeset in webkit [239374] by aboya@igalia.com
  • 7 edits in trunk/Source/WebCore

[MSE] Remove dead code: sourceBufferPrivateSeekToTime()
https://bugs.webkit.org/show_bug.cgi?id=192827

Reviewed by Xabier Rodriguez-Calvar.

This patch makes two dead code removal changes in
SourceBufferPrivateClient:

First, sourceBufferPrivateFastSeekTimeForMediaTime() is made pure
virtual in SourceBufferPrivateClient. Since SourceBufferPrivateClient
is only inherited by SourceBuffer, it makes no sense to have default
implementations there (they will never be used), moreso it being a
client interface.

Second, sourceBufferPrivateSeekToTime() is removed entirely. It used
to had an empty implementation, which SourceBuffer did not overwrite,
therefore making any calls to it useless.

All calls to sourceBufferPrivateSeekToTime() have been removed:

SourceBufferPrivateAVFObjC::seekToTime(), which was also dead code
itself, used to call this method. This patch deletes it completely.

MockSourceBufferPrivate::seekToTime(), which only called this empty
method, has also been removed along with its only usage in
MockMediaSourcePrivate::seekToTime().

  • platform/graphics/SourceBufferPrivateClient.h:

(WebCore::SourceBufferPrivateClient::sourceBufferPrivateFastSeekTimeForMediaTime): Deleted.
(WebCore::SourceBufferPrivateClient::sourceBufferPrivateSeekToTime): Deleted.

  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
  • platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:

(WebCore::SourceBufferPrivateAVFObjC::seekToTime): Deleted.

  • platform/mock/mediasource/MockMediaSourcePrivate.cpp:

(WebCore::MockMediaSourcePrivate::seekToTime):

  • platform/mock/mediasource/MockSourceBufferPrivate.cpp:

(WebCore::MockSourceBufferPrivate::seekToTime): Deleted.

  • platform/mock/mediasource/MockSourceBufferPrivate.h:
12:55 AM Changeset in webkit [239373] by calvaris@igalia.com
  • 2 edits in trunk/Source/WebCore

[EME] MediaKeySystemConfiguration distinctiveIdentifier and persistentState should default to optional
https://bugs.webkit.org/show_bug.cgi?id=192815

Reviewed by Jer Noble.

https://www.w3.org/TR/encrypted-media/#dom-mediakeysystemconfiguration
says that distinctiveIdentifier and persistentState default to
optional. Our implementation does not define a default leaving it
to the first option of the enum, which currently is Required.

  • platform/encryptedmedia/CDMKeySystemConfiguration.h:
12:00 AM Changeset in webkit [239372] by commit-queue@webkit.org
  • 4 edits in trunk/Source/WebCore

Merge parseAccessControlExposeHeadersAllowList into parseAccessControlAllowList
https://bugs.webkit.org/show_bug.cgi?id=192288

Patch by Rob Buis <rbuis@igalia.com> on 2018-12-19
Reviewed by Frédéric Wang.

Prefer return value to out parameter for parseAccessControlAllowList.

  • loader/CrossOriginPreflightResultCache.cpp:

(WebCore::CrossOriginPreflightResultCacheItem::parse):

  • platform/network/HTTPParsers.h:

(WebCore::parseAccessControlAllowList):

  • platform/network/ResourceResponseBase.cpp:

(WebCore::ResourceResponseBase::filter):
(WebCore::ResourceResponseBase::sanitizeHTTPHeaderFieldsAccordingToTainting):

Note: See TracTimeline for information about the timeline view.