Timeline



Dec 26, 2018:

8:01 PM Changeset in webkit [239555] by Fujii Hironori
  • 3 edits in trunk/Source/WebKit

[MSVC] error C2381: 'WebKit::NetworkHTTPSUpgradeChecker::~NetworkHTTPSUpgradeChecker': redefinition; 'declspec(noreturn)' or 'noreturn?' differs
​https://bugs.webkit.org/show_bug.cgi?id=193030

Reviewed by Ross Kirsling.

Windows Debug builds are failing to compile due to
NO_RETURN_DUE_TO_ASSERT inconsistency of
NetworkHTTPSUpgradeChecker destructor's definition and
declaration.

  • NetworkProcess/NetworkHTTPSUpgradeChecker.h: Added

NO_RETURN_DUE_TO_ASSERT to NetworkHTTPSUpgradeChecker destructor
declaration.

  • NetworkProcess/NetworkHTTPSUpgradeChecker.cpp: Removed

NO_RETURN_DUE_TO_ASSERT from the definition.

12:42 PM Changeset in webkit [239554] by commit-queue@webkit.org
  • 3 edits in trunk/Source/WebCore

[FreeType] Restore conditional compilation logic for recent HarfBuzz refactoring
​https://bugs.webkit.org/show_bug.cgi?id=193036

Patch by Jim Mason <​jmason@ibinx.com> on 2018-12-26
Reviewed by Michael Catanzaro.

  • platform/graphics/FontPlatformData.h:
  • platform/graphics/freetype/FontPlatformDataFreeType.cpp:
10:30 AM Changeset in webkit [239553] by Adrian Perez de Castro
  • 6 edits in trunk/Tools

[Tools] Remove references to Bison and Flex
​https://bugs.webkit.org/show_bug.cgi?id=193033

Reviewed by Michael Catanzaro.

The Bison and Flex tools are not needed anymore since r209883.

  • CygwinDownloader/cygwin-downloader.py:
  • EWSTools/ubuntu-ews-packages:
  • Scripts/filter-build-webkit:

(shouldIgnoreLine):

  • gtk/install-dependencies:
  • wpe/install-dependencies:

Dec 25, 2018:

11:52 PM Changeset in webkit [239552] by Fujii Hironori
  • 4 edits in trunk/Source/JavaScriptCore

[JSC][Win][Clang] warning: implicit conversion from 'size_t' (aka 'unsigned long long') to 'int32_t' (aka 'int') changes value from 18446744073709551552 to -64 [-Wconstant-conversion]
​https://bugs.webkit.org/show_bug.cgi?id=193035

Reviewed by Yusuke Suzuki.

Clang-cl reports a compilation warning for implicit conversion
from -64 size_t to int. Replaced '-maxFrameExtentForSlowPathCall'
with '-static_cast<int32_t>(maxFrameExtentForSlowPathCall)'.

  • dfg/DFGJITCompiler.cpp:

(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):

  • jit/JIT.cpp:

(JSC::JIT::compileWithoutLinking):

  • jit/ThunkGenerators.cpp:

(JSC::slowPathFor):

Dec 24, 2018:

8:40 PM Changeset in webkit [239551] by Fujii Hironori
  • 2 edits in trunk/Source/WebCore

Remove "using namespace std;"
​https://bugs.webkit.org/show_bug.cgi?id=192973
<rdar://problem/46937309>

Unreviewed Windows port Debug builds fix.

No new tests since no behavior changes.

  • accessibility/win/AXObjectCacheWin.cpp:

(WebCore::AXObjectCache::postPlatformNotification): Add "std::" prefix to numeric_limits in ASSERT macro.

6:14 PM Changeset in webkit [239550] by Fujii Hironori
  • 12 edits in trunk/Source/WebKit

[WebKit][Win] Remove using namespace in the global scope
​https://bugs.webkit.org/show_bug.cgi?id=192968

Reviewed by Alex Christensen.

Moved using namespace statements in the global scope to inside
namespaces.
<​https://webkit.org/code-style-guidelines/#using-position>

  • NetworkProcess/Cookies/curl/WebCookieManagerCurl.cpp:
  • NetworkProcess/curl/NetworkDataTaskCurl.cpp:
  • NetworkProcess/curl/NetworkProcessCurl.cpp:
  • NetworkProcess/curl/NetworkSessionCurl.cpp:
  • NetworkProcess/curl/RemoteNetworkingContextCurl.cpp:
  • Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp:
  • Shared/WebWheelEvent.cpp:
  • Shared/curl/WebCoreArgumentCodersCurl.cpp:
  • Shared/win/NativeWebKeyboardEventWin.cpp:
  • Shared/win/WebEventFactory.cpp:
  • UIProcess/Automation/WebAutomationSession.cpp:
6:00 PM Changeset in webkit [239549] by Fujii Hironori
  • 27 edits in trunk/Source

Remove "using namespace std;"
​https://bugs.webkit.org/show_bug.cgi?id=192973

Reviewed by Alex Christensen.

Source/WebCore:

Removed "using namespace std" statement, and use std:: prefix.

No new tests since no behavior changes.

  • accessibility/win/AXObjectCacheWin.cpp:
  • platform/graphics/GraphicsContext3DPrivate.cpp:
  • platform/graphics/cairo/ImageBufferCairo.cpp:
  • platform/graphics/win/FontPlatformDataCairoWin.cpp:
  • platform/graphics/win/FontWin.cpp:

(WebCore::FontCascade::floatWidthForComplexText const):

  • platform/graphics/win/GraphicsContextCGWin.cpp:
  • platform/graphics/win/GraphicsContextCairoWin.cpp:
  • platform/graphics/win/GraphicsContextDirect2D.cpp:
  • platform/graphics/win/GraphicsContextWin.cpp:
  • platform/graphics/win/SimpleFontDataCGWin.cpp:
  • platform/graphics/win/UniscribeController.cpp:

(WebCore::UniscribeController::UniscribeController):
(WebCore::UniscribeController::shapeAndPlaceItem):

  • platform/image-decoders/ScalableImageDecoder.cpp:
  • platform/text/LocaleICU.cpp:
  • platform/text/win/LocaleWin.cpp:
  • platform/win/ScrollbarThemeWin.cpp:
  • rendering/RenderRubyRun.cpp:

(WebCore::RenderRubyRun::layoutBlock):

  • rendering/RenderThemeWin.cpp:

(WebCore::RenderThemeWin::adjustMenuListButtonStyle const):
(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::adjustSearchFieldCancelButtonStyle const):
(WebCore::RenderThemeWin::adjustSearchFieldResultsDecorationPartStyle const):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecorationPart):
(WebCore::RenderThemeWin::adjustSearchFieldResultsButtonStyle const):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):

Source/WebKit:

  • Platform/IPC/win/ConnectionWin.cpp:

Source/WebKitLegacy/win:

  • FullscreenVideoController.cpp:
  • WebFrame.cpp:

(WebFrame::drawFooter):

  • WebHistory.cpp:
  • WebKitQuartzCoreAdditions/CAD3DRenderer.cpp:
  • WebKitQuartzCoreAdditions/CAView.cpp:
  • WebView.cpp:

(PreferencesChangedOrRemovedObserver::notifyPreferencesChanged):
(PreferencesChangedOrRemovedObserver::notifyPreferencesRemoved):
(WebView::setCacheModel):
(WebView::maxCacheModelInAnyInstance):

11:20 AM Changeset in webkit [239548] by Simon Fraser
  • 26 edits in trunk/Source

Change ScrollingNodeType to an enum class
​https://bugs.webkit.org/show_bug.cgi?id=193009

Reviewed by Zalan Bujtas.

Change the ScrollingNodeType enum to an enum class.

No behavior change.

Source/WebCore:

  • page/scrolling/AsyncScrollingCoordinator.cpp:

(WebCore::AsyncScrollingCoordinator::ensureRootStateNodeForFrameView):

  • page/scrolling/ScrollingCoordinator.cpp:

(WebCore::operator<<):

  • page/scrolling/ScrollingCoordinator.h:
  • page/scrolling/ScrollingStateFixedNode.cpp:

(WebCore::ScrollingStateFixedNode::ScrollingStateFixedNode):

  • page/scrolling/ScrollingStateNode.h:

(WebCore::ScrollingStateNode::isFixedNode const):
(WebCore::ScrollingStateNode::isStickyNode const):
(WebCore::ScrollingStateNode::isFrameScrollingNode const):
(WebCore::ScrollingStateNode::isOverflowScrollingNode const):

  • page/scrolling/ScrollingStateOverflowScrollingNode.cpp:

(WebCore::ScrollingStateOverflowScrollingNode::ScrollingStateOverflowScrollingNode):

  • page/scrolling/ScrollingStateStickyNode.cpp:

(WebCore::ScrollingStateStickyNode::ScrollingStateStickyNode):

  • page/scrolling/ScrollingStateTree.cpp:

(WebCore::ScrollingStateTree::createNode):
(WebCore::ScrollingStateTree::attachNode):

  • page/scrolling/ScrollingTreeNode.h:

(WebCore::ScrollingTreeNode::isFixedNode const):
(WebCore::ScrollingTreeNode::isStickyNode const):
(WebCore::ScrollingTreeNode::isFrameScrollingNode const):
(WebCore::ScrollingTreeNode::isOverflowScrollingNode const):

  • page/scrolling/ScrollingTreeOverflowScrollingNode.cpp:

(WebCore::ScrollingTreeOverflowScrollingNode::ScrollingTreeOverflowScrollingNode):

  • page/scrolling/ios/ScrollingTreeIOS.cpp:

(WebCore::ScrollingTreeIOS::createScrollingTreeNode):

  • page/scrolling/mac/ScrollingTreeFixedNode.mm:

(WebCore::ScrollingTreeFixedNode::ScrollingTreeFixedNode):

  • page/scrolling/mac/ScrollingTreeMac.cpp:

(ScrollingTreeMac::createScrollingTreeNode):

  • page/scrolling/mac/ScrollingTreeStickyNode.mm:

(WebCore::ScrollingTreeStickyNode::ScrollingTreeStickyNode):

  • platform/graphics/GraphicsLayerClient.h:
  • rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::reattachSubframeScrollLayers):
(WebCore::scrollCoordinationRoleForNodeType):
(WebCore::RenderLayerCompositor::updateScrollCoordinationForThisFrame):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):

Source/WebKit:

  • Shared/RemoteLayerTree/RemoteScrollingCoordinatorTransaction.cpp:

(WebKit::encodeNodeAndDescendants):
(WebKit::RemoteScrollingCoordinatorTransaction::decode):
(WebKit::dump):

  • UIProcess/RemoteLayerTree/RemoteScrollingCoordinatorProxy.cpp:

(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):

  • UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp:

(WebKit::RemoteScrollingTree::createScrollingTreeNode):

  • UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm:

(WebKit::RemoteScrollingCoordinatorProxy::connectStateNodeLayers):

  • UIProcess/RemoteLayerTree/ios/ScrollingTreeScrollingNodeDelegateIOS.mm:

(WebKit::ScrollingTreeScrollingNodeDelegateIOS::updateChildNodesAfterScroll):

Dec 23, 2018:

9:07 PM Changeset in webkit [239547] by Wenson Hsieh
  • 5 edits in trunk/Source/WebKit

[iOS] Remove some unnecessary editing SPI after <rdar://problem/46047546>
​https://bugs.webkit.org/show_bug.cgi?id=193019

Reviewed by Dan Bernstein.

Remove these SPI method declarations, as well as method forwarding in WKContentView. Mail was the only adoptee
of these methods; after <rdar://problem/46047546>, they have moved to the underscore-prefixed versions, so we
we have no need for these erroneously-named SPI methods anymore. There is no change in behavior; verified this
through existing API tests (WKWebViewEditActions), as well as building iOS Mail against WebKit with these
changes to WKWebViewPrivate.h.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView canPerformAction:withSender:]):
(-[WKWebView targetForAction:withSender:]):
(-[WKWebView _setFont:sender:]):
(-[WKWebView _setFontSize:sender:]):
(-[WKWebView _setTextColor:sender:]):
(-[WKWebView setFont:sender:]): Deleted.
(-[WKWebView setTextColor:sender:]): Deleted.
(-[WKWebView setFontSize:sender:]): Deleted.

  • UIProcess/API/Cocoa/WKWebViewPrivate.h:
  • UIProcess/ios/WKContentViewInteraction.h:
  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView canPerformActionForWebView:withSender:]):
(-[WKContentView setFontForWebView:sender:]): Deleted.
(-[WKContentView setFontSizeForWebView:sender:]): Deleted.
(-[WKContentView setTextColorForWebView:sender:]): Deleted.

3:51 PM Changeset in webkit [239546] by Wenson Hsieh
  • 2 edits in trunk/Source/WebKit

Fix fast/ruby/ruby-base-merge-block-children-crash-2.html after r239543
​https://bugs.webkit.org/show_bug.cgi?id=193015
<rdar://problem/46583527>

Reviewed by Tim Horton.

Fix the crash by gracefully handling integer overflow when computing the area of a very large editable element.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
(-[WKContentView _updateChangedSelection:]):

2:46 AM Changeset in webkit [239545] by Carlos Garcia Campos
  • 2 edits in trunk/LayoutTests

Unreviewed GTK+ gardening. Rebaseline fast/text/zero-font-size.html after r239539.

  • platform/gtk/fast/text/zero-font-size-expected.txt:
2:09 AM Changeset in webkit [239544] by yusukesuzuki@slowstart.org
  • 6 edits
    2 adds in trunk

[BigInt] Support BigInt in JSON.stringify
​https://bugs.webkit.org/show_bug.cgi?id=192624

Reviewed by Saam Barati.

JSTests:

  • stress/big-int-json-stringify-to-json.js: Added.

(shouldBe):
(shouldThrow):
(BigInt.prototype.toJSON):
(shouldBe.JSON.stringify):

  • stress/big-int-json-stringify.js: Added.

(shouldBe):
(shouldThrow):

Source/JavaScriptCore:

This patch adds BigInt support to JSON.stringify, specified in [1].

[1]: ​https://tc39.github.io/proposal-bigint/#sec-serializejsonproperty

  • runtime/JSONObject.cpp:

(JSC::unwrapBoxedPrimitive):
(JSC::Stringifier::toJSON):
(JSC::Stringifier::toJSONImpl):
(JSC::Stringifier::appendStringifiedValue):

LayoutTests:

The test is wrong according to the spec[1]. valueOf of Boolean object won't be called.

[1]: ​https://tc39.github.io/ecma262/#sec-serializejsonproperty

  • js/resources/JSON-stringify.js:
  • js/resources/json2-es5-compat.js:

(str):

Dec 22, 2018:

10:38 PM Changeset in webkit [239543] by Wenson Hsieh
  • 11 edits
    2 adds in trunk

[iOS] Suppress native selection behaviors when focusing a very small editable element
​https://bugs.webkit.org/show_bug.cgi?id=193005
<rdar://problem/46583527>

Reviewed by Tim Horton.

Source/WebKit:

In r238146, I added a mechanism to detect when the selection is hidden within transparent editable elements, and
used this to suppress native selection on iOS (such as selection handles, highlight, callout bar, etc.) to avoid
conflicts between the page's editing UI and the platform.

However, one additional technique observed on some websites involves hiding the selection by moving it into a
tiny (1x1) editable element. Here, we currently still present a callout bar with editing actions, as well as
show a selection caret or handles on iOS. To fix this, we extend the mechanism added in r238146 by also
suppressing the selection assistant in the case where the editable element's area is beneath a tiny minimum
threshold.

Test: editing/selection/ios/hide-selection-in-tiny-contenteditable.html

  • Shared/EditorState.cpp:

(WebKit::EditorState::PostLayoutData::encode const):
(WebKit::EditorState::PostLayoutData::decode):
(WebKit::operator<<):

  • Shared/EditorState.h:

Rename selectionClipRect to focusedElementRect. We currently propagate the bounds of the focused element to the
UI process through EditorState updates, but only for the purpose of returning it in the computed selection clip
rect; instead, rename this member to something more general-purpose, so we can also use it when determining
whether to suppress the selection assistant.

  • UIProcess/API/Cocoa/WKWebView.mm:

(-[WKWebView _candidateRect]):

  • UIProcess/Cocoa/WebViewImpl.mm:

(WebKit::WebViewImpl::handleRequestedCandidates):

  • UIProcess/ios/WKContentViewInteraction.h:

Add a new SuppressSelectionAssistantReason that corresponds to focusing tiny editable elements.

  • UIProcess/ios/WKContentViewInteraction.mm:

(-[WKContentView _zoomToRevealFocusedElement]):
(-[WKContentView _selectionClipRect]):
(-[WKContentView _elementDidFocus:userIsInteracting:blurPreviousNode:changingActivityState:userObject:]):
(-[WKContentView _updateChangedSelection:]):

Check the size of the focused element, and begin or stop suppressing the selection assistant accordingly.

  • WebProcess/WebPage/ios/WebPageIOS.mm:

(WebKit::WebPage::platformEditorState const):

  • WebProcess/WebPage/mac/WebPageMac.mm:

(WebKit::WebPage::platformEditorState const):

LayoutTests:

Add a new layout test to verify that native selection UI is suppressed when focusing a tiny (1px by 1px)
editable element.

  • editing/selection/ios/hide-selection-in-tiny-contenteditable-expected.txt: Added.
  • editing/selection/ios/hide-selection-in-tiny-contenteditable.html: Added.
  • resources/ui-helper.js:

(window.UIHelper.zoomToScale):

5:09 PM Changeset in webkit [239542] by Michael Catanzaro
  • 7 edits
    2 adds in releases/WebKitGTK/webkit-2.22

Merge r219121 - Synchronous media query evaluation could destroy current Frame/FrameView.
​https://bugs.webkit.org/show_bug.cgi?id=192781
<rdar://problem/34416793>

Reviewed by Chris Dumez.

Source/WebCore:

Protect Frame and FrameView when coming back from printing and check if the current Frame/FrameView/FrameLoader objects are still valid.

Test: printing/print-with-media-query-destory.html

  • loader/DocumentLoader.cpp:

(WebCore::DocumentLoader::finishedLoading):

  • page/Frame.cpp:

(WebCore::Frame::setPrinting):

  • page/FrameView.cpp:

(WebCore::FrameView::forceLayoutForPagination):

  • page/PrintContext.cpp:

(WebCore::PrintContext::PrintContext):
(WebCore::PrintContext::computePageRects):
(WebCore::PrintContext::computePageRectsWithPageSizeInternal):
(WebCore::PrintContext::begin):
(WebCore::PrintContext::computeAutomaticScaleFactor):
(WebCore::PrintContext::spoolPage):
(WebCore::PrintContext::spoolRect):
(WebCore::PrintContext::end):

  • page/PrintContext.h:

(WebCore::PrintContext::frame const): Deleted.

LayoutTests:

  • printing/print-with-media-query-destory-expected.txt: Added.
  • printing/print-with-media-query-destory.html: Added.
2:54 PM Changeset in webkit [239541] by mitz@apple.com
  • 2 edits in trunk/Source/ThirdParty/libwebrtc

Fixed Apple production builds.

  • Configurations/Base.xcconfig: Exclude the Source/third_party/boringssl/src/util subdirectory, which contains binaries, from installsrc. Its contents are not used for building any of the targets in the project.
4:37 AM Changeset in webkit [239540] by Carlos Garcia Campos
  • 2 edits in trunk/Tools

WebDriver: warn about non existing tests when parsing expectations
​https://bugs.webkit.org/show_bug.cgi?id=192979

Reviewed by Michael Catanzaro.

It's common to update web driver tests and forget updating the test expectations in case of tests removed or
renamed.

  • Scripts/webkitpy/webdriver_tests/webdriver_test_runner.py:

(WebDriverTestRunner.init):

4:33 AM Changeset in webkit [239539] by Carlos Garcia Campos
  • 2 edits in trunk/Source/WebCore

[HarfBuzz] Width not correctly reported as 0 for zero font size
​https://bugs.webkit.org/show_bug.cgi?id=192986

Reviewed by Michael Catanzaro.

Fixes test fast/text/font-size-zero.html

  • platform/graphics/harfbuzz/ComplexTextControllerHarfBuzz.cpp:

(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Use empty advances for glyphs when the font
size is zero.

Note: See TracTimeline for information about the timeline view.