Timeline
Jan 2, 2019:
- 11:18 PM Changeset in webkit [239588] by
-
- 3 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles: selection lost when inspector is blurred
https://bugs.webkit.org/show_bug.cgi?id=192124
<rdar://problem/46800965>
Reviewed by Devin Rousso.
- UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.css:
(body:matches(.window-docked-inactive, .window-inactive) .spreadsheet-style-declaration-editor .property.selected):
Selection should be gray when Web Inspector window isn't focused.
- UserInterface/Views/SpreadsheetStyleProperty.js:
- 10:42 PM Changeset in webkit [239587] by
-
- 2 edits in trunk/Source/WebCore
Leak of CMSampleBuffer (752 bytes) in com.apple.WebKit.WebContent running WebKit layout tests
<https://webkit.org/b/193016>
<rdar://problem/46925703>
Reviewed by Simon Fraser.
- platform/mediarecorder/cocoa/MediaRecorderPrivateWriterCocoa.mm:
(WebCore::copySampleBufferWithCurrentTimeStamp):
- Change to return RetainPtr<CMSampleBufferRef>.
- Check return value of CMSampleBufferCreateCopyWithNewTiming().
(WebCore::MediaRecorderPrivateWriter::appendVideoSampleBuffer):
- Check return value of copySampleBufferWithCurrentTimeStamp().
- Fix leak by using RetainPtr<CMSampleBufferRef> returned from
copySampleBufferWithCurrentTimeStamp() instead of leaking
bufferWithCurrentTimeby using retainPtr().
(WebCore::createAudioFormatDescription):
- Extract method from appendAudioSampleBuffer() to return RetainPtr<CMFormatDescriptionRef> after calling CMAudioFormatDescriptionCreate().
- Check return value of CMAudioFormatDescriptionCreate().
(WebCore::createAudioSampleBufferWithPacketDescriptions):
- Extract method from appendAudioSampleBuffer() to return RetainPtr<CMSampleBufferRef> after calling CMAudioSampleBufferCreateWithPacketDescriptions().
(WebCore::MediaRecorderPrivateWriter::appendAudioSampleBuffer):
- Check return values of createAudioFormatDescription() and createAudioSampleBufferWithPacketDescriptions().
- Fix leaks by extracting code into helper methods that return
RetainPtr<> objects instead of leaking CMFormatDescriptionRef
directly or leaking
sampleBufferby using retainPtr().
- 8:33 PM Changeset in webkit [239586] by
-
- 4 edits in trunk
Homograph with LATIN SMALL LETTER R WITH FISHHOOK
https://bugs.webkit.org/show_bug.cgi?id=192944
Reviewed by Tim Horton.
Source/WTF:
- wtf/cocoa/NSURLExtras.mm:
(WTF::isLookalikeCharacter):
Tools:
- TestWebKitAPI/Tests/WTF/cocoa/URLExtras.mm:
(TestWebKitAPI::TEST):
- 8:05 PM Changeset in webkit [239585] by
-
- 2 edits in trunk/Source/WebInspectorUI
Web Inspector: Styles: it shouldn't be possible to delete read-only properties
https://bugs.webkit.org/show_bug.cgi?id=193099
<rdar://problem/47016335>
Reviewed by Devin Rousso.
- UserInterface/Views/SpreadsheetCSSStyleDeclarationEditor.js:
(WI.SpreadsheetCSSStyleDeclarationEditor):
Drive-by: Forward Delete should work the same way as Delete (Backspace).
- 8:00 PM Changeset in webkit [239584] by
-
- 24 edits3 adds in trunk
Add support for using the current text selection as the find string on iOS
https://bugs.webkit.org/show_bug.cgi?id=193034
<rdar://problem/45138739>
Reviewed by Tim Horton.
Source/WebCore:
Add support for "TakeFindStringFromSelection" on iOS. Unlike macOS, iOS does not have a notion of a "find
pasteboard" like macOS; instead, we handle this editing command by sending the selection string to the UI
process, where it is exposed via WebKit SPI so that clients that present find-in-page UI (i.e. MobileSafari) are
able to trigger find-in-page with this string.
Test: WebKit.UseSelectionAsFindString
- editing/Editor.cpp:
(WebCore::Editor::canCopyExcludingStandaloneImages const):
Make this helper function cross-platform.
- editing/Editor.h:
- editing/EditorCommand.cpp:
(WebCore::createCommandMap):
- editing/cocoa/EditorCocoa.mm:
(WebCore::Editor::takeFindStringFromSelection):
Move this from EditorMac to EditorCocoa, and implement it on iOS by calling into the editor client to update the
find string (see WebKit/ChangeLog for more details).
- editing/mac/EditorMac.mm:
(WebCore::Editor::canCopyExcludingStandaloneImages): Deleted.
(WebCore::Editor::takeFindStringFromSelection): Deleted.
- loader/EmptyClients.cpp:
- page/EditorClient.h:
Add a new editor client method to send the string for find-in-page to the UI process.
Source/WebKit:
- SourcesCocoa.txt:
- UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _takeFindStringFromSelection:]):
Provides a way to set the find string on iOS and macOS (an aside: takeFindStringFromSelection: already exists on
macOS, but there is no equivalent protocol method on iOS, so this new SPI acts as a cross-platform way for
WebKit clients to take the find string from the selection across all Cocoa platforms).
(+[WKWebView _stringForFind]):
(+[WKWebView _setStringForFind:]):
Call into find-in-page helper functions.
(-[WKWebView _findString:options:maxCount:]):
On iOS, additionally update the find-in-page string when exercising the _findString:options:maxCount: SPI. This
mirrors macOS behavior of updating the find pasteboard every time the find string changes; however, on macOS,
this is implemented by the platform (in AppKit), whereas there's no platform find pasteboard on iOS, let alone
logic to update it in UIKit. As such, we directly drive updates to the find string within WebKit.
- UIProcess/API/Cocoa/WKWebViewPrivate.h:
Add some new cross-platform find-in-page SPI. See above for more details.
- UIProcess/Cocoa/GlobalFindInPageState.h: Added.
- UIProcess/Cocoa/GlobalFindInPageState.mm: Added.
(WebKit::findPasteboard):
(WebKit::globalStringForFind):
Fetch the string to use when finding text in the page. On macOS, this accesses the AppKit find pasteboard; on
iOS, this instead returns the current global find string.
(WebKit::updateStringForFind):
Sets the global find string. Uses the find pasteboard on macOS, and sets the global find string on iOS.
(WebKit::stringForFind):
- UIProcess/WebPageProxy.h:
- UIProcess/WebPageProxy.messages.in:
Add plumbing to allow WebEditorClient to deliver the update the global find string in the UI process.
- UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::updateStringForFind):
- WebKit.xcodeproj/project.pbxproj:
- WebProcess/WebCoreSupport/WebEditorClient.h:
- WebProcess/WebCoreSupport/ios/WebEditorClientIOS.mm:
(WebKit::WebEditorClient::updateStringForFind):
- WebProcess/WebPage/WebPage.h:
- WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::updateStringForFind):
Source/WebKitLegacy/mac:
Add a method stub for WebKitLegacy.
- WebCoreSupport/WebEditorClient.h:
Tools:
Add a new API test to verify that the new WebKit SPI (_stringForFind, _takeFindStringFromSelection:, and
_setStringForFind) works as expected.
- TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- TestWebKitAPI/Tests/WebKitCocoa/UseSelectionAsFindString.mm: Added.
- 7:48 PM Changeset in webkit [239583] by
-
- 12 edits2 adds in trunk
Web Inspector: Implement
queryObjectsCommand Line API
https://bugs.webkit.org/show_bug.cgi?id=176766
<rdar://problem/34890689>
Reviewed by Joseph Pecoraro.
Source/JavaScriptCore:
Introduces a new Command Line function called
queryObjectsthat will return an array of
object that have the given constructor/prototype argument in their prototype chain.
queryObjects(Promise)will return an array of all Promises.queryObjects(Foo)will return all objects created with the constructorFoo.
Currently, an error is thrown if the first argument is one of the following:
- Object
- Object.prototype
- Function
- Function.prototype
- Array
- Array.prototype
- Map
- Map.prototype
- Set
- Set.prototype
- Proxy
The reason for this is that we don't want to expose any internal/builtin objects, as some of
them are highly sensitive and undefined behaviour can occur if they are modified.
- inspector/JSInjectedScriptHost.h:
- inspector/JSInjectedScriptHost.cpp:
(Inspector::checkForbiddenPrototype): Added.
(Inspector::JSInjectedScriptHost::queryObjects): Added.
Does a GC and then iterates over all live JSCell in the heap to find these objects.
- inspector/JSInjectedScriptHostPrototype.cpp:
(Inspector::JSInjectedScriptHostPrototype::finishCreation):
(Inspector::jsInjectedScriptHostPrototypeFunctionQueryObjects): Added.
- inspector/InjectedScriptSource.js:
(queryObjects): Added.
- runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::promisePrototype): Added.
Source/WebCore:
Test: inspector/console/queryObjects.html
- inspector/CommandLineAPIModuleSource.js:
(CommandLineAPI):
(CommandLineAPIImpl.prototype.queryObjects): Added.
Source/WebInspectorUI:
- UserInterface/Controllers/JavaScriptRuntimeCompletionProvider.js:
(WI.JavaScriptRuntimeCompletionProvider.completionControllerCompletionsNeeded.receivedPropertyNames):
AddqueryObjectsto the list of command line functions.
LayoutTests:
- inspector/console/queryObjects-expected.html: Added.
- inspector/console/queryObjects.html: Added.
- http/tests/inspector/console/cross-domain-inspected-node-access-expected.txt:
- 4:48 PM Changeset in webkit [239582] by
-
- 2 edits in trunk/Tools
[ews-build] Use git on OpenSource EWS bots
https://bugs.webkit.org/show_bug.cgi?id=193092
Reviewed by Lucas Forschler.
- BuildSlaveSupport/ews-build/steps.py:
(CheckOutSource): Use git instead of svn.
(CheckOutSource.init): Use timeout of 2 hours since the initial checkout might take a long time.
- 4:09 PM Changeset in webkit [239581] by
-
- 1 copy in tags/Safari-607.1.18
Tag Safari-607.1.18.
- 3:50 PM Changeset in webkit [239580] by
-
- 3 edits in trunk/Source/WebKit
Allow WebContent process access to some drawing-related IOKit properties
https://bugs.webkit.org/show_bug.cgi?id=193086
<rdar://problem/46568088>
Reviewed by Eric Carlson.
Update the iOS WebContent process sandbox to allow access to some IOKit properties
that are needed for drawing and media playback operations.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- WebProcess/com.apple.WebKit.WebContent.sb.in:
- 3:41 PM Changeset in webkit [239579] by
-
- 4 edits in trunk
Fix resourcetimingbufferfull bubbles attribute
https://bugs.webkit.org/show_bug.cgi?id=193087
Patch by Charles Vazac <cvazac@gmail.com> on 2019-01-02
Reviewed by Chris Dumez.
Source/WebCore:
This change is covered by web-platform-tests [1].
[1] https://github.com/web-platform-tests/wpt/blob/master/resource-timing/buffer-full-when-populate-entries.html#L20
- page/Performance.cpp:
(WebCore::Performance::resourceTimingBufferFullTimerFired):
LayoutTests:
- http/wpt/resource-timing/rt-performance-extensions.js:
(promise_test):
- 1:32 PM Changeset in webkit [239578] by
-
- 2 edits in trunk/Source/WebKit
Remove unused logging service
https://bugs.webkit.org/show_bug.cgi?id=193081
<rdar://problem/40414815>
Reviewed by Alexey Proskuryakov.
We don't use this logging service, so don't open an exception for it.
- Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
- 1:30 PM Changeset in webkit [239577] by
-
- 2 edits in trunk/Source/WebKit
Remove temporary workaround for CVMS code signing objects
https://bugs.webkit.org/show_bug.cgi?id=193079
<rdar://problem/40139202>
Reviewed by Alexey Proskuryakov.
- WebProcess/com.apple.WebProcess.sb.in:
- 1:22 PM Changeset in webkit [239576] by
-
- 7 edits in trunk/Source/WebCore
Rename LayerScrollCoordinationRole to ScrollCoordinationRole and make an enum class
https://bugs.webkit.org/show_bug.cgi?id=193010
Reviewed by Zalan Bujtas.
Move the enum LayerScrollCoordinationRole from RenderLayer.h to RenderLayerCompositor.h,
and make it an enum class.
- page/FrameView.cpp:
(WebCore::FrameView::scrollLayerID const):
- rendering/RenderLayer.h:
- rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::~RenderLayerBacking):
(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):
(WebCore::operator<<):
- rendering/RenderLayerBacking.h:
- rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateScrollCoordinatedStatus):
(WebCore::RenderLayerCompositor::removeFromScrollCoordinatedLayers):
(WebCore::scrollCoordinationRoleForNodeType):
(WebCore::RenderLayerCompositor::attachScrollingNode):
(WebCore::RenderLayerCompositor::detachScrollCoordinatedLayer):
(WebCore::RenderLayerCompositor::updateScrollCoordinatedLayer):
(WebCore::RenderLayerCompositor::willRemoveScrollingLayerWithBacking):
- rendering/RenderLayerCompositor.h:
- 1:09 PM Changeset in webkit [239575] by
-
- 2 edits in trunk/Source/WebCore
Don't spin up a CalcParser if the current token is not a function token
https://bugs.webkit.org/show_bug.cgi?id=193067
Reviewed by Zalan Bujtas.
Various functions in CSSPropertyParserHelpers fall back to trying to parse
a calc expression if the normal parsing fails. Don't do this unless the
current token is a function token, which should be slightly more efficient.
- css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeInteger):
(WebCore::CSSPropertyParserHelpers::consumePositiveIntegerRaw):
(WebCore::CSSPropertyParserHelpers::consumeNumberRaw):
(WebCore::CSSPropertyParserHelpers::consumeNumber):
(WebCore::CSSPropertyParserHelpers::consumeFontWeightNumber):
(WebCore::CSSPropertyParserHelpers::consumeLength):
(WebCore::CSSPropertyParserHelpers::consumePercent):
(WebCore::CSSPropertyParserHelpers::consumeLengthOrPercent):
(WebCore::CSSPropertyParserHelpers::consumeAngle):
(WebCore::CSSPropertyParserHelpers::consumeAngleOrPercent):
(WebCore::CSSPropertyParserHelpers::consumeTime):
- 12:53 PM Changeset in webkit [239574] by
-
- 22 edits22 deletes in trunk
Support css-color-4 rgb functions
https://bugs.webkit.org/show_bug.cgi?id=192321
Reviewed by Zalan Bujtas.
LayoutTests/imported/w3c:
New expected results.
- web-platform-tests/css/css-color/color-resolving-expected.txt:
- web-platform-tests/css/css-color/rgb-rounding-001-expected.txt:
Source/WebCore:
Support the new rgb()/rgba() syntax described in https://drafts.csswg.org/css-color/#rgb-functions.
The differences are:
- There is a new comma-free syntax, where the optional alpha is separated by a slash:
rgb(128 34 56)
rgb(128 34 56 / 50%)
- Floating point values are allowed, and rounded:
rgb(128.5 34.2 56.5) becomes rgb(129 34 57)
- rgba() is a pure alias for rgb(), so these are equivalent:
rgb(128 34 56 / 50%)
rgba(128 34 56 / 50%)
hsl()/hsla() parsing was already updated to this new syntax in r230861.
Tested by tests in imported/w3c/web-platform-tests/css/css-color/
- css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::clampRGBComponent):
(WebCore::CSSPropertyParserHelpers::parseRGBParameters):
(WebCore::CSSPropertyParserHelpers::parseColorFunction):
LayoutTests:
- TestExpectations: Unskip most of the WPT css-color rgb tests. Skip old imported WPT canvas tests.
- canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-1-expected.txt: Removed.
- canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-1.html: Removed.
- canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-2-expected.txt: Removed.
- canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-2.html: Removed.
- canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-5-expected.txt: Removed.
- canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-5.html: Removed.
- canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-7-expected.txt: Removed.
- canvas/philip/tests/2d.fillStyle.parse.invalid.rgb-7.html: Removed.
- canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-1-expected.txt: Removed.
- canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-1.html: Removed.
- canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-2-expected.txt: Removed.
- canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-2.html: Removed.
- canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-4-expected.txt: Removed.
- canvas/philip/tests/2d.fillStyle.parse.invalid.rgba-4.html: Removed.
- css3/calc/color-rgb-expected.txt:
- fast/canvas/gradient-addColorStop-with-invalid-color-expected.txt:
- fast/canvas/gradient-addColorStop-with-invalid-color.html: Remove a test that is no longer invalid.
- fast/css/rgb-float.html: Removed. This test is no longer value, since rgb() accepts floating point values.
- platform/gtk/css2.1/t040306-syntax-01-f-expected.txt:
- platform/gtk/fast/css/rgb-float-expected.png: Removed.
- platform/gtk/fast/css/rgb-float-expected.txt: Removed.
- platform/gtk/svg/hixie/perf/007-expected.txt:
- platform/ios/css2.1/t040306-syntax-01-f-expected.txt:
- platform/ios/fast/css/rgb-float-expected.txt: Removed.
- platform/mac/css2.1/t040306-syntax-01-f-expected.txt:
- platform/mac/fast/css/rgb-float-expected.png: Removed.
- platform/mac/fast/css/rgb-float-expected.txt: Removed.
- platform/mac/svg/hixie/perf/007-expected.txt:
- platform/win-future/svg/hixie/perf/007-expected.txt:
- platform/win/css2.1/t040306-syntax-01-f-expected.txt:
- platform/win/svg/hixie/perf/007-expected.txt:
- platform/wincairo/css2.1/t040306-syntax-01-f-expected.txt:
- platform/wincairo/fast/css/rgb-float-expected.txt: Removed.
- platform/wpe/css2.1/t040306-syntax-01-f-expected.txt:
- platform/wpe/fast/css/rgb-float-expected.txt: Removed.
- platform/wpe/svg/hixie/perf/007-expected.txt:
- svg/hixie/perf/007-expected.txt:
- 12:28 PM Changeset in webkit [239573] by
-
- 4 edits2 adds in trunk
REGRESSION (r239441): [iOS] Selection UI sometimes doesn't change after tapping "select all" in the callout bar
https://bugs.webkit.org/show_bug.cgi?id=193070
<rdar://problem/46921508>
Reviewed by Tim Horton.
Source/WebKit:
r239441 added logic to include an EditorState in the next layer tree commit when refocusing an element; this was
done to ensure that after tapping an element that has already been programmatically focused, we still send up-
to-date editor information to the UI process for the purposes of zooming to the selection rect, even if the
selection in the DOM is unchanged, since other aspects of the editor state may have changed since the element
was initially focused.
We currently try to flag the next layer tree commit by setting
m_hasPendingEditorStateUpdatetotrue.
However, this is problematic since we aren't guaranteed in all cases that a compositing flush has been
scheduled. In the case where it hasn't, we'll end up in a state where the editor state update flag has been set,
yet the update will not make it over to the UI process until something happens that forces a layer tree commit
(e.g. scrolling, pinch zooming). Worse still, if the selection is then programmatically changed from the web
process, we will bail from sending a subsequent editor state update to the UI process becauseWebPagethinks
that a pending editor state has already been scheduled. This manifests in selection UI not updating after
tapping "Select All" in the callout bar, if the callout bar was brought up by tapping near the selection (since
this refocuses the element).
To fix this, we adjust this logic in
WebPage::elementDidRefocusso that it sets the flag and then schedules a
compositing flush, but only if the user is actually interacting with the focused element (i.e., if the page
callsfocusrepeatedly, we won't continue to schedule compositing flushes).
Test: editing/selection/ios/change-selection-after-tapping-focused-element.html
- WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::elementDidRefocus):
(WebKit::WebPage::sendEditorStateUpdate):
(WebKit::WebPage::scheduleFullEditorStateUpdate):
Add a private helper method to schedule an editor state update by setting
m_hasPendingEditorStateUpdateto
trueand then scheduling a compositing layer flush. Also, add a FIXME aluding to the fact that scheduling an
entire compositing layer flush to send an editor state update is somewhat wasteful, and should be replaced by
just scheduling this work to be done before the next frame (see: <rdar://problem/36523583> for more detail).
We also use this helper method in a few places where we currently turn on the editor state flag and schedule a
subsequent compositing flush.
(WebKit::WebPage::sendPartialEditorStateAndSchedulePostLayoutUpdate):
- WebProcess/WebPage/WebPage.h:
LayoutTests:
Add a test to ensure that selection UI is shown after tapping on a focused element and then changing the
selection programmatically.
- editing/selection/ios/change-selection-after-tapping-focused-element-expected.txt: Added.
- editing/selection/ios/change-selection-after-tapping-focused-element.html: Added.
- 11:40 AM Changeset in webkit [239572] by
-
- 8 edits in trunk/Source
Unreviewed, rolling out r239524.
https://bugs.webkit.org/show_bug.cgi?id=193083
basic browsing seems not to work (Requested by thorton on
#webkit).
Reverted changeset:
"Expand use of sourceApplicationAuditData"
https://bugs.webkit.org/show_bug.cgi?id=192995
https://trac.webkit.org/changeset/239524
- 11:24 AM Changeset in webkit [239571] by
-
- 4 edits2 adds in trunk
Handle calc() expressions in gradient color stops
https://bugs.webkit.org/show_bug.cgi?id=193066
rdar://problem/46961985
Reviewed by Sam Weinig.
Source/WebCore:
Fix two issues that prevented calc() expressions from working in conic-gradient color stops,
for the angle or percent value. First, consumeAngleOrPercent() needs to look for CalculationCategory::Percent
calc values as well as angle ones.
Second, CSSPrimitiveValue::isAngle() needs to use primitiveType() (which takes calc into account),
just as isPx() etc do.
Test: fast/gradients/conic-calc-stop-position.html
- css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isAngle const):
- css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::consumeAngleOrPercent):
(WebCore::CSSPropertyParserHelpers::consumeGradientColorStops):
LayoutTests:
- fast/gradients/conic-calc-stop-position-expected.html: Added.
- fast/gradients/conic-calc-stop-position.html: Added.
- 10:50 AM Changeset in webkit [239570] by
-
- 2 edits in trunk/Tools
[lldb-webkit] Remove broken code to print WTF::OptionSet::m_storage
https://bugs.webkit.org/show_bug.cgi?id=193023
Reviewed by Simon Fraser.
The code to print WTF::OptionSet::m_storage as an item in the set never worked and does
not seem meaningful to fix because WTF::OptionSet::m_storage is just the sum of the printed
enumerator values. We should just remove this code.
- lldb/lldb_webkit.py:
(WTFOptionSetProvider.has_children):
(WTFOptionSetProvider.num_children):
(WTFOptionSetProvider.get_child_index):
(WTFOptionSetProvider.get_child_at_index):
- 9:59 AM Changeset in webkit [239569] by
-
- 23 edits in trunk/Source
SourceProviders should use an actual URL instead of a string
https://bugs.webkit.org/show_bug.cgi?id=192734
Reviewed by Yusuke Suzuki.
Source/JavaScriptCore:
This will be useful for the Module loader API in the future where
by default it will use the relative path from the referring module
to resolve dependencies.
I didn't change the JSC shell's urls to be absolute paths as it
caused problems with the stack traces in our Chakra tests. Since
the absolute paths included system directories the diff would
appear incorrect.
See: https://bugs.webkit.org/show_bug.cgi?id=193077
- API/JSBase.cpp:
(JSEvaluateScript):
(JSCheckScriptSyntax):
- API/JSScriptRef.cpp:
(OpaqueJSScript::create):
(OpaqueJSScript::OpaqueJSScript):
- API/glib/JSCContext.cpp:
(jsc_context_check_syntax):
- jsc.cpp:
(jscSource):
(GlobalObject::moduleLoaderFetch):
(functionCheckModuleSyntax):
(runWithOptions):
- parser/SourceCode.h:
(JSC::makeSource):
- parser/SourceProvider.cpp:
(JSC::SourceProvider::SourceProvider):
- parser/SourceProvider.h:
(JSC::SourceProvider::url const):
(JSC::StringSourceProvider::create):
(JSC::StringSourceProvider::StringSourceProvider):
(JSC::WebAssemblySourceProvider::create):
(JSC::WebAssemblySourceProvider::WebAssemblySourceProvider):
- runtime/FunctionConstructor.cpp:
(JSC::constructFunctionSkippingEvalEnabledCheck):
- tools/CodeProfile.h:
(JSC::CodeProfile::CodeProfile):
- tools/FunctionOverrides.cpp:
(JSC::initializeOverrideInfo):
Source/WebCore:
Remove ScriptSourceCode's URL member and make the url() method
reference the URL on the SourceProvider. Also, avoid some
ref count churn.
Additionally, this patch fixes an existing bug in
WorkletGlobalScope() that would use a ScriptSourceCode after
WTFMoving it.
- bindings/js/CachedScriptSourceProvider.h:
(WebCore::CachedScriptSourceProvider::CachedScriptSourceProvider):
- bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute):
- bindings/js/ScriptController.cpp:
(WebCore::ScriptController::executeScriptInWorld):
(WebCore::ScriptController::executeScript):
- bindings/js/ScriptSourceCode.h:
(WebCore::ScriptSourceCode::ScriptSourceCode):
(WebCore::ScriptSourceCode::m_code):
(WebCore::ScriptSourceCode::url const):
(WebCore::ScriptSourceCode::m_url): Deleted.
- dom/ScriptElement.cpp:
(WebCore::ScriptElement::prepareScript):
(WebCore::ScriptElement::requestModuleScript):
(WebCore::ScriptElement::executePendingScript):
- html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::ensureMediaControlsInjectedScript):
- page/Frame.cpp:
(WebCore::Frame::injectUserScriptImmediately):
- workers/WorkerGlobalScope.cpp:
(WebCore::WorkerGlobalScope::importScripts):
- workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
- worklets/WorkletGlobalScope.cpp:
(WebCore::WorkletGlobalScope::WorkletGlobalScope):
- xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::endElementNs):
Jan 1, 2019:
- 5:37 PM WebKitGTK/AddingNewWebKit2API edited by
- Update reminder to add autocleanups when adding new types (diff)
- 11:29 AM Changeset in webkit [239568] by
-
- 15 edits in trunk
Update user-visible copyright strings to include 2019
https://bugs.webkit.org/show_bug.cgi?id=192811
Reviewed by Mark Lam.
Source/JavaScriptCore:
- Info.plist:
Source/WebCore:
- Info.plist:
Source/WebKit:
- Info.plist:
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-OSX.plist:
- NetworkProcess/EntryPoint/mac/XPCService/NetworkService/Info-iOS.plist:
- PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-OSX.plist:
- WebProcess/EntryPoint/mac/XPCService/WebContentService/Info-iOS.plist:
Source/WebKitLegacy/mac:
- Info.plist:
WebKitLibraries:
- win/tools/scripts/COPYRIGHT-END-YEAR:
Dec 31, 2018:
- 7:31 AM Changeset in webkit [239567] by
-
- 2 edits in trunk/Tools
.ycm_extra_conf.py should handle XXXInlines.h
https://bugs.webkit.org/show_bug.cgi?id=193055
Reviewed by Carlos Garcia Campos.
compile_commands.json database only records flags and options for cpp source files.
So, when we open headers, this database does not have any information for that.
Our .ycm_extra_conf.py alleviates this by using XXX.cpp's configuration for XXX.h.
But this mitigation does not handle XXXInlines.h well since we do not have XXXInlines.cpp.
This patch adds support for XXXInlines.h in .ycm_extra_conf.py. When XXXInlines.h is queried,
we attempt to find XXX.cpp and use the configuration if it exists.
- gtk/ycm_extra_conf.py:
(getImplementationFilename):
(FlagsForFile):
- 6:53 AM Changeset in webkit [239566] by
-
- 3 edits1 add in trunk
Unreviewed. Support PHP 7.3 in Debian.
Tools:
Add 7.3 to the list of php versions supported in Debian.
- Scripts/webkitpy/port/base.py:
(Port._debian_php_version):
LayoutTests:
- http/conf/debian-httpd-2.4-php7.3.conf: Added.
- 6:08 AM Changeset in webkit [239565] by
-
- 15 edits in trunk/LayoutTests
Unreviewed GTK+ gardening. Rebaseline several tests after r239156.
- platform/gtk/fast/frames/onlyCommentInIFrame-expected.txt:
- platform/gtk/fast/invalid/junk-data-expected.txt:
- platform/gtk/fast/invalid/missing-end-tag-expected.txt:
- platform/gtk/fast/parser/xhtml-alternate-entities-expected.txt:
- platform/gtk/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.png:
- platform/gtk/fast/sub-pixel/selection/selection-rect-in-sub-pixel-table-expected.txt:
- platform/gtk/fast/xsl/xslt-extra-content-at-end-expected.txt:
- platform/gtk/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
- platform/gtk/svg/custom/bug45331-expected.txt:
- platform/gtk/svg/custom/junk-data-expected.txt:
- platform/gtk/svg/custom/missing-xlink-expected.txt:
- platform/gtk/svg/custom/path-bad-data-expected.txt:
- platform/gtk/svg/custom/use-font-face-crash-expected.txt:
- platform/gtk/svg/hixie/error/012-expected.txt:
- 5:36 AM Changeset in webkit [239564] by
-
- 4 edits11 adds in trunk/LayoutTests
Unreviewed GTK+ gardening. Rebaseline several tests after r238730.
innerText works differently when using complex text path.
See https://bugs.webkit.org/show_bug.cgi?id=192750.
- platform/gtk/fast/events/nested-window-event-expected.txt: Added.
- platform/gtk/fast/events/window-events-bubble-expected.txt: Added.
- platform/gtk/fast/events/window-events-bubble2-expected.txt: Added.
- platform/gtk/fast/tokenizer/script_extra_close-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-015-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/css/css-grid/alignment/grid-row-axis-alignment-positioned-items-016-expected.txt: Added.
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/constraints/form-validation-willValidate-expected.txt:
- platform/gtk/imported/w3c/web-platform-tests/html/semantics/forms/the-input-element/selection-expected.txt:
- platform/gtk/legacy-animation-engine/animations/lineheight-animation-expected.txt: Added.
- platform/gtk/legacy-animation-engine/animations/simultaneous-start-transform-expected.txt: Added.
- platform/gtk/legacy-animation-engine/animations/width-using-ems-expected.txt: Added.
Dec 30, 2018:
- 1:56 PM Changeset in webkit [239563] by
-
- 3 edits in trunk/Source/WebCore
clang-tidy: Save 8 padding bytes on WebCore::BorderEdge
<https://webkit.org/b/193058>
<rdar://problem/46979275>
Reviewed by Yusuke Suzuki.
- rendering/BorderEdge.cpp:
(WebCore::BorderEdge::BorderEdge): Reorder initialization to
match new instance variable order.
- rendering/BorderEdge.h: Reorder instance variables to save
8 padding bytes.
- 1:23 PM Changeset in webkit [239562] by
-
- 2 edits in trunk
gperf is only used in WebCore
https://bugs.webkit.org/show_bug.cgi?id=193061
Reviewed by Don Olmstead.
gperf is only used in WebCore. So if the port does not have WebCore,
it is not necessary. For example, JSCOnly port does not require it.
This patch removes gperf dependency in these ports by checking
ENABLE_WEBCORE.
- Source/cmake/WebKitCommon.cmake:
- 1:19 PM Changeset in webkit [239561] by
-
- 5 edits in trunk
Add ENABLE_UNIFIED_BUILDS option to cmake ports
https://bugs.webkit.org/show_bug.cgi?id=193045
Reviewed by Don Olmstead.
.:
This patch adds ENABLE_UNIFIED_BUILDS option to cmake ports, which allows us to disable Unified Builds in WebKit.
This makescompile_commands.jsonsane when the unified builds is disabled, and various tools can use this
compilation database. For example, YouCompleteMe completion server can use it.
- Source/cmake/WebKitFeatures.cmake:
- Source/cmake/WebKitMacros.cmake:
Source/WTF:
- Scripts/generate-unified-source-bundles.rb:
- 12:53 PM Changeset in webkit [239560] by
-
- 2 edits in trunk/JSTests
Unreviewed, JSTests gardening with memoryLimited
- stress/string-overflow-createError.js:
- 9:38 AM Changeset in webkit [239559] by
-
- 33 edits in trunk
[JSC] Identifier validity should be based on ID_Start / ID_Continue properties
https://bugs.webkit.org/show_bug.cgi?id=193050
Reviewed by Yusuke Suzuki.
JSTests:
- test262.yaml:
- test262/expectations.yaml:
Mark 16 tests as passing.
Source/JavaScriptCore:
From https://tc39.github.io/ecma262/#sec-names-and-keywords:
- UnicodeIDStart
- any Unicode code point with the Unicode property "ID_Start"
- UnicodeIDContinue
- any Unicode code point with the Unicode property "ID_Continue"
- parser/Lexer.cpp:
(JSC::Lexer<T>::Lexer):
(JSC::isNonLatin1IdentStart):
(JSC::isNonLatin1IdentPart):
(JSC::isIdentPart):
(JSC::Lexer<T>::lex):
Ensure identifier start / part is based on ID_Start / ID_Continue.
(Implies a special case for U+00B7, which is Latin-1 but Other_ID_Continue.)
LayoutTests:
- sputnik/Unicode/Unicode_218/S7.6_A1.1_T2-expected.txt:
- sputnik/Unicode/Unicode_218/S7.6_A1.1_T6-expected.txt:
- sputnik/Unicode/Unicode_218/S7.6_A5.2_T2-expected.txt:
- sputnik/Unicode/Unicode_218/S7.6_A5.2_T6-expected.txt:
- sputnik/Unicode/Unicode_218/S7.6_A5.3_T1-expected.txt:
- sputnik/Unicode/Unicode_218/S7.6_A5.3_T2-expected.txt:
- sputnik/Unicode/Unicode_320/S7.6_A1.1_T6-expected.txt:
- sputnik/Unicode/Unicode_320/S7.6_A2.3-expected.txt:
- sputnik/Unicode/Unicode_320/S7.6_A3.1-expected.txt:
- sputnik/Unicode/Unicode_320/S7.6_A5.2_T6-expected.txt:
- sputnik/Unicode/Unicode_320/S7.6_A5.2_T9-expected.txt:
- sputnik/Unicode/Unicode_320/S7.6_A5.3_T1-expected.txt:
- sputnik/Unicode/Unicode_320/S7.6_A5.3_T2-expected.txt:
- sputnik/Unicode/Unicode_410/S7.6_A1.1_T6-expected.txt:
- sputnik/Unicode/Unicode_410/S7.6_A3.1-expected.txt:
- sputnik/Unicode/Unicode_410/S7.6_A5.2_T6-expected.txt:
- sputnik/Unicode/Unicode_410/S7.6_A5.3_T1-expected.txt:
- sputnik/Unicode/Unicode_410/S7.6_A5.3_T2-expected.txt:
- sputnik/Unicode/Unicode_500/S7.6_A1.1_T6-expected.txt:
- sputnik/Unicode/Unicode_500/S7.6_A3.1-expected.txt:
- sputnik/Unicode/Unicode_500/S7.6_A5.2_T6-expected.txt:
- sputnik/Unicode/Unicode_500/S7.6_A5.3_T1-expected.txt:
- sputnik/Unicode/Unicode_500/S7.6_A5.3_T2-expected.txt:
- sputnik/Unicode/Unicode_510/S7.6_A1.1_T4-expected.txt:
- sputnik/Unicode/Unicode_510/S7.6_A1.1_T6-expected.txt:
- sputnik/Unicode/Unicode_510/S7.6_A5.2_T4-expected.txt:
- sputnik/Unicode/Unicode_510/S7.6_A5.2_T6-expected.txt:
Update expectations for outdated tests.
